Don't assume that stated character widths fit in int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5637687f
PE
12011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2
3 Don't assume that stated character widths fit in int.
4 * character.c (Fchar_width, c_string_width, lisp_string_width):
5 * character.h (CHAR_WIDTH):
6 * indent.c (MULTIBYTE_BYTES_WIDTH):
7 Use sanitize_char_width to avoid undefined and/or bad behavior
8 with outlandish widths.
9 * character.h (sanitize_tab_width): Renamed from sanitize_width,
10 now that we have two such functions. All uses changed.
11 (sanitize_char_width): New inline function.
12
caeeedc1
PE
132011-07-18 Paul Eggert <eggert@cs.ucla.edu>
14
a2271ba2
PE
15 Don't assume that tab-width fits in int.
16 * character.h (sanitize_width): New inline function.
17 (SANE_TAB_WIDTH): New macro.
18 (ASCII_CHAR_WIDTH): Use it.
19 * indent.c (sane_tab_width): Remove. All uses replaced by
20 SANE_TAB_WIDTH (current_buffer).
21 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
22
18c52557
PE
23 * fileio.c: Integer overflow issues with file modes.
24 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
25
caeeedc1
PE
26 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
27 Remove unreachable code.
28 (read_hex, load_charset_map_from_file): Check for integer overflow.
29
b1f367f7 302011-07-17 Paul Eggert <eggert@cs.ucla.edu>
13464394 31
50849c52
PE
32 * xterm.c: don't go over XClientMessageEvent limit
33 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
34 (x_send_scroll_bar_event): Likewise. Check that the size does not
35 exceed limits imposed by XClientMessageEvent, as well as the usual
36 ptrdiff_t and size_t limits.
37
b13995db
PE
38 * keyboard.c: Overflow, signedness and related fixes.
39 (make_lispy_movement): Use same integer type in forward decl
40 that is used in the definition.
41 (read_key_sequence, keyremap_step):
42 Change bufsize argument back to int, undoing my 2011-03-30 change.
43 We prefer signed types, and int is wide enough here.
44 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
45 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
46 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
47 length, not size_t. Use ptrdiff_t for index, not int.
48 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
49 possibility of integer overflow.
50
13464394
PE
51 Overflow, signedness and related fixes for images.
52
53 * dispextern.h (struct it.stack[0].u.image.image_id)
54 (struct_it.image_id, struct image.id, struct image_cache.size)
55 (struct image_cache.used, struct image_cache.ref_count):
56 * gtkutil.c (update_frame_tool_bar):
57 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
58 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
59 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
60 * nsmenu.m (update_frame_tool_bar):
61 * xdisp.c (calc_pixel_width_or_height):
62 * xfns.c (image_cache_refcount):
63 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
64 on typical 64-bit hosts.
65
66 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
67 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
68 Omit unnecessary casts to int.
69 (parse_image_spec): Check that integers fall into 'int' range
70 when the callers expect that.
71 (image_ascent): Redo ascent calculation to avoid int overflow.
72 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
73 (lookup_image): Remove unnecessary tests.
74 (xbm_image_p): Locals are now of int, not EMACS_INT,
75 since parse_image_check makes sure they fit into int.
76 (png_load, gif_load, svg_load_image):
77 Prefer int to unsigned where either will do.
78 (tiff_handler): New function, combining the cores of the
79 old tiff_error_handler and tiff_warning_handler. This
80 function is rewritten to use vsnprintf and thereby avoid
81 stack buffer overflows. It uses only the features of vsnprintf
82 that are common to both POSIX and native Microsoft.
83 (tiff_error_handler, tiff_warning_handler): Use it.
84 (tiff_load, gif_load, imagemagick_load_image):
85 Don't assume :index value fits in 'int'.
86 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
87 (imagemagick_load_image): Check that crop parameters fit into
88 the integer types that MagickCropImage accepts. Don't assume
89 Vimagemagick_render_type has a nonnegative value. Don't assume
90 size_t fits in 'long'.
91 (gs_load): Use printmax_t to print the widest integers possible.
92 Check for integer overflow when computing image height and width.
93
4f8a4547 942011-07-17 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 95
41f55ccd 96 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 97
39e378da
PE
98 * bidi.c: Integer size and overflow fixes.
99 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
100 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
101 (bidi_cache_find_level_change, bidi_cache_ensure_space)
102 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
103 (bidi_find_other_level_edge):
104 Use ptrdiff_t instead of EMACS_INT where either will do.
105 This works better on 32-bit hosts configured --with-wide-int.
106 (bidi_cache_ensure_space): Check for size-calculation overflow.
107 Use % rather than repeated addition, for better worst-case speed.
108 Don't set bidi_cache_size until after xrealloc returns, because it
109 might not return.
110 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
111 (bidi_cache_ensure_space): Also check that the bidi cache size
112 does not exceed that of the largest Lisp string or buffer. See Eli
113 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 114
5e927815
PE
115 * alloc.c (__malloc_size_t): Remove.
116 All uses replaced by size_t. See Andreas Schwab's note
117 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
118
ca4aa935
PE
119 * image.c: Improve checking for integer overflow.
120 (check_image_size): Assume that f is nonnull, since
121 it is always nonnull in practice. This is one less thing to
122 worry about when checking for integer overflow later.
123 (x_check_image_size): New function, which checks for integer
124 overflow issues inside X.
125 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
126 This removes the need for a memory_full check.
127 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
128 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
129 (xbm_read_bitmap_data): Change locals back to 'int', since
130 their values must fit in 'int'.
131 (xpm_load_image, png_load, tiff_load):
132 Invoke x_create_x_image_and_pixmap earlier,
133 to avoid much needless work if the image is too large.
134 (tiff_load): Treat overly large images as if
135 x_create_x_image_and_pixmap failed, not as malloc failures.
136 (gs_load): Use x_check_image_size.
137
5f8f9cc2
PE
138 * gtkutil.c: Omit integer casts.
139 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
140 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
141
5adf60bc
PE
142 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
143
c8907a93
PE
144 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
145 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
146 would wrongly return t on a 64-bit host.
147
e3c25c68
PE
148 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
149 The plain *_OVERFLOW macros run afoul of GCC bug 49705
150 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
151 and therefore cause GCC to emit a bogus diagnostic in some cases.
152
3f791afe
PE
153 * image.c: Integer signedness and overflow and related fixes.
154 This is not an exhaustive set of fixes, but it's time to
155 record what I've got.
156 (lookup_pixel_color, check_image_size): Remove redundant decls.
157 (check_image_size): Don't assume that arbitrary EMACS_INT values
158 fit in 'int', or that arbitrary 'double' values fit in 'int'.
159 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
160 (tiff_load, imagemagick_load_image):
161 Check for overflow in size calculations.
162 (x_create_x_image_and_pixmap): Remove unnecessary test for
163 xmalloc returning NULL; that can't happen.
164 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
165 (xpm_color_bucket): Use better integer hashing function.
166 (xpm_cache_color): Don't possibly over-allocate memory.
167 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
168 (gif_memory_source):
169 Use ptrdiff_t, not int or size_t, to record sizes.
170 (png_load): Don't assume values greater than 2**31 fit in 'int'.
171 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
172 either works, as we prefer signed integers.
173 (tiff_read_from_memory, tiff_write_from_memory):
174 Return tsize_t, not size_t, since that's what the TIFF API wants.
175 (tiff_read_from_memory): Don't fail simply because the read would
176 go past EOF; instead, return a short read.
177 (tiff_load): Omit no-longer-needed casts.
178 (Fimagemagick_types): Don't assume size fits into 'int'.
179
3cc5a532
PE
180 Improve hashing quality when configured --with-wide-int.
181 * fns.c (hash_string): New function, taken from sxhash_string.
182 Do not discard information about ASCII character case; this
183 discarding is no longer needed.
184 (sxhash-string): Use it. Change sig to match it. Caller changed.
185 * lisp.h: Declare it.
186 * lread.c (hash_string): Remove, since we now use fns.c's version.
187 The fns.c version returns a wider integer if --with-wide-int is
188 specified, so this should help the quality of the hashing a bit.
189
b312a492
PE
190 * emacs.c: Integer overflow minor fix.
191 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
192 Define only if GNU_LINUX.
193 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
194
dfd153ae
PE
195 * dispnew.c: Integer signedness and overflow fixes.
196 Remove unnecessary forward decls, that were a maintenance hassle.
197 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
198 All uses changed.
199 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
200 (scrolling_window): Use ptrdiff_t, not int, for byte count.
201 (prepare_desired_row, line_draw_cost):
202 Use int, not unsigned, where either works.
203 (save_current_matrix, restore_current_matrix):
204 Use ptrdiff_t, not size_t, where either works.
205 (init_display): Check for overflow more accurately, and without
206 relying on undefined behavior.
207
a81d11a3
PE
208 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
209 Remove, replacing with the new symbols in lisp.h. All uses changed.
210 * fileio.c (make_temp_name):
211 * filelock.c (lock_file_1, lock_file):
212 * xdisp.c (message_dolog):
213 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
214 Use pMd etc. instead.
215 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
216 replacing the pWIDE etc. symbols removed from editfns.c.
217
3300e6fd
PE
218 * keyboard.h (num_input_events): Now uintmax_t.
219 This is (very slightly) less likely to mess up due to wraparound.
220 All uses changed.
221
fd05c7e9
PE
222 * buffer.c: Integer signedness fixes.
223 (alloc_buffer_text, enlarge_buffer_text):
224 Use ptrdiff_t rather than size_t when either will do, as we prefer
225 signed integers.
226
903fe15d
PE
227 * alloc.c: Integer signedness and overflow fixes.
228 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
229 (__malloc_size_t): Default to size_t, not to int.
230 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
231 (Fgarbage_collect, mark_object_loop_halt, mark_object):
232 Prefer ptrdiff_t to size_t when either would do, as we prefer
233 signed integers.
234 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
235 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
236 Now const. Initialize with values that are in range even if char
237 is signed.
238 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
239 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
240 These functions do the right thing with sizes > 2**32.
241 (check_depth): Now ptrdiff_t, not int.
242 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
243 Adjust to new way of storing sizes. Check for size overflow bugs
244 in rest of code.
245 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
246 slightly wrong anyway, as it missed one instance of
247 XMALLOC_OVERRUN_CHECK_OVERHEAD.
248 (refill_memory_reserve): Omit needless cast to size_t.
249 (mark_object_loop_halt): Mark as externally visible.
250
ac82cc6a
PE
251 * xselect.c: Integer signedness and overflow fixes.
252 (Fx_register_dnd_atom, x_handle_dnd_message):
253 Use ptrdiff_t, not size_t, since we prefer signed.
254 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
255 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
256 x_dnd_atoms_size and x_dnd_atoms_length.
257
c2d1e36d
PE
258 * doprnt.c: Prefer signed to unsigned when either works.
259 * eval.c (verror):
260 * doprnt.c (doprnt):
261 * lisp.h (doprnt):
262 * xdisp.c (vmessage):
263 Use ptrdiff_t, not size_t, when using or implementing doprnt,
264 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
265 prefer signed arithmetic to avoid comparison confusion.
266 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
267 but is a bit tricky.
268
0e926e56
PE
269 Assume freestanding C89 headers, string.h, stdlib.h.
270 * data.c, doprnt.c, floatfns.c, print.c:
271 Include float.h unconditionally.
272 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
273 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
274 * regex.c: Likewise for stddef.h, string.h.
275 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
276 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
277 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
278 (STDC_HEADERS): Remove obsolete defines.
279 * sysdep.c: Include limits.h unconditionally.
280
9cfdb3ec
PE
281 Assume support for memcmp, memcpy, memmove, memset.
282 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
283 * regex.c (memcmp, memcpy):
284 Remove; we assume C89 now.
285
286 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
287 (__malloc_safe_bcopy): Remove; no longer needed.
288
cf950e6b 289 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
290 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
291 well either way, and we prefer signed to unsigned.
292
9e381cdd
PE
2932011-07-17 Paul Eggert <eggert@cs.ucla.edu>
294
295 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
296 This works around a problem with the previous change to Fcopy_file.
297 Recent glibc declares fchown with __attribute__((warn_unused_result)),
298 and without this change, GCC might complain about discarding
299 fchown's return value.
300
b5641435
JB
3012011-07-16 Juanma Barranquero <lekktu@gmail.com>
302
303 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
304
a8031457
PE
3052011-07-16 Paul Eggert <eggert@cs.ucla.edu>
306
307 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
308
dd889327
LMI
3092011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
310
750c33f7
LMI
311 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
312 it's used from the C level.
313
dd889327
LMI
314 * process.c: Use the same condition for POLL_FOR_INPUT in both
315 keyboard.c and process.c (bug#1858).
316
87e86684
LM
3172011-07-09 Lawrence Mitchell <wence@gmx.li>
318
319 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
320 (Fgnutls_boot): Use it.
321
64348f40
AS
3222011-07-15 Andreas Schwab <schwab@linux-m68k.org>
323
324 * doc.c (Fsubstitute_command_keys): Revert last change.
325
1d698799
LMI
3262011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
327
f863868c
LMI
328 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
329 quotes the next character, and doesn't affect other longer
330 sequences (bug#8935).
331
1d698799
LMI
332 * lread.c (syms_of_lread): Clarify that is isn't only
333 `eval-buffer' and `eval-defun' that's affected by
334 `lexical-binding' (bug#8460).
335
aa4b6df6
EZ
3362011-07-15 Eli Zaretskii <eliz@gnu.org>
337
338 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
339 bidi redisplay when a line includes both an image and is
340 truncated.
341
5d856da6
PE
3422011-07-14 Paul Eggert <eggert@cs.ucla.edu>
343
ad6042bb
PE
344 Fix minor problems found by static checking.
345 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
346 (elsz): Now a signed constant, not a size_t var. We prefer signed
347 types to unsigned, to avoid integer comparison confusion. Without
348 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
349 "cannot optimize loop, the loop counter may overflow", a symptom
350 of the confusion.
f00bbb22 351 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
352 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
353
6468f31c
LMI
3542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
355
49080b10
LMI
356 * search.c (Fre_search_backward): Mention `case-fold-search' in
357 all the re_search_* functions (bug#8138).
358
6468f31c
LMI
359 * keyboard.c (Fopen_dribble_file): Document when the file is
360 closed (bug#8056).
361
c965adc5
EZ
3622011-07-14 Eli Zaretskii <eliz@gnu.org>
363
df9733bf
EZ
364 * bidi.c (bidi_dump_cached_states): Fix format of displaying
365 bidi_cache_idx.
366
0bb23927
EZ
367 Support bidi reordering of display and overlay strings.
368 * xdisp.c (compute_display_string_pos)
369 (compute_display_string_end): Accept additional argument STRING.
370 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
371 (reseat_to_string): Initialize bidi_it->string.s and
372 bidi_it->string.schars.
373 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
374 NULL (avoids a crash in bidi_paragraph_init). Initialize
375 itb.string.lstring.
376 (init_iterator): Call bidi_init_it only of a valid
377 buffer position was specified. Initialize paragraph_embedding to
378 L2R.
379 (reseat_to_string): Initialize the bidi iterator.
380 (display_string): If we need to ignore text properties of
381 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
382 original value of -1 will not work with bidi.)
383 (compute_display_string_pos): First arg is now struct
384 `text_pos *'; all callers changed. Support display properties on
385 Lisp strings.
386 (compute_display_string_end): Support display properties on Lisp
387 strings.
388 (init_iterator, reseat_1, reseat_to_string): Initialize the
389 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
390 when iterating on a string not from display properties).
391 (compute_display_string_pos, compute_display_string_end): Fix
392 calculation of the object to scan. Fixes an error when using
393 arrow keys.
394 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
395 base_level_stop; instead, set base_level_stop to BEGV. Fixes
396 crashes in vertical-motion.
397 (next_element_from_buffer): Improve commentary for when
398 the iterator is before prev_stop.
399 (init_iterator): Initialize bidi_p from the default value of
400 bidi-display-reordering, not from buffer-local value. Use the
401 buffer-local value only if initializing for buffer iteration.
402 (handle_invisible_prop): Support invisible properties on strings
403 that are being bidi-reordered.
404 (set_iterator_to_next): Support bidi reordering of C strings and
405 Lisp strings.
406 (next_element_from_string): Support bidi reordering of Lisp
407 strings.
408 (handle_stop_backwards): Support Lisp strings as well.
409 (display_string): Support display of R2L glyph rows. Use
410 IT_STRING_CHARPOS when displaying from a Lisp string.
411 (init_iterator): Don't initialize it->bidi_p for strings
412 here.
413 (reseat_to_string): Initialize it->bidi_p for strings here.
414 (next_element_from_string, next_element_from_c_string)
415 (next_element_from_buffer): Add xassert's for correspondence
416 between IT's object being iterated and it->bidi_it.string
417 structure.
418 (face_before_or_after_it_pos): Support bidi iteration.
419 (next_element_from_c_string): Handle the case of the first string
420 character that is not the first one in the visual order.
421 (get_visually_first_element): New function, refactored from common
422 parts of next_element_from_buffer, next_element_from_string, and
423 next_element_from_c_string.
424 (tool_bar_lines_needed, redisplay_tool_bar)
425 (display_menu_bar): Force left-to-right direction. Add a FIXME
426 comment for making that be controlled by a user option.
427 (push_it, pop_it): Save and restore the state of the
428 bidi iterator. Save and restore the bidi_p flag.
429 (pop_it): Iterate out of display property for string iteration as
430 well.
431 (iterate_out_of_display_property): Support iteration over strings.
432 (handle_single_display_spec): Set up it->bidi_it for iteration
433 over a display string, and call bidi_init_it.
434 (handle_single_display_spec, next_overlay_string)
435 (get_overlay_strings_1, push_display_prop): Set up the bidi
436 iterator for displaying display or overlay strings.
437 (forward_to_next_line_start): Don't use the shortcut if
438 bidi-iterating.
439 (back_to_previous_visible_line_start): If handle_display_prop
440 pushed the iterator stack, restore the internal state of the bidi
441 iterator by calling bidi_pop_it same number of times.
442 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
443 and we are bidi-iterating, don't decrement the iterator position;
444 instead, set the first_elt flag in the bidi iterator, to produce
445 the same effect.
446 (reseat_1): Remove redundant setting of string_from_display_prop_p.
447 (push_display_prop): xassert that we are iterating a buffer.
448 (push_it, pop_it): Save and restore paragraph_embedding member.
449 (handle_single_display_spec, next_overlay_string)
450 (get_overlay_strings_1, reseat_1, reseat_to_string)
451 (push_display_prop): Set up the `unibyte' member of bidi_it.string
452 correctly. Don't assume unibyte strings are not bidi-reordered.
453 (compute_display_string_pos)
454 (compute_display_string_end): Fix handling the case of C string.
455 (push_it, pop_it): Save and restore from_disp_prop_p.
456 (handle_single_display_spec, push_display_prop): Set the
457 from_disp_prop_p flag.
458 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
459 (pop_it): Call iterate_out_of_display_property only if we are
460 popping after iteration over a string that came from a display
461 property. Fix a typo in popping stretch info. Add an assertion
462 for verifying that the iterator position is in sync with the bidi
463 iterator.
464 (handle_single_display_spec, get_overlay_strings_1)
465 (push_display_prop): Fix initialization of paragraph direction for
466 string when that of the parent object is not yet determined.
467 (reseat_1): Call bidi_init_it to resync the bidi
468 iterator with IT's position. (Bug#7616)
469 (find_row_edges): If ROW->start.pos gives position
470 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
471 (handle_stop, back_to_previous_visible_line_start, reseat_1):
472 Reset the from_disp_prop_p flag.
473 (SAVE_IT, RESTORE_IT): New macros.
474 (pos_visible_p, face_before_or_after_it_pos)
475 (back_to_previous_visible_line_start)
476 (move_it_in_display_line_to, move_it_in_display_line)
477 (move_it_to, move_it_vertically_backward, move_it_by_lines)
478 (try_scrolling, redisplay_window, display_line): Use them when
479 saving a temporary copy of the iterator and restoring it back.
480 (back_to_previous_visible_line_start, reseat_1)
481 (init_iterator): Empty the bidi cache "stack".
482 (move_it_in_display_line_to): If iterator ended up at
483 EOL, but we never saw any buffer positions smaller than
484 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
485 motion in bidi-reordered lines.
486 (move_it_in_display_line_to): Record prev_method and prev_pos
487 immediately before the call to set_iterator_to_next. Fixes cursor
488 motion in bidi-reordered lines with stretch glyphs and strings
489 displayed in margins. (Bug#8133) (Bug#8867)
490 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
491 TO_CHARPOS.
492 (pos_visible_p): Support positions in bidi-reordered lines. Save
493 and restore bidi cache.
494
495 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
496 (bidi_paragraph_info): Delete unused struct.
497 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
498 (bidi_cache_start): New variable.
499 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
500 to zero.
501 (bidi_cache_fetch_state, bidi_cache_search)
502 (bidi_cache_find_level_change, bidi_cache_iterator_state)
503 (bidi_cache_find, bidi_peek_at_next_level)
504 (bidi_level_of_next_char, bidi_find_other_level_edge)
505 (bidi_move_to_visually_next): Compare cache index with
506 bidi_cache_start rather than with zero.
507 (bidi_fetch_char): Accept new argument STRING; all callers
508 changed. Support iteration over a string. Support strings with
509 display properties. Support unibyte strings. Fix the type of
510 `len' according to what STRING_CHAR_AND_LENGTH expects.
511 (bidi_paragraph_init, bidi_resolve_explicit_1)
512 (bidi_resolve_explicit, bidi_resolve_weak)
513 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
514 iteration over a string.
515 (bidi_set_sor_type, bidi_resolve_explicit_1)
516 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
517 can now be zero (for strings); special values 0 and -1 were
518 changed to -1 and -2, respectively.
519 (bidi_char_at_pos): New function.
520 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
521 Call it instead of FETCH_MULTIBYTE_CHAR.
522 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
523 initialized to valid values.
524 (bidi_init_it): Don't initialize charpos and bytepos with invalid
525 values.
526 (bidi_level_of_next_char): Allow the sentinel "position" to pass
527 the test for valid cached positions. Fix the logic for looking up
528 the sentinel state in the cache. GCPRO the Lisp string we are
529 iterating.
530 (bidi_push_it, bidi_pop_it): New functions.
531 (bidi_initialize): Initialize the bidi cache start stack pointer.
532 (bidi_cache_ensure_space): New function, refactored from part of
533 bidi_cache_iterator_state. Don't assume the required size is just
534 one BIDI_CACHE_CHUNK away.
535 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
536 (bidi_count_bytes, bidi_char_at_pos): New functions.
537 (bidi_cache_search): Don't assume bidi_cache_last_idx is
538 always valid if bidi_cache_idx is valid.
539 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
540 is valid if it's going to be used.
541 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
542 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
543 (bidi_cache_find_level_change, bidi_cache_ensure_space)
544 (bidi_cache_iterator_state, bidi_cache_find)
545 (bidi_find_other_level_edge, bidi_cache_start_stack): All
546 variables related to cache indices are now EMACS_INT.
547
0bb23927
EZ
548 * dispextern.h (struct bidi_string_data): New structure.
549 (struct bidi_it): New member `string'. Make flag members be 1-bit
550 fields, and put them last in the struct.
551 (compute_display_string_pos, compute_display_string_end): Update
552 prototypes.
553 (bidi_push_it, bidi_pop_it): Add prototypes.
554 (struct iterator_stack_entry): New members bidi_p,
555 paragraph_embedding, and from_disp_prop_p.
556 (struct it): Member bidi_p is now a bit field 1 bit wide.
557 (bidi_shelve_cache, bidi_unshelve_cache): Declare
558 prototypes.
559
560 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
561 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
562 and vector-like objects.
563
564 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
565 cache around display iteration.
566
567 * window.c (Fwindow_end, window_scroll_pixel_based)
568 (displayed_window_lines, Frecenter): Save and restore the bidi
569 cache around display iteration.
570
3bbd2265
LMI
5712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
572
573 * editfns.c (Fdelete_region): Clarify the use of the named
574 parameters (bug#6788).
575
adc47434
MR
5762011-07-14 Martin Rudalics <rudalics@gmx.at>
577
578 * indent.c (Fvertical_motion): Set and restore w->pointm when
579 saving and restoring the window's buffer (Bug#9006).
580
837c31f8
LMI
5812011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
582
583 * editfns.c (Fstring_to_char): Clarify just what is returned
584 (bug#6576). Text by Eli Zaretskii.
585
ac389d0c
JB
5862011-07-13 Juanma Barranquero <lekktu@gmail.com>
587
588 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
589
0be0ce47
EZ
5902011-07-13 Eli Zaretskii <eliz@gnu.org>
591
592 * buffer.c (mmap_find): Fix a typo.
593
cd18e7e3
JB
5942011-07-13 Johan Bockgård <bojohan@gnu.org>
595
596 Fix execution of x selection hooks.
597 * xselect.c (Qx_lost_selection_functions)
598 (Qx_sent_selection_functions): New vars.
599 (syms_of_xselect): DEFSYM them.
600 (x_handle_selection_request): Pass Qx_sent_selection_functions
601 rather than Vx_sent_selection_functions to Frun_hook_with_args.
602 (x_handle_selection_clear,x_clear_frame_selections):
603 Pass Qx_lost_selection_functions rather than
604 Vx_lost_selection_functions to Frun_hook_with_args.
605
47ea7f44
PE
6062011-07-13 Paul Eggert <eggert@cs.ucla.edu>
607
ac389d0c 608 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
609 The old code sometimes used this field without initializing it.
610
47ea7f44
PE
611 * alloc.c (gc_sweep): Don't read past end of array.
612 In theory, the old code could also have corrupted Emacs internals,
613 though it'd be very unlikely.
614
bc985c87
AS
6152011-07-12 Andreas Schwab <schwab@linux-m68k.org>
616
617 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 618 argument. (Bug#4026)
bc985c87 619
0cf34688
LMI
6202011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
621
b3dadd76
LMI
622 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
623 key" (bug#4257).
624
0cf34688
LMI
625 * window.c (Fset_window_start): Doc fix (bug#4199).
626 (Fset_window_hscroll): Ditto.
627
270768cd
PE
6282011-07-12 Paul Eggert <eggert@cs.ucla.edu>
629
077e3dda 630 Fix minor new problems caught by GCC 4.6.1.
270768cd 631 * term.c (init_tty): Remove unused local.
490011a6 632 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 633 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 634 not used otherwise.
270768cd 635
b1f58454
CY
6362011-07-12 Chong Yidong <cyd@stupidchicken.com>
637
638 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
639
22b9578d
LMI
6402011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
641
6e70ab07
LMI
642 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
643 are the mini-buffer and the echo area (bug#3320).
644
22b9578d
LMI
645 * term.c (init_tty): Remove support for supdup, c10 and perq
646 terminals, which are no longer supported (bug#1482).
647
8974cc9f
JB
6482011-07-10 Johan Bockgård <bojohan@gnu.org>
649
650 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
651
a560d974
JD
6522011-07-10 Jan Djärv <jan.h.d@swipnet.se>
653
654 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
655 for non-popups (Bug#3642).
656
1dae0f0a
AS
6572011-07-10 Andreas Schwab <schwab@linux-m68k.org>
658
268c2c36 659 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 660 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
661 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
662 * cm.c (losecursor): Likewise.
1dae0f0a
AS
663 * data.c (fmod): Likewise.
664 * dispnew.c (swap_glyphs_in_rows): Likewise.
665 * emacs.c (memory_warning_signal): Likewise.
666 * floatfns.c (float_error): Likewise.
667 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
668 (otf_open, font_otf_capability, generate_otf_features)
669 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
670 Likewise.
671 * image.c (pbm_read_file): Likewise.
672 * indent.c (string_display_width): Likewise.
673 * intervals.c (check_for_interval, search_for_interval)
674 (inc_interval_count, count_intervals, root_interval)
675 (adjust_intervals_for_insertion, make_new_interval): Likewise.
676 * lread.c (defalias): Likewise.
268c2c36 677 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
678 * regex.c (set_image_of_range_1, set_image_of_range)
679 (regex_grow_registers): Likewise.
680 * sysdep.c (strerror): Likewise.
681 * termcap.c (valid_filename_p, tprint, main): Likewise.
682 * tparam.c (main): Likewise.
683 * unexhp9k800.c (run_time_remap, save_data_space)
684 (update_file_ptrs, read_header, write_header, calculate_checksum)
685 (copy_file, copy_rest, display_header): Likewise.
686 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
687 Likewise.
688 * xdisp.c (check_it): Likewise.
689 * xfaces.c (register_color, unregister_color, unregister_colors):
690 Likewise.
691 * xfns.c (print_fontset_result): Likewise.
692 * xrdb.c (member, fatal, main): Likewise.
693
99033785
PE
6942011-07-10 Paul Eggert <eggert@cs.ucla.edu>
695
696 Fix minor problems found by static checking (Bug#9031).
697 * chartab.c (char_table_set_range, map_sub_char_table):
698 Remove unused locals.
699 (uniprop_table): Now static.
700 * composite.c (_work_char): Remove unused static var.
701
9cb2ac56
JB
7022011-07-09 Juanma Barranquero <lekktu@gmail.com>
703
704 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
705
f25661f0
JD
7062011-07-09 Jan Djärv <jan.h.d@swipnet.se>
707
708 * gtkutil.c (qttip_cb): Remove code without function.
709
8278c4fe
EZ
7102011-07-09 Eli Zaretskii <eliz@gnu.org>
711
712 * w32.c (pthread_sigmask): New stub.
713
1692ae2d 7142011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 715
8a6ebd58 716 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
717 sigprocmask is portable only for single-threaded applications, and
718 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
719 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
720 (LIBES): Use it.
721 * callproc.c (Fcall_process):
722 * process.c (create_process):
723 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
724 Use pthread_sigmask, not sigprocmask.
123403e4 725
1b854618
JD
7262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
727
728 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
729 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
730 wrong (Bug#8591).
731
3fe4b549
JD
7322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
733
0ce7e563
JD
734 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
735 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
736 (xg_hide_tooltip): Fix comment.
737
3fe4b549
JD
738 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
739 in registerServicesMenuSendTypes.
740 (validRequestorForSendType): Don't check ns_return_types.
741
742 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
743 ns_return_type.
744
5df75e47
JR
7452011-07-08 Jason Rumney <jasonr@gnu.org>
746
747 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
748 frame struct members of non-existent frames (Bug#6284).
749
699c10bd
JD
7502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
751
4393663b
JD
752 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
753 variable firstTime not needed on OSX >= 10.6.
754 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
755 >= 10.5. Use setKnobProportion, setDoubleValue.
756
757 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
758 (MAC_OS_X_VERSION_10_5): Define if not defined.
759 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
760 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
761 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
762
763 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
764 cString and lossyCString on OSX >= 10.4
765
766 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
767 sizeToFit on OSX >= 10.2.
768
769 * nsimage.m (allocInitFromFile): Don't use deprecated method
770 bestRepresentationForDevice on OSX >= 10.6.
771
772 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
773 to avoid warning.
774
775 * emacs.c: Declare unexec_init_emacs_zone.
776
a63e0781
JD
777 * nsgui.h: Fix compiler warning about gnulib redefining verify.
778
699c10bd
JD
779 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
780
781 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
782 on svcsMenu (Bug#8842).
783
784 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
785 ns_return_types.
786 (Fns_list_services): Just return Qnil on 10.6, code not working there.
787
788 * nsterm.m (QUTF8_STRING): Declare.
789 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
790 (validRequestorForSendType): Return type is (id).
791 Change indexOfObjectIdenticalTo to indexOfObject.
792 Check if we have local selection before returning self (Bug#8842).
793 (writeSelectionToPasteboard): Put local selection into paste board
794 if we have a local selection (Bug#8842).
795 (syms_of_nsterm): DEFSYM QUTF8_STRING.
796
797 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
798 (ns_get_local_selection): Declare.
799
54e10184
LMI
8002011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
801
9888ff71
LMI
802 * keymap.c (describe_map_tree): Don't insert a double newline at
803 the end of the buffer (bug#1169) and return whether we inserted
804 something.
805
54e10184
LMI
806 * callint.c (Fcall_interactively): Change "reading args" to
807 "providing args" to try to clarify what it does (bug#1010).
808
15fa4783
KH
8092011-07-07 Kenichi Handa <handa@m17n.org>
810
811 * composite.c (composition_compute_stop_pos): Ignore a static
812 composition starting before CHARPOS (Bug#8915).
813
814 * xdisp.c (handle_composition_prop): Likewise.
815
a8815b00
EZ
8162011-07-07 Eli Zaretskii <eliz@gnu.org>
817
818 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
819 (Bug#9015)
820
ef7b981d 8212011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
822
823 * character.h (unicode_category_t): New enum type.
824
825 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
826 (Qchar_code_property_table): New variable.
827 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
828 (UNIPROP_COMPRESSED_FORM_P): New macros.
829 (char_table_ascii): Uncompress the compressed values.
830 (sub_char_table_ref): New arg is_uniprop. Callers changed.
831 Uncompress the compressed values.
ac389d0c 832 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
833 (char_table_ref_and_range): Uncompress the compressed values.
834 (sub_char_table_set): New arg is_uniprop. Callers changed.
835 Uncompress the compressed values.
836 (sub_char_table_set_range): Args changed. Callers changed.
837 (char_table_set_range): Adjuted for the above change.
838 (map_sub_char_table): Delete args default_val and parent. Add arg
839 top. Give decoded values to a Lisp function.
840 (map_char_table): Adjusted for the above change. Give decoded
841 values to a Lisp function. Gcpro more variables.
842 (uniprop_table_uncompress)
843 (uniprop_decode_value_run_length): New functions.
844 (uniprop_decoder, uniprop_decoder_count): New variables.
845 (uniprop_get_decoder, uniprop_encode_value_character)
846 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
847 New functions.
848 (uniprop_encoder, uniprop_encoder_count): New variables.
849 (uniprop_get_encoder, uniprop_table)
850 (Funicode_property_table_internal, Fget_unicode_property_internal)
851 (Fput_unicode_property_internal): New functions.
852 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
853 Sunicode_property_table_internal, Sget_unicode_property_internal,
854 and Sput_unicode_property_internal. Defvar_lisp
855 char-code-property-alist.
856
857 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
858 Vunicode_category_table.
859
860 * font.c (font_range): Adjusted for the change of
861 Vunicode_category_table.
862
76b397fb
DN
8632011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
864
865 * m/iris4d.h: Remove file, move contents ...
866 * s/irix6-5.h: ... here.
867
22b4128e
PE
8682011-07-06 Paul Eggert <eggert@cs.ucla.edu>
869
870 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
871 * alloc.c (mark_buffer):
872 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
873 (clone_per_buffer_values): Don't assume that
22b4128e
PE
874 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
875 This isn't true in general, and it's particularly not true
876 if Emacs is configured with --with-wide-int.
877 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
878 New macros, used in the buffer.c change.
879
869795d6
JD
8802011-07-05 Jan Djärv <jan.h.d@swipnet.se>
881
882 * xsettings.c: Use both GConf and GSettings if both are available.
883 (store_config_changed_event): Add comment.
884 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
885 (store_tool_bar_style_changed): New functions.
886 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
887 (struct xsettings): Move font inside HAVE_XFT.
888 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
889 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
890 Move inside HAVE_XFT.
891 (something_changed_gsettingsCB): Renamed from something_changedCB.
892 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
893 also.
894 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
895 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
896 (something_changed_gconfCB): Renamed from something_changedCB.
897 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
898 (parse_settings): Move check for font inside HAVE_XFT.
899 (read_settings, apply_xft_settings): Add comment.
900 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
901 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
902 call store_font_name_changed.
903 (xft_settings_event): Add comment.
904 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
905 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
906 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
907 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
908 (xsettings_initialize): Call init_gsettings last.
909 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
910 comment.
911
d8ed26bd
PE
9122011-07-05 Paul Eggert <eggert@cs.ucla.edu>
913
914 Random fixes. E.g., (random) never returned negative values.
915 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
916 subseconds part to the entropy, as that's a bit more random.
917 Prefer signed to unsigned, since the signedness doesn't matter and
918 in general we prefer signed. When given a limit, use a
919 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
920 latter isn't right if USE_2_TAGS_FOR_INTS.
921 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
922 not 0..VALMASK. Don't discard "excess" bits that random () returns.
923
cabf1cac
SM
9242011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
925
926 * textprop.c (text_property_stickiness):
927 Obey Vtext_property_default_nonsticky.
928 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
929 * w32fns.c (syms_of_w32fns):
930 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
931
6e9b2be9
PE
9322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
933
934 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
935 This is more efficient than Ffile_directory_p and avoids a minor race.
936
90186c68
LMI
9372011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
938
7c301272
LMI
939 * buffer.c (Foverlay_put): Say what the return value is
940 (bug#7835).
941
c4f2d8d4
LMI
942 * fileio.c (barf_or_query_if_file_exists): Check first if the file
943 is a directory before asking whether to use the file name
944 (bug#7564).
ad637907
LMI
945 (barf_or_query_if_file_exists): Make the "File is a directory"
946 error be more correct.
c4f2d8d4 947
90186c68
LMI
948 * fns.c (Frequire): Remove the mention of the .gz files, since
949 that's installation-specific, but keep the mention of
950 `get-load-suffixes'.
951
da64016e
PE
9522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
953
954 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
955 Report string overflow if the output is too long.
956
7d47b580
JB
9572011-07-04 Juanma Barranquero <lekktu@gmail.com>
958
a555cb87
JB
959 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
960 (syms_of_gnutls): Remove duplicate DEFSYM for
961 Qgnutls_bootprop_verify_hostname_error, an error for
962 Qgnutls_bootprop_verify_error (which is no longer used).
963
7d47b580
JB
964 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
965 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
966 Also (re)move comments that are misplaced or no longer relevant.
967
1e49bfab
LMI
9682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
969
970 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
971
1485f4c0
CY
9722011-07-03 Chong Yidong <cyd@stupidchicken.com>
973
974 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
975 and background color parameters if they have been changed.
976
a9ab721e
LMI
9772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
978
979 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
980
cf7cff57
PE
9812011-07-03 Paul Eggert <eggert@cs.ucla.edu>
982
2e13213d
PE
983 * xsettings.c (SYSTEM_FONT): Define only when used.
984 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
985
cf7cff57
PE
986 * keymap.c (access_keymap_1): Now static.
987
7a8e04f7
CY
9882011-07-02 Chong Yidong <cyd@stupidchicken.com>
989
990 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
991 leave any prefix arg for the up event (Bug#1586).
992
61352f62
LMI
9932011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
994
69bb1ef7
LMI
995 * lread.c (syms_of_lread): Mention single symbols defined by
996 `defvar' or `defconst' (bug#7154).
997
61352f62 998 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 999 (Frequire): Mention get-load-suffixes.
61352f62 1000
28545e04
MR
10012011-07-02 Martin Rudalics <rudalics@gmx.at>
1002
1003 * window.h (window): Remove clone_number slot.
1004 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1005 Remove.
1006 (make_parent_window, make_window, saved_window)
1007 (Fset_window_configuration, save_window_save): Don't deal with
1008 clone numbers.
1009 * buffer.c (Qclone_number): Remove declaration.
1010 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1011
3349e122
SM
10122011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1013
1014 Add multiple inheritance to keymaps.
1015 * keymap.c (Fmake_composed_keymap): New function.
1016 (Fset_keymap_parent): Simplify.
1017 (fix_submap_inheritance): Remove.
1018 (access_keymap_1): New function extracted from access_keymap to handle
1019 embedded parents and handle lists of maps.
1020 (access_keymap): Use it.
1021 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1022 (Fcopy_keymap): Handle embedded parents.
1023 (Fcommand_remapping, define_as_prefix): Simplify.
1024 (Fkey_binding): Simplify.
1025 (syms_of_keymap): Move minibuffer-local-completion-map,
1026 minibuffer-local-filename-completion-map,
1027 minibuffer-local-must-match-map, and
1028 minibuffer-local-filename-must-match-map to Elisp.
1029 (syms_of_keymap): Defsubr make-composed-keymap.
1030 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1031 (parse_menu_item): Trivial simplification.
1032
3279eb87
GM
10332011-07-01 Glenn Morris <rgm@gnu.org>
1034
1035 * Makefile.in (SETTINGS_LIBS): Fix typo.
1036
4550efdf
KI
10372011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1038
1039 * coding.c (Fencode_coding_string): Record the last coding system
1040 used, as the function doc string says (bug#8738).
1041
0949d2b6
JD
10422011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * xsettings.c (store_monospaced_changed): Take new font as arg and
1045 check for change against current_mono_font.
1046 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1047 (emacs_settings_constructor, emacs_settings_get_property)
1048 (emacs_settings_set_property, emacs_settings_class_init)
1049 (emacs_settings_init, gsettings_obj): Remove.
1050 (something_changedCB): New function for HAVE_GSETTINGS.
1051 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1052 with value as argument.
1053 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1054 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1055 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1056 "changed".
1057
1058 * xgselect.c: Add defined (HAVE_GSETTINGS).
1059 (xgselect_initialize): Ditto.
1060
1061 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1062 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1063 xg_select.
1064
bbc6b304
PE
10652011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 * eval.c (struct backtrace): Simplify and port the data structure.
1068 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1069 signed bit field, as this assumption is not portable and it makes
1070 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1071 "char debug_on_exit : 1" as this is not portable either; instead,
1072 use the portable "unsigned int debug_on_exit : 1". Remove unused
1073 member evalargs. Remove obsolete comments about cc bombing out.
1074
9851bfc5
JD
10752011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1076
51bb811f 1077 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1078 Let HAVE_GSETTINGS override HAVE_GCONF.
1079 (store_monospaced_changed): New function.
1080 (EMACS_SETTINGS): A new type derived from GObject to handle
1081 GSettings notifications.
1082 (emacs_settings_constructor, emacs_settings_get_property)
1083 (emacs_settings_set_property, emacs_settings_class_init):
1084 New functions.
1085 (gsettings_client, gsettings_obj): New variables.
1086 (GSETTINGS_SCHEMA): New define.
1087 (something_changedCB): Call store_monospaced_changed.
1088 (init_gsettings): New function.
1089 (xsettings_initialize): Call init_gsettings.
1090 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1091 to NULL.
1092
1093 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1094 GCONF_CFLAGS/LIBS.
1095
5386012d
MR
10962011-06-29 Martin Rudalics <rudalics@gmx.at>
1097
1098 * window.c (resize_root_window, grow_mini_window)
1099 (shrink_mini_window): Rename Qresize_root_window to
1100 Qwindow_resize_root_window and Qresize_root_window_vertically to
1101 Qwindow_resize_root_window_vertically.
1102
f13e0b08
PE
11032011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1104
1105 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1106
94515237
JB
11072011-06-27 Juanma Barranquero <lekktu@gmail.com>
1108
1109 * makefile.w32-in: Redesign dependencies so they reflect more
1110 clearly which files are directly included by each source file,
1111 and not through other includes.
1112
e43b6e43
MR
11132011-06-27 Martin Rudalics <rudalics@gmx.at>
1114
1115 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1116 (sort_overlays, overlay_strings): When an overlay's clone number
1117 matches the window's clone number process the overlay even if
1118 the overlay's window property doesn't match the current window.
1119
d68443dc
MR
1120 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1121 (Fwindow_hchild): Rename to Fwindow_left_child.
1122 (Fwindow_next): Rename to Fwindow_next_sibling.
1123 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1124 (resize_window_check): Rename to window_resize_check.
1125 (resize_window_apply): Rename to window_resize_apply.
1126 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1127 (Fdelete_other_windows_internal, resize_frame_windows)
1128 (Fsplit_window_internal, Fdelete_window_internal)
1129 (grow_mini_window, shrink_mini_window)
1130 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1131
c7e73be5
JD
11322011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1135 (emacs_fixed_set_min_size): Remove.
1136 (emacs_fixed_new): Take frame as argument.
1137
1138 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1139 (_EmacsFixedPrivate): Remove minwidth/height.
1140 Add struct frame *f.
1141 (emacs_fixed_init): Initialize priv->f.
1142 (get_parent_class, emacs_fixed_set_min_size): Remove.
1143 (emacs_fixed_new): Set priv->f to argument.
1144 (emacs_fixed_get_preferred_width)
1145 (emacs_fixed_get_preferred_height): Use min_width/height from
1146 frames size_hint to set minimum and natural (Bug#8919).
1147 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1148 and use min_width/height from frames size_hint to set
1149 min_width/height (Bug#8919).
1150
1151 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1152 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1153 Fix indentation.
c7e73be5 1154
cf99dcf8
EZ
11552011-06-26 Eli Zaretskii <eliz@gnu.org>
1156
1157 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1158 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1159 called at ZV.
1160
029529ac
CY
11612011-06-26 Chong Yidong <cyd@stupidchicken.com>
1162
1163 * process.c (wait_reading_process_output): Bypass select if
1164 waiting for a cell while ignoring keyboard input, and input is
1165 pending. Suggested by Jan Djärv (Bug#8869).
1166
7a7ef429
PE
11672011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 Use gnulib's dup2 module instead of rolling our own.
1170 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1171
11fdef7d 11722011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1173
1174 * dispnew.c (scrolling_window): Before scrolling, turn off a
1175 mouse-highlight in the window being scrolled.
1176
cd3520a4
JB
11772011-06-24 Juanma Barranquero <lekktu@gmail.com>
1178
1179 Move DEFSYM to lisp.h and use everywhere.
1180
1181 * character.h (DEFSYM): Move declaration...
1182 * lisp.h (DEFSYM): ...here.
1183
1184 * gnutls.c:
1185 * minibuf.c:
1186 * w32menu.c:
1187 * w32proc.c:
1188 * w32select.c: Don't include character.h.
1189
1190 * alloc.c (syms_of_alloc):
1191 * buffer.c (syms_of_buffer):
1192 * bytecode.c (syms_of_bytecode):
1193 * callint.c (syms_of_callint):
1194 * casefiddle.c (syms_of_casefiddle):
1195 * casetab.c (init_casetab_once):
1196 * category.c (init_category_once, syms_of_category):
1197 * ccl.c (syms_of_ccl):
1198 * cmds.c (syms_of_cmds):
1199 * composite.c (syms_of_composite):
1200 * dbusbind.c (syms_of_dbusbind):
1201 * dired.c (syms_of_dired):
1202 * dispnew.c (syms_of_display):
1203 * doc.c (syms_of_doc):
1204 * editfns.c (syms_of_editfns):
1205 * emacs.c (syms_of_emacs):
1206 * eval.c (syms_of_eval):
1207 * fileio.c (syms_of_fileio):
1208 * fns.c (syms_of_fns):
1209 * frame.c (syms_of_frame):
1210 * fringe.c (syms_of_fringe):
1211 * insdel.c (syms_of_insdel):
1212 * keymap.c (syms_of_keymap):
1213 * lread.c (init_obarray, syms_of_lread):
1214 * macros.c (syms_of_macros):
1215 * msdos.c (syms_of_msdos):
1216 * print.c (syms_of_print):
1217 * process.c (syms_of_process):
1218 * search.c (syms_of_search):
1219 * sound.c (syms_of_sound):
1220 * syntax.c (init_syntax_once, syms_of_syntax):
1221 * terminal.c (syms_of_terminal):
1222 * textprop.c (syms_of_textprop):
1223 * undo.c (syms_of_undo):
1224 * w32.c (globals_of_w32):
1225 * window.c (syms_of_window):
1226 * xdisp.c (syms_of_xdisp):
1227 * xfaces.c (syms_of_xfaces):
1228 * xfns.c (syms_of_xfns):
1229 * xmenu.c (syms_of_xmenu):
1230 * xsettings.c (syms_of_xsettings):
1231 * xterm.c (syms_of_xterm): Use DEFSYM.
1232
4228cf16
TZ
12332011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1234
cd3520a4 1235 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1236
7fcccf1e
PE
12372011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1238
7efb4e0e
PE
1239 Integer and buffer overflow fixes (Bug#8873).
1240
ff5844ad
PE
1241 * print.c (printchar, strout): Check for string overflow.
1242 (PRINTPREPARE, printchar, strout):
1243 Don't set size unless allocation succeeds.
1244
90532f02
PE
1245 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1246 for sizes. Check for string overflow more accurately.
1247 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1248
6d84508d
PE
1249 * macros.c: Integer and buffer overflow fixes.
1250 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1251 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1252 Use ptrdiff_t, not int, for sizes.
1253 Don't increment bufsize until after realloc succeeds.
1254 Check for size-calculation overflow.
1255 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1256
437b2cb4
PE
1257 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1258
8b9ac8b4
PE
1259 * lread.c: Integer overflow fixes.
1260 (read_integer): Radix is now EMACS_INT, not int,
1261 to improve quality of diagnostics for out-of-range radices.
1262 Calculate buffer size correctly for out-of-range radices.
1263 (read1): Check for integer overflow in radices, and in
1264 read-circle numbers.
82cb60d3
PE
1265 (read_escape): Avoid int overflow.
1266 (Fload, openp, read_buffer_size, read1)
1267 (substitute_object_recurse, read_vector, read_list, map_obarray):
1268 Use ptrdiff_t, not int, for sizes.
1269 (read1): Use EMACS_INT, not int, for sizes.
20270765 1270 Check for size overflow.
8b9ac8b4 1271
7fcccf1e
PE
1272 * image.c (cache_image): Check for size arithmetic overflow.
1273
bfbbd7e7
PE
1274 * lread.c: Integer overflow issues.
1275 (saved_doc_string_size, saved_doc_string_length)
1276 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1277 Now ptrdiff_t, not int.
1278 (read1): Don't assume doc string length fits in int. Check for
1279 out-of-range doc string lengths.
1280 (read_list): Don't assume file position fits in int.
39019e54 1281 (read_escape): Check for hex character overflow.
bfbbd7e7 1282
4e323265
LL
12832011-06-22 Leo Liu <sdl.web@gmail.com>
1284
1285 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1286 Move to minibuffer.el.
1287
85fece3e
PE
12882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1289
20b84ce9 1290 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1291 The following patches are for when GLYPH_DEBUG && !XASSERT.
1292 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1293 * dispnew.c (flush_stdout):
1294 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1295 Mark as externally visible.
1296 * dispnew.c (check_window_matrix_pointers): Now static.
1297 * dispnew.c (window_to_frame_vpos):
1298 * xfns.c (unwind_create_frame):
1299 * xterm.c (x_check_font): Remove unused local.
1300 * scroll.c (CHECK_BOUNDS):
1301 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1302 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1303 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1304 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1305 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1306 Now static.
1307 (debug_method_add): Use va_list and vsprintf rather than relying
1308 on undefined behavior with wrong number of arguments.
1309 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1310 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1311 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1312 since we're not interested in debugging glyphs with old libraries.
1313 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1314 GCC 4.6.0's static checking.
1315
0766b489
PE
13162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1317
31fd4b32
PE
1318 Integer overflow and signedness fixes (Bug#8873).
1319 A few related buffer overrun fixes, too.
1320
b79e8648
PE
1321 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1322
0766b489
PE
1323 * dispextern.h (struct face.stipple):
1324 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1325 (x_bitmap_mask, x_allocate_bitmap_record)
1326 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1327 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1328 (x_create_bitmap_from_xpm_data):
1329 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1330 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1331 (.bitmaps_last):
1332 * xfaces.c (load_pixmap):
1333 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1334 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1335 (.bitmaps_last, struct x_output.icon_bitmap):
1336 Use ptrdiff_t, not int, for bitmap indexes.
1337 (x_allocate_bitmap_record): Check for size overflow.
1338 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1339
b081724f
PE
1340 Use ptrdiff_t, not int, for overlay counts.
1341 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1342 * editfns.c (overlays_around, get_pos_property):
1343 * textprop.c (get_char_property_and_overlay):
1344 * xdisp.c (next_overlay_change, note_mouse_highlight):
1345 * xfaces.c (face_at_buffer_position):
21514da7
PE
1346 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1347 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1348 (Fnext_overlay_change, Fprevious_overlay_change)
1349 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1350 Use ptrdiff_t, not int, for sizes.
21514da7 1351 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1352
3de73e5e
PE
1353 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1354
2606c57b
PE
1355 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1356 (x_session_initialize): Do not assume string length fits in int.
1357
aaafe47a
PE
1358 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1359 This is unlikely, but can occur if DPI is outlandish.
1360
2674ddc8 1361 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1362 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1363
28154962
PE
1364 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1365 * xrdb.c (magic_file_p, search_magic_path):
1366 Omit last arg SUFFIX; it was always 0. All callers changed.
1367 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1368
7de51af5
PE
1369 * xfont.c (xfont_match): Avoid need for strlen.
1370
25ed6cc3
PE
1371 * xfns.c: Don't assume strlen fits in int.
1372 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1373
4eab31dd
PE
1374 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1375 not unsigned long, as we prefer signed integers. All callers changed.
1376 Detect integer overflow in repeat count.
1377 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1378 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1379
171e2a58
PE
1380 * termcap.c: Don't assume sizes fit in int and never overflow.
1381 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1382 (gobble_line): Check for size-calculation overflow.
1383
ad39faca 1384 * minibuf.c (Fread_buffer):
6e5bb2dc 1385 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1386 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1387 Don't assume string length fits in int.
1388
52c61c22 1389 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1390 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1391
b5b8c9e5
PE
1392 * font.c: Don't assume string length fits in int.
1393 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1394 Use ptrdiff_t, not int.
ccd6111c
PE
1395 (font_intern_prop): Don't assume string length fits in int.
1396 Don't assume integer property fits in fixnum.
1397 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1398
882f0d81 1399 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1400 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1401 Reformulate so as not to need the command string.
1402 Invoke gzip -cd rather than gunzip, as it's more portable.
1403 (lock_info_type, lock_file_1, lock_file):
1404 Don't assume pid_t and time_t fit in unsigned long.
1405 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1406 (current_lock_owner): Prefer signed type for sizes.
1407 Use memcpy, not strncpy, where memcpy is what is really wanted.
1408 Don't assume (via atoi) that time_t and pid_t fit in int.
1409 Check for time_t and/or pid_t out of range, e.g., via a network share.
1410 Don't alloca where an auto var works fine.
1411
93f4cf88
PE
1412 * fileio.c: Fix some integer overflow issues.
1413 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1414 Don't assume string length fits in int.
1415 (directory_file_name): Don't assume string length fits in long.
1416 (make_temp_name): Don't assume pid fits in int, or that its print
1417 length is less than 20.
1418
f3e92b69
PE
1419 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1420
1bfdaf10
PE
1421 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1422
35016e9a
PE
1423 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1424
3d1e65a1
PE
1425 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1426 We prefer signed integers, even for size calculations.
1427
0b963a93
PE
1428 * emacs.c: Don't assume string length fits in 'int'.
1429 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1430 (main): Don't invoke strlen when not needed.
1431
573f4b54
PE
1432 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1433 (XD_DEBUG_MESSAGE): Don't waste a byte.
1434
989f33ba
PE
1435 * callproc.c (getenv_internal_1, getenv_internal)
1436 (Fgetenv_internal):
965d34eb
PE
1437 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1438
e4d29b33
PE
1439 * lread.c (invalid_syntax): Omit length argument.
1440 All uses changed. This doesn't fix a bug, but it simplifies the
1441 code away from its former Hollerith-constant appearance, and it's
1442 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1443 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1444
eb49b136
PE
1445 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1446 This didn't break anything, but it didn't help either.
1447 It's confusing to put a bogus integer in a place where the actual
1448 value does not matter.
9f62aeb1 1449 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1450 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1451
15375a22
PE
1452 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1453 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1454 implementation.
b61cc01c
PE
1455 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1456 We prefer signed types, and the value cannot exceed the EMACS_INT
1457 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1458 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1459 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1460 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1461
53b2623d
PE
1462 * indent.c (sane_tab_width): New function.
1463 (current_column, scan_for_column, Findent_to, position_indentation)
1464 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1465 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1466
51cab52b 1467 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1468
f2ed8a70
PE
1469 * lisp.h (lint_assume): New macro.
1470 * composite.c (composition_gstring_put_cache):
1471 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1472
abe80cc6
PE
1473 * editfns.c, insdel.c:
1474 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1475
b02c740e
PE
1476 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1477
ebc96716
PE
1478 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1479
b4e50fa0 1480 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1481 Use much-faster test for byte-length change.
311d5d7c 1482 Don't assume string byte-length fits in 'int'.
a4cf38e4 1483 Check that character arg fits in 'int'.
85461888 1484 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1485
c0c1ee9f
PE
1486 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1487
a498d7f4
PE
1488 * fns.c (concat): Catch string overflow earlier.
1489 Do not rely on integer wraparound.
1490
51cab52b
PE
1491 * dispextern.h (struct it.overlay_strings_charpos)
1492 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1493 * xdisp.c (forward_to_next_line_start)
1494 (back_to_previous_visible_line_start)
1495 (reseat_at_next_visible_line_start, next_element_from_buffer):
1496 Don't arbitrarily truncate the value of 'selective' to int.
1497
76031fad
PE
1498 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1499
5eb55db9
PE
1500 * composite.c: Don't truncate sizes to 'int'.
1501 (composition_gstring_p, composition_reseat_it)
1502 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1503 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1504 not EMACS_UINT, for indexes.
5eb55db9 1505
0703a717
PE
1506 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1507
d6202519
PE
1508 * buffer.c: Include <verify.h>.
1509 (struct sortvec.priority, struct sortstr.priority):
8961a454 1510 Now EMACS_INT, not int.
c20998a7 1511 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1512 (struct sortstr.size, record_overlay_string)
1513 (struct sortstrlist.size, struct sortlist.used):
1514 Don't truncate size to int.
1515 (record_overlay_string): Check for size-calculation overflow.
d6202519 1516 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1517
d5a19415
JM
15182011-06-22 Jim Meyering <meyering@redhat.com>
1519
029529ac 1520 Don't leak an XBM-image-sized buffer
d5a19415
JM
1521 * image.c (xbm_load): Free the image buffer after using it.
1522
a9041e6c
PE
15232011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Port to Sun C.
1526 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1527 that Sun C diagnosed.
1528 * fns.c (secure_hash): Fix pointer signedness issue.
1529 * intervals.c (static_offset_intervals): New function.
1530 (offset_intervals): Use it.
1531
7f3f739f
LL
15322011-06-21 Leo Liu <sdl.web@gmail.com>
1533
1534 * deps.mk (fns.o):
1535 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1536 sha512.h.
1537
1538 * fns.c (secure_hash): Rename from crypto_hash_function and change
1539 the first arg to accept symbols.
5b66d427 1540 (Fsecure_hash): New primitive.
7f3f739f
LL
1541 (syms_of_fns): New symbols.
1542
76147d94
DD
15432011-06-20 Deniz Dogan <deniz@dogan.se>
1544
1545 * process.c (Fset_process_buffer): Clarify return value in
1546 docstring.
1547
7d7d0045
CY
15482011-06-18 Chong Yidong <cyd@stupidchicken.com>
1549
1550 * dispnew.c (add_window_display_history): Use BVAR.
1551
1552 * xdisp.c (debug_method_add): Use BVAR.
1553 (check_window_end, dump_glyph_matrix, dump_glyph)
1554 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1555
1556 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1557 Likewise.
1558
1559 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1560 check till after the cache is created in init_frame_faces.
1561
ff2bc410
SM
15622011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1563
1564 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1565
28177add
PE
15662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1567
dd3482fe
PE
1568 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1569 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1570 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1571
393d71f3 1572 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1573 * fileio.c (Finsert_file_contents):
1574 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1575 Remove the old (too-loose) buffer overflow checks.
1576 They weren't needed, since make_gap checks for buffer overflow.
1577 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1578 The old code merely checked for Emacs fixnum overflow, and relied
1579 on undefined (wraparound) behavior. The new code avoids undefined
1580 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1581
2e6813b0 1582 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1583 Tune. Don't use wider integers than needed. Don't use alloca.
1584 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1585
599a9e4f
PE
1586 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1587
99561444
PE
1588 * insdel.c, lisp.h (buffer_overflow): New function.
1589 (insert_from_buffer_1, replace_range, replace_range_2):
1590 * insdel.c (make_gap_larger):
1591 * editfns.c (Finsert_char):
1592 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1593
28177add
PE
1594 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1595
e69dafad
PE
15962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1597
a7af7fde 1598 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1599
b1c46f02
PE
1600 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1601 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1602
e69dafad
PE
1603 * fileio.c: Don't assume EMACS_INT fits in off_t.
1604 (emacs_lseek): New static function.
1605 (Finsert_file_contents, Fwrite_region): Use it.
1606 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1607
566684ea
PE
1608 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1609
e6966cd6
PE
1610 * fns.c: Don't overflow int when computing a list length.
1611 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1612 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1613 truncation on 64-bit hosts. Check for QUIT every
1614 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1615 faster and is responsive enough.
1616 (Flength): Report an error instead of overflowing an integer.
1617 (Fsafe_length): Return a float if the value is not representable
1618 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1619 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1620 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1621
dd0b0efb
PE
1622 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1623 (header_size, word_size): New constants.
1624 (allocate_vectorlike): Don't check size overflow here.
1625 (allocate_vector): Check it here instead, since this is the only
1626 caller of allocate_vectorlike that could cause overflow.
1627 Check that the new vector's length is representable as a fixnum.
1628
86fe5cfe
PE
1629 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1630 The previous code was bogus. For example, next_almost_prime (32)
1631 returned 39, which is undesirable as it is a multiple of 3; and
1632 next_almost_prime (24) returned 25, which is a multiple of 5 so
1633 why was the code bothering to check for multiples of 7?
1634
80e88859
PE
1635 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1636
4a2f0ad6
PE
1637 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1638
f66c7cf8
PE
1639 Variadic C functions now count arguments with ptrdiff_t.
1640 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1641 Back then I didn't know that the Emacs coding style prefers signed int.
1642 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1643 were being counted with int, which may truncate counts on 64-bit
1644 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1645 * lisp.h (struct Lisp_Subr.function.aMANY)
1646 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1647 Arg counts are now ptrdiff_t, not size_t.
1648 All variadic functions and their callers changed accordingly.
1649 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1650 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1651 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1652 * callint.c (Fcall_interactively): Check arg count for overflow,
1653 to avoid potential buffer overrun. Use signed char, not 'int',
1654 for 'varies' array, so that we needn't bother to check its size
1655 calculation for overflow.
1656 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1657 * eval.c (apply_lambda):
1658 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1659 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1660 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1661
a1759b76
PE
1662 * callint.c (Fcall_interactively): Don't use index var as event count.
1663
d96be9fc
PE
1664 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1665 * mem-limits.h (SIZE): Remove; no longer used.
1666
a690a978 1667 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1668
578c21e6
PE
1669 Remove unnecessary casts.
1670 * xterm.c (x_term_init):
1671 * xfns.c (x_set_border_pixel):
1672 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1673 These aren't needed now that we assume ANSI C.
1674
96f53c6c
PE
1675 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1676 It's more likely to cause problems (due to unsigned overflow)
1677 than to cure them.
1678
83c77d31
PE
1679 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1680
ee2079f1
PE
1681 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1682
6da65536
PE
1683 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1684
7147c4a4
PE
1685 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1686
193e32d9
PE
1687 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1688
e5533da6
PE
1689 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1690
9910e595
PE
1691 GLYPH_CODE_FACE returns EMACS_INT, not int.
1692 * dispextern.h (merge_faces):
1693 * xfaces.c (merge_faces):
01103c44
PE
1694 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1695 Don't assume EMACS_INT fits in int.
9910e595 1696
2638320e
PE
1697 * character.h (CHAR_VALID_P): Remove unused parameter.
1698 * fontset.c, lisp.h, xdisp.c: All uses changed.
1699
045eb8d9
PE
1700 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1701
c1f134b5
PE
1702 * fns.c (concat): Minor tuning based on overflow analysis.
1703 This doesn't fix any bugs. Use int to hold character, instead
1704 of constantly refetching from Emacs object. Use XFASTINT, not
1705 XINT, for value known to be a character. Don't bother comparing
1706 a single byte to 0400, as it's always less.
1707
395fcb93 1708 * floatfns.c (Fexpt):
327eeec8
PE
1709 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1710
abbd3d23
PE
1711 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1712 for characters.
1713
684a03ef
PE
1714 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1715
0fed43f3
PE
1716 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1717 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1718 incorrectly succeed when S was a string, because 4294967386 was
1719 truncated before it was used.
1720
8fd02eb7
PE
1721 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1722 Otherwise, an out-of-range integer could cause undefined behavior
1723 on a 64-bit host.
1724
f8c86b69
PE
1725 * composite.c: Use int, not EMACS_INT, for characters.
1726 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1727 EMACS_INT, for values that are known to be in character range.
1728 This doesn't fix any bugs but is the usual style inside Emacs and
1729 may generate better code on 32-bit machines.
1730
34206dd2
PE
1731 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1732 This is for reasons similar to the recent CHAR_STRING fix.
1733 * charset.c (Fencode_char): Check that character arg is actually
1734 a character. Pass an int to ENCODE_CHAR.
1735 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1736 wider than 'int', as a compile-time check to prevent future regressions
1737 in this area.
1738
c5958d4c 1739 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1740
1741 Make sure a 64-bit char is never passed to CHAR_STRING.
1742 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1743 by silently ignoring the top 32 bits, allowing some values
1744 that were far too large to be valid characters.
1745 * character.h: Include <verify.h>.
1746 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1747 arguments are no wider than unsigned, as a compile-time check
1748 to prevent future regressions in this area.
1749 * data.c (Faset):
01103c44 1750 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1751 (Fsubst_char_in_region):
1752 * fns.c (concat):
1753 * xdisp.c (decode_mode_spec_coding):
1754 Adjust to CHAR_STRING's new requirement.
1755 * editfns.c (Finsert_char, Fsubst_char_in_region):
1756 * fns.c (concat): Check that character args are actually
1757 characters. Without this test, these functions did the wrong
1758 thing with wildly out-of-range values on 64-bit hosts.
1759
d37ca623
PE
1760 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1761 These casts should not be needed on 32-bit hosts, either.
1762 * keyboard.c (read_char):
1763 * lread.c (Fload): Remove casts to unsigned.
1764
ea204efb
PE
1765 * lisp.h (UNSIGNED_CMP): New macro.
1766 This fixes comparison bugs on 64-bit hosts.
1767 (ASCII_CHAR_P): Use it.
1768 * casefiddle.c (casify_object):
01103c44 1769 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1770 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1771 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1772 * dispextern.h (FACE_FROM_ID):
1773 * keyboard.c (read_char): Use UNSIGNED_CMP.
1774
41cb286c
PE
1775 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1776 not to EMACS_INT, to avoid GCC warning.
1777
4a1b9832
PE
1778 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1779
55daad71
PE
1780 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1781 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1782 isn't needed on 32-bit machines.
8f95c75c 1783
01103c44
PE
1784 * buffer.c (Fgenerate_new_buffer_name):
1785 Use EMACS_INT for count, not int.
0ceccced 1786 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1787
1788 * data.c (Qcompiled_function): Now static.
1789
c6f072e7
PE
1790 * window.c (window_body_lines): Now static.
1791
20ce5912
PE
1792 * image.c (gif_load): Rename local to avoid shadowing.
1793
9c4c5f81
PE
1794 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1795 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1796 * alloc.c (make_save_value): Integer argument is now of type
1797 ptrdiff_t, not int.
1798 (mark_object): Use ptrdiff_t, not int.
1799 * lisp.h (pD): New macro.
1800 * print.c (print_object): Use it.
1801
c0c5c8ae
PE
1802 * alloc.c: Use EMACS_INT, not int, to count objects.
1803 (total_conses, total_markers, total_symbols, total_vector_size)
1804 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1805 (total_free_floats, total_floats, total_free_intervals)
1806 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1807 Now EMACS_INT, not int. All uses changed.
1808 (Fgarbage_collect): Compute overall total using a double, so that
1809 integer overflow is less likely to be a problem. Check for overflow
1810 when converting back to an integer.
5a25e253
PE
1811 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1812 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1813 These were 'int' variables that could overflow on 64-bit hosts;
1814 they were never used, so remove them instead of repairing them.
211a0b2a 1815 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1816 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1817 Previously, this ceilinged at INT_MAX, but that doesn't work on
1818 64-bit machines.
e46bb31a 1819 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1820
c78baabf 1821 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1822 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1823 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1824 when a (possibly-narrower) signed value would do just as well.
1825 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1826
c9d624c6
PE
1827 * alloc.c: Catch some string size overflows that we were missing.
1828 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1829 for convenience in STRING_BYTES_MAX.
1830 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1831 The definition here is exact; the one in lisp.h was approximate.
1832 (allocate_string_data): Check for string overflow. This catches
1833 some instances we weren't catching before. Also, it catches
1834 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1835 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1836 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1837
c9d624c6
PE
1838 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1839 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1840 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1841
353032ce
PE
1842 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1843
2bccce07
PE
1844 * alloc.c (Fmake_string): Check for out-of-range init.
1845
0ac30604
SM
18462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1847
1848 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1849
c195f2de
JD
18502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1851
1852 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1853 xg_get_default_scrollbar_width.
1854
1855 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1856 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1857 (style_changed_cb): Call update_theme_scrollbar_width and call
1858 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1859 all frames (Bug#8505).
1860 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1861 Call gtk_window_set_resizable if HAVE_GTK3.
1862 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1863 and height if HAVE_GTK3 (Bug#8505).
1864 (scroll_bar_width_for_theme): New variable.
1865 (update_theme_scrollbar_width): New function.
1866 (xg_get_default_scrollbar_width): Move code to
1867 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1868 (xg_initialize): Call update_theme_scrollbar_width.
1869
1870 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1871
1872 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1873
e10ac9f1
MR
18742011-06-12 Martin Rudalics <rudalics@gmx.at>
1875
1876 * frame.c (make_frame): Call other_buffer_safely instead of
1877 other_buffer.
1878
1879 * window.c (temp_output_buffer_show): Call display_buffer with
1880 second argument Vtemp_buffer_show_specifiers and reset latter
1881 immediately after the call.
1882 (Vtemp_buffer_show_specifiers): New variable.
1883 (auto_window_vscroll_p, next_screen_context_lines)
1884 (Vscroll_preserve_screen_position): Remove leading asterisks from
1885 doc-strings.
1886
2d3c217e 18872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1888
7b7f97e8 1889 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1890 * buffer.c (Qclone_number): Remove for now, as it's unused.
1891 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1892 (record_buffer): Remove unused local.
1893 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1894 (set_frame_buffer_list): Remove; unused.
1895 * frame.h (other_visible_frames): Remove decl.
1896 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1897 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1898 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1899 if HAVE_GPM.
1900 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1901 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1902 Define only if HAVE_GPM.
1903 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1904 (update_hints_inhibit): Remove; never set. All uses removed.
1905 * widgetprv.h (emacsFrameClassRec): Remove decl.
1906 * window.c (delete_deletable_window): Now returns void, since it
1907 wasn't returning anything.
1908 (compare_window_configurations): Remove unused locals.
1909 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1910 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1911 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1912 the same widths as pointers. This follows up on the 2011-05-06 patch.
1913 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1914 * xterm.h: Likewise.
1915 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1916
1384b89e
JB
19172011-06-12 Juanma Barranquero <lekktu@gmail.com>
1918
1919 * makefile.w32-in: Update dependencies.
1920 (LISP_H): Add lib/intprops.h.
1921
1100a63c
CY
19222011-06-11 Chong Yidong <cyd@stupidchicken.com>
1923
1924 * image.c (gif_load): Add animation frame delay to the metadata.
1925 (syms_of_image): Use DEFSYM. New symbol `delay'.
1926
6198ccd0
MR
19272011-06-11 Martin Rudalics <rudalics@gmx.at>
1928
1929 * window.c (delete_deletable_window): Re-add.
1930 (Fset_window_configuration): Rewrite to handle dead buffers and
1931 consequently deletable windows.
1932 (window_tree, Fwindow_tree): Remove. Supply functionality in
1933 window.el.
1934 (compare_window_configurations): Simplify code.
1935
b6e3633c
AS
19362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1937
1ab0dee5
AS
1938 * image.c (imagemagick_load_image): Fix type mismatch.
1939 (Fimagemagick_types): Likewise.
1940
b6e3633c
AS
1941 * window.h (replace_buffer_in_windows): Declare.
1942
9397e56f
MR
19432011-06-11 Martin Rudalics <rudalics@gmx.at>
1944
1945 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1946 Qclone_number. Remove external declaration of Qdelete_window.
1947 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1948 code.
1949 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1950 Qbuffer_list_update_hook if allowed.
1951 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1952 buffer list implementation.
1953 (other_buffer_safely): New function.
1954 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1955 calls to replace_buffer_in_windows and
1956 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1957 if allowed.
1958 (record_buffer): Inhibit quitting and rewrite using quittable
1959 functions. Run Qbuffer_list_update_hook if allowed.
1960 (Frecord_buffer, Funrecord_buffer): New functions.
1961 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1962 switch-to-buffer to window.el.
1963 (bury-buffer): Move to window.el.
1964 (Vbuffer_list_update_hook): New variable.
1965
1966 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1967 section.
1968
1969 * window.h (resize_frame_windows): Move up in code.
1970 (Fwindow_frame): Remove EXFUN.
1971 (replace_buffer_in_all_windows): Remove prototype.
1972 (replace_buffer_in_windows_safely): Add prototype.
1973
1974 * window.c: Declare Qdelete_window static again. Move down
1975 declaration of select_count.
1976 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1977 (Fother_window): Move to window.el.
1978 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1979 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1980 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1981 window.el.
1982 (replace_buffer_in_windows): Implement by calling
1983 Qreplace_buffer_in_windows.
1984 (replace_buffer_in_all_windows): Remove with some functionality
1985 moved into replace_buffer_in_windows_safely.
1986 (replace_buffer_in_windows_safely): New function.
1987 (select_window_norecord, select_frame_norecord): Move in front
1988 of run_window_configuration_change_hook. Remove now obsolete
1989 declarations.
1990 (Fset_window_buffer): Rewrite doc-string. Call
1991 Qrecord_window_buffer.
1992 (keys_of_window): Move binding for other-window to window.el.
1993
b50691aa
CY
19942011-06-11 Chong Yidong <cyd@stupidchicken.com>
1995
1996 * dispextern.h (struct image): Replace data member, whose int_val
1997 and ptr_val fields were not used by anything, with a single
1998 lisp_val object.
1999
2000 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2001 (gif_clear_image, gif_load, imagemagick_load_image)
2002 (gs_clear_image, gs_load): Callers changed.
2003
3f754b86
PE
20042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2005
cca69397
PE
2006 * buffer.h: Include <time.h>, for time_t.
2007 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2008
109e28d0
PE
2009 Fix minor problems found by static checking.
2010
60737f02
PE
2011 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2012
4b66faf3
PE
2013 Make identifiers static if they are not used in other modules.
2014 * data.c (Qcompiled_function, Qframe, Qvector):
2015 * image.c (QimageMagick, Qsvg):
2016 * minibuf.c (Qmetadata):
2017 * window.c (resize_window_check, resize_root_window): Now static.
2018 * window.h (resize_window_check, resize_root_window): Remove decls.
2019
109e28d0
PE
2020 * window.c (window_deletion_count, delete_deletable_window):
2021 Remove; unused.
46a4ce9e
PE
2022 (window_body_lines): Now static.
2023 (Fdelete_other_windows_internal): Mark vars as initialized.
2024 Make sure 'resize_failed' is initialized.
2025 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2026 (resize_window_apply): Remove unused local.
2027 * window.h (delete_deletable_window): Remove decl.
2028
109e28d0 2029 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2030 (imagemagick_load_image): Fix pointer signedness problem by changing
2031 last arg from unsigned char * to char *. All uses changed.
2032 Also, fix a local for similar reasons.
2033 Remove unused locals. Remove locals to avoid shadowing.
2034 (fn_rsvg_handle_free): Remove; unused.
2035 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2036 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2037
3f754b86
PE
2038 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2039
2547adb1
CY
20402011-06-10 Chong Yidong <cyd@stupidchicken.com>
2041
2042 * image.c (gif_load): Fix omitted cast error introduced by
2043 2011-06-06 change.
2044
2c8e37d4
MR
20452011-06-10 Martin Rudalics <rudalics@gmx.at>
2046
2047 * window.h (resize_proportionally, orig_total_lines)
2048 (orig_top_line): Remove from window structure.
2049 (set_window_height, set_window_width, change_window_heights)
2050 (Fdelete_window): Remove prototypes.
2051 (resize_frame_windows): Remove duplicate declaration.
2052
440a42e3
EZ
20532011-06-10 Eli Zaretskii <eliz@gnu.org>
2054
2055 * window.h (resize_frame_windows, resize_window_check)
2056 (delete_deletable_window, resize_root_window)
2057 (resize_frame_windows): Declare prototypes.
2058
2059 * window.c (resize_window_apply): Make definition be "static" to
2060 match the prototype.
2061
562dd5e9
MR
20622011-06-10 Martin Rudalics <rudalics@gmx.at>
2063
2064 * window.c: Remove declarations of Qwindow_size_fixed,
2065 window_min_size_1, window_min_size_2, window_min_size,
2066 size_window, window_fixed_size_p, enlarge_window, delete_window.
2067 Remove static from declaration of Qdelete_window, it's
2068 temporarily needed by Fbury_buffer.
2069 (replace_window): Don't assign orig_top_line and
2070 orig_total_lines.
2071 (Fdelete_window, delete_window): Remove. Window deletion is
2072 handled by window.el.
2073 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2074 Fdelete_window calls with calls to Qdelete_window.
2075 (Fdelete_other_windows): Remove. Deleting other windows is
2076 handled by window.el.
2077 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2078 handled in window.el.
2079 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2080 Window minimum sizes are handled in window.el.
2081 (shrink_windows, size_window, set_window_height)
2082 (set_window_width, change_window_heights, window_height)
2083 (window_width, CURBEG, CURSIZE, enlarge_window)
2084 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2085 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2086 handled in window.el.
2087 (make_dummy_parent): Rename to make_parent_window and give it a
2088 second argument horflag.
2089 (make_window): Don't set resize_proportionally any more.
2090 (Fsplit_window): Remove. Windows are split in window.el.
2091 (save_restore_action, save_restore_orig_size)
2092 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2093 Resize mini windows in window.el.
2094 (grow_mini_window, shrink_mini_window): Implement by calling
2095 Qresize_root_window_vertically, resize_window_check and
2096 resize_window_apply.
2097 (saved_window, Fset_window_configuration, save_window_save): Do
2098 not handle orig_top_line, orig_total_lines, and
2099 resize_proportionally.
2100 (window_min_height, window_min_width): Move to window.el.
2101 (keys_of_window): Move bindings for delete-other-windows,
2102 split-window, delete-window and enlarge-window to window.el.
2103
2104 * buffer.c: Temporarily extern Qdelete_window.
2105 (Fbury_buffer): Temporarily call Qdelete_window instead of
2106 Fdelete_window (Fbury_buffer will move to window.el soon).
2107
2108 * frame.c (set_menu_bar_lines_1): Remove code handling
2109 orig_top_line and orig_total_lines.
2110
2111 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2112 set_window_height but set heights directly.
2113 (change_frame_size_1): Use resize_frame_windows.
2114
2115 * xdisp.c (init_xdisp): Don't use set_window_height but set
2116 heights directly.
2117
2118 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2119 resize_frame_windows instead of change_window_heights and run
2120 run_window_configuration_change_hook.
2121
2122 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2123 instead of change_window_heights and run
2124 run_window_configuration_change_hook.
2125
1a13852e
MR
21262011-06-09 Martin Rudalics <rudalics@gmx.at>
2127
2128 * window.c (replace_window): Rename second argument REPLACEMENT to
2129 NEW. New third argument SETFLAG. Rewrite.
2130 (delete_window, make_dummy_parent): Call replace_window with
2131 third argument 1.
2132 (window_list_1): Move down in code.
2133 (run_window_configuration_change_hook): Move set_buffer part
2134 before select_frame_norecord part in order to unwind correctly.
2135 Rename count1 to count.
2136 (recombine_windows, delete_deletable_window, resize_root_window)
2137 (Fdelete_other_windows_internal)
2138 (Frun_window_configuration_change_hook, make_parent_window)
2139 (resize_window_check, resize_window_apply, Fresize_window_apply)
2140 (resize_frame_windows, Fsplit_window_internal)
2141 (Fdelete_window_internal, Fresize_mini_window_internal): New
2142 functions.
2143 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2144
f3d1777e
MR
21452011-06-08 Martin Rudalics <rudalics@gmx.at>
2146
496e208e
MR
2147 * window.h (window): Add some new members to window structure -
2148 normal_lines, normal_cols, new_total, new_normal, clone_number,
2149 splits, nest, prev_buffers, next_buffers.
2150 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2151 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2152
f3d1777e
MR
2153 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2154 Remove.
496e208e
MR
2155 (make_dummy_parent): Set new members of windows structure.
2156 (make_window): Move down in code. Handle new members of window
2157 structure.
2158 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2159 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2160 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2161 (Fset_window_prev_buffers, Fwindow_next_buffers)
2162 (Fset_window_next_buffers, Fset_window_clone_number): New
2163 functions.
2164 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2165 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2166 Doc-string fixes.
2167 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2168 Argument WINDOW can be now internal window too.
2169 (Fwindow_use_time): Move up in code.
2170 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2171 Rewrite doc-string.
2172 (Fset_window_configuration, saved_window)
2173 (Fcurrent_window_configuration, save_window_save): Handle new
2174 members of window structure.
b9e809c2
MR
2175 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2176 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2177 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2178 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2179 Qget_mru_window, Qresize_root_window,
2180 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2181 Qauto_buffer_name; staticpro them.
f3d1777e 2182
abde8f8c
MR
21832011-06-07 Martin Rudalics <rudalics@gmx.at>
2184
2185 * window.c (Fwindow_total_size, Fwindow_left_column)
2186 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2187 (Fwindow_list_1): New functions.
2188 (window_box_text_cols): Replace with window_body_cols.
2189 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2190 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2191 (delete_window, Fset_window_configuration): Call
2192 delete_all_subwindows with window as argument.
2193 (delete_all_subwindows): Take a window as argument and not a
2194 structure. Rewrite.
190b47e6
MR
2195 (window_loop): Remove handling of GET_LRU_WINDOW and
2196 GET_LARGEST_WINDOW.
2197 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2198
2199 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2200 window_box_text_cols. delete_all_subwindows now takes a
2201 Lisp_Object as argument.
abde8f8c
MR
2202
2203 * indent.c (compute_motion, Fcompute_motion): Use
2204 window_body_cols instead of window_box_text_cols.
2205
fa8a67e6
MR
2206 * frame.c (delete_frame): Call delete_all_subwindows with root
2207 window as argument.
2208
a54e3482
DC
22092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2210
2211 * fns.c (Fputhash): Document return value.
2212
60002bf5
CY
22132011-06-06 Chong Yidong <cyd@stupidchicken.com>
2214
2215 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2216
0c671da6 22172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2218
b862a52a 2219 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2220
be44ca6c
PE
2221 Check for overflow when converting integer to cons and back.
2222 * charset.c (Fdefine_charset_internal, Fdecode_char):
2223 Use cons_to_unsigned to catch overflow.
2224 (Fencode_char): Use INTEGER_TO_CONS.
2225 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2226 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2227 * data.c (long_to_cons, cons_to_long): Remove.
2228 (cons_to_unsigned, cons_to_signed): New functions.
2229 These signal an error for invalid or out-of-range values.
2230 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2231 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2232 * font.c (Ffont_variation_glyphs):
2233 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2234 * lisp.h: Include <intprops.h>.
2235 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2236 (cons_to_signed, cons_to_unsigned): New decls.
2237 (long_to_cons, cons_to_long): Remove decls.
2238 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2239 (Fprimitive_undo): Use CONS_TO_INTEGER.
2240 * xfns.c (Fx_window_property): Likewise.
2241 * xselect.c: Include <limits.h>.
2242 (x_own_selection, selection_data_to_lisp_data):
2243 Use INTEGER_TO_CONS.
2244 (x_handle_selection_request, x_handle_selection_clear)
2245 (x_get_foreign_selection, Fx_disown_selection_internal)
2246 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2247 (lisp_data_to_selection_data): Use cons_to_unsigned.
2248 (x_fill_property_data): Use cons_to_signed.
2249 Report values out of range.
2250
d1f3d2af
PE
2251 Check for buffer and string overflow more precisely.
2252 * buffer.h (BUF_BYTES_MAX): New macro.
2253 * lisp.h (STRING_BYTES_MAX): New macro.
2254 * alloc.c (Fmake_string):
2255 * character.c (string_escape_byte8):
2256 * coding.c (coding_alloc_by_realloc):
2257 * doprnt.c (doprnt):
2258 * editfns.c (Fformat):
2259 * eval.c (verror):
2260 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2261 since they may not be the same number.
2262 * editfns.c (Finsert_char):
2263 * fileio.c (Finsert_file_contents):
2264 Likewise for BUF_BYTES_MAX.
2265
dd52fcea
PE
2266 * image.c: Use ptrdiff_t, not int, for sizes.
2267 (slurp_file): Switch from int to ptrdiff_t.
2268 All uses changed.
2269 (slurp_file): Check that file size fits in both size_t (for
2270 malloc) and ptrdiff_t (for sanity and safety).
2271
7f9bbdbb
PE
2272 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2273 if b->modtime has its maximal value.
2274
dfe18f82
PE
2275 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2276
84acfcf0
PE
2277 Don't assume time_t can fit into int.
2278 * buffer.h (struct buffer.modtime): Now time_t, not int.
2279 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2280 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2281
ccd9a01a
PE
2282 Minor fixes for signed vs unsigned integers.
2283 * character.h (MAYBE_UNIFY_CHAR):
2284 * charset.c (maybe_unify_char):
2285 * keyboard.c (read_char, reorder_modifiers):
2286 XINT -> XFASTINT, since the integer must be nonnegative.
2287 * ftfont.c (ftfont_spec_pattern):
2288 * keymap.c (access_keymap, silly_event_symbol_error):
2289 XUINT -> XFASTINT, since the integer must be nonnegative.
2290 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2291 since it makes no difference and we prefer signed.
2292 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2293 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2294 nonnegative.
2295
d6d100dd
SM
22962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2297
2298 * window.h (Fwindow_frame): Declare.
2299
2b6148e4
PE
23002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2301
2302 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2303 (SPARE_MEMORY): Always define.
2304 (LARGE_REQUEST): Remove.
2305 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2306
f230ecc9
MR
23072011-06-06 Martin Rudalics <rudalics@gmx.at>
2308
727e958e
MR
2309 * lisp.h: Move EXFUNS for Fframe_root_window,
2310 Fframe_first_window and Fset_frame_selected_window to window.h.
2311
2312 * window.h: Move EXFUNS for Fframe_root_window,
2313 Fframe_first_window and Fset_frame_selected_window here from
2314 lisp.h.
2315
2316 * frame.c (Fwindow_frame, Fframe_first_window)
2317 (Fframe_root_window, Fframe_selected_window)
2318 (Fset_frame_selected_window): Move to window.c.
2319 (Factive_minibuffer_window): Move to minibuf.c.
2320 (Fother_visible_frames_p): New function.
2321
2322 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2323
f230ecc9
MR
2324 * window.c (decode_window, decode_any_window): Move up in code.
2325 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2326 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2327 (Fwindow_buffer): Move up and rewrite doc-string.
2328 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2329 (Fwindow_prev): New functions.
727e958e
MR
2330 (Fwindow_frame): Move here from frame.c. Accept any window as
2331 argument.
2332 (Fframe_root_window, Fframe_first_window)
2333 (Fframe_selected_window): Move here from frame.c. Accept frame
2334 or arbitrary window as argument. Update doc-strings.
2335 (Fminibuffer_window): Move up in code.
2336 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2337 (Fset_frame_selected_window): Move here from frame.c.
2338 Marginal rewrite.
727e958e
MR
2339 (Fselected_window, select_window, Fselect_window): Move up in
2340 code. Minor doc-string fixes.
f230ecc9 2341
4d09bcf6
PE
23422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2345 Do not assume that spare memory exists; that assumption is valid
2346 only if SYSTEM_MALLOC.
2347 (LARGE_REQUEST): New macro, so that the issue of large requests
2348 is separated from the issue of spare memory.
2349
810928a2
AS
23502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2351
172418ad
AS
2352 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2353 format. (Bug#8806)
2354
43f862f7
AS
2355 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2356
810928a2
AS
2357 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2358 before statements.
2359
a059fe24
JD
23602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2361
2362 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2363
2364 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2365
2366 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2367 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2368
989bf368
JB
23692011-06-05 Juanma Barranquero <lekktu@gmail.com>
2370
2371 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2372
4b80f674
CY
23732011-06-04 Chong Yidong <cyd@stupidchicken.com>
2374
2375 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2376 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2377 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2378 New error handlers.
4b80f674
CY
2379 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2380 Obey Vx_select_enable_clipboard_manager. Catch errors in
2381 x_clipboard_manager_save (Bug#8779).
2382 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2383 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2384
99a33b77 23852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2386
2387 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2388
99a33b77 23892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2390
2391 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2392 in the current matrix if keep_current_p is non-zero.
2393
8264569d
EZ
23942011-06-04 Eli Zaretskii <eliz@gnu.org>
2395
2396 * bidi.c (bidi_level_of_next_char): Fix last change.
2397
57f97249
EZ
23982011-06-03 Eli Zaretskii <eliz@gnu.org>
2399
fec2107c 2400 Support bidi reordering of text covered by display properties.
57f97249 2401
fec2107c
EZ
2402 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2403 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2404 (bidi_cache_search, bidi_cache_iterator_state)
2405 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2406 (bidi_level_of_next_char, bidi_move_to_visually_next):
2407 Support character positions inside a run of characters covered by a
fec2107c
EZ
2408 display string.
2409 (bidi_paragraph_init, bidi_resolve_explicit_1)
2410 (bidi_level_of_next_char): Call bidi_fetch_char and
2411 bidi_fetch_char_advance instead of FETCH_CHAR and
2412 FETCH_CHAR_ADVANCE.
2413 (bidi_init_it): Initialize new members.
2414 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2415 definitions.
2416 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2417 instead of using explicit *_CHAR codes.
d6d100dd
SM
2418 (bidi_resolve_explicit, bidi_resolve_weak):
2419 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2420 bidirectional text is supported only in multibyte buffers.
2421 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2422 it to initialize the frame_window_p member of struct bidi_it.
2423 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2424 (bidi_resolve_explicit, bidi_resolve_weak)
2425 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2426 bidi_it->nchars is non-positive.
2427 (bidi_level_of_next_char): Don't try to lookup the cache for the
2428 next/previous character if nothing is cached there yet, or if we
2429 were just reseat()'ed to a new position.
c40e2fb2 2430
0e14fe90
EZ
2431 * xdisp.c (set_cursor_from_row): Set start and stop points
2432 according to the row's direction when priming the loop that looks
2433 for the glyph on which to display cursor.
2434 (single_display_spec_intangible_p): Function deleted.
2435 (display_prop_intangible_p): Reimplement to call
2436 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2437 Accept 3 additional arguments needed by handle_display_spec.
2438 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2439 values: lists, `(when COND...)' forms, etc.
2440 (single_display_spec_string_p): Support property values that are
2441 lists with the argument STRING its top-level element.
2442 (display_prop_string_p): Fix the condition for processing a
2443 property that is a list to be consistent with handle_display_spec.
fec2107c 2444 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2445 last portion of handle_display_prop.
2446 (compute_display_string_pos): Accept additional argument
2447 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2448 value of a `display' property is a "replacing spec".
2449 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2450 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2451 the display property, but just return a value indicating whether
2452 the display property will replace the characters it covers.
2453 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2454 frame_window_p members of struct bidi_it.
d6d100dd
SM
2455 (compute_display_string_pos, compute_display_string_end):
2456 New functions.
fec2107c
EZ
2457 (push_it): Accept second argument POSITION, where pop_it should
2458 jump to continue iteration.
2459 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2460
fec2107c
EZ
2461 * keyboard.c (adjust_point_for_property): Adjust the call to
2462 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2463
2464 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2465 (bidi_init_it): Update prototypes.
2466 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2467 (compute_display_string_pos, compute_display_string_end):
2468 Declare prototypes.
fec2107c
EZ
2469 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2470 EMACS_INT.
fc6f18ce 2471
40087514 24722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2473
57f53182
PE
2474 Malloc failure behavior now depends on size of allocation.
2475 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2476 * lisp.h: Change signatures accordingly.
2477 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2478 All callers changed. (Bug#8762)
2479
2480 * gnutls.c: Use Emacs's memory allocators.
2481 Without this change, the gnutls library would invoke malloc etc.
2482 directly, which causes problems on non-SYNC_INPUT hosts, and which
2483 runs afoul of improving memory_full behavior. (Bug#8761)
2484 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2485 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2486 xfree instead of the default malloc, realloc, free.
2487 (Fgnutls_boot): No need to check for memory allocation failure,
2488 since xmalloc does that for us.
2489
ac32cd99 2490 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2491 * category.c (hash_get_category_set):
2492 * ccl.c (ccl_driver):
2493 * charset.c (Fdefine_charset_internal):
2494 * charset.h (struct charset.hash_index):
2495 * composite.c (get_composition_id, gstring_lookup_cache)
2496 (composition_gstring_put_cache):
2497 * composite.h (struct composition.hash_index):
2498 * dispextern.h (struct image.hash):
2499 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2500 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2501 (hashfn_equal, hashfn_user_defined, make_hash_table)
2502 (maybe_resize_hash_table, hash_lookup, hash_put)
2503 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2504 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2505 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2506 * image.c (make_image, search_image_cache, lookup_image)
2507 (xpm_put_color_table_h):
2508 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2509 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2510 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2511 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2512 * alloc.c (allocate_vectorlike):
2513 Check for overflow in vector size calculations.
2514 * ccl.c (ccl_driver):
2515 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2516 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2517 need to be updated by these changes.
40087514
PE
2518 * fns.c (make_hash_table, maybe_resize_hash_table):
2519 Check for integer overflow with large hash tables.
0de4bb68
PE
2520 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2521 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2522 (SXHASH_REDUCE): New macro.
2523 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2524 Use it instead of discarding useful hash info with large hash values.
2525 (sxhash_float): New function.
2526 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2527 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2528 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2529 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2530 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2531 Adjust signatures to match updated version of code.
2532 (consing_since_gc): Now EMACS_INT, since a single hash table can
2533 use more than INT_MAX bytes.
2534
698d32e2
DN
25352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2536
2537 Make it possible to build with GCC-4.6+ -O2 -flto.
2538
2539 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2540
fd6fa53f
SM
25412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2542
2543 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2544 Call minibuffer-inactive-mode.
2545
864db017
JB
25462011-05-31 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2549 Update dependencies.
2550
2ad0baf4
DN
25512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2552
2553 * data.c (init_data): Remove code for UTS, this system is not
2554 supported anymore.
2555
4fcc2638
DN
25562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2557
2558 Don't force ./temacs to start in terminal mode.
2559
2560 * frame.c (make_initial_frame): Initialize faces in all cases, not
2561 only when CANNOT_DUMP is defined.
2562 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2563
c56e0fd5
DN
25642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2565
2566 * dispnew.c (add_window_display_history): Use const for the string
2567 pointer. Remove declaration, not needed.
2568
333d54da 25692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2570
55d4c1b2 2571 Use 'inline', not 'INLINE'.
333d54da 2572 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2573 * alloc.c, fontset.c (INLINE): Remove.
2574 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2575 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2576 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2577 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2578 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2579
738db178
DN
25802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2581
2582 Make it possible to run ./temacs.
2583
2584 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2585 syms_of_callproc does the same thing. Remove test for
2586 "initialized", do it in the caller.
2587 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2588
620c53a6
SM
25892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2590
2591 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2592 (read_minibuf): Use get_minibuffer.
2593 (syms_of_minibuf): Use DEFSYM.
2594 (Qmetadata): New var.
2595 * data.c (Qbuffer): Don't make it static.
2596 (syms_of_data): Use DEFSYM.
2597
e003a292
PE
25982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2601 (CCL_CODE_MIN): New macro.
2602
ed008a6d
PE
26032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2604
3687c2ef
PE
2605 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2606
ed008a6d
PE
2607 * eval.c (Qdebug): Now static.
2608 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2609 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2610 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2611
d66c4c7c
CY
26122011-05-29 Chong Yidong <cyd@stupidchicken.com>
2613
2614 * image.c: Various fixes to ImageMagick code comments.
2615 (Fimagemagick_types): Doc fix.
2616
5fbc2025
PE
26172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2618
0196f88a
PE
2619 Minor fixes prompted by GCC 4.6.0 warnings.
2620
2621 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2622
5fbc2025
PE
2623 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2624 (x_clipboard_manager_save_all): Move extern decl to ...
2625 * xterm.h: ... here, so that it can be checked for consistency.
2626
1dd3c2d9
CY
26272011-05-29 Chong Yidong <cyd@stupidchicken.com>
2628
2629 * xselect.c (x_clipboard_manager_save_frame)
2630 (x_clipboard_manager_save_all): New functions.
2631 (Fx_clipboard_manager_save): Lisp function deleted.
2632
2633 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2634 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2635
2636 * xterm.h: Update prototype.
2637
5ba6571d
WX
26382011-05-28 William Xu <william.xwl@gmail.com>
2639
2640 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2641 exiting (Bug#8239).
2642
3eaff834
JM
26432011-05-28 Jim Meyering <meyering@redhat.com>
2644
e1900994 2645 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2646 * fns.c (to_uchar): Define.
2647 (crypto_hash_function): Use it to convert some newly-signed
2648 variables to unsigned, to avoid sign-extension bugs. For example,
2649 without this change, (md5 "truc") would evaluate to
2650 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2651 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2652 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2653
0f6990a7
PE
26542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 Integer overflow fixes.
c8a9ca5a 2657
08686060
PE
2658 * dbusbind.c: Serial number integer overflow fixes.
2659 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2660 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2661 to hold a serial number that is too large for a fixnum.
2662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2663 Check for serial numbers out of range. Decode any serial number
59568bf0 2664 that was so large that it became a float. (Bug#8722)
08686060 2665
2d1fc3c7
PE
2666 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2667 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2668 Use XFASTINT rather than XUINT when numbers are nonnegative.
2669 (xd_append_arg, Fdbus_method_return_internal):
2670 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2671 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2672 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2673 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2674 (Bug#8722)
2d1fc3c7 2675
c8a9ca5a
PE
2676 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2677
519e1d69
PE
2678 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2679
30569699
PE
2680 ccl: add integer overflow checks
2681 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2682 (IN_INT_RANGE): New macros.
2683 (ccl_driver): Use them to check for integer overflow when
2684 decoding a CCL program. Many of the new checks are whether XINT (x)
2685 fits in int; it doesn't always, on 64-bit hosts. The new version
2686 doesn't catch all possible integer overflows, but it's an
847044ea 2687 improvement. (Bug#8719)
30569699 2688
c11285dc
PE
2689 * alloc.c (make_event_array): Use XINT, not XUINT.
2690 There's no need for unsigned here.
2691
fdccd48e
PE
2692 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2693 This follows up to the 2011-05-06 change that substituted uintptr_t
2694 for EMACS_INT. This case wasn't caught back then.
2695
37910ab2
PE
2696 Rework Fformat to avoid integer overflow issues.
2697 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2698 now (part of C89). Include <verify.h>.
2699 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2700 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2701 (Fformat): Avoid the prepass trying to compute sizes; it was only
2702 approximate and thus did not catch overflow reliably. Instead, walk
2703 through the format just once, formatting and computing sizes as we go,
2704 checking for integer overflow at every step, and allocating a larger
2705 buffer as needed. Keep track separately whether the format is
2706 multibyte. Keep only the most-recently calculated precision, rather
2707 than them all. Record whether each argument has been converted to
2708 string. Use EMACS_INT, not int, for byte and char and arg counts.
2709 Support field widths and precisions larger than INT_MAX. Avoid
2710 sprintf's undefined behavior with conversion specifications such as %#d
2711 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2712 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2713 formatting out-of-range floating point numbers with int
9173deec 2714 formats. (Bug#8668)
37910ab2 2715
2e6578fb
PE
2716 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2717
0ae6bdee
PE
2718 * data.c: Avoid integer truncation in expressions involving floats.
2719 * data.c: Include <intprops.h>.
2720 (arith_driver): When there's an integer overflow in an expression
2721 involving floating point, convert the integers to floating point
2722 so that the resulting value does not suffer from catastrophic
2723 integer truncation. For example, on a 64-bit host (* 4
2724 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2725 Do not rely on undefined behavior after integer overflow.
2726
de883a70
PE
2727 merge count_size_as_multibyte, parse_str_to_multibyte
2728 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2729 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2730 Check for integer overflow.
2731 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2732 since it's now a duplicate of the other. This is more of
2733 a character than a buffer op, so better that it's in character.c.
2734 * fns.c, print.c: Adjust to above changes.
2735
2ff916cb
PE
27362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2737
2738 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2739
f1b54466
PE
27402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2741
fb1ac845
PE
2742 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2743 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2744 (x_clipboard_manager_save): Now static.
2745 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2746
f1b54466
PE
2747 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2748 (crypto_hash_function): Now static.
2749 Fix pointer signedness problems. Avoid unnecessary initializations.
2750
a9f737ee
CY
27512011-05-27 Chong Yidong <cyd@stupidchicken.com>
2752
2753 * termhooks.h (Vselection_alist): Make it terminal-local.
2754
2755 * terminal.c (create_terminal): Initialize it.
2756
2757 * xselect.c: Support for clipboard managers.
2758 (Vselection_alist): Move to termhooks.h as terminal-local var.
2759 (LOCAL_SELECTION): New macro.
2760 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2761 (symbol_to_x_atom): Remove gratuitous arg.
2762 (x_handle_selection_request, lisp_data_to_selection_data)
2763 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2764 (x_own_selection, x_get_local_selection, x_convert_selection):
2765 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2766 (some_frame_on_display): Delete unused function.
2767 (Fx_own_selection_internal, Fx_get_selection_internal)
2768 (Fx_disown_selection_internal, Fx_selection_owner_p)
2769 (Fx_selection_exists_p): New optional frame arg.
2770 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2771 (x_handle_selection_clear): Don't treat other terminals with the
2772 same keyboard specially. Use the terminal-local Vselection_alist.
2773 (x_clear_frame_selections): Use Frun_hook_with_args.
2774
2775 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2776
2777 * xterm.h: Add support for those atoms.
2778
e067f0c1
CY
27792011-05-26 Chong Yidong <cyd@stupidchicken.com>
2780
2781 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2782 (converted_selections, conversion_fail_tag): New global variables.
2783 (x_selection_request_lisp_error): Free the above.
2784 (x_get_local_selection): Remove unnecessary code.
2785 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2786 of converted selections stored in converted_selections.
2787 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2788 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2789 (x_convert_selection): New function.
2790 (x_handle_selection_event): Simplify.
2791 (x_get_foreign_selection): Don't ignore incoming requests while
2792 waiting for an answer; this will fail when we implement
2793 SAVE_TARGETS, and seems unnecessary anyway.
2794 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2795 (Vx_sent_selection_functions): Doc fix.
2796
0f4aebc0
LL
27972011-05-26 Leo Liu <sdl.web@gmail.com>
2798
2799 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2800
e61124cd
YM
28012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2802
2803 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2804
2805 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2806 for fringe update if it has periodic bitmap.
ac389d0c 2807 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2808 and fringe_bitmap_periodic_p.
2809
2810 * fringe.c (get_fringe_bitmap_data): New function.
2811 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2812 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2813 row. Mark glyph row for fringe update if periodicity changed.
2814
2815 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2816 for fringe update unless it has periodic bitmap.
2817
f16d9837
KH
28182011-05-25 Kenichi Handa <handa@m17n.org>
2819
2820 * xdisp.c (get_next_display_element): Set correct it->face_id for
2821 a static composition.
2822
e1b90ef6
LL
28232011-05-24 Leo Liu <sdl.web@gmail.com>
2824
2825 * deps.mk (fns.o):
2826 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2827
2828 * fns.c (crypto_hash_function, Fsha1): New function.
2829 (Fmd5): Use crypto_hash_function.
2830 (syms_of_fns): Add Ssha1.
2831
7400048f
PE
28322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 * gnutls.c: Remove unused macros.
2835 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2836 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2837 Remove macros that are defined and never used.
2838 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2839
abb71cf4
CY
28402011-05-22 Chong Yidong <cyd@stupidchicken.com>
2841
2842 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2843 (Fx_get_selection_internal): Minor cleanup.
2844 (Fx_own_selection_internal): Rename arguments for consistency with
2845 select.el.
2846
6307db39
PE
28472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2848
2849 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2850
f3d4e0a4
CY
28512011-05-22 Chong Yidong <cyd@stupidchicken.com>
2852
2853 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2854
4d8ade89
YM
28552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2856
2857 * dispnew.c (scrolling_window): Don't exclude the case that the
2858 last enabled row in the desired matrix touches the bottom boundary.
2859
32078c8d
GM
28602011-05-21 Glenn Morris <rgm@gnu.org>
2861
2862 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2863 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2864 and add some more files.
32078c8d 2865
7285dc67
EZ
28662011-05-20 Eli Zaretskii <eliz@gnu.org>
2867
2868 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2869 report_file_error introduced by the change from 2011-05-07.
2870
89d1bd22
PE
28712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * systime.h (Time): Define only if emacs is defined.
2874 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2875 where the include path doesn't have X11/X.h by default. See
2876 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2877
e23640bb 28782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2879
2880 * composite.c (find_automatic_composition): Fix previous change.
2881
b9704ad9
GM
28822011-05-20 Glenn Morris <rgm@gnu.org>
2883
2884 * lisp.mk: New file, split from Makefile.in.
2885 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2886 (shortlisp): Remove.
2887 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2888
4a720484
GM
28892011-05-19 Glenn Morris <rgm@gnu.org>
2890
2891 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2892 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2893 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2894 (lisp): Set the order to that of loadup.el.
2895 (shortlisp): Make it a copy of $lisp.
2896 (SOME_MACHINE_LISP): Remove.
2897 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2898 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2899
a28d4396
KH
29002011-05-18 Kenichi Handa <handa@m17n.org>
2901
2902 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2903 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2904 (find_automatic_composition): Mostly rewrite for efficiency.
2905
a2b1fa8e
JB
29062011-05-18 Juanma Barranquero <lekktu@gmail.com>
2907
2908 * makefile.w32-in: Update dependencies.
2909
8e1f5610
CS
29102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2911
2912 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2913 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2914
7025ee00 29152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2916
cdfa6eab
PE
2917 Fix some integer overflow issues, such as string length overflow.
2918
06d6db33
PE
2919 * insdel.c (count_size_as_multibyte): Check for string overflow.
2920
2b4560a8
PE
2921 * character.c (lisp_string_width): Check for string overflow.
2922 Use EMACS_INT, not int, for string indexes and lengths; in
2923 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2924 the resulting string length overflows an EMACS_INT; instead,
2925 report a string overflow if no precision given. When checking for
2926 precision exhaustion, use a check that cannot possibly have
2927 integer overflow. (Bug#8675)
2928 * character.h (lisp_string_width): Adjust to new signature.
2929
cb93f9be
PE
2930 * alloc.c (string_overflow): New function.
2931 (Fmake_string): Use it. This doesn't change behavior, but saves
2932 a few bytes and will simplify future changes.
2933 * character.c (string_escape_byte8): Likewise.
2934 * lisp.h (string_overflow): New decl.
2935
1a1f3366
PE
2936 Fixups, following up to the user-interface timestamp change.
2937 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2938 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2939 * msdos.c (mouse_get_pos): Likewise.
2940 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2941 * w32gui.h (Time): Define by including "systime.h" rather than by
2942 declaring it ourselves. (Bug#8664)
2943
d4e3e4d3
PE
2944 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2945 * image.c (clear_image_cache): Likewise.
2946
f6a24d19
PE
2947 * term.c (term_mouse_position): Don't assume time_t wraparound.
2948
08dc5ae6
PE
2949 Be more systematic about user-interface timestamps.
2950 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2951 and sometimes 'EMACS_UINT', to represent these timestamps.
2952 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2953 This makes the code easier to follow, and makes it easier to catch
2954 integer overflow bugs such as Bug#8664.
2955 * frame.c (Fmouse_position, Fmouse_pixel_position):
2956 Use Time, not unsigned long, for user-interface timestamps.
2957 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2958 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2959 * keyboard.h (last_event_timestamp): Likewise.
2960 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2961 * menu.h (xmenu_show): Likewise.
2962 * term.c (term_mouse_position): Likewise.
2963 * termhooks.h (struct input_event.timestamp): Likewise.
2964 (struct terminal.mouse_position_hook): Likewise.
2965 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2966 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2967 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2968 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2969 what it was before.
2970 * menu.h, termhooks.h: Include "systime.h", for Time.
2971
8e55734a
PE
2972 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2973 Don't assume that the difference between two unsigned long values
2974 can fit into an integer. At this point, we know button_down_time
2975 <= event->timestamp, so the difference must be nonnegative, so
2976 there's no need to cast the result if double-click-time is
2977 nonnegative, as it should be; check that it's nonnegative, just in
2978 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2979 apart (about 25 days). (Bug#8664)
8e55734a 2980
841f1b75 2981 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2982 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2983
3e26f69c
PE
2984 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2985 that always fit in int. Use a sentinel instead of a counter, to
2986 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2987 * frame.h (struct frame): Use int for menu_bar_items_used
2988 instead of EMACS_INT, since it always fits in int.
3e26f69c 2989
5cc152c0
PE
2990 * menu.c (grow_menu_items): Check for int overflow.
2991
d89eb65e
PE
2992 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2993
5235bd3e
PE
2994 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2995 Before, the code was not consistent. These values cannot exceed
2996 2**31 - 1 so there's no need to make them unsigned.
2997 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2998 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2999 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3000 as modifiers.
3001 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3002
bc827e23
PE
3003 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3004 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3005 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3006 presumably because the widths might not match.
3007
78eb494e
PE
3008 * window.c (size_window): Avoid needless test at loop start.
3009
04f2d78b
CB
30102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3011
3012 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3013
d2fc7e3d 30142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3015
3016 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3017
d2fc7e3d 30182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3019
3020 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3021 `width' to `bar_area_x' and `bar_area_width', respectively.
3022 (x_scroll_run): Take account of fringe background extension.
3023
04f2d78b
CB
3024 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3025 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3026 `bar_area_width', respectively.
3027 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3028 background extension.
3029
79b70037
GM
30302011-05-10 Jim Meyering <meyering@redhat.com>
3031
3032 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3033
2f142cc5
JB
30342011-05-10 Juanma Barranquero <lekktu@gmail.com>
3035
3036 * image.c (Finit_image_library): Return t for built-in image types,
3037 like pbm and xbm. (Bug#8640)
3038
57679c86
AS
30392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3040
3041 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3042
888c9e86
EZ
30432011-05-07 Eli Zaretskii <eliz@gnu.org>
3044
b0512a1d
EZ
3045 * w32console.c (Fset_screen_color): Doc fix.
3046 (Fget_screen_color): New function.
3047 (syms_of_ntterm): Defsubr it.
3048
7285dc67
EZ
3049 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3050 unlink the temporary file if Fcall_process didn't create it in the
3051 first place.
3052 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3053 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3054 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3055 cue to call_process_cleanup not to close that handle.
3056
4d3fcc8e
BK
30572011-05-07 Ben Key <bkey76@gmail.com>
3058
3059 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3060 one of two shell specific rules, either bootstrap-temacs-CMD or
3061 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3062 to the previous implementation of the bootstrap-temacs rule.
3063 The bootstrap-temacs-CMD rule is similar to the previous
3064 implementation of the bootstrap-temacs rule except that it
3065 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3066 variable.
3067
3068 These changes, along with some changes to nt/configure.bat,
3069 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3070 earlier fix to add support for --cflags and --ldflags options
3071 that include quotes so that it works whether make uses cmd or
3072 sh as the shell.
3073
b4289b64
MA
30742011-05-06 Michael Albinus <michael.albinus@gmx.de>
3075
3076 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3077 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3078 is a constant.
3079 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3080 a string. Handle both cases.
3081 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3082 (Fdbus_register_method): Use Qinvalid_function.
3083
af4c0e28
JB
30842011-05-06 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * makefile.w32-in: Update dependencies.
3087 (LISP_H): Add inttypes.h and stdin.h.
3088 (PROCESS_H): Add unistd.h.
3089
c51453d9
EZ
30902011-05-06 Eli Zaretskii <eliz@gnu.org>
3091
3092 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3093 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3094
8ff0ac3c 30952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3096
4c4b566b
PE
3097 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3098
aab2b9b5
PE
3099 * term.c (vfatal): Remove stray call to va_end.
3100 It's not needed and the C Standard doesn't allow it here anyway.
3101
c378da0b
PE
3102 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3103 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3104
288b08c7
PE
3105 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3106 bytes.
3107
e3601888
PE
3108 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3109
db6c0e74
PE
3110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3111
dd5963ea
PE
3112 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3113
88c9450f
PE
3114 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3115
2f9442b8
PE
3116 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3117
c032b5f8
PE
3118 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3119 * charset.c (Fdefine_charset_internal): Don't initialize
3120 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3121 32-bit int (Bug#8600).
a108c10b
PE
3122
3123 * lread.c (read_integer): Be more consistent with string-to-number.
3124 Use string_to_number to do the actual conversion; this avoids
3125 rounding errors and fixes some other screwups. Without this fix,
3126 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3127 (digit_to_number): Move earlier, for benefit of read_integer.
3128 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3129 not a digit in any supported base. (Bug#8602)
a108c10b 3130
ad5f9eea
PE
3131 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3132
aec1708a
PE
3133 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3134 to match comment at start of function. This also removes a
3135 GCC warning about overflow in a 32+64-bit port.
3136
47be4ab5
PE
3137 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3138
371cac43
PE
3139 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3140 Reported by Stefan Monnier in
3141 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3142 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3143 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3144
d01a7826
PE
3145 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3146 (EMACS_UINTPTR): Likewise, with uintptr_t.
3147
7fd47d5c
PE
3148 * lisp.h: Prefer 64-bit EMACS_INT if available.
3149 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3150 on 32-bit hosts that have 64-bit int, so that they can access
3151 large files.
122b0c86
PE
3152 However, temporarily disable this change unless the temporary
3153 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3154
8727937b
PE
3155 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3156
8ac068ac
PE
3157 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3158 This removes an assumption that EMACS_INT and long are the same
3159 width as pointers. The assumption is true for Emacs porting targets
3160 now, but we want to make other targets possible.
3161 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3162 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3163 In the rest of the code, change types of integers that hold casted
3164 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3165 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3166 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3167 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3168 No need to cast type when ORing.
3169 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3170 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3171 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3172 assume EMACS_INT is the same width as char *.
3173 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3174 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3175 Remove no-longer-needed casts.
3176 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3177 (xg_tool_bar_help_callback, xg_make_tool_item):
3178 Use EMACS_INTPTR to hold an integer
3179 that will be cast to void *; this can avoid a GCC warning
3180 if EMACS_INT is not the same width as void *.
3181 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3182 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3183 (current_message_1, set_message_1):
3184 Use a local to convert to proper width without a cast.
3185 * xmenu.c (dialog_selection_callback): Likewise.
3186
ede49d71
PE
3187 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3188 Also, don't assume VALBITS / RAND_BITS is less than 5,
3189 and don't rely on undefined behavior when shifting a 1 left into
3190 the sign bit.
3191 * lisp.h (get_random): Change signature to match.
3192
2f30ecd0
PE
3193 * lread.c (hash_string): Use size_t, not int, for hash computation.
3194 Normally we prefer signed values; but hashing is special, because
3195 it's better to use unsigned division on hash table sizes so that
3196 the remainder is nonnegative. Also, size_t is the natural width
3197 for hashing into memory. The previous code used 'int', which doesn't
3198 retain enough info to hash well into very large tables.
3199 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3200
2a866e7b
PE
3201 * dbusbind.c: Don't possibly lose pointer info when converting.
3202 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3203 Use XPNTR rather than XHASH, so that the high-order bits of
3204 the pointer aren't lost when converting through void *.
3205
51639eac
PE
3206 * eval.c (Fautoload): Don't double-shift a pointer.
3207
92394119
PE
3208 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3209
dbdb9a7c
JB
32102011-05-06 Juanma Barranquero <lekktu@gmail.com>
3211
3212 * gnutls.c (DEF_GNUTLS_FN):
3213 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3214
db7a0b4f
AS
32152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3216
3217 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3218 marker. (Bug#8610)
3219
f7ff1b0f 32202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3221
3222 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3223 New version that can reserve upto 2GB of heap space.
3224
f7ff1b0f 32252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3226
3227 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3228
639c109b
TZ
32292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3230
3231 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3232 `gnutls_certificate_set_x509_key_file'.
3233
d2127135
JB
32342011-05-05 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3237 Update dependencies.
3238
e968f4f3
JB
32392011-05-04 Juanma Barranquero <lekktu@gmail.com>
3240
3241 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3242 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3243 Remove unused parameter `fildes'.
3244 * process.c (read_process_output, send_process): Don't pass it.
3245
84d358f0
JB
32462011-05-04 Juanma Barranquero <lekktu@gmail.com>
3247
3248 Fix previous change: the library cache is defined in w32.c.
3249 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3250 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3251
0898ca10
JB
32522011-05-04 Juanma Barranquero <lekktu@gmail.com>
3253
3254 Implement dynamic loading of GnuTLS on Windows.
3255
3256 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3257 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3258 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3259 Declare.
3260
3261 * gnutls.c (Qgnutls_dll): Define.
3262 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3263 (gnutls_*): Declare function pointers.
3264 (init_gnutls_functions): New function to initialize function pointers.
3265 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3266 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3268 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3269 (emacs_gnutls_write, emacs_gnutls_read)
3270 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3271 (Fgnutls_available_p): New function.
3272 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3273 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3274 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3275
3276 * image.c: Include w32.h.
3277 (Vimage_type_cache): Delete.
3278 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3279 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3280 (w32_delayed_load): Move to w32.c.
3281
3282 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3283
3284 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3285 (w32_delayed_load): Move from image.c. When loading a library, record
3286 its filename in the :loaded-from property of the library id.
3287 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3288 Initialize and staticpro them.
3289 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3290
3291 * process.c: Include lisp.h before w32.h, not after.
3292 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3293 instead of gnutls_record_check_pending.
3294
3295 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3296
ff4de4aa
TZ
32972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3298
3299 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3300 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3301 as passed in.
3302
abe95abb
JD
33032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3304
3305 * xterm.c (x_set_frame_alpha): Do not set property on anything
3306 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3307
e16e55d4
JB
33082011-05-02 Juanma Barranquero <lekktu@gmail.com>
3309
3310 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3311
bafcf6a5
JB
33122011-05-02 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3315 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3316 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3317 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3318 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3319 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3320 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3321 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3322 (Qgnutls_bootprop_callbacks_verify): Make static.
3323
e7a6747f
AS
33242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3325
19ed11ba
AS
3326 * callproc.c: Indentation fixup.
3327
e7a6747f 3328 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3329 (wait_for_termination, interruptible_wait_for_termination):
3330 Move after wait_for_termination_1.
e7a6747f 3331
1ef14cb4
LMI
33322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3333
3334 * sysdep.c (interruptible_wait_for_termination): New function
3335 which is like wait_for_termination, but allows keyboard
3336 interruptions.
3337
3338 * callproc.c (Fcall_process): Add (:file "file") as an option for
3339 the STDOUT buffer.
3340 (Fcall_process_region): Ditto.
3341
330d880c
EZ
33422011-04-30 Eli Zaretskii <eliz@gnu.org>
3343
8db90b73
EZ
3344 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3345 rather than `XVECTOR (FOO)->size'.
3346
330d880c
EZ
3347 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3348 inttypes.h, as a gnulib replacement is used if it not available in
3349 system headers.
3350
15cbd324
EZ
33512011-04-21 Eli Zaretskii <eliz@gnu.org>
3352
3353 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3354 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3355 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3356
3357 * coding.c (coding_alloc_by_realloc): Error out if destination
3358 will grow beyond MOST_POSITIVE_FIXNUM.
3359 (decode_coding_emacs_mule): Abort if there isn't enough place in
3360 charbuf for the composition carryover bytes. Reserve an extra
3361 space for up to 2 characters produced in a loop.
3362 (decode_coding_iso_2022): Abort if there isn't enough place in
3363 charbuf for the composition carryover bytes.
3364
33652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3366
ae940cca
EZ
3367 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3368 aborting when %lld or %lll format is passed.
3369 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3370 %llo or %llx format is passed. (Bug#8545)
3371
03ab8921
EZ
3372 * window.c (window_scroll_line_based): Use a marker instead of
3373 simple variables to record original value of point. (Bug#7952)
3374
afda1437
EZ
3375 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3376 produced by %s or %c overflows available buffer space. (Bug#8545)
3377
f76dee0c
PE
33782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3381 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3382
fdc5744d
JB
33832011-04-28 Juanma Barranquero <lekktu@gmail.com>
3384
3385 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3386
638f053a
JB
33872011-04-28 Juanma Barranquero <lekktu@gmail.com>
3388
3389 * keyboard.c (Qdelayed_warnings_hook): Define.
3390 (command_loop_1): Run `delayed-warnings-hook'
3391 if Vdelayed_warnings_list is non-nil.
3392 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3393 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3394
d178f871
EZ
33952011-04-28 Eli Zaretskii <eliz@gnu.org>
3396
3397 * doprnt.c (doprnt): Don't return value smaller than the buffer
3398 size if the message was truncated. (Bug#8545).
3399
b124fd93
JB
34002011-04-28 Juanma Barranquero <lekktu@gmail.com>
3401
3402 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3403 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3404
e810457d
PE
34052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3406
3407 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3408
ea51cceb
JB
34092011-04-27 Juanma Barranquero <lekktu@gmail.com>
3410
3411 * makefile.w32-in: Update dependencies.
3412
94dcfacf
EZ
34132011-04-27 Eli Zaretskii <eliz@gnu.org>
3414
3415 Improve `doprnt' and its usage. (Bug#8545)
3416 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3417 `format_end'. Remove support for %l as a conversion specifier.
3418 Don't use xrealloc. Improve diagnostics when the %l size modifier
3419 is used. Update the commentary.
3420
3421 * eval.c (verror): Simplify calculation of size_t.
3422
3423 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3424 messages.
3425
f61f41d7
PE
34262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3427
3428 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3429 change.
3430
96fb4434
PE
34312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3434 This makes this file independent of the recent pseudovector change.
3435
671875da 34362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3437
69e9b5a3
PE
3438 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3439
b5f869a7 3440 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3441 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3442 Remove unused local.
c8926152 3443 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3444
841a1577 3445 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3446 GCC 4.6.0 optimizes based on type-based alias analysis.
3447 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3448 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3449 != &v->size, and therefore "v->size = 1; b->size = 2; return
3450 v->size;" must therefore return 1. This assumption is incorrect
3451 for Emacs, since it type-puns struct Lisp_Vector * with many other
3452 types. To fix this problem, this patch adds a new type struct
f904488f 3453 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3454 and pseudovectors, and helps optimizing compilers not get fooled
3455 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3456 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3457 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3458 the size member.
eab3844f
PE
3459 (XSETPVECTYPE): Rewrite in terms of new macro.
3460 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3461 This is a bit clearer, and further avoids the possibility of
3462 undesirable aliasing.
3463 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3464 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3465 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3466 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3467 (ASIZE): Now uses header.size rather than size.
3468 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3469 to avoid the hassle of writing XVECTOR (foo)->header.size.
3470 (struct vectorlike_header): New type.
eab3844f
PE
3471 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3472 object, to help avoid aliasing.
3473 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3474 (SUBRP): Likewise, since Lisp_Subr is a special case.
3475 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3476 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3477 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3478 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3479 changed to be "header.size" and "header.next".
3480 * buffer.h (struct buffer): Likewise.
3481 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3482 * frame.h (struct frame): Likewise.
3483 * process.h (struct Lisp_Process): Likewise.
3484 * termhooks.h (struct terminal): Likewise.
3485 * window.c (struct save_window_data, struct saved_window): Likewise.
3486 * window.h (struct window): Likewise.
3487 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3488 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3489 * buffer.c (init_buffer_once): Likewise.
3490 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3491 special case.
3492 * process.c (Fformat_network_address): Use local var for size,
3493 for brevity.
3494
0df1eac5
PE
3495 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3496
847ab9d1 3497 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3498 * data.c (atof): Remove decl; no longer used or needed.
3499 (digit_to_number): Move to lread.c.
3500 (Fstring_to_number): Use new string_to_number function, to be
3501 consistent with how the Lisp reader treats infinities and NaNs.
3502 Do not assume that floating-point numbers represent EMACS_INT
3503 without losing information; this is not true on most 64-bit hosts.
3504 Avoid double-rounding errors, by insisting on integers when
3505 parsing non-base-10 numbers, as the documentation specifies.
3506 * lisp.h (string_to_number): New decl, replacing ...
3507 (isfloat_string): Remove.
bc0a5c13 3508 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3509 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3510 appears to have been a coding error. Similarly, do not accept
3511 strings like +-1e0 as floating point numbers. Do not report
3512 overflow for integer overflows unless the base is not 10 which
3513 means we have no simple and reliable way to continue.
3514 Break out the floating-point parsing into a new
3515 function string_to_number, so that Fstring_to_number parses
3516 floating point numbers consistently with the Lisp reader.
04f2d78b 3517 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3518 (E_CHAR, EXP_INT): Remove, replacing with ...
3519 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3520 (string_to_number): New function, replacing isfloat_string.
3521 This function checks for valid syntax and produces the resulting
3522 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3523 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3524 so that overflow for non-base-10 numbers is reported only when
3525 there's no portable and simple way to convert to floating point.
452f4150 3526
67769ffc
PE
3527 * textprop.c (set_text_properties_1): Rewrite for clarity,
3528 and to avoid GCC warning about integer overflow.
3529
c20db43f
PE
3530 * intervals.h (struct interval): Use EMACS_INT for members
3531 where EMACS_UINT might cause problems. See
3532 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3533 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3534 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3535 All uses changed.
37aa2f85
PE
3536 (offset_intervals): Tell GCC not to worry about length overflow
3537 when negating a negative length.
c20db43f 3538
2538aa2f
PE
3539 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3540 (overrun_check_free): Likewise.
3541
f2d3008d
PE
3542 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3543 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3544 word size.
3545
ec8df744
PE
3546 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3547 (gnutls_make_error): Rename local to avoid shadowing.
3548 (gnutls_emacs_global_deinit): ifdef out; not used.
3549 (Fgnutls_boot): Use const for pointer to readonly storage.
3550 Comment out unused local. Fix pointer signedness problems.
3551
640ee02d
PE
3552 * lread.c (openp): Don't stuff size_t into an 'int'.
3553 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3554 about possible signed overflow.
3555
6048fb2a
PE
3556 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3557 (GDK_KEY_g): Don't define if already defined.
3558 (xg_prepare_tooltip): Avoid pointer signedness problem.
3559 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3560
fa3c87e1
PE
3561 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3562 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3563
2172544b
PE
3564 * xfns.c (Fx_window_property): Simplify a bit,
3565 to make a bit faster and to avoid GCC 4.6.0 warning.
3566 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3567
9b821a21
PE
3568 * fns.c (internal_equal): Don't assume size_t fits in int.
3569
3c616cfa
PE
3570 * alloc.c (compact_small_strings): Tighten assertion a little.
3571
c2982e87
PE
3572 Replace pEd with more-general pI, and fix some printf arg casts.
3573 * lisp.h (pI): New macro, generalizing old pEd macro to other
3574 conversion specifiers. For example, use "...%"pI"d..." rather
3575 than "...%"pEd"...".
3576 (pEd): Remove. All uses replaced with similar uses of pI.
3577 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3578 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3579 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3580 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3581 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3582 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3583 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3584 64-bit hosts.
3585 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3586 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3587 * print.c (safe_debug_print, print_object): Likewise.
3588 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3589 to int.
6f04d126
PE
3590 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3591 avoiding the 0 flag, which is not portable.
c2982e87
PE
3592 * process.c (Fmake_network_process): Use pI to avoid cast.
3593 * region-cache.c (pp_cache): Likewise.
3594 * xdisp.c (decode_mode_spec): Likewise.
3595 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3596 behavior on 64-bit hosts with printf arg.
6f04d126 3597 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3598 (x_stop_queuing_selection_requests): Likewise.
3599 (x_get_window_property): Don't truncate byte count to an 'int'
3600 when tracing.
0b432f21 3601
5e073ec7
PE
3602 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3603 here, since it parses constructs like leading '-' and spaces,
3604 which are not wanted; and it overflows with large numbers.
3605 Instead, simply match F[0-9]+, which is what is wanted anyway.
3606
36372bf9
PE
3607 * alloc.c: Remove unportable assumptions about struct layout.
3608 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3609 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3610 (allocate_vectorlike, make_pure_vector): Use the new macros,
3611 plus offsetof, to remove unportable assumptions about struct layout.
3612 These assumptions hold on all porting targets that I know of, but
3613 they are not guaranteed, they're easy to remove, and removing them
3614 makes further changes easier.
3615
0b432f21
PE
3616 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3617 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3618 (string_overrun_cookie): Now const. Use initializers that
3619 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3620 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3621 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3622 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3623 multiple of sizeof (EMACS_INT); it need not be, if
3624 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3625 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3626
895009e1
JB
36272011-04-26 Juanma Barranquero <lekktu@gmail.com>
3628
3629 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3630
6a7a1b0b
TZ
36312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3632
3633 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3634 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3635 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3636
841a1577 36372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3638
3639 * lisp.h (Qdebug): List symbol.
895009e1 3640 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3641 * keyboard.c (debug-on-event): New variable.
3642 (handle_user_signal): Break into debugger when debug-on-event
3643 matches the current signal symbol.
3644
f2d3ba6f
DN
36452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3646
3647 * alloc.c (check_sblock, check_string_bytes)
3648 (check_string_free_list): Convert to standard C.
3649
42ce4c63
TZ
36502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3651
3652 * w32.c (emacs_gnutls_push): Fix typo.
3653
825cd63c
EZ
36542011-04-25 Eli Zaretskii <eliz@gnu.org>
3655
fb11d64d
EZ
3656 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3657 "cast to pointer from integer of different size".
3658
825cd63c
EZ
3659 Improve doprnt and its use in verror. (Bug#8545)
3660 * doprnt.c (doprnt): Document the set of format control sequences
3661 supported by the function. Use SAFE_ALLOCA instead of always
3662 using `alloca'.
3663
3664 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3665 is one byte too soon. Don't use xrealloc; instead xfree and
3666 xmalloc anew.
3667
e061a11b
TZ
36682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3669
3670 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3671 callbacks stage.
3672
3673 * gnutls.c: Renamed global_initialized to
3674 gnutls_global_initialized. Added internals for the
3675 :verify-hostname-error, :verify-error, and :verify-flags
3676 parameters of `gnutls-boot' and documented those parameters in the
3677 docstring. Start callback support.
9173deec
JB
3678 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3679 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3680 on error. Return error code.
e061a11b
TZ
3681 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3682 (emacs_gnutls_read): Likewise.
3683 (Fgnutls_boot): Return handshake error code.
3684 (emacs_gnutls_handle_error): New function.
3685 (wsaerror_to_errno): Likewise.
3686
3687 * w32.h (emacs_gnutls_pull): Add prototype.
3688 (emacs_gnutls_push): Likewise.
3689
3690 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3691 (emacs_gnutls_push): Likewise.
3692
36932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3694
3695 * process.c (wait_reading_process_output): Check if GnuTLS
3696 buffered some data internally if no FDs are set for TLS
3697 connections.
3698
3699 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3700 (LIBS): Link to USER_LIBS.
3701 ($(BLD)/gnutls.$(0)): New target.
3702
fa6996bc
EZ
37032011-04-24 Eli Zaretskii <eliz@gnu.org>
3704
eb35682e
EZ
3705 * xdisp.c (handle_single_display_spec): Rename the
3706 display_replaced_before_p argument into display_replaced_p, to
3707 make it consistent with the commentary. Fix typos in the
3708 commentary.
3709
e2ad650c
EZ
3710 * textprop.c (syms_of_textprop): Remove dead code.
3711 (copy_text_properties): Delete obsolete commentary about an
3712 interface that was deleted long ago. Fix typos in the description
3713 of arguments.
3714
1b2de274
EZ
3715 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3716 to changes in oldXMenu/XMenu.h from 2011-04-16.
3717 <menu_help_message, prev_menu_help_message>: Constify.
3718 (IT_menu_make_room): menu->help_text is now `const char **';
3719 adjust.
3720
3721 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3722 to changes in oldXMenu/XMenu.h from 2011-04-16.
3723 (struct XMenu): Declare `help_text' `const char **'.
3724
3725 * xfaces.c <Qunspecified>: Make extern again.
3726
3727 * syntax.c: Include sys/types.h before including regex.h, as
3728 required by Posix.
3729
762b15be
EZ
3730 * doc.c (get_doc_string): Improve the format passed to `error'.
3731
3732 * doprnt.c (doprnt): Improve commentary.
3733
3734 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3735
3736 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3737 them with etags.
3738
f1052e5d
EZ
3739 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3740 changes in globals.h immediately force recompilation.
762b15be
EZ
3741 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3742 $(CURDIR)/s/ms-w32.h.
3743 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3744
fa6996bc
EZ
3745 * character.c (Fchar_direction): Function deleted.
3746 (syms_of_character): Don't defsubr it.
3747 <char-direction-table>: Deleted.
3748
e6c3da20
EZ
37492011-04-23 Eli Zaretskii <eliz@gnu.org>
3750
3751 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3752 * doprnt.c: Include limits.h.
3753 (SIZE_MAX): New macro.
04f2d78b
CB
3754 (doprnt): Return a size_t value. 2nd arg is now size_t.
3755 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3756 Improve overflow protection. Support `l' modifier for integer
3757 conversions. Support %l conversion. Don't assume an EMACS_INT
3758 argument for integer conversions and for %c.
3759
3760 * lisp.h (doprnt): Restore prototype.
3761
3762 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3763 $(SRC)/character.h.
3764
3765 * Makefile.in (base_obj): Add back doprnt.o.
3766
3767 * deps.mk (doprnt.o): Add back prerequisites.
3768 (callint.o): Depend on character.h.
3769
3770 * eval.c (internal_lisp_condition_case): Include the handler
3771 representation in the error message.
3772 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3773 when breaking from the loop.
3774
3775 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3776
3777 * callint.c (Fcall_interactively): When displaying error message
3778 about invalid control letter, pass the character's codepoint, not
3779 a pointer to its multibyte form. Improve display of the character
3780 in octal and display also its hex code.
3781
3782 * character.c (char_string): Use %x to display the (unsigned)
3783 codepoint of an invalid character, to avoid displaying a bogus
3784 negative value.
3785
3786 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3787 `error', not SYMBOL_NAME itself.
3788
3789 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3790 character arguments to `error'.
3791
3792 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3793 to `error' in error message about FINAL_CHAR argument. Make sure
3794 FINAL_CHAR is a character, and use %c when it is passed as
3795 argument to `error'.
3796
4ffd0d6b 37972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3798
3799 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3800
3801 * w32.c: Include <time.h>.
3802 (sys_localtime): New function.
3803
4ffd0d6b 38042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3805
3806 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3807
4ffd0d6b 3808 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3809
4ffd0d6b 38102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3811
4ffd0d6b
GM
3812 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3813 zombies (Bug#8467).
aac0c6e3 3814
04c56954
EZ
38152011-04-19 Eli Zaretskii <eliz@gnu.org>
3816
3817 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3818 gl_state.e_property when gl_state.object is Qt.
3819
3820 * insdel.c (make_gap_larger): Remove limitation of buffer size
3821 to <= INT_MAX.
3822
16a43933
CY
38232011-04-18 Chong Yidong <cyd@stupidchicken.com>
3824
3825 * xdisp.c (lookup_glyphless_char_display)
3826 (produce_glyphless_glyph): Handle cons cell entry in
3827 glyphless-char-display.
3828 (Vglyphless_char_display): Document it.
3829
3830 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3831 glyphless-char-display.
3832
4581706e
CY
38332011-04-17 Chong Yidong <cyd@stupidchicken.com>
3834
3835 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3836
3837 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3838
3839 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3840 definition for no-X builds.
3841
4887c6e2 38422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3843
fd35b6f9
PE
3844 Static checks with GCC 4.6.0 and non-default toolkits.
3845
5c1ccb01
PE
3846 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3847
006c5daa
PE
3848 * process.c (keyboard_bit_set): Define only if SIGIO.
3849 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3850 (send_process): Repair possible setjmp clobbering.
3851
efc736d3
PE
3852 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3853
4e2fe2e6
PE
3854 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3855
f97334a2
PE
3856 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3857
4e75f29d
PE
3858 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3859 Define only if needed.
3860
90efadd1
PE
3861 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3862 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3863 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3864
3c647824
PE
3865 * dispextern.h (struct redisplay_interface): Rename param
3866 to avoid shadowing.
e264f262 3867 * termhooks.h (struct terminal): Likewise.
761383f4 3868 * xterm.c (xembed_send_message): Likewise.
3c647824 3869
b58c5c4a
PE
3870 * insdel.c (make_gap_smaller): Define only if
3871 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3872
cad59032
PE
3873 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3874 it.
3875
c339dc2e
PE
3876 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3877 so that we aren't warned about unused symbols.
3878
91a3e27b
PE
3879 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3880
399c71d3 3881 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3882
8ffc96f5
PE
3883 * xfns.c (x_real_positions): Mark locals as initialized.
3884
eef9bc79
PE
3885 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3886
098db9dd
PE
3887 * xterm.c: Fix problems found by static analysis with other toolkits.
3888 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3889 (x_dispatch_event): Declare static if USE_GTK, and
3890 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3891 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3892 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3893 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3894 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3895
eb18f6cc
PE
3896 * xmenu.c (menu_help_callback): Pointer type fixes.
3897 Use const pointers when pointing at readonly data. Avoid pointer
3898 signedness clashes.
3899 (FALSE): Remove unused macro.
3900 (update_frame_menubar): Remove unused decl.
3901
1fe72bf8
PE
3902 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3903
60d9e1db
PE
3904 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3905 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3906 (single_menu_item): Rename local to avoid shadowing.
3907
39261c26
PE
3908 * keyboard.c (make_lispy_event): Remove unused local var.
3909
018c5e19
PE
3910 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3911 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3912
63d2b86e
PE
3913 * bitmaps: Change bitmaps from unsigned char back to the X11
3914 compatible char. Avoid the old compiler warnings about
3915 out-of-range initializers by using, for example, '\xab' rather
3916 than 0xab.
3917
aefd87e1
PE
3918 * xgselect.c (xgselect_initialize): Check vs interface
3919 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3920
bf501fb9
PE
3921 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3922
e9829fdf
PE
3923 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3924 to read-only memory.
3925
1086c095
PE
3926 * fns.c (vector): Remove; this old hack is no longer needed.
3927
2baccd04 3928 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3929 Remove unused var.
dde42981 3930 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3931
72391843 3932 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3933
436c16df 3934 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3935 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3936 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3937
92bb796d 3938 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3939 (x_term_init): Remove local to avoid shadowing.
92bb796d 3940
764430a3 3941 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3942
3943 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3944 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3945
d1dfb56c
EZ
39462011-04-16 Eli Zaretskii <eliz@gnu.org>
3947
c4354cb4
EZ
3948 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3949
d1dfb56c
EZ
3950 Fix regex.c, syntax.c and friends for buffers > 2GB.
3951 * syntax.h (struct gl_state_s): Declare character position members
3952 EMACS_INT.
3953
3954 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3955
04f2d78b
CB
3956 * textprop.c (verify_interval_modification, interval_of):
3957 Declare arguments EMACS_INT.
d1dfb56c
EZ
3958
3959 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3960 EMACS_INT.
3961
3962 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3963
3964 * indent.c (Fvertical_motion): Local variable it_start is now
3965 EMACS_INT.
3966
3967 * regex.c (re_match, re_match_2, re_match_2_internal)
3968 (bcmp_translate, regcomp, regexec, print_double_string)
3969 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3970 (re_compile_pattern, re_exec): Declare arguments and local
3971 variables `size_t' and `ssize_t' and return values `regoff_t', as
3972 appropriate.
3973 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3974 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3975 <compile_stack_type>: `size' and `avail' are now `size_t'.
3976
3977 * regex.h <regoff_t>: Use ssize_t, not int.
3978 (re_search, re_search_2, re_match, re_match_2): Arguments that
3979 specify buffer/string position and length are now ssize_t and
3980 size_t. Return type is regoff_t.
3981
613052cd
BK
39822011-04-16 Ben Key <bkey76@gmail.com>
3983
3984 * nsfont.m: Fixed bugs in ns_get_family and
3985 ns_descriptor_to_entity that were caused by using free to
3986 deallocate memory blocks that were allocated by xmalloc (via
3987 xstrdup). This caused Emacs to crash when compiled with
3988 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3989 --enable-checking=xmallocoverrun). xfree is now used to
3990 deallocate these memory blocks.
3991
4170f62f 39922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3993
71b41406
PE
3994 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3995
9587a89d
PE
3996 emacs_write: Accept and return EMACS_INT for sizes.
3997 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3998 et seq.
3999 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4000 Accept and return EMACS_INT.
4001 (emacs_gnutls_write): Return the number of bytes written on
4002 partial writes.
4003 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4004 (emacs_read, emacs_write): Remove check for negative size, as the
4005 Emacs source code has been audited now.
9587a89d
PE
4006 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4007 (emacs_read, emacs_write): Use it.
273a5f82
PE
4008 * process.c (send_process): Adjust to the new signatures of
4009 emacs_write and emacs_gnutls_write. Do not attempt to store
4010 a byte offset into an 'int'; it might overflow.
9587a89d 4011 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4012
3e047f51
PE
4013 * sound.c: Don't assume sizes fit in 'int'.
4014 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4015 Return EMACS_INT, not int.
3e047f51 4016 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4017 Accept EMACS_INT, not int.
4018 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4019 record read return values.
4020
cc39a9db
BK
40212011-04-15 Ben Key <bkey76@gmail.com>
4022
c9d0ec6d
JB
4023 * keyboard.c (Qundefined): Don't declare static since it is used
4024 in nsfns.m.
4025 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4026 static since they are used in nsfont.m.
cc39a9db 4027
6c60eb9f
SM
40282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4029
4030 * process.c (Qprocessp): Don't declare static.
4031 * lisp.h (Qprocessp): Declare again.
4032
7990b61a
JB
40332011-04-15 Juanma Barranquero <lekktu@gmail.com>
4034
4035 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4036
5d4cb038
PE
40372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4038
8bd7b830 4039 Improve C-level modularity by making more things 'static'.
cd64ea1d 4040
e3b27b31
PE
4041 Don't publish debugger-only interfaces to other modules.
4042 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4043 (verify_bytepos, count_markers): Move decls to the only modules
4044 that need them.
4045 * region-cache.h (pp_cache): Likewise.
4046 * window.h (check_all_windows): Likewise.
4047 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4048
5d4cb038
PE
4049 * sysdep.c (croak): Now static, if
4050 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4051 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4052
4053 * alloc.c (refill_memory_reserve): Now static if
4054 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4055 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4056
e87b6180
PE
4057 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4058 Define only if USE_LUCID.
4059
ac64929e
PE
4060 * xrdb.c (x_customization_string, x_rm_string): Now static.
4061
6f37259d
PE
4062 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4063 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4064
1683e3ab
PE
4065 * xdisp.c (draw_row_with_mouse_face): Now static.
4066 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4067
de9c2632
PE
4068 * window.h (check_all_windows): Mark externally visible.
4069
2b96acb7
PE
4070 * window.c (window_deletion_count): Now static.
4071
4072 * undo.c: Make symbols static if they're not exported.
4073 (last_undo_buffer, last_boundary_position, pending_boundary):
4074 Now static.
4075
50436f33
PE
4076 * textprop.c (interval_insert_behind_hooks): Now static.
4077 (interval_insert_in_front_hooks): Likewise.
4078
64520e5c
PE
4079 * term.c: Make symbols static if they're not exported.
4080 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4081 (max_frame_lines, tty_set_terminal_modes):
4082 (tty_reset_terminal_modes, tty_turn_off_highlight):
4083 (get_tty_terminal): Now static.
4084 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4085 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4086 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4087 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4088 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4089
1fa53021
PE
4090 * sysdep.c: Make symbols static if they're not exported.
4091 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4092 Now static.
4093 (sigprocmask_set, full_mask): Remove; unused.
4094 (wait_debugging): Mark as visible.
4095 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4096 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4097
d4b43b22
PE
4098 * syntax.c (syntax_temp): Define only if !__GNUC__.
4099
b7c513d0
PE
4100 * sound.c (current_sound_device, current_sound): Now static.
4101
989b29ad
PE
4102 * search.c (searchbufs, searchbuf_head): Now static.
4103
13a55a78
PE
4104 * scroll.c (scroll_cost): Remove; unused.
4105 * dispextern.h (scroll_cost): Remove decl.
4106
de68a1fc
PE
4107 * region-cache.h (pp_cache): Mark as externally visible.
4108
40ccffa6
PE
4109 * process.c: Make symbols static if they're not exported.
4110 (process_tick, update_tick, create_process, chan_process):
4111 (Vprocess_alist, proc_buffered_char, datagram_access):
4112 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4113 (deactivate_process): Mark defn as static, as well as decl.
4114 * lisp.h (create_process): Remove decl.
4115 * process.h (chan_process, Vprocess_alist): Remove decls.
4116
ad64fc97
PE
4117 * print.c: Make symbols static if they're not exported.
4118 (print_depth, new_backquote_output, being_printed, print_buffer):
4119 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4120 (print_interval, print_number_index, initial_stderr_stream):
4121 Now static.
4122 * lisp.h (Fprinc): Remove decl.
4123 (debug_output_compilation_hack): Mark as externally visible.
4124
adddb265
PE
4125 * sysdep.c (croak): Move decl from here to syssignal.h.
4126 * syssignal.h (croak): Put it here, so the API can be checked when
4127 'croak' is called from dissociate_if_controlling_tty.
4128
1717ede2
PE
4129 * minibuf.c: Make symbols static if they're not exported.
4130 (minibuf_save_list, choose_minibuf_frame): Now static.
4131 * lisp.h (choose_minibuf_frame): Remove decl.
4132
fa5fb2bc
PE
4133 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4134
1e3890d1
PE
4135 * lread.c: Make symbols static if they're not exported.
4136 (read_objects, initial_obarray, oblookup_last_bucket_number):
4137 Now static.
4138 (make_symbol): Remove; unused.
4139 * lisp.h (initial_obarray, make_symbol): Remove decls.
4140
8a1414fa
PE
4141 * keyboard.c: Make symbols static if they're not exported.
4142 (single_kboard, recent_keys_index, total_keys, recent_keys):
4143 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4144 (this_single_command_key_start, echoing, last_auto_save):
4145 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4146 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4147 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4148 (Vlispy_mouse_stem, double_click_count):
4149 Now static.
4150 (force_auto_save_soon): Define only if SIGDANGER.
4151 (ignore_mouse_drag_p): Now static if
4152 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4153 (print_help): Remove; unused.
4154 (stop_character, last_timer_event): Mark as externally visible.
4155 * keyboard.h (ignore_mouse_drag_p): Declare only if
4156 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4157 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4158 * lisp.h (echoing): Remove decl.
4159 (force_auto_save_soon): Declare only if SIGDANGER.
4160 * xdisp.c (redisplay_window): Simplify code, to make it more
4161 obvious that ignore_mouse_drag_p is not accessed if !defined
4162 USE_GTK && !defined HAVE_NS.
4163
93ea6e8f
PE
4164 * intervals.c: Make symbols static if they're not exported.
4165 (merge_properties_sticky, merge_interval_right, delete_interval):
4166 Now static.
4167 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4168
77382fcc
PE
4169 * insdel.c: Make symbols static if they're not exported.
4170 However, leave prepare_to_modify_buffer alone. It's never
4171 called from outside this function, but that appears to be a bug.
4172 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4173 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4174 (adjust_after_replace_noundo): Remove; unused.
4175 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4176 (signal_before_change): Remove decls.
77382fcc 4177
9306c32e
PE
4178 * indent.c (val_compute_motion, val_vmotion): Now static.
4179
cd44d2eb
PE
4180 * image.c: Make symbols static if they're not exported.
4181 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4182 if USE_GTK.
4183 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4184 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4185
ad9a7a06
PE
4186 * fringe.c (standard_bitmaps): Now static.
4187 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4188
81626931
PE
4189 * frame.c: Make symbols static if they're not exported.
4190 (x_report_frame_params, make_terminal_frame): Now static.
4191 (get_frame_param): Now static, unless HAVE_NS.
4192 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4193 (x_get_resource_string): Remove; not used.
4194 * frame.h (make_terminal_frame, x_report_frame_params):
4195 (x_get_resource_string); Remove decls.
4196 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4197 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4198
239f9db9
PE
4199 * font.c, fontset.c: Make symbols static if they're not exported.
4200 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4201 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4202 * font.c (font_close_object): Now static.
4203 * font.h (font_close_object): Remove.
4204 * fontset.c (FONTSET_OBJLIST): Remove.
4205 (free_realized_fontset) #if-0 the body, which does nothing.
4206 (face_suitable_for_char_p): #if-0, as it's never called.
4207 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4208 * xfaces.c (face_at_string_position):
4209 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4210 since 0 is always ASCII.
4211
dfcf3579
PE
4212 * fns.c (weak_hash_tables): Now static.
4213
5045092b
PE
4214 * fileio.c: Make symbols static if they're not exported.
4215 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4216 (Vwrite_region_annotation_buffers): Now static.
4217
57a96f5c
PE
4218 * eval.c: Make symbols static if they're not exported.
4219 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4220 * lisp.h (backtrace_list): Remove decl.
4221
35f08c38
PE
4222 * emacs.c: Make symbols static if they're not exported.
4223 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4224 (fatal_error_code, fatal_error_signal_hook, standard_args):
4225 Now static.
4226 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4227 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4228 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4229 * lisp.h (fatal_error_signal_hook): Remove decl.
4230 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4231
f44bd759
PE
4232 * editfns.c: Move a (normally-unused) function to its only use.
4233 * editfns.c, lisp.h (get_operating_system_release): Remove.
4234 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4235 worth the hassle of breaking this out.
4236
b532497d
PE
4237 * xterm.c: Make symbols static if they're not exported.
4238 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4239 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4240 (x_destroy_window, x_delete_display):
4241 Now static.
4242 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4243 (x_mouse_leave): Remove; unused.
4244 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4245 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4246 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4247 Remove decls.
4248 (x_mouse_leave): Declare only if WINDOWSNT.
4249 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4250 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4251 USE_X_TOOLKIT.
4252
1675728f
PE
4253 * ftxfont.c: Make symbols static if they're not exported.
4254 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4255 HAVE_FREETYPE.
4256 * font.h (ftxfont_driver): Likewise.
4257
e4cebfca
PE
4258 * xfns.c: Make symbols static if they're not exported.
4259 (x_last_font_name, x_display_info_for_name):
4260 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4261 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4262 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4263 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4264 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4265 (last_show_tip_args): Now static.
4266 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4267 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4268 (x_screen_planes): Remove; unused.
4269 * dispextern.h (x_screen_planes): Remove decl.
4270
5bf46f05
PE
4271 * dispnew.c: Make symbols static if they're not exported.
4272 * dispextern.h (redraw_garbaged_frames, scrolling):
4273 (increment_row_positions): Remove.
4274 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4275 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4276 Now static.
4277 (redraw_garbaged_frames): Remove; unused.
4278
435f4c28
PE
4279 * xfaces.c: Make symbols static if they're not exported.
4280 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4281 Remove decls.
4282 * xterm.h (defined_color): Remove decls.
4283 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4284 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4285 (menu_face_changed_default, defined_color, free_realized_face):
4286 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4287 (ascii_face_of_lisp_face): Remove; unused.
4288
8524aef3
PE
4289 * xdisp.c: Make symbols static if they're not exported.
4290 * dispextern.h (scratch_glyph_row, window_box_edges):
4291 (glyph_to_pixel_coords, set_cursor_from_row):
4292 (get_next_display_element, set_iterator_to_next):
4293 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4294 (show_mouse_face): Remove decls
4295 * frame.h (message_buf_print): Likewise.
4296 * lisp.h (pop_message, set_message, check_point_in_composition):
4297 Likewise.
4298 * xterm.h (set_vertical_scroll_bar): Likewise.
4299 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4300 (message_buf_print, scratch_glyph_row, displayed_buffer):
4301 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4302 (get_next_display_element, show_mouse_face, window_box_edges):
4303 (frame_to_window_pixel_xy, check_point_in_composition):
4304 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4305 (glyph_to_pixel_coords): Remove; unused.
4306
16390cd2
PE
4307 * dired.c (file_name_completion): Now static.
4308
4309 * dbusbind.c (xd_in_read_queued_messages): Now static.
4310
a25f4dfa
PE
4311 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4312 * data.c (circular_list_error): Remove.
4313
14a9c8df
PE
4314 * commands.h (last_point_position, last_point_position_buffer):
4315 (last_point_position_window): Remove decls.
4316 * keyboard.c: Make these variables static.
4317
04f2d78b
CB
4318 * coding.h (coding, code_convert_region, encode_coding_gap):
4319 Remove decls.
74ab6df5
PE
4320 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4321 (iso_code_class, detect_coding, code_convert_region): Now static.
4322 (encode_coding_gap): Remove; unused.
4323
38dfbee1
PE
4324 * chartab.c (chartab_chars, chartab_bits): Now static.
4325
a2cb4e63
PE
4326 * charset.h (charset_iso_8859_1): Remove decl.
4327 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4328 Now static.
4329
127198fd
PE
4330 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4331 * ccl.c (Vccl_program_table): Now static.
4332 (check_ccl_update): Remove; unused.
4333
d85b608f
PE
4334 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4335 * category.h: ... from here.
4336 * category.c (check_category_table, set_category_set): Now static.
4337
31cd66f3
PE
4338 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4339 * lisp.h: Remove these decls.
4340
c358e587
PE
4341 * buffer.c (buffer_count): Remove unused var.
4342
e78aecca
PE
4343 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4344 so that it's not optimized away.
4345 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4346 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4347 exported only to the debugger.
4348
e192d7d3 4349 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4350 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4351
92470028
PE
4352 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4353 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4354 was inaccessible from Lisp.
4355 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4356 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4357
244ed907
PE
4358 alloc.c: Import and export fewer symbols, and remove unused items.
4359 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4360 is defined.
4361 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4362 it's not optimized away by whole-program optimization.
4363 (message_enable_multibyte, free_misc): Remove.
4364 (catchlist, handlerlist, mark_backtrace):
4365 Declare only if BYTE_MARK_STACK.
4366 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4367 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4368 (message_enable_multibyte): Remove decl.
4369 (free_misc, interval_free_list, float_block, float_block_index):
4370 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4371 (cons_free_list, last_marked_index):
4372 Now static.
4373 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4374 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4375 (mark_backtrace): Define only if BYTE_MARK_STACK.
4376 * xdisp.c (message_enable_multibyte): Now static.
4377
61c2b50e 4378 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4379 This makes it easier for human readers (and static analyzers)
4380 to see whether these variables are used from other modules.
4381 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4382 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4383 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4384 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4385 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4386 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4387 * xmenu.c, xselect.c:
4388 Declare Q* vars static if they are not used in other modules.
4389 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4390 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4391 Remove decls of unexported vars.
4392 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4393
95c82688
PE
4394 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4395
16a97296
PE
4396 Make Emacs functions such as Fatom 'static' by default.
4397 This makes it easier for human readers (and static analyzers)
4398 to see whether these functions can be called from other modules.
4399 DEFUN now defines a static function. To make the function external
4400 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4401 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4402 (Finit_image_library):
16a97296
PE
4403 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4404 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4405 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4406 Remove decls, since these functions are now static.
4407 (Funintern, Fget_internal_run_time): New decls, since these functions
4408 were already external.
95c82688 4409
16a97296
PE
4410 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4411 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4412 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4413 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4414 * keyboard.c, keymap.c, lread.c:
4415 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4416 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4417 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4418 Mark functions with DEFUE instead of DEFUN,
4419 if they are used in other modules.
4420 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4421 decls for now-static functions.
4422 * buffer.h (Fdelete_overlay): Remove decl.
4423 * callproc.c (Fgetenv_internal): Mark as internal.
4424 * composite.c (Fremove_list_of_text_properties): Remove decl.
4425 (Fcomposition_get_gstring): New forward static decl.
4426 * composite.h (Fcomposite_get_gstring): Remove decl.
4427 * dired.c (Ffile_attributes): New forward static decl.
4428 * doc.c (Fdocumntation_property): New forward static decl.
4429 * eval.c (Ffetch_bytecode): New forward static decl.
4430 (Funintern): Remove extern decl; now in .h file where it belongs.
4431 * fileio.c (Fmake_symbolic_link): New forward static decl.
4432 * image.c (Finit_image_library): New forward static decl.
4433 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4434 * intervals.h (Fprevious_property_change):
4435 (Fremove_list_of_text_properties): Remove decls.
4436 * keyboard.c (Fthis_command_keys): Remove decl.
4437 (Fcommand_execute): New forward static decl.
4438 * keymap.c (Flookup_key): New forward static decl.
4439 (Fcopy_keymap): Now static.
4440 * keymap.h (Flookup_key): Remove decl.
4441 * process.c (Fget_process): New forward static decl.
4442 (Fprocess_datagram_address): Mark as internal.
4443 * syntax.c (Fsyntax_table_p): New forward static decl.
4444 (skip_chars): Remove duplicate decl.
4445 * textprop.c (Fprevious_property_change): New forward static decl.
4446 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4447 Now internal.
4448 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4449 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4450
785bbd42
PE
4451 * editfns.c (Fformat): Remove unreachable code.
4452
8b913b57
AS
44532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4454
4455 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4456 change. (Bug#8496)
4457
a6744a35
EZ
44582011-04-13 Eli Zaretskii <eliz@gnu.org>
4459
4460 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4461 when at ZV. (Bug#8487)
4462
e7974947
AS
44632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4464
baad03f0
AS
4465 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4466 (Bug#8437)
4467 * keyboard.c (parse_tool_bar_item): Likewise.
4468 * sound.c (sound_cleanup, alsa_close): Likewise.
4469 * termcap.c (tgetent): Likewise.
4470 * xfns.c (x_default_font_parameter): Likewise.
4471 * xsettings.c (read_and_apply_settings): Likewise.
4472
e7974947
AS
4473 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4474 (overrun_check_free): Protoize.
4475
28272684
PE
44762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4479 since callers should never pass a negative size.
4480 Change the signature to match that of plain 'read' and 'write'; see
4481 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4482 * lisp.h: Update prototypes of emacs_write and emacs_read.
4483
11997c76
EZ
44842011-04-11 Eli Zaretskii <eliz@gnu.org>
4485
4486 * xdisp.c (redisplay_window): Don't try to determine the character
4487 position of the scroll margin if the window start point w->startp
e896f03c 4488 is outside the buffer's accessible region. (Bug#8468)
11997c76 4489
8a2cbd72
EZ
44902011-04-10 Eli Zaretskii <eliz@gnu.org>
4491
4492 Fix write-region and its subroutines for buffers > 2GB.
4493 * fileio.c (a_write, e_write): Modify declaration of arguments and
4494 local variables to support buffers larger than 2GB.
4495 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4496
4497 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4498 argument, local variables, and return value.
4499
4500 * lisp.h: Update prototypes of emacs_write and emacs_read.
4501
4502 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4503
4073e537 45042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4505
1ebfdcb6
PE
4506 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4507
b2ded58d
PE
4508 Fix more problems found by GCC 4.6.0's static checks.
4509
7d66342c
PE
4510 * xdisp.c (vmessage): Use a better test for character truncation.
4511
bbf47d44
PE
4512 * charset.c (load_charset_map): <, not <=, for optimization,
4513 and to avoid potential problems with integer overflow.
9248994d 4514 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4515 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4516 * editfns.c (Fformat): Likewise.
1e69125e 4517 * syntax.c (skip_chars): Likewise.
3befa583 4518
e3019616
PE
4519 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4520 This also lets GCC 4.6.0 generate slightly better loop code.
4521
becfa255
PE
4522 * callint.c (Fcall_interactively): <, not <=, for optimization.
4523 (Fcall_interactively): Count the number of arguments produced,
4524 not the number of arguments given. This is simpler and lets GCC
4525 4.6.0 generate slightly better code.
4526
dae0cd48
PE
4527 * ftfont.c: Distingish more carefully between FcChar8 and char.
4528 The previous code passed unsigned char * to a functions like
4529 strlen and xstrcasecmp that expect char *, which does not
4530 conform to the C standard.
4531 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4532 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4533 char * when the C standard requires it.
4534
76032d70
PE
4535 * keyboard.c (read_char): Remove unused var.
4536
eb3f1cc8
PE
4537 * eval.c: Port to Windows vsnprintf (Bug#8435).
4538 Include <limits.h>.
4539 (SIZE_MAX): Define if the headers do not.
4540 (verror): Do not give up if vsnprintf returns a negative count.
4541 Instead, grow the buffer. This ports to Windows vsnprintf, which
4542 does not conform to C99. Problem reported by Eli Zaretskii.
4543 Also, simplify the allocation scheme, by avoiding the need for
4544 calling realloc, and removing the ALLOCATED variable.
4545
70476b54
PE
4546 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4547
12020a9e
PE
4548 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4549 But keep the doprint source code for now, as we might revamp it
4550 and use it again (Bug#8435).
ea6c7ae6
PE
4551 * lisp.h (doprnt): Remove.
4552 * Makefile.in (base_obj): Remove doprnt.o.
4553 * deps.mk (doprnt.o): Remove.
4554
5fdb398c
PE
4555 error: Print 32- and 64-bit integers portably (Bug#8435).
4556 Without this change, on typical 64-bit hosts error ("...%d...", N)
4557 was used to print both 32- and 64-bit integers N, which relied on
4558 undefined behavior.
4559 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4560 New macro.
4561 * lisp.h (error, verror): Mark as printf-like functions.
4562 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4563 Report overflow in size calculations when allocating printf buffer.
4564 Do not truncate output string at its first null byte.
4565 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4566 Truncate the output at a character boundary, since vsnprintf does not
4567 do that.
4568 * charset.c (check_iso_charset_parameter): Convert internal
4569 character to string before calling 'error', since %c now has the
4570 printf meaning.
4571 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4572 overflow when computing char to be passed to 'error'. Do not
4573 pass Lisp_Object to 'error'; pass the integer instead.
4574 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4575 formatted with plain %d.
4576
b189fa66
PE
4577 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4578
bff87ef0
PE
4579 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4580
7e2cac20
PE
4581 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4582
ce4d90b5
PE
4583 * xterm.c (x_catch_errors): Remove duplicate declaration.
4584
266c9547
PE
4585 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4586
79c49ad2
PE
4587 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4588
368f4090
JM
45892011-04-10 Jim Meyering <meyering@redhat.com>
4590
4591 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4592 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4593 return ssize_t not "int", and use size_t as the buffer length.
4594 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4595 * gnutls.h: Update declarations.
4596 * process.c (read_process_output): Use ssize_t, to match.
4597 (send_process): Likewise.
4598
a32d4040
CY
45992011-04-09 Chong Yidong <cyd@stupidchicken.com>
4600
4601 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4602
8546720e 46032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4604
04f2d78b
CB
4605 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4606 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4607
8546720e
GM
4608 * xterm.c (handle_one_xevent):
4609 * xmenu.c (create_and_show_popup_menu):
4610 * xselect.c (x_decline_selection_request)
4611 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4612
0a2f5c1a 46132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4614
4615 Fix some uses of `int' instead of EMACS_INT.
4616 * search.c (string_match_1, fast_string_match)
4617 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4618 (scan_buffer, find_next_newline_no_quit)
4619 (find_before_next_newline, search_command, Freplace_match)
4620 (Fmatch_data): Make some `int' variables be EMACS_INT.
4621
4622 * xdisp.c (display_count_lines): 3rd argument and return value now
4623 EMACS_INT. All callers changed.
4624 (pint2hrstr): Last argument is now EMACS_INT.
4625
4626 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4627 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4628 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4629 (decode_coding_utf_16, decode_coding_emacs_mule)
4630 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4631 (decode_coding_ccl, decode_coding_charset)
4632 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4633 (decode_coding_iso_2022, decode_coding_emacs_mule)
4634 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4635 <char_offset, last_offset>: Declare EMACS_INT.
4636 (encode_coding_utf_8, encode_coding_utf_16)
4637 (encode_coding_emacs_mule, encode_invocation_designation)
4638 (encode_designation_at_bol, encode_coding_iso_2022)
4639 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4640 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4641 Declare EMACS_INT.
4642 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4643 (encode_invocation_designation): Last argument P_NCHARS is now
4644 EMACS_INT.
4645 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4646 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4647
4648 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4649 All users changed.
4650
4651 * ccl.c (Fccl_execute_on_string): Declare some variables
4652 EMACS_INT.
4653
8546720e 46542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4655
4656 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4657
4e19a977
CS
46582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4659
4660 * process.c (Fformat_network_address): Doc fix.
4661
87302331
R
46622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4663
4664 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4665
cbb59342
CY
46662011-04-08 Chong Yidong <cyd@stupidchicken.com>
4667
4668 * keyboard.c (read_char): Call Lisp function help-form-show,
4669 instead of using internal_with_output_to_temp_buffer.
4670 (Qhelp_form_show): New var.
e0d38eeb 4671 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4672
4673 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4674
4675 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4676
e67a13ab
CY
46772011-04-06 Chong Yidong <cyd@stupidchicken.com>
4678
04f2d78b
CB
4679 * process.c (Flist_processes): Remove to Lisp.
4680 (list_processes_1): Delete.
e67a13ab 4681
973f782d
EZ
46822011-04-06 Eli Zaretskii <eliz@gnu.org>
4683
7c106b1e
EZ
4684 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4685
973f782d
EZ
4686 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4687
41cf7d1a 46882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4689
ca23cc88
PE
4690 Fix more problems found by GCC 4.6.0's static checks.
4691
f390e2d5
PE
4692 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4693
42eea0d0
PE
4694 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4695
b69769da 4696 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4697
f9541e84
PE
4698 * xdisp.c (vmessage): Mark as a printf-like function.
4699
13841b55
PE
4700 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4701
c136c10f
PE
4702 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4703
5e2d4a30
PE
4704 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4705 printf-like functions.
4706 (tiff_load): Add casts to remove these marks before passing them
4707 to system-supplied API.
4708
583f48b9
PE
4709 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4710
b25d760e
PE
4711 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4712 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4713 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4714 directly, rather than having caller test rule sign. This avoids
4715 some unnecessary tests.
4716 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4717 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4718 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4719
bc7b6697 4720 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4721 (xfont_open): Avoid unnecessary tests.
bc7b6697 4722
27ccc379
PE
4723 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4724
dcd5c89a
PE
4725 * composite.h, composite.c (composition_gstring_put_cache):
4726 Use EMACS_INT, not int, for length.
4727
b13a45c6
PE
4728 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4729 breaking out part of COMPOSITION_DECODE_RULE.
4730 (COMPOSITION_DECODE_RULE): Use it.
4731 * composite.c (get_composition_id): Remove unused local vars,
4732 by using the new macro.
4733
1e792e4d
PE
4734 * textprop.c (set_text_properties_1): Change while to do-while,
4735 since the condition is always true at first.
4736
dc6c6455 4737 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4738 (interval_deletion_adjustment): Return unsigned value.
4739 All uses changed.
dc6c6455 4740
aba7731a
PE
4741 * process.c (list_processes_1, create_pty, read_process_output):
4742 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4743 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4744 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4745 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4746 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4747
fdfc4bf3
PE
4748 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4749
fca8fe46 4750 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4751 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4752
06a0259a 4753 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4754 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4755 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4756
e7b9e80f
PE
4757 * print.c (print_error_message): Avoid int overflow.
4758
56201685
PE
4759 * font.c (font_list_entities): Redo for clarity,
4760 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4761
78834453 4762 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4763 (font_score): Avoid potential overflow in diff calculation.
78834453 4764
0bc0b309 4765 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4766 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4767
e610eaca
PE
4768 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4769
b895abce
PE
4770 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4771 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4772 can always succeed if overflow has undefined behavior.
4773
1f1d9321 4774 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4775 (wordify): Omit three unnecessary tests.
1f1d9321 4776
c59478bc
PE
4777 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4778 All callers changed. This avoids the need for an unused var.
4779
79b73827
PE
4780 * casefiddle.c (casify_region): Remove var that is set but not used.
4781
a4db5dfe
PE
4782 * dired.c (file_name_completion): Remove var that is set but not used.
4783
43aae36e
PE
4784 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4785
2a47c44d 4786 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4787 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4788
a37c69bf
PE
4789 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4790 Check for integer overflow on size calculations.
4791
328ab8e7
PE
4792 * buffer.c (Fprevious_overlay_change): Remove var that is set
4793 but not used.
4794
e5a2a5cb
PE
4795 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4796 Remove vars that are set but not used.
8d84a6eb 4797 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4798 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4799
a60e5f68
PE
4800 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4801
f661cb61 4802 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4803 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4804
f0397f5a
PE
4805 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4806 that are set but not used.
4807
8664db06 4808 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4809 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4810
6abdaa4a
PE
4811 * xselect.c (x_get_local_selection, x_handle_property_notify):
4812 Remove vars that are set but not used.
4813
0ce7538d 4814 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4815 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4816
9ae848fc
PE
4817 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4818 Remove var that is set but not used.
0b918413
PE
4819 (scroll_bar_windows_size): Now size_t, not int.
4820 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4821 Check for overflow.
9ae848fc 4822
a5a62657
PE
4823 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4824 (map_tty_color) [!defined MSDOS]: Likewise.
4825
5c5cdd39
PE
4826 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4827
66ebf983
PE
4828 * coding.c: Remove vars that are set but not used.
4829 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4830 All callers changed.
4831 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4832 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4833 (decode_coding_charset): Remove vars that are set but not used.
4834
1be4d761
PE
4835 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4836 that is set but not used.
4837
47553fa8
PE
4838 * print.c (print_object): Remove var that is set but not used.
4839
1f7196bf 4840 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4841 The gnulib version avoids calling malloc in the usual case,
4842 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4843 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4844 * filelock.c (current_lock_owner): Likewise.
4845 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4846 * sysdep.c: Include allocator.h, careadlinkat.h.
4847 (emacs_no_realloc_allocator): New static constant.
4848 (emacs_readlink): New function.
fdb61804
PE
4849 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4850 ../lib/careadlinkat.h.
d1fdcab7 4851
f84c17c7
SM
48522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4853
4854 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4855 first non-nil return value).
4856
ef3862ad
JD
48572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4858
4859 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4860 if not defined (Bug#8403).
4861
376a7006
JB
48622011-04-02 Juanma Barranquero <lekktu@gmail.com>
4863
4864 * xdisp.c (display_count_lines): Remove parameter `start',
4865 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4866 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4867 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4868 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4869 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4870 and thereabouts. All callers changed.
4871 (get_per_char_metric): Remove parameter `f', unused since
4872 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4873
6ca3801d
JM
48742011-04-02 Jim Meyering <meyering@redhat.com>
4875
4876 do not dereference NULL upon failed strdup
4877 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4878 (ns_get_family): Likewise.
4879
d8e2b5ba
JB
48802011-04-02 Juanma Barranquero <lekktu@gmail.com>
4881
4882 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4883
8c74fcbd
JD
48842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4885
4886 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4887 later (Bug#8403).
4888
7200d79c
SM
48892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4890
03408648 4891 Add lexical binding.
7200d79c 4892
03408648
SM
4893 * window.c (Ftemp_output_buffer_show): New fun.
4894 (Fsave_window_excursion):
4895 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4896
4897 * lread.c (lisp_file_lexically_bound_p): New function.
4898 (Fload): Bind Qlexical_binding.
4899 (readevalloop): Remove `evalfun' arg.
4900 Bind Qinternal_interpreter_environment.
4901 (Feval_buffer): Bind Qlexical_binding.
4902 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4903 Mark as dynamic.
4904 (syms_of_lread): Declare `lexical-binding'.
4905
4906 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4907
4908 * keyboard.c (eval_dyn): New fun.
4909 (menu_item_eval_property): Use it.
ca105506
SM
4910
4911 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4912
03408648
SM
4913 * fns.c (concat, mapcar1): Accept byte-code-functions.
4914
4915 * eval.c (Fsetq): Handle lexical vars.
4916 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4917 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4918 (FletX, Flet): Obey lexical binding.
4919 (Fcommandp): Handle closures.
4920 (Feval): New `lexical' arg.
4921 (eval_sub): New function extracted from Feval. Use it almost
4922 everywhere where Feval was used. Look up vars in lexical env.
4923 Handle closures.
4924 (Ffunctionp): Move from subr.el.
4925 (Ffuncall): Handle closures.
4926 (apply_lambda): Remove `eval_flags'.
4927 (funcall_lambda): Handle closures and new byte-code-functions.
4928 (Fspecial_variable_p): New function.
4929 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4930 but without exporting it to Lisp.
23aba0ea 4931
23aba0ea 4932 * doc.c (Fdocumentation, store_function_docstring):
03408648 4933 * data.c (Finteractive_form): Handle closures.
23aba0ea 4934
03408648
SM
4935 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4936 interactive spec.
ba83908c 4937
04f2d78b
CB
4938 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4939 New byte-codes.
03408648
SM
4940 (exec_byte_code): New function extracted from Fbyte_code to handle new
4941 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4942
03408648 4943 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4944
03408648 4945 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4946
e2abce01
JB
49472011-03-31 Juanma Barranquero <lekktu@gmail.com>
4948
4949 * xdisp.c (redisplay_internal): Fix prototype.
4950
63696a73 49512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4952
63696a73 4953 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4954 (try_scrolling): Use it when setting scroll_limit.
4955 Limit scrolling to 100 screen lines.
63696a73
EZ
4956 (redisplay_window): Even when falling back on "recentering",
4957 position point in the window according to scroll-conservatively,
4958 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4959
4960 (try_scrolling): When point is above the window, allow searching
4961 as far as scroll_max, or one screenful, to compute vertical
4962 distance from PT to the scroll margin position. This prevents
4963 try_scrolling from unnecessarily failing when
4964 scroll-conservatively is set to a value slightly larger than the
4965 window height. Clean up the case of PT below the margin at bottom
4966 of window: scroll_max can no longer be INT_MAX. When aggressive
4967 scrolling is in use, don't let point enter the opposite scroll
4968 margin as result of the scroll.
4969 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4970 threshold of 100 lines for never-recentering scrolling.
4971
e4cc2dfc
JB
49722011-03-31 Juanma Barranquero <lekktu@gmail.com>
4973
4974 * dispextern.h (move_it_by_lines):
4975 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4976 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4977 (message_log_check_duplicate): Remove parameters `prev_bol' and
4978 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4979 (redisplay_internal): Remove parameter `preserve_echo_area',
4980 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4981
4982 * indent.c (Fvertical_motion):
4983 * window.c (window_scroll_pixel_based, Frecenter):
4984 Don't pass `need_y_p' to `move_it_by_lines'.
4985
1c470562
SM
49862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4987
44f230aa
SM
4988 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4989 steal a few bits to be more compact.
4990 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4991 Remove unneeded casts.
4992
1c470562
SM
4993 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4994
888adce9
ZK
49952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4996
4997 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4998 binding" message (bug#7967).
4999
f838ed7b
PE
50002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5001
77861b95
PE
5002 Fix more problems found by GCC 4.6.0's static checks.
5003
de6dbc14
PE
5004 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5005 Remove unused local var.
5006
f838ed7b
PE
5007 * editfns.c (Fmessage_box): Remove unused local var.
5008
792c7b2b
PE
5009 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5010 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5011 Omit unused local vars.
c499e557 5012 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5013 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5014 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5015 Omit unused local var.
5016
ba0165e1
PE
5017 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5018 Don't assume string length fits in int.
32ad8845 5019 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5020 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5021
3c59b4c9
PE
5022 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5023 instead of alloca (Bug#8344).
5024
a3eed478 5025 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5026 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5027
eb4d412d
PE
5028 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5029
1658b401
PE
5030 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5031 concerns.
5032
5033 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5034
5035 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5036
9a2c6e05
PE
5037 * keyboard.c (syms_of_keyboard): Use the same style as later
5038 in this function when indexing through an array. This also
5039 works around GCC bug 48267.
5040
03d0a109
PE
5041 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5042
44f730c8
PE
5043 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5044
fe75f926
PE
5045 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5046 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5047
ffa8c828
PE
5048 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5049 This avoids undefined behavior on integer overflow, and is a bit
5050 more convenient anyway since it is compared to a size_t variable.
5051
c5101a77
PE
5052 Variadic C functions now count arguments with size_t, not int.
5053 This avoids an unnecessary limitation on 64-bit machines, which
5054 caused (substring ...) to crash on large vectors (Bug#8344).
5055 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5056 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5057 All variadic functions and their callers changed accordingly.
c5101a77
PE
5058 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5059 * data.c (arith_driver, float_arith_driver): Likewise.
5060 * editfns.c (general_insert_function): Likewise.
5061 * eval.c (struct backtrace.nargs, interactive_p)
5062 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5063 (funcall_lambda, mark_backtrace): Likewise.
5064 * fns.c (concat): Likewise.
5065 * frame.c (x_set_frame_parameters): Likewise.
5066 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5067 0 if not found, not -1. All callers changed.
5068
dd3f25f7
PE
5069 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5070 (stack_copy_size): Now size_t, not int.
5071 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5072
461c2ab9
JB
50732011-03-28 Juanma Barranquero <lekktu@gmail.com>
5074
5075 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5076 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5077 All callers changed.
5078
5079 * lisp.h (multibyte_char_to_unibyte):
5080 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5081 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5082 * character.h (CHAR_TO_BYTE8):
5083 * cmds.c (internal_self_insert):
5084 * editfns.c (general_insert_function):
5085 * keymap.c (push_key_description):
5086 * search.c (Freplace_match):
5087 * xdisp.c (message_dolog, set_message_1): All callers changed.
5088
f6d62986
SM
50892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5090
5091 * keyboard.c (safe_run_hook_funcall): New function.
5092 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5093 don't set the hook to nil, but remove the offending function instead.
5094 (Qcommand_hook_internal): Remove, unused.
5095 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5096 Vcommand_hook_internal.
5097
5098 * eval.c (enum run_hooks_condition): Remove.
5099 (funcall_nil, funcall_not): New functions.
5100 (run_hook_with_args): Call each function through a `funcall' argument.
5101 Remove `cond' argument, now redundant.
5102 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5103 (Frun_hook_with_args_until_failure): Adjust accordingly.
5104 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5105
1db5b1ad
JB
51062011-03-28 Juanma Barranquero <lekktu@gmail.com>
5107
5108 * dispextern.h (string_buffer_position): Remove declaration.
5109
5110 * print.c (strout): Remove parameter `multibyte', unused since
5111 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5112
5113 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5114 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5115 All callers changed.
5116
5117 * w32.c (_wsa_errlist): Use braces for struct initializers.
5118
5119 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5120 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5121 All callers changed.
5122 (string_buffer_position): Likewise. Also, make static (it's never
5123 used outside xdisp.c).
5124 (cursor_row_p): Remove parameter `w', unused since
5125 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5126 (decode_mode_spec): Remove parameter `precision', introduced during
5127 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5128 All callers changed.
5129
5ffb62aa
JD
51302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5131
5132 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5133
461c2ab9 51342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5135
5136 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5137 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5138 (ns_update_auto_hide_menu_bar): New functions.
5139 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5140 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5141 ns_constrain_all_frames.
5142 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5143 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5144
5c380ffb
JD
51452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5146
5147 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5148
9af30bdf
GM
51492011-03-27 Glenn Morris <rgm@gnu.org>
5150
5151 * syssignal.h: Replace RETSIGTYPE with void.
5152 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5153 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5154 Replace SIGTYPE with void everywhere.
5155 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5156 * s/template.h (SIGTYPE): Remove commented out definition.
5157
e2abce01
JB
51582011-03-26 Eli Zaretskii <eliz@gnu.org>
5159
5160 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5161 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5162
f868cd8a
JB
51632011-03-26 Juanma Barranquero <lekktu@gmail.com>
5164
59eb0929
JB
5165 * w32.c (read_unc_volume): Use parameter `henum', instead of
5166 global variable `wget_enum_handle'.
5167
5168 * keymap.c (describe_vector): Remove parameters `indices' and
5169 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5170 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5171
f868cd8a
JB
5172 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5173
5174 * keyboard.c (timer_check): Remove parameter `do_it_now',
5175 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5176 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5177 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5178
5179 * keyboard.c (read_char):
5180 * w32menu.c (w32_menu_display_help):
5181 * xmenu.c (show_help_event, menu_help_callback):
5182 Adjust calls to `show_help_echo'.
5183
5184 * gtkutil.c (xg_maybe_add_timer):
5185 * keyboard.c (readable_events):
5186 * process.c (wait_reading_process_output):
5187 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5188
5189 * insdel.c (adjust_markers_gap_motion):
5190 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5191 (gap_left, gap_right): Don't call it.
5192
2ecf6fdb
CY
51932011-03-25 Chong Yidong <cyd@stupidchicken.com>
5194
5195 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5196 incurred during fontification.
5197
6b1f9ba4
JB
51982011-03-25 Juanma Barranquero <lekktu@gmail.com>
5199
5200 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5201 (DEFVAR_PER_BUFFER): Don't pass it.
5202
5203 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5204 (scrolling_window): Don't pass it.
5205
0f4a96b5
JB
52062011-03-25 Juanma Barranquero <lekktu@gmail.com>
5207
5208 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5209
5210 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5211 and `suffix'.
5212 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5213 of variables specific to SELinux and computation of `encoded_absname'.
5214
5215 * image.c (XPutPixel): Remove unused variable `height'.
5216
5217 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5218
5219 * unexw32.c (get_section_info): Remove unused variable `section'.
5220
5221 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5222 (system_process_attributes): Remove unused variable `sess'.
5223 (sys_read): Remove unused variable `err'.
5224
5225 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5226 (w32_wnd_proc): Remove unused variable `isdead'.
5227 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5228 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5229 (x_create_tip_frame): Remove unused variable `tem'.
5230
5231 * w32inevt.c (w32_console_read_socket):
5232 Remove unused variable `no_events'.
5233
5234 * w32term.c (x_draw_composite_glyph_string_foreground):
5235 Remove unused variable `width'.
5236
1149507c
JB
52372011-03-24 Juanma Barranquero <lekktu@gmail.com>
5238
5239 * w32term.c (x_set_glyph_string_clipping):
5240 Don't pass uninitialized region to CombineRgn.
5241
9c88f339
JB
52422011-03-23 Juanma Barranquero <lekktu@gmail.com>
5243
5244 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5245 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5246 (Fx_close_connection): Remove unused variable `i'.
5247
5248 * w32font.c (w32font_draw): Return number of glyphs.
5249 (w32font_open_internal): Remove unused variable `i'.
5250 (w32font_driver): Add missing initializer.
5251
5252 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5253 (fill_in_menu): Remove unused variable `items_added'.
5254
5255 * w32term.c (last_mouse_press_frame): Remove static global variable.
5256 (w32_clip_to_row): Remove unused variable `f'.
5257 (x_delete_terminal): Remove unused variable `i'.
5258
5259 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5260 (NOTHING): Remove unused static global variable.
5261 (uniscribe_check_otf): Remove unused variable `table'.
5262 (uniscribe_font_driver): Add missing initializers.
5263
dee091a3
JD
52642011-03-23 Julien Danjou <julien@danjou.info>
5265
5266 * term.c (Fsuspend_tty, Fresume_tty):
5267 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5268 * window.c (temp_output_buffer_show):
5269 * insdel.c (signal_before_change):
5270 * frame.c (Fhandle_switch_frame):
5271 * fileio.c (Fdo_auto_save):
5272 * emacs.c (Fkill_emacs):
5273 * editfns.c (save_excursion_restore):
5274 * cmds.c (internal_self_insert):
5275 * callint.c (Fcall_interactively):
5276 * buffer.c (Fkill_all_local_variables):
5277 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5278 Use Frun_hooks.
0f4a96b5 5279 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5280 unconditionnaly since it does the check itself.
5281
2c520ab5 52822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5283
c9c49752
PE
5284 Fix more problems found by GCC 4.5.2's static checks.
5285
8abc3f12
PE
5286 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5287 the first time through the loop, since we know p0 < p1 then.
5288 This also avoids a gcc -Wstrict-overflow warning.
5289
a2d26660
PE
5290 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5291 leading to a memory leak, possible in functions like
5292 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5293 of objects (Bug#8318).
a2d26660 5294
916c72e9
PE
5295 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5296 that could (at least in theory) be that large.
5297
19ab8a18
PE
5298 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5299 This is less likely to overflow, and avoids undefined behavior if
5300 overflow does occur. All callers changed. Use strtoul to scan
5301 for the unsigned long integer.
b7cbbd6f
PE
5302 (pint2hrstr): Simplify and tune code slightly.
5303 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5304
f0641eff
PE
5305 * scroll.c (do_scrolling): Work around GCC bug 48228.
5306 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5307
7f650bb9
PE
5308 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5309 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5310 (validate_x_resource_name): Simplify count usage.
5311 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5312
37dd57d1
PE
5313 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5314 fail (Bug#8306).
81e56e61 5315
699979fc 5316 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5317
401bf9b4
PE
5318 * process.c (Fmake_network_process): Use socklen_t, not int,
5319 where POSIX says socklen_t is required in portable programs.
5320 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5321 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5322 (Fmake_network_process, server_accept_connection):
5323 (wait_reading_process_output, read_process_output):
5324 Likewise.
5325
b93aacde
PE
5326 * process.c: Rename or move locals to avoid shadowing.
5327 (list_processes_1, Fmake_network_process):
5328 (read_process_output_error_handler, exec_sentinel_error_handler):
5329 Rename or move locals.
4dc343ee 5330 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5331 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5332 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5333 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5334 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5335
af8a867c 5336 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5337 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5338 Include tparam.h instead, since it declares them.
af8a867c
PE
5339 * cm.h (PC): Remove extern decl; tparam.h now does this.
5340 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5341 * terminfo.c: Include tparam.h, to check interfaces.
5342 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5343 (tparam): Adjust signature to match interface in tparam.h;
5344 this removes some undefined behavior. Check that outstring and len
5345 are zero, which they always are with Emacs.
5346 * tparam.h (PC, BC, UP): New extern decls.
5347
0248044d 5348 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5349 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5350
8ff096c1 5351 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5352 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5353 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5354 (ftfont_list): Remove unused local.
49eaafba
PE
5355 (get_adstyle_property, ftfont_pattern_entity):
5356 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5357 Rename locals to avoid shadowing.
8ff096c1 5358
e2be39f6
PE
5359 * xfont.c (xfont_list_family): Mark var as initialized.
5360
c9735e30
PE
5361 * xml.c (make_dom): Now static.
5362
8f5201ae
PE
5363 * composite.c (composition_compute_stop_pos): Rename local to
5364 avoid shadowing.
b246f932
PE
5365 (composition_reseat_it): Remove unused locals.
5366 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5367 (composition_update_it): Mark var as initialized.
11b61122
PE
5368 (find_automatic_composition): Mark vars as initialized,
5369 with a FIXME (Bug#8290).
8f5201ae 5370
760fbc2c
PE
5371 character.h: Rename locals to avoid shadowing.
5372 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5373 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5374 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5375 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5376 to avoid shadowing.
5377
ff08eb85
PE
5378 * textprop.c (property_change_between_p): Remove; unused.
5379
fc7bf025
PE
5380 * intervals.c (interval_start_pos): Now static.
5381
235d7abc
PE
5382 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5383
44f230aa
SM
5384 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5385 Rename locals to avoid shadowing.
3e7d6594 5386
50060332
PE
5387 * sound.c (wav_play, au_play, Fplay_sound_internal):
5388 Fix pointer signedness.
d01f234b 5389 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5390 (wav_play): Initialize a variable to 0, to prevent undefined
5391 behavior (Bug#8278).
50060332 5392
c4fc4e30
PE
5393 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5394
918436ed
PE
5395 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5396
c939f91b
PE
5397 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5398 clobbering (Bug#8298).
b9c7f648
PE
5399 * sysdep.c (sys_subshell): Likewise.
5400 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5401
6bd8c144
PE
5402 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5403 This should get cleaned up, so that child_setup has the
5404 same signature on all platforms.
5405
7710357c 5406 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5407 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5408
c59da222
CY
54092011-03-22 Chong Yidong <cyd@stupidchicken.com>
5410
5411 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5412 not to be necessary, and produces flickering.
5413
66b87493
GM
54142011-03-20 Glenn Morris <rgm@gnu.org>
5415
5416 * config.in: Remove file.
5417
45b6f6d5
JB
54182011-03-20 Juanma Barranquero <lekktu@gmail.com>
5419
5420 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5421 are now in src/globals.h.
5422 (syms_of_minibuf): Remove spurious & from previous change.
5423
3ec03f7e
LL
54242011-03-20 Leo <sdl.web@gmail.com>
5425
5426 * minibuf.c (completing-read-function): New variable.
5427 (completing-read-default): Rename from completing-read.
5428 (completing-read): Call completing-read-function.
5429
b14e3e21
CY
54302011-03-19 Juanma Barranquero <lekktu@gmail.com>
5431
5432 * xfaces.c (Fx_load_color_file):
5433 Read color file from absolute filename (bug#8250).
5434
f2b726e6
JB
54352011-03-19 Juanma Barranquero <lekktu@gmail.com>
5436
5437 * makefile.w32-in: Update dependencies.
5438
09f6ff02
EZ
54392011-03-17 Eli Zaretskii <eliz@gnu.org>
5440
5441 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5442
29a6015a
PE
54432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5444
a3a6c54e
PE
5445 Fix more problems found by GCC 4.5.2's static checks.
5446
b766f867
PE
5447 * process.c (make_serial_process_unwind, send_process_trap):
5448 (sigchld_handler): Now static.
5449
be02381c
PE
5450 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5451 That way, the code declares only the vars that it needs.
5452 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5453 * s/cygwin.h (PTY_ITERATION): Likewise.
5454 * s/darwin.h (PTY_ITERATION): Likewise.
5455 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5456
57048744
PE
5457 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5458 * process.c (allocate_pty): Don't declare stb unless it's needed.
5459
7914961c 5460 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5461 (CONSTANTLIM): Remove; unused.
5462 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5463 Define only if needed.
7914961c 5464
b3967b18
PE
5465 * unexelf.c (unexec): Name an expression,
5466 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5467 Use a different way to cause a compilation error if anyone uses
5468 n rather than nn, a way that does not involve shadowing.
73366a00 5469 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5470
29a6015a
PE
5471 * deps.mk (unexalpha.o): Remove; unused.
5472
43cfc33e 5473 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5474 * unexec.h: New file.
ce701a33
PE
5475 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5476 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5477 Depend on unexec.h.
5478 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5479 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5480 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5481 Change as necessary to match prototype in unexec.h.
ce701a33 5482
01f44d5a
PE
5483 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5484 shadowing.
4f63c6bb 5485 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5486
a6670b0b
PE
5487 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5488 Rename locals to avoid shadowing.
5489
cef2010d 5490 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5491 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5492
d4d7173a
PE
5493 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5494
f08b802a
PE
5495 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5496 warning when compiling print.c.
5497
3ddb0639
PE
5498 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5499 instead of using an uninitialized var.
5ad03b97 5500 (font_sort_entities): Mark var as initialized.
3ddb0639 5501
170a2692
PE
5502 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5503
e663c700
PE
5504 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5505 pointers to constants.
89bc529a 5506 (font_parse_fcname): Remove unused vars.
7b81e2d0 5507 (font_delete_unmatched): Now static.
ea838e10 5508 (font_get_spec): Remove; unused.
13a547c6
PE
5509 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5510 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5511 Rename or move locals to avoid shadowing.
e663c700 5512
2a80c887 5513 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5514 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5515
1384fa33 5516 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5517 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5518
8b2c52e9
PE
5519 * alloc.c (mark_backtrace): Move decl from here ...
5520 * lisp.h: ... to here, so that it can be checked.
5521
475545b5 5522 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5523 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5524 (lisp_indirect_variable): Name an expression,
5525 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5526 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5527
b1349114 5528 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5529 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5530 Use const pointer when appropriate.
b1349114 5531
a2928364
PE
5532 * lisp.h (get_system_name, get_operating_system_release):
5533 Move decls here, to check interfaces.
5534 * process.c (get_operating_system_release): Move decl to lisp.h.
5535 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5536 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5537 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5538 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5539 (Fformat_time_string, Fencode_time, Finsert_char):
5540 (Ftranslate_region_internal, Fformat):
5541 Rename or remove local vars to avoid shadowing.
9710023e 5542 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5543
a415e694
PE
5544 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5545 avoid shadowing.
5546
8ef4622d
PE
5547 * lisp.h (eassert): Check that the argument compiles, even if
5548 ENABLE_CHECKING is not defined.
5549
946f9a5b
PE
5550 * data.c (Findirect_variable): Name an expression, to avoid
5551 gcc -Wbad-function-cast warning.
112396d6 5552 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5553 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5554 (Fmake_variable_buffer_local, Fmake_local_variable):
5555 Mark variables as initialized.
52746918 5556 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5557
e5aab7e7 5558 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5559 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5560 Rename locals to avoid shadowing.
dff45157
PE
5561 (mark_stack): Move local variables into the #ifdef region where
5562 they're used.
7bc26fdb
PE
5563 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5564 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5565 needed otherwise.
5566 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5567 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5568 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5569
e5aab7e7
PE
5570 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5571 avoids undefined behavior in theory.
5572
4da60324
PE
5573 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5574
88043301
PE
5575 Use functions, not macros, for up- and down-casing (Bug#8254).
5576 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5577 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5578 to use the following functions instead of these macros.
5579 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5580 EMACS_INT, since callers assume the returned value fits in int.
5581 (upcase1): Likewise, for UPCASE_TABLE.
5582 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5583 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5584 the race-condition problem in the old DOWNCASE.
88043301 5585
19ed5445
PE
5586 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5587 Rename locals to avoid shadowing.
5588 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5589 (regex_compile, re_search_2, re_match_2_internal):
5590 Remove unused local vars.
952db0d7
PE
5591 (FREE_VAR): Rewrite so as not to use empty "else",
5592 which gcc can warn about.
da053e48 5593 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5594 (RETALLOC_IF): Define only if needed.
5595 (WORDCHAR_P): Likewise. This one is never needed, but is used
5596 only in a comment talking about a compiler bug, so put inside
5597 the #if 0 of that comment.
5598 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5599 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5600 Remove; unused.
19ed5445 5601
1f3561e4 5602 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5603 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5604 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5605
ded6f8f7
PE
5606 * search.c (simple_search): Remove unused var.
5607
dbd37a95
PE
5608 * dired.c (compile_pattern): Move decl from here ...
5609 * lisp.h: ... to here, so that it can be checked.
5610 (struct re_registers): New forward decl.
5611
7e47afad
PE
5612 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5613
85f24f61
PE
5614 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5615 All uses changed.
5616 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5617 Rename locals to avoid shadowing.
5671df8f 5618 (Fvertical_motion): Mark locals as initialized.
85f24f61 5619
181aa2be 5620 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5621 (casify_region): Mark local as initialized.
181aa2be 5622
930d429c
PE
5623 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5624
7082eac6
PE
5625 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5626 New macros, so that the caller can use some names other than
5627 gcpro1, gcpro2, etc.
5628 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5629 of the new macros.
5630 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5631 argument, for consistency with GCPRO2_VAR, etc: it is now the
5632 prefix of the variable, not the variable itself. All uses
5633 changed.
38b2c076
PE
5634 * dired.c (directory_files_internal, file_name_completion):
5635 Rename locals to avoid shadowing.
5636
15206ed9
PE
5637 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5638 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5639 dired.c's scmp function, had undefined behavior.
5640 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5641 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5642 * buffer.h: ... to here, because these macros use current_buffer,
5643 and the new implementation with inline functions needs to have
5644 current_buffer in scope now, rather than later when the macros
5645 are used.
5646 (downcase, upcase1): New static inline functions.
5647 (DOWNCASE, UPCASE1): Reimplement using these functions.
5648 This avoids undefined behavior in expressions like
5649 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5650 from race conditions in accessing the global variables
5651 case_temp1 and case_temp2.
5652 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5653 * lisp.h (case_temp1, case_temp2): Remove their decls.
5654 * character.h (ASCII_CHAR_P): Move from here ...
5655 * lisp.h: ... to here, so that the inline functions mentioned
5656 above can use them.
5657
4a6bea26
PE
5658 * dired.c (directory_files_internal_unwind): Now static.
5659
f14b7e14
PE
5660 * fileio.c (file_name_as_directory, directory_file_name):
5661 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5662 Now static.
2893f146
PE
5663 (file_name_as_directory): Use const pointers when appropriate.
5664 (Fexpand_file_name): Likewise. In particular, newdir might
5665 point at constant storage, so make it a const pointer.
fd4ead52 5666 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5667 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5668 signedness issues.
f839df0c
PE
5669 (Fset_file_times, Finsert_file_contents, auto_save_error):
5670 Rename locals to avoid shadowing.
f14b7e14 5671
5716756e 5672 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5673 (Ftry_completion, Fall_completions): Rename or remove locals
5674 to avoid shadowing.
5716756e 5675
b4c3046a
PE
5676 * marker.c (bytepos_to_charpos): Remove; unused.
5677
b45db522
PE
5678 * lisp.h (verify_bytepos, count_markers): New decls,
5679 so that gcc does not warn that these functions aren't declared.
5680
85876d07
PE
5681 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5682 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5683 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5684 (copy_text): Remove unused local var.
85876d07 5685
03d78a21 5686 * filelock.c (within_one_second): Now static.
b3dd38ab 5687 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5688
5df8f01b
PE
5689 * buffer.c (fix_overlays_before): Mark locals as initialized.
5690 (fix_start_end_in_overlays): Likewise. This function should be
5691 simplified by using pointers-to-pointers, but that's a different
5692 matter.
b1d876f1 5693 (switch_to_buffer_1): Now static.
8f54f30a
PE
5694 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5695 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5696
a70072c9 5697 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5698 Fix pointer signedness issue.
edced198
PE
5699 (sys_subshell): Mark local as volatile if checking for lint,
5700 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5701 (MAXPATHLEN): Define only if needed.
a70072c9 5702
a0977c44
PE
5703 * process.c (serial_open, serial_configure): Move decls from here ...
5704 * systty.h: ... to here, so that they can be checked.
5705
a884fdcc
PE
5706 * fns.c (get_random, seed_random): Move extern decls from here ...
5707 * lisp.h: ... to here, so that they can be checked.
5708
604efe86 5709 * sysdep.c (reset_io): Now static.
b8950c94 5710 (wait_for_termination_signal): Remove; unused.
604efe86 5711
38fc62d9
PE
5712 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5713 (copy_keymap_item, append_key, push_text_char_description):
5714 Now static.
1004a21a 5715 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5716 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5717 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5718 (describe_map_tree):
5719 Rename locals to avoid shadowing.
38fc62d9 5720
2f2650da
PE
5721 * keyboard.c: Declare functions static if they are not used elsewhere.
5722 (echo_char, echo_dash, cmd_error, top_level_2):
5723 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5724 (read_char, kbd_buffer_get_event, make_lispy_position):
5725 (make_lispy_event, make_lispy_movement, apply_modifiers):
5726 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5727 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5728 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5729 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5730 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5731
a053e86c 5732 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5733 (mark_kboards): Move decl here ...
5734 * alloc.c (mark_kboards): ... from here.
a053e86c 5735
4752793e
PE
5736 * lisp.h (force_auto_save_soon): New decl.
5737
74f10ca7 5738 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5739 (DEFINE_DUMMY_FUNCTION): New macro.
5740 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5741 Use it.
c03cd23f
PE
5742 (main): Add casts to avoid warnings
5743 if GCC considers string literals to be constants.
74f10ca7 5744
022e70d4
PE
5745 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5746
59d6fe83
PE
5747 * dbusbind.c: Pointer signedness fixes.
5748 (xd_signature, xd_append_arg, xd_initialize):
5749 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5750 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5751 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5752 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5753
78320123
PE
5754 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5755 if GCC considers string literals to be constants.
49cebcca 5756 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5757
35ac2a97
SM
57582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5759
fb103ca9
SM
5760 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5761 (print_preprocess, print_object): New macro to fix last change.
5762
35ac2a97
SM
5763 * print.c (print_preprocess): Don't forget font objects.
5764
62973b41
JB
57652011-03-16 Juanma Barranquero <lekktu@gmail.com>
5766
5767 * emacs.c (USAGE3): Doc fixes.
5768
0e48bb22
AS
57692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5770
5771 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5772 structure.
5773
7684e57b
JB
57742011-03-14 Juanma Barranquero <lekktu@gmail.com>
5775
5776 * lisp.h (VWindow_system, Qfile_name_history):
5777 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5778 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5779 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5780
5781 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5782 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5783
5784 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5785 * w32console.c (detect_input_pending, read_input_pending)
5786 (encode_terminal_code):
5787 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5788 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5789 (w32_system_caret_y, Qfile_name_history):
5790 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5791 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5792 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5793 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5794 * w32proc.c (Qlocal, report_file_error):
5795 * w32term.c (Vwindow_system, updating_frame):
5796 * w32uniscribe.c (initialized, uniscribe_font_driver):
5797 Remove unneeded extern declarations.
5798
2aa46d6c
CY
57992011-03-14 Chong Yidong <cyd@stupidchicken.com>
5800
c96bbc66 5801 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5802
cffc6f3b
CY
58032011-03-13 Chong Yidong <cyd@stupidchicken.com>
5804
5805 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5806 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5807 These macros can no longer be used for assignment.
5808
44f230aa
SM
5809 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5810 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5811 (record_buffer_markers, fetch_buffer_markers): New functions for
5812 recording and fetching special buffer markers.
5813 (set_buffer_internal_1, set_buffer_temp): Use them.
5814
5815 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5816
5817 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5818
5819 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5820 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5821
5822 * xdisp.c (hscroll_window_tree):
5823 (reconsider_clip_changes): Use PT instead of BUF_PT.
5824
d251f04b
EZ
58252011-03-13 Eli Zaretskii <eliz@gnu.org>
5826
5827 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5828 $(EMACS_ROOT)/lib/intprops.h.
5829
f0c77cd1
PE
58302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5831
3eca4629
PE
5832 Fix more problems found by GCC 4.5.2's static checks.
5833
7c86ee98
PE
5834 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5835 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5836 (xg_free_frame_widgets): Make it clear that a local variable is
5837 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5838 (gdk_window_get_screen): Make it clear that this macro is needed
5839 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5840 (int_gtk_range_get_value): New function, which avoids a diagnostic
5841 from gcc -Wbad-function-cast.
5842 (xg_set_toolkit_scroll_bar_thumb): Use it.
5843 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5844 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5845 (get_utf8_string, xg_get_file_with_chooser):
5846 Rename locals to avoid shadowing.
5847 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5848
41729b81
PE
5849 * xgselect.c (xg_select): Remove unused var.
5850
f0c77cd1
PE
5851 * image.c (four_corners_best): Mark locals as initialized.
5852 (gif_load): Initialize transparent_p to zero (Bug#8238).
5853 Mark another local as initialized.
ec6cf4c6 5854 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5855
ce0ad53d 5856 * image.c (clear_image_cache): Now static.
d5d5a617 5857 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5858 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5859 (x_edge_detection): Remove unnecessary cast that
5860 gcc -Wbad-function-cast diagnoses.
2037898d 5861 (gif_load): Fix pointer signedness.
6ae141d6
PE
5862 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5863 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5864
33383987 58652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5866
d32df629
PE
5867 Improve quality of tests for time stamp overflow.
5868 For example, without this patch (encode-time 0 0 0 1 1
5869 1152921504606846976) returns the obviously-bogus value (-948597
5870 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5871 reports time overflow. See
5872 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5873 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5874 * editfns.c: Include limits.h and intprops.h.
5875 (TIME_T_MIN, TIME_T_MAX): New macros.
5876 (time_overflow): Move earlier, to before first use.
5877 (hi_time, lo_time): New functions, for an accurate test for
5878 out-of-range times.
5879 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5880 (Fget_internal_run_time): Don't assume time_t fits in int.
5881 (make_time): Use list2 instead of Fcons twice.
5882 (Fdecode_time): More accurate test for out-of-range times.
5883 (check_tm_member): New function.
5884 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5885 (lisp_time_argument): Don't rely on undefined left-shift and
5886 right-shift behavior when checking for time stamp overflow.
8be6f318 5887
fe31d94c
PE
5888 * editfns.c (time_overflow): New function, refactoring common code.
5889 (Fformat_time_string, Fdecode_time, Fencode_time):
5890 (Fcurrent_time_string): Use it.
5891
8be6f318
PE
5892 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5893 * dired.c (make_time): Move to ...
5894 * editfns.c (make_time): ... here.
5895 * systime.h: Note the move.
5896
09d9db2c 58972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5898
126bc0dc
YM
5899 * fringe.c (update_window_fringes): Remove unused variables.
5900
c47cbdfd
YM
5901 * unexmacosx.c (copy_data_segment): Also copy __got section.
5902 (Bug#8223)
5903
7ac80be9
EZ
59042011-03-12 Eli Zaretskii <eliz@gnu.org>
5905
c96bbc66 5906 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5907 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5908 Constify `char *' arguments and their references according to
5909 prototypes in tparam.h.
5910
ecb0f94d 5911 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5912
7ac80be9
EZ
5913 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5914 Adapt all references accordingly.
5915
5916 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5917
ef1fd07e
TT
59182011-03-11 Tom Tromey <tromey@redhat.com>
5919
5920 * buffer.c (syms_of_buffer): Remove obsolete comment.
5921
7ef4b50c
EZ
59222011-03-11 Eli Zaretskii <eliz@gnu.org>
5923
5924 * termhooks.h (encode_terminal_code): Declare prototype.
5925
5926 * msdos.c (encode_terminal_code): Don't declare prototype.
5927
5928 * term.c (encode_terminal_code): Now external again, used by
5929 w32console.c and msdos.c.
5930
44f230aa
SM
5931 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5932 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5933
4b1ec863 59342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5935
1714f52b 5936 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5937
4b1ec863
PE
5938 * fringe.c (update_window_fringes): Mark locals as initialized
5939 (Bug#8227).
5940 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5941
524c7aa6
PE
5942 * alloc.c (mark_fringe_data): Move decl from here ...
5943 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5944 to check its interface.
5945 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5946
a5c0af81 5947 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5948 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5949 (fontset_font): Mark local as initialized.
a9a06e0b 5950 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5951
b4716021
PE
5952 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5953
811e9bac 5954 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5955 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5956 (x_own_selection, Fx_disown_selection_internal): Rename locals
5957 to avoid shadowing.
5958 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5959
7e3ab302
PE
5960 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5961 so that the caller can use some name other than gcpro1.
5962 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5963 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5964 (Fx_backspace_delete_keys_p):
5965 Use them to avoid shadowing, and rename vars to avoid shadowing.
5966 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5967 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5968 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5969 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5970 Remove unused locals.
7e3ab302
PE
5971 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5972 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5973 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5974 macros.
f78faa98 5975
e2b13473
PE
5976 * xterm.h (x_mouse_leave): New decl.
5977
77f23912
PE
5978 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5979 Remove unused functions.
cdf4ba58
PE
5980 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5981 (x_calc_absolute_position): Now static.
7411c686 5982 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5983 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5984 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5985 unless they are used.
38d0b34a
PE
5986 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5987 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5988 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5989 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5990 (x_error_catcher, x_connection_closed, x_error_handler):
5991 (x_error_quitter, xembed_send_message, x_iconify_frame):
5992 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5993 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5994 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5995
44f230aa
SM
5996 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5997 Rename or move locals to avoid shadowing.
6b463e58 5998 (tty_defined_color, merge_face_heights): Now static.
5967d051 5999 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6000 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6001 does not deduce is never used uninitialized.
73719eba
PE
6002 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6003 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6004
426994c3 6005 * terminal.c (store_terminal_param): Now static.
5489860b 6006
032f1620 6007 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6008 (set_frame_menubar): Remove unused local.
d4323972 6009 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6010 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6011 since they might point to immutable storage.
281585b0
PE
6012 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6013 since it's unused otherwise.
032f1620 6014
367c19e5 6015 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6016 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6017 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6018 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6019 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6020 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6021 does not deduce are never used uninitialized.
70739cbe 6022
07b48fa9
PE
6023 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6024
8868a238 6025 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6026 * window.c (window_loop, size_window):
6027 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6028
7e5cf297 6029 * window.c (display_buffer): Now static.
d6550a9f
PE
6030 (size_window): Mark variables that gcc -Wuninitialized
6031 does not deduce are never used uninitialized.
a586633d
PE
6032 * window.h (check_all_windows): New decl, to forestall
6033 gcc -Wmissing-prototypes diagnostic.
5b555da1 6034 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6035
f6095868
PE
6036 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6037 shadowing.
6038 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6039 Include <limits.h>.
6040 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6041 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6042 (load_charset_map): Mark variables that gcc -Wuninitialized
6043 does not deduce are never used uninitialized.
53df7c11 6044 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6045
f38b440c
PE
6046 * coding.c (coding_set_source, coding_set_destination):
6047 Use "else { /* comment */ }" rather than "else /* comment */;"
6048 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6049 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6050 a block, when the outer 'i' will do.
6051 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6052 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6053 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6054 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6055 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6056 Rename locals to avoid shadowing.
6057 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6058 * coding.c (emacs_mule_char, encode_invocation_designation):
6059 Now static, since they're not used elsewhere.
413bb2db 6060 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6061 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6062 (decode_coding_emacs_mule): Mark variables that gcc
6063 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6064 (detect_coding_iso_2022): Initialize a local variable that might
6065 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6066 this initialization is needed. (Bug#8211)
5f58e762
PE
6067 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6068 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6069 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6070 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6071 Remove unused macros.
f38b440c 6072
232b38b9 6073 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6074 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6075 * character.c (string_count_byte8): Likewise.
232b38b9 6076
fb90da1b
PE
6077 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6078 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6079
fb93dbc2
PE
6080 * chartab.c (copy_sub_char_table): Now static, since it's not used
6081 elsewhere.
5c156ace
PE
6082 (sub_char_table_ref_and_range, char_table_ref_and_range):
6083 Rename locals to avoid shadowing.
bbcd0949 6084 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6085
7d3b3862 6086 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6087 (BIDI_BOB): Remove unused macro.
7d3b3862 6088
6be7d3da
PE
6089 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6090 deduce are never used uninitialized.
c2ed9c8b 6091 * term.c (encode_terminal_code): Likewise.
6be7d3da 6092
75f8807f 6093 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6094
50938595
PE
6095 * tparam.h: New file.
6096 * term.c, tparam.h: Include it.
6097 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6098 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6099 Move these decls to tparam.h, and make them agree with what
6100 is actually in tparam.c. The previous trick of using incompatible
6101 decls in different modules does not conform to the C standard.
6102 All callers of tparam changed to use tparam's actual API.
6103 * tparam.c (tparam1, tparam, tgoto):
6104 Use const pointers where appropriate.
6105
fbceeba2
PE
6106 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6107 * cm.h (struct cm): Likewise.
6108 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6109 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6110 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6111 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6112 (turn_on_face, init_tty): Likewise.
6113 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6114
7f3f1250
PE
6115 * term.c (term_mouse_position): Rename local to avoid shadowing.
6116
e6ca6543
PE
6117 * alloc.c (mark_ttys): Move decl from here ...
6118 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6119
c40f8d15
AS
61202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6121
6122 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6123
cfe0661d
JB
61242011-03-09 Juanma Barranquero <lekktu@gmail.com>
6125
6126 * search.c (compile_pattern_1): Remove argument regp, unused since
6127 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6128 (compile_pattern): Don't pass it.
6129
0afb4571
J
61302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6131
6132 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6133 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6134 for ! HAVE_GTK3.
6135 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6136
6137 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6138
6139 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6140 gdk_window_get_screen, gdk_window_get_geometry,
6141 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6142 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6143 (xg_get_pixbuf_from_pixmap): New function.
6144 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6145 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6146 Call xg_get_pixbuf_from_pixmap instead of
6147 gdk_pixbuf_get_from_drawable.
6148 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6149 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6150 (xg_check_special_colors): Use GtkStyleContext and its functions
6151 for HAVE_GTK3.
6152 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6153 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6154 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6155 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6156 Call gtk_widget_get_preferred_size.
0afb4571
J
6157 (xg_frame_resized): gdk_window_get_geometry only takes 5
6158 parameters.
44f230aa
SM
6159 (xg_win_to_widget, xg_event_is_for_menubar):
6160 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6161 (xg_set_widget_bg): New function.
6162 (delete_cb): New function.
895009e1 6163 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6164 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6165 (xg_set_background_color): Call xg_set_widget_bg.
6166 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6167 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6168 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6169 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6170 if ! HAVE_GTK3.
6171 (update_frame_tool_bar): Call gtk_widget_hide.
6172 (xg_initialize): Use GDK_KEY_g.
6173
6174 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6175 if ! HAVE_GTK3
6176 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6177
6178 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6179 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6180 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6181
1c2cc4ef
JB
61822011-03-08 Juanma Barranquero <lekktu@gmail.com>
6183
6184 * w32xfns.c (select_palette): Check success of RealizePalette against
6185 GDI_ERROR, not zero.
6186
33383987 6187See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6188
6189;; Local Variables:
6190;; coding: utf-8
aac0c6e3
MR
6191;; End:
6192
33383987 6193 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6194
6195 This file is part of GNU Emacs.
6196
6197 GNU Emacs is free software: you can redistribute it and/or modify
6198 it under the terms of the GNU General Public License as published by
6199 the Free Software Foundation, either version 3 of the License, or
6200 (at your option) any later version.
6201
6202 GNU Emacs is distributed in the hope that it will be useful,
6203 but WITHOUT ANY WARRANTY; without even the implied warranty of
6204 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6205 GNU General Public License for more details.
6206
6207 You should have received a copy of the GNU General Public License
6208 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.