There's no reason not to compile version.el
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e8d32c7e
SM
12012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2
48def666
SM
3 * lread.c: Remove `read_pure' which makes no difference.
4 (read_pure): Remove var.
5 (unreadpure): Remove function.
6 (readevalloop): Don't call read_list with -1 flag.
7 (read1, read_vector): Don't test read_pure any more.
8 (read_list): Simplify.
9
e8d32c7e
SM
10 * fileio.c, character.h: Minor style tweaks.
11
4b2addb7
DA
122012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
13
14 * window.h (clip_changed): Remove useless declaration.
15
584461b2
JB
162012-05-22 Juanma Barranquero <lekktu@gmail.com>
17
18 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
19 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
20
34374650
PE
212012-05-22 Paul Eggert <eggert@cs.ucla.edu>
22
23 Remove src/m/*.
24 This directory predates autoconf and is no longer needed nowadays.
25 Move its few remaining bits of functionality to where they're needed.
26 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
27 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
28 * m/template.h: Remove.
29 * Makefile.in (M_FILE): Remove. All uses removed.
30 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
31 * lisp.h (USE_LSB_TAG):
32 * mem-limits.h (EXCEEDS_LISP_PTR):
33 Use VAL_MAX, not VALBITS, in #if.
34 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
35 (EMACS_UINT): Define unconditionally now.
36 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
37 (BITS_PER_EMACS_INT): New constants, replacing
38 what used to be in config.h, but not useful in #if.
39 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
40 define them any more.
41 (VAL_MAX): New macro.
42 (VALMASK): Use it.
43 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
44 BITS_PER_EMACS_INT, in #if.
45 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
46 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
47 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
48 * s/ms-w32.h (DATA_START):
49 Move here from removed file m/intel386.h.
50 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
51 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
52
261cb4bb
PE
532012-05-21 Paul Eggert <eggert@cs.ucla.edu>
54
55 Assume C89 or later.
56 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
57 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
58 (xrealloc):
59 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
60 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
61 * textprop.c, tparam.c (NULL): Remove.
62 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
63 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
64 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
65 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
66 * xterm.c (input_signal_count): Assume volatile works.
67
ff23cd9f
KB
682012-05-21 Ken Brown <kbrown@cornell.edu>
69
70 * xgselect.c (xg_select): Fix first argument in call to 'select'
71 (bug#11508).
72
1b170bc6
KB
732012-05-20 Ken Brown <kbrown@cornell.edu>
74
75 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 76 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 77
b2f4d39f
KB
782012-05-19 Ken Brown <kbrown@cornell.edu>
79
80 * xfns.c (x_in_use): Remove `static' qualifier.
81 * xterm.h (x_in_use): Declare.
82 * xgselect.c: Include xterm.h.
83 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
84 and `display_arg' (bug#9754).
85
003fdae2
PE
862012-05-19 Paul Eggert <eggert@cs.ucla.edu>
87
9232a6d9
PE
88 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
89
003fdae2
PE
90 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
91 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
92
784b56e2
EZ
932012-05-18 Eli Zaretskii <eliz@gnu.org>
94
95 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
96
97 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
98 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
99
100 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
101 reference to image_cache->refcount.
102 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
103
a0a79cde
JL
1042012-05-17 Juri Linkov <juri@jurta.org>
105
106 * search.c (Fword_search_regexp, Fword_search_backward)
107 (Fword_search_forward, Fword_search_backward_lax)
108 (Fword_search_forward_lax): Move functions to isearch.el
109 (bug#10145, bug#11381).
110
b0572523
PE
1112012-05-16 Paul Eggert <eggert@cs.ucla.edu>
112
113 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
114
9660f5fc
SM
1152012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
116
117 * lread.c (init_obarray): Declare Qt and Qnil as special.
118
4374de83
GM
1192012-05-14 Glenn Morris <rgm@gnu.org>
120
121 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 122 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 123
dc44c39a
PE
1242012-05-14 Paul Eggert <eggert@cs.ucla.edu>
125
078c97cb
PE
126 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
127
dc44c39a
PE
128 * unexaix.c: Port to more-recent AIX compilers.
129 (report_error, report_error_1, make_hdr, copy_sym)
130 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
131 Make arguments const char *, not char *, to avoid violations of C
132 standard and to fix some AIX warnings reported by Gilles Pion.
133
e18afed7 1342012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
135
136 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
137 already have overlays loaded.
138 (handle_single_display_spec): Before returning without displaying
139 fringe bitmap, synchronize the bidi iterator with the main display
140 iterator, by calling iterate_out_of_display_property.
141 (iterate_out_of_display_property): Detect buffer iteration by
142 testing that it->string is a Lisp string.
143 (get_next_display_element): When the current object is exhausted,
144 and there's something on it->stack, call set_iterator_to_next to
145 proceed with what's on the stack, instead of returning zero.
146 (set_iterator_to_next): If called at the end of a Lisp string,
147 proceed to consider_string_end without incrementing string
148 position. Don't increment display vector index past the end of
149 the display vector. (Bug#11417)
c8fb9dc6
EZ
150 (pos_visible_p): Don't report a position visible when move_it_to
151 stopped at the last line of window, which happens to be scanned
152 backwards by the bidi iteration. (Bug#11464)
ac268e67 153
e18afed7 1542012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
155
156 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
157 and right-margin display specs even if the spec is invalid or we
158 are on a TTY, and thus unable to display on the fringes. That's
159 because the text with the property will not be displayed anyway,
160 so we need to signal to the caller that this is a "replacing"
161 display spec. This fixes display when the spec is invalid or we
162 are on a TTY.
163
e18afed7 1642012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
165
166 * unexaix.c (make_hdr): Fix typo in prototype.
167 This bug broke the build on AIX. Problem reported by Gilles Pion.
168
9d0a235a
MA
1692012-05-14 Michael Albinus <michael.albinus@gmx.de>
170
171 * keyboard.c (kbd_buffer_get_event): Read special events also in
172 batch mode. (Bug#11415)
173
9e6b06ed
GM
1742012-05-12 Glenn Morris <rgm@gnu.org>
175
176 * ns.mk: Update for ns_appbindir no longer having trailing "/".
177
c1a1d7a3
EZ
1782012-05-12 Eli Zaretskii <eliz@gnu.org>
179
180 * lisp.mk (lisp): Add newcomment.elc.
181
3fe7cdc8
GM
1822012-05-12 Glenn Morris <rgm@gnu.org>
183
184 * Makefile.in (MKDIR_P): New, set by configure.
185 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
186
53f7d2c0
PE
1872012-05-11 Paul Eggert <eggert@cs.ucla.edu>
188
189 Remove unused function hourglass_started.
190 * dispextern.h (hourglass_started):
191 * w32fns.c (hourglass_started):
192 * xdisp.c (hourglass_started): Remove.
193
75aafb17
JB
1942012-05-10 Juanma Barranquero <lekktu@gmail.com>
195
196 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
197 Update dependencies.
198
12959e8e
PE
1992012-05-10 Paul Eggert <eggert@cs.ucla.edu>
200
97107e2e
PE
201 * xgselect.c (xg_select): Put maxfds+1 into a var.
202 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
203
12959e8e
PE
204 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
205
836d29b3
DA
2062012-05-10 Dave Abrahams <dave@boostpro.com>
207
208 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
209 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
210
5cb67954
MA
2112012-05-09 Michael Albinus <michael.albinus@gmx.de>
212
213 * dbusbind.c (xd_registered_buses): New internal Lisp object.
214 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
215 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
216 Initialize xd_registered_buses.
217
3478ec45
PE
2182012-05-09 Paul Eggert <eggert@cs.ucla.edu>
219
b263a6b0
PE
220 Untag more efficiently if USE_LSB_TAG.
221 This is based on a proposal by YAMAMOTO Mitsuharu in
222 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
223 For an admittedly artificial (nth 8000 longlist) benchmark on
224 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
225 Emacs's overall text size by 1%.
226 * lisp.h (XUNTAG): New macro.
227 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
228 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
229 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
230 * eval.c (Fautoload):
231 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
232 * frame.h (XFRAME): Use XUNTAG.
233
3478ec45
PE
234 Port recent dbusbind.c changes to 32-bit --with-wide-int.
235 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
236 Remove unportable assumptions about print widths of types like
237 dbus_uint32_t.
238 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
239 intptr_t when converting between pointer and integer, to avoid GCC
240 warnings about wrong width.
241
666b903b 2422012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
243
244 * w32proc.c (new_child): Force Windows to reserve only 64KB of
245 stack for each reader_thread, instead of defaulting to 8MB
246 determined by the linker. This avoids failures in creating
247 subprocesses on Windows 7, see the discussion in this thread:
248 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
249
b120cc17
JC
2502012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
251
252 Fix up display of the *Minibuf-0* buffer in the mini window.
253 * keyboard.c (read_char): Don't clear the echo area if there's no
254 message to clear.
255 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 256 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 257
9a4b36f8
MA
2582012-05-07 Michael Albinus <michael.albinus@gmx.de>
259
260 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
261 batch mode.
262
e5f9458f
CY
2632012-05-06 Chong Yidong <cyd@gnu.org>
264
265 * lisp.mk (lisp): Update.
266
eceeb5fc 2672012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
268
269 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
270
71873e2b
SM
2712012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
272
273 * data.c (PUT_ERROR): New macro.
274 (syms_of_data): Use it. Add new error type `user-error'.
275 * undo.c (user_error): New function.
276 (Fprimitive_undo): Use it.
277 * print.c (print_error_message): Adjust print style for `user-error'.
278 * keyboard.c (user_error): New function.
279 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
280
ab0fa4e4
PE
2812012-05-03 Paul Eggert <eggert@cs.ucla.edu>
282
283 Do not limit current-time-string to years 1000..9999.
284 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
285 (Fcurrent_time_string): Support any year that is supported by the
286 underlying localtime representation. Don't use asctime, as it
287 has undefined behavior for years outside the range -999..9999.
288
7ed806a7
PE
2892012-05-02 Paul Eggert <eggert@cs.ucla.edu>
290
291 Fix race conditions involving setenv, gmtime, localtime, asctime.
292 Without this fix, interrupts could mess up code that uses these
293 nonreentrant functions, since setting TZ invalidates existing
294 tm_zone or tzname values, and since most of these functions return
295 pointers to static storage.
296 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
297 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
298 Grow the critical sections to include not just invoking
299 localtime/gmtime, but also accessing these functions' results
300 including their tm_zone values if any, and any related TZ setting.
301 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
302 so that the struct tm is saved in the critical section.
303 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
304 motivated by the fact that memory allocation needs to be outside
305 the critical section.
306
0c16dfed
DA
3072012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
308
309 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
310 with RESET_INTERVAL.
311
312 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
313 Remove duplicated buffer name initialization.
314
3f83ace8
JM
3152012-05-02 Jim Meyering <jim@meyering.net>
316
317 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
318
c7b8541e
JM
319 * xfns.c (x_window): Use xstrdup (Bug#11375).
320
90207a15 3212012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
322
323 * xdisp.c (pos_visible_p): If already at a newline from the
324 display string before the 'while' loop, don't walk back the glyphs
325 from it3.glyph_row. Solves assertion violation when the display
326 string begins with a newline (egg.el). (Bug#11367)
327
b593d6a9
AH
3282012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
329
330 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
331 Move to simple.el.
332
4737362e
GM
3332012-05-01 Glenn Morris <rgm@gnu.org>
334
99cf43f9
GM
335 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
336 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
337 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
338 All were removed before 23.1.
339
9311dcff
GM
340 * dispnew.c: Remove HAVE_LIBNCURSES test;
341 it is always true on relevant platforms.
342
4d5c6349
GM
343 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
344 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
345
4737362e
GM
346 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
347
74dd3a6b
AS
3482012-04-30 Andreas Schwab <schwab@linux-m68k.org>
349
350 * .gdbinit (xpr): Remove checks for no longer existing misc types.
351 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
352 Remove.
353
13c379ee
PE
3542012-04-28 Paul Eggert <eggert@cs.ucla.edu>
355
356 Do not avoid creating empty evaporating overlays (Bug#9642).
357 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
358 That is, do not delete an evaporating overlay if it becomes
359 empty after its bounds are adjusted to fit within its buffer.
360 This fix caused other problems, and I'm reverting it until we get
361 to the bottom of them.
362
a8e7d6d7 3632012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
364
365 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
366
a8e7d6d7 3672012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
368
369 * xdisp.c (pos_visible_p): If the window start position is beyond
370 ZV, start the display from buffer beginning. Prevents assertion
371 violation in init_iterator when the minibuffer window is scrolled
372 via the scroll bar.
373
374 * window.c (window_scroll_pixel_based): Likewise.
375
a8e7d6d7 3762012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
377
378 * keymap.c (where_is_internal): Doc fix (Bug#10872).
379
a8e7d6d7 3802012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
381
382 * fileio.c (Fcopy_file, Fset_file_selinux_context):
383 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
384
a8e7d6d7 3852012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 386
b593d6a9
AH
387 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
388 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 389
1c6900d9
EZ
3902012-04-26 Eli Zaretskii <eliz@gnu.org>
391
4c3fa1d9
EZ
392 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
393 display element, check also the underlying string or buffer
394 character. (Bug#11341)
395
1c6900d9
EZ
396 * w32menu.c: Include w32heap.h.
397 (add_menu_item): If the call to AppendMenuW (via
398 unicode_append_menu) fails, disable Unicode menus only if we are
399 running on Windows 9X/Me.
400
42bf8205
AS
4012012-04-24 Andreas Schwab <schwab@linux-m68k.org>
402
403 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
404 (xgetint): Add missing shift for LSB tags.
405
b1bac16e
MR
4062012-04-24 Martin Rudalics <rudalics@gmx.at>
407
408 * keyboard.c (read_char): Don't wipe echo area for select window
409 events: These might get delayed via `mouse-autoselect-window'
410 (Bug#11304).
411
d69621cc
JB
4122012-04-24 Juanma Barranquero <lekktu@gmail.com>
413
414 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
415 manipulation of :loaded-from data.
416
02fd101b
JB
4172012-04-23 Juanma Barranquero <lekktu@gmail.com>
418
419 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
420 now a cons (bug#11311).
421
888bec30
PE
4222012-04-23 Paul Eggert <eggert@cs.ucla.edu>
423
89a438bd
PE
424 Do not create empty overlays with the evaporate property (Bug#9642).
425 * buffer.c (Fmove_overlay): Delete an evaporating overlay
426 if it becomes empty after its bounds are adjusted to fit within
427 its buffer. Without this fix, in a nonempty buffer (let ((o
428 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
429 yields an empty overlay that has the evaporate property, which is
430 not supposed to happen.
431
1068fe4d
PE
432 Fix minor GTK3 problems found by static checking.
433 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
434 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
435 (struct _EmacsFixedClass, emacs_fixed_get_type):
436 Move decls here from emacsgtkfixed.h, since they needn't be public.
437 (emacs_fixed_get_type): Now static.
438 (emacs_fixed_class_init): Omit unused local.
439 (emacs_fixed_child_type): Remove; unused.
440 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
441 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
442 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
443 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
444 (EMACS_FIXED_GET_CLASS): Remove; unused.
445 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
446
888bec30
PE
447 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
448 Problem reported by Juanma Barranquero for Windows -Wunused-function.
449
de85e130
PE
4502012-04-22 Paul Eggert <eggert@cs.ucla.edu>
451
d0baac98 452 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 453 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
454 (__malloc_size_t, __malloc_ptrdiff_t):
455 Remove. All uses removed, replaced by the definiens if needed,
456 since we can assume C89 or better now.
457 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
458 (protect_malloc_state, align, get_contiguous_space)
459 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
460 (malloc_atfork_handler_child, malloc_enable_thread)
461 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
462 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
463 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
464 (special_realloc, _realloc_internal_nolock, _realloc_internal)
465 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
466 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
467 Define using prototypes, not old style.
468 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
469 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
470 (align): Don't assume that signed integer overflow wraps around.
471 Omit unused local var.
472 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
473 (_free_internal_nolock, memalign, mallochook, reallochook):
474 Omit no-longer-needed casts.
475 (valloc): Use getpagesize, not __getpagesize.
476 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
477 (struct hdr): The 'magic' member is now size_t, not unsigned long.
478
de85e130
PE
479 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
480
dcbf5805
MA
4812012-04-22 Michael Albinus <michael.albinus@gmx.de>
482
483 Move functions from C to Lisp. Make non-blocking method calls
484 the default. Implement further D-Bus standard interfaces.
485
486 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
487 (QCdbus_request_name_allow_replacement)
488 (QCdbus_request_name_replace_existing)
489 (QCdbus_request_name_do_not_queue)
490 (QCdbus_request_name_reply_primary_owner)
491 (QCdbus_request_name_reply_in_queue)
492 (QCdbus_request_name_reply_exists)
493 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
494 (QCdbus_registered_serial, QCdbus_registered_method)
495 (QCdbus_registered_signal): New Lisp objects.
496 (XD_DEBUG_MESSAGE): Use sizeof.
497 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
498 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
499 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
500 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
501 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
502 (xd_signature, xd_append_arg): Allow float for integer types.
503 (xd_get_connection_references): New function.
b593d6a9
AH
504 (xd_get_connection_address): Rename from xd_initialize.
505 Return cached address.
dcbf5805
MA
506 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
507 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
508 level.
509 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 510 Return number of refcounts.
dcbf5805
MA
511 (Fdbus_get_unique_name): Make stronger parameter check.
512 (Fdbus_message_internal): New defun.
513 (Fdbus_call_method, Fdbus_call_method_asynchronously)
514 (Fdbus_method_return_internal, Fdbus_method_error_internal)
515 (Fdbus_send_signal, Fdbus_register_service)
516 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
517 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
518 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
519 (Vdbus_compiled_version, Vdbus_runtime_version)
520 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
521 (Vdbus_message_type_method_return, Vdbus_message_type_error)
522 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
523 (Vdbus_registered_buses, Vdbus_registered_objects_table):
524 Adapt docstring.
dcbf5805 525
52828e02
PE
5262012-04-22 Paul Eggert <eggert@cs.ucla.edu>
527
da05bc4c
PE
528 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
529 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
530 Do not assume ptrdiff_t is the same width as 'int'.
531
52828e02
PE
532 * alloc.c: Handle unusual debugging option combinations.
533 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
534 since the two debugging options are incompatible.
535 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
536 is defined.
537 (mem_init, mem_insert, mem_insert_fixup):
538 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
539 (NEED_MEM_INSERT): Remove; no longer needed.
540
f01769f9
LL
5412012-04-22 Leo Liu <sdl.web@gmail.com>
542
543 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
544
5790543d
PE
5452012-04-22 Paul Eggert <eggert@cs.ucla.edu>
546
547 * sysdep.c [__FreeBSD__]: Minor cleanups.
548 (list_system_processes, system_process_attributes) [__FreeBSD__]:
549 Use Emacs indenting style more consistently. Avoid some casts.
550 Use 'double' consistently rather than mixing 'float' and 'double'.
551
b91b7e4d
EW
5522012-04-21 Eduard Wiebe <usenet@pusto.de>
553
b593d6a9
AH
554 * sysdep.c (list_system_processes, system_process_attributes):
555 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 556
6114eb15
AS
5572012-04-21 Andreas Schwab <schwab@linux-m68k.org>
558
559 * lisp.mk (lisp): Update.
560
2f38dff7
PE
5612012-04-20 Paul Eggert <eggert@cs.ucla.edu>
562
563 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
564 It is never used otherwise.
565
4ae29f89
SM
5662012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
567
568 * print.c (print_preprocess): Only check print_depth if print-circle
569 is nil.
570 (print_object): Check for cycles even when print-circle is nil and
571 print-gensym is t, but only check print_depth if print-circle is nil.
572
f30d612a
CY
5732012-04-20 Chong Yidong <cyd@gnu.org>
574
575 * process.c (wait_reading_process_output): If EIO occurs on a pty,
576 set the status to "failed" and ensure that sentinel is run.
577
c07a4c0b 5782012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
579
580 * process.c (Fset_process_inherit_coding_system_flag)
581 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 582 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 583
c07a4c0b 5842012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
585
586 * xdisp.c (string_buffer_position_lim): Limit starting position to
587 BEGV.
588 (set_cursor_from_row): If called for a mode-line or header-line
589 row, return zero immediately.
590 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
591 farther than the first row after the header line, if any.
592 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
593 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
594
c07a4c0b 5952012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 596
4ae29f89
SM
597 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
598 (bug#11238).
ad3a2b41 599
c07a4c0b 6002012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 6012012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
602
603 configure: new option --enable-gcc-warnings (Bug#11207)
604 * Makefile.in (C_WARNINGS_SWITCH): Remove.
605 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
606 (ALL_CFLAGS): Use new macros rather than old.
607 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
608 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
609 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
610 -Wunused-result, -Wunused-variable. This should go away once
611 the Emacs and Gnulib regex code is merged.
612 (xmalloc, xrealloc): Now static.
613
aba027e8
PE
6142012-04-17 Paul Eggert <eggert@cs.ucla.edu>
615
616 * dired.c (Fsystem_groups): Remove unused local.
617
e5a36063
GM
6182012-04-17 Glenn Morris <rgm@gnu.org>
619
620 * dired.c (Fsystem_users): Doc fix.
621
316411f0
DA
6222012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
623
624 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
625 (syms_of_dired): Add them.
626
9426aba4
PE
6272012-04-16 Paul Eggert <eggert@cs.ucla.edu>
628
b62a57be
PE
629 Fix minor alloc.c problems found by static checking.
630 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
631 New extern decls, to avoid calling undeclared functions.
632 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
633 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
634 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
635 (NEED_MEM_INSERT): New macro.
636 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 637 Remove one incorrect comment and fix another.
b62a57be 638
3539f31f
PE
639 Fix minor ralloc.c problems found by static checking.
640 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
641 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
642 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
643 (r_alloc_sbrk): Now static.
644
a041960a
PE
645 Improve ralloc.c interface checking.
646 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
647 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
648 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
649 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
650 [REL_ALLOC]: ... to here, to check interface.
651 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
652 Remove decls. This fixes an "It stinks!".
653
9426aba4
PE
654 * alloc.c (which_symbols): Fix alignment issue / type clash.
655
d55c12ed
AS
6562012-04-15 Andreas Schwab <schwab@linux-m68k.org>
657
658 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
659 (struct Lisp_Misc_Any): Likewise.
660 (struct Lisp_Free): Likewise.
661 * alloc.c (union aligned_Lisp_Symbol): Define.
662 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
663 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
664 (union aligned_Lisp_Misc): Define.
665 (MARKER_BLOCK_SIZE, struct marker_block): Use union
666 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 667 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 668
b948ce8b
PE
6692012-04-14 Paul Eggert <eggert@cs.ucla.edu>
670
671 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
672 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
673 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
674 * s/netbsd.h, s/sol2-6.h:
675 Remove definition of GC_MARK_STACK, since the default now works.
676 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
677 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
678 no longer the default.
679 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
680
35dc09a1 6812012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 682
35dc09a1
GM
683 * lread.c (lisp_file_lexically_bound_p):
684 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 685
35dc09a1
GM
6862012-04-14 Eli Zaretskii <eliz@gnu.org>
687
688 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
689 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
690
6912012-04-14 Jan Djärv <jan.h.d@swipnet.se>
692
693 * nsterm.m (constrainFrameRect): Always constrain when there is only
694 one screen (Bug#10962).
695
bcd86815
KB
6962012-04-13 Ken Brown <kbrown@cornell.edu>
697
698 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
699
c25df26e
RT
7002012-04-13 Reuben Thomas <rrt@sc3d.org>
701
702 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
703
0fc59f1e
DC
7042012-04-11 Daniel Colascione <dancol@dancol.org>
705
706 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
707 against is gone. It's better to use vfork now so that when Cygwin
708 gains a new, working vfork, we use it automatically (bug#10398).
709
de8c03dc
SM
7102012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
711
712 * window.c (save_window_save): Obey window-point-insertion-type.
713
2f097256
GM
7142012-04-11 Glenn Morris <rgm@gnu.org>
715
716 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
717
453b951e
SM
7182012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
719
720 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
721
75f1671a 7222012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
723
724 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
725 (force_quit_count): New var.
726 (handle_interrupt): Use it.
727
2a8ce227
JB
7282012-04-10 Juanma Barranquero <lekktu@gmail.com>
729
730 * w32.c (w32_delayed_load): Record the full path of the library
731 being loaded (bug#10424).
732
935396c0
GM
7332012-04-09 Glenn Morris <rgm@gnu.org>
734
05920a43
GM
735 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
736 not just in the obarray, before snarfing them. (Bug#11036)
737
935396c0
GM
738 * Makefile.in ($(leimdir)/leim-list.el):
739 Pass EMACS rather than BUILT_EMACS.
740
a18ecafa
TZ
7412012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
742
743 * process.c (make_process):
744 * process.h: Add integer `gnutls_handshakes_tried' member to
745 process struct.
746
6bbef4e5
JC
747 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
748 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
749
750 * gnutls.c (gnutls_log_function2i): Convenience log function.
751 (emacs_gnutls_read): Use new log functions,
752 `gnutls_handshakes_tried' process member, and
753 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
754 attempts per process (connection).
755
b4d3bc10
CY
7562012-04-09 Chong Yidong <cyd@gnu.org>
757
758 * eval.c (Fuser_variable_p, user_variable_p_eh)
759 (lisp_indirect_variable): Functions deleted.
760 (Fdefvar): Caller changed.
761
762 * callint.c (Finteractive, Fcall_interactively):
763 * minibuf.c (Fread_variable): Callers changed.
764
70f4d973
EZ
7652012-04-09 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (set_cursor_from_row): If the display string appears in
768 the buffer at position that is closer to point than the position
769 after the display string, display the cursor on the first glyph of
770 the display string. Fixes cursor display when a 'display' text
771 property immediately follows invisible text. (Bug#11094)
772
cb3c2e3e
PE
7732012-04-09 Paul Eggert <eggert@cs.ucla.edu>
774
775 composite.c: use 'double' consistently
776 * composite.c (get_composition_id): Use 'double' consistently
777 instead of converting 'float' to 'double' and vice versa; this is
778 easier to understand and avoids a GCC warning.
779
fd06db5d
GM
7802012-04-09 Glenn Morris <rgm@gnu.org>
781
50fe702a
GM
782 * Makefile.in: Generate leim-list with bootstrap-emacs, in
783 preparation for dumping it with emacs. (Bug#4789)
784 (leimdir): New variable.
785 ($(leimdir)/leim-list.el): New rule.
786 (emacs$(EXEEXT)): Depend on leim-list.el.
787
fd06db5d
GM
788 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
789 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
790 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
791
55c131ee
AS
7922012-04-08 Andreas Schwab <schwab@linux-m68k.org>
793
794 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
795 proper alignment.
796
9209588f
JB
7972012-04-07 Juanma Barranquero <lekktu@gmail.com>
798
799 * xml.c (init_libxml2_functions) [WINDOWSNT]:
800 Remove unused local variable.
801
e3fb2efb
PE
8022012-04-07 Paul Eggert <eggert@cs.ucla.edu>
803
804 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
805 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
806 (mark_memory): Mark Lisp_Objects only if pointers might hide in
807 objects, as mark_maybe_pointer will catch them otherwise.
808 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
809 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
810
b5385551
PE
8112012-04-07 Paul Eggert <eggert@cs.ucla.edu>
812
813 Fix typo that broke non-Windows builds.
814 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
815
9078ead6
EZ
8162012-04-07 Eli Zaretskii <eliz@gnu.org>
817
818 Support building on MS-Windows with libxml2.
819
820 * makefile.w32-in (OBJ2): Add xml.$(O).
821 (GLOBAL_SOURCES): Add xml.c.
822 ($(BLD)/xml.$(O)): New dependency list.
823
824 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
825 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
826 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
827 [!WINDOWSNT]: New macros.
828 (init_libxml2_functions, libxml2_loaded_p): New functions.
829 (parse_region): Call fn_xmlCheckVersion instead of using the macro
830 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
831 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
832 Calls xmlCleanupParser only if libxml2 was loaded (or statically
833 linked in).
6bbef4e5
JC
834 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
835 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
836 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
837
838 * emacs.c: Don't include libxml/parser.h.
839 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
840 xmlCleanupParser directly.
841
842 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
843
3811fdf3
EZ
8442012-04-07 Eli Zaretskii <eliz@gnu.org>
845
846 * indent.c (Fvertical_motion): If there is a display string at
847 point, use it.vpos to compute how many lines to backtrack after
848 move_it_to point. (Bug#11133)
849
2f8e16b2
EZ
8502012-04-06 Eli Zaretskii <eliz@gnu.org>
851
852 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
853 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
854 about subtle differences between FETCH_CHAR* and STRING_CHAR*
855 macros related to unification of CJK characters. For the details,
856 see the discussion following the message here:
857 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
858
3d439cd1
CY
8592012-04-04 Chong Yidong <cyd@gnu.org>
860
861 * keyboard.c (Vdelayed_warnings_list): Doc fix.
862
8bc53d00
EZ
8632012-04-01 Eli Zaretskii <eliz@gnu.org>
864
865 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
866 instead of alloca. (Bug#11138)
867
3b0512a3
AS
8682012-04-01 Andreas Schwab <schwab@linux-m68k.org>
869
870 * w32menu.c (is_simple_dialog): Properly check lisp types.
871 (Bug#11141)
872
8427ddd2
EZ
8732012-03-31 Eli Zaretskii <eliz@gnu.org>
874
979022ef
EZ
875 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
876 position we get to after a call to move_it_to fails the
877 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
878 only if we wind up in a string from display property. (Bug#11063)
879
a6b1c7cc
EZ
880 * window.c (Fdelete_other_windows_internal): Invalidate the row
881 and column information about mouse highlight, so that redisplay
882 restores it after reallocating the glyph matrices. (Bug#7464)
883
8427ddd2
EZ
884 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
885 string comes from a `display' text property, use the buffer
886 position of that property as if we actually saw that position in
887 the row's glyphs.
697ba24b
EZ
888 (move_it_by_lines): Remove the assertion that
889 "it->current_x == 0 && it->hpos == 0" which can be legitimately
890 violated when there's a before-string at the beginning of a line.
891 (Bug#11063)
8427ddd2 892
65a0a738
EZ
8932012-03-30 Eli Zaretskii <eliz@gnu.org>
894
895 * xdisp.c (append_space_for_newline): If the default face was
896 remapped, use the remapped face for the appended newline.
897 (extend_face_to_end_of_line): Use the remapped default face for
898 extending the face to the end of the line.
899 (display_line): Call extend_face_to_end_of_line when the default
900 face was remapped. (Bug#11068)
901
581355cc
EZ
9022012-03-29 Eli Zaretskii <eliz@gnu.org>
903
904 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
905
e8fc049f
SM
9062012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
907
908 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
909
4fb9a543
GM
9102012-03-27 Glenn Morris <rgm@gnu.org>
911
912 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
913 Doc fixes.
914
679910f1
KH
9152012-03-26 Kenichi Handa <handa@m17n.org>
916
917 * dispextern.h (struct glyph): Fix previous change. Change the
918 bit length of glyphless.ch to 25 (Bug#11082).
919
90d49b7f
CY
9202012-03-26 Chong Yidong <cyd@gnu.org>
921
922 * keyboard.c (Vselection_inhibit_update_commands): New variable.
923 (command_loop_1): Use it; inhibit selection update for
924 handle-select-window too (Bug#8996).
925
f514f6f0
FP
9262012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
927
e8fc049f 928 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 929
bf43fa51
KH
9302012-03-25 Kenichi Handa <handa@m17n.org>
931
932 * dispextern.h (struct glyph): Change the bit length of
933 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
934
8a0c01dd
EZ
9352012-03-24 Eli Zaretskii <eliz@gnu.org>
936
937 * s/ms-w32.h (tzname): Include time.h before redirecting to
938 _tzname. Fixes the MSVC build. (Bug#9960)
939
7d1c3a76
AS
9402012-03-24 Andreas Schwab <schwab@linux-m68k.org>
941
8ed79523
AS
942 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
943 characters.
944
7d1c3a76
AS
945 * xterm.c (XTread_socket): Only modify handling_signal if
946 !SYNC_INPUT. (Bug#11080)
947
e99a9b8b
EZ
9482012-03-23 Eli Zaretskii <eliz@gnu.org>
949
950 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
951 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
952 when fetching a multibyte character consumes more bytes than
953 CHAR_BYTES returns, due to unification of CJK characters in
954 string_char. (Bug#11073)
955
5063c0e1
TN
9562012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
957
958 * process.c (wait_reading_process_output): Handle pty disconnect
959 by refraining from sending oneself a SIGCHLD (bug#10933).
960
9f851fbd
CY
9612012-03-22 Chong Yidong <cyd@gnu.org>
962
963 * dispextern.h (struct it): New member string_from_prefix_prop_p.
964
5063c0e1 965 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
966 Mark string as coming from a prefix property.
967 (handle_face_prop): Use default face for prefix strings (Bug#4281).
968 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
969
fb5b8aca
CY
9702012-03-21 Chong Yidong <cyd@gnu.org>
971
972 * xfaces.c (Vface_remapping_alist): Doc fix.
973
62356a1b
EZ
9742012-03-20 Eli Zaretskii <eliz@gnu.org>
975
976 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
977 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
978 Doc fixes.
62356a1b 979
025de85b
CY
9802012-03-20 Chong Yidong <cyd@gnu.org>
981
982 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
983 to reflect default non-nil value of redisplay-dont-pause.
984
4827f94e
KH
9852012-03-19 Kenichi Handa <handa@m17n.org>
986
987 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
988 it fit in a valid range (Bug#11003).
989
e50a24a2
EZ
9902012-03-18 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
993 that is not from display property, accept the row as a "cursor
994 row" if one of the string's character has a non-nil `cursor'
995 property. Fixes cursor positioning when there are newlines in
996 overlay strings, e.g. in icomplete.el. (Bug#11035)
997
9af5ed87
PE
9982012-03-12 Paul Eggert <eggert@cs.ucla.edu>
999
1000 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1001
d1f55f16
CY
10022012-03-12 Chong Yidong <cyd@gnu.org>
1003
1004 * eval.c (inhibit_lisp_code): Rename from
1005 inhibit_window_configuration_change_hook; move from window.c.
1006
1007 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1008 * window.c (run_window_configuration_change_hook)
1009 (syms_of_window): Callers changed.
1010
66c5eebd
CY
10112012-03-11 Chong Yidong <cyd@gnu.org>
1012
413df973
CY
1013 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1014
66c5eebd
CY
1015 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1016
1de11f56
CY
10172012-03-10 Chong Yidong <cyd@gnu.org>
1018
1019 * frame.c (other_visible_frames): Don't assume the selected frame
1020 is visible (Bug#10955).
1021
cae07000
SM
10222012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1023
1024 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1025
89c94350
JD
10262012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1027
1028 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1029 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1030 zero (Bug#10954).
1031
999dd333
GM
10322012-03-03 Glenn Morris <rgm@gnu.org>
1033
01a6dcc8 1034 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1035
de0100f2
EZ
10362012-03-02 Eli Zaretskii <eliz@gnu.org>
1037
1038 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1039 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1040 (redisplay_window, next_element_from_string): Fix typos in
1041 comments.
3e441275
EZ
1042 (redisplay_window): Pass to move_it_vertically the margin in
1043 pixels, not in screen lines.
de0100f2 1044
96a72ee9
GM
10452012-03-02 Glenn Morris <rgm@gnu.org>
1046
1047 * buffer.c (buffer-list-update-hook): Doc fix.
1048
312508d7
EZ
10492012-02-29 Eli Zaretskii <eliz@gnu.org>
1050
1051 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1052 push_it before setting up the iterator for the first overlay
1053 string, even if we have an empty string loaded.
1054 (next_overlay_string): If there's an empty string on the iterator
1055 stack, pop the stack. (Bug#10903)
1056
27f3c637
PE
10572012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1060 Suggested by Stefan Monnier in
1061 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1062 * alloc.c (widen_to_Lisp_Object): New static function.
1063 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1064 and widening them to Lisp_Objects. This would work even if
1065 USE_LSB_TAG is defined and wide integers are used, which might
1066 happen in a future version of Emacs.
1067
3c9dfce6
CY
10682012-02-25 Chong Yidong <cyd@gnu.org>
1069
fa74b241
CY
1070 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1071 Doc fix.
1072
3c9dfce6
CY
1073 * xselect.c (Fx_selection_exists_p): Doc fix.
1074 (x_clipboard_manager_save_all): Print an informative message
1075 before saving to clipboard manager.
1076
9486df08
CY
10772012-02-24 Chong Yidong <cyd@gnu.org>
1078
1079 * keyboard.c (process_special_events): Handle all X selection
1080 requests in kbd_buffer, not just the next one (Bug#8869).
1081
f01d3321
CY
10822012-02-23 Chong Yidong <cyd@gnu.org>
1083
1084 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1085 call when setting menu-bar-lines and tool-bar-lines parameters.
1086 (unwind_create_frame_1): New helper function.
1087
1088 * window.c (inhibit_window_configuration_change_hook): New var.
1089 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1090 (syms_of_window): Initialize it.
f01d3321 1091
86b847b6
CY
10922012-02-22 Chong Yidong <cyd@gnu.org>
1093
1094 * xterm.c (x_draw_image_relief): Add missing type check for
1095 Vtool_bar_button_margin (Bug#10743).
1096
a59225b1
CY
10972012-02-21 Chong Yidong <cyd@gnu.org>
1098
1099 * fileio.c (Vfile_name_handler_alist): Doc fix.
1100
1101 * buffer.c (Fget_file_buffer): Protect against invalid file
1102 handler return value.
1103
310f5bd4
PE
11042012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1105
cb3a28cc
PE
1106 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1107 when computing $valmask.
1108
310f5bd4
PE
1109 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1110 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1111 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1112 It's useless in that case, and it can cause problems on hosts
1113 that allocate halves of EMACS_INT values separately.
1114 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1115 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1116 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1117 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1118 it avoids undefined behavior on hosts where shifting right by more
1119 than the word width has undefined behavior.
1120
2375c96a
CY
11212012-02-19 Chong Yidong <cyd@gnu.org>
1122
1123 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1124 (Funhandled_file_name_directory, Ffile_name_as_directory)
1125 (Fdirectory_file_name, Fexpand_file_name)
1126 (Fsubstitute_in_file_name): Protect against invalid file handler
1127 return values (Bug#10845).
1128
3eb49e71
EZ
11292012-02-18 Eli Zaretskii <eliz@gnu.org>
1130
1131 * .gdbinit (pitx): Fix incorrect references to fields of the
1132 iterator stack.
1133
7b926f3f
CY
11342012-02-17 Chong Yidong <cyd@gnu.org>
1135
1136 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1137
11273115
PE
11382012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1141 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1142
c3a70e2b
CY
11432012-02-15 Chong Yidong <cyd@gnu.org>
1144
1145 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1146 marked as special. Also, starting docstrings with * is obsolete.
1147
0ca43699
AS
11482012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1149
1150 * gnutls.c (emacs_gnutls_write): Fix last change.
1151
2e8f3c56
LI
11522012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1153
1154 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1155 send_process.
1156
af70074f
SM
11572012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1158
1159 * keymap.c (Fsingle_key_description): Handle char ranges.
1160
95986d52
CY
11612012-02-12 Chong Yidong <cyd@gnu.org>
1162
afd83bd1
CY
1163 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1164 as that creates a dangerous corner case.
1165
95986d52
CY
1166 * window.c (Fdelete_window_internal): Invalidate the mouse
1167 highlight (Bug#9904).
1168
bd7da63e
GM
11692012-02-12 Glenn Morris <rgm@gnu.org>
1170
1171 * xselect.c (Fx_own_selection_internal)
1172 (Fx_get_selection_internal, Fx_disown_selection_internal)
1173 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1174 * nsselect.m (Fx_own_selection_internal)
1175 (Fx_disown_selection_internal, Fx_selection_exists_p)
1176 (Fx_selection_owner_p, Fx_get_selection_internal):
1177 Sync docs and argument specs with the xselect.c versions.
1178
77abcbc2
LI
11792012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1180
1181 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1182
90b671e2
EZ
11832012-02-11 Eli Zaretskii <eliz@gnu.org>
1184
1c0ca0b7
EZ
1185 * w32select.c (Fx_selection_exists_p): Sync doc string and
1186 argument list with xselect.c. (Bug#10783)
1187
1188 * w16select.c (Fx_selection_exists_p): Sync doc string and
1189 argument list with xselect.c. (Bug#10783)
90b671e2 1190
49241268
GM
11912012-02-10 Glenn Morris <rgm@gnu.org>
1192
1193 * fns.c (Fsecure_hash): Doc fix.
1194
f998bbe7 11952012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1196
1197 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1198
0992bd9c
CY
11992012-02-07 Chong Yidong <cyd@gnu.org>
1200
1201 * buffer.c (Fbuffer_local_variables)
1202 (buffer_lisp_local_variables): Handle unbound vars correctly;
1203 don't let Qunbound leak into Lisp.
1204
af008560
GM
12052012-02-07 Glenn Morris <rgm@gnu.org>
1206
dd605cc4
GM
1207 * image.c (Fimagemagick_types): Doc fix.
1208
af008560
GM
1209 * image.c (imagemagick-render-type): Change it from a lisp object
1210 to an integer. Move the doc here from the lisp manual.
1211 Treat all values not equal to 0 the same.
1212
1449fa1d
CY
12132012-02-06 Chong Yidong <cyd@gnu.org>
1214
1215 * doc.c (store_function_docstring): Avoid applying docstring of
1216 alias to base function (Bug#2603).
1217
3723ec07
AS
12182012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1219
1220 * .gdbinit (pp1, pv1): Remove redundant defines.
1221 (pr): Use pp.
1222
79c1cc1e
CY
12232012-02-04 Chong Yidong <cyd@gnu.org>
1224
1225 * nsterm.m: Declare a global (Bug#10694).
1226
d7f29f8e
EZ
12272012-02-04 Eli Zaretskii <eliz@gnu.org>
1228
cae07000
SM
1229 * w32.c (get_emacs_configuration_options):
1230 Include --enable-checking, if specified, in the return value.
d7f29f8e 1231
3b95a6f9
MR
12322012-02-04 Martin Rudalics <rudalics@gmx.at>
1233
1234 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1235 after rounding frame sizes. (Bug#9723)
1236
d6fa96a6
EZ
12372012-02-04 Eli Zaretskii <eliz@gnu.org>
1238
1239 * keyboard.c (adjust_point_for_property): Don't position point
1240 before BEGV. (Bug#10696)
1241
df0b2940
PE
12422012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 Handle overflow when computing char display width (Bug#9496).
1245 * character.c (char_width): Return EMACS_INT, not int.
1246 (char_width, c_string_width): Check for overflow when
1247 computing the width; this is possible now that individual
1248 characters can have unbounded width. Problem introduced
1249 by merge from Emacs 23 on 2012-01-19.
1250
6bee44d6
MA
12512012-02-02 Michael Albinus <michael.albinus@gmx.de>
1252
1253 * dbusbind.c (Fdbus_register_method): Mention the return value
1254 :ignore in the docstring.
1255
44f92739
GM
12562012-02-02 Glenn Morris <rgm@gnu.org>
1257
1b9f60cc
GM
1258 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1259
44f92739
GM
1260 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1261 Unconditionally set to t. (Bug#10673)
1262 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1263 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1264 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1265
c5d3843c
KH
12662012-02-02 Kenichi Handa <handa@m17n.org>
1267
1268 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1269 0, do not call append_composite_glyph.
1270
159462d4 12712012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1272
1273 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1274 NULL (Bug#6988).
1275 (x_produce_glyphs): If the component of a composition is a null
1276 string, set it->pixel_width to 1 to avoid zero-width glyph.
1277
78cef877
EZ
12782012-02-01 Eli Zaretskii <eliz@gnu.org>
1279
1280 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1281 first 2 arguments are identical. This makes inserting large
1282 output from a subprocess an order of magnitude faster on
1283 MS-Windows, where all sbrk'ed memory is always contiguous.
1284
97897668
GM
12852012-01-31 Glenn Morris <rgm@gnu.org>
1286
1287 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1288 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1289 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1290
31fd3586
GM
12912012-01-29 Glenn Morris <rgm@gnu.org>
1292
1293 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1294
0e24a8b2
CY
12952012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1296
1297 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1298
cc0adcb0
CY
12992012-01-28 Chong Yidong <cyd@gnu.org>
1300
1301 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1302
acc28cb9
CY
13032012-01-26 Chong Yidong <cyd@gnu.org>
1304
9c69cfb7
CY
1305 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1306
acc28cb9
CY
1307 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1308 repeat counts (Bug#10507).
1309
48da7392
GM
13102012-01-26 Glenn Morris <rgm@gnu.org>
1311
1312 * lread.c (syms_of_lread): Doc fix.
1313
14af5f7f
CY
13142012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1315
1316 * coding.c (encode_designation_at_bol): Change return value to
1317 EMACS_INT.
1318
0b21c100
CY
13192012-01-25 Chong Yidong <cyd@gnu.org>
1320
1321 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1322
3c2907f7
CY
13232012-01-21 Chong Yidong <cyd@gnu.org>
1324
1325 * floatfns.c (Fcopysign): Make the second argument non-optional,
1326 since nil is not allowed anyway.
1327
959ad23f
AS
13282012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1329
1330 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1331 (send_process): Likewise.
1332
34a02f46
MR
13332012-01-19 Martin Rudalics <rudalics@gmx.at>
1334
1335 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1336 (Vwindow_persistent_parameters): Do not use Qstate.
1337 Rewrite doc-strings.
34a02f46 1338
1259009a 13392012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1340
1341 * character.c (char_width): New function.
70d4fdf6
GM
1342 (Fchar_width, c_string_width, lisp_string_width):
1343 Use char_width (Bug#9496).
25ed9e61 1344
6a6ee00d
MR
13452012-01-16 Martin Rudalics <rudalics@gmx.at>
1346
1347 * window.c (Vwindow_persistent_parameters): New variable.
1348 (Fset_window_configuration, save_window_save): Handle persistent
1349 window parameters.
1350
c85efaf7
EZ
13512012-01-14 Eli Zaretskii <eliz@gnu.org>
1352
1353 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1354 thrashing the stack of the thread. (Bug#9087)
1355
5944709e
PE
13562012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1359
e71f5d99
EZ
13602012-01-11 Eli Zaretskii <eliz@gnu.org>
1361
1362 * xdisp.c (rows_from_pos_range): Handle the case where the
1363 highlight ends on a newline. (Bug#10464)
1364 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1365 he end column for display of highlight that ends on a newline
1366 before a R2L line.
1367
ce316182
GM
13682012-01-11 Glenn Morris <rgm@gnu.org>
1369
1370 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1371 from load-path also when installation-directory is nil. (Bug#10208)
1372
5b43da69
GM
13732012-01-10 Glenn Morris <rgm@gnu.org>
1374
74cc8ff9
GM
1375 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1376
7d8d6e4e
GM
1377 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1378 Update template values to be closer to their typical values these days.
5b43da69 1379
a0db8d43
EZ
13802012-01-09 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (rows_from_pos_range): Accept additional argument
1383 DISP_STRING, and accept any glyph in a row whose object is that
1384 string as eligible for mouse highlight. Fixes mouse highlight of
1385 display strings from overlays. (Bug#10464)
1386
9a0115ab 13872012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1388
b9110d6a 1389 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1390 * fileio.c (auto_saving_dir_umask): New static var.
1391 (Fmake_directory_internal): Use it.
1392 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1393 creating the directory. The old code temporarily assigns
1394 too-generous permissions to the directory.
1395 (do_auto_save_eh): Clear it.
b9110d6a 1396 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1397 that the var is always cleared.
1398
6c1bd3f3
EZ
13992012-01-07 Eli Zaretskii <eliz@gnu.org>
1400
1401 * search.c (scan_buffer): Pass character positions to
1402 know_region_cache, not byte positions. (Bug#6540)
1403
069d2b50
L
14042012-01-07 LynX <_LynX@bk.ru> (tiny change)
1405
1406 * w32.c (sys_rename): Report EXDEV when rename of a directory
1407 fails because the target is on another logical disk. (Bug#10284)
1408
75bf0d33
DB
14092012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1410
1411 * xterm.c (x_embed_request_focus): New function.
1412
1413 * xterm.h: Add prototype.
1414
1415 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1416
1c6e5a32
GM
14172012-01-05 Glenn Morris <rgm@gnu.org>
1418
1419 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1420
651e947e
EZ
14212012-01-01 Eli Zaretskii <eliz@gnu.org>
1422
1423 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1424 Load gnutls_transport_set_lowat only if GnuTLS version is below
1425 2.11.1.
1426 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1427 GnuTLS versions below 2.11.1.
1428
3778cdd8
AL
14292011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1430
1431 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1432 to the doc string advising against its use for altering the way
1433 windows are scrolled.
1434
0e5317f7
KH
14352011-12-28 Kenichi Handa <handa@m17n.org>
1436
1437 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1438 coding-system ASCII compatible only when it does not produce BOM
1439 on encoding (Bug#10383).
1440
93d5ca1f
JD
14412011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1442
1443 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1444 can scroll.
1445 (create_and_show_popup_menu): Always use menu_position_func for
1446 Gtk3 (Bug#10361).
1447
ca22b785
AS
14482011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1449
1450 * callint.c (Fcall_interactively): Don't truncate prompt string.
1451
d048e1e6
EZ
14522011-12-23 Eli Zaretskii <eliz@gnu.org>
1453
1454 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1455 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1456 resumed from there (after widening). (Bug#10360)
d048e1e6 1457
5ccaba1f
JD
14582011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1459
1460 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1461
204ee57f
JD
14622011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1463
b81d40f0
JB
1464 * nsterm.m (x_free_frame_resources):
1465 Release f->output_data.ns->miniimage.
204ee57f
JD
1466 (ns_index_color): Fix indentation. Do not retain
1467 color_table->colors[i].
1468
1469 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1470 before returning.
1471
1472 * nsfns.m (x_set_background_color): Assign return value from
1473 ns_index_color to face-background instead of NSColor*.
1474 (ns_implicitly_set_icon_type): Fix indentation.
1475 Change assignment in for loop to comparison.
1476
1477 * emacs.c (ns_pool): New variable.
1478 (main): Assign ns_pool.
1479 (Fkill_emacs): Call ns_release_autorelease_pool.
1480
1481 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1482 autorelease fdesc, release fdAttrs and tdict.
1483 (ns_get_covering_families): Release charset.
1484 (ns_findfonts): Release NSFontDescriptor created with new.
1485 (ns_uni_to_glyphs): Fix indentation.
1486 (setString): Release attrStr before assigning new value.
1487
c803b2b7
JD
14882011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1489
678f4426
JD
1490 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1491 and NS_IMPL_COCOA.
1492 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1493 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1494
cd394be1 14952011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1496
5fecd5fc
JD
1497 * nsterm.m (ns_term_init): Subscribe for notifications
1498 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1499 to method trackingNotification in EmacsMenu.
1500
1501 * nsmenu.m (trackingMenu): New variable.
3771cb17 1502 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1503 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1504 from Aquamacs (Bug#7030).
678f4426
JD
1505
15062011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1507
c803b2b7
JD
1508 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1509 (symbol_to_nsstring): Fix indentation.
1510 (ns_symbol_to_pb): New function.
cae07000
SM
1511 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1512 (Fns_rotate_cut_buffers_internal): Remove.
1513 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1514 Fns_store_cut_buffer_internal.
1515 (ns_get_foreign_selection, Fx_own_selection_internal)
1516 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1517 (Fns_get_selection_internal, Fns_store_selection_internal):
1518 Use ns_symbol_to_pb and check if return value is nil.
1519 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1520 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1521 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1522 renamed to Sns_store_selection_internal.
1523 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1524 and remove this function.
1525 (ns_handle_selection_clear): Remove, never used.
1526 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1527 here.
1528
e1b01a3a
KB
15292011-12-17 Ken Brown <kbrown@cornell.edu>
1530
1531 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1532 GID is unknown (Bug#10257).
1533
2adb6e85
PE
15342011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1537 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1538 which caused a build failure on GNU/Linux IA-64. This problem was
1539 introduced by my 2011-10-07 patch.
1540
d1d7b339
JL
15412011-12-15 Juri Linkov <juri@jurta.org>
1542
1543 * image.c (imagemagick_error): New function. (Bug#10112)
1544 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1545 Use `imagemagick_error' where ImageMagick functions return
1546 `MagickFalse'.
1547 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1548 proper order.
1549
100d5755
KH
15502011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1551
1552 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1553 fill background (Bug#8992).
1554
454592a6
MR
15552011-12-13 Martin Rudalics <rudalics@gmx.at>
1556
1557 * window.c (Vwindow_combination_resize)
1558 (Vwindow_combination_limit): Use t instead of non-nil in
1559 doc-strings.
61d4b438
MR
1560 (Vrecenter_redisplay): Add first sentence of doc-string on
1561 separate line.
53524d93 1562 (Frecenter): Fix doc-string typo.
454592a6 1563
3633e3aa
KH
15642011-12-11 Kenichi Handa <handa@m17n.org>
1565
1566 * coding.c (Funencodable_char_position): Pay attention to the
1567 buffer text relocation (Bug#9389).
1568
7b9d523a
JD
15692011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1570
1571 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1572 gtk_init (Bug#10100).
1573
b73189c6
EZ
15742011-12-10 Eli Zaretskii <eliz@gnu.org>
1575
1576 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1577 IT->string is nil. (Bug#10263)
1578
f7dfe5d6
JD
15792011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1580
83faebb4
JD
1581 * nsterm.h (x_free_frame_resources): Declare.
1582
f7dfe5d6
JD
1583 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1584 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1585
1586 * nsterm.h (ns_get_defaults_value): Declare.
1587
1588 * nsterm.m (ns_default): Call ns_get_defaults_value.
1589
7cd4e72c
EZ
15902011-12-09 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1593 (Bug#10170)
1594
b34d7317
YM
15952011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1596
1597 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1598 that where the value of an _OBJC_* symbol points to is in the .bss
1599 section (Bug#10240).
1600
76470ad1
KH
16012011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1602
1603 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1604 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1605
745fff94
KH
16062011-12-08 Kenichi Handa <handa@m17n.org>
1607
1608 * ftfont.c (get_adstyle_property): Fix previous change
1609 (Bug#10233).
1610
6e44397c
JB
16112011-12-07 Juanma Barranquero <lekktu@gmail.com>
1612
1613 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1614 dirs from the default value of EMACSLOADPATH (bug#10208).
1615
7efa6272
GM
16162011-12-07 Glenn Morris <rgm@gnu.org>
1617
1618 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1619 installation and source directories as well. (Bug#10208)
1620
f6fc4d87
CY
16212011-12-06 Chong Yidong <cyd@gnu.org>
1622
1623 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1624
2bf26180
GM
16252011-12-06 Glenn Morris <rgm@gnu.org>
1626
1627 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1628 as an error, not just -1. (Bug#10217)
1629
3a6ad4f0
CY
16302011-12-05 Chong Yidong <cyd@gnu.org>
1631
1632 * keyboard.c (process_special_events): New function.
1633 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1634
75a3b399
PE
16352011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * coding.c (encode_designation_at_bol): Don't use uninitialized
1638 local variable (Bug#9318).
1639
c3c9e25e
KH
16402011-12-05 Kenichi Handa <handa@m17n.org>
1641
1642 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1643 return Qnil (Bug#8046, Bug#10193).
1644
5eb05ea3
KH
16452011-12-05 Kenichi Handa <handa@m17n.org>
1646
1647 * coding.c (encode_designation_at_bol): New args charbuf_end and
1648 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1649 (coding_set_source): Return how many bytes coding->source was
1650 relocated.
1651 (coding_set_destination): Return how many bytes
1652 coding->destination was relocated.
1653 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1654 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1655
16562011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1657
1658 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1659 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1660 macro (Bug#9318).
1661
16622011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1663
1664 The following changes are to fix Bug#9318.
1665
a79703f5 1666 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1667 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1668 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1669 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1670
7dbda6df
JB
16712011-12-05 Juanma Barranquero <lekktu@gmail.com>
1672
1673 * lisp.h (process_quit_flag): Fix external declaration.
1674
6d5eb5b0
SM
16752011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1676
1677 Don't macro-inline non-performance-critical code.
1678 * eval.c (process_quit_flag): New function.
1679 * lisp.h (QUIT): Use it.
1680
a0c3fad0
JD
16812011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1682
1683 * nsfns.m (get_geometry_from_preferences): New function.
1684 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1685
6c07aac2
AS
16862011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1687
1688 * emacs.c (Qkill_emacs): Define.
1689 (syms_of_emacs): Initialize it.
1690 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1691 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1692 (quit_throw_to_read_char): Add parameter `from_signal'.
1693 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1694 * lisp.h (QUIT): Call Fkill_emacs if requested.
1695
c052ead4
JD
16962011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1697
1698 * widget.c (update_wm_hints): Return if wmshell is null.
1699 (widget_update_wm_size_hints): New function.
1700
1701 * widget.h (widget_update_wm_size_hints): Declare.
1702
1703 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1704 widget_update_wm_size_hints (Bug#10104).
1705
9e49252b
EZ
17062011-12-03 Eli Zaretskii <eliz@gnu.org>
1707
1708 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1709 before a newline, prepare the bidi iterator for consuming the
1710 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1711 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1712
02b16839
JL
17132011-12-02 Juri Linkov <juri@jurta.org>
1714
1715 * search.c (Fword_search_regexp): New Lisp function created from
1716 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1717 (Fword_search_backward, Fword_search_forward)
1718 (Fword_search_backward_lax, Fword_search_forward_lax):
1719 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1720 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1721
0068070e
SM
17222011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * fileio.c (Finsert_file_contents): Move after-change-function call
1725 to before the "handled:" label, since all "goto handled" appear in
1726 cases where the *-change-functions have already been properly called
1727 (bug#10117).
1728
3360a3fc
AS
17292011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1730
1731 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1732 waiting for input. (Bug#10169)
1733
73d6c093
EZ
17342011-11-30 Eli Zaretskii <eliz@gnu.org>
1735
1736 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1737 verifies glyph row's hash code--we have just reallocated the
1738 glyphs, so their contents can be complete garbage. (Bug#10164)
1739
febe6bea
JB
17402011-11-30 Juanma Barranquero <lekktu@gmail.com>
1741
1742 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1743
801a4313
EZ
17442011-11-30 Eli Zaretskii <eliz@gnu.org>
1745
1746 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1747 attributes are tested _before_ calling verify_row_hash, to protect
1748 against GCC re-ordering of the tests. (Bug#10164)
1749
2b56b87e
JD
17502011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1751
1752 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1753
1754 * xterm.c (handle_one_xevent): Only set async_visible and friends
1755 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1756 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1757 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1758
dbf31225
PE
17592011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1762 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1763 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1764 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1765 All uses changed to use GCPRO1 etc.
1766 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1767 Revert to old implementation (i.e., before 2011-03-11).
1768
1305621b
YM
17692011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1770
1771 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1772 of scroll runs so as to avoid assigning disabled bogus rows and
1773 unnecessary graphics copy operations.
1774
8c9afb46
EZ
17752011-11-27 Eli Zaretskii <eliz@gnu.org>
1776
1777 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1778 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1779 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1780 (malloc, free, realloc, calloc): Redirect to e_* only when
1781 compiling Emacs.
1782
1783 * lisp.h (GCTYPEBITS): Move before first use.
1784 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1785 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1786 this macro definition.
1787
1788 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1789 _MSC_VER.
1790
54e9e3bf
JD
17912011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1792
6d5eb5b0
SM
1793 * gtkutil.c (xg_create_frame_widgets):
1794 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1795 present with Gtk+ 2.0.
1796
83aca1cb
PE
17972011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 * fileio.c (Finsert_file_contents): Undo previous change; see
1800 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1801
5b76caa4
PE
18022011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 Rename locals to avoid shadowing.
1805 * fileio.c (Finsert_file_contents):
1806 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1807 * process.c (wait_reading_process_output):
1808 Rename inner 'proc' to 'p' to avoid shadowing.
1809 Indent for consistency with usual Emacs style.
1810
8c535114
EZ
18112011-11-25 Eli Zaretskii <eliz@gnu.org>
1812
1813 * xdisp.c (redisplay_window): If cursor row is not fully visible
1814 after recentering, and scroll-conservatively is set to a large
1815 number, scroll window by a few more lines to make the cursor fully
1816 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1817 (start_display): Don't move to the next line if the display should
1818 start at a newline that is part of a display vector or an overlay
1819 string. (Bug#10119)
8c535114 1820
fa4fdb5c
JL
18212011-11-24 Juri Linkov <juri@jurta.org>
1822
1823 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1824 after the `MagickPingImage' call. (Bug#10112)
1825
90ec88df
CY
18262011-11-23 Chong Yidong <cyd@gnu.org>
1827
1828 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1829
56e2e794
MR
18302011-11-23 Martin Rudalics <rudalics@gmx.at>
1831
1832 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1833 making another buffer current. (Bug#10114)
1834
b6e64c41
GM
18352011-11-23 Glenn Morris <rgm@gnu.org>
1836
1837 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1838
6b21de18
CY
18392011-11-23 Chong Yidong <cyd@gnu.org>
1840
1841 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1842 using it (Bug#5984).
1843
b12cd789
EZ
18442011-11-22 Eli Zaretskii <eliz@gnu.org>
1845
1846 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1847 and header-lines, as they don't have one computed for them.
1848 (Bug#10098)
1849
1850 * .gdbinit (prow): Make displayed values more self-explaining.
1851 Add row's hash code.
1852
261b6fd4
LMI
18532011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1854
1855 * process.c (wait_reading_process_output): Fix asynchrounous
1856 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1857 (wait_reading_process_output): Add comment and URL.
261b6fd4 1858
e7cfd277
JD
18592011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1860
1861 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1862
a9b9b7f5
CY
18632011-11-21 Chong Yidong <cyd@gnu.org>
1864
1865 * window.c (Fnext_window, Fprevious_window): Doc fix.
1866
b0d15b4f
SM
18672011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1868
1869 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1870
fe7a3057
JB
18712011-11-20 Juanma Barranquero <lekktu@gmail.com>
1872
1873 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1874
d2999b1a
MR
18752011-11-20 Martin Rudalics <rudalics@gmx.at>
1876
1877 * window.c (Fset_window_combination_limit): Rename argument
1878 STATUS to LIMIT.
1879 (Vwindow_combination_limit): Remove "status" from doc-string.
1880
d5ff9cd0
AS
18812011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1882
1883 * m/ibms390.h: Remove.
1884 * m/ibms390x.h: Don't include "ibms390.h".
1885
a5bb9bd3
SM
18862011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1887
1888 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1889 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1890
cd1181db
JB
18912011-11-20 Juanma Barranquero <lekktu@gmail.com>
1892
1893 * casetab.c (Fset_case_table):
1894 * charset.c (Fcharset_after): Fix typos.
1895
615a3b8d 18962011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1897
17e845af
PE
1898 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1899 Otherwise, valgrind does not work on some platforms.
1900 Problem reported by Andreas Schwab in
6a0bf43d
PE
1901 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1902 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1903 is set, removing the need for VIRT_ADDRESS_VARIES.
1904 (PURE_P): Use a more-efficient implementation that needs just one
1905 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1906 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1907 to 4 (xorl, subq, cmpq, setbe).
1908 * alloc.c (pure): Always extern now, since that's the
1909 VIRT_ADDR_VARIES behavior.
1910 (PURE_POINTER_P): Use a single comparison, not two, for
1911 consistency with the new puresize.h.
1912 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1913 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1914 Remove VIRT_ADDR_VARIES no longer needed.
1915
f8fe6f96
EZ
19162011-11-19 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1919 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1920 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1921 behave as if the cursor position were at the window margin.
1922
1923 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1924 and the cursor position is out of bounds, behave as if the cursor
1925 position were at the window margin. (Bug#10075)
1926
df05a53c
CY
19272011-11-18 Chong Yidong <cyd@gnu.org>
1928
1929 * window.c (Fwindow_combination_limit): Make first argument
1930 non-optional, since it is meaningless for live windows like the
1931 selected window.
1932
2071918e
DA
19332011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1934
1935 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1936
b50a28de
SM
19372011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1938
1939 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1940 (graft_intervals_into_buffer): Simplify.
1941
015137db
EZ
19422011-11-18 Eli Zaretskii <eliz@gnu.org>
1943
1944 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1945 hash values of the two rows.
1946 (copy_row_except_pointers): Preserve the used[] arrays and the
1947 hash values of the two rows. (Bug#10035)
68c95424 1948 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1949
1950 * xdisp.c (row_hash): New function, body extracted from
1951 compute_line_metrics.
1952 (compute_line_metrics): Call row_hash, instead of computing the
1953 hash code inline.
1954
1955 * dispnew.c (verify_row_hash): Call row_hash for computing the
1956 hash code of a row, instead of duplicating code from xdisp.c.
1957
1958 * dispextern.h (row_hash): Add prototype.
1959
a2addb04
TH
19602011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1961
1962 * frame.c (delete_frame): Don't delete the terminal when the last
1963 X frame is closed if emacs is built with GTK toolkit.
1964
df85d315
JB
19652011-11-17 Juanma Barranquero <lekktu@gmail.com>
1966
1967 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1968
a0c2d0ae
MR
19692011-11-17 Martin Rudalics <rudalics@gmx.at>
1970
1971 * window.c (Vwindow_splits): Rename to
1972 Vwindow_combination_resize. Suggested by Juri Linkov.
1973 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1974 of Vwindow_splits.
1975
58179cce
JB
19762011-11-16 Juanma Barranquero <lekktu@gmail.com>
1977
7877f373
JB
1978 * nsfns.m (Fns_font_name):
1979 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1980
b6f67890
MR
19812011-11-16 Martin Rudalics <rudalics@gmx.at>
1982
1983 * window.h (window): Rename slot "nest" to "combination_limit".
1984 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1985 (Fset_window_nest): Rename to Fset_window_combination_limit.
1986 (Vwindow_nest): Rename to Vwindow_combination_limit.
1987 (recombine_windows, make_parent_window, make_window)
1988 (Fsplit_window_internal, saved_window)
1989 (Fset_window_configuration, save_window_save): Rename all
1990 occurrences of window_nest to window_combination_limit.
1991
c7015153
JB
19922011-11-15 Juanma Barranquero <lekktu@gmail.com>
1993
1994 * image.c (imagemagick_load_image): Fix typo.
1995
322ad6ec
EZ
19962011-11-14 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (display_line): Move the call to
1999 highlight_trailing_whitespace before the call to
2000 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
2001 faces of all the glyphs to compute ROW's hash value.
2002 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 2003
f067b8ec
JB
20042011-11-14 Juanma Barranquero <lekktu@gmail.com>
2005
2006 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2007 just return (bug#10044).
2008
1e5b2111
EZ
20092011-11-12 Eli Zaretskii <eliz@gnu.org>
2010
7ef3cbd5
EZ
2011 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2012 with user-defined heap size. Bump the default size of the temacs
2013 heap to 27MB, to avoid memory warning when running temacs.
2014 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2015
1e5b2111
EZ
2016 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2017 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2018 (verify_row_hash) [XASSERTS]: New function.
2019 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2020 that the hash value of glyph rows is correct.
1e5b2111 2021
89d61221
MR
20222011-11-12 Martin Rudalics <rudalics@gmx.at>
2023
2024 * window.h (window): Remove splits slot.
2025 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2026 (Fdelete_other_windows_internal, make_parent_window)
2027 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2028 (Fset_window_configuration, save_window_save): Don't deal with
2029 split status of windows.
2030 (saved_window): Remove splits slot.
2031 (Vwindow_splits): Rewrite doc-string.
2032
97f18cc8
JD
20332011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2034
2035 * xfns.c (unwind_create_frame):
2036 * nsfns.m (unwind_create_frame):
2037 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2038 Vframe_list (Bug#9999).
2039
22a648b4
DA
20402011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2041
0b381c7e 2042 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2043
659afede
KH
20442011-11-11 Kenichi Handa <handa@m17n.org>
2045
2046 * callproc.c (Fcall_process): Set the member dst_multibyte of
2047 process_coding.
2048
9ac0394b
KH
20492011-11-11 Johan Bockgård <bojohan@gnu.org>
2050
2051 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2052 avoid a crash (bug#9496).
2053
2fbdc249
CY
20542011-11-09 Chong Yidong <cyd@gnu.org>
2055
2056 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2057 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2058
ac6b1f81
PE
20592011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2062
09db192c
PE
20632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 Avoid some portability problems by eschewing 'extern inline' functions.
2066 The trivial performance wins aren't worth the portability hassles; see
2067 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2068 et seq.
2069 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2070 (window_box_width, window_box_left, window_box_left_offset)
2071 (window_box_right, window_box_right_offset): Undo previous change,
2072 by removing the "extern"s.
2073 * intervals.c (adjust_intervals_for_insertion)
2074 (adjust_intervals_for_deletion): Undo previous change,
2075 making these static again.
2076 (offset_intervals, temp_set_point_both, temp_set_point)
2077 (copy_intervals_to_string): No longer inline.
2078 * xdisp.c (window_text_bottom_y, window_box_width)
2079 (window_box_height, window_box_left_offset)
2080 (window_box_right_offset, window_box_left, window_box_right)
2081 (window_box): No longer inline.
2082
105216ed
CY
20832011-11-08 Chong Yidong <cyd@gnu.org>
2084
2085 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2086 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2087 Signal an error if not a live window.
105216ed
CY
2088 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2089 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2090
ae9e237f
JB
20912011-11-07 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * lisp.h (syms_of_abbrev): Remove declaration.
2094 Reported by CHENG Gao <chenggao@royau.me>.
2095
c7aa8333
EZ
20962011-11-07 Eli Zaretskii <eliz@gnu.org>
2097
2098 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2099 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2100 of temacs in GUI mode.
2101
be7f5545
MR
21022011-11-07 Martin Rudalics <rudalics@gmx.at>
2103
2104 * window.h: Declare delete_all_child_windows instead of
2105 delete_all_subwindows.
2106 * window.c (Fwindow_nest, Fset_window_nest)
2107 (Fset_window_new_total, Fset_window_new_normal)
2108 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2109 (delete_all_subwindows): Rename to delete_all_child_windows.
2110 (Fdelete_other_windows_internal, Fset_window_configuration):
2111 Call delete_all_child_windows instead of delete_all_subwindows.
2112 * frame.c (delete_frame): Call delete_all_child_windows instead
2113 of delete_all_subwindows.
2114
ca78dc43
PE
21152011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2116
2117 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2118 This is also needed for porting to any host where GC_MARK_STACK is
2119 not GC_MAKE_GCPROS_NOOPS.
2120 (which_symbols): Use it.
2121
a0241d01
KH
21222011-11-07 Kenichi Handa <handa@m17n.org>
2123
2124 * coding.c (coding_set_destination): Check coding->src_pos only
2125 when coding->src_object is a buffer (bug#9910).
2126
2127 * process.c (send_process): Set the member src_multibyte of coding
2128 to 0 (bug#9911) when sending a unibyte text.
2129
2130 * callproc.c (Fcall_process): Set the member src_multibyte of
2131 process_coding to 0 (bug#9912).
2132
a64bfdfa 21332011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2134
2135 * xmenu.c (cleanup_widget_value_tree): New function.
2136 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2137 calling free_menubar_widget_value_tree directly (Bug#9830).
2138
cb41b32a
PE
21392011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 Fix some portability problems with 'inline'.
2142 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2143 (window_box_width, window_box_left, window_box_left_offset)
2144 (window_box_right, window_box_right_offset): Declare extern.
2145 Otherwise, these inline functions do not conform to C99 and
2146 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2147 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2148 * intervals.c (adjust_intervals_for_insertion)
2149 (adjust_intervals_for_deletion): Now extern, because otherwise the
2150 extern inline functions 'offset_intervals' couldn't refer to it.
2151 (static_offset_intervals): Remove.
2152 (offset_intervals): Rewrite using the old contents of
2153 static_offset_intervals. The old version didn't conform to C99
2154 because an extern inline function contained a reference to an
2155 identifier with static linkage.
2156
b7041366
AS
21572011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2158
2159 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2160 GC.
2161
88a37c4d
EZ
21622011-11-06 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2165 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2166 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2167 return Qleft_to_right.
2168
49745b39
CY
21692011-11-06 Chong Yidong <cyd@gnu.org>
2170
2171 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2172 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2173 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2174 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2175 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2176 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2177 (Fwindow_vscroll): Doc fix.
2178 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2179 argument, since it makes no sense to pass a live window and for
2180 consistency with window-child.
2181
1f05cd82
CS
21822011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2183
2184 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2185 support MSVC.
2186
22610910
JR
21872011-11-05 Jason Rumney <jasonr@gnu.org>
2188
2189 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2190 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2191 fonts (Bug#6029).
2192 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2193 bitwise arithmetic preventing use of unicode-sip and non-truetype
2194 opentype fonts.
2195
a06776b2
EZ
21962011-11-05 Eli Zaretskii <eliz@gnu.org>
2197
3ad924ba
EZ
2198 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2199 "emacs"-only part.
2200
a06776b2
EZ
2201 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2202 initialization code to keep similarity to xfns.c after changes
2203 from 2011-11-05.
2204
c9e7db78
JD
22052011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2206
a97f8f3f
JD
2207 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2208 (unwind_create_frame): New function (Bug#9943).
2209 (Fx_create_frame): Restructure code to be more similar to the one in
2210 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2211 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2212 Move terminal->reference_count++ just before making the frame official
2213 (Bug#9943).
2214
2215 * nsterm.m (x_free_frame_resources): New function.
2216 (x_destroy_window): Move code to x_free_frame_resources.
2217
c9e7db78 2218 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2219 (Fx_create_frame, x_create_tip_frame):
2220 Move terminal->reference_count++ just before making the frame
75f1671a 2221 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2222 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2223
a6fc3b5c
EZ
22242011-11-05 Eli Zaretskii <eliz@gnu.org>
2225
2226 Support MSVC build with newer versions of Visual Studio.
2227 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2228 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2229 nt/gmake.defs.
2230
2231 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2232 which are not supported by MSVC.
2233 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2234 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2235 bitfields.
2236 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2237 types in bitfields.
2238 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2239
2240 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2241
58179cce 22422011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2243
2244 Support MSVC build with newer versions of Visual Studio.
2245 * w32.c: Don't include w32api.h for MSVC.
2246 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2247
2248 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2249 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2250 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2251 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2252 e_* cousins.
2253 (alloca) [_MSC_VER]: Define to _alloca.
2254
2255 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2256
2257 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2258
a58c13ed
EZ
22592011-11-04 Eli Zaretskii <eliz@gnu.org>
2260
2261 * xdisp.c (note_mouse_highlight): If either of
2262 previous/next-single-property-change returns nil, treat that as
2263 the beginning or the end of the buffer. (Bug#9955)
2264
fe0b6370
JD
22652011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2266
a58c13ed 2267 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2268 label is not null (Bug#9951).
2269 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2270 may be NULL.
2271
89bd5ee1
EZ
22722011-11-04 Eli Zaretskii <eliz@gnu.org>
2273
2274 * window.c (Fwindow_body_size): Mention in the doc string that the
2275 return value is in frame's canonical units. (Bug#9949)
2276
84c3edb9
EZ
22772011-11-03 Eli Zaretskii <eliz@gnu.org>
2278
4e2fb5c7
EZ
2279 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2280
84c3edb9 2281 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2282 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2283 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2284
bc17a887
EZ
22852011-11-01 Eli Zaretskii <eliz@gnu.org>
2286
2287 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2288 Don't stop backward scan on the continuation glyph, even though
2289 its CHARPOS is positive.
6d5eb5b0
SM
2290 (mouse_face_from_buffer_pos, note_mouse_highlight):
2291 Rename cover_string to disp_string.
bc17a887 2292
4ee88440
MR
22932011-11-01 Martin Rudalics <rudalics@gmx.at>
2294
2295 * window.c (temp_output_buffer_show): Don't use
2296 Vtemp_buffer_show_specifiers.
2297 (Vtemp_buffer_show_specifiers): Remove unused variable.
2298
c2ff3c02
EZ
22992011-10-30 Eli Zaretskii <eliz@gnu.org>
2300
2301 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2302 past the beginning of the current glyph matrix.
2303
58179cce 23042011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2305
2306 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2307 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2308 HAVE_GTK3 (Bug#9869).
b77a6a7f 2309
3b574623
JD
2310 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2311 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2312
b77a6a7f
JD
2313 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2314
2315 * xterm.c: Declare x_handle_net_wm_state to return int.
2316 (handle_one_xevent): Check if we are iconified but don't have
2317 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2318 (get_current_wm_state): Return non-zero if not hidden,
2319 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2320 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2321 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2322 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2323
196e41e4
PE
23242011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2325
2326 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2327 so that this new function doesn't get optimized away by a
2328 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2329
021f2e1a
AS
23302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2331
2332 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2333
8b058d44
EZ
23342011-10-29 Eli Zaretskii <eliz@gnu.org>
2335
2336 Fix the `xbytecode' command.
2337 * .gdbinit (xprintbytestr): New command.
b50a28de 2338 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2339 (xbytecode): Print the byte-code string as well.
2340
4452fb80
EZ
23412011-10-29 Kim Storm <storm@cua.dk>
2342
8b058d44
EZ
2343 * alloc.c (which_symbols): New function.
2344
21b72067
AS
23452011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2346
2347 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2348 line. (Bug#9903)
2349
83ed7b5c
GM
23502011-10-29 Glenn Morris <rgm@gnu.org>
2351
2352 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2353 Not clear what it was for, and it causes various bugs. (Bug#9839)
2354
5a7a728b
EZ
23552011-10-28 Eli Zaretskii <eliz@gnu.org>
2356
2357 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2358 possible random value that matches one of those tested as
2359 condition to clear the mouse face.
2360
d3d0842f
CY
23612011-10-28 Chong Yidong <cyd@gnu.org>
2362
2363 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2364
31b39d13
DN
23652011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2366
2367 * window.c (make_window): Initialize phys_cursor_on_p.
2368
9aba6043
SM
23692011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2370
2371 * lisp.h (struct Lisp_Symbol): Update comments.
2372
c20992f4
JB
23732011-10-28 Juanma Barranquero <lekktu@gmail.com>
2374
2375 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2376
db4f02f2
EZ
23772011-10-28 Eli Zaretskii <eliz@gnu.org>
2378
2379 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2380 <oslsachem@gmail.com> for helping to debug this.
2381
2382 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2383 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2384 (g_b_init_get_glyph_outline_w): New static variables.
2385 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2386 (GetGlyphOutlineW_Proc): New typedefs.
2387 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2388 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2389 New functions.
2390 (w32font_open_internal, compute_metrics):
2391 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2392 instead of calling the "wide" APIs directly.
2393
2394 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2395
2396 * w32.h (syms_of_w32font): Add prototype.
2397
87e68db4
JB
23982011-10-27 Juanma Barranquero <lekktu@gmail.com>
2399
2400 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2401 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2402 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2403 (Fmove_to_window_line): Doc fix.
2404
435c1d67
CY
24052011-10-27 Chong Yidong <cyd@gnu.org>
2406
2407 * process.c (make_process): Set gnutls_state to NULL.
2408
2409 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2410 non-NULL, regardless of GNUTLS_INITSTAGE.
2411 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2412 an error. Set process slots as soon as we allocate them.
2413
2414 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2415
9c6c6f49
CY
24162011-10-27 Chong Yidong <cyd@gnu.org>
2417
9aba6043
SM
2418 * gnutls.c (emacs_gnutls_deinit): New function.
2419 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2420 (Fgnutls_deinit, Fgnutls_boot): Use it.
2421
2422 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2423 (deactivate_process): Call emacs_gnutls_deinit.
2424
657d08d3
JB
24252011-10-27 Juanma Barranquero <lekktu@gmail.com>
2426
2427 * image.c (x_create_x_image_and_pixmap):
2428 * w32.c (sys_rename, w32_delayed_load):
2429 * w32font.c (fill_in_logfont):
2430 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2431
5430d399
JB
24322011-10-26 Juanma Barranquero <lekktu@gmail.com>
2433
2434 * w32fns.c (w32_default_color_map): New function,
2435 extracted from Fw32_default_color_map.
a7ef684b 2436 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2437
fe0055fa
PE
24382011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2441
e6346438
SM
24422011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2443
2444 * keyboard.c (test_undefined): New function (bug#9751).
2445 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2446
e112cc37
ET
24472011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2448
2449 * sysdep.c (init_sys_modes): Fix the check for the controlling
2450 terminal (Bug#6649).
2451
7b5d6677
EZ
24522011-10-20 Eli Zaretskii <eliz@gnu.org>
2453
2454 * dispextern.h (struct bidi_it): New member next_en_type.
2455
2456 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2457 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2458 current character, check also for next_en_type being WEAK_EN.
2459 (bidi_resolve_weak): Don't enter the expensive loop if the current
2460 position is before next_en_pos. Record the bidi type of the first
2461 non-ET, non-BN character we find, in addition to its position.
2462 (bidi_level_of_next_char): Invalidate next_en_type when
2463 next_en_pos is over-stepped.
2464
7da0b018
PE
24652011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2468 * editfns.c: Rewrite current-time-zone so that it invokes
2469 the equivalent of (format-time-string "%Z") to get the time zone name.
2470 This fixes a bug when the time zone name contains characters that
2471 need converting from the system time locale to Emacs internal format.
2472 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2473 that patch fixed format-time-string to do the conversion, but
2474 I forgot to fix current-time-zone.
2475 (format_time_string): New function, containing most of
2476 what Fformat_time_string used to contain.
2477 (Fformat_time_string): Rewrite in terms of format_time_string.
2478 This doesn't change this function's behavior.
2479 (current-time-zone): Rewrite to use format_time_string.
2480 This fixes the bug reported by Michael Schierl in
2481 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2482 Jason Rumney's 2007-06-07 change worked around this bug, but
2483 didn't fix it.
2484 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2485
8547b010
EZ
24862011-10-19 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (start_display): If the character at POS is displayed
2489 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2490 (try_window_reusing_current_matrix): If a line ends in a display
2491 vector or the next line starts in a display vector, continue
2492 redrawing the window even though the character position of
2493 start_row was reached.
8547b010
EZ
2494 (Bug#9771, part 2)
2495
4e948d15
CY
24962011-10-18 Chong Yidong <cyd@gnu.org>
2497
2498 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2499 with nobreak-char-display too.
2500
4787455f
EZ
25012011-10-18 Eli Zaretskii <eliz@gnu.org>
2502
2503 Fix part 3 of bug#9771.
2504 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2505 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2506 non-neutral characters if the current character is a paragraph
2507 separator (a.k.a. Newline). This avoids running the same
2508 expensive loop twice, once when we consume the preceding newline
2509 and the other time when the line actually needs to be displayed.
2510 Avoid the loop when we see neutrals on the base embedding level
2511 following a character whose directionality is the same as the
2512 paragraph's. This avoids running the expensive loop when a line
2513 ends in a long sequence of neutrals, like control characters.
2514 Add assertion against STRONG_AL type. Slightly rearrange code
2515 that determines the type of a neutral given the first non-neutral
2516 that follows it.
2517 (bidi_level_of_next_char): Set next_en_pos to zero when
2518 invalidating its info.
2519
2c91f553
EZ
25202011-10-17 Eli Zaretskii <eliz@gnu.org>
2521
2522 * xdisp.c (push_display_prop): Determine whether to record string
2523 or buffer position by IT->string, not by IT->method. Allow
2524 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2525 (move_it_vertically_backward): Don't look for character position
2526 immediately after the newline when in a continuation line.
2527 (Bug#9771, part 1)
2c91f553 2528
c7b08b0d
MR
25292011-10-15 Martin Rudalics <rudalics@gmx.at>
2530
2531 * window.c (coordinates_in_window): Rewrite and delabelize
2532 vertical border check. (Bug#5357) (Bug#9618)
2533
6b02f655
SM
25342011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2535
2536 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2537 errors in XSetWindowBorder (bug#9310).
2538
81d40c92
DA
25392011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2540
2541 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2542 avoid crash when xmalloc overrun checking is enabled.
2543
d4172c3b
EZ
25442011-10-13 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2547 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2548 cursor motion with <left> and <right> arrow keys.
2549
2550 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2551 some callers set that themselves.
2552
b00eea75
EZ
25532011-10-12 Eli Zaretskii <eliz@gnu.org>
2554
2555 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2556 display string and the previous row comes from the same string and
2557 is empty. (Bug#9739) (Bug#9738)
2558
8fe012c4
SM
25592011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2560
2561 * doc.c (get_doc_string): Encode file name (bug#9735).
2562
0074aef2
EZ
25632011-10-12 Eli Zaretskii <eliz@gnu.org>
2564
79beb178
EZ
2565 * bidi.c (bidi_level_of_next_char):
2566 * xdisp.c (get_visually_first_element): Remove old incorrect
2567 comments regarding the Unicode Line Separator character.
2568
0074aef2
EZ
2569 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2570
6e4b3fbe
DA
25712011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2572
2573 * alloc.c (Fgc_status): Do not access beyond zombies array
2574 boundary if nzombies > MAX_ZOMBIES.
2575 * alloc.c (dump_zombies): Add missing format specifier.
2576
0324f3af
PE
25772011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2578
b5525cac
PE
2579 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2580 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2581
0324f3af
PE
2582 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2583 Some packages use them to denote characters with modifiers.
2584
e9b5f888
AS
25852011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2586
2587 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2588 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2589 matching a pp-number. Rename parameter var to var1.
2590
127827c0
SM
25912011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2592
2593 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2594
c8fd3bd0
GM
25952011-10-08 Glenn Morris <rgm@gnu.org>
2596
2597 * callint.c (Fcall_interactively): Give a more explicit error for the
2598 'c' case with a non-character input. (Bug#8479)
2599
352ec8ff
EZ
26002011-10-08 Eli Zaretskii <eliz@gnu.org>
2601
03669ccb
EZ
2602 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2603 lines.
7061c986
EZ
2604 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2605 lines that are hscrolled on the left.
03669ccb 2606
352ec8ff
EZ
2607 * dispnew.c (buffer_posn_from_coords): Account for a possible
2608 presence of header-line. (Bug#4426)
2609
a66cfb1c
SM
26102011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2611
6b02f655
SM
2612 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2613 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2614
7c5ee88e
PE
26152011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2618 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2619 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2620 this makes Emacs dump core during garbage collection on rare
2621 occasions. sizeof is obviously inferior to offsetof here, so
2622 stick with offsetof.
2623 (GC_POINTER_ALIGNMENT): New macro.
2624 (mark_memory): Omit 3rd (offset) arg; caller changed.
2625 Don't assume EMACS_INT alignment is the same as pointer alignment.
2626
df1bbe5b
SM
26272011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2628
2629 * keyboard.c (read_key_sequence_remapped): New var.
2630 (read_key_sequence): Compute remapping in the right buffer.
2631 (command_loop_1): Use read_key_sequence's remapping directly.
2632
51553db6
SM
26332011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2634
32c1fffd
SM
2635 * dired.c (file_name_completion): Don't expand file name.
2636 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2637 before checking file name handler.
2638
51553db6
SM
2639 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2640 they've been requested explicitly (bug#9591).
2641
b6bd1599 26422011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2643
2644 * keymap.c (Fsingle_key_description): Use make_specified_string
2645 instead of build_string to build string from push_key_description.
2646 (Bug#5193)
2647
f701dc2a
PE
26482011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2649
4222c55d
PE
2650 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2651 This fixes a Y2038 bug on 64-bit hosts.
2652 * buffer.c (reset_buffer):
2653 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2654 (Fclear_buffer_auto_save_failure):
2655 Use 0, not -1, to represent an unset failure time, since time_t
2656 might not be signed.
2657
f701dc2a
PE
2658 Remove dependency on glibc malloc internals.
2659 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2660 Move back here from lisp.h, but with their new implementations.
2661 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2662 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2663 * charset.c (charset_table_init): New static var.
2664 (syms_of_charset): Use it instead of xmalloc. This removes a
2665 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2666 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2667 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2668 Move back to alloc.c.
2669 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2670 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2671
9ceebf39
JD
26722011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2673
2674 * nsterm.m (windowDidResize): Call x_set_window_size only when
2675 ns_in_resize is true. Otherwise set pixelwidth/height and
2676 call change_frame_size (Bug#9628).
2677
cb993c58
PE
26782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2679
3930c88b
PE
2680 Port --enable-checking=all to Fedora 14 x86-64.
2681 * charset.c (syms_of_charset): Also account for glibc malloc's
2682 internal overhead when calculating the initial malloc maximum.
2683
cb993c58
PE
2684 Port --enable-checking=all to Fedora 14 x86.
2685 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2686 Move to lisp.h.
2687 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2688 (overrun_check_realloc, overrun_check_free):
2689 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2690 That way, xmalloc returns a properly-aligned pointer even if
2691 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2692 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2693 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2694 into account when calculating the initial malloc maximum.
2695 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2696 Move here from alloc.c, so that charset.c can use it too.
2697 Properly align; the old code wasn't right for common 32-bit hosts
2698 when configured with --enable-checking=all.
2699 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2700 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2701
31bed486
EZ
27022011-09-29 Eli Zaretskii <eliz@gnu.org>
2703
04c70788 2704 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2705 use EDOM.
2706
fbcaa2f3
EZ
27072011-09-28 Eli Zaretskii <eliz@gnu.org>
2708
2709 * xdisp.c (compute_display_string_end): If there's no display
2710 string at CHARPOS, return -1.
2711
2712 * bidi.c (bidi_fetch_char): When compute_display_string_end
2713 returns a negative value, treat the character as a normal
2714 character not covered by a display string. (Bug#9624)
2715
a239d4e9
JB
27162011-09-28 Juanma Barranquero <lekktu@gmail.com>
2717
2718 * lread.c (Fread_from_string): Fix typo in docstring.
2719
88652fd5
EZ
27202011-09-27 Eli Zaretskii <eliz@gnu.org>
2721
2722 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2723 newline, reseat the iterator instead of bidi-iterating there one
2724 character at a time. (Bug#9610)
32c1fffd
SM
2725 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2726 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2727
ed497dd4
AS
27282011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2729
2730 * lread.c (readevalloop): Use correct code for NBSP.
2731 (read1): Likewise. (Bug#9608)
2732
b2bf61aa
MA
27332011-09-25 Michael Albinus <michael.albinus@gmx.de>
2734
2735 * dbusbind.c (Fdbus_register_signal): When service is not
2736 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2737
32bbb17c
GM
27382011-09-25 Glenn Morris <rgm@gnu.org>
2739
2740 * buffer.c (truncate-lines): Doc fix.
2741
94e0933e
CY
27422011-09-24 Chong Yidong <cyd@stupidchicken.com>
2743
2744 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2745 (Fset_window_next_buffers): Doc fix.
2746
cddde921
GM
27472011-09-24 Glenn Morris <rgm@gnu.org>
2748
2749 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2750
1260aef1
PE
27512011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2752
25b4bfa0
PE
2753 Fix minor problems found by static checking.
2754 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2755 * indent.c (Fvertical_motion): Fix == vs = typo.
2756
e3cbd34b
EZ
27572011-09-24 Eli Zaretskii <eliz@gnu.org>
2758
a66cfb1c
SM
2759 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2760 Default value is now t. Doc fix.
6bf7006f 2761
e3cbd34b 2762 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2763 logic when moving up, not only when moving down. Fix the
e3cbd34b 2764 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2765 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2766
2767 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2768 CHARPOS is covered by a display string which includes newlines.
2769 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2770 is covered by a display string with embedded newlines.
2771
a3de0cbd
MA
27722011-09-24 Michael Albinus <michael.albinus@gmx.de>
2773
2774 * dbusbind.c (Fdbus_register_signal): Add match rule to
2775 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2776 (Fdbus_register_method, Vdbus_registered_objects_table):
2777 Fix docstring.
a3de0cbd 2778
b260039d
JM
27792011-09-24 Jim Meyering <meyering@redhat.com>
2780
32c1fffd 2781 do not ignore write error for any output size
b260039d
JM
2782 The previous change was incomplete.
2783 While it makes emacs --batch detect the vast majority of stdout
2784 write failures, errors were still ignored whenever the output size is
2785 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2786 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2787 && echo FAIL: ignored write error
2788 FAIL: ignored write error
2789 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2790 && echo FAIL: ignored write error
2791 FAIL: ignored write error
2792 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2793
8eca8a7c
AS
27942011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2795
2796 * emacs.c (Fkill_emacs): In noninteractive mode exit
2797 non-successfully if a write error occurred on stdout. (Bug#9574)
2798
3341db62
EZ
27992011-09-21 Eli Zaretskii <eliz@gnu.org>
2800
2801 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2802 the xassert test.
2803
2804 * dispextern.h (struct it): Update the comment documenting what
2805 can it->OBJECT be.
2806
8c203dbf
EZ
28072011-09-20 Eli Zaretskii <eliz@gnu.org>
2808
2809 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2810 a display string, extend search for cursor position to end of row.
2811 (find_row_edges): If the row ends in a newline from a display
2812 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2813 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2814 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2815 non-empty line. Fixes confusing cursor motion with arrow keys at
2816 the beginning of a line that starts with whitespace.
8c203dbf 2817
a4824228
LMI
28182011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2819
2820 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2821 (bug#9493).
2822
33ed493b
CY
28232011-09-18 Chong Yidong <cyd@stupidchicken.com>
2824
2825 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2826 boolean (Bug#9154).
2827
56cd55c8
EZ
28282011-09-18 Eli Zaretskii <eliz@gnu.org>
2829
2830 * xdisp.c (display_line): Record maximum and minimum buffer
2831 positions even if no glyphs were produced (e.g., by a zero-width
2832 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2833 buffer positions that will be removed from the glyph row because
2834 they don't fit.
c02dcedf
EZ
2835 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2836 column is beyond frame width: don't subtract 1 "pixel" when
2837 computing width of the stretch.
3e62b7e0
EZ
2838 (reseat_at_next_visible_line_start): Undo the change made on
2839 2011-09-17 that saved paragraph information and restored it after
2840 the call to `reseat'. (Bug#9545)
56cd55c8 2841
5ed99d36 28422011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2843
2844 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2845 and turn window cursor on if cleared (Bug#9415).
2846
5ed99d36 28472011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2848
2849 * search.c (boyer_moore): Take unibyte characters from pattern
2850 literally. (Bug#9458)
2851
9bade7b2
EZ
28522011-09-18 Eli Zaretskii <eliz@gnu.org>
2853
2854 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2855
e5e9d610
PE
28562011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2857
87e4427a
PE
2858 Fix minor problem found by static checking.
2859 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2860 initialized, to pacify gcc -Wuninitialized.
2861
e5e9d610
PE
2862 * fileio.c: Report proper errno when syscall falls.
2863 (Finsert_file_contents): Save and restore errno,
2864 so that report_file_error outputs the correct diagnostic.
2865 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2866
a1674f0b
EZ
28672011-09-18 Eli Zaretskii <eliz@gnu.org>
2868
2869 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2870
fbfb6dd4
EZ
28712011-09-17 Eli Zaretskii <eliz@gnu.org>
2872
2873 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2874 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2875
bb187662
EZ
28762011-09-17 Eli Zaretskii <eliz@gnu.org>
2877
1137e8b8 2878 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2879 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2880
2881 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2882 (bidi_find_paragraph_start): Search back for paragraph beginning
2883 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2884 (bidi_move_to_visually_next): Only trigger paragraph-related
2885 computations when the last character is a newline or at EOB, not
2886 just any NEUTRAL_B. (Bug#9470)
2887
bb187662
EZ
2888 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2889 truncated lines if point is covered by a display string. (Bug#9524)
2890
2e621251
PE
28912011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2892
2893 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2894 (cons_to_x_long): New function.
2895 (lisp_data_to_selection_data): Use it. Correct the test for
2896 short-versus-long data; it was negated. Break out of vector
2897 loop, for efficiency, when a long datum is discovered.
2898
91a15bc6
SM
28992011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2900
2901 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2902
b41c3a35
EZ
29032011-09-16 Eli Zaretskii <eliz@gnu.org>
2904
2905 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2906 GCC PR/17406) by declaring this function with external scope.
2907
7812ba2d
PE
29082011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2909
2910 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2911 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2912
cf7edc2a
AS
29132011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2914
2915 * editfns.c (Fformat): Correctly handle text properties on "%%".
2916
bd01620e
EZ
29172011-09-15 Eli Zaretskii <eliz@gnu.org>
2918
2919 * xterm.c (x_draw_composite_glyph_string_foreground):
2920 * w32term.c (x_draw_composite_glyph_string_foreground):
2921 * term.c (encode_terminal_code):
2922 * composite.c (composition_update_it, get_composition_id):
2923 * xdisp.c (get_next_display_element)
2924 (fill_composite_glyph_string): Add comments about special meaning
2925 of TAB characters in a composition.
2926
a02719a3
PE
29272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2928
2929 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2930 This occurs when processing a multibyte format.
2931 Problem reported by Wolfgang Jenker.
a02719a3 2932
72589a3c
JB
29332011-09-15 Johan Bockgård <bojohan@gnu.org>
2934
2935 * xdisp.c (try_cursor_movement): Only check for exact match if
2936 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2937
1c14176c
PE
29382011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2939
2940 Remove unused external symbols.
2941 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2942 * xdisp.c (calc_pixel_width_or_height): Now static.
2943 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2944 * indent.c (check_display_width):
2945 * w32term.c: Fix comment to match code.
2946 * xterm.c, xterm.h (x_catching_errors): Remove.
2947
d2eea5b5
PE
29482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * xselect.c: Use signed conversions more consistently (Bug#9498).
2951 (selection_data_to_lisp_data): Assume incoming selection data are
2952 signed integers, not unsigned. This is to be consistent with
2953 outgoing selection data, which was modified to use signed integers
2954 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2955 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2956 expects long, not unsigned long.
2957
46888499
EZ
29582011-09-14 Eli Zaretskii <eliz@gnu.org>
2959
2960 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2961 computation of loop end. Reported by Johan Bockgård
2962 <bojohan@gnu.org>.
2963
ef8ef9fb
CY
29642011-09-13 Chong Yidong <cyd@stupidchicken.com>
2965
2966 * frame.c (Fother_visible_frames_p): Function deleted.
2967
fa819fed
EZ
29682011-09-12 Eli Zaretskii <eliz@gnu.org>
2969
2970 * indent.c (compute_motion): Process display vector front to back
2971 rather than the other way around. (Bug#2496)
2972
2ba8e008
SM
29732011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2974
2975 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2976
20f53c69
CY
29772011-09-11 Chong Yidong <cyd@stupidchicken.com>
2978
2979 * minibuf.c (Fread_from_minibuffer): Doc fix.
2980
d562d7a4
EZ
29812011-09-11 Eli Zaretskii <eliz@gnu.org>
2982
2983 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2984 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2985
1c4d7f3d
LMI
29862011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2987
2988 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2989 value for non-existent files.
2990
b885bf36
EZ
29912011-09-11 Eli Zaretskii <eliz@gnu.org>
2992
2993 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2994 set its "size" to -1. This will set the modtime_size field of
2995 the corresponding buffer to -1, which is what
2996 verify-visited-file-modtime expects for files that do not exist.
2997 (Bug#9139)
2998
6612f0bf
PE
29992011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3002 here ...
3003 * lisp.h: ... from here. push_key_description is no longer
3004 defined in keyboard.c, so its declaration should not be in
3005 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3006 logically belongs with push_key_description.
3007
dfb3f755
PE
30082011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3009
3010 * buffer.h: Include <sys/types.h> instead of <time.h>.
3011 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3012 Problem reported by Herbert J. Skuhra.
3013
3134906c
LMI
30142011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3015
3016 * xml.c (parse_region): Make the parsing work for
3017 non-comment-starting XML files again (bug#9144).
3018
8d903f4e
AS
30192011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3020
3021 * image.c (gif_load): Fix calculation of bottom and right corner.
3022 (Bug#9468)
3023
80ad64f4
EZ
30242011-09-10 Eli Zaretskii <eliz@gnu.org>
3025
3026 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3027 redisplay in small windows.
3028
208a048d
EZ
30292011-09-09 Eli Zaretskii <eliz@gnu.org>
3030
3031 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3032
9b1c252e
MR
30332011-09-08 Martin Rudalics <rudalics@gmx.at>
3034
3035 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3036 Operate on live windows only.
3037
2949f33b
JB
30382011-09-08 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3041
e08dcafd
EZ
30422011-09-07 Eli Zaretskii <eliz@gnu.org>
3043
3044 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3045 only under bidi iteration.
3046
115b96bd
JD
30472011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3048
3049 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3050
c8199d0f
PE
30512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3052
3053 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3054 Without this fix, the command to link temacs failed due to an
3055 undefined symbol __builtin_isnan. This is because
3056 /usr/include/iso/math_c99.h #defines isnan(x) to
3057 __builtin_isnan(x), but the bundled gcc, which identifies itself
3058 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3059 a __builtin_isnan.
3060 * floatfns.c (isnan): #undef, and then #define to a clone of
3061 what's in data.c.
3062 (Fisnan): Always define, since it's always available now.
3063 (syms_of_floatfns): Always define isnan at the Lisp level.
3064
e39b275c 30652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3066
3067 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3068
b2db44d9 30692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3070
f4af5137 3071 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3072 The previous code assumed that file offsets (off_t values) fit in
3073 EMACS_INT variables, which is not true on typical 32-bit hosts.
3074 The code messed up by falsely reporting buffer overflow in cases
3075 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3076 when "big" contains more than 2**29 bytes, even though this
3077 inserts just one byte and does not overflow the buffer.
3078 (Finsert_file_contents): Store file offsets as off_t
3079 values, not as EMACS_INT values. Check for overflow when
3080 converting between EMACS_INT and off_t. When checking for
3081 buffer overflow or for overlap, take the offsets into account.
3082 Don't use EMACS_INT for small values where int suffices.
3083 When checking for overlap, fix a typo: ZV was used where
3084 ZV_BYTE was intended.
3085 (Fwrite_region): Don't assume off_t fits into 'long'.
3086 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3087
ecfc0a49
MA
30882011-09-05 Michael Albinus <michael.albinus@gmx.de>
3089
3090 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3091
6511acf2 30922011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3093
0999621a 3094 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3095
3096 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3097 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3098 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3099 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3100 (modify_event_symbol): Do not assume that the length of
3101 name_alist_or_stem is safe to alloca and fits in int.
3102 (Fexecute_extended_command): Likewise for function name and binding.
3103 (Frecursion_depth): Wrap around reliably on integer overflow.
3104 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3105 since some callers pass EMACS_INT values.
3106 (Fsingle_key_description): Don't crash if symbol name contains more
3107 than MAX_ALLOCA bytes.
3108 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3109 (get_minibuffer): Arg is now EMACS_INT, not int.
3110 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3111 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3112 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3113
2be7d702
PE
3114 * dbusbind.c (signature_cat): New function.
3115 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3116 Do not overrun buffer; instead, report string overflow.
3117
9d1df220
PE
3118 * dispnew.c (add_window_display_history): Don't overrun buffer.
3119 Truncate instead; this is OK since it's just a log.
3120
33ef5c64
PE
3121 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3122 even if the time zone offset is outlandishly large.
3123 Don't mishandle offset == INT_MIN.
3124
66c6fdd5
PE
3125 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3126 when creating daemon; the previous buffer-overflow check was incorrect.
3127
d749b01b
PE
3128 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3129 which has the guts of the old verror function.
3130
b5cd1905
PE
3131 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3132 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3133
6e1a67fb
PE
3134 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3135 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3136 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3137 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3138 length of string rather than counting it via multiple sprintfs;
3139 that's simpler and more reliable.
c21721cc
PE
3140 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3141 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3142 sprintf, in case result does not fit in int.
3143
c57b67fc
PE
3144 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3145 (fontset_from_font): Print it.
3146
8a401434
PE
3147 * frame.c (tty_frame_count): Now printmax_t, not int.
3148 (make_terminal_frame, set_term_frame_name): Print it.
3149 (x_report_frame_params): In X, window IDs are unsigned long,
3150 not signed long, so print them as unsigned.
3151 (validate_x_resource_name): Check for implausibly long names,
3152 and don't assume name length fits in 'int'.
3153 (x_get_resource_string): Don't blindly alloca invocation name;
3154 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3155 not fit in int.
3156
6e1a67fb
PE
3157 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3158 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3159 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3160
0df02bf3
PE
3161 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3162 Use esprintf, not sprintf, in case result does not fit in int.
3163
48e30793
PE
3164 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3165 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3166 it as a large positive number.
3167 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3168 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3169
a66ff6d8
PE
3170 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3171 in case result does not fit in int.
3172
aca216ff
PE
3173 * print.c (float_to_string): Detect width overflow more reliably.
3174 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3175 buffer overrun. Don't assume list length fits in 'int'. Treat
3176 print length of 0 as 0, not as infinity; to be consistent with other
3177 uses of print length in this function. Don't overflow print length
3178 index. Don't assume hash table size fits in 'long', or that
3179 vectorlike size fits in 'unsigned long'.
3180
31c286f7
PE
3181 * process.c (make_process): Use printmax_t, not int, to format
3182 process-name gensyms.
3183
55e5faa1
PE
3184 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3185
80f2e268
PE
3186 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3187 to avoid potential buffer overrun.
3188
670741ab
PE
3189 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3190 if X resource line is longer than 512 bytes.
3191
b7163a50
PE
3192 * xfns.c (x_window): Make sprintf buffer a bit bigger
3193 to avoid potential buffer overrun.
3194
ae58ff1f
PE
3195 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3196
c43c8a6a
PE
3197 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3198
3f8236f4
PE
31992011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3200
53e9fe90 3201 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3202 Without these, Emacs silently mishandles large integers sometimes.
3203 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3204 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3205
6511acf2
PE
3206 * xdisp.c (try_window_id): Check Emacs fixnum range before
3207 converting to 'int'.
806add1d 3208
6511acf2 3209 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3210 Check that an Emacs fixnum is in range before assigning it to 'int'.
3211 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3212 values converted from Emacs fixnums.
3213 (Frecenter): Don't wrap around a line count if it is out of 'int'
3214 range; instead, treat it as an extreme value.
3215 (Fset_window_configuration, compare_window_configurations):
3216 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3217
6511acf2
PE
3218 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3219 that can exceed INT_MAX. Check that EMACS_INT value is in range
3220 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3221 (match_limit): Don't assume that a fixnum can fit in 'int'.
3222
6511acf2 3223 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3224 exceed INT_MAX.
3225
6511acf2 3226 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3227 (Fvertical_motion): Don't wrap around LINES values that don't fit
3228 in 'int'. Instead, treat them as extreme values. This is good
3229 enough for windows, which can't have more than INT_MAX lines anyway.
3230
fcb901a7
LMI
32312011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3232
0f2f6b6d
LMI
3233 * Require libxml/parser.h to avoid compilation warning.
3234
fcb901a7
LMI
3235 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3236
3237 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3238 since this reportedly can destroy thread storage.
3239
6e20a0d4
CY
32402011-08-30 Chong Yidong <cyd@stupidchicken.com>
3241
3242 * syntax.c (find_defun_start): Update all cache variables if
3243 exiting early (Bug#9401).
3244
148ae00e
EZ
32452011-08-30 Eli Zaretskii <eliz@gnu.org>
3246
f6cfbd8f
EZ
3247 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3248
148ae00e
EZ
3249 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3250 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3251 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3252
3253 * term.c (tty_append_glyph): New function.
3254 (produce_stretch_glyph): Static function and its prototype deleted.
3255
a66cfb1c
SM
3256 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3257 Add prototypes.
148ae00e 3258
c4a07a4c
PE
32592011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3260
3261 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3262 when checking :margin (Bug#9390).
3263 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3264 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3265 so that the name doesn't mislead. All uses changed.
3266
6bc8cd65
JB
32672011-08-28 Johan Bockgård <bojohan@gnu.org>
3268
3269 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3270 set_tty_hooks.
3271
dca4927e
EZ
32722011-08-27 Eli Zaretskii <eliz@gnu.org>
3273
3274 * xdisp.c (move_it_to): Don't bail out early when reaching
3275 position beyond to_charpos, if we are scanning backwards.
3276 (move_it_vertically_backward): When DY == 0, make sure we get to
3277 the first character in the line after the newline.
3278
f2cad773
PE
32792011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3282 (ccl_driver): Do not generate an out-of-range pointer.
3283 (Fccl_execute_on_string): Remove unnecessary check for
3284 integer overflow, noted by Stefan Monnier in
3285 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3286 Remove a FIXME that didn't need fixing.
3287 Simplify the newly-introduced buffer reallocation code.
3288
0cae2cdb
JB
32892011-08-27 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3292
5fc295a4 32932011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3294
70c60eb2 3295 Integer and memory overflow issues (Bug#9196).
726e0ab1 3296
d31850da
PE
3297 * doc.c (get_doc_string): Rework so that
3298 get_doc_string_buffer_size is the actual buffer size, rather than
3299 being 1 less than the actual buffer size; this makes xpalloc more
3300 convenient.
3301
a69fbedb
PE
3302 * image.c (x_allocate_bitmap_record, cache_image):
3303 * xselect.c (Fx_register_dnd_atom):
3304 Simplify previous changes by using xpalloc.
3305
fe5c5d37
PE
3306 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3307 since either will do and ptrdiff_t is convenient with xpalloc.
3308
0065d054
PE
3309 * charset.c (charset_table_size)
3310 (struct charset_sort_data.priority): Now ptrdiff_t.
3311 (charset_compare): Don't overflow if priorities differ greatly.
3312 (Fsort_charsets): Don't assume list length fits in int.
3313 Check for size-calculation overflow when allocating sort data.
3314 (syms_of_charset): Allocate an initial charset table that is
3315 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3316
3317 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3318
3319 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3320 The actual value is always <= INT_MAX, and leaving it unsigned made
3321 overflow checking harder.
3322
3323 * dispextern.h (struct glyph_matrix.rows_allocated)
3324 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3325 with xpalloc. The values are still always <= INT_MAX.
3326
3327 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3328
3329 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3330 (SAFE_NALLOCA): New macro.
3331
3332 * region-cache.c (struct boundary.pos, find_cache_boundary)
3333 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3334 (set_cache_region, invalidate_region_cache)
3335 (revalidate_region_cache, know_region_cache, region_cache_forward)
3336 (region_cache_backward, pp_cache):
3337 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3338 so that ptrdiff_t * can be passed to xpalloc.
3339 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3340 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3341 (pp_cache): Don't assume cache_len fits in int.
3342 * region-cache.h: Adjust extern decls to match.
3343
3344 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3345 EMACS_INT, since either will do, for xpalloc.
3346
3347 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3348 (xnmalloc, xnrealloc, xpalloc): New functions.
3349
726e0ab1
PE
3350 * bidi.c (bidi_shelve_header_size): New constant.
3351 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3352 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3353
51f30bc5 3354 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3355 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3356 (overlay_strings):
3357 Don't update size of array until after memory allocation succeeds,
3358 because xmalloc/xrealloc may not return.
0065d054
PE
3359 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3360 now that we have proper integer overflow checking.
3361 (record_overlay_string, overlay_strings): Catch overflows when
3362 calculating size of overlay_str_buf.
726e0ab1 3363
0065d054
PE
3364 * callproc.c (Fcall_process): Check for size overflow when
3365 calculating size of args2.
3366 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3367 Normally we prefer signed values, but sticking with ptrdiff_t would
3368 require adding more-complicated checks.
726e0ab1
PE
3369
3370 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3371 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3372 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3373 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3374
3375 * character.c (Fstring): Check for size-calculation overflow.
3376
3377 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3378 unnecessary integer overflow. Check for size overflow.
3379 (encode_coding_object): Don't update size until xmalloc succeeds.
3380
3381 * composite.c (get_composition_id): Check for overflow in glyph
3382 length calculations.
3383
3384 Integer and memory overflow fixes for display code.
3385 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3386 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3387 (scrolling_window): Check for overflow in size calculations.
3388 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3389 Don't assume glyph table len fits in int.
3390 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3391 (row_table_size): Now ptrdiff_t, not int.
3392 (scrolling_window): Avoid overflow in size calculations.
3393 Don't update size until allocation succeeds.
3394 * fns.c (concat): Check for overflow in size calculations.
3395 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3396 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3397 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3398
3399 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3400 (get_doc_string): Check for size calculation overflow.
3401 Don't update size until allocation succeeds.
3402 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3403 EMACS_INT, where ptrdiff_t will do.
3404 (Fsubstitute_command_keys): Check for string overflow.
3405
3406 * editfns.c (set_time_zone_rule): Don't assume environment length
3407 fits in int.
3408 (message_length): Now ptrdiff_t, not int.
3409 (Fmessage_box): Don't update size until allocation succeeds.
3410 Don't assume message length fits in int.
3411 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3412
0065d054
PE
3413 * emacs.c (main): Do not reallocate argv, since there is a null at
3414 the end that can be overwritten, and this way there's no need to
3415 worry about size-calculation overflow.
3416 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3417
3418 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3419 alloc succeeds.
3420 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3421
3422 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3423 (x_set_scroll_bar_width, x_figure_window_size):
3424 Check for integer overflow.
3425 (x_set_alpha): Do not assume XINT fits in int.
3426
3427 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3428 This is for the members text_lines, text_cols, total_lines, total_cols,
3429 where the system imposes an 'int' limit.
3430
3431 * fringe.c (Fdefine_fringe_bitmap):
3432 Don't update size until alloc works.
3433
3434 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3435 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3436
3437 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3438 Check for size-calculation overflow.
3439 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3440 do, as we prefer signed integers.
3441 (id_to_widget.max_size, id_to_widget.used)
3442 (xg_store_widget_in_map, xg_remove_widget_from_map)
3443 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3444 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3445 Use and return ptrdiff_t, not int.
3446 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3447 * gtkutil.h: Change prototypes to match the above.
3448
3449 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3450 are duplicate now that they've been promoted to lisp.h.
3451 (x_allocate_bitmap_record, x_alloc_image_color)
3452 (make_image_cache, cache_image, xpm_load):
3453 Don't update size until alloc is done.
3454 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3455 (x_detect_edges):
3256efce 3456 Check for size calculation overflow.
726e0ab1
PE
3457 (ct_colors_allocated_max): New constant.
3458 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3459 overflow.
3256efce 3460
726e0ab1
PE
3461 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3462 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3463 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3464 Use ptrdiff_t, not int, to count maps.
3465 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3466 calculations. Don't update size until allocation succeeds.
3467 Redo calculations to avoid overflow.
726e0ab1
PE
3468 * keyboard.h: Change prototypes to match the above.
3469
3470 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3471 to count maps.
3472 (current_minor_maps): Check for size calculation overflow.
3473 * keymap.h: Change prototypes to match the above.
3474
3475 * lread.c (read1, init_obarray): Don't update size until alloc done.
3476
3477 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3478 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3479
726e0ab1
PE
3480 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3481 Now ptrdiff_t, not int.
3482 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3483 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3484
3485 * process.c (Fnetwork_interface_list): Check for overflow
3486 in size calculation.
3487
3488 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3489
3490 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3491 overflow. Don't bother calling xmalloc when xrealloc will do.
3492
3493 * search.c (Freplace_match): Check for size calculation overflow.
3494 (Fset_match_data): Don't assume list lengths fit in 'int'.
3495
3496 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3497 for command line length. Do not attempt to address one before the
3498 beginning of an array, as that's not portable.
3499
3500 * term.c (max_frame_lines): Remove; unused.
3501 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3502 not int.
3503 (encode_terminal_code, calculate_costs): Check for size
3504 calculation overflow.
3505 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3506 table lengths and related sizes. Don't update size until alloc
3507 done. Redo calculations to avoid overflow.
3508 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3509
3510 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3511 subtracting pointers.
3512 (gobble_line): Check for overflow more carefully. Don't update size
3513 until alloc done.
3514
3515 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3516 Don't update size until alloc done.
3517 Redo size calculations to avoid overflow.
3518 Check for size calculation overflow.
0065d054 3519 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3520
3521 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3522 Use ptrdiff_t, not int, for sizes.
3523 (store_mode_line_noprop_char): Don't update size until alloc done.
3524
0065d054
PE
3525 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3526 Use ptrdiff_t, not int, for sizes.
3527 (Finternal_make_lisp_face, cache_face):
3528 Check for size calculation overflow.
3529 (cache_face): Treat size calculation overflows as if they were
3530 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3531
3532 * xfns.c (x_encode_text, x_set_name_internal)
3533 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3534 sizes, since they can exceed INT_MAX in size. Check for size
3535 calculation overflow.
3536
0065d054
PE
3537 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3538 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3539 Don't update size until alloc done.
3540
0065d054 3541 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3542 as sprintf is limited to int lengths.
1d526e2f 3543
252c5ee1
PE
3544 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3545 (X_LONG_MIN): New macros.
864d7ce7
PE
3546 Use them to make the following changes clearer.
3547 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3548 This change doesn't affect the value now, but it may help remind
3549 future maintainers not to raise the value too much later.
3550 (SELECTION_QUANTUM): Remove, replacing with ...
3551 (selection_quantum): ... new function, which avoids overflow.
3552 All uses changed.
3553 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3554 assumption that selection length fits in 'int'.
3555 (x_reply_selection_request, x_handle_selection_request)
3556 (x_get_window_property, receive_incremental_selection)
3557 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3558 (lisp_data_to_selection_data, clean_local_selection_data):
3559 Use ptrdiff_t, not int, to record length of selection.
3560 (x_reply_selection_request, x_get_window_property)
3561 (receive_incremental_selection, x_property_data_to_lisp):
3562 Redo calculations to avoid overflow.
3563 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3564 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3565 something.
3566 (x_get_window_property, receive_incremental_selection)
3567 (lisp_data_to_selection_data, x_property_data_to_lisp):
3568 Check for size-calculation overflow.
3569 (x_get_window_property, receive_incremental_selection)
3570 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3571 Don't store size until memory allocation succeeds.
3572 (x_get_window_property): Plug memory leak on memory exhaustion.
3573 Don't double-block input; malloc is safe here. Don't assume 2**34
3574 - 4 fits in unsigned long. Add an xassert to check
3575 XGetWindowProperty overflow. Be more careful about overflow
3576 calculations, and distinguish size from memory overflow better.
3577 (receive_incremental_selection): When tracing, don't assume
3578 unsigned int is less than INT_MAX.
3579 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3580 harmful) conversions of unsigned short to int.
3581 (lisp_data_to_selection_data): Don't assume that integers
3582 in the range -65535 through -1 fit in an X unsigned short.
3583 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3584 result parameters unless successful. Rely on cons_to_unsigned
3585 to report problems with elements; the old code wasn't right anyway.
3586 (x_check_property_data): Check for int overflow; we cannot use
3587 a wider type due to X limits.
3588 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3589
726e0ab1 3590 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3591
0065d054
PE
3592 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3593 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3594 (x_color_cells): Don't store size until memory allocation succeeds.
3595 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3596 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3597 (x_term_init): Don't assume length fits in int (sprintf is limited
3598 to int size).
bc18e09d 3599
ebfa62c0
PE
3600 Use ptrdiff_t for composition IDs.
3601 * character.c (lisp_string_width):
3602 * composite.c (composition_table_size, n_compositions)
3603 (get_composition_id, composition_gstring_from_id):
3604 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3605 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3606 * window.c (Frecenter):
3607 Use ptrdiff_t, not int, for composition IDs.
3608 * composite.c (get_composition_id): Check for integer overflow.
3609 * composite.h: Adjust prototypes to match the above changes.
3610
d3411f89
PE
3611 Use ptrdiff_t for hash table indexes.
3612 * category.c (hash_get_category_set):
3613 * ccl.c (ccl_driver):
3614 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3615 * coding.c (coding_system_charset_list, detect_coding_system):
3616 * coding.h (struct coding_system.id):
3617 * composite.c (get_composition_id, gstring_lookup_cache):
3618 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3619 * image.c (xpm_get_color_table_h):
3620 * lisp.h (hash_lookup, hash_put):
3621 * minibuf.c (Ftest_completion):
3622 Use ptrdiff_t for hash table indexes, not int (which is too
3623 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3624 32-bit --with-wide-int hosts).
3625
e097a6fa
PE
3626 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3627 Add a FIXME comment about memory leaks.
3628 (syms_of_charset): Don't assume xmalloc returns.
3629
5637687f
PE
3630 Don't assume that stated character widths fit in int.
3631 * character.c (Fchar_width, c_string_width, lisp_string_width):
3632 * character.h (CHAR_WIDTH):
3633 * indent.c (MULTIBYTE_BYTES_WIDTH):
3634 Use sanitize_char_width to avoid undefined and/or bad behavior
3635 with outlandish widths.
a66cfb1c 3636 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3637 now that we have two such functions. All uses changed.
3638 (sanitize_char_width): New inline function.
3639
a2271ba2
PE
3640 Don't assume that tab-width fits in int.
3641 * character.h (sanitize_width): New inline function.
3642 (SANE_TAB_WIDTH): New macro.
3643 (ASCII_CHAR_WIDTH): Use it.
3644 * indent.c (sane_tab_width): Remove. All uses replaced by
3645 SANE_TAB_WIDTH (current_buffer).
3646 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3647
18c52557
PE
3648 * fileio.c: Integer overflow issues with file modes.
3649 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3650
caeeedc1
PE
3651 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3652 Remove unreachable code.
3653 (read_hex, load_charset_map_from_file): Check for integer overflow.
3654
6df6ae42 3655 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3656 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3657 (x_send_scroll_bar_event): Likewise. Check that the size does not
3658 exceed limits imposed by XClientMessageEvent, as well as the usual
3659 ptrdiff_t and size_t limits.
3660
b13995db
PE
3661 * keyboard.c: Overflow, signedness and related fixes.
3662 (make_lispy_movement): Use same integer type in forward decl
3663 that is used in the definition.
3664 (read_key_sequence, keyremap_step):
3665 Change bufsize argument back to int, undoing my 2011-03-30 change.
3666 We prefer signed types, and int is wide enough here.
3667 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3668 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3669 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3670 length, not size_t. Use ptrdiff_t for index, not int.
3671 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3672 possibility of integer overflow.
3673
13464394
PE
3674 Overflow, signedness and related fixes for images.
3675
3676 * dispextern.h (struct it.stack[0].u.image.image_id)
3677 (struct_it.image_id, struct image.id, struct image_cache.size)
3678 (struct image_cache.used, struct image_cache.ref_count):
3679 * gtkutil.c (update_frame_tool_bar):
3680 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3681 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3682 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3683 * nsmenu.m (update_frame_tool_bar):
3684 * xdisp.c (calc_pixel_width_or_height):
3685 * xfns.c (image_cache_refcount):
3686 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3687 on typical 64-bit hosts.
3688
3689 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3690 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3691 Omit unnecessary casts to int.
3692 (parse_image_spec): Check that integers fall into 'int' range
3693 when the callers expect that.
3694 (image_ascent): Redo ascent calculation to avoid int overflow.
3695 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3696 (lookup_image): Remove unnecessary tests.
3697 (xbm_image_p): Locals are now of int, not EMACS_INT,
3698 since parse_image_check makes sure they fit into int.
3699 (png_load, gif_load, svg_load_image):
3700 Prefer int to unsigned where either will do.
3701 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3702 old tiff_error_handler and tiff_warning_handler.
3703 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3704 stack buffer overflows. It uses only the features of vsnprintf
3705 that are common to both POSIX and native Microsoft.
3706 (tiff_error_handler, tiff_warning_handler): Use it.
3707 (tiff_load, gif_load, imagemagick_load_image):
3708 Don't assume :index value fits in 'int'.
3709 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3710 (imagemagick_load_image): Check that crop parameters fit into
3711 the integer types that MagickCropImage accepts. Don't assume
3712 Vimagemagick_render_type has a nonnegative value. Don't assume
3713 size_t fits in 'long'.
3714 (gs_load): Use printmax_t to print the widest integers possible.
3715 Check for integer overflow when computing image height and width.
3716
c11821d4
EZ
37172011-08-26 Eli Zaretskii <eliz@gnu.org>
3718
3719 * xdisp.c (redisplay_window): Don't force window start if point
3720 will be invisible in the resulting window. (Bug#9324)
3721
0c95fcf7
EZ
37222011-08-25 Eli Zaretskii <eliz@gnu.org>
3723
3724 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3725 the display spec is of the form `(space ...)'.
3726 (handle_display_spec): Return the value returned by
3727 handle_single_display_spec, not just 1 or zero.
3728 (handle_single_display_spec): If the display spec is of the form
3729 `(space ...)', and specifies display in the text area, return 2
3730 rather than 1.
fee65a97 3731 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3732 accurately, and prefer exact match for point under bidi.
3733 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3734
3735 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3736 into disp_prop; all users changed.
3737
3738 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3739 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3740 for the text covered by the display property.
3741
e4ed06f1
CY
37422011-08-25 Chong Yidong <cyd@stupidchicken.com>
3743
3744 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3745 Change return value to nil.
3746 (Frecord_buffer): Delete unused function.
3747
f67cdd7f
EZ
37482011-08-24 Eli Zaretskii <eliz@gnu.org>
3749
5980d4c6
EZ
3750 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3751 buffers, return left-to-right.
8610fe8b
EZ
3752 (set_cursor_from_row): Consider candidate row a win if its glyph
3753 represents a newline and point is on that newline. Fixes cursor
3754 positioning on the newline at EOL of R2L text within L2R
3755 paragraph, and vice versa.
3756 (try_cursor_movement): Check continued rows, in addition to
3757 continuation rows. Fixes unwarranted scroll when point enters a
3758 continued line of R2L text within an L2R paragraph, or vice versa.
3759 (cursor_row_p): Consider the case of point being equal to
3760 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3761 from the end of a short line to the beginning of a continued line
3762 of R2L text within L2R paragraph.
3763 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3764 composed characters.
5980d4c6 3765
f67cdd7f
EZ
3766 * bidi.c (bidi_check_type): Use xassert.
3767 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3768 members.
3769
bca633fb
EZ
37702011-08-23 Eli Zaretskii <eliz@gnu.org>
3771
3772 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3773 a character.
3774
4a5885a7
CY
37752011-08-23 Chong Yidong <cyd@stupidchicken.com>
3776
3777 * nsfont.m (ns_otf_to_script): Fix typo.
3778
0902a04e
KH
37792011-08-22 Kenichi Handa <handa@m17n.org>
3780
3781 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3782 extra slot even if the purpose is char-code-property-table.
3783
1a2e6670
EZ
37842011-08-23 Eli Zaretskii <eliz@gnu.org>
3785
8ddde651
EZ
3786 * xdisp.c (redisplay_window): When computing centering_position,
3787 account for the height of the header line. (Bug#8874)
3788
425cc014
EZ
3789 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3790 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3791 candidate is selected by the mouse, and that candidate has a
3792 composed character under the mouse.
3793
1a2e6670
EZ
3794 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3795 coordinates reported by pos-visible-in-window-p for a composed
3796 character in column zero.
3797
8b76d6f8
SM
37982011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3799
3800 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3801
dac347dd
EZ
38022011-08-22 Eli Zaretskii <eliz@gnu.org>
3803
3804 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3805 consider it a hit if to_charpos is anywhere in the range of the
3806 composed buffer positions.
3807
e013fb34
CY
38082011-08-22 Chong Yidong <cyd@stupidchicken.com>
3809
3810 * image.c (gif_load): Don't assume that each subimage has the same
3811 dimensions as the base image. Handle disposal method that is
3812 "undefined" by the gif spec (Bug#9335).
3813
bd1ba3e8
CY
38142011-08-20 Chong Yidong <cyd@stupidchicken.com>
3815
3816 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3817 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3818
54a1215b
EZ
38192011-08-19 Eli Zaretskii <eliz@gnu.org>
3820
823564e5
EZ
3821 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3822 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3823 from an Org mode buffer to a Speedbar frame.
3824
54a1215b
EZ
3825 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3826 a composition, take its buffer position from IT->cmp_it.charpos.
3827 Fixes cursor positioning at the beginning of a line that begins
3828 with a composed character.
3829
9778ebcc
EZ
38302011-08-18 Eli Zaretskii <eliz@gnu.org>
3831
0be6ee06
EZ
3832 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3833 character bidirectional type, use STRONG_L instead. Fixes crashes
3834 in a buffer produced by `describe-categories'.
3835
9778ebcc
EZ
3836 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3837 members before the level stack, so they would be saved and
3838 restored when copying iterator state. Fixes incorrect reordering
3839 around TABs covered by display properties.
3840
156bffbe
AS
38412011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3842
6b02f655 3843 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3844
72ad093b
CY
38452011-08-17 Chong Yidong <cyd@stupidchicken.com>
3846
3847 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3848 (internal_condition_case_2, internal_condition_case_n):
3849 Remove unnecessary aborts (Bug#9081).
72ad093b 3850
35774242
EZ
38512011-08-17 Eli Zaretskii <eliz@gnu.org>
3852
3853 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3854 has no `load' handler, try opening the file locally. (Bug#9311)
3855
db76dd85
KB
38562011-08-16 Ken Brown <kbrown@cornell.edu>
3857
3858 * gmalloc.c: Expand comment.
3859
b215eee5
EZ
38602011-08-16 Eli Zaretskii <eliz@gnu.org>
3861
3862 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3863 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3864
a4579d33
KB
38652011-08-16 Ken Brown <kbrown@cornell.edu>
3866
3867 Fix memory allocation problems in Cygwin build (Bug#9273).
3868
3869 * unexcw.c ( __malloc_initialized): Declare external variable.
3870 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3871
8b76d6f8
SM
3872 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3873 New variables.
a4579d33
KB
3874 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3875 dumped emacs.
3876 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3877 in the static heap.
3878 [CYGWIN] (special_realloc): New function.
3879 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3880 requests to realloc storage in the static heap.
3881
3ebec551
PE
38822011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 * bidi.c (bidi_initialize): Remove unused local.
3885
9fd8be00
EZ
38862011-08-15 Eli Zaretskii <eliz@gnu.org>
3887
6b02f655
SM
3888 * bidimirror.h:
3889 * biditype.h: Remove file.
3890 * makefile.w32-in ($(BLD)/bidi.$(O)):
3891 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3892
3893 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3894
3895 * chartab.c: Improve commentary for the uniprop_table API.
3896
32413314
EZ
3897 * bidi.c (bidi_paragraph_init): Support zero value of
3898 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3899 (bidi_initialize): Use uniprop_table instead of including
3900 biditype.h and bidimirror.h.
32413314 3901
9fd8be00
EZ
3902 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3903 coordinates of the iterator when restoring from ppos_it.
3904 (Bug#9296)
3905
5cf2b69b
KH
39062011-08-14 Kenichi Handa <handa@m17n.org>
3907
3908 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3909 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3910
daf17d00
EZ
39112011-08-14 Eli Zaretskii <eliz@gnu.org>
3912
3913 * xdisp.c (move_it_in_display_line_to): Don't invoke
3914 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3915 ppos_it. Fixes vertical cursor motion when line beginning is
3916 covered by an image. (Bug#9296)
3917
08e3161a
JD
39182011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3919
3920 * nsterm.h (ns_run_ascript): Declare.
3921 (NSAPP_DATA2_RUNASSCRIPT): Define.
3922
3923 * nsfns.m (as_script, as_result, as_status): New static variables.
3924 (ns_run_ascript): New function.
5e617bc2 3925 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3926 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3927 the event loop. Get status from as_status (Bug#7276).
3928
3929 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3930 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3931 the event loop (Bug#7276).
3932
a3720aa2
AS
39332011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3934
3935 * gnutls.c (QCgnutls_bootprop_priority)
3936 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3937 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3938 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3939 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3940 (QCgnutls_bootprop_verify_hostname_error)
3941 (QCgnutls_bootprop_callbacks_verify): Rename from
3942 Qgnutls_bootprop_..., all uses changed.
3943
3944 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3945 uses changed.
3946
0a0d27fb
PE
39472011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3948
19d5c50c
PE
3949 * xfaces.c (Qframe_set_background_mode): Now static.
3950 * dispextern.h (Qframe_set_background_mode): Remove decl.
3951
0a0d27fb
PE
3952 * process.c (Fnetwork_interface_info): Declare local only if needed.
3953
377538cb
JD
39542011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3955
3956 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3957 (Fnetwork_interface_list): Allocate in increments of bytes instead
3958 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3959 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3960 sockaddr.
3961 (struct ifflag_def): notrailers is smart on OSX.
3962 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3963 Get hardware address with getifaddrs if available.
3964
08fff70c
EZ
39652011-08-12 Eli Zaretskii <eliz@gnu.org>
3966
3967 * xdisp.c (iterate_out_of_display_property): xassert that
3968 IT->position is set to within IT->object's boundaries. Break from
3969 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3970 when IT->position is set up wrongly due to some bug.
3971 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3972 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3973 entry. Force push_it to save on the stack the current
3974 buffer/string position, to be restored by pop_it. Fix flags in
3975 the iterator structure wrt the object coming from a display
3976 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3977 properties. (Bug#9284)
3978
7be1c708 39792011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3980
7be1c708
CY
3981 * fontset.c (fontset_get_font_group): Add proper type checks.
3982 (Bug#9172)
aac0c6e3 3983
7be1c708 39842011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3985
7be1c708
CY
3986 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3987 and LC_VERSION_MIN_MACOSX.
3988 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3989 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3990
97bb72a6
EZ
39912011-08-08 Eli Zaretskii <eliz@gnu.org>
3992
3993 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3994 no-display-properties-and-no-overlays under bidi display.
3995 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3996 properties and overlays.
97bb72a6 3997
d5617611
CY
39982011-08-08 Chong Yidong <cyd@stupidchicken.com>
3999
37e11a63
CY
4000 * editfns.c (Fset_time_zone_rule): Document relationship with the
4001 setenv function.
4002
d5617611
CY
4003 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4004 the font entity extracted from the cache (Bug#8109).
4005
58872834
CY
40062011-08-07 Chong Yidong <cyd@stupidchicken.com>
4007
4008 * composite.c (autocmp_chars): Don't reset point. That is done by
4009 restore_point_unwind (Bug#5984).
4010
75bfc667
JL
40112011-08-07 Juri Linkov <juri@jurta.org>
4012
4013 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4014 to show the arg `TIME' instead of `TIMEVAL'.
4015
d1410150
EZ
40162011-08-06 Eli Zaretskii <eliz@gnu.org>
4017
4018 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4019 display property strides EOL and includes a newline, as in
4020 longlines-mode. (Bug#9254)
75b771e4
EZ
4021 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4022 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4023
4024 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4025 is non-zero, even if the data buffer is NULL. Fixes a crash in
4026 vertical-motion with longlines-mode. (Bug#9254)
4027
35928349
EZ
40282011-08-05 Eli Zaretskii <eliz@gnu.org>
4029
ec7cc85b
EZ
4030 * bidi.c <bidi_cache_total_alloc>: Now static.
4031 (bidi_initialize): Initialize bidi_cache_total_alloc.
4032
8b76d6f8 4033 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4034 cache. (Bug#9221)
4035
4036 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4037 amount allocated this far in `bidi_cache_total_alloc'.
4038 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4039 non-zero, only free the data buffer without restoring the cache
4040 contents. All callers changed.
4041
4042 * dispextern.h (bidi_unshelve_cache): Update prototype.
4043
4044 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4045 (move_it_in_display_line, move_it_to)
4046 (move_it_vertically_backward, move_it_by_lines): Replace the call
4047 to xfree to an equivalent call to bidi_unshelve_cache.
4048 (move_it_in_display_line_to): Fix logic of returning
412b6358 4049 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4050
e2e2423b
EZ
40512011-08-05 Eli Zaretskii <eliz@gnu.org>
4052
4053 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4054 came from a string character with a `cursor' property. (Bug#9229)
4055
ae9e757a
JD
40562011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4057
4058 * Makefile.in (LIB_PTHREAD): New variable.
4059 (LIBES): Add LIB_PTHREAD (Bug#9216).
4060
4061 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4062 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4063
213bd7f2
AS
40642011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4065
6b02f655 4066 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4067
99aaf75f
JD
40682011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4069
4070 * xterm.c (x_find_topmost_parent): New function.
4071 (x_set_frame_alpha): Find topmost parent window with
4072 x_find_topmost_parent and set the property there also (bug#9181).
4073 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4074
c74e9d86
PE
40752011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4076
4077 * callproc.c (Fcall_process): Avoid vfork clobbering
4078 the local vars buffer, coding_systems, current_dir.
4079
640c8776
SM
40802011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4081
4082 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4083
f26d0e4c
PE
40842011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4085
8a10d76c
PE
4086 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4087 so that it is not optimized away.
4088
f26d0e4c
PE
4089 * xdisp.c (compute_display_string_pos): Remove unused local.
4090
55439c61
EZ
40912011-08-02 Eli Zaretskii <eliz@gnu.org>
4092
4093 Fix slow cursor motion and scrolling in large buffers with
4094 selective display, like Org Mode buffers. (Bug#9218)
4095
4096 * dispextern.h (struct bidi_it): New member disp_prop_p.
4097
4098 * xdisp.c: Remove one-slot cache of display string positions.
4099 (compute_display_string_pos): Accept an additional argument
5e617bc2 4100 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4101 for a display string or property. If found, set DISP_PROP_P
4102 non-zero.
4103
4104 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4105 DISP_PROP_P, and pass it to compute_display_string_pos.
4106 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4107 non-zero. All callers of bidi_fetch_char changed.
4108
fb33fa43
SM
41092011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4112
b099e063
DM
41132010-12-03 Don March <don@ohspite.net>
4114
4115 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4116 last character M-[char] is translated to ESC [char] (bug#7541).
4117
5cc7f7af
KH
41182011-08-02 Kenichi Handa <handa@m17n.org>
4119
d0fffa3f 4120 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4121
4122 * chartab.c (uniprop_table): Make it non-static.
4123
525d5e6e
EZ
41242011-08-01 Eli Zaretskii <eliz@gnu.org>
4125
4126 * xdisp.c (forward_to_next_line_start): Accept additional argument
4127 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4128 on the newline.
4129 (reseat_at_next_visible_line_start): Use the bidi iterator state
4130 returned by forward_to_next_line_start to restore the state of
4131 it->bidi_it after backing up to previous newline. (Bug#9212)
4132
31011111
AS
41332011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4134
4135 * regex.c (re_comp): Protoize.
4136 (re_exec): Fix return type.
4137 (regexec): Fix type of `ret'. (Bug#9203)
4138
476371c4
PE
41392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4140
e5d76069
PE
4141 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4142 This is needed if max-image-size is a floating-point number.
4143
9a79b20c
AS
41442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4145
4146 * print.c (print_object): Print empty symbol as ##.
4147
4148 * lread.c (read1): Read ## as empty symbol.
4149
d8c2fa78
AA
41502011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4151
4152 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4153 setting frame foreground color (Bug#9175).
4154 (x_set_background_color): Likewise.
4155
ffe57a7a
AA
4156 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4157 contents (Bug#9176).
4158 (EmacsTooltip -init): Remove bezels and add shadows to
4159 tooltip windows.
4160
bf3492a5
AA
4161 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4162 or scroll bar (Bug#8470).
4163
d55e9c53
AA
4164 * nsfont.m (nsfont_open): Remove assignment to voffset and
4165 unnecessary vars hshink, expand, hd, full_height, min_height.
4166 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4167
4168 * nsterm.h (nsfont_info): Remove voffset field.
4169
d8c2fa78 41702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4171
4172 Implement strike-through and overline on NextStep (Bug#8863).
4173
4174 * nsfont.m (nsfont_open): Use underline position provided by font,
4175 instead of hard-coded value of 2.
4176 (nsfont_draw): Call ns_draw_text_decoration instead.
4177
4178 * nsterm.h: Add declaration for ns_draw_text_decoration.
4179
4180 * nsterm.m (ns_draw_text_decoration): New function for drawing
4181 underline, overline, and strike-through.
4182 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4183 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4184 accommodate underlining, etc.
4843aac3 4185
4cc60b9b
EZ
41862011-07-28 Eli Zaretskii <eliz@gnu.org>
4187
bc7ece87
EZ
4188 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4189 default.
4cc60b9b 4190
476371c4
PE
41912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4192
66606eea
PE
4193 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4194 Without this fix, if a signal arrives just after memory fills up,
4195 'malloc' might be invoked reentrantly.
4196
476371c4
PE
4197 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4198 In other words, assume that every image size is allowed, on non-X
4199 hosts. This assumption is probably wrong, but it lets Emacs compile.
4200
f3fcc40d
AS
42012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4202
4203 * regex.c (re_iswctype): Convert return values to boolean.
4204
350c992f
EZ
42052011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4206
4207 * xdisp.c (compute_display_string_pos): Don't use cached display
4208 string position if the buffer had its restriction changed.
4209 (Bug#9184)
4210
5266b4bb
PE
42112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4214
2573a837 42152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4216
41f55ccd 4217 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4218
39e378da
PE
4219 * bidi.c: Integer size and overflow fixes.
4220 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4221 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4222 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4223 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4224 (bidi_find_other_level_edge):
4225 Use ptrdiff_t instead of EMACS_INT where either will do.
4226 This works better on 32-bit hosts configured --with-wide-int.
4227 (bidi_cache_ensure_space): Check for size-calculation overflow.
4228 Use % rather than repeated addition, for better worst-case speed.
4229 Don't set bidi_cache_size until after xrealloc returns, because it
4230 might not return.
4231 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4232 (bidi_cache_ensure_space): Also check that the bidi cache size
4233 does not exceed that of the largest Lisp string or buffer. See Eli
4234 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4235
5e927815
PE
4236 * alloc.c (__malloc_size_t): Remove.
4237 All uses replaced by size_t. See Andreas Schwab's note
4238 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4239
ca4aa935
PE
4240 * image.c: Improve checking for integer overflow.
4241 (check_image_size): Assume that f is nonnull, since
4242 it is always nonnull in practice. This is one less thing to
4243 worry about when checking for integer overflow later.
4244 (x_check_image_size): New function, which checks for integer
4245 overflow issues inside X.
4246 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4247 This removes the need for a memory_full check.
4248 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4249 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4250 (xbm_read_bitmap_data): Change locals back to 'int', since
4251 their values must fit in 'int'.
4252 (xpm_load_image, png_load, tiff_load):
4253 Invoke x_create_x_image_and_pixmap earlier,
4254 to avoid much needless work if the image is too large.
4255 (tiff_load): Treat overly large images as if
4256 x_create_x_image_and_pixmap failed, not as malloc failures.
4257 (gs_load): Use x_check_image_size.
4258
5f8f9cc2
PE
4259 * gtkutil.c: Omit integer casts.
4260 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4261 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4262
5adf60bc
PE
4263 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4264
c8907a93
PE
4265 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4266 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4267 would wrongly return t on a 64-bit host.
4268
e3c25c68
PE
4269 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4270 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4271 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4272 and therefore cause GCC to emit a bogus diagnostic in some cases.
4273
3f791afe
PE
4274 * image.c: Integer signedness and overflow and related fixes.
4275 This is not an exhaustive set of fixes, but it's time to
4276 record what I've got.
4277 (lookup_pixel_color, check_image_size): Remove redundant decls.
4278 (check_image_size): Don't assume that arbitrary EMACS_INT values
4279 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4280 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4281 (tiff_load, imagemagick_load_image):
4282 Check for overflow in size calculations.
4283 (x_create_x_image_and_pixmap): Remove unnecessary test for
4284 xmalloc returning NULL; that can't happen.
4285 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4286 (xpm_color_bucket): Use better integer hashing function.
4287 (xpm_cache_color): Don't possibly over-allocate memory.
4288 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4289 (gif_memory_source):
4290 Use ptrdiff_t, not int or size_t, to record sizes.
4291 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4292 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4293 either works, as we prefer signed integers.
4294 (tiff_read_from_memory, tiff_write_from_memory):
4295 Return tsize_t, not size_t, since that's what the TIFF API wants.
4296 (tiff_read_from_memory): Don't fail simply because the read would
4297 go past EOF; instead, return a short read.
4298 (tiff_load): Omit no-longer-needed casts.
4299 (Fimagemagick_types): Don't assume size fits into 'int'.
4300
3cc5a532
PE
4301 Improve hashing quality when configured --with-wide-int.
4302 * fns.c (hash_string): New function, taken from sxhash_string.
4303 Do not discard information about ASCII character case; this
4304 discarding is no longer needed.
4305 (sxhash-string): Use it. Change sig to match it. Caller changed.
4306 * lisp.h: Declare it.
4307 * lread.c (hash_string): Remove, since we now use fns.c's version.
4308 The fns.c version returns a wider integer if --with-wide-int is
4309 specified, so this should help the quality of the hashing a bit.
4310
b312a492
PE
4311 * emacs.c: Integer overflow minor fix.
4312 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4313 Define only if GNU_LINUX.
4314 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4315
dfd153ae
PE
4316 * dispnew.c: Integer signedness and overflow fixes.
4317 Remove unnecessary forward decls, that were a maintenance hassle.
4318 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4319 All uses changed.
4320 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4321 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4322 (prepare_desired_row, line_draw_cost):
4323 Use int, not unsigned, where either works.
4324 (save_current_matrix, restore_current_matrix):
4325 Use ptrdiff_t, not size_t, where either works.
4326 (init_display): Check for overflow more accurately, and without
4327 relying on undefined behavior.
4328
a81d11a3
PE
4329 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4330 Remove, replacing with the new symbols in lisp.h. All uses changed.
4331 * fileio.c (make_temp_name):
4332 * filelock.c (lock_file_1, lock_file):
4333 * xdisp.c (message_dolog):
4334 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4335 Use pMd etc. instead.
4336 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4337 replacing the pWIDE etc. symbols removed from editfns.c.
4338
3300e6fd
PE
4339 * keyboard.h (num_input_events): Now uintmax_t.
4340 This is (very slightly) less likely to mess up due to wraparound.
4341 All uses changed.
4342
fd05c7e9
PE
4343 * buffer.c: Integer signedness fixes.
4344 (alloc_buffer_text, enlarge_buffer_text):
4345 Use ptrdiff_t rather than size_t when either will do, as we prefer
4346 signed integers.
4347
903fe15d
PE
4348 * alloc.c: Integer signedness and overflow fixes.
4349 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4350 (__malloc_size_t): Default to size_t, not to int.
4351 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4352 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4353 Prefer ptrdiff_t to size_t when either would do, as we prefer
4354 signed integers.
4355 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4356 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4357 Now const. Initialize with values that are in range even if char
4358 is signed.
4359 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4360 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4361 These functions do the right thing with sizes > 2**32.
4362 (check_depth): Now ptrdiff_t, not int.
4363 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4364 Adjust to new way of storing sizes. Check for size overflow bugs
4365 in rest of code.
4366 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4367 slightly wrong anyway, as it missed one instance of
4368 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4369 (refill_memory_reserve): Omit needless cast to size_t.
4370 (mark_object_loop_halt): Mark as externally visible.
4371
ac82cc6a
PE
4372 * xselect.c: Integer signedness and overflow fixes.
4373 (Fx_register_dnd_atom, x_handle_dnd_message):
4374 Use ptrdiff_t, not size_t, since we prefer signed.
4375 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4376 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4377 x_dnd_atoms_size and x_dnd_atoms_length.
4378
c2d1e36d
PE
4379 * doprnt.c: Prefer signed to unsigned when either works.
4380 * eval.c (verror):
4381 * doprnt.c (doprnt):
4382 * lisp.h (doprnt):
4383 * xdisp.c (vmessage):
4384 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4385 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4386 prefer signed arithmetic to avoid comparison confusion.
4387 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4388 but is a bit tricky.
4389
0e926e56
PE
4390 Assume freestanding C89 headers, string.h, stdlib.h.
4391 * data.c, doprnt.c, floatfns.c, print.c:
4392 Include float.h unconditionally.
4393 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4394 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4395 * regex.c: Likewise for stddef.h, string.h.
4396 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4397 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4398 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4399 (STDC_HEADERS): Remove obsolete defines.
4400 * sysdep.c: Include limits.h unconditionally.
4401
9cfdb3ec
PE
4402 Assume support for memcmp, memcpy, memmove, memset.
4403 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4404 * regex.c (memcmp, memcpy):
4405 Remove; we assume C89 now.
4406
4407 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4408 (__malloc_safe_bcopy): Remove; no longer needed.
4409
cf950e6b 4410 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4411 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4412 well either way, and we prefer signed to unsigned.
4413
dbf38e02
LMI
44142011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4415
4416 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4417 closes the connection while we're reading (bug#9182).
4418
d6f0886c 44192011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4420
d6f0886c
JD
4421 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4422 are specified (Bug#9168).
24e0f6b1 4423
2eb1f9e6
PE
44242011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4425
4426 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4427 Found by GCC static checking and --with-wide-int on a 32-bit host.
4428
22381272 44292011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4430
4431 * xdisp.c (compute_display_string_pos): Fix logic of caching
4432 previous display string position. Initialize cached_prev_pos to
4433 -1. Fixes slow-down at the beginning of a buffer.
4434
f25e39b4
EZ
44352011-07-24 Eli Zaretskii <eliz@gnu.org>
4436
4437 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4438 for attrs[LFACE_FONTSET_INDEX].
4439
04c4b52e
PE
44402011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4441
4442 * xml.c (parse_region): Remove unused local
4443 that was recently introduced.
4444
c1734fbd
EZ
44452011-07-23 Eli Zaretskii <eliz@gnu.org>
4446
be18c5a5
EZ
4447 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4448 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4449
c1734fbd
EZ
4450 * xdisp.c (move_it_in_display_line_to): Record the best matching
4451 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4452 exit if none of the characters scanned was an exact match.
4453 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4454 when exact match is impossible due to invisible text, and the
4455 lines are truncated.
4456
a258d627
JD
44572011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4458
4459 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4460 for OSX >= 10.7.
4461
b6d5a689
EZ
44622011-07-22 Eli Zaretskii <eliz@gnu.org>
4463
0f74f785
EZ
4464 Fix a significant slow-down of cursor motion with C-n, C-p,
4465 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4466 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4467 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4468 (next_element_from_buffer): Call compute_stop_pos_backwards to
4469 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4470 base_level_stop.
4471 (reseat): Don't look for prev_stop, as that could mean a very long
4472 run.
4473 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4474 <cached_disp_overlay_modiff>: Cache for last found display string
4475 position.
551918c1 4476 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4477 about the same buffer in the same area of character positions, and
4478 the buffer wasn't changed since the time the display string
4479 position was cached.
551918c1 4480
b2d0c91a
EZ
44812011-07-22 Eli Zaretskii <eliz@gnu.org>
4482
4483 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4484 is an integer, which is important for empty lines. (Bug#9149)
4485
043604ee
CY
44862011-07-22 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * frame.c (Fmodify_frame_parameters): In tty case, update the
4489 default face if necessary (Bug#4238).
4490
da4adb04
CY
44912011-07-21 Chong Yidong <cyd@stupidchicken.com>
4492
4493 * editfns.c (Fstring_to_char): No need to explain what a character
4494 is in the docstring (Bug#6576).
4495
9abd0532
LMI
44962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4497
4498 * xml.c (parse_region): Make sure we always return a tree.
4499
36881d16
HK
45002011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4501
4502 * xml.c (parse_region): If a document contains only comments,
4503 return that, too.
4504
1e98674d
LMI
45052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4506
4507 * xml.c (make_dom): Return comments, too.
4508
590bd467
PE
45092011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4510
4511 Port to OpenBSD.
4512 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4513 and the surrounding thread.
4514 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4515 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4516 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4517 timer goes off.
4518 * s/openbsd.h (BROKEN_SIGIO): Define.
4519 * unexelf.c (unexec) [__OpenBSD__]:
4520 Don't update the .mdebug section of the Alpha COFF symbol table.
4521
f41628b2
LMI
45222011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4523
4524 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4525 (bug#8460).
4526
b59b67c5
PE
45272011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4528
15e3a074
PE
4529 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4530 This fixes some race conditions on the permissions of any newly
4531 created file.
4532
41bed37d
PE
4533 * alloc.c (valid_pointer_p): Use pipe, not open.
4534 This fixes some permissions issues when debugging.
4535
b59b67c5
PE
4536 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4537 If fchown fails to set both uid and gid, try to set just gid,
4538 as that is sometimes allowed. Adjust the file's mode to eliminate
4539 setuid or setgid bits that are inappropriate if fchown fails.
4540
925a6be7
SM
45412011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4542
4543 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4544 to compare Lisp_Objects.
4545 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4546 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4547 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4548
52968808
AS
45492011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4550
0a6a104b
AS
4551 * lread.c (read_integer): Unread even EOF character.
4552 (read1): Likewise. Properly record start position of symbol.
4553
52968808
AS
4554 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4555 symbol character follows.
4556
9e381cdd
PE
45572011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4558
4559 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4560 This works around a problem with the previous change to Fcopy_file.
4561 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4562 and without this change, GCC might complain about discarding
4563 fchown's return value.
4564
b5641435
JB
45652011-07-16 Juanma Barranquero <lekktu@gmail.com>
4566
4567 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4568
a8031457
PE
45692011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4572
dd889327
LMI
45732011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4574
750c33f7
LMI
4575 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4576 it's used from the C level.
4577
dd889327
LMI
4578 * process.c: Use the same condition for POLL_FOR_INPUT in both
4579 keyboard.c and process.c (bug#1858).
4580
87e86684
LM
45812011-07-09 Lawrence Mitchell <wence@gmx.li>
4582
4583 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4584 (Fgnutls_boot): Use it.
4585
64348f40
AS
45862011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4587
4588 * doc.c (Fsubstitute_command_keys): Revert last change.
4589
1d698799
LMI
45902011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4591
f863868c
LMI
4592 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4593 quotes the next character, and doesn't affect other longer
4594 sequences (bug#8935).
4595
1d698799
LMI
4596 * lread.c (syms_of_lread): Clarify that is isn't only
4597 `eval-buffer' and `eval-defun' that's affected by
4598 `lexical-binding' (bug#8460).
4599
aa4b6df6
EZ
46002011-07-15 Eli Zaretskii <eliz@gnu.org>
4601
4602 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4603 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4604
5d856da6
PE
46052011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4606
ad6042bb
PE
4607 Fix minor problems found by static checking.
4608 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4609 (elsz): Now a signed constant, not a size_t var. We prefer signed
4610 types to unsigned, to avoid integer comparison confusion. Without
4611 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4612 "cannot optimize loop, the loop counter may overflow", a symptom
4613 of the confusion.
f00bbb22 4614 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4615 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4616
6468f31c
LMI
46172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4618
49080b10
LMI
4619 * search.c (Fre_search_backward): Mention `case-fold-search' in
4620 all the re_search_* functions (bug#8138).
4621
6468f31c
LMI
4622 * keyboard.c (Fopen_dribble_file): Document when the file is
4623 closed (bug#8056).
4624
c965adc5
EZ
46252011-07-14 Eli Zaretskii <eliz@gnu.org>
4626
df9733bf
EZ
4627 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4628 bidi_cache_idx.
4629
0bb23927
EZ
4630 Support bidi reordering of display and overlay strings.
4631 * xdisp.c (compute_display_string_pos)
4632 (compute_display_string_end): Accept additional argument STRING.
4633 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4634 (reseat_to_string): Initialize bidi_it->string.s and
4635 bidi_it->string.schars.
4636 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4637 NULL (avoids a crash in bidi_paragraph_init).
4638 Initialize itb.string.lstring.
0bb23927
EZ
4639 (init_iterator): Call bidi_init_it only of a valid
4640 buffer position was specified. Initialize paragraph_embedding to
4641 L2R.
4642 (reseat_to_string): Initialize the bidi iterator.
4643 (display_string): If we need to ignore text properties of
4644 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4645 original value of -1 will not work with bidi.)
4646 (compute_display_string_pos): First arg is now struct
4647 `text_pos *'; all callers changed. Support display properties on
4648 Lisp strings.
4649 (compute_display_string_end): Support display properties on Lisp
4650 strings.
4651 (init_iterator, reseat_1, reseat_to_string): Initialize the
4652 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4653 when iterating on a string not from display properties).
640c8776
SM
4654 (compute_display_string_pos, compute_display_string_end):
4655 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4656 arrow keys.
4657 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4658 base_level_stop; instead, set base_level_stop to BEGV.
4659 Fixes crashes in vertical-motion.
0bb23927
EZ
4660 (next_element_from_buffer): Improve commentary for when
4661 the iterator is before prev_stop.
4662 (init_iterator): Initialize bidi_p from the default value of
4663 bidi-display-reordering, not from buffer-local value. Use the
4664 buffer-local value only if initializing for buffer iteration.
4665 (handle_invisible_prop): Support invisible properties on strings
4666 that are being bidi-reordered.
4667 (set_iterator_to_next): Support bidi reordering of C strings and
4668 Lisp strings.
4669 (next_element_from_string): Support bidi reordering of Lisp
4670 strings.
4671 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4672 (display_string): Support display of R2L glyph rows.
4673 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4674 (init_iterator): Don't initialize it->bidi_p for strings
4675 here.
4676 (reseat_to_string): Initialize it->bidi_p for strings here.
4677 (next_element_from_string, next_element_from_c_string)
4678 (next_element_from_buffer): Add xassert's for correspondence
4679 between IT's object being iterated and it->bidi_it.string
4680 structure.
4681 (face_before_or_after_it_pos): Support bidi iteration.
4682 (next_element_from_c_string): Handle the case of the first string
4683 character that is not the first one in the visual order.
4684 (get_visually_first_element): New function, refactored from common
4685 parts of next_element_from_buffer, next_element_from_string, and
4686 next_element_from_c_string.
4687 (tool_bar_lines_needed, redisplay_tool_bar)
4688 (display_menu_bar): Force left-to-right direction. Add a FIXME
4689 comment for making that be controlled by a user option.
4690 (push_it, pop_it): Save and restore the state of the
4691 bidi iterator. Save and restore the bidi_p flag.
4692 (pop_it): Iterate out of display property for string iteration as
4693 well.
4694 (iterate_out_of_display_property): Support iteration over strings.
4695 (handle_single_display_spec): Set up it->bidi_it for iteration
4696 over a display string, and call bidi_init_it.
4697 (handle_single_display_spec, next_overlay_string)
4698 (get_overlay_strings_1, push_display_prop): Set up the bidi
4699 iterator for displaying display or overlay strings.
4700 (forward_to_next_line_start): Don't use the shortcut if
4701 bidi-iterating.
4702 (back_to_previous_visible_line_start): If handle_display_prop
4703 pushed the iterator stack, restore the internal state of the bidi
4704 iterator by calling bidi_pop_it same number of times.
4705 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4706 and we are bidi-iterating, don't decrement the iterator position;
4707 instead, set the first_elt flag in the bidi iterator, to produce
4708 the same effect.
4709 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4710 (push_display_prop): xassert that we are iterating a buffer.
4711 (push_it, pop_it): Save and restore paragraph_embedding member.
4712 (handle_single_display_spec, next_overlay_string)
4713 (get_overlay_strings_1, reseat_1, reseat_to_string)
4714 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4715 correctly. Don't assume unibyte strings are not bidi-reordered.
4716 (compute_display_string_pos)
4717 (compute_display_string_end): Fix handling the case of C string.
4718 (push_it, pop_it): Save and restore from_disp_prop_p.
4719 (handle_single_display_spec, push_display_prop): Set the
4720 from_disp_prop_p flag.
4721 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4722 (pop_it): Call iterate_out_of_display_property only if we are
4723 popping after iteration over a string that came from a display
4724 property. Fix a typo in popping stretch info. Add an assertion
4725 for verifying that the iterator position is in sync with the bidi
4726 iterator.
4727 (handle_single_display_spec, get_overlay_strings_1)
4728 (push_display_prop): Fix initialization of paragraph direction for
4729 string when that of the parent object is not yet determined.
4730 (reseat_1): Call bidi_init_it to resync the bidi
4731 iterator with IT's position. (Bug#7616)
4732 (find_row_edges): If ROW->start.pos gives position
4733 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4734 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4735 Reset the from_disp_prop_p flag.
4736 (SAVE_IT, RESTORE_IT): New macros.
4737 (pos_visible_p, face_before_or_after_it_pos)
4738 (back_to_previous_visible_line_start)
4739 (move_it_in_display_line_to, move_it_in_display_line)
4740 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4741 (try_scrolling, redisplay_window, display_line): Use them when
4742 saving a temporary copy of the iterator and restoring it back.
4743 (back_to_previous_visible_line_start, reseat_1)
4744 (init_iterator): Empty the bidi cache "stack".
4745 (move_it_in_display_line_to): If iterator ended up at
4746 EOL, but we never saw any buffer positions smaller than
4747 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4748 motion in bidi-reordered lines.
4749 (move_it_in_display_line_to): Record prev_method and prev_pos
4750 immediately before the call to set_iterator_to_next. Fixes cursor
4751 motion in bidi-reordered lines with stretch glyphs and strings
4752 displayed in margins. (Bug#8133) (Bug#8867)
4753 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4754 TO_CHARPOS.
640c8776
SM
4755 (pos_visible_p): Support positions in bidi-reordered lines.
4756 Save and restore bidi cache.
0bb23927
EZ
4757
4758 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4759 (bidi_paragraph_info): Delete unused struct.
4760 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4761 (bidi_cache_start): New variable.
4762 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4763 to zero.
4764 (bidi_cache_fetch_state, bidi_cache_search)
4765 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4766 (bidi_cache_find, bidi_peek_at_next_level)
4767 (bidi_level_of_next_char, bidi_find_other_level_edge)
4768 (bidi_move_to_visually_next): Compare cache index with
4769 bidi_cache_start rather than with zero.
4770 (bidi_fetch_char): Accept new argument STRING; all callers
4771 changed. Support iteration over a string. Support strings with
4772 display properties. Support unibyte strings. Fix the type of
4773 `len' according to what STRING_CHAR_AND_LENGTH expects.
4774 (bidi_paragraph_init, bidi_resolve_explicit_1)
4775 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4776 (bidi_level_of_next_char, bidi_move_to_visually_next):
4777 Support iteration over a string.
0bb23927
EZ
4778 (bidi_set_sor_type, bidi_resolve_explicit_1)
4779 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4780 can now be zero (for strings); special values 0 and -1 were
4781 changed to -1 and -2, respectively.
4782 (bidi_char_at_pos): New function.
4783 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4784 Call it instead of FETCH_MULTIBYTE_CHAR.
4785 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4786 initialized to valid values.
4787 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4788 values.
4789 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4790 the test for valid cached positions. Fix the logic for looking up
4791 the sentinel state in the cache. GCPRO the Lisp string we are
4792 iterating.
4793 (bidi_push_it, bidi_pop_it): New functions.
4794 (bidi_initialize): Initialize the bidi cache start stack pointer.
4795 (bidi_cache_ensure_space): New function, refactored from part of
4796 bidi_cache_iterator_state. Don't assume the required size is just
4797 one BIDI_CACHE_CHUNK away.
4798 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4799 (bidi_count_bytes, bidi_char_at_pos): New functions.
4800 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4801 always valid if bidi_cache_idx is valid.
4802 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4803 is valid if it's going to be used.
4804 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4805 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4806 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4807 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4808 (bidi_find_other_level_edge, bidi_cache_start_stack):
4809 All variables related to cache indices are now EMACS_INT.
c965adc5 4810
0bb23927
EZ
4811 * dispextern.h (struct bidi_string_data): New structure.
4812 (struct bidi_it): New member `string'. Make flag members be 1-bit
4813 fields, and put them last in the struct.
640c8776
SM
4814 (compute_display_string_pos, compute_display_string_end):
4815 Update prototypes.
0bb23927
EZ
4816 (bidi_push_it, bidi_pop_it): Add prototypes.
4817 (struct iterator_stack_entry): New members bidi_p,
4818 paragraph_embedding, and from_disp_prop_p.
4819 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4820 (bidi_shelve_cache, bidi_unshelve_cache):
4821 Declare prototypes.
0bb23927
EZ
4822
4823 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4824 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4825 and vector-like objects.
4826
4827 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4828 cache around display iteration.
4829
4830 * window.c (Fwindow_end, window_scroll_pixel_based)
4831 (displayed_window_lines, Frecenter): Save and restore the bidi
4832 cache around display iteration.
4833
3bbd2265
LMI
48342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4835
4836 * editfns.c (Fdelete_region): Clarify the use of the named
4837 parameters (bug#6788).
4838
adc47434
MR
48392011-07-14 Martin Rudalics <rudalics@gmx.at>
4840
4841 * indent.c (Fvertical_motion): Set and restore w->pointm when
4842 saving and restoring the window's buffer (Bug#9006).
4843
837c31f8
LMI
48442011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4845
4846 * editfns.c (Fstring_to_char): Clarify just what is returned
4847 (bug#6576). Text by Eli Zaretskii.
4848
ac389d0c
JB
48492011-07-13 Juanma Barranquero <lekktu@gmail.com>
4850
4851 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4852
0be0ce47
EZ
48532011-07-13 Eli Zaretskii <eliz@gnu.org>
4854
4855 * buffer.c (mmap_find): Fix a typo.
4856
cd18e7e3
JB
48572011-07-13 Johan Bockgård <bojohan@gnu.org>
4858
4859 Fix execution of x selection hooks.
4860 * xselect.c (Qx_lost_selection_functions)
4861 (Qx_sent_selection_functions): New vars.
4862 (syms_of_xselect): DEFSYM them.
4863 (x_handle_selection_request): Pass Qx_sent_selection_functions
4864 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4865 (x_handle_selection_clear,x_clear_frame_selections):
4866 Pass Qx_lost_selection_functions rather than
4867 Vx_lost_selection_functions to Frun_hook_with_args.
4868
47ea7f44
PE
48692011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4870
ac389d0c 4871 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4872 The old code sometimes used this field without initializing it.
4873
47ea7f44
PE
4874 * alloc.c (gc_sweep): Don't read past end of array.
4875 In theory, the old code could also have corrupted Emacs internals,
4876 though it'd be very unlikely.
4877
bc985c87
AS
48782011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4879
4880 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4881 argument. (Bug#4026)
bc985c87 4882
0cf34688
LMI
48832011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4884
b3dadd76
LMI
4885 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4886 key" (bug#4257).
4887
0cf34688
LMI
4888 * window.c (Fset_window_start): Doc fix (bug#4199).
4889 (Fset_window_hscroll): Ditto.
4890
270768cd
PE
48912011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4892
077e3dda 4893 Fix minor new problems caught by GCC 4.6.1.
270768cd 4894 * term.c (init_tty): Remove unused local.
490011a6 4895 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4896 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4897 not used otherwise.
270768cd 4898
b1f58454
CY
48992011-07-12 Chong Yidong <cyd@stupidchicken.com>
4900
4901 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4902
22b9578d
LMI
49032011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4904
6e70ab07
LMI
4905 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4906 are the mini-buffer and the echo area (bug#3320).
4907
22b9578d
LMI
4908 * term.c (init_tty): Remove support for supdup, c10 and perq
4909 terminals, which are no longer supported (bug#1482).
4910
8974cc9f
JB
49112011-07-10 Johan Bockgård <bojohan@gnu.org>
4912
4913 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4914
a560d974
JD
49152011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4916
4917 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4918 for non-popups (Bug#3642).
4919
1dae0f0a
AS
49202011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4921
268c2c36 4922 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4923 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4924 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4925 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4926 * data.c (fmod): Likewise.
4927 * dispnew.c (swap_glyphs_in_rows): Likewise.
4928 * emacs.c (memory_warning_signal): Likewise.
4929 * floatfns.c (float_error): Likewise.
4930 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4931 (otf_open, font_otf_capability, generate_otf_features)
4932 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4933 Likewise.
4934 * image.c (pbm_read_file): Likewise.
4935 * indent.c (string_display_width): Likewise.
4936 * intervals.c (check_for_interval, search_for_interval)
4937 (inc_interval_count, count_intervals, root_interval)
4938 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4939 * lread.c (defalias): Likewise.
268c2c36 4940 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4941 * regex.c (set_image_of_range_1, set_image_of_range)
4942 (regex_grow_registers): Likewise.
4943 * sysdep.c (strerror): Likewise.
4944 * termcap.c (valid_filename_p, tprint, main): Likewise.
4945 * tparam.c (main): Likewise.
4946 * unexhp9k800.c (run_time_remap, save_data_space)
4947 (update_file_ptrs, read_header, write_header, calculate_checksum)
4948 (copy_file, copy_rest, display_header): Likewise.
4949 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4950 Likewise.
4951 * xdisp.c (check_it): Likewise.
4952 * xfaces.c (register_color, unregister_color, unregister_colors):
4953 Likewise.
4954 * xfns.c (print_fontset_result): Likewise.
4955 * xrdb.c (member, fatal, main): Likewise.
4956
99033785
PE
49572011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 Fix minor problems found by static checking (Bug#9031).
4960 * chartab.c (char_table_set_range, map_sub_char_table):
4961 Remove unused locals.
4962 (uniprop_table): Now static.
4963 * composite.c (_work_char): Remove unused static var.
4964
9cb2ac56
JB
49652011-07-09 Juanma Barranquero <lekktu@gmail.com>
4966
4967 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4968
f25661f0
JD
49692011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4970
4971 * gtkutil.c (qttip_cb): Remove code without function.
4972
8278c4fe
EZ
49732011-07-09 Eli Zaretskii <eliz@gnu.org>
4974
4975 * w32.c (pthread_sigmask): New stub.
4976
1692ae2d 49772011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4978
8a6ebd58 4979 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4980 sigprocmask is portable only for single-threaded applications, and
4981 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4982 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4983 (LIBES): Use it.
4984 * callproc.c (Fcall_process):
4985 * process.c (create_process):
4986 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4987 Use pthread_sigmask, not sigprocmask.
123403e4 4988
1b854618
JD
49892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4990
4991 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4992 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4993 wrong (Bug#8591).
4994
3fe4b549
JD
49952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4996
0ce7e563
JD
4997 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4998 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4999 (xg_hide_tooltip): Fix comment.
5000
3fe4b549
JD
5001 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5002 in registerServicesMenuSendTypes.
5003 (validRequestorForSendType): Don't check ns_return_types.
5004
5005 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5006 ns_return_type.
5007
5df75e47
JR
50082011-07-08 Jason Rumney <jasonr@gnu.org>
5009
22610910
JR
5010 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5011 SH_SHOW for hidden windows (Bug#5482).
5012
5df75e47
JR
5013 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5014 frame struct members of non-existent frames (Bug#6284).
5015
699c10bd
JD
50162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5017
4393663b
JD
5018 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5019 variable firstTime not needed on OSX >= 10.6.
5020 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5021 >= 10.5. Use setKnobProportion, setDoubleValue.
5022
5023 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5024 (MAC_OS_X_VERSION_10_5): Define if not defined.
5025 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5026 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5027 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5028
5029 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5030 cString and lossyCString on OSX >= 10.4
5031
58179cce 5032 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5033 sizeToFit on OSX >= 10.2.
5034
5035 * nsimage.m (allocInitFromFile): Don't use deprecated method
5036 bestRepresentationForDevice on OSX >= 10.6.
5037
5038 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5039 to avoid warning.
5040
5041 * emacs.c: Declare unexec_init_emacs_zone.
5042
a63e0781
JD
5043 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5044
699c10bd
JD
5045 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5046
5047 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5048 on svcsMenu (Bug#8842).
5049
5050 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5051 ns_return_types.
5052 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5053
5054 * nsterm.m (QUTF8_STRING): Declare.
5055 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5056 (validRequestorForSendType): Return type is (id).
5057 Change indexOfObjectIdenticalTo to indexOfObject.
5058 Check if we have local selection before returning self (Bug#8842).
5059 (writeSelectionToPasteboard): Put local selection into paste board
5060 if we have a local selection (Bug#8842).
5061 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5062
5063 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5064 (ns_get_local_selection): Declare.
5065
54e10184
LMI
50662011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5067
9888ff71
LMI
5068 * keymap.c (describe_map_tree): Don't insert a double newline at
5069 the end of the buffer (bug#1169) and return whether we inserted
5070 something.
5071
54e10184
LMI
5072 * callint.c (Fcall_interactively): Change "reading args" to
5073 "providing args" to try to clarify what it does (bug#1010).
5074
15fa4783
KH
50752011-07-07 Kenichi Handa <handa@m17n.org>
5076
5077 * composite.c (composition_compute_stop_pos): Ignore a static
5078 composition starting before CHARPOS (Bug#8915).
5079
5080 * xdisp.c (handle_composition_prop): Likewise.
5081
a8815b00
EZ
50822011-07-07 Eli Zaretskii <eliz@gnu.org>
5083
5084 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5085 (Bug#9015)
5086
ef7b981d 50872011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5088
5089 * character.h (unicode_category_t): New enum type.
5090
5091 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5092 (Qchar_code_property_table): New variable.
5093 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5094 (UNIPROP_COMPRESSED_FORM_P): New macros.
5095 (char_table_ascii): Uncompress the compressed values.
5096 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5097 Uncompress the compressed values.
ac389d0c 5098 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5099 (char_table_ref_and_range): Uncompress the compressed values.
5100 (sub_char_table_set): New arg is_uniprop. Callers changed.
5101 Uncompress the compressed values.
5102 (sub_char_table_set_range): Args changed. Callers changed.
5103 (char_table_set_range): Adjuted for the above change.
5104 (map_sub_char_table): Delete args default_val and parent. Add arg
5105 top. Give decoded values to a Lisp function.
640c8776 5106 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5107 values to a Lisp function. Gcpro more variables.
5108 (uniprop_table_uncompress)
5109 (uniprop_decode_value_run_length): New functions.
5110 (uniprop_decoder, uniprop_decoder_count): New variables.
5111 (uniprop_get_decoder, uniprop_encode_value_character)
5112 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5113 New functions.
5114 (uniprop_encoder, uniprop_encoder_count): New variables.
5115 (uniprop_get_encoder, uniprop_table)
5116 (Funicode_property_table_internal, Fget_unicode_property_internal)
5117 (Fput_unicode_property_internal): New functions.
5118 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5119 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5120 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5121 char-code-property-alist.
5122
640c8776 5123 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5124 Vunicode_category_table.
5125
640c8776 5126 * font.c (font_range): Adjust for the change of
c805dec0
KH
5127 Vunicode_category_table.
5128
76b397fb
DN
51292011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5130
5131 * m/iris4d.h: Remove file, move contents ...
5132 * s/irix6-5.h: ... here.
5133
22b4128e
PE
51342011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5135
5136 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5137 * alloc.c (mark_buffer):
5138 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5139 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5140 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5141 This isn't true in general, and it's particularly not true
5142 if Emacs is configured with --with-wide-int.
5143 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5144 New macros, used in the buffer.c change.
5145
869795d6
JD
51462011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5147
5148 * xsettings.c: Use both GConf and GSettings if both are available.
5149 (store_config_changed_event): Add comment.
5150 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5151 (store_tool_bar_style_changed): New functions.
5e617bc2 5152 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5153 (struct xsettings): Move font inside HAVE_XFT.
5154 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5155 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5156 Move inside HAVE_XFT.
640c8776 5157 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5158 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5159 also.
5160 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5161 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5162 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5163 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5164 (parse_settings): Move check for font inside HAVE_XFT.
5165 (read_settings, apply_xft_settings): Add comment.
5166 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5167 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5168 call store_font_name_changed.
5169 (xft_settings_event): Add comment.
5170 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5171 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5172 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5173 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5174 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5175 (xsettings_get_system_font, xsettings_get_system_normal_font):
5176 Add comment.
869795d6 5177
d8ed26bd
PE
51782011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5179
5180 Random fixes. E.g., (random) never returned negative values.
5181 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5182 subseconds part to the entropy, as that's a bit more random.
5183 Prefer signed to unsigned, since the signedness doesn't matter and
5184 in general we prefer signed. When given a limit, use a
5185 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5186 latter isn't right if USE_2_TAGS_FOR_INTS.
5187 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5188 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5189
cabf1cac
SM
51902011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5191
5192 * textprop.c (text_property_stickiness):
5193 Obey Vtext_property_default_nonsticky.
5194 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5195 * w32fns.c (syms_of_w32fns):
5196 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5197
6e9b2be9
PE
51982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5199
5200 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5201 This is more efficient than Ffile_directory_p and avoids a minor race.
5202
90186c68
LMI
52032011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5204
7c301272
LMI
5205 * buffer.c (Foverlay_put): Say what the return value is
5206 (bug#7835).
5207
c4f2d8d4
LMI
5208 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5209 is a directory before asking whether to use the file name
5210 (bug#7564).
ad637907
LMI
5211 (barf_or_query_if_file_exists): Make the "File is a directory"
5212 error be more correct.
c4f2d8d4 5213
90186c68
LMI
5214 * fns.c (Frequire): Remove the mention of the .gz files, since
5215 that's installation-specific, but keep the mention of
5216 `get-load-suffixes'.
5217
da64016e
PE
52182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5219
5220 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5221 Report string overflow if the output is too long.
5222
7d47b580
JB
52232011-07-04 Juanma Barranquero <lekktu@gmail.com>
5224
a555cb87
JB
5225 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5226 (syms_of_gnutls): Remove duplicate DEFSYM for
5227 Qgnutls_bootprop_verify_hostname_error, an error for
5228 Qgnutls_bootprop_verify_error (which is no longer used).
5229
7d47b580
JB
5230 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5231 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5232 Also (re)move comments that are misplaced or no longer relevant.
5233
1e49bfab
LMI
52342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5235
5236 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5237
1485f4c0
CY
52382011-07-03 Chong Yidong <cyd@stupidchicken.com>
5239
5240 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5241 and background color parameters if they have been changed.
5242
a9ab721e
LMI
52432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5244
5245 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5246
cf7cff57
PE
52472011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5248
2e13213d
PE
5249 * xsettings.c (SYSTEM_FONT): Define only when used.
5250 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5251
cf7cff57
PE
5252 * keymap.c (access_keymap_1): Now static.
5253
7a8e04f7
CY
52542011-07-02 Chong Yidong <cyd@stupidchicken.com>
5255
5256 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5257 leave any prefix arg for the up event (Bug#1586).
5258
61352f62
LMI
52592011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5260
69bb1ef7
LMI
5261 * lread.c (syms_of_lread): Mention single symbols defined by
5262 `defvar' or `defconst' (bug#7154).
5263
61352f62 5264 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5265 (Frequire): Mention get-load-suffixes.
61352f62 5266
28545e04
MR
52672011-07-02 Martin Rudalics <rudalics@gmx.at>
5268
5269 * window.h (window): Remove clone_number slot.
5270 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5271 Remove.
5272 (make_parent_window, make_window, saved_window)
5273 (Fset_window_configuration, save_window_save): Don't deal with
5274 clone numbers.
5275 * buffer.c (Qclone_number): Remove declaration.
5276 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5277
3349e122
SM
52782011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5279
5280 Add multiple inheritance to keymaps.
5281 * keymap.c (Fmake_composed_keymap): New function.
5282 (Fset_keymap_parent): Simplify.
5283 (fix_submap_inheritance): Remove.
5284 (access_keymap_1): New function extracted from access_keymap to handle
5285 embedded parents and handle lists of maps.
5286 (access_keymap): Use it.
5287 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5288 (Fcopy_keymap): Handle embedded parents.
5289 (Fcommand_remapping, define_as_prefix): Simplify.
5290 (Fkey_binding): Simplify.
5291 (syms_of_keymap): Move minibuffer-local-completion-map,
5292 minibuffer-local-filename-completion-map,
5293 minibuffer-local-must-match-map, and
5294 minibuffer-local-filename-must-match-map to Elisp.
5295 (syms_of_keymap): Defsubr make-composed-keymap.
5296 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5297 (parse_menu_item): Trivial simplification.
5298
3279eb87
GM
52992011-07-01 Glenn Morris <rgm@gnu.org>
5300
5301 * Makefile.in (SETTINGS_LIBS): Fix typo.
5302
4550efdf
KI
53032011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5304
5305 * coding.c (Fencode_coding_string): Record the last coding system
5306 used, as the function doc string says (bug#8738).
5307
0949d2b6
JD
53082011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5309
5310 * xsettings.c (store_monospaced_changed): Take new font as arg and
5311 check for change against current_mono_font.
5312 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5313 (emacs_settings_constructor, emacs_settings_get_property)
5314 (emacs_settings_set_property, emacs_settings_class_init)
5315 (emacs_settings_init, gsettings_obj): Remove.
5316 (something_changedCB): New function for HAVE_GSETTINGS.
5317 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5318 with value as argument.
5319 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5320 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5321 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5322 "changed".
5323
5324 * xgselect.c: Add defined (HAVE_GSETTINGS).
5325 (xgselect_initialize): Ditto.
5326
5327 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5328 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5329 xg_select.
5330
bbc6b304
PE
53312011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 * eval.c (struct backtrace): Simplify and port the data structure.
5334 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5335 signed bit field, as this assumption is not portable and it makes
5336 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5337 "char debug_on_exit : 1" as this is not portable either; instead,
5338 use the portable "unsigned int debug_on_exit : 1". Remove unused
5339 member evalargs. Remove obsolete comments about cc bombing out.
5340
9851bfc5
JD
53412011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5342
51bb811f 5343 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5344 Let HAVE_GSETTINGS override HAVE_GCONF.
5345 (store_monospaced_changed): New function.
5346 (EMACS_SETTINGS): A new type derived from GObject to handle
5347 GSettings notifications.
5348 (emacs_settings_constructor, emacs_settings_get_property)
5349 (emacs_settings_set_property, emacs_settings_class_init):
5350 New functions.
5351 (gsettings_client, gsettings_obj): New variables.
5352 (GSETTINGS_SCHEMA): New define.
5353 (something_changedCB): Call store_monospaced_changed.
5354 (init_gsettings): New function.
5355 (xsettings_initialize): Call init_gsettings.
5356 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5357 to NULL.
5358
640c8776 5359 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5360 GCONF_CFLAGS/LIBS.
5361
5386012d
MR
53622011-06-29 Martin Rudalics <rudalics@gmx.at>
5363
5364 * window.c (resize_root_window, grow_mini_window)
5365 (shrink_mini_window): Rename Qresize_root_window to
5366 Qwindow_resize_root_window and Qresize_root_window_vertically to
5367 Qwindow_resize_root_window_vertically.
5368
f13e0b08
PE
53692011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5370
5371 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5372
94515237
JB
53732011-06-27 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * makefile.w32-in: Redesign dependencies so they reflect more
5376 clearly which files are directly included by each source file,
5377 and not through other includes.
5378
e43b6e43
MR
53792011-06-27 Martin Rudalics <rudalics@gmx.at>
5380
5381 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5382 (sort_overlays, overlay_strings): When an overlay's clone number
5383 matches the window's clone number process the overlay even if
5384 the overlay's window property doesn't match the current window.
5385
d68443dc
MR
5386 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5387 (Fwindow_hchild): Rename to Fwindow_left_child.
5388 (Fwindow_next): Rename to Fwindow_next_sibling.
5389 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5390 (resize_window_check): Rename to window_resize_check.
5391 (resize_window_apply): Rename to window_resize_apply.
5392 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5393 (Fdelete_other_windows_internal, resize_frame_windows)
5394 (Fsplit_window_internal, Fdelete_window_internal)
5395 (grow_mini_window, shrink_mini_window)
5396 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5397
c7e73be5
JD
53982011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5399
5400 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5401 (emacs_fixed_set_min_size): Remove.
5402 (emacs_fixed_new): Take frame as argument.
5403
5404 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5405 (_EmacsFixedPrivate): Remove minwidth/height.
5406 Add struct frame *f.
5407 (emacs_fixed_init): Initialize priv->f.
5408 (get_parent_class, emacs_fixed_set_min_size): Remove.
5409 (emacs_fixed_new): Set priv->f to argument.
5410 (emacs_fixed_get_preferred_width)
5411 (emacs_fixed_get_preferred_height): Use min_width/height from
5412 frames size_hint to set minimum and natural (Bug#8919).
5413 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5414 and use min_width/height from frames size_hint to set
5415 min_width/height (Bug#8919).
5416
5417 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5418 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5419 Fix indentation.
c7e73be5 5420
cf99dcf8
EZ
54212011-06-26 Eli Zaretskii <eliz@gnu.org>
5422
5423 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5424 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5425 called at ZV.
5426
029529ac
CY
54272011-06-26 Chong Yidong <cyd@stupidchicken.com>
5428
5429 * process.c (wait_reading_process_output): Bypass select if
5430 waiting for a cell while ignoring keyboard input, and input is
5431 pending. Suggested by Jan Djärv (Bug#8869).
5432
7a7ef429
PE
54332011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5434
5435 Use gnulib's dup2 module instead of rolling our own.
5436 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5437
11fdef7d 54382011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5439
5440 * dispnew.c (scrolling_window): Before scrolling, turn off a
5441 mouse-highlight in the window being scrolled.
5442
cd3520a4
JB
54432011-06-24 Juanma Barranquero <lekktu@gmail.com>
5444
5445 Move DEFSYM to lisp.h and use everywhere.
5446
5447 * character.h (DEFSYM): Move declaration...
5448 * lisp.h (DEFSYM): ...here.
5449
5450 * gnutls.c:
5451 * minibuf.c:
5452 * w32menu.c:
5453 * w32proc.c:
5454 * w32select.c: Don't include character.h.
5455
5456 * alloc.c (syms_of_alloc):
5457 * buffer.c (syms_of_buffer):
5458 * bytecode.c (syms_of_bytecode):
5459 * callint.c (syms_of_callint):
5460 * casefiddle.c (syms_of_casefiddle):
5461 * casetab.c (init_casetab_once):
5462 * category.c (init_category_once, syms_of_category):
5463 * ccl.c (syms_of_ccl):
5464 * cmds.c (syms_of_cmds):
5465 * composite.c (syms_of_composite):
5466 * dbusbind.c (syms_of_dbusbind):
5467 * dired.c (syms_of_dired):
5468 * dispnew.c (syms_of_display):
5469 * doc.c (syms_of_doc):
5470 * editfns.c (syms_of_editfns):
5471 * emacs.c (syms_of_emacs):
5472 * eval.c (syms_of_eval):
5473 * fileio.c (syms_of_fileio):
5474 * fns.c (syms_of_fns):
5475 * frame.c (syms_of_frame):
5476 * fringe.c (syms_of_fringe):
5477 * insdel.c (syms_of_insdel):
5478 * keymap.c (syms_of_keymap):
5479 * lread.c (init_obarray, syms_of_lread):
5480 * macros.c (syms_of_macros):
5481 * msdos.c (syms_of_msdos):
5482 * print.c (syms_of_print):
5483 * process.c (syms_of_process):
5484 * search.c (syms_of_search):
5485 * sound.c (syms_of_sound):
5486 * syntax.c (init_syntax_once, syms_of_syntax):
5487 * terminal.c (syms_of_terminal):
5488 * textprop.c (syms_of_textprop):
5489 * undo.c (syms_of_undo):
5490 * w32.c (globals_of_w32):
5491 * window.c (syms_of_window):
5492 * xdisp.c (syms_of_xdisp):
5493 * xfaces.c (syms_of_xfaces):
5494 * xfns.c (syms_of_xfns):
5495 * xmenu.c (syms_of_xmenu):
5496 * xsettings.c (syms_of_xsettings):
5497 * xterm.c (syms_of_xterm): Use DEFSYM.
5498
4228cf16
TZ
54992011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5500
cd3520a4 5501 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5502
7fcccf1e
PE
55032011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5504
7efb4e0e
PE
5505 Integer and buffer overflow fixes (Bug#8873).
5506
ff5844ad
PE
5507 * print.c (printchar, strout): Check for string overflow.
5508 (PRINTPREPARE, printchar, strout):
5509 Don't set size unless allocation succeeds.
5510
90532f02
PE
5511 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5512 for sizes. Check for string overflow more accurately.
5513 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5514
6d84508d
PE
5515 * macros.c: Integer and buffer overflow fixes.
5516 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5517 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5518 Use ptrdiff_t, not int, for sizes.
5519 Don't increment bufsize until after realloc succeeds.
5520 Check for size-calculation overflow.
5521 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5522
437b2cb4
PE
5523 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5524
8b9ac8b4
PE
5525 * lread.c: Integer overflow fixes.
5526 (read_integer): Radix is now EMACS_INT, not int,
5527 to improve quality of diagnostics for out-of-range radices.
5528 Calculate buffer size correctly for out-of-range radices.
5529 (read1): Check for integer overflow in radices, and in
5530 read-circle numbers.
82cb60d3
PE
5531 (read_escape): Avoid int overflow.
5532 (Fload, openp, read_buffer_size, read1)
5533 (substitute_object_recurse, read_vector, read_list, map_obarray):
5534 Use ptrdiff_t, not int, for sizes.
5535 (read1): Use EMACS_INT, not int, for sizes.
20270765 5536 Check for size overflow.
8b9ac8b4 5537
7fcccf1e
PE
5538 * image.c (cache_image): Check for size arithmetic overflow.
5539
bfbbd7e7
PE
5540 * lread.c: Integer overflow issues.
5541 (saved_doc_string_size, saved_doc_string_length)
5542 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5543 Now ptrdiff_t, not int.
5544 (read1): Don't assume doc string length fits in int. Check for
5545 out-of-range doc string lengths.
5546 (read_list): Don't assume file position fits in int.
39019e54 5547 (read_escape): Check for hex character overflow.
bfbbd7e7 5548
4e323265
LL
55492011-06-22 Leo Liu <sdl.web@gmail.com>
5550
5551 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5552 Move to minibuffer.el.
5553
85fece3e
PE
55542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5555
20b84ce9 5556 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5557 The following patches are for when GLYPH_DEBUG && !XASSERT.
5558 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5559 * dispnew.c (flush_stdout):
5560 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5561 Mark as externally visible.
5562 * dispnew.c (check_window_matrix_pointers): Now static.
5563 * dispnew.c (window_to_frame_vpos):
5564 * xfns.c (unwind_create_frame):
5565 * xterm.c (x_check_font): Remove unused local.
5566 * scroll.c (CHECK_BOUNDS):
5567 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5568 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5569 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5570 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5571 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5572 Now static.
5573 (debug_method_add): Use va_list and vsprintf rather than relying
5574 on undefined behavior with wrong number of arguments.
5575 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5576 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5577 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5578 since we're not interested in debugging glyphs with old libraries.
5579 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5580 GCC 4.6.0's static checking.
5581
0766b489
PE
55822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5583
31fd4b32
PE
5584 Integer overflow and signedness fixes (Bug#8873).
5585 A few related buffer overrun fixes, too.
5586
b79e8648
PE
5587 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5588
0766b489
PE
5589 * dispextern.h (struct face.stipple):
5590 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5591 (x_bitmap_mask, x_allocate_bitmap_record)
5592 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5593 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5594 (x_create_bitmap_from_xpm_data):
5595 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5596 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5597 (.bitmaps_last):
5598 * xfaces.c (load_pixmap):
5599 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5600 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5601 (.bitmaps_last, struct x_output.icon_bitmap):
5602 Use ptrdiff_t, not int, for bitmap indexes.
5603 (x_allocate_bitmap_record): Check for size overflow.
5604 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5605
b081724f
PE
5606 Use ptrdiff_t, not int, for overlay counts.
5607 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5608 * editfns.c (overlays_around, get_pos_property):
5609 * textprop.c (get_char_property_and_overlay):
5610 * xdisp.c (next_overlay_change, note_mouse_highlight):
5611 * xfaces.c (face_at_buffer_position):
21514da7
PE
5612 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5613 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5614 (Fnext_overlay_change, Fprevious_overlay_change)
5615 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5616 Use ptrdiff_t, not int, for sizes.
21514da7 5617 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5618
3de73e5e
PE
5619 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5620
2606c57b
PE
5621 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5622 (x_session_initialize): Do not assume string length fits in int.
5623
aaafe47a
PE
5624 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5625 This is unlikely, but can occur if DPI is outlandish.
5626
2674ddc8 5627 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5628 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5629
28154962
PE
5630 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5631 * xrdb.c (magic_file_p, search_magic_path):
5632 Omit last arg SUFFIX; it was always 0. All callers changed.
5633 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5634
7de51af5
PE
5635 * xfont.c (xfont_match): Avoid need for strlen.
5636
25ed6cc3
PE
5637 * xfns.c: Don't assume strlen fits in int.
5638 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5639
4eab31dd
PE
5640 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5641 not unsigned long, as we prefer signed integers. All callers changed.
5642 Detect integer overflow in repeat count.
5643 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5644 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5645
171e2a58
PE
5646 * termcap.c: Don't assume sizes fit in int and never overflow.
5647 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5648 (gobble_line): Check for size-calculation overflow.
5649
ad39faca 5650 * minibuf.c (Fread_buffer):
6e5bb2dc 5651 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5652 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5653 Don't assume string length fits in int.
5654
52c61c22 5655 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5656 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5657
b5b8c9e5
PE
5658 * font.c: Don't assume string length fits in int.
5659 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5660 Use ptrdiff_t, not int.
ccd6111c
PE
5661 (font_intern_prop): Don't assume string length fits in int.
5662 Don't assume integer property fits in fixnum.
5663 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5664
882f0d81 5665 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5666 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5667 Reformulate so as not to need the command string.
5668 Invoke gzip -cd rather than gunzip, as it's more portable.
5669 (lock_info_type, lock_file_1, lock_file):
5670 Don't assume pid_t and time_t fit in unsigned long.
5671 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5672 (current_lock_owner): Prefer signed type for sizes.
5673 Use memcpy, not strncpy, where memcpy is what is really wanted.
5674 Don't assume (via atoi) that time_t and pid_t fit in int.
5675 Check for time_t and/or pid_t out of range, e.g., via a network share.
5676 Don't alloca where an auto var works fine.
5677
93f4cf88
PE
5678 * fileio.c: Fix some integer overflow issues.
5679 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5680 Don't assume string length fits in int.
5681 (directory_file_name): Don't assume string length fits in long.
5682 (make_temp_name): Don't assume pid fits in int, or that its print
5683 length is less than 20.
5684
f3e92b69
PE
5685 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5686
1bfdaf10
PE
5687 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5688
35016e9a
PE
5689 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5690
3d1e65a1
PE
5691 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5692 We prefer signed integers, even for size calculations.
5693
0b963a93
PE
5694 * emacs.c: Don't assume string length fits in 'int'.
5695 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5696 (main): Don't invoke strlen when not needed.
5697
573f4b54
PE
5698 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5699 (XD_DEBUG_MESSAGE): Don't waste a byte.
5700
989f33ba
PE
5701 * callproc.c (getenv_internal_1, getenv_internal)
5702 (Fgetenv_internal):
965d34eb
PE
5703 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5704
e4d29b33
PE
5705 * lread.c (invalid_syntax): Omit length argument.
5706 All uses changed. This doesn't fix a bug, but it simplifies the
5707 code away from its former Hollerith-constant appearance, and it's
5708 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5709 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5710
eb49b136
PE
5711 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5712 This didn't break anything, but it didn't help either.
5713 It's confusing to put a bogus integer in a place where the actual
5714 value does not matter.
9f62aeb1 5715 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5716 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5717
15375a22
PE
5718 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5719 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5720 implementation.
b61cc01c
PE
5721 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5722 We prefer signed types, and the value cannot exceed the EMACS_INT
5723 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5724 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5725 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5726 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5727
53b2623d
PE
5728 * indent.c (sane_tab_width): New function.
5729 (current_column, scan_for_column, Findent_to, position_indentation)
5730 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5731 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5732
51cab52b 5733 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5734
f2ed8a70
PE
5735 * lisp.h (lint_assume): New macro.
5736 * composite.c (composition_gstring_put_cache):
5737 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5738
abe80cc6
PE
5739 * editfns.c, insdel.c:
5740 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5741
b02c740e
PE
5742 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5743
ebc96716
PE
5744 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5745
b4e50fa0 5746 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5747 Use much-faster test for byte-length change.
311d5d7c 5748 Don't assume string byte-length fits in 'int'.
a4cf38e4 5749 Check that character arg fits in 'int'.
85461888 5750 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5751
c0c1ee9f
PE
5752 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5753
a498d7f4
PE
5754 * fns.c (concat): Catch string overflow earlier.
5755 Do not rely on integer wraparound.
5756
51cab52b
PE
5757 * dispextern.h (struct it.overlay_strings_charpos)
5758 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5759 * xdisp.c (forward_to_next_line_start)
5760 (back_to_previous_visible_line_start)
5761 (reseat_at_next_visible_line_start, next_element_from_buffer):
5762 Don't arbitrarily truncate the value of 'selective' to int.
5763
76031fad
PE
5764 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5765
5eb55db9
PE
5766 * composite.c: Don't truncate sizes to 'int'.
5767 (composition_gstring_p, composition_reseat_it)
5768 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5769 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5770 not EMACS_UINT, for indexes.
5eb55db9 5771
0703a717
PE
5772 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5773
d6202519
PE
5774 * buffer.c: Include <verify.h>.
5775 (struct sortvec.priority, struct sortstr.priority):
8961a454 5776 Now EMACS_INT, not int.
c20998a7 5777 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5778 (struct sortstr.size, record_overlay_string)
5779 (struct sortstrlist.size, struct sortlist.used):
5780 Don't truncate size to int.
5781 (record_overlay_string): Check for size-calculation overflow.
d6202519 5782 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5783
d5a19415
JM
57842011-06-22 Jim Meyering <meyering@redhat.com>
5785
029529ac 5786 Don't leak an XBM-image-sized buffer
d5a19415
JM
5787 * image.c (xbm_load): Free the image buffer after using it.
5788
a9041e6c
PE
57892011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5790
5791 Port to Sun C.
5792 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5793 that Sun C diagnosed.
5794 * fns.c (secure_hash): Fix pointer signedness issue.
5795 * intervals.c (static_offset_intervals): New function.
5796 (offset_intervals): Use it.
5797
7f3f739f
LL
57982011-06-21 Leo Liu <sdl.web@gmail.com>
5799
5800 * deps.mk (fns.o):
5801 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5802 sha512.h.
5803
5804 * fns.c (secure_hash): Rename from crypto_hash_function and change
5805 the first arg to accept symbols.
5b66d427 5806 (Fsecure_hash): New primitive.
7f3f739f
LL
5807 (syms_of_fns): New symbols.
5808
76147d94
DD
58092011-06-20 Deniz Dogan <deniz@dogan.se>
5810
5811 * process.c (Fset_process_buffer): Clarify return value in
5812 docstring.
5813
7d7d0045
CY
58142011-06-18 Chong Yidong <cyd@stupidchicken.com>
5815
5816 * dispnew.c (add_window_display_history): Use BVAR.
5817
5818 * xdisp.c (debug_method_add): Use BVAR.
5819 (check_window_end, dump_glyph_matrix, dump_glyph)
5820 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5821
5822 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5823 Likewise.
5824
5825 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5826 check till after the cache is created in init_frame_faces.
5827
ff2bc410
SM
58282011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5829
5830 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5831
28177add
PE
58322011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5833
dd3482fe
PE
5834 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5835 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5836 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5837
393d71f3 5838 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5839 * fileio.c (Finsert_file_contents):
5840 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5841 Remove the old (too-loose) buffer overflow checks.
5842 They weren't needed, since make_gap checks for buffer overflow.
5843 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5844 The old code merely checked for Emacs fixnum overflow, and relied
5845 on undefined (wraparound) behavior. The new code avoids undefined
5846 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5847
2e6813b0 5848 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5849 Tune. Don't use wider integers than needed. Don't use alloca.
5850 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5851
599a9e4f
PE
5852 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5853
99561444
PE
5854 * insdel.c, lisp.h (buffer_overflow): New function.
5855 (insert_from_buffer_1, replace_range, replace_range_2):
5856 * insdel.c (make_gap_larger):
5857 * editfns.c (Finsert_char):
5858 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5859
28177add
PE
5860 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5861
e69dafad
PE
58622011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5863
4baa020d 5864 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5865
b1c46f02
PE
5866 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5867 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5868
e69dafad
PE
5869 * fileio.c: Don't assume EMACS_INT fits in off_t.
5870 (emacs_lseek): New static function.
5871 (Finsert_file_contents, Fwrite_region): Use it.
5872 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5873
566684ea
PE
5874 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5875
e6966cd6
PE
5876 * fns.c: Don't overflow int when computing a list length.
5877 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5878 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5879 truncation on 64-bit hosts. Check for QUIT every
5880 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5881 faster and is responsive enough.
5882 (Flength): Report an error instead of overflowing an integer.
5883 (Fsafe_length): Return a float if the value is not representable
5884 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5885 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5886 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5887
dd0b0efb
PE
5888 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5889 (header_size, word_size): New constants.
5890 (allocate_vectorlike): Don't check size overflow here.
5891 (allocate_vector): Check it here instead, since this is the only
5892 caller of allocate_vectorlike that could cause overflow.
5893 Check that the new vector's length is representable as a fixnum.
5894
86fe5cfe
PE
5895 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5896 The previous code was bogus. For example, next_almost_prime (32)
5897 returned 39, which is undesirable as it is a multiple of 3; and
5898 next_almost_prime (24) returned 25, which is a multiple of 5 so
5899 why was the code bothering to check for multiples of 7?
5900
80e88859
PE
5901 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5902
4a2f0ad6
PE
5903 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5904
f66c7cf8
PE
5905 Variadic C functions now count arguments with ptrdiff_t.
5906 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5907 Back then I didn't know that the Emacs coding style prefers signed int.
5908 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5909 were being counted with int, which may truncate counts on 64-bit
5910 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5911 * lisp.h (struct Lisp_Subr.function.aMANY)
5912 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5913 Arg counts are now ptrdiff_t, not size_t.
5914 All variadic functions and their callers changed accordingly.
5915 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5916 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5917 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5918 * callint.c (Fcall_interactively): Check arg count for overflow,
5919 to avoid potential buffer overrun. Use signed char, not 'int',
5920 for 'varies' array, so that we needn't bother to check its size
5921 calculation for overflow.
5922 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5923 * eval.c (apply_lambda):
5924 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5925 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5926 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5927
a1759b76
PE
5928 * callint.c (Fcall_interactively): Don't use index var as event count.
5929
d96be9fc
PE
5930 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5931 * mem-limits.h (SIZE): Remove; no longer used.
5932
a690a978 5933 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5934
578c21e6
PE
5935 Remove unnecessary casts.
5936 * xterm.c (x_term_init):
5937 * xfns.c (x_set_border_pixel):
5938 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5939 These aren't needed now that we assume ANSI C.
5940
96f53c6c
PE
5941 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5942 It's more likely to cause problems (due to unsigned overflow)
5943 than to cure them.
5944
83c77d31
PE
5945 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5946
ee2079f1
PE
5947 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5948
6da65536
PE
5949 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5950
7147c4a4
PE
5951 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5952
193e32d9
PE
5953 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5954
e5533da6
PE
5955 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5956
9910e595
PE
5957 GLYPH_CODE_FACE returns EMACS_INT, not int.
5958 * dispextern.h (merge_faces):
5959 * xfaces.c (merge_faces):
01103c44
PE
5960 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5961 Don't assume EMACS_INT fits in int.
9910e595 5962
2638320e
PE
5963 * character.h (CHAR_VALID_P): Remove unused parameter.
5964 * fontset.c, lisp.h, xdisp.c: All uses changed.
5965
045eb8d9
PE
5966 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5967
c1f134b5
PE
5968 * fns.c (concat): Minor tuning based on overflow analysis.
5969 This doesn't fix any bugs. Use int to hold character, instead
5970 of constantly refetching from Emacs object. Use XFASTINT, not
5971 XINT, for value known to be a character. Don't bother comparing
5972 a single byte to 0400, as it's always less.
5973
395fcb93 5974 * floatfns.c (Fexpt):
327eeec8
PE
5975 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5976
abbd3d23
PE
5977 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5978 for characters.
5979
684a03ef
PE
5980 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5981
0fed43f3
PE
5982 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5983 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5984 incorrectly succeed when S was a string, because 4294967386 was
5985 truncated before it was used.
5986
8fd02eb7
PE
5987 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5988 Otherwise, an out-of-range integer could cause undefined behavior
5989 on a 64-bit host.
5990
f8c86b69
PE
5991 * composite.c: Use int, not EMACS_INT, for characters.
5992 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5993 EMACS_INT, for values that are known to be in character range.
5994 This doesn't fix any bugs but is the usual style inside Emacs and
5995 may generate better code on 32-bit machines.
5996
34206dd2
PE
5997 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5998 This is for reasons similar to the recent CHAR_STRING fix.
5999 * charset.c (Fencode_char): Check that character arg is actually
6000 a character. Pass an int to ENCODE_CHAR.
6001 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6002 wider than 'int', as a compile-time check to prevent future regressions
6003 in this area.
6004
c5958d4c 6005 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
6006
6007 Make sure a 64-bit char is never passed to CHAR_STRING.
6008 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6009 by silently ignoring the top 32 bits, allowing some values
6010 that were far too large to be valid characters.
6011 * character.h: Include <verify.h>.
6012 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6013 arguments are no wider than unsigned, as a compile-time check
6014 to prevent future regressions in this area.
6015 * data.c (Faset):
01103c44 6016 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6017 (Fsubst_char_in_region):
6018 * fns.c (concat):
6019 * xdisp.c (decode_mode_spec_coding):
6020 Adjust to CHAR_STRING's new requirement.
6021 * editfns.c (Finsert_char, Fsubst_char_in_region):
6022 * fns.c (concat): Check that character args are actually
6023 characters. Without this test, these functions did the wrong
6024 thing with wildly out-of-range values on 64-bit hosts.
6025
d37ca623
PE
6026 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6027 These casts should not be needed on 32-bit hosts, either.
6028 * keyboard.c (read_char):
6029 * lread.c (Fload): Remove casts to unsigned.
6030
ea204efb
PE
6031 * lisp.h (UNSIGNED_CMP): New macro.
6032 This fixes comparison bugs on 64-bit hosts.
6033 (ASCII_CHAR_P): Use it.
6034 * casefiddle.c (casify_object):
01103c44 6035 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6036 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6037 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6038 * dispextern.h (FACE_FROM_ID):
6039 * keyboard.c (read_char): Use UNSIGNED_CMP.
6040
41cb286c
PE
6041 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6042 not to EMACS_INT, to avoid GCC warning.
6043
4a1b9832
PE
6044 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6045
55daad71
PE
6046 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6047 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6048 isn't needed on 32-bit machines.
8f95c75c 6049
01103c44
PE
6050 * buffer.c (Fgenerate_new_buffer_name):
6051 Use EMACS_INT for count, not int.
0ceccced 6052 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6053
6054 * data.c (Qcompiled_function): Now static.
6055
c6f072e7
PE
6056 * window.c (window_body_lines): Now static.
6057
20ce5912
PE
6058 * image.c (gif_load): Rename local to avoid shadowing.
6059
9c4c5f81
PE
6060 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6061 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6062 * alloc.c (make_save_value): Integer argument is now of type
6063 ptrdiff_t, not int.
6064 (mark_object): Use ptrdiff_t, not int.
6065 * lisp.h (pD): New macro.
6066 * print.c (print_object): Use it.
6067
c0c5c8ae
PE
6068 * alloc.c: Use EMACS_INT, not int, to count objects.
6069 (total_conses, total_markers, total_symbols, total_vector_size)
6070 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6071 (total_free_floats, total_floats, total_free_intervals)
6072 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6073 Now EMACS_INT, not int. All uses changed.
6074 (Fgarbage_collect): Compute overall total using a double, so that
6075 integer overflow is less likely to be a problem. Check for overflow
6076 when converting back to an integer.
5a25e253
PE
6077 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6078 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6079 These were 'int' variables that could overflow on 64-bit hosts;
6080 they were never used, so remove them instead of repairing them.
211a0b2a 6081 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6082 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6083 Previously, this ceilinged at INT_MAX, but that doesn't work on
6084 64-bit machines.
e46bb31a 6085 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6086
c78baabf 6087 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6088 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6089 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6090 when a (possibly-narrower) signed value would do just as well.
6091 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6092
c9d624c6
PE
6093 * alloc.c: Catch some string size overflows that we were missing.
6094 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6095 for convenience in STRING_BYTES_MAX.
6096 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6097 The definition here is exact; the one in lisp.h was approximate.
6098 (allocate_string_data): Check for string overflow. This catches
6099 some instances we weren't catching before. Also, it catches
6100 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6101 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6102 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6103
c9d624c6
PE
6104 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6105 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6106 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6107
353032ce
PE
6108 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6109
2bccce07
PE
6110 * alloc.c (Fmake_string): Check for out-of-range init.
6111
0ac30604
SM
61122011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6113
6114 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6115
c195f2de
JD
61162011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6117
6118 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6119 xg_get_default_scrollbar_width.
6120
6121 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6122 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6123 (style_changed_cb): Call update_theme_scrollbar_width and call
6124 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6125 all frames (Bug#8505).
6126 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6127 Call gtk_window_set_resizable if HAVE_GTK3.
6128 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6129 and height if HAVE_GTK3 (Bug#8505).
6130 (scroll_bar_width_for_theme): New variable.
6131 (update_theme_scrollbar_width): New function.
6132 (xg_get_default_scrollbar_width): Move code to
6133 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6134 (xg_initialize): Call update_theme_scrollbar_width.
6135
6136 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6137
6138 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6139
e10ac9f1
MR
61402011-06-12 Martin Rudalics <rudalics@gmx.at>
6141
6142 * frame.c (make_frame): Call other_buffer_safely instead of
6143 other_buffer.
6144
6145 * window.c (temp_output_buffer_show): Call display_buffer with
6146 second argument Vtemp_buffer_show_specifiers and reset latter
6147 immediately after the call.
6148 (Vtemp_buffer_show_specifiers): New variable.
6149 (auto_window_vscroll_p, next_screen_context_lines)
6150 (Vscroll_preserve_screen_position): Remove leading asterisks from
6151 doc-strings.
6152
2d3c217e 61532011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6154
7b7f97e8 6155 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6156 * buffer.c (Qclone_number): Remove for now, as it's unused.
6157 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6158 (record_buffer): Remove unused local.
6159 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6160 (set_frame_buffer_list): Remove; unused.
6161 * frame.h (other_visible_frames): Remove decl.
6162 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6163 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6164 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6165 if HAVE_GPM.
6166 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6167 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6168 Define only if HAVE_GPM.
6169 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6170 (update_hints_inhibit): Remove; never set. All uses removed.
6171 * widgetprv.h (emacsFrameClassRec): Remove decl.
6172 * window.c (delete_deletable_window): Now returns void, since it
6173 wasn't returning anything.
6174 (compare_window_configurations): Remove unused locals.
6175 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6176 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6177 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6178 the same widths as pointers. This follows up on the 2011-05-06 patch.
6179 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6180 * xterm.h: Likewise.
6181 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6182
1384b89e
JB
61832011-06-12 Juanma Barranquero <lekktu@gmail.com>
6184
6185 * makefile.w32-in: Update dependencies.
6186 (LISP_H): Add lib/intprops.h.
6187
1100a63c
CY
61882011-06-11 Chong Yidong <cyd@stupidchicken.com>
6189
6190 * image.c (gif_load): Add animation frame delay to the metadata.
6191 (syms_of_image): Use DEFSYM. New symbol `delay'.
6192
6198ccd0
MR
61932011-06-11 Martin Rudalics <rudalics@gmx.at>
6194
6195 * window.c (delete_deletable_window): Re-add.
6196 (Fset_window_configuration): Rewrite to handle dead buffers and
6197 consequently deletable windows.
6198 (window_tree, Fwindow_tree): Remove. Supply functionality in
6199 window.el.
6200 (compare_window_configurations): Simplify code.
6201
b6e3633c
AS
62022011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6203
1ab0dee5
AS
6204 * image.c (imagemagick_load_image): Fix type mismatch.
6205 (Fimagemagick_types): Likewise.
6206
b6e3633c
AS
6207 * window.h (replace_buffer_in_windows): Declare.
6208
9397e56f
MR
62092011-06-11 Martin Rudalics <rudalics@gmx.at>
6210
6211 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6212 Qclone_number. Remove external declaration of Qdelete_window.
6213 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6214 code.
640c8776
SM
6215 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6216 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6217 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6218 buffer list implementation.
6219 (other_buffer_safely): New function.
6220 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6221 calls to replace_buffer_in_windows and
6222 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6223 if allowed.
6224 (record_buffer): Inhibit quitting and rewrite using quittable
6225 functions. Run Qbuffer_list_update_hook if allowed.
6226 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6227 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6228 Move switch-to-buffer to window.el.
9397e56f
MR
6229 (bury-buffer): Move to window.el.
6230 (Vbuffer_list_update_hook): New variable.
6231
6232 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6233 section.
6234
6235 * window.h (resize_frame_windows): Move up in code.
6236 (Fwindow_frame): Remove EXFUN.
6237 (replace_buffer_in_all_windows): Remove prototype.
6238 (replace_buffer_in_windows_safely): Add prototype.
6239
6240 * window.c: Declare Qdelete_window static again. Move down
6241 declaration of select_count.
6242 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6243 (Fother_window): Move to window.el.
6244 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6245 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6246 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6247 window.el.
6248 (replace_buffer_in_windows): Implement by calling
6249 Qreplace_buffer_in_windows.
6250 (replace_buffer_in_all_windows): Remove with some functionality
6251 moved into replace_buffer_in_windows_safely.
6252 (replace_buffer_in_windows_safely): New function.
6253 (select_window_norecord, select_frame_norecord): Move in front
6254 of run_window_configuration_change_hook. Remove now obsolete
6255 declarations.
640c8776
SM
6256 (Fset_window_buffer): Rewrite doc-string.
6257 Call Qrecord_window_buffer.
9397e56f
MR
6258 (keys_of_window): Move binding for other-window to window.el.
6259
b50691aa
CY
62602011-06-11 Chong Yidong <cyd@stupidchicken.com>
6261
6262 * dispextern.h (struct image): Replace data member, whose int_val
6263 and ptr_val fields were not used by anything, with a single
6264 lisp_val object.
6265
6266 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6267 (gif_clear_image, gif_load, imagemagick_load_image)
6268 (gs_clear_image, gs_load): Callers changed.
6269
3f754b86
PE
62702011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6271
cca69397
PE
6272 * buffer.h: Include <time.h>, for time_t.
6273 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6274
109e28d0
PE
6275 Fix minor problems found by static checking.
6276
60737f02
PE
6277 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6278
4b66faf3
PE
6279 Make identifiers static if they are not used in other modules.
6280 * data.c (Qcompiled_function, Qframe, Qvector):
6281 * image.c (QimageMagick, Qsvg):
6282 * minibuf.c (Qmetadata):
6283 * window.c (resize_window_check, resize_root_window): Now static.
6284 * window.h (resize_window_check, resize_root_window): Remove decls.
6285
109e28d0
PE
6286 * window.c (window_deletion_count, delete_deletable_window):
6287 Remove; unused.
46a4ce9e
PE
6288 (window_body_lines): Now static.
6289 (Fdelete_other_windows_internal): Mark vars as initialized.
6290 Make sure 'resize_failed' is initialized.
6291 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6292 (resize_window_apply): Remove unused local.
6293 * window.h (delete_deletable_window): Remove decl.
6294
109e28d0 6295 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6296 (imagemagick_load_image): Fix pointer signedness problem by changing
6297 last arg from unsigned char * to char *. All uses changed.
6298 Also, fix a local for similar reasons.
6299 Remove unused locals. Remove locals to avoid shadowing.
6300 (fn_rsvg_handle_free): Remove; unused.
6301 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6302 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6303
3f754b86
PE
6304 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6305
2547adb1
CY
63062011-06-10 Chong Yidong <cyd@stupidchicken.com>
6307
6308 * image.c (gif_load): Fix omitted cast error introduced by
6309 2011-06-06 change.
6310
2c8e37d4
MR
63112011-06-10 Martin Rudalics <rudalics@gmx.at>
6312
6313 * window.h (resize_proportionally, orig_total_lines)
6314 (orig_top_line): Remove from window structure.
6315 (set_window_height, set_window_width, change_window_heights)
6316 (Fdelete_window): Remove prototypes.
6317 (resize_frame_windows): Remove duplicate declaration.
6318
440a42e3
EZ
63192011-06-10 Eli Zaretskii <eliz@gnu.org>
6320
6321 * window.h (resize_frame_windows, resize_window_check)
6322 (delete_deletable_window, resize_root_window)
6323 (resize_frame_windows): Declare prototypes.
6324
6325 * window.c (resize_window_apply): Make definition be "static" to
6326 match the prototype.
6327
562dd5e9
MR
63282011-06-10 Martin Rudalics <rudalics@gmx.at>
6329
6330 * window.c: Remove declarations of Qwindow_size_fixed,
6331 window_min_size_1, window_min_size_2, window_min_size,
6332 size_window, window_fixed_size_p, enlarge_window, delete_window.
6333 Remove static from declaration of Qdelete_window, it's
6334 temporarily needed by Fbury_buffer.
6335 (replace_window): Don't assign orig_top_line and
6336 orig_total_lines.
6337 (Fdelete_window, delete_window): Remove. Window deletion is
6338 handled by window.el.
640c8776
SM
6339 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6340 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6341 (Fdelete_other_windows): Remove. Deleting other windows is
6342 handled by window.el.
6343 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6344 handled in window.el.
6345 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6346 Window minimum sizes are handled in window.el.
6347 (shrink_windows, size_window, set_window_height)
6348 (set_window_width, change_window_heights, window_height)
6349 (window_width, CURBEG, CURSIZE, enlarge_window)
6350 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6351 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6352 handled in window.el.
6353 (make_dummy_parent): Rename to make_parent_window and give it a
6354 second argument horflag.
6355 (make_window): Don't set resize_proportionally any more.
6356 (Fsplit_window): Remove. Windows are split in window.el.
6357 (save_restore_action, save_restore_orig_size)
6358 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6359 Resize mini windows in window.el.
6360 (grow_mini_window, shrink_mini_window): Implement by calling
6361 Qresize_root_window_vertically, resize_window_check and
6362 resize_window_apply.
640c8776
SM
6363 (saved_window, Fset_window_configuration, save_window_save):
6364 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6365 resize_proportionally.
6366 (window_min_height, window_min_width): Move to window.el.
6367 (keys_of_window): Move bindings for delete-other-windows,
6368 split-window, delete-window and enlarge-window to window.el.
6369
6370 * buffer.c: Temporarily extern Qdelete_window.
6371 (Fbury_buffer): Temporarily call Qdelete_window instead of
6372 Fdelete_window (Fbury_buffer will move to window.el soon).
6373
6374 * frame.c (set_menu_bar_lines_1): Remove code handling
6375 orig_top_line and orig_total_lines.
6376
6377 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6378 set_window_height but set heights directly.
6379 (change_frame_size_1): Use resize_frame_windows.
6380
6381 * xdisp.c (init_xdisp): Don't use set_window_height but set
6382 heights directly.
6383
640c8776
SM
6384 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6385 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6386 run_window_configuration_change_hook.
6387
6388 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6389 instead of change_window_heights and run
6390 run_window_configuration_change_hook.
6391
1a13852e
MR
63922011-06-09 Martin Rudalics <rudalics@gmx.at>
6393
6394 * window.c (replace_window): Rename second argument REPLACEMENT to
6395 NEW. New third argument SETFLAG. Rewrite.
6396 (delete_window, make_dummy_parent): Call replace_window with
6397 third argument 1.
6398 (window_list_1): Move down in code.
6399 (run_window_configuration_change_hook): Move set_buffer part
6400 before select_frame_norecord part in order to unwind correctly.
6401 Rename count1 to count.
6402 (recombine_windows, delete_deletable_window, resize_root_window)
6403 (Fdelete_other_windows_internal)
6404 (Frun_window_configuration_change_hook, make_parent_window)
6405 (resize_window_check, resize_window_apply, Fresize_window_apply)
6406 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6407 (Fdelete_window_internal, Fresize_mini_window_internal):
6408 New functions.
1a13852e
MR
6409 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6410
f3d1777e
MR
64112011-06-08 Martin Rudalics <rudalics@gmx.at>
6412
496e208e
MR
6413 * window.h (window): Add some new members to window structure -
6414 normal_lines, normal_cols, new_total, new_normal, clone_number,
6415 splits, nest, prev_buffers, next_buffers.
6416 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6417 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6418
f3d1777e
MR
6419 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6420 Remove.
496e208e
MR
6421 (make_dummy_parent): Set new members of windows structure.
6422 (make_window): Move down in code. Handle new members of window
6423 structure.
6424 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6425 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6426 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6427 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6428 (Fset_window_next_buffers, Fset_window_clone_number):
6429 New functions.
496e208e
MR
6430 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6431 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6432 Doc-string fixes.
6433 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6434 Argument WINDOW can be now internal window too.
6435 (Fwindow_use_time): Move up in code.
6436 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6437 Rewrite doc-string.
6438 (Fset_window_configuration, saved_window)
6439 (Fcurrent_window_configuration, save_window_save): Handle new
6440 members of window structure.
b9e809c2
MR
6441 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6442 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6443 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6444 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6445 Qget_mru_window, Qresize_root_window,
6446 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6447 Qauto_buffer_name; staticpro them.
f3d1777e 6448
abde8f8c
MR
64492011-06-07 Martin Rudalics <rudalics@gmx.at>
6450
6451 * window.c (Fwindow_total_size, Fwindow_left_column)
6452 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6453 (Fwindow_list_1): New functions.
6454 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6455 (Fwindow_width, Fscroll_left, Fscroll_right):
6456 Use window_body_cols instead of window_box_text_cols.
6457 (delete_window, Fset_window_configuration):
6458 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6459 (delete_all_subwindows): Take a window as argument and not a
6460 structure. Rewrite.
190b47e6
MR
6461 (window_loop): Remove handling of GET_LRU_WINDOW and
6462 GET_LARGEST_WINDOW.
6463 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6464
6465 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6466 window_box_text_cols. delete_all_subwindows now takes a
6467 Lisp_Object as argument.
abde8f8c 6468
640c8776
SM
6469 * indent.c (compute_motion, Fcompute_motion):
6470 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6471
fa8a67e6
MR
6472 * frame.c (delete_frame): Call delete_all_subwindows with root
6473 window as argument.
6474
a54e3482
DC
64752011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6476
6477 * fns.c (Fputhash): Document return value.
6478
60002bf5
CY
64792011-06-06 Chong Yidong <cyd@stupidchicken.com>
6480
6481 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6482
0c671da6 64832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6484
b862a52a 6485 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6486
be44ca6c
PE
6487 Check for overflow when converting integer to cons and back.
6488 * charset.c (Fdefine_charset_internal, Fdecode_char):
6489 Use cons_to_unsigned to catch overflow.
6490 (Fencode_char): Use INTEGER_TO_CONS.
6491 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6492 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6493 * data.c (long_to_cons, cons_to_long): Remove.
6494 (cons_to_unsigned, cons_to_signed): New functions.
6495 These signal an error for invalid or out-of-range values.
6496 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6497 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6498 * font.c (Ffont_variation_glyphs):
6499 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6500 * lisp.h: Include <intprops.h>.
6501 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6502 (cons_to_signed, cons_to_unsigned): New decls.
6503 (long_to_cons, cons_to_long): Remove decls.
6504 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6505 (Fprimitive_undo): Use CONS_TO_INTEGER.
6506 * xfns.c (Fx_window_property): Likewise.
6507 * xselect.c: Include <limits.h>.
6508 (x_own_selection, selection_data_to_lisp_data):
6509 Use INTEGER_TO_CONS.
6510 (x_handle_selection_request, x_handle_selection_clear)
6511 (x_get_foreign_selection, Fx_disown_selection_internal)
6512 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6513 (lisp_data_to_selection_data): Use cons_to_unsigned.
6514 (x_fill_property_data): Use cons_to_signed.
6515 Report values out of range.
6516
d1f3d2af
PE
6517 Check for buffer and string overflow more precisely.
6518 * buffer.h (BUF_BYTES_MAX): New macro.
6519 * lisp.h (STRING_BYTES_MAX): New macro.
6520 * alloc.c (Fmake_string):
6521 * character.c (string_escape_byte8):
6522 * coding.c (coding_alloc_by_realloc):
6523 * doprnt.c (doprnt):
6524 * editfns.c (Fformat):
6525 * eval.c (verror):
6526 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6527 since they may not be the same number.
6528 * editfns.c (Finsert_char):
6529 * fileio.c (Finsert_file_contents):
6530 Likewise for BUF_BYTES_MAX.
6531
dd52fcea
PE
6532 * image.c: Use ptrdiff_t, not int, for sizes.
6533 (slurp_file): Switch from int to ptrdiff_t.
6534 All uses changed.
6535 (slurp_file): Check that file size fits in both size_t (for
6536 malloc) and ptrdiff_t (for sanity and safety).
6537
7f9bbdbb
PE
6538 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6539 if b->modtime has its maximal value.
6540
dfe18f82
PE
6541 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6542
84acfcf0
PE
6543 Don't assume time_t can fit into int.
6544 * buffer.h (struct buffer.modtime): Now time_t, not int.
6545 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6546 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6547
ccd9a01a
PE
6548 Minor fixes for signed vs unsigned integers.
6549 * character.h (MAYBE_UNIFY_CHAR):
6550 * charset.c (maybe_unify_char):
6551 * keyboard.c (read_char, reorder_modifiers):
6552 XINT -> XFASTINT, since the integer must be nonnegative.
6553 * ftfont.c (ftfont_spec_pattern):
6554 * keymap.c (access_keymap, silly_event_symbol_error):
6555 XUINT -> XFASTINT, since the integer must be nonnegative.
6556 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6557 since it makes no difference and we prefer signed.
6558 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6559 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6560 nonnegative.
6561
d6d100dd
SM
65622011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6563
6564 * window.h (Fwindow_frame): Declare.
6565
2b6148e4
PE
65662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6567
6568 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6569 (SPARE_MEMORY): Always define.
6570 (LARGE_REQUEST): Remove.
6571 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6572
f230ecc9
MR
65732011-06-06 Martin Rudalics <rudalics@gmx.at>
6574
727e958e
MR
6575 * lisp.h: Move EXFUNS for Fframe_root_window,
6576 Fframe_first_window and Fset_frame_selected_window to window.h.
6577
6578 * window.h: Move EXFUNS for Fframe_root_window,
6579 Fframe_first_window and Fset_frame_selected_window here from
6580 lisp.h.
6581
6582 * frame.c (Fwindow_frame, Fframe_first_window)
6583 (Fframe_root_window, Fframe_selected_window)
6584 (Fset_frame_selected_window): Move to window.c.
6585 (Factive_minibuffer_window): Move to minibuf.c.
6586 (Fother_visible_frames_p): New function.
6587
6588 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6589
f230ecc9
MR
6590 * window.c (decode_window, decode_any_window): Move up in code.
6591 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6592 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6593 (Fwindow_buffer): Move up and rewrite doc-string.
6594 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6595 (Fwindow_prev): New functions.
727e958e
MR
6596 (Fwindow_frame): Move here from frame.c. Accept any window as
6597 argument.
6598 (Fframe_root_window, Fframe_first_window)
6599 (Fframe_selected_window): Move here from frame.c. Accept frame
6600 or arbitrary window as argument. Update doc-strings.
6601 (Fminibuffer_window): Move up in code.
6602 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6603 (Fset_frame_selected_window): Move here from frame.c.
6604 Marginal rewrite.
727e958e
MR
6605 (Fselected_window, select_window, Fselect_window): Move up in
6606 code. Minor doc-string fixes.
f230ecc9 6607
4d09bcf6
PE
66082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6609
6610 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6611 Do not assume that spare memory exists; that assumption is valid
6612 only if SYSTEM_MALLOC.
6613 (LARGE_REQUEST): New macro, so that the issue of large requests
6614 is separated from the issue of spare memory.
6615
810928a2
AS
66162011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6617
172418ad
AS
6618 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6619 format. (Bug#8806)
6620
43f862f7
AS
6621 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6622
810928a2
AS
6623 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6624 before statements.
6625
a059fe24
JD
66262011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6627
6628 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6629
6630 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6631
6632 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6633 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6634
989bf368
JB
66352011-06-05 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6638
4b80f674
CY
66392011-06-04 Chong Yidong <cyd@stupidchicken.com>
6640
6641 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6642 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6643 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6644 New error handlers.
4b80f674
CY
6645 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6646 Obey Vx_select_enable_clipboard_manager. Catch errors in
6647 x_clipboard_manager_save (Bug#8779).
6648 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6649 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6650
99a33b77 66512011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6652
6653 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6654
99a33b77 66552011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6656
6657 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6658 in the current matrix if keep_current_p is non-zero.
6659
8264569d
EZ
66602011-06-04 Eli Zaretskii <eliz@gnu.org>
6661
6662 * bidi.c (bidi_level_of_next_char): Fix last change.
6663
57f97249
EZ
66642011-06-03 Eli Zaretskii <eliz@gnu.org>
6665
fec2107c 6666 Support bidi reordering of text covered by display properties.
57f97249 6667
fec2107c
EZ
6668 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6669 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6670 (bidi_cache_search, bidi_cache_iterator_state)
6671 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6672 (bidi_level_of_next_char, bidi_move_to_visually_next):
6673 Support character positions inside a run of characters covered by a
fec2107c
EZ
6674 display string.
6675 (bidi_paragraph_init, bidi_resolve_explicit_1)
6676 (bidi_level_of_next_char): Call bidi_fetch_char and
6677 bidi_fetch_char_advance instead of FETCH_CHAR and
6678 FETCH_CHAR_ADVANCE.
6679 (bidi_init_it): Initialize new members.
6680 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6681 definitions.
6682 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6683 instead of using explicit *_CHAR codes.
d6d100dd
SM
6684 (bidi_resolve_explicit, bidi_resolve_weak):
6685 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6686 bidirectional text is supported only in multibyte buffers.
6687 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6688 it to initialize the frame_window_p member of struct bidi_it.
6689 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6690 (bidi_resolve_explicit, bidi_resolve_weak)
6691 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6692 bidi_it->nchars is non-positive.
6693 (bidi_level_of_next_char): Don't try to lookup the cache for the
6694 next/previous character if nothing is cached there yet, or if we
6695 were just reseat()'ed to a new position.
c40e2fb2 6696
0e14fe90
EZ
6697 * xdisp.c (set_cursor_from_row): Set start and stop points
6698 according to the row's direction when priming the loop that looks
6699 for the glyph on which to display cursor.
6700 (single_display_spec_intangible_p): Function deleted.
6701 (display_prop_intangible_p): Reimplement to call
6702 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6703 Accept 3 additional arguments needed by handle_display_spec.
6704 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6705 values: lists, `(when COND...)' forms, etc.
6706 (single_display_spec_string_p): Support property values that are
6707 lists with the argument STRING its top-level element.
6708 (display_prop_string_p): Fix the condition for processing a
6709 property that is a list to be consistent with handle_display_spec.
fec2107c 6710 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6711 last portion of handle_display_prop.
6712 (compute_display_string_pos): Accept additional argument
6713 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6714 value of a `display' property is a "replacing spec".
6715 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6716 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6717 the display property, but just return a value indicating whether
6718 the display property will replace the characters it covers.
6719 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6720 frame_window_p members of struct bidi_it.
d6d100dd
SM
6721 (compute_display_string_pos, compute_display_string_end):
6722 New functions.
fec2107c
EZ
6723 (push_it): Accept second argument POSITION, where pop_it should
6724 jump to continue iteration.
6725 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6726
fec2107c
EZ
6727 * keyboard.c (adjust_point_for_property): Adjust the call to
6728 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6729
6730 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6731 (bidi_init_it): Update prototypes.
6732 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6733 (compute_display_string_pos, compute_display_string_end):
6734 Declare prototypes.
fec2107c
EZ
6735 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6736 EMACS_INT.
fc6f18ce 6737
40087514 67382011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6739
57f53182
PE
6740 Malloc failure behavior now depends on size of allocation.
6741 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6742 * lisp.h: Change signatures accordingly.
6743 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6744 All callers changed. (Bug#8762)
6745
6746 * gnutls.c: Use Emacs's memory allocators.
6747 Without this change, the gnutls library would invoke malloc etc.
6748 directly, which causes problems on non-SYNC_INPUT hosts, and which
6749 runs afoul of improving memory_full behavior. (Bug#8761)
6750 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6751 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6752 xfree instead of the default malloc, realloc, free.
6753 (Fgnutls_boot): No need to check for memory allocation failure,
6754 since xmalloc does that for us.
6755
ac32cd99 6756 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6757 * category.c (hash_get_category_set):
6758 * ccl.c (ccl_driver):
6759 * charset.c (Fdefine_charset_internal):
6760 * charset.h (struct charset.hash_index):
6761 * composite.c (get_composition_id, gstring_lookup_cache)
6762 (composition_gstring_put_cache):
6763 * composite.h (struct composition.hash_index):
6764 * dispextern.h (struct image.hash):
6765 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6766 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6767 (hashfn_equal, hashfn_user_defined, make_hash_table)
6768 (maybe_resize_hash_table, hash_lookup, hash_put)
6769 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6770 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6771 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6772 * image.c (make_image, search_image_cache, lookup_image)
6773 (xpm_put_color_table_h):
6774 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6775 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6776 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6777 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6778 * alloc.c (allocate_vectorlike):
6779 Check for overflow in vector size calculations.
6780 * ccl.c (ccl_driver):
6781 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6782 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6783 need to be updated by these changes.
40087514
PE
6784 * fns.c (make_hash_table, maybe_resize_hash_table):
6785 Check for integer overflow with large hash tables.
0de4bb68
PE
6786 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6787 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6788 (SXHASH_REDUCE): New macro.
6789 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6790 Use it instead of discarding useful hash info with large hash values.
6791 (sxhash_float): New function.
6792 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6793 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6794 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6795 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6796 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6797 Adjust signatures to match updated version of code.
6798 (consing_since_gc): Now EMACS_INT, since a single hash table can
6799 use more than INT_MAX bytes.
6800
698d32e2
DN
68012011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6802
6803 Make it possible to build with GCC-4.6+ -O2 -flto.
6804
6805 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6806
fd6fa53f
SM
68072011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6808
6809 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6810 Call minibuffer-inactive-mode.
6811
864db017
JB
68122011-05-31 Juanma Barranquero <lekktu@gmail.com>
6813
6814 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6815 Update dependencies.
6816
2ad0baf4
DN
68172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6818
6819 * data.c (init_data): Remove code for UTS, this system is not
6820 supported anymore.
6821
4fcc2638
DN
68222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6823
6824 Don't force ./temacs to start in terminal mode.
6825
6826 * frame.c (make_initial_frame): Initialize faces in all cases, not
6827 only when CANNOT_DUMP is defined.
6828 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6829
c56e0fd5
DN
68302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6831
6832 * dispnew.c (add_window_display_history): Use const for the string
6833 pointer. Remove declaration, not needed.
6834
333d54da 68352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6836
55d4c1b2 6837 Use 'inline', not 'INLINE'.
333d54da 6838 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6839 * alloc.c, fontset.c (INLINE): Remove.
6840 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6841 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6842 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6843 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6844 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6845
738db178
DN
68462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6847
6848 Make it possible to run ./temacs.
6849
6850 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6851 syms_of_callproc does the same thing. Remove test for
6852 "initialized", do it in the caller.
6853 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6854
620c53a6
SM
68552011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6856
6857 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6858 (read_minibuf): Use get_minibuffer.
6859 (syms_of_minibuf): Use DEFSYM.
6860 (Qmetadata): New var.
6861 * data.c (Qbuffer): Don't make it static.
6862 (syms_of_data): Use DEFSYM.
6863
e003a292
PE
68642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6865
6866 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6867 (CCL_CODE_MIN): New macro.
6868
ed008a6d
PE
68692011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6870
3687c2ef
PE
6871 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6872
ed008a6d
PE
6873 * eval.c (Qdebug): Now static.
6874 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6875 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6876 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6877
d66c4c7c
CY
68782011-05-29 Chong Yidong <cyd@stupidchicken.com>
6879
6880 * image.c: Various fixes to ImageMagick code comments.
6881 (Fimagemagick_types): Doc fix.
6882
5fbc2025
PE
68832011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6884
0196f88a
PE
6885 Minor fixes prompted by GCC 4.6.0 warnings.
6886
6887 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6888
5fbc2025
PE
6889 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6890 (x_clipboard_manager_save_all): Move extern decl to ...
6891 * xterm.h: ... here, so that it can be checked for consistency.
6892
1dd3c2d9
CY
68932011-05-29 Chong Yidong <cyd@stupidchicken.com>
6894
6895 * xselect.c (x_clipboard_manager_save_frame)
6896 (x_clipboard_manager_save_all): New functions.
6897 (Fx_clipboard_manager_save): Lisp function deleted.
6898
6899 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6900 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6901
6902 * xterm.h: Update prototype.
6903
5ba6571d
WX
69042011-05-28 William Xu <william.xwl@gmail.com>
6905
6906 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6907 exiting (Bug#8239).
6908
3eaff834
JM
69092011-05-28 Jim Meyering <meyering@redhat.com>
6910
e1900994 6911 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6912 * fns.c (to_uchar): Define.
6913 (crypto_hash_function): Use it to convert some newly-signed
6914 variables to unsigned, to avoid sign-extension bugs. For example,
6915 without this change, (md5 "truc") would evaluate to
6916 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6917 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6918 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6919
0f6990a7
PE
69202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6921
6922 Integer overflow fixes.
c8a9ca5a 6923
08686060
PE
6924 * dbusbind.c: Serial number integer overflow fixes.
6925 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6926 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6927 to hold a serial number that is too large for a fixnum.
6928 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6929 Check for serial numbers out of range. Decode any serial number
59568bf0 6930 that was so large that it became a float. (Bug#8722)
08686060 6931
2d1fc3c7
PE
6932 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6933 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6934 Use XFASTINT rather than XUINT when numbers are nonnegative.
6935 (xd_append_arg, Fdbus_method_return_internal):
6936 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6937 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6938 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6939 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6940 (Bug#8722)
2d1fc3c7 6941
c8a9ca5a
PE
6942 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6943
519e1d69
PE
6944 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6945
6df6ae42 6946 ccl: Add integer overflow checks.
30569699
PE
6947 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6948 (IN_INT_RANGE): New macros.
6949 (ccl_driver): Use them to check for integer overflow when
6950 decoding a CCL program. Many of the new checks are whether XINT (x)
6951 fits in int; it doesn't always, on 64-bit hosts. The new version
6952 doesn't catch all possible integer overflows, but it's an
847044ea 6953 improvement. (Bug#8719)
30569699 6954
c11285dc
PE
6955 * alloc.c (make_event_array): Use XINT, not XUINT.
6956 There's no need for unsigned here.
6957
fdccd48e
PE
6958 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6959 This follows up to the 2011-05-06 change that substituted uintptr_t
6960 for EMACS_INT. This case wasn't caught back then.
6961
37910ab2
PE
6962 Rework Fformat to avoid integer overflow issues.
6963 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6964 now (part of C89). Include <verify.h>.
6965 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6966 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6967 (Fformat): Avoid the prepass trying to compute sizes; it was only
6968 approximate and thus did not catch overflow reliably. Instead, walk
6969 through the format just once, formatting and computing sizes as we go,
6970 checking for integer overflow at every step, and allocating a larger
6971 buffer as needed. Keep track separately whether the format is
6972 multibyte. Keep only the most-recently calculated precision, rather
6973 than them all. Record whether each argument has been converted to
6974 string. Use EMACS_INT, not int, for byte and char and arg counts.
6975 Support field widths and precisions larger than INT_MAX. Avoid
6976 sprintf's undefined behavior with conversion specifications such as %#d
6977 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6978 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6979 formatting out-of-range floating point numbers with int
9173deec 6980 formats. (Bug#8668)
37910ab2 6981
2e6578fb
PE
6982 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6983
0ae6bdee
PE
6984 * data.c: Avoid integer truncation in expressions involving floats.
6985 * data.c: Include <intprops.h>.
6986 (arith_driver): When there's an integer overflow in an expression
6987 involving floating point, convert the integers to floating point
6988 so that the resulting value does not suffer from catastrophic
6989 integer truncation. For example, on a 64-bit host (* 4
6990 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6991 Do not rely on undefined behavior after integer overflow.
6992
de883a70
PE
6993 merge count_size_as_multibyte, parse_str_to_multibyte
6994 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6995 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6996 Check for integer overflow.
6997 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6998 since it's now a duplicate of the other. This is more of
6999 a character than a buffer op, so better that it's in character.c.
7000 * fns.c, print.c: Adjust to above changes.
7001
2ff916cb
PE
70022011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7003
7004 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7005
f1b54466
PE
70062011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7007
fb1ac845
PE
7008 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7009 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7010 (x_clipboard_manager_save): Now static.
7011 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7012
f1b54466
PE
7013 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7014 (crypto_hash_function): Now static.
7015 Fix pointer signedness problems. Avoid unnecessary initializations.
7016
a9f737ee
CY
70172011-05-27 Chong Yidong <cyd@stupidchicken.com>
7018
7019 * termhooks.h (Vselection_alist): Make it terminal-local.
7020
7021 * terminal.c (create_terminal): Initialize it.
7022
7023 * xselect.c: Support for clipboard managers.
7024 (Vselection_alist): Move to termhooks.h as terminal-local var.
7025 (LOCAL_SELECTION): New macro.
7026 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7027 (symbol_to_x_atom): Remove gratuitous arg.
7028 (x_handle_selection_request, lisp_data_to_selection_data)
7029 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7030 (x_own_selection, x_get_local_selection, x_convert_selection):
7031 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7032 (some_frame_on_display): Delete unused function.
7033 (Fx_own_selection_internal, Fx_get_selection_internal)
7034 (Fx_disown_selection_internal, Fx_selection_owner_p)
7035 (Fx_selection_exists_p): New optional frame arg.
7036 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7037 (x_handle_selection_clear): Don't treat other terminals with the
7038 same keyboard specially. Use the terminal-local Vselection_alist.
7039 (x_clear_frame_selections): Use Frun_hook_with_args.
7040
7041 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7042
7043 * xterm.h: Add support for those atoms.
7044
e067f0c1
CY
70452011-05-26 Chong Yidong <cyd@stupidchicken.com>
7046
7047 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7048 (converted_selections, conversion_fail_tag): New global variables.
7049 (x_selection_request_lisp_error): Free the above.
7050 (x_get_local_selection): Remove unnecessary code.
7051 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7052 of converted selections stored in converted_selections.
7053 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7054 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7055 (x_convert_selection): New function.
7056 (x_handle_selection_event): Simplify.
7057 (x_get_foreign_selection): Don't ignore incoming requests while
7058 waiting for an answer; this will fail when we implement
7059 SAVE_TARGETS, and seems unnecessary anyway.
7060 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7061 (Vx_sent_selection_functions): Doc fix.
7062
0f4aebc0
LL
70632011-05-26 Leo Liu <sdl.web@gmail.com>
7064
7065 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7066
e61124cd
YM
70672011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7068
7069 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7070
7071 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7072 for fringe update if it has periodic bitmap.
ac389d0c 7073 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7074 and fringe_bitmap_periodic_p.
7075
7076 * fringe.c (get_fringe_bitmap_data): New function.
7077 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7078 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7079 row. Mark glyph row for fringe update if periodicity changed.
7080
7081 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7082 for fringe update unless it has periodic bitmap.
7083
f16d9837
KH
70842011-05-25 Kenichi Handa <handa@m17n.org>
7085
7086 * xdisp.c (get_next_display_element): Set correct it->face_id for
7087 a static composition.
7088
e1b90ef6
LL
70892011-05-24 Leo Liu <sdl.web@gmail.com>
7090
7091 * deps.mk (fns.o):
7092 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7093
7094 * fns.c (crypto_hash_function, Fsha1): New function.
7095 (Fmd5): Use crypto_hash_function.
7096 (syms_of_fns): Add Ssha1.
7097
7400048f
PE
70982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7099
7100 * gnutls.c: Remove unused macros.
7101 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7102 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7103 Remove macros that are defined and never used.
7104 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7105
abb71cf4
CY
71062011-05-22 Chong Yidong <cyd@stupidchicken.com>
7107
7108 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7109 (Fx_get_selection_internal): Minor cleanup.
7110 (Fx_own_selection_internal): Rename arguments for consistency with
7111 select.el.
7112
6307db39
PE
71132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7114
7115 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7116
f3d4e0a4
CY
71172011-05-22 Chong Yidong <cyd@stupidchicken.com>
7118
7119 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7120
4d8ade89
YM
71212011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7122
7123 * dispnew.c (scrolling_window): Don't exclude the case that the
7124 last enabled row in the desired matrix touches the bottom boundary.
7125
32078c8d
GM
71262011-05-21 Glenn Morris <rgm@gnu.org>
7127
7128 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7129 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7130 and add some more files.
32078c8d 7131
7285dc67
EZ
71322011-05-20 Eli Zaretskii <eliz@gnu.org>
7133
7134 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7135 report_file_error introduced by the change from 2011-05-07.
7136
89d1bd22
PE
71372011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7138
7139 * systime.h (Time): Define only if emacs is defined.
7140 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7141 where the include path doesn't have X11/X.h by default. See
7142 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7143
cd394be1 71442011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7145
7146 * composite.c (find_automatic_composition): Fix previous change.
7147
b9704ad9
GM
71482011-05-20 Glenn Morris <rgm@gnu.org>
7149
7150 * lisp.mk: New file, split from Makefile.in.
7151 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7152 (shortlisp): Remove.
7153 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7154
4a720484
GM
71552011-05-19 Glenn Morris <rgm@gnu.org>
7156
7157 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7158 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7159 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7160 (lisp): Set the order to that of loadup.el.
7161 (shortlisp): Make it a copy of $lisp.
7162 (SOME_MACHINE_LISP): Remove.
7163 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7164 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7165
a28d4396
KH
71662011-05-18 Kenichi Handa <handa@m17n.org>
7167
7168 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7169 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7170 (find_automatic_composition): Mostly rewrite for efficiency.
7171
a2b1fa8e
JB
71722011-05-18 Juanma Barranquero <lekktu@gmail.com>
7173
7174 * makefile.w32-in: Update dependencies.
7175
8e1f5610
CS
71762011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7177
7178 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7179 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7180
7025ee00 71812011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7182
cdfa6eab
PE
7183 Fix some integer overflow issues, such as string length overflow.
7184
06d6db33
PE
7185 * insdel.c (count_size_as_multibyte): Check for string overflow.
7186
2b4560a8
PE
7187 * character.c (lisp_string_width): Check for string overflow.
7188 Use EMACS_INT, not int, for string indexes and lengths; in
7189 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7190 the resulting string length overflows an EMACS_INT; instead,
7191 report a string overflow if no precision given. When checking for
7192 precision exhaustion, use a check that cannot possibly have
7193 integer overflow. (Bug#8675)
7194 * character.h (lisp_string_width): Adjust to new signature.
7195
cb93f9be
PE
7196 * alloc.c (string_overflow): New function.
7197 (Fmake_string): Use it. This doesn't change behavior, but saves
7198 a few bytes and will simplify future changes.
7199 * character.c (string_escape_byte8): Likewise.
7200 * lisp.h (string_overflow): New decl.
7201
1a1f3366
PE
7202 Fixups, following up to the user-interface timestamp change.
7203 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7204 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7205 * msdos.c (mouse_get_pos): Likewise.
7206 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7207 * w32gui.h (Time): Define by including "systime.h" rather than by
7208 declaring it ourselves. (Bug#8664)
7209
d4e3e4d3
PE
7210 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7211 * image.c (clear_image_cache): Likewise.
7212
f6a24d19
PE
7213 * term.c (term_mouse_position): Don't assume time_t wraparound.
7214
08dc5ae6
PE
7215 Be more systematic about user-interface timestamps.
7216 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7217 and sometimes 'EMACS_UINT', to represent these timestamps.
7218 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7219 This makes the code easier to follow, and makes it easier to catch
7220 integer overflow bugs such as Bug#8664.
7221 * frame.c (Fmouse_position, Fmouse_pixel_position):
7222 Use Time, not unsigned long, for user-interface timestamps.
7223 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7224 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7225 * keyboard.h (last_event_timestamp): Likewise.
7226 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7227 * menu.h (xmenu_show): Likewise.
7228 * term.c (term_mouse_position): Likewise.
7229 * termhooks.h (struct input_event.timestamp): Likewise.
7230 (struct terminal.mouse_position_hook): Likewise.
7231 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7232 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7233 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7234 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7235 what it was before.
7236 * menu.h, termhooks.h: Include "systime.h", for Time.
7237
8e55734a
PE
7238 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7239 Don't assume that the difference between two unsigned long values
7240 can fit into an integer. At this point, we know button_down_time
7241 <= event->timestamp, so the difference must be nonnegative, so
7242 there's no need to cast the result if double-click-time is
7243 nonnegative, as it should be; check that it's nonnegative, just in
7244 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7245 apart (about 25 days). (Bug#8664)
8e55734a 7246
841f1b75 7247 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7248 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7249
3e26f69c
PE
7250 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7251 that always fit in int. Use a sentinel instead of a counter, to
7252 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7253 * frame.h (struct frame): Use int for menu_bar_items_used
7254 instead of EMACS_INT, since it always fits in int.
3e26f69c 7255
5cc152c0
PE
7256 * menu.c (grow_menu_items): Check for int overflow.
7257
d89eb65e
PE
7258 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7259
5235bd3e
PE
7260 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7261 Before, the code was not consistent. These values cannot exceed
7262 2**31 - 1 so there's no need to make them unsigned.
7263 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7264 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7265 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7266 as modifiers.
7267 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7268
bc827e23
PE
7269 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7270 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7271 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7272 presumably because the widths might not match.
7273
78eb494e
PE
7274 * window.c (size_window): Avoid needless test at loop start.
7275
04f2d78b
CB
72762011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7277
7278 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7279
d2fc7e3d 72802011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7281
7282 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7283
d2fc7e3d 72842011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7285
7286 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7287 `width' to `bar_area_x' and `bar_area_width', respectively.
7288 (x_scroll_run): Take account of fringe background extension.
7289
04f2d78b
CB
7290 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7291 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7292 `bar_area_width', respectively.
7293 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7294 background extension.
7295
79b70037
GM
72962011-05-10 Jim Meyering <meyering@redhat.com>
7297
7298 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7299
2f142cc5
JB
73002011-05-10 Juanma Barranquero <lekktu@gmail.com>
7301
7302 * image.c (Finit_image_library): Return t for built-in image types,
7303 like pbm and xbm. (Bug#8640)
7304
57679c86
AS
73052011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7306
7307 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7308
888c9e86
EZ
73092011-05-07 Eli Zaretskii <eliz@gnu.org>
7310
b0512a1d
EZ
7311 * w32console.c (Fset_screen_color): Doc fix.
7312 (Fget_screen_color): New function.
7313 (syms_of_ntterm): Defsubr it.
7314
7285dc67
EZ
7315 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7316 unlink the temporary file if Fcall_process didn't create it in the
7317 first place.
7318 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7319 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7320 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7321 cue to call_process_cleanup not to close that handle.
7322
4d3fcc8e
BK
73232011-05-07 Ben Key <bkey76@gmail.com>
7324
7325 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7326 one of two shell specific rules, either bootstrap-temacs-CMD or
7327 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7328 to the previous implementation of the bootstrap-temacs rule.
7329 The bootstrap-temacs-CMD rule is similar to the previous
7330 implementation of the bootstrap-temacs rule except that it
7331 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7332 variable.
7333
7334 These changes, along with some changes to nt/configure.bat,
7335 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7336 earlier fix to add support for --cflags and --ldflags options
7337 that include quotes so that it works whether make uses cmd or
7338 sh as the shell.
7339
b4289b64
MA
73402011-05-06 Michael Albinus <michael.albinus@gmx.de>
7341
7342 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7343 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7344 is a constant.
7345 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7346 a string. Handle both cases.
7347 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7348 (Fdbus_register_method): Use Qinvalid_function.
7349
af4c0e28
JB
73502011-05-06 Juanma Barranquero <lekktu@gmail.com>
7351
7352 * makefile.w32-in: Update dependencies.
7353 (LISP_H): Add inttypes.h and stdin.h.
7354 (PROCESS_H): Add unistd.h.
7355
c51453d9
EZ
73562011-05-06 Eli Zaretskii <eliz@gnu.org>
7357
7358 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7359 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7360
8ff0ac3c 73612011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7362
4c4b566b
PE
7363 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7364
aab2b9b5
PE
7365 * term.c (vfatal): Remove stray call to va_end.
7366 It's not needed and the C Standard doesn't allow it here anyway.
7367
c378da0b
PE
7368 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7369 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7370
288b08c7
PE
7371 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7372 bytes.
7373
e3601888
PE
7374 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7375
db6c0e74
PE
7376 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7377
dd5963ea
PE
7378 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7379
88c9450f
PE
7380 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7381
2f9442b8
PE
7382 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7383
c032b5f8
PE
7384 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7385 * charset.c (Fdefine_charset_internal): Don't initialize
7386 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7387 32-bit int (Bug#8600).
a108c10b
PE
7388
7389 * lread.c (read_integer): Be more consistent with string-to-number.
7390 Use string_to_number to do the actual conversion; this avoids
7391 rounding errors and fixes some other screwups. Without this fix,
7392 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7393 (digit_to_number): Move earlier, for benefit of read_integer.
7394 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7395 not a digit in any supported base. (Bug#8602)
a108c10b 7396
ad5f9eea
PE
7397 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7398
aec1708a
PE
7399 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7400 to match comment at start of function. This also removes a
7401 GCC warning about overflow in a 32+64-bit port.
7402
47be4ab5
PE
7403 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7404
371cac43
PE
7405 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7406 Reported by Stefan Monnier in
7407 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7408 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7409 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7410
d01a7826
PE
7411 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7412 (EMACS_UINTPTR): Likewise, with uintptr_t.
7413
7fd47d5c
PE
7414 * lisp.h: Prefer 64-bit EMACS_INT if available.
7415 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7416 on 32-bit hosts that have 64-bit int, so that they can access
7417 large files.
122b0c86
PE
7418 However, temporarily disable this change unless the temporary
7419 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7420
8727937b
PE
7421 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7422
8ac068ac
PE
7423 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7424 This removes an assumption that EMACS_INT and long are the same
7425 width as pointers. The assumption is true for Emacs porting targets
7426 now, but we want to make other targets possible.
7427 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7428 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7429 In the rest of the code, change types of integers that hold casted
7430 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7431 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7432 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7433 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7434 No need to cast type when ORing.
7435 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7436 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7437 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7438 assume EMACS_INT is the same width as char *.
7439 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7440 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7441 Remove no-longer-needed casts.
7442 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7443 (xg_tool_bar_help_callback, xg_make_tool_item):
7444 Use EMACS_INTPTR to hold an integer
7445 that will be cast to void *; this can avoid a GCC warning
7446 if EMACS_INT is not the same width as void *.
7447 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7448 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7449 (current_message_1, set_message_1):
7450 Use a local to convert to proper width without a cast.
7451 * xmenu.c (dialog_selection_callback): Likewise.
7452
ede49d71
PE
7453 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7454 Also, don't assume VALBITS / RAND_BITS is less than 5,
7455 and don't rely on undefined behavior when shifting a 1 left into
7456 the sign bit.
7457 * lisp.h (get_random): Change signature to match.
7458
2f30ecd0
PE
7459 * lread.c (hash_string): Use size_t, not int, for hash computation.
7460 Normally we prefer signed values; but hashing is special, because
7461 it's better to use unsigned division on hash table sizes so that
7462 the remainder is nonnegative. Also, size_t is the natural width
7463 for hashing into memory. The previous code used 'int', which doesn't
7464 retain enough info to hash well into very large tables.
7465 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7466
2a866e7b
PE
7467 * dbusbind.c: Don't possibly lose pointer info when converting.
7468 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7469 Use XPNTR rather than XHASH, so that the high-order bits of
7470 the pointer aren't lost when converting through void *.
7471
51639eac
PE
7472 * eval.c (Fautoload): Don't double-shift a pointer.
7473
92394119
PE
7474 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7475
dbdb9a7c
JB
74762011-05-06 Juanma Barranquero <lekktu@gmail.com>
7477
7478 * gnutls.c (DEF_GNUTLS_FN):
7479 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7480
db7a0b4f
AS
74812011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7482
7483 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7484 marker. (Bug#8610)
7485
cd394be1 74862011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7487
7488 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7489 New version that can reserve upto 2GB of heap space.
7490
f7ff1b0f 74912011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7492
7493 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7494
639c109b
TZ
74952011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7496
7497 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7498 `gnutls_certificate_set_x509_key_file'.
7499
d2127135
JB
75002011-05-05 Juanma Barranquero <lekktu@gmail.com>
7501
7502 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7503 Update dependencies.
7504
e968f4f3
JB
75052011-05-04 Juanma Barranquero <lekktu@gmail.com>
7506
7507 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7508 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7509 Remove unused parameter `fildes'.
7510 * process.c (read_process_output, send_process): Don't pass it.
7511
84d358f0
JB
75122011-05-04 Juanma Barranquero <lekktu@gmail.com>
7513
7514 Fix previous change: the library cache is defined in w32.c.
7515 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7516 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7517
0898ca10
JB
75182011-05-04 Juanma Barranquero <lekktu@gmail.com>
7519
7520 Implement dynamic loading of GnuTLS on Windows.
7521
7522 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7523 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7524 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7525 Declare.
7526
7527 * gnutls.c (Qgnutls_dll): Define.
7528 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7529 (gnutls_*): Declare function pointers.
7530 (init_gnutls_functions): New function to initialize function pointers.
7531 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7532 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7533 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7534 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7535 (emacs_gnutls_write, emacs_gnutls_read)
7536 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7537 (Fgnutls_available_p): New function.
7538 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7539 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7540 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7541
7542 * image.c: Include w32.h.
7543 (Vimage_type_cache): Delete.
7544 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7545 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7546 (w32_delayed_load): Move to w32.c.
7547
7548 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7549
7550 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7551 (w32_delayed_load): Move from image.c. When loading a library, record
7552 its filename in the :loaded-from property of the library id.
7553 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7554 Initialize and staticpro them.
7555 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7556
7557 * process.c: Include lisp.h before w32.h, not after.
7558 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7559 instead of gnutls_record_check_pending.
7560
7561 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7562
ff4de4aa
TZ
75632011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7564
7565 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7566 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7567 as passed in.
7568
abe95abb
JD
75692011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7570
7571 * xterm.c (x_set_frame_alpha): Do not set property on anything
7572 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7573
e16e55d4
JB
75742011-05-02 Juanma Barranquero <lekktu@gmail.com>
7575
7576 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7577
bafcf6a5
JB
75782011-05-02 Juanma Barranquero <lekktu@gmail.com>
7579
7580 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7581 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7582 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7583 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7584 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7585 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7586 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7587 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7588 (Qgnutls_bootprop_callbacks_verify): Make static.
7589
e7a6747f
AS
75902011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7591
19ed11ba
AS
7592 * callproc.c: Indentation fixup.
7593
e7a6747f 7594 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7595 (wait_for_termination, interruptible_wait_for_termination):
7596 Move after wait_for_termination_1.
e7a6747f 7597
1ef14cb4
LMI
75982011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7599
7600 * sysdep.c (interruptible_wait_for_termination): New function
7601 which is like wait_for_termination, but allows keyboard
7602 interruptions.
7603
7604 * callproc.c (Fcall_process): Add (:file "file") as an option for
7605 the STDOUT buffer.
7606 (Fcall_process_region): Ditto.
7607
330d880c
EZ
76082011-04-30 Eli Zaretskii <eliz@gnu.org>
7609
8db90b73
EZ
7610 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7611 rather than `XVECTOR (FOO)->size'.
7612
330d880c
EZ
7613 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7614 inttypes.h, as a gnulib replacement is used if it not available in
7615 system headers.
7616
15cbd324
EZ
76172011-04-21 Eli Zaretskii <eliz@gnu.org>
7618
7619 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7620 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7621 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7622
7623 * coding.c (coding_alloc_by_realloc): Error out if destination
7624 will grow beyond MOST_POSITIVE_FIXNUM.
7625 (decode_coding_emacs_mule): Abort if there isn't enough place in
7626 charbuf for the composition carryover bytes. Reserve an extra
7627 space for up to 2 characters produced in a loop.
7628 (decode_coding_iso_2022): Abort if there isn't enough place in
7629 charbuf for the composition carryover bytes.
7630
76312011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7632
ae940cca
EZ
7633 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7634 aborting when %lld or %lll format is passed.
7635 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7636 %llo or %llx format is passed. (Bug#8545)
7637
03ab8921
EZ
7638 * window.c (window_scroll_line_based): Use a marker instead of
7639 simple variables to record original value of point. (Bug#7952)
7640
afda1437
EZ
7641 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7642 produced by %s or %c overflows available buffer space. (Bug#8545)
7643
f76dee0c
PE
76442011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7645
7646 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7647 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7648
fdc5744d
JB
76492011-04-28 Juanma Barranquero <lekktu@gmail.com>
7650
7651 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7652
638f053a
JB
76532011-04-28 Juanma Barranquero <lekktu@gmail.com>
7654
7655 * keyboard.c (Qdelayed_warnings_hook): Define.
7656 (command_loop_1): Run `delayed-warnings-hook'
7657 if Vdelayed_warnings_list is non-nil.
7658 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7659 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7660
d178f871
EZ
76612011-04-28 Eli Zaretskii <eliz@gnu.org>
7662
7663 * doprnt.c (doprnt): Don't return value smaller than the buffer
7664 size if the message was truncated. (Bug#8545).
7665
b124fd93
JB
76662011-04-28 Juanma Barranquero <lekktu@gmail.com>
7667
7668 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7669 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7670
e810457d
PE
76712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7672
7673 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7674
ea51cceb
JB
76752011-04-27 Juanma Barranquero <lekktu@gmail.com>
7676
7677 * makefile.w32-in: Update dependencies.
7678
94dcfacf
EZ
76792011-04-27 Eli Zaretskii <eliz@gnu.org>
7680
7681 Improve `doprnt' and its usage. (Bug#8545)
7682 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7683 `format_end'. Remove support for %l as a conversion specifier.
7684 Don't use xrealloc. Improve diagnostics when the %l size modifier
7685 is used. Update the commentary.
7686
7687 * eval.c (verror): Simplify calculation of size_t.
7688
7689 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7690 messages.
7691
f61f41d7
PE
76922011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7693
7694 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7695 change.
7696
96fb4434
PE
76972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7698
7699 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7700 This makes this file independent of the recent pseudovector change.
7701
671875da 77022011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7703
69e9b5a3
PE
7704 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7705
b5f869a7 7706 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7707 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7708 Remove unused local.
c8926152 7709 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7710
841a1577 7711 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7712 GCC 4.6.0 optimizes based on type-based alias analysis.
7713 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7714 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7715 != &v->size, and therefore "v->size = 1; b->size = 2; return
7716 v->size;" must therefore return 1. This assumption is incorrect
7717 for Emacs, since it type-puns struct Lisp_Vector * with many other
7718 types. To fix this problem, this patch adds a new type struct
f904488f 7719 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7720 and pseudovectors, and helps optimizing compilers not get fooled
7721 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7722 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7723 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7724 the size member.
eab3844f
PE
7725 (XSETPVECTYPE): Rewrite in terms of new macro.
7726 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7727 This is a bit clearer, and further avoids the possibility of
7728 undesirable aliasing.
7729 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7730 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7731 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7732 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7733 (ASIZE): Now uses header.size rather than size.
7734 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7735 to avoid the hassle of writing XVECTOR (foo)->header.size.
7736 (struct vectorlike_header): New type.
eab3844f
PE
7737 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7738 object, to help avoid aliasing.
7739 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7740 (SUBRP): Likewise, since Lisp_Subr is a special case.
7741 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7742 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7743 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7744 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7745 changed to be "header.size" and "header.next".
7746 * buffer.h (struct buffer): Likewise.
7747 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7748 * frame.h (struct frame): Likewise.
7749 * process.h (struct Lisp_Process): Likewise.
7750 * termhooks.h (struct terminal): Likewise.
7751 * window.c (struct save_window_data, struct saved_window): Likewise.
7752 * window.h (struct window): Likewise.
7753 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7754 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7755 * buffer.c (init_buffer_once): Likewise.
7756 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7757 special case.
7758 * process.c (Fformat_network_address): Use local var for size,
7759 for brevity.
7760
0df1eac5
PE
7761 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7762
847ab9d1 7763 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7764 * data.c (atof): Remove decl; no longer used or needed.
7765 (digit_to_number): Move to lread.c.
7766 (Fstring_to_number): Use new string_to_number function, to be
7767 consistent with how the Lisp reader treats infinities and NaNs.
7768 Do not assume that floating-point numbers represent EMACS_INT
7769 without losing information; this is not true on most 64-bit hosts.
7770 Avoid double-rounding errors, by insisting on integers when
7771 parsing non-base-10 numbers, as the documentation specifies.
7772 * lisp.h (string_to_number): New decl, replacing ...
7773 (isfloat_string): Remove.
bc0a5c13 7774 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7775 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7776 appears to have been a coding error. Similarly, do not accept
7777 strings like +-1e0 as floating point numbers. Do not report
7778 overflow for integer overflows unless the base is not 10 which
7779 means we have no simple and reliable way to continue.
7780 Break out the floating-point parsing into a new
7781 function string_to_number, so that Fstring_to_number parses
7782 floating point numbers consistently with the Lisp reader.
04f2d78b 7783 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7784 (E_CHAR, EXP_INT): Remove, replacing with ...
7785 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7786 (string_to_number): New function, replacing isfloat_string.
7787 This function checks for valid syntax and produces the resulting
7788 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7789 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7790 so that overflow for non-base-10 numbers is reported only when
7791 there's no portable and simple way to convert to floating point.
452f4150 7792
67769ffc
PE
7793 * textprop.c (set_text_properties_1): Rewrite for clarity,
7794 and to avoid GCC warning about integer overflow.
7795
c20db43f
PE
7796 * intervals.h (struct interval): Use EMACS_INT for members
7797 where EMACS_UINT might cause problems. See
7798 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7799 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7800 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7801 All uses changed.
37aa2f85
PE
7802 (offset_intervals): Tell GCC not to worry about length overflow
7803 when negating a negative length.
c20db43f 7804
2538aa2f
PE
7805 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7806 (overrun_check_free): Likewise.
7807
f2d3008d
PE
7808 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7809 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7810 word size.
7811
ec8df744
PE
7812 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7813 (gnutls_make_error): Rename local to avoid shadowing.
7814 (gnutls_emacs_global_deinit): ifdef out; not used.
7815 (Fgnutls_boot): Use const for pointer to readonly storage.
7816 Comment out unused local. Fix pointer signedness problems.
7817
640ee02d
PE
7818 * lread.c (openp): Don't stuff size_t into an 'int'.
7819 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7820 about possible signed overflow.
7821
6048fb2a
PE
7822 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7823 (GDK_KEY_g): Don't define if already defined.
7824 (xg_prepare_tooltip): Avoid pointer signedness problem.
7825 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7826
fa3c87e1
PE
7827 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7828 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7829
2172544b
PE
7830 * xfns.c (Fx_window_property): Simplify a bit,
7831 to make a bit faster and to avoid GCC 4.6.0 warning.
7832 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7833
9b821a21
PE
7834 * fns.c (internal_equal): Don't assume size_t fits in int.
7835
3c616cfa
PE
7836 * alloc.c (compact_small_strings): Tighten assertion a little.
7837
c2982e87
PE
7838 Replace pEd with more-general pI, and fix some printf arg casts.
7839 * lisp.h (pI): New macro, generalizing old pEd macro to other
7840 conversion specifiers. For example, use "...%"pI"d..." rather
7841 than "...%"pEd"...".
7842 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7843 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7844 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7845 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7846 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7847 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7848 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7849 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7850 64-bit hosts.
7851 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7852 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7853 * print.c (safe_debug_print, print_object): Likewise.
7854 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7855 to int.
6f04d126
PE
7856 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7857 avoiding the 0 flag, which is not portable.
c2982e87
PE
7858 * process.c (Fmake_network_process): Use pI to avoid cast.
7859 * region-cache.c (pp_cache): Likewise.
7860 * xdisp.c (decode_mode_spec): Likewise.
7861 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7862 behavior on 64-bit hosts with printf arg.
6f04d126 7863 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7864 (x_stop_queuing_selection_requests): Likewise.
7865 (x_get_window_property): Don't truncate byte count to an 'int'
7866 when tracing.
0b432f21 7867
5e073ec7
PE
7868 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7869 here, since it parses constructs like leading '-' and spaces,
7870 which are not wanted; and it overflows with large numbers.
7871 Instead, simply match F[0-9]+, which is what is wanted anyway.
7872
36372bf9
PE
7873 * alloc.c: Remove unportable assumptions about struct layout.
7874 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7875 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7876 (allocate_vectorlike, make_pure_vector): Use the new macros,
7877 plus offsetof, to remove unportable assumptions about struct layout.
7878 These assumptions hold on all porting targets that I know of, but
7879 they are not guaranteed, they're easy to remove, and removing them
7880 makes further changes easier.
7881
0b432f21
PE
7882 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7883 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7884 (string_overrun_cookie): Now const. Use initializers that
7885 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7886 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7887 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7888 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7889 multiple of sizeof (EMACS_INT); it need not be, if
7890 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7891 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7892
895009e1
JB
78932011-04-26 Juanma Barranquero <lekktu@gmail.com>
7894
7895 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7896
6a7a1b0b
TZ
78972011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7898
7899 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7900 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7901 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7902
841a1577 79032011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7904
7905 * lisp.h (Qdebug): List symbol.
895009e1 7906 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7907 * keyboard.c (debug-on-event): New variable.
7908 (handle_user_signal): Break into debugger when debug-on-event
7909 matches the current signal symbol.
7910
f2d3ba6f
DN
79112011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7912
7913 * alloc.c (check_sblock, check_string_bytes)
7914 (check_string_free_list): Convert to standard C.
7915
42ce4c63
TZ
79162011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7917
7918 * w32.c (emacs_gnutls_push): Fix typo.
7919
825cd63c
EZ
79202011-04-25 Eli Zaretskii <eliz@gnu.org>
7921
fb11d64d
EZ
7922 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7923 "cast to pointer from integer of different size".
7924
825cd63c
EZ
7925 Improve doprnt and its use in verror. (Bug#8545)
7926 * doprnt.c (doprnt): Document the set of format control sequences
7927 supported by the function. Use SAFE_ALLOCA instead of always
7928 using `alloca'.
7929
7930 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7931 is one byte too soon. Don't use xrealloc; instead xfree and
7932 xmalloc anew.
7933
e061a11b
TZ
79342011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7935
7936 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7937 callbacks stage.
7938
7939 * gnutls.c: Renamed global_initialized to
7940 gnutls_global_initialized. Added internals for the
7941 :verify-hostname-error, :verify-error, and :verify-flags
7942 parameters of `gnutls-boot' and documented those parameters in the
7943 docstring. Start callback support.
9173deec
JB
7944 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7945 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7946 on error. Return error code.
e061a11b
TZ
7947 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7948 (emacs_gnutls_read): Likewise.
7949 (Fgnutls_boot): Return handshake error code.
7950 (emacs_gnutls_handle_error): New function.
7951 (wsaerror_to_errno): Likewise.
7952
7953 * w32.h (emacs_gnutls_pull): Add prototype.
7954 (emacs_gnutls_push): Likewise.
7955
7956 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7957 (emacs_gnutls_push): Likewise.
7958
79592011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7960
7961 * process.c (wait_reading_process_output): Check if GnuTLS
7962 buffered some data internally if no FDs are set for TLS
7963 connections.
7964
7965 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7966 (LIBS): Link to USER_LIBS.
7967 ($(BLD)/gnutls.$(0)): New target.
7968
fa6996bc
EZ
79692011-04-24 Eli Zaretskii <eliz@gnu.org>
7970
eb35682e
EZ
7971 * xdisp.c (handle_single_display_spec): Rename the
7972 display_replaced_before_p argument into display_replaced_p, to
7973 make it consistent with the commentary. Fix typos in the
7974 commentary.
7975
e2ad650c
EZ
7976 * textprop.c (syms_of_textprop): Remove dead code.
7977 (copy_text_properties): Delete obsolete commentary about an
7978 interface that was deleted long ago. Fix typos in the description
7979 of arguments.
7980
1b2de274
EZ
7981 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7982 to changes in oldXMenu/XMenu.h from 2011-04-16.
7983 <menu_help_message, prev_menu_help_message>: Constify.
7984 (IT_menu_make_room): menu->help_text is now `const char **';
7985 adjust.
7986
7987 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7988 to changes in oldXMenu/XMenu.h from 2011-04-16.
7989 (struct XMenu): Declare `help_text' `const char **'.
7990
7991 * xfaces.c <Qunspecified>: Make extern again.
7992
7993 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7994 required by POSIX.
1b2de274 7995
762b15be
EZ
7996 * doc.c (get_doc_string): Improve the format passed to `error'.
7997
7998 * doprnt.c (doprnt): Improve commentary.
7999
8000 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8001
8002 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8003 them with etags.
8004
f1052e5d
EZ
8005 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8006 changes in globals.h immediately force recompilation.
762b15be
EZ
8007 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8008 $(CURDIR)/s/ms-w32.h.
8009 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8010
fa6996bc
EZ
8011 * character.c (Fchar_direction): Function deleted.
8012 (syms_of_character): Don't defsubr it.
8013 <char-direction-table>: Deleted.
8014
e6c3da20
EZ
80152011-04-23 Eli Zaretskii <eliz@gnu.org>
8016
8017 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8018 * doprnt.c: Include limits.h.
8019 (SIZE_MAX): New macro.
04f2d78b
CB
8020 (doprnt): Return a size_t value. 2nd arg is now size_t.
8021 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8022 Improve overflow protection. Support `l' modifier for integer
8023 conversions. Support %l conversion. Don't assume an EMACS_INT
8024 argument for integer conversions and for %c.
8025
8026 * lisp.h (doprnt): Restore prototype.
8027
8028 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8029 $(SRC)/character.h.
8030
8031 * Makefile.in (base_obj): Add back doprnt.o.
8032
8033 * deps.mk (doprnt.o): Add back prerequisites.
8034 (callint.o): Depend on character.h.
8035
8036 * eval.c (internal_lisp_condition_case): Include the handler
8037 representation in the error message.
8038 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8039 when breaking from the loop.
8040
8041 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8042
8043 * callint.c (Fcall_interactively): When displaying error message
8044 about invalid control letter, pass the character's codepoint, not
8045 a pointer to its multibyte form. Improve display of the character
8046 in octal and display also its hex code.
8047
8048 * character.c (char_string): Use %x to display the (unsigned)
8049 codepoint of an invalid character, to avoid displaying a bogus
8050 negative value.
8051
8052 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8053 `error', not SYMBOL_NAME itself.
8054
8055 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8056 character arguments to `error'.
8057
8058 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8059 to `error' in error message about FINAL_CHAR argument. Make sure
8060 FINAL_CHAR is a character, and use %c when it is passed as
8061 argument to `error'.
8062
4ffd0d6b 80632011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8064
8065 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8066
8067 * w32.c: Include <time.h>.
8068 (sys_localtime): New function.
8069
4ffd0d6b 80702011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8071
8072 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8073
4ffd0d6b 8074 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8075
4ffd0d6b 80762011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8077
4ffd0d6b
GM
8078 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8079 zombies (Bug#8467).
aac0c6e3 8080
04c56954
EZ
80812011-04-19 Eli Zaretskii <eliz@gnu.org>
8082
8083 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8084 gl_state.e_property when gl_state.object is Qt.
8085
8086 * insdel.c (make_gap_larger): Remove limitation of buffer size
8087 to <= INT_MAX.
8088
16a43933
CY
80892011-04-18 Chong Yidong <cyd@stupidchicken.com>
8090
8091 * xdisp.c (lookup_glyphless_char_display)
8092 (produce_glyphless_glyph): Handle cons cell entry in
8093 glyphless-char-display.
8094 (Vglyphless_char_display): Document it.
8095
8096 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8097 glyphless-char-display.
8098
4581706e
CY
80992011-04-17 Chong Yidong <cyd@stupidchicken.com>
8100
8101 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8102
8103 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8104
8105 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8106 definition for no-X builds.
8107
4887c6e2 81082011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8109
fd35b6f9
PE
8110 Static checks with GCC 4.6.0 and non-default toolkits.
8111
5c1ccb01
PE
8112 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8113
006c5daa
PE
8114 * process.c (keyboard_bit_set): Define only if SIGIO.
8115 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8116 (send_process): Repair possible setjmp clobbering.
8117
efc736d3
PE
8118 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8119
4e2fe2e6
PE
8120 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8121
f97334a2
PE
8122 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8123
4e75f29d
PE
8124 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8125 Define only if needed.
8126
90efadd1
PE
8127 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8128 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8129 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8130
3c647824
PE
8131 * dispextern.h (struct redisplay_interface): Rename param
8132 to avoid shadowing.
e264f262 8133 * termhooks.h (struct terminal): Likewise.
761383f4 8134 * xterm.c (xembed_send_message): Likewise.
3c647824 8135
b58c5c4a
PE
8136 * insdel.c (make_gap_smaller): Define only if
8137 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8138
cad59032
PE
8139 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8140 it.
8141
c339dc2e
PE
8142 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8143 so that we aren't warned about unused symbols.
8144
91a3e27b
PE
8145 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8146
399c71d3 8147 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8148
8ffc96f5
PE
8149 * xfns.c (x_real_positions): Mark locals as initialized.
8150
eef9bc79
PE
8151 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8152
098db9dd
PE
8153 * xterm.c: Fix problems found by static analysis with other toolkits.
8154 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8155 (x_dispatch_event): Declare static if USE_GTK, and
8156 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8157 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8158 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8159 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8160 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8161
eb18f6cc
PE
8162 * xmenu.c (menu_help_callback): Pointer type fixes.
8163 Use const pointers when pointing at readonly data. Avoid pointer
8164 signedness clashes.
8165 (FALSE): Remove unused macro.
8166 (update_frame_menubar): Remove unused decl.
8167
1fe72bf8
PE
8168 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8169
60d9e1db
PE
8170 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8171 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8172 (single_menu_item): Rename local to avoid shadowing.
8173
39261c26
PE
8174 * keyboard.c (make_lispy_event): Remove unused local var.
8175
018c5e19
PE
8176 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8177 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8178
63d2b86e
PE
8179 * bitmaps: Change bitmaps from unsigned char back to the X11
8180 compatible char. Avoid the old compiler warnings about
8181 out-of-range initializers by using, for example, '\xab' rather
8182 than 0xab.
8183
aefd87e1
PE
8184 * xgselect.c (xgselect_initialize): Check vs interface
8185 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8186
bf501fb9
PE
8187 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8188
e9829fdf
PE
8189 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8190 to read-only memory.
8191
1086c095
PE
8192 * fns.c (vector): Remove; this old hack is no longer needed.
8193
2baccd04 8194 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8195 Remove unused var.
dde42981 8196 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8197
72391843 8198 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8199
436c16df 8200 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8201 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8202 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8203
92bb796d 8204 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8205 (x_term_init): Remove local to avoid shadowing.
92bb796d 8206
764430a3 8207 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8208
8209 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8210 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8211
d1dfb56c
EZ
82122011-04-16 Eli Zaretskii <eliz@gnu.org>
8213
c4354cb4
EZ
8214 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8215
d1dfb56c
EZ
8216 Fix regex.c, syntax.c and friends for buffers > 2GB.
8217 * syntax.h (struct gl_state_s): Declare character position members
8218 EMACS_INT.
8219
8220 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8221
04f2d78b
CB
8222 * textprop.c (verify_interval_modification, interval_of):
8223 Declare arguments EMACS_INT.
d1dfb56c
EZ
8224
8225 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8226 EMACS_INT.
8227
8228 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8229
8230 * indent.c (Fvertical_motion): Local variable it_start is now
8231 EMACS_INT.
8232
8233 * regex.c (re_match, re_match_2, re_match_2_internal)
8234 (bcmp_translate, regcomp, regexec, print_double_string)
8235 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8236 (re_compile_pattern, re_exec): Declare arguments and local
8237 variables `size_t' and `ssize_t' and return values `regoff_t', as
8238 appropriate.
8239 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8240 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8241 <compile_stack_type>: `size' and `avail' are now `size_t'.
8242
8243 * regex.h <regoff_t>: Use ssize_t, not int.
8244 (re_search, re_search_2, re_match, re_match_2): Arguments that
8245 specify buffer/string position and length are now ssize_t and
8246 size_t. Return type is regoff_t.
8247
613052cd
BK
82482011-04-16 Ben Key <bkey76@gmail.com>
8249
8250 * nsfont.m: Fixed bugs in ns_get_family and
8251 ns_descriptor_to_entity that were caused by using free to
8252 deallocate memory blocks that were allocated by xmalloc (via
8253 xstrdup). This caused Emacs to crash when compiled with
8254 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8255 --enable-checking=xmallocoverrun). xfree is now used to
8256 deallocate these memory blocks.
8257
4170f62f 82582011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8259
71b41406
PE
8260 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8261
9587a89d
PE
8262 emacs_write: Accept and return EMACS_INT for sizes.
8263 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8264 et seq.
8265 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8266 Accept and return EMACS_INT.
8267 (emacs_gnutls_write): Return the number of bytes written on
8268 partial writes.
8269 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8270 (emacs_read, emacs_write): Remove check for negative size, as the
8271 Emacs source code has been audited now.
9587a89d
PE
8272 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8273 (emacs_read, emacs_write): Use it.
273a5f82
PE
8274 * process.c (send_process): Adjust to the new signatures of
8275 emacs_write and emacs_gnutls_write. Do not attempt to store
8276 a byte offset into an 'int'; it might overflow.
9587a89d 8277 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8278
3e047f51
PE
8279 * sound.c: Don't assume sizes fit in 'int'.
8280 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8281 Return EMACS_INT, not int.
3e047f51 8282 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8283 Accept EMACS_INT, not int.
8284 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8285 record read return values.
8286
cc39a9db
BK
82872011-04-15 Ben Key <bkey76@gmail.com>
8288
c9d0ec6d
JB
8289 * keyboard.c (Qundefined): Don't declare static since it is used
8290 in nsfns.m.
8291 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8292 static since they are used in nsfont.m.
cc39a9db 8293
6c60eb9f
SM
82942011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8295
8296 * process.c (Qprocessp): Don't declare static.
8297 * lisp.h (Qprocessp): Declare again.
8298
7990b61a
JB
82992011-04-15 Juanma Barranquero <lekktu@gmail.com>
8300
8301 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8302
5d4cb038
PE
83032011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8304
8bd7b830 8305 Improve C-level modularity by making more things 'static'.
cd64ea1d 8306
e3b27b31
PE
8307 Don't publish debugger-only interfaces to other modules.
8308 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8309 (verify_bytepos, count_markers): Move decls to the only modules
8310 that need them.
8311 * region-cache.h (pp_cache): Likewise.
8312 * window.h (check_all_windows): Likewise.
8313 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8314
5d4cb038
PE
8315 * sysdep.c (croak): Now static, if
8316 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8317 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8318
8319 * alloc.c (refill_memory_reserve): Now static if
8320 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8321 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8322
e87b6180
PE
8323 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8324 Define only if USE_LUCID.
8325
ac64929e
PE
8326 * xrdb.c (x_customization_string, x_rm_string): Now static.
8327
6f37259d
PE
8328 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8329 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8330
1683e3ab
PE
8331 * xdisp.c (draw_row_with_mouse_face): Now static.
8332 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8333
de9c2632
PE
8334 * window.h (check_all_windows): Mark externally visible.
8335
2b96acb7
PE
8336 * window.c (window_deletion_count): Now static.
8337
8338 * undo.c: Make symbols static if they're not exported.
8339 (last_undo_buffer, last_boundary_position, pending_boundary):
8340 Now static.
8341
50436f33
PE
8342 * textprop.c (interval_insert_behind_hooks): Now static.
8343 (interval_insert_in_front_hooks): Likewise.
8344
64520e5c
PE
8345 * term.c: Make symbols static if they're not exported.
8346 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8347 (max_frame_lines, tty_set_terminal_modes):
8348 (tty_reset_terminal_modes, tty_turn_off_highlight):
8349 (get_tty_terminal): Now static.
8350 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8351 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8352 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8353 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8354 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8355
1fa53021
PE
8356 * sysdep.c: Make symbols static if they're not exported.
8357 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8358 Now static.
8359 (sigprocmask_set, full_mask): Remove; unused.
8360 (wait_debugging): Mark as visible.
8361 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8362 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8363
d4b43b22
PE
8364 * syntax.c (syntax_temp): Define only if !__GNUC__.
8365
b7c513d0
PE
8366 * sound.c (current_sound_device, current_sound): Now static.
8367
989b29ad
PE
8368 * search.c (searchbufs, searchbuf_head): Now static.
8369
13a55a78
PE
8370 * scroll.c (scroll_cost): Remove; unused.
8371 * dispextern.h (scroll_cost): Remove decl.
8372
de68a1fc
PE
8373 * region-cache.h (pp_cache): Mark as externally visible.
8374
40ccffa6
PE
8375 * process.c: Make symbols static if they're not exported.
8376 (process_tick, update_tick, create_process, chan_process):
8377 (Vprocess_alist, proc_buffered_char, datagram_access):
8378 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8379 (deactivate_process): Mark defn as static, as well as decl.
8380 * lisp.h (create_process): Remove decl.
8381 * process.h (chan_process, Vprocess_alist): Remove decls.
8382
ad64fc97
PE
8383 * print.c: Make symbols static if they're not exported.
8384 (print_depth, new_backquote_output, being_printed, print_buffer):
8385 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8386 (print_interval, print_number_index, initial_stderr_stream):
8387 Now static.
8388 * lisp.h (Fprinc): Remove decl.
8389 (debug_output_compilation_hack): Mark as externally visible.
8390
adddb265
PE
8391 * sysdep.c (croak): Move decl from here to syssignal.h.
8392 * syssignal.h (croak): Put it here, so the API can be checked when
8393 'croak' is called from dissociate_if_controlling_tty.
8394
1717ede2
PE
8395 * minibuf.c: Make symbols static if they're not exported.
8396 (minibuf_save_list, choose_minibuf_frame): Now static.
8397 * lisp.h (choose_minibuf_frame): Remove decl.
8398
fa5fb2bc
PE
8399 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8400
1e3890d1
PE
8401 * lread.c: Make symbols static if they're not exported.
8402 (read_objects, initial_obarray, oblookup_last_bucket_number):
8403 Now static.
8404 (make_symbol): Remove; unused.
8405 * lisp.h (initial_obarray, make_symbol): Remove decls.
8406
8a1414fa
PE
8407 * keyboard.c: Make symbols static if they're not exported.
8408 (single_kboard, recent_keys_index, total_keys, recent_keys):
8409 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8410 (this_single_command_key_start, echoing, last_auto_save):
8411 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8412 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8413 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8414 (Vlispy_mouse_stem, double_click_count):
8415 Now static.
8416 (force_auto_save_soon): Define only if SIGDANGER.
8417 (ignore_mouse_drag_p): Now static if
8418 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8419 (print_help): Remove; unused.
8420 (stop_character, last_timer_event): Mark as externally visible.
8421 * keyboard.h (ignore_mouse_drag_p): Declare only if
8422 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8423 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8424 * lisp.h (echoing): Remove decl.
8425 (force_auto_save_soon): Declare only if SIGDANGER.
8426 * xdisp.c (redisplay_window): Simplify code, to make it more
8427 obvious that ignore_mouse_drag_p is not accessed if !defined
8428 USE_GTK && !defined HAVE_NS.
8429
93ea6e8f
PE
8430 * intervals.c: Make symbols static if they're not exported.
8431 (merge_properties_sticky, merge_interval_right, delete_interval):
8432 Now static.
8433 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8434
77382fcc
PE
8435 * insdel.c: Make symbols static if they're not exported.
8436 However, leave prepare_to_modify_buffer alone. It's never
8437 called from outside this function, but that appears to be a bug.
8438 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8439 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8440 (adjust_after_replace_noundo): Remove; unused.
8441 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8442 (signal_before_change): Remove decls.
77382fcc 8443
9306c32e
PE
8444 * indent.c (val_compute_motion, val_vmotion): Now static.
8445
cd44d2eb
PE
8446 * image.c: Make symbols static if they're not exported.
8447 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8448 if USE_GTK.
8449 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8450 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8451
ad9a7a06
PE
8452 * fringe.c (standard_bitmaps): Now static.
8453 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8454
81626931
PE
8455 * frame.c: Make symbols static if they're not exported.
8456 (x_report_frame_params, make_terminal_frame): Now static.
8457 (get_frame_param): Now static, unless HAVE_NS.
8458 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8459 (x_get_resource_string): Remove; not used.
8460 * frame.h (make_terminal_frame, x_report_frame_params):
8461 (x_get_resource_string); Remove decls.
8462 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8463 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8464
239f9db9
PE
8465 * font.c, fontset.c: Make symbols static if they're not exported.
8466 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8467 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8468 * font.c (font_close_object): Now static.
8469 * font.h (font_close_object): Remove.
8470 * fontset.c (FONTSET_OBJLIST): Remove.
8471 (free_realized_fontset) #if-0 the body, which does nothing.
8472 (face_suitable_for_char_p): #if-0, as it's never called.
8473 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8474 * xfaces.c (face_at_string_position):
8475 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8476 since 0 is always ASCII.
8477
dfcf3579
PE
8478 * fns.c (weak_hash_tables): Now static.
8479
5045092b
PE
8480 * fileio.c: Make symbols static if they're not exported.
8481 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8482 (Vwrite_region_annotation_buffers): Now static.
8483
57a96f5c
PE
8484 * eval.c: Make symbols static if they're not exported.
8485 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8486 * lisp.h (backtrace_list): Remove decl.
8487
35f08c38
PE
8488 * emacs.c: Make symbols static if they're not exported.
8489 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8490 (fatal_error_code, fatal_error_signal_hook, standard_args):
8491 Now static.
8492 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8493 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8494 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8495 * lisp.h (fatal_error_signal_hook): Remove decl.
8496 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8497
f44bd759
PE
8498 * editfns.c: Move a (normally-unused) function to its only use.
8499 * editfns.c, lisp.h (get_operating_system_release): Remove.
8500 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8501 worth the hassle of breaking this out.
8502
b532497d
PE
8503 * xterm.c: Make symbols static if they're not exported.
8504 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8505 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8506 (x_destroy_window, x_delete_display):
8507 Now static.
8508 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8509 (x_mouse_leave): Remove; unused.
8510 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8511 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8512 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8513 Remove decls.
8514 (x_mouse_leave): Declare only if WINDOWSNT.
8515 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8516 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8517 USE_X_TOOLKIT.
8518
1675728f
PE
8519 * ftxfont.c: Make symbols static if they're not exported.
8520 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8521 HAVE_FREETYPE.
8522 * font.h (ftxfont_driver): Likewise.
8523
e4cebfca
PE
8524 * xfns.c: Make symbols static if they're not exported.
8525 (x_last_font_name, x_display_info_for_name):
8526 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8527 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8528 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8529 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8530 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8531 (last_show_tip_args): Now static.
8532 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8533 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8534 (x_screen_planes): Remove; unused.
8535 * dispextern.h (x_screen_planes): Remove decl.
8536
5bf46f05
PE
8537 * dispnew.c: Make symbols static if they're not exported.
8538 * dispextern.h (redraw_garbaged_frames, scrolling):
8539 (increment_row_positions): Remove.
8540 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8541 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8542 Now static.
8543 (redraw_garbaged_frames): Remove; unused.
8544
435f4c28
PE
8545 * xfaces.c: Make symbols static if they're not exported.
8546 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8547 Remove decls.
8548 * xterm.h (defined_color): Remove decls.
8549 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8550 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8551 (menu_face_changed_default, defined_color, free_realized_face):
8552 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8553 (ascii_face_of_lisp_face): Remove; unused.
8554
8524aef3
PE
8555 * xdisp.c: Make symbols static if they're not exported.
8556 * dispextern.h (scratch_glyph_row, window_box_edges):
8557 (glyph_to_pixel_coords, set_cursor_from_row):
8558 (get_next_display_element, set_iterator_to_next):
8559 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8560 (show_mouse_face): Remove decls
8561 * frame.h (message_buf_print): Likewise.
8562 * lisp.h (pop_message, set_message, check_point_in_composition):
8563 Likewise.
8564 * xterm.h (set_vertical_scroll_bar): Likewise.
8565 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8566 (message_buf_print, scratch_glyph_row, displayed_buffer):
8567 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8568 (get_next_display_element, show_mouse_face, window_box_edges):
8569 (frame_to_window_pixel_xy, check_point_in_composition):
8570 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8571 (glyph_to_pixel_coords): Remove; unused.
8572
16390cd2
PE
8573 * dired.c (file_name_completion): Now static.
8574
8575 * dbusbind.c (xd_in_read_queued_messages): Now static.
8576
a25f4dfa
PE
8577 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8578 * data.c (circular_list_error): Remove.
8579
14a9c8df
PE
8580 * commands.h (last_point_position, last_point_position_buffer):
8581 (last_point_position_window): Remove decls.
8582 * keyboard.c: Make these variables static.
8583
04f2d78b
CB
8584 * coding.h (coding, code_convert_region, encode_coding_gap):
8585 Remove decls.
74ab6df5
PE
8586 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8587 (iso_code_class, detect_coding, code_convert_region): Now static.
8588 (encode_coding_gap): Remove; unused.
8589
38dfbee1
PE
8590 * chartab.c (chartab_chars, chartab_bits): Now static.
8591
a2cb4e63
PE
8592 * charset.h (charset_iso_8859_1): Remove decl.
8593 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8594 Now static.
8595
127198fd
PE
8596 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8597 * ccl.c (Vccl_program_table): Now static.
8598 (check_ccl_update): Remove; unused.
8599
d85b608f
PE
8600 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8601 * category.h: ... from here.
8602 * category.c (check_category_table, set_category_set): Now static.
8603
31cd66f3
PE
8604 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8605 * lisp.h: Remove these decls.
8606
c358e587
PE
8607 * buffer.c (buffer_count): Remove unused var.
8608
e78aecca
PE
8609 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8610 so that it's not optimized away.
8611 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8612 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8613 exported only to the debugger.
8614
e192d7d3 8615 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8616 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8617
92470028
PE
8618 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8619 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8620 was inaccessible from Lisp.
8621 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8622 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8623
244ed907
PE
8624 alloc.c: Import and export fewer symbols, and remove unused items.
8625 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8626 is defined.
8627 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8628 it's not optimized away by whole-program optimization.
8629 (message_enable_multibyte, free_misc): Remove.
8630 (catchlist, handlerlist, mark_backtrace):
8631 Declare only if BYTE_MARK_STACK.
8632 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8633 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8634 (message_enable_multibyte): Remove decl.
8635 (free_misc, interval_free_list, float_block, float_block_index):
8636 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8637 (cons_free_list, last_marked_index):
8638 Now static.
8639 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8640 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8641 (mark_backtrace): Define only if BYTE_MARK_STACK.
8642 * xdisp.c (message_enable_multibyte): Now static.
8643
61c2b50e 8644 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8645 This makes it easier for human readers (and static analyzers)
8646 to see whether these variables are used from other modules.
8647 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8648 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8649 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8650 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8651 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8652 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8653 * xmenu.c, xselect.c:
8654 Declare Q* vars static if they are not used in other modules.
8655 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8656 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8657 Remove decls of unexported vars.
8658 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8659
95c82688
PE
8660 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8661
16a97296
PE
8662 Make Emacs functions such as Fatom 'static' by default.
8663 This makes it easier for human readers (and static analyzers)
8664 to see whether these functions can be called from other modules.
8665 DEFUN now defines a static function. To make the function external
8666 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8667 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8668 (Finit_image_library):
16a97296
PE
8669 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8670 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8671 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8672 Remove decls, since these functions are now static.
8673 (Funintern, Fget_internal_run_time): New decls, since these functions
8674 were already external.
95c82688 8675
16a97296
PE
8676 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8677 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8678 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8679 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8680 * keyboard.c, keymap.c, lread.c:
8681 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8682 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8683 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8684 Mark functions with DEFUE instead of DEFUN,
8685 if they are used in other modules.
8686 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8687 decls for now-static functions.
8688 * buffer.h (Fdelete_overlay): Remove decl.
8689 * callproc.c (Fgetenv_internal): Mark as internal.
8690 * composite.c (Fremove_list_of_text_properties): Remove decl.
8691 (Fcomposition_get_gstring): New forward static decl.
8692 * composite.h (Fcomposite_get_gstring): Remove decl.
8693 * dired.c (Ffile_attributes): New forward static decl.
8694 * doc.c (Fdocumntation_property): New forward static decl.
8695 * eval.c (Ffetch_bytecode): New forward static decl.
8696 (Funintern): Remove extern decl; now in .h file where it belongs.
8697 * fileio.c (Fmake_symbolic_link): New forward static decl.
8698 * image.c (Finit_image_library): New forward static decl.
8699 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8700 * intervals.h (Fprevious_property_change):
8701 (Fremove_list_of_text_properties): Remove decls.
8702 * keyboard.c (Fthis_command_keys): Remove decl.
8703 (Fcommand_execute): New forward static decl.
8704 * keymap.c (Flookup_key): New forward static decl.
8705 (Fcopy_keymap): Now static.
8706 * keymap.h (Flookup_key): Remove decl.
8707 * process.c (Fget_process): New forward static decl.
8708 (Fprocess_datagram_address): Mark as internal.
8709 * syntax.c (Fsyntax_table_p): New forward static decl.
8710 (skip_chars): Remove duplicate decl.
8711 * textprop.c (Fprevious_property_change): New forward static decl.
8712 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8713 Now internal.
8714 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8715 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8716
785bbd42
PE
8717 * editfns.c (Fformat): Remove unreachable code.
8718
8b913b57
AS
87192011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8720
8721 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8722 change. (Bug#8496)
8723
a6744a35
EZ
87242011-04-13 Eli Zaretskii <eliz@gnu.org>
8725
8726 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8727 when at ZV. (Bug#8487)
8728
e7974947
AS
87292011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8730
baad03f0
AS
8731 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8732 (Bug#8437)
8733 * keyboard.c (parse_tool_bar_item): Likewise.
8734 * sound.c (sound_cleanup, alsa_close): Likewise.
8735 * termcap.c (tgetent): Likewise.
8736 * xfns.c (x_default_font_parameter): Likewise.
8737 * xsettings.c (read_and_apply_settings): Likewise.
8738
e7974947
AS
8739 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8740 (overrun_check_free): Protoize.
8741
28272684
PE
87422011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8743
8744 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8745 since callers should never pass a negative size.
8746 Change the signature to match that of plain 'read' and 'write'; see
8747 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8748 * lisp.h: Update prototypes of emacs_write and emacs_read.
8749
11997c76
EZ
87502011-04-11 Eli Zaretskii <eliz@gnu.org>
8751
8752 * xdisp.c (redisplay_window): Don't try to determine the character
8753 position of the scroll margin if the window start point w->startp
e896f03c 8754 is outside the buffer's accessible region. (Bug#8468)
11997c76 8755
8a2cbd72
EZ
87562011-04-10 Eli Zaretskii <eliz@gnu.org>
8757
8758 Fix write-region and its subroutines for buffers > 2GB.
8759 * fileio.c (a_write, e_write): Modify declaration of arguments and
8760 local variables to support buffers larger than 2GB.
8761 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8762
8763 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8764 argument, local variables, and return value.
8765
8766 * lisp.h: Update prototypes of emacs_write and emacs_read.
8767
8768 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8769
4073e537 87702011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8771
1ebfdcb6
PE
8772 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8773
b2ded58d
PE
8774 Fix more problems found by GCC 4.6.0's static checks.
8775
7d66342c
PE
8776 * xdisp.c (vmessage): Use a better test for character truncation.
8777
bbf47d44
PE
8778 * charset.c (load_charset_map): <, not <=, for optimization,
8779 and to avoid potential problems with integer overflow.
9248994d 8780 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8781 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8782 * editfns.c (Fformat): Likewise.
1e69125e 8783 * syntax.c (skip_chars): Likewise.
3befa583 8784
e3019616
PE
8785 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8786 This also lets GCC 4.6.0 generate slightly better loop code.
8787
becfa255
PE
8788 * callint.c (Fcall_interactively): <, not <=, for optimization.
8789 (Fcall_interactively): Count the number of arguments produced,
8790 not the number of arguments given. This is simpler and lets GCC
8791 4.6.0 generate slightly better code.
8792
dae0cd48
PE
8793 * ftfont.c: Distingish more carefully between FcChar8 and char.
8794 The previous code passed unsigned char * to a functions like
8795 strlen and xstrcasecmp that expect char *, which does not
8796 conform to the C standard.
8797 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8798 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8799 char * when the C standard requires it.
8800
76032d70
PE
8801 * keyboard.c (read_char): Remove unused var.
8802
eb3f1cc8
PE
8803 * eval.c: Port to Windows vsnprintf (Bug#8435).
8804 Include <limits.h>.
8805 (SIZE_MAX): Define if the headers do not.
8806 (verror): Do not give up if vsnprintf returns a negative count.
8807 Instead, grow the buffer. This ports to Windows vsnprintf, which
8808 does not conform to C99. Problem reported by Eli Zaretskii.
8809 Also, simplify the allocation scheme, by avoiding the need for
8810 calling realloc, and removing the ALLOCATED variable.
8811
70476b54
PE
8812 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8813
12020a9e
PE
8814 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8815 But keep the doprint source code for now, as we might revamp it
8816 and use it again (Bug#8435).
ea6c7ae6
PE
8817 * lisp.h (doprnt): Remove.
8818 * Makefile.in (base_obj): Remove doprnt.o.
8819 * deps.mk (doprnt.o): Remove.
8820
5fdb398c
PE
8821 error: Print 32- and 64-bit integers portably (Bug#8435).
8822 Without this change, on typical 64-bit hosts error ("...%d...", N)
8823 was used to print both 32- and 64-bit integers N, which relied on
8824 undefined behavior.
61bdb816 8825 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8826 * lisp.h (error, verror): Mark as printf-like functions.
8827 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8828 Report overflow in size calculations when allocating printf buffer.
8829 Do not truncate output string at its first null byte.
8830 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8831 Truncate the output at a character boundary, since vsnprintf does not
8832 do that.
8833 * charset.c (check_iso_charset_parameter): Convert internal
8834 character to string before calling 'error', since %c now has the
8835 printf meaning.
8836 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8837 overflow when computing char to be passed to 'error'. Do not
8838 pass Lisp_Object to 'error'; pass the integer instead.
8839 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8840 formatted with plain %d.
8841
b189fa66
PE
8842 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8843
bff87ef0
PE
8844 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8845
7e2cac20
PE
8846 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8847
ce4d90b5
PE
8848 * xterm.c (x_catch_errors): Remove duplicate declaration.
8849
266c9547
PE
8850 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8851
79c49ad2
PE
8852 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8853
368f4090
JM
88542011-04-10 Jim Meyering <meyering@redhat.com>
8855
8856 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8857 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8858 return ssize_t not "int", and use size_t as the buffer length.
8859 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8860 * gnutls.h: Update declarations.
8861 * process.c (read_process_output): Use ssize_t, to match.
8862 (send_process): Likewise.
8863
a32d4040
CY
88642011-04-09 Chong Yidong <cyd@stupidchicken.com>
8865
8866 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8867
8546720e 88682011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8869
04f2d78b
CB
8870 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8871 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8872
8546720e
GM
8873 * xterm.c (handle_one_xevent):
8874 * xmenu.c (create_and_show_popup_menu):
8875 * xselect.c (x_decline_selection_request)
8876 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8877
0a2f5c1a 88782011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8879
8880 Fix some uses of `int' instead of EMACS_INT.
8881 * search.c (string_match_1, fast_string_match)
8882 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8883 (scan_buffer, find_next_newline_no_quit)
8884 (find_before_next_newline, search_command, Freplace_match)
8885 (Fmatch_data): Make some `int' variables be EMACS_INT.
8886
8887 * xdisp.c (display_count_lines): 3rd argument and return value now
8888 EMACS_INT. All callers changed.
8889 (pint2hrstr): Last argument is now EMACS_INT.
8890
8891 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8892 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8893 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8894 (decode_coding_utf_16, decode_coding_emacs_mule)
8895 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8896 (decode_coding_ccl, decode_coding_charset)
8897 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8898 (decode_coding_iso_2022, decode_coding_emacs_mule)
8899 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8900 <char_offset, last_offset>: Declare EMACS_INT.
8901 (encode_coding_utf_8, encode_coding_utf_16)
8902 (encode_coding_emacs_mule, encode_invocation_designation)
8903 (encode_designation_at_bol, encode_coding_iso_2022)
8904 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8905 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8906 Declare EMACS_INT.
8907 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8908 (encode_invocation_designation): Last argument P_NCHARS is now
8909 EMACS_INT.
8910 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8911 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8912
8913 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8914 All users changed.
8915
8916 * ccl.c (Fccl_execute_on_string): Declare some variables
8917 EMACS_INT.
8918
8546720e 89192011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8920
8921 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8922
4e19a977
CS
89232011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8924
8925 * process.c (Fformat_network_address): Doc fix.
8926
87302331
R
89272011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8928
ee7683eb 8929 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8930
cbb59342
CY
89312011-04-08 Chong Yidong <cyd@stupidchicken.com>
8932
8933 * keyboard.c (read_char): Call Lisp function help-form-show,
8934 instead of using internal_with_output_to_temp_buffer.
8935 (Qhelp_form_show): New var.
e0d38eeb 8936 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8937
8938 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8939
8940 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8941
e67a13ab
CY
89422011-04-06 Chong Yidong <cyd@stupidchicken.com>
8943
04f2d78b
CB
8944 * process.c (Flist_processes): Remove to Lisp.
8945 (list_processes_1): Delete.
e67a13ab 8946
973f782d
EZ
89472011-04-06 Eli Zaretskii <eliz@gnu.org>
8948
7c106b1e
EZ
8949 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8950
973f782d
EZ
8951 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8952
41cf7d1a 89532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8954
ca23cc88
PE
8955 Fix more problems found by GCC 4.6.0's static checks.
8956
f390e2d5
PE
8957 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8958
42eea0d0
PE
8959 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8960
b69769da 8961 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8962
f9541e84
PE
8963 * xdisp.c (vmessage): Mark as a printf-like function.
8964
13841b55
PE
8965 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8966
c136c10f
PE
8967 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8968
5e2d4a30
PE
8969 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8970 printf-like functions.
8971 (tiff_load): Add casts to remove these marks before passing them
8972 to system-supplied API.
8973
583f48b9
PE
8974 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8975
b25d760e
PE
8976 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8977 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8978 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8979 directly, rather than having caller test rule sign. This avoids
8980 some unnecessary tests.
8981 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8982 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8983 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8984
bc7b6697 8985 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8986 (xfont_open): Avoid unnecessary tests.
bc7b6697 8987
27ccc379
PE
8988 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8989
dcd5c89a
PE
8990 * composite.h, composite.c (composition_gstring_put_cache):
8991 Use EMACS_INT, not int, for length.
8992
b13a45c6
PE
8993 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8994 breaking out part of COMPOSITION_DECODE_RULE.
8995 (COMPOSITION_DECODE_RULE): Use it.
8996 * composite.c (get_composition_id): Remove unused local vars,
8997 by using the new macro.
8998
1e792e4d
PE
8999 * textprop.c (set_text_properties_1): Change while to do-while,
9000 since the condition is always true at first.
9001
dc6c6455 9002 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
9003 (interval_deletion_adjustment): Return unsigned value.
9004 All uses changed.
dc6c6455 9005
aba7731a
PE
9006 * process.c (list_processes_1, create_pty, read_process_output):
9007 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9008 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9009 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9010 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9011 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9012
fdfc4bf3
PE
9013 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9014
fca8fe46 9015 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9016 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9017
06a0259a 9018 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9019 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9020 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9021
e7b9e80f
PE
9022 * print.c (print_error_message): Avoid int overflow.
9023
56201685
PE
9024 * font.c (font_list_entities): Redo for clarity,
9025 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9026
78834453 9027 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9028 (font_score): Avoid potential overflow in diff calculation.
78834453 9029
0bc0b309 9030 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9031 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9032
e610eaca
PE
9033 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9034
b895abce
PE
9035 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9036 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9037 can always succeed if overflow has undefined behavior.
9038
1f1d9321 9039 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9040 (wordify): Omit three unnecessary tests.
1f1d9321 9041
c59478bc
PE
9042 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9043 All callers changed. This avoids the need for an unused var.
9044
79b73827
PE
9045 * casefiddle.c (casify_region): Remove var that is set but not used.
9046
a4db5dfe
PE
9047 * dired.c (file_name_completion): Remove var that is set but not used.
9048
43aae36e
PE
9049 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9050
2a47c44d 9051 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9052 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9053
a37c69bf
PE
9054 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9055 Check for integer overflow on size calculations.
9056
328ab8e7
PE
9057 * buffer.c (Fprevious_overlay_change): Remove var that is set
9058 but not used.
9059
e5a2a5cb
PE
9060 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9061 Remove vars that are set but not used.
8d84a6eb 9062 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9063 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9064
a60e5f68
PE
9065 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9066
f661cb61 9067 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9068 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9069
f0397f5a
PE
9070 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9071 that are set but not used.
9072
8664db06 9073 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9074 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9075
6abdaa4a
PE
9076 * xselect.c (x_get_local_selection, x_handle_property_notify):
9077 Remove vars that are set but not used.
9078
0ce7538d 9079 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9080 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9081
9ae848fc
PE
9082 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9083 Remove var that is set but not used.
0b918413
PE
9084 (scroll_bar_windows_size): Now size_t, not int.
9085 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9086 Check for overflow.
9ae848fc 9087
a5a62657
PE
9088 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9089 (map_tty_color) [!defined MSDOS]: Likewise.
9090
5c5cdd39
PE
9091 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9092
66ebf983
PE
9093 * coding.c: Remove vars that are set but not used.
9094 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9095 All callers changed.
9096 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9097 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9098 (decode_coding_charset): Remove vars that are set but not used.
9099
1be4d761
PE
9100 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9101 that is set but not used.
9102
47553fa8
PE
9103 * print.c (print_object): Remove var that is set but not used.
9104
1f7196bf 9105 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9106 The gnulib version avoids calling malloc in the usual case,
9107 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9108 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9109 * filelock.c (current_lock_owner): Likewise.
9110 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9111 * sysdep.c: Include allocator.h, careadlinkat.h.
9112 (emacs_no_realloc_allocator): New static constant.
9113 (emacs_readlink): New function.
fdb61804
PE
9114 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9115 ../lib/careadlinkat.h.
d1fdcab7 9116
f84c17c7
SM
91172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9118
9119 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9120 first non-nil return value).
9121
ef3862ad
JD
91222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9123
9124 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9125 if not defined (Bug#8403).
9126
376a7006
JB
91272011-04-02 Juanma Barranquero <lekktu@gmail.com>
9128
9129 * xdisp.c (display_count_lines): Remove parameter `start',
9130 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9131 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9132 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9133 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9134 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9135 and thereabouts. All callers changed.
9136 (get_per_char_metric): Remove parameter `f', unused since
9137 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9138
6ca3801d
JM
91392011-04-02 Jim Meyering <meyering@redhat.com>
9140
9141 do not dereference NULL upon failed strdup
9142 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9143 (ns_get_family): Likewise.
9144
d8e2b5ba
JB
91452011-04-02 Juanma Barranquero <lekktu@gmail.com>
9146
9147 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9148
8c74fcbd
JD
91492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9150
9151 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9152 later (Bug#8403).
9153
7200d79c
SM
91542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9155
03408648 9156 Add lexical binding.
7200d79c 9157
03408648
SM
9158 * window.c (Ftemp_output_buffer_show): New fun.
9159 (Fsave_window_excursion):
9160 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9161
9162 * lread.c (lisp_file_lexically_bound_p): New function.
9163 (Fload): Bind Qlexical_binding.
9164 (readevalloop): Remove `evalfun' arg.
9165 Bind Qinternal_interpreter_environment.
9166 (Feval_buffer): Bind Qlexical_binding.
9167 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9168 Mark as dynamic.
9169 (syms_of_lread): Declare `lexical-binding'.
9170
9171 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9172
9173 * keyboard.c (eval_dyn): New fun.
9174 (menu_item_eval_property): Use it.
ca105506
SM
9175
9176 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9177
03408648
SM
9178 * fns.c (concat, mapcar1): Accept byte-code-functions.
9179
9180 * eval.c (Fsetq): Handle lexical vars.
9181 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9182 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9183 (FletX, Flet): Obey lexical binding.
9184 (Fcommandp): Handle closures.
9185 (Feval): New `lexical' arg.
9186 (eval_sub): New function extracted from Feval. Use it almost
9187 everywhere where Feval was used. Look up vars in lexical env.
9188 Handle closures.
9189 (Ffunctionp): Move from subr.el.
9190 (Ffuncall): Handle closures.
9191 (apply_lambda): Remove `eval_flags'.
9192 (funcall_lambda): Handle closures and new byte-code-functions.
9193 (Fspecial_variable_p): New function.
9194 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9195 but without exporting it to Lisp.
23aba0ea 9196
23aba0ea 9197 * doc.c (Fdocumentation, store_function_docstring):
03408648 9198 * data.c (Finteractive_form): Handle closures.
23aba0ea 9199
03408648
SM
9200 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9201 interactive spec.
ba83908c 9202
04f2d78b
CB
9203 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9204 New byte-codes.
03408648
SM
9205 (exec_byte_code): New function extracted from Fbyte_code to handle new
9206 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9207
03408648 9208 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9209
03408648 9210 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9211
e2abce01
JB
92122011-03-31 Juanma Barranquero <lekktu@gmail.com>
9213
9214 * xdisp.c (redisplay_internal): Fix prototype.
9215
63696a73 92162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9217
63696a73 9218 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9219 (try_scrolling): Use it when setting scroll_limit.
9220 Limit scrolling to 100 screen lines.
63696a73
EZ
9221 (redisplay_window): Even when falling back on "recentering",
9222 position point in the window according to scroll-conservatively,
9223 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9224
9225 (try_scrolling): When point is above the window, allow searching
9226 as far as scroll_max, or one screenful, to compute vertical
9227 distance from PT to the scroll margin position. This prevents
9228 try_scrolling from unnecessarily failing when
9229 scroll-conservatively is set to a value slightly larger than the
9230 window height. Clean up the case of PT below the margin at bottom
9231 of window: scroll_max can no longer be INT_MAX. When aggressive
9232 scrolling is in use, don't let point enter the opposite scroll
9233 margin as result of the scroll.
9234 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9235 threshold of 100 lines for never-recentering scrolling.
9236
e4cc2dfc
JB
92372011-03-31 Juanma Barranquero <lekktu@gmail.com>
9238
9239 * dispextern.h (move_it_by_lines):
9240 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9241 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9242 (message_log_check_duplicate): Remove parameters `prev_bol' and
9243 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9244 (redisplay_internal): Remove parameter `preserve_echo_area',
9245 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9246
9247 * indent.c (Fvertical_motion):
9248 * window.c (window_scroll_pixel_based, Frecenter):
9249 Don't pass `need_y_p' to `move_it_by_lines'.
9250
1c470562
SM
92512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9252
44f230aa
SM
9253 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9254 steal a few bits to be more compact.
9255 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9256 Remove unneeded casts.
9257
1c470562
SM
9258 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9259
888adce9
ZK
92602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9261
9262 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9263 binding" message (bug#7967).
9264
f838ed7b
PE
92652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9266
77861b95
PE
9267 Fix more problems found by GCC 4.6.0's static checks.
9268
de6dbc14
PE
9269 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9270 Remove unused local var.
9271
f838ed7b
PE
9272 * editfns.c (Fmessage_box): Remove unused local var.
9273
792c7b2b
PE
9274 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9275 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9276 Omit unused local vars.
c499e557 9277 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9278 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9279 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9280 Omit unused local var.
9281
ba0165e1
PE
9282 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9283 Don't assume string length fits in int.
32ad8845 9284 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9285 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9286
3c59b4c9
PE
9287 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9288 instead of alloca (Bug#8344).
9289
a3eed478 9290 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9291 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9292
eb4d412d
PE
9293 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9294
1658b401
PE
9295 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9296 concerns.
9297
9298 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9299
9300 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9301
9a2c6e05
PE
9302 * keyboard.c (syms_of_keyboard): Use the same style as later
9303 in this function when indexing through an array. This also
9304 works around GCC bug 48267.
9305
03d0a109
PE
9306 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9307
44f730c8
PE
9308 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9309
fe75f926
PE
9310 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9311 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9312
ffa8c828
PE
9313 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9314 This avoids undefined behavior on integer overflow, and is a bit
9315 more convenient anyway since it is compared to a size_t variable.
9316
c5101a77
PE
9317 Variadic C functions now count arguments with size_t, not int.
9318 This avoids an unnecessary limitation on 64-bit machines, which
9319 caused (substring ...) to crash on large vectors (Bug#8344).
9320 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9321 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9322 All variadic functions and their callers changed accordingly.
c5101a77
PE
9323 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9324 * data.c (arith_driver, float_arith_driver): Likewise.
9325 * editfns.c (general_insert_function): Likewise.
9326 * eval.c (struct backtrace.nargs, interactive_p)
9327 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9328 (funcall_lambda, mark_backtrace): Likewise.
9329 * fns.c (concat): Likewise.
9330 * frame.c (x_set_frame_parameters): Likewise.
9331 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9332 0 if not found, not -1. All callers changed.
9333
dd3f25f7
PE
9334 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9335 (stack_copy_size): Now size_t, not int.
9336 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9337
461c2ab9
JB
93382011-03-28 Juanma Barranquero <lekktu@gmail.com>
9339
9340 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9341 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9342 All callers changed.
9343
9344 * lisp.h (multibyte_char_to_unibyte):
9345 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9346 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9347 * character.h (CHAR_TO_BYTE8):
9348 * cmds.c (internal_self_insert):
9349 * editfns.c (general_insert_function):
9350 * keymap.c (push_key_description):
9351 * search.c (Freplace_match):
9352 * xdisp.c (message_dolog, set_message_1): All callers changed.
9353
f6d62986
SM
93542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9355
9356 * keyboard.c (safe_run_hook_funcall): New function.
9357 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9358 don't set the hook to nil, but remove the offending function instead.
9359 (Qcommand_hook_internal): Remove, unused.
9360 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9361 Vcommand_hook_internal.
9362
9363 * eval.c (enum run_hooks_condition): Remove.
9364 (funcall_nil, funcall_not): New functions.
9365 (run_hook_with_args): Call each function through a `funcall' argument.
9366 Remove `cond' argument, now redundant.
9367 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9368 (Frun_hook_with_args_until_failure): Adjust accordingly.
9369 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9370
1db5b1ad
JB
93712011-03-28 Juanma Barranquero <lekktu@gmail.com>
9372
9373 * dispextern.h (string_buffer_position): Remove declaration.
9374
9375 * print.c (strout): Remove parameter `multibyte', unused since
9376 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9377
9378 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9379 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9380 All callers changed.
9381
9382 * w32.c (_wsa_errlist): Use braces for struct initializers.
9383
9384 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9385 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9386 All callers changed.
9387 (string_buffer_position): Likewise. Also, make static (it's never
9388 used outside xdisp.c).
9389 (cursor_row_p): Remove parameter `w', unused since
9390 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9391 (decode_mode_spec): Remove parameter `precision', introduced during
9392 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9393 All callers changed.
9394
5ffb62aa
JD
93952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9396
9397 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9398
461c2ab9 93992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9400
9401 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9402 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9403 (ns_update_auto_hide_menu_bar): New functions.
9404 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9405 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9406 ns_constrain_all_frames.
9407 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9408 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9409
5c380ffb
JD
94102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9411
9412 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9413
9af30bdf
GM
94142011-03-27 Glenn Morris <rgm@gnu.org>
9415
9416 * syssignal.h: Replace RETSIGTYPE with void.
9417 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9418 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9419 Replace SIGTYPE with void everywhere.
9420 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9421 * s/template.h (SIGTYPE): Remove commented out definition.
9422
e2abce01
JB
94232011-03-26 Eli Zaretskii <eliz@gnu.org>
9424
9425 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9426 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9427
f868cd8a
JB
94282011-03-26 Juanma Barranquero <lekktu@gmail.com>
9429
59eb0929
JB
9430 * w32.c (read_unc_volume): Use parameter `henum', instead of
9431 global variable `wget_enum_handle'.
9432
9433 * keymap.c (describe_vector): Remove parameters `indices' and
9434 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9435 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9436
f868cd8a
JB
9437 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9438
9439 * keyboard.c (timer_check): Remove parameter `do_it_now',
9440 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9441 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9442 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9443
9444 * keyboard.c (read_char):
9445 * w32menu.c (w32_menu_display_help):
9446 * xmenu.c (show_help_event, menu_help_callback):
9447 Adjust calls to `show_help_echo'.
9448
9449 * gtkutil.c (xg_maybe_add_timer):
9450 * keyboard.c (readable_events):
9451 * process.c (wait_reading_process_output):
9452 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9453
9454 * insdel.c (adjust_markers_gap_motion):
9455 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9456 (gap_left, gap_right): Don't call it.
9457
2ecf6fdb
CY
94582011-03-25 Chong Yidong <cyd@stupidchicken.com>
9459
9460 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9461 incurred during fontification.
9462
6b1f9ba4
JB
94632011-03-25 Juanma Barranquero <lekktu@gmail.com>
9464
9465 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9466 (DEFVAR_PER_BUFFER): Don't pass it.
9467
9468 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9469 (scrolling_window): Don't pass it.
9470
0f4a96b5
JB
94712011-03-25 Juanma Barranquero <lekktu@gmail.com>
9472
9473 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9474
9475 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9476 and `suffix'.
9477 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9478 of variables specific to SELinux and computation of `encoded_absname'.
9479
9480 * image.c (XPutPixel): Remove unused variable `height'.
9481
9482 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9483
9484 * unexw32.c (get_section_info): Remove unused variable `section'.
9485
9486 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9487 (system_process_attributes): Remove unused variable `sess'.
9488 (sys_read): Remove unused variable `err'.
9489
9490 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9491 (w32_wnd_proc): Remove unused variable `isdead'.
9492 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9493 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9494 (x_create_tip_frame): Remove unused variable `tem'.
9495
9496 * w32inevt.c (w32_console_read_socket):
9497 Remove unused variable `no_events'.
9498
9499 * w32term.c (x_draw_composite_glyph_string_foreground):
9500 Remove unused variable `width'.
9501
1149507c
JB
95022011-03-24 Juanma Barranquero <lekktu@gmail.com>
9503
9504 * w32term.c (x_set_glyph_string_clipping):
9505 Don't pass uninitialized region to CombineRgn.
9506
9c88f339
JB
95072011-03-23 Juanma Barranquero <lekktu@gmail.com>
9508
9509 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9510 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9511 (Fx_close_connection): Remove unused variable `i'.
9512
9513 * w32font.c (w32font_draw): Return number of glyphs.
9514 (w32font_open_internal): Remove unused variable `i'.
9515 (w32font_driver): Add missing initializer.
9516
9517 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9518 (fill_in_menu): Remove unused variable `items_added'.
9519
9520 * w32term.c (last_mouse_press_frame): Remove static global variable.
9521 (w32_clip_to_row): Remove unused variable `f'.
9522 (x_delete_terminal): Remove unused variable `i'.
9523
9524 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9525 (NOTHING): Remove unused static global variable.
9526 (uniscribe_check_otf): Remove unused variable `table'.
9527 (uniscribe_font_driver): Add missing initializers.
9528
dee091a3
JD
95292011-03-23 Julien Danjou <julien@danjou.info>
9530
9531 * term.c (Fsuspend_tty, Fresume_tty):
9532 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9533 * window.c (temp_output_buffer_show):
9534 * insdel.c (signal_before_change):
9535 * frame.c (Fhandle_switch_frame):
9536 * fileio.c (Fdo_auto_save):
9537 * emacs.c (Fkill_emacs):
9538 * editfns.c (save_excursion_restore):
9539 * cmds.c (internal_self_insert):
9540 * callint.c (Fcall_interactively):
9541 * buffer.c (Fkill_all_local_variables):
9542 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9543 Use Frun_hooks.
0f4a96b5 9544 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9545 unconditionally since it does the check itself.
dee091a3 9546
2c520ab5 95472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9548
c9c49752
PE
9549 Fix more problems found by GCC 4.5.2's static checks.
9550
8abc3f12
PE
9551 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9552 the first time through the loop, since we know p0 < p1 then.
9553 This also avoids a gcc -Wstrict-overflow warning.
9554
a2d26660
PE
9555 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9556 leading to a memory leak, possible in functions like
9557 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9558 of objects (Bug#8318).
a2d26660 9559
916c72e9
PE
9560 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9561 that could (at least in theory) be that large.
9562
19ab8a18
PE
9563 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9564 This is less likely to overflow, and avoids undefined behavior if
9565 overflow does occur. All callers changed. Use strtoul to scan
9566 for the unsigned long integer.
b7cbbd6f
PE
9567 (pint2hrstr): Simplify and tune code slightly.
9568 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9569
f0641eff
PE
9570 * scroll.c (do_scrolling): Work around GCC bug 48228.
9571 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9572
7f650bb9
PE
9573 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9574 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9575 (validate_x_resource_name): Simplify count usage.
9576 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9577
37dd57d1
PE
9578 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9579 fail (Bug#8306).
81e56e61 9580
699979fc 9581 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9582
401bf9b4
PE
9583 * process.c (Fmake_network_process): Use socklen_t, not int,
9584 where POSIX says socklen_t is required in portable programs.
9585 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9586 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9587 (Fmake_network_process, server_accept_connection):
9588 (wait_reading_process_output, read_process_output):
9589 Likewise.
9590
b93aacde
PE
9591 * process.c: Rename or move locals to avoid shadowing.
9592 (list_processes_1, Fmake_network_process):
9593 (read_process_output_error_handler, exec_sentinel_error_handler):
9594 Rename or move locals.
4dc343ee 9595 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9596 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9597 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9598 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9599 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9600
af8a867c 9601 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9602 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9603 Include tparam.h instead, since it declares them.
af8a867c
PE
9604 * cm.h (PC): Remove extern decl; tparam.h now does this.
9605 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9606 * terminfo.c: Include tparam.h, to check interfaces.
9607 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9608 (tparam): Adjust signature to match interface in tparam.h;
9609 this removes some undefined behavior. Check that outstring and len
9610 are zero, which they always are with Emacs.
9611 * tparam.h (PC, BC, UP): New extern decls.
9612
0248044d 9613 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9614 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9615
8ff096c1 9616 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9617 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9618 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9619 (ftfont_list): Remove unused local.
49eaafba
PE
9620 (get_adstyle_property, ftfont_pattern_entity):
9621 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9622 Rename locals to avoid shadowing.
8ff096c1 9623
e2be39f6
PE
9624 * xfont.c (xfont_list_family): Mark var as initialized.
9625
c9735e30
PE
9626 * xml.c (make_dom): Now static.
9627
8f5201ae
PE
9628 * composite.c (composition_compute_stop_pos): Rename local to
9629 avoid shadowing.
b246f932
PE
9630 (composition_reseat_it): Remove unused locals.
9631 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9632 (composition_update_it): Mark var as initialized.
11b61122
PE
9633 (find_automatic_composition): Mark vars as initialized,
9634 with a FIXME (Bug#8290).
8f5201ae 9635
760fbc2c
PE
9636 character.h: Rename locals to avoid shadowing.
9637 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9638 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9639 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9640 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9641 to avoid shadowing.
9642
ff08eb85
PE
9643 * textprop.c (property_change_between_p): Remove; unused.
9644
fc7bf025
PE
9645 * intervals.c (interval_start_pos): Now static.
9646
235d7abc
PE
9647 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9648
44f230aa
SM
9649 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9650 Rename locals to avoid shadowing.
3e7d6594 9651
50060332
PE
9652 * sound.c (wav_play, au_play, Fplay_sound_internal):
9653 Fix pointer signedness.
d01f234b 9654 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9655 (wav_play): Initialize a variable to 0, to prevent undefined
9656 behavior (Bug#8278).
50060332 9657
c4fc4e30
PE
9658 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9659
918436ed
PE
9660 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9661
c939f91b
PE
9662 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9663 clobbering (Bug#8298).
b9c7f648
PE
9664 * sysdep.c (sys_subshell): Likewise.
9665 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9666
6bd8c144
PE
9667 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9668 This should get cleaned up, so that child_setup has the
9669 same signature on all platforms.
9670
7710357c 9671 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9672 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9673
c59da222
CY
96742011-03-22 Chong Yidong <cyd@stupidchicken.com>
9675
9676 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9677 not to be necessary, and produces flickering.
9678
66b87493
GM
96792011-03-20 Glenn Morris <rgm@gnu.org>
9680
9681 * config.in: Remove file.
9682
45b6f6d5
JB
96832011-03-20 Juanma Barranquero <lekktu@gmail.com>
9684
9685 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9686 are now in src/globals.h.
9687 (syms_of_minibuf): Remove spurious & from previous change.
9688
cd394be1 96892011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9690
9691 * minibuf.c (completing-read-function): New variable.
9692 (completing-read-default): Rename from completing-read.
9693 (completing-read): Call completing-read-function.
9694
b14e3e21
CY
96952011-03-19 Juanma Barranquero <lekktu@gmail.com>
9696
9697 * xfaces.c (Fx_load_color_file):
9698 Read color file from absolute filename (bug#8250).
9699
f2b726e6
JB
97002011-03-19 Juanma Barranquero <lekktu@gmail.com>
9701
9702 * makefile.w32-in: Update dependencies.
9703
09f6ff02
EZ
97042011-03-17 Eli Zaretskii <eliz@gnu.org>
9705
9706 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9707
29a6015a
PE
97082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9709
a3a6c54e
PE
9710 Fix more problems found by GCC 4.5.2's static checks.
9711
b766f867
PE
9712 * process.c (make_serial_process_unwind, send_process_trap):
9713 (sigchld_handler): Now static.
9714
be02381c
PE
9715 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9716 That way, the code declares only the vars that it needs.
9717 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9718 * s/cygwin.h (PTY_ITERATION): Likewise.
9719 * s/darwin.h (PTY_ITERATION): Likewise.
9720 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9721
57048744
PE
9722 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9723 * process.c (allocate_pty): Don't declare stb unless it's needed.
9724
7914961c 9725 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9726 (CONSTANTLIM): Remove; unused.
9727 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9728 Define only if needed.
7914961c 9729
b3967b18
PE
9730 * unexelf.c (unexec): Name an expression,
9731 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9732 Use a different way to cause a compilation error if anyone uses
9733 n rather than nn, a way that does not involve shadowing.
73366a00 9734 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9735
29a6015a
PE
9736 * deps.mk (unexalpha.o): Remove; unused.
9737
43cfc33e 9738 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9739 * unexec.h: New file.
ce701a33
PE
9740 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9741 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9742 Depend on unexec.h.
9743 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9744 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9745 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9746 Change as necessary to match prototype in unexec.h.
ce701a33 9747
01f44d5a
PE
9748 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9749 shadowing.
4f63c6bb 9750 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9751
a6670b0b
PE
9752 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9753 Rename locals to avoid shadowing.
9754
cef2010d 9755 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9756 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9757
d4d7173a
PE
9758 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9759
f08b802a
PE
9760 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9761 warning when compiling print.c.
9762
3ddb0639
PE
9763 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9764 instead of using an uninitialized var.
5ad03b97 9765 (font_sort_entities): Mark var as initialized.
3ddb0639 9766
170a2692
PE
9767 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9768
e663c700
PE
9769 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9770 pointers to constants.
89bc529a 9771 (font_parse_fcname): Remove unused vars.
7b81e2d0 9772 (font_delete_unmatched): Now static.
ea838e10 9773 (font_get_spec): Remove; unused.
13a547c6
PE
9774 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9775 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9776 Rename or move locals to avoid shadowing.
e663c700 9777
2a80c887 9778 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9779 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9780
1384fa33 9781 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9782 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9783
8b2c52e9
PE
9784 * alloc.c (mark_backtrace): Move decl from here ...
9785 * lisp.h: ... to here, so that it can be checked.
9786
475545b5 9787 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9788 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9789 (lisp_indirect_variable): Name an expression,
9790 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9791 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9792
b1349114 9793 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9794 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9795 Use const pointer when appropriate.
b1349114 9796
a2928364
PE
9797 * lisp.h (get_system_name, get_operating_system_release):
9798 Move decls here, to check interfaces.
9799 * process.c (get_operating_system_release): Move decl to lisp.h.
9800 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9801 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9802 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9803 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9804 (Fformat_time_string, Fencode_time, Finsert_char):
9805 (Ftranslate_region_internal, Fformat):
9806 Rename or remove local vars to avoid shadowing.
9710023e 9807 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9808
a415e694
PE
9809 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9810 avoid shadowing.
9811
8ef4622d
PE
9812 * lisp.h (eassert): Check that the argument compiles, even if
9813 ENABLE_CHECKING is not defined.
9814
946f9a5b
PE
9815 * data.c (Findirect_variable): Name an expression, to avoid
9816 gcc -Wbad-function-cast warning.
112396d6 9817 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9818 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9819 (Fmake_variable_buffer_local, Fmake_local_variable):
9820 Mark variables as initialized.
52746918 9821 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9822
e5aab7e7 9823 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9824 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9825 Rename locals to avoid shadowing.
dff45157
PE
9826 (mark_stack): Move local variables into the #ifdef region where
9827 they're used.
7bc26fdb
PE
9828 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9829 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9830 needed otherwise.
9831 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9832 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9833 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9834
e5aab7e7
PE
9835 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9836 avoids undefined behavior in theory.
9837
4da60324
PE
9838 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9839
88043301
PE
9840 Use functions, not macros, for up- and down-casing (Bug#8254).
9841 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9842 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9843 to use the following functions instead of these macros.
9844 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9845 EMACS_INT, since callers assume the returned value fits in int.
9846 (upcase1): Likewise, for UPCASE_TABLE.
9847 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9848 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9849 the race-condition problem in the old DOWNCASE.
88043301 9850
19ed5445
PE
9851 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9852 Rename locals to avoid shadowing.
9853 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9854 (regex_compile, re_search_2, re_match_2_internal):
9855 Remove unused local vars.
952db0d7
PE
9856 (FREE_VAR): Rewrite so as not to use empty "else",
9857 which gcc can warn about.
da053e48 9858 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9859 (RETALLOC_IF): Define only if needed.
9860 (WORDCHAR_P): Likewise. This one is never needed, but is used
9861 only in a comment talking about a compiler bug, so put inside
9862 the #if 0 of that comment.
9863 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9864 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9865 Remove; unused.
19ed5445 9866
1f3561e4 9867 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9868 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9869 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9870
ded6f8f7
PE
9871 * search.c (simple_search): Remove unused var.
9872
dbd37a95
PE
9873 * dired.c (compile_pattern): Move decl from here ...
9874 * lisp.h: ... to here, so that it can be checked.
9875 (struct re_registers): New forward decl.
9876
7e47afad
PE
9877 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9878
85f24f61
PE
9879 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9880 All uses changed.
9881 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9882 Rename locals to avoid shadowing.
5671df8f 9883 (Fvertical_motion): Mark locals as initialized.
85f24f61 9884
181aa2be 9885 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9886 (casify_region): Mark local as initialized.
181aa2be 9887
930d429c
PE
9888 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9889
7082eac6
PE
9890 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9891 New macros, so that the caller can use some names other than
9892 gcpro1, gcpro2, etc.
9893 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9894 of the new macros.
9895 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9896 argument, for consistency with GCPRO2_VAR, etc: it is now the
9897 prefix of the variable, not the variable itself. All uses
9898 changed.
38b2c076
PE
9899 * dired.c (directory_files_internal, file_name_completion):
9900 Rename locals to avoid shadowing.
9901
15206ed9
PE
9902 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9903 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9904 dired.c's scmp function, had undefined behavior.
9905 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9906 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9907 * buffer.h: ... to here, because these macros use current_buffer,
9908 and the new implementation with inline functions needs to have
9909 current_buffer in scope now, rather than later when the macros
9910 are used.
9911 (downcase, upcase1): New static inline functions.
9912 (DOWNCASE, UPCASE1): Reimplement using these functions.
9913 This avoids undefined behavior in expressions like
9914 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9915 from race conditions in accessing the global variables
9916 case_temp1 and case_temp2.
9917 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9918 * lisp.h (case_temp1, case_temp2): Remove their decls.
9919 * character.h (ASCII_CHAR_P): Move from here ...
9920 * lisp.h: ... to here, so that the inline functions mentioned
9921 above can use them.
9922
4a6bea26
PE
9923 * dired.c (directory_files_internal_unwind): Now static.
9924
f14b7e14
PE
9925 * fileio.c (file_name_as_directory, directory_file_name):
9926 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9927 Now static.
2893f146
PE
9928 (file_name_as_directory): Use const pointers when appropriate.
9929 (Fexpand_file_name): Likewise. In particular, newdir might
9930 point at constant storage, so make it a const pointer.
fd4ead52 9931 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9932 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9933 signedness issues.
f839df0c
PE
9934 (Fset_file_times, Finsert_file_contents, auto_save_error):
9935 Rename locals to avoid shadowing.
f14b7e14 9936
5716756e 9937 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9938 (Ftry_completion, Fall_completions): Rename or remove locals
9939 to avoid shadowing.
5716756e 9940
b4c3046a
PE
9941 * marker.c (bytepos_to_charpos): Remove; unused.
9942
b45db522
PE
9943 * lisp.h (verify_bytepos, count_markers): New decls,
9944 so that gcc does not warn that these functions aren't declared.
9945
85876d07
PE
9946 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9947 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9948 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9949 (copy_text): Remove unused local var.
85876d07 9950
03d78a21 9951 * filelock.c (within_one_second): Now static.
b3dd38ab 9952 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9953
5df8f01b
PE
9954 * buffer.c (fix_overlays_before): Mark locals as initialized.
9955 (fix_start_end_in_overlays): Likewise. This function should be
9956 simplified by using pointers-to-pointers, but that's a different
9957 matter.
b1d876f1 9958 (switch_to_buffer_1): Now static.
8f54f30a
PE
9959 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9960 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9961
a70072c9 9962 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9963 Fix pointer signedness issue.
edced198
PE
9964 (sys_subshell): Mark local as volatile if checking for lint,
9965 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9966 (MAXPATHLEN): Define only if needed.
a70072c9 9967
a0977c44
PE
9968 * process.c (serial_open, serial_configure): Move decls from here ...
9969 * systty.h: ... to here, so that they can be checked.
9970
a884fdcc
PE
9971 * fns.c (get_random, seed_random): Move extern decls from here ...
9972 * lisp.h: ... to here, so that they can be checked.
9973
604efe86 9974 * sysdep.c (reset_io): Now static.
b8950c94 9975 (wait_for_termination_signal): Remove; unused.
604efe86 9976
38fc62d9
PE
9977 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9978 (copy_keymap_item, append_key, push_text_char_description):
9979 Now static.
1004a21a 9980 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9981 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9982 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9983 (describe_map_tree):
9984 Rename locals to avoid shadowing.
38fc62d9 9985
2f2650da
PE
9986 * keyboard.c: Declare functions static if they are not used elsewhere.
9987 (echo_char, echo_dash, cmd_error, top_level_2):
9988 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9989 (read_char, kbd_buffer_get_event, make_lispy_position):
9990 (make_lispy_event, make_lispy_movement, apply_modifiers):
9991 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9992 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9993 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9994 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9995 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9996
a053e86c 9997 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9998 (mark_kboards): Move decl here ...
9999 * alloc.c (mark_kboards): ... from here.
a053e86c 10000
4752793e
PE
10001 * lisp.h (force_auto_save_soon): New decl.
10002
74f10ca7 10003 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
10004 (DEFINE_DUMMY_FUNCTION): New macro.
10005 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10006 Use it.
c03cd23f
PE
10007 (main): Add casts to avoid warnings
10008 if GCC considers string literals to be constants.
74f10ca7 10009
022e70d4
PE
10010 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10011
59d6fe83
PE
10012 * dbusbind.c: Pointer signedness fixes.
10013 (xd_signature, xd_append_arg, xd_initialize):
10014 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10015 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10016 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10017 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10018
78320123
PE
10019 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10020 if GCC considers string literals to be constants.
49cebcca 10021 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10022
35ac2a97
SM
100232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10024
fb103ca9
SM
10025 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10026 (print_preprocess, print_object): New macro to fix last change.
10027
35ac2a97
SM
10028 * print.c (print_preprocess): Don't forget font objects.
10029
62973b41
JB
100302011-03-16 Juanma Barranquero <lekktu@gmail.com>
10031
10032 * emacs.c (USAGE3): Doc fixes.
10033
0e48bb22
AS
100342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10035
10036 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10037 structure.
10038
7684e57b
JB
100392011-03-14 Juanma Barranquero <lekktu@gmail.com>
10040
10041 * lisp.h (VWindow_system, Qfile_name_history):
10042 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10043 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10044 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10045
10046 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10047 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10048
10049 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10050 * w32console.c (detect_input_pending, read_input_pending)
10051 (encode_terminal_code):
10052 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10053 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10054 (w32_system_caret_y, Qfile_name_history):
10055 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10056 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10057 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10058 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10059 * w32proc.c (Qlocal, report_file_error):
10060 * w32term.c (Vwindow_system, updating_frame):
10061 * w32uniscribe.c (initialized, uniscribe_font_driver):
10062 Remove unneeded extern declarations.
10063
2aa46d6c
CY
100642011-03-14 Chong Yidong <cyd@stupidchicken.com>
10065
c96bbc66 10066 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10067
cffc6f3b
CY
100682011-03-13 Chong Yidong <cyd@stupidchicken.com>
10069
10070 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10071 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10072 These macros can no longer be used for assignment.
10073
44f230aa
SM
10074 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10075 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10076 (record_buffer_markers, fetch_buffer_markers): New functions for
10077 recording and fetching special buffer markers.
10078 (set_buffer_internal_1, set_buffer_temp): Use them.
10079
10080 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10081
10082 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10083
10084 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10085 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10086
10087 * xdisp.c (hscroll_window_tree):
10088 (reconsider_clip_changes): Use PT instead of BUF_PT.
10089
d251f04b
EZ
100902011-03-13 Eli Zaretskii <eliz@gnu.org>
10091
10092 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10093 $(EMACS_ROOT)/lib/intprops.h.
10094
f0c77cd1
PE
100952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10096
3eca4629
PE
10097 Fix more problems found by GCC 4.5.2's static checks.
10098
7c86ee98
PE
10099 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10100 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10101 (xg_free_frame_widgets): Make it clear that a local variable is
10102 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10103 (gdk_window_get_screen): Make it clear that this macro is needed
10104 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10105 (int_gtk_range_get_value): New function, which avoids a diagnostic
10106 from gcc -Wbad-function-cast.
10107 (xg_set_toolkit_scroll_bar_thumb): Use it.
10108 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10109 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10110 (get_utf8_string, xg_get_file_with_chooser):
10111 Rename locals to avoid shadowing.
10112 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10113
41729b81
PE
10114 * xgselect.c (xg_select): Remove unused var.
10115
f0c77cd1
PE
10116 * image.c (four_corners_best): Mark locals as initialized.
10117 (gif_load): Initialize transparent_p to zero (Bug#8238).
10118 Mark another local as initialized.
ec6cf4c6 10119 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10120
ce0ad53d 10121 * image.c (clear_image_cache): Now static.
d5d5a617 10122 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10123 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10124 (x_edge_detection): Remove unnecessary cast that
10125 gcc -Wbad-function-cast diagnoses.
2037898d 10126 (gif_load): Fix pointer signedness.
6ae141d6
PE
10127 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10128 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10129
33383987 101302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10131
d32df629
PE
10132 Improve quality of tests for time stamp overflow.
10133 For example, without this patch (encode-time 0 0 0 1 1
10134 1152921504606846976) returns the obviously-bogus value (-948597
10135 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10136 reports time overflow. See
10137 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10138 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10139 * editfns.c: Include limits.h and intprops.h.
10140 (TIME_T_MIN, TIME_T_MAX): New macros.
10141 (time_overflow): Move earlier, to before first use.
10142 (hi_time, lo_time): New functions, for an accurate test for
10143 out-of-range times.
10144 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10145 (Fget_internal_run_time): Don't assume time_t fits in int.
10146 (make_time): Use list2 instead of Fcons twice.
10147 (Fdecode_time): More accurate test for out-of-range times.
10148 (check_tm_member): New function.
10149 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10150 (lisp_time_argument): Don't rely on undefined left-shift and
10151 right-shift behavior when checking for time stamp overflow.
8be6f318 10152
fe31d94c
PE
10153 * editfns.c (time_overflow): New function, refactoring common code.
10154 (Fformat_time_string, Fdecode_time, Fencode_time):
10155 (Fcurrent_time_string): Use it.
10156
8be6f318
PE
10157 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10158 * dired.c (make_time): Move to ...
10159 * editfns.c (make_time): ... here.
10160 * systime.h: Note the move.
10161
09d9db2c 101622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10163
126bc0dc
YM
10164 * fringe.c (update_window_fringes): Remove unused variables.
10165
c47cbdfd
YM
10166 * unexmacosx.c (copy_data_segment): Also copy __got section.
10167 (Bug#8223)
10168
7ac80be9
EZ
101692011-03-12 Eli Zaretskii <eliz@gnu.org>
10170
c96bbc66 10171 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10172 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10173 Constify `char *' arguments and their references according to
10174 prototypes in tparam.h.
10175
ecb0f94d 10176 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10177
7ac80be9
EZ
10178 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10179 Adapt all references accordingly.
10180
10181 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10182
ef1fd07e
TT
101832011-03-11 Tom Tromey <tromey@redhat.com>
10184
10185 * buffer.c (syms_of_buffer): Remove obsolete comment.
10186
7ef4b50c
EZ
101872011-03-11 Eli Zaretskii <eliz@gnu.org>
10188
10189 * termhooks.h (encode_terminal_code): Declare prototype.
10190
10191 * msdos.c (encode_terminal_code): Don't declare prototype.
10192
10193 * term.c (encode_terminal_code): Now external again, used by
10194 w32console.c and msdos.c.
10195
44f230aa
SM
10196 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10197 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10198
4b1ec863 101992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10200
1714f52b 10201 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10202
4b1ec863
PE
10203 * fringe.c (update_window_fringes): Mark locals as initialized
10204 (Bug#8227).
10205 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10206
524c7aa6
PE
10207 * alloc.c (mark_fringe_data): Move decl from here ...
10208 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10209 to check its interface.
10210 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10211
a5c0af81 10212 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10213 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10214 (fontset_font): Mark local as initialized.
a9a06e0b 10215 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10216
b4716021
PE
10217 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10218
811e9bac 10219 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10220 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10221 (x_own_selection, Fx_disown_selection_internal): Rename locals
10222 to avoid shadowing.
10223 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10224
7e3ab302
PE
10225 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10226 so that the caller can use some name other than gcpro1.
10227 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10228 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10229 (Fx_backspace_delete_keys_p):
10230 Use them to avoid shadowing, and rename vars to avoid shadowing.
10231 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10232 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10233 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10234 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10235 Remove unused locals.
7e3ab302
PE
10236 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10237 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10238 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10239 macros.
f78faa98 10240
e2b13473
PE
10241 * xterm.h (x_mouse_leave): New decl.
10242
77f23912
PE
10243 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10244 Remove unused functions.
cdf4ba58
PE
10245 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10246 (x_calc_absolute_position): Now static.
7411c686 10247 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10248 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10249 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10250 unless they are used.
38d0b34a
PE
10251 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10252 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10253 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10254 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10255 (x_error_catcher, x_connection_closed, x_error_handler):
10256 (x_error_quitter, xembed_send_message, x_iconify_frame):
10257 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10258 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10259 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10260
44f230aa
SM
10261 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10262 Rename or move locals to avoid shadowing.
6b463e58 10263 (tty_defined_color, merge_face_heights): Now static.
5967d051 10264 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10265 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10266 does not deduce is never used uninitialized.
73719eba
PE
10267 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10268 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10269
426994c3 10270 * terminal.c (store_terminal_param): Now static.
5489860b 10271
032f1620 10272 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10273 (set_frame_menubar): Remove unused local.
d4323972 10274 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10275 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10276 since they might point to immutable storage.
281585b0
PE
10277 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10278 since it's unused otherwise.
032f1620 10279
367c19e5 10280 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10281 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10282 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10283 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10284 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10285 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10286 does not deduce are never used uninitialized.
70739cbe 10287
07b48fa9
PE
10288 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10289
8868a238 10290 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10291 * window.c (window_loop, size_window):
10292 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10293
7e5cf297 10294 * window.c (display_buffer): Now static.
d6550a9f
PE
10295 (size_window): Mark variables that gcc -Wuninitialized
10296 does not deduce are never used uninitialized.
a586633d
PE
10297 * window.h (check_all_windows): New decl, to forestall
10298 gcc -Wmissing-prototypes diagnostic.
5b555da1 10299 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10300
f6095868
PE
10301 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10302 shadowing.
10303 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10304 Include <limits.h>.
10305 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10306 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10307 (load_charset_map): Mark variables that gcc -Wuninitialized
10308 does not deduce are never used uninitialized.
53df7c11 10309 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10310
f38b440c
PE
10311 * coding.c (coding_set_source, coding_set_destination):
10312 Use "else { /* comment */ }" rather than "else /* comment */;"
10313 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10314 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10315 a block, when the outer 'i' will do.
10316 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10317 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10318 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10319 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10320 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10321 Rename locals to avoid shadowing.
10322 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10323 * coding.c (emacs_mule_char, encode_invocation_designation):
10324 Now static, since they're not used elsewhere.
413bb2db 10325 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10326 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10327 (decode_coding_emacs_mule): Mark variables that gcc
10328 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10329 (detect_coding_iso_2022): Initialize a local variable that might
10330 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10331 this initialization is needed. (Bug#8211)
5f58e762
PE
10332 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10333 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10334 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10335 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10336 Remove unused macros.
f38b440c 10337
232b38b9 10338 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10339 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10340 * character.c (string_count_byte8): Likewise.
232b38b9 10341
fb90da1b
PE
10342 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10343 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10344
fb93dbc2
PE
10345 * chartab.c (copy_sub_char_table): Now static, since it's not used
10346 elsewhere.
5c156ace
PE
10347 (sub_char_table_ref_and_range, char_table_ref_and_range):
10348 Rename locals to avoid shadowing.
bbcd0949 10349 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10350
7d3b3862 10351 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10352 (BIDI_BOB): Remove unused macro.
7d3b3862 10353
6be7d3da
PE
10354 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10355 deduce are never used uninitialized.
c2ed9c8b 10356 * term.c (encode_terminal_code): Likewise.
6be7d3da 10357
75f8807f 10358 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10359
50938595
PE
10360 * tparam.h: New file.
10361 * term.c, tparam.h: Include it.
10362 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10363 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10364 Move these decls to tparam.h, and make them agree with what
10365 is actually in tparam.c. The previous trick of using incompatible
10366 decls in different modules does not conform to the C standard.
10367 All callers of tparam changed to use tparam's actual API.
10368 * tparam.c (tparam1, tparam, tgoto):
10369 Use const pointers where appropriate.
10370
fbceeba2
PE
10371 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10372 * cm.h (struct cm): Likewise.
10373 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10374 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10375 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10376 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10377 (turn_on_face, init_tty): Likewise.
10378 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10379
7f3f1250
PE
10380 * term.c (term_mouse_position): Rename local to avoid shadowing.
10381
e6ca6543
PE
10382 * alloc.c (mark_ttys): Move decl from here ...
10383 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10384
c40f8d15
AS
103852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10386
10387 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10388
cfe0661d
JB
103892011-03-09 Juanma Barranquero <lekktu@gmail.com>
10390
10391 * search.c (compile_pattern_1): Remove argument regp, unused since
10392 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10393 (compile_pattern): Don't pass it.
10394
0afb4571
J
103952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10396
10397 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10398 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10399 for ! HAVE_GTK3.
10400 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10401
10402 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10403
10404 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10405 gdk_window_get_screen, gdk_window_get_geometry,
10406 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10407 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10408 (xg_get_pixbuf_from_pixmap): New function.
10409 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10410 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10411 Call xg_get_pixbuf_from_pixmap instead of
10412 gdk_pixbuf_get_from_drawable.
10413 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10414 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10415 (xg_check_special_colors): Use GtkStyleContext and its functions
10416 for HAVE_GTK3.
10417 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10418 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10419 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10420 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10421 Call gtk_widget_get_preferred_size.
0afb4571
J
10422 (xg_frame_resized): gdk_window_get_geometry only takes 5
10423 parameters.
44f230aa
SM
10424 (xg_win_to_widget, xg_event_is_for_menubar):
10425 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10426 (xg_set_widget_bg): New function.
10427 (delete_cb): New function.
895009e1 10428 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10429 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10430 (xg_set_background_color): Call xg_set_widget_bg.
10431 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10432 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10433 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10434 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10435 if ! HAVE_GTK3.
10436 (update_frame_tool_bar): Call gtk_widget_hide.
10437 (xg_initialize): Use GDK_KEY_g.
10438
10439 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10440 if ! HAVE_GTK3
10441 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10442
10443 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10444 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10445 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10446
1c2cc4ef
JB
104472011-03-08 Juanma Barranquero <lekktu@gmail.com>
10448
10449 * w32xfns.c (select_palette): Check success of RealizePalette against
10450 GDI_ERROR, not zero.
10451
33383987 10452See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10453
10454;; Local Variables:
10455;; coding: utf-8
aac0c6e3
MR
10456;; End:
10457
2f097256 10458 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10459
10460 This file is part of GNU Emacs.
10461
10462 GNU Emacs is free software: you can redistribute it and/or modify
10463 it under the terms of the GNU General Public License as published by
10464 the Free Software Foundation, either version 3 of the License, or
10465 (at your option) any later version.
10466
10467 GNU Emacs is distributed in the hope that it will be useful,
10468 but WITHOUT ANY WARRANTY; without even the implied warranty of
10469 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10470 GNU General Public License for more details.
10471
10472 You should have received a copy of the GNU General Public License
10473 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.