Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e43b6e43
MR
12011-06-27 Martin Rudalics <rudalics@gmx.at>
2
3 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4 (sort_overlays, overlay_strings): When an overlay's clone number
5 matches the window's clone number process the overlay even if
6 the overlay's window property doesn't match the current window.
7
c7e73be5
JD
82011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9
10 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11 (emacs_fixed_set_min_size): Remove.
12 (emacs_fixed_new): Take frame as argument.
13
14 * emacsgtkfixed.c: State that this is only used with Gtk+3.
15 (_EmacsFixedPrivate): Remove minwidth/height.
16 Add struct frame *f.
17 (emacs_fixed_init): Initialize priv->f.
18 (get_parent_class, emacs_fixed_set_min_size): Remove.
19 (emacs_fixed_new): Set priv->f to argument.
20 (emacs_fixed_get_preferred_width)
21 (emacs_fixed_get_preferred_height): Use min_width/height from
22 frames size_hint to set minimum and natural (Bug#8919).
23 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
24 and use min_width/height from frames size_hint to set
25 min_width/height (Bug#8919).
26
27 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
28 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
29 indentation.
30
cf99dcf8
EZ
312011-06-26 Eli Zaretskii <eliz@gnu.org>
32
33 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
34 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
35 called at ZV.
36
029529ac
CY
372011-06-26 Chong Yidong <cyd@stupidchicken.com>
38
39 * process.c (wait_reading_process_output): Bypass select if
40 waiting for a cell while ignoring keyboard input, and input is
41 pending. Suggested by Jan Djärv (Bug#8869).
42
7a7ef429
PE
432011-06-25 Paul Eggert <eggert@cs.ucla.edu>
44
45 Use gnulib's dup2 module instead of rolling our own.
46 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
47
11fdef7d 482011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
49
50 * dispnew.c (scrolling_window): Before scrolling, turn off a
51 mouse-highlight in the window being scrolled.
52
cd3520a4
JB
532011-06-24 Juanma Barranquero <lekktu@gmail.com>
54
55 Move DEFSYM to lisp.h and use everywhere.
56
57 * character.h (DEFSYM): Move declaration...
58 * lisp.h (DEFSYM): ...here.
59
60 * gnutls.c:
61 * minibuf.c:
62 * w32menu.c:
63 * w32proc.c:
64 * w32select.c: Don't include character.h.
65
66 * alloc.c (syms_of_alloc):
67 * buffer.c (syms_of_buffer):
68 * bytecode.c (syms_of_bytecode):
69 * callint.c (syms_of_callint):
70 * casefiddle.c (syms_of_casefiddle):
71 * casetab.c (init_casetab_once):
72 * category.c (init_category_once, syms_of_category):
73 * ccl.c (syms_of_ccl):
74 * cmds.c (syms_of_cmds):
75 * composite.c (syms_of_composite):
76 * dbusbind.c (syms_of_dbusbind):
77 * dired.c (syms_of_dired):
78 * dispnew.c (syms_of_display):
79 * doc.c (syms_of_doc):
80 * editfns.c (syms_of_editfns):
81 * emacs.c (syms_of_emacs):
82 * eval.c (syms_of_eval):
83 * fileio.c (syms_of_fileio):
84 * fns.c (syms_of_fns):
85 * frame.c (syms_of_frame):
86 * fringe.c (syms_of_fringe):
87 * insdel.c (syms_of_insdel):
88 * keymap.c (syms_of_keymap):
89 * lread.c (init_obarray, syms_of_lread):
90 * macros.c (syms_of_macros):
91 * msdos.c (syms_of_msdos):
92 * print.c (syms_of_print):
93 * process.c (syms_of_process):
94 * search.c (syms_of_search):
95 * sound.c (syms_of_sound):
96 * syntax.c (init_syntax_once, syms_of_syntax):
97 * terminal.c (syms_of_terminal):
98 * textprop.c (syms_of_textprop):
99 * undo.c (syms_of_undo):
100 * w32.c (globals_of_w32):
101 * window.c (syms_of_window):
102 * xdisp.c (syms_of_xdisp):
103 * xfaces.c (syms_of_xfaces):
104 * xfns.c (syms_of_xfns):
105 * xmenu.c (syms_of_xmenu):
106 * xsettings.c (syms_of_xsettings):
107 * xterm.c (syms_of_xterm): Use DEFSYM.
108
4228cf16
TZ
1092011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
110
cd3520a4 111 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 112
7fcccf1e
PE
1132011-06-23 Paul Eggert <eggert@cs.ucla.edu>
114
7efb4e0e
PE
115 Integer and buffer overflow fixes (Bug#8873).
116
ff5844ad
PE
117 * print.c (printchar, strout): Check for string overflow.
118 (PRINTPREPARE, printchar, strout):
119 Don't set size unless allocation succeeds.
120
90532f02
PE
121 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
122 for sizes. Check for string overflow more accurately.
123 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
124
6d84508d
PE
125 * macros.c: Integer and buffer overflow fixes.
126 * keyboard.h (struct keyboard.kbd_macro_bufsize):
127 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
128 Use ptrdiff_t, not int, for sizes.
129 Don't increment bufsize until after realloc succeeds.
130 Check for size-calculation overflow.
131 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
132
437b2cb4
PE
133 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
134
8b9ac8b4
PE
135 * lread.c: Integer overflow fixes.
136 (read_integer): Radix is now EMACS_INT, not int,
137 to improve quality of diagnostics for out-of-range radices.
138 Calculate buffer size correctly for out-of-range radices.
139 (read1): Check for integer overflow in radices, and in
140 read-circle numbers.
82cb60d3
PE
141 (read_escape): Avoid int overflow.
142 (Fload, openp, read_buffer_size, read1)
143 (substitute_object_recurse, read_vector, read_list, map_obarray):
144 Use ptrdiff_t, not int, for sizes.
145 (read1): Use EMACS_INT, not int, for sizes.
20270765 146 Check for size overflow.
8b9ac8b4 147
7fcccf1e
PE
148 * image.c (cache_image): Check for size arithmetic overflow.
149
bfbbd7e7
PE
150 * lread.c: Integer overflow issues.
151 (saved_doc_string_size, saved_doc_string_length)
152 (prev_saved_doc_string_size, prev_saved_doc_string_length):
153 Now ptrdiff_t, not int.
154 (read1): Don't assume doc string length fits in int. Check for
155 out-of-range doc string lengths.
156 (read_list): Don't assume file position fits in int.
39019e54 157 (read_escape): Check for hex character overflow.
bfbbd7e7 158
4e323265
LL
1592011-06-22 Leo Liu <sdl.web@gmail.com>
160
161 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
162 Move to minibuffer.el.
163
85fece3e
PE
1642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
165
20b84ce9 166 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
167 The following patches are for when GLYPH_DEBUG && !XASSERT.
168 * dispextern.h (trace_redisplay_p, dump_glyph_string):
169 * dispnew.c (flush_stdout):
170 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
171 Mark as externally visible.
172 * dispnew.c (check_window_matrix_pointers): Now static.
173 * dispnew.c (window_to_frame_vpos):
174 * xfns.c (unwind_create_frame):
175 * xterm.c (x_check_font): Remove unused local.
176 * scroll.c (CHECK_BOUNDS):
177 * xfaces.c (cache_fache): Rename local to avoid shadowing.
178 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
179 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
180 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
181 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
182 Now static.
183 (debug_method_add): Use va_list and vsprintf rather than relying
184 on undefined behavior with wrong number of arguments.
185 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
186 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
187 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
188 since we're not interested in debugging glyphs with old libraries.
189 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
190 GCC 4.6.0's static checking.
191
0766b489
PE
1922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
193
31fd4b32
PE
194 Integer overflow and signedness fixes (Bug#8873).
195 A few related buffer overrun fixes, too.
196
b79e8648
PE
197 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
198
0766b489
PE
199 * dispextern.h (struct face.stipple):
200 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
201 (x_bitmap_mask, x_allocate_bitmap_record)
202 (x_create_bitmap_from_data, x_create_bitmap_from_file)
203 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
204 (x_create_bitmap_from_xpm_data):
205 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
206 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
207 (.bitmaps_last):
208 * xfaces.c (load_pixmap):
209 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
210 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
211 (.bitmaps_last, struct x_output.icon_bitmap):
212 Use ptrdiff_t, not int, for bitmap indexes.
213 (x_allocate_bitmap_record): Check for size overflow.
214 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
215
b081724f
PE
216 Use ptrdiff_t, not int, for overlay counts.
217 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
218 * editfns.c (overlays_around, get_pos_property):
219 * textprop.c (get_char_property_and_overlay):
220 * xdisp.c (next_overlay_change, note_mouse_highlight):
221 * xfaces.c (face_at_buffer_position):
21514da7
PE
222 * buffer.c (OVERLAY_COUNT_MAX): New macro.
223 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
224 (Fnext_overlay_change, Fprevious_overlay_change)
225 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 226 Use ptrdiff_t, not int, for sizes.
21514da7 227 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 228
3de73e5e
PE
229 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
230
2606c57b
PE
231 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
232 (x_session_initialize): Do not assume string length fits in int.
233
aaafe47a
PE
234 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
235 This is unlikely, but can occur if DPI is outlandish.
236
2674ddc8 237 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
238 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
239
28154962
PE
240 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
241 * xrdb.c (magic_file_p, search_magic_path):
242 Omit last arg SUFFIX; it was always 0. All callers changed.
243 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
244
7de51af5
PE
245 * xfont.c (xfont_match): Avoid need for strlen.
246
25ed6cc3
PE
247 * xfns.c: Don't assume strlen fits in int.
248 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
249
4eab31dd
PE
250 * xdisp.c (message_log_check_duplicate): Return intmax_t,
251 not unsigned long, as we prefer signed integers. All callers changed.
252 Detect integer overflow in repeat count.
253 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 254 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 255
171e2a58
PE
256 * termcap.c: Don't assume sizes fit in int and never overflow.
257 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
258 (gobble_line): Check for size-calculation overflow.
259
ad39faca 260 * minibuf.c (Fread_buffer):
6e5bb2dc 261 * lread.c (intern, intern_c_string):
74ca2eb3
PE
262 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
263 Don't assume string length fits in int.
264
52c61c22 265 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
266 * gtkutil.c (style_changed_cb): Avoid need for strlen.
267
b5b8c9e5
PE
268 * font.c: Don't assume string length fits in int.
269 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
270 Use ptrdiff_t, not int.
ccd6111c
PE
271 (font_intern_prop): Don't assume string length fits in int.
272 Don't assume integer property fits in fixnum.
273 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 274
882f0d81 275 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 276 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
277 Reformulate so as not to need the command string.
278 Invoke gzip -cd rather than gunzip, as it's more portable.
279 (lock_info_type, lock_file_1, lock_file):
280 Don't assume pid_t and time_t fit in unsigned long.
281 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
282 (current_lock_owner): Prefer signed type for sizes.
283 Use memcpy, not strncpy, where memcpy is what is really wanted.
284 Don't assume (via atoi) that time_t and pid_t fit in int.
285 Check for time_t and/or pid_t out of range, e.g., via a network share.
286 Don't alloca where an auto var works fine.
287
93f4cf88
PE
288 * fileio.c: Fix some integer overflow issues.
289 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
290 Don't assume string length fits in int.
291 (directory_file_name): Don't assume string length fits in long.
292 (make_temp_name): Don't assume pid fits in int, or that its print
293 length is less than 20.
294
f3e92b69
PE
295 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
296
1bfdaf10
PE
297 * coding.c (make_subsidiaries): Don't assume string length fits in int.
298
35016e9a
PE
299 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
300
3d1e65a1
PE
301 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
302 We prefer signed integers, even for size calculations.
303
0b963a93
PE
304 * emacs.c: Don't assume string length fits in 'int'.
305 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
306 (main): Don't invoke strlen when not needed.
307
573f4b54
PE
308 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
309 (XD_DEBUG_MESSAGE): Don't waste a byte.
310
989f33ba
PE
311 * callproc.c (getenv_internal_1, getenv_internal)
312 (Fgetenv_internal):
965d34eb
PE
313 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
314
e4d29b33
PE
315 * lread.c (invalid_syntax): Omit length argument.
316 All uses changed. This doesn't fix a bug, but it simplifies the
317 code away from its former Hollerith-constant appearance, and it's
318 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 319 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 320
eb49b136
PE
321 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
322 This didn't break anything, but it didn't help either.
323 It's confusing to put a bogus integer in a place where the actual
324 value does not matter.
9f62aeb1 325 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 326 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 327
15375a22
PE
328 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
329 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
330 implementation.
b61cc01c
PE
331 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
332 We prefer signed types, and the value cannot exceed the EMACS_INT
333 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
334 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
335 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
336 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 337
53b2623d
PE
338 * indent.c (sane_tab_width): New function.
339 (current_column, scan_for_column, Findent_to, position_indentation)
340 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 341 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 342
51cab52b 343 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 344
f2ed8a70
PE
345 * lisp.h (lint_assume): New macro.
346 * composite.c (composition_gstring_put_cache):
347 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
348
abe80cc6
PE
349 * editfns.c, insdel.c:
350 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 351
b02c740e
PE
352 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
353
ebc96716
PE
354 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
355
b4e50fa0 356 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 357 Use much-faster test for byte-length change.
311d5d7c 358 Don't assume string byte-length fits in 'int'.
a4cf38e4 359 Check that character arg fits in 'int'.
85461888 360 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 361
c0c1ee9f
PE
362 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
363
a498d7f4
PE
364 * fns.c (concat): Catch string overflow earlier.
365 Do not rely on integer wraparound.
366
51cab52b
PE
367 * dispextern.h (struct it.overlay_strings_charpos)
368 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
369 * xdisp.c (forward_to_next_line_start)
370 (back_to_previous_visible_line_start)
371 (reseat_at_next_visible_line_start, next_element_from_buffer):
372 Don't arbitrarily truncate the value of 'selective' to int.
373
76031fad
PE
374 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
375
5eb55db9
PE
376 * composite.c: Don't truncate sizes to 'int'.
377 (composition_gstring_p, composition_reseat_it)
378 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
379 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
380 not EMACS_UINT, for indexes.
5eb55db9 381
0703a717
PE
382 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
383
d6202519
PE
384 * buffer.c: Include <verify.h>.
385 (struct sortvec.priority, struct sortstr.priority):
8961a454 386 Now EMACS_INT, not int.
c20998a7 387 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
388 (struct sortstr.size, record_overlay_string)
389 (struct sortstrlist.size, struct sortlist.used):
390 Don't truncate size to int.
391 (record_overlay_string): Check for size-calculation overflow.
d6202519 392 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 393
d5a19415
JM
3942011-06-22 Jim Meyering <meyering@redhat.com>
395
029529ac 396 Don't leak an XBM-image-sized buffer
d5a19415
JM
397 * image.c (xbm_load): Free the image buffer after using it.
398
a9041e6c
PE
3992011-06-21 Paul Eggert <eggert@cs.ucla.edu>
400
401 Port to Sun C.
402 * composite.c (find_automatic_composition): Omit needless 'return 0;'
403 that Sun C diagnosed.
404 * fns.c (secure_hash): Fix pointer signedness issue.
405 * intervals.c (static_offset_intervals): New function.
406 (offset_intervals): Use it.
407
7f3f739f
LL
4082011-06-21 Leo Liu <sdl.web@gmail.com>
409
410 * deps.mk (fns.o):
411 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
412 sha512.h.
413
414 * fns.c (secure_hash): Rename from crypto_hash_function and change
415 the first arg to accept symbols.
5b66d427 416 (Fsecure_hash): New primitive.
7f3f739f
LL
417 (syms_of_fns): New symbols.
418
76147d94
DD
4192011-06-20 Deniz Dogan <deniz@dogan.se>
420
421 * process.c (Fset_process_buffer): Clarify return value in
422 docstring.
423
7d7d0045
CY
4242011-06-18 Chong Yidong <cyd@stupidchicken.com>
425
426 * dispnew.c (add_window_display_history): Use BVAR.
427
428 * xdisp.c (debug_method_add): Use BVAR.
429 (check_window_end, dump_glyph_matrix, dump_glyph)
430 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
431
432 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
433 Likewise.
434
435 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
436 check till after the cache is created in init_frame_faces.
437
ff2bc410
SM
4382011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
439
440 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
441
28177add
PE
4422011-06-16 Paul Eggert <eggert@cs.ucla.edu>
443
dd3482fe
PE
444 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
445 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
446 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
447
393d71f3 448 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
449 * fileio.c (Finsert_file_contents):
450 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
451 Remove the old (too-loose) buffer overflow checks.
452 They weren't needed, since make_gap checks for buffer overflow.
453 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
454 The old code merely checked for Emacs fixnum overflow, and relied
455 on undefined (wraparound) behavior. The new code avoids undefined
456 behavior, and also checks for ptrdiff_t and/or size_t overflow.
457
2e6813b0 458 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
459 Tune. Don't use wider integers than needed. Don't use alloca.
460 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 461
599a9e4f
PE
462 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
463
99561444
PE
464 * insdel.c, lisp.h (buffer_overflow): New function.
465 (insert_from_buffer_1, replace_range, replace_range_2):
466 * insdel.c (make_gap_larger):
467 * editfns.c (Finsert_char):
468 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
469
28177add
PE
470 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
471
e69dafad
PE
4722011-06-15 Paul Eggert <eggert@cs.ucla.edu>
473
a7af7fde 474 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 475
b1c46f02
PE
476 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
477 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
478
e69dafad
PE
479 * fileio.c: Don't assume EMACS_INT fits in off_t.
480 (emacs_lseek): New static function.
481 (Finsert_file_contents, Fwrite_region): Use it.
482 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
483
566684ea
PE
484 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
485
e6966cd6
PE
486 * fns.c: Don't overflow int when computing a list length.
487 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
488 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
489 truncation on 64-bit hosts. Check for QUIT every
490 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
491 faster and is responsive enough.
492 (Flength): Report an error instead of overflowing an integer.
493 (Fsafe_length): Return a float if the value is not representable
494 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 495 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 496 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 497
dd0b0efb
PE
498 * alloc.c: Check that resized vectors' lengths fit in fixnums.
499 (header_size, word_size): New constants.
500 (allocate_vectorlike): Don't check size overflow here.
501 (allocate_vector): Check it here instead, since this is the only
502 caller of allocate_vectorlike that could cause overflow.
503 Check that the new vector's length is representable as a fixnum.
504
86fe5cfe
PE
505 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
506 The previous code was bogus. For example, next_almost_prime (32)
507 returned 39, which is undesirable as it is a multiple of 3; and
508 next_almost_prime (24) returned 25, which is a multiple of 5 so
509 why was the code bothering to check for multiples of 7?
510
80e88859
PE
511 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
512
4a2f0ad6
PE
513 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
514
f66c7cf8
PE
515 Variadic C functions now count arguments with ptrdiff_t.
516 This partly undoes my 2011-03-30 change, which replaced int with size_t.
517 Back then I didn't know that the Emacs coding style prefers signed int.
518 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
519 were being counted with int, which may truncate counts on 64-bit
520 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
521 * lisp.h (struct Lisp_Subr.function.aMANY)
522 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
523 Arg counts are now ptrdiff_t, not size_t.
524 All variadic functions and their callers changed accordingly.
525 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
526 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
527 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
528 * callint.c (Fcall_interactively): Check arg count for overflow,
529 to avoid potential buffer overrun. Use signed char, not 'int',
530 for 'varies' array, so that we needn't bother to check its size
531 calculation for overflow.
532 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
533 * eval.c (apply_lambda):
534 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
535 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
536 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
537
a1759b76
PE
538 * callint.c (Fcall_interactively): Don't use index var as event count.
539
d96be9fc
PE
540 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
541 * mem-limits.h (SIZE): Remove; no longer used.
542
a690a978 543 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 544
578c21e6
PE
545 Remove unnecessary casts.
546 * xterm.c (x_term_init):
547 * xfns.c (x_set_border_pixel):
548 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
549 These aren't needed now that we assume ANSI C.
550
96f53c6c
PE
551 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
552 It's more likely to cause problems (due to unsigned overflow)
553 than to cure them.
554
83c77d31
PE
555 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
556
ee2079f1
PE
557 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
558
6da65536
PE
559 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
560
7147c4a4
PE
561 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
562
193e32d9
PE
563 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
564
e5533da6
PE
565 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
566
9910e595
PE
567 GLYPH_CODE_FACE returns EMACS_INT, not int.
568 * dispextern.h (merge_faces):
569 * xfaces.c (merge_faces):
01103c44
PE
570 * xdisp.c (get_next_display_element, next_element_from_display_vector):
571 Don't assume EMACS_INT fits in int.
9910e595 572
2638320e
PE
573 * character.h (CHAR_VALID_P): Remove unused parameter.
574 * fontset.c, lisp.h, xdisp.c: All uses changed.
575
045eb8d9
PE
576 * editfns.c (Ftranslate_region_internal): Omit redundant test.
577
c1f134b5
PE
578 * fns.c (concat): Minor tuning based on overflow analysis.
579 This doesn't fix any bugs. Use int to hold character, instead
580 of constantly refetching from Emacs object. Use XFASTINT, not
581 XINT, for value known to be a character. Don't bother comparing
582 a single byte to 0400, as it's always less.
583
395fcb93 584 * floatfns.c (Fexpt):
327eeec8
PE
585 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
586
abbd3d23
PE
587 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
588 for characters.
589
684a03ef
PE
590 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
591
0fed43f3
PE
592 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
593 Without this fix, on a 64-bit host (aset S 0 4294967386) would
594 incorrectly succeed when S was a string, because 4294967386 was
595 truncated before it was used.
596
8fd02eb7
PE
597 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
598 Otherwise, an out-of-range integer could cause undefined behavior
599 on a 64-bit host.
600
f8c86b69
PE
601 * composite.c: Use int, not EMACS_INT, for characters.
602 (fill_gstring_body, composition_compute_stop_pos): Use int, not
603 EMACS_INT, for values that are known to be in character range.
604 This doesn't fix any bugs but is the usual style inside Emacs and
605 may generate better code on 32-bit machines.
606
34206dd2
PE
607 Make sure a 64-bit char is never passed to ENCODE_CHAR.
608 This is for reasons similar to the recent CHAR_STRING fix.
609 * charset.c (Fencode_char): Check that character arg is actually
610 a character. Pass an int to ENCODE_CHAR.
611 * charset.h (ENCODE_CHAR): Verify that the character argument is no
612 wider than 'int', as a compile-time check to prevent future regressions
613 in this area.
614
c5958d4c 615 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
616
617 Make sure a 64-bit char is never passed to CHAR_STRING.
618 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
619 by silently ignoring the top 32 bits, allowing some values
620 that were far too large to be valid characters.
621 * character.h: Include <verify.h>.
622 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
623 arguments are no wider than unsigned, as a compile-time check
624 to prevent future regressions in this area.
625 * data.c (Faset):
01103c44 626 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
627 (Fsubst_char_in_region):
628 * fns.c (concat):
629 * xdisp.c (decode_mode_spec_coding):
630 Adjust to CHAR_STRING's new requirement.
631 * editfns.c (Finsert_char, Fsubst_char_in_region):
632 * fns.c (concat): Check that character args are actually
633 characters. Without this test, these functions did the wrong
634 thing with wildly out-of-range values on 64-bit hosts.
635
d37ca623
PE
636 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
637 These casts should not be needed on 32-bit hosts, either.
638 * keyboard.c (read_char):
639 * lread.c (Fload): Remove casts to unsigned.
640
ea204efb
PE
641 * lisp.h (UNSIGNED_CMP): New macro.
642 This fixes comparison bugs on 64-bit hosts.
643 (ASCII_CHAR_P): Use it.
644 * casefiddle.c (casify_object):
01103c44 645 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
646 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
647 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
648 * dispextern.h (FACE_FROM_ID):
649 * keyboard.c (read_char): Use UNSIGNED_CMP.
650
41cb286c
PE
651 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
652 not to EMACS_INT, to avoid GCC warning.
653
4a1b9832
PE
654 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
655
55daad71
PE
656 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
657 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
658 isn't needed on 32-bit machines.
8f95c75c 659
01103c44
PE
660 * buffer.c (Fgenerate_new_buffer_name):
661 Use EMACS_INT for count, not int.
0ceccced 662 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
663
664 * data.c (Qcompiled_function): Now static.
665
c6f072e7
PE
666 * window.c (window_body_lines): Now static.
667
20ce5912
PE
668 * image.c (gif_load): Rename local to avoid shadowing.
669
9c4c5f81
PE
670 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
671 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
672 * alloc.c (make_save_value): Integer argument is now of type
673 ptrdiff_t, not int.
674 (mark_object): Use ptrdiff_t, not int.
675 * lisp.h (pD): New macro.
676 * print.c (print_object): Use it.
677
c0c5c8ae
PE
678 * alloc.c: Use EMACS_INT, not int, to count objects.
679 (total_conses, total_markers, total_symbols, total_vector_size)
680 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
681 (total_free_floats, total_floats, total_free_intervals)
682 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
683 Now EMACS_INT, not int. All uses changed.
684 (Fgarbage_collect): Compute overall total using a double, so that
685 integer overflow is less likely to be a problem. Check for overflow
686 when converting back to an integer.
5a25e253
PE
687 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
688 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
689 These were 'int' variables that could overflow on 64-bit hosts;
690 they were never used, so remove them instead of repairing them.
211a0b2a 691 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
692 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
693 Previously, this ceilinged at INT_MAX, but that doesn't work on
694 64-bit machines.
e46bb31a 695 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 696
c78baabf 697 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 698 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
699 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
700 when a (possibly-narrower) signed value would do just as well.
701 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 702
c9d624c6
PE
703 * alloc.c: Catch some string size overflows that we were missing.
704 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
705 for convenience in STRING_BYTES_MAX.
706 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
707 The definition here is exact; the one in lisp.h was approximate.
708 (allocate_string_data): Check for string overflow. This catches
709 some instances we weren't catching before. Also, it catches
710 size_t overflow on (unusual) hosts where SIZE_MAX <= min
711 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
712 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 713
c9d624c6
PE
714 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
715 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
716 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
717
353032ce
PE
718 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
719
2bccce07
PE
720 * alloc.c (Fmake_string): Check for out-of-range init.
721
0ac30604
SM
7222011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
723
724 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
725
c195f2de
JD
7262011-06-14 Jan Djärv <jan.h.d@swipnet.se>
727
728 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
729 xg_get_default_scrollbar_width.
730
731 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
732 (int_gtk_range_get_value): Move to the scroll bar part of the file.
733 (style_changed_cb): Call update_theme_scrollbar_width and call
734 x_set_scroll_bar_default_width and xg_frame_set_char_size for
735 all frames (Bug#8505).
736 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
737 Call gtk_window_set_resizable if HAVE_GTK3.
738 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
739 and height if HAVE_GTK3 (Bug#8505).
740 (scroll_bar_width_for_theme): New variable.
741 (update_theme_scrollbar_width): New function.
742 (xg_get_default_scrollbar_width): Move code to
743 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
744 (xg_initialize): Call update_theme_scrollbar_width.
745
746 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
747
748 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
749
e10ac9f1
MR
7502011-06-12 Martin Rudalics <rudalics@gmx.at>
751
752 * frame.c (make_frame): Call other_buffer_safely instead of
753 other_buffer.
754
755 * window.c (temp_output_buffer_show): Call display_buffer with
756 second argument Vtemp_buffer_show_specifiers and reset latter
757 immediately after the call.
758 (Vtemp_buffer_show_specifiers): New variable.
759 (auto_window_vscroll_p, next_screen_context_lines)
760 (Vscroll_preserve_screen_position): Remove leading asterisks from
761 doc-strings.
762
2d3c217e 7632011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 764
7b7f97e8 765 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
766 * buffer.c (Qclone_number): Remove for now, as it's unused.
767 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
768 (record_buffer): Remove unused local.
769 * frame.c (other_visible_frames, frame_buffer_list): Now static.
770 (set_frame_buffer_list): Remove; unused.
771 * frame.h (other_visible_frames): Remove decl.
772 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
773 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
774 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
775 if HAVE_GPM.
776 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
777 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
778 Define only if HAVE_GPM.
779 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
780 (update_hints_inhibit): Remove; never set. All uses removed.
781 * widgetprv.h (emacsFrameClassRec): Remove decl.
782 * window.c (delete_deletable_window): Now returns void, since it
783 wasn't returning anything.
784 (compare_window_configurations): Remove unused locals.
785 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
786 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
787 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
788 the same widths as pointers. This follows up on the 2011-05-06 patch.
789 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
790 * xterm.h: Likewise.
791 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
792
1384b89e
JB
7932011-06-12 Juanma Barranquero <lekktu@gmail.com>
794
795 * makefile.w32-in: Update dependencies.
796 (LISP_H): Add lib/intprops.h.
797
1100a63c
CY
7982011-06-11 Chong Yidong <cyd@stupidchicken.com>
799
800 * image.c (gif_load): Add animation frame delay to the metadata.
801 (syms_of_image): Use DEFSYM. New symbol `delay'.
802
6198ccd0
MR
8032011-06-11 Martin Rudalics <rudalics@gmx.at>
804
805 * window.c (delete_deletable_window): Re-add.
806 (Fset_window_configuration): Rewrite to handle dead buffers and
807 consequently deletable windows.
808 (window_tree, Fwindow_tree): Remove. Supply functionality in
809 window.el.
810 (compare_window_configurations): Simplify code.
811
b6e3633c
AS
8122011-06-11 Andreas Schwab <schwab@linux-m68k.org>
813
1ab0dee5
AS
814 * image.c (imagemagick_load_image): Fix type mismatch.
815 (Fimagemagick_types): Likewise.
816
b6e3633c
AS
817 * window.h (replace_buffer_in_windows): Declare.
818
9397e56f
MR
8192011-06-11 Martin Rudalics <rudalics@gmx.at>
820
821 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
822 Qclone_number. Remove external declaration of Qdelete_window.
823 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
824 code.
825 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
826 Qbuffer_list_update_hook if allowed.
827 (Fother_buffer): Rewrite doc-string. Major rewrite for new
828 buffer list implementation.
829 (other_buffer_safely): New function.
830 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
831 calls to replace_buffer_in_windows and
832 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
833 if allowed.
834 (record_buffer): Inhibit quitting and rewrite using quittable
835 functions. Run Qbuffer_list_update_hook if allowed.
836 (Frecord_buffer, Funrecord_buffer): New functions.
837 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
838 switch-to-buffer to window.el.
839 (bury-buffer): Move to window.el.
840 (Vbuffer_list_update_hook): New variable.
841
842 * lisp.h (other_buffer_safely): Add prototype in buffer.c
843 section.
844
845 * window.h (resize_frame_windows): Move up in code.
846 (Fwindow_frame): Remove EXFUN.
847 (replace_buffer_in_all_windows): Remove prototype.
848 (replace_buffer_in_windows_safely): Add prototype.
849
850 * window.c: Declare Qdelete_window static again. Move down
851 declaration of select_count.
852 (Fnext_window, Fprevious_window): Rewrite doc-strings.
853 (Fother_window): Move to window.el.
854 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
855 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
856 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
857 window.el.
858 (replace_buffer_in_windows): Implement by calling
859 Qreplace_buffer_in_windows.
860 (replace_buffer_in_all_windows): Remove with some functionality
861 moved into replace_buffer_in_windows_safely.
862 (replace_buffer_in_windows_safely): New function.
863 (select_window_norecord, select_frame_norecord): Move in front
864 of run_window_configuration_change_hook. Remove now obsolete
865 declarations.
866 (Fset_window_buffer): Rewrite doc-string. Call
867 Qrecord_window_buffer.
868 (keys_of_window): Move binding for other-window to window.el.
869
b50691aa
CY
8702011-06-11 Chong Yidong <cyd@stupidchicken.com>
871
872 * dispextern.h (struct image): Replace data member, whose int_val
873 and ptr_val fields were not used by anything, with a single
874 lisp_val object.
875
876 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
877 (gif_clear_image, gif_load, imagemagick_load_image)
878 (gs_clear_image, gs_load): Callers changed.
879
3f754b86
PE
8802011-06-10 Paul Eggert <eggert@cs.ucla.edu>
881
cca69397
PE
882 * buffer.h: Include <time.h>, for time_t.
883 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
884
109e28d0
PE
885 Fix minor problems found by static checking.
886
60737f02
PE
887 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
888
4b66faf3
PE
889 Make identifiers static if they are not used in other modules.
890 * data.c (Qcompiled_function, Qframe, Qvector):
891 * image.c (QimageMagick, Qsvg):
892 * minibuf.c (Qmetadata):
893 * window.c (resize_window_check, resize_root_window): Now static.
894 * window.h (resize_window_check, resize_root_window): Remove decls.
895
109e28d0
PE
896 * window.c (window_deletion_count, delete_deletable_window):
897 Remove; unused.
46a4ce9e
PE
898 (window_body_lines): Now static.
899 (Fdelete_other_windows_internal): Mark vars as initialized.
900 Make sure 'resize_failed' is initialized.
901 (run_window_configuration_change_hook): Rename local to avoid shadowing.
902 (resize_window_apply): Remove unused local.
903 * window.h (delete_deletable_window): Remove decl.
904
109e28d0 905 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
906 (imagemagick_load_image): Fix pointer signedness problem by changing
907 last arg from unsigned char * to char *. All uses changed.
908 Also, fix a local for similar reasons.
909 Remove unused locals. Remove locals to avoid shadowing.
910 (fn_rsvg_handle_free): Remove; unused.
911 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 912 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 913
3f754b86
PE
914 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
915
2547adb1
CY
9162011-06-10 Chong Yidong <cyd@stupidchicken.com>
917
918 * image.c (gif_load): Fix omitted cast error introduced by
919 2011-06-06 change.
920
2c8e37d4
MR
9212011-06-10 Martin Rudalics <rudalics@gmx.at>
922
923 * window.h (resize_proportionally, orig_total_lines)
924 (orig_top_line): Remove from window structure.
925 (set_window_height, set_window_width, change_window_heights)
926 (Fdelete_window): Remove prototypes.
927 (resize_frame_windows): Remove duplicate declaration.
928
440a42e3
EZ
9292011-06-10 Eli Zaretskii <eliz@gnu.org>
930
931 * window.h (resize_frame_windows, resize_window_check)
932 (delete_deletable_window, resize_root_window)
933 (resize_frame_windows): Declare prototypes.
934
935 * window.c (resize_window_apply): Make definition be "static" to
936 match the prototype.
937
562dd5e9
MR
9382011-06-10 Martin Rudalics <rudalics@gmx.at>
939
940 * window.c: Remove declarations of Qwindow_size_fixed,
941 window_min_size_1, window_min_size_2, window_min_size,
942 size_window, window_fixed_size_p, enlarge_window, delete_window.
943 Remove static from declaration of Qdelete_window, it's
944 temporarily needed by Fbury_buffer.
945 (replace_window): Don't assign orig_top_line and
946 orig_total_lines.
947 (Fdelete_window, delete_window): Remove. Window deletion is
948 handled by window.el.
949 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
950 Fdelete_window calls with calls to Qdelete_window.
951 (Fdelete_other_windows): Remove. Deleting other windows is
952 handled by window.el.
953 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
954 handled in window.el.
955 (window_min_size_2, window_min_size_1, window_min_size): Remove.
956 Window minimum sizes are handled in window.el.
957 (shrink_windows, size_window, set_window_height)
958 (set_window_width, change_window_heights, window_height)
959 (window_width, CURBEG, CURSIZE, enlarge_window)
960 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
961 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
962 handled in window.el.
963 (make_dummy_parent): Rename to make_parent_window and give it a
964 second argument horflag.
965 (make_window): Don't set resize_proportionally any more.
966 (Fsplit_window): Remove. Windows are split in window.el.
967 (save_restore_action, save_restore_orig_size)
968 (shrink_window_lowest_first, save_restore_orig_size): Remove.
969 Resize mini windows in window.el.
970 (grow_mini_window, shrink_mini_window): Implement by calling
971 Qresize_root_window_vertically, resize_window_check and
972 resize_window_apply.
973 (saved_window, Fset_window_configuration, save_window_save): Do
974 not handle orig_top_line, orig_total_lines, and
975 resize_proportionally.
976 (window_min_height, window_min_width): Move to window.el.
977 (keys_of_window): Move bindings for delete-other-windows,
978 split-window, delete-window and enlarge-window to window.el.
979
980 * buffer.c: Temporarily extern Qdelete_window.
981 (Fbury_buffer): Temporarily call Qdelete_window instead of
982 Fdelete_window (Fbury_buffer will move to window.el soon).
983
984 * frame.c (set_menu_bar_lines_1): Remove code handling
985 orig_top_line and orig_total_lines.
986
987 * dispnew.c (adjust_frame_glyphs_initially): Don't use
988 set_window_height but set heights directly.
989 (change_frame_size_1): Use resize_frame_windows.
990
991 * xdisp.c (init_xdisp): Don't use set_window_height but set
992 heights directly.
993
994 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
995 resize_frame_windows instead of change_window_heights and run
996 run_window_configuration_change_hook.
997
998 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
999 instead of change_window_heights and run
1000 run_window_configuration_change_hook.
1001
1a13852e
MR
10022011-06-09 Martin Rudalics <rudalics@gmx.at>
1003
1004 * window.c (replace_window): Rename second argument REPLACEMENT to
1005 NEW. New third argument SETFLAG. Rewrite.
1006 (delete_window, make_dummy_parent): Call replace_window with
1007 third argument 1.
1008 (window_list_1): Move down in code.
1009 (run_window_configuration_change_hook): Move set_buffer part
1010 before select_frame_norecord part in order to unwind correctly.
1011 Rename count1 to count.
1012 (recombine_windows, delete_deletable_window, resize_root_window)
1013 (Fdelete_other_windows_internal)
1014 (Frun_window_configuration_change_hook, make_parent_window)
1015 (resize_window_check, resize_window_apply, Fresize_window_apply)
1016 (resize_frame_windows, Fsplit_window_internal)
1017 (Fdelete_window_internal, Fresize_mini_window_internal): New
1018 functions.
1019 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1020
f3d1777e
MR
10212011-06-08 Martin Rudalics <rudalics@gmx.at>
1022
496e208e
MR
1023 * window.h (window): Add some new members to window structure -
1024 normal_lines, normal_cols, new_total, new_normal, clone_number,
1025 splits, nest, prev_buffers, next_buffers.
1026 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1027 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1028
f3d1777e
MR
1029 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1030 Remove.
496e208e
MR
1031 (make_dummy_parent): Set new members of windows structure.
1032 (make_window): Move down in code. Handle new members of window
1033 structure.
1034 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1035 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1036 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1037 (Fset_window_prev_buffers, Fwindow_next_buffers)
1038 (Fset_window_next_buffers, Fset_window_clone_number): New
1039 functions.
1040 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1041 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1042 Doc-string fixes.
1043 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1044 Argument WINDOW can be now internal window too.
1045 (Fwindow_use_time): Move up in code.
1046 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1047 Rewrite doc-string.
1048 (Fset_window_configuration, saved_window)
1049 (Fcurrent_window_configuration, save_window_save): Handle new
1050 members of window structure.
b9e809c2
MR
1051 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1052 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1053 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1054 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1055 Qget_mru_window, Qresize_root_window,
1056 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1057 Qauto_buffer_name; staticpro them.
f3d1777e 1058
abde8f8c
MR
10592011-06-07 Martin Rudalics <rudalics@gmx.at>
1060
1061 * window.c (Fwindow_total_size, Fwindow_left_column)
1062 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1063 (Fwindow_list_1): New functions.
1064 (window_box_text_cols): Replace with window_body_cols.
1065 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1066 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1067 (delete_window, Fset_window_configuration): Call
1068 delete_all_subwindows with window as argument.
1069 (delete_all_subwindows): Take a window as argument and not a
1070 structure. Rewrite.
190b47e6
MR
1071 (window_loop): Remove handling of GET_LRU_WINDOW and
1072 GET_LARGEST_WINDOW.
1073 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1074
1075 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1076 window_box_text_cols. delete_all_subwindows now takes a
1077 Lisp_Object as argument.
abde8f8c
MR
1078
1079 * indent.c (compute_motion, Fcompute_motion): Use
1080 window_body_cols instead of window_box_text_cols.
1081
fa8a67e6
MR
1082 * frame.c (delete_frame): Call delete_all_subwindows with root
1083 window as argument.
1084
a54e3482
DC
10852011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1086
1087 * fns.c (Fputhash): Document return value.
1088
60002bf5
CY
10892011-06-06 Chong Yidong <cyd@stupidchicken.com>
1090
1091 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1092
0c671da6 10932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1094
b862a52a 1095 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1096
be44ca6c
PE
1097 Check for overflow when converting integer to cons and back.
1098 * charset.c (Fdefine_charset_internal, Fdecode_char):
1099 Use cons_to_unsigned to catch overflow.
1100 (Fencode_char): Use INTEGER_TO_CONS.
1101 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1102 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1103 * data.c (long_to_cons, cons_to_long): Remove.
1104 (cons_to_unsigned, cons_to_signed): New functions.
1105 These signal an error for invalid or out-of-range values.
1106 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1107 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1108 * font.c (Ffont_variation_glyphs):
1109 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1110 * lisp.h: Include <intprops.h>.
1111 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1112 (cons_to_signed, cons_to_unsigned): New decls.
1113 (long_to_cons, cons_to_long): Remove decls.
1114 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1115 (Fprimitive_undo): Use CONS_TO_INTEGER.
1116 * xfns.c (Fx_window_property): Likewise.
1117 * xselect.c: Include <limits.h>.
1118 (x_own_selection, selection_data_to_lisp_data):
1119 Use INTEGER_TO_CONS.
1120 (x_handle_selection_request, x_handle_selection_clear)
1121 (x_get_foreign_selection, Fx_disown_selection_internal)
1122 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1123 (lisp_data_to_selection_data): Use cons_to_unsigned.
1124 (x_fill_property_data): Use cons_to_signed.
1125 Report values out of range.
1126
d1f3d2af
PE
1127 Check for buffer and string overflow more precisely.
1128 * buffer.h (BUF_BYTES_MAX): New macro.
1129 * lisp.h (STRING_BYTES_MAX): New macro.
1130 * alloc.c (Fmake_string):
1131 * character.c (string_escape_byte8):
1132 * coding.c (coding_alloc_by_realloc):
1133 * doprnt.c (doprnt):
1134 * editfns.c (Fformat):
1135 * eval.c (verror):
1136 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1137 since they may not be the same number.
1138 * editfns.c (Finsert_char):
1139 * fileio.c (Finsert_file_contents):
1140 Likewise for BUF_BYTES_MAX.
1141
dd52fcea
PE
1142 * image.c: Use ptrdiff_t, not int, for sizes.
1143 (slurp_file): Switch from int to ptrdiff_t.
1144 All uses changed.
1145 (slurp_file): Check that file size fits in both size_t (for
1146 malloc) and ptrdiff_t (for sanity and safety).
1147
7f9bbdbb
PE
1148 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1149 if b->modtime has its maximal value.
1150
dfe18f82
PE
1151 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1152
84acfcf0
PE
1153 Don't assume time_t can fit into int.
1154 * buffer.h (struct buffer.modtime): Now time_t, not int.
1155 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1156 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1157
ccd9a01a
PE
1158 Minor fixes for signed vs unsigned integers.
1159 * character.h (MAYBE_UNIFY_CHAR):
1160 * charset.c (maybe_unify_char):
1161 * keyboard.c (read_char, reorder_modifiers):
1162 XINT -> XFASTINT, since the integer must be nonnegative.
1163 * ftfont.c (ftfont_spec_pattern):
1164 * keymap.c (access_keymap, silly_event_symbol_error):
1165 XUINT -> XFASTINT, since the integer must be nonnegative.
1166 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1167 since it makes no difference and we prefer signed.
1168 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1169 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1170 nonnegative.
1171
d6d100dd
SM
11722011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1173
1174 * window.h (Fwindow_frame): Declare.
1175
2b6148e4
PE
11762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1179 (SPARE_MEMORY): Always define.
1180 (LARGE_REQUEST): Remove.
1181 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1182
f230ecc9
MR
11832011-06-06 Martin Rudalics <rudalics@gmx.at>
1184
727e958e
MR
1185 * lisp.h: Move EXFUNS for Fframe_root_window,
1186 Fframe_first_window and Fset_frame_selected_window to window.h.
1187
1188 * window.h: Move EXFUNS for Fframe_root_window,
1189 Fframe_first_window and Fset_frame_selected_window here from
1190 lisp.h.
1191
1192 * frame.c (Fwindow_frame, Fframe_first_window)
1193 (Fframe_root_window, Fframe_selected_window)
1194 (Fset_frame_selected_window): Move to window.c.
1195 (Factive_minibuffer_window): Move to minibuf.c.
1196 (Fother_visible_frames_p): New function.
1197
1198 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1199
f230ecc9
MR
1200 * window.c (decode_window, decode_any_window): Move up in code.
1201 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1202 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1203 (Fwindow_buffer): Move up and rewrite doc-string.
1204 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1205 (Fwindow_prev): New functions.
727e958e
MR
1206 (Fwindow_frame): Move here from frame.c. Accept any window as
1207 argument.
1208 (Fframe_root_window, Fframe_first_window)
1209 (Fframe_selected_window): Move here from frame.c. Accept frame
1210 or arbitrary window as argument. Update doc-strings.
1211 (Fminibuffer_window): Move up in code.
1212 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1213 (Fset_frame_selected_window): Move here from frame.c.
1214 Marginal rewrite.
727e958e
MR
1215 (Fselected_window, select_window, Fselect_window): Move up in
1216 code. Minor doc-string fixes.
f230ecc9 1217
4d09bcf6
PE
12182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1221 Do not assume that spare memory exists; that assumption is valid
1222 only if SYSTEM_MALLOC.
1223 (LARGE_REQUEST): New macro, so that the issue of large requests
1224 is separated from the issue of spare memory.
1225
810928a2
AS
12262011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1227
172418ad
AS
1228 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1229 format. (Bug#8806)
1230
43f862f7
AS
1231 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1232
810928a2
AS
1233 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1234 before statements.
1235
a059fe24
JD
12362011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1239
1240 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1241
1242 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1243 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1244
989bf368
JB
12452011-06-05 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1248
4b80f674
CY
12492011-06-04 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1252 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1253 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1254 New error handlers.
4b80f674
CY
1255 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1256 Obey Vx_select_enable_clipboard_manager. Catch errors in
1257 x_clipboard_manager_save (Bug#8779).
1258 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1259 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1260
99a33b77 12612011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1262
1263 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1264
99a33b77 12652011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1266
1267 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1268 in the current matrix if keep_current_p is non-zero.
1269
8264569d
EZ
12702011-06-04 Eli Zaretskii <eliz@gnu.org>
1271
1272 * bidi.c (bidi_level_of_next_char): Fix last change.
1273
57f97249
EZ
12742011-06-03 Eli Zaretskii <eliz@gnu.org>
1275
fec2107c 1276 Support bidi reordering of text covered by display properties.
57f97249 1277
fec2107c
EZ
1278 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1279 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1280 (bidi_cache_search, bidi_cache_iterator_state)
1281 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1282 (bidi_level_of_next_char, bidi_move_to_visually_next):
1283 Support character positions inside a run of characters covered by a
fec2107c
EZ
1284 display string.
1285 (bidi_paragraph_init, bidi_resolve_explicit_1)
1286 (bidi_level_of_next_char): Call bidi_fetch_char and
1287 bidi_fetch_char_advance instead of FETCH_CHAR and
1288 FETCH_CHAR_ADVANCE.
1289 (bidi_init_it): Initialize new members.
1290 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1291 definitions.
1292 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1293 instead of using explicit *_CHAR codes.
d6d100dd
SM
1294 (bidi_resolve_explicit, bidi_resolve_weak):
1295 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1296 bidirectional text is supported only in multibyte buffers.
1297 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1298 it to initialize the frame_window_p member of struct bidi_it.
1299 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1300 (bidi_resolve_explicit, bidi_resolve_weak)
1301 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1302 bidi_it->nchars is non-positive.
1303 (bidi_level_of_next_char): Don't try to lookup the cache for the
1304 next/previous character if nothing is cached there yet, or if we
1305 were just reseat()'ed to a new position.
c40e2fb2 1306
0e14fe90
EZ
1307 * xdisp.c (set_cursor_from_row): Set start and stop points
1308 according to the row's direction when priming the loop that looks
1309 for the glyph on which to display cursor.
1310 (single_display_spec_intangible_p): Function deleted.
1311 (display_prop_intangible_p): Reimplement to call
1312 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1313 Accept 3 additional arguments needed by handle_display_spec.
1314 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1315 values: lists, `(when COND...)' forms, etc.
1316 (single_display_spec_string_p): Support property values that are
1317 lists with the argument STRING its top-level element.
1318 (display_prop_string_p): Fix the condition for processing a
1319 property that is a list to be consistent with handle_display_spec.
fec2107c 1320 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1321 last portion of handle_display_prop.
1322 (compute_display_string_pos): Accept additional argument
1323 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1324 value of a `display' property is a "replacing spec".
1325 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1326 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1327 the display property, but just return a value indicating whether
1328 the display property will replace the characters it covers.
1329 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1330 frame_window_p members of struct bidi_it.
d6d100dd
SM
1331 (compute_display_string_pos, compute_display_string_end):
1332 New functions.
fec2107c
EZ
1333 (push_it): Accept second argument POSITION, where pop_it should
1334 jump to continue iteration.
1335 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1336
fec2107c
EZ
1337 * keyboard.c (adjust_point_for_property): Adjust the call to
1338 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1339
1340 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1341 (bidi_init_it): Update prototypes.
1342 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1343 (compute_display_string_pos, compute_display_string_end):
1344 Declare prototypes.
fec2107c
EZ
1345 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1346 EMACS_INT.
fc6f18ce 1347
40087514 13482011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1349
57f53182
PE
1350 Malloc failure behavior now depends on size of allocation.
1351 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1352 * lisp.h: Change signatures accordingly.
1353 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1354 All callers changed. (Bug#8762)
1355
1356 * gnutls.c: Use Emacs's memory allocators.
1357 Without this change, the gnutls library would invoke malloc etc.
1358 directly, which causes problems on non-SYNC_INPUT hosts, and which
1359 runs afoul of improving memory_full behavior. (Bug#8761)
1360 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1361 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1362 xfree instead of the default malloc, realloc, free.
1363 (Fgnutls_boot): No need to check for memory allocation failure,
1364 since xmalloc does that for us.
1365
ac32cd99 1366 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1367 * category.c (hash_get_category_set):
1368 * ccl.c (ccl_driver):
1369 * charset.c (Fdefine_charset_internal):
1370 * charset.h (struct charset.hash_index):
1371 * composite.c (get_composition_id, gstring_lookup_cache)
1372 (composition_gstring_put_cache):
1373 * composite.h (struct composition.hash_index):
1374 * dispextern.h (struct image.hash):
1375 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1376 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1377 (hashfn_equal, hashfn_user_defined, make_hash_table)
1378 (maybe_resize_hash_table, hash_lookup, hash_put)
1379 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1380 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1381 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1382 * image.c (make_image, search_image_cache, lookup_image)
1383 (xpm_put_color_table_h):
1384 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1385 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1386 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1387 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1388 * alloc.c (allocate_vectorlike):
1389 Check for overflow in vector size calculations.
1390 * ccl.c (ccl_driver):
1391 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1392 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1393 need to be updated by these changes.
40087514
PE
1394 * fns.c (make_hash_table, maybe_resize_hash_table):
1395 Check for integer overflow with large hash tables.
0de4bb68
PE
1396 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1397 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1398 (SXHASH_REDUCE): New macro.
1399 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1400 Use it instead of discarding useful hash info with large hash values.
1401 (sxhash_float): New function.
1402 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1403 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1404 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1405 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1406 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1407 Adjust signatures to match updated version of code.
1408 (consing_since_gc): Now EMACS_INT, since a single hash table can
1409 use more than INT_MAX bytes.
1410
698d32e2
DN
14112011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1412
1413 Make it possible to build with GCC-4.6+ -O2 -flto.
1414
1415 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1416
fd6fa53f
SM
14172011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1420 Call minibuffer-inactive-mode.
1421
864db017
JB
14222011-05-31 Juanma Barranquero <lekktu@gmail.com>
1423
1424 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1425 Update dependencies.
1426
2ad0baf4
DN
14272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1428
1429 * data.c (init_data): Remove code for UTS, this system is not
1430 supported anymore.
1431
4fcc2638
DN
14322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1433
1434 Don't force ./temacs to start in terminal mode.
1435
1436 * frame.c (make_initial_frame): Initialize faces in all cases, not
1437 only when CANNOT_DUMP is defined.
1438 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1439
c56e0fd5
DN
14402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1441
1442 * dispnew.c (add_window_display_history): Use const for the string
1443 pointer. Remove declaration, not needed.
1444
333d54da 14452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1446
55d4c1b2 1447 Use 'inline', not 'INLINE'.
333d54da 1448 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1449 * alloc.c, fontset.c (INLINE): Remove.
1450 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1451 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1452 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1453 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1454 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1455
738db178
DN
14562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1457
1458 Make it possible to run ./temacs.
1459
1460 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1461 syms_of_callproc does the same thing. Remove test for
1462 "initialized", do it in the caller.
1463 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1464
620c53a6
SM
14652011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1466
1467 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1468 (read_minibuf): Use get_minibuffer.
1469 (syms_of_minibuf): Use DEFSYM.
1470 (Qmetadata): New var.
1471 * data.c (Qbuffer): Don't make it static.
1472 (syms_of_data): Use DEFSYM.
1473
e003a292
PE
14742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1477 (CCL_CODE_MIN): New macro.
1478
ed008a6d
PE
14792011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1480
3687c2ef
PE
1481 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1482
ed008a6d
PE
1483 * eval.c (Qdebug): Now static.
1484 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1485 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1486 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1487
d66c4c7c
CY
14882011-05-29 Chong Yidong <cyd@stupidchicken.com>
1489
1490 * image.c: Various fixes to ImageMagick code comments.
1491 (Fimagemagick_types): Doc fix.
1492
5fbc2025
PE
14932011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1494
0196f88a
PE
1495 Minor fixes prompted by GCC 4.6.0 warnings.
1496
1497 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1498
5fbc2025
PE
1499 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1500 (x_clipboard_manager_save_all): Move extern decl to ...
1501 * xterm.h: ... here, so that it can be checked for consistency.
1502
1dd3c2d9
CY
15032011-05-29 Chong Yidong <cyd@stupidchicken.com>
1504
1505 * xselect.c (x_clipboard_manager_save_frame)
1506 (x_clipboard_manager_save_all): New functions.
1507 (Fx_clipboard_manager_save): Lisp function deleted.
1508
1509 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1510 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1511
1512 * xterm.h: Update prototype.
1513
5ba6571d
WX
15142011-05-28 William Xu <william.xwl@gmail.com>
1515
1516 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1517 exiting (Bug#8239).
1518
3eaff834
JM
15192011-05-28 Jim Meyering <meyering@redhat.com>
1520
e1900994 1521 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1522 * fns.c (to_uchar): Define.
1523 (crypto_hash_function): Use it to convert some newly-signed
1524 variables to unsigned, to avoid sign-extension bugs. For example,
1525 without this change, (md5 "truc") would evaluate to
1526 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1527 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1528 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1529
0f6990a7
PE
15302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1531
1532 Integer overflow fixes.
c8a9ca5a 1533
08686060
PE
1534 * dbusbind.c: Serial number integer overflow fixes.
1535 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1536 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1537 to hold a serial number that is too large for a fixnum.
1538 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1539 Check for serial numbers out of range. Decode any serial number
59568bf0 1540 that was so large that it became a float. (Bug#8722)
08686060 1541
2d1fc3c7
PE
1542 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1543 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1544 Use XFASTINT rather than XUINT when numbers are nonnegative.
1545 (xd_append_arg, Fdbus_method_return_internal):
1546 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1547 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1548 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1549 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1550 (Bug#8722)
2d1fc3c7 1551
c8a9ca5a
PE
1552 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1553
519e1d69
PE
1554 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1555
30569699
PE
1556 ccl: add integer overflow checks
1557 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1558 (IN_INT_RANGE): New macros.
1559 (ccl_driver): Use them to check for integer overflow when
1560 decoding a CCL program. Many of the new checks are whether XINT (x)
1561 fits in int; it doesn't always, on 64-bit hosts. The new version
1562 doesn't catch all possible integer overflows, but it's an
847044ea 1563 improvement. (Bug#8719)
30569699 1564
c11285dc
PE
1565 * alloc.c (make_event_array): Use XINT, not XUINT.
1566 There's no need for unsigned here.
1567
fdccd48e
PE
1568 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1569 This follows up to the 2011-05-06 change that substituted uintptr_t
1570 for EMACS_INT. This case wasn't caught back then.
1571
37910ab2
PE
1572 Rework Fformat to avoid integer overflow issues.
1573 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1574 now (part of C89). Include <verify.h>.
1575 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1576 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1577 (Fformat): Avoid the prepass trying to compute sizes; it was only
1578 approximate and thus did not catch overflow reliably. Instead, walk
1579 through the format just once, formatting and computing sizes as we go,
1580 checking for integer overflow at every step, and allocating a larger
1581 buffer as needed. Keep track separately whether the format is
1582 multibyte. Keep only the most-recently calculated precision, rather
1583 than them all. Record whether each argument has been converted to
1584 string. Use EMACS_INT, not int, for byte and char and arg counts.
1585 Support field widths and precisions larger than INT_MAX. Avoid
1586 sprintf's undefined behavior with conversion specifications such as %#d
1587 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1588 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1589 formatting out-of-range floating point numbers with int
1590 formats. (Bug#8668)
1591
2e6578fb
PE
1592 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1593
0ae6bdee
PE
1594 * data.c: Avoid integer truncation in expressions involving floats.
1595 * data.c: Include <intprops.h>.
1596 (arith_driver): When there's an integer overflow in an expression
1597 involving floating point, convert the integers to floating point
1598 so that the resulting value does not suffer from catastrophic
1599 integer truncation. For example, on a 64-bit host (* 4
1600 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1601 Do not rely on undefined behavior after integer overflow.
1602
de883a70
PE
1603 merge count_size_as_multibyte, parse_str_to_multibyte
1604 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1605 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1606 Check for integer overflow.
1607 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1608 since it's now a duplicate of the other. This is more of
1609 a character than a buffer op, so better that it's in character.c.
1610 * fns.c, print.c: Adjust to above changes.
1611
2ff916cb
PE
16122011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1613
1614 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1615
f1b54466
PE
16162011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1617
fb1ac845
PE
1618 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1619 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1620 (x_clipboard_manager_save): Now static.
1621 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1622
f1b54466
PE
1623 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1624 (crypto_hash_function): Now static.
1625 Fix pointer signedness problems. Avoid unnecessary initializations.
1626
a9f737ee
CY
16272011-05-27 Chong Yidong <cyd@stupidchicken.com>
1628
1629 * termhooks.h (Vselection_alist): Make it terminal-local.
1630
1631 * terminal.c (create_terminal): Initialize it.
1632
1633 * xselect.c: Support for clipboard managers.
1634 (Vselection_alist): Move to termhooks.h as terminal-local var.
1635 (LOCAL_SELECTION): New macro.
1636 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1637 (symbol_to_x_atom): Remove gratuitous arg.
1638 (x_handle_selection_request, lisp_data_to_selection_data)
1639 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1640 (x_own_selection, x_get_local_selection, x_convert_selection):
1641 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1642 (some_frame_on_display): Delete unused function.
1643 (Fx_own_selection_internal, Fx_get_selection_internal)
1644 (Fx_disown_selection_internal, Fx_selection_owner_p)
1645 (Fx_selection_exists_p): New optional frame arg.
1646 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1647 (x_handle_selection_clear): Don't treat other terminals with the
1648 same keyboard specially. Use the terminal-local Vselection_alist.
1649 (x_clear_frame_selections): Use Frun_hook_with_args.
1650
1651 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1652
1653 * xterm.h: Add support for those atoms.
1654
e067f0c1
CY
16552011-05-26 Chong Yidong <cyd@stupidchicken.com>
1656
1657 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1658 (converted_selections, conversion_fail_tag): New global variables.
1659 (x_selection_request_lisp_error): Free the above.
1660 (x_get_local_selection): Remove unnecessary code.
1661 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1662 of converted selections stored in converted_selections.
1663 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1664 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1665 (x_convert_selection): New function.
1666 (x_handle_selection_event): Simplify.
1667 (x_get_foreign_selection): Don't ignore incoming requests while
1668 waiting for an answer; this will fail when we implement
1669 SAVE_TARGETS, and seems unnecessary anyway.
1670 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1671 (Vx_sent_selection_functions): Doc fix.
1672
0f4aebc0
LL
16732011-05-26 Leo Liu <sdl.web@gmail.com>
1674
1675 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1676
e61124cd
YM
16772011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1678
1679 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1680
1681 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1682 for fringe update if it has periodic bitmap.
1683 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1684 and fringe_bitmap_periodic_p.
1685
1686 * fringe.c (get_fringe_bitmap_data): New function.
1687 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1688 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1689 row. Mark glyph row for fringe update if periodicity changed.
1690
1691 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1692 for fringe update unless it has periodic bitmap.
1693
f16d9837
KH
16942011-05-25 Kenichi Handa <handa@m17n.org>
1695
1696 * xdisp.c (get_next_display_element): Set correct it->face_id for
1697 a static composition.
1698
e1b90ef6
LL
16992011-05-24 Leo Liu <sdl.web@gmail.com>
1700
1701 * deps.mk (fns.o):
1702 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1703
1704 * fns.c (crypto_hash_function, Fsha1): New function.
1705 (Fmd5): Use crypto_hash_function.
1706 (syms_of_fns): Add Ssha1.
1707
7400048f
PE
17082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 * gnutls.c: Remove unused macros.
1711 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1712 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1713 Remove macros that are defined and never used.
1714 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1715
abb71cf4
CY
17162011-05-22 Chong Yidong <cyd@stupidchicken.com>
1717
1718 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1719 (Fx_get_selection_internal): Minor cleanup.
1720 (Fx_own_selection_internal): Rename arguments for consistency with
1721 select.el.
1722
6307db39
PE
17232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1726
f3d4e0a4
CY
17272011-05-22 Chong Yidong <cyd@stupidchicken.com>
1728
1729 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1730
4d8ade89
YM
17312011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1732
1733 * dispnew.c (scrolling_window): Don't exclude the case that the
1734 last enabled row in the desired matrix touches the bottom boundary.
1735
32078c8d
GM
17362011-05-21 Glenn Morris <rgm@gnu.org>
1737
1738 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1739 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1740 and add some more files.
32078c8d 1741
7285dc67
EZ
17422011-05-20 Eli Zaretskii <eliz@gnu.org>
1743
1744 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1745 report_file_error introduced by the change from 2011-05-07.
1746
89d1bd22
PE
17472011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * systime.h (Time): Define only if emacs is defined.
1750 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1751 where the include path doesn't have X11/X.h by default. See
1752 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1753
e23640bb 17542011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1755
1756 * composite.c (find_automatic_composition): Fix previous change.
1757
b9704ad9
GM
17582011-05-20 Glenn Morris <rgm@gnu.org>
1759
1760 * lisp.mk: New file, split from Makefile.in.
1761 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1762 (shortlisp): Remove.
1763 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1764
4a720484
GM
17652011-05-19 Glenn Morris <rgm@gnu.org>
1766
1767 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1768 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1769 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1770 (lisp): Set the order to that of loadup.el.
1771 (shortlisp): Make it a copy of $lisp.
1772 (SOME_MACHINE_LISP): Remove.
1773 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1774 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1775
a28d4396
KH
17762011-05-18 Kenichi Handa <handa@m17n.org>
1777
1778 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1779 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1780 (find_automatic_composition): Mostly rewrite for efficiency.
1781
a2b1fa8e
JB
17822011-05-18 Juanma Barranquero <lekktu@gmail.com>
1783
1784 * makefile.w32-in: Update dependencies.
1785
8e1f5610
CS
17862011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1787
1788 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1789 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1790
7025ee00 17912011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1792
cdfa6eab
PE
1793 Fix some integer overflow issues, such as string length overflow.
1794
06d6db33
PE
1795 * insdel.c (count_size_as_multibyte): Check for string overflow.
1796
2b4560a8
PE
1797 * character.c (lisp_string_width): Check for string overflow.
1798 Use EMACS_INT, not int, for string indexes and lengths; in
1799 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1800 the resulting string length overflows an EMACS_INT; instead,
1801 report a string overflow if no precision given. When checking for
1802 precision exhaustion, use a check that cannot possibly have
1803 integer overflow. (Bug#8675)
1804 * character.h (lisp_string_width): Adjust to new signature.
1805
cb93f9be
PE
1806 * alloc.c (string_overflow): New function.
1807 (Fmake_string): Use it. This doesn't change behavior, but saves
1808 a few bytes and will simplify future changes.
1809 * character.c (string_escape_byte8): Likewise.
1810 * lisp.h (string_overflow): New decl.
1811
1a1f3366
PE
1812 Fixups, following up to the user-interface timestamp change.
1813 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1814 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1815 * msdos.c (mouse_get_pos): Likewise.
1816 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1817 * w32gui.h (Time): Define by including "systime.h" rather than by
1818 declaring it ourselves. (Bug#8664)
1819
d4e3e4d3
PE
1820 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1821 * image.c (clear_image_cache): Likewise.
1822
f6a24d19
PE
1823 * term.c (term_mouse_position): Don't assume time_t wraparound.
1824
08dc5ae6
PE
1825 Be more systematic about user-interface timestamps.
1826 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1827 and sometimes 'EMACS_UINT', to represent these timestamps.
1828 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1829 This makes the code easier to follow, and makes it easier to catch
1830 integer overflow bugs such as Bug#8664.
1831 * frame.c (Fmouse_position, Fmouse_pixel_position):
1832 Use Time, not unsigned long, for user-interface timestamps.
1833 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1834 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1835 * keyboard.h (last_event_timestamp): Likewise.
1836 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1837 * menu.h (xmenu_show): Likewise.
1838 * term.c (term_mouse_position): Likewise.
1839 * termhooks.h (struct input_event.timestamp): Likewise.
1840 (struct terminal.mouse_position_hook): Likewise.
1841 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1842 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1843 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1844 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1845 what it was before.
1846 * menu.h, termhooks.h: Include "systime.h", for Time.
1847
8e55734a
PE
1848 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1849 Don't assume that the difference between two unsigned long values
1850 can fit into an integer. At this point, we know button_down_time
1851 <= event->timestamp, so the difference must be nonnegative, so
1852 there's no need to cast the result if double-click-time is
1853 nonnegative, as it should be; check that it's nonnegative, just in
1854 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1855 apart (about 25 days). (Bug#8664)
8e55734a 1856
841f1b75 1857 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1858 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1859
3e26f69c
PE
1860 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1861 that always fit in int. Use a sentinel instead of a counter, to
1862 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1863 * frame.h (struct frame): Use int for menu_bar_items_used
1864 instead of EMACS_INT, since it always fits in int.
3e26f69c 1865
5cc152c0
PE
1866 * menu.c (grow_menu_items): Check for int overflow.
1867
d89eb65e
PE
1868 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1869
5235bd3e
PE
1870 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1871 Before, the code was not consistent. These values cannot exceed
1872 2**31 - 1 so there's no need to make them unsigned.
1873 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1874 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1875 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1876 as modifiers.
1877 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1878
bc827e23
PE
1879 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1880 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1881 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1882 presumably because the widths might not match.
1883
78eb494e
PE
1884 * window.c (size_window): Avoid needless test at loop start.
1885
04f2d78b
CB
18862011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1887
1888 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1889
d2fc7e3d 18902011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1891
1892 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1893
d2fc7e3d 18942011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1895
1896 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1897 `width' to `bar_area_x' and `bar_area_width', respectively.
1898 (x_scroll_run): Take account of fringe background extension.
1899
04f2d78b
CB
1900 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1901 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1902 `bar_area_width', respectively.
1903 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1904 background extension.
1905
79b70037
GM
19062011-05-10 Jim Meyering <meyering@redhat.com>
1907
1908 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1909
2f142cc5
JB
19102011-05-10 Juanma Barranquero <lekktu@gmail.com>
1911
1912 * image.c (Finit_image_library): Return t for built-in image types,
1913 like pbm and xbm. (Bug#8640)
1914
57679c86
AS
19152011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1916
1917 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1918
888c9e86
EZ
19192011-05-07 Eli Zaretskii <eliz@gnu.org>
1920
b0512a1d
EZ
1921 * w32console.c (Fset_screen_color): Doc fix.
1922 (Fget_screen_color): New function.
1923 (syms_of_ntterm): Defsubr it.
1924
7285dc67
EZ
1925 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1926 unlink the temporary file if Fcall_process didn't create it in the
1927 first place.
1928 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1929 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1930 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1931 cue to call_process_cleanup not to close that handle.
1932
4d3fcc8e
BK
19332011-05-07 Ben Key <bkey76@gmail.com>
1934
1935 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1936 one of two shell specific rules, either bootstrap-temacs-CMD or
1937 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1938 to the previous implementation of the bootstrap-temacs rule.
1939 The bootstrap-temacs-CMD rule is similar to the previous
1940 implementation of the bootstrap-temacs rule except that it
1941 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1942 variable.
1943
1944 These changes, along with some changes to nt/configure.bat,
1945 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1946 earlier fix to add support for --cflags and --ldflags options
1947 that include quotes so that it works whether make uses cmd or
1948 sh as the shell.
1949
b4289b64
MA
19502011-05-06 Michael Albinus <michael.albinus@gmx.de>
1951
1952 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1953 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1954 is a constant.
1955 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1956 a string. Handle both cases.
1957 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1958 (Fdbus_register_method): Use Qinvalid_function.
1959
af4c0e28
JB
19602011-05-06 Juanma Barranquero <lekktu@gmail.com>
1961
1962 * makefile.w32-in: Update dependencies.
1963 (LISP_H): Add inttypes.h and stdin.h.
1964 (PROCESS_H): Add unistd.h.
1965
c51453d9
EZ
19662011-05-06 Eli Zaretskii <eliz@gnu.org>
1967
1968 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1969 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1970
8ff0ac3c 19712011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1972
4c4b566b
PE
1973 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1974
aab2b9b5
PE
1975 * term.c (vfatal): Remove stray call to va_end.
1976 It's not needed and the C Standard doesn't allow it here anyway.
1977
c378da0b
PE
1978 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1979 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1980
288b08c7
PE
1981 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1982 bytes.
1983
e3601888
PE
1984 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1985
db6c0e74
PE
1986 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1987
dd5963ea
PE
1988 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1989
88c9450f
PE
1990 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1991
2f9442b8
PE
1992 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1993
c032b5f8
PE
1994 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1995 * charset.c (Fdefine_charset_internal): Don't initialize
1996 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1997 32-bit int (Bug#8600).
a108c10b
PE
1998
1999 * lread.c (read_integer): Be more consistent with string-to-number.
2000 Use string_to_number to do the actual conversion; this avoids
2001 rounding errors and fixes some other screwups. Without this fix,
2002 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2003 (digit_to_number): Move earlier, for benefit of read_integer.
2004 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2005 not a digit in any supported base. (Bug#8602)
a108c10b 2006
ad5f9eea
PE
2007 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2008
aec1708a
PE
2009 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2010 to match comment at start of function. This also removes a
2011 GCC warning about overflow in a 32+64-bit port.
2012
47be4ab5
PE
2013 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2014
371cac43
PE
2015 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2016 Reported by Stefan Monnier in
2017 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2018 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2019 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2020
d01a7826
PE
2021 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2022 (EMACS_UINTPTR): Likewise, with uintptr_t.
2023
7fd47d5c
PE
2024 * lisp.h: Prefer 64-bit EMACS_INT if available.
2025 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2026 on 32-bit hosts that have 64-bit int, so that they can access
2027 large files.
122b0c86
PE
2028 However, temporarily disable this change unless the temporary
2029 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2030
8727937b
PE
2031 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2032
8ac068ac
PE
2033 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2034 This removes an assumption that EMACS_INT and long are the same
2035 width as pointers. The assumption is true for Emacs porting targets
2036 now, but we want to make other targets possible.
2037 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2038 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2039 In the rest of the code, change types of integers that hold casted
2040 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2041 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2042 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2043 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2044 No need to cast type when ORing.
2045 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2046 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2047 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2048 assume EMACS_INT is the same width as char *.
2049 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2050 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2051 Remove no-longer-needed casts.
2052 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2053 (xg_tool_bar_help_callback, xg_make_tool_item):
2054 Use EMACS_INTPTR to hold an integer
2055 that will be cast to void *; this can avoid a GCC warning
2056 if EMACS_INT is not the same width as void *.
2057 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2058 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2059 (current_message_1, set_message_1):
2060 Use a local to convert to proper width without a cast.
2061 * xmenu.c (dialog_selection_callback): Likewise.
2062
ede49d71
PE
2063 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2064 Also, don't assume VALBITS / RAND_BITS is less than 5,
2065 and don't rely on undefined behavior when shifting a 1 left into
2066 the sign bit.
2067 * lisp.h (get_random): Change signature to match.
2068
2f30ecd0
PE
2069 * lread.c (hash_string): Use size_t, not int, for hash computation.
2070 Normally we prefer signed values; but hashing is special, because
2071 it's better to use unsigned division on hash table sizes so that
2072 the remainder is nonnegative. Also, size_t is the natural width
2073 for hashing into memory. The previous code used 'int', which doesn't
2074 retain enough info to hash well into very large tables.
2075 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2076
2a866e7b
PE
2077 * dbusbind.c: Don't possibly lose pointer info when converting.
2078 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2079 Use XPNTR rather than XHASH, so that the high-order bits of
2080 the pointer aren't lost when converting through void *.
2081
51639eac
PE
2082 * eval.c (Fautoload): Don't double-shift a pointer.
2083
92394119
PE
2084 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2085
dbdb9a7c
JB
20862011-05-06 Juanma Barranquero <lekktu@gmail.com>
2087
2088 * gnutls.c (DEF_GNUTLS_FN):
2089 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2090
db7a0b4f
AS
20912011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2092
2093 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2094 marker. (Bug#8610)
2095
f7ff1b0f 20962011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2097
2098 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2099 New version that can reserve upto 2GB of heap space.
2100
f7ff1b0f 21012011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2102
2103 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2104
639c109b
TZ
21052011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2106
2107 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2108 `gnutls_certificate_set_x509_key_file'.
2109
d2127135
JB
21102011-05-05 Juanma Barranquero <lekktu@gmail.com>
2111
2112 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2113 Update dependencies.
2114
e968f4f3
JB
21152011-05-04 Juanma Barranquero <lekktu@gmail.com>
2116
2117 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2118 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2119 Remove unused parameter `fildes'.
2120 * process.c (read_process_output, send_process): Don't pass it.
2121
84d358f0
JB
21222011-05-04 Juanma Barranquero <lekktu@gmail.com>
2123
2124 Fix previous change: the library cache is defined in w32.c.
2125 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2126 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2127
0898ca10
JB
21282011-05-04 Juanma Barranquero <lekktu@gmail.com>
2129
2130 Implement dynamic loading of GnuTLS on Windows.
2131
2132 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2133 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2134 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2135 Declare.
2136
2137 * gnutls.c (Qgnutls_dll): Define.
2138 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2139 (gnutls_*): Declare function pointers.
2140 (init_gnutls_functions): New function to initialize function pointers.
2141 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2142 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2143 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2144 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2145 (emacs_gnutls_write, emacs_gnutls_read)
2146 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2147 (Fgnutls_available_p): New function.
2148 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2149 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2150 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2151
2152 * image.c: Include w32.h.
2153 (Vimage_type_cache): Delete.
2154 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2155 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2156 (w32_delayed_load): Move to w32.c.
2157
2158 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2159
2160 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2161 (w32_delayed_load): Move from image.c. When loading a library, record
2162 its filename in the :loaded-from property of the library id.
2163 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2164 Initialize and staticpro them.
2165 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2166
2167 * process.c: Include lisp.h before w32.h, not after.
2168 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2169 instead of gnutls_record_check_pending.
2170
2171 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2172
ff4de4aa
TZ
21732011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2174
2175 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2176 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2177 as passed in.
2178
abe95abb
JD
21792011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2180
2181 * xterm.c (x_set_frame_alpha): Do not set property on anything
2182 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2183
e16e55d4
JB
21842011-05-02 Juanma Barranquero <lekktu@gmail.com>
2185
2186 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2187
bafcf6a5
JB
21882011-05-02 Juanma Barranquero <lekktu@gmail.com>
2189
2190 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2191 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2192 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2193 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2194 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2195 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2196 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2197 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2198 (Qgnutls_bootprop_callbacks_verify): Make static.
2199
e7a6747f
AS
22002011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2201
19ed11ba
AS
2202 * callproc.c: Indentation fixup.
2203
e7a6747f 2204 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2205 (wait_for_termination, interruptible_wait_for_termination):
2206 Move after wait_for_termination_1.
e7a6747f 2207
1ef14cb4
LMI
22082011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2209
2210 * sysdep.c (interruptible_wait_for_termination): New function
2211 which is like wait_for_termination, but allows keyboard
2212 interruptions.
2213
2214 * callproc.c (Fcall_process): Add (:file "file") as an option for
2215 the STDOUT buffer.
2216 (Fcall_process_region): Ditto.
2217
330d880c
EZ
22182011-04-30 Eli Zaretskii <eliz@gnu.org>
2219
8db90b73
EZ
2220 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2221 rather than `XVECTOR (FOO)->size'.
2222
330d880c
EZ
2223 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2224 inttypes.h, as a gnulib replacement is used if it not available in
2225 system headers.
2226
15cbd324
EZ
22272011-04-21 Eli Zaretskii <eliz@gnu.org>
2228
2229 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2230 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2231 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2232
2233 * coding.c (coding_alloc_by_realloc): Error out if destination
2234 will grow beyond MOST_POSITIVE_FIXNUM.
2235 (decode_coding_emacs_mule): Abort if there isn't enough place in
2236 charbuf for the composition carryover bytes. Reserve an extra
2237 space for up to 2 characters produced in a loop.
2238 (decode_coding_iso_2022): Abort if there isn't enough place in
2239 charbuf for the composition carryover bytes.
2240
22412011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2242
ae940cca
EZ
2243 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2244 aborting when %lld or %lll format is passed.
2245 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2246 %llo or %llx format is passed. (Bug#8545)
2247
03ab8921
EZ
2248 * window.c (window_scroll_line_based): Use a marker instead of
2249 simple variables to record original value of point. (Bug#7952)
2250
afda1437
EZ
2251 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2252 produced by %s or %c overflows available buffer space. (Bug#8545)
2253
f76dee0c
PE
22542011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2257 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2258
fdc5744d
JB
22592011-04-28 Juanma Barranquero <lekktu@gmail.com>
2260
2261 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2262
638f053a
JB
22632011-04-28 Juanma Barranquero <lekktu@gmail.com>
2264
2265 * keyboard.c (Qdelayed_warnings_hook): Define.
2266 (command_loop_1): Run `delayed-warnings-hook'
2267 if Vdelayed_warnings_list is non-nil.
2268 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2269 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2270
d178f871
EZ
22712011-04-28 Eli Zaretskii <eliz@gnu.org>
2272
2273 * doprnt.c (doprnt): Don't return value smaller than the buffer
2274 size if the message was truncated. (Bug#8545).
2275
b124fd93
JB
22762011-04-28 Juanma Barranquero <lekktu@gmail.com>
2277
2278 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2279 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2280
e810457d
PE
22812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2284
ea51cceb
JB
22852011-04-27 Juanma Barranquero <lekktu@gmail.com>
2286
2287 * makefile.w32-in: Update dependencies.
2288
94dcfacf
EZ
22892011-04-27 Eli Zaretskii <eliz@gnu.org>
2290
2291 Improve `doprnt' and its usage. (Bug#8545)
2292 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2293 `format_end'. Remove support for %l as a conversion specifier.
2294 Don't use xrealloc. Improve diagnostics when the %l size modifier
2295 is used. Update the commentary.
2296
2297 * eval.c (verror): Simplify calculation of size_t.
2298
2299 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2300 messages.
2301
f61f41d7
PE
23022011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2303
2304 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2305 change.
2306
96fb4434
PE
23072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2310 This makes this file independent of the recent pseudovector change.
2311
671875da 23122011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2313
69e9b5a3
PE
2314 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2315
b5f869a7 2316 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2317 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2318 Remove unused local.
c8926152 2319 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2320
841a1577 2321 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2322 GCC 4.6.0 optimizes based on type-based alias analysis.
2323 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2324 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2325 != &v->size, and therefore "v->size = 1; b->size = 2; return
2326 v->size;" must therefore return 1. This assumption is incorrect
2327 for Emacs, since it type-puns struct Lisp_Vector * with many other
2328 types. To fix this problem, this patch adds a new type struct
f904488f 2329 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2330 and pseudovectors, and helps optimizing compilers not get fooled
2331 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2332 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2333 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2334 the size member.
eab3844f
PE
2335 (XSETPVECTYPE): Rewrite in terms of new macro.
2336 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2337 This is a bit clearer, and further avoids the possibility of
2338 undesirable aliasing.
2339 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2340 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2341 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2342 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2343 (ASIZE): Now uses header.size rather than size.
2344 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2345 to avoid the hassle of writing XVECTOR (foo)->header.size.
2346 (struct vectorlike_header): New type.
eab3844f
PE
2347 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2348 object, to help avoid aliasing.
2349 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2350 (SUBRP): Likewise, since Lisp_Subr is a special case.
2351 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2352 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2353 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2354 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2355 changed to be "header.size" and "header.next".
2356 * buffer.h (struct buffer): Likewise.
2357 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2358 * frame.h (struct frame): Likewise.
2359 * process.h (struct Lisp_Process): Likewise.
2360 * termhooks.h (struct terminal): Likewise.
2361 * window.c (struct save_window_data, struct saved_window): Likewise.
2362 * window.h (struct window): Likewise.
2363 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2364 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2365 * buffer.c (init_buffer_once): Likewise.
2366 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2367 special case.
2368 * process.c (Fformat_network_address): Use local var for size,
2369 for brevity.
2370
0df1eac5
PE
2371 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2372
847ab9d1 2373 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2374 * data.c (atof): Remove decl; no longer used or needed.
2375 (digit_to_number): Move to lread.c.
2376 (Fstring_to_number): Use new string_to_number function, to be
2377 consistent with how the Lisp reader treats infinities and NaNs.
2378 Do not assume that floating-point numbers represent EMACS_INT
2379 without losing information; this is not true on most 64-bit hosts.
2380 Avoid double-rounding errors, by insisting on integers when
2381 parsing non-base-10 numbers, as the documentation specifies.
2382 * lisp.h (string_to_number): New decl, replacing ...
2383 (isfloat_string): Remove.
bc0a5c13 2384 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2385 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2386 appears to have been a coding error. Similarly, do not accept
2387 strings like +-1e0 as floating point numbers. Do not report
2388 overflow for integer overflows unless the base is not 10 which
2389 means we have no simple and reliable way to continue.
2390 Break out the floating-point parsing into a new
2391 function string_to_number, so that Fstring_to_number parses
2392 floating point numbers consistently with the Lisp reader.
04f2d78b 2393 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2394 (E_CHAR, EXP_INT): Remove, replacing with ...
2395 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2396 (string_to_number): New function, replacing isfloat_string.
2397 This function checks for valid syntax and produces the resulting
2398 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2399 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2400 so that overflow for non-base-10 numbers is reported only when
2401 there's no portable and simple way to convert to floating point.
452f4150 2402
67769ffc
PE
2403 * textprop.c (set_text_properties_1): Rewrite for clarity,
2404 and to avoid GCC warning about integer overflow.
2405
c20db43f
PE
2406 * intervals.h (struct interval): Use EMACS_INT for members
2407 where EMACS_UINT might cause problems. See
2408 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2409 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2410 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2411 All uses changed.
37aa2f85
PE
2412 (offset_intervals): Tell GCC not to worry about length overflow
2413 when negating a negative length.
c20db43f 2414
2538aa2f
PE
2415 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2416 (overrun_check_free): Likewise.
2417
f2d3008d
PE
2418 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2419 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2420 word size.
2421
ec8df744
PE
2422 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2423 (gnutls_make_error): Rename local to avoid shadowing.
2424 (gnutls_emacs_global_deinit): ifdef out; not used.
2425 (Fgnutls_boot): Use const for pointer to readonly storage.
2426 Comment out unused local. Fix pointer signedness problems.
2427
640ee02d
PE
2428 * lread.c (openp): Don't stuff size_t into an 'int'.
2429 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2430 about possible signed overflow.
2431
6048fb2a
PE
2432 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2433 (GDK_KEY_g): Don't define if already defined.
2434 (xg_prepare_tooltip): Avoid pointer signedness problem.
2435 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2436
fa3c87e1
PE
2437 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2438 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2439
2172544b
PE
2440 * xfns.c (Fx_window_property): Simplify a bit,
2441 to make a bit faster and to avoid GCC 4.6.0 warning.
2442 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2443
9b821a21
PE
2444 * fns.c (internal_equal): Don't assume size_t fits in int.
2445
3c616cfa
PE
2446 * alloc.c (compact_small_strings): Tighten assertion a little.
2447
c2982e87
PE
2448 Replace pEd with more-general pI, and fix some printf arg casts.
2449 * lisp.h (pI): New macro, generalizing old pEd macro to other
2450 conversion specifiers. For example, use "...%"pI"d..." rather
2451 than "...%"pEd"...".
2452 (pEd): Remove. All uses replaced with similar uses of pI.
2453 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2454 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2455 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2456 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2457 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2458 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2459 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2460 64-bit hosts.
2461 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2462 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2463 * print.c (safe_debug_print, print_object): Likewise.
2464 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2465 to int.
6f04d126
PE
2466 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2467 avoiding the 0 flag, which is not portable.
c2982e87
PE
2468 * process.c (Fmake_network_process): Use pI to avoid cast.
2469 * region-cache.c (pp_cache): Likewise.
2470 * xdisp.c (decode_mode_spec): Likewise.
2471 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2472 behavior on 64-bit hosts with printf arg.
6f04d126 2473 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2474 (x_stop_queuing_selection_requests): Likewise.
2475 (x_get_window_property): Don't truncate byte count to an 'int'
2476 when tracing.
0b432f21 2477
5e073ec7
PE
2478 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2479 here, since it parses constructs like leading '-' and spaces,
2480 which are not wanted; and it overflows with large numbers.
2481 Instead, simply match F[0-9]+, which is what is wanted anyway.
2482
36372bf9
PE
2483 * alloc.c: Remove unportable assumptions about struct layout.
2484 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2485 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2486 (allocate_vectorlike, make_pure_vector): Use the new macros,
2487 plus offsetof, to remove unportable assumptions about struct layout.
2488 These assumptions hold on all porting targets that I know of, but
2489 they are not guaranteed, they're easy to remove, and removing them
2490 makes further changes easier.
2491
0b432f21
PE
2492 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2493 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2494 (string_overrun_cookie): Now const. Use initializers that
2495 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2496 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2497 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2498 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2499 multiple of sizeof (EMACS_INT); it need not be, if
2500 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2501 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2502
895009e1
JB
25032011-04-26 Juanma Barranquero <lekktu@gmail.com>
2504
2505 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2506
6a7a1b0b
TZ
25072011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2508
2509 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2510 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2511 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2512
841a1577 25132011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2514
2515 * lisp.h (Qdebug): List symbol.
895009e1 2516 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2517 * keyboard.c (debug-on-event): New variable.
2518 (handle_user_signal): Break into debugger when debug-on-event
2519 matches the current signal symbol.
2520
f2d3ba6f
DN
25212011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2522
2523 * alloc.c (check_sblock, check_string_bytes)
2524 (check_string_free_list): Convert to standard C.
2525
42ce4c63
TZ
25262011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2527
2528 * w32.c (emacs_gnutls_push): Fix typo.
2529
825cd63c
EZ
25302011-04-25 Eli Zaretskii <eliz@gnu.org>
2531
fb11d64d
EZ
2532 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2533 "cast to pointer from integer of different size".
2534
825cd63c
EZ
2535 Improve doprnt and its use in verror. (Bug#8545)
2536 * doprnt.c (doprnt): Document the set of format control sequences
2537 supported by the function. Use SAFE_ALLOCA instead of always
2538 using `alloca'.
2539
2540 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2541 is one byte too soon. Don't use xrealloc; instead xfree and
2542 xmalloc anew.
2543
e061a11b
TZ
25442011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2545
2546 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2547 callbacks stage.
2548
2549 * gnutls.c: Renamed global_initialized to
2550 gnutls_global_initialized. Added internals for the
2551 :verify-hostname-error, :verify-error, and :verify-flags
2552 parameters of `gnutls-boot' and documented those parameters in the
2553 docstring. Start callback support.
2554 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2555 unless a fatal error occured. Call gnutls_alert_send_appropriate
2556 on error. Return error code.
2557 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2558 (emacs_gnutls_read): Likewise.
2559 (Fgnutls_boot): Return handshake error code.
2560 (emacs_gnutls_handle_error): New function.
2561 (wsaerror_to_errno): Likewise.
2562
2563 * w32.h (emacs_gnutls_pull): Add prototype.
2564 (emacs_gnutls_push): Likewise.
2565
2566 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2567 (emacs_gnutls_push): Likewise.
2568
25692011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2570
2571 * process.c (wait_reading_process_output): Check if GnuTLS
2572 buffered some data internally if no FDs are set for TLS
2573 connections.
2574
2575 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2576 (LIBS): Link to USER_LIBS.
2577 ($(BLD)/gnutls.$(0)): New target.
2578
fa6996bc
EZ
25792011-04-24 Eli Zaretskii <eliz@gnu.org>
2580
eb35682e
EZ
2581 * xdisp.c (handle_single_display_spec): Rename the
2582 display_replaced_before_p argument into display_replaced_p, to
2583 make it consistent with the commentary. Fix typos in the
2584 commentary.
2585
e2ad650c
EZ
2586 * textprop.c (syms_of_textprop): Remove dead code.
2587 (copy_text_properties): Delete obsolete commentary about an
2588 interface that was deleted long ago. Fix typos in the description
2589 of arguments.
2590
1b2de274
EZ
2591 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2592 to changes in oldXMenu/XMenu.h from 2011-04-16.
2593 <menu_help_message, prev_menu_help_message>: Constify.
2594 (IT_menu_make_room): menu->help_text is now `const char **';
2595 adjust.
2596
2597 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2598 to changes in oldXMenu/XMenu.h from 2011-04-16.
2599 (struct XMenu): Declare `help_text' `const char **'.
2600
2601 * xfaces.c <Qunspecified>: Make extern again.
2602
2603 * syntax.c: Include sys/types.h before including regex.h, as
2604 required by Posix.
2605
762b15be
EZ
2606 * doc.c (get_doc_string): Improve the format passed to `error'.
2607
2608 * doprnt.c (doprnt): Improve commentary.
2609
2610 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2611
2612 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2613 them with etags.
2614
f1052e5d
EZ
2615 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2616 changes in globals.h immediately force recompilation.
762b15be
EZ
2617 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2618 $(CURDIR)/s/ms-w32.h.
2619 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2620
fa6996bc
EZ
2621 * character.c (Fchar_direction): Function deleted.
2622 (syms_of_character): Don't defsubr it.
2623 <char-direction-table>: Deleted.
2624
e6c3da20
EZ
26252011-04-23 Eli Zaretskii <eliz@gnu.org>
2626
2627 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2628 * doprnt.c: Include limits.h.
2629 (SIZE_MAX): New macro.
04f2d78b
CB
2630 (doprnt): Return a size_t value. 2nd arg is now size_t.
2631 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2632 Improve overflow protection. Support `l' modifier for integer
2633 conversions. Support %l conversion. Don't assume an EMACS_INT
2634 argument for integer conversions and for %c.
2635
2636 * lisp.h (doprnt): Restore prototype.
2637
2638 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2639 $(SRC)/character.h.
2640
2641 * Makefile.in (base_obj): Add back doprnt.o.
2642
2643 * deps.mk (doprnt.o): Add back prerequisites.
2644 (callint.o): Depend on character.h.
2645
2646 * eval.c (internal_lisp_condition_case): Include the handler
2647 representation in the error message.
2648 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2649 when breaking from the loop.
2650
2651 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2652
2653 * callint.c (Fcall_interactively): When displaying error message
2654 about invalid control letter, pass the character's codepoint, not
2655 a pointer to its multibyte form. Improve display of the character
2656 in octal and display also its hex code.
2657
2658 * character.c (char_string): Use %x to display the (unsigned)
2659 codepoint of an invalid character, to avoid displaying a bogus
2660 negative value.
2661
2662 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2663 `error', not SYMBOL_NAME itself.
2664
2665 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2666 character arguments to `error'.
2667
2668 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2669 to `error' in error message about FINAL_CHAR argument. Make sure
2670 FINAL_CHAR is a character, and use %c when it is passed as
2671 argument to `error'.
2672
4ffd0d6b 26732011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2674
2675 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2676
2677 * w32.c: Include <time.h>.
2678 (sys_localtime): New function.
2679
4ffd0d6b 26802011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2681
2682 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2683
4ffd0d6b 2684 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2685
4ffd0d6b 26862011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2687
4ffd0d6b
GM
2688 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2689 zombies (Bug#8467).
aac0c6e3 2690
04c56954
EZ
26912011-04-19 Eli Zaretskii <eliz@gnu.org>
2692
2693 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2694 gl_state.e_property when gl_state.object is Qt.
2695
2696 * insdel.c (make_gap_larger): Remove limitation of buffer size
2697 to <= INT_MAX.
2698
16a43933
CY
26992011-04-18 Chong Yidong <cyd@stupidchicken.com>
2700
2701 * xdisp.c (lookup_glyphless_char_display)
2702 (produce_glyphless_glyph): Handle cons cell entry in
2703 glyphless-char-display.
2704 (Vglyphless_char_display): Document it.
2705
2706 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2707 glyphless-char-display.
2708
4581706e
CY
27092011-04-17 Chong Yidong <cyd@stupidchicken.com>
2710
2711 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2712
2713 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2714
2715 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2716 definition for no-X builds.
2717
4887c6e2 27182011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2719
fd35b6f9
PE
2720 Static checks with GCC 4.6.0 and non-default toolkits.
2721
5c1ccb01
PE
2722 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2723
006c5daa
PE
2724 * process.c (keyboard_bit_set): Define only if SIGIO.
2725 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2726 (send_process): Repair possible setjmp clobbering.
2727
efc736d3
PE
2728 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2729
4e2fe2e6
PE
2730 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2731
f97334a2
PE
2732 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2733
4e75f29d
PE
2734 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2735 Define only if needed.
2736
90efadd1
PE
2737 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2738 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2739 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2740
3c647824
PE
2741 * dispextern.h (struct redisplay_interface): Rename param
2742 to avoid shadowing.
e264f262 2743 * termhooks.h (struct terminal): Likewise.
761383f4 2744 * xterm.c (xembed_send_message): Likewise.
3c647824 2745
b58c5c4a
PE
2746 * insdel.c (make_gap_smaller): Define only if
2747 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2748
cad59032
PE
2749 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2750 it.
2751
c339dc2e
PE
2752 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2753 so that we aren't warned about unused symbols.
2754
91a3e27b
PE
2755 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2756
399c71d3 2757 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2758
8ffc96f5
PE
2759 * xfns.c (x_real_positions): Mark locals as initialized.
2760
eef9bc79
PE
2761 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2762
098db9dd
PE
2763 * xterm.c: Fix problems found by static analysis with other toolkits.
2764 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2765 (x_dispatch_event): Declare static if USE_GTK, and
2766 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2767 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2768 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2769 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2770 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2771
eb18f6cc
PE
2772 * xmenu.c (menu_help_callback): Pointer type fixes.
2773 Use const pointers when pointing at readonly data. Avoid pointer
2774 signedness clashes.
2775 (FALSE): Remove unused macro.
2776 (update_frame_menubar): Remove unused decl.
2777
1fe72bf8
PE
2778 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2779
60d9e1db
PE
2780 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2781 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2782 (single_menu_item): Rename local to avoid shadowing.
2783
39261c26
PE
2784 * keyboard.c (make_lispy_event): Remove unused local var.
2785
018c5e19
PE
2786 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2787 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2788
63d2b86e
PE
2789 * bitmaps: Change bitmaps from unsigned char back to the X11
2790 compatible char. Avoid the old compiler warnings about
2791 out-of-range initializers by using, for example, '\xab' rather
2792 than 0xab.
2793
aefd87e1
PE
2794 * xgselect.c (xgselect_initialize): Check vs interface
2795 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2796
bf501fb9
PE
2797 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2798
e9829fdf
PE
2799 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2800 to read-only memory.
2801
1086c095
PE
2802 * fns.c (vector): Remove; this old hack is no longer needed.
2803
2baccd04 2804 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2805 Remove unused var.
dde42981 2806 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2807
72391843 2808 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2809
436c16df 2810 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2811 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2812 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2813
92bb796d 2814 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2815 (x_term_init): Remove local to avoid shadowing.
92bb796d 2816
764430a3 2817 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2818
2819 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2820 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2821
d1dfb56c
EZ
28222011-04-16 Eli Zaretskii <eliz@gnu.org>
2823
c4354cb4
EZ
2824 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2825
d1dfb56c
EZ
2826 Fix regex.c, syntax.c and friends for buffers > 2GB.
2827 * syntax.h (struct gl_state_s): Declare character position members
2828 EMACS_INT.
2829
2830 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2831
04f2d78b
CB
2832 * textprop.c (verify_interval_modification, interval_of):
2833 Declare arguments EMACS_INT.
d1dfb56c
EZ
2834
2835 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2836 EMACS_INT.
2837
2838 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2839
2840 * indent.c (Fvertical_motion): Local variable it_start is now
2841 EMACS_INT.
2842
2843 * regex.c (re_match, re_match_2, re_match_2_internal)
2844 (bcmp_translate, regcomp, regexec, print_double_string)
2845 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2846 (re_compile_pattern, re_exec): Declare arguments and local
2847 variables `size_t' and `ssize_t' and return values `regoff_t', as
2848 appropriate.
2849 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2850 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2851 <compile_stack_type>: `size' and `avail' are now `size_t'.
2852
2853 * regex.h <regoff_t>: Use ssize_t, not int.
2854 (re_search, re_search_2, re_match, re_match_2): Arguments that
2855 specify buffer/string position and length are now ssize_t and
2856 size_t. Return type is regoff_t.
2857
613052cd
BK
28582011-04-16 Ben Key <bkey76@gmail.com>
2859
2860 * nsfont.m: Fixed bugs in ns_get_family and
2861 ns_descriptor_to_entity that were caused by using free to
2862 deallocate memory blocks that were allocated by xmalloc (via
2863 xstrdup). This caused Emacs to crash when compiled with
2864 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2865 --enable-checking=xmallocoverrun). xfree is now used to
2866 deallocate these memory blocks.
2867
4170f62f 28682011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2869
71b41406
PE
2870 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2871
9587a89d
PE
2872 emacs_write: Accept and return EMACS_INT for sizes.
2873 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2874 et seq.
2875 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2876 Accept and return EMACS_INT.
2877 (emacs_gnutls_write): Return the number of bytes written on
2878 partial writes.
2879 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2880 (emacs_read, emacs_write): Remove check for negative size, as the
2881 Emacs source code has been audited now.
9587a89d
PE
2882 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2883 (emacs_read, emacs_write): Use it.
273a5f82
PE
2884 * process.c (send_process): Adjust to the new signatures of
2885 emacs_write and emacs_gnutls_write. Do not attempt to store
2886 a byte offset into an 'int'; it might overflow.
9587a89d 2887 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2888
3e047f51
PE
2889 * sound.c: Don't assume sizes fit in 'int'.
2890 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2891 Return EMACS_INT, not int.
3e047f51 2892 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2893 Accept EMACS_INT, not int.
2894 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2895 record read return values.
2896
cc39a9db
BK
28972011-04-15 Ben Key <bkey76@gmail.com>
2898
c9d0ec6d
JB
2899 * keyboard.c (Qundefined): Don't declare static since it is used
2900 in nsfns.m.
2901 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2902 static since they are used in nsfont.m.
cc39a9db 2903
6c60eb9f
SM
29042011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2905
2906 * process.c (Qprocessp): Don't declare static.
2907 * lisp.h (Qprocessp): Declare again.
2908
7990b61a
JB
29092011-04-15 Juanma Barranquero <lekktu@gmail.com>
2910
2911 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2912
5d4cb038
PE
29132011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2914
8bd7b830 2915 Improve C-level modularity by making more things 'static'.
cd64ea1d 2916
e3b27b31
PE
2917 Don't publish debugger-only interfaces to other modules.
2918 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2919 (verify_bytepos, count_markers): Move decls to the only modules
2920 that need them.
2921 * region-cache.h (pp_cache): Likewise.
2922 * window.h (check_all_windows): Likewise.
2923 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2924
5d4cb038
PE
2925 * sysdep.c (croak): Now static, if
2926 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2927 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2928
2929 * alloc.c (refill_memory_reserve): Now static if
2930 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2931 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2932
e87b6180
PE
2933 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2934 Define only if USE_LUCID.
2935
ac64929e
PE
2936 * xrdb.c (x_customization_string, x_rm_string): Now static.
2937
6f37259d
PE
2938 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2939 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2940
1683e3ab
PE
2941 * xdisp.c (draw_row_with_mouse_face): Now static.
2942 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2943
de9c2632
PE
2944 * window.h (check_all_windows): Mark externally visible.
2945
2b96acb7
PE
2946 * window.c (window_deletion_count): Now static.
2947
2948 * undo.c: Make symbols static if they're not exported.
2949 (last_undo_buffer, last_boundary_position, pending_boundary):
2950 Now static.
2951
50436f33
PE
2952 * textprop.c (interval_insert_behind_hooks): Now static.
2953 (interval_insert_in_front_hooks): Likewise.
2954
64520e5c
PE
2955 * term.c: Make symbols static if they're not exported.
2956 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2957 (max_frame_lines, tty_set_terminal_modes):
2958 (tty_reset_terminal_modes, tty_turn_off_highlight):
2959 (get_tty_terminal): Now static.
2960 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2961 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2962 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2963 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2964 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2965
1fa53021
PE
2966 * sysdep.c: Make symbols static if they're not exported.
2967 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2968 Now static.
2969 (sigprocmask_set, full_mask): Remove; unused.
2970 (wait_debugging): Mark as visible.
2971 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2972 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2973
d4b43b22
PE
2974 * syntax.c (syntax_temp): Define only if !__GNUC__.
2975
b7c513d0
PE
2976 * sound.c (current_sound_device, current_sound): Now static.
2977
989b29ad
PE
2978 * search.c (searchbufs, searchbuf_head): Now static.
2979
13a55a78
PE
2980 * scroll.c (scroll_cost): Remove; unused.
2981 * dispextern.h (scroll_cost): Remove decl.
2982
de68a1fc
PE
2983 * region-cache.h (pp_cache): Mark as externally visible.
2984
40ccffa6
PE
2985 * process.c: Make symbols static if they're not exported.
2986 (process_tick, update_tick, create_process, chan_process):
2987 (Vprocess_alist, proc_buffered_char, datagram_access):
2988 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2989 (deactivate_process): Mark defn as static, as well as decl.
2990 * lisp.h (create_process): Remove decl.
2991 * process.h (chan_process, Vprocess_alist): Remove decls.
2992
ad64fc97
PE
2993 * print.c: Make symbols static if they're not exported.
2994 (print_depth, new_backquote_output, being_printed, print_buffer):
2995 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2996 (print_interval, print_number_index, initial_stderr_stream):
2997 Now static.
2998 * lisp.h (Fprinc): Remove decl.
2999 (debug_output_compilation_hack): Mark as externally visible.
3000
adddb265
PE
3001 * sysdep.c (croak): Move decl from here to syssignal.h.
3002 * syssignal.h (croak): Put it here, so the API can be checked when
3003 'croak' is called from dissociate_if_controlling_tty.
3004
1717ede2
PE
3005 * minibuf.c: Make symbols static if they're not exported.
3006 (minibuf_save_list, choose_minibuf_frame): Now static.
3007 * lisp.h (choose_minibuf_frame): Remove decl.
3008
fa5fb2bc
PE
3009 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3010
1e3890d1
PE
3011 * lread.c: Make symbols static if they're not exported.
3012 (read_objects, initial_obarray, oblookup_last_bucket_number):
3013 Now static.
3014 (make_symbol): Remove; unused.
3015 * lisp.h (initial_obarray, make_symbol): Remove decls.
3016
8a1414fa
PE
3017 * keyboard.c: Make symbols static if they're not exported.
3018 (single_kboard, recent_keys_index, total_keys, recent_keys):
3019 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3020 (this_single_command_key_start, echoing, last_auto_save):
3021 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3022 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3023 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3024 (Vlispy_mouse_stem, double_click_count):
3025 Now static.
3026 (force_auto_save_soon): Define only if SIGDANGER.
3027 (ignore_mouse_drag_p): Now static if
3028 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3029 (print_help): Remove; unused.
3030 (stop_character, last_timer_event): Mark as externally visible.
3031 * keyboard.h (ignore_mouse_drag_p): Declare only if
3032 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3033 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3034 * lisp.h (echoing): Remove decl.
3035 (force_auto_save_soon): Declare only if SIGDANGER.
3036 * xdisp.c (redisplay_window): Simplify code, to make it more
3037 obvious that ignore_mouse_drag_p is not accessed if !defined
3038 USE_GTK && !defined HAVE_NS.
3039
93ea6e8f
PE
3040 * intervals.c: Make symbols static if they're not exported.
3041 (merge_properties_sticky, merge_interval_right, delete_interval):
3042 Now static.
3043 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3044
77382fcc
PE
3045 * insdel.c: Make symbols static if they're not exported.
3046 However, leave prepare_to_modify_buffer alone. It's never
3047 called from outside this function, but that appears to be a bug.
3048 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3049 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3050 (adjust_after_replace_noundo): Remove; unused.
3051 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3052 (signal_before_change): Remove decls.
77382fcc 3053
9306c32e
PE
3054 * indent.c (val_compute_motion, val_vmotion): Now static.
3055
cd44d2eb
PE
3056 * image.c: Make symbols static if they're not exported.
3057 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3058 if USE_GTK.
3059 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3060 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3061
ad9a7a06
PE
3062 * fringe.c (standard_bitmaps): Now static.
3063 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3064
81626931
PE
3065 * frame.c: Make symbols static if they're not exported.
3066 (x_report_frame_params, make_terminal_frame): Now static.
3067 (get_frame_param): Now static, unless HAVE_NS.
3068 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3069 (x_get_resource_string): Remove; not used.
3070 * frame.h (make_terminal_frame, x_report_frame_params):
3071 (x_get_resource_string); Remove decls.
3072 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3073 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3074
239f9db9
PE
3075 * font.c, fontset.c: Make symbols static if they're not exported.
3076 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3077 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3078 * font.c (font_close_object): Now static.
3079 * font.h (font_close_object): Remove.
3080 * fontset.c (FONTSET_OBJLIST): Remove.
3081 (free_realized_fontset) #if-0 the body, which does nothing.
3082 (face_suitable_for_char_p): #if-0, as it's never called.
3083 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3084 * xfaces.c (face_at_string_position):
3085 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3086 since 0 is always ASCII.
3087
dfcf3579
PE
3088 * fns.c (weak_hash_tables): Now static.
3089
5045092b
PE
3090 * fileio.c: Make symbols static if they're not exported.
3091 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3092 (Vwrite_region_annotation_buffers): Now static.
3093
57a96f5c
PE
3094 * eval.c: Make symbols static if they're not exported.
3095 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3096 * lisp.h (backtrace_list): Remove decl.
3097
35f08c38
PE
3098 * emacs.c: Make symbols static if they're not exported.
3099 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3100 (fatal_error_code, fatal_error_signal_hook, standard_args):
3101 Now static.
3102 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3103 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3104 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3105 * lisp.h (fatal_error_signal_hook): Remove decl.
3106 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3107
f44bd759
PE
3108 * editfns.c: Move a (normally-unused) function to its only use.
3109 * editfns.c, lisp.h (get_operating_system_release): Remove.
3110 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3111 worth the hassle of breaking this out.
3112
b532497d
PE
3113 * xterm.c: Make symbols static if they're not exported.
3114 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3115 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3116 (x_destroy_window, x_delete_display):
3117 Now static.
3118 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3119 (x_mouse_leave): Remove; unused.
3120 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3121 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3122 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3123 Remove decls.
3124 (x_mouse_leave): Declare only if WINDOWSNT.
3125 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3126 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3127 USE_X_TOOLKIT.
3128
1675728f
PE
3129 * ftxfont.c: Make symbols static if they're not exported.
3130 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3131 HAVE_FREETYPE.
3132 * font.h (ftxfont_driver): Likewise.
3133
e4cebfca
PE
3134 * xfns.c: Make symbols static if they're not exported.
3135 (x_last_font_name, x_display_info_for_name):
3136 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3137 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3138 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3139 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3140 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3141 (last_show_tip_args): Now static.
3142 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3143 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3144 (x_screen_planes): Remove; unused.
3145 * dispextern.h (x_screen_planes): Remove decl.
3146
5bf46f05
PE
3147 * dispnew.c: Make symbols static if they're not exported.
3148 * dispextern.h (redraw_garbaged_frames, scrolling):
3149 (increment_row_positions): Remove.
3150 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3151 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3152 Now static.
3153 (redraw_garbaged_frames): Remove; unused.
3154
435f4c28
PE
3155 * xfaces.c: Make symbols static if they're not exported.
3156 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3157 Remove decls.
3158 * xterm.h (defined_color): Remove decls.
3159 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3160 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3161 (menu_face_changed_default, defined_color, free_realized_face):
3162 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3163 (ascii_face_of_lisp_face): Remove; unused.
3164
8524aef3
PE
3165 * xdisp.c: Make symbols static if they're not exported.
3166 * dispextern.h (scratch_glyph_row, window_box_edges):
3167 (glyph_to_pixel_coords, set_cursor_from_row):
3168 (get_next_display_element, set_iterator_to_next):
3169 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3170 (show_mouse_face): Remove decls
3171 * frame.h (message_buf_print): Likewise.
3172 * lisp.h (pop_message, set_message, check_point_in_composition):
3173 Likewise.
3174 * xterm.h (set_vertical_scroll_bar): Likewise.
3175 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3176 (message_buf_print, scratch_glyph_row, displayed_buffer):
3177 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3178 (get_next_display_element, show_mouse_face, window_box_edges):
3179 (frame_to_window_pixel_xy, check_point_in_composition):
3180 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3181 (glyph_to_pixel_coords): Remove; unused.
3182
16390cd2
PE
3183 * dired.c (file_name_completion): Now static.
3184
3185 * dbusbind.c (xd_in_read_queued_messages): Now static.
3186
a25f4dfa
PE
3187 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3188 * data.c (circular_list_error): Remove.
3189
14a9c8df
PE
3190 * commands.h (last_point_position, last_point_position_buffer):
3191 (last_point_position_window): Remove decls.
3192 * keyboard.c: Make these variables static.
3193
04f2d78b
CB
3194 * coding.h (coding, code_convert_region, encode_coding_gap):
3195 Remove decls.
74ab6df5
PE
3196 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3197 (iso_code_class, detect_coding, code_convert_region): Now static.
3198 (encode_coding_gap): Remove; unused.
3199
38dfbee1
PE
3200 * chartab.c (chartab_chars, chartab_bits): Now static.
3201
a2cb4e63
PE
3202 * charset.h (charset_iso_8859_1): Remove decl.
3203 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3204 Now static.
3205
127198fd
PE
3206 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3207 * ccl.c (Vccl_program_table): Now static.
3208 (check_ccl_update): Remove; unused.
3209
d85b608f
PE
3210 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3211 * category.h: ... from here.
3212 * category.c (check_category_table, set_category_set): Now static.
3213
31cd66f3
PE
3214 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3215 * lisp.h: Remove these decls.
3216
c358e587
PE
3217 * buffer.c (buffer_count): Remove unused var.
3218
e78aecca
PE
3219 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3220 so that it's not optimized away.
3221 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3222 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3223 exported only to the debugger.
3224
e192d7d3 3225 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3226 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3227
92470028
PE
3228 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3229 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3230 was inaccessible from Lisp.
3231 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3232 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3233
244ed907
PE
3234 alloc.c: Import and export fewer symbols, and remove unused items.
3235 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3236 is defined.
3237 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3238 it's not optimized away by whole-program optimization.
3239 (message_enable_multibyte, free_misc): Remove.
3240 (catchlist, handlerlist, mark_backtrace):
3241 Declare only if BYTE_MARK_STACK.
3242 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3243 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3244 (message_enable_multibyte): Remove decl.
3245 (free_misc, interval_free_list, float_block, float_block_index):
3246 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3247 (cons_free_list, last_marked_index):
3248 Now static.
3249 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3250 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3251 (mark_backtrace): Define only if BYTE_MARK_STACK.
3252 * xdisp.c (message_enable_multibyte): Now static.
3253
61c2b50e 3254 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3255 This makes it easier for human readers (and static analyzers)
3256 to see whether these variables are used from other modules.
3257 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3258 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3259 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3260 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3261 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3262 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3263 * xmenu.c, xselect.c:
3264 Declare Q* vars static if they are not used in other modules.
3265 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3266 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3267 Remove decls of unexported vars.
3268 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3269
95c82688
PE
3270 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3271
16a97296
PE
3272 Make Emacs functions such as Fatom 'static' by default.
3273 This makes it easier for human readers (and static analyzers)
3274 to see whether these functions can be called from other modules.
3275 DEFUN now defines a static function. To make the function external
3276 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3277 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3278 (Finit_image_library):
16a97296
PE
3279 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3280 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3281 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3282 Remove decls, since these functions are now static.
3283 (Funintern, Fget_internal_run_time): New decls, since these functions
3284 were already external.
95c82688 3285
16a97296
PE
3286 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3287 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3288 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3289 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3290 * keyboard.c, keymap.c, lread.c:
3291 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3292 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3293 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3294 Mark functions with DEFUE instead of DEFUN,
3295 if they are used in other modules.
3296 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3297 decls for now-static functions.
3298 * buffer.h (Fdelete_overlay): Remove decl.
3299 * callproc.c (Fgetenv_internal): Mark as internal.
3300 * composite.c (Fremove_list_of_text_properties): Remove decl.
3301 (Fcomposition_get_gstring): New forward static decl.
3302 * composite.h (Fcomposite_get_gstring): Remove decl.
3303 * dired.c (Ffile_attributes): New forward static decl.
3304 * doc.c (Fdocumntation_property): New forward static decl.
3305 * eval.c (Ffetch_bytecode): New forward static decl.
3306 (Funintern): Remove extern decl; now in .h file where it belongs.
3307 * fileio.c (Fmake_symbolic_link): New forward static decl.
3308 * image.c (Finit_image_library): New forward static decl.
3309 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3310 * intervals.h (Fprevious_property_change):
3311 (Fremove_list_of_text_properties): Remove decls.
3312 * keyboard.c (Fthis_command_keys): Remove decl.
3313 (Fcommand_execute): New forward static decl.
3314 * keymap.c (Flookup_key): New forward static decl.
3315 (Fcopy_keymap): Now static.
3316 * keymap.h (Flookup_key): Remove decl.
3317 * process.c (Fget_process): New forward static decl.
3318 (Fprocess_datagram_address): Mark as internal.
3319 * syntax.c (Fsyntax_table_p): New forward static decl.
3320 (skip_chars): Remove duplicate decl.
3321 * textprop.c (Fprevious_property_change): New forward static decl.
3322 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3323 Now internal.
3324 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3325 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3326
785bbd42
PE
3327 * editfns.c (Fformat): Remove unreachable code.
3328
8b913b57
AS
33292011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3330
3331 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3332 change. (Bug#8496)
3333
a6744a35
EZ
33342011-04-13 Eli Zaretskii <eliz@gnu.org>
3335
3336 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3337 when at ZV. (Bug#8487)
3338
e7974947
AS
33392011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3340
baad03f0
AS
3341 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3342 (Bug#8437)
3343 * keyboard.c (parse_tool_bar_item): Likewise.
3344 * sound.c (sound_cleanup, alsa_close): Likewise.
3345 * termcap.c (tgetent): Likewise.
3346 * xfns.c (x_default_font_parameter): Likewise.
3347 * xsettings.c (read_and_apply_settings): Likewise.
3348
e7974947
AS
3349 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3350 (overrun_check_free): Protoize.
3351
28272684
PE
33522011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3353
3354 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3355 since callers should never pass a negative size.
3356 Change the signature to match that of plain 'read' and 'write'; see
3357 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3358 * lisp.h: Update prototypes of emacs_write and emacs_read.
3359
11997c76
EZ
33602011-04-11 Eli Zaretskii <eliz@gnu.org>
3361
3362 * xdisp.c (redisplay_window): Don't try to determine the character
3363 position of the scroll margin if the window start point w->startp
e896f03c 3364 is outside the buffer's accessible region. (Bug#8468)
11997c76 3365
8a2cbd72
EZ
33662011-04-10 Eli Zaretskii <eliz@gnu.org>
3367
3368 Fix write-region and its subroutines for buffers > 2GB.
3369 * fileio.c (a_write, e_write): Modify declaration of arguments and
3370 local variables to support buffers larger than 2GB.
3371 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3372
3373 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3374 argument, local variables, and return value.
3375
3376 * lisp.h: Update prototypes of emacs_write and emacs_read.
3377
3378 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3379
4073e537 33802011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3381
1ebfdcb6
PE
3382 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3383
b2ded58d
PE
3384 Fix more problems found by GCC 4.6.0's static checks.
3385
7d66342c
PE
3386 * xdisp.c (vmessage): Use a better test for character truncation.
3387
bbf47d44
PE
3388 * charset.c (load_charset_map): <, not <=, for optimization,
3389 and to avoid potential problems with integer overflow.
9248994d 3390 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3391 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3392 * editfns.c (Fformat): Likewise.
1e69125e 3393 * syntax.c (skip_chars): Likewise.
3befa583 3394
e3019616
PE
3395 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3396 This also lets GCC 4.6.0 generate slightly better loop code.
3397
becfa255
PE
3398 * callint.c (Fcall_interactively): <, not <=, for optimization.
3399 (Fcall_interactively): Count the number of arguments produced,
3400 not the number of arguments given. This is simpler and lets GCC
3401 4.6.0 generate slightly better code.
3402
dae0cd48
PE
3403 * ftfont.c: Distingish more carefully between FcChar8 and char.
3404 The previous code passed unsigned char * to a functions like
3405 strlen and xstrcasecmp that expect char *, which does not
3406 conform to the C standard.
3407 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3408 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3409 char * when the C standard requires it.
3410
76032d70
PE
3411 * keyboard.c (read_char): Remove unused var.
3412
eb3f1cc8
PE
3413 * eval.c: Port to Windows vsnprintf (Bug#8435).
3414 Include <limits.h>.
3415 (SIZE_MAX): Define if the headers do not.
3416 (verror): Do not give up if vsnprintf returns a negative count.
3417 Instead, grow the buffer. This ports to Windows vsnprintf, which
3418 does not conform to C99. Problem reported by Eli Zaretskii.
3419 Also, simplify the allocation scheme, by avoiding the need for
3420 calling realloc, and removing the ALLOCATED variable.
3421
70476b54
PE
3422 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3423
12020a9e
PE
3424 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3425 But keep the doprint source code for now, as we might revamp it
3426 and use it again (Bug#8435).
ea6c7ae6
PE
3427 * lisp.h (doprnt): Remove.
3428 * Makefile.in (base_obj): Remove doprnt.o.
3429 * deps.mk (doprnt.o): Remove.
3430
5fdb398c
PE
3431 error: Print 32- and 64-bit integers portably (Bug#8435).
3432 Without this change, on typical 64-bit hosts error ("...%d...", N)
3433 was used to print both 32- and 64-bit integers N, which relied on
3434 undefined behavior.
3435 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3436 New macro.
3437 * lisp.h (error, verror): Mark as printf-like functions.
3438 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3439 Report overflow in size calculations when allocating printf buffer.
3440 Do not truncate output string at its first null byte.
3441 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3442 Truncate the output at a character boundary, since vsnprintf does not
3443 do that.
3444 * charset.c (check_iso_charset_parameter): Convert internal
3445 character to string before calling 'error', since %c now has the
3446 printf meaning.
3447 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3448 overflow when computing char to be passed to 'error'. Do not
3449 pass Lisp_Object to 'error'; pass the integer instead.
3450 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3451 formatted with plain %d.
3452
b189fa66
PE
3453 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3454
bff87ef0
PE
3455 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3456
7e2cac20
PE
3457 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3458
ce4d90b5
PE
3459 * xterm.c (x_catch_errors): Remove duplicate declaration.
3460
266c9547
PE
3461 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3462
79c49ad2
PE
3463 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3464
368f4090
JM
34652011-04-10 Jim Meyering <meyering@redhat.com>
3466
3467 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3468 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3469 return ssize_t not "int", and use size_t as the buffer length.
3470 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3471 * gnutls.h: Update declarations.
3472 * process.c (read_process_output): Use ssize_t, to match.
3473 (send_process): Likewise.
3474
a32d4040
CY
34752011-04-09 Chong Yidong <cyd@stupidchicken.com>
3476
3477 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3478
8546720e 34792011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3480
04f2d78b
CB
3481 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3482 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3483
8546720e
GM
3484 * xterm.c (handle_one_xevent):
3485 * xmenu.c (create_and_show_popup_menu):
3486 * xselect.c (x_decline_selection_request)
3487 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3488
0a2f5c1a 34892011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3490
3491 Fix some uses of `int' instead of EMACS_INT.
3492 * search.c (string_match_1, fast_string_match)
3493 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3494 (scan_buffer, find_next_newline_no_quit)
3495 (find_before_next_newline, search_command, Freplace_match)
3496 (Fmatch_data): Make some `int' variables be EMACS_INT.
3497
3498 * xdisp.c (display_count_lines): 3rd argument and return value now
3499 EMACS_INT. All callers changed.
3500 (pint2hrstr): Last argument is now EMACS_INT.
3501
3502 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3503 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3504 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3505 (decode_coding_utf_16, decode_coding_emacs_mule)
3506 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3507 (decode_coding_ccl, decode_coding_charset)
3508 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3509 (decode_coding_iso_2022, decode_coding_emacs_mule)
3510 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3511 <char_offset, last_offset>: Declare EMACS_INT.
3512 (encode_coding_utf_8, encode_coding_utf_16)
3513 (encode_coding_emacs_mule, encode_invocation_designation)
3514 (encode_designation_at_bol, encode_coding_iso_2022)
3515 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3516 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3517 Declare EMACS_INT.
3518 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3519 (encode_invocation_designation): Last argument P_NCHARS is now
3520 EMACS_INT.
3521 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3522 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3523
3524 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3525 All users changed.
3526
3527 * ccl.c (Fccl_execute_on_string): Declare some variables
3528 EMACS_INT.
3529
8546720e 35302011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3531
3532 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3533
4e19a977
CS
35342011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3535
3536 * process.c (Fformat_network_address): Doc fix.
3537
87302331
R
35382011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3539
3540 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3541
cbb59342
CY
35422011-04-08 Chong Yidong <cyd@stupidchicken.com>
3543
3544 * keyboard.c (read_char): Call Lisp function help-form-show,
3545 instead of using internal_with_output_to_temp_buffer.
3546 (Qhelp_form_show): New var.
e0d38eeb 3547 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3548
3549 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3550
3551 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3552
e67a13ab
CY
35532011-04-06 Chong Yidong <cyd@stupidchicken.com>
3554
04f2d78b
CB
3555 * process.c (Flist_processes): Remove to Lisp.
3556 (list_processes_1): Delete.
e67a13ab 3557
973f782d
EZ
35582011-04-06 Eli Zaretskii <eliz@gnu.org>
3559
7c106b1e
EZ
3560 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3561
973f782d
EZ
3562 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3563
41cf7d1a 35642011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3565
ca23cc88
PE
3566 Fix more problems found by GCC 4.6.0's static checks.
3567
f390e2d5
PE
3568 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3569
42eea0d0
PE
3570 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3571
b69769da 3572 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3573
f9541e84
PE
3574 * xdisp.c (vmessage): Mark as a printf-like function.
3575
13841b55
PE
3576 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3577
c136c10f
PE
3578 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3579
5e2d4a30
PE
3580 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3581 printf-like functions.
3582 (tiff_load): Add casts to remove these marks before passing them
3583 to system-supplied API.
3584
583f48b9
PE
3585 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3586
b25d760e
PE
3587 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3588 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3589 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3590 directly, rather than having caller test rule sign. This avoids
3591 some unnecessary tests.
3592 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3593 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3594 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3595
bc7b6697 3596 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3597 (xfont_open): Avoid unnecessary tests.
bc7b6697 3598
27ccc379
PE
3599 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3600
dcd5c89a
PE
3601 * composite.h, composite.c (composition_gstring_put_cache):
3602 Use EMACS_INT, not int, for length.
3603
b13a45c6
PE
3604 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3605 breaking out part of COMPOSITION_DECODE_RULE.
3606 (COMPOSITION_DECODE_RULE): Use it.
3607 * composite.c (get_composition_id): Remove unused local vars,
3608 by using the new macro.
3609
1e792e4d
PE
3610 * textprop.c (set_text_properties_1): Change while to do-while,
3611 since the condition is always true at first.
3612
dc6c6455 3613 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3614 (interval_deletion_adjustment): Return unsigned value.
3615 All uses changed.
dc6c6455 3616
aba7731a
PE
3617 * process.c (list_processes_1, create_pty, read_process_output):
3618 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3619 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3620 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3621 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3622 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3623
fdfc4bf3
PE
3624 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3625
fca8fe46 3626 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3627 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3628
06a0259a 3629 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3630 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3631 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3632
e7b9e80f
PE
3633 * print.c (print_error_message): Avoid int overflow.
3634
56201685
PE
3635 * font.c (font_list_entities): Redo for clarity,
3636 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3637
78834453 3638 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3639 (font_score): Avoid potential overflow in diff calculation.
78834453 3640
0bc0b309 3641 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3642 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3643
e610eaca
PE
3644 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3645
b895abce
PE
3646 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3647 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3648 can always succeed if overflow has undefined behavior.
3649
1f1d9321 3650 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3651 (wordify): Omit three unnecessary tests.
1f1d9321 3652
c59478bc
PE
3653 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3654 All callers changed. This avoids the need for an unused var.
3655
79b73827
PE
3656 * casefiddle.c (casify_region): Remove var that is set but not used.
3657
a4db5dfe
PE
3658 * dired.c (file_name_completion): Remove var that is set but not used.
3659
43aae36e
PE
3660 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3661
2a47c44d 3662 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3663 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3664
a37c69bf
PE
3665 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3666 Check for integer overflow on size calculations.
3667
328ab8e7
PE
3668 * buffer.c (Fprevious_overlay_change): Remove var that is set
3669 but not used.
3670
e5a2a5cb
PE
3671 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3672 Remove vars that are set but not used.
8d84a6eb 3673 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3674 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3675
a60e5f68
PE
3676 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3677
f661cb61 3678 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3679 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3680
f0397f5a
PE
3681 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3682 that are set but not used.
3683
8664db06 3684 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3685 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3686
6abdaa4a
PE
3687 * xselect.c (x_get_local_selection, x_handle_property_notify):
3688 Remove vars that are set but not used.
3689
0ce7538d 3690 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3691 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3692
9ae848fc
PE
3693 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3694 Remove var that is set but not used.
0b918413
PE
3695 (scroll_bar_windows_size): Now size_t, not int.
3696 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3697 Check for overflow.
9ae848fc 3698
a5a62657
PE
3699 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3700 (map_tty_color) [!defined MSDOS]: Likewise.
3701
5c5cdd39
PE
3702 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3703
66ebf983
PE
3704 * coding.c: Remove vars that are set but not used.
3705 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3706 All callers changed.
3707 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3708 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3709 (decode_coding_charset): Remove vars that are set but not used.
3710
1be4d761
PE
3711 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3712 that is set but not used.
3713
47553fa8
PE
3714 * print.c (print_object): Remove var that is set but not used.
3715
1f7196bf 3716 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3717 The gnulib version avoids calling malloc in the usual case,
3718 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3719 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3720 * filelock.c (current_lock_owner): Likewise.
3721 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3722 * sysdep.c: Include allocator.h, careadlinkat.h.
3723 (emacs_no_realloc_allocator): New static constant.
3724 (emacs_readlink): New function.
fdb61804
PE
3725 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3726 ../lib/careadlinkat.h.
d1fdcab7 3727
f84c17c7
SM
37282011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3729
3730 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3731 first non-nil return value).
3732
ef3862ad
JD
37332011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3736 if not defined (Bug#8403).
3737
376a7006
JB
37382011-04-02 Juanma Barranquero <lekktu@gmail.com>
3739
3740 * xdisp.c (display_count_lines): Remove parameter `start',
3741 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3742 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3743 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3744 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3745 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3746 and thereabouts. All callers changed.
3747 (get_per_char_metric): Remove parameter `f', unused since
3748 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3749
6ca3801d
JM
37502011-04-02 Jim Meyering <meyering@redhat.com>
3751
3752 do not dereference NULL upon failed strdup
3753 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3754 (ns_get_family): Likewise.
3755
d8e2b5ba
JB
37562011-04-02 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3759
8c74fcbd
JD
37602011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3761
3762 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3763 later (Bug#8403).
3764
7200d79c
SM
37652011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3766
03408648 3767 Add lexical binding.
7200d79c 3768
03408648
SM
3769 * window.c (Ftemp_output_buffer_show): New fun.
3770 (Fsave_window_excursion):
3771 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3772
3773 * lread.c (lisp_file_lexically_bound_p): New function.
3774 (Fload): Bind Qlexical_binding.
3775 (readevalloop): Remove `evalfun' arg.
3776 Bind Qinternal_interpreter_environment.
3777 (Feval_buffer): Bind Qlexical_binding.
3778 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3779 Mark as dynamic.
3780 (syms_of_lread): Declare `lexical-binding'.
3781
3782 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3783
3784 * keyboard.c (eval_dyn): New fun.
3785 (menu_item_eval_property): Use it.
ca105506
SM
3786
3787 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3788
03408648
SM
3789 * fns.c (concat, mapcar1): Accept byte-code-functions.
3790
3791 * eval.c (Fsetq): Handle lexical vars.
3792 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3793 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3794 (FletX, Flet): Obey lexical binding.
3795 (Fcommandp): Handle closures.
3796 (Feval): New `lexical' arg.
3797 (eval_sub): New function extracted from Feval. Use it almost
3798 everywhere where Feval was used. Look up vars in lexical env.
3799 Handle closures.
3800 (Ffunctionp): Move from subr.el.
3801 (Ffuncall): Handle closures.
3802 (apply_lambda): Remove `eval_flags'.
3803 (funcall_lambda): Handle closures and new byte-code-functions.
3804 (Fspecial_variable_p): New function.
3805 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3806 but without exporting it to Lisp.
23aba0ea 3807
23aba0ea 3808 * doc.c (Fdocumentation, store_function_docstring):
03408648 3809 * data.c (Finteractive_form): Handle closures.
23aba0ea 3810
03408648
SM
3811 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3812 interactive spec.
ba83908c 3813
04f2d78b
CB
3814 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3815 New byte-codes.
03408648
SM
3816 (exec_byte_code): New function extracted from Fbyte_code to handle new
3817 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3818
03408648 3819 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3820
03408648 3821 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3822
e2abce01
JB
38232011-03-31 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * xdisp.c (redisplay_internal): Fix prototype.
3826
63696a73 38272011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3828
63696a73 3829 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3830 (try_scrolling): Use it when setting scroll_limit.
3831 Limit scrolling to 100 screen lines.
63696a73
EZ
3832 (redisplay_window): Even when falling back on "recentering",
3833 position point in the window according to scroll-conservatively,
3834 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3835
3836 (try_scrolling): When point is above the window, allow searching
3837 as far as scroll_max, or one screenful, to compute vertical
3838 distance from PT to the scroll margin position. This prevents
3839 try_scrolling from unnecessarily failing when
3840 scroll-conservatively is set to a value slightly larger than the
3841 window height. Clean up the case of PT below the margin at bottom
3842 of window: scroll_max can no longer be INT_MAX. When aggressive
3843 scrolling is in use, don't let point enter the opposite scroll
3844 margin as result of the scroll.
3845 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3846 threshold of 100 lines for never-recentering scrolling.
3847
e4cc2dfc
JB
38482011-03-31 Juanma Barranquero <lekktu@gmail.com>
3849
3850 * dispextern.h (move_it_by_lines):
3851 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3852 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3853 (message_log_check_duplicate): Remove parameters `prev_bol' and
3854 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3855 (redisplay_internal): Remove parameter `preserve_echo_area',
3856 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3857
3858 * indent.c (Fvertical_motion):
3859 * window.c (window_scroll_pixel_based, Frecenter):
3860 Don't pass `need_y_p' to `move_it_by_lines'.
3861
1c470562
SM
38622011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3863
44f230aa
SM
3864 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3865 steal a few bits to be more compact.
3866 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3867 Remove unneeded casts.
3868
1c470562
SM
3869 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3870
888adce9
ZK
38712011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3872
3873 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3874 binding" message (bug#7967).
3875
f838ed7b
PE
38762011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3877
77861b95
PE
3878 Fix more problems found by GCC 4.6.0's static checks.
3879
de6dbc14
PE
3880 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3881 Remove unused local var.
3882
f838ed7b
PE
3883 * editfns.c (Fmessage_box): Remove unused local var.
3884
792c7b2b
PE
3885 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3886 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3887 Omit unused local vars.
c499e557 3888 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3889 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3890 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3891 Omit unused local var.
3892
ba0165e1
PE
3893 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3894 Don't assume string length fits in int.
32ad8845 3895 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3896 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3897
3c59b4c9
PE
3898 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3899 instead of alloca (Bug#8344).
3900
a3eed478 3901 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3902 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3903
eb4d412d
PE
3904 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3905
1658b401
PE
3906 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3907 concerns.
3908
3909 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3910
3911 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3912
9a2c6e05
PE
3913 * keyboard.c (syms_of_keyboard): Use the same style as later
3914 in this function when indexing through an array. This also
3915 works around GCC bug 48267.
3916
03d0a109
PE
3917 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3918
44f730c8
PE
3919 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3920
fe75f926
PE
3921 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3922 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3923
ffa8c828
PE
3924 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3925 This avoids undefined behavior on integer overflow, and is a bit
3926 more convenient anyway since it is compared to a size_t variable.
3927
c5101a77
PE
3928 Variadic C functions now count arguments with size_t, not int.
3929 This avoids an unnecessary limitation on 64-bit machines, which
3930 caused (substring ...) to crash on large vectors (Bug#8344).
3931 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3932 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3933 All variadic functions and their callers changed accordingly.
c5101a77
PE
3934 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3935 * data.c (arith_driver, float_arith_driver): Likewise.
3936 * editfns.c (general_insert_function): Likewise.
3937 * eval.c (struct backtrace.nargs, interactive_p)
3938 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3939 (funcall_lambda, mark_backtrace): Likewise.
3940 * fns.c (concat): Likewise.
3941 * frame.c (x_set_frame_parameters): Likewise.
3942 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3943 0 if not found, not -1. All callers changed.
3944
dd3f25f7
PE
3945 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3946 (stack_copy_size): Now size_t, not int.
3947 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3948
461c2ab9
JB
39492011-03-28 Juanma Barranquero <lekktu@gmail.com>
3950
3951 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3952 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3953 All callers changed.
3954
3955 * lisp.h (multibyte_char_to_unibyte):
3956 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3957 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3958 * character.h (CHAR_TO_BYTE8):
3959 * cmds.c (internal_self_insert):
3960 * editfns.c (general_insert_function):
3961 * keymap.c (push_key_description):
3962 * search.c (Freplace_match):
3963 * xdisp.c (message_dolog, set_message_1): All callers changed.
3964
f6d62986
SM
39652011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3966
3967 * keyboard.c (safe_run_hook_funcall): New function.
3968 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3969 don't set the hook to nil, but remove the offending function instead.
3970 (Qcommand_hook_internal): Remove, unused.
3971 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3972 Vcommand_hook_internal.
3973
3974 * eval.c (enum run_hooks_condition): Remove.
3975 (funcall_nil, funcall_not): New functions.
3976 (run_hook_with_args): Call each function through a `funcall' argument.
3977 Remove `cond' argument, now redundant.
3978 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3979 (Frun_hook_with_args_until_failure): Adjust accordingly.
3980 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3981
1db5b1ad
JB
39822011-03-28 Juanma Barranquero <lekktu@gmail.com>
3983
3984 * dispextern.h (string_buffer_position): Remove declaration.
3985
3986 * print.c (strout): Remove parameter `multibyte', unused since
3987 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3988
3989 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3990 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3991 All callers changed.
3992
3993 * w32.c (_wsa_errlist): Use braces for struct initializers.
3994
3995 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3996 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3997 All callers changed.
3998 (string_buffer_position): Likewise. Also, make static (it's never
3999 used outside xdisp.c).
4000 (cursor_row_p): Remove parameter `w', unused since
4001 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4002 (decode_mode_spec): Remove parameter `precision', introduced during
4003 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4004 All callers changed.
4005
5ffb62aa
JD
40062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4007
4008 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4009
461c2ab9 40102011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4011
4012 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4013 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4014 (ns_update_auto_hide_menu_bar): New functions.
4015 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4016 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4017 ns_constrain_all_frames.
4018 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4019 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4020
5c380ffb
JD
40212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4022
4023 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4024
9af30bdf
GM
40252011-03-27 Glenn Morris <rgm@gnu.org>
4026
4027 * syssignal.h: Replace RETSIGTYPE with void.
4028 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4029 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4030 Replace SIGTYPE with void everywhere.
4031 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4032 * s/template.h (SIGTYPE): Remove commented out definition.
4033
e2abce01
JB
40342011-03-26 Eli Zaretskii <eliz@gnu.org>
4035
4036 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4037 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4038
f868cd8a
JB
40392011-03-26 Juanma Barranquero <lekktu@gmail.com>
4040
59eb0929
JB
4041 * w32.c (read_unc_volume): Use parameter `henum', instead of
4042 global variable `wget_enum_handle'.
4043
4044 * keymap.c (describe_vector): Remove parameters `indices' and
4045 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4046 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4047
f868cd8a
JB
4048 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4049
4050 * keyboard.c (timer_check): Remove parameter `do_it_now',
4051 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4052 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4053 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4054
4055 * keyboard.c (read_char):
4056 * w32menu.c (w32_menu_display_help):
4057 * xmenu.c (show_help_event, menu_help_callback):
4058 Adjust calls to `show_help_echo'.
4059
4060 * gtkutil.c (xg_maybe_add_timer):
4061 * keyboard.c (readable_events):
4062 * process.c (wait_reading_process_output):
4063 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4064
4065 * insdel.c (adjust_markers_gap_motion):
4066 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4067 (gap_left, gap_right): Don't call it.
4068
2ecf6fdb
CY
40692011-03-25 Chong Yidong <cyd@stupidchicken.com>
4070
4071 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4072 incurred during fontification.
4073
6b1f9ba4
JB
40742011-03-25 Juanma Barranquero <lekktu@gmail.com>
4075
4076 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4077 (DEFVAR_PER_BUFFER): Don't pass it.
4078
4079 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4080 (scrolling_window): Don't pass it.
4081
0f4a96b5
JB
40822011-03-25 Juanma Barranquero <lekktu@gmail.com>
4083
4084 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4085
4086 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4087 and `suffix'.
4088 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4089 of variables specific to SELinux and computation of `encoded_absname'.
4090
4091 * image.c (XPutPixel): Remove unused variable `height'.
4092
4093 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4094
4095 * unexw32.c (get_section_info): Remove unused variable `section'.
4096
4097 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4098 (system_process_attributes): Remove unused variable `sess'.
4099 (sys_read): Remove unused variable `err'.
4100
4101 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4102 (w32_wnd_proc): Remove unused variable `isdead'.
4103 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4104 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4105 (x_create_tip_frame): Remove unused variable `tem'.
4106
4107 * w32inevt.c (w32_console_read_socket):
4108 Remove unused variable `no_events'.
4109
4110 * w32term.c (x_draw_composite_glyph_string_foreground):
4111 Remove unused variable `width'.
4112
1149507c
JB
41132011-03-24 Juanma Barranquero <lekktu@gmail.com>
4114
4115 * w32term.c (x_set_glyph_string_clipping):
4116 Don't pass uninitialized region to CombineRgn.
4117
9c88f339
JB
41182011-03-23 Juanma Barranquero <lekktu@gmail.com>
4119
4120 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4121 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4122 (Fx_close_connection): Remove unused variable `i'.
4123
4124 * w32font.c (w32font_draw): Return number of glyphs.
4125 (w32font_open_internal): Remove unused variable `i'.
4126 (w32font_driver): Add missing initializer.
4127
4128 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4129 (fill_in_menu): Remove unused variable `items_added'.
4130
4131 * w32term.c (last_mouse_press_frame): Remove static global variable.
4132 (w32_clip_to_row): Remove unused variable `f'.
4133 (x_delete_terminal): Remove unused variable `i'.
4134
4135 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4136 (NOTHING): Remove unused static global variable.
4137 (uniscribe_check_otf): Remove unused variable `table'.
4138 (uniscribe_font_driver): Add missing initializers.
4139
dee091a3
JD
41402011-03-23 Julien Danjou <julien@danjou.info>
4141
4142 * term.c (Fsuspend_tty, Fresume_tty):
4143 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4144 * window.c (temp_output_buffer_show):
4145 * insdel.c (signal_before_change):
4146 * frame.c (Fhandle_switch_frame):
4147 * fileio.c (Fdo_auto_save):
4148 * emacs.c (Fkill_emacs):
4149 * editfns.c (save_excursion_restore):
4150 * cmds.c (internal_self_insert):
4151 * callint.c (Fcall_interactively):
4152 * buffer.c (Fkill_all_local_variables):
4153 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4154 Use Frun_hooks.
0f4a96b5 4155 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4156 unconditionnaly since it does the check itself.
4157
2c520ab5 41582011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4159
c9c49752
PE
4160 Fix more problems found by GCC 4.5.2's static checks.
4161
8abc3f12
PE
4162 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4163 the first time through the loop, since we know p0 < p1 then.
4164 This also avoids a gcc -Wstrict-overflow warning.
4165
a2d26660
PE
4166 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4167 leading to a memory leak, possible in functions like
4168 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4169 of objects (Bug#8318).
a2d26660 4170
916c72e9
PE
4171 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4172 that could (at least in theory) be that large.
4173
19ab8a18
PE
4174 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4175 This is less likely to overflow, and avoids undefined behavior if
4176 overflow does occur. All callers changed. Use strtoul to scan
4177 for the unsigned long integer.
b7cbbd6f
PE
4178 (pint2hrstr): Simplify and tune code slightly.
4179 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4180
f0641eff
PE
4181 * scroll.c (do_scrolling): Work around GCC bug 48228.
4182 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4183
7f650bb9
PE
4184 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4185 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4186 (validate_x_resource_name): Simplify count usage.
4187 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4188
37dd57d1
PE
4189 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4190 fail (Bug#8306).
81e56e61 4191
699979fc 4192 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4193
401bf9b4
PE
4194 * process.c (Fmake_network_process): Use socklen_t, not int,
4195 where POSIX says socklen_t is required in portable programs.
4196 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4197 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4198 (Fmake_network_process, server_accept_connection):
4199 (wait_reading_process_output, read_process_output):
4200 Likewise.
4201
b93aacde
PE
4202 * process.c: Rename or move locals to avoid shadowing.
4203 (list_processes_1, Fmake_network_process):
4204 (read_process_output_error_handler, exec_sentinel_error_handler):
4205 Rename or move locals.
4dc343ee 4206 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4207 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4208 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4209 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4210 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4211
af8a867c 4212 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4213 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4214 Include tparam.h instead, since it declares them.
af8a867c
PE
4215 * cm.h (PC): Remove extern decl; tparam.h now does this.
4216 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4217 * terminfo.c: Include tparam.h, to check interfaces.
4218 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4219 (tparam): Adjust signature to match interface in tparam.h;
4220 this removes some undefined behavior. Check that outstring and len
4221 are zero, which they always are with Emacs.
4222 * tparam.h (PC, BC, UP): New extern decls.
4223
0248044d 4224 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4225 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4226
8ff096c1 4227 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4228 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4229 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4230 (ftfont_list): Remove unused local.
49eaafba
PE
4231 (get_adstyle_property, ftfont_pattern_entity):
4232 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4233 Rename locals to avoid shadowing.
8ff096c1 4234
e2be39f6
PE
4235 * xfont.c (xfont_list_family): Mark var as initialized.
4236
c9735e30
PE
4237 * xml.c (make_dom): Now static.
4238
8f5201ae
PE
4239 * composite.c (composition_compute_stop_pos): Rename local to
4240 avoid shadowing.
b246f932
PE
4241 (composition_reseat_it): Remove unused locals.
4242 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4243 (composition_update_it): Mark var as initialized.
11b61122
PE
4244 (find_automatic_composition): Mark vars as initialized,
4245 with a FIXME (Bug#8290).
8f5201ae 4246
760fbc2c
PE
4247 character.h: Rename locals to avoid shadowing.
4248 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4249 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4250 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4251 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4252 to avoid shadowing.
4253
ff08eb85
PE
4254 * textprop.c (property_change_between_p): Remove; unused.
4255
fc7bf025
PE
4256 * intervals.c (interval_start_pos): Now static.
4257
235d7abc
PE
4258 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4259
44f230aa
SM
4260 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4261 Rename locals to avoid shadowing.
3e7d6594 4262
50060332
PE
4263 * sound.c (wav_play, au_play, Fplay_sound_internal):
4264 Fix pointer signedness.
d01f234b 4265 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4266 (wav_play): Initialize a variable to 0, to prevent undefined
4267 behavior (Bug#8278).
50060332 4268
c4fc4e30
PE
4269 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4270
918436ed
PE
4271 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4272
c939f91b
PE
4273 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4274 clobbering (Bug#8298).
b9c7f648
PE
4275 * sysdep.c (sys_subshell): Likewise.
4276 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4277
6bd8c144
PE
4278 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4279 This should get cleaned up, so that child_setup has the
4280 same signature on all platforms.
4281
7710357c 4282 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4283 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4284
c59da222
CY
42852011-03-22 Chong Yidong <cyd@stupidchicken.com>
4286
4287 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4288 not to be necessary, and produces flickering.
4289
66b87493
GM
42902011-03-20 Glenn Morris <rgm@gnu.org>
4291
4292 * config.in: Remove file.
4293
45b6f6d5
JB
42942011-03-20 Juanma Barranquero <lekktu@gmail.com>
4295
4296 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4297 are now in src/globals.h.
4298 (syms_of_minibuf): Remove spurious & from previous change.
4299
3ec03f7e
LL
43002011-03-20 Leo <sdl.web@gmail.com>
4301
4302 * minibuf.c (completing-read-function): New variable.
4303 (completing-read-default): Rename from completing-read.
4304 (completing-read): Call completing-read-function.
4305
b14e3e21
CY
43062011-03-19 Juanma Barranquero <lekktu@gmail.com>
4307
4308 * xfaces.c (Fx_load_color_file):
4309 Read color file from absolute filename (bug#8250).
4310
f2b726e6
JB
43112011-03-19 Juanma Barranquero <lekktu@gmail.com>
4312
4313 * makefile.w32-in: Update dependencies.
4314
09f6ff02
EZ
43152011-03-17 Eli Zaretskii <eliz@gnu.org>
4316
4317 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4318
29a6015a
PE
43192011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4320
a3a6c54e
PE
4321 Fix more problems found by GCC 4.5.2's static checks.
4322
b766f867
PE
4323 * process.c (make_serial_process_unwind, send_process_trap):
4324 (sigchld_handler): Now static.
4325
be02381c
PE
4326 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4327 That way, the code declares only the vars that it needs.
4328 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4329 * s/cygwin.h (PTY_ITERATION): Likewise.
4330 * s/darwin.h (PTY_ITERATION): Likewise.
4331 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4332
57048744
PE
4333 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4334 * process.c (allocate_pty): Don't declare stb unless it's needed.
4335
7914961c 4336 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4337 (CONSTANTLIM): Remove; unused.
4338 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4339 Define only if needed.
7914961c 4340
b3967b18
PE
4341 * unexelf.c (unexec): Name an expression,
4342 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4343 Use a different way to cause a compilation error if anyone uses
4344 n rather than nn, a way that does not involve shadowing.
73366a00 4345 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4346
29a6015a
PE
4347 * deps.mk (unexalpha.o): Remove; unused.
4348
43cfc33e 4349 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4350 * unexec.h: New file.
ce701a33
PE
4351 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4352 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4353 Depend on unexec.h.
4354 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4355 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4356 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4357 Change as necessary to match prototype in unexec.h.
ce701a33 4358
01f44d5a
PE
4359 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4360 shadowing.
4f63c6bb 4361 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4362
a6670b0b
PE
4363 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4364 Rename locals to avoid shadowing.
4365
cef2010d 4366 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4367 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4368
d4d7173a
PE
4369 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4370
f08b802a
PE
4371 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4372 warning when compiling print.c.
4373
3ddb0639
PE
4374 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4375 instead of using an uninitialized var.
5ad03b97 4376 (font_sort_entities): Mark var as initialized.
3ddb0639 4377
170a2692
PE
4378 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4379
e663c700
PE
4380 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4381 pointers to constants.
89bc529a 4382 (font_parse_fcname): Remove unused vars.
7b81e2d0 4383 (font_delete_unmatched): Now static.
ea838e10 4384 (font_get_spec): Remove; unused.
13a547c6
PE
4385 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4386 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4387 Rename or move locals to avoid shadowing.
e663c700 4388
2a80c887 4389 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4390 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4391
1384fa33 4392 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4393 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4394
8b2c52e9
PE
4395 * alloc.c (mark_backtrace): Move decl from here ...
4396 * lisp.h: ... to here, so that it can be checked.
4397
475545b5 4398 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4399 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4400 (lisp_indirect_variable): Name an expression,
4401 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4402 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4403
b1349114 4404 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4405 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4406 Use const pointer when appropriate.
b1349114 4407
a2928364
PE
4408 * lisp.h (get_system_name, get_operating_system_release):
4409 Move decls here, to check interfaces.
4410 * process.c (get_operating_system_release): Move decl to lisp.h.
4411 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4412 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4413 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4414 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4415 (Fformat_time_string, Fencode_time, Finsert_char):
4416 (Ftranslate_region_internal, Fformat):
4417 Rename or remove local vars to avoid shadowing.
9710023e 4418 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4419
a415e694
PE
4420 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4421 avoid shadowing.
4422
8ef4622d
PE
4423 * lisp.h (eassert): Check that the argument compiles, even if
4424 ENABLE_CHECKING is not defined.
4425
946f9a5b
PE
4426 * data.c (Findirect_variable): Name an expression, to avoid
4427 gcc -Wbad-function-cast warning.
112396d6 4428 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4429 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4430 (Fmake_variable_buffer_local, Fmake_local_variable):
4431 Mark variables as initialized.
52746918 4432 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4433
e5aab7e7 4434 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4435 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4436 Rename locals to avoid shadowing.
dff45157
PE
4437 (mark_stack): Move local variables into the #ifdef region where
4438 they're used.
7bc26fdb
PE
4439 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4440 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4441 needed otherwise.
4442 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4443 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4444 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4445
e5aab7e7
PE
4446 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4447 avoids undefined behavior in theory.
4448
4da60324
PE
4449 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4450
88043301
PE
4451 Use functions, not macros, for up- and down-casing (Bug#8254).
4452 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4453 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4454 to use the following functions instead of these macros.
4455 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4456 EMACS_INT, since callers assume the returned value fits in int.
4457 (upcase1): Likewise, for UPCASE_TABLE.
4458 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4459 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4460 the race-condition problem in the old DOWNCASE.
88043301 4461
19ed5445
PE
4462 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4463 Rename locals to avoid shadowing.
4464 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4465 (regex_compile, re_search_2, re_match_2_internal):
4466 Remove unused local vars.
952db0d7
PE
4467 (FREE_VAR): Rewrite so as not to use empty "else",
4468 which gcc can warn about.
da053e48 4469 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4470 (RETALLOC_IF): Define only if needed.
4471 (WORDCHAR_P): Likewise. This one is never needed, but is used
4472 only in a comment talking about a compiler bug, so put inside
4473 the #if 0 of that comment.
4474 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4475 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4476 Remove; unused.
19ed5445 4477
1f3561e4 4478 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4479 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4480 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4481
ded6f8f7
PE
4482 * search.c (simple_search): Remove unused var.
4483
dbd37a95
PE
4484 * dired.c (compile_pattern): Move decl from here ...
4485 * lisp.h: ... to here, so that it can be checked.
4486 (struct re_registers): New forward decl.
4487
7e47afad
PE
4488 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4489
85f24f61
PE
4490 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4491 All uses changed.
4492 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4493 Rename locals to avoid shadowing.
5671df8f 4494 (Fvertical_motion): Mark locals as initialized.
85f24f61 4495
181aa2be 4496 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4497 (casify_region): Mark local as initialized.
181aa2be 4498
930d429c
PE
4499 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4500
7082eac6
PE
4501 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4502 New macros, so that the caller can use some names other than
4503 gcpro1, gcpro2, etc.
4504 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4505 of the new macros.
4506 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4507 argument, for consistency with GCPRO2_VAR, etc: it is now the
4508 prefix of the variable, not the variable itself. All uses
4509 changed.
38b2c076
PE
4510 * dired.c (directory_files_internal, file_name_completion):
4511 Rename locals to avoid shadowing.
4512
15206ed9
PE
4513 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4514 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4515 dired.c's scmp function, had undefined behavior.
4516 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4517 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4518 * buffer.h: ... to here, because these macros use current_buffer,
4519 and the new implementation with inline functions needs to have
4520 current_buffer in scope now, rather than later when the macros
4521 are used.
4522 (downcase, upcase1): New static inline functions.
4523 (DOWNCASE, UPCASE1): Reimplement using these functions.
4524 This avoids undefined behavior in expressions like
4525 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4526 from race conditions in accessing the global variables
4527 case_temp1 and case_temp2.
4528 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4529 * lisp.h (case_temp1, case_temp2): Remove their decls.
4530 * character.h (ASCII_CHAR_P): Move from here ...
4531 * lisp.h: ... to here, so that the inline functions mentioned
4532 above can use them.
4533
4a6bea26
PE
4534 * dired.c (directory_files_internal_unwind): Now static.
4535
f14b7e14
PE
4536 * fileio.c (file_name_as_directory, directory_file_name):
4537 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4538 Now static.
2893f146
PE
4539 (file_name_as_directory): Use const pointers when appropriate.
4540 (Fexpand_file_name): Likewise. In particular, newdir might
4541 point at constant storage, so make it a const pointer.
fd4ead52 4542 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4543 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4544 signedness issues.
f839df0c
PE
4545 (Fset_file_times, Finsert_file_contents, auto_save_error):
4546 Rename locals to avoid shadowing.
f14b7e14 4547
5716756e 4548 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4549 (Ftry_completion, Fall_completions): Rename or remove locals
4550 to avoid shadowing.
5716756e 4551
b4c3046a
PE
4552 * marker.c (bytepos_to_charpos): Remove; unused.
4553
b45db522
PE
4554 * lisp.h (verify_bytepos, count_markers): New decls,
4555 so that gcc does not warn that these functions aren't declared.
4556
85876d07
PE
4557 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4558 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4559 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4560 (copy_text): Remove unused local var.
85876d07 4561
03d78a21 4562 * filelock.c (within_one_second): Now static.
b3dd38ab 4563 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4564
5df8f01b
PE
4565 * buffer.c (fix_overlays_before): Mark locals as initialized.
4566 (fix_start_end_in_overlays): Likewise. This function should be
4567 simplified by using pointers-to-pointers, but that's a different
4568 matter.
b1d876f1 4569 (switch_to_buffer_1): Now static.
8f54f30a
PE
4570 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4571 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4572
a70072c9 4573 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4574 Fix pointer signedness issue.
edced198
PE
4575 (sys_subshell): Mark local as volatile if checking for lint,
4576 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4577 (MAXPATHLEN): Define only if needed.
a70072c9 4578
a0977c44
PE
4579 * process.c (serial_open, serial_configure): Move decls from here ...
4580 * systty.h: ... to here, so that they can be checked.
4581
a884fdcc
PE
4582 * fns.c (get_random, seed_random): Move extern decls from here ...
4583 * lisp.h: ... to here, so that they can be checked.
4584
604efe86 4585 * sysdep.c (reset_io): Now static.
b8950c94 4586 (wait_for_termination_signal): Remove; unused.
604efe86 4587
38fc62d9
PE
4588 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4589 (copy_keymap_item, append_key, push_text_char_description):
4590 Now static.
1004a21a 4591 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4592 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4593 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4594 (describe_map_tree):
4595 Rename locals to avoid shadowing.
38fc62d9 4596
2f2650da
PE
4597 * keyboard.c: Declare functions static if they are not used elsewhere.
4598 (echo_char, echo_dash, cmd_error, top_level_2):
4599 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4600 (read_char, kbd_buffer_get_event, make_lispy_position):
4601 (make_lispy_event, make_lispy_movement, apply_modifiers):
4602 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4603 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4604 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4605 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4606 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4607
a053e86c 4608 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4609 (mark_kboards): Move decl here ...
4610 * alloc.c (mark_kboards): ... from here.
a053e86c 4611
4752793e
PE
4612 * lisp.h (force_auto_save_soon): New decl.
4613
74f10ca7 4614 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4615 (DEFINE_DUMMY_FUNCTION): New macro.
4616 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4617 Use it.
c03cd23f
PE
4618 (main): Add casts to avoid warnings
4619 if GCC considers string literals to be constants.
74f10ca7 4620
022e70d4
PE
4621 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4622
59d6fe83
PE
4623 * dbusbind.c: Pointer signedness fixes.
4624 (xd_signature, xd_append_arg, xd_initialize):
4625 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4626 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4627 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4628 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4629
78320123
PE
4630 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4631 if GCC considers string literals to be constants.
49cebcca 4632 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4633
35ac2a97
SM
46342011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4635
fb103ca9
SM
4636 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4637 (print_preprocess, print_object): New macro to fix last change.
4638
35ac2a97
SM
4639 * print.c (print_preprocess): Don't forget font objects.
4640
62973b41
JB
46412011-03-16 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * emacs.c (USAGE3): Doc fixes.
4644
0e48bb22
AS
46452011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4646
4647 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4648 structure.
4649
7684e57b
JB
46502011-03-14 Juanma Barranquero <lekktu@gmail.com>
4651
4652 * lisp.h (VWindow_system, Qfile_name_history):
4653 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4654 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4655 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4656
4657 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4658 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4659
4660 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4661 * w32console.c (detect_input_pending, read_input_pending)
4662 (encode_terminal_code):
4663 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4664 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4665 (w32_system_caret_y, Qfile_name_history):
4666 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4667 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4668 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4669 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4670 * w32proc.c (Qlocal, report_file_error):
4671 * w32term.c (Vwindow_system, updating_frame):
4672 * w32uniscribe.c (initialized, uniscribe_font_driver):
4673 Remove unneeded extern declarations.
4674
2aa46d6c
CY
46752011-03-14 Chong Yidong <cyd@stupidchicken.com>
4676
c96bbc66 4677 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4678
cffc6f3b
CY
46792011-03-13 Chong Yidong <cyd@stupidchicken.com>
4680
4681 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4682 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4683 These macros can no longer be used for assignment.
4684
44f230aa
SM
4685 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4686 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4687 (record_buffer_markers, fetch_buffer_markers): New functions for
4688 recording and fetching special buffer markers.
4689 (set_buffer_internal_1, set_buffer_temp): Use them.
4690
4691 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4692
4693 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4694
4695 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4696 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4697
4698 * xdisp.c (hscroll_window_tree):
4699 (reconsider_clip_changes): Use PT instead of BUF_PT.
4700
d251f04b
EZ
47012011-03-13 Eli Zaretskii <eliz@gnu.org>
4702
4703 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4704 $(EMACS_ROOT)/lib/intprops.h.
4705
f0c77cd1
PE
47062011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4707
3eca4629
PE
4708 Fix more problems found by GCC 4.5.2's static checks.
4709
7c86ee98
PE
4710 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4711 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4712 (xg_free_frame_widgets): Make it clear that a local variable is
4713 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4714 (gdk_window_get_screen): Make it clear that this macro is needed
4715 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4716 (int_gtk_range_get_value): New function, which avoids a diagnostic
4717 from gcc -Wbad-function-cast.
4718 (xg_set_toolkit_scroll_bar_thumb): Use it.
4719 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4720 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4721 (get_utf8_string, xg_get_file_with_chooser):
4722 Rename locals to avoid shadowing.
4723 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4724
41729b81
PE
4725 * xgselect.c (xg_select): Remove unused var.
4726
f0c77cd1
PE
4727 * image.c (four_corners_best): Mark locals as initialized.
4728 (gif_load): Initialize transparent_p to zero (Bug#8238).
4729 Mark another local as initialized.
ec6cf4c6 4730 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4731
ce0ad53d 4732 * image.c (clear_image_cache): Now static.
d5d5a617 4733 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4734 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4735 (x_edge_detection): Remove unnecessary cast that
4736 gcc -Wbad-function-cast diagnoses.
2037898d 4737 (gif_load): Fix pointer signedness.
6ae141d6
PE
4738 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4739 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4740
33383987 47412011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4742
d32df629
PE
4743 Improve quality of tests for time stamp overflow.
4744 For example, without this patch (encode-time 0 0 0 1 1
4745 1152921504606846976) returns the obviously-bogus value (-948597
4746 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4747 reports time overflow. See
4748 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4749 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4750 * editfns.c: Include limits.h and intprops.h.
4751 (TIME_T_MIN, TIME_T_MAX): New macros.
4752 (time_overflow): Move earlier, to before first use.
4753 (hi_time, lo_time): New functions, for an accurate test for
4754 out-of-range times.
4755 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4756 (Fget_internal_run_time): Don't assume time_t fits in int.
4757 (make_time): Use list2 instead of Fcons twice.
4758 (Fdecode_time): More accurate test for out-of-range times.
4759 (check_tm_member): New function.
4760 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4761 (lisp_time_argument): Don't rely on undefined left-shift and
4762 right-shift behavior when checking for time stamp overflow.
8be6f318 4763
fe31d94c
PE
4764 * editfns.c (time_overflow): New function, refactoring common code.
4765 (Fformat_time_string, Fdecode_time, Fencode_time):
4766 (Fcurrent_time_string): Use it.
4767
8be6f318
PE
4768 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4769 * dired.c (make_time): Move to ...
4770 * editfns.c (make_time): ... here.
4771 * systime.h: Note the move.
4772
09d9db2c 47732011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4774
126bc0dc
YM
4775 * fringe.c (update_window_fringes): Remove unused variables.
4776
c47cbdfd
YM
4777 * unexmacosx.c (copy_data_segment): Also copy __got section.
4778 (Bug#8223)
4779
7ac80be9
EZ
47802011-03-12 Eli Zaretskii <eliz@gnu.org>
4781
c96bbc66 4782 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4783 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4784 Constify `char *' arguments and their references according to
4785 prototypes in tparam.h.
4786
ecb0f94d 4787 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4788
7ac80be9
EZ
4789 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4790 Adapt all references accordingly.
4791
4792 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4793
ef1fd07e
TT
47942011-03-11 Tom Tromey <tromey@redhat.com>
4795
4796 * buffer.c (syms_of_buffer): Remove obsolete comment.
4797
7ef4b50c
EZ
47982011-03-11 Eli Zaretskii <eliz@gnu.org>
4799
4800 * termhooks.h (encode_terminal_code): Declare prototype.
4801
4802 * msdos.c (encode_terminal_code): Don't declare prototype.
4803
4804 * term.c (encode_terminal_code): Now external again, used by
4805 w32console.c and msdos.c.
4806
44f230aa
SM
4807 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4808 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4809
4b1ec863 48102011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4811
1714f52b 4812 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4813
4b1ec863
PE
4814 * fringe.c (update_window_fringes): Mark locals as initialized
4815 (Bug#8227).
4816 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4817
524c7aa6
PE
4818 * alloc.c (mark_fringe_data): Move decl from here ...
4819 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4820 to check its interface.
4821 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4822
a5c0af81 4823 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4824 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4825 (fontset_font): Mark local as initialized.
a9a06e0b 4826 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4827
b4716021
PE
4828 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4829
811e9bac 4830 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4831 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4832 (x_own_selection, Fx_disown_selection_internal): Rename locals
4833 to avoid shadowing.
4834 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4835
7e3ab302
PE
4836 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4837 so that the caller can use some name other than gcpro1.
4838 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4839 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4840 (Fx_backspace_delete_keys_p):
4841 Use them to avoid shadowing, and rename vars to avoid shadowing.
4842 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4843 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4844 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4845 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4846 Remove unused locals.
7e3ab302
PE
4847 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4848 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4849 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4850 macros.
f78faa98 4851
e2b13473
PE
4852 * xterm.h (x_mouse_leave): New decl.
4853
77f23912
PE
4854 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4855 Remove unused functions.
cdf4ba58
PE
4856 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4857 (x_calc_absolute_position): Now static.
7411c686 4858 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4859 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4860 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4861 unless they are used.
38d0b34a
PE
4862 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4863 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4864 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4865 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4866 (x_error_catcher, x_connection_closed, x_error_handler):
4867 (x_error_quitter, xembed_send_message, x_iconify_frame):
4868 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4869 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4870 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4871
44f230aa
SM
4872 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4873 Rename or move locals to avoid shadowing.
6b463e58 4874 (tty_defined_color, merge_face_heights): Now static.
5967d051 4875 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4876 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4877 does not deduce is never used uninitialized.
73719eba
PE
4878 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4879 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4880
426994c3 4881 * terminal.c (store_terminal_param): Now static.
5489860b 4882
032f1620 4883 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4884 (set_frame_menubar): Remove unused local.
d4323972 4885 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4886 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4887 since they might point to immutable storage.
281585b0
PE
4888 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4889 since it's unused otherwise.
032f1620 4890
367c19e5 4891 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4892 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4893 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4894 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4895 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4896 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4897 does not deduce are never used uninitialized.
70739cbe 4898
07b48fa9
PE
4899 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4900
8868a238 4901 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4902 * window.c (window_loop, size_window):
4903 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4904
7e5cf297 4905 * window.c (display_buffer): Now static.
d6550a9f
PE
4906 (size_window): Mark variables that gcc -Wuninitialized
4907 does not deduce are never used uninitialized.
a586633d
PE
4908 * window.h (check_all_windows): New decl, to forestall
4909 gcc -Wmissing-prototypes diagnostic.
5b555da1 4910 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4911
f6095868
PE
4912 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4913 shadowing.
4914 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4915 Include <limits.h>.
4916 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4917 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4918 (load_charset_map): Mark variables that gcc -Wuninitialized
4919 does not deduce are never used uninitialized.
53df7c11 4920 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4921
f38b440c
PE
4922 * coding.c (coding_set_source, coding_set_destination):
4923 Use "else { /* comment */ }" rather than "else /* comment */;"
4924 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4925 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4926 a block, when the outer 'i' will do.
4927 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4928 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4929 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4930 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4931 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4932 Rename locals to avoid shadowing.
4933 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4934 * coding.c (emacs_mule_char, encode_invocation_designation):
4935 Now static, since they're not used elsewhere.
413bb2db 4936 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4937 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4938 (decode_coding_emacs_mule): Mark variables that gcc
4939 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4940 (detect_coding_iso_2022): Initialize a local variable that might
4941 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4942 this initialization is needed. (Bug#8211)
5f58e762
PE
4943 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4944 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4945 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4946 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4947 Remove unused macros.
f38b440c 4948
232b38b9 4949 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4950 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4951 * character.c (string_count_byte8): Likewise.
232b38b9 4952
fb90da1b
PE
4953 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4954 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4955
fb93dbc2
PE
4956 * chartab.c (copy_sub_char_table): Now static, since it's not used
4957 elsewhere.
5c156ace
PE
4958 (sub_char_table_ref_and_range, char_table_ref_and_range):
4959 Rename locals to avoid shadowing.
bbcd0949 4960 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4961
7d3b3862 4962 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4963 (BIDI_BOB): Remove unused macro.
7d3b3862 4964
6be7d3da
PE
4965 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4966 deduce are never used uninitialized.
c2ed9c8b 4967 * term.c (encode_terminal_code): Likewise.
6be7d3da 4968
75f8807f 4969 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4970
50938595
PE
4971 * tparam.h: New file.
4972 * term.c, tparam.h: Include it.
4973 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4974 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4975 Move these decls to tparam.h, and make them agree with what
4976 is actually in tparam.c. The previous trick of using incompatible
4977 decls in different modules does not conform to the C standard.
4978 All callers of tparam changed to use tparam's actual API.
4979 * tparam.c (tparam1, tparam, tgoto):
4980 Use const pointers where appropriate.
4981
fbceeba2
PE
4982 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4983 * cm.h (struct cm): Likewise.
4984 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4985 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4986 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4987 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4988 (turn_on_face, init_tty): Likewise.
4989 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4990
7f3f1250
PE
4991 * term.c (term_mouse_position): Rename local to avoid shadowing.
4992
e6ca6543
PE
4993 * alloc.c (mark_ttys): Move decl from here ...
4994 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4995
c40f8d15
AS
49962011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4997
4998 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4999
cfe0661d
JB
50002011-03-09 Juanma Barranquero <lekktu@gmail.com>
5001
5002 * search.c (compile_pattern_1): Remove argument regp, unused since
5003 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5004 (compile_pattern): Don't pass it.
5005
0afb4571
J
50062011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5007
5008 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5009 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5010 for ! HAVE_GTK3.
5011 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5012
5013 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5014
5015 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5016 gdk_window_get_screen, gdk_window_get_geometry,
5017 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5018 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5019 (xg_get_pixbuf_from_pixmap): New function.
5020 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5021 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5022 Call xg_get_pixbuf_from_pixmap instead of
5023 gdk_pixbuf_get_from_drawable.
5024 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5025 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5026 (xg_check_special_colors): Use GtkStyleContext and its functions
5027 for HAVE_GTK3.
5028 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5029 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5030 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5031 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5032 Call gtk_widget_get_preferred_size.
0afb4571
J
5033 (xg_frame_resized): gdk_window_get_geometry only takes 5
5034 parameters.
44f230aa
SM
5035 (xg_win_to_widget, xg_event_is_for_menubar):
5036 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5037 (xg_set_widget_bg): New function.
5038 (delete_cb): New function.
895009e1 5039 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5040 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5041 (xg_set_background_color): Call xg_set_widget_bg.
5042 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5043 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5044 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5045 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5046 if ! HAVE_GTK3.
5047 (update_frame_tool_bar): Call gtk_widget_hide.
5048 (xg_initialize): Use GDK_KEY_g.
5049
5050 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5051 if ! HAVE_GTK3
5052 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5053
5054 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5055 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5056 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5057
1c2cc4ef
JB
50582011-03-08 Juanma Barranquero <lekktu@gmail.com>
5059
5060 * w32xfns.c (select_palette): Check success of RealizePalette against
5061 GDI_ERROR, not zero.
5062
33383987 5063See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5064
5065;; Local Variables:
5066;; coding: utf-8
aac0c6e3
MR
5067;; End:
5068
33383987 5069 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5070
5071 This file is part of GNU Emacs.
5072
5073 GNU Emacs is free software: you can redistribute it and/or modify
5074 it under the terms of the GNU General Public License as published by
5075 the Free Software Foundation, either version 3 of the License, or
5076 (at your option) any later version.
5077
5078 GNU Emacs is distributed in the hope that it will be useful,
5079 but WITHOUT ANY WARRANTY; without even the implied warranty of
5080 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5081 GNU General Public License for more details.
5082
5083 You should have received a copy of the GNU General Public License
5084 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.