* frame.c (tty_frame_count): Now printmax_t, not int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62f19c19
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2ea16b89
PE
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
9d1df220
PE
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
33ef5c64
PE
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
66c6fdd5
PE
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
d749b01b
PE
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
b5cd1905
PE
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
c21721cc
PE
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
51
c57b67fc
PE
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
54
8a401434
PE
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
63 not fit in int.
64
5fc295a4 652011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 66
70c60eb2 67 Integer and memory overflow issues (Bug#9196).
726e0ab1 68
d31850da
PE
69 * doc.c (get_doc_string): Rework so that
70 get_doc_string_buffer_size is the actual buffer size, rather than
71 being 1 less than the actual buffer size; this makes xpalloc more
72 convenient.
73
a69fbedb
PE
74 * image.c (x_allocate_bitmap_record, cache_image):
75 * xselect.c (Fx_register_dnd_atom):
76 Simplify previous changes by using xpalloc.
77
fe5c5d37
PE
78 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
79 since either will do and ptrdiff_t is convenient with xpalloc.
80
0065d054
PE
81 * charset.c (charset_table_size)
82 (struct charset_sort_data.priority): Now ptrdiff_t.
83 (charset_compare): Don't overflow if priorities differ greatly.
84 (Fsort_charsets): Don't assume list length fits in int.
85 Check for size-calculation overflow when allocating sort data.
86 (syms_of_charset): Allocate an initial charset table that is
87 just under 64 KiB, to avoid problems with glibc malloc and mmap.
88
89 * cmds.c (internal_self_insert): Check for size-calculation overflow.
90
91 * composite.h (struct composition.glyph_len): Now int, not unsigned.
92 The actual value is always <= INT_MAX, and leaving it unsigned made
93 overflow checking harder.
94
95 * dispextern.h (struct glyph_matrix.rows_allocated)
96 (struct face_cache.size): Now ptrdiff_t, for convenience in use
97 with xpalloc. The values are still always <= INT_MAX.
98
99 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
100
101 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
102 (SAFE_NALLOCA): New macro.
103
104 * region-cache.c (struct boundary.pos, find_cache_boundary)
105 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
106 (set_cache_region, invalidate_region_cache)
107 (revalidate_region_cache, know_region_cache, region_cache_forward)
108 (region_cache_backward, pp_cache):
109 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
110 so that ptrdiff_t * can be passed to xpalloc.
111 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
112 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
113 (pp_cache): Don't assume cache_len fits in int.
114 * region-cache.h: Adjust extern decls to match.
115
116 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
117 EMACS_INT, since either will do, for xpalloc.
118
119 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
120 (xnmalloc, xnrealloc, xpalloc): New functions.
121
726e0ab1
PE
122 * bidi.c (bidi_shelve_header_size): New constant.
123 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
124 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
125
51f30bc5 126 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
127 * buffer.c (overlays_at, overlays_in, record_overlay_string)
128 (overlay_strings):
129 Don't update size of array until after memory allocation succeeds,
130 because xmalloc/xrealloc may not return.
0065d054
PE
131 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
132 now that we have proper integer overflow checking.
133 (record_overlay_string, overlay_strings): Catch overflows when
134 calculating size of overlay_str_buf.
726e0ab1 135
0065d054
PE
136 * callproc.c (Fcall_process): Check for size overflow when
137 calculating size of args2.
138 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
139 Normally we prefer signed values, but sticking with ptrdiff_t would
140 require adding more-complicated checks.
726e0ab1
PE
141
142 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
143 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
144 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 145 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
146
147 * character.c (Fstring): Check for size-calculation overflow.
148
149 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
150 unnecessary integer overflow. Check for size overflow.
151 (encode_coding_object): Don't update size until xmalloc succeeds.
152
153 * composite.c (get_composition_id): Check for overflow in glyph
154 length calculations.
155
156 Integer and memory overflow fixes for display code.
157 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
158 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
159 (scrolling_window): Check for overflow in size calculations.
160 (line_draw_cost, realloc_glyph_pool, add_row_entry):
161 Don't assume glyph table len fits in int.
162 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
163 (row_table_size): Now ptrdiff_t, not int.
164 (scrolling_window): Avoid overflow in size calculations.
165 Don't update size until allocation succeeds.
166 * fns.c (concat): Check for overflow in size calculations.
167 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
168 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
169 (NEXT_ALMOST_PRIME_LIMIT): New constant.
170
171 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
172 (get_doc_string): Check for size calculation overflow.
173 Don't update size until allocation succeeds.
174 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
175 EMACS_INT, where ptrdiff_t will do.
176 (Fsubstitute_command_keys): Check for string overflow.
177
178 * editfns.c (set_time_zone_rule): Don't assume environment length
179 fits in int.
180 (message_length): Now ptrdiff_t, not int.
181 (Fmessage_box): Don't update size until allocation succeeds.
182 Don't assume message length fits in int.
183 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
184
0065d054
PE
185 * emacs.c (main): Do not reallocate argv, since there is a null at
186 the end that can be overwritten, and this way there's no need to
187 worry about size-calculation overflow.
188 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
189
190 * eval.c (init_eval_once, grow_specpdl): Don't update size until
191 alloc succeeds.
192 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
193
194 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
195 (x_set_scroll_bar_width, x_figure_window_size):
196 Check for integer overflow.
197 (x_set_alpha): Do not assume XINT fits in int.
198
199 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
200 This is for the members text_lines, text_cols, total_lines, total_cols,
201 where the system imposes an 'int' limit.
202
203 * fringe.c (Fdefine_fringe_bitmap):
204 Don't update size until alloc works.
205
206 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
207 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
208
209 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
210 Check for size-calculation overflow.
211 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
212 do, as we prefer signed integers.
213 (id_to_widget.max_size, id_to_widget.used)
214 (xg_store_widget_in_map, xg_remove_widget_from_map)
215 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
216 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
217 Use and return ptrdiff_t, not int.
218 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
219 * gtkutil.h: Change prototypes to match the above.
220
221 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
222 are duplicate now that they've been promoted to lisp.h.
223 (x_allocate_bitmap_record, x_alloc_image_color)
224 (make_image_cache, cache_image, xpm_load):
225 Don't update size until alloc is done.
226 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
227 (x_detect_edges):
3256efce 228 Check for size calculation overflow.
726e0ab1
PE
229 (ct_colors_allocated_max): New constant.
230 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
231 overflow.
3256efce 232
726e0ab1
PE
233 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
234 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
235 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
236 Use ptrdiff_t, not int, to count maps.
237 (read_char_minibuf_menu_prompt): Check for overflow in size
238 calculations. Don't update size until allocation succeeds. Redo
239 calculations to avoid overflow.
240 * keyboard.h: Change prototypes to match the above.
241
242 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
243 to count maps.
244 (current_minor_maps): Check for size calculation overflow.
245 * keymap.h: Change prototypes to match the above.
246
247 * lread.c (read1, init_obarray): Don't update size until alloc done.
248
249 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
250 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
251
726e0ab1
PE
252 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
253 Now ptrdiff_t, not int.
254 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
255 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
256
257 * process.c (Fnetwork_interface_list): Check for overflow
258 in size calculation.
259
260 * region-cache.c (move_cache_gap): Check for size calculation overflow.
261
262 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
263 overflow. Don't bother calling xmalloc when xrealloc will do.
264
265 * search.c (Freplace_match): Check for size calculation overflow.
266 (Fset_match_data): Don't assume list lengths fit in 'int'.
267
268 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
269 for command line length. Do not attempt to address one before the
270 beginning of an array, as that's not portable.
271
272 * term.c (max_frame_lines): Remove; unused.
273 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
274 not int.
275 (encode_terminal_code, calculate_costs): Check for size
276 calculation overflow.
277 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
278 table lengths and related sizes. Don't update size until alloc
279 done. Redo calculations to avoid overflow.
280 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
281
282 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
283 subtracting pointers.
284 (gobble_line): Check for overflow more carefully. Don't update size
285 until alloc done.
286
287 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
288 Don't update size until alloc done.
289 Redo size calculations to avoid overflow.
290 Check for size calculation overflow.
0065d054 291 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
292
293 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
294 Use ptrdiff_t, not int, for sizes.
295 (store_mode_line_noprop_char): Don't update size until alloc done.
296
0065d054
PE
297 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
298 Use ptrdiff_t, not int, for sizes.
299 (Finternal_make_lisp_face, cache_face):
300 Check for size calculation overflow.
301 (cache_face): Treat size calculation overflows as if they were
302 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
303
304 * xfns.c (x_encode_text, x_set_name_internal)
305 (Fx_change_window_property): Use ptrdiff_t, not int, to count
306 sizes, since they can exceed INT_MAX in size. Check for size
307 calculation overflow.
308
0065d054
PE
309 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
310 (xg_select): Check for size calculation overflow.
726e0ab1
PE
311 Don't update size until alloc done.
312
0065d054 313 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 314 as sprintf is limited to int lengths.
1d526e2f 315
252c5ee1
PE
316 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
317 (X_LONG_MIN): New macros.
864d7ce7
PE
318 Use them to make the following changes clearer.
319 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
320 This change doesn't affect the value now, but it may help remind
321 future maintainers not to raise the value too much later.
322 (SELECTION_QUANTUM): Remove, replacing with ...
323 (selection_quantum): ... new function, which avoids overflow.
324 All uses changed.
325 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
326 assumption that selection length fits in 'int'.
327 (x_reply_selection_request, x_handle_selection_request)
328 (x_get_window_property, receive_incremental_selection)
329 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
330 (lisp_data_to_selection_data, clean_local_selection_data):
331 Use ptrdiff_t, not int, to record length of selection.
332 (x_reply_selection_request, x_get_window_property)
333 (receive_incremental_selection, x_property_data_to_lisp):
334 Redo calculations to avoid overflow.
335 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 336 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
337 something.
338 (x_get_window_property, receive_incremental_selection)
339 (lisp_data_to_selection_data, x_property_data_to_lisp):
340 Check for size-calculation overflow.
341 (x_get_window_property, receive_incremental_selection)
342 (lisp_data_to_selection_data, Fx_register_dnd_atom):
343 Don't store size until memory allocation succeeds.
344 (x_get_window_property): Plug memory leak on memory exhaustion.
345 Don't double-block input; malloc is safe here. Don't assume 2**34
346 - 4 fits in unsigned long. Add an xassert to check
347 XGetWindowProperty overflow. Be more careful about overflow
348 calculations, and distinguish size from memory overflow better.
349 (receive_incremental_selection): When tracing, don't assume
350 unsigned int is less than INT_MAX.
351 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
352 harmful) conversions of unsigned short to int.
353 (lisp_data_to_selection_data): Don't assume that integers
354 in the range -65535 through -1 fit in an X unsigned short.
355 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
356 result parameters unless successful. Rely on cons_to_unsigned
357 to report problems with elements; the old code wasn't right anyway.
358 (x_check_property_data): Check for int overflow; we cannot use
359 a wider type due to X limits.
360 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
361
726e0ab1 362 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 363
0065d054
PE
364 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
365 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
366 (x_color_cells): Don't store size until memory allocation succeeds.
367 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 368 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
369 (x_term_init): Don't assume length fits in int (sprintf is limited
370 to int size).
bc18e09d 371
ebfa62c0
PE
372 Use ptrdiff_t for composition IDs.
373 * character.c (lisp_string_width):
374 * composite.c (composition_table_size, n_compositions)
375 (get_composition_id, composition_gstring_from_id):
376 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
377 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
378 * window.c (Frecenter):
379 Use ptrdiff_t, not int, for composition IDs.
380 * composite.c (get_composition_id): Check for integer overflow.
381 * composite.h: Adjust prototypes to match the above changes.
382
d3411f89
PE
383 Use ptrdiff_t for hash table indexes.
384 * category.c (hash_get_category_set):
385 * ccl.c (ccl_driver):
386 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
387 * coding.c (coding_system_charset_list, detect_coding_system):
388 * coding.h (struct coding_system.id):
389 * composite.c (get_composition_id, gstring_lookup_cache):
390 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
391 * image.c (xpm_get_color_table_h):
392 * lisp.h (hash_lookup, hash_put):
393 * minibuf.c (Ftest_completion):
394 Use ptrdiff_t for hash table indexes, not int (which is too
395 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
396 32-bit --with-wide-int hosts).
397
e097a6fa
PE
398 * charset.c (Fdefine_charset_internal): Check for integer overflow.
399 Add a FIXME comment about memory leaks.
400 (syms_of_charset): Don't assume xmalloc returns.
401
5637687f
PE
402 Don't assume that stated character widths fit in int.
403 * character.c (Fchar_width, c_string_width, lisp_string_width):
404 * character.h (CHAR_WIDTH):
405 * indent.c (MULTIBYTE_BYTES_WIDTH):
406 Use sanitize_char_width to avoid undefined and/or bad behavior
407 with outlandish widths.
408 * character.h (sanitize_tab_width): Renamed from sanitize_width,
409 now that we have two such functions. All uses changed.
410 (sanitize_char_width): New inline function.
411
a2271ba2
PE
412 Don't assume that tab-width fits in int.
413 * character.h (sanitize_width): New inline function.
414 (SANE_TAB_WIDTH): New macro.
415 (ASCII_CHAR_WIDTH): Use it.
416 * indent.c (sane_tab_width): Remove. All uses replaced by
417 SANE_TAB_WIDTH (current_buffer).
418 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
419
18c52557
PE
420 * fileio.c: Integer overflow issues with file modes.
421 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
422
caeeedc1
PE
423 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
424 Remove unreachable code.
425 (read_hex, load_charset_map_from_file): Check for integer overflow.
426
50849c52
PE
427 * xterm.c: don't go over XClientMessageEvent limit
428 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
429 (x_send_scroll_bar_event): Likewise. Check that the size does not
430 exceed limits imposed by XClientMessageEvent, as well as the usual
431 ptrdiff_t and size_t limits.
432
b13995db
PE
433 * keyboard.c: Overflow, signedness and related fixes.
434 (make_lispy_movement): Use same integer type in forward decl
435 that is used in the definition.
436 (read_key_sequence, keyremap_step):
437 Change bufsize argument back to int, undoing my 2011-03-30 change.
438 We prefer signed types, and int is wide enough here.
439 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
440 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
441 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
442 length, not size_t. Use ptrdiff_t for index, not int.
443 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
444 possibility of integer overflow.
445
13464394
PE
446 Overflow, signedness and related fixes for images.
447
448 * dispextern.h (struct it.stack[0].u.image.image_id)
449 (struct_it.image_id, struct image.id, struct image_cache.size)
450 (struct image_cache.used, struct image_cache.ref_count):
451 * gtkutil.c (update_frame_tool_bar):
452 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
453 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
454 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
455 * nsmenu.m (update_frame_tool_bar):
456 * xdisp.c (calc_pixel_width_or_height):
457 * xfns.c (image_cache_refcount):
458 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
459 on typical 64-bit hosts.
460
461 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
462 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
463 Omit unnecessary casts to int.
464 (parse_image_spec): Check that integers fall into 'int' range
465 when the callers expect that.
466 (image_ascent): Redo ascent calculation to avoid int overflow.
467 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
468 (lookup_image): Remove unnecessary tests.
469 (xbm_image_p): Locals are now of int, not EMACS_INT,
470 since parse_image_check makes sure they fit into int.
471 (png_load, gif_load, svg_load_image):
472 Prefer int to unsigned where either will do.
473 (tiff_handler): New function, combining the cores of the
474 old tiff_error_handler and tiff_warning_handler. This
475 function is rewritten to use vsnprintf and thereby avoid
476 stack buffer overflows. It uses only the features of vsnprintf
477 that are common to both POSIX and native Microsoft.
478 (tiff_error_handler, tiff_warning_handler): Use it.
479 (tiff_load, gif_load, imagemagick_load_image):
480 Don't assume :index value fits in 'int'.
481 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
482 (imagemagick_load_image): Check that crop parameters fit into
483 the integer types that MagickCropImage accepts. Don't assume
484 Vimagemagick_render_type has a nonnegative value. Don't assume
485 size_t fits in 'long'.
486 (gs_load): Use printmax_t to print the widest integers possible.
487 Check for integer overflow when computing image height and width.
488
c11821d4
EZ
4892011-08-26 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (redisplay_window): Don't force window start if point
492 will be invisible in the resulting window. (Bug#9324)
493
0c95fcf7
EZ
4942011-08-25 Eli Zaretskii <eliz@gnu.org>
495
496 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
497 the display spec is of the form `(space ...)'.
498 (handle_display_spec): Return the value returned by
499 handle_single_display_spec, not just 1 or zero.
500 (handle_single_display_spec): If the display spec is of the form
501 `(space ...)', and specifies display in the text area, return 2
502 rather than 1.
fee65a97 503 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
504 accurately, and prefer exact match for point under bidi. Don't
505 advance `row' beyond the last row of the window.
0c95fcf7
EZ
506
507 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
508 into disp_prop; all users changed.
509
510 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
511 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
512 for the text covered by the display property.
513
e4ed06f1
CY
5142011-08-25 Chong Yidong <cyd@stupidchicken.com>
515
516 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
517 Change return value to nil.
518 (Frecord_buffer): Delete unused function.
519
f67cdd7f
EZ
5202011-08-24 Eli Zaretskii <eliz@gnu.org>
521
5980d4c6
EZ
522 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
523 buffers, return left-to-right.
8610fe8b
EZ
524 (set_cursor_from_row): Consider candidate row a win if its glyph
525 represents a newline and point is on that newline. Fixes cursor
526 positioning on the newline at EOL of R2L text within L2R
527 paragraph, and vice versa.
528 (try_cursor_movement): Check continued rows, in addition to
529 continuation rows. Fixes unwarranted scroll when point enters a
530 continued line of R2L text within an L2R paragraph, or vice versa.
531 (cursor_row_p): Consider the case of point being equal to
532 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
533 from the end of a short line to the beginning of a continued line
534 of R2L text within L2R paragraph.
535 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
536 composed characters.
5980d4c6 537
f67cdd7f
EZ
538 * bidi.c (bidi_check_type): Use xassert.
539 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
540 members.
541
bca633fb
EZ
5422011-08-23 Eli Zaretskii <eliz@gnu.org>
543
544 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
545 a character.
546
4a5885a7
CY
5472011-08-23 Chong Yidong <cyd@stupidchicken.com>
548
549 * nsfont.m (ns_otf_to_script): Fix typo.
550
0902a04e
KH
5512011-08-22 Kenichi Handa <handa@m17n.org>
552
553 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
554 extra slot even if the purpose is char-code-property-table.
555
1a2e6670
EZ
5562011-08-23 Eli Zaretskii <eliz@gnu.org>
557
8ddde651
EZ
558 * xdisp.c (redisplay_window): When computing centering_position,
559 account for the height of the header line. (Bug#8874)
560
425cc014
EZ
561 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
562 instead of CHAR_TO_BYTE. Fixes a crash when a completion
563 candidate is selected by the mouse, and that candidate has a
564 composed character under the mouse.
565
1a2e6670
EZ
566 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
567 coordinates reported by pos-visible-in-window-p for a composed
568 character in column zero.
569
8b76d6f8
SM
5702011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
571
572 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
573
dac347dd
EZ
5742011-08-22 Eli Zaretskii <eliz@gnu.org>
575
576 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
577 consider it a hit if to_charpos is anywhere in the range of the
578 composed buffer positions.
579
e013fb34
CY
5802011-08-22 Chong Yidong <cyd@stupidchicken.com>
581
582 * image.c (gif_load): Don't assume that each subimage has the same
583 dimensions as the base image. Handle disposal method that is
584 "undefined" by the gif spec (Bug#9335).
585
bd1ba3e8
CY
5862011-08-20 Chong Yidong <cyd@stupidchicken.com>
587
588 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 589 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 590
54a1215b
EZ
5912011-08-19 Eli Zaretskii <eliz@gnu.org>
592
823564e5
EZ
593 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
594 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
595 from an Org mode buffer to a Speedbar frame.
596
54a1215b
EZ
597 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
598 a composition, take its buffer position from IT->cmp_it.charpos.
599 Fixes cursor positioning at the beginning of a line that begins
600 with a composed character.
601
9778ebcc
EZ
6022011-08-18 Eli Zaretskii <eliz@gnu.org>
603
0be6ee06
EZ
604 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
605 character bidirectional type, use STRONG_L instead. Fixes crashes
606 in a buffer produced by `describe-categories'.
607
9778ebcc
EZ
608 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
609 members before the level stack, so they would be saved and
610 restored when copying iterator state. Fixes incorrect reordering
611 around TABs covered by display properties.
612
156bffbe
AS
6132011-08-18 Andreas Schwab <schwab@linux-m68k.org>
614
615 * process.c (Fnetwork_interface_list): Correctly determine buffer
616 size.
617
72ad093b
CY
6182011-08-17 Chong Yidong <cyd@stupidchicken.com>
619
620 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
621 (internal_condition_case_2, internal_condition_case_n):
622 Remove unnecessary aborts (Bug#9081).
72ad093b 623
35774242
EZ
6242011-08-17 Eli Zaretskii <eliz@gnu.org>
625
626 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
627 has no `load' handler, try opening the file locally. (Bug#9311)
628
db76dd85
KB
6292011-08-16 Ken Brown <kbrown@cornell.edu>
630
631 * gmalloc.c: Expand comment.
632
b215eee5
EZ
6332011-08-16 Eli Zaretskii <eliz@gnu.org>
634
635 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
636 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
637
a4579d33
KB
6382011-08-16 Ken Brown <kbrown@cornell.edu>
639
640 Fix memory allocation problems in Cygwin build (Bug#9273).
641
642 * unexcw.c ( __malloc_initialized): Declare external variable.
643 (fixup_executable): Force the dumped emacs to reinitialize malloc.
644
8b76d6f8
SM
645 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
646 New variables.
a4579d33
KB
647 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
648 dumped emacs.
649 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
650 in the static heap.
651 [CYGWIN] (special_realloc): New function.
652 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
653 requests to realloc storage in the static heap.
654
3ebec551
PE
6552011-08-15 Paul Eggert <eggert@cs.ucla.edu>
656
657 * bidi.c (bidi_initialize): Remove unused local.
658
9fd8be00
EZ
6592011-08-15 Eli Zaretskii <eliz@gnu.org>
660
474a8465
EZ
661 * biditype.h: File removed.
662
663 * bidimirror.h: File removed.
664
665 * deps.mk (bidi.o): Remove biditype.h and
666 bidimirror.h.
667
668 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
669 bidimirror.h.
670
671 * dispextern.h: Fix a typo in the comment to bidi_type_t.
672
673 * chartab.c: Improve commentary for the uniprop_table API.
674
32413314
EZ
675 * bidi.c (bidi_paragraph_init): Support zero value of
676 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
677 (bidi_initialize): Use uniprop_table instead of including
678 biditype.h and bidimirror.h.
32413314 679
9fd8be00
EZ
680 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
681 coordinates of the iterator when restoring from ppos_it.
682 (Bug#9296)
683
5cf2b69b
KH
6842011-08-14 Kenichi Handa <handa@m17n.org>
685
686 * process.c (create_process): Call setup_process_coding_systems
72ad093b 687 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 688
daf17d00
EZ
6892011-08-14 Eli Zaretskii <eliz@gnu.org>
690
691 * xdisp.c (move_it_in_display_line_to): Don't invoke
692 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
693 ppos_it. Fixes vertical cursor motion when line beginning is
694 covered by an image. (Bug#9296)
695
08e3161a
JD
6962011-08-14 Jan Djärv <jan.h.d@swipnet.se>
697
698 * nsterm.h (ns_run_ascript): Declare.
699 (NSAPP_DATA2_RUNASSCRIPT): Define.
700
701 * nsfns.m (as_script, as_result, as_status): New static variables.
702 (ns_run_ascript): New function.
703 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
704 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
705 the event loop. Get status from as_status (Bug#7276).
706
707 * nsterm.m (sendEvent): If event is NSApplicationDefined and
708 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
709 the event loop (Bug#7276).
710
a3720aa2
AS
7112011-08-14 Andreas Schwab <schwab@linux-m68k.org>
712
713 * gnutls.c (QCgnutls_bootprop_priority)
714 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
715 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
716 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
717 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
718 (QCgnutls_bootprop_verify_hostname_error)
719 (QCgnutls_bootprop_callbacks_verify): Rename from
720 Qgnutls_bootprop_..., all uses changed.
721
722 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
723 uses changed.
724
0a0d27fb
PE
7252011-08-14 Paul Eggert <eggert@cs.ucla.edu>
726
19d5c50c
PE
727 * xfaces.c (Qframe_set_background_mode): Now static.
728 * dispextern.h (Qframe_set_background_mode): Remove decl.
729
0a0d27fb
PE
730 * process.c (Fnetwork_interface_info): Declare local only if needed.
731
377538cb
JD
7322011-08-13 Jan Djärv <jan.h.d@swipnet.se>
733
734 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
735 (Fnetwork_interface_list): Allocate in increments of bytes instead
736 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
737 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
738 sockaddr.
739 (struct ifflag_def): notrailers is smart on OSX.
740 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
741 Get hardware address with getifaddrs if available.
742
08fff70c
EZ
7432011-08-12 Eli Zaretskii <eliz@gnu.org>
744
745 * xdisp.c (iterate_out_of_display_property): xassert that
746 IT->position is set to within IT->object's boundaries. Break from
747 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
748 when IT->position is set up wrongly due to some bug.
749 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
750 (push_display_prop): Allow GET_FROM_STRING as IT->method on
751 entry. Force push_it to save on the stack the current
752 buffer/string position, to be restored by pop_it. Fix flags in
753 the iterator structure wrt the object coming from a display
754 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
755 properties. (Bug#9284)
756
7be1c708 7572011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 758
7be1c708
CY
759 * fontset.c (fontset_get_font_group): Add proper type checks.
760 (Bug#9172)
aac0c6e3 761
7be1c708 7622011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 763
7be1c708
CY
764 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
765 and LC_VERSION_MIN_MACOSX.
766 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
767 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 768
97bb72a6
EZ
7692011-08-08 Eli Zaretskii <eliz@gnu.org>
770
771 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
772 no-display-properties-and-no-overlays under bidi display.
773 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 774 properties and overlays.
97bb72a6 775
d5617611
CY
7762011-08-08 Chong Yidong <cyd@stupidchicken.com>
777
37e11a63
CY
778 * editfns.c (Fset_time_zone_rule): Document relationship with the
779 setenv function.
780
d5617611
CY
781 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
782 the font entity extracted from the cache (Bug#8109).
783
58872834
CY
7842011-08-07 Chong Yidong <cyd@stupidchicken.com>
785
786 * composite.c (autocmp_chars): Don't reset point. That is done by
787 restore_point_unwind (Bug#5984).
788
75bfc667
JL
7892011-08-07 Juri Linkov <juri@jurta.org>
790
791 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
792 to show the arg `TIME' instead of `TIMEVAL'.
793
d1410150
EZ
7942011-08-06 Eli Zaretskii <eliz@gnu.org>
795
796 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
797 display property strides EOL and includes a newline, as in
798 longlines-mode. (Bug#9254)
75b771e4
EZ
799 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
800 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
801
802 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
803 is non-zero, even if the data buffer is NULL. Fixes a crash in
804 vertical-motion with longlines-mode. (Bug#9254)
805
35928349
EZ
8062011-08-05 Eli Zaretskii <eliz@gnu.org>
807
ec7cc85b
EZ
808 * bidi.c <bidi_cache_total_alloc>: Now static.
809 (bidi_initialize): Initialize bidi_cache_total_alloc.
810
8b76d6f8 811 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
812 cache. (Bug#9221)
813
814 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
815 amount allocated this far in `bidi_cache_total_alloc'.
816 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
817 non-zero, only free the data buffer without restoring the cache
818 contents. All callers changed.
819
820 * dispextern.h (bidi_unshelve_cache): Update prototype.
821
822 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
823 (move_it_in_display_line, move_it_to)
824 (move_it_vertically_backward, move_it_by_lines): Replace the call
825 to xfree to an equivalent call to bidi_unshelve_cache.
826 (move_it_in_display_line_to): Fix logic of returning
412b6358 827 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 828
e2e2423b
EZ
8292011-08-05 Eli Zaretskii <eliz@gnu.org>
830
831 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
832 came from a string character with a `cursor' property. (Bug#9229)
833
ae9e757a
JD
8342011-08-04 Jan Djärv <jan.h.d@swipnet.se>
835
836 * Makefile.in (LIB_PTHREAD): New variable.
837 (LIBES): Add LIB_PTHREAD (Bug#9216).
838
839 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
840 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
841
213bd7f2
AS
8422011-08-04 Andreas Schwab <schwab@linux-m68k.org>
843
844 * regex.c (re_iswctype): Remove some redundant boolean
845 conversions.
846
99aaf75f
JD
8472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
848
849 * xterm.c (x_find_topmost_parent): New function.
850 (x_set_frame_alpha): Find topmost parent window with
851 x_find_topmost_parent and set the property there also (bug#9181).
852 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
853
c74e9d86
PE
8542011-08-04 Paul Eggert <eggert@cs.ucla.edu>
855
856 * callproc.c (Fcall_process): Avoid vfork clobbering
857 the local vars buffer, coding_systems, current_dir.
858
640c8776
SM
8592011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
860
861 * keymap.c (Fmake_composed_keymap): Move to subr.el.
862
f26d0e4c
PE
8632011-08-03 Paul Eggert <eggert@cs.ucla.edu>
864
8a10d76c
PE
865 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
866 so that it is not optimized away.
867
f26d0e4c
PE
868 * xdisp.c (compute_display_string_pos): Remove unused local.
869
55439c61
EZ
8702011-08-02 Eli Zaretskii <eliz@gnu.org>
871
872 Fix slow cursor motion and scrolling in large buffers with
873 selective display, like Org Mode buffers. (Bug#9218)
874
875 * dispextern.h (struct bidi_it): New member disp_prop_p.
876
877 * xdisp.c: Remove one-slot cache of display string positions.
878 (compute_display_string_pos): Accept an additional argument
879 DISP_PROP_P; callers changed. Scan at most 5K characters forward
880 for a display string or property. If found, set DISP_PROP_P
881 non-zero.
882
883 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
884 DISP_PROP_P, and pass it to compute_display_string_pos.
885 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
886 non-zero. All callers of bidi_fetch_char changed.
887
fb33fa43
SM
8882011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
889
890 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
891
b099e063
DM
8922010-12-03 Don March <don@ohspite.net>
893
894 * keymap.c (Fdefine_key): Fix non-prefix key error message when
895 last character M-[char] is translated to ESC [char] (bug#7541).
896
5cc7f7af
KH
8972011-08-02 Kenichi Handa <handa@m17n.org>
898
d0fffa3f 899 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
900
901 * chartab.c (uniprop_table): Make it non-static.
902
525d5e6e
EZ
9032011-08-01 Eli Zaretskii <eliz@gnu.org>
904
905 * xdisp.c (forward_to_next_line_start): Accept additional argument
906 BIDI_IT_PREV, and store into it the state of the bidi iterator had
907 on the newline.
908 (reseat_at_next_visible_line_start): Use the bidi iterator state
909 returned by forward_to_next_line_start to restore the state of
910 it->bidi_it after backing up to previous newline. (Bug#9212)
911
31011111
AS
9122011-07-30 Andreas Schwab <schwab@linux-m68k.org>
913
914 * regex.c (re_comp): Protoize.
915 (re_exec): Fix return type.
916 (regexec): Fix type of `ret'. (Bug#9203)
917
e5d76069
PE
9182011-07-29 Paul Eggert <eggert@cs.ucla.edu>
919
920 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
921 This is needed if max-image-size is a floating-point number.
922
9a79b20c
AS
9232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
924
925 * print.c (print_object): Print empty symbol as ##.
926
927 * lread.c (read1): Read ## as empty symbol.
928
d8c2fa78
AA
9292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
930
931 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
932 setting frame foreground color (Bug#9175).
933 (x_set_background_color): Likewise.
934
ffe57a7a
AA
935 * nsmenu.m (-setText): Size tooltip dimensions precisely to
936 contents (Bug#9176).
937 (EmacsTooltip -init): Remove bezels and add shadows to
938 tooltip windows.
939
bf3492a5
AA
940 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
941 or scroll bar (Bug#8470).
942
d55e9c53
AA
943 * nsfont.m (nsfont_open): Remove assignment to voffset and
944 unnecessary vars hshink, expand, hd, full_height, min_height.
945 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
946
947 * nsterm.h (nsfont_info): Remove voffset field.
948
d8c2fa78 9492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
950
951 Implement strike-through and overline on NextStep (Bug#8863).
952
953 * nsfont.m (nsfont_open): Use underline position provided by font,
954 instead of hard-coded value of 2.
955 (nsfont_draw): Call ns_draw_text_decoration instead.
956
957 * nsterm.h: Add declaration for ns_draw_text_decoration.
958
959 * nsterm.m (ns_draw_text_decoration): New function for drawing
960 underline, overline, and strike-through.
961 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
962 ns_draw_text_decoration. Change treatment of cursor drawing to
963 accomodate underlining, etc.
964
4cc60b9b
EZ
9652011-07-28 Eli Zaretskii <eliz@gnu.org>
966
bc7ece87
EZ
967 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
968 default.
4cc60b9b 969
476371c4
PE
9702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
971
66606eea
PE
972 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
973 Without this fix, if a signal arrives just after memory fills up,
974 'malloc' might be invoked reentrantly.
975
476371c4
PE
976 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
977 In other words, assume that every image size is allowed, on non-X
978 hosts. This assumption is probably wrong, but it lets Emacs compile.
979
f3fcc40d
AS
9802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
981
982 * regex.c (re_iswctype): Convert return values to boolean.
983
350c992f
EZ
9842011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
985
986 * xdisp.c (compute_display_string_pos): Don't use cached display
987 string position if the buffer had its restriction changed.
988 (Bug#9184)
989
5266b4bb
PE
9902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
991
992 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
993
2573a837 9942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 995
41f55ccd 996 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 997
39e378da
PE
998 * bidi.c: Integer size and overflow fixes.
999 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1000 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1001 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1002 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1003 (bidi_find_other_level_edge):
1004 Use ptrdiff_t instead of EMACS_INT where either will do.
1005 This works better on 32-bit hosts configured --with-wide-int.
1006 (bidi_cache_ensure_space): Check for size-calculation overflow.
1007 Use % rather than repeated addition, for better worst-case speed.
1008 Don't set bidi_cache_size until after xrealloc returns, because it
1009 might not return.
1010 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1011 (bidi_cache_ensure_space): Also check that the bidi cache size
1012 does not exceed that of the largest Lisp string or buffer. See Eli
1013 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1014
5e927815
PE
1015 * alloc.c (__malloc_size_t): Remove.
1016 All uses replaced by size_t. See Andreas Schwab's note
1017 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1018
ca4aa935
PE
1019 * image.c: Improve checking for integer overflow.
1020 (check_image_size): Assume that f is nonnull, since
1021 it is always nonnull in practice. This is one less thing to
1022 worry about when checking for integer overflow later.
1023 (x_check_image_size): New function, which checks for integer
1024 overflow issues inside X.
1025 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1026 This removes the need for a memory_full check.
1027 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1028 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1029 (xbm_read_bitmap_data): Change locals back to 'int', since
1030 their values must fit in 'int'.
1031 (xpm_load_image, png_load, tiff_load):
1032 Invoke x_create_x_image_and_pixmap earlier,
1033 to avoid much needless work if the image is too large.
1034 (tiff_load): Treat overly large images as if
1035 x_create_x_image_and_pixmap failed, not as malloc failures.
1036 (gs_load): Use x_check_image_size.
1037
5f8f9cc2
PE
1038 * gtkutil.c: Omit integer casts.
1039 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1040 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1041
5adf60bc
PE
1042 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1043
c8907a93
PE
1044 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1045 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1046 would wrongly return t on a 64-bit host.
1047
e3c25c68
PE
1048 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1049 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1050 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1051 and therefore cause GCC to emit a bogus diagnostic in some cases.
1052
3f791afe
PE
1053 * image.c: Integer signedness and overflow and related fixes.
1054 This is not an exhaustive set of fixes, but it's time to
1055 record what I've got.
1056 (lookup_pixel_color, check_image_size): Remove redundant decls.
1057 (check_image_size): Don't assume that arbitrary EMACS_INT values
1058 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1059 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1060 (tiff_load, imagemagick_load_image):
1061 Check for overflow in size calculations.
1062 (x_create_x_image_and_pixmap): Remove unnecessary test for
1063 xmalloc returning NULL; that can't happen.
1064 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1065 (xpm_color_bucket): Use better integer hashing function.
1066 (xpm_cache_color): Don't possibly over-allocate memory.
1067 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1068 (gif_memory_source):
1069 Use ptrdiff_t, not int or size_t, to record sizes.
1070 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1071 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1072 either works, as we prefer signed integers.
1073 (tiff_read_from_memory, tiff_write_from_memory):
1074 Return tsize_t, not size_t, since that's what the TIFF API wants.
1075 (tiff_read_from_memory): Don't fail simply because the read would
1076 go past EOF; instead, return a short read.
1077 (tiff_load): Omit no-longer-needed casts.
1078 (Fimagemagick_types): Don't assume size fits into 'int'.
1079
3cc5a532
PE
1080 Improve hashing quality when configured --with-wide-int.
1081 * fns.c (hash_string): New function, taken from sxhash_string.
1082 Do not discard information about ASCII character case; this
1083 discarding is no longer needed.
1084 (sxhash-string): Use it. Change sig to match it. Caller changed.
1085 * lisp.h: Declare it.
1086 * lread.c (hash_string): Remove, since we now use fns.c's version.
1087 The fns.c version returns a wider integer if --with-wide-int is
1088 specified, so this should help the quality of the hashing a bit.
1089
b312a492
PE
1090 * emacs.c: Integer overflow minor fix.
1091 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1092 Define only if GNU_LINUX.
1093 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1094
dfd153ae
PE
1095 * dispnew.c: Integer signedness and overflow fixes.
1096 Remove unnecessary forward decls, that were a maintenance hassle.
1097 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1098 All uses changed.
1099 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1100 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1101 (prepare_desired_row, line_draw_cost):
1102 Use int, not unsigned, where either works.
1103 (save_current_matrix, restore_current_matrix):
1104 Use ptrdiff_t, not size_t, where either works.
1105 (init_display): Check for overflow more accurately, and without
1106 relying on undefined behavior.
1107
a81d11a3
PE
1108 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1109 Remove, replacing with the new symbols in lisp.h. All uses changed.
1110 * fileio.c (make_temp_name):
1111 * filelock.c (lock_file_1, lock_file):
1112 * xdisp.c (message_dolog):
1113 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1114 Use pMd etc. instead.
1115 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1116 replacing the pWIDE etc. symbols removed from editfns.c.
1117
3300e6fd
PE
1118 * keyboard.h (num_input_events): Now uintmax_t.
1119 This is (very slightly) less likely to mess up due to wraparound.
1120 All uses changed.
1121
fd05c7e9
PE
1122 * buffer.c: Integer signedness fixes.
1123 (alloc_buffer_text, enlarge_buffer_text):
1124 Use ptrdiff_t rather than size_t when either will do, as we prefer
1125 signed integers.
1126
903fe15d
PE
1127 * alloc.c: Integer signedness and overflow fixes.
1128 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1129 (__malloc_size_t): Default to size_t, not to int.
1130 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1131 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1132 Prefer ptrdiff_t to size_t when either would do, as we prefer
1133 signed integers.
1134 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1135 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1136 Now const. Initialize with values that are in range even if char
1137 is signed.
1138 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1139 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1140 These functions do the right thing with sizes > 2**32.
1141 (check_depth): Now ptrdiff_t, not int.
1142 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1143 Adjust to new way of storing sizes. Check for size overflow bugs
1144 in rest of code.
1145 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1146 slightly wrong anyway, as it missed one instance of
1147 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1148 (refill_memory_reserve): Omit needless cast to size_t.
1149 (mark_object_loop_halt): Mark as externally visible.
1150
ac82cc6a
PE
1151 * xselect.c: Integer signedness and overflow fixes.
1152 (Fx_register_dnd_atom, x_handle_dnd_message):
1153 Use ptrdiff_t, not size_t, since we prefer signed.
1154 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1155 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1156 x_dnd_atoms_size and x_dnd_atoms_length.
1157
c2d1e36d
PE
1158 * doprnt.c: Prefer signed to unsigned when either works.
1159 * eval.c (verror):
1160 * doprnt.c (doprnt):
1161 * lisp.h (doprnt):
1162 * xdisp.c (vmessage):
1163 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1164 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1165 prefer signed arithmetic to avoid comparison confusion.
1166 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1167 but is a bit tricky.
1168
0e926e56
PE
1169 Assume freestanding C89 headers, string.h, stdlib.h.
1170 * data.c, doprnt.c, floatfns.c, print.c:
1171 Include float.h unconditionally.
1172 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1173 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1174 * regex.c: Likewise for stddef.h, string.h.
1175 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1176 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1177 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1178 (STDC_HEADERS): Remove obsolete defines.
1179 * sysdep.c: Include limits.h unconditionally.
1180
9cfdb3ec
PE
1181 Assume support for memcmp, memcpy, memmove, memset.
1182 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1183 * regex.c (memcmp, memcpy):
1184 Remove; we assume C89 now.
1185
1186 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1187 (__malloc_safe_bcopy): Remove; no longer needed.
1188
cf950e6b 1189 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1190 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1191 well either way, and we prefer signed to unsigned.
1192
dbf38e02
LMI
11932011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1194
1195 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1196 closes the connection while we're reading (bug#9182).
1197
d6f0886c
JD
11982011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1199
1200 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1201 are specified (Bug#9168).
1202
2eb1f9e6
PE
12032011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1206 Found by GCC static checking and --with-wide-int on a 32-bit host.
1207
22381272 12082011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1209
1210 * xdisp.c (compute_display_string_pos): Fix logic of caching
1211 previous display string position. Initialize cached_prev_pos to
1212 -1. Fixes slow-down at the beginning of a buffer.
1213
f25e39b4
EZ
12142011-07-24 Eli Zaretskii <eliz@gnu.org>
1215
1216 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1217 for attrs[LFACE_FONTSET_INDEX].
1218
04c4b52e
PE
12192011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 * xml.c (parse_region): Remove unused local
1222 that was recently introduced.
1223
c1734fbd
EZ
12242011-07-23 Eli Zaretskii <eliz@gnu.org>
1225
be18c5a5
EZ
1226 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1227 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1228
c1734fbd
EZ
1229 * xdisp.c (move_it_in_display_line_to): Record the best matching
1230 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1231 exit if none of the characters scanned was an exact match.
1232 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1233 when exact match is impossible due to invisible text, and the
1234 lines are truncated.
1235
a258d627
JD
12362011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1239 for OSX >= 10.7.
1240
b6d5a689
EZ
12412011-07-22 Eli Zaretskii <eliz@gnu.org>
1242
0f74f785
EZ
1243 Fix a significant slow-down of cursor motion with C-n, C-p,
1244 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1245 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1246 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1247 (next_element_from_buffer): Call compute_stop_pos_backwards to
1248 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1249 base_level_stop.
1250 (reseat): Don't look for prev_stop, as that could mean a very long
1251 run.
1252 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1253 <cached_disp_overlay_modiff>: Cache for last found display string
1254 position.
551918c1 1255 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1256 about the same buffer in the same area of character positions, and
1257 the buffer wasn't changed since the time the display string
1258 position was cached.
551918c1 1259
b2d0c91a
EZ
12602011-07-22 Eli Zaretskii <eliz@gnu.org>
1261
1262 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1263 is an integer, which is important for empty lines. (Bug#9149)
1264
043604ee
CY
12652011-07-22 Chong Yidong <cyd@stupidchicken.com>
1266
1267 * frame.c (Fmodify_frame_parameters): In tty case, update the
1268 default face if necessary (Bug#4238).
1269
da4adb04
CY
12702011-07-21 Chong Yidong <cyd@stupidchicken.com>
1271
1272 * editfns.c (Fstring_to_char): No need to explain what a character
1273 is in the docstring (Bug#6576).
1274
9abd0532
LMI
12752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1276
1277 * xml.c (parse_region): Make sure we always return a tree.
1278
36881d16
HK
12792011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1280
1281 * xml.c (parse_region): If a document contains only comments,
1282 return that, too.
1283
1e98674d
LMI
12842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1285
1286 * xml.c (make_dom): Return comments, too.
1287
590bd467
PE
12882011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 Port to OpenBSD.
1291 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1292 and the surrounding thread.
1293 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1294 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1295 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1296 timer goes off.
1297 * s/openbsd.h (BROKEN_SIGIO): Define.
1298 * unexelf.c (unexec) [__OpenBSD__]:
1299 Don't update the .mdebug section of the Alpha COFF symbol table.
1300
f41628b2
LMI
13012011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1302
1303 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1304 (bug#8460).
1305
b59b67c5
PE
13062011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1307
15e3a074
PE
1308 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1309 This fixes some race conditions on the permissions of any newly
1310 created file.
1311
41bed37d
PE
1312 * alloc.c (valid_pointer_p): Use pipe, not open.
1313 This fixes some permissions issues when debugging.
1314
b59b67c5
PE
1315 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1316 If fchown fails to set both uid and gid, try to set just gid,
1317 as that is sometimes allowed. Adjust the file's mode to eliminate
1318 setuid or setgid bits that are inappropriate if fchown fails.
1319
925a6be7
SM
13202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1321
1322 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1323 to compare Lisp_Objects.
1324 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1325 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1326 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1327
52968808
AS
13282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1329
0a6a104b
AS
1330 * lread.c (read_integer): Unread even EOF character.
1331 (read1): Likewise. Properly record start position of symbol.
1332
52968808
AS
1333 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1334 symbol character follows.
1335
9e381cdd
PE
13362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1339 This works around a problem with the previous change to Fcopy_file.
1340 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1341 and without this change, GCC might complain about discarding
1342 fchown's return value.
1343
b5641435
JB
13442011-07-16 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1347
a8031457
PE
13482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1351
dd889327
LMI
13522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1353
750c33f7
LMI
1354 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1355 it's used from the C level.
1356
dd889327
LMI
1357 * process.c: Use the same condition for POLL_FOR_INPUT in both
1358 keyboard.c and process.c (bug#1858).
1359
87e86684
LM
13602011-07-09 Lawrence Mitchell <wence@gmx.li>
1361
1362 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1363 (Fgnutls_boot): Use it.
1364
64348f40
AS
13652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1366
1367 * doc.c (Fsubstitute_command_keys): Revert last change.
1368
1d698799
LMI
13692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1370
f863868c
LMI
1371 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1372 quotes the next character, and doesn't affect other longer
1373 sequences (bug#8935).
1374
1d698799
LMI
1375 * lread.c (syms_of_lread): Clarify that is isn't only
1376 `eval-buffer' and `eval-defun' that's affected by
1377 `lexical-binding' (bug#8460).
1378
aa4b6df6
EZ
13792011-07-15 Eli Zaretskii <eliz@gnu.org>
1380
1381 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1382 bidi redisplay when a line includes both an image and is
1383 truncated.
1384
5d856da6
PE
13852011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1386
ad6042bb
PE
1387 Fix minor problems found by static checking.
1388 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1389 (elsz): Now a signed constant, not a size_t var. We prefer signed
1390 types to unsigned, to avoid integer comparison confusion. Without
1391 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1392 "cannot optimize loop, the loop counter may overflow", a symptom
1393 of the confusion.
f00bbb22 1394 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1395 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1396
6468f31c
LMI
13972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1398
49080b10
LMI
1399 * search.c (Fre_search_backward): Mention `case-fold-search' in
1400 all the re_search_* functions (bug#8138).
1401
6468f31c
LMI
1402 * keyboard.c (Fopen_dribble_file): Document when the file is
1403 closed (bug#8056).
1404
c965adc5
EZ
14052011-07-14 Eli Zaretskii <eliz@gnu.org>
1406
df9733bf
EZ
1407 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1408 bidi_cache_idx.
1409
0bb23927
EZ
1410 Support bidi reordering of display and overlay strings.
1411 * xdisp.c (compute_display_string_pos)
1412 (compute_display_string_end): Accept additional argument STRING.
1413 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1414 (reseat_to_string): Initialize bidi_it->string.s and
1415 bidi_it->string.schars.
1416 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1417 NULL (avoids a crash in bidi_paragraph_init).
1418 Initialize itb.string.lstring.
0bb23927
EZ
1419 (init_iterator): Call bidi_init_it only of a valid
1420 buffer position was specified. Initialize paragraph_embedding to
1421 L2R.
1422 (reseat_to_string): Initialize the bidi iterator.
1423 (display_string): If we need to ignore text properties of
1424 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1425 original value of -1 will not work with bidi.)
1426 (compute_display_string_pos): First arg is now struct
1427 `text_pos *'; all callers changed. Support display properties on
1428 Lisp strings.
1429 (compute_display_string_end): Support display properties on Lisp
1430 strings.
1431 (init_iterator, reseat_1, reseat_to_string): Initialize the
1432 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1433 when iterating on a string not from display properties).
640c8776
SM
1434 (compute_display_string_pos, compute_display_string_end):
1435 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1436 arrow keys.
1437 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1438 base_level_stop; instead, set base_level_stop to BEGV.
1439 Fixes crashes in vertical-motion.
0bb23927
EZ
1440 (next_element_from_buffer): Improve commentary for when
1441 the iterator is before prev_stop.
1442 (init_iterator): Initialize bidi_p from the default value of
1443 bidi-display-reordering, not from buffer-local value. Use the
1444 buffer-local value only if initializing for buffer iteration.
1445 (handle_invisible_prop): Support invisible properties on strings
1446 that are being bidi-reordered.
1447 (set_iterator_to_next): Support bidi reordering of C strings and
1448 Lisp strings.
1449 (next_element_from_string): Support bidi reordering of Lisp
1450 strings.
1451 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1452 (display_string): Support display of R2L glyph rows.
1453 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1454 (init_iterator): Don't initialize it->bidi_p for strings
1455 here.
1456 (reseat_to_string): Initialize it->bidi_p for strings here.
1457 (next_element_from_string, next_element_from_c_string)
1458 (next_element_from_buffer): Add xassert's for correspondence
1459 between IT's object being iterated and it->bidi_it.string
1460 structure.
1461 (face_before_or_after_it_pos): Support bidi iteration.
1462 (next_element_from_c_string): Handle the case of the first string
1463 character that is not the first one in the visual order.
1464 (get_visually_first_element): New function, refactored from common
1465 parts of next_element_from_buffer, next_element_from_string, and
1466 next_element_from_c_string.
1467 (tool_bar_lines_needed, redisplay_tool_bar)
1468 (display_menu_bar): Force left-to-right direction. Add a FIXME
1469 comment for making that be controlled by a user option.
1470 (push_it, pop_it): Save and restore the state of the
1471 bidi iterator. Save and restore the bidi_p flag.
1472 (pop_it): Iterate out of display property for string iteration as
1473 well.
1474 (iterate_out_of_display_property): Support iteration over strings.
1475 (handle_single_display_spec): Set up it->bidi_it for iteration
1476 over a display string, and call bidi_init_it.
1477 (handle_single_display_spec, next_overlay_string)
1478 (get_overlay_strings_1, push_display_prop): Set up the bidi
1479 iterator for displaying display or overlay strings.
1480 (forward_to_next_line_start): Don't use the shortcut if
1481 bidi-iterating.
1482 (back_to_previous_visible_line_start): If handle_display_prop
1483 pushed the iterator stack, restore the internal state of the bidi
1484 iterator by calling bidi_pop_it same number of times.
1485 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1486 and we are bidi-iterating, don't decrement the iterator position;
1487 instead, set the first_elt flag in the bidi iterator, to produce
1488 the same effect.
1489 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1490 (push_display_prop): xassert that we are iterating a buffer.
1491 (push_it, pop_it): Save and restore paragraph_embedding member.
1492 (handle_single_display_spec, next_overlay_string)
1493 (get_overlay_strings_1, reseat_1, reseat_to_string)
1494 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1495 correctly. Don't assume unibyte strings are not bidi-reordered.
1496 (compute_display_string_pos)
1497 (compute_display_string_end): Fix handling the case of C string.
1498 (push_it, pop_it): Save and restore from_disp_prop_p.
1499 (handle_single_display_spec, push_display_prop): Set the
1500 from_disp_prop_p flag.
1501 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1502 (pop_it): Call iterate_out_of_display_property only if we are
1503 popping after iteration over a string that came from a display
1504 property. Fix a typo in popping stretch info. Add an assertion
1505 for verifying that the iterator position is in sync with the bidi
1506 iterator.
1507 (handle_single_display_spec, get_overlay_strings_1)
1508 (push_display_prop): Fix initialization of paragraph direction for
1509 string when that of the parent object is not yet determined.
1510 (reseat_1): Call bidi_init_it to resync the bidi
1511 iterator with IT's position. (Bug#7616)
1512 (find_row_edges): If ROW->start.pos gives position
1513 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1514 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1515 Reset the from_disp_prop_p flag.
1516 (SAVE_IT, RESTORE_IT): New macros.
1517 (pos_visible_p, face_before_or_after_it_pos)
1518 (back_to_previous_visible_line_start)
1519 (move_it_in_display_line_to, move_it_in_display_line)
1520 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1521 (try_scrolling, redisplay_window, display_line): Use them when
1522 saving a temporary copy of the iterator and restoring it back.
1523 (back_to_previous_visible_line_start, reseat_1)
1524 (init_iterator): Empty the bidi cache "stack".
1525 (move_it_in_display_line_to): If iterator ended up at
1526 EOL, but we never saw any buffer positions smaller than
1527 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1528 motion in bidi-reordered lines.
1529 (move_it_in_display_line_to): Record prev_method and prev_pos
1530 immediately before the call to set_iterator_to_next. Fixes cursor
1531 motion in bidi-reordered lines with stretch glyphs and strings
1532 displayed in margins. (Bug#8133) (Bug#8867)
1533 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1534 TO_CHARPOS.
640c8776
SM
1535 (pos_visible_p): Support positions in bidi-reordered lines.
1536 Save and restore bidi cache.
0bb23927
EZ
1537
1538 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1539 (bidi_paragraph_info): Delete unused struct.
1540 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1541 (bidi_cache_start): New variable.
1542 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1543 to zero.
1544 (bidi_cache_fetch_state, bidi_cache_search)
1545 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1546 (bidi_cache_find, bidi_peek_at_next_level)
1547 (bidi_level_of_next_char, bidi_find_other_level_edge)
1548 (bidi_move_to_visually_next): Compare cache index with
1549 bidi_cache_start rather than with zero.
1550 (bidi_fetch_char): Accept new argument STRING; all callers
1551 changed. Support iteration over a string. Support strings with
1552 display properties. Support unibyte strings. Fix the type of
1553 `len' according to what STRING_CHAR_AND_LENGTH expects.
1554 (bidi_paragraph_init, bidi_resolve_explicit_1)
1555 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1556 (bidi_level_of_next_char, bidi_move_to_visually_next):
1557 Support iteration over a string.
0bb23927
EZ
1558 (bidi_set_sor_type, bidi_resolve_explicit_1)
1559 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1560 can now be zero (for strings); special values 0 and -1 were
1561 changed to -1 and -2, respectively.
1562 (bidi_char_at_pos): New function.
1563 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1564 Call it instead of FETCH_MULTIBYTE_CHAR.
1565 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1566 initialized to valid values.
1567 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1568 values.
1569 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1570 the test for valid cached positions. Fix the logic for looking up
1571 the sentinel state in the cache. GCPRO the Lisp string we are
1572 iterating.
1573 (bidi_push_it, bidi_pop_it): New functions.
1574 (bidi_initialize): Initialize the bidi cache start stack pointer.
1575 (bidi_cache_ensure_space): New function, refactored from part of
1576 bidi_cache_iterator_state. Don't assume the required size is just
1577 one BIDI_CACHE_CHUNK away.
1578 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1579 (bidi_count_bytes, bidi_char_at_pos): New functions.
1580 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1581 always valid if bidi_cache_idx is valid.
1582 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1583 is valid if it's going to be used.
1584 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1585 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1586 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1587 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1588 (bidi_find_other_level_edge, bidi_cache_start_stack):
1589 All variables related to cache indices are now EMACS_INT.
c965adc5 1590
0bb23927
EZ
1591 * dispextern.h (struct bidi_string_data): New structure.
1592 (struct bidi_it): New member `string'. Make flag members be 1-bit
1593 fields, and put them last in the struct.
640c8776
SM
1594 (compute_display_string_pos, compute_display_string_end):
1595 Update prototypes.
0bb23927
EZ
1596 (bidi_push_it, bidi_pop_it): Add prototypes.
1597 (struct iterator_stack_entry): New members bidi_p,
1598 paragraph_embedding, and from_disp_prop_p.
1599 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1600 (bidi_shelve_cache, bidi_unshelve_cache):
1601 Declare prototypes.
0bb23927
EZ
1602
1603 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1604 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1605 and vector-like objects.
1606
1607 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1608 cache around display iteration.
1609
1610 * window.c (Fwindow_end, window_scroll_pixel_based)
1611 (displayed_window_lines, Frecenter): Save and restore the bidi
1612 cache around display iteration.
1613
3bbd2265
LMI
16142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1615
1616 * editfns.c (Fdelete_region): Clarify the use of the named
1617 parameters (bug#6788).
1618
adc47434
MR
16192011-07-14 Martin Rudalics <rudalics@gmx.at>
1620
1621 * indent.c (Fvertical_motion): Set and restore w->pointm when
1622 saving and restoring the window's buffer (Bug#9006).
1623
837c31f8
LMI
16242011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1625
1626 * editfns.c (Fstring_to_char): Clarify just what is returned
1627 (bug#6576). Text by Eli Zaretskii.
1628
ac389d0c
JB
16292011-07-13 Juanma Barranquero <lekktu@gmail.com>
1630
1631 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1632
0be0ce47
EZ
16332011-07-13 Eli Zaretskii <eliz@gnu.org>
1634
1635 * buffer.c (mmap_find): Fix a typo.
1636
cd18e7e3
JB
16372011-07-13 Johan Bockgård <bojohan@gnu.org>
1638
1639 Fix execution of x selection hooks.
1640 * xselect.c (Qx_lost_selection_functions)
1641 (Qx_sent_selection_functions): New vars.
1642 (syms_of_xselect): DEFSYM them.
1643 (x_handle_selection_request): Pass Qx_sent_selection_functions
1644 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1645 (x_handle_selection_clear,x_clear_frame_selections):
1646 Pass Qx_lost_selection_functions rather than
1647 Vx_lost_selection_functions to Frun_hook_with_args.
1648
47ea7f44
PE
16492011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1650
ac389d0c 1651 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1652 The old code sometimes used this field without initializing it.
1653
47ea7f44
PE
1654 * alloc.c (gc_sweep): Don't read past end of array.
1655 In theory, the old code could also have corrupted Emacs internals,
1656 though it'd be very unlikely.
1657
bc985c87
AS
16582011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1659
1660 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1661 argument. (Bug#4026)
bc985c87 1662
0cf34688
LMI
16632011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1664
b3dadd76
LMI
1665 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1666 key" (bug#4257).
1667
0cf34688
LMI
1668 * window.c (Fset_window_start): Doc fix (bug#4199).
1669 (Fset_window_hscroll): Ditto.
1670
270768cd
PE
16712011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1672
077e3dda 1673 Fix minor new problems caught by GCC 4.6.1.
270768cd 1674 * term.c (init_tty): Remove unused local.
490011a6 1675 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1676 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1677 not used otherwise.
270768cd 1678
b1f58454
CY
16792011-07-12 Chong Yidong <cyd@stupidchicken.com>
1680
1681 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1682
22b9578d
LMI
16832011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1684
6e70ab07
LMI
1685 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1686 are the mini-buffer and the echo area (bug#3320).
1687
22b9578d
LMI
1688 * term.c (init_tty): Remove support for supdup, c10 and perq
1689 terminals, which are no longer supported (bug#1482).
1690
8974cc9f
JB
16912011-07-10 Johan Bockgård <bojohan@gnu.org>
1692
1693 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1694
a560d974
JD
16952011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1696
1697 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1698 for non-popups (Bug#3642).
1699
1dae0f0a
AS
17002011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1701
268c2c36 1702 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1703 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1704 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1705 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1706 * data.c (fmod): Likewise.
1707 * dispnew.c (swap_glyphs_in_rows): Likewise.
1708 * emacs.c (memory_warning_signal): Likewise.
1709 * floatfns.c (float_error): Likewise.
1710 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1711 (otf_open, font_otf_capability, generate_otf_features)
1712 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1713 Likewise.
1714 * image.c (pbm_read_file): Likewise.
1715 * indent.c (string_display_width): Likewise.
1716 * intervals.c (check_for_interval, search_for_interval)
1717 (inc_interval_count, count_intervals, root_interval)
1718 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1719 * lread.c (defalias): Likewise.
268c2c36 1720 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1721 * regex.c (set_image_of_range_1, set_image_of_range)
1722 (regex_grow_registers): Likewise.
1723 * sysdep.c (strerror): Likewise.
1724 * termcap.c (valid_filename_p, tprint, main): Likewise.
1725 * tparam.c (main): Likewise.
1726 * unexhp9k800.c (run_time_remap, save_data_space)
1727 (update_file_ptrs, read_header, write_header, calculate_checksum)
1728 (copy_file, copy_rest, display_header): Likewise.
1729 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1730 Likewise.
1731 * xdisp.c (check_it): Likewise.
1732 * xfaces.c (register_color, unregister_color, unregister_colors):
1733 Likewise.
1734 * xfns.c (print_fontset_result): Likewise.
1735 * xrdb.c (member, fatal, main): Likewise.
1736
99033785
PE
17372011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1738
1739 Fix minor problems found by static checking (Bug#9031).
1740 * chartab.c (char_table_set_range, map_sub_char_table):
1741 Remove unused locals.
1742 (uniprop_table): Now static.
1743 * composite.c (_work_char): Remove unused static var.
1744
9cb2ac56
JB
17452011-07-09 Juanma Barranquero <lekktu@gmail.com>
1746
1747 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1748
f25661f0
JD
17492011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1750
1751 * gtkutil.c (qttip_cb): Remove code without function.
1752
8278c4fe
EZ
17532011-07-09 Eli Zaretskii <eliz@gnu.org>
1754
1755 * w32.c (pthread_sigmask): New stub.
1756
1692ae2d 17572011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1758
8a6ebd58 1759 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1760 sigprocmask is portable only for single-threaded applications, and
1761 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1762 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1763 (LIBES): Use it.
1764 * callproc.c (Fcall_process):
1765 * process.c (create_process):
1766 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1767 Use pthread_sigmask, not sigprocmask.
123403e4 1768
1b854618
JD
17692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1770
1771 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1772 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1773 wrong (Bug#8591).
1774
3fe4b549
JD
17752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1776
0ce7e563
JD
1777 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1778 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1779 (xg_hide_tooltip): Fix comment.
1780
3fe4b549
JD
1781 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1782 in registerServicesMenuSendTypes.
1783 (validRequestorForSendType): Don't check ns_return_types.
1784
1785 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1786 ns_return_type.
1787
5df75e47
JR
17882011-07-08 Jason Rumney <jasonr@gnu.org>
1789
1790 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1791 frame struct members of non-existent frames (Bug#6284).
1792
699c10bd
JD
17932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1794
4393663b
JD
1795 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1796 variable firstTime not needed on OSX >= 10.6.
1797 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1798 >= 10.5. Use setKnobProportion, setDoubleValue.
1799
1800 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1801 (MAC_OS_X_VERSION_10_5): Define if not defined.
1802 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1803 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1804 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1805
1806 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1807 cString and lossyCString on OSX >= 10.4
1808
1809 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1810 sizeToFit on OSX >= 10.2.
1811
1812 * nsimage.m (allocInitFromFile): Don't use deprecated method
1813 bestRepresentationForDevice on OSX >= 10.6.
1814
1815 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1816 to avoid warning.
1817
1818 * emacs.c: Declare unexec_init_emacs_zone.
1819
a63e0781
JD
1820 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1821
699c10bd
JD
1822 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1823
1824 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1825 on svcsMenu (Bug#8842).
1826
1827 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1828 ns_return_types.
1829 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1830
1831 * nsterm.m (QUTF8_STRING): Declare.
1832 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1833 (validRequestorForSendType): Return type is (id).
1834 Change indexOfObjectIdenticalTo to indexOfObject.
1835 Check if we have local selection before returning self (Bug#8842).
1836 (writeSelectionToPasteboard): Put local selection into paste board
1837 if we have a local selection (Bug#8842).
1838 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1839
1840 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1841 (ns_get_local_selection): Declare.
1842
54e10184
LMI
18432011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1844
9888ff71
LMI
1845 * keymap.c (describe_map_tree): Don't insert a double newline at
1846 the end of the buffer (bug#1169) and return whether we inserted
1847 something.
1848
54e10184
LMI
1849 * callint.c (Fcall_interactively): Change "reading args" to
1850 "providing args" to try to clarify what it does (bug#1010).
1851
15fa4783
KH
18522011-07-07 Kenichi Handa <handa@m17n.org>
1853
1854 * composite.c (composition_compute_stop_pos): Ignore a static
1855 composition starting before CHARPOS (Bug#8915).
1856
1857 * xdisp.c (handle_composition_prop): Likewise.
1858
a8815b00
EZ
18592011-07-07 Eli Zaretskii <eliz@gnu.org>
1860
1861 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1862 (Bug#9015)
1863
ef7b981d 18642011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1865
1866 * character.h (unicode_category_t): New enum type.
1867
1868 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1869 (Qchar_code_property_table): New variable.
1870 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1871 (UNIPROP_COMPRESSED_FORM_P): New macros.
1872 (char_table_ascii): Uncompress the compressed values.
1873 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1874 Uncompress the compressed values.
ac389d0c 1875 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1876 (char_table_ref_and_range): Uncompress the compressed values.
1877 (sub_char_table_set): New arg is_uniprop. Callers changed.
1878 Uncompress the compressed values.
1879 (sub_char_table_set_range): Args changed. Callers changed.
1880 (char_table_set_range): Adjuted for the above change.
1881 (map_sub_char_table): Delete args default_val and parent. Add arg
1882 top. Give decoded values to a Lisp function.
640c8776 1883 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1884 values to a Lisp function. Gcpro more variables.
1885 (uniprop_table_uncompress)
1886 (uniprop_decode_value_run_length): New functions.
1887 (uniprop_decoder, uniprop_decoder_count): New variables.
1888 (uniprop_get_decoder, uniprop_encode_value_character)
1889 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1890 New functions.
1891 (uniprop_encoder, uniprop_encoder_count): New variables.
1892 (uniprop_get_encoder, uniprop_table)
1893 (Funicode_property_table_internal, Fget_unicode_property_internal)
1894 (Fput_unicode_property_internal): New functions.
1895 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1896 Sunicode_property_table_internal, Sget_unicode_property_internal,
1897 and Sput_unicode_property_internal. Defvar_lisp
1898 char-code-property-alist.
1899
640c8776 1900 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1901 Vunicode_category_table.
1902
640c8776 1903 * font.c (font_range): Adjust for the change of
c805dec0
KH
1904 Vunicode_category_table.
1905
76b397fb
DN
19062011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1907
1908 * m/iris4d.h: Remove file, move contents ...
1909 * s/irix6-5.h: ... here.
1910
22b4128e
PE
19112011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1914 * alloc.c (mark_buffer):
1915 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1916 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1917 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1918 This isn't true in general, and it's particularly not true
1919 if Emacs is configured with --with-wide-int.
1920 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1921 New macros, used in the buffer.c change.
1922
869795d6
JD
19232011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1924
1925 * xsettings.c: Use both GConf and GSettings if both are available.
1926 (store_config_changed_event): Add comment.
1927 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1928 (store_tool_bar_style_changed): New functions.
1929 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1930 (struct xsettings): Move font inside HAVE_XFT.
1931 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1932 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1933 Move inside HAVE_XFT.
640c8776 1934 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1935 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1936 also.
1937 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1938 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1939 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1940 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1941 (parse_settings): Move check for font inside HAVE_XFT.
1942 (read_settings, apply_xft_settings): Add comment.
1943 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1944 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1945 call store_font_name_changed.
1946 (xft_settings_event): Add comment.
1947 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1948 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1949 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1950 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1951 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1952 (xsettings_get_system_font, xsettings_get_system_normal_font):
1953 Add comment.
869795d6 1954
d8ed26bd
PE
19552011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 Random fixes. E.g., (random) never returned negative values.
1958 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1959 subseconds part to the entropy, as that's a bit more random.
1960 Prefer signed to unsigned, since the signedness doesn't matter and
1961 in general we prefer signed. When given a limit, use a
1962 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1963 latter isn't right if USE_2_TAGS_FOR_INTS.
1964 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1965 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1966
cabf1cac
SM
19672011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1968
1969 * textprop.c (text_property_stickiness):
1970 Obey Vtext_property_default_nonsticky.
1971 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1972 * w32fns.c (syms_of_w32fns):
1973 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1974
6e9b2be9
PE
19752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1978 This is more efficient than Ffile_directory_p and avoids a minor race.
1979
90186c68
LMI
19802011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1981
7c301272
LMI
1982 * buffer.c (Foverlay_put): Say what the return value is
1983 (bug#7835).
1984
c4f2d8d4
LMI
1985 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1986 is a directory before asking whether to use the file name
1987 (bug#7564).
ad637907
LMI
1988 (barf_or_query_if_file_exists): Make the "File is a directory"
1989 error be more correct.
c4f2d8d4 1990
90186c68
LMI
1991 * fns.c (Frequire): Remove the mention of the .gz files, since
1992 that's installation-specific, but keep the mention of
1993 `get-load-suffixes'.
1994
da64016e
PE
19952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1998 Report string overflow if the output is too long.
1999
7d47b580
JB
20002011-07-04 Juanma Barranquero <lekktu@gmail.com>
2001
a555cb87
JB
2002 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2003 (syms_of_gnutls): Remove duplicate DEFSYM for
2004 Qgnutls_bootprop_verify_hostname_error, an error for
2005 Qgnutls_bootprop_verify_error (which is no longer used).
2006
7d47b580
JB
2007 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2008 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2009 Also (re)move comments that are misplaced or no longer relevant.
2010
1e49bfab
LMI
20112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2012
2013 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2014
1485f4c0
CY
20152011-07-03 Chong Yidong <cyd@stupidchicken.com>
2016
2017 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2018 and background color parameters if they have been changed.
2019
a9ab721e
LMI
20202011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2021
2022 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2023
cf7cff57
PE
20242011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2025
2e13213d
PE
2026 * xsettings.c (SYSTEM_FONT): Define only when used.
2027 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2028
cf7cff57
PE
2029 * keymap.c (access_keymap_1): Now static.
2030
7a8e04f7
CY
20312011-07-02 Chong Yidong <cyd@stupidchicken.com>
2032
2033 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2034 leave any prefix arg for the up event (Bug#1586).
2035
61352f62
LMI
20362011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2037
69bb1ef7
LMI
2038 * lread.c (syms_of_lread): Mention single symbols defined by
2039 `defvar' or `defconst' (bug#7154).
2040
61352f62 2041 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2042 (Frequire): Mention get-load-suffixes.
61352f62 2043
28545e04
MR
20442011-07-02 Martin Rudalics <rudalics@gmx.at>
2045
2046 * window.h (window): Remove clone_number slot.
2047 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2048 Remove.
2049 (make_parent_window, make_window, saved_window)
2050 (Fset_window_configuration, save_window_save): Don't deal with
2051 clone numbers.
2052 * buffer.c (Qclone_number): Remove declaration.
2053 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2054
3349e122
SM
20552011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2056
2057 Add multiple inheritance to keymaps.
2058 * keymap.c (Fmake_composed_keymap): New function.
2059 (Fset_keymap_parent): Simplify.
2060 (fix_submap_inheritance): Remove.
2061 (access_keymap_1): New function extracted from access_keymap to handle
2062 embedded parents and handle lists of maps.
2063 (access_keymap): Use it.
2064 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2065 (Fcopy_keymap): Handle embedded parents.
2066 (Fcommand_remapping, define_as_prefix): Simplify.
2067 (Fkey_binding): Simplify.
2068 (syms_of_keymap): Move minibuffer-local-completion-map,
2069 minibuffer-local-filename-completion-map,
2070 minibuffer-local-must-match-map, and
2071 minibuffer-local-filename-must-match-map to Elisp.
2072 (syms_of_keymap): Defsubr make-composed-keymap.
2073 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2074 (parse_menu_item): Trivial simplification.
2075
3279eb87
GM
20762011-07-01 Glenn Morris <rgm@gnu.org>
2077
2078 * Makefile.in (SETTINGS_LIBS): Fix typo.
2079
4550efdf
KI
20802011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2081
2082 * coding.c (Fencode_coding_string): Record the last coding system
2083 used, as the function doc string says (bug#8738).
2084
0949d2b6
JD
20852011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2086
2087 * xsettings.c (store_monospaced_changed): Take new font as arg and
2088 check for change against current_mono_font.
2089 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2090 (emacs_settings_constructor, emacs_settings_get_property)
2091 (emacs_settings_set_property, emacs_settings_class_init)
2092 (emacs_settings_init, gsettings_obj): Remove.
2093 (something_changedCB): New function for HAVE_GSETTINGS.
2094 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2095 with value as argument.
2096 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2097 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2098 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2099 "changed".
2100
2101 * xgselect.c: Add defined (HAVE_GSETTINGS).
2102 (xgselect_initialize): Ditto.
2103
2104 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2105 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2106 xg_select.
2107
bbc6b304
PE
21082011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * eval.c (struct backtrace): Simplify and port the data structure.
2111 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2112 signed bit field, as this assumption is not portable and it makes
2113 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2114 "char debug_on_exit : 1" as this is not portable either; instead,
2115 use the portable "unsigned int debug_on_exit : 1". Remove unused
2116 member evalargs. Remove obsolete comments about cc bombing out.
2117
9851bfc5
JD
21182011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2119
51bb811f 2120 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2121 Let HAVE_GSETTINGS override HAVE_GCONF.
2122 (store_monospaced_changed): New function.
2123 (EMACS_SETTINGS): A new type derived from GObject to handle
2124 GSettings notifications.
2125 (emacs_settings_constructor, emacs_settings_get_property)
2126 (emacs_settings_set_property, emacs_settings_class_init):
2127 New functions.
2128 (gsettings_client, gsettings_obj): New variables.
2129 (GSETTINGS_SCHEMA): New define.
2130 (something_changedCB): Call store_monospaced_changed.
2131 (init_gsettings): New function.
2132 (xsettings_initialize): Call init_gsettings.
2133 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2134 to NULL.
2135
640c8776 2136 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2137 GCONF_CFLAGS/LIBS.
2138
5386012d
MR
21392011-06-29 Martin Rudalics <rudalics@gmx.at>
2140
2141 * window.c (resize_root_window, grow_mini_window)
2142 (shrink_mini_window): Rename Qresize_root_window to
2143 Qwindow_resize_root_window and Qresize_root_window_vertically to
2144 Qwindow_resize_root_window_vertically.
2145
f13e0b08
PE
21462011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2149
94515237
JB
21502011-06-27 Juanma Barranquero <lekktu@gmail.com>
2151
2152 * makefile.w32-in: Redesign dependencies so they reflect more
2153 clearly which files are directly included by each source file,
2154 and not through other includes.
2155
e43b6e43
MR
21562011-06-27 Martin Rudalics <rudalics@gmx.at>
2157
2158 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2159 (sort_overlays, overlay_strings): When an overlay's clone number
2160 matches the window's clone number process the overlay even if
2161 the overlay's window property doesn't match the current window.
2162
d68443dc
MR
2163 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2164 (Fwindow_hchild): Rename to Fwindow_left_child.
2165 (Fwindow_next): Rename to Fwindow_next_sibling.
2166 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2167 (resize_window_check): Rename to window_resize_check.
2168 (resize_window_apply): Rename to window_resize_apply.
2169 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2170 (Fdelete_other_windows_internal, resize_frame_windows)
2171 (Fsplit_window_internal, Fdelete_window_internal)
2172 (grow_mini_window, shrink_mini_window)
2173 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2174
c7e73be5
JD
21752011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2176
2177 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2178 (emacs_fixed_set_min_size): Remove.
2179 (emacs_fixed_new): Take frame as argument.
2180
2181 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2182 (_EmacsFixedPrivate): Remove minwidth/height.
2183 Add struct frame *f.
2184 (emacs_fixed_init): Initialize priv->f.
2185 (get_parent_class, emacs_fixed_set_min_size): Remove.
2186 (emacs_fixed_new): Set priv->f to argument.
2187 (emacs_fixed_get_preferred_width)
2188 (emacs_fixed_get_preferred_height): Use min_width/height from
2189 frames size_hint to set minimum and natural (Bug#8919).
2190 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2191 and use min_width/height from frames size_hint to set
2192 min_width/height (Bug#8919).
2193
2194 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2195 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2196 Fix indentation.
c7e73be5 2197
cf99dcf8
EZ
21982011-06-26 Eli Zaretskii <eliz@gnu.org>
2199
2200 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2201 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2202 called at ZV.
2203
029529ac
CY
22042011-06-26 Chong Yidong <cyd@stupidchicken.com>
2205
2206 * process.c (wait_reading_process_output): Bypass select if
2207 waiting for a cell while ignoring keyboard input, and input is
2208 pending. Suggested by Jan Djärv (Bug#8869).
2209
7a7ef429
PE
22102011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2211
2212 Use gnulib's dup2 module instead of rolling our own.
2213 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2214
11fdef7d 22152011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2216
2217 * dispnew.c (scrolling_window): Before scrolling, turn off a
2218 mouse-highlight in the window being scrolled.
2219
cd3520a4
JB
22202011-06-24 Juanma Barranquero <lekktu@gmail.com>
2221
2222 Move DEFSYM to lisp.h and use everywhere.
2223
2224 * character.h (DEFSYM): Move declaration...
2225 * lisp.h (DEFSYM): ...here.
2226
2227 * gnutls.c:
2228 * minibuf.c:
2229 * w32menu.c:
2230 * w32proc.c:
2231 * w32select.c: Don't include character.h.
2232
2233 * alloc.c (syms_of_alloc):
2234 * buffer.c (syms_of_buffer):
2235 * bytecode.c (syms_of_bytecode):
2236 * callint.c (syms_of_callint):
2237 * casefiddle.c (syms_of_casefiddle):
2238 * casetab.c (init_casetab_once):
2239 * category.c (init_category_once, syms_of_category):
2240 * ccl.c (syms_of_ccl):
2241 * cmds.c (syms_of_cmds):
2242 * composite.c (syms_of_composite):
2243 * dbusbind.c (syms_of_dbusbind):
2244 * dired.c (syms_of_dired):
2245 * dispnew.c (syms_of_display):
2246 * doc.c (syms_of_doc):
2247 * editfns.c (syms_of_editfns):
2248 * emacs.c (syms_of_emacs):
2249 * eval.c (syms_of_eval):
2250 * fileio.c (syms_of_fileio):
2251 * fns.c (syms_of_fns):
2252 * frame.c (syms_of_frame):
2253 * fringe.c (syms_of_fringe):
2254 * insdel.c (syms_of_insdel):
2255 * keymap.c (syms_of_keymap):
2256 * lread.c (init_obarray, syms_of_lread):
2257 * macros.c (syms_of_macros):
2258 * msdos.c (syms_of_msdos):
2259 * print.c (syms_of_print):
2260 * process.c (syms_of_process):
2261 * search.c (syms_of_search):
2262 * sound.c (syms_of_sound):
2263 * syntax.c (init_syntax_once, syms_of_syntax):
2264 * terminal.c (syms_of_terminal):
2265 * textprop.c (syms_of_textprop):
2266 * undo.c (syms_of_undo):
2267 * w32.c (globals_of_w32):
2268 * window.c (syms_of_window):
2269 * xdisp.c (syms_of_xdisp):
2270 * xfaces.c (syms_of_xfaces):
2271 * xfns.c (syms_of_xfns):
2272 * xmenu.c (syms_of_xmenu):
2273 * xsettings.c (syms_of_xsettings):
2274 * xterm.c (syms_of_xterm): Use DEFSYM.
2275
4228cf16
TZ
22762011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2277
cd3520a4 2278 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2279
7fcccf1e
PE
22802011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2281
7efb4e0e
PE
2282 Integer and buffer overflow fixes (Bug#8873).
2283
ff5844ad
PE
2284 * print.c (printchar, strout): Check for string overflow.
2285 (PRINTPREPARE, printchar, strout):
2286 Don't set size unless allocation succeeds.
2287
90532f02
PE
2288 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2289 for sizes. Check for string overflow more accurately.
2290 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2291
6d84508d
PE
2292 * macros.c: Integer and buffer overflow fixes.
2293 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2294 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2295 Use ptrdiff_t, not int, for sizes.
2296 Don't increment bufsize until after realloc succeeds.
2297 Check for size-calculation overflow.
2298 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2299
437b2cb4
PE
2300 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2301
8b9ac8b4
PE
2302 * lread.c: Integer overflow fixes.
2303 (read_integer): Radix is now EMACS_INT, not int,
2304 to improve quality of diagnostics for out-of-range radices.
2305 Calculate buffer size correctly for out-of-range radices.
2306 (read1): Check for integer overflow in radices, and in
2307 read-circle numbers.
82cb60d3
PE
2308 (read_escape): Avoid int overflow.
2309 (Fload, openp, read_buffer_size, read1)
2310 (substitute_object_recurse, read_vector, read_list, map_obarray):
2311 Use ptrdiff_t, not int, for sizes.
2312 (read1): Use EMACS_INT, not int, for sizes.
20270765 2313 Check for size overflow.
8b9ac8b4 2314
7fcccf1e
PE
2315 * image.c (cache_image): Check for size arithmetic overflow.
2316
bfbbd7e7
PE
2317 * lread.c: Integer overflow issues.
2318 (saved_doc_string_size, saved_doc_string_length)
2319 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2320 Now ptrdiff_t, not int.
2321 (read1): Don't assume doc string length fits in int. Check for
2322 out-of-range doc string lengths.
2323 (read_list): Don't assume file position fits in int.
39019e54 2324 (read_escape): Check for hex character overflow.
bfbbd7e7 2325
4e323265
LL
23262011-06-22 Leo Liu <sdl.web@gmail.com>
2327
2328 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2329 Move to minibuffer.el.
2330
85fece3e
PE
23312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2332
20b84ce9 2333 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2334 The following patches are for when GLYPH_DEBUG && !XASSERT.
2335 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2336 * dispnew.c (flush_stdout):
2337 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2338 Mark as externally visible.
2339 * dispnew.c (check_window_matrix_pointers): Now static.
2340 * dispnew.c (window_to_frame_vpos):
2341 * xfns.c (unwind_create_frame):
2342 * xterm.c (x_check_font): Remove unused local.
2343 * scroll.c (CHECK_BOUNDS):
2344 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2345 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2346 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2347 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2348 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2349 Now static.
2350 (debug_method_add): Use va_list and vsprintf rather than relying
2351 on undefined behavior with wrong number of arguments.
2352 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2353 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2354 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2355 since we're not interested in debugging glyphs with old libraries.
2356 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2357 GCC 4.6.0's static checking.
2358
0766b489
PE
23592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2360
31fd4b32
PE
2361 Integer overflow and signedness fixes (Bug#8873).
2362 A few related buffer overrun fixes, too.
2363
b79e8648
PE
2364 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2365
0766b489
PE
2366 * dispextern.h (struct face.stipple):
2367 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2368 (x_bitmap_mask, x_allocate_bitmap_record)
2369 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2370 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2371 (x_create_bitmap_from_xpm_data):
2372 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2373 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2374 (.bitmaps_last):
2375 * xfaces.c (load_pixmap):
2376 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2377 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2378 (.bitmaps_last, struct x_output.icon_bitmap):
2379 Use ptrdiff_t, not int, for bitmap indexes.
2380 (x_allocate_bitmap_record): Check for size overflow.
2381 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2382
b081724f
PE
2383 Use ptrdiff_t, not int, for overlay counts.
2384 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2385 * editfns.c (overlays_around, get_pos_property):
2386 * textprop.c (get_char_property_and_overlay):
2387 * xdisp.c (next_overlay_change, note_mouse_highlight):
2388 * xfaces.c (face_at_buffer_position):
21514da7
PE
2389 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2390 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2391 (Fnext_overlay_change, Fprevious_overlay_change)
2392 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2393 Use ptrdiff_t, not int, for sizes.
21514da7 2394 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2395
3de73e5e
PE
2396 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2397
2606c57b
PE
2398 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2399 (x_session_initialize): Do not assume string length fits in int.
2400
aaafe47a
PE
2401 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2402 This is unlikely, but can occur if DPI is outlandish.
2403
2674ddc8 2404 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2405 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2406
28154962
PE
2407 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2408 * xrdb.c (magic_file_p, search_magic_path):
2409 Omit last arg SUFFIX; it was always 0. All callers changed.
2410 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2411
7de51af5
PE
2412 * xfont.c (xfont_match): Avoid need for strlen.
2413
25ed6cc3
PE
2414 * xfns.c: Don't assume strlen fits in int.
2415 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2416
4eab31dd
PE
2417 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2418 not unsigned long, as we prefer signed integers. All callers changed.
2419 Detect integer overflow in repeat count.
2420 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2421 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2422
171e2a58
PE
2423 * termcap.c: Don't assume sizes fit in int and never overflow.
2424 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2425 (gobble_line): Check for size-calculation overflow.
2426
ad39faca 2427 * minibuf.c (Fread_buffer):
6e5bb2dc 2428 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2429 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2430 Don't assume string length fits in int.
2431
52c61c22 2432 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2433 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2434
b5b8c9e5
PE
2435 * font.c: Don't assume string length fits in int.
2436 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2437 Use ptrdiff_t, not int.
ccd6111c
PE
2438 (font_intern_prop): Don't assume string length fits in int.
2439 Don't assume integer property fits in fixnum.
2440 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2441
882f0d81 2442 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2443 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2444 Reformulate so as not to need the command string.
2445 Invoke gzip -cd rather than gunzip, as it's more portable.
2446 (lock_info_type, lock_file_1, lock_file):
2447 Don't assume pid_t and time_t fit in unsigned long.
2448 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2449 (current_lock_owner): Prefer signed type for sizes.
2450 Use memcpy, not strncpy, where memcpy is what is really wanted.
2451 Don't assume (via atoi) that time_t and pid_t fit in int.
2452 Check for time_t and/or pid_t out of range, e.g., via a network share.
2453 Don't alloca where an auto var works fine.
2454
93f4cf88
PE
2455 * fileio.c: Fix some integer overflow issues.
2456 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2457 Don't assume string length fits in int.
2458 (directory_file_name): Don't assume string length fits in long.
2459 (make_temp_name): Don't assume pid fits in int, or that its print
2460 length is less than 20.
2461
f3e92b69
PE
2462 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2463
1bfdaf10
PE
2464 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2465
35016e9a
PE
2466 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2467
3d1e65a1
PE
2468 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2469 We prefer signed integers, even for size calculations.
2470
0b963a93
PE
2471 * emacs.c: Don't assume string length fits in 'int'.
2472 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2473 (main): Don't invoke strlen when not needed.
2474
573f4b54
PE
2475 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2476 (XD_DEBUG_MESSAGE): Don't waste a byte.
2477
989f33ba
PE
2478 * callproc.c (getenv_internal_1, getenv_internal)
2479 (Fgetenv_internal):
965d34eb
PE
2480 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2481
e4d29b33
PE
2482 * lread.c (invalid_syntax): Omit length argument.
2483 All uses changed. This doesn't fix a bug, but it simplifies the
2484 code away from its former Hollerith-constant appearance, and it's
2485 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2486 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2487
eb49b136
PE
2488 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2489 This didn't break anything, but it didn't help either.
2490 It's confusing to put a bogus integer in a place where the actual
2491 value does not matter.
9f62aeb1 2492 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2493 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2494
15375a22
PE
2495 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2496 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2497 implementation.
b61cc01c
PE
2498 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2499 We prefer signed types, and the value cannot exceed the EMACS_INT
2500 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2501 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2502 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2503 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2504
53b2623d
PE
2505 * indent.c (sane_tab_width): New function.
2506 (current_column, scan_for_column, Findent_to, position_indentation)
2507 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2508 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2509
51cab52b 2510 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2511
f2ed8a70
PE
2512 * lisp.h (lint_assume): New macro.
2513 * composite.c (composition_gstring_put_cache):
2514 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2515
abe80cc6
PE
2516 * editfns.c, insdel.c:
2517 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2518
b02c740e
PE
2519 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2520
ebc96716
PE
2521 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2522
b4e50fa0 2523 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2524 Use much-faster test for byte-length change.
311d5d7c 2525 Don't assume string byte-length fits in 'int'.
a4cf38e4 2526 Check that character arg fits in 'int'.
85461888 2527 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2528
c0c1ee9f
PE
2529 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2530
a498d7f4
PE
2531 * fns.c (concat): Catch string overflow earlier.
2532 Do not rely on integer wraparound.
2533
51cab52b
PE
2534 * dispextern.h (struct it.overlay_strings_charpos)
2535 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2536 * xdisp.c (forward_to_next_line_start)
2537 (back_to_previous_visible_line_start)
2538 (reseat_at_next_visible_line_start, next_element_from_buffer):
2539 Don't arbitrarily truncate the value of 'selective' to int.
2540
76031fad
PE
2541 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2542
5eb55db9
PE
2543 * composite.c: Don't truncate sizes to 'int'.
2544 (composition_gstring_p, composition_reseat_it)
2545 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2546 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2547 not EMACS_UINT, for indexes.
5eb55db9 2548
0703a717
PE
2549 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2550
d6202519
PE
2551 * buffer.c: Include <verify.h>.
2552 (struct sortvec.priority, struct sortstr.priority):
8961a454 2553 Now EMACS_INT, not int.
c20998a7 2554 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2555 (struct sortstr.size, record_overlay_string)
2556 (struct sortstrlist.size, struct sortlist.used):
2557 Don't truncate size to int.
2558 (record_overlay_string): Check for size-calculation overflow.
d6202519 2559 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2560
d5a19415
JM
25612011-06-22 Jim Meyering <meyering@redhat.com>
2562
029529ac 2563 Don't leak an XBM-image-sized buffer
d5a19415
JM
2564 * image.c (xbm_load): Free the image buffer after using it.
2565
a9041e6c
PE
25662011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 Port to Sun C.
2569 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2570 that Sun C diagnosed.
2571 * fns.c (secure_hash): Fix pointer signedness issue.
2572 * intervals.c (static_offset_intervals): New function.
2573 (offset_intervals): Use it.
2574
7f3f739f
LL
25752011-06-21 Leo Liu <sdl.web@gmail.com>
2576
2577 * deps.mk (fns.o):
2578 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2579 sha512.h.
2580
2581 * fns.c (secure_hash): Rename from crypto_hash_function and change
2582 the first arg to accept symbols.
5b66d427 2583 (Fsecure_hash): New primitive.
7f3f739f
LL
2584 (syms_of_fns): New symbols.
2585
76147d94
DD
25862011-06-20 Deniz Dogan <deniz@dogan.se>
2587
2588 * process.c (Fset_process_buffer): Clarify return value in
2589 docstring.
2590
7d7d0045
CY
25912011-06-18 Chong Yidong <cyd@stupidchicken.com>
2592
2593 * dispnew.c (add_window_display_history): Use BVAR.
2594
2595 * xdisp.c (debug_method_add): Use BVAR.
2596 (check_window_end, dump_glyph_matrix, dump_glyph)
2597 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2598
2599 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2600 Likewise.
2601
2602 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2603 check till after the cache is created in init_frame_faces.
2604
ff2bc410
SM
26052011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2606
2607 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2608
28177add
PE
26092011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2610
dd3482fe
PE
2611 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2612 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2613 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2614
393d71f3 2615 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2616 * fileio.c (Finsert_file_contents):
2617 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2618 Remove the old (too-loose) buffer overflow checks.
2619 They weren't needed, since make_gap checks for buffer overflow.
2620 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2621 The old code merely checked for Emacs fixnum overflow, and relied
2622 on undefined (wraparound) behavior. The new code avoids undefined
2623 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2624
2e6813b0 2625 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2626 Tune. Don't use wider integers than needed. Don't use alloca.
2627 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2628
599a9e4f
PE
2629 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2630
99561444
PE
2631 * insdel.c, lisp.h (buffer_overflow): New function.
2632 (insert_from_buffer_1, replace_range, replace_range_2):
2633 * insdel.c (make_gap_larger):
2634 * editfns.c (Finsert_char):
2635 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2636
28177add
PE
2637 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2638
e69dafad
PE
26392011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2640
a7af7fde 2641 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2642
b1c46f02
PE
2643 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2644 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2645
e69dafad
PE
2646 * fileio.c: Don't assume EMACS_INT fits in off_t.
2647 (emacs_lseek): New static function.
2648 (Finsert_file_contents, Fwrite_region): Use it.
2649 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2650
566684ea
PE
2651 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2652
e6966cd6
PE
2653 * fns.c: Don't overflow int when computing a list length.
2654 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2655 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2656 truncation on 64-bit hosts. Check for QUIT every
2657 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2658 faster and is responsive enough.
2659 (Flength): Report an error instead of overflowing an integer.
2660 (Fsafe_length): Return a float if the value is not representable
2661 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2662 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2663 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2664
dd0b0efb
PE
2665 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2666 (header_size, word_size): New constants.
2667 (allocate_vectorlike): Don't check size overflow here.
2668 (allocate_vector): Check it here instead, since this is the only
2669 caller of allocate_vectorlike that could cause overflow.
2670 Check that the new vector's length is representable as a fixnum.
2671
86fe5cfe
PE
2672 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2673 The previous code was bogus. For example, next_almost_prime (32)
2674 returned 39, which is undesirable as it is a multiple of 3; and
2675 next_almost_prime (24) returned 25, which is a multiple of 5 so
2676 why was the code bothering to check for multiples of 7?
2677
80e88859
PE
2678 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2679
4a2f0ad6
PE
2680 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2681
f66c7cf8
PE
2682 Variadic C functions now count arguments with ptrdiff_t.
2683 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2684 Back then I didn't know that the Emacs coding style prefers signed int.
2685 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2686 were being counted with int, which may truncate counts on 64-bit
2687 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2688 * lisp.h (struct Lisp_Subr.function.aMANY)
2689 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2690 Arg counts are now ptrdiff_t, not size_t.
2691 All variadic functions and their callers changed accordingly.
2692 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2693 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2694 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2695 * callint.c (Fcall_interactively): Check arg count for overflow,
2696 to avoid potential buffer overrun. Use signed char, not 'int',
2697 for 'varies' array, so that we needn't bother to check its size
2698 calculation for overflow.
2699 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2700 * eval.c (apply_lambda):
2701 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2702 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2703 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2704
a1759b76
PE
2705 * callint.c (Fcall_interactively): Don't use index var as event count.
2706
d96be9fc
PE
2707 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2708 * mem-limits.h (SIZE): Remove; no longer used.
2709
a690a978 2710 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2711
578c21e6
PE
2712 Remove unnecessary casts.
2713 * xterm.c (x_term_init):
2714 * xfns.c (x_set_border_pixel):
2715 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2716 These aren't needed now that we assume ANSI C.
2717
96f53c6c
PE
2718 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2719 It's more likely to cause problems (due to unsigned overflow)
2720 than to cure them.
2721
83c77d31
PE
2722 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2723
ee2079f1
PE
2724 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2725
6da65536
PE
2726 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2727
7147c4a4
PE
2728 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2729
193e32d9
PE
2730 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2731
e5533da6
PE
2732 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2733
9910e595
PE
2734 GLYPH_CODE_FACE returns EMACS_INT, not int.
2735 * dispextern.h (merge_faces):
2736 * xfaces.c (merge_faces):
01103c44
PE
2737 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2738 Don't assume EMACS_INT fits in int.
9910e595 2739
2638320e
PE
2740 * character.h (CHAR_VALID_P): Remove unused parameter.
2741 * fontset.c, lisp.h, xdisp.c: All uses changed.
2742
045eb8d9
PE
2743 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2744
c1f134b5
PE
2745 * fns.c (concat): Minor tuning based on overflow analysis.
2746 This doesn't fix any bugs. Use int to hold character, instead
2747 of constantly refetching from Emacs object. Use XFASTINT, not
2748 XINT, for value known to be a character. Don't bother comparing
2749 a single byte to 0400, as it's always less.
2750
395fcb93 2751 * floatfns.c (Fexpt):
327eeec8
PE
2752 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2753
abbd3d23
PE
2754 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2755 for characters.
2756
684a03ef
PE
2757 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2758
0fed43f3
PE
2759 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2760 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2761 incorrectly succeed when S was a string, because 4294967386 was
2762 truncated before it was used.
2763
8fd02eb7
PE
2764 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2765 Otherwise, an out-of-range integer could cause undefined behavior
2766 on a 64-bit host.
2767
f8c86b69
PE
2768 * composite.c: Use int, not EMACS_INT, for characters.
2769 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2770 EMACS_INT, for values that are known to be in character range.
2771 This doesn't fix any bugs but is the usual style inside Emacs and
2772 may generate better code on 32-bit machines.
2773
34206dd2
PE
2774 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2775 This is for reasons similar to the recent CHAR_STRING fix.
2776 * charset.c (Fencode_char): Check that character arg is actually
2777 a character. Pass an int to ENCODE_CHAR.
2778 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2779 wider than 'int', as a compile-time check to prevent future regressions
2780 in this area.
2781
c5958d4c 2782 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2783
2784 Make sure a 64-bit char is never passed to CHAR_STRING.
2785 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2786 by silently ignoring the top 32 bits, allowing some values
2787 that were far too large to be valid characters.
2788 * character.h: Include <verify.h>.
2789 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2790 arguments are no wider than unsigned, as a compile-time check
2791 to prevent future regressions in this area.
2792 * data.c (Faset):
01103c44 2793 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2794 (Fsubst_char_in_region):
2795 * fns.c (concat):
2796 * xdisp.c (decode_mode_spec_coding):
2797 Adjust to CHAR_STRING's new requirement.
2798 * editfns.c (Finsert_char, Fsubst_char_in_region):
2799 * fns.c (concat): Check that character args are actually
2800 characters. Without this test, these functions did the wrong
2801 thing with wildly out-of-range values on 64-bit hosts.
2802
d37ca623
PE
2803 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2804 These casts should not be needed on 32-bit hosts, either.
2805 * keyboard.c (read_char):
2806 * lread.c (Fload): Remove casts to unsigned.
2807
ea204efb
PE
2808 * lisp.h (UNSIGNED_CMP): New macro.
2809 This fixes comparison bugs on 64-bit hosts.
2810 (ASCII_CHAR_P): Use it.
2811 * casefiddle.c (casify_object):
01103c44 2812 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2813 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2814 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2815 * dispextern.h (FACE_FROM_ID):
2816 * keyboard.c (read_char): Use UNSIGNED_CMP.
2817
41cb286c
PE
2818 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2819 not to EMACS_INT, to avoid GCC warning.
2820
4a1b9832
PE
2821 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2822
55daad71
PE
2823 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2824 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2825 isn't needed on 32-bit machines.
8f95c75c 2826
01103c44
PE
2827 * buffer.c (Fgenerate_new_buffer_name):
2828 Use EMACS_INT for count, not int.
0ceccced 2829 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2830
2831 * data.c (Qcompiled_function): Now static.
2832
c6f072e7
PE
2833 * window.c (window_body_lines): Now static.
2834
20ce5912
PE
2835 * image.c (gif_load): Rename local to avoid shadowing.
2836
9c4c5f81
PE
2837 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2838 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2839 * alloc.c (make_save_value): Integer argument is now of type
2840 ptrdiff_t, not int.
2841 (mark_object): Use ptrdiff_t, not int.
2842 * lisp.h (pD): New macro.
2843 * print.c (print_object): Use it.
2844
c0c5c8ae
PE
2845 * alloc.c: Use EMACS_INT, not int, to count objects.
2846 (total_conses, total_markers, total_symbols, total_vector_size)
2847 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2848 (total_free_floats, total_floats, total_free_intervals)
2849 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2850 Now EMACS_INT, not int. All uses changed.
2851 (Fgarbage_collect): Compute overall total using a double, so that
2852 integer overflow is less likely to be a problem. Check for overflow
2853 when converting back to an integer.
5a25e253
PE
2854 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2855 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2856 These were 'int' variables that could overflow on 64-bit hosts;
2857 they were never used, so remove them instead of repairing them.
211a0b2a 2858 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2859 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2860 Previously, this ceilinged at INT_MAX, but that doesn't work on
2861 64-bit machines.
e46bb31a 2862 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2863
c78baabf 2864 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2865 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2866 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2867 when a (possibly-narrower) signed value would do just as well.
2868 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2869
c9d624c6
PE
2870 * alloc.c: Catch some string size overflows that we were missing.
2871 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2872 for convenience in STRING_BYTES_MAX.
2873 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2874 The definition here is exact; the one in lisp.h was approximate.
2875 (allocate_string_data): Check for string overflow. This catches
2876 some instances we weren't catching before. Also, it catches
2877 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2878 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2879 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2880
c9d624c6
PE
2881 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2882 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2883 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2884
353032ce
PE
2885 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2886
2bccce07
PE
2887 * alloc.c (Fmake_string): Check for out-of-range init.
2888
0ac30604
SM
28892011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2890
2891 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2892
c195f2de
JD
28932011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2894
2895 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2896 xg_get_default_scrollbar_width.
2897
2898 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2899 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2900 (style_changed_cb): Call update_theme_scrollbar_width and call
2901 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2902 all frames (Bug#8505).
2903 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2904 Call gtk_window_set_resizable if HAVE_GTK3.
2905 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2906 and height if HAVE_GTK3 (Bug#8505).
2907 (scroll_bar_width_for_theme): New variable.
2908 (update_theme_scrollbar_width): New function.
2909 (xg_get_default_scrollbar_width): Move code to
2910 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2911 (xg_initialize): Call update_theme_scrollbar_width.
2912
2913 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2914
2915 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2916
e10ac9f1
MR
29172011-06-12 Martin Rudalics <rudalics@gmx.at>
2918
2919 * frame.c (make_frame): Call other_buffer_safely instead of
2920 other_buffer.
2921
2922 * window.c (temp_output_buffer_show): Call display_buffer with
2923 second argument Vtemp_buffer_show_specifiers and reset latter
2924 immediately after the call.
2925 (Vtemp_buffer_show_specifiers): New variable.
2926 (auto_window_vscroll_p, next_screen_context_lines)
2927 (Vscroll_preserve_screen_position): Remove leading asterisks from
2928 doc-strings.
2929
2d3c217e 29302011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2931
7b7f97e8 2932 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2933 * buffer.c (Qclone_number): Remove for now, as it's unused.
2934 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2935 (record_buffer): Remove unused local.
2936 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2937 (set_frame_buffer_list): Remove; unused.
2938 * frame.h (other_visible_frames): Remove decl.
2939 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2940 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2941 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2942 if HAVE_GPM.
2943 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2944 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2945 Define only if HAVE_GPM.
2946 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2947 (update_hints_inhibit): Remove; never set. All uses removed.
2948 * widgetprv.h (emacsFrameClassRec): Remove decl.
2949 * window.c (delete_deletable_window): Now returns void, since it
2950 wasn't returning anything.
2951 (compare_window_configurations): Remove unused locals.
2952 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2953 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2954 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2955 the same widths as pointers. This follows up on the 2011-05-06 patch.
2956 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2957 * xterm.h: Likewise.
2958 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2959
1384b89e
JB
29602011-06-12 Juanma Barranquero <lekktu@gmail.com>
2961
2962 * makefile.w32-in: Update dependencies.
2963 (LISP_H): Add lib/intprops.h.
2964
1100a63c
CY
29652011-06-11 Chong Yidong <cyd@stupidchicken.com>
2966
2967 * image.c (gif_load): Add animation frame delay to the metadata.
2968 (syms_of_image): Use DEFSYM. New symbol `delay'.
2969
6198ccd0
MR
29702011-06-11 Martin Rudalics <rudalics@gmx.at>
2971
2972 * window.c (delete_deletable_window): Re-add.
2973 (Fset_window_configuration): Rewrite to handle dead buffers and
2974 consequently deletable windows.
2975 (window_tree, Fwindow_tree): Remove. Supply functionality in
2976 window.el.
2977 (compare_window_configurations): Simplify code.
2978
b6e3633c
AS
29792011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2980
1ab0dee5
AS
2981 * image.c (imagemagick_load_image): Fix type mismatch.
2982 (Fimagemagick_types): Likewise.
2983
b6e3633c
AS
2984 * window.h (replace_buffer_in_windows): Declare.
2985
9397e56f
MR
29862011-06-11 Martin Rudalics <rudalics@gmx.at>
2987
2988 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2989 Qclone_number. Remove external declaration of Qdelete_window.
2990 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2991 code.
640c8776
SM
2992 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2993 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2994 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2995 buffer list implementation.
2996 (other_buffer_safely): New function.
2997 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2998 calls to replace_buffer_in_windows and
2999 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3000 if allowed.
3001 (record_buffer): Inhibit quitting and rewrite using quittable
3002 functions. Run Qbuffer_list_update_hook if allowed.
3003 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3004 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3005 Move switch-to-buffer to window.el.
9397e56f
MR
3006 (bury-buffer): Move to window.el.
3007 (Vbuffer_list_update_hook): New variable.
3008
3009 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3010 section.
3011
3012 * window.h (resize_frame_windows): Move up in code.
3013 (Fwindow_frame): Remove EXFUN.
3014 (replace_buffer_in_all_windows): Remove prototype.
3015 (replace_buffer_in_windows_safely): Add prototype.
3016
3017 * window.c: Declare Qdelete_window static again. Move down
3018 declaration of select_count.
3019 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3020 (Fother_window): Move to window.el.
3021 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3022 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3023 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3024 window.el.
3025 (replace_buffer_in_windows): Implement by calling
3026 Qreplace_buffer_in_windows.
3027 (replace_buffer_in_all_windows): Remove with some functionality
3028 moved into replace_buffer_in_windows_safely.
3029 (replace_buffer_in_windows_safely): New function.
3030 (select_window_norecord, select_frame_norecord): Move in front
3031 of run_window_configuration_change_hook. Remove now obsolete
3032 declarations.
640c8776
SM
3033 (Fset_window_buffer): Rewrite doc-string.
3034 Call Qrecord_window_buffer.
9397e56f
MR
3035 (keys_of_window): Move binding for other-window to window.el.
3036
b50691aa
CY
30372011-06-11 Chong Yidong <cyd@stupidchicken.com>
3038
3039 * dispextern.h (struct image): Replace data member, whose int_val
3040 and ptr_val fields were not used by anything, with a single
3041 lisp_val object.
3042
3043 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3044 (gif_clear_image, gif_load, imagemagick_load_image)
3045 (gs_clear_image, gs_load): Callers changed.
3046
3f754b86
PE
30472011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3048
cca69397
PE
3049 * buffer.h: Include <time.h>, for time_t.
3050 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3051
109e28d0
PE
3052 Fix minor problems found by static checking.
3053
60737f02
PE
3054 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3055
4b66faf3
PE
3056 Make identifiers static if they are not used in other modules.
3057 * data.c (Qcompiled_function, Qframe, Qvector):
3058 * image.c (QimageMagick, Qsvg):
3059 * minibuf.c (Qmetadata):
3060 * window.c (resize_window_check, resize_root_window): Now static.
3061 * window.h (resize_window_check, resize_root_window): Remove decls.
3062
109e28d0
PE
3063 * window.c (window_deletion_count, delete_deletable_window):
3064 Remove; unused.
46a4ce9e
PE
3065 (window_body_lines): Now static.
3066 (Fdelete_other_windows_internal): Mark vars as initialized.
3067 Make sure 'resize_failed' is initialized.
3068 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3069 (resize_window_apply): Remove unused local.
3070 * window.h (delete_deletable_window): Remove decl.
3071
109e28d0 3072 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3073 (imagemagick_load_image): Fix pointer signedness problem by changing
3074 last arg from unsigned char * to char *. All uses changed.
3075 Also, fix a local for similar reasons.
3076 Remove unused locals. Remove locals to avoid shadowing.
3077 (fn_rsvg_handle_free): Remove; unused.
3078 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3079 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3080
3f754b86
PE
3081 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3082
2547adb1
CY
30832011-06-10 Chong Yidong <cyd@stupidchicken.com>
3084
3085 * image.c (gif_load): Fix omitted cast error introduced by
3086 2011-06-06 change.
3087
2c8e37d4
MR
30882011-06-10 Martin Rudalics <rudalics@gmx.at>
3089
3090 * window.h (resize_proportionally, orig_total_lines)
3091 (orig_top_line): Remove from window structure.
3092 (set_window_height, set_window_width, change_window_heights)
3093 (Fdelete_window): Remove prototypes.
3094 (resize_frame_windows): Remove duplicate declaration.
3095
440a42e3
EZ
30962011-06-10 Eli Zaretskii <eliz@gnu.org>
3097
3098 * window.h (resize_frame_windows, resize_window_check)
3099 (delete_deletable_window, resize_root_window)
3100 (resize_frame_windows): Declare prototypes.
3101
3102 * window.c (resize_window_apply): Make definition be "static" to
3103 match the prototype.
3104
562dd5e9
MR
31052011-06-10 Martin Rudalics <rudalics@gmx.at>
3106
3107 * window.c: Remove declarations of Qwindow_size_fixed,
3108 window_min_size_1, window_min_size_2, window_min_size,
3109 size_window, window_fixed_size_p, enlarge_window, delete_window.
3110 Remove static from declaration of Qdelete_window, it's
3111 temporarily needed by Fbury_buffer.
3112 (replace_window): Don't assign orig_top_line and
3113 orig_total_lines.
3114 (Fdelete_window, delete_window): Remove. Window deletion is
3115 handled by window.el.
640c8776
SM
3116 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3117 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3118 (Fdelete_other_windows): Remove. Deleting other windows is
3119 handled by window.el.
3120 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3121 handled in window.el.
3122 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3123 Window minimum sizes are handled in window.el.
3124 (shrink_windows, size_window, set_window_height)
3125 (set_window_width, change_window_heights, window_height)
3126 (window_width, CURBEG, CURSIZE, enlarge_window)
3127 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3128 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3129 handled in window.el.
3130 (make_dummy_parent): Rename to make_parent_window and give it a
3131 second argument horflag.
3132 (make_window): Don't set resize_proportionally any more.
3133 (Fsplit_window): Remove. Windows are split in window.el.
3134 (save_restore_action, save_restore_orig_size)
3135 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3136 Resize mini windows in window.el.
3137 (grow_mini_window, shrink_mini_window): Implement by calling
3138 Qresize_root_window_vertically, resize_window_check and
3139 resize_window_apply.
640c8776
SM
3140 (saved_window, Fset_window_configuration, save_window_save):
3141 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3142 resize_proportionally.
3143 (window_min_height, window_min_width): Move to window.el.
3144 (keys_of_window): Move bindings for delete-other-windows,
3145 split-window, delete-window and enlarge-window to window.el.
3146
3147 * buffer.c: Temporarily extern Qdelete_window.
3148 (Fbury_buffer): Temporarily call Qdelete_window instead of
3149 Fdelete_window (Fbury_buffer will move to window.el soon).
3150
3151 * frame.c (set_menu_bar_lines_1): Remove code handling
3152 orig_top_line and orig_total_lines.
3153
3154 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3155 set_window_height but set heights directly.
3156 (change_frame_size_1): Use resize_frame_windows.
3157
3158 * xdisp.c (init_xdisp): Don't use set_window_height but set
3159 heights directly.
3160
640c8776
SM
3161 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3162 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3163 run_window_configuration_change_hook.
3164
3165 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3166 instead of change_window_heights and run
3167 run_window_configuration_change_hook.
3168
1a13852e
MR
31692011-06-09 Martin Rudalics <rudalics@gmx.at>
3170
3171 * window.c (replace_window): Rename second argument REPLACEMENT to
3172 NEW. New third argument SETFLAG. Rewrite.
3173 (delete_window, make_dummy_parent): Call replace_window with
3174 third argument 1.
3175 (window_list_1): Move down in code.
3176 (run_window_configuration_change_hook): Move set_buffer part
3177 before select_frame_norecord part in order to unwind correctly.
3178 Rename count1 to count.
3179 (recombine_windows, delete_deletable_window, resize_root_window)
3180 (Fdelete_other_windows_internal)
3181 (Frun_window_configuration_change_hook, make_parent_window)
3182 (resize_window_check, resize_window_apply, Fresize_window_apply)
3183 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3184 (Fdelete_window_internal, Fresize_mini_window_internal):
3185 New functions.
1a13852e
MR
3186 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3187
f3d1777e
MR
31882011-06-08 Martin Rudalics <rudalics@gmx.at>
3189
496e208e
MR
3190 * window.h (window): Add some new members to window structure -
3191 normal_lines, normal_cols, new_total, new_normal, clone_number,
3192 splits, nest, prev_buffers, next_buffers.
3193 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3194 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3195
f3d1777e
MR
3196 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3197 Remove.
496e208e
MR
3198 (make_dummy_parent): Set new members of windows structure.
3199 (make_window): Move down in code. Handle new members of window
3200 structure.
3201 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3202 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3203 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3204 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3205 (Fset_window_next_buffers, Fset_window_clone_number):
3206 New functions.
496e208e
MR
3207 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3208 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3209 Doc-string fixes.
3210 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3211 Argument WINDOW can be now internal window too.
3212 (Fwindow_use_time): Move up in code.
3213 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3214 Rewrite doc-string.
3215 (Fset_window_configuration, saved_window)
3216 (Fcurrent_window_configuration, save_window_save): Handle new
3217 members of window structure.
b9e809c2
MR
3218 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3219 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3220 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3221 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3222 Qget_mru_window, Qresize_root_window,
3223 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3224 Qauto_buffer_name; staticpro them.
f3d1777e 3225
abde8f8c
MR
32262011-06-07 Martin Rudalics <rudalics@gmx.at>
3227
3228 * window.c (Fwindow_total_size, Fwindow_left_column)
3229 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3230 (Fwindow_list_1): New functions.
3231 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3232 (Fwindow_width, Fscroll_left, Fscroll_right):
3233 Use window_body_cols instead of window_box_text_cols.
3234 (delete_window, Fset_window_configuration):
3235 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3236 (delete_all_subwindows): Take a window as argument and not a
3237 structure. Rewrite.
190b47e6
MR
3238 (window_loop): Remove handling of GET_LRU_WINDOW and
3239 GET_LARGEST_WINDOW.
3240 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3241
3242 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3243 window_box_text_cols. delete_all_subwindows now takes a
3244 Lisp_Object as argument.
abde8f8c 3245
640c8776
SM
3246 * indent.c (compute_motion, Fcompute_motion):
3247 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3248
fa8a67e6
MR
3249 * frame.c (delete_frame): Call delete_all_subwindows with root
3250 window as argument.
3251
a54e3482
DC
32522011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3253
3254 * fns.c (Fputhash): Document return value.
3255
60002bf5
CY
32562011-06-06 Chong Yidong <cyd@stupidchicken.com>
3257
3258 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3259
0c671da6 32602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3261
b862a52a 3262 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3263
be44ca6c
PE
3264 Check for overflow when converting integer to cons and back.
3265 * charset.c (Fdefine_charset_internal, Fdecode_char):
3266 Use cons_to_unsigned to catch overflow.
3267 (Fencode_char): Use INTEGER_TO_CONS.
3268 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3269 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3270 * data.c (long_to_cons, cons_to_long): Remove.
3271 (cons_to_unsigned, cons_to_signed): New functions.
3272 These signal an error for invalid or out-of-range values.
3273 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3274 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3275 * font.c (Ffont_variation_glyphs):
3276 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3277 * lisp.h: Include <intprops.h>.
3278 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3279 (cons_to_signed, cons_to_unsigned): New decls.
3280 (long_to_cons, cons_to_long): Remove decls.
3281 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3282 (Fprimitive_undo): Use CONS_TO_INTEGER.
3283 * xfns.c (Fx_window_property): Likewise.
3284 * xselect.c: Include <limits.h>.
3285 (x_own_selection, selection_data_to_lisp_data):
3286 Use INTEGER_TO_CONS.
3287 (x_handle_selection_request, x_handle_selection_clear)
3288 (x_get_foreign_selection, Fx_disown_selection_internal)
3289 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3290 (lisp_data_to_selection_data): Use cons_to_unsigned.
3291 (x_fill_property_data): Use cons_to_signed.
3292 Report values out of range.
3293
d1f3d2af
PE
3294 Check for buffer and string overflow more precisely.
3295 * buffer.h (BUF_BYTES_MAX): New macro.
3296 * lisp.h (STRING_BYTES_MAX): New macro.
3297 * alloc.c (Fmake_string):
3298 * character.c (string_escape_byte8):
3299 * coding.c (coding_alloc_by_realloc):
3300 * doprnt.c (doprnt):
3301 * editfns.c (Fformat):
3302 * eval.c (verror):
3303 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3304 since they may not be the same number.
3305 * editfns.c (Finsert_char):
3306 * fileio.c (Finsert_file_contents):
3307 Likewise for BUF_BYTES_MAX.
3308
dd52fcea
PE
3309 * image.c: Use ptrdiff_t, not int, for sizes.
3310 (slurp_file): Switch from int to ptrdiff_t.
3311 All uses changed.
3312 (slurp_file): Check that file size fits in both size_t (for
3313 malloc) and ptrdiff_t (for sanity and safety).
3314
7f9bbdbb
PE
3315 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3316 if b->modtime has its maximal value.
3317
dfe18f82
PE
3318 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3319
84acfcf0
PE
3320 Don't assume time_t can fit into int.
3321 * buffer.h (struct buffer.modtime): Now time_t, not int.
3322 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3323 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3324
ccd9a01a
PE
3325 Minor fixes for signed vs unsigned integers.
3326 * character.h (MAYBE_UNIFY_CHAR):
3327 * charset.c (maybe_unify_char):
3328 * keyboard.c (read_char, reorder_modifiers):
3329 XINT -> XFASTINT, since the integer must be nonnegative.
3330 * ftfont.c (ftfont_spec_pattern):
3331 * keymap.c (access_keymap, silly_event_symbol_error):
3332 XUINT -> XFASTINT, since the integer must be nonnegative.
3333 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3334 since it makes no difference and we prefer signed.
3335 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3336 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3337 nonnegative.
3338
d6d100dd
SM
33392011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3340
3341 * window.h (Fwindow_frame): Declare.
3342
2b6148e4
PE
33432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3346 (SPARE_MEMORY): Always define.
3347 (LARGE_REQUEST): Remove.
3348 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3349
f230ecc9
MR
33502011-06-06 Martin Rudalics <rudalics@gmx.at>
3351
727e958e
MR
3352 * lisp.h: Move EXFUNS for Fframe_root_window,
3353 Fframe_first_window and Fset_frame_selected_window to window.h.
3354
3355 * window.h: Move EXFUNS for Fframe_root_window,
3356 Fframe_first_window and Fset_frame_selected_window here from
3357 lisp.h.
3358
3359 * frame.c (Fwindow_frame, Fframe_first_window)
3360 (Fframe_root_window, Fframe_selected_window)
3361 (Fset_frame_selected_window): Move to window.c.
3362 (Factive_minibuffer_window): Move to minibuf.c.
3363 (Fother_visible_frames_p): New function.
3364
3365 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3366
f230ecc9
MR
3367 * window.c (decode_window, decode_any_window): Move up in code.
3368 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3369 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3370 (Fwindow_buffer): Move up and rewrite doc-string.
3371 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3372 (Fwindow_prev): New functions.
727e958e
MR
3373 (Fwindow_frame): Move here from frame.c. Accept any window as
3374 argument.
3375 (Fframe_root_window, Fframe_first_window)
3376 (Fframe_selected_window): Move here from frame.c. Accept frame
3377 or arbitrary window as argument. Update doc-strings.
3378 (Fminibuffer_window): Move up in code.
3379 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3380 (Fset_frame_selected_window): Move here from frame.c.
3381 Marginal rewrite.
727e958e
MR
3382 (Fselected_window, select_window, Fselect_window): Move up in
3383 code. Minor doc-string fixes.
f230ecc9 3384
4d09bcf6
PE
33852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3388 Do not assume that spare memory exists; that assumption is valid
3389 only if SYSTEM_MALLOC.
3390 (LARGE_REQUEST): New macro, so that the issue of large requests
3391 is separated from the issue of spare memory.
3392
810928a2
AS
33932011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3394
172418ad
AS
3395 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3396 format. (Bug#8806)
3397
43f862f7
AS
3398 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3399
810928a2
AS
3400 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3401 before statements.
3402
a059fe24
JD
34032011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3404
3405 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3406
3407 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3408
3409 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3410 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3411
989bf368
JB
34122011-06-05 Juanma Barranquero <lekktu@gmail.com>
3413
3414 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3415
4b80f674
CY
34162011-06-04 Chong Yidong <cyd@stupidchicken.com>
3417
3418 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3419 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3420 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3421 New error handlers.
4b80f674
CY
3422 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3423 Obey Vx_select_enable_clipboard_manager. Catch errors in
3424 x_clipboard_manager_save (Bug#8779).
3425 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3426 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3427
99a33b77 34282011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3429
3430 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3431
99a33b77 34322011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3433
3434 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3435 in the current matrix if keep_current_p is non-zero.
3436
8264569d
EZ
34372011-06-04 Eli Zaretskii <eliz@gnu.org>
3438
3439 * bidi.c (bidi_level_of_next_char): Fix last change.
3440
57f97249
EZ
34412011-06-03 Eli Zaretskii <eliz@gnu.org>
3442
fec2107c 3443 Support bidi reordering of text covered by display properties.
57f97249 3444
fec2107c
EZ
3445 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3446 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3447 (bidi_cache_search, bidi_cache_iterator_state)
3448 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3449 (bidi_level_of_next_char, bidi_move_to_visually_next):
3450 Support character positions inside a run of characters covered by a
fec2107c
EZ
3451 display string.
3452 (bidi_paragraph_init, bidi_resolve_explicit_1)
3453 (bidi_level_of_next_char): Call bidi_fetch_char and
3454 bidi_fetch_char_advance instead of FETCH_CHAR and
3455 FETCH_CHAR_ADVANCE.
3456 (bidi_init_it): Initialize new members.
3457 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3458 definitions.
3459 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3460 instead of using explicit *_CHAR codes.
d6d100dd
SM
3461 (bidi_resolve_explicit, bidi_resolve_weak):
3462 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3463 bidirectional text is supported only in multibyte buffers.
3464 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3465 it to initialize the frame_window_p member of struct bidi_it.
3466 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3467 (bidi_resolve_explicit, bidi_resolve_weak)
3468 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3469 bidi_it->nchars is non-positive.
3470 (bidi_level_of_next_char): Don't try to lookup the cache for the
3471 next/previous character if nothing is cached there yet, or if we
3472 were just reseat()'ed to a new position.
c40e2fb2 3473
0e14fe90
EZ
3474 * xdisp.c (set_cursor_from_row): Set start and stop points
3475 according to the row's direction when priming the loop that looks
3476 for the glyph on which to display cursor.
3477 (single_display_spec_intangible_p): Function deleted.
3478 (display_prop_intangible_p): Reimplement to call
3479 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3480 Accept 3 additional arguments needed by handle_display_spec.
3481 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3482 values: lists, `(when COND...)' forms, etc.
3483 (single_display_spec_string_p): Support property values that are
3484 lists with the argument STRING its top-level element.
3485 (display_prop_string_p): Fix the condition for processing a
3486 property that is a list to be consistent with handle_display_spec.
fec2107c 3487 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3488 last portion of handle_display_prop.
3489 (compute_display_string_pos): Accept additional argument
3490 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3491 value of a `display' property is a "replacing spec".
3492 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3493 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3494 the display property, but just return a value indicating whether
3495 the display property will replace the characters it covers.
3496 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3497 frame_window_p members of struct bidi_it.
d6d100dd
SM
3498 (compute_display_string_pos, compute_display_string_end):
3499 New functions.
fec2107c
EZ
3500 (push_it): Accept second argument POSITION, where pop_it should
3501 jump to continue iteration.
3502 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3503
fec2107c
EZ
3504 * keyboard.c (adjust_point_for_property): Adjust the call to
3505 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3506
3507 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3508 (bidi_init_it): Update prototypes.
3509 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3510 (compute_display_string_pos, compute_display_string_end):
3511 Declare prototypes.
fec2107c
EZ
3512 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3513 EMACS_INT.
fc6f18ce 3514
40087514 35152011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3516
57f53182
PE
3517 Malloc failure behavior now depends on size of allocation.
3518 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3519 * lisp.h: Change signatures accordingly.
3520 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3521 All callers changed. (Bug#8762)
3522
3523 * gnutls.c: Use Emacs's memory allocators.
3524 Without this change, the gnutls library would invoke malloc etc.
3525 directly, which causes problems on non-SYNC_INPUT hosts, and which
3526 runs afoul of improving memory_full behavior. (Bug#8761)
3527 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3528 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3529 xfree instead of the default malloc, realloc, free.
3530 (Fgnutls_boot): No need to check for memory allocation failure,
3531 since xmalloc does that for us.
3532
ac32cd99 3533 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3534 * category.c (hash_get_category_set):
3535 * ccl.c (ccl_driver):
3536 * charset.c (Fdefine_charset_internal):
3537 * charset.h (struct charset.hash_index):
3538 * composite.c (get_composition_id, gstring_lookup_cache)
3539 (composition_gstring_put_cache):
3540 * composite.h (struct composition.hash_index):
3541 * dispextern.h (struct image.hash):
3542 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3543 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3544 (hashfn_equal, hashfn_user_defined, make_hash_table)
3545 (maybe_resize_hash_table, hash_lookup, hash_put)
3546 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3547 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3548 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3549 * image.c (make_image, search_image_cache, lookup_image)
3550 (xpm_put_color_table_h):
3551 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3552 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3553 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3554 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3555 * alloc.c (allocate_vectorlike):
3556 Check for overflow in vector size calculations.
3557 * ccl.c (ccl_driver):
3558 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3559 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3560 need to be updated by these changes.
40087514
PE
3561 * fns.c (make_hash_table, maybe_resize_hash_table):
3562 Check for integer overflow with large hash tables.
0de4bb68
PE
3563 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3564 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3565 (SXHASH_REDUCE): New macro.
3566 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3567 Use it instead of discarding useful hash info with large hash values.
3568 (sxhash_float): New function.
3569 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3570 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3571 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3572 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3573 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3574 Adjust signatures to match updated version of code.
3575 (consing_since_gc): Now EMACS_INT, since a single hash table can
3576 use more than INT_MAX bytes.
3577
698d32e2
DN
35782011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3579
3580 Make it possible to build with GCC-4.6+ -O2 -flto.
3581
3582 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3583
fd6fa53f
SM
35842011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3585
3586 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3587 Call minibuffer-inactive-mode.
3588
864db017
JB
35892011-05-31 Juanma Barranquero <lekktu@gmail.com>
3590
3591 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3592 Update dependencies.
3593
2ad0baf4
DN
35942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3595
3596 * data.c (init_data): Remove code for UTS, this system is not
3597 supported anymore.
3598
4fcc2638
DN
35992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3600
3601 Don't force ./temacs to start in terminal mode.
3602
3603 * frame.c (make_initial_frame): Initialize faces in all cases, not
3604 only when CANNOT_DUMP is defined.
3605 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3606
c56e0fd5
DN
36072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3608
3609 * dispnew.c (add_window_display_history): Use const for the string
3610 pointer. Remove declaration, not needed.
3611
333d54da 36122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3613
55d4c1b2 3614 Use 'inline', not 'INLINE'.
333d54da 3615 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3616 * alloc.c, fontset.c (INLINE): Remove.
3617 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3618 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3619 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3620 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3621 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3622
738db178
DN
36232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3624
3625 Make it possible to run ./temacs.
3626
3627 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3628 syms_of_callproc does the same thing. Remove test for
3629 "initialized", do it in the caller.
3630 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3631
620c53a6
SM
36322011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3633
3634 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3635 (read_minibuf): Use get_minibuffer.
3636 (syms_of_minibuf): Use DEFSYM.
3637 (Qmetadata): New var.
3638 * data.c (Qbuffer): Don't make it static.
3639 (syms_of_data): Use DEFSYM.
3640
e003a292
PE
36412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3644 (CCL_CODE_MIN): New macro.
3645
ed008a6d
PE
36462011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3647
3687c2ef
PE
3648 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3649
ed008a6d
PE
3650 * eval.c (Qdebug): Now static.
3651 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3652 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3653 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3654
d66c4c7c
CY
36552011-05-29 Chong Yidong <cyd@stupidchicken.com>
3656
3657 * image.c: Various fixes to ImageMagick code comments.
3658 (Fimagemagick_types): Doc fix.
3659
5fbc2025
PE
36602011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3661
0196f88a
PE
3662 Minor fixes prompted by GCC 4.6.0 warnings.
3663
3664 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3665
5fbc2025
PE
3666 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3667 (x_clipboard_manager_save_all): Move extern decl to ...
3668 * xterm.h: ... here, so that it can be checked for consistency.
3669
1dd3c2d9
CY
36702011-05-29 Chong Yidong <cyd@stupidchicken.com>
3671
3672 * xselect.c (x_clipboard_manager_save_frame)
3673 (x_clipboard_manager_save_all): New functions.
3674 (Fx_clipboard_manager_save): Lisp function deleted.
3675
3676 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3677 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3678
3679 * xterm.h: Update prototype.
3680
5ba6571d
WX
36812011-05-28 William Xu <william.xwl@gmail.com>
3682
3683 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3684 exiting (Bug#8239).
3685
3eaff834
JM
36862011-05-28 Jim Meyering <meyering@redhat.com>
3687
e1900994 3688 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3689 * fns.c (to_uchar): Define.
3690 (crypto_hash_function): Use it to convert some newly-signed
3691 variables to unsigned, to avoid sign-extension bugs. For example,
3692 without this change, (md5 "truc") would evaluate to
3693 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3694 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3695 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3696
0f6990a7
PE
36972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 Integer overflow fixes.
c8a9ca5a 3700
08686060
PE
3701 * dbusbind.c: Serial number integer overflow fixes.
3702 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3703 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3704 to hold a serial number that is too large for a fixnum.
3705 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3706 Check for serial numbers out of range. Decode any serial number
59568bf0 3707 that was so large that it became a float. (Bug#8722)
08686060 3708
2d1fc3c7
PE
3709 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3710 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3711 Use XFASTINT rather than XUINT when numbers are nonnegative.
3712 (xd_append_arg, Fdbus_method_return_internal):
3713 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3714 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3715 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3716 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3717 (Bug#8722)
2d1fc3c7 3718
c8a9ca5a
PE
3719 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3720
519e1d69
PE
3721 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3722
30569699
PE
3723 ccl: add integer overflow checks
3724 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3725 (IN_INT_RANGE): New macros.
3726 (ccl_driver): Use them to check for integer overflow when
3727 decoding a CCL program. Many of the new checks are whether XINT (x)
3728 fits in int; it doesn't always, on 64-bit hosts. The new version
3729 doesn't catch all possible integer overflows, but it's an
847044ea 3730 improvement. (Bug#8719)
30569699 3731
c11285dc
PE
3732 * alloc.c (make_event_array): Use XINT, not XUINT.
3733 There's no need for unsigned here.
3734
fdccd48e
PE
3735 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3736 This follows up to the 2011-05-06 change that substituted uintptr_t
3737 for EMACS_INT. This case wasn't caught back then.
3738
37910ab2
PE
3739 Rework Fformat to avoid integer overflow issues.
3740 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3741 now (part of C89). Include <verify.h>.
3742 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3743 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3744 (Fformat): Avoid the prepass trying to compute sizes; it was only
3745 approximate and thus did not catch overflow reliably. Instead, walk
3746 through the format just once, formatting and computing sizes as we go,
3747 checking for integer overflow at every step, and allocating a larger
3748 buffer as needed. Keep track separately whether the format is
3749 multibyte. Keep only the most-recently calculated precision, rather
3750 than them all. Record whether each argument has been converted to
3751 string. Use EMACS_INT, not int, for byte and char and arg counts.
3752 Support field widths and precisions larger than INT_MAX. Avoid
3753 sprintf's undefined behavior with conversion specifications such as %#d
3754 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3755 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3756 formatting out-of-range floating point numbers with int
9173deec 3757 formats. (Bug#8668)
37910ab2 3758
2e6578fb
PE
3759 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3760
0ae6bdee
PE
3761 * data.c: Avoid integer truncation in expressions involving floats.
3762 * data.c: Include <intprops.h>.
3763 (arith_driver): When there's an integer overflow in an expression
3764 involving floating point, convert the integers to floating point
3765 so that the resulting value does not suffer from catastrophic
3766 integer truncation. For example, on a 64-bit host (* 4
3767 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3768 Do not rely on undefined behavior after integer overflow.
3769
de883a70
PE
3770 merge count_size_as_multibyte, parse_str_to_multibyte
3771 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3772 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3773 Check for integer overflow.
3774 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3775 since it's now a duplicate of the other. This is more of
3776 a character than a buffer op, so better that it's in character.c.
3777 * fns.c, print.c: Adjust to above changes.
3778
2ff916cb
PE
37792011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3780
3781 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3782
f1b54466
PE
37832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3784
fb1ac845
PE
3785 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3786 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3787 (x_clipboard_manager_save): Now static.
3788 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3789
f1b54466
PE
3790 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3791 (crypto_hash_function): Now static.
3792 Fix pointer signedness problems. Avoid unnecessary initializations.
3793
a9f737ee
CY
37942011-05-27 Chong Yidong <cyd@stupidchicken.com>
3795
3796 * termhooks.h (Vselection_alist): Make it terminal-local.
3797
3798 * terminal.c (create_terminal): Initialize it.
3799
3800 * xselect.c: Support for clipboard managers.
3801 (Vselection_alist): Move to termhooks.h as terminal-local var.
3802 (LOCAL_SELECTION): New macro.
3803 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3804 (symbol_to_x_atom): Remove gratuitous arg.
3805 (x_handle_selection_request, lisp_data_to_selection_data)
3806 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3807 (x_own_selection, x_get_local_selection, x_convert_selection):
3808 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3809 (some_frame_on_display): Delete unused function.
3810 (Fx_own_selection_internal, Fx_get_selection_internal)
3811 (Fx_disown_selection_internal, Fx_selection_owner_p)
3812 (Fx_selection_exists_p): New optional frame arg.
3813 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3814 (x_handle_selection_clear): Don't treat other terminals with the
3815 same keyboard specially. Use the terminal-local Vselection_alist.
3816 (x_clear_frame_selections): Use Frun_hook_with_args.
3817
3818 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3819
3820 * xterm.h: Add support for those atoms.
3821
e067f0c1
CY
38222011-05-26 Chong Yidong <cyd@stupidchicken.com>
3823
3824 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3825 (converted_selections, conversion_fail_tag): New global variables.
3826 (x_selection_request_lisp_error): Free the above.
3827 (x_get_local_selection): Remove unnecessary code.
3828 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3829 of converted selections stored in converted_selections.
3830 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3831 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3832 (x_convert_selection): New function.
3833 (x_handle_selection_event): Simplify.
3834 (x_get_foreign_selection): Don't ignore incoming requests while
3835 waiting for an answer; this will fail when we implement
3836 SAVE_TARGETS, and seems unnecessary anyway.
3837 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3838 (Vx_sent_selection_functions): Doc fix.
3839
0f4aebc0
LL
38402011-05-26 Leo Liu <sdl.web@gmail.com>
3841
3842 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3843
e61124cd
YM
38442011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3845
3846 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3847
3848 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3849 for fringe update if it has periodic bitmap.
ac389d0c 3850 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3851 and fringe_bitmap_periodic_p.
3852
3853 * fringe.c (get_fringe_bitmap_data): New function.
3854 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3855 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3856 row. Mark glyph row for fringe update if periodicity changed.
3857
3858 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3859 for fringe update unless it has periodic bitmap.
3860
f16d9837
KH
38612011-05-25 Kenichi Handa <handa@m17n.org>
3862
3863 * xdisp.c (get_next_display_element): Set correct it->face_id for
3864 a static composition.
3865
e1b90ef6
LL
38662011-05-24 Leo Liu <sdl.web@gmail.com>
3867
3868 * deps.mk (fns.o):
3869 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3870
3871 * fns.c (crypto_hash_function, Fsha1): New function.
3872 (Fmd5): Use crypto_hash_function.
3873 (syms_of_fns): Add Ssha1.
3874
7400048f
PE
38752011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 * gnutls.c: Remove unused macros.
3878 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3879 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3880 Remove macros that are defined and never used.
3881 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3882
abb71cf4
CY
38832011-05-22 Chong Yidong <cyd@stupidchicken.com>
3884
3885 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3886 (Fx_get_selection_internal): Minor cleanup.
3887 (Fx_own_selection_internal): Rename arguments for consistency with
3888 select.el.
3889
6307db39
PE
38902011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3893
f3d4e0a4
CY
38942011-05-22 Chong Yidong <cyd@stupidchicken.com>
3895
3896 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3897
4d8ade89
YM
38982011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3899
3900 * dispnew.c (scrolling_window): Don't exclude the case that the
3901 last enabled row in the desired matrix touches the bottom boundary.
3902
32078c8d
GM
39032011-05-21 Glenn Morris <rgm@gnu.org>
3904
3905 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3906 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3907 and add some more files.
32078c8d 3908
7285dc67
EZ
39092011-05-20 Eli Zaretskii <eliz@gnu.org>
3910
3911 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3912 report_file_error introduced by the change from 2011-05-07.
3913
89d1bd22
PE
39142011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3915
3916 * systime.h (Time): Define only if emacs is defined.
3917 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3918 where the include path doesn't have X11/X.h by default. See
3919 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3920
e23640bb 39212011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3922
3923 * composite.c (find_automatic_composition): Fix previous change.
3924
b9704ad9
GM
39252011-05-20 Glenn Morris <rgm@gnu.org>
3926
3927 * lisp.mk: New file, split from Makefile.in.
3928 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3929 (shortlisp): Remove.
3930 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3931
4a720484
GM
39322011-05-19 Glenn Morris <rgm@gnu.org>
3933
3934 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3935 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3936 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3937 (lisp): Set the order to that of loadup.el.
3938 (shortlisp): Make it a copy of $lisp.
3939 (SOME_MACHINE_LISP): Remove.
3940 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3941 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3942
a28d4396
KH
39432011-05-18 Kenichi Handa <handa@m17n.org>
3944
3945 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3946 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3947 (find_automatic_composition): Mostly rewrite for efficiency.
3948
a2b1fa8e
JB
39492011-05-18 Juanma Barranquero <lekktu@gmail.com>
3950
3951 * makefile.w32-in: Update dependencies.
3952
8e1f5610
CS
39532011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3954
3955 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3956 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3957
7025ee00 39582011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3959
cdfa6eab
PE
3960 Fix some integer overflow issues, such as string length overflow.
3961
06d6db33
PE
3962 * insdel.c (count_size_as_multibyte): Check for string overflow.
3963
2b4560a8
PE
3964 * character.c (lisp_string_width): Check for string overflow.
3965 Use EMACS_INT, not int, for string indexes and lengths; in
3966 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3967 the resulting string length overflows an EMACS_INT; instead,
3968 report a string overflow if no precision given. When checking for
3969 precision exhaustion, use a check that cannot possibly have
3970 integer overflow. (Bug#8675)
3971 * character.h (lisp_string_width): Adjust to new signature.
3972
cb93f9be
PE
3973 * alloc.c (string_overflow): New function.
3974 (Fmake_string): Use it. This doesn't change behavior, but saves
3975 a few bytes and will simplify future changes.
3976 * character.c (string_escape_byte8): Likewise.
3977 * lisp.h (string_overflow): New decl.
3978
1a1f3366
PE
3979 Fixups, following up to the user-interface timestamp change.
3980 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3981 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3982 * msdos.c (mouse_get_pos): Likewise.
3983 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3984 * w32gui.h (Time): Define by including "systime.h" rather than by
3985 declaring it ourselves. (Bug#8664)
3986
d4e3e4d3
PE
3987 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3988 * image.c (clear_image_cache): Likewise.
3989
f6a24d19
PE
3990 * term.c (term_mouse_position): Don't assume time_t wraparound.
3991
08dc5ae6
PE
3992 Be more systematic about user-interface timestamps.
3993 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3994 and sometimes 'EMACS_UINT', to represent these timestamps.
3995 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3996 This makes the code easier to follow, and makes it easier to catch
3997 integer overflow bugs such as Bug#8664.
3998 * frame.c (Fmouse_position, Fmouse_pixel_position):
3999 Use Time, not unsigned long, for user-interface timestamps.
4000 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4001 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4002 * keyboard.h (last_event_timestamp): Likewise.
4003 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4004 * menu.h (xmenu_show): Likewise.
4005 * term.c (term_mouse_position): Likewise.
4006 * termhooks.h (struct input_event.timestamp): Likewise.
4007 (struct terminal.mouse_position_hook): Likewise.
4008 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4009 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4010 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4011 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4012 what it was before.
4013 * menu.h, termhooks.h: Include "systime.h", for Time.
4014
8e55734a
PE
4015 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4016 Don't assume that the difference between two unsigned long values
4017 can fit into an integer. At this point, we know button_down_time
4018 <= event->timestamp, so the difference must be nonnegative, so
4019 there's no need to cast the result if double-click-time is
4020 nonnegative, as it should be; check that it's nonnegative, just in
4021 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4022 apart (about 25 days). (Bug#8664)
8e55734a 4023
841f1b75 4024 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4025 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4026
3e26f69c
PE
4027 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4028 that always fit in int. Use a sentinel instead of a counter, to
4029 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4030 * frame.h (struct frame): Use int for menu_bar_items_used
4031 instead of EMACS_INT, since it always fits in int.
3e26f69c 4032
5cc152c0
PE
4033 * menu.c (grow_menu_items): Check for int overflow.
4034
d89eb65e
PE
4035 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4036
5235bd3e
PE
4037 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4038 Before, the code was not consistent. These values cannot exceed
4039 2**31 - 1 so there's no need to make them unsigned.
4040 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4041 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4042 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4043 as modifiers.
4044 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4045
bc827e23
PE
4046 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4047 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4048 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4049 presumably because the widths might not match.
4050
78eb494e
PE
4051 * window.c (size_window): Avoid needless test at loop start.
4052
04f2d78b
CB
40532011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4054
4055 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4056
d2fc7e3d 40572011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4058
4059 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4060
d2fc7e3d 40612011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4062
4063 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4064 `width' to `bar_area_x' and `bar_area_width', respectively.
4065 (x_scroll_run): Take account of fringe background extension.
4066
04f2d78b
CB
4067 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4068 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4069 `bar_area_width', respectively.
4070 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4071 background extension.
4072
79b70037
GM
40732011-05-10 Jim Meyering <meyering@redhat.com>
4074
4075 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4076
2f142cc5
JB
40772011-05-10 Juanma Barranquero <lekktu@gmail.com>
4078
4079 * image.c (Finit_image_library): Return t for built-in image types,
4080 like pbm and xbm. (Bug#8640)
4081
57679c86
AS
40822011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4083
4084 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4085
888c9e86
EZ
40862011-05-07 Eli Zaretskii <eliz@gnu.org>
4087
b0512a1d
EZ
4088 * w32console.c (Fset_screen_color): Doc fix.
4089 (Fget_screen_color): New function.
4090 (syms_of_ntterm): Defsubr it.
4091
7285dc67
EZ
4092 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4093 unlink the temporary file if Fcall_process didn't create it in the
4094 first place.
4095 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4096 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4097 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4098 cue to call_process_cleanup not to close that handle.
4099
4d3fcc8e
BK
41002011-05-07 Ben Key <bkey76@gmail.com>
4101
4102 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4103 one of two shell specific rules, either bootstrap-temacs-CMD or
4104 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4105 to the previous implementation of the bootstrap-temacs rule.
4106 The bootstrap-temacs-CMD rule is similar to the previous
4107 implementation of the bootstrap-temacs rule except that it
4108 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4109 variable.
4110
4111 These changes, along with some changes to nt/configure.bat,
4112 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4113 earlier fix to add support for --cflags and --ldflags options
4114 that include quotes so that it works whether make uses cmd or
4115 sh as the shell.
4116
b4289b64
MA
41172011-05-06 Michael Albinus <michael.albinus@gmx.de>
4118
4119 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4120 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4121 is a constant.
4122 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4123 a string. Handle both cases.
4124 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4125 (Fdbus_register_method): Use Qinvalid_function.
4126
af4c0e28
JB
41272011-05-06 Juanma Barranquero <lekktu@gmail.com>
4128
4129 * makefile.w32-in: Update dependencies.
4130 (LISP_H): Add inttypes.h and stdin.h.
4131 (PROCESS_H): Add unistd.h.
4132
c51453d9
EZ
41332011-05-06 Eli Zaretskii <eliz@gnu.org>
4134
4135 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4136 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4137
8ff0ac3c 41382011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4139
4c4b566b
PE
4140 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4141
aab2b9b5
PE
4142 * term.c (vfatal): Remove stray call to va_end.
4143 It's not needed and the C Standard doesn't allow it here anyway.
4144
c378da0b
PE
4145 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4146 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4147
288b08c7
PE
4148 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4149 bytes.
4150
e3601888
PE
4151 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4152
db6c0e74
PE
4153 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4154
dd5963ea
PE
4155 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4156
88c9450f
PE
4157 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4158
2f9442b8
PE
4159 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4160
c032b5f8
PE
4161 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4162 * charset.c (Fdefine_charset_internal): Don't initialize
4163 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4164 32-bit int (Bug#8600).
a108c10b
PE
4165
4166 * lread.c (read_integer): Be more consistent with string-to-number.
4167 Use string_to_number to do the actual conversion; this avoids
4168 rounding errors and fixes some other screwups. Without this fix,
4169 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4170 (digit_to_number): Move earlier, for benefit of read_integer.
4171 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4172 not a digit in any supported base. (Bug#8602)
a108c10b 4173
ad5f9eea
PE
4174 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4175
aec1708a
PE
4176 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4177 to match comment at start of function. This also removes a
4178 GCC warning about overflow in a 32+64-bit port.
4179
47be4ab5
PE
4180 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4181
371cac43
PE
4182 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4183 Reported by Stefan Monnier in
4184 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4185 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4186 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4187
d01a7826
PE
4188 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4189 (EMACS_UINTPTR): Likewise, with uintptr_t.
4190
7fd47d5c
PE
4191 * lisp.h: Prefer 64-bit EMACS_INT if available.
4192 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4193 on 32-bit hosts that have 64-bit int, so that they can access
4194 large files.
122b0c86
PE
4195 However, temporarily disable this change unless the temporary
4196 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4197
8727937b
PE
4198 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4199
8ac068ac
PE
4200 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4201 This removes an assumption that EMACS_INT and long are the same
4202 width as pointers. The assumption is true for Emacs porting targets
4203 now, but we want to make other targets possible.
4204 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4205 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4206 In the rest of the code, change types of integers that hold casted
4207 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4208 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4209 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4210 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4211 No need to cast type when ORing.
4212 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4213 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4214 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4215 assume EMACS_INT is the same width as char *.
4216 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4217 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4218 Remove no-longer-needed casts.
4219 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4220 (xg_tool_bar_help_callback, xg_make_tool_item):
4221 Use EMACS_INTPTR to hold an integer
4222 that will be cast to void *; this can avoid a GCC warning
4223 if EMACS_INT is not the same width as void *.
4224 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4225 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4226 (current_message_1, set_message_1):
4227 Use a local to convert to proper width without a cast.
4228 * xmenu.c (dialog_selection_callback): Likewise.
4229
ede49d71
PE
4230 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4231 Also, don't assume VALBITS / RAND_BITS is less than 5,
4232 and don't rely on undefined behavior when shifting a 1 left into
4233 the sign bit.
4234 * lisp.h (get_random): Change signature to match.
4235
2f30ecd0
PE
4236 * lread.c (hash_string): Use size_t, not int, for hash computation.
4237 Normally we prefer signed values; but hashing is special, because
4238 it's better to use unsigned division on hash table sizes so that
4239 the remainder is nonnegative. Also, size_t is the natural width
4240 for hashing into memory. The previous code used 'int', which doesn't
4241 retain enough info to hash well into very large tables.
4242 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4243
2a866e7b
PE
4244 * dbusbind.c: Don't possibly lose pointer info when converting.
4245 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4246 Use XPNTR rather than XHASH, so that the high-order bits of
4247 the pointer aren't lost when converting through void *.
4248
51639eac
PE
4249 * eval.c (Fautoload): Don't double-shift a pointer.
4250
92394119
PE
4251 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4252
dbdb9a7c
JB
42532011-05-06 Juanma Barranquero <lekktu@gmail.com>
4254
4255 * gnutls.c (DEF_GNUTLS_FN):
4256 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4257
db7a0b4f
AS
42582011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4259
4260 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4261 marker. (Bug#8610)
4262
f7ff1b0f 42632011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4264
4265 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4266 New version that can reserve upto 2GB of heap space.
4267
f7ff1b0f 42682011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4269
4270 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4271
639c109b
TZ
42722011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4273
4274 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4275 `gnutls_certificate_set_x509_key_file'.
4276
d2127135
JB
42772011-05-05 Juanma Barranquero <lekktu@gmail.com>
4278
4279 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4280 Update dependencies.
4281
e968f4f3
JB
42822011-05-04 Juanma Barranquero <lekktu@gmail.com>
4283
4284 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4285 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4286 Remove unused parameter `fildes'.
4287 * process.c (read_process_output, send_process): Don't pass it.
4288
84d358f0
JB
42892011-05-04 Juanma Barranquero <lekktu@gmail.com>
4290
4291 Fix previous change: the library cache is defined in w32.c.
4292 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4293 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4294
0898ca10
JB
42952011-05-04 Juanma Barranquero <lekktu@gmail.com>
4296
4297 Implement dynamic loading of GnuTLS on Windows.
4298
4299 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4300 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4301 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4302 Declare.
4303
4304 * gnutls.c (Qgnutls_dll): Define.
4305 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4306 (gnutls_*): Declare function pointers.
4307 (init_gnutls_functions): New function to initialize function pointers.
4308 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4309 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4310 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4311 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4312 (emacs_gnutls_write, emacs_gnutls_read)
4313 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4314 (Fgnutls_available_p): New function.
4315 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4316 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4317 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4318
4319 * image.c: Include w32.h.
4320 (Vimage_type_cache): Delete.
4321 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4322 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4323 (w32_delayed_load): Move to w32.c.
4324
4325 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4326
4327 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4328 (w32_delayed_load): Move from image.c. When loading a library, record
4329 its filename in the :loaded-from property of the library id.
4330 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4331 Initialize and staticpro them.
4332 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4333
4334 * process.c: Include lisp.h before w32.h, not after.
4335 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4336 instead of gnutls_record_check_pending.
4337
4338 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4339
ff4de4aa
TZ
43402011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4341
4342 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4343 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4344 as passed in.
4345
abe95abb
JD
43462011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4347
4348 * xterm.c (x_set_frame_alpha): Do not set property on anything
4349 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4350
e16e55d4
JB
43512011-05-02 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4354
bafcf6a5
JB
43552011-05-02 Juanma Barranquero <lekktu@gmail.com>
4356
4357 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4358 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4359 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4360 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4361 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4362 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4363 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4364 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4365 (Qgnutls_bootprop_callbacks_verify): Make static.
4366
e7a6747f
AS
43672011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4368
19ed11ba
AS
4369 * callproc.c: Indentation fixup.
4370
e7a6747f 4371 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4372 (wait_for_termination, interruptible_wait_for_termination):
4373 Move after wait_for_termination_1.
e7a6747f 4374
1ef14cb4
LMI
43752011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4376
4377 * sysdep.c (interruptible_wait_for_termination): New function
4378 which is like wait_for_termination, but allows keyboard
4379 interruptions.
4380
4381 * callproc.c (Fcall_process): Add (:file "file") as an option for
4382 the STDOUT buffer.
4383 (Fcall_process_region): Ditto.
4384
330d880c
EZ
43852011-04-30 Eli Zaretskii <eliz@gnu.org>
4386
8db90b73
EZ
4387 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4388 rather than `XVECTOR (FOO)->size'.
4389
330d880c
EZ
4390 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4391 inttypes.h, as a gnulib replacement is used if it not available in
4392 system headers.
4393
15cbd324
EZ
43942011-04-21 Eli Zaretskii <eliz@gnu.org>
4395
4396 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4397 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4398 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4399
4400 * coding.c (coding_alloc_by_realloc): Error out if destination
4401 will grow beyond MOST_POSITIVE_FIXNUM.
4402 (decode_coding_emacs_mule): Abort if there isn't enough place in
4403 charbuf for the composition carryover bytes. Reserve an extra
4404 space for up to 2 characters produced in a loop.
4405 (decode_coding_iso_2022): Abort if there isn't enough place in
4406 charbuf for the composition carryover bytes.
4407
44082011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4409
ae940cca
EZ
4410 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4411 aborting when %lld or %lll format is passed.
4412 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4413 %llo or %llx format is passed. (Bug#8545)
4414
03ab8921
EZ
4415 * window.c (window_scroll_line_based): Use a marker instead of
4416 simple variables to record original value of point. (Bug#7952)
4417
afda1437
EZ
4418 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4419 produced by %s or %c overflows available buffer space. (Bug#8545)
4420
f76dee0c
PE
44212011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4422
4423 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4424 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4425
fdc5744d
JB
44262011-04-28 Juanma Barranquero <lekktu@gmail.com>
4427
4428 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4429
638f053a
JB
44302011-04-28 Juanma Barranquero <lekktu@gmail.com>
4431
4432 * keyboard.c (Qdelayed_warnings_hook): Define.
4433 (command_loop_1): Run `delayed-warnings-hook'
4434 if Vdelayed_warnings_list is non-nil.
4435 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4436 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4437
d178f871
EZ
44382011-04-28 Eli Zaretskii <eliz@gnu.org>
4439
4440 * doprnt.c (doprnt): Don't return value smaller than the buffer
4441 size if the message was truncated. (Bug#8545).
4442
b124fd93
JB
44432011-04-28 Juanma Barranquero <lekktu@gmail.com>
4444
4445 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4446 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4447
e810457d
PE
44482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4449
4450 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4451
ea51cceb
JB
44522011-04-27 Juanma Barranquero <lekktu@gmail.com>
4453
4454 * makefile.w32-in: Update dependencies.
4455
94dcfacf
EZ
44562011-04-27 Eli Zaretskii <eliz@gnu.org>
4457
4458 Improve `doprnt' and its usage. (Bug#8545)
4459 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4460 `format_end'. Remove support for %l as a conversion specifier.
4461 Don't use xrealloc. Improve diagnostics when the %l size modifier
4462 is used. Update the commentary.
4463
4464 * eval.c (verror): Simplify calculation of size_t.
4465
4466 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4467 messages.
4468
f61f41d7
PE
44692011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4470
4471 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4472 change.
4473
96fb4434
PE
44742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4475
4476 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4477 This makes this file independent of the recent pseudovector change.
4478
671875da 44792011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4480
69e9b5a3
PE
4481 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4482
b5f869a7 4483 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4484 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4485 Remove unused local.
c8926152 4486 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4487
841a1577 4488 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4489 GCC 4.6.0 optimizes based on type-based alias analysis.
4490 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4491 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4492 != &v->size, and therefore "v->size = 1; b->size = 2; return
4493 v->size;" must therefore return 1. This assumption is incorrect
4494 for Emacs, since it type-puns struct Lisp_Vector * with many other
4495 types. To fix this problem, this patch adds a new type struct
f904488f 4496 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4497 and pseudovectors, and helps optimizing compilers not get fooled
4498 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4499 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4500 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4501 the size member.
eab3844f
PE
4502 (XSETPVECTYPE): Rewrite in terms of new macro.
4503 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4504 This is a bit clearer, and further avoids the possibility of
4505 undesirable aliasing.
4506 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4507 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4508 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4509 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4510 (ASIZE): Now uses header.size rather than size.
4511 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4512 to avoid the hassle of writing XVECTOR (foo)->header.size.
4513 (struct vectorlike_header): New type.
eab3844f
PE
4514 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4515 object, to help avoid aliasing.
4516 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4517 (SUBRP): Likewise, since Lisp_Subr is a special case.
4518 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4519 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4520 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4521 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4522 changed to be "header.size" and "header.next".
4523 * buffer.h (struct buffer): Likewise.
4524 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4525 * frame.h (struct frame): Likewise.
4526 * process.h (struct Lisp_Process): Likewise.
4527 * termhooks.h (struct terminal): Likewise.
4528 * window.c (struct save_window_data, struct saved_window): Likewise.
4529 * window.h (struct window): Likewise.
4530 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4531 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4532 * buffer.c (init_buffer_once): Likewise.
4533 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4534 special case.
4535 * process.c (Fformat_network_address): Use local var for size,
4536 for brevity.
4537
0df1eac5
PE
4538 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4539
847ab9d1 4540 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4541 * data.c (atof): Remove decl; no longer used or needed.
4542 (digit_to_number): Move to lread.c.
4543 (Fstring_to_number): Use new string_to_number function, to be
4544 consistent with how the Lisp reader treats infinities and NaNs.
4545 Do not assume that floating-point numbers represent EMACS_INT
4546 without losing information; this is not true on most 64-bit hosts.
4547 Avoid double-rounding errors, by insisting on integers when
4548 parsing non-base-10 numbers, as the documentation specifies.
4549 * lisp.h (string_to_number): New decl, replacing ...
4550 (isfloat_string): Remove.
bc0a5c13 4551 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4552 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4553 appears to have been a coding error. Similarly, do not accept
4554 strings like +-1e0 as floating point numbers. Do not report
4555 overflow for integer overflows unless the base is not 10 which
4556 means we have no simple and reliable way to continue.
4557 Break out the floating-point parsing into a new
4558 function string_to_number, so that Fstring_to_number parses
4559 floating point numbers consistently with the Lisp reader.
04f2d78b 4560 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4561 (E_CHAR, EXP_INT): Remove, replacing with ...
4562 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4563 (string_to_number): New function, replacing isfloat_string.
4564 This function checks for valid syntax and produces the resulting
4565 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4566 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4567 so that overflow for non-base-10 numbers is reported only when
4568 there's no portable and simple way to convert to floating point.
452f4150 4569
67769ffc
PE
4570 * textprop.c (set_text_properties_1): Rewrite for clarity,
4571 and to avoid GCC warning about integer overflow.
4572
c20db43f
PE
4573 * intervals.h (struct interval): Use EMACS_INT for members
4574 where EMACS_UINT might cause problems. See
4575 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4576 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4577 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4578 All uses changed.
37aa2f85
PE
4579 (offset_intervals): Tell GCC not to worry about length overflow
4580 when negating a negative length.
c20db43f 4581
2538aa2f
PE
4582 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4583 (overrun_check_free): Likewise.
4584
f2d3008d
PE
4585 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4586 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4587 word size.
4588
ec8df744
PE
4589 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4590 (gnutls_make_error): Rename local to avoid shadowing.
4591 (gnutls_emacs_global_deinit): ifdef out; not used.
4592 (Fgnutls_boot): Use const for pointer to readonly storage.
4593 Comment out unused local. Fix pointer signedness problems.
4594
640ee02d
PE
4595 * lread.c (openp): Don't stuff size_t into an 'int'.
4596 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4597 about possible signed overflow.
4598
6048fb2a
PE
4599 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4600 (GDK_KEY_g): Don't define if already defined.
4601 (xg_prepare_tooltip): Avoid pointer signedness problem.
4602 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4603
fa3c87e1
PE
4604 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4605 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4606
2172544b
PE
4607 * xfns.c (Fx_window_property): Simplify a bit,
4608 to make a bit faster and to avoid GCC 4.6.0 warning.
4609 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4610
9b821a21
PE
4611 * fns.c (internal_equal): Don't assume size_t fits in int.
4612
3c616cfa
PE
4613 * alloc.c (compact_small_strings): Tighten assertion a little.
4614
c2982e87
PE
4615 Replace pEd with more-general pI, and fix some printf arg casts.
4616 * lisp.h (pI): New macro, generalizing old pEd macro to other
4617 conversion specifiers. For example, use "...%"pI"d..." rather
4618 than "...%"pEd"...".
4619 (pEd): Remove. All uses replaced with similar uses of pI.
4620 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4621 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4622 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4623 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4624 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4625 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4626 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4627 64-bit hosts.
4628 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4629 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4630 * print.c (safe_debug_print, print_object): Likewise.
4631 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4632 to int.
6f04d126
PE
4633 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4634 avoiding the 0 flag, which is not portable.
c2982e87
PE
4635 * process.c (Fmake_network_process): Use pI to avoid cast.
4636 * region-cache.c (pp_cache): Likewise.
4637 * xdisp.c (decode_mode_spec): Likewise.
4638 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4639 behavior on 64-bit hosts with printf arg.
6f04d126 4640 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4641 (x_stop_queuing_selection_requests): Likewise.
4642 (x_get_window_property): Don't truncate byte count to an 'int'
4643 when tracing.
0b432f21 4644
5e073ec7
PE
4645 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4646 here, since it parses constructs like leading '-' and spaces,
4647 which are not wanted; and it overflows with large numbers.
4648 Instead, simply match F[0-9]+, which is what is wanted anyway.
4649
36372bf9
PE
4650 * alloc.c: Remove unportable assumptions about struct layout.
4651 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4652 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4653 (allocate_vectorlike, make_pure_vector): Use the new macros,
4654 plus offsetof, to remove unportable assumptions about struct layout.
4655 These assumptions hold on all porting targets that I know of, but
4656 they are not guaranteed, they're easy to remove, and removing them
4657 makes further changes easier.
4658
0b432f21
PE
4659 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4660 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4661 (string_overrun_cookie): Now const. Use initializers that
4662 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4663 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4664 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4665 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4666 multiple of sizeof (EMACS_INT); it need not be, if
4667 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4668 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4669
895009e1
JB
46702011-04-26 Juanma Barranquero <lekktu@gmail.com>
4671
4672 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4673
6a7a1b0b
TZ
46742011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4675
4676 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4677 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4678 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4679
841a1577 46802011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4681
4682 * lisp.h (Qdebug): List symbol.
895009e1 4683 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4684 * keyboard.c (debug-on-event): New variable.
4685 (handle_user_signal): Break into debugger when debug-on-event
4686 matches the current signal symbol.
4687
f2d3ba6f
DN
46882011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4689
4690 * alloc.c (check_sblock, check_string_bytes)
4691 (check_string_free_list): Convert to standard C.
4692
42ce4c63
TZ
46932011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4694
4695 * w32.c (emacs_gnutls_push): Fix typo.
4696
825cd63c
EZ
46972011-04-25 Eli Zaretskii <eliz@gnu.org>
4698
fb11d64d
EZ
4699 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4700 "cast to pointer from integer of different size".
4701
825cd63c
EZ
4702 Improve doprnt and its use in verror. (Bug#8545)
4703 * doprnt.c (doprnt): Document the set of format control sequences
4704 supported by the function. Use SAFE_ALLOCA instead of always
4705 using `alloca'.
4706
4707 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4708 is one byte too soon. Don't use xrealloc; instead xfree and
4709 xmalloc anew.
4710
e061a11b
TZ
47112011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4712
4713 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4714 callbacks stage.
4715
4716 * gnutls.c: Renamed global_initialized to
4717 gnutls_global_initialized. Added internals for the
4718 :verify-hostname-error, :verify-error, and :verify-flags
4719 parameters of `gnutls-boot' and documented those parameters in the
4720 docstring. Start callback support.
9173deec
JB
4721 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4722 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4723 on error. Return error code.
e061a11b
TZ
4724 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4725 (emacs_gnutls_read): Likewise.
4726 (Fgnutls_boot): Return handshake error code.
4727 (emacs_gnutls_handle_error): New function.
4728 (wsaerror_to_errno): Likewise.
4729
4730 * w32.h (emacs_gnutls_pull): Add prototype.
4731 (emacs_gnutls_push): Likewise.
4732
4733 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4734 (emacs_gnutls_push): Likewise.
4735
47362011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4737
4738 * process.c (wait_reading_process_output): Check if GnuTLS
4739 buffered some data internally if no FDs are set for TLS
4740 connections.
4741
4742 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4743 (LIBS): Link to USER_LIBS.
4744 ($(BLD)/gnutls.$(0)): New target.
4745
fa6996bc
EZ
47462011-04-24 Eli Zaretskii <eliz@gnu.org>
4747
eb35682e
EZ
4748 * xdisp.c (handle_single_display_spec): Rename the
4749 display_replaced_before_p argument into display_replaced_p, to
4750 make it consistent with the commentary. Fix typos in the
4751 commentary.
4752
e2ad650c
EZ
4753 * textprop.c (syms_of_textprop): Remove dead code.
4754 (copy_text_properties): Delete obsolete commentary about an
4755 interface that was deleted long ago. Fix typos in the description
4756 of arguments.
4757
1b2de274
EZ
4758 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4759 to changes in oldXMenu/XMenu.h from 2011-04-16.
4760 <menu_help_message, prev_menu_help_message>: Constify.
4761 (IT_menu_make_room): menu->help_text is now `const char **';
4762 adjust.
4763
4764 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4765 to changes in oldXMenu/XMenu.h from 2011-04-16.
4766 (struct XMenu): Declare `help_text' `const char **'.
4767
4768 * xfaces.c <Qunspecified>: Make extern again.
4769
4770 * syntax.c: Include sys/types.h before including regex.h, as
4771 required by Posix.
4772
762b15be
EZ
4773 * doc.c (get_doc_string): Improve the format passed to `error'.
4774
4775 * doprnt.c (doprnt): Improve commentary.
4776
4777 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4778
4779 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4780 them with etags.
4781
f1052e5d
EZ
4782 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4783 changes in globals.h immediately force recompilation.
762b15be
EZ
4784 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4785 $(CURDIR)/s/ms-w32.h.
4786 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4787
fa6996bc
EZ
4788 * character.c (Fchar_direction): Function deleted.
4789 (syms_of_character): Don't defsubr it.
4790 <char-direction-table>: Deleted.
4791
e6c3da20
EZ
47922011-04-23 Eli Zaretskii <eliz@gnu.org>
4793
4794 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4795 * doprnt.c: Include limits.h.
4796 (SIZE_MAX): New macro.
04f2d78b
CB
4797 (doprnt): Return a size_t value. 2nd arg is now size_t.
4798 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4799 Improve overflow protection. Support `l' modifier for integer
4800 conversions. Support %l conversion. Don't assume an EMACS_INT
4801 argument for integer conversions and for %c.
4802
4803 * lisp.h (doprnt): Restore prototype.
4804
4805 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4806 $(SRC)/character.h.
4807
4808 * Makefile.in (base_obj): Add back doprnt.o.
4809
4810 * deps.mk (doprnt.o): Add back prerequisites.
4811 (callint.o): Depend on character.h.
4812
4813 * eval.c (internal_lisp_condition_case): Include the handler
4814 representation in the error message.
4815 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4816 when breaking from the loop.
4817
4818 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4819
4820 * callint.c (Fcall_interactively): When displaying error message
4821 about invalid control letter, pass the character's codepoint, not
4822 a pointer to its multibyte form. Improve display of the character
4823 in octal and display also its hex code.
4824
4825 * character.c (char_string): Use %x to display the (unsigned)
4826 codepoint of an invalid character, to avoid displaying a bogus
4827 negative value.
4828
4829 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4830 `error', not SYMBOL_NAME itself.
4831
4832 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4833 character arguments to `error'.
4834
4835 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4836 to `error' in error message about FINAL_CHAR argument. Make sure
4837 FINAL_CHAR is a character, and use %c when it is passed as
4838 argument to `error'.
4839
4ffd0d6b 48402011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4841
4842 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4843
4844 * w32.c: Include <time.h>.
4845 (sys_localtime): New function.
4846
4ffd0d6b 48472011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4848
4849 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4850
4ffd0d6b 4851 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4852
4ffd0d6b 48532011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4854
4ffd0d6b
GM
4855 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4856 zombies (Bug#8467).
aac0c6e3 4857
04c56954
EZ
48582011-04-19 Eli Zaretskii <eliz@gnu.org>
4859
4860 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4861 gl_state.e_property when gl_state.object is Qt.
4862
4863 * insdel.c (make_gap_larger): Remove limitation of buffer size
4864 to <= INT_MAX.
4865
16a43933
CY
48662011-04-18 Chong Yidong <cyd@stupidchicken.com>
4867
4868 * xdisp.c (lookup_glyphless_char_display)
4869 (produce_glyphless_glyph): Handle cons cell entry in
4870 glyphless-char-display.
4871 (Vglyphless_char_display): Document it.
4872
4873 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4874 glyphless-char-display.
4875
4581706e
CY
48762011-04-17 Chong Yidong <cyd@stupidchicken.com>
4877
4878 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4879
4880 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4881
4882 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4883 definition for no-X builds.
4884
4887c6e2 48852011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4886
fd35b6f9
PE
4887 Static checks with GCC 4.6.0 and non-default toolkits.
4888
5c1ccb01
PE
4889 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4890
006c5daa
PE
4891 * process.c (keyboard_bit_set): Define only if SIGIO.
4892 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4893 (send_process): Repair possible setjmp clobbering.
4894
efc736d3
PE
4895 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4896
4e2fe2e6
PE
4897 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4898
f97334a2
PE
4899 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4900
4e75f29d
PE
4901 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4902 Define only if needed.
4903
90efadd1
PE
4904 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4905 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4906 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4907
3c647824
PE
4908 * dispextern.h (struct redisplay_interface): Rename param
4909 to avoid shadowing.
e264f262 4910 * termhooks.h (struct terminal): Likewise.
761383f4 4911 * xterm.c (xembed_send_message): Likewise.
3c647824 4912
b58c5c4a
PE
4913 * insdel.c (make_gap_smaller): Define only if
4914 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4915
cad59032
PE
4916 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4917 it.
4918
c339dc2e
PE
4919 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4920 so that we aren't warned about unused symbols.
4921
91a3e27b
PE
4922 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4923
399c71d3 4924 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4925
8ffc96f5
PE
4926 * xfns.c (x_real_positions): Mark locals as initialized.
4927
eef9bc79
PE
4928 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4929
098db9dd
PE
4930 * xterm.c: Fix problems found by static analysis with other toolkits.
4931 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4932 (x_dispatch_event): Declare static if USE_GTK, and
4933 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4934 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4935 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4936 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4937 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4938
eb18f6cc
PE
4939 * xmenu.c (menu_help_callback): Pointer type fixes.
4940 Use const pointers when pointing at readonly data. Avoid pointer
4941 signedness clashes.
4942 (FALSE): Remove unused macro.
4943 (update_frame_menubar): Remove unused decl.
4944
1fe72bf8
PE
4945 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4946
60d9e1db
PE
4947 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4948 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4949 (single_menu_item): Rename local to avoid shadowing.
4950
39261c26
PE
4951 * keyboard.c (make_lispy_event): Remove unused local var.
4952
018c5e19
PE
4953 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4954 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4955
63d2b86e
PE
4956 * bitmaps: Change bitmaps from unsigned char back to the X11
4957 compatible char. Avoid the old compiler warnings about
4958 out-of-range initializers by using, for example, '\xab' rather
4959 than 0xab.
4960
aefd87e1
PE
4961 * xgselect.c (xgselect_initialize): Check vs interface
4962 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4963
bf501fb9
PE
4964 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4965
e9829fdf
PE
4966 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4967 to read-only memory.
4968
1086c095
PE
4969 * fns.c (vector): Remove; this old hack is no longer needed.
4970
2baccd04 4971 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4972 Remove unused var.
dde42981 4973 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4974
72391843 4975 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4976
436c16df 4977 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4978 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4979 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4980
92bb796d 4981 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4982 (x_term_init): Remove local to avoid shadowing.
92bb796d 4983
764430a3 4984 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4985
4986 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4987 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4988
d1dfb56c
EZ
49892011-04-16 Eli Zaretskii <eliz@gnu.org>
4990
c4354cb4
EZ
4991 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4992
d1dfb56c
EZ
4993 Fix regex.c, syntax.c and friends for buffers > 2GB.
4994 * syntax.h (struct gl_state_s): Declare character position members
4995 EMACS_INT.
4996
4997 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4998
04f2d78b
CB
4999 * textprop.c (verify_interval_modification, interval_of):
5000 Declare arguments EMACS_INT.
d1dfb56c
EZ
5001
5002 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5003 EMACS_INT.
5004
5005 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5006
5007 * indent.c (Fvertical_motion): Local variable it_start is now
5008 EMACS_INT.
5009
5010 * regex.c (re_match, re_match_2, re_match_2_internal)
5011 (bcmp_translate, regcomp, regexec, print_double_string)
5012 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5013 (re_compile_pattern, re_exec): Declare arguments and local
5014 variables `size_t' and `ssize_t' and return values `regoff_t', as
5015 appropriate.
5016 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5017 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5018 <compile_stack_type>: `size' and `avail' are now `size_t'.
5019
5020 * regex.h <regoff_t>: Use ssize_t, not int.
5021 (re_search, re_search_2, re_match, re_match_2): Arguments that
5022 specify buffer/string position and length are now ssize_t and
5023 size_t. Return type is regoff_t.
5024
613052cd
BK
50252011-04-16 Ben Key <bkey76@gmail.com>
5026
5027 * nsfont.m: Fixed bugs in ns_get_family and
5028 ns_descriptor_to_entity that were caused by using free to
5029 deallocate memory blocks that were allocated by xmalloc (via
5030 xstrdup). This caused Emacs to crash when compiled with
5031 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5032 --enable-checking=xmallocoverrun). xfree is now used to
5033 deallocate these memory blocks.
5034
4170f62f 50352011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5036
71b41406
PE
5037 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5038
9587a89d
PE
5039 emacs_write: Accept and return EMACS_INT for sizes.
5040 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5041 et seq.
5042 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5043 Accept and return EMACS_INT.
5044 (emacs_gnutls_write): Return the number of bytes written on
5045 partial writes.
5046 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5047 (emacs_read, emacs_write): Remove check for negative size, as the
5048 Emacs source code has been audited now.
9587a89d
PE
5049 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5050 (emacs_read, emacs_write): Use it.
273a5f82
PE
5051 * process.c (send_process): Adjust to the new signatures of
5052 emacs_write and emacs_gnutls_write. Do not attempt to store
5053 a byte offset into an 'int'; it might overflow.
9587a89d 5054 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5055
3e047f51
PE
5056 * sound.c: Don't assume sizes fit in 'int'.
5057 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5058 Return EMACS_INT, not int.
3e047f51 5059 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5060 Accept EMACS_INT, not int.
5061 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5062 record read return values.
5063
cc39a9db
BK
50642011-04-15 Ben Key <bkey76@gmail.com>
5065
c9d0ec6d
JB
5066 * keyboard.c (Qundefined): Don't declare static since it is used
5067 in nsfns.m.
5068 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5069 static since they are used in nsfont.m.
cc39a9db 5070
6c60eb9f
SM
50712011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5072
5073 * process.c (Qprocessp): Don't declare static.
5074 * lisp.h (Qprocessp): Declare again.
5075
7990b61a
JB
50762011-04-15 Juanma Barranquero <lekktu@gmail.com>
5077
5078 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5079
5d4cb038
PE
50802011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5081
8bd7b830 5082 Improve C-level modularity by making more things 'static'.
cd64ea1d 5083
e3b27b31
PE
5084 Don't publish debugger-only interfaces to other modules.
5085 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5086 (verify_bytepos, count_markers): Move decls to the only modules
5087 that need them.
5088 * region-cache.h (pp_cache): Likewise.
5089 * window.h (check_all_windows): Likewise.
5090 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5091
5d4cb038
PE
5092 * sysdep.c (croak): Now static, if
5093 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5094 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5095
5096 * alloc.c (refill_memory_reserve): Now static if
5097 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5098 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5099
e87b6180
PE
5100 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5101 Define only if USE_LUCID.
5102
ac64929e
PE
5103 * xrdb.c (x_customization_string, x_rm_string): Now static.
5104
6f37259d
PE
5105 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5106 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5107
1683e3ab
PE
5108 * xdisp.c (draw_row_with_mouse_face): Now static.
5109 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5110
de9c2632
PE
5111 * window.h (check_all_windows): Mark externally visible.
5112
2b96acb7
PE
5113 * window.c (window_deletion_count): Now static.
5114
5115 * undo.c: Make symbols static if they're not exported.
5116 (last_undo_buffer, last_boundary_position, pending_boundary):
5117 Now static.
5118
50436f33
PE
5119 * textprop.c (interval_insert_behind_hooks): Now static.
5120 (interval_insert_in_front_hooks): Likewise.
5121
64520e5c
PE
5122 * term.c: Make symbols static if they're not exported.
5123 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5124 (max_frame_lines, tty_set_terminal_modes):
5125 (tty_reset_terminal_modes, tty_turn_off_highlight):
5126 (get_tty_terminal): Now static.
5127 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5128 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5129 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5130 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5131 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5132
1fa53021
PE
5133 * sysdep.c: Make symbols static if they're not exported.
5134 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5135 Now static.
5136 (sigprocmask_set, full_mask): Remove; unused.
5137 (wait_debugging): Mark as visible.
5138 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5139 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5140
d4b43b22
PE
5141 * syntax.c (syntax_temp): Define only if !__GNUC__.
5142
b7c513d0
PE
5143 * sound.c (current_sound_device, current_sound): Now static.
5144
989b29ad
PE
5145 * search.c (searchbufs, searchbuf_head): Now static.
5146
13a55a78
PE
5147 * scroll.c (scroll_cost): Remove; unused.
5148 * dispextern.h (scroll_cost): Remove decl.
5149
de68a1fc
PE
5150 * region-cache.h (pp_cache): Mark as externally visible.
5151
40ccffa6
PE
5152 * process.c: Make symbols static if they're not exported.
5153 (process_tick, update_tick, create_process, chan_process):
5154 (Vprocess_alist, proc_buffered_char, datagram_access):
5155 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5156 (deactivate_process): Mark defn as static, as well as decl.
5157 * lisp.h (create_process): Remove decl.
5158 * process.h (chan_process, Vprocess_alist): Remove decls.
5159
ad64fc97
PE
5160 * print.c: Make symbols static if they're not exported.
5161 (print_depth, new_backquote_output, being_printed, print_buffer):
5162 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5163 (print_interval, print_number_index, initial_stderr_stream):
5164 Now static.
5165 * lisp.h (Fprinc): Remove decl.
5166 (debug_output_compilation_hack): Mark as externally visible.
5167
adddb265
PE
5168 * sysdep.c (croak): Move decl from here to syssignal.h.
5169 * syssignal.h (croak): Put it here, so the API can be checked when
5170 'croak' is called from dissociate_if_controlling_tty.
5171
1717ede2
PE
5172 * minibuf.c: Make symbols static if they're not exported.
5173 (minibuf_save_list, choose_minibuf_frame): Now static.
5174 * lisp.h (choose_minibuf_frame): Remove decl.
5175
fa5fb2bc
PE
5176 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5177
1e3890d1
PE
5178 * lread.c: Make symbols static if they're not exported.
5179 (read_objects, initial_obarray, oblookup_last_bucket_number):
5180 Now static.
5181 (make_symbol): Remove; unused.
5182 * lisp.h (initial_obarray, make_symbol): Remove decls.
5183
8a1414fa
PE
5184 * keyboard.c: Make symbols static if they're not exported.
5185 (single_kboard, recent_keys_index, total_keys, recent_keys):
5186 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5187 (this_single_command_key_start, echoing, last_auto_save):
5188 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5189 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5190 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5191 (Vlispy_mouse_stem, double_click_count):
5192 Now static.
5193 (force_auto_save_soon): Define only if SIGDANGER.
5194 (ignore_mouse_drag_p): Now static if
5195 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5196 (print_help): Remove; unused.
5197 (stop_character, last_timer_event): Mark as externally visible.
5198 * keyboard.h (ignore_mouse_drag_p): Declare only if
5199 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5200 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5201 * lisp.h (echoing): Remove decl.
5202 (force_auto_save_soon): Declare only if SIGDANGER.
5203 * xdisp.c (redisplay_window): Simplify code, to make it more
5204 obvious that ignore_mouse_drag_p is not accessed if !defined
5205 USE_GTK && !defined HAVE_NS.
5206
93ea6e8f
PE
5207 * intervals.c: Make symbols static if they're not exported.
5208 (merge_properties_sticky, merge_interval_right, delete_interval):
5209 Now static.
5210 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5211
77382fcc
PE
5212 * insdel.c: Make symbols static if they're not exported.
5213 However, leave prepare_to_modify_buffer alone. It's never
5214 called from outside this function, but that appears to be a bug.
5215 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5216 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5217 (adjust_after_replace_noundo): Remove; unused.
5218 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5219 (signal_before_change): Remove decls.
77382fcc 5220
9306c32e
PE
5221 * indent.c (val_compute_motion, val_vmotion): Now static.
5222
cd44d2eb
PE
5223 * image.c: Make symbols static if they're not exported.
5224 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5225 if USE_GTK.
5226 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5227 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5228
ad9a7a06
PE
5229 * fringe.c (standard_bitmaps): Now static.
5230 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5231
81626931
PE
5232 * frame.c: Make symbols static if they're not exported.
5233 (x_report_frame_params, make_terminal_frame): Now static.
5234 (get_frame_param): Now static, unless HAVE_NS.
5235 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5236 (x_get_resource_string): Remove; not used.
5237 * frame.h (make_terminal_frame, x_report_frame_params):
5238 (x_get_resource_string); Remove decls.
5239 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5240 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5241
239f9db9
PE
5242 * font.c, fontset.c: Make symbols static if they're not exported.
5243 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5244 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5245 * font.c (font_close_object): Now static.
5246 * font.h (font_close_object): Remove.
5247 * fontset.c (FONTSET_OBJLIST): Remove.
5248 (free_realized_fontset) #if-0 the body, which does nothing.
5249 (face_suitable_for_char_p): #if-0, as it's never called.
5250 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5251 * xfaces.c (face_at_string_position):
5252 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5253 since 0 is always ASCII.
5254
dfcf3579
PE
5255 * fns.c (weak_hash_tables): Now static.
5256
5045092b
PE
5257 * fileio.c: Make symbols static if they're not exported.
5258 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5259 (Vwrite_region_annotation_buffers): Now static.
5260
57a96f5c
PE
5261 * eval.c: Make symbols static if they're not exported.
5262 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5263 * lisp.h (backtrace_list): Remove decl.
5264
35f08c38
PE
5265 * emacs.c: Make symbols static if they're not exported.
5266 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5267 (fatal_error_code, fatal_error_signal_hook, standard_args):
5268 Now static.
5269 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5270 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5271 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5272 * lisp.h (fatal_error_signal_hook): Remove decl.
5273 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5274
f44bd759
PE
5275 * editfns.c: Move a (normally-unused) function to its only use.
5276 * editfns.c, lisp.h (get_operating_system_release): Remove.
5277 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5278 worth the hassle of breaking this out.
5279
b532497d
PE
5280 * xterm.c: Make symbols static if they're not exported.
5281 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5282 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5283 (x_destroy_window, x_delete_display):
5284 Now static.
5285 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5286 (x_mouse_leave): Remove; unused.
5287 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5288 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5289 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5290 Remove decls.
5291 (x_mouse_leave): Declare only if WINDOWSNT.
5292 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5293 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5294 USE_X_TOOLKIT.
5295
1675728f
PE
5296 * ftxfont.c: Make symbols static if they're not exported.
5297 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5298 HAVE_FREETYPE.
5299 * font.h (ftxfont_driver): Likewise.
5300
e4cebfca
PE
5301 * xfns.c: Make symbols static if they're not exported.
5302 (x_last_font_name, x_display_info_for_name):
5303 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5304 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5305 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5306 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5307 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5308 (last_show_tip_args): Now static.
5309 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5310 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5311 (x_screen_planes): Remove; unused.
5312 * dispextern.h (x_screen_planes): Remove decl.
5313
5bf46f05
PE
5314 * dispnew.c: Make symbols static if they're not exported.
5315 * dispextern.h (redraw_garbaged_frames, scrolling):
5316 (increment_row_positions): Remove.
5317 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5318 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5319 Now static.
5320 (redraw_garbaged_frames): Remove; unused.
5321
435f4c28
PE
5322 * xfaces.c: Make symbols static if they're not exported.
5323 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5324 Remove decls.
5325 * xterm.h (defined_color): Remove decls.
5326 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5327 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5328 (menu_face_changed_default, defined_color, free_realized_face):
5329 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5330 (ascii_face_of_lisp_face): Remove; unused.
5331
8524aef3
PE
5332 * xdisp.c: Make symbols static if they're not exported.
5333 * dispextern.h (scratch_glyph_row, window_box_edges):
5334 (glyph_to_pixel_coords, set_cursor_from_row):
5335 (get_next_display_element, set_iterator_to_next):
5336 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5337 (show_mouse_face): Remove decls
5338 * frame.h (message_buf_print): Likewise.
5339 * lisp.h (pop_message, set_message, check_point_in_composition):
5340 Likewise.
5341 * xterm.h (set_vertical_scroll_bar): Likewise.
5342 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5343 (message_buf_print, scratch_glyph_row, displayed_buffer):
5344 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5345 (get_next_display_element, show_mouse_face, window_box_edges):
5346 (frame_to_window_pixel_xy, check_point_in_composition):
5347 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5348 (glyph_to_pixel_coords): Remove; unused.
5349
16390cd2
PE
5350 * dired.c (file_name_completion): Now static.
5351
5352 * dbusbind.c (xd_in_read_queued_messages): Now static.
5353
a25f4dfa
PE
5354 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5355 * data.c (circular_list_error): Remove.
5356
14a9c8df
PE
5357 * commands.h (last_point_position, last_point_position_buffer):
5358 (last_point_position_window): Remove decls.
5359 * keyboard.c: Make these variables static.
5360
04f2d78b
CB
5361 * coding.h (coding, code_convert_region, encode_coding_gap):
5362 Remove decls.
74ab6df5
PE
5363 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5364 (iso_code_class, detect_coding, code_convert_region): Now static.
5365 (encode_coding_gap): Remove; unused.
5366
38dfbee1
PE
5367 * chartab.c (chartab_chars, chartab_bits): Now static.
5368
a2cb4e63
PE
5369 * charset.h (charset_iso_8859_1): Remove decl.
5370 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5371 Now static.
5372
127198fd
PE
5373 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5374 * ccl.c (Vccl_program_table): Now static.
5375 (check_ccl_update): Remove; unused.
5376
d85b608f
PE
5377 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5378 * category.h: ... from here.
5379 * category.c (check_category_table, set_category_set): Now static.
5380
31cd66f3
PE
5381 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5382 * lisp.h: Remove these decls.
5383
c358e587
PE
5384 * buffer.c (buffer_count): Remove unused var.
5385
e78aecca
PE
5386 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5387 so that it's not optimized away.
5388 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5389 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5390 exported only to the debugger.
5391
e192d7d3 5392 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5393 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5394
92470028
PE
5395 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5396 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5397 was inaccessible from Lisp.
5398 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5399 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5400
244ed907
PE
5401 alloc.c: Import and export fewer symbols, and remove unused items.
5402 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5403 is defined.
5404 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5405 it's not optimized away by whole-program optimization.
5406 (message_enable_multibyte, free_misc): Remove.
5407 (catchlist, handlerlist, mark_backtrace):
5408 Declare only if BYTE_MARK_STACK.
5409 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5410 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5411 (message_enable_multibyte): Remove decl.
5412 (free_misc, interval_free_list, float_block, float_block_index):
5413 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5414 (cons_free_list, last_marked_index):
5415 Now static.
5416 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5417 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5418 (mark_backtrace): Define only if BYTE_MARK_STACK.
5419 * xdisp.c (message_enable_multibyte): Now static.
5420
61c2b50e 5421 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5422 This makes it easier for human readers (and static analyzers)
5423 to see whether these variables are used from other modules.
5424 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5425 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5426 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5427 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5428 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5429 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5430 * xmenu.c, xselect.c:
5431 Declare Q* vars static if they are not used in other modules.
5432 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5433 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5434 Remove decls of unexported vars.
5435 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5436
95c82688
PE
5437 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5438
16a97296
PE
5439 Make Emacs functions such as Fatom 'static' by default.
5440 This makes it easier for human readers (and static analyzers)
5441 to see whether these functions can be called from other modules.
5442 DEFUN now defines a static function. To make the function external
5443 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5444 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5445 (Finit_image_library):
16a97296
PE
5446 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5447 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5448 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5449 Remove decls, since these functions are now static.
5450 (Funintern, Fget_internal_run_time): New decls, since these functions
5451 were already external.
95c82688 5452
16a97296
PE
5453 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5454 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5455 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5456 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5457 * keyboard.c, keymap.c, lread.c:
5458 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5459 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5460 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5461 Mark functions with DEFUE instead of DEFUN,
5462 if they are used in other modules.
5463 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5464 decls for now-static functions.
5465 * buffer.h (Fdelete_overlay): Remove decl.
5466 * callproc.c (Fgetenv_internal): Mark as internal.
5467 * composite.c (Fremove_list_of_text_properties): Remove decl.
5468 (Fcomposition_get_gstring): New forward static decl.
5469 * composite.h (Fcomposite_get_gstring): Remove decl.
5470 * dired.c (Ffile_attributes): New forward static decl.
5471 * doc.c (Fdocumntation_property): New forward static decl.
5472 * eval.c (Ffetch_bytecode): New forward static decl.
5473 (Funintern): Remove extern decl; now in .h file where it belongs.
5474 * fileio.c (Fmake_symbolic_link): New forward static decl.
5475 * image.c (Finit_image_library): New forward static decl.
5476 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5477 * intervals.h (Fprevious_property_change):
5478 (Fremove_list_of_text_properties): Remove decls.
5479 * keyboard.c (Fthis_command_keys): Remove decl.
5480 (Fcommand_execute): New forward static decl.
5481 * keymap.c (Flookup_key): New forward static decl.
5482 (Fcopy_keymap): Now static.
5483 * keymap.h (Flookup_key): Remove decl.
5484 * process.c (Fget_process): New forward static decl.
5485 (Fprocess_datagram_address): Mark as internal.
5486 * syntax.c (Fsyntax_table_p): New forward static decl.
5487 (skip_chars): Remove duplicate decl.
5488 * textprop.c (Fprevious_property_change): New forward static decl.
5489 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5490 Now internal.
5491 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5492 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5493
785bbd42
PE
5494 * editfns.c (Fformat): Remove unreachable code.
5495
8b913b57
AS
54962011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5497
5498 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5499 change. (Bug#8496)
5500
a6744a35
EZ
55012011-04-13 Eli Zaretskii <eliz@gnu.org>
5502
5503 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5504 when at ZV. (Bug#8487)
5505
e7974947
AS
55062011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5507
baad03f0
AS
5508 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5509 (Bug#8437)
5510 * keyboard.c (parse_tool_bar_item): Likewise.
5511 * sound.c (sound_cleanup, alsa_close): Likewise.
5512 * termcap.c (tgetent): Likewise.
5513 * xfns.c (x_default_font_parameter): Likewise.
5514 * xsettings.c (read_and_apply_settings): Likewise.
5515
e7974947
AS
5516 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5517 (overrun_check_free): Protoize.
5518
28272684
PE
55192011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5522 since callers should never pass a negative size.
5523 Change the signature to match that of plain 'read' and 'write'; see
5524 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5525 * lisp.h: Update prototypes of emacs_write and emacs_read.
5526
11997c76
EZ
55272011-04-11 Eli Zaretskii <eliz@gnu.org>
5528
5529 * xdisp.c (redisplay_window): Don't try to determine the character
5530 position of the scroll margin if the window start point w->startp
e896f03c 5531 is outside the buffer's accessible region. (Bug#8468)
11997c76 5532
8a2cbd72
EZ
55332011-04-10 Eli Zaretskii <eliz@gnu.org>
5534
5535 Fix write-region and its subroutines for buffers > 2GB.
5536 * fileio.c (a_write, e_write): Modify declaration of arguments and
5537 local variables to support buffers larger than 2GB.
5538 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5539
5540 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5541 argument, local variables, and return value.
5542
5543 * lisp.h: Update prototypes of emacs_write and emacs_read.
5544
5545 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5546
4073e537 55472011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5548
1ebfdcb6
PE
5549 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5550
b2ded58d
PE
5551 Fix more problems found by GCC 4.6.0's static checks.
5552
7d66342c
PE
5553 * xdisp.c (vmessage): Use a better test for character truncation.
5554
bbf47d44
PE
5555 * charset.c (load_charset_map): <, not <=, for optimization,
5556 and to avoid potential problems with integer overflow.
9248994d 5557 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5558 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5559 * editfns.c (Fformat): Likewise.
1e69125e 5560 * syntax.c (skip_chars): Likewise.
3befa583 5561
e3019616
PE
5562 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5563 This also lets GCC 4.6.0 generate slightly better loop code.
5564
becfa255
PE
5565 * callint.c (Fcall_interactively): <, not <=, for optimization.
5566 (Fcall_interactively): Count the number of arguments produced,
5567 not the number of arguments given. This is simpler and lets GCC
5568 4.6.0 generate slightly better code.
5569
dae0cd48
PE
5570 * ftfont.c: Distingish more carefully between FcChar8 and char.
5571 The previous code passed unsigned char * to a functions like
5572 strlen and xstrcasecmp that expect char *, which does not
5573 conform to the C standard.
5574 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5575 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5576 char * when the C standard requires it.
5577
76032d70
PE
5578 * keyboard.c (read_char): Remove unused var.
5579
eb3f1cc8
PE
5580 * eval.c: Port to Windows vsnprintf (Bug#8435).
5581 Include <limits.h>.
5582 (SIZE_MAX): Define if the headers do not.
5583 (verror): Do not give up if vsnprintf returns a negative count.
5584 Instead, grow the buffer. This ports to Windows vsnprintf, which
5585 does not conform to C99. Problem reported by Eli Zaretskii.
5586 Also, simplify the allocation scheme, by avoiding the need for
5587 calling realloc, and removing the ALLOCATED variable.
5588
70476b54
PE
5589 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5590
12020a9e
PE
5591 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5592 But keep the doprint source code for now, as we might revamp it
5593 and use it again (Bug#8435).
ea6c7ae6
PE
5594 * lisp.h (doprnt): Remove.
5595 * Makefile.in (base_obj): Remove doprnt.o.
5596 * deps.mk (doprnt.o): Remove.
5597
5fdb398c
PE
5598 error: Print 32- and 64-bit integers portably (Bug#8435).
5599 Without this change, on typical 64-bit hosts error ("...%d...", N)
5600 was used to print both 32- and 64-bit integers N, which relied on
5601 undefined behavior.
5602 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5603 New macro.
5604 * lisp.h (error, verror): Mark as printf-like functions.
5605 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5606 Report overflow in size calculations when allocating printf buffer.
5607 Do not truncate output string at its first null byte.
5608 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5609 Truncate the output at a character boundary, since vsnprintf does not
5610 do that.
5611 * charset.c (check_iso_charset_parameter): Convert internal
5612 character to string before calling 'error', since %c now has the
5613 printf meaning.
5614 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5615 overflow when computing char to be passed to 'error'. Do not
5616 pass Lisp_Object to 'error'; pass the integer instead.
5617 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5618 formatted with plain %d.
5619
b189fa66
PE
5620 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5621
bff87ef0
PE
5622 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5623
7e2cac20
PE
5624 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5625
ce4d90b5
PE
5626 * xterm.c (x_catch_errors): Remove duplicate declaration.
5627
266c9547
PE
5628 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5629
79c49ad2
PE
5630 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5631
368f4090
JM
56322011-04-10 Jim Meyering <meyering@redhat.com>
5633
5634 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5635 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5636 return ssize_t not "int", and use size_t as the buffer length.
5637 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5638 * gnutls.h: Update declarations.
5639 * process.c (read_process_output): Use ssize_t, to match.
5640 (send_process): Likewise.
5641
a32d4040
CY
56422011-04-09 Chong Yidong <cyd@stupidchicken.com>
5643
5644 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5645
8546720e 56462011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5647
04f2d78b
CB
5648 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5649 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5650
8546720e
GM
5651 * xterm.c (handle_one_xevent):
5652 * xmenu.c (create_and_show_popup_menu):
5653 * xselect.c (x_decline_selection_request)
5654 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5655
0a2f5c1a 56562011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5657
5658 Fix some uses of `int' instead of EMACS_INT.
5659 * search.c (string_match_1, fast_string_match)
5660 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5661 (scan_buffer, find_next_newline_no_quit)
5662 (find_before_next_newline, search_command, Freplace_match)
5663 (Fmatch_data): Make some `int' variables be EMACS_INT.
5664
5665 * xdisp.c (display_count_lines): 3rd argument and return value now
5666 EMACS_INT. All callers changed.
5667 (pint2hrstr): Last argument is now EMACS_INT.
5668
5669 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5670 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5671 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5672 (decode_coding_utf_16, decode_coding_emacs_mule)
5673 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5674 (decode_coding_ccl, decode_coding_charset)
5675 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5676 (decode_coding_iso_2022, decode_coding_emacs_mule)
5677 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5678 <char_offset, last_offset>: Declare EMACS_INT.
5679 (encode_coding_utf_8, encode_coding_utf_16)
5680 (encode_coding_emacs_mule, encode_invocation_designation)
5681 (encode_designation_at_bol, encode_coding_iso_2022)
5682 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5683 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5684 Declare EMACS_INT.
5685 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5686 (encode_invocation_designation): Last argument P_NCHARS is now
5687 EMACS_INT.
5688 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5689 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5690
5691 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5692 All users changed.
5693
5694 * ccl.c (Fccl_execute_on_string): Declare some variables
5695 EMACS_INT.
5696
8546720e 56972011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5698
5699 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5700
4e19a977
CS
57012011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5702
5703 * process.c (Fformat_network_address): Doc fix.
5704
87302331
R
57052011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5706
5707 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5708
cbb59342
CY
57092011-04-08 Chong Yidong <cyd@stupidchicken.com>
5710
5711 * keyboard.c (read_char): Call Lisp function help-form-show,
5712 instead of using internal_with_output_to_temp_buffer.
5713 (Qhelp_form_show): New var.
e0d38eeb 5714 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5715
5716 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5717
5718 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5719
e67a13ab
CY
57202011-04-06 Chong Yidong <cyd@stupidchicken.com>
5721
04f2d78b
CB
5722 * process.c (Flist_processes): Remove to Lisp.
5723 (list_processes_1): Delete.
e67a13ab 5724
973f782d
EZ
57252011-04-06 Eli Zaretskii <eliz@gnu.org>
5726
7c106b1e
EZ
5727 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5728
973f782d
EZ
5729 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5730
41cf7d1a 57312011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5732
ca23cc88
PE
5733 Fix more problems found by GCC 4.6.0's static checks.
5734
f390e2d5
PE
5735 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5736
42eea0d0
PE
5737 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5738
b69769da 5739 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5740
f9541e84
PE
5741 * xdisp.c (vmessage): Mark as a printf-like function.
5742
13841b55
PE
5743 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5744
c136c10f
PE
5745 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5746
5e2d4a30
PE
5747 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5748 printf-like functions.
5749 (tiff_load): Add casts to remove these marks before passing them
5750 to system-supplied API.
5751
583f48b9
PE
5752 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5753
b25d760e
PE
5754 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5755 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5756 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5757 directly, rather than having caller test rule sign. This avoids
5758 some unnecessary tests.
5759 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5760 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5761 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5762
bc7b6697 5763 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5764 (xfont_open): Avoid unnecessary tests.
bc7b6697 5765
27ccc379
PE
5766 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5767
dcd5c89a
PE
5768 * composite.h, composite.c (composition_gstring_put_cache):
5769 Use EMACS_INT, not int, for length.
5770
b13a45c6
PE
5771 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5772 breaking out part of COMPOSITION_DECODE_RULE.
5773 (COMPOSITION_DECODE_RULE): Use it.
5774 * composite.c (get_composition_id): Remove unused local vars,
5775 by using the new macro.
5776
1e792e4d
PE
5777 * textprop.c (set_text_properties_1): Change while to do-while,
5778 since the condition is always true at first.
5779
dc6c6455 5780 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5781 (interval_deletion_adjustment): Return unsigned value.
5782 All uses changed.
dc6c6455 5783
aba7731a
PE
5784 * process.c (list_processes_1, create_pty, read_process_output):
5785 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5786 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5787 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5788 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5789 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5790
fdfc4bf3
PE
5791 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5792
fca8fe46 5793 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5794 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5795
06a0259a 5796 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5797 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5798 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5799
e7b9e80f
PE
5800 * print.c (print_error_message): Avoid int overflow.
5801
56201685
PE
5802 * font.c (font_list_entities): Redo for clarity,
5803 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5804
78834453 5805 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5806 (font_score): Avoid potential overflow in diff calculation.
78834453 5807
0bc0b309 5808 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5809 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5810
e610eaca
PE
5811 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5812
b895abce
PE
5813 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5814 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5815 can always succeed if overflow has undefined behavior.
5816
1f1d9321 5817 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5818 (wordify): Omit three unnecessary tests.
1f1d9321 5819
c59478bc
PE
5820 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5821 All callers changed. This avoids the need for an unused var.
5822
79b73827
PE
5823 * casefiddle.c (casify_region): Remove var that is set but not used.
5824
a4db5dfe
PE
5825 * dired.c (file_name_completion): Remove var that is set but not used.
5826
43aae36e
PE
5827 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5828
2a47c44d 5829 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5830 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5831
a37c69bf
PE
5832 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5833 Check for integer overflow on size calculations.
5834
328ab8e7
PE
5835 * buffer.c (Fprevious_overlay_change): Remove var that is set
5836 but not used.
5837
e5a2a5cb
PE
5838 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5839 Remove vars that are set but not used.
8d84a6eb 5840 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5841 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5842
a60e5f68
PE
5843 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5844
f661cb61 5845 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5846 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5847
f0397f5a
PE
5848 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5849 that are set but not used.
5850
8664db06 5851 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5852 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5853
6abdaa4a
PE
5854 * xselect.c (x_get_local_selection, x_handle_property_notify):
5855 Remove vars that are set but not used.
5856
0ce7538d 5857 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5858 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5859
9ae848fc
PE
5860 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5861 Remove var that is set but not used.
0b918413
PE
5862 (scroll_bar_windows_size): Now size_t, not int.
5863 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5864 Check for overflow.
9ae848fc 5865
a5a62657
PE
5866 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5867 (map_tty_color) [!defined MSDOS]: Likewise.
5868
5c5cdd39
PE
5869 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5870
66ebf983
PE
5871 * coding.c: Remove vars that are set but not used.
5872 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5873 All callers changed.
5874 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5875 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5876 (decode_coding_charset): Remove vars that are set but not used.
5877
1be4d761
PE
5878 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5879 that is set but not used.
5880
47553fa8
PE
5881 * print.c (print_object): Remove var that is set but not used.
5882
1f7196bf 5883 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5884 The gnulib version avoids calling malloc in the usual case,
5885 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5886 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5887 * filelock.c (current_lock_owner): Likewise.
5888 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5889 * sysdep.c: Include allocator.h, careadlinkat.h.
5890 (emacs_no_realloc_allocator): New static constant.
5891 (emacs_readlink): New function.
fdb61804
PE
5892 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5893 ../lib/careadlinkat.h.
d1fdcab7 5894
f84c17c7
SM
58952011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5896
5897 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5898 first non-nil return value).
5899
ef3862ad
JD
59002011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5901
5902 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5903 if not defined (Bug#8403).
5904
376a7006
JB
59052011-04-02 Juanma Barranquero <lekktu@gmail.com>
5906
5907 * xdisp.c (display_count_lines): Remove parameter `start',
5908 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5909 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5910 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5911 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5912 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5913 and thereabouts. All callers changed.
5914 (get_per_char_metric): Remove parameter `f', unused since
5915 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5916
6ca3801d
JM
59172011-04-02 Jim Meyering <meyering@redhat.com>
5918
5919 do not dereference NULL upon failed strdup
5920 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5921 (ns_get_family): Likewise.
5922
d8e2b5ba
JB
59232011-04-02 Juanma Barranquero <lekktu@gmail.com>
5924
5925 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5926
8c74fcbd
JD
59272011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5928
5929 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5930 later (Bug#8403).
5931
7200d79c
SM
59322011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5933
03408648 5934 Add lexical binding.
7200d79c 5935
03408648
SM
5936 * window.c (Ftemp_output_buffer_show): New fun.
5937 (Fsave_window_excursion):
5938 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5939
5940 * lread.c (lisp_file_lexically_bound_p): New function.
5941 (Fload): Bind Qlexical_binding.
5942 (readevalloop): Remove `evalfun' arg.
5943 Bind Qinternal_interpreter_environment.
5944 (Feval_buffer): Bind Qlexical_binding.
5945 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5946 Mark as dynamic.
5947 (syms_of_lread): Declare `lexical-binding'.
5948
5949 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5950
5951 * keyboard.c (eval_dyn): New fun.
5952 (menu_item_eval_property): Use it.
ca105506
SM
5953
5954 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5955
03408648
SM
5956 * fns.c (concat, mapcar1): Accept byte-code-functions.
5957
5958 * eval.c (Fsetq): Handle lexical vars.
5959 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5960 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5961 (FletX, Flet): Obey lexical binding.
5962 (Fcommandp): Handle closures.
5963 (Feval): New `lexical' arg.
5964 (eval_sub): New function extracted from Feval. Use it almost
5965 everywhere where Feval was used. Look up vars in lexical env.
5966 Handle closures.
5967 (Ffunctionp): Move from subr.el.
5968 (Ffuncall): Handle closures.
5969 (apply_lambda): Remove `eval_flags'.
5970 (funcall_lambda): Handle closures and new byte-code-functions.
5971 (Fspecial_variable_p): New function.
5972 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5973 but without exporting it to Lisp.
23aba0ea 5974
23aba0ea 5975 * doc.c (Fdocumentation, store_function_docstring):
03408648 5976 * data.c (Finteractive_form): Handle closures.
23aba0ea 5977
03408648
SM
5978 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5979 interactive spec.
ba83908c 5980
04f2d78b
CB
5981 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5982 New byte-codes.
03408648
SM
5983 (exec_byte_code): New function extracted from Fbyte_code to handle new
5984 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5985
03408648 5986 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5987
03408648 5988 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5989
e2abce01
JB
59902011-03-31 Juanma Barranquero <lekktu@gmail.com>
5991
5992 * xdisp.c (redisplay_internal): Fix prototype.
5993
63696a73 59942011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5995
63696a73 5996 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5997 (try_scrolling): Use it when setting scroll_limit.
5998 Limit scrolling to 100 screen lines.
63696a73
EZ
5999 (redisplay_window): Even when falling back on "recentering",
6000 position point in the window according to scroll-conservatively,
6001 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6002
6003 (try_scrolling): When point is above the window, allow searching
6004 as far as scroll_max, or one screenful, to compute vertical
6005 distance from PT to the scroll margin position. This prevents
6006 try_scrolling from unnecessarily failing when
6007 scroll-conservatively is set to a value slightly larger than the
6008 window height. Clean up the case of PT below the margin at bottom
6009 of window: scroll_max can no longer be INT_MAX. When aggressive
6010 scrolling is in use, don't let point enter the opposite scroll
6011 margin as result of the scroll.
6012 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6013 threshold of 100 lines for never-recentering scrolling.
6014
e4cc2dfc
JB
60152011-03-31 Juanma Barranquero <lekktu@gmail.com>
6016
6017 * dispextern.h (move_it_by_lines):
6018 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6019 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6020 (message_log_check_duplicate): Remove parameters `prev_bol' and
6021 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6022 (redisplay_internal): Remove parameter `preserve_echo_area',
6023 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6024
6025 * indent.c (Fvertical_motion):
6026 * window.c (window_scroll_pixel_based, Frecenter):
6027 Don't pass `need_y_p' to `move_it_by_lines'.
6028
1c470562
SM
60292011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6030
44f230aa
SM
6031 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6032 steal a few bits to be more compact.
6033 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6034 Remove unneeded casts.
6035
1c470562
SM
6036 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6037
888adce9
ZK
60382011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6039
6040 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6041 binding" message (bug#7967).
6042
f838ed7b
PE
60432011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6044
77861b95
PE
6045 Fix more problems found by GCC 4.6.0's static checks.
6046
de6dbc14
PE
6047 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6048 Remove unused local var.
6049
f838ed7b
PE
6050 * editfns.c (Fmessage_box): Remove unused local var.
6051
792c7b2b
PE
6052 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6053 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6054 Omit unused local vars.
c499e557 6055 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6056 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6057 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6058 Omit unused local var.
6059
ba0165e1
PE
6060 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6061 Don't assume string length fits in int.
32ad8845 6062 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6063 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6064
3c59b4c9
PE
6065 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6066 instead of alloca (Bug#8344).
6067
a3eed478 6068 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6069 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6070
eb4d412d
PE
6071 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6072
1658b401
PE
6073 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6074 concerns.
6075
6076 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6077
6078 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6079
9a2c6e05
PE
6080 * keyboard.c (syms_of_keyboard): Use the same style as later
6081 in this function when indexing through an array. This also
6082 works around GCC bug 48267.
6083
03d0a109
PE
6084 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6085
44f730c8
PE
6086 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6087
fe75f926
PE
6088 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6089 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6090
ffa8c828
PE
6091 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6092 This avoids undefined behavior on integer overflow, and is a bit
6093 more convenient anyway since it is compared to a size_t variable.
6094
c5101a77
PE
6095 Variadic C functions now count arguments with size_t, not int.
6096 This avoids an unnecessary limitation on 64-bit machines, which
6097 caused (substring ...) to crash on large vectors (Bug#8344).
6098 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6099 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6100 All variadic functions and their callers changed accordingly.
c5101a77
PE
6101 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6102 * data.c (arith_driver, float_arith_driver): Likewise.
6103 * editfns.c (general_insert_function): Likewise.
6104 * eval.c (struct backtrace.nargs, interactive_p)
6105 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6106 (funcall_lambda, mark_backtrace): Likewise.
6107 * fns.c (concat): Likewise.
6108 * frame.c (x_set_frame_parameters): Likewise.
6109 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6110 0 if not found, not -1. All callers changed.
6111
dd3f25f7
PE
6112 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6113 (stack_copy_size): Now size_t, not int.
6114 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6115
461c2ab9
JB
61162011-03-28 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6119 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6120 All callers changed.
6121
6122 * lisp.h (multibyte_char_to_unibyte):
6123 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6124 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6125 * character.h (CHAR_TO_BYTE8):
6126 * cmds.c (internal_self_insert):
6127 * editfns.c (general_insert_function):
6128 * keymap.c (push_key_description):
6129 * search.c (Freplace_match):
6130 * xdisp.c (message_dolog, set_message_1): All callers changed.
6131
f6d62986
SM
61322011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6133
6134 * keyboard.c (safe_run_hook_funcall): New function.
6135 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6136 don't set the hook to nil, but remove the offending function instead.
6137 (Qcommand_hook_internal): Remove, unused.
6138 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6139 Vcommand_hook_internal.
6140
6141 * eval.c (enum run_hooks_condition): Remove.
6142 (funcall_nil, funcall_not): New functions.
6143 (run_hook_with_args): Call each function through a `funcall' argument.
6144 Remove `cond' argument, now redundant.
6145 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6146 (Frun_hook_with_args_until_failure): Adjust accordingly.
6147 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6148
1db5b1ad
JB
61492011-03-28 Juanma Barranquero <lekktu@gmail.com>
6150
6151 * dispextern.h (string_buffer_position): Remove declaration.
6152
6153 * print.c (strout): Remove parameter `multibyte', unused since
6154 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6155
6156 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6157 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6158 All callers changed.
6159
6160 * w32.c (_wsa_errlist): Use braces for struct initializers.
6161
6162 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6163 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6164 All callers changed.
6165 (string_buffer_position): Likewise. Also, make static (it's never
6166 used outside xdisp.c).
6167 (cursor_row_p): Remove parameter `w', unused since
6168 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6169 (decode_mode_spec): Remove parameter `precision', introduced during
6170 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6171 All callers changed.
6172
5ffb62aa
JD
61732011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6174
6175 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6176
461c2ab9 61772011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6178
6179 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6180 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6181 (ns_update_auto_hide_menu_bar): New functions.
6182 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6183 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6184 ns_constrain_all_frames.
6185 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6186 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6187
5c380ffb
JD
61882011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6189
6190 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6191
9af30bdf
GM
61922011-03-27 Glenn Morris <rgm@gnu.org>
6193
6194 * syssignal.h: Replace RETSIGTYPE with void.
6195 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6196 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6197 Replace SIGTYPE with void everywhere.
6198 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6199 * s/template.h (SIGTYPE): Remove commented out definition.
6200
e2abce01
JB
62012011-03-26 Eli Zaretskii <eliz@gnu.org>
6202
6203 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6204 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6205
f868cd8a
JB
62062011-03-26 Juanma Barranquero <lekktu@gmail.com>
6207
59eb0929
JB
6208 * w32.c (read_unc_volume): Use parameter `henum', instead of
6209 global variable `wget_enum_handle'.
6210
6211 * keymap.c (describe_vector): Remove parameters `indices' and
6212 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6213 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6214
f868cd8a
JB
6215 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6216
6217 * keyboard.c (timer_check): Remove parameter `do_it_now',
6218 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6219 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6220 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6221
6222 * keyboard.c (read_char):
6223 * w32menu.c (w32_menu_display_help):
6224 * xmenu.c (show_help_event, menu_help_callback):
6225 Adjust calls to `show_help_echo'.
6226
6227 * gtkutil.c (xg_maybe_add_timer):
6228 * keyboard.c (readable_events):
6229 * process.c (wait_reading_process_output):
6230 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6231
6232 * insdel.c (adjust_markers_gap_motion):
6233 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6234 (gap_left, gap_right): Don't call it.
6235
2ecf6fdb
CY
62362011-03-25 Chong Yidong <cyd@stupidchicken.com>
6237
6238 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6239 incurred during fontification.
6240
6b1f9ba4
JB
62412011-03-25 Juanma Barranquero <lekktu@gmail.com>
6242
6243 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6244 (DEFVAR_PER_BUFFER): Don't pass it.
6245
6246 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6247 (scrolling_window): Don't pass it.
6248
0f4a96b5
JB
62492011-03-25 Juanma Barranquero <lekktu@gmail.com>
6250
6251 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6252
6253 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6254 and `suffix'.
6255 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6256 of variables specific to SELinux and computation of `encoded_absname'.
6257
6258 * image.c (XPutPixel): Remove unused variable `height'.
6259
6260 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6261
6262 * unexw32.c (get_section_info): Remove unused variable `section'.
6263
6264 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6265 (system_process_attributes): Remove unused variable `sess'.
6266 (sys_read): Remove unused variable `err'.
6267
6268 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6269 (w32_wnd_proc): Remove unused variable `isdead'.
6270 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6271 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6272 (x_create_tip_frame): Remove unused variable `tem'.
6273
6274 * w32inevt.c (w32_console_read_socket):
6275 Remove unused variable `no_events'.
6276
6277 * w32term.c (x_draw_composite_glyph_string_foreground):
6278 Remove unused variable `width'.
6279
1149507c
JB
62802011-03-24 Juanma Barranquero <lekktu@gmail.com>
6281
6282 * w32term.c (x_set_glyph_string_clipping):
6283 Don't pass uninitialized region to CombineRgn.
6284
9c88f339
JB
62852011-03-23 Juanma Barranquero <lekktu@gmail.com>
6286
6287 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6288 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6289 (Fx_close_connection): Remove unused variable `i'.
6290
6291 * w32font.c (w32font_draw): Return number of glyphs.
6292 (w32font_open_internal): Remove unused variable `i'.
6293 (w32font_driver): Add missing initializer.
6294
6295 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6296 (fill_in_menu): Remove unused variable `items_added'.
6297
6298 * w32term.c (last_mouse_press_frame): Remove static global variable.
6299 (w32_clip_to_row): Remove unused variable `f'.
6300 (x_delete_terminal): Remove unused variable `i'.
6301
6302 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6303 (NOTHING): Remove unused static global variable.
6304 (uniscribe_check_otf): Remove unused variable `table'.
6305 (uniscribe_font_driver): Add missing initializers.
6306
dee091a3
JD
63072011-03-23 Julien Danjou <julien@danjou.info>
6308
6309 * term.c (Fsuspend_tty, Fresume_tty):
6310 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6311 * window.c (temp_output_buffer_show):
6312 * insdel.c (signal_before_change):
6313 * frame.c (Fhandle_switch_frame):
6314 * fileio.c (Fdo_auto_save):
6315 * emacs.c (Fkill_emacs):
6316 * editfns.c (save_excursion_restore):
6317 * cmds.c (internal_self_insert):
6318 * callint.c (Fcall_interactively):
6319 * buffer.c (Fkill_all_local_variables):
6320 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6321 Use Frun_hooks.
0f4a96b5 6322 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6323 unconditionnaly since it does the check itself.
6324
2c520ab5 63252011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6326
c9c49752
PE
6327 Fix more problems found by GCC 4.5.2's static checks.
6328
8abc3f12
PE
6329 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6330 the first time through the loop, since we know p0 < p1 then.
6331 This also avoids a gcc -Wstrict-overflow warning.
6332
a2d26660
PE
6333 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6334 leading to a memory leak, possible in functions like
6335 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6336 of objects (Bug#8318).
a2d26660 6337
916c72e9
PE
6338 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6339 that could (at least in theory) be that large.
6340
19ab8a18
PE
6341 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6342 This is less likely to overflow, and avoids undefined behavior if
6343 overflow does occur. All callers changed. Use strtoul to scan
6344 for the unsigned long integer.
b7cbbd6f
PE
6345 (pint2hrstr): Simplify and tune code slightly.
6346 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6347
f0641eff
PE
6348 * scroll.c (do_scrolling): Work around GCC bug 48228.
6349 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6350
7f650bb9
PE
6351 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6352 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6353 (validate_x_resource_name): Simplify count usage.
6354 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6355
37dd57d1
PE
6356 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6357 fail (Bug#8306).
81e56e61 6358
699979fc 6359 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6360
401bf9b4
PE
6361 * process.c (Fmake_network_process): Use socklen_t, not int,
6362 where POSIX says socklen_t is required in portable programs.
6363 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6364 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6365 (Fmake_network_process, server_accept_connection):
6366 (wait_reading_process_output, read_process_output):
6367 Likewise.
6368
b93aacde
PE
6369 * process.c: Rename or move locals to avoid shadowing.
6370 (list_processes_1, Fmake_network_process):
6371 (read_process_output_error_handler, exec_sentinel_error_handler):
6372 Rename or move locals.
4dc343ee 6373 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6374 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6375 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6376 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6377 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6378
af8a867c 6379 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6380 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6381 Include tparam.h instead, since it declares them.
af8a867c
PE
6382 * cm.h (PC): Remove extern decl; tparam.h now does this.
6383 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6384 * terminfo.c: Include tparam.h, to check interfaces.
6385 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6386 (tparam): Adjust signature to match interface in tparam.h;
6387 this removes some undefined behavior. Check that outstring and len
6388 are zero, which they always are with Emacs.
6389 * tparam.h (PC, BC, UP): New extern decls.
6390
0248044d 6391 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6392 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6393
8ff096c1 6394 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6395 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6396 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6397 (ftfont_list): Remove unused local.
49eaafba
PE
6398 (get_adstyle_property, ftfont_pattern_entity):
6399 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6400 Rename locals to avoid shadowing.
8ff096c1 6401
e2be39f6
PE
6402 * xfont.c (xfont_list_family): Mark var as initialized.
6403
c9735e30
PE
6404 * xml.c (make_dom): Now static.
6405
8f5201ae
PE
6406 * composite.c (composition_compute_stop_pos): Rename local to
6407 avoid shadowing.
b246f932
PE
6408 (composition_reseat_it): Remove unused locals.
6409 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6410 (composition_update_it): Mark var as initialized.
11b61122
PE
6411 (find_automatic_composition): Mark vars as initialized,
6412 with a FIXME (Bug#8290).
8f5201ae 6413
760fbc2c
PE
6414 character.h: Rename locals to avoid shadowing.
6415 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6416 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6417 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6418 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6419 to avoid shadowing.
6420
ff08eb85
PE
6421 * textprop.c (property_change_between_p): Remove; unused.
6422
fc7bf025
PE
6423 * intervals.c (interval_start_pos): Now static.
6424
235d7abc
PE
6425 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6426
44f230aa
SM
6427 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6428 Rename locals to avoid shadowing.
3e7d6594 6429
50060332
PE
6430 * sound.c (wav_play, au_play, Fplay_sound_internal):
6431 Fix pointer signedness.
d01f234b 6432 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6433 (wav_play): Initialize a variable to 0, to prevent undefined
6434 behavior (Bug#8278).
50060332 6435
c4fc4e30
PE
6436 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6437
918436ed
PE
6438 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6439
c939f91b
PE
6440 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6441 clobbering (Bug#8298).
b9c7f648
PE
6442 * sysdep.c (sys_subshell): Likewise.
6443 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6444
6bd8c144
PE
6445 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6446 This should get cleaned up, so that child_setup has the
6447 same signature on all platforms.
6448
7710357c 6449 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6450 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6451
c59da222
CY
64522011-03-22 Chong Yidong <cyd@stupidchicken.com>
6453
6454 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6455 not to be necessary, and produces flickering.
6456
66b87493
GM
64572011-03-20 Glenn Morris <rgm@gnu.org>
6458
6459 * config.in: Remove file.
6460
45b6f6d5
JB
64612011-03-20 Juanma Barranquero <lekktu@gmail.com>
6462
6463 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6464 are now in src/globals.h.
6465 (syms_of_minibuf): Remove spurious & from previous change.
6466
3ec03f7e
LL
64672011-03-20 Leo <sdl.web@gmail.com>
6468
6469 * minibuf.c (completing-read-function): New variable.
6470 (completing-read-default): Rename from completing-read.
6471 (completing-read): Call completing-read-function.
6472
b14e3e21
CY
64732011-03-19 Juanma Barranquero <lekktu@gmail.com>
6474
6475 * xfaces.c (Fx_load_color_file):
6476 Read color file from absolute filename (bug#8250).
6477
f2b726e6
JB
64782011-03-19 Juanma Barranquero <lekktu@gmail.com>
6479
6480 * makefile.w32-in: Update dependencies.
6481
09f6ff02
EZ
64822011-03-17 Eli Zaretskii <eliz@gnu.org>
6483
6484 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6485
29a6015a
PE
64862011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6487
a3a6c54e
PE
6488 Fix more problems found by GCC 4.5.2's static checks.
6489
b766f867
PE
6490 * process.c (make_serial_process_unwind, send_process_trap):
6491 (sigchld_handler): Now static.
6492
be02381c
PE
6493 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6494 That way, the code declares only the vars that it needs.
6495 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6496 * s/cygwin.h (PTY_ITERATION): Likewise.
6497 * s/darwin.h (PTY_ITERATION): Likewise.
6498 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6499
57048744
PE
6500 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6501 * process.c (allocate_pty): Don't declare stb unless it's needed.
6502
7914961c 6503 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6504 (CONSTANTLIM): Remove; unused.
6505 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6506 Define only if needed.
7914961c 6507
b3967b18
PE
6508 * unexelf.c (unexec): Name an expression,
6509 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6510 Use a different way to cause a compilation error if anyone uses
6511 n rather than nn, a way that does not involve shadowing.
73366a00 6512 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6513
29a6015a
PE
6514 * deps.mk (unexalpha.o): Remove; unused.
6515
43cfc33e 6516 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6517 * unexec.h: New file.
ce701a33
PE
6518 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6519 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6520 Depend on unexec.h.
6521 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6522 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6523 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6524 Change as necessary to match prototype in unexec.h.
ce701a33 6525
01f44d5a
PE
6526 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6527 shadowing.
4f63c6bb 6528 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6529
a6670b0b
PE
6530 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6531 Rename locals to avoid shadowing.
6532
cef2010d 6533 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6534 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6535
d4d7173a
PE
6536 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6537
f08b802a
PE
6538 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6539 warning when compiling print.c.
6540
3ddb0639
PE
6541 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6542 instead of using an uninitialized var.
5ad03b97 6543 (font_sort_entities): Mark var as initialized.
3ddb0639 6544
170a2692
PE
6545 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6546
e663c700
PE
6547 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6548 pointers to constants.
89bc529a 6549 (font_parse_fcname): Remove unused vars.
7b81e2d0 6550 (font_delete_unmatched): Now static.
ea838e10 6551 (font_get_spec): Remove; unused.
13a547c6
PE
6552 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6553 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6554 Rename or move locals to avoid shadowing.
e663c700 6555
2a80c887 6556 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6557 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6558
1384fa33 6559 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6560 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6561
8b2c52e9
PE
6562 * alloc.c (mark_backtrace): Move decl from here ...
6563 * lisp.h: ... to here, so that it can be checked.
6564
475545b5 6565 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6566 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6567 (lisp_indirect_variable): Name an expression,
6568 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6569 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6570
b1349114 6571 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6572 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6573 Use const pointer when appropriate.
b1349114 6574
a2928364
PE
6575 * lisp.h (get_system_name, get_operating_system_release):
6576 Move decls here, to check interfaces.
6577 * process.c (get_operating_system_release): Move decl to lisp.h.
6578 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6579 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6580 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6581 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6582 (Fformat_time_string, Fencode_time, Finsert_char):
6583 (Ftranslate_region_internal, Fformat):
6584 Rename or remove local vars to avoid shadowing.
9710023e 6585 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6586
a415e694
PE
6587 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6588 avoid shadowing.
6589
8ef4622d
PE
6590 * lisp.h (eassert): Check that the argument compiles, even if
6591 ENABLE_CHECKING is not defined.
6592
946f9a5b
PE
6593 * data.c (Findirect_variable): Name an expression, to avoid
6594 gcc -Wbad-function-cast warning.
112396d6 6595 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6596 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6597 (Fmake_variable_buffer_local, Fmake_local_variable):
6598 Mark variables as initialized.
52746918 6599 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6600
e5aab7e7 6601 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6602 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6603 Rename locals to avoid shadowing.
dff45157
PE
6604 (mark_stack): Move local variables into the #ifdef region where
6605 they're used.
7bc26fdb
PE
6606 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6607 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6608 needed otherwise.
6609 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6610 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6611 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6612
e5aab7e7
PE
6613 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6614 avoids undefined behavior in theory.
6615
4da60324
PE
6616 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6617
88043301
PE
6618 Use functions, not macros, for up- and down-casing (Bug#8254).
6619 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6620 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6621 to use the following functions instead of these macros.
6622 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6623 EMACS_INT, since callers assume the returned value fits in int.
6624 (upcase1): Likewise, for UPCASE_TABLE.
6625 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6626 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6627 the race-condition problem in the old DOWNCASE.
88043301 6628
19ed5445
PE
6629 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6630 Rename locals to avoid shadowing.
6631 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6632 (regex_compile, re_search_2, re_match_2_internal):
6633 Remove unused local vars.
952db0d7
PE
6634 (FREE_VAR): Rewrite so as not to use empty "else",
6635 which gcc can warn about.
da053e48 6636 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6637 (RETALLOC_IF): Define only if needed.
6638 (WORDCHAR_P): Likewise. This one is never needed, but is used
6639 only in a comment talking about a compiler bug, so put inside
6640 the #if 0 of that comment.
6641 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6642 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6643 Remove; unused.
19ed5445 6644
1f3561e4 6645 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6646 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6647 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6648
ded6f8f7
PE
6649 * search.c (simple_search): Remove unused var.
6650
dbd37a95
PE
6651 * dired.c (compile_pattern): Move decl from here ...
6652 * lisp.h: ... to here, so that it can be checked.
6653 (struct re_registers): New forward decl.
6654
7e47afad
PE
6655 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6656
85f24f61
PE
6657 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6658 All uses changed.
6659 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6660 Rename locals to avoid shadowing.
5671df8f 6661 (Fvertical_motion): Mark locals as initialized.
85f24f61 6662
181aa2be 6663 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6664 (casify_region): Mark local as initialized.
181aa2be 6665
930d429c
PE
6666 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6667
7082eac6
PE
6668 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6669 New macros, so that the caller can use some names other than
6670 gcpro1, gcpro2, etc.
6671 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6672 of the new macros.
6673 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6674 argument, for consistency with GCPRO2_VAR, etc: it is now the
6675 prefix of the variable, not the variable itself. All uses
6676 changed.
38b2c076
PE
6677 * dired.c (directory_files_internal, file_name_completion):
6678 Rename locals to avoid shadowing.
6679
15206ed9
PE
6680 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6681 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6682 dired.c's scmp function, had undefined behavior.
6683 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6684 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6685 * buffer.h: ... to here, because these macros use current_buffer,
6686 and the new implementation with inline functions needs to have
6687 current_buffer in scope now, rather than later when the macros
6688 are used.
6689 (downcase, upcase1): New static inline functions.
6690 (DOWNCASE, UPCASE1): Reimplement using these functions.
6691 This avoids undefined behavior in expressions like
6692 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6693 from race conditions in accessing the global variables
6694 case_temp1 and case_temp2.
6695 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6696 * lisp.h (case_temp1, case_temp2): Remove their decls.
6697 * character.h (ASCII_CHAR_P): Move from here ...
6698 * lisp.h: ... to here, so that the inline functions mentioned
6699 above can use them.
6700
4a6bea26
PE
6701 * dired.c (directory_files_internal_unwind): Now static.
6702
f14b7e14
PE
6703 * fileio.c (file_name_as_directory, directory_file_name):
6704 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6705 Now static.
2893f146
PE
6706 (file_name_as_directory): Use const pointers when appropriate.
6707 (Fexpand_file_name): Likewise. In particular, newdir might
6708 point at constant storage, so make it a const pointer.
fd4ead52 6709 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6710 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6711 signedness issues.
f839df0c
PE
6712 (Fset_file_times, Finsert_file_contents, auto_save_error):
6713 Rename locals to avoid shadowing.
f14b7e14 6714
5716756e 6715 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6716 (Ftry_completion, Fall_completions): Rename or remove locals
6717 to avoid shadowing.
5716756e 6718
b4c3046a
PE
6719 * marker.c (bytepos_to_charpos): Remove; unused.
6720
b45db522
PE
6721 * lisp.h (verify_bytepos, count_markers): New decls,
6722 so that gcc does not warn that these functions aren't declared.
6723
85876d07
PE
6724 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6725 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6726 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6727 (copy_text): Remove unused local var.
85876d07 6728
03d78a21 6729 * filelock.c (within_one_second): Now static.
b3dd38ab 6730 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6731
5df8f01b
PE
6732 * buffer.c (fix_overlays_before): Mark locals as initialized.
6733 (fix_start_end_in_overlays): Likewise. This function should be
6734 simplified by using pointers-to-pointers, but that's a different
6735 matter.
b1d876f1 6736 (switch_to_buffer_1): Now static.
8f54f30a
PE
6737 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6738 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6739
a70072c9 6740 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6741 Fix pointer signedness issue.
edced198
PE
6742 (sys_subshell): Mark local as volatile if checking for lint,
6743 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6744 (MAXPATHLEN): Define only if needed.
a70072c9 6745
a0977c44
PE
6746 * process.c (serial_open, serial_configure): Move decls from here ...
6747 * systty.h: ... to here, so that they can be checked.
6748
a884fdcc
PE
6749 * fns.c (get_random, seed_random): Move extern decls from here ...
6750 * lisp.h: ... to here, so that they can be checked.
6751
604efe86 6752 * sysdep.c (reset_io): Now static.
b8950c94 6753 (wait_for_termination_signal): Remove; unused.
604efe86 6754
38fc62d9
PE
6755 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6756 (copy_keymap_item, append_key, push_text_char_description):
6757 Now static.
1004a21a 6758 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6759 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6760 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6761 (describe_map_tree):
6762 Rename locals to avoid shadowing.
38fc62d9 6763
2f2650da
PE
6764 * keyboard.c: Declare functions static if they are not used elsewhere.
6765 (echo_char, echo_dash, cmd_error, top_level_2):
6766 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6767 (read_char, kbd_buffer_get_event, make_lispy_position):
6768 (make_lispy_event, make_lispy_movement, apply_modifiers):
6769 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6770 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6771 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6772 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6773 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6774
a053e86c 6775 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6776 (mark_kboards): Move decl here ...
6777 * alloc.c (mark_kboards): ... from here.
a053e86c 6778
4752793e
PE
6779 * lisp.h (force_auto_save_soon): New decl.
6780
74f10ca7 6781 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6782 (DEFINE_DUMMY_FUNCTION): New macro.
6783 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6784 Use it.
c03cd23f
PE
6785 (main): Add casts to avoid warnings
6786 if GCC considers string literals to be constants.
74f10ca7 6787
022e70d4
PE
6788 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6789
59d6fe83
PE
6790 * dbusbind.c: Pointer signedness fixes.
6791 (xd_signature, xd_append_arg, xd_initialize):
6792 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6793 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6794 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6795 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6796
78320123
PE
6797 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6798 if GCC considers string literals to be constants.
49cebcca 6799 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6800
35ac2a97
SM
68012011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6802
fb103ca9
SM
6803 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6804 (print_preprocess, print_object): New macro to fix last change.
6805
35ac2a97
SM
6806 * print.c (print_preprocess): Don't forget font objects.
6807
62973b41
JB
68082011-03-16 Juanma Barranquero <lekktu@gmail.com>
6809
6810 * emacs.c (USAGE3): Doc fixes.
6811
0e48bb22
AS
68122011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6813
6814 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6815 structure.
6816
7684e57b
JB
68172011-03-14 Juanma Barranquero <lekktu@gmail.com>
6818
6819 * lisp.h (VWindow_system, Qfile_name_history):
6820 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6821 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6822 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6823
6824 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6825 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6826
6827 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6828 * w32console.c (detect_input_pending, read_input_pending)
6829 (encode_terminal_code):
6830 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6831 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6832 (w32_system_caret_y, Qfile_name_history):
6833 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6834 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6835 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6836 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6837 * w32proc.c (Qlocal, report_file_error):
6838 * w32term.c (Vwindow_system, updating_frame):
6839 * w32uniscribe.c (initialized, uniscribe_font_driver):
6840 Remove unneeded extern declarations.
6841
2aa46d6c
CY
68422011-03-14 Chong Yidong <cyd@stupidchicken.com>
6843
c96bbc66 6844 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6845
cffc6f3b
CY
68462011-03-13 Chong Yidong <cyd@stupidchicken.com>
6847
6848 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6849 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6850 These macros can no longer be used for assignment.
6851
44f230aa
SM
6852 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6853 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6854 (record_buffer_markers, fetch_buffer_markers): New functions for
6855 recording and fetching special buffer markers.
6856 (set_buffer_internal_1, set_buffer_temp): Use them.
6857
6858 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6859
6860 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6861
6862 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6863 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6864
6865 * xdisp.c (hscroll_window_tree):
6866 (reconsider_clip_changes): Use PT instead of BUF_PT.
6867
d251f04b
EZ
68682011-03-13 Eli Zaretskii <eliz@gnu.org>
6869
6870 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6871 $(EMACS_ROOT)/lib/intprops.h.
6872
f0c77cd1
PE
68732011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6874
3eca4629
PE
6875 Fix more problems found by GCC 4.5.2's static checks.
6876
7c86ee98
PE
6877 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6878 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6879 (xg_free_frame_widgets): Make it clear that a local variable is
6880 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6881 (gdk_window_get_screen): Make it clear that this macro is needed
6882 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6883 (int_gtk_range_get_value): New function, which avoids a diagnostic
6884 from gcc -Wbad-function-cast.
6885 (xg_set_toolkit_scroll_bar_thumb): Use it.
6886 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6887 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6888 (get_utf8_string, xg_get_file_with_chooser):
6889 Rename locals to avoid shadowing.
6890 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6891
41729b81
PE
6892 * xgselect.c (xg_select): Remove unused var.
6893
f0c77cd1
PE
6894 * image.c (four_corners_best): Mark locals as initialized.
6895 (gif_load): Initialize transparent_p to zero (Bug#8238).
6896 Mark another local as initialized.
ec6cf4c6 6897 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6898
ce0ad53d 6899 * image.c (clear_image_cache): Now static.
d5d5a617 6900 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6901 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6902 (x_edge_detection): Remove unnecessary cast that
6903 gcc -Wbad-function-cast diagnoses.
2037898d 6904 (gif_load): Fix pointer signedness.
6ae141d6
PE
6905 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6906 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6907
33383987 69082011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6909
d32df629
PE
6910 Improve quality of tests for time stamp overflow.
6911 For example, without this patch (encode-time 0 0 0 1 1
6912 1152921504606846976) returns the obviously-bogus value (-948597
6913 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6914 reports time overflow. See
6915 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6916 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6917 * editfns.c: Include limits.h and intprops.h.
6918 (TIME_T_MIN, TIME_T_MAX): New macros.
6919 (time_overflow): Move earlier, to before first use.
6920 (hi_time, lo_time): New functions, for an accurate test for
6921 out-of-range times.
6922 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6923 (Fget_internal_run_time): Don't assume time_t fits in int.
6924 (make_time): Use list2 instead of Fcons twice.
6925 (Fdecode_time): More accurate test for out-of-range times.
6926 (check_tm_member): New function.
6927 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6928 (lisp_time_argument): Don't rely on undefined left-shift and
6929 right-shift behavior when checking for time stamp overflow.
8be6f318 6930
fe31d94c
PE
6931 * editfns.c (time_overflow): New function, refactoring common code.
6932 (Fformat_time_string, Fdecode_time, Fencode_time):
6933 (Fcurrent_time_string): Use it.
6934
8be6f318
PE
6935 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6936 * dired.c (make_time): Move to ...
6937 * editfns.c (make_time): ... here.
6938 * systime.h: Note the move.
6939
09d9db2c 69402011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6941
126bc0dc
YM
6942 * fringe.c (update_window_fringes): Remove unused variables.
6943
c47cbdfd
YM
6944 * unexmacosx.c (copy_data_segment): Also copy __got section.
6945 (Bug#8223)
6946
7ac80be9
EZ
69472011-03-12 Eli Zaretskii <eliz@gnu.org>
6948
c96bbc66 6949 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6950 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6951 Constify `char *' arguments and their references according to
6952 prototypes in tparam.h.
6953
ecb0f94d 6954 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6955
7ac80be9
EZ
6956 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6957 Adapt all references accordingly.
6958
6959 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6960
ef1fd07e
TT
69612011-03-11 Tom Tromey <tromey@redhat.com>
6962
6963 * buffer.c (syms_of_buffer): Remove obsolete comment.
6964
7ef4b50c
EZ
69652011-03-11 Eli Zaretskii <eliz@gnu.org>
6966
6967 * termhooks.h (encode_terminal_code): Declare prototype.
6968
6969 * msdos.c (encode_terminal_code): Don't declare prototype.
6970
6971 * term.c (encode_terminal_code): Now external again, used by
6972 w32console.c and msdos.c.
6973
44f230aa
SM
6974 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6975 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6976
4b1ec863 69772011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6978
1714f52b 6979 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6980
4b1ec863
PE
6981 * fringe.c (update_window_fringes): Mark locals as initialized
6982 (Bug#8227).
6983 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6984
524c7aa6
PE
6985 * alloc.c (mark_fringe_data): Move decl from here ...
6986 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6987 to check its interface.
6988 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6989
a5c0af81 6990 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6991 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6992 (fontset_font): Mark local as initialized.
a9a06e0b 6993 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6994
b4716021
PE
6995 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6996
811e9bac 6997 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6998 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6999 (x_own_selection, Fx_disown_selection_internal): Rename locals
7000 to avoid shadowing.
7001 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7002
7e3ab302
PE
7003 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7004 so that the caller can use some name other than gcpro1.
7005 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7006 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7007 (Fx_backspace_delete_keys_p):
7008 Use them to avoid shadowing, and rename vars to avoid shadowing.
7009 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7010 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7011 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7012 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7013 Remove unused locals.
7e3ab302
PE
7014 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7015 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7016 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7017 macros.
f78faa98 7018
e2b13473
PE
7019 * xterm.h (x_mouse_leave): New decl.
7020
77f23912
PE
7021 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7022 Remove unused functions.
cdf4ba58
PE
7023 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7024 (x_calc_absolute_position): Now static.
7411c686 7025 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7026 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7027 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7028 unless they are used.
38d0b34a
PE
7029 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7030 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7031 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7032 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7033 (x_error_catcher, x_connection_closed, x_error_handler):
7034 (x_error_quitter, xembed_send_message, x_iconify_frame):
7035 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7036 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7037 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7038
44f230aa
SM
7039 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7040 Rename or move locals to avoid shadowing.
6b463e58 7041 (tty_defined_color, merge_face_heights): Now static.
5967d051 7042 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7043 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7044 does not deduce is never used uninitialized.
73719eba
PE
7045 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7046 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7047
426994c3 7048 * terminal.c (store_terminal_param): Now static.
5489860b 7049
032f1620 7050 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7051 (set_frame_menubar): Remove unused local.
d4323972 7052 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7053 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7054 since they might point to immutable storage.
281585b0
PE
7055 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7056 since it's unused otherwise.
032f1620 7057
367c19e5 7058 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7059 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7060 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7061 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7062 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7063 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7064 does not deduce are never used uninitialized.
70739cbe 7065
07b48fa9
PE
7066 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7067
8868a238 7068 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7069 * window.c (window_loop, size_window):
7070 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7071
7e5cf297 7072 * window.c (display_buffer): Now static.
d6550a9f
PE
7073 (size_window): Mark variables that gcc -Wuninitialized
7074 does not deduce are never used uninitialized.
a586633d
PE
7075 * window.h (check_all_windows): New decl, to forestall
7076 gcc -Wmissing-prototypes diagnostic.
5b555da1 7077 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7078
f6095868
PE
7079 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7080 shadowing.
7081 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7082 Include <limits.h>.
7083 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7084 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7085 (load_charset_map): Mark variables that gcc -Wuninitialized
7086 does not deduce are never used uninitialized.
53df7c11 7087 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7088
f38b440c
PE
7089 * coding.c (coding_set_source, coding_set_destination):
7090 Use "else { /* comment */ }" rather than "else /* comment */;"
7091 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7092 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7093 a block, when the outer 'i' will do.
7094 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7095 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7096 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7097 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7098 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7099 Rename locals to avoid shadowing.
7100 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7101 * coding.c (emacs_mule_char, encode_invocation_designation):
7102 Now static, since they're not used elsewhere.
413bb2db 7103 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7104 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7105 (decode_coding_emacs_mule): Mark variables that gcc
7106 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7107 (detect_coding_iso_2022): Initialize a local variable that might
7108 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7109 this initialization is needed. (Bug#8211)
5f58e762
PE
7110 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7111 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7112 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7113 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7114 Remove unused macros.
f38b440c 7115
232b38b9 7116 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7117 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7118 * character.c (string_count_byte8): Likewise.
232b38b9 7119
fb90da1b
PE
7120 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7121 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7122
fb93dbc2
PE
7123 * chartab.c (copy_sub_char_table): Now static, since it's not used
7124 elsewhere.
5c156ace
PE
7125 (sub_char_table_ref_and_range, char_table_ref_and_range):
7126 Rename locals to avoid shadowing.
bbcd0949 7127 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7128
7d3b3862 7129 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7130 (BIDI_BOB): Remove unused macro.
7d3b3862 7131
6be7d3da
PE
7132 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7133 deduce are never used uninitialized.
c2ed9c8b 7134 * term.c (encode_terminal_code): Likewise.
6be7d3da 7135
75f8807f 7136 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7137
50938595
PE
7138 * tparam.h: New file.
7139 * term.c, tparam.h: Include it.
7140 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7141 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7142 Move these decls to tparam.h, and make them agree with what
7143 is actually in tparam.c. The previous trick of using incompatible
7144 decls in different modules does not conform to the C standard.
7145 All callers of tparam changed to use tparam's actual API.
7146 * tparam.c (tparam1, tparam, tgoto):
7147 Use const pointers where appropriate.
7148
fbceeba2
PE
7149 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7150 * cm.h (struct cm): Likewise.
7151 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7152 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7153 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7154 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7155 (turn_on_face, init_tty): Likewise.
7156 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7157
7f3f1250
PE
7158 * term.c (term_mouse_position): Rename local to avoid shadowing.
7159
e6ca6543
PE
7160 * alloc.c (mark_ttys): Move decl from here ...
7161 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7162
c40f8d15
AS
71632011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7164
7165 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7166
cfe0661d
JB
71672011-03-09 Juanma Barranquero <lekktu@gmail.com>
7168
7169 * search.c (compile_pattern_1): Remove argument regp, unused since
7170 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7171 (compile_pattern): Don't pass it.
7172
0afb4571
J
71732011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7174
7175 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7176 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7177 for ! HAVE_GTK3.
7178 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7179
7180 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7181
7182 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7183 gdk_window_get_screen, gdk_window_get_geometry,
7184 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7185 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7186 (xg_get_pixbuf_from_pixmap): New function.
7187 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7188 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7189 Call xg_get_pixbuf_from_pixmap instead of
7190 gdk_pixbuf_get_from_drawable.
7191 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7192 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7193 (xg_check_special_colors): Use GtkStyleContext and its functions
7194 for HAVE_GTK3.
7195 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7196 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7197 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7198 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7199 Call gtk_widget_get_preferred_size.
0afb4571
J
7200 (xg_frame_resized): gdk_window_get_geometry only takes 5
7201 parameters.
44f230aa
SM
7202 (xg_win_to_widget, xg_event_is_for_menubar):
7203 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7204 (xg_set_widget_bg): New function.
7205 (delete_cb): New function.
895009e1 7206 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7207 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7208 (xg_set_background_color): Call xg_set_widget_bg.
7209 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7210 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7211 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7212 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7213 if ! HAVE_GTK3.
7214 (update_frame_tool_bar): Call gtk_widget_hide.
7215 (xg_initialize): Use GDK_KEY_g.
7216
7217 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7218 if ! HAVE_GTK3
7219 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7220
7221 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7222 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7223 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7224
1c2cc4ef
JB
72252011-03-08 Juanma Barranquero <lekktu@gmail.com>
7226
7227 * w32xfns.c (select_palette): Check success of RealizePalette against
7228 GDI_ERROR, not zero.
7229
33383987 7230See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7231
7232;; Local Variables:
7233;; coding: utf-8
aac0c6e3
MR
7234;; End:
7235
33383987 7236 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7237
7238 This file is part of GNU Emacs.
7239
7240 GNU Emacs is free software: you can redistribute it and/or modify
7241 it under the terms of the GNU General Public License as published by
7242 the Free Software Foundation, either version 3 of the License, or
7243 (at your option) any later version.
7244
7245 GNU Emacs is distributed in the hope that it will be useful,
7246 but WITHOUT ANY WARRANTY; without even the implied warranty of
7247 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7248 GNU General Public License for more details.
7249
7250 You should have received a copy of the GNU General Public License
7251 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.