alloc.c: Import and export fewer symbols, and remove unused items.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
16a97296
PE
12011-04-11 Paul Eggert <eggert@cs.ucla.edu>
2
244ed907
PE
3 alloc.c: Import and export fewer symbols, and remove unused items.
4 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5 is defined.
6 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7 it's not optimized away by whole-program optimization.
8 (message_enable_multibyte, free_misc): Remove.
9 (catchlist, handlerlist, mark_backtrace):
10 Declare only if BYTE_MARK_STACK.
11 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13 (message_enable_multibyte): Remove decl.
14 (free_misc, interval_free_list, float_block, float_block_index):
15 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16 (cons_free_list, last_marked_index):
17 Now static.
18 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
19 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
20 (mark_backtrace): Define only if BYTE_MARK_STACK.
21 * xdisp.c (message_enable_multibyte): Now static.
22
955cbe7b
PE
23 Declare Lisp_Object Q* variables to be 'static' if not exproted.
24 This makes it easier for human readers (and static analyzers)
25 to see whether these variables are used from other modules.
26 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
27 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
28 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
29 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
30 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
31 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
32 * xmenu.c, xselect.c:
33 Declare Q* vars static if they are not used in other modules.
34 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
35 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
36 Remove decls of unexported vars.
37 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
38
95c82688
PE
39 * lisp.h (DEFINE_FUNC): Make sname 'static'.
40
16a97296
PE
41 Make Emacs functions such as Fatom 'static' by default.
42 This makes it easier for human readers (and static analyzers)
43 to see whether these functions can be called from other modules.
44 DEFUN now defines a static function. To make the function external
45 so that it can be used in other C modules, use the new macro DEFUE.
46 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
47 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
48 static function definition. Use DEFUE if you want an extern one.
49 (DEFUE, INFUN): New macros.
50 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
51 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
52 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
53 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
54 Remove decls, since these functions are now static.
55 (Funintern, Fget_internal_run_time): New decls, since these functions
56 were already external.
95c82688 57
16a97296
PE
58 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
59 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
60 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
61 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
62 * keyboard.c, keymap.c, lread.c:
63 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
64 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
65 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
66 Mark functions with DEFUE instead of DEFUN,
67 if they are used in other modules.
68 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
69 decls for now-static functions.
70 * buffer.h (Fdelete_overlay): Remove decl.
71 * callproc.c (Fgetenv_internal): Mark as internal.
72 * composite.c (Fremove_list_of_text_properties): Remove decl.
73 (Fcomposition_get_gstring): New forward static decl.
74 * composite.h (Fcomposite_get_gstring): Remove decl.
75 * dired.c (Ffile_attributes): New forward static decl.
76 * doc.c (Fdocumntation_property): New forward static decl.
77 * eval.c (Ffetch_bytecode): New forward static decl.
78 (Funintern): Remove extern decl; now in .h file where it belongs.
79 * fileio.c (Fmake_symbolic_link): New forward static decl.
80 * image.c (Finit_image_library): New forward static decl.
81 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
82 * intervals.h (Fprevious_property_change):
83 (Fremove_list_of_text_properties): Remove decls.
84 * keyboard.c (Fthis_command_keys): Remove decl.
85 (Fcommand_execute): New forward static decl.
86 * keymap.c (Flookup_key): New forward static decl.
87 (Fcopy_keymap): Now static.
88 * keymap.h (Flookup_key): Remove decl.
89 * process.c (Fget_process): New forward static decl.
90 (Fprocess_datagram_address): Mark as internal.
91 * syntax.c (Fsyntax_table_p): New forward static decl.
92 (skip_chars): Remove duplicate decl.
93 * textprop.c (Fprevious_property_change): New forward static decl.
94 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
95 Now internal.
96 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
97 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
98
785bbd42
PE
992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
100
101 * editfns.c (Fformat): Remove unreachable code.
102
4073e537 1032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 104
b2ded58d
PE
105 Fix more problems found by GCC 4.6.0's static checks.
106
7d66342c
PE
107 * xdisp.c (vmessage): Use a better test for character truncation.
108
bbf47d44
PE
109 * charset.c (load_charset_map): <, not <=, for optimization,
110 and to avoid potential problems with integer overflow.
9248994d 111 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 112 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 113 * editfns.c (Fformat): Likewise.
1e69125e 114 * syntax.c (skip_chars): Likewise.
3befa583 115
e3019616
PE
116 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
117 This also lets GCC 4.6.0 generate slightly better loop code.
118
becfa255
PE
119 * callint.c (Fcall_interactively): <, not <=, for optimization.
120 (Fcall_interactively): Count the number of arguments produced,
121 not the number of arguments given. This is simpler and lets GCC
122 4.6.0 generate slightly better code.
123
dae0cd48
PE
124 * ftfont.c: Distingish more carefully between FcChar8 and char.
125 The previous code passed unsigned char * to a functions like
126 strlen and xstrcasecmp that expect char *, which does not
127 conform to the C standard.
128 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
129 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
130 char * when the C standard requires it.
131
76032d70
PE
132 * keyboard.c (read_char): Remove unused var.
133
eb3f1cc8
PE
134 * eval.c: Port to Windows vsnprintf (Bug#8435).
135 Include <limits.h>.
136 (SIZE_MAX): Define if the headers do not.
137 (verror): Do not give up if vsnprintf returns a negative count.
138 Instead, grow the buffer. This ports to Windows vsnprintf, which
139 does not conform to C99. Problem reported by Eli Zaretskii.
140 Also, simplify the allocation scheme, by avoiding the need for
141 calling realloc, and removing the ALLOCATED variable.
142
70476b54
PE
143 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
144
12020a9e
PE
145 Remove invocations of doprnt, as Emacs now uses vsnprintf.
146 But keep the doprint source code for now, as we might revamp it
147 and use it again (Bug#8435).
ea6c7ae6
PE
148 * lisp.h (doprnt): Remove.
149 * Makefile.in (base_obj): Remove doprnt.o.
150 * deps.mk (doprnt.o): Remove.
151
5fdb398c
PE
152 error: Print 32- and 64-bit integers portably (Bug#8435).
153 Without this change, on typical 64-bit hosts error ("...%d...", N)
154 was used to print both 32- and 64-bit integers N, which relied on
155 undefined behavior.
156 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
157 New macro.
158 * lisp.h (error, verror): Mark as printf-like functions.
159 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
160 Report overflow in size calculations when allocating printf buffer.
161 Do not truncate output string at its first null byte.
162 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
163 Truncate the output at a character boundary, since vsnprintf does not
164 do that.
165 * charset.c (check_iso_charset_parameter): Convert internal
166 character to string before calling 'error', since %c now has the
167 printf meaning.
168 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
169 overflow when computing char to be passed to 'error'. Do not
170 pass Lisp_Object to 'error'; pass the integer instead.
171 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
172 formatted with plain %d.
173
b189fa66
PE
174 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
175
bff87ef0
PE
176 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
177
7e2cac20
PE
178 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
179
ce4d90b5
PE
180 * xterm.c (x_catch_errors): Remove duplicate declaration.
181
266c9547
PE
182 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
183
79c49ad2
PE
184 * xdisp.c, lisp.h (message_nolog): Remove; unused.
185
368f4090
JM
1862011-04-10 Jim Meyering <meyering@redhat.com>
187
188 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
189 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
190 return ssize_t not "int", and use size_t as the buffer length.
191 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
192 * gnutls.h: Update declarations.
193 * process.c (read_process_output): Use ssize_t, to match.
194 (send_process): Likewise.
195
a32d4040
CY
1962011-04-09 Chong Yidong <cyd@stupidchicken.com>
197
198 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
199
8546720e 2002011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 201
8546720e
GM
202 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
203 unsigned char, to match FcChar8 type definition.
aac0c6e3 204
8546720e
GM
205 * xterm.c (handle_one_xevent):
206 * xmenu.c (create_and_show_popup_menu):
207 * xselect.c (x_decline_selection_request)
208 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 209
a53e2e89
EZ
2102011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
211
212 Fix some uses of `int' instead of EMACS_INT.
213 * search.c (string_match_1, fast_string_match)
214 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
215 (scan_buffer, find_next_newline_no_quit)
216 (find_before_next_newline, search_command, Freplace_match)
217 (Fmatch_data): Make some `int' variables be EMACS_INT.
218
219 * xdisp.c (display_count_lines): 3rd argument and return value now
220 EMACS_INT. All callers changed.
221 (pint2hrstr): Last argument is now EMACS_INT.
222
223 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
224 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
225 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
226 (decode_coding_utf_16, decode_coding_emacs_mule)
227 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
228 (decode_coding_ccl, decode_coding_charset)
229 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
230 (decode_coding_iso_2022, decode_coding_emacs_mule)
231 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
232 <char_offset, last_offset>: Declare EMACS_INT.
233 (encode_coding_utf_8, encode_coding_utf_16)
234 (encode_coding_emacs_mule, encode_invocation_designation)
235 (encode_designation_at_bol, encode_coding_iso_2022)
236 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
237 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
238 Declare EMACS_INT.
239 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
240 (encode_invocation_designation): Last argument P_NCHARS is now
241 EMACS_INT.
242 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
243 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
244
245 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
246 All users changed.
247
248 * ccl.c (Fccl_execute_on_string): Declare some variables
249 EMACS_INT.
250
8546720e 2512011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
252
253 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
254
4e19a977
CS
2552011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
256
257 * process.c (Fformat_network_address): Doc fix.
258
87302331
R
2592011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
260
261 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
262
cbb59342
CY
2632011-04-08 Chong Yidong <cyd@stupidchicken.com>
264
265 * keyboard.c (read_char): Call Lisp function help-form-show,
266 instead of using internal_with_output_to_temp_buffer.
267 (Qhelp_form_show): New var.
e0d38eeb 268 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
269
270 * print.c (internal_with_output_to_temp_buffer): Function deleted.
271
272 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
273
e67a13ab
CY
2742011-04-06 Chong Yidong <cyd@stupidchicken.com>
275
276 * process.c (Flist_processes): Removed to Lisp.
277 (list_processes_1): Deleted.
278
973f782d
EZ
2792011-04-06 Eli Zaretskii <eliz@gnu.org>
280
7c106b1e
EZ
281 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
282
973f782d
EZ
283 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
284
41cf7d1a 2852011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 286
ca23cc88
PE
287 Fix more problems found by GCC 4.6.0's static checks.
288
f390e2d5
PE
289 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
290
42eea0d0
PE
291 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
292
b69769da 293 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 294
f9541e84
PE
295 * xdisp.c (vmessage): Mark as a printf-like function.
296
13841b55
PE
297 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
298
c136c10f
PE
299 * sound.c (sound_warning): Don't crash if arg contains a printf format.
300
5e2d4a30
PE
301 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
302 printf-like functions.
303 (tiff_load): Add casts to remove these marks before passing them
304 to system-supplied API.
305
583f48b9
PE
306 * eval.c (Fsignal): Remove excess argument to 'fatal'.
307
b25d760e
PE
308 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
309 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
310 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
311 directly, rather than having caller test rule sign. This avoids
312 some unnecessary tests.
313 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
314 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
315 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 316
bc7b6697 317 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 318 (xfont_open): Avoid unnecessary tests.
bc7b6697 319
27ccc379
PE
320 * composite.c (composition_gstring_put_cache): Use unsigned integer.
321
dcd5c89a
PE
322 * composite.h, composite.c (composition_gstring_put_cache):
323 Use EMACS_INT, not int, for length.
324
b13a45c6
PE
325 * composite.h (COMPOSITION_DECODE_REFS): New macro,
326 breaking out part of COMPOSITION_DECODE_RULE.
327 (COMPOSITION_DECODE_RULE): Use it.
328 * composite.c (get_composition_id): Remove unused local vars,
329 by using the new macro.
330
1e792e4d
PE
331 * textprop.c (set_text_properties_1): Change while to do-while,
332 since the condition is always true at first.
333
dc6c6455 334 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
335 (interval_deletion_adjustment): Return unsigned value.
336 All uses changed.
dc6c6455 337
aba7731a
PE
338 * process.c (list_processes_1, create_pty, read_process_output):
339 (exec_sentinel): Remove vars that were set but not used.
afd4052b 340 (create_pty): Remove unnecessary "volatile"s.
bc57d757 341 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 342 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 343 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 344
fdfc4bf3
PE
345 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
346
fca8fe46 347 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 348 (update_syntax_table): Use unsigned instead of int.
fca8fe46 349
06a0259a 350 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 351 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 352 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 353
e7b9e80f
PE
354 * print.c (print_error_message): Avoid int overflow.
355
56201685
PE
356 * font.c (font_list_entities): Redo for clarity,
357 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
358
78834453 359 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 360 (font_score): Avoid potential overflow in diff calculation.
78834453 361
0bc0b309 362 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 363 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 364
e610eaca
PE
365 * eval.c (funcall_lambda): Rename local to avoid shadowing.
366
b895abce
PE
367 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
368 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
369 can always succeed if overflow has undefined behavior.
370
1f1d9321 371 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 372 (wordify): Omit three unnecessary tests.
1f1d9321 373
c59478bc
PE
374 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
375 All callers changed. This avoids the need for an unused var.
376
79b73827
PE
377 * casefiddle.c (casify_region): Remove var that is set but not used.
378
a4db5dfe
PE
379 * dired.c (file_name_completion): Remove var that is set but not used.
380
43aae36e
PE
381 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
382
2a47c44d 383 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 384 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 385
a37c69bf
PE
386 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
387 Check for integer overflow on size calculations.
388
328ab8e7
PE
389 * buffer.c (Fprevious_overlay_change): Remove var that is set
390 but not used.
391
e5a2a5cb
PE
392 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
393 Remove vars that are set but not used.
8d84a6eb 394 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 395 (timer_check_2): Mark vars as initialized.
e5a2a5cb 396
a60e5f68
PE
397 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
398
f661cb61 399 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 400 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 401
f0397f5a
PE
402 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
403 that are set but not used.
404
8664db06 405 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 406 if XCreateBitmapFromData fails (Bug#8410).
8664db06 407
6abdaa4a
PE
408 * xselect.c (x_get_local_selection, x_handle_property_notify):
409 Remove vars that are set but not used.
410
0ce7538d 411 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 412 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 413
9ae848fc
PE
414 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
415 Remove var that is set but not used.
0b918413
PE
416 (scroll_bar_windows_size): Now size_t, not int.
417 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
418 Check for overflow.
9ae848fc 419
a5a62657
PE
420 * xfaces.c (realize_named_face): Remove vars that are set but not used.
421 (map_tty_color) [!defined MSDOS]: Likewise.
422
5c5cdd39
PE
423 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
424
66ebf983
PE
425 * coding.c: Remove vars that are set but not used.
426 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
427 All callers changed.
428 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
429 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
430 (decode_coding_charset): Remove vars that are set but not used.
431
1be4d761
PE
432 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
433 that is set but not used.
434
47553fa8
PE
435 * print.c (print_object): Remove var that is set but not used.
436
1f7196bf 437 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
438 The gnulib version avoids calling malloc in the usual case,
439 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
440 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
441 * filelock.c (current_lock_owner): Likewise.
442 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
443 * sysdep.c: Include allocator.h, careadlinkat.h.
444 (emacs_no_realloc_allocator): New static constant.
445 (emacs_readlink): New function.
fdb61804
PE
446 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
447 ../lib/careadlinkat.h.
d1fdcab7 448
f84c17c7
SM
4492011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
450
451 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
452 first non-nil return value).
453
ef3862ad
JD
4542011-04-03 Jan Djärv <jan.h.d@swipnet.se>
455
456 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
457 if not defined (Bug#8403).
458
376a7006
JB
4592011-04-02 Juanma Barranquero <lekktu@gmail.com>
460
461 * xdisp.c (display_count_lines): Remove parameter `start',
462 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
463 (get_char_face_and_encoding): Remove parameter `multibyte_p',
464 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
465 (fill_stretch_glyph_string): Remove parameters `row' and `area',
466 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
467 and thereabouts. All callers changed.
468 (get_per_char_metric): Remove parameter `f', unused since
469 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
470
6ca3801d
JM
4712011-04-02 Jim Meyering <meyering@redhat.com>
472
473 do not dereference NULL upon failed strdup
474 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
475 (ns_get_family): Likewise.
476
d8e2b5ba
JB
4772011-04-02 Juanma Barranquero <lekktu@gmail.com>
478
479 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
480
8c74fcbd
JD
4812011-04-02 Jan Djärv <jan.h.d@swipnet.se>
482
483 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
484 later (Bug#8403).
485
7200d79c
SM
4862011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
487
03408648 488 Add lexical binding.
7200d79c 489
03408648
SM
490 * window.c (Ftemp_output_buffer_show): New fun.
491 (Fsave_window_excursion):
492 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
493
494 * lread.c (lisp_file_lexically_bound_p): New function.
495 (Fload): Bind Qlexical_binding.
496 (readevalloop): Remove `evalfun' arg.
497 Bind Qinternal_interpreter_environment.
498 (Feval_buffer): Bind Qlexical_binding.
499 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
500 Mark as dynamic.
501 (syms_of_lread): Declare `lexical-binding'.
502
503 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
504
505 * keyboard.c (eval_dyn): New fun.
506 (menu_item_eval_property): Use it.
ca105506
SM
507
508 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 509
03408648
SM
510 * fns.c (concat, mapcar1): Accept byte-code-functions.
511
512 * eval.c (Fsetq): Handle lexical vars.
513 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
514 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
515 (FletX, Flet): Obey lexical binding.
516 (Fcommandp): Handle closures.
517 (Feval): New `lexical' arg.
518 (eval_sub): New function extracted from Feval. Use it almost
519 everywhere where Feval was used. Look up vars in lexical env.
520 Handle closures.
521 (Ffunctionp): Move from subr.el.
522 (Ffuncall): Handle closures.
523 (apply_lambda): Remove `eval_flags'.
524 (funcall_lambda): Handle closures and new byte-code-functions.
525 (Fspecial_variable_p): New function.
526 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
527 but without exporting it to Lisp.
23aba0ea 528
23aba0ea 529 * doc.c (Fdocumentation, store_function_docstring):
03408648 530 * data.c (Finteractive_form): Handle closures.
23aba0ea 531
03408648
SM
532 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
533 interactive spec.
ba83908c 534
03408648
SM
535 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
536 byte-codes.
537 (exec_byte_code): New function extracted from Fbyte_code to handle new
538 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 539
03408648 540 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 541
03408648 542 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 543
e2abce01
JB
5442011-03-31 Juanma Barranquero <lekktu@gmail.com>
545
546 * xdisp.c (redisplay_internal): Fix prototype.
547
63696a73 5482011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 549
63696a73
EZ
550 * xdisp.c (SCROLL_LIMIT): New macro.
551 (try_scrolling): Use it when setting scroll_limit. Limit
552 scrolling to 100 screen lines.
553 (redisplay_window): Even when falling back on "recentering",
554 position point in the window according to scroll-conservatively,
555 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
556
557 (try_scrolling): When point is above the window, allow searching
558 as far as scroll_max, or one screenful, to compute vertical
559 distance from PT to the scroll margin position. This prevents
560 try_scrolling from unnecessarily failing when
561 scroll-conservatively is set to a value slightly larger than the
562 window height. Clean up the case of PT below the margin at bottom
563 of window: scroll_max can no longer be INT_MAX. When aggressive
564 scrolling is in use, don't let point enter the opposite scroll
565 margin as result of the scroll.
566 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
567 threshold of 100 lines for never-recentering scrolling.
568
e4cc2dfc
JB
5692011-03-31 Juanma Barranquero <lekktu@gmail.com>
570
571 * dispextern.h (move_it_by_lines):
572 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
573 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
574 (message_log_check_duplicate): Remove parameters `prev_bol' and
575 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
576 (redisplay_internal): Remove parameter `preserve_echo_area',
577 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
578
579 * indent.c (Fvertical_motion):
580 * window.c (window_scroll_pixel_based, Frecenter):
581 Don't pass `need_y_p' to `move_it_by_lines'.
582
1c470562
SM
5832011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
584
44f230aa
SM
585 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
586 steal a few bits to be more compact.
587 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
588 Remove unneeded casts.
589
1c470562
SM
590 * bytecode.c (Fbyte_code): CAR and CDR can GC.
591
888adce9
ZK
5922011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
593
594 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
595 binding" message (bug#7967).
596
f838ed7b
PE
5972011-03-30 Paul Eggert <eggert@cs.ucla.edu>
598
77861b95
PE
599 Fix more problems found by GCC 4.6.0's static checks.
600
de6dbc14
PE
601 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
602 Remove unused local var.
603
f838ed7b
PE
604 * editfns.c (Fmessage_box): Remove unused local var.
605
792c7b2b
PE
606 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
607 (note_mode_line_or_margin_highlight, note_mouse_highlight):
608 Omit unused local vars.
c499e557 609 * window.c (shrink_windows): Omit unused local var.
b01a1c29 610 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
611 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
612 Omit unused local var.
613
ba0165e1
PE
614 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
615 Don't assume string length fits in int.
32ad8845 616 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 617 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 618
3c59b4c9
PE
619 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
620 instead of alloca (Bug#8344).
621
a3eed478 622 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 623 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 624
eb4d412d
PE
625 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
626
1658b401
PE
627 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
628 concerns.
629
630 * term.c (produce_glyphless_glyph): Remove unnecessary test.
631
632 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 633
9a2c6e05
PE
634 * keyboard.c (syms_of_keyboard): Use the same style as later
635 in this function when indexing through an array. This also
636 works around GCC bug 48267.
637
03d0a109
PE
638 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
639
44f730c8
PE
640 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
641
fe75f926
PE
642 * chartab.c (sub_char_table_ref_and_range): Redo for slight
643 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
644
ffa8c828
PE
645 * keyboard.c, keyboard.h (num_input_events): Now size_t.
646 This avoids undefined behavior on integer overflow, and is a bit
647 more convenient anyway since it is compared to a size_t variable.
648
c5101a77
PE
649 Variadic C functions now count arguments with size_t, not int.
650 This avoids an unnecessary limitation on 64-bit machines, which
651 caused (substring ...) to crash on large vectors (Bug#8344).
652 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
653 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 654 All variadic functions and their callers changed accordingly.
c5101a77
PE
655 (struct gcpro.nvars): Now size_t, not int. All uses changed.
656 * data.c (arith_driver, float_arith_driver): Likewise.
657 * editfns.c (general_insert_function): Likewise.
658 * eval.c (struct backtrace.nargs, interactive_p)
659 (internal_condition_case_n, run_hook_with_args, apply_lambda)
660 (funcall_lambda, mark_backtrace): Likewise.
661 * fns.c (concat): Likewise.
662 * frame.c (x_set_frame_parameters): Likewise.
663 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
664 0 if not found, not -1. All callers changed.
665
dd3f25f7
PE
666 * alloc.c (garbage_collect): Don't assume stack size fits in int.
667 (stack_copy_size): Now size_t, not int.
668 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
669
461c2ab9
JB
6702011-03-28 Juanma Barranquero <lekktu@gmail.com>
671
672 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
673 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
674 All callers changed.
675
676 * lisp.h (multibyte_char_to_unibyte):
677 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
678 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
679 * character.h (CHAR_TO_BYTE8):
680 * cmds.c (internal_self_insert):
681 * editfns.c (general_insert_function):
682 * keymap.c (push_key_description):
683 * search.c (Freplace_match):
684 * xdisp.c (message_dolog, set_message_1): All callers changed.
685
f6d62986
SM
6862011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
687
688 * keyboard.c (safe_run_hook_funcall): New function.
689 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
690 don't set the hook to nil, but remove the offending function instead.
691 (Qcommand_hook_internal): Remove, unused.
692 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
693 Vcommand_hook_internal.
694
695 * eval.c (enum run_hooks_condition): Remove.
696 (funcall_nil, funcall_not): New functions.
697 (run_hook_with_args): Call each function through a `funcall' argument.
698 Remove `cond' argument, now redundant.
699 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
700 (Frun_hook_with_args_until_failure): Adjust accordingly.
701 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
702
1db5b1ad
JB
7032011-03-28 Juanma Barranquero <lekktu@gmail.com>
704
705 * dispextern.h (string_buffer_position): Remove declaration.
706
707 * print.c (strout): Remove parameter `multibyte', unused since
708 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
709
710 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
711 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
712 All callers changed.
713
714 * w32.c (_wsa_errlist): Use braces for struct initializers.
715
716 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
717 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
718 All callers changed.
719 (string_buffer_position): Likewise. Also, make static (it's never
720 used outside xdisp.c).
721 (cursor_row_p): Remove parameter `w', unused since
722 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
723 (decode_mode_spec): Remove parameter `precision', introduced during
724 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
725 All callers changed.
726
5ffb62aa
JD
7272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
728
729 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
730
461c2ab9 7312011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
732
733 * nsterm.m (ns_menu_bar_is_hidden): New variable.
734 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
735 (ns_update_auto_hide_menu_bar): New functions.
736 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
737 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
738 ns_constrain_all_frames.
739 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
740 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
741
5c380ffb
JD
7422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
743
744 * nsmenu.m (runDialogAt): Remove argument to timer_check.
745
9af30bdf
GM
7462011-03-27 Glenn Morris <rgm@gnu.org>
747
748 * syssignal.h: Replace RETSIGTYPE with void.
749 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
750 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
751 Replace SIGTYPE with void everywhere.
752 * s/usg5-4-common.h (SIGTYPE): Remove definition.
753 * s/template.h (SIGTYPE): Remove commented out definition.
754
e2abce01
JB
7552011-03-26 Eli Zaretskii <eliz@gnu.org>
756
757 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
758 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
759
f868cd8a
JB
7602011-03-26 Juanma Barranquero <lekktu@gmail.com>
761
59eb0929
JB
762 * w32.c (read_unc_volume): Use parameter `henum', instead of
763 global variable `wget_enum_handle'.
764
765 * keymap.c (describe_vector): Remove parameters `indices' and
766 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
767 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
768
f868cd8a
JB
769 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
770
771 * keyboard.c (timer_check): Remove parameter `do_it_now',
772 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
773 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
774 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
775
776 * keyboard.c (read_char):
777 * w32menu.c (w32_menu_display_help):
778 * xmenu.c (show_help_event, menu_help_callback):
779 Adjust calls to `show_help_echo'.
780
781 * gtkutil.c (xg_maybe_add_timer):
782 * keyboard.c (readable_events):
783 * process.c (wait_reading_process_output):
784 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
785
786 * insdel.c (adjust_markers_gap_motion):
787 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
788 (gap_left, gap_right): Don't call it.
789
2ecf6fdb
CY
7902011-03-25 Chong Yidong <cyd@stupidchicken.com>
791
792 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
793 incurred during fontification.
794
6b1f9ba4
JB
7952011-03-25 Juanma Barranquero <lekktu@gmail.com>
796
797 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
798 (DEFVAR_PER_BUFFER): Don't pass it.
799
800 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
801 (scrolling_window): Don't pass it.
802
0f4a96b5
JB
8032011-03-25 Juanma Barranquero <lekktu@gmail.com>
804
805 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
806
807 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
808 and `suffix'.
809 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
810 of variables specific to SELinux and computation of `encoded_absname'.
811
812 * image.c (XPutPixel): Remove unused variable `height'.
813
814 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
815
816 * unexw32.c (get_section_info): Remove unused variable `section'.
817
818 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
819 (system_process_attributes): Remove unused variable `sess'.
820 (sys_read): Remove unused variable `err'.
821
822 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
823 (w32_wnd_proc): Remove unused variable `isdead'.
824 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
825 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
826 (x_create_tip_frame): Remove unused variable `tem'.
827
828 * w32inevt.c (w32_console_read_socket):
829 Remove unused variable `no_events'.
830
831 * w32term.c (x_draw_composite_glyph_string_foreground):
832 Remove unused variable `width'.
833
1149507c
JB
8342011-03-24 Juanma Barranquero <lekktu@gmail.com>
835
836 * w32term.c (x_set_glyph_string_clipping):
837 Don't pass uninitialized region to CombineRgn.
838
9c88f339
JB
8392011-03-23 Juanma Barranquero <lekktu@gmail.com>
840
841 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
842 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
843 (Fx_close_connection): Remove unused variable `i'.
844
845 * w32font.c (w32font_draw): Return number of glyphs.
846 (w32font_open_internal): Remove unused variable `i'.
847 (w32font_driver): Add missing initializer.
848
849 * w32menu.c (utf8to16): Remove unused variable `utf16'.
850 (fill_in_menu): Remove unused variable `items_added'.
851
852 * w32term.c (last_mouse_press_frame): Remove static global variable.
853 (w32_clip_to_row): Remove unused variable `f'.
854 (x_delete_terminal): Remove unused variable `i'.
855
856 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
857 (NOTHING): Remove unused static global variable.
858 (uniscribe_check_otf): Remove unused variable `table'.
859 (uniscribe_font_driver): Add missing initializers.
860
dee091a3
JD
8612011-03-23 Julien Danjou <julien@danjou.info>
862
863 * term.c (Fsuspend_tty, Fresume_tty):
864 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
865 * window.c (temp_output_buffer_show):
866 * insdel.c (signal_before_change):
867 * frame.c (Fhandle_switch_frame):
868 * fileio.c (Fdo_auto_save):
869 * emacs.c (Fkill_emacs):
870 * editfns.c (save_excursion_restore):
871 * cmds.c (internal_self_insert):
872 * callint.c (Fcall_interactively):
873 * buffer.c (Fkill_all_local_variables):
874 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
875 Use Frun_hooks.
0f4a96b5 876 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
877 unconditionnaly since it does the check itself.
878
2c520ab5 8792011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 880
c9c49752
PE
881 Fix more problems found by GCC 4.5.2's static checks.
882
8abc3f12
PE
883 * coding.c (encode_coding_raw_text): Avoid unnecessary test
884 the first time through the loop, since we know p0 < p1 then.
885 This also avoids a gcc -Wstrict-overflow warning.
886
a2d26660
PE
887 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
888 leading to a memory leak, possible in functions like
889 load_charset_map_from_file that can allocate an unbounded number
b12ef411 890 of objects (Bug#8318).
a2d26660 891
916c72e9
PE
892 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
893 that could (at least in theory) be that large.
894
19ab8a18
PE
895 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
896 This is less likely to overflow, and avoids undefined behavior if
897 overflow does occur. All callers changed. Use strtoul to scan
898 for the unsigned long integer.
b7cbbd6f
PE
899 (pint2hrstr): Simplify and tune code slightly.
900 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 901
f0641eff
PE
902 * scroll.c (do_scrolling): Work around GCC bug 48228.
903 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
904
7f650bb9
PE
905 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
906 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
907 (validate_x_resource_name): Simplify count usage.
908 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 909
37dd57d1
PE
910 * fileio.c (Fcopy_file): Report error if fchown or fchmod
911 fail (Bug#8306).
81e56e61 912
699979fc 913 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 914
401bf9b4
PE
915 * process.c (Fmake_network_process): Use socklen_t, not int,
916 where POSIX says socklen_t is required in portable programs.
917 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 918 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
919 (Fmake_network_process, server_accept_connection):
920 (wait_reading_process_output, read_process_output):
921 Likewise.
922
b93aacde
PE
923 * process.c: Rename or move locals to avoid shadowing.
924 (list_processes_1, Fmake_network_process):
925 (read_process_output_error_handler, exec_sentinel_error_handler):
926 Rename or move locals.
4dc343ee 927 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 928 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 929 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 930 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 931 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 932
af8a867c 933 Make tparam.h and terminfo.c consistent.
44f230aa
SM
934 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
935 Include tparam.h instead, since it declares them.
af8a867c
PE
936 * cm.h (PC): Remove extern decl; tparam.h now does this.
937 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
938 * terminfo.c: Include tparam.h, to check interfaces.
939 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
940 (tparam): Adjust signature to match interface in tparam.h;
941 this removes some undefined behavior. Check that outstring and len
942 are zero, which they always are with Emacs.
943 * tparam.h (PC, BC, UP): New extern decls.
944
0248044d 945 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 946 (xftfont_open): Rename locals to avoid shadowing.
0248044d 947
8ff096c1 948 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
949 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
950 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 951 (ftfont_list): Remove unused local.
49eaafba
PE
952 (get_adstyle_property, ftfont_pattern_entity):
953 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
954 Rename locals to avoid shadowing.
8ff096c1 955
e2be39f6
PE
956 * xfont.c (xfont_list_family): Mark var as initialized.
957
c9735e30
PE
958 * xml.c (make_dom): Now static.
959
8f5201ae
PE
960 * composite.c (composition_compute_stop_pos): Rename local to
961 avoid shadowing.
b246f932
PE
962 (composition_reseat_it): Remove unused locals.
963 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 964 (composition_update_it): Mark var as initialized.
11b61122
PE
965 (find_automatic_composition): Mark vars as initialized,
966 with a FIXME (Bug#8290).
8f5201ae 967
760fbc2c
PE
968 character.h: Rename locals to avoid shadowing.
969 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
970 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
971 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
972 (BUF_DEC_POS): Be more systematic about renaming local temporaries
973 to avoid shadowing.
974
ff08eb85
PE
975 * textprop.c (property_change_between_p): Remove; unused.
976
fc7bf025
PE
977 * intervals.c (interval_start_pos): Now static.
978
235d7abc
PE
979 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
980
44f230aa
SM
981 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
982 Rename locals to avoid shadowing.
3e7d6594 983
50060332
PE
984 * sound.c (wav_play, au_play, Fplay_sound_internal):
985 Fix pointer signedness.
d01f234b 986 (alsa_choose_format): Remove unused local var.
c83b8872
PE
987 (wav_play): Initialize a variable to 0, to prevent undefined
988 behavior (Bug#8278).
50060332 989
c4fc4e30
PE
990 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
991
918436ed
PE
992 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
993
c939f91b
PE
994 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
995 clobbering (Bug#8298).
b9c7f648
PE
996 * sysdep.c (sys_subshell): Likewise.
997 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 998
6bd8c144
PE
999 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1000 This should get cleaned up, so that child_setup has the
1001 same signature on all platforms.
1002
7710357c 1003 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1004 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1005
c59da222
CY
10062011-03-22 Chong Yidong <cyd@stupidchicken.com>
1007
1008 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1009 not to be necessary, and produces flickering.
1010
66b87493
GM
10112011-03-20 Glenn Morris <rgm@gnu.org>
1012
1013 * config.in: Remove file.
1014
45b6f6d5
JB
10152011-03-20 Juanma Barranquero <lekktu@gmail.com>
1016
1017 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1018 are now in src/globals.h.
1019 (syms_of_minibuf): Remove spurious & from previous change.
1020
3ec03f7e
LL
10212011-03-20 Leo <sdl.web@gmail.com>
1022
1023 * minibuf.c (completing-read-function): New variable.
1024 (completing-read-default): Rename from completing-read.
1025 (completing-read): Call completing-read-function.
1026
b14e3e21
CY
10272011-03-19 Juanma Barranquero <lekktu@gmail.com>
1028
1029 * xfaces.c (Fx_load_color_file):
1030 Read color file from absolute filename (bug#8250).
1031
f2b726e6
JB
10322011-03-19 Juanma Barranquero <lekktu@gmail.com>
1033
1034 * makefile.w32-in: Update dependencies.
1035
09f6ff02
EZ
10362011-03-17 Eli Zaretskii <eliz@gnu.org>
1037
1038 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1039
29a6015a
PE
10402011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1041
a3a6c54e
PE
1042 Fix more problems found by GCC 4.5.2's static checks.
1043
b766f867
PE
1044 * process.c (make_serial_process_unwind, send_process_trap):
1045 (sigchld_handler): Now static.
1046
be02381c
PE
1047 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1048 That way, the code declares only the vars that it needs.
1049 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1050 * s/cygwin.h (PTY_ITERATION): Likewise.
1051 * s/darwin.h (PTY_ITERATION): Likewise.
1052 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1053
57048744
PE
1054 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1055 * process.c (allocate_pty): Don't declare stb unless it's needed.
1056
7914961c 1057 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1058 (CONSTANTLIM): Remove; unused.
1059 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1060 Define only if needed.
7914961c 1061
b3967b18
PE
1062 * unexelf.c (unexec): Name an expression,
1063 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1064 Use a different way to cause a compilation error if anyone uses
1065 n rather than nn, a way that does not involve shadowing.
73366a00 1066 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1067
29a6015a
PE
1068 * deps.mk (unexalpha.o): Remove; unused.
1069
43cfc33e 1070 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1071 * unexec.h: New file.
ce701a33
PE
1072 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1073 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1074 Depend on unexec.h.
1075 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1076 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1077 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1078 Change as necessary to match prototype in unexec.h.
ce701a33 1079
01f44d5a
PE
1080 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1081 shadowing.
4f63c6bb 1082 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1083
a6670b0b
PE
1084 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1085 Rename locals to avoid shadowing.
1086
cef2010d 1087 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1088 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1089
d4d7173a
PE
1090 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1091
f08b802a
PE
1092 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1093 warning when compiling print.c.
1094
3ddb0639
PE
1095 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1096 instead of using an uninitialized var.
5ad03b97 1097 (font_sort_entities): Mark var as initialized.
3ddb0639 1098
170a2692
PE
1099 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1100
e663c700
PE
1101 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1102 pointers to constants.
89bc529a 1103 (font_parse_fcname): Remove unused vars.
7b81e2d0 1104 (font_delete_unmatched): Now static.
ea838e10 1105 (font_get_spec): Remove; unused.
13a547c6
PE
1106 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1107 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1108 Rename or move locals to avoid shadowing.
e663c700 1109
2a80c887 1110 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1111 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1112
1384fa33 1113 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1114 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1115
8b2c52e9
PE
1116 * alloc.c (mark_backtrace): Move decl from here ...
1117 * lisp.h: ... to here, so that it can be checked.
1118
475545b5 1119 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1120 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1121 (lisp_indirect_variable): Name an expression,
1122 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1123 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1124
b1349114 1125 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1126 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1127 Use const pointer when appropriate.
b1349114 1128
a2928364
PE
1129 * lisp.h (get_system_name, get_operating_system_release):
1130 Move decls here, to check interfaces.
1131 * process.c (get_operating_system_release): Move decl to lisp.h.
1132 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1133 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1134 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1135 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1136 (Fformat_time_string, Fencode_time, Finsert_char):
1137 (Ftranslate_region_internal, Fformat):
1138 Rename or remove local vars to avoid shadowing.
9710023e 1139 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1140
a415e694
PE
1141 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1142 avoid shadowing.
1143
8ef4622d
PE
1144 * lisp.h (eassert): Check that the argument compiles, even if
1145 ENABLE_CHECKING is not defined.
1146
946f9a5b
PE
1147 * data.c (Findirect_variable): Name an expression, to avoid
1148 gcc -Wbad-function-cast warning.
112396d6 1149 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1150 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1151 (Fmake_variable_buffer_local, Fmake_local_variable):
1152 Mark variables as initialized.
52746918 1153 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1154
e5aab7e7 1155 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1156 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1157 Rename locals to avoid shadowing.
dff45157
PE
1158 (mark_stack): Move local variables into the #ifdef region where
1159 they're used.
7bc26fdb
PE
1160 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1161 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1162 needed otherwise.
1163 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1164 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1165 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1166
e5aab7e7
PE
1167 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1168 avoids undefined behavior in theory.
1169
4da60324
PE
1170 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1171
88043301
PE
1172 Use functions, not macros, for up- and down-casing (Bug#8254).
1173 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1174 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1175 to use the following functions instead of these macros.
1176 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1177 EMACS_INT, since callers assume the returned value fits in int.
1178 (upcase1): Likewise, for UPCASE_TABLE.
1179 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1180 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1181 the race-condition problem in the old DOWNCASE.
88043301 1182
19ed5445
PE
1183 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1184 Rename locals to avoid shadowing.
1185 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1186 (regex_compile, re_search_2, re_match_2_internal):
1187 Remove unused local vars.
952db0d7
PE
1188 (FREE_VAR): Rewrite so as not to use empty "else",
1189 which gcc can warn about.
da053e48 1190 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1191 (RETALLOC_IF): Define only if needed.
1192 (WORDCHAR_P): Likewise. This one is never needed, but is used
1193 only in a comment talking about a compiler bug, so put inside
1194 the #if 0 of that comment.
1195 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1196 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1197 Remove; unused.
19ed5445 1198
1f3561e4 1199 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1200 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1201 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1202
ded6f8f7
PE
1203 * search.c (simple_search): Remove unused var.
1204
dbd37a95
PE
1205 * dired.c (compile_pattern): Move decl from here ...
1206 * lisp.h: ... to here, so that it can be checked.
1207 (struct re_registers): New forward decl.
1208
7e47afad
PE
1209 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1210
85f24f61
PE
1211 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1212 All uses changed.
1213 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1214 Rename locals to avoid shadowing.
5671df8f 1215 (Fvertical_motion): Mark locals as initialized.
85f24f61 1216
181aa2be 1217 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1218 (casify_region): Mark local as initialized.
181aa2be 1219
930d429c
PE
1220 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1221
7082eac6
PE
1222 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1223 New macros, so that the caller can use some names other than
1224 gcpro1, gcpro2, etc.
1225 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1226 of the new macros.
1227 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1228 argument, for consistency with GCPRO2_VAR, etc: it is now the
1229 prefix of the variable, not the variable itself. All uses
1230 changed.
38b2c076
PE
1231 * dired.c (directory_files_internal, file_name_completion):
1232 Rename locals to avoid shadowing.
1233
15206ed9
PE
1234 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1235 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1236 dired.c's scmp function, had undefined behavior.
1237 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1238 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1239 * buffer.h: ... to here, because these macros use current_buffer,
1240 and the new implementation with inline functions needs to have
1241 current_buffer in scope now, rather than later when the macros
1242 are used.
1243 (downcase, upcase1): New static inline functions.
1244 (DOWNCASE, UPCASE1): Reimplement using these functions.
1245 This avoids undefined behavior in expressions like
1246 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1247 from race conditions in accessing the global variables
1248 case_temp1 and case_temp2.
1249 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1250 * lisp.h (case_temp1, case_temp2): Remove their decls.
1251 * character.h (ASCII_CHAR_P): Move from here ...
1252 * lisp.h: ... to here, so that the inline functions mentioned
1253 above can use them.
1254
4a6bea26
PE
1255 * dired.c (directory_files_internal_unwind): Now static.
1256
f14b7e14
PE
1257 * fileio.c (file_name_as_directory, directory_file_name):
1258 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1259 Now static.
2893f146
PE
1260 (file_name_as_directory): Use const pointers when appropriate.
1261 (Fexpand_file_name): Likewise. In particular, newdir might
1262 point at constant storage, so make it a const pointer.
fd4ead52 1263 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1264 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1265 signedness issues.
f839df0c
PE
1266 (Fset_file_times, Finsert_file_contents, auto_save_error):
1267 Rename locals to avoid shadowing.
f14b7e14 1268
5716756e 1269 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1270 (Ftry_completion, Fall_completions): Rename or remove locals
1271 to avoid shadowing.
5716756e 1272
b4c3046a
PE
1273 * marker.c (bytepos_to_charpos): Remove; unused.
1274
b45db522
PE
1275 * lisp.h (verify_bytepos, count_markers): New decls,
1276 so that gcc does not warn that these functions aren't declared.
1277
85876d07
PE
1278 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1279 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1280 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1281 (copy_text): Remove unused local var.
85876d07 1282
03d78a21 1283 * filelock.c (within_one_second): Now static.
b3dd38ab 1284 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1285
5df8f01b
PE
1286 * buffer.c (fix_overlays_before): Mark locals as initialized.
1287 (fix_start_end_in_overlays): Likewise. This function should be
1288 simplified by using pointers-to-pointers, but that's a different
1289 matter.
b1d876f1 1290 (switch_to_buffer_1): Now static.
8f54f30a
PE
1291 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1292 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1293
a70072c9 1294 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1295 Fix pointer signedness issue.
edced198
PE
1296 (sys_subshell): Mark local as volatile if checking for lint,
1297 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1298 (MAXPATHLEN): Define only if needed.
a70072c9 1299
a0977c44
PE
1300 * process.c (serial_open, serial_configure): Move decls from here ...
1301 * systty.h: ... to here, so that they can be checked.
1302
a884fdcc
PE
1303 * fns.c (get_random, seed_random): Move extern decls from here ...
1304 * lisp.h: ... to here, so that they can be checked.
1305
604efe86 1306 * sysdep.c (reset_io): Now static.
b8950c94 1307 (wait_for_termination_signal): Remove; unused.
604efe86 1308
38fc62d9
PE
1309 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1310 (copy_keymap_item, append_key, push_text_char_description):
1311 Now static.
1004a21a 1312 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1313 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1314 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1315 (describe_map_tree):
1316 Rename locals to avoid shadowing.
38fc62d9 1317
2f2650da
PE
1318 * keyboard.c: Declare functions static if they are not used elsewhere.
1319 (echo_char, echo_dash, cmd_error, top_level_2):
1320 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1321 (read_char, kbd_buffer_get_event, make_lispy_position):
1322 (make_lispy_event, make_lispy_movement, apply_modifiers):
1323 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1324 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1325 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1326 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1327 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1328
a053e86c 1329 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1330 (mark_kboards): Move decl here ...
1331 * alloc.c (mark_kboards): ... from here.
a053e86c 1332
4752793e
PE
1333 * lisp.h (force_auto_save_soon): New decl.
1334
74f10ca7 1335 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1336 (DEFINE_DUMMY_FUNCTION): New macro.
1337 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1338 Use it.
c03cd23f
PE
1339 (main): Add casts to avoid warnings
1340 if GCC considers string literals to be constants.
74f10ca7 1341
022e70d4
PE
1342 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1343
59d6fe83
PE
1344 * dbusbind.c: Pointer signedness fixes.
1345 (xd_signature, xd_append_arg, xd_initialize):
1346 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1347 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1348 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1349 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1350
78320123
PE
1351 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1352 if GCC considers string literals to be constants.
49cebcca 1353 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1354
35ac2a97
SM
13552011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1356
fb103ca9
SM
1357 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1358 (print_preprocess, print_object): New macro to fix last change.
1359
35ac2a97
SM
1360 * print.c (print_preprocess): Don't forget font objects.
1361
62973b41
JB
13622011-03-16 Juanma Barranquero <lekktu@gmail.com>
1363
1364 * emacs.c (USAGE3): Doc fixes.
1365
0e48bb22
AS
13662011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1367
1368 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1369 structure.
1370
7684e57b
JB
13712011-03-14 Juanma Barranquero <lekktu@gmail.com>
1372
1373 * lisp.h (VWindow_system, Qfile_name_history):
1374 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1375 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1376 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1377
1378 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1379 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1380
1381 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1382 * w32console.c (detect_input_pending, read_input_pending)
1383 (encode_terminal_code):
1384 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1385 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1386 (w32_system_caret_y, Qfile_name_history):
1387 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1388 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1389 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1390 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1391 * w32proc.c (Qlocal, report_file_error):
1392 * w32term.c (Vwindow_system, updating_frame):
1393 * w32uniscribe.c (initialized, uniscribe_font_driver):
1394 Remove unneeded extern declarations.
1395
2aa46d6c
CY
13962011-03-14 Chong Yidong <cyd@stupidchicken.com>
1397
c96bbc66 1398 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1399
cffc6f3b
CY
14002011-03-13 Chong Yidong <cyd@stupidchicken.com>
1401
1402 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1403 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1404 These macros can no longer be used for assignment.
1405
44f230aa
SM
1406 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1407 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1408 (record_buffer_markers, fetch_buffer_markers): New functions for
1409 recording and fetching special buffer markers.
1410 (set_buffer_internal_1, set_buffer_temp): Use them.
1411
1412 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1413
1414 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1415
1416 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1417 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1418
1419 * xdisp.c (hscroll_window_tree):
1420 (reconsider_clip_changes): Use PT instead of BUF_PT.
1421
d251f04b
EZ
14222011-03-13 Eli Zaretskii <eliz@gnu.org>
1423
1424 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1425 $(EMACS_ROOT)/lib/intprops.h.
1426
f0c77cd1
PE
14272011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1428
3eca4629
PE
1429 Fix more problems found by GCC 4.5.2's static checks.
1430
7c86ee98
PE
1431 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1432 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1433 (xg_free_frame_widgets): Make it clear that a local variable is
1434 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1435 (gdk_window_get_screen): Make it clear that this macro is needed
1436 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1437 (int_gtk_range_get_value): New function, which avoids a diagnostic
1438 from gcc -Wbad-function-cast.
1439 (xg_set_toolkit_scroll_bar_thumb): Use it.
1440 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1441 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1442 (get_utf8_string, xg_get_file_with_chooser):
1443 Rename locals to avoid shadowing.
1444 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1445
41729b81
PE
1446 * xgselect.c (xg_select): Remove unused var.
1447
f0c77cd1
PE
1448 * image.c (four_corners_best): Mark locals as initialized.
1449 (gif_load): Initialize transparent_p to zero (Bug#8238).
1450 Mark another local as initialized.
ec6cf4c6 1451 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1452
ce0ad53d 1453 * image.c (clear_image_cache): Now static.
d5d5a617 1454 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1455 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1456 (x_edge_detection): Remove unnecessary cast that
1457 gcc -Wbad-function-cast diagnoses.
2037898d 1458 (gif_load): Fix pointer signedness.
6ae141d6
PE
1459 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1460 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1461
33383987 14622011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1463
d32df629
PE
1464 Improve quality of tests for time stamp overflow.
1465 For example, without this patch (encode-time 0 0 0 1 1
1466 1152921504606846976) returns the obviously-bogus value (-948597
1467 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1468 reports time overflow. See
1469 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1470 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1471 * editfns.c: Include limits.h and intprops.h.
1472 (TIME_T_MIN, TIME_T_MAX): New macros.
1473 (time_overflow): Move earlier, to before first use.
1474 (hi_time, lo_time): New functions, for an accurate test for
1475 out-of-range times.
1476 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1477 (Fget_internal_run_time): Don't assume time_t fits in int.
1478 (make_time): Use list2 instead of Fcons twice.
1479 (Fdecode_time): More accurate test for out-of-range times.
1480 (check_tm_member): New function.
1481 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1482 (lisp_time_argument): Don't rely on undefined left-shift and
1483 right-shift behavior when checking for time stamp overflow.
8be6f318 1484
fe31d94c
PE
1485 * editfns.c (time_overflow): New function, refactoring common code.
1486 (Fformat_time_string, Fdecode_time, Fencode_time):
1487 (Fcurrent_time_string): Use it.
1488
8be6f318
PE
1489 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1490 * dired.c (make_time): Move to ...
1491 * editfns.c (make_time): ... here.
1492 * systime.h: Note the move.
1493
09d9db2c 14942011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1495
126bc0dc
YM
1496 * fringe.c (update_window_fringes): Remove unused variables.
1497
c47cbdfd
YM
1498 * unexmacosx.c (copy_data_segment): Also copy __got section.
1499 (Bug#8223)
1500
7ac80be9
EZ
15012011-03-12 Eli Zaretskii <eliz@gnu.org>
1502
c96bbc66 1503 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1504 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1505 Constify `char *' arguments and their references according to
1506 prototypes in tparam.h.
1507
ecb0f94d 1508 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1509
7ac80be9
EZ
1510 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1511 Adapt all references accordingly.
1512
1513 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1514
ef1fd07e
TT
15152011-03-11 Tom Tromey <tromey@redhat.com>
1516
1517 * buffer.c (syms_of_buffer): Remove obsolete comment.
1518
7ef4b50c
EZ
15192011-03-11 Eli Zaretskii <eliz@gnu.org>
1520
1521 * termhooks.h (encode_terminal_code): Declare prototype.
1522
1523 * msdos.c (encode_terminal_code): Don't declare prototype.
1524
1525 * term.c (encode_terminal_code): Now external again, used by
1526 w32console.c and msdos.c.
1527
44f230aa
SM
1528 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1529 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1530
4b1ec863 15312011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1532
1714f52b 1533 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1534
4b1ec863
PE
1535 * fringe.c (update_window_fringes): Mark locals as initialized
1536 (Bug#8227).
1537 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1538
524c7aa6
PE
1539 * alloc.c (mark_fringe_data): Move decl from here ...
1540 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1541 to check its interface.
1542 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1543
a5c0af81 1544 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1545 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1546 (fontset_font): Mark local as initialized.
a9a06e0b 1547 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1548
b4716021
PE
1549 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1550
811e9bac 1551 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1552 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1553 (x_own_selection, Fx_disown_selection_internal): Rename locals
1554 to avoid shadowing.
1555 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1556
7e3ab302
PE
1557 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1558 so that the caller can use some name other than gcpro1.
1559 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1560 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1561 (Fx_backspace_delete_keys_p):
1562 Use them to avoid shadowing, and rename vars to avoid shadowing.
1563 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1564 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1565 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1566 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1567 Remove unused locals.
7e3ab302
PE
1568 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1569 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1570 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1571 macros.
f78faa98 1572
e2b13473
PE
1573 * xterm.h (x_mouse_leave): New decl.
1574
77f23912
PE
1575 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1576 Remove unused functions.
cdf4ba58
PE
1577 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1578 (x_calc_absolute_position): Now static.
7411c686 1579 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1580 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1581 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1582 unless they are used.
38d0b34a
PE
1583 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1584 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1585 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1586 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1587 (x_error_catcher, x_connection_closed, x_error_handler):
1588 (x_error_quitter, xembed_send_message, x_iconify_frame):
1589 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1590 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1591 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1592
44f230aa
SM
1593 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1594 Rename or move locals to avoid shadowing.
6b463e58 1595 (tty_defined_color, merge_face_heights): Now static.
5967d051 1596 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1597 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1598 does not deduce is never used uninitialized.
73719eba
PE
1599 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1600 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1601
426994c3 1602 * terminal.c (store_terminal_param): Now static.
5489860b 1603
032f1620 1604 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1605 (set_frame_menubar): Remove unused local.
d4323972 1606 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1607 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1608 since they might point to immutable storage.
281585b0
PE
1609 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1610 since it's unused otherwise.
032f1620 1611
367c19e5 1612 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1613 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1614 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1615 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1616 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1617 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1618 does not deduce are never used uninitialized.
70739cbe 1619
07b48fa9
PE
1620 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1621
8868a238 1622 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1623 * window.c (window_loop, size_window):
1624 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1625
7e5cf297 1626 * window.c (display_buffer): Now static.
d6550a9f
PE
1627 (size_window): Mark variables that gcc -Wuninitialized
1628 does not deduce are never used uninitialized.
a586633d
PE
1629 * window.h (check_all_windows): New decl, to forestall
1630 gcc -Wmissing-prototypes diagnostic.
5b555da1 1631 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1632
f6095868
PE
1633 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1634 shadowing.
1635 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1636 Include <limits.h>.
1637 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1638 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1639 (load_charset_map): Mark variables that gcc -Wuninitialized
1640 does not deduce are never used uninitialized.
53df7c11 1641 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1642
f38b440c
PE
1643 * coding.c (coding_set_source, coding_set_destination):
1644 Use "else { /* comment */ }" rather than "else /* comment */;"
1645 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1646 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1647 a block, when the outer 'i' will do.
1648 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1649 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1650 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1651 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1652 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1653 Rename locals to avoid shadowing.
1654 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1655 * coding.c (emacs_mule_char, encode_invocation_designation):
1656 Now static, since they're not used elsewhere.
413bb2db 1657 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1658 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1659 (decode_coding_emacs_mule): Mark variables that gcc
1660 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1661 (detect_coding_iso_2022): Initialize a local variable that might
1662 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1663 this initialization is needed. (Bug#8211)
5f58e762
PE
1664 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1665 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1666 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1667 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1668 Remove unused macros.
f38b440c 1669
232b38b9 1670 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1671 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1672 * character.c (string_count_byte8): Likewise.
232b38b9 1673
fb90da1b
PE
1674 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1675 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1676
fb93dbc2
PE
1677 * chartab.c (copy_sub_char_table): Now static, since it's not used
1678 elsewhere.
5c156ace
PE
1679 (sub_char_table_ref_and_range, char_table_ref_and_range):
1680 Rename locals to avoid shadowing.
bbcd0949 1681 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1682
7d3b3862 1683 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1684 (BIDI_BOB): Remove unused macro.
7d3b3862 1685
6be7d3da
PE
1686 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1687 deduce are never used uninitialized.
c2ed9c8b 1688 * term.c (encode_terminal_code): Likewise.
6be7d3da 1689
75f8807f 1690 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1691
50938595
PE
1692 * tparam.h: New file.
1693 * term.c, tparam.h: Include it.
1694 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1695 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1696 Move these decls to tparam.h, and make them agree with what
1697 is actually in tparam.c. The previous trick of using incompatible
1698 decls in different modules does not conform to the C standard.
1699 All callers of tparam changed to use tparam's actual API.
1700 * tparam.c (tparam1, tparam, tgoto):
1701 Use const pointers where appropriate.
1702
fbceeba2
PE
1703 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1704 * cm.h (struct cm): Likewise.
1705 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1706 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1707 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1708 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1709 (turn_on_face, init_tty): Likewise.
1710 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1711
7f3f1250
PE
1712 * term.c (term_mouse_position): Rename local to avoid shadowing.
1713
e6ca6543
PE
1714 * alloc.c (mark_ttys): Move decl from here ...
1715 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1716
c40f8d15
AS
17172011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1718
1719 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1720
cfe0661d
JB
17212011-03-09 Juanma Barranquero <lekktu@gmail.com>
1722
1723 * search.c (compile_pattern_1): Remove argument regp, unused since
1724 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1725 (compile_pattern): Don't pass it.
1726
0afb4571
J
17272011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1728
1729 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1730 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1731 for ! HAVE_GTK3.
1732 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1733
1734 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1735
1736 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1737 gdk_window_get_screen, gdk_window_get_geometry,
1738 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1739 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1740 (xg_get_pixbuf_from_pixmap): New function.
1741 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1742 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1743 Call xg_get_pixbuf_from_pixmap instead of
1744 gdk_pixbuf_get_from_drawable.
1745 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1746 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1747 (xg_check_special_colors): Use GtkStyleContext and its functions
1748 for HAVE_GTK3.
1749 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1750 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1751 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1752 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1753 Call gtk_widget_get_preferred_size.
0afb4571
J
1754 (xg_frame_resized): gdk_window_get_geometry only takes 5
1755 parameters.
44f230aa
SM
1756 (xg_win_to_widget, xg_event_is_for_menubar):
1757 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1758 (xg_set_widget_bg): New function.
1759 (delete_cb): New function.
1760 (xg_create_frame_widgets): connect delete-event to delete_cb.
1761 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1762 (xg_set_background_color): Call xg_set_widget_bg.
1763 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1764 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1765 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1766 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1767 if ! HAVE_GTK3.
1768 (update_frame_tool_bar): Call gtk_widget_hide.
1769 (xg_initialize): Use GDK_KEY_g.
1770
1771 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1772 if ! HAVE_GTK3
1773 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1774
1775 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1776 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1777 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1778
1c2cc4ef
JB
17792011-03-08 Juanma Barranquero <lekktu@gmail.com>
1780
1781 * w32xfns.c (select_palette): Check success of RealizePalette against
1782 GDI_ERROR, not zero.
1783
33383987 1784See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1785
1786;; Local Variables:
1787;; coding: utf-8
aac0c6e3
MR
1788;; End:
1789
33383987 1790 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1791
1792 This file is part of GNU Emacs.
1793
1794 GNU Emacs is free software: you can redistribute it and/or modify
1795 it under the terms of the GNU General Public License as published by
1796 the Free Software Foundation, either version 3 of the License, or
1797 (at your option) any later version.
1798
1799 GNU Emacs is distributed in the hope that it will be useful,
1800 but WITHOUT ANY WARRANTY; without even the implied warranty of
1801 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1802 GNU General Public License for more details.
1803
1804 You should have received a copy of the GNU General Public License
1805 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.