Fix hang after C-z in gnome-shell.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b77a6a7f
JD
12011-10-30 Jan Djärv <jan.h.d@swipnet.se>
2
3 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4
5 * xterm.c: Declare x_handle_net_wm_state to return int.
6 (handle_one_xevent): Check if we are iconified but don't have
7 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8 (get_current_wm_state): Return non-zero if not hidden,
9 check for _NET_WM_STATE_HIDDEN (Bug#9893).
10 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
11 (x_handle_net_wm_state): Return what get_current_wm_state returns.
12 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
13
196e41e4
PE
142011-10-29 Paul Eggert <eggert@cs.ucla.edu>
15
16 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
17 so that this new function doesn't get optimized away by a
18 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
19
021f2e1a
AS
202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
21
22 * frame.h (MOUSE_HL_INFO): Remove excess parens.
23
8b058d44
EZ
242011-10-29 Eli Zaretskii <eliz@gnu.org>
25
26 Fix the `xbytecode' command.
27 * .gdbinit (xprintbytestr): New command.
28 (xwhichsymbols): Renamed from `which'; all callers changed.
29 (xbytecode): Print the byte-code string as well.
30
4452fb80
EZ
312011-10-29 Kim Storm <storm@cua.dk>
32
8b058d44
EZ
33 * alloc.c (which_symbols): New function.
34
21b72067
AS
352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
36
37 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
38 line. (Bug#9903)
39
83ed7b5c
GM
402011-10-29 Glenn Morris <rgm@gnu.org>
41
42 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
43 Not clear what it was for, and it causes various bugs. (Bug#9839)
44
5a7a728b
EZ
452011-10-28 Eli Zaretskii <eliz@gnu.org>
46
47 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
48 possible random value that matches one of those tested as
49 condition to clear the mouse face.
50
d3d0842f
CY
512011-10-28 Chong Yidong <cyd@gnu.org>
52
53 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
54
31b39d13
DN
552011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
56
57 * window.c (make_window): Initialize phys_cursor_on_p.
58
9aba6043
SM
592011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
60
61 * lisp.h (struct Lisp_Symbol): Update comments.
62
c20992f4
JB
632011-10-28 Juanma Barranquero <lekktu@gmail.com>
64
65 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
66
db4f02f2
EZ
672011-10-28 Eli Zaretskii <eliz@gnu.org>
68
69 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
70 <oslsachem@gmail.com> for helping to debug this.
71
72 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
73 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
74 (g_b_init_get_glyph_outline_w): New static variables.
75 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
76 (GetGlyphOutlineW_Proc): New typedefs.
77 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
78 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
79 New functions.
80 (w32font_open_internal, compute_metrics):
81 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
82 instead of calling the "wide" APIs directly.
83
84 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
85
86 * w32.h (syms_of_w32font): Add prototype.
87
87e68db4
JB
882011-10-27 Juanma Barranquero <lekktu@gmail.com>
89
90 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
91 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
92 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
93 (Fmove_to_window_line): Doc fix.
94
435c1d67
CY
952011-10-27 Chong Yidong <cyd@gnu.org>
96
97 * process.c (make_process): Set gnutls_state to NULL.
98
99 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
100 non-NULL, regardless of GNUTLS_INITSTAGE.
101 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
102 an error. Set process slots as soon as we allocate them.
103
104 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
105
9c6c6f49
CY
1062011-10-27 Chong Yidong <cyd@gnu.org>
107
9aba6043
SM
108 * gnutls.c (emacs_gnutls_deinit): New function.
109 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
110 (Fgnutls_deinit, Fgnutls_boot): Use it.
111
112 * process.c (make_process): Initialize GnuTLS credentials to NULL.
113 (deactivate_process): Call emacs_gnutls_deinit.
114
657d08d3
JB
1152011-10-27 Juanma Barranquero <lekktu@gmail.com>
116
117 * image.c (x_create_x_image_and_pixmap):
118 * w32.c (sys_rename, w32_delayed_load):
119 * w32font.c (fill_in_logfont):
120 * w32reg.c (x_get_string_resource): Silence compiler warnings.
121
5430d399
JB
1222011-10-26 Juanma Barranquero <lekktu@gmail.com>
123
124 * w32fns.c (w32_default_color_map): New function,
125 extracted from Fw32_default_color_map.
a7ef684b 126 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 127
fe0055fa
PE
1282011-10-25 Paul Eggert <eggert@cs.ucla.edu>
129
130 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
131
e6346438
SM
1322011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
133
134 * keyboard.c (test_undefined): New function (bug#9751).
135 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
136
e112cc37
ET
1372011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
138
139 * sysdep.c (init_sys_modes): Fix the check for the controlling
140 terminal (Bug#6649).
141
7b5d6677
EZ
1422011-10-20 Eli Zaretskii <eliz@gnu.org>
143
144 * dispextern.h (struct bidi_it): New member next_en_type.
145
146 * bidi.c (bidi_line_init): Initialize the next_en_type member.
147 (bidi_resolve_explicit_1): When next_en_pos is valid for the
148 current character, check also for next_en_type being WEAK_EN.
149 (bidi_resolve_weak): Don't enter the expensive loop if the current
150 position is before next_en_pos. Record the bidi type of the first
151 non-ET, non-BN character we find, in addition to its position.
152 (bidi_level_of_next_char): Invalidate next_en_type when
153 next_en_pos is over-stepped.
154
7da0b018
PE
1552011-10-20 Paul Eggert <eggert@cs.ucla.edu>
156
157 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
158 * editfns.c: Rewrite current-time-zone so that it invokes
159 the equivalent of (format-time-string "%Z") to get the time zone name.
160 This fixes a bug when the time zone name contains characters that
161 need converting from the system time locale to Emacs internal format.
162 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
163 that patch fixed format-time-string to do the conversion, but
164 I forgot to fix current-time-zone.
165 (format_time_string): New function, containing most of
166 what Fformat_time_string used to contain.
167 (Fformat_time_string): Rewrite in terms of format_time_string.
168 This doesn't change this function's behavior.
169 (current-time-zone): Rewrite to use format_time_string.
170 This fixes the bug reported by Michael Schierl in
171 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
172 Jason Rumney's 2007-06-07 change worked around this bug, but
173 didn't fix it.
174 * systime.h (tzname, timezone): Remove no-longer-used declarations.
175
8547b010
EZ
1762011-10-19 Eli Zaretskii <eliz@gnu.org>
177
178 * xdisp.c (start_display): If the character at POS is displayed
179 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
180 (try_window_reusing_current_matrix): If a line ends in a display
181 vector or the next line starts in a display vector, continue
182 redrawing the window even though the character position of
183 start_row was reached.
8547b010
EZ
184 (Bug#9771, part 2)
185
4e948d15
CY
1862011-10-18 Chong Yidong <cyd@gnu.org>
187
188 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
189 with nobreak-char-display too.
190
4787455f
EZ
1912011-10-18 Eli Zaretskii <eliz@gnu.org>
192
193 Fix part 3 of bug#9771.
194 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
195 (bidi_resolve_neutral): Don't enter the expensive loop looking for
196 non-neutral characters if the current character is a paragraph
197 separator (a.k.a. Newline). This avoids running the same
198 expensive loop twice, once when we consume the preceding newline
199 and the other time when the line actually needs to be displayed.
200 Avoid the loop when we see neutrals on the base embedding level
201 following a character whose directionality is the same as the
202 paragraph's. This avoids running the expensive loop when a line
203 ends in a long sequence of neutrals, like control characters.
204 Add assertion against STRONG_AL type. Slightly rearrange code
205 that determines the type of a neutral given the first non-neutral
206 that follows it.
207 (bidi_level_of_next_char): Set next_en_pos to zero when
208 invalidating its info.
209
2c91f553
EZ
2102011-10-17 Eli Zaretskii <eliz@gnu.org>
211
212 * xdisp.c (push_display_prop): Determine whether to record string
213 or buffer position by IT->string, not by IT->method. Allow
214 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
215 (move_it_vertically_backward): Don't look for character position
216 immediately after the newline when in a continuation line.
217 (Bug#9771, part 1)
2c91f553 218
c7b08b0d
MR
2192011-10-15 Martin Rudalics <rudalics@gmx.at>
220
221 * window.c (coordinates_in_window): Rewrite and delabelize
222 vertical border check. (Bug#5357) (Bug#9618)
223
6b02f655
SM
2242011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
225
226 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
227 errors in XSetWindowBorder (bug#9310).
228
81d40c92
DA
2292011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
230
231 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
232 avoid crash when xmalloc overrun checking is enabled.
233
d4172c3b
EZ
2342011-10-13 Eli Zaretskii <eliz@gnu.org>
235
236 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
237 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
238 cursor motion with <left> and <right> arrow keys.
239
240 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
241 some callers set that themselves.
242
b00eea75
EZ
2432011-10-12 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
246 display string and the previous row comes from the same string and
247 is empty. (Bug#9739) (Bug#9738)
248
8fe012c4
SM
2492011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
250
251 * doc.c (get_doc_string): Encode file name (bug#9735).
252
0074aef2
EZ
2532011-10-12 Eli Zaretskii <eliz@gnu.org>
254
79beb178
EZ
255 * bidi.c (bidi_level_of_next_char):
256 * xdisp.c (get_visually_first_element): Remove old incorrect
257 comments regarding the Unicode Line Separator character.
258
0074aef2
EZ
259 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
260
6e4b3fbe
DA
2612011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
262
263 * alloc.c (Fgc_status): Do not access beyond zombies array
264 boundary if nzombies > MAX_ZOMBIES.
265 * alloc.c (dump_zombies): Add missing format specifier.
266
0324f3af
PE
2672011-10-12 Paul Eggert <eggert@cs.ucla.edu>
268
b5525cac
PE
269 * xdisp.c (set_cursor_from_row): Simplify conditionals,
270 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
271
0324f3af
PE
272 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
273 Some packages use them to denote characters with modifiers.
274
e9b5f888
AS
2752011-10-11 Andreas Schwab <schwab@linux-m68k.org>
276
277 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
278 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
279 matching a pp-number. Rename parameter var to var1.
280
127827c0
SM
2812011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
282
283 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
284
c8fd3bd0
GM
2852011-10-08 Glenn Morris <rgm@gnu.org>
286
287 * callint.c (Fcall_interactively): Give a more explicit error for the
288 'c' case with a non-character input. (Bug#8479)
289
352ec8ff
EZ
2902011-10-08 Eli Zaretskii <eliz@gnu.org>
291
03669ccb
EZ
292 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
293 lines.
7061c986
EZ
294 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
295 lines that are hscrolled on the left.
03669ccb 296
352ec8ff
EZ
297 * dispnew.c (buffer_posn_from_coords): Account for a possible
298 presence of header-line. (Bug#4426)
299
a66cfb1c
SM
3002011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
301
6b02f655
SM
302 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
303 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 304
7c5ee88e
PE
3052011-10-07 Paul Eggert <eggert@cs.ucla.edu>
306
307 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
308 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
309 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
310 this makes Emacs dump core during garbage collection on rare
311 occasions. sizeof is obviously inferior to offsetof here, so
312 stick with offsetof.
313 (GC_POINTER_ALIGNMENT): New macro.
314 (mark_memory): Omit 3rd (offset) arg; caller changed.
315 Don't assume EMACS_INT alignment is the same as pointer alignment.
316
df1bbe5b
SM
3172011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
318
319 * keyboard.c (read_key_sequence_remapped): New var.
320 (read_key_sequence): Compute remapping in the right buffer.
321 (command_loop_1): Use read_key_sequence's remapping directly.
322
51553db6
SM
3232011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
324
32c1fffd
SM
325 * dired.c (file_name_completion): Don't expand file name.
326 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
327 before checking file name handler.
328
51553db6
SM
329 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
330 they've been requested explicitly (bug#9591).
331
b6bd1599 3322011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
333
334 * keymap.c (Fsingle_key_description): Use make_specified_string
335 instead of build_string to build string from push_key_description.
336 (Bug#5193)
337
f701dc2a
PE
3382011-09-30 Paul Eggert <eggert@cs.ucla.edu>
339
4222c55d
PE
340 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
341 This fixes a Y2038 bug on 64-bit hosts.
342 * buffer.c (reset_buffer):
343 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
344 (Fclear_buffer_auto_save_failure):
345 Use 0, not -1, to represent an unset failure time, since time_t
346 might not be signed.
347
f701dc2a
PE
348 Remove dependency on glibc malloc internals.
349 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
350 Move back here from lisp.h, but with their new implementations.
351 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
352 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
353 * charset.c (charset_table_init): New static var.
354 (syms_of_charset): Use it instead of xmalloc. This removes a
355 dependency on glibc malloc internals. See Eli Zaretskii's comment in
356 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
357 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
358 Move back to alloc.c.
359 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
360 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
361
9ceebf39
JD
3622011-09-30 Jan Djärv <jan.h.d@swipnet.se>
363
364 * nsterm.m (windowDidResize): Call x_set_window_size only when
365 ns_in_resize is true. Otherwise set pixelwidth/height and
366 call change_frame_size (Bug#9628).
367
cb993c58
PE
3682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
369
3930c88b
PE
370 Port --enable-checking=all to Fedora 14 x86-64.
371 * charset.c (syms_of_charset): Also account for glibc malloc's
372 internal overhead when calculating the initial malloc maximum.
373
cb993c58
PE
374 Port --enable-checking=all to Fedora 14 x86.
375 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
376 Move to lisp.h.
377 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
378 (overrun_check_realloc, overrun_check_free):
379 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
380 That way, xmalloc returns a properly-aligned pointer even if
381 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
382 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
383 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
384 into account when calculating the initial malloc maximum.
385 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
386 Move here from alloc.c, so that charset.c can use it too.
387 Properly align; the old code wasn't right for common 32-bit hosts
388 when configured with --enable-checking=all.
389 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
390 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
391
31bed486
EZ
3922011-09-29 Eli Zaretskii <eliz@gnu.org>
393
04c70788 394 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
395 use EDOM.
396
fbcaa2f3
EZ
3972011-09-28 Eli Zaretskii <eliz@gnu.org>
398
399 * xdisp.c (compute_display_string_end): If there's no display
400 string at CHARPOS, return -1.
401
402 * bidi.c (bidi_fetch_char): When compute_display_string_end
403 returns a negative value, treat the character as a normal
404 character not covered by a display string. (Bug#9624)
405
a239d4e9
JB
4062011-09-28 Juanma Barranquero <lekktu@gmail.com>
407
408 * lread.c (Fread_from_string): Fix typo in docstring.
409
88652fd5
EZ
4102011-09-27 Eli Zaretskii <eliz@gnu.org>
411
412 * xdisp.c (handle_invisible_prop): If invisible text ends on a
413 newline, reseat the iterator instead of bidi-iterating there one
414 character at a time. (Bug#9610)
32c1fffd
SM
415 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
416 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 417
ed497dd4
AS
4182011-09-27 Andreas Schwab <schwab@linux-m68k.org>
419
420 * lread.c (readevalloop): Use correct code for NBSP.
421 (read1): Likewise. (Bug#9608)
422
b2bf61aa
MA
4232011-09-25 Michael Albinus <michael.albinus@gmx.de>
424
425 * dbusbind.c (Fdbus_register_signal): When service is not
426 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
427
32bbb17c
GM
4282011-09-25 Glenn Morris <rgm@gnu.org>
429
430 * buffer.c (truncate-lines): Doc fix.
431
94e0933e
CY
4322011-09-24 Chong Yidong <cyd@stupidchicken.com>
433
434 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
435 (Fset_window_next_buffers): Doc fix.
436
cddde921
GM
4372011-09-24 Glenn Morris <rgm@gnu.org>
438
439 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
440
1260aef1
PE
4412011-09-24 Paul Eggert <eggert@cs.ucla.edu>
442
25b4bfa0
PE
443 Fix minor problems found by static checking.
444 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
445 * indent.c (Fvertical_motion): Fix == vs = typo.
446
e3cbd34b
EZ
4472011-09-24 Eli Zaretskii <eliz@gnu.org>
448
a66cfb1c
SM
449 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
450 Default value is now t. Doc fix.
6bf7006f 451
e3cbd34b 452 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 453 logic when moving up, not only when moving down. Fix the
e3cbd34b 454 confusing name and values of the it_overshoot_expected variable;
32c1fffd 455 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
456
457 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
458 CHARPOS is covered by a display string which includes newlines.
459 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
460 is covered by a display string with embedded newlines.
461
a3de0cbd
MA
4622011-09-24 Michael Albinus <michael.albinus@gmx.de>
463
464 * dbusbind.c (Fdbus_register_signal): Add match rule to
465 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
466 (Fdbus_register_method, Vdbus_registered_objects_table):
467 Fix docstring.
a3de0cbd 468
b260039d
JM
4692011-09-24 Jim Meyering <meyering@redhat.com>
470
32c1fffd 471 do not ignore write error for any output size
b260039d
JM
472 The previous change was incomplete.
473 While it makes emacs --batch detect the vast majority of stdout
474 write failures, errors were still ignored whenever the output size is
475 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
476 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
477 && echo FAIL: ignored write error
478 FAIL: ignored write error
479 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
480 && echo FAIL: ignored write error
481 FAIL: ignored write error
482 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
483
8eca8a7c
AS
4842011-09-23 Andreas Schwab <schwab@linux-m68k.org>
485
486 * emacs.c (Fkill_emacs): In noninteractive mode exit
487 non-successfully if a write error occurred on stdout. (Bug#9574)
488
3341db62
EZ
4892011-09-21 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
492 the xassert test.
493
494 * dispextern.h (struct it): Update the comment documenting what
495 can it->OBJECT be.
496
8c203dbf
EZ
4972011-09-20 Eli Zaretskii <eliz@gnu.org>
498
499 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
500 a display string, extend search for cursor position to end of row.
501 (find_row_edges): If the row ends in a newline from a display
502 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
503 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
504 (Fcurrent_bidi_paragraph_direction): Fix search for previous
505 non-empty line. Fixes confusing cursor motion with arrow keys at
506 the beginning of a line that starts with whitespace.
8c203dbf 507
a4824228
LMI
5082011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
509
510 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
511 (bug#9493).
512
33ed493b
CY
5132011-09-18 Chong Yidong <cyd@stupidchicken.com>
514
515 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
516 boolean (Bug#9154).
517
56cd55c8
EZ
5182011-09-18 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (display_line): Record maximum and minimum buffer
521 positions even if no glyphs were produced (e.g., by a zero-width
522 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
523 buffer positions that will be removed from the glyph row because
524 they don't fit.
c02dcedf
EZ
525 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
526 column is beyond frame width: don't subtract 1 "pixel" when
527 computing width of the stretch.
3e62b7e0
EZ
528 (reseat_at_next_visible_line_start): Undo the change made on
529 2011-09-17 that saved paragraph information and restored it after
530 the call to `reseat'. (Bug#9545)
56cd55c8 531
5ed99d36 5322011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
533
534 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
535 and turn window cursor on if cleared (Bug#9415).
536
5ed99d36 5372011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
538
539 * search.c (boyer_moore): Take unibyte characters from pattern
540 literally. (Bug#9458)
541
9bade7b2
EZ
5422011-09-18 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
545
e5e9d610
PE
5462011-09-18 Paul Eggert <eggert@cs.ucla.edu>
547
87e4427a
PE
548 Fix minor problem found by static checking.
549 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
550 initialized, to pacify gcc -Wuninitialized.
551
e5e9d610
PE
552 * fileio.c: Report proper errno when syscall falls.
553 (Finsert_file_contents): Save and restore errno,
554 so that report_file_error outputs the correct diagnostic.
555 (Fwrite_region) [CLASH_DETECTION]: Likewise.
556
a1674f0b
EZ
5572011-09-18 Eli Zaretskii <eliz@gnu.org>
558
559 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
560
fbfb6dd4
EZ
5612011-09-17 Eli Zaretskii <eliz@gnu.org>
562
563 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
564 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
565
bb187662
EZ
5662011-09-17 Eli Zaretskii <eliz@gnu.org>
567
1137e8b8 568 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 569 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
570
571 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
572 (bidi_find_paragraph_start): Search back for paragraph beginning
573 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
574 (bidi_move_to_visually_next): Only trigger paragraph-related
575 computations when the last character is a newline or at EOB, not
576 just any NEUTRAL_B. (Bug#9470)
577
bb187662
EZ
578 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
579 truncated lines if point is covered by a display string. (Bug#9524)
580
2e621251
PE
5812011-09-16 Paul Eggert <eggert@cs.ucla.edu>
582
583 * xselect.c: Relax test for outgoing X longs (Bug#9498).
584 (cons_to_x_long): New function.
585 (lisp_data_to_selection_data): Use it. Correct the test for
586 short-versus-long data; it was negated. Break out of vector
587 loop, for efficiency, when a long datum is discovered.
588
91a15bc6
SM
5892011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
590
591 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
592
b41c3a35
EZ
5932011-09-16 Eli Zaretskii <eliz@gnu.org>
594
595 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
596 GCC PR/17406) by declaring this function with external scope.
597
7812ba2d
PE
5982011-09-15 Paul Eggert <eggert@cs.ucla.edu>
599
600 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
601 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
602
cf7edc2a
AS
6032011-09-15 Andreas Schwab <schwab@linux-m68k.org>
604
605 * editfns.c (Fformat): Correctly handle text properties on "%%".
606
bd01620e
EZ
6072011-09-15 Eli Zaretskii <eliz@gnu.org>
608
609 * xterm.c (x_draw_composite_glyph_string_foreground):
610 * w32term.c (x_draw_composite_glyph_string_foreground):
611 * term.c (encode_terminal_code):
612 * composite.c (composition_update_it, get_composition_id):
613 * xdisp.c (get_next_display_element)
614 (fill_composite_glyph_string): Add comments about special meaning
615 of TAB characters in a composition.
616
a02719a3
PE
6172011-09-15 Paul Eggert <eggert@cs.ucla.edu>
618
619 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
620 This occurs when processing a multibyte format.
621 Problem reported by Wolfgang Jenker.
a02719a3 622
72589a3c
JB
6232011-09-15 Johan Bockgård <bojohan@gnu.org>
624
625 * xdisp.c (try_cursor_movement): Only check for exact match if
626 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
627
1c14176c
PE
6282011-09-14 Paul Eggert <eggert@cs.ucla.edu>
629
630 Remove unused external symbols.
631 * dispextern.h (calc_pixel_width_or_height): Remove decl.
632 * xdisp.c (calc_pixel_width_or_height): Now static.
633 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
634 * indent.c (check_display_width):
635 * w32term.c: Fix comment to match code.
636 * xterm.c, xterm.h (x_catching_errors): Remove.
637
d2eea5b5
PE
6382011-09-14 Paul Eggert <eggert@cs.ucla.edu>
639
640 * xselect.c: Use signed conversions more consistently (Bug#9498).
641 (selection_data_to_lisp_data): Assume incoming selection data are
642 signed integers, not unsigned. This is to be consistent with
643 outgoing selection data, which was modified to use signed integers
644 in as part of the fix to Bug#9196 in response to Jan D.'s comment
645 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
646 expects long, not unsigned long.
647
46888499
EZ
6482011-09-14 Eli Zaretskii <eliz@gnu.org>
649
650 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
651 computation of loop end. Reported by Johan Bockgård
652 <bojohan@gnu.org>.
653
ef8ef9fb
CY
6542011-09-13 Chong Yidong <cyd@stupidchicken.com>
655
656 * frame.c (Fother_visible_frames_p): Function deleted.
657
fa819fed
EZ
6582011-09-12 Eli Zaretskii <eliz@gnu.org>
659
660 * indent.c (compute_motion): Process display vector front to back
661 rather than the other way around. (Bug#2496)
662
2ba8e008
SM
6632011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
664
665 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
666
20f53c69
CY
6672011-09-11 Chong Yidong <cyd@stupidchicken.com>
668
669 * minibuf.c (Fread_from_minibuffer): Doc fix.
670
d562d7a4
EZ
6712011-09-11 Eli Zaretskii <eliz@gnu.org>
672
673 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
674 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
675
1c4d7f3d
LMI
6762011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
677
678 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
679 value for non-existent files.
680
b885bf36
EZ
6812011-09-11 Eli Zaretskii <eliz@gnu.org>
682
683 * fileio.c (Finsert_file_contents): If the file cannot be opened,
684 set its "size" to -1. This will set the modtime_size field of
685 the corresponding buffer to -1, which is what
686 verify-visited-file-modtime expects for files that do not exist.
687 (Bug#9139)
688
6612f0bf
PE
6892011-09-11 Paul Eggert <eggert@cs.ucla.edu>
690
691 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
692 here ...
693 * lisp.h: ... from here. push_key_description is no longer
694 defined in keyboard.c, so its declaration should not be in
695 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
696 logically belongs with push_key_description.
697
dfb3f755
PE
6982011-09-10 Paul Eggert <eggert@cs.ucla.edu>
699
700 * buffer.h: Include <sys/types.h> instead of <time.h>.
701 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
702 Problem reported by Herbert J. Skuhra.
703
3134906c
LMI
7042011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
705
706 * xml.c (parse_region): Make the parsing work for
707 non-comment-starting XML files again (bug#9144).
708
8d903f4e
AS
7092011-09-10 Andreas Schwab <schwab@linux-m68k.org>
710
711 * image.c (gif_load): Fix calculation of bottom and right corner.
712 (Bug#9468)
713
80ad64f4
EZ
7142011-09-10 Eli Zaretskii <eliz@gnu.org>
715
716 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
717 redisplay in small windows.
718
208a048d
EZ
7192011-09-09 Eli Zaretskii <eliz@gnu.org>
720
721 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
722
9b1c252e
MR
7232011-09-08 Martin Rudalics <rudalics@gmx.at>
724
725 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
726 Operate on live windows only.
727
2949f33b
JB
7282011-09-08 Juanma Barranquero <lekktu@gmail.com>
729
730 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
731
e08dcafd
EZ
7322011-09-07 Eli Zaretskii <eliz@gnu.org>
733
734 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
735 only under bidi iteration.
736
115b96bd
JD
7372011-09-07 Jan Djärv <jan.h.d@swipnet.se>
738
739 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
740
c8199d0f
PE
7412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
742
743 isnan: Fix porting problem to Solaris 10 with bundled gcc.
744 Without this fix, the command to link temacs failed due to an
745 undefined symbol __builtin_isnan. This is because
746 /usr/include/iso/math_c99.h #defines isnan(x) to
747 __builtin_isnan(x), but the bundled gcc, which identifies itself
748 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
749 a __builtin_isnan.
750 * floatfns.c (isnan): #undef, and then #define to a clone of
751 what's in data.c.
752 (Fisnan): Always define, since it's always available now.
753 (syms_of_floatfns): Always define isnan at the Lisp level.
754
e39b275c 7552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
756
757 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
758
b2db44d9 7592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 760
f4af5137 761 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
762 The previous code assumed that file offsets (off_t values) fit in
763 EMACS_INT variables, which is not true on typical 32-bit hosts.
764 The code messed up by falsely reporting buffer overflow in cases
765 such as (insert-file-contents "big" nil 1 2) into an empty buffer
766 when "big" contains more than 2**29 bytes, even though this
767 inserts just one byte and does not overflow the buffer.
768 (Finsert_file_contents): Store file offsets as off_t
769 values, not as EMACS_INT values. Check for overflow when
770 converting between EMACS_INT and off_t. When checking for
771 buffer overflow or for overlap, take the offsets into account.
772 Don't use EMACS_INT for small values where int suffices.
773 When checking for overlap, fix a typo: ZV was used where
774 ZV_BYTE was intended.
775 (Fwrite_region): Don't assume off_t fits into 'long'.
776 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
777
ecfc0a49
MA
7782011-09-05 Michael Albinus <michael.albinus@gmx.de>
779
780 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
781
6511acf2 7822011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 783
0999621a 784 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
785
786 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 787 (esprintf, exprintf, evxprintf): New functions.
62f19c19 788 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 789 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
790 (modify_event_symbol): Do not assume that the length of
791 name_alist_or_stem is safe to alloca and fits in int.
792 (Fexecute_extended_command): Likewise for function name and binding.
793 (Frecursion_depth): Wrap around reliably on integer overflow.
794 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
795 since some callers pass EMACS_INT values.
796 (Fsingle_key_description): Don't crash if symbol name contains more
797 than MAX_ALLOCA bytes.
798 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
799 (get_minibuffer): Arg is now EMACS_INT, not int.
800 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 801 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
802 * window.h (command_loop_level, minibuf_level): Reflect API changes.
803
2be7d702
PE
804 * dbusbind.c (signature_cat): New function.
805 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
806 Do not overrun buffer; instead, report string overflow.
807
9d1df220
PE
808 * dispnew.c (add_window_display_history): Don't overrun buffer.
809 Truncate instead; this is OK since it's just a log.
810
33ef5c64
PE
811 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
812 even if the time zone offset is outlandishly large.
813 Don't mishandle offset == INT_MIN.
814
66c6fdd5
PE
815 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
816 when creating daemon; the previous buffer-overflow check was incorrect.
817
d749b01b
PE
818 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
819 which has the guts of the old verror function.
820
b5cd1905
PE
821 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
822 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
823
6e1a67fb
PE
824 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
825 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 826 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 827 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
828 length of string rather than counting it via multiple sprintfs;
829 that's simpler and more reliable.
c21721cc
PE
830 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
831 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
832 sprintf, in case result does not fit in int.
833
c57b67fc
PE
834 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
835 (fontset_from_font): Print it.
836
8a401434
PE
837 * frame.c (tty_frame_count): Now printmax_t, not int.
838 (make_terminal_frame, set_term_frame_name): Print it.
839 (x_report_frame_params): In X, window IDs are unsigned long,
840 not signed long, so print them as unsigned.
841 (validate_x_resource_name): Check for implausibly long names,
842 and don't assume name length fits in 'int'.
843 (x_get_resource_string): Don't blindly alloca invocation name;
844 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
845 not fit in int.
846
6e1a67fb
PE
847 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
848 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
849 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
850
0df02bf3
PE
851 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
852 Use esprintf, not sprintf, in case result does not fit in int.
853
48e30793
PE
854 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
855 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
856 it as a large positive number.
857 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
858 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
859
a66ff6d8
PE
860 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
861 in case result does not fit in int.
862
aca216ff
PE
863 * print.c (float_to_string): Detect width overflow more reliably.
864 (print_object): Make sprintf buffer a bit bigger, to avoid potential
865 buffer overrun. Don't assume list length fits in 'int'. Treat
866 print length of 0 as 0, not as infinity; to be consistent with other
867 uses of print length in this function. Don't overflow print length
868 index. Don't assume hash table size fits in 'long', or that
869 vectorlike size fits in 'unsigned long'.
870
31c286f7
PE
871 * process.c (make_process): Use printmax_t, not int, to format
872 process-name gensyms.
873
55e5faa1
PE
874 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
875
80f2e268
PE
876 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
877 to avoid potential buffer overrun.
878
670741ab
PE
879 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
880 if X resource line is longer than 512 bytes.
881
b7163a50
PE
882 * xfns.c (x_window): Make sprintf buffer a bit bigger
883 to avoid potential buffer overrun.
884
ae58ff1f
PE
885 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
886
c43c8a6a
PE
887 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
888
3f8236f4
PE
8892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
890
53e9fe90 891 Integer overflow fixes for scrolling, etc.
6511acf2
PE
892 Without these, Emacs silently mishandles large integers sometimes.
893 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
894 it were "C-u 1 M-x recenter" on a typical 64-bit host.
895
6511acf2
PE
896 * xdisp.c (try_window_id): Check Emacs fixnum range before
897 converting to 'int'.
806add1d 898
6511acf2 899 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
900 Check that an Emacs fixnum is in range before assigning it to 'int'.
901 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
902 values converted from Emacs fixnums.
903 (Frecenter): Don't wrap around a line count if it is out of 'int'
904 range; instead, treat it as an extreme value.
905 (Fset_window_configuration, compare_window_configurations):
906 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
907
6511acf2
PE
908 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
909 that can exceed INT_MAX. Check that EMACS_INT value is in range
910 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
911 (match_limit): Don't assume that a fixnum can fit in 'int'.
912
6511acf2 913 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
914 exceed INT_MAX.
915
6511acf2 916 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
917 (Fvertical_motion): Don't wrap around LINES values that don't fit
918 in 'int'. Instead, treat them as extreme values. This is good
919 enough for windows, which can't have more than INT_MAX lines anyway.
920
fcb901a7
LMI
9212011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
922
0f2f6b6d
LMI
923 * Require libxml/parser.h to avoid compilation warning.
924
fcb901a7
LMI
925 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
926
927 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
928 since this reportedly can destroy thread storage.
929
6e20a0d4
CY
9302011-08-30 Chong Yidong <cyd@stupidchicken.com>
931
932 * syntax.c (find_defun_start): Update all cache variables if
933 exiting early (Bug#9401).
934
148ae00e
EZ
9352011-08-30 Eli Zaretskii <eliz@gnu.org>
936
f6cfbd8f
EZ
937 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
938
148ae00e
EZ
939 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
940 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
941 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
942
943 * term.c (tty_append_glyph): New function.
944 (produce_stretch_glyph): Static function and its prototype deleted.
945
a66cfb1c
SM
946 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
947 Add prototypes.
148ae00e 948
c4a07a4c
PE
9492011-08-29 Paul Eggert <eggert@cs.ucla.edu>
950
951 * image.c (parse_image_spec): Check for nonnegative, not for positive,
952 when checking :margin (Bug#9390).
953 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 954 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
955 so that the name doesn't mislead. All uses changed.
956
6bc8cd65
JB
9572011-08-28 Johan Bockgård <bojohan@gnu.org>
958
959 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
960 set_tty_hooks.
961
dca4927e
EZ
9622011-08-27 Eli Zaretskii <eliz@gnu.org>
963
964 * xdisp.c (move_it_to): Don't bail out early when reaching
965 position beyond to_charpos, if we are scanning backwards.
966 (move_it_vertically_backward): When DY == 0, make sure we get to
967 the first character in the line after the newline.
968
f2cad773
PE
9692011-08-27 Paul Eggert <eggert@cs.ucla.edu>
970
971 * ccl.c: Improve and simplify overflow checking (Bug#9196).
972 (ccl_driver): Do not generate an out-of-range pointer.
973 (Fccl_execute_on_string): Remove unnecessary check for
974 integer overflow, noted by Stefan Monnier in
975 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
976 Remove a FIXME that didn't need fixing.
977 Simplify the newly-introduced buffer reallocation code.
978
0cae2cdb
JB
9792011-08-27 Juanma Barranquero <lekktu@gmail.com>
980
981 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
982
5fc295a4 9832011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 984
70c60eb2 985 Integer and memory overflow issues (Bug#9196).
726e0ab1 986
d31850da
PE
987 * doc.c (get_doc_string): Rework so that
988 get_doc_string_buffer_size is the actual buffer size, rather than
989 being 1 less than the actual buffer size; this makes xpalloc more
990 convenient.
991
a69fbedb
PE
992 * image.c (x_allocate_bitmap_record, cache_image):
993 * xselect.c (Fx_register_dnd_atom):
994 Simplify previous changes by using xpalloc.
995
fe5c5d37
PE
996 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
997 since either will do and ptrdiff_t is convenient with xpalloc.
998
0065d054
PE
999 * charset.c (charset_table_size)
1000 (struct charset_sort_data.priority): Now ptrdiff_t.
1001 (charset_compare): Don't overflow if priorities differ greatly.
1002 (Fsort_charsets): Don't assume list length fits in int.
1003 Check for size-calculation overflow when allocating sort data.
1004 (syms_of_charset): Allocate an initial charset table that is
1005 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1006
1007 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1008
1009 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1010 The actual value is always <= INT_MAX, and leaving it unsigned made
1011 overflow checking harder.
1012
1013 * dispextern.h (struct glyph_matrix.rows_allocated)
1014 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1015 with xpalloc. The values are still always <= INT_MAX.
1016
1017 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1018
1019 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1020 (SAFE_NALLOCA): New macro.
1021
1022 * region-cache.c (struct boundary.pos, find_cache_boundary)
1023 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1024 (set_cache_region, invalidate_region_cache)
1025 (revalidate_region_cache, know_region_cache, region_cache_forward)
1026 (region_cache_backward, pp_cache):
1027 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1028 so that ptrdiff_t * can be passed to xpalloc.
1029 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1030 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1031 (pp_cache): Don't assume cache_len fits in int.
1032 * region-cache.h: Adjust extern decls to match.
1033
1034 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1035 EMACS_INT, since either will do, for xpalloc.
1036
1037 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1038 (xnmalloc, xnrealloc, xpalloc): New functions.
1039
726e0ab1
PE
1040 * bidi.c (bidi_shelve_header_size): New constant.
1041 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1042 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1043
51f30bc5 1044 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1045 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1046 (overlay_strings):
1047 Don't update size of array until after memory allocation succeeds,
1048 because xmalloc/xrealloc may not return.
0065d054
PE
1049 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1050 now that we have proper integer overflow checking.
1051 (record_overlay_string, overlay_strings): Catch overflows when
1052 calculating size of overlay_str_buf.
726e0ab1 1053
0065d054
PE
1054 * callproc.c (Fcall_process): Check for size overflow when
1055 calculating size of args2.
1056 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1057 Normally we prefer signed values, but sticking with ptrdiff_t would
1058 require adding more-complicated checks.
726e0ab1
PE
1059
1060 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1061 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1062 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1063 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1064
1065 * character.c (Fstring): Check for size-calculation overflow.
1066
1067 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1068 unnecessary integer overflow. Check for size overflow.
1069 (encode_coding_object): Don't update size until xmalloc succeeds.
1070
1071 * composite.c (get_composition_id): Check for overflow in glyph
1072 length calculations.
1073
1074 Integer and memory overflow fixes for display code.
1075 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1076 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1077 (scrolling_window): Check for overflow in size calculations.
1078 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1079 Don't assume glyph table len fits in int.
1080 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1081 (row_table_size): Now ptrdiff_t, not int.
1082 (scrolling_window): Avoid overflow in size calculations.
1083 Don't update size until allocation succeeds.
1084 * fns.c (concat): Check for overflow in size calculations.
1085 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1086 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1087 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1088
1089 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1090 (get_doc_string): Check for size calculation overflow.
1091 Don't update size until allocation succeeds.
1092 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1093 EMACS_INT, where ptrdiff_t will do.
1094 (Fsubstitute_command_keys): Check for string overflow.
1095
1096 * editfns.c (set_time_zone_rule): Don't assume environment length
1097 fits in int.
1098 (message_length): Now ptrdiff_t, not int.
1099 (Fmessage_box): Don't update size until allocation succeeds.
1100 Don't assume message length fits in int.
1101 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1102
0065d054
PE
1103 * emacs.c (main): Do not reallocate argv, since there is a null at
1104 the end that can be overwritten, and this way there's no need to
1105 worry about size-calculation overflow.
1106 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1107
1108 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1109 alloc succeeds.
1110 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1111
1112 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1113 (x_set_scroll_bar_width, x_figure_window_size):
1114 Check for integer overflow.
1115 (x_set_alpha): Do not assume XINT fits in int.
1116
1117 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1118 This is for the members text_lines, text_cols, total_lines, total_cols,
1119 where the system imposes an 'int' limit.
1120
1121 * fringe.c (Fdefine_fringe_bitmap):
1122 Don't update size until alloc works.
1123
1124 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1125 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1126
1127 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1128 Check for size-calculation overflow.
1129 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1130 do, as we prefer signed integers.
1131 (id_to_widget.max_size, id_to_widget.used)
1132 (xg_store_widget_in_map, xg_remove_widget_from_map)
1133 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1134 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1135 Use and return ptrdiff_t, not int.
1136 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1137 * gtkutil.h: Change prototypes to match the above.
1138
1139 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1140 are duplicate now that they've been promoted to lisp.h.
1141 (x_allocate_bitmap_record, x_alloc_image_color)
1142 (make_image_cache, cache_image, xpm_load):
1143 Don't update size until alloc is done.
1144 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1145 (x_detect_edges):
3256efce 1146 Check for size calculation overflow.
726e0ab1
PE
1147 (ct_colors_allocated_max): New constant.
1148 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1149 overflow.
3256efce 1150
726e0ab1
PE
1151 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1152 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1153 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1154 Use ptrdiff_t, not int, to count maps.
1155 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1156 calculations. Don't update size until allocation succeeds.
1157 Redo calculations to avoid overflow.
726e0ab1
PE
1158 * keyboard.h: Change prototypes to match the above.
1159
1160 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1161 to count maps.
1162 (current_minor_maps): Check for size calculation overflow.
1163 * keymap.h: Change prototypes to match the above.
1164
1165 * lread.c (read1, init_obarray): Don't update size until alloc done.
1166
1167 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1168 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1169
726e0ab1
PE
1170 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1171 Now ptrdiff_t, not int.
1172 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1173 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1174
1175 * process.c (Fnetwork_interface_list): Check for overflow
1176 in size calculation.
1177
1178 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1179
1180 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1181 overflow. Don't bother calling xmalloc when xrealloc will do.
1182
1183 * search.c (Freplace_match): Check for size calculation overflow.
1184 (Fset_match_data): Don't assume list lengths fit in 'int'.
1185
1186 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1187 for command line length. Do not attempt to address one before the
1188 beginning of an array, as that's not portable.
1189
1190 * term.c (max_frame_lines): Remove; unused.
1191 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1192 not int.
1193 (encode_terminal_code, calculate_costs): Check for size
1194 calculation overflow.
1195 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1196 table lengths and related sizes. Don't update size until alloc
1197 done. Redo calculations to avoid overflow.
1198 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1199
1200 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1201 subtracting pointers.
1202 (gobble_line): Check for overflow more carefully. Don't update size
1203 until alloc done.
1204
1205 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1206 Don't update size until alloc done.
1207 Redo size calculations to avoid overflow.
1208 Check for size calculation overflow.
0065d054 1209 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1210
1211 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1212 Use ptrdiff_t, not int, for sizes.
1213 (store_mode_line_noprop_char): Don't update size until alloc done.
1214
0065d054
PE
1215 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1216 Use ptrdiff_t, not int, for sizes.
1217 (Finternal_make_lisp_face, cache_face):
1218 Check for size calculation overflow.
1219 (cache_face): Treat size calculation overflows as if they were
1220 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1221
1222 * xfns.c (x_encode_text, x_set_name_internal)
1223 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1224 sizes, since they can exceed INT_MAX in size. Check for size
1225 calculation overflow.
1226
0065d054
PE
1227 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1228 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1229 Don't update size until alloc done.
1230
0065d054 1231 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1232 as sprintf is limited to int lengths.
1d526e2f 1233
252c5ee1
PE
1234 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1235 (X_LONG_MIN): New macros.
864d7ce7
PE
1236 Use them to make the following changes clearer.
1237 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1238 This change doesn't affect the value now, but it may help remind
1239 future maintainers not to raise the value too much later.
1240 (SELECTION_QUANTUM): Remove, replacing with ...
1241 (selection_quantum): ... new function, which avoids overflow.
1242 All uses changed.
1243 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1244 assumption that selection length fits in 'int'.
1245 (x_reply_selection_request, x_handle_selection_request)
1246 (x_get_window_property, receive_incremental_selection)
1247 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1248 (lisp_data_to_selection_data, clean_local_selection_data):
1249 Use ptrdiff_t, not int, to record length of selection.
1250 (x_reply_selection_request, x_get_window_property)
1251 (receive_incremental_selection, x_property_data_to_lisp):
1252 Redo calculations to avoid overflow.
1253 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1254 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1255 something.
1256 (x_get_window_property, receive_incremental_selection)
1257 (lisp_data_to_selection_data, x_property_data_to_lisp):
1258 Check for size-calculation overflow.
1259 (x_get_window_property, receive_incremental_selection)
1260 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1261 Don't store size until memory allocation succeeds.
1262 (x_get_window_property): Plug memory leak on memory exhaustion.
1263 Don't double-block input; malloc is safe here. Don't assume 2**34
1264 - 4 fits in unsigned long. Add an xassert to check
1265 XGetWindowProperty overflow. Be more careful about overflow
1266 calculations, and distinguish size from memory overflow better.
1267 (receive_incremental_selection): When tracing, don't assume
1268 unsigned int is less than INT_MAX.
1269 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1270 harmful) conversions of unsigned short to int.
1271 (lisp_data_to_selection_data): Don't assume that integers
1272 in the range -65535 through -1 fit in an X unsigned short.
1273 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1274 result parameters unless successful. Rely on cons_to_unsigned
1275 to report problems with elements; the old code wasn't right anyway.
1276 (x_check_property_data): Check for int overflow; we cannot use
1277 a wider type due to X limits.
1278 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1279
726e0ab1 1280 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1281
0065d054
PE
1282 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1283 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1284 (x_color_cells): Don't store size until memory allocation succeeds.
1285 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1286 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1287 (x_term_init): Don't assume length fits in int (sprintf is limited
1288 to int size).
bc18e09d 1289
ebfa62c0
PE
1290 Use ptrdiff_t for composition IDs.
1291 * character.c (lisp_string_width):
1292 * composite.c (composition_table_size, n_compositions)
1293 (get_composition_id, composition_gstring_from_id):
1294 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1295 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1296 * window.c (Frecenter):
1297 Use ptrdiff_t, not int, for composition IDs.
1298 * composite.c (get_composition_id): Check for integer overflow.
1299 * composite.h: Adjust prototypes to match the above changes.
1300
d3411f89
PE
1301 Use ptrdiff_t for hash table indexes.
1302 * category.c (hash_get_category_set):
1303 * ccl.c (ccl_driver):
1304 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1305 * coding.c (coding_system_charset_list, detect_coding_system):
1306 * coding.h (struct coding_system.id):
1307 * composite.c (get_composition_id, gstring_lookup_cache):
1308 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1309 * image.c (xpm_get_color_table_h):
1310 * lisp.h (hash_lookup, hash_put):
1311 * minibuf.c (Ftest_completion):
1312 Use ptrdiff_t for hash table indexes, not int (which is too
1313 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1314 32-bit --with-wide-int hosts).
1315
e097a6fa
PE
1316 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1317 Add a FIXME comment about memory leaks.
1318 (syms_of_charset): Don't assume xmalloc returns.
1319
5637687f
PE
1320 Don't assume that stated character widths fit in int.
1321 * character.c (Fchar_width, c_string_width, lisp_string_width):
1322 * character.h (CHAR_WIDTH):
1323 * indent.c (MULTIBYTE_BYTES_WIDTH):
1324 Use sanitize_char_width to avoid undefined and/or bad behavior
1325 with outlandish widths.
a66cfb1c 1326 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1327 now that we have two such functions. All uses changed.
1328 (sanitize_char_width): New inline function.
1329
a2271ba2
PE
1330 Don't assume that tab-width fits in int.
1331 * character.h (sanitize_width): New inline function.
1332 (SANE_TAB_WIDTH): New macro.
1333 (ASCII_CHAR_WIDTH): Use it.
1334 * indent.c (sane_tab_width): Remove. All uses replaced by
1335 SANE_TAB_WIDTH (current_buffer).
1336 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1337
18c52557
PE
1338 * fileio.c: Integer overflow issues with file modes.
1339 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1340
caeeedc1
PE
1341 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1342 Remove unreachable code.
1343 (read_hex, load_charset_map_from_file): Check for integer overflow.
1344
50849c52
PE
1345 * xterm.c: don't go over XClientMessageEvent limit
1346 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1347 (x_send_scroll_bar_event): Likewise. Check that the size does not
1348 exceed limits imposed by XClientMessageEvent, as well as the usual
1349 ptrdiff_t and size_t limits.
1350
b13995db
PE
1351 * keyboard.c: Overflow, signedness and related fixes.
1352 (make_lispy_movement): Use same integer type in forward decl
1353 that is used in the definition.
1354 (read_key_sequence, keyremap_step):
1355 Change bufsize argument back to int, undoing my 2011-03-30 change.
1356 We prefer signed types, and int is wide enough here.
1357 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1358 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1359 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1360 length, not size_t. Use ptrdiff_t for index, not int.
1361 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1362 possibility of integer overflow.
1363
13464394
PE
1364 Overflow, signedness and related fixes for images.
1365
1366 * dispextern.h (struct it.stack[0].u.image.image_id)
1367 (struct_it.image_id, struct image.id, struct image_cache.size)
1368 (struct image_cache.used, struct image_cache.ref_count):
1369 * gtkutil.c (update_frame_tool_bar):
1370 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1371 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1372 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1373 * nsmenu.m (update_frame_tool_bar):
1374 * xdisp.c (calc_pixel_width_or_height):
1375 * xfns.c (image_cache_refcount):
1376 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1377 on typical 64-bit hosts.
1378
1379 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1380 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1381 Omit unnecessary casts to int.
1382 (parse_image_spec): Check that integers fall into 'int' range
1383 when the callers expect that.
1384 (image_ascent): Redo ascent calculation to avoid int overflow.
1385 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1386 (lookup_image): Remove unnecessary tests.
1387 (xbm_image_p): Locals are now of int, not EMACS_INT,
1388 since parse_image_check makes sure they fit into int.
1389 (png_load, gif_load, svg_load_image):
1390 Prefer int to unsigned where either will do.
1391 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1392 old tiff_error_handler and tiff_warning_handler.
1393 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1394 stack buffer overflows. It uses only the features of vsnprintf
1395 that are common to both POSIX and native Microsoft.
1396 (tiff_error_handler, tiff_warning_handler): Use it.
1397 (tiff_load, gif_load, imagemagick_load_image):
1398 Don't assume :index value fits in 'int'.
1399 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1400 (imagemagick_load_image): Check that crop parameters fit into
1401 the integer types that MagickCropImage accepts. Don't assume
1402 Vimagemagick_render_type has a nonnegative value. Don't assume
1403 size_t fits in 'long'.
1404 (gs_load): Use printmax_t to print the widest integers possible.
1405 Check for integer overflow when computing image height and width.
1406
c11821d4
EZ
14072011-08-26 Eli Zaretskii <eliz@gnu.org>
1408
1409 * xdisp.c (redisplay_window): Don't force window start if point
1410 will be invisible in the resulting window. (Bug#9324)
1411
0c95fcf7
EZ
14122011-08-25 Eli Zaretskii <eliz@gnu.org>
1413
1414 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1415 the display spec is of the form `(space ...)'.
1416 (handle_display_spec): Return the value returned by
1417 handle_single_display_spec, not just 1 or zero.
1418 (handle_single_display_spec): If the display spec is of the form
1419 `(space ...)', and specifies display in the text area, return 2
1420 rather than 1.
fee65a97 1421 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1422 accurately, and prefer exact match for point under bidi.
1423 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1424
1425 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1426 into disp_prop; all users changed.
1427
1428 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1429 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1430 for the text covered by the display property.
1431
e4ed06f1
CY
14322011-08-25 Chong Yidong <cyd@stupidchicken.com>
1433
1434 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1435 Change return value to nil.
1436 (Frecord_buffer): Delete unused function.
1437
f67cdd7f
EZ
14382011-08-24 Eli Zaretskii <eliz@gnu.org>
1439
5980d4c6
EZ
1440 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1441 buffers, return left-to-right.
8610fe8b
EZ
1442 (set_cursor_from_row): Consider candidate row a win if its glyph
1443 represents a newline and point is on that newline. Fixes cursor
1444 positioning on the newline at EOL of R2L text within L2R
1445 paragraph, and vice versa.
1446 (try_cursor_movement): Check continued rows, in addition to
1447 continuation rows. Fixes unwarranted scroll when point enters a
1448 continued line of R2L text within an L2R paragraph, or vice versa.
1449 (cursor_row_p): Consider the case of point being equal to
1450 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1451 from the end of a short line to the beginning of a continued line
1452 of R2L text within L2R paragraph.
1453 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1454 composed characters.
5980d4c6 1455
f67cdd7f
EZ
1456 * bidi.c (bidi_check_type): Use xassert.
1457 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1458 members.
1459
bca633fb
EZ
14602011-08-23 Eli Zaretskii <eliz@gnu.org>
1461
1462 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1463 a character.
1464
4a5885a7
CY
14652011-08-23 Chong Yidong <cyd@stupidchicken.com>
1466
1467 * nsfont.m (ns_otf_to_script): Fix typo.
1468
0902a04e
KH
14692011-08-22 Kenichi Handa <handa@m17n.org>
1470
1471 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1472 extra slot even if the purpose is char-code-property-table.
1473
1a2e6670
EZ
14742011-08-23 Eli Zaretskii <eliz@gnu.org>
1475
8ddde651
EZ
1476 * xdisp.c (redisplay_window): When computing centering_position,
1477 account for the height of the header line. (Bug#8874)
1478
425cc014
EZ
1479 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1480 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1481 candidate is selected by the mouse, and that candidate has a
1482 composed character under the mouse.
1483
1a2e6670
EZ
1484 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1485 coordinates reported by pos-visible-in-window-p for a composed
1486 character in column zero.
1487
8b76d6f8
SM
14882011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1489
1490 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1491
dac347dd
EZ
14922011-08-22 Eli Zaretskii <eliz@gnu.org>
1493
1494 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1495 consider it a hit if to_charpos is anywhere in the range of the
1496 composed buffer positions.
1497
e013fb34
CY
14982011-08-22 Chong Yidong <cyd@stupidchicken.com>
1499
1500 * image.c (gif_load): Don't assume that each subimage has the same
1501 dimensions as the base image. Handle disposal method that is
1502 "undefined" by the gif spec (Bug#9335).
1503
bd1ba3e8
CY
15042011-08-20 Chong Yidong <cyd@stupidchicken.com>
1505
1506 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1507 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1508
54a1215b
EZ
15092011-08-19 Eli Zaretskii <eliz@gnu.org>
1510
823564e5
EZ
1511 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1512 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1513 from an Org mode buffer to a Speedbar frame.
1514
54a1215b
EZ
1515 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1516 a composition, take its buffer position from IT->cmp_it.charpos.
1517 Fixes cursor positioning at the beginning of a line that begins
1518 with a composed character.
1519
9778ebcc
EZ
15202011-08-18 Eli Zaretskii <eliz@gnu.org>
1521
0be6ee06
EZ
1522 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1523 character bidirectional type, use STRONG_L instead. Fixes crashes
1524 in a buffer produced by `describe-categories'.
1525
9778ebcc
EZ
1526 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1527 members before the level stack, so they would be saved and
1528 restored when copying iterator state. Fixes incorrect reordering
1529 around TABs covered by display properties.
1530
156bffbe
AS
15312011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1532
6b02f655 1533 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1534
72ad093b
CY
15352011-08-17 Chong Yidong <cyd@stupidchicken.com>
1536
1537 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1538 (internal_condition_case_2, internal_condition_case_n):
1539 Remove unnecessary aborts (Bug#9081).
72ad093b 1540
35774242
EZ
15412011-08-17 Eli Zaretskii <eliz@gnu.org>
1542
1543 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1544 has no `load' handler, try opening the file locally. (Bug#9311)
1545
db76dd85
KB
15462011-08-16 Ken Brown <kbrown@cornell.edu>
1547
1548 * gmalloc.c: Expand comment.
1549
b215eee5
EZ
15502011-08-16 Eli Zaretskii <eliz@gnu.org>
1551
1552 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1553 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1554
a4579d33
KB
15552011-08-16 Ken Brown <kbrown@cornell.edu>
1556
1557 Fix memory allocation problems in Cygwin build (Bug#9273).
1558
1559 * unexcw.c ( __malloc_initialized): Declare external variable.
1560 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1561
8b76d6f8
SM
1562 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1563 New variables.
a4579d33
KB
1564 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1565 dumped emacs.
1566 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1567 in the static heap.
1568 [CYGWIN] (special_realloc): New function.
1569 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1570 requests to realloc storage in the static heap.
1571
3ebec551
PE
15722011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1573
1574 * bidi.c (bidi_initialize): Remove unused local.
1575
9fd8be00
EZ
15762011-08-15 Eli Zaretskii <eliz@gnu.org>
1577
6b02f655
SM
1578 * bidimirror.h:
1579 * biditype.h: Remove file.
1580 * makefile.w32-in ($(BLD)/bidi.$(O)):
1581 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1582
1583 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1584
1585 * chartab.c: Improve commentary for the uniprop_table API.
1586
32413314
EZ
1587 * bidi.c (bidi_paragraph_init): Support zero value of
1588 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1589 (bidi_initialize): Use uniprop_table instead of including
1590 biditype.h and bidimirror.h.
32413314 1591
9fd8be00
EZ
1592 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1593 coordinates of the iterator when restoring from ppos_it.
1594 (Bug#9296)
1595
5cf2b69b
KH
15962011-08-14 Kenichi Handa <handa@m17n.org>
1597
1598 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1599 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1600
daf17d00
EZ
16012011-08-14 Eli Zaretskii <eliz@gnu.org>
1602
1603 * xdisp.c (move_it_in_display_line_to): Don't invoke
1604 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1605 ppos_it. Fixes vertical cursor motion when line beginning is
1606 covered by an image. (Bug#9296)
1607
08e3161a
JD
16082011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1609
1610 * nsterm.h (ns_run_ascript): Declare.
1611 (NSAPP_DATA2_RUNASSCRIPT): Define.
1612
1613 * nsfns.m (as_script, as_result, as_status): New static variables.
1614 (ns_run_ascript): New function.
5e617bc2 1615 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1616 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1617 the event loop. Get status from as_status (Bug#7276).
1618
1619 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1620 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1621 the event loop (Bug#7276).
1622
a3720aa2
AS
16232011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1624
1625 * gnutls.c (QCgnutls_bootprop_priority)
1626 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1627 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1628 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1629 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1630 (QCgnutls_bootprop_verify_hostname_error)
1631 (QCgnutls_bootprop_callbacks_verify): Rename from
1632 Qgnutls_bootprop_..., all uses changed.
1633
1634 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1635 uses changed.
1636
0a0d27fb
PE
16372011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1638
19d5c50c
PE
1639 * xfaces.c (Qframe_set_background_mode): Now static.
1640 * dispextern.h (Qframe_set_background_mode): Remove decl.
1641
0a0d27fb
PE
1642 * process.c (Fnetwork_interface_info): Declare local only if needed.
1643
377538cb
JD
16442011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1645
1646 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1647 (Fnetwork_interface_list): Allocate in increments of bytes instead
1648 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1649 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1650 sockaddr.
1651 (struct ifflag_def): notrailers is smart on OSX.
1652 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1653 Get hardware address with getifaddrs if available.
1654
08fff70c
EZ
16552011-08-12 Eli Zaretskii <eliz@gnu.org>
1656
1657 * xdisp.c (iterate_out_of_display_property): xassert that
1658 IT->position is set to within IT->object's boundaries. Break from
1659 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1660 when IT->position is set up wrongly due to some bug.
1661 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1662 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1663 entry. Force push_it to save on the stack the current
1664 buffer/string position, to be restored by pop_it. Fix flags in
1665 the iterator structure wrt the object coming from a display
1666 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1667 properties. (Bug#9284)
1668
7be1c708 16692011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1670
7be1c708
CY
1671 * fontset.c (fontset_get_font_group): Add proper type checks.
1672 (Bug#9172)
aac0c6e3 1673
7be1c708 16742011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1675
7be1c708
CY
1676 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1677 and LC_VERSION_MIN_MACOSX.
1678 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1679 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1680
97bb72a6
EZ
16812011-08-08 Eli Zaretskii <eliz@gnu.org>
1682
1683 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1684 no-display-properties-and-no-overlays under bidi display.
1685 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1686 properties and overlays.
97bb72a6 1687
d5617611
CY
16882011-08-08 Chong Yidong <cyd@stupidchicken.com>
1689
37e11a63
CY
1690 * editfns.c (Fset_time_zone_rule): Document relationship with the
1691 setenv function.
1692
d5617611
CY
1693 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1694 the font entity extracted from the cache (Bug#8109).
1695
58872834
CY
16962011-08-07 Chong Yidong <cyd@stupidchicken.com>
1697
1698 * composite.c (autocmp_chars): Don't reset point. That is done by
1699 restore_point_unwind (Bug#5984).
1700
75bfc667
JL
17012011-08-07 Juri Linkov <juri@jurta.org>
1702
1703 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1704 to show the arg `TIME' instead of `TIMEVAL'.
1705
d1410150
EZ
17062011-08-06 Eli Zaretskii <eliz@gnu.org>
1707
1708 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1709 display property strides EOL and includes a newline, as in
1710 longlines-mode. (Bug#9254)
75b771e4
EZ
1711 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1712 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1713
1714 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1715 is non-zero, even if the data buffer is NULL. Fixes a crash in
1716 vertical-motion with longlines-mode. (Bug#9254)
1717
35928349
EZ
17182011-08-05 Eli Zaretskii <eliz@gnu.org>
1719
ec7cc85b
EZ
1720 * bidi.c <bidi_cache_total_alloc>: Now static.
1721 (bidi_initialize): Initialize bidi_cache_total_alloc.
1722
8b76d6f8 1723 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1724 cache. (Bug#9221)
1725
1726 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1727 amount allocated this far in `bidi_cache_total_alloc'.
1728 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1729 non-zero, only free the data buffer without restoring the cache
1730 contents. All callers changed.
1731
1732 * dispextern.h (bidi_unshelve_cache): Update prototype.
1733
1734 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1735 (move_it_in_display_line, move_it_to)
1736 (move_it_vertically_backward, move_it_by_lines): Replace the call
1737 to xfree to an equivalent call to bidi_unshelve_cache.
1738 (move_it_in_display_line_to): Fix logic of returning
412b6358 1739 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1740
e2e2423b
EZ
17412011-08-05 Eli Zaretskii <eliz@gnu.org>
1742
1743 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1744 came from a string character with a `cursor' property. (Bug#9229)
1745
ae9e757a
JD
17462011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1747
1748 * Makefile.in (LIB_PTHREAD): New variable.
1749 (LIBES): Add LIB_PTHREAD (Bug#9216).
1750
1751 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1752 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1753
213bd7f2
AS
17542011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1755
6b02f655 1756 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1757
99aaf75f
JD
17582011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1759
1760 * xterm.c (x_find_topmost_parent): New function.
1761 (x_set_frame_alpha): Find topmost parent window with
1762 x_find_topmost_parent and set the property there also (bug#9181).
1763 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1764
c74e9d86
PE
17652011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 * callproc.c (Fcall_process): Avoid vfork clobbering
1768 the local vars buffer, coding_systems, current_dir.
1769
640c8776
SM
17702011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1771
1772 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1773
f26d0e4c
PE
17742011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1775
8a10d76c
PE
1776 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1777 so that it is not optimized away.
1778
f26d0e4c
PE
1779 * xdisp.c (compute_display_string_pos): Remove unused local.
1780
55439c61
EZ
17812011-08-02 Eli Zaretskii <eliz@gnu.org>
1782
1783 Fix slow cursor motion and scrolling in large buffers with
1784 selective display, like Org Mode buffers. (Bug#9218)
1785
1786 * dispextern.h (struct bidi_it): New member disp_prop_p.
1787
1788 * xdisp.c: Remove one-slot cache of display string positions.
1789 (compute_display_string_pos): Accept an additional argument
5e617bc2 1790 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1791 for a display string or property. If found, set DISP_PROP_P
1792 non-zero.
1793
1794 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1795 DISP_PROP_P, and pass it to compute_display_string_pos.
1796 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1797 non-zero. All callers of bidi_fetch_char changed.
1798
fb33fa43
SM
17992011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1800
1801 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1802
b099e063
DM
18032010-12-03 Don March <don@ohspite.net>
1804
1805 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1806 last character M-[char] is translated to ESC [char] (bug#7541).
1807
5cc7f7af
KH
18082011-08-02 Kenichi Handa <handa@m17n.org>
1809
d0fffa3f 1810 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1811
1812 * chartab.c (uniprop_table): Make it non-static.
1813
525d5e6e
EZ
18142011-08-01 Eli Zaretskii <eliz@gnu.org>
1815
1816 * xdisp.c (forward_to_next_line_start): Accept additional argument
1817 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1818 on the newline.
1819 (reseat_at_next_visible_line_start): Use the bidi iterator state
1820 returned by forward_to_next_line_start to restore the state of
1821 it->bidi_it after backing up to previous newline. (Bug#9212)
1822
31011111
AS
18232011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1824
1825 * regex.c (re_comp): Protoize.
1826 (re_exec): Fix return type.
1827 (regexec): Fix type of `ret'. (Bug#9203)
1828
476371c4
PE
18292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1830
e5d76069
PE
1831 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1832 This is needed if max-image-size is a floating-point number.
1833
9a79b20c
AS
18342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1835
1836 * print.c (print_object): Print empty symbol as ##.
1837
1838 * lread.c (read1): Read ## as empty symbol.
1839
d8c2fa78
AA
18402011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1841
1842 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1843 setting frame foreground color (Bug#9175).
1844 (x_set_background_color): Likewise.
1845
ffe57a7a
AA
1846 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1847 contents (Bug#9176).
1848 (EmacsTooltip -init): Remove bezels and add shadows to
1849 tooltip windows.
1850
bf3492a5
AA
1851 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1852 or scroll bar (Bug#8470).
1853
d55e9c53
AA
1854 * nsfont.m (nsfont_open): Remove assignment to voffset and
1855 unnecessary vars hshink, expand, hd, full_height, min_height.
1856 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1857
1858 * nsterm.h (nsfont_info): Remove voffset field.
1859
d8c2fa78 18602011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1861
1862 Implement strike-through and overline on NextStep (Bug#8863).
1863
1864 * nsfont.m (nsfont_open): Use underline position provided by font,
1865 instead of hard-coded value of 2.
1866 (nsfont_draw): Call ns_draw_text_decoration instead.
1867
1868 * nsterm.h: Add declaration for ns_draw_text_decoration.
1869
1870 * nsterm.m (ns_draw_text_decoration): New function for drawing
1871 underline, overline, and strike-through.
1872 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1873 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1874 accommodate underlining, etc.
4843aac3 1875
4cc60b9b
EZ
18762011-07-28 Eli Zaretskii <eliz@gnu.org>
1877
bc7ece87
EZ
1878 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1879 default.
4cc60b9b 1880
476371c4
PE
18812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1882
66606eea
PE
1883 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1884 Without this fix, if a signal arrives just after memory fills up,
1885 'malloc' might be invoked reentrantly.
1886
476371c4
PE
1887 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1888 In other words, assume that every image size is allowed, on non-X
1889 hosts. This assumption is probably wrong, but it lets Emacs compile.
1890
f3fcc40d
AS
18912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1892
1893 * regex.c (re_iswctype): Convert return values to boolean.
1894
350c992f
EZ
18952011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1896
1897 * xdisp.c (compute_display_string_pos): Don't use cached display
1898 string position if the buffer had its restriction changed.
1899 (Bug#9184)
1900
5266b4bb
PE
19012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1904
2573a837 19052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1906
41f55ccd 1907 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1908
39e378da
PE
1909 * bidi.c: Integer size and overflow fixes.
1910 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1911 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1912 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1913 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1914 (bidi_find_other_level_edge):
1915 Use ptrdiff_t instead of EMACS_INT where either will do.
1916 This works better on 32-bit hosts configured --with-wide-int.
1917 (bidi_cache_ensure_space): Check for size-calculation overflow.
1918 Use % rather than repeated addition, for better worst-case speed.
1919 Don't set bidi_cache_size until after xrealloc returns, because it
1920 might not return.
1921 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1922 (bidi_cache_ensure_space): Also check that the bidi cache size
1923 does not exceed that of the largest Lisp string or buffer. See Eli
1924 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1925
5e927815
PE
1926 * alloc.c (__malloc_size_t): Remove.
1927 All uses replaced by size_t. See Andreas Schwab's note
1928 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1929
ca4aa935
PE
1930 * image.c: Improve checking for integer overflow.
1931 (check_image_size): Assume that f is nonnull, since
1932 it is always nonnull in practice. This is one less thing to
1933 worry about when checking for integer overflow later.
1934 (x_check_image_size): New function, which checks for integer
1935 overflow issues inside X.
1936 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1937 This removes the need for a memory_full check.
1938 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1939 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1940 (xbm_read_bitmap_data): Change locals back to 'int', since
1941 their values must fit in 'int'.
1942 (xpm_load_image, png_load, tiff_load):
1943 Invoke x_create_x_image_and_pixmap earlier,
1944 to avoid much needless work if the image is too large.
1945 (tiff_load): Treat overly large images as if
1946 x_create_x_image_and_pixmap failed, not as malloc failures.
1947 (gs_load): Use x_check_image_size.
1948
5f8f9cc2
PE
1949 * gtkutil.c: Omit integer casts.
1950 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1951 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1952
5adf60bc
PE
1953 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1954
c8907a93
PE
1955 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1956 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1957 would wrongly return t on a 64-bit host.
1958
e3c25c68
PE
1959 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1960 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1961 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1962 and therefore cause GCC to emit a bogus diagnostic in some cases.
1963
3f791afe
PE
1964 * image.c: Integer signedness and overflow and related fixes.
1965 This is not an exhaustive set of fixes, but it's time to
1966 record what I've got.
1967 (lookup_pixel_color, check_image_size): Remove redundant decls.
1968 (check_image_size): Don't assume that arbitrary EMACS_INT values
1969 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1970 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1971 (tiff_load, imagemagick_load_image):
1972 Check for overflow in size calculations.
1973 (x_create_x_image_and_pixmap): Remove unnecessary test for
1974 xmalloc returning NULL; that can't happen.
1975 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1976 (xpm_color_bucket): Use better integer hashing function.
1977 (xpm_cache_color): Don't possibly over-allocate memory.
1978 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1979 (gif_memory_source):
1980 Use ptrdiff_t, not int or size_t, to record sizes.
1981 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1982 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1983 either works, as we prefer signed integers.
1984 (tiff_read_from_memory, tiff_write_from_memory):
1985 Return tsize_t, not size_t, since that's what the TIFF API wants.
1986 (tiff_read_from_memory): Don't fail simply because the read would
1987 go past EOF; instead, return a short read.
1988 (tiff_load): Omit no-longer-needed casts.
1989 (Fimagemagick_types): Don't assume size fits into 'int'.
1990
3cc5a532
PE
1991 Improve hashing quality when configured --with-wide-int.
1992 * fns.c (hash_string): New function, taken from sxhash_string.
1993 Do not discard information about ASCII character case; this
1994 discarding is no longer needed.
1995 (sxhash-string): Use it. Change sig to match it. Caller changed.
1996 * lisp.h: Declare it.
1997 * lread.c (hash_string): Remove, since we now use fns.c's version.
1998 The fns.c version returns a wider integer if --with-wide-int is
1999 specified, so this should help the quality of the hashing a bit.
2000
b312a492
PE
2001 * emacs.c: Integer overflow minor fix.
2002 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2003 Define only if GNU_LINUX.
2004 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2005
dfd153ae
PE
2006 * dispnew.c: Integer signedness and overflow fixes.
2007 Remove unnecessary forward decls, that were a maintenance hassle.
2008 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2009 All uses changed.
2010 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2011 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2012 (prepare_desired_row, line_draw_cost):
2013 Use int, not unsigned, where either works.
2014 (save_current_matrix, restore_current_matrix):
2015 Use ptrdiff_t, not size_t, where either works.
2016 (init_display): Check for overflow more accurately, and without
2017 relying on undefined behavior.
2018
a81d11a3
PE
2019 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2020 Remove, replacing with the new symbols in lisp.h. All uses changed.
2021 * fileio.c (make_temp_name):
2022 * filelock.c (lock_file_1, lock_file):
2023 * xdisp.c (message_dolog):
2024 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2025 Use pMd etc. instead.
2026 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2027 replacing the pWIDE etc. symbols removed from editfns.c.
2028
3300e6fd
PE
2029 * keyboard.h (num_input_events): Now uintmax_t.
2030 This is (very slightly) less likely to mess up due to wraparound.
2031 All uses changed.
2032
fd05c7e9
PE
2033 * buffer.c: Integer signedness fixes.
2034 (alloc_buffer_text, enlarge_buffer_text):
2035 Use ptrdiff_t rather than size_t when either will do, as we prefer
2036 signed integers.
2037
903fe15d
PE
2038 * alloc.c: Integer signedness and overflow fixes.
2039 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2040 (__malloc_size_t): Default to size_t, not to int.
2041 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2042 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2043 Prefer ptrdiff_t to size_t when either would do, as we prefer
2044 signed integers.
2045 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2046 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2047 Now const. Initialize with values that are in range even if char
2048 is signed.
2049 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2050 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2051 These functions do the right thing with sizes > 2**32.
2052 (check_depth): Now ptrdiff_t, not int.
2053 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2054 Adjust to new way of storing sizes. Check for size overflow bugs
2055 in rest of code.
2056 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2057 slightly wrong anyway, as it missed one instance of
2058 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2059 (refill_memory_reserve): Omit needless cast to size_t.
2060 (mark_object_loop_halt): Mark as externally visible.
2061
ac82cc6a
PE
2062 * xselect.c: Integer signedness and overflow fixes.
2063 (Fx_register_dnd_atom, x_handle_dnd_message):
2064 Use ptrdiff_t, not size_t, since we prefer signed.
2065 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2066 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2067 x_dnd_atoms_size and x_dnd_atoms_length.
2068
c2d1e36d
PE
2069 * doprnt.c: Prefer signed to unsigned when either works.
2070 * eval.c (verror):
2071 * doprnt.c (doprnt):
2072 * lisp.h (doprnt):
2073 * xdisp.c (vmessage):
2074 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2075 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2076 prefer signed arithmetic to avoid comparison confusion.
2077 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2078 but is a bit tricky.
2079
0e926e56
PE
2080 Assume freestanding C89 headers, string.h, stdlib.h.
2081 * data.c, doprnt.c, floatfns.c, print.c:
2082 Include float.h unconditionally.
2083 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2084 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2085 * regex.c: Likewise for stddef.h, string.h.
2086 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2087 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2088 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2089 (STDC_HEADERS): Remove obsolete defines.
2090 * sysdep.c: Include limits.h unconditionally.
2091
9cfdb3ec
PE
2092 Assume support for memcmp, memcpy, memmove, memset.
2093 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2094 * regex.c (memcmp, memcpy):
2095 Remove; we assume C89 now.
2096
2097 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2098 (__malloc_safe_bcopy): Remove; no longer needed.
2099
cf950e6b 2100 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2101 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2102 well either way, and we prefer signed to unsigned.
2103
dbf38e02
LMI
21042011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2105
2106 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2107 closes the connection while we're reading (bug#9182).
2108
d6f0886c 21092011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2110
d6f0886c
JD
2111 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2112 are specified (Bug#9168).
24e0f6b1 2113
2eb1f9e6
PE
21142011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2117 Found by GCC static checking and --with-wide-int on a 32-bit host.
2118
22381272 21192011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2120
2121 * xdisp.c (compute_display_string_pos): Fix logic of caching
2122 previous display string position. Initialize cached_prev_pos to
2123 -1. Fixes slow-down at the beginning of a buffer.
2124
f25e39b4
EZ
21252011-07-24 Eli Zaretskii <eliz@gnu.org>
2126
2127 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2128 for attrs[LFACE_FONTSET_INDEX].
2129
04c4b52e
PE
21302011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 * xml.c (parse_region): Remove unused local
2133 that was recently introduced.
2134
c1734fbd
EZ
21352011-07-23 Eli Zaretskii <eliz@gnu.org>
2136
be18c5a5
EZ
2137 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2138 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2139
c1734fbd
EZ
2140 * xdisp.c (move_it_in_display_line_to): Record the best matching
2141 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2142 exit if none of the characters scanned was an exact match.
2143 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2144 when exact match is impossible due to invisible text, and the
2145 lines are truncated.
2146
a258d627
JD
21472011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2148
2149 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2150 for OSX >= 10.7.
2151
b6d5a689
EZ
21522011-07-22 Eli Zaretskii <eliz@gnu.org>
2153
0f74f785
EZ
2154 Fix a significant slow-down of cursor motion with C-n, C-p,
2155 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2156 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2157 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2158 (next_element_from_buffer): Call compute_stop_pos_backwards to
2159 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2160 base_level_stop.
2161 (reseat): Don't look for prev_stop, as that could mean a very long
2162 run.
2163 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2164 <cached_disp_overlay_modiff>: Cache for last found display string
2165 position.
551918c1 2166 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2167 about the same buffer in the same area of character positions, and
2168 the buffer wasn't changed since the time the display string
2169 position was cached.
551918c1 2170
b2d0c91a
EZ
21712011-07-22 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2174 is an integer, which is important for empty lines. (Bug#9149)
2175
043604ee
CY
21762011-07-22 Chong Yidong <cyd@stupidchicken.com>
2177
2178 * frame.c (Fmodify_frame_parameters): In tty case, update the
2179 default face if necessary (Bug#4238).
2180
da4adb04
CY
21812011-07-21 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * editfns.c (Fstring_to_char): No need to explain what a character
2184 is in the docstring (Bug#6576).
2185
9abd0532
LMI
21862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2187
2188 * xml.c (parse_region): Make sure we always return a tree.
2189
36881d16
HK
21902011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2191
2192 * xml.c (parse_region): If a document contains only comments,
2193 return that, too.
2194
1e98674d
LMI
21952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2196
2197 * xml.c (make_dom): Return comments, too.
2198
590bd467
PE
21992011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 Port to OpenBSD.
2202 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2203 and the surrounding thread.
2204 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2205 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2206 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2207 timer goes off.
2208 * s/openbsd.h (BROKEN_SIGIO): Define.
2209 * unexelf.c (unexec) [__OpenBSD__]:
2210 Don't update the .mdebug section of the Alpha COFF symbol table.
2211
f41628b2
LMI
22122011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2213
2214 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2215 (bug#8460).
2216
b59b67c5
PE
22172011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2218
15e3a074
PE
2219 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2220 This fixes some race conditions on the permissions of any newly
2221 created file.
2222
41bed37d
PE
2223 * alloc.c (valid_pointer_p): Use pipe, not open.
2224 This fixes some permissions issues when debugging.
2225
b59b67c5
PE
2226 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2227 If fchown fails to set both uid and gid, try to set just gid,
2228 as that is sometimes allowed. Adjust the file's mode to eliminate
2229 setuid or setgid bits that are inappropriate if fchown fails.
2230
925a6be7
SM
22312011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2232
2233 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2234 to compare Lisp_Objects.
2235 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2236 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2237 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2238
52968808
AS
22392011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2240
0a6a104b
AS
2241 * lread.c (read_integer): Unread even EOF character.
2242 (read1): Likewise. Properly record start position of symbol.
2243
52968808
AS
2244 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2245 symbol character follows.
2246
9e381cdd
PE
22472011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2250 This works around a problem with the previous change to Fcopy_file.
2251 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2252 and without this change, GCC might complain about discarding
2253 fchown's return value.
2254
b5641435
JB
22552011-07-16 Juanma Barranquero <lekktu@gmail.com>
2256
2257 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2258
a8031457
PE
22592011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2262
dd889327
LMI
22632011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2264
750c33f7
LMI
2265 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2266 it's used from the C level.
2267
dd889327
LMI
2268 * process.c: Use the same condition for POLL_FOR_INPUT in both
2269 keyboard.c and process.c (bug#1858).
2270
87e86684
LM
22712011-07-09 Lawrence Mitchell <wence@gmx.li>
2272
2273 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2274 (Fgnutls_boot): Use it.
2275
64348f40
AS
22762011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2277
2278 * doc.c (Fsubstitute_command_keys): Revert last change.
2279
1d698799
LMI
22802011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2281
f863868c
LMI
2282 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2283 quotes the next character, and doesn't affect other longer
2284 sequences (bug#8935).
2285
1d698799
LMI
2286 * lread.c (syms_of_lread): Clarify that is isn't only
2287 `eval-buffer' and `eval-defun' that's affected by
2288 `lexical-binding' (bug#8460).
2289
aa4b6df6
EZ
22902011-07-15 Eli Zaretskii <eliz@gnu.org>
2291
2292 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2293 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2294
5d856da6
PE
22952011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2296
ad6042bb
PE
2297 Fix minor problems found by static checking.
2298 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2299 (elsz): Now a signed constant, not a size_t var. We prefer signed
2300 types to unsigned, to avoid integer comparison confusion. Without
2301 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2302 "cannot optimize loop, the loop counter may overflow", a symptom
2303 of the confusion.
f00bbb22 2304 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2305 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2306
6468f31c
LMI
23072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2308
49080b10
LMI
2309 * search.c (Fre_search_backward): Mention `case-fold-search' in
2310 all the re_search_* functions (bug#8138).
2311
6468f31c
LMI
2312 * keyboard.c (Fopen_dribble_file): Document when the file is
2313 closed (bug#8056).
2314
c965adc5
EZ
23152011-07-14 Eli Zaretskii <eliz@gnu.org>
2316
df9733bf
EZ
2317 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2318 bidi_cache_idx.
2319
0bb23927
EZ
2320 Support bidi reordering of display and overlay strings.
2321 * xdisp.c (compute_display_string_pos)
2322 (compute_display_string_end): Accept additional argument STRING.
2323 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2324 (reseat_to_string): Initialize bidi_it->string.s and
2325 bidi_it->string.schars.
2326 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2327 NULL (avoids a crash in bidi_paragraph_init).
2328 Initialize itb.string.lstring.
0bb23927
EZ
2329 (init_iterator): Call bidi_init_it only of a valid
2330 buffer position was specified. Initialize paragraph_embedding to
2331 L2R.
2332 (reseat_to_string): Initialize the bidi iterator.
2333 (display_string): If we need to ignore text properties of
2334 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2335 original value of -1 will not work with bidi.)
2336 (compute_display_string_pos): First arg is now struct
2337 `text_pos *'; all callers changed. Support display properties on
2338 Lisp strings.
2339 (compute_display_string_end): Support display properties on Lisp
2340 strings.
2341 (init_iterator, reseat_1, reseat_to_string): Initialize the
2342 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2343 when iterating on a string not from display properties).
640c8776
SM
2344 (compute_display_string_pos, compute_display_string_end):
2345 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2346 arrow keys.
2347 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2348 base_level_stop; instead, set base_level_stop to BEGV.
2349 Fixes crashes in vertical-motion.
0bb23927
EZ
2350 (next_element_from_buffer): Improve commentary for when
2351 the iterator is before prev_stop.
2352 (init_iterator): Initialize bidi_p from the default value of
2353 bidi-display-reordering, not from buffer-local value. Use the
2354 buffer-local value only if initializing for buffer iteration.
2355 (handle_invisible_prop): Support invisible properties on strings
2356 that are being bidi-reordered.
2357 (set_iterator_to_next): Support bidi reordering of C strings and
2358 Lisp strings.
2359 (next_element_from_string): Support bidi reordering of Lisp
2360 strings.
2361 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2362 (display_string): Support display of R2L glyph rows.
2363 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2364 (init_iterator): Don't initialize it->bidi_p for strings
2365 here.
2366 (reseat_to_string): Initialize it->bidi_p for strings here.
2367 (next_element_from_string, next_element_from_c_string)
2368 (next_element_from_buffer): Add xassert's for correspondence
2369 between IT's object being iterated and it->bidi_it.string
2370 structure.
2371 (face_before_or_after_it_pos): Support bidi iteration.
2372 (next_element_from_c_string): Handle the case of the first string
2373 character that is not the first one in the visual order.
2374 (get_visually_first_element): New function, refactored from common
2375 parts of next_element_from_buffer, next_element_from_string, and
2376 next_element_from_c_string.
2377 (tool_bar_lines_needed, redisplay_tool_bar)
2378 (display_menu_bar): Force left-to-right direction. Add a FIXME
2379 comment for making that be controlled by a user option.
2380 (push_it, pop_it): Save and restore the state of the
2381 bidi iterator. Save and restore the bidi_p flag.
2382 (pop_it): Iterate out of display property for string iteration as
2383 well.
2384 (iterate_out_of_display_property): Support iteration over strings.
2385 (handle_single_display_spec): Set up it->bidi_it for iteration
2386 over a display string, and call bidi_init_it.
2387 (handle_single_display_spec, next_overlay_string)
2388 (get_overlay_strings_1, push_display_prop): Set up the bidi
2389 iterator for displaying display or overlay strings.
2390 (forward_to_next_line_start): Don't use the shortcut if
2391 bidi-iterating.
2392 (back_to_previous_visible_line_start): If handle_display_prop
2393 pushed the iterator stack, restore the internal state of the bidi
2394 iterator by calling bidi_pop_it same number of times.
2395 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2396 and we are bidi-iterating, don't decrement the iterator position;
2397 instead, set the first_elt flag in the bidi iterator, to produce
2398 the same effect.
2399 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2400 (push_display_prop): xassert that we are iterating a buffer.
2401 (push_it, pop_it): Save and restore paragraph_embedding member.
2402 (handle_single_display_spec, next_overlay_string)
2403 (get_overlay_strings_1, reseat_1, reseat_to_string)
2404 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2405 correctly. Don't assume unibyte strings are not bidi-reordered.
2406 (compute_display_string_pos)
2407 (compute_display_string_end): Fix handling the case of C string.
2408 (push_it, pop_it): Save and restore from_disp_prop_p.
2409 (handle_single_display_spec, push_display_prop): Set the
2410 from_disp_prop_p flag.
2411 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2412 (pop_it): Call iterate_out_of_display_property only if we are
2413 popping after iteration over a string that came from a display
2414 property. Fix a typo in popping stretch info. Add an assertion
2415 for verifying that the iterator position is in sync with the bidi
2416 iterator.
2417 (handle_single_display_spec, get_overlay_strings_1)
2418 (push_display_prop): Fix initialization of paragraph direction for
2419 string when that of the parent object is not yet determined.
2420 (reseat_1): Call bidi_init_it to resync the bidi
2421 iterator with IT's position. (Bug#7616)
2422 (find_row_edges): If ROW->start.pos gives position
2423 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2424 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2425 Reset the from_disp_prop_p flag.
2426 (SAVE_IT, RESTORE_IT): New macros.
2427 (pos_visible_p, face_before_or_after_it_pos)
2428 (back_to_previous_visible_line_start)
2429 (move_it_in_display_line_to, move_it_in_display_line)
2430 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2431 (try_scrolling, redisplay_window, display_line): Use them when
2432 saving a temporary copy of the iterator and restoring it back.
2433 (back_to_previous_visible_line_start, reseat_1)
2434 (init_iterator): Empty the bidi cache "stack".
2435 (move_it_in_display_line_to): If iterator ended up at
2436 EOL, but we never saw any buffer positions smaller than
2437 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2438 motion in bidi-reordered lines.
2439 (move_it_in_display_line_to): Record prev_method and prev_pos
2440 immediately before the call to set_iterator_to_next. Fixes cursor
2441 motion in bidi-reordered lines with stretch glyphs and strings
2442 displayed in margins. (Bug#8133) (Bug#8867)
2443 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2444 TO_CHARPOS.
640c8776
SM
2445 (pos_visible_p): Support positions in bidi-reordered lines.
2446 Save and restore bidi cache.
0bb23927
EZ
2447
2448 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2449 (bidi_paragraph_info): Delete unused struct.
2450 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2451 (bidi_cache_start): New variable.
2452 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2453 to zero.
2454 (bidi_cache_fetch_state, bidi_cache_search)
2455 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2456 (bidi_cache_find, bidi_peek_at_next_level)
2457 (bidi_level_of_next_char, bidi_find_other_level_edge)
2458 (bidi_move_to_visually_next): Compare cache index with
2459 bidi_cache_start rather than with zero.
2460 (bidi_fetch_char): Accept new argument STRING; all callers
2461 changed. Support iteration over a string. Support strings with
2462 display properties. Support unibyte strings. Fix the type of
2463 `len' according to what STRING_CHAR_AND_LENGTH expects.
2464 (bidi_paragraph_init, bidi_resolve_explicit_1)
2465 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2466 (bidi_level_of_next_char, bidi_move_to_visually_next):
2467 Support iteration over a string.
0bb23927
EZ
2468 (bidi_set_sor_type, bidi_resolve_explicit_1)
2469 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2470 can now be zero (for strings); special values 0 and -1 were
2471 changed to -1 and -2, respectively.
2472 (bidi_char_at_pos): New function.
2473 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2474 Call it instead of FETCH_MULTIBYTE_CHAR.
2475 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2476 initialized to valid values.
2477 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2478 values.
2479 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2480 the test for valid cached positions. Fix the logic for looking up
2481 the sentinel state in the cache. GCPRO the Lisp string we are
2482 iterating.
2483 (bidi_push_it, bidi_pop_it): New functions.
2484 (bidi_initialize): Initialize the bidi cache start stack pointer.
2485 (bidi_cache_ensure_space): New function, refactored from part of
2486 bidi_cache_iterator_state. Don't assume the required size is just
2487 one BIDI_CACHE_CHUNK away.
2488 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2489 (bidi_count_bytes, bidi_char_at_pos): New functions.
2490 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2491 always valid if bidi_cache_idx is valid.
2492 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2493 is valid if it's going to be used.
2494 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2495 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2496 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2497 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2498 (bidi_find_other_level_edge, bidi_cache_start_stack):
2499 All variables related to cache indices are now EMACS_INT.
c965adc5 2500
0bb23927
EZ
2501 * dispextern.h (struct bidi_string_data): New structure.
2502 (struct bidi_it): New member `string'. Make flag members be 1-bit
2503 fields, and put them last in the struct.
640c8776
SM
2504 (compute_display_string_pos, compute_display_string_end):
2505 Update prototypes.
0bb23927
EZ
2506 (bidi_push_it, bidi_pop_it): Add prototypes.
2507 (struct iterator_stack_entry): New members bidi_p,
2508 paragraph_embedding, and from_disp_prop_p.
2509 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2510 (bidi_shelve_cache, bidi_unshelve_cache):
2511 Declare prototypes.
0bb23927
EZ
2512
2513 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2514 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2515 and vector-like objects.
2516
2517 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2518 cache around display iteration.
2519
2520 * window.c (Fwindow_end, window_scroll_pixel_based)
2521 (displayed_window_lines, Frecenter): Save and restore the bidi
2522 cache around display iteration.
2523
3bbd2265
LMI
25242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2525
2526 * editfns.c (Fdelete_region): Clarify the use of the named
2527 parameters (bug#6788).
2528
adc47434
MR
25292011-07-14 Martin Rudalics <rudalics@gmx.at>
2530
2531 * indent.c (Fvertical_motion): Set and restore w->pointm when
2532 saving and restoring the window's buffer (Bug#9006).
2533
837c31f8
LMI
25342011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2535
2536 * editfns.c (Fstring_to_char): Clarify just what is returned
2537 (bug#6576). Text by Eli Zaretskii.
2538
ac389d0c
JB
25392011-07-13 Juanma Barranquero <lekktu@gmail.com>
2540
2541 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2542
0be0ce47
EZ
25432011-07-13 Eli Zaretskii <eliz@gnu.org>
2544
2545 * buffer.c (mmap_find): Fix a typo.
2546
cd18e7e3
JB
25472011-07-13 Johan Bockgård <bojohan@gnu.org>
2548
2549 Fix execution of x selection hooks.
2550 * xselect.c (Qx_lost_selection_functions)
2551 (Qx_sent_selection_functions): New vars.
2552 (syms_of_xselect): DEFSYM them.
2553 (x_handle_selection_request): Pass Qx_sent_selection_functions
2554 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2555 (x_handle_selection_clear,x_clear_frame_selections):
2556 Pass Qx_lost_selection_functions rather than
2557 Vx_lost_selection_functions to Frun_hook_with_args.
2558
47ea7f44
PE
25592011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2560
ac389d0c 2561 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2562 The old code sometimes used this field without initializing it.
2563
47ea7f44
PE
2564 * alloc.c (gc_sweep): Don't read past end of array.
2565 In theory, the old code could also have corrupted Emacs internals,
2566 though it'd be very unlikely.
2567
bc985c87
AS
25682011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2569
2570 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2571 argument. (Bug#4026)
bc985c87 2572
0cf34688
LMI
25732011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2574
b3dadd76
LMI
2575 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2576 key" (bug#4257).
2577
0cf34688
LMI
2578 * window.c (Fset_window_start): Doc fix (bug#4199).
2579 (Fset_window_hscroll): Ditto.
2580
270768cd
PE
25812011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2582
077e3dda 2583 Fix minor new problems caught by GCC 4.6.1.
270768cd 2584 * term.c (init_tty): Remove unused local.
490011a6 2585 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2586 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2587 not used otherwise.
270768cd 2588
b1f58454
CY
25892011-07-12 Chong Yidong <cyd@stupidchicken.com>
2590
2591 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2592
22b9578d
LMI
25932011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2594
6e70ab07
LMI
2595 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2596 are the mini-buffer and the echo area (bug#3320).
2597
22b9578d
LMI
2598 * term.c (init_tty): Remove support for supdup, c10 and perq
2599 terminals, which are no longer supported (bug#1482).
2600
8974cc9f
JB
26012011-07-10 Johan Bockgård <bojohan@gnu.org>
2602
2603 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2604
a560d974
JD
26052011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2606
2607 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2608 for non-popups (Bug#3642).
2609
1dae0f0a
AS
26102011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2611
268c2c36 2612 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2613 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2614 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2615 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2616 * data.c (fmod): Likewise.
2617 * dispnew.c (swap_glyphs_in_rows): Likewise.
2618 * emacs.c (memory_warning_signal): Likewise.
2619 * floatfns.c (float_error): Likewise.
2620 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2621 (otf_open, font_otf_capability, generate_otf_features)
2622 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2623 Likewise.
2624 * image.c (pbm_read_file): Likewise.
2625 * indent.c (string_display_width): Likewise.
2626 * intervals.c (check_for_interval, search_for_interval)
2627 (inc_interval_count, count_intervals, root_interval)
2628 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2629 * lread.c (defalias): Likewise.
268c2c36 2630 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2631 * regex.c (set_image_of_range_1, set_image_of_range)
2632 (regex_grow_registers): Likewise.
2633 * sysdep.c (strerror): Likewise.
2634 * termcap.c (valid_filename_p, tprint, main): Likewise.
2635 * tparam.c (main): Likewise.
2636 * unexhp9k800.c (run_time_remap, save_data_space)
2637 (update_file_ptrs, read_header, write_header, calculate_checksum)
2638 (copy_file, copy_rest, display_header): Likewise.
2639 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2640 Likewise.
2641 * xdisp.c (check_it): Likewise.
2642 * xfaces.c (register_color, unregister_color, unregister_colors):
2643 Likewise.
2644 * xfns.c (print_fontset_result): Likewise.
2645 * xrdb.c (member, fatal, main): Likewise.
2646
99033785
PE
26472011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 Fix minor problems found by static checking (Bug#9031).
2650 * chartab.c (char_table_set_range, map_sub_char_table):
2651 Remove unused locals.
2652 (uniprop_table): Now static.
2653 * composite.c (_work_char): Remove unused static var.
2654
9cb2ac56
JB
26552011-07-09 Juanma Barranquero <lekktu@gmail.com>
2656
2657 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2658
f25661f0
JD
26592011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2660
2661 * gtkutil.c (qttip_cb): Remove code without function.
2662
8278c4fe
EZ
26632011-07-09 Eli Zaretskii <eliz@gnu.org>
2664
2665 * w32.c (pthread_sigmask): New stub.
2666
1692ae2d 26672011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2668
8a6ebd58 2669 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2670 sigprocmask is portable only for single-threaded applications, and
2671 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2672 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2673 (LIBES): Use it.
2674 * callproc.c (Fcall_process):
2675 * process.c (create_process):
2676 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2677 Use pthread_sigmask, not sigprocmask.
123403e4 2678
1b854618
JD
26792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2680
2681 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2682 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2683 wrong (Bug#8591).
2684
3fe4b549
JD
26852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2686
0ce7e563
JD
2687 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2688 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2689 (xg_hide_tooltip): Fix comment.
2690
3fe4b549
JD
2691 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2692 in registerServicesMenuSendTypes.
2693 (validRequestorForSendType): Don't check ns_return_types.
2694
2695 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2696 ns_return_type.
2697
5df75e47
JR
26982011-07-08 Jason Rumney <jasonr@gnu.org>
2699
2700 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2701 frame struct members of non-existent frames (Bug#6284).
2702
699c10bd
JD
27032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2704
4393663b
JD
2705 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2706 variable firstTime not needed on OSX >= 10.6.
2707 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2708 >= 10.5. Use setKnobProportion, setDoubleValue.
2709
2710 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2711 (MAC_OS_X_VERSION_10_5): Define if not defined.
2712 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2713 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2714 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2715
2716 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2717 cString and lossyCString on OSX >= 10.4
2718
2719 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2720 sizeToFit on OSX >= 10.2.
2721
2722 * nsimage.m (allocInitFromFile): Don't use deprecated method
2723 bestRepresentationForDevice on OSX >= 10.6.
2724
2725 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2726 to avoid warning.
2727
2728 * emacs.c: Declare unexec_init_emacs_zone.
2729
a63e0781
JD
2730 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2731
699c10bd
JD
2732 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2733
2734 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2735 on svcsMenu (Bug#8842).
2736
2737 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2738 ns_return_types.
2739 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2740
2741 * nsterm.m (QUTF8_STRING): Declare.
2742 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2743 (validRequestorForSendType): Return type is (id).
2744 Change indexOfObjectIdenticalTo to indexOfObject.
2745 Check if we have local selection before returning self (Bug#8842).
2746 (writeSelectionToPasteboard): Put local selection into paste board
2747 if we have a local selection (Bug#8842).
2748 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2749
2750 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2751 (ns_get_local_selection): Declare.
2752
54e10184
LMI
27532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2754
9888ff71
LMI
2755 * keymap.c (describe_map_tree): Don't insert a double newline at
2756 the end of the buffer (bug#1169) and return whether we inserted
2757 something.
2758
54e10184
LMI
2759 * callint.c (Fcall_interactively): Change "reading args" to
2760 "providing args" to try to clarify what it does (bug#1010).
2761
15fa4783
KH
27622011-07-07 Kenichi Handa <handa@m17n.org>
2763
2764 * composite.c (composition_compute_stop_pos): Ignore a static
2765 composition starting before CHARPOS (Bug#8915).
2766
2767 * xdisp.c (handle_composition_prop): Likewise.
2768
a8815b00
EZ
27692011-07-07 Eli Zaretskii <eliz@gnu.org>
2770
2771 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2772 (Bug#9015)
2773
ef7b981d 27742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2775
2776 * character.h (unicode_category_t): New enum type.
2777
2778 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2779 (Qchar_code_property_table): New variable.
2780 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2781 (UNIPROP_COMPRESSED_FORM_P): New macros.
2782 (char_table_ascii): Uncompress the compressed values.
2783 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2784 Uncompress the compressed values.
ac389d0c 2785 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2786 (char_table_ref_and_range): Uncompress the compressed values.
2787 (sub_char_table_set): New arg is_uniprop. Callers changed.
2788 Uncompress the compressed values.
2789 (sub_char_table_set_range): Args changed. Callers changed.
2790 (char_table_set_range): Adjuted for the above change.
2791 (map_sub_char_table): Delete args default_val and parent. Add arg
2792 top. Give decoded values to a Lisp function.
640c8776 2793 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2794 values to a Lisp function. Gcpro more variables.
2795 (uniprop_table_uncompress)
2796 (uniprop_decode_value_run_length): New functions.
2797 (uniprop_decoder, uniprop_decoder_count): New variables.
2798 (uniprop_get_decoder, uniprop_encode_value_character)
2799 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2800 New functions.
2801 (uniprop_encoder, uniprop_encoder_count): New variables.
2802 (uniprop_get_encoder, uniprop_table)
2803 (Funicode_property_table_internal, Fget_unicode_property_internal)
2804 (Fput_unicode_property_internal): New functions.
2805 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2806 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2807 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2808 char-code-property-alist.
2809
640c8776 2810 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2811 Vunicode_category_table.
2812
640c8776 2813 * font.c (font_range): Adjust for the change of
c805dec0
KH
2814 Vunicode_category_table.
2815
76b397fb
DN
28162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2817
2818 * m/iris4d.h: Remove file, move contents ...
2819 * s/irix6-5.h: ... here.
2820
22b4128e
PE
28212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2824 * alloc.c (mark_buffer):
2825 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2826 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2827 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2828 This isn't true in general, and it's particularly not true
2829 if Emacs is configured with --with-wide-int.
2830 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2831 New macros, used in the buffer.c change.
2832
869795d6
JD
28332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2834
2835 * xsettings.c: Use both GConf and GSettings if both are available.
2836 (store_config_changed_event): Add comment.
2837 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2838 (store_tool_bar_style_changed): New functions.
5e617bc2 2839 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2840 (struct xsettings): Move font inside HAVE_XFT.
2841 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2842 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2843 Move inside HAVE_XFT.
640c8776 2844 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2845 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2846 also.
2847 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2848 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2849 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2850 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2851 (parse_settings): Move check for font inside HAVE_XFT.
2852 (read_settings, apply_xft_settings): Add comment.
2853 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2854 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2855 call store_font_name_changed.
2856 (xft_settings_event): Add comment.
2857 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2858 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2859 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2860 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2861 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2862 (xsettings_get_system_font, xsettings_get_system_normal_font):
2863 Add comment.
869795d6 2864
d8ed26bd
PE
28652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2866
2867 Random fixes. E.g., (random) never returned negative values.
2868 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2869 subseconds part to the entropy, as that's a bit more random.
2870 Prefer signed to unsigned, since the signedness doesn't matter and
2871 in general we prefer signed. When given a limit, use a
2872 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2873 latter isn't right if USE_2_TAGS_FOR_INTS.
2874 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2875 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2876
cabf1cac
SM
28772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2878
2879 * textprop.c (text_property_stickiness):
2880 Obey Vtext_property_default_nonsticky.
2881 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2882 * w32fns.c (syms_of_w32fns):
2883 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2884
6e9b2be9
PE
28852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2888 This is more efficient than Ffile_directory_p and avoids a minor race.
2889
90186c68
LMI
28902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2891
7c301272
LMI
2892 * buffer.c (Foverlay_put): Say what the return value is
2893 (bug#7835).
2894
c4f2d8d4
LMI
2895 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2896 is a directory before asking whether to use the file name
2897 (bug#7564).
ad637907
LMI
2898 (barf_or_query_if_file_exists): Make the "File is a directory"
2899 error be more correct.
c4f2d8d4 2900
90186c68
LMI
2901 * fns.c (Frequire): Remove the mention of the .gz files, since
2902 that's installation-specific, but keep the mention of
2903 `get-load-suffixes'.
2904
da64016e
PE
29052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2906
2907 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2908 Report string overflow if the output is too long.
2909
7d47b580
JB
29102011-07-04 Juanma Barranquero <lekktu@gmail.com>
2911
a555cb87
JB
2912 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2913 (syms_of_gnutls): Remove duplicate DEFSYM for
2914 Qgnutls_bootprop_verify_hostname_error, an error for
2915 Qgnutls_bootprop_verify_error (which is no longer used).
2916
7d47b580
JB
2917 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2918 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2919 Also (re)move comments that are misplaced or no longer relevant.
2920
1e49bfab
LMI
29212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2922
2923 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2924
1485f4c0
CY
29252011-07-03 Chong Yidong <cyd@stupidchicken.com>
2926
2927 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2928 and background color parameters if they have been changed.
2929
a9ab721e
LMI
29302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2931
2932 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2933
cf7cff57
PE
29342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2935
2e13213d
PE
2936 * xsettings.c (SYSTEM_FONT): Define only when used.
2937 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2938
cf7cff57
PE
2939 * keymap.c (access_keymap_1): Now static.
2940
7a8e04f7
CY
29412011-07-02 Chong Yidong <cyd@stupidchicken.com>
2942
2943 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2944 leave any prefix arg for the up event (Bug#1586).
2945
61352f62
LMI
29462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2947
69bb1ef7
LMI
2948 * lread.c (syms_of_lread): Mention single symbols defined by
2949 `defvar' or `defconst' (bug#7154).
2950
61352f62 2951 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2952 (Frequire): Mention get-load-suffixes.
61352f62 2953
28545e04
MR
29542011-07-02 Martin Rudalics <rudalics@gmx.at>
2955
2956 * window.h (window): Remove clone_number slot.
2957 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2958 Remove.
2959 (make_parent_window, make_window, saved_window)
2960 (Fset_window_configuration, save_window_save): Don't deal with
2961 clone numbers.
2962 * buffer.c (Qclone_number): Remove declaration.
2963 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2964
3349e122
SM
29652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2966
2967 Add multiple inheritance to keymaps.
2968 * keymap.c (Fmake_composed_keymap): New function.
2969 (Fset_keymap_parent): Simplify.
2970 (fix_submap_inheritance): Remove.
2971 (access_keymap_1): New function extracted from access_keymap to handle
2972 embedded parents and handle lists of maps.
2973 (access_keymap): Use it.
2974 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2975 (Fcopy_keymap): Handle embedded parents.
2976 (Fcommand_remapping, define_as_prefix): Simplify.
2977 (Fkey_binding): Simplify.
2978 (syms_of_keymap): Move minibuffer-local-completion-map,
2979 minibuffer-local-filename-completion-map,
2980 minibuffer-local-must-match-map, and
2981 minibuffer-local-filename-must-match-map to Elisp.
2982 (syms_of_keymap): Defsubr make-composed-keymap.
2983 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2984 (parse_menu_item): Trivial simplification.
2985
3279eb87
GM
29862011-07-01 Glenn Morris <rgm@gnu.org>
2987
2988 * Makefile.in (SETTINGS_LIBS): Fix typo.
2989
4550efdf
KI
29902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2991
2992 * coding.c (Fencode_coding_string): Record the last coding system
2993 used, as the function doc string says (bug#8738).
2994
0949d2b6
JD
29952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2996
2997 * xsettings.c (store_monospaced_changed): Take new font as arg and
2998 check for change against current_mono_font.
2999 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3000 (emacs_settings_constructor, emacs_settings_get_property)
3001 (emacs_settings_set_property, emacs_settings_class_init)
3002 (emacs_settings_init, gsettings_obj): Remove.
3003 (something_changedCB): New function for HAVE_GSETTINGS.
3004 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3005 with value as argument.
3006 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3007 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3008 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3009 "changed".
3010
3011 * xgselect.c: Add defined (HAVE_GSETTINGS).
3012 (xgselect_initialize): Ditto.
3013
3014 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3015 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3016 xg_select.
3017
bbc6b304
PE
30182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * eval.c (struct backtrace): Simplify and port the data structure.
3021 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3022 signed bit field, as this assumption is not portable and it makes
3023 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3024 "char debug_on_exit : 1" as this is not portable either; instead,
3025 use the portable "unsigned int debug_on_exit : 1". Remove unused
3026 member evalargs. Remove obsolete comments about cc bombing out.
3027
9851bfc5
JD
30282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3029
51bb811f 3030 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3031 Let HAVE_GSETTINGS override HAVE_GCONF.
3032 (store_monospaced_changed): New function.
3033 (EMACS_SETTINGS): A new type derived from GObject to handle
3034 GSettings notifications.
3035 (emacs_settings_constructor, emacs_settings_get_property)
3036 (emacs_settings_set_property, emacs_settings_class_init):
3037 New functions.
3038 (gsettings_client, gsettings_obj): New variables.
3039 (GSETTINGS_SCHEMA): New define.
3040 (something_changedCB): Call store_monospaced_changed.
3041 (init_gsettings): New function.
3042 (xsettings_initialize): Call init_gsettings.
3043 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3044 to NULL.
3045
640c8776 3046 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3047 GCONF_CFLAGS/LIBS.
3048
5386012d
MR
30492011-06-29 Martin Rudalics <rudalics@gmx.at>
3050
3051 * window.c (resize_root_window, grow_mini_window)
3052 (shrink_mini_window): Rename Qresize_root_window to
3053 Qwindow_resize_root_window and Qresize_root_window_vertically to
3054 Qwindow_resize_root_window_vertically.
3055
f13e0b08
PE
30562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3059
94515237
JB
30602011-06-27 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * makefile.w32-in: Redesign dependencies so they reflect more
3063 clearly which files are directly included by each source file,
3064 and not through other includes.
3065
e43b6e43
MR
30662011-06-27 Martin Rudalics <rudalics@gmx.at>
3067
3068 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3069 (sort_overlays, overlay_strings): When an overlay's clone number
3070 matches the window's clone number process the overlay even if
3071 the overlay's window property doesn't match the current window.
3072
d68443dc
MR
3073 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3074 (Fwindow_hchild): Rename to Fwindow_left_child.
3075 (Fwindow_next): Rename to Fwindow_next_sibling.
3076 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3077 (resize_window_check): Rename to window_resize_check.
3078 (resize_window_apply): Rename to window_resize_apply.
3079 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3080 (Fdelete_other_windows_internal, resize_frame_windows)
3081 (Fsplit_window_internal, Fdelete_window_internal)
3082 (grow_mini_window, shrink_mini_window)
3083 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3084
c7e73be5
JD
30852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3086
3087 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3088 (emacs_fixed_set_min_size): Remove.
3089 (emacs_fixed_new): Take frame as argument.
3090
3091 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3092 (_EmacsFixedPrivate): Remove minwidth/height.
3093 Add struct frame *f.
3094 (emacs_fixed_init): Initialize priv->f.
3095 (get_parent_class, emacs_fixed_set_min_size): Remove.
3096 (emacs_fixed_new): Set priv->f to argument.
3097 (emacs_fixed_get_preferred_width)
3098 (emacs_fixed_get_preferred_height): Use min_width/height from
3099 frames size_hint to set minimum and natural (Bug#8919).
3100 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3101 and use min_width/height from frames size_hint to set
3102 min_width/height (Bug#8919).
3103
3104 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3105 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3106 Fix indentation.
c7e73be5 3107
cf99dcf8
EZ
31082011-06-26 Eli Zaretskii <eliz@gnu.org>
3109
3110 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3111 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3112 called at ZV.
3113
029529ac
CY
31142011-06-26 Chong Yidong <cyd@stupidchicken.com>
3115
3116 * process.c (wait_reading_process_output): Bypass select if
3117 waiting for a cell while ignoring keyboard input, and input is
3118 pending. Suggested by Jan Djärv (Bug#8869).
3119
7a7ef429
PE
31202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 Use gnulib's dup2 module instead of rolling our own.
3123 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3124
11fdef7d 31252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3126
3127 * dispnew.c (scrolling_window): Before scrolling, turn off a
3128 mouse-highlight in the window being scrolled.
3129
cd3520a4
JB
31302011-06-24 Juanma Barranquero <lekktu@gmail.com>
3131
3132 Move DEFSYM to lisp.h and use everywhere.
3133
3134 * character.h (DEFSYM): Move declaration...
3135 * lisp.h (DEFSYM): ...here.
3136
3137 * gnutls.c:
3138 * minibuf.c:
3139 * w32menu.c:
3140 * w32proc.c:
3141 * w32select.c: Don't include character.h.
3142
3143 * alloc.c (syms_of_alloc):
3144 * buffer.c (syms_of_buffer):
3145 * bytecode.c (syms_of_bytecode):
3146 * callint.c (syms_of_callint):
3147 * casefiddle.c (syms_of_casefiddle):
3148 * casetab.c (init_casetab_once):
3149 * category.c (init_category_once, syms_of_category):
3150 * ccl.c (syms_of_ccl):
3151 * cmds.c (syms_of_cmds):
3152 * composite.c (syms_of_composite):
3153 * dbusbind.c (syms_of_dbusbind):
3154 * dired.c (syms_of_dired):
3155 * dispnew.c (syms_of_display):
3156 * doc.c (syms_of_doc):
3157 * editfns.c (syms_of_editfns):
3158 * emacs.c (syms_of_emacs):
3159 * eval.c (syms_of_eval):
3160 * fileio.c (syms_of_fileio):
3161 * fns.c (syms_of_fns):
3162 * frame.c (syms_of_frame):
3163 * fringe.c (syms_of_fringe):
3164 * insdel.c (syms_of_insdel):
3165 * keymap.c (syms_of_keymap):
3166 * lread.c (init_obarray, syms_of_lread):
3167 * macros.c (syms_of_macros):
3168 * msdos.c (syms_of_msdos):
3169 * print.c (syms_of_print):
3170 * process.c (syms_of_process):
3171 * search.c (syms_of_search):
3172 * sound.c (syms_of_sound):
3173 * syntax.c (init_syntax_once, syms_of_syntax):
3174 * terminal.c (syms_of_terminal):
3175 * textprop.c (syms_of_textprop):
3176 * undo.c (syms_of_undo):
3177 * w32.c (globals_of_w32):
3178 * window.c (syms_of_window):
3179 * xdisp.c (syms_of_xdisp):
3180 * xfaces.c (syms_of_xfaces):
3181 * xfns.c (syms_of_xfns):
3182 * xmenu.c (syms_of_xmenu):
3183 * xsettings.c (syms_of_xsettings):
3184 * xterm.c (syms_of_xterm): Use DEFSYM.
3185
4228cf16
TZ
31862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3187
cd3520a4 3188 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3189
7fcccf1e
PE
31902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3191
7efb4e0e
PE
3192 Integer and buffer overflow fixes (Bug#8873).
3193
ff5844ad
PE
3194 * print.c (printchar, strout): Check for string overflow.
3195 (PRINTPREPARE, printchar, strout):
3196 Don't set size unless allocation succeeds.
3197
90532f02
PE
3198 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3199 for sizes. Check for string overflow more accurately.
3200 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3201
6d84508d
PE
3202 * macros.c: Integer and buffer overflow fixes.
3203 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3204 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3205 Use ptrdiff_t, not int, for sizes.
3206 Don't increment bufsize until after realloc succeeds.
3207 Check for size-calculation overflow.
3208 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3209
437b2cb4
PE
3210 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3211
8b9ac8b4
PE
3212 * lread.c: Integer overflow fixes.
3213 (read_integer): Radix is now EMACS_INT, not int,
3214 to improve quality of diagnostics for out-of-range radices.
3215 Calculate buffer size correctly for out-of-range radices.
3216 (read1): Check for integer overflow in radices, and in
3217 read-circle numbers.
82cb60d3
PE
3218 (read_escape): Avoid int overflow.
3219 (Fload, openp, read_buffer_size, read1)
3220 (substitute_object_recurse, read_vector, read_list, map_obarray):
3221 Use ptrdiff_t, not int, for sizes.
3222 (read1): Use EMACS_INT, not int, for sizes.
20270765 3223 Check for size overflow.
8b9ac8b4 3224
7fcccf1e
PE
3225 * image.c (cache_image): Check for size arithmetic overflow.
3226
bfbbd7e7
PE
3227 * lread.c: Integer overflow issues.
3228 (saved_doc_string_size, saved_doc_string_length)
3229 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3230 Now ptrdiff_t, not int.
3231 (read1): Don't assume doc string length fits in int. Check for
3232 out-of-range doc string lengths.
3233 (read_list): Don't assume file position fits in int.
39019e54 3234 (read_escape): Check for hex character overflow.
bfbbd7e7 3235
4e323265
LL
32362011-06-22 Leo Liu <sdl.web@gmail.com>
3237
3238 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3239 Move to minibuffer.el.
3240
85fece3e
PE
32412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3242
20b84ce9 3243 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3244 The following patches are for when GLYPH_DEBUG && !XASSERT.
3245 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3246 * dispnew.c (flush_stdout):
3247 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3248 Mark as externally visible.
3249 * dispnew.c (check_window_matrix_pointers): Now static.
3250 * dispnew.c (window_to_frame_vpos):
3251 * xfns.c (unwind_create_frame):
3252 * xterm.c (x_check_font): Remove unused local.
3253 * scroll.c (CHECK_BOUNDS):
3254 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3255 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3256 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3257 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3258 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3259 Now static.
3260 (debug_method_add): Use va_list and vsprintf rather than relying
3261 on undefined behavior with wrong number of arguments.
3262 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3263 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3264 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3265 since we're not interested in debugging glyphs with old libraries.
3266 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3267 GCC 4.6.0's static checking.
3268
0766b489
PE
32692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3270
31fd4b32
PE
3271 Integer overflow and signedness fixes (Bug#8873).
3272 A few related buffer overrun fixes, too.
3273
b79e8648
PE
3274 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3275
0766b489
PE
3276 * dispextern.h (struct face.stipple):
3277 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3278 (x_bitmap_mask, x_allocate_bitmap_record)
3279 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3280 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3281 (x_create_bitmap_from_xpm_data):
3282 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3283 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3284 (.bitmaps_last):
3285 * xfaces.c (load_pixmap):
3286 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3287 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3288 (.bitmaps_last, struct x_output.icon_bitmap):
3289 Use ptrdiff_t, not int, for bitmap indexes.
3290 (x_allocate_bitmap_record): Check for size overflow.
3291 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3292
b081724f
PE
3293 Use ptrdiff_t, not int, for overlay counts.
3294 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3295 * editfns.c (overlays_around, get_pos_property):
3296 * textprop.c (get_char_property_and_overlay):
3297 * xdisp.c (next_overlay_change, note_mouse_highlight):
3298 * xfaces.c (face_at_buffer_position):
21514da7
PE
3299 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3300 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3301 (Fnext_overlay_change, Fprevious_overlay_change)
3302 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3303 Use ptrdiff_t, not int, for sizes.
21514da7 3304 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3305
3de73e5e
PE
3306 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3307
2606c57b
PE
3308 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3309 (x_session_initialize): Do not assume string length fits in int.
3310
aaafe47a
PE
3311 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3312 This is unlikely, but can occur if DPI is outlandish.
3313
2674ddc8 3314 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3315 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3316
28154962
PE
3317 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3318 * xrdb.c (magic_file_p, search_magic_path):
3319 Omit last arg SUFFIX; it was always 0. All callers changed.
3320 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3321
7de51af5
PE
3322 * xfont.c (xfont_match): Avoid need for strlen.
3323
25ed6cc3
PE
3324 * xfns.c: Don't assume strlen fits in int.
3325 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3326
4eab31dd
PE
3327 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3328 not unsigned long, as we prefer signed integers. All callers changed.
3329 Detect integer overflow in repeat count.
3330 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3331 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3332
171e2a58
PE
3333 * termcap.c: Don't assume sizes fit in int and never overflow.
3334 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3335 (gobble_line): Check for size-calculation overflow.
3336
ad39faca 3337 * minibuf.c (Fread_buffer):
6e5bb2dc 3338 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3339 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3340 Don't assume string length fits in int.
3341
52c61c22 3342 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3343 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3344
b5b8c9e5
PE
3345 * font.c: Don't assume string length fits in int.
3346 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3347 Use ptrdiff_t, not int.
ccd6111c
PE
3348 (font_intern_prop): Don't assume string length fits in int.
3349 Don't assume integer property fits in fixnum.
3350 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3351
882f0d81 3352 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3353 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3354 Reformulate so as not to need the command string.
3355 Invoke gzip -cd rather than gunzip, as it's more portable.
3356 (lock_info_type, lock_file_1, lock_file):
3357 Don't assume pid_t and time_t fit in unsigned long.
3358 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3359 (current_lock_owner): Prefer signed type for sizes.
3360 Use memcpy, not strncpy, where memcpy is what is really wanted.
3361 Don't assume (via atoi) that time_t and pid_t fit in int.
3362 Check for time_t and/or pid_t out of range, e.g., via a network share.
3363 Don't alloca where an auto var works fine.
3364
93f4cf88
PE
3365 * fileio.c: Fix some integer overflow issues.
3366 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3367 Don't assume string length fits in int.
3368 (directory_file_name): Don't assume string length fits in long.
3369 (make_temp_name): Don't assume pid fits in int, or that its print
3370 length is less than 20.
3371
f3e92b69
PE
3372 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3373
1bfdaf10
PE
3374 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3375
35016e9a
PE
3376 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3377
3d1e65a1
PE
3378 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3379 We prefer signed integers, even for size calculations.
3380
0b963a93
PE
3381 * emacs.c: Don't assume string length fits in 'int'.
3382 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3383 (main): Don't invoke strlen when not needed.
3384
573f4b54
PE
3385 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3386 (XD_DEBUG_MESSAGE): Don't waste a byte.
3387
989f33ba
PE
3388 * callproc.c (getenv_internal_1, getenv_internal)
3389 (Fgetenv_internal):
965d34eb
PE
3390 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3391
e4d29b33
PE
3392 * lread.c (invalid_syntax): Omit length argument.
3393 All uses changed. This doesn't fix a bug, but it simplifies the
3394 code away from its former Hollerith-constant appearance, and it's
3395 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3396 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3397
eb49b136
PE
3398 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3399 This didn't break anything, but it didn't help either.
3400 It's confusing to put a bogus integer in a place where the actual
3401 value does not matter.
9f62aeb1 3402 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3403 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3404
15375a22
PE
3405 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3406 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3407 implementation.
b61cc01c
PE
3408 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3409 We prefer signed types, and the value cannot exceed the EMACS_INT
3410 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3411 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3412 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3413 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3414
53b2623d
PE
3415 * indent.c (sane_tab_width): New function.
3416 (current_column, scan_for_column, Findent_to, position_indentation)
3417 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3418 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3419
51cab52b 3420 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3421
f2ed8a70
PE
3422 * lisp.h (lint_assume): New macro.
3423 * composite.c (composition_gstring_put_cache):
3424 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3425
abe80cc6
PE
3426 * editfns.c, insdel.c:
3427 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3428
b02c740e
PE
3429 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3430
ebc96716
PE
3431 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3432
b4e50fa0 3433 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3434 Use much-faster test for byte-length change.
311d5d7c 3435 Don't assume string byte-length fits in 'int'.
a4cf38e4 3436 Check that character arg fits in 'int'.
85461888 3437 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3438
c0c1ee9f
PE
3439 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3440
a498d7f4
PE
3441 * fns.c (concat): Catch string overflow earlier.
3442 Do not rely on integer wraparound.
3443
51cab52b
PE
3444 * dispextern.h (struct it.overlay_strings_charpos)
3445 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3446 * xdisp.c (forward_to_next_line_start)
3447 (back_to_previous_visible_line_start)
3448 (reseat_at_next_visible_line_start, next_element_from_buffer):
3449 Don't arbitrarily truncate the value of 'selective' to int.
3450
76031fad
PE
3451 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3452
5eb55db9
PE
3453 * composite.c: Don't truncate sizes to 'int'.
3454 (composition_gstring_p, composition_reseat_it)
3455 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3456 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3457 not EMACS_UINT, for indexes.
5eb55db9 3458
0703a717
PE
3459 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3460
d6202519
PE
3461 * buffer.c: Include <verify.h>.
3462 (struct sortvec.priority, struct sortstr.priority):
8961a454 3463 Now EMACS_INT, not int.
c20998a7 3464 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3465 (struct sortstr.size, record_overlay_string)
3466 (struct sortstrlist.size, struct sortlist.used):
3467 Don't truncate size to int.
3468 (record_overlay_string): Check for size-calculation overflow.
d6202519 3469 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3470
d5a19415
JM
34712011-06-22 Jim Meyering <meyering@redhat.com>
3472
029529ac 3473 Don't leak an XBM-image-sized buffer
d5a19415
JM
3474 * image.c (xbm_load): Free the image buffer after using it.
3475
a9041e6c
PE
34762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 Port to Sun C.
3479 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3480 that Sun C diagnosed.
3481 * fns.c (secure_hash): Fix pointer signedness issue.
3482 * intervals.c (static_offset_intervals): New function.
3483 (offset_intervals): Use it.
3484
7f3f739f
LL
34852011-06-21 Leo Liu <sdl.web@gmail.com>
3486
3487 * deps.mk (fns.o):
3488 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3489 sha512.h.
3490
3491 * fns.c (secure_hash): Rename from crypto_hash_function and change
3492 the first arg to accept symbols.
5b66d427 3493 (Fsecure_hash): New primitive.
7f3f739f
LL
3494 (syms_of_fns): New symbols.
3495
76147d94
DD
34962011-06-20 Deniz Dogan <deniz@dogan.se>
3497
3498 * process.c (Fset_process_buffer): Clarify return value in
3499 docstring.
3500
7d7d0045
CY
35012011-06-18 Chong Yidong <cyd@stupidchicken.com>
3502
3503 * dispnew.c (add_window_display_history): Use BVAR.
3504
3505 * xdisp.c (debug_method_add): Use BVAR.
3506 (check_window_end, dump_glyph_matrix, dump_glyph)
3507 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3508
3509 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3510 Likewise.
3511
3512 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3513 check till after the cache is created in init_frame_faces.
3514
ff2bc410
SM
35152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3516
3517 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3518
28177add
PE
35192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3520
dd3482fe
PE
3521 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3522 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3523 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3524
393d71f3 3525 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3526 * fileio.c (Finsert_file_contents):
3527 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3528 Remove the old (too-loose) buffer overflow checks.
3529 They weren't needed, since make_gap checks for buffer overflow.
3530 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3531 The old code merely checked for Emacs fixnum overflow, and relied
3532 on undefined (wraparound) behavior. The new code avoids undefined
3533 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3534
2e6813b0 3535 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3536 Tune. Don't use wider integers than needed. Don't use alloca.
3537 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3538
599a9e4f
PE
3539 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3540
99561444
PE
3541 * insdel.c, lisp.h (buffer_overflow): New function.
3542 (insert_from_buffer_1, replace_range, replace_range_2):
3543 * insdel.c (make_gap_larger):
3544 * editfns.c (Finsert_char):
3545 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3546
28177add
PE
3547 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3548
e69dafad
PE
35492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3550
a7af7fde 3551 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3552
b1c46f02
PE
3553 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3554 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3555
e69dafad
PE
3556 * fileio.c: Don't assume EMACS_INT fits in off_t.
3557 (emacs_lseek): New static function.
3558 (Finsert_file_contents, Fwrite_region): Use it.
3559 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3560
566684ea
PE
3561 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3562
e6966cd6
PE
3563 * fns.c: Don't overflow int when computing a list length.
3564 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3565 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3566 truncation on 64-bit hosts. Check for QUIT every
3567 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3568 faster and is responsive enough.
3569 (Flength): Report an error instead of overflowing an integer.
3570 (Fsafe_length): Return a float if the value is not representable
3571 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3572 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3573 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3574
dd0b0efb
PE
3575 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3576 (header_size, word_size): New constants.
3577 (allocate_vectorlike): Don't check size overflow here.
3578 (allocate_vector): Check it here instead, since this is the only
3579 caller of allocate_vectorlike that could cause overflow.
3580 Check that the new vector's length is representable as a fixnum.
3581
86fe5cfe
PE
3582 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3583 The previous code was bogus. For example, next_almost_prime (32)
3584 returned 39, which is undesirable as it is a multiple of 3; and
3585 next_almost_prime (24) returned 25, which is a multiple of 5 so
3586 why was the code bothering to check for multiples of 7?
3587
80e88859
PE
3588 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3589
4a2f0ad6
PE
3590 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3591
f66c7cf8
PE
3592 Variadic C functions now count arguments with ptrdiff_t.
3593 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3594 Back then I didn't know that the Emacs coding style prefers signed int.
3595 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3596 were being counted with int, which may truncate counts on 64-bit
3597 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3598 * lisp.h (struct Lisp_Subr.function.aMANY)
3599 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3600 Arg counts are now ptrdiff_t, not size_t.
3601 All variadic functions and their callers changed accordingly.
3602 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3603 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3604 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3605 * callint.c (Fcall_interactively): Check arg count for overflow,
3606 to avoid potential buffer overrun. Use signed char, not 'int',
3607 for 'varies' array, so that we needn't bother to check its size
3608 calculation for overflow.
3609 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3610 * eval.c (apply_lambda):
3611 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3612 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3613 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3614
a1759b76
PE
3615 * callint.c (Fcall_interactively): Don't use index var as event count.
3616
d96be9fc
PE
3617 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3618 * mem-limits.h (SIZE): Remove; no longer used.
3619
a690a978 3620 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3621
578c21e6
PE
3622 Remove unnecessary casts.
3623 * xterm.c (x_term_init):
3624 * xfns.c (x_set_border_pixel):
3625 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3626 These aren't needed now that we assume ANSI C.
3627
96f53c6c
PE
3628 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3629 It's more likely to cause problems (due to unsigned overflow)
3630 than to cure them.
3631
83c77d31
PE
3632 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3633
ee2079f1
PE
3634 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3635
6da65536
PE
3636 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3637
7147c4a4
PE
3638 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3639
193e32d9
PE
3640 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3641
e5533da6
PE
3642 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3643
9910e595
PE
3644 GLYPH_CODE_FACE returns EMACS_INT, not int.
3645 * dispextern.h (merge_faces):
3646 * xfaces.c (merge_faces):
01103c44
PE
3647 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3648 Don't assume EMACS_INT fits in int.
9910e595 3649
2638320e
PE
3650 * character.h (CHAR_VALID_P): Remove unused parameter.
3651 * fontset.c, lisp.h, xdisp.c: All uses changed.
3652
045eb8d9
PE
3653 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3654
c1f134b5
PE
3655 * fns.c (concat): Minor tuning based on overflow analysis.
3656 This doesn't fix any bugs. Use int to hold character, instead
3657 of constantly refetching from Emacs object. Use XFASTINT, not
3658 XINT, for value known to be a character. Don't bother comparing
3659 a single byte to 0400, as it's always less.
3660
395fcb93 3661 * floatfns.c (Fexpt):
327eeec8
PE
3662 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3663
abbd3d23
PE
3664 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3665 for characters.
3666
684a03ef
PE
3667 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3668
0fed43f3
PE
3669 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3670 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3671 incorrectly succeed when S was a string, because 4294967386 was
3672 truncated before it was used.
3673
8fd02eb7
PE
3674 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3675 Otherwise, an out-of-range integer could cause undefined behavior
3676 on a 64-bit host.
3677
f8c86b69
PE
3678 * composite.c: Use int, not EMACS_INT, for characters.
3679 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3680 EMACS_INT, for values that are known to be in character range.
3681 This doesn't fix any bugs but is the usual style inside Emacs and
3682 may generate better code on 32-bit machines.
3683
34206dd2
PE
3684 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3685 This is for reasons similar to the recent CHAR_STRING fix.
3686 * charset.c (Fencode_char): Check that character arg is actually
3687 a character. Pass an int to ENCODE_CHAR.
3688 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3689 wider than 'int', as a compile-time check to prevent future regressions
3690 in this area.
3691
c5958d4c 3692 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3693
3694 Make sure a 64-bit char is never passed to CHAR_STRING.
3695 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3696 by silently ignoring the top 32 bits, allowing some values
3697 that were far too large to be valid characters.
3698 * character.h: Include <verify.h>.
3699 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3700 arguments are no wider than unsigned, as a compile-time check
3701 to prevent future regressions in this area.
3702 * data.c (Faset):
01103c44 3703 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3704 (Fsubst_char_in_region):
3705 * fns.c (concat):
3706 * xdisp.c (decode_mode_spec_coding):
3707 Adjust to CHAR_STRING's new requirement.
3708 * editfns.c (Finsert_char, Fsubst_char_in_region):
3709 * fns.c (concat): Check that character args are actually
3710 characters. Without this test, these functions did the wrong
3711 thing with wildly out-of-range values on 64-bit hosts.
3712
d37ca623
PE
3713 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3714 These casts should not be needed on 32-bit hosts, either.
3715 * keyboard.c (read_char):
3716 * lread.c (Fload): Remove casts to unsigned.
3717
ea204efb
PE
3718 * lisp.h (UNSIGNED_CMP): New macro.
3719 This fixes comparison bugs on 64-bit hosts.
3720 (ASCII_CHAR_P): Use it.
3721 * casefiddle.c (casify_object):
01103c44 3722 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3723 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3724 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3725 * dispextern.h (FACE_FROM_ID):
3726 * keyboard.c (read_char): Use UNSIGNED_CMP.
3727
41cb286c
PE
3728 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3729 not to EMACS_INT, to avoid GCC warning.
3730
4a1b9832
PE
3731 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3732
55daad71
PE
3733 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3734 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3735 isn't needed on 32-bit machines.
8f95c75c 3736
01103c44
PE
3737 * buffer.c (Fgenerate_new_buffer_name):
3738 Use EMACS_INT for count, not int.
0ceccced 3739 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3740
3741 * data.c (Qcompiled_function): Now static.
3742
c6f072e7
PE
3743 * window.c (window_body_lines): Now static.
3744
20ce5912
PE
3745 * image.c (gif_load): Rename local to avoid shadowing.
3746
9c4c5f81
PE
3747 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3748 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3749 * alloc.c (make_save_value): Integer argument is now of type
3750 ptrdiff_t, not int.
3751 (mark_object): Use ptrdiff_t, not int.
3752 * lisp.h (pD): New macro.
3753 * print.c (print_object): Use it.
3754
c0c5c8ae
PE
3755 * alloc.c: Use EMACS_INT, not int, to count objects.
3756 (total_conses, total_markers, total_symbols, total_vector_size)
3757 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3758 (total_free_floats, total_floats, total_free_intervals)
3759 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3760 Now EMACS_INT, not int. All uses changed.
3761 (Fgarbage_collect): Compute overall total using a double, so that
3762 integer overflow is less likely to be a problem. Check for overflow
3763 when converting back to an integer.
5a25e253
PE
3764 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3765 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3766 These were 'int' variables that could overflow on 64-bit hosts;
3767 they were never used, so remove them instead of repairing them.
211a0b2a 3768 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3769 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3770 Previously, this ceilinged at INT_MAX, but that doesn't work on
3771 64-bit machines.
e46bb31a 3772 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3773
c78baabf 3774 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3775 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3776 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3777 when a (possibly-narrower) signed value would do just as well.
3778 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3779
c9d624c6
PE
3780 * alloc.c: Catch some string size overflows that we were missing.
3781 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3782 for convenience in STRING_BYTES_MAX.
3783 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3784 The definition here is exact; the one in lisp.h was approximate.
3785 (allocate_string_data): Check for string overflow. This catches
3786 some instances we weren't catching before. Also, it catches
3787 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3788 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3789 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3790
c9d624c6
PE
3791 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3792 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3793 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3794
353032ce
PE
3795 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3796
2bccce07
PE
3797 * alloc.c (Fmake_string): Check for out-of-range init.
3798
0ac30604
SM
37992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3800
3801 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3802
c195f2de
JD
38032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3804
3805 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3806 xg_get_default_scrollbar_width.
3807
3808 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3809 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3810 (style_changed_cb): Call update_theme_scrollbar_width and call
3811 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3812 all frames (Bug#8505).
3813 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3814 Call gtk_window_set_resizable if HAVE_GTK3.
3815 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3816 and height if HAVE_GTK3 (Bug#8505).
3817 (scroll_bar_width_for_theme): New variable.
3818 (update_theme_scrollbar_width): New function.
3819 (xg_get_default_scrollbar_width): Move code to
3820 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3821 (xg_initialize): Call update_theme_scrollbar_width.
3822
3823 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3824
3825 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3826
e10ac9f1
MR
38272011-06-12 Martin Rudalics <rudalics@gmx.at>
3828
3829 * frame.c (make_frame): Call other_buffer_safely instead of
3830 other_buffer.
3831
3832 * window.c (temp_output_buffer_show): Call display_buffer with
3833 second argument Vtemp_buffer_show_specifiers and reset latter
3834 immediately after the call.
3835 (Vtemp_buffer_show_specifiers): New variable.
3836 (auto_window_vscroll_p, next_screen_context_lines)
3837 (Vscroll_preserve_screen_position): Remove leading asterisks from
3838 doc-strings.
3839
2d3c217e 38402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3841
7b7f97e8 3842 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3843 * buffer.c (Qclone_number): Remove for now, as it's unused.
3844 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3845 (record_buffer): Remove unused local.
3846 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3847 (set_frame_buffer_list): Remove; unused.
3848 * frame.h (other_visible_frames): Remove decl.
3849 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3850 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3851 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3852 if HAVE_GPM.
3853 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3854 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3855 Define only if HAVE_GPM.
3856 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3857 (update_hints_inhibit): Remove; never set. All uses removed.
3858 * widgetprv.h (emacsFrameClassRec): Remove decl.
3859 * window.c (delete_deletable_window): Now returns void, since it
3860 wasn't returning anything.
3861 (compare_window_configurations): Remove unused locals.
3862 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3863 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3864 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3865 the same widths as pointers. This follows up on the 2011-05-06 patch.
3866 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3867 * xterm.h: Likewise.
3868 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3869
1384b89e
JB
38702011-06-12 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * makefile.w32-in: Update dependencies.
3873 (LISP_H): Add lib/intprops.h.
3874
1100a63c
CY
38752011-06-11 Chong Yidong <cyd@stupidchicken.com>
3876
3877 * image.c (gif_load): Add animation frame delay to the metadata.
3878 (syms_of_image): Use DEFSYM. New symbol `delay'.
3879
6198ccd0
MR
38802011-06-11 Martin Rudalics <rudalics@gmx.at>
3881
3882 * window.c (delete_deletable_window): Re-add.
3883 (Fset_window_configuration): Rewrite to handle dead buffers and
3884 consequently deletable windows.
3885 (window_tree, Fwindow_tree): Remove. Supply functionality in
3886 window.el.
3887 (compare_window_configurations): Simplify code.
3888
b6e3633c
AS
38892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3890
1ab0dee5
AS
3891 * image.c (imagemagick_load_image): Fix type mismatch.
3892 (Fimagemagick_types): Likewise.
3893
b6e3633c
AS
3894 * window.h (replace_buffer_in_windows): Declare.
3895
9397e56f
MR
38962011-06-11 Martin Rudalics <rudalics@gmx.at>
3897
3898 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3899 Qclone_number. Remove external declaration of Qdelete_window.
3900 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3901 code.
640c8776
SM
3902 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3903 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3904 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3905 buffer list implementation.
3906 (other_buffer_safely): New function.
3907 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3908 calls to replace_buffer_in_windows and
3909 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3910 if allowed.
3911 (record_buffer): Inhibit quitting and rewrite using quittable
3912 functions. Run Qbuffer_list_update_hook if allowed.
3913 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3914 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3915 Move switch-to-buffer to window.el.
9397e56f
MR
3916 (bury-buffer): Move to window.el.
3917 (Vbuffer_list_update_hook): New variable.
3918
3919 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3920 section.
3921
3922 * window.h (resize_frame_windows): Move up in code.
3923 (Fwindow_frame): Remove EXFUN.
3924 (replace_buffer_in_all_windows): Remove prototype.
3925 (replace_buffer_in_windows_safely): Add prototype.
3926
3927 * window.c: Declare Qdelete_window static again. Move down
3928 declaration of select_count.
3929 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3930 (Fother_window): Move to window.el.
3931 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3932 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3933 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3934 window.el.
3935 (replace_buffer_in_windows): Implement by calling
3936 Qreplace_buffer_in_windows.
3937 (replace_buffer_in_all_windows): Remove with some functionality
3938 moved into replace_buffer_in_windows_safely.
3939 (replace_buffer_in_windows_safely): New function.
3940 (select_window_norecord, select_frame_norecord): Move in front
3941 of run_window_configuration_change_hook. Remove now obsolete
3942 declarations.
640c8776
SM
3943 (Fset_window_buffer): Rewrite doc-string.
3944 Call Qrecord_window_buffer.
9397e56f
MR
3945 (keys_of_window): Move binding for other-window to window.el.
3946
b50691aa
CY
39472011-06-11 Chong Yidong <cyd@stupidchicken.com>
3948
3949 * dispextern.h (struct image): Replace data member, whose int_val
3950 and ptr_val fields were not used by anything, with a single
3951 lisp_val object.
3952
3953 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3954 (gif_clear_image, gif_load, imagemagick_load_image)
3955 (gs_clear_image, gs_load): Callers changed.
3956
3f754b86
PE
39572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3958
cca69397
PE
3959 * buffer.h: Include <time.h>, for time_t.
3960 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3961
109e28d0
PE
3962 Fix minor problems found by static checking.
3963
60737f02
PE
3964 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3965
4b66faf3
PE
3966 Make identifiers static if they are not used in other modules.
3967 * data.c (Qcompiled_function, Qframe, Qvector):
3968 * image.c (QimageMagick, Qsvg):
3969 * minibuf.c (Qmetadata):
3970 * window.c (resize_window_check, resize_root_window): Now static.
3971 * window.h (resize_window_check, resize_root_window): Remove decls.
3972
109e28d0
PE
3973 * window.c (window_deletion_count, delete_deletable_window):
3974 Remove; unused.
46a4ce9e
PE
3975 (window_body_lines): Now static.
3976 (Fdelete_other_windows_internal): Mark vars as initialized.
3977 Make sure 'resize_failed' is initialized.
3978 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3979 (resize_window_apply): Remove unused local.
3980 * window.h (delete_deletable_window): Remove decl.
3981
109e28d0 3982 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3983 (imagemagick_load_image): Fix pointer signedness problem by changing
3984 last arg from unsigned char * to char *. All uses changed.
3985 Also, fix a local for similar reasons.
3986 Remove unused locals. Remove locals to avoid shadowing.
3987 (fn_rsvg_handle_free): Remove; unused.
3988 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3989 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3990
3f754b86
PE
3991 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3992
2547adb1
CY
39932011-06-10 Chong Yidong <cyd@stupidchicken.com>
3994
3995 * image.c (gif_load): Fix omitted cast error introduced by
3996 2011-06-06 change.
3997
2c8e37d4
MR
39982011-06-10 Martin Rudalics <rudalics@gmx.at>
3999
4000 * window.h (resize_proportionally, orig_total_lines)
4001 (orig_top_line): Remove from window structure.
4002 (set_window_height, set_window_width, change_window_heights)
4003 (Fdelete_window): Remove prototypes.
4004 (resize_frame_windows): Remove duplicate declaration.
4005
440a42e3
EZ
40062011-06-10 Eli Zaretskii <eliz@gnu.org>
4007
4008 * window.h (resize_frame_windows, resize_window_check)
4009 (delete_deletable_window, resize_root_window)
4010 (resize_frame_windows): Declare prototypes.
4011
4012 * window.c (resize_window_apply): Make definition be "static" to
4013 match the prototype.
4014
562dd5e9
MR
40152011-06-10 Martin Rudalics <rudalics@gmx.at>
4016
4017 * window.c: Remove declarations of Qwindow_size_fixed,
4018 window_min_size_1, window_min_size_2, window_min_size,
4019 size_window, window_fixed_size_p, enlarge_window, delete_window.
4020 Remove static from declaration of Qdelete_window, it's
4021 temporarily needed by Fbury_buffer.
4022 (replace_window): Don't assign orig_top_line and
4023 orig_total_lines.
4024 (Fdelete_window, delete_window): Remove. Window deletion is
4025 handled by window.el.
640c8776
SM
4026 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4027 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4028 (Fdelete_other_windows): Remove. Deleting other windows is
4029 handled by window.el.
4030 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4031 handled in window.el.
4032 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4033 Window minimum sizes are handled in window.el.
4034 (shrink_windows, size_window, set_window_height)
4035 (set_window_width, change_window_heights, window_height)
4036 (window_width, CURBEG, CURSIZE, enlarge_window)
4037 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4038 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4039 handled in window.el.
4040 (make_dummy_parent): Rename to make_parent_window and give it a
4041 second argument horflag.
4042 (make_window): Don't set resize_proportionally any more.
4043 (Fsplit_window): Remove. Windows are split in window.el.
4044 (save_restore_action, save_restore_orig_size)
4045 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4046 Resize mini windows in window.el.
4047 (grow_mini_window, shrink_mini_window): Implement by calling
4048 Qresize_root_window_vertically, resize_window_check and
4049 resize_window_apply.
640c8776
SM
4050 (saved_window, Fset_window_configuration, save_window_save):
4051 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4052 resize_proportionally.
4053 (window_min_height, window_min_width): Move to window.el.
4054 (keys_of_window): Move bindings for delete-other-windows,
4055 split-window, delete-window and enlarge-window to window.el.
4056
4057 * buffer.c: Temporarily extern Qdelete_window.
4058 (Fbury_buffer): Temporarily call Qdelete_window instead of
4059 Fdelete_window (Fbury_buffer will move to window.el soon).
4060
4061 * frame.c (set_menu_bar_lines_1): Remove code handling
4062 orig_top_line and orig_total_lines.
4063
4064 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4065 set_window_height but set heights directly.
4066 (change_frame_size_1): Use resize_frame_windows.
4067
4068 * xdisp.c (init_xdisp): Don't use set_window_height but set
4069 heights directly.
4070
640c8776
SM
4071 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4072 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4073 run_window_configuration_change_hook.
4074
4075 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4076 instead of change_window_heights and run
4077 run_window_configuration_change_hook.
4078
1a13852e
MR
40792011-06-09 Martin Rudalics <rudalics@gmx.at>
4080
4081 * window.c (replace_window): Rename second argument REPLACEMENT to
4082 NEW. New third argument SETFLAG. Rewrite.
4083 (delete_window, make_dummy_parent): Call replace_window with
4084 third argument 1.
4085 (window_list_1): Move down in code.
4086 (run_window_configuration_change_hook): Move set_buffer part
4087 before select_frame_norecord part in order to unwind correctly.
4088 Rename count1 to count.
4089 (recombine_windows, delete_deletable_window, resize_root_window)
4090 (Fdelete_other_windows_internal)
4091 (Frun_window_configuration_change_hook, make_parent_window)
4092 (resize_window_check, resize_window_apply, Fresize_window_apply)
4093 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4094 (Fdelete_window_internal, Fresize_mini_window_internal):
4095 New functions.
1a13852e
MR
4096 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4097
f3d1777e
MR
40982011-06-08 Martin Rudalics <rudalics@gmx.at>
4099
496e208e
MR
4100 * window.h (window): Add some new members to window structure -
4101 normal_lines, normal_cols, new_total, new_normal, clone_number,
4102 splits, nest, prev_buffers, next_buffers.
4103 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4104 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4105
f3d1777e
MR
4106 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4107 Remove.
496e208e
MR
4108 (make_dummy_parent): Set new members of windows structure.
4109 (make_window): Move down in code. Handle new members of window
4110 structure.
4111 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4112 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4113 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4114 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4115 (Fset_window_next_buffers, Fset_window_clone_number):
4116 New functions.
496e208e
MR
4117 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4118 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4119 Doc-string fixes.
4120 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4121 Argument WINDOW can be now internal window too.
4122 (Fwindow_use_time): Move up in code.
4123 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4124 Rewrite doc-string.
4125 (Fset_window_configuration, saved_window)
4126 (Fcurrent_window_configuration, save_window_save): Handle new
4127 members of window structure.
b9e809c2
MR
4128 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4129 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4130 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4131 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4132 Qget_mru_window, Qresize_root_window,
4133 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4134 Qauto_buffer_name; staticpro them.
f3d1777e 4135
abde8f8c
MR
41362011-06-07 Martin Rudalics <rudalics@gmx.at>
4137
4138 * window.c (Fwindow_total_size, Fwindow_left_column)
4139 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4140 (Fwindow_list_1): New functions.
4141 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4142 (Fwindow_width, Fscroll_left, Fscroll_right):
4143 Use window_body_cols instead of window_box_text_cols.
4144 (delete_window, Fset_window_configuration):
4145 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4146 (delete_all_subwindows): Take a window as argument and not a
4147 structure. Rewrite.
190b47e6
MR
4148 (window_loop): Remove handling of GET_LRU_WINDOW and
4149 GET_LARGEST_WINDOW.
4150 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4151
4152 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4153 window_box_text_cols. delete_all_subwindows now takes a
4154 Lisp_Object as argument.
abde8f8c 4155
640c8776
SM
4156 * indent.c (compute_motion, Fcompute_motion):
4157 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4158
fa8a67e6
MR
4159 * frame.c (delete_frame): Call delete_all_subwindows with root
4160 window as argument.
4161
a54e3482
DC
41622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4163
4164 * fns.c (Fputhash): Document return value.
4165
60002bf5
CY
41662011-06-06 Chong Yidong <cyd@stupidchicken.com>
4167
4168 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4169
0c671da6 41702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4171
b862a52a 4172 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4173
be44ca6c
PE
4174 Check for overflow when converting integer to cons and back.
4175 * charset.c (Fdefine_charset_internal, Fdecode_char):
4176 Use cons_to_unsigned to catch overflow.
4177 (Fencode_char): Use INTEGER_TO_CONS.
4178 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4179 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4180 * data.c (long_to_cons, cons_to_long): Remove.
4181 (cons_to_unsigned, cons_to_signed): New functions.
4182 These signal an error for invalid or out-of-range values.
4183 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4184 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4185 * font.c (Ffont_variation_glyphs):
4186 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4187 * lisp.h: Include <intprops.h>.
4188 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4189 (cons_to_signed, cons_to_unsigned): New decls.
4190 (long_to_cons, cons_to_long): Remove decls.
4191 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4192 (Fprimitive_undo): Use CONS_TO_INTEGER.
4193 * xfns.c (Fx_window_property): Likewise.
4194 * xselect.c: Include <limits.h>.
4195 (x_own_selection, selection_data_to_lisp_data):
4196 Use INTEGER_TO_CONS.
4197 (x_handle_selection_request, x_handle_selection_clear)
4198 (x_get_foreign_selection, Fx_disown_selection_internal)
4199 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4200 (lisp_data_to_selection_data): Use cons_to_unsigned.
4201 (x_fill_property_data): Use cons_to_signed.
4202 Report values out of range.
4203
d1f3d2af
PE
4204 Check for buffer and string overflow more precisely.
4205 * buffer.h (BUF_BYTES_MAX): New macro.
4206 * lisp.h (STRING_BYTES_MAX): New macro.
4207 * alloc.c (Fmake_string):
4208 * character.c (string_escape_byte8):
4209 * coding.c (coding_alloc_by_realloc):
4210 * doprnt.c (doprnt):
4211 * editfns.c (Fformat):
4212 * eval.c (verror):
4213 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4214 since they may not be the same number.
4215 * editfns.c (Finsert_char):
4216 * fileio.c (Finsert_file_contents):
4217 Likewise for BUF_BYTES_MAX.
4218
dd52fcea
PE
4219 * image.c: Use ptrdiff_t, not int, for sizes.
4220 (slurp_file): Switch from int to ptrdiff_t.
4221 All uses changed.
4222 (slurp_file): Check that file size fits in both size_t (for
4223 malloc) and ptrdiff_t (for sanity and safety).
4224
7f9bbdbb
PE
4225 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4226 if b->modtime has its maximal value.
4227
dfe18f82
PE
4228 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4229
84acfcf0
PE
4230 Don't assume time_t can fit into int.
4231 * buffer.h (struct buffer.modtime): Now time_t, not int.
4232 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4233 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4234
ccd9a01a
PE
4235 Minor fixes for signed vs unsigned integers.
4236 * character.h (MAYBE_UNIFY_CHAR):
4237 * charset.c (maybe_unify_char):
4238 * keyboard.c (read_char, reorder_modifiers):
4239 XINT -> XFASTINT, since the integer must be nonnegative.
4240 * ftfont.c (ftfont_spec_pattern):
4241 * keymap.c (access_keymap, silly_event_symbol_error):
4242 XUINT -> XFASTINT, since the integer must be nonnegative.
4243 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4244 since it makes no difference and we prefer signed.
4245 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4246 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4247 nonnegative.
4248
d6d100dd
SM
42492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4250
4251 * window.h (Fwindow_frame): Declare.
4252
2b6148e4
PE
42532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4256 (SPARE_MEMORY): Always define.
4257 (LARGE_REQUEST): Remove.
4258 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4259
f230ecc9
MR
42602011-06-06 Martin Rudalics <rudalics@gmx.at>
4261
727e958e
MR
4262 * lisp.h: Move EXFUNS for Fframe_root_window,
4263 Fframe_first_window and Fset_frame_selected_window to window.h.
4264
4265 * window.h: Move EXFUNS for Fframe_root_window,
4266 Fframe_first_window and Fset_frame_selected_window here from
4267 lisp.h.
4268
4269 * frame.c (Fwindow_frame, Fframe_first_window)
4270 (Fframe_root_window, Fframe_selected_window)
4271 (Fset_frame_selected_window): Move to window.c.
4272 (Factive_minibuffer_window): Move to minibuf.c.
4273 (Fother_visible_frames_p): New function.
4274
4275 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4276
f230ecc9
MR
4277 * window.c (decode_window, decode_any_window): Move up in code.
4278 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4279 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4280 (Fwindow_buffer): Move up and rewrite doc-string.
4281 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4282 (Fwindow_prev): New functions.
727e958e
MR
4283 (Fwindow_frame): Move here from frame.c. Accept any window as
4284 argument.
4285 (Fframe_root_window, Fframe_first_window)
4286 (Fframe_selected_window): Move here from frame.c. Accept frame
4287 or arbitrary window as argument. Update doc-strings.
4288 (Fminibuffer_window): Move up in code.
4289 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4290 (Fset_frame_selected_window): Move here from frame.c.
4291 Marginal rewrite.
727e958e
MR
4292 (Fselected_window, select_window, Fselect_window): Move up in
4293 code. Minor doc-string fixes.
f230ecc9 4294
4d09bcf6
PE
42952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4296
4297 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4298 Do not assume that spare memory exists; that assumption is valid
4299 only if SYSTEM_MALLOC.
4300 (LARGE_REQUEST): New macro, so that the issue of large requests
4301 is separated from the issue of spare memory.
4302
810928a2
AS
43032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4304
172418ad
AS
4305 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4306 format. (Bug#8806)
4307
43f862f7
AS
4308 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4309
810928a2
AS
4310 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4311 before statements.
4312
a059fe24
JD
43132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4314
4315 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4316
4317 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4318
4319 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4320 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4321
989bf368
JB
43222011-06-05 Juanma Barranquero <lekktu@gmail.com>
4323
4324 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4325
4b80f674
CY
43262011-06-04 Chong Yidong <cyd@stupidchicken.com>
4327
4328 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4329 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4330 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4331 New error handlers.
4b80f674
CY
4332 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4333 Obey Vx_select_enable_clipboard_manager. Catch errors in
4334 x_clipboard_manager_save (Bug#8779).
4335 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4336 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4337
99a33b77 43382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4339
4340 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4341
99a33b77 43422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4343
4344 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4345 in the current matrix if keep_current_p is non-zero.
4346
8264569d
EZ
43472011-06-04 Eli Zaretskii <eliz@gnu.org>
4348
4349 * bidi.c (bidi_level_of_next_char): Fix last change.
4350
57f97249
EZ
43512011-06-03 Eli Zaretskii <eliz@gnu.org>
4352
fec2107c 4353 Support bidi reordering of text covered by display properties.
57f97249 4354
fec2107c
EZ
4355 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4356 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4357 (bidi_cache_search, bidi_cache_iterator_state)
4358 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4359 (bidi_level_of_next_char, bidi_move_to_visually_next):
4360 Support character positions inside a run of characters covered by a
fec2107c
EZ
4361 display string.
4362 (bidi_paragraph_init, bidi_resolve_explicit_1)
4363 (bidi_level_of_next_char): Call bidi_fetch_char and
4364 bidi_fetch_char_advance instead of FETCH_CHAR and
4365 FETCH_CHAR_ADVANCE.
4366 (bidi_init_it): Initialize new members.
4367 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4368 definitions.
4369 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4370 instead of using explicit *_CHAR codes.
d6d100dd
SM
4371 (bidi_resolve_explicit, bidi_resolve_weak):
4372 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4373 bidirectional text is supported only in multibyte buffers.
4374 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4375 it to initialize the frame_window_p member of struct bidi_it.
4376 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4377 (bidi_resolve_explicit, bidi_resolve_weak)
4378 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4379 bidi_it->nchars is non-positive.
4380 (bidi_level_of_next_char): Don't try to lookup the cache for the
4381 next/previous character if nothing is cached there yet, or if we
4382 were just reseat()'ed to a new position.
c40e2fb2 4383
0e14fe90
EZ
4384 * xdisp.c (set_cursor_from_row): Set start and stop points
4385 according to the row's direction when priming the loop that looks
4386 for the glyph on which to display cursor.
4387 (single_display_spec_intangible_p): Function deleted.
4388 (display_prop_intangible_p): Reimplement to call
4389 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4390 Accept 3 additional arguments needed by handle_display_spec.
4391 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4392 values: lists, `(when COND...)' forms, etc.
4393 (single_display_spec_string_p): Support property values that are
4394 lists with the argument STRING its top-level element.
4395 (display_prop_string_p): Fix the condition for processing a
4396 property that is a list to be consistent with handle_display_spec.
fec2107c 4397 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4398 last portion of handle_display_prop.
4399 (compute_display_string_pos): Accept additional argument
4400 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4401 value of a `display' property is a "replacing spec".
4402 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4403 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4404 the display property, but just return a value indicating whether
4405 the display property will replace the characters it covers.
4406 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4407 frame_window_p members of struct bidi_it.
d6d100dd
SM
4408 (compute_display_string_pos, compute_display_string_end):
4409 New functions.
fec2107c
EZ
4410 (push_it): Accept second argument POSITION, where pop_it should
4411 jump to continue iteration.
4412 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4413
fec2107c
EZ
4414 * keyboard.c (adjust_point_for_property): Adjust the call to
4415 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4416
4417 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4418 (bidi_init_it): Update prototypes.
4419 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4420 (compute_display_string_pos, compute_display_string_end):
4421 Declare prototypes.
fec2107c
EZ
4422 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4423 EMACS_INT.
fc6f18ce 4424
40087514 44252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4426
57f53182
PE
4427 Malloc failure behavior now depends on size of allocation.
4428 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4429 * lisp.h: Change signatures accordingly.
4430 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4431 All callers changed. (Bug#8762)
4432
4433 * gnutls.c: Use Emacs's memory allocators.
4434 Without this change, the gnutls library would invoke malloc etc.
4435 directly, which causes problems on non-SYNC_INPUT hosts, and which
4436 runs afoul of improving memory_full behavior. (Bug#8761)
4437 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4438 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4439 xfree instead of the default malloc, realloc, free.
4440 (Fgnutls_boot): No need to check for memory allocation failure,
4441 since xmalloc does that for us.
4442
ac32cd99 4443 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4444 * category.c (hash_get_category_set):
4445 * ccl.c (ccl_driver):
4446 * charset.c (Fdefine_charset_internal):
4447 * charset.h (struct charset.hash_index):
4448 * composite.c (get_composition_id, gstring_lookup_cache)
4449 (composition_gstring_put_cache):
4450 * composite.h (struct composition.hash_index):
4451 * dispextern.h (struct image.hash):
4452 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4453 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4454 (hashfn_equal, hashfn_user_defined, make_hash_table)
4455 (maybe_resize_hash_table, hash_lookup, hash_put)
4456 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4457 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4458 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4459 * image.c (make_image, search_image_cache, lookup_image)
4460 (xpm_put_color_table_h):
4461 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4462 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4463 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4464 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4465 * alloc.c (allocate_vectorlike):
4466 Check for overflow in vector size calculations.
4467 * ccl.c (ccl_driver):
4468 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4469 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4470 need to be updated by these changes.
40087514
PE
4471 * fns.c (make_hash_table, maybe_resize_hash_table):
4472 Check for integer overflow with large hash tables.
0de4bb68
PE
4473 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4474 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4475 (SXHASH_REDUCE): New macro.
4476 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4477 Use it instead of discarding useful hash info with large hash values.
4478 (sxhash_float): New function.
4479 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4480 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4481 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4482 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4483 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4484 Adjust signatures to match updated version of code.
4485 (consing_since_gc): Now EMACS_INT, since a single hash table can
4486 use more than INT_MAX bytes.
4487
698d32e2
DN
44882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4489
4490 Make it possible to build with GCC-4.6+ -O2 -flto.
4491
4492 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4493
fd6fa53f
SM
44942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4495
4496 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4497 Call minibuffer-inactive-mode.
4498
864db017
JB
44992011-05-31 Juanma Barranquero <lekktu@gmail.com>
4500
4501 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4502 Update dependencies.
4503
2ad0baf4
DN
45042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4505
4506 * data.c (init_data): Remove code for UTS, this system is not
4507 supported anymore.
4508
4fcc2638
DN
45092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4510
4511 Don't force ./temacs to start in terminal mode.
4512
4513 * frame.c (make_initial_frame): Initialize faces in all cases, not
4514 only when CANNOT_DUMP is defined.
4515 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4516
c56e0fd5
DN
45172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4518
4519 * dispnew.c (add_window_display_history): Use const for the string
4520 pointer. Remove declaration, not needed.
4521
333d54da 45222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4523
55d4c1b2 4524 Use 'inline', not 'INLINE'.
333d54da 4525 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4526 * alloc.c, fontset.c (INLINE): Remove.
4527 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4528 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4529 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4530 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4531 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4532
738db178
DN
45332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4534
4535 Make it possible to run ./temacs.
4536
4537 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4538 syms_of_callproc does the same thing. Remove test for
4539 "initialized", do it in the caller.
4540 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4541
620c53a6
SM
45422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4543
4544 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4545 (read_minibuf): Use get_minibuffer.
4546 (syms_of_minibuf): Use DEFSYM.
4547 (Qmetadata): New var.
4548 * data.c (Qbuffer): Don't make it static.
4549 (syms_of_data): Use DEFSYM.
4550
e003a292
PE
45512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4554 (CCL_CODE_MIN): New macro.
4555
ed008a6d
PE
45562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4557
3687c2ef
PE
4558 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4559
ed008a6d
PE
4560 * eval.c (Qdebug): Now static.
4561 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4562 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4563 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4564
d66c4c7c
CY
45652011-05-29 Chong Yidong <cyd@stupidchicken.com>
4566
4567 * image.c: Various fixes to ImageMagick code comments.
4568 (Fimagemagick_types): Doc fix.
4569
5fbc2025
PE
45702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4571
0196f88a
PE
4572 Minor fixes prompted by GCC 4.6.0 warnings.
4573
4574 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4575
5fbc2025
PE
4576 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4577 (x_clipboard_manager_save_all): Move extern decl to ...
4578 * xterm.h: ... here, so that it can be checked for consistency.
4579
1dd3c2d9
CY
45802011-05-29 Chong Yidong <cyd@stupidchicken.com>
4581
4582 * xselect.c (x_clipboard_manager_save_frame)
4583 (x_clipboard_manager_save_all): New functions.
4584 (Fx_clipboard_manager_save): Lisp function deleted.
4585
4586 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4587 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4588
4589 * xterm.h: Update prototype.
4590
5ba6571d
WX
45912011-05-28 William Xu <william.xwl@gmail.com>
4592
4593 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4594 exiting (Bug#8239).
4595
3eaff834
JM
45962011-05-28 Jim Meyering <meyering@redhat.com>
4597
e1900994 4598 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4599 * fns.c (to_uchar): Define.
4600 (crypto_hash_function): Use it to convert some newly-signed
4601 variables to unsigned, to avoid sign-extension bugs. For example,
4602 without this change, (md5 "truc") would evaluate to
4603 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4604 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4605 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4606
0f6990a7
PE
46072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4608
4609 Integer overflow fixes.
c8a9ca5a 4610
08686060
PE
4611 * dbusbind.c: Serial number integer overflow fixes.
4612 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4613 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4614 to hold a serial number that is too large for a fixnum.
4615 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4616 Check for serial numbers out of range. Decode any serial number
59568bf0 4617 that was so large that it became a float. (Bug#8722)
08686060 4618
2d1fc3c7
PE
4619 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4620 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4621 Use XFASTINT rather than XUINT when numbers are nonnegative.
4622 (xd_append_arg, Fdbus_method_return_internal):
4623 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4624 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4625 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4626 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4627 (Bug#8722)
2d1fc3c7 4628
c8a9ca5a
PE
4629 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4630
519e1d69
PE
4631 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4632
30569699
PE
4633 ccl: add integer overflow checks
4634 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4635 (IN_INT_RANGE): New macros.
4636 (ccl_driver): Use them to check for integer overflow when
4637 decoding a CCL program. Many of the new checks are whether XINT (x)
4638 fits in int; it doesn't always, on 64-bit hosts. The new version
4639 doesn't catch all possible integer overflows, but it's an
847044ea 4640 improvement. (Bug#8719)
30569699 4641
c11285dc
PE
4642 * alloc.c (make_event_array): Use XINT, not XUINT.
4643 There's no need for unsigned here.
4644
fdccd48e
PE
4645 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4646 This follows up to the 2011-05-06 change that substituted uintptr_t
4647 for EMACS_INT. This case wasn't caught back then.
4648
37910ab2
PE
4649 Rework Fformat to avoid integer overflow issues.
4650 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4651 now (part of C89). Include <verify.h>.
4652 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4653 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4654 (Fformat): Avoid the prepass trying to compute sizes; it was only
4655 approximate and thus did not catch overflow reliably. Instead, walk
4656 through the format just once, formatting and computing sizes as we go,
4657 checking for integer overflow at every step, and allocating a larger
4658 buffer as needed. Keep track separately whether the format is
4659 multibyte. Keep only the most-recently calculated precision, rather
4660 than them all. Record whether each argument has been converted to
4661 string. Use EMACS_INT, not int, for byte and char and arg counts.
4662 Support field widths and precisions larger than INT_MAX. Avoid
4663 sprintf's undefined behavior with conversion specifications such as %#d
4664 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4665 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4666 formatting out-of-range floating point numbers with int
9173deec 4667 formats. (Bug#8668)
37910ab2 4668
2e6578fb
PE
4669 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4670
0ae6bdee
PE
4671 * data.c: Avoid integer truncation in expressions involving floats.
4672 * data.c: Include <intprops.h>.
4673 (arith_driver): When there's an integer overflow in an expression
4674 involving floating point, convert the integers to floating point
4675 so that the resulting value does not suffer from catastrophic
4676 integer truncation. For example, on a 64-bit host (* 4
4677 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4678 Do not rely on undefined behavior after integer overflow.
4679
de883a70
PE
4680 merge count_size_as_multibyte, parse_str_to_multibyte
4681 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4682 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4683 Check for integer overflow.
4684 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4685 since it's now a duplicate of the other. This is more of
4686 a character than a buffer op, so better that it's in character.c.
4687 * fns.c, print.c: Adjust to above changes.
4688
2ff916cb
PE
46892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4690
4691 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4692
f1b54466
PE
46932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4694
fb1ac845
PE
4695 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4696 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4697 (x_clipboard_manager_save): Now static.
4698 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4699
f1b54466
PE
4700 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4701 (crypto_hash_function): Now static.
4702 Fix pointer signedness problems. Avoid unnecessary initializations.
4703
a9f737ee
CY
47042011-05-27 Chong Yidong <cyd@stupidchicken.com>
4705
4706 * termhooks.h (Vselection_alist): Make it terminal-local.
4707
4708 * terminal.c (create_terminal): Initialize it.
4709
4710 * xselect.c: Support for clipboard managers.
4711 (Vselection_alist): Move to termhooks.h as terminal-local var.
4712 (LOCAL_SELECTION): New macro.
4713 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4714 (symbol_to_x_atom): Remove gratuitous arg.
4715 (x_handle_selection_request, lisp_data_to_selection_data)
4716 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4717 (x_own_selection, x_get_local_selection, x_convert_selection):
4718 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4719 (some_frame_on_display): Delete unused function.
4720 (Fx_own_selection_internal, Fx_get_selection_internal)
4721 (Fx_disown_selection_internal, Fx_selection_owner_p)
4722 (Fx_selection_exists_p): New optional frame arg.
4723 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4724 (x_handle_selection_clear): Don't treat other terminals with the
4725 same keyboard specially. Use the terminal-local Vselection_alist.
4726 (x_clear_frame_selections): Use Frun_hook_with_args.
4727
4728 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4729
4730 * xterm.h: Add support for those atoms.
4731
e067f0c1
CY
47322011-05-26 Chong Yidong <cyd@stupidchicken.com>
4733
4734 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4735 (converted_selections, conversion_fail_tag): New global variables.
4736 (x_selection_request_lisp_error): Free the above.
4737 (x_get_local_selection): Remove unnecessary code.
4738 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4739 of converted selections stored in converted_selections.
4740 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4741 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4742 (x_convert_selection): New function.
4743 (x_handle_selection_event): Simplify.
4744 (x_get_foreign_selection): Don't ignore incoming requests while
4745 waiting for an answer; this will fail when we implement
4746 SAVE_TARGETS, and seems unnecessary anyway.
4747 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4748 (Vx_sent_selection_functions): Doc fix.
4749
0f4aebc0
LL
47502011-05-26 Leo Liu <sdl.web@gmail.com>
4751
4752 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4753
e61124cd
YM
47542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4755
4756 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4757
4758 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4759 for fringe update if it has periodic bitmap.
ac389d0c 4760 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4761 and fringe_bitmap_periodic_p.
4762
4763 * fringe.c (get_fringe_bitmap_data): New function.
4764 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4765 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4766 row. Mark glyph row for fringe update if periodicity changed.
4767
4768 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4769 for fringe update unless it has periodic bitmap.
4770
f16d9837
KH
47712011-05-25 Kenichi Handa <handa@m17n.org>
4772
4773 * xdisp.c (get_next_display_element): Set correct it->face_id for
4774 a static composition.
4775
e1b90ef6
LL
47762011-05-24 Leo Liu <sdl.web@gmail.com>
4777
4778 * deps.mk (fns.o):
4779 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4780
4781 * fns.c (crypto_hash_function, Fsha1): New function.
4782 (Fmd5): Use crypto_hash_function.
4783 (syms_of_fns): Add Ssha1.
4784
7400048f
PE
47852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4786
4787 * gnutls.c: Remove unused macros.
4788 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4789 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4790 Remove macros that are defined and never used.
4791 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4792
abb71cf4
CY
47932011-05-22 Chong Yidong <cyd@stupidchicken.com>
4794
4795 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4796 (Fx_get_selection_internal): Minor cleanup.
4797 (Fx_own_selection_internal): Rename arguments for consistency with
4798 select.el.
4799
6307db39
PE
48002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4801
4802 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4803
f3d4e0a4
CY
48042011-05-22 Chong Yidong <cyd@stupidchicken.com>
4805
4806 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4807
4d8ade89
YM
48082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4809
4810 * dispnew.c (scrolling_window): Don't exclude the case that the
4811 last enabled row in the desired matrix touches the bottom boundary.
4812
32078c8d
GM
48132011-05-21 Glenn Morris <rgm@gnu.org>
4814
4815 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4816 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4817 and add some more files.
32078c8d 4818
7285dc67
EZ
48192011-05-20 Eli Zaretskii <eliz@gnu.org>
4820
4821 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4822 report_file_error introduced by the change from 2011-05-07.
4823
89d1bd22
PE
48242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4825
4826 * systime.h (Time): Define only if emacs is defined.
4827 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4828 where the include path doesn't have X11/X.h by default. See
4829 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4830
e23640bb 48312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4832
4833 * composite.c (find_automatic_composition): Fix previous change.
4834
b9704ad9
GM
48352011-05-20 Glenn Morris <rgm@gnu.org>
4836
4837 * lisp.mk: New file, split from Makefile.in.
4838 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4839 (shortlisp): Remove.
4840 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4841
4a720484
GM
48422011-05-19 Glenn Morris <rgm@gnu.org>
4843
4844 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4845 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4846 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4847 (lisp): Set the order to that of loadup.el.
4848 (shortlisp): Make it a copy of $lisp.
4849 (SOME_MACHINE_LISP): Remove.
4850 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4851 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4852
a28d4396
KH
48532011-05-18 Kenichi Handa <handa@m17n.org>
4854
4855 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4856 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4857 (find_automatic_composition): Mostly rewrite for efficiency.
4858
a2b1fa8e
JB
48592011-05-18 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * makefile.w32-in: Update dependencies.
4862
8e1f5610
CS
48632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4864
4865 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4866 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4867
7025ee00 48682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4869
cdfa6eab
PE
4870 Fix some integer overflow issues, such as string length overflow.
4871
06d6db33
PE
4872 * insdel.c (count_size_as_multibyte): Check for string overflow.
4873
2b4560a8
PE
4874 * character.c (lisp_string_width): Check for string overflow.
4875 Use EMACS_INT, not int, for string indexes and lengths; in
4876 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4877 the resulting string length overflows an EMACS_INT; instead,
4878 report a string overflow if no precision given. When checking for
4879 precision exhaustion, use a check that cannot possibly have
4880 integer overflow. (Bug#8675)
4881 * character.h (lisp_string_width): Adjust to new signature.
4882
cb93f9be
PE
4883 * alloc.c (string_overflow): New function.
4884 (Fmake_string): Use it. This doesn't change behavior, but saves
4885 a few bytes and will simplify future changes.
4886 * character.c (string_escape_byte8): Likewise.
4887 * lisp.h (string_overflow): New decl.
4888
1a1f3366
PE
4889 Fixups, following up to the user-interface timestamp change.
4890 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4891 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4892 * msdos.c (mouse_get_pos): Likewise.
4893 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4894 * w32gui.h (Time): Define by including "systime.h" rather than by
4895 declaring it ourselves. (Bug#8664)
4896
d4e3e4d3
PE
4897 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4898 * image.c (clear_image_cache): Likewise.
4899
f6a24d19
PE
4900 * term.c (term_mouse_position): Don't assume time_t wraparound.
4901
08dc5ae6
PE
4902 Be more systematic about user-interface timestamps.
4903 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4904 and sometimes 'EMACS_UINT', to represent these timestamps.
4905 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4906 This makes the code easier to follow, and makes it easier to catch
4907 integer overflow bugs such as Bug#8664.
4908 * frame.c (Fmouse_position, Fmouse_pixel_position):
4909 Use Time, not unsigned long, for user-interface timestamps.
4910 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4911 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4912 * keyboard.h (last_event_timestamp): Likewise.
4913 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4914 * menu.h (xmenu_show): Likewise.
4915 * term.c (term_mouse_position): Likewise.
4916 * termhooks.h (struct input_event.timestamp): Likewise.
4917 (struct terminal.mouse_position_hook): Likewise.
4918 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4919 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4920 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4921 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4922 what it was before.
4923 * menu.h, termhooks.h: Include "systime.h", for Time.
4924
8e55734a
PE
4925 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4926 Don't assume that the difference between two unsigned long values
4927 can fit into an integer. At this point, we know button_down_time
4928 <= event->timestamp, so the difference must be nonnegative, so
4929 there's no need to cast the result if double-click-time is
4930 nonnegative, as it should be; check that it's nonnegative, just in
4931 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4932 apart (about 25 days). (Bug#8664)
8e55734a 4933
841f1b75 4934 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4935 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4936
3e26f69c
PE
4937 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4938 that always fit in int. Use a sentinel instead of a counter, to
4939 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4940 * frame.h (struct frame): Use int for menu_bar_items_used
4941 instead of EMACS_INT, since it always fits in int.
3e26f69c 4942
5cc152c0
PE
4943 * menu.c (grow_menu_items): Check for int overflow.
4944
d89eb65e
PE
4945 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4946
5235bd3e
PE
4947 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4948 Before, the code was not consistent. These values cannot exceed
4949 2**31 - 1 so there's no need to make them unsigned.
4950 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4951 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4952 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4953 as modifiers.
4954 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4955
bc827e23
PE
4956 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4957 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4958 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4959 presumably because the widths might not match.
4960
78eb494e
PE
4961 * window.c (size_window): Avoid needless test at loop start.
4962
04f2d78b
CB
49632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4964
4965 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4966
d2fc7e3d 49672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4968
4969 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4970
d2fc7e3d 49712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4972
4973 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4974 `width' to `bar_area_x' and `bar_area_width', respectively.
4975 (x_scroll_run): Take account of fringe background extension.
4976
04f2d78b
CB
4977 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4978 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4979 `bar_area_width', respectively.
4980 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4981 background extension.
4982
79b70037
GM
49832011-05-10 Jim Meyering <meyering@redhat.com>
4984
4985 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4986
2f142cc5
JB
49872011-05-10 Juanma Barranquero <lekktu@gmail.com>
4988
4989 * image.c (Finit_image_library): Return t for built-in image types,
4990 like pbm and xbm. (Bug#8640)
4991
57679c86
AS
49922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4993
4994 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4995
888c9e86
EZ
49962011-05-07 Eli Zaretskii <eliz@gnu.org>
4997
b0512a1d
EZ
4998 * w32console.c (Fset_screen_color): Doc fix.
4999 (Fget_screen_color): New function.
5000 (syms_of_ntterm): Defsubr it.
5001
7285dc67
EZ
5002 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5003 unlink the temporary file if Fcall_process didn't create it in the
5004 first place.
5005 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5006 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5007 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5008 cue to call_process_cleanup not to close that handle.
5009
4d3fcc8e
BK
50102011-05-07 Ben Key <bkey76@gmail.com>
5011
5012 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5013 one of two shell specific rules, either bootstrap-temacs-CMD or
5014 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5015 to the previous implementation of the bootstrap-temacs rule.
5016 The bootstrap-temacs-CMD rule is similar to the previous
5017 implementation of the bootstrap-temacs rule except that it
5018 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5019 variable.
5020
5021 These changes, along with some changes to nt/configure.bat,
5022 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5023 earlier fix to add support for --cflags and --ldflags options
5024 that include quotes so that it works whether make uses cmd or
5025 sh as the shell.
5026
b4289b64
MA
50272011-05-06 Michael Albinus <michael.albinus@gmx.de>
5028
5029 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5030 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5031 is a constant.
5032 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5033 a string. Handle both cases.
5034 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5035 (Fdbus_register_method): Use Qinvalid_function.
5036
af4c0e28
JB
50372011-05-06 Juanma Barranquero <lekktu@gmail.com>
5038
5039 * makefile.w32-in: Update dependencies.
5040 (LISP_H): Add inttypes.h and stdin.h.
5041 (PROCESS_H): Add unistd.h.
5042
c51453d9
EZ
50432011-05-06 Eli Zaretskii <eliz@gnu.org>
5044
5045 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5046 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5047
8ff0ac3c 50482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5049
4c4b566b
PE
5050 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5051
aab2b9b5
PE
5052 * term.c (vfatal): Remove stray call to va_end.
5053 It's not needed and the C Standard doesn't allow it here anyway.
5054
c378da0b
PE
5055 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5056 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5057
288b08c7
PE
5058 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5059 bytes.
5060
e3601888
PE
5061 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5062
db6c0e74
PE
5063 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5064
dd5963ea
PE
5065 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5066
88c9450f
PE
5067 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5068
2f9442b8
PE
5069 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5070
c032b5f8
PE
5071 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5072 * charset.c (Fdefine_charset_internal): Don't initialize
5073 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5074 32-bit int (Bug#8600).
a108c10b
PE
5075
5076 * lread.c (read_integer): Be more consistent with string-to-number.
5077 Use string_to_number to do the actual conversion; this avoids
5078 rounding errors and fixes some other screwups. Without this fix,
5079 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5080 (digit_to_number): Move earlier, for benefit of read_integer.
5081 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5082 not a digit in any supported base. (Bug#8602)
a108c10b 5083
ad5f9eea
PE
5084 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5085
aec1708a
PE
5086 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5087 to match comment at start of function. This also removes a
5088 GCC warning about overflow in a 32+64-bit port.
5089
47be4ab5
PE
5090 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5091
371cac43
PE
5092 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5093 Reported by Stefan Monnier in
5094 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5095 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5096 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5097
d01a7826
PE
5098 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5099 (EMACS_UINTPTR): Likewise, with uintptr_t.
5100
7fd47d5c
PE
5101 * lisp.h: Prefer 64-bit EMACS_INT if available.
5102 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5103 on 32-bit hosts that have 64-bit int, so that they can access
5104 large files.
122b0c86
PE
5105 However, temporarily disable this change unless the temporary
5106 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5107
8727937b
PE
5108 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5109
8ac068ac
PE
5110 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5111 This removes an assumption that EMACS_INT and long are the same
5112 width as pointers. The assumption is true for Emacs porting targets
5113 now, but we want to make other targets possible.
5114 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5115 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5116 In the rest of the code, change types of integers that hold casted
5117 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5118 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5119 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5120 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5121 No need to cast type when ORing.
5122 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5123 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5124 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5125 assume EMACS_INT is the same width as char *.
5126 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5127 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5128 Remove no-longer-needed casts.
5129 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5130 (xg_tool_bar_help_callback, xg_make_tool_item):
5131 Use EMACS_INTPTR to hold an integer
5132 that will be cast to void *; this can avoid a GCC warning
5133 if EMACS_INT is not the same width as void *.
5134 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5135 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5136 (current_message_1, set_message_1):
5137 Use a local to convert to proper width without a cast.
5138 * xmenu.c (dialog_selection_callback): Likewise.
5139
ede49d71
PE
5140 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5141 Also, don't assume VALBITS / RAND_BITS is less than 5,
5142 and don't rely on undefined behavior when shifting a 1 left into
5143 the sign bit.
5144 * lisp.h (get_random): Change signature to match.
5145
2f30ecd0
PE
5146 * lread.c (hash_string): Use size_t, not int, for hash computation.
5147 Normally we prefer signed values; but hashing is special, because
5148 it's better to use unsigned division on hash table sizes so that
5149 the remainder is nonnegative. Also, size_t is the natural width
5150 for hashing into memory. The previous code used 'int', which doesn't
5151 retain enough info to hash well into very large tables.
5152 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5153
2a866e7b
PE
5154 * dbusbind.c: Don't possibly lose pointer info when converting.
5155 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5156 Use XPNTR rather than XHASH, so that the high-order bits of
5157 the pointer aren't lost when converting through void *.
5158
51639eac
PE
5159 * eval.c (Fautoload): Don't double-shift a pointer.
5160
92394119
PE
5161 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5162
dbdb9a7c
JB
51632011-05-06 Juanma Barranquero <lekktu@gmail.com>
5164
5165 * gnutls.c (DEF_GNUTLS_FN):
5166 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5167
db7a0b4f
AS
51682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5169
5170 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5171 marker. (Bug#8610)
5172
f7ff1b0f 51732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5174
5175 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5176 New version that can reserve upto 2GB of heap space.
5177
f7ff1b0f 51782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5179
5180 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5181
639c109b
TZ
51822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5183
5184 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5185 `gnutls_certificate_set_x509_key_file'.
5186
d2127135
JB
51872011-05-05 Juanma Barranquero <lekktu@gmail.com>
5188
5189 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5190 Update dependencies.
5191
e968f4f3
JB
51922011-05-04 Juanma Barranquero <lekktu@gmail.com>
5193
5194 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5195 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5196 Remove unused parameter `fildes'.
5197 * process.c (read_process_output, send_process): Don't pass it.
5198
84d358f0
JB
51992011-05-04 Juanma Barranquero <lekktu@gmail.com>
5200
5201 Fix previous change: the library cache is defined in w32.c.
5202 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5203 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5204
0898ca10
JB
52052011-05-04 Juanma Barranquero <lekktu@gmail.com>
5206
5207 Implement dynamic loading of GnuTLS on Windows.
5208
5209 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5210 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5211 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5212 Declare.
5213
5214 * gnutls.c (Qgnutls_dll): Define.
5215 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5216 (gnutls_*): Declare function pointers.
5217 (init_gnutls_functions): New function to initialize function pointers.
5218 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5219 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5220 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5221 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5222 (emacs_gnutls_write, emacs_gnutls_read)
5223 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5224 (Fgnutls_available_p): New function.
5225 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5226 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5227 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5228
5229 * image.c: Include w32.h.
5230 (Vimage_type_cache): Delete.
5231 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5232 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5233 (w32_delayed_load): Move to w32.c.
5234
5235 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5236
5237 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5238 (w32_delayed_load): Move from image.c. When loading a library, record
5239 its filename in the :loaded-from property of the library id.
5240 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5241 Initialize and staticpro them.
5242 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5243
5244 * process.c: Include lisp.h before w32.h, not after.
5245 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5246 instead of gnutls_record_check_pending.
5247
5248 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5249
ff4de4aa
TZ
52502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5251
5252 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5253 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5254 as passed in.
5255
abe95abb
JD
52562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5257
5258 * xterm.c (x_set_frame_alpha): Do not set property on anything
5259 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5260
e16e55d4
JB
52612011-05-02 Juanma Barranquero <lekktu@gmail.com>
5262
5263 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5264
bafcf6a5
JB
52652011-05-02 Juanma Barranquero <lekktu@gmail.com>
5266
5267 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5268 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5269 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5270 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5271 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5272 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5273 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5274 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5275 (Qgnutls_bootprop_callbacks_verify): Make static.
5276
e7a6747f
AS
52772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5278
19ed11ba
AS
5279 * callproc.c: Indentation fixup.
5280
e7a6747f 5281 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5282 (wait_for_termination, interruptible_wait_for_termination):
5283 Move after wait_for_termination_1.
e7a6747f 5284
1ef14cb4
LMI
52852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5286
5287 * sysdep.c (interruptible_wait_for_termination): New function
5288 which is like wait_for_termination, but allows keyboard
5289 interruptions.
5290
5291 * callproc.c (Fcall_process): Add (:file "file") as an option for
5292 the STDOUT buffer.
5293 (Fcall_process_region): Ditto.
5294
330d880c
EZ
52952011-04-30 Eli Zaretskii <eliz@gnu.org>
5296
8db90b73
EZ
5297 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5298 rather than `XVECTOR (FOO)->size'.
5299
330d880c
EZ
5300 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5301 inttypes.h, as a gnulib replacement is used if it not available in
5302 system headers.
5303
15cbd324
EZ
53042011-04-21 Eli Zaretskii <eliz@gnu.org>
5305
5306 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5307 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5308 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5309
5310 * coding.c (coding_alloc_by_realloc): Error out if destination
5311 will grow beyond MOST_POSITIVE_FIXNUM.
5312 (decode_coding_emacs_mule): Abort if there isn't enough place in
5313 charbuf for the composition carryover bytes. Reserve an extra
5314 space for up to 2 characters produced in a loop.
5315 (decode_coding_iso_2022): Abort if there isn't enough place in
5316 charbuf for the composition carryover bytes.
5317
53182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5319
ae940cca
EZ
5320 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5321 aborting when %lld or %lll format is passed.
5322 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5323 %llo or %llx format is passed. (Bug#8545)
5324
03ab8921
EZ
5325 * window.c (window_scroll_line_based): Use a marker instead of
5326 simple variables to record original value of point. (Bug#7952)
5327
afda1437
EZ
5328 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5329 produced by %s or %c overflows available buffer space. (Bug#8545)
5330
f76dee0c
PE
53312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5334 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5335
fdc5744d
JB
53362011-04-28 Juanma Barranquero <lekktu@gmail.com>
5337
5338 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5339
638f053a
JB
53402011-04-28 Juanma Barranquero <lekktu@gmail.com>
5341
5342 * keyboard.c (Qdelayed_warnings_hook): Define.
5343 (command_loop_1): Run `delayed-warnings-hook'
5344 if Vdelayed_warnings_list is non-nil.
5345 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5346 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5347
d178f871
EZ
53482011-04-28 Eli Zaretskii <eliz@gnu.org>
5349
5350 * doprnt.c (doprnt): Don't return value smaller than the buffer
5351 size if the message was truncated. (Bug#8545).
5352
b124fd93
JB
53532011-04-28 Juanma Barranquero <lekktu@gmail.com>
5354
5355 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5356 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5357
e810457d
PE
53582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5359
5360 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5361
ea51cceb
JB
53622011-04-27 Juanma Barranquero <lekktu@gmail.com>
5363
5364 * makefile.w32-in: Update dependencies.
5365
94dcfacf
EZ
53662011-04-27 Eli Zaretskii <eliz@gnu.org>
5367
5368 Improve `doprnt' and its usage. (Bug#8545)
5369 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5370 `format_end'. Remove support for %l as a conversion specifier.
5371 Don't use xrealloc. Improve diagnostics when the %l size modifier
5372 is used. Update the commentary.
5373
5374 * eval.c (verror): Simplify calculation of size_t.
5375
5376 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5377 messages.
5378
f61f41d7
PE
53792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5380
5381 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5382 change.
5383
96fb4434
PE
53842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5385
5386 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5387 This makes this file independent of the recent pseudovector change.
5388
671875da 53892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5390
69e9b5a3
PE
5391 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5392
b5f869a7 5393 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5394 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5395 Remove unused local.
c8926152 5396 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5397
841a1577 5398 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5399 GCC 4.6.0 optimizes based on type-based alias analysis.
5400 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5401 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5402 != &v->size, and therefore "v->size = 1; b->size = 2; return
5403 v->size;" must therefore return 1. This assumption is incorrect
5404 for Emacs, since it type-puns struct Lisp_Vector * with many other
5405 types. To fix this problem, this patch adds a new type struct
f904488f 5406 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5407 and pseudovectors, and helps optimizing compilers not get fooled
5408 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5409 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5410 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5411 the size member.
eab3844f
PE
5412 (XSETPVECTYPE): Rewrite in terms of new macro.
5413 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5414 This is a bit clearer, and further avoids the possibility of
5415 undesirable aliasing.
5416 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5417 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5418 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5419 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5420 (ASIZE): Now uses header.size rather than size.
5421 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5422 to avoid the hassle of writing XVECTOR (foo)->header.size.
5423 (struct vectorlike_header): New type.
eab3844f
PE
5424 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5425 object, to help avoid aliasing.
5426 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5427 (SUBRP): Likewise, since Lisp_Subr is a special case.
5428 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5429 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5430 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5431 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5432 changed to be "header.size" and "header.next".
5433 * buffer.h (struct buffer): Likewise.
5434 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5435 * frame.h (struct frame): Likewise.
5436 * process.h (struct Lisp_Process): Likewise.
5437 * termhooks.h (struct terminal): Likewise.
5438 * window.c (struct save_window_data, struct saved_window): Likewise.
5439 * window.h (struct window): Likewise.
5440 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5441 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5442 * buffer.c (init_buffer_once): Likewise.
5443 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5444 special case.
5445 * process.c (Fformat_network_address): Use local var for size,
5446 for brevity.
5447
0df1eac5
PE
5448 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5449
847ab9d1 5450 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5451 * data.c (atof): Remove decl; no longer used or needed.
5452 (digit_to_number): Move to lread.c.
5453 (Fstring_to_number): Use new string_to_number function, to be
5454 consistent with how the Lisp reader treats infinities and NaNs.
5455 Do not assume that floating-point numbers represent EMACS_INT
5456 without losing information; this is not true on most 64-bit hosts.
5457 Avoid double-rounding errors, by insisting on integers when
5458 parsing non-base-10 numbers, as the documentation specifies.
5459 * lisp.h (string_to_number): New decl, replacing ...
5460 (isfloat_string): Remove.
bc0a5c13 5461 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5462 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5463 appears to have been a coding error. Similarly, do not accept
5464 strings like +-1e0 as floating point numbers. Do not report
5465 overflow for integer overflows unless the base is not 10 which
5466 means we have no simple and reliable way to continue.
5467 Break out the floating-point parsing into a new
5468 function string_to_number, so that Fstring_to_number parses
5469 floating point numbers consistently with the Lisp reader.
04f2d78b 5470 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5471 (E_CHAR, EXP_INT): Remove, replacing with ...
5472 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5473 (string_to_number): New function, replacing isfloat_string.
5474 This function checks for valid syntax and produces the resulting
5475 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5476 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5477 so that overflow for non-base-10 numbers is reported only when
5478 there's no portable and simple way to convert to floating point.
452f4150 5479
67769ffc
PE
5480 * textprop.c (set_text_properties_1): Rewrite for clarity,
5481 and to avoid GCC warning about integer overflow.
5482
c20db43f
PE
5483 * intervals.h (struct interval): Use EMACS_INT for members
5484 where EMACS_UINT might cause problems. See
5485 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5486 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5487 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5488 All uses changed.
37aa2f85
PE
5489 (offset_intervals): Tell GCC not to worry about length overflow
5490 when negating a negative length.
c20db43f 5491
2538aa2f
PE
5492 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5493 (overrun_check_free): Likewise.
5494
f2d3008d
PE
5495 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5496 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5497 word size.
5498
ec8df744
PE
5499 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5500 (gnutls_make_error): Rename local to avoid shadowing.
5501 (gnutls_emacs_global_deinit): ifdef out; not used.
5502 (Fgnutls_boot): Use const for pointer to readonly storage.
5503 Comment out unused local. Fix pointer signedness problems.
5504
640ee02d
PE
5505 * lread.c (openp): Don't stuff size_t into an 'int'.
5506 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5507 about possible signed overflow.
5508
6048fb2a
PE
5509 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5510 (GDK_KEY_g): Don't define if already defined.
5511 (xg_prepare_tooltip): Avoid pointer signedness problem.
5512 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5513
fa3c87e1
PE
5514 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5515 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5516
2172544b
PE
5517 * xfns.c (Fx_window_property): Simplify a bit,
5518 to make a bit faster and to avoid GCC 4.6.0 warning.
5519 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5520
9b821a21
PE
5521 * fns.c (internal_equal): Don't assume size_t fits in int.
5522
3c616cfa
PE
5523 * alloc.c (compact_small_strings): Tighten assertion a little.
5524
c2982e87
PE
5525 Replace pEd with more-general pI, and fix some printf arg casts.
5526 * lisp.h (pI): New macro, generalizing old pEd macro to other
5527 conversion specifiers. For example, use "...%"pI"d..." rather
5528 than "...%"pEd"...".
5529 (pEd): Remove. All uses replaced with similar uses of pI.
5530 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5531 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5532 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5533 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5534 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5535 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5536 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5537 64-bit hosts.
5538 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5539 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5540 * print.c (safe_debug_print, print_object): Likewise.
5541 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5542 to int.
6f04d126
PE
5543 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5544 avoiding the 0 flag, which is not portable.
c2982e87
PE
5545 * process.c (Fmake_network_process): Use pI to avoid cast.
5546 * region-cache.c (pp_cache): Likewise.
5547 * xdisp.c (decode_mode_spec): Likewise.
5548 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5549 behavior on 64-bit hosts with printf arg.
6f04d126 5550 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5551 (x_stop_queuing_selection_requests): Likewise.
5552 (x_get_window_property): Don't truncate byte count to an 'int'
5553 when tracing.
0b432f21 5554
5e073ec7
PE
5555 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5556 here, since it parses constructs like leading '-' and spaces,
5557 which are not wanted; and it overflows with large numbers.
5558 Instead, simply match F[0-9]+, which is what is wanted anyway.
5559
36372bf9
PE
5560 * alloc.c: Remove unportable assumptions about struct layout.
5561 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5562 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5563 (allocate_vectorlike, make_pure_vector): Use the new macros,
5564 plus offsetof, to remove unportable assumptions about struct layout.
5565 These assumptions hold on all porting targets that I know of, but
5566 they are not guaranteed, they're easy to remove, and removing them
5567 makes further changes easier.
5568
0b432f21
PE
5569 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5570 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5571 (string_overrun_cookie): Now const. Use initializers that
5572 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5573 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5574 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5575 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5576 multiple of sizeof (EMACS_INT); it need not be, if
5577 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5578 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5579
895009e1
JB
55802011-04-26 Juanma Barranquero <lekktu@gmail.com>
5581
5582 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5583
6a7a1b0b
TZ
55842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5585
5586 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5587 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5588 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5589
841a1577 55902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5591
5592 * lisp.h (Qdebug): List symbol.
895009e1 5593 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5594 * keyboard.c (debug-on-event): New variable.
5595 (handle_user_signal): Break into debugger when debug-on-event
5596 matches the current signal symbol.
5597
f2d3ba6f
DN
55982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5599
5600 * alloc.c (check_sblock, check_string_bytes)
5601 (check_string_free_list): Convert to standard C.
5602
42ce4c63
TZ
56032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5604
5605 * w32.c (emacs_gnutls_push): Fix typo.
5606
825cd63c
EZ
56072011-04-25 Eli Zaretskii <eliz@gnu.org>
5608
fb11d64d
EZ
5609 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5610 "cast to pointer from integer of different size".
5611
825cd63c
EZ
5612 Improve doprnt and its use in verror. (Bug#8545)
5613 * doprnt.c (doprnt): Document the set of format control sequences
5614 supported by the function. Use SAFE_ALLOCA instead of always
5615 using `alloca'.
5616
5617 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5618 is one byte too soon. Don't use xrealloc; instead xfree and
5619 xmalloc anew.
5620
e061a11b
TZ
56212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5622
5623 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5624 callbacks stage.
5625
5626 * gnutls.c: Renamed global_initialized to
5627 gnutls_global_initialized. Added internals for the
5628 :verify-hostname-error, :verify-error, and :verify-flags
5629 parameters of `gnutls-boot' and documented those parameters in the
5630 docstring. Start callback support.
9173deec
JB
5631 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5632 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5633 on error. Return error code.
e061a11b
TZ
5634 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5635 (emacs_gnutls_read): Likewise.
5636 (Fgnutls_boot): Return handshake error code.
5637 (emacs_gnutls_handle_error): New function.
5638 (wsaerror_to_errno): Likewise.
5639
5640 * w32.h (emacs_gnutls_pull): Add prototype.
5641 (emacs_gnutls_push): Likewise.
5642
5643 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5644 (emacs_gnutls_push): Likewise.
5645
56462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5647
5648 * process.c (wait_reading_process_output): Check if GnuTLS
5649 buffered some data internally if no FDs are set for TLS
5650 connections.
5651
5652 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5653 (LIBS): Link to USER_LIBS.
5654 ($(BLD)/gnutls.$(0)): New target.
5655
fa6996bc
EZ
56562011-04-24 Eli Zaretskii <eliz@gnu.org>
5657
eb35682e
EZ
5658 * xdisp.c (handle_single_display_spec): Rename the
5659 display_replaced_before_p argument into display_replaced_p, to
5660 make it consistent with the commentary. Fix typos in the
5661 commentary.
5662
e2ad650c
EZ
5663 * textprop.c (syms_of_textprop): Remove dead code.
5664 (copy_text_properties): Delete obsolete commentary about an
5665 interface that was deleted long ago. Fix typos in the description
5666 of arguments.
5667
1b2de274
EZ
5668 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5669 to changes in oldXMenu/XMenu.h from 2011-04-16.
5670 <menu_help_message, prev_menu_help_message>: Constify.
5671 (IT_menu_make_room): menu->help_text is now `const char **';
5672 adjust.
5673
5674 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5675 to changes in oldXMenu/XMenu.h from 2011-04-16.
5676 (struct XMenu): Declare `help_text' `const char **'.
5677
5678 * xfaces.c <Qunspecified>: Make extern again.
5679
5680 * syntax.c: Include sys/types.h before including regex.h, as
5681 required by Posix.
5682
762b15be
EZ
5683 * doc.c (get_doc_string): Improve the format passed to `error'.
5684
5685 * doprnt.c (doprnt): Improve commentary.
5686
5687 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5688
5689 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5690 them with etags.
5691
f1052e5d
EZ
5692 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5693 changes in globals.h immediately force recompilation.
762b15be
EZ
5694 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5695 $(CURDIR)/s/ms-w32.h.
5696 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5697
fa6996bc
EZ
5698 * character.c (Fchar_direction): Function deleted.
5699 (syms_of_character): Don't defsubr it.
5700 <char-direction-table>: Deleted.
5701
e6c3da20
EZ
57022011-04-23 Eli Zaretskii <eliz@gnu.org>
5703
5704 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5705 * doprnt.c: Include limits.h.
5706 (SIZE_MAX): New macro.
04f2d78b
CB
5707 (doprnt): Return a size_t value. 2nd arg is now size_t.
5708 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5709 Improve overflow protection. Support `l' modifier for integer
5710 conversions. Support %l conversion. Don't assume an EMACS_INT
5711 argument for integer conversions and for %c.
5712
5713 * lisp.h (doprnt): Restore prototype.
5714
5715 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5716 $(SRC)/character.h.
5717
5718 * Makefile.in (base_obj): Add back doprnt.o.
5719
5720 * deps.mk (doprnt.o): Add back prerequisites.
5721 (callint.o): Depend on character.h.
5722
5723 * eval.c (internal_lisp_condition_case): Include the handler
5724 representation in the error message.
5725 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5726 when breaking from the loop.
5727
5728 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5729
5730 * callint.c (Fcall_interactively): When displaying error message
5731 about invalid control letter, pass the character's codepoint, not
5732 a pointer to its multibyte form. Improve display of the character
5733 in octal and display also its hex code.
5734
5735 * character.c (char_string): Use %x to display the (unsigned)
5736 codepoint of an invalid character, to avoid displaying a bogus
5737 negative value.
5738
5739 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5740 `error', not SYMBOL_NAME itself.
5741
5742 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5743 character arguments to `error'.
5744
5745 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5746 to `error' in error message about FINAL_CHAR argument. Make sure
5747 FINAL_CHAR is a character, and use %c when it is passed as
5748 argument to `error'.
5749
4ffd0d6b 57502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5751
5752 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5753
5754 * w32.c: Include <time.h>.
5755 (sys_localtime): New function.
5756
4ffd0d6b 57572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5758
5759 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5760
4ffd0d6b 5761 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5762
4ffd0d6b 57632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5764
4ffd0d6b
GM
5765 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5766 zombies (Bug#8467).
aac0c6e3 5767
04c56954
EZ
57682011-04-19 Eli Zaretskii <eliz@gnu.org>
5769
5770 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5771 gl_state.e_property when gl_state.object is Qt.
5772
5773 * insdel.c (make_gap_larger): Remove limitation of buffer size
5774 to <= INT_MAX.
5775
16a43933
CY
57762011-04-18 Chong Yidong <cyd@stupidchicken.com>
5777
5778 * xdisp.c (lookup_glyphless_char_display)
5779 (produce_glyphless_glyph): Handle cons cell entry in
5780 glyphless-char-display.
5781 (Vglyphless_char_display): Document it.
5782
5783 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5784 glyphless-char-display.
5785
4581706e
CY
57862011-04-17 Chong Yidong <cyd@stupidchicken.com>
5787
5788 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5789
5790 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5791
5792 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5793 definition for no-X builds.
5794
4887c6e2 57952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5796
fd35b6f9
PE
5797 Static checks with GCC 4.6.0 and non-default toolkits.
5798
5c1ccb01
PE
5799 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5800
006c5daa
PE
5801 * process.c (keyboard_bit_set): Define only if SIGIO.
5802 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5803 (send_process): Repair possible setjmp clobbering.
5804
efc736d3
PE
5805 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5806
4e2fe2e6
PE
5807 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5808
f97334a2
PE
5809 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5810
4e75f29d
PE
5811 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5812 Define only if needed.
5813
90efadd1
PE
5814 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5815 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5816 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5817
3c647824
PE
5818 * dispextern.h (struct redisplay_interface): Rename param
5819 to avoid shadowing.
e264f262 5820 * termhooks.h (struct terminal): Likewise.
761383f4 5821 * xterm.c (xembed_send_message): Likewise.
3c647824 5822
b58c5c4a
PE
5823 * insdel.c (make_gap_smaller): Define only if
5824 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5825
cad59032
PE
5826 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5827 it.
5828
c339dc2e
PE
5829 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5830 so that we aren't warned about unused symbols.
5831
91a3e27b
PE
5832 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5833
399c71d3 5834 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5835
8ffc96f5
PE
5836 * xfns.c (x_real_positions): Mark locals as initialized.
5837
eef9bc79
PE
5838 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5839
098db9dd
PE
5840 * xterm.c: Fix problems found by static analysis with other toolkits.
5841 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5842 (x_dispatch_event): Declare static if USE_GTK, and
5843 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5844 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5845 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5846 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5847 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5848
eb18f6cc
PE
5849 * xmenu.c (menu_help_callback): Pointer type fixes.
5850 Use const pointers when pointing at readonly data. Avoid pointer
5851 signedness clashes.
5852 (FALSE): Remove unused macro.
5853 (update_frame_menubar): Remove unused decl.
5854
1fe72bf8
PE
5855 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5856
60d9e1db
PE
5857 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5858 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5859 (single_menu_item): Rename local to avoid shadowing.
5860
39261c26
PE
5861 * keyboard.c (make_lispy_event): Remove unused local var.
5862
018c5e19
PE
5863 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5864 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5865
63d2b86e
PE
5866 * bitmaps: Change bitmaps from unsigned char back to the X11
5867 compatible char. Avoid the old compiler warnings about
5868 out-of-range initializers by using, for example, '\xab' rather
5869 than 0xab.
5870
aefd87e1
PE
5871 * xgselect.c (xgselect_initialize): Check vs interface
5872 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5873
bf501fb9
PE
5874 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5875
e9829fdf
PE
5876 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5877 to read-only memory.
5878
1086c095
PE
5879 * fns.c (vector): Remove; this old hack is no longer needed.
5880
2baccd04 5881 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5882 Remove unused var.
dde42981 5883 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5884
72391843 5885 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5886
436c16df 5887 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5888 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5889 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5890
92bb796d 5891 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5892 (x_term_init): Remove local to avoid shadowing.
92bb796d 5893
764430a3 5894 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5895
5896 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5897 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5898
d1dfb56c
EZ
58992011-04-16 Eli Zaretskii <eliz@gnu.org>
5900
c4354cb4
EZ
5901 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5902
d1dfb56c
EZ
5903 Fix regex.c, syntax.c and friends for buffers > 2GB.
5904 * syntax.h (struct gl_state_s): Declare character position members
5905 EMACS_INT.
5906
5907 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5908
04f2d78b
CB
5909 * textprop.c (verify_interval_modification, interval_of):
5910 Declare arguments EMACS_INT.
d1dfb56c
EZ
5911
5912 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5913 EMACS_INT.
5914
5915 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5916
5917 * indent.c (Fvertical_motion): Local variable it_start is now
5918 EMACS_INT.
5919
5920 * regex.c (re_match, re_match_2, re_match_2_internal)
5921 (bcmp_translate, regcomp, regexec, print_double_string)
5922 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5923 (re_compile_pattern, re_exec): Declare arguments and local
5924 variables `size_t' and `ssize_t' and return values `regoff_t', as
5925 appropriate.
5926 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5927 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5928 <compile_stack_type>: `size' and `avail' are now `size_t'.
5929
5930 * regex.h <regoff_t>: Use ssize_t, not int.
5931 (re_search, re_search_2, re_match, re_match_2): Arguments that
5932 specify buffer/string position and length are now ssize_t and
5933 size_t. Return type is regoff_t.
5934
613052cd
BK
59352011-04-16 Ben Key <bkey76@gmail.com>
5936
5937 * nsfont.m: Fixed bugs in ns_get_family and
5938 ns_descriptor_to_entity that were caused by using free to
5939 deallocate memory blocks that were allocated by xmalloc (via
5940 xstrdup). This caused Emacs to crash when compiled with
5941 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5942 --enable-checking=xmallocoverrun). xfree is now used to
5943 deallocate these memory blocks.
5944
4170f62f 59452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5946
71b41406
PE
5947 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5948
9587a89d
PE
5949 emacs_write: Accept and return EMACS_INT for sizes.
5950 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5951 et seq.
5952 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5953 Accept and return EMACS_INT.
5954 (emacs_gnutls_write): Return the number of bytes written on
5955 partial writes.
5956 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5957 (emacs_read, emacs_write): Remove check for negative size, as the
5958 Emacs source code has been audited now.
9587a89d
PE
5959 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5960 (emacs_read, emacs_write): Use it.
273a5f82
PE
5961 * process.c (send_process): Adjust to the new signatures of
5962 emacs_write and emacs_gnutls_write. Do not attempt to store
5963 a byte offset into an 'int'; it might overflow.
9587a89d 5964 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5965
3e047f51
PE
5966 * sound.c: Don't assume sizes fit in 'int'.
5967 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5968 Return EMACS_INT, not int.
3e047f51 5969 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5970 Accept EMACS_INT, not int.
5971 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5972 record read return values.
5973
cc39a9db
BK
59742011-04-15 Ben Key <bkey76@gmail.com>
5975
c9d0ec6d
JB
5976 * keyboard.c (Qundefined): Don't declare static since it is used
5977 in nsfns.m.
5978 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5979 static since they are used in nsfont.m.
cc39a9db 5980
6c60eb9f
SM
59812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5982
5983 * process.c (Qprocessp): Don't declare static.
5984 * lisp.h (Qprocessp): Declare again.
5985
7990b61a
JB
59862011-04-15 Juanma Barranquero <lekktu@gmail.com>
5987
5988 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5989
5d4cb038
PE
59902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5991
8bd7b830 5992 Improve C-level modularity by making more things 'static'.
cd64ea1d 5993
e3b27b31
PE
5994 Don't publish debugger-only interfaces to other modules.
5995 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5996 (verify_bytepos, count_markers): Move decls to the only modules
5997 that need them.
5998 * region-cache.h (pp_cache): Likewise.
5999 * window.h (check_all_windows): Likewise.
6000 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6001
5d4cb038
PE
6002 * sysdep.c (croak): Now static, if
6003 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6004 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6005
6006 * alloc.c (refill_memory_reserve): Now static if
6007 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6008 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6009
e87b6180
PE
6010 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6011 Define only if USE_LUCID.
6012
ac64929e
PE
6013 * xrdb.c (x_customization_string, x_rm_string): Now static.
6014
6f37259d
PE
6015 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6016 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6017
1683e3ab
PE
6018 * xdisp.c (draw_row_with_mouse_face): Now static.
6019 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6020
de9c2632
PE
6021 * window.h (check_all_windows): Mark externally visible.
6022
2b96acb7
PE
6023 * window.c (window_deletion_count): Now static.
6024
6025 * undo.c: Make symbols static if they're not exported.
6026 (last_undo_buffer, last_boundary_position, pending_boundary):
6027 Now static.
6028
50436f33
PE
6029 * textprop.c (interval_insert_behind_hooks): Now static.
6030 (interval_insert_in_front_hooks): Likewise.
6031
64520e5c
PE
6032 * term.c: Make symbols static if they're not exported.
6033 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6034 (max_frame_lines, tty_set_terminal_modes):
6035 (tty_reset_terminal_modes, tty_turn_off_highlight):
6036 (get_tty_terminal): Now static.
6037 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6038 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6039 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6040 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6041 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6042
1fa53021
PE
6043 * sysdep.c: Make symbols static if they're not exported.
6044 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6045 Now static.
6046 (sigprocmask_set, full_mask): Remove; unused.
6047 (wait_debugging): Mark as visible.
6048 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6049 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6050
d4b43b22
PE
6051 * syntax.c (syntax_temp): Define only if !__GNUC__.
6052
b7c513d0
PE
6053 * sound.c (current_sound_device, current_sound): Now static.
6054
989b29ad
PE
6055 * search.c (searchbufs, searchbuf_head): Now static.
6056
13a55a78
PE
6057 * scroll.c (scroll_cost): Remove; unused.
6058 * dispextern.h (scroll_cost): Remove decl.
6059
de68a1fc
PE
6060 * region-cache.h (pp_cache): Mark as externally visible.
6061
40ccffa6
PE
6062 * process.c: Make symbols static if they're not exported.
6063 (process_tick, update_tick, create_process, chan_process):
6064 (Vprocess_alist, proc_buffered_char, datagram_access):
6065 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6066 (deactivate_process): Mark defn as static, as well as decl.
6067 * lisp.h (create_process): Remove decl.
6068 * process.h (chan_process, Vprocess_alist): Remove decls.
6069
ad64fc97
PE
6070 * print.c: Make symbols static if they're not exported.
6071 (print_depth, new_backquote_output, being_printed, print_buffer):
6072 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6073 (print_interval, print_number_index, initial_stderr_stream):
6074 Now static.
6075 * lisp.h (Fprinc): Remove decl.
6076 (debug_output_compilation_hack): Mark as externally visible.
6077
adddb265
PE
6078 * sysdep.c (croak): Move decl from here to syssignal.h.
6079 * syssignal.h (croak): Put it here, so the API can be checked when
6080 'croak' is called from dissociate_if_controlling_tty.
6081
1717ede2
PE
6082 * minibuf.c: Make symbols static if they're not exported.
6083 (minibuf_save_list, choose_minibuf_frame): Now static.
6084 * lisp.h (choose_minibuf_frame): Remove decl.
6085
fa5fb2bc
PE
6086 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6087
1e3890d1
PE
6088 * lread.c: Make symbols static if they're not exported.
6089 (read_objects, initial_obarray, oblookup_last_bucket_number):
6090 Now static.
6091 (make_symbol): Remove; unused.
6092 * lisp.h (initial_obarray, make_symbol): Remove decls.
6093
8a1414fa
PE
6094 * keyboard.c: Make symbols static if they're not exported.
6095 (single_kboard, recent_keys_index, total_keys, recent_keys):
6096 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6097 (this_single_command_key_start, echoing, last_auto_save):
6098 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6099 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6100 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6101 (Vlispy_mouse_stem, double_click_count):
6102 Now static.
6103 (force_auto_save_soon): Define only if SIGDANGER.
6104 (ignore_mouse_drag_p): Now static if
6105 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6106 (print_help): Remove; unused.
6107 (stop_character, last_timer_event): Mark as externally visible.
6108 * keyboard.h (ignore_mouse_drag_p): Declare only if
6109 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6110 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6111 * lisp.h (echoing): Remove decl.
6112 (force_auto_save_soon): Declare only if SIGDANGER.
6113 * xdisp.c (redisplay_window): Simplify code, to make it more
6114 obvious that ignore_mouse_drag_p is not accessed if !defined
6115 USE_GTK && !defined HAVE_NS.
6116
93ea6e8f
PE
6117 * intervals.c: Make symbols static if they're not exported.
6118 (merge_properties_sticky, merge_interval_right, delete_interval):
6119 Now static.
6120 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6121
77382fcc
PE
6122 * insdel.c: Make symbols static if they're not exported.
6123 However, leave prepare_to_modify_buffer alone. It's never
6124 called from outside this function, but that appears to be a bug.
6125 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6126 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6127 (adjust_after_replace_noundo): Remove; unused.
6128 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6129 (signal_before_change): Remove decls.
77382fcc 6130
9306c32e
PE
6131 * indent.c (val_compute_motion, val_vmotion): Now static.
6132
cd44d2eb
PE
6133 * image.c: Make symbols static if they're not exported.
6134 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6135 if USE_GTK.
6136 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6137 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6138
ad9a7a06
PE
6139 * fringe.c (standard_bitmaps): Now static.
6140 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6141
81626931
PE
6142 * frame.c: Make symbols static if they're not exported.
6143 (x_report_frame_params, make_terminal_frame): Now static.
6144 (get_frame_param): Now static, unless HAVE_NS.
6145 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6146 (x_get_resource_string): Remove; not used.
6147 * frame.h (make_terminal_frame, x_report_frame_params):
6148 (x_get_resource_string); Remove decls.
6149 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6150 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6151
239f9db9
PE
6152 * font.c, fontset.c: Make symbols static if they're not exported.
6153 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6154 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6155 * font.c (font_close_object): Now static.
6156 * font.h (font_close_object): Remove.
6157 * fontset.c (FONTSET_OBJLIST): Remove.
6158 (free_realized_fontset) #if-0 the body, which does nothing.
6159 (face_suitable_for_char_p): #if-0, as it's never called.
6160 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6161 * xfaces.c (face_at_string_position):
6162 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6163 since 0 is always ASCII.
6164
dfcf3579
PE
6165 * fns.c (weak_hash_tables): Now static.
6166
5045092b
PE
6167 * fileio.c: Make symbols static if they're not exported.
6168 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6169 (Vwrite_region_annotation_buffers): Now static.
6170
57a96f5c
PE
6171 * eval.c: Make symbols static if they're not exported.
6172 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6173 * lisp.h (backtrace_list): Remove decl.
6174
35f08c38
PE
6175 * emacs.c: Make symbols static if they're not exported.
6176 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6177 (fatal_error_code, fatal_error_signal_hook, standard_args):
6178 Now static.
6179 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6180 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6181 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6182 * lisp.h (fatal_error_signal_hook): Remove decl.
6183 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6184
f44bd759
PE
6185 * editfns.c: Move a (normally-unused) function to its only use.
6186 * editfns.c, lisp.h (get_operating_system_release): Remove.
6187 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6188 worth the hassle of breaking this out.
6189
b532497d
PE
6190 * xterm.c: Make symbols static if they're not exported.
6191 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6192 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6193 (x_destroy_window, x_delete_display):
6194 Now static.
6195 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6196 (x_mouse_leave): Remove; unused.
6197 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6198 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6199 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6200 Remove decls.
6201 (x_mouse_leave): Declare only if WINDOWSNT.
6202 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6203 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6204 USE_X_TOOLKIT.
6205
1675728f
PE
6206 * ftxfont.c: Make symbols static if they're not exported.
6207 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6208 HAVE_FREETYPE.
6209 * font.h (ftxfont_driver): Likewise.
6210
e4cebfca
PE
6211 * xfns.c: Make symbols static if they're not exported.
6212 (x_last_font_name, x_display_info_for_name):
6213 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6214 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6215 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6216 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6217 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6218 (last_show_tip_args): Now static.
6219 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6220 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6221 (x_screen_planes): Remove; unused.
6222 * dispextern.h (x_screen_planes): Remove decl.
6223
5bf46f05
PE
6224 * dispnew.c: Make symbols static if they're not exported.
6225 * dispextern.h (redraw_garbaged_frames, scrolling):
6226 (increment_row_positions): Remove.
6227 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6228 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6229 Now static.
6230 (redraw_garbaged_frames): Remove; unused.
6231
435f4c28
PE
6232 * xfaces.c: Make symbols static if they're not exported.
6233 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6234 Remove decls.
6235 * xterm.h (defined_color): Remove decls.
6236 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6237 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6238 (menu_face_changed_default, defined_color, free_realized_face):
6239 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6240 (ascii_face_of_lisp_face): Remove; unused.
6241
8524aef3
PE
6242 * xdisp.c: Make symbols static if they're not exported.
6243 * dispextern.h (scratch_glyph_row, window_box_edges):
6244 (glyph_to_pixel_coords, set_cursor_from_row):
6245 (get_next_display_element, set_iterator_to_next):
6246 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6247 (show_mouse_face): Remove decls
6248 * frame.h (message_buf_print): Likewise.
6249 * lisp.h (pop_message, set_message, check_point_in_composition):
6250 Likewise.
6251 * xterm.h (set_vertical_scroll_bar): Likewise.
6252 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6253 (message_buf_print, scratch_glyph_row, displayed_buffer):
6254 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6255 (get_next_display_element, show_mouse_face, window_box_edges):
6256 (frame_to_window_pixel_xy, check_point_in_composition):
6257 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6258 (glyph_to_pixel_coords): Remove; unused.
6259
16390cd2
PE
6260 * dired.c (file_name_completion): Now static.
6261
6262 * dbusbind.c (xd_in_read_queued_messages): Now static.
6263
a25f4dfa
PE
6264 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6265 * data.c (circular_list_error): Remove.
6266
14a9c8df
PE
6267 * commands.h (last_point_position, last_point_position_buffer):
6268 (last_point_position_window): Remove decls.
6269 * keyboard.c: Make these variables static.
6270
04f2d78b
CB
6271 * coding.h (coding, code_convert_region, encode_coding_gap):
6272 Remove decls.
74ab6df5
PE
6273 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6274 (iso_code_class, detect_coding, code_convert_region): Now static.
6275 (encode_coding_gap): Remove; unused.
6276
38dfbee1
PE
6277 * chartab.c (chartab_chars, chartab_bits): Now static.
6278
a2cb4e63
PE
6279 * charset.h (charset_iso_8859_1): Remove decl.
6280 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6281 Now static.
6282
127198fd
PE
6283 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6284 * ccl.c (Vccl_program_table): Now static.
6285 (check_ccl_update): Remove; unused.
6286
d85b608f
PE
6287 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6288 * category.h: ... from here.
6289 * category.c (check_category_table, set_category_set): Now static.
6290
31cd66f3
PE
6291 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6292 * lisp.h: Remove these decls.
6293
c358e587
PE
6294 * buffer.c (buffer_count): Remove unused var.
6295
e78aecca
PE
6296 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6297 so that it's not optimized away.
6298 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6299 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6300 exported only to the debugger.
6301
e192d7d3 6302 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6303 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6304
92470028
PE
6305 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6306 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6307 was inaccessible from Lisp.
6308 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6309 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6310
244ed907
PE
6311 alloc.c: Import and export fewer symbols, and remove unused items.
6312 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6313 is defined.
6314 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6315 it's not optimized away by whole-program optimization.
6316 (message_enable_multibyte, free_misc): Remove.
6317 (catchlist, handlerlist, mark_backtrace):
6318 Declare only if BYTE_MARK_STACK.
6319 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6320 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6321 (message_enable_multibyte): Remove decl.
6322 (free_misc, interval_free_list, float_block, float_block_index):
6323 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6324 (cons_free_list, last_marked_index):
6325 Now static.
6326 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6327 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6328 (mark_backtrace): Define only if BYTE_MARK_STACK.
6329 * xdisp.c (message_enable_multibyte): Now static.
6330
61c2b50e 6331 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6332 This makes it easier for human readers (and static analyzers)
6333 to see whether these variables are used from other modules.
6334 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6335 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6336 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6337 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6338 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6339 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6340 * xmenu.c, xselect.c:
6341 Declare Q* vars static if they are not used in other modules.
6342 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6343 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6344 Remove decls of unexported vars.
6345 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6346
95c82688
PE
6347 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6348
16a97296
PE
6349 Make Emacs functions such as Fatom 'static' by default.
6350 This makes it easier for human readers (and static analyzers)
6351 to see whether these functions can be called from other modules.
6352 DEFUN now defines a static function. To make the function external
6353 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6354 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6355 (Finit_image_library):
16a97296
PE
6356 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6357 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6358 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6359 Remove decls, since these functions are now static.
6360 (Funintern, Fget_internal_run_time): New decls, since these functions
6361 were already external.
95c82688 6362
16a97296
PE
6363 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6364 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6365 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6366 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6367 * keyboard.c, keymap.c, lread.c:
6368 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6369 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6370 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6371 Mark functions with DEFUE instead of DEFUN,
6372 if they are used in other modules.
6373 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6374 decls for now-static functions.
6375 * buffer.h (Fdelete_overlay): Remove decl.
6376 * callproc.c (Fgetenv_internal): Mark as internal.
6377 * composite.c (Fremove_list_of_text_properties): Remove decl.
6378 (Fcomposition_get_gstring): New forward static decl.
6379 * composite.h (Fcomposite_get_gstring): Remove decl.
6380 * dired.c (Ffile_attributes): New forward static decl.
6381 * doc.c (Fdocumntation_property): New forward static decl.
6382 * eval.c (Ffetch_bytecode): New forward static decl.
6383 (Funintern): Remove extern decl; now in .h file where it belongs.
6384 * fileio.c (Fmake_symbolic_link): New forward static decl.
6385 * image.c (Finit_image_library): New forward static decl.
6386 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6387 * intervals.h (Fprevious_property_change):
6388 (Fremove_list_of_text_properties): Remove decls.
6389 * keyboard.c (Fthis_command_keys): Remove decl.
6390 (Fcommand_execute): New forward static decl.
6391 * keymap.c (Flookup_key): New forward static decl.
6392 (Fcopy_keymap): Now static.
6393 * keymap.h (Flookup_key): Remove decl.
6394 * process.c (Fget_process): New forward static decl.
6395 (Fprocess_datagram_address): Mark as internal.
6396 * syntax.c (Fsyntax_table_p): New forward static decl.
6397 (skip_chars): Remove duplicate decl.
6398 * textprop.c (Fprevious_property_change): New forward static decl.
6399 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6400 Now internal.
6401 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6402 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6403
785bbd42
PE
6404 * editfns.c (Fformat): Remove unreachable code.
6405
8b913b57
AS
64062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6407
6408 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6409 change. (Bug#8496)
6410
a6744a35
EZ
64112011-04-13 Eli Zaretskii <eliz@gnu.org>
6412
6413 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6414 when at ZV. (Bug#8487)
6415
e7974947
AS
64162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6417
baad03f0
AS
6418 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6419 (Bug#8437)
6420 * keyboard.c (parse_tool_bar_item): Likewise.
6421 * sound.c (sound_cleanup, alsa_close): Likewise.
6422 * termcap.c (tgetent): Likewise.
6423 * xfns.c (x_default_font_parameter): Likewise.
6424 * xsettings.c (read_and_apply_settings): Likewise.
6425
e7974947
AS
6426 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6427 (overrun_check_free): Protoize.
6428
28272684
PE
64292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6430
6431 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6432 since callers should never pass a negative size.
6433 Change the signature to match that of plain 'read' and 'write'; see
6434 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6435 * lisp.h: Update prototypes of emacs_write and emacs_read.
6436
11997c76
EZ
64372011-04-11 Eli Zaretskii <eliz@gnu.org>
6438
6439 * xdisp.c (redisplay_window): Don't try to determine the character
6440 position of the scroll margin if the window start point w->startp
e896f03c 6441 is outside the buffer's accessible region. (Bug#8468)
11997c76 6442
8a2cbd72
EZ
64432011-04-10 Eli Zaretskii <eliz@gnu.org>
6444
6445 Fix write-region and its subroutines for buffers > 2GB.
6446 * fileio.c (a_write, e_write): Modify declaration of arguments and
6447 local variables to support buffers larger than 2GB.
6448 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6449
6450 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6451 argument, local variables, and return value.
6452
6453 * lisp.h: Update prototypes of emacs_write and emacs_read.
6454
6455 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6456
4073e537 64572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6458
1ebfdcb6
PE
6459 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6460
b2ded58d
PE
6461 Fix more problems found by GCC 4.6.0's static checks.
6462
7d66342c
PE
6463 * xdisp.c (vmessage): Use a better test for character truncation.
6464
bbf47d44
PE
6465 * charset.c (load_charset_map): <, not <=, for optimization,
6466 and to avoid potential problems with integer overflow.
9248994d 6467 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6468 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6469 * editfns.c (Fformat): Likewise.
1e69125e 6470 * syntax.c (skip_chars): Likewise.
3befa583 6471
e3019616
PE
6472 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6473 This also lets GCC 4.6.0 generate slightly better loop code.
6474
becfa255
PE
6475 * callint.c (Fcall_interactively): <, not <=, for optimization.
6476 (Fcall_interactively): Count the number of arguments produced,
6477 not the number of arguments given. This is simpler and lets GCC
6478 4.6.0 generate slightly better code.
6479
dae0cd48
PE
6480 * ftfont.c: Distingish more carefully between FcChar8 and char.
6481 The previous code passed unsigned char * to a functions like
6482 strlen and xstrcasecmp that expect char *, which does not
6483 conform to the C standard.
6484 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6485 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6486 char * when the C standard requires it.
6487
76032d70
PE
6488 * keyboard.c (read_char): Remove unused var.
6489
eb3f1cc8
PE
6490 * eval.c: Port to Windows vsnprintf (Bug#8435).
6491 Include <limits.h>.
6492 (SIZE_MAX): Define if the headers do not.
6493 (verror): Do not give up if vsnprintf returns a negative count.
6494 Instead, grow the buffer. This ports to Windows vsnprintf, which
6495 does not conform to C99. Problem reported by Eli Zaretskii.
6496 Also, simplify the allocation scheme, by avoiding the need for
6497 calling realloc, and removing the ALLOCATED variable.
6498
70476b54
PE
6499 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6500
12020a9e
PE
6501 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6502 But keep the doprint source code for now, as we might revamp it
6503 and use it again (Bug#8435).
ea6c7ae6
PE
6504 * lisp.h (doprnt): Remove.
6505 * Makefile.in (base_obj): Remove doprnt.o.
6506 * deps.mk (doprnt.o): Remove.
6507
5fdb398c
PE
6508 error: Print 32- and 64-bit integers portably (Bug#8435).
6509 Without this change, on typical 64-bit hosts error ("...%d...", N)
6510 was used to print both 32- and 64-bit integers N, which relied on
6511 undefined behavior.
6512 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6513 New macro.
6514 * lisp.h (error, verror): Mark as printf-like functions.
6515 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6516 Report overflow in size calculations when allocating printf buffer.
6517 Do not truncate output string at its first null byte.
6518 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6519 Truncate the output at a character boundary, since vsnprintf does not
6520 do that.
6521 * charset.c (check_iso_charset_parameter): Convert internal
6522 character to string before calling 'error', since %c now has the
6523 printf meaning.
6524 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6525 overflow when computing char to be passed to 'error'. Do not
6526 pass Lisp_Object to 'error'; pass the integer instead.
6527 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6528 formatted with plain %d.
6529
b189fa66
PE
6530 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6531
bff87ef0
PE
6532 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6533
7e2cac20
PE
6534 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6535
ce4d90b5
PE
6536 * xterm.c (x_catch_errors): Remove duplicate declaration.
6537
266c9547
PE
6538 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6539
79c49ad2
PE
6540 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6541
368f4090
JM
65422011-04-10 Jim Meyering <meyering@redhat.com>
6543
6544 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6545 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6546 return ssize_t not "int", and use size_t as the buffer length.
6547 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6548 * gnutls.h: Update declarations.
6549 * process.c (read_process_output): Use ssize_t, to match.
6550 (send_process): Likewise.
6551
a32d4040
CY
65522011-04-09 Chong Yidong <cyd@stupidchicken.com>
6553
6554 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6555
8546720e 65562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6557
04f2d78b
CB
6558 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6559 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6560
8546720e
GM
6561 * xterm.c (handle_one_xevent):
6562 * xmenu.c (create_and_show_popup_menu):
6563 * xselect.c (x_decline_selection_request)
6564 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6565
0a2f5c1a 65662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6567
6568 Fix some uses of `int' instead of EMACS_INT.
6569 * search.c (string_match_1, fast_string_match)
6570 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6571 (scan_buffer, find_next_newline_no_quit)
6572 (find_before_next_newline, search_command, Freplace_match)
6573 (Fmatch_data): Make some `int' variables be EMACS_INT.
6574
6575 * xdisp.c (display_count_lines): 3rd argument and return value now
6576 EMACS_INT. All callers changed.
6577 (pint2hrstr): Last argument is now EMACS_INT.
6578
6579 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6580 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6581 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6582 (decode_coding_utf_16, decode_coding_emacs_mule)
6583 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6584 (decode_coding_ccl, decode_coding_charset)
6585 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6586 (decode_coding_iso_2022, decode_coding_emacs_mule)
6587 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6588 <char_offset, last_offset>: Declare EMACS_INT.
6589 (encode_coding_utf_8, encode_coding_utf_16)
6590 (encode_coding_emacs_mule, encode_invocation_designation)
6591 (encode_designation_at_bol, encode_coding_iso_2022)
6592 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6593 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6594 Declare EMACS_INT.
6595 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6596 (encode_invocation_designation): Last argument P_NCHARS is now
6597 EMACS_INT.
6598 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6599 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6600
6601 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6602 All users changed.
6603
6604 * ccl.c (Fccl_execute_on_string): Declare some variables
6605 EMACS_INT.
6606
8546720e 66072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6608
6609 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6610
4e19a977
CS
66112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6612
6613 * process.c (Fformat_network_address): Doc fix.
6614
87302331
R
66152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6616
6617 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6618
cbb59342
CY
66192011-04-08 Chong Yidong <cyd@stupidchicken.com>
6620
6621 * keyboard.c (read_char): Call Lisp function help-form-show,
6622 instead of using internal_with_output_to_temp_buffer.
6623 (Qhelp_form_show): New var.
e0d38eeb 6624 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6625
6626 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6627
6628 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6629
e67a13ab
CY
66302011-04-06 Chong Yidong <cyd@stupidchicken.com>
6631
04f2d78b
CB
6632 * process.c (Flist_processes): Remove to Lisp.
6633 (list_processes_1): Delete.
e67a13ab 6634
973f782d
EZ
66352011-04-06 Eli Zaretskii <eliz@gnu.org>
6636
7c106b1e
EZ
6637 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6638
973f782d
EZ
6639 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6640
41cf7d1a 66412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6642
ca23cc88
PE
6643 Fix more problems found by GCC 4.6.0's static checks.
6644
f390e2d5
PE
6645 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6646
42eea0d0
PE
6647 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6648
b69769da 6649 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6650
f9541e84
PE
6651 * xdisp.c (vmessage): Mark as a printf-like function.
6652
13841b55
PE
6653 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6654
c136c10f
PE
6655 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6656
5e2d4a30
PE
6657 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6658 printf-like functions.
6659 (tiff_load): Add casts to remove these marks before passing them
6660 to system-supplied API.
6661
583f48b9
PE
6662 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6663
b25d760e
PE
6664 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6665 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6666 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6667 directly, rather than having caller test rule sign. This avoids
6668 some unnecessary tests.
6669 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6670 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6671 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6672
bc7b6697 6673 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6674 (xfont_open): Avoid unnecessary tests.
bc7b6697 6675
27ccc379
PE
6676 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6677
dcd5c89a
PE
6678 * composite.h, composite.c (composition_gstring_put_cache):
6679 Use EMACS_INT, not int, for length.
6680
b13a45c6
PE
6681 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6682 breaking out part of COMPOSITION_DECODE_RULE.
6683 (COMPOSITION_DECODE_RULE): Use it.
6684 * composite.c (get_composition_id): Remove unused local vars,
6685 by using the new macro.
6686
1e792e4d
PE
6687 * textprop.c (set_text_properties_1): Change while to do-while,
6688 since the condition is always true at first.
6689
dc6c6455 6690 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6691 (interval_deletion_adjustment): Return unsigned value.
6692 All uses changed.
dc6c6455 6693
aba7731a
PE
6694 * process.c (list_processes_1, create_pty, read_process_output):
6695 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6696 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6697 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6698 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6699 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6700
fdfc4bf3
PE
6701 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6702
fca8fe46 6703 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6704 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6705
06a0259a 6706 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6707 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6708 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6709
e7b9e80f
PE
6710 * print.c (print_error_message): Avoid int overflow.
6711
56201685
PE
6712 * font.c (font_list_entities): Redo for clarity,
6713 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6714
78834453 6715 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6716 (font_score): Avoid potential overflow in diff calculation.
78834453 6717
0bc0b309 6718 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6719 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6720
e610eaca
PE
6721 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6722
b895abce
PE
6723 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6724 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6725 can always succeed if overflow has undefined behavior.
6726
1f1d9321 6727 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6728 (wordify): Omit three unnecessary tests.
1f1d9321 6729
c59478bc
PE
6730 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6731 All callers changed. This avoids the need for an unused var.
6732
79b73827
PE
6733 * casefiddle.c (casify_region): Remove var that is set but not used.
6734
a4db5dfe
PE
6735 * dired.c (file_name_completion): Remove var that is set but not used.
6736
43aae36e
PE
6737 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6738
2a47c44d 6739 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6740 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6741
a37c69bf
PE
6742 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6743 Check for integer overflow on size calculations.
6744
328ab8e7
PE
6745 * buffer.c (Fprevious_overlay_change): Remove var that is set
6746 but not used.
6747
e5a2a5cb
PE
6748 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6749 Remove vars that are set but not used.
8d84a6eb 6750 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6751 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6752
a60e5f68
PE
6753 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6754
f661cb61 6755 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6756 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6757
f0397f5a
PE
6758 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6759 that are set but not used.
6760
8664db06 6761 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6762 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6763
6abdaa4a
PE
6764 * xselect.c (x_get_local_selection, x_handle_property_notify):
6765 Remove vars that are set but not used.
6766
0ce7538d 6767 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6768 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6769
9ae848fc
PE
6770 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6771 Remove var that is set but not used.
0b918413
PE
6772 (scroll_bar_windows_size): Now size_t, not int.
6773 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6774 Check for overflow.
9ae848fc 6775
a5a62657
PE
6776 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6777 (map_tty_color) [!defined MSDOS]: Likewise.
6778
5c5cdd39
PE
6779 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6780
66ebf983
PE
6781 * coding.c: Remove vars that are set but not used.
6782 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6783 All callers changed.
6784 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6785 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6786 (decode_coding_charset): Remove vars that are set but not used.
6787
1be4d761
PE
6788 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6789 that is set but not used.
6790
47553fa8
PE
6791 * print.c (print_object): Remove var that is set but not used.
6792
1f7196bf 6793 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6794 The gnulib version avoids calling malloc in the usual case,
6795 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6796 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6797 * filelock.c (current_lock_owner): Likewise.
6798 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6799 * sysdep.c: Include allocator.h, careadlinkat.h.
6800 (emacs_no_realloc_allocator): New static constant.
6801 (emacs_readlink): New function.
fdb61804
PE
6802 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6803 ../lib/careadlinkat.h.
d1fdcab7 6804
f84c17c7
SM
68052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6806
6807 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6808 first non-nil return value).
6809
ef3862ad
JD
68102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6811
6812 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6813 if not defined (Bug#8403).
6814
376a7006
JB
68152011-04-02 Juanma Barranquero <lekktu@gmail.com>
6816
6817 * xdisp.c (display_count_lines): Remove parameter `start',
6818 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6819 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6820 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6821 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6822 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6823 and thereabouts. All callers changed.
6824 (get_per_char_metric): Remove parameter `f', unused since
6825 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6826
6ca3801d
JM
68272011-04-02 Jim Meyering <meyering@redhat.com>
6828
6829 do not dereference NULL upon failed strdup
6830 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6831 (ns_get_family): Likewise.
6832
d8e2b5ba
JB
68332011-04-02 Juanma Barranquero <lekktu@gmail.com>
6834
6835 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6836
8c74fcbd
JD
68372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6838
6839 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6840 later (Bug#8403).
6841
7200d79c
SM
68422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6843
03408648 6844 Add lexical binding.
7200d79c 6845
03408648
SM
6846 * window.c (Ftemp_output_buffer_show): New fun.
6847 (Fsave_window_excursion):
6848 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6849
6850 * lread.c (lisp_file_lexically_bound_p): New function.
6851 (Fload): Bind Qlexical_binding.
6852 (readevalloop): Remove `evalfun' arg.
6853 Bind Qinternal_interpreter_environment.
6854 (Feval_buffer): Bind Qlexical_binding.
6855 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6856 Mark as dynamic.
6857 (syms_of_lread): Declare `lexical-binding'.
6858
6859 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6860
6861 * keyboard.c (eval_dyn): New fun.
6862 (menu_item_eval_property): Use it.
ca105506
SM
6863
6864 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6865
03408648
SM
6866 * fns.c (concat, mapcar1): Accept byte-code-functions.
6867
6868 * eval.c (Fsetq): Handle lexical vars.
6869 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6870 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6871 (FletX, Flet): Obey lexical binding.
6872 (Fcommandp): Handle closures.
6873 (Feval): New `lexical' arg.
6874 (eval_sub): New function extracted from Feval. Use it almost
6875 everywhere where Feval was used. Look up vars in lexical env.
6876 Handle closures.
6877 (Ffunctionp): Move from subr.el.
6878 (Ffuncall): Handle closures.
6879 (apply_lambda): Remove `eval_flags'.
6880 (funcall_lambda): Handle closures and new byte-code-functions.
6881 (Fspecial_variable_p): New function.
6882 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6883 but without exporting it to Lisp.
23aba0ea 6884
23aba0ea 6885 * doc.c (Fdocumentation, store_function_docstring):
03408648 6886 * data.c (Finteractive_form): Handle closures.
23aba0ea 6887
03408648
SM
6888 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6889 interactive spec.
ba83908c 6890
04f2d78b
CB
6891 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6892 New byte-codes.
03408648
SM
6893 (exec_byte_code): New function extracted from Fbyte_code to handle new
6894 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6895
03408648 6896 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6897
03408648 6898 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6899
e2abce01
JB
69002011-03-31 Juanma Barranquero <lekktu@gmail.com>
6901
6902 * xdisp.c (redisplay_internal): Fix prototype.
6903
63696a73 69042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6905
63696a73 6906 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6907 (try_scrolling): Use it when setting scroll_limit.
6908 Limit scrolling to 100 screen lines.
63696a73
EZ
6909 (redisplay_window): Even when falling back on "recentering",
6910 position point in the window according to scroll-conservatively,
6911 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6912
6913 (try_scrolling): When point is above the window, allow searching
6914 as far as scroll_max, or one screenful, to compute vertical
6915 distance from PT to the scroll margin position. This prevents
6916 try_scrolling from unnecessarily failing when
6917 scroll-conservatively is set to a value slightly larger than the
6918 window height. Clean up the case of PT below the margin at bottom
6919 of window: scroll_max can no longer be INT_MAX. When aggressive
6920 scrolling is in use, don't let point enter the opposite scroll
6921 margin as result of the scroll.
6922 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6923 threshold of 100 lines for never-recentering scrolling.
6924
e4cc2dfc
JB
69252011-03-31 Juanma Barranquero <lekktu@gmail.com>
6926
6927 * dispextern.h (move_it_by_lines):
6928 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6929 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6930 (message_log_check_duplicate): Remove parameters `prev_bol' and
6931 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6932 (redisplay_internal): Remove parameter `preserve_echo_area',
6933 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6934
6935 * indent.c (Fvertical_motion):
6936 * window.c (window_scroll_pixel_based, Frecenter):
6937 Don't pass `need_y_p' to `move_it_by_lines'.
6938
1c470562
SM
69392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6940
44f230aa
SM
6941 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6942 steal a few bits to be more compact.
6943 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6944 Remove unneeded casts.
6945
1c470562
SM
6946 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6947
888adce9
ZK
69482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6949
6950 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6951 binding" message (bug#7967).
6952
f838ed7b
PE
69532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6954
77861b95
PE
6955 Fix more problems found by GCC 4.6.0's static checks.
6956
de6dbc14
PE
6957 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6958 Remove unused local var.
6959
f838ed7b
PE
6960 * editfns.c (Fmessage_box): Remove unused local var.
6961
792c7b2b
PE
6962 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6963 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6964 Omit unused local vars.
c499e557 6965 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6966 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6967 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6968 Omit unused local var.
6969
ba0165e1
PE
6970 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6971 Don't assume string length fits in int.
32ad8845 6972 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6973 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6974
3c59b4c9
PE
6975 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6976 instead of alloca (Bug#8344).
6977
a3eed478 6978 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6979 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6980
eb4d412d
PE
6981 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6982
1658b401
PE
6983 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6984 concerns.
6985
6986 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6987
6988 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6989
9a2c6e05
PE
6990 * keyboard.c (syms_of_keyboard): Use the same style as later
6991 in this function when indexing through an array. This also
6992 works around GCC bug 48267.
6993
03d0a109
PE
6994 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6995
44f730c8
PE
6996 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6997
fe75f926
PE
6998 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6999 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7000
ffa8c828
PE
7001 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7002 This avoids undefined behavior on integer overflow, and is a bit
7003 more convenient anyway since it is compared to a size_t variable.
7004
c5101a77
PE
7005 Variadic C functions now count arguments with size_t, not int.
7006 This avoids an unnecessary limitation on 64-bit machines, which
7007 caused (substring ...) to crash on large vectors (Bug#8344).
7008 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7009 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7010 All variadic functions and their callers changed accordingly.
c5101a77
PE
7011 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7012 * data.c (arith_driver, float_arith_driver): Likewise.
7013 * editfns.c (general_insert_function): Likewise.
7014 * eval.c (struct backtrace.nargs, interactive_p)
7015 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7016 (funcall_lambda, mark_backtrace): Likewise.
7017 * fns.c (concat): Likewise.
7018 * frame.c (x_set_frame_parameters): Likewise.
7019 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7020 0 if not found, not -1. All callers changed.
7021
dd3f25f7
PE
7022 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7023 (stack_copy_size): Now size_t, not int.
7024 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7025
461c2ab9
JB
70262011-03-28 Juanma Barranquero <lekktu@gmail.com>
7027
7028 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7029 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7030 All callers changed.
7031
7032 * lisp.h (multibyte_char_to_unibyte):
7033 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7034 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7035 * character.h (CHAR_TO_BYTE8):
7036 * cmds.c (internal_self_insert):
7037 * editfns.c (general_insert_function):
7038 * keymap.c (push_key_description):
7039 * search.c (Freplace_match):
7040 * xdisp.c (message_dolog, set_message_1): All callers changed.
7041
f6d62986
SM
70422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7043
7044 * keyboard.c (safe_run_hook_funcall): New function.
7045 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7046 don't set the hook to nil, but remove the offending function instead.
7047 (Qcommand_hook_internal): Remove, unused.
7048 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7049 Vcommand_hook_internal.
7050
7051 * eval.c (enum run_hooks_condition): Remove.
7052 (funcall_nil, funcall_not): New functions.
7053 (run_hook_with_args): Call each function through a `funcall' argument.
7054 Remove `cond' argument, now redundant.
7055 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7056 (Frun_hook_with_args_until_failure): Adjust accordingly.
7057 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7058
1db5b1ad
JB
70592011-03-28 Juanma Barranquero <lekktu@gmail.com>
7060
7061 * dispextern.h (string_buffer_position): Remove declaration.
7062
7063 * print.c (strout): Remove parameter `multibyte', unused since
7064 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7065
7066 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7067 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7068 All callers changed.
7069
7070 * w32.c (_wsa_errlist): Use braces for struct initializers.
7071
7072 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7073 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7074 All callers changed.
7075 (string_buffer_position): Likewise. Also, make static (it's never
7076 used outside xdisp.c).
7077 (cursor_row_p): Remove parameter `w', unused since
7078 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7079 (decode_mode_spec): Remove parameter `precision', introduced during
7080 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7081 All callers changed.
7082
5ffb62aa
JD
70832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7084
7085 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7086
461c2ab9 70872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7088
7089 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7090 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7091 (ns_update_auto_hide_menu_bar): New functions.
7092 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7093 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7094 ns_constrain_all_frames.
7095 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7096 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7097
5c380ffb
JD
70982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7099
7100 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7101
9af30bdf
GM
71022011-03-27 Glenn Morris <rgm@gnu.org>
7103
7104 * syssignal.h: Replace RETSIGTYPE with void.
7105 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7106 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7107 Replace SIGTYPE with void everywhere.
7108 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7109 * s/template.h (SIGTYPE): Remove commented out definition.
7110
e2abce01
JB
71112011-03-26 Eli Zaretskii <eliz@gnu.org>
7112
7113 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7114 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7115
f868cd8a
JB
71162011-03-26 Juanma Barranquero <lekktu@gmail.com>
7117
59eb0929
JB
7118 * w32.c (read_unc_volume): Use parameter `henum', instead of
7119 global variable `wget_enum_handle'.
7120
7121 * keymap.c (describe_vector): Remove parameters `indices' and
7122 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7123 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7124
f868cd8a
JB
7125 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7126
7127 * keyboard.c (timer_check): Remove parameter `do_it_now',
7128 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7129 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7130 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7131
7132 * keyboard.c (read_char):
7133 * w32menu.c (w32_menu_display_help):
7134 * xmenu.c (show_help_event, menu_help_callback):
7135 Adjust calls to `show_help_echo'.
7136
7137 * gtkutil.c (xg_maybe_add_timer):
7138 * keyboard.c (readable_events):
7139 * process.c (wait_reading_process_output):
7140 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7141
7142 * insdel.c (adjust_markers_gap_motion):
7143 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7144 (gap_left, gap_right): Don't call it.
7145
2ecf6fdb
CY
71462011-03-25 Chong Yidong <cyd@stupidchicken.com>
7147
7148 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7149 incurred during fontification.
7150
6b1f9ba4
JB
71512011-03-25 Juanma Barranquero <lekktu@gmail.com>
7152
7153 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7154 (DEFVAR_PER_BUFFER): Don't pass it.
7155
7156 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7157 (scrolling_window): Don't pass it.
7158
0f4a96b5
JB
71592011-03-25 Juanma Barranquero <lekktu@gmail.com>
7160
7161 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7162
7163 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7164 and `suffix'.
7165 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7166 of variables specific to SELinux and computation of `encoded_absname'.
7167
7168 * image.c (XPutPixel): Remove unused variable `height'.
7169
7170 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7171
7172 * unexw32.c (get_section_info): Remove unused variable `section'.
7173
7174 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7175 (system_process_attributes): Remove unused variable `sess'.
7176 (sys_read): Remove unused variable `err'.
7177
7178 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7179 (w32_wnd_proc): Remove unused variable `isdead'.
7180 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7181 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7182 (x_create_tip_frame): Remove unused variable `tem'.
7183
7184 * w32inevt.c (w32_console_read_socket):
7185 Remove unused variable `no_events'.
7186
7187 * w32term.c (x_draw_composite_glyph_string_foreground):
7188 Remove unused variable `width'.
7189
1149507c
JB
71902011-03-24 Juanma Barranquero <lekktu@gmail.com>
7191
7192 * w32term.c (x_set_glyph_string_clipping):
7193 Don't pass uninitialized region to CombineRgn.
7194
9c88f339
JB
71952011-03-23 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7198 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7199 (Fx_close_connection): Remove unused variable `i'.
7200
7201 * w32font.c (w32font_draw): Return number of glyphs.
7202 (w32font_open_internal): Remove unused variable `i'.
7203 (w32font_driver): Add missing initializer.
7204
7205 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7206 (fill_in_menu): Remove unused variable `items_added'.
7207
7208 * w32term.c (last_mouse_press_frame): Remove static global variable.
7209 (w32_clip_to_row): Remove unused variable `f'.
7210 (x_delete_terminal): Remove unused variable `i'.
7211
7212 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7213 (NOTHING): Remove unused static global variable.
7214 (uniscribe_check_otf): Remove unused variable `table'.
7215 (uniscribe_font_driver): Add missing initializers.
7216
dee091a3
JD
72172011-03-23 Julien Danjou <julien@danjou.info>
7218
7219 * term.c (Fsuspend_tty, Fresume_tty):
7220 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7221 * window.c (temp_output_buffer_show):
7222 * insdel.c (signal_before_change):
7223 * frame.c (Fhandle_switch_frame):
7224 * fileio.c (Fdo_auto_save):
7225 * emacs.c (Fkill_emacs):
7226 * editfns.c (save_excursion_restore):
7227 * cmds.c (internal_self_insert):
7228 * callint.c (Fcall_interactively):
7229 * buffer.c (Fkill_all_local_variables):
7230 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7231 Use Frun_hooks.
0f4a96b5 7232 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7233 unconditionnaly since it does the check itself.
7234
2c520ab5 72352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7236
c9c49752
PE
7237 Fix more problems found by GCC 4.5.2's static checks.
7238
8abc3f12
PE
7239 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7240 the first time through the loop, since we know p0 < p1 then.
7241 This also avoids a gcc -Wstrict-overflow warning.
7242
a2d26660
PE
7243 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7244 leading to a memory leak, possible in functions like
7245 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7246 of objects (Bug#8318).
a2d26660 7247
916c72e9
PE
7248 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7249 that could (at least in theory) be that large.
7250
19ab8a18
PE
7251 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7252 This is less likely to overflow, and avoids undefined behavior if
7253 overflow does occur. All callers changed. Use strtoul to scan
7254 for the unsigned long integer.
b7cbbd6f
PE
7255 (pint2hrstr): Simplify and tune code slightly.
7256 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7257
f0641eff
PE
7258 * scroll.c (do_scrolling): Work around GCC bug 48228.
7259 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7260
7f650bb9
PE
7261 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7262 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7263 (validate_x_resource_name): Simplify count usage.
7264 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7265
37dd57d1
PE
7266 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7267 fail (Bug#8306).
81e56e61 7268
699979fc 7269 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7270
401bf9b4
PE
7271 * process.c (Fmake_network_process): Use socklen_t, not int,
7272 where POSIX says socklen_t is required in portable programs.
7273 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7274 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7275 (Fmake_network_process, server_accept_connection):
7276 (wait_reading_process_output, read_process_output):
7277 Likewise.
7278
b93aacde
PE
7279 * process.c: Rename or move locals to avoid shadowing.
7280 (list_processes_1, Fmake_network_process):
7281 (read_process_output_error_handler, exec_sentinel_error_handler):
7282 Rename or move locals.
4dc343ee 7283 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7284 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7285 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7286 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7287 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7288
af8a867c 7289 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7290 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7291 Include tparam.h instead, since it declares them.
af8a867c
PE
7292 * cm.h (PC): Remove extern decl; tparam.h now does this.
7293 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7294 * terminfo.c: Include tparam.h, to check interfaces.
7295 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7296 (tparam): Adjust signature to match interface in tparam.h;
7297 this removes some undefined behavior. Check that outstring and len
7298 are zero, which they always are with Emacs.
7299 * tparam.h (PC, BC, UP): New extern decls.
7300
0248044d 7301 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7302 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7303
8ff096c1 7304 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7305 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7306 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7307 (ftfont_list): Remove unused local.
49eaafba
PE
7308 (get_adstyle_property, ftfont_pattern_entity):
7309 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7310 Rename locals to avoid shadowing.
8ff096c1 7311
e2be39f6
PE
7312 * xfont.c (xfont_list_family): Mark var as initialized.
7313
c9735e30
PE
7314 * xml.c (make_dom): Now static.
7315
8f5201ae
PE
7316 * composite.c (composition_compute_stop_pos): Rename local to
7317 avoid shadowing.
b246f932
PE
7318 (composition_reseat_it): Remove unused locals.
7319 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7320 (composition_update_it): Mark var as initialized.
11b61122
PE
7321 (find_automatic_composition): Mark vars as initialized,
7322 with a FIXME (Bug#8290).
8f5201ae 7323
760fbc2c
PE
7324 character.h: Rename locals to avoid shadowing.
7325 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7326 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7327 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7328 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7329 to avoid shadowing.
7330
ff08eb85
PE
7331 * textprop.c (property_change_between_p): Remove; unused.
7332
fc7bf025
PE
7333 * intervals.c (interval_start_pos): Now static.
7334
235d7abc
PE
7335 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7336
44f230aa
SM
7337 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7338 Rename locals to avoid shadowing.
3e7d6594 7339
50060332
PE
7340 * sound.c (wav_play, au_play, Fplay_sound_internal):
7341 Fix pointer signedness.
d01f234b 7342 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7343 (wav_play): Initialize a variable to 0, to prevent undefined
7344 behavior (Bug#8278).
50060332 7345
c4fc4e30
PE
7346 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7347
918436ed
PE
7348 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7349
c939f91b
PE
7350 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7351 clobbering (Bug#8298).
b9c7f648
PE
7352 * sysdep.c (sys_subshell): Likewise.
7353 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7354
6bd8c144
PE
7355 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7356 This should get cleaned up, so that child_setup has the
7357 same signature on all platforms.
7358
7710357c 7359 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7360 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7361
c59da222
CY
73622011-03-22 Chong Yidong <cyd@stupidchicken.com>
7363
7364 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7365 not to be necessary, and produces flickering.
7366
66b87493
GM
73672011-03-20 Glenn Morris <rgm@gnu.org>
7368
7369 * config.in: Remove file.
7370
45b6f6d5
JB
73712011-03-20 Juanma Barranquero <lekktu@gmail.com>
7372
7373 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7374 are now in src/globals.h.
7375 (syms_of_minibuf): Remove spurious & from previous change.
7376
3ec03f7e
LL
73772011-03-20 Leo <sdl.web@gmail.com>
7378
7379 * minibuf.c (completing-read-function): New variable.
7380 (completing-read-default): Rename from completing-read.
7381 (completing-read): Call completing-read-function.
7382
b14e3e21
CY
73832011-03-19 Juanma Barranquero <lekktu@gmail.com>
7384
7385 * xfaces.c (Fx_load_color_file):
7386 Read color file from absolute filename (bug#8250).
7387
f2b726e6
JB
73882011-03-19 Juanma Barranquero <lekktu@gmail.com>
7389
7390 * makefile.w32-in: Update dependencies.
7391
09f6ff02
EZ
73922011-03-17 Eli Zaretskii <eliz@gnu.org>
7393
7394 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7395
29a6015a
PE
73962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7397
a3a6c54e
PE
7398 Fix more problems found by GCC 4.5.2's static checks.
7399
b766f867
PE
7400 * process.c (make_serial_process_unwind, send_process_trap):
7401 (sigchld_handler): Now static.
7402
be02381c
PE
7403 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7404 That way, the code declares only the vars that it needs.
7405 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7406 * s/cygwin.h (PTY_ITERATION): Likewise.
7407 * s/darwin.h (PTY_ITERATION): Likewise.
7408 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7409
57048744
PE
7410 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7411 * process.c (allocate_pty): Don't declare stb unless it's needed.
7412
7914961c 7413 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7414 (CONSTANTLIM): Remove; unused.
7415 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7416 Define only if needed.
7914961c 7417
b3967b18
PE
7418 * unexelf.c (unexec): Name an expression,
7419 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7420 Use a different way to cause a compilation error if anyone uses
7421 n rather than nn, a way that does not involve shadowing.
73366a00 7422 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7423
29a6015a
PE
7424 * deps.mk (unexalpha.o): Remove; unused.
7425
43cfc33e 7426 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7427 * unexec.h: New file.
ce701a33
PE
7428 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7429 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7430 Depend on unexec.h.
7431 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7432 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7433 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7434 Change as necessary to match prototype in unexec.h.
ce701a33 7435
01f44d5a
PE
7436 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7437 shadowing.
4f63c6bb 7438 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7439
a6670b0b
PE
7440 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7441 Rename locals to avoid shadowing.
7442
cef2010d 7443 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7444 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7445
d4d7173a
PE
7446 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7447
f08b802a
PE
7448 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7449 warning when compiling print.c.
7450
3ddb0639
PE
7451 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7452 instead of using an uninitialized var.
5ad03b97 7453 (font_sort_entities): Mark var as initialized.
3ddb0639 7454
170a2692
PE
7455 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7456
e663c700
PE
7457 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7458 pointers to constants.
89bc529a 7459 (font_parse_fcname): Remove unused vars.
7b81e2d0 7460 (font_delete_unmatched): Now static.
ea838e10 7461 (font_get_spec): Remove; unused.
13a547c6
PE
7462 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7463 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7464 Rename or move locals to avoid shadowing.
e663c700 7465
2a80c887 7466 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7467 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7468
1384fa33 7469 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7470 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7471
8b2c52e9
PE
7472 * alloc.c (mark_backtrace): Move decl from here ...
7473 * lisp.h: ... to here, so that it can be checked.
7474
475545b5 7475 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7476 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7477 (lisp_indirect_variable): Name an expression,
7478 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7479 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7480
b1349114 7481 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7482 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7483 Use const pointer when appropriate.
b1349114 7484
a2928364
PE
7485 * lisp.h (get_system_name, get_operating_system_release):
7486 Move decls here, to check interfaces.
7487 * process.c (get_operating_system_release): Move decl to lisp.h.
7488 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7489 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7490 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7491 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7492 (Fformat_time_string, Fencode_time, Finsert_char):
7493 (Ftranslate_region_internal, Fformat):
7494 Rename or remove local vars to avoid shadowing.
9710023e 7495 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7496
a415e694
PE
7497 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7498 avoid shadowing.
7499
8ef4622d
PE
7500 * lisp.h (eassert): Check that the argument compiles, even if
7501 ENABLE_CHECKING is not defined.
7502
946f9a5b
PE
7503 * data.c (Findirect_variable): Name an expression, to avoid
7504 gcc -Wbad-function-cast warning.
112396d6 7505 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7506 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7507 (Fmake_variable_buffer_local, Fmake_local_variable):
7508 Mark variables as initialized.
52746918 7509 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7510
e5aab7e7 7511 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7512 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7513 Rename locals to avoid shadowing.
dff45157
PE
7514 (mark_stack): Move local variables into the #ifdef region where
7515 they're used.
7bc26fdb
PE
7516 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7517 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7518 needed otherwise.
7519 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7520 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7521 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7522
e5aab7e7
PE
7523 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7524 avoids undefined behavior in theory.
7525
4da60324
PE
7526 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7527
88043301
PE
7528 Use functions, not macros, for up- and down-casing (Bug#8254).
7529 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7530 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7531 to use the following functions instead of these macros.
7532 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7533 EMACS_INT, since callers assume the returned value fits in int.
7534 (upcase1): Likewise, for UPCASE_TABLE.
7535 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7536 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7537 the race-condition problem in the old DOWNCASE.
88043301 7538
19ed5445
PE
7539 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7540 Rename locals to avoid shadowing.
7541 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7542 (regex_compile, re_search_2, re_match_2_internal):
7543 Remove unused local vars.
952db0d7
PE
7544 (FREE_VAR): Rewrite so as not to use empty "else",
7545 which gcc can warn about.
da053e48 7546 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7547 (RETALLOC_IF): Define only if needed.
7548 (WORDCHAR_P): Likewise. This one is never needed, but is used
7549 only in a comment talking about a compiler bug, so put inside
7550 the #if 0 of that comment.
7551 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7552 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7553 Remove; unused.
19ed5445 7554
1f3561e4 7555 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7556 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7557 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7558
ded6f8f7
PE
7559 * search.c (simple_search): Remove unused var.
7560
dbd37a95
PE
7561 * dired.c (compile_pattern): Move decl from here ...
7562 * lisp.h: ... to here, so that it can be checked.
7563 (struct re_registers): New forward decl.
7564
7e47afad
PE
7565 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7566
85f24f61
PE
7567 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7568 All uses changed.
7569 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7570 Rename locals to avoid shadowing.
5671df8f 7571 (Fvertical_motion): Mark locals as initialized.
85f24f61 7572
181aa2be 7573 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7574 (casify_region): Mark local as initialized.
181aa2be 7575
930d429c
PE
7576 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7577
7082eac6
PE
7578 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7579 New macros, so that the caller can use some names other than
7580 gcpro1, gcpro2, etc.
7581 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7582 of the new macros.
7583 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7584 argument, for consistency with GCPRO2_VAR, etc: it is now the
7585 prefix of the variable, not the variable itself. All uses
7586 changed.
38b2c076
PE
7587 * dired.c (directory_files_internal, file_name_completion):
7588 Rename locals to avoid shadowing.
7589
15206ed9
PE
7590 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7591 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7592 dired.c's scmp function, had undefined behavior.
7593 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7594 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7595 * buffer.h: ... to here, because these macros use current_buffer,
7596 and the new implementation with inline functions needs to have
7597 current_buffer in scope now, rather than later when the macros
7598 are used.
7599 (downcase, upcase1): New static inline functions.
7600 (DOWNCASE, UPCASE1): Reimplement using these functions.
7601 This avoids undefined behavior in expressions like
7602 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7603 from race conditions in accessing the global variables
7604 case_temp1 and case_temp2.
7605 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7606 * lisp.h (case_temp1, case_temp2): Remove their decls.
7607 * character.h (ASCII_CHAR_P): Move from here ...
7608 * lisp.h: ... to here, so that the inline functions mentioned
7609 above can use them.
7610
4a6bea26
PE
7611 * dired.c (directory_files_internal_unwind): Now static.
7612
f14b7e14
PE
7613 * fileio.c (file_name_as_directory, directory_file_name):
7614 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7615 Now static.
2893f146
PE
7616 (file_name_as_directory): Use const pointers when appropriate.
7617 (Fexpand_file_name): Likewise. In particular, newdir might
7618 point at constant storage, so make it a const pointer.
fd4ead52 7619 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7620 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7621 signedness issues.
f839df0c
PE
7622 (Fset_file_times, Finsert_file_contents, auto_save_error):
7623 Rename locals to avoid shadowing.
f14b7e14 7624
5716756e 7625 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7626 (Ftry_completion, Fall_completions): Rename or remove locals
7627 to avoid shadowing.
5716756e 7628
b4c3046a
PE
7629 * marker.c (bytepos_to_charpos): Remove; unused.
7630
b45db522
PE
7631 * lisp.h (verify_bytepos, count_markers): New decls,
7632 so that gcc does not warn that these functions aren't declared.
7633
85876d07
PE
7634 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7635 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7636 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7637 (copy_text): Remove unused local var.
85876d07 7638
03d78a21 7639 * filelock.c (within_one_second): Now static.
b3dd38ab 7640 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7641
5df8f01b
PE
7642 * buffer.c (fix_overlays_before): Mark locals as initialized.
7643 (fix_start_end_in_overlays): Likewise. This function should be
7644 simplified by using pointers-to-pointers, but that's a different
7645 matter.
b1d876f1 7646 (switch_to_buffer_1): Now static.
8f54f30a
PE
7647 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7648 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7649
a70072c9 7650 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7651 Fix pointer signedness issue.
edced198
PE
7652 (sys_subshell): Mark local as volatile if checking for lint,
7653 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7654 (MAXPATHLEN): Define only if needed.
a70072c9 7655
a0977c44
PE
7656 * process.c (serial_open, serial_configure): Move decls from here ...
7657 * systty.h: ... to here, so that they can be checked.
7658
a884fdcc
PE
7659 * fns.c (get_random, seed_random): Move extern decls from here ...
7660 * lisp.h: ... to here, so that they can be checked.
7661
604efe86 7662 * sysdep.c (reset_io): Now static.
b8950c94 7663 (wait_for_termination_signal): Remove; unused.
604efe86 7664
38fc62d9
PE
7665 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7666 (copy_keymap_item, append_key, push_text_char_description):
7667 Now static.
1004a21a 7668 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7669 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7670 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7671 (describe_map_tree):
7672 Rename locals to avoid shadowing.
38fc62d9 7673
2f2650da
PE
7674 * keyboard.c: Declare functions static if they are not used elsewhere.
7675 (echo_char, echo_dash, cmd_error, top_level_2):
7676 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7677 (read_char, kbd_buffer_get_event, make_lispy_position):
7678 (make_lispy_event, make_lispy_movement, apply_modifiers):
7679 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7680 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7681 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7682 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7683 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7684
a053e86c 7685 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7686 (mark_kboards): Move decl here ...
7687 * alloc.c (mark_kboards): ... from here.
a053e86c 7688
4752793e
PE
7689 * lisp.h (force_auto_save_soon): New decl.
7690
74f10ca7 7691 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7692 (DEFINE_DUMMY_FUNCTION): New macro.
7693 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7694 Use it.
c03cd23f
PE
7695 (main): Add casts to avoid warnings
7696 if GCC considers string literals to be constants.
74f10ca7 7697
022e70d4
PE
7698 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7699
59d6fe83
PE
7700 * dbusbind.c: Pointer signedness fixes.
7701 (xd_signature, xd_append_arg, xd_initialize):
7702 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7703 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7704 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7705 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7706
78320123
PE
7707 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7708 if GCC considers string literals to be constants.
49cebcca 7709 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7710
35ac2a97
SM
77112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7712
fb103ca9
SM
7713 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7714 (print_preprocess, print_object): New macro to fix last change.
7715
35ac2a97
SM
7716 * print.c (print_preprocess): Don't forget font objects.
7717
62973b41
JB
77182011-03-16 Juanma Barranquero <lekktu@gmail.com>
7719
7720 * emacs.c (USAGE3): Doc fixes.
7721
0e48bb22
AS
77222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7723
7724 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7725 structure.
7726
7684e57b
JB
77272011-03-14 Juanma Barranquero <lekktu@gmail.com>
7728
7729 * lisp.h (VWindow_system, Qfile_name_history):
7730 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7731 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7732 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7733
7734 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7735 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7736
7737 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7738 * w32console.c (detect_input_pending, read_input_pending)
7739 (encode_terminal_code):
7740 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7741 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7742 (w32_system_caret_y, Qfile_name_history):
7743 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7744 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7745 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7746 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7747 * w32proc.c (Qlocal, report_file_error):
7748 * w32term.c (Vwindow_system, updating_frame):
7749 * w32uniscribe.c (initialized, uniscribe_font_driver):
7750 Remove unneeded extern declarations.
7751
2aa46d6c
CY
77522011-03-14 Chong Yidong <cyd@stupidchicken.com>
7753
c96bbc66 7754 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7755
cffc6f3b
CY
77562011-03-13 Chong Yidong <cyd@stupidchicken.com>
7757
7758 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7759 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7760 These macros can no longer be used for assignment.
7761
44f230aa
SM
7762 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7763 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7764 (record_buffer_markers, fetch_buffer_markers): New functions for
7765 recording and fetching special buffer markers.
7766 (set_buffer_internal_1, set_buffer_temp): Use them.
7767
7768 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7769
7770 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7771
7772 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7773 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7774
7775 * xdisp.c (hscroll_window_tree):
7776 (reconsider_clip_changes): Use PT instead of BUF_PT.
7777
d251f04b
EZ
77782011-03-13 Eli Zaretskii <eliz@gnu.org>
7779
7780 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7781 $(EMACS_ROOT)/lib/intprops.h.
7782
f0c77cd1
PE
77832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7784
3eca4629
PE
7785 Fix more problems found by GCC 4.5.2's static checks.
7786
7c86ee98
PE
7787 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7788 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7789 (xg_free_frame_widgets): Make it clear that a local variable is
7790 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7791 (gdk_window_get_screen): Make it clear that this macro is needed
7792 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7793 (int_gtk_range_get_value): New function, which avoids a diagnostic
7794 from gcc -Wbad-function-cast.
7795 (xg_set_toolkit_scroll_bar_thumb): Use it.
7796 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7797 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7798 (get_utf8_string, xg_get_file_with_chooser):
7799 Rename locals to avoid shadowing.
7800 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7801
41729b81
PE
7802 * xgselect.c (xg_select): Remove unused var.
7803
f0c77cd1
PE
7804 * image.c (four_corners_best): Mark locals as initialized.
7805 (gif_load): Initialize transparent_p to zero (Bug#8238).
7806 Mark another local as initialized.
ec6cf4c6 7807 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7808
ce0ad53d 7809 * image.c (clear_image_cache): Now static.
d5d5a617 7810 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7811 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7812 (x_edge_detection): Remove unnecessary cast that
7813 gcc -Wbad-function-cast diagnoses.
2037898d 7814 (gif_load): Fix pointer signedness.
6ae141d6
PE
7815 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7816 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7817
33383987 78182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7819
d32df629
PE
7820 Improve quality of tests for time stamp overflow.
7821 For example, without this patch (encode-time 0 0 0 1 1
7822 1152921504606846976) returns the obviously-bogus value (-948597
7823 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7824 reports time overflow. See
7825 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7826 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7827 * editfns.c: Include limits.h and intprops.h.
7828 (TIME_T_MIN, TIME_T_MAX): New macros.
7829 (time_overflow): Move earlier, to before first use.
7830 (hi_time, lo_time): New functions, for an accurate test for
7831 out-of-range times.
7832 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7833 (Fget_internal_run_time): Don't assume time_t fits in int.
7834 (make_time): Use list2 instead of Fcons twice.
7835 (Fdecode_time): More accurate test for out-of-range times.
7836 (check_tm_member): New function.
7837 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7838 (lisp_time_argument): Don't rely on undefined left-shift and
7839 right-shift behavior when checking for time stamp overflow.
8be6f318 7840
fe31d94c
PE
7841 * editfns.c (time_overflow): New function, refactoring common code.
7842 (Fformat_time_string, Fdecode_time, Fencode_time):
7843 (Fcurrent_time_string): Use it.
7844
8be6f318
PE
7845 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7846 * dired.c (make_time): Move to ...
7847 * editfns.c (make_time): ... here.
7848 * systime.h: Note the move.
7849
09d9db2c 78502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7851
126bc0dc
YM
7852 * fringe.c (update_window_fringes): Remove unused variables.
7853
c47cbdfd
YM
7854 * unexmacosx.c (copy_data_segment): Also copy __got section.
7855 (Bug#8223)
7856
7ac80be9
EZ
78572011-03-12 Eli Zaretskii <eliz@gnu.org>
7858
c96bbc66 7859 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7860 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7861 Constify `char *' arguments and their references according to
7862 prototypes in tparam.h.
7863
ecb0f94d 7864 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7865
7ac80be9
EZ
7866 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7867 Adapt all references accordingly.
7868
7869 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7870
ef1fd07e
TT
78712011-03-11 Tom Tromey <tromey@redhat.com>
7872
7873 * buffer.c (syms_of_buffer): Remove obsolete comment.
7874
7ef4b50c
EZ
78752011-03-11 Eli Zaretskii <eliz@gnu.org>
7876
7877 * termhooks.h (encode_terminal_code): Declare prototype.
7878
7879 * msdos.c (encode_terminal_code): Don't declare prototype.
7880
7881 * term.c (encode_terminal_code): Now external again, used by
7882 w32console.c and msdos.c.
7883
44f230aa
SM
7884 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7885 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7886
4b1ec863 78872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7888
1714f52b 7889 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7890
4b1ec863
PE
7891 * fringe.c (update_window_fringes): Mark locals as initialized
7892 (Bug#8227).
7893 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7894
524c7aa6
PE
7895 * alloc.c (mark_fringe_data): Move decl from here ...
7896 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7897 to check its interface.
7898 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7899
a5c0af81 7900 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7901 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7902 (fontset_font): Mark local as initialized.
a9a06e0b 7903 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7904
b4716021
PE
7905 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7906
811e9bac 7907 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7908 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7909 (x_own_selection, Fx_disown_selection_internal): Rename locals
7910 to avoid shadowing.
7911 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7912
7e3ab302
PE
7913 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7914 so that the caller can use some name other than gcpro1.
7915 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7916 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7917 (Fx_backspace_delete_keys_p):
7918 Use them to avoid shadowing, and rename vars to avoid shadowing.
7919 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7920 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7921 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7922 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7923 Remove unused locals.
7e3ab302
PE
7924 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7925 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7926 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7927 macros.
f78faa98 7928
e2b13473
PE
7929 * xterm.h (x_mouse_leave): New decl.
7930
77f23912
PE
7931 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7932 Remove unused functions.
cdf4ba58
PE
7933 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7934 (x_calc_absolute_position): Now static.
7411c686 7935 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7936 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7937 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7938 unless they are used.
38d0b34a
PE
7939 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7940 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7941 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7942 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7943 (x_error_catcher, x_connection_closed, x_error_handler):
7944 (x_error_quitter, xembed_send_message, x_iconify_frame):
7945 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7946 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7947 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7948
44f230aa
SM
7949 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7950 Rename or move locals to avoid shadowing.
6b463e58 7951 (tty_defined_color, merge_face_heights): Now static.
5967d051 7952 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7953 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7954 does not deduce is never used uninitialized.
73719eba
PE
7955 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7956 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7957
426994c3 7958 * terminal.c (store_terminal_param): Now static.
5489860b 7959
032f1620 7960 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7961 (set_frame_menubar): Remove unused local.
d4323972 7962 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7963 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7964 since they might point to immutable storage.
281585b0
PE
7965 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7966 since it's unused otherwise.
032f1620 7967
367c19e5 7968 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7969 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7970 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7971 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7972 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7973 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7974 does not deduce are never used uninitialized.
70739cbe 7975
07b48fa9
PE
7976 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7977
8868a238 7978 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7979 * window.c (window_loop, size_window):
7980 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7981
7e5cf297 7982 * window.c (display_buffer): Now static.
d6550a9f
PE
7983 (size_window): Mark variables that gcc -Wuninitialized
7984 does not deduce are never used uninitialized.
a586633d
PE
7985 * window.h (check_all_windows): New decl, to forestall
7986 gcc -Wmissing-prototypes diagnostic.
5b555da1 7987 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7988
f6095868
PE
7989 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7990 shadowing.
7991 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7992 Include <limits.h>.
7993 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7994 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7995 (load_charset_map): Mark variables that gcc -Wuninitialized
7996 does not deduce are never used uninitialized.
53df7c11 7997 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7998
f38b440c
PE
7999 * coding.c (coding_set_source, coding_set_destination):
8000 Use "else { /* comment */ }" rather than "else /* comment */;"
8001 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8002 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8003 a block, when the outer 'i' will do.
8004 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8005 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8006 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8007 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8008 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8009 Rename locals to avoid shadowing.
8010 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8011 * coding.c (emacs_mule_char, encode_invocation_designation):
8012 Now static, since they're not used elsewhere.
413bb2db 8013 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8014 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8015 (decode_coding_emacs_mule): Mark variables that gcc
8016 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8017 (detect_coding_iso_2022): Initialize a local variable that might
8018 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8019 this initialization is needed. (Bug#8211)
5f58e762
PE
8020 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8021 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8022 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8023 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8024 Remove unused macros.
f38b440c 8025
232b38b9 8026 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8027 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8028 * character.c (string_count_byte8): Likewise.
232b38b9 8029
fb90da1b
PE
8030 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8031 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8032
fb93dbc2
PE
8033 * chartab.c (copy_sub_char_table): Now static, since it's not used
8034 elsewhere.
5c156ace
PE
8035 (sub_char_table_ref_and_range, char_table_ref_and_range):
8036 Rename locals to avoid shadowing.
bbcd0949 8037 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8038
7d3b3862 8039 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8040 (BIDI_BOB): Remove unused macro.
7d3b3862 8041
6be7d3da
PE
8042 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8043 deduce are never used uninitialized.
c2ed9c8b 8044 * term.c (encode_terminal_code): Likewise.
6be7d3da 8045
75f8807f 8046 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8047
50938595
PE
8048 * tparam.h: New file.
8049 * term.c, tparam.h: Include it.
8050 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8051 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8052 Move these decls to tparam.h, and make them agree with what
8053 is actually in tparam.c. The previous trick of using incompatible
8054 decls in different modules does not conform to the C standard.
8055 All callers of tparam changed to use tparam's actual API.
8056 * tparam.c (tparam1, tparam, tgoto):
8057 Use const pointers where appropriate.
8058
fbceeba2
PE
8059 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8060 * cm.h (struct cm): Likewise.
8061 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8062 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8063 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8064 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8065 (turn_on_face, init_tty): Likewise.
8066 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8067
7f3f1250
PE
8068 * term.c (term_mouse_position): Rename local to avoid shadowing.
8069
e6ca6543
PE
8070 * alloc.c (mark_ttys): Move decl from here ...
8071 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8072
c40f8d15
AS
80732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8074
8075 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8076
cfe0661d
JB
80772011-03-09 Juanma Barranquero <lekktu@gmail.com>
8078
8079 * search.c (compile_pattern_1): Remove argument regp, unused since
8080 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8081 (compile_pattern): Don't pass it.
8082
0afb4571
J
80832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8084
8085 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8086 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8087 for ! HAVE_GTK3.
8088 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8089
8090 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8091
8092 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8093 gdk_window_get_screen, gdk_window_get_geometry,
8094 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8095 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8096 (xg_get_pixbuf_from_pixmap): New function.
8097 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8098 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8099 Call xg_get_pixbuf_from_pixmap instead of
8100 gdk_pixbuf_get_from_drawable.
8101 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8102 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8103 (xg_check_special_colors): Use GtkStyleContext and its functions
8104 for HAVE_GTK3.
8105 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8106 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8107 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8108 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8109 Call gtk_widget_get_preferred_size.
0afb4571
J
8110 (xg_frame_resized): gdk_window_get_geometry only takes 5
8111 parameters.
44f230aa
SM
8112 (xg_win_to_widget, xg_event_is_for_menubar):
8113 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8114 (xg_set_widget_bg): New function.
8115 (delete_cb): New function.
895009e1 8116 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8117 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8118 (xg_set_background_color): Call xg_set_widget_bg.
8119 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8120 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8121 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8122 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8123 if ! HAVE_GTK3.
8124 (update_frame_tool_bar): Call gtk_widget_hide.
8125 (xg_initialize): Use GDK_KEY_g.
8126
8127 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8128 if ! HAVE_GTK3
8129 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8130
8131 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8132 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8133 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8134
1c2cc4ef
JB
81352011-03-08 Juanma Barranquero <lekktu@gmail.com>
8136
8137 * w32xfns.c (select_palette): Check success of RealizePalette against
8138 GDI_ERROR, not zero.
8139
33383987 8140See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8141
8142;; Local Variables:
8143;; coding: utf-8
aac0c6e3
MR
8144;; End:
8145
33383987 8146 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8147
8148 This file is part of GNU Emacs.
8149
8150 GNU Emacs is free software: you can redistribute it and/or modify
8151 it under the terms of the GNU General Public License as published by
8152 the Free Software Foundation, either version 3 of the License, or
8153 (at your option) any later version.
8154
8155 GNU Emacs is distributed in the hope that it will be useful,
8156 but WITHOUT ANY WARRANTY; without even the implied warranty of
8157 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8158 GNU General Public License for more details.
8159
8160 You should have received a copy of the GNU General Public License
8161 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.