Cleanup intervals.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
77c7bcb1
DA
12012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Cleanup intervals.
4 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
5 (NULL_INTERVAL_P): Likewise. Adjust users.
6 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P): Adjust
7 comment. Move under #if 0.
8 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
9 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
10
9c08a8d4
DA
112012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
12
13 Check total length of intervals with eassert.
14 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
15 * intervals.c: Change all users to eassert.
16
26d16b35
EZ
172012-08-07 Eli Zaretskii <eliz@gnu.org>
18
19 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist): Rename
20 fields to match removal of FGET and WGET and disuse of
21 INTERNAL_FIELD in Lisp_Cons.
22
c644523b
DA
232012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
24
25 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
26 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
27 name since all xname users are fixed long time ago. Do not
28 use INTERNAL_FIELD.
29 (set_symbol_name, set_symbol_function, set_symbol_plist):
30 (set_symbol_next, set_overlay_plist): New function.
31 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
32 (struct Lisp_Overlay): Likewise.
33 (CVAR, MVAR, SVAR): Remove.
34 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
35 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
36 * xterm.c: Adjust users.
37 * .gdbinit: Change to use name field of struct Lisp_Symbol
38 where appropriate.
39
6a3d20cc
DA
402012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Basic functions to set Lisp_Object and pointer slots of intervals.
43 * intervals.h (interval_set_parent, interval_set_object):
44 (interval_set_left, interval_set_right, interval_set_plist):
45 (interval_copy_parent): New function.
46 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
47 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE): Adjust
48 indentation.
49 (INTERVAL_SIZE): Remove. Adjust users.
50 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
51
4d2b044c
DA
522012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
53
54 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
55 * process.h (PGET): Remove.
56 (struct Lisp_Process): Do not use INTERNAL_FIELD.
57 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
58
d3d50620
DA
592012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
60
61 Drop WGET and revert read access to Lisp_Objects slots of struct window.
62 * window.h (WGET): Remove.
63 (struct window): Do not use INTERNAL_FIELD.
64 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
65 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
66 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
67 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
68 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
69 Adjust users.
70
d10a51dc
CY
712012-08-07 Chong Yidong <cyd@gnu.org>
72
73 * window.c (Fwindow_edges, Fwindow_pixel_edges)
74 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
75 (Fdelete_window_internal): Signal an error if the window is not on
76 a live frame (Bug#12025).
77
e69b0960
DA
782012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
79
80 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
81 * frame.h (FGET): Remove.
82 (struct frame): Do not use INTERNAL_FIELD.
83 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
84 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
85 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
86 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
87
25a20a3a
JB
882012-08-06 Juanma Barranquero <lekktu@gmail.com>
89
90 * w32.c: Silence compiler warnings.
91 (map_w32_filename): Remove unused variable `is_fat'.
92 (chase_symlinks): Add parentheses around expression.
93
1c6f11f4
GM
942012-08-06 Glenn Morris <rgm@gnu.org>
95
1db4583a
GM
96 * sysdep.c: Respect BROKEN_GETWD.
97
1c6f11f4
GM
98 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
99 Let configure handle it.
100 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
101
2b90362b
DA
1022012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
103
104 Use GCALIGNMENT where appropriate.
105 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
106 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
107 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
108
5f50daf2
EZ
1092012-08-06 Eli Zaretskii <eliz@gnu.org>
110
111 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
112 use FRAME_MENU_BAR_ITEMS as an lvalue.
113
cbcc7007
SM
1142012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
115
116 * buffer.h (struct buffer): Revert `indirections' to a simple int;
117 that should be sufficient for everyone.
118
4d365fa4
JD
1192012-08-06 Jan Djärv <jan.h.d@swipnet.se>
120
121 * keyboard.c (timer_check_2): Add break so timer_check returns next
122 timeout.
123
dd86bd82
DA
1242012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
125
126 Fix Windows build errors introduced after converting to WGET and WSET.
127 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
128 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
129
054e1668
JD
1302012-08-06 Jan Djärv <jan.h.d@swipnet.se>
131
132 * nsterm.m (ns_frame_rehighlight): Use FSET.
133
134 * nsmenu.m (ns_update_menubar): Use FSET.
135
21238f11
DA
1362012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
137
138 Separate read and write access to Lisp_Object slots of Lisp_Process.
139 * process.h (PGET, PSET): New macros similar to AREF and ASET.
140 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
141
077288cf
DA
1422012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
143
144 Separate read and write access to Lisp_Object slots of struct window.
145 * window.h (WGET, WSET): New macros similar to AREF and ASET.
146 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
147 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
148 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
149 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
150 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
151 Adjust users.
152
71688bd7
DA
1532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
154
155 Fix Windows build errors introduced after converting to FGET and FSET.
156 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
157 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
158 (w32_judge_scroll_bars): Change to use FSET.
159 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
160
f99bac93
DA
1612012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
162
163 Fix replacement typo.
164 * window.c (replace_window): Set root_window instead of
165 selected_window. This fixes a total window subsystem
166 malfunction reported by Bastien Guerry <bzg@gnu.org>.
167
8c2a0f2d
GM
1682012-08-06 Glenn Morris <rgm@gnu.org>
169
170 * lisp.mk (lisp): Add language/persian.elc.
171
edd74c35
DA
1722012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
173
174 Separate read and write access to Lisp_Object slots of struct frame.
175 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
176 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
177 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
178 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
179 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
180
8671676c
AS
1812012-08-05 Andreas Schwab <schwab@linux-m68k.org>
182
183 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
184
663e2b3f
DA
1852012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
186
187 Generalize common compile-time constants.
188 * lisp.h (header_size, bool_header_size, word_size): Now here.
189 (struct Lisp_Vector): Add comment.
190 (struct Lisp_Bool_Vector): Move up to define handy constants.
191 (VECSIZE, PSEUDOVECSIZE): Simplify.
192 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
193 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
194 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
195 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
196 * xfont.c, xmenu.c: Use word_size where appropriate.
197
d32e47af
LM
1982012-08-05 Lawrence Mitchell <wence@gmx.li>
199
200 * search.c (Freplace_match): Treat \? in the replacement text
201 literally (Bug#8161).
202
e5d9c0d1
CY
2032012-08-05 Chong Yidong <cyd@gnu.org>
204
205 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
206 * frame.c (Vdelete_frame_functions):
207 * emacs.c (Vkill_emacs_hook): Doc fix.
208
8da0576b
EZ
2092012-08-04 Eli Zaretskii <eliz@gnu.org>
210
211 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
212 --with-x-toolkit=no builds.
213 Reported by Carsten Mattner <carstenmattner@gmail.com>.
214
02676e5d
CY
2152012-08-04 Chong Yidong <cyd@gnu.org>
216
217 * syntax.c (Fmodify_syntax_entry): Doc fix.
218
97147da9
EZ
2192012-08-04 Eli Zaretskii <eliz@gnu.org>
220
76151e2c
EZ
221 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
222 * w32.c (init_environment): Change the default values of many
223 environment variables in dflt_envvars[] to NULL, to avoid pushing
224 them into environment when they were not already defined. Remove
225 the code that deletes site-lisp subdirectories from the default
226 value of EMACSLOADPATH, as it is no longer needed.
227 (check_windows_init_file): Now external, not static. Use
228 Vload_path as is, without adding anything, as this function is now
229 called when Vload_path is already set up.
230
231 * w32.h (check_windows_init_file): Add prototype.
232
233 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
234 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
235 compatibility with Posix platforms.
236 (main): Move the call to check_windows_init_file to here from
237 w32.c.
238 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
239 any, in the DEFALT argument into the root of the Emacs build or
240 installation tree, as appropriate.
241
242 * callproc.c (init_callproc_1): Call decode_env_path instead of
243 doing its equivalent by hand.
244 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
245 the code that sets Vexec_path run on MS-Windows.
246
247 * lread.c (init_lread): Add comments to #ifdef's.
248
97147da9
EZ
249 * msdos.c (dos_set_window_size, IT_update_begin)
250 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
251 instead of direct references.
252
185ee146
PE
2532012-08-04 Paul Eggert <eggert@cs.ucla.edu>
254
255 Export DEFAULT_REHASH_* to GDB.
256 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
257 Now constants, not macros.
258
8834c57a
PE
2592012-08-03 Paul Eggert <eggert@cs.ucla.edu>
260
98c6f1e3
PE
261 Remove unnecessary casts involving pointers.
262 These casts are no longer needed now that we assume C89 or later,
263 since they involve casting to or from void *.
264 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
265 (make_pure_float, make_pure_vector):
266 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
267 * macros.c (Fstart_kbd_macro):
268 * menu.c (find_and_return_menu_selection):
269 * minibuf.c (read_minibuf_noninteractive):
270 * sysdep.c (closedir):
271 * xdisp.c (x_produce_glyphs):
272 * xfaces.c (compare_fonts_by_sort_order):
273 * xfns.c (x_real_positions, select_visual):
274 * xselect.c (x_stop_queuing_selection_requests)
275 (x_get_window_property, x_get_window_property_as_lisp_data):
276 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
277 Remove unnecessary pointer casts.
278 * alloc.c (record_xmalloc): New function.
279 * lisp.h (record_xmalloc): New decl.
280 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
281 more like a function. This is because the pointer cast is not
282 needed. All uses changed.
283 * print.c (print_string, print_error_message): Avoid length recalc.
284
8834c57a
PE
285 Improve fix for macroexp crash with debugging (Bug#12118).
286 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
287 ARRAY_MARK_FLAG when checking subscripts, because ASET is
288 not supposed to be invoked from the garbage collector.
289 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
290 (gc_aset): New function, which is like ASET but can be
291 used in the garbage collector.
292 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
293 (set_hash_index): Use it instead of ASET.
294
6dad7178
EZ
2952012-08-03 Eli Zaretskii <eliz@gnu.org>
296
297 Support symlinks on latest versions of MS-Windows.
298 * w32.c: Include winioctl.h and aclapi.h.
299 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
300 (revert_to_self): Forward declarations of static functions.
301 <static BOOL g_b_init_get_security_info>:
302 <g_b_init_create_symbolic_link>: New static flags.
303 (globals_of_w32): Initialize them to zero.
304 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
305 (map_w32_filename): Improve commentary. Simplify switch.
306 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
307 headers (most versions of MinGW w32api don't).
308 (get_security_info, create_symbolic_link)
309 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
310 New functions.
311 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
312 in the argument file name.
313 (sys_access): Call unc_volume_file_attributes only if
314 GetFileAttributes fails with network-related error codes.
315 (sys_rename): Diagnose renaming of a symlink when the user doesn't
316 have the required privileges.
317 (get_file_security_desc_by_name): Renamed from
318 get_file_security_desc.
319 (stat_worker): New function, with most of the guts of 'stat', and
320 with addition of handling of symlinks and support for 'lstat'. If
321 possible, get file's attributes and security information by
322 handle, not by name. Produce S_IFLNK bit for symlinks, when
323 called from 'lstat'.
324 (stat, lstat): New functions, call 'stat_worker'.
325 (symlink, readlink, careadlinkat): Rewritten to create and resolve
326 symlinks when the underlying filesystem supports them.
327
f162bcc3
PE
3282012-08-02 Paul Eggert <eggert@cs.ucla.edu>
329
79ea6c20
PE
330 Fix macroexp crash on Windows with debugging (Bug#12118).
331 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
332 checking subscripts; problem introduced with the recent
333 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
334 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
335 since it's used in non-static inline functions now.
336
c0ce93fd
PE
337 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
338 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 339
f162bcc3
PE
340 Use C99-style 'extern inline' if available.
341 * buffer.h (BUFFER_INLINE):
342 * category.h (CATEGORY_INLINE):
343 * character.h (CHARACTER_INLINE):
344 * charset.h (CHARSET_INLINE):
345 * composite.h (COMPOSITE_INLINE):
346 * dispextern.h (DISPEXTERN_INLINE):
347 * lisp.h (LISP_INLINE):
348 * systime.h (SYSTIME_INLINE):
349 New macro, replacing 'static inline' in this header.
350 * buffer.h, category.h, character.h, charset.h, composite.h:
351 * dispextern.h, lisp.h, systime.h:
352 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
353 * alloc.c (LISP_INLINE):
354 * buffer.c (BUFFER_INLINE):
355 * category.c (CATEGORY_INLINE):
356 * character.c (CHARACTER_INLINE):
357 * charset.c (CHARSET_INLINE):
358 * composite.c (COMPOSITE_INLINE):
359 * dispnew.c (DISPEXTERN_INLINE):
360 * sysdep.c (SYSTIME_INLINE):
361 Define to EXTERN_INLINE, so that the corresponding functions
362 are compiled into code.
363 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
364 (INLINE_HEADER_END): New macros.
365 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
366 since it's used in non-static inline functions now.
a8333d03 367 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 368
837b365b
GM
3692012-08-02 Glenn Morris <rgm@gnu.org>
370
d66b744d
GM
371 * s/: Remove empty directory.
372
837b365b
GM
373 * s/ms-w32.h: Move to ../nt/inc.
374 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
375 Update for new ms-w32.h location.
376
13294f95
PE
3772012-08-02 Paul Eggert <eggert@cs.ucla.edu>
378
379 Port to Solaris 8.
380 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
381
90df0db3
GM
3822012-08-02 Glenn Morris <rgm@gnu.org>
383
384 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
385 hard-coding the path separator.
386
4939150c
PE
3872012-08-01 Paul Eggert <eggert@cs.ucla.edu>
388
389 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
390 This how ASET and AREF are supposed to work, and makes
391 it easier to think about future improvements. See
392 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
393 * charset.h (set_charset_attr): New function.
394 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
395 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
396 (aref_addr): New function. All uses of &AREF(...) changed.
397 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
398 (set_hash_index): New functions. All lvalue-style uses of
399 HASH_KEY etc. changed.
400 * keyboard.c (set_prop): New function. All lvalue-style uses
401 of PROP changed.
402
947b2afd
AA
4032012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
404
405 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
406 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
407 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
408 * nsfns.m (ns_set_name_as_filename): Likewise.
409 * nsmenu.m (ns_update_menubar): Likewise.
410 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
411
4f5d0325
EZ
4122012-08-01 Eli Zaretskii <eliz@gnu.org>
413
2008beae
EZ
414 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
415 Adapt to latest changes in field names of the corresponding Lisp
288479f6 416 objects.
2008beae 417
4f5d0325
EZ
418 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
419
fe3cc771
GM
4202012-08-01 Glenn Morris <rgm@gnu.org>
421
422 * s/msdos.h: Remove file.
423 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
424 * Makefile.in (S_FILE): Remove.
425 (config_h): Remove S_FILE.
426
c90acc54
JB
4272012-08-01 Juanma Barranquero <lekktu@gmail.com>
428
429 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
430 Remove; moved to nt/config.nt.
431
d8a05828
DA
4322012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
433
434 Use INTERNAL_FIELD for conses and overlays.
435 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
436 Remove obsolete comment.
437 (MVAR): New macro.
438 (struct Lisp_Overlay): Use INTERNAL_FIELD.
439 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
440
8271d590
DA
4412012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
442
443 Use INTERNAL_FIELD for symbols.
444 * lisp.h (SVAR): New macro. Adjust users.
445 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
446 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
447
3193acd2
DA
4482012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
449
450 Use INTERNAL_FIELD for processes.
451 * process.h (PVAR): New macro. Adjust style.
452 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
453 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
454
3a45383a
DA
4552012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
456
457 Use INTERNAL_FIELD for windows.
458 * window.h (WVAR): New macro.
459 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
460 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
461 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
462 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
463 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
464 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
465
c1dbc63c
PE
4662012-08-01 Paul Eggert <eggert@cs.ucla.edu>
467
468 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
469
5c0c0e8a
GM
4702012-08-01 Glenn Morris <rgm@gnu.org>
471
472 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
473 Move to configure.ac.
474
552a99b4
JB
4752012-08-01 Juanma Barranquero <lekktu@gmail.com>
476
477 * makefile.w32-in (CONFIG_H): Update dependencies.
478 (CONF_POST_H): New macro.
479
480 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
481
8d8e2dfe
GM
4822012-07-31 Glenn Morris <rgm@gnu.org>
483
bc96620a
GM
484 * Makefile.in (S_FILE): No longer set by configure.
485
476b1b2d
GM
486 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
487 is available.
488 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
489
b2c7a106
GM
490 * process.h (NULL_DEVICE):
491 * emacs.c (SEPCHAR):
492 * editfns.c (USER_FULL_NAME): Let configure set them.
493
d53d062a
GM
494 * s/README, s/template.h: Remove files.
495
4515017f
GM
496 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
497
8d8e2dfe
GM
498 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
499 Move to configure.ac.
500
5b20b3cc
EZ
5012012-07-31 Eli Zaretskii <eliz@gnu.org>
502
1e0afd9a
EZ
503 * .gdbinit (xframe): Adapt to introduction of FVAR and the
504 resulting renaming of 'struct frame' members.
505
5b20b3cc
EZ
506 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
507
508 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
509 after introduction of FVAR.
510
f1310128
JD
5112012-07-31 Jan Djärv <jan.h.d@swipnet.se>
512
79e721e0
JD
513 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
514
515 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
516 instead of compositeToPoint.
517 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
518
8d7c7eed 519 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 520
e34f7f79
DA
5212012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
522
523 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
524 * lisp.h (INTERNAL_FIELD): New macro.
525 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
526 (BVAR): Change to use INTERNAL_FIELD.
527 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
528 (KVAR): Change to use INTERNAL_FIELD.
529 * frame.h (FVAR): New macro.
530 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
531 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
532 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
533 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
534 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
535
c09bfb2f
DA
5362012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
537
538 Miscellaneous fixes for non-default X toolkits.
539 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
540 * xterm.c (x_frame_of_widget): Remove redundant prototype.
541 Move under #ifdef USE_LUCID.
542 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
543 definition and usage to avoid warnings.
544
14c114ae
JD
5452012-07-31 Jan Djärv <jan.h.d@swipnet.se>
546
547 * nsterm.m (openFiles): Fix previous checkin.
548
3bd21e82
PE
5492012-07-31 Paul Eggert <eggert@cs.ucla.edu>
550
551 * indent.c (compute_motion): Remove unused local.
552
c1529ded
GM
5532012-07-31 Glenn Morris <rgm@gnu.org>
554
400d5621
GM
555 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
556
268e2432
GM
557 * conf_post.h [USG5_4]:
558 Move remaining contents of s/usg5-4-common.h here.
559 * s/usg5-4-common.h: Remove file.
560
7552f3ee
GM
561 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
562 * s/irix6-5.h: Remove file.
563
6a381852
GM
564 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
565 * s/darwin.h: Remove file.
566
c1529ded
GM
567 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
568 * s/hpux10-20.h: Remove file, which is now empty.
569
b429a4ee
GM
5702012-07-30 Glenn Morris <rgm@gnu.org>
571
572 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
573 * Makefile.in (config_h): Add conf_post.h.
574 * makefile.w32-in (CONFIG_H): Add conf_post.h.
575
adff3182
JD
5762012-07-30 Jan Djärv <jan.h.d@swipnet.se>
577
578 * nsterm.m (ns_do_open_file): New variable.
b9031d69 579 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
580 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
581 files only if ns_do_open_file.
582
c32af1e4
PE
5832012-07-30 Paul Eggert <eggert@cs.ucla.edu>
584
7393bcbb
PE
585 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
586 This no-op macro hasn't been needed for many years.
587 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
588
c32af1e4
PE
589 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
590 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
591 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
592 gdb_make_enums_visible.
593 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
594 (DIRECTORY_SEP): Now a constant, not a macro.
595
302fc036
EZ
5962012-07-30 Eli Zaretskii <eliz@gnu.org>
597
598 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
599 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
600
601 * w32term.c <w32_keyboard_codepage>: Renamed from
602 keyboard_codepage and now external. All users changed.
603
604 * w32term.h: Add declaration of w32_keyboard_codepage.
605
606 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
607 the codepage to translate keys to Unicode. If this argument is
608 -1, use the value returned by GetConsoleCP. All callers changed.
609
88fb40b4
PE
6102012-07-30 Paul Eggert <eggert@cs.ucla.edu>
611
0aee6912
PE
612 Update .PHONY listings in makefiles.
613 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
614 bootstrap-clean, distclean, maintainer-clean, versioclean,
615 extraclean, frc.
616
88fb40b4
PE
617 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
618 This is a bit clearer. Fix some commentary typos.
619
0a763bd1
GM
6202012-07-30 Glenn Morris <rgm@gnu.org>
621
32bac6d6
GM
622 * s/netbsd.h: Let configure include signal.h if needed.
623 Remove file, which is now empty.
624
b65e7c46
GM
625 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
626 Let configure set them.
627 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
628 No more need to undefine.
0a763bd1 629
169304bd
AS
6302012-07-30 Andreas Schwab <schwab@linux-m68k.org>
631
632 * keymap.c (Fkey_description): Don't remove 0x80 bit from
633 non-single-byte char when adding meta modifier. (Bug#12090)
634
6cd7a139
DA
6352012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
636
637 Convert safe_call to use variable number of arguments.
638 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
639 (safe_call2): Fix comment.
640 * lisp.h (safe_call): Adjust prototype.
641 * coding.c (encode_coding_object): Change to use safe_call2.
642 * xfaces.c (merge_face_heights): Change to use safe_call1.
643
d34d6ffc
GM
6442012-07-30 Glenn Morris <rgm@gnu.org>
645
7b8a48e4 646 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 647 does that unconditionally. Remove file, which is now empty.
7b8a48e4 648
d34d6ffc
GM
649 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
650 Remove empty files.
651
03a660a6
PE
6522012-07-30 Paul Eggert <eggert@cs.ucla.edu>
653
654 Export to GDB most of lisp.h's remaining object-like macros.
655 * lisp.h (min, max): Move earlier, because they're used earlier now.
656 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
657 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
658 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
659 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
660 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
661 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
662 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
663 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
664 Now constants, for GDB. They need not be macros.
665 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
666 Now constants, for GDB, as well as macros, for static initializers.
667 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
668 Move to after the definition of struct Lisp_Char_Table,
669 since the former now needs that type defined.
670 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
671 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
672 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
673 New enums, for gdb_make_enums_visible.
674 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 675 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
676 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
677 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
678 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
679 enum maxargs, enum MAX_ALLOCA.
680 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
681 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
682 no longer needed, now that they are done in lisp.h.
683
e499d0ee
DA
6842012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Cleanup string bytes checking.
687 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
688 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
689 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
690 (check_sblock, compact_small_strings): Simplify.
691
d5040d2d
PE
6922012-07-29 Paul Eggert <eggert@cs.ucla.edu>
693
694 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
695 These macros are confusing and no longer need to be defined, as
696 the enum values now suffice. All uses replaced with definiens.
697 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
698
7f259ae6
JB
6992012-07-29 Juanma Barranquero <lekktu@gmail.com>
700
701 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
702 ($(BLD)/w32console.$(O)): Update dependencies.
703
7e63e0c3
DA
7042012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
705
706 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
707 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
708 time. Adjust users.
709 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
710
ffd817eb
JD
7112012-07-29 Jan Djärv <jan.h.d@swipnet.se>
712
713 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
714 setting sitelisp (Bug#12010).
715
417a7a0e
EZ
7162012-07-29 Eli Zaretskii <eliz@gnu.org>
717
718 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
719
720 * w32heap.c (cache_system_info):
721 * w32.c (sys_rename):
722 * w32proc.c (find_child_console, sys_kill): All users changed.
723
387d4d92
PE
7242012-07-29 Paul Eggert <eggert@cs.ucla.edu>
725
726 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
727
55a6cca6
EZ
7282012-07-29 Eli Zaretskii <eliz@gnu.org>
729
730 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
731
dbcf001c
DA
7322012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
733
734 Cleanup statistics calculation in Fgarbage_collect.
735 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
736 zombies percentage calculation. Simplify elapsed time calculation.
737
e2688e4a
DA
7382012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
739
740 Generalize marker debugging code under MARKER_DEBUG and use eassert.
741 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
742 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
743 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
744 (replace_range, replace_range_2, del_range_2): Change to eassert.
745 * marker.c (byte_char_debug_check): Adjust style.
746
b46a6a83
PE
7472012-07-29 Paul Eggert <eggert@cs.ucla.edu>
748
749 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
750 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
751 long-ago-commented-out code that talks about "WIN32".
752 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
753 All uses changed.
754
e32a5799
PE
7552012-07-28 Paul Eggert <eggert@cs.ucla.edu>
756
757 Use Gnulib stdalign module (Bug#9772, Bug#9960).
758 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
759 Simplify by using alignof.
760 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
761 * lisp.h: Include <stdalign.h>.
762 (GCALIGNMENT): New macro and constant.
763 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
764 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
765 (stdalign): New macro, if not already defined.
766
df81cd29
EZ
7672012-07-28 Eli Zaretskii <eliz@gnu.org>
768
01bd1b0d
EZ
769 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
770 * w32inevt.c: Include w32inevt.h.
771 (w32_read_console_input): New inline function, calls either
772 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
773 w32_console_unicode_input.
774 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
775 (w32_kbd_patch_key, key_event): Use the codepage returned by
776 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
777 (key_event): use uChar.UnicodeChar only if
778 w32_console_unicode_input is non-zero.
779
780 * w32console.c: Include w32heap.h.
781 <w32_console_unicode_input>: New global variable.
782 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
783 family of Windows, zero otherwise.
784
785 * w32inevt.h: Declare w32_console_unicode_input.
786
df81cd29
EZ
787 * xdisp.c (init_iterator): Don't reference tip_frame in a build
788 --without-x. (Bug#11742)
789
c20fdd9e
PE
7902012-07-27 Paul Eggert <eggert@cs.ucla.edu>
791
792 Adjust GDB to reflect pvec_type changes (Bug#12036).
793 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
794 2012-07-04 changes to pseudovector representation. Problem
795 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
796
32770973 7972012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
798
799 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
800 bus address.
801 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
802
3438fe21
EZ
8032012-07-27 Eli Zaretskii <eliz@gnu.org>
804
bcfbc9de
EZ
805 * alloc.c (listn): Fix the order the arguments are consed onto the
806 list.
807
3438fe21
EZ
808 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
809 enumeration constants, as PURE and HEAP are too general, and clash
810 with other headers and sources, such as gmalloc.c and the
811 MS-Windows system headers. All users changed.
812
eeaea515
DA
8132012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
814
815 Revert last save_excursion_save and save_excursion_restore changes.
816 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
817 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
818
073c88c2
DA
8192012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
820
821 Fix recently-introduced typos in Windows port.
822 Reported by Martin Rudalics <rudalics@gmx.at>.
823 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 824 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 825
4706125e
PE
8262012-07-27 Paul Eggert <eggert@cs.ucla.edu>
827
828 Improve GDB symbol export (Bug#12036).
829 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
830 arms of an 'if', not using conditional expressions; otherwise GDB
831 complains about the types in the unevaluated arm when the argument
832 is an integer literal.
833 (xgetint): Simplify expression.
834 * alloc.c (gdb_make_enums_visible): New constant. This ports to
835 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
836 Zaretskii in <http://bugs.gnu.org/12036#13>.
837 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
838 needed now that we have gdb_make_enums_visible.
839 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
840 (enum enum_USE_LSB_TAG):
841 New enum types, packaging up enums that need to be exported to GDB.
842
694b6c97
DA
8432012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
844
845 Utility function to make a list from specified amount of objects.
846 * lisp.h (enum constype): New datatype.
847 (listn): New prototype.
848 * alloc.c (listn): New function.
849 (Fmemory_use_count, syms_of_alloc): Use it.
850 * buffer.c (syms_of_buffer): Likewise.
851 * callint.c (syms_of_callint): Likewise.
852 * charset.c (define_charset_internal): Likewise.
853 * coding.c (syms_of_coding): Likewise.
854 * keymap.c (syms_of_keymap): Likewise.
855 * search.c (syms_of_search): Likewise.
856 * syntax.c (syms_of_syntax): Likewise.
857 * w32.c (init_environment): Likewise.
858 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
859 * xdisp.c (syms_of_xdisp): Likewise.
860 * xfns.c (syms_of_xfns): Likewise.
861
6195f384
DA
8622012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
863
864 Fast save_excursion_save and save_excursion_restore.
865 * lisp.h (struct Lisp_Excursion): New data type.
866 (PVEC_EXCURSION): New pseudovector type.
867 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
868 to deal with it. Adjust comments.
869 (init_marker, attach_marker): New prototype.
870 (unchain_marker): Adjust prototype.
871 * marker.c (attach_marker): Change to global.
872 (init_marker): New function.
873 * alloc.c (Fmake_marker, build_marker): Use it.
874 (build_marker): More easserts.
875 (mark_object): Handle struct Lisp_Excursion.
876 * editfns.c (save_excursion_save, save_excursion_restore):
877 Reimplement to use struct Lisp_Excursion. Add comments.
878
5eceb8fb
PE
8792012-07-26 Paul Eggert <eggert@cs.ucla.edu>
880
881 Fix export of symbols to GDB (Bug#12036).
882 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
883 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
884 emacs.c, as this is a more-suitable home. Had this been done earlier
885 the fix for 12036 would have avoided some of the problems noted in
886 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
887 would have been more obvious.
562157c8
PE
888 * emacs.c: Do not include <verify.h>; no longer needed.
889 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
890 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
891 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
892 Remove; now done in lisp.h.
893 * lisp.h (PUBLISH_TO_GDB): New macro.
894 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
895 (DATA_SEG_BITS): Use it.
896 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
897 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
898 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
899 not be usable in #if. This simplifies things.
900
d6749401
JB
9012012-07-26 Juanma Barranquero <lekktu@gmail.com>
902
903 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
904
1781b9e9
PE
9052012-07-26 Paul Eggert <eggert@cs.ucla.edu>
906
d89518db 907 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
908 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
909 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
910 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
911 Adjust to changes in lisp.h and emacs.c, by using
912 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
913 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
914 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
915 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
916 instead of gdb_valbits.
917 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
918 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
919 instead of gdb_array_mark_flag.
920 (xboolvector): Get size from $->size, not $->header.size.
921 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
922 (xreload, hook-run, hookpost-run): Remove.
923 * emacs.c: Include <verify.h>.
924 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
925 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
926 Remove.
927 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
928 (gdb_USE_LSB_TAG): New enum constants.
929 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
930 Also define these as enum constants, so they're visible to GDB.
931 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
932 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
933 as constants, so they're visible to GDB.
934 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
935 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
936 Now enum constants, not macros, so they're visible to GDB.
937 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
938 more convenient now. All uses changed.
939 (VALMASK) [USE_LSB_TAG]: Also define in this case.
940 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
941
3628596a
DA
9422012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
943
944 Explicitly free restriction data that are not needed anymore.
945 * editfns.c (save_restriction_restore): Free restriction data.
946
7abaf5cc
SM
9472012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
948
949 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
950 add argument, tune behavior, and adjust all callers.
951
71f88e00
PE
9522012-07-25 Paul Eggert <eggert@cs.ucla.edu>
953
954 Use typedef for EMACS_INT, EMACS_UINT.
955 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
956 than macros. This simplifies debugging in the usual case, since
957 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
958 and it allows expressions involving EMACS_INT casts.
959 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
960
57ec3034
JD
9612012-07-25 Jan Djärv <jan.h.d@swipnet.se>
962
963 * nsterm.m (ns_read_socket): Return early if there is a modal
964 window (Bug#12043).
965
8137e7b3
MR
9662012-07-25 Martin Rudalics <rudalics@gmx.at>
967
968 * frame.c (Fredirect_frame_focus): In doc-string don't mention
969 that FOCUS-FRAME can be omitted.
970
04e9897c
DA
9712012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
972
973 Adjust buffer text indirection counters at the end of Fkill_buffer.
974 * buffer.c (Fkill_buffer): Adjust indirection counters when the
975 buffer is definitely dead. This should really fix an issue reported
976 by Christoph Scholtes again. (Bug#12007).
977 (init_buffer_once): Initialize indirection counters of
978 buffer_defaults and buffer_local_symbols (for sanity and safety).
979
8a0484e1
EZ
9802012-07-24 Eli Zaretskii <eliz@gnu.org>
981
982 * xdisp.c (init_iterator): Don't compute dimensions of truncation
983 and continuation glyphs on tooltip frames, leave them at zero.
984 Avoids continued lines in tooltips. (Bug#11832)
985
fa691a83
DA
9862012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
987
988 Simplify copy_overlay.
04e9897c 989 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
990 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
991
436bc8e0
EZ
9922012-07-23 Eli Zaretskii <eliz@gnu.org>
993
994 * print.c (print_object): Don't crash when a frame's name is nil
995 or invalid. (Bug#12025)
996
997 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
998 it signals an error when a tooltip frame is being created.
999
d7a7fda3
DA
10002012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 Cleanup miscellaneous objects allocation and initialization.
1003 * alloc.c (allocate_misc): Change to static. Add argument to
1004 specify the subtype. Adjust comment and users.
1005 (build_overlay): New function.
1006 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1007 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1008 (allocate_misc): Remove prototype.
1009 (build_overlay): Add prototype.
1010
10112012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1012
1013 Swap buffer text indirection counters in Fbuffer_swap_text.
1014 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1015 This avoids crash reported by Christoph Scholtes at
1016 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1017
9d7fa573
JD
10182012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1019
1020 * nsmenu.m (Popdown_data): New struct.
1021 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1022 free Popdown_data.
1023 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1024 (initWithContentRect): Make imgView and contentView non-static
1025 and autorelease them. Also autorelease img and matrix (Bug#12005).
1026 (dealloc): Remove (Bug#12005).
1027
0dd6d66d
DA
10282012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 Adjust consing_since_gc when objects are explicitly freed.
1031 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1032 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1033 (free_cons, free_misc): Subtract object size from consing_since_gc.
1034
d36d71df
DA
10352012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1036
1037 Simplify and cleanup markers positioning code.
1038 * marker.c (attach_marker): More useful eassert.
1039 (live_buffer, set_marker_internal): New function.
1040 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1041 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1042
fb9ea40f
PE
10432012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1044
1045 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1046 as it's limited by the amount of memory, not by INT_MAX.
1047
2d5c5f7d
EZ
10482012-07-21 Eli Zaretskii <eliz@gnu.org>
1049
07fb592e
EZ
1050 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1051 in special-event-map. See the discussion at
1052 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1053 for the reasons.
1054
37a9eac8 1055 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
1056 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
1057 Fabrice Popineau <fabrice.popineau@supelec.fr>.
1058
c4328746
JD
10592012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1060
1061 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1062 (conversationIdentifier): Return value is NSInteger.
784051c4 1063 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1064
6e5d1c12
CY
10652012-07-21 Chong Yidong <cyd@gnu.org>
1066
1067 * window.c (decode_any_window): Signal an error if the window is
1068 on a dead frame (Bug#11984).
1069
9928463d
DA
10702012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1071
1072 Add indirection counting to speed up Fkill_buffer.
1073 * buffer.h (struct buffer): New member.
1074 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1075 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1076 base buffer indirection counter.
1077 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1078 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1079 through buffer list if indirection counter is 0.
1080
f8643a6b
DA
10812012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1082
1083 Extend the value returned by Fgarbage_collect with heap statistics.
1084 * alloc.c (Qheap): New symbol.
1085 (syms_of_alloc): DEFSYM it.
1086 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1087 (Fmemory_free): Remove.
1088 (syms_of_alloc): Don't defsubr it.
1089 * buffer.c (Fcompact_buffer): Remove.
1090 (syms_of_buffer): Don't defsubr it.
1091
dac616ff
DA
10922012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 Make maybe_gc inline.
1095 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1096 * lisp.h (consing_since_gc, gc_relative_threshold)
1097 (memory_full_cons_threshold): Revert declaration.
1098 (maybe_gc): Remove prototype, define as inline.
1099 * alloc.c: Remove old commented-out code.
1100 (consing_since_gc, gc_relative_threshold)
1101 (memory_full_cons_threshold): Revert to global.
1102 (maybe_gc): Remove.
1103
d7ea76b4
DA
11042012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1105
1106 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1107 * lisp.h (build_unibyte_string): New function.
1108 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1109 * sysdep.c, w32fns.c, xfns.c: Use it.
1110 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1111 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1112 Adjust users accordingly.
1113 * font.h (font_open_by_name): Adjust prototype.
1114
765e61e3
DA
11152012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1116
1117 Cleanup calls to Fgarbage_collect.
1118 * lisp.h (maybe_gc): New prototype.
1119 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1120 Remove declarations.
1121 * alloc.c (maybe_gc): New function.
1122 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1123 Make them static.
1124 * bytecode.c (MAYBE_GC): Use maybe_gc.
1125 * eval.c (eval_sub, Ffuncall): Likewise.
1126 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1127 to avoid dependency from auto-save feature.
1128
52b852c7
PE
11292012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1132 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1133 'for_each_per_buffer_object_at'.
1134 All uses changed. It's better to use upper-case for macros that
1135 cannot be implemented as functions, to give the reader a clue
1136 that they're special.
1137
5db81e33
SM
11382012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1139
1140 * alloc.c (Fgarbage_collect): Tweak docstring.
1141
5b835e1d
DA
11422012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 Tweak the value returned from Fgarbage_collect again.
1145 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1146 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1147 Adjust documentation.
1148 (total_vector_bytes): Rename to total_vector_slots, adjust
1149 accounting.
1150 (total_free_vector_bytes): Rename to total_free_vector_slots,
1151 adjust accounting.
1152 (Qstring_bytes, Qvector_slots): New symbols.
1153 (syms_of_alloc): DEFSYM them.
1154
9cd47b72
DA
11552012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1156
1157 Buffer compaction primitive which may be used from Lisp.
1158 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1159 (syms_of_buffer): Register Fcompact_buffer.
1160 * alloc.c (Fgarbage_collect): Use compact_buffer.
1161 * buffer.h (compact_buffer): New prototype.
1162 (struct buffer_text): New member.
1163
d17337e5
DA
11642012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1165
1166 New macro to iterate over all buffers, miscellaneous cleanups.
1167 * lisp.h (all_buffers): Remove declaration.
1168 * buffer.h (all_buffers): Add declaration, with comment.
1169 (for_each_buffer): New macro.
1170 * alloc.c (Fgarbage_collect, mark_object): Use it.
1171 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1172 (init_buffer): Likewise.
1173 * data.c (Fset_default): Likewise.
1174 * coding.c (code_conversion_restore): Remove redundant check
1175 for dead buffer.
1176 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1177
60cfd278
AS
11782012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1179
1180 Fix bug that created negative-length intervals.
1181 * intervals.c (merge_interval_right, merge_interval_left):
1182 Do not zero out this interval if it is absorbed by its children,
1183 as this interval's total length doesn't change in that case. See
1184 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1185
d06714cb
PE
11862012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1187
83713154
PE
1188 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1189 when invoking (make-bool-vector N t) and N is a positive
1190 multiple of 8 -- the last 8 bits were mistakenly cleared.
1191
d06714cb
PE
1192 Remove some struct layout assumptions in bool vectors.
1193 * alloc.c (bool_header_size): New constant.
1194 (header_size, word_size): Move earlier, as they're now used earlier.
1195 Use 'word_size' in a few more places, where it's appropriate.
1196 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1197 padding before the data member of a bool vector.
1198 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1199 than doing the check by hand with an abort ().
1200
464d5a5e
SM
12012012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1202
5fbc0409
SM
1203 * eval.c (Fdefvar): Don't check constants since we only set the var if
1204 it's not yet defined anyway (bug#11904).
1205
464d5a5e
SM
1206 * lisp.h (last_undo_boundary): Declare new var.
1207 * keyboard.c (command_loop_1): Set it.
1208 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1209 were auto-added by the command loop (bug#11774).
1210
8dc2e44a
AS
12112012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1212
1213 * w32font.c (Qsymbol): Remove local definition.
1214 (syms_of_w32font): Don't DEFSYM it.
1215
169925ec
DA
12162012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 Fix sweep_vectors to handle large bool vectors correctly.
1219 * alloc.c (sweep_vectors): Account total_vector_bytes for
1220 bool vectors larger than VBLOCK_BYTES_MAX.
1221
5fbfb018
CY
12222012-07-18 Chong Yidong <cyd@gnu.org>
1223
1224 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1225 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1226
3ab6e069
DA
12272012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1228
1229 Return more descriptive data from Fgarbage_collect.
1230 Suggested by Stefan Monnier in
1231 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1232 * alloc.c (bounded_number): New function.
1233 (total_buffers, total_vectors): New variable.
1234 (total_string_size): Rename to total_string_bytes, adjust users.
1235 (total_vector_size): Rename to total_vector_bytes, adjust users.
1236 (sweep_vectors): Account total_vectors and total_vector_bytes.
1237 (Fgarbage_collect): New return value. Adjust documentation.
1238 (gc_sweep): Account total_buffers.
1239 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1240 (VECTOR_SIZE): Remove.
1241 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1242 (Qinterval, Qmisc): New symbols.
1243 (syms_of_data): Initialize them.
1244 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1245 (Qcons, Qbuffer): New declarations.
1246
6d02fe5b
PE
12472012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1250 Round up, not down. Improve doc.
1251
b7ffe040
DA
12522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 Restore old code in allocate_string_data to avoid Faset breakage.
1255 Reported by Julien Danjou <julien@danjou.info> in
1256 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1257 * alloc.c (allocate_string_data): Restore old code with minor
1258 adjustments, fix comment to explain this subtle issue.
1259
4dc7c8d5
SM
12602012-07-17 Eli Zaretskii <eliz@gnu.org>
1261
1262 Remove FILE_SYSTEM_CASE.
1263 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1264
1265 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1266 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1267 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1268 call-process-region passes it through expand-file-name.
1269
1270 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1271
12722012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1273
1274 Fix crash when creating indirect buffer (Bug#11917)
1275 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1276 Don't handle unbound variables specially if non-zero.
1277 (Fbuffer_local_variables): Pass zero.
1278 (clone_per_buffer_values): Pass non-zero.
1279
12802012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1281
1282 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1283 to make the loop interruptible.
1284
12852012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1286
1287 * gnutls.c (emacs_gnutls_handshake): Only retry if
1288 GNUTLS_E_INTERRUPTED.
1289
cce7fefc
DA
12902012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1291
1292 Cleanup and convert miscellaneous checks to eassert.
1293 * alloc.c (mark_interval): Fix comment, partially rephrase
1294 old comment from intervals.h (see below).
1295 * intervals.c (find_interval, adjust_intervals_for_insertion)
1296 (delete_interval, adjust_intervals_for_deletion)
1297 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1298 Convert to eassert.
1299 (adjust_intervals_for_insertion, make_new_interval):
1300 Remove obsolete and unused code.
1301 * intervals.h (struct interval): Remove obsolete comment.
1302 * textprotp.c (erase_properties): Remove unused code.
1303 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1304 (Fremove_list_of_text_properties): Convert to eassert.
1305
9ea10cc3
CY
13062012-07-17 Chong Yidong <cyd@gnu.org>
1307
1308 * editfns.c (Finsert_char): Doc fix.
1309
3900d5de
DA
13102012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Fix previous change to make Fmemory_free always accurate.
1313 * alloc.c (make_interval): Update total_free_intervals.
1314 (make_float): Likewise for total_free_floats.
1315 (free_cons, Fcons): Likewise for total_free_conses.
1316 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1317 Likewise for total_free_vector_bytes.
1318 (Fmake_symbol): Likewise for total_free_symbols.
1319 (bytes_free): Remove.
1320
7098646f
DA
13212012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1322
1323 Simple free memory accounting feature.
1324 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1325 (sweep_vectors): Accumulate size of free vectors.
1326 (Fgarbage_collect): Setup bytes_free.
1327 (Fmemory_free): New function.
1328 (syms_of_alloc): Register it.
1329
22657b40
DA
13302012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1331
1332 Cleanup overlays checking.
1333 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1334 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1335 eassert and OVERLAYP.
1336 (sort_overlays): Change to use OVERLAYP.
1337
ddfc8813
RK
13382012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1339
1340 * editfns.c (Finsert_char): Make it interactive, and make the
1341 second arg optional. Copy interactive spec and docstring from
1342 ucs-insert.
1343
7c26cf3c
PE
13442012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1347 Unlike the other wrapped functions, fabs has an unspecified
1348 effect on errno.
1349
5d127af9
JD
13502012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1351
1352 * nsterm.m (keyDown): Interpret flags without left/right bits
1353 as the left key (Bug#11670).
1354
6a0dd1d7
DA
13552012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1356
1357 Remove empty and useless init functions.
1358 * lisp.h (init_character_once, init_fns, init_image)
1359 (init_filelock, init_sound): Remove prototype.
1360 * character.c (init_character_once): Remove.
1361 * filelock.c (init_filelock): Likewise.
1362 * fns.c (init_fns): Likewise.
1363 * image.c (init_image): Likewise.
1364 * sound.c (init_sound): Likewise.
1365 * emacs.c (main): Adjust accordingly.
1366
7a6136fd
DA
13672012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 * gtkutil.h: Tiny cleanups.
1370 (use_old_gtk_file_dialog): Remove useless declaration.
1371 (xg_uses_old_file_dialog): Add suggested const attribute.
1372
ce811ad9
EZ
13732012-07-15 Eli Zaretskii <eliz@gnu.org>
1374
1375 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1376 (bidi_paragraph_init): Use it to limit search forward for a strong
1377 directional character in abnormally large paragraphs full of
1378 neutral or weak characters. (Bug#11943)
1379
c9adfeaa
SF
13802012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1381
1382 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1383 the toolbar (Bug#9451).
1384 (xg_make_tool_item): Give the widget event box a transparent
1385 background.
1386
fff62aa9
DA
13872012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1388
1389 Cleanup basic allocation variables and functions.
1390 * alloc.c (ignore_warnings, init_intervals, init_float)
1391 (init_cons, init_symbol, init_marker): Remove.
1392 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1393 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1394 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1395 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1396 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1397 (staticidx, init_alloc_once, init_strings, free_ablock):
1398 Remove redundant initialization.
1399 * fns.c (init_weak_hash_tables): Remove.
1400 * lisp.h (init_weak_hash_tables): Remove prototype.
1401
9730daca
DA
14022012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1403
1404 Use zero_vector where appropriate.
1405 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1406 accordingly.
1407 * lisp.h (zero_vector): New declaration.
1408 * font.c (null_vector): Remove.
1409 (syms_of_font): Remove initialization and staticpro.
1410 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1411 * keymap.c (Faccessible_keymaps): Likewise.
1412
2e2d2a13
LL
14132012-07-15 Leo Liu <sdl.web@gmail.com>
1414
1415 * fringe.c: Fix typo in comments.
1416
cd276f6e
LL
14172012-07-14 Leo Liu <sdl.web@gmail.com>
1418
1419 * fringe.c: Add a new bitmap exclamation-mark.
1420
5a1131d9
EZ
14212012-07-14 Eli Zaretskii <eliz@gnu.org>
1422
1423 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1424
1425 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1426 (HAVE_MENUS): Don't define, defined by editing config.in with
1427 msdos/sed2v2.inp.
1428 (GMALLOC_INHIBIT_VALLOC): Don't define.
1429 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1430
22e983b7
JB
14312012-07-14 Juanma Barranquero <lekktu@gmail.com>
1432
1433 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1434
5b3f250f
GM
14352012-07-14 Glenn Morris <rgm@gnu.org>
1436
1437 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1438 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1439 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1440
33d63ff4
GM
14412012-07-13 Glenn Morris <rgm@gnu.org>
1442
5b633342
GM
1443 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1444
33d63ff4
GM
1445 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1446 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1447
b55b9f85
JD
14482012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1449
0dc8cf50
JD
1450 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1451 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1452 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1453 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1454 where appropriate.
1455 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1456 as boolean expression.
1457 (x_set_window_size): Remove unused variable toolbar.
1458 (ns_get_color_default, ns_mod_to_lisp): Remove.
1459 (ns_mouse_position): Remove unused variables xchar and ychar.
1460 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1461 (ns_set_vertical_scroll_bar): Remove unused variable count.
1462 (ns_delete_terminal): Remove unused variable i.
1463 (ns_term_init): Remove unused variables r, g and b.
1464 (mouseDown): Remove unused variable window.
1465 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1466 (initFrameFromEmacs): Remove unused variable vbextra.
1467 (mouseEntered): Remove unused variables p and dpyinfo.
1468 (mouseExited): Remove unused variables p and r.
1469 (ns_define_frame_cursor, ns_clear_frame_area)
1470 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1471 (menuDown): Assign [sender tag] to variable and cast the variable.
1472
1473 * nsterm.h (menuDown): Add id as type to argument sender.
1474 (ns_display_info_for_name): Add Lisp_Object argument.
1475 (ns_term_init): Add Lisp_Object argument.
1476 (ns_map_event_to_object): Add void argument.
1477 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1478 prototype with arguments and only declare if __OBJC__.
1479 (nxatoms_of_nsselect): Add void argument.
1480 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1481 (ns_alloc_autorelease_pool): Add void argument.
1482 (ns_release_autorelease_pool): Add void* argument.
1483 (ns_get_defaults_value): Add const char* argument.
1484
1485 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1486 (initFromContents): Use SSDATA where appropriate.
1487 (ns_update_menubar): Add braces to ambigous if-else.
1488 (initWithTitle): Put () around assignment in if statement.
1489 (ns_menu_show): Remove unused variables window and keymap.
1490 (update_frame_tool_bar): Remove unused variable selected_p.
1491 (initWithContentRect): Remove unused variable this_cmd_name.
1492
1493 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1494 appropriate.
1495 (setXBMColor): Remove unused variable len.
1496 (setPixmapData): Put () around assignment in loop statement.
1497
1498 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1499 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1500 where appropriate.
1501 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1502 around assignment in loop statement.
1503 (nsfont_open): Remove unused variable i.
1504 (nsfont_open): Remove unused variable len.
1505 (nsfont_draw): Remove unused variable cs.
1506
1507 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1508 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1509 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1510 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1511 (Fns_font_name, Fns_perform_service)
1512 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1513 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1514 (ns_set_name): Remove unused variable view.
1515 (x_set_menu_bar_lines): Remove unused variable olines.
1516 (x_set_tool_bar_lines): Remove unused variable root_window.
1517 (Fns_list_colors): Put () around assignment in while statement.
1518 (Fns_perform_service): Remove unused variable len.
1519 (Fns_display_usable_bounds): Remove unused variable top.
1520 (syms_of_nsfns): Remove unused variable i.
1521
b55b9f85
JD
1522 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1523 memcpy (Bug#11907).
1524
ed9265fc 15252012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1526
1527 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1528 and free it with DestroyExceptionInfo (Bug#11558).
1529
ef099b57
JB
15302012-07-13 Juanma Barranquero <lekktu@gmail.com>
1531
1532 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1533 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1534 Set here, not in nt/config.nt.
1535
ea814a5d
EZ
15362012-07-13 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1539 cursor overflow into the last glyph on display line when the right
1540 fringe is off. (Bug#11832)
1541
1a952767
PE
15422012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 * xdisp.c (produce_special_glyphs): Now static.
1545 * dispextern.h (produce_special_glyphs): Remove decl.
1546
983188fd
GM
15472012-07-13 Glenn Morris <rgm@gnu.org>
1548
8d7c7eed 1549 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1550 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1551
983188fd
GM
1552 * s/usg5-4-common.h (USG, USG5):
1553 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1554 * s/sol2-6.h (SOLARIS2):
1555 * s/irix6-5.h (IRIX6_5):
1556 * s/hpux10-20.h (USG, USG5, HPUX):
1557 * s/gnu-linux.h (USG, GNU_LINUX):
1558 * s/freebsd.h (BSD_SYSTEM):
1559 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1560 * s/cygwin.h (CYGWIN):
1561 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1562 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1563
d1e68667 15642012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1565
1566 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1567
6de0e799
GM
15682012-07-13 Glenn Morris <rgm@gnu.org>
1569
739ae010
GM
1570 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1571
dbee5793
GM
1572 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1573
6de0e799
GM
1574 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1575 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1576
b82da769
GM
15772012-07-12 Glenn Morris <rgm@gnu.org>
1578
4fae5a7a 1579 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1580
1581 * process.c (init_process_emacs): Rename from init_process.
1582 The old name is also the name of a Mach system call.
1583 * lisp.h, emacs.c: Update for this name change.
1584 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1585 longer needed.
1586
5a979817
EZ
15872012-07-12 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1590 memmove call that removes glyphs covered by the left truncation
1591 glyph. Improve commentary.
1592 (display_line): Fix display of continuation glyphs on GUI frames
1593 when the right fringe is turned off and variable-size fonts are
1594 used in the window. Move the code that appends a stretch glyph to
1595 produce_special_glyphs, so that it could be used for truncation
1596 and continuation glyphs alike.
1597 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1598 glyph of a suitably computed width, to align the special glyphs at
1599 the window margin. Code moved from display_line. (Bug#11832)
1600
3e91a053
GM
16012012-07-12 Glenn Morris <rgm@gnu.org>
1602
ba9e4b84
GM
1603 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1604
1605 * s/gnu-linux.h, s/hpux10-20.h:
1606 Do not unconditionally define HAVE_XRMSETDATABASE.
1607
3e91a053
GM
1608 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1609
b300b1f4
PE
16102012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 Fix typos that broke OS X build.
1613 Reported by Randal L. Schwartz in
1614 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1615 * nsterm.m (ns_timeout): Add missing local decl.
1616 (ns_get_color): snprintf -> sprintf, to fix typo.
1617
6e777848
GM
16182012-07-12 Glenn Morris <rgm@gnu.org>
1619
3f922c37
GM
1620 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1621 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1622 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1623 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1624
0ab7b23a
GM
1625 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1626 Move PTY_OPEN to configure.
1627
6e777848
GM
1628 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1629 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1630 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1631
4a7edc24
DA
16322012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1633
1634 Use empty_unibyte_string where applicable.
1635 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1636 * lread.c (read1): Likewise.
1637 * xsettings.c (syms_of_xsettings): Likewise.
1638
308aab79
GM
16392012-07-12 Glenn Morris <rgm@gnu.org>
1640
42bd1719
GM
1641 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1642 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1643 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1644 * s/hpux10-20.h (RUN_TIME_REMAP):
1645 * s/bsd-common.h (TABDLY): Move to configure.
1646
1647 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1648
1649 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1650
ea0bbd17 1651 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1652 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1653
1654 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1655
308aab79
GM
1656 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1657 * s/template.h: Move NARROWPROTO to configure.
1658
ee1cf5cf
GM
16592012-07-11 Glenn Morris <rgm@gnu.org>
1660
30fe9bf4
GM
1661 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1662 unused since 2011-01-17 change to systty.h.
1663
ee1cf5cf
GM
1664 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1665 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1666 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1667
63e47e07
PE
16682012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1669
1670 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1671
c43fb4c3
GM
16722012-07-11 Glenn Morris <rgm@gnu.org>
1673
1674 * s/darwin.h, s/gnu-linux.h, s/template.h:
1675 Move INTERRUPT_INPUT to configure.
1676
e8df9267
DA
16772012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1678
1679 Minor adjustments to interning code.
1680 * lisp.h (intern, intern_c_string): Redefine as static inline
1681 wrappers for intern_1 and intern_c_string_1, respectively.
1682 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1683 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1684 Vobarray checking.
e8df9267
DA
1685 * font.c (font_intern_prop): Likewise. Adjust comment.
1686 * w32font.c (intern_font_name): Likewise.
1687
34348bd4
AS
16882012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1689
d96a1e0c
AS
1690 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1691
34348bd4
AS
1692 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1693 of Fcar/Fcdr if possible.
1694 * font.c (check_otf_features): Likewise.
1695 * fontset.c (Fnew_fontset): Likewise.
1696 * gnutls.c (Fgnutls_boot): Likewise.
1697 * minibuf.c (read_minibuf): Likewise.
1698 * msdos.c (IT_set_frame_parameters): Likewise.
1699 * xmenu.c (Fx_popup_dialog): Likewise.
1700 * w32menu.c (Fx_popup_dialog): Likewise.
1701
c8add24e
GM
17022012-07-11 Glenn Morris <rgm@gnu.org>
1703
4b575b3c
GM
1704 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1705 since nothing has defined it on these platforms.
1706
09f4e3b0
GM
1707 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1708 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1709
172bedef
GM
1710 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1711 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1712 Move CLASH_DETECTION to configure.
1713
249685df
GM
1714 * s/gnu.h: Remove file, which is now empty.
1715
c8add24e
GM
1716 * s/gnu.h, s/gnu-linux.h:
1717 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1718
b41253a3
JW
17192012-07-11 John Wiegley <johnw@newartisans.com>
1720
1721 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1722 function attribute, so we only use it if it exists in the
1723 compiler.
1724
d923b542
DA
17252012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1726
1727 Avoid call to strlen in fast_c_string_match_ignore_case.
1728 * search.c (fast_c_string_match_ignore_case): Change to use
1729 length argument. Adjust users accordingly.
1730 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1731
5ebbef1d
PE
17322012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1733
bb352260
PE
1734 Assume mkdir, rmdir.
1735 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1736 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1737
57054ddd
PE
1738 Assume rename.
1739 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1740
b747d3f7
PE
1741 Assume perror.
1742 * s/hpux10-20.h (HAVE_PERROR): Remove.
1743 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1744 Remove dummy definition, as this problem was obsolete long ago.
1745
5ebbef1d
PE
1746 Assume strerror.
1747 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1748
984e7f30
DA
17492012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1750
1751 Avoid calls to strlen in font processing functions.
1752 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1753 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1754 users accordingly.
d923b542
DA
1755 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1756 Adjust prototypes.
1757 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1758 Change to return ptrdiff_t.
984e7f30
DA
1759 (xfont_list_pattern, xfont_match): Use length returned by
1760 xfont_decode_coding_xlfd.
1761 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1762
20e94fdd
GM
17632012-07-11 Glenn Morris <rgm@gnu.org>
1764
9d596af3
GM
1765 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1766 Move DONT_REOPEN_PTY to configure.
1767
20e94fdd
GM
1768 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1769 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1770
e99a530f
PE
17712012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1772
22ffb973
PE
1773 Remove "#define unix" that is no longer needed (Bug#11905).
1774 * s/aix4-2.h (unix): Remove; no longer needed.
1775
e9a9ae03
PE
1776 EMACS_TIME simplification (Bug#11875).
1777 This replaces macros (which typically do not work in GDB)
1778 with functions, typedefs and enums, making the code easier to debug.
1779 The functional style also makes code easier to read and maintain.
1780 * systime.h: Include <sys/time.h> on all hosts, not just if
1781 WINDOWSNT, since 'struct timeval' is needed in general.
1782 (EMACS_TIME): Now a typedef, not a macro.
1783 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1784 not macros.
1785 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1786 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1787 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1788 (EMACS_TIME_LE): Now functions, not macros.
1789 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1790 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1791 which are not functions. All uses rewritten to use:
1792 (make_emacs_time): New function.
1793 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1794 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1795 not functions. All uses rewritten to use the following, respectively:
1796 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1797 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1798 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1799 * fileio.c (Fcopy_file):
1800 * xterm.c (XTflash): Get the current time closer to when it's used.
1801 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1802
ffacb126
PE
1803 * bytecode.c (targets): Suppress -Woverride-init warnings.
1804
e99a530f
PE
1805 Simplify by avoiding confusing use of strncpy etc.
1806 * doc.c (Fsnarf_documentation):
1807 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1808 * frame.c (Fmake_terminal_frame):
1809 * gtkutil.c (get_utf8_string):
1810 * lread.c (openp):
1811 * nsmenu.m (ns_update_menubar):
1812 * regex.c (regerror):
1813 Prefer memcpy to strncpy and strncat when either will do.
1814 * fileio.c (Fsubstitute_in_file_name):
1815 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1816 (menu_separator_name_p):
1817 * nsmenu.m (ns_update_menubar):
1818 Prefer memcmp to strncmp when either will do.
1819 * nsterm.m: Include <ftoastr.h>.
1820 (ns_get_color):
1821 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1822 Prefer snprintf to strncpy.
1823 * nsterm.m (ns_term_init):
1824 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1825 * nsterm.m (ns_term_init):
1826 Avoid the need for strncpy, by using build_string or
1827 make_unibyte_string directly. Use dtoastr, not snprintf.
1828 * process.c (Fmake_network_process): Diagnose service names that
1829 are too long, rather than silently truncating them or creating
1830 non-null-terminated names.
1831 (Fnetwork_interface_info): Likewise, for interface names.
1832 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1833 Prefer sprintf to strncat.
1834 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1835 Prefer vsnprintf to vsprintf + strncpy.
1836
c59592b3
GM
18372012-07-10 Glenn Morris <rgm@gnu.org>
1838
1839 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1840 Clarify fallback case.
1841
7d7bbefd
DA
18422012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1843
1844 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1845 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1846 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1847 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1848 where argument type is known to be a Lisp_Cons.
1849
3a4c8000
TT
18502012-07-10 Tom Tromey <tromey@redhat.com>
1851
1852 * bytecode.c (BYTE_CODE_THREADED): New macro.
1853 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1854 (enum byte_code_op): New type.
1855 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1856 (exec_byte_code): Use them. Use token threading when applicable.
1857
2a0213a6
DA
18582012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1859
1860 Optimize pure C strings initialization.
1861 * lisp.h (make_pure_string): Fix prototype.
1862 (build_pure_c_string): New function, defined as static inline. This
1863 provides a better opportunity to optimize away calls to strlen when
1864 the function is called with compile-time constant argument.
1865 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1866 argument, adjust users accordingly. Use build_pure_c_string where
1867 appropriate.
1868 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1869 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1870 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1871
cb1caeaf
DA
18722012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1873
1874 Avoid calls to strlen in miscellaneous functions.
1875 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1876 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1877 * lread.c (openp): Likewise.
1878
c293e30c
DA
18792012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 Avoid calls to strlen in path processing functions.
1882 * fileio.c (file_name_as_directory): Add comment. Change to add
1883 srclen argument and return the length of result. Adjust users
1884 accordingly.
1885 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1886 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1887 users accordingly.
1888 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1889
9e059e3f
GM
18902012-07-10 Glenn Morris <rgm@gnu.org>
1891
d02eb359
GM
1892 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1893 Move PENDING_OUTPUT_COUNT definition to configure.
1894
882cf227
GM
1895 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1896 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1897 * s/gnu.h (DATA_START): Move definitions to configure.
1898
af6e839f
GM
1899 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1900 We include usg5-4-common.h, which defines them both.
1901
40289a12
GM
1902 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1903 O_RDONLY already includes it).
1904
9e059e3f
GM
1905 Stop ns builds setting the EMACSLOADPATH environment variable.
1906 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1907 Now it does not set EMACSLOADPATH, just returns the load-path string.
1908 * nsterm.h: Update accordingly.
1909 * lread.c [HAVE_NS]: Include nsterm.h.
1910 (init_lread) [HAVE_NS]: Use ns_load_path.
1911 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1912
7c4e8ec0
GM
19132012-07-09 Glenn Morris <rgm@gnu.org>
1914
d4f600ff
GM
1915 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1916 since the included bsd-common.h does so.
1917
cbb31951
GM
1918 Stop ns builds setting the EMACSPATH environment variable.
1919 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1920 (ns_init_paths): Do not set EMACSPATH.
1921 * nsterm.h (ns_exec_path): Add it.
1922 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1923 Use ns_exec_path.
1924
7c4e8ec0
GM
1925 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1926
26bccfae
PE
19272012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1928
a0bee46f
PE
1929 * process.c (wait_reading_process_output): 'waitchannels' was unset
1930 when read_kbd || !NILP (wait_for_cell); fix this.
1931
5994c183
PE
1932 Add GCC-style 'const' attribute to functions that can use it.
1933 * character.h (char_resolve_modifier_mask):
1934 * keyboard.h (make_ctrl_char):
1935 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1936 (init_character_once, next_almost_prime, init_fns, init_image)
1937 (flush_pending_output, init_sound):
1938 * mem-limits.h (start_of_data):
1939 * menu.h (finish_menu_items):
1940 Add ATTRIBUTE_CONST.
1941 * emacs.c (DEFINE_DUMMY_FUNCTION):
1942 Declare the dummy function with ATTRIBUTE_CONST.
1943 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1944 Add decls with ATTRIBUTE_CONST.
1945
26bccfae
PE
1946 Minor improvements to make_formatted_string.
1947 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1948 where int is good enough, as vsprintf returns an int.
1949 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1950
a8290ec3
DA
19512012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1952
1953 Use make_formatted_string to avoid double length calculation.
1954 * lisp.h (make_formatted_string): New prototype.
1955 * alloc.c (make_formatted_string): New function.
1956 * buffer.c (Fgenerate_new_buffer_name): Use it.
1957 * dbus.c (syms_of_dbusbind): Likewise.
1958 * editfns.c (Fcurrent_time_zone): Likewise.
1959 * filelock.c (get_boot_time): Likewise.
1960 * frame.c (make_terminal_frame, set_term_frame_name)
1961 (x_report_frame_params): Likewise.
1962 * image.c (gs_load): Likewise.
1963 * minibuf.c (get_minibuffer): Likewise.
1964 * msdos.c (dos_set_window_size): Likewise.
1965 * process.c (make_process): Likewise.
1966 * xdisp.c (ensure_echo_area_buffers): Likewise.
1967 * xsettings.c (apply_xft_settings): Likewise.
1968
d01ba2f1
GM
19692012-07-09 Glenn Morris <rgm@gnu.org>
1970
1971 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1972 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1973 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1974 * nsterm.h (ns_etc_directory): Add it.
1975 * callproc.c [HAVE_NS]: Include nsterm.h.
1976 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1977
f1f924b6
DA
19782012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1979
1980 Move marker debugging code under MARKER_DEBUG.
1981 * marker.c (MARKER_DEBUG): Move marker debugging code under
1982 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1983 for bootstrap with --enable-checking (~3x slowdown reported
1984 by Juanma Barranquero <lekktu@gmail.com>).
1985 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1986
ab531b66
PE
19872012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1990 See <http://bugs.gnu.org/11825#29>.
1991
c4b3bc8a
EZ
19922012-07-08 Eli Zaretskii <eliz@gnu.org>
1993
1994 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1995 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1996 (display_line): Add commentary about displaying truncation glyphs
1997 on GUI frames.
1998 (produce_special_glyphs): Move here from term.c.
1999
2000 * term.c (produce_special_glyphs): Move to xdisp.c.
2001
2002 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2003 section.
c4b3bc8a 2004
b676b881
AS
20052012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2006
f17c5273
AS
2007 * xdisp.c (display_line): Avoid warning about implicit declaration
2008 of FRAME_FONT.
2009
298819b9
AS
2010 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2011
b676b881
AS
2012 * lisp.h: Remove empty conditional.
2013
6045c4fd
PE
20142012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2015
b3350bf9
PE
2016 * lread.c (load_path_check): Now static.
2017
6045c4fd
PE
2018 Fix some minor --with-ns problems found by static checking.
2019 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2020 (x_set_font) [!HAVE_X_WINDOWS]:
2021 * image.c (xpm_load_image) [HAVE_NS]:
2022 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2023 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2024 Remove unused local.
2025 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2026 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2027 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2028 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2029 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2030 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2031 Fix pointer signedness problem.
2032 * xfaces.c (FRAME_X_FONT_TABLE):
2033 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2034
929e7845
GM
20352012-07-07 Glenn Morris <rgm@gnu.org>
2036
2037 * lread.c (load_path_check): New function, split from init_lread.
2038 (init_lread): Reorganize. Motivation:
2039 If EMACSLOADPATH is set, check/warn about that rather than the
2040 defaults, which we are not going to use. Hence we can remove
2041 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2042 Don't warn if site-lisp directories are missing.
2043 If not installed, start from a blank load-path, since
2044 PATH_LOADSEARCH refers to the eventual installation directories.
2045
58dd0aa4
EZ
20462012-07-07 Eli Zaretskii <eliz@gnu.org>
2047
2048 Support truncation and continuation glyphs on GUI frames, when
2049 fringes are disabled. (Bug#11832)
2050 * xdisp.c (init_iterator): Get dimensions of truncation and
2051 continuation glyphs even if on GUI frames. Adjust
2052 it->last_visible_x on GUI frames when the left or right fringes,
2053 or both, are absent.
2054 (start_display, move_it_in_display_line_to): Handle the case of a
2055 GUI frame without a fringe to display continuation or truncation
2056 glyphs.
2057 (insert_left_trunc_glyphs): Support GUI frames: make sure
2058 truncation glyphs overwrite enough glyphs from the current line to
2059 have sufficient space in pixels.
2060 (display_line): Support truncation and continuation glyphs on GUI
2061 frames. If some spare pixels are left on the line after inserting
2062 the truncation glyphs, fill that space with a stretch glyph of a
2063 suitably computed width.
2064
2065 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2066 produce_glyphs, to support GUI sessions.
2067
31571fd7
PE
20682012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2069
5a16b9bc
PE
2070 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2071
f3047c75
PE
2072 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2073
31571fd7
PE
2074 Do not require float-time's arg to fit in time_t (Bug#11825).
2075 This works better on hosts where time_t is unsigned, and where
2076 float-time is applied to the (negative) difference between two times.
2077 * editfns.c (decode_time_components): Last arg is now double *,
2078 not int *, and means to store all the result as a double, without
2079 worrying about whether the seconds part fits in time_t.
2080 All callers changed.
2081 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2082 All callers changed.
2083 (Ffloat_time): Do not fail merely because the specified time falls
2084 outside of time_t range.
2085
4516fbef
GM
20862012-07-07 Glenn Morris <rgm@gnu.org>
2087
2088 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2089 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2090 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2091
07adc2c6
JB
20922012-07-07 Juanma Barranquero <lekktu@gmail.com>
2093
2094 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2095 Update dependencies.
2096
2097 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2098
fd573f31
PE
20992012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2100
fee5959d
PE
2101 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2102 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2103 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2104 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2105 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2106 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2107
fd573f31
PE
2108 * xfont.c (compare_font_names): Redo to omit the need for casts.
2109
ddadbc0e
AS
21102012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2111
fca8d6b6
AS
2112 * xfns.c (Fx_change_window_property): Doc fix.
2113 * w32fns.c (Fx_change_window_property): Doc fix.
2114
ddadbc0e
AS
2115 * w32fns.c (Fx_window_property): Accept the same arguments as the
2116 X Windows version. Doc fix.
2117 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2118
ed9265fc 21192012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2120 Eli Zaretskii <eliz@gnu.org>
2121
2122 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2123 Windows-specific code from nt/config.nt moved here.
2124 Obsolete settings removed.
2125
216ee680
PE
21262012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * process.c: Avoid unnecessary calls to gettime.
2129 (wait_reading_process_output): Don't get the time of day
2130 when gobbling data immediately and not waiting, as there's no need
2131 for it in that case. This removes a FIXME.
2132
bdd091e4
JD
21332012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2134
2135 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2136 is defined (Bug#11768).
2137
9d44f8ce
DA
21382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2139
2140 Fix marker debugging code.
2141 * marker.c (byte_char_debug_check): Do not perform the check
2142 if buffer is not multibyte.
090bd7cb
JB
2143 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2144 Call byte_char_debug_check with correct arguments.
9d44f8ce 2145
90fc4786
DA
21462012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2147
2148 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2149 * marker.c (byte_char_debug_check, count_markers):
2150 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2151 (byte_debug_flag): Remove.
2152 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2153 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2154
7b7ae965
DA
21552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2156
4e57b342
DA
2157 Avoid code repetition in marker-related functions.
2158 * marker.c (attach_marker): New function.
2159 (Fset_marker, set_marker_restricted, set_marker_both)
2160 (set_marker_restricted_both): Use it.
2161 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2162 Consistently rename charno to charpos.
2163 (marker_position): Add eassert.
2164 (marker_byte_position): Convert to eassert.
2165
21662012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2167
2168 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2169 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2170 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2171
657924ff
DA
21722012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2173
2174 Introduce fast path for the widely used marker operation.
2175 * alloc.c (build_marker): New function.
2176 * lisp.h (build_marker): New prototype.
2177 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2178 * composite.c (autocmp_chars): Likewise.
2179 * editfns.c (buildmark): Remove.
2180 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2181 (save_restriction_save): Use build_marker.
2182 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2183 * window.c (save_window_save): Likewise.
2184
041a49a6
DA
21852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2186
2187 Do not use Fdelete_overlay in delete_all_overlays
2188 to avoid redundant calls to unchain_overlay.
2189 * buffer.c (drop_overlay): New function.
2190 (delete_all_overlays, Fdelete_overlay): Use it.
2191 * minibuf.c (get_minibuffer): Fix comment.
2192
7dca65a4
PE
21932012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 Port to OpenBSD 5.1 amd64.
2196 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2197 This is needed for OpenBSD, and should be harmless on all BSD systems.
2198 Also, include <sys/sysctl.h>, as it should be available on all
2199 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2200 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2201 use p_pid member, not kp_proc.pid.
2202
8eb876e2
GM
22032012-07-06 Glenn Morris <rgm@gnu.org>
2204
2205 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2206
38182d90
PE
22072012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 More xmalloc and related cleanup.
2210 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2211 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2212 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2213 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2214 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2215 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2216 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2217 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2218 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2219 * xterm.c:
2220 Omit needless casts involving void * pointers and allocation.
2221 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2222 as the former is more robust if P's type is changed.
2223 Prefer xzalloc to xmalloc + memset 0.
2224 Simplify malloc-or-realloc to realloc.
2225 Don't worry about xmalloc returning a null pointer.
2226 Prefer xstrdup to xmalloc + strcpy.
2227 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2228 growing it.
2229 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2230 alloca of a constant.
2231
6dd5a677
EZ
22322012-07-05 Eli Zaretskii <eliz@gnu.org>
2233
2234 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2235 hscroll is larger than the line width. Fixes long and futile
2236 looping inside extend_face_to_end_of_line (on a TTY) producing
2237 glyphs that are not needed and thrown away.
2238
6b312f0f
DA
22392012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2240
2241 * marker.c (set_marker_restricted_both): Simplify by using
2242 clip_to_bounds.
2243
f520ef9b
PE
22442012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2247
383b7c95
JD
22482012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2249
2250 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2251 not defined (Bug#11768).
2252 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2253 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2254 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2255 followed by gtk_box_set_homogeneous (Bug#11768).
2256 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2257 (update_theme_scrollbar_width, xg_create_scroll_bar):
2258 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2259 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2260 (is_box_type): New function (Bug#11768).
2261 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2262 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2263 with default display (Bug#11768).
2264
d6e7bf45
EZ
22652012-07-05 Eli Zaretskii <eliz@gnu.org>
2266
2267 * xdisp.c (window_hscroll_limited): New function.
2268 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2269 coordinates when window's hscroll is set to insanely large
2270 values. (Bug#11857)
2271
431391ec
JB
22722012-07-05 Juanma Barranquero <lekktu@gmail.com>
2273
2274 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2275 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2276
23f86fce
DA
22772012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2278
2279 Cleanup xmalloc.
2280 * lisp.h (xzalloc): New prototype. Omit needless casts.
2281 * alloc.c (xzalloc): New function. Omit needless casts.
2282 * charset.c: Omit needless casts. Convert all calls to
2283 xmalloc with following memset to xzalloc.
2284 * dispnew.c: Likewise.
2285 * fringe.c: Likewise.
2286 * image.c: Likewise.
2287 * sound.c: Likewise.
2288 * term.c: Likewise.
2289 * w32fns.c: Likewise.
2290 * w32font.c: Likewise.
2291 * w32term.c: Likewise.
2292 * xfaces.c: Likewise.
2293 * xfns.c: Likewise.
2294 * xterm.c: Likewise.
2295 * atimer.c: Omit needless casts.
2296 * buffer.c: Likewise.
2297 * callproc.c: Likewise.
2298 * ccl.c: Likewise.
2299 * coding.c: Likewise.
2300 * composite.c: Likewise.
2301 * doc.c: Likewise.
2302 * doprnt.c: Likewise.
2303 * editfns.c: Likewise.
2304 * emacs.c: Likewise.
2305 * eval.c: Likewise.
2306 * filelock.c: Likewise.
2307 * fns.c: Likewise.
2308 * gtkutil.c: Likewise.
2309 * keyboard.c: Likewise.
2310 * lisp.h: Likewise.
2311 * lread.c: Likewise.
2312 * minibuf.c: Likewise.
2313 * msdos.c: Likewise.
2314 * print.c: Likewise.
2315 * process.c: Likewise.
2316 * region-cache.c: Likewise.
2317 * search.c: Likewise.
2318 * sysdep.c: Likewise.
2319 * termcap.c: Likewise.
2320 * terminal.c: Likewise.
2321 * tparam.c: Likewise.
2322 * w16select.c: Likewise.
2323 * w32.c: Likewise.
2324 * w32reg.c: Likewise.
2325 * w32select.c: Likewise.
2326 * w32uniscribe.c: Likewise.
2327 * widget.c: Likewise.
2328 * xdisp.c: Likewise.
2329 * xmenu.c: Likewise.
2330 * xrdb.c: Likewise.
2331 * xselect.c: Likewise.
2332
0497dc44
PE
23332012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 * fileio.c (time_error_value): Check the right error number.
2336 Problem reported by Troels Nielsen in
2337 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2338
356e7178
PE
23392012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2340
4e71fd89
PE
2341 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2342 This should be fixed in a better way; see Eli Zaretskii in
2343 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2344 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2345
f0941253
PE
2346 * fileio.c (time_error_value): Rename from special_mtime.
2347 The old name's problems were noted by Eli Zaretskii in
2348 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2349
065c9eb4
PE
2350 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2351 This variable's comment says Emacs needs at least one GDB-visible
2352 symbol of type enum pvec_type, to work around GDB problems.
2353 The symbol's value doesn't matter.
2354
356e7178
PE
2355 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2356 that causes compilation to fail on pre-C99 compilers.
2357
ed9265fc 23582012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2359
2360 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2361 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2362
3884d954
DA
23632012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2364
d209e2fb 2365 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2366 headers for buffer_defaults and buffer_local_symbols.
2367 Reported by Juanma Barranquero <lekktu@gmail.com>.
2368
ee28be33
SM
23692012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2370
2371 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2372 * lisp.h (enum pvec_type): Use fewer bits.
2373 (PSEUDOVECTOR_SIZE_BITS): New constant.
2374 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2375 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2376 change in pvec_type.
2377 (PSEUDOVECTOR_TYPEP): New macro.
2378 (TYPED_PSEUDOVECTORP): Use it.
2379 * fns.c (internal_equal): Adapt code to extract pvectype.
2380 * emacs.c (gdb_pvec_type): Update type.
2381 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2382 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2383 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2384 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2385 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2386 abusing vector->header.next.nbytes.
2387 (live_vector_p): Use PVEC_TYPE.
2388 (mark_object): Adapt code to extract pvectype. Use switch.
2389
c7f2cd7f
PE
23902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2391
2392 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2393 Tighten new eassert a bit.
2394
8ce70ed2
DA
23952012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2396
2397 Fix compilation with --enable-gcc-warnings and -O1
2398 optimization level.
2399 * doprnt.c (doprnt): Change type of tem to int, initialize
2400 to avoid compiler warning. Add eassert.
2401 * search.c (simple_search): Initialize match_byte to avoid
2402 compiler warning. Add eassert.
2403
dea7f1e5
PE
24042012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2405
24a212eb
PE
2406 Avoid weird behavior with large horizontal scrolls.
2407 Without this change, for example, large hscroll values would
2408 mess up Emacs's display on Fedora 15 x86, presumably due to
2409 overflows in int calculations in the display code.
2410 Also, if buffers had long lines, Emacs would freeze.
2411 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2412 (set_window_hscroll): New function, containing the old guts of
2413 Fset_window_hscroll. Return the clipped value.
2414 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2415 This avoids the need to check against PTRDIFF_MAX.
2416
dea7f1e5
PE
2417 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2418
76046526
DA
24192012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2420
2421 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2422
39adff0d
PE
24232012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2424
63807d47
PE
2425 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2426 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2427 since GCC 4.4.6 issues a bogus warning for them.
2428
39adff0d
PE
2429 Fix bugs in file timestamp newness comparisons.
2430 * fileio.c (Ffile_newer_than_file_p):
2431 * lread.c (Fload): Use full timestamp resolution of files,
2432 not just the 1-second resolution, so that files that are only
2433 slightly newer still count as newer.
2434 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2435 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2436
dbeed9a6
PE
24372012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * fileio.c: Improve handling of file time marker. (Bug#11852)
2440 (special_mtime): New function.
2441 (Finsert_file_contents, Fverify_visited_file_modtime):
2442 Use it to set special mtime values consistently.
2443
636334d6
AS
24442012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2445
2446 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2447 marker for non-existing file. (Bug#11852)
2448
e2017fe2
GM
24492012-07-03 Glenn Morris <rgm@gnu.org>
2450
2451 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2452 and did not make it into globals.h).
2453
404dbd37
TT
24542012-07-03 Tom Tromey <tromey@redhat.com>
2455
2456 * window.c (Fset_window_margins, Fset_window_fringes)
2457 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2458 * textprop.c (Fprevious_property_change): No longer static.
2459 * syntax.c (Fsyntax_table_p): No longer static.
2460 * process.c (Fget_process, Fprocess_datagram_address): No longer
2461 static.
2462 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2463 * keyboard.c (Fcommand_execute): No longer static.
2464 Remove EXFUN.
2465 * insdel.c (Fcombine_after_change_execute): No longer static.
2466 * image.c (Finit_image_library): No longer static.
2467 * fileio.c (Fmake_symbolic_link): No longer static.
2468 * eval.c (Ffetch_bytecode): No longer static.
2469 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2470 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2471 No longer static.
404dbd37
TT
2472 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2473 static.
2474 * dired.c (Ffile_attributes): No longer static.
2475 * composite.c (Fcomposition_get_gstring): No longer static.
2476 * callproc.c (Fgetenv_internal): No longer static.
2477
2478 * ccl.h: Remove EXFUNs.
2479 * buffer.h: Remove EXFUNs.
2480 * dispextern.h: Remove EXFUNs.
2481 * intervals.h: Remove EXFUNs.
2482 * fontset.h: Remove EXFUN.
2483 * font.h: Remove EXFUNs.
2484 * dosfns.c (system_process_attributes): Remove EXFUN.
2485 * keymap.h: Remove EXFUNs.
2486 * lisp.h: Remove EXFUNs.
2487 * w32term.h: Remove EXFUNs.
2488 * window.h: Remove EXFUNs.
2489 * xsettings.h: Remove EXFUN.
2490 * xterm.h: Remove EXFUN.
2491
8e4fd1e1
GM
24922012-07-03 Glenn Morris <rgm@gnu.org>
2493
2494 * lisp.h (Frandom): Make it visible to C.
2495 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2496 buffer for invisible buffers. (Bug#1229)
2497
ca95b3eb
DA
24982012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2499
2500 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2501 values which aren't power of 2.
2502 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2503 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2504 accordingly.
2505
7555c33f
SM
25062012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2507
2508 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2509
2510 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2511
d12e8f5a
DA
25122012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2513
2514 * alloc.c (allocate_vector_block): Remove redundant
2515 calls to mallopt if DOUG_LEA_MALLOC is defined.
2516 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2517 avoid calls to mallopt if zero_vector is returned.
2518
296094c3
DA
25192012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2520
2521 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2522 is enabled, avoid dereferencing NULL current_sblock if
2523 running undumped.
2524
36429c89
DA
25252012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2526
2527 Cleanup basic buffer management.
2528 * buffer.h (struct buffer): Change layout to use generic vector
2529 marking code. Fix some comments. Change type of 'clip_changed'
2530 to bitfield. Remove unused #ifndef old.
2531 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2532 (GET_OVERLAYS_AT): Fix indentation.
2533 (for_each_per_buffer_object_at): New macro.
2534 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2535 (Fbuffer_local_variables): Use it.
2536 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2537 * alloc.c (allocate_buffer): Adjust to match new layout of
2538 struct buffer. Fix comment.
2539 (mark_overlay): New function.
2540 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2541 Lisp area of struct buffer.
2542 (mark_object): Use it. Adjust marking of misc objects
2543 and related comments.
2544
3b3e4cac
PE
25452012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2546
2547 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2548 wrapper that is not needed because the wrapped code is a no-op (zero
2549 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2550 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2551
cf5c0175
DA
25522012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2553
2554 * alloc.c (mark_buffer): Simplify. Remove prototype.
2555 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2556 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2557 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2558 redundant calls to mark_vectorlike for bool vectors.
2559
ca26824c
GM
25602012-06-30 Glenn Morris <rgm@gnu.org>
2561
2e4c5312
GM
2562 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2563
ca26824c
GM
2564 * epaths.in (PATH_SITELOADSEARCH): New.
2565 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2566 This is rather than relying on --enable-locallisppath elements
2567 having "site-lisp" in their names. (Bug#10208#25, 11658)
2568
0d23c240
EZ
25692012-06-30 Eli Zaretskii <eliz@gnu.org>
2570
c9240d7a
EZ
2571 * w32proc.c (sys_select): Accept and ignore one more argument.
2572
2573 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2574
0d23c240 2575 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2576 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2577
2578 * sysdep.c: Don't include dos.h and dosfns.h.
2579
2580 * process.c (sys_select):
2581 * msdos.c (sys_select): Accept one more argument and ignore it.
2582
2583 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2584 adapt data types and code to that.
2585
2586 * dosfns.c:
2587 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2588 which clashes with the gnulib function of the same name.
2589
af5a5a98
AS
25902012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2591
c5e4379c
AS
2592 * font.c (font_style_to_value, font_style_symbolic)
2593 (font_prop_validate_style): Add type checks for values in
2594 font_style_table.
2595
af5a5a98
AS
2596 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2597 argument.
2598 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2599 uses.
2600
8d38f461
EZ
26012012-06-29 Eli Zaretskii <eliz@gnu.org>
2602
2e5a6631
EZ
2603 * xdisp.c (try_window_id): Undo last change.
2604
8d38f461
EZ
2605 * w32.c (getwd): Adjust commentary about startup_dir.
2606 (init_environment): Always call sys_access, even in non-MSVC
2607 builds. Don't chdir to the directory of the Emacs executable.
2608 This undoes code from 1997 which was justified by the need to
2609 "avoid conflicts when removing and renaming directories". But its
2610 downside was that every relative file name was being interpreted
2611 relative to the directory of the Emacs executable, which can never
2612 be TRT. In particular, it broke sys_access when called with
2613 relative file names.
2614 (sys_access): Map GetLastError to errno.
2615
2af3565e
DA
26162012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2617
2618 * window.h (struct window): Change type of 'fringes_outside_margins'
2619 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2620 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2621 Adjust comment.
2622 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2623 to ptrdiff_t.
2624
c8d3a25c 26252012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2626
c8d3a25c
GM
2627 * gnutls.c (emacs_gnutls_handshake):
2628 Add QUIT to make the loop interruptible.
57570cd3 2629
c8d3a25c 26302012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2631
c8d3a25c
GM
2632 * charset.c (init_charset): Make lack of etc/charsets fatal.
2633
3e984ee8
DA
26342012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2635
2636 * editfns.c (region_limit): Fix type mismatch.
2637
ef884f23
DA
26382012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2639
2640 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2641 undefined. Convert from xassert to eassert.
2642 * nsmenu.m: Convert from xassert to eassert.
2643 * nsterm.m: Likewise.
2644
7d7e0027
SM
26452012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2646
2647 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2648
aa754e6a
PE
26492012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2650
2651 Avoid integer overflow on scroll-left and scroll-right.
2652 * window.c (HSCROLL_MAX): New macro.
2653 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2654 overflow when requested scroll falls outside ptrdiff_t range.
2655
80b00b08
DA
26562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2657
2658 * window.h (struct window): Change type of 'hscroll',
2659 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2660 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2661 Adjust users accordingly.
2662 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2663 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2664 from EMACS_INT to ptrdiff_t.
2665 (make_window): Omit redundant initialization.
2666
62b2bcf6
JB
26672012-06-28 Juanma Barranquero <lekktu@gmail.com>
2668
2669 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2670
45942c7d
DA
26712012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2672
2673 * window.h (struct window): Change type of 'use_time' and
2674 'sequence_number' from Lisp_Object to int.
2675 * frame.c (make_frame): Adjust users accordingly.
2676 * print.c (print_object): Likewise.
2677 * window.c (select_window, Fwindow_use_time, make_parent_window)
2678 (make_window): Likewise.
2679
e509cfa6
DA
26802012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2681
2682 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2683 enabled with --enable-checking=[all,glyphs] configure option.
2684 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2685 adjust comments accordingly.
2686 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2687 undefined, adjust comments accordingly.
2688 * image.c: Likewise.
2689 * scroll.c: Likewise.
2690 * w32fns.c: Likewise.
2691 * w32term.c: Likewise.
2692 * xdisp.c: Likewise.
2693 * xfaces.c: Likewise.
2694 * xfns.c: Likewise.
2695 * xterm.c: Likewise.
2696
a54e2c05
DA
26972012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2698
2699 Generalize run-time debugging checks.
2700 * dispextern.h (XASSERTS): Remove.
2701 * fontset.c (xassert): Remove.
2702 Convert from xassert to eassert.
2703 * alloc.c: Convert from xassert to eassert.
2704 * bidi.c: Likewise.
2705 * dispnew.c: Likewise.
2706 * fns.c: Likewise.
2707 * fringe.c: Likewise.
2708 * ftfont.c: Likewise.
2709 * gtkutil.c: Likewise.
2710 * image.c: Likewise.
2711 * keyboard.c: Likewise.
2712 * menu.c: Likewise.
2713 * process.c: Likewise.
2714 * scroll.c: Likewise.
2715 * sound.c: Likewise.
2716 * term.c: Likewise.
2717 * w32console.c: Likewise.
2718 * w32fns.c: Likewise.
2719 * w32term.c: Likewise.
2720 * window.c: Likewise.
2721 * xdisp.c: Likewise.
2722 * xfaces.c: Likewise.
2723 * xfns.c: Likewise.
2724 * xselect.c: Likewise.
2725 * xterm.c: Likewise.
2726
1ec4b7b2
SM
27272012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2728
2729 * fns.c (maybe_resize_hash_table): Output message when growing the
2730 purify-hashtable.
2731
2014308a
DA
27322012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2733
2734 * alloc.c (allocate_string_data): Remove dead code.
2735 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2736 avoid GCC warning about unused macro.
2737
246155eb
DA
27382012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2739
2740 * alloc.c (allocate_string): Omit intervals initialization.
2741 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2742 as in make_pure_string and make_pure_c_string.
2743
43184b7b
DA
27442012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2745
d209e2fb 2746 * alloc.c (allocate_string): Fix last change.
43184b7b 2747
3fe6dd74
DA
27482012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2749
d209e2fb 2750 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2751 to memset, add explicit initialization where appropriate.
2752
1ba6038a
GM
27532012-06-27 Glenn Morris <rgm@gnu.org>
2754
2755 * lisp.mk (lisp): Remove paths.elc.
2756
c89926a5
CY
27572012-06-27 Chong Yidong <cyd@gnu.org>
2758
2759 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2760
ed6b3510
JW
27612012-06-26 John Wiegley <johnw@newartisans.com>
2762
1ec4b7b2 2763 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2764 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2765
ed6b3510
JW
2766 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2767 when building with Clang.
2768
8edd4a2b
SM
27692012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2770
2771 * eval.c (Fapply): Allow calling it with a single argument.
2772
f6f62d1b
EZ
27732012-06-26 Eli Zaretskii <eliz@gnu.org>
2774
2775 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2776 _stricmp and _strnicmp.
2777 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2778
62efea5e
DA
27792012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2780
2781 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2782 allocated window.
2783 (allocate_process): Likewise for new process.
8edd4a2b 2784 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2785 (allocate_frame): Likewise.
2786 * frame.c (make_frame): Omit redundant initialization.
2787 * window.c (make_parent_window): Use memset.
2788 (make_window): Omit redundant initialization.
2789 * process.c (make_process): Omit redundant initialization.
2790 * terminal.c (create_terminal): Likewise.
2791
42997f4d
DA
27922012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2793
2794 * term.c (delete_tty): Remove redundant call to memset.
2795
1130ecfc
DA
27962012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2797
2798 * alloc.c: Remove build_string.
2799 * lisp.h: Define build_string as static inline. This provides
2800 a better opportunity to optimize away calls to strlen when the
2801 function is called with compile-time constant argument.
2802 * image.c (imagemagick_error): Convert to build_string.
2803 * w32proc.c (sys_spawnve): Likewise.
2804 * xterm.c (x_term_init): Likewise.
2805
cf38a720
PE
28062012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2807
99027bdd
PE
2808 Use sprintf return value instead of invoking strlen on result.
2809 In the old days this wasn't portable, since some sprintf
2810 implementations returned char *. But they died out years ago and
2811 Emacs already assumes sprintf returns int.
2812 Similarly for float_to_string.
2813 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2814 * ccl.c (ccl_driver):
2815 * character.c (string_escape_byte8):
2816 * data.c (Fnumber_to_string):
2817 * doprnt.c (doprnt):
2818 * print.c (print_object):
2819 * xdisp.c (message_dolog):
2820 * xfns.c (syms_of_xfns):
2821 Use sprintf or float_to_string result to avoid need to call strlen.
2822 * data.c (Fnumber_to_string):
2823 Use make_unibyte_string, since the string must be ASCII.
2824 * lisp.h, print.c (float_to_string): Now returns int length.
2825 * term.c (produce_glyphless_glyph):
2826 Use sprintf result rather than recomputing it.
2827
cf38a720
PE
2828 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2829 * Makefile.in (ALL_CFLAGS):
2830 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2831 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2832
3511c784
DA
28332012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2834
0a08eb21 2835 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2836 strcasecmp if available.
2837 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2838
fb7da12e
AS
28392012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2840
2841 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2842 Avoid comma operator.
2843 * menu.c (push_submenu_start, push_submenu_end)
2844 (push_left_right_boundary, push_menu_pane): Likewise.
2845 * msdos.c (dos_rawgetc): Likewise.
2846
afa2ffd8
DA
28472012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2848
2849 * xfns.c (xic_create_fontsetname): Remove redundant calls
2850 to memset.
2851
b3b4476b
PE
28522012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2853
4495ff38
PE
2854 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2855 sprintf already null-terminates its output.
2856
b3b4476b
PE
2857 * xfns.c (x_window): Remove redundant cast.
2858
b00876c9
DA
28592012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2860
2861 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2862 `const char *' to `char *' to avoid compiler warning.
2863
d188e26b
PE
28642012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2865
885d1d74
PE
2866 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2867 instead of truncating it to 63 (admittedly a generous limit).
2868
d188e26b
PE
2869 * process.c: Fix spelling and caps in comments.
2870
e2f560b1
DN
28712012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2872
e86db54b 2873 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2874 * sysdep.c (setpgrp): Remove definition, not used in this file.
2875
7583a3a1
JB
28762012-06-24 Juanma Barranquero <lekktu@gmail.com>
2877
2878 * makefile.w32-in: Update dependencies.
2879
696056c2
EZ
28802012-06-24 Eli Zaretskii <eliz@gnu.org>
2881
2882 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2883 (SYSTIME_H): Add nt/inc/sys/time.h.
2884
2885 * systime.h [WINDOWSNT]: Include sys/time.h.
2886
2887 * s/ms-w32.h (struct timespec): Definition moved from
2888 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2889
845ca893
PE
28902012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2891
2892 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2893 * buffer.h (buffer_slot_type_mismatch):
2894 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2895 * eval.c (unwind_to_catch):
2896 * image.c (my_png_error, my_error_exit):
2897 * keyboard.c (quit_throw_to_read_char, user_error)
2898 (Fexit_recursive_edit, Fabort_recursive_edit):
2899 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2900 (wrong_type_argument, buffer_overflow, __executable_start)
2901 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2902 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2903 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2904 (fatal):
2905 (child_setup) [!DOS_NT]:
2906 * lread.c (end_of_file_error, invalid_syntax):
2907 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2908 * puresize.h (pure_write_error):
2909 * search.c (matcher_overflow):
2910 * sound.c (sound_perror, alsa_sound_perror):
2911 * sysdep.c, syssignal.h (croak):
2912 * term.c (maybe_fatal, vfatal):
2913 * textprop.c (text_read_only):
2914 * undo.c (user_error):
2915 * unexmacosx.c (unexec_error):
2916 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2917 Use _Noreturn rather than NO_RETURN.
2918 No need for separate decl merely because of _Noreturn.
2919 * sound.c (sound_warning, parse_sound):
2920 Remove unnecessary forward decls.
2921
f1dd8073
PE
29222012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2923
2924 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2925 * lisp.h (WAIT_READING_MAX): New macro.
2926 * dispnew.c (Fsleep_for, sit_for):
2927 * keyboard.c (kbd_buffer_get_event):
2928 * process.c (Faccept_process_output):
2929 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2930 This improves on the previous patch, which introduced a bug
2931 when time_t is unsigned and as wide as intmax_t.
2932 See <http://bugs.gnu.org/9000#51>.
2933
b82c1755
EZ
29342012-06-23 Eli Zaretskii <eliz@gnu.org>
2935
2936 * dispnew.c (sit_for, Fsleep_for):
2937 * keyboard.c (kbd_buffer_get_event):
2938 * process.c (Faccept_process_output): Avoid compiler warnings when
2939 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2940
ca300656
JB
29412012-06-23 Juanma Barranquero <lekktu@gmail.com>
2942
049ec95b
JB
2943 * makefile.w32-in: Update dependencies.
2944
ca300656
JB
2945 * w32.c (ltime): Add return type and declare static.
2946 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2947
db7b8d06
PE
29482012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2951 Privately reported by Herbert J. Skuhra.
2952 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2953 All uses changed.
2954 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2955 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2956
0bd8297f
EZ
29572012-06-23 Eli Zaretskii <eliz@gnu.org>
2958
96512555
EZ
2959 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2960 last argument of make_unibyte_string.
2961
0bd8297f
EZ
2962 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2963 language ID in the event parameters.
2964
2965 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2966 event.code, not the obscure "character set ID".
2967
63def6b6
CY
29682012-06-23 Chong Yidong <cyd@gnu.org>
2969
2970 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2971
e8a02204
EZ
29722012-06-23 Eli Zaretskii <eliz@gnu.org>
2973
388cdec0
EZ
2974 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2975 * w32.c (fdutimens): New function.
2976
2977 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2978
2979 * s/ms-w32.h (pselect): Redirect to sys_select.
2980
2981 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2982
e8a02204
EZ
2983 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2984 in the logic of incrementing and decrementing the value of
2985 use_relocatable_buffers.
2986
d054f3fb
PE
29872012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2990 Privately reported by Herbert J. Skuhra.
2991 [__FreeBSD__]: Remove "*/" typo after "#include".
2992 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2993 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2994 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2995 Don't assume EMACS_TIME and struct timeval are the same type.
2996
d35af63c
PE
29972012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 Support higher-resolution time stamps (Bug#9000).
3000 The time stamps are only nanosecond-resolution at the C level,
3001 since that's the best that any real-world system supports now.
3002 But they are picosecond-resolution at the Lisp level, as that's
3003 easy, and leaves room for future OS improvements.
3004
3005 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3006 (LIBES): Use it.
3007
3008 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3009 Don't get current time unless it's needed.
3010
3011 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3012 now provides it if it's absent.
3013 (start_atimer): Port to higher-res time stamps.
3014 Check for time stamp overflow. Don't get current time more
3015 often than is needed.
3016
3017 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3018 Include systime.h, not time.h.
3019 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3020
3021 * dired.c: Include stat-time.h.
3022 (Ffile-attributes): File times now have higher resolution.
3023
3024 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3025 (struct image): Timestamp now has higher resolution.
3026
3027 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3028 has at least microseconds now. All uses removed.
3029 (update_frame, update_single_window, update_window, update_frame_1)
3030 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3031
3032 * editfns.c (time_overflow): Now extern.
3033 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3034 (float-time, Fformat_time_string, Fcurrent_time_string)
3035 (Fcurrent_time_zone): Accept and generate higher-resolution
3036 time stamps.
3037 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3038 (decode_time_components, lisp_seconds_argument): New functions.
3039 (make_time): Now static.
3040 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3041 Report an error if the time is invalid, rather than having the caller
3042 do that.
3043
3044 * fileio.c: Include <stat-time.h>
3045 (Fcopy_file): Copy higher-resolution time stamps.
3046 Prefer to set the time stamp via a file descriptor if that works.
3047 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3048 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3049 (Fvisited_file_modtime, Fset_visited_file_modtime):
3050 Support higher-resolution time stamps.
3051
3052 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3053
3054 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3055
3056 * image.c (prepare_image_for_display, clear_image_cache)
3057 (lookup_image): Port to higer-resolution time stamps.
3058
3059 * keyboard.c (start_polling, bind_polling_period):
3060 Check for time stamp overflow.
3061 (read_char, kbd_buffer_get_event, timer_start_idle)
3062 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3063 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3064 Port to higher-resolution time stamps. Do not assume time_t is signed.
3065 (decode_timer): New function. Timers are now vectors of length 9,
3066 not 8, to accommodate the picosecond component.
3067 (timer_check_2): Use it.
3068
3069 * nsterm.m (select_timeout, timeval_subtract): Remove.
3070 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3071 as they're a bit more accurate and handle overflow better.
3072 (ns_select): Change prototype to be compatible with pselect.
3073 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3074 * nsterm.h (ns_select): Adjust prototype.
3075
3076 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3077 us-resolution time stamps.
3078 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3079
3080 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3081
3082 * lisp.h (time_overflow): New decl.
3083 (wait_reading_process_output): First arg is now intmax_t, not int,
3084 to accommodate larger waits.
3085
3086 * process.h (struct Lisp_Process.read_output_delay):
3087 Now counts nanoseconds, not microseconds.
3088 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3089 EMACS_HAS_USECS.
3090 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3091 (wait_reading_process_output):
3092 Port to ns-resolution time stamps.
3093 (Faccept_process_output, wait_reading_process_output):
3094 Check for time stamp overflow. Do not assume time_t is signed.
3095 (select_wrapper): Remove; we now use pselect.
3096 (Fprocess_attributes): Now generates ns-resolution time stamps.
3097
3098 * sysdep.c: Include utimens.h. Don't include utime.h
3099 or worry about struct utimbuf; gnulib does that for us now.
3100 (gettimeofday): Remove; gnulib provides a substitute.
3101 (make_timeval): New function.
3102 (set_file_times): Now sets ns-resolution time stamps.
3103 New arg FD; all uses changed.
3104 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3105 (system_process_attributes):
3106 Now returns ns-resolution time stamp. All uses changed.
3107 Check for time stamp overflow.
3108
3109 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3110 provides a substitute now.
3111
3112 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3113 since it guarantees struct timespec.
3114 (EMACS_TIME): Now struct timespec, so that we can support
3115 ns-resolution time stamps.
3116 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3117 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3118 (EMACS_USECS): Remove.
3119 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3120 so multiply the arg by 1000 before storing it.
3121 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3122 New macros.
3123 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3124 Port to ns-resolution time stamps.
3125 (EMACS_TIME_NEG_P): Remove; replaced by....
3126 (EMACS_TIME_SIGN): New macro.
3127 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3128 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3129 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3130 (make_timeval, make_lisp_time, decode_time_components): New decls.
3131 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3132 that it mishandled time_t overflow. You can't compare by subtracting!
3133 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3134 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3135
3136 * term.c: Include <sys/time.h>.
3137 (timeval_to_Time): New function, for proper overflow wraparound.
3138 (term_mouse_position, term_mouse_click): Use it.
3139
3140 * undo.c (record_first_change): Support higher-resolution time stamps
3141 in the undo buffer.
3142 (Fprimitive_undo): Use them when restoring time stamps.
3143
3144 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3145 (w32_get_internal_run_time):
3146 Port to higher-resolution Emacs time stamps.
3147 (ltime): Now accepts single 64-bit integer, as that's more convenient
3148 for callers.
3149
3150 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3151
3152 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3153 for compatibility with pselect. Support ns-resolution time stamps.
3154
3155 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3156
3157 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3158 Check for time stamp overflow, and support ns-resolution time stamps.
3159
3160 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3161 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3162 (timeval_subtract): Remove; no longer needed.
3163 (XTflash, XTring_bell, x_wait_for_event):
3164 Port to ns-resolution time stamps. Don't assume time_t is signed.
3165
b6a92dfe
CY
31662012-06-22 Chong Yidong <cyd@gnu.org>
3167
3168 * xdisp.c (x_consider_frame_title): Revert last change.
3169
d251c37c
EZ
31702012-06-22 Eli Zaretskii <eliz@gnu.org>
3171
3172 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3173 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3174 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3175 staticidx goes up to 1597 out of 1600 = 0x640.)
3176
f10deafb
PE
31772012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3178
3179 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3180 Otherwise, the umask might be mistakenly 0 while handling input signals.
3181
ec6de1e2
SM
31822012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3183
3184 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3185
28be1ada
DA
31862012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3187
3188 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3189 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3190 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3191 access to `contents' member of Lisp_Vector objects with AREF and ASET
3192 where appropriate.
3193
c6bf3022
CY
31942012-06-19 Chong Yidong <cyd@gnu.org>
3195
3196 * frame.c (delete_frame): When selecting a frame on a different
3197 text terminal, do not alter the terminal's top-frame.
3198
3199 * xdisp.c (format_mode_line_unwind_data): Record the target
3200 frame's selected window and its terminal's top-frame.
3201 (unwind_format_mode_line): Restore them.
3202 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3203 Callers changed.
3204 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3205 since tty frames can be explicitly named.
3206 (prepare_menu_bars): Likewise.
3207
3208 * term.c (Ftty_top_frame): New function.
3209
defd4196
PE
32102012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 Port byte-code-meter to modern targets.
3213 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3214 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3215 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3216 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3217 (METER_1, METER_2): Simplify.
3218
1053a871
SM
32192012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3220
3221 * data.c (Fdefalias): Return `symbol' (bug#11686).
3222
b7e8d081
MR
32232012-06-18 Martin Rudalics <rudalics@gmx.at>
3224
3225 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3226 gets killed during executing of this function (Bug#11665).
3227 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3228 (Vkill_buffer_query_functions): In doc-string say that functions
3229 run by this hook should not change the current buffer.
3230
7ea2b339
PE
32312012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 Fix recently-introduced process.c problems found by static checking.
3234 * process.c (write_queue_push, write_queue_pop, send_process):
3235 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3236 (write_queue_pop): Fix pointer signedness problem.
3237 (send_process): Remove unused local.
3238
96a313a1
CY
32392012-06-17 Chong Yidong <cyd@gnu.org>
3240
3241 * xdisp.c (redisplay_internal): No need to redisplay terminal
3242 frames that are not on top.
3243
20ca2e94
TN
32442012-06-17 Troels Nielsen <bn.troels@gmail.com>
3245
3246 * process.c (make_process): Initialize write_queue.
3247 (write_queue_push, write_queue_pop): New functions.
3248 (send_process): Use them to maintain correct ordering of process
3249 writes (Bug#10815).
3250
9a900ca9
PE
32512012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3252
310fbfa8
PE
3253 * lisp.h (eassert): Assume C89 or later.
3254 This removes the need for CHECK.
3255 (CHECK): Remove. Its comments about always evaluating its
3256 argument were confusing, as 'eassert' typically does not evaluate
3257 its argument.
3258
27bb1ca4
PE
3259 * coding.c (produce_chars): Use ptrdiff_t, not int.
3260
9a900ca9
PE
3261 * xterm.c (x_draw_underwave): Check for integer overflow.
3262 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3263
41b7f8bc 32642012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3265
3266 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3267 referenced (Bug#11583).
3268
9b0e3eba
AA
32692012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3270
3271 Implement wave-style variant of underlining.
3272 * dispextern.h (face_underline_type): New enum.
3273 (face): Add field for underline type.
3274 * nsterm.m (ns_draw_underwave): New function.
3275 (ns_draw_text_decoration): Use it.
3276 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3277 New functions.
3278 (x_draw_glyph_string): Use them.
3279 * xfaces.c (Qline, Qwave): New Lisp objects.
3280 (check_lface_attrs, merge_face_ref)
1053a871
SM
3281 (Finternal_set_lisp_face_attribute, realize_x_face):
3282 Handle wave-style underline face attributes.
9b0e3eba
AA
3283 * xterm.c (x_draw_underwave): New function.
3284 (x_draw_glyph_string): Use it.
3285
0fb52f11
JB
32862012-06-16 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3289 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3290 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3291 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3292 ($(BLD)/w32select.$(O)): Update dependencies.
3293
e5560ff7
AS
32942012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3295
3296 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3297 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3298 * character.c (_fetch_multibyte_char_p): Remove.
3299 * alloc.c: Include "character.h" before "buffer.h".
3300 * bidi.c: Likewise.
3301 * buffer.c: Likewise.
3302 * bytecode.c: Likewise.
3303 * callint.c: Likewise.
3304 * callproc.c: Likewise.
3305 * casefiddle.c: Likewise.
3306 * casetab.c: Likewise.
3307 * category.c: Likewise.
3308 * cmds.c: Likewise.
3309 * coding.c: Likewise.
3310 * composite.c: Likewise.
3311 * dired.c: Likewise.
3312 * dispnew.c: Likewise.
3313 * doc.c: Likewise.
3314 * dosfns.c: Likewise.
3315 * editfns.c: Likewise.
3316 * emacs.c: Likewise.
3317 * fileio.c: Likewise.
3318 * filelock.c: Likewise.
3319 * font.c: Likewise.
3320 * fontset.c: Likewise.
3321 * fringe.c: Likewise.
3322 * indent.c: Likewise.
3323 * insdel.c: Likewise.
3324 * intervals.c: Likewise.
3325 * keyboard.c: Likewise.
3326 * keymap.c: Likewise.
3327 * lread.c: Likewise.
3328 * macros.c: Likewise.
3329 * marker.c: Likewise.
3330 * minibuf.c: Likewise.
3331 * nsfns.m: Likewise.
3332 * nsmenu.m: Likewise.
3333 * print.c: Likewise.
3334 * process.c: Likewise.
3335 * regex.c: Likewise.
3336 * region-cache.c: Likewise.
3337 * search.c: Likewise.
3338 * syntax.c: Likewise.
3339 * term.c: Likewise.
3340 * textprop.c: Likewise.
3341 * undo.c: Likewise.
3342 * unexsol.c: Likewise.
3343 * w16select.c: Likewise.
3344 * w32fns.c: Likewise.
3345 * w32menu.c: Likewise.
3346 * window.c: Likewise.
3347 * xdisp.c: Likewise.
3348 * xfns.c: Likewise.
3349 * xmenu.c: Likewise.
3350 * xml.c: Likewise.
3351 * xselect.c: Likewise.
3352
2f07e6af
EZ
33532012-06-16 Eli Zaretskii <eliz@gnu.org>
3354
1053a871
SM
3355 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3356 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3357 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3358 row.
3359 (handle_face_prop): Use chunk-relative overlay string index when
3360 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3361 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3362 the rightmost. (Bug#11720)
2f07e6af 3363
29b83cec
AS
33642012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3365
3366 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3367 (CATEGORY_MEMBER): Enforce 1/0 value.
3368 * category.c (_temp_category_set): Remove.
3369
4c5501e9
EZ
33702012-06-16 Eli Zaretskii <eliz@gnu.org>
3371
3372 * window.c (Fdelete_other_windows_internal)
3373 (Fdelete_window_internal): Don't access frame's mouse highlight
3374 info of the initial frame. (Bug#11677)
3375
2b570124
PE
33762012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3377
e93864f9
PE
3378 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3379 Assume USE_2_TAGS_FOR_INTS.
3380 (xreload): Adjust $tagmask width to match recent lisp.h change.
3381
2b570124
PE
3382 Simplify lisp.h in minor ways that should not affect code.
3383 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3384 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3385 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3386 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3387 (INTTYPEBITS): New macro, for clarity.
3388 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3389 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3390 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3391 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3392 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3393
81755f69
JB
33942012-06-13 Juanma Barranquero <lekktu@gmail.com>
3395
3396 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3397
16192a57
GM
33982012-06-13 Glenn Morris <rgm@gnu.org>
3399
3400 * s/bsd-common.h (BSD4_3):
3401 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3402
646b5f55
AS
34032012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3404
3405 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3406 instead of union.
3407 (XLI, XIL): Define.
1053a871
SM
3408 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3409 Use them.
3410 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3411 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3412 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3413 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3414 * frame.c (delete_frame): Remove outdated comment.
3415 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3416 USE_LISP_UNION_TYPE.
3417 (Fw32_unregister_hot_key): Likewise.
3418 (Fw32_toggle_lock_key): Likewise.
3419 * w32menu.c (add_menu_item): Likewise.
3420 (w32_menu_display_help): Use XIL instead of checking
3421 USE_LISP_UNION_TYPE.
3422 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3423 (init_heap): Likewise.
3424 * w32term.c (w32_read_socket): Update comment.
3425
1d3823c9
GM
34262012-06-13 Glenn Morris <rgm@gnu.org>
3427
c62ff706
GM
3428 * s/usg5-4-common.h, src/s/unixware.h:
3429 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3430
1d3823c9
GM
3431 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3432
bfe3e0a2
PE
34332012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3434
3435 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3436 * alloc.c (make_number) [!defined make_number]:
3437 Remove, as lisp.h always defines this now.
3438 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3439 (roundup_size): Verify that it is a power of 2.
3440 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3441 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3442 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3443 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3444 USE_LSB_TAG now is always defined to be either 0 or 1.
3445 All uses changed.
3446 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3447 code works fine either way, and efficiency is not a concern here,
3448 as the union type is for debugging, not for production.
3449 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3450 Use an inline function on all platforms when using the union type,
3451 since this is simpler and 'static inline' can be used portably
3452 within Emacs now.
3453 (LISP_INITIALLY_ZERO): New macro.
3454 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3455 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3456
45fa9c0f
GM
34572012-06-12 Glenn Morris <rgm@gnu.org>
3458
b4492cba
GM
3459 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3460
3461 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3462
45fa9c0f
GM
3463 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3464 Move BROKEN_SIGIO to configure.
3465
3466 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3467 Move NO_TERMIO to configure.
3468
0e25d334
CY
34692012-06-12 Chong Yidong <cyd@gnu.org>
3470
3471 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3472 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3473 MagickExportImagePixels is undefined.
3474
43682bb6
PE
34752012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 * image.c (imagemagick_load_image): Remove unused label.
3478
a9be7d2b
GM
34792012-06-11 Glenn Morris <rgm@gnu.org>
3480
3481 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3482 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3483 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3484 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3485
3017f87f
SM
34862012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3487
3488 * alloc.c (make_byte_code): New function.
3489 (Fmake_byte_code): Use it. Don't purify here.
3490 * lread.c (read1): Use it as well to avoid extra allocation.
3491
1b9b4cf4
CY
34922012-06-11 Chong Yidong <cyd@gnu.org>
3493
3494 * image.c (imagemagick_load_image): Implement transparency.
3495
95988fcf
AS
34962012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3497
3498 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3499 account for preceding backslashes. (Bug#11663)
3500
cd4eb164
CY
35012012-06-09 Chong Yidong <cyd@gnu.org>
3502
3503 * term.c: Support italics in capable terminals (Bug#9652).
3504 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3505 (turn_on_face): Output using TS_enter_italic_mode if available.
3506 Don't handle unused blinking and alt-charset cases.
3507 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3508 and tty_alt_charset_p cases.
3509 (tty_capable_p, init_tty): Support italics.
3510
3511 * termchar.h (struct tty_display_info): Add field for italics.
3512 Remove unused blink field.
3513
3514 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3515 Handle slant.
3516
3517 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3518 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3519 tty_alt_charset_p. Add tty_italic_p.
3520
ff88beb8
MA
35212012-06-09 Michael Albinus <michael.albinus@gmx.de>
3522
3523 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3524 dbus_type_is_basic if available.
3525 (xd_extract_signed, xd_extract_unsigned): Rename from
3526 extract_signed and extract_unsigned, respectively. Adapt callers.
3527
44286096
CY
35282012-06-09 Chong Yidong <cyd@gnu.org>
3529
1682701f
CY
3530 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3531
44286096
CY
3532 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3533 case (Bug#9752).
3534
d86feb17
PE
35352012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 * xdisp.c (vmessage): Treat frame message as multibyte.
3538 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3539 would generate the diagnostic "Making \302\247 buffer-local while
3540 let-bound!".
3541
d5c20fe8
EZ
35422012-06-08 Eli Zaretskii <eliz@gnu.org>
3543
3544 * dispnew.c (showing_window_margins_p): Undo last change, which
3545 was done due to an inadvertent commit.
3546 (adjust_frame_glyphs_for_frame_redisplay): Do call
3547 showing_window_margins_p.
3548
513749ee
SM
35492012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3550
3551 * eval.c (Fmake_var_non_special): New primitive.
3552 (syms_of_eval): Defsubr it.
3553 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3554
d4a8f5c1
JB
35552012-06-08 Juanma Barranquero <lekktu@gmail.com>
3556
3557 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3558 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3559
8bbbc977
EZ
35602012-06-08 Eli Zaretskii <eliz@gnu.org>
3561
3562 * alloc.c (allocate_vectorlike): Fix last change.
3563
f3372c87
DA
35642012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3565
3566 Block-based vector allocation of small vectors.
3567 * lisp.h (struct vectorlike_header): New field `nbytes',
3568 adjust comment accordingly.
3569 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3570 to denote vector blocks. Adjust users (live_vector_p,
3571 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3572 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3573 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3574 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3575 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3576 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3577 (roundup_size): New constant.
3578 (struct vector_block): New data type.
3579 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3580 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3581 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3582 (sweep_vectors): New functions.
3583 (allocate_vectorlike): Return `zero_vector' as the only vector of
3584 0 items. Allocate new vector from block if vector size is less than
3585 or equal to VBLOCK_BYTES_MAX.
3586 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3587 (init_alloc_once): Add call to init_vectors.
3588
4f18a4ed
SM
35892012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3592
86f158bc
PE
35932012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 * doprnt.c (doprnt): Truncate multibyte char correctly.
3596 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3597 would mishandle a string argument "Xc" if X was a multibyte
3598 character of length 2: it would truncate after X's first byte
3599 rather than including all of X.
3600
c5cfcbe0
CY
36012012-06-06 Chong Yidong <cyd@gnu.org>
3602
3603 * buffer.c (word_wrap): Doc fix.
3604
c05cf390
PE
36052012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3606
3607 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3608
0c3461de
GM
36092012-06-03 Glenn Morris <rgm@gnu.org>
3610
3611 * xdisp.c (tool-bar-style): Doc fix.
3612
c71232db
UM
36132012-06-03 Ulrich Müller <ulm@gentoo.org>
3614
3615 * Makefile.in (PAXCTL): Define.
3616 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3617 binary via PaX flags if the paxctl utility is available.
3618 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3619 Restore PaX flags to their default. (Bug#11398)
3620
383f7350
CY
36212012-06-03 Chong Yidong <cyd@gnu.org>
3622
3623 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3624 buffer (Bug#11226).
3625
5f2c76c6
CY
36262012-06-03 Chong Yidong <cyd@gnu.org>
3627
3628 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3629 (note_mode_line_or_margin_highlight): If there is no help echo,
3630 use mode-line-default-help-echo. Handle the case where the mouse
3631 position is past the end of the mode line string.
3632
3633 * buffer.c (buffer_local_value_1): New function, split from
3634 Fbuffer_local_value; can return Qunbound.
3635 (Fbuffer_local_value): Use it.
3636 (Vmode_line_format): Docstring tweaks.
3637
773d47f6
PE
36382012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 * sysdep.c (system_process_attributes): Improve comment.
3641
f2d6a3df
SM
36422012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3643
3644 * keyboard.c: Export real-this-command to Elisp.
3645 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3646 and DEFVAR it. Update all users.
3647
63810350
PE
36482012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3649
7bd5c1f4
PE
3650 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3651
63810350
PE
3652 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3653 Convert pctcpu and pctmem to Lisp float properly.
3654 Let the compiler fold better, as 100.0/0x8000 is exact.
3655
a2821611
AS
36562012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3657
3658 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3659 cons_block.
3660
5fceba1d
PE
36612012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3664
c98ff5dd
DA
36652012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3666
3667 For a 'struct window', replace some Lisp_Object fields to
3668 bitfields where appropriate, remove unused fields.
3669 * window.h (struct window): Remove unused 'last_mark_x' and
3670 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3671 change it's type from Lisp_Object to bitfield.
3672 Change type of 'force_start', 'optional_new_start',
3673 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3674 fields from Lisp_Object to bitfield. Adjust users accordingly.
3675
ca34e0be
PE
36762012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 Pacify gcc -Wdouble-precision when using Xaw.
3679 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3680 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3681 Use 'float' consistently, rather than 'float' in most places
3682 and 'double' in a couple of places.
3683
efc00ab1 36842012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3685
3686 * xdisp.c (handle_stop): Detect whether we have overlay strings
3687 loaded by testing it->current.overlay_string_index to be
3688 non-negative, instead of checking whether n_overlay_strings is
3689 positive. (Bug#11587)
3690
efc00ab1 36912012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3692
3693 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3694
3695 * doc.c (Fsubstitute_command_keys): Doc fix.
3696
efc00ab1 36972012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3698
3699 * search.c (search_buffer): Remove calls to
3700 r_alloc_inhibit_buffer_relocation, as it is now called by
3701 maybe_unify_char, which was the cause of relocation of buffer text
3702 in bug#11519.
3703
efc00ab1 37042012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3705
3706 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3707 for the duration of call to load_charset, to avoid problems with
3708 callers of maybe_unify_char that access buffer text through C
3709 pointers.
3710
3711 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3712 decrement the inhibition flag, instead of just setting or
3713 resetting it.
3714
ba93a187
PE
37152012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3716
3717 Remove obsolete '#define static' cruft.
3718 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3719 This #undef was "temporary" in 2000; it is no longer needed
3720 now that '#define static' has gone away.
3721 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3722 (gray_bitmap_bits): Remove; no longer needed.
3723 All uses replaced with definiens.
3724 * xterm.c: Include "bitmaps/gray.xbm".
3725
9e4bf381
PE
37262012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3727
3728 Clean up __executable_start, monstartup when --enable-profiling.
3729 The following changes affect the code only when profiling.
3730 * dispnew.c (__executable_start): Rename from safe_bcopy.
3731 Define only on platforms that need it.
3732 * emacs.c: Include <sys/gmon.h> when profiling.
3733 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3734 (__executable_start): Remove decl, since lisp.h does it now.
3735 (safe_bcopy): Remove decl; no longer has that name.
3736 (main): Coalesce #if into single bit of code, for simplicity.
3737 Cast pointers to uintptr_t, since standard libraries want integers
3738 and not pointers.
3739 * lisp.h (__executable_start): New decl.
3740
32d72c2f
GM
37412012-05-31 Glenn Morris <rgm@gnu.org>
3742
3743 * image.c (Fimagemagick_types): Doc fix.
3744
baac5bc7
JM
37452012-05-30 Jim Meyering <meyering@redhat.com>
3746
3747 * callproc.c (Fcall_process_region): Include directory component
3748 in mkstemp error message (Bug#11586).
3749
72cb32cf
PE
37502012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 * alloc.c, lisp.h (make_pure_vector): Now static.
3753
61b108cc
SM
37542012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3755
3756 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3757 Move to byte-run.el.
3758 (Fautoload): Do the hash-doc more carefully.
3759 * data.c (Fdefalias): Purify definition, except for keymaps.
3760 (Qdefun): Move from eval.c.
3761 * lisp.h (Qdefun): Remove.
3762 * lread.c (read1): Tiny simplification.
3763
471fe23d
TN
37642012-05-29 Troels Nielsen <bn.troels@gmail.com>
3765
934f3f58 3766 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3767 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3768 Bug#9642, but explicitly check that the buffer the overlay would
3769 be moved to is live and rearrange lines to make sure that errors
3770 will not put the overlay in an inconsistent state.
3771 (Fdelete_overlay): Cosmetics.
3772
85d0efd1
EZ
37732012-05-28 Eli Zaretskii <eliz@gnu.org>
3774
3775 * w32term.c (my_bring_window_to_top): New function.
3776 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3777 could be different from the original one.
3778 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3779 (Bug#11513)
3780
3781 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3782 by calling BringWindowToTop.
3783
3784 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3785 (WM_EMACS_END): Increase by one.
3786
da92a98c
PE
37872012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3788
3789 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3790 This avoids undefined behavior that might cause the eassert
3791 to not catch an out-of-range value.
3792
74d1f848
JB
37932012-05-28 Juanma Barranquero <lekktu@gmail.com>
3794
3795 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3796 Update dependencies.
3797
9e1a06fc
EZ
37982012-05-27 Eli Zaretskii <eliz@gnu.org>
3799
3800 * bidi.c (bidi_mirror_char): Fix last change.
3801
f3dd7312
AS
38022012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3805 when referring to sectname field in printf format.
3806
81899c91
PE
38072012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3808
57b81a9f
PE
3809 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3810 Only r_alloc_inhibit_buffer_relocation needed to be added;
3811 the others were already declared.
3812
81899c91
PE
3813 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3814 before checking whether it's out of range. Put the check inside
3815 eassert. See
3816 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3817
33017faf 38182012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3819
3820 * callproc.c (Fcall_process): Restore a line that was accidentally
3821 commented out in the 2011-02-13 change (bug#11547).
3822
33017faf 38232012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3824
3825 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3826 defined on ralloc.c.
3827
3828 * buffer.c [REL_ALLOC]: Remove prototypes of
3829 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3830 they are now on lisp.h.
3831
3832 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3833
3834 * search.c (search_buffer): Use it to inhibit relocation of buffer
3835 text while re_search_2 is doing its job, because re_search_2 is
3836 passed C pointers to buffer text. (Bug#11519)
3837
23415acf
EZ
3838 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3839 Update value to 24.
3840
44e27368
EZ
3841 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3842 state after an additional call to move_it_in_display_line_to, keep
3843 the values of it->max_ascent and it->max_descent found for the
3844 entire line.
3845 (pos_visible_p): Revert the comparison against bottom_y to what it
3846 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3847 (Bug#11464)
3848
c1892f11
PE
38492012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3850
3851 Fix coding-related core dumps with gcc -ftrapv.
3852 The code was computing A - B, where A and B are pointers, and B is
3853 random garbage. This can lead to core dumps on platforms that
3854 have special pointer registers, and it also leads to core dumps on
3855 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3856 A - B only when B is initialized properly.
3857 * coding.c (coding_set_source, coding_set_destination): Return void.
3858 (coding_change_source, coding_change_destinations): New functions,
3859 with the old behaviors of coding_set_source and coding_set_destination.
3860 All callers that need an offset changed to use these new functions.
3861
eb7afdad
GM
38622012-05-26 Glenn Morris <rgm@gnu.org>
3863
3864 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3865
f12fdf02
EZ
38662012-05-26 Eli Zaretskii <eliz@gnu.org>
3867
53a63be6 3868 Extend mouse support on W32 text-mode console.
61b108cc
SM
3869 * xdisp.c (draw_row_with_mouse_face):
3870 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3871
eb3f6f01 3872 * w32console.c: Include window.h.
61b108cc
SM
3873 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3874 New functions.
eb3f6f01
EZ
3875 (initialize_w32_display): Initialize mouse-highlight data.
3876
53a63be6
EZ
3877 * w32inevt.c: Include termchar.h and window.h.
3878 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3879 moves, call note_mouse_highlight. If help_echo changed, call
3880 gen_help_event to produce help-echo message in the echo area.
3881 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3882 highlight info.
3883
4cfd81f6
PE
38842012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * lread.c (read1): Simplify slightly to avoid an overflow warning
3887 with GCC 4.7.0 on x86-64.
3888
4446092a
EZ
38892012-05-26 Eli Zaretskii <eliz@gnu.org>
3890
3891 * bidi.c (bidi_mirror_char): Revert last change: an int is
3892 definitely wide enough here.
3893
42b2a986 38942012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3895
42b2a986 3896 Fix integer width and related bugs (Bug#9874).
eb106a49 3897 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3898 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3899 (string_bytes, check_sblock, allocate_string_data):
3900 (compact_small_strings, Fmake_bool_vector, make_string)
3901 (make_unibyte_string, make_multibyte_string)
3902 (make_string_from_bytes, make_specified_string)
3903 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3904 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3905 (mark_vectorlike):
3906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3907 (allocate_pseudovector):
3908 Use int, not EMACS_INT, where int is wide enough.
3909 (inhibit_garbage_collection, Fgarbage_collect):
3910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3911 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3912 int might not be wide enough.
3913 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3914 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3915 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3916 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3917 (bidi_level_of_next_char, bidi_move_to_visually_next):
3918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3919 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3920 (Fkill_buffer, Fset_buffer_major_mode)
3921 (advance_to_char_boundary, Fbuffer_swap_text)
3922 (Fset_buffer_multibyte, overlays_at, overlays_in)
3923 (overlay_touches_p, struct sortvec, record_overlay_string)
3924 (overlay_strings, recenter_overlay_lists)
3925 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3926 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3927 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3928 (Foverlay_recenter, last_overlay_modification_hooks_used)
3929 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3931 (validate_region): Omit unnecessary test for b <= e,
3932 since that's guaranteed by the previous test.
d311d28c
PE
3933 (adjust_overlays_for_delete): Avoid pos + length overflow.
3934 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3935 (report_overlay_modification):
3936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3937 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3938 Omit pointer cast, which isn't needed anyway, and doesn't work
3939 after the EMACS_INT -> ptrdiff_t change.
02481186 3940 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3941 * buffer.h: Adjust decls to match defn changes elsewhere.
3942 (struct buffer_text, struct buffer):
3943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3944 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3945 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3946 not int, to avoid needless 32-bit limit on 64-bit hosts.
3947 (exec_byte_code): Use tighter memory-full test, one that checks
3948 for alloca overflow. Don't compute the address of the object just
3949 before an array, as that's not portable. Use EMACS_INT, not
3950 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3951 * callint.c (Fcall_interactively):
3952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3953 * callproc.c (call_process_kill, Fcall_process):
3954 Don't assume pid_t fits into an Emacs fixnum.
3955 (call_process_cleanup, Fcall_process, child_setup):
3956 Don't assume pid_t fits into int.
3957 (call_process_cleanup, Fcall_process, delete_temp_file)
3958 (Fcall_process_region):
3959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3960 (Fcall_process): Simplify handling of volatile integers.
3961 Use int, not EMACS_INT, where int will do.
3962 * casefiddle.c (casify_object, casify_region, operate_on_word)
3963 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3965 (casify_object): Avoid integer overflow when overallocating buffer.
3966 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3967 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3968 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3969 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3970 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3971 integers are now checked earlier. All uses replaced with XINT.
3972 (ccl_driver):
3973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3974 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3975 (ccl_driver, Fregister_code_conversion_map):
3976 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3977 (resolve_symbol_ccl_program): Check that vector header is in range.
3978 Always copy the vector, so that we can check its contents reliably
3979 now rather than having to recheck each instruction as it's being
3980 executed. Check that vector words fit in 'int'.
3981 (ccl_get_compiled_code, Fregister_ccl_program)
3982 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3983 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3984 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3985 contents are in range.
3986 (Fccl_execute_on_string): Check that status is in range.
3987 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3988 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3989 Accept and return EMACS_INT, not int, because callers can pass values
3990 out of 'int' range.
3991 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3992 (multibyte_chars_in_text, parse_str_as_multibyte)
3993 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3994 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3995 (string_escape_byte8, Fget_byte):
3996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3997 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3998 avoid mishandling large integers.
3999 * character.h: Adjust decls to match defn changes elsewhere.
4000 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4001 (Ffind_charset_region):
4002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4003 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4004 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4005 Don't assume fixnum fits in int.
d311d28c
PE
4006 (load_charset_map_from_vector, Fmap_charset_chars):
4007 Remove now-unnecessary CHECK_NATNUMs.
4008 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4009 Don't rely on undefined behavior with signed left shift overflow.
4010 Don't assume unsigned int fits into fixnum, or that fixnum fits
4011 into unsigned int. Don't require max_code to be a valid fixnum;
4012 that's not true for gb10830 4-byte on a 32-bit host. Allow
4013 invalid_code to be a cons, for the same reason. Require code_offset
4014 to be a character. Avoid int overflow if max_char is close
4015 to INT_MAX.
4016 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4017 this is intended anyway and avoids some undefined behavior.
4018 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4019 INDEX_TO_CODE_POINT, as that's what it expects.
4020 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4021 * charset.h (DECODE_CHAR): Return int, not unsigned;
4022 this is what was intended anyway, and it avoids undefined behavior.
4023 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4024 integer-overflow issues.
4025 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4026 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4027 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4028 * chartab.c (Fmake_char_table, Fset_char_table_range)
4029 (uniprop_get_decoder, uniprop_get_encoder):
4030 Don't assume fixnum fits in int.
4031 * cmds.c (move_point): New function, that does the gist of
4032 Fforward_char and Fbackward_char, but does so while checking
4033 for integer overflow more accurately.
c96e5d6a 4034 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4035 (Fforward_line, Fend_of_line, internal_self_insert)
4036 (internal_self_insert):
4037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4038 Fix a FIXME, by checking for integer overflow when calculating
4039 target_clm and actual_clm.
4040 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4041 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4042 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4043 (coding_alloc_by_making_gap, alloc_destination)
4044 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4045 (encode_coding_utf_16, detect_coding_emacs_mule)
4046 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4047 (detect_coding_iso_2022, decode_coding_iso_2022)
4048 (encode_invocation_designation, encode_designation_at_bol)
4049 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4050 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4051 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4052 (encode_coding_ccl, encode_coding_raw_text)
4053 (detect_coding_charset, decode_coding_charset)
4054 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4055 (produce_composition, produce_charset, produce_annotation)
4056 (decode_coding, handle_composition_annotation)
4057 (handle_charset_annotation, consume_chars, decode_coding_gap)
4058 (decode_coding_object, encode_coding_object, detect_coding_system)
4059 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4060 (code_convert_region, code_convert_string)
8f50130c
PE
4061 (Fdefine_coding_system_internal)
4062 (coding_set_source, coding_set_destination):
d311d28c
PE
4063 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4064 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4065 (Fdefine_coding_system_internal):
4066 Don't assume fixnums fit in int.
4067 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4068 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4069 (Funencodable_char_position, Fcheck_coding_systems_region)
4070 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4072 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4073 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4074 Don't access memory outside of the args array.
d311d28c 4075 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4076 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4077 result of ENCODE_CHAR.
d311d28c
PE
4078 * coding.h: Adjust decls to match defn changes elsewhere.
4079 (struct coding_system):
4080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4081 * composite.c (get_composition_id, find_composition)
4082 (run_composition_function, update_compositions)
4083 (compose_text, composition_gstring_put_cache)
4084 (composition_gstring_p, composition_gstring_width)
4085 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4086 (composition_compute_stop_pos, composition_reseat_it)
4087 (composition_update_it, struct position_record)
4088 (find_automatic_composition, composition_adjust_point)
4089 (Fcomposition_get_gstring, Ffind_composition_internal):
4090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4091 (update_compositions):
4092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4093 * composite.h: Adjust decls to match defn changes elsewhere.
4094 (struct composition):
4095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4096 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4097 Do not attempt to compute the address of the object just before a
4098 buffer; this is not portable.
4099 (Faref, Faset):
4100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4101 (Faset): Use int, not EMACS_INT, where int is wide enough.
4102 (Fstring_to_number): Don't assume fixnums fit in int.
4103 (Frem): Don't assume arg is nonnegative.
4104 * dbusbind.c (xd_append_arg): Check for integers out of range.
4105 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4106 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4107 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4108 (xd_get_connection_references): Return ptrdiff_t, not int.
4109 All uses changed.
4110 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4111 (xd_read_message_1):
4112 Use int, not unsigned, where the dbus API uses int.
4113 (Fdbus_message_internal): Don't overflow mtype.
4114 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4115 * dired.c (directory_files_internal, file_name_completion, scmp)
4116 (file_name_completion_stat):
4117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4118 (file_name_completion): Don't overflow matchcount.
4119 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4120 * dispextern.h: Adjust decls to match defn changes elsewhere.
4121 (struct text_pos, struct glyph, struct bidi_saved_info)
4122 (struct bidi_string_data, struct bidi_it, struct composition_it)
4123 (struct it):
4124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4125 (struct display_pos, struct composition_it, struct it):
4126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4127 * dispnew.c (increment_matrix_positions)
4128 (increment_row_positions, mode_line_string)
4129 (marginal_area_string):
4130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4131 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4133 (duration_to_sec_usec): New function, to check for overflow better.
4134 (Fsleep_for, sit_for): Use it.
4135 * doc.c (get_doc_string, store_function_docstring):
4136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4137 (get_doc_string, Fsnarf_documentation):
4138 Use int, not EMACS_INT, where int is wide enough.
4139 (get_doc_string):
4140 Use SAFE_ALLOCA, not alloca.
4141 Check for overflow when converting EMACS_INT to off_t.
4142 * doprnt.c (doprnt):
4143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4144 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4145 Don't assume uid_t fits into fixnum.
4146 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4147 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4148 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4149 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4150 (general_insert_function)
4151 (Finsert_char, make_buffer_string, make_buffer_string_both)
4152 (update_buffer_properties, Fbuffer_substring)
4153 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4154 (Fsubst_char_in_region, check_translation)
4155 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4156 (transpose_markers, Ftranspose_regions):
4157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4158 (clip_to_bounds): Move to lisp.h as an inline function).
4159 (Fconstrain_to_field): Don't assume integers are nonnegative.
4160 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4161 (Fsubst_char_in_region, Fsave_restriction):
4162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4163 (Femacs_pid): Don't assume pid_t fits into fixnum.
4164 (lo_time): Use int, not EMACS_INT, when int suffices.
4165 (lisp_time_argument): Check for usec out of range.
4166 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4167 (Fuser_login_name, Fuser_full_name): Signal an error
4168 if a uid argument is out of range, rather than relying on
4169 undefined behavior.
c8d5c857
PE
4170 (Fformat_time_string): Remove now-unnecessary check.
4171 lisp_time_argument checks for out-of-range usec now.
243e0530 4172 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4173 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4174 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4175 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4176 (init_cmdargs, Fdump_emacs):
4177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4178 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4179 the bottom (typically) 32 bits of the fixnum.
4180 * eval.c (specpdl_size, call_debugger):
4181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4182 (when_entered_debugger, Fbacktrace_debug):
4183 Don't assume fixnum can fit in int.
4184 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4185 the object just before a buffer; this is not portable.
4186 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4187 (grow_specpdl, unbind_to):
4188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4189 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4190 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4191 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4192 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4193 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4195 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4196 (a_write, e_write):
4197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4198 (Fcopy_file, non_regular_nbytes, read_non_regular)
4199 (Finsert_file_contents):
4200 Use int, not EMACS_INT, where int is wide enough.
4201 (READ_BUF_SIZE): Verify that it fits in int.
4202 (Finsert_file_contents): Check that counts are in proper range,
4203 rather than assuming fixnums fit into ptrdiff_t etc.
4204 Don't assume fixnums fit into int.
125b3835 4205 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4206 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4207 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4208 (string_char_to_byte, string_byte_to_char)
4209 (string_make_multibyte, string_to_multibyte)
4210 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4211 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4212 (substring_both, Fdelete, internal_equal, Ffillarray)
4213 (Fclear_string, mapcar1)
4214 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4215 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4216 (larger_vector, make_hash_table, maybe_resize_hash_table)
4217 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4218 (Fmaphash, secure_hash):
4219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4220 (concat): Check for string index and length overflow.
4221 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4222 (Frequire):
4223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4224 (larger_vector): New API (vec, incr_min, size_max) replaces old
4225 one (vec, new_size, init). This catches size overflow.
4226 INIT was removed because it was always Qnil.
4227 All callers changed.
4228 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4229 the upper bound on a hash table index size.
4230 (make_hash_table, maybe_resize_hash_table): Use it.
4231 (secure_hash): Computer start_byte and end_byte only after
4232 they're known to be in ptrdiff_t range.
4233 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4234 (Ffont_get_glyphs, Ffont_at):
4235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4236 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4237 (Flist_fonts, Fopen_font):
4238 Don't assume fixnum can fit in int.
4239 (check_gstring): Don't assume index can fit in int.
4240 (font_match_p): Check that fixnum is a character, not a nonnegative
4241 fixnum, since the later code needs to stuff it into an int.
4242 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4243 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4244 conversion overflow issues.
4245 (Fopen_font): Check for integer out of range.
4246 (Ffont_get_glyphs): Don't assume index can fit in int.
4247 * font.h: Adjust decls to match defn changes elsewhere.
4248 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4249 integer overflow.
4250 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4251 printmax_t, where ptrdiff_t is wide enough.
4252 (Finternal_char_font):
4253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4254 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4255 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4256 (Fset_frame_position, x_set_frame_parameters)
4257 (x_set_line_spacing, x_set_border_width)
4258 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4259 Check that fixnums are in proper range for system types.
4260 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4262 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4263 Use SAFE_ALLOCA_LISP, not alloca.
4264 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4265 intptr_t is wide enough.
4266 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4267 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4268 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4269 Check for fixnum out of range.
4270 * ftfont.c (ftfont_list): Don't assume index fits in int.
4271 Check that fixnums are in proper range for system types.
4272 (ftfont_shape_by_flt):
4273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4274 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4276 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4277 Check that fixnums are in proper range for system types.
4278 * gnutls.h: Adjust decls to match defn changes elsewhere.
4279 * gtkutil.c (xg_dialog_run):
4280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4281 (update_frame_tool_bar):
4282 Check that fixnums are in proper range for system types.
4283 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4284 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4285 * indent.c (last_known_column, last_known_column_point):
4286 (current_column_bol_cache):
4287 (skip_invisible, current_column, check_display_width):
4288 (check_display_width, scan_for_column, current_column_1)
4289 (Findent_to, Fcurrent_indentation, position_indentation)
4290 (indented_beyond_p, Fmove_to_column, compute_motion):
4291 (Fcompute_motion, Fvertical_motion):
4292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4293 (last_known_column_modified): Use EMACS_INT, not int.
4294 (check_display_width):
4295 (Fcompute_motion):
4296 Check that fixnums and floats are in proper range for system types.
4297 (compute_motion): Don't assume index or fixnum fits in int.
4298 (compute_motion, Fcompute_motion):
4299 Use int, not EMACS_INT, when it is wide enough.
4300 (vmotion): Omit local var start_hpos that is always 0; that way
4301 we don't need to worry about overflow in expressions involving it.
4302 * indent.h: Adjust decls to match defn changes elsewhere.
4303 (struct position):
4304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4305 Use int, not EMACS_INT, where int is wide enough.
4306 Remove unused members ovstring_chars_done and tab_offset;
4307 all uses removed.
4308 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4309 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4310 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4311 (make_gap, copy_text, insert, insert_and_inherit)
4312 (insert_before_markers, insert_before_markers_and_inherit)
4313 (insert_1, count_combining_before, count_combining_after)
4314 (insert_1_both, insert_from_string)
4315 (insert_from_string_before_markers, insert_from_string_1)
4316 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4317 (adjust_after_replace, adjust_after_insert, replace_range)
4318 (replace_range_2, del_range, del_range_1, del_range_byte)
4319 (del_range_both, del_range_2, modify_region)
4320 (prepare_to_modify_buffer, signal_before_change)
4321 (signal_after_change, Fcombine_after_change_execute):
4322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4323 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4324 (balance_an_interval, split_interval_right, split_interval_left)
4325 (find_interval, next_interval, update_interval)
4326 (adjust_intervals_for_insertion, delete_node, delete_interval)
4327 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4328 (static_offset_intervals, offset_intervals)
4329 (merge_interval_right, merge_interval_left, make_new_interval)
4330 (graft_intervals_into_buffer, temp_set_point_both)
4331 (temp_set_point, set_point, adjust_for_invis_intang)
4332 (set_point_both, move_if_not_intangible, get_property_and_range)
4333 (get_local_map, copy_intervals, copy_intervals_to_string)
4334 (compare_string_intervals, set_intervals_multibyte_1):
4335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4336 * intervals.h: Adjust decls to match defn changes elsewhere.
4337 (struct interval):
4338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4339 * keyboard.c (this_command_key_count, this_single_command_key_start)
4340 (before_command_key_count, before_command_echo_length, echo_now)
4341 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4342 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4343 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4344 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4346 (last_non_minibuf_size, last_point_position, echo_truncate)
4347 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4348 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4349 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4350 (stuff_buffered_input):
4351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4352 (last_auto_save, command_loop_1, read_char):
4353 Use EMACS_INT, not int, to avoid integer overflow.
4354 (record_char): Avoid overflow in total_keys computation.
4355 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4356 * keyboard.h: Adjust decls to match defn changes elsewhere.
4357 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4358 (Fkey_description, Fdescribe_vector, Flookup_key):
4359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4360 (click_position): New function, to check that positions are in range.
4361 (Fcurrent_active_maps):
4362 (describe_command):
4363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4364 (Faccessible_keymaps, Fkey_description):
4365 (preferred_sequence_p):
4366 Don't assume fixnum can fit into int.
4367 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4368 Check for integer overflow in size calculations.
4369 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4370 avoid mishandling large integers.
4371 * lisp.h: Adjust decls to match defn changes elsewhere.
4372 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4373 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4374 (struct Lisp_Marker):
4375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4376 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4377 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4378 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4379 All callers changed.
4380 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4381 Assume the arg has valid form, since it always does.
4382 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4383 unsigned integer system type.
4384 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4385 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4387 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4388 (duration_to_sec_usec): New decl.
4389 * lread.c (read_from_string_index, read_from_string_index_byte)
4390 (read_from_string_limit, readchar, unreadchar, openp)
4391 (read_internal_start, read1, oblookup):
4392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4393 (Fload, readevalloop, Feval_buffer, Feval_region):
4394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4395 (openp): Check for out-of-range argument to 'access'.
4396 (read1): Use int, not EMACS_INT, where int is wide enough.
4397 Don't assume fixnum fits into int.
6efdadfd 4398 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4399 (read_filtered_event): Use duration_to_sec_usec
4400 to do proper overflow checking on durations.
d311d28c
PE
4401 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4402 in size calculation.
4403 (Fexecute_kbd_macro):
4404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4405 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4406 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4407 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4408 (set_marker_both, set_marker_restricted_both, marker_position)
4409 (marker_byte_position, Fbuffer_has_markers_at):
4410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4411 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4412 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4413 It now merely ensures that the menu is large enough, without
4414 necessarily growing it, as this avoids some integer overflow issues.
4415 All callers changed.
4416 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4418 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4419 Use SAFE_ALLOCA_LISP, not alloca.
4420 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4421 to EMACS_INT. Check that fixnums are in proper range for system types.
4422 * minibuf.c (minibuf_prompt_width, string_to_object)
4423 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4424 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4426 (get_minibuffer, read_minibuf_unwind):
4427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4428 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4429 this simplifies overflow checking. All callers changed.
4430 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4431 (Ftest_completion):
4432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4433 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4434 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4435 Check that fixnums are in proper range for system types.
4436 (Fx_create_frame, Fx_show_tip):
4437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4438 * nsfont.m (ns_findfonts, nsfont_list_family):
4439 Don't assume fixnum fits in long.
4440 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4442 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4443 wide enough.
17fdb222 4444 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4446 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4447 (PRINTDECLARE, PRINTPREPARE):
4448 (strout, print_string):
4449 (print, print_preprocess, print_check_string_charset_prop)
4450 (print_object):
4451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4452 (PRINTDECLARE):
4453 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4455 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4456 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4457 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4458 (print_error_message): Use SAFE_ALLOCA, not alloca.
4459 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4460 (print_depth, new_backquote_output, print_number_index):
4461 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4462 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4463 (Fset_process_window_size, Fformat_network_address)
4464 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4465 (sigchld_handler):
d311d28c 4466 Check that fixnums are in proper range for system types.
d44287d4 4467 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4468 Check for process-ids out of pid_t range rather than relying on
4469 undefined behavior.
e4d81efc 4470 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4471 (Fformat_network_address, read_process_output, send_process)
4472 (Fprocess_send_region, status_notify):
4473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4474 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4475 (wait_reading_process_output, read_process_output, exec_sentinel):
4476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4477 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4478 (Faccept_process_output): Use duration_to_sec_usec to do proper
4479 overflow checking on durations.
dde14581
PE
4480 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4481 Don't assume pid_t fits in int.
02481186
PE
4482 * process.h (struct Lisp_Process): Members tick and update_tick
4483 are now of type EMACS_INT, not int.
b62b53e8
PE
4484 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4485 configured --with-wide-int.
d311d28c
PE
4486 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4487 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4488 * search.c (looking_at_1, string_match_1):
4489 (fast_string_match, fast_c_string_match_ignore_case)
4490 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4491 (scan_newline, find_before_next_newline, search_command)
4492 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4493 (set_search_regs, wordify):
4494 (Freplace_match):
4495 (Fmatch_data):
4496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4497 (string_match_1, search_buffer, set_search_regs):
4498 (Fmatch_data):
4499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4500 (wordify): Check for overflow in size calculation.
4501 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4502 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4503 Check that fixnums are in proper range for system types.
4504 * sound.c (struct sound_device)
4505 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4507 (Fplay_sound_internal):
4508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4509 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4510 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4511 (Fparse_partial_sexp):
4512 Don't assume fixnums can fit in int.
4513 (struct lisp_parse_state, find_start_pos, find_start_value)
4514 (find_start_value_byte, find_start_begv)
4515 (update_syntax_table, char_quoted, dec_bytepos)
4516 (find_defun_start, prev_char_comend_first, back_comment):
4517 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4518 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4520 (Finternal_describe_syntax_value): Check that match_lisp is a
4521 character, not an integer, since the code stuffs it into int.
4522 (scan_words, scan_sexps_forward):
4523 Check that fixnums are in proper range for system types.
4524 (Fforward_word):
4525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4526 (scan_sexps_forward):
4527 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4528 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4529 * syntax.h: Adjust decls to match defn changes elsewhere.
4530 (struct gl_state_s):
4531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4532 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4533 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4534 * sysdep.c (wait_for_termination_1, wait_for_termination)
4535 (interruptible_wait_for_termination, mkdir):
4536 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4537 (emacs_read, emacs_write):
4538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4539 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4540 and double all fit in int.
d311d28c
PE
4541 * term.c (set_tty_color_mode):
4542 Check that fixnums are in proper range for system types.
4543 * termhooks.h (struct input_event):
4544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4545 * textprop.c (validate_interval_range, interval_of)
4546 (Fadd_text_properties, set_text_properties_1)
4547 (Fremove_text_properties, Fremove_list_of_text_properties)
4548 (Ftext_property_any, Ftext_property_not_all)
4549 (copy_text_properties, text_property_list, extend_property_ranges)
4550 (verify_interval_modification):
4551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4552 (Fnext_single_char_property_change)
4553 (Fprevious_single_char_property_change):
4554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4555 (copy_text_properties):
4556 Check for integer overflow in index calculation.
d311d28c
PE
4557 * undo.c (last_boundary_position, record_point, record_insert)
4558 (record_delete, record_marker_adjustment, record_change)
4559 (record_property_change):
4560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4561 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4563 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4564 (Fx_hide_tip, Fx_file_dialog):
4565 * w32menu.c (set_frame_menubar):
4566 Use ptrdiff_t, not int, for consistency with rest of code.
4567 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4568 (select_window, Fdelete_other_windows_internal)
4569 (window_scroll_pixel_based, window_scroll_line_based)
4570 (Frecenter, Fset_window_configuration):
4571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4572 (Fset_window_hscroll, run_window_configuration_change_hook)
4573 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4574 (Fscroll_other_window, Frecenter):
d311d28c
PE
4575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4576 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4577 Don't assume fixnum fits in int.
4578 (Fset_window_scroll_bars):
4579 Check that fixnums are in proper range for system types.
4580 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4581 (string_pos, c_string_pos, number_of_chars, init_iterator)
4582 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4583 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4584 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4585 (face_before_or_after_it_pos, handle_invisible_prop)
4586 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4587 (display_prop_intangible_p, string_buffer_position_lim)
4588 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4589 (get_overlay_strings_1, get_overlay_strings)
4590 (iterate_out_of_display_property, forward_to_next_line_start)
4591 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4592 (get_next_display_element, set_iterator_to_next)
4593 (get_visually_first_element, compute_stop_pos_backwards)
4594 (handle_stop_backwards, next_element_from_buffer)
4595 (move_it_in_display_line_to, move_it_in_display_line)
4596 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4597 (add_to_log, message_dolog, message_log_check_duplicate)
4598 (message2, message2_nolog, message3, message3_nolog
4599 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4600 (current_message_1, truncate_echo_area, truncate_message_1)
4601 (set_message, set_message_1, store_mode_line_noprop)
4602 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4603 (text_outside_line_unchanged_p, check_point_in_composition)
4604 (reconsider_clip_changes)
4605 (redisplay_internal, set_cursor_from_row, try_scrolling)
4606 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4607 (redisplay_window, find_last_unchanged_at_beg_row)
4608 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4609 (trailing_whitespace_p, find_row_edges, display_line)
4610 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4611 (display_mode_element, store_mode_line_string)
4612 (pint2str, pint2hrstr, decode_mode_spec)
4613 (display_count_lines, display_string, draw_glyphs)
4614 (x_produce_glyphs, x_insert_glyphs)
4615 (rows_from_pos_range, mouse_face_from_buffer_pos)
4616 (fast_find_string_pos, mouse_face_from_string_pos)
4617 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4619 (safe_call, init_from_display_pos, handle_fontified_prop)
4620 (handle_single_display_spec, load_overlay_strings)
4621 (with_echo_area_buffer, setup_echo_area_for_printing)
4622 (display_echo_area, echo_area_display)
4623 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4624 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4625 (redisplay_window, dump_glyph_row, display_mode_line)
4626 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4627 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4629 (handle_single_display_spec, build_desired_tool_bar_string)
4630 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4631 (get_specified_cursor_type):
4632 Check that fixnums are in proper range for system types.
4633 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4634 (Flookup_image_map):
4635 Don't assume fixnums fit in int.
4636 (compare_overlay_entries):
4637 Avoid mishandling comparisons due to subtraction overflow.
4638 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4639 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4640 (handle_tool_bar_click):
4641 Use int, not unsigned, since we prefer signed and the signedness
4642 doesn't matter here.
4643 (get_next_display_element, next_element_from_display_vector):
4644 Use int, not EMACS_INT, when int is wide enough.
4645 (start_hourglass): Use duration_to_sec_usec to do proper
4646 overflow checking on durations.
4647 * xfaces.c (Fbitmap_spec_p):
4648 Check that fixnums are in proper range for system types.
4649 (compare_fonts_by_sort_order):
4650 Avoid mishandling comparisons due to subtraction overflow.
4651 (Fx_family_fonts, realize_basic_faces):
4652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4653 (Fx_family_fonts):
4654 Don't assume fixnum fits in int.
4655 Use SAFE_ALLOCA_LISP, not alloca.
4656 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4657 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4658 (face_at_buffer_position, face_for_overlay_string)
4659 (face_at_string_position):
4660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4661 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4662 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4663 (Fx_show_tip):
4664 Check that fixnums are in proper range for system types.
4665 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4666 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4668 (Fx_change_window_property): Don't assume fixnums fit in int.
4669 * xfont.c (xfont_chars_supported):
4670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4671 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4672 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4674 * xml.c (parse_region):
4675 * xrdb.c (magic_file_p):
4676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4677 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4678 (x_get_local_selection, x_reply_selection_request)
4679 (x_handle_selection_request, wait_for_property_change):
4680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4681 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4682 short is wide enough.
4683 (x_send_client_event): Don't assume fixnum fits in int.
4684 * xterm.c (x_x_to_emacs_modifiers):
4685 Don't assume EMACS_INT overflows nicely into int.
4686 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4687 may come from Lisp.
4688 (handle_one_xevent): NATNUMP can eval its arg twice.
4689 (x_connection_closed):
4690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4691 * xterm.h: Adjust decls to match defn changes elsewhere.
4692 (struct scroll_bar): Use struct vectorlike_header
4693 rather than rolling our own approximation.
4694 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4695
c6574eb5
GM
46962012-05-25 Glenn Morris <rgm@gnu.org>
4697
4698 * lisp.mk (lisp): Update for more files being compiled now.
4699
e8d32c7e
SM
47002012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4701
48def666
SM
4702 * lread.c: Remove `read_pure' which makes no difference.
4703 (read_pure): Remove var.
4704 (unreadpure): Remove function.
4705 (readevalloop): Don't call read_list with -1 flag.
4706 (read1, read_vector): Don't test read_pure any more.
4707 (read_list): Simplify.
4708
e8d32c7e
SM
4709 * fileio.c, character.h: Minor style tweaks.
4710
4b2addb7
DA
47112012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4712
4713 * window.h (clip_changed): Remove useless declaration.
4714
584461b2
JB
47152012-05-22 Juanma Barranquero <lekktu@gmail.com>
4716
4717 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4718 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4719
34374650
PE
47202012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4721
4722 Remove src/m/*.
4723 This directory predates autoconf and is no longer needed nowadays.
4724 Move its few remaining bits of functionality to where they're needed.
4725 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4726 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4727 * m/template.h: Remove.
4728 * Makefile.in (M_FILE): Remove. All uses removed.
4729 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4730 * lisp.h (USE_LSB_TAG):
4731 * mem-limits.h (EXCEEDS_LISP_PTR):
4732 Use VAL_MAX, not VALBITS, in #if.
4733 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4734 (EMACS_UINT): Define unconditionally now.
4735 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4736 (BITS_PER_EMACS_INT): New constants, replacing
4737 what used to be in config.h, but not useful in #if.
4738 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4739 define them any more.
4740 (VAL_MAX): New macro.
4741 (VALMASK): Use it.
4742 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4743 BITS_PER_EMACS_INT, in #if.
4744 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4745 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4746 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4747 * s/ms-w32.h (DATA_START):
4748 Move here from removed file m/intel386.h.
4749 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4750 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4751
261cb4bb
PE
47522012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 Assume C89 or later.
4755 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4756 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4757 (xrealloc):
4758 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4759 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4760 * textprop.c, tparam.c (NULL): Remove.
4761 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4762 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4763 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4764 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4765 * xterm.c (input_signal_count): Assume volatile works.
4766
ff23cd9f
KB
47672012-05-21 Ken Brown <kbrown@cornell.edu>
4768
4769 * xgselect.c (xg_select): Fix first argument in call to 'select'
4770 (bug#11508).
4771
1b170bc6
KB
47722012-05-20 Ken Brown <kbrown@cornell.edu>
4773
4774 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4775 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4776
b2f4d39f
KB
47772012-05-19 Ken Brown <kbrown@cornell.edu>
4778
4779 * xfns.c (x_in_use): Remove `static' qualifier.
4780 * xterm.h (x_in_use): Declare.
4781 * xgselect.c: Include xterm.h.
4782 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4783 and `display_arg' (bug#9754).
4784
003fdae2
PE
47852012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4786
9232a6d9
PE
4787 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4788
003fdae2
PE
4789 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4790 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4791
784b56e2
EZ
47922012-05-18 Eli Zaretskii <eliz@gnu.org>
4793
4794 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4795
4796 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4797 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4798
4799 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4800 reference to image_cache->refcount.
4801 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4802
a0a79cde
JL
48032012-05-17 Juri Linkov <juri@jurta.org>
4804
4805 * search.c (Fword_search_regexp, Fword_search_backward)
4806 (Fword_search_forward, Fword_search_backward_lax)
4807 (Fword_search_forward_lax): Move functions to isearch.el
4808 (bug#10145, bug#11381).
4809
b0572523
PE
48102012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4811
4812 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4813
9660f5fc
SM
48142012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4815
4816 * lread.c (init_obarray): Declare Qt and Qnil as special.
4817
4374de83
GM
48182012-05-14 Glenn Morris <rgm@gnu.org>
4819
4820 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4821 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4822
dc44c39a
PE
48232012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4824
078c97cb
PE
4825 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4826
dc44c39a
PE
4827 * unexaix.c: Port to more-recent AIX compilers.
4828 (report_error, report_error_1, make_hdr, copy_sym)
4829 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4830 Make arguments const char *, not char *, to avoid violations of C
4831 standard and to fix some AIX warnings reported by Gilles Pion.
4832
e18afed7 48332012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4834
4835 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4836 already have overlays loaded.
4837 (handle_single_display_spec): Before returning without displaying
4838 fringe bitmap, synchronize the bidi iterator with the main display
4839 iterator, by calling iterate_out_of_display_property.
4840 (iterate_out_of_display_property): Detect buffer iteration by
4841 testing that it->string is a Lisp string.
4842 (get_next_display_element): When the current object is exhausted,
4843 and there's something on it->stack, call set_iterator_to_next to
4844 proceed with what's on the stack, instead of returning zero.
4845 (set_iterator_to_next): If called at the end of a Lisp string,
4846 proceed to consider_string_end without incrementing string
4847 position. Don't increment display vector index past the end of
4848 the display vector. (Bug#11417)
c8fb9dc6
EZ
4849 (pos_visible_p): Don't report a position visible when move_it_to
4850 stopped at the last line of window, which happens to be scanned
4851 backwards by the bidi iteration. (Bug#11464)
ac268e67 4852
e18afed7 48532012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4854
4855 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4856 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4857 are on a TTY, and thus unable to display on the fringes.
4858 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4859 so we need to signal to the caller that this is a "replacing"
4860 display spec. This fixes display when the spec is invalid or we
4861 are on a TTY.
4862
e18afed7 48632012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4864
4865 * unexaix.c (make_hdr): Fix typo in prototype.
4866 This bug broke the build on AIX. Problem reported by Gilles Pion.
4867
9d0a235a
MA
48682012-05-14 Michael Albinus <michael.albinus@gmx.de>
4869
4870 * keyboard.c (kbd_buffer_get_event): Read special events also in
4871 batch mode. (Bug#11415)
4872
9e6b06ed
GM
48732012-05-12 Glenn Morris <rgm@gnu.org>
4874
4875 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4876
c1a1d7a3
EZ
48772012-05-12 Eli Zaretskii <eliz@gnu.org>
4878
4879 * lisp.mk (lisp): Add newcomment.elc.
4880
3fe7cdc8
GM
48812012-05-12 Glenn Morris <rgm@gnu.org>
4882
4883 * Makefile.in (MKDIR_P): New, set by configure.
4884 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4885
53f7d2c0
PE
48862012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 Remove unused function hourglass_started.
4889 * dispextern.h (hourglass_started):
4890 * w32fns.c (hourglass_started):
4891 * xdisp.c (hourglass_started): Remove.
4892
75aafb17
JB
48932012-05-10 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4896 Update dependencies.
4897
12959e8e
PE
48982012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4899
97107e2e
PE
4900 * xgselect.c (xg_select): Put maxfds+1 into a var.
4901 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4902
12959e8e
PE
4903 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4904
836d29b3
DA
49052012-05-10 Dave Abrahams <dave@boostpro.com>
4906
4907 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4908 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4909
5cb67954
MA
49102012-05-09 Michael Albinus <michael.albinus@gmx.de>
4911
4912 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4913 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4914 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4915 Initialize xd_registered_buses.
4916
3478ec45
PE
49172012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4918
b263a6b0
PE
4919 Untag more efficiently if USE_LSB_TAG.
4920 This is based on a proposal by YAMAMOTO Mitsuharu in
4921 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4922 For an admittedly artificial (nth 8000 longlist) benchmark on
4923 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4924 Emacs's overall text size by 1%.
4925 * lisp.h (XUNTAG): New macro.
4926 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4927 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4928 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4929 * eval.c (Fautoload):
4930 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4931 * frame.h (XFRAME): Use XUNTAG.
4932
3478ec45
PE
4933 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4934 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4935 Remove unportable assumptions about print widths of types like
4936 dbus_uint32_t.
4937 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4938 intptr_t when converting between pointer and integer, to avoid GCC
4939 warnings about wrong width.
4940
666b903b 49412012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4942
4943 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4944 stack for each reader_thread, instead of defaulting to 8MB
4945 determined by the linker. This avoids failures in creating
4946 subprocesses on Windows 7, see the discussion in this thread:
4947 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4948
b120cc17
JC
49492012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4950
4951 Fix up display of the *Minibuf-0* buffer in the mini window.
4952 * keyboard.c (read_char): Don't clear the echo area if there's no
4953 message to clear.
4954 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4955 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4956
9a4b36f8
MA
49572012-05-07 Michael Albinus <michael.albinus@gmx.de>
4958
4959 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4960 batch mode.
4961
e5f9458f
CY
49622012-05-06 Chong Yidong <cyd@gnu.org>
4963
4964 * lisp.mk (lisp): Update.
4965
eceeb5fc 49662012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4967
4968 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4969
71873e2b
SM
49702012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4971
4972 * data.c (PUT_ERROR): New macro.
4973 (syms_of_data): Use it. Add new error type `user-error'.
4974 * undo.c (user_error): New function.
4975 (Fprimitive_undo): Use it.
4976 * print.c (print_error_message): Adjust print style for `user-error'.
4977 * keyboard.c (user_error): New function.
4978 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4979
ab0fa4e4
PE
49802012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4981
4982 Do not limit current-time-string to years 1000..9999.
4983 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4984 (Fcurrent_time_string): Support any year that is supported by the
4985 underlying localtime representation. Don't use asctime, as it
4986 has undefined behavior for years outside the range -999..9999.
4987
7ed806a7
PE
49882012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 Fix race conditions involving setenv, gmtime, localtime, asctime.
4991 Without this fix, interrupts could mess up code that uses these
4992 nonreentrant functions, since setting TZ invalidates existing
4993 tm_zone or tzname values, and since most of these functions return
4994 pointers to static storage.
4995 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4996 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4997 Grow the critical sections to include not just invoking
4998 localtime/gmtime, but also accessing these functions' results
4999 including their tm_zone values if any, and any related TZ setting.
5000 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5001 so that the struct tm is saved in the critical section.
5002 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5003 motivated by the fact that memory allocation needs to be outside
5004 the critical section.
5005
0c16dfed
DA
50062012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5007
5008 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5009 with RESET_INTERVAL.
5010
5011 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5012 Remove duplicated buffer name initialization.
5013
3f83ace8
JM
50142012-05-02 Jim Meyering <jim@meyering.net>
5015
5016 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5017
c7b8541e
JM
5018 * xfns.c (x_window): Use xstrdup (Bug#11375).
5019
90207a15 50202012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5021
5022 * xdisp.c (pos_visible_p): If already at a newline from the
5023 display string before the 'while' loop, don't walk back the glyphs
5024 from it3.glyph_row. Solves assertion violation when the display
5025 string begins with a newline (egg.el). (Bug#11367)
5026
b593d6a9
AH
50272012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5028
5029 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5030 Move to simple.el.
5031
4737362e
GM
50322012-05-01 Glenn Morris <rgm@gnu.org>
5033
99cf43f9
GM
5034 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5035 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5036 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5037 All were removed before 23.1.
5038
9311dcff
GM
5039 * dispnew.c: Remove HAVE_LIBNCURSES test;
5040 it is always true on relevant platforms.
5041
4d5c6349
GM
5042 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5043 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5044
4737362e
GM
5045 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5046
74dd3a6b
AS
50472012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5048
5049 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5050 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5051 Remove.
5052
13c379ee
PE
50532012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5054
5055 Do not avoid creating empty evaporating overlays (Bug#9642).
5056 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5057 That is, do not delete an evaporating overlay if it becomes
5058 empty after its bounds are adjusted to fit within its buffer.
5059 This fix caused other problems, and I'm reverting it until we get
5060 to the bottom of them.
5061
a8e7d6d7 50622012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5063
5064 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5065
a8e7d6d7 50662012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5067
5068 * xdisp.c (pos_visible_p): If the window start position is beyond
5069 ZV, start the display from buffer beginning. Prevents assertion
5070 violation in init_iterator when the minibuffer window is scrolled
5071 via the scroll bar.
5072
5073 * window.c (window_scroll_pixel_based): Likewise.
5074
a8e7d6d7 50752012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5076
5077 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5078
a8e7d6d7 50792012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5080
5081 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5082 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5083
a8e7d6d7 50842012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5085
b593d6a9
AH
5086 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5087 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5088
1c6900d9
EZ
50892012-04-26 Eli Zaretskii <eliz@gnu.org>
5090
4c3fa1d9
EZ
5091 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5092 display element, check also the underlying string or buffer
5093 character. (Bug#11341)
5094
1c6900d9
EZ
5095 * w32menu.c: Include w32heap.h.
5096 (add_menu_item): If the call to AppendMenuW (via
5097 unicode_append_menu) fails, disable Unicode menus only if we are
5098 running on Windows 9X/Me.
5099
42bf8205
AS
51002012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5101
5102 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5103 (xgetint): Add missing shift for LSB tags.
5104
b1bac16e
MR
51052012-04-24 Martin Rudalics <rudalics@gmx.at>
5106
5107 * keyboard.c (read_char): Don't wipe echo area for select window
5108 events: These might get delayed via `mouse-autoselect-window'
5109 (Bug#11304).
5110
d69621cc
JB
51112012-04-24 Juanma Barranquero <lekktu@gmail.com>
5112
5113 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5114 manipulation of :loaded-from data.
5115
02fd101b
JB
51162012-04-23 Juanma Barranquero <lekktu@gmail.com>
5117
5118 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5119 now a cons (bug#11311).
5120
888bec30
PE
51212012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5122
89a438bd
PE
5123 Do not create empty overlays with the evaporate property (Bug#9642).
5124 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5125 if it becomes empty after its bounds are adjusted to fit within
5126 its buffer. Without this fix, in a nonempty buffer (let ((o
5127 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5128 yields an empty overlay that has the evaporate property, which is
5129 not supposed to happen.
5130
1068fe4d
PE
5131 Fix minor GTK3 problems found by static checking.
5132 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5133 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5134 (struct _EmacsFixedClass, emacs_fixed_get_type):
5135 Move decls here from emacsgtkfixed.h, since they needn't be public.
5136 (emacs_fixed_get_type): Now static.
5137 (emacs_fixed_class_init): Omit unused local.
5138 (emacs_fixed_child_type): Remove; unused.
5139 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5140 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5141 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5142 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5143 (EMACS_FIXED_GET_CLASS): Remove; unused.
5144 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5145
888bec30
PE
5146 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5147 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5148
de85e130
PE
51492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5150
d0baac98 5151 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5152 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5153 (__malloc_size_t, __malloc_ptrdiff_t):
5154 Remove. All uses removed, replaced by the definiens if needed,
5155 since we can assume C89 or better now.
5156 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5157 (protect_malloc_state, align, get_contiguous_space)
5158 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5159 (malloc_atfork_handler_child, malloc_enable_thread)
5160 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5161 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5162 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5163 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5164 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5165 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5166 Define using prototypes, not old style.
5167 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5168 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5169 (align): Don't assume that signed integer overflow wraps around.
5170 Omit unused local var.
5171 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5172 (_free_internal_nolock, memalign, mallochook, reallochook):
5173 Omit no-longer-needed casts.
5174 (valloc): Use getpagesize, not __getpagesize.
5175 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5176 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5177
de85e130
PE
5178 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5179
dcbf5805
MA
51802012-04-22 Michael Albinus <michael.albinus@gmx.de>
5181
5182 Move functions from C to Lisp. Make non-blocking method calls
5183 the default. Implement further D-Bus standard interfaces.
5184
5185 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5186 (QCdbus_request_name_allow_replacement)
5187 (QCdbus_request_name_replace_existing)
5188 (QCdbus_request_name_do_not_queue)
5189 (QCdbus_request_name_reply_primary_owner)
5190 (QCdbus_request_name_reply_in_queue)
5191 (QCdbus_request_name_reply_exists)
5192 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5193 (QCdbus_registered_serial, QCdbus_registered_method)
5194 (QCdbus_registered_signal): New Lisp objects.
5195 (XD_DEBUG_MESSAGE): Use sizeof.
5196 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5197 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5198 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5199 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5200 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5201 (xd_signature, xd_append_arg): Allow float for integer types.
5202 (xd_get_connection_references): New function.
b593d6a9
AH
5203 (xd_get_connection_address): Rename from xd_initialize.
5204 Return cached address.
dcbf5805
MA
5205 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5206 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5207 level.
5208 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5209 Return number of refcounts.
dcbf5805
MA
5210 (Fdbus_get_unique_name): Make stronger parameter check.
5211 (Fdbus_message_internal): New defun.
5212 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5213 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5214 (Fdbus_send_signal, Fdbus_register_service)
5215 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5216 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5217 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5218 (Vdbus_compiled_version, Vdbus_runtime_version)
5219 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5220 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5221 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5222 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5223 Adapt docstring.
dcbf5805 5224
52828e02
PE
52252012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5226
da05bc4c
PE
5227 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5228 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5229 Do not assume ptrdiff_t is the same width as 'int'.
5230
52828e02
PE
5231 * alloc.c: Handle unusual debugging option combinations.
5232 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5233 since the two debugging options are incompatible.
5234 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5235 is defined.
5236 (mem_init, mem_insert, mem_insert_fixup):
5237 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5238 (NEED_MEM_INSERT): Remove; no longer needed.
5239
f01769f9
LL
52402012-04-22 Leo Liu <sdl.web@gmail.com>
5241
5242 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5243
5790543d
PE
52442012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5245
5246 * sysdep.c [__FreeBSD__]: Minor cleanups.
5247 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5248 Use Emacs indenting style more consistently. Avoid some casts.
5249 Use 'double' consistently rather than mixing 'float' and 'double'.
5250
b91b7e4d
EW
52512012-04-21 Eduard Wiebe <usenet@pusto.de>
5252
b593d6a9
AH
5253 * sysdep.c (list_system_processes, system_process_attributes):
5254 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5255
6114eb15
AS
52562012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5257
5258 * lisp.mk (lisp): Update.
5259
2f38dff7
PE
52602012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5261
5262 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5263 It is never used otherwise.
5264
4ae29f89
SM
52652012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5266
5267 * print.c (print_preprocess): Only check print_depth if print-circle
5268 is nil.
5269 (print_object): Check for cycles even when print-circle is nil and
5270 print-gensym is t, but only check print_depth if print-circle is nil.
5271
f30d612a
CY
52722012-04-20 Chong Yidong <cyd@gnu.org>
5273
5274 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5275 set the status to "failed" and ensure that sentinel is run.
5276
c07a4c0b 52772012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5278
5279 * process.c (Fset_process_inherit_coding_system_flag)
5280 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5281 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5282
c07a4c0b 52832012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5284
5285 * xdisp.c (string_buffer_position_lim): Limit starting position to
5286 BEGV.
5287 (set_cursor_from_row): If called for a mode-line or header-line
5288 row, return zero immediately.
5289 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5290 farther than the first row after the header line, if any.
5291 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5292 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5293
c07a4c0b 52942012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5295
4ae29f89
SM
5296 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5297 (bug#11238).
ad3a2b41 5298
c07a4c0b 52992012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 53002012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5301
5302 configure: new option --enable-gcc-warnings (Bug#11207)
5303 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5304 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5305 (ALL_CFLAGS): Use new macros rather than old.
5306 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5307 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5308 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5309 -Wunused-result, -Wunused-variable. This should go away once
5310 the Emacs and Gnulib regex code is merged.
5311 (xmalloc, xrealloc): Now static.
5312
aba027e8
PE
53132012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5314
5315 * dired.c (Fsystem_groups): Remove unused local.
5316
e5a36063
GM
53172012-04-17 Glenn Morris <rgm@gnu.org>
5318
5319 * dired.c (Fsystem_users): Doc fix.
5320
316411f0
DA
53212012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5322
5323 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5324 (syms_of_dired): Add them.
5325
9426aba4
PE
53262012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5327
b62a57be
PE
5328 Fix minor alloc.c problems found by static checking.
5329 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5330 New extern decls, to avoid calling undeclared functions.
5331 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5332 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5333 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5334 (NEED_MEM_INSERT): New macro.
5335 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5336 Remove one incorrect comment and fix another.
b62a57be 5337
3539f31f
PE
5338 Fix minor ralloc.c problems found by static checking.
5339 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5340 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5341 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5342 (r_alloc_sbrk): Now static.
5343
a041960a
PE
5344 Improve ralloc.c interface checking.
5345 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5346 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5347 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5348 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5349 [REL_ALLOC]: ... to here, to check interface.
5350 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5351 Remove decls. This fixes an "It stinks!".
5352
9426aba4
PE
5353 * alloc.c (which_symbols): Fix alignment issue / type clash.
5354
d55c12ed
AS
53552012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5356
5357 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5358 (struct Lisp_Misc_Any): Likewise.
5359 (struct Lisp_Free): Likewise.
5360 * alloc.c (union aligned_Lisp_Symbol): Define.
5361 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5362 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5363 (union aligned_Lisp_Misc): Define.
5364 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5365 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5366 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5367
b948ce8b
PE
53682012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5371 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5372 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5373 * s/netbsd.h, s/sol2-6.h:
5374 Remove definition of GC_MARK_STACK, since the default now works.
5375 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5376 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5377 no longer the default.
5378 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5379
35dc09a1 53802012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5381
35dc09a1
GM
5382 * lread.c (lisp_file_lexically_bound_p):
5383 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5384
35dc09a1
GM
53852012-04-14 Eli Zaretskii <eliz@gnu.org>
5386
5387 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5388 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5389
53902012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5391
5392 * nsterm.m (constrainFrameRect): Always constrain when there is only
5393 one screen (Bug#10962).
5394
bcd86815
KB
53952012-04-13 Ken Brown <kbrown@cornell.edu>
5396
5397 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5398
c25df26e
RT
53992012-04-13 Reuben Thomas <rrt@sc3d.org>
5400
5401 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5402
0fc59f1e
DC
54032012-04-11 Daniel Colascione <dancol@dancol.org>
5404
5405 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5406 against is gone. It's better to use vfork now so that when Cygwin
5407 gains a new, working vfork, we use it automatically (bug#10398).
5408
de8c03dc
SM
54092012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5410
5411 * window.c (save_window_save): Obey window-point-insertion-type.
5412
2f097256
GM
54132012-04-11 Glenn Morris <rgm@gnu.org>
5414
5415 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5416
453b951e
SM
54172012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5418
5419 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5420
75f1671a 54212012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5422
5423 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5424 (force_quit_count): New var.
5425 (handle_interrupt): Use it.
5426
2a8ce227
JB
54272012-04-10 Juanma Barranquero <lekktu@gmail.com>
5428
5429 * w32.c (w32_delayed_load): Record the full path of the library
5430 being loaded (bug#10424).
5431
935396c0
GM
54322012-04-09 Glenn Morris <rgm@gnu.org>
5433
05920a43
GM
5434 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5435 not just in the obarray, before snarfing them. (Bug#11036)
5436
935396c0
GM
5437 * Makefile.in ($(leimdir)/leim-list.el):
5438 Pass EMACS rather than BUILT_EMACS.
5439
a18ecafa
TZ
54402012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5441
5442 * process.c (make_process):
5443 * process.h: Add integer `gnutls_handshakes_tried' member to
5444 process struct.
5445
6bbef4e5
JC
5446 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5447 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5448
5449 * gnutls.c (gnutls_log_function2i): Convenience log function.
5450 (emacs_gnutls_read): Use new log functions,
5451 `gnutls_handshakes_tried' process member, and
5452 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5453 attempts per process (connection).
5454
b4d3bc10
CY
54552012-04-09 Chong Yidong <cyd@gnu.org>
5456
5457 * eval.c (Fuser_variable_p, user_variable_p_eh)
5458 (lisp_indirect_variable): Functions deleted.
5459 (Fdefvar): Caller changed.
5460
5461 * callint.c (Finteractive, Fcall_interactively):
5462 * minibuf.c (Fread_variable): Callers changed.
5463
70f4d973
EZ
54642012-04-09 Eli Zaretskii <eliz@gnu.org>
5465
5466 * xdisp.c (set_cursor_from_row): If the display string appears in
5467 the buffer at position that is closer to point than the position
5468 after the display string, display the cursor on the first glyph of
5469 the display string. Fixes cursor display when a 'display' text
5470 property immediately follows invisible text. (Bug#11094)
5471
cb3c2e3e
PE
54722012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5473
5474 composite.c: use 'double' consistently
5475 * composite.c (get_composition_id): Use 'double' consistently
5476 instead of converting 'float' to 'double' and vice versa; this is
5477 easier to understand and avoids a GCC warning.
5478
fd06db5d
GM
54792012-04-09 Glenn Morris <rgm@gnu.org>
5480
50fe702a
GM
5481 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5482 preparation for dumping it with emacs. (Bug#4789)
5483 (leimdir): New variable.
5484 ($(leimdir)/leim-list.el): New rule.
5485 (emacs$(EXEEXT)): Depend on leim-list.el.
5486
fd06db5d
GM
5487 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5488 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5489 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5490
55c131ee
AS
54912012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5492
5493 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5494 proper alignment.
5495
9209588f
JB
54962012-04-07 Juanma Barranquero <lekktu@gmail.com>
5497
5498 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5499 Remove unused local variable.
5500
e3fb2efb
PE
55012012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5502
5503 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5504 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5505 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5506 objects, as mark_maybe_pointer will catch them otherwise.
5507 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5508 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5509
b5385551
PE
55102012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5511
5512 Fix typo that broke non-Windows builds.
5513 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5514
9078ead6
EZ
55152012-04-07 Eli Zaretskii <eliz@gnu.org>
5516
5517 Support building on MS-Windows with libxml2.
5518
5519 * makefile.w32-in (OBJ2): Add xml.$(O).
5520 (GLOBAL_SOURCES): Add xml.c.
5521 ($(BLD)/xml.$(O)): New dependency list.
5522
5523 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5524 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5525 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5526 [!WINDOWSNT]: New macros.
5527 (init_libxml2_functions, libxml2_loaded_p): New functions.
5528 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5529 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5530 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5531 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5532 linked in).
6bbef4e5
JC
5533 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5534 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5535 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5536
5537 * emacs.c: Don't include libxml/parser.h.
5538 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5539 xmlCleanupParser directly.
5540
5541 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5542
3811fdf3
EZ
55432012-04-07 Eli Zaretskii <eliz@gnu.org>
5544
5545 * indent.c (Fvertical_motion): If there is a display string at
5546 point, use it.vpos to compute how many lines to backtrack after
5547 move_it_to point. (Bug#11133)
5548
2f8e16b2
EZ
55492012-04-06 Eli Zaretskii <eliz@gnu.org>
5550
5551 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5552 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5553 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5554 macros related to unification of CJK characters. For the details,
5555 see the discussion following the message here:
5556 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5557
3d439cd1
CY
55582012-04-04 Chong Yidong <cyd@gnu.org>
5559
5560 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5561
8bc53d00
EZ
55622012-04-01 Eli Zaretskii <eliz@gnu.org>
5563
5564 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5565 instead of alloca. (Bug#11138)
5566
3b0512a3
AS
55672012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5568
5569 * w32menu.c (is_simple_dialog): Properly check lisp types.
5570 (Bug#11141)
5571
8427ddd2
EZ
55722012-03-31 Eli Zaretskii <eliz@gnu.org>
5573
979022ef
EZ
5574 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5575 position we get to after a call to move_it_to fails the
5576 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5577 only if we wind up in a string from display property. (Bug#11063)
5578
a6b1c7cc
EZ
5579 * window.c (Fdelete_other_windows_internal): Invalidate the row
5580 and column information about mouse highlight, so that redisplay
5581 restores it after reallocating the glyph matrices. (Bug#7464)
5582
8427ddd2
EZ
5583 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5584 string comes from a `display' text property, use the buffer
5585 position of that property as if we actually saw that position in
5586 the row's glyphs.
697ba24b
EZ
5587 (move_it_by_lines): Remove the assertion that
5588 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5589 violated when there's a before-string at the beginning of a line.
5590 (Bug#11063)
8427ddd2 5591
65a0a738
EZ
55922012-03-30 Eli Zaretskii <eliz@gnu.org>
5593
5594 * xdisp.c (append_space_for_newline): If the default face was
5595 remapped, use the remapped face for the appended newline.
5596 (extend_face_to_end_of_line): Use the remapped default face for
5597 extending the face to the end of the line.
5598 (display_line): Call extend_face_to_end_of_line when the default
5599 face was remapped. (Bug#11068)
5600
581355cc
EZ
56012012-03-29 Eli Zaretskii <eliz@gnu.org>
5602
5603 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5604
e8fc049f
SM
56052012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5606
5607 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5608
4fb9a543
GM
56092012-03-27 Glenn Morris <rgm@gnu.org>
5610
5611 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5612 Doc fixes.
5613
679910f1
KH
56142012-03-26 Kenichi Handa <handa@m17n.org>
5615
5616 * dispextern.h (struct glyph): Fix previous change. Change the
5617 bit length of glyphless.ch to 25 (Bug#11082).
5618
90d49b7f
CY
56192012-03-26 Chong Yidong <cyd@gnu.org>
5620
5621 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5622 (command_loop_1): Use it; inhibit selection update for
5623 handle-select-window too (Bug#8996).
5624
f514f6f0
FP
56252012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5626
e8fc049f 5627 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5628
bf43fa51
KH
56292012-03-25 Kenichi Handa <handa@m17n.org>
5630
5631 * dispextern.h (struct glyph): Change the bit length of
5632 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5633
8a0c01dd
EZ
56342012-03-24 Eli Zaretskii <eliz@gnu.org>
5635
5636 * s/ms-w32.h (tzname): Include time.h before redirecting to
5637 _tzname. Fixes the MSVC build. (Bug#9960)
5638
7d1c3a76
AS
56392012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5640
8ed79523
AS
5641 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5642 characters.
5643
7d1c3a76
AS
5644 * xterm.c (XTread_socket): Only modify handling_signal if
5645 !SYNC_INPUT. (Bug#11080)
5646
e99a9b8b
EZ
56472012-03-23 Eli Zaretskii <eliz@gnu.org>
5648
5649 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5650 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5651 when fetching a multibyte character consumes more bytes than
5652 CHAR_BYTES returns, due to unification of CJK characters in
5653 string_char. (Bug#11073)
5654
5063c0e1
TN
56552012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5656
5657 * process.c (wait_reading_process_output): Handle pty disconnect
5658 by refraining from sending oneself a SIGCHLD (bug#10933).
5659
9f851fbd
CY
56602012-03-22 Chong Yidong <cyd@gnu.org>
5661
5662 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5663
5063c0e1 5664 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5665 Mark string as coming from a prefix property.
5666 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5667 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5668
fb5b8aca
CY
56692012-03-21 Chong Yidong <cyd@gnu.org>
5670
5671 * xfaces.c (Vface_remapping_alist): Doc fix.
5672
62356a1b
EZ
56732012-03-20 Eli Zaretskii <eliz@gnu.org>
5674
5675 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5676 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5677 Doc fixes.
62356a1b 5678
025de85b
CY
56792012-03-20 Chong Yidong <cyd@gnu.org>
5680
5681 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5682 to reflect default non-nil value of redisplay-dont-pause.
5683
4827f94e
KH
56842012-03-19 Kenichi Handa <handa@m17n.org>
5685
5686 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5687 it fit in a valid range (Bug#11003).
5688
e50a24a2
EZ
56892012-03-18 Eli Zaretskii <eliz@gnu.org>
5690
5691 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5692 that is not from display property, accept the row as a "cursor
5693 row" if one of the string's character has a non-nil `cursor'
5694 property. Fixes cursor positioning when there are newlines in
5695 overlay strings, e.g. in icomplete.el. (Bug#11035)
5696
9af5ed87
PE
56972012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5700
d1f55f16
CY
57012012-03-12 Chong Yidong <cyd@gnu.org>
5702
5703 * eval.c (inhibit_lisp_code): Rename from
5704 inhibit_window_configuration_change_hook; move from window.c.
5705
5706 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5707 * window.c (run_window_configuration_change_hook)
5708 (syms_of_window): Callers changed.
5709
66c5eebd
CY
57102012-03-11 Chong Yidong <cyd@gnu.org>
5711
413df973
CY
5712 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5713
66c5eebd
CY
5714 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5715
1de11f56
CY
57162012-03-10 Chong Yidong <cyd@gnu.org>
5717
5718 * frame.c (other_visible_frames): Don't assume the selected frame
5719 is visible (Bug#10955).
5720
cae07000
SM
57212012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5722
5723 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5724
89c94350
JD
57252012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5726
5727 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5728 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5729 zero (Bug#10954).
5730
999dd333
GM
57312012-03-03 Glenn Morris <rgm@gnu.org>
5732
01a6dcc8 5733 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5734
de0100f2
EZ
57352012-03-02 Eli Zaretskii <eliz@gnu.org>
5736
5737 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5738 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5739 (redisplay_window, next_element_from_string): Fix typos in
5740 comments.
3e441275
EZ
5741 (redisplay_window): Pass to move_it_vertically the margin in
5742 pixels, not in screen lines.
de0100f2 5743
96a72ee9
GM
57442012-03-02 Glenn Morris <rgm@gnu.org>
5745
5746 * buffer.c (buffer-list-update-hook): Doc fix.
5747
312508d7
EZ
57482012-02-29 Eli Zaretskii <eliz@gnu.org>
5749
5750 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5751 push_it before setting up the iterator for the first overlay
5752 string, even if we have an empty string loaded.
5753 (next_overlay_string): If there's an empty string on the iterator
5754 stack, pop the stack. (Bug#10903)
5755
27f3c637
PE
57562012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5757
5758 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5759 Suggested by Stefan Monnier in
5760 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5761 * alloc.c (widen_to_Lisp_Object): New static function.
5762 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5763 and widening them to Lisp_Objects. This would work even if
5764 USE_LSB_TAG is defined and wide integers are used, which might
5765 happen in a future version of Emacs.
5766
3c9dfce6
CY
57672012-02-25 Chong Yidong <cyd@gnu.org>
5768
fa74b241
CY
5769 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5770 Doc fix.
5771
3c9dfce6
CY
5772 * xselect.c (Fx_selection_exists_p): Doc fix.
5773 (x_clipboard_manager_save_all): Print an informative message
5774 before saving to clipboard manager.
5775
9486df08
CY
57762012-02-24 Chong Yidong <cyd@gnu.org>
5777
5778 * keyboard.c (process_special_events): Handle all X selection
5779 requests in kbd_buffer, not just the next one (Bug#8869).
5780
f01d3321
CY
57812012-02-23 Chong Yidong <cyd@gnu.org>
5782
5783 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5784 call when setting menu-bar-lines and tool-bar-lines parameters.
5785 (unwind_create_frame_1): New helper function.
5786
5787 * window.c (inhibit_window_configuration_change_hook): New var.
5788 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5789 (syms_of_window): Initialize it.
f01d3321 5790
86b847b6
CY
57912012-02-22 Chong Yidong <cyd@gnu.org>
5792
5793 * xterm.c (x_draw_image_relief): Add missing type check for
5794 Vtool_bar_button_margin (Bug#10743).
5795
a59225b1
CY
57962012-02-21 Chong Yidong <cyd@gnu.org>
5797
5798 * fileio.c (Vfile_name_handler_alist): Doc fix.
5799
5800 * buffer.c (Fget_file_buffer): Protect against invalid file
5801 handler return value.
5802
310f5bd4
PE
58032012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5804
cb3a28cc
PE
5805 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5806 when computing $valmask.
5807
310f5bd4
PE
5808 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5809 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5810 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5811 It's useless in that case, and it can cause problems on hosts
5812 that allocate halves of EMACS_INT values separately.
5813 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5814 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5815 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5816 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5817 it avoids undefined behavior on hosts where shifting right by more
5818 than the word width has undefined behavior.
5819
2375c96a
CY
58202012-02-19 Chong Yidong <cyd@gnu.org>
5821
5822 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5823 (Funhandled_file_name_directory, Ffile_name_as_directory)
5824 (Fdirectory_file_name, Fexpand_file_name)
5825 (Fsubstitute_in_file_name): Protect against invalid file handler
5826 return values (Bug#10845).
5827
3eb49e71
EZ
58282012-02-18 Eli Zaretskii <eliz@gnu.org>
5829
5830 * .gdbinit (pitx): Fix incorrect references to fields of the
5831 iterator stack.
5832
7b926f3f
CY
58332012-02-17 Chong Yidong <cyd@gnu.org>
5834
5835 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5836
11273115
PE
58372012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5838
5839 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5840 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5841
c3a70e2b
CY
58422012-02-15 Chong Yidong <cyd@gnu.org>
5843
5844 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5845 marked as special. Also, starting docstrings with * is obsolete.
5846
0ca43699
AS
58472012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5848
5849 * gnutls.c (emacs_gnutls_write): Fix last change.
5850
2e8f3c56
LI
58512012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5852
5853 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5854 send_process.
5855
af70074f
SM
58562012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5857
5858 * keymap.c (Fsingle_key_description): Handle char ranges.
5859
95986d52
CY
58602012-02-12 Chong Yidong <cyd@gnu.org>
5861
afd83bd1
CY
5862 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5863 as that creates a dangerous corner case.
5864
95986d52
CY
5865 * window.c (Fdelete_window_internal): Invalidate the mouse
5866 highlight (Bug#9904).
5867
bd7da63e
GM
58682012-02-12 Glenn Morris <rgm@gnu.org>
5869
5870 * xselect.c (Fx_own_selection_internal)
5871 (Fx_get_selection_internal, Fx_disown_selection_internal)
5872 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5873 * nsselect.m (Fx_own_selection_internal)
5874 (Fx_disown_selection_internal, Fx_selection_exists_p)
5875 (Fx_selection_owner_p, Fx_get_selection_internal):
5876 Sync docs and argument specs with the xselect.c versions.
5877
77abcbc2
LI
58782012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5879
5880 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5881
90b671e2
EZ
58822012-02-11 Eli Zaretskii <eliz@gnu.org>
5883
1c0ca0b7
EZ
5884 * w32select.c (Fx_selection_exists_p): Sync doc string and
5885 argument list with xselect.c. (Bug#10783)
5886
5887 * w16select.c (Fx_selection_exists_p): Sync doc string and
5888 argument list with xselect.c. (Bug#10783)
90b671e2 5889
49241268
GM
58902012-02-10 Glenn Morris <rgm@gnu.org>
5891
5892 * fns.c (Fsecure_hash): Doc fix.
5893
f998bbe7 58942012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5895
5896 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5897
0992bd9c
CY
58982012-02-07 Chong Yidong <cyd@gnu.org>
5899
5900 * buffer.c (Fbuffer_local_variables)
5901 (buffer_lisp_local_variables): Handle unbound vars correctly;
5902 don't let Qunbound leak into Lisp.
5903
af008560
GM
59042012-02-07 Glenn Morris <rgm@gnu.org>
5905
dd605cc4
GM
5906 * image.c (Fimagemagick_types): Doc fix.
5907
af008560
GM
5908 * image.c (imagemagick-render-type): Change it from a lisp object
5909 to an integer. Move the doc here from the lisp manual.
5910 Treat all values not equal to 0 the same.
5911
1449fa1d
CY
59122012-02-06 Chong Yidong <cyd@gnu.org>
5913
5914 * doc.c (store_function_docstring): Avoid applying docstring of
5915 alias to base function (Bug#2603).
5916
3723ec07
AS
59172012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5918
5919 * .gdbinit (pp1, pv1): Remove redundant defines.
5920 (pr): Use pp.
5921
79c1cc1e
CY
59222012-02-04 Chong Yidong <cyd@gnu.org>
5923
5924 * nsterm.m: Declare a global (Bug#10694).
5925
d7f29f8e
EZ
59262012-02-04 Eli Zaretskii <eliz@gnu.org>
5927
cae07000
SM
5928 * w32.c (get_emacs_configuration_options):
5929 Include --enable-checking, if specified, in the return value.
d7f29f8e 5930
3b95a6f9
MR
59312012-02-04 Martin Rudalics <rudalics@gmx.at>
5932
5933 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5934 after rounding frame sizes. (Bug#9723)
5935
d6fa96a6
EZ
59362012-02-04 Eli Zaretskii <eliz@gnu.org>
5937
5938 * keyboard.c (adjust_point_for_property): Don't position point
5939 before BEGV. (Bug#10696)
5940
df0b2940
PE
59412012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5942
5943 Handle overflow when computing char display width (Bug#9496).
5944 * character.c (char_width): Return EMACS_INT, not int.
5945 (char_width, c_string_width): Check for overflow when
5946 computing the width; this is possible now that individual
5947 characters can have unbounded width. Problem introduced
5948 by merge from Emacs 23 on 2012-01-19.
5949
6bee44d6
MA
59502012-02-02 Michael Albinus <michael.albinus@gmx.de>
5951
5952 * dbusbind.c (Fdbus_register_method): Mention the return value
5953 :ignore in the docstring.
5954
44f92739
GM
59552012-02-02 Glenn Morris <rgm@gnu.org>
5956
1b9f60cc
GM
5957 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5958
44f92739
GM
5959 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5960 Unconditionally set to t. (Bug#10673)
5961 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5962 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5963 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5964
c5d3843c
KH
59652012-02-02 Kenichi Handa <handa@m17n.org>
5966
5967 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5968 0, do not call append_composite_glyph.
5969
159462d4 59702012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5971
5972 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5973 NULL (Bug#6988).
5974 (x_produce_glyphs): If the component of a composition is a null
5975 string, set it->pixel_width to 1 to avoid zero-width glyph.
5976
78cef877
EZ
59772012-02-01 Eli Zaretskii <eliz@gnu.org>
5978
5979 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5980 first 2 arguments are identical. This makes inserting large
5981 output from a subprocess an order of magnitude faster on
5982 MS-Windows, where all sbrk'ed memory is always contiguous.
5983
97897668
GM
59842012-01-31 Glenn Morris <rgm@gnu.org>
5985
5986 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5987 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5988 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5989
31fd3586
GM
59902012-01-29 Glenn Morris <rgm@gnu.org>
5991
5992 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5993
0e24a8b2
CY
59942012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5995
5996 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5997
cc0adcb0
CY
59982012-01-28 Chong Yidong <cyd@gnu.org>
5999
6000 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6001
acc28cb9
CY
60022012-01-26 Chong Yidong <cyd@gnu.org>
6003
9c69cfb7
CY
6004 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6005
acc28cb9
CY
6006 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6007 repeat counts (Bug#10507).
6008
48da7392
GM
60092012-01-26 Glenn Morris <rgm@gnu.org>
6010
6011 * lread.c (syms_of_lread): Doc fix.
6012
14af5f7f
CY
60132012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6014
6015 * coding.c (encode_designation_at_bol): Change return value to
6016 EMACS_INT.
6017
0b21c100
CY
60182012-01-25 Chong Yidong <cyd@gnu.org>
6019
6020 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6021
3c2907f7
CY
60222012-01-21 Chong Yidong <cyd@gnu.org>
6023
6024 * floatfns.c (Fcopysign): Make the second argument non-optional,
6025 since nil is not allowed anyway.
6026
959ad23f
AS
60272012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6028
6029 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6030 (send_process): Likewise.
6031
34a02f46
MR
60322012-01-19 Martin Rudalics <rudalics@gmx.at>
6033
6034 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6035 (Vwindow_persistent_parameters): Do not use Qstate.
6036 Rewrite doc-strings.
34a02f46 6037
1259009a 60382012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6039
6040 * character.c (char_width): New function.
70d4fdf6
GM
6041 (Fchar_width, c_string_width, lisp_string_width):
6042 Use char_width (Bug#9496).
25ed9e61 6043
6a6ee00d
MR
60442012-01-16 Martin Rudalics <rudalics@gmx.at>
6045
6046 * window.c (Vwindow_persistent_parameters): New variable.
6047 (Fset_window_configuration, save_window_save): Handle persistent
6048 window parameters.
6049
c85efaf7
EZ
60502012-01-14 Eli Zaretskii <eliz@gnu.org>
6051
6052 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6053 thrashing the stack of the thread. (Bug#9087)
6054
5944709e
PE
60552012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6056
6057 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6058
e71f5d99
EZ
60592012-01-11 Eli Zaretskii <eliz@gnu.org>
6060
6061 * xdisp.c (rows_from_pos_range): Handle the case where the
6062 highlight ends on a newline. (Bug#10464)
6063 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6064 he end column for display of highlight that ends on a newline
6065 before a R2L line.
6066
ce316182
GM
60672012-01-11 Glenn Morris <rgm@gnu.org>
6068
6069 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6070 from load-path also when installation-directory is nil. (Bug#10208)
6071
5b43da69
GM
60722012-01-10 Glenn Morris <rgm@gnu.org>
6073
74cc8ff9
GM
6074 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6075
7d8d6e4e
GM
6076 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6077 Update template values to be closer to their typical values these days.
5b43da69 6078
a0db8d43
EZ
60792012-01-09 Eli Zaretskii <eliz@gnu.org>
6080
6081 * xdisp.c (rows_from_pos_range): Accept additional argument
6082 DISP_STRING, and accept any glyph in a row whose object is that
6083 string as eligible for mouse highlight. Fixes mouse highlight of
6084 display strings from overlays. (Bug#10464)
6085
9a0115ab 60862012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6087
b9110d6a 6088 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6089 * fileio.c (auto_saving_dir_umask): New static var.
6090 (Fmake_directory_internal): Use it.
6091 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6092 creating the directory. The old code temporarily assigns
6093 too-generous permissions to the directory.
6094 (do_auto_save_eh): Clear it.
b9110d6a 6095 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6096 that the var is always cleared.
6097
6c1bd3f3
EZ
60982012-01-07 Eli Zaretskii <eliz@gnu.org>
6099
6100 * search.c (scan_buffer): Pass character positions to
6101 know_region_cache, not byte positions. (Bug#6540)
6102
069d2b50
L
61032012-01-07 LynX <_LynX@bk.ru> (tiny change)
6104
6105 * w32.c (sys_rename): Report EXDEV when rename of a directory
6106 fails because the target is on another logical disk. (Bug#10284)
6107
75bf0d33
DB
61082012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6109
6110 * xterm.c (x_embed_request_focus): New function.
6111
6112 * xterm.h: Add prototype.
6113
6114 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6115
1c6e5a32
GM
61162012-01-05 Glenn Morris <rgm@gnu.org>
6117
6118 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6119
651e947e
EZ
61202012-01-01 Eli Zaretskii <eliz@gnu.org>
6121
6122 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6123 Load gnutls_transport_set_lowat only if GnuTLS version is below
6124 2.11.1.
6125 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6126 GnuTLS versions below 2.11.1.
6127
3778cdd8
AL
61282011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6129
6130 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6131 to the doc string advising against its use for altering the way
6132 windows are scrolled.
6133
0e5317f7
KH
61342011-12-28 Kenichi Handa <handa@m17n.org>
6135
6136 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6137 coding-system ASCII compatible only when it does not produce BOM
6138 on encoding (Bug#10383).
6139
93d5ca1f
JD
61402011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6141
6142 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6143 can scroll.
6144 (create_and_show_popup_menu): Always use menu_position_func for
6145 Gtk3 (Bug#10361).
6146
ca22b785
AS
61472011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6148
6149 * callint.c (Fcall_interactively): Don't truncate prompt string.
6150
d048e1e6
EZ
61512011-12-23 Eli Zaretskii <eliz@gnu.org>
6152
6153 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6154 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6155 resumed from there (after widening). (Bug#10360)
d048e1e6 6156
5ccaba1f
JD
61572011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6158
6159 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6160
204ee57f
JD
61612011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6162
b81d40f0
JB
6163 * nsterm.m (x_free_frame_resources):
6164 Release f->output_data.ns->miniimage.
204ee57f
JD
6165 (ns_index_color): Fix indentation. Do not retain
6166 color_table->colors[i].
6167
6168 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6169 before returning.
6170
6171 * nsfns.m (x_set_background_color): Assign return value from
6172 ns_index_color to face-background instead of NSColor*.
6173 (ns_implicitly_set_icon_type): Fix indentation.
6174 Change assignment in for loop to comparison.
6175
6176 * emacs.c (ns_pool): New variable.
6177 (main): Assign ns_pool.
6178 (Fkill_emacs): Call ns_release_autorelease_pool.
6179
6180 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6181 autorelease fdesc, release fdAttrs and tdict.
6182 (ns_get_covering_families): Release charset.
6183 (ns_findfonts): Release NSFontDescriptor created with new.
6184 (ns_uni_to_glyphs): Fix indentation.
6185 (setString): Release attrStr before assigning new value.
6186
c803b2b7
JD
61872011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6188
678f4426
JD
6189 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6190 and NS_IMPL_COCOA.
6191 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6192 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6193
cd394be1 61942011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6195
5fecd5fc
JD
6196 * nsterm.m (ns_term_init): Subscribe for notifications
6197 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6198 to method trackingNotification in EmacsMenu.
6199
6200 * nsmenu.m (trackingMenu): New variable.
3771cb17 6201 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6202 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6203 from Aquamacs (Bug#7030).
678f4426
JD
6204
62052011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6206
c803b2b7
JD
6207 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6208 (symbol_to_nsstring): Fix indentation.
6209 (ns_symbol_to_pb): New function.
cae07000
SM
6210 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6211 (Fns_rotate_cut_buffers_internal): Remove.
6212 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6213 Fns_store_cut_buffer_internal.
6214 (ns_get_foreign_selection, Fx_own_selection_internal)
6215 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6216 (Fns_get_selection_internal, Fns_store_selection_internal):
6217 Use ns_symbol_to_pb and check if return value is nil.
6218 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6219 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6220 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6221 renamed to Sns_store_selection_internal.
6222 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6223 and remove this function.
6224 (ns_handle_selection_clear): Remove, never used.
6225 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6226 here.
6227
e1b01a3a
KB
62282011-12-17 Ken Brown <kbrown@cornell.edu>
6229
6230 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6231 GID is unknown (Bug#10257).
6232
2adb6e85
PE
62332011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6234
6235 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6236 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6237 which caused a build failure on GNU/Linux IA-64. This problem was
6238 introduced by my 2011-10-07 patch.
6239
d1d7b339
JL
62402011-12-15 Juri Linkov <juri@jurta.org>
6241
6242 * image.c (imagemagick_error): New function. (Bug#10112)
6243 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6244 Use `imagemagick_error' where ImageMagick functions return
6245 `MagickFalse'.
6246 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6247 proper order.
6248
100d5755
KH
62492011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6250
6251 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6252 fill background (Bug#8992).
6253
454592a6
MR
62542011-12-13 Martin Rudalics <rudalics@gmx.at>
6255
6256 * window.c (Vwindow_combination_resize)
6257 (Vwindow_combination_limit): Use t instead of non-nil in
6258 doc-strings.
61d4b438
MR
6259 (Vrecenter_redisplay): Add first sentence of doc-string on
6260 separate line.
53524d93 6261 (Frecenter): Fix doc-string typo.
454592a6 6262
3633e3aa
KH
62632011-12-11 Kenichi Handa <handa@m17n.org>
6264
6265 * coding.c (Funencodable_char_position): Pay attention to the
6266 buffer text relocation (Bug#9389).
6267
7b9d523a 62682011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6269
7b9d523a
JD
6270 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6271 gtk_init (Bug#10100).
6272
b73189c6
EZ
62732011-12-10 Eli Zaretskii <eliz@gnu.org>
6274
6275 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6276 IT->string is nil. (Bug#10263)
6277
f7dfe5d6
JD
62782011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6279
83faebb4
JD
6280 * nsterm.h (x_free_frame_resources): Declare.
6281
f7dfe5d6
JD
6282 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6283 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6284
6285 * nsterm.h (ns_get_defaults_value): Declare.
6286
6287 * nsterm.m (ns_default): Call ns_get_defaults_value.
6288
7cd4e72c
EZ
62892011-12-09 Eli Zaretskii <eliz@gnu.org>
6290
6291 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6292 (Bug#10170)
6293
b34d7317
YM
62942011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6295
6296 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6297 that where the value of an _OBJC_* symbol points to is in the .bss
6298 section (Bug#10240).
6299
76470ad1
KH
63002011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6301
6302 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6303 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6304
745fff94
KH
63052011-12-08 Kenichi Handa <handa@m17n.org>
6306
6307 * ftfont.c (get_adstyle_property): Fix previous change
6308 (Bug#10233).
6309
6e44397c
JB
63102011-12-07 Juanma Barranquero <lekktu@gmail.com>
6311
6312 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6313 dirs from the default value of EMACSLOADPATH (bug#10208).
6314
7efa6272
GM
63152011-12-07 Glenn Morris <rgm@gnu.org>
6316
6317 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6318 installation and source directories as well. (Bug#10208)
6319
f6fc4d87
CY
63202011-12-06 Chong Yidong <cyd@gnu.org>
6321
6322 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6323
2bf26180
GM
63242011-12-06 Glenn Morris <rgm@gnu.org>
6325
6326 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6327 as an error, not just -1. (Bug#10217)
6328
3a6ad4f0
CY
63292011-12-05 Chong Yidong <cyd@gnu.org>
6330
6331 * keyboard.c (process_special_events): New function.
6332 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6333
75a3b399
PE
63342011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6335
6336 * coding.c (encode_designation_at_bol): Don't use uninitialized
6337 local variable (Bug#9318).
6338
c3c9e25e
KH
63392011-12-05 Kenichi Handa <handa@m17n.org>
6340
6341 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6342 return Qnil (Bug#8046, Bug#10193).
6343
5eb05ea3
KH
63442011-12-05 Kenichi Handa <handa@m17n.org>
6345
6346 * coding.c (encode_designation_at_bol): New args charbuf_end and
6347 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6348 (coding_set_source): Return how many bytes coding->source was
6349 relocated.
6350 (coding_set_destination): Return how many bytes
6351 coding->destination was relocated.
6352 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6353 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6354
63552011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6356
6357 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6358 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6359 macro (Bug#9318).
6360
63612011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6362
6363 The following changes are to fix Bug#9318.
6364
a79703f5 6365 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6366 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6367 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6368 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6369
7dbda6df
JB
63702011-12-05 Juanma Barranquero <lekktu@gmail.com>
6371
6372 * lisp.h (process_quit_flag): Fix external declaration.
6373
6d5eb5b0
SM
63742011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6375
6376 Don't macro-inline non-performance-critical code.
6377 * eval.c (process_quit_flag): New function.
6378 * lisp.h (QUIT): Use it.
6379
a0c3fad0
JD
63802011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6381
6382 * nsfns.m (get_geometry_from_preferences): New function.
6383 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6384
6c07aac2
AS
63852011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6386
6387 * emacs.c (Qkill_emacs): Define.
6388 (syms_of_emacs): Initialize it.
6389 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6390 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6391 (quit_throw_to_read_char): Add parameter `from_signal'.
6392 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6393 * lisp.h (QUIT): Call Fkill_emacs if requested.
6394
c052ead4
JD
63952011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6396
6397 * widget.c (update_wm_hints): Return if wmshell is null.
6398 (widget_update_wm_size_hints): New function.
6399
6400 * widget.h (widget_update_wm_size_hints): Declare.
6401
6402 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6403 widget_update_wm_size_hints (Bug#10104).
6404
9e49252b
EZ
64052011-12-03 Eli Zaretskii <eliz@gnu.org>
6406
6407 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6408 before a newline, prepare the bidi iterator for consuming the
6409 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6410 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6411
02b16839
JL
64122011-12-02 Juri Linkov <juri@jurta.org>
6413
6414 * search.c (Fword_search_regexp): New Lisp function created from
6415 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6416 (Fword_search_backward, Fword_search_forward)
6417 (Fword_search_backward_lax, Fword_search_forward_lax):
6418 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6419 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6420
0068070e
SM
64212011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6422
6423 * fileio.c (Finsert_file_contents): Move after-change-function call
6424 to before the "handled:" label, since all "goto handled" appear in
6425 cases where the *-change-functions have already been properly called
6426 (bug#10117).
6427
3360a3fc
AS
64282011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6429
6430 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6431 waiting for input. (Bug#10169)
6432
73d6c093
EZ
64332011-11-30 Eli Zaretskii <eliz@gnu.org>
6434
6435 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6436 verifies glyph row's hash code--we have just reallocated the
6437 glyphs, so their contents can be complete garbage. (Bug#10164)
6438
febe6bea
JB
64392011-11-30 Juanma Barranquero <lekktu@gmail.com>
6440
6441 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6442
801a4313
EZ
64432011-11-30 Eli Zaretskii <eliz@gnu.org>
6444
6445 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6446 attributes are tested _before_ calling verify_row_hash, to protect
6447 against GCC re-ordering of the tests. (Bug#10164)
6448
2b56b87e
JD
64492011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6450
6451 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6452
6453 * xterm.c (handle_one_xevent): Only set async_visible and friends
6454 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6455 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6456 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6457
dbf31225
PE
64582011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6459
6460 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6461 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6462 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6463 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6464 All uses changed to use GCPRO1 etc.
6465 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6466 Revert to old implementation (i.e., before 2011-03-11).
6467
1305621b
YM
64682011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6469
6470 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6471 of scroll runs so as to avoid assigning disabled bogus rows and
6472 unnecessary graphics copy operations.
6473
8c9afb46
EZ
64742011-11-27 Eli Zaretskii <eliz@gnu.org>
6475
6476 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6477 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6478 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6479 (malloc, free, realloc, calloc): Redirect to e_* only when
6480 compiling Emacs.
6481
6482 * lisp.h (GCTYPEBITS): Move before first use.
6483 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6484 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6485 this macro definition.
6486
6487 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6488 _MSC_VER.
6489
54e9e3bf
JD
64902011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6491
6d5eb5b0
SM
6492 * gtkutil.c (xg_create_frame_widgets):
6493 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6494 present with Gtk+ 2.0.
6495
83aca1cb
PE
64962011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6497
6498 * fileio.c (Finsert_file_contents): Undo previous change; see
6499 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6500
5b76caa4
PE
65012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6502
6503 Rename locals to avoid shadowing.
6504 * fileio.c (Finsert_file_contents):
6505 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6506 * process.c (wait_reading_process_output):
6507 Rename inner 'proc' to 'p' to avoid shadowing.
6508 Indent for consistency with usual Emacs style.
6509
8c535114
EZ
65102011-11-25 Eli Zaretskii <eliz@gnu.org>
6511
6512 * xdisp.c (redisplay_window): If cursor row is not fully visible
6513 after recentering, and scroll-conservatively is set to a large
6514 number, scroll window by a few more lines to make the cursor fully
6515 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6516 (start_display): Don't move to the next line if the display should
6517 start at a newline that is part of a display vector or an overlay
6518 string. (Bug#10119)
8c535114 6519
fa4fdb5c
JL
65202011-11-24 Juri Linkov <juri@jurta.org>
6521
6522 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6523 after the `MagickPingImage' call. (Bug#10112)
6524
90ec88df
CY
65252011-11-23 Chong Yidong <cyd@gnu.org>
6526
6527 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6528
56e2e794
MR
65292011-11-23 Martin Rudalics <rudalics@gmx.at>
6530
6531 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6532 making another buffer current. (Bug#10114)
6533
b6e64c41
GM
65342011-11-23 Glenn Morris <rgm@gnu.org>
6535
6536 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6537
6b21de18
CY
65382011-11-23 Chong Yidong <cyd@gnu.org>
6539
6540 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6541 using it (Bug#5984).
6542
b12cd789
EZ
65432011-11-22 Eli Zaretskii <eliz@gnu.org>
6544
6545 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6546 and header-lines, as they don't have one computed for them.
6547 (Bug#10098)
6548
6549 * .gdbinit (prow): Make displayed values more self-explaining.
6550 Add row's hash code.
6551
261b6fd4
LMI
65522011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6553
6554 * process.c (wait_reading_process_output): Fix asynchrounous
6555 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6556 (wait_reading_process_output): Add comment and URL.
261b6fd4 6557
e7cfd277
JD
65582011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6559
6560 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6561
a9b9b7f5
CY
65622011-11-21 Chong Yidong <cyd@gnu.org>
6563
6564 * window.c (Fnext_window, Fprevious_window): Doc fix.
6565
b0d15b4f
SM
65662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6567
6568 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6569
fe7a3057
JB
65702011-11-20 Juanma Barranquero <lekktu@gmail.com>
6571
6572 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6573
d2999b1a
MR
65742011-11-20 Martin Rudalics <rudalics@gmx.at>
6575
6576 * window.c (Fset_window_combination_limit): Rename argument
6577 STATUS to LIMIT.
6578 (Vwindow_combination_limit): Remove "status" from doc-string.
6579
d5ff9cd0
AS
65802011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6581
6582 * m/ibms390.h: Remove.
6583 * m/ibms390x.h: Don't include "ibms390.h".
6584
a5bb9bd3
SM
65852011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6586
6587 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6588 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6589
cd1181db
JB
65902011-11-20 Juanma Barranquero <lekktu@gmail.com>
6591
6592 * casetab.c (Fset_case_table):
6593 * charset.c (Fcharset_after): Fix typos.
6594
615a3b8d 65952011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6596
17e845af
PE
6597 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6598 Otherwise, valgrind does not work on some platforms.
6599 Problem reported by Andreas Schwab in
6a0bf43d
PE
6600 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6601 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6602 is set, removing the need for VIRT_ADDRESS_VARIES.
6603 (PURE_P): Use a more-efficient implementation that needs just one
6604 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6605 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6606 to 4 (xorl, subq, cmpq, setbe).
6607 * alloc.c (pure): Always extern now, since that's the
6608 VIRT_ADDR_VARIES behavior.
6609 (PURE_POINTER_P): Use a single comparison, not two, for
6610 consistency with the new puresize.h.
6611 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6612 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6613 Remove VIRT_ADDR_VARIES no longer needed.
6614
f8fe6f96
EZ
66152011-11-19 Eli Zaretskii <eliz@gnu.org>
6616
6617 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6618 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6619 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6620 behave as if the cursor position were at the window margin.
6621
6622 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6623 and the cursor position is out of bounds, behave as if the cursor
6624 position were at the window margin. (Bug#10075)
6625
df05a53c
CY
66262011-11-18 Chong Yidong <cyd@gnu.org>
6627
6628 * window.c (Fwindow_combination_limit): Make first argument
6629 non-optional, since it is meaningless for live windows like the
6630 selected window.
61ccba97 6631
2071918e
DA
66322011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6633
6634 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6635
b50a28de
SM
66362011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6637
6638 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6639 (graft_intervals_into_buffer): Simplify.
6640
015137db
EZ
66412011-11-18 Eli Zaretskii <eliz@gnu.org>
6642
6643 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6644 hash values of the two rows.
6645 (copy_row_except_pointers): Preserve the used[] arrays and the
6646 hash values of the two rows. (Bug#10035)
68c95424 6647 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6648
6649 * xdisp.c (row_hash): New function, body extracted from
6650 compute_line_metrics.
6651 (compute_line_metrics): Call row_hash, instead of computing the
6652 hash code inline.
6653
6654 * dispnew.c (verify_row_hash): Call row_hash for computing the
6655 hash code of a row, instead of duplicating code from xdisp.c.
6656
6657 * dispextern.h (row_hash): Add prototype.
6658
a2addb04
TH
66592011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6660
6661 * frame.c (delete_frame): Don't delete the terminal when the last
6662 X frame is closed if emacs is built with GTK toolkit.
6663
df85d315
JB
66642011-11-17 Juanma Barranquero <lekktu@gmail.com>
6665
6666 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6667
a0c2d0ae
MR
66682011-11-17 Martin Rudalics <rudalics@gmx.at>
6669
6670 * window.c (Vwindow_splits): Rename to
6671 Vwindow_combination_resize. Suggested by Juri Linkov.
6672 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6673 of Vwindow_splits.
6674
58179cce
JB
66752011-11-16 Juanma Barranquero <lekktu@gmail.com>
6676
7877f373
JB
6677 * nsfns.m (Fns_font_name):
6678 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6679
b6f67890
MR
66802011-11-16 Martin Rudalics <rudalics@gmx.at>
6681
6682 * window.h (window): Rename slot "nest" to "combination_limit".
6683 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6684 (Fset_window_nest): Rename to Fset_window_combination_limit.
6685 (Vwindow_nest): Rename to Vwindow_combination_limit.
6686 (recombine_windows, make_parent_window, make_window)
6687 (Fsplit_window_internal, saved_window)
6688 (Fset_window_configuration, save_window_save): Rename all
6689 occurrences of window_nest to window_combination_limit.
6690
c7015153
JB
66912011-11-15 Juanma Barranquero <lekktu@gmail.com>
6692
6693 * image.c (imagemagick_load_image): Fix typo.
6694
322ad6ec
EZ
66952011-11-14 Eli Zaretskii <eliz@gnu.org>
6696
6697 * xdisp.c (display_line): Move the call to
6698 highlight_trailing_whitespace before the call to
6699 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6700 faces of all the glyphs to compute ROW's hash value.
6701 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6702
f067b8ec
JB
67032011-11-14 Juanma Barranquero <lekktu@gmail.com>
6704
6705 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6706 just return (bug#10044).
6707
1e5b2111
EZ
67082011-11-12 Eli Zaretskii <eliz@gnu.org>
6709
7ef3cbd5
EZ
6710 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6711 with user-defined heap size. Bump the default size of the temacs
6712 heap to 27MB, to avoid memory warning when running temacs.
6713 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6714
1e5b2111
EZ
6715 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6716 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6717 (verify_row_hash) [XASSERTS]: New function.
6718 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6719 that the hash value of glyph rows is correct.
1e5b2111 6720
89d61221
MR
67212011-11-12 Martin Rudalics <rudalics@gmx.at>
6722
6723 * window.h (window): Remove splits slot.
6724 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6725 (Fdelete_other_windows_internal, make_parent_window)
6726 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6727 (Fset_window_configuration, save_window_save): Don't deal with
6728 split status of windows.
6729 (saved_window): Remove splits slot.
6730 (Vwindow_splits): Rewrite doc-string.
6731
97f18cc8
JD
67322011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6733
6734 * xfns.c (unwind_create_frame):
6735 * nsfns.m (unwind_create_frame):
6736 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6737 Vframe_list (Bug#9999).
6738
22a648b4
DA
67392011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6740
0b381c7e 6741 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6742
659afede
KH
67432011-11-11 Kenichi Handa <handa@m17n.org>
6744
6745 * callproc.c (Fcall_process): Set the member dst_multibyte of
6746 process_coding.
6747
9ac0394b
KH
67482011-11-11 Johan Bockgård <bojohan@gnu.org>
6749
6750 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6751 avoid a crash (bug#9496).
6752
2fbdc249
CY
67532011-11-09 Chong Yidong <cyd@gnu.org>
6754
6755 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6756 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6757
ac6b1f81
PE
67582011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6759
6760 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6761
09db192c
PE
67622011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6763
6764 Avoid some portability problems by eschewing 'extern inline' functions.
6765 The trivial performance wins aren't worth the portability hassles; see
6766 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6767 et seq.
6768 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6769 (window_box_width, window_box_left, window_box_left_offset)
6770 (window_box_right, window_box_right_offset): Undo previous change,
6771 by removing the "extern"s.
6772 * intervals.c (adjust_intervals_for_insertion)
6773 (adjust_intervals_for_deletion): Undo previous change,
6774 making these static again.
6775 (offset_intervals, temp_set_point_both, temp_set_point)
6776 (copy_intervals_to_string): No longer inline.
6777 * xdisp.c (window_text_bottom_y, window_box_width)
6778 (window_box_height, window_box_left_offset)
6779 (window_box_right_offset, window_box_left, window_box_right)
6780 (window_box): No longer inline.
6781
105216ed
CY
67822011-11-08 Chong Yidong <cyd@gnu.org>
6783
6784 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6785 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6786 Signal an error if not a live window.
105216ed
CY
6787 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6788 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6789
ae9e237f
JB
67902011-11-07 Juanma Barranquero <lekktu@gmail.com>
6791
6792 * lisp.h (syms_of_abbrev): Remove declaration.
6793 Reported by CHENG Gao <chenggao@royau.me>.
6794
c7aa8333
EZ
67952011-11-07 Eli Zaretskii <eliz@gnu.org>
6796
6797 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6798 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6799 of temacs in GUI mode.
6800
be7f5545
MR
68012011-11-07 Martin Rudalics <rudalics@gmx.at>
6802
6803 * window.h: Declare delete_all_child_windows instead of
6804 delete_all_subwindows.
6805 * window.c (Fwindow_nest, Fset_window_nest)
6806 (Fset_window_new_total, Fset_window_new_normal)
6807 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6808 (delete_all_subwindows): Rename to delete_all_child_windows.
6809 (Fdelete_other_windows_internal, Fset_window_configuration):
6810 Call delete_all_child_windows instead of delete_all_subwindows.
6811 * frame.c (delete_frame): Call delete_all_child_windows instead
6812 of delete_all_subwindows.
6813
ca78dc43
PE
68142011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6815
6816 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6817 This is also needed for porting to any host where GC_MARK_STACK is
6818 not GC_MAKE_GCPROS_NOOPS.
6819 (which_symbols): Use it.
6820
a0241d01
KH
68212011-11-07 Kenichi Handa <handa@m17n.org>
6822
6823 * coding.c (coding_set_destination): Check coding->src_pos only
6824 when coding->src_object is a buffer (bug#9910).
6825
6826 * process.c (send_process): Set the member src_multibyte of coding
6827 to 0 (bug#9911) when sending a unibyte text.
6828
6829 * callproc.c (Fcall_process): Set the member src_multibyte of
6830 process_coding to 0 (bug#9912).
6831
a64bfdfa 68322011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6833
6834 * xmenu.c (cleanup_widget_value_tree): New function.
6835 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6836 calling free_menubar_widget_value_tree directly (Bug#9830).
6837
cb41b32a
PE
68382011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6839
6840 Fix some portability problems with 'inline'.
6841 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6842 (window_box_width, window_box_left, window_box_left_offset)
6843 (window_box_right, window_box_right_offset): Declare extern.
6844 Otherwise, these inline functions do not conform to C99 and
6845 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6846 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6847 * intervals.c (adjust_intervals_for_insertion)
6848 (adjust_intervals_for_deletion): Now extern, because otherwise the
6849 extern inline functions 'offset_intervals' couldn't refer to it.
6850 (static_offset_intervals): Remove.
6851 (offset_intervals): Rewrite using the old contents of
6852 static_offset_intervals. The old version didn't conform to C99
6853 because an extern inline function contained a reference to an
6854 identifier with static linkage.
6855
b7041366
AS
68562011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6857
6858 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6859 GC.
6860
88a37c4d
EZ
68612011-11-06 Eli Zaretskii <eliz@gnu.org>
6862
6863 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6864 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6865 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6866 return Qleft_to_right.
6867
49745b39
CY
68682011-11-06 Chong Yidong <cyd@gnu.org>
6869
6870 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6871 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6872 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6873 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6874 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6875 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6876 (Fwindow_vscroll): Doc fix.
6877 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6878 argument, since it makes no sense to pass a live window and for
6879 consistency with window-child.
6880
1f05cd82
CS
68812011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6882
6883 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6884 support MSVC.
6885
22610910
JR
68862011-11-05 Jason Rumney <jasonr@gnu.org>
6887
6888 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6889 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6890 fonts (Bug#6029).
6891 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6892 bitwise arithmetic preventing use of unicode-sip and non-truetype
6893 opentype fonts.
6894
a06776b2
EZ
68952011-11-05 Eli Zaretskii <eliz@gnu.org>
6896
3ad924ba
EZ
6897 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6898 "emacs"-only part.
6899
a06776b2
EZ
6900 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6901 initialization code to keep similarity to xfns.c after changes
6902 from 2011-11-05.
6903
c9e7db78
JD
69042011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6905
a97f8f3f
JD
6906 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6907 (unwind_create_frame): New function (Bug#9943).
6908 (Fx_create_frame): Restructure code to be more similar to the one in
6909 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6910 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6911 Move terminal->reference_count++ just before making the frame official
6912 (Bug#9943).
6913
6914 * nsterm.m (x_free_frame_resources): New function.
6915 (x_destroy_window): Move code to x_free_frame_resources.
6916
c9e7db78 6917 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6918 (Fx_create_frame, x_create_tip_frame):
6919 Move terminal->reference_count++ just before making the frame
75f1671a 6920 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6921 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6922
a6fc3b5c
EZ
69232011-11-05 Eli Zaretskii <eliz@gnu.org>
6924
6925 Support MSVC build with newer versions of Visual Studio.
6926 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6927 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6928 nt/gmake.defs.
6929
6930 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6931 which are not supported by MSVC.
6932 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6933 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6934 bitfields.
6935 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6936 types in bitfields.
6937 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6938
6939 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6940
58179cce 69412011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6942
6943 Support MSVC build with newer versions of Visual Studio.
6944 * w32.c: Don't include w32api.h for MSVC.
6945 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6946
6947 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6948 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6949 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6950 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6951 e_* cousins.
6952 (alloca) [_MSC_VER]: Define to _alloca.
6953
6954 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6955
6956 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6957
a58c13ed
EZ
69582011-11-04 Eli Zaretskii <eliz@gnu.org>
6959
6960 * xdisp.c (note_mouse_highlight): If either of
6961 previous/next-single-property-change returns nil, treat that as
6962 the beginning or the end of the buffer. (Bug#9955)
6963
fe0b6370
JD
69642011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6965
a58c13ed 6966 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6967 label is not null (Bug#9951).
6968 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6969 may be NULL.
6970
89bd5ee1
EZ
69712011-11-04 Eli Zaretskii <eliz@gnu.org>
6972
6973 * window.c (Fwindow_body_size): Mention in the doc string that the
6974 return value is in frame's canonical units. (Bug#9949)
6975
84c3edb9
EZ
69762011-11-03 Eli Zaretskii <eliz@gnu.org>
6977
4e2fb5c7
EZ
6978 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6979
84c3edb9 6980 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6981 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6982 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6983
bc17a887
EZ
69842011-11-01 Eli Zaretskii <eliz@gnu.org>
6985
6986 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6987 Don't stop backward scan on the continuation glyph, even though
6988 its CHARPOS is positive.
6d5eb5b0
SM
6989 (mouse_face_from_buffer_pos, note_mouse_highlight):
6990 Rename cover_string to disp_string.
bc17a887 6991
4ee88440
MR
69922011-11-01 Martin Rudalics <rudalics@gmx.at>
6993
6994 * window.c (temp_output_buffer_show): Don't use
6995 Vtemp_buffer_show_specifiers.
6996 (Vtemp_buffer_show_specifiers): Remove unused variable.
6997
c2ff3c02
EZ
69982011-10-30 Eli Zaretskii <eliz@gnu.org>
6999
7000 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7001 past the beginning of the current glyph matrix.
7002
58179cce 70032011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7004
7005 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7006 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7007 HAVE_GTK3 (Bug#9869).
b77a6a7f 7008
3b574623
JD
7009 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7010 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7011
b77a6a7f
JD
7012 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7013
7014 * xterm.c: Declare x_handle_net_wm_state to return int.
7015 (handle_one_xevent): Check if we are iconified but don't have
7016 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7017 (get_current_wm_state): Return non-zero if not hidden,
7018 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7019 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7020 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7021 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7022
196e41e4
PE
70232011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7024
7025 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7026 so that this new function doesn't get optimized away by a
7027 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7028
021f2e1a
AS
70292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7030
7031 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7032
8b058d44
EZ
70332011-10-29 Eli Zaretskii <eliz@gnu.org>
7034
7035 Fix the `xbytecode' command.
7036 * .gdbinit (xprintbytestr): New command.
b50a28de 7037 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7038 (xbytecode): Print the byte-code string as well.
7039
4452fb80
EZ
70402011-10-29 Kim Storm <storm@cua.dk>
7041
8b058d44
EZ
7042 * alloc.c (which_symbols): New function.
7043
21b72067
AS
70442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7045
7046 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7047 line. (Bug#9903)
7048
83ed7b5c
GM
70492011-10-29 Glenn Morris <rgm@gnu.org>
7050
7051 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7052 Not clear what it was for, and it causes various bugs. (Bug#9839)
7053
5a7a728b
EZ
70542011-10-28 Eli Zaretskii <eliz@gnu.org>
7055
7056 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7057 possible random value that matches one of those tested as
7058 condition to clear the mouse face.
7059
d3d0842f
CY
70602011-10-28 Chong Yidong <cyd@gnu.org>
7061
7062 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7063
31b39d13
DN
70642011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7065
7066 * window.c (make_window): Initialize phys_cursor_on_p.
7067
9aba6043
SM
70682011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7069
7070 * lisp.h (struct Lisp_Symbol): Update comments.
7071
c20992f4
JB
70722011-10-28 Juanma Barranquero <lekktu@gmail.com>
7073
7074 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7075
db4f02f2
EZ
70762011-10-28 Eli Zaretskii <eliz@gnu.org>
7077
7078 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7079 <oslsachem@gmail.com> for helping to debug this.
7080
7081 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7082 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7083 (g_b_init_get_glyph_outline_w): New static variables.
7084 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7085 (GetGlyphOutlineW_Proc): New typedefs.
7086 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7087 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7088 New functions.
7089 (w32font_open_internal, compute_metrics):
7090 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7091 instead of calling the "wide" APIs directly.
7092
7093 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7094
7095 * w32.h (syms_of_w32font): Add prototype.
7096
87e68db4
JB
70972011-10-27 Juanma Barranquero <lekktu@gmail.com>
7098
7099 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7100 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7101 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7102 (Fmove_to_window_line): Doc fix.
7103
435c1d67
CY
71042011-10-27 Chong Yidong <cyd@gnu.org>
7105
7106 * process.c (make_process): Set gnutls_state to NULL.
7107
7108 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7109 non-NULL, regardless of GNUTLS_INITSTAGE.
7110 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7111 an error. Set process slots as soon as we allocate them.
7112
7113 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7114
9c6c6f49
CY
71152011-10-27 Chong Yidong <cyd@gnu.org>
7116
9aba6043
SM
7117 * gnutls.c (emacs_gnutls_deinit): New function.
7118 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7119 (Fgnutls_deinit, Fgnutls_boot): Use it.
7120
7121 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7122 (deactivate_process): Call emacs_gnutls_deinit.
7123
657d08d3
JB
71242011-10-27 Juanma Barranquero <lekktu@gmail.com>
7125
7126 * image.c (x_create_x_image_and_pixmap):
7127 * w32.c (sys_rename, w32_delayed_load):
7128 * w32font.c (fill_in_logfont):
7129 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7130
5430d399
JB
71312011-10-26 Juanma Barranquero <lekktu@gmail.com>
7132
7133 * w32fns.c (w32_default_color_map): New function,
7134 extracted from Fw32_default_color_map.
a7ef684b 7135 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7136
fe0055fa
PE
71372011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7138
7139 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7140
e6346438
SM
71412011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7142
7143 * keyboard.c (test_undefined): New function (bug#9751).
7144 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7145
e112cc37
ET
71462011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7147
7148 * sysdep.c (init_sys_modes): Fix the check for the controlling
7149 terminal (Bug#6649).
7150
7b5d6677
EZ
71512011-10-20 Eli Zaretskii <eliz@gnu.org>
7152
7153 * dispextern.h (struct bidi_it): New member next_en_type.
7154
7155 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7156 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7157 current character, check also for next_en_type being WEAK_EN.
7158 (bidi_resolve_weak): Don't enter the expensive loop if the current
7159 position is before next_en_pos. Record the bidi type of the first
7160 non-ET, non-BN character we find, in addition to its position.
7161 (bidi_level_of_next_char): Invalidate next_en_type when
7162 next_en_pos is over-stepped.
7163
7da0b018
PE
71642011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7165
7166 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7167 * editfns.c: Rewrite current-time-zone so that it invokes
7168 the equivalent of (format-time-string "%Z") to get the time zone name.
7169 This fixes a bug when the time zone name contains characters that
7170 need converting from the system time locale to Emacs internal format.
7171 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7172 that patch fixed format-time-string to do the conversion, but
7173 I forgot to fix current-time-zone.
7174 (format_time_string): New function, containing most of
7175 what Fformat_time_string used to contain.
7176 (Fformat_time_string): Rewrite in terms of format_time_string.
7177 This doesn't change this function's behavior.
7178 (current-time-zone): Rewrite to use format_time_string.
7179 This fixes the bug reported by Michael Schierl in
7180 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7181 Jason Rumney's 2007-06-07 change worked around this bug, but
7182 didn't fix it.
7183 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7184
8547b010
EZ
71852011-10-19 Eli Zaretskii <eliz@gnu.org>
7186
7187 * xdisp.c (start_display): If the character at POS is displayed
7188 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7189 (try_window_reusing_current_matrix): If a line ends in a display
7190 vector or the next line starts in a display vector, continue
7191 redrawing the window even though the character position of
7192 start_row was reached.
8547b010
EZ
7193 (Bug#9771, part 2)
7194
4e948d15
CY
71952011-10-18 Chong Yidong <cyd@gnu.org>
7196
7197 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7198 with nobreak-char-display too.
7199
4787455f
EZ
72002011-10-18 Eli Zaretskii <eliz@gnu.org>
7201
7202 Fix part 3 of bug#9771.
7203 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7204 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7205 non-neutral characters if the current character is a paragraph
7206 separator (a.k.a. Newline). This avoids running the same
7207 expensive loop twice, once when we consume the preceding newline
7208 and the other time when the line actually needs to be displayed.
7209 Avoid the loop when we see neutrals on the base embedding level
7210 following a character whose directionality is the same as the
7211 paragraph's. This avoids running the expensive loop when a line
7212 ends in a long sequence of neutrals, like control characters.
7213 Add assertion against STRONG_AL type. Slightly rearrange code
7214 that determines the type of a neutral given the first non-neutral
7215 that follows it.
7216 (bidi_level_of_next_char): Set next_en_pos to zero when
7217 invalidating its info.
7218
2c91f553
EZ
72192011-10-17 Eli Zaretskii <eliz@gnu.org>
7220
7221 * xdisp.c (push_display_prop): Determine whether to record string
7222 or buffer position by IT->string, not by IT->method. Allow
7223 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7224 (move_it_vertically_backward): Don't look for character position
7225 immediately after the newline when in a continuation line.
7226 (Bug#9771, part 1)
2c91f553 7227
c7b08b0d
MR
72282011-10-15 Martin Rudalics <rudalics@gmx.at>
7229
7230 * window.c (coordinates_in_window): Rewrite and delabelize
7231 vertical border check. (Bug#5357) (Bug#9618)
7232
6b02f655
SM
72332011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7234
7235 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7236 errors in XSetWindowBorder (bug#9310).
7237
81d40c92
DA
72382011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7239
7240 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7241 avoid crash when xmalloc overrun checking is enabled.
7242
d4172c3b
EZ
72432011-10-13 Eli Zaretskii <eliz@gnu.org>
7244
7245 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7246 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7247 cursor motion with <left> and <right> arrow keys.
7248
7249 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7250 some callers set that themselves.
7251
b00eea75
EZ
72522011-10-12 Eli Zaretskii <eliz@gnu.org>
7253
7254 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7255 display string and the previous row comes from the same string and
7256 is empty. (Bug#9739) (Bug#9738)
7257
8fe012c4
SM
72582011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7259
7260 * doc.c (get_doc_string): Encode file name (bug#9735).
7261
0074aef2
EZ
72622011-10-12 Eli Zaretskii <eliz@gnu.org>
7263
79beb178
EZ
7264 * bidi.c (bidi_level_of_next_char):
7265 * xdisp.c (get_visually_first_element): Remove old incorrect
7266 comments regarding the Unicode Line Separator character.
7267
0074aef2
EZ
7268 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7269
6e4b3fbe
DA
72702011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7271
7272 * alloc.c (Fgc_status): Do not access beyond zombies array
7273 boundary if nzombies > MAX_ZOMBIES.
7274 * alloc.c (dump_zombies): Add missing format specifier.
7275
0324f3af
PE
72762011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7277
b5525cac
PE
7278 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7279 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7280
0324f3af
PE
7281 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7282 Some packages use them to denote characters with modifiers.
7283
e9b5f888
AS
72842011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7285
7286 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7287 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7288 matching a pp-number. Rename parameter var to var1.
7289
127827c0
SM
72902011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7291
7292 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7293
c8fd3bd0
GM
72942011-10-08 Glenn Morris <rgm@gnu.org>
7295
7296 * callint.c (Fcall_interactively): Give a more explicit error for the
7297 'c' case with a non-character input. (Bug#8479)
7298
352ec8ff
EZ
72992011-10-08 Eli Zaretskii <eliz@gnu.org>
7300
03669ccb
EZ
7301 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7302 lines.
7061c986
EZ
7303 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7304 lines that are hscrolled on the left.
03669ccb 7305
352ec8ff
EZ
7306 * dispnew.c (buffer_posn_from_coords): Account for a possible
7307 presence of header-line. (Bug#4426)
7308
a66cfb1c
SM
73092011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7310
6b02f655
SM
7311 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7312 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7313
7c5ee88e
PE
73142011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7315
7316 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7317 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7318 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7319 this makes Emacs dump core during garbage collection on rare
7320 occasions. sizeof is obviously inferior to offsetof here, so
7321 stick with offsetof.
7322 (GC_POINTER_ALIGNMENT): New macro.
7323 (mark_memory): Omit 3rd (offset) arg; caller changed.
7324 Don't assume EMACS_INT alignment is the same as pointer alignment.
7325
df1bbe5b
SM
73262011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7327
7328 * keyboard.c (read_key_sequence_remapped): New var.
7329 (read_key_sequence): Compute remapping in the right buffer.
7330 (command_loop_1): Use read_key_sequence's remapping directly.
7331
51553db6
SM
73322011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7333
32c1fffd
SM
7334 * dired.c (file_name_completion): Don't expand file name.
7335 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7336 before checking file name handler.
7337
51553db6
SM
7338 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7339 they've been requested explicitly (bug#9591).
7340
b6bd1599 73412011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7342
7343 * keymap.c (Fsingle_key_description): Use make_specified_string
7344 instead of build_string to build string from push_key_description.
7345 (Bug#5193)
7346
f701dc2a
PE
73472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7348
4222c55d
PE
7349 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7350 This fixes a Y2038 bug on 64-bit hosts.
7351 * buffer.c (reset_buffer):
7352 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7353 (Fclear_buffer_auto_save_failure):
7354 Use 0, not -1, to represent an unset failure time, since time_t
7355 might not be signed.
7356
f701dc2a
PE
7357 Remove dependency on glibc malloc internals.
7358 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7359 Move back here from lisp.h, but with their new implementations.
7360 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7361 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7362 * charset.c (charset_table_init): New static var.
7363 (syms_of_charset): Use it instead of xmalloc. This removes a
7364 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7365 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7366 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7367 Move back to alloc.c.
7368 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7369 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7370
9ceebf39
JD
73712011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7372
7373 * nsterm.m (windowDidResize): Call x_set_window_size only when
7374 ns_in_resize is true. Otherwise set pixelwidth/height and
7375 call change_frame_size (Bug#9628).
7376
cb993c58
PE
73772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7378
3930c88b
PE
7379 Port --enable-checking=all to Fedora 14 x86-64.
7380 * charset.c (syms_of_charset): Also account for glibc malloc's
7381 internal overhead when calculating the initial malloc maximum.
7382
cb993c58
PE
7383 Port --enable-checking=all to Fedora 14 x86.
7384 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7385 Move to lisp.h.
7386 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7387 (overrun_check_realloc, overrun_check_free):
7388 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7389 That way, xmalloc returns a properly-aligned pointer even if
7390 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7391 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7392 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7393 into account when calculating the initial malloc maximum.
7394 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7395 Move here from alloc.c, so that charset.c can use it too.
7396 Properly align; the old code wasn't right for common 32-bit hosts
7397 when configured with --enable-checking=all.
7398 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7399 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7400
31bed486
EZ
74012011-09-29 Eli Zaretskii <eliz@gnu.org>
7402
04c70788 7403 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7404 use EDOM.
7405
fbcaa2f3
EZ
74062011-09-28 Eli Zaretskii <eliz@gnu.org>
7407
7408 * xdisp.c (compute_display_string_end): If there's no display
7409 string at CHARPOS, return -1.
7410
7411 * bidi.c (bidi_fetch_char): When compute_display_string_end
7412 returns a negative value, treat the character as a normal
7413 character not covered by a display string. (Bug#9624)
7414
a239d4e9
JB
74152011-09-28 Juanma Barranquero <lekktu@gmail.com>
7416
7417 * lread.c (Fread_from_string): Fix typo in docstring.
7418
88652fd5
EZ
74192011-09-27 Eli Zaretskii <eliz@gnu.org>
7420
7421 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7422 newline, reseat the iterator instead of bidi-iterating there one
7423 character at a time. (Bug#9610)
32c1fffd
SM
7424 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7425 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7426
ed497dd4
AS
74272011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7428
7429 * lread.c (readevalloop): Use correct code for NBSP.
7430 (read1): Likewise. (Bug#9608)
7431
b2bf61aa
MA
74322011-09-25 Michael Albinus <michael.albinus@gmx.de>
7433
7434 * dbusbind.c (Fdbus_register_signal): When service is not
7435 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7436
32bbb17c
GM
74372011-09-25 Glenn Morris <rgm@gnu.org>
7438
7439 * buffer.c (truncate-lines): Doc fix.
7440
94e0933e
CY
74412011-09-24 Chong Yidong <cyd@stupidchicken.com>
7442
7443 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7444 (Fset_window_next_buffers): Doc fix.
7445
cddde921
GM
74462011-09-24 Glenn Morris <rgm@gnu.org>
7447
7448 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7449
1260aef1
PE
74502011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7451
25b4bfa0
PE
7452 Fix minor problems found by static checking.
7453 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7454 * indent.c (Fvertical_motion): Fix == vs = typo.
7455
e3cbd34b
EZ
74562011-09-24 Eli Zaretskii <eliz@gnu.org>
7457
a66cfb1c
SM
7458 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7459 Default value is now t. Doc fix.
6bf7006f 7460
e3cbd34b 7461 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7462 logic when moving up, not only when moving down. Fix the
e3cbd34b 7463 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7464 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7465
7466 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7467 CHARPOS is covered by a display string which includes newlines.
7468 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7469 is covered by a display string with embedded newlines.
7470
a3de0cbd
MA
74712011-09-24 Michael Albinus <michael.albinus@gmx.de>
7472
7473 * dbusbind.c (Fdbus_register_signal): Add match rule to
7474 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7475 (Fdbus_register_method, Vdbus_registered_objects_table):
7476 Fix docstring.
a3de0cbd 7477
b260039d
JM
74782011-09-24 Jim Meyering <meyering@redhat.com>
7479
32c1fffd 7480 do not ignore write error for any output size
b260039d
JM
7481 The previous change was incomplete.
7482 While it makes emacs --batch detect the vast majority of stdout
7483 write failures, errors were still ignored whenever the output size is
7484 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7485 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7486 && echo FAIL: ignored write error
7487 FAIL: ignored write error
7488 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7489 && echo FAIL: ignored write error
7490 FAIL: ignored write error
7491 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7492
8eca8a7c
AS
74932011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7494
7495 * emacs.c (Fkill_emacs): In noninteractive mode exit
7496 non-successfully if a write error occurred on stdout. (Bug#9574)
7497
3341db62
EZ
74982011-09-21 Eli Zaretskii <eliz@gnu.org>
7499
7500 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7501 the xassert test.
7502
7503 * dispextern.h (struct it): Update the comment documenting what
7504 can it->OBJECT be.
7505
8c203dbf
EZ
75062011-09-20 Eli Zaretskii <eliz@gnu.org>
7507
7508 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7509 a display string, extend search for cursor position to end of row.
7510 (find_row_edges): If the row ends in a newline from a display
7511 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7512 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7513 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7514 non-empty line. Fixes confusing cursor motion with arrow keys at
7515 the beginning of a line that starts with whitespace.
8c203dbf 7516
a4824228
LMI
75172011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7518
7519 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7520 (bug#9493).
7521
33ed493b
CY
75222011-09-18 Chong Yidong <cyd@stupidchicken.com>
7523
7524 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7525 boolean (Bug#9154).
7526
56cd55c8
EZ
75272011-09-18 Eli Zaretskii <eliz@gnu.org>
7528
7529 * xdisp.c (display_line): Record maximum and minimum buffer
7530 positions even if no glyphs were produced (e.g., by a zero-width
7531 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7532 buffer positions that will be removed from the glyph row because
7533 they don't fit.
c02dcedf
EZ
7534 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7535 column is beyond frame width: don't subtract 1 "pixel" when
7536 computing width of the stretch.
3e62b7e0
EZ
7537 (reseat_at_next_visible_line_start): Undo the change made on
7538 2011-09-17 that saved paragraph information and restored it after
7539 the call to `reseat'. (Bug#9545)
56cd55c8 7540
5ed99d36 75412011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7542
7543 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7544 and turn window cursor on if cleared (Bug#9415).
7545
5ed99d36 75462011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7547
7548 * search.c (boyer_moore): Take unibyte characters from pattern
7549 literally. (Bug#9458)
7550
9bade7b2
EZ
75512011-09-18 Eli Zaretskii <eliz@gnu.org>
7552
7553 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7554
e5e9d610
PE
75552011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7556
87e4427a
PE
7557 Fix minor problem found by static checking.
7558 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7559 initialized, to pacify gcc -Wuninitialized.
7560
e5e9d610
PE
7561 * fileio.c: Report proper errno when syscall falls.
7562 (Finsert_file_contents): Save and restore errno,
7563 so that report_file_error outputs the correct diagnostic.
7564 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7565
a1674f0b
EZ
75662011-09-18 Eli Zaretskii <eliz@gnu.org>
7567
7568 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7569
fbfb6dd4
EZ
75702011-09-17 Eli Zaretskii <eliz@gnu.org>
7571
7572 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7573 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7574
bb187662
EZ
75752011-09-17 Eli Zaretskii <eliz@gnu.org>
7576
1137e8b8 7577 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7578 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7579
7580 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7581 (bidi_find_paragraph_start): Search back for paragraph beginning
7582 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7583 (bidi_move_to_visually_next): Only trigger paragraph-related
7584 computations when the last character is a newline or at EOB, not
7585 just any NEUTRAL_B. (Bug#9470)
7586
bb187662
EZ
7587 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7588 truncated lines if point is covered by a display string. (Bug#9524)
7589
2e621251
PE
75902011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7591
7592 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7593 (cons_to_x_long): New function.
7594 (lisp_data_to_selection_data): Use it. Correct the test for
7595 short-versus-long data; it was negated. Break out of vector
7596 loop, for efficiency, when a long datum is discovered.
7597
91a15bc6
SM
75982011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7599
7600 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7601
b41c3a35
EZ
76022011-09-16 Eli Zaretskii <eliz@gnu.org>
7603
7604 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7605 GCC PR/17406) by declaring this function with external scope.
7606
7812ba2d
PE
76072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7608
7609 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7610 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7611
cf7edc2a
AS
76122011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7613
7614 * editfns.c (Fformat): Correctly handle text properties on "%%".
7615
bd01620e
EZ
76162011-09-15 Eli Zaretskii <eliz@gnu.org>
7617
7618 * xterm.c (x_draw_composite_glyph_string_foreground):
7619 * w32term.c (x_draw_composite_glyph_string_foreground):
7620 * term.c (encode_terminal_code):
7621 * composite.c (composition_update_it, get_composition_id):
7622 * xdisp.c (get_next_display_element)
7623 (fill_composite_glyph_string): Add comments about special meaning
7624 of TAB characters in a composition.
7625
a02719a3
PE
76262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7627
7628 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7629 This occurs when processing a multibyte format.
7630 Problem reported by Wolfgang Jenker.
a02719a3 7631
72589a3c
JB
76322011-09-15 Johan Bockgård <bojohan@gnu.org>
7633
7634 * xdisp.c (try_cursor_movement): Only check for exact match if
7635 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7636
1c14176c
PE
76372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7638
7639 Remove unused external symbols.
7640 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7641 * xdisp.c (calc_pixel_width_or_height): Now static.
7642 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7643 * indent.c (check_display_width):
7644 * w32term.c: Fix comment to match code.
7645 * xterm.c, xterm.h (x_catching_errors): Remove.
7646
d2eea5b5
PE
76472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7648
7649 * xselect.c: Use signed conversions more consistently (Bug#9498).
7650 (selection_data_to_lisp_data): Assume incoming selection data are
7651 signed integers, not unsigned. This is to be consistent with
7652 outgoing selection data, which was modified to use signed integers
7653 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7654 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7655 expects long, not unsigned long.
7656
46888499
EZ
76572011-09-14 Eli Zaretskii <eliz@gnu.org>
7658
7659 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7660 computation of loop end. Reported by Johan Bockgård
7661 <bojohan@gnu.org>.
7662
ef8ef9fb
CY
76632011-09-13 Chong Yidong <cyd@stupidchicken.com>
7664
7665 * frame.c (Fother_visible_frames_p): Function deleted.
7666
fa819fed
EZ
76672011-09-12 Eli Zaretskii <eliz@gnu.org>
7668
7669 * indent.c (compute_motion): Process display vector front to back
7670 rather than the other way around. (Bug#2496)
7671
2ba8e008
SM
76722011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7673
7674 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7675
20f53c69
CY
76762011-09-11 Chong Yidong <cyd@stupidchicken.com>
7677
7678 * minibuf.c (Fread_from_minibuffer): Doc fix.
7679
d562d7a4
EZ
76802011-09-11 Eli Zaretskii <eliz@gnu.org>
7681
7682 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7683 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7684
1c4d7f3d
LMI
76852011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7686
7687 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7688 value for non-existent files.
7689
b885bf36
EZ
76902011-09-11 Eli Zaretskii <eliz@gnu.org>
7691
7692 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7693 set its "size" to -1. This will set the modtime_size field of
7694 the corresponding buffer to -1, which is what
7695 verify-visited-file-modtime expects for files that do not exist.
7696 (Bug#9139)
7697
6612f0bf
PE
76982011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7699
7700 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7701 here ...
7702 * lisp.h: ... from here. push_key_description is no longer
7703 defined in keyboard.c, so its declaration should not be in
7704 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7705 logically belongs with push_key_description.
7706
dfb3f755
PE
77072011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7708
7709 * buffer.h: Include <sys/types.h> instead of <time.h>.
7710 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7711 Problem reported by Herbert J. Skuhra.
7712
3134906c
LMI
77132011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7714
7715 * xml.c (parse_region): Make the parsing work for
7716 non-comment-starting XML files again (bug#9144).
7717
8d903f4e
AS
77182011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7719
7720 * image.c (gif_load): Fix calculation of bottom and right corner.
7721 (Bug#9468)
7722
80ad64f4
EZ
77232011-09-10 Eli Zaretskii <eliz@gnu.org>
7724
7725 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7726 redisplay in small windows.
7727
208a048d
EZ
77282011-09-09 Eli Zaretskii <eliz@gnu.org>
7729
7730 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7731
9b1c252e
MR
77322011-09-08 Martin Rudalics <rudalics@gmx.at>
7733
7734 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7735 Operate on live windows only.
7736
2949f33b
JB
77372011-09-08 Juanma Barranquero <lekktu@gmail.com>
7738
7739 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7740
e08dcafd
EZ
77412011-09-07 Eli Zaretskii <eliz@gnu.org>
7742
7743 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7744 only under bidi iteration.
7745
115b96bd
JD
77462011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7747
7748 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7749
c8199d0f
PE
77502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7751
7752 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7753 Without this fix, the command to link temacs failed due to an
7754 undefined symbol __builtin_isnan. This is because
7755 /usr/include/iso/math_c99.h #defines isnan(x) to
7756 __builtin_isnan(x), but the bundled gcc, which identifies itself
7757 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7758 a __builtin_isnan.
7759 * floatfns.c (isnan): #undef, and then #define to a clone of
7760 what's in data.c.
7761 (Fisnan): Always define, since it's always available now.
7762 (syms_of_floatfns): Always define isnan at the Lisp level.
7763
e39b275c 77642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7765
7766 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7767
b2db44d9 77682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7769
f4af5137 7770 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7771 The previous code assumed that file offsets (off_t values) fit in
7772 EMACS_INT variables, which is not true on typical 32-bit hosts.
7773 The code messed up by falsely reporting buffer overflow in cases
7774 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7775 when "big" contains more than 2**29 bytes, even though this
7776 inserts just one byte and does not overflow the buffer.
7777 (Finsert_file_contents): Store file offsets as off_t
7778 values, not as EMACS_INT values. Check for overflow when
7779 converting between EMACS_INT and off_t. When checking for
7780 buffer overflow or for overlap, take the offsets into account.
7781 Don't use EMACS_INT for small values where int suffices.
7782 When checking for overlap, fix a typo: ZV was used where
7783 ZV_BYTE was intended.
7784 (Fwrite_region): Don't assume off_t fits into 'long'.
7785 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7786
ecfc0a49
MA
77872011-09-05 Michael Albinus <michael.albinus@gmx.de>
7788
7789 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7790
6511acf2 77912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7792
0999621a 7793 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7794
7795 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7796 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7797 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7798 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7799 (modify_event_symbol): Do not assume that the length of
7800 name_alist_or_stem is safe to alloca and fits in int.
7801 (Fexecute_extended_command): Likewise for function name and binding.
7802 (Frecursion_depth): Wrap around reliably on integer overflow.
7803 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7804 since some callers pass EMACS_INT values.
7805 (Fsingle_key_description): Don't crash if symbol name contains more
7806 than MAX_ALLOCA bytes.
7807 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7808 (get_minibuffer): Arg is now EMACS_INT, not int.
7809 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7810 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7811 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7812
2be7d702
PE
7813 * dbusbind.c (signature_cat): New function.
7814 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7815 Do not overrun buffer; instead, report string overflow.
7816
9d1df220
PE
7817 * dispnew.c (add_window_display_history): Don't overrun buffer.
7818 Truncate instead; this is OK since it's just a log.
7819
33ef5c64
PE
7820 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7821 even if the time zone offset is outlandishly large.
7822 Don't mishandle offset == INT_MIN.
7823
66c6fdd5
PE
7824 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7825 when creating daemon; the previous buffer-overflow check was incorrect.
7826
d749b01b
PE
7827 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7828 which has the guts of the old verror function.
7829
b5cd1905
PE
7830 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7831 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7832
6e1a67fb
PE
7833 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7834 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7835 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7836 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7837 length of string rather than counting it via multiple sprintfs;
7838 that's simpler and more reliable.
c21721cc
PE
7839 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7840 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7841 sprintf, in case result does not fit in int.
7842
c57b67fc
PE
7843 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7844 (fontset_from_font): Print it.
7845
8a401434
PE
7846 * frame.c (tty_frame_count): Now printmax_t, not int.
7847 (make_terminal_frame, set_term_frame_name): Print it.
7848 (x_report_frame_params): In X, window IDs are unsigned long,
7849 not signed long, so print them as unsigned.
7850 (validate_x_resource_name): Check for implausibly long names,
7851 and don't assume name length fits in 'int'.
7852 (x_get_resource_string): Don't blindly alloca invocation name;
7853 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7854 not fit in int.
7855
6e1a67fb
PE
7856 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7857 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7858 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7859
0df02bf3
PE
7860 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7861 Use esprintf, not sprintf, in case result does not fit in int.
7862
48e30793
PE
7863 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7864 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7865 it as a large positive number.
7866 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7867 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7868
a66ff6d8
PE
7869 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7870 in case result does not fit in int.
7871
aca216ff
PE
7872 * print.c (float_to_string): Detect width overflow more reliably.
7873 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7874 buffer overrun. Don't assume list length fits in 'int'. Treat
7875 print length of 0 as 0, not as infinity; to be consistent with other
7876 uses of print length in this function. Don't overflow print length
7877 index. Don't assume hash table size fits in 'long', or that
7878 vectorlike size fits in 'unsigned long'.
7879
31c286f7
PE
7880 * process.c (make_process): Use printmax_t, not int, to format
7881 process-name gensyms.
7882
55e5faa1
PE
7883 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7884
80f2e268
PE
7885 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7886 to avoid potential buffer overrun.
7887
670741ab
PE
7888 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7889 if X resource line is longer than 512 bytes.
7890
b7163a50
PE
7891 * xfns.c (x_window): Make sprintf buffer a bit bigger
7892 to avoid potential buffer overrun.
7893
ae58ff1f
PE
7894 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7895
c43c8a6a
PE
7896 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7897
3f8236f4
PE
78982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7899
53e9fe90 7900 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7901 Without these, Emacs silently mishandles large integers sometimes.
7902 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7903 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7904
6511acf2
PE
7905 * xdisp.c (try_window_id): Check Emacs fixnum range before
7906 converting to 'int'.
806add1d 7907
6511acf2 7908 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7909 Check that an Emacs fixnum is in range before assigning it to 'int'.
7910 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7911 values converted from Emacs fixnums.
7912 (Frecenter): Don't wrap around a line count if it is out of 'int'
7913 range; instead, treat it as an extreme value.
7914 (Fset_window_configuration, compare_window_configurations):
7915 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7916
6511acf2
PE
7917 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7918 that can exceed INT_MAX. Check that EMACS_INT value is in range
7919 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7920 (match_limit): Don't assume that a fixnum can fit in 'int'.
7921
6511acf2 7922 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7923 exceed INT_MAX.
7924
6511acf2 7925 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7926 (Fvertical_motion): Don't wrap around LINES values that don't fit
7927 in 'int'. Instead, treat them as extreme values. This is good
7928 enough for windows, which can't have more than INT_MAX lines anyway.
7929
fcb901a7
LMI
79302011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7931
0f2f6b6d
LMI
7932 * Require libxml/parser.h to avoid compilation warning.
7933
fcb901a7
LMI
7934 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7935
7936 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7937 since this reportedly can destroy thread storage.
7938
6e20a0d4
CY
79392011-08-30 Chong Yidong <cyd@stupidchicken.com>
7940
7941 * syntax.c (find_defun_start): Update all cache variables if
7942 exiting early (Bug#9401).
7943
148ae00e
EZ
79442011-08-30 Eli Zaretskii <eliz@gnu.org>
7945
f6cfbd8f
EZ
7946 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7947
148ae00e
EZ
7948 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7949 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7950 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7951
7952 * term.c (tty_append_glyph): New function.
7953 (produce_stretch_glyph): Static function and its prototype deleted.
7954
a66cfb1c
SM
7955 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7956 Add prototypes.
148ae00e 7957
c4a07a4c
PE
79582011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7959
7960 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7961 when checking :margin (Bug#9390).
7962 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7963 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7964 so that the name doesn't mislead. All uses changed.
7965
6bc8cd65
JB
79662011-08-28 Johan Bockgård <bojohan@gnu.org>
7967
7968 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7969 set_tty_hooks.
7970
dca4927e
EZ
79712011-08-27 Eli Zaretskii <eliz@gnu.org>
7972
7973 * xdisp.c (move_it_to): Don't bail out early when reaching
7974 position beyond to_charpos, if we are scanning backwards.
7975 (move_it_vertically_backward): When DY == 0, make sure we get to
7976 the first character in the line after the newline.
7977
f2cad773
PE
79782011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7979
7980 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7981 (ccl_driver): Do not generate an out-of-range pointer.
7982 (Fccl_execute_on_string): Remove unnecessary check for
7983 integer overflow, noted by Stefan Monnier in
7984 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7985 Remove a FIXME that didn't need fixing.
7986 Simplify the newly-introduced buffer reallocation code.
7987
0cae2cdb
JB
79882011-08-27 Juanma Barranquero <lekktu@gmail.com>
7989
7990 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7991
5fc295a4 79922011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7993
70c60eb2 7994 Integer and memory overflow issues (Bug#9196).
726e0ab1 7995
d31850da
PE
7996 * doc.c (get_doc_string): Rework so that
7997 get_doc_string_buffer_size is the actual buffer size, rather than
7998 being 1 less than the actual buffer size; this makes xpalloc more
7999 convenient.
8000
a69fbedb
PE
8001 * image.c (x_allocate_bitmap_record, cache_image):
8002 * xselect.c (Fx_register_dnd_atom):
8003 Simplify previous changes by using xpalloc.
8004
fe5c5d37
PE
8005 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8006 since either will do and ptrdiff_t is convenient with xpalloc.
8007
0065d054
PE
8008 * charset.c (charset_table_size)
8009 (struct charset_sort_data.priority): Now ptrdiff_t.
8010 (charset_compare): Don't overflow if priorities differ greatly.
8011 (Fsort_charsets): Don't assume list length fits in int.
8012 Check for size-calculation overflow when allocating sort data.
8013 (syms_of_charset): Allocate an initial charset table that is
8014 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8015
8016 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8017
8018 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8019 The actual value is always <= INT_MAX, and leaving it unsigned made
8020 overflow checking harder.
8021
8022 * dispextern.h (struct glyph_matrix.rows_allocated)
8023 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8024 with xpalloc. The values are still always <= INT_MAX.
8025
8026 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8027
8028 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8029 (SAFE_NALLOCA): New macro.
8030
8031 * region-cache.c (struct boundary.pos, find_cache_boundary)
8032 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8033 (set_cache_region, invalidate_region_cache)
8034 (revalidate_region_cache, know_region_cache, region_cache_forward)
8035 (region_cache_backward, pp_cache):
8036 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8037 so that ptrdiff_t * can be passed to xpalloc.
8038 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8039 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8040 (pp_cache): Don't assume cache_len fits in int.
8041 * region-cache.h: Adjust extern decls to match.
8042
8043 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8044 EMACS_INT, since either will do, for xpalloc.
8045
8046 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8047 (xnmalloc, xnrealloc, xpalloc): New functions.
8048
726e0ab1
PE
8049 * bidi.c (bidi_shelve_header_size): New constant.
8050 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8051 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8052
51f30bc5 8053 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8054 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8055 (overlay_strings):
8056 Don't update size of array until after memory allocation succeeds,
8057 because xmalloc/xrealloc may not return.
0065d054
PE
8058 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8059 now that we have proper integer overflow checking.
8060 (record_overlay_string, overlay_strings): Catch overflows when
8061 calculating size of overlay_str_buf.
726e0ab1 8062
0065d054
PE
8063 * callproc.c (Fcall_process): Check for size overflow when
8064 calculating size of args2.
8065 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8066 Normally we prefer signed values, but sticking with ptrdiff_t would
8067 require adding more-complicated checks.
726e0ab1
PE
8068
8069 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8070 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8071 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8072 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8073
8074 * character.c (Fstring): Check for size-calculation overflow.
8075
8076 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8077 unnecessary integer overflow. Check for size overflow.
8078 (encode_coding_object): Don't update size until xmalloc succeeds.
8079
8080 * composite.c (get_composition_id): Check for overflow in glyph
8081 length calculations.
8082
8083 Integer and memory overflow fixes for display code.
8084 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8085 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8086 (scrolling_window): Check for overflow in size calculations.
8087 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8088 Don't assume glyph table len fits in int.
8089 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8090 (row_table_size): Now ptrdiff_t, not int.
8091 (scrolling_window): Avoid overflow in size calculations.
8092 Don't update size until allocation succeeds.
8093 * fns.c (concat): Check for overflow in size calculations.
8094 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8095 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8096 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8097
8098 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8099 (get_doc_string): Check for size calculation overflow.
8100 Don't update size until allocation succeeds.
8101 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8102 EMACS_INT, where ptrdiff_t will do.
8103 (Fsubstitute_command_keys): Check for string overflow.
8104
8105 * editfns.c (set_time_zone_rule): Don't assume environment length
8106 fits in int.
8107 (message_length): Now ptrdiff_t, not int.
8108 (Fmessage_box): Don't update size until allocation succeeds.
8109 Don't assume message length fits in int.
8110 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8111
0065d054
PE
8112 * emacs.c (main): Do not reallocate argv, since there is a null at
8113 the end that can be overwritten, and this way there's no need to
8114 worry about size-calculation overflow.
8115 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8116
8117 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8118 alloc succeeds.
8119 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8120
8121 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8122 (x_set_scroll_bar_width, x_figure_window_size):
8123 Check for integer overflow.
8124 (x_set_alpha): Do not assume XINT fits in int.
8125
8126 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8127 This is for the members text_lines, text_cols, total_lines, total_cols,
8128 where the system imposes an 'int' limit.
8129
8130 * fringe.c (Fdefine_fringe_bitmap):
8131 Don't update size until alloc works.
8132
8133 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8134 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8135
8136 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8137 Check for size-calculation overflow.
8138 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8139 do, as we prefer signed integers.
8140 (id_to_widget.max_size, id_to_widget.used)
8141 (xg_store_widget_in_map, xg_remove_widget_from_map)
8142 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8143 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8144 Use and return ptrdiff_t, not int.
8145 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8146 * gtkutil.h: Change prototypes to match the above.
8147
8148 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8149 are duplicate now that they've been promoted to lisp.h.
8150 (x_allocate_bitmap_record, x_alloc_image_color)
8151 (make_image_cache, cache_image, xpm_load):
8152 Don't update size until alloc is done.
8153 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8154 (x_detect_edges):
3256efce 8155 Check for size calculation overflow.
726e0ab1
PE
8156 (ct_colors_allocated_max): New constant.
8157 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8158 overflow.
3256efce 8159
726e0ab1
PE
8160 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8161 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8162 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8163 Use ptrdiff_t, not int, to count maps.
8164 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8165 calculations. Don't update size until allocation succeeds.
8166 Redo calculations to avoid overflow.
726e0ab1
PE
8167 * keyboard.h: Change prototypes to match the above.
8168
8169 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8170 to count maps.
8171 (current_minor_maps): Check for size calculation overflow.
8172 * keymap.h: Change prototypes to match the above.
8173
8174 * lread.c (read1, init_obarray): Don't update size until alloc done.
8175
8176 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8177 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8178
726e0ab1
PE
8179 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8180 Now ptrdiff_t, not int.
8181 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8182 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8183
8184 * process.c (Fnetwork_interface_list): Check for overflow
8185 in size calculation.
8186
8187 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8188
8189 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8190 overflow. Don't bother calling xmalloc when xrealloc will do.
8191
8192 * search.c (Freplace_match): Check for size calculation overflow.
8193 (Fset_match_data): Don't assume list lengths fit in 'int'.
8194
8195 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8196 for command line length. Do not attempt to address one before the
8197 beginning of an array, as that's not portable.
8198
8199 * term.c (max_frame_lines): Remove; unused.
8200 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8201 not int.
8202 (encode_terminal_code, calculate_costs): Check for size
8203 calculation overflow.
8204 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8205 table lengths and related sizes. Don't update size until alloc
8206 done. Redo calculations to avoid overflow.
8207 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8208
8209 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8210 subtracting pointers.
8211 (gobble_line): Check for overflow more carefully. Don't update size
8212 until alloc done.
8213
8214 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8215 Don't update size until alloc done.
8216 Redo size calculations to avoid overflow.
8217 Check for size calculation overflow.
0065d054 8218 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8219
8220 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8221 Use ptrdiff_t, not int, for sizes.
8222 (store_mode_line_noprop_char): Don't update size until alloc done.
8223
0065d054
PE
8224 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8225 Use ptrdiff_t, not int, for sizes.
8226 (Finternal_make_lisp_face, cache_face):
8227 Check for size calculation overflow.
8228 (cache_face): Treat size calculation overflows as if they were
8229 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8230
8231 * xfns.c (x_encode_text, x_set_name_internal)
8232 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8233 sizes, since they can exceed INT_MAX in size. Check for size
8234 calculation overflow.
8235
0065d054
PE
8236 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8237 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8238 Don't update size until alloc done.
8239
0065d054 8240 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8241 as sprintf is limited to int lengths.
1d526e2f 8242
252c5ee1
PE
8243 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8244 (X_LONG_MIN): New macros.
864d7ce7
PE
8245 Use them to make the following changes clearer.
8246 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8247 This change doesn't affect the value now, but it may help remind
8248 future maintainers not to raise the value too much later.
8249 (SELECTION_QUANTUM): Remove, replacing with ...
8250 (selection_quantum): ... new function, which avoids overflow.
8251 All uses changed.
8252 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8253 assumption that selection length fits in 'int'.
8254 (x_reply_selection_request, x_handle_selection_request)
8255 (x_get_window_property, receive_incremental_selection)
8256 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8257 (lisp_data_to_selection_data, clean_local_selection_data):
8258 Use ptrdiff_t, not int, to record length of selection.
8259 (x_reply_selection_request, x_get_window_property)
8260 (receive_incremental_selection, x_property_data_to_lisp):
8261 Redo calculations to avoid overflow.
8262 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8263 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8264 something.
8265 (x_get_window_property, receive_incremental_selection)
8266 (lisp_data_to_selection_data, x_property_data_to_lisp):
8267 Check for size-calculation overflow.
8268 (x_get_window_property, receive_incremental_selection)
8269 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8270 Don't store size until memory allocation succeeds.
8271 (x_get_window_property): Plug memory leak on memory exhaustion.
8272 Don't double-block input; malloc is safe here. Don't assume 2**34
8273 - 4 fits in unsigned long. Add an xassert to check
8274 XGetWindowProperty overflow. Be more careful about overflow
8275 calculations, and distinguish size from memory overflow better.
8276 (receive_incremental_selection): When tracing, don't assume
8277 unsigned int is less than INT_MAX.
8278 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8279 harmful) conversions of unsigned short to int.
8280 (lisp_data_to_selection_data): Don't assume that integers
8281 in the range -65535 through -1 fit in an X unsigned short.
8282 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8283 result parameters unless successful. Rely on cons_to_unsigned
8284 to report problems with elements; the old code wasn't right anyway.
8285 (x_check_property_data): Check for int overflow; we cannot use
8286 a wider type due to X limits.
8287 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8288
726e0ab1 8289 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8290
0065d054
PE
8291 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8292 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8293 (x_color_cells): Don't store size until memory allocation succeeds.
8294 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8295 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8296 (x_term_init): Don't assume length fits in int (sprintf is limited
8297 to int size).
bc18e09d 8298
ebfa62c0
PE
8299 Use ptrdiff_t for composition IDs.
8300 * character.c (lisp_string_width):
8301 * composite.c (composition_table_size, n_compositions)
8302 (get_composition_id, composition_gstring_from_id):
8303 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8304 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8305 * window.c (Frecenter):
8306 Use ptrdiff_t, not int, for composition IDs.
8307 * composite.c (get_composition_id): Check for integer overflow.
8308 * composite.h: Adjust prototypes to match the above changes.
8309
d3411f89
PE
8310 Use ptrdiff_t for hash table indexes.
8311 * category.c (hash_get_category_set):
8312 * ccl.c (ccl_driver):
8313 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8314 * coding.c (coding_system_charset_list, detect_coding_system):
8315 * coding.h (struct coding_system.id):
8316 * composite.c (get_composition_id, gstring_lookup_cache):
8317 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8318 * image.c (xpm_get_color_table_h):
8319 * lisp.h (hash_lookup, hash_put):
8320 * minibuf.c (Ftest_completion):
8321 Use ptrdiff_t for hash table indexes, not int (which is too
8322 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8323 32-bit --with-wide-int hosts).
8324
e097a6fa
PE
8325 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8326 Add a FIXME comment about memory leaks.
8327 (syms_of_charset): Don't assume xmalloc returns.
8328
5637687f
PE
8329 Don't assume that stated character widths fit in int.
8330 * character.c (Fchar_width, c_string_width, lisp_string_width):
8331 * character.h (CHAR_WIDTH):
8332 * indent.c (MULTIBYTE_BYTES_WIDTH):
8333 Use sanitize_char_width to avoid undefined and/or bad behavior
8334 with outlandish widths.
a66cfb1c 8335 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8336 now that we have two such functions. All uses changed.
8337 (sanitize_char_width): New inline function.
8338
a2271ba2
PE
8339 Don't assume that tab-width fits in int.
8340 * character.h (sanitize_width): New inline function.
8341 (SANE_TAB_WIDTH): New macro.
8342 (ASCII_CHAR_WIDTH): Use it.
8343 * indent.c (sane_tab_width): Remove. All uses replaced by
8344 SANE_TAB_WIDTH (current_buffer).
8345 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8346
18c52557
PE
8347 * fileio.c: Integer overflow issues with file modes.
8348 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8349
caeeedc1
PE
8350 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8351 Remove unreachable code.
8352 (read_hex, load_charset_map_from_file): Check for integer overflow.
8353
6df6ae42 8354 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8355 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8356 (x_send_scroll_bar_event): Likewise. Check that the size does not
8357 exceed limits imposed by XClientMessageEvent, as well as the usual
8358 ptrdiff_t and size_t limits.
8359
b13995db
PE
8360 * keyboard.c: Overflow, signedness and related fixes.
8361 (make_lispy_movement): Use same integer type in forward decl
8362 that is used in the definition.
8363 (read_key_sequence, keyremap_step):
8364 Change bufsize argument back to int, undoing my 2011-03-30 change.
8365 We prefer signed types, and int is wide enough here.
8366 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8367 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8368 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8369 length, not size_t. Use ptrdiff_t for index, not int.
8370 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8371 possibility of integer overflow.
8372
13464394
PE
8373 Overflow, signedness and related fixes for images.
8374
8375 * dispextern.h (struct it.stack[0].u.image.image_id)
8376 (struct_it.image_id, struct image.id, struct image_cache.size)
8377 (struct image_cache.used, struct image_cache.ref_count):
8378 * gtkutil.c (update_frame_tool_bar):
8379 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8380 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8381 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8382 * nsmenu.m (update_frame_tool_bar):
8383 * xdisp.c (calc_pixel_width_or_height):
8384 * xfns.c (image_cache_refcount):
8385 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8386 on typical 64-bit hosts.
8387
8388 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8389 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8390 Omit unnecessary casts to int.
8391 (parse_image_spec): Check that integers fall into 'int' range
8392 when the callers expect that.
8393 (image_ascent): Redo ascent calculation to avoid int overflow.
8394 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8395 (lookup_image): Remove unnecessary tests.
8396 (xbm_image_p): Locals are now of int, not EMACS_INT,
8397 since parse_image_check makes sure they fit into int.
8398 (png_load, gif_load, svg_load_image):
8399 Prefer int to unsigned where either will do.
8400 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8401 old tiff_error_handler and tiff_warning_handler.
8402 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8403 stack buffer overflows. It uses only the features of vsnprintf
8404 that are common to both POSIX and native Microsoft.
8405 (tiff_error_handler, tiff_warning_handler): Use it.
8406 (tiff_load, gif_load, imagemagick_load_image):
8407 Don't assume :index value fits in 'int'.
8408 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8409 (imagemagick_load_image): Check that crop parameters fit into
8410 the integer types that MagickCropImage accepts. Don't assume
8411 Vimagemagick_render_type has a nonnegative value. Don't assume
8412 size_t fits in 'long'.
8413 (gs_load): Use printmax_t to print the widest integers possible.
8414 Check for integer overflow when computing image height and width.
8415
c11821d4
EZ
84162011-08-26 Eli Zaretskii <eliz@gnu.org>
8417
8418 * xdisp.c (redisplay_window): Don't force window start if point
8419 will be invisible in the resulting window. (Bug#9324)
8420
0c95fcf7
EZ
84212011-08-25 Eli Zaretskii <eliz@gnu.org>
8422
8423 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8424 the display spec is of the form `(space ...)'.
8425 (handle_display_spec): Return the value returned by
8426 handle_single_display_spec, not just 1 or zero.
8427 (handle_single_display_spec): If the display spec is of the form
8428 `(space ...)', and specifies display in the text area, return 2
8429 rather than 1.
fee65a97 8430 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8431 accurately, and prefer exact match for point under bidi.
8432 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8433
8434 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8435 into disp_prop; all users changed.
8436
8437 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8438 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8439 for the text covered by the display property.
8440
e4ed06f1
CY
84412011-08-25 Chong Yidong <cyd@stupidchicken.com>
8442
8443 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8444 Change return value to nil.
8445 (Frecord_buffer): Delete unused function.
8446
f67cdd7f
EZ
84472011-08-24 Eli Zaretskii <eliz@gnu.org>
8448
5980d4c6
EZ
8449 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8450 buffers, return left-to-right.
8610fe8b
EZ
8451 (set_cursor_from_row): Consider candidate row a win if its glyph
8452 represents a newline and point is on that newline. Fixes cursor
8453 positioning on the newline at EOL of R2L text within L2R
8454 paragraph, and vice versa.
8455 (try_cursor_movement): Check continued rows, in addition to
8456 continuation rows. Fixes unwarranted scroll when point enters a
8457 continued line of R2L text within an L2R paragraph, or vice versa.
8458 (cursor_row_p): Consider the case of point being equal to
8459 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8460 from the end of a short line to the beginning of a continued line
8461 of R2L text within L2R paragraph.
8462 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8463 composed characters.
5980d4c6 8464
f67cdd7f
EZ
8465 * bidi.c (bidi_check_type): Use xassert.
8466 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8467 members.
8468
bca633fb
EZ
84692011-08-23 Eli Zaretskii <eliz@gnu.org>
8470
8471 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8472 a character.
8473
4a5885a7
CY
84742011-08-23 Chong Yidong <cyd@stupidchicken.com>
8475
8476 * nsfont.m (ns_otf_to_script): Fix typo.
8477
0902a04e
KH
84782011-08-22 Kenichi Handa <handa@m17n.org>
8479
8480 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8481 extra slot even if the purpose is char-code-property-table.
8482
1a2e6670
EZ
84832011-08-23 Eli Zaretskii <eliz@gnu.org>
8484
8ddde651
EZ
8485 * xdisp.c (redisplay_window): When computing centering_position,
8486 account for the height of the header line. (Bug#8874)
8487
425cc014
EZ
8488 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8489 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8490 candidate is selected by the mouse, and that candidate has a
8491 composed character under the mouse.
8492
1a2e6670
EZ
8493 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8494 coordinates reported by pos-visible-in-window-p for a composed
8495 character in column zero.
8496
8b76d6f8
SM
84972011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8498
8499 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8500
dac347dd
EZ
85012011-08-22 Eli Zaretskii <eliz@gnu.org>
8502
8503 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8504 consider it a hit if to_charpos is anywhere in the range of the
8505 composed buffer positions.
8506
e013fb34
CY
85072011-08-22 Chong Yidong <cyd@stupidchicken.com>
8508
8509 * image.c (gif_load): Don't assume that each subimage has the same
8510 dimensions as the base image. Handle disposal method that is
8511 "undefined" by the gif spec (Bug#9335).
8512
bd1ba3e8
CY
85132011-08-20 Chong Yidong <cyd@stupidchicken.com>
8514
8515 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8516 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8517
54a1215b
EZ
85182011-08-19 Eli Zaretskii <eliz@gnu.org>
8519
823564e5
EZ
8520 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8521 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8522 from an Org mode buffer to a Speedbar frame.
8523
54a1215b
EZ
8524 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8525 a composition, take its buffer position from IT->cmp_it.charpos.
8526 Fixes cursor positioning at the beginning of a line that begins
8527 with a composed character.
8528
9778ebcc
EZ
85292011-08-18 Eli Zaretskii <eliz@gnu.org>
8530
0be6ee06
EZ
8531 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8532 character bidirectional type, use STRONG_L instead. Fixes crashes
8533 in a buffer produced by `describe-categories'.
8534
9778ebcc
EZ
8535 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8536 members before the level stack, so they would be saved and
8537 restored when copying iterator state. Fixes incorrect reordering
8538 around TABs covered by display properties.
8539
156bffbe
AS
85402011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8541
6b02f655 8542 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8543
72ad093b
CY
85442011-08-17 Chong Yidong <cyd@stupidchicken.com>
8545
8546 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8547 (internal_condition_case_2, internal_condition_case_n):
8548 Remove unnecessary aborts (Bug#9081).
72ad093b 8549
35774242
EZ
85502011-08-17 Eli Zaretskii <eliz@gnu.org>
8551
8552 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8553 has no `load' handler, try opening the file locally. (Bug#9311)
8554
db76dd85
KB
85552011-08-16 Ken Brown <kbrown@cornell.edu>
8556
8557 * gmalloc.c: Expand comment.
8558
b215eee5
EZ
85592011-08-16 Eli Zaretskii <eliz@gnu.org>
8560
8561 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8562 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8563
a4579d33
KB
85642011-08-16 Ken Brown <kbrown@cornell.edu>
8565
8566 Fix memory allocation problems in Cygwin build (Bug#9273).
8567
8568 * unexcw.c ( __malloc_initialized): Declare external variable.
8569 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8570
8b76d6f8
SM
8571 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8572 New variables.
a4579d33
KB
8573 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8574 dumped emacs.
8575 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8576 in the static heap.
8577 [CYGWIN] (special_realloc): New function.
8578 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8579 requests to realloc storage in the static heap.
8580
3ebec551
PE
85812011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8582
8583 * bidi.c (bidi_initialize): Remove unused local.
8584
9fd8be00
EZ
85852011-08-15 Eli Zaretskii <eliz@gnu.org>
8586
6b02f655
SM
8587 * bidimirror.h:
8588 * biditype.h: Remove file.
8589 * makefile.w32-in ($(BLD)/bidi.$(O)):
8590 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8591
8592 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8593
8594 * chartab.c: Improve commentary for the uniprop_table API.
8595
32413314
EZ
8596 * bidi.c (bidi_paragraph_init): Support zero value of
8597 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8598 (bidi_initialize): Use uniprop_table instead of including
8599 biditype.h and bidimirror.h.
32413314 8600
9fd8be00
EZ
8601 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8602 coordinates of the iterator when restoring from ppos_it.
8603 (Bug#9296)
8604
5cf2b69b
KH
86052011-08-14 Kenichi Handa <handa@m17n.org>
8606
8607 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8608 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8609
daf17d00
EZ
86102011-08-14 Eli Zaretskii <eliz@gnu.org>
8611
8612 * xdisp.c (move_it_in_display_line_to): Don't invoke
8613 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8614 ppos_it. Fixes vertical cursor motion when line beginning is
8615 covered by an image. (Bug#9296)
8616
08e3161a
JD
86172011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8618
8619 * nsterm.h (ns_run_ascript): Declare.
8620 (NSAPP_DATA2_RUNASSCRIPT): Define.
8621
8622 * nsfns.m (as_script, as_result, as_status): New static variables.
8623 (ns_run_ascript): New function.
5e617bc2 8624 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8625 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8626 the event loop. Get status from as_status (Bug#7276).
8627
8628 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8629 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8630 the event loop (Bug#7276).
8631
a3720aa2
AS
86322011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8633
8634 * gnutls.c (QCgnutls_bootprop_priority)
8635 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8636 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8637 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8638 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8639 (QCgnutls_bootprop_verify_hostname_error)
8640 (QCgnutls_bootprop_callbacks_verify): Rename from
8641 Qgnutls_bootprop_..., all uses changed.
8642
8643 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8644 uses changed.
8645
0a0d27fb
PE
86462011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8647
19d5c50c
PE
8648 * xfaces.c (Qframe_set_background_mode): Now static.
8649 * dispextern.h (Qframe_set_background_mode): Remove decl.
8650
0a0d27fb
PE
8651 * process.c (Fnetwork_interface_info): Declare local only if needed.
8652
377538cb
JD
86532011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8654
8655 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8656 (Fnetwork_interface_list): Allocate in increments of bytes instead
8657 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8658 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8659 sockaddr.
8660 (struct ifflag_def): notrailers is smart on OSX.
8661 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8662 Get hardware address with getifaddrs if available.
8663
08fff70c
EZ
86642011-08-12 Eli Zaretskii <eliz@gnu.org>
8665
8666 * xdisp.c (iterate_out_of_display_property): xassert that
8667 IT->position is set to within IT->object's boundaries. Break from
8668 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8669 when IT->position is set up wrongly due to some bug.
8670 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8671 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8672 entry. Force push_it to save on the stack the current
8673 buffer/string position, to be restored by pop_it. Fix flags in
8674 the iterator structure wrt the object coming from a display
8675 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8676 properties. (Bug#9284)
8677
7be1c708 86782011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8679
7be1c708
CY
8680 * fontset.c (fontset_get_font_group): Add proper type checks.
8681 (Bug#9172)
aac0c6e3 8682
7be1c708 86832011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8684
7be1c708
CY
8685 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8686 and LC_VERSION_MIN_MACOSX.
8687 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8688 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8689
97bb72a6
EZ
86902011-08-08 Eli Zaretskii <eliz@gnu.org>
8691
8692 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8693 no-display-properties-and-no-overlays under bidi display.
8694 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8695 properties and overlays.
97bb72a6 8696
d5617611
CY
86972011-08-08 Chong Yidong <cyd@stupidchicken.com>
8698
37e11a63
CY
8699 * editfns.c (Fset_time_zone_rule): Document relationship with the
8700 setenv function.
8701
d5617611
CY
8702 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8703 the font entity extracted from the cache (Bug#8109).
8704
58872834
CY
87052011-08-07 Chong Yidong <cyd@stupidchicken.com>
8706
8707 * composite.c (autocmp_chars): Don't reset point. That is done by
8708 restore_point_unwind (Bug#5984).
8709
75bfc667
JL
87102011-08-07 Juri Linkov <juri@jurta.org>
8711
8712 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8713 to show the arg `TIME' instead of `TIMEVAL'.
8714
d1410150
EZ
87152011-08-06 Eli Zaretskii <eliz@gnu.org>
8716
8717 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8718 display property strides EOL and includes a newline, as in
8719 longlines-mode. (Bug#9254)
75b771e4
EZ
8720 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8721 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8722
8723 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8724 is non-zero, even if the data buffer is NULL. Fixes a crash in
8725 vertical-motion with longlines-mode. (Bug#9254)
8726
35928349
EZ
87272011-08-05 Eli Zaretskii <eliz@gnu.org>
8728
ec7cc85b
EZ
8729 * bidi.c <bidi_cache_total_alloc>: Now static.
8730 (bidi_initialize): Initialize bidi_cache_total_alloc.
8731
8b76d6f8 8732 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8733 cache. (Bug#9221)
8734
8735 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8736 amount allocated this far in `bidi_cache_total_alloc'.
8737 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8738 non-zero, only free the data buffer without restoring the cache
8739 contents. All callers changed.
8740
8741 * dispextern.h (bidi_unshelve_cache): Update prototype.
8742
8743 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8744 (move_it_in_display_line, move_it_to)
8745 (move_it_vertically_backward, move_it_by_lines): Replace the call
8746 to xfree to an equivalent call to bidi_unshelve_cache.
8747 (move_it_in_display_line_to): Fix logic of returning
412b6358 8748 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8749
e2e2423b
EZ
87502011-08-05 Eli Zaretskii <eliz@gnu.org>
8751
8752 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8753 came from a string character with a `cursor' property. (Bug#9229)
8754
ae9e757a
JD
87552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8756
8757 * Makefile.in (LIB_PTHREAD): New variable.
8758 (LIBES): Add LIB_PTHREAD (Bug#9216).
8759
8760 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8761 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8762
213bd7f2
AS
87632011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8764
6b02f655 8765 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8766
99aaf75f
JD
87672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8768
8769 * xterm.c (x_find_topmost_parent): New function.
8770 (x_set_frame_alpha): Find topmost parent window with
8771 x_find_topmost_parent and set the property there also (bug#9181).
8772 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8773
c74e9d86
PE
87742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8775
8776 * callproc.c (Fcall_process): Avoid vfork clobbering
8777 the local vars buffer, coding_systems, current_dir.
8778
640c8776
SM
87792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8780
8781 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8782
f26d0e4c
PE
87832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8784
8a10d76c
PE
8785 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8786 so that it is not optimized away.
8787
f26d0e4c
PE
8788 * xdisp.c (compute_display_string_pos): Remove unused local.
8789
55439c61
EZ
87902011-08-02 Eli Zaretskii <eliz@gnu.org>
8791
8792 Fix slow cursor motion and scrolling in large buffers with
8793 selective display, like Org Mode buffers. (Bug#9218)
8794
8795 * dispextern.h (struct bidi_it): New member disp_prop_p.
8796
8797 * xdisp.c: Remove one-slot cache of display string positions.
8798 (compute_display_string_pos): Accept an additional argument
5e617bc2 8799 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8800 for a display string or property. If found, set DISP_PROP_P
8801 non-zero.
8802
8803 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8804 DISP_PROP_P, and pass it to compute_display_string_pos.
8805 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8806 non-zero. All callers of bidi_fetch_char changed.
8807
fb33fa43
SM
88082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8809
8810 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8811
b099e063
DM
88122010-12-03 Don March <don@ohspite.net>
8813
8814 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8815 last character M-[char] is translated to ESC [char] (bug#7541).
8816
5cc7f7af
KH
88172011-08-02 Kenichi Handa <handa@m17n.org>
8818
d0fffa3f 8819 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8820
8821 * chartab.c (uniprop_table): Make it non-static.
8822
525d5e6e
EZ
88232011-08-01 Eli Zaretskii <eliz@gnu.org>
8824
8825 * xdisp.c (forward_to_next_line_start): Accept additional argument
8826 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8827 on the newline.
8828 (reseat_at_next_visible_line_start): Use the bidi iterator state
8829 returned by forward_to_next_line_start to restore the state of
8830 it->bidi_it after backing up to previous newline. (Bug#9212)
8831
31011111
AS
88322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8833
8834 * regex.c (re_comp): Protoize.
8835 (re_exec): Fix return type.
8836 (regexec): Fix type of `ret'. (Bug#9203)
8837
476371c4
PE
88382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8839
e5d76069
PE
8840 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8841 This is needed if max-image-size is a floating-point number.
8842
9a79b20c
AS
88432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8844
8845 * print.c (print_object): Print empty symbol as ##.
8846
8847 * lread.c (read1): Read ## as empty symbol.
8848
d8c2fa78
AA
88492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8850
8851 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8852 setting frame foreground color (Bug#9175).
8853 (x_set_background_color): Likewise.
8854
ffe57a7a
AA
8855 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8856 contents (Bug#9176).
8857 (EmacsTooltip -init): Remove bezels and add shadows to
8858 tooltip windows.
8859
bf3492a5
AA
8860 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8861 or scroll bar (Bug#8470).
8862
d55e9c53
AA
8863 * nsfont.m (nsfont_open): Remove assignment to voffset and
8864 unnecessary vars hshink, expand, hd, full_height, min_height.
8865 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8866
8867 * nsterm.h (nsfont_info): Remove voffset field.
8868
d8c2fa78 88692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8870
8871 Implement strike-through and overline on NextStep (Bug#8863).
8872
8873 * nsfont.m (nsfont_open): Use underline position provided by font,
8874 instead of hard-coded value of 2.
8875 (nsfont_draw): Call ns_draw_text_decoration instead.
8876
8877 * nsterm.h: Add declaration for ns_draw_text_decoration.
8878
8879 * nsterm.m (ns_draw_text_decoration): New function for drawing
8880 underline, overline, and strike-through.
8881 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8882 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8883 accommodate underlining, etc.
4843aac3 8884
4cc60b9b
EZ
88852011-07-28 Eli Zaretskii <eliz@gnu.org>
8886
bc7ece87
EZ
8887 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8888 default.
4cc60b9b 8889
476371c4
PE
88902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8891
66606eea
PE
8892 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8893 Without this fix, if a signal arrives just after memory fills up,
8894 'malloc' might be invoked reentrantly.
8895
476371c4
PE
8896 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8897 In other words, assume that every image size is allowed, on non-X
8898 hosts. This assumption is probably wrong, but it lets Emacs compile.
8899
f3fcc40d
AS
89002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8901
8902 * regex.c (re_iswctype): Convert return values to boolean.
8903
350c992f
EZ
89042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8905
8906 * xdisp.c (compute_display_string_pos): Don't use cached display
8907 string position if the buffer had its restriction changed.
8908 (Bug#9184)
8909
5266b4bb
PE
89102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8911
8912 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8913
2573a837 89142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8915
41f55ccd 8916 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8917
39e378da
PE
8918 * bidi.c: Integer size and overflow fixes.
8919 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8920 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8921 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8922 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8923 (bidi_find_other_level_edge):
8924 Use ptrdiff_t instead of EMACS_INT where either will do.
8925 This works better on 32-bit hosts configured --with-wide-int.
8926 (bidi_cache_ensure_space): Check for size-calculation overflow.
8927 Use % rather than repeated addition, for better worst-case speed.
8928 Don't set bidi_cache_size until after xrealloc returns, because it
8929 might not return.
8930 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8931 (bidi_cache_ensure_space): Also check that the bidi cache size
8932 does not exceed that of the largest Lisp string or buffer. See Eli
8933 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8934
5e927815
PE
8935 * alloc.c (__malloc_size_t): Remove.
8936 All uses replaced by size_t. See Andreas Schwab's note
8937 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8938
ca4aa935
PE
8939 * image.c: Improve checking for integer overflow.
8940 (check_image_size): Assume that f is nonnull, since
8941 it is always nonnull in practice. This is one less thing to
8942 worry about when checking for integer overflow later.
8943 (x_check_image_size): New function, which checks for integer
8944 overflow issues inside X.
8945 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8946 This removes the need for a memory_full check.
8947 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8948 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8949 (xbm_read_bitmap_data): Change locals back to 'int', since
8950 their values must fit in 'int'.
8951 (xpm_load_image, png_load, tiff_load):
8952 Invoke x_create_x_image_and_pixmap earlier,
8953 to avoid much needless work if the image is too large.
8954 (tiff_load): Treat overly large images as if
8955 x_create_x_image_and_pixmap failed, not as malloc failures.
8956 (gs_load): Use x_check_image_size.
8957
5f8f9cc2
PE
8958 * gtkutil.c: Omit integer casts.
8959 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8960 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8961
5adf60bc
PE
8962 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8963
c8907a93
PE
8964 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8965 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8966 would wrongly return t on a 64-bit host.
8967
e3c25c68
PE
8968 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8969 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8970 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8971 and therefore cause GCC to emit a bogus diagnostic in some cases.
8972
3f791afe
PE
8973 * image.c: Integer signedness and overflow and related fixes.
8974 This is not an exhaustive set of fixes, but it's time to
8975 record what I've got.
8976 (lookup_pixel_color, check_image_size): Remove redundant decls.
8977 (check_image_size): Don't assume that arbitrary EMACS_INT values
8978 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8979 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8980 (tiff_load, imagemagick_load_image):
8981 Check for overflow in size calculations.
8982 (x_create_x_image_and_pixmap): Remove unnecessary test for
8983 xmalloc returning NULL; that can't happen.
8984 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8985 (xpm_color_bucket): Use better integer hashing function.
8986 (xpm_cache_color): Don't possibly over-allocate memory.
8987 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8988 (gif_memory_source):
8989 Use ptrdiff_t, not int or size_t, to record sizes.
8990 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8991 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8992 either works, as we prefer signed integers.
8993 (tiff_read_from_memory, tiff_write_from_memory):
8994 Return tsize_t, not size_t, since that's what the TIFF API wants.
8995 (tiff_read_from_memory): Don't fail simply because the read would
8996 go past EOF; instead, return a short read.
8997 (tiff_load): Omit no-longer-needed casts.
8998 (Fimagemagick_types): Don't assume size fits into 'int'.
8999
3cc5a532
PE
9000 Improve hashing quality when configured --with-wide-int.
9001 * fns.c (hash_string): New function, taken from sxhash_string.
9002 Do not discard information about ASCII character case; this
9003 discarding is no longer needed.
9004 (sxhash-string): Use it. Change sig to match it. Caller changed.
9005 * lisp.h: Declare it.
9006 * lread.c (hash_string): Remove, since we now use fns.c's version.
9007 The fns.c version returns a wider integer if --with-wide-int is
9008 specified, so this should help the quality of the hashing a bit.
9009
b312a492
PE
9010 * emacs.c: Integer overflow minor fix.
9011 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9012 Define only if GNU_LINUX.
9013 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9014
dfd153ae
PE
9015 * dispnew.c: Integer signedness and overflow fixes.
9016 Remove unnecessary forward decls, that were a maintenance hassle.
9017 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9018 All uses changed.
9019 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9020 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9021 (prepare_desired_row, line_draw_cost):
9022 Use int, not unsigned, where either works.
9023 (save_current_matrix, restore_current_matrix):
9024 Use ptrdiff_t, not size_t, where either works.
9025 (init_display): Check for overflow more accurately, and without
9026 relying on undefined behavior.
9027
a81d11a3
PE
9028 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9029 Remove, replacing with the new symbols in lisp.h. All uses changed.
9030 * fileio.c (make_temp_name):
9031 * filelock.c (lock_file_1, lock_file):
9032 * xdisp.c (message_dolog):
9033 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9034 Use pMd etc. instead.
9035 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9036 replacing the pWIDE etc. symbols removed from editfns.c.
9037
3300e6fd
PE
9038 * keyboard.h (num_input_events): Now uintmax_t.
9039 This is (very slightly) less likely to mess up due to wraparound.
9040 All uses changed.
9041
fd05c7e9
PE
9042 * buffer.c: Integer signedness fixes.
9043 (alloc_buffer_text, enlarge_buffer_text):
9044 Use ptrdiff_t rather than size_t when either will do, as we prefer
9045 signed integers.
9046
903fe15d
PE
9047 * alloc.c: Integer signedness and overflow fixes.
9048 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9049 (__malloc_size_t): Default to size_t, not to int.
9050 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9051 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9052 Prefer ptrdiff_t to size_t when either would do, as we prefer
9053 signed integers.
9054 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9055 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9056 Now const. Initialize with values that are in range even if char
9057 is signed.
9058 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9059 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9060 These functions do the right thing with sizes > 2**32.
9061 (check_depth): Now ptrdiff_t, not int.
9062 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9063 Adjust to new way of storing sizes. Check for size overflow bugs
9064 in rest of code.
9065 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9066 slightly wrong anyway, as it missed one instance of
9067 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9068 (refill_memory_reserve): Omit needless cast to size_t.
9069 (mark_object_loop_halt): Mark as externally visible.
9070
ac82cc6a
PE
9071 * xselect.c: Integer signedness and overflow fixes.
9072 (Fx_register_dnd_atom, x_handle_dnd_message):
9073 Use ptrdiff_t, not size_t, since we prefer signed.
9074 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9075 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9076 x_dnd_atoms_size and x_dnd_atoms_length.
9077
c2d1e36d
PE
9078 * doprnt.c: Prefer signed to unsigned when either works.
9079 * eval.c (verror):
9080 * doprnt.c (doprnt):
9081 * lisp.h (doprnt):
9082 * xdisp.c (vmessage):
9083 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9084 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9085 prefer signed arithmetic to avoid comparison confusion.
9086 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9087 but is a bit tricky.
9088
0e926e56
PE
9089 Assume freestanding C89 headers, string.h, stdlib.h.
9090 * data.c, doprnt.c, floatfns.c, print.c:
9091 Include float.h unconditionally.
9092 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9093 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9094 * regex.c: Likewise for stddef.h, string.h.
9095 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9096 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9097 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9098 (STDC_HEADERS): Remove obsolete defines.
9099 * sysdep.c: Include limits.h unconditionally.
9100
9cfdb3ec
PE
9101 Assume support for memcmp, memcpy, memmove, memset.
9102 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9103 * regex.c (memcmp, memcpy):
9104 Remove; we assume C89 now.
9105
9106 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9107 (__malloc_safe_bcopy): Remove; no longer needed.
9108
cf950e6b 9109 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9110 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9111 well either way, and we prefer signed to unsigned.
9112
dbf38e02
LMI
91132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9114
9115 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9116 closes the connection while we're reading (bug#9182).
9117
d6f0886c 91182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9119
d6f0886c
JD
9120 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9121 are specified (Bug#9168).
24e0f6b1 9122
2eb1f9e6
PE
91232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9124
9125 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9126 Found by GCC static checking and --with-wide-int on a 32-bit host.
9127
22381272 91282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9129
9130 * xdisp.c (compute_display_string_pos): Fix logic of caching
9131 previous display string position. Initialize cached_prev_pos to
9132 -1. Fixes slow-down at the beginning of a buffer.
9133
f25e39b4
EZ
91342011-07-24 Eli Zaretskii <eliz@gnu.org>
9135
9136 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9137 for attrs[LFACE_FONTSET_INDEX].
9138
04c4b52e
PE
91392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9140
9141 * xml.c (parse_region): Remove unused local
9142 that was recently introduced.
9143
c1734fbd
EZ
91442011-07-23 Eli Zaretskii <eliz@gnu.org>
9145
be18c5a5
EZ
9146 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9147 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9148
c1734fbd
EZ
9149 * xdisp.c (move_it_in_display_line_to): Record the best matching
9150 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9151 exit if none of the characters scanned was an exact match.
9152 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9153 when exact match is impossible due to invisible text, and the
9154 lines are truncated.
9155
a258d627
JD
91562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9157
9158 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9159 for OSX >= 10.7.
9160
b6d5a689
EZ
91612011-07-22 Eli Zaretskii <eliz@gnu.org>
9162
0f74f785
EZ
9163 Fix a significant slow-down of cursor motion with C-n, C-p,
9164 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9165 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9166 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9167 (next_element_from_buffer): Call compute_stop_pos_backwards to
9168 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9169 base_level_stop.
9170 (reseat): Don't look for prev_stop, as that could mean a very long
9171 run.
9172 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9173 <cached_disp_overlay_modiff>: Cache for last found display string
9174 position.
551918c1 9175 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9176 about the same buffer in the same area of character positions, and
9177 the buffer wasn't changed since the time the display string
9178 position was cached.
551918c1 9179
b2d0c91a
EZ
91802011-07-22 Eli Zaretskii <eliz@gnu.org>
9181
9182 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9183 is an integer, which is important for empty lines. (Bug#9149)
9184
043604ee
CY
91852011-07-22 Chong Yidong <cyd@stupidchicken.com>
9186
9187 * frame.c (Fmodify_frame_parameters): In tty case, update the
9188 default face if necessary (Bug#4238).
9189
da4adb04
CY
91902011-07-21 Chong Yidong <cyd@stupidchicken.com>
9191
9192 * editfns.c (Fstring_to_char): No need to explain what a character
9193 is in the docstring (Bug#6576).
9194
9abd0532
LMI
91952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9196
9197 * xml.c (parse_region): Make sure we always return a tree.
9198
36881d16
HK
91992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9200
9201 * xml.c (parse_region): If a document contains only comments,
9202 return that, too.
9203
1e98674d
LMI
92042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9205
9206 * xml.c (make_dom): Return comments, too.
9207
590bd467
PE
92082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9209
9210 Port to OpenBSD.
9211 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9212 and the surrounding thread.
9213 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9214 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9215 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9216 timer goes off.
9217 * s/openbsd.h (BROKEN_SIGIO): Define.
9218 * unexelf.c (unexec) [__OpenBSD__]:
9219 Don't update the .mdebug section of the Alpha COFF symbol table.
9220
f41628b2
LMI
92212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9222
9223 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9224 (bug#8460).
9225
b59b67c5
PE
92262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9227
15e3a074
PE
9228 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9229 This fixes some race conditions on the permissions of any newly
9230 created file.
9231
41bed37d
PE
9232 * alloc.c (valid_pointer_p): Use pipe, not open.
9233 This fixes some permissions issues when debugging.
9234
b59b67c5
PE
9235 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9236 If fchown fails to set both uid and gid, try to set just gid,
9237 as that is sometimes allowed. Adjust the file's mode to eliminate
9238 setuid or setgid bits that are inappropriate if fchown fails.
9239
925a6be7
SM
92402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9241
9242 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9243 to compare Lisp_Objects.
9244 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9245 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9246 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9247
52968808
AS
92482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9249
0a6a104b
AS
9250 * lread.c (read_integer): Unread even EOF character.
9251 (read1): Likewise. Properly record start position of symbol.
9252
52968808
AS
9253 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9254 symbol character follows.
9255
9e381cdd
PE
92562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9257
9258 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9259 This works around a problem with the previous change to Fcopy_file.
9260 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9261 and without this change, GCC might complain about discarding
9262 fchown's return value.
9263
b5641435
JB
92642011-07-16 Juanma Barranquero <lekktu@gmail.com>
9265
9266 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9267
a8031457
PE
92682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9269
9270 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9271
dd889327
LMI
92722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9273
750c33f7
LMI
9274 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9275 it's used from the C level.
9276
dd889327
LMI
9277 * process.c: Use the same condition for POLL_FOR_INPUT in both
9278 keyboard.c and process.c (bug#1858).
9279
87e86684
LM
92802011-07-09 Lawrence Mitchell <wence@gmx.li>
9281
9282 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9283 (Fgnutls_boot): Use it.
9284
64348f40
AS
92852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9286
9287 * doc.c (Fsubstitute_command_keys): Revert last change.
9288
1d698799
LMI
92892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9290
f863868c
LMI
9291 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9292 quotes the next character, and doesn't affect other longer
9293 sequences (bug#8935).
9294
1d698799
LMI
9295 * lread.c (syms_of_lread): Clarify that is isn't only
9296 `eval-buffer' and `eval-defun' that's affected by
9297 `lexical-binding' (bug#8460).
9298
aa4b6df6
EZ
92992011-07-15 Eli Zaretskii <eliz@gnu.org>
9300
9301 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9302 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9303
5d856da6
PE
93042011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9305
ad6042bb
PE
9306 Fix minor problems found by static checking.
9307 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9308 (elsz): Now a signed constant, not a size_t var. We prefer signed
9309 types to unsigned, to avoid integer comparison confusion. Without
9310 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9311 "cannot optimize loop, the loop counter may overflow", a symptom
9312 of the confusion.
f00bbb22 9313 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9314 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9315
6468f31c
LMI
93162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9317
49080b10
LMI
9318 * search.c (Fre_search_backward): Mention `case-fold-search' in
9319 all the re_search_* functions (bug#8138).
9320
6468f31c
LMI
9321 * keyboard.c (Fopen_dribble_file): Document when the file is
9322 closed (bug#8056).
9323
c965adc5
EZ
93242011-07-14 Eli Zaretskii <eliz@gnu.org>
9325
df9733bf
EZ
9326 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9327 bidi_cache_idx.
9328
0bb23927
EZ
9329 Support bidi reordering of display and overlay strings.
9330 * xdisp.c (compute_display_string_pos)
9331 (compute_display_string_end): Accept additional argument STRING.
9332 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9333 (reseat_to_string): Initialize bidi_it->string.s and
9334 bidi_it->string.schars.
9335 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9336 NULL (avoids a crash in bidi_paragraph_init).
9337 Initialize itb.string.lstring.
0bb23927
EZ
9338 (init_iterator): Call bidi_init_it only of a valid
9339 buffer position was specified. Initialize paragraph_embedding to
9340 L2R.
9341 (reseat_to_string): Initialize the bidi iterator.
9342 (display_string): If we need to ignore text properties of
9343 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9344 original value of -1 will not work with bidi.)
9345 (compute_display_string_pos): First arg is now struct
9346 `text_pos *'; all callers changed. Support display properties on
9347 Lisp strings.
9348 (compute_display_string_end): Support display properties on Lisp
9349 strings.
9350 (init_iterator, reseat_1, reseat_to_string): Initialize the
9351 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9352 when iterating on a string not from display properties).
640c8776
SM
9353 (compute_display_string_pos, compute_display_string_end):
9354 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9355 arrow keys.
9356 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9357 base_level_stop; instead, set base_level_stop to BEGV.
9358 Fixes crashes in vertical-motion.
0bb23927
EZ
9359 (next_element_from_buffer): Improve commentary for when
9360 the iterator is before prev_stop.
9361 (init_iterator): Initialize bidi_p from the default value of
9362 bidi-display-reordering, not from buffer-local value. Use the
9363 buffer-local value only if initializing for buffer iteration.
9364 (handle_invisible_prop): Support invisible properties on strings
9365 that are being bidi-reordered.
9366 (set_iterator_to_next): Support bidi reordering of C strings and
9367 Lisp strings.
9368 (next_element_from_string): Support bidi reordering of Lisp
9369 strings.
9370 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9371 (display_string): Support display of R2L glyph rows.
9372 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9373 (init_iterator): Don't initialize it->bidi_p for strings
9374 here.
9375 (reseat_to_string): Initialize it->bidi_p for strings here.
9376 (next_element_from_string, next_element_from_c_string)
9377 (next_element_from_buffer): Add xassert's for correspondence
9378 between IT's object being iterated and it->bidi_it.string
9379 structure.
9380 (face_before_or_after_it_pos): Support bidi iteration.
9381 (next_element_from_c_string): Handle the case of the first string
9382 character that is not the first one in the visual order.
9383 (get_visually_first_element): New function, refactored from common
9384 parts of next_element_from_buffer, next_element_from_string, and
9385 next_element_from_c_string.
9386 (tool_bar_lines_needed, redisplay_tool_bar)
9387 (display_menu_bar): Force left-to-right direction. Add a FIXME
9388 comment for making that be controlled by a user option.
9389 (push_it, pop_it): Save and restore the state of the
9390 bidi iterator. Save and restore the bidi_p flag.
9391 (pop_it): Iterate out of display property for string iteration as
9392 well.
9393 (iterate_out_of_display_property): Support iteration over strings.
9394 (handle_single_display_spec): Set up it->bidi_it for iteration
9395 over a display string, and call bidi_init_it.
9396 (handle_single_display_spec, next_overlay_string)
9397 (get_overlay_strings_1, push_display_prop): Set up the bidi
9398 iterator for displaying display or overlay strings.
9399 (forward_to_next_line_start): Don't use the shortcut if
9400 bidi-iterating.
9401 (back_to_previous_visible_line_start): If handle_display_prop
9402 pushed the iterator stack, restore the internal state of the bidi
9403 iterator by calling bidi_pop_it same number of times.
9404 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9405 and we are bidi-iterating, don't decrement the iterator position;
9406 instead, set the first_elt flag in the bidi iterator, to produce
9407 the same effect.
9408 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9409 (push_display_prop): xassert that we are iterating a buffer.
9410 (push_it, pop_it): Save and restore paragraph_embedding member.
9411 (handle_single_display_spec, next_overlay_string)
9412 (get_overlay_strings_1, reseat_1, reseat_to_string)
9413 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9414 correctly. Don't assume unibyte strings are not bidi-reordered.
9415 (compute_display_string_pos)
9416 (compute_display_string_end): Fix handling the case of C string.
9417 (push_it, pop_it): Save and restore from_disp_prop_p.
9418 (handle_single_display_spec, push_display_prop): Set the
9419 from_disp_prop_p flag.
9420 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9421 (pop_it): Call iterate_out_of_display_property only if we are
9422 popping after iteration over a string that came from a display
9423 property. Fix a typo in popping stretch info. Add an assertion
9424 for verifying that the iterator position is in sync with the bidi
9425 iterator.
9426 (handle_single_display_spec, get_overlay_strings_1)
9427 (push_display_prop): Fix initialization of paragraph direction for
9428 string when that of the parent object is not yet determined.
9429 (reseat_1): Call bidi_init_it to resync the bidi
9430 iterator with IT's position. (Bug#7616)
9431 (find_row_edges): If ROW->start.pos gives position
9432 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9433 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9434 Reset the from_disp_prop_p flag.
9435 (SAVE_IT, RESTORE_IT): New macros.
9436 (pos_visible_p, face_before_or_after_it_pos)
9437 (back_to_previous_visible_line_start)
9438 (move_it_in_display_line_to, move_it_in_display_line)
9439 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9440 (try_scrolling, redisplay_window, display_line): Use them when
9441 saving a temporary copy of the iterator and restoring it back.
9442 (back_to_previous_visible_line_start, reseat_1)
9443 (init_iterator): Empty the bidi cache "stack".
9444 (move_it_in_display_line_to): If iterator ended up at
9445 EOL, but we never saw any buffer positions smaller than
9446 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9447 motion in bidi-reordered lines.
9448 (move_it_in_display_line_to): Record prev_method and prev_pos
9449 immediately before the call to set_iterator_to_next. Fixes cursor
9450 motion in bidi-reordered lines with stretch glyphs and strings
9451 displayed in margins. (Bug#8133) (Bug#8867)
9452 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9453 TO_CHARPOS.
640c8776
SM
9454 (pos_visible_p): Support positions in bidi-reordered lines.
9455 Save and restore bidi cache.
0bb23927
EZ
9456
9457 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9458 (bidi_paragraph_info): Delete unused struct.
9459 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9460 (bidi_cache_start): New variable.
9461 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9462 to zero.
9463 (bidi_cache_fetch_state, bidi_cache_search)
9464 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9465 (bidi_cache_find, bidi_peek_at_next_level)
9466 (bidi_level_of_next_char, bidi_find_other_level_edge)
9467 (bidi_move_to_visually_next): Compare cache index with
9468 bidi_cache_start rather than with zero.
9469 (bidi_fetch_char): Accept new argument STRING; all callers
9470 changed. Support iteration over a string. Support strings with
9471 display properties. Support unibyte strings. Fix the type of
9472 `len' according to what STRING_CHAR_AND_LENGTH expects.
9473 (bidi_paragraph_init, bidi_resolve_explicit_1)
9474 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9475 (bidi_level_of_next_char, bidi_move_to_visually_next):
9476 Support iteration over a string.
0bb23927
EZ
9477 (bidi_set_sor_type, bidi_resolve_explicit_1)
9478 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9479 can now be zero (for strings); special values 0 and -1 were
9480 changed to -1 and -2, respectively.
9481 (bidi_char_at_pos): New function.
9482 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9483 Call it instead of FETCH_MULTIBYTE_CHAR.
9484 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9485 initialized to valid values.
9486 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9487 values.
9488 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9489 the test for valid cached positions. Fix the logic for looking up
9490 the sentinel state in the cache. GCPRO the Lisp string we are
9491 iterating.
9492 (bidi_push_it, bidi_pop_it): New functions.
9493 (bidi_initialize): Initialize the bidi cache start stack pointer.
9494 (bidi_cache_ensure_space): New function, refactored from part of
9495 bidi_cache_iterator_state. Don't assume the required size is just
9496 one BIDI_CACHE_CHUNK away.
9497 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9498 (bidi_count_bytes, bidi_char_at_pos): New functions.
9499 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9500 always valid if bidi_cache_idx is valid.
9501 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9502 is valid if it's going to be used.
9503 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9504 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9505 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9506 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9507 (bidi_find_other_level_edge, bidi_cache_start_stack):
9508 All variables related to cache indices are now EMACS_INT.
c965adc5 9509
0bb23927
EZ
9510 * dispextern.h (struct bidi_string_data): New structure.
9511 (struct bidi_it): New member `string'. Make flag members be 1-bit
9512 fields, and put them last in the struct.
640c8776
SM
9513 (compute_display_string_pos, compute_display_string_end):
9514 Update prototypes.
0bb23927
EZ
9515 (bidi_push_it, bidi_pop_it): Add prototypes.
9516 (struct iterator_stack_entry): New members bidi_p,
9517 paragraph_embedding, and from_disp_prop_p.
9518 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9519 (bidi_shelve_cache, bidi_unshelve_cache):
9520 Declare prototypes.
0bb23927
EZ
9521
9522 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9523 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9524 and vector-like objects.
9525
9526 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9527 cache around display iteration.
9528
9529 * window.c (Fwindow_end, window_scroll_pixel_based)
9530 (displayed_window_lines, Frecenter): Save and restore the bidi
9531 cache around display iteration.
9532
3bbd2265
LMI
95332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9534
9535 * editfns.c (Fdelete_region): Clarify the use of the named
9536 parameters (bug#6788).
9537
adc47434
MR
95382011-07-14 Martin Rudalics <rudalics@gmx.at>
9539
9540 * indent.c (Fvertical_motion): Set and restore w->pointm when
9541 saving and restoring the window's buffer (Bug#9006).
9542
837c31f8
LMI
95432011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9544
9545 * editfns.c (Fstring_to_char): Clarify just what is returned
9546 (bug#6576). Text by Eli Zaretskii.
9547
ac389d0c
JB
95482011-07-13 Juanma Barranquero <lekktu@gmail.com>
9549
9550 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9551
0be0ce47
EZ
95522011-07-13 Eli Zaretskii <eliz@gnu.org>
9553
9554 * buffer.c (mmap_find): Fix a typo.
9555
cd18e7e3
JB
95562011-07-13 Johan Bockgård <bojohan@gnu.org>
9557
9558 Fix execution of x selection hooks.
9559 * xselect.c (Qx_lost_selection_functions)
9560 (Qx_sent_selection_functions): New vars.
9561 (syms_of_xselect): DEFSYM them.
9562 (x_handle_selection_request): Pass Qx_sent_selection_functions
9563 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9564 (x_handle_selection_clear,x_clear_frame_selections):
9565 Pass Qx_lost_selection_functions rather than
9566 Vx_lost_selection_functions to Frun_hook_with_args.
9567
47ea7f44
PE
95682011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9569
ac389d0c 9570 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9571 The old code sometimes used this field without initializing it.
9572
47ea7f44
PE
9573 * alloc.c (gc_sweep): Don't read past end of array.
9574 In theory, the old code could also have corrupted Emacs internals,
9575 though it'd be very unlikely.
9576
bc985c87
AS
95772011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9578
9579 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9580 argument. (Bug#4026)
bc985c87 9581
0cf34688
LMI
95822011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9583
b3dadd76
LMI
9584 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9585 key" (bug#4257).
9586
0cf34688
LMI
9587 * window.c (Fset_window_start): Doc fix (bug#4199).
9588 (Fset_window_hscroll): Ditto.
9589
270768cd
PE
95902011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9591
077e3dda 9592 Fix minor new problems caught by GCC 4.6.1.
270768cd 9593 * term.c (init_tty): Remove unused local.
490011a6 9594 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9595 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9596 not used otherwise.
270768cd 9597
b1f58454
CY
95982011-07-12 Chong Yidong <cyd@stupidchicken.com>
9599
9600 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9601
22b9578d
LMI
96022011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9603
6e70ab07
LMI
9604 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9605 are the mini-buffer and the echo area (bug#3320).
9606
22b9578d
LMI
9607 * term.c (init_tty): Remove support for supdup, c10 and perq
9608 terminals, which are no longer supported (bug#1482).
9609
8974cc9f
JB
96102011-07-10 Johan Bockgård <bojohan@gnu.org>
9611
9612 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9613
a560d974
JD
96142011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9615
9616 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9617 for non-popups (Bug#3642).
9618
1dae0f0a
AS
96192011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9620
268c2c36 9621 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9622 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9623 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9624 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9625 * data.c (fmod): Likewise.
9626 * dispnew.c (swap_glyphs_in_rows): Likewise.
9627 * emacs.c (memory_warning_signal): Likewise.
9628 * floatfns.c (float_error): Likewise.
9629 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9630 (otf_open, font_otf_capability, generate_otf_features)
9631 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9632 Likewise.
9633 * image.c (pbm_read_file): Likewise.
9634 * indent.c (string_display_width): Likewise.
9635 * intervals.c (check_for_interval, search_for_interval)
9636 (inc_interval_count, count_intervals, root_interval)
9637 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9638 * lread.c (defalias): Likewise.
268c2c36 9639 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9640 * regex.c (set_image_of_range_1, set_image_of_range)
9641 (regex_grow_registers): Likewise.
9642 * sysdep.c (strerror): Likewise.
9643 * termcap.c (valid_filename_p, tprint, main): Likewise.
9644 * tparam.c (main): Likewise.
9645 * unexhp9k800.c (run_time_remap, save_data_space)
9646 (update_file_ptrs, read_header, write_header, calculate_checksum)
9647 (copy_file, copy_rest, display_header): Likewise.
9648 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9649 Likewise.
9650 * xdisp.c (check_it): Likewise.
9651 * xfaces.c (register_color, unregister_color, unregister_colors):
9652 Likewise.
9653 * xfns.c (print_fontset_result): Likewise.
9654 * xrdb.c (member, fatal, main): Likewise.
9655
99033785
PE
96562011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9657
9658 Fix minor problems found by static checking (Bug#9031).
9659 * chartab.c (char_table_set_range, map_sub_char_table):
9660 Remove unused locals.
9661 (uniprop_table): Now static.
9662 * composite.c (_work_char): Remove unused static var.
9663
9cb2ac56
JB
96642011-07-09 Juanma Barranquero <lekktu@gmail.com>
9665
9666 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9667
f25661f0
JD
96682011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9669
9670 * gtkutil.c (qttip_cb): Remove code without function.
9671
8278c4fe
EZ
96722011-07-09 Eli Zaretskii <eliz@gnu.org>
9673
9674 * w32.c (pthread_sigmask): New stub.
9675
1692ae2d 96762011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9677
8a6ebd58 9678 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9679 sigprocmask is portable only for single-threaded applications, and
9680 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9681 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9682 (LIBES): Use it.
9683 * callproc.c (Fcall_process):
9684 * process.c (create_process):
9685 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9686 Use pthread_sigmask, not sigprocmask.
123403e4 9687
1b854618
JD
96882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9689
9690 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9691 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9692 wrong (Bug#8591).
9693
3fe4b549
JD
96942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9695
0ce7e563
JD
9696 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9697 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9698 (xg_hide_tooltip): Fix comment.
9699
3fe4b549
JD
9700 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9701 in registerServicesMenuSendTypes.
9702 (validRequestorForSendType): Don't check ns_return_types.
9703
9704 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9705 ns_return_type.
9706
5df75e47
JR
97072011-07-08 Jason Rumney <jasonr@gnu.org>
9708
22610910
JR
9709 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9710 SH_SHOW for hidden windows (Bug#5482).
9711
5df75e47
JR
9712 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9713 frame struct members of non-existent frames (Bug#6284).
9714
699c10bd
JD
97152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9716
4393663b
JD
9717 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9718 variable firstTime not needed on OSX >= 10.6.
9719 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9720 >= 10.5. Use setKnobProportion, setDoubleValue.
9721
9722 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9723 (MAC_OS_X_VERSION_10_5): Define if not defined.
9724 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9725 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9726 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9727
9728 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9729 cString and lossyCString on OSX >= 10.4.
4393663b 9730
58179cce 9731 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9732 sizeToFit on OSX >= 10.2.
9733
9734 * nsimage.m (allocInitFromFile): Don't use deprecated method
9735 bestRepresentationForDevice on OSX >= 10.6.
9736
9737 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9738 to avoid warning.
9739
9740 * emacs.c: Declare unexec_init_emacs_zone.
9741
a63e0781
JD
9742 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9743
699c10bd
JD
9744 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9745
9746 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9747 on svcsMenu (Bug#8842).
9748
9749 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9750 ns_return_types.
9751 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9752
9753 * nsterm.m (QUTF8_STRING): Declare.
9754 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9755 (validRequestorForSendType): Return type is (id).
9756 Change indexOfObjectIdenticalTo to indexOfObject.
9757 Check if we have local selection before returning self (Bug#8842).
9758 (writeSelectionToPasteboard): Put local selection into paste board
9759 if we have a local selection (Bug#8842).
9760 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9761
9762 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9763 (ns_get_local_selection): Declare.
9764
54e10184
LMI
97652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9766
9888ff71
LMI
9767 * keymap.c (describe_map_tree): Don't insert a double newline at
9768 the end of the buffer (bug#1169) and return whether we inserted
9769 something.
9770
54e10184
LMI
9771 * callint.c (Fcall_interactively): Change "reading args" to
9772 "providing args" to try to clarify what it does (bug#1010).
9773
15fa4783
KH
97742011-07-07 Kenichi Handa <handa@m17n.org>
9775
9776 * composite.c (composition_compute_stop_pos): Ignore a static
9777 composition starting before CHARPOS (Bug#8915).
9778
9779 * xdisp.c (handle_composition_prop): Likewise.
9780
a8815b00
EZ
97812011-07-07 Eli Zaretskii <eliz@gnu.org>
9782
9783 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9784 (Bug#9015)
9785
ef7b981d 97862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9787
9788 * character.h (unicode_category_t): New enum type.
9789
9790 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9791 (Qchar_code_property_table): New variable.
9792 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9793 (UNIPROP_COMPRESSED_FORM_P): New macros.
9794 (char_table_ascii): Uncompress the compressed values.
9795 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9796 Uncompress the compressed values.
ac389d0c 9797 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9798 (char_table_ref_and_range): Uncompress the compressed values.
9799 (sub_char_table_set): New arg is_uniprop. Callers changed.
9800 Uncompress the compressed values.
9801 (sub_char_table_set_range): Args changed. Callers changed.
9802 (char_table_set_range): Adjuted for the above change.
9803 (map_sub_char_table): Delete args default_val and parent. Add arg
9804 top. Give decoded values to a Lisp function.
640c8776 9805 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9806 values to a Lisp function. Gcpro more variables.
9807 (uniprop_table_uncompress)
9808 (uniprop_decode_value_run_length): New functions.
9809 (uniprop_decoder, uniprop_decoder_count): New variables.
9810 (uniprop_get_decoder, uniprop_encode_value_character)
9811 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9812 New functions.
9813 (uniprop_encoder, uniprop_encoder_count): New variables.
9814 (uniprop_get_encoder, uniprop_table)
9815 (Funicode_property_table_internal, Fget_unicode_property_internal)
9816 (Fput_unicode_property_internal): New functions.
9817 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9818 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9819 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9820 char-code-property-alist.
9821
640c8776 9822 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9823 Vunicode_category_table.
9824
640c8776 9825 * font.c (font_range): Adjust for the change of
c805dec0
KH
9826 Vunicode_category_table.
9827
76b397fb
DN
98282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9829
9830 * m/iris4d.h: Remove file, move contents ...
9831 * s/irix6-5.h: ... here.
9832
22b4128e
PE
98332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9834
9835 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9836 * alloc.c (mark_buffer):
9837 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9838 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9839 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9840 This isn't true in general, and it's particularly not true
9841 if Emacs is configured with --with-wide-int.
9842 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9843 New macros, used in the buffer.c change.
9844
869795d6
JD
98452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9846
9847 * xsettings.c: Use both GConf and GSettings if both are available.
9848 (store_config_changed_event): Add comment.
9849 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9850 (store_tool_bar_style_changed): New functions.
5e617bc2 9851 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9852 (struct xsettings): Move font inside HAVE_XFT.
9853 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9854 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9855 Move inside HAVE_XFT.
640c8776 9856 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9857 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9858 also.
9859 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9860 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9861 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9862 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9863 (parse_settings): Move check for font inside HAVE_XFT.
9864 (read_settings, apply_xft_settings): Add comment.
9865 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9866 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9867 call store_font_name_changed.
9868 (xft_settings_event): Add comment.
9869 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9870 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9871 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9872 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9873 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9874 (xsettings_get_system_font, xsettings_get_system_normal_font):
9875 Add comment.
869795d6 9876
d8ed26bd
PE
98772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9878
9879 Random fixes. E.g., (random) never returned negative values.
9880 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9881 subseconds part to the entropy, as that's a bit more random.
9882 Prefer signed to unsigned, since the signedness doesn't matter and
9883 in general we prefer signed. When given a limit, use a
9884 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9885 latter isn't right if USE_2_TAGS_FOR_INTS.
9886 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9887 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9888
cabf1cac
SM
98892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9890
9891 * textprop.c (text_property_stickiness):
9892 Obey Vtext_property_default_nonsticky.
9893 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9894 * w32fns.c (syms_of_w32fns):
9895 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9896
6e9b2be9
PE
98972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9898
9899 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9900 This is more efficient than Ffile_directory_p and avoids a minor race.
9901
90186c68
LMI
99022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9903
7c301272
LMI
9904 * buffer.c (Foverlay_put): Say what the return value is
9905 (bug#7835).
9906
c4f2d8d4
LMI
9907 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9908 is a directory before asking whether to use the file name
9909 (bug#7564).
ad637907
LMI
9910 (barf_or_query_if_file_exists): Make the "File is a directory"
9911 error be more correct.
c4f2d8d4 9912
90186c68
LMI
9913 * fns.c (Frequire): Remove the mention of the .gz files, since
9914 that's installation-specific, but keep the mention of
9915 `get-load-suffixes'.
9916
da64016e
PE
99172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9918
9919 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9920 Report string overflow if the output is too long.
9921
7d47b580
JB
99222011-07-04 Juanma Barranquero <lekktu@gmail.com>
9923
a555cb87
JB
9924 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9925 (syms_of_gnutls): Remove duplicate DEFSYM for
9926 Qgnutls_bootprop_verify_hostname_error, an error for
9927 Qgnutls_bootprop_verify_error (which is no longer used).
9928
7d47b580
JB
9929 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9930 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9931 Also (re)move comments that are misplaced or no longer relevant.
9932
1e49bfab
LMI
99332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9934
9935 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9936
1485f4c0
CY
99372011-07-03 Chong Yidong <cyd@stupidchicken.com>
9938
9939 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9940 and background color parameters if they have been changed.
9941
a9ab721e
LMI
99422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9943
9944 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9945
cf7cff57
PE
99462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9947
2e13213d
PE
9948 * xsettings.c (SYSTEM_FONT): Define only when used.
9949 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9950
cf7cff57
PE
9951 * keymap.c (access_keymap_1): Now static.
9952
7a8e04f7
CY
99532011-07-02 Chong Yidong <cyd@stupidchicken.com>
9954
9955 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9956 leave any prefix arg for the up event (Bug#1586).
9957
61352f62
LMI
99582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9959
69bb1ef7
LMI
9960 * lread.c (syms_of_lread): Mention single symbols defined by
9961 `defvar' or `defconst' (bug#7154).
9962
61352f62 9963 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9964 (Frequire): Mention get-load-suffixes.
61352f62 9965
28545e04
MR
99662011-07-02 Martin Rudalics <rudalics@gmx.at>
9967
9968 * window.h (window): Remove clone_number slot.
9969 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9970 Remove.
9971 (make_parent_window, make_window, saved_window)
9972 (Fset_window_configuration, save_window_save): Don't deal with
9973 clone numbers.
9974 * buffer.c (Qclone_number): Remove declaration.
9975 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9976
3349e122
SM
99772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9978
9979 Add multiple inheritance to keymaps.
9980 * keymap.c (Fmake_composed_keymap): New function.
9981 (Fset_keymap_parent): Simplify.
9982 (fix_submap_inheritance): Remove.
9983 (access_keymap_1): New function extracted from access_keymap to handle
9984 embedded parents and handle lists of maps.
9985 (access_keymap): Use it.
9986 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9987 (Fcopy_keymap): Handle embedded parents.
9988 (Fcommand_remapping, define_as_prefix): Simplify.
9989 (Fkey_binding): Simplify.
9990 (syms_of_keymap): Move minibuffer-local-completion-map,
9991 minibuffer-local-filename-completion-map,
9992 minibuffer-local-must-match-map, and
9993 minibuffer-local-filename-must-match-map to Elisp.
9994 (syms_of_keymap): Defsubr make-composed-keymap.
9995 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9996 (parse_menu_item): Trivial simplification.
9997
3279eb87
GM
99982011-07-01 Glenn Morris <rgm@gnu.org>
9999
10000 * Makefile.in (SETTINGS_LIBS): Fix typo.
10001
4550efdf
KI
100022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
10003
10004 * coding.c (Fencode_coding_string): Record the last coding system
10005 used, as the function doc string says (bug#8738).
10006
0949d2b6
JD
100072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10008
10009 * xsettings.c (store_monospaced_changed): Take new font as arg and
10010 check for change against current_mono_font.
10011 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10012 (emacs_settings_constructor, emacs_settings_get_property)
10013 (emacs_settings_set_property, emacs_settings_class_init)
10014 (emacs_settings_init, gsettings_obj): Remove.
10015 (something_changedCB): New function for HAVE_GSETTINGS.
10016 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10017 with value as argument.
10018 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10019 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10020 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10021 "changed".
10022
10023 * xgselect.c: Add defined (HAVE_GSETTINGS).
10024 (xgselect_initialize): Ditto.
10025
10026 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10027 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10028 xg_select.
10029
bbc6b304
PE
100302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10031
10032 * eval.c (struct backtrace): Simplify and port the data structure.
10033 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10034 signed bit field, as this assumption is not portable and it makes
10035 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10036 "char debug_on_exit : 1" as this is not portable either; instead,
10037 use the portable "unsigned int debug_on_exit : 1". Remove unused
10038 member evalargs. Remove obsolete comments about cc bombing out.
10039
9851bfc5
JD
100402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10041
51bb811f 10042 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10043 Let HAVE_GSETTINGS override HAVE_GCONF.
10044 (store_monospaced_changed): New function.
10045 (EMACS_SETTINGS): A new type derived from GObject to handle
10046 GSettings notifications.
10047 (emacs_settings_constructor, emacs_settings_get_property)
10048 (emacs_settings_set_property, emacs_settings_class_init):
10049 New functions.
10050 (gsettings_client, gsettings_obj): New variables.
10051 (GSETTINGS_SCHEMA): New define.
10052 (something_changedCB): Call store_monospaced_changed.
10053 (init_gsettings): New function.
10054 (xsettings_initialize): Call init_gsettings.
10055 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10056 to NULL.
10057
640c8776 10058 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10059 GCONF_CFLAGS/LIBS.
10060
5386012d
MR
100612011-06-29 Martin Rudalics <rudalics@gmx.at>
10062
10063 * window.c (resize_root_window, grow_mini_window)
10064 (shrink_mini_window): Rename Qresize_root_window to
10065 Qwindow_resize_root_window and Qresize_root_window_vertically to
10066 Qwindow_resize_root_window_vertically.
10067
f13e0b08
PE
100682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10069
10070 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10071
94515237
JB
100722011-06-27 Juanma Barranquero <lekktu@gmail.com>
10073
10074 * makefile.w32-in: Redesign dependencies so they reflect more
10075 clearly which files are directly included by each source file,
10076 and not through other includes.
10077
e43b6e43
MR
100782011-06-27 Martin Rudalics <rudalics@gmx.at>
10079
10080 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10081 (sort_overlays, overlay_strings): When an overlay's clone number
10082 matches the window's clone number process the overlay even if
10083 the overlay's window property doesn't match the current window.
10084
d68443dc
MR
10085 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10086 (Fwindow_hchild): Rename to Fwindow_left_child.
10087 (Fwindow_next): Rename to Fwindow_next_sibling.
10088 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10089 (resize_window_check): Rename to window_resize_check.
10090 (resize_window_apply): Rename to window_resize_apply.
10091 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10092 (Fdelete_other_windows_internal, resize_frame_windows)
10093 (Fsplit_window_internal, Fdelete_window_internal)
10094 (grow_mini_window, shrink_mini_window)
10095 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10096
c7e73be5
JD
100972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10098
10099 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10100 (emacs_fixed_set_min_size): Remove.
10101 (emacs_fixed_new): Take frame as argument.
10102
10103 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10104 (_EmacsFixedPrivate): Remove minwidth/height.
10105 Add struct frame *f.
10106 (emacs_fixed_init): Initialize priv->f.
10107 (get_parent_class, emacs_fixed_set_min_size): Remove.
10108 (emacs_fixed_new): Set priv->f to argument.
10109 (emacs_fixed_get_preferred_width)
10110 (emacs_fixed_get_preferred_height): Use min_width/height from
10111 frames size_hint to set minimum and natural (Bug#8919).
10112 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10113 and use min_width/height from frames size_hint to set
10114 min_width/height (Bug#8919).
10115
10116 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10117 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10118 Fix indentation.
c7e73be5 10119
cf99dcf8
EZ
101202011-06-26 Eli Zaretskii <eliz@gnu.org>
10121
10122 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10123 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10124 called at ZV.
10125
029529ac
CY
101262011-06-26 Chong Yidong <cyd@stupidchicken.com>
10127
10128 * process.c (wait_reading_process_output): Bypass select if
10129 waiting for a cell while ignoring keyboard input, and input is
10130 pending. Suggested by Jan Djärv (Bug#8869).
10131
7a7ef429
PE
101322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10133
10134 Use gnulib's dup2 module instead of rolling our own.
10135 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10136
11fdef7d 101372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10138
10139 * dispnew.c (scrolling_window): Before scrolling, turn off a
10140 mouse-highlight in the window being scrolled.
10141
cd3520a4
JB
101422011-06-24 Juanma Barranquero <lekktu@gmail.com>
10143
10144 Move DEFSYM to lisp.h and use everywhere.
10145
10146 * character.h (DEFSYM): Move declaration...
10147 * lisp.h (DEFSYM): ...here.
10148
10149 * gnutls.c:
10150 * minibuf.c:
10151 * w32menu.c:
10152 * w32proc.c:
10153 * w32select.c: Don't include character.h.
10154
10155 * alloc.c (syms_of_alloc):
10156 * buffer.c (syms_of_buffer):
10157 * bytecode.c (syms_of_bytecode):
10158 * callint.c (syms_of_callint):
10159 * casefiddle.c (syms_of_casefiddle):
10160 * casetab.c (init_casetab_once):
10161 * category.c (init_category_once, syms_of_category):
10162 * ccl.c (syms_of_ccl):
10163 * cmds.c (syms_of_cmds):
10164 * composite.c (syms_of_composite):
10165 * dbusbind.c (syms_of_dbusbind):
10166 * dired.c (syms_of_dired):
10167 * dispnew.c (syms_of_display):
10168 * doc.c (syms_of_doc):
10169 * editfns.c (syms_of_editfns):
10170 * emacs.c (syms_of_emacs):
10171 * eval.c (syms_of_eval):
10172 * fileio.c (syms_of_fileio):
10173 * fns.c (syms_of_fns):
10174 * frame.c (syms_of_frame):
10175 * fringe.c (syms_of_fringe):
10176 * insdel.c (syms_of_insdel):
10177 * keymap.c (syms_of_keymap):
10178 * lread.c (init_obarray, syms_of_lread):
10179 * macros.c (syms_of_macros):
10180 * msdos.c (syms_of_msdos):
10181 * print.c (syms_of_print):
10182 * process.c (syms_of_process):
10183 * search.c (syms_of_search):
10184 * sound.c (syms_of_sound):
10185 * syntax.c (init_syntax_once, syms_of_syntax):
10186 * terminal.c (syms_of_terminal):
10187 * textprop.c (syms_of_textprop):
10188 * undo.c (syms_of_undo):
10189 * w32.c (globals_of_w32):
10190 * window.c (syms_of_window):
10191 * xdisp.c (syms_of_xdisp):
10192 * xfaces.c (syms_of_xfaces):
10193 * xfns.c (syms_of_xfns):
10194 * xmenu.c (syms_of_xmenu):
10195 * xsettings.c (syms_of_xsettings):
10196 * xterm.c (syms_of_xterm): Use DEFSYM.
10197
4228cf16
TZ
101982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10199
cd3520a4 10200 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10201
7fcccf1e
PE
102022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10203
7efb4e0e
PE
10204 Integer and buffer overflow fixes (Bug#8873).
10205
ff5844ad
PE
10206 * print.c (printchar, strout): Check for string overflow.
10207 (PRINTPREPARE, printchar, strout):
10208 Don't set size unless allocation succeeds.
10209
90532f02
PE
10210 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10211 for sizes. Check for string overflow more accurately.
10212 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10213
6d84508d
PE
10214 * macros.c: Integer and buffer overflow fixes.
10215 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10216 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10217 Use ptrdiff_t, not int, for sizes.
10218 Don't increment bufsize until after realloc succeeds.
10219 Check for size-calculation overflow.
10220 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10221
437b2cb4
PE
10222 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10223
8b9ac8b4
PE
10224 * lread.c: Integer overflow fixes.
10225 (read_integer): Radix is now EMACS_INT, not int,
10226 to improve quality of diagnostics for out-of-range radices.
10227 Calculate buffer size correctly for out-of-range radices.
10228 (read1): Check for integer overflow in radices, and in
10229 read-circle numbers.
82cb60d3
PE
10230 (read_escape): Avoid int overflow.
10231 (Fload, openp, read_buffer_size, read1)
10232 (substitute_object_recurse, read_vector, read_list, map_obarray):
10233 Use ptrdiff_t, not int, for sizes.
10234 (read1): Use EMACS_INT, not int, for sizes.
20270765 10235 Check for size overflow.
8b9ac8b4 10236
7fcccf1e
PE
10237 * image.c (cache_image): Check for size arithmetic overflow.
10238
bfbbd7e7
PE
10239 * lread.c: Integer overflow issues.
10240 (saved_doc_string_size, saved_doc_string_length)
10241 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10242 Now ptrdiff_t, not int.
10243 (read1): Don't assume doc string length fits in int. Check for
10244 out-of-range doc string lengths.
10245 (read_list): Don't assume file position fits in int.
39019e54 10246 (read_escape): Check for hex character overflow.
bfbbd7e7 10247
4e323265
LL
102482011-06-22 Leo Liu <sdl.web@gmail.com>
10249
10250 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10251 Move to minibuffer.el.
10252
85fece3e
PE
102532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10254
20b84ce9 10255 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10256 The following patches are for when GLYPH_DEBUG && !XASSERT.
10257 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10258 * dispnew.c (flush_stdout):
10259 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10260 Mark as externally visible.
10261 * dispnew.c (check_window_matrix_pointers): Now static.
10262 * dispnew.c (window_to_frame_vpos):
10263 * xfns.c (unwind_create_frame):
10264 * xterm.c (x_check_font): Remove unused local.
10265 * scroll.c (CHECK_BOUNDS):
10266 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10267 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10268 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10269 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10270 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10271 Now static.
10272 (debug_method_add): Use va_list and vsprintf rather than relying
10273 on undefined behavior with wrong number of arguments.
10274 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10275 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10276 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10277 since we're not interested in debugging glyphs with old libraries.
10278 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10279 GCC 4.6.0's static checking.
10280
0766b489
PE
102812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10282
31fd4b32
PE
10283 Integer overflow and signedness fixes (Bug#8873).
10284 A few related buffer overrun fixes, too.
10285
b79e8648
PE
10286 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10287
0766b489
PE
10288 * dispextern.h (struct face.stipple):
10289 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10290 (x_bitmap_mask, x_allocate_bitmap_record)
10291 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10292 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10293 (x_create_bitmap_from_xpm_data):
10294 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10295 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10296 (.bitmaps_last):
10297 * xfaces.c (load_pixmap):
10298 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10299 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10300 (.bitmaps_last, struct x_output.icon_bitmap):
10301 Use ptrdiff_t, not int, for bitmap indexes.
10302 (x_allocate_bitmap_record): Check for size overflow.
10303 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10304
b081724f
PE
10305 Use ptrdiff_t, not int, for overlay counts.
10306 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10307 * editfns.c (overlays_around, get_pos_property):
10308 * textprop.c (get_char_property_and_overlay):
10309 * xdisp.c (next_overlay_change, note_mouse_highlight):
10310 * xfaces.c (face_at_buffer_position):
21514da7
PE
10311 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10312 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10313 (Fnext_overlay_change, Fprevious_overlay_change)
10314 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10315 Use ptrdiff_t, not int, for sizes.
21514da7 10316 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10317
3de73e5e
PE
10318 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10319
2606c57b
PE
10320 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10321 (x_session_initialize): Do not assume string length fits in int.
10322
aaafe47a
PE
10323 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10324 This is unlikely, but can occur if DPI is outlandish.
10325
2674ddc8 10326 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10327 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10328
28154962
PE
10329 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10330 * xrdb.c (magic_file_p, search_magic_path):
10331 Omit last arg SUFFIX; it was always 0. All callers changed.
10332 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10333
7de51af5
PE
10334 * xfont.c (xfont_match): Avoid need for strlen.
10335
25ed6cc3
PE
10336 * xfns.c: Don't assume strlen fits in int.
10337 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10338
4eab31dd
PE
10339 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10340 not unsigned long, as we prefer signed integers. All callers changed.
10341 Detect integer overflow in repeat count.
10342 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10343 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10344
171e2a58
PE
10345 * termcap.c: Don't assume sizes fit in int and never overflow.
10346 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10347 (gobble_line): Check for size-calculation overflow.
10348
ad39faca 10349 * minibuf.c (Fread_buffer):
6e5bb2dc 10350 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10351 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10352 Don't assume string length fits in int.
10353
52c61c22 10354 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10355 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10356
b5b8c9e5
PE
10357 * font.c: Don't assume string length fits in int.
10358 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10359 Use ptrdiff_t, not int.
ccd6111c
PE
10360 (font_intern_prop): Don't assume string length fits in int.
10361 Don't assume integer property fits in fixnum.
10362 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10363
882f0d81 10364 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10365 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10366 Reformulate so as not to need the command string.
10367 Invoke gzip -cd rather than gunzip, as it's more portable.
10368 (lock_info_type, lock_file_1, lock_file):
10369 Don't assume pid_t and time_t fit in unsigned long.
10370 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10371 (current_lock_owner): Prefer signed type for sizes.
10372 Use memcpy, not strncpy, where memcpy is what is really wanted.
10373 Don't assume (via atoi) that time_t and pid_t fit in int.
10374 Check for time_t and/or pid_t out of range, e.g., via a network share.
10375 Don't alloca where an auto var works fine.
10376
93f4cf88
PE
10377 * fileio.c: Fix some integer overflow issues.
10378 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10379 Don't assume string length fits in int.
10380 (directory_file_name): Don't assume string length fits in long.
10381 (make_temp_name): Don't assume pid fits in int, or that its print
10382 length is less than 20.
10383
f3e92b69
PE
10384 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10385
1bfdaf10
PE
10386 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10387
35016e9a
PE
10388 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10389
3d1e65a1
PE
10390 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10391 We prefer signed integers, even for size calculations.
10392
0b963a93
PE
10393 * emacs.c: Don't assume string length fits in 'int'.
10394 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10395 (main): Don't invoke strlen when not needed.
10396
573f4b54
PE
10397 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10398 (XD_DEBUG_MESSAGE): Don't waste a byte.
10399
989f33ba
PE
10400 * callproc.c (getenv_internal_1, getenv_internal)
10401 (Fgetenv_internal):
965d34eb
PE
10402 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10403
e4d29b33
PE
10404 * lread.c (invalid_syntax): Omit length argument.
10405 All uses changed. This doesn't fix a bug, but it simplifies the
10406 code away from its former Hollerith-constant appearance, and it's
10407 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10408 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10409
eb49b136
PE
10410 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10411 This didn't break anything, but it didn't help either.
10412 It's confusing to put a bogus integer in a place where the actual
10413 value does not matter.
9f62aeb1 10414 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10415 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10416
15375a22
PE
10417 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10418 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10419 implementation.
b61cc01c
PE
10420 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10421 We prefer signed types, and the value cannot exceed the EMACS_INT
10422 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10423 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10424 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10425 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10426
53b2623d
PE
10427 * indent.c (sane_tab_width): New function.
10428 (current_column, scan_for_column, Findent_to, position_indentation)
10429 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10430 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10431
51cab52b 10432 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10433
f2ed8a70
PE
10434 * lisp.h (lint_assume): New macro.
10435 * composite.c (composition_gstring_put_cache):
10436 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10437
abe80cc6
PE
10438 * editfns.c, insdel.c:
10439 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10440
b02c740e
PE
10441 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10442
ebc96716
PE
10443 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10444
b4e50fa0 10445 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10446 Use much-faster test for byte-length change.
311d5d7c 10447 Don't assume string byte-length fits in 'int'.
a4cf38e4 10448 Check that character arg fits in 'int'.
85461888 10449 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10450
c0c1ee9f
PE
10451 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10452
a498d7f4
PE
10453 * fns.c (concat): Catch string overflow earlier.
10454 Do not rely on integer wraparound.
10455
51cab52b
PE
10456 * dispextern.h (struct it.overlay_strings_charpos)
10457 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10458 * xdisp.c (forward_to_next_line_start)
10459 (back_to_previous_visible_line_start)
10460 (reseat_at_next_visible_line_start, next_element_from_buffer):
10461 Don't arbitrarily truncate the value of 'selective' to int.
10462
76031fad
PE
10463 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10464
5eb55db9
PE
10465 * composite.c: Don't truncate sizes to 'int'.
10466 (composition_gstring_p, composition_reseat_it)
10467 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10468 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10469 not EMACS_UINT, for indexes.
5eb55db9 10470
0703a717
PE
10471 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10472
d6202519
PE
10473 * buffer.c: Include <verify.h>.
10474 (struct sortvec.priority, struct sortstr.priority):
8961a454 10475 Now EMACS_INT, not int.
c20998a7 10476 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10477 (struct sortstr.size, record_overlay_string)
10478 (struct sortstrlist.size, struct sortlist.used):
10479 Don't truncate size to int.
10480 (record_overlay_string): Check for size-calculation overflow.
d6202519 10481 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10482
d5a19415
JM
104832011-06-22 Jim Meyering <meyering@redhat.com>
10484
029529ac 10485 Don't leak an XBM-image-sized buffer
d5a19415
JM
10486 * image.c (xbm_load): Free the image buffer after using it.
10487
a9041e6c
PE
104882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10489
10490 Port to Sun C.
10491 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10492 that Sun C diagnosed.
10493 * fns.c (secure_hash): Fix pointer signedness issue.
10494 * intervals.c (static_offset_intervals): New function.
10495 (offset_intervals): Use it.
10496
7f3f739f
LL
104972011-06-21 Leo Liu <sdl.web@gmail.com>
10498
10499 * deps.mk (fns.o):
10500 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10501 sha512.h.
10502
10503 * fns.c (secure_hash): Rename from crypto_hash_function and change
10504 the first arg to accept symbols.
5b66d427 10505 (Fsecure_hash): New primitive.
7f3f739f
LL
10506 (syms_of_fns): New symbols.
10507
76147d94
DD
105082011-06-20 Deniz Dogan <deniz@dogan.se>
10509
10510 * process.c (Fset_process_buffer): Clarify return value in
10511 docstring.
10512
7d7d0045
CY
105132011-06-18 Chong Yidong <cyd@stupidchicken.com>
10514
10515 * dispnew.c (add_window_display_history): Use BVAR.
10516
10517 * xdisp.c (debug_method_add): Use BVAR.
10518 (check_window_end, dump_glyph_matrix, dump_glyph)
10519 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10520
10521 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10522 Likewise.
10523
10524 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10525 check till after the cache is created in init_frame_faces.
10526
ff2bc410
SM
105272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10528
10529 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10530
28177add
PE
105312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10532
dd3482fe
PE
10533 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10534 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10535 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10536
393d71f3 10537 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10538 * fileio.c (Finsert_file_contents):
10539 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10540 Remove the old (too-loose) buffer overflow checks.
10541 They weren't needed, since make_gap checks for buffer overflow.
10542 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10543 The old code merely checked for Emacs fixnum overflow, and relied
10544 on undefined (wraparound) behavior. The new code avoids undefined
10545 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10546
2e6813b0 10547 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10548 Tune. Don't use wider integers than needed. Don't use alloca.
10549 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10550
599a9e4f
PE
10551 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10552
99561444
PE
10553 * insdel.c, lisp.h (buffer_overflow): New function.
10554 (insert_from_buffer_1, replace_range, replace_range_2):
10555 * insdel.c (make_gap_larger):
10556 * editfns.c (Finsert_char):
10557 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10558
28177add
PE
10559 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10560
e69dafad
PE
105612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10562
4baa020d 10563 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10564
b1c46f02
PE
10565 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10566 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10567
e69dafad
PE
10568 * fileio.c: Don't assume EMACS_INT fits in off_t.
10569 (emacs_lseek): New static function.
10570 (Finsert_file_contents, Fwrite_region): Use it.
10571 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10572
566684ea
PE
10573 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10574
e6966cd6
PE
10575 * fns.c: Don't overflow int when computing a list length.
10576 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10577 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10578 truncation on 64-bit hosts. Check for QUIT every
10579 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10580 faster and is responsive enough.
10581 (Flength): Report an error instead of overflowing an integer.
10582 (Fsafe_length): Return a float if the value is not representable
10583 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10584 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10585 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10586
dd0b0efb
PE
10587 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10588 (header_size, word_size): New constants.
10589 (allocate_vectorlike): Don't check size overflow here.
10590 (allocate_vector): Check it here instead, since this is the only
10591 caller of allocate_vectorlike that could cause overflow.
10592 Check that the new vector's length is representable as a fixnum.
10593
86fe5cfe
PE
10594 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10595 The previous code was bogus. For example, next_almost_prime (32)
10596 returned 39, which is undesirable as it is a multiple of 3; and
10597 next_almost_prime (24) returned 25, which is a multiple of 5 so
10598 why was the code bothering to check for multiples of 7?
10599
80e88859
PE
10600 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10601
4a2f0ad6
PE
10602 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10603
f66c7cf8
PE
10604 Variadic C functions now count arguments with ptrdiff_t.
10605 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10606 Back then I didn't know that the Emacs coding style prefers signed int.
10607 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10608 were being counted with int, which may truncate counts on 64-bit
10609 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10610 * lisp.h (struct Lisp_Subr.function.aMANY)
10611 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10612 Arg counts are now ptrdiff_t, not size_t.
10613 All variadic functions and their callers changed accordingly.
10614 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10615 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10616 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10617 * callint.c (Fcall_interactively): Check arg count for overflow,
10618 to avoid potential buffer overrun. Use signed char, not 'int',
10619 for 'varies' array, so that we needn't bother to check its size
10620 calculation for overflow.
10621 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10622 * eval.c (apply_lambda):
10623 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10624 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10625 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10626
a1759b76
PE
10627 * callint.c (Fcall_interactively): Don't use index var as event count.
10628
d96be9fc
PE
10629 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10630 * mem-limits.h (SIZE): Remove; no longer used.
10631
a690a978 10632 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10633
578c21e6
PE
10634 Remove unnecessary casts.
10635 * xterm.c (x_term_init):
10636 * xfns.c (x_set_border_pixel):
10637 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10638 These aren't needed now that we assume ANSI C.
10639
96f53c6c
PE
10640 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10641 It's more likely to cause problems (due to unsigned overflow)
10642 than to cure them.
10643
83c77d31
PE
10644 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10645
ee2079f1
PE
10646 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10647
6da65536
PE
10648 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10649
7147c4a4
PE
10650 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10651
193e32d9
PE
10652 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10653
e5533da6
PE
10654 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10655
9910e595
PE
10656 GLYPH_CODE_FACE returns EMACS_INT, not int.
10657 * dispextern.h (merge_faces):
10658 * xfaces.c (merge_faces):
01103c44
PE
10659 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10660 Don't assume EMACS_INT fits in int.
9910e595 10661
2638320e
PE
10662 * character.h (CHAR_VALID_P): Remove unused parameter.
10663 * fontset.c, lisp.h, xdisp.c: All uses changed.
10664
045eb8d9
PE
10665 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10666
c1f134b5
PE
10667 * fns.c (concat): Minor tuning based on overflow analysis.
10668 This doesn't fix any bugs. Use int to hold character, instead
10669 of constantly refetching from Emacs object. Use XFASTINT, not
10670 XINT, for value known to be a character. Don't bother comparing
10671 a single byte to 0400, as it's always less.
10672
395fcb93 10673 * floatfns.c (Fexpt):
327eeec8
PE
10674 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10675
abbd3d23
PE
10676 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10677 for characters.
10678
684a03ef
PE
10679 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10680
0fed43f3
PE
10681 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10682 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10683 incorrectly succeed when S was a string, because 4294967386 was
10684 truncated before it was used.
10685
8fd02eb7
PE
10686 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10687 Otherwise, an out-of-range integer could cause undefined behavior
10688 on a 64-bit host.
10689
f8c86b69
PE
10690 * composite.c: Use int, not EMACS_INT, for characters.
10691 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10692 EMACS_INT, for values that are known to be in character range.
10693 This doesn't fix any bugs but is the usual style inside Emacs and
10694 may generate better code on 32-bit machines.
10695
34206dd2
PE
10696 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10697 This is for reasons similar to the recent CHAR_STRING fix.
10698 * charset.c (Fencode_char): Check that character arg is actually
10699 a character. Pass an int to ENCODE_CHAR.
10700 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10701 wider than 'int', as a compile-time check to prevent future regressions
10702 in this area.
10703
c5958d4c 10704 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10705
10706 Make sure a 64-bit char is never passed to CHAR_STRING.
10707 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10708 by silently ignoring the top 32 bits, allowing some values
10709 that were far too large to be valid characters.
10710 * character.h: Include <verify.h>.
10711 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10712 arguments are no wider than unsigned, as a compile-time check
10713 to prevent future regressions in this area.
10714 * data.c (Faset):
01103c44 10715 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10716 (Fsubst_char_in_region):
10717 * fns.c (concat):
10718 * xdisp.c (decode_mode_spec_coding):
10719 Adjust to CHAR_STRING's new requirement.
10720 * editfns.c (Finsert_char, Fsubst_char_in_region):
10721 * fns.c (concat): Check that character args are actually
10722 characters. Without this test, these functions did the wrong
10723 thing with wildly out-of-range values on 64-bit hosts.
10724
d37ca623
PE
10725 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10726 These casts should not be needed on 32-bit hosts, either.
10727 * keyboard.c (read_char):
10728 * lread.c (Fload): Remove casts to unsigned.
10729
ea204efb
PE
10730 * lisp.h (UNSIGNED_CMP): New macro.
10731 This fixes comparison bugs on 64-bit hosts.
10732 (ASCII_CHAR_P): Use it.
10733 * casefiddle.c (casify_object):
01103c44 10734 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10735 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10736 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10737 * dispextern.h (FACE_FROM_ID):
10738 * keyboard.c (read_char): Use UNSIGNED_CMP.
10739
41cb286c
PE
10740 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10741 not to EMACS_INT, to avoid GCC warning.
10742
4a1b9832
PE
10743 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10744
55daad71
PE
10745 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10746 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10747 isn't needed on 32-bit machines.
8f95c75c 10748
01103c44
PE
10749 * buffer.c (Fgenerate_new_buffer_name):
10750 Use EMACS_INT for count, not int.
0ceccced 10751 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10752
10753 * data.c (Qcompiled_function): Now static.
10754
c6f072e7
PE
10755 * window.c (window_body_lines): Now static.
10756
20ce5912
PE
10757 * image.c (gif_load): Rename local to avoid shadowing.
10758
9c4c5f81
PE
10759 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10760 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10761 * alloc.c (make_save_value): Integer argument is now of type
10762 ptrdiff_t, not int.
10763 (mark_object): Use ptrdiff_t, not int.
10764 * lisp.h (pD): New macro.
10765 * print.c (print_object): Use it.
10766
c0c5c8ae
PE
10767 * alloc.c: Use EMACS_INT, not int, to count objects.
10768 (total_conses, total_markers, total_symbols, total_vector_size)
10769 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10770 (total_free_floats, total_floats, total_free_intervals)
10771 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10772 Now EMACS_INT, not int. All uses changed.
10773 (Fgarbage_collect): Compute overall total using a double, so that
10774 integer overflow is less likely to be a problem. Check for overflow
10775 when converting back to an integer.
5a25e253
PE
10776 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10777 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10778 These were 'int' variables that could overflow on 64-bit hosts;
10779 they were never used, so remove them instead of repairing them.
211a0b2a 10780 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10781 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10782 Previously, this ceilinged at INT_MAX, but that doesn't work on
10783 64-bit machines.
e46bb31a 10784 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10785
c78baabf 10786 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10787 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10788 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10789 when a (possibly-narrower) signed value would do just as well.
10790 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10791
c9d624c6
PE
10792 * alloc.c: Catch some string size overflows that we were missing.
10793 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10794 for convenience in STRING_BYTES_MAX.
10795 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10796 The definition here is exact; the one in lisp.h was approximate.
10797 (allocate_string_data): Check for string overflow. This catches
10798 some instances we weren't catching before. Also, it catches
10799 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10800 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10801 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10802
c9d624c6
PE
10803 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10804 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10805 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10806
353032ce
PE
10807 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10808
2bccce07
PE
10809 * alloc.c (Fmake_string): Check for out-of-range init.
10810
0ac30604
SM
108112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10812
10813 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10814
c195f2de
JD
108152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10816
10817 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10818 xg_get_default_scrollbar_width.
10819
10820 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10821 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10822 (style_changed_cb): Call update_theme_scrollbar_width and call
10823 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10824 all frames (Bug#8505).
10825 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10826 Call gtk_window_set_resizable if HAVE_GTK3.
10827 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10828 and height if HAVE_GTK3 (Bug#8505).
10829 (scroll_bar_width_for_theme): New variable.
10830 (update_theme_scrollbar_width): New function.
10831 (xg_get_default_scrollbar_width): Move code to
10832 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10833 (xg_initialize): Call update_theme_scrollbar_width.
10834
10835 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10836
10837 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10838
e10ac9f1
MR
108392011-06-12 Martin Rudalics <rudalics@gmx.at>
10840
10841 * frame.c (make_frame): Call other_buffer_safely instead of
10842 other_buffer.
10843
10844 * window.c (temp_output_buffer_show): Call display_buffer with
10845 second argument Vtemp_buffer_show_specifiers and reset latter
10846 immediately after the call.
10847 (Vtemp_buffer_show_specifiers): New variable.
10848 (auto_window_vscroll_p, next_screen_context_lines)
10849 (Vscroll_preserve_screen_position): Remove leading asterisks from
10850 doc-strings.
10851
2d3c217e 108522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10853
7b7f97e8 10854 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10855 * buffer.c (Qclone_number): Remove for now, as it's unused.
10856 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10857 (record_buffer): Remove unused local.
10858 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10859 (set_frame_buffer_list): Remove; unused.
10860 * frame.h (other_visible_frames): Remove decl.
10861 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10862 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10863 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10864 if HAVE_GPM.
10865 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10866 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10867 Define only if HAVE_GPM.
10868 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10869 (update_hints_inhibit): Remove; never set. All uses removed.
10870 * widgetprv.h (emacsFrameClassRec): Remove decl.
10871 * window.c (delete_deletable_window): Now returns void, since it
10872 wasn't returning anything.
10873 (compare_window_configurations): Remove unused locals.
10874 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10875 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10876 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10877 the same widths as pointers. This follows up on the 2011-05-06 patch.
10878 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10879 * xterm.h: Likewise.
10880 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10881
1384b89e
JB
108822011-06-12 Juanma Barranquero <lekktu@gmail.com>
10883
10884 * makefile.w32-in: Update dependencies.
10885 (LISP_H): Add lib/intprops.h.
10886
1100a63c
CY
108872011-06-11 Chong Yidong <cyd@stupidchicken.com>
10888
10889 * image.c (gif_load): Add animation frame delay to the metadata.
10890 (syms_of_image): Use DEFSYM. New symbol `delay'.
10891
6198ccd0
MR
108922011-06-11 Martin Rudalics <rudalics@gmx.at>
10893
10894 * window.c (delete_deletable_window): Re-add.
10895 (Fset_window_configuration): Rewrite to handle dead buffers and
10896 consequently deletable windows.
10897 (window_tree, Fwindow_tree): Remove. Supply functionality in
10898 window.el.
10899 (compare_window_configurations): Simplify code.
10900
b6e3633c
AS
109012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10902
1ab0dee5
AS
10903 * image.c (imagemagick_load_image): Fix type mismatch.
10904 (Fimagemagick_types): Likewise.
10905
b6e3633c
AS
10906 * window.h (replace_buffer_in_windows): Declare.
10907
9397e56f
MR
109082011-06-11 Martin Rudalics <rudalics@gmx.at>
10909
10910 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10911 Qclone_number. Remove external declaration of Qdelete_window.
10912 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10913 code.
640c8776
SM
10914 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10915 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10916 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10917 buffer list implementation.
10918 (other_buffer_safely): New function.
10919 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10920 calls to replace_buffer_in_windows and
10921 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10922 if allowed.
10923 (record_buffer): Inhibit quitting and rewrite using quittable
10924 functions. Run Qbuffer_list_update_hook if allowed.
10925 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10926 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10927 Move switch-to-buffer to window.el.
9397e56f
MR
10928 (bury-buffer): Move to window.el.
10929 (Vbuffer_list_update_hook): New variable.
10930
10931 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10932 section.
10933
10934 * window.h (resize_frame_windows): Move up in code.
10935 (Fwindow_frame): Remove EXFUN.
10936 (replace_buffer_in_all_windows): Remove prototype.
10937 (replace_buffer_in_windows_safely): Add prototype.
10938
10939 * window.c: Declare Qdelete_window static again. Move down
10940 declaration of select_count.
10941 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10942 (Fother_window): Move to window.el.
10943 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10944 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10945 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10946 window.el.
10947 (replace_buffer_in_windows): Implement by calling
10948 Qreplace_buffer_in_windows.
10949 (replace_buffer_in_all_windows): Remove with some functionality
10950 moved into replace_buffer_in_windows_safely.
10951 (replace_buffer_in_windows_safely): New function.
10952 (select_window_norecord, select_frame_norecord): Move in front
10953 of run_window_configuration_change_hook. Remove now obsolete
10954 declarations.
640c8776
SM
10955 (Fset_window_buffer): Rewrite doc-string.
10956 Call Qrecord_window_buffer.
9397e56f
MR
10957 (keys_of_window): Move binding for other-window to window.el.
10958
b50691aa
CY
109592011-06-11 Chong Yidong <cyd@stupidchicken.com>
10960
10961 * dispextern.h (struct image): Replace data member, whose int_val
10962 and ptr_val fields were not used by anything, with a single
10963 lisp_val object.
10964
10965 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10966 (gif_clear_image, gif_load, imagemagick_load_image)
10967 (gs_clear_image, gs_load): Callers changed.
10968
3f754b86
PE
109692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10970
cca69397
PE
10971 * buffer.h: Include <time.h>, for time_t.
10972 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10973
109e28d0
PE
10974 Fix minor problems found by static checking.
10975
60737f02
PE
10976 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10977
4b66faf3
PE
10978 Make identifiers static if they are not used in other modules.
10979 * data.c (Qcompiled_function, Qframe, Qvector):
10980 * image.c (QimageMagick, Qsvg):
10981 * minibuf.c (Qmetadata):
10982 * window.c (resize_window_check, resize_root_window): Now static.
10983 * window.h (resize_window_check, resize_root_window): Remove decls.
10984
109e28d0
PE
10985 * window.c (window_deletion_count, delete_deletable_window):
10986 Remove; unused.
46a4ce9e
PE
10987 (window_body_lines): Now static.
10988 (Fdelete_other_windows_internal): Mark vars as initialized.
10989 Make sure 'resize_failed' is initialized.
10990 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10991 (resize_window_apply): Remove unused local.
10992 * window.h (delete_deletable_window): Remove decl.
10993
109e28d0 10994 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10995 (imagemagick_load_image): Fix pointer signedness problem by changing
10996 last arg from unsigned char * to char *. All uses changed.
10997 Also, fix a local for similar reasons.
10998 Remove unused locals. Remove locals to avoid shadowing.
10999 (fn_rsvg_handle_free): Remove; unused.
11000 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11001 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11002
3f754b86
PE
11003 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11004
2547adb1
CY
110052011-06-10 Chong Yidong <cyd@stupidchicken.com>
11006
11007 * image.c (gif_load): Fix omitted cast error introduced by
11008 2011-06-06 change.
11009
2c8e37d4
MR
110102011-06-10 Martin Rudalics <rudalics@gmx.at>
11011
11012 * window.h (resize_proportionally, orig_total_lines)
11013 (orig_top_line): Remove from window structure.
11014 (set_window_height, set_window_width, change_window_heights)
11015 (Fdelete_window): Remove prototypes.
11016 (resize_frame_windows): Remove duplicate declaration.
11017
440a42e3
EZ
110182011-06-10 Eli Zaretskii <eliz@gnu.org>
11019
11020 * window.h (resize_frame_windows, resize_window_check)
11021 (delete_deletable_window, resize_root_window)
11022 (resize_frame_windows): Declare prototypes.
11023
11024 * window.c (resize_window_apply): Make definition be "static" to
11025 match the prototype.
11026
562dd5e9
MR
110272011-06-10 Martin Rudalics <rudalics@gmx.at>
11028
11029 * window.c: Remove declarations of Qwindow_size_fixed,
11030 window_min_size_1, window_min_size_2, window_min_size,
11031 size_window, window_fixed_size_p, enlarge_window, delete_window.
11032 Remove static from declaration of Qdelete_window, it's
11033 temporarily needed by Fbury_buffer.
11034 (replace_window): Don't assign orig_top_line and
11035 orig_total_lines.
11036 (Fdelete_window, delete_window): Remove. Window deletion is
11037 handled by window.el.
640c8776
SM
11038 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11039 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11040 (Fdelete_other_windows): Remove. Deleting other windows is
11041 handled by window.el.
11042 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11043 handled in window.el.
11044 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11045 Window minimum sizes are handled in window.el.
11046 (shrink_windows, size_window, set_window_height)
11047 (set_window_width, change_window_heights, window_height)
11048 (window_width, CURBEG, CURSIZE, enlarge_window)
11049 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11050 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11051 handled in window.el.
11052 (make_dummy_parent): Rename to make_parent_window and give it a
11053 second argument horflag.
11054 (make_window): Don't set resize_proportionally any more.
11055 (Fsplit_window): Remove. Windows are split in window.el.
11056 (save_restore_action, save_restore_orig_size)
11057 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11058 Resize mini windows in window.el.
11059 (grow_mini_window, shrink_mini_window): Implement by calling
11060 Qresize_root_window_vertically, resize_window_check and
11061 resize_window_apply.
640c8776
SM
11062 (saved_window, Fset_window_configuration, save_window_save):
11063 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11064 resize_proportionally.
11065 (window_min_height, window_min_width): Move to window.el.
11066 (keys_of_window): Move bindings for delete-other-windows,
11067 split-window, delete-window and enlarge-window to window.el.
11068
11069 * buffer.c: Temporarily extern Qdelete_window.
11070 (Fbury_buffer): Temporarily call Qdelete_window instead of
11071 Fdelete_window (Fbury_buffer will move to window.el soon).
11072
11073 * frame.c (set_menu_bar_lines_1): Remove code handling
11074 orig_top_line and orig_total_lines.
11075
11076 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11077 set_window_height but set heights directly.
11078 (change_frame_size_1): Use resize_frame_windows.
11079
11080 * xdisp.c (init_xdisp): Don't use set_window_height but set
11081 heights directly.
11082
640c8776
SM
11083 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11084 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11085 run_window_configuration_change_hook.
11086
11087 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11088 instead of change_window_heights and run
11089 run_window_configuration_change_hook.
11090
1a13852e
MR
110912011-06-09 Martin Rudalics <rudalics@gmx.at>
11092
11093 * window.c (replace_window): Rename second argument REPLACEMENT to
11094 NEW. New third argument SETFLAG. Rewrite.
11095 (delete_window, make_dummy_parent): Call replace_window with
11096 third argument 1.
11097 (window_list_1): Move down in code.
11098 (run_window_configuration_change_hook): Move set_buffer part
11099 before select_frame_norecord part in order to unwind correctly.
11100 Rename count1 to count.
11101 (recombine_windows, delete_deletable_window, resize_root_window)
11102 (Fdelete_other_windows_internal)
11103 (Frun_window_configuration_change_hook, make_parent_window)
11104 (resize_window_check, resize_window_apply, Fresize_window_apply)
11105 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11106 (Fdelete_window_internal, Fresize_mini_window_internal):
11107 New functions.
1a13852e
MR
11108 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11109
f3d1777e
MR
111102011-06-08 Martin Rudalics <rudalics@gmx.at>
11111
496e208e
MR
11112 * window.h (window): Add some new members to window structure -
11113 normal_lines, normal_cols, new_total, new_normal, clone_number,
11114 splits, nest, prev_buffers, next_buffers.
11115 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11116 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11117
f3d1777e
MR
11118 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11119 Remove.
496e208e
MR
11120 (make_dummy_parent): Set new members of windows structure.
11121 (make_window): Move down in code. Handle new members of window
11122 structure.
11123 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11124 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11125 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11126 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11127 (Fset_window_next_buffers, Fset_window_clone_number):
11128 New functions.
496e208e
MR
11129 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11130 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11131 Doc-string fixes.
11132 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11133 Argument WINDOW can be now internal window too.
11134 (Fwindow_use_time): Move up in code.
11135 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11136 Rewrite doc-string.
11137 (Fset_window_configuration, saved_window)
11138 (Fcurrent_window_configuration, save_window_save): Handle new
11139 members of window structure.
b9e809c2
MR
11140 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11141 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11142 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11143 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11144 Qget_mru_window, Qresize_root_window,
11145 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11146 Qauto_buffer_name; staticpro them.
f3d1777e 11147
abde8f8c
MR
111482011-06-07 Martin Rudalics <rudalics@gmx.at>
11149
11150 * window.c (Fwindow_total_size, Fwindow_left_column)
11151 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11152 (Fwindow_list_1): New functions.
11153 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11154 (Fwindow_width, Fscroll_left, Fscroll_right):
11155 Use window_body_cols instead of window_box_text_cols.
11156 (delete_window, Fset_window_configuration):
11157 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11158 (delete_all_subwindows): Take a window as argument and not a
11159 structure. Rewrite.
190b47e6
MR
11160 (window_loop): Remove handling of GET_LRU_WINDOW and
11161 GET_LARGEST_WINDOW.
11162 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11163
11164 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11165 window_box_text_cols. delete_all_subwindows now takes a
11166 Lisp_Object as argument.
abde8f8c 11167
640c8776
SM
11168 * indent.c (compute_motion, Fcompute_motion):
11169 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11170
fa8a67e6
MR
11171 * frame.c (delete_frame): Call delete_all_subwindows with root
11172 window as argument.
11173
a54e3482
DC
111742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11175
11176 * fns.c (Fputhash): Document return value.
11177
60002bf5
CY
111782011-06-06 Chong Yidong <cyd@stupidchicken.com>
11179
11180 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11181
0c671da6 111822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11183
b862a52a 11184 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11185
be44ca6c
PE
11186 Check for overflow when converting integer to cons and back.
11187 * charset.c (Fdefine_charset_internal, Fdecode_char):
11188 Use cons_to_unsigned to catch overflow.
11189 (Fencode_char): Use INTEGER_TO_CONS.
11190 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11191 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11192 * data.c (long_to_cons, cons_to_long): Remove.
11193 (cons_to_unsigned, cons_to_signed): New functions.
11194 These signal an error for invalid or out-of-range values.
11195 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11196 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11197 * font.c (Ffont_variation_glyphs):
11198 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11199 * lisp.h: Include <intprops.h>.
11200 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11201 (cons_to_signed, cons_to_unsigned): New decls.
11202 (long_to_cons, cons_to_long): Remove decls.
11203 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11204 (Fprimitive_undo): Use CONS_TO_INTEGER.
11205 * xfns.c (Fx_window_property): Likewise.
11206 * xselect.c: Include <limits.h>.
11207 (x_own_selection, selection_data_to_lisp_data):
11208 Use INTEGER_TO_CONS.
11209 (x_handle_selection_request, x_handle_selection_clear)
11210 (x_get_foreign_selection, Fx_disown_selection_internal)
11211 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11212 (lisp_data_to_selection_data): Use cons_to_unsigned.
11213 (x_fill_property_data): Use cons_to_signed.
11214 Report values out of range.
11215
d1f3d2af
PE
11216 Check for buffer and string overflow more precisely.
11217 * buffer.h (BUF_BYTES_MAX): New macro.
11218 * lisp.h (STRING_BYTES_MAX): New macro.
11219 * alloc.c (Fmake_string):
11220 * character.c (string_escape_byte8):
11221 * coding.c (coding_alloc_by_realloc):
11222 * doprnt.c (doprnt):
11223 * editfns.c (Fformat):
11224 * eval.c (verror):
11225 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11226 since they may not be the same number.
11227 * editfns.c (Finsert_char):
11228 * fileio.c (Finsert_file_contents):
11229 Likewise for BUF_BYTES_MAX.
11230
dd52fcea
PE
11231 * image.c: Use ptrdiff_t, not int, for sizes.
11232 (slurp_file): Switch from int to ptrdiff_t.
11233 All uses changed.
11234 (slurp_file): Check that file size fits in both size_t (for
11235 malloc) and ptrdiff_t (for sanity and safety).
11236
7f9bbdbb
PE
11237 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11238 if b->modtime has its maximal value.
11239
dfe18f82
PE
11240 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11241
84acfcf0
PE
11242 Don't assume time_t can fit into int.
11243 * buffer.h (struct buffer.modtime): Now time_t, not int.
11244 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11245 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11246
ccd9a01a
PE
11247 Minor fixes for signed vs unsigned integers.
11248 * character.h (MAYBE_UNIFY_CHAR):
11249 * charset.c (maybe_unify_char):
11250 * keyboard.c (read_char, reorder_modifiers):
11251 XINT -> XFASTINT, since the integer must be nonnegative.
11252 * ftfont.c (ftfont_spec_pattern):
11253 * keymap.c (access_keymap, silly_event_symbol_error):
11254 XUINT -> XFASTINT, since the integer must be nonnegative.
11255 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11256 since it makes no difference and we prefer signed.
11257 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11258 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11259 nonnegative.
11260
d6d100dd
SM
112612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11262
11263 * window.h (Fwindow_frame): Declare.
11264
2b6148e4
PE
112652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11266
11267 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11268 (SPARE_MEMORY): Always define.
11269 (LARGE_REQUEST): Remove.
11270 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11271
f230ecc9
MR
112722011-06-06 Martin Rudalics <rudalics@gmx.at>
11273
727e958e
MR
11274 * lisp.h: Move EXFUNS for Fframe_root_window,
11275 Fframe_first_window and Fset_frame_selected_window to window.h.
11276
11277 * window.h: Move EXFUNS for Fframe_root_window,
11278 Fframe_first_window and Fset_frame_selected_window here from
11279 lisp.h.
11280
11281 * frame.c (Fwindow_frame, Fframe_first_window)
11282 (Fframe_root_window, Fframe_selected_window)
11283 (Fset_frame_selected_window): Move to window.c.
11284 (Factive_minibuffer_window): Move to minibuf.c.
11285 (Fother_visible_frames_p): New function.
11286
11287 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11288
f230ecc9
MR
11289 * window.c (decode_window, decode_any_window): Move up in code.
11290 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11291 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11292 (Fwindow_buffer): Move up and rewrite doc-string.
11293 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11294 (Fwindow_prev): New functions.
727e958e
MR
11295 (Fwindow_frame): Move here from frame.c. Accept any window as
11296 argument.
11297 (Fframe_root_window, Fframe_first_window)
11298 (Fframe_selected_window): Move here from frame.c. Accept frame
11299 or arbitrary window as argument. Update doc-strings.
11300 (Fminibuffer_window): Move up in code.
11301 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11302 (Fset_frame_selected_window): Move here from frame.c.
11303 Marginal rewrite.
727e958e
MR
11304 (Fselected_window, select_window, Fselect_window): Move up in
11305 code. Minor doc-string fixes.
f230ecc9 11306
4d09bcf6
PE
113072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11308
11309 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11310 Do not assume that spare memory exists; that assumption is valid
11311 only if SYSTEM_MALLOC.
11312 (LARGE_REQUEST): New macro, so that the issue of large requests
11313 is separated from the issue of spare memory.
11314
810928a2
AS
113152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11316
172418ad
AS
11317 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11318 format. (Bug#8806)
11319
43f862f7
AS
11320 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11321
810928a2
AS
11322 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11323 before statements.
11324
a059fe24
JD
113252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11326
11327 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11328
11329 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11330
11331 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11332 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11333
989bf368
JB
113342011-06-05 Juanma Barranquero <lekktu@gmail.com>
11335
11336 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11337
4b80f674
CY
113382011-06-04 Chong Yidong <cyd@stupidchicken.com>
11339
11340 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11341 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11342 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11343 New error handlers.
4b80f674
CY
11344 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11345 Obey Vx_select_enable_clipboard_manager. Catch errors in
11346 x_clipboard_manager_save (Bug#8779).
11347 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11348 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11349
99a33b77 113502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11351
11352 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11353
99a33b77 113542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11355
11356 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11357 in the current matrix if keep_current_p is non-zero.
11358
8264569d
EZ
113592011-06-04 Eli Zaretskii <eliz@gnu.org>
11360
11361 * bidi.c (bidi_level_of_next_char): Fix last change.
11362
57f97249
EZ
113632011-06-03 Eli Zaretskii <eliz@gnu.org>
11364
fec2107c 11365 Support bidi reordering of text covered by display properties.
57f97249 11366
fec2107c
EZ
11367 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11368 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11369 (bidi_cache_search, bidi_cache_iterator_state)
11370 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11371 (bidi_level_of_next_char, bidi_move_to_visually_next):
11372 Support character positions inside a run of characters covered by a
fec2107c
EZ
11373 display string.
11374 (bidi_paragraph_init, bidi_resolve_explicit_1)
11375 (bidi_level_of_next_char): Call bidi_fetch_char and
11376 bidi_fetch_char_advance instead of FETCH_CHAR and
11377 FETCH_CHAR_ADVANCE.
11378 (bidi_init_it): Initialize new members.
11379 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11380 definitions.
11381 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11382 instead of using explicit *_CHAR codes.
d6d100dd
SM
11383 (bidi_resolve_explicit, bidi_resolve_weak):
11384 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11385 bidirectional text is supported only in multibyte buffers.
11386 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11387 it to initialize the frame_window_p member of struct bidi_it.
11388 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11389 (bidi_resolve_explicit, bidi_resolve_weak)
11390 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11391 bidi_it->nchars is non-positive.
11392 (bidi_level_of_next_char): Don't try to lookup the cache for the
11393 next/previous character if nothing is cached there yet, or if we
11394 were just reseat()'ed to a new position.
c40e2fb2 11395
0e14fe90
EZ
11396 * xdisp.c (set_cursor_from_row): Set start and stop points
11397 according to the row's direction when priming the loop that looks
11398 for the glyph on which to display cursor.
11399 (single_display_spec_intangible_p): Function deleted.
11400 (display_prop_intangible_p): Reimplement to call
11401 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11402 Accept 3 additional arguments needed by handle_display_spec.
11403 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11404 values: lists, `(when COND...)' forms, etc.
11405 (single_display_spec_string_p): Support property values that are
11406 lists with the argument STRING its top-level element.
11407 (display_prop_string_p): Fix the condition for processing a
11408 property that is a list to be consistent with handle_display_spec.
fec2107c 11409 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11410 last portion of handle_display_prop.
11411 (compute_display_string_pos): Accept additional argument
11412 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11413 value of a `display' property is a "replacing spec".
11414 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11415 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11416 the display property, but just return a value indicating whether
11417 the display property will replace the characters it covers.
11418 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11419 frame_window_p members of struct bidi_it.
d6d100dd
SM
11420 (compute_display_string_pos, compute_display_string_end):
11421 New functions.
fec2107c
EZ
11422 (push_it): Accept second argument POSITION, where pop_it should
11423 jump to continue iteration.
11424 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11425
fec2107c
EZ
11426 * keyboard.c (adjust_point_for_property): Adjust the call to
11427 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11428
11429 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11430 (bidi_init_it): Update prototypes.
11431 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11432 (compute_display_string_pos, compute_display_string_end):
11433 Declare prototypes.
fec2107c
EZ
11434 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11435 EMACS_INT.
fc6f18ce 11436
40087514 114372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11438
57f53182
PE
11439 Malloc failure behavior now depends on size of allocation.
11440 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11441 * lisp.h: Change signatures accordingly.
11442 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11443 All callers changed. (Bug#8762)
11444
11445 * gnutls.c: Use Emacs's memory allocators.
11446 Without this change, the gnutls library would invoke malloc etc.
11447 directly, which causes problems on non-SYNC_INPUT hosts, and which
11448 runs afoul of improving memory_full behavior. (Bug#8761)
11449 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11450 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11451 xfree instead of the default malloc, realloc, free.
11452 (Fgnutls_boot): No need to check for memory allocation failure,
11453 since xmalloc does that for us.
11454
ac32cd99 11455 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11456 * category.c (hash_get_category_set):
11457 * ccl.c (ccl_driver):
11458 * charset.c (Fdefine_charset_internal):
11459 * charset.h (struct charset.hash_index):
11460 * composite.c (get_composition_id, gstring_lookup_cache)
11461 (composition_gstring_put_cache):
11462 * composite.h (struct composition.hash_index):
11463 * dispextern.h (struct image.hash):
11464 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11465 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11466 (hashfn_equal, hashfn_user_defined, make_hash_table)
11467 (maybe_resize_hash_table, hash_lookup, hash_put)
11468 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11469 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11470 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11471 * image.c (make_image, search_image_cache, lookup_image)
11472 (xpm_put_color_table_h):
11473 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11474 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11475 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11476 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11477 * alloc.c (allocate_vectorlike):
11478 Check for overflow in vector size calculations.
11479 * ccl.c (ccl_driver):
11480 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11481 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11482 need to be updated by these changes.
40087514
PE
11483 * fns.c (make_hash_table, maybe_resize_hash_table):
11484 Check for integer overflow with large hash tables.
0de4bb68
PE
11485 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11486 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11487 (SXHASH_REDUCE): New macro.
11488 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11489 Use it instead of discarding useful hash info with large hash values.
11490 (sxhash_float): New function.
11491 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11492 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11493 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11494 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11495 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11496 Adjust signatures to match updated version of code.
11497 (consing_since_gc): Now EMACS_INT, since a single hash table can
11498 use more than INT_MAX bytes.
11499
698d32e2
DN
115002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11501
11502 Make it possible to build with GCC-4.6+ -O2 -flto.
11503
11504 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11505
fd6fa53f
SM
115062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11507
11508 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11509 Call minibuffer-inactive-mode.
11510
864db017
JB
115112011-05-31 Juanma Barranquero <lekktu@gmail.com>
11512
11513 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11514 Update dependencies.
11515
2ad0baf4
DN
115162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11517
11518 * data.c (init_data): Remove code for UTS, this system is not
11519 supported anymore.
11520
4fcc2638
DN
115212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11522
11523 Don't force ./temacs to start in terminal mode.
11524
11525 * frame.c (make_initial_frame): Initialize faces in all cases, not
11526 only when CANNOT_DUMP is defined.
11527 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11528
c56e0fd5
DN
115292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11530
11531 * dispnew.c (add_window_display_history): Use const for the string
11532 pointer. Remove declaration, not needed.
11533
333d54da 115342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11535
55d4c1b2 11536 Use 'inline', not 'INLINE'.
333d54da 11537 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11538 * alloc.c, fontset.c (INLINE): Remove.
11539 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11540 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11541 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11542 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11543 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11544
738db178
DN
115452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11546
11547 Make it possible to run ./temacs.
11548
11549 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11550 syms_of_callproc does the same thing. Remove test for
11551 "initialized", do it in the caller.
11552 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11553
620c53a6
SM
115542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11555
11556 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11557 (read_minibuf): Use get_minibuffer.
11558 (syms_of_minibuf): Use DEFSYM.
11559 (Qmetadata): New var.
11560 * data.c (Qbuffer): Don't make it static.
11561 (syms_of_data): Use DEFSYM.
11562
e003a292
PE
115632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11564
11565 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11566 (CCL_CODE_MIN): New macro.
11567
ed008a6d
PE
115682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11569
3687c2ef
PE
11570 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11571
ed008a6d
PE
11572 * eval.c (Qdebug): Now static.
11573 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11574 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11575 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11576
d66c4c7c
CY
115772011-05-29 Chong Yidong <cyd@stupidchicken.com>
11578
11579 * image.c: Various fixes to ImageMagick code comments.
11580 (Fimagemagick_types): Doc fix.
11581
5fbc2025
PE
115822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11583
0196f88a
PE
11584 Minor fixes prompted by GCC 4.6.0 warnings.
11585
11586 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11587
5fbc2025
PE
11588 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11589 (x_clipboard_manager_save_all): Move extern decl to ...
11590 * xterm.h: ... here, so that it can be checked for consistency.
11591
1dd3c2d9
CY
115922011-05-29 Chong Yidong <cyd@stupidchicken.com>
11593
11594 * xselect.c (x_clipboard_manager_save_frame)
11595 (x_clipboard_manager_save_all): New functions.
11596 (Fx_clipboard_manager_save): Lisp function deleted.
11597
11598 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11599 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11600
11601 * xterm.h: Update prototype.
11602
5ba6571d
WX
116032011-05-28 William Xu <william.xwl@gmail.com>
11604
11605 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11606 exiting (Bug#8239).
11607
3eaff834
JM
116082011-05-28 Jim Meyering <meyering@redhat.com>
11609
e1900994 11610 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11611 * fns.c (to_uchar): Define.
11612 (crypto_hash_function): Use it to convert some newly-signed
11613 variables to unsigned, to avoid sign-extension bugs. For example,
11614 without this change, (md5 "truc") would evaluate to
11615 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11616 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11617 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11618
0f6990a7
PE
116192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11620
11621 Integer overflow fixes.
c8a9ca5a 11622
08686060
PE
11623 * dbusbind.c: Serial number integer overflow fixes.
11624 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11625 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11626 to hold a serial number that is too large for a fixnum.
11627 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11628 Check for serial numbers out of range. Decode any serial number
59568bf0 11629 that was so large that it became a float. (Bug#8722)
08686060 11630
2d1fc3c7
PE
11631 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11632 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11633 Use XFASTINT rather than XUINT when numbers are nonnegative.
11634 (xd_append_arg, Fdbus_method_return_internal):
11635 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11636 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11637 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11638 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11639 (Bug#8722)
2d1fc3c7 11640
c8a9ca5a
PE
11641 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11642
519e1d69
PE
11643 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11644
6df6ae42 11645 ccl: Add integer overflow checks.
30569699
PE
11646 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11647 (IN_INT_RANGE): New macros.
11648 (ccl_driver): Use them to check for integer overflow when
11649 decoding a CCL program. Many of the new checks are whether XINT (x)
11650 fits in int; it doesn't always, on 64-bit hosts. The new version
11651 doesn't catch all possible integer overflows, but it's an
847044ea 11652 improvement. (Bug#8719)
30569699 11653
c11285dc
PE
11654 * alloc.c (make_event_array): Use XINT, not XUINT.
11655 There's no need for unsigned here.
11656
fdccd48e
PE
11657 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11658 This follows up to the 2011-05-06 change that substituted uintptr_t
11659 for EMACS_INT. This case wasn't caught back then.
11660
37910ab2
PE
11661 Rework Fformat to avoid integer overflow issues.
11662 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11663 now (part of C89). Include <verify.h>.
11664 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11665 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11666 (Fformat): Avoid the prepass trying to compute sizes; it was only
11667 approximate and thus did not catch overflow reliably. Instead, walk
11668 through the format just once, formatting and computing sizes as we go,
11669 checking for integer overflow at every step, and allocating a larger
11670 buffer as needed. Keep track separately whether the format is
11671 multibyte. Keep only the most-recently calculated precision, rather
11672 than them all. Record whether each argument has been converted to
11673 string. Use EMACS_INT, not int, for byte and char and arg counts.
11674 Support field widths and precisions larger than INT_MAX. Avoid
11675 sprintf's undefined behavior with conversion specifications such as %#d
11676 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11677 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11678 formatting out-of-range floating point numbers with int
9173deec 11679 formats. (Bug#8668)
37910ab2 11680
2e6578fb
PE
11681 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11682
0ae6bdee
PE
11683 * data.c: Avoid integer truncation in expressions involving floats.
11684 * data.c: Include <intprops.h>.
11685 (arith_driver): When there's an integer overflow in an expression
11686 involving floating point, convert the integers to floating point
11687 so that the resulting value does not suffer from catastrophic
11688 integer truncation. For example, on a 64-bit host (* 4
11689 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11690 Do not rely on undefined behavior after integer overflow.
11691
de883a70
PE
11692 merge count_size_as_multibyte, parse_str_to_multibyte
11693 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11694 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11695 Check for integer overflow.
11696 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11697 since it's now a duplicate of the other. This is more of
11698 a character than a buffer op, so better that it's in character.c.
11699 * fns.c, print.c: Adjust to above changes.
11700
2ff916cb
PE
117012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11702
11703 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11704
f1b54466
PE
117052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11706
fb1ac845
PE
11707 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11708 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11709 (x_clipboard_manager_save): Now static.
11710 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11711
f1b54466
PE
11712 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11713 (crypto_hash_function): Now static.
11714 Fix pointer signedness problems. Avoid unnecessary initializations.
11715
a9f737ee
CY
117162011-05-27 Chong Yidong <cyd@stupidchicken.com>
11717
11718 * termhooks.h (Vselection_alist): Make it terminal-local.
11719
11720 * terminal.c (create_terminal): Initialize it.
11721
11722 * xselect.c: Support for clipboard managers.
11723 (Vselection_alist): Move to termhooks.h as terminal-local var.
11724 (LOCAL_SELECTION): New macro.
11725 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11726 (symbol_to_x_atom): Remove gratuitous arg.
11727 (x_handle_selection_request, lisp_data_to_selection_data)
11728 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11729 (x_own_selection, x_get_local_selection, x_convert_selection):
11730 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11731 (some_frame_on_display): Delete unused function.
11732 (Fx_own_selection_internal, Fx_get_selection_internal)
11733 (Fx_disown_selection_internal, Fx_selection_owner_p)
11734 (Fx_selection_exists_p): New optional frame arg.
11735 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11736 (x_handle_selection_clear): Don't treat other terminals with the
11737 same keyboard specially. Use the terminal-local Vselection_alist.
11738 (x_clear_frame_selections): Use Frun_hook_with_args.
11739
11740 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11741
11742 * xterm.h: Add support for those atoms.
11743
e067f0c1
CY
117442011-05-26 Chong Yidong <cyd@stupidchicken.com>
11745
11746 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11747 (converted_selections, conversion_fail_tag): New global variables.
11748 (x_selection_request_lisp_error): Free the above.
11749 (x_get_local_selection): Remove unnecessary code.
11750 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11751 of converted selections stored in converted_selections.
11752 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11753 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11754 (x_convert_selection): New function.
11755 (x_handle_selection_event): Simplify.
11756 (x_get_foreign_selection): Don't ignore incoming requests while
11757 waiting for an answer; this will fail when we implement
11758 SAVE_TARGETS, and seems unnecessary anyway.
11759 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11760 (Vx_sent_selection_functions): Doc fix.
11761
0f4aebc0
LL
117622011-05-26 Leo Liu <sdl.web@gmail.com>
11763
11764 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11765
e61124cd
YM
117662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11767
11768 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11769
11770 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11771 for fringe update if it has periodic bitmap.
ac389d0c 11772 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11773 and fringe_bitmap_periodic_p.
11774
11775 * fringe.c (get_fringe_bitmap_data): New function.
11776 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11777 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11778 row. Mark glyph row for fringe update if periodicity changed.
11779
11780 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11781 for fringe update unless it has periodic bitmap.
11782
f16d9837
KH
117832011-05-25 Kenichi Handa <handa@m17n.org>
11784
11785 * xdisp.c (get_next_display_element): Set correct it->face_id for
11786 a static composition.
11787
e1b90ef6
LL
117882011-05-24 Leo Liu <sdl.web@gmail.com>
11789
11790 * deps.mk (fns.o):
11791 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11792
11793 * fns.c (crypto_hash_function, Fsha1): New function.
11794 (Fmd5): Use crypto_hash_function.
11795 (syms_of_fns): Add Ssha1.
11796
7400048f
PE
117972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11798
11799 * gnutls.c: Remove unused macros.
11800 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11801 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11802 Remove macros that are defined and never used.
11803 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11804
abb71cf4
CY
118052011-05-22 Chong Yidong <cyd@stupidchicken.com>
11806
11807 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11808 (Fx_get_selection_internal): Minor cleanup.
11809 (Fx_own_selection_internal): Rename arguments for consistency with
11810 select.el.
11811
6307db39
PE
118122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11813
11814 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11815
f3d4e0a4
CY
118162011-05-22 Chong Yidong <cyd@stupidchicken.com>
11817
11818 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11819
4d8ade89
YM
118202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11821
11822 * dispnew.c (scrolling_window): Don't exclude the case that the
11823 last enabled row in the desired matrix touches the bottom boundary.
11824
32078c8d
GM
118252011-05-21 Glenn Morris <rgm@gnu.org>
11826
11827 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11828 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11829 and add some more files.
32078c8d 11830
7285dc67
EZ
118312011-05-20 Eli Zaretskii <eliz@gnu.org>
11832
11833 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11834 report_file_error introduced by the change from 2011-05-07.
11835
89d1bd22
PE
118362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11837
11838 * systime.h (Time): Define only if emacs is defined.
11839 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11840 where the include path doesn't have X11/X.h by default. See
11841 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11842
cd394be1 118432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11844
11845 * composite.c (find_automatic_composition): Fix previous change.
11846
b9704ad9
GM
118472011-05-20 Glenn Morris <rgm@gnu.org>
11848
11849 * lisp.mk: New file, split from Makefile.in.
11850 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11851 (shortlisp): Remove.
11852 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11853
4a720484
GM
118542011-05-19 Glenn Morris <rgm@gnu.org>
11855
11856 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11857 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11858 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11859 (lisp): Set the order to that of loadup.el.
11860 (shortlisp): Make it a copy of $lisp.
11861 (SOME_MACHINE_LISP): Remove.
11862 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11863 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11864
a28d4396
KH
118652011-05-18 Kenichi Handa <handa@m17n.org>
11866
11867 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11868 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11869 (find_automatic_composition): Mostly rewrite for efficiency.
11870
a2b1fa8e
JB
118712011-05-18 Juanma Barranquero <lekktu@gmail.com>
11872
11873 * makefile.w32-in: Update dependencies.
11874
8e1f5610
CS
118752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11876
11877 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11878 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11879
7025ee00 118802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11881
cdfa6eab
PE
11882 Fix some integer overflow issues, such as string length overflow.
11883
06d6db33
PE
11884 * insdel.c (count_size_as_multibyte): Check for string overflow.
11885
2b4560a8
PE
11886 * character.c (lisp_string_width): Check for string overflow.
11887 Use EMACS_INT, not int, for string indexes and lengths; in
11888 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11889 the resulting string length overflows an EMACS_INT; instead,
11890 report a string overflow if no precision given. When checking for
11891 precision exhaustion, use a check that cannot possibly have
11892 integer overflow. (Bug#8675)
11893 * character.h (lisp_string_width): Adjust to new signature.
11894
cb93f9be
PE
11895 * alloc.c (string_overflow): New function.
11896 (Fmake_string): Use it. This doesn't change behavior, but saves
11897 a few bytes and will simplify future changes.
11898 * character.c (string_escape_byte8): Likewise.
11899 * lisp.h (string_overflow): New decl.
11900
1a1f3366
PE
11901 Fixups, following up to the user-interface timestamp change.
11902 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11903 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11904 * msdos.c (mouse_get_pos): Likewise.
11905 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11906 * w32gui.h (Time): Define by including "systime.h" rather than by
11907 declaring it ourselves. (Bug#8664)
11908
d4e3e4d3
PE
11909 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11910 * image.c (clear_image_cache): Likewise.
11911
f6a24d19
PE
11912 * term.c (term_mouse_position): Don't assume time_t wraparound.
11913
08dc5ae6
PE
11914 Be more systematic about user-interface timestamps.
11915 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11916 and sometimes 'EMACS_UINT', to represent these timestamps.
11917 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11918 This makes the code easier to follow, and makes it easier to catch
11919 integer overflow bugs such as Bug#8664.
11920 * frame.c (Fmouse_position, Fmouse_pixel_position):
11921 Use Time, not unsigned long, for user-interface timestamps.
11922 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11923 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11924 * keyboard.h (last_event_timestamp): Likewise.
11925 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11926 * menu.h (xmenu_show): Likewise.
11927 * term.c (term_mouse_position): Likewise.
11928 * termhooks.h (struct input_event.timestamp): Likewise.
11929 (struct terminal.mouse_position_hook): Likewise.
11930 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11931 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11932 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11933 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11934 what it was before.
11935 * menu.h, termhooks.h: Include "systime.h", for Time.
11936
8e55734a
PE
11937 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11938 Don't assume that the difference between two unsigned long values
11939 can fit into an integer. At this point, we know button_down_time
11940 <= event->timestamp, so the difference must be nonnegative, so
11941 there's no need to cast the result if double-click-time is
11942 nonnegative, as it should be; check that it's nonnegative, just in
11943 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11944 apart (about 25 days). (Bug#8664)
8e55734a 11945
841f1b75 11946 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11947 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11948
3e26f69c
PE
11949 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11950 that always fit in int. Use a sentinel instead of a counter, to
11951 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11952 * frame.h (struct frame): Use int for menu_bar_items_used
11953 instead of EMACS_INT, since it always fits in int.
3e26f69c 11954
5cc152c0
PE
11955 * menu.c (grow_menu_items): Check for int overflow.
11956
d89eb65e
PE
11957 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11958
5235bd3e
PE
11959 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11960 Before, the code was not consistent. These values cannot exceed
11961 2**31 - 1 so there's no need to make them unsigned.
11962 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11963 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11964 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11965 as modifiers.
11966 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11967
bc827e23
PE
11968 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11969 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11970 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11971 presumably because the widths might not match.
11972
78eb494e
PE
11973 * window.c (size_window): Avoid needless test at loop start.
11974
04f2d78b
CB
119752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11976
11977 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11978
d2fc7e3d 119792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11980
11981 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11982
d2fc7e3d 119832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11984
11985 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11986 `width' to `bar_area_x' and `bar_area_width', respectively.
11987 (x_scroll_run): Take account of fringe background extension.
11988
04f2d78b
CB
11989 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11990 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11991 `bar_area_width', respectively.
11992 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11993 background extension.
11994
79b70037
GM
119952011-05-10 Jim Meyering <meyering@redhat.com>
11996
11997 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11998
2f142cc5
JB
119992011-05-10 Juanma Barranquero <lekktu@gmail.com>
12000
12001 * image.c (Finit_image_library): Return t for built-in image types,
12002 like pbm and xbm. (Bug#8640)
12003
57679c86
AS
120042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12005
12006 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12007
888c9e86
EZ
120082011-05-07 Eli Zaretskii <eliz@gnu.org>
12009
b0512a1d
EZ
12010 * w32console.c (Fset_screen_color): Doc fix.
12011 (Fget_screen_color): New function.
12012 (syms_of_ntterm): Defsubr it.
12013
7285dc67
EZ
12014 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12015 unlink the temporary file if Fcall_process didn't create it in the
12016 first place.
12017 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12018 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12019 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12020 cue to call_process_cleanup not to close that handle.
12021
4d3fcc8e
BK
120222011-05-07 Ben Key <bkey76@gmail.com>
12023
12024 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12025 one of two shell specific rules, either bootstrap-temacs-CMD or
12026 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12027 to the previous implementation of the bootstrap-temacs rule.
12028 The bootstrap-temacs-CMD rule is similar to the previous
12029 implementation of the bootstrap-temacs rule except that it
12030 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12031 variable.
12032
12033 These changes, along with some changes to nt/configure.bat,
12034 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12035 earlier fix to add support for --cflags and --ldflags options
12036 that include quotes so that it works whether make uses cmd or
12037 sh as the shell.
12038
b4289b64
MA
120392011-05-06 Michael Albinus <michael.albinus@gmx.de>
12040
12041 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12042 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12043 is a constant.
12044 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12045 a string. Handle both cases.
12046 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12047 (Fdbus_register_method): Use Qinvalid_function.
12048
af4c0e28
JB
120492011-05-06 Juanma Barranquero <lekktu@gmail.com>
12050
12051 * makefile.w32-in: Update dependencies.
12052 (LISP_H): Add inttypes.h and stdin.h.
12053 (PROCESS_H): Add unistd.h.
12054
c51453d9
EZ
120552011-05-06 Eli Zaretskii <eliz@gnu.org>
12056
12057 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12058 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12059
8ff0ac3c 120602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12061
4c4b566b
PE
12062 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12063
aab2b9b5
PE
12064 * term.c (vfatal): Remove stray call to va_end.
12065 It's not needed and the C Standard doesn't allow it here anyway.
12066
c378da0b
PE
12067 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12068 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12069
288b08c7
PE
12070 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12071 bytes.
12072
e3601888
PE
12073 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12074
db6c0e74
PE
12075 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12076
dd5963ea
PE
12077 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12078
88c9450f
PE
12079 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12080
2f9442b8
PE
12081 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12082
c032b5f8
PE
12083 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12084 * charset.c (Fdefine_charset_internal): Don't initialize
12085 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12086 32-bit int (Bug#8600).
a108c10b
PE
12087
12088 * lread.c (read_integer): Be more consistent with string-to-number.
12089 Use string_to_number to do the actual conversion; this avoids
12090 rounding errors and fixes some other screwups. Without this fix,
12091 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12092 (digit_to_number): Move earlier, for benefit of read_integer.
12093 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12094 not a digit in any supported base. (Bug#8602)
a108c10b 12095
ad5f9eea
PE
12096 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12097
aec1708a
PE
12098 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12099 to match comment at start of function. This also removes a
12100 GCC warning about overflow in a 32+64-bit port.
12101
47be4ab5
PE
12102 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12103
371cac43
PE
12104 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12105 Reported by Stefan Monnier in
12106 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12107 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12108 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12109
d01a7826
PE
12110 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12111 (EMACS_UINTPTR): Likewise, with uintptr_t.
12112
7fd47d5c
PE
12113 * lisp.h: Prefer 64-bit EMACS_INT if available.
12114 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12115 on 32-bit hosts that have 64-bit int, so that they can access
12116 large files.
122b0c86
PE
12117 However, temporarily disable this change unless the temporary
12118 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12119
8727937b
PE
12120 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12121
8ac068ac
PE
12122 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12123 This removes an assumption that EMACS_INT and long are the same
12124 width as pointers. The assumption is true for Emacs porting targets
12125 now, but we want to make other targets possible.
12126 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12127 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12128 In the rest of the code, change types of integers that hold casted
12129 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12130 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12131 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12132 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12133 No need to cast type when ORing.
12134 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12135 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12136 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12137 assume EMACS_INT is the same width as char *.
12138 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12139 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12140 Remove no-longer-needed casts.
12141 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12142 (xg_tool_bar_help_callback, xg_make_tool_item):
12143 Use EMACS_INTPTR to hold an integer
12144 that will be cast to void *; this can avoid a GCC warning
12145 if EMACS_INT is not the same width as void *.
12146 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12147 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12148 (current_message_1, set_message_1):
12149 Use a local to convert to proper width without a cast.
12150 * xmenu.c (dialog_selection_callback): Likewise.
12151
ede49d71
PE
12152 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12153 Also, don't assume VALBITS / RAND_BITS is less than 5,
12154 and don't rely on undefined behavior when shifting a 1 left into
12155 the sign bit.
12156 * lisp.h (get_random): Change signature to match.
12157
2f30ecd0
PE
12158 * lread.c (hash_string): Use size_t, not int, for hash computation.
12159 Normally we prefer signed values; but hashing is special, because
12160 it's better to use unsigned division on hash table sizes so that
12161 the remainder is nonnegative. Also, size_t is the natural width
12162 for hashing into memory. The previous code used 'int', which doesn't
12163 retain enough info to hash well into very large tables.
12164 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12165
2a866e7b
PE
12166 * dbusbind.c: Don't possibly lose pointer info when converting.
12167 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12168 Use XPNTR rather than XHASH, so that the high-order bits of
12169 the pointer aren't lost when converting through void *.
12170
51639eac
PE
12171 * eval.c (Fautoload): Don't double-shift a pointer.
12172
92394119
PE
12173 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12174
dbdb9a7c
JB
121752011-05-06 Juanma Barranquero <lekktu@gmail.com>
12176
12177 * gnutls.c (DEF_GNUTLS_FN):
12178 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12179
db7a0b4f
AS
121802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12181
12182 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12183 marker. (Bug#8610)
12184
cd394be1 121852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12186
12187 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12188 New version that can reserve upto 2GB of heap space.
12189
f7ff1b0f 121902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12191
12192 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12193
639c109b
TZ
121942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12195
12196 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12197 `gnutls_certificate_set_x509_key_file'.
12198
d2127135
JB
121992011-05-05 Juanma Barranquero <lekktu@gmail.com>
12200
12201 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12202 Update dependencies.
12203
e968f4f3
JB
122042011-05-04 Juanma Barranquero <lekktu@gmail.com>
12205
12206 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12207 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12208 Remove unused parameter `fildes'.
12209 * process.c (read_process_output, send_process): Don't pass it.
12210
84d358f0
JB
122112011-05-04 Juanma Barranquero <lekktu@gmail.com>
12212
12213 Fix previous change: the library cache is defined in w32.c.
12214 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12215 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12216
0898ca10
JB
122172011-05-04 Juanma Barranquero <lekktu@gmail.com>
12218
12219 Implement dynamic loading of GnuTLS on Windows.
12220
12221 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12222 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12223 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12224 Declare.
12225
12226 * gnutls.c (Qgnutls_dll): Define.
12227 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12228 (gnutls_*): Declare function pointers.
12229 (init_gnutls_functions): New function to initialize function pointers.
12230 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12231 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12232 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12233 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12234 (emacs_gnutls_write, emacs_gnutls_read)
12235 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12236 (Fgnutls_available_p): New function.
12237 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12238 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12239 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12240
12241 * image.c: Include w32.h.
12242 (Vimage_type_cache): Delete.
12243 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12244 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12245 (w32_delayed_load): Move to w32.c.
12246
12247 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12248
12249 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12250 (w32_delayed_load): Move from image.c. When loading a library, record
12251 its filename in the :loaded-from property of the library id.
12252 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12253 Initialize and staticpro them.
12254 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12255
12256 * process.c: Include lisp.h before w32.h, not after.
12257 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12258 instead of gnutls_record_check_pending.
12259
12260 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12261
ff4de4aa
TZ
122622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12263
12264 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12265 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12266 as passed in.
12267
abe95abb
JD
122682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12269
12270 * xterm.c (x_set_frame_alpha): Do not set property on anything
12271 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12272
e16e55d4
JB
122732011-05-02 Juanma Barranquero <lekktu@gmail.com>
12274
12275 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12276
bafcf6a5
JB
122772011-05-02 Juanma Barranquero <lekktu@gmail.com>
12278
12279 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12280 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12281 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12282 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12283 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12284 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12285 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12286 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12287 (Qgnutls_bootprop_callbacks_verify): Make static.
12288
e7a6747f
AS
122892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12290
19ed11ba
AS
12291 * callproc.c: Indentation fixup.
12292
e7a6747f 12293 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12294 (wait_for_termination, interruptible_wait_for_termination):
12295 Move after wait_for_termination_1.
e7a6747f 12296
1ef14cb4
LMI
122972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12298
12299 * sysdep.c (interruptible_wait_for_termination): New function
12300 which is like wait_for_termination, but allows keyboard
12301 interruptions.
12302
12303 * callproc.c (Fcall_process): Add (:file "file") as an option for
12304 the STDOUT buffer.
12305 (Fcall_process_region): Ditto.
12306
330d880c
EZ
123072011-04-30 Eli Zaretskii <eliz@gnu.org>
12308
8db90b73
EZ
12309 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12310 rather than `XVECTOR (FOO)->size'.
12311
330d880c
EZ
12312 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12313 inttypes.h, as a gnulib replacement is used if it not available in
12314 system headers.
12315
15cbd324
EZ
123162011-04-21 Eli Zaretskii <eliz@gnu.org>
12317
12318 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12319 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12320 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12321
12322 * coding.c (coding_alloc_by_realloc): Error out if destination
12323 will grow beyond MOST_POSITIVE_FIXNUM.
12324 (decode_coding_emacs_mule): Abort if there isn't enough place in
12325 charbuf for the composition carryover bytes. Reserve an extra
12326 space for up to 2 characters produced in a loop.
12327 (decode_coding_iso_2022): Abort if there isn't enough place in
12328 charbuf for the composition carryover bytes.
12329
123302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12331
ae940cca
EZ
12332 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12333 aborting when %lld or %lll format is passed.
12334 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12335 %llo or %llx format is passed. (Bug#8545)
12336
03ab8921
EZ
12337 * window.c (window_scroll_line_based): Use a marker instead of
12338 simple variables to record original value of point. (Bug#7952)
12339
afda1437
EZ
12340 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12341 produced by %s or %c overflows available buffer space. (Bug#8545)
12342
f76dee0c
PE
123432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12344
12345 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12346 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12347
fdc5744d
JB
123482011-04-28 Juanma Barranquero <lekktu@gmail.com>
12349
12350 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12351
638f053a
JB
123522011-04-28 Juanma Barranquero <lekktu@gmail.com>
12353
12354 * keyboard.c (Qdelayed_warnings_hook): Define.
12355 (command_loop_1): Run `delayed-warnings-hook'
12356 if Vdelayed_warnings_list is non-nil.
12357 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12358 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12359
d178f871
EZ
123602011-04-28 Eli Zaretskii <eliz@gnu.org>
12361
12362 * doprnt.c (doprnt): Don't return value smaller than the buffer
12363 size if the message was truncated. (Bug#8545).
12364
b124fd93
JB
123652011-04-28 Juanma Barranquero <lekktu@gmail.com>
12366
12367 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12368 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12369
e810457d
PE
123702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12371
12372 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12373
ea51cceb
JB
123742011-04-27 Juanma Barranquero <lekktu@gmail.com>
12375
12376 * makefile.w32-in: Update dependencies.
12377
94dcfacf
EZ
123782011-04-27 Eli Zaretskii <eliz@gnu.org>
12379
12380 Improve `doprnt' and its usage. (Bug#8545)
12381 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12382 `format_end'. Remove support for %l as a conversion specifier.
12383 Don't use xrealloc. Improve diagnostics when the %l size modifier
12384 is used. Update the commentary.
12385
12386 * eval.c (verror): Simplify calculation of size_t.
12387
12388 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12389 messages.
12390
f61f41d7
PE
123912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12392
12393 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12394 change.
12395
96fb4434
PE
123962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12397
12398 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12399 This makes this file independent of the recent pseudovector change.
12400
671875da 124012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12402
69e9b5a3
PE
12403 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12404
b5f869a7 12405 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12406 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12407 Remove unused local.
c8926152 12408 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12409
841a1577 12410 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12411 GCC 4.6.0 optimizes based on type-based alias analysis.
12412 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12413 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12414 != &v->size, and therefore "v->size = 1; b->size = 2; return
12415 v->size;" must therefore return 1. This assumption is incorrect
12416 for Emacs, since it type-puns struct Lisp_Vector * with many other
12417 types. To fix this problem, this patch adds a new type struct
f904488f 12418 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12419 and pseudovectors, and helps optimizing compilers not get fooled
12420 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12421 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12422 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12423 the size member.
eab3844f
PE
12424 (XSETPVECTYPE): Rewrite in terms of new macro.
12425 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12426 This is a bit clearer, and further avoids the possibility of
12427 undesirable aliasing.
12428 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12429 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12430 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12431 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12432 (ASIZE): Now uses header.size rather than size.
12433 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12434 to avoid the hassle of writing XVECTOR (foo)->header.size.
12435 (struct vectorlike_header): New type.
eab3844f
PE
12436 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12437 object, to help avoid aliasing.
12438 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12439 (SUBRP): Likewise, since Lisp_Subr is a special case.
12440 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12441 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12442 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12443 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12444 changed to be "header.size" and "header.next".
12445 * buffer.h (struct buffer): Likewise.
12446 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12447 * frame.h (struct frame): Likewise.
12448 * process.h (struct Lisp_Process): Likewise.
12449 * termhooks.h (struct terminal): Likewise.
12450 * window.c (struct save_window_data, struct saved_window): Likewise.
12451 * window.h (struct window): Likewise.
12452 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12453 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12454 * buffer.c (init_buffer_once): Likewise.
12455 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12456 special case.
12457 * process.c (Fformat_network_address): Use local var for size,
12458 for brevity.
12459
0df1eac5
PE
12460 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12461
847ab9d1 12462 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12463 * data.c (atof): Remove decl; no longer used or needed.
12464 (digit_to_number): Move to lread.c.
12465 (Fstring_to_number): Use new string_to_number function, to be
12466 consistent with how the Lisp reader treats infinities and NaNs.
12467 Do not assume that floating-point numbers represent EMACS_INT
12468 without losing information; this is not true on most 64-bit hosts.
12469 Avoid double-rounding errors, by insisting on integers when
12470 parsing non-base-10 numbers, as the documentation specifies.
12471 * lisp.h (string_to_number): New decl, replacing ...
12472 (isfloat_string): Remove.
bc0a5c13 12473 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12474 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12475 appears to have been a coding error. Similarly, do not accept
12476 strings like +-1e0 as floating point numbers. Do not report
12477 overflow for integer overflows unless the base is not 10 which
12478 means we have no simple and reliable way to continue.
12479 Break out the floating-point parsing into a new
12480 function string_to_number, so that Fstring_to_number parses
12481 floating point numbers consistently with the Lisp reader.
04f2d78b 12482 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12483 (E_CHAR, EXP_INT): Remove, replacing with ...
12484 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12485 (string_to_number): New function, replacing isfloat_string.
12486 This function checks for valid syntax and produces the resulting
12487 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12488 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12489 so that overflow for non-base-10 numbers is reported only when
12490 there's no portable and simple way to convert to floating point.
452f4150 12491
67769ffc
PE
12492 * textprop.c (set_text_properties_1): Rewrite for clarity,
12493 and to avoid GCC warning about integer overflow.
12494
c20db43f
PE
12495 * intervals.h (struct interval): Use EMACS_INT for members
12496 where EMACS_UINT might cause problems. See
12497 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12498 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12499 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12500 All uses changed.
37aa2f85
PE
12501 (offset_intervals): Tell GCC not to worry about length overflow
12502 when negating a negative length.
c20db43f 12503
2538aa2f
PE
12504 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12505 (overrun_check_free): Likewise.
12506
f2d3008d
PE
12507 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12508 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12509 word size.
12510
ec8df744
PE
12511 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12512 (gnutls_make_error): Rename local to avoid shadowing.
12513 (gnutls_emacs_global_deinit): ifdef out; not used.
12514 (Fgnutls_boot): Use const for pointer to readonly storage.
12515 Comment out unused local. Fix pointer signedness problems.
12516
640ee02d
PE
12517 * lread.c (openp): Don't stuff size_t into an 'int'.
12518 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12519 about possible signed overflow.
12520
6048fb2a
PE
12521 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12522 (GDK_KEY_g): Don't define if already defined.
12523 (xg_prepare_tooltip): Avoid pointer signedness problem.
12524 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12525
fa3c87e1
PE
12526 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12527 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12528
2172544b
PE
12529 * xfns.c (Fx_window_property): Simplify a bit,
12530 to make a bit faster and to avoid GCC 4.6.0 warning.
12531 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12532
9b821a21
PE
12533 * fns.c (internal_equal): Don't assume size_t fits in int.
12534
3c616cfa
PE
12535 * alloc.c (compact_small_strings): Tighten assertion a little.
12536
c2982e87
PE
12537 Replace pEd with more-general pI, and fix some printf arg casts.
12538 * lisp.h (pI): New macro, generalizing old pEd macro to other
12539 conversion specifiers. For example, use "...%"pI"d..." rather
12540 than "...%"pEd"...".
12541 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12542 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12543 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12544 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12545 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12546 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12547 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12548 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12549 64-bit hosts.
12550 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12551 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12552 * print.c (safe_debug_print, print_object): Likewise.
12553 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12554 to int.
6f04d126
PE
12555 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12556 avoiding the 0 flag, which is not portable.
c2982e87
PE
12557 * process.c (Fmake_network_process): Use pI to avoid cast.
12558 * region-cache.c (pp_cache): Likewise.
12559 * xdisp.c (decode_mode_spec): Likewise.
12560 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12561 behavior on 64-bit hosts with printf arg.
6f04d126 12562 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12563 (x_stop_queuing_selection_requests): Likewise.
12564 (x_get_window_property): Don't truncate byte count to an 'int'
12565 when tracing.
0b432f21 12566
5e073ec7
PE
12567 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12568 here, since it parses constructs like leading '-' and spaces,
12569 which are not wanted; and it overflows with large numbers.
12570 Instead, simply match F[0-9]+, which is what is wanted anyway.
12571
36372bf9
PE
12572 * alloc.c: Remove unportable assumptions about struct layout.
12573 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12574 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12575 (allocate_vectorlike, make_pure_vector): Use the new macros,
12576 plus offsetof, to remove unportable assumptions about struct layout.
12577 These assumptions hold on all porting targets that I know of, but
12578 they are not guaranteed, they're easy to remove, and removing them
12579 makes further changes easier.
12580
0b432f21
PE
12581 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12582 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12583 (string_overrun_cookie): Now const. Use initializers that
12584 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12585 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12586 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12587 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12588 multiple of sizeof (EMACS_INT); it need not be, if
12589 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12590 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12591
895009e1
JB
125922011-04-26 Juanma Barranquero <lekktu@gmail.com>
12593
12594 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12595
6a7a1b0b
TZ
125962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12597
12598 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12599 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12600 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12601
841a1577 126022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12603
12604 * lisp.h (Qdebug): List symbol.
895009e1 12605 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12606 * keyboard.c (debug-on-event): New variable.
12607 (handle_user_signal): Break into debugger when debug-on-event
12608 matches the current signal symbol.
12609
f2d3ba6f
DN
126102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12611
12612 * alloc.c (check_sblock, check_string_bytes)
12613 (check_string_free_list): Convert to standard C.
12614
42ce4c63
TZ
126152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12616
12617 * w32.c (emacs_gnutls_push): Fix typo.
12618
825cd63c
EZ
126192011-04-25 Eli Zaretskii <eliz@gnu.org>
12620
fb11d64d
EZ
12621 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12622 "cast to pointer from integer of different size".
12623
825cd63c
EZ
12624 Improve doprnt and its use in verror. (Bug#8545)
12625 * doprnt.c (doprnt): Document the set of format control sequences
12626 supported by the function. Use SAFE_ALLOCA instead of always
12627 using `alloca'.
12628
12629 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12630 is one byte too soon. Don't use xrealloc; instead xfree and
12631 xmalloc anew.
12632
e061a11b
TZ
126332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12634
12635 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12636 callbacks stage.
12637
12638 * gnutls.c: Renamed global_initialized to
12639 gnutls_global_initialized. Added internals for the
12640 :verify-hostname-error, :verify-error, and :verify-flags
12641 parameters of `gnutls-boot' and documented those parameters in the
12642 docstring. Start callback support.
9173deec
JB
12643 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12644 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12645 on error. Return error code.
e061a11b
TZ
12646 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12647 (emacs_gnutls_read): Likewise.
12648 (Fgnutls_boot): Return handshake error code.
12649 (emacs_gnutls_handle_error): New function.
12650 (wsaerror_to_errno): Likewise.
12651
12652 * w32.h (emacs_gnutls_pull): Add prototype.
12653 (emacs_gnutls_push): Likewise.
12654
12655 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12656 (emacs_gnutls_push): Likewise.
12657
126582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12659
12660 * process.c (wait_reading_process_output): Check if GnuTLS
12661 buffered some data internally if no FDs are set for TLS
12662 connections.
12663
12664 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12665 (LIBS): Link to USER_LIBS.
12666 ($(BLD)/gnutls.$(0)): New target.
12667
fa6996bc
EZ
126682011-04-24 Eli Zaretskii <eliz@gnu.org>
12669
eb35682e
EZ
12670 * xdisp.c (handle_single_display_spec): Rename the
12671 display_replaced_before_p argument into display_replaced_p, to
12672 make it consistent with the commentary. Fix typos in the
12673 commentary.
12674
e2ad650c
EZ
12675 * textprop.c (syms_of_textprop): Remove dead code.
12676 (copy_text_properties): Delete obsolete commentary about an
12677 interface that was deleted long ago. Fix typos in the description
12678 of arguments.
12679
1b2de274
EZ
12680 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12681 to changes in oldXMenu/XMenu.h from 2011-04-16.
12682 <menu_help_message, prev_menu_help_message>: Constify.
12683 (IT_menu_make_room): menu->help_text is now `const char **';
12684 adjust.
12685
12686 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12687 to changes in oldXMenu/XMenu.h from 2011-04-16.
12688 (struct XMenu): Declare `help_text' `const char **'.
12689
12690 * xfaces.c <Qunspecified>: Make extern again.
12691
12692 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12693 required by POSIX.
1b2de274 12694
762b15be
EZ
12695 * doc.c (get_doc_string): Improve the format passed to `error'.
12696
12697 * doprnt.c (doprnt): Improve commentary.
12698
12699 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12700
12701 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12702 them with etags.
12703
f1052e5d
EZ
12704 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12705 changes in globals.h immediately force recompilation.
762b15be
EZ
12706 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12707 $(CURDIR)/s/ms-w32.h.
12708 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12709
fa6996bc
EZ
12710 * character.c (Fchar_direction): Function deleted.
12711 (syms_of_character): Don't defsubr it.
12712 <char-direction-table>: Deleted.
12713
e6c3da20
EZ
127142011-04-23 Eli Zaretskii <eliz@gnu.org>
12715
12716 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12717 * doprnt.c: Include limits.h.
12718 (SIZE_MAX): New macro.
04f2d78b
CB
12719 (doprnt): Return a size_t value. 2nd arg is now size_t.
12720 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12721 Improve overflow protection. Support `l' modifier for integer
12722 conversions. Support %l conversion. Don't assume an EMACS_INT
12723 argument for integer conversions and for %c.
12724
12725 * lisp.h (doprnt): Restore prototype.
12726
12727 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12728 $(SRC)/character.h.
12729
12730 * Makefile.in (base_obj): Add back doprnt.o.
12731
12732 * deps.mk (doprnt.o): Add back prerequisites.
12733 (callint.o): Depend on character.h.
12734
12735 * eval.c (internal_lisp_condition_case): Include the handler
12736 representation in the error message.
12737 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12738 when breaking from the loop.
12739
12740 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12741
12742 * callint.c (Fcall_interactively): When displaying error message
12743 about invalid control letter, pass the character's codepoint, not
12744 a pointer to its multibyte form. Improve display of the character
12745 in octal and display also its hex code.
12746
12747 * character.c (char_string): Use %x to display the (unsigned)
12748 codepoint of an invalid character, to avoid displaying a bogus
12749 negative value.
12750
12751 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12752 `error', not SYMBOL_NAME itself.
12753
12754 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12755 character arguments to `error'.
12756
12757 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12758 to `error' in error message about FINAL_CHAR argument. Make sure
12759 FINAL_CHAR is a character, and use %c when it is passed as
12760 argument to `error'.
12761
4ffd0d6b 127622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12763
12764 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12765
12766 * w32.c: Include <time.h>.
12767 (sys_localtime): New function.
12768
4ffd0d6b 127692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12770
12771 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12772
4ffd0d6b 12773 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12774
4ffd0d6b 127752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12776
4ffd0d6b
GM
12777 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12778 zombies (Bug#8467).
aac0c6e3 12779
04c56954
EZ
127802011-04-19 Eli Zaretskii <eliz@gnu.org>
12781
12782 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12783 gl_state.e_property when gl_state.object is Qt.
12784
12785 * insdel.c (make_gap_larger): Remove limitation of buffer size
12786 to <= INT_MAX.
12787
16a43933
CY
127882011-04-18 Chong Yidong <cyd@stupidchicken.com>
12789
12790 * xdisp.c (lookup_glyphless_char_display)
12791 (produce_glyphless_glyph): Handle cons cell entry in
12792 glyphless-char-display.
12793 (Vglyphless_char_display): Document it.
12794
12795 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12796 glyphless-char-display.
12797
4581706e
CY
127982011-04-17 Chong Yidong <cyd@stupidchicken.com>
12799
12800 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12801
12802 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12803
12804 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12805 definition for no-X builds.
12806
4887c6e2 128072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12808
fd35b6f9
PE
12809 Static checks with GCC 4.6.0 and non-default toolkits.
12810
5c1ccb01
PE
12811 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12812
006c5daa
PE
12813 * process.c (keyboard_bit_set): Define only if SIGIO.
12814 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12815 (send_process): Repair possible setjmp clobbering.
12816
efc736d3
PE
12817 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12818
4e2fe2e6
PE
12819 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12820
f97334a2
PE
12821 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12822
4e75f29d
PE
12823 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12824 Define only if needed.
12825
90efadd1
PE
12826 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12827 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12828 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12829
3c647824
PE
12830 * dispextern.h (struct redisplay_interface): Rename param
12831 to avoid shadowing.
e264f262 12832 * termhooks.h (struct terminal): Likewise.
761383f4 12833 * xterm.c (xembed_send_message): Likewise.
3c647824 12834
b58c5c4a
PE
12835 * insdel.c (make_gap_smaller): Define only if
12836 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12837
cad59032
PE
12838 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12839 it.
12840
c339dc2e
PE
12841 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12842 so that we aren't warned about unused symbols.
12843
91a3e27b
PE
12844 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12845
399c71d3 12846 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12847
8ffc96f5
PE
12848 * xfns.c (x_real_positions): Mark locals as initialized.
12849
eef9bc79
PE
12850 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12851
098db9dd
PE
12852 * xterm.c: Fix problems found by static analysis with other toolkits.
12853 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12854 (x_dispatch_event): Declare static if USE_GTK, and
12855 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12856 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12857 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12858 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12859 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12860
eb18f6cc
PE
12861 * xmenu.c (menu_help_callback): Pointer type fixes.
12862 Use const pointers when pointing at readonly data. Avoid pointer
12863 signedness clashes.
12864 (FALSE): Remove unused macro.
12865 (update_frame_menubar): Remove unused decl.
12866
1fe72bf8
PE
12867 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12868
60d9e1db
PE
12869 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12870 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12871 (single_menu_item): Rename local to avoid shadowing.
12872
39261c26
PE
12873 * keyboard.c (make_lispy_event): Remove unused local var.
12874
018c5e19
PE
12875 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12876 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12877
63d2b86e
PE
12878 * bitmaps: Change bitmaps from unsigned char back to the X11
12879 compatible char. Avoid the old compiler warnings about
12880 out-of-range initializers by using, for example, '\xab' rather
12881 than 0xab.
12882
aefd87e1
PE
12883 * xgselect.c (xgselect_initialize): Check vs interface
12884 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12885
bf501fb9
PE
12886 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12887
e9829fdf
PE
12888 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12889 to read-only memory.
12890
1086c095
PE
12891 * fns.c (vector): Remove; this old hack is no longer needed.
12892
2baccd04 12893 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12894 Remove unused var.
dde42981 12895 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12896
72391843 12897 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12898
436c16df 12899 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12900 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12901 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12902
92bb796d 12903 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12904 (x_term_init): Remove local to avoid shadowing.
92bb796d 12905
764430a3 12906 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12907
12908 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12909 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12910
d1dfb56c
EZ
129112011-04-16 Eli Zaretskii <eliz@gnu.org>
12912
c4354cb4
EZ
12913 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12914
d1dfb56c
EZ
12915 Fix regex.c, syntax.c and friends for buffers > 2GB.
12916 * syntax.h (struct gl_state_s): Declare character position members
12917 EMACS_INT.
12918
12919 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12920
04f2d78b
CB
12921 * textprop.c (verify_interval_modification, interval_of):
12922 Declare arguments EMACS_INT.
d1dfb56c
EZ
12923
12924 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12925 EMACS_INT.
12926
12927 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12928
12929 * indent.c (Fvertical_motion): Local variable it_start is now
12930 EMACS_INT.
12931
12932 * regex.c (re_match, re_match_2, re_match_2_internal)
12933 (bcmp_translate, regcomp, regexec, print_double_string)
12934 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12935 (re_compile_pattern, re_exec): Declare arguments and local
12936 variables `size_t' and `ssize_t' and return values `regoff_t', as
12937 appropriate.
12938 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12939 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12940 <compile_stack_type>: `size' and `avail' are now `size_t'.
12941
12942 * regex.h <regoff_t>: Use ssize_t, not int.
12943 (re_search, re_search_2, re_match, re_match_2): Arguments that
12944 specify buffer/string position and length are now ssize_t and
12945 size_t. Return type is regoff_t.
12946
613052cd
BK
129472011-04-16 Ben Key <bkey76@gmail.com>
12948
12949 * nsfont.m: Fixed bugs in ns_get_family and
12950 ns_descriptor_to_entity that were caused by using free to
12951 deallocate memory blocks that were allocated by xmalloc (via
12952 xstrdup). This caused Emacs to crash when compiled with
12953 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12954 --enable-checking=xmallocoverrun). xfree is now used to
12955 deallocate these memory blocks.
12956
4170f62f 129572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12958
71b41406
PE
12959 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12960
9587a89d
PE
12961 emacs_write: Accept and return EMACS_INT for sizes.
12962 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12963 et seq.
12964 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12965 Accept and return EMACS_INT.
12966 (emacs_gnutls_write): Return the number of bytes written on
12967 partial writes.
12968 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12969 (emacs_read, emacs_write): Remove check for negative size, as the
12970 Emacs source code has been audited now.
9587a89d
PE
12971 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12972 (emacs_read, emacs_write): Use it.
273a5f82
PE
12973 * process.c (send_process): Adjust to the new signatures of
12974 emacs_write and emacs_gnutls_write. Do not attempt to store
12975 a byte offset into an 'int'; it might overflow.
9587a89d 12976 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12977
3e047f51
PE
12978 * sound.c: Don't assume sizes fit in 'int'.
12979 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12980 Return EMACS_INT, not int.
3e047f51 12981 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12982 Accept EMACS_INT, not int.
12983 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12984 record read return values.
12985
cc39a9db
BK
129862011-04-15 Ben Key <bkey76@gmail.com>
12987
c9d0ec6d
JB
12988 * keyboard.c (Qundefined): Don't declare static since it is used
12989 in nsfns.m.
12990 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12991 static since they are used in nsfont.m.
cc39a9db 12992
6c60eb9f
SM
129932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12994
12995 * process.c (Qprocessp): Don't declare static.
12996 * lisp.h (Qprocessp): Declare again.
12997
7990b61a
JB
129982011-04-15 Juanma Barranquero <lekktu@gmail.com>
12999
13000 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13001
5d4cb038
PE
130022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13003
8bd7b830 13004 Improve C-level modularity by making more things 'static'.
cd64ea1d 13005
e3b27b31
PE
13006 Don't publish debugger-only interfaces to other modules.
13007 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13008 (verify_bytepos, count_markers): Move decls to the only modules
13009 that need them.
13010 * region-cache.h (pp_cache): Likewise.
13011 * window.h (check_all_windows): Likewise.
13012 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13013
5d4cb038
PE
13014 * sysdep.c (croak): Now static, if
13015 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13016 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13017
13018 * alloc.c (refill_memory_reserve): Now static if
13019 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13020 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13021
e87b6180
PE
13022 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13023 Define only if USE_LUCID.
13024
ac64929e
PE
13025 * xrdb.c (x_customization_string, x_rm_string): Now static.
13026
6f37259d
PE
13027 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13028 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13029
1683e3ab
PE
13030 * xdisp.c (draw_row_with_mouse_face): Now static.
13031 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13032
de9c2632
PE
13033 * window.h (check_all_windows): Mark externally visible.
13034
2b96acb7
PE
13035 * window.c (window_deletion_count): Now static.
13036
13037 * undo.c: Make symbols static if they're not exported.
13038 (last_undo_buffer, last_boundary_position, pending_boundary):
13039 Now static.
13040
50436f33
PE
13041 * textprop.c (interval_insert_behind_hooks): Now static.
13042 (interval_insert_in_front_hooks): Likewise.
13043
64520e5c
PE
13044 * term.c: Make symbols static if they're not exported.
13045 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13046 (max_frame_lines, tty_set_terminal_modes):
13047 (tty_reset_terminal_modes, tty_turn_off_highlight):
13048 (get_tty_terminal): Now static.
13049 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13050 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13051 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13052 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13053 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13054
1fa53021
PE
13055 * sysdep.c: Make symbols static if they're not exported.
13056 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13057 Now static.
13058 (sigprocmask_set, full_mask): Remove; unused.
13059 (wait_debugging): Mark as visible.
13060 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13061 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13062
d4b43b22
PE
13063 * syntax.c (syntax_temp): Define only if !__GNUC__.
13064
b7c513d0
PE
13065 * sound.c (current_sound_device, current_sound): Now static.
13066
989b29ad
PE
13067 * search.c (searchbufs, searchbuf_head): Now static.
13068
13a55a78
PE
13069 * scroll.c (scroll_cost): Remove; unused.
13070 * dispextern.h (scroll_cost): Remove decl.
13071
de68a1fc
PE
13072 * region-cache.h (pp_cache): Mark as externally visible.
13073
40ccffa6
PE
13074 * process.c: Make symbols static if they're not exported.
13075 (process_tick, update_tick, create_process, chan_process):
13076 (Vprocess_alist, proc_buffered_char, datagram_access):
13077 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13078 (deactivate_process): Mark defn as static, as well as decl.
13079 * lisp.h (create_process): Remove decl.
13080 * process.h (chan_process, Vprocess_alist): Remove decls.
13081
ad64fc97
PE
13082 * print.c: Make symbols static if they're not exported.
13083 (print_depth, new_backquote_output, being_printed, print_buffer):
13084 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13085 (print_interval, print_number_index, initial_stderr_stream):
13086 Now static.
13087 * lisp.h (Fprinc): Remove decl.
13088 (debug_output_compilation_hack): Mark as externally visible.
13089
adddb265
PE
13090 * sysdep.c (croak): Move decl from here to syssignal.h.
13091 * syssignal.h (croak): Put it here, so the API can be checked when
13092 'croak' is called from dissociate_if_controlling_tty.
13093
1717ede2
PE
13094 * minibuf.c: Make symbols static if they're not exported.
13095 (minibuf_save_list, choose_minibuf_frame): Now static.
13096 * lisp.h (choose_minibuf_frame): Remove decl.
13097
fa5fb2bc
PE
13098 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13099
1e3890d1
PE
13100 * lread.c: Make symbols static if they're not exported.
13101 (read_objects, initial_obarray, oblookup_last_bucket_number):
13102 Now static.
13103 (make_symbol): Remove; unused.
13104 * lisp.h (initial_obarray, make_symbol): Remove decls.
13105
8a1414fa
PE
13106 * keyboard.c: Make symbols static if they're not exported.
13107 (single_kboard, recent_keys_index, total_keys, recent_keys):
13108 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13109 (this_single_command_key_start, echoing, last_auto_save):
13110 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13111 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13112 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13113 (Vlispy_mouse_stem, double_click_count):
13114 Now static.
13115 (force_auto_save_soon): Define only if SIGDANGER.
13116 (ignore_mouse_drag_p): Now static if
13117 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13118 (print_help): Remove; unused.
13119 (stop_character, last_timer_event): Mark as externally visible.
13120 * keyboard.h (ignore_mouse_drag_p): Declare only if
13121 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13122 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13123 * lisp.h (echoing): Remove decl.
13124 (force_auto_save_soon): Declare only if SIGDANGER.
13125 * xdisp.c (redisplay_window): Simplify code, to make it more
13126 obvious that ignore_mouse_drag_p is not accessed if !defined
13127 USE_GTK && !defined HAVE_NS.
13128
93ea6e8f
PE
13129 * intervals.c: Make symbols static if they're not exported.
13130 (merge_properties_sticky, merge_interval_right, delete_interval):
13131 Now static.
13132 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13133
77382fcc
PE
13134 * insdel.c: Make symbols static if they're not exported.
13135 However, leave prepare_to_modify_buffer alone. It's never
13136 called from outside this function, but that appears to be a bug.
13137 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13138 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13139 (adjust_after_replace_noundo): Remove; unused.
13140 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13141 (signal_before_change): Remove decls.
77382fcc 13142
9306c32e
PE
13143 * indent.c (val_compute_motion, val_vmotion): Now static.
13144
cd44d2eb
PE
13145 * image.c: Make symbols static if they're not exported.
13146 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13147 if USE_GTK.
13148 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13149 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13150
ad9a7a06
PE
13151 * fringe.c (standard_bitmaps): Now static.
13152 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13153
81626931
PE
13154 * frame.c: Make symbols static if they're not exported.
13155 (x_report_frame_params, make_terminal_frame): Now static.
13156 (get_frame_param): Now static, unless HAVE_NS.
13157 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13158 (x_get_resource_string): Remove; not used.
13159 * frame.h (make_terminal_frame, x_report_frame_params):
13160 (x_get_resource_string); Remove decls.
13161 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13162 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13163
239f9db9
PE
13164 * font.c, fontset.c: Make symbols static if they're not exported.
13165 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13166 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13167 * font.c (font_close_object): Now static.
13168 * font.h (font_close_object): Remove.
13169 * fontset.c (FONTSET_OBJLIST): Remove.
13170 (free_realized_fontset) #if-0 the body, which does nothing.
13171 (face_suitable_for_char_p): #if-0, as it's never called.
13172 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13173 * xfaces.c (face_at_string_position):
13174 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13175 since 0 is always ASCII.
13176
dfcf3579
PE
13177 * fns.c (weak_hash_tables): Now static.
13178
5045092b
PE
13179 * fileio.c: Make symbols static if they're not exported.
13180 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13181 (Vwrite_region_annotation_buffers): Now static.
13182
57a96f5c
PE
13183 * eval.c: Make symbols static if they're not exported.
13184 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13185 * lisp.h (backtrace_list): Remove decl.
13186
35f08c38
PE
13187 * emacs.c: Make symbols static if they're not exported.
13188 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13189 (fatal_error_code, fatal_error_signal_hook, standard_args):
13190 Now static.
13191 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13192 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13193 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13194 * lisp.h (fatal_error_signal_hook): Remove decl.
13195 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13196
f44bd759
PE
13197 * editfns.c: Move a (normally-unused) function to its only use.
13198 * editfns.c, lisp.h (get_operating_system_release): Remove.
13199 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13200 worth the hassle of breaking this out.
13201
b532497d
PE
13202 * xterm.c: Make symbols static if they're not exported.
13203 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13204 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13205 (x_destroy_window, x_delete_display):
13206 Now static.
13207 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13208 (x_mouse_leave): Remove; unused.
13209 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13210 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13211 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13212 Remove decls.
13213 (x_mouse_leave): Declare only if WINDOWSNT.
13214 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13215 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13216 USE_X_TOOLKIT.
13217
1675728f
PE
13218 * ftxfont.c: Make symbols static if they're not exported.
13219 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13220 HAVE_FREETYPE.
13221 * font.h (ftxfont_driver): Likewise.
13222
e4cebfca
PE
13223 * xfns.c: Make symbols static if they're not exported.
13224 (x_last_font_name, x_display_info_for_name):
13225 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13226 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13227 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13228 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13229 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13230 (last_show_tip_args): Now static.
13231 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13232 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13233 (x_screen_planes): Remove; unused.
13234 * dispextern.h (x_screen_planes): Remove decl.
13235
5bf46f05
PE
13236 * dispnew.c: Make symbols static if they're not exported.
13237 * dispextern.h (redraw_garbaged_frames, scrolling):
13238 (increment_row_positions): Remove.
13239 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13240 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13241 Now static.
13242 (redraw_garbaged_frames): Remove; unused.
13243
435f4c28
PE
13244 * xfaces.c: Make symbols static if they're not exported.
13245 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13246 Remove decls.
13247 * xterm.h (defined_color): Remove decls.
13248 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13249 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13250 (menu_face_changed_default, defined_color, free_realized_face):
13251 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13252 (ascii_face_of_lisp_face): Remove; unused.
13253
8524aef3
PE
13254 * xdisp.c: Make symbols static if they're not exported.
13255 * dispextern.h (scratch_glyph_row, window_box_edges):
13256 (glyph_to_pixel_coords, set_cursor_from_row):
13257 (get_next_display_element, set_iterator_to_next):
13258 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13259 (show_mouse_face): Remove decls
13260 * frame.h (message_buf_print): Likewise.
13261 * lisp.h (pop_message, set_message, check_point_in_composition):
13262 Likewise.
13263 * xterm.h (set_vertical_scroll_bar): Likewise.
13264 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13265 (message_buf_print, scratch_glyph_row, displayed_buffer):
13266 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13267 (get_next_display_element, show_mouse_face, window_box_edges):
13268 (frame_to_window_pixel_xy, check_point_in_composition):
13269 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13270 (glyph_to_pixel_coords): Remove; unused.
13271
16390cd2
PE
13272 * dired.c (file_name_completion): Now static.
13273
13274 * dbusbind.c (xd_in_read_queued_messages): Now static.
13275
a25f4dfa
PE
13276 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13277 * data.c (circular_list_error): Remove.
13278
14a9c8df
PE
13279 * commands.h (last_point_position, last_point_position_buffer):
13280 (last_point_position_window): Remove decls.
13281 * keyboard.c: Make these variables static.
13282
04f2d78b
CB
13283 * coding.h (coding, code_convert_region, encode_coding_gap):
13284 Remove decls.
74ab6df5
PE
13285 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13286 (iso_code_class, detect_coding, code_convert_region): Now static.
13287 (encode_coding_gap): Remove; unused.
13288
38dfbee1
PE
13289 * chartab.c (chartab_chars, chartab_bits): Now static.
13290
a2cb4e63
PE
13291 * charset.h (charset_iso_8859_1): Remove decl.
13292 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13293 Now static.
13294
127198fd
PE
13295 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13296 * ccl.c (Vccl_program_table): Now static.
13297 (check_ccl_update): Remove; unused.
13298
d85b608f
PE
13299 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13300 * category.h: ... from here.
13301 * category.c (check_category_table, set_category_set): Now static.
13302
31cd66f3
PE
13303 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13304 * lisp.h: Remove these decls.
13305
c358e587
PE
13306 * buffer.c (buffer_count): Remove unused var.
13307
e78aecca
PE
13308 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13309 so that it's not optimized away.
13310 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13311 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13312 exported only to the debugger.
13313
e192d7d3 13314 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13315 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13316
92470028
PE
13317 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13318 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13319 was inaccessible from Lisp.
13320 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13321 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13322
244ed907
PE
13323 alloc.c: Import and export fewer symbols, and remove unused items.
13324 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13325 is defined.
13326 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13327 it's not optimized away by whole-program optimization.
13328 (message_enable_multibyte, free_misc): Remove.
13329 (catchlist, handlerlist, mark_backtrace):
13330 Declare only if BYTE_MARK_STACK.
13331 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13332 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13333 (message_enable_multibyte): Remove decl.
13334 (free_misc, interval_free_list, float_block, float_block_index):
13335 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13336 (cons_free_list, last_marked_index):
13337 Now static.
13338 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13339 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13340 (mark_backtrace): Define only if BYTE_MARK_STACK.
13341 * xdisp.c (message_enable_multibyte): Now static.
13342
61c2b50e 13343 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13344 This makes it easier for human readers (and static analyzers)
13345 to see whether these variables are used from other modules.
13346 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13347 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13348 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13349 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13350 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13351 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13352 * xmenu.c, xselect.c:
13353 Declare Q* vars static if they are not used in other modules.
13354 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13355 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13356 Remove decls of unexported vars.
13357 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13358
95c82688
PE
13359 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13360
16a97296
PE
13361 Make Emacs functions such as Fatom 'static' by default.
13362 This makes it easier for human readers (and static analyzers)
13363 to see whether these functions can be called from other modules.
13364 DEFUN now defines a static function. To make the function external
13365 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13366 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13367 (Finit_image_library):
16a97296
PE
13368 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13369 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13370 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13371 Remove decls, since these functions are now static.
13372 (Funintern, Fget_internal_run_time): New decls, since these functions
13373 were already external.
95c82688 13374
16a97296
PE
13375 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13376 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13377 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13378 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13379 * keyboard.c, keymap.c, lread.c:
13380 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13381 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13382 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13383 Mark functions with DEFUE instead of DEFUN,
13384 if they are used in other modules.
13385 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13386 decls for now-static functions.
13387 * buffer.h (Fdelete_overlay): Remove decl.
13388 * callproc.c (Fgetenv_internal): Mark as internal.
13389 * composite.c (Fremove_list_of_text_properties): Remove decl.
13390 (Fcomposition_get_gstring): New forward static decl.
13391 * composite.h (Fcomposite_get_gstring): Remove decl.
13392 * dired.c (Ffile_attributes): New forward static decl.
13393 * doc.c (Fdocumntation_property): New forward static decl.
13394 * eval.c (Ffetch_bytecode): New forward static decl.
13395 (Funintern): Remove extern decl; now in .h file where it belongs.
13396 * fileio.c (Fmake_symbolic_link): New forward static decl.
13397 * image.c (Finit_image_library): New forward static decl.
13398 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13399 * intervals.h (Fprevious_property_change):
13400 (Fremove_list_of_text_properties): Remove decls.
13401 * keyboard.c (Fthis_command_keys): Remove decl.
13402 (Fcommand_execute): New forward static decl.
13403 * keymap.c (Flookup_key): New forward static decl.
13404 (Fcopy_keymap): Now static.
13405 * keymap.h (Flookup_key): Remove decl.
13406 * process.c (Fget_process): New forward static decl.
13407 (Fprocess_datagram_address): Mark as internal.
13408 * syntax.c (Fsyntax_table_p): New forward static decl.
13409 (skip_chars): Remove duplicate decl.
13410 * textprop.c (Fprevious_property_change): New forward static decl.
13411 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13412 Now internal.
13413 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13414 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13415
785bbd42
PE
13416 * editfns.c (Fformat): Remove unreachable code.
13417
8b913b57
AS
134182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13419
13420 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13421 change. (Bug#8496)
13422
a6744a35
EZ
134232011-04-13 Eli Zaretskii <eliz@gnu.org>
13424
13425 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13426 when at ZV. (Bug#8487)
13427
e7974947
AS
134282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13429
baad03f0
AS
13430 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13431 (Bug#8437)
13432 * keyboard.c (parse_tool_bar_item): Likewise.
13433 * sound.c (sound_cleanup, alsa_close): Likewise.
13434 * termcap.c (tgetent): Likewise.
13435 * xfns.c (x_default_font_parameter): Likewise.
13436 * xsettings.c (read_and_apply_settings): Likewise.
13437
e7974947
AS
13438 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13439 (overrun_check_free): Protoize.
13440
28272684
PE
134412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13442
13443 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13444 since callers should never pass a negative size.
13445 Change the signature to match that of plain 'read' and 'write'; see
13446 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13447 * lisp.h: Update prototypes of emacs_write and emacs_read.
13448
11997c76
EZ
134492011-04-11 Eli Zaretskii <eliz@gnu.org>
13450
13451 * xdisp.c (redisplay_window): Don't try to determine the character
13452 position of the scroll margin if the window start point w->startp
e896f03c 13453 is outside the buffer's accessible region. (Bug#8468)
11997c76 13454
8a2cbd72
EZ
134552011-04-10 Eli Zaretskii <eliz@gnu.org>
13456
13457 Fix write-region and its subroutines for buffers > 2GB.
13458 * fileio.c (a_write, e_write): Modify declaration of arguments and
13459 local variables to support buffers larger than 2GB.
13460 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13461
13462 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13463 argument, local variables, and return value.
13464
13465 * lisp.h: Update prototypes of emacs_write and emacs_read.
13466
13467 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13468
4073e537 134692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13470
1ebfdcb6
PE
13471 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13472
b2ded58d
PE
13473 Fix more problems found by GCC 4.6.0's static checks.
13474
7d66342c
PE
13475 * xdisp.c (vmessage): Use a better test for character truncation.
13476
bbf47d44
PE
13477 * charset.c (load_charset_map): <, not <=, for optimization,
13478 and to avoid potential problems with integer overflow.
9248994d 13479 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13480 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13481 * editfns.c (Fformat): Likewise.
1e69125e 13482 * syntax.c (skip_chars): Likewise.
3befa583 13483
e3019616
PE
13484 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13485 This also lets GCC 4.6.0 generate slightly better loop code.
13486
becfa255
PE
13487 * callint.c (Fcall_interactively): <, not <=, for optimization.
13488 (Fcall_interactively): Count the number of arguments produced,
13489 not the number of arguments given. This is simpler and lets GCC
13490 4.6.0 generate slightly better code.
13491
dae0cd48
PE
13492 * ftfont.c: Distingish more carefully between FcChar8 and char.
13493 The previous code passed unsigned char * to a functions like
13494 strlen and xstrcasecmp that expect char *, which does not
13495 conform to the C standard.
13496 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13497 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13498 char * when the C standard requires it.
13499
76032d70
PE
13500 * keyboard.c (read_char): Remove unused var.
13501
eb3f1cc8
PE
13502 * eval.c: Port to Windows vsnprintf (Bug#8435).
13503 Include <limits.h>.
13504 (SIZE_MAX): Define if the headers do not.
13505 (verror): Do not give up if vsnprintf returns a negative count.
13506 Instead, grow the buffer. This ports to Windows vsnprintf, which
13507 does not conform to C99. Problem reported by Eli Zaretskii.
13508 Also, simplify the allocation scheme, by avoiding the need for
13509 calling realloc, and removing the ALLOCATED variable.
13510
70476b54
PE
13511 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13512
12020a9e
PE
13513 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13514 But keep the doprint source code for now, as we might revamp it
13515 and use it again (Bug#8435).
ea6c7ae6
PE
13516 * lisp.h (doprnt): Remove.
13517 * Makefile.in (base_obj): Remove doprnt.o.
13518 * deps.mk (doprnt.o): Remove.
13519
5fdb398c
PE
13520 error: Print 32- and 64-bit integers portably (Bug#8435).
13521 Without this change, on typical 64-bit hosts error ("...%d...", N)
13522 was used to print both 32- and 64-bit integers N, which relied on
13523 undefined behavior.
61bdb816 13524 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13525 * lisp.h (error, verror): Mark as printf-like functions.
13526 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13527 Report overflow in size calculations when allocating printf buffer.
13528 Do not truncate output string at its first null byte.
13529 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13530 Truncate the output at a character boundary, since vsnprintf does not
13531 do that.
13532 * charset.c (check_iso_charset_parameter): Convert internal
13533 character to string before calling 'error', since %c now has the
13534 printf meaning.
13535 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13536 overflow when computing char to be passed to 'error'. Do not
13537 pass Lisp_Object to 'error'; pass the integer instead.
13538 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13539 formatted with plain %d.
13540
b189fa66
PE
13541 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13542
bff87ef0
PE
13543 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13544
7e2cac20
PE
13545 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13546
ce4d90b5
PE
13547 * xterm.c (x_catch_errors): Remove duplicate declaration.
13548
266c9547
PE
13549 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13550
79c49ad2
PE
13551 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13552
368f4090
JM
135532011-04-10 Jim Meyering <meyering@redhat.com>
13554
13555 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13556 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13557 return ssize_t not "int", and use size_t as the buffer length.
13558 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13559 * gnutls.h: Update declarations.
13560 * process.c (read_process_output): Use ssize_t, to match.
13561 (send_process): Likewise.
13562
a32d4040
CY
135632011-04-09 Chong Yidong <cyd@stupidchicken.com>
13564
13565 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13566
8546720e 135672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13568
04f2d78b
CB
13569 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13570 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13571
8546720e
GM
13572 * xterm.c (handle_one_xevent):
13573 * xmenu.c (create_and_show_popup_menu):
13574 * xselect.c (x_decline_selection_request)
13575 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13576
0a2f5c1a 135772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13578
13579 Fix some uses of `int' instead of EMACS_INT.
13580 * search.c (string_match_1, fast_string_match)
13581 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13582 (scan_buffer, find_next_newline_no_quit)
13583 (find_before_next_newline, search_command, Freplace_match)
13584 (Fmatch_data): Make some `int' variables be EMACS_INT.
13585
13586 * xdisp.c (display_count_lines): 3rd argument and return value now
13587 EMACS_INT. All callers changed.
13588 (pint2hrstr): Last argument is now EMACS_INT.
13589
13590 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13591 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13592 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13593 (decode_coding_utf_16, decode_coding_emacs_mule)
13594 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13595 (decode_coding_ccl, decode_coding_charset)
13596 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13597 (decode_coding_iso_2022, decode_coding_emacs_mule)
13598 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13599 <char_offset, last_offset>: Declare EMACS_INT.
13600 (encode_coding_utf_8, encode_coding_utf_16)
13601 (encode_coding_emacs_mule, encode_invocation_designation)
13602 (encode_designation_at_bol, encode_coding_iso_2022)
13603 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13604 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13605 Declare EMACS_INT.
13606 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13607 (encode_invocation_designation): Last argument P_NCHARS is now
13608 EMACS_INT.
13609 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13610 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13611
13612 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13613 All users changed.
13614
13615 * ccl.c (Fccl_execute_on_string): Declare some variables
13616 EMACS_INT.
13617
8546720e 136182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13619
13620 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13621
4e19a977
CS
136222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13623
13624 * process.c (Fformat_network_address): Doc fix.
13625
87302331
R
136262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13627
ee7683eb 13628 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13629
cbb59342
CY
136302011-04-08 Chong Yidong <cyd@stupidchicken.com>
13631
13632 * keyboard.c (read_char): Call Lisp function help-form-show,
13633 instead of using internal_with_output_to_temp_buffer.
13634 (Qhelp_form_show): New var.
e0d38eeb 13635 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13636
13637 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13638
13639 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13640
e67a13ab
CY
136412011-04-06 Chong Yidong <cyd@stupidchicken.com>
13642
04f2d78b
CB
13643 * process.c (Flist_processes): Remove to Lisp.
13644 (list_processes_1): Delete.
e67a13ab 13645
973f782d
EZ
136462011-04-06 Eli Zaretskii <eliz@gnu.org>
13647
7c106b1e
EZ
13648 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13649
973f782d
EZ
13650 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13651
41cf7d1a 136522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13653
ca23cc88
PE
13654 Fix more problems found by GCC 4.6.0's static checks.
13655
f390e2d5
PE
13656 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13657
42eea0d0
PE
13658 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13659
b69769da 13660 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13661
f9541e84
PE
13662 * xdisp.c (vmessage): Mark as a printf-like function.
13663
13841b55
PE
13664 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13665
c136c10f
PE
13666 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13667
5e2d4a30
PE
13668 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13669 printf-like functions.
13670 (tiff_load): Add casts to remove these marks before passing them
13671 to system-supplied API.
13672
583f48b9
PE
13673 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13674
b25d760e
PE
13675 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13676 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13677 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13678 directly, rather than having caller test rule sign. This avoids
13679 some unnecessary tests.
13680 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13681 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13682 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13683
bc7b6697 13684 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13685 (xfont_open): Avoid unnecessary tests.
bc7b6697 13686
27ccc379
PE
13687 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13688
dcd5c89a
PE
13689 * composite.h, composite.c (composition_gstring_put_cache):
13690 Use EMACS_INT, not int, for length.
13691
b13a45c6
PE
13692 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13693 breaking out part of COMPOSITION_DECODE_RULE.
13694 (COMPOSITION_DECODE_RULE): Use it.
13695 * composite.c (get_composition_id): Remove unused local vars,
13696 by using the new macro.
13697
1e792e4d
PE
13698 * textprop.c (set_text_properties_1): Change while to do-while,
13699 since the condition is always true at first.
13700
dc6c6455 13701 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13702 (interval_deletion_adjustment): Return unsigned value.
13703 All uses changed.
dc6c6455 13704
aba7731a
PE
13705 * process.c (list_processes_1, create_pty, read_process_output):
13706 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13707 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13708 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13709 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13710 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13711
fdfc4bf3
PE
13712 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13713
fca8fe46 13714 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13715 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13716
06a0259a 13717 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13718 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13719 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13720
e7b9e80f
PE
13721 * print.c (print_error_message): Avoid int overflow.
13722
56201685
PE
13723 * font.c (font_list_entities): Redo for clarity,
13724 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13725
78834453 13726 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13727 (font_score): Avoid potential overflow in diff calculation.
78834453 13728
0bc0b309 13729 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13730 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13731
e610eaca
PE
13732 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13733
b895abce
PE
13734 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13735 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13736 can always succeed if overflow has undefined behavior.
13737
1f1d9321 13738 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13739 (wordify): Omit three unnecessary tests.
1f1d9321 13740
c59478bc
PE
13741 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13742 All callers changed. This avoids the need for an unused var.
13743
79b73827
PE
13744 * casefiddle.c (casify_region): Remove var that is set but not used.
13745
a4db5dfe
PE
13746 * dired.c (file_name_completion): Remove var that is set but not used.
13747
43aae36e
PE
13748 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13749
2a47c44d 13750 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13751 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13752
a37c69bf
PE
13753 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13754 Check for integer overflow on size calculations.
13755
328ab8e7
PE
13756 * buffer.c (Fprevious_overlay_change): Remove var that is set
13757 but not used.
13758
e5a2a5cb
PE
13759 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13760 Remove vars that are set but not used.
8d84a6eb 13761 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13762 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13763
a60e5f68
PE
13764 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13765
f661cb61 13766 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13767 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13768
f0397f5a
PE
13769 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13770 that are set but not used.
13771
8664db06 13772 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13773 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13774
6abdaa4a
PE
13775 * xselect.c (x_get_local_selection, x_handle_property_notify):
13776 Remove vars that are set but not used.
13777
0ce7538d 13778 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13779 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13780
9ae848fc
PE
13781 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13782 Remove var that is set but not used.
0b918413
PE
13783 (scroll_bar_windows_size): Now size_t, not int.
13784 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13785 Check for overflow.
9ae848fc 13786
a5a62657
PE
13787 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13788 (map_tty_color) [!defined MSDOS]: Likewise.
13789
5c5cdd39
PE
13790 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13791
66ebf983
PE
13792 * coding.c: Remove vars that are set but not used.
13793 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13794 All callers changed.
13795 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13796 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13797 (decode_coding_charset): Remove vars that are set but not used.
13798
1be4d761
PE
13799 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13800 that is set but not used.
13801
47553fa8
PE
13802 * print.c (print_object): Remove var that is set but not used.
13803
1f7196bf 13804 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13805 The gnulib version avoids calling malloc in the usual case,
13806 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13807 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13808 * filelock.c (current_lock_owner): Likewise.
13809 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13810 * sysdep.c: Include allocator.h, careadlinkat.h.
13811 (emacs_no_realloc_allocator): New static constant.
13812 (emacs_readlink): New function.
fdb61804
PE
13813 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13814 ../lib/careadlinkat.h.
d1fdcab7 13815
f84c17c7
SM
138162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13817
13818 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13819 first non-nil return value).
13820
ef3862ad
JD
138212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13822
13823 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13824 if not defined (Bug#8403).
13825
376a7006
JB
138262011-04-02 Juanma Barranquero <lekktu@gmail.com>
13827
13828 * xdisp.c (display_count_lines): Remove parameter `start',
13829 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13830 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13831 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13832 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13833 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13834 and thereabouts. All callers changed.
13835 (get_per_char_metric): Remove parameter `f', unused since
13836 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13837
6ca3801d
JM
138382011-04-02 Jim Meyering <meyering@redhat.com>
13839
13840 do not dereference NULL upon failed strdup
13841 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13842 (ns_get_family): Likewise.
13843
d8e2b5ba
JB
138442011-04-02 Juanma Barranquero <lekktu@gmail.com>
13845
13846 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13847
8c74fcbd
JD
138482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13849
13850 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13851 later (Bug#8403).
13852
7200d79c
SM
138532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13854
03408648 13855 Add lexical binding.
7200d79c 13856
03408648
SM
13857 * window.c (Ftemp_output_buffer_show): New fun.
13858 (Fsave_window_excursion):
13859 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13860
13861 * lread.c (lisp_file_lexically_bound_p): New function.
13862 (Fload): Bind Qlexical_binding.
13863 (readevalloop): Remove `evalfun' arg.
13864 Bind Qinternal_interpreter_environment.
13865 (Feval_buffer): Bind Qlexical_binding.
13866 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13867 Mark as dynamic.
13868 (syms_of_lread): Declare `lexical-binding'.
13869
13870 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13871
13872 * keyboard.c (eval_dyn): New fun.
13873 (menu_item_eval_property): Use it.
ca105506
SM
13874
13875 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13876
03408648
SM
13877 * fns.c (concat, mapcar1): Accept byte-code-functions.
13878
13879 * eval.c (Fsetq): Handle lexical vars.
13880 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13881 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13882 (FletX, Flet): Obey lexical binding.
13883 (Fcommandp): Handle closures.
13884 (Feval): New `lexical' arg.
13885 (eval_sub): New function extracted from Feval. Use it almost
13886 everywhere where Feval was used. Look up vars in lexical env.
13887 Handle closures.
13888 (Ffunctionp): Move from subr.el.
13889 (Ffuncall): Handle closures.
13890 (apply_lambda): Remove `eval_flags'.
13891 (funcall_lambda): Handle closures and new byte-code-functions.
13892 (Fspecial_variable_p): New function.
13893 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13894 but without exporting it to Lisp.
23aba0ea 13895
23aba0ea 13896 * doc.c (Fdocumentation, store_function_docstring):
03408648 13897 * data.c (Finteractive_form): Handle closures.
23aba0ea 13898
03408648
SM
13899 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13900 interactive spec.
ba83908c 13901
04f2d78b
CB
13902 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13903 New byte-codes.
03408648
SM
13904 (exec_byte_code): New function extracted from Fbyte_code to handle new
13905 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13906
03408648 13907 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13908
03408648 13909 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13910
e2abce01
JB
139112011-03-31 Juanma Barranquero <lekktu@gmail.com>
13912
13913 * xdisp.c (redisplay_internal): Fix prototype.
13914
63696a73 139152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13916
63696a73 13917 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13918 (try_scrolling): Use it when setting scroll_limit.
13919 Limit scrolling to 100 screen lines.
63696a73
EZ
13920 (redisplay_window): Even when falling back on "recentering",
13921 position point in the window according to scroll-conservatively,
13922 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13923
13924 (try_scrolling): When point is above the window, allow searching
13925 as far as scroll_max, or one screenful, to compute vertical
13926 distance from PT to the scroll margin position. This prevents
13927 try_scrolling from unnecessarily failing when
13928 scroll-conservatively is set to a value slightly larger than the
13929 window height. Clean up the case of PT below the margin at bottom
13930 of window: scroll_max can no longer be INT_MAX. When aggressive
13931 scrolling is in use, don't let point enter the opposite scroll
13932 margin as result of the scroll.
13933 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13934 threshold of 100 lines for never-recentering scrolling.
13935
e4cc2dfc
JB
139362011-03-31 Juanma Barranquero <lekktu@gmail.com>
13937
13938 * dispextern.h (move_it_by_lines):
13939 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13940 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13941 (message_log_check_duplicate): Remove parameters `prev_bol' and
13942 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13943 (redisplay_internal): Remove parameter `preserve_echo_area',
13944 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13945
13946 * indent.c (Fvertical_motion):
13947 * window.c (window_scroll_pixel_based, Frecenter):
13948 Don't pass `need_y_p' to `move_it_by_lines'.
13949
1c470562
SM
139502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13951
44f230aa
SM
13952 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13953 steal a few bits to be more compact.
13954 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13955 Remove unneeded casts.
13956
1c470562
SM
13957 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13958
888adce9
ZK
139592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13960
13961 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13962 binding" message (bug#7967).
13963
f838ed7b
PE
139642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13965
77861b95
PE
13966 Fix more problems found by GCC 4.6.0's static checks.
13967
de6dbc14
PE
13968 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13969 Remove unused local var.
13970
f838ed7b
PE
13971 * editfns.c (Fmessage_box): Remove unused local var.
13972
792c7b2b
PE
13973 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13974 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13975 Omit unused local vars.
c499e557 13976 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13977 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13978 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13979 Omit unused local var.
13980
ba0165e1
PE
13981 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13982 Don't assume string length fits in int.
32ad8845 13983 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13984 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13985
3c59b4c9
PE
13986 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13987 instead of alloca (Bug#8344).
13988
a3eed478 13989 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13990 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13991
eb4d412d
PE
13992 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13993
1658b401
PE
13994 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13995 concerns.
13996
13997 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13998
13999 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14000
9a2c6e05
PE
14001 * keyboard.c (syms_of_keyboard): Use the same style as later
14002 in this function when indexing through an array. This also
14003 works around GCC bug 48267.
14004
03d0a109
PE
14005 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14006
44f730c8
PE
14007 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14008
fe75f926
PE
14009 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14010 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14011
ffa8c828
PE
14012 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14013 This avoids undefined behavior on integer overflow, and is a bit
14014 more convenient anyway since it is compared to a size_t variable.
14015
c5101a77
PE
14016 Variadic C functions now count arguments with size_t, not int.
14017 This avoids an unnecessary limitation on 64-bit machines, which
14018 caused (substring ...) to crash on large vectors (Bug#8344).
14019 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14020 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14021 All variadic functions and their callers changed accordingly.
c5101a77
PE
14022 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14023 * data.c (arith_driver, float_arith_driver): Likewise.
14024 * editfns.c (general_insert_function): Likewise.
14025 * eval.c (struct backtrace.nargs, interactive_p)
14026 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14027 (funcall_lambda, mark_backtrace): Likewise.
14028 * fns.c (concat): Likewise.
14029 * frame.c (x_set_frame_parameters): Likewise.
14030 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14031 0 if not found, not -1. All callers changed.
14032
dd3f25f7
PE
14033 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14034 (stack_copy_size): Now size_t, not int.
14035 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14036
461c2ab9
JB
140372011-03-28 Juanma Barranquero <lekktu@gmail.com>
14038
14039 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14040 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14041 All callers changed.
14042
14043 * lisp.h (multibyte_char_to_unibyte):
14044 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14045 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14046 * character.h (CHAR_TO_BYTE8):
14047 * cmds.c (internal_self_insert):
14048 * editfns.c (general_insert_function):
14049 * keymap.c (push_key_description):
14050 * search.c (Freplace_match):
14051 * xdisp.c (message_dolog, set_message_1): All callers changed.
14052
f6d62986
SM
140532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14054
14055 * keyboard.c (safe_run_hook_funcall): New function.
14056 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14057 don't set the hook to nil, but remove the offending function instead.
14058 (Qcommand_hook_internal): Remove, unused.
14059 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14060 Vcommand_hook_internal.
14061
14062 * eval.c (enum run_hooks_condition): Remove.
14063 (funcall_nil, funcall_not): New functions.
14064 (run_hook_with_args): Call each function through a `funcall' argument.
14065 Remove `cond' argument, now redundant.
14066 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14067 (Frun_hook_with_args_until_failure): Adjust accordingly.
14068 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14069
1db5b1ad
JB
140702011-03-28 Juanma Barranquero <lekktu@gmail.com>
14071
14072 * dispextern.h (string_buffer_position): Remove declaration.
14073
14074 * print.c (strout): Remove parameter `multibyte', unused since
14075 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14076
14077 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14078 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14079 All callers changed.
14080
14081 * w32.c (_wsa_errlist): Use braces for struct initializers.
14082
14083 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14084 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14085 All callers changed.
14086 (string_buffer_position): Likewise. Also, make static (it's never
14087 used outside xdisp.c).
14088 (cursor_row_p): Remove parameter `w', unused since
14089 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14090 (decode_mode_spec): Remove parameter `precision', introduced during
14091 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14092 All callers changed.
14093
5ffb62aa
JD
140942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14095
14096 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14097
461c2ab9 140982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14099
14100 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14101 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14102 (ns_update_auto_hide_menu_bar): New functions.
14103 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14104 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14105 ns_constrain_all_frames.
14106 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14107 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14108
5c380ffb
JD
141092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14110
14111 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14112
9af30bdf
GM
141132011-03-27 Glenn Morris <rgm@gnu.org>
14114
14115 * syssignal.h: Replace RETSIGTYPE with void.
14116 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14117 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14118 Replace SIGTYPE with void everywhere.
14119 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14120 * s/template.h (SIGTYPE): Remove commented out definition.
14121
e2abce01
JB
141222011-03-26 Eli Zaretskii <eliz@gnu.org>
14123
14124 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14125 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14126
f868cd8a
JB
141272011-03-26 Juanma Barranquero <lekktu@gmail.com>
14128
59eb0929
JB
14129 * w32.c (read_unc_volume): Use parameter `henum', instead of
14130 global variable `wget_enum_handle'.
14131
14132 * keymap.c (describe_vector): Remove parameters `indices' and
14133 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14134 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14135
f868cd8a
JB
14136 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14137
14138 * keyboard.c (timer_check): Remove parameter `do_it_now',
14139 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14140 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14141 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14142
14143 * keyboard.c (read_char):
14144 * w32menu.c (w32_menu_display_help):
14145 * xmenu.c (show_help_event, menu_help_callback):
14146 Adjust calls to `show_help_echo'.
14147
14148 * gtkutil.c (xg_maybe_add_timer):
14149 * keyboard.c (readable_events):
14150 * process.c (wait_reading_process_output):
14151 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14152
14153 * insdel.c (adjust_markers_gap_motion):
14154 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14155 (gap_left, gap_right): Don't call it.
14156
2ecf6fdb
CY
141572011-03-25 Chong Yidong <cyd@stupidchicken.com>
14158
14159 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14160 incurred during fontification.
14161
6b1f9ba4
JB
141622011-03-25 Juanma Barranquero <lekktu@gmail.com>
14163
14164 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14165 (DEFVAR_PER_BUFFER): Don't pass it.
14166
14167 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14168 (scrolling_window): Don't pass it.
14169
0f4a96b5
JB
141702011-03-25 Juanma Barranquero <lekktu@gmail.com>
14171
14172 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14173
14174 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14175 and `suffix'.
14176 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14177 of variables specific to SELinux and computation of `encoded_absname'.
14178
14179 * image.c (XPutPixel): Remove unused variable `height'.
14180
14181 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14182
14183 * unexw32.c (get_section_info): Remove unused variable `section'.
14184
14185 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14186 (system_process_attributes): Remove unused variable `sess'.
14187 (sys_read): Remove unused variable `err'.
14188
14189 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14190 (w32_wnd_proc): Remove unused variable `isdead'.
14191 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14192 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14193 (x_create_tip_frame): Remove unused variable `tem'.
14194
14195 * w32inevt.c (w32_console_read_socket):
14196 Remove unused variable `no_events'.
14197
14198 * w32term.c (x_draw_composite_glyph_string_foreground):
14199 Remove unused variable `width'.
14200
1149507c
JB
142012011-03-24 Juanma Barranquero <lekktu@gmail.com>
14202
14203 * w32term.c (x_set_glyph_string_clipping):
14204 Don't pass uninitialized region to CombineRgn.
14205
9c88f339
JB
142062011-03-23 Juanma Barranquero <lekktu@gmail.com>
14207
14208 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14209 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14210 (Fx_close_connection): Remove unused variable `i'.
14211
14212 * w32font.c (w32font_draw): Return number of glyphs.
14213 (w32font_open_internal): Remove unused variable `i'.
14214 (w32font_driver): Add missing initializer.
14215
14216 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14217 (fill_in_menu): Remove unused variable `items_added'.
14218
14219 * w32term.c (last_mouse_press_frame): Remove static global variable.
14220 (w32_clip_to_row): Remove unused variable `f'.
14221 (x_delete_terminal): Remove unused variable `i'.
14222
14223 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14224 (NOTHING): Remove unused static global variable.
14225 (uniscribe_check_otf): Remove unused variable `table'.
14226 (uniscribe_font_driver): Add missing initializers.
14227
dee091a3
JD
142282011-03-23 Julien Danjou <julien@danjou.info>
14229
14230 * term.c (Fsuspend_tty, Fresume_tty):
14231 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14232 * window.c (temp_output_buffer_show):
14233 * insdel.c (signal_before_change):
14234 * frame.c (Fhandle_switch_frame):
14235 * fileio.c (Fdo_auto_save):
14236 * emacs.c (Fkill_emacs):
14237 * editfns.c (save_excursion_restore):
14238 * cmds.c (internal_self_insert):
14239 * callint.c (Fcall_interactively):
14240 * buffer.c (Fkill_all_local_variables):
14241 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14242 Use Frun_hooks.
0f4a96b5 14243 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14244 unconditionally since it does the check itself.
dee091a3 14245
2c520ab5 142462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14247
c9c49752
PE
14248 Fix more problems found by GCC 4.5.2's static checks.
14249
8abc3f12
PE
14250 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14251 the first time through the loop, since we know p0 < p1 then.
14252 This also avoids a gcc -Wstrict-overflow warning.
14253
a2d26660
PE
14254 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14255 leading to a memory leak, possible in functions like
14256 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14257 of objects (Bug#8318).
a2d26660 14258
916c72e9
PE
14259 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14260 that could (at least in theory) be that large.
14261
19ab8a18
PE
14262 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14263 This is less likely to overflow, and avoids undefined behavior if
14264 overflow does occur. All callers changed. Use strtoul to scan
14265 for the unsigned long integer.
b7cbbd6f
PE
14266 (pint2hrstr): Simplify and tune code slightly.
14267 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14268
f0641eff
PE
14269 * scroll.c (do_scrolling): Work around GCC bug 48228.
14270 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14271
7f650bb9
PE
14272 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14273 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14274 (validate_x_resource_name): Simplify count usage.
14275 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14276
37dd57d1
PE
14277 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14278 fail (Bug#8306).
81e56e61 14279
699979fc 14280 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14281
401bf9b4
PE
14282 * process.c (Fmake_network_process): Use socklen_t, not int,
14283 where POSIX says socklen_t is required in portable programs.
14284 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14285 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14286 (Fmake_network_process, server_accept_connection):
14287 (wait_reading_process_output, read_process_output):
14288 Likewise.
14289
b93aacde
PE
14290 * process.c: Rename or move locals to avoid shadowing.
14291 (list_processes_1, Fmake_network_process):
14292 (read_process_output_error_handler, exec_sentinel_error_handler):
14293 Rename or move locals.
4dc343ee 14294 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14295 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14296 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14297 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14298 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14299
af8a867c 14300 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14301 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14302 Include tparam.h instead, since it declares them.
af8a867c
PE
14303 * cm.h (PC): Remove extern decl; tparam.h now does this.
14304 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14305 * terminfo.c: Include tparam.h, to check interfaces.
14306 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14307 (tparam): Adjust signature to match interface in tparam.h;
14308 this removes some undefined behavior. Check that outstring and len
14309 are zero, which they always are with Emacs.
14310 * tparam.h (PC, BC, UP): New extern decls.
14311
0248044d 14312 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14313 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14314
8ff096c1 14315 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14316 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14317 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14318 (ftfont_list): Remove unused local.
49eaafba
PE
14319 (get_adstyle_property, ftfont_pattern_entity):
14320 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14321 Rename locals to avoid shadowing.
8ff096c1 14322
e2be39f6
PE
14323 * xfont.c (xfont_list_family): Mark var as initialized.
14324
c9735e30
PE
14325 * xml.c (make_dom): Now static.
14326
8f5201ae
PE
14327 * composite.c (composition_compute_stop_pos): Rename local to
14328 avoid shadowing.
b246f932
PE
14329 (composition_reseat_it): Remove unused locals.
14330 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14331 (composition_update_it): Mark var as initialized.
11b61122
PE
14332 (find_automatic_composition): Mark vars as initialized,
14333 with a FIXME (Bug#8290).
8f5201ae 14334
760fbc2c
PE
14335 character.h: Rename locals to avoid shadowing.
14336 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14337 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14338 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14339 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14340 to avoid shadowing.
14341
ff08eb85
PE
14342 * textprop.c (property_change_between_p): Remove; unused.
14343
fc7bf025
PE
14344 * intervals.c (interval_start_pos): Now static.
14345
235d7abc
PE
14346 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14347
44f230aa
SM
14348 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14349 Rename locals to avoid shadowing.
3e7d6594 14350
50060332
PE
14351 * sound.c (wav_play, au_play, Fplay_sound_internal):
14352 Fix pointer signedness.
d01f234b 14353 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14354 (wav_play): Initialize a variable to 0, to prevent undefined
14355 behavior (Bug#8278).
50060332 14356
c4fc4e30
PE
14357 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14358
918436ed
PE
14359 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14360
c939f91b
PE
14361 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14362 clobbering (Bug#8298).
b9c7f648
PE
14363 * sysdep.c (sys_subshell): Likewise.
14364 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14365
6bd8c144
PE
14366 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14367 This should get cleaned up, so that child_setup has the
14368 same signature on all platforms.
14369
7710357c 14370 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14371 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14372
c59da222
CY
143732011-03-22 Chong Yidong <cyd@stupidchicken.com>
14374
14375 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14376 not to be necessary, and produces flickering.
14377
66b87493
GM
143782011-03-20 Glenn Morris <rgm@gnu.org>
14379
14380 * config.in: Remove file.
14381
45b6f6d5
JB
143822011-03-20 Juanma Barranquero <lekktu@gmail.com>
14383
14384 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14385 are now in src/globals.h.
14386 (syms_of_minibuf): Remove spurious & from previous change.
14387
cd394be1 143882011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14389
14390 * minibuf.c (completing-read-function): New variable.
14391 (completing-read-default): Rename from completing-read.
14392 (completing-read): Call completing-read-function.
14393
b14e3e21
CY
143942011-03-19 Juanma Barranquero <lekktu@gmail.com>
14395
14396 * xfaces.c (Fx_load_color_file):
14397 Read color file from absolute filename (bug#8250).
14398
f2b726e6
JB
143992011-03-19 Juanma Barranquero <lekktu@gmail.com>
14400
14401 * makefile.w32-in: Update dependencies.
14402
09f6ff02
EZ
144032011-03-17 Eli Zaretskii <eliz@gnu.org>
14404
14405 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14406
29a6015a
PE
144072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14408
a3a6c54e
PE
14409 Fix more problems found by GCC 4.5.2's static checks.
14410
b766f867
PE
14411 * process.c (make_serial_process_unwind, send_process_trap):
14412 (sigchld_handler): Now static.
14413
be02381c
PE
14414 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14415 That way, the code declares only the vars that it needs.
14416 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14417 * s/cygwin.h (PTY_ITERATION): Likewise.
14418 * s/darwin.h (PTY_ITERATION): Likewise.
14419 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14420
57048744
PE
14421 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14422 * process.c (allocate_pty): Don't declare stb unless it's needed.
14423
7914961c 14424 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14425 (CONSTANTLIM): Remove; unused.
14426 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14427 Define only if needed.
7914961c 14428
b3967b18
PE
14429 * unexelf.c (unexec): Name an expression,
14430 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14431 Use a different way to cause a compilation error if anyone uses
14432 n rather than nn, a way that does not involve shadowing.
73366a00 14433 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14434
29a6015a
PE
14435 * deps.mk (unexalpha.o): Remove; unused.
14436
43cfc33e 14437 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14438 * unexec.h: New file.
ce701a33
PE
14439 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14440 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14441 Depend on unexec.h.
14442 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14443 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14444 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14445 Change as necessary to match prototype in unexec.h.
ce701a33 14446
01f44d5a
PE
14447 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14448 shadowing.
4f63c6bb 14449 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14450
a6670b0b
PE
14451 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14452 Rename locals to avoid shadowing.
14453
cef2010d 14454 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14455 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14456
d4d7173a
PE
14457 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14458
f08b802a
PE
14459 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14460 warning when compiling print.c.
14461
3ddb0639
PE
14462 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14463 instead of using an uninitialized var.
5ad03b97 14464 (font_sort_entities): Mark var as initialized.
3ddb0639 14465
170a2692
PE
14466 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14467
e663c700
PE
14468 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14469 pointers to constants.
89bc529a 14470 (font_parse_fcname): Remove unused vars.
7b81e2d0 14471 (font_delete_unmatched): Now static.
ea838e10 14472 (font_get_spec): Remove; unused.
13a547c6
PE
14473 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14474 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14475 Rename or move locals to avoid shadowing.
e663c700 14476
2a80c887 14477 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14478 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14479
1384fa33 14480 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14481 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14482
8b2c52e9
PE
14483 * alloc.c (mark_backtrace): Move decl from here ...
14484 * lisp.h: ... to here, so that it can be checked.
14485
475545b5 14486 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14487 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14488 (lisp_indirect_variable): Name an expression,
14489 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14490 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14491
b1349114 14492 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14493 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14494 Use const pointer when appropriate.
b1349114 14495
a2928364
PE
14496 * lisp.h (get_system_name, get_operating_system_release):
14497 Move decls here, to check interfaces.
14498 * process.c (get_operating_system_release): Move decl to lisp.h.
14499 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14500 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14501 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14502 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14503 (Fformat_time_string, Fencode_time, Finsert_char):
14504 (Ftranslate_region_internal, Fformat):
14505 Rename or remove local vars to avoid shadowing.
9710023e 14506 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14507
a415e694
PE
14508 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14509 avoid shadowing.
14510
8ef4622d
PE
14511 * lisp.h (eassert): Check that the argument compiles, even if
14512 ENABLE_CHECKING is not defined.
14513
946f9a5b
PE
14514 * data.c (Findirect_variable): Name an expression, to avoid
14515 gcc -Wbad-function-cast warning.
112396d6 14516 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14517 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14518 (Fmake_variable_buffer_local, Fmake_local_variable):
14519 Mark variables as initialized.
52746918 14520 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14521
e5aab7e7 14522 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14523 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14524 Rename locals to avoid shadowing.
dff45157
PE
14525 (mark_stack): Move local variables into the #ifdef region where
14526 they're used.
7bc26fdb
PE
14527 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14528 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14529 needed otherwise.
14530 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14531 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14532 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14533
e5aab7e7
PE
14534 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14535 avoids undefined behavior in theory.
14536
4da60324
PE
14537 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14538
88043301
PE
14539 Use functions, not macros, for up- and down-casing (Bug#8254).
14540 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14541 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14542 to use the following functions instead of these macros.
14543 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14544 EMACS_INT, since callers assume the returned value fits in int.
14545 (upcase1): Likewise, for UPCASE_TABLE.
14546 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14547 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14548 the race-condition problem in the old DOWNCASE.
88043301 14549
19ed5445
PE
14550 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14551 Rename locals to avoid shadowing.
14552 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14553 (regex_compile, re_search_2, re_match_2_internal):
14554 Remove unused local vars.
952db0d7
PE
14555 (FREE_VAR): Rewrite so as not to use empty "else",
14556 which gcc can warn about.
da053e48 14557 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14558 (RETALLOC_IF): Define only if needed.
14559 (WORDCHAR_P): Likewise. This one is never needed, but is used
14560 only in a comment talking about a compiler bug, so put inside
14561 the #if 0 of that comment.
14562 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14563 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14564 Remove; unused.
19ed5445 14565
1f3561e4 14566 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14567 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14568 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14569
ded6f8f7
PE
14570 * search.c (simple_search): Remove unused var.
14571
dbd37a95
PE
14572 * dired.c (compile_pattern): Move decl from here ...
14573 * lisp.h: ... to here, so that it can be checked.
14574 (struct re_registers): New forward decl.
14575
7e47afad
PE
14576 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14577
85f24f61
PE
14578 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14579 All uses changed.
14580 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14581 Rename locals to avoid shadowing.
5671df8f 14582 (Fvertical_motion): Mark locals as initialized.
85f24f61 14583
181aa2be 14584 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14585 (casify_region): Mark local as initialized.
181aa2be 14586
930d429c
PE
14587 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14588
7082eac6
PE
14589 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14590 New macros, so that the caller can use some names other than
14591 gcpro1, gcpro2, etc.
14592 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14593 of the new macros.
14594 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14595 argument, for consistency with GCPRO2_VAR, etc: it is now the
14596 prefix of the variable, not the variable itself. All uses
14597 changed.
38b2c076
PE
14598 * dired.c (directory_files_internal, file_name_completion):
14599 Rename locals to avoid shadowing.
14600
15206ed9
PE
14601 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14602 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14603 dired.c's scmp function, had undefined behavior.
14604 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14605 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14606 * buffer.h: ... to here, because these macros use current_buffer,
14607 and the new implementation with inline functions needs to have
14608 current_buffer in scope now, rather than later when the macros
14609 are used.
14610 (downcase, upcase1): New static inline functions.
14611 (DOWNCASE, UPCASE1): Reimplement using these functions.
14612 This avoids undefined behavior in expressions like
14613 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14614 from race conditions in accessing the global variables
14615 case_temp1 and case_temp2.
14616 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14617 * lisp.h (case_temp1, case_temp2): Remove their decls.
14618 * character.h (ASCII_CHAR_P): Move from here ...
14619 * lisp.h: ... to here, so that the inline functions mentioned
14620 above can use them.
14621
4a6bea26
PE
14622 * dired.c (directory_files_internal_unwind): Now static.
14623
f14b7e14
PE
14624 * fileio.c (file_name_as_directory, directory_file_name):
14625 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14626 Now static.
2893f146
PE
14627 (file_name_as_directory): Use const pointers when appropriate.
14628 (Fexpand_file_name): Likewise. In particular, newdir might
14629 point at constant storage, so make it a const pointer.
fd4ead52 14630 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14631 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14632 signedness issues.
f839df0c
PE
14633 (Fset_file_times, Finsert_file_contents, auto_save_error):
14634 Rename locals to avoid shadowing.
f14b7e14 14635
5716756e 14636 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14637 (Ftry_completion, Fall_completions): Rename or remove locals
14638 to avoid shadowing.
5716756e 14639
b4c3046a
PE
14640 * marker.c (bytepos_to_charpos): Remove; unused.
14641
b45db522
PE
14642 * lisp.h (verify_bytepos, count_markers): New decls,
14643 so that gcc does not warn that these functions aren't declared.
14644
85876d07
PE
14645 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14646 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14647 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14648 (copy_text): Remove unused local var.
85876d07 14649
03d78a21 14650 * filelock.c (within_one_second): Now static.
b3dd38ab 14651 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14652
5df8f01b
PE
14653 * buffer.c (fix_overlays_before): Mark locals as initialized.
14654 (fix_start_end_in_overlays): Likewise. This function should be
14655 simplified by using pointers-to-pointers, but that's a different
14656 matter.
b1d876f1 14657 (switch_to_buffer_1): Now static.
8f54f30a
PE
14658 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14659 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14660
a70072c9 14661 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14662 Fix pointer signedness issue.
edced198
PE
14663 (sys_subshell): Mark local as volatile if checking for lint,
14664 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14665 (MAXPATHLEN): Define only if needed.
a70072c9 14666
a0977c44
PE
14667 * process.c (serial_open, serial_configure): Move decls from here ...
14668 * systty.h: ... to here, so that they can be checked.
14669
a884fdcc
PE
14670 * fns.c (get_random, seed_random): Move extern decls from here ...
14671 * lisp.h: ... to here, so that they can be checked.
14672
604efe86 14673 * sysdep.c (reset_io): Now static.
b8950c94 14674 (wait_for_termination_signal): Remove; unused.
604efe86 14675
38fc62d9
PE
14676 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14677 (copy_keymap_item, append_key, push_text_char_description):
14678 Now static.
1004a21a 14679 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14680 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14681 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14682 (describe_map_tree):
14683 Rename locals to avoid shadowing.
38fc62d9 14684
2f2650da
PE
14685 * keyboard.c: Declare functions static if they are not used elsewhere.
14686 (echo_char, echo_dash, cmd_error, top_level_2):
14687 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14688 (read_char, kbd_buffer_get_event, make_lispy_position):
14689 (make_lispy_event, make_lispy_movement, apply_modifiers):
14690 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14691 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14692 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14693 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14694 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14695
a053e86c 14696 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14697 (mark_kboards): Move decl here ...
14698 * alloc.c (mark_kboards): ... from here.
a053e86c 14699
4752793e
PE
14700 * lisp.h (force_auto_save_soon): New decl.
14701
74f10ca7 14702 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14703 (DEFINE_DUMMY_FUNCTION): New macro.
14704 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14705 Use it.
c03cd23f
PE
14706 (main): Add casts to avoid warnings
14707 if GCC considers string literals to be constants.
74f10ca7 14708
022e70d4
PE
14709 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14710
59d6fe83
PE
14711 * dbusbind.c: Pointer signedness fixes.
14712 (xd_signature, xd_append_arg, xd_initialize):
14713 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14714 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14715 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14716 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14717
78320123
PE
14718 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14719 if GCC considers string literals to be constants.
49cebcca 14720 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14721
35ac2a97
SM
147222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14723
fb103ca9
SM
14724 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14725 (print_preprocess, print_object): New macro to fix last change.
14726
35ac2a97
SM
14727 * print.c (print_preprocess): Don't forget font objects.
14728
62973b41
JB
147292011-03-16 Juanma Barranquero <lekktu@gmail.com>
14730
14731 * emacs.c (USAGE3): Doc fixes.
14732
0e48bb22
AS
147332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14734
14735 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14736 structure.
14737
7684e57b
JB
147382011-03-14 Juanma Barranquero <lekktu@gmail.com>
14739
14740 * lisp.h (VWindow_system, Qfile_name_history):
14741 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14742 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14743 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14744
14745 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14746 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14747
14748 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14749 * w32console.c (detect_input_pending, read_input_pending)
14750 (encode_terminal_code):
14751 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14752 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14753 (w32_system_caret_y, Qfile_name_history):
14754 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14755 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14756 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14757 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14758 * w32proc.c (Qlocal, report_file_error):
14759 * w32term.c (Vwindow_system, updating_frame):
14760 * w32uniscribe.c (initialized, uniscribe_font_driver):
14761 Remove unneeded extern declarations.
14762
2aa46d6c
CY
147632011-03-14 Chong Yidong <cyd@stupidchicken.com>
14764
c96bbc66 14765 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14766
cffc6f3b
CY
147672011-03-13 Chong Yidong <cyd@stupidchicken.com>
14768
14769 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14770 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14771 These macros can no longer be used for assignment.
14772
44f230aa
SM
14773 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14774 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14775 (record_buffer_markers, fetch_buffer_markers): New functions for
14776 recording and fetching special buffer markers.
14777 (set_buffer_internal_1, set_buffer_temp): Use them.
14778
14779 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14780
14781 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14782
14783 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14784 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14785
14786 * xdisp.c (hscroll_window_tree):
14787 (reconsider_clip_changes): Use PT instead of BUF_PT.
14788
d251f04b
EZ
147892011-03-13 Eli Zaretskii <eliz@gnu.org>
14790
14791 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14792 $(EMACS_ROOT)/lib/intprops.h.
14793
f0c77cd1
PE
147942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14795
3eca4629
PE
14796 Fix more problems found by GCC 4.5.2's static checks.
14797
7c86ee98
PE
14798 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14799 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14800 (xg_free_frame_widgets): Make it clear that a local variable is
14801 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14802 (gdk_window_get_screen): Make it clear that this macro is needed
14803 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14804 (int_gtk_range_get_value): New function, which avoids a diagnostic
14805 from gcc -Wbad-function-cast.
14806 (xg_set_toolkit_scroll_bar_thumb): Use it.
14807 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14808 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14809 (get_utf8_string, xg_get_file_with_chooser):
14810 Rename locals to avoid shadowing.
14811 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14812
41729b81
PE
14813 * xgselect.c (xg_select): Remove unused var.
14814
f0c77cd1
PE
14815 * image.c (four_corners_best): Mark locals as initialized.
14816 (gif_load): Initialize transparent_p to zero (Bug#8238).
14817 Mark another local as initialized.
ec6cf4c6 14818 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14819
ce0ad53d 14820 * image.c (clear_image_cache): Now static.
d5d5a617 14821 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14822 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14823 (x_edge_detection): Remove unnecessary cast that
14824 gcc -Wbad-function-cast diagnoses.
2037898d 14825 (gif_load): Fix pointer signedness.
6ae141d6
PE
14826 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14827 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14828
33383987 148292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14830
d32df629
PE
14831 Improve quality of tests for time stamp overflow.
14832 For example, without this patch (encode-time 0 0 0 1 1
14833 1152921504606846976) returns the obviously-bogus value (-948597
14834 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14835 reports time overflow. See
14836 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14837 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14838 * editfns.c: Include limits.h and intprops.h.
14839 (TIME_T_MIN, TIME_T_MAX): New macros.
14840 (time_overflow): Move earlier, to before first use.
14841 (hi_time, lo_time): New functions, for an accurate test for
14842 out-of-range times.
14843 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14844 (Fget_internal_run_time): Don't assume time_t fits in int.
14845 (make_time): Use list2 instead of Fcons twice.
14846 (Fdecode_time): More accurate test for out-of-range times.
14847 (check_tm_member): New function.
14848 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14849 (lisp_time_argument): Don't rely on undefined left-shift and
14850 right-shift behavior when checking for time stamp overflow.
8be6f318 14851
fe31d94c
PE
14852 * editfns.c (time_overflow): New function, refactoring common code.
14853 (Fformat_time_string, Fdecode_time, Fencode_time):
14854 (Fcurrent_time_string): Use it.
14855
8be6f318
PE
14856 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14857 * dired.c (make_time): Move to ...
14858 * editfns.c (make_time): ... here.
14859 * systime.h: Note the move.
14860
09d9db2c 148612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14862
126bc0dc
YM
14863 * fringe.c (update_window_fringes): Remove unused variables.
14864
c47cbdfd
YM
14865 * unexmacosx.c (copy_data_segment): Also copy __got section.
14866 (Bug#8223)
14867
7ac80be9
EZ
148682011-03-12 Eli Zaretskii <eliz@gnu.org>
14869
c96bbc66 14870 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14871 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14872 Constify `char *' arguments and their references according to
14873 prototypes in tparam.h.
14874
ecb0f94d 14875 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14876
7ac80be9
EZ
14877 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14878 Adapt all references accordingly.
14879
14880 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14881
ef1fd07e
TT
148822011-03-11 Tom Tromey <tromey@redhat.com>
14883
14884 * buffer.c (syms_of_buffer): Remove obsolete comment.
14885
7ef4b50c
EZ
148862011-03-11 Eli Zaretskii <eliz@gnu.org>
14887
14888 * termhooks.h (encode_terminal_code): Declare prototype.
14889
14890 * msdos.c (encode_terminal_code): Don't declare prototype.
14891
14892 * term.c (encode_terminal_code): Now external again, used by
14893 w32console.c and msdos.c.
14894
44f230aa
SM
14895 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14896 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14897
4b1ec863 148982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14899
1714f52b 14900 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14901
4b1ec863
PE
14902 * fringe.c (update_window_fringes): Mark locals as initialized
14903 (Bug#8227).
14904 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14905
524c7aa6
PE
14906 * alloc.c (mark_fringe_data): Move decl from here ...
14907 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14908 to check its interface.
14909 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14910
a5c0af81 14911 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14912 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14913 (fontset_font): Mark local as initialized.
a9a06e0b 14914 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14915
b4716021
PE
14916 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14917
811e9bac 14918 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14919 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14920 (x_own_selection, Fx_disown_selection_internal): Rename locals
14921 to avoid shadowing.
14922 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14923
7e3ab302
PE
14924 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14925 so that the caller can use some name other than gcpro1.
14926 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14927 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14928 (Fx_backspace_delete_keys_p):
14929 Use them to avoid shadowing, and rename vars to avoid shadowing.
14930 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14931 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14932 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14933 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14934 Remove unused locals.
7e3ab302
PE
14935 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14936 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14937 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14938 macros.
f78faa98 14939
e2b13473
PE
14940 * xterm.h (x_mouse_leave): New decl.
14941
77f23912
PE
14942 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14943 Remove unused functions.
cdf4ba58
PE
14944 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14945 (x_calc_absolute_position): Now static.
7411c686 14946 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14947 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14948 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14949 unless they are used.
38d0b34a
PE
14950 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14951 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14952 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14953 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14954 (x_error_catcher, x_connection_closed, x_error_handler):
14955 (x_error_quitter, xembed_send_message, x_iconify_frame):
14956 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14957 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14958 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14959
44f230aa
SM
14960 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14961 Rename or move locals to avoid shadowing.
6b463e58 14962 (tty_defined_color, merge_face_heights): Now static.
5967d051 14963 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14964 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14965 does not deduce is never used uninitialized.
73719eba
PE
14966 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14967 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14968
426994c3 14969 * terminal.c (store_terminal_param): Now static.
5489860b 14970
032f1620 14971 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14972 (set_frame_menubar): Remove unused local.
d4323972 14973 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14974 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14975 since they might point to immutable storage.
281585b0
PE
14976 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14977 since it's unused otherwise.
032f1620 14978
367c19e5 14979 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14980 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14981 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14982 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14983 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14984 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14985 does not deduce are never used uninitialized.
70739cbe 14986
07b48fa9
PE
14987 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14988
8868a238 14989 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14990 * window.c (window_loop, size_window):
14991 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14992
7e5cf297 14993 * window.c (display_buffer): Now static.
d6550a9f
PE
14994 (size_window): Mark variables that gcc -Wuninitialized
14995 does not deduce are never used uninitialized.
a586633d
PE
14996 * window.h (check_all_windows): New decl, to forestall
14997 gcc -Wmissing-prototypes diagnostic.
5b555da1 14998 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14999
f6095868
PE
15000 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15001 shadowing.
15002 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15003 Include <limits.h>.
15004 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15005 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15006 (load_charset_map): Mark variables that gcc -Wuninitialized
15007 does not deduce are never used uninitialized.
53df7c11 15008 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15009
f38b440c
PE
15010 * coding.c (coding_set_source, coding_set_destination):
15011 Use "else { /* comment */ }" rather than "else /* comment */;"
15012 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15013 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15014 a block, when the outer 'i' will do.
15015 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15016 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15017 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15018 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15019 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15020 Rename locals to avoid shadowing.
15021 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15022 * coding.c (emacs_mule_char, encode_invocation_designation):
15023 Now static, since they're not used elsewhere.
413bb2db 15024 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15025 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15026 (decode_coding_emacs_mule): Mark variables that gcc
15027 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15028 (detect_coding_iso_2022): Initialize a local variable that might
15029 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15030 this initialization is needed. (Bug#8211)
5f58e762
PE
15031 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15032 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15033 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15034 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15035 Remove unused macros.
f38b440c 15036
232b38b9 15037 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15038 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15039 * character.c (string_count_byte8): Likewise.
232b38b9 15040
fb90da1b
PE
15041 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15042 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15043
fb93dbc2
PE
15044 * chartab.c (copy_sub_char_table): Now static, since it's not used
15045 elsewhere.
5c156ace
PE
15046 (sub_char_table_ref_and_range, char_table_ref_and_range):
15047 Rename locals to avoid shadowing.
bbcd0949 15048 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15049
7d3b3862 15050 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15051 (BIDI_BOB): Remove unused macro.
7d3b3862 15052
6be7d3da
PE
15053 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15054 deduce are never used uninitialized.
c2ed9c8b 15055 * term.c (encode_terminal_code): Likewise.
6be7d3da 15056
75f8807f 15057 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15058
50938595
PE
15059 * tparam.h: New file.
15060 * term.c, tparam.h: Include it.
15061 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15062 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15063 Move these decls to tparam.h, and make them agree with what
15064 is actually in tparam.c. The previous trick of using incompatible
15065 decls in different modules does not conform to the C standard.
15066 All callers of tparam changed to use tparam's actual API.
15067 * tparam.c (tparam1, tparam, tgoto):
15068 Use const pointers where appropriate.
15069
fbceeba2
PE
15070 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15071 * cm.h (struct cm): Likewise.
15072 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15073 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15074 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15075 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15076 (turn_on_face, init_tty): Likewise.
15077 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15078
7f3f1250
PE
15079 * term.c (term_mouse_position): Rename local to avoid shadowing.
15080
e6ca6543
PE
15081 * alloc.c (mark_ttys): Move decl from here ...
15082 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15083
c40f8d15
AS
150842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15085
15086 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15087
cfe0661d
JB
150882011-03-09 Juanma Barranquero <lekktu@gmail.com>
15089
15090 * search.c (compile_pattern_1): Remove argument regp, unused since
15091 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15092 (compile_pattern): Don't pass it.
15093
0afb4571
J
150942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15095
15096 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15097 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15098 for ! HAVE_GTK3.
15099 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15100
15101 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15102
15103 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15104 gdk_window_get_screen, gdk_window_get_geometry,
15105 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15106 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15107 (xg_get_pixbuf_from_pixmap): New function.
15108 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15109 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15110 Call xg_get_pixbuf_from_pixmap instead of
15111 gdk_pixbuf_get_from_drawable.
15112 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15113 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15114 (xg_check_special_colors): Use GtkStyleContext and its functions
15115 for HAVE_GTK3.
15116 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15117 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15118 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15119 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15120 Call gtk_widget_get_preferred_size.
0afb4571
J
15121 (xg_frame_resized): gdk_window_get_geometry only takes 5
15122 parameters.
44f230aa
SM
15123 (xg_win_to_widget, xg_event_is_for_menubar):
15124 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15125 (xg_set_widget_bg): New function.
15126 (delete_cb): New function.
895009e1 15127 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15128 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15129 (xg_set_background_color): Call xg_set_widget_bg.
15130 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15131 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15132 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15133 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15134 if ! HAVE_GTK3.
15135 (update_frame_tool_bar): Call gtk_widget_hide.
15136 (xg_initialize): Use GDK_KEY_g.
15137
15138 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15139 if ! HAVE_GTK3
15140 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15141
15142 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15143 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15144 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15145
1c2cc4ef
JB
151462011-03-08 Juanma Barranquero <lekktu@gmail.com>
15147
15148 * w32xfns.c (select_palette): Check success of RealizePalette against
15149 GDI_ERROR, not zero.
15150
33383987 15151See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15152
15153;; Local Variables:
15154;; coding: utf-8
aac0c6e3
MR
15155;; End:
15156
2f097256 15157 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15158
15159 This file is part of GNU Emacs.
15160
15161 GNU Emacs is free software: you can redistribute it and/or modify
15162 it under the terms of the GNU General Public License as published by
15163 the Free Software Foundation, either version 3 of the License, or
15164 (at your option) any later version.
15165
15166 GNU Emacs is distributed in the hope that it will be useful,
15167 but WITHOUT ANY WARRANTY; without even the implied warranty of
15168 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15169 GNU General Public License for more details.
15170
15171 You should have received a copy of the GNU General Public License
15172 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.