* lisp/font-lock.el (lisp-font-lock-keywords-2): Add pcase, pcase-let
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f30d612a
CY
12012-04-20 Chong Yidong <cyd@gnu.org>
2
3 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4 set the status to "failed" and ensure that sentinel is run.
5
c07a4c0b 62012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
7
8 * process.c (Fset_process_inherit_coding_system_flag)
9 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 10 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 11
c07a4c0b 122012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
13
14 * xdisp.c (string_buffer_position_lim): Limit starting position to
15 BEGV.
16 (set_cursor_from_row): If called for a mode-line or header-line
17 row, return zero immediately.
18 (try_cursor_movement): If inside continuation line, don't back up
19 farther than the first row after the header line, if any. Don't
20 consider the header-line row as "partially visible", even if
21 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
22
c07a4c0b 232012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41
AO
24
25 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
26
c07a4c0b 272012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 282012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
29
30 configure: new option --enable-gcc-warnings (Bug#11207)
31 * Makefile.in (C_WARNINGS_SWITCH): Remove.
32 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
33 (ALL_CFLAGS): Use new macros rather than old.
34 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
35 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
36 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
37 -Wunused-result, -Wunused-variable. This should go away once
38 the Emacs and Gnulib regex code is merged.
39 (xmalloc, xrealloc): Now static.
40
aba027e8
PE
412012-04-17 Paul Eggert <eggert@cs.ucla.edu>
42
43 * dired.c (Fsystem_groups): Remove unused local.
44
e5a36063
GM
452012-04-17 Glenn Morris <rgm@gnu.org>
46
47 * dired.c (Fsystem_users): Doc fix.
48
316411f0
DA
492012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
50
51 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
52 (syms_of_dired): Add them.
53
9426aba4
PE
542012-04-16 Paul Eggert <eggert@cs.ucla.edu>
55
b62a57be
PE
56 Fix minor alloc.c problems found by static checking.
57 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
58 New extern decls, to avoid calling undeclared functions.
59 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
60 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
61 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
62 (NEED_MEM_INSERT): New macro.
63 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 64 Remove one incorrect comment and fix another.
b62a57be 65
3539f31f
PE
66 Fix minor ralloc.c problems found by static checking.
67 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
68 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
69 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
70 (r_alloc_sbrk): Now static.
71
a041960a
PE
72 Improve ralloc.c interface checking.
73 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
74 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
75 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
76 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
77 [REL_ALLOC]: ... to here, to check interface.
78 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
79 Remove decls. This fixes an "It stinks!".
80
9426aba4
PE
81 * alloc.c (which_symbols): Fix alignment issue / type clash.
82
d55c12ed
AS
832012-04-15 Andreas Schwab <schwab@linux-m68k.org>
84
85 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
86 (struct Lisp_Misc_Any): Likewise.
87 (struct Lisp_Free): Likewise.
88 * alloc.c (union aligned_Lisp_Symbol): Define.
89 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
90 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
91 (union aligned_Lisp_Misc): Define.
92 (MARKER_BLOCK_SIZE, struct marker_block): Use union
93 aligned_Lisp_Misc instead of union Lisp_Misc.
94 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
95
b948ce8b
PE
962012-04-14 Paul Eggert <eggert@cs.ucla.edu>
97
98 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
99 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
100 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
101 * s/netbsd.h, s/sol2-6.h:
102 Remove definition of GC_MARK_STACK, since the default now works.
103 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
104 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
105 no longer the default.
106 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
107
35dc09a1 1082012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 109
35dc09a1
GM
110 * lread.c (lisp_file_lexically_bound_p):
111 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 112
35dc09a1
GM
1132012-04-14 Eli Zaretskii <eliz@gnu.org>
114
115 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
116 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
117
1182012-04-14 Jan Djärv <jan.h.d@swipnet.se>
119
120 * nsterm.m (constrainFrameRect): Always constrain when there is only
121 one screen (Bug#10962).
122
bcd86815
KB
1232012-04-13 Ken Brown <kbrown@cornell.edu>
124
125 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
126
c25df26e
RT
1272012-04-13 Reuben Thomas <rrt@sc3d.org>
128
129 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
130
0fc59f1e
DC
1312012-04-11 Daniel Colascione <dancol@dancol.org>
132
133 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
134 against is gone. It's better to use vfork now so that when Cygwin
135 gains a new, working vfork, we use it automatically (bug#10398).
136
de8c03dc
SM
1372012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
138
139 * window.c (save_window_save): Obey window-point-insertion-type.
140
2f097256
GM
1412012-04-11 Glenn Morris <rgm@gnu.org>
142
143 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
144
453b951e
SM
1452012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
146
147 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
148
75f1671a 1492012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
150
151 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
152 (force_quit_count): New var.
153 (handle_interrupt): Use it.
154
2a8ce227
JB
1552012-04-10 Juanma Barranquero <lekktu@gmail.com>
156
157 * w32.c (w32_delayed_load): Record the full path of the library
158 being loaded (bug#10424).
159
935396c0
GM
1602012-04-09 Glenn Morris <rgm@gnu.org>
161
05920a43
GM
162 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
163 not just in the obarray, before snarfing them. (Bug#11036)
164
935396c0
GM
165 * Makefile.in ($(leimdir)/leim-list.el):
166 Pass EMACS rather than BUILT_EMACS.
167
a18ecafa
TZ
1682012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
169
170 * process.c (make_process):
171 * process.h: Add integer `gnutls_handshakes_tried' member to
172 process struct.
173
6bbef4e5
JC
174 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
175 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
176
177 * gnutls.c (gnutls_log_function2i): Convenience log function.
178 (emacs_gnutls_read): Use new log functions,
179 `gnutls_handshakes_tried' process member, and
180 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
181 attempts per process (connection).
182
b4d3bc10
CY
1832012-04-09 Chong Yidong <cyd@gnu.org>
184
185 * eval.c (Fuser_variable_p, user_variable_p_eh)
186 (lisp_indirect_variable): Functions deleted.
187 (Fdefvar): Caller changed.
188
189 * callint.c (Finteractive, Fcall_interactively):
190 * minibuf.c (Fread_variable): Callers changed.
191
70f4d973
EZ
1922012-04-09 Eli Zaretskii <eliz@gnu.org>
193
194 * xdisp.c (set_cursor_from_row): If the display string appears in
195 the buffer at position that is closer to point than the position
196 after the display string, display the cursor on the first glyph of
197 the display string. Fixes cursor display when a 'display' text
198 property immediately follows invisible text. (Bug#11094)
199
cb3c2e3e
PE
2002012-04-09 Paul Eggert <eggert@cs.ucla.edu>
201
202 composite.c: use 'double' consistently
203 * composite.c (get_composition_id): Use 'double' consistently
204 instead of converting 'float' to 'double' and vice versa; this is
205 easier to understand and avoids a GCC warning.
206
fd06db5d
GM
2072012-04-09 Glenn Morris <rgm@gnu.org>
208
50fe702a
GM
209 * Makefile.in: Generate leim-list with bootstrap-emacs, in
210 preparation for dumping it with emacs. (Bug#4789)
211 (leimdir): New variable.
212 ($(leimdir)/leim-list.el): New rule.
213 (emacs$(EXEEXT)): Depend on leim-list.el.
214
fd06db5d
GM
215 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
216 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
217 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
218
55c131ee
AS
2192012-04-08 Andreas Schwab <schwab@linux-m68k.org>
220
221 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
222 proper alignment.
223
9209588f
JB
2242012-04-07 Juanma Barranquero <lekktu@gmail.com>
225
226 * xml.c (init_libxml2_functions) [WINDOWSNT]:
227 Remove unused local variable.
228
e3fb2efb
PE
2292012-04-07 Paul Eggert <eggert@cs.ucla.edu>
230
231 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
232 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
233 (mark_memory): Mark Lisp_Objects only if pointers might hide in
234 objects, as mark_maybe_pointer will catch them otherwise.
235 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
236 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
237
b5385551
PE
2382012-04-07 Paul Eggert <eggert@cs.ucla.edu>
239
240 Fix typo that broke non-Windows builds.
241 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
242
9078ead6
EZ
2432012-04-07 Eli Zaretskii <eliz@gnu.org>
244
245 Support building on MS-Windows with libxml2.
246
247 * makefile.w32-in (OBJ2): Add xml.$(O).
248 (GLOBAL_SOURCES): Add xml.c.
249 ($(BLD)/xml.$(O)): New dependency list.
250
251 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
252 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
253 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
254 [!WINDOWSNT]: New macros.
255 (init_libxml2_functions, libxml2_loaded_p): New functions.
256 (parse_region): Call fn_xmlCheckVersion instead of using the macro
257 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
258 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
259 Calls xmlCleanupParser only if libxml2 was loaded (or statically
260 linked in).
6bbef4e5
JC
261 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
262 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
263 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
264
265 * emacs.c: Don't include libxml/parser.h.
266 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
267 xmlCleanupParser directly.
268
269 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
270
3811fdf3
EZ
2712012-04-07 Eli Zaretskii <eliz@gnu.org>
272
273 * indent.c (Fvertical_motion): If there is a display string at
274 point, use it.vpos to compute how many lines to backtrack after
275 move_it_to point. (Bug#11133)
276
2f8e16b2
EZ
2772012-04-06 Eli Zaretskii <eliz@gnu.org>
278
279 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
280 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
281 about subtle differences between FETCH_CHAR* and STRING_CHAR*
282 macros related to unification of CJK characters. For the details,
283 see the discussion following the message here:
284 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
285
3d439cd1
CY
2862012-04-04 Chong Yidong <cyd@gnu.org>
287
288 * keyboard.c (Vdelayed_warnings_list): Doc fix.
289
8bc53d00
EZ
2902012-04-01 Eli Zaretskii <eliz@gnu.org>
291
292 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
293 instead of alloca. (Bug#11138)
294
3b0512a3
AS
2952012-04-01 Andreas Schwab <schwab@linux-m68k.org>
296
297 * w32menu.c (is_simple_dialog): Properly check lisp types.
298 (Bug#11141)
299
8427ddd2
EZ
3002012-03-31 Eli Zaretskii <eliz@gnu.org>
301
979022ef
EZ
302 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
303 position we get to after a call to move_it_to fails the
304 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
305 only if we wind up in a string from display property. (Bug#11063)
306
a6b1c7cc
EZ
307 * window.c (Fdelete_other_windows_internal): Invalidate the row
308 and column information about mouse highlight, so that redisplay
309 restores it after reallocating the glyph matrices. (Bug#7464)
310
8427ddd2
EZ
311 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
312 string comes from a `display' text property, use the buffer
313 position of that property as if we actually saw that position in
314 the row's glyphs.
697ba24b
EZ
315 (move_it_by_lines): Remove the assertion that
316 "it->current_x == 0 && it->hpos == 0" which can be legitimately
317 violated when there's a before-string at the beginning of a line.
318 (Bug#11063)
8427ddd2 319
65a0a738
EZ
3202012-03-30 Eli Zaretskii <eliz@gnu.org>
321
322 * xdisp.c (append_space_for_newline): If the default face was
323 remapped, use the remapped face for the appended newline.
324 (extend_face_to_end_of_line): Use the remapped default face for
325 extending the face to the end of the line.
326 (display_line): Call extend_face_to_end_of_line when the default
327 face was remapped. (Bug#11068)
328
581355cc
EZ
3292012-03-29 Eli Zaretskii <eliz@gnu.org>
330
331 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
332
e8fc049f
SM
3332012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
334
335 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
336
4fb9a543
GM
3372012-03-27 Glenn Morris <rgm@gnu.org>
338
339 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
340 Doc fixes.
341
679910f1
KH
3422012-03-26 Kenichi Handa <handa@m17n.org>
343
344 * dispextern.h (struct glyph): Fix previous change. Change the
345 bit length of glyphless.ch to 25 (Bug#11082).
346
90d49b7f
CY
3472012-03-26 Chong Yidong <cyd@gnu.org>
348
349 * keyboard.c (Vselection_inhibit_update_commands): New variable.
350 (command_loop_1): Use it; inhibit selection update for
351 handle-select-window too (Bug#8996).
352
f514f6f0
FP
3532012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
354
e8fc049f 355 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 356
bf43fa51
KH
3572012-03-25 Kenichi Handa <handa@m17n.org>
358
359 * dispextern.h (struct glyph): Change the bit length of
360 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
361
8a0c01dd
EZ
3622012-03-24 Eli Zaretskii <eliz@gnu.org>
363
364 * s/ms-w32.h (tzname): Include time.h before redirecting to
365 _tzname. Fixes the MSVC build. (Bug#9960)
366
7d1c3a76
AS
3672012-03-24 Andreas Schwab <schwab@linux-m68k.org>
368
8ed79523
AS
369 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
370 characters.
371
7d1c3a76
AS
372 * xterm.c (XTread_socket): Only modify handling_signal if
373 !SYNC_INPUT. (Bug#11080)
374
e99a9b8b
EZ
3752012-03-23 Eli Zaretskii <eliz@gnu.org>
376
377 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
378 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
379 when fetching a multibyte character consumes more bytes than
380 CHAR_BYTES returns, due to unification of CJK characters in
381 string_char. (Bug#11073)
382
5063c0e1
TN
3832012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
384
385 * process.c (wait_reading_process_output): Handle pty disconnect
386 by refraining from sending oneself a SIGCHLD (bug#10933).
387
9f851fbd
CY
3882012-03-22 Chong Yidong <cyd@gnu.org>
389
390 * dispextern.h (struct it): New member string_from_prefix_prop_p.
391
5063c0e1 392 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
393 Mark string as coming from a prefix property.
394 (handle_face_prop): Use default face for prefix strings (Bug#4281).
395 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
396
fb5b8aca
CY
3972012-03-21 Chong Yidong <cyd@gnu.org>
398
399 * xfaces.c (Vface_remapping_alist): Doc fix.
400
62356a1b
EZ
4012012-03-20 Eli Zaretskii <eliz@gnu.org>
402
403 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
404 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
405 Doc fixes.
62356a1b 406
025de85b
CY
4072012-03-20 Chong Yidong <cyd@gnu.org>
408
409 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
410 to reflect default non-nil value of redisplay-dont-pause.
411
4827f94e
KH
4122012-03-19 Kenichi Handa <handa@m17n.org>
413
414 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
415 it fit in a valid range (Bug#11003).
416
e50a24a2
EZ
4172012-03-18 Eli Zaretskii <eliz@gnu.org>
418
419 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
420 that is not from display property, accept the row as a "cursor
421 row" if one of the string's character has a non-nil `cursor'
422 property. Fixes cursor positioning when there are newlines in
423 overlay strings, e.g. in icomplete.el. (Bug#11035)
424
9af5ed87
PE
4252012-03-12 Paul Eggert <eggert@cs.ucla.edu>
426
427 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
428
d1f55f16
CY
4292012-03-12 Chong Yidong <cyd@gnu.org>
430
431 * eval.c (inhibit_lisp_code): Rename from
432 inhibit_window_configuration_change_hook; move from window.c.
433
434 * xfns.c (unwind_create_frame_1, Fx_create_frame):
435 * window.c (run_window_configuration_change_hook)
436 (syms_of_window): Callers changed.
437
66c5eebd
CY
4382012-03-11 Chong Yidong <cyd@gnu.org>
439
413df973
CY
440 * keymap.c (Fkey_description): Doc fix (Bug#9700).
441
66c5eebd
CY
442 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
443
1de11f56
CY
4442012-03-10 Chong Yidong <cyd@gnu.org>
445
446 * frame.c (other_visible_frames): Don't assume the selected frame
447 is visible (Bug#10955).
448
cae07000
SM
4492012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
450
451 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
452
89c94350
JD
4532012-03-08 Jan Djärv <jan.h.d@swipnet.se>
454
455 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
456 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
457 zero (Bug#10954).
458
999dd333
GM
4592012-03-03 Glenn Morris <rgm@gnu.org>
460
01a6dcc8 461 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 462
de0100f2
EZ
4632012-03-02 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
466 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
467 (redisplay_window, next_element_from_string): Fix typos in
468 comments.
3e441275
EZ
469 (redisplay_window): Pass to move_it_vertically the margin in
470 pixels, not in screen lines.
de0100f2 471
96a72ee9
GM
4722012-03-02 Glenn Morris <rgm@gnu.org>
473
474 * buffer.c (buffer-list-update-hook): Doc fix.
475
312508d7
EZ
4762012-02-29 Eli Zaretskii <eliz@gnu.org>
477
478 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
479 push_it before setting up the iterator for the first overlay
480 string, even if we have an empty string loaded.
481 (next_overlay_string): If there's an empty string on the iterator
482 stack, pop the stack. (Bug#10903)
483
27f3c637
PE
4842012-02-25 Paul Eggert <eggert@cs.ucla.edu>
485
486 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
487 Suggested by Stefan Monnier in
488 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
489 * alloc.c (widen_to_Lisp_Object): New static function.
490 (mark_memory): Also mark Lisp_Objects by fetching pointer words
491 and widening them to Lisp_Objects. This would work even if
492 USE_LSB_TAG is defined and wide integers are used, which might
493 happen in a future version of Emacs.
494
3c9dfce6
CY
4952012-02-25 Chong Yidong <cyd@gnu.org>
496
fa74b241
CY
497 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
498 Doc fix.
499
3c9dfce6
CY
500 * xselect.c (Fx_selection_exists_p): Doc fix.
501 (x_clipboard_manager_save_all): Print an informative message
502 before saving to clipboard manager.
503
9486df08
CY
5042012-02-24 Chong Yidong <cyd@gnu.org>
505
506 * keyboard.c (process_special_events): Handle all X selection
507 requests in kbd_buffer, not just the next one (Bug#8869).
508
f01d3321
CY
5092012-02-23 Chong Yidong <cyd@gnu.org>
510
511 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
512 call when setting menu-bar-lines and tool-bar-lines parameters.
513 (unwind_create_frame_1): New helper function.
514
515 * window.c (inhibit_window_configuration_change_hook): New var.
516 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 517 (syms_of_window): Initialize it.
f01d3321 518
86b847b6
CY
5192012-02-22 Chong Yidong <cyd@gnu.org>
520
521 * xterm.c (x_draw_image_relief): Add missing type check for
522 Vtool_bar_button_margin (Bug#10743).
523
a59225b1
CY
5242012-02-21 Chong Yidong <cyd@gnu.org>
525
526 * fileio.c (Vfile_name_handler_alist): Doc fix.
527
528 * buffer.c (Fget_file_buffer): Protect against invalid file
529 handler return value.
530
310f5bd4
PE
5312012-02-20 Paul Eggert <eggert@cs.ucla.edu>
532
cb3a28cc
PE
533 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
534 when computing $valmask.
535
310f5bd4
PE
536 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
537 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
538 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
539 It's useless in that case, and it can cause problems on hosts
540 that allocate halves of EMACS_INT values separately.
541 Reported by Dan Horák. Diagnosed by Andreas Schwab in
542 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
543 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
544 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
545 it avoids undefined behavior on hosts where shifting right by more
546 than the word width has undefined behavior.
547
2375c96a
CY
5482012-02-19 Chong Yidong <cyd@gnu.org>
549
550 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
551 (Funhandled_file_name_directory, Ffile_name_as_directory)
552 (Fdirectory_file_name, Fexpand_file_name)
553 (Fsubstitute_in_file_name): Protect against invalid file handler
554 return values (Bug#10845).
555
3eb49e71
EZ
5562012-02-18 Eli Zaretskii <eliz@gnu.org>
557
558 * .gdbinit (pitx): Fix incorrect references to fields of the
559 iterator stack.
560
7b926f3f
CY
5612012-02-17 Chong Yidong <cyd@gnu.org>
562
563 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
564
11273115
PE
5652012-02-15 Paul Eggert <eggert@cs.ucla.edu>
566
567 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
568 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
569
c3a70e2b
CY
5702012-02-15 Chong Yidong <cyd@gnu.org>
571
572 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
573 marked as special. Also, starting docstrings with * is obsolete.
574
0ca43699
AS
5752012-02-13 Andreas Schwab <schwab@linux-m68k.org>
576
577 * gnutls.c (emacs_gnutls_write): Fix last change.
578
2e8f3c56
LI
5792012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
580
581 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
582 send_process.
583
af70074f
SM
5842012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
585
586 * keymap.c (Fsingle_key_description): Handle char ranges.
587
95986d52
CY
5882012-02-12 Chong Yidong <cyd@gnu.org>
589
afd83bd1
CY
590 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
591 as that creates a dangerous corner case.
592
95986d52
CY
593 * window.c (Fdelete_window_internal): Invalidate the mouse
594 highlight (Bug#9904).
595
bd7da63e
GM
5962012-02-12 Glenn Morris <rgm@gnu.org>
597
598 * xselect.c (Fx_own_selection_internal)
599 (Fx_get_selection_internal, Fx_disown_selection_internal)
600 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
601 * nsselect.m (Fx_own_selection_internal)
602 (Fx_disown_selection_internal, Fx_selection_exists_p)
603 (Fx_selection_owner_p, Fx_get_selection_internal):
604 Sync docs and argument specs with the xselect.c versions.
605
77abcbc2
LI
6062012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
607
608 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
609
90b671e2
EZ
6102012-02-11 Eli Zaretskii <eliz@gnu.org>
611
1c0ca0b7
EZ
612 * w32select.c (Fx_selection_exists_p): Sync doc string and
613 argument list with xselect.c. (Bug#10783)
614
615 * w16select.c (Fx_selection_exists_p): Sync doc string and
616 argument list with xselect.c. (Bug#10783)
90b671e2 617
49241268
GM
6182012-02-10 Glenn Morris <rgm@gnu.org>
619
620 * fns.c (Fsecure_hash): Doc fix.
621
f998bbe7 6222012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
623
624 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
625
0992bd9c
CY
6262012-02-07 Chong Yidong <cyd@gnu.org>
627
628 * buffer.c (Fbuffer_local_variables)
629 (buffer_lisp_local_variables): Handle unbound vars correctly;
630 don't let Qunbound leak into Lisp.
631
af008560
GM
6322012-02-07 Glenn Morris <rgm@gnu.org>
633
dd605cc4
GM
634 * image.c (Fimagemagick_types): Doc fix.
635
af008560
GM
636 * image.c (imagemagick-render-type): Change it from a lisp object
637 to an integer. Move the doc here from the lisp manual.
638 Treat all values not equal to 0 the same.
639
1449fa1d
CY
6402012-02-06 Chong Yidong <cyd@gnu.org>
641
642 * doc.c (store_function_docstring): Avoid applying docstring of
643 alias to base function (Bug#2603).
644
3723ec07
AS
6452012-02-04 Andreas Schwab <schwab@linux-m68k.org>
646
647 * .gdbinit (pp1, pv1): Remove redundant defines.
648 (pr): Use pp.
649
79c1cc1e
CY
6502012-02-04 Chong Yidong <cyd@gnu.org>
651
652 * nsterm.m: Declare a global (Bug#10694).
653
d7f29f8e
EZ
6542012-02-04 Eli Zaretskii <eliz@gnu.org>
655
cae07000
SM
656 * w32.c (get_emacs_configuration_options):
657 Include --enable-checking, if specified, in the return value.
d7f29f8e 658
3b95a6f9
MR
6592012-02-04 Martin Rudalics <rudalics@gmx.at>
660
661 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
662 after rounding frame sizes. (Bug#9723)
663
d6fa96a6
EZ
6642012-02-04 Eli Zaretskii <eliz@gnu.org>
665
666 * keyboard.c (adjust_point_for_property): Don't position point
667 before BEGV. (Bug#10696)
668
df0b2940
PE
6692012-02-03 Paul Eggert <eggert@cs.ucla.edu>
670
671 Handle overflow when computing char display width (Bug#9496).
672 * character.c (char_width): Return EMACS_INT, not int.
673 (char_width, c_string_width): Check for overflow when
674 computing the width; this is possible now that individual
675 characters can have unbounded width. Problem introduced
676 by merge from Emacs 23 on 2012-01-19.
677
6bee44d6
MA
6782012-02-02 Michael Albinus <michael.albinus@gmx.de>
679
680 * dbusbind.c (Fdbus_register_method): Mention the return value
681 :ignore in the docstring.
682
44f92739
GM
6832012-02-02 Glenn Morris <rgm@gnu.org>
684
1b9f60cc
GM
685 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
686
44f92739
GM
687 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
688 Unconditionally set to t. (Bug#10673)
689 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
690 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
691 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
692
c5d3843c
KH
6932012-02-02 Kenichi Handa <handa@m17n.org>
694
695 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
696 0, do not call append_composite_glyph.
697
159462d4 6982012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
699
700 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
701 NULL (Bug#6988).
702 (x_produce_glyphs): If the component of a composition is a null
703 string, set it->pixel_width to 1 to avoid zero-width glyph.
704
78cef877
EZ
7052012-02-01 Eli Zaretskii <eliz@gnu.org>
706
707 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
708 first 2 arguments are identical. This makes inserting large
709 output from a subprocess an order of magnitude faster on
710 MS-Windows, where all sbrk'ed memory is always contiguous.
711
97897668
GM
7122012-01-31 Glenn Morris <rgm@gnu.org>
713
714 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 715 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
716 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
717
31fd3586
GM
7182012-01-29 Glenn Morris <rgm@gnu.org>
719
720 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
721
0e24a8b2
CY
7222012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
723
724 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
725
cc0adcb0
CY
7262012-01-28 Chong Yidong <cyd@gnu.org>
727
728 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
729
acc28cb9
CY
7302012-01-26 Chong Yidong <cyd@gnu.org>
731
9c69cfb7
CY
732 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
733
acc28cb9
CY
734 * search.c (Fsearch_forward, Fsearch_backward): Document negative
735 repeat counts (Bug#10507).
736
48da7392
GM
7372012-01-26 Glenn Morris <rgm@gnu.org>
738
739 * lread.c (syms_of_lread): Doc fix.
740
14af5f7f
CY
7412012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
742
743 * coding.c (encode_designation_at_bol): Change return value to
744 EMACS_INT.
745
0b21c100
CY
7462012-01-25 Chong Yidong <cyd@gnu.org>
747
748 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
749
3c2907f7
CY
7502012-01-21 Chong Yidong <cyd@gnu.org>
751
752 * floatfns.c (Fcopysign): Make the second argument non-optional,
753 since nil is not allowed anyway.
754
959ad23f
AS
7552012-01-21 Andreas Schwab <schwab@linux-m68k.org>
756
757 * process.c (read_process_output): Use p instead of XPROCESS (proc).
758 (send_process): Likewise.
759
34a02f46
MR
7602012-01-19 Martin Rudalics <rudalics@gmx.at>
761
762 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
763 (Vwindow_persistent_parameters): Do not use Qstate.
764 Rewrite doc-strings.
34a02f46 765
1259009a 7662012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
767
768 * character.c (char_width): New function.
70d4fdf6
GM
769 (Fchar_width, c_string_width, lisp_string_width):
770 Use char_width (Bug#9496).
25ed9e61 771
6a6ee00d
MR
7722012-01-16 Martin Rudalics <rudalics@gmx.at>
773
774 * window.c (Vwindow_persistent_parameters): New variable.
775 (Fset_window_configuration, save_window_save): Handle persistent
776 window parameters.
777
c85efaf7
EZ
7782012-01-14 Eli Zaretskii <eliz@gnu.org>
779
780 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
781 thrashing the stack of the thread. (Bug#9087)
782
5944709e
PE
7832012-01-12 Paul Eggert <eggert@cs.ucla.edu>
784
785 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
786
e71f5d99
EZ
7872012-01-11 Eli Zaretskii <eliz@gnu.org>
788
789 * xdisp.c (rows_from_pos_range): Handle the case where the
790 highlight ends on a newline. (Bug#10464)
791 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
792 he end column for display of highlight that ends on a newline
793 before a R2L line.
794
ce316182
GM
7952012-01-11 Glenn Morris <rgm@gnu.org>
796
797 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
798 from load-path also when installation-directory is nil. (Bug#10208)
799
5b43da69
GM
8002012-01-10 Glenn Morris <rgm@gnu.org>
801
74cc8ff9
GM
802 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
803
7d8d6e4e
GM
804 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
805 Update template values to be closer to their typical values these days.
5b43da69 806
a0db8d43
EZ
8072012-01-09 Eli Zaretskii <eliz@gnu.org>
808
809 * xdisp.c (rows_from_pos_range): Accept additional argument
810 DISP_STRING, and accept any glyph in a row whose object is that
811 string as eligible for mouse highlight. Fixes mouse highlight of
812 display strings from overlays. (Bug#10464)
813
9a0115ab 8142012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 815
b9110d6a 816 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
817 * fileio.c (auto_saving_dir_umask): New static var.
818 (Fmake_directory_internal): Use it.
819 (do_auto_save_make_dir): Set it, instead of invoking chmod after
820 creating the directory. The old code temporarily assigns
821 too-generous permissions to the directory.
822 (do_auto_save_eh): Clear it.
b9110d6a 823 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
824 that the var is always cleared.
825
6c1bd3f3
EZ
8262012-01-07 Eli Zaretskii <eliz@gnu.org>
827
828 * search.c (scan_buffer): Pass character positions to
829 know_region_cache, not byte positions. (Bug#6540)
830
069d2b50
L
8312012-01-07 LynX <_LynX@bk.ru> (tiny change)
832
833 * w32.c (sys_rename): Report EXDEV when rename of a directory
834 fails because the target is on another logical disk. (Bug#10284)
835
75bf0d33
DB
8362012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
837
838 * xterm.c (x_embed_request_focus): New function.
839
840 * xterm.h: Add prototype.
841
842 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
843
1c6e5a32
GM
8442012-01-05 Glenn Morris <rgm@gnu.org>
845
846 * emacs.c (emacs_copyright): Update short copyright year to 2012.
847
651e947e
EZ
8482012-01-01 Eli Zaretskii <eliz@gnu.org>
849
850 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
851 Load gnutls_transport_set_lowat only if GnuTLS version is below
852 2.11.1.
853 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
854 GnuTLS versions below 2.11.1.
855
3778cdd8
AL
8562011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
857
858 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
859 to the doc string advising against its use for altering the way
860 windows are scrolled.
861
0e5317f7
KH
8622011-12-28 Kenichi Handa <handa@m17n.org>
863
864 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
865 coding-system ASCII compatible only when it does not produce BOM
866 on encoding (Bug#10383).
867
93d5ca1f
JD
8682011-12-26 Jan Djärv <jan.h.d@swipnet.se>
869
870 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
871 can scroll.
872 (create_and_show_popup_menu): Always use menu_position_func for
873 Gtk3 (Bug#10361).
874
ca22b785
AS
8752011-12-24 Andreas Schwab <schwab@linux-m68k.org>
876
877 * callint.c (Fcall_interactively): Don't truncate prompt string.
878
d048e1e6
EZ
8792011-12-23 Eli Zaretskii <eliz@gnu.org>
880
881 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
882 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 883 resumed from there (after widening). (Bug#10360)
d048e1e6 884
5ccaba1f
JD
8852011-12-22 Jan Djärv <jan.h.d@swipnet.se>
886
887 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
888
204ee57f
JD
8892011-12-21 Jan Djärv <jan.h.d@swipnet.se>
890
b81d40f0
JB
891 * nsterm.m (x_free_frame_resources):
892 Release f->output_data.ns->miniimage.
204ee57f
JD
893 (ns_index_color): Fix indentation. Do not retain
894 color_table->colors[i].
895
896 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
897 before returning.
898
899 * nsfns.m (x_set_background_color): Assign return value from
900 ns_index_color to face-background instead of NSColor*.
901 (ns_implicitly_set_icon_type): Fix indentation.
902 Change assignment in for loop to comparison.
903
904 * emacs.c (ns_pool): New variable.
905 (main): Assign ns_pool.
906 (Fkill_emacs): Call ns_release_autorelease_pool.
907
908 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
909 autorelease fdesc, release fdAttrs and tdict.
910 (ns_get_covering_families): Release charset.
911 (ns_findfonts): Release NSFontDescriptor created with new.
912 (ns_uni_to_glyphs): Fix indentation.
913 (setString): Release attrStr before assigning new value.
914
c803b2b7
JD
9152011-12-18 Jan Djärv <jan.h.d@swipnet.se>
916
678f4426
JD
917 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
918 and NS_IMPL_COCOA.
919 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
920 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
921
cd394be1 9222011-12-18 David Reitter <reitter@cmu.edu>
678f4426 923
5fecd5fc
JD
924 * nsterm.m (ns_term_init): Subscribe for notifications
925 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
926 to method trackingNotification in EmacsMenu.
927
928 * nsmenu.m (trackingMenu): New variable.
3771cb17 929 (trackingNotification): New method (from Aquamacs).
5fecd5fc 930 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 931 from Aquamacs (Bug#7030).
678f4426
JD
932
9332011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 934
c803b2b7
JD
935 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
936 (symbol_to_nsstring): Fix indentation.
937 (ns_symbol_to_pb): New function.
cae07000
SM
938 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
939 (Fns_rotate_cut_buffers_internal): Remove.
940 (Fns_store_selection_internal): Rename from
c803b2b7
JD
941 Fns_store_cut_buffer_internal.
942 (ns_get_foreign_selection, Fx_own_selection_internal)
943 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
944 (Fns_get_selection_internal, Fns_store_selection_internal):
945 Use ns_symbol_to_pb and check if return value is nil.
946 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
947 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
948 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
949 renamed to Sns_store_selection_internal.
950 (ns_handle_selection_request): Move code to Fx_own_selection_internal
951 and remove this function.
952 (ns_handle_selection_clear): Remove, never used.
953 (Fx_own_selection_internal): Move code from ns_handle_selection_request
954 here.
955
e1b01a3a
KB
9562011-12-17 Ken Brown <kbrown@cornell.edu>
957
958 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
959 GID is unknown (Bug#10257).
960
2adb6e85
PE
9612011-12-17 Paul Eggert <eggert@cs.ucla.edu>
962
963 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
964 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
965 which caused a build failure on GNU/Linux IA-64. This problem was
966 introduced by my 2011-10-07 patch.
967
d1d7b339
JL
9682011-12-15 Juri Linkov <juri@jurta.org>
969
970 * image.c (imagemagick_error): New function. (Bug#10112)
971 (imagemagick_load_image): Comment out `MagickSetResolution' call.
972 Use `imagemagick_error' where ImageMagick functions return
973 `MagickFalse'.
974 (Fimagemagick_types): Add `Fnreverse' to return the list in the
975 proper order.
976
100d5755
KH
9772011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
978
979 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
980 fill background (Bug#8992).
981
454592a6
MR
9822011-12-13 Martin Rudalics <rudalics@gmx.at>
983
984 * window.c (Vwindow_combination_resize)
985 (Vwindow_combination_limit): Use t instead of non-nil in
986 doc-strings.
61d4b438
MR
987 (Vrecenter_redisplay): Add first sentence of doc-string on
988 separate line.
53524d93 989 (Frecenter): Fix doc-string typo.
454592a6 990
3633e3aa
KH
9912011-12-11 Kenichi Handa <handa@m17n.org>
992
993 * coding.c (Funencodable_char_position): Pay attention to the
994 buffer text relocation (Bug#9389).
995
7b9d523a
JD
9962011-12-10 Jan Djärv <jan.h.d@swipnet.se>
997
998 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
999 gtk_init (Bug#10100).
1000
b73189c6
EZ
10012011-12-10 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1004 IT->string is nil. (Bug#10263)
1005
f7dfe5d6
JD
10062011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1007
83faebb4
JD
1008 * nsterm.h (x_free_frame_resources): Declare.
1009
f7dfe5d6
JD
1010 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1011 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1012
1013 * nsterm.h (ns_get_defaults_value): Declare.
1014
1015 * nsterm.m (ns_default): Call ns_get_defaults_value.
1016
7cd4e72c
EZ
10172011-12-09 Eli Zaretskii <eliz@gnu.org>
1018
1019 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1020 (Bug#10170)
1021
b34d7317
YM
10222011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1023
1024 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1025 that where the value of an _OBJC_* symbol points to is in the .bss
1026 section (Bug#10240).
1027
76470ad1
KH
10282011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1029
1030 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1031 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1032
745fff94
KH
10332011-12-08 Kenichi Handa <handa@m17n.org>
1034
1035 * ftfont.c (get_adstyle_property): Fix previous change
1036 (Bug#10233).
1037
6e44397c
JB
10382011-12-07 Juanma Barranquero <lekktu@gmail.com>
1039
1040 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1041 dirs from the default value of EMACSLOADPATH (bug#10208).
1042
7efa6272
GM
10432011-12-07 Glenn Morris <rgm@gnu.org>
1044
1045 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1046 installation and source directories as well. (Bug#10208)
1047
f6fc4d87
CY
10482011-12-06 Chong Yidong <cyd@gnu.org>
1049
1050 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1051
2bf26180
GM
10522011-12-06 Glenn Morris <rgm@gnu.org>
1053
1054 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1055 as an error, not just -1. (Bug#10217)
1056
3a6ad4f0
CY
10572011-12-05 Chong Yidong <cyd@gnu.org>
1058
1059 * keyboard.c (process_special_events): New function.
1060 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1061
75a3b399
PE
10622011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * coding.c (encode_designation_at_bol): Don't use uninitialized
1065 local variable (Bug#9318).
1066
c3c9e25e
KH
10672011-12-05 Kenichi Handa <handa@m17n.org>
1068
1069 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1070 return Qnil (Bug#8046, Bug#10193).
1071
5eb05ea3
KH
10722011-12-05 Kenichi Handa <handa@m17n.org>
1073
1074 * coding.c (encode_designation_at_bol): New args charbuf_end and
1075 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1076 (coding_set_source): Return how many bytes coding->source was
1077 relocated.
1078 (coding_set_destination): Return how many bytes
1079 coding->destination was relocated.
1080 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1081 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1082
10832011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1084
1085 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1086 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1087 macro (Bug#9318).
1088
10892011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1090
1091 The following changes are to fix Bug#9318.
1092
a79703f5 1093 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1094 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1095 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1096 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1097
7dbda6df
JB
10982011-12-05 Juanma Barranquero <lekktu@gmail.com>
1099
1100 * lisp.h (process_quit_flag): Fix external declaration.
1101
6d5eb5b0
SM
11022011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1103
1104 Don't macro-inline non-performance-critical code.
1105 * eval.c (process_quit_flag): New function.
1106 * lisp.h (QUIT): Use it.
1107
a0c3fad0
JD
11082011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1109
1110 * nsfns.m (get_geometry_from_preferences): New function.
1111 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1112
6c07aac2
AS
11132011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1114
1115 * emacs.c (Qkill_emacs): Define.
1116 (syms_of_emacs): Initialize it.
1117 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1118 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1119 (quit_throw_to_read_char): Add parameter `from_signal'.
1120 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1121 * lisp.h (QUIT): Call Fkill_emacs if requested.
1122
c052ead4
JD
11232011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1124
1125 * widget.c (update_wm_hints): Return if wmshell is null.
1126 (widget_update_wm_size_hints): New function.
1127
1128 * widget.h (widget_update_wm_size_hints): Declare.
1129
1130 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1131 widget_update_wm_size_hints (Bug#10104).
1132
9e49252b
EZ
11332011-12-03 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1136 before a newline, prepare the bidi iterator for consuming the
1137 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1138 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1139
02b16839
JL
11402011-12-02 Juri Linkov <juri@jurta.org>
1141
1142 * search.c (Fword_search_regexp): New Lisp function created from
1143 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1144 (Fword_search_backward, Fword_search_forward)
1145 (Fword_search_backward_lax, Fword_search_forward_lax):
1146 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1147 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1148
0068070e
SM
11492011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1150
1151 * fileio.c (Finsert_file_contents): Move after-change-function call
1152 to before the "handled:" label, since all "goto handled" appear in
1153 cases where the *-change-functions have already been properly called
1154 (bug#10117).
1155
3360a3fc
AS
11562011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1157
1158 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1159 waiting for input. (Bug#10169)
1160
73d6c093
EZ
11612011-11-30 Eli Zaretskii <eliz@gnu.org>
1162
1163 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1164 verifies glyph row's hash code--we have just reallocated the
1165 glyphs, so their contents can be complete garbage. (Bug#10164)
1166
febe6bea
JB
11672011-11-30 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1170
801a4313
EZ
11712011-11-30 Eli Zaretskii <eliz@gnu.org>
1172
1173 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1174 attributes are tested _before_ calling verify_row_hash, to protect
1175 against GCC re-ordering of the tests. (Bug#10164)
1176
2b56b87e
JD
11772011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1178
1179 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1180
1181 * xterm.c (handle_one_xevent): Only set async_visible and friends
1182 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1183 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1184 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1185
dbf31225
PE
11862011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1189 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1190 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1191 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1192 All uses changed to use GCPRO1 etc.
1193 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1194 Revert to old implementation (i.e., before 2011-03-11).
1195
1305621b
YM
11962011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1197
1198 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1199 of scroll runs so as to avoid assigning disabled bogus rows and
1200 unnecessary graphics copy operations.
1201
8c9afb46
EZ
12022011-11-27 Eli Zaretskii <eliz@gnu.org>
1203
1204 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1205 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1206 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1207 (malloc, free, realloc, calloc): Redirect to e_* only when
1208 compiling Emacs.
1209
1210 * lisp.h (GCTYPEBITS): Move before first use.
1211 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1212 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1213 this macro definition.
1214
1215 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1216 _MSC_VER.
1217
54e9e3bf
JD
12182011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1219
6d5eb5b0
SM
1220 * gtkutil.c (xg_create_frame_widgets):
1221 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1222 present with Gtk+ 2.0.
1223
83aca1cb
PE
12242011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 * fileio.c (Finsert_file_contents): Undo previous change; see
1227 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1228
5b76caa4
PE
12292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 Rename locals to avoid shadowing.
1232 * fileio.c (Finsert_file_contents):
1233 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1234 * process.c (wait_reading_process_output):
1235 Rename inner 'proc' to 'p' to avoid shadowing.
1236 Indent for consistency with usual Emacs style.
1237
8c535114
EZ
12382011-11-25 Eli Zaretskii <eliz@gnu.org>
1239
1240 * xdisp.c (redisplay_window): If cursor row is not fully visible
1241 after recentering, and scroll-conservatively is set to a large
1242 number, scroll window by a few more lines to make the cursor fully
1243 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1244 (start_display): Don't move to the next line if the display should
1245 start at a newline that is part of a display vector or an overlay
1246 string. (Bug#10119)
8c535114 1247
fa4fdb5c
JL
12482011-11-24 Juri Linkov <juri@jurta.org>
1249
1250 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1251 after the `MagickPingImage' call. (Bug#10112)
1252
90ec88df
CY
12532011-11-23 Chong Yidong <cyd@gnu.org>
1254
1255 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1256
56e2e794
MR
12572011-11-23 Martin Rudalics <rudalics@gmx.at>
1258
1259 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1260 making another buffer current. (Bug#10114)
1261
b6e64c41
GM
12622011-11-23 Glenn Morris <rgm@gnu.org>
1263
1264 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1265
6b21de18
CY
12662011-11-23 Chong Yidong <cyd@gnu.org>
1267
1268 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1269 using it (Bug#5984).
1270
b12cd789
EZ
12712011-11-22 Eli Zaretskii <eliz@gnu.org>
1272
1273 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1274 and header-lines, as they don't have one computed for them.
1275 (Bug#10098)
1276
1277 * .gdbinit (prow): Make displayed values more self-explaining.
1278 Add row's hash code.
1279
261b6fd4
LMI
12802011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1281
1282 * process.c (wait_reading_process_output): Fix asynchrounous
1283 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1284 (wait_reading_process_output): Add comment and URL.
261b6fd4 1285
e7cfd277
JD
12862011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1287
1288 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1289
a9b9b7f5
CY
12902011-11-21 Chong Yidong <cyd@gnu.org>
1291
1292 * window.c (Fnext_window, Fprevious_window): Doc fix.
1293
b0d15b4f
SM
12942011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1295
1296 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1297
fe7a3057
JB
12982011-11-20 Juanma Barranquero <lekktu@gmail.com>
1299
1300 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1301
d2999b1a
MR
13022011-11-20 Martin Rudalics <rudalics@gmx.at>
1303
1304 * window.c (Fset_window_combination_limit): Rename argument
1305 STATUS to LIMIT.
1306 (Vwindow_combination_limit): Remove "status" from doc-string.
1307
d5ff9cd0
AS
13082011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 * m/ibms390.h: Remove.
1311 * m/ibms390x.h: Don't include "ibms390.h".
1312
a5bb9bd3
SM
13132011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1314
1315 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1316 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1317
cd1181db
JB
13182011-11-20 Juanma Barranquero <lekktu@gmail.com>
1319
1320 * casetab.c (Fset_case_table):
1321 * charset.c (Fcharset_after): Fix typos.
1322
615a3b8d 13232011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1324
17e845af
PE
1325 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1326 Otherwise, valgrind does not work on some platforms.
1327 Problem reported by Andreas Schwab in
6a0bf43d
PE
1328 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1329 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1330 is set, removing the need for VIRT_ADDRESS_VARIES.
1331 (PURE_P): Use a more-efficient implementation that needs just one
1332 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1333 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1334 to 4 (xorl, subq, cmpq, setbe).
1335 * alloc.c (pure): Always extern now, since that's the
1336 VIRT_ADDR_VARIES behavior.
1337 (PURE_POINTER_P): Use a single comparison, not two, for
1338 consistency with the new puresize.h.
1339 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1340 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1341 Remove VIRT_ADDR_VARIES no longer needed.
1342
f8fe6f96
EZ
13432011-11-19 Eli Zaretskii <eliz@gnu.org>
1344
1345 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1346 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1347 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1348 behave as if the cursor position were at the window margin.
1349
1350 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1351 and the cursor position is out of bounds, behave as if the cursor
1352 position were at the window margin. (Bug#10075)
1353
df05a53c
CY
13542011-11-18 Chong Yidong <cyd@gnu.org>
1355
1356 * window.c (Fwindow_combination_limit): Make first argument
1357 non-optional, since it is meaningless for live windows like the
1358 selected window.
1359
2071918e
DA
13602011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1363
b50a28de
SM
13642011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1365
1366 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1367 (graft_intervals_into_buffer): Simplify.
1368
015137db
EZ
13692011-11-18 Eli Zaretskii <eliz@gnu.org>
1370
1371 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1372 hash values of the two rows.
1373 (copy_row_except_pointers): Preserve the used[] arrays and the
1374 hash values of the two rows. (Bug#10035)
68c95424 1375 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1376
1377 * xdisp.c (row_hash): New function, body extracted from
1378 compute_line_metrics.
1379 (compute_line_metrics): Call row_hash, instead of computing the
1380 hash code inline.
1381
1382 * dispnew.c (verify_row_hash): Call row_hash for computing the
1383 hash code of a row, instead of duplicating code from xdisp.c.
1384
1385 * dispextern.h (row_hash): Add prototype.
1386
a2addb04
TH
13872011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1388
1389 * frame.c (delete_frame): Don't delete the terminal when the last
1390 X frame is closed if emacs is built with GTK toolkit.
1391
df85d315
JB
13922011-11-17 Juanma Barranquero <lekktu@gmail.com>
1393
1394 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1395
a0c2d0ae
MR
13962011-11-17 Martin Rudalics <rudalics@gmx.at>
1397
1398 * window.c (Vwindow_splits): Rename to
1399 Vwindow_combination_resize. Suggested by Juri Linkov.
1400 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1401 of Vwindow_splits.
1402
58179cce
JB
14032011-11-16 Juanma Barranquero <lekktu@gmail.com>
1404
7877f373
JB
1405 * nsfns.m (Fns_font_name):
1406 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1407
b6f67890
MR
14082011-11-16 Martin Rudalics <rudalics@gmx.at>
1409
1410 * window.h (window): Rename slot "nest" to "combination_limit".
1411 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1412 (Fset_window_nest): Rename to Fset_window_combination_limit.
1413 (Vwindow_nest): Rename to Vwindow_combination_limit.
1414 (recombine_windows, make_parent_window, make_window)
1415 (Fsplit_window_internal, saved_window)
1416 (Fset_window_configuration, save_window_save): Rename all
1417 occurrences of window_nest to window_combination_limit.
1418
c7015153
JB
14192011-11-15 Juanma Barranquero <lekktu@gmail.com>
1420
1421 * image.c (imagemagick_load_image): Fix typo.
1422
322ad6ec
EZ
14232011-11-14 Eli Zaretskii <eliz@gnu.org>
1424
1425 * xdisp.c (display_line): Move the call to
1426 highlight_trailing_whitespace before the call to
1427 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1428 faces of all the glyphs to compute ROW's hash value.
1429 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1430
f067b8ec
JB
14312011-11-14 Juanma Barranquero <lekktu@gmail.com>
1432
1433 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1434 just return (bug#10044).
1435
1e5b2111
EZ
14362011-11-12 Eli Zaretskii <eliz@gnu.org>
1437
7ef3cbd5
EZ
1438 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1439 with user-defined heap size. Bump the default size of the temacs
1440 heap to 27MB, to avoid memory warning when running temacs.
1441 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1442
1e5b2111
EZ
1443 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1444 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1445 (verify_row_hash) [XASSERTS]: New function.
1446 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1447 that the hash value of glyph rows is correct.
1e5b2111 1448
89d61221
MR
14492011-11-12 Martin Rudalics <rudalics@gmx.at>
1450
1451 * window.h (window): Remove splits slot.
1452 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1453 (Fdelete_other_windows_internal, make_parent_window)
1454 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1455 (Fset_window_configuration, save_window_save): Don't deal with
1456 split status of windows.
1457 (saved_window): Remove splits slot.
1458 (Vwindow_splits): Rewrite doc-string.
1459
97f18cc8
JD
14602011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1461
1462 * xfns.c (unwind_create_frame):
1463 * nsfns.m (unwind_create_frame):
1464 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1465 Vframe_list (Bug#9999).
1466
22a648b4
DA
14672011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1468
0b381c7e 1469 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1470
659afede
KH
14712011-11-11 Kenichi Handa <handa@m17n.org>
1472
1473 * callproc.c (Fcall_process): Set the member dst_multibyte of
1474 process_coding.
1475
9ac0394b
KH
14762011-11-11 Johan Bockgård <bojohan@gnu.org>
1477
1478 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1479 avoid a crash (bug#9496).
1480
2fbdc249
CY
14812011-11-09 Chong Yidong <cyd@gnu.org>
1482
1483 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1484 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1485
ac6b1f81
PE
14862011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1489
09db192c
PE
14902011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1491
1492 Avoid some portability problems by eschewing 'extern inline' functions.
1493 The trivial performance wins aren't worth the portability hassles; see
1494 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1495 et seq.
1496 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1497 (window_box_width, window_box_left, window_box_left_offset)
1498 (window_box_right, window_box_right_offset): Undo previous change,
1499 by removing the "extern"s.
1500 * intervals.c (adjust_intervals_for_insertion)
1501 (adjust_intervals_for_deletion): Undo previous change,
1502 making these static again.
1503 (offset_intervals, temp_set_point_both, temp_set_point)
1504 (copy_intervals_to_string): No longer inline.
1505 * xdisp.c (window_text_bottom_y, window_box_width)
1506 (window_box_height, window_box_left_offset)
1507 (window_box_right_offset, window_box_left, window_box_right)
1508 (window_box): No longer inline.
1509
105216ed
CY
15102011-11-08 Chong Yidong <cyd@gnu.org>
1511
1512 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1513 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1514 Signal an error if not a live window.
105216ed
CY
1515 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1516 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1517
ae9e237f
JB
15182011-11-07 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * lisp.h (syms_of_abbrev): Remove declaration.
1521 Reported by CHENG Gao <chenggao@royau.me>.
1522
c7aa8333
EZ
15232011-11-07 Eli Zaretskii <eliz@gnu.org>
1524
1525 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1526 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1527 of temacs in GUI mode.
1528
be7f5545
MR
15292011-11-07 Martin Rudalics <rudalics@gmx.at>
1530
1531 * window.h: Declare delete_all_child_windows instead of
1532 delete_all_subwindows.
1533 * window.c (Fwindow_nest, Fset_window_nest)
1534 (Fset_window_new_total, Fset_window_new_normal)
1535 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1536 (delete_all_subwindows): Rename to delete_all_child_windows.
1537 (Fdelete_other_windows_internal, Fset_window_configuration):
1538 Call delete_all_child_windows instead of delete_all_subwindows.
1539 * frame.c (delete_frame): Call delete_all_child_windows instead
1540 of delete_all_subwindows.
1541
ca78dc43
PE
15422011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1545 This is also needed for porting to any host where GC_MARK_STACK is
1546 not GC_MAKE_GCPROS_NOOPS.
1547 (which_symbols): Use it.
1548
a0241d01
KH
15492011-11-07 Kenichi Handa <handa@m17n.org>
1550
1551 * coding.c (coding_set_destination): Check coding->src_pos only
1552 when coding->src_object is a buffer (bug#9910).
1553
1554 * process.c (send_process): Set the member src_multibyte of coding
1555 to 0 (bug#9911) when sending a unibyte text.
1556
1557 * callproc.c (Fcall_process): Set the member src_multibyte of
1558 process_coding to 0 (bug#9912).
1559
a64bfdfa 15602011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1561
1562 * xmenu.c (cleanup_widget_value_tree): New function.
1563 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1564 calling free_menubar_widget_value_tree directly (Bug#9830).
1565
cb41b32a
PE
15662011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1567
1568 Fix some portability problems with 'inline'.
1569 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1570 (window_box_width, window_box_left, window_box_left_offset)
1571 (window_box_right, window_box_right_offset): Declare extern.
1572 Otherwise, these inline functions do not conform to C99 and
1573 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1574 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1575 * intervals.c (adjust_intervals_for_insertion)
1576 (adjust_intervals_for_deletion): Now extern, because otherwise the
1577 extern inline functions 'offset_intervals' couldn't refer to it.
1578 (static_offset_intervals): Remove.
1579 (offset_intervals): Rewrite using the old contents of
1580 static_offset_intervals. The old version didn't conform to C99
1581 because an extern inline function contained a reference to an
1582 identifier with static linkage.
1583
b7041366
AS
15842011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1585
1586 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1587 GC.
1588
88a37c4d
EZ
15892011-11-06 Eli Zaretskii <eliz@gnu.org>
1590
1591 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1592 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1593 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1594 return Qleft_to_right.
1595
49745b39
CY
15962011-11-06 Chong Yidong <cyd@gnu.org>
1597
1598 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1599 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1600 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1601 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1602 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1603 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1604 (Fwindow_vscroll): Doc fix.
1605 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1606 argument, since it makes no sense to pass a live window and for
1607 consistency with window-child.
1608
1f05cd82
CS
16092011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1610
1611 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1612 support MSVC.
1613
22610910
JR
16142011-11-05 Jason Rumney <jasonr@gnu.org>
1615
1616 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1617 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1618 fonts (Bug#6029).
1619 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1620 bitwise arithmetic preventing use of unicode-sip and non-truetype
1621 opentype fonts.
1622
a06776b2
EZ
16232011-11-05 Eli Zaretskii <eliz@gnu.org>
1624
3ad924ba
EZ
1625 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1626 "emacs"-only part.
1627
a06776b2
EZ
1628 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1629 initialization code to keep similarity to xfns.c after changes
1630 from 2011-11-05.
1631
c9e7db78
JD
16322011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1633
a97f8f3f
JD
1634 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1635 (unwind_create_frame): New function (Bug#9943).
1636 (Fx_create_frame): Restructure code to be more similar to the one in
1637 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1638 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1639 Move terminal->reference_count++ just before making the frame official
1640 (Bug#9943).
1641
1642 * nsterm.m (x_free_frame_resources): New function.
1643 (x_destroy_window): Move code to x_free_frame_resources.
1644
c9e7db78 1645 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1646 (Fx_create_frame, x_create_tip_frame):
1647 Move terminal->reference_count++ just before making the frame
75f1671a 1648 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1649 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1650
a6fc3b5c
EZ
16512011-11-05 Eli Zaretskii <eliz@gnu.org>
1652
1653 Support MSVC build with newer versions of Visual Studio.
1654 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1655 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1656 nt/gmake.defs.
1657
1658 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1659 which are not supported by MSVC.
1660 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1661 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1662 bitfields.
1663 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1664 types in bitfields.
1665 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1666
1667 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1668
58179cce 16692011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1670
1671 Support MSVC build with newer versions of Visual Studio.
1672 * w32.c: Don't include w32api.h for MSVC.
1673 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1674
1675 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1676 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1677 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1678 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1679 e_* cousins.
1680 (alloca) [_MSC_VER]: Define to _alloca.
1681
1682 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1683
1684 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1685
a58c13ed
EZ
16862011-11-04 Eli Zaretskii <eliz@gnu.org>
1687
1688 * xdisp.c (note_mouse_highlight): If either of
1689 previous/next-single-property-change returns nil, treat that as
1690 the beginning or the end of the buffer. (Bug#9955)
1691
fe0b6370
JD
16922011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1693
a58c13ed 1694 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1695 label is not null (Bug#9951).
1696 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1697 may be NULL.
1698
89bd5ee1
EZ
16992011-11-04 Eli Zaretskii <eliz@gnu.org>
1700
1701 * window.c (Fwindow_body_size): Mention in the doc string that the
1702 return value is in frame's canonical units. (Bug#9949)
1703
84c3edb9
EZ
17042011-11-03 Eli Zaretskii <eliz@gnu.org>
1705
4e2fb5c7
EZ
1706 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1707
84c3edb9 1708 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1709 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1710 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1711
bc17a887
EZ
17122011-11-01 Eli Zaretskii <eliz@gnu.org>
1713
1714 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1715 Don't stop backward scan on the continuation glyph, even though
1716 its CHARPOS is positive.
6d5eb5b0
SM
1717 (mouse_face_from_buffer_pos, note_mouse_highlight):
1718 Rename cover_string to disp_string.
bc17a887 1719
4ee88440
MR
17202011-11-01 Martin Rudalics <rudalics@gmx.at>
1721
1722 * window.c (temp_output_buffer_show): Don't use
1723 Vtemp_buffer_show_specifiers.
1724 (Vtemp_buffer_show_specifiers): Remove unused variable.
1725
c2ff3c02
EZ
17262011-10-30 Eli Zaretskii <eliz@gnu.org>
1727
1728 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1729 past the beginning of the current glyph matrix.
1730
58179cce 17312011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1732
1733 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1734 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1735 HAVE_GTK3 (Bug#9869).
b77a6a7f 1736
3b574623
JD
1737 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1738 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1739
b77a6a7f
JD
1740 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1741
1742 * xterm.c: Declare x_handle_net_wm_state to return int.
1743 (handle_one_xevent): Check if we are iconified but don't have
1744 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1745 (get_current_wm_state): Return non-zero if not hidden,
1746 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1747 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1748 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1749 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1750
196e41e4
PE
17512011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1752
1753 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1754 so that this new function doesn't get optimized away by a
1755 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1756
021f2e1a
AS
17572011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1758
1759 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1760
8b058d44
EZ
17612011-10-29 Eli Zaretskii <eliz@gnu.org>
1762
1763 Fix the `xbytecode' command.
1764 * .gdbinit (xprintbytestr): New command.
b50a28de 1765 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1766 (xbytecode): Print the byte-code string as well.
1767
4452fb80
EZ
17682011-10-29 Kim Storm <storm@cua.dk>
1769
8b058d44
EZ
1770 * alloc.c (which_symbols): New function.
1771
21b72067
AS
17722011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1773
1774 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1775 line. (Bug#9903)
1776
83ed7b5c
GM
17772011-10-29 Glenn Morris <rgm@gnu.org>
1778
1779 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1780 Not clear what it was for, and it causes various bugs. (Bug#9839)
1781
5a7a728b
EZ
17822011-10-28 Eli Zaretskii <eliz@gnu.org>
1783
1784 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1785 possible random value that matches one of those tested as
1786 condition to clear the mouse face.
1787
d3d0842f
CY
17882011-10-28 Chong Yidong <cyd@gnu.org>
1789
1790 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1791
31b39d13
DN
17922011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1793
1794 * window.c (make_window): Initialize phys_cursor_on_p.
1795
9aba6043
SM
17962011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1797
1798 * lisp.h (struct Lisp_Symbol): Update comments.
1799
c20992f4
JB
18002011-10-28 Juanma Barranquero <lekktu@gmail.com>
1801
1802 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1803
db4f02f2
EZ
18042011-10-28 Eli Zaretskii <eliz@gnu.org>
1805
1806 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1807 <oslsachem@gmail.com> for helping to debug this.
1808
1809 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1810 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1811 (g_b_init_get_glyph_outline_w): New static variables.
1812 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1813 (GetGlyphOutlineW_Proc): New typedefs.
1814 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1815 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1816 New functions.
1817 (w32font_open_internal, compute_metrics):
1818 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1819 instead of calling the "wide" APIs directly.
1820
1821 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1822
1823 * w32.h (syms_of_w32font): Add prototype.
1824
87e68db4
JB
18252011-10-27 Juanma Barranquero <lekktu@gmail.com>
1826
1827 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1828 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1829 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1830 (Fmove_to_window_line): Doc fix.
1831
435c1d67
CY
18322011-10-27 Chong Yidong <cyd@gnu.org>
1833
1834 * process.c (make_process): Set gnutls_state to NULL.
1835
1836 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1837 non-NULL, regardless of GNUTLS_INITSTAGE.
1838 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1839 an error. Set process slots as soon as we allocate them.
1840
1841 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1842
9c6c6f49
CY
18432011-10-27 Chong Yidong <cyd@gnu.org>
1844
9aba6043
SM
1845 * gnutls.c (emacs_gnutls_deinit): New function.
1846 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1847 (Fgnutls_deinit, Fgnutls_boot): Use it.
1848
1849 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1850 (deactivate_process): Call emacs_gnutls_deinit.
1851
657d08d3
JB
18522011-10-27 Juanma Barranquero <lekktu@gmail.com>
1853
1854 * image.c (x_create_x_image_and_pixmap):
1855 * w32.c (sys_rename, w32_delayed_load):
1856 * w32font.c (fill_in_logfont):
1857 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1858
5430d399
JB
18592011-10-26 Juanma Barranquero <lekktu@gmail.com>
1860
1861 * w32fns.c (w32_default_color_map): New function,
1862 extracted from Fw32_default_color_map.
a7ef684b 1863 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1864
fe0055fa
PE
18652011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1868
e6346438
SM
18692011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1870
1871 * keyboard.c (test_undefined): New function (bug#9751).
1872 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1873
e112cc37
ET
18742011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1875
1876 * sysdep.c (init_sys_modes): Fix the check for the controlling
1877 terminal (Bug#6649).
1878
7b5d6677
EZ
18792011-10-20 Eli Zaretskii <eliz@gnu.org>
1880
1881 * dispextern.h (struct bidi_it): New member next_en_type.
1882
1883 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1884 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1885 current character, check also for next_en_type being WEAK_EN.
1886 (bidi_resolve_weak): Don't enter the expensive loop if the current
1887 position is before next_en_pos. Record the bidi type of the first
1888 non-ET, non-BN character we find, in addition to its position.
1889 (bidi_level_of_next_char): Invalidate next_en_type when
1890 next_en_pos is over-stepped.
1891
7da0b018
PE
18922011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1895 * editfns.c: Rewrite current-time-zone so that it invokes
1896 the equivalent of (format-time-string "%Z") to get the time zone name.
1897 This fixes a bug when the time zone name contains characters that
1898 need converting from the system time locale to Emacs internal format.
1899 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1900 that patch fixed format-time-string to do the conversion, but
1901 I forgot to fix current-time-zone.
1902 (format_time_string): New function, containing most of
1903 what Fformat_time_string used to contain.
1904 (Fformat_time_string): Rewrite in terms of format_time_string.
1905 This doesn't change this function's behavior.
1906 (current-time-zone): Rewrite to use format_time_string.
1907 This fixes the bug reported by Michael Schierl in
1908 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1909 Jason Rumney's 2007-06-07 change worked around this bug, but
1910 didn't fix it.
1911 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1912
8547b010
EZ
19132011-10-19 Eli Zaretskii <eliz@gnu.org>
1914
1915 * xdisp.c (start_display): If the character at POS is displayed
1916 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1917 (try_window_reusing_current_matrix): If a line ends in a display
1918 vector or the next line starts in a display vector, continue
1919 redrawing the window even though the character position of
1920 start_row was reached.
8547b010
EZ
1921 (Bug#9771, part 2)
1922
4e948d15
CY
19232011-10-18 Chong Yidong <cyd@gnu.org>
1924
1925 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1926 with nobreak-char-display too.
1927
4787455f
EZ
19282011-10-18 Eli Zaretskii <eliz@gnu.org>
1929
1930 Fix part 3 of bug#9771.
1931 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1932 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1933 non-neutral characters if the current character is a paragraph
1934 separator (a.k.a. Newline). This avoids running the same
1935 expensive loop twice, once when we consume the preceding newline
1936 and the other time when the line actually needs to be displayed.
1937 Avoid the loop when we see neutrals on the base embedding level
1938 following a character whose directionality is the same as the
1939 paragraph's. This avoids running the expensive loop when a line
1940 ends in a long sequence of neutrals, like control characters.
1941 Add assertion against STRONG_AL type. Slightly rearrange code
1942 that determines the type of a neutral given the first non-neutral
1943 that follows it.
1944 (bidi_level_of_next_char): Set next_en_pos to zero when
1945 invalidating its info.
1946
2c91f553
EZ
19472011-10-17 Eli Zaretskii <eliz@gnu.org>
1948
1949 * xdisp.c (push_display_prop): Determine whether to record string
1950 or buffer position by IT->string, not by IT->method. Allow
1951 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1952 (move_it_vertically_backward): Don't look for character position
1953 immediately after the newline when in a continuation line.
1954 (Bug#9771, part 1)
2c91f553 1955
c7b08b0d
MR
19562011-10-15 Martin Rudalics <rudalics@gmx.at>
1957
1958 * window.c (coordinates_in_window): Rewrite and delabelize
1959 vertical border check. (Bug#5357) (Bug#9618)
1960
6b02f655
SM
19612011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1962
1963 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1964 errors in XSetWindowBorder (bug#9310).
1965
81d40c92
DA
19662011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1967
1968 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1969 avoid crash when xmalloc overrun checking is enabled.
1970
d4172c3b
EZ
19712011-10-13 Eli Zaretskii <eliz@gnu.org>
1972
1973 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1974 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1975 cursor motion with <left> and <right> arrow keys.
1976
1977 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1978 some callers set that themselves.
1979
b00eea75
EZ
19802011-10-12 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1983 display string and the previous row comes from the same string and
1984 is empty. (Bug#9739) (Bug#9738)
1985
8fe012c4
SM
19862011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1987
1988 * doc.c (get_doc_string): Encode file name (bug#9735).
1989
0074aef2
EZ
19902011-10-12 Eli Zaretskii <eliz@gnu.org>
1991
79beb178
EZ
1992 * bidi.c (bidi_level_of_next_char):
1993 * xdisp.c (get_visually_first_element): Remove old incorrect
1994 comments regarding the Unicode Line Separator character.
1995
0074aef2
EZ
1996 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1997
6e4b3fbe
DA
19982011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1999
2000 * alloc.c (Fgc_status): Do not access beyond zombies array
2001 boundary if nzombies > MAX_ZOMBIES.
2002 * alloc.c (dump_zombies): Add missing format specifier.
2003
0324f3af
PE
20042011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2005
b5525cac
PE
2006 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2007 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2008
0324f3af
PE
2009 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2010 Some packages use them to denote characters with modifiers.
2011
e9b5f888
AS
20122011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2013
2014 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2015 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2016 matching a pp-number. Rename parameter var to var1.
2017
127827c0
SM
20182011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2019
2020 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2021
c8fd3bd0
GM
20222011-10-08 Glenn Morris <rgm@gnu.org>
2023
2024 * callint.c (Fcall_interactively): Give a more explicit error for the
2025 'c' case with a non-character input. (Bug#8479)
2026
352ec8ff
EZ
20272011-10-08 Eli Zaretskii <eliz@gnu.org>
2028
03669ccb
EZ
2029 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2030 lines.
7061c986
EZ
2031 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2032 lines that are hscrolled on the left.
03669ccb 2033
352ec8ff
EZ
2034 * dispnew.c (buffer_posn_from_coords): Account for a possible
2035 presence of header-line. (Bug#4426)
2036
a66cfb1c
SM
20372011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2038
6b02f655
SM
2039 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2040 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2041
7c5ee88e
PE
20422011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2043
2044 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2045 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2046 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2047 this makes Emacs dump core during garbage collection on rare
2048 occasions. sizeof is obviously inferior to offsetof here, so
2049 stick with offsetof.
2050 (GC_POINTER_ALIGNMENT): New macro.
2051 (mark_memory): Omit 3rd (offset) arg; caller changed.
2052 Don't assume EMACS_INT alignment is the same as pointer alignment.
2053
df1bbe5b
SM
20542011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2055
2056 * keyboard.c (read_key_sequence_remapped): New var.
2057 (read_key_sequence): Compute remapping in the right buffer.
2058 (command_loop_1): Use read_key_sequence's remapping directly.
2059
51553db6
SM
20602011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2061
32c1fffd
SM
2062 * dired.c (file_name_completion): Don't expand file name.
2063 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2064 before checking file name handler.
2065
51553db6
SM
2066 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2067 they've been requested explicitly (bug#9591).
2068
b6bd1599 20692011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2070
2071 * keymap.c (Fsingle_key_description): Use make_specified_string
2072 instead of build_string to build string from push_key_description.
2073 (Bug#5193)
2074
f701dc2a
PE
20752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2076
4222c55d
PE
2077 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2078 This fixes a Y2038 bug on 64-bit hosts.
2079 * buffer.c (reset_buffer):
2080 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2081 (Fclear_buffer_auto_save_failure):
2082 Use 0, not -1, to represent an unset failure time, since time_t
2083 might not be signed.
2084
f701dc2a
PE
2085 Remove dependency on glibc malloc internals.
2086 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2087 Move back here from lisp.h, but with their new implementations.
2088 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2089 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2090 * charset.c (charset_table_init): New static var.
2091 (syms_of_charset): Use it instead of xmalloc. This removes a
2092 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2093 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2094 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2095 Move back to alloc.c.
2096 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2097 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2098
9ceebf39
JD
20992011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2100
2101 * nsterm.m (windowDidResize): Call x_set_window_size only when
2102 ns_in_resize is true. Otherwise set pixelwidth/height and
2103 call change_frame_size (Bug#9628).
2104
cb993c58
PE
21052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2106
3930c88b
PE
2107 Port --enable-checking=all to Fedora 14 x86-64.
2108 * charset.c (syms_of_charset): Also account for glibc malloc's
2109 internal overhead when calculating the initial malloc maximum.
2110
cb993c58
PE
2111 Port --enable-checking=all to Fedora 14 x86.
2112 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2113 Move to lisp.h.
2114 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2115 (overrun_check_realloc, overrun_check_free):
2116 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2117 That way, xmalloc returns a properly-aligned pointer even if
2118 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2119 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2120 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2121 into account when calculating the initial malloc maximum.
2122 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2123 Move here from alloc.c, so that charset.c can use it too.
2124 Properly align; the old code wasn't right for common 32-bit hosts
2125 when configured with --enable-checking=all.
2126 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2127 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2128
31bed486
EZ
21292011-09-29 Eli Zaretskii <eliz@gnu.org>
2130
04c70788 2131 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2132 use EDOM.
2133
fbcaa2f3
EZ
21342011-09-28 Eli Zaretskii <eliz@gnu.org>
2135
2136 * xdisp.c (compute_display_string_end): If there's no display
2137 string at CHARPOS, return -1.
2138
2139 * bidi.c (bidi_fetch_char): When compute_display_string_end
2140 returns a negative value, treat the character as a normal
2141 character not covered by a display string. (Bug#9624)
2142
a239d4e9
JB
21432011-09-28 Juanma Barranquero <lekktu@gmail.com>
2144
2145 * lread.c (Fread_from_string): Fix typo in docstring.
2146
88652fd5
EZ
21472011-09-27 Eli Zaretskii <eliz@gnu.org>
2148
2149 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2150 newline, reseat the iterator instead of bidi-iterating there one
2151 character at a time. (Bug#9610)
32c1fffd
SM
2152 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2153 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2154
ed497dd4
AS
21552011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2156
2157 * lread.c (readevalloop): Use correct code for NBSP.
2158 (read1): Likewise. (Bug#9608)
2159
b2bf61aa
MA
21602011-09-25 Michael Albinus <michael.albinus@gmx.de>
2161
2162 * dbusbind.c (Fdbus_register_signal): When service is not
2163 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2164
32bbb17c
GM
21652011-09-25 Glenn Morris <rgm@gnu.org>
2166
2167 * buffer.c (truncate-lines): Doc fix.
2168
94e0933e
CY
21692011-09-24 Chong Yidong <cyd@stupidchicken.com>
2170
2171 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2172 (Fset_window_next_buffers): Doc fix.
2173
cddde921
GM
21742011-09-24 Glenn Morris <rgm@gnu.org>
2175
2176 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2177
1260aef1
PE
21782011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2179
25b4bfa0
PE
2180 Fix minor problems found by static checking.
2181 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2182 * indent.c (Fvertical_motion): Fix == vs = typo.
2183
e3cbd34b
EZ
21842011-09-24 Eli Zaretskii <eliz@gnu.org>
2185
a66cfb1c
SM
2186 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2187 Default value is now t. Doc fix.
6bf7006f 2188
e3cbd34b 2189 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2190 logic when moving up, not only when moving down. Fix the
e3cbd34b 2191 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2192 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2193
2194 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2195 CHARPOS is covered by a display string which includes newlines.
2196 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2197 is covered by a display string with embedded newlines.
2198
a3de0cbd
MA
21992011-09-24 Michael Albinus <michael.albinus@gmx.de>
2200
2201 * dbusbind.c (Fdbus_register_signal): Add match rule to
2202 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2203 (Fdbus_register_method, Vdbus_registered_objects_table):
2204 Fix docstring.
a3de0cbd 2205
b260039d
JM
22062011-09-24 Jim Meyering <meyering@redhat.com>
2207
32c1fffd 2208 do not ignore write error for any output size
b260039d
JM
2209 The previous change was incomplete.
2210 While it makes emacs --batch detect the vast majority of stdout
2211 write failures, errors were still ignored whenever the output size is
2212 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2213 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2214 && echo FAIL: ignored write error
2215 FAIL: ignored write error
2216 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2217 && echo FAIL: ignored write error
2218 FAIL: ignored write error
2219 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2220
8eca8a7c
AS
22212011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2222
2223 * emacs.c (Fkill_emacs): In noninteractive mode exit
2224 non-successfully if a write error occurred on stdout. (Bug#9574)
2225
3341db62
EZ
22262011-09-21 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2229 the xassert test.
2230
2231 * dispextern.h (struct it): Update the comment documenting what
2232 can it->OBJECT be.
2233
8c203dbf
EZ
22342011-09-20 Eli Zaretskii <eliz@gnu.org>
2235
2236 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2237 a display string, extend search for cursor position to end of row.
2238 (find_row_edges): If the row ends in a newline from a display
2239 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2240 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2241 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2242 non-empty line. Fixes confusing cursor motion with arrow keys at
2243 the beginning of a line that starts with whitespace.
8c203dbf 2244
a4824228
LMI
22452011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2246
2247 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2248 (bug#9493).
2249
33ed493b
CY
22502011-09-18 Chong Yidong <cyd@stupidchicken.com>
2251
2252 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2253 boolean (Bug#9154).
2254
56cd55c8
EZ
22552011-09-18 Eli Zaretskii <eliz@gnu.org>
2256
2257 * xdisp.c (display_line): Record maximum and minimum buffer
2258 positions even if no glyphs were produced (e.g., by a zero-width
2259 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2260 buffer positions that will be removed from the glyph row because
2261 they don't fit.
c02dcedf
EZ
2262 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2263 column is beyond frame width: don't subtract 1 "pixel" when
2264 computing width of the stretch.
3e62b7e0
EZ
2265 (reseat_at_next_visible_line_start): Undo the change made on
2266 2011-09-17 that saved paragraph information and restored it after
2267 the call to `reseat'. (Bug#9545)
56cd55c8 2268
5ed99d36 22692011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2270
2271 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2272 and turn window cursor on if cleared (Bug#9415).
2273
5ed99d36 22742011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2275
2276 * search.c (boyer_moore): Take unibyte characters from pattern
2277 literally. (Bug#9458)
2278
9bade7b2
EZ
22792011-09-18 Eli Zaretskii <eliz@gnu.org>
2280
2281 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2282
e5e9d610
PE
22832011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2284
87e4427a
PE
2285 Fix minor problem found by static checking.
2286 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2287 initialized, to pacify gcc -Wuninitialized.
2288
e5e9d610
PE
2289 * fileio.c: Report proper errno when syscall falls.
2290 (Finsert_file_contents): Save and restore errno,
2291 so that report_file_error outputs the correct diagnostic.
2292 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2293
a1674f0b
EZ
22942011-09-18 Eli Zaretskii <eliz@gnu.org>
2295
2296 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2297
fbfb6dd4
EZ
22982011-09-17 Eli Zaretskii <eliz@gnu.org>
2299
2300 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2301 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2302
bb187662
EZ
23032011-09-17 Eli Zaretskii <eliz@gnu.org>
2304
1137e8b8 2305 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2306 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2307
2308 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2309 (bidi_find_paragraph_start): Search back for paragraph beginning
2310 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2311 (bidi_move_to_visually_next): Only trigger paragraph-related
2312 computations when the last character is a newline or at EOB, not
2313 just any NEUTRAL_B. (Bug#9470)
2314
bb187662
EZ
2315 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2316 truncated lines if point is covered by a display string. (Bug#9524)
2317
2e621251
PE
23182011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2321 (cons_to_x_long): New function.
2322 (lisp_data_to_selection_data): Use it. Correct the test for
2323 short-versus-long data; it was negated. Break out of vector
2324 loop, for efficiency, when a long datum is discovered.
2325
91a15bc6
SM
23262011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2327
2328 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2329
b41c3a35
EZ
23302011-09-16 Eli Zaretskii <eliz@gnu.org>
2331
2332 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2333 GCC PR/17406) by declaring this function with external scope.
2334
7812ba2d
PE
23352011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2338 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2339
cf7edc2a
AS
23402011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2341
2342 * editfns.c (Fformat): Correctly handle text properties on "%%".
2343
bd01620e
EZ
23442011-09-15 Eli Zaretskii <eliz@gnu.org>
2345
2346 * xterm.c (x_draw_composite_glyph_string_foreground):
2347 * w32term.c (x_draw_composite_glyph_string_foreground):
2348 * term.c (encode_terminal_code):
2349 * composite.c (composition_update_it, get_composition_id):
2350 * xdisp.c (get_next_display_element)
2351 (fill_composite_glyph_string): Add comments about special meaning
2352 of TAB characters in a composition.
2353
a02719a3
PE
23542011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2357 This occurs when processing a multibyte format.
2358 Problem reported by Wolfgang Jenker.
a02719a3 2359
72589a3c
JB
23602011-09-15 Johan Bockgård <bojohan@gnu.org>
2361
2362 * xdisp.c (try_cursor_movement): Only check for exact match if
2363 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2364
1c14176c
PE
23652011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 Remove unused external symbols.
2368 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2369 * xdisp.c (calc_pixel_width_or_height): Now static.
2370 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2371 * indent.c (check_display_width):
2372 * w32term.c: Fix comment to match code.
2373 * xterm.c, xterm.h (x_catching_errors): Remove.
2374
d2eea5b5
PE
23752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2376
2377 * xselect.c: Use signed conversions more consistently (Bug#9498).
2378 (selection_data_to_lisp_data): Assume incoming selection data are
2379 signed integers, not unsigned. This is to be consistent with
2380 outgoing selection data, which was modified to use signed integers
2381 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2382 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2383 expects long, not unsigned long.
2384
46888499
EZ
23852011-09-14 Eli Zaretskii <eliz@gnu.org>
2386
2387 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2388 computation of loop end. Reported by Johan Bockgård
2389 <bojohan@gnu.org>.
2390
ef8ef9fb
CY
23912011-09-13 Chong Yidong <cyd@stupidchicken.com>
2392
2393 * frame.c (Fother_visible_frames_p): Function deleted.
2394
fa819fed
EZ
23952011-09-12 Eli Zaretskii <eliz@gnu.org>
2396
2397 * indent.c (compute_motion): Process display vector front to back
2398 rather than the other way around. (Bug#2496)
2399
2ba8e008
SM
24002011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2401
2402 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2403
20f53c69
CY
24042011-09-11 Chong Yidong <cyd@stupidchicken.com>
2405
2406 * minibuf.c (Fread_from_minibuffer): Doc fix.
2407
d562d7a4
EZ
24082011-09-11 Eli Zaretskii <eliz@gnu.org>
2409
2410 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2411 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2412
1c4d7f3d
LMI
24132011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2414
2415 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2416 value for non-existent files.
2417
b885bf36
EZ
24182011-09-11 Eli Zaretskii <eliz@gnu.org>
2419
2420 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2421 set its "size" to -1. This will set the modtime_size field of
2422 the corresponding buffer to -1, which is what
2423 verify-visited-file-modtime expects for files that do not exist.
2424 (Bug#9139)
2425
6612f0bf
PE
24262011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2427
2428 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2429 here ...
2430 * lisp.h: ... from here. push_key_description is no longer
2431 defined in keyboard.c, so its declaration should not be in
2432 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2433 logically belongs with push_key_description.
2434
dfb3f755
PE
24352011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * buffer.h: Include <sys/types.h> instead of <time.h>.
2438 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2439 Problem reported by Herbert J. Skuhra.
2440
3134906c
LMI
24412011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2442
2443 * xml.c (parse_region): Make the parsing work for
2444 non-comment-starting XML files again (bug#9144).
2445
8d903f4e
AS
24462011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2447
2448 * image.c (gif_load): Fix calculation of bottom and right corner.
2449 (Bug#9468)
2450
80ad64f4
EZ
24512011-09-10 Eli Zaretskii <eliz@gnu.org>
2452
2453 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2454 redisplay in small windows.
2455
208a048d
EZ
24562011-09-09 Eli Zaretskii <eliz@gnu.org>
2457
2458 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2459
9b1c252e
MR
24602011-09-08 Martin Rudalics <rudalics@gmx.at>
2461
2462 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2463 Operate on live windows only.
2464
2949f33b
JB
24652011-09-08 Juanma Barranquero <lekktu@gmail.com>
2466
2467 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2468
e08dcafd
EZ
24692011-09-07 Eli Zaretskii <eliz@gnu.org>
2470
2471 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2472 only under bidi iteration.
2473
115b96bd
JD
24742011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2475
2476 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2477
c8199d0f
PE
24782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2479
2480 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2481 Without this fix, the command to link temacs failed due to an
2482 undefined symbol __builtin_isnan. This is because
2483 /usr/include/iso/math_c99.h #defines isnan(x) to
2484 __builtin_isnan(x), but the bundled gcc, which identifies itself
2485 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2486 a __builtin_isnan.
2487 * floatfns.c (isnan): #undef, and then #define to a clone of
2488 what's in data.c.
2489 (Fisnan): Always define, since it's always available now.
2490 (syms_of_floatfns): Always define isnan at the Lisp level.
2491
e39b275c 24922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2493
2494 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2495
b2db44d9 24962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2497
f4af5137 2498 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2499 The previous code assumed that file offsets (off_t values) fit in
2500 EMACS_INT variables, which is not true on typical 32-bit hosts.
2501 The code messed up by falsely reporting buffer overflow in cases
2502 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2503 when "big" contains more than 2**29 bytes, even though this
2504 inserts just one byte and does not overflow the buffer.
2505 (Finsert_file_contents): Store file offsets as off_t
2506 values, not as EMACS_INT values. Check for overflow when
2507 converting between EMACS_INT and off_t. When checking for
2508 buffer overflow or for overlap, take the offsets into account.
2509 Don't use EMACS_INT for small values where int suffices.
2510 When checking for overlap, fix a typo: ZV was used where
2511 ZV_BYTE was intended.
2512 (Fwrite_region): Don't assume off_t fits into 'long'.
2513 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2514
ecfc0a49
MA
25152011-09-05 Michael Albinus <michael.albinus@gmx.de>
2516
2517 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2518
6511acf2 25192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2520
0999621a 2521 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2522
2523 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2524 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2525 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2526 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2527 (modify_event_symbol): Do not assume that the length of
2528 name_alist_or_stem is safe to alloca and fits in int.
2529 (Fexecute_extended_command): Likewise for function name and binding.
2530 (Frecursion_depth): Wrap around reliably on integer overflow.
2531 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2532 since some callers pass EMACS_INT values.
2533 (Fsingle_key_description): Don't crash if symbol name contains more
2534 than MAX_ALLOCA bytes.
2535 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2536 (get_minibuffer): Arg is now EMACS_INT, not int.
2537 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2538 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2539 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2540
2be7d702
PE
2541 * dbusbind.c (signature_cat): New function.
2542 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2543 Do not overrun buffer; instead, report string overflow.
2544
9d1df220
PE
2545 * dispnew.c (add_window_display_history): Don't overrun buffer.
2546 Truncate instead; this is OK since it's just a log.
2547
33ef5c64
PE
2548 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2549 even if the time zone offset is outlandishly large.
2550 Don't mishandle offset == INT_MIN.
2551
66c6fdd5
PE
2552 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2553 when creating daemon; the previous buffer-overflow check was incorrect.
2554
d749b01b
PE
2555 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2556 which has the guts of the old verror function.
2557
b5cd1905
PE
2558 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2559 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2560
6e1a67fb
PE
2561 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2562 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2563 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2564 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2565 length of string rather than counting it via multiple sprintfs;
2566 that's simpler and more reliable.
c21721cc
PE
2567 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2568 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2569 sprintf, in case result does not fit in int.
2570
c57b67fc
PE
2571 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2572 (fontset_from_font): Print it.
2573
8a401434
PE
2574 * frame.c (tty_frame_count): Now printmax_t, not int.
2575 (make_terminal_frame, set_term_frame_name): Print it.
2576 (x_report_frame_params): In X, window IDs are unsigned long,
2577 not signed long, so print them as unsigned.
2578 (validate_x_resource_name): Check for implausibly long names,
2579 and don't assume name length fits in 'int'.
2580 (x_get_resource_string): Don't blindly alloca invocation name;
2581 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2582 not fit in int.
2583
6e1a67fb
PE
2584 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2585 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2586 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2587
0df02bf3
PE
2588 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2589 Use esprintf, not sprintf, in case result does not fit in int.
2590
48e30793
PE
2591 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2592 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2593 it as a large positive number.
2594 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2595 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2596
a66ff6d8
PE
2597 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2598 in case result does not fit in int.
2599
aca216ff
PE
2600 * print.c (float_to_string): Detect width overflow more reliably.
2601 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2602 buffer overrun. Don't assume list length fits in 'int'. Treat
2603 print length of 0 as 0, not as infinity; to be consistent with other
2604 uses of print length in this function. Don't overflow print length
2605 index. Don't assume hash table size fits in 'long', or that
2606 vectorlike size fits in 'unsigned long'.
2607
31c286f7
PE
2608 * process.c (make_process): Use printmax_t, not int, to format
2609 process-name gensyms.
2610
55e5faa1
PE
2611 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2612
80f2e268
PE
2613 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2614 to avoid potential buffer overrun.
2615
670741ab
PE
2616 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2617 if X resource line is longer than 512 bytes.
2618
b7163a50
PE
2619 * xfns.c (x_window): Make sprintf buffer a bit bigger
2620 to avoid potential buffer overrun.
2621
ae58ff1f
PE
2622 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2623
c43c8a6a
PE
2624 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2625
3f8236f4
PE
26262011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2627
53e9fe90 2628 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2629 Without these, Emacs silently mishandles large integers sometimes.
2630 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2631 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2632
6511acf2
PE
2633 * xdisp.c (try_window_id): Check Emacs fixnum range before
2634 converting to 'int'.
806add1d 2635
6511acf2 2636 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2637 Check that an Emacs fixnum is in range before assigning it to 'int'.
2638 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2639 values converted from Emacs fixnums.
2640 (Frecenter): Don't wrap around a line count if it is out of 'int'
2641 range; instead, treat it as an extreme value.
2642 (Fset_window_configuration, compare_window_configurations):
2643 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2644
6511acf2
PE
2645 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2646 that can exceed INT_MAX. Check that EMACS_INT value is in range
2647 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2648 (match_limit): Don't assume that a fixnum can fit in 'int'.
2649
6511acf2 2650 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2651 exceed INT_MAX.
2652
6511acf2 2653 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2654 (Fvertical_motion): Don't wrap around LINES values that don't fit
2655 in 'int'. Instead, treat them as extreme values. This is good
2656 enough for windows, which can't have more than INT_MAX lines anyway.
2657
fcb901a7
LMI
26582011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2659
0f2f6b6d
LMI
2660 * Require libxml/parser.h to avoid compilation warning.
2661
fcb901a7
LMI
2662 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2663
2664 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2665 since this reportedly can destroy thread storage.
2666
6e20a0d4
CY
26672011-08-30 Chong Yidong <cyd@stupidchicken.com>
2668
2669 * syntax.c (find_defun_start): Update all cache variables if
2670 exiting early (Bug#9401).
2671
148ae00e
EZ
26722011-08-30 Eli Zaretskii <eliz@gnu.org>
2673
f6cfbd8f
EZ
2674 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2675
148ae00e
EZ
2676 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2677 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2678 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2679
2680 * term.c (tty_append_glyph): New function.
2681 (produce_stretch_glyph): Static function and its prototype deleted.
2682
a66cfb1c
SM
2683 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2684 Add prototypes.
148ae00e 2685
c4a07a4c
PE
26862011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2689 when checking :margin (Bug#9390).
2690 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2691 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2692 so that the name doesn't mislead. All uses changed.
2693
6bc8cd65
JB
26942011-08-28 Johan Bockgård <bojohan@gnu.org>
2695
2696 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2697 set_tty_hooks.
2698
dca4927e
EZ
26992011-08-27 Eli Zaretskii <eliz@gnu.org>
2700
2701 * xdisp.c (move_it_to): Don't bail out early when reaching
2702 position beyond to_charpos, if we are scanning backwards.
2703 (move_it_vertically_backward): When DY == 0, make sure we get to
2704 the first character in the line after the newline.
2705
f2cad773
PE
27062011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2707
2708 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2709 (ccl_driver): Do not generate an out-of-range pointer.
2710 (Fccl_execute_on_string): Remove unnecessary check for
2711 integer overflow, noted by Stefan Monnier in
2712 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2713 Remove a FIXME that didn't need fixing.
2714 Simplify the newly-introduced buffer reallocation code.
2715
0cae2cdb
JB
27162011-08-27 Juanma Barranquero <lekktu@gmail.com>
2717
2718 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2719
5fc295a4 27202011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2721
70c60eb2 2722 Integer and memory overflow issues (Bug#9196).
726e0ab1 2723
d31850da
PE
2724 * doc.c (get_doc_string): Rework so that
2725 get_doc_string_buffer_size is the actual buffer size, rather than
2726 being 1 less than the actual buffer size; this makes xpalloc more
2727 convenient.
2728
a69fbedb
PE
2729 * image.c (x_allocate_bitmap_record, cache_image):
2730 * xselect.c (Fx_register_dnd_atom):
2731 Simplify previous changes by using xpalloc.
2732
fe5c5d37
PE
2733 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2734 since either will do and ptrdiff_t is convenient with xpalloc.
2735
0065d054
PE
2736 * charset.c (charset_table_size)
2737 (struct charset_sort_data.priority): Now ptrdiff_t.
2738 (charset_compare): Don't overflow if priorities differ greatly.
2739 (Fsort_charsets): Don't assume list length fits in int.
2740 Check for size-calculation overflow when allocating sort data.
2741 (syms_of_charset): Allocate an initial charset table that is
2742 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2743
2744 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2745
2746 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2747 The actual value is always <= INT_MAX, and leaving it unsigned made
2748 overflow checking harder.
2749
2750 * dispextern.h (struct glyph_matrix.rows_allocated)
2751 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2752 with xpalloc. The values are still always <= INT_MAX.
2753
2754 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2755
2756 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2757 (SAFE_NALLOCA): New macro.
2758
2759 * region-cache.c (struct boundary.pos, find_cache_boundary)
2760 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2761 (set_cache_region, invalidate_region_cache)
2762 (revalidate_region_cache, know_region_cache, region_cache_forward)
2763 (region_cache_backward, pp_cache):
2764 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2765 so that ptrdiff_t * can be passed to xpalloc.
2766 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2767 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2768 (pp_cache): Don't assume cache_len fits in int.
2769 * region-cache.h: Adjust extern decls to match.
2770
2771 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2772 EMACS_INT, since either will do, for xpalloc.
2773
2774 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2775 (xnmalloc, xnrealloc, xpalloc): New functions.
2776
726e0ab1
PE
2777 * bidi.c (bidi_shelve_header_size): New constant.
2778 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2779 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2780
51f30bc5 2781 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2782 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2783 (overlay_strings):
2784 Don't update size of array until after memory allocation succeeds,
2785 because xmalloc/xrealloc may not return.
0065d054
PE
2786 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2787 now that we have proper integer overflow checking.
2788 (record_overlay_string, overlay_strings): Catch overflows when
2789 calculating size of overlay_str_buf.
726e0ab1 2790
0065d054
PE
2791 * callproc.c (Fcall_process): Check for size overflow when
2792 calculating size of args2.
2793 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2794 Normally we prefer signed values, but sticking with ptrdiff_t would
2795 require adding more-complicated checks.
726e0ab1
PE
2796
2797 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2798 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2799 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2800 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2801
2802 * character.c (Fstring): Check for size-calculation overflow.
2803
2804 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2805 unnecessary integer overflow. Check for size overflow.
2806 (encode_coding_object): Don't update size until xmalloc succeeds.
2807
2808 * composite.c (get_composition_id): Check for overflow in glyph
2809 length calculations.
2810
2811 Integer and memory overflow fixes for display code.
2812 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2813 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2814 (scrolling_window): Check for overflow in size calculations.
2815 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2816 Don't assume glyph table len fits in int.
2817 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2818 (row_table_size): Now ptrdiff_t, not int.
2819 (scrolling_window): Avoid overflow in size calculations.
2820 Don't update size until allocation succeeds.
2821 * fns.c (concat): Check for overflow in size calculations.
2822 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2823 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2824 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2825
2826 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2827 (get_doc_string): Check for size calculation overflow.
2828 Don't update size until allocation succeeds.
2829 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2830 EMACS_INT, where ptrdiff_t will do.
2831 (Fsubstitute_command_keys): Check for string overflow.
2832
2833 * editfns.c (set_time_zone_rule): Don't assume environment length
2834 fits in int.
2835 (message_length): Now ptrdiff_t, not int.
2836 (Fmessage_box): Don't update size until allocation succeeds.
2837 Don't assume message length fits in int.
2838 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2839
0065d054
PE
2840 * emacs.c (main): Do not reallocate argv, since there is a null at
2841 the end that can be overwritten, and this way there's no need to
2842 worry about size-calculation overflow.
2843 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2844
2845 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2846 alloc succeeds.
2847 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2848
2849 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2850 (x_set_scroll_bar_width, x_figure_window_size):
2851 Check for integer overflow.
2852 (x_set_alpha): Do not assume XINT fits in int.
2853
2854 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2855 This is for the members text_lines, text_cols, total_lines, total_cols,
2856 where the system imposes an 'int' limit.
2857
2858 * fringe.c (Fdefine_fringe_bitmap):
2859 Don't update size until alloc works.
2860
2861 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2862 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2863
2864 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2865 Check for size-calculation overflow.
2866 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2867 do, as we prefer signed integers.
2868 (id_to_widget.max_size, id_to_widget.used)
2869 (xg_store_widget_in_map, xg_remove_widget_from_map)
2870 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2871 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2872 Use and return ptrdiff_t, not int.
2873 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2874 * gtkutil.h: Change prototypes to match the above.
2875
2876 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2877 are duplicate now that they've been promoted to lisp.h.
2878 (x_allocate_bitmap_record, x_alloc_image_color)
2879 (make_image_cache, cache_image, xpm_load):
2880 Don't update size until alloc is done.
2881 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2882 (x_detect_edges):
3256efce 2883 Check for size calculation overflow.
726e0ab1
PE
2884 (ct_colors_allocated_max): New constant.
2885 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2886 overflow.
3256efce 2887
726e0ab1
PE
2888 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2889 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2890 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2891 Use ptrdiff_t, not int, to count maps.
2892 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2893 calculations. Don't update size until allocation succeeds.
2894 Redo calculations to avoid overflow.
726e0ab1
PE
2895 * keyboard.h: Change prototypes to match the above.
2896
2897 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2898 to count maps.
2899 (current_minor_maps): Check for size calculation overflow.
2900 * keymap.h: Change prototypes to match the above.
2901
2902 * lread.c (read1, init_obarray): Don't update size until alloc done.
2903
2904 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2905 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2906
726e0ab1
PE
2907 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2908 Now ptrdiff_t, not int.
2909 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2910 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2911
2912 * process.c (Fnetwork_interface_list): Check for overflow
2913 in size calculation.
2914
2915 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2916
2917 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2918 overflow. Don't bother calling xmalloc when xrealloc will do.
2919
2920 * search.c (Freplace_match): Check for size calculation overflow.
2921 (Fset_match_data): Don't assume list lengths fit in 'int'.
2922
2923 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2924 for command line length. Do not attempt to address one before the
2925 beginning of an array, as that's not portable.
2926
2927 * term.c (max_frame_lines): Remove; unused.
2928 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2929 not int.
2930 (encode_terminal_code, calculate_costs): Check for size
2931 calculation overflow.
2932 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2933 table lengths and related sizes. Don't update size until alloc
2934 done. Redo calculations to avoid overflow.
2935 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2936
2937 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2938 subtracting pointers.
2939 (gobble_line): Check for overflow more carefully. Don't update size
2940 until alloc done.
2941
2942 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2943 Don't update size until alloc done.
2944 Redo size calculations to avoid overflow.
2945 Check for size calculation overflow.
0065d054 2946 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2947
2948 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2949 Use ptrdiff_t, not int, for sizes.
2950 (store_mode_line_noprop_char): Don't update size until alloc done.
2951
0065d054
PE
2952 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2953 Use ptrdiff_t, not int, for sizes.
2954 (Finternal_make_lisp_face, cache_face):
2955 Check for size calculation overflow.
2956 (cache_face): Treat size calculation overflows as if they were
2957 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2958
2959 * xfns.c (x_encode_text, x_set_name_internal)
2960 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2961 sizes, since they can exceed INT_MAX in size. Check for size
2962 calculation overflow.
2963
0065d054
PE
2964 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2965 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2966 Don't update size until alloc done.
2967
0065d054 2968 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2969 as sprintf is limited to int lengths.
1d526e2f 2970
252c5ee1
PE
2971 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2972 (X_LONG_MIN): New macros.
864d7ce7
PE
2973 Use them to make the following changes clearer.
2974 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2975 This change doesn't affect the value now, but it may help remind
2976 future maintainers not to raise the value too much later.
2977 (SELECTION_QUANTUM): Remove, replacing with ...
2978 (selection_quantum): ... new function, which avoids overflow.
2979 All uses changed.
2980 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2981 assumption that selection length fits in 'int'.
2982 (x_reply_selection_request, x_handle_selection_request)
2983 (x_get_window_property, receive_incremental_selection)
2984 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2985 (lisp_data_to_selection_data, clean_local_selection_data):
2986 Use ptrdiff_t, not int, to record length of selection.
2987 (x_reply_selection_request, x_get_window_property)
2988 (receive_incremental_selection, x_property_data_to_lisp):
2989 Redo calculations to avoid overflow.
2990 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2991 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2992 something.
2993 (x_get_window_property, receive_incremental_selection)
2994 (lisp_data_to_selection_data, x_property_data_to_lisp):
2995 Check for size-calculation overflow.
2996 (x_get_window_property, receive_incremental_selection)
2997 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2998 Don't store size until memory allocation succeeds.
2999 (x_get_window_property): Plug memory leak on memory exhaustion.
3000 Don't double-block input; malloc is safe here. Don't assume 2**34
3001 - 4 fits in unsigned long. Add an xassert to check
3002 XGetWindowProperty overflow. Be more careful about overflow
3003 calculations, and distinguish size from memory overflow better.
3004 (receive_incremental_selection): When tracing, don't assume
3005 unsigned int is less than INT_MAX.
3006 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3007 harmful) conversions of unsigned short to int.
3008 (lisp_data_to_selection_data): Don't assume that integers
3009 in the range -65535 through -1 fit in an X unsigned short.
3010 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3011 result parameters unless successful. Rely on cons_to_unsigned
3012 to report problems with elements; the old code wasn't right anyway.
3013 (x_check_property_data): Check for int overflow; we cannot use
3014 a wider type due to X limits.
3015 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3016
726e0ab1 3017 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3018
0065d054
PE
3019 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3020 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3021 (x_color_cells): Don't store size until memory allocation succeeds.
3022 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3023 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3024 (x_term_init): Don't assume length fits in int (sprintf is limited
3025 to int size).
bc18e09d 3026
ebfa62c0
PE
3027 Use ptrdiff_t for composition IDs.
3028 * character.c (lisp_string_width):
3029 * composite.c (composition_table_size, n_compositions)
3030 (get_composition_id, composition_gstring_from_id):
3031 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3032 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3033 * window.c (Frecenter):
3034 Use ptrdiff_t, not int, for composition IDs.
3035 * composite.c (get_composition_id): Check for integer overflow.
3036 * composite.h: Adjust prototypes to match the above changes.
3037
d3411f89
PE
3038 Use ptrdiff_t for hash table indexes.
3039 * category.c (hash_get_category_set):
3040 * ccl.c (ccl_driver):
3041 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3042 * coding.c (coding_system_charset_list, detect_coding_system):
3043 * coding.h (struct coding_system.id):
3044 * composite.c (get_composition_id, gstring_lookup_cache):
3045 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3046 * image.c (xpm_get_color_table_h):
3047 * lisp.h (hash_lookup, hash_put):
3048 * minibuf.c (Ftest_completion):
3049 Use ptrdiff_t for hash table indexes, not int (which is too
3050 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3051 32-bit --with-wide-int hosts).
3052
e097a6fa
PE
3053 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3054 Add a FIXME comment about memory leaks.
3055 (syms_of_charset): Don't assume xmalloc returns.
3056
5637687f
PE
3057 Don't assume that stated character widths fit in int.
3058 * character.c (Fchar_width, c_string_width, lisp_string_width):
3059 * character.h (CHAR_WIDTH):
3060 * indent.c (MULTIBYTE_BYTES_WIDTH):
3061 Use sanitize_char_width to avoid undefined and/or bad behavior
3062 with outlandish widths.
a66cfb1c 3063 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3064 now that we have two such functions. All uses changed.
3065 (sanitize_char_width): New inline function.
3066
a2271ba2
PE
3067 Don't assume that tab-width fits in int.
3068 * character.h (sanitize_width): New inline function.
3069 (SANE_TAB_WIDTH): New macro.
3070 (ASCII_CHAR_WIDTH): Use it.
3071 * indent.c (sane_tab_width): Remove. All uses replaced by
3072 SANE_TAB_WIDTH (current_buffer).
3073 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3074
18c52557
PE
3075 * fileio.c: Integer overflow issues with file modes.
3076 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3077
caeeedc1
PE
3078 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3079 Remove unreachable code.
3080 (read_hex, load_charset_map_from_file): Check for integer overflow.
3081
6df6ae42 3082 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3083 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3084 (x_send_scroll_bar_event): Likewise. Check that the size does not
3085 exceed limits imposed by XClientMessageEvent, as well as the usual
3086 ptrdiff_t and size_t limits.
3087
b13995db
PE
3088 * keyboard.c: Overflow, signedness and related fixes.
3089 (make_lispy_movement): Use same integer type in forward decl
3090 that is used in the definition.
3091 (read_key_sequence, keyremap_step):
3092 Change bufsize argument back to int, undoing my 2011-03-30 change.
3093 We prefer signed types, and int is wide enough here.
3094 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3095 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3096 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3097 length, not size_t. Use ptrdiff_t for index, not int.
3098 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3099 possibility of integer overflow.
3100
13464394
PE
3101 Overflow, signedness and related fixes for images.
3102
3103 * dispextern.h (struct it.stack[0].u.image.image_id)
3104 (struct_it.image_id, struct image.id, struct image_cache.size)
3105 (struct image_cache.used, struct image_cache.ref_count):
3106 * gtkutil.c (update_frame_tool_bar):
3107 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3108 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3109 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3110 * nsmenu.m (update_frame_tool_bar):
3111 * xdisp.c (calc_pixel_width_or_height):
3112 * xfns.c (image_cache_refcount):
3113 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3114 on typical 64-bit hosts.
3115
3116 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3117 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3118 Omit unnecessary casts to int.
3119 (parse_image_spec): Check that integers fall into 'int' range
3120 when the callers expect that.
3121 (image_ascent): Redo ascent calculation to avoid int overflow.
3122 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3123 (lookup_image): Remove unnecessary tests.
3124 (xbm_image_p): Locals are now of int, not EMACS_INT,
3125 since parse_image_check makes sure they fit into int.
3126 (png_load, gif_load, svg_load_image):
3127 Prefer int to unsigned where either will do.
3128 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3129 old tiff_error_handler and tiff_warning_handler.
3130 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3131 stack buffer overflows. It uses only the features of vsnprintf
3132 that are common to both POSIX and native Microsoft.
3133 (tiff_error_handler, tiff_warning_handler): Use it.
3134 (tiff_load, gif_load, imagemagick_load_image):
3135 Don't assume :index value fits in 'int'.
3136 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3137 (imagemagick_load_image): Check that crop parameters fit into
3138 the integer types that MagickCropImage accepts. Don't assume
3139 Vimagemagick_render_type has a nonnegative value. Don't assume
3140 size_t fits in 'long'.
3141 (gs_load): Use printmax_t to print the widest integers possible.
3142 Check for integer overflow when computing image height and width.
3143
c11821d4
EZ
31442011-08-26 Eli Zaretskii <eliz@gnu.org>
3145
3146 * xdisp.c (redisplay_window): Don't force window start if point
3147 will be invisible in the resulting window. (Bug#9324)
3148
0c95fcf7
EZ
31492011-08-25 Eli Zaretskii <eliz@gnu.org>
3150
3151 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3152 the display spec is of the form `(space ...)'.
3153 (handle_display_spec): Return the value returned by
3154 handle_single_display_spec, not just 1 or zero.
3155 (handle_single_display_spec): If the display spec is of the form
3156 `(space ...)', and specifies display in the text area, return 2
3157 rather than 1.
fee65a97 3158 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3159 accurately, and prefer exact match for point under bidi.
3160 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3161
3162 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3163 into disp_prop; all users changed.
3164
3165 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3166 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3167 for the text covered by the display property.
3168
e4ed06f1
CY
31692011-08-25 Chong Yidong <cyd@stupidchicken.com>
3170
3171 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3172 Change return value to nil.
3173 (Frecord_buffer): Delete unused function.
3174
f67cdd7f
EZ
31752011-08-24 Eli Zaretskii <eliz@gnu.org>
3176
5980d4c6
EZ
3177 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3178 buffers, return left-to-right.
8610fe8b
EZ
3179 (set_cursor_from_row): Consider candidate row a win if its glyph
3180 represents a newline and point is on that newline. Fixes cursor
3181 positioning on the newline at EOL of R2L text within L2R
3182 paragraph, and vice versa.
3183 (try_cursor_movement): Check continued rows, in addition to
3184 continuation rows. Fixes unwarranted scroll when point enters a
3185 continued line of R2L text within an L2R paragraph, or vice versa.
3186 (cursor_row_p): Consider the case of point being equal to
3187 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3188 from the end of a short line to the beginning of a continued line
3189 of R2L text within L2R paragraph.
3190 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3191 composed characters.
5980d4c6 3192
f67cdd7f
EZ
3193 * bidi.c (bidi_check_type): Use xassert.
3194 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3195 members.
3196
bca633fb
EZ
31972011-08-23 Eli Zaretskii <eliz@gnu.org>
3198
3199 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3200 a character.
3201
4a5885a7
CY
32022011-08-23 Chong Yidong <cyd@stupidchicken.com>
3203
3204 * nsfont.m (ns_otf_to_script): Fix typo.
3205
0902a04e
KH
32062011-08-22 Kenichi Handa <handa@m17n.org>
3207
3208 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3209 extra slot even if the purpose is char-code-property-table.
3210
1a2e6670
EZ
32112011-08-23 Eli Zaretskii <eliz@gnu.org>
3212
8ddde651
EZ
3213 * xdisp.c (redisplay_window): When computing centering_position,
3214 account for the height of the header line. (Bug#8874)
3215
425cc014
EZ
3216 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3217 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3218 candidate is selected by the mouse, and that candidate has a
3219 composed character under the mouse.
3220
1a2e6670
EZ
3221 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3222 coordinates reported by pos-visible-in-window-p for a composed
3223 character in column zero.
3224
8b76d6f8
SM
32252011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3226
3227 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3228
dac347dd
EZ
32292011-08-22 Eli Zaretskii <eliz@gnu.org>
3230
3231 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3232 consider it a hit if to_charpos is anywhere in the range of the
3233 composed buffer positions.
3234
e013fb34
CY
32352011-08-22 Chong Yidong <cyd@stupidchicken.com>
3236
3237 * image.c (gif_load): Don't assume that each subimage has the same
3238 dimensions as the base image. Handle disposal method that is
3239 "undefined" by the gif spec (Bug#9335).
3240
bd1ba3e8
CY
32412011-08-20 Chong Yidong <cyd@stupidchicken.com>
3242
3243 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3244 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3245
54a1215b
EZ
32462011-08-19 Eli Zaretskii <eliz@gnu.org>
3247
823564e5
EZ
3248 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3249 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3250 from an Org mode buffer to a Speedbar frame.
3251
54a1215b
EZ
3252 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3253 a composition, take its buffer position from IT->cmp_it.charpos.
3254 Fixes cursor positioning at the beginning of a line that begins
3255 with a composed character.
3256
9778ebcc
EZ
32572011-08-18 Eli Zaretskii <eliz@gnu.org>
3258
0be6ee06
EZ
3259 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3260 character bidirectional type, use STRONG_L instead. Fixes crashes
3261 in a buffer produced by `describe-categories'.
3262
9778ebcc
EZ
3263 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3264 members before the level stack, so they would be saved and
3265 restored when copying iterator state. Fixes incorrect reordering
3266 around TABs covered by display properties.
3267
156bffbe
AS
32682011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3269
6b02f655 3270 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3271
72ad093b
CY
32722011-08-17 Chong Yidong <cyd@stupidchicken.com>
3273
3274 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3275 (internal_condition_case_2, internal_condition_case_n):
3276 Remove unnecessary aborts (Bug#9081).
72ad093b 3277
35774242
EZ
32782011-08-17 Eli Zaretskii <eliz@gnu.org>
3279
3280 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3281 has no `load' handler, try opening the file locally. (Bug#9311)
3282
db76dd85
KB
32832011-08-16 Ken Brown <kbrown@cornell.edu>
3284
3285 * gmalloc.c: Expand comment.
3286
b215eee5
EZ
32872011-08-16 Eli Zaretskii <eliz@gnu.org>
3288
3289 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3290 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3291
a4579d33
KB
32922011-08-16 Ken Brown <kbrown@cornell.edu>
3293
3294 Fix memory allocation problems in Cygwin build (Bug#9273).
3295
3296 * unexcw.c ( __malloc_initialized): Declare external variable.
3297 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3298
8b76d6f8
SM
3299 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3300 New variables.
a4579d33
KB
3301 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3302 dumped emacs.
3303 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3304 in the static heap.
3305 [CYGWIN] (special_realloc): New function.
3306 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3307 requests to realloc storage in the static heap.
3308
3ebec551
PE
33092011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3310
3311 * bidi.c (bidi_initialize): Remove unused local.
3312
9fd8be00
EZ
33132011-08-15 Eli Zaretskii <eliz@gnu.org>
3314
6b02f655
SM
3315 * bidimirror.h:
3316 * biditype.h: Remove file.
3317 * makefile.w32-in ($(BLD)/bidi.$(O)):
3318 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3319
3320 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3321
3322 * chartab.c: Improve commentary for the uniprop_table API.
3323
32413314
EZ
3324 * bidi.c (bidi_paragraph_init): Support zero value of
3325 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3326 (bidi_initialize): Use uniprop_table instead of including
3327 biditype.h and bidimirror.h.
32413314 3328
9fd8be00
EZ
3329 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3330 coordinates of the iterator when restoring from ppos_it.
3331 (Bug#9296)
3332
5cf2b69b
KH
33332011-08-14 Kenichi Handa <handa@m17n.org>
3334
3335 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3336 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3337
daf17d00
EZ
33382011-08-14 Eli Zaretskii <eliz@gnu.org>
3339
3340 * xdisp.c (move_it_in_display_line_to): Don't invoke
3341 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3342 ppos_it. Fixes vertical cursor motion when line beginning is
3343 covered by an image. (Bug#9296)
3344
08e3161a
JD
33452011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3346
3347 * nsterm.h (ns_run_ascript): Declare.
3348 (NSAPP_DATA2_RUNASSCRIPT): Define.
3349
3350 * nsfns.m (as_script, as_result, as_status): New static variables.
3351 (ns_run_ascript): New function.
5e617bc2 3352 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3353 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3354 the event loop. Get status from as_status (Bug#7276).
3355
3356 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3357 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3358 the event loop (Bug#7276).
3359
a3720aa2
AS
33602011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3361
3362 * gnutls.c (QCgnutls_bootprop_priority)
3363 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3364 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3365 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3366 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3367 (QCgnutls_bootprop_verify_hostname_error)
3368 (QCgnutls_bootprop_callbacks_verify): Rename from
3369 Qgnutls_bootprop_..., all uses changed.
3370
3371 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3372 uses changed.
3373
0a0d27fb
PE
33742011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3375
19d5c50c
PE
3376 * xfaces.c (Qframe_set_background_mode): Now static.
3377 * dispextern.h (Qframe_set_background_mode): Remove decl.
3378
0a0d27fb
PE
3379 * process.c (Fnetwork_interface_info): Declare local only if needed.
3380
377538cb
JD
33812011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3382
3383 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3384 (Fnetwork_interface_list): Allocate in increments of bytes instead
3385 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3386 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3387 sockaddr.
3388 (struct ifflag_def): notrailers is smart on OSX.
3389 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3390 Get hardware address with getifaddrs if available.
3391
08fff70c
EZ
33922011-08-12 Eli Zaretskii <eliz@gnu.org>
3393
3394 * xdisp.c (iterate_out_of_display_property): xassert that
3395 IT->position is set to within IT->object's boundaries. Break from
3396 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3397 when IT->position is set up wrongly due to some bug.
3398 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3399 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3400 entry. Force push_it to save on the stack the current
3401 buffer/string position, to be restored by pop_it. Fix flags in
3402 the iterator structure wrt the object coming from a display
3403 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3404 properties. (Bug#9284)
3405
7be1c708 34062011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3407
7be1c708
CY
3408 * fontset.c (fontset_get_font_group): Add proper type checks.
3409 (Bug#9172)
aac0c6e3 3410
7be1c708 34112011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3412
7be1c708
CY
3413 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3414 and LC_VERSION_MIN_MACOSX.
3415 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3416 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3417
97bb72a6
EZ
34182011-08-08 Eli Zaretskii <eliz@gnu.org>
3419
3420 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3421 no-display-properties-and-no-overlays under bidi display.
3422 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3423 properties and overlays.
97bb72a6 3424
d5617611
CY
34252011-08-08 Chong Yidong <cyd@stupidchicken.com>
3426
37e11a63
CY
3427 * editfns.c (Fset_time_zone_rule): Document relationship with the
3428 setenv function.
3429
d5617611
CY
3430 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3431 the font entity extracted from the cache (Bug#8109).
3432
58872834
CY
34332011-08-07 Chong Yidong <cyd@stupidchicken.com>
3434
3435 * composite.c (autocmp_chars): Don't reset point. That is done by
3436 restore_point_unwind (Bug#5984).
3437
75bfc667
JL
34382011-08-07 Juri Linkov <juri@jurta.org>
3439
3440 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3441 to show the arg `TIME' instead of `TIMEVAL'.
3442
d1410150
EZ
34432011-08-06 Eli Zaretskii <eliz@gnu.org>
3444
3445 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3446 display property strides EOL and includes a newline, as in
3447 longlines-mode. (Bug#9254)
75b771e4
EZ
3448 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3449 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3450
3451 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3452 is non-zero, even if the data buffer is NULL. Fixes a crash in
3453 vertical-motion with longlines-mode. (Bug#9254)
3454
35928349
EZ
34552011-08-05 Eli Zaretskii <eliz@gnu.org>
3456
ec7cc85b
EZ
3457 * bidi.c <bidi_cache_total_alloc>: Now static.
3458 (bidi_initialize): Initialize bidi_cache_total_alloc.
3459
8b76d6f8 3460 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3461 cache. (Bug#9221)
3462
3463 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3464 amount allocated this far in `bidi_cache_total_alloc'.
3465 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3466 non-zero, only free the data buffer without restoring the cache
3467 contents. All callers changed.
3468
3469 * dispextern.h (bidi_unshelve_cache): Update prototype.
3470
3471 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3472 (move_it_in_display_line, move_it_to)
3473 (move_it_vertically_backward, move_it_by_lines): Replace the call
3474 to xfree to an equivalent call to bidi_unshelve_cache.
3475 (move_it_in_display_line_to): Fix logic of returning
412b6358 3476 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3477
e2e2423b
EZ
34782011-08-05 Eli Zaretskii <eliz@gnu.org>
3479
3480 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3481 came from a string character with a `cursor' property. (Bug#9229)
3482
ae9e757a
JD
34832011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3484
3485 * Makefile.in (LIB_PTHREAD): New variable.
3486 (LIBES): Add LIB_PTHREAD (Bug#9216).
3487
3488 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3489 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3490
213bd7f2
AS
34912011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3492
6b02f655 3493 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3494
99aaf75f
JD
34952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3496
3497 * xterm.c (x_find_topmost_parent): New function.
3498 (x_set_frame_alpha): Find topmost parent window with
3499 x_find_topmost_parent and set the property there also (bug#9181).
3500 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3501
c74e9d86
PE
35022011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 * callproc.c (Fcall_process): Avoid vfork clobbering
3505 the local vars buffer, coding_systems, current_dir.
3506
640c8776
SM
35072011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3508
3509 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3510
f26d0e4c
PE
35112011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3512
8a10d76c
PE
3513 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3514 so that it is not optimized away.
3515
f26d0e4c
PE
3516 * xdisp.c (compute_display_string_pos): Remove unused local.
3517
55439c61
EZ
35182011-08-02 Eli Zaretskii <eliz@gnu.org>
3519
3520 Fix slow cursor motion and scrolling in large buffers with
3521 selective display, like Org Mode buffers. (Bug#9218)
3522
3523 * dispextern.h (struct bidi_it): New member disp_prop_p.
3524
3525 * xdisp.c: Remove one-slot cache of display string positions.
3526 (compute_display_string_pos): Accept an additional argument
5e617bc2 3527 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3528 for a display string or property. If found, set DISP_PROP_P
3529 non-zero.
3530
3531 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3532 DISP_PROP_P, and pass it to compute_display_string_pos.
3533 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3534 non-zero. All callers of bidi_fetch_char changed.
3535
fb33fa43
SM
35362011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3537
3538 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3539
b099e063
DM
35402010-12-03 Don March <don@ohspite.net>
3541
3542 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3543 last character M-[char] is translated to ESC [char] (bug#7541).
3544
5cc7f7af
KH
35452011-08-02 Kenichi Handa <handa@m17n.org>
3546
d0fffa3f 3547 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3548
3549 * chartab.c (uniprop_table): Make it non-static.
3550
525d5e6e
EZ
35512011-08-01 Eli Zaretskii <eliz@gnu.org>
3552
3553 * xdisp.c (forward_to_next_line_start): Accept additional argument
3554 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3555 on the newline.
3556 (reseat_at_next_visible_line_start): Use the bidi iterator state
3557 returned by forward_to_next_line_start to restore the state of
3558 it->bidi_it after backing up to previous newline. (Bug#9212)
3559
31011111
AS
35602011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3561
3562 * regex.c (re_comp): Protoize.
3563 (re_exec): Fix return type.
3564 (regexec): Fix type of `ret'. (Bug#9203)
3565
476371c4
PE
35662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3567
e5d76069
PE
3568 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3569 This is needed if max-image-size is a floating-point number.
3570
9a79b20c
AS
35712011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3572
3573 * print.c (print_object): Print empty symbol as ##.
3574
3575 * lread.c (read1): Read ## as empty symbol.
3576
d8c2fa78
AA
35772011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3578
3579 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3580 setting frame foreground color (Bug#9175).
3581 (x_set_background_color): Likewise.
3582
ffe57a7a
AA
3583 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3584 contents (Bug#9176).
3585 (EmacsTooltip -init): Remove bezels and add shadows to
3586 tooltip windows.
3587
bf3492a5
AA
3588 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3589 or scroll bar (Bug#8470).
3590
d55e9c53
AA
3591 * nsfont.m (nsfont_open): Remove assignment to voffset and
3592 unnecessary vars hshink, expand, hd, full_height, min_height.
3593 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3594
3595 * nsterm.h (nsfont_info): Remove voffset field.
3596
d8c2fa78 35972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3598
3599 Implement strike-through and overline on NextStep (Bug#8863).
3600
3601 * nsfont.m (nsfont_open): Use underline position provided by font,
3602 instead of hard-coded value of 2.
3603 (nsfont_draw): Call ns_draw_text_decoration instead.
3604
3605 * nsterm.h: Add declaration for ns_draw_text_decoration.
3606
3607 * nsterm.m (ns_draw_text_decoration): New function for drawing
3608 underline, overline, and strike-through.
3609 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3610 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3611 accommodate underlining, etc.
4843aac3 3612
4cc60b9b
EZ
36132011-07-28 Eli Zaretskii <eliz@gnu.org>
3614
bc7ece87
EZ
3615 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3616 default.
4cc60b9b 3617
476371c4
PE
36182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3619
66606eea
PE
3620 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3621 Without this fix, if a signal arrives just after memory fills up,
3622 'malloc' might be invoked reentrantly.
3623
476371c4
PE
3624 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3625 In other words, assume that every image size is allowed, on non-X
3626 hosts. This assumption is probably wrong, but it lets Emacs compile.
3627
f3fcc40d
AS
36282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3629
3630 * regex.c (re_iswctype): Convert return values to boolean.
3631
350c992f
EZ
36322011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3633
3634 * xdisp.c (compute_display_string_pos): Don't use cached display
3635 string position if the buffer had its restriction changed.
3636 (Bug#9184)
3637
5266b4bb
PE
36382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3641
2573a837 36422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3643
41f55ccd 3644 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3645
39e378da
PE
3646 * bidi.c: Integer size and overflow fixes.
3647 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3648 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3649 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3650 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3651 (bidi_find_other_level_edge):
3652 Use ptrdiff_t instead of EMACS_INT where either will do.
3653 This works better on 32-bit hosts configured --with-wide-int.
3654 (bidi_cache_ensure_space): Check for size-calculation overflow.
3655 Use % rather than repeated addition, for better worst-case speed.
3656 Don't set bidi_cache_size until after xrealloc returns, because it
3657 might not return.
3658 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3659 (bidi_cache_ensure_space): Also check that the bidi cache size
3660 does not exceed that of the largest Lisp string or buffer. See Eli
3661 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3662
5e927815
PE
3663 * alloc.c (__malloc_size_t): Remove.
3664 All uses replaced by size_t. See Andreas Schwab's note
3665 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3666
ca4aa935
PE
3667 * image.c: Improve checking for integer overflow.
3668 (check_image_size): Assume that f is nonnull, since
3669 it is always nonnull in practice. This is one less thing to
3670 worry about when checking for integer overflow later.
3671 (x_check_image_size): New function, which checks for integer
3672 overflow issues inside X.
3673 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3674 This removes the need for a memory_full check.
3675 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3676 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3677 (xbm_read_bitmap_data): Change locals back to 'int', since
3678 their values must fit in 'int'.
3679 (xpm_load_image, png_load, tiff_load):
3680 Invoke x_create_x_image_and_pixmap earlier,
3681 to avoid much needless work if the image is too large.
3682 (tiff_load): Treat overly large images as if
3683 x_create_x_image_and_pixmap failed, not as malloc failures.
3684 (gs_load): Use x_check_image_size.
3685
5f8f9cc2
PE
3686 * gtkutil.c: Omit integer casts.
3687 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3688 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3689
5adf60bc
PE
3690 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3691
c8907a93
PE
3692 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3693 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3694 would wrongly return t on a 64-bit host.
3695
e3c25c68
PE
3696 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3697 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3698 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3699 and therefore cause GCC to emit a bogus diagnostic in some cases.
3700
3f791afe
PE
3701 * image.c: Integer signedness and overflow and related fixes.
3702 This is not an exhaustive set of fixes, but it's time to
3703 record what I've got.
3704 (lookup_pixel_color, check_image_size): Remove redundant decls.
3705 (check_image_size): Don't assume that arbitrary EMACS_INT values
3706 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3707 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3708 (tiff_load, imagemagick_load_image):
3709 Check for overflow in size calculations.
3710 (x_create_x_image_and_pixmap): Remove unnecessary test for
3711 xmalloc returning NULL; that can't happen.
3712 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3713 (xpm_color_bucket): Use better integer hashing function.
3714 (xpm_cache_color): Don't possibly over-allocate memory.
3715 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3716 (gif_memory_source):
3717 Use ptrdiff_t, not int or size_t, to record sizes.
3718 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3719 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3720 either works, as we prefer signed integers.
3721 (tiff_read_from_memory, tiff_write_from_memory):
3722 Return tsize_t, not size_t, since that's what the TIFF API wants.
3723 (tiff_read_from_memory): Don't fail simply because the read would
3724 go past EOF; instead, return a short read.
3725 (tiff_load): Omit no-longer-needed casts.
3726 (Fimagemagick_types): Don't assume size fits into 'int'.
3727
3cc5a532
PE
3728 Improve hashing quality when configured --with-wide-int.
3729 * fns.c (hash_string): New function, taken from sxhash_string.
3730 Do not discard information about ASCII character case; this
3731 discarding is no longer needed.
3732 (sxhash-string): Use it. Change sig to match it. Caller changed.
3733 * lisp.h: Declare it.
3734 * lread.c (hash_string): Remove, since we now use fns.c's version.
3735 The fns.c version returns a wider integer if --with-wide-int is
3736 specified, so this should help the quality of the hashing a bit.
3737
b312a492
PE
3738 * emacs.c: Integer overflow minor fix.
3739 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3740 Define only if GNU_LINUX.
3741 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3742
dfd153ae
PE
3743 * dispnew.c: Integer signedness and overflow fixes.
3744 Remove unnecessary forward decls, that were a maintenance hassle.
3745 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3746 All uses changed.
3747 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3748 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3749 (prepare_desired_row, line_draw_cost):
3750 Use int, not unsigned, where either works.
3751 (save_current_matrix, restore_current_matrix):
3752 Use ptrdiff_t, not size_t, where either works.
3753 (init_display): Check for overflow more accurately, and without
3754 relying on undefined behavior.
3755
a81d11a3
PE
3756 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3757 Remove, replacing with the new symbols in lisp.h. All uses changed.
3758 * fileio.c (make_temp_name):
3759 * filelock.c (lock_file_1, lock_file):
3760 * xdisp.c (message_dolog):
3761 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3762 Use pMd etc. instead.
3763 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3764 replacing the pWIDE etc. symbols removed from editfns.c.
3765
3300e6fd
PE
3766 * keyboard.h (num_input_events): Now uintmax_t.
3767 This is (very slightly) less likely to mess up due to wraparound.
3768 All uses changed.
3769
fd05c7e9
PE
3770 * buffer.c: Integer signedness fixes.
3771 (alloc_buffer_text, enlarge_buffer_text):
3772 Use ptrdiff_t rather than size_t when either will do, as we prefer
3773 signed integers.
3774
903fe15d
PE
3775 * alloc.c: Integer signedness and overflow fixes.
3776 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3777 (__malloc_size_t): Default to size_t, not to int.
3778 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3779 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3780 Prefer ptrdiff_t to size_t when either would do, as we prefer
3781 signed integers.
3782 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3783 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3784 Now const. Initialize with values that are in range even if char
3785 is signed.
3786 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3787 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3788 These functions do the right thing with sizes > 2**32.
3789 (check_depth): Now ptrdiff_t, not int.
3790 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3791 Adjust to new way of storing sizes. Check for size overflow bugs
3792 in rest of code.
3793 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3794 slightly wrong anyway, as it missed one instance of
3795 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3796 (refill_memory_reserve): Omit needless cast to size_t.
3797 (mark_object_loop_halt): Mark as externally visible.
3798
ac82cc6a
PE
3799 * xselect.c: Integer signedness and overflow fixes.
3800 (Fx_register_dnd_atom, x_handle_dnd_message):
3801 Use ptrdiff_t, not size_t, since we prefer signed.
3802 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3803 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3804 x_dnd_atoms_size and x_dnd_atoms_length.
3805
c2d1e36d
PE
3806 * doprnt.c: Prefer signed to unsigned when either works.
3807 * eval.c (verror):
3808 * doprnt.c (doprnt):
3809 * lisp.h (doprnt):
3810 * xdisp.c (vmessage):
3811 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3812 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3813 prefer signed arithmetic to avoid comparison confusion.
3814 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3815 but is a bit tricky.
3816
0e926e56
PE
3817 Assume freestanding C89 headers, string.h, stdlib.h.
3818 * data.c, doprnt.c, floatfns.c, print.c:
3819 Include float.h unconditionally.
3820 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3821 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3822 * regex.c: Likewise for stddef.h, string.h.
3823 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3824 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3825 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3826 (STDC_HEADERS): Remove obsolete defines.
3827 * sysdep.c: Include limits.h unconditionally.
3828
9cfdb3ec
PE
3829 Assume support for memcmp, memcpy, memmove, memset.
3830 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3831 * regex.c (memcmp, memcpy):
3832 Remove; we assume C89 now.
3833
3834 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3835 (__malloc_safe_bcopy): Remove; no longer needed.
3836
cf950e6b 3837 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3838 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3839 well either way, and we prefer signed to unsigned.
3840
dbf38e02
LMI
38412011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3842
3843 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3844 closes the connection while we're reading (bug#9182).
3845
d6f0886c 38462011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3847
d6f0886c
JD
3848 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3849 are specified (Bug#9168).
24e0f6b1 3850
2eb1f9e6
PE
38512011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3854 Found by GCC static checking and --with-wide-int on a 32-bit host.
3855
22381272 38562011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3857
3858 * xdisp.c (compute_display_string_pos): Fix logic of caching
3859 previous display string position. Initialize cached_prev_pos to
3860 -1. Fixes slow-down at the beginning of a buffer.
3861
f25e39b4
EZ
38622011-07-24 Eli Zaretskii <eliz@gnu.org>
3863
3864 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3865 for attrs[LFACE_FONTSET_INDEX].
3866
04c4b52e
PE
38672011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 * xml.c (parse_region): Remove unused local
3870 that was recently introduced.
3871
c1734fbd
EZ
38722011-07-23 Eli Zaretskii <eliz@gnu.org>
3873
be18c5a5
EZ
3874 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3875 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3876
c1734fbd
EZ
3877 * xdisp.c (move_it_in_display_line_to): Record the best matching
3878 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3879 exit if none of the characters scanned was an exact match.
3880 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3881 when exact match is impossible due to invisible text, and the
3882 lines are truncated.
3883
a258d627
JD
38842011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3885
3886 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3887 for OSX >= 10.7.
3888
b6d5a689
EZ
38892011-07-22 Eli Zaretskii <eliz@gnu.org>
3890
0f74f785
EZ
3891 Fix a significant slow-down of cursor motion with C-n, C-p,
3892 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3893 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3894 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3895 (next_element_from_buffer): Call compute_stop_pos_backwards to
3896 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3897 base_level_stop.
3898 (reseat): Don't look for prev_stop, as that could mean a very long
3899 run.
3900 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3901 <cached_disp_overlay_modiff>: Cache for last found display string
3902 position.
551918c1 3903 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3904 about the same buffer in the same area of character positions, and
3905 the buffer wasn't changed since the time the display string
3906 position was cached.
551918c1 3907
b2d0c91a
EZ
39082011-07-22 Eli Zaretskii <eliz@gnu.org>
3909
3910 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3911 is an integer, which is important for empty lines. (Bug#9149)
3912
043604ee
CY
39132011-07-22 Chong Yidong <cyd@stupidchicken.com>
3914
3915 * frame.c (Fmodify_frame_parameters): In tty case, update the
3916 default face if necessary (Bug#4238).
3917
da4adb04
CY
39182011-07-21 Chong Yidong <cyd@stupidchicken.com>
3919
3920 * editfns.c (Fstring_to_char): No need to explain what a character
3921 is in the docstring (Bug#6576).
3922
9abd0532
LMI
39232011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3924
3925 * xml.c (parse_region): Make sure we always return a tree.
3926
36881d16
HK
39272011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3928
3929 * xml.c (parse_region): If a document contains only comments,
3930 return that, too.
3931
1e98674d
LMI
39322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3933
3934 * xml.c (make_dom): Return comments, too.
3935
590bd467
PE
39362011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 Port to OpenBSD.
3939 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3940 and the surrounding thread.
3941 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3942 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3943 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3944 timer goes off.
3945 * s/openbsd.h (BROKEN_SIGIO): Define.
3946 * unexelf.c (unexec) [__OpenBSD__]:
3947 Don't update the .mdebug section of the Alpha COFF symbol table.
3948
f41628b2
LMI
39492011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3950
3951 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3952 (bug#8460).
3953
b59b67c5
PE
39542011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3955
15e3a074
PE
3956 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3957 This fixes some race conditions on the permissions of any newly
3958 created file.
3959
41bed37d
PE
3960 * alloc.c (valid_pointer_p): Use pipe, not open.
3961 This fixes some permissions issues when debugging.
3962
b59b67c5
PE
3963 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3964 If fchown fails to set both uid and gid, try to set just gid,
3965 as that is sometimes allowed. Adjust the file's mode to eliminate
3966 setuid or setgid bits that are inappropriate if fchown fails.
3967
925a6be7
SM
39682011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3969
3970 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3971 to compare Lisp_Objects.
3972 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3973 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3974 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3975
52968808
AS
39762011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3977
0a6a104b
AS
3978 * lread.c (read_integer): Unread even EOF character.
3979 (read1): Likewise. Properly record start position of symbol.
3980
52968808
AS
3981 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3982 symbol character follows.
3983
9e381cdd
PE
39842011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3985
3986 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3987 This works around a problem with the previous change to Fcopy_file.
3988 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3989 and without this change, GCC might complain about discarding
3990 fchown's return value.
3991
b5641435
JB
39922011-07-16 Juanma Barranquero <lekktu@gmail.com>
3993
3994 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3995
a8031457
PE
39962011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3999
dd889327
LMI
40002011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4001
750c33f7
LMI
4002 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4003 it's used from the C level.
4004
dd889327
LMI
4005 * process.c: Use the same condition for POLL_FOR_INPUT in both
4006 keyboard.c and process.c (bug#1858).
4007
87e86684
LM
40082011-07-09 Lawrence Mitchell <wence@gmx.li>
4009
4010 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4011 (Fgnutls_boot): Use it.
4012
64348f40
AS
40132011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4014
4015 * doc.c (Fsubstitute_command_keys): Revert last change.
4016
1d698799
LMI
40172011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4018
f863868c
LMI
4019 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4020 quotes the next character, and doesn't affect other longer
4021 sequences (bug#8935).
4022
1d698799
LMI
4023 * lread.c (syms_of_lread): Clarify that is isn't only
4024 `eval-buffer' and `eval-defun' that's affected by
4025 `lexical-binding' (bug#8460).
4026
aa4b6df6
EZ
40272011-07-15 Eli Zaretskii <eliz@gnu.org>
4028
4029 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4030 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4031
5d856da6
PE
40322011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4033
ad6042bb
PE
4034 Fix minor problems found by static checking.
4035 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4036 (elsz): Now a signed constant, not a size_t var. We prefer signed
4037 types to unsigned, to avoid integer comparison confusion. Without
4038 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4039 "cannot optimize loop, the loop counter may overflow", a symptom
4040 of the confusion.
f00bbb22 4041 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4042 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4043
6468f31c
LMI
40442011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4045
49080b10
LMI
4046 * search.c (Fre_search_backward): Mention `case-fold-search' in
4047 all the re_search_* functions (bug#8138).
4048
6468f31c
LMI
4049 * keyboard.c (Fopen_dribble_file): Document when the file is
4050 closed (bug#8056).
4051
c965adc5
EZ
40522011-07-14 Eli Zaretskii <eliz@gnu.org>
4053
df9733bf
EZ
4054 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4055 bidi_cache_idx.
4056
0bb23927
EZ
4057 Support bidi reordering of display and overlay strings.
4058 * xdisp.c (compute_display_string_pos)
4059 (compute_display_string_end): Accept additional argument STRING.
4060 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4061 (reseat_to_string): Initialize bidi_it->string.s and
4062 bidi_it->string.schars.
4063 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4064 NULL (avoids a crash in bidi_paragraph_init).
4065 Initialize itb.string.lstring.
0bb23927
EZ
4066 (init_iterator): Call bidi_init_it only of a valid
4067 buffer position was specified. Initialize paragraph_embedding to
4068 L2R.
4069 (reseat_to_string): Initialize the bidi iterator.
4070 (display_string): If we need to ignore text properties of
4071 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4072 original value of -1 will not work with bidi.)
4073 (compute_display_string_pos): First arg is now struct
4074 `text_pos *'; all callers changed. Support display properties on
4075 Lisp strings.
4076 (compute_display_string_end): Support display properties on Lisp
4077 strings.
4078 (init_iterator, reseat_1, reseat_to_string): Initialize the
4079 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4080 when iterating on a string not from display properties).
640c8776
SM
4081 (compute_display_string_pos, compute_display_string_end):
4082 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4083 arrow keys.
4084 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4085 base_level_stop; instead, set base_level_stop to BEGV.
4086 Fixes crashes in vertical-motion.
0bb23927
EZ
4087 (next_element_from_buffer): Improve commentary for when
4088 the iterator is before prev_stop.
4089 (init_iterator): Initialize bidi_p from the default value of
4090 bidi-display-reordering, not from buffer-local value. Use the
4091 buffer-local value only if initializing for buffer iteration.
4092 (handle_invisible_prop): Support invisible properties on strings
4093 that are being bidi-reordered.
4094 (set_iterator_to_next): Support bidi reordering of C strings and
4095 Lisp strings.
4096 (next_element_from_string): Support bidi reordering of Lisp
4097 strings.
4098 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4099 (display_string): Support display of R2L glyph rows.
4100 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4101 (init_iterator): Don't initialize it->bidi_p for strings
4102 here.
4103 (reseat_to_string): Initialize it->bidi_p for strings here.
4104 (next_element_from_string, next_element_from_c_string)
4105 (next_element_from_buffer): Add xassert's for correspondence
4106 between IT's object being iterated and it->bidi_it.string
4107 structure.
4108 (face_before_or_after_it_pos): Support bidi iteration.
4109 (next_element_from_c_string): Handle the case of the first string
4110 character that is not the first one in the visual order.
4111 (get_visually_first_element): New function, refactored from common
4112 parts of next_element_from_buffer, next_element_from_string, and
4113 next_element_from_c_string.
4114 (tool_bar_lines_needed, redisplay_tool_bar)
4115 (display_menu_bar): Force left-to-right direction. Add a FIXME
4116 comment for making that be controlled by a user option.
4117 (push_it, pop_it): Save and restore the state of the
4118 bidi iterator. Save and restore the bidi_p flag.
4119 (pop_it): Iterate out of display property for string iteration as
4120 well.
4121 (iterate_out_of_display_property): Support iteration over strings.
4122 (handle_single_display_spec): Set up it->bidi_it for iteration
4123 over a display string, and call bidi_init_it.
4124 (handle_single_display_spec, next_overlay_string)
4125 (get_overlay_strings_1, push_display_prop): Set up the bidi
4126 iterator for displaying display or overlay strings.
4127 (forward_to_next_line_start): Don't use the shortcut if
4128 bidi-iterating.
4129 (back_to_previous_visible_line_start): If handle_display_prop
4130 pushed the iterator stack, restore the internal state of the bidi
4131 iterator by calling bidi_pop_it same number of times.
4132 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4133 and we are bidi-iterating, don't decrement the iterator position;
4134 instead, set the first_elt flag in the bidi iterator, to produce
4135 the same effect.
4136 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4137 (push_display_prop): xassert that we are iterating a buffer.
4138 (push_it, pop_it): Save and restore paragraph_embedding member.
4139 (handle_single_display_spec, next_overlay_string)
4140 (get_overlay_strings_1, reseat_1, reseat_to_string)
4141 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4142 correctly. Don't assume unibyte strings are not bidi-reordered.
4143 (compute_display_string_pos)
4144 (compute_display_string_end): Fix handling the case of C string.
4145 (push_it, pop_it): Save and restore from_disp_prop_p.
4146 (handle_single_display_spec, push_display_prop): Set the
4147 from_disp_prop_p flag.
4148 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4149 (pop_it): Call iterate_out_of_display_property only if we are
4150 popping after iteration over a string that came from a display
4151 property. Fix a typo in popping stretch info. Add an assertion
4152 for verifying that the iterator position is in sync with the bidi
4153 iterator.
4154 (handle_single_display_spec, get_overlay_strings_1)
4155 (push_display_prop): Fix initialization of paragraph direction for
4156 string when that of the parent object is not yet determined.
4157 (reseat_1): Call bidi_init_it to resync the bidi
4158 iterator with IT's position. (Bug#7616)
4159 (find_row_edges): If ROW->start.pos gives position
4160 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4161 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4162 Reset the from_disp_prop_p flag.
4163 (SAVE_IT, RESTORE_IT): New macros.
4164 (pos_visible_p, face_before_or_after_it_pos)
4165 (back_to_previous_visible_line_start)
4166 (move_it_in_display_line_to, move_it_in_display_line)
4167 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4168 (try_scrolling, redisplay_window, display_line): Use them when
4169 saving a temporary copy of the iterator and restoring it back.
4170 (back_to_previous_visible_line_start, reseat_1)
4171 (init_iterator): Empty the bidi cache "stack".
4172 (move_it_in_display_line_to): If iterator ended up at
4173 EOL, but we never saw any buffer positions smaller than
4174 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4175 motion in bidi-reordered lines.
4176 (move_it_in_display_line_to): Record prev_method and prev_pos
4177 immediately before the call to set_iterator_to_next. Fixes cursor
4178 motion in bidi-reordered lines with stretch glyphs and strings
4179 displayed in margins. (Bug#8133) (Bug#8867)
4180 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4181 TO_CHARPOS.
640c8776
SM
4182 (pos_visible_p): Support positions in bidi-reordered lines.
4183 Save and restore bidi cache.
0bb23927
EZ
4184
4185 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4186 (bidi_paragraph_info): Delete unused struct.
4187 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4188 (bidi_cache_start): New variable.
4189 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4190 to zero.
4191 (bidi_cache_fetch_state, bidi_cache_search)
4192 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4193 (bidi_cache_find, bidi_peek_at_next_level)
4194 (bidi_level_of_next_char, bidi_find_other_level_edge)
4195 (bidi_move_to_visually_next): Compare cache index with
4196 bidi_cache_start rather than with zero.
4197 (bidi_fetch_char): Accept new argument STRING; all callers
4198 changed. Support iteration over a string. Support strings with
4199 display properties. Support unibyte strings. Fix the type of
4200 `len' according to what STRING_CHAR_AND_LENGTH expects.
4201 (bidi_paragraph_init, bidi_resolve_explicit_1)
4202 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4203 (bidi_level_of_next_char, bidi_move_to_visually_next):
4204 Support iteration over a string.
0bb23927
EZ
4205 (bidi_set_sor_type, bidi_resolve_explicit_1)
4206 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4207 can now be zero (for strings); special values 0 and -1 were
4208 changed to -1 and -2, respectively.
4209 (bidi_char_at_pos): New function.
4210 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4211 Call it instead of FETCH_MULTIBYTE_CHAR.
4212 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4213 initialized to valid values.
4214 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4215 values.
4216 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4217 the test for valid cached positions. Fix the logic for looking up
4218 the sentinel state in the cache. GCPRO the Lisp string we are
4219 iterating.
4220 (bidi_push_it, bidi_pop_it): New functions.
4221 (bidi_initialize): Initialize the bidi cache start stack pointer.
4222 (bidi_cache_ensure_space): New function, refactored from part of
4223 bidi_cache_iterator_state. Don't assume the required size is just
4224 one BIDI_CACHE_CHUNK away.
4225 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4226 (bidi_count_bytes, bidi_char_at_pos): New functions.
4227 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4228 always valid if bidi_cache_idx is valid.
4229 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4230 is valid if it's going to be used.
4231 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4232 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4233 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4234 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4235 (bidi_find_other_level_edge, bidi_cache_start_stack):
4236 All variables related to cache indices are now EMACS_INT.
c965adc5 4237
0bb23927
EZ
4238 * dispextern.h (struct bidi_string_data): New structure.
4239 (struct bidi_it): New member `string'. Make flag members be 1-bit
4240 fields, and put them last in the struct.
640c8776
SM
4241 (compute_display_string_pos, compute_display_string_end):
4242 Update prototypes.
0bb23927
EZ
4243 (bidi_push_it, bidi_pop_it): Add prototypes.
4244 (struct iterator_stack_entry): New members bidi_p,
4245 paragraph_embedding, and from_disp_prop_p.
4246 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4247 (bidi_shelve_cache, bidi_unshelve_cache):
4248 Declare prototypes.
0bb23927
EZ
4249
4250 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4251 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4252 and vector-like objects.
4253
4254 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4255 cache around display iteration.
4256
4257 * window.c (Fwindow_end, window_scroll_pixel_based)
4258 (displayed_window_lines, Frecenter): Save and restore the bidi
4259 cache around display iteration.
4260
3bbd2265
LMI
42612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4262
4263 * editfns.c (Fdelete_region): Clarify the use of the named
4264 parameters (bug#6788).
4265
adc47434
MR
42662011-07-14 Martin Rudalics <rudalics@gmx.at>
4267
4268 * indent.c (Fvertical_motion): Set and restore w->pointm when
4269 saving and restoring the window's buffer (Bug#9006).
4270
837c31f8
LMI
42712011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4272
4273 * editfns.c (Fstring_to_char): Clarify just what is returned
4274 (bug#6576). Text by Eli Zaretskii.
4275
ac389d0c
JB
42762011-07-13 Juanma Barranquero <lekktu@gmail.com>
4277
4278 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4279
0be0ce47
EZ
42802011-07-13 Eli Zaretskii <eliz@gnu.org>
4281
4282 * buffer.c (mmap_find): Fix a typo.
4283
cd18e7e3
JB
42842011-07-13 Johan Bockgård <bojohan@gnu.org>
4285
4286 Fix execution of x selection hooks.
4287 * xselect.c (Qx_lost_selection_functions)
4288 (Qx_sent_selection_functions): New vars.
4289 (syms_of_xselect): DEFSYM them.
4290 (x_handle_selection_request): Pass Qx_sent_selection_functions
4291 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4292 (x_handle_selection_clear,x_clear_frame_selections):
4293 Pass Qx_lost_selection_functions rather than
4294 Vx_lost_selection_functions to Frun_hook_with_args.
4295
47ea7f44
PE
42962011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4297
ac389d0c 4298 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4299 The old code sometimes used this field without initializing it.
4300
47ea7f44
PE
4301 * alloc.c (gc_sweep): Don't read past end of array.
4302 In theory, the old code could also have corrupted Emacs internals,
4303 though it'd be very unlikely.
4304
bc985c87
AS
43052011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4306
4307 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4308 argument. (Bug#4026)
bc985c87 4309
0cf34688
LMI
43102011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4311
b3dadd76
LMI
4312 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4313 key" (bug#4257).
4314
0cf34688
LMI
4315 * window.c (Fset_window_start): Doc fix (bug#4199).
4316 (Fset_window_hscroll): Ditto.
4317
270768cd
PE
43182011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4319
077e3dda 4320 Fix minor new problems caught by GCC 4.6.1.
270768cd 4321 * term.c (init_tty): Remove unused local.
490011a6 4322 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4323 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4324 not used otherwise.
270768cd 4325
b1f58454
CY
43262011-07-12 Chong Yidong <cyd@stupidchicken.com>
4327
4328 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4329
22b9578d
LMI
43302011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4331
6e70ab07
LMI
4332 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4333 are the mini-buffer and the echo area (bug#3320).
4334
22b9578d
LMI
4335 * term.c (init_tty): Remove support for supdup, c10 and perq
4336 terminals, which are no longer supported (bug#1482).
4337
8974cc9f
JB
43382011-07-10 Johan Bockgård <bojohan@gnu.org>
4339
4340 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4341
a560d974
JD
43422011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4343
4344 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4345 for non-popups (Bug#3642).
4346
1dae0f0a
AS
43472011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4348
268c2c36 4349 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4350 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4351 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4352 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4353 * data.c (fmod): Likewise.
4354 * dispnew.c (swap_glyphs_in_rows): Likewise.
4355 * emacs.c (memory_warning_signal): Likewise.
4356 * floatfns.c (float_error): Likewise.
4357 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4358 (otf_open, font_otf_capability, generate_otf_features)
4359 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4360 Likewise.
4361 * image.c (pbm_read_file): Likewise.
4362 * indent.c (string_display_width): Likewise.
4363 * intervals.c (check_for_interval, search_for_interval)
4364 (inc_interval_count, count_intervals, root_interval)
4365 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4366 * lread.c (defalias): Likewise.
268c2c36 4367 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4368 * regex.c (set_image_of_range_1, set_image_of_range)
4369 (regex_grow_registers): Likewise.
4370 * sysdep.c (strerror): Likewise.
4371 * termcap.c (valid_filename_p, tprint, main): Likewise.
4372 * tparam.c (main): Likewise.
4373 * unexhp9k800.c (run_time_remap, save_data_space)
4374 (update_file_ptrs, read_header, write_header, calculate_checksum)
4375 (copy_file, copy_rest, display_header): Likewise.
4376 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4377 Likewise.
4378 * xdisp.c (check_it): Likewise.
4379 * xfaces.c (register_color, unregister_color, unregister_colors):
4380 Likewise.
4381 * xfns.c (print_fontset_result): Likewise.
4382 * xrdb.c (member, fatal, main): Likewise.
4383
99033785
PE
43842011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 Fix minor problems found by static checking (Bug#9031).
4387 * chartab.c (char_table_set_range, map_sub_char_table):
4388 Remove unused locals.
4389 (uniprop_table): Now static.
4390 * composite.c (_work_char): Remove unused static var.
4391
9cb2ac56
JB
43922011-07-09 Juanma Barranquero <lekktu@gmail.com>
4393
4394 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4395
f25661f0
JD
43962011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4397
4398 * gtkutil.c (qttip_cb): Remove code without function.
4399
8278c4fe
EZ
44002011-07-09 Eli Zaretskii <eliz@gnu.org>
4401
4402 * w32.c (pthread_sigmask): New stub.
4403
1692ae2d 44042011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4405
8a6ebd58 4406 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4407 sigprocmask is portable only for single-threaded applications, and
4408 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4409 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4410 (LIBES): Use it.
4411 * callproc.c (Fcall_process):
4412 * process.c (create_process):
4413 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4414 Use pthread_sigmask, not sigprocmask.
123403e4 4415
1b854618
JD
44162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4417
4418 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4419 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4420 wrong (Bug#8591).
4421
3fe4b549
JD
44222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4423
0ce7e563
JD
4424 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4425 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4426 (xg_hide_tooltip): Fix comment.
4427
3fe4b549
JD
4428 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4429 in registerServicesMenuSendTypes.
4430 (validRequestorForSendType): Don't check ns_return_types.
4431
4432 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4433 ns_return_type.
4434
5df75e47
JR
44352011-07-08 Jason Rumney <jasonr@gnu.org>
4436
22610910
JR
4437 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4438 SH_SHOW for hidden windows (Bug#5482).
4439
5df75e47
JR
4440 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4441 frame struct members of non-existent frames (Bug#6284).
4442
699c10bd
JD
44432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4444
4393663b
JD
4445 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4446 variable firstTime not needed on OSX >= 10.6.
4447 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4448 >= 10.5. Use setKnobProportion, setDoubleValue.
4449
4450 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4451 (MAC_OS_X_VERSION_10_5): Define if not defined.
4452 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4453 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4454 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4455
4456 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4457 cString and lossyCString on OSX >= 10.4
4458
58179cce 4459 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4460 sizeToFit on OSX >= 10.2.
4461
4462 * nsimage.m (allocInitFromFile): Don't use deprecated method
4463 bestRepresentationForDevice on OSX >= 10.6.
4464
4465 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4466 to avoid warning.
4467
4468 * emacs.c: Declare unexec_init_emacs_zone.
4469
a63e0781
JD
4470 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4471
699c10bd
JD
4472 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4473
4474 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4475 on svcsMenu (Bug#8842).
4476
4477 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4478 ns_return_types.
4479 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4480
4481 * nsterm.m (QUTF8_STRING): Declare.
4482 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4483 (validRequestorForSendType): Return type is (id).
4484 Change indexOfObjectIdenticalTo to indexOfObject.
4485 Check if we have local selection before returning self (Bug#8842).
4486 (writeSelectionToPasteboard): Put local selection into paste board
4487 if we have a local selection (Bug#8842).
4488 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4489
4490 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4491 (ns_get_local_selection): Declare.
4492
54e10184
LMI
44932011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4494
9888ff71
LMI
4495 * keymap.c (describe_map_tree): Don't insert a double newline at
4496 the end of the buffer (bug#1169) and return whether we inserted
4497 something.
4498
54e10184
LMI
4499 * callint.c (Fcall_interactively): Change "reading args" to
4500 "providing args" to try to clarify what it does (bug#1010).
4501
15fa4783
KH
45022011-07-07 Kenichi Handa <handa@m17n.org>
4503
4504 * composite.c (composition_compute_stop_pos): Ignore a static
4505 composition starting before CHARPOS (Bug#8915).
4506
4507 * xdisp.c (handle_composition_prop): Likewise.
4508
a8815b00
EZ
45092011-07-07 Eli Zaretskii <eliz@gnu.org>
4510
4511 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4512 (Bug#9015)
4513
ef7b981d 45142011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4515
4516 * character.h (unicode_category_t): New enum type.
4517
4518 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4519 (Qchar_code_property_table): New variable.
4520 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4521 (UNIPROP_COMPRESSED_FORM_P): New macros.
4522 (char_table_ascii): Uncompress the compressed values.
4523 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4524 Uncompress the compressed values.
ac389d0c 4525 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4526 (char_table_ref_and_range): Uncompress the compressed values.
4527 (sub_char_table_set): New arg is_uniprop. Callers changed.
4528 Uncompress the compressed values.
4529 (sub_char_table_set_range): Args changed. Callers changed.
4530 (char_table_set_range): Adjuted for the above change.
4531 (map_sub_char_table): Delete args default_val and parent. Add arg
4532 top. Give decoded values to a Lisp function.
640c8776 4533 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4534 values to a Lisp function. Gcpro more variables.
4535 (uniprop_table_uncompress)
4536 (uniprop_decode_value_run_length): New functions.
4537 (uniprop_decoder, uniprop_decoder_count): New variables.
4538 (uniprop_get_decoder, uniprop_encode_value_character)
4539 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4540 New functions.
4541 (uniprop_encoder, uniprop_encoder_count): New variables.
4542 (uniprop_get_encoder, uniprop_table)
4543 (Funicode_property_table_internal, Fget_unicode_property_internal)
4544 (Fput_unicode_property_internal): New functions.
4545 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4546 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4547 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4548 char-code-property-alist.
4549
640c8776 4550 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4551 Vunicode_category_table.
4552
640c8776 4553 * font.c (font_range): Adjust for the change of
c805dec0
KH
4554 Vunicode_category_table.
4555
76b397fb
DN
45562011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4557
4558 * m/iris4d.h: Remove file, move contents ...
4559 * s/irix6-5.h: ... here.
4560
22b4128e
PE
45612011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4562
4563 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4564 * alloc.c (mark_buffer):
4565 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4566 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4567 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4568 This isn't true in general, and it's particularly not true
4569 if Emacs is configured with --with-wide-int.
4570 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4571 New macros, used in the buffer.c change.
4572
869795d6
JD
45732011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4574
4575 * xsettings.c: Use both GConf and GSettings if both are available.
4576 (store_config_changed_event): Add comment.
4577 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4578 (store_tool_bar_style_changed): New functions.
5e617bc2 4579 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4580 (struct xsettings): Move font inside HAVE_XFT.
4581 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4582 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4583 Move inside HAVE_XFT.
640c8776 4584 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4585 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4586 also.
4587 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4588 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4589 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4590 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4591 (parse_settings): Move check for font inside HAVE_XFT.
4592 (read_settings, apply_xft_settings): Add comment.
4593 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4594 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4595 call store_font_name_changed.
4596 (xft_settings_event): Add comment.
4597 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4598 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4599 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4600 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4601 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4602 (xsettings_get_system_font, xsettings_get_system_normal_font):
4603 Add comment.
869795d6 4604
d8ed26bd
PE
46052011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4606
4607 Random fixes. E.g., (random) never returned negative values.
4608 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4609 subseconds part to the entropy, as that's a bit more random.
4610 Prefer signed to unsigned, since the signedness doesn't matter and
4611 in general we prefer signed. When given a limit, use a
4612 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4613 latter isn't right if USE_2_TAGS_FOR_INTS.
4614 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4615 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4616
cabf1cac
SM
46172011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4618
4619 * textprop.c (text_property_stickiness):
4620 Obey Vtext_property_default_nonsticky.
4621 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4622 * w32fns.c (syms_of_w32fns):
4623 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4624
6e9b2be9
PE
46252011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4626
4627 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4628 This is more efficient than Ffile_directory_p and avoids a minor race.
4629
90186c68
LMI
46302011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4631
7c301272
LMI
4632 * buffer.c (Foverlay_put): Say what the return value is
4633 (bug#7835).
4634
c4f2d8d4
LMI
4635 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4636 is a directory before asking whether to use the file name
4637 (bug#7564).
ad637907
LMI
4638 (barf_or_query_if_file_exists): Make the "File is a directory"
4639 error be more correct.
c4f2d8d4 4640
90186c68
LMI
4641 * fns.c (Frequire): Remove the mention of the .gz files, since
4642 that's installation-specific, but keep the mention of
4643 `get-load-suffixes'.
4644
da64016e
PE
46452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4646
4647 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4648 Report string overflow if the output is too long.
4649
7d47b580
JB
46502011-07-04 Juanma Barranquero <lekktu@gmail.com>
4651
a555cb87
JB
4652 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4653 (syms_of_gnutls): Remove duplicate DEFSYM for
4654 Qgnutls_bootprop_verify_hostname_error, an error for
4655 Qgnutls_bootprop_verify_error (which is no longer used).
4656
7d47b580
JB
4657 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4658 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4659 Also (re)move comments that are misplaced or no longer relevant.
4660
1e49bfab
LMI
46612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4662
4663 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4664
1485f4c0
CY
46652011-07-03 Chong Yidong <cyd@stupidchicken.com>
4666
4667 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4668 and background color parameters if they have been changed.
4669
a9ab721e
LMI
46702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4671
4672 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4673
cf7cff57
PE
46742011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4675
2e13213d
PE
4676 * xsettings.c (SYSTEM_FONT): Define only when used.
4677 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4678
cf7cff57
PE
4679 * keymap.c (access_keymap_1): Now static.
4680
7a8e04f7
CY
46812011-07-02 Chong Yidong <cyd@stupidchicken.com>
4682
4683 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4684 leave any prefix arg for the up event (Bug#1586).
4685
61352f62
LMI
46862011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4687
69bb1ef7
LMI
4688 * lread.c (syms_of_lread): Mention single symbols defined by
4689 `defvar' or `defconst' (bug#7154).
4690
61352f62 4691 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4692 (Frequire): Mention get-load-suffixes.
61352f62 4693
28545e04
MR
46942011-07-02 Martin Rudalics <rudalics@gmx.at>
4695
4696 * window.h (window): Remove clone_number slot.
4697 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4698 Remove.
4699 (make_parent_window, make_window, saved_window)
4700 (Fset_window_configuration, save_window_save): Don't deal with
4701 clone numbers.
4702 * buffer.c (Qclone_number): Remove declaration.
4703 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4704
3349e122
SM
47052011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4706
4707 Add multiple inheritance to keymaps.
4708 * keymap.c (Fmake_composed_keymap): New function.
4709 (Fset_keymap_parent): Simplify.
4710 (fix_submap_inheritance): Remove.
4711 (access_keymap_1): New function extracted from access_keymap to handle
4712 embedded parents and handle lists of maps.
4713 (access_keymap): Use it.
4714 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4715 (Fcopy_keymap): Handle embedded parents.
4716 (Fcommand_remapping, define_as_prefix): Simplify.
4717 (Fkey_binding): Simplify.
4718 (syms_of_keymap): Move minibuffer-local-completion-map,
4719 minibuffer-local-filename-completion-map,
4720 minibuffer-local-must-match-map, and
4721 minibuffer-local-filename-must-match-map to Elisp.
4722 (syms_of_keymap): Defsubr make-composed-keymap.
4723 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4724 (parse_menu_item): Trivial simplification.
4725
3279eb87
GM
47262011-07-01 Glenn Morris <rgm@gnu.org>
4727
4728 * Makefile.in (SETTINGS_LIBS): Fix typo.
4729
4550efdf
KI
47302011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4731
4732 * coding.c (Fencode_coding_string): Record the last coding system
4733 used, as the function doc string says (bug#8738).
4734
0949d2b6
JD
47352011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4736
4737 * xsettings.c (store_monospaced_changed): Take new font as arg and
4738 check for change against current_mono_font.
4739 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4740 (emacs_settings_constructor, emacs_settings_get_property)
4741 (emacs_settings_set_property, emacs_settings_class_init)
4742 (emacs_settings_init, gsettings_obj): Remove.
4743 (something_changedCB): New function for HAVE_GSETTINGS.
4744 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4745 with value as argument.
4746 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4747 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4748 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4749 "changed".
4750
4751 * xgselect.c: Add defined (HAVE_GSETTINGS).
4752 (xgselect_initialize): Ditto.
4753
4754 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4755 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4756 xg_select.
4757
bbc6b304
PE
47582011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4759
4760 * eval.c (struct backtrace): Simplify and port the data structure.
4761 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4762 signed bit field, as this assumption is not portable and it makes
4763 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4764 "char debug_on_exit : 1" as this is not portable either; instead,
4765 use the portable "unsigned int debug_on_exit : 1". Remove unused
4766 member evalargs. Remove obsolete comments about cc bombing out.
4767
9851bfc5
JD
47682011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4769
51bb811f 4770 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4771 Let HAVE_GSETTINGS override HAVE_GCONF.
4772 (store_monospaced_changed): New function.
4773 (EMACS_SETTINGS): A new type derived from GObject to handle
4774 GSettings notifications.
4775 (emacs_settings_constructor, emacs_settings_get_property)
4776 (emacs_settings_set_property, emacs_settings_class_init):
4777 New functions.
4778 (gsettings_client, gsettings_obj): New variables.
4779 (GSETTINGS_SCHEMA): New define.
4780 (something_changedCB): Call store_monospaced_changed.
4781 (init_gsettings): New function.
4782 (xsettings_initialize): Call init_gsettings.
4783 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4784 to NULL.
4785
640c8776 4786 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4787 GCONF_CFLAGS/LIBS.
4788
5386012d
MR
47892011-06-29 Martin Rudalics <rudalics@gmx.at>
4790
4791 * window.c (resize_root_window, grow_mini_window)
4792 (shrink_mini_window): Rename Qresize_root_window to
4793 Qwindow_resize_root_window and Qresize_root_window_vertically to
4794 Qwindow_resize_root_window_vertically.
4795
f13e0b08
PE
47962011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4797
4798 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4799
94515237
JB
48002011-06-27 Juanma Barranquero <lekktu@gmail.com>
4801
4802 * makefile.w32-in: Redesign dependencies so they reflect more
4803 clearly which files are directly included by each source file,
4804 and not through other includes.
4805
e43b6e43
MR
48062011-06-27 Martin Rudalics <rudalics@gmx.at>
4807
4808 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4809 (sort_overlays, overlay_strings): When an overlay's clone number
4810 matches the window's clone number process the overlay even if
4811 the overlay's window property doesn't match the current window.
4812
d68443dc
MR
4813 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4814 (Fwindow_hchild): Rename to Fwindow_left_child.
4815 (Fwindow_next): Rename to Fwindow_next_sibling.
4816 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4817 (resize_window_check): Rename to window_resize_check.
4818 (resize_window_apply): Rename to window_resize_apply.
4819 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4820 (Fdelete_other_windows_internal, resize_frame_windows)
4821 (Fsplit_window_internal, Fdelete_window_internal)
4822 (grow_mini_window, shrink_mini_window)
4823 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4824
c7e73be5
JD
48252011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4826
4827 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4828 (emacs_fixed_set_min_size): Remove.
4829 (emacs_fixed_new): Take frame as argument.
4830
4831 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4832 (_EmacsFixedPrivate): Remove minwidth/height.
4833 Add struct frame *f.
4834 (emacs_fixed_init): Initialize priv->f.
4835 (get_parent_class, emacs_fixed_set_min_size): Remove.
4836 (emacs_fixed_new): Set priv->f to argument.
4837 (emacs_fixed_get_preferred_width)
4838 (emacs_fixed_get_preferred_height): Use min_width/height from
4839 frames size_hint to set minimum and natural (Bug#8919).
4840 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4841 and use min_width/height from frames size_hint to set
4842 min_width/height (Bug#8919).
4843
4844 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4845 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4846 Fix indentation.
c7e73be5 4847
cf99dcf8
EZ
48482011-06-26 Eli Zaretskii <eliz@gnu.org>
4849
4850 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4851 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4852 called at ZV.
4853
029529ac
CY
48542011-06-26 Chong Yidong <cyd@stupidchicken.com>
4855
4856 * process.c (wait_reading_process_output): Bypass select if
4857 waiting for a cell while ignoring keyboard input, and input is
4858 pending. Suggested by Jan Djärv (Bug#8869).
4859
7a7ef429
PE
48602011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4861
4862 Use gnulib's dup2 module instead of rolling our own.
4863 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4864
11fdef7d 48652011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4866
4867 * dispnew.c (scrolling_window): Before scrolling, turn off a
4868 mouse-highlight in the window being scrolled.
4869
cd3520a4
JB
48702011-06-24 Juanma Barranquero <lekktu@gmail.com>
4871
4872 Move DEFSYM to lisp.h and use everywhere.
4873
4874 * character.h (DEFSYM): Move declaration...
4875 * lisp.h (DEFSYM): ...here.
4876
4877 * gnutls.c:
4878 * minibuf.c:
4879 * w32menu.c:
4880 * w32proc.c:
4881 * w32select.c: Don't include character.h.
4882
4883 * alloc.c (syms_of_alloc):
4884 * buffer.c (syms_of_buffer):
4885 * bytecode.c (syms_of_bytecode):
4886 * callint.c (syms_of_callint):
4887 * casefiddle.c (syms_of_casefiddle):
4888 * casetab.c (init_casetab_once):
4889 * category.c (init_category_once, syms_of_category):
4890 * ccl.c (syms_of_ccl):
4891 * cmds.c (syms_of_cmds):
4892 * composite.c (syms_of_composite):
4893 * dbusbind.c (syms_of_dbusbind):
4894 * dired.c (syms_of_dired):
4895 * dispnew.c (syms_of_display):
4896 * doc.c (syms_of_doc):
4897 * editfns.c (syms_of_editfns):
4898 * emacs.c (syms_of_emacs):
4899 * eval.c (syms_of_eval):
4900 * fileio.c (syms_of_fileio):
4901 * fns.c (syms_of_fns):
4902 * frame.c (syms_of_frame):
4903 * fringe.c (syms_of_fringe):
4904 * insdel.c (syms_of_insdel):
4905 * keymap.c (syms_of_keymap):
4906 * lread.c (init_obarray, syms_of_lread):
4907 * macros.c (syms_of_macros):
4908 * msdos.c (syms_of_msdos):
4909 * print.c (syms_of_print):
4910 * process.c (syms_of_process):
4911 * search.c (syms_of_search):
4912 * sound.c (syms_of_sound):
4913 * syntax.c (init_syntax_once, syms_of_syntax):
4914 * terminal.c (syms_of_terminal):
4915 * textprop.c (syms_of_textprop):
4916 * undo.c (syms_of_undo):
4917 * w32.c (globals_of_w32):
4918 * window.c (syms_of_window):
4919 * xdisp.c (syms_of_xdisp):
4920 * xfaces.c (syms_of_xfaces):
4921 * xfns.c (syms_of_xfns):
4922 * xmenu.c (syms_of_xmenu):
4923 * xsettings.c (syms_of_xsettings):
4924 * xterm.c (syms_of_xterm): Use DEFSYM.
4925
4228cf16
TZ
49262011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4927
cd3520a4 4928 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4929
7fcccf1e
PE
49302011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4931
7efb4e0e
PE
4932 Integer and buffer overflow fixes (Bug#8873).
4933
ff5844ad
PE
4934 * print.c (printchar, strout): Check for string overflow.
4935 (PRINTPREPARE, printchar, strout):
4936 Don't set size unless allocation succeeds.
4937
90532f02
PE
4938 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4939 for sizes. Check for string overflow more accurately.
4940 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4941
6d84508d
PE
4942 * macros.c: Integer and buffer overflow fixes.
4943 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4944 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4945 Use ptrdiff_t, not int, for sizes.
4946 Don't increment bufsize until after realloc succeeds.
4947 Check for size-calculation overflow.
4948 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4949
437b2cb4
PE
4950 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4951
8b9ac8b4
PE
4952 * lread.c: Integer overflow fixes.
4953 (read_integer): Radix is now EMACS_INT, not int,
4954 to improve quality of diagnostics for out-of-range radices.
4955 Calculate buffer size correctly for out-of-range radices.
4956 (read1): Check for integer overflow in radices, and in
4957 read-circle numbers.
82cb60d3
PE
4958 (read_escape): Avoid int overflow.
4959 (Fload, openp, read_buffer_size, read1)
4960 (substitute_object_recurse, read_vector, read_list, map_obarray):
4961 Use ptrdiff_t, not int, for sizes.
4962 (read1): Use EMACS_INT, not int, for sizes.
20270765 4963 Check for size overflow.
8b9ac8b4 4964
7fcccf1e
PE
4965 * image.c (cache_image): Check for size arithmetic overflow.
4966
bfbbd7e7
PE
4967 * lread.c: Integer overflow issues.
4968 (saved_doc_string_size, saved_doc_string_length)
4969 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4970 Now ptrdiff_t, not int.
4971 (read1): Don't assume doc string length fits in int. Check for
4972 out-of-range doc string lengths.
4973 (read_list): Don't assume file position fits in int.
39019e54 4974 (read_escape): Check for hex character overflow.
bfbbd7e7 4975
4e323265
LL
49762011-06-22 Leo Liu <sdl.web@gmail.com>
4977
4978 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4979 Move to minibuffer.el.
4980
85fece3e
PE
49812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4982
20b84ce9 4983 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4984 The following patches are for when GLYPH_DEBUG && !XASSERT.
4985 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4986 * dispnew.c (flush_stdout):
4987 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4988 Mark as externally visible.
4989 * dispnew.c (check_window_matrix_pointers): Now static.
4990 * dispnew.c (window_to_frame_vpos):
4991 * xfns.c (unwind_create_frame):
4992 * xterm.c (x_check_font): Remove unused local.
4993 * scroll.c (CHECK_BOUNDS):
4994 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4995 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4996 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4997 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4998 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4999 Now static.
5000 (debug_method_add): Use va_list and vsprintf rather than relying
5001 on undefined behavior with wrong number of arguments.
5002 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5003 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5004 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5005 since we're not interested in debugging glyphs with old libraries.
5006 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5007 GCC 4.6.0's static checking.
5008
0766b489
PE
50092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5010
31fd4b32
PE
5011 Integer overflow and signedness fixes (Bug#8873).
5012 A few related buffer overrun fixes, too.
5013
b79e8648
PE
5014 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5015
0766b489
PE
5016 * dispextern.h (struct face.stipple):
5017 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5018 (x_bitmap_mask, x_allocate_bitmap_record)
5019 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5020 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5021 (x_create_bitmap_from_xpm_data):
5022 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5023 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5024 (.bitmaps_last):
5025 * xfaces.c (load_pixmap):
5026 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5027 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5028 (.bitmaps_last, struct x_output.icon_bitmap):
5029 Use ptrdiff_t, not int, for bitmap indexes.
5030 (x_allocate_bitmap_record): Check for size overflow.
5031 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5032
b081724f
PE
5033 Use ptrdiff_t, not int, for overlay counts.
5034 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5035 * editfns.c (overlays_around, get_pos_property):
5036 * textprop.c (get_char_property_and_overlay):
5037 * xdisp.c (next_overlay_change, note_mouse_highlight):
5038 * xfaces.c (face_at_buffer_position):
21514da7
PE
5039 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5040 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5041 (Fnext_overlay_change, Fprevious_overlay_change)
5042 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5043 Use ptrdiff_t, not int, for sizes.
21514da7 5044 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5045
3de73e5e
PE
5046 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5047
2606c57b
PE
5048 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5049 (x_session_initialize): Do not assume string length fits in int.
5050
aaafe47a
PE
5051 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5052 This is unlikely, but can occur if DPI is outlandish.
5053
2674ddc8 5054 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5055 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5056
28154962
PE
5057 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5058 * xrdb.c (magic_file_p, search_magic_path):
5059 Omit last arg SUFFIX; it was always 0. All callers changed.
5060 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5061
7de51af5
PE
5062 * xfont.c (xfont_match): Avoid need for strlen.
5063
25ed6cc3
PE
5064 * xfns.c: Don't assume strlen fits in int.
5065 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5066
4eab31dd
PE
5067 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5068 not unsigned long, as we prefer signed integers. All callers changed.
5069 Detect integer overflow in repeat count.
5070 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5071 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5072
171e2a58
PE
5073 * termcap.c: Don't assume sizes fit in int and never overflow.
5074 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5075 (gobble_line): Check for size-calculation overflow.
5076
ad39faca 5077 * minibuf.c (Fread_buffer):
6e5bb2dc 5078 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5079 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5080 Don't assume string length fits in int.
5081
52c61c22 5082 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5083 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5084
b5b8c9e5
PE
5085 * font.c: Don't assume string length fits in int.
5086 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5087 Use ptrdiff_t, not int.
ccd6111c
PE
5088 (font_intern_prop): Don't assume string length fits in int.
5089 Don't assume integer property fits in fixnum.
5090 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5091
882f0d81 5092 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5093 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5094 Reformulate so as not to need the command string.
5095 Invoke gzip -cd rather than gunzip, as it's more portable.
5096 (lock_info_type, lock_file_1, lock_file):
5097 Don't assume pid_t and time_t fit in unsigned long.
5098 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5099 (current_lock_owner): Prefer signed type for sizes.
5100 Use memcpy, not strncpy, where memcpy is what is really wanted.
5101 Don't assume (via atoi) that time_t and pid_t fit in int.
5102 Check for time_t and/or pid_t out of range, e.g., via a network share.
5103 Don't alloca where an auto var works fine.
5104
93f4cf88
PE
5105 * fileio.c: Fix some integer overflow issues.
5106 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5107 Don't assume string length fits in int.
5108 (directory_file_name): Don't assume string length fits in long.
5109 (make_temp_name): Don't assume pid fits in int, or that its print
5110 length is less than 20.
5111
f3e92b69
PE
5112 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5113
1bfdaf10
PE
5114 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5115
35016e9a
PE
5116 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5117
3d1e65a1
PE
5118 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5119 We prefer signed integers, even for size calculations.
5120
0b963a93
PE
5121 * emacs.c: Don't assume string length fits in 'int'.
5122 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5123 (main): Don't invoke strlen when not needed.
5124
573f4b54
PE
5125 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5126 (XD_DEBUG_MESSAGE): Don't waste a byte.
5127
989f33ba
PE
5128 * callproc.c (getenv_internal_1, getenv_internal)
5129 (Fgetenv_internal):
965d34eb
PE
5130 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5131
e4d29b33
PE
5132 * lread.c (invalid_syntax): Omit length argument.
5133 All uses changed. This doesn't fix a bug, but it simplifies the
5134 code away from its former Hollerith-constant appearance, and it's
5135 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5136 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5137
eb49b136
PE
5138 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5139 This didn't break anything, but it didn't help either.
5140 It's confusing to put a bogus integer in a place where the actual
5141 value does not matter.
9f62aeb1 5142 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5143 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5144
15375a22
PE
5145 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5146 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5147 implementation.
b61cc01c
PE
5148 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5149 We prefer signed types, and the value cannot exceed the EMACS_INT
5150 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5151 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5152 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5153 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5154
53b2623d
PE
5155 * indent.c (sane_tab_width): New function.
5156 (current_column, scan_for_column, Findent_to, position_indentation)
5157 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5158 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5159
51cab52b 5160 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5161
f2ed8a70
PE
5162 * lisp.h (lint_assume): New macro.
5163 * composite.c (composition_gstring_put_cache):
5164 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5165
abe80cc6
PE
5166 * editfns.c, insdel.c:
5167 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5168
b02c740e
PE
5169 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5170
ebc96716
PE
5171 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5172
b4e50fa0 5173 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5174 Use much-faster test for byte-length change.
311d5d7c 5175 Don't assume string byte-length fits in 'int'.
a4cf38e4 5176 Check that character arg fits in 'int'.
85461888 5177 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5178
c0c1ee9f
PE
5179 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5180
a498d7f4
PE
5181 * fns.c (concat): Catch string overflow earlier.
5182 Do not rely on integer wraparound.
5183
51cab52b
PE
5184 * dispextern.h (struct it.overlay_strings_charpos)
5185 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5186 * xdisp.c (forward_to_next_line_start)
5187 (back_to_previous_visible_line_start)
5188 (reseat_at_next_visible_line_start, next_element_from_buffer):
5189 Don't arbitrarily truncate the value of 'selective' to int.
5190
76031fad
PE
5191 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5192
5eb55db9
PE
5193 * composite.c: Don't truncate sizes to 'int'.
5194 (composition_gstring_p, composition_reseat_it)
5195 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5196 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5197 not EMACS_UINT, for indexes.
5eb55db9 5198
0703a717
PE
5199 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5200
d6202519
PE
5201 * buffer.c: Include <verify.h>.
5202 (struct sortvec.priority, struct sortstr.priority):
8961a454 5203 Now EMACS_INT, not int.
c20998a7 5204 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5205 (struct sortstr.size, record_overlay_string)
5206 (struct sortstrlist.size, struct sortlist.used):
5207 Don't truncate size to int.
5208 (record_overlay_string): Check for size-calculation overflow.
d6202519 5209 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5210
d5a19415
JM
52112011-06-22 Jim Meyering <meyering@redhat.com>
5212
029529ac 5213 Don't leak an XBM-image-sized buffer
d5a19415
JM
5214 * image.c (xbm_load): Free the image buffer after using it.
5215
a9041e6c
PE
52162011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5217
5218 Port to Sun C.
5219 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5220 that Sun C diagnosed.
5221 * fns.c (secure_hash): Fix pointer signedness issue.
5222 * intervals.c (static_offset_intervals): New function.
5223 (offset_intervals): Use it.
5224
7f3f739f
LL
52252011-06-21 Leo Liu <sdl.web@gmail.com>
5226
5227 * deps.mk (fns.o):
5228 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5229 sha512.h.
5230
5231 * fns.c (secure_hash): Rename from crypto_hash_function and change
5232 the first arg to accept symbols.
5b66d427 5233 (Fsecure_hash): New primitive.
7f3f739f
LL
5234 (syms_of_fns): New symbols.
5235
76147d94
DD
52362011-06-20 Deniz Dogan <deniz@dogan.se>
5237
5238 * process.c (Fset_process_buffer): Clarify return value in
5239 docstring.
5240
7d7d0045
CY
52412011-06-18 Chong Yidong <cyd@stupidchicken.com>
5242
5243 * dispnew.c (add_window_display_history): Use BVAR.
5244
5245 * xdisp.c (debug_method_add): Use BVAR.
5246 (check_window_end, dump_glyph_matrix, dump_glyph)
5247 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5248
5249 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5250 Likewise.
5251
5252 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5253 check till after the cache is created in init_frame_faces.
5254
ff2bc410
SM
52552011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5256
5257 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5258
28177add
PE
52592011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5260
dd3482fe
PE
5261 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5262 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5263 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5264
393d71f3 5265 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5266 * fileio.c (Finsert_file_contents):
5267 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5268 Remove the old (too-loose) buffer overflow checks.
5269 They weren't needed, since make_gap checks for buffer overflow.
5270 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5271 The old code merely checked for Emacs fixnum overflow, and relied
5272 on undefined (wraparound) behavior. The new code avoids undefined
5273 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5274
2e6813b0 5275 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5276 Tune. Don't use wider integers than needed. Don't use alloca.
5277 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5278
599a9e4f
PE
5279 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5280
99561444
PE
5281 * insdel.c, lisp.h (buffer_overflow): New function.
5282 (insert_from_buffer_1, replace_range, replace_range_2):
5283 * insdel.c (make_gap_larger):
5284 * editfns.c (Finsert_char):
5285 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5286
28177add
PE
5287 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5288
e69dafad
PE
52892011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5290
4baa020d 5291 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5292
b1c46f02
PE
5293 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5294 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5295
e69dafad
PE
5296 * fileio.c: Don't assume EMACS_INT fits in off_t.
5297 (emacs_lseek): New static function.
5298 (Finsert_file_contents, Fwrite_region): Use it.
5299 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5300
566684ea
PE
5301 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5302
e6966cd6
PE
5303 * fns.c: Don't overflow int when computing a list length.
5304 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5305 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5306 truncation on 64-bit hosts. Check for QUIT every
5307 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5308 faster and is responsive enough.
5309 (Flength): Report an error instead of overflowing an integer.
5310 (Fsafe_length): Return a float if the value is not representable
5311 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5312 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5313 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5314
dd0b0efb
PE
5315 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5316 (header_size, word_size): New constants.
5317 (allocate_vectorlike): Don't check size overflow here.
5318 (allocate_vector): Check it here instead, since this is the only
5319 caller of allocate_vectorlike that could cause overflow.
5320 Check that the new vector's length is representable as a fixnum.
5321
86fe5cfe
PE
5322 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5323 The previous code was bogus. For example, next_almost_prime (32)
5324 returned 39, which is undesirable as it is a multiple of 3; and
5325 next_almost_prime (24) returned 25, which is a multiple of 5 so
5326 why was the code bothering to check for multiples of 7?
5327
80e88859
PE
5328 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5329
4a2f0ad6
PE
5330 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5331
f66c7cf8
PE
5332 Variadic C functions now count arguments with ptrdiff_t.
5333 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5334 Back then I didn't know that the Emacs coding style prefers signed int.
5335 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5336 were being counted with int, which may truncate counts on 64-bit
5337 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5338 * lisp.h (struct Lisp_Subr.function.aMANY)
5339 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5340 Arg counts are now ptrdiff_t, not size_t.
5341 All variadic functions and their callers changed accordingly.
5342 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5343 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5344 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5345 * callint.c (Fcall_interactively): Check arg count for overflow,
5346 to avoid potential buffer overrun. Use signed char, not 'int',
5347 for 'varies' array, so that we needn't bother to check its size
5348 calculation for overflow.
5349 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5350 * eval.c (apply_lambda):
5351 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5352 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5353 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5354
a1759b76
PE
5355 * callint.c (Fcall_interactively): Don't use index var as event count.
5356
d96be9fc
PE
5357 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5358 * mem-limits.h (SIZE): Remove; no longer used.
5359
a690a978 5360 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5361
578c21e6
PE
5362 Remove unnecessary casts.
5363 * xterm.c (x_term_init):
5364 * xfns.c (x_set_border_pixel):
5365 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5366 These aren't needed now that we assume ANSI C.
5367
96f53c6c
PE
5368 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5369 It's more likely to cause problems (due to unsigned overflow)
5370 than to cure them.
5371
83c77d31
PE
5372 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5373
ee2079f1
PE
5374 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5375
6da65536
PE
5376 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5377
7147c4a4
PE
5378 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5379
193e32d9
PE
5380 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5381
e5533da6
PE
5382 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5383
9910e595
PE
5384 GLYPH_CODE_FACE returns EMACS_INT, not int.
5385 * dispextern.h (merge_faces):
5386 * xfaces.c (merge_faces):
01103c44
PE
5387 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5388 Don't assume EMACS_INT fits in int.
9910e595 5389
2638320e
PE
5390 * character.h (CHAR_VALID_P): Remove unused parameter.
5391 * fontset.c, lisp.h, xdisp.c: All uses changed.
5392
045eb8d9
PE
5393 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5394
c1f134b5
PE
5395 * fns.c (concat): Minor tuning based on overflow analysis.
5396 This doesn't fix any bugs. Use int to hold character, instead
5397 of constantly refetching from Emacs object. Use XFASTINT, not
5398 XINT, for value known to be a character. Don't bother comparing
5399 a single byte to 0400, as it's always less.
5400
395fcb93 5401 * floatfns.c (Fexpt):
327eeec8
PE
5402 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5403
abbd3d23
PE
5404 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5405 for characters.
5406
684a03ef
PE
5407 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5408
0fed43f3
PE
5409 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5410 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5411 incorrectly succeed when S was a string, because 4294967386 was
5412 truncated before it was used.
5413
8fd02eb7
PE
5414 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5415 Otherwise, an out-of-range integer could cause undefined behavior
5416 on a 64-bit host.
5417
f8c86b69
PE
5418 * composite.c: Use int, not EMACS_INT, for characters.
5419 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5420 EMACS_INT, for values that are known to be in character range.
5421 This doesn't fix any bugs but is the usual style inside Emacs and
5422 may generate better code on 32-bit machines.
5423
34206dd2
PE
5424 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5425 This is for reasons similar to the recent CHAR_STRING fix.
5426 * charset.c (Fencode_char): Check that character arg is actually
5427 a character. Pass an int to ENCODE_CHAR.
5428 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5429 wider than 'int', as a compile-time check to prevent future regressions
5430 in this area.
5431
c5958d4c 5432 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5433
5434 Make sure a 64-bit char is never passed to CHAR_STRING.
5435 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5436 by silently ignoring the top 32 bits, allowing some values
5437 that were far too large to be valid characters.
5438 * character.h: Include <verify.h>.
5439 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5440 arguments are no wider than unsigned, as a compile-time check
5441 to prevent future regressions in this area.
5442 * data.c (Faset):
01103c44 5443 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5444 (Fsubst_char_in_region):
5445 * fns.c (concat):
5446 * xdisp.c (decode_mode_spec_coding):
5447 Adjust to CHAR_STRING's new requirement.
5448 * editfns.c (Finsert_char, Fsubst_char_in_region):
5449 * fns.c (concat): Check that character args are actually
5450 characters. Without this test, these functions did the wrong
5451 thing with wildly out-of-range values on 64-bit hosts.
5452
d37ca623
PE
5453 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5454 These casts should not be needed on 32-bit hosts, either.
5455 * keyboard.c (read_char):
5456 * lread.c (Fload): Remove casts to unsigned.
5457
ea204efb
PE
5458 * lisp.h (UNSIGNED_CMP): New macro.
5459 This fixes comparison bugs on 64-bit hosts.
5460 (ASCII_CHAR_P): Use it.
5461 * casefiddle.c (casify_object):
01103c44 5462 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5463 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5464 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5465 * dispextern.h (FACE_FROM_ID):
5466 * keyboard.c (read_char): Use UNSIGNED_CMP.
5467
41cb286c
PE
5468 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5469 not to EMACS_INT, to avoid GCC warning.
5470
4a1b9832
PE
5471 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5472
55daad71
PE
5473 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5474 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5475 isn't needed on 32-bit machines.
8f95c75c 5476
01103c44
PE
5477 * buffer.c (Fgenerate_new_buffer_name):
5478 Use EMACS_INT for count, not int.
0ceccced 5479 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5480
5481 * data.c (Qcompiled_function): Now static.
5482
c6f072e7
PE
5483 * window.c (window_body_lines): Now static.
5484
20ce5912
PE
5485 * image.c (gif_load): Rename local to avoid shadowing.
5486
9c4c5f81
PE
5487 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5488 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5489 * alloc.c (make_save_value): Integer argument is now of type
5490 ptrdiff_t, not int.
5491 (mark_object): Use ptrdiff_t, not int.
5492 * lisp.h (pD): New macro.
5493 * print.c (print_object): Use it.
5494
c0c5c8ae
PE
5495 * alloc.c: Use EMACS_INT, not int, to count objects.
5496 (total_conses, total_markers, total_symbols, total_vector_size)
5497 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5498 (total_free_floats, total_floats, total_free_intervals)
5499 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5500 Now EMACS_INT, not int. All uses changed.
5501 (Fgarbage_collect): Compute overall total using a double, so that
5502 integer overflow is less likely to be a problem. Check for overflow
5503 when converting back to an integer.
5a25e253
PE
5504 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5505 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5506 These were 'int' variables that could overflow on 64-bit hosts;
5507 they were never used, so remove them instead of repairing them.
211a0b2a 5508 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5509 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5510 Previously, this ceilinged at INT_MAX, but that doesn't work on
5511 64-bit machines.
e46bb31a 5512 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5513
c78baabf 5514 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5515 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5516 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5517 when a (possibly-narrower) signed value would do just as well.
5518 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5519
c9d624c6
PE
5520 * alloc.c: Catch some string size overflows that we were missing.
5521 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5522 for convenience in STRING_BYTES_MAX.
5523 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5524 The definition here is exact; the one in lisp.h was approximate.
5525 (allocate_string_data): Check for string overflow. This catches
5526 some instances we weren't catching before. Also, it catches
5527 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5528 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5529 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5530
c9d624c6
PE
5531 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5532 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5533 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5534
353032ce
PE
5535 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5536
2bccce07
PE
5537 * alloc.c (Fmake_string): Check for out-of-range init.
5538
0ac30604
SM
55392011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5540
5541 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5542
c195f2de
JD
55432011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5544
5545 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5546 xg_get_default_scrollbar_width.
5547
5548 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5549 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5550 (style_changed_cb): Call update_theme_scrollbar_width and call
5551 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5552 all frames (Bug#8505).
5553 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5554 Call gtk_window_set_resizable if HAVE_GTK3.
5555 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5556 and height if HAVE_GTK3 (Bug#8505).
5557 (scroll_bar_width_for_theme): New variable.
5558 (update_theme_scrollbar_width): New function.
5559 (xg_get_default_scrollbar_width): Move code to
5560 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5561 (xg_initialize): Call update_theme_scrollbar_width.
5562
5563 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5564
5565 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5566
e10ac9f1
MR
55672011-06-12 Martin Rudalics <rudalics@gmx.at>
5568
5569 * frame.c (make_frame): Call other_buffer_safely instead of
5570 other_buffer.
5571
5572 * window.c (temp_output_buffer_show): Call display_buffer with
5573 second argument Vtemp_buffer_show_specifiers and reset latter
5574 immediately after the call.
5575 (Vtemp_buffer_show_specifiers): New variable.
5576 (auto_window_vscroll_p, next_screen_context_lines)
5577 (Vscroll_preserve_screen_position): Remove leading asterisks from
5578 doc-strings.
5579
2d3c217e 55802011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5581
7b7f97e8 5582 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5583 * buffer.c (Qclone_number): Remove for now, as it's unused.
5584 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5585 (record_buffer): Remove unused local.
5586 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5587 (set_frame_buffer_list): Remove; unused.
5588 * frame.h (other_visible_frames): Remove decl.
5589 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5590 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5591 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5592 if HAVE_GPM.
5593 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5594 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5595 Define only if HAVE_GPM.
5596 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5597 (update_hints_inhibit): Remove; never set. All uses removed.
5598 * widgetprv.h (emacsFrameClassRec): Remove decl.
5599 * window.c (delete_deletable_window): Now returns void, since it
5600 wasn't returning anything.
5601 (compare_window_configurations): Remove unused locals.
5602 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5603 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5604 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5605 the same widths as pointers. This follows up on the 2011-05-06 patch.
5606 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5607 * xterm.h: Likewise.
5608 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5609
1384b89e
JB
56102011-06-12 Juanma Barranquero <lekktu@gmail.com>
5611
5612 * makefile.w32-in: Update dependencies.
5613 (LISP_H): Add lib/intprops.h.
5614
1100a63c
CY
56152011-06-11 Chong Yidong <cyd@stupidchicken.com>
5616
5617 * image.c (gif_load): Add animation frame delay to the metadata.
5618 (syms_of_image): Use DEFSYM. New symbol `delay'.
5619
6198ccd0
MR
56202011-06-11 Martin Rudalics <rudalics@gmx.at>
5621
5622 * window.c (delete_deletable_window): Re-add.
5623 (Fset_window_configuration): Rewrite to handle dead buffers and
5624 consequently deletable windows.
5625 (window_tree, Fwindow_tree): Remove. Supply functionality in
5626 window.el.
5627 (compare_window_configurations): Simplify code.
5628
b6e3633c
AS
56292011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5630
1ab0dee5
AS
5631 * image.c (imagemagick_load_image): Fix type mismatch.
5632 (Fimagemagick_types): Likewise.
5633
b6e3633c
AS
5634 * window.h (replace_buffer_in_windows): Declare.
5635
9397e56f
MR
56362011-06-11 Martin Rudalics <rudalics@gmx.at>
5637
5638 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5639 Qclone_number. Remove external declaration of Qdelete_window.
5640 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5641 code.
640c8776
SM
5642 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5643 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5644 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5645 buffer list implementation.
5646 (other_buffer_safely): New function.
5647 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5648 calls to replace_buffer_in_windows and
5649 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5650 if allowed.
5651 (record_buffer): Inhibit quitting and rewrite using quittable
5652 functions. Run Qbuffer_list_update_hook if allowed.
5653 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5654 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5655 Move switch-to-buffer to window.el.
9397e56f
MR
5656 (bury-buffer): Move to window.el.
5657 (Vbuffer_list_update_hook): New variable.
5658
5659 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5660 section.
5661
5662 * window.h (resize_frame_windows): Move up in code.
5663 (Fwindow_frame): Remove EXFUN.
5664 (replace_buffer_in_all_windows): Remove prototype.
5665 (replace_buffer_in_windows_safely): Add prototype.
5666
5667 * window.c: Declare Qdelete_window static again. Move down
5668 declaration of select_count.
5669 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5670 (Fother_window): Move to window.el.
5671 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5672 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5673 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5674 window.el.
5675 (replace_buffer_in_windows): Implement by calling
5676 Qreplace_buffer_in_windows.
5677 (replace_buffer_in_all_windows): Remove with some functionality
5678 moved into replace_buffer_in_windows_safely.
5679 (replace_buffer_in_windows_safely): New function.
5680 (select_window_norecord, select_frame_norecord): Move in front
5681 of run_window_configuration_change_hook. Remove now obsolete
5682 declarations.
640c8776
SM
5683 (Fset_window_buffer): Rewrite doc-string.
5684 Call Qrecord_window_buffer.
9397e56f
MR
5685 (keys_of_window): Move binding for other-window to window.el.
5686
b50691aa
CY
56872011-06-11 Chong Yidong <cyd@stupidchicken.com>
5688
5689 * dispextern.h (struct image): Replace data member, whose int_val
5690 and ptr_val fields were not used by anything, with a single
5691 lisp_val object.
5692
5693 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5694 (gif_clear_image, gif_load, imagemagick_load_image)
5695 (gs_clear_image, gs_load): Callers changed.
5696
3f754b86
PE
56972011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5698
cca69397
PE
5699 * buffer.h: Include <time.h>, for time_t.
5700 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5701
109e28d0
PE
5702 Fix minor problems found by static checking.
5703
60737f02
PE
5704 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5705
4b66faf3
PE
5706 Make identifiers static if they are not used in other modules.
5707 * data.c (Qcompiled_function, Qframe, Qvector):
5708 * image.c (QimageMagick, Qsvg):
5709 * minibuf.c (Qmetadata):
5710 * window.c (resize_window_check, resize_root_window): Now static.
5711 * window.h (resize_window_check, resize_root_window): Remove decls.
5712
109e28d0
PE
5713 * window.c (window_deletion_count, delete_deletable_window):
5714 Remove; unused.
46a4ce9e
PE
5715 (window_body_lines): Now static.
5716 (Fdelete_other_windows_internal): Mark vars as initialized.
5717 Make sure 'resize_failed' is initialized.
5718 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5719 (resize_window_apply): Remove unused local.
5720 * window.h (delete_deletable_window): Remove decl.
5721
109e28d0 5722 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5723 (imagemagick_load_image): Fix pointer signedness problem by changing
5724 last arg from unsigned char * to char *. All uses changed.
5725 Also, fix a local for similar reasons.
5726 Remove unused locals. Remove locals to avoid shadowing.
5727 (fn_rsvg_handle_free): Remove; unused.
5728 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5729 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5730
3f754b86
PE
5731 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5732
2547adb1
CY
57332011-06-10 Chong Yidong <cyd@stupidchicken.com>
5734
5735 * image.c (gif_load): Fix omitted cast error introduced by
5736 2011-06-06 change.
5737
2c8e37d4
MR
57382011-06-10 Martin Rudalics <rudalics@gmx.at>
5739
5740 * window.h (resize_proportionally, orig_total_lines)
5741 (orig_top_line): Remove from window structure.
5742 (set_window_height, set_window_width, change_window_heights)
5743 (Fdelete_window): Remove prototypes.
5744 (resize_frame_windows): Remove duplicate declaration.
5745
440a42e3
EZ
57462011-06-10 Eli Zaretskii <eliz@gnu.org>
5747
5748 * window.h (resize_frame_windows, resize_window_check)
5749 (delete_deletable_window, resize_root_window)
5750 (resize_frame_windows): Declare prototypes.
5751
5752 * window.c (resize_window_apply): Make definition be "static" to
5753 match the prototype.
5754
562dd5e9
MR
57552011-06-10 Martin Rudalics <rudalics@gmx.at>
5756
5757 * window.c: Remove declarations of Qwindow_size_fixed,
5758 window_min_size_1, window_min_size_2, window_min_size,
5759 size_window, window_fixed_size_p, enlarge_window, delete_window.
5760 Remove static from declaration of Qdelete_window, it's
5761 temporarily needed by Fbury_buffer.
5762 (replace_window): Don't assign orig_top_line and
5763 orig_total_lines.
5764 (Fdelete_window, delete_window): Remove. Window deletion is
5765 handled by window.el.
640c8776
SM
5766 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5767 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5768 (Fdelete_other_windows): Remove. Deleting other windows is
5769 handled by window.el.
5770 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5771 handled in window.el.
5772 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5773 Window minimum sizes are handled in window.el.
5774 (shrink_windows, size_window, set_window_height)
5775 (set_window_width, change_window_heights, window_height)
5776 (window_width, CURBEG, CURSIZE, enlarge_window)
5777 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5778 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5779 handled in window.el.
5780 (make_dummy_parent): Rename to make_parent_window and give it a
5781 second argument horflag.
5782 (make_window): Don't set resize_proportionally any more.
5783 (Fsplit_window): Remove. Windows are split in window.el.
5784 (save_restore_action, save_restore_orig_size)
5785 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5786 Resize mini windows in window.el.
5787 (grow_mini_window, shrink_mini_window): Implement by calling
5788 Qresize_root_window_vertically, resize_window_check and
5789 resize_window_apply.
640c8776
SM
5790 (saved_window, Fset_window_configuration, save_window_save):
5791 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5792 resize_proportionally.
5793 (window_min_height, window_min_width): Move to window.el.
5794 (keys_of_window): Move bindings for delete-other-windows,
5795 split-window, delete-window and enlarge-window to window.el.
5796
5797 * buffer.c: Temporarily extern Qdelete_window.
5798 (Fbury_buffer): Temporarily call Qdelete_window instead of
5799 Fdelete_window (Fbury_buffer will move to window.el soon).
5800
5801 * frame.c (set_menu_bar_lines_1): Remove code handling
5802 orig_top_line and orig_total_lines.
5803
5804 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5805 set_window_height but set heights directly.
5806 (change_frame_size_1): Use resize_frame_windows.
5807
5808 * xdisp.c (init_xdisp): Don't use set_window_height but set
5809 heights directly.
5810
640c8776
SM
5811 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5812 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5813 run_window_configuration_change_hook.
5814
5815 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5816 instead of change_window_heights and run
5817 run_window_configuration_change_hook.
5818
1a13852e
MR
58192011-06-09 Martin Rudalics <rudalics@gmx.at>
5820
5821 * window.c (replace_window): Rename second argument REPLACEMENT to
5822 NEW. New third argument SETFLAG. Rewrite.
5823 (delete_window, make_dummy_parent): Call replace_window with
5824 third argument 1.
5825 (window_list_1): Move down in code.
5826 (run_window_configuration_change_hook): Move set_buffer part
5827 before select_frame_norecord part in order to unwind correctly.
5828 Rename count1 to count.
5829 (recombine_windows, delete_deletable_window, resize_root_window)
5830 (Fdelete_other_windows_internal)
5831 (Frun_window_configuration_change_hook, make_parent_window)
5832 (resize_window_check, resize_window_apply, Fresize_window_apply)
5833 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5834 (Fdelete_window_internal, Fresize_mini_window_internal):
5835 New functions.
1a13852e
MR
5836 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5837
f3d1777e
MR
58382011-06-08 Martin Rudalics <rudalics@gmx.at>
5839
496e208e
MR
5840 * window.h (window): Add some new members to window structure -
5841 normal_lines, normal_cols, new_total, new_normal, clone_number,
5842 splits, nest, prev_buffers, next_buffers.
5843 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5844 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5845
f3d1777e
MR
5846 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5847 Remove.
496e208e
MR
5848 (make_dummy_parent): Set new members of windows structure.
5849 (make_window): Move down in code. Handle new members of window
5850 structure.
5851 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5852 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5853 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5854 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5855 (Fset_window_next_buffers, Fset_window_clone_number):
5856 New functions.
496e208e
MR
5857 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5858 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5859 Doc-string fixes.
5860 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5861 Argument WINDOW can be now internal window too.
5862 (Fwindow_use_time): Move up in code.
5863 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5864 Rewrite doc-string.
5865 (Fset_window_configuration, saved_window)
5866 (Fcurrent_window_configuration, save_window_save): Handle new
5867 members of window structure.
b9e809c2
MR
5868 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5869 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5870 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5871 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5872 Qget_mru_window, Qresize_root_window,
5873 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5874 Qauto_buffer_name; staticpro them.
f3d1777e 5875
abde8f8c
MR
58762011-06-07 Martin Rudalics <rudalics@gmx.at>
5877
5878 * window.c (Fwindow_total_size, Fwindow_left_column)
5879 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5880 (Fwindow_list_1): New functions.
5881 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5882 (Fwindow_width, Fscroll_left, Fscroll_right):
5883 Use window_body_cols instead of window_box_text_cols.
5884 (delete_window, Fset_window_configuration):
5885 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5886 (delete_all_subwindows): Take a window as argument and not a
5887 structure. Rewrite.
190b47e6
MR
5888 (window_loop): Remove handling of GET_LRU_WINDOW and
5889 GET_LARGEST_WINDOW.
5890 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5891
5892 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5893 window_box_text_cols. delete_all_subwindows now takes a
5894 Lisp_Object as argument.
abde8f8c 5895
640c8776
SM
5896 * indent.c (compute_motion, Fcompute_motion):
5897 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5898
fa8a67e6
MR
5899 * frame.c (delete_frame): Call delete_all_subwindows with root
5900 window as argument.
5901
a54e3482
DC
59022011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5903
5904 * fns.c (Fputhash): Document return value.
5905
60002bf5
CY
59062011-06-06 Chong Yidong <cyd@stupidchicken.com>
5907
5908 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5909
0c671da6 59102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5911
b862a52a 5912 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5913
be44ca6c
PE
5914 Check for overflow when converting integer to cons and back.
5915 * charset.c (Fdefine_charset_internal, Fdecode_char):
5916 Use cons_to_unsigned to catch overflow.
5917 (Fencode_char): Use INTEGER_TO_CONS.
5918 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5919 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5920 * data.c (long_to_cons, cons_to_long): Remove.
5921 (cons_to_unsigned, cons_to_signed): New functions.
5922 These signal an error for invalid or out-of-range values.
5923 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5924 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5925 * font.c (Ffont_variation_glyphs):
5926 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5927 * lisp.h: Include <intprops.h>.
5928 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5929 (cons_to_signed, cons_to_unsigned): New decls.
5930 (long_to_cons, cons_to_long): Remove decls.
5931 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5932 (Fprimitive_undo): Use CONS_TO_INTEGER.
5933 * xfns.c (Fx_window_property): Likewise.
5934 * xselect.c: Include <limits.h>.
5935 (x_own_selection, selection_data_to_lisp_data):
5936 Use INTEGER_TO_CONS.
5937 (x_handle_selection_request, x_handle_selection_clear)
5938 (x_get_foreign_selection, Fx_disown_selection_internal)
5939 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5940 (lisp_data_to_selection_data): Use cons_to_unsigned.
5941 (x_fill_property_data): Use cons_to_signed.
5942 Report values out of range.
5943
d1f3d2af
PE
5944 Check for buffer and string overflow more precisely.
5945 * buffer.h (BUF_BYTES_MAX): New macro.
5946 * lisp.h (STRING_BYTES_MAX): New macro.
5947 * alloc.c (Fmake_string):
5948 * character.c (string_escape_byte8):
5949 * coding.c (coding_alloc_by_realloc):
5950 * doprnt.c (doprnt):
5951 * editfns.c (Fformat):
5952 * eval.c (verror):
5953 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5954 since they may not be the same number.
5955 * editfns.c (Finsert_char):
5956 * fileio.c (Finsert_file_contents):
5957 Likewise for BUF_BYTES_MAX.
5958
dd52fcea
PE
5959 * image.c: Use ptrdiff_t, not int, for sizes.
5960 (slurp_file): Switch from int to ptrdiff_t.
5961 All uses changed.
5962 (slurp_file): Check that file size fits in both size_t (for
5963 malloc) and ptrdiff_t (for sanity and safety).
5964
7f9bbdbb
PE
5965 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5966 if b->modtime has its maximal value.
5967
dfe18f82
PE
5968 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5969
84acfcf0
PE
5970 Don't assume time_t can fit into int.
5971 * buffer.h (struct buffer.modtime): Now time_t, not int.
5972 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5973 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5974
ccd9a01a
PE
5975 Minor fixes for signed vs unsigned integers.
5976 * character.h (MAYBE_UNIFY_CHAR):
5977 * charset.c (maybe_unify_char):
5978 * keyboard.c (read_char, reorder_modifiers):
5979 XINT -> XFASTINT, since the integer must be nonnegative.
5980 * ftfont.c (ftfont_spec_pattern):
5981 * keymap.c (access_keymap, silly_event_symbol_error):
5982 XUINT -> XFASTINT, since the integer must be nonnegative.
5983 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5984 since it makes no difference and we prefer signed.
5985 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5986 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5987 nonnegative.
5988
d6d100dd
SM
59892011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5990
5991 * window.h (Fwindow_frame): Declare.
5992
2b6148e4
PE
59932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5994
5995 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5996 (SPARE_MEMORY): Always define.
5997 (LARGE_REQUEST): Remove.
5998 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5999
f230ecc9
MR
60002011-06-06 Martin Rudalics <rudalics@gmx.at>
6001
727e958e
MR
6002 * lisp.h: Move EXFUNS for Fframe_root_window,
6003 Fframe_first_window and Fset_frame_selected_window to window.h.
6004
6005 * window.h: Move EXFUNS for Fframe_root_window,
6006 Fframe_first_window and Fset_frame_selected_window here from
6007 lisp.h.
6008
6009 * frame.c (Fwindow_frame, Fframe_first_window)
6010 (Fframe_root_window, Fframe_selected_window)
6011 (Fset_frame_selected_window): Move to window.c.
6012 (Factive_minibuffer_window): Move to minibuf.c.
6013 (Fother_visible_frames_p): New function.
6014
6015 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6016
f230ecc9
MR
6017 * window.c (decode_window, decode_any_window): Move up in code.
6018 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6019 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6020 (Fwindow_buffer): Move up and rewrite doc-string.
6021 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6022 (Fwindow_prev): New functions.
727e958e
MR
6023 (Fwindow_frame): Move here from frame.c. Accept any window as
6024 argument.
6025 (Fframe_root_window, Fframe_first_window)
6026 (Fframe_selected_window): Move here from frame.c. Accept frame
6027 or arbitrary window as argument. Update doc-strings.
6028 (Fminibuffer_window): Move up in code.
6029 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6030 (Fset_frame_selected_window): Move here from frame.c.
6031 Marginal rewrite.
727e958e
MR
6032 (Fselected_window, select_window, Fselect_window): Move up in
6033 code. Minor doc-string fixes.
f230ecc9 6034
4d09bcf6
PE
60352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6036
6037 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6038 Do not assume that spare memory exists; that assumption is valid
6039 only if SYSTEM_MALLOC.
6040 (LARGE_REQUEST): New macro, so that the issue of large requests
6041 is separated from the issue of spare memory.
6042
810928a2
AS
60432011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6044
172418ad
AS
6045 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6046 format. (Bug#8806)
6047
43f862f7
AS
6048 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6049
810928a2
AS
6050 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6051 before statements.
6052
a059fe24
JD
60532011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6054
6055 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6056
6057 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6058
6059 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6060 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6061
989bf368
JB
60622011-06-05 Juanma Barranquero <lekktu@gmail.com>
6063
6064 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6065
4b80f674
CY
60662011-06-04 Chong Yidong <cyd@stupidchicken.com>
6067
6068 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6069 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6070 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6071 New error handlers.
4b80f674
CY
6072 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6073 Obey Vx_select_enable_clipboard_manager. Catch errors in
6074 x_clipboard_manager_save (Bug#8779).
6075 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6076 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6077
99a33b77 60782011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6079
6080 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6081
99a33b77 60822011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6083
6084 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6085 in the current matrix if keep_current_p is non-zero.
6086
8264569d
EZ
60872011-06-04 Eli Zaretskii <eliz@gnu.org>
6088
6089 * bidi.c (bidi_level_of_next_char): Fix last change.
6090
57f97249
EZ
60912011-06-03 Eli Zaretskii <eliz@gnu.org>
6092
fec2107c 6093 Support bidi reordering of text covered by display properties.
57f97249 6094
fec2107c
EZ
6095 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6096 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6097 (bidi_cache_search, bidi_cache_iterator_state)
6098 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6099 (bidi_level_of_next_char, bidi_move_to_visually_next):
6100 Support character positions inside a run of characters covered by a
fec2107c
EZ
6101 display string.
6102 (bidi_paragraph_init, bidi_resolve_explicit_1)
6103 (bidi_level_of_next_char): Call bidi_fetch_char and
6104 bidi_fetch_char_advance instead of FETCH_CHAR and
6105 FETCH_CHAR_ADVANCE.
6106 (bidi_init_it): Initialize new members.
6107 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6108 definitions.
6109 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6110 instead of using explicit *_CHAR codes.
d6d100dd
SM
6111 (bidi_resolve_explicit, bidi_resolve_weak):
6112 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6113 bidirectional text is supported only in multibyte buffers.
6114 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6115 it to initialize the frame_window_p member of struct bidi_it.
6116 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6117 (bidi_resolve_explicit, bidi_resolve_weak)
6118 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6119 bidi_it->nchars is non-positive.
6120 (bidi_level_of_next_char): Don't try to lookup the cache for the
6121 next/previous character if nothing is cached there yet, or if we
6122 were just reseat()'ed to a new position.
c40e2fb2 6123
0e14fe90
EZ
6124 * xdisp.c (set_cursor_from_row): Set start and stop points
6125 according to the row's direction when priming the loop that looks
6126 for the glyph on which to display cursor.
6127 (single_display_spec_intangible_p): Function deleted.
6128 (display_prop_intangible_p): Reimplement to call
6129 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6130 Accept 3 additional arguments needed by handle_display_spec.
6131 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6132 values: lists, `(when COND...)' forms, etc.
6133 (single_display_spec_string_p): Support property values that are
6134 lists with the argument STRING its top-level element.
6135 (display_prop_string_p): Fix the condition for processing a
6136 property that is a list to be consistent with handle_display_spec.
fec2107c 6137 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6138 last portion of handle_display_prop.
6139 (compute_display_string_pos): Accept additional argument
6140 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6141 value of a `display' property is a "replacing spec".
6142 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6143 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6144 the display property, but just return a value indicating whether
6145 the display property will replace the characters it covers.
6146 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6147 frame_window_p members of struct bidi_it.
d6d100dd
SM
6148 (compute_display_string_pos, compute_display_string_end):
6149 New functions.
fec2107c
EZ
6150 (push_it): Accept second argument POSITION, where pop_it should
6151 jump to continue iteration.
6152 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6153
fec2107c
EZ
6154 * keyboard.c (adjust_point_for_property): Adjust the call to
6155 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6156
6157 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6158 (bidi_init_it): Update prototypes.
6159 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6160 (compute_display_string_pos, compute_display_string_end):
6161 Declare prototypes.
fec2107c
EZ
6162 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6163 EMACS_INT.
fc6f18ce 6164
40087514 61652011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6166
57f53182
PE
6167 Malloc failure behavior now depends on size of allocation.
6168 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6169 * lisp.h: Change signatures accordingly.
6170 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6171 All callers changed. (Bug#8762)
6172
6173 * gnutls.c: Use Emacs's memory allocators.
6174 Without this change, the gnutls library would invoke malloc etc.
6175 directly, which causes problems on non-SYNC_INPUT hosts, and which
6176 runs afoul of improving memory_full behavior. (Bug#8761)
6177 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6178 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6179 xfree instead of the default malloc, realloc, free.
6180 (Fgnutls_boot): No need to check for memory allocation failure,
6181 since xmalloc does that for us.
6182
ac32cd99 6183 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6184 * category.c (hash_get_category_set):
6185 * ccl.c (ccl_driver):
6186 * charset.c (Fdefine_charset_internal):
6187 * charset.h (struct charset.hash_index):
6188 * composite.c (get_composition_id, gstring_lookup_cache)
6189 (composition_gstring_put_cache):
6190 * composite.h (struct composition.hash_index):
6191 * dispextern.h (struct image.hash):
6192 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6193 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6194 (hashfn_equal, hashfn_user_defined, make_hash_table)
6195 (maybe_resize_hash_table, hash_lookup, hash_put)
6196 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6197 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6198 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6199 * image.c (make_image, search_image_cache, lookup_image)
6200 (xpm_put_color_table_h):
6201 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6202 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6203 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6204 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6205 * alloc.c (allocate_vectorlike):
6206 Check for overflow in vector size calculations.
6207 * ccl.c (ccl_driver):
6208 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6209 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6210 need to be updated by these changes.
40087514
PE
6211 * fns.c (make_hash_table, maybe_resize_hash_table):
6212 Check for integer overflow with large hash tables.
0de4bb68
PE
6213 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6214 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6215 (SXHASH_REDUCE): New macro.
6216 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6217 Use it instead of discarding useful hash info with large hash values.
6218 (sxhash_float): New function.
6219 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6220 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6221 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6222 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6223 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6224 Adjust signatures to match updated version of code.
6225 (consing_since_gc): Now EMACS_INT, since a single hash table can
6226 use more than INT_MAX bytes.
6227
698d32e2
DN
62282011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6229
6230 Make it possible to build with GCC-4.6+ -O2 -flto.
6231
6232 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6233
fd6fa53f
SM
62342011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6235
6236 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6237 Call minibuffer-inactive-mode.
6238
864db017
JB
62392011-05-31 Juanma Barranquero <lekktu@gmail.com>
6240
6241 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6242 Update dependencies.
6243
2ad0baf4
DN
62442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6245
6246 * data.c (init_data): Remove code for UTS, this system is not
6247 supported anymore.
6248
4fcc2638
DN
62492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6250
6251 Don't force ./temacs to start in terminal mode.
6252
6253 * frame.c (make_initial_frame): Initialize faces in all cases, not
6254 only when CANNOT_DUMP is defined.
6255 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6256
c56e0fd5
DN
62572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6258
6259 * dispnew.c (add_window_display_history): Use const for the string
6260 pointer. Remove declaration, not needed.
6261
333d54da 62622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6263
55d4c1b2 6264 Use 'inline', not 'INLINE'.
333d54da 6265 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6266 * alloc.c, fontset.c (INLINE): Remove.
6267 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6268 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6269 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6270 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6271 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6272
738db178
DN
62732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6274
6275 Make it possible to run ./temacs.
6276
6277 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6278 syms_of_callproc does the same thing. Remove test for
6279 "initialized", do it in the caller.
6280 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6281
620c53a6
SM
62822011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6283
6284 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6285 (read_minibuf): Use get_minibuffer.
6286 (syms_of_minibuf): Use DEFSYM.
6287 (Qmetadata): New var.
6288 * data.c (Qbuffer): Don't make it static.
6289 (syms_of_data): Use DEFSYM.
6290
e003a292
PE
62912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6292
6293 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6294 (CCL_CODE_MIN): New macro.
6295
ed008a6d
PE
62962011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6297
3687c2ef
PE
6298 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6299
ed008a6d
PE
6300 * eval.c (Qdebug): Now static.
6301 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6302 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6303 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6304
d66c4c7c
CY
63052011-05-29 Chong Yidong <cyd@stupidchicken.com>
6306
6307 * image.c: Various fixes to ImageMagick code comments.
6308 (Fimagemagick_types): Doc fix.
6309
5fbc2025
PE
63102011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6311
0196f88a
PE
6312 Minor fixes prompted by GCC 4.6.0 warnings.
6313
6314 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6315
5fbc2025
PE
6316 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6317 (x_clipboard_manager_save_all): Move extern decl to ...
6318 * xterm.h: ... here, so that it can be checked for consistency.
6319
1dd3c2d9
CY
63202011-05-29 Chong Yidong <cyd@stupidchicken.com>
6321
6322 * xselect.c (x_clipboard_manager_save_frame)
6323 (x_clipboard_manager_save_all): New functions.
6324 (Fx_clipboard_manager_save): Lisp function deleted.
6325
6326 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6327 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6328
6329 * xterm.h: Update prototype.
6330
5ba6571d
WX
63312011-05-28 William Xu <william.xwl@gmail.com>
6332
6333 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6334 exiting (Bug#8239).
6335
3eaff834
JM
63362011-05-28 Jim Meyering <meyering@redhat.com>
6337
e1900994 6338 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6339 * fns.c (to_uchar): Define.
6340 (crypto_hash_function): Use it to convert some newly-signed
6341 variables to unsigned, to avoid sign-extension bugs. For example,
6342 without this change, (md5 "truc") would evaluate to
6343 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6344 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6345 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6346
0f6990a7
PE
63472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6348
6349 Integer overflow fixes.
c8a9ca5a 6350
08686060
PE
6351 * dbusbind.c: Serial number integer overflow fixes.
6352 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6353 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6354 to hold a serial number that is too large for a fixnum.
6355 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6356 Check for serial numbers out of range. Decode any serial number
59568bf0 6357 that was so large that it became a float. (Bug#8722)
08686060 6358
2d1fc3c7
PE
6359 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6360 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6361 Use XFASTINT rather than XUINT when numbers are nonnegative.
6362 (xd_append_arg, Fdbus_method_return_internal):
6363 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6364 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6365 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6366 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6367 (Bug#8722)
2d1fc3c7 6368
c8a9ca5a
PE
6369 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6370
519e1d69
PE
6371 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6372
6df6ae42 6373 ccl: Add integer overflow checks.
30569699
PE
6374 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6375 (IN_INT_RANGE): New macros.
6376 (ccl_driver): Use them to check for integer overflow when
6377 decoding a CCL program. Many of the new checks are whether XINT (x)
6378 fits in int; it doesn't always, on 64-bit hosts. The new version
6379 doesn't catch all possible integer overflows, but it's an
847044ea 6380 improvement. (Bug#8719)
30569699 6381
c11285dc
PE
6382 * alloc.c (make_event_array): Use XINT, not XUINT.
6383 There's no need for unsigned here.
6384
fdccd48e
PE
6385 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6386 This follows up to the 2011-05-06 change that substituted uintptr_t
6387 for EMACS_INT. This case wasn't caught back then.
6388
37910ab2
PE
6389 Rework Fformat to avoid integer overflow issues.
6390 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6391 now (part of C89). Include <verify.h>.
6392 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6393 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6394 (Fformat): Avoid the prepass trying to compute sizes; it was only
6395 approximate and thus did not catch overflow reliably. Instead, walk
6396 through the format just once, formatting and computing sizes as we go,
6397 checking for integer overflow at every step, and allocating a larger
6398 buffer as needed. Keep track separately whether the format is
6399 multibyte. Keep only the most-recently calculated precision, rather
6400 than them all. Record whether each argument has been converted to
6401 string. Use EMACS_INT, not int, for byte and char and arg counts.
6402 Support field widths and precisions larger than INT_MAX. Avoid
6403 sprintf's undefined behavior with conversion specifications such as %#d
6404 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6405 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6406 formatting out-of-range floating point numbers with int
9173deec 6407 formats. (Bug#8668)
37910ab2 6408
2e6578fb
PE
6409 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6410
0ae6bdee
PE
6411 * data.c: Avoid integer truncation in expressions involving floats.
6412 * data.c: Include <intprops.h>.
6413 (arith_driver): When there's an integer overflow in an expression
6414 involving floating point, convert the integers to floating point
6415 so that the resulting value does not suffer from catastrophic
6416 integer truncation. For example, on a 64-bit host (* 4
6417 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6418 Do not rely on undefined behavior after integer overflow.
6419
de883a70
PE
6420 merge count_size_as_multibyte, parse_str_to_multibyte
6421 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6422 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6423 Check for integer overflow.
6424 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6425 since it's now a duplicate of the other. This is more of
6426 a character than a buffer op, so better that it's in character.c.
6427 * fns.c, print.c: Adjust to above changes.
6428
2ff916cb
PE
64292011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6430
6431 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6432
f1b54466
PE
64332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6434
fb1ac845
PE
6435 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6436 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6437 (x_clipboard_manager_save): Now static.
6438 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6439
f1b54466
PE
6440 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6441 (crypto_hash_function): Now static.
6442 Fix pointer signedness problems. Avoid unnecessary initializations.
6443
a9f737ee
CY
64442011-05-27 Chong Yidong <cyd@stupidchicken.com>
6445
6446 * termhooks.h (Vselection_alist): Make it terminal-local.
6447
6448 * terminal.c (create_terminal): Initialize it.
6449
6450 * xselect.c: Support for clipboard managers.
6451 (Vselection_alist): Move to termhooks.h as terminal-local var.
6452 (LOCAL_SELECTION): New macro.
6453 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6454 (symbol_to_x_atom): Remove gratuitous arg.
6455 (x_handle_selection_request, lisp_data_to_selection_data)
6456 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6457 (x_own_selection, x_get_local_selection, x_convert_selection):
6458 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6459 (some_frame_on_display): Delete unused function.
6460 (Fx_own_selection_internal, Fx_get_selection_internal)
6461 (Fx_disown_selection_internal, Fx_selection_owner_p)
6462 (Fx_selection_exists_p): New optional frame arg.
6463 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6464 (x_handle_selection_clear): Don't treat other terminals with the
6465 same keyboard specially. Use the terminal-local Vselection_alist.
6466 (x_clear_frame_selections): Use Frun_hook_with_args.
6467
6468 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6469
6470 * xterm.h: Add support for those atoms.
6471
e067f0c1
CY
64722011-05-26 Chong Yidong <cyd@stupidchicken.com>
6473
6474 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6475 (converted_selections, conversion_fail_tag): New global variables.
6476 (x_selection_request_lisp_error): Free the above.
6477 (x_get_local_selection): Remove unnecessary code.
6478 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6479 of converted selections stored in converted_selections.
6480 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6481 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6482 (x_convert_selection): New function.
6483 (x_handle_selection_event): Simplify.
6484 (x_get_foreign_selection): Don't ignore incoming requests while
6485 waiting for an answer; this will fail when we implement
6486 SAVE_TARGETS, and seems unnecessary anyway.
6487 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6488 (Vx_sent_selection_functions): Doc fix.
6489
0f4aebc0
LL
64902011-05-26 Leo Liu <sdl.web@gmail.com>
6491
6492 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6493
e61124cd
YM
64942011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6495
6496 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6497
6498 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6499 for fringe update if it has periodic bitmap.
ac389d0c 6500 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6501 and fringe_bitmap_periodic_p.
6502
6503 * fringe.c (get_fringe_bitmap_data): New function.
6504 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6505 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6506 row. Mark glyph row for fringe update if periodicity changed.
6507
6508 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6509 for fringe update unless it has periodic bitmap.
6510
f16d9837
KH
65112011-05-25 Kenichi Handa <handa@m17n.org>
6512
6513 * xdisp.c (get_next_display_element): Set correct it->face_id for
6514 a static composition.
6515
e1b90ef6
LL
65162011-05-24 Leo Liu <sdl.web@gmail.com>
6517
6518 * deps.mk (fns.o):
6519 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6520
6521 * fns.c (crypto_hash_function, Fsha1): New function.
6522 (Fmd5): Use crypto_hash_function.
6523 (syms_of_fns): Add Ssha1.
6524
7400048f
PE
65252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6526
6527 * gnutls.c: Remove unused macros.
6528 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6529 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6530 Remove macros that are defined and never used.
6531 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6532
abb71cf4
CY
65332011-05-22 Chong Yidong <cyd@stupidchicken.com>
6534
6535 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6536 (Fx_get_selection_internal): Minor cleanup.
6537 (Fx_own_selection_internal): Rename arguments for consistency with
6538 select.el.
6539
6307db39
PE
65402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6541
6542 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6543
f3d4e0a4
CY
65442011-05-22 Chong Yidong <cyd@stupidchicken.com>
6545
6546 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6547
4d8ade89
YM
65482011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6549
6550 * dispnew.c (scrolling_window): Don't exclude the case that the
6551 last enabled row in the desired matrix touches the bottom boundary.
6552
32078c8d
GM
65532011-05-21 Glenn Morris <rgm@gnu.org>
6554
6555 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6556 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6557 and add some more files.
32078c8d 6558
7285dc67
EZ
65592011-05-20 Eli Zaretskii <eliz@gnu.org>
6560
6561 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6562 report_file_error introduced by the change from 2011-05-07.
6563
89d1bd22
PE
65642011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6565
6566 * systime.h (Time): Define only if emacs is defined.
6567 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6568 where the include path doesn't have X11/X.h by default. See
6569 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6570
cd394be1 65712011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6572
6573 * composite.c (find_automatic_composition): Fix previous change.
6574
b9704ad9
GM
65752011-05-20 Glenn Morris <rgm@gnu.org>
6576
6577 * lisp.mk: New file, split from Makefile.in.
6578 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6579 (shortlisp): Remove.
6580 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6581
4a720484
GM
65822011-05-19 Glenn Morris <rgm@gnu.org>
6583
6584 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6585 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6586 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6587 (lisp): Set the order to that of loadup.el.
6588 (shortlisp): Make it a copy of $lisp.
6589 (SOME_MACHINE_LISP): Remove.
6590 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6591 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6592
a28d4396
KH
65932011-05-18 Kenichi Handa <handa@m17n.org>
6594
6595 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6596 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6597 (find_automatic_composition): Mostly rewrite for efficiency.
6598
a2b1fa8e
JB
65992011-05-18 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * makefile.w32-in: Update dependencies.
6602
8e1f5610
CS
66032011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6604
6605 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6606 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6607
7025ee00 66082011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6609
cdfa6eab
PE
6610 Fix some integer overflow issues, such as string length overflow.
6611
06d6db33
PE
6612 * insdel.c (count_size_as_multibyte): Check for string overflow.
6613
2b4560a8
PE
6614 * character.c (lisp_string_width): Check for string overflow.
6615 Use EMACS_INT, not int, for string indexes and lengths; in
6616 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6617 the resulting string length overflows an EMACS_INT; instead,
6618 report a string overflow if no precision given. When checking for
6619 precision exhaustion, use a check that cannot possibly have
6620 integer overflow. (Bug#8675)
6621 * character.h (lisp_string_width): Adjust to new signature.
6622
cb93f9be
PE
6623 * alloc.c (string_overflow): New function.
6624 (Fmake_string): Use it. This doesn't change behavior, but saves
6625 a few bytes and will simplify future changes.
6626 * character.c (string_escape_byte8): Likewise.
6627 * lisp.h (string_overflow): New decl.
6628
1a1f3366
PE
6629 Fixups, following up to the user-interface timestamp change.
6630 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6631 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6632 * msdos.c (mouse_get_pos): Likewise.
6633 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6634 * w32gui.h (Time): Define by including "systime.h" rather than by
6635 declaring it ourselves. (Bug#8664)
6636
d4e3e4d3
PE
6637 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6638 * image.c (clear_image_cache): Likewise.
6639
f6a24d19
PE
6640 * term.c (term_mouse_position): Don't assume time_t wraparound.
6641
08dc5ae6
PE
6642 Be more systematic about user-interface timestamps.
6643 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6644 and sometimes 'EMACS_UINT', to represent these timestamps.
6645 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6646 This makes the code easier to follow, and makes it easier to catch
6647 integer overflow bugs such as Bug#8664.
6648 * frame.c (Fmouse_position, Fmouse_pixel_position):
6649 Use Time, not unsigned long, for user-interface timestamps.
6650 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6651 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6652 * keyboard.h (last_event_timestamp): Likewise.
6653 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6654 * menu.h (xmenu_show): Likewise.
6655 * term.c (term_mouse_position): Likewise.
6656 * termhooks.h (struct input_event.timestamp): Likewise.
6657 (struct terminal.mouse_position_hook): Likewise.
6658 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6659 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6660 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6661 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6662 what it was before.
6663 * menu.h, termhooks.h: Include "systime.h", for Time.
6664
8e55734a
PE
6665 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6666 Don't assume that the difference between two unsigned long values
6667 can fit into an integer. At this point, we know button_down_time
6668 <= event->timestamp, so the difference must be nonnegative, so
6669 there's no need to cast the result if double-click-time is
6670 nonnegative, as it should be; check that it's nonnegative, just in
6671 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6672 apart (about 25 days). (Bug#8664)
8e55734a 6673
841f1b75 6674 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6675 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6676
3e26f69c
PE
6677 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6678 that always fit in int. Use a sentinel instead of a counter, to
6679 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6680 * frame.h (struct frame): Use int for menu_bar_items_used
6681 instead of EMACS_INT, since it always fits in int.
3e26f69c 6682
5cc152c0
PE
6683 * menu.c (grow_menu_items): Check for int overflow.
6684
d89eb65e
PE
6685 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6686
5235bd3e
PE
6687 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6688 Before, the code was not consistent. These values cannot exceed
6689 2**31 - 1 so there's no need to make them unsigned.
6690 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6691 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6692 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6693 as modifiers.
6694 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6695
bc827e23
PE
6696 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6697 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6698 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6699 presumably because the widths might not match.
6700
78eb494e
PE
6701 * window.c (size_window): Avoid needless test at loop start.
6702
04f2d78b
CB
67032011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6704
6705 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6706
d2fc7e3d 67072011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6708
6709 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6710
d2fc7e3d 67112011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6712
6713 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6714 `width' to `bar_area_x' and `bar_area_width', respectively.
6715 (x_scroll_run): Take account of fringe background extension.
6716
04f2d78b
CB
6717 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6718 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6719 `bar_area_width', respectively.
6720 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6721 background extension.
6722
79b70037
GM
67232011-05-10 Jim Meyering <meyering@redhat.com>
6724
6725 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6726
2f142cc5
JB
67272011-05-10 Juanma Barranquero <lekktu@gmail.com>
6728
6729 * image.c (Finit_image_library): Return t for built-in image types,
6730 like pbm and xbm. (Bug#8640)
6731
57679c86
AS
67322011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6733
6734 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6735
888c9e86
EZ
67362011-05-07 Eli Zaretskii <eliz@gnu.org>
6737
b0512a1d
EZ
6738 * w32console.c (Fset_screen_color): Doc fix.
6739 (Fget_screen_color): New function.
6740 (syms_of_ntterm): Defsubr it.
6741
7285dc67
EZ
6742 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6743 unlink the temporary file if Fcall_process didn't create it in the
6744 first place.
6745 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6746 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6747 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6748 cue to call_process_cleanup not to close that handle.
6749
4d3fcc8e
BK
67502011-05-07 Ben Key <bkey76@gmail.com>
6751
6752 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6753 one of two shell specific rules, either bootstrap-temacs-CMD or
6754 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6755 to the previous implementation of the bootstrap-temacs rule.
6756 The bootstrap-temacs-CMD rule is similar to the previous
6757 implementation of the bootstrap-temacs rule except that it
6758 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6759 variable.
6760
6761 These changes, along with some changes to nt/configure.bat,
6762 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6763 earlier fix to add support for --cflags and --ldflags options
6764 that include quotes so that it works whether make uses cmd or
6765 sh as the shell.
6766
b4289b64
MA
67672011-05-06 Michael Albinus <michael.albinus@gmx.de>
6768
6769 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6770 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6771 is a constant.
6772 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6773 a string. Handle both cases.
6774 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6775 (Fdbus_register_method): Use Qinvalid_function.
6776
af4c0e28
JB
67772011-05-06 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * makefile.w32-in: Update dependencies.
6780 (LISP_H): Add inttypes.h and stdin.h.
6781 (PROCESS_H): Add unistd.h.
6782
c51453d9
EZ
67832011-05-06 Eli Zaretskii <eliz@gnu.org>
6784
6785 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6786 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6787
8ff0ac3c 67882011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6789
4c4b566b
PE
6790 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6791
aab2b9b5
PE
6792 * term.c (vfatal): Remove stray call to va_end.
6793 It's not needed and the C Standard doesn't allow it here anyway.
6794
c378da0b
PE
6795 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6796 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6797
288b08c7
PE
6798 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6799 bytes.
6800
e3601888
PE
6801 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6802
db6c0e74
PE
6803 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6804
dd5963ea
PE
6805 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6806
88c9450f
PE
6807 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6808
2f9442b8
PE
6809 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6810
c032b5f8
PE
6811 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6812 * charset.c (Fdefine_charset_internal): Don't initialize
6813 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6814 32-bit int (Bug#8600).
a108c10b
PE
6815
6816 * lread.c (read_integer): Be more consistent with string-to-number.
6817 Use string_to_number to do the actual conversion; this avoids
6818 rounding errors and fixes some other screwups. Without this fix,
6819 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6820 (digit_to_number): Move earlier, for benefit of read_integer.
6821 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6822 not a digit in any supported base. (Bug#8602)
a108c10b 6823
ad5f9eea
PE
6824 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6825
aec1708a
PE
6826 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6827 to match comment at start of function. This also removes a
6828 GCC warning about overflow in a 32+64-bit port.
6829
47be4ab5
PE
6830 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6831
371cac43
PE
6832 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6833 Reported by Stefan Monnier in
6834 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6835 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6836 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6837
d01a7826
PE
6838 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6839 (EMACS_UINTPTR): Likewise, with uintptr_t.
6840
7fd47d5c
PE
6841 * lisp.h: Prefer 64-bit EMACS_INT if available.
6842 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6843 on 32-bit hosts that have 64-bit int, so that they can access
6844 large files.
122b0c86
PE
6845 However, temporarily disable this change unless the temporary
6846 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6847
8727937b
PE
6848 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6849
8ac068ac
PE
6850 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6851 This removes an assumption that EMACS_INT and long are the same
6852 width as pointers. The assumption is true for Emacs porting targets
6853 now, but we want to make other targets possible.
6854 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6855 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6856 In the rest of the code, change types of integers that hold casted
6857 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6858 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6859 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6860 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6861 No need to cast type when ORing.
6862 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6863 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6864 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6865 assume EMACS_INT is the same width as char *.
6866 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6867 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6868 Remove no-longer-needed casts.
6869 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6870 (xg_tool_bar_help_callback, xg_make_tool_item):
6871 Use EMACS_INTPTR to hold an integer
6872 that will be cast to void *; this can avoid a GCC warning
6873 if EMACS_INT is not the same width as void *.
6874 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6875 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6876 (current_message_1, set_message_1):
6877 Use a local to convert to proper width without a cast.
6878 * xmenu.c (dialog_selection_callback): Likewise.
6879
ede49d71
PE
6880 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6881 Also, don't assume VALBITS / RAND_BITS is less than 5,
6882 and don't rely on undefined behavior when shifting a 1 left into
6883 the sign bit.
6884 * lisp.h (get_random): Change signature to match.
6885
2f30ecd0
PE
6886 * lread.c (hash_string): Use size_t, not int, for hash computation.
6887 Normally we prefer signed values; but hashing is special, because
6888 it's better to use unsigned division on hash table sizes so that
6889 the remainder is nonnegative. Also, size_t is the natural width
6890 for hashing into memory. The previous code used 'int', which doesn't
6891 retain enough info to hash well into very large tables.
6892 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6893
2a866e7b
PE
6894 * dbusbind.c: Don't possibly lose pointer info when converting.
6895 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6896 Use XPNTR rather than XHASH, so that the high-order bits of
6897 the pointer aren't lost when converting through void *.
6898
51639eac
PE
6899 * eval.c (Fautoload): Don't double-shift a pointer.
6900
92394119
PE
6901 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6902
dbdb9a7c
JB
69032011-05-06 Juanma Barranquero <lekktu@gmail.com>
6904
6905 * gnutls.c (DEF_GNUTLS_FN):
6906 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6907
db7a0b4f
AS
69082011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6909
6910 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6911 marker. (Bug#8610)
6912
cd394be1 69132011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6914
6915 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6916 New version that can reserve upto 2GB of heap space.
6917
f7ff1b0f 69182011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6919
6920 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6921
639c109b
TZ
69222011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6923
6924 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6925 `gnutls_certificate_set_x509_key_file'.
6926
d2127135
JB
69272011-05-05 Juanma Barranquero <lekktu@gmail.com>
6928
6929 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6930 Update dependencies.
6931
e968f4f3
JB
69322011-05-04 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6935 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6936 Remove unused parameter `fildes'.
6937 * process.c (read_process_output, send_process): Don't pass it.
6938
84d358f0
JB
69392011-05-04 Juanma Barranquero <lekktu@gmail.com>
6940
6941 Fix previous change: the library cache is defined in w32.c.
6942 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6943 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6944
0898ca10
JB
69452011-05-04 Juanma Barranquero <lekktu@gmail.com>
6946
6947 Implement dynamic loading of GnuTLS on Windows.
6948
6949 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6950 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6951 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6952 Declare.
6953
6954 * gnutls.c (Qgnutls_dll): Define.
6955 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6956 (gnutls_*): Declare function pointers.
6957 (init_gnutls_functions): New function to initialize function pointers.
6958 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6959 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6960 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6961 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6962 (emacs_gnutls_write, emacs_gnutls_read)
6963 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6964 (Fgnutls_available_p): New function.
6965 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6966 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6967 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6968
6969 * image.c: Include w32.h.
6970 (Vimage_type_cache): Delete.
6971 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6972 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6973 (w32_delayed_load): Move to w32.c.
6974
6975 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6976
6977 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6978 (w32_delayed_load): Move from image.c. When loading a library, record
6979 its filename in the :loaded-from property of the library id.
6980 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6981 Initialize and staticpro them.
6982 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6983
6984 * process.c: Include lisp.h before w32.h, not after.
6985 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6986 instead of gnutls_record_check_pending.
6987
6988 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6989
ff4de4aa
TZ
69902011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6991
6992 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6993 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6994 as passed in.
6995
abe95abb
JD
69962011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6997
6998 * xterm.c (x_set_frame_alpha): Do not set property on anything
6999 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7000
e16e55d4
JB
70012011-05-02 Juanma Barranquero <lekktu@gmail.com>
7002
7003 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7004
bafcf6a5
JB
70052011-05-02 Juanma Barranquero <lekktu@gmail.com>
7006
7007 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7008 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7009 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7010 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7011 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7012 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7013 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7014 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7015 (Qgnutls_bootprop_callbacks_verify): Make static.
7016
e7a6747f
AS
70172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7018
19ed11ba
AS
7019 * callproc.c: Indentation fixup.
7020
e7a6747f 7021 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7022 (wait_for_termination, interruptible_wait_for_termination):
7023 Move after wait_for_termination_1.
e7a6747f 7024
1ef14cb4
LMI
70252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7026
7027 * sysdep.c (interruptible_wait_for_termination): New function
7028 which is like wait_for_termination, but allows keyboard
7029 interruptions.
7030
7031 * callproc.c (Fcall_process): Add (:file "file") as an option for
7032 the STDOUT buffer.
7033 (Fcall_process_region): Ditto.
7034
330d880c
EZ
70352011-04-30 Eli Zaretskii <eliz@gnu.org>
7036
8db90b73
EZ
7037 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7038 rather than `XVECTOR (FOO)->size'.
7039
330d880c
EZ
7040 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7041 inttypes.h, as a gnulib replacement is used if it not available in
7042 system headers.
7043
15cbd324
EZ
70442011-04-21 Eli Zaretskii <eliz@gnu.org>
7045
7046 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7047 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7048 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7049
7050 * coding.c (coding_alloc_by_realloc): Error out if destination
7051 will grow beyond MOST_POSITIVE_FIXNUM.
7052 (decode_coding_emacs_mule): Abort if there isn't enough place in
7053 charbuf for the composition carryover bytes. Reserve an extra
7054 space for up to 2 characters produced in a loop.
7055 (decode_coding_iso_2022): Abort if there isn't enough place in
7056 charbuf for the composition carryover bytes.
7057
70582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7059
ae940cca
EZ
7060 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7061 aborting when %lld or %lll format is passed.
7062 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7063 %llo or %llx format is passed. (Bug#8545)
7064
03ab8921
EZ
7065 * window.c (window_scroll_line_based): Use a marker instead of
7066 simple variables to record original value of point. (Bug#7952)
7067
afda1437
EZ
7068 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7069 produced by %s or %c overflows available buffer space. (Bug#8545)
7070
f76dee0c
PE
70712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7072
7073 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7074 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7075
fdc5744d
JB
70762011-04-28 Juanma Barranquero <lekktu@gmail.com>
7077
7078 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7079
638f053a
JB
70802011-04-28 Juanma Barranquero <lekktu@gmail.com>
7081
7082 * keyboard.c (Qdelayed_warnings_hook): Define.
7083 (command_loop_1): Run `delayed-warnings-hook'
7084 if Vdelayed_warnings_list is non-nil.
7085 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7086 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7087
d178f871
EZ
70882011-04-28 Eli Zaretskii <eliz@gnu.org>
7089
7090 * doprnt.c (doprnt): Don't return value smaller than the buffer
7091 size if the message was truncated. (Bug#8545).
7092
b124fd93
JB
70932011-04-28 Juanma Barranquero <lekktu@gmail.com>
7094
7095 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7096 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7097
e810457d
PE
70982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7099
7100 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7101
ea51cceb
JB
71022011-04-27 Juanma Barranquero <lekktu@gmail.com>
7103
7104 * makefile.w32-in: Update dependencies.
7105
94dcfacf
EZ
71062011-04-27 Eli Zaretskii <eliz@gnu.org>
7107
7108 Improve `doprnt' and its usage. (Bug#8545)
7109 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7110 `format_end'. Remove support for %l as a conversion specifier.
7111 Don't use xrealloc. Improve diagnostics when the %l size modifier
7112 is used. Update the commentary.
7113
7114 * eval.c (verror): Simplify calculation of size_t.
7115
7116 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7117 messages.
7118
f61f41d7
PE
71192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7120
7121 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7122 change.
7123
96fb4434
PE
71242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7125
7126 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7127 This makes this file independent of the recent pseudovector change.
7128
671875da 71292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7130
69e9b5a3
PE
7131 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7132
b5f869a7 7133 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7134 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7135 Remove unused local.
c8926152 7136 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7137
841a1577 7138 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7139 GCC 4.6.0 optimizes based on type-based alias analysis.
7140 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7141 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7142 != &v->size, and therefore "v->size = 1; b->size = 2; return
7143 v->size;" must therefore return 1. This assumption is incorrect
7144 for Emacs, since it type-puns struct Lisp_Vector * with many other
7145 types. To fix this problem, this patch adds a new type struct
f904488f 7146 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7147 and pseudovectors, and helps optimizing compilers not get fooled
7148 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7149 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7150 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7151 the size member.
eab3844f
PE
7152 (XSETPVECTYPE): Rewrite in terms of new macro.
7153 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7154 This is a bit clearer, and further avoids the possibility of
7155 undesirable aliasing.
7156 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7157 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7158 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7159 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7160 (ASIZE): Now uses header.size rather than size.
7161 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7162 to avoid the hassle of writing XVECTOR (foo)->header.size.
7163 (struct vectorlike_header): New type.
eab3844f
PE
7164 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7165 object, to help avoid aliasing.
7166 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7167 (SUBRP): Likewise, since Lisp_Subr is a special case.
7168 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7169 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7170 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7171 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7172 changed to be "header.size" and "header.next".
7173 * buffer.h (struct buffer): Likewise.
7174 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7175 * frame.h (struct frame): Likewise.
7176 * process.h (struct Lisp_Process): Likewise.
7177 * termhooks.h (struct terminal): Likewise.
7178 * window.c (struct save_window_data, struct saved_window): Likewise.
7179 * window.h (struct window): Likewise.
7180 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7181 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7182 * buffer.c (init_buffer_once): Likewise.
7183 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7184 special case.
7185 * process.c (Fformat_network_address): Use local var for size,
7186 for brevity.
7187
0df1eac5
PE
7188 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7189
847ab9d1 7190 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7191 * data.c (atof): Remove decl; no longer used or needed.
7192 (digit_to_number): Move to lread.c.
7193 (Fstring_to_number): Use new string_to_number function, to be
7194 consistent with how the Lisp reader treats infinities and NaNs.
7195 Do not assume that floating-point numbers represent EMACS_INT
7196 without losing information; this is not true on most 64-bit hosts.
7197 Avoid double-rounding errors, by insisting on integers when
7198 parsing non-base-10 numbers, as the documentation specifies.
7199 * lisp.h (string_to_number): New decl, replacing ...
7200 (isfloat_string): Remove.
bc0a5c13 7201 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7202 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7203 appears to have been a coding error. Similarly, do not accept
7204 strings like +-1e0 as floating point numbers. Do not report
7205 overflow for integer overflows unless the base is not 10 which
7206 means we have no simple and reliable way to continue.
7207 Break out the floating-point parsing into a new
7208 function string_to_number, so that Fstring_to_number parses
7209 floating point numbers consistently with the Lisp reader.
04f2d78b 7210 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7211 (E_CHAR, EXP_INT): Remove, replacing with ...
7212 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7213 (string_to_number): New function, replacing isfloat_string.
7214 This function checks for valid syntax and produces the resulting
7215 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7216 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7217 so that overflow for non-base-10 numbers is reported only when
7218 there's no portable and simple way to convert to floating point.
452f4150 7219
67769ffc
PE
7220 * textprop.c (set_text_properties_1): Rewrite for clarity,
7221 and to avoid GCC warning about integer overflow.
7222
c20db43f
PE
7223 * intervals.h (struct interval): Use EMACS_INT for members
7224 where EMACS_UINT might cause problems. See
7225 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7226 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7227 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7228 All uses changed.
37aa2f85
PE
7229 (offset_intervals): Tell GCC not to worry about length overflow
7230 when negating a negative length.
c20db43f 7231
2538aa2f
PE
7232 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7233 (overrun_check_free): Likewise.
7234
f2d3008d
PE
7235 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7236 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7237 word size.
7238
ec8df744
PE
7239 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7240 (gnutls_make_error): Rename local to avoid shadowing.
7241 (gnutls_emacs_global_deinit): ifdef out; not used.
7242 (Fgnutls_boot): Use const for pointer to readonly storage.
7243 Comment out unused local. Fix pointer signedness problems.
7244
640ee02d
PE
7245 * lread.c (openp): Don't stuff size_t into an 'int'.
7246 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7247 about possible signed overflow.
7248
6048fb2a
PE
7249 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7250 (GDK_KEY_g): Don't define if already defined.
7251 (xg_prepare_tooltip): Avoid pointer signedness problem.
7252 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7253
fa3c87e1
PE
7254 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7255 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7256
2172544b
PE
7257 * xfns.c (Fx_window_property): Simplify a bit,
7258 to make a bit faster and to avoid GCC 4.6.0 warning.
7259 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7260
9b821a21
PE
7261 * fns.c (internal_equal): Don't assume size_t fits in int.
7262
3c616cfa
PE
7263 * alloc.c (compact_small_strings): Tighten assertion a little.
7264
c2982e87
PE
7265 Replace pEd with more-general pI, and fix some printf arg casts.
7266 * lisp.h (pI): New macro, generalizing old pEd macro to other
7267 conversion specifiers. For example, use "...%"pI"d..." rather
7268 than "...%"pEd"...".
7269 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7270 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7271 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7272 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7273 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7274 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7275 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7276 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7277 64-bit hosts.
7278 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7279 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7280 * print.c (safe_debug_print, print_object): Likewise.
7281 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7282 to int.
6f04d126
PE
7283 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7284 avoiding the 0 flag, which is not portable.
c2982e87
PE
7285 * process.c (Fmake_network_process): Use pI to avoid cast.
7286 * region-cache.c (pp_cache): Likewise.
7287 * xdisp.c (decode_mode_spec): Likewise.
7288 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7289 behavior on 64-bit hosts with printf arg.
6f04d126 7290 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7291 (x_stop_queuing_selection_requests): Likewise.
7292 (x_get_window_property): Don't truncate byte count to an 'int'
7293 when tracing.
0b432f21 7294
5e073ec7
PE
7295 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7296 here, since it parses constructs like leading '-' and spaces,
7297 which are not wanted; and it overflows with large numbers.
7298 Instead, simply match F[0-9]+, which is what is wanted anyway.
7299
36372bf9
PE
7300 * alloc.c: Remove unportable assumptions about struct layout.
7301 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7302 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7303 (allocate_vectorlike, make_pure_vector): Use the new macros,
7304 plus offsetof, to remove unportable assumptions about struct layout.
7305 These assumptions hold on all porting targets that I know of, but
7306 they are not guaranteed, they're easy to remove, and removing them
7307 makes further changes easier.
7308
0b432f21
PE
7309 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7310 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7311 (string_overrun_cookie): Now const. Use initializers that
7312 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7313 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7314 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7315 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7316 multiple of sizeof (EMACS_INT); it need not be, if
7317 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7318 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7319
895009e1
JB
73202011-04-26 Juanma Barranquero <lekktu@gmail.com>
7321
7322 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7323
6a7a1b0b
TZ
73242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7325
7326 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7327 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7328 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7329
841a1577 73302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7331
7332 * lisp.h (Qdebug): List symbol.
895009e1 7333 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7334 * keyboard.c (debug-on-event): New variable.
7335 (handle_user_signal): Break into debugger when debug-on-event
7336 matches the current signal symbol.
7337
f2d3ba6f
DN
73382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7339
7340 * alloc.c (check_sblock, check_string_bytes)
7341 (check_string_free_list): Convert to standard C.
7342
42ce4c63
TZ
73432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7344
7345 * w32.c (emacs_gnutls_push): Fix typo.
7346
825cd63c
EZ
73472011-04-25 Eli Zaretskii <eliz@gnu.org>
7348
fb11d64d
EZ
7349 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7350 "cast to pointer from integer of different size".
7351
825cd63c
EZ
7352 Improve doprnt and its use in verror. (Bug#8545)
7353 * doprnt.c (doprnt): Document the set of format control sequences
7354 supported by the function. Use SAFE_ALLOCA instead of always
7355 using `alloca'.
7356
7357 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7358 is one byte too soon. Don't use xrealloc; instead xfree and
7359 xmalloc anew.
7360
e061a11b
TZ
73612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7362
7363 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7364 callbacks stage.
7365
7366 * gnutls.c: Renamed global_initialized to
7367 gnutls_global_initialized. Added internals for the
7368 :verify-hostname-error, :verify-error, and :verify-flags
7369 parameters of `gnutls-boot' and documented those parameters in the
7370 docstring. Start callback support.
9173deec
JB
7371 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7372 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7373 on error. Return error code.
e061a11b
TZ
7374 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7375 (emacs_gnutls_read): Likewise.
7376 (Fgnutls_boot): Return handshake error code.
7377 (emacs_gnutls_handle_error): New function.
7378 (wsaerror_to_errno): Likewise.
7379
7380 * w32.h (emacs_gnutls_pull): Add prototype.
7381 (emacs_gnutls_push): Likewise.
7382
7383 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7384 (emacs_gnutls_push): Likewise.
7385
73862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7387
7388 * process.c (wait_reading_process_output): Check if GnuTLS
7389 buffered some data internally if no FDs are set for TLS
7390 connections.
7391
7392 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7393 (LIBS): Link to USER_LIBS.
7394 ($(BLD)/gnutls.$(0)): New target.
7395
fa6996bc
EZ
73962011-04-24 Eli Zaretskii <eliz@gnu.org>
7397
eb35682e
EZ
7398 * xdisp.c (handle_single_display_spec): Rename the
7399 display_replaced_before_p argument into display_replaced_p, to
7400 make it consistent with the commentary. Fix typos in the
7401 commentary.
7402
e2ad650c
EZ
7403 * textprop.c (syms_of_textprop): Remove dead code.
7404 (copy_text_properties): Delete obsolete commentary about an
7405 interface that was deleted long ago. Fix typos in the description
7406 of arguments.
7407
1b2de274
EZ
7408 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7409 to changes in oldXMenu/XMenu.h from 2011-04-16.
7410 <menu_help_message, prev_menu_help_message>: Constify.
7411 (IT_menu_make_room): menu->help_text is now `const char **';
7412 adjust.
7413
7414 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7415 to changes in oldXMenu/XMenu.h from 2011-04-16.
7416 (struct XMenu): Declare `help_text' `const char **'.
7417
7418 * xfaces.c <Qunspecified>: Make extern again.
7419
7420 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7421 required by POSIX.
1b2de274 7422
762b15be
EZ
7423 * doc.c (get_doc_string): Improve the format passed to `error'.
7424
7425 * doprnt.c (doprnt): Improve commentary.
7426
7427 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7428
7429 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7430 them with etags.
7431
f1052e5d
EZ
7432 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7433 changes in globals.h immediately force recompilation.
762b15be
EZ
7434 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7435 $(CURDIR)/s/ms-w32.h.
7436 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7437
fa6996bc
EZ
7438 * character.c (Fchar_direction): Function deleted.
7439 (syms_of_character): Don't defsubr it.
7440 <char-direction-table>: Deleted.
7441
e6c3da20
EZ
74422011-04-23 Eli Zaretskii <eliz@gnu.org>
7443
7444 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7445 * doprnt.c: Include limits.h.
7446 (SIZE_MAX): New macro.
04f2d78b
CB
7447 (doprnt): Return a size_t value. 2nd arg is now size_t.
7448 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7449 Improve overflow protection. Support `l' modifier for integer
7450 conversions. Support %l conversion. Don't assume an EMACS_INT
7451 argument for integer conversions and for %c.
7452
7453 * lisp.h (doprnt): Restore prototype.
7454
7455 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7456 $(SRC)/character.h.
7457
7458 * Makefile.in (base_obj): Add back doprnt.o.
7459
7460 * deps.mk (doprnt.o): Add back prerequisites.
7461 (callint.o): Depend on character.h.
7462
7463 * eval.c (internal_lisp_condition_case): Include the handler
7464 representation in the error message.
7465 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7466 when breaking from the loop.
7467
7468 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7469
7470 * callint.c (Fcall_interactively): When displaying error message
7471 about invalid control letter, pass the character's codepoint, not
7472 a pointer to its multibyte form. Improve display of the character
7473 in octal and display also its hex code.
7474
7475 * character.c (char_string): Use %x to display the (unsigned)
7476 codepoint of an invalid character, to avoid displaying a bogus
7477 negative value.
7478
7479 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7480 `error', not SYMBOL_NAME itself.
7481
7482 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7483 character arguments to `error'.
7484
7485 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7486 to `error' in error message about FINAL_CHAR argument. Make sure
7487 FINAL_CHAR is a character, and use %c when it is passed as
7488 argument to `error'.
7489
4ffd0d6b 74902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7491
7492 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7493
7494 * w32.c: Include <time.h>.
7495 (sys_localtime): New function.
7496
4ffd0d6b 74972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7498
7499 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7500
4ffd0d6b 7501 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7502
4ffd0d6b 75032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7504
4ffd0d6b
GM
7505 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7506 zombies (Bug#8467).
aac0c6e3 7507
04c56954
EZ
75082011-04-19 Eli Zaretskii <eliz@gnu.org>
7509
7510 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7511 gl_state.e_property when gl_state.object is Qt.
7512
7513 * insdel.c (make_gap_larger): Remove limitation of buffer size
7514 to <= INT_MAX.
7515
16a43933
CY
75162011-04-18 Chong Yidong <cyd@stupidchicken.com>
7517
7518 * xdisp.c (lookup_glyphless_char_display)
7519 (produce_glyphless_glyph): Handle cons cell entry in
7520 glyphless-char-display.
7521 (Vglyphless_char_display): Document it.
7522
7523 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7524 glyphless-char-display.
7525
4581706e
CY
75262011-04-17 Chong Yidong <cyd@stupidchicken.com>
7527
7528 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7529
7530 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7531
7532 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7533 definition for no-X builds.
7534
4887c6e2 75352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7536
fd35b6f9
PE
7537 Static checks with GCC 4.6.0 and non-default toolkits.
7538
5c1ccb01
PE
7539 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7540
006c5daa
PE
7541 * process.c (keyboard_bit_set): Define only if SIGIO.
7542 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7543 (send_process): Repair possible setjmp clobbering.
7544
efc736d3
PE
7545 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7546
4e2fe2e6
PE
7547 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7548
f97334a2
PE
7549 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7550
4e75f29d
PE
7551 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7552 Define only if needed.
7553
90efadd1
PE
7554 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7555 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7556 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7557
3c647824
PE
7558 * dispextern.h (struct redisplay_interface): Rename param
7559 to avoid shadowing.
e264f262 7560 * termhooks.h (struct terminal): Likewise.
761383f4 7561 * xterm.c (xembed_send_message): Likewise.
3c647824 7562
b58c5c4a
PE
7563 * insdel.c (make_gap_smaller): Define only if
7564 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7565
cad59032
PE
7566 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7567 it.
7568
c339dc2e
PE
7569 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7570 so that we aren't warned about unused symbols.
7571
91a3e27b
PE
7572 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7573
399c71d3 7574 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7575
8ffc96f5
PE
7576 * xfns.c (x_real_positions): Mark locals as initialized.
7577
eef9bc79
PE
7578 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7579
098db9dd
PE
7580 * xterm.c: Fix problems found by static analysis with other toolkits.
7581 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7582 (x_dispatch_event): Declare static if USE_GTK, and
7583 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7584 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7585 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7586 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7587 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7588
eb18f6cc
PE
7589 * xmenu.c (menu_help_callback): Pointer type fixes.
7590 Use const pointers when pointing at readonly data. Avoid pointer
7591 signedness clashes.
7592 (FALSE): Remove unused macro.
7593 (update_frame_menubar): Remove unused decl.
7594
1fe72bf8
PE
7595 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7596
60d9e1db
PE
7597 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7598 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7599 (single_menu_item): Rename local to avoid shadowing.
7600
39261c26
PE
7601 * keyboard.c (make_lispy_event): Remove unused local var.
7602
018c5e19
PE
7603 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7604 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7605
63d2b86e
PE
7606 * bitmaps: Change bitmaps from unsigned char back to the X11
7607 compatible char. Avoid the old compiler warnings about
7608 out-of-range initializers by using, for example, '\xab' rather
7609 than 0xab.
7610
aefd87e1
PE
7611 * xgselect.c (xgselect_initialize): Check vs interface
7612 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7613
bf501fb9
PE
7614 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7615
e9829fdf
PE
7616 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7617 to read-only memory.
7618
1086c095
PE
7619 * fns.c (vector): Remove; this old hack is no longer needed.
7620
2baccd04 7621 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7622 Remove unused var.
dde42981 7623 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7624
72391843 7625 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7626
436c16df 7627 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7628 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7629 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7630
92bb796d 7631 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7632 (x_term_init): Remove local to avoid shadowing.
92bb796d 7633
764430a3 7634 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7635
7636 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7637 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7638
d1dfb56c
EZ
76392011-04-16 Eli Zaretskii <eliz@gnu.org>
7640
c4354cb4
EZ
7641 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7642
d1dfb56c
EZ
7643 Fix regex.c, syntax.c and friends for buffers > 2GB.
7644 * syntax.h (struct gl_state_s): Declare character position members
7645 EMACS_INT.
7646
7647 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7648
04f2d78b
CB
7649 * textprop.c (verify_interval_modification, interval_of):
7650 Declare arguments EMACS_INT.
d1dfb56c
EZ
7651
7652 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7653 EMACS_INT.
7654
7655 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7656
7657 * indent.c (Fvertical_motion): Local variable it_start is now
7658 EMACS_INT.
7659
7660 * regex.c (re_match, re_match_2, re_match_2_internal)
7661 (bcmp_translate, regcomp, regexec, print_double_string)
7662 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7663 (re_compile_pattern, re_exec): Declare arguments and local
7664 variables `size_t' and `ssize_t' and return values `regoff_t', as
7665 appropriate.
7666 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7667 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7668 <compile_stack_type>: `size' and `avail' are now `size_t'.
7669
7670 * regex.h <regoff_t>: Use ssize_t, not int.
7671 (re_search, re_search_2, re_match, re_match_2): Arguments that
7672 specify buffer/string position and length are now ssize_t and
7673 size_t. Return type is regoff_t.
7674
613052cd
BK
76752011-04-16 Ben Key <bkey76@gmail.com>
7676
7677 * nsfont.m: Fixed bugs in ns_get_family and
7678 ns_descriptor_to_entity that were caused by using free to
7679 deallocate memory blocks that were allocated by xmalloc (via
7680 xstrdup). This caused Emacs to crash when compiled with
7681 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7682 --enable-checking=xmallocoverrun). xfree is now used to
7683 deallocate these memory blocks.
7684
4170f62f 76852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7686
71b41406
PE
7687 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7688
9587a89d
PE
7689 emacs_write: Accept and return EMACS_INT for sizes.
7690 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7691 et seq.
7692 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7693 Accept and return EMACS_INT.
7694 (emacs_gnutls_write): Return the number of bytes written on
7695 partial writes.
7696 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7697 (emacs_read, emacs_write): Remove check for negative size, as the
7698 Emacs source code has been audited now.
9587a89d
PE
7699 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7700 (emacs_read, emacs_write): Use it.
273a5f82
PE
7701 * process.c (send_process): Adjust to the new signatures of
7702 emacs_write and emacs_gnutls_write. Do not attempt to store
7703 a byte offset into an 'int'; it might overflow.
9587a89d 7704 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7705
3e047f51
PE
7706 * sound.c: Don't assume sizes fit in 'int'.
7707 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7708 Return EMACS_INT, not int.
3e047f51 7709 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7710 Accept EMACS_INT, not int.
7711 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7712 record read return values.
7713
cc39a9db
BK
77142011-04-15 Ben Key <bkey76@gmail.com>
7715
c9d0ec6d
JB
7716 * keyboard.c (Qundefined): Don't declare static since it is used
7717 in nsfns.m.
7718 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7719 static since they are used in nsfont.m.
cc39a9db 7720
6c60eb9f
SM
77212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7722
7723 * process.c (Qprocessp): Don't declare static.
7724 * lisp.h (Qprocessp): Declare again.
7725
7990b61a
JB
77262011-04-15 Juanma Barranquero <lekktu@gmail.com>
7727
7728 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7729
5d4cb038
PE
77302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7731
8bd7b830 7732 Improve C-level modularity by making more things 'static'.
cd64ea1d 7733
e3b27b31
PE
7734 Don't publish debugger-only interfaces to other modules.
7735 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7736 (verify_bytepos, count_markers): Move decls to the only modules
7737 that need them.
7738 * region-cache.h (pp_cache): Likewise.
7739 * window.h (check_all_windows): Likewise.
7740 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7741
5d4cb038
PE
7742 * sysdep.c (croak): Now static, if
7743 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7744 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7745
7746 * alloc.c (refill_memory_reserve): Now static if
7747 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7748 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7749
e87b6180
PE
7750 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7751 Define only if USE_LUCID.
7752
ac64929e
PE
7753 * xrdb.c (x_customization_string, x_rm_string): Now static.
7754
6f37259d
PE
7755 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7756 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7757
1683e3ab
PE
7758 * xdisp.c (draw_row_with_mouse_face): Now static.
7759 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7760
de9c2632
PE
7761 * window.h (check_all_windows): Mark externally visible.
7762
2b96acb7
PE
7763 * window.c (window_deletion_count): Now static.
7764
7765 * undo.c: Make symbols static if they're not exported.
7766 (last_undo_buffer, last_boundary_position, pending_boundary):
7767 Now static.
7768
50436f33
PE
7769 * textprop.c (interval_insert_behind_hooks): Now static.
7770 (interval_insert_in_front_hooks): Likewise.
7771
64520e5c
PE
7772 * term.c: Make symbols static if they're not exported.
7773 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7774 (max_frame_lines, tty_set_terminal_modes):
7775 (tty_reset_terminal_modes, tty_turn_off_highlight):
7776 (get_tty_terminal): Now static.
7777 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7778 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7779 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7780 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7781 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7782
1fa53021
PE
7783 * sysdep.c: Make symbols static if they're not exported.
7784 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7785 Now static.
7786 (sigprocmask_set, full_mask): Remove; unused.
7787 (wait_debugging): Mark as visible.
7788 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7789 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7790
d4b43b22
PE
7791 * syntax.c (syntax_temp): Define only if !__GNUC__.
7792
b7c513d0
PE
7793 * sound.c (current_sound_device, current_sound): Now static.
7794
989b29ad
PE
7795 * search.c (searchbufs, searchbuf_head): Now static.
7796
13a55a78
PE
7797 * scroll.c (scroll_cost): Remove; unused.
7798 * dispextern.h (scroll_cost): Remove decl.
7799
de68a1fc
PE
7800 * region-cache.h (pp_cache): Mark as externally visible.
7801
40ccffa6
PE
7802 * process.c: Make symbols static if they're not exported.
7803 (process_tick, update_tick, create_process, chan_process):
7804 (Vprocess_alist, proc_buffered_char, datagram_access):
7805 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7806 (deactivate_process): Mark defn as static, as well as decl.
7807 * lisp.h (create_process): Remove decl.
7808 * process.h (chan_process, Vprocess_alist): Remove decls.
7809
ad64fc97
PE
7810 * print.c: Make symbols static if they're not exported.
7811 (print_depth, new_backquote_output, being_printed, print_buffer):
7812 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7813 (print_interval, print_number_index, initial_stderr_stream):
7814 Now static.
7815 * lisp.h (Fprinc): Remove decl.
7816 (debug_output_compilation_hack): Mark as externally visible.
7817
adddb265
PE
7818 * sysdep.c (croak): Move decl from here to syssignal.h.
7819 * syssignal.h (croak): Put it here, so the API can be checked when
7820 'croak' is called from dissociate_if_controlling_tty.
7821
1717ede2
PE
7822 * minibuf.c: Make symbols static if they're not exported.
7823 (minibuf_save_list, choose_minibuf_frame): Now static.
7824 * lisp.h (choose_minibuf_frame): Remove decl.
7825
fa5fb2bc
PE
7826 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7827
1e3890d1
PE
7828 * lread.c: Make symbols static if they're not exported.
7829 (read_objects, initial_obarray, oblookup_last_bucket_number):
7830 Now static.
7831 (make_symbol): Remove; unused.
7832 * lisp.h (initial_obarray, make_symbol): Remove decls.
7833
8a1414fa
PE
7834 * keyboard.c: Make symbols static if they're not exported.
7835 (single_kboard, recent_keys_index, total_keys, recent_keys):
7836 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7837 (this_single_command_key_start, echoing, last_auto_save):
7838 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7839 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7840 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7841 (Vlispy_mouse_stem, double_click_count):
7842 Now static.
7843 (force_auto_save_soon): Define only if SIGDANGER.
7844 (ignore_mouse_drag_p): Now static if
7845 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7846 (print_help): Remove; unused.
7847 (stop_character, last_timer_event): Mark as externally visible.
7848 * keyboard.h (ignore_mouse_drag_p): Declare only if
7849 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7850 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7851 * lisp.h (echoing): Remove decl.
7852 (force_auto_save_soon): Declare only if SIGDANGER.
7853 * xdisp.c (redisplay_window): Simplify code, to make it more
7854 obvious that ignore_mouse_drag_p is not accessed if !defined
7855 USE_GTK && !defined HAVE_NS.
7856
93ea6e8f
PE
7857 * intervals.c: Make symbols static if they're not exported.
7858 (merge_properties_sticky, merge_interval_right, delete_interval):
7859 Now static.
7860 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7861
77382fcc
PE
7862 * insdel.c: Make symbols static if they're not exported.
7863 However, leave prepare_to_modify_buffer alone. It's never
7864 called from outside this function, but that appears to be a bug.
7865 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7866 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7867 (adjust_after_replace_noundo): Remove; unused.
7868 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7869 (signal_before_change): Remove decls.
77382fcc 7870
9306c32e
PE
7871 * indent.c (val_compute_motion, val_vmotion): Now static.
7872
cd44d2eb
PE
7873 * image.c: Make symbols static if they're not exported.
7874 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7875 if USE_GTK.
7876 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7877 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7878
ad9a7a06
PE
7879 * fringe.c (standard_bitmaps): Now static.
7880 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7881
81626931
PE
7882 * frame.c: Make symbols static if they're not exported.
7883 (x_report_frame_params, make_terminal_frame): Now static.
7884 (get_frame_param): Now static, unless HAVE_NS.
7885 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7886 (x_get_resource_string): Remove; not used.
7887 * frame.h (make_terminal_frame, x_report_frame_params):
7888 (x_get_resource_string); Remove decls.
7889 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7890 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7891
239f9db9
PE
7892 * font.c, fontset.c: Make symbols static if they're not exported.
7893 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7894 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7895 * font.c (font_close_object): Now static.
7896 * font.h (font_close_object): Remove.
7897 * fontset.c (FONTSET_OBJLIST): Remove.
7898 (free_realized_fontset) #if-0 the body, which does nothing.
7899 (face_suitable_for_char_p): #if-0, as it's never called.
7900 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7901 * xfaces.c (face_at_string_position):
7902 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7903 since 0 is always ASCII.
7904
dfcf3579
PE
7905 * fns.c (weak_hash_tables): Now static.
7906
5045092b
PE
7907 * fileio.c: Make symbols static if they're not exported.
7908 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7909 (Vwrite_region_annotation_buffers): Now static.
7910
57a96f5c
PE
7911 * eval.c: Make symbols static if they're not exported.
7912 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7913 * lisp.h (backtrace_list): Remove decl.
7914
35f08c38
PE
7915 * emacs.c: Make symbols static if they're not exported.
7916 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7917 (fatal_error_code, fatal_error_signal_hook, standard_args):
7918 Now static.
7919 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7920 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7921 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7922 * lisp.h (fatal_error_signal_hook): Remove decl.
7923 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7924
f44bd759
PE
7925 * editfns.c: Move a (normally-unused) function to its only use.
7926 * editfns.c, lisp.h (get_operating_system_release): Remove.
7927 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7928 worth the hassle of breaking this out.
7929
b532497d
PE
7930 * xterm.c: Make symbols static if they're not exported.
7931 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7932 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7933 (x_destroy_window, x_delete_display):
7934 Now static.
7935 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7936 (x_mouse_leave): Remove; unused.
7937 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7938 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7939 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7940 Remove decls.
7941 (x_mouse_leave): Declare only if WINDOWSNT.
7942 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7943 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7944 USE_X_TOOLKIT.
7945
1675728f
PE
7946 * ftxfont.c: Make symbols static if they're not exported.
7947 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7948 HAVE_FREETYPE.
7949 * font.h (ftxfont_driver): Likewise.
7950
e4cebfca
PE
7951 * xfns.c: Make symbols static if they're not exported.
7952 (x_last_font_name, x_display_info_for_name):
7953 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7954 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7955 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7956 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7957 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7958 (last_show_tip_args): Now static.
7959 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7960 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7961 (x_screen_planes): Remove; unused.
7962 * dispextern.h (x_screen_planes): Remove decl.
7963
5bf46f05
PE
7964 * dispnew.c: Make symbols static if they're not exported.
7965 * dispextern.h (redraw_garbaged_frames, scrolling):
7966 (increment_row_positions): Remove.
7967 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7968 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7969 Now static.
7970 (redraw_garbaged_frames): Remove; unused.
7971
435f4c28
PE
7972 * xfaces.c: Make symbols static if they're not exported.
7973 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7974 Remove decls.
7975 * xterm.h (defined_color): Remove decls.
7976 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7977 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7978 (menu_face_changed_default, defined_color, free_realized_face):
7979 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7980 (ascii_face_of_lisp_face): Remove; unused.
7981
8524aef3
PE
7982 * xdisp.c: Make symbols static if they're not exported.
7983 * dispextern.h (scratch_glyph_row, window_box_edges):
7984 (glyph_to_pixel_coords, set_cursor_from_row):
7985 (get_next_display_element, set_iterator_to_next):
7986 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7987 (show_mouse_face): Remove decls
7988 * frame.h (message_buf_print): Likewise.
7989 * lisp.h (pop_message, set_message, check_point_in_composition):
7990 Likewise.
7991 * xterm.h (set_vertical_scroll_bar): Likewise.
7992 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7993 (message_buf_print, scratch_glyph_row, displayed_buffer):
7994 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7995 (get_next_display_element, show_mouse_face, window_box_edges):
7996 (frame_to_window_pixel_xy, check_point_in_composition):
7997 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7998 (glyph_to_pixel_coords): Remove; unused.
7999
16390cd2
PE
8000 * dired.c (file_name_completion): Now static.
8001
8002 * dbusbind.c (xd_in_read_queued_messages): Now static.
8003
a25f4dfa
PE
8004 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8005 * data.c (circular_list_error): Remove.
8006
14a9c8df
PE
8007 * commands.h (last_point_position, last_point_position_buffer):
8008 (last_point_position_window): Remove decls.
8009 * keyboard.c: Make these variables static.
8010
04f2d78b
CB
8011 * coding.h (coding, code_convert_region, encode_coding_gap):
8012 Remove decls.
74ab6df5
PE
8013 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8014 (iso_code_class, detect_coding, code_convert_region): Now static.
8015 (encode_coding_gap): Remove; unused.
8016
38dfbee1
PE
8017 * chartab.c (chartab_chars, chartab_bits): Now static.
8018
a2cb4e63
PE
8019 * charset.h (charset_iso_8859_1): Remove decl.
8020 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8021 Now static.
8022
127198fd
PE
8023 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8024 * ccl.c (Vccl_program_table): Now static.
8025 (check_ccl_update): Remove; unused.
8026
d85b608f
PE
8027 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8028 * category.h: ... from here.
8029 * category.c (check_category_table, set_category_set): Now static.
8030
31cd66f3
PE
8031 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8032 * lisp.h: Remove these decls.
8033
c358e587
PE
8034 * buffer.c (buffer_count): Remove unused var.
8035
e78aecca
PE
8036 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8037 so that it's not optimized away.
8038 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8039 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8040 exported only to the debugger.
8041
e192d7d3 8042 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8043 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8044
92470028
PE
8045 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8046 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8047 was inaccessible from Lisp.
8048 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8049 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8050
244ed907
PE
8051 alloc.c: Import and export fewer symbols, and remove unused items.
8052 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8053 is defined.
8054 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8055 it's not optimized away by whole-program optimization.
8056 (message_enable_multibyte, free_misc): Remove.
8057 (catchlist, handlerlist, mark_backtrace):
8058 Declare only if BYTE_MARK_STACK.
8059 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8060 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8061 (message_enable_multibyte): Remove decl.
8062 (free_misc, interval_free_list, float_block, float_block_index):
8063 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8064 (cons_free_list, last_marked_index):
8065 Now static.
8066 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8067 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8068 (mark_backtrace): Define only if BYTE_MARK_STACK.
8069 * xdisp.c (message_enable_multibyte): Now static.
8070
61c2b50e 8071 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8072 This makes it easier for human readers (and static analyzers)
8073 to see whether these variables are used from other modules.
8074 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8075 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8076 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8077 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8078 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8079 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8080 * xmenu.c, xselect.c:
8081 Declare Q* vars static if they are not used in other modules.
8082 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8083 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8084 Remove decls of unexported vars.
8085 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8086
95c82688
PE
8087 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8088
16a97296
PE
8089 Make Emacs functions such as Fatom 'static' by default.
8090 This makes it easier for human readers (and static analyzers)
8091 to see whether these functions can be called from other modules.
8092 DEFUN now defines a static function. To make the function external
8093 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8094 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8095 (Finit_image_library):
16a97296
PE
8096 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8097 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8098 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8099 Remove decls, since these functions are now static.
8100 (Funintern, Fget_internal_run_time): New decls, since these functions
8101 were already external.
95c82688 8102
16a97296
PE
8103 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8104 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8105 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8106 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8107 * keyboard.c, keymap.c, lread.c:
8108 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8109 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8110 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8111 Mark functions with DEFUE instead of DEFUN,
8112 if they are used in other modules.
8113 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8114 decls for now-static functions.
8115 * buffer.h (Fdelete_overlay): Remove decl.
8116 * callproc.c (Fgetenv_internal): Mark as internal.
8117 * composite.c (Fremove_list_of_text_properties): Remove decl.
8118 (Fcomposition_get_gstring): New forward static decl.
8119 * composite.h (Fcomposite_get_gstring): Remove decl.
8120 * dired.c (Ffile_attributes): New forward static decl.
8121 * doc.c (Fdocumntation_property): New forward static decl.
8122 * eval.c (Ffetch_bytecode): New forward static decl.
8123 (Funintern): Remove extern decl; now in .h file where it belongs.
8124 * fileio.c (Fmake_symbolic_link): New forward static decl.
8125 * image.c (Finit_image_library): New forward static decl.
8126 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8127 * intervals.h (Fprevious_property_change):
8128 (Fremove_list_of_text_properties): Remove decls.
8129 * keyboard.c (Fthis_command_keys): Remove decl.
8130 (Fcommand_execute): New forward static decl.
8131 * keymap.c (Flookup_key): New forward static decl.
8132 (Fcopy_keymap): Now static.
8133 * keymap.h (Flookup_key): Remove decl.
8134 * process.c (Fget_process): New forward static decl.
8135 (Fprocess_datagram_address): Mark as internal.
8136 * syntax.c (Fsyntax_table_p): New forward static decl.
8137 (skip_chars): Remove duplicate decl.
8138 * textprop.c (Fprevious_property_change): New forward static decl.
8139 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8140 Now internal.
8141 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8142 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8143
785bbd42
PE
8144 * editfns.c (Fformat): Remove unreachable code.
8145
8b913b57
AS
81462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8147
8148 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8149 change. (Bug#8496)
8150
a6744a35
EZ
81512011-04-13 Eli Zaretskii <eliz@gnu.org>
8152
8153 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8154 when at ZV. (Bug#8487)
8155
e7974947
AS
81562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8157
baad03f0
AS
8158 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8159 (Bug#8437)
8160 * keyboard.c (parse_tool_bar_item): Likewise.
8161 * sound.c (sound_cleanup, alsa_close): Likewise.
8162 * termcap.c (tgetent): Likewise.
8163 * xfns.c (x_default_font_parameter): Likewise.
8164 * xsettings.c (read_and_apply_settings): Likewise.
8165
e7974947
AS
8166 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8167 (overrun_check_free): Protoize.
8168
28272684
PE
81692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8170
8171 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8172 since callers should never pass a negative size.
8173 Change the signature to match that of plain 'read' and 'write'; see
8174 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8175 * lisp.h: Update prototypes of emacs_write and emacs_read.
8176
11997c76
EZ
81772011-04-11 Eli Zaretskii <eliz@gnu.org>
8178
8179 * xdisp.c (redisplay_window): Don't try to determine the character
8180 position of the scroll margin if the window start point w->startp
e896f03c 8181 is outside the buffer's accessible region. (Bug#8468)
11997c76 8182
8a2cbd72
EZ
81832011-04-10 Eli Zaretskii <eliz@gnu.org>
8184
8185 Fix write-region and its subroutines for buffers > 2GB.
8186 * fileio.c (a_write, e_write): Modify declaration of arguments and
8187 local variables to support buffers larger than 2GB.
8188 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8189
8190 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8191 argument, local variables, and return value.
8192
8193 * lisp.h: Update prototypes of emacs_write and emacs_read.
8194
8195 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8196
4073e537 81972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8198
1ebfdcb6
PE
8199 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8200
b2ded58d
PE
8201 Fix more problems found by GCC 4.6.0's static checks.
8202
7d66342c
PE
8203 * xdisp.c (vmessage): Use a better test for character truncation.
8204
bbf47d44
PE
8205 * charset.c (load_charset_map): <, not <=, for optimization,
8206 and to avoid potential problems with integer overflow.
9248994d 8207 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8208 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8209 * editfns.c (Fformat): Likewise.
1e69125e 8210 * syntax.c (skip_chars): Likewise.
3befa583 8211
e3019616
PE
8212 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8213 This also lets GCC 4.6.0 generate slightly better loop code.
8214
becfa255
PE
8215 * callint.c (Fcall_interactively): <, not <=, for optimization.
8216 (Fcall_interactively): Count the number of arguments produced,
8217 not the number of arguments given. This is simpler and lets GCC
8218 4.6.0 generate slightly better code.
8219
dae0cd48
PE
8220 * ftfont.c: Distingish more carefully between FcChar8 and char.
8221 The previous code passed unsigned char * to a functions like
8222 strlen and xstrcasecmp that expect char *, which does not
8223 conform to the C standard.
8224 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8225 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8226 char * when the C standard requires it.
8227
76032d70
PE
8228 * keyboard.c (read_char): Remove unused var.
8229
eb3f1cc8
PE
8230 * eval.c: Port to Windows vsnprintf (Bug#8435).
8231 Include <limits.h>.
8232 (SIZE_MAX): Define if the headers do not.
8233 (verror): Do not give up if vsnprintf returns a negative count.
8234 Instead, grow the buffer. This ports to Windows vsnprintf, which
8235 does not conform to C99. Problem reported by Eli Zaretskii.
8236 Also, simplify the allocation scheme, by avoiding the need for
8237 calling realloc, and removing the ALLOCATED variable.
8238
70476b54
PE
8239 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8240
12020a9e
PE
8241 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8242 But keep the doprint source code for now, as we might revamp it
8243 and use it again (Bug#8435).
ea6c7ae6
PE
8244 * lisp.h (doprnt): Remove.
8245 * Makefile.in (base_obj): Remove doprnt.o.
8246 * deps.mk (doprnt.o): Remove.
8247
5fdb398c
PE
8248 error: Print 32- and 64-bit integers portably (Bug#8435).
8249 Without this change, on typical 64-bit hosts error ("...%d...", N)
8250 was used to print both 32- and 64-bit integers N, which relied on
8251 undefined behavior.
61bdb816 8252 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8253 * lisp.h (error, verror): Mark as printf-like functions.
8254 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8255 Report overflow in size calculations when allocating printf buffer.
8256 Do not truncate output string at its first null byte.
8257 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8258 Truncate the output at a character boundary, since vsnprintf does not
8259 do that.
8260 * charset.c (check_iso_charset_parameter): Convert internal
8261 character to string before calling 'error', since %c now has the
8262 printf meaning.
8263 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8264 overflow when computing char to be passed to 'error'. Do not
8265 pass Lisp_Object to 'error'; pass the integer instead.
8266 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8267 formatted with plain %d.
8268
b189fa66
PE
8269 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8270
bff87ef0
PE
8271 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8272
7e2cac20
PE
8273 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8274
ce4d90b5
PE
8275 * xterm.c (x_catch_errors): Remove duplicate declaration.
8276
266c9547
PE
8277 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8278
79c49ad2
PE
8279 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8280
368f4090
JM
82812011-04-10 Jim Meyering <meyering@redhat.com>
8282
8283 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8284 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8285 return ssize_t not "int", and use size_t as the buffer length.
8286 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8287 * gnutls.h: Update declarations.
8288 * process.c (read_process_output): Use ssize_t, to match.
8289 (send_process): Likewise.
8290
a32d4040
CY
82912011-04-09 Chong Yidong <cyd@stupidchicken.com>
8292
8293 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8294
8546720e 82952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8296
04f2d78b
CB
8297 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8298 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8299
8546720e
GM
8300 * xterm.c (handle_one_xevent):
8301 * xmenu.c (create_and_show_popup_menu):
8302 * xselect.c (x_decline_selection_request)
8303 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8304
0a2f5c1a 83052011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8306
8307 Fix some uses of `int' instead of EMACS_INT.
8308 * search.c (string_match_1, fast_string_match)
8309 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8310 (scan_buffer, find_next_newline_no_quit)
8311 (find_before_next_newline, search_command, Freplace_match)
8312 (Fmatch_data): Make some `int' variables be EMACS_INT.
8313
8314 * xdisp.c (display_count_lines): 3rd argument and return value now
8315 EMACS_INT. All callers changed.
8316 (pint2hrstr): Last argument is now EMACS_INT.
8317
8318 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8319 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8320 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8321 (decode_coding_utf_16, decode_coding_emacs_mule)
8322 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8323 (decode_coding_ccl, decode_coding_charset)
8324 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8325 (decode_coding_iso_2022, decode_coding_emacs_mule)
8326 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8327 <char_offset, last_offset>: Declare EMACS_INT.
8328 (encode_coding_utf_8, encode_coding_utf_16)
8329 (encode_coding_emacs_mule, encode_invocation_designation)
8330 (encode_designation_at_bol, encode_coding_iso_2022)
8331 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8332 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8333 Declare EMACS_INT.
8334 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8335 (encode_invocation_designation): Last argument P_NCHARS is now
8336 EMACS_INT.
8337 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8338 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8339
8340 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8341 All users changed.
8342
8343 * ccl.c (Fccl_execute_on_string): Declare some variables
8344 EMACS_INT.
8345
8546720e 83462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8347
8348 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8349
4e19a977
CS
83502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8351
8352 * process.c (Fformat_network_address): Doc fix.
8353
87302331
R
83542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8355
ee7683eb 8356 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8357
cbb59342
CY
83582011-04-08 Chong Yidong <cyd@stupidchicken.com>
8359
8360 * keyboard.c (read_char): Call Lisp function help-form-show,
8361 instead of using internal_with_output_to_temp_buffer.
8362 (Qhelp_form_show): New var.
e0d38eeb 8363 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8364
8365 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8366
8367 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8368
e67a13ab
CY
83692011-04-06 Chong Yidong <cyd@stupidchicken.com>
8370
04f2d78b
CB
8371 * process.c (Flist_processes): Remove to Lisp.
8372 (list_processes_1): Delete.
e67a13ab 8373
973f782d
EZ
83742011-04-06 Eli Zaretskii <eliz@gnu.org>
8375
7c106b1e
EZ
8376 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8377
973f782d
EZ
8378 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8379
41cf7d1a 83802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8381
ca23cc88
PE
8382 Fix more problems found by GCC 4.6.0's static checks.
8383
f390e2d5
PE
8384 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8385
42eea0d0
PE
8386 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8387
b69769da 8388 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8389
f9541e84
PE
8390 * xdisp.c (vmessage): Mark as a printf-like function.
8391
13841b55
PE
8392 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8393
c136c10f
PE
8394 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8395
5e2d4a30
PE
8396 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8397 printf-like functions.
8398 (tiff_load): Add casts to remove these marks before passing them
8399 to system-supplied API.
8400
583f48b9
PE
8401 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8402
b25d760e
PE
8403 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8404 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8405 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8406 directly, rather than having caller test rule sign. This avoids
8407 some unnecessary tests.
8408 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8409 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8410 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8411
bc7b6697 8412 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8413 (xfont_open): Avoid unnecessary tests.
bc7b6697 8414
27ccc379
PE
8415 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8416
dcd5c89a
PE
8417 * composite.h, composite.c (composition_gstring_put_cache):
8418 Use EMACS_INT, not int, for length.
8419
b13a45c6
PE
8420 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8421 breaking out part of COMPOSITION_DECODE_RULE.
8422 (COMPOSITION_DECODE_RULE): Use it.
8423 * composite.c (get_composition_id): Remove unused local vars,
8424 by using the new macro.
8425
1e792e4d
PE
8426 * textprop.c (set_text_properties_1): Change while to do-while,
8427 since the condition is always true at first.
8428
dc6c6455 8429 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8430 (interval_deletion_adjustment): Return unsigned value.
8431 All uses changed.
dc6c6455 8432
aba7731a
PE
8433 * process.c (list_processes_1, create_pty, read_process_output):
8434 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8435 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8436 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8437 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8438 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8439
fdfc4bf3
PE
8440 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8441
fca8fe46 8442 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8443 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8444
06a0259a 8445 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8446 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8447 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8448
e7b9e80f
PE
8449 * print.c (print_error_message): Avoid int overflow.
8450
56201685
PE
8451 * font.c (font_list_entities): Redo for clarity,
8452 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8453
78834453 8454 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8455 (font_score): Avoid potential overflow in diff calculation.
78834453 8456
0bc0b309 8457 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8458 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8459
e610eaca
PE
8460 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8461
b895abce
PE
8462 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8463 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8464 can always succeed if overflow has undefined behavior.
8465
1f1d9321 8466 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8467 (wordify): Omit three unnecessary tests.
1f1d9321 8468
c59478bc
PE
8469 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8470 All callers changed. This avoids the need for an unused var.
8471
79b73827
PE
8472 * casefiddle.c (casify_region): Remove var that is set but not used.
8473
a4db5dfe
PE
8474 * dired.c (file_name_completion): Remove var that is set but not used.
8475
43aae36e
PE
8476 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8477
2a47c44d 8478 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8479 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8480
a37c69bf
PE
8481 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8482 Check for integer overflow on size calculations.
8483
328ab8e7
PE
8484 * buffer.c (Fprevious_overlay_change): Remove var that is set
8485 but not used.
8486
e5a2a5cb
PE
8487 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8488 Remove vars that are set but not used.
8d84a6eb 8489 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8490 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8491
a60e5f68
PE
8492 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8493
f661cb61 8494 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8495 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8496
f0397f5a
PE
8497 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8498 that are set but not used.
8499
8664db06 8500 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8501 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8502
6abdaa4a
PE
8503 * xselect.c (x_get_local_selection, x_handle_property_notify):
8504 Remove vars that are set but not used.
8505
0ce7538d 8506 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8507 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8508
9ae848fc
PE
8509 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8510 Remove var that is set but not used.
0b918413
PE
8511 (scroll_bar_windows_size): Now size_t, not int.
8512 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8513 Check for overflow.
9ae848fc 8514
a5a62657
PE
8515 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8516 (map_tty_color) [!defined MSDOS]: Likewise.
8517
5c5cdd39
PE
8518 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8519
66ebf983
PE
8520 * coding.c: Remove vars that are set but not used.
8521 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8522 All callers changed.
8523 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8524 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8525 (decode_coding_charset): Remove vars that are set but not used.
8526
1be4d761
PE
8527 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8528 that is set but not used.
8529
47553fa8
PE
8530 * print.c (print_object): Remove var that is set but not used.
8531
1f7196bf 8532 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8533 The gnulib version avoids calling malloc in the usual case,
8534 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8535 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8536 * filelock.c (current_lock_owner): Likewise.
8537 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8538 * sysdep.c: Include allocator.h, careadlinkat.h.
8539 (emacs_no_realloc_allocator): New static constant.
8540 (emacs_readlink): New function.
fdb61804
PE
8541 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8542 ../lib/careadlinkat.h.
d1fdcab7 8543
f84c17c7
SM
85442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8545
8546 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8547 first non-nil return value).
8548
ef3862ad
JD
85492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8550
8551 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8552 if not defined (Bug#8403).
8553
376a7006
JB
85542011-04-02 Juanma Barranquero <lekktu@gmail.com>
8555
8556 * xdisp.c (display_count_lines): Remove parameter `start',
8557 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8558 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8559 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8560 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8561 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8562 and thereabouts. All callers changed.
8563 (get_per_char_metric): Remove parameter `f', unused since
8564 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8565
6ca3801d
JM
85662011-04-02 Jim Meyering <meyering@redhat.com>
8567
8568 do not dereference NULL upon failed strdup
8569 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8570 (ns_get_family): Likewise.
8571
d8e2b5ba
JB
85722011-04-02 Juanma Barranquero <lekktu@gmail.com>
8573
8574 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8575
8c74fcbd
JD
85762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8577
8578 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8579 later (Bug#8403).
8580
7200d79c
SM
85812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8582
03408648 8583 Add lexical binding.
7200d79c 8584
03408648
SM
8585 * window.c (Ftemp_output_buffer_show): New fun.
8586 (Fsave_window_excursion):
8587 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8588
8589 * lread.c (lisp_file_lexically_bound_p): New function.
8590 (Fload): Bind Qlexical_binding.
8591 (readevalloop): Remove `evalfun' arg.
8592 Bind Qinternal_interpreter_environment.
8593 (Feval_buffer): Bind Qlexical_binding.
8594 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8595 Mark as dynamic.
8596 (syms_of_lread): Declare `lexical-binding'.
8597
8598 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8599
8600 * keyboard.c (eval_dyn): New fun.
8601 (menu_item_eval_property): Use it.
ca105506
SM
8602
8603 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8604
03408648
SM
8605 * fns.c (concat, mapcar1): Accept byte-code-functions.
8606
8607 * eval.c (Fsetq): Handle lexical vars.
8608 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8609 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8610 (FletX, Flet): Obey lexical binding.
8611 (Fcommandp): Handle closures.
8612 (Feval): New `lexical' arg.
8613 (eval_sub): New function extracted from Feval. Use it almost
8614 everywhere where Feval was used. Look up vars in lexical env.
8615 Handle closures.
8616 (Ffunctionp): Move from subr.el.
8617 (Ffuncall): Handle closures.
8618 (apply_lambda): Remove `eval_flags'.
8619 (funcall_lambda): Handle closures and new byte-code-functions.
8620 (Fspecial_variable_p): New function.
8621 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8622 but without exporting it to Lisp.
23aba0ea 8623
23aba0ea 8624 * doc.c (Fdocumentation, store_function_docstring):
03408648 8625 * data.c (Finteractive_form): Handle closures.
23aba0ea 8626
03408648
SM
8627 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8628 interactive spec.
ba83908c 8629
04f2d78b
CB
8630 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8631 New byte-codes.
03408648
SM
8632 (exec_byte_code): New function extracted from Fbyte_code to handle new
8633 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8634
03408648 8635 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8636
03408648 8637 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8638
e2abce01
JB
86392011-03-31 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * xdisp.c (redisplay_internal): Fix prototype.
8642
63696a73 86432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8644
63696a73 8645 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8646 (try_scrolling): Use it when setting scroll_limit.
8647 Limit scrolling to 100 screen lines.
63696a73
EZ
8648 (redisplay_window): Even when falling back on "recentering",
8649 position point in the window according to scroll-conservatively,
8650 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8651
8652 (try_scrolling): When point is above the window, allow searching
8653 as far as scroll_max, or one screenful, to compute vertical
8654 distance from PT to the scroll margin position. This prevents
8655 try_scrolling from unnecessarily failing when
8656 scroll-conservatively is set to a value slightly larger than the
8657 window height. Clean up the case of PT below the margin at bottom
8658 of window: scroll_max can no longer be INT_MAX. When aggressive
8659 scrolling is in use, don't let point enter the opposite scroll
8660 margin as result of the scroll.
8661 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8662 threshold of 100 lines for never-recentering scrolling.
8663
e4cc2dfc
JB
86642011-03-31 Juanma Barranquero <lekktu@gmail.com>
8665
8666 * dispextern.h (move_it_by_lines):
8667 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8668 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8669 (message_log_check_duplicate): Remove parameters `prev_bol' and
8670 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8671 (redisplay_internal): Remove parameter `preserve_echo_area',
8672 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8673
8674 * indent.c (Fvertical_motion):
8675 * window.c (window_scroll_pixel_based, Frecenter):
8676 Don't pass `need_y_p' to `move_it_by_lines'.
8677
1c470562
SM
86782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8679
44f230aa
SM
8680 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8681 steal a few bits to be more compact.
8682 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8683 Remove unneeded casts.
8684
1c470562
SM
8685 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8686
888adce9
ZK
86872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8688
8689 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8690 binding" message (bug#7967).
8691
f838ed7b
PE
86922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8693
77861b95
PE
8694 Fix more problems found by GCC 4.6.0's static checks.
8695
de6dbc14
PE
8696 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8697 Remove unused local var.
8698
f838ed7b
PE
8699 * editfns.c (Fmessage_box): Remove unused local var.
8700
792c7b2b
PE
8701 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8702 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8703 Omit unused local vars.
c499e557 8704 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8705 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8706 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8707 Omit unused local var.
8708
ba0165e1
PE
8709 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8710 Don't assume string length fits in int.
32ad8845 8711 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8712 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8713
3c59b4c9
PE
8714 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8715 instead of alloca (Bug#8344).
8716
a3eed478 8717 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8718 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8719
eb4d412d
PE
8720 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8721
1658b401
PE
8722 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8723 concerns.
8724
8725 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8726
8727 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8728
9a2c6e05
PE
8729 * keyboard.c (syms_of_keyboard): Use the same style as later
8730 in this function when indexing through an array. This also
8731 works around GCC bug 48267.
8732
03d0a109
PE
8733 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8734
44f730c8
PE
8735 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8736
fe75f926
PE
8737 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8738 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8739
ffa8c828
PE
8740 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8741 This avoids undefined behavior on integer overflow, and is a bit
8742 more convenient anyway since it is compared to a size_t variable.
8743
c5101a77
PE
8744 Variadic C functions now count arguments with size_t, not int.
8745 This avoids an unnecessary limitation on 64-bit machines, which
8746 caused (substring ...) to crash on large vectors (Bug#8344).
8747 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8748 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8749 All variadic functions and their callers changed accordingly.
c5101a77
PE
8750 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8751 * data.c (arith_driver, float_arith_driver): Likewise.
8752 * editfns.c (general_insert_function): Likewise.
8753 * eval.c (struct backtrace.nargs, interactive_p)
8754 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8755 (funcall_lambda, mark_backtrace): Likewise.
8756 * fns.c (concat): Likewise.
8757 * frame.c (x_set_frame_parameters): Likewise.
8758 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8759 0 if not found, not -1. All callers changed.
8760
dd3f25f7
PE
8761 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8762 (stack_copy_size): Now size_t, not int.
8763 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8764
461c2ab9
JB
87652011-03-28 Juanma Barranquero <lekktu@gmail.com>
8766
8767 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8768 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8769 All callers changed.
8770
8771 * lisp.h (multibyte_char_to_unibyte):
8772 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8773 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8774 * character.h (CHAR_TO_BYTE8):
8775 * cmds.c (internal_self_insert):
8776 * editfns.c (general_insert_function):
8777 * keymap.c (push_key_description):
8778 * search.c (Freplace_match):
8779 * xdisp.c (message_dolog, set_message_1): All callers changed.
8780
f6d62986
SM
87812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8782
8783 * keyboard.c (safe_run_hook_funcall): New function.
8784 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8785 don't set the hook to nil, but remove the offending function instead.
8786 (Qcommand_hook_internal): Remove, unused.
8787 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8788 Vcommand_hook_internal.
8789
8790 * eval.c (enum run_hooks_condition): Remove.
8791 (funcall_nil, funcall_not): New functions.
8792 (run_hook_with_args): Call each function through a `funcall' argument.
8793 Remove `cond' argument, now redundant.
8794 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8795 (Frun_hook_with_args_until_failure): Adjust accordingly.
8796 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8797
1db5b1ad
JB
87982011-03-28 Juanma Barranquero <lekktu@gmail.com>
8799
8800 * dispextern.h (string_buffer_position): Remove declaration.
8801
8802 * print.c (strout): Remove parameter `multibyte', unused since
8803 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8804
8805 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8806 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8807 All callers changed.
8808
8809 * w32.c (_wsa_errlist): Use braces for struct initializers.
8810
8811 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8812 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8813 All callers changed.
8814 (string_buffer_position): Likewise. Also, make static (it's never
8815 used outside xdisp.c).
8816 (cursor_row_p): Remove parameter `w', unused since
8817 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8818 (decode_mode_spec): Remove parameter `precision', introduced during
8819 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8820 All callers changed.
8821
5ffb62aa
JD
88222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8823
8824 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8825
461c2ab9 88262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8827
8828 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8829 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8830 (ns_update_auto_hide_menu_bar): New functions.
8831 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8832 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8833 ns_constrain_all_frames.
8834 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8835 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8836
5c380ffb
JD
88372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8838
8839 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8840
9af30bdf
GM
88412011-03-27 Glenn Morris <rgm@gnu.org>
8842
8843 * syssignal.h: Replace RETSIGTYPE with void.
8844 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8845 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8846 Replace SIGTYPE with void everywhere.
8847 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8848 * s/template.h (SIGTYPE): Remove commented out definition.
8849
e2abce01
JB
88502011-03-26 Eli Zaretskii <eliz@gnu.org>
8851
8852 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8853 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8854
f868cd8a
JB
88552011-03-26 Juanma Barranquero <lekktu@gmail.com>
8856
59eb0929
JB
8857 * w32.c (read_unc_volume): Use parameter `henum', instead of
8858 global variable `wget_enum_handle'.
8859
8860 * keymap.c (describe_vector): Remove parameters `indices' and
8861 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8862 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8863
f868cd8a
JB
8864 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8865
8866 * keyboard.c (timer_check): Remove parameter `do_it_now',
8867 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8868 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8869 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8870
8871 * keyboard.c (read_char):
8872 * w32menu.c (w32_menu_display_help):
8873 * xmenu.c (show_help_event, menu_help_callback):
8874 Adjust calls to `show_help_echo'.
8875
8876 * gtkutil.c (xg_maybe_add_timer):
8877 * keyboard.c (readable_events):
8878 * process.c (wait_reading_process_output):
8879 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8880
8881 * insdel.c (adjust_markers_gap_motion):
8882 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8883 (gap_left, gap_right): Don't call it.
8884
2ecf6fdb
CY
88852011-03-25 Chong Yidong <cyd@stupidchicken.com>
8886
8887 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8888 incurred during fontification.
8889
6b1f9ba4
JB
88902011-03-25 Juanma Barranquero <lekktu@gmail.com>
8891
8892 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8893 (DEFVAR_PER_BUFFER): Don't pass it.
8894
8895 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8896 (scrolling_window): Don't pass it.
8897
0f4a96b5
JB
88982011-03-25 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8901
8902 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8903 and `suffix'.
8904 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8905 of variables specific to SELinux and computation of `encoded_absname'.
8906
8907 * image.c (XPutPixel): Remove unused variable `height'.
8908
8909 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8910
8911 * unexw32.c (get_section_info): Remove unused variable `section'.
8912
8913 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8914 (system_process_attributes): Remove unused variable `sess'.
8915 (sys_read): Remove unused variable `err'.
8916
8917 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8918 (w32_wnd_proc): Remove unused variable `isdead'.
8919 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8920 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8921 (x_create_tip_frame): Remove unused variable `tem'.
8922
8923 * w32inevt.c (w32_console_read_socket):
8924 Remove unused variable `no_events'.
8925
8926 * w32term.c (x_draw_composite_glyph_string_foreground):
8927 Remove unused variable `width'.
8928
1149507c
JB
89292011-03-24 Juanma Barranquero <lekktu@gmail.com>
8930
8931 * w32term.c (x_set_glyph_string_clipping):
8932 Don't pass uninitialized region to CombineRgn.
8933
9c88f339
JB
89342011-03-23 Juanma Barranquero <lekktu@gmail.com>
8935
8936 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8937 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8938 (Fx_close_connection): Remove unused variable `i'.
8939
8940 * w32font.c (w32font_draw): Return number of glyphs.
8941 (w32font_open_internal): Remove unused variable `i'.
8942 (w32font_driver): Add missing initializer.
8943
8944 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8945 (fill_in_menu): Remove unused variable `items_added'.
8946
8947 * w32term.c (last_mouse_press_frame): Remove static global variable.
8948 (w32_clip_to_row): Remove unused variable `f'.
8949 (x_delete_terminal): Remove unused variable `i'.
8950
8951 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8952 (NOTHING): Remove unused static global variable.
8953 (uniscribe_check_otf): Remove unused variable `table'.
8954 (uniscribe_font_driver): Add missing initializers.
8955
dee091a3
JD
89562011-03-23 Julien Danjou <julien@danjou.info>
8957
8958 * term.c (Fsuspend_tty, Fresume_tty):
8959 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8960 * window.c (temp_output_buffer_show):
8961 * insdel.c (signal_before_change):
8962 * frame.c (Fhandle_switch_frame):
8963 * fileio.c (Fdo_auto_save):
8964 * emacs.c (Fkill_emacs):
8965 * editfns.c (save_excursion_restore):
8966 * cmds.c (internal_self_insert):
8967 * callint.c (Fcall_interactively):
8968 * buffer.c (Fkill_all_local_variables):
8969 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8970 Use Frun_hooks.
0f4a96b5 8971 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8972 unconditionally since it does the check itself.
dee091a3 8973
2c520ab5 89742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8975
c9c49752
PE
8976 Fix more problems found by GCC 4.5.2's static checks.
8977
8abc3f12
PE
8978 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8979 the first time through the loop, since we know p0 < p1 then.
8980 This also avoids a gcc -Wstrict-overflow warning.
8981
a2d26660
PE
8982 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8983 leading to a memory leak, possible in functions like
8984 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8985 of objects (Bug#8318).
a2d26660 8986
916c72e9
PE
8987 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8988 that could (at least in theory) be that large.
8989
19ab8a18
PE
8990 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8991 This is less likely to overflow, and avoids undefined behavior if
8992 overflow does occur. All callers changed. Use strtoul to scan
8993 for the unsigned long integer.
b7cbbd6f
PE
8994 (pint2hrstr): Simplify and tune code slightly.
8995 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8996
f0641eff
PE
8997 * scroll.c (do_scrolling): Work around GCC bug 48228.
8998 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8999
7f650bb9
PE
9000 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9001 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9002 (validate_x_resource_name): Simplify count usage.
9003 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9004
37dd57d1
PE
9005 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9006 fail (Bug#8306).
81e56e61 9007
699979fc 9008 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9009
401bf9b4
PE
9010 * process.c (Fmake_network_process): Use socklen_t, not int,
9011 where POSIX says socklen_t is required in portable programs.
9012 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9013 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9014 (Fmake_network_process, server_accept_connection):
9015 (wait_reading_process_output, read_process_output):
9016 Likewise.
9017
b93aacde
PE
9018 * process.c: Rename or move locals to avoid shadowing.
9019 (list_processes_1, Fmake_network_process):
9020 (read_process_output_error_handler, exec_sentinel_error_handler):
9021 Rename or move locals.
4dc343ee 9022 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9023 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9024 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9025 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9026 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9027
af8a867c 9028 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9029 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9030 Include tparam.h instead, since it declares them.
af8a867c
PE
9031 * cm.h (PC): Remove extern decl; tparam.h now does this.
9032 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9033 * terminfo.c: Include tparam.h, to check interfaces.
9034 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9035 (tparam): Adjust signature to match interface in tparam.h;
9036 this removes some undefined behavior. Check that outstring and len
9037 are zero, which they always are with Emacs.
9038 * tparam.h (PC, BC, UP): New extern decls.
9039
0248044d 9040 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9041 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9042
8ff096c1 9043 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9044 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9045 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9046 (ftfont_list): Remove unused local.
49eaafba
PE
9047 (get_adstyle_property, ftfont_pattern_entity):
9048 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9049 Rename locals to avoid shadowing.
8ff096c1 9050
e2be39f6
PE
9051 * xfont.c (xfont_list_family): Mark var as initialized.
9052
c9735e30
PE
9053 * xml.c (make_dom): Now static.
9054
8f5201ae
PE
9055 * composite.c (composition_compute_stop_pos): Rename local to
9056 avoid shadowing.
b246f932
PE
9057 (composition_reseat_it): Remove unused locals.
9058 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9059 (composition_update_it): Mark var as initialized.
11b61122
PE
9060 (find_automatic_composition): Mark vars as initialized,
9061 with a FIXME (Bug#8290).
8f5201ae 9062
760fbc2c
PE
9063 character.h: Rename locals to avoid shadowing.
9064 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9065 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9066 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9067 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9068 to avoid shadowing.
9069
ff08eb85
PE
9070 * textprop.c (property_change_between_p): Remove; unused.
9071
fc7bf025
PE
9072 * intervals.c (interval_start_pos): Now static.
9073
235d7abc
PE
9074 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9075
44f230aa
SM
9076 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9077 Rename locals to avoid shadowing.
3e7d6594 9078
50060332
PE
9079 * sound.c (wav_play, au_play, Fplay_sound_internal):
9080 Fix pointer signedness.
d01f234b 9081 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9082 (wav_play): Initialize a variable to 0, to prevent undefined
9083 behavior (Bug#8278).
50060332 9084
c4fc4e30
PE
9085 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9086
918436ed
PE
9087 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9088
c939f91b
PE
9089 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9090 clobbering (Bug#8298).
b9c7f648
PE
9091 * sysdep.c (sys_subshell): Likewise.
9092 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9093
6bd8c144
PE
9094 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9095 This should get cleaned up, so that child_setup has the
9096 same signature on all platforms.
9097
7710357c 9098 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9099 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9100
c59da222
CY
91012011-03-22 Chong Yidong <cyd@stupidchicken.com>
9102
9103 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9104 not to be necessary, and produces flickering.
9105
66b87493
GM
91062011-03-20 Glenn Morris <rgm@gnu.org>
9107
9108 * config.in: Remove file.
9109
45b6f6d5
JB
91102011-03-20 Juanma Barranquero <lekktu@gmail.com>
9111
9112 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9113 are now in src/globals.h.
9114 (syms_of_minibuf): Remove spurious & from previous change.
9115
cd394be1 91162011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9117
9118 * minibuf.c (completing-read-function): New variable.
9119 (completing-read-default): Rename from completing-read.
9120 (completing-read): Call completing-read-function.
9121
b14e3e21
CY
91222011-03-19 Juanma Barranquero <lekktu@gmail.com>
9123
9124 * xfaces.c (Fx_load_color_file):
9125 Read color file from absolute filename (bug#8250).
9126
f2b726e6
JB
91272011-03-19 Juanma Barranquero <lekktu@gmail.com>
9128
9129 * makefile.w32-in: Update dependencies.
9130
09f6ff02
EZ
91312011-03-17 Eli Zaretskii <eliz@gnu.org>
9132
9133 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9134
29a6015a
PE
91352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9136
a3a6c54e
PE
9137 Fix more problems found by GCC 4.5.2's static checks.
9138
b766f867
PE
9139 * process.c (make_serial_process_unwind, send_process_trap):
9140 (sigchld_handler): Now static.
9141
be02381c
PE
9142 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9143 That way, the code declares only the vars that it needs.
9144 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9145 * s/cygwin.h (PTY_ITERATION): Likewise.
9146 * s/darwin.h (PTY_ITERATION): Likewise.
9147 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9148
57048744
PE
9149 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9150 * process.c (allocate_pty): Don't declare stb unless it's needed.
9151
7914961c 9152 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9153 (CONSTANTLIM): Remove; unused.
9154 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9155 Define only if needed.
7914961c 9156
b3967b18
PE
9157 * unexelf.c (unexec): Name an expression,
9158 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9159 Use a different way to cause a compilation error if anyone uses
9160 n rather than nn, a way that does not involve shadowing.
73366a00 9161 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9162
29a6015a
PE
9163 * deps.mk (unexalpha.o): Remove; unused.
9164
43cfc33e 9165 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9166 * unexec.h: New file.
ce701a33
PE
9167 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9168 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9169 Depend on unexec.h.
9170 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9171 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9172 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9173 Change as necessary to match prototype in unexec.h.
ce701a33 9174
01f44d5a
PE
9175 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9176 shadowing.
4f63c6bb 9177 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9178
a6670b0b
PE
9179 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9180 Rename locals to avoid shadowing.
9181
cef2010d 9182 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9183 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9184
d4d7173a
PE
9185 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9186
f08b802a
PE
9187 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9188 warning when compiling print.c.
9189
3ddb0639
PE
9190 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9191 instead of using an uninitialized var.
5ad03b97 9192 (font_sort_entities): Mark var as initialized.
3ddb0639 9193
170a2692
PE
9194 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9195
e663c700
PE
9196 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9197 pointers to constants.
89bc529a 9198 (font_parse_fcname): Remove unused vars.
7b81e2d0 9199 (font_delete_unmatched): Now static.
ea838e10 9200 (font_get_spec): Remove; unused.
13a547c6
PE
9201 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9202 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9203 Rename or move locals to avoid shadowing.
e663c700 9204
2a80c887 9205 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9206 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9207
1384fa33 9208 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9209 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9210
8b2c52e9
PE
9211 * alloc.c (mark_backtrace): Move decl from here ...
9212 * lisp.h: ... to here, so that it can be checked.
9213
475545b5 9214 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9215 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9216 (lisp_indirect_variable): Name an expression,
9217 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9218 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9219
b1349114 9220 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9221 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9222 Use const pointer when appropriate.
b1349114 9223
a2928364
PE
9224 * lisp.h (get_system_name, get_operating_system_release):
9225 Move decls here, to check interfaces.
9226 * process.c (get_operating_system_release): Move decl to lisp.h.
9227 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9228 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9229 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9230 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9231 (Fformat_time_string, Fencode_time, Finsert_char):
9232 (Ftranslate_region_internal, Fformat):
9233 Rename or remove local vars to avoid shadowing.
9710023e 9234 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9235
a415e694
PE
9236 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9237 avoid shadowing.
9238
8ef4622d
PE
9239 * lisp.h (eassert): Check that the argument compiles, even if
9240 ENABLE_CHECKING is not defined.
9241
946f9a5b
PE
9242 * data.c (Findirect_variable): Name an expression, to avoid
9243 gcc -Wbad-function-cast warning.
112396d6 9244 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9245 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9246 (Fmake_variable_buffer_local, Fmake_local_variable):
9247 Mark variables as initialized.
52746918 9248 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9249
e5aab7e7 9250 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9251 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9252 Rename locals to avoid shadowing.
dff45157
PE
9253 (mark_stack): Move local variables into the #ifdef region where
9254 they're used.
7bc26fdb
PE
9255 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9256 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9257 needed otherwise.
9258 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9259 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9260 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9261
e5aab7e7
PE
9262 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9263 avoids undefined behavior in theory.
9264
4da60324
PE
9265 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9266
88043301
PE
9267 Use functions, not macros, for up- and down-casing (Bug#8254).
9268 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9269 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9270 to use the following functions instead of these macros.
9271 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9272 EMACS_INT, since callers assume the returned value fits in int.
9273 (upcase1): Likewise, for UPCASE_TABLE.
9274 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9275 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9276 the race-condition problem in the old DOWNCASE.
88043301 9277
19ed5445
PE
9278 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9279 Rename locals to avoid shadowing.
9280 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9281 (regex_compile, re_search_2, re_match_2_internal):
9282 Remove unused local vars.
952db0d7
PE
9283 (FREE_VAR): Rewrite so as not to use empty "else",
9284 which gcc can warn about.
da053e48 9285 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9286 (RETALLOC_IF): Define only if needed.
9287 (WORDCHAR_P): Likewise. This one is never needed, but is used
9288 only in a comment talking about a compiler bug, so put inside
9289 the #if 0 of that comment.
9290 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9291 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9292 Remove; unused.
19ed5445 9293
1f3561e4 9294 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9295 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9296 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9297
ded6f8f7
PE
9298 * search.c (simple_search): Remove unused var.
9299
dbd37a95
PE
9300 * dired.c (compile_pattern): Move decl from here ...
9301 * lisp.h: ... to here, so that it can be checked.
9302 (struct re_registers): New forward decl.
9303
7e47afad
PE
9304 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9305
85f24f61
PE
9306 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9307 All uses changed.
9308 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9309 Rename locals to avoid shadowing.
5671df8f 9310 (Fvertical_motion): Mark locals as initialized.
85f24f61 9311
181aa2be 9312 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9313 (casify_region): Mark local as initialized.
181aa2be 9314
930d429c
PE
9315 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9316
7082eac6
PE
9317 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9318 New macros, so that the caller can use some names other than
9319 gcpro1, gcpro2, etc.
9320 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9321 of the new macros.
9322 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9323 argument, for consistency with GCPRO2_VAR, etc: it is now the
9324 prefix of the variable, not the variable itself. All uses
9325 changed.
38b2c076
PE
9326 * dired.c (directory_files_internal, file_name_completion):
9327 Rename locals to avoid shadowing.
9328
15206ed9
PE
9329 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9330 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9331 dired.c's scmp function, had undefined behavior.
9332 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9333 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9334 * buffer.h: ... to here, because these macros use current_buffer,
9335 and the new implementation with inline functions needs to have
9336 current_buffer in scope now, rather than later when the macros
9337 are used.
9338 (downcase, upcase1): New static inline functions.
9339 (DOWNCASE, UPCASE1): Reimplement using these functions.
9340 This avoids undefined behavior in expressions like
9341 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9342 from race conditions in accessing the global variables
9343 case_temp1 and case_temp2.
9344 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9345 * lisp.h (case_temp1, case_temp2): Remove their decls.
9346 * character.h (ASCII_CHAR_P): Move from here ...
9347 * lisp.h: ... to here, so that the inline functions mentioned
9348 above can use them.
9349
4a6bea26
PE
9350 * dired.c (directory_files_internal_unwind): Now static.
9351
f14b7e14
PE
9352 * fileio.c (file_name_as_directory, directory_file_name):
9353 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9354 Now static.
2893f146
PE
9355 (file_name_as_directory): Use const pointers when appropriate.
9356 (Fexpand_file_name): Likewise. In particular, newdir might
9357 point at constant storage, so make it a const pointer.
fd4ead52 9358 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9359 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9360 signedness issues.
f839df0c
PE
9361 (Fset_file_times, Finsert_file_contents, auto_save_error):
9362 Rename locals to avoid shadowing.
f14b7e14 9363
5716756e 9364 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9365 (Ftry_completion, Fall_completions): Rename or remove locals
9366 to avoid shadowing.
5716756e 9367
b4c3046a
PE
9368 * marker.c (bytepos_to_charpos): Remove; unused.
9369
b45db522
PE
9370 * lisp.h (verify_bytepos, count_markers): New decls,
9371 so that gcc does not warn that these functions aren't declared.
9372
85876d07
PE
9373 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9374 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9375 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9376 (copy_text): Remove unused local var.
85876d07 9377
03d78a21 9378 * filelock.c (within_one_second): Now static.
b3dd38ab 9379 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9380
5df8f01b
PE
9381 * buffer.c (fix_overlays_before): Mark locals as initialized.
9382 (fix_start_end_in_overlays): Likewise. This function should be
9383 simplified by using pointers-to-pointers, but that's a different
9384 matter.
b1d876f1 9385 (switch_to_buffer_1): Now static.
8f54f30a
PE
9386 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9387 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9388
a70072c9 9389 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9390 Fix pointer signedness issue.
edced198
PE
9391 (sys_subshell): Mark local as volatile if checking for lint,
9392 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9393 (MAXPATHLEN): Define only if needed.
a70072c9 9394
a0977c44
PE
9395 * process.c (serial_open, serial_configure): Move decls from here ...
9396 * systty.h: ... to here, so that they can be checked.
9397
a884fdcc
PE
9398 * fns.c (get_random, seed_random): Move extern decls from here ...
9399 * lisp.h: ... to here, so that they can be checked.
9400
604efe86 9401 * sysdep.c (reset_io): Now static.
b8950c94 9402 (wait_for_termination_signal): Remove; unused.
604efe86 9403
38fc62d9
PE
9404 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9405 (copy_keymap_item, append_key, push_text_char_description):
9406 Now static.
1004a21a 9407 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9408 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9409 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9410 (describe_map_tree):
9411 Rename locals to avoid shadowing.
38fc62d9 9412
2f2650da
PE
9413 * keyboard.c: Declare functions static if they are not used elsewhere.
9414 (echo_char, echo_dash, cmd_error, top_level_2):
9415 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9416 (read_char, kbd_buffer_get_event, make_lispy_position):
9417 (make_lispy_event, make_lispy_movement, apply_modifiers):
9418 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9419 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9420 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9421 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9422 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9423
a053e86c 9424 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9425 (mark_kboards): Move decl here ...
9426 * alloc.c (mark_kboards): ... from here.
a053e86c 9427
4752793e
PE
9428 * lisp.h (force_auto_save_soon): New decl.
9429
74f10ca7 9430 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9431 (DEFINE_DUMMY_FUNCTION): New macro.
9432 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9433 Use it.
c03cd23f
PE
9434 (main): Add casts to avoid warnings
9435 if GCC considers string literals to be constants.
74f10ca7 9436
022e70d4
PE
9437 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9438
59d6fe83
PE
9439 * dbusbind.c: Pointer signedness fixes.
9440 (xd_signature, xd_append_arg, xd_initialize):
9441 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9442 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9443 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9444 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9445
78320123
PE
9446 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9447 if GCC considers string literals to be constants.
49cebcca 9448 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9449
35ac2a97
SM
94502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9451
fb103ca9
SM
9452 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9453 (print_preprocess, print_object): New macro to fix last change.
9454
35ac2a97
SM
9455 * print.c (print_preprocess): Don't forget font objects.
9456
62973b41
JB
94572011-03-16 Juanma Barranquero <lekktu@gmail.com>
9458
9459 * emacs.c (USAGE3): Doc fixes.
9460
0e48bb22
AS
94612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9462
9463 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9464 structure.
9465
7684e57b
JB
94662011-03-14 Juanma Barranquero <lekktu@gmail.com>
9467
9468 * lisp.h (VWindow_system, Qfile_name_history):
9469 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9470 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9471 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9472
9473 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9474 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9475
9476 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9477 * w32console.c (detect_input_pending, read_input_pending)
9478 (encode_terminal_code):
9479 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9480 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9481 (w32_system_caret_y, Qfile_name_history):
9482 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9483 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9484 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9485 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9486 * w32proc.c (Qlocal, report_file_error):
9487 * w32term.c (Vwindow_system, updating_frame):
9488 * w32uniscribe.c (initialized, uniscribe_font_driver):
9489 Remove unneeded extern declarations.
9490
2aa46d6c
CY
94912011-03-14 Chong Yidong <cyd@stupidchicken.com>
9492
c96bbc66 9493 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9494
cffc6f3b
CY
94952011-03-13 Chong Yidong <cyd@stupidchicken.com>
9496
9497 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9498 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9499 These macros can no longer be used for assignment.
9500
44f230aa
SM
9501 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9502 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9503 (record_buffer_markers, fetch_buffer_markers): New functions for
9504 recording and fetching special buffer markers.
9505 (set_buffer_internal_1, set_buffer_temp): Use them.
9506
9507 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9508
9509 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9510
9511 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9512 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9513
9514 * xdisp.c (hscroll_window_tree):
9515 (reconsider_clip_changes): Use PT instead of BUF_PT.
9516
d251f04b
EZ
95172011-03-13 Eli Zaretskii <eliz@gnu.org>
9518
9519 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9520 $(EMACS_ROOT)/lib/intprops.h.
9521
f0c77cd1
PE
95222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9523
3eca4629
PE
9524 Fix more problems found by GCC 4.5.2's static checks.
9525
7c86ee98
PE
9526 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9527 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9528 (xg_free_frame_widgets): Make it clear that a local variable is
9529 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9530 (gdk_window_get_screen): Make it clear that this macro is needed
9531 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9532 (int_gtk_range_get_value): New function, which avoids a diagnostic
9533 from gcc -Wbad-function-cast.
9534 (xg_set_toolkit_scroll_bar_thumb): Use it.
9535 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9536 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9537 (get_utf8_string, xg_get_file_with_chooser):
9538 Rename locals to avoid shadowing.
9539 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9540
41729b81
PE
9541 * xgselect.c (xg_select): Remove unused var.
9542
f0c77cd1
PE
9543 * image.c (four_corners_best): Mark locals as initialized.
9544 (gif_load): Initialize transparent_p to zero (Bug#8238).
9545 Mark another local as initialized.
ec6cf4c6 9546 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9547
ce0ad53d 9548 * image.c (clear_image_cache): Now static.
d5d5a617 9549 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9550 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9551 (x_edge_detection): Remove unnecessary cast that
9552 gcc -Wbad-function-cast diagnoses.
2037898d 9553 (gif_load): Fix pointer signedness.
6ae141d6
PE
9554 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9555 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9556
33383987 95572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9558
d32df629
PE
9559 Improve quality of tests for time stamp overflow.
9560 For example, without this patch (encode-time 0 0 0 1 1
9561 1152921504606846976) returns the obviously-bogus value (-948597
9562 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9563 reports time overflow. See
9564 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9565 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9566 * editfns.c: Include limits.h and intprops.h.
9567 (TIME_T_MIN, TIME_T_MAX): New macros.
9568 (time_overflow): Move earlier, to before first use.
9569 (hi_time, lo_time): New functions, for an accurate test for
9570 out-of-range times.
9571 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9572 (Fget_internal_run_time): Don't assume time_t fits in int.
9573 (make_time): Use list2 instead of Fcons twice.
9574 (Fdecode_time): More accurate test for out-of-range times.
9575 (check_tm_member): New function.
9576 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9577 (lisp_time_argument): Don't rely on undefined left-shift and
9578 right-shift behavior when checking for time stamp overflow.
8be6f318 9579
fe31d94c
PE
9580 * editfns.c (time_overflow): New function, refactoring common code.
9581 (Fformat_time_string, Fdecode_time, Fencode_time):
9582 (Fcurrent_time_string): Use it.
9583
8be6f318
PE
9584 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9585 * dired.c (make_time): Move to ...
9586 * editfns.c (make_time): ... here.
9587 * systime.h: Note the move.
9588
09d9db2c 95892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9590
126bc0dc
YM
9591 * fringe.c (update_window_fringes): Remove unused variables.
9592
c47cbdfd
YM
9593 * unexmacosx.c (copy_data_segment): Also copy __got section.
9594 (Bug#8223)
9595
7ac80be9
EZ
95962011-03-12 Eli Zaretskii <eliz@gnu.org>
9597
c96bbc66 9598 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9599 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9600 Constify `char *' arguments and their references according to
9601 prototypes in tparam.h.
9602
ecb0f94d 9603 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9604
7ac80be9
EZ
9605 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9606 Adapt all references accordingly.
9607
9608 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9609
ef1fd07e
TT
96102011-03-11 Tom Tromey <tromey@redhat.com>
9611
9612 * buffer.c (syms_of_buffer): Remove obsolete comment.
9613
7ef4b50c
EZ
96142011-03-11 Eli Zaretskii <eliz@gnu.org>
9615
9616 * termhooks.h (encode_terminal_code): Declare prototype.
9617
9618 * msdos.c (encode_terminal_code): Don't declare prototype.
9619
9620 * term.c (encode_terminal_code): Now external again, used by
9621 w32console.c and msdos.c.
9622
44f230aa
SM
9623 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9624 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9625
4b1ec863 96262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9627
1714f52b 9628 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9629
4b1ec863
PE
9630 * fringe.c (update_window_fringes): Mark locals as initialized
9631 (Bug#8227).
9632 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9633
524c7aa6
PE
9634 * alloc.c (mark_fringe_data): Move decl from here ...
9635 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9636 to check its interface.
9637 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9638
a5c0af81 9639 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9640 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9641 (fontset_font): Mark local as initialized.
a9a06e0b 9642 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9643
b4716021
PE
9644 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9645
811e9bac 9646 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9647 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9648 (x_own_selection, Fx_disown_selection_internal): Rename locals
9649 to avoid shadowing.
9650 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9651
7e3ab302
PE
9652 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9653 so that the caller can use some name other than gcpro1.
9654 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9655 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9656 (Fx_backspace_delete_keys_p):
9657 Use them to avoid shadowing, and rename vars to avoid shadowing.
9658 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9659 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9660 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9661 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9662 Remove unused locals.
7e3ab302
PE
9663 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9664 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9665 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9666 macros.
f78faa98 9667
e2b13473
PE
9668 * xterm.h (x_mouse_leave): New decl.
9669
77f23912
PE
9670 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9671 Remove unused functions.
cdf4ba58
PE
9672 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9673 (x_calc_absolute_position): Now static.
7411c686 9674 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9675 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9676 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9677 unless they are used.
38d0b34a
PE
9678 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9679 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9680 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9681 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9682 (x_error_catcher, x_connection_closed, x_error_handler):
9683 (x_error_quitter, xembed_send_message, x_iconify_frame):
9684 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9685 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9686 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9687
44f230aa
SM
9688 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9689 Rename or move locals to avoid shadowing.
6b463e58 9690 (tty_defined_color, merge_face_heights): Now static.
5967d051 9691 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9692 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9693 does not deduce is never used uninitialized.
73719eba
PE
9694 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9695 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9696
426994c3 9697 * terminal.c (store_terminal_param): Now static.
5489860b 9698
032f1620 9699 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9700 (set_frame_menubar): Remove unused local.
d4323972 9701 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9702 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9703 since they might point to immutable storage.
281585b0
PE
9704 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9705 since it's unused otherwise.
032f1620 9706
367c19e5 9707 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9708 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9709 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9710 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9711 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9712 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9713 does not deduce are never used uninitialized.
70739cbe 9714
07b48fa9
PE
9715 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9716
8868a238 9717 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9718 * window.c (window_loop, size_window):
9719 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9720
7e5cf297 9721 * window.c (display_buffer): Now static.
d6550a9f
PE
9722 (size_window): Mark variables that gcc -Wuninitialized
9723 does not deduce are never used uninitialized.
a586633d
PE
9724 * window.h (check_all_windows): New decl, to forestall
9725 gcc -Wmissing-prototypes diagnostic.
5b555da1 9726 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9727
f6095868
PE
9728 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9729 shadowing.
9730 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9731 Include <limits.h>.
9732 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9733 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9734 (load_charset_map): Mark variables that gcc -Wuninitialized
9735 does not deduce are never used uninitialized.
53df7c11 9736 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9737
f38b440c
PE
9738 * coding.c (coding_set_source, coding_set_destination):
9739 Use "else { /* comment */ }" rather than "else /* comment */;"
9740 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9741 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9742 a block, when the outer 'i' will do.
9743 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9744 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9745 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9746 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9747 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9748 Rename locals to avoid shadowing.
9749 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9750 * coding.c (emacs_mule_char, encode_invocation_designation):
9751 Now static, since they're not used elsewhere.
413bb2db 9752 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9753 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9754 (decode_coding_emacs_mule): Mark variables that gcc
9755 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9756 (detect_coding_iso_2022): Initialize a local variable that might
9757 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9758 this initialization is needed. (Bug#8211)
5f58e762
PE
9759 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9760 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9761 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9762 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9763 Remove unused macros.
f38b440c 9764
232b38b9 9765 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9766 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9767 * character.c (string_count_byte8): Likewise.
232b38b9 9768
fb90da1b
PE
9769 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9770 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9771
fb93dbc2
PE
9772 * chartab.c (copy_sub_char_table): Now static, since it's not used
9773 elsewhere.
5c156ace
PE
9774 (sub_char_table_ref_and_range, char_table_ref_and_range):
9775 Rename locals to avoid shadowing.
bbcd0949 9776 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9777
7d3b3862 9778 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9779 (BIDI_BOB): Remove unused macro.
7d3b3862 9780
6be7d3da
PE
9781 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9782 deduce are never used uninitialized.
c2ed9c8b 9783 * term.c (encode_terminal_code): Likewise.
6be7d3da 9784
75f8807f 9785 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9786
50938595
PE
9787 * tparam.h: New file.
9788 * term.c, tparam.h: Include it.
9789 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9790 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9791 Move these decls to tparam.h, and make them agree with what
9792 is actually in tparam.c. The previous trick of using incompatible
9793 decls in different modules does not conform to the C standard.
9794 All callers of tparam changed to use tparam's actual API.
9795 * tparam.c (tparam1, tparam, tgoto):
9796 Use const pointers where appropriate.
9797
fbceeba2
PE
9798 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9799 * cm.h (struct cm): Likewise.
9800 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9801 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9802 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9803 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9804 (turn_on_face, init_tty): Likewise.
9805 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9806
7f3f1250
PE
9807 * term.c (term_mouse_position): Rename local to avoid shadowing.
9808
e6ca6543
PE
9809 * alloc.c (mark_ttys): Move decl from here ...
9810 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9811
c40f8d15
AS
98122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9813
9814 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9815
cfe0661d
JB
98162011-03-09 Juanma Barranquero <lekktu@gmail.com>
9817
9818 * search.c (compile_pattern_1): Remove argument regp, unused since
9819 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9820 (compile_pattern): Don't pass it.
9821
0afb4571
J
98222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9823
9824 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9825 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9826 for ! HAVE_GTK3.
9827 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9828
9829 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9830
9831 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9832 gdk_window_get_screen, gdk_window_get_geometry,
9833 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9834 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9835 (xg_get_pixbuf_from_pixmap): New function.
9836 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9837 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9838 Call xg_get_pixbuf_from_pixmap instead of
9839 gdk_pixbuf_get_from_drawable.
9840 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9841 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9842 (xg_check_special_colors): Use GtkStyleContext and its functions
9843 for HAVE_GTK3.
9844 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9845 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9846 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9847 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9848 Call gtk_widget_get_preferred_size.
0afb4571
J
9849 (xg_frame_resized): gdk_window_get_geometry only takes 5
9850 parameters.
44f230aa
SM
9851 (xg_win_to_widget, xg_event_is_for_menubar):
9852 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9853 (xg_set_widget_bg): New function.
9854 (delete_cb): New function.
895009e1 9855 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9856 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9857 (xg_set_background_color): Call xg_set_widget_bg.
9858 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9859 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9860 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9861 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9862 if ! HAVE_GTK3.
9863 (update_frame_tool_bar): Call gtk_widget_hide.
9864 (xg_initialize): Use GDK_KEY_g.
9865
9866 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9867 if ! HAVE_GTK3
9868 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9869
9870 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9871 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9872 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9873
1c2cc4ef
JB
98742011-03-08 Juanma Barranquero <lekktu@gmail.com>
9875
9876 * w32xfns.c (select_palette): Check success of RealizePalette against
9877 GDI_ERROR, not zero.
9878
33383987 9879See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9880
9881;; Local Variables:
9882;; coding: utf-8
aac0c6e3
MR
9883;; End:
9884
2f097256 9885 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9886
9887 This file is part of GNU Emacs.
9888
9889 GNU Emacs is free software: you can redistribute it and/or modify
9890 it under the terms of the GNU General Public License as published by
9891 the Free Software Foundation, either version 3 of the License, or
9892 (at your option) any later version.
9893
9894 GNU Emacs is distributed in the hope that it will be useful,
9895 but WITHOUT ANY WARRANTY; without even the implied warranty of
9896 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9897 GNU General Public License for more details.
9898
9899 You should have received a copy of the GNU General Public License
9900 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.