Don't make popup frames unsplittable by default.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7f3f739f
LL
12011-06-21 Leo Liu <sdl.web@gmail.com>
2
3 * deps.mk (fns.o):
4 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5 sha512.h.
6
7 * fns.c (secure_hash): Rename from crypto_hash_function and change
8 the first arg to accept symbols.
9 (Fsecure_hash): New primtive.
10 (syms_of_fns): New symbols.
11
76147d94
DD
122011-06-20 Deniz Dogan <deniz@dogan.se>
13
14 * process.c (Fset_process_buffer): Clarify return value in
15 docstring.
16
7d7d0045
CY
172011-06-18 Chong Yidong <cyd@stupidchicken.com>
18
19 * dispnew.c (add_window_display_history): Use BVAR.
20
21 * xdisp.c (debug_method_add): Use BVAR.
22 (check_window_end, dump_glyph_matrix, dump_glyph)
23 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
24
25 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
26 Likewise.
27
28 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
29 check till after the cache is created in init_frame_faces.
30
ff2bc410
SM
312011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
32
33 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
34
28177add
PE
352011-06-16 Paul Eggert <eggert@cs.ucla.edu>
36
dd3482fe
PE
37 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
38 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
39 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
40
393d71f3 41 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
42 * fileio.c (Finsert_file_contents):
43 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
44 Remove the old (too-loose) buffer overflow checks.
45 They weren't needed, since make_gap checks for buffer overflow.
46 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
47 The old code merely checked for Emacs fixnum overflow, and relied
48 on undefined (wraparound) behavior. The new code avoids undefined
49 behavior, and also checks for ptrdiff_t and/or size_t overflow.
50
2e6813b0 51 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
52 Tune. Don't use wider integers than needed. Don't use alloca.
53 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 54
599a9e4f
PE
55 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
56
99561444
PE
57 * insdel.c, lisp.h (buffer_overflow): New function.
58 (insert_from_buffer_1, replace_range, replace_range_2):
59 * insdel.c (make_gap_larger):
60 * editfns.c (Finsert_char):
61 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
62
28177add
PE
63 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
64
e69dafad
PE
652011-06-15 Paul Eggert <eggert@cs.ucla.edu>
66
a7af7fde 67 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 68
b1c46f02
PE
69 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
70 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
71
e69dafad
PE
72 * fileio.c: Don't assume EMACS_INT fits in off_t.
73 (emacs_lseek): New static function.
74 (Finsert_file_contents, Fwrite_region): Use it.
75 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
76
566684ea
PE
77 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
78
e6966cd6
PE
79 * fns.c: Don't overflow int when computing a list length.
80 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
81 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
82 truncation on 64-bit hosts. Check for QUIT every
83 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
84 faster and is responsive enough.
85 (Flength): Report an error instead of overflowing an integer.
86 (Fsafe_length): Return a float if the value is not representable
87 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 88 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 89 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 90
dd0b0efb
PE
91 * alloc.c: Check that resized vectors' lengths fit in fixnums.
92 (header_size, word_size): New constants.
93 (allocate_vectorlike): Don't check size overflow here.
94 (allocate_vector): Check it here instead, since this is the only
95 caller of allocate_vectorlike that could cause overflow.
96 Check that the new vector's length is representable as a fixnum.
97
86fe5cfe
PE
98 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
99 The previous code was bogus. For example, next_almost_prime (32)
100 returned 39, which is undesirable as it is a multiple of 3; and
101 next_almost_prime (24) returned 25, which is a multiple of 5 so
102 why was the code bothering to check for multiples of 7?
103
80e88859
PE
104 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
105
4a2f0ad6
PE
106 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
107
f66c7cf8
PE
108 Variadic C functions now count arguments with ptrdiff_t.
109 This partly undoes my 2011-03-30 change, which replaced int with size_t.
110 Back then I didn't know that the Emacs coding style prefers signed int.
111 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
112 were being counted with int, which may truncate counts on 64-bit
113 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
114 * lisp.h (struct Lisp_Subr.function.aMANY)
115 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
116 Arg counts are now ptrdiff_t, not size_t.
117 All variadic functions and their callers changed accordingly.
118 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
119 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
120 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
121 * callint.c (Fcall_interactively): Check arg count for overflow,
122 to avoid potential buffer overrun. Use signed char, not 'int',
123 for 'varies' array, so that we needn't bother to check its size
124 calculation for overflow.
125 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
126 * eval.c (apply_lambda):
127 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
128 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
129 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
130
a1759b76
PE
131 * callint.c (Fcall_interactively): Don't use index var as event count.
132
d96be9fc
PE
133 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
134 * mem-limits.h (SIZE): Remove; no longer used.
135
a690a978 136 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 137
578c21e6
PE
138 Remove unnecessary casts.
139 * xterm.c (x_term_init):
140 * xfns.c (x_set_border_pixel):
141 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
142 These aren't needed now that we assume ANSI C.
143
96f53c6c
PE
144 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
145 It's more likely to cause problems (due to unsigned overflow)
146 than to cure them.
147
83c77d31
PE
148 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
149
ee2079f1
PE
150 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
151
6da65536
PE
152 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
153
7147c4a4
PE
154 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
155
193e32d9
PE
156 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
157
e5533da6
PE
158 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
159
9910e595
PE
160 GLYPH_CODE_FACE returns EMACS_INT, not int.
161 * dispextern.h (merge_faces):
162 * xfaces.c (merge_faces):
01103c44
PE
163 * xdisp.c (get_next_display_element, next_element_from_display_vector):
164 Don't assume EMACS_INT fits in int.
9910e595 165
2638320e
PE
166 * character.h (CHAR_VALID_P): Remove unused parameter.
167 * fontset.c, lisp.h, xdisp.c: All uses changed.
168
045eb8d9
PE
169 * editfns.c (Ftranslate_region_internal): Omit redundant test.
170
c1f134b5
PE
171 * fns.c (concat): Minor tuning based on overflow analysis.
172 This doesn't fix any bugs. Use int to hold character, instead
173 of constantly refetching from Emacs object. Use XFASTINT, not
174 XINT, for value known to be a character. Don't bother comparing
175 a single byte to 0400, as it's always less.
176
395fcb93 177 * floatfns.c (Fexpt):
327eeec8
PE
178 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
179
abbd3d23
PE
180 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
181 for characters.
182
684a03ef
PE
183 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
184
0fed43f3
PE
185 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
186 Without this fix, on a 64-bit host (aset S 0 4294967386) would
187 incorrectly succeed when S was a string, because 4294967386 was
188 truncated before it was used.
189
8fd02eb7
PE
190 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
191 Otherwise, an out-of-range integer could cause undefined behavior
192 on a 64-bit host.
193
f8c86b69
PE
194 * composite.c: Use int, not EMACS_INT, for characters.
195 (fill_gstring_body, composition_compute_stop_pos): Use int, not
196 EMACS_INT, for values that are known to be in character range.
197 This doesn't fix any bugs but is the usual style inside Emacs and
198 may generate better code on 32-bit machines.
199
34206dd2
PE
200 Make sure a 64-bit char is never passed to ENCODE_CHAR.
201 This is for reasons similar to the recent CHAR_STRING fix.
202 * charset.c (Fencode_char): Check that character arg is actually
203 a character. Pass an int to ENCODE_CHAR.
204 * charset.h (ENCODE_CHAR): Verify that the character argument is no
205 wider than 'int', as a compile-time check to prevent future regressions
206 in this area.
207
c5958d4c 208 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
209
210 Make sure a 64-bit char is never passed to CHAR_STRING.
211 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
212 by silently ignoring the top 32 bits, allowing some values
213 that were far too large to be valid characters.
214 * character.h: Include <verify.h>.
215 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
216 arguments are no wider than unsigned, as a compile-time check
217 to prevent future regressions in this area.
218 * data.c (Faset):
01103c44 219 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
220 (Fsubst_char_in_region):
221 * fns.c (concat):
222 * xdisp.c (decode_mode_spec_coding):
223 Adjust to CHAR_STRING's new requirement.
224 * editfns.c (Finsert_char, Fsubst_char_in_region):
225 * fns.c (concat): Check that character args are actually
226 characters. Without this test, these functions did the wrong
227 thing with wildly out-of-range values on 64-bit hosts.
228
d37ca623
PE
229 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
230 These casts should not be needed on 32-bit hosts, either.
231 * keyboard.c (read_char):
232 * lread.c (Fload): Remove casts to unsigned.
233
ea204efb
PE
234 * lisp.h (UNSIGNED_CMP): New macro.
235 This fixes comparison bugs on 64-bit hosts.
236 (ASCII_CHAR_P): Use it.
237 * casefiddle.c (casify_object):
01103c44 238 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
239 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
240 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
241 * dispextern.h (FACE_FROM_ID):
242 * keyboard.c (read_char): Use UNSIGNED_CMP.
243
41cb286c
PE
244 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
245 not to EMACS_INT, to avoid GCC warning.
246
4a1b9832
PE
247 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
248
55daad71
PE
249 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
250 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
251 isn't needed on 32-bit machines.
8f95c75c 252
01103c44
PE
253 * buffer.c (Fgenerate_new_buffer_name):
254 Use EMACS_INT for count, not int.
0ceccced 255 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
256
257 * data.c (Qcompiled_function): Now static.
258
c6f072e7
PE
259 * window.c (window_body_lines): Now static.
260
20ce5912
PE
261 * image.c (gif_load): Rename local to avoid shadowing.
262
9c4c5f81
PE
263 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
264 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
265 * alloc.c (make_save_value): Integer argument is now of type
266 ptrdiff_t, not int.
267 (mark_object): Use ptrdiff_t, not int.
268 * lisp.h (pD): New macro.
269 * print.c (print_object): Use it.
270
c0c5c8ae
PE
271 * alloc.c: Use EMACS_INT, not int, to count objects.
272 (total_conses, total_markers, total_symbols, total_vector_size)
273 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
274 (total_free_floats, total_floats, total_free_intervals)
275 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
276 Now EMACS_INT, not int. All uses changed.
277 (Fgarbage_collect): Compute overall total using a double, so that
278 integer overflow is less likely to be a problem. Check for overflow
279 when converting back to an integer.
5a25e253
PE
280 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
281 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
282 These were 'int' variables that could overflow on 64-bit hosts;
283 they were never used, so remove them instead of repairing them.
211a0b2a 284 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
285 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
286 Previously, this ceilinged at INT_MAX, but that doesn't work on
287 64-bit machines.
e46bb31a 288 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 289
c78baabf 290 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 291 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
292 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
293 when a (possibly-narrower) signed value would do just as well.
294 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 295
c9d624c6
PE
296 * alloc.c: Catch some string size overflows that we were missing.
297 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
298 for convenience in STRING_BYTES_MAX.
299 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
300 The definition here is exact; the one in lisp.h was approximate.
301 (allocate_string_data): Check for string overflow. This catches
302 some instances we weren't catching before. Also, it catches
303 size_t overflow on (unusual) hosts where SIZE_MAX <= min
304 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
305 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 306
c9d624c6
PE
307 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
308 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
309 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
310
353032ce
PE
311 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
312
2bccce07
PE
313 * alloc.c (Fmake_string): Check for out-of-range init.
314
0ac30604
SM
3152011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
316
317 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
318
c195f2de
JD
3192011-06-14 Jan Djärv <jan.h.d@swipnet.se>
320
321 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
322 xg_get_default_scrollbar_width.
323
324 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
325 (int_gtk_range_get_value): Move to the scroll bar part of the file.
326 (style_changed_cb): Call update_theme_scrollbar_width and call
327 x_set_scroll_bar_default_width and xg_frame_set_char_size for
328 all frames (Bug#8505).
329 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
330 Call gtk_window_set_resizable if HAVE_GTK3.
331 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
332 and height if HAVE_GTK3 (Bug#8505).
333 (scroll_bar_width_for_theme): New variable.
334 (update_theme_scrollbar_width): New function.
335 (xg_get_default_scrollbar_width): Move code to
336 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
337 (xg_initialize): Call update_theme_scrollbar_width.
338
339 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
340
341 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
342
e10ac9f1
MR
3432011-06-12 Martin Rudalics <rudalics@gmx.at>
344
345 * frame.c (make_frame): Call other_buffer_safely instead of
346 other_buffer.
347
348 * window.c (temp_output_buffer_show): Call display_buffer with
349 second argument Vtemp_buffer_show_specifiers and reset latter
350 immediately after the call.
351 (Vtemp_buffer_show_specifiers): New variable.
352 (auto_window_vscroll_p, next_screen_context_lines)
353 (Vscroll_preserve_screen_position): Remove leading asterisks from
354 doc-strings.
355
2d3c217e 3562011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 357
7b7f97e8 358 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
359 * buffer.c (Qclone_number): Remove for now, as it's unused.
360 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
361 (record_buffer): Remove unused local.
362 * frame.c (other_visible_frames, frame_buffer_list): Now static.
363 (set_frame_buffer_list): Remove; unused.
364 * frame.h (other_visible_frames): Remove decl.
365 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
366 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
367 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
368 if HAVE_GPM.
369 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
370 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
371 Define only if HAVE_GPM.
372 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
373 (update_hints_inhibit): Remove; never set. All uses removed.
374 * widgetprv.h (emacsFrameClassRec): Remove decl.
375 * window.c (delete_deletable_window): Now returns void, since it
376 wasn't returning anything.
377 (compare_window_configurations): Remove unused locals.
378 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
379 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
380 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
381 the same widths as pointers. This follows up on the 2011-05-06 patch.
382 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
383 * xterm.h: Likewise.
384 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
385
1384b89e
JB
3862011-06-12 Juanma Barranquero <lekktu@gmail.com>
387
388 * makefile.w32-in: Update dependencies.
389 (LISP_H): Add lib/intprops.h.
390
1100a63c
CY
3912011-06-11 Chong Yidong <cyd@stupidchicken.com>
392
393 * image.c (gif_load): Add animation frame delay to the metadata.
394 (syms_of_image): Use DEFSYM. New symbol `delay'.
395
6198ccd0
MR
3962011-06-11 Martin Rudalics <rudalics@gmx.at>
397
398 * window.c (delete_deletable_window): Re-add.
399 (Fset_window_configuration): Rewrite to handle dead buffers and
400 consequently deletable windows.
401 (window_tree, Fwindow_tree): Remove. Supply functionality in
402 window.el.
403 (compare_window_configurations): Simplify code.
404
b6e3633c
AS
4052011-06-11 Andreas Schwab <schwab@linux-m68k.org>
406
1ab0dee5
AS
407 * image.c (imagemagick_load_image): Fix type mismatch.
408 (Fimagemagick_types): Likewise.
409
b6e3633c
AS
410 * window.h (replace_buffer_in_windows): Declare.
411
9397e56f
MR
4122011-06-11 Martin Rudalics <rudalics@gmx.at>
413
414 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
415 Qclone_number. Remove external declaration of Qdelete_window.
416 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
417 code.
418 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
419 Qbuffer_list_update_hook if allowed.
420 (Fother_buffer): Rewrite doc-string. Major rewrite for new
421 buffer list implementation.
422 (other_buffer_safely): New function.
423 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
424 calls to replace_buffer_in_windows and
425 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
426 if allowed.
427 (record_buffer): Inhibit quitting and rewrite using quittable
428 functions. Run Qbuffer_list_update_hook if allowed.
429 (Frecord_buffer, Funrecord_buffer): New functions.
430 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
431 switch-to-buffer to window.el.
432 (bury-buffer): Move to window.el.
433 (Vbuffer_list_update_hook): New variable.
434
435 * lisp.h (other_buffer_safely): Add prototype in buffer.c
436 section.
437
438 * window.h (resize_frame_windows): Move up in code.
439 (Fwindow_frame): Remove EXFUN.
440 (replace_buffer_in_all_windows): Remove prototype.
441 (replace_buffer_in_windows_safely): Add prototype.
442
443 * window.c: Declare Qdelete_window static again. Move down
444 declaration of select_count.
445 (Fnext_window, Fprevious_window): Rewrite doc-strings.
446 (Fother_window): Move to window.el.
447 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
448 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
449 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
450 window.el.
451 (replace_buffer_in_windows): Implement by calling
452 Qreplace_buffer_in_windows.
453 (replace_buffer_in_all_windows): Remove with some functionality
454 moved into replace_buffer_in_windows_safely.
455 (replace_buffer_in_windows_safely): New function.
456 (select_window_norecord, select_frame_norecord): Move in front
457 of run_window_configuration_change_hook. Remove now obsolete
458 declarations.
459 (Fset_window_buffer): Rewrite doc-string. Call
460 Qrecord_window_buffer.
461 (keys_of_window): Move binding for other-window to window.el.
462
b50691aa
CY
4632011-06-11 Chong Yidong <cyd@stupidchicken.com>
464
465 * dispextern.h (struct image): Replace data member, whose int_val
466 and ptr_val fields were not used by anything, with a single
467 lisp_val object.
468
469 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
470 (gif_clear_image, gif_load, imagemagick_load_image)
471 (gs_clear_image, gs_load): Callers changed.
472
3f754b86
PE
4732011-06-10 Paul Eggert <eggert@cs.ucla.edu>
474
cca69397
PE
475 * buffer.h: Include <time.h>, for time_t.
476 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
477
109e28d0
PE
478 Fix minor problems found by static checking.
479
60737f02
PE
480 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
481
4b66faf3
PE
482 Make identifiers static if they are not used in other modules.
483 * data.c (Qcompiled_function, Qframe, Qvector):
484 * image.c (QimageMagick, Qsvg):
485 * minibuf.c (Qmetadata):
486 * window.c (resize_window_check, resize_root_window): Now static.
487 * window.h (resize_window_check, resize_root_window): Remove decls.
488
109e28d0
PE
489 * window.c (window_deletion_count, delete_deletable_window):
490 Remove; unused.
46a4ce9e
PE
491 (window_body_lines): Now static.
492 (Fdelete_other_windows_internal): Mark vars as initialized.
493 Make sure 'resize_failed' is initialized.
494 (run_window_configuration_change_hook): Rename local to avoid shadowing.
495 (resize_window_apply): Remove unused local.
496 * window.h (delete_deletable_window): Remove decl.
497
109e28d0 498 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
499 (imagemagick_load_image): Fix pointer signedness problem by changing
500 last arg from unsigned char * to char *. All uses changed.
501 Also, fix a local for similar reasons.
502 Remove unused locals. Remove locals to avoid shadowing.
503 (fn_rsvg_handle_free): Remove; unused.
504 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 505 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 506
3f754b86
PE
507 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
508
2547adb1
CY
5092011-06-10 Chong Yidong <cyd@stupidchicken.com>
510
511 * image.c (gif_load): Fix omitted cast error introduced by
512 2011-06-06 change.
513
2c8e37d4
MR
5142011-06-10 Martin Rudalics <rudalics@gmx.at>
515
516 * window.h (resize_proportionally, orig_total_lines)
517 (orig_top_line): Remove from window structure.
518 (set_window_height, set_window_width, change_window_heights)
519 (Fdelete_window): Remove prototypes.
520 (resize_frame_windows): Remove duplicate declaration.
521
440a42e3
EZ
5222011-06-10 Eli Zaretskii <eliz@gnu.org>
523
524 * window.h (resize_frame_windows, resize_window_check)
525 (delete_deletable_window, resize_root_window)
526 (resize_frame_windows): Declare prototypes.
527
528 * window.c (resize_window_apply): Make definition be "static" to
529 match the prototype.
530
562dd5e9
MR
5312011-06-10 Martin Rudalics <rudalics@gmx.at>
532
533 * window.c: Remove declarations of Qwindow_size_fixed,
534 window_min_size_1, window_min_size_2, window_min_size,
535 size_window, window_fixed_size_p, enlarge_window, delete_window.
536 Remove static from declaration of Qdelete_window, it's
537 temporarily needed by Fbury_buffer.
538 (replace_window): Don't assign orig_top_line and
539 orig_total_lines.
540 (Fdelete_window, delete_window): Remove. Window deletion is
541 handled by window.el.
542 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
543 Fdelete_window calls with calls to Qdelete_window.
544 (Fdelete_other_windows): Remove. Deleting other windows is
545 handled by window.el.
546 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
547 handled in window.el.
548 (window_min_size_2, window_min_size_1, window_min_size): Remove.
549 Window minimum sizes are handled in window.el.
550 (shrink_windows, size_window, set_window_height)
551 (set_window_width, change_window_heights, window_height)
552 (window_width, CURBEG, CURSIZE, enlarge_window)
553 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
554 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
555 handled in window.el.
556 (make_dummy_parent): Rename to make_parent_window and give it a
557 second argument horflag.
558 (make_window): Don't set resize_proportionally any more.
559 (Fsplit_window): Remove. Windows are split in window.el.
560 (save_restore_action, save_restore_orig_size)
561 (shrink_window_lowest_first, save_restore_orig_size): Remove.
562 Resize mini windows in window.el.
563 (grow_mini_window, shrink_mini_window): Implement by calling
564 Qresize_root_window_vertically, resize_window_check and
565 resize_window_apply.
566 (saved_window, Fset_window_configuration, save_window_save): Do
567 not handle orig_top_line, orig_total_lines, and
568 resize_proportionally.
569 (window_min_height, window_min_width): Move to window.el.
570 (keys_of_window): Move bindings for delete-other-windows,
571 split-window, delete-window and enlarge-window to window.el.
572
573 * buffer.c: Temporarily extern Qdelete_window.
574 (Fbury_buffer): Temporarily call Qdelete_window instead of
575 Fdelete_window (Fbury_buffer will move to window.el soon).
576
577 * frame.c (set_menu_bar_lines_1): Remove code handling
578 orig_top_line and orig_total_lines.
579
580 * dispnew.c (adjust_frame_glyphs_initially): Don't use
581 set_window_height but set heights directly.
582 (change_frame_size_1): Use resize_frame_windows.
583
584 * xdisp.c (init_xdisp): Don't use set_window_height but set
585 heights directly.
586
587 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
588 resize_frame_windows instead of change_window_heights and run
589 run_window_configuration_change_hook.
590
591 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
592 instead of change_window_heights and run
593 run_window_configuration_change_hook.
594
1a13852e
MR
5952011-06-09 Martin Rudalics <rudalics@gmx.at>
596
597 * window.c (replace_window): Rename second argument REPLACEMENT to
598 NEW. New third argument SETFLAG. Rewrite.
599 (delete_window, make_dummy_parent): Call replace_window with
600 third argument 1.
601 (window_list_1): Move down in code.
602 (run_window_configuration_change_hook): Move set_buffer part
603 before select_frame_norecord part in order to unwind correctly.
604 Rename count1 to count.
605 (recombine_windows, delete_deletable_window, resize_root_window)
606 (Fdelete_other_windows_internal)
607 (Frun_window_configuration_change_hook, make_parent_window)
608 (resize_window_check, resize_window_apply, Fresize_window_apply)
609 (resize_frame_windows, Fsplit_window_internal)
610 (Fdelete_window_internal, Fresize_mini_window_internal): New
611 functions.
612 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
613
f3d1777e
MR
6142011-06-08 Martin Rudalics <rudalics@gmx.at>
615
496e208e
MR
616 * window.h (window): Add some new members to window structure -
617 normal_lines, normal_cols, new_total, new_normal, clone_number,
618 splits, nest, prev_buffers, next_buffers.
619 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 620 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 621
f3d1777e
MR
622 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
623 Remove.
496e208e
MR
624 (make_dummy_parent): Set new members of windows structure.
625 (make_window): Move down in code. Handle new members of window
626 structure.
627 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
628 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
629 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
630 (Fset_window_prev_buffers, Fwindow_next_buffers)
631 (Fset_window_next_buffers, Fset_window_clone_number): New
632 functions.
633 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
634 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
635 Doc-string fixes.
636 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
637 Argument WINDOW can be now internal window too.
638 (Fwindow_use_time): Move up in code.
639 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
640 Rewrite doc-string.
641 (Fset_window_configuration, saved_window)
642 (Fcurrent_window_configuration, save_window_save): Handle new
643 members of window structure.
b9e809c2
MR
644 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
645 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
646 (syms_of_window): New Lisp objects Qrecord_window_buffer,
647 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
648 Qget_mru_window, Qresize_root_window,
649 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
650 Qauto_buffer_name; staticpro them.
f3d1777e 651
abde8f8c
MR
6522011-06-07 Martin Rudalics <rudalics@gmx.at>
653
654 * window.c (Fwindow_total_size, Fwindow_left_column)
655 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
656 (Fwindow_list_1): New functions.
657 (window_box_text_cols): Replace with window_body_cols.
658 (Fwindow_width, Fscroll_left, Fscroll_right): Use
659 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
660 (delete_window, Fset_window_configuration): Call
661 delete_all_subwindows with window as argument.
662 (delete_all_subwindows): Take a window as argument and not a
663 structure. Rewrite.
190b47e6
MR
664 (window_loop): Remove handling of GET_LRU_WINDOW and
665 GET_LARGEST_WINDOW.
666 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
667
668 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
669 window_box_text_cols. delete_all_subwindows now takes a
670 Lisp_Object as argument.
abde8f8c
MR
671
672 * indent.c (compute_motion, Fcompute_motion): Use
673 window_body_cols instead of window_box_text_cols.
674
fa8a67e6
MR
675 * frame.c (delete_frame): Call delete_all_subwindows with root
676 window as argument.
677
a54e3482
DC
6782011-06-07 Daniel Colascione <dan.colascione@gmail.com>
679
680 * fns.c (Fputhash): Document return value.
681
60002bf5
CY
6822011-06-06 Chong Yidong <cyd@stupidchicken.com>
683
684 * image.c (gif_load): Implement gif89a spec "no disposal" method.
685
0c671da6 6862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 687
b862a52a 688 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 689
be44ca6c
PE
690 Check for overflow when converting integer to cons and back.
691 * charset.c (Fdefine_charset_internal, Fdecode_char):
692 Use cons_to_unsigned to catch overflow.
693 (Fencode_char): Use INTEGER_TO_CONS.
694 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
695 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
696 * data.c (long_to_cons, cons_to_long): Remove.
697 (cons_to_unsigned, cons_to_signed): New functions.
698 These signal an error for invalid or out-of-range values.
699 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
700 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
701 * font.c (Ffont_variation_glyphs):
702 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
703 * lisp.h: Include <intprops.h>.
704 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
705 (cons_to_signed, cons_to_unsigned): New decls.
706 (long_to_cons, cons_to_long): Remove decls.
707 * undo.c (record_first_change): Use INTEGER_TO_CONS.
708 (Fprimitive_undo): Use CONS_TO_INTEGER.
709 * xfns.c (Fx_window_property): Likewise.
710 * xselect.c: Include <limits.h>.
711 (x_own_selection, selection_data_to_lisp_data):
712 Use INTEGER_TO_CONS.
713 (x_handle_selection_request, x_handle_selection_clear)
714 (x_get_foreign_selection, Fx_disown_selection_internal)
715 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
716 (lisp_data_to_selection_data): Use cons_to_unsigned.
717 (x_fill_property_data): Use cons_to_signed.
718 Report values out of range.
719
d1f3d2af
PE
720 Check for buffer and string overflow more precisely.
721 * buffer.h (BUF_BYTES_MAX): New macro.
722 * lisp.h (STRING_BYTES_MAX): New macro.
723 * alloc.c (Fmake_string):
724 * character.c (string_escape_byte8):
725 * coding.c (coding_alloc_by_realloc):
726 * doprnt.c (doprnt):
727 * editfns.c (Fformat):
728 * eval.c (verror):
729 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
730 since they may not be the same number.
731 * editfns.c (Finsert_char):
732 * fileio.c (Finsert_file_contents):
733 Likewise for BUF_BYTES_MAX.
734
dd52fcea
PE
735 * image.c: Use ptrdiff_t, not int, for sizes.
736 (slurp_file): Switch from int to ptrdiff_t.
737 All uses changed.
738 (slurp_file): Check that file size fits in both size_t (for
739 malloc) and ptrdiff_t (for sanity and safety).
740
7f9bbdbb
PE
741 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
742 if b->modtime has its maximal value.
743
dfe18f82
PE
744 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
745
84acfcf0
PE
746 Don't assume time_t can fit into int.
747 * buffer.h (struct buffer.modtime): Now time_t, not int.
748 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
749 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
750
ccd9a01a
PE
751 Minor fixes for signed vs unsigned integers.
752 * character.h (MAYBE_UNIFY_CHAR):
753 * charset.c (maybe_unify_char):
754 * keyboard.c (read_char, reorder_modifiers):
755 XINT -> XFASTINT, since the integer must be nonnegative.
756 * ftfont.c (ftfont_spec_pattern):
757 * keymap.c (access_keymap, silly_event_symbol_error):
758 XUINT -> XFASTINT, since the integer must be nonnegative.
759 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
760 since it makes no difference and we prefer signed.
761 * keyboard.c (record_char): Use XUINT when all the neighbors do.
762 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
763 nonnegative.
764
d6d100dd
SM
7652011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
766
767 * window.h (Fwindow_frame): Declare.
768
2b6148e4
PE
7692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
770
771 * alloc.c: Simplify handling of large-request failures (Bug#8800).
772 (SPARE_MEMORY): Always define.
773 (LARGE_REQUEST): Remove.
774 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
775
f230ecc9
MR
7762011-06-06 Martin Rudalics <rudalics@gmx.at>
777
727e958e
MR
778 * lisp.h: Move EXFUNS for Fframe_root_window,
779 Fframe_first_window and Fset_frame_selected_window to window.h.
780
781 * window.h: Move EXFUNS for Fframe_root_window,
782 Fframe_first_window and Fset_frame_selected_window here from
783 lisp.h.
784
785 * frame.c (Fwindow_frame, Fframe_first_window)
786 (Fframe_root_window, Fframe_selected_window)
787 (Fset_frame_selected_window): Move to window.c.
788 (Factive_minibuffer_window): Move to minibuf.c.
789 (Fother_visible_frames_p): New function.
790
791 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
792
f230ecc9
MR
793 * window.c (decode_window, decode_any_window): Move up in code.
794 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
795 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
796 (Fwindow_buffer): Move up and rewrite doc-string.
797 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
798 (Fwindow_prev): New functions.
727e958e
MR
799 (Fwindow_frame): Move here from frame.c. Accept any window as
800 argument.
801 (Fframe_root_window, Fframe_first_window)
802 (Fframe_selected_window): Move here from frame.c. Accept frame
803 or arbitrary window as argument. Update doc-strings.
804 (Fminibuffer_window): Move up in code.
805 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
806 (Fset_frame_selected_window): Move here from frame.c.
807 Marginal rewrite.
727e958e
MR
808 (Fselected_window, select_window, Fselect_window): Move up in
809 code. Minor doc-string fixes.
f230ecc9 810
4d09bcf6
PE
8112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
812
813 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
814 Do not assume that spare memory exists; that assumption is valid
815 only if SYSTEM_MALLOC.
816 (LARGE_REQUEST): New macro, so that the issue of large requests
817 is separated from the issue of spare memory.
818
810928a2
AS
8192011-06-05 Andreas Schwab <schwab@linux-m68k.org>
820
172418ad
AS
821 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
822 format. (Bug#8806)
823
43f862f7
AS
824 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
825
810928a2
AS
826 * xfns.c (x_set_scroll_bar_default_width): Move declarations
827 before statements.
828
a059fe24
JD
8292011-06-05 Jan Djärv <jan.h.d@swipnet.se>
830
831 * gtkutil.c (xg_get_default_scrollbar_width): New function.
832
833 * gtkutil.h: Declare xg_get_default_scrollbar_width.
834
835 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
836 min width by calling x_set_scroll_bar_default_width (Bug#8505).
837
989bf368
JB
8382011-06-05 Juanma Barranquero <lekktu@gmail.com>
839
840 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
841
4b80f674
CY
8422011-06-04 Chong Yidong <cyd@stupidchicken.com>
843
844 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
845 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
846 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
847 New error handlers.
4b80f674
CY
848 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
849 Obey Vx_select_enable_clipboard_manager. Catch errors in
850 x_clipboard_manager_save (Bug#8779).
851 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 852 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 853
99a33b77 8542011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
855
856 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
857
99a33b77 8582011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
859
860 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
861 in the current matrix if keep_current_p is non-zero.
862
8264569d
EZ
8632011-06-04 Eli Zaretskii <eliz@gnu.org>
864
865 * bidi.c (bidi_level_of_next_char): Fix last change.
866
57f97249
EZ
8672011-06-03 Eli Zaretskii <eliz@gnu.org>
868
fec2107c 869 Support bidi reordering of text covered by display properties.
57f97249 870
fec2107c
EZ
871 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
872 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
873 (bidi_cache_search, bidi_cache_iterator_state)
874 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
875 (bidi_level_of_next_char, bidi_move_to_visually_next):
876 Support character positions inside a run of characters covered by a
fec2107c
EZ
877 display string.
878 (bidi_paragraph_init, bidi_resolve_explicit_1)
879 (bidi_level_of_next_char): Call bidi_fetch_char and
880 bidi_fetch_char_advance instead of FETCH_CHAR and
881 FETCH_CHAR_ADVANCE.
882 (bidi_init_it): Initialize new members.
883 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
884 definitions.
885 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
886 instead of using explicit *_CHAR codes.
d6d100dd
SM
887 (bidi_resolve_explicit, bidi_resolve_weak):
888 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
889 bidirectional text is supported only in multibyte buffers.
890 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
891 it to initialize the frame_window_p member of struct bidi_it.
892 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
893 (bidi_resolve_explicit, bidi_resolve_weak)
894 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
895 bidi_it->nchars is non-positive.
896 (bidi_level_of_next_char): Don't try to lookup the cache for the
897 next/previous character if nothing is cached there yet, or if we
898 were just reseat()'ed to a new position.
c40e2fb2 899
0e14fe90
EZ
900 * xdisp.c (set_cursor_from_row): Set start and stop points
901 according to the row's direction when priming the loop that looks
902 for the glyph on which to display cursor.
903 (single_display_spec_intangible_p): Function deleted.
904 (display_prop_intangible_p): Reimplement to call
905 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
906 Accept 3 additional arguments needed by handle_display_spec.
907 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
908 values: lists, `(when COND...)' forms, etc.
909 (single_display_spec_string_p): Support property values that are
910 lists with the argument STRING its top-level element.
911 (display_prop_string_p): Fix the condition for processing a
912 property that is a list to be consistent with handle_display_spec.
fec2107c 913 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
914 last portion of handle_display_prop.
915 (compute_display_string_pos): Accept additional argument
916 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
917 value of a `display' property is a "replacing spec".
918 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
919 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
920 the display property, but just return a value indicating whether
921 the display property will replace the characters it covers.
922 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
923 frame_window_p members of struct bidi_it.
d6d100dd
SM
924 (compute_display_string_pos, compute_display_string_end):
925 New functions.
fec2107c
EZ
926 (push_it): Accept second argument POSITION, where pop_it should
927 jump to continue iteration.
928 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 929
fec2107c
EZ
930 * keyboard.c (adjust_point_for_property): Adjust the call to
931 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
932
933 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
934 (bidi_init_it): Update prototypes.
935 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
936 (compute_display_string_pos, compute_display_string_end):
937 Declare prototypes.
fec2107c
EZ
938 (struct bidi_it): New members nchars and disp_pos. ch_len is now
939 EMACS_INT.
fc6f18ce 940
40087514 9412011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 942
57f53182
PE
943 Malloc failure behavior now depends on size of allocation.
944 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
945 * lisp.h: Change signatures accordingly.
946 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
947 All callers changed. (Bug#8762)
948
949 * gnutls.c: Use Emacs's memory allocators.
950 Without this change, the gnutls library would invoke malloc etc.
951 directly, which causes problems on non-SYNC_INPUT hosts, and which
952 runs afoul of improving memory_full behavior. (Bug#8761)
953 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
954 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
955 xfree instead of the default malloc, realloc, free.
956 (Fgnutls_boot): No need to check for memory allocation failure,
957 since xmalloc does that for us.
958
ac32cd99 959 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
960 * category.c (hash_get_category_set):
961 * ccl.c (ccl_driver):
962 * charset.c (Fdefine_charset_internal):
963 * charset.h (struct charset.hash_index):
964 * composite.c (get_composition_id, gstring_lookup_cache)
965 (composition_gstring_put_cache):
966 * composite.h (struct composition.hash_index):
967 * dispextern.h (struct image.hash):
968 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
969 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
970 (hashfn_equal, hashfn_user_defined, make_hash_table)
971 (maybe_resize_hash_table, hash_lookup, hash_put)
972 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
973 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
974 (Fsxhash, Fgethash, Fputhash, Fmaphash):
975 * image.c (make_image, search_image_cache, lookup_image)
976 (xpm_put_color_table_h):
977 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 978 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
979 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
980 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
981 * alloc.c (allocate_vectorlike):
982 Check for overflow in vector size calculations.
983 * ccl.c (ccl_driver):
984 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
985 * fns.c, image.c: Remove unnecessary static decls that would otherwise
986 need to be updated by these changes.
40087514
PE
987 * fns.c (make_hash_table, maybe_resize_hash_table):
988 Check for integer overflow with large hash tables.
0de4bb68
PE
989 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
990 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
991 (SXHASH_REDUCE): New macro.
992 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
993 Use it instead of discarding useful hash info with large hash values.
994 (sxhash_float): New function.
995 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
996 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
997 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
998 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
999 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1000 Adjust signatures to match updated version of code.
1001 (consing_since_gc): Now EMACS_INT, since a single hash table can
1002 use more than INT_MAX bytes.
1003
698d32e2
DN
10042011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1005
1006 Make it possible to build with GCC-4.6+ -O2 -flto.
1007
1008 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1009
fd6fa53f
SM
10102011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1011
1012 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1013 Call minibuffer-inactive-mode.
1014
864db017
JB
10152011-05-31 Juanma Barranquero <lekktu@gmail.com>
1016
1017 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1018 Update dependencies.
1019
2ad0baf4
DN
10202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1021
1022 * data.c (init_data): Remove code for UTS, this system is not
1023 supported anymore.
1024
4fcc2638
DN
10252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1026
1027 Don't force ./temacs to start in terminal mode.
1028
1029 * frame.c (make_initial_frame): Initialize faces in all cases, not
1030 only when CANNOT_DUMP is defined.
1031 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1032
c56e0fd5
DN
10332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1034
1035 * dispnew.c (add_window_display_history): Use const for the string
1036 pointer. Remove declaration, not needed.
1037
333d54da 10382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1039
55d4c1b2 1040 Use 'inline', not 'INLINE'.
333d54da 1041 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1042 * alloc.c, fontset.c (INLINE): Remove.
1043 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1044 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1045 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1046 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1047 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1048
738db178
DN
10492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1050
1051 Make it possible to run ./temacs.
1052
1053 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1054 syms_of_callproc does the same thing. Remove test for
1055 "initialized", do it in the caller.
1056 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1057
620c53a6
SM
10582011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1061 (read_minibuf): Use get_minibuffer.
1062 (syms_of_minibuf): Use DEFSYM.
1063 (Qmetadata): New var.
1064 * data.c (Qbuffer): Don't make it static.
1065 (syms_of_data): Use DEFSYM.
1066
e003a292
PE
10672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1070 (CCL_CODE_MIN): New macro.
1071
ed008a6d
PE
10722011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1073
3687c2ef
PE
1074 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1075
ed008a6d
PE
1076 * eval.c (Qdebug): Now static.
1077 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1078 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1079 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1080
d66c4c7c
CY
10812011-05-29 Chong Yidong <cyd@stupidchicken.com>
1082
1083 * image.c: Various fixes to ImageMagick code comments.
1084 (Fimagemagick_types): Doc fix.
1085
5fbc2025
PE
10862011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1087
0196f88a
PE
1088 Minor fixes prompted by GCC 4.6.0 warnings.
1089
1090 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1091
5fbc2025
PE
1092 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1093 (x_clipboard_manager_save_all): Move extern decl to ...
1094 * xterm.h: ... here, so that it can be checked for consistency.
1095
1dd3c2d9
CY
10962011-05-29 Chong Yidong <cyd@stupidchicken.com>
1097
1098 * xselect.c (x_clipboard_manager_save_frame)
1099 (x_clipboard_manager_save_all): New functions.
1100 (Fx_clipboard_manager_save): Lisp function deleted.
1101
1102 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1103 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1104
1105 * xterm.h: Update prototype.
1106
5ba6571d
WX
11072011-05-28 William Xu <william.xwl@gmail.com>
1108
1109 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1110 exiting (Bug#8239).
1111
3eaff834
JM
11122011-05-28 Jim Meyering <meyering@redhat.com>
1113
e1900994 1114 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1115 * fns.c (to_uchar): Define.
1116 (crypto_hash_function): Use it to convert some newly-signed
1117 variables to unsigned, to avoid sign-extension bugs. For example,
1118 without this change, (md5 "truc") would evaluate to
1119 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1120 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1121 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1122
0f6990a7
PE
11232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 Integer overflow fixes.
c8a9ca5a 1126
08686060
PE
1127 * dbusbind.c: Serial number integer overflow fixes.
1128 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1129 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1130 to hold a serial number that is too large for a fixnum.
1131 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1132 Check for serial numbers out of range. Decode any serial number
59568bf0 1133 that was so large that it became a float. (Bug#8722)
08686060 1134
2d1fc3c7
PE
1135 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1136 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1137 Use XFASTINT rather than XUINT when numbers are nonnegative.
1138 (xd_append_arg, Fdbus_method_return_internal):
1139 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1140 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1141 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1142 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1143 (Bug#8722)
2d1fc3c7 1144
c8a9ca5a
PE
1145 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1146
519e1d69
PE
1147 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1148
30569699
PE
1149 ccl: add integer overflow checks
1150 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1151 (IN_INT_RANGE): New macros.
1152 (ccl_driver): Use them to check for integer overflow when
1153 decoding a CCL program. Many of the new checks are whether XINT (x)
1154 fits in int; it doesn't always, on 64-bit hosts. The new version
1155 doesn't catch all possible integer overflows, but it's an
847044ea 1156 improvement. (Bug#8719)
30569699 1157
c11285dc
PE
1158 * alloc.c (make_event_array): Use XINT, not XUINT.
1159 There's no need for unsigned here.
1160
fdccd48e
PE
1161 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1162 This follows up to the 2011-05-06 change that substituted uintptr_t
1163 for EMACS_INT. This case wasn't caught back then.
1164
37910ab2
PE
1165 Rework Fformat to avoid integer overflow issues.
1166 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1167 now (part of C89). Include <verify.h>.
1168 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1169 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1170 (Fformat): Avoid the prepass trying to compute sizes; it was only
1171 approximate and thus did not catch overflow reliably. Instead, walk
1172 through the format just once, formatting and computing sizes as we go,
1173 checking for integer overflow at every step, and allocating a larger
1174 buffer as needed. Keep track separately whether the format is
1175 multibyte. Keep only the most-recently calculated precision, rather
1176 than them all. Record whether each argument has been converted to
1177 string. Use EMACS_INT, not int, for byte and char and arg counts.
1178 Support field widths and precisions larger than INT_MAX. Avoid
1179 sprintf's undefined behavior with conversion specifications such as %#d
1180 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1181 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1182 formatting out-of-range floating point numbers with int
1183 formats. (Bug#8668)
1184
2e6578fb
PE
1185 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1186
0ae6bdee
PE
1187 * data.c: Avoid integer truncation in expressions involving floats.
1188 * data.c: Include <intprops.h>.
1189 (arith_driver): When there's an integer overflow in an expression
1190 involving floating point, convert the integers to floating point
1191 so that the resulting value does not suffer from catastrophic
1192 integer truncation. For example, on a 64-bit host (* 4
1193 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1194 Do not rely on undefined behavior after integer overflow.
1195
de883a70
PE
1196 merge count_size_as_multibyte, parse_str_to_multibyte
1197 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1198 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1199 Check for integer overflow.
1200 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1201 since it's now a duplicate of the other. This is more of
1202 a character than a buffer op, so better that it's in character.c.
1203 * fns.c, print.c: Adjust to above changes.
1204
2ff916cb
PE
12052011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1208
f1b54466
PE
12092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1210
fb1ac845
PE
1211 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1212 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1213 (x_clipboard_manager_save): Now static.
1214 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1215
f1b54466
PE
1216 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1217 (crypto_hash_function): Now static.
1218 Fix pointer signedness problems. Avoid unnecessary initializations.
1219
a9f737ee
CY
12202011-05-27 Chong Yidong <cyd@stupidchicken.com>
1221
1222 * termhooks.h (Vselection_alist): Make it terminal-local.
1223
1224 * terminal.c (create_terminal): Initialize it.
1225
1226 * xselect.c: Support for clipboard managers.
1227 (Vselection_alist): Move to termhooks.h as terminal-local var.
1228 (LOCAL_SELECTION): New macro.
1229 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1230 (symbol_to_x_atom): Remove gratuitous arg.
1231 (x_handle_selection_request, lisp_data_to_selection_data)
1232 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1233 (x_own_selection, x_get_local_selection, x_convert_selection):
1234 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1235 (some_frame_on_display): Delete unused function.
1236 (Fx_own_selection_internal, Fx_get_selection_internal)
1237 (Fx_disown_selection_internal, Fx_selection_owner_p)
1238 (Fx_selection_exists_p): New optional frame arg.
1239 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1240 (x_handle_selection_clear): Don't treat other terminals with the
1241 same keyboard specially. Use the terminal-local Vselection_alist.
1242 (x_clear_frame_selections): Use Frun_hook_with_args.
1243
1244 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1245
1246 * xterm.h: Add support for those atoms.
1247
e067f0c1
CY
12482011-05-26 Chong Yidong <cyd@stupidchicken.com>
1249
1250 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1251 (converted_selections, conversion_fail_tag): New global variables.
1252 (x_selection_request_lisp_error): Free the above.
1253 (x_get_local_selection): Remove unnecessary code.
1254 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1255 of converted selections stored in converted_selections.
1256 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1257 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1258 (x_convert_selection): New function.
1259 (x_handle_selection_event): Simplify.
1260 (x_get_foreign_selection): Don't ignore incoming requests while
1261 waiting for an answer; this will fail when we implement
1262 SAVE_TARGETS, and seems unnecessary anyway.
1263 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1264 (Vx_sent_selection_functions): Doc fix.
1265
0f4aebc0
LL
12662011-05-26 Leo Liu <sdl.web@gmail.com>
1267
1268 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1269
e61124cd
YM
12702011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1271
1272 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1273
1274 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1275 for fringe update if it has periodic bitmap.
1276 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1277 and fringe_bitmap_periodic_p.
1278
1279 * fringe.c (get_fringe_bitmap_data): New function.
1280 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1281 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1282 row. Mark glyph row for fringe update if periodicity changed.
1283
1284 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1285 for fringe update unless it has periodic bitmap.
1286
f16d9837
KH
12872011-05-25 Kenichi Handa <handa@m17n.org>
1288
1289 * xdisp.c (get_next_display_element): Set correct it->face_id for
1290 a static composition.
1291
e1b90ef6
LL
12922011-05-24 Leo Liu <sdl.web@gmail.com>
1293
1294 * deps.mk (fns.o):
1295 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1296
1297 * fns.c (crypto_hash_function, Fsha1): New function.
1298 (Fmd5): Use crypto_hash_function.
1299 (syms_of_fns): Add Ssha1.
1300
7400048f
PE
13012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 * gnutls.c: Remove unused macros.
1304 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1305 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1306 Remove macros that are defined and never used.
1307 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1308
abb71cf4
CY
13092011-05-22 Chong Yidong <cyd@stupidchicken.com>
1310
1311 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1312 (Fx_get_selection_internal): Minor cleanup.
1313 (Fx_own_selection_internal): Rename arguments for consistency with
1314 select.el.
1315
6307db39
PE
13162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1319
f3d4e0a4
CY
13202011-05-22 Chong Yidong <cyd@stupidchicken.com>
1321
1322 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1323
4d8ade89
YM
13242011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1325
1326 * dispnew.c (scrolling_window): Don't exclude the case that the
1327 last enabled row in the desired matrix touches the bottom boundary.
1328
32078c8d
GM
13292011-05-21 Glenn Morris <rgm@gnu.org>
1330
1331 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1332 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1333 and add some more files.
32078c8d 1334
7285dc67
EZ
13352011-05-20 Eli Zaretskii <eliz@gnu.org>
1336
1337 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1338 report_file_error introduced by the change from 2011-05-07.
1339
89d1bd22
PE
13402011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 * systime.h (Time): Define only if emacs is defined.
1343 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1344 where the include path doesn't have X11/X.h by default. See
1345 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1346
e23640bb 13472011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1348
1349 * composite.c (find_automatic_composition): Fix previous change.
1350
b9704ad9
GM
13512011-05-20 Glenn Morris <rgm@gnu.org>
1352
1353 * lisp.mk: New file, split from Makefile.in.
1354 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1355 (shortlisp): Remove.
1356 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1357
4a720484
GM
13582011-05-19 Glenn Morris <rgm@gnu.org>
1359
1360 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1361 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1362 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1363 (lisp): Set the order to that of loadup.el.
1364 (shortlisp): Make it a copy of $lisp.
1365 (SOME_MACHINE_LISP): Remove.
1366 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1367 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1368
a28d4396
KH
13692011-05-18 Kenichi Handa <handa@m17n.org>
1370
1371 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1372 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1373 (find_automatic_composition): Mostly rewrite for efficiency.
1374
a2b1fa8e
JB
13752011-05-18 Juanma Barranquero <lekktu@gmail.com>
1376
1377 * makefile.w32-in: Update dependencies.
1378
8e1f5610
CS
13792011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1380
1381 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1382 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1383
7025ee00 13842011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1385
cdfa6eab
PE
1386 Fix some integer overflow issues, such as string length overflow.
1387
06d6db33
PE
1388 * insdel.c (count_size_as_multibyte): Check for string overflow.
1389
2b4560a8
PE
1390 * character.c (lisp_string_width): Check for string overflow.
1391 Use EMACS_INT, not int, for string indexes and lengths; in
1392 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1393 the resulting string length overflows an EMACS_INT; instead,
1394 report a string overflow if no precision given. When checking for
1395 precision exhaustion, use a check that cannot possibly have
1396 integer overflow. (Bug#8675)
1397 * character.h (lisp_string_width): Adjust to new signature.
1398
cb93f9be
PE
1399 * alloc.c (string_overflow): New function.
1400 (Fmake_string): Use it. This doesn't change behavior, but saves
1401 a few bytes and will simplify future changes.
1402 * character.c (string_escape_byte8): Likewise.
1403 * lisp.h (string_overflow): New decl.
1404
1a1f3366
PE
1405 Fixups, following up to the user-interface timestamp change.
1406 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1407 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1408 * msdos.c (mouse_get_pos): Likewise.
1409 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1410 * w32gui.h (Time): Define by including "systime.h" rather than by
1411 declaring it ourselves. (Bug#8664)
1412
d4e3e4d3
PE
1413 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1414 * image.c (clear_image_cache): Likewise.
1415
f6a24d19
PE
1416 * term.c (term_mouse_position): Don't assume time_t wraparound.
1417
08dc5ae6
PE
1418 Be more systematic about user-interface timestamps.
1419 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1420 and sometimes 'EMACS_UINT', to represent these timestamps.
1421 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1422 This makes the code easier to follow, and makes it easier to catch
1423 integer overflow bugs such as Bug#8664.
1424 * frame.c (Fmouse_position, Fmouse_pixel_position):
1425 Use Time, not unsigned long, for user-interface timestamps.
1426 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1427 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1428 * keyboard.h (last_event_timestamp): Likewise.
1429 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1430 * menu.h (xmenu_show): Likewise.
1431 * term.c (term_mouse_position): Likewise.
1432 * termhooks.h (struct input_event.timestamp): Likewise.
1433 (struct terminal.mouse_position_hook): Likewise.
1434 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1435 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1436 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1437 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1438 what it was before.
1439 * menu.h, termhooks.h: Include "systime.h", for Time.
1440
8e55734a
PE
1441 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1442 Don't assume that the difference between two unsigned long values
1443 can fit into an integer. At this point, we know button_down_time
1444 <= event->timestamp, so the difference must be nonnegative, so
1445 there's no need to cast the result if double-click-time is
1446 nonnegative, as it should be; check that it's nonnegative, just in
1447 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1448 apart (about 25 days). (Bug#8664)
8e55734a 1449
841f1b75 1450 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1451 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1452
3e26f69c
PE
1453 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1454 that always fit in int. Use a sentinel instead of a counter, to
1455 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1456 * frame.h (struct frame): Use int for menu_bar_items_used
1457 instead of EMACS_INT, since it always fits in int.
3e26f69c 1458
5cc152c0
PE
1459 * menu.c (grow_menu_items): Check for int overflow.
1460
d89eb65e
PE
1461 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1462
5235bd3e
PE
1463 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1464 Before, the code was not consistent. These values cannot exceed
1465 2**31 - 1 so there's no need to make them unsigned.
1466 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1467 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1468 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1469 as modifiers.
1470 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1471
bc827e23
PE
1472 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1473 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1474 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1475 presumably because the widths might not match.
1476
78eb494e
PE
1477 * window.c (size_window): Avoid needless test at loop start.
1478
04f2d78b
CB
14792011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1480
1481 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1482
d2fc7e3d 14832011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1484
1485 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1486
d2fc7e3d 14872011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1488
1489 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1490 `width' to `bar_area_x' and `bar_area_width', respectively.
1491 (x_scroll_run): Take account of fringe background extension.
1492
04f2d78b
CB
1493 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1494 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1495 `bar_area_width', respectively.
1496 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1497 background extension.
1498
79b70037
GM
14992011-05-10 Jim Meyering <meyering@redhat.com>
1500
1501 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1502
2f142cc5
JB
15032011-05-10 Juanma Barranquero <lekktu@gmail.com>
1504
1505 * image.c (Finit_image_library): Return t for built-in image types,
1506 like pbm and xbm. (Bug#8640)
1507
57679c86
AS
15082011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1509
1510 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1511
888c9e86
EZ
15122011-05-07 Eli Zaretskii <eliz@gnu.org>
1513
b0512a1d
EZ
1514 * w32console.c (Fset_screen_color): Doc fix.
1515 (Fget_screen_color): New function.
1516 (syms_of_ntterm): Defsubr it.
1517
7285dc67
EZ
1518 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1519 unlink the temporary file if Fcall_process didn't create it in the
1520 first place.
1521 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1522 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1523 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1524 cue to call_process_cleanup not to close that handle.
1525
4d3fcc8e
BK
15262011-05-07 Ben Key <bkey76@gmail.com>
1527
1528 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1529 one of two shell specific rules, either bootstrap-temacs-CMD or
1530 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1531 to the previous implementation of the bootstrap-temacs rule.
1532 The bootstrap-temacs-CMD rule is similar to the previous
1533 implementation of the bootstrap-temacs rule except that it
1534 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1535 variable.
1536
1537 These changes, along with some changes to nt/configure.bat,
1538 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1539 earlier fix to add support for --cflags and --ldflags options
1540 that include quotes so that it works whether make uses cmd or
1541 sh as the shell.
1542
b4289b64
MA
15432011-05-06 Michael Albinus <michael.albinus@gmx.de>
1544
1545 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1546 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1547 is a constant.
1548 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1549 a string. Handle both cases.
1550 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1551 (Fdbus_register_method): Use Qinvalid_function.
1552
af4c0e28
JB
15532011-05-06 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * makefile.w32-in: Update dependencies.
1556 (LISP_H): Add inttypes.h and stdin.h.
1557 (PROCESS_H): Add unistd.h.
1558
c51453d9
EZ
15592011-05-06 Eli Zaretskii <eliz@gnu.org>
1560
1561 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1562 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1563
8ff0ac3c 15642011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1565
4c4b566b
PE
1566 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1567
aab2b9b5
PE
1568 * term.c (vfatal): Remove stray call to va_end.
1569 It's not needed and the C Standard doesn't allow it here anyway.
1570
c378da0b
PE
1571 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1572 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1573
288b08c7
PE
1574 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1575 bytes.
1576
e3601888
PE
1577 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1578
db6c0e74
PE
1579 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1580
dd5963ea
PE
1581 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1582
88c9450f
PE
1583 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1584
2f9442b8
PE
1585 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1586
c032b5f8
PE
1587 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1588 * charset.c (Fdefine_charset_internal): Don't initialize
1589 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1590 32-bit int (Bug#8600).
a108c10b
PE
1591
1592 * lread.c (read_integer): Be more consistent with string-to-number.
1593 Use string_to_number to do the actual conversion; this avoids
1594 rounding errors and fixes some other screwups. Without this fix,
1595 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1596 (digit_to_number): Move earlier, for benefit of read_integer.
1597 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1598 not a digit in any supported base. (Bug#8602)
a108c10b 1599
ad5f9eea
PE
1600 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1601
aec1708a
PE
1602 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1603 to match comment at start of function. This also removes a
1604 GCC warning about overflow in a 32+64-bit port.
1605
47be4ab5
PE
1606 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1607
371cac43
PE
1608 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1609 Reported by Stefan Monnier in
1610 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1611 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1612 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1613
d01a7826
PE
1614 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1615 (EMACS_UINTPTR): Likewise, with uintptr_t.
1616
7fd47d5c
PE
1617 * lisp.h: Prefer 64-bit EMACS_INT if available.
1618 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1619 on 32-bit hosts that have 64-bit int, so that they can access
1620 large files.
122b0c86
PE
1621 However, temporarily disable this change unless the temporary
1622 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1623
8727937b
PE
1624 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1625
8ac068ac
PE
1626 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1627 This removes an assumption that EMACS_INT and long are the same
1628 width as pointers. The assumption is true for Emacs porting targets
1629 now, but we want to make other targets possible.
1630 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1631 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1632 In the rest of the code, change types of integers that hold casted
1633 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1634 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1635 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1636 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1637 No need to cast type when ORing.
1638 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1639 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1640 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1641 assume EMACS_INT is the same width as char *.
1642 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1643 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1644 Remove no-longer-needed casts.
1645 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1646 (xg_tool_bar_help_callback, xg_make_tool_item):
1647 Use EMACS_INTPTR to hold an integer
1648 that will be cast to void *; this can avoid a GCC warning
1649 if EMACS_INT is not the same width as void *.
1650 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1651 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1652 (current_message_1, set_message_1):
1653 Use a local to convert to proper width without a cast.
1654 * xmenu.c (dialog_selection_callback): Likewise.
1655
ede49d71
PE
1656 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1657 Also, don't assume VALBITS / RAND_BITS is less than 5,
1658 and don't rely on undefined behavior when shifting a 1 left into
1659 the sign bit.
1660 * lisp.h (get_random): Change signature to match.
1661
2f30ecd0
PE
1662 * lread.c (hash_string): Use size_t, not int, for hash computation.
1663 Normally we prefer signed values; but hashing is special, because
1664 it's better to use unsigned division on hash table sizes so that
1665 the remainder is nonnegative. Also, size_t is the natural width
1666 for hashing into memory. The previous code used 'int', which doesn't
1667 retain enough info to hash well into very large tables.
1668 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1669
2a866e7b
PE
1670 * dbusbind.c: Don't possibly lose pointer info when converting.
1671 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1672 Use XPNTR rather than XHASH, so that the high-order bits of
1673 the pointer aren't lost when converting through void *.
1674
51639eac
PE
1675 * eval.c (Fautoload): Don't double-shift a pointer.
1676
92394119
PE
1677 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1678
dbdb9a7c
JB
16792011-05-06 Juanma Barranquero <lekktu@gmail.com>
1680
1681 * gnutls.c (DEF_GNUTLS_FN):
1682 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1683
db7a0b4f
AS
16842011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1685
1686 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1687 marker. (Bug#8610)
1688
f7ff1b0f 16892011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1690
1691 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1692 New version that can reserve upto 2GB of heap space.
1693
f7ff1b0f 16942011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1695
1696 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1697
639c109b
TZ
16982011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1699
1700 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1701 `gnutls_certificate_set_x509_key_file'.
1702
d2127135
JB
17032011-05-05 Juanma Barranquero <lekktu@gmail.com>
1704
1705 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1706 Update dependencies.
1707
e968f4f3
JB
17082011-05-04 Juanma Barranquero <lekktu@gmail.com>
1709
1710 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1711 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1712 Remove unused parameter `fildes'.
1713 * process.c (read_process_output, send_process): Don't pass it.
1714
84d358f0
JB
17152011-05-04 Juanma Barranquero <lekktu@gmail.com>
1716
1717 Fix previous change: the library cache is defined in w32.c.
1718 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1719 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1720
0898ca10
JB
17212011-05-04 Juanma Barranquero <lekktu@gmail.com>
1722
1723 Implement dynamic loading of GnuTLS on Windows.
1724
1725 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1726 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1727 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1728 Declare.
1729
1730 * gnutls.c (Qgnutls_dll): Define.
1731 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1732 (gnutls_*): Declare function pointers.
1733 (init_gnutls_functions): New function to initialize function pointers.
1734 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1735 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1736 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1737 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1738 (emacs_gnutls_write, emacs_gnutls_read)
1739 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1740 (Fgnutls_available_p): New function.
1741 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1742 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1743 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1744
1745 * image.c: Include w32.h.
1746 (Vimage_type_cache): Delete.
1747 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1748 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1749 (w32_delayed_load): Move to w32.c.
1750
1751 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1752
1753 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1754 (w32_delayed_load): Move from image.c. When loading a library, record
1755 its filename in the :loaded-from property of the library id.
1756 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1757 Initialize and staticpro them.
1758 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1759
1760 * process.c: Include lisp.h before w32.h, not after.
1761 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1762 instead of gnutls_record_check_pending.
1763
1764 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1765
ff4de4aa
TZ
17662011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1767
1768 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1769 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1770 as passed in.
1771
abe95abb
JD
17722011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1773
1774 * xterm.c (x_set_frame_alpha): Do not set property on anything
1775 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1776
e16e55d4
JB
17772011-05-02 Juanma Barranquero <lekktu@gmail.com>
1778
1779 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1780
bafcf6a5
JB
17812011-05-02 Juanma Barranquero <lekktu@gmail.com>
1782
1783 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1784 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1785 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1786 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1787 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1788 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1789 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1790 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1791 (Qgnutls_bootprop_callbacks_verify): Make static.
1792
e7a6747f
AS
17932011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1794
19ed11ba
AS
1795 * callproc.c: Indentation fixup.
1796
e7a6747f 1797 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1798 (wait_for_termination, interruptible_wait_for_termination):
1799 Move after wait_for_termination_1.
e7a6747f 1800
1ef14cb4
LMI
18012011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1802
1803 * sysdep.c (interruptible_wait_for_termination): New function
1804 which is like wait_for_termination, but allows keyboard
1805 interruptions.
1806
1807 * callproc.c (Fcall_process): Add (:file "file") as an option for
1808 the STDOUT buffer.
1809 (Fcall_process_region): Ditto.
1810
330d880c
EZ
18112011-04-30 Eli Zaretskii <eliz@gnu.org>
1812
8db90b73
EZ
1813 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1814 rather than `XVECTOR (FOO)->size'.
1815
330d880c
EZ
1816 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1817 inttypes.h, as a gnulib replacement is used if it not available in
1818 system headers.
1819
15cbd324
EZ
18202011-04-21 Eli Zaretskii <eliz@gnu.org>
1821
1822 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1823 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1824 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1825
1826 * coding.c (coding_alloc_by_realloc): Error out if destination
1827 will grow beyond MOST_POSITIVE_FIXNUM.
1828 (decode_coding_emacs_mule): Abort if there isn't enough place in
1829 charbuf for the composition carryover bytes. Reserve an extra
1830 space for up to 2 characters produced in a loop.
1831 (decode_coding_iso_2022): Abort if there isn't enough place in
1832 charbuf for the composition carryover bytes.
1833
18342011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1835
ae940cca
EZ
1836 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1837 aborting when %lld or %lll format is passed.
1838 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1839 %llo or %llx format is passed. (Bug#8545)
1840
03ab8921
EZ
1841 * window.c (window_scroll_line_based): Use a marker instead of
1842 simple variables to record original value of point. (Bug#7952)
1843
afda1437
EZ
1844 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1845 produced by %s or %c overflows available buffer space. (Bug#8545)
1846
f76dee0c
PE
18472011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1850 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1851
fdc5744d
JB
18522011-04-28 Juanma Barranquero <lekktu@gmail.com>
1853
1854 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1855
638f053a
JB
18562011-04-28 Juanma Barranquero <lekktu@gmail.com>
1857
1858 * keyboard.c (Qdelayed_warnings_hook): Define.
1859 (command_loop_1): Run `delayed-warnings-hook'
1860 if Vdelayed_warnings_list is non-nil.
1861 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1862 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1863
d178f871
EZ
18642011-04-28 Eli Zaretskii <eliz@gnu.org>
1865
1866 * doprnt.c (doprnt): Don't return value smaller than the buffer
1867 size if the message was truncated. (Bug#8545).
1868
b124fd93
JB
18692011-04-28 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1872 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1873
e810457d
PE
18742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1875
1876 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1877
ea51cceb
JB
18782011-04-27 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * makefile.w32-in: Update dependencies.
1881
94dcfacf
EZ
18822011-04-27 Eli Zaretskii <eliz@gnu.org>
1883
1884 Improve `doprnt' and its usage. (Bug#8545)
1885 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1886 `format_end'. Remove support for %l as a conversion specifier.
1887 Don't use xrealloc. Improve diagnostics when the %l size modifier
1888 is used. Update the commentary.
1889
1890 * eval.c (verror): Simplify calculation of size_t.
1891
1892 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1893 messages.
1894
f61f41d7
PE
18952011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1896
1897 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1898 change.
1899
96fb4434
PE
19002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1903 This makes this file independent of the recent pseudovector change.
1904
671875da 19052011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1906
69e9b5a3
PE
1907 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1908
b5f869a7 1909 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1910 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1911 Remove unused local.
c8926152 1912 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1913
841a1577 1914 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1915 GCC 4.6.0 optimizes based on type-based alias analysis.
1916 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1917 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1918 != &v->size, and therefore "v->size = 1; b->size = 2; return
1919 v->size;" must therefore return 1. This assumption is incorrect
1920 for Emacs, since it type-puns struct Lisp_Vector * with many other
1921 types. To fix this problem, this patch adds a new type struct
f904488f 1922 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1923 and pseudovectors, and helps optimizing compilers not get fooled
1924 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1925 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1926 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1927 the size member.
eab3844f
PE
1928 (XSETPVECTYPE): Rewrite in terms of new macro.
1929 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1930 This is a bit clearer, and further avoids the possibility of
1931 undesirable aliasing.
1932 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1933 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1934 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1935 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1936 (ASIZE): Now uses header.size rather than size.
1937 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1938 to avoid the hassle of writing XVECTOR (foo)->header.size.
1939 (struct vectorlike_header): New type.
eab3844f
PE
1940 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1941 object, to help avoid aliasing.
1942 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1943 (SUBRP): Likewise, since Lisp_Subr is a special case.
1944 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1945 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1946 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1947 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1948 changed to be "header.size" and "header.next".
1949 * buffer.h (struct buffer): Likewise.
1950 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1951 * frame.h (struct frame): Likewise.
1952 * process.h (struct Lisp_Process): Likewise.
1953 * termhooks.h (struct terminal): Likewise.
1954 * window.c (struct save_window_data, struct saved_window): Likewise.
1955 * window.h (struct window): Likewise.
1956 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1957 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1958 * buffer.c (init_buffer_once): Likewise.
1959 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1960 special case.
1961 * process.c (Fformat_network_address): Use local var for size,
1962 for brevity.
1963
0df1eac5
PE
1964 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1965
847ab9d1 1966 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1967 * data.c (atof): Remove decl; no longer used or needed.
1968 (digit_to_number): Move to lread.c.
1969 (Fstring_to_number): Use new string_to_number function, to be
1970 consistent with how the Lisp reader treats infinities and NaNs.
1971 Do not assume that floating-point numbers represent EMACS_INT
1972 without losing information; this is not true on most 64-bit hosts.
1973 Avoid double-rounding errors, by insisting on integers when
1974 parsing non-base-10 numbers, as the documentation specifies.
1975 * lisp.h (string_to_number): New decl, replacing ...
1976 (isfloat_string): Remove.
bc0a5c13 1977 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1978 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1979 appears to have been a coding error. Similarly, do not accept
1980 strings like +-1e0 as floating point numbers. Do not report
1981 overflow for integer overflows unless the base is not 10 which
1982 means we have no simple and reliable way to continue.
1983 Break out the floating-point parsing into a new
1984 function string_to_number, so that Fstring_to_number parses
1985 floating point numbers consistently with the Lisp reader.
04f2d78b 1986 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1987 (E_CHAR, EXP_INT): Remove, replacing with ...
1988 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1989 (string_to_number): New function, replacing isfloat_string.
1990 This function checks for valid syntax and produces the resulting
1991 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1992 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1993 so that overflow for non-base-10 numbers is reported only when
1994 there's no portable and simple way to convert to floating point.
452f4150 1995
67769ffc
PE
1996 * textprop.c (set_text_properties_1): Rewrite for clarity,
1997 and to avoid GCC warning about integer overflow.
1998
c20db43f
PE
1999 * intervals.h (struct interval): Use EMACS_INT for members
2000 where EMACS_UINT might cause problems. See
2001 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2002 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2003 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2004 All uses changed.
37aa2f85
PE
2005 (offset_intervals): Tell GCC not to worry about length overflow
2006 when negating a negative length.
c20db43f 2007
2538aa2f
PE
2008 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2009 (overrun_check_free): Likewise.
2010
f2d3008d
PE
2011 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2012 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2013 word size.
2014
ec8df744
PE
2015 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2016 (gnutls_make_error): Rename local to avoid shadowing.
2017 (gnutls_emacs_global_deinit): ifdef out; not used.
2018 (Fgnutls_boot): Use const for pointer to readonly storage.
2019 Comment out unused local. Fix pointer signedness problems.
2020
640ee02d
PE
2021 * lread.c (openp): Don't stuff size_t into an 'int'.
2022 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2023 about possible signed overflow.
2024
6048fb2a
PE
2025 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2026 (GDK_KEY_g): Don't define if already defined.
2027 (xg_prepare_tooltip): Avoid pointer signedness problem.
2028 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2029
fa3c87e1
PE
2030 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2031 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2032
2172544b
PE
2033 * xfns.c (Fx_window_property): Simplify a bit,
2034 to make a bit faster and to avoid GCC 4.6.0 warning.
2035 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2036
9b821a21
PE
2037 * fns.c (internal_equal): Don't assume size_t fits in int.
2038
3c616cfa
PE
2039 * alloc.c (compact_small_strings): Tighten assertion a little.
2040
c2982e87
PE
2041 Replace pEd with more-general pI, and fix some printf arg casts.
2042 * lisp.h (pI): New macro, generalizing old pEd macro to other
2043 conversion specifiers. For example, use "...%"pI"d..." rather
2044 than "...%"pEd"...".
2045 (pEd): Remove. All uses replaced with similar uses of pI.
2046 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2047 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2048 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2049 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2050 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2051 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2052 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2053 64-bit hosts.
2054 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2055 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2056 * print.c (safe_debug_print, print_object): Likewise.
2057 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2058 to int.
6f04d126
PE
2059 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2060 avoiding the 0 flag, which is not portable.
c2982e87
PE
2061 * process.c (Fmake_network_process): Use pI to avoid cast.
2062 * region-cache.c (pp_cache): Likewise.
2063 * xdisp.c (decode_mode_spec): Likewise.
2064 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2065 behavior on 64-bit hosts with printf arg.
6f04d126 2066 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2067 (x_stop_queuing_selection_requests): Likewise.
2068 (x_get_window_property): Don't truncate byte count to an 'int'
2069 when tracing.
0b432f21 2070
5e073ec7
PE
2071 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2072 here, since it parses constructs like leading '-' and spaces,
2073 which are not wanted; and it overflows with large numbers.
2074 Instead, simply match F[0-9]+, which is what is wanted anyway.
2075
36372bf9
PE
2076 * alloc.c: Remove unportable assumptions about struct layout.
2077 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2078 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2079 (allocate_vectorlike, make_pure_vector): Use the new macros,
2080 plus offsetof, to remove unportable assumptions about struct layout.
2081 These assumptions hold on all porting targets that I know of, but
2082 they are not guaranteed, they're easy to remove, and removing them
2083 makes further changes easier.
2084
0b432f21
PE
2085 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2086 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2087 (string_overrun_cookie): Now const. Use initializers that
2088 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2089 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2090 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2091 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2092 multiple of sizeof (EMACS_INT); it need not be, if
2093 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2094 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2095
895009e1
JB
20962011-04-26 Juanma Barranquero <lekktu@gmail.com>
2097
2098 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2099
6a7a1b0b
TZ
21002011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2101
2102 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2103 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2104 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2105
841a1577 21062011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2107
2108 * lisp.h (Qdebug): List symbol.
895009e1 2109 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2110 * keyboard.c (debug-on-event): New variable.
2111 (handle_user_signal): Break into debugger when debug-on-event
2112 matches the current signal symbol.
2113
f2d3ba6f
DN
21142011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2115
2116 * alloc.c (check_sblock, check_string_bytes)
2117 (check_string_free_list): Convert to standard C.
2118
42ce4c63
TZ
21192011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2120
2121 * w32.c (emacs_gnutls_push): Fix typo.
2122
825cd63c
EZ
21232011-04-25 Eli Zaretskii <eliz@gnu.org>
2124
fb11d64d
EZ
2125 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2126 "cast to pointer from integer of different size".
2127
825cd63c
EZ
2128 Improve doprnt and its use in verror. (Bug#8545)
2129 * doprnt.c (doprnt): Document the set of format control sequences
2130 supported by the function. Use SAFE_ALLOCA instead of always
2131 using `alloca'.
2132
2133 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2134 is one byte too soon. Don't use xrealloc; instead xfree and
2135 xmalloc anew.
2136
e061a11b
TZ
21372011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2138
2139 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2140 callbacks stage.
2141
2142 * gnutls.c: Renamed global_initialized to
2143 gnutls_global_initialized. Added internals for the
2144 :verify-hostname-error, :verify-error, and :verify-flags
2145 parameters of `gnutls-boot' and documented those parameters in the
2146 docstring. Start callback support.
2147 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2148 unless a fatal error occured. Call gnutls_alert_send_appropriate
2149 on error. Return error code.
2150 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2151 (emacs_gnutls_read): Likewise.
2152 (Fgnutls_boot): Return handshake error code.
2153 (emacs_gnutls_handle_error): New function.
2154 (wsaerror_to_errno): Likewise.
2155
2156 * w32.h (emacs_gnutls_pull): Add prototype.
2157 (emacs_gnutls_push): Likewise.
2158
2159 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2160 (emacs_gnutls_push): Likewise.
2161
21622011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2163
2164 * process.c (wait_reading_process_output): Check if GnuTLS
2165 buffered some data internally if no FDs are set for TLS
2166 connections.
2167
2168 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2169 (LIBS): Link to USER_LIBS.
2170 ($(BLD)/gnutls.$(0)): New target.
2171
fa6996bc
EZ
21722011-04-24 Eli Zaretskii <eliz@gnu.org>
2173
eb35682e
EZ
2174 * xdisp.c (handle_single_display_spec): Rename the
2175 display_replaced_before_p argument into display_replaced_p, to
2176 make it consistent with the commentary. Fix typos in the
2177 commentary.
2178
e2ad650c
EZ
2179 * textprop.c (syms_of_textprop): Remove dead code.
2180 (copy_text_properties): Delete obsolete commentary about an
2181 interface that was deleted long ago. Fix typos in the description
2182 of arguments.
2183
1b2de274
EZ
2184 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2185 to changes in oldXMenu/XMenu.h from 2011-04-16.
2186 <menu_help_message, prev_menu_help_message>: Constify.
2187 (IT_menu_make_room): menu->help_text is now `const char **';
2188 adjust.
2189
2190 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2191 to changes in oldXMenu/XMenu.h from 2011-04-16.
2192 (struct XMenu): Declare `help_text' `const char **'.
2193
2194 * xfaces.c <Qunspecified>: Make extern again.
2195
2196 * syntax.c: Include sys/types.h before including regex.h, as
2197 required by Posix.
2198
762b15be
EZ
2199 * doc.c (get_doc_string): Improve the format passed to `error'.
2200
2201 * doprnt.c (doprnt): Improve commentary.
2202
2203 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2204
2205 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2206 them with etags.
2207
f1052e5d
EZ
2208 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2209 changes in globals.h immediately force recompilation.
762b15be
EZ
2210 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2211 $(CURDIR)/s/ms-w32.h.
2212 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2213
fa6996bc
EZ
2214 * character.c (Fchar_direction): Function deleted.
2215 (syms_of_character): Don't defsubr it.
2216 <char-direction-table>: Deleted.
2217
e6c3da20
EZ
22182011-04-23 Eli Zaretskii <eliz@gnu.org>
2219
2220 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2221 * doprnt.c: Include limits.h.
2222 (SIZE_MAX): New macro.
04f2d78b
CB
2223 (doprnt): Return a size_t value. 2nd arg is now size_t.
2224 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2225 Improve overflow protection. Support `l' modifier for integer
2226 conversions. Support %l conversion. Don't assume an EMACS_INT
2227 argument for integer conversions and for %c.
2228
2229 * lisp.h (doprnt): Restore prototype.
2230
2231 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2232 $(SRC)/character.h.
2233
2234 * Makefile.in (base_obj): Add back doprnt.o.
2235
2236 * deps.mk (doprnt.o): Add back prerequisites.
2237 (callint.o): Depend on character.h.
2238
2239 * eval.c (internal_lisp_condition_case): Include the handler
2240 representation in the error message.
2241 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2242 when breaking from the loop.
2243
2244 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2245
2246 * callint.c (Fcall_interactively): When displaying error message
2247 about invalid control letter, pass the character's codepoint, not
2248 a pointer to its multibyte form. Improve display of the character
2249 in octal and display also its hex code.
2250
2251 * character.c (char_string): Use %x to display the (unsigned)
2252 codepoint of an invalid character, to avoid displaying a bogus
2253 negative value.
2254
2255 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2256 `error', not SYMBOL_NAME itself.
2257
2258 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2259 character arguments to `error'.
2260
2261 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2262 to `error' in error message about FINAL_CHAR argument. Make sure
2263 FINAL_CHAR is a character, and use %c when it is passed as
2264 argument to `error'.
2265
4ffd0d6b 22662011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2267
2268 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2269
2270 * w32.c: Include <time.h>.
2271 (sys_localtime): New function.
2272
4ffd0d6b 22732011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2274
2275 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2276
4ffd0d6b 2277 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2278
4ffd0d6b 22792011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2280
4ffd0d6b
GM
2281 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2282 zombies (Bug#8467).
aac0c6e3 2283
04c56954
EZ
22842011-04-19 Eli Zaretskii <eliz@gnu.org>
2285
2286 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2287 gl_state.e_property when gl_state.object is Qt.
2288
2289 * insdel.c (make_gap_larger): Remove limitation of buffer size
2290 to <= INT_MAX.
2291
16a43933
CY
22922011-04-18 Chong Yidong <cyd@stupidchicken.com>
2293
2294 * xdisp.c (lookup_glyphless_char_display)
2295 (produce_glyphless_glyph): Handle cons cell entry in
2296 glyphless-char-display.
2297 (Vglyphless_char_display): Document it.
2298
2299 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2300 glyphless-char-display.
2301
4581706e
CY
23022011-04-17 Chong Yidong <cyd@stupidchicken.com>
2303
2304 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2305
2306 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2307
2308 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2309 definition for no-X builds.
2310
4887c6e2 23112011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2312
fd35b6f9
PE
2313 Static checks with GCC 4.6.0 and non-default toolkits.
2314
5c1ccb01
PE
2315 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2316
006c5daa
PE
2317 * process.c (keyboard_bit_set): Define only if SIGIO.
2318 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2319 (send_process): Repair possible setjmp clobbering.
2320
efc736d3
PE
2321 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2322
4e2fe2e6
PE
2323 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2324
f97334a2
PE
2325 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2326
4e75f29d
PE
2327 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2328 Define only if needed.
2329
90efadd1
PE
2330 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2331 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2332 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2333
3c647824
PE
2334 * dispextern.h (struct redisplay_interface): Rename param
2335 to avoid shadowing.
e264f262 2336 * termhooks.h (struct terminal): Likewise.
761383f4 2337 * xterm.c (xembed_send_message): Likewise.
3c647824 2338
b58c5c4a
PE
2339 * insdel.c (make_gap_smaller): Define only if
2340 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2341
cad59032
PE
2342 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2343 it.
2344
c339dc2e
PE
2345 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2346 so that we aren't warned about unused symbols.
2347
91a3e27b
PE
2348 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2349
399c71d3 2350 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2351
8ffc96f5
PE
2352 * xfns.c (x_real_positions): Mark locals as initialized.
2353
eef9bc79
PE
2354 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2355
098db9dd
PE
2356 * xterm.c: Fix problems found by static analysis with other toolkits.
2357 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2358 (x_dispatch_event): Declare static if USE_GTK, and
2359 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2360 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2361 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2362 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2363 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2364
eb18f6cc
PE
2365 * xmenu.c (menu_help_callback): Pointer type fixes.
2366 Use const pointers when pointing at readonly data. Avoid pointer
2367 signedness clashes.
2368 (FALSE): Remove unused macro.
2369 (update_frame_menubar): Remove unused decl.
2370
1fe72bf8
PE
2371 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2372
60d9e1db
PE
2373 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2374 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2375 (single_menu_item): Rename local to avoid shadowing.
2376
39261c26
PE
2377 * keyboard.c (make_lispy_event): Remove unused local var.
2378
018c5e19
PE
2379 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2380 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2381
63d2b86e
PE
2382 * bitmaps: Change bitmaps from unsigned char back to the X11
2383 compatible char. Avoid the old compiler warnings about
2384 out-of-range initializers by using, for example, '\xab' rather
2385 than 0xab.
2386
aefd87e1
PE
2387 * xgselect.c (xgselect_initialize): Check vs interface
2388 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2389
bf501fb9
PE
2390 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2391
e9829fdf
PE
2392 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2393 to read-only memory.
2394
1086c095
PE
2395 * fns.c (vector): Remove; this old hack is no longer needed.
2396
2baccd04 2397 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2398 Remove unused var.
dde42981 2399 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2400
72391843 2401 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2402
436c16df 2403 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2404 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2405 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2406
92bb796d 2407 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2408 (x_term_init): Remove local to avoid shadowing.
92bb796d 2409
764430a3 2410 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2411
2412 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2413 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2414
d1dfb56c
EZ
24152011-04-16 Eli Zaretskii <eliz@gnu.org>
2416
c4354cb4
EZ
2417 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2418
d1dfb56c
EZ
2419 Fix regex.c, syntax.c and friends for buffers > 2GB.
2420 * syntax.h (struct gl_state_s): Declare character position members
2421 EMACS_INT.
2422
2423 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2424
04f2d78b
CB
2425 * textprop.c (verify_interval_modification, interval_of):
2426 Declare arguments EMACS_INT.
d1dfb56c
EZ
2427
2428 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2429 EMACS_INT.
2430
2431 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2432
2433 * indent.c (Fvertical_motion): Local variable it_start is now
2434 EMACS_INT.
2435
2436 * regex.c (re_match, re_match_2, re_match_2_internal)
2437 (bcmp_translate, regcomp, regexec, print_double_string)
2438 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2439 (re_compile_pattern, re_exec): Declare arguments and local
2440 variables `size_t' and `ssize_t' and return values `regoff_t', as
2441 appropriate.
2442 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2443 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2444 <compile_stack_type>: `size' and `avail' are now `size_t'.
2445
2446 * regex.h <regoff_t>: Use ssize_t, not int.
2447 (re_search, re_search_2, re_match, re_match_2): Arguments that
2448 specify buffer/string position and length are now ssize_t and
2449 size_t. Return type is regoff_t.
2450
613052cd
BK
24512011-04-16 Ben Key <bkey76@gmail.com>
2452
2453 * nsfont.m: Fixed bugs in ns_get_family and
2454 ns_descriptor_to_entity that were caused by using free to
2455 deallocate memory blocks that were allocated by xmalloc (via
2456 xstrdup). This caused Emacs to crash when compiled with
2457 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2458 --enable-checking=xmallocoverrun). xfree is now used to
2459 deallocate these memory blocks.
2460
4170f62f 24612011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2462
71b41406
PE
2463 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2464
9587a89d
PE
2465 emacs_write: Accept and return EMACS_INT for sizes.
2466 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2467 et seq.
2468 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2469 Accept and return EMACS_INT.
2470 (emacs_gnutls_write): Return the number of bytes written on
2471 partial writes.
2472 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2473 (emacs_read, emacs_write): Remove check for negative size, as the
2474 Emacs source code has been audited now.
9587a89d
PE
2475 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2476 (emacs_read, emacs_write): Use it.
273a5f82
PE
2477 * process.c (send_process): Adjust to the new signatures of
2478 emacs_write and emacs_gnutls_write. Do not attempt to store
2479 a byte offset into an 'int'; it might overflow.
9587a89d 2480 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2481
3e047f51
PE
2482 * sound.c: Don't assume sizes fit in 'int'.
2483 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2484 Return EMACS_INT, not int.
3e047f51 2485 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2486 Accept EMACS_INT, not int.
2487 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2488 record read return values.
2489
cc39a9db
BK
24902011-04-15 Ben Key <bkey76@gmail.com>
2491
c9d0ec6d
JB
2492 * keyboard.c (Qundefined): Don't declare static since it is used
2493 in nsfns.m.
2494 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2495 static since they are used in nsfont.m.
cc39a9db 2496
6c60eb9f
SM
24972011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2498
2499 * process.c (Qprocessp): Don't declare static.
2500 * lisp.h (Qprocessp): Declare again.
2501
7990b61a
JB
25022011-04-15 Juanma Barranquero <lekktu@gmail.com>
2503
2504 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2505
5d4cb038
PE
25062011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2507
8bd7b830 2508 Improve C-level modularity by making more things 'static'.
cd64ea1d 2509
e3b27b31
PE
2510 Don't publish debugger-only interfaces to other modules.
2511 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2512 (verify_bytepos, count_markers): Move decls to the only modules
2513 that need them.
2514 * region-cache.h (pp_cache): Likewise.
2515 * window.h (check_all_windows): Likewise.
2516 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2517
5d4cb038
PE
2518 * sysdep.c (croak): Now static, if
2519 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2520 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2521
2522 * alloc.c (refill_memory_reserve): Now static if
2523 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2524 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2525
e87b6180
PE
2526 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2527 Define only if USE_LUCID.
2528
ac64929e
PE
2529 * xrdb.c (x_customization_string, x_rm_string): Now static.
2530
6f37259d
PE
2531 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2532 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2533
1683e3ab
PE
2534 * xdisp.c (draw_row_with_mouse_face): Now static.
2535 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2536
de9c2632
PE
2537 * window.h (check_all_windows): Mark externally visible.
2538
2b96acb7
PE
2539 * window.c (window_deletion_count): Now static.
2540
2541 * undo.c: Make symbols static if they're not exported.
2542 (last_undo_buffer, last_boundary_position, pending_boundary):
2543 Now static.
2544
50436f33
PE
2545 * textprop.c (interval_insert_behind_hooks): Now static.
2546 (interval_insert_in_front_hooks): Likewise.
2547
64520e5c
PE
2548 * term.c: Make symbols static if they're not exported.
2549 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2550 (max_frame_lines, tty_set_terminal_modes):
2551 (tty_reset_terminal_modes, tty_turn_off_highlight):
2552 (get_tty_terminal): Now static.
2553 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2554 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2555 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2556 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2557 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2558
1fa53021
PE
2559 * sysdep.c: Make symbols static if they're not exported.
2560 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2561 Now static.
2562 (sigprocmask_set, full_mask): Remove; unused.
2563 (wait_debugging): Mark as visible.
2564 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2565 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2566
d4b43b22
PE
2567 * syntax.c (syntax_temp): Define only if !__GNUC__.
2568
b7c513d0
PE
2569 * sound.c (current_sound_device, current_sound): Now static.
2570
989b29ad
PE
2571 * search.c (searchbufs, searchbuf_head): Now static.
2572
13a55a78
PE
2573 * scroll.c (scroll_cost): Remove; unused.
2574 * dispextern.h (scroll_cost): Remove decl.
2575
de68a1fc
PE
2576 * region-cache.h (pp_cache): Mark as externally visible.
2577
40ccffa6
PE
2578 * process.c: Make symbols static if they're not exported.
2579 (process_tick, update_tick, create_process, chan_process):
2580 (Vprocess_alist, proc_buffered_char, datagram_access):
2581 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2582 (deactivate_process): Mark defn as static, as well as decl.
2583 * lisp.h (create_process): Remove decl.
2584 * process.h (chan_process, Vprocess_alist): Remove decls.
2585
ad64fc97
PE
2586 * print.c: Make symbols static if they're not exported.
2587 (print_depth, new_backquote_output, being_printed, print_buffer):
2588 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2589 (print_interval, print_number_index, initial_stderr_stream):
2590 Now static.
2591 * lisp.h (Fprinc): Remove decl.
2592 (debug_output_compilation_hack): Mark as externally visible.
2593
adddb265
PE
2594 * sysdep.c (croak): Move decl from here to syssignal.h.
2595 * syssignal.h (croak): Put it here, so the API can be checked when
2596 'croak' is called from dissociate_if_controlling_tty.
2597
1717ede2
PE
2598 * minibuf.c: Make symbols static if they're not exported.
2599 (minibuf_save_list, choose_minibuf_frame): Now static.
2600 * lisp.h (choose_minibuf_frame): Remove decl.
2601
fa5fb2bc
PE
2602 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2603
1e3890d1
PE
2604 * lread.c: Make symbols static if they're not exported.
2605 (read_objects, initial_obarray, oblookup_last_bucket_number):
2606 Now static.
2607 (make_symbol): Remove; unused.
2608 * lisp.h (initial_obarray, make_symbol): Remove decls.
2609
8a1414fa
PE
2610 * keyboard.c: Make symbols static if they're not exported.
2611 (single_kboard, recent_keys_index, total_keys, recent_keys):
2612 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2613 (this_single_command_key_start, echoing, last_auto_save):
2614 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2615 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2616 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2617 (Vlispy_mouse_stem, double_click_count):
2618 Now static.
2619 (force_auto_save_soon): Define only if SIGDANGER.
2620 (ignore_mouse_drag_p): Now static if
2621 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2622 (print_help): Remove; unused.
2623 (stop_character, last_timer_event): Mark as externally visible.
2624 * keyboard.h (ignore_mouse_drag_p): Declare only if
2625 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2626 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2627 * lisp.h (echoing): Remove decl.
2628 (force_auto_save_soon): Declare only if SIGDANGER.
2629 * xdisp.c (redisplay_window): Simplify code, to make it more
2630 obvious that ignore_mouse_drag_p is not accessed if !defined
2631 USE_GTK && !defined HAVE_NS.
2632
93ea6e8f
PE
2633 * intervals.c: Make symbols static if they're not exported.
2634 (merge_properties_sticky, merge_interval_right, delete_interval):
2635 Now static.
2636 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2637
77382fcc
PE
2638 * insdel.c: Make symbols static if they're not exported.
2639 However, leave prepare_to_modify_buffer alone. It's never
2640 called from outside this function, but that appears to be a bug.
2641 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2642 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2643 (adjust_after_replace_noundo): Remove; unused.
2644 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2645 (signal_before_change): Remove decls.
77382fcc 2646
9306c32e
PE
2647 * indent.c (val_compute_motion, val_vmotion): Now static.
2648
cd44d2eb
PE
2649 * image.c: Make symbols static if they're not exported.
2650 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2651 if USE_GTK.
2652 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2653 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2654
ad9a7a06
PE
2655 * fringe.c (standard_bitmaps): Now static.
2656 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2657
81626931
PE
2658 * frame.c: Make symbols static if they're not exported.
2659 (x_report_frame_params, make_terminal_frame): Now static.
2660 (get_frame_param): Now static, unless HAVE_NS.
2661 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2662 (x_get_resource_string): Remove; not used.
2663 * frame.h (make_terminal_frame, x_report_frame_params):
2664 (x_get_resource_string); Remove decls.
2665 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2666 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2667
239f9db9
PE
2668 * font.c, fontset.c: Make symbols static if they're not exported.
2669 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2670 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2671 * font.c (font_close_object): Now static.
2672 * font.h (font_close_object): Remove.
2673 * fontset.c (FONTSET_OBJLIST): Remove.
2674 (free_realized_fontset) #if-0 the body, which does nothing.
2675 (face_suitable_for_char_p): #if-0, as it's never called.
2676 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2677 * xfaces.c (face_at_string_position):
2678 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2679 since 0 is always ASCII.
2680
dfcf3579
PE
2681 * fns.c (weak_hash_tables): Now static.
2682
5045092b
PE
2683 * fileio.c: Make symbols static if they're not exported.
2684 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2685 (Vwrite_region_annotation_buffers): Now static.
2686
57a96f5c
PE
2687 * eval.c: Make symbols static if they're not exported.
2688 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2689 * lisp.h (backtrace_list): Remove decl.
2690
35f08c38
PE
2691 * emacs.c: Make symbols static if they're not exported.
2692 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2693 (fatal_error_code, fatal_error_signal_hook, standard_args):
2694 Now static.
2695 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2696 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2697 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2698 * lisp.h (fatal_error_signal_hook): Remove decl.
2699 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2700
f44bd759
PE
2701 * editfns.c: Move a (normally-unused) function to its only use.
2702 * editfns.c, lisp.h (get_operating_system_release): Remove.
2703 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2704 worth the hassle of breaking this out.
2705
b532497d
PE
2706 * xterm.c: Make symbols static if they're not exported.
2707 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2708 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2709 (x_destroy_window, x_delete_display):
2710 Now static.
2711 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2712 (x_mouse_leave): Remove; unused.
2713 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2714 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2715 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2716 Remove decls.
2717 (x_mouse_leave): Declare only if WINDOWSNT.
2718 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2719 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2720 USE_X_TOOLKIT.
2721
1675728f
PE
2722 * ftxfont.c: Make symbols static if they're not exported.
2723 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2724 HAVE_FREETYPE.
2725 * font.h (ftxfont_driver): Likewise.
2726
e4cebfca
PE
2727 * xfns.c: Make symbols static if they're not exported.
2728 (x_last_font_name, x_display_info_for_name):
2729 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2730 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2731 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2732 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2733 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2734 (last_show_tip_args): Now static.
2735 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2736 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2737 (x_screen_planes): Remove; unused.
2738 * dispextern.h (x_screen_planes): Remove decl.
2739
5bf46f05
PE
2740 * dispnew.c: Make symbols static if they're not exported.
2741 * dispextern.h (redraw_garbaged_frames, scrolling):
2742 (increment_row_positions): Remove.
2743 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2744 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2745 Now static.
2746 (redraw_garbaged_frames): Remove; unused.
2747
435f4c28
PE
2748 * xfaces.c: Make symbols static if they're not exported.
2749 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2750 Remove decls.
2751 * xterm.h (defined_color): Remove decls.
2752 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2753 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2754 (menu_face_changed_default, defined_color, free_realized_face):
2755 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2756 (ascii_face_of_lisp_face): Remove; unused.
2757
8524aef3
PE
2758 * xdisp.c: Make symbols static if they're not exported.
2759 * dispextern.h (scratch_glyph_row, window_box_edges):
2760 (glyph_to_pixel_coords, set_cursor_from_row):
2761 (get_next_display_element, set_iterator_to_next):
2762 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2763 (show_mouse_face): Remove decls
2764 * frame.h (message_buf_print): Likewise.
2765 * lisp.h (pop_message, set_message, check_point_in_composition):
2766 Likewise.
2767 * xterm.h (set_vertical_scroll_bar): Likewise.
2768 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2769 (message_buf_print, scratch_glyph_row, displayed_buffer):
2770 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2771 (get_next_display_element, show_mouse_face, window_box_edges):
2772 (frame_to_window_pixel_xy, check_point_in_composition):
2773 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2774 (glyph_to_pixel_coords): Remove; unused.
2775
16390cd2
PE
2776 * dired.c (file_name_completion): Now static.
2777
2778 * dbusbind.c (xd_in_read_queued_messages): Now static.
2779
a25f4dfa
PE
2780 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2781 * data.c (circular_list_error): Remove.
2782
14a9c8df
PE
2783 * commands.h (last_point_position, last_point_position_buffer):
2784 (last_point_position_window): Remove decls.
2785 * keyboard.c: Make these variables static.
2786
04f2d78b
CB
2787 * coding.h (coding, code_convert_region, encode_coding_gap):
2788 Remove decls.
74ab6df5
PE
2789 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2790 (iso_code_class, detect_coding, code_convert_region): Now static.
2791 (encode_coding_gap): Remove; unused.
2792
38dfbee1
PE
2793 * chartab.c (chartab_chars, chartab_bits): Now static.
2794
a2cb4e63
PE
2795 * charset.h (charset_iso_8859_1): Remove decl.
2796 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2797 Now static.
2798
127198fd
PE
2799 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2800 * ccl.c (Vccl_program_table): Now static.
2801 (check_ccl_update): Remove; unused.
2802
d85b608f
PE
2803 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2804 * category.h: ... from here.
2805 * category.c (check_category_table, set_category_set): Now static.
2806
31cd66f3
PE
2807 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2808 * lisp.h: Remove these decls.
2809
c358e587
PE
2810 * buffer.c (buffer_count): Remove unused var.
2811
e78aecca
PE
2812 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2813 so that it's not optimized away.
2814 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2815 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2816 exported only to the debugger.
2817
e192d7d3 2818 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2819 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2820
92470028
PE
2821 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2822 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2823 was inaccessible from Lisp.
2824 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2825 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2826
244ed907
PE
2827 alloc.c: Import and export fewer symbols, and remove unused items.
2828 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2829 is defined.
2830 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2831 it's not optimized away by whole-program optimization.
2832 (message_enable_multibyte, free_misc): Remove.
2833 (catchlist, handlerlist, mark_backtrace):
2834 Declare only if BYTE_MARK_STACK.
2835 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2836 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2837 (message_enable_multibyte): Remove decl.
2838 (free_misc, interval_free_list, float_block, float_block_index):
2839 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2840 (cons_free_list, last_marked_index):
2841 Now static.
2842 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2843 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2844 (mark_backtrace): Define only if BYTE_MARK_STACK.
2845 * xdisp.c (message_enable_multibyte): Now static.
2846
61c2b50e 2847 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2848 This makes it easier for human readers (and static analyzers)
2849 to see whether these variables are used from other modules.
2850 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2851 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2852 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2853 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2854 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2855 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2856 * xmenu.c, xselect.c:
2857 Declare Q* vars static if they are not used in other modules.
2858 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2859 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2860 Remove decls of unexported vars.
2861 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2862
95c82688
PE
2863 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2864
16a97296
PE
2865 Make Emacs functions such as Fatom 'static' by default.
2866 This makes it easier for human readers (and static analyzers)
2867 to see whether these functions can be called from other modules.
2868 DEFUN now defines a static function. To make the function external
2869 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2870 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2871 (Finit_image_library):
16a97296
PE
2872 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2873 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2874 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2875 Remove decls, since these functions are now static.
2876 (Funintern, Fget_internal_run_time): New decls, since these functions
2877 were already external.
95c82688 2878
16a97296
PE
2879 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2880 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2881 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2882 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2883 * keyboard.c, keymap.c, lread.c:
2884 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2885 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2886 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2887 Mark functions with DEFUE instead of DEFUN,
2888 if they are used in other modules.
2889 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2890 decls for now-static functions.
2891 * buffer.h (Fdelete_overlay): Remove decl.
2892 * callproc.c (Fgetenv_internal): Mark as internal.
2893 * composite.c (Fremove_list_of_text_properties): Remove decl.
2894 (Fcomposition_get_gstring): New forward static decl.
2895 * composite.h (Fcomposite_get_gstring): Remove decl.
2896 * dired.c (Ffile_attributes): New forward static decl.
2897 * doc.c (Fdocumntation_property): New forward static decl.
2898 * eval.c (Ffetch_bytecode): New forward static decl.
2899 (Funintern): Remove extern decl; now in .h file where it belongs.
2900 * fileio.c (Fmake_symbolic_link): New forward static decl.
2901 * image.c (Finit_image_library): New forward static decl.
2902 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2903 * intervals.h (Fprevious_property_change):
2904 (Fremove_list_of_text_properties): Remove decls.
2905 * keyboard.c (Fthis_command_keys): Remove decl.
2906 (Fcommand_execute): New forward static decl.
2907 * keymap.c (Flookup_key): New forward static decl.
2908 (Fcopy_keymap): Now static.
2909 * keymap.h (Flookup_key): Remove decl.
2910 * process.c (Fget_process): New forward static decl.
2911 (Fprocess_datagram_address): Mark as internal.
2912 * syntax.c (Fsyntax_table_p): New forward static decl.
2913 (skip_chars): Remove duplicate decl.
2914 * textprop.c (Fprevious_property_change): New forward static decl.
2915 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2916 Now internal.
2917 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2918 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2919
785bbd42
PE
2920 * editfns.c (Fformat): Remove unreachable code.
2921
8b913b57
AS
29222011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2923
2924 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2925 change. (Bug#8496)
2926
a6744a35
EZ
29272011-04-13 Eli Zaretskii <eliz@gnu.org>
2928
2929 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2930 when at ZV. (Bug#8487)
2931
e7974947
AS
29322011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2933
baad03f0
AS
2934 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2935 (Bug#8437)
2936 * keyboard.c (parse_tool_bar_item): Likewise.
2937 * sound.c (sound_cleanup, alsa_close): Likewise.
2938 * termcap.c (tgetent): Likewise.
2939 * xfns.c (x_default_font_parameter): Likewise.
2940 * xsettings.c (read_and_apply_settings): Likewise.
2941
e7974947
AS
2942 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2943 (overrun_check_free): Protoize.
2944
28272684
PE
29452011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2946
2947 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2948 since callers should never pass a negative size.
2949 Change the signature to match that of plain 'read' and 'write'; see
2950 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2951 * lisp.h: Update prototypes of emacs_write and emacs_read.
2952
11997c76
EZ
29532011-04-11 Eli Zaretskii <eliz@gnu.org>
2954
2955 * xdisp.c (redisplay_window): Don't try to determine the character
2956 position of the scroll margin if the window start point w->startp
e896f03c 2957 is outside the buffer's accessible region. (Bug#8468)
11997c76 2958
8a2cbd72
EZ
29592011-04-10 Eli Zaretskii <eliz@gnu.org>
2960
2961 Fix write-region and its subroutines for buffers > 2GB.
2962 * fileio.c (a_write, e_write): Modify declaration of arguments and
2963 local variables to support buffers larger than 2GB.
2964 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2965
2966 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2967 argument, local variables, and return value.
2968
2969 * lisp.h: Update prototypes of emacs_write and emacs_read.
2970
2971 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2972
4073e537 29732011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2974
1ebfdcb6
PE
2975 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2976
b2ded58d
PE
2977 Fix more problems found by GCC 4.6.0's static checks.
2978
7d66342c
PE
2979 * xdisp.c (vmessage): Use a better test for character truncation.
2980
bbf47d44
PE
2981 * charset.c (load_charset_map): <, not <=, for optimization,
2982 and to avoid potential problems with integer overflow.
9248994d 2983 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2984 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2985 * editfns.c (Fformat): Likewise.
1e69125e 2986 * syntax.c (skip_chars): Likewise.
3befa583 2987
e3019616
PE
2988 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2989 This also lets GCC 4.6.0 generate slightly better loop code.
2990
becfa255
PE
2991 * callint.c (Fcall_interactively): <, not <=, for optimization.
2992 (Fcall_interactively): Count the number of arguments produced,
2993 not the number of arguments given. This is simpler and lets GCC
2994 4.6.0 generate slightly better code.
2995
dae0cd48
PE
2996 * ftfont.c: Distingish more carefully between FcChar8 and char.
2997 The previous code passed unsigned char * to a functions like
2998 strlen and xstrcasecmp that expect char *, which does not
2999 conform to the C standard.
3000 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3001 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3002 char * when the C standard requires it.
3003
76032d70
PE
3004 * keyboard.c (read_char): Remove unused var.
3005
eb3f1cc8
PE
3006 * eval.c: Port to Windows vsnprintf (Bug#8435).
3007 Include <limits.h>.
3008 (SIZE_MAX): Define if the headers do not.
3009 (verror): Do not give up if vsnprintf returns a negative count.
3010 Instead, grow the buffer. This ports to Windows vsnprintf, which
3011 does not conform to C99. Problem reported by Eli Zaretskii.
3012 Also, simplify the allocation scheme, by avoiding the need for
3013 calling realloc, and removing the ALLOCATED variable.
3014
70476b54
PE
3015 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3016
12020a9e
PE
3017 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3018 But keep the doprint source code for now, as we might revamp it
3019 and use it again (Bug#8435).
ea6c7ae6
PE
3020 * lisp.h (doprnt): Remove.
3021 * Makefile.in (base_obj): Remove doprnt.o.
3022 * deps.mk (doprnt.o): Remove.
3023
5fdb398c
PE
3024 error: Print 32- and 64-bit integers portably (Bug#8435).
3025 Without this change, on typical 64-bit hosts error ("...%d...", N)
3026 was used to print both 32- and 64-bit integers N, which relied on
3027 undefined behavior.
3028 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3029 New macro.
3030 * lisp.h (error, verror): Mark as printf-like functions.
3031 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3032 Report overflow in size calculations when allocating printf buffer.
3033 Do not truncate output string at its first null byte.
3034 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3035 Truncate the output at a character boundary, since vsnprintf does not
3036 do that.
3037 * charset.c (check_iso_charset_parameter): Convert internal
3038 character to string before calling 'error', since %c now has the
3039 printf meaning.
3040 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3041 overflow when computing char to be passed to 'error'. Do not
3042 pass Lisp_Object to 'error'; pass the integer instead.
3043 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3044 formatted with plain %d.
3045
b189fa66
PE
3046 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3047
bff87ef0
PE
3048 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3049
7e2cac20
PE
3050 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3051
ce4d90b5
PE
3052 * xterm.c (x_catch_errors): Remove duplicate declaration.
3053
266c9547
PE
3054 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3055
79c49ad2
PE
3056 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3057
368f4090
JM
30582011-04-10 Jim Meyering <meyering@redhat.com>
3059
3060 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3061 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3062 return ssize_t not "int", and use size_t as the buffer length.
3063 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3064 * gnutls.h: Update declarations.
3065 * process.c (read_process_output): Use ssize_t, to match.
3066 (send_process): Likewise.
3067
a32d4040
CY
30682011-04-09 Chong Yidong <cyd@stupidchicken.com>
3069
3070 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3071
8546720e 30722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3073
04f2d78b
CB
3074 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3075 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3076
8546720e
GM
3077 * xterm.c (handle_one_xevent):
3078 * xmenu.c (create_and_show_popup_menu):
3079 * xselect.c (x_decline_selection_request)
3080 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3081
0a2f5c1a 30822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3083
3084 Fix some uses of `int' instead of EMACS_INT.
3085 * search.c (string_match_1, fast_string_match)
3086 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3087 (scan_buffer, find_next_newline_no_quit)
3088 (find_before_next_newline, search_command, Freplace_match)
3089 (Fmatch_data): Make some `int' variables be EMACS_INT.
3090
3091 * xdisp.c (display_count_lines): 3rd argument and return value now
3092 EMACS_INT. All callers changed.
3093 (pint2hrstr): Last argument is now EMACS_INT.
3094
3095 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3096 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3097 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3098 (decode_coding_utf_16, decode_coding_emacs_mule)
3099 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3100 (decode_coding_ccl, decode_coding_charset)
3101 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3102 (decode_coding_iso_2022, decode_coding_emacs_mule)
3103 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3104 <char_offset, last_offset>: Declare EMACS_INT.
3105 (encode_coding_utf_8, encode_coding_utf_16)
3106 (encode_coding_emacs_mule, encode_invocation_designation)
3107 (encode_designation_at_bol, encode_coding_iso_2022)
3108 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3109 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3110 Declare EMACS_INT.
3111 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3112 (encode_invocation_designation): Last argument P_NCHARS is now
3113 EMACS_INT.
3114 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3115 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3116
3117 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3118 All users changed.
3119
3120 * ccl.c (Fccl_execute_on_string): Declare some variables
3121 EMACS_INT.
3122
8546720e 31232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3124
3125 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3126
4e19a977
CS
31272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3128
3129 * process.c (Fformat_network_address): Doc fix.
3130
87302331
R
31312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3132
3133 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3134
cbb59342
CY
31352011-04-08 Chong Yidong <cyd@stupidchicken.com>
3136
3137 * keyboard.c (read_char): Call Lisp function help-form-show,
3138 instead of using internal_with_output_to_temp_buffer.
3139 (Qhelp_form_show): New var.
e0d38eeb 3140 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3141
3142 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3143
3144 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3145
e67a13ab
CY
31462011-04-06 Chong Yidong <cyd@stupidchicken.com>
3147
04f2d78b
CB
3148 * process.c (Flist_processes): Remove to Lisp.
3149 (list_processes_1): Delete.
e67a13ab 3150
973f782d
EZ
31512011-04-06 Eli Zaretskii <eliz@gnu.org>
3152
7c106b1e
EZ
3153 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3154
973f782d
EZ
3155 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3156
41cf7d1a 31572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3158
ca23cc88
PE
3159 Fix more problems found by GCC 4.6.0's static checks.
3160
f390e2d5
PE
3161 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3162
42eea0d0
PE
3163 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3164
b69769da 3165 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3166
f9541e84
PE
3167 * xdisp.c (vmessage): Mark as a printf-like function.
3168
13841b55
PE
3169 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3170
c136c10f
PE
3171 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3172
5e2d4a30
PE
3173 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3174 printf-like functions.
3175 (tiff_load): Add casts to remove these marks before passing them
3176 to system-supplied API.
3177
583f48b9
PE
3178 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3179
b25d760e
PE
3180 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3181 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3182 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3183 directly, rather than having caller test rule sign. This avoids
3184 some unnecessary tests.
3185 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3186 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3187 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3188
bc7b6697 3189 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3190 (xfont_open): Avoid unnecessary tests.
bc7b6697 3191
27ccc379
PE
3192 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3193
dcd5c89a
PE
3194 * composite.h, composite.c (composition_gstring_put_cache):
3195 Use EMACS_INT, not int, for length.
3196
b13a45c6
PE
3197 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3198 breaking out part of COMPOSITION_DECODE_RULE.
3199 (COMPOSITION_DECODE_RULE): Use it.
3200 * composite.c (get_composition_id): Remove unused local vars,
3201 by using the new macro.
3202
1e792e4d
PE
3203 * textprop.c (set_text_properties_1): Change while to do-while,
3204 since the condition is always true at first.
3205
dc6c6455 3206 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3207 (interval_deletion_adjustment): Return unsigned value.
3208 All uses changed.
dc6c6455 3209
aba7731a
PE
3210 * process.c (list_processes_1, create_pty, read_process_output):
3211 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3212 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3213 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3214 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3215 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3216
fdfc4bf3
PE
3217 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3218
fca8fe46 3219 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3220 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3221
06a0259a 3222 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3223 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3224 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3225
e7b9e80f
PE
3226 * print.c (print_error_message): Avoid int overflow.
3227
56201685
PE
3228 * font.c (font_list_entities): Redo for clarity,
3229 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3230
78834453 3231 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3232 (font_score): Avoid potential overflow in diff calculation.
78834453 3233
0bc0b309 3234 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3235 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3236
e610eaca
PE
3237 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3238
b895abce
PE
3239 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3240 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3241 can always succeed if overflow has undefined behavior.
3242
1f1d9321 3243 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3244 (wordify): Omit three unnecessary tests.
1f1d9321 3245
c59478bc
PE
3246 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3247 All callers changed. This avoids the need for an unused var.
3248
79b73827
PE
3249 * casefiddle.c (casify_region): Remove var that is set but not used.
3250
a4db5dfe
PE
3251 * dired.c (file_name_completion): Remove var that is set but not used.
3252
43aae36e
PE
3253 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3254
2a47c44d 3255 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3256 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3257
a37c69bf
PE
3258 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3259 Check for integer overflow on size calculations.
3260
328ab8e7
PE
3261 * buffer.c (Fprevious_overlay_change): Remove var that is set
3262 but not used.
3263
e5a2a5cb
PE
3264 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3265 Remove vars that are set but not used.
8d84a6eb 3266 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3267 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3268
a60e5f68
PE
3269 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3270
f661cb61 3271 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3272 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3273
f0397f5a
PE
3274 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3275 that are set but not used.
3276
8664db06 3277 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3278 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3279
6abdaa4a
PE
3280 * xselect.c (x_get_local_selection, x_handle_property_notify):
3281 Remove vars that are set but not used.
3282
0ce7538d 3283 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3284 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3285
9ae848fc
PE
3286 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3287 Remove var that is set but not used.
0b918413
PE
3288 (scroll_bar_windows_size): Now size_t, not int.
3289 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3290 Check for overflow.
9ae848fc 3291
a5a62657
PE
3292 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3293 (map_tty_color) [!defined MSDOS]: Likewise.
3294
5c5cdd39
PE
3295 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3296
66ebf983
PE
3297 * coding.c: Remove vars that are set but not used.
3298 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3299 All callers changed.
3300 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3301 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3302 (decode_coding_charset): Remove vars that are set but not used.
3303
1be4d761
PE
3304 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3305 that is set but not used.
3306
47553fa8
PE
3307 * print.c (print_object): Remove var that is set but not used.
3308
1f7196bf 3309 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3310 The gnulib version avoids calling malloc in the usual case,
3311 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3312 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3313 * filelock.c (current_lock_owner): Likewise.
3314 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3315 * sysdep.c: Include allocator.h, careadlinkat.h.
3316 (emacs_no_realloc_allocator): New static constant.
3317 (emacs_readlink): New function.
fdb61804
PE
3318 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3319 ../lib/careadlinkat.h.
d1fdcab7 3320
f84c17c7
SM
33212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3322
3323 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3324 first non-nil return value).
3325
ef3862ad
JD
33262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3327
3328 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3329 if not defined (Bug#8403).
3330
376a7006
JB
33312011-04-02 Juanma Barranquero <lekktu@gmail.com>
3332
3333 * xdisp.c (display_count_lines): Remove parameter `start',
3334 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3335 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3336 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3337 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3338 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3339 and thereabouts. All callers changed.
3340 (get_per_char_metric): Remove parameter `f', unused since
3341 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3342
6ca3801d
JM
33432011-04-02 Jim Meyering <meyering@redhat.com>
3344
3345 do not dereference NULL upon failed strdup
3346 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3347 (ns_get_family): Likewise.
3348
d8e2b5ba
JB
33492011-04-02 Juanma Barranquero <lekktu@gmail.com>
3350
3351 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3352
8c74fcbd
JD
33532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3354
3355 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3356 later (Bug#8403).
3357
7200d79c
SM
33582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3359
03408648 3360 Add lexical binding.
7200d79c 3361
03408648
SM
3362 * window.c (Ftemp_output_buffer_show): New fun.
3363 (Fsave_window_excursion):
3364 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3365
3366 * lread.c (lisp_file_lexically_bound_p): New function.
3367 (Fload): Bind Qlexical_binding.
3368 (readevalloop): Remove `evalfun' arg.
3369 Bind Qinternal_interpreter_environment.
3370 (Feval_buffer): Bind Qlexical_binding.
3371 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3372 Mark as dynamic.
3373 (syms_of_lread): Declare `lexical-binding'.
3374
3375 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3376
3377 * keyboard.c (eval_dyn): New fun.
3378 (menu_item_eval_property): Use it.
ca105506
SM
3379
3380 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3381
03408648
SM
3382 * fns.c (concat, mapcar1): Accept byte-code-functions.
3383
3384 * eval.c (Fsetq): Handle lexical vars.
3385 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3386 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3387 (FletX, Flet): Obey lexical binding.
3388 (Fcommandp): Handle closures.
3389 (Feval): New `lexical' arg.
3390 (eval_sub): New function extracted from Feval. Use it almost
3391 everywhere where Feval was used. Look up vars in lexical env.
3392 Handle closures.
3393 (Ffunctionp): Move from subr.el.
3394 (Ffuncall): Handle closures.
3395 (apply_lambda): Remove `eval_flags'.
3396 (funcall_lambda): Handle closures and new byte-code-functions.
3397 (Fspecial_variable_p): New function.
3398 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3399 but without exporting it to Lisp.
23aba0ea 3400
23aba0ea 3401 * doc.c (Fdocumentation, store_function_docstring):
03408648 3402 * data.c (Finteractive_form): Handle closures.
23aba0ea 3403
03408648
SM
3404 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3405 interactive spec.
ba83908c 3406
04f2d78b
CB
3407 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3408 New byte-codes.
03408648
SM
3409 (exec_byte_code): New function extracted from Fbyte_code to handle new
3410 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3411
03408648 3412 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3413
03408648 3414 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3415
e2abce01
JB
34162011-03-31 Juanma Barranquero <lekktu@gmail.com>
3417
3418 * xdisp.c (redisplay_internal): Fix prototype.
3419
63696a73 34202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3421
63696a73 3422 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3423 (try_scrolling): Use it when setting scroll_limit.
3424 Limit scrolling to 100 screen lines.
63696a73
EZ
3425 (redisplay_window): Even when falling back on "recentering",
3426 position point in the window according to scroll-conservatively,
3427 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3428
3429 (try_scrolling): When point is above the window, allow searching
3430 as far as scroll_max, or one screenful, to compute vertical
3431 distance from PT to the scroll margin position. This prevents
3432 try_scrolling from unnecessarily failing when
3433 scroll-conservatively is set to a value slightly larger than the
3434 window height. Clean up the case of PT below the margin at bottom
3435 of window: scroll_max can no longer be INT_MAX. When aggressive
3436 scrolling is in use, don't let point enter the opposite scroll
3437 margin as result of the scroll.
3438 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3439 threshold of 100 lines for never-recentering scrolling.
3440
e4cc2dfc
JB
34412011-03-31 Juanma Barranquero <lekktu@gmail.com>
3442
3443 * dispextern.h (move_it_by_lines):
3444 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3445 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3446 (message_log_check_duplicate): Remove parameters `prev_bol' and
3447 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3448 (redisplay_internal): Remove parameter `preserve_echo_area',
3449 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3450
3451 * indent.c (Fvertical_motion):
3452 * window.c (window_scroll_pixel_based, Frecenter):
3453 Don't pass `need_y_p' to `move_it_by_lines'.
3454
1c470562
SM
34552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3456
44f230aa
SM
3457 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3458 steal a few bits to be more compact.
3459 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3460 Remove unneeded casts.
3461
1c470562
SM
3462 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3463
888adce9
ZK
34642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3465
3466 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3467 binding" message (bug#7967).
3468
f838ed7b
PE
34692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3470
77861b95
PE
3471 Fix more problems found by GCC 4.6.0's static checks.
3472
de6dbc14
PE
3473 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3474 Remove unused local var.
3475
f838ed7b
PE
3476 * editfns.c (Fmessage_box): Remove unused local var.
3477
792c7b2b
PE
3478 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3479 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3480 Omit unused local vars.
c499e557 3481 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3482 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3483 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3484 Omit unused local var.
3485
ba0165e1
PE
3486 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3487 Don't assume string length fits in int.
32ad8845 3488 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3489 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3490
3c59b4c9
PE
3491 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3492 instead of alloca (Bug#8344).
3493
a3eed478 3494 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3495 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3496
eb4d412d
PE
3497 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3498
1658b401
PE
3499 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3500 concerns.
3501
3502 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3503
3504 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3505
9a2c6e05
PE
3506 * keyboard.c (syms_of_keyboard): Use the same style as later
3507 in this function when indexing through an array. This also
3508 works around GCC bug 48267.
3509
03d0a109
PE
3510 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3511
44f730c8
PE
3512 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3513
fe75f926
PE
3514 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3515 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3516
ffa8c828
PE
3517 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3518 This avoids undefined behavior on integer overflow, and is a bit
3519 more convenient anyway since it is compared to a size_t variable.
3520
c5101a77
PE
3521 Variadic C functions now count arguments with size_t, not int.
3522 This avoids an unnecessary limitation on 64-bit machines, which
3523 caused (substring ...) to crash on large vectors (Bug#8344).
3524 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3525 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3526 All variadic functions and their callers changed accordingly.
c5101a77
PE
3527 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3528 * data.c (arith_driver, float_arith_driver): Likewise.
3529 * editfns.c (general_insert_function): Likewise.
3530 * eval.c (struct backtrace.nargs, interactive_p)
3531 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3532 (funcall_lambda, mark_backtrace): Likewise.
3533 * fns.c (concat): Likewise.
3534 * frame.c (x_set_frame_parameters): Likewise.
3535 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3536 0 if not found, not -1. All callers changed.
3537
dd3f25f7
PE
3538 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3539 (stack_copy_size): Now size_t, not int.
3540 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3541
461c2ab9
JB
35422011-03-28 Juanma Barranquero <lekktu@gmail.com>
3543
3544 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3545 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3546 All callers changed.
3547
3548 * lisp.h (multibyte_char_to_unibyte):
3549 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3550 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3551 * character.h (CHAR_TO_BYTE8):
3552 * cmds.c (internal_self_insert):
3553 * editfns.c (general_insert_function):
3554 * keymap.c (push_key_description):
3555 * search.c (Freplace_match):
3556 * xdisp.c (message_dolog, set_message_1): All callers changed.
3557
f6d62986
SM
35582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3559
3560 * keyboard.c (safe_run_hook_funcall): New function.
3561 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3562 don't set the hook to nil, but remove the offending function instead.
3563 (Qcommand_hook_internal): Remove, unused.
3564 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3565 Vcommand_hook_internal.
3566
3567 * eval.c (enum run_hooks_condition): Remove.
3568 (funcall_nil, funcall_not): New functions.
3569 (run_hook_with_args): Call each function through a `funcall' argument.
3570 Remove `cond' argument, now redundant.
3571 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3572 (Frun_hook_with_args_until_failure): Adjust accordingly.
3573 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3574
1db5b1ad
JB
35752011-03-28 Juanma Barranquero <lekktu@gmail.com>
3576
3577 * dispextern.h (string_buffer_position): Remove declaration.
3578
3579 * print.c (strout): Remove parameter `multibyte', unused since
3580 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3581
3582 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3583 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3584 All callers changed.
3585
3586 * w32.c (_wsa_errlist): Use braces for struct initializers.
3587
3588 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3589 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3590 All callers changed.
3591 (string_buffer_position): Likewise. Also, make static (it's never
3592 used outside xdisp.c).
3593 (cursor_row_p): Remove parameter `w', unused since
3594 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3595 (decode_mode_spec): Remove parameter `precision', introduced during
3596 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3597 All callers changed.
3598
5ffb62aa
JD
35992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3600
3601 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3602
461c2ab9 36032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3604
3605 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3606 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3607 (ns_update_auto_hide_menu_bar): New functions.
3608 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3609 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3610 ns_constrain_all_frames.
3611 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3612 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3613
5c380ffb
JD
36142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3615
3616 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3617
9af30bdf
GM
36182011-03-27 Glenn Morris <rgm@gnu.org>
3619
3620 * syssignal.h: Replace RETSIGTYPE with void.
3621 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3622 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3623 Replace SIGTYPE with void everywhere.
3624 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3625 * s/template.h (SIGTYPE): Remove commented out definition.
3626
e2abce01
JB
36272011-03-26 Eli Zaretskii <eliz@gnu.org>
3628
3629 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3630 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3631
f868cd8a
JB
36322011-03-26 Juanma Barranquero <lekktu@gmail.com>
3633
59eb0929
JB
3634 * w32.c (read_unc_volume): Use parameter `henum', instead of
3635 global variable `wget_enum_handle'.
3636
3637 * keymap.c (describe_vector): Remove parameters `indices' and
3638 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3639 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3640
f868cd8a
JB
3641 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3642
3643 * keyboard.c (timer_check): Remove parameter `do_it_now',
3644 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3645 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3646 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3647
3648 * keyboard.c (read_char):
3649 * w32menu.c (w32_menu_display_help):
3650 * xmenu.c (show_help_event, menu_help_callback):
3651 Adjust calls to `show_help_echo'.
3652
3653 * gtkutil.c (xg_maybe_add_timer):
3654 * keyboard.c (readable_events):
3655 * process.c (wait_reading_process_output):
3656 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3657
3658 * insdel.c (adjust_markers_gap_motion):
3659 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3660 (gap_left, gap_right): Don't call it.
3661
2ecf6fdb
CY
36622011-03-25 Chong Yidong <cyd@stupidchicken.com>
3663
3664 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3665 incurred during fontification.
3666
6b1f9ba4
JB
36672011-03-25 Juanma Barranquero <lekktu@gmail.com>
3668
3669 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3670 (DEFVAR_PER_BUFFER): Don't pass it.
3671
3672 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3673 (scrolling_window): Don't pass it.
3674
0f4a96b5
JB
36752011-03-25 Juanma Barranquero <lekktu@gmail.com>
3676
3677 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3678
3679 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3680 and `suffix'.
3681 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3682 of variables specific to SELinux and computation of `encoded_absname'.
3683
3684 * image.c (XPutPixel): Remove unused variable `height'.
3685
3686 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3687
3688 * unexw32.c (get_section_info): Remove unused variable `section'.
3689
3690 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3691 (system_process_attributes): Remove unused variable `sess'.
3692 (sys_read): Remove unused variable `err'.
3693
3694 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3695 (w32_wnd_proc): Remove unused variable `isdead'.
3696 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3697 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3698 (x_create_tip_frame): Remove unused variable `tem'.
3699
3700 * w32inevt.c (w32_console_read_socket):
3701 Remove unused variable `no_events'.
3702
3703 * w32term.c (x_draw_composite_glyph_string_foreground):
3704 Remove unused variable `width'.
3705
1149507c
JB
37062011-03-24 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * w32term.c (x_set_glyph_string_clipping):
3709 Don't pass uninitialized region to CombineRgn.
3710
9c88f339
JB
37112011-03-23 Juanma Barranquero <lekktu@gmail.com>
3712
3713 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3714 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3715 (Fx_close_connection): Remove unused variable `i'.
3716
3717 * w32font.c (w32font_draw): Return number of glyphs.
3718 (w32font_open_internal): Remove unused variable `i'.
3719 (w32font_driver): Add missing initializer.
3720
3721 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3722 (fill_in_menu): Remove unused variable `items_added'.
3723
3724 * w32term.c (last_mouse_press_frame): Remove static global variable.
3725 (w32_clip_to_row): Remove unused variable `f'.
3726 (x_delete_terminal): Remove unused variable `i'.
3727
3728 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3729 (NOTHING): Remove unused static global variable.
3730 (uniscribe_check_otf): Remove unused variable `table'.
3731 (uniscribe_font_driver): Add missing initializers.
3732
dee091a3
JD
37332011-03-23 Julien Danjou <julien@danjou.info>
3734
3735 * term.c (Fsuspend_tty, Fresume_tty):
3736 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3737 * window.c (temp_output_buffer_show):
3738 * insdel.c (signal_before_change):
3739 * frame.c (Fhandle_switch_frame):
3740 * fileio.c (Fdo_auto_save):
3741 * emacs.c (Fkill_emacs):
3742 * editfns.c (save_excursion_restore):
3743 * cmds.c (internal_self_insert):
3744 * callint.c (Fcall_interactively):
3745 * buffer.c (Fkill_all_local_variables):
3746 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3747 Use Frun_hooks.
0f4a96b5 3748 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3749 unconditionnaly since it does the check itself.
3750
2c520ab5 37512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3752
c9c49752
PE
3753 Fix more problems found by GCC 4.5.2's static checks.
3754
8abc3f12
PE
3755 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3756 the first time through the loop, since we know p0 < p1 then.
3757 This also avoids a gcc -Wstrict-overflow warning.
3758
a2d26660
PE
3759 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3760 leading to a memory leak, possible in functions like
3761 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3762 of objects (Bug#8318).
a2d26660 3763
916c72e9
PE
3764 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3765 that could (at least in theory) be that large.
3766
19ab8a18
PE
3767 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3768 This is less likely to overflow, and avoids undefined behavior if
3769 overflow does occur. All callers changed. Use strtoul to scan
3770 for the unsigned long integer.
b7cbbd6f
PE
3771 (pint2hrstr): Simplify and tune code slightly.
3772 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3773
f0641eff
PE
3774 * scroll.c (do_scrolling): Work around GCC bug 48228.
3775 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3776
7f650bb9
PE
3777 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3778 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3779 (validate_x_resource_name): Simplify count usage.
3780 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3781
37dd57d1
PE
3782 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3783 fail (Bug#8306).
81e56e61 3784
699979fc 3785 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3786
401bf9b4
PE
3787 * process.c (Fmake_network_process): Use socklen_t, not int,
3788 where POSIX says socklen_t is required in portable programs.
3789 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3790 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3791 (Fmake_network_process, server_accept_connection):
3792 (wait_reading_process_output, read_process_output):
3793 Likewise.
3794
b93aacde
PE
3795 * process.c: Rename or move locals to avoid shadowing.
3796 (list_processes_1, Fmake_network_process):
3797 (read_process_output_error_handler, exec_sentinel_error_handler):
3798 Rename or move locals.
4dc343ee 3799 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3800 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3801 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3802 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3803 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3804
af8a867c 3805 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3806 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3807 Include tparam.h instead, since it declares them.
af8a867c
PE
3808 * cm.h (PC): Remove extern decl; tparam.h now does this.
3809 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3810 * terminfo.c: Include tparam.h, to check interfaces.
3811 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3812 (tparam): Adjust signature to match interface in tparam.h;
3813 this removes some undefined behavior. Check that outstring and len
3814 are zero, which they always are with Emacs.
3815 * tparam.h (PC, BC, UP): New extern decls.
3816
0248044d 3817 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3818 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3819
8ff096c1 3820 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3821 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3822 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3823 (ftfont_list): Remove unused local.
49eaafba
PE
3824 (get_adstyle_property, ftfont_pattern_entity):
3825 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3826 Rename locals to avoid shadowing.
8ff096c1 3827
e2be39f6
PE
3828 * xfont.c (xfont_list_family): Mark var as initialized.
3829
c9735e30
PE
3830 * xml.c (make_dom): Now static.
3831
8f5201ae
PE
3832 * composite.c (composition_compute_stop_pos): Rename local to
3833 avoid shadowing.
b246f932
PE
3834 (composition_reseat_it): Remove unused locals.
3835 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3836 (composition_update_it): Mark var as initialized.
11b61122
PE
3837 (find_automatic_composition): Mark vars as initialized,
3838 with a FIXME (Bug#8290).
8f5201ae 3839
760fbc2c
PE
3840 character.h: Rename locals to avoid shadowing.
3841 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3842 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3843 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3844 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3845 to avoid shadowing.
3846
ff08eb85
PE
3847 * textprop.c (property_change_between_p): Remove; unused.
3848
fc7bf025
PE
3849 * intervals.c (interval_start_pos): Now static.
3850
235d7abc
PE
3851 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3852
44f230aa
SM
3853 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3854 Rename locals to avoid shadowing.
3e7d6594 3855
50060332
PE
3856 * sound.c (wav_play, au_play, Fplay_sound_internal):
3857 Fix pointer signedness.
d01f234b 3858 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3859 (wav_play): Initialize a variable to 0, to prevent undefined
3860 behavior (Bug#8278).
50060332 3861
c4fc4e30
PE
3862 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3863
918436ed
PE
3864 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3865
c939f91b
PE
3866 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3867 clobbering (Bug#8298).
b9c7f648
PE
3868 * sysdep.c (sys_subshell): Likewise.
3869 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3870
6bd8c144
PE
3871 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3872 This should get cleaned up, so that child_setup has the
3873 same signature on all platforms.
3874
7710357c 3875 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3876 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3877
c59da222
CY
38782011-03-22 Chong Yidong <cyd@stupidchicken.com>
3879
3880 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3881 not to be necessary, and produces flickering.
3882
66b87493
GM
38832011-03-20 Glenn Morris <rgm@gnu.org>
3884
3885 * config.in: Remove file.
3886
45b6f6d5
JB
38872011-03-20 Juanma Barranquero <lekktu@gmail.com>
3888
3889 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3890 are now in src/globals.h.
3891 (syms_of_minibuf): Remove spurious & from previous change.
3892
3ec03f7e
LL
38932011-03-20 Leo <sdl.web@gmail.com>
3894
3895 * minibuf.c (completing-read-function): New variable.
3896 (completing-read-default): Rename from completing-read.
3897 (completing-read): Call completing-read-function.
3898
b14e3e21
CY
38992011-03-19 Juanma Barranquero <lekktu@gmail.com>
3900
3901 * xfaces.c (Fx_load_color_file):
3902 Read color file from absolute filename (bug#8250).
3903
f2b726e6
JB
39042011-03-19 Juanma Barranquero <lekktu@gmail.com>
3905
3906 * makefile.w32-in: Update dependencies.
3907
09f6ff02
EZ
39082011-03-17 Eli Zaretskii <eliz@gnu.org>
3909
3910 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3911
29a6015a
PE
39122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3913
a3a6c54e
PE
3914 Fix more problems found by GCC 4.5.2's static checks.
3915
b766f867
PE
3916 * process.c (make_serial_process_unwind, send_process_trap):
3917 (sigchld_handler): Now static.
3918
be02381c
PE
3919 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3920 That way, the code declares only the vars that it needs.
3921 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3922 * s/cygwin.h (PTY_ITERATION): Likewise.
3923 * s/darwin.h (PTY_ITERATION): Likewise.
3924 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3925
57048744
PE
3926 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3927 * process.c (allocate_pty): Don't declare stb unless it's needed.
3928
7914961c 3929 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3930 (CONSTANTLIM): Remove; unused.
3931 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3932 Define only if needed.
7914961c 3933
b3967b18
PE
3934 * unexelf.c (unexec): Name an expression,
3935 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3936 Use a different way to cause a compilation error if anyone uses
3937 n rather than nn, a way that does not involve shadowing.
73366a00 3938 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3939
29a6015a
PE
3940 * deps.mk (unexalpha.o): Remove; unused.
3941
43cfc33e 3942 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3943 * unexec.h: New file.
ce701a33
PE
3944 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3945 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3946 Depend on unexec.h.
3947 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3948 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3949 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3950 Change as necessary to match prototype in unexec.h.
ce701a33 3951
01f44d5a
PE
3952 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3953 shadowing.
4f63c6bb 3954 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3955
a6670b0b
PE
3956 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3957 Rename locals to avoid shadowing.
3958
cef2010d 3959 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3960 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3961
d4d7173a
PE
3962 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3963
f08b802a
PE
3964 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3965 warning when compiling print.c.
3966
3ddb0639
PE
3967 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3968 instead of using an uninitialized var.
5ad03b97 3969 (font_sort_entities): Mark var as initialized.
3ddb0639 3970
170a2692
PE
3971 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3972
e663c700
PE
3973 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3974 pointers to constants.
89bc529a 3975 (font_parse_fcname): Remove unused vars.
7b81e2d0 3976 (font_delete_unmatched): Now static.
ea838e10 3977 (font_get_spec): Remove; unused.
13a547c6
PE
3978 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3979 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3980 Rename or move locals to avoid shadowing.
e663c700 3981
2a80c887 3982 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3983 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3984
1384fa33 3985 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3986 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3987
8b2c52e9
PE
3988 * alloc.c (mark_backtrace): Move decl from here ...
3989 * lisp.h: ... to here, so that it can be checked.
3990
475545b5 3991 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3992 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3993 (lisp_indirect_variable): Name an expression,
3994 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3995 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3996
b1349114 3997 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3998 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3999 Use const pointer when appropriate.
b1349114 4000
a2928364
PE
4001 * lisp.h (get_system_name, get_operating_system_release):
4002 Move decls here, to check interfaces.
4003 * process.c (get_operating_system_release): Move decl to lisp.h.
4004 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4005 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4006 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4007 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4008 (Fformat_time_string, Fencode_time, Finsert_char):
4009 (Ftranslate_region_internal, Fformat):
4010 Rename or remove local vars to avoid shadowing.
9710023e 4011 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4012
a415e694
PE
4013 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4014 avoid shadowing.
4015
8ef4622d
PE
4016 * lisp.h (eassert): Check that the argument compiles, even if
4017 ENABLE_CHECKING is not defined.
4018
946f9a5b
PE
4019 * data.c (Findirect_variable): Name an expression, to avoid
4020 gcc -Wbad-function-cast warning.
112396d6 4021 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4022 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4023 (Fmake_variable_buffer_local, Fmake_local_variable):
4024 Mark variables as initialized.
52746918 4025 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4026
e5aab7e7 4027 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4028 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4029 Rename locals to avoid shadowing.
dff45157
PE
4030 (mark_stack): Move local variables into the #ifdef region where
4031 they're used.
7bc26fdb
PE
4032 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4033 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4034 needed otherwise.
4035 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4036 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4037 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4038
e5aab7e7
PE
4039 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4040 avoids undefined behavior in theory.
4041
4da60324
PE
4042 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4043
88043301
PE
4044 Use functions, not macros, for up- and down-casing (Bug#8254).
4045 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4046 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4047 to use the following functions instead of these macros.
4048 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4049 EMACS_INT, since callers assume the returned value fits in int.
4050 (upcase1): Likewise, for UPCASE_TABLE.
4051 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4052 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4053 the race-condition problem in the old DOWNCASE.
88043301 4054
19ed5445
PE
4055 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4056 Rename locals to avoid shadowing.
4057 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4058 (regex_compile, re_search_2, re_match_2_internal):
4059 Remove unused local vars.
952db0d7
PE
4060 (FREE_VAR): Rewrite so as not to use empty "else",
4061 which gcc can warn about.
da053e48 4062 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4063 (RETALLOC_IF): Define only if needed.
4064 (WORDCHAR_P): Likewise. This one is never needed, but is used
4065 only in a comment talking about a compiler bug, so put inside
4066 the #if 0 of that comment.
4067 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4068 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4069 Remove; unused.
19ed5445 4070
1f3561e4 4071 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4072 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4073 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4074
ded6f8f7
PE
4075 * search.c (simple_search): Remove unused var.
4076
dbd37a95
PE
4077 * dired.c (compile_pattern): Move decl from here ...
4078 * lisp.h: ... to here, so that it can be checked.
4079 (struct re_registers): New forward decl.
4080
7e47afad
PE
4081 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4082
85f24f61
PE
4083 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4084 All uses changed.
4085 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4086 Rename locals to avoid shadowing.
5671df8f 4087 (Fvertical_motion): Mark locals as initialized.
85f24f61 4088
181aa2be 4089 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4090 (casify_region): Mark local as initialized.
181aa2be 4091
930d429c
PE
4092 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4093
7082eac6
PE
4094 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4095 New macros, so that the caller can use some names other than
4096 gcpro1, gcpro2, etc.
4097 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4098 of the new macros.
4099 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4100 argument, for consistency with GCPRO2_VAR, etc: it is now the
4101 prefix of the variable, not the variable itself. All uses
4102 changed.
38b2c076
PE
4103 * dired.c (directory_files_internal, file_name_completion):
4104 Rename locals to avoid shadowing.
4105
15206ed9
PE
4106 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4107 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4108 dired.c's scmp function, had undefined behavior.
4109 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4110 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4111 * buffer.h: ... to here, because these macros use current_buffer,
4112 and the new implementation with inline functions needs to have
4113 current_buffer in scope now, rather than later when the macros
4114 are used.
4115 (downcase, upcase1): New static inline functions.
4116 (DOWNCASE, UPCASE1): Reimplement using these functions.
4117 This avoids undefined behavior in expressions like
4118 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4119 from race conditions in accessing the global variables
4120 case_temp1 and case_temp2.
4121 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4122 * lisp.h (case_temp1, case_temp2): Remove their decls.
4123 * character.h (ASCII_CHAR_P): Move from here ...
4124 * lisp.h: ... to here, so that the inline functions mentioned
4125 above can use them.
4126
4a6bea26
PE
4127 * dired.c (directory_files_internal_unwind): Now static.
4128
f14b7e14
PE
4129 * fileio.c (file_name_as_directory, directory_file_name):
4130 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4131 Now static.
2893f146
PE
4132 (file_name_as_directory): Use const pointers when appropriate.
4133 (Fexpand_file_name): Likewise. In particular, newdir might
4134 point at constant storage, so make it a const pointer.
fd4ead52 4135 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4136 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4137 signedness issues.
f839df0c
PE
4138 (Fset_file_times, Finsert_file_contents, auto_save_error):
4139 Rename locals to avoid shadowing.
f14b7e14 4140
5716756e 4141 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4142 (Ftry_completion, Fall_completions): Rename or remove locals
4143 to avoid shadowing.
5716756e 4144
b4c3046a
PE
4145 * marker.c (bytepos_to_charpos): Remove; unused.
4146
b45db522
PE
4147 * lisp.h (verify_bytepos, count_markers): New decls,
4148 so that gcc does not warn that these functions aren't declared.
4149
85876d07
PE
4150 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4151 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4152 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4153 (copy_text): Remove unused local var.
85876d07 4154
03d78a21 4155 * filelock.c (within_one_second): Now static.
b3dd38ab 4156 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4157
5df8f01b
PE
4158 * buffer.c (fix_overlays_before): Mark locals as initialized.
4159 (fix_start_end_in_overlays): Likewise. This function should be
4160 simplified by using pointers-to-pointers, but that's a different
4161 matter.
b1d876f1 4162 (switch_to_buffer_1): Now static.
8f54f30a
PE
4163 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4164 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4165
a70072c9 4166 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4167 Fix pointer signedness issue.
edced198
PE
4168 (sys_subshell): Mark local as volatile if checking for lint,
4169 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4170 (MAXPATHLEN): Define only if needed.
a70072c9 4171
a0977c44
PE
4172 * process.c (serial_open, serial_configure): Move decls from here ...
4173 * systty.h: ... to here, so that they can be checked.
4174
a884fdcc
PE
4175 * fns.c (get_random, seed_random): Move extern decls from here ...
4176 * lisp.h: ... to here, so that they can be checked.
4177
604efe86 4178 * sysdep.c (reset_io): Now static.
b8950c94 4179 (wait_for_termination_signal): Remove; unused.
604efe86 4180
38fc62d9
PE
4181 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4182 (copy_keymap_item, append_key, push_text_char_description):
4183 Now static.
1004a21a 4184 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4185 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4186 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4187 (describe_map_tree):
4188 Rename locals to avoid shadowing.
38fc62d9 4189
2f2650da
PE
4190 * keyboard.c: Declare functions static if they are not used elsewhere.
4191 (echo_char, echo_dash, cmd_error, top_level_2):
4192 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4193 (read_char, kbd_buffer_get_event, make_lispy_position):
4194 (make_lispy_event, make_lispy_movement, apply_modifiers):
4195 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4196 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4197 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4198 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4199 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4200
a053e86c 4201 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4202 (mark_kboards): Move decl here ...
4203 * alloc.c (mark_kboards): ... from here.
a053e86c 4204
4752793e
PE
4205 * lisp.h (force_auto_save_soon): New decl.
4206
74f10ca7 4207 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4208 (DEFINE_DUMMY_FUNCTION): New macro.
4209 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4210 Use it.
c03cd23f
PE
4211 (main): Add casts to avoid warnings
4212 if GCC considers string literals to be constants.
74f10ca7 4213
022e70d4
PE
4214 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4215
59d6fe83
PE
4216 * dbusbind.c: Pointer signedness fixes.
4217 (xd_signature, xd_append_arg, xd_initialize):
4218 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4219 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4220 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4221 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4222
78320123
PE
4223 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4224 if GCC considers string literals to be constants.
49cebcca 4225 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4226
35ac2a97
SM
42272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4228
fb103ca9
SM
4229 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4230 (print_preprocess, print_object): New macro to fix last change.
4231
35ac2a97
SM
4232 * print.c (print_preprocess): Don't forget font objects.
4233
62973b41
JB
42342011-03-16 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * emacs.c (USAGE3): Doc fixes.
4237
0e48bb22
AS
42382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4239
4240 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4241 structure.
4242
7684e57b
JB
42432011-03-14 Juanma Barranquero <lekktu@gmail.com>
4244
4245 * lisp.h (VWindow_system, Qfile_name_history):
4246 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4247 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4248 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4249
4250 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4251 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4252
4253 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4254 * w32console.c (detect_input_pending, read_input_pending)
4255 (encode_terminal_code):
4256 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4257 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4258 (w32_system_caret_y, Qfile_name_history):
4259 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4260 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4261 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4262 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4263 * w32proc.c (Qlocal, report_file_error):
4264 * w32term.c (Vwindow_system, updating_frame):
4265 * w32uniscribe.c (initialized, uniscribe_font_driver):
4266 Remove unneeded extern declarations.
4267
2aa46d6c
CY
42682011-03-14 Chong Yidong <cyd@stupidchicken.com>
4269
c96bbc66 4270 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4271
cffc6f3b
CY
42722011-03-13 Chong Yidong <cyd@stupidchicken.com>
4273
4274 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4275 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4276 These macros can no longer be used for assignment.
4277
44f230aa
SM
4278 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4279 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4280 (record_buffer_markers, fetch_buffer_markers): New functions for
4281 recording and fetching special buffer markers.
4282 (set_buffer_internal_1, set_buffer_temp): Use them.
4283
4284 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4285
4286 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4287
4288 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4289 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4290
4291 * xdisp.c (hscroll_window_tree):
4292 (reconsider_clip_changes): Use PT instead of BUF_PT.
4293
d251f04b
EZ
42942011-03-13 Eli Zaretskii <eliz@gnu.org>
4295
4296 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4297 $(EMACS_ROOT)/lib/intprops.h.
4298
f0c77cd1
PE
42992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4300
3eca4629
PE
4301 Fix more problems found by GCC 4.5.2's static checks.
4302
7c86ee98
PE
4303 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4304 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4305 (xg_free_frame_widgets): Make it clear that a local variable is
4306 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4307 (gdk_window_get_screen): Make it clear that this macro is needed
4308 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4309 (int_gtk_range_get_value): New function, which avoids a diagnostic
4310 from gcc -Wbad-function-cast.
4311 (xg_set_toolkit_scroll_bar_thumb): Use it.
4312 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4313 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4314 (get_utf8_string, xg_get_file_with_chooser):
4315 Rename locals to avoid shadowing.
4316 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4317
41729b81
PE
4318 * xgselect.c (xg_select): Remove unused var.
4319
f0c77cd1
PE
4320 * image.c (four_corners_best): Mark locals as initialized.
4321 (gif_load): Initialize transparent_p to zero (Bug#8238).
4322 Mark another local as initialized.
ec6cf4c6 4323 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4324
ce0ad53d 4325 * image.c (clear_image_cache): Now static.
d5d5a617 4326 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4327 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4328 (x_edge_detection): Remove unnecessary cast that
4329 gcc -Wbad-function-cast diagnoses.
2037898d 4330 (gif_load): Fix pointer signedness.
6ae141d6
PE
4331 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4332 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4333
33383987 43342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4335
d32df629
PE
4336 Improve quality of tests for time stamp overflow.
4337 For example, without this patch (encode-time 0 0 0 1 1
4338 1152921504606846976) returns the obviously-bogus value (-948597
4339 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4340 reports time overflow. See
4341 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4342 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4343 * editfns.c: Include limits.h and intprops.h.
4344 (TIME_T_MIN, TIME_T_MAX): New macros.
4345 (time_overflow): Move earlier, to before first use.
4346 (hi_time, lo_time): New functions, for an accurate test for
4347 out-of-range times.
4348 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4349 (Fget_internal_run_time): Don't assume time_t fits in int.
4350 (make_time): Use list2 instead of Fcons twice.
4351 (Fdecode_time): More accurate test for out-of-range times.
4352 (check_tm_member): New function.
4353 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4354 (lisp_time_argument): Don't rely on undefined left-shift and
4355 right-shift behavior when checking for time stamp overflow.
8be6f318 4356
fe31d94c
PE
4357 * editfns.c (time_overflow): New function, refactoring common code.
4358 (Fformat_time_string, Fdecode_time, Fencode_time):
4359 (Fcurrent_time_string): Use it.
4360
8be6f318
PE
4361 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4362 * dired.c (make_time): Move to ...
4363 * editfns.c (make_time): ... here.
4364 * systime.h: Note the move.
4365
09d9db2c 43662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4367
126bc0dc
YM
4368 * fringe.c (update_window_fringes): Remove unused variables.
4369
c47cbdfd
YM
4370 * unexmacosx.c (copy_data_segment): Also copy __got section.
4371 (Bug#8223)
4372
7ac80be9
EZ
43732011-03-12 Eli Zaretskii <eliz@gnu.org>
4374
c96bbc66 4375 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4376 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4377 Constify `char *' arguments and their references according to
4378 prototypes in tparam.h.
4379
ecb0f94d 4380 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4381
7ac80be9
EZ
4382 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4383 Adapt all references accordingly.
4384
4385 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4386
ef1fd07e
TT
43872011-03-11 Tom Tromey <tromey@redhat.com>
4388
4389 * buffer.c (syms_of_buffer): Remove obsolete comment.
4390
7ef4b50c
EZ
43912011-03-11 Eli Zaretskii <eliz@gnu.org>
4392
4393 * termhooks.h (encode_terminal_code): Declare prototype.
4394
4395 * msdos.c (encode_terminal_code): Don't declare prototype.
4396
4397 * term.c (encode_terminal_code): Now external again, used by
4398 w32console.c and msdos.c.
4399
44f230aa
SM
4400 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4401 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4402
4b1ec863 44032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4404
1714f52b 4405 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4406
4b1ec863
PE
4407 * fringe.c (update_window_fringes): Mark locals as initialized
4408 (Bug#8227).
4409 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4410
524c7aa6
PE
4411 * alloc.c (mark_fringe_data): Move decl from here ...
4412 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4413 to check its interface.
4414 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4415
a5c0af81 4416 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4417 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4418 (fontset_font): Mark local as initialized.
a9a06e0b 4419 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4420
b4716021
PE
4421 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4422
811e9bac 4423 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4424 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4425 (x_own_selection, Fx_disown_selection_internal): Rename locals
4426 to avoid shadowing.
4427 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4428
7e3ab302
PE
4429 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4430 so that the caller can use some name other than gcpro1.
4431 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4432 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4433 (Fx_backspace_delete_keys_p):
4434 Use them to avoid shadowing, and rename vars to avoid shadowing.
4435 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4436 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4437 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4438 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4439 Remove unused locals.
7e3ab302
PE
4440 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4441 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4442 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4443 macros.
f78faa98 4444
e2b13473
PE
4445 * xterm.h (x_mouse_leave): New decl.
4446
77f23912
PE
4447 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4448 Remove unused functions.
cdf4ba58
PE
4449 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4450 (x_calc_absolute_position): Now static.
7411c686 4451 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4452 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4453 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4454 unless they are used.
38d0b34a
PE
4455 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4456 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4457 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4458 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4459 (x_error_catcher, x_connection_closed, x_error_handler):
4460 (x_error_quitter, xembed_send_message, x_iconify_frame):
4461 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4462 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4463 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4464
44f230aa
SM
4465 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4466 Rename or move locals to avoid shadowing.
6b463e58 4467 (tty_defined_color, merge_face_heights): Now static.
5967d051 4468 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4469 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4470 does not deduce is never used uninitialized.
73719eba
PE
4471 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4472 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4473
426994c3 4474 * terminal.c (store_terminal_param): Now static.
5489860b 4475
032f1620 4476 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4477 (set_frame_menubar): Remove unused local.
d4323972 4478 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4479 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4480 since they might point to immutable storage.
281585b0
PE
4481 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4482 since it's unused otherwise.
032f1620 4483
367c19e5 4484 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4485 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4486 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4487 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4488 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4489 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4490 does not deduce are never used uninitialized.
70739cbe 4491
07b48fa9
PE
4492 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4493
8868a238 4494 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4495 * window.c (window_loop, size_window):
4496 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4497
7e5cf297 4498 * window.c (display_buffer): Now static.
d6550a9f
PE
4499 (size_window): Mark variables that gcc -Wuninitialized
4500 does not deduce are never used uninitialized.
a586633d
PE
4501 * window.h (check_all_windows): New decl, to forestall
4502 gcc -Wmissing-prototypes diagnostic.
5b555da1 4503 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4504
f6095868
PE
4505 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4506 shadowing.
4507 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4508 Include <limits.h>.
4509 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4510 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4511 (load_charset_map): Mark variables that gcc -Wuninitialized
4512 does not deduce are never used uninitialized.
53df7c11 4513 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4514
f38b440c
PE
4515 * coding.c (coding_set_source, coding_set_destination):
4516 Use "else { /* comment */ }" rather than "else /* comment */;"
4517 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4518 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4519 a block, when the outer 'i' will do.
4520 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4521 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4522 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4523 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4524 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4525 Rename locals to avoid shadowing.
4526 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4527 * coding.c (emacs_mule_char, encode_invocation_designation):
4528 Now static, since they're not used elsewhere.
413bb2db 4529 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4530 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4531 (decode_coding_emacs_mule): Mark variables that gcc
4532 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4533 (detect_coding_iso_2022): Initialize a local variable that might
4534 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4535 this initialization is needed. (Bug#8211)
5f58e762
PE
4536 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4537 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4538 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4539 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4540 Remove unused macros.
f38b440c 4541
232b38b9 4542 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4543 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4544 * character.c (string_count_byte8): Likewise.
232b38b9 4545
fb90da1b
PE
4546 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4547 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4548
fb93dbc2
PE
4549 * chartab.c (copy_sub_char_table): Now static, since it's not used
4550 elsewhere.
5c156ace
PE
4551 (sub_char_table_ref_and_range, char_table_ref_and_range):
4552 Rename locals to avoid shadowing.
bbcd0949 4553 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4554
7d3b3862 4555 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4556 (BIDI_BOB): Remove unused macro.
7d3b3862 4557
6be7d3da
PE
4558 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4559 deduce are never used uninitialized.
c2ed9c8b 4560 * term.c (encode_terminal_code): Likewise.
6be7d3da 4561
75f8807f 4562 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4563
50938595
PE
4564 * tparam.h: New file.
4565 * term.c, tparam.h: Include it.
4566 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4567 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4568 Move these decls to tparam.h, and make them agree with what
4569 is actually in tparam.c. The previous trick of using incompatible
4570 decls in different modules does not conform to the C standard.
4571 All callers of tparam changed to use tparam's actual API.
4572 * tparam.c (tparam1, tparam, tgoto):
4573 Use const pointers where appropriate.
4574
fbceeba2
PE
4575 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4576 * cm.h (struct cm): Likewise.
4577 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4578 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4579 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4580 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4581 (turn_on_face, init_tty): Likewise.
4582 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4583
7f3f1250
PE
4584 * term.c (term_mouse_position): Rename local to avoid shadowing.
4585
e6ca6543
PE
4586 * alloc.c (mark_ttys): Move decl from here ...
4587 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4588
c40f8d15
AS
45892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4590
4591 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4592
cfe0661d
JB
45932011-03-09 Juanma Barranquero <lekktu@gmail.com>
4594
4595 * search.c (compile_pattern_1): Remove argument regp, unused since
4596 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4597 (compile_pattern): Don't pass it.
4598
0afb4571
J
45992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4600
4601 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4602 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4603 for ! HAVE_GTK3.
4604 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4605
4606 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4607
4608 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4609 gdk_window_get_screen, gdk_window_get_geometry,
4610 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4611 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4612 (xg_get_pixbuf_from_pixmap): New function.
4613 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4614 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4615 Call xg_get_pixbuf_from_pixmap instead of
4616 gdk_pixbuf_get_from_drawable.
4617 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4618 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4619 (xg_check_special_colors): Use GtkStyleContext and its functions
4620 for HAVE_GTK3.
4621 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4622 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4623 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4624 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4625 Call gtk_widget_get_preferred_size.
0afb4571
J
4626 (xg_frame_resized): gdk_window_get_geometry only takes 5
4627 parameters.
44f230aa
SM
4628 (xg_win_to_widget, xg_event_is_for_menubar):
4629 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4630 (xg_set_widget_bg): New function.
4631 (delete_cb): New function.
895009e1 4632 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4633 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4634 (xg_set_background_color): Call xg_set_widget_bg.
4635 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4636 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4637 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4638 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4639 if ! HAVE_GTK3.
4640 (update_frame_tool_bar): Call gtk_widget_hide.
4641 (xg_initialize): Use GDK_KEY_g.
4642
4643 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4644 if ! HAVE_GTK3
4645 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4646
4647 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4648 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4649 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4650
1c2cc4ef
JB
46512011-03-08 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * w32xfns.c (select_palette): Check success of RealizePalette against
4654 GDI_ERROR, not zero.
4655
33383987 4656See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4657
4658;; Local Variables:
4659;; coding: utf-8
aac0c6e3
MR
4660;; End:
4661
33383987 4662 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4663
4664 This file is part of GNU Emacs.
4665
4666 GNU Emacs is free software: you can redistribute it and/or modify
4667 it under the terms of the GNU General Public License as published by
4668 the Free Software Foundation, either version 3 of the License, or
4669 (at your option) any later version.
4670
4671 GNU Emacs is distributed in the hope that it will be useful,
4672 but WITHOUT ANY WARRANTY; without even the implied warranty of
4673 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4674 GNU General Public License for more details.
4675
4676 You should have received a copy of the GNU General Public License
4677 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.