Better parallelism on MS-Windows for "make info".
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2a8ce227
JB
12012-04-10 Juanma Barranquero <lekktu@gmail.com>
2
3 * w32.c (w32_delayed_load): Record the full path of the library
4 being loaded (bug#10424).
5
935396c0
GM
62012-04-09 Glenn Morris <rgm@gnu.org>
7
05920a43
GM
8 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
9 not just in the obarray, before snarfing them. (Bug#11036)
10
935396c0
GM
11 * Makefile.in ($(leimdir)/leim-list.el):
12 Pass EMACS rather than BUILT_EMACS.
13
a18ecafa
TZ
142012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
15
16 * process.c (make_process):
17 * process.h: Add integer `gnutls_handshakes_tried' member to
18 process struct.
19
20 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit. Add
21 convenience `GNUTLS_LOG2i' macro.
22
23 * gnutls.c (gnutls_log_function2i): Convenience log function.
24 (emacs_gnutls_read): Use new log functions,
25 `gnutls_handshakes_tried' process member, and
26 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
27 attempts per process (connection).
28
b4d3bc10
CY
292012-04-09 Chong Yidong <cyd@gnu.org>
30
31 * eval.c (Fuser_variable_p, user_variable_p_eh)
32 (lisp_indirect_variable): Functions deleted.
33 (Fdefvar): Caller changed.
34
35 * callint.c (Finteractive, Fcall_interactively):
36 * minibuf.c (Fread_variable): Callers changed.
37
70f4d973
EZ
382012-04-09 Eli Zaretskii <eliz@gnu.org>
39
40 * xdisp.c (set_cursor_from_row): If the display string appears in
41 the buffer at position that is closer to point than the position
42 after the display string, display the cursor on the first glyph of
43 the display string. Fixes cursor display when a 'display' text
44 property immediately follows invisible text. (Bug#11094)
45
cb3c2e3e
PE
462012-04-09 Paul Eggert <eggert@cs.ucla.edu>
47
48 composite.c: use 'double' consistently
49 * composite.c (get_composition_id): Use 'double' consistently
50 instead of converting 'float' to 'double' and vice versa; this is
51 easier to understand and avoids a GCC warning.
52
fd06db5d
GM
532012-04-09 Glenn Morris <rgm@gnu.org>
54
50fe702a
GM
55 * Makefile.in: Generate leim-list with bootstrap-emacs, in
56 preparation for dumping it with emacs. (Bug#4789)
57 (leimdir): New variable.
58 ($(leimdir)/leim-list.el): New rule.
59 (emacs$(EXEEXT)): Depend on leim-list.el.
60
fd06db5d
GM
61 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
62 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
63 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
64
55c131ee
AS
652012-04-08 Andreas Schwab <schwab@linux-m68k.org>
66
67 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
68 proper alignment.
69
9209588f
JB
702012-04-07 Juanma Barranquero <lekktu@gmail.com>
71
72 * xml.c (init_libxml2_functions) [WINDOWSNT]:
73 Remove unused local variable.
74
e3fb2efb
PE
752012-04-07 Paul Eggert <eggert@cs.ucla.edu>
76
77 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
78 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
79 (mark_memory): Mark Lisp_Objects only if pointers might hide in
80 objects, as mark_maybe_pointer will catch them otherwise.
81 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
82 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
83
b5385551
PE
842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
85
86 Fix typo that broke non-Windows builds.
87 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
88
9078ead6
EZ
892012-04-07 Eli Zaretskii <eliz@gnu.org>
90
91 Support building on MS-Windows with libxml2.
92
93 * makefile.w32-in (OBJ2): Add xml.$(O).
94 (GLOBAL_SOURCES): Add xml.c.
95 ($(BLD)/xml.$(O)): New dependency list.
96
97 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
98 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
99 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
100 [!WINDOWSNT]: New macros.
101 (init_libxml2_functions, libxml2_loaded_p): New functions.
102 (parse_region): Call fn_xmlCheckVersion instead of using the macro
103 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
104 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
105 Calls xmlCleanupParser only if libxml2 was loaded (or statically
106 linked in).
107 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
108 init_libxml2_functions before calling libxml2 functions.
109 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
110
111 * emacs.c: Don't include libxml/parser.h.
112 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
113 xmlCleanupParser directly.
114
115 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
116
3811fdf3
EZ
1172012-04-07 Eli Zaretskii <eliz@gnu.org>
118
119 * indent.c (Fvertical_motion): If there is a display string at
120 point, use it.vpos to compute how many lines to backtrack after
121 move_it_to point. (Bug#11133)
122
2f8e16b2
EZ
1232012-04-06 Eli Zaretskii <eliz@gnu.org>
124
125 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
126 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
127 about subtle differences between FETCH_CHAR* and STRING_CHAR*
128 macros related to unification of CJK characters. For the details,
129 see the discussion following the message here:
130 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
131
3d439cd1
CY
1322012-04-04 Chong Yidong <cyd@gnu.org>
133
134 * keyboard.c (Vdelayed_warnings_list): Doc fix.
135
8bc53d00
EZ
1362012-04-01 Eli Zaretskii <eliz@gnu.org>
137
138 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
139 instead of alloca. (Bug#11138)
140
3b0512a3
AS
1412012-04-01 Andreas Schwab <schwab@linux-m68k.org>
142
143 * w32menu.c (is_simple_dialog): Properly check lisp types.
144 (Bug#11141)
145
8427ddd2
EZ
1462012-03-31 Eli Zaretskii <eliz@gnu.org>
147
979022ef
EZ
148 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
149 position we get to after a call to move_it_to fails the
150 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
151 only if we wind up in a string from display property. (Bug#11063)
152
a6b1c7cc
EZ
153 * window.c (Fdelete_other_windows_internal): Invalidate the row
154 and column information about mouse highlight, so that redisplay
155 restores it after reallocating the glyph matrices. (Bug#7464)
156
8427ddd2
EZ
157 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
158 string comes from a `display' text property, use the buffer
159 position of that property as if we actually saw that position in
160 the row's glyphs.
697ba24b
EZ
161 (move_it_by_lines): Remove the assertion that
162 "it->current_x == 0 && it->hpos == 0" which can be legitimately
163 violated when there's a before-string at the beginning of a line.
164 (Bug#11063)
8427ddd2 165
65a0a738
EZ
1662012-03-30 Eli Zaretskii <eliz@gnu.org>
167
168 * xdisp.c (append_space_for_newline): If the default face was
169 remapped, use the remapped face for the appended newline.
170 (extend_face_to_end_of_line): Use the remapped default face for
171 extending the face to the end of the line.
172 (display_line): Call extend_face_to_end_of_line when the default
173 face was remapped. (Bug#11068)
174
581355cc
EZ
1752012-03-29 Eli Zaretskii <eliz@gnu.org>
176
177 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
178
e8fc049f
SM
1792012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
180
181 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
182
4fb9a543
GM
1832012-03-27 Glenn Morris <rgm@gnu.org>
184
185 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
186 Doc fixes.
187
679910f1
KH
1882012-03-26 Kenichi Handa <handa@m17n.org>
189
190 * dispextern.h (struct glyph): Fix previous change. Change the
191 bit length of glyphless.ch to 25 (Bug#11082).
192
90d49b7f
CY
1932012-03-26 Chong Yidong <cyd@gnu.org>
194
195 * keyboard.c (Vselection_inhibit_update_commands): New variable.
196 (command_loop_1): Use it; inhibit selection update for
197 handle-select-window too (Bug#8996).
198
f514f6f0
FP
1992012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
200
e8fc049f 201 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 202
bf43fa51
KH
2032012-03-25 Kenichi Handa <handa@m17n.org>
204
205 * dispextern.h (struct glyph): Change the bit length of
206 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
207
8a0c01dd
EZ
2082012-03-24 Eli Zaretskii <eliz@gnu.org>
209
210 * s/ms-w32.h (tzname): Include time.h before redirecting to
211 _tzname. Fixes the MSVC build. (Bug#9960)
212
7d1c3a76
AS
2132012-03-24 Andreas Schwab <schwab@linux-m68k.org>
214
8ed79523
AS
215 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
216 characters.
217
7d1c3a76
AS
218 * xterm.c (XTread_socket): Only modify handling_signal if
219 !SYNC_INPUT. (Bug#11080)
220
e99a9b8b
EZ
2212012-03-23 Eli Zaretskii <eliz@gnu.org>
222
223 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
224 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
225 when fetching a multibyte character consumes more bytes than
226 CHAR_BYTES returns, due to unification of CJK characters in
227 string_char. (Bug#11073)
228
5063c0e1
TN
2292012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
230
231 * process.c (wait_reading_process_output): Handle pty disconnect
232 by refraining from sending oneself a SIGCHLD (bug#10933).
233
9f851fbd
CY
2342012-03-22 Chong Yidong <cyd@gnu.org>
235
236 * dispextern.h (struct it): New member string_from_prefix_prop_p.
237
5063c0e1 238 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
239 Mark string as coming from a prefix property.
240 (handle_face_prop): Use default face for prefix strings (Bug#4281).
241 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
242
fb5b8aca
CY
2432012-03-21 Chong Yidong <cyd@gnu.org>
244
245 * xfaces.c (Vface_remapping_alist): Doc fix.
246
62356a1b
EZ
2472012-03-20 Eli Zaretskii <eliz@gnu.org>
248
249 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
250 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
251 Doc fixes.
62356a1b 252
025de85b
CY
2532012-03-20 Chong Yidong <cyd@gnu.org>
254
255 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
256 to reflect default non-nil value of redisplay-dont-pause.
257
4827f94e
KH
2582012-03-19 Kenichi Handa <handa@m17n.org>
259
260 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
261 it fit in a valid range (Bug#11003).
262
e50a24a2
EZ
2632012-03-18 Eli Zaretskii <eliz@gnu.org>
264
265 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
266 that is not from display property, accept the row as a "cursor
267 row" if one of the string's character has a non-nil `cursor'
268 property. Fixes cursor positioning when there are newlines in
269 overlay strings, e.g. in icomplete.el. (Bug#11035)
270
9af5ed87
PE
2712012-03-12 Paul Eggert <eggert@cs.ucla.edu>
272
273 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
274
d1f55f16
CY
2752012-03-12 Chong Yidong <cyd@gnu.org>
276
277 * eval.c (inhibit_lisp_code): Rename from
278 inhibit_window_configuration_change_hook; move from window.c.
279
280 * xfns.c (unwind_create_frame_1, Fx_create_frame):
281 * window.c (run_window_configuration_change_hook)
282 (syms_of_window): Callers changed.
283
66c5eebd
CY
2842012-03-11 Chong Yidong <cyd@gnu.org>
285
413df973
CY
286 * keymap.c (Fkey_description): Doc fix (Bug#9700).
287
66c5eebd
CY
288 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
289
1de11f56
CY
2902012-03-10 Chong Yidong <cyd@gnu.org>
291
292 * frame.c (other_visible_frames): Don't assume the selected frame
293 is visible (Bug#10955).
294
cae07000
SM
2952012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
296
297 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
298
89c94350
JD
2992012-03-08 Jan Djärv <jan.h.d@swipnet.se>
300
301 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
302 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
303 zero (Bug#10954).
304
999dd333
GM
3052012-03-03 Glenn Morris <rgm@gnu.org>
306
01a6dcc8 307 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 308
de0100f2
EZ
3092012-03-02 Eli Zaretskii <eliz@gnu.org>
310
311 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
312 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
313 (redisplay_window, next_element_from_string): Fix typos in
314 comments.
3e441275
EZ
315 (redisplay_window): Pass to move_it_vertically the margin in
316 pixels, not in screen lines.
de0100f2 317
96a72ee9
GM
3182012-03-02 Glenn Morris <rgm@gnu.org>
319
320 * buffer.c (buffer-list-update-hook): Doc fix.
321
312508d7
EZ
3222012-02-29 Eli Zaretskii <eliz@gnu.org>
323
324 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
325 push_it before setting up the iterator for the first overlay
326 string, even if we have an empty string loaded.
327 (next_overlay_string): If there's an empty string on the iterator
328 stack, pop the stack. (Bug#10903)
329
27f3c637
PE
3302012-02-25 Paul Eggert <eggert@cs.ucla.edu>
331
332 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
333 Suggested by Stefan Monnier in
334 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
335 * alloc.c (widen_to_Lisp_Object): New static function.
336 (mark_memory): Also mark Lisp_Objects by fetching pointer words
337 and widening them to Lisp_Objects. This would work even if
338 USE_LSB_TAG is defined and wide integers are used, which might
339 happen in a future version of Emacs.
340
3c9dfce6
CY
3412012-02-25 Chong Yidong <cyd@gnu.org>
342
fa74b241
CY
343 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
344 Doc fix.
345
3c9dfce6
CY
346 * xselect.c (Fx_selection_exists_p): Doc fix.
347 (x_clipboard_manager_save_all): Print an informative message
348 before saving to clipboard manager.
349
9486df08
CY
3502012-02-24 Chong Yidong <cyd@gnu.org>
351
352 * keyboard.c (process_special_events): Handle all X selection
353 requests in kbd_buffer, not just the next one (Bug#8869).
354
f01d3321
CY
3552012-02-23 Chong Yidong <cyd@gnu.org>
356
357 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
358 call when setting menu-bar-lines and tool-bar-lines parameters.
359 (unwind_create_frame_1): New helper function.
360
361 * window.c (inhibit_window_configuration_change_hook): New var.
362 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 363 (syms_of_window): Initialize it.
f01d3321 364
86b847b6
CY
3652012-02-22 Chong Yidong <cyd@gnu.org>
366
367 * xterm.c (x_draw_image_relief): Add missing type check for
368 Vtool_bar_button_margin (Bug#10743).
369
a59225b1
CY
3702012-02-21 Chong Yidong <cyd@gnu.org>
371
372 * fileio.c (Vfile_name_handler_alist): Doc fix.
373
374 * buffer.c (Fget_file_buffer): Protect against invalid file
375 handler return value.
376
310f5bd4
PE
3772012-02-20 Paul Eggert <eggert@cs.ucla.edu>
378
cb3a28cc
PE
379 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
380 when computing $valmask.
381
310f5bd4
PE
382 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
383 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
384 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
385 It's useless in that case, and it can cause problems on hosts
386 that allocate halves of EMACS_INT values separately.
387 Reported by Dan Horák. Diagnosed by Andreas Schwab in
388 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
389 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
390 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
391 it avoids undefined behavior on hosts where shifting right by more
392 than the word width has undefined behavior.
393
2375c96a
CY
3942012-02-19 Chong Yidong <cyd@gnu.org>
395
396 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
397 (Funhandled_file_name_directory, Ffile_name_as_directory)
398 (Fdirectory_file_name, Fexpand_file_name)
399 (Fsubstitute_in_file_name): Protect against invalid file handler
400 return values (Bug#10845).
401
3eb49e71
EZ
4022012-02-18 Eli Zaretskii <eliz@gnu.org>
403
404 * .gdbinit (pitx): Fix incorrect references to fields of the
405 iterator stack.
406
7b926f3f
CY
4072012-02-17 Chong Yidong <cyd@gnu.org>
408
409 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
410
11273115
PE
4112012-02-15 Paul Eggert <eggert@cs.ucla.edu>
412
413 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
414 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
415
c3a70e2b
CY
4162012-02-15 Chong Yidong <cyd@gnu.org>
417
418 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
419 marked as special. Also, starting docstrings with * is obsolete.
420
0ca43699
AS
4212012-02-13 Andreas Schwab <schwab@linux-m68k.org>
422
423 * gnutls.c (emacs_gnutls_write): Fix last change.
424
2e8f3c56
LI
4252012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
426
427 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
428 send_process.
429
af70074f
SM
4302012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
431
432 * keymap.c (Fsingle_key_description): Handle char ranges.
433
95986d52
CY
4342012-02-12 Chong Yidong <cyd@gnu.org>
435
afd83bd1
CY
436 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
437 as that creates a dangerous corner case.
438
95986d52
CY
439 * window.c (Fdelete_window_internal): Invalidate the mouse
440 highlight (Bug#9904).
441
bd7da63e
GM
4422012-02-12 Glenn Morris <rgm@gnu.org>
443
444 * xselect.c (Fx_own_selection_internal)
445 (Fx_get_selection_internal, Fx_disown_selection_internal)
446 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
447 * nsselect.m (Fx_own_selection_internal)
448 (Fx_disown_selection_internal, Fx_selection_exists_p)
449 (Fx_selection_owner_p, Fx_get_selection_internal):
450 Sync docs and argument specs with the xselect.c versions.
451
77abcbc2
LI
4522012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
453
454 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
455
90b671e2
EZ
4562012-02-11 Eli Zaretskii <eliz@gnu.org>
457
1c0ca0b7
EZ
458 * w32select.c (Fx_selection_exists_p): Sync doc string and
459 argument list with xselect.c. (Bug#10783)
460
461 * w16select.c (Fx_selection_exists_p): Sync doc string and
462 argument list with xselect.c. (Bug#10783)
90b671e2 463
49241268
GM
4642012-02-10 Glenn Morris <rgm@gnu.org>
465
466 * fns.c (Fsecure_hash): Doc fix.
467
f998bbe7 4682012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
469
470 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
471
0992bd9c
CY
4722012-02-07 Chong Yidong <cyd@gnu.org>
473
474 * buffer.c (Fbuffer_local_variables)
475 (buffer_lisp_local_variables): Handle unbound vars correctly;
476 don't let Qunbound leak into Lisp.
477
af008560
GM
4782012-02-07 Glenn Morris <rgm@gnu.org>
479
dd605cc4
GM
480 * image.c (Fimagemagick_types): Doc fix.
481
af008560
GM
482 * image.c (imagemagick-render-type): Change it from a lisp object
483 to an integer. Move the doc here from the lisp manual.
484 Treat all values not equal to 0 the same.
485
1449fa1d
CY
4862012-02-06 Chong Yidong <cyd@gnu.org>
487
488 * doc.c (store_function_docstring): Avoid applying docstring of
489 alias to base function (Bug#2603).
490
3723ec07
AS
4912012-02-04 Andreas Schwab <schwab@linux-m68k.org>
492
493 * .gdbinit (pp1, pv1): Remove redundant defines.
494 (pr): Use pp.
495
79c1cc1e
CY
4962012-02-04 Chong Yidong <cyd@gnu.org>
497
498 * nsterm.m: Declare a global (Bug#10694).
499
d7f29f8e
EZ
5002012-02-04 Eli Zaretskii <eliz@gnu.org>
501
cae07000
SM
502 * w32.c (get_emacs_configuration_options):
503 Include --enable-checking, if specified, in the return value.
d7f29f8e 504
3b95a6f9
MR
5052012-02-04 Martin Rudalics <rudalics@gmx.at>
506
507 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
508 after rounding frame sizes. (Bug#9723)
509
d6fa96a6
EZ
5102012-02-04 Eli Zaretskii <eliz@gnu.org>
511
512 * keyboard.c (adjust_point_for_property): Don't position point
513 before BEGV. (Bug#10696)
514
df0b2940
PE
5152012-02-03 Paul Eggert <eggert@cs.ucla.edu>
516
517 Handle overflow when computing char display width (Bug#9496).
518 * character.c (char_width): Return EMACS_INT, not int.
519 (char_width, c_string_width): Check for overflow when
520 computing the width; this is possible now that individual
521 characters can have unbounded width. Problem introduced
522 by merge from Emacs 23 on 2012-01-19.
523
6bee44d6
MA
5242012-02-02 Michael Albinus <michael.albinus@gmx.de>
525
526 * dbusbind.c (Fdbus_register_method): Mention the return value
527 :ignore in the docstring.
528
44f92739
GM
5292012-02-02 Glenn Morris <rgm@gnu.org>
530
1b9f60cc
GM
531 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
532
44f92739
GM
533 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
534 Unconditionally set to t. (Bug#10673)
535 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
536 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
537 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
538
c5d3843c
KH
5392012-02-02 Kenichi Handa <handa@m17n.org>
540
541 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
542 0, do not call append_composite_glyph.
543
159462d4 5442012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
545
546 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
547 NULL (Bug#6988).
548 (x_produce_glyphs): If the component of a composition is a null
549 string, set it->pixel_width to 1 to avoid zero-width glyph.
550
78cef877
EZ
5512012-02-01 Eli Zaretskii <eliz@gnu.org>
552
553 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
554 first 2 arguments are identical. This makes inserting large
555 output from a subprocess an order of magnitude faster on
556 MS-Windows, where all sbrk'ed memory is always contiguous.
557
97897668
GM
5582012-01-31 Glenn Morris <rgm@gnu.org>
559
560 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 561 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
562 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
563
31fd3586
GM
5642012-01-29 Glenn Morris <rgm@gnu.org>
565
566 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
567
0e24a8b2
CY
5682012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
569
570 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
571
cc0adcb0
CY
5722012-01-28 Chong Yidong <cyd@gnu.org>
573
574 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
575
acc28cb9
CY
5762012-01-26 Chong Yidong <cyd@gnu.org>
577
9c69cfb7
CY
578 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
579
acc28cb9
CY
580 * search.c (Fsearch_forward, Fsearch_backward): Document negative
581 repeat counts (Bug#10507).
582
48da7392
GM
5832012-01-26 Glenn Morris <rgm@gnu.org>
584
585 * lread.c (syms_of_lread): Doc fix.
586
14af5f7f
CY
5872012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
588
589 * coding.c (encode_designation_at_bol): Change return value to
590 EMACS_INT.
591
0b21c100
CY
5922012-01-25 Chong Yidong <cyd@gnu.org>
593
594 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
595
3c2907f7
CY
5962012-01-21 Chong Yidong <cyd@gnu.org>
597
598 * floatfns.c (Fcopysign): Make the second argument non-optional,
599 since nil is not allowed anyway.
600
959ad23f
AS
6012012-01-21 Andreas Schwab <schwab@linux-m68k.org>
602
603 * process.c (read_process_output): Use p instead of XPROCESS (proc).
604 (send_process): Likewise.
605
34a02f46
MR
6062012-01-19 Martin Rudalics <rudalics@gmx.at>
607
608 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
609 (Vwindow_persistent_parameters): Do not use Qstate.
610 Rewrite doc-strings.
34a02f46 611
1259009a 6122012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
613
614 * character.c (char_width): New function.
70d4fdf6
GM
615 (Fchar_width, c_string_width, lisp_string_width):
616 Use char_width (Bug#9496).
25ed9e61 617
6a6ee00d
MR
6182012-01-16 Martin Rudalics <rudalics@gmx.at>
619
620 * window.c (Vwindow_persistent_parameters): New variable.
621 (Fset_window_configuration, save_window_save): Handle persistent
622 window parameters.
623
c85efaf7
EZ
6242012-01-14 Eli Zaretskii <eliz@gnu.org>
625
626 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
627 thrashing the stack of the thread. (Bug#9087)
628
5944709e
PE
6292012-01-12 Paul Eggert <eggert@cs.ucla.edu>
630
631 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
632
e71f5d99
EZ
6332012-01-11 Eli Zaretskii <eliz@gnu.org>
634
635 * xdisp.c (rows_from_pos_range): Handle the case where the
636 highlight ends on a newline. (Bug#10464)
637 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
638 he end column for display of highlight that ends on a newline
639 before a R2L line.
640
ce316182
GM
6412012-01-11 Glenn Morris <rgm@gnu.org>
642
643 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
644 from load-path also when installation-directory is nil. (Bug#10208)
645
5b43da69
GM
6462012-01-10 Glenn Morris <rgm@gnu.org>
647
74cc8ff9
GM
648 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
649
7d8d6e4e
GM
650 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
651 Update template values to be closer to their typical values these days.
5b43da69 652
a0db8d43
EZ
6532012-01-09 Eli Zaretskii <eliz@gnu.org>
654
655 * xdisp.c (rows_from_pos_range): Accept additional argument
656 DISP_STRING, and accept any glyph in a row whose object is that
657 string as eligible for mouse highlight. Fixes mouse highlight of
658 display strings from overlays. (Bug#10464)
659
9a0115ab 6602012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 661
b9110d6a 662 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
663 * fileio.c (auto_saving_dir_umask): New static var.
664 (Fmake_directory_internal): Use it.
665 (do_auto_save_make_dir): Set it, instead of invoking chmod after
666 creating the directory. The old code temporarily assigns
667 too-generous permissions to the directory.
668 (do_auto_save_eh): Clear it.
b9110d6a 669 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
670 that the var is always cleared.
671
6c1bd3f3
EZ
6722012-01-07 Eli Zaretskii <eliz@gnu.org>
673
674 * search.c (scan_buffer): Pass character positions to
675 know_region_cache, not byte positions. (Bug#6540)
676
069d2b50
L
6772012-01-07 LynX <_LynX@bk.ru> (tiny change)
678
679 * w32.c (sys_rename): Report EXDEV when rename of a directory
680 fails because the target is on another logical disk. (Bug#10284)
681
75bf0d33
DB
6822012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
683
684 * xterm.c (x_embed_request_focus): New function.
685
686 * xterm.h: Add prototype.
687
688 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
689
1c6e5a32
GM
6902012-01-05 Glenn Morris <rgm@gnu.org>
691
692 * emacs.c (emacs_copyright): Update short copyright year to 2012.
693
651e947e
EZ
6942012-01-01 Eli Zaretskii <eliz@gnu.org>
695
696 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
697 Load gnutls_transport_set_lowat only if GnuTLS version is below
698 2.11.1.
699 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
700 GnuTLS versions below 2.11.1.
701
3778cdd8
AL
7022011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
703
704 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
705 to the doc string advising against its use for altering the way
706 windows are scrolled.
707
0e5317f7
KH
7082011-12-28 Kenichi Handa <handa@m17n.org>
709
710 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
711 coding-system ASCII compatible only when it does not produce BOM
712 on encoding (Bug#10383).
713
93d5ca1f
JD
7142011-12-26 Jan Djärv <jan.h.d@swipnet.se>
715
716 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
717 can scroll.
718 (create_and_show_popup_menu): Always use menu_position_func for
719 Gtk3 (Bug#10361).
720
ca22b785
AS
7212011-12-24 Andreas Schwab <schwab@linux-m68k.org>
722
723 * callint.c (Fcall_interactively): Don't truncate prompt string.
724
d048e1e6
EZ
7252011-12-23 Eli Zaretskii <eliz@gnu.org>
726
727 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
728 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 729 resumed from there (after widening). (Bug#10360)
d048e1e6 730
5ccaba1f
JD
7312011-12-22 Jan Djärv <jan.h.d@swipnet.se>
732
733 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
734
204ee57f
JD
7352011-12-21 Jan Djärv <jan.h.d@swipnet.se>
736
b81d40f0
JB
737 * nsterm.m (x_free_frame_resources):
738 Release f->output_data.ns->miniimage.
204ee57f
JD
739 (ns_index_color): Fix indentation. Do not retain
740 color_table->colors[i].
741
742 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
743 before returning.
744
745 * nsfns.m (x_set_background_color): Assign return value from
746 ns_index_color to face-background instead of NSColor*.
747 (ns_implicitly_set_icon_type): Fix indentation.
748 Change assignment in for loop to comparison.
749
750 * emacs.c (ns_pool): New variable.
751 (main): Assign ns_pool.
752 (Fkill_emacs): Call ns_release_autorelease_pool.
753
754 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
755 autorelease fdesc, release fdAttrs and tdict.
756 (ns_get_covering_families): Release charset.
757 (ns_findfonts): Release NSFontDescriptor created with new.
758 (ns_uni_to_glyphs): Fix indentation.
759 (setString): Release attrStr before assigning new value.
760
c803b2b7
JD
7612011-12-18 Jan Djärv <jan.h.d@swipnet.se>
762
678f4426
JD
763 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
764 and NS_IMPL_COCOA.
765 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
766 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
767
cd394be1 7682011-12-18 David Reitter <reitter@cmu.edu>
678f4426 769
5fecd5fc
JD
770 * nsterm.m (ns_term_init): Subscribe for notifications
771 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
772 to method trackingNotification in EmacsMenu.
773
774 * nsmenu.m (trackingMenu): New variable.
3771cb17 775 (trackingNotification): New method (from Aquamacs).
5fecd5fc 776 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 777 from Aquamacs (Bug#7030).
678f4426
JD
778
7792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 780
c803b2b7
JD
781 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
782 (symbol_to_nsstring): Fix indentation.
783 (ns_symbol_to_pb): New function.
cae07000
SM
784 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
785 (Fns_rotate_cut_buffers_internal): Remove.
786 (Fns_store_selection_internal): Rename from
c803b2b7
JD
787 Fns_store_cut_buffer_internal.
788 (ns_get_foreign_selection, Fx_own_selection_internal)
789 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
790 (Fns_get_selection_internal, Fns_store_selection_internal):
791 Use ns_symbol_to_pb and check if return value is nil.
792 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
793 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
794 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
795 renamed to Sns_store_selection_internal.
796 (ns_handle_selection_request): Move code to Fx_own_selection_internal
797 and remove this function.
798 (ns_handle_selection_clear): Remove, never used.
799 (Fx_own_selection_internal): Move code from ns_handle_selection_request
800 here.
801
e1b01a3a
KB
8022011-12-17 Ken Brown <kbrown@cornell.edu>
803
804 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
805 GID is unknown (Bug#10257).
806
2adb6e85
PE
8072011-12-17 Paul Eggert <eggert@cs.ucla.edu>
808
809 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
810 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
811 which caused a build failure on GNU/Linux IA-64. This problem was
812 introduced by my 2011-10-07 patch.
813
d1d7b339
JL
8142011-12-15 Juri Linkov <juri@jurta.org>
815
816 * image.c (imagemagick_error): New function. (Bug#10112)
817 (imagemagick_load_image): Comment out `MagickSetResolution' call.
818 Use `imagemagick_error' where ImageMagick functions return
819 `MagickFalse'.
820 (Fimagemagick_types): Add `Fnreverse' to return the list in the
821 proper order.
822
100d5755
KH
8232011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
824
825 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
826 fill background (Bug#8992).
827
454592a6
MR
8282011-12-13 Martin Rudalics <rudalics@gmx.at>
829
830 * window.c (Vwindow_combination_resize)
831 (Vwindow_combination_limit): Use t instead of non-nil in
832 doc-strings.
61d4b438
MR
833 (Vrecenter_redisplay): Add first sentence of doc-string on
834 separate line.
53524d93 835 (Frecenter): Fix doc-string typo.
454592a6 836
3633e3aa
KH
8372011-12-11 Kenichi Handa <handa@m17n.org>
838
839 * coding.c (Funencodable_char_position): Pay attention to the
840 buffer text relocation (Bug#9389).
841
7b9d523a
JD
8422011-12-10 Jan Djärv <jan.h.d@swipnet.se>
843
844 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
845 gtk_init (Bug#10100).
846
b73189c6
EZ
8472011-12-10 Eli Zaretskii <eliz@gnu.org>
848
849 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
850 IT->string is nil. (Bug#10263)
851
f7dfe5d6
JD
8522011-12-10 Jan Djärv <jan.h.d@swipnet.se>
853
83faebb4
JD
854 * nsterm.h (x_free_frame_resources): Declare.
855
f7dfe5d6
JD
856 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
857 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
858
859 * nsterm.h (ns_get_defaults_value): Declare.
860
861 * nsterm.m (ns_default): Call ns_get_defaults_value.
862
7cd4e72c
EZ
8632011-12-09 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
866 (Bug#10170)
867
b34d7317
YM
8682011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
869
870 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
871 that where the value of an _OBJC_* symbol points to is in the .bss
872 section (Bug#10240).
873
76470ad1
KH
8742011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
875
876 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 877 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 878
745fff94
KH
8792011-12-08 Kenichi Handa <handa@m17n.org>
880
881 * ftfont.c (get_adstyle_property): Fix previous change
882 (Bug#10233).
883
6e44397c
JB
8842011-12-07 Juanma Barranquero <lekktu@gmail.com>
885
886 * w32.c (init_environment): If no_site_lisp, remove site-lisp
887 dirs from the default value of EMACSLOADPATH (bug#10208).
888
7efa6272
GM
8892011-12-07 Glenn Morris <rgm@gnu.org>
890
891 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
892 installation and source directories as well. (Bug#10208)
893
f6fc4d87
CY
8942011-12-06 Chong Yidong <cyd@gnu.org>
895
896 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
897
2bf26180
GM
8982011-12-06 Glenn Morris <rgm@gnu.org>
899
900 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
901 as an error, not just -1. (Bug#10217)
902
3a6ad4f0
CY
9032011-12-05 Chong Yidong <cyd@gnu.org>
904
905 * keyboard.c (process_special_events): New function.
906 (swallow_events, Finput_pending_p): Use it (Bug#10195).
907
75a3b399
PE
9082011-12-05 Paul Eggert <eggert@cs.ucla.edu>
909
910 * coding.c (encode_designation_at_bol): Don't use uninitialized
911 local variable (Bug#9318).
912
c3c9e25e
KH
9132011-12-05 Kenichi Handa <handa@m17n.org>
914
915 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
916 return Qnil (Bug#8046, Bug#10193).
917
5eb05ea3
KH
9182011-12-05 Kenichi Handa <handa@m17n.org>
919
920 * coding.c (encode_designation_at_bol): New args charbuf_end and
921 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
922 (coding_set_source): Return how many bytes coding->source was
923 relocated.
924 (coding_set_destination): Return how many bytes
925 coding->destination was relocated.
926 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 927 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
928
9292011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
930
931 * coding.c (CODING_CHAR_CHARSET_P): New macro.
932 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
933 macro (Bug#9318).
934
9352011-12-05 Andreas Schwab <schwab@linux-m68k.org>
936
937 The following changes are to fix Bug#9318.
938
a79703f5 939 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
940 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
941 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 942 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 943
7dbda6df
JB
9442011-12-05 Juanma Barranquero <lekktu@gmail.com>
945
946 * lisp.h (process_quit_flag): Fix external declaration.
947
6d5eb5b0
SM
9482011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
949
950 Don't macro-inline non-performance-critical code.
951 * eval.c (process_quit_flag): New function.
952 * lisp.h (QUIT): Use it.
953
a0c3fad0
JD
9542011-12-04 Jan Djärv <jan.h.d@swipnet.se>
955
956 * nsfns.m (get_geometry_from_preferences): New function.
957 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
958
6c07aac2
AS
9592011-12-04 Andreas Schwab <schwab@linux-m68k.org>
960
961 * emacs.c (Qkill_emacs): Define.
962 (syms_of_emacs): Initialize it.
963 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
964 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
965 (quit_throw_to_read_char): Add parameter `from_signal'.
966 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
967 * lisp.h (QUIT): Call Fkill_emacs if requested.
968
c052ead4
JD
9692011-12-03 Jan Djärv <jan.h.d@swipnet.se>
970
971 * widget.c (update_wm_hints): Return if wmshell is null.
972 (widget_update_wm_size_hints): New function.
973
974 * widget.h (widget_update_wm_size_hints): Declare.
975
976 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
977 widget_update_wm_size_hints (Bug#10104).
978
9e49252b
EZ
9792011-12-03 Eli Zaretskii <eliz@gnu.org>
980
981 * xdisp.c (handle_invisible_prop): If the invisible text ends just
982 before a newline, prepare the bidi iterator for consuming the
983 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 984 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 985
02b16839
JL
9862011-12-02 Juri Linkov <juri@jurta.org>
987
988 * search.c (Fword_search_regexp): New Lisp function created from
989 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
990 (Fword_search_backward, Fword_search_forward)
991 (Fword_search_backward_lax, Fword_search_forward_lax):
992 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
993 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
994
0068070e
SM
9952011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
996
997 * fileio.c (Finsert_file_contents): Move after-change-function call
998 to before the "handled:" label, since all "goto handled" appear in
999 cases where the *-change-functions have already been properly called
1000 (bug#10117).
1001
3360a3fc
AS
10022011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1003
1004 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1005 waiting for input. (Bug#10169)
1006
73d6c093
EZ
10072011-11-30 Eli Zaretskii <eliz@gnu.org>
1008
1009 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1010 verifies glyph row's hash code--we have just reallocated the
1011 glyphs, so their contents can be complete garbage. (Bug#10164)
1012
febe6bea
JB
10132011-11-30 Juanma Barranquero <lekktu@gmail.com>
1014
1015 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1016
801a4313
EZ
10172011-11-30 Eli Zaretskii <eliz@gnu.org>
1018
1019 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1020 attributes are tested _before_ calling verify_row_hash, to protect
1021 against GCC re-ordering of the tests. (Bug#10164)
1022
2b56b87e
JD
10232011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1024
1025 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1026
1027 * xterm.c (handle_one_xevent): Only set async_visible and friends
1028 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1029 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1030 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1031
dbf31225
PE
10322011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1035 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1036 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1037 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1038 All uses changed to use GCPRO1 etc.
1039 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1040 Revert to old implementation (i.e., before 2011-03-11).
1041
1305621b
YM
10422011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1043
1044 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1045 of scroll runs so as to avoid assigning disabled bogus rows and
1046 unnecessary graphics copy operations.
1047
8c9afb46
EZ
10482011-11-27 Eli Zaretskii <eliz@gnu.org>
1049
1050 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1051 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1052 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1053 (malloc, free, realloc, calloc): Redirect to e_* only when
1054 compiling Emacs.
1055
1056 * lisp.h (GCTYPEBITS): Move before first use.
1057 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1058 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1059 this macro definition.
1060
1061 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1062 _MSC_VER.
1063
54e9e3bf
JD
10642011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1065
6d5eb5b0
SM
1066 * gtkutil.c (xg_create_frame_widgets):
1067 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1068 present with Gtk+ 2.0.
1069
83aca1cb
PE
10702011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 * fileio.c (Finsert_file_contents): Undo previous change; see
1073 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1074
5b76caa4
PE
10752011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 Rename locals to avoid shadowing.
1078 * fileio.c (Finsert_file_contents):
1079 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1080 * process.c (wait_reading_process_output):
1081 Rename inner 'proc' to 'p' to avoid shadowing.
1082 Indent for consistency with usual Emacs style.
1083
8c535114
EZ
10842011-11-25 Eli Zaretskii <eliz@gnu.org>
1085
1086 * xdisp.c (redisplay_window): If cursor row is not fully visible
1087 after recentering, and scroll-conservatively is set to a large
1088 number, scroll window by a few more lines to make the cursor fully
1089 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1090 (start_display): Don't move to the next line if the display should
1091 start at a newline that is part of a display vector or an overlay
1092 string. (Bug#10119)
8c535114 1093
fa4fdb5c
JL
10942011-11-24 Juri Linkov <juri@jurta.org>
1095
1096 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1097 after the `MagickPingImage' call. (Bug#10112)
1098
90ec88df
CY
10992011-11-23 Chong Yidong <cyd@gnu.org>
1100
1101 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1102
56e2e794
MR
11032011-11-23 Martin Rudalics <rudalics@gmx.at>
1104
1105 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1106 making another buffer current. (Bug#10114)
1107
b6e64c41
GM
11082011-11-23 Glenn Morris <rgm@gnu.org>
1109
1110 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1111
6b21de18
CY
11122011-11-23 Chong Yidong <cyd@gnu.org>
1113
1114 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1115 using it (Bug#5984).
1116
b12cd789
EZ
11172011-11-22 Eli Zaretskii <eliz@gnu.org>
1118
1119 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1120 and header-lines, as they don't have one computed for them.
1121 (Bug#10098)
1122
1123 * .gdbinit (prow): Make displayed values more self-explaining.
1124 Add row's hash code.
1125
261b6fd4
LMI
11262011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1127
1128 * process.c (wait_reading_process_output): Fix asynchrounous
1129 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1130 (wait_reading_process_output): Add comment and URL.
261b6fd4 1131
e7cfd277
JD
11322011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1135
a9b9b7f5
CY
11362011-11-21 Chong Yidong <cyd@gnu.org>
1137
1138 * window.c (Fnext_window, Fprevious_window): Doc fix.
1139
b0d15b4f
SM
11402011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1141
1142 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1143
fe7a3057
JB
11442011-11-20 Juanma Barranquero <lekktu@gmail.com>
1145
1146 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1147
d2999b1a
MR
11482011-11-20 Martin Rudalics <rudalics@gmx.at>
1149
1150 * window.c (Fset_window_combination_limit): Rename argument
1151 STATUS to LIMIT.
1152 (Vwindow_combination_limit): Remove "status" from doc-string.
1153
d5ff9cd0
AS
11542011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1155
1156 * m/ibms390.h: Remove.
1157 * m/ibms390x.h: Don't include "ibms390.h".
1158
a5bb9bd3
SM
11592011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1160
1161 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1162 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1163
cd1181db
JB
11642011-11-20 Juanma Barranquero <lekktu@gmail.com>
1165
1166 * casetab.c (Fset_case_table):
1167 * charset.c (Fcharset_after): Fix typos.
1168
615a3b8d 11692011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1170
17e845af
PE
1171 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1172 Otherwise, valgrind does not work on some platforms.
1173 Problem reported by Andreas Schwab in
6a0bf43d
PE
1174 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1175 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1176 is set, removing the need for VIRT_ADDRESS_VARIES.
1177 (PURE_P): Use a more-efficient implementation that needs just one
1178 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1179 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1180 to 4 (xorl, subq, cmpq, setbe).
1181 * alloc.c (pure): Always extern now, since that's the
1182 VIRT_ADDR_VARIES behavior.
1183 (PURE_POINTER_P): Use a single comparison, not two, for
1184 consistency with the new puresize.h.
1185 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1186 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1187 Remove VIRT_ADDR_VARIES no longer needed.
1188
f8fe6f96
EZ
11892011-11-19 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1192 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1193 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1194 behave as if the cursor position were at the window margin.
1195
1196 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1197 and the cursor position is out of bounds, behave as if the cursor
1198 position were at the window margin. (Bug#10075)
1199
df05a53c
CY
12002011-11-18 Chong Yidong <cyd@gnu.org>
1201
1202 * window.c (Fwindow_combination_limit): Make first argument
1203 non-optional, since it is meaningless for live windows like the
1204 selected window.
1205
2071918e
DA
12062011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1207
1208 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1209
b50a28de
SM
12102011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1211
1212 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1213 (graft_intervals_into_buffer): Simplify.
1214
015137db
EZ
12152011-11-18 Eli Zaretskii <eliz@gnu.org>
1216
1217 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1218 hash values of the two rows.
1219 (copy_row_except_pointers): Preserve the used[] arrays and the
1220 hash values of the two rows. (Bug#10035)
68c95424 1221 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1222
1223 * xdisp.c (row_hash): New function, body extracted from
1224 compute_line_metrics.
1225 (compute_line_metrics): Call row_hash, instead of computing the
1226 hash code inline.
1227
1228 * dispnew.c (verify_row_hash): Call row_hash for computing the
1229 hash code of a row, instead of duplicating code from xdisp.c.
1230
1231 * dispextern.h (row_hash): Add prototype.
1232
a2addb04
TH
12332011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1234
1235 * frame.c (delete_frame): Don't delete the terminal when the last
1236 X frame is closed if emacs is built with GTK toolkit.
1237
df85d315
JB
12382011-11-17 Juanma Barranquero <lekktu@gmail.com>
1239
1240 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1241
a0c2d0ae
MR
12422011-11-17 Martin Rudalics <rudalics@gmx.at>
1243
1244 * window.c (Vwindow_splits): Rename to
1245 Vwindow_combination_resize. Suggested by Juri Linkov.
1246 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1247 of Vwindow_splits.
1248
58179cce
JB
12492011-11-16 Juanma Barranquero <lekktu@gmail.com>
1250
7877f373
JB
1251 * nsfns.m (Fns_font_name):
1252 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1253
b6f67890
MR
12542011-11-16 Martin Rudalics <rudalics@gmx.at>
1255
1256 * window.h (window): Rename slot "nest" to "combination_limit".
1257 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1258 (Fset_window_nest): Rename to Fset_window_combination_limit.
1259 (Vwindow_nest): Rename to Vwindow_combination_limit.
1260 (recombine_windows, make_parent_window, make_window)
1261 (Fsplit_window_internal, saved_window)
1262 (Fset_window_configuration, save_window_save): Rename all
1263 occurrences of window_nest to window_combination_limit.
1264
c7015153
JB
12652011-11-15 Juanma Barranquero <lekktu@gmail.com>
1266
1267 * image.c (imagemagick_load_image): Fix typo.
1268
322ad6ec
EZ
12692011-11-14 Eli Zaretskii <eliz@gnu.org>
1270
1271 * xdisp.c (display_line): Move the call to
1272 highlight_trailing_whitespace before the call to
1273 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1274 faces of all the glyphs to compute ROW's hash value.
1275 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1276
f067b8ec
JB
12772011-11-14 Juanma Barranquero <lekktu@gmail.com>
1278
1279 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1280 just return (bug#10044).
1281
1e5b2111
EZ
12822011-11-12 Eli Zaretskii <eliz@gnu.org>
1283
7ef3cbd5
EZ
1284 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1285 with user-defined heap size. Bump the default size of the temacs
1286 heap to 27MB, to avoid memory warning when running temacs.
1287 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1288
1e5b2111
EZ
1289 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1290 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1291 (verify_row_hash) [XASSERTS]: New function.
1292 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1293 that the hash value of glyph rows is correct.
1e5b2111 1294
89d61221
MR
12952011-11-12 Martin Rudalics <rudalics@gmx.at>
1296
1297 * window.h (window): Remove splits slot.
1298 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1299 (Fdelete_other_windows_internal, make_parent_window)
1300 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1301 (Fset_window_configuration, save_window_save): Don't deal with
1302 split status of windows.
1303 (saved_window): Remove splits slot.
1304 (Vwindow_splits): Rewrite doc-string.
1305
97f18cc8
JD
13062011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1307
1308 * xfns.c (unwind_create_frame):
1309 * nsfns.m (unwind_create_frame):
1310 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1311 Vframe_list (Bug#9999).
1312
22a648b4
DA
13132011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1314
0b381c7e 1315 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1316
659afede
KH
13172011-11-11 Kenichi Handa <handa@m17n.org>
1318
1319 * callproc.c (Fcall_process): Set the member dst_multibyte of
1320 process_coding.
1321
9ac0394b
KH
13222011-11-11 Johan Bockgård <bojohan@gnu.org>
1323
1324 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1325 avoid a crash (bug#9496).
1326
2fbdc249
CY
13272011-11-09 Chong Yidong <cyd@gnu.org>
1328
1329 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1330 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1331
ac6b1f81
PE
13322011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1335
09db192c
PE
13362011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 Avoid some portability problems by eschewing 'extern inline' functions.
1339 The trivial performance wins aren't worth the portability hassles; see
1340 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1341 et seq.
1342 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1343 (window_box_width, window_box_left, window_box_left_offset)
1344 (window_box_right, window_box_right_offset): Undo previous change,
1345 by removing the "extern"s.
1346 * intervals.c (adjust_intervals_for_insertion)
1347 (adjust_intervals_for_deletion): Undo previous change,
1348 making these static again.
1349 (offset_intervals, temp_set_point_both, temp_set_point)
1350 (copy_intervals_to_string): No longer inline.
1351 * xdisp.c (window_text_bottom_y, window_box_width)
1352 (window_box_height, window_box_left_offset)
1353 (window_box_right_offset, window_box_left, window_box_right)
1354 (window_box): No longer inline.
1355
105216ed
CY
13562011-11-08 Chong Yidong <cyd@gnu.org>
1357
1358 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1359 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1360 Signal an error if not a live window.
105216ed
CY
1361 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1362 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1363
ae9e237f
JB
13642011-11-07 Juanma Barranquero <lekktu@gmail.com>
1365
1366 * lisp.h (syms_of_abbrev): Remove declaration.
1367 Reported by CHENG Gao <chenggao@royau.me>.
1368
c7aa8333
EZ
13692011-11-07 Eli Zaretskii <eliz@gnu.org>
1370
1371 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1372 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1373 of temacs in GUI mode.
1374
be7f5545
MR
13752011-11-07 Martin Rudalics <rudalics@gmx.at>
1376
1377 * window.h: Declare delete_all_child_windows instead of
1378 delete_all_subwindows.
1379 * window.c (Fwindow_nest, Fset_window_nest)
1380 (Fset_window_new_total, Fset_window_new_normal)
1381 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1382 (delete_all_subwindows): Rename to delete_all_child_windows.
1383 (Fdelete_other_windows_internal, Fset_window_configuration):
1384 Call delete_all_child_windows instead of delete_all_subwindows.
1385 * frame.c (delete_frame): Call delete_all_child_windows instead
1386 of delete_all_subwindows.
1387
ca78dc43
PE
13882011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1391 This is also needed for porting to any host where GC_MARK_STACK is
1392 not GC_MAKE_GCPROS_NOOPS.
1393 (which_symbols): Use it.
1394
a0241d01
KH
13952011-11-07 Kenichi Handa <handa@m17n.org>
1396
1397 * coding.c (coding_set_destination): Check coding->src_pos only
1398 when coding->src_object is a buffer (bug#9910).
1399
1400 * process.c (send_process): Set the member src_multibyte of coding
1401 to 0 (bug#9911) when sending a unibyte text.
1402
1403 * callproc.c (Fcall_process): Set the member src_multibyte of
1404 process_coding to 0 (bug#9912).
1405
a64bfdfa 14062011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1407
1408 * xmenu.c (cleanup_widget_value_tree): New function.
1409 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1410 calling free_menubar_widget_value_tree directly (Bug#9830).
1411
cb41b32a
PE
14122011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 Fix some portability problems with 'inline'.
1415 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1416 (window_box_width, window_box_left, window_box_left_offset)
1417 (window_box_right, window_box_right_offset): Declare extern.
1418 Otherwise, these inline functions do not conform to C99 and
1419 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1420 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1421 * intervals.c (adjust_intervals_for_insertion)
1422 (adjust_intervals_for_deletion): Now extern, because otherwise the
1423 extern inline functions 'offset_intervals' couldn't refer to it.
1424 (static_offset_intervals): Remove.
1425 (offset_intervals): Rewrite using the old contents of
1426 static_offset_intervals. The old version didn't conform to C99
1427 because an extern inline function contained a reference to an
1428 identifier with static linkage.
1429
b7041366
AS
14302011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1431
1432 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1433 GC.
1434
88a37c4d
EZ
14352011-11-06 Eli Zaretskii <eliz@gnu.org>
1436
1437 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1438 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1439 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1440 return Qleft_to_right.
1441
49745b39
CY
14422011-11-06 Chong Yidong <cyd@gnu.org>
1443
1444 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1445 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1446 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1447 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1448 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1449 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1450 (Fwindow_vscroll): Doc fix.
1451 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1452 argument, since it makes no sense to pass a live window and for
1453 consistency with window-child.
1454
1f05cd82
CS
14552011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1456
1457 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1458 support MSVC.
1459
22610910
JR
14602011-11-05 Jason Rumney <jasonr@gnu.org>
1461
1462 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1463 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1464 fonts (Bug#6029).
1465 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1466 bitwise arithmetic preventing use of unicode-sip and non-truetype
1467 opentype fonts.
1468
a06776b2
EZ
14692011-11-05 Eli Zaretskii <eliz@gnu.org>
1470
3ad924ba
EZ
1471 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1472 "emacs"-only part.
1473
a06776b2
EZ
1474 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1475 initialization code to keep similarity to xfns.c after changes
1476 from 2011-11-05.
1477
c9e7db78
JD
14782011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1479
a97f8f3f
JD
1480 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1481 (unwind_create_frame): New function (Bug#9943).
1482 (Fx_create_frame): Restructure code to be more similar to the one in
1483 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1484 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1485 Move terminal->reference_count++ just before making the frame official
1486 (Bug#9943).
1487
1488 * nsterm.m (x_free_frame_resources): New function.
1489 (x_destroy_window): Move code to x_free_frame_resources.
1490
c9e7db78 1491 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1492 (Fx_create_frame, x_create_tip_frame):
1493 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1494 official. Move initialization of image_cache_refcount and
1495 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1496
a6fc3b5c
EZ
14972011-11-05 Eli Zaretskii <eliz@gnu.org>
1498
1499 Support MSVC build with newer versions of Visual Studio.
1500 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1501 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1502 nt/gmake.defs.
1503
1504 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1505 which are not supported by MSVC.
1506 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1507 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1508 bitfields.
1509 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1510 types in bitfields.
1511 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1512
1513 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1514
58179cce 15152011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1516
1517 Support MSVC build with newer versions of Visual Studio.
1518 * w32.c: Don't include w32api.h for MSVC.
1519 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1520
1521 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1522 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1523 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1524 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1525 e_* cousins.
1526 (alloca) [_MSC_VER]: Define to _alloca.
1527
1528 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1529
1530 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1531
a58c13ed
EZ
15322011-11-04 Eli Zaretskii <eliz@gnu.org>
1533
1534 * xdisp.c (note_mouse_highlight): If either of
1535 previous/next-single-property-change returns nil, treat that as
1536 the beginning or the end of the buffer. (Bug#9955)
1537
fe0b6370
JD
15382011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1539
a58c13ed 1540 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1541 label is not null (Bug#9951).
1542 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1543 may be NULL.
1544
89bd5ee1
EZ
15452011-11-04 Eli Zaretskii <eliz@gnu.org>
1546
1547 * window.c (Fwindow_body_size): Mention in the doc string that the
1548 return value is in frame's canonical units. (Bug#9949)
1549
84c3edb9
EZ
15502011-11-03 Eli Zaretskii <eliz@gnu.org>
1551
4e2fb5c7
EZ
1552 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1553
84c3edb9 1554 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1555 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1556 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1557
bc17a887
EZ
15582011-11-01 Eli Zaretskii <eliz@gnu.org>
1559
1560 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1561 Don't stop backward scan on the continuation glyph, even though
1562 its CHARPOS is positive.
6d5eb5b0
SM
1563 (mouse_face_from_buffer_pos, note_mouse_highlight):
1564 Rename cover_string to disp_string.
bc17a887 1565
4ee88440
MR
15662011-11-01 Martin Rudalics <rudalics@gmx.at>
1567
1568 * window.c (temp_output_buffer_show): Don't use
1569 Vtemp_buffer_show_specifiers.
1570 (Vtemp_buffer_show_specifiers): Remove unused variable.
1571
c2ff3c02
EZ
15722011-10-30 Eli Zaretskii <eliz@gnu.org>
1573
1574 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1575 past the beginning of the current glyph matrix.
1576
58179cce 15772011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1578
1579 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1580 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1581 HAVE_GTK3 (Bug#9869).
b77a6a7f 1582
3b574623
JD
1583 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1584 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1585
b77a6a7f
JD
1586 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1587
1588 * xterm.c: Declare x_handle_net_wm_state to return int.
1589 (handle_one_xevent): Check if we are iconified but don't have
1590 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1591 (get_current_wm_state): Return non-zero if not hidden,
1592 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1593 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1594 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1595 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1596
196e41e4
PE
15972011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1600 so that this new function doesn't get optimized away by a
1601 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1602
021f2e1a
AS
16032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1604
1605 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1606
8b058d44
EZ
16072011-10-29 Eli Zaretskii <eliz@gnu.org>
1608
1609 Fix the `xbytecode' command.
1610 * .gdbinit (xprintbytestr): New command.
b50a28de 1611 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1612 (xbytecode): Print the byte-code string as well.
1613
4452fb80
EZ
16142011-10-29 Kim Storm <storm@cua.dk>
1615
8b058d44
EZ
1616 * alloc.c (which_symbols): New function.
1617
21b72067
AS
16182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1619
1620 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1621 line. (Bug#9903)
1622
83ed7b5c
GM
16232011-10-29 Glenn Morris <rgm@gnu.org>
1624
1625 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1626 Not clear what it was for, and it causes various bugs. (Bug#9839)
1627
5a7a728b
EZ
16282011-10-28 Eli Zaretskii <eliz@gnu.org>
1629
1630 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1631 possible random value that matches one of those tested as
1632 condition to clear the mouse face.
1633
d3d0842f
CY
16342011-10-28 Chong Yidong <cyd@gnu.org>
1635
1636 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1637
31b39d13
DN
16382011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1639
1640 * window.c (make_window): Initialize phys_cursor_on_p.
1641
9aba6043
SM
16422011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1643
1644 * lisp.h (struct Lisp_Symbol): Update comments.
1645
c20992f4
JB
16462011-10-28 Juanma Barranquero <lekktu@gmail.com>
1647
1648 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1649
db4f02f2
EZ
16502011-10-28 Eli Zaretskii <eliz@gnu.org>
1651
1652 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1653 <oslsachem@gmail.com> for helping to debug this.
1654
1655 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1656 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1657 (g_b_init_get_glyph_outline_w): New static variables.
1658 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1659 (GetGlyphOutlineW_Proc): New typedefs.
1660 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1661 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1662 New functions.
1663 (w32font_open_internal, compute_metrics):
1664 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1665 instead of calling the "wide" APIs directly.
1666
1667 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1668
1669 * w32.h (syms_of_w32font): Add prototype.
1670
87e68db4
JB
16712011-10-27 Juanma Barranquero <lekktu@gmail.com>
1672
1673 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1674 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1675 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1676 (Fmove_to_window_line): Doc fix.
1677
435c1d67
CY
16782011-10-27 Chong Yidong <cyd@gnu.org>
1679
1680 * process.c (make_process): Set gnutls_state to NULL.
1681
1682 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1683 non-NULL, regardless of GNUTLS_INITSTAGE.
1684 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1685 an error. Set process slots as soon as we allocate them.
1686
1687 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1688
9c6c6f49
CY
16892011-10-27 Chong Yidong <cyd@gnu.org>
1690
9aba6043
SM
1691 * gnutls.c (emacs_gnutls_deinit): New function.
1692 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1693 (Fgnutls_deinit, Fgnutls_boot): Use it.
1694
1695 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1696 (deactivate_process): Call emacs_gnutls_deinit.
1697
657d08d3
JB
16982011-10-27 Juanma Barranquero <lekktu@gmail.com>
1699
1700 * image.c (x_create_x_image_and_pixmap):
1701 * w32.c (sys_rename, w32_delayed_load):
1702 * w32font.c (fill_in_logfont):
1703 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1704
5430d399
JB
17052011-10-26 Juanma Barranquero <lekktu@gmail.com>
1706
1707 * w32fns.c (w32_default_color_map): New function,
1708 extracted from Fw32_default_color_map.
a7ef684b 1709 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1710
fe0055fa
PE
17112011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1714
e6346438
SM
17152011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1716
1717 * keyboard.c (test_undefined): New function (bug#9751).
1718 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1719
e112cc37
ET
17202011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1721
1722 * sysdep.c (init_sys_modes): Fix the check for the controlling
1723 terminal (Bug#6649).
1724
7b5d6677
EZ
17252011-10-20 Eli Zaretskii <eliz@gnu.org>
1726
1727 * dispextern.h (struct bidi_it): New member next_en_type.
1728
1729 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1730 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1731 current character, check also for next_en_type being WEAK_EN.
1732 (bidi_resolve_weak): Don't enter the expensive loop if the current
1733 position is before next_en_pos. Record the bidi type of the first
1734 non-ET, non-BN character we find, in addition to its position.
1735 (bidi_level_of_next_char): Invalidate next_en_type when
1736 next_en_pos is over-stepped.
1737
7da0b018
PE
17382011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1741 * editfns.c: Rewrite current-time-zone so that it invokes
1742 the equivalent of (format-time-string "%Z") to get the time zone name.
1743 This fixes a bug when the time zone name contains characters that
1744 need converting from the system time locale to Emacs internal format.
1745 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1746 that patch fixed format-time-string to do the conversion, but
1747 I forgot to fix current-time-zone.
1748 (format_time_string): New function, containing most of
1749 what Fformat_time_string used to contain.
1750 (Fformat_time_string): Rewrite in terms of format_time_string.
1751 This doesn't change this function's behavior.
1752 (current-time-zone): Rewrite to use format_time_string.
1753 This fixes the bug reported by Michael Schierl in
1754 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1755 Jason Rumney's 2007-06-07 change worked around this bug, but
1756 didn't fix it.
1757 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1758
8547b010
EZ
17592011-10-19 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (start_display): If the character at POS is displayed
1762 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1763 (try_window_reusing_current_matrix): If a line ends in a display
1764 vector or the next line starts in a display vector, continue
1765 redrawing the window even though the character position of
1766 start_row was reached.
8547b010
EZ
1767 (Bug#9771, part 2)
1768
4e948d15
CY
17692011-10-18 Chong Yidong <cyd@gnu.org>
1770
1771 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1772 with nobreak-char-display too.
1773
4787455f
EZ
17742011-10-18 Eli Zaretskii <eliz@gnu.org>
1775
1776 Fix part 3 of bug#9771.
1777 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1778 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1779 non-neutral characters if the current character is a paragraph
1780 separator (a.k.a. Newline). This avoids running the same
1781 expensive loop twice, once when we consume the preceding newline
1782 and the other time when the line actually needs to be displayed.
1783 Avoid the loop when we see neutrals on the base embedding level
1784 following a character whose directionality is the same as the
1785 paragraph's. This avoids running the expensive loop when a line
1786 ends in a long sequence of neutrals, like control characters.
1787 Add assertion against STRONG_AL type. Slightly rearrange code
1788 that determines the type of a neutral given the first non-neutral
1789 that follows it.
1790 (bidi_level_of_next_char): Set next_en_pos to zero when
1791 invalidating its info.
1792
2c91f553
EZ
17932011-10-17 Eli Zaretskii <eliz@gnu.org>
1794
1795 * xdisp.c (push_display_prop): Determine whether to record string
1796 or buffer position by IT->string, not by IT->method. Allow
1797 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1798 (move_it_vertically_backward): Don't look for character position
1799 immediately after the newline when in a continuation line.
1800 (Bug#9771, part 1)
2c91f553 1801
c7b08b0d
MR
18022011-10-15 Martin Rudalics <rudalics@gmx.at>
1803
1804 * window.c (coordinates_in_window): Rewrite and delabelize
1805 vertical border check. (Bug#5357) (Bug#9618)
1806
6b02f655
SM
18072011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1810 errors in XSetWindowBorder (bug#9310).
1811
81d40c92
DA
18122011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1813
1814 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1815 avoid crash when xmalloc overrun checking is enabled.
1816
d4172c3b
EZ
18172011-10-13 Eli Zaretskii <eliz@gnu.org>
1818
1819 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1820 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1821 cursor motion with <left> and <right> arrow keys.
1822
1823 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1824 some callers set that themselves.
1825
b00eea75
EZ
18262011-10-12 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1829 display string and the previous row comes from the same string and
1830 is empty. (Bug#9739) (Bug#9738)
1831
8fe012c4
SM
18322011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1833
1834 * doc.c (get_doc_string): Encode file name (bug#9735).
1835
0074aef2
EZ
18362011-10-12 Eli Zaretskii <eliz@gnu.org>
1837
79beb178
EZ
1838 * bidi.c (bidi_level_of_next_char):
1839 * xdisp.c (get_visually_first_element): Remove old incorrect
1840 comments regarding the Unicode Line Separator character.
1841
0074aef2
EZ
1842 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1843
6e4b3fbe
DA
18442011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1845
1846 * alloc.c (Fgc_status): Do not access beyond zombies array
1847 boundary if nzombies > MAX_ZOMBIES.
1848 * alloc.c (dump_zombies): Add missing format specifier.
1849
0324f3af
PE
18502011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1851
b5525cac
PE
1852 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1853 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1854
0324f3af
PE
1855 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1856 Some packages use them to denote characters with modifiers.
1857
e9b5f888
AS
18582011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1859
1860 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1861 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1862 matching a pp-number. Rename parameter var to var1.
1863
127827c0
SM
18642011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1865
1866 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1867
c8fd3bd0
GM
18682011-10-08 Glenn Morris <rgm@gnu.org>
1869
1870 * callint.c (Fcall_interactively): Give a more explicit error for the
1871 'c' case with a non-character input. (Bug#8479)
1872
352ec8ff
EZ
18732011-10-08 Eli Zaretskii <eliz@gnu.org>
1874
03669ccb
EZ
1875 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1876 lines.
7061c986
EZ
1877 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1878 lines that are hscrolled on the left.
03669ccb 1879
352ec8ff
EZ
1880 * dispnew.c (buffer_posn_from_coords): Account for a possible
1881 presence of header-line. (Bug#4426)
1882
a66cfb1c
SM
18832011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1884
6b02f655
SM
1885 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1886 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1887
7c5ee88e
PE
18882011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1891 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1892 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1893 this makes Emacs dump core during garbage collection on rare
1894 occasions. sizeof is obviously inferior to offsetof here, so
1895 stick with offsetof.
1896 (GC_POINTER_ALIGNMENT): New macro.
1897 (mark_memory): Omit 3rd (offset) arg; caller changed.
1898 Don't assume EMACS_INT alignment is the same as pointer alignment.
1899
df1bbe5b
SM
19002011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1901
1902 * keyboard.c (read_key_sequence_remapped): New var.
1903 (read_key_sequence): Compute remapping in the right buffer.
1904 (command_loop_1): Use read_key_sequence's remapping directly.
1905
51553db6
SM
19062011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1907
32c1fffd
SM
1908 * dired.c (file_name_completion): Don't expand file name.
1909 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1910 before checking file name handler.
1911
51553db6
SM
1912 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1913 they've been requested explicitly (bug#9591).
1914
b6bd1599 19152011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1916
1917 * keymap.c (Fsingle_key_description): Use make_specified_string
1918 instead of build_string to build string from push_key_description.
1919 (Bug#5193)
1920
f701dc2a
PE
19212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1922
4222c55d
PE
1923 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1924 This fixes a Y2038 bug on 64-bit hosts.
1925 * buffer.c (reset_buffer):
1926 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1927 (Fclear_buffer_auto_save_failure):
1928 Use 0, not -1, to represent an unset failure time, since time_t
1929 might not be signed.
1930
f701dc2a
PE
1931 Remove dependency on glibc malloc internals.
1932 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1933 Move back here from lisp.h, but with their new implementations.
1934 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1935 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1936 * charset.c (charset_table_init): New static var.
1937 (syms_of_charset): Use it instead of xmalloc. This removes a
1938 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1939 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1940 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1941 Move back to alloc.c.
1942 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1943 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1944
9ceebf39
JD
19452011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1946
1947 * nsterm.m (windowDidResize): Call x_set_window_size only when
1948 ns_in_resize is true. Otherwise set pixelwidth/height and
1949 call change_frame_size (Bug#9628).
1950
cb993c58
PE
19512011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1952
3930c88b
PE
1953 Port --enable-checking=all to Fedora 14 x86-64.
1954 * charset.c (syms_of_charset): Also account for glibc malloc's
1955 internal overhead when calculating the initial malloc maximum.
1956
cb993c58
PE
1957 Port --enable-checking=all to Fedora 14 x86.
1958 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1959 Move to lisp.h.
1960 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1961 (overrun_check_realloc, overrun_check_free):
1962 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1963 That way, xmalloc returns a properly-aligned pointer even if
1964 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1965 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1966 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1967 into account when calculating the initial malloc maximum.
1968 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1969 Move here from alloc.c, so that charset.c can use it too.
1970 Properly align; the old code wasn't right for common 32-bit hosts
1971 when configured with --enable-checking=all.
1972 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1973 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1974
31bed486
EZ
19752011-09-29 Eli Zaretskii <eliz@gnu.org>
1976
04c70788 1977 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1978 use EDOM.
1979
fbcaa2f3
EZ
19802011-09-28 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (compute_display_string_end): If there's no display
1983 string at CHARPOS, return -1.
1984
1985 * bidi.c (bidi_fetch_char): When compute_display_string_end
1986 returns a negative value, treat the character as a normal
1987 character not covered by a display string. (Bug#9624)
1988
a239d4e9
JB
19892011-09-28 Juanma Barranquero <lekktu@gmail.com>
1990
1991 * lread.c (Fread_from_string): Fix typo in docstring.
1992
88652fd5
EZ
19932011-09-27 Eli Zaretskii <eliz@gnu.org>
1994
1995 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1996 newline, reseat the iterator instead of bidi-iterating there one
1997 character at a time. (Bug#9610)
32c1fffd
SM
1998 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1999 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2000
ed497dd4
AS
20012011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2002
2003 * lread.c (readevalloop): Use correct code for NBSP.
2004 (read1): Likewise. (Bug#9608)
2005
b2bf61aa
MA
20062011-09-25 Michael Albinus <michael.albinus@gmx.de>
2007
2008 * dbusbind.c (Fdbus_register_signal): When service is not
2009 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2010
32bbb17c
GM
20112011-09-25 Glenn Morris <rgm@gnu.org>
2012
2013 * buffer.c (truncate-lines): Doc fix.
2014
94e0933e
CY
20152011-09-24 Chong Yidong <cyd@stupidchicken.com>
2016
2017 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2018 (Fset_window_next_buffers): Doc fix.
2019
cddde921
GM
20202011-09-24 Glenn Morris <rgm@gnu.org>
2021
2022 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2023
1260aef1
PE
20242011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2025
25b4bfa0
PE
2026 Fix minor problems found by static checking.
2027 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2028 * indent.c (Fvertical_motion): Fix == vs = typo.
2029
e3cbd34b
EZ
20302011-09-24 Eli Zaretskii <eliz@gnu.org>
2031
a66cfb1c
SM
2032 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2033 Default value is now t. Doc fix.
6bf7006f 2034
e3cbd34b 2035 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2036 logic when moving up, not only when moving down. Fix the
e3cbd34b 2037 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2038 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2039
2040 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2041 CHARPOS is covered by a display string which includes newlines.
2042 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2043 is covered by a display string with embedded newlines.
2044
a3de0cbd
MA
20452011-09-24 Michael Albinus <michael.albinus@gmx.de>
2046
2047 * dbusbind.c (Fdbus_register_signal): Add match rule to
2048 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2049 (Fdbus_register_method, Vdbus_registered_objects_table):
2050 Fix docstring.
a3de0cbd 2051
b260039d
JM
20522011-09-24 Jim Meyering <meyering@redhat.com>
2053
32c1fffd 2054 do not ignore write error for any output size
b260039d
JM
2055 The previous change was incomplete.
2056 While it makes emacs --batch detect the vast majority of stdout
2057 write failures, errors were still ignored whenever the output size is
2058 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2059 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2060 && echo FAIL: ignored write error
2061 FAIL: ignored write error
2062 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2063 && echo FAIL: ignored write error
2064 FAIL: ignored write error
2065 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2066
8eca8a7c
AS
20672011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2068
2069 * emacs.c (Fkill_emacs): In noninteractive mode exit
2070 non-successfully if a write error occurred on stdout. (Bug#9574)
2071
3341db62
EZ
20722011-09-21 Eli Zaretskii <eliz@gnu.org>
2073
2074 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2075 the xassert test.
2076
2077 * dispextern.h (struct it): Update the comment documenting what
2078 can it->OBJECT be.
2079
8c203dbf
EZ
20802011-09-20 Eli Zaretskii <eliz@gnu.org>
2081
2082 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2083 a display string, extend search for cursor position to end of row.
2084 (find_row_edges): If the row ends in a newline from a display
2085 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2086 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2087 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2088 non-empty line. Fixes confusing cursor motion with arrow keys at
2089 the beginning of a line that starts with whitespace.
8c203dbf 2090
a4824228
LMI
20912011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2092
2093 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2094 (bug#9493).
2095
33ed493b
CY
20962011-09-18 Chong Yidong <cyd@stupidchicken.com>
2097
2098 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2099 boolean (Bug#9154).
2100
56cd55c8
EZ
21012011-09-18 Eli Zaretskii <eliz@gnu.org>
2102
2103 * xdisp.c (display_line): Record maximum and minimum buffer
2104 positions even if no glyphs were produced (e.g., by a zero-width
2105 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2106 buffer positions that will be removed from the glyph row because
2107 they don't fit.
c02dcedf
EZ
2108 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2109 column is beyond frame width: don't subtract 1 "pixel" when
2110 computing width of the stretch.
3e62b7e0
EZ
2111 (reseat_at_next_visible_line_start): Undo the change made on
2112 2011-09-17 that saved paragraph information and restored it after
2113 the call to `reseat'. (Bug#9545)
56cd55c8 2114
5ed99d36 21152011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2116
2117 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2118 and turn window cursor on if cleared (Bug#9415).
2119
5ed99d36 21202011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2121
2122 * search.c (boyer_moore): Take unibyte characters from pattern
2123 literally. (Bug#9458)
2124
9bade7b2
EZ
21252011-09-18 Eli Zaretskii <eliz@gnu.org>
2126
2127 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2128
e5e9d610
PE
21292011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2130
87e4427a
PE
2131 Fix minor problem found by static checking.
2132 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2133 initialized, to pacify gcc -Wuninitialized.
2134
e5e9d610
PE
2135 * fileio.c: Report proper errno when syscall falls.
2136 (Finsert_file_contents): Save and restore errno,
2137 so that report_file_error outputs the correct diagnostic.
2138 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2139
a1674f0b
EZ
21402011-09-18 Eli Zaretskii <eliz@gnu.org>
2141
2142 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2143
fbfb6dd4
EZ
21442011-09-17 Eli Zaretskii <eliz@gnu.org>
2145
2146 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2147 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2148
bb187662
EZ
21492011-09-17 Eli Zaretskii <eliz@gnu.org>
2150
1137e8b8 2151 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2152 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2153
2154 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2155 (bidi_find_paragraph_start): Search back for paragraph beginning
2156 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2157 (bidi_move_to_visually_next): Only trigger paragraph-related
2158 computations when the last character is a newline or at EOB, not
2159 just any NEUTRAL_B. (Bug#9470)
2160
bb187662
EZ
2161 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2162 truncated lines if point is covered by a display string. (Bug#9524)
2163
2e621251
PE
21642011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2167 (cons_to_x_long): New function.
2168 (lisp_data_to_selection_data): Use it. Correct the test for
2169 short-versus-long data; it was negated. Break out of vector
2170 loop, for efficiency, when a long datum is discovered.
2171
91a15bc6
SM
21722011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2175
b41c3a35
EZ
21762011-09-16 Eli Zaretskii <eliz@gnu.org>
2177
2178 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2179 GCC PR/17406) by declaring this function with external scope.
2180
7812ba2d
PE
21812011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2184 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2185
cf7edc2a
AS
21862011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2187
2188 * editfns.c (Fformat): Correctly handle text properties on "%%".
2189
bd01620e
EZ
21902011-09-15 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xterm.c (x_draw_composite_glyph_string_foreground):
2193 * w32term.c (x_draw_composite_glyph_string_foreground):
2194 * term.c (encode_terminal_code):
2195 * composite.c (composition_update_it, get_composition_id):
2196 * xdisp.c (get_next_display_element)
2197 (fill_composite_glyph_string): Add comments about special meaning
2198 of TAB characters in a composition.
2199
a02719a3
PE
22002011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2201
2202 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2203 This occurs when processing a multibyte format.
2204 Problem reported by Wolfgang Jenker.
a02719a3 2205
72589a3c
JB
22062011-09-15 Johan Bockgård <bojohan@gnu.org>
2207
2208 * xdisp.c (try_cursor_movement): Only check for exact match if
2209 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2210
1c14176c
PE
22112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 Remove unused external symbols.
2214 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2215 * xdisp.c (calc_pixel_width_or_height): Now static.
2216 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2217 * indent.c (check_display_width):
2218 * w32term.c: Fix comment to match code.
2219 * xterm.c, xterm.h (x_catching_errors): Remove.
2220
d2eea5b5
PE
22212011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 * xselect.c: Use signed conversions more consistently (Bug#9498).
2224 (selection_data_to_lisp_data): Assume incoming selection data are
2225 signed integers, not unsigned. This is to be consistent with
2226 outgoing selection data, which was modified to use signed integers
2227 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2228 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2229 expects long, not unsigned long.
2230
46888499
EZ
22312011-09-14 Eli Zaretskii <eliz@gnu.org>
2232
2233 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2234 computation of loop end. Reported by Johan Bockgård
2235 <bojohan@gnu.org>.
2236
ef8ef9fb
CY
22372011-09-13 Chong Yidong <cyd@stupidchicken.com>
2238
2239 * frame.c (Fother_visible_frames_p): Function deleted.
2240
fa819fed
EZ
22412011-09-12 Eli Zaretskii <eliz@gnu.org>
2242
2243 * indent.c (compute_motion): Process display vector front to back
2244 rather than the other way around. (Bug#2496)
2245
2ba8e008
SM
22462011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2247
2248 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2249
20f53c69
CY
22502011-09-11 Chong Yidong <cyd@stupidchicken.com>
2251
2252 * minibuf.c (Fread_from_minibuffer): Doc fix.
2253
d562d7a4
EZ
22542011-09-11 Eli Zaretskii <eliz@gnu.org>
2255
2256 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2257 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2258
1c4d7f3d
LMI
22592011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2260
2261 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2262 value for non-existent files.
2263
b885bf36
EZ
22642011-09-11 Eli Zaretskii <eliz@gnu.org>
2265
2266 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2267 set its "size" to -1. This will set the modtime_size field of
2268 the corresponding buffer to -1, which is what
2269 verify-visited-file-modtime expects for files that do not exist.
2270 (Bug#9139)
2271
6612f0bf
PE
22722011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2275 here ...
2276 * lisp.h: ... from here. push_key_description is no longer
2277 defined in keyboard.c, so its declaration should not be in
2278 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2279 logically belongs with push_key_description.
2280
dfb3f755
PE
22812011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 * buffer.h: Include <sys/types.h> instead of <time.h>.
2284 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2285 Problem reported by Herbert J. Skuhra.
2286
3134906c
LMI
22872011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2288
2289 * xml.c (parse_region): Make the parsing work for
2290 non-comment-starting XML files again (bug#9144).
2291
8d903f4e
AS
22922011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2293
2294 * image.c (gif_load): Fix calculation of bottom and right corner.
2295 (Bug#9468)
2296
80ad64f4
EZ
22972011-09-10 Eli Zaretskii <eliz@gnu.org>
2298
2299 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2300 redisplay in small windows.
2301
208a048d
EZ
23022011-09-09 Eli Zaretskii <eliz@gnu.org>
2303
2304 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2305
9b1c252e
MR
23062011-09-08 Martin Rudalics <rudalics@gmx.at>
2307
2308 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2309 Operate on live windows only.
2310
2949f33b
JB
23112011-09-08 Juanma Barranquero <lekktu@gmail.com>
2312
2313 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2314
e08dcafd
EZ
23152011-09-07 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2318 only under bidi iteration.
2319
115b96bd
JD
23202011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2321
2322 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2323
c8199d0f
PE
23242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2325
2326 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2327 Without this fix, the command to link temacs failed due to an
2328 undefined symbol __builtin_isnan. This is because
2329 /usr/include/iso/math_c99.h #defines isnan(x) to
2330 __builtin_isnan(x), but the bundled gcc, which identifies itself
2331 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2332 a __builtin_isnan.
2333 * floatfns.c (isnan): #undef, and then #define to a clone of
2334 what's in data.c.
2335 (Fisnan): Always define, since it's always available now.
2336 (syms_of_floatfns): Always define isnan at the Lisp level.
2337
e39b275c 23382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2339
2340 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2341
b2db44d9 23422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2343
f4af5137 2344 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2345 The previous code assumed that file offsets (off_t values) fit in
2346 EMACS_INT variables, which is not true on typical 32-bit hosts.
2347 The code messed up by falsely reporting buffer overflow in cases
2348 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2349 when "big" contains more than 2**29 bytes, even though this
2350 inserts just one byte and does not overflow the buffer.
2351 (Finsert_file_contents): Store file offsets as off_t
2352 values, not as EMACS_INT values. Check for overflow when
2353 converting between EMACS_INT and off_t. When checking for
2354 buffer overflow or for overlap, take the offsets into account.
2355 Don't use EMACS_INT for small values where int suffices.
2356 When checking for overlap, fix a typo: ZV was used where
2357 ZV_BYTE was intended.
2358 (Fwrite_region): Don't assume off_t fits into 'long'.
2359 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2360
ecfc0a49
MA
23612011-09-05 Michael Albinus <michael.albinus@gmx.de>
2362
2363 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2364
6511acf2 23652011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2366
0999621a 2367 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2368
2369 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2370 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2371 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2372 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2373 (modify_event_symbol): Do not assume that the length of
2374 name_alist_or_stem is safe to alloca and fits in int.
2375 (Fexecute_extended_command): Likewise for function name and binding.
2376 (Frecursion_depth): Wrap around reliably on integer overflow.
2377 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2378 since some callers pass EMACS_INT values.
2379 (Fsingle_key_description): Don't crash if symbol name contains more
2380 than MAX_ALLOCA bytes.
2381 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2382 (get_minibuffer): Arg is now EMACS_INT, not int.
2383 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2384 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2385 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2386
2be7d702
PE
2387 * dbusbind.c (signature_cat): New function.
2388 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2389 Do not overrun buffer; instead, report string overflow.
2390
9d1df220
PE
2391 * dispnew.c (add_window_display_history): Don't overrun buffer.
2392 Truncate instead; this is OK since it's just a log.
2393
33ef5c64
PE
2394 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2395 even if the time zone offset is outlandishly large.
2396 Don't mishandle offset == INT_MIN.
2397
66c6fdd5
PE
2398 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2399 when creating daemon; the previous buffer-overflow check was incorrect.
2400
d749b01b
PE
2401 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2402 which has the guts of the old verror function.
2403
b5cd1905
PE
2404 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2405 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2406
6e1a67fb
PE
2407 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2408 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2409 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2410 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2411 length of string rather than counting it via multiple sprintfs;
2412 that's simpler and more reliable.
c21721cc
PE
2413 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2414 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2415 sprintf, in case result does not fit in int.
2416
c57b67fc
PE
2417 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2418 (fontset_from_font): Print it.
2419
8a401434
PE
2420 * frame.c (tty_frame_count): Now printmax_t, not int.
2421 (make_terminal_frame, set_term_frame_name): Print it.
2422 (x_report_frame_params): In X, window IDs are unsigned long,
2423 not signed long, so print them as unsigned.
2424 (validate_x_resource_name): Check for implausibly long names,
2425 and don't assume name length fits in 'int'.
2426 (x_get_resource_string): Don't blindly alloca invocation name;
2427 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2428 not fit in int.
2429
6e1a67fb
PE
2430 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2431 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2432 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2433
0df02bf3
PE
2434 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2435 Use esprintf, not sprintf, in case result does not fit in int.
2436
48e30793
PE
2437 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2438 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2439 it as a large positive number.
2440 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2441 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2442
a66ff6d8
PE
2443 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2444 in case result does not fit in int.
2445
aca216ff
PE
2446 * print.c (float_to_string): Detect width overflow more reliably.
2447 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2448 buffer overrun. Don't assume list length fits in 'int'. Treat
2449 print length of 0 as 0, not as infinity; to be consistent with other
2450 uses of print length in this function. Don't overflow print length
2451 index. Don't assume hash table size fits in 'long', or that
2452 vectorlike size fits in 'unsigned long'.
2453
31c286f7
PE
2454 * process.c (make_process): Use printmax_t, not int, to format
2455 process-name gensyms.
2456
55e5faa1
PE
2457 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2458
80f2e268
PE
2459 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2460 to avoid potential buffer overrun.
2461
670741ab
PE
2462 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2463 if X resource line is longer than 512 bytes.
2464
b7163a50
PE
2465 * xfns.c (x_window): Make sprintf buffer a bit bigger
2466 to avoid potential buffer overrun.
2467
ae58ff1f
PE
2468 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2469
c43c8a6a
PE
2470 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2471
3f8236f4
PE
24722011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2473
53e9fe90 2474 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2475 Without these, Emacs silently mishandles large integers sometimes.
2476 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2477 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2478
6511acf2
PE
2479 * xdisp.c (try_window_id): Check Emacs fixnum range before
2480 converting to 'int'.
806add1d 2481
6511acf2 2482 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2483 Check that an Emacs fixnum is in range before assigning it to 'int'.
2484 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2485 values converted from Emacs fixnums.
2486 (Frecenter): Don't wrap around a line count if it is out of 'int'
2487 range; instead, treat it as an extreme value.
2488 (Fset_window_configuration, compare_window_configurations):
2489 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2490
6511acf2
PE
2491 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2492 that can exceed INT_MAX. Check that EMACS_INT value is in range
2493 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2494 (match_limit): Don't assume that a fixnum can fit in 'int'.
2495
6511acf2 2496 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2497 exceed INT_MAX.
2498
6511acf2 2499 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2500 (Fvertical_motion): Don't wrap around LINES values that don't fit
2501 in 'int'. Instead, treat them as extreme values. This is good
2502 enough for windows, which can't have more than INT_MAX lines anyway.
2503
fcb901a7
LMI
25042011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2505
0f2f6b6d
LMI
2506 * Require libxml/parser.h to avoid compilation warning.
2507
fcb901a7
LMI
2508 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2509
2510 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2511 since this reportedly can destroy thread storage.
2512
6e20a0d4
CY
25132011-08-30 Chong Yidong <cyd@stupidchicken.com>
2514
2515 * syntax.c (find_defun_start): Update all cache variables if
2516 exiting early (Bug#9401).
2517
148ae00e
EZ
25182011-08-30 Eli Zaretskii <eliz@gnu.org>
2519
f6cfbd8f
EZ
2520 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2521
148ae00e
EZ
2522 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2523 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2524 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2525
2526 * term.c (tty_append_glyph): New function.
2527 (produce_stretch_glyph): Static function and its prototype deleted.
2528
a66cfb1c
SM
2529 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2530 Add prototypes.
148ae00e 2531
c4a07a4c
PE
25322011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2535 when checking :margin (Bug#9390).
2536 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2537 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2538 so that the name doesn't mislead. All uses changed.
2539
6bc8cd65
JB
25402011-08-28 Johan Bockgård <bojohan@gnu.org>
2541
2542 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2543 set_tty_hooks.
2544
dca4927e
EZ
25452011-08-27 Eli Zaretskii <eliz@gnu.org>
2546
2547 * xdisp.c (move_it_to): Don't bail out early when reaching
2548 position beyond to_charpos, if we are scanning backwards.
2549 (move_it_vertically_backward): When DY == 0, make sure we get to
2550 the first character in the line after the newline.
2551
f2cad773
PE
25522011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2555 (ccl_driver): Do not generate an out-of-range pointer.
2556 (Fccl_execute_on_string): Remove unnecessary check for
2557 integer overflow, noted by Stefan Monnier in
2558 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2559 Remove a FIXME that didn't need fixing.
2560 Simplify the newly-introduced buffer reallocation code.
2561
0cae2cdb
JB
25622011-08-27 Juanma Barranquero <lekktu@gmail.com>
2563
2564 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2565
5fc295a4 25662011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2567
70c60eb2 2568 Integer and memory overflow issues (Bug#9196).
726e0ab1 2569
d31850da
PE
2570 * doc.c (get_doc_string): Rework so that
2571 get_doc_string_buffer_size is the actual buffer size, rather than
2572 being 1 less than the actual buffer size; this makes xpalloc more
2573 convenient.
2574
a69fbedb
PE
2575 * image.c (x_allocate_bitmap_record, cache_image):
2576 * xselect.c (Fx_register_dnd_atom):
2577 Simplify previous changes by using xpalloc.
2578
fe5c5d37
PE
2579 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2580 since either will do and ptrdiff_t is convenient with xpalloc.
2581
0065d054
PE
2582 * charset.c (charset_table_size)
2583 (struct charset_sort_data.priority): Now ptrdiff_t.
2584 (charset_compare): Don't overflow if priorities differ greatly.
2585 (Fsort_charsets): Don't assume list length fits in int.
2586 Check for size-calculation overflow when allocating sort data.
2587 (syms_of_charset): Allocate an initial charset table that is
2588 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2589
2590 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2591
2592 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2593 The actual value is always <= INT_MAX, and leaving it unsigned made
2594 overflow checking harder.
2595
2596 * dispextern.h (struct glyph_matrix.rows_allocated)
2597 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2598 with xpalloc. The values are still always <= INT_MAX.
2599
2600 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2601
2602 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2603 (SAFE_NALLOCA): New macro.
2604
2605 * region-cache.c (struct boundary.pos, find_cache_boundary)
2606 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2607 (set_cache_region, invalidate_region_cache)
2608 (revalidate_region_cache, know_region_cache, region_cache_forward)
2609 (region_cache_backward, pp_cache):
2610 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2611 so that ptrdiff_t * can be passed to xpalloc.
2612 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2613 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2614 (pp_cache): Don't assume cache_len fits in int.
2615 * region-cache.h: Adjust extern decls to match.
2616
2617 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2618 EMACS_INT, since either will do, for xpalloc.
2619
2620 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2621 (xnmalloc, xnrealloc, xpalloc): New functions.
2622
726e0ab1
PE
2623 * bidi.c (bidi_shelve_header_size): New constant.
2624 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2625 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2626
51f30bc5 2627 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2628 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2629 (overlay_strings):
2630 Don't update size of array until after memory allocation succeeds,
2631 because xmalloc/xrealloc may not return.
0065d054
PE
2632 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2633 now that we have proper integer overflow checking.
2634 (record_overlay_string, overlay_strings): Catch overflows when
2635 calculating size of overlay_str_buf.
726e0ab1 2636
0065d054
PE
2637 * callproc.c (Fcall_process): Check for size overflow when
2638 calculating size of args2.
2639 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2640 Normally we prefer signed values, but sticking with ptrdiff_t would
2641 require adding more-complicated checks.
726e0ab1
PE
2642
2643 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2644 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2645 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2646 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2647
2648 * character.c (Fstring): Check for size-calculation overflow.
2649
2650 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2651 unnecessary integer overflow. Check for size overflow.
2652 (encode_coding_object): Don't update size until xmalloc succeeds.
2653
2654 * composite.c (get_composition_id): Check for overflow in glyph
2655 length calculations.
2656
2657 Integer and memory overflow fixes for display code.
2658 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2659 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2660 (scrolling_window): Check for overflow in size calculations.
2661 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2662 Don't assume glyph table len fits in int.
2663 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2664 (row_table_size): Now ptrdiff_t, not int.
2665 (scrolling_window): Avoid overflow in size calculations.
2666 Don't update size until allocation succeeds.
2667 * fns.c (concat): Check for overflow in size calculations.
2668 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2669 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2670 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2671
2672 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2673 (get_doc_string): Check for size calculation overflow.
2674 Don't update size until allocation succeeds.
2675 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2676 EMACS_INT, where ptrdiff_t will do.
2677 (Fsubstitute_command_keys): Check for string overflow.
2678
2679 * editfns.c (set_time_zone_rule): Don't assume environment length
2680 fits in int.
2681 (message_length): Now ptrdiff_t, not int.
2682 (Fmessage_box): Don't update size until allocation succeeds.
2683 Don't assume message length fits in int.
2684 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2685
0065d054
PE
2686 * emacs.c (main): Do not reallocate argv, since there is a null at
2687 the end that can be overwritten, and this way there's no need to
2688 worry about size-calculation overflow.
2689 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2690
2691 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2692 alloc succeeds.
2693 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2694
2695 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2696 (x_set_scroll_bar_width, x_figure_window_size):
2697 Check for integer overflow.
2698 (x_set_alpha): Do not assume XINT fits in int.
2699
2700 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2701 This is for the members text_lines, text_cols, total_lines, total_cols,
2702 where the system imposes an 'int' limit.
2703
2704 * fringe.c (Fdefine_fringe_bitmap):
2705 Don't update size until alloc works.
2706
2707 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2708 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2709
2710 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2711 Check for size-calculation overflow.
2712 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2713 do, as we prefer signed integers.
2714 (id_to_widget.max_size, id_to_widget.used)
2715 (xg_store_widget_in_map, xg_remove_widget_from_map)
2716 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2717 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2718 Use and return ptrdiff_t, not int.
2719 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2720 * gtkutil.h: Change prototypes to match the above.
2721
2722 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2723 are duplicate now that they've been promoted to lisp.h.
2724 (x_allocate_bitmap_record, x_alloc_image_color)
2725 (make_image_cache, cache_image, xpm_load):
2726 Don't update size until alloc is done.
2727 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2728 (x_detect_edges):
3256efce 2729 Check for size calculation overflow.
726e0ab1
PE
2730 (ct_colors_allocated_max): New constant.
2731 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2732 overflow.
3256efce 2733
726e0ab1
PE
2734 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2735 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2736 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2737 Use ptrdiff_t, not int, to count maps.
2738 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2739 calculations. Don't update size until allocation succeeds.
2740 Redo calculations to avoid overflow.
726e0ab1
PE
2741 * keyboard.h: Change prototypes to match the above.
2742
2743 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2744 to count maps.
2745 (current_minor_maps): Check for size calculation overflow.
2746 * keymap.h: Change prototypes to match the above.
2747
2748 * lread.c (read1, init_obarray): Don't update size until alloc done.
2749
2750 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2751 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2752
726e0ab1
PE
2753 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2754 Now ptrdiff_t, not int.
2755 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2756 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2757
2758 * process.c (Fnetwork_interface_list): Check for overflow
2759 in size calculation.
2760
2761 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2762
2763 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2764 overflow. Don't bother calling xmalloc when xrealloc will do.
2765
2766 * search.c (Freplace_match): Check for size calculation overflow.
2767 (Fset_match_data): Don't assume list lengths fit in 'int'.
2768
2769 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2770 for command line length. Do not attempt to address one before the
2771 beginning of an array, as that's not portable.
2772
2773 * term.c (max_frame_lines): Remove; unused.
2774 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2775 not int.
2776 (encode_terminal_code, calculate_costs): Check for size
2777 calculation overflow.
2778 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2779 table lengths and related sizes. Don't update size until alloc
2780 done. Redo calculations to avoid overflow.
2781 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2782
2783 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2784 subtracting pointers.
2785 (gobble_line): Check for overflow more carefully. Don't update size
2786 until alloc done.
2787
2788 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2789 Don't update size until alloc done.
2790 Redo size calculations to avoid overflow.
2791 Check for size calculation overflow.
0065d054 2792 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2793
2794 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2795 Use ptrdiff_t, not int, for sizes.
2796 (store_mode_line_noprop_char): Don't update size until alloc done.
2797
0065d054
PE
2798 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2799 Use ptrdiff_t, not int, for sizes.
2800 (Finternal_make_lisp_face, cache_face):
2801 Check for size calculation overflow.
2802 (cache_face): Treat size calculation overflows as if they were
2803 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2804
2805 * xfns.c (x_encode_text, x_set_name_internal)
2806 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2807 sizes, since they can exceed INT_MAX in size. Check for size
2808 calculation overflow.
2809
0065d054
PE
2810 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2811 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2812 Don't update size until alloc done.
2813
0065d054 2814 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2815 as sprintf is limited to int lengths.
1d526e2f 2816
252c5ee1
PE
2817 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2818 (X_LONG_MIN): New macros.
864d7ce7
PE
2819 Use them to make the following changes clearer.
2820 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2821 This change doesn't affect the value now, but it may help remind
2822 future maintainers not to raise the value too much later.
2823 (SELECTION_QUANTUM): Remove, replacing with ...
2824 (selection_quantum): ... new function, which avoids overflow.
2825 All uses changed.
2826 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2827 assumption that selection length fits in 'int'.
2828 (x_reply_selection_request, x_handle_selection_request)
2829 (x_get_window_property, receive_incremental_selection)
2830 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2831 (lisp_data_to_selection_data, clean_local_selection_data):
2832 Use ptrdiff_t, not int, to record length of selection.
2833 (x_reply_selection_request, x_get_window_property)
2834 (receive_incremental_selection, x_property_data_to_lisp):
2835 Redo calculations to avoid overflow.
2836 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2837 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2838 something.
2839 (x_get_window_property, receive_incremental_selection)
2840 (lisp_data_to_selection_data, x_property_data_to_lisp):
2841 Check for size-calculation overflow.
2842 (x_get_window_property, receive_incremental_selection)
2843 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2844 Don't store size until memory allocation succeeds.
2845 (x_get_window_property): Plug memory leak on memory exhaustion.
2846 Don't double-block input; malloc is safe here. Don't assume 2**34
2847 - 4 fits in unsigned long. Add an xassert to check
2848 XGetWindowProperty overflow. Be more careful about overflow
2849 calculations, and distinguish size from memory overflow better.
2850 (receive_incremental_selection): When tracing, don't assume
2851 unsigned int is less than INT_MAX.
2852 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2853 harmful) conversions of unsigned short to int.
2854 (lisp_data_to_selection_data): Don't assume that integers
2855 in the range -65535 through -1 fit in an X unsigned short.
2856 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2857 result parameters unless successful. Rely on cons_to_unsigned
2858 to report problems with elements; the old code wasn't right anyway.
2859 (x_check_property_data): Check for int overflow; we cannot use
2860 a wider type due to X limits.
2861 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2862
726e0ab1 2863 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2864
0065d054
PE
2865 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2866 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2867 (x_color_cells): Don't store size until memory allocation succeeds.
2868 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2869 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2870 (x_term_init): Don't assume length fits in int (sprintf is limited
2871 to int size).
bc18e09d 2872
ebfa62c0
PE
2873 Use ptrdiff_t for composition IDs.
2874 * character.c (lisp_string_width):
2875 * composite.c (composition_table_size, n_compositions)
2876 (get_composition_id, composition_gstring_from_id):
2877 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2878 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2879 * window.c (Frecenter):
2880 Use ptrdiff_t, not int, for composition IDs.
2881 * composite.c (get_composition_id): Check for integer overflow.
2882 * composite.h: Adjust prototypes to match the above changes.
2883
d3411f89
PE
2884 Use ptrdiff_t for hash table indexes.
2885 * category.c (hash_get_category_set):
2886 * ccl.c (ccl_driver):
2887 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2888 * coding.c (coding_system_charset_list, detect_coding_system):
2889 * coding.h (struct coding_system.id):
2890 * composite.c (get_composition_id, gstring_lookup_cache):
2891 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2892 * image.c (xpm_get_color_table_h):
2893 * lisp.h (hash_lookup, hash_put):
2894 * minibuf.c (Ftest_completion):
2895 Use ptrdiff_t for hash table indexes, not int (which is too
2896 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2897 32-bit --with-wide-int hosts).
2898
e097a6fa
PE
2899 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2900 Add a FIXME comment about memory leaks.
2901 (syms_of_charset): Don't assume xmalloc returns.
2902
5637687f
PE
2903 Don't assume that stated character widths fit in int.
2904 * character.c (Fchar_width, c_string_width, lisp_string_width):
2905 * character.h (CHAR_WIDTH):
2906 * indent.c (MULTIBYTE_BYTES_WIDTH):
2907 Use sanitize_char_width to avoid undefined and/or bad behavior
2908 with outlandish widths.
a66cfb1c 2909 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2910 now that we have two such functions. All uses changed.
2911 (sanitize_char_width): New inline function.
2912
a2271ba2
PE
2913 Don't assume that tab-width fits in int.
2914 * character.h (sanitize_width): New inline function.
2915 (SANE_TAB_WIDTH): New macro.
2916 (ASCII_CHAR_WIDTH): Use it.
2917 * indent.c (sane_tab_width): Remove. All uses replaced by
2918 SANE_TAB_WIDTH (current_buffer).
2919 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2920
18c52557
PE
2921 * fileio.c: Integer overflow issues with file modes.
2922 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2923
caeeedc1
PE
2924 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2925 Remove unreachable code.
2926 (read_hex, load_charset_map_from_file): Check for integer overflow.
2927
6df6ae42 2928 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2929 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2930 (x_send_scroll_bar_event): Likewise. Check that the size does not
2931 exceed limits imposed by XClientMessageEvent, as well as the usual
2932 ptrdiff_t and size_t limits.
2933
b13995db
PE
2934 * keyboard.c: Overflow, signedness and related fixes.
2935 (make_lispy_movement): Use same integer type in forward decl
2936 that is used in the definition.
2937 (read_key_sequence, keyremap_step):
2938 Change bufsize argument back to int, undoing my 2011-03-30 change.
2939 We prefer signed types, and int is wide enough here.
2940 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2941 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2942 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2943 length, not size_t. Use ptrdiff_t for index, not int.
2944 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2945 possibility of integer overflow.
2946
13464394
PE
2947 Overflow, signedness and related fixes for images.
2948
2949 * dispextern.h (struct it.stack[0].u.image.image_id)
2950 (struct_it.image_id, struct image.id, struct image_cache.size)
2951 (struct image_cache.used, struct image_cache.ref_count):
2952 * gtkutil.c (update_frame_tool_bar):
2953 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2954 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2955 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2956 * nsmenu.m (update_frame_tool_bar):
2957 * xdisp.c (calc_pixel_width_or_height):
2958 * xfns.c (image_cache_refcount):
2959 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2960 on typical 64-bit hosts.
2961
2962 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2963 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2964 Omit unnecessary casts to int.
2965 (parse_image_spec): Check that integers fall into 'int' range
2966 when the callers expect that.
2967 (image_ascent): Redo ascent calculation to avoid int overflow.
2968 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2969 (lookup_image): Remove unnecessary tests.
2970 (xbm_image_p): Locals are now of int, not EMACS_INT,
2971 since parse_image_check makes sure they fit into int.
2972 (png_load, gif_load, svg_load_image):
2973 Prefer int to unsigned where either will do.
2974 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2975 old tiff_error_handler and tiff_warning_handler.
2976 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2977 stack buffer overflows. It uses only the features of vsnprintf
2978 that are common to both POSIX and native Microsoft.
2979 (tiff_error_handler, tiff_warning_handler): Use it.
2980 (tiff_load, gif_load, imagemagick_load_image):
2981 Don't assume :index value fits in 'int'.
2982 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2983 (imagemagick_load_image): Check that crop parameters fit into
2984 the integer types that MagickCropImage accepts. Don't assume
2985 Vimagemagick_render_type has a nonnegative value. Don't assume
2986 size_t fits in 'long'.
2987 (gs_load): Use printmax_t to print the widest integers possible.
2988 Check for integer overflow when computing image height and width.
2989
c11821d4
EZ
29902011-08-26 Eli Zaretskii <eliz@gnu.org>
2991
2992 * xdisp.c (redisplay_window): Don't force window start if point
2993 will be invisible in the resulting window. (Bug#9324)
2994
0c95fcf7
EZ
29952011-08-25 Eli Zaretskii <eliz@gnu.org>
2996
2997 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2998 the display spec is of the form `(space ...)'.
2999 (handle_display_spec): Return the value returned by
3000 handle_single_display_spec, not just 1 or zero.
3001 (handle_single_display_spec): If the display spec is of the form
3002 `(space ...)', and specifies display in the text area, return 2
3003 rather than 1.
fee65a97 3004 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3005 accurately, and prefer exact match for point under bidi.
3006 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3007
3008 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3009 into disp_prop; all users changed.
3010
3011 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3012 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3013 for the text covered by the display property.
3014
e4ed06f1
CY
30152011-08-25 Chong Yidong <cyd@stupidchicken.com>
3016
3017 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3018 Change return value to nil.
3019 (Frecord_buffer): Delete unused function.
3020
f67cdd7f
EZ
30212011-08-24 Eli Zaretskii <eliz@gnu.org>
3022
5980d4c6
EZ
3023 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3024 buffers, return left-to-right.
8610fe8b
EZ
3025 (set_cursor_from_row): Consider candidate row a win if its glyph
3026 represents a newline and point is on that newline. Fixes cursor
3027 positioning on the newline at EOL of R2L text within L2R
3028 paragraph, and vice versa.
3029 (try_cursor_movement): Check continued rows, in addition to
3030 continuation rows. Fixes unwarranted scroll when point enters a
3031 continued line of R2L text within an L2R paragraph, or vice versa.
3032 (cursor_row_p): Consider the case of point being equal to
3033 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3034 from the end of a short line to the beginning of a continued line
3035 of R2L text within L2R paragraph.
3036 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3037 composed characters.
5980d4c6 3038
f67cdd7f
EZ
3039 * bidi.c (bidi_check_type): Use xassert.
3040 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3041 members.
3042
bca633fb
EZ
30432011-08-23 Eli Zaretskii <eliz@gnu.org>
3044
3045 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3046 a character.
3047
4a5885a7
CY
30482011-08-23 Chong Yidong <cyd@stupidchicken.com>
3049
3050 * nsfont.m (ns_otf_to_script): Fix typo.
3051
0902a04e
KH
30522011-08-22 Kenichi Handa <handa@m17n.org>
3053
3054 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3055 extra slot even if the purpose is char-code-property-table.
3056
1a2e6670
EZ
30572011-08-23 Eli Zaretskii <eliz@gnu.org>
3058
8ddde651
EZ
3059 * xdisp.c (redisplay_window): When computing centering_position,
3060 account for the height of the header line. (Bug#8874)
3061
425cc014
EZ
3062 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3063 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3064 candidate is selected by the mouse, and that candidate has a
3065 composed character under the mouse.
3066
1a2e6670
EZ
3067 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3068 coordinates reported by pos-visible-in-window-p for a composed
3069 character in column zero.
3070
8b76d6f8
SM
30712011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3072
3073 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3074
dac347dd
EZ
30752011-08-22 Eli Zaretskii <eliz@gnu.org>
3076
3077 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3078 consider it a hit if to_charpos is anywhere in the range of the
3079 composed buffer positions.
3080
e013fb34
CY
30812011-08-22 Chong Yidong <cyd@stupidchicken.com>
3082
3083 * image.c (gif_load): Don't assume that each subimage has the same
3084 dimensions as the base image. Handle disposal method that is
3085 "undefined" by the gif spec (Bug#9335).
3086
bd1ba3e8
CY
30872011-08-20 Chong Yidong <cyd@stupidchicken.com>
3088
3089 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3090 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3091
54a1215b
EZ
30922011-08-19 Eli Zaretskii <eliz@gnu.org>
3093
823564e5
EZ
3094 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3095 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3096 from an Org mode buffer to a Speedbar frame.
3097
54a1215b
EZ
3098 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3099 a composition, take its buffer position from IT->cmp_it.charpos.
3100 Fixes cursor positioning at the beginning of a line that begins
3101 with a composed character.
3102
9778ebcc
EZ
31032011-08-18 Eli Zaretskii <eliz@gnu.org>
3104
0be6ee06
EZ
3105 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3106 character bidirectional type, use STRONG_L instead. Fixes crashes
3107 in a buffer produced by `describe-categories'.
3108
9778ebcc
EZ
3109 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3110 members before the level stack, so they would be saved and
3111 restored when copying iterator state. Fixes incorrect reordering
3112 around TABs covered by display properties.
3113
156bffbe
AS
31142011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3115
6b02f655 3116 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3117
72ad093b
CY
31182011-08-17 Chong Yidong <cyd@stupidchicken.com>
3119
3120 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3121 (internal_condition_case_2, internal_condition_case_n):
3122 Remove unnecessary aborts (Bug#9081).
72ad093b 3123
35774242
EZ
31242011-08-17 Eli Zaretskii <eliz@gnu.org>
3125
3126 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3127 has no `load' handler, try opening the file locally. (Bug#9311)
3128
db76dd85
KB
31292011-08-16 Ken Brown <kbrown@cornell.edu>
3130
3131 * gmalloc.c: Expand comment.
3132
b215eee5
EZ
31332011-08-16 Eli Zaretskii <eliz@gnu.org>
3134
3135 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3136 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3137
a4579d33
KB
31382011-08-16 Ken Brown <kbrown@cornell.edu>
3139
3140 Fix memory allocation problems in Cygwin build (Bug#9273).
3141
3142 * unexcw.c ( __malloc_initialized): Declare external variable.
3143 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3144
8b76d6f8
SM
3145 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3146 New variables.
a4579d33
KB
3147 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3148 dumped emacs.
3149 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3150 in the static heap.
3151 [CYGWIN] (special_realloc): New function.
3152 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3153 requests to realloc storage in the static heap.
3154
3ebec551
PE
31552011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * bidi.c (bidi_initialize): Remove unused local.
3158
9fd8be00
EZ
31592011-08-15 Eli Zaretskii <eliz@gnu.org>
3160
6b02f655
SM
3161 * bidimirror.h:
3162 * biditype.h: Remove file.
3163 * makefile.w32-in ($(BLD)/bidi.$(O)):
3164 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3165
3166 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3167
3168 * chartab.c: Improve commentary for the uniprop_table API.
3169
32413314
EZ
3170 * bidi.c (bidi_paragraph_init): Support zero value of
3171 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3172 (bidi_initialize): Use uniprop_table instead of including
3173 biditype.h and bidimirror.h.
32413314 3174
9fd8be00
EZ
3175 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3176 coordinates of the iterator when restoring from ppos_it.
3177 (Bug#9296)
3178
5cf2b69b
KH
31792011-08-14 Kenichi Handa <handa@m17n.org>
3180
3181 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3182 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3183
daf17d00
EZ
31842011-08-14 Eli Zaretskii <eliz@gnu.org>
3185
3186 * xdisp.c (move_it_in_display_line_to): Don't invoke
3187 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3188 ppos_it. Fixes vertical cursor motion when line beginning is
3189 covered by an image. (Bug#9296)
3190
08e3161a
JD
31912011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3192
3193 * nsterm.h (ns_run_ascript): Declare.
3194 (NSAPP_DATA2_RUNASSCRIPT): Define.
3195
3196 * nsfns.m (as_script, as_result, as_status): New static variables.
3197 (ns_run_ascript): New function.
5e617bc2 3198 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3199 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3200 the event loop. Get status from as_status (Bug#7276).
3201
3202 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3203 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3204 the event loop (Bug#7276).
3205
a3720aa2
AS
32062011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3207
3208 * gnutls.c (QCgnutls_bootprop_priority)
3209 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3210 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3211 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3212 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3213 (QCgnutls_bootprop_verify_hostname_error)
3214 (QCgnutls_bootprop_callbacks_verify): Rename from
3215 Qgnutls_bootprop_..., all uses changed.
3216
3217 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3218 uses changed.
3219
0a0d27fb
PE
32202011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3221
19d5c50c
PE
3222 * xfaces.c (Qframe_set_background_mode): Now static.
3223 * dispextern.h (Qframe_set_background_mode): Remove decl.
3224
0a0d27fb
PE
3225 * process.c (Fnetwork_interface_info): Declare local only if needed.
3226
377538cb
JD
32272011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3228
3229 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3230 (Fnetwork_interface_list): Allocate in increments of bytes instead
3231 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3232 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3233 sockaddr.
3234 (struct ifflag_def): notrailers is smart on OSX.
3235 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3236 Get hardware address with getifaddrs if available.
3237
08fff70c
EZ
32382011-08-12 Eli Zaretskii <eliz@gnu.org>
3239
3240 * xdisp.c (iterate_out_of_display_property): xassert that
3241 IT->position is set to within IT->object's boundaries. Break from
3242 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3243 when IT->position is set up wrongly due to some bug.
3244 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3245 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3246 entry. Force push_it to save on the stack the current
3247 buffer/string position, to be restored by pop_it. Fix flags in
3248 the iterator structure wrt the object coming from a display
3249 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3250 properties. (Bug#9284)
3251
7be1c708 32522011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3253
7be1c708
CY
3254 * fontset.c (fontset_get_font_group): Add proper type checks.
3255 (Bug#9172)
aac0c6e3 3256
7be1c708 32572011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3258
7be1c708
CY
3259 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3260 and LC_VERSION_MIN_MACOSX.
3261 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3262 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3263
97bb72a6
EZ
32642011-08-08 Eli Zaretskii <eliz@gnu.org>
3265
3266 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3267 no-display-properties-and-no-overlays under bidi display.
3268 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3269 properties and overlays.
97bb72a6 3270
d5617611
CY
32712011-08-08 Chong Yidong <cyd@stupidchicken.com>
3272
37e11a63
CY
3273 * editfns.c (Fset_time_zone_rule): Document relationship with the
3274 setenv function.
3275
d5617611
CY
3276 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3277 the font entity extracted from the cache (Bug#8109).
3278
58872834
CY
32792011-08-07 Chong Yidong <cyd@stupidchicken.com>
3280
3281 * composite.c (autocmp_chars): Don't reset point. That is done by
3282 restore_point_unwind (Bug#5984).
3283
75bfc667
JL
32842011-08-07 Juri Linkov <juri@jurta.org>
3285
3286 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3287 to show the arg `TIME' instead of `TIMEVAL'.
3288
d1410150
EZ
32892011-08-06 Eli Zaretskii <eliz@gnu.org>
3290
3291 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3292 display property strides EOL and includes a newline, as in
3293 longlines-mode. (Bug#9254)
75b771e4
EZ
3294 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3295 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3296
3297 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3298 is non-zero, even if the data buffer is NULL. Fixes a crash in
3299 vertical-motion with longlines-mode. (Bug#9254)
3300
35928349
EZ
33012011-08-05 Eli Zaretskii <eliz@gnu.org>
3302
ec7cc85b
EZ
3303 * bidi.c <bidi_cache_total_alloc>: Now static.
3304 (bidi_initialize): Initialize bidi_cache_total_alloc.
3305
8b76d6f8 3306 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3307 cache. (Bug#9221)
3308
3309 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3310 amount allocated this far in `bidi_cache_total_alloc'.
3311 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3312 non-zero, only free the data buffer without restoring the cache
3313 contents. All callers changed.
3314
3315 * dispextern.h (bidi_unshelve_cache): Update prototype.
3316
3317 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3318 (move_it_in_display_line, move_it_to)
3319 (move_it_vertically_backward, move_it_by_lines): Replace the call
3320 to xfree to an equivalent call to bidi_unshelve_cache.
3321 (move_it_in_display_line_to): Fix logic of returning
412b6358 3322 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3323
e2e2423b
EZ
33242011-08-05 Eli Zaretskii <eliz@gnu.org>
3325
3326 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3327 came from a string character with a `cursor' property. (Bug#9229)
3328
ae9e757a
JD
33292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3330
3331 * Makefile.in (LIB_PTHREAD): New variable.
3332 (LIBES): Add LIB_PTHREAD (Bug#9216).
3333
3334 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3335 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3336
213bd7f2
AS
33372011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3338
6b02f655 3339 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3340
99aaf75f
JD
33412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3342
3343 * xterm.c (x_find_topmost_parent): New function.
3344 (x_set_frame_alpha): Find topmost parent window with
3345 x_find_topmost_parent and set the property there also (bug#9181).
3346 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3347
c74e9d86
PE
33482011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 * callproc.c (Fcall_process): Avoid vfork clobbering
3351 the local vars buffer, coding_systems, current_dir.
3352
640c8776
SM
33532011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3354
3355 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3356
f26d0e4c
PE
33572011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3358
8a10d76c
PE
3359 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3360 so that it is not optimized away.
3361
f26d0e4c
PE
3362 * xdisp.c (compute_display_string_pos): Remove unused local.
3363
55439c61
EZ
33642011-08-02 Eli Zaretskii <eliz@gnu.org>
3365
3366 Fix slow cursor motion and scrolling in large buffers with
3367 selective display, like Org Mode buffers. (Bug#9218)
3368
3369 * dispextern.h (struct bidi_it): New member disp_prop_p.
3370
3371 * xdisp.c: Remove one-slot cache of display string positions.
3372 (compute_display_string_pos): Accept an additional argument
5e617bc2 3373 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3374 for a display string or property. If found, set DISP_PROP_P
3375 non-zero.
3376
3377 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3378 DISP_PROP_P, and pass it to compute_display_string_pos.
3379 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3380 non-zero. All callers of bidi_fetch_char changed.
3381
fb33fa43
SM
33822011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3383
3384 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3385
b099e063
DM
33862010-12-03 Don March <don@ohspite.net>
3387
3388 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3389 last character M-[char] is translated to ESC [char] (bug#7541).
3390
5cc7f7af
KH
33912011-08-02 Kenichi Handa <handa@m17n.org>
3392
d0fffa3f 3393 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3394
3395 * chartab.c (uniprop_table): Make it non-static.
3396
525d5e6e
EZ
33972011-08-01 Eli Zaretskii <eliz@gnu.org>
3398
3399 * xdisp.c (forward_to_next_line_start): Accept additional argument
3400 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3401 on the newline.
3402 (reseat_at_next_visible_line_start): Use the bidi iterator state
3403 returned by forward_to_next_line_start to restore the state of
3404 it->bidi_it after backing up to previous newline. (Bug#9212)
3405
31011111
AS
34062011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3407
3408 * regex.c (re_comp): Protoize.
3409 (re_exec): Fix return type.
3410 (regexec): Fix type of `ret'. (Bug#9203)
3411
476371c4
PE
34122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3413
e5d76069
PE
3414 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3415 This is needed if max-image-size is a floating-point number.
3416
9a79b20c
AS
34172011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3418
3419 * print.c (print_object): Print empty symbol as ##.
3420
3421 * lread.c (read1): Read ## as empty symbol.
3422
d8c2fa78
AA
34232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3424
3425 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3426 setting frame foreground color (Bug#9175).
3427 (x_set_background_color): Likewise.
3428
ffe57a7a
AA
3429 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3430 contents (Bug#9176).
3431 (EmacsTooltip -init): Remove bezels and add shadows to
3432 tooltip windows.
3433
bf3492a5
AA
3434 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3435 or scroll bar (Bug#8470).
3436
d55e9c53
AA
3437 * nsfont.m (nsfont_open): Remove assignment to voffset and
3438 unnecessary vars hshink, expand, hd, full_height, min_height.
3439 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3440
3441 * nsterm.h (nsfont_info): Remove voffset field.
3442
d8c2fa78 34432011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3444
3445 Implement strike-through and overline on NextStep (Bug#8863).
3446
3447 * nsfont.m (nsfont_open): Use underline position provided by font,
3448 instead of hard-coded value of 2.
3449 (nsfont_draw): Call ns_draw_text_decoration instead.
3450
3451 * nsterm.h: Add declaration for ns_draw_text_decoration.
3452
3453 * nsterm.m (ns_draw_text_decoration): New function for drawing
3454 underline, overline, and strike-through.
3455 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3456 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3457 accommodate underlining, etc.
4843aac3 3458
4cc60b9b
EZ
34592011-07-28 Eli Zaretskii <eliz@gnu.org>
3460
bc7ece87
EZ
3461 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3462 default.
4cc60b9b 3463
476371c4
PE
34642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3465
66606eea
PE
3466 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3467 Without this fix, if a signal arrives just after memory fills up,
3468 'malloc' might be invoked reentrantly.
3469
476371c4
PE
3470 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3471 In other words, assume that every image size is allowed, on non-X
3472 hosts. This assumption is probably wrong, but it lets Emacs compile.
3473
f3fcc40d
AS
34742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3475
3476 * regex.c (re_iswctype): Convert return values to boolean.
3477
350c992f
EZ
34782011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3479
3480 * xdisp.c (compute_display_string_pos): Don't use cached display
3481 string position if the buffer had its restriction changed.
3482 (Bug#9184)
3483
5266b4bb
PE
34842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3487
2573a837 34882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3489
41f55ccd 3490 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3491
39e378da
PE
3492 * bidi.c: Integer size and overflow fixes.
3493 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3494 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3495 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3496 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3497 (bidi_find_other_level_edge):
3498 Use ptrdiff_t instead of EMACS_INT where either will do.
3499 This works better on 32-bit hosts configured --with-wide-int.
3500 (bidi_cache_ensure_space): Check for size-calculation overflow.
3501 Use % rather than repeated addition, for better worst-case speed.
3502 Don't set bidi_cache_size until after xrealloc returns, because it
3503 might not return.
3504 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3505 (bidi_cache_ensure_space): Also check that the bidi cache size
3506 does not exceed that of the largest Lisp string or buffer. See Eli
3507 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3508
5e927815
PE
3509 * alloc.c (__malloc_size_t): Remove.
3510 All uses replaced by size_t. See Andreas Schwab's note
3511 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3512
ca4aa935
PE
3513 * image.c: Improve checking for integer overflow.
3514 (check_image_size): Assume that f is nonnull, since
3515 it is always nonnull in practice. This is one less thing to
3516 worry about when checking for integer overflow later.
3517 (x_check_image_size): New function, which checks for integer
3518 overflow issues inside X.
3519 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3520 This removes the need for a memory_full check.
3521 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3522 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3523 (xbm_read_bitmap_data): Change locals back to 'int', since
3524 their values must fit in 'int'.
3525 (xpm_load_image, png_load, tiff_load):
3526 Invoke x_create_x_image_and_pixmap earlier,
3527 to avoid much needless work if the image is too large.
3528 (tiff_load): Treat overly large images as if
3529 x_create_x_image_and_pixmap failed, not as malloc failures.
3530 (gs_load): Use x_check_image_size.
3531
5f8f9cc2
PE
3532 * gtkutil.c: Omit integer casts.
3533 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3534 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3535
5adf60bc
PE
3536 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3537
c8907a93
PE
3538 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3539 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3540 would wrongly return t on a 64-bit host.
3541
e3c25c68
PE
3542 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3543 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3544 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3545 and therefore cause GCC to emit a bogus diagnostic in some cases.
3546
3f791afe
PE
3547 * image.c: Integer signedness and overflow and related fixes.
3548 This is not an exhaustive set of fixes, but it's time to
3549 record what I've got.
3550 (lookup_pixel_color, check_image_size): Remove redundant decls.
3551 (check_image_size): Don't assume that arbitrary EMACS_INT values
3552 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3553 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3554 (tiff_load, imagemagick_load_image):
3555 Check for overflow in size calculations.
3556 (x_create_x_image_and_pixmap): Remove unnecessary test for
3557 xmalloc returning NULL; that can't happen.
3558 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3559 (xpm_color_bucket): Use better integer hashing function.
3560 (xpm_cache_color): Don't possibly over-allocate memory.
3561 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3562 (gif_memory_source):
3563 Use ptrdiff_t, not int or size_t, to record sizes.
3564 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3565 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3566 either works, as we prefer signed integers.
3567 (tiff_read_from_memory, tiff_write_from_memory):
3568 Return tsize_t, not size_t, since that's what the TIFF API wants.
3569 (tiff_read_from_memory): Don't fail simply because the read would
3570 go past EOF; instead, return a short read.
3571 (tiff_load): Omit no-longer-needed casts.
3572 (Fimagemagick_types): Don't assume size fits into 'int'.
3573
3cc5a532
PE
3574 Improve hashing quality when configured --with-wide-int.
3575 * fns.c (hash_string): New function, taken from sxhash_string.
3576 Do not discard information about ASCII character case; this
3577 discarding is no longer needed.
3578 (sxhash-string): Use it. Change sig to match it. Caller changed.
3579 * lisp.h: Declare it.
3580 * lread.c (hash_string): Remove, since we now use fns.c's version.
3581 The fns.c version returns a wider integer if --with-wide-int is
3582 specified, so this should help the quality of the hashing a bit.
3583
b312a492
PE
3584 * emacs.c: Integer overflow minor fix.
3585 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3586 Define only if GNU_LINUX.
3587 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3588
dfd153ae
PE
3589 * dispnew.c: Integer signedness and overflow fixes.
3590 Remove unnecessary forward decls, that were a maintenance hassle.
3591 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3592 All uses changed.
3593 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3594 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3595 (prepare_desired_row, line_draw_cost):
3596 Use int, not unsigned, where either works.
3597 (save_current_matrix, restore_current_matrix):
3598 Use ptrdiff_t, not size_t, where either works.
3599 (init_display): Check for overflow more accurately, and without
3600 relying on undefined behavior.
3601
a81d11a3
PE
3602 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3603 Remove, replacing with the new symbols in lisp.h. All uses changed.
3604 * fileio.c (make_temp_name):
3605 * filelock.c (lock_file_1, lock_file):
3606 * xdisp.c (message_dolog):
3607 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3608 Use pMd etc. instead.
3609 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3610 replacing the pWIDE etc. symbols removed from editfns.c.
3611
3300e6fd
PE
3612 * keyboard.h (num_input_events): Now uintmax_t.
3613 This is (very slightly) less likely to mess up due to wraparound.
3614 All uses changed.
3615
fd05c7e9
PE
3616 * buffer.c: Integer signedness fixes.
3617 (alloc_buffer_text, enlarge_buffer_text):
3618 Use ptrdiff_t rather than size_t when either will do, as we prefer
3619 signed integers.
3620
903fe15d
PE
3621 * alloc.c: Integer signedness and overflow fixes.
3622 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3623 (__malloc_size_t): Default to size_t, not to int.
3624 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3625 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3626 Prefer ptrdiff_t to size_t when either would do, as we prefer
3627 signed integers.
3628 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3629 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3630 Now const. Initialize with values that are in range even if char
3631 is signed.
3632 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3633 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3634 These functions do the right thing with sizes > 2**32.
3635 (check_depth): Now ptrdiff_t, not int.
3636 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3637 Adjust to new way of storing sizes. Check for size overflow bugs
3638 in rest of code.
3639 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3640 slightly wrong anyway, as it missed one instance of
3641 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3642 (refill_memory_reserve): Omit needless cast to size_t.
3643 (mark_object_loop_halt): Mark as externally visible.
3644
ac82cc6a
PE
3645 * xselect.c: Integer signedness and overflow fixes.
3646 (Fx_register_dnd_atom, x_handle_dnd_message):
3647 Use ptrdiff_t, not size_t, since we prefer signed.
3648 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3649 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3650 x_dnd_atoms_size and x_dnd_atoms_length.
3651
c2d1e36d
PE
3652 * doprnt.c: Prefer signed to unsigned when either works.
3653 * eval.c (verror):
3654 * doprnt.c (doprnt):
3655 * lisp.h (doprnt):
3656 * xdisp.c (vmessage):
3657 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3658 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3659 prefer signed arithmetic to avoid comparison confusion.
3660 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3661 but is a bit tricky.
3662
0e926e56
PE
3663 Assume freestanding C89 headers, string.h, stdlib.h.
3664 * data.c, doprnt.c, floatfns.c, print.c:
3665 Include float.h unconditionally.
3666 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3667 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3668 * regex.c: Likewise for stddef.h, string.h.
3669 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3670 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3671 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3672 (STDC_HEADERS): Remove obsolete defines.
3673 * sysdep.c: Include limits.h unconditionally.
3674
9cfdb3ec
PE
3675 Assume support for memcmp, memcpy, memmove, memset.
3676 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3677 * regex.c (memcmp, memcpy):
3678 Remove; we assume C89 now.
3679
3680 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3681 (__malloc_safe_bcopy): Remove; no longer needed.
3682
cf950e6b 3683 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3684 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3685 well either way, and we prefer signed to unsigned.
3686
dbf38e02
LMI
36872011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3688
3689 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3690 closes the connection while we're reading (bug#9182).
3691
d6f0886c 36922011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3693
d6f0886c
JD
3694 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3695 are specified (Bug#9168).
24e0f6b1 3696
2eb1f9e6
PE
36972011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3700 Found by GCC static checking and --with-wide-int on a 32-bit host.
3701
22381272 37022011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3703
3704 * xdisp.c (compute_display_string_pos): Fix logic of caching
3705 previous display string position. Initialize cached_prev_pos to
3706 -1. Fixes slow-down at the beginning of a buffer.
3707
f25e39b4
EZ
37082011-07-24 Eli Zaretskii <eliz@gnu.org>
3709
3710 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3711 for attrs[LFACE_FONTSET_INDEX].
3712
04c4b52e
PE
37132011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 * xml.c (parse_region): Remove unused local
3716 that was recently introduced.
3717
c1734fbd
EZ
37182011-07-23 Eli Zaretskii <eliz@gnu.org>
3719
be18c5a5
EZ
3720 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3721 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3722
c1734fbd
EZ
3723 * xdisp.c (move_it_in_display_line_to): Record the best matching
3724 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3725 exit if none of the characters scanned was an exact match.
3726 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3727 when exact match is impossible due to invisible text, and the
3728 lines are truncated.
3729
a258d627
JD
37302011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3731
3732 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3733 for OSX >= 10.7.
3734
b6d5a689
EZ
37352011-07-22 Eli Zaretskii <eliz@gnu.org>
3736
0f74f785
EZ
3737 Fix a significant slow-down of cursor motion with C-n, C-p,
3738 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3739 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3740 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3741 (next_element_from_buffer): Call compute_stop_pos_backwards to
3742 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3743 base_level_stop.
3744 (reseat): Don't look for prev_stop, as that could mean a very long
3745 run.
3746 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3747 <cached_disp_overlay_modiff>: Cache for last found display string
3748 position.
551918c1 3749 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3750 about the same buffer in the same area of character positions, and
3751 the buffer wasn't changed since the time the display string
3752 position was cached.
551918c1 3753
b2d0c91a
EZ
37542011-07-22 Eli Zaretskii <eliz@gnu.org>
3755
3756 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3757 is an integer, which is important for empty lines. (Bug#9149)
3758
043604ee
CY
37592011-07-22 Chong Yidong <cyd@stupidchicken.com>
3760
3761 * frame.c (Fmodify_frame_parameters): In tty case, update the
3762 default face if necessary (Bug#4238).
3763
da4adb04
CY
37642011-07-21 Chong Yidong <cyd@stupidchicken.com>
3765
3766 * editfns.c (Fstring_to_char): No need to explain what a character
3767 is in the docstring (Bug#6576).
3768
9abd0532
LMI
37692011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3770
3771 * xml.c (parse_region): Make sure we always return a tree.
3772
36881d16
HK
37732011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3774
3775 * xml.c (parse_region): If a document contains only comments,
3776 return that, too.
3777
1e98674d
LMI
37782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3779
3780 * xml.c (make_dom): Return comments, too.
3781
590bd467
PE
37822011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 Port to OpenBSD.
3785 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3786 and the surrounding thread.
3787 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3788 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3789 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3790 timer goes off.
3791 * s/openbsd.h (BROKEN_SIGIO): Define.
3792 * unexelf.c (unexec) [__OpenBSD__]:
3793 Don't update the .mdebug section of the Alpha COFF symbol table.
3794
f41628b2
LMI
37952011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3796
3797 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3798 (bug#8460).
3799
b59b67c5
PE
38002011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3801
15e3a074
PE
3802 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3803 This fixes some race conditions on the permissions of any newly
3804 created file.
3805
41bed37d
PE
3806 * alloc.c (valid_pointer_p): Use pipe, not open.
3807 This fixes some permissions issues when debugging.
3808
b59b67c5
PE
3809 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3810 If fchown fails to set both uid and gid, try to set just gid,
3811 as that is sometimes allowed. Adjust the file's mode to eliminate
3812 setuid or setgid bits that are inappropriate if fchown fails.
3813
925a6be7
SM
38142011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3815
3816 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3817 to compare Lisp_Objects.
3818 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3819 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3820 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3821
52968808
AS
38222011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3823
0a6a104b
AS
3824 * lread.c (read_integer): Unread even EOF character.
3825 (read1): Likewise. Properly record start position of symbol.
3826
52968808
AS
3827 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3828 symbol character follows.
3829
9e381cdd
PE
38302011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3833 This works around a problem with the previous change to Fcopy_file.
3834 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3835 and without this change, GCC might complain about discarding
3836 fchown's return value.
3837
b5641435
JB
38382011-07-16 Juanma Barranquero <lekktu@gmail.com>
3839
3840 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3841
a8031457
PE
38422011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3845
dd889327
LMI
38462011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3847
750c33f7
LMI
3848 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3849 it's used from the C level.
3850
dd889327
LMI
3851 * process.c: Use the same condition for POLL_FOR_INPUT in both
3852 keyboard.c and process.c (bug#1858).
3853
87e86684
LM
38542011-07-09 Lawrence Mitchell <wence@gmx.li>
3855
3856 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3857 (Fgnutls_boot): Use it.
3858
64348f40
AS
38592011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3860
3861 * doc.c (Fsubstitute_command_keys): Revert last change.
3862
1d698799
LMI
38632011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3864
f863868c
LMI
3865 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3866 quotes the next character, and doesn't affect other longer
3867 sequences (bug#8935).
3868
1d698799
LMI
3869 * lread.c (syms_of_lread): Clarify that is isn't only
3870 `eval-buffer' and `eval-defun' that's affected by
3871 `lexical-binding' (bug#8460).
3872
aa4b6df6
EZ
38732011-07-15 Eli Zaretskii <eliz@gnu.org>
3874
3875 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3876 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3877
5d856da6
PE
38782011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3879
ad6042bb
PE
3880 Fix minor problems found by static checking.
3881 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3882 (elsz): Now a signed constant, not a size_t var. We prefer signed
3883 types to unsigned, to avoid integer comparison confusion. Without
3884 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3885 "cannot optimize loop, the loop counter may overflow", a symptom
3886 of the confusion.
f00bbb22 3887 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3888 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3889
6468f31c
LMI
38902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3891
49080b10
LMI
3892 * search.c (Fre_search_backward): Mention `case-fold-search' in
3893 all the re_search_* functions (bug#8138).
3894
6468f31c
LMI
3895 * keyboard.c (Fopen_dribble_file): Document when the file is
3896 closed (bug#8056).
3897
c965adc5
EZ
38982011-07-14 Eli Zaretskii <eliz@gnu.org>
3899
df9733bf
EZ
3900 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3901 bidi_cache_idx.
3902
0bb23927
EZ
3903 Support bidi reordering of display and overlay strings.
3904 * xdisp.c (compute_display_string_pos)
3905 (compute_display_string_end): Accept additional argument STRING.
3906 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3907 (reseat_to_string): Initialize bidi_it->string.s and
3908 bidi_it->string.schars.
3909 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3910 NULL (avoids a crash in bidi_paragraph_init).
3911 Initialize itb.string.lstring.
0bb23927
EZ
3912 (init_iterator): Call bidi_init_it only of a valid
3913 buffer position was specified. Initialize paragraph_embedding to
3914 L2R.
3915 (reseat_to_string): Initialize the bidi iterator.
3916 (display_string): If we need to ignore text properties of
3917 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3918 original value of -1 will not work with bidi.)
3919 (compute_display_string_pos): First arg is now struct
3920 `text_pos *'; all callers changed. Support display properties on
3921 Lisp strings.
3922 (compute_display_string_end): Support display properties on Lisp
3923 strings.
3924 (init_iterator, reseat_1, reseat_to_string): Initialize the
3925 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3926 when iterating on a string not from display properties).
640c8776
SM
3927 (compute_display_string_pos, compute_display_string_end):
3928 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3929 arrow keys.
3930 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3931 base_level_stop; instead, set base_level_stop to BEGV.
3932 Fixes crashes in vertical-motion.
0bb23927
EZ
3933 (next_element_from_buffer): Improve commentary for when
3934 the iterator is before prev_stop.
3935 (init_iterator): Initialize bidi_p from the default value of
3936 bidi-display-reordering, not from buffer-local value. Use the
3937 buffer-local value only if initializing for buffer iteration.
3938 (handle_invisible_prop): Support invisible properties on strings
3939 that are being bidi-reordered.
3940 (set_iterator_to_next): Support bidi reordering of C strings and
3941 Lisp strings.
3942 (next_element_from_string): Support bidi reordering of Lisp
3943 strings.
3944 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3945 (display_string): Support display of R2L glyph rows.
3946 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3947 (init_iterator): Don't initialize it->bidi_p for strings
3948 here.
3949 (reseat_to_string): Initialize it->bidi_p for strings here.
3950 (next_element_from_string, next_element_from_c_string)
3951 (next_element_from_buffer): Add xassert's for correspondence
3952 between IT's object being iterated and it->bidi_it.string
3953 structure.
3954 (face_before_or_after_it_pos): Support bidi iteration.
3955 (next_element_from_c_string): Handle the case of the first string
3956 character that is not the first one in the visual order.
3957 (get_visually_first_element): New function, refactored from common
3958 parts of next_element_from_buffer, next_element_from_string, and
3959 next_element_from_c_string.
3960 (tool_bar_lines_needed, redisplay_tool_bar)
3961 (display_menu_bar): Force left-to-right direction. Add a FIXME
3962 comment for making that be controlled by a user option.
3963 (push_it, pop_it): Save and restore the state of the
3964 bidi iterator. Save and restore the bidi_p flag.
3965 (pop_it): Iterate out of display property for string iteration as
3966 well.
3967 (iterate_out_of_display_property): Support iteration over strings.
3968 (handle_single_display_spec): Set up it->bidi_it for iteration
3969 over a display string, and call bidi_init_it.
3970 (handle_single_display_spec, next_overlay_string)
3971 (get_overlay_strings_1, push_display_prop): Set up the bidi
3972 iterator for displaying display or overlay strings.
3973 (forward_to_next_line_start): Don't use the shortcut if
3974 bidi-iterating.
3975 (back_to_previous_visible_line_start): If handle_display_prop
3976 pushed the iterator stack, restore the internal state of the bidi
3977 iterator by calling bidi_pop_it same number of times.
3978 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3979 and we are bidi-iterating, don't decrement the iterator position;
3980 instead, set the first_elt flag in the bidi iterator, to produce
3981 the same effect.
3982 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3983 (push_display_prop): xassert that we are iterating a buffer.
3984 (push_it, pop_it): Save and restore paragraph_embedding member.
3985 (handle_single_display_spec, next_overlay_string)
3986 (get_overlay_strings_1, reseat_1, reseat_to_string)
3987 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3988 correctly. Don't assume unibyte strings are not bidi-reordered.
3989 (compute_display_string_pos)
3990 (compute_display_string_end): Fix handling the case of C string.
3991 (push_it, pop_it): Save and restore from_disp_prop_p.
3992 (handle_single_display_spec, push_display_prop): Set the
3993 from_disp_prop_p flag.
3994 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3995 (pop_it): Call iterate_out_of_display_property only if we are
3996 popping after iteration over a string that came from a display
3997 property. Fix a typo in popping stretch info. Add an assertion
3998 for verifying that the iterator position is in sync with the bidi
3999 iterator.
4000 (handle_single_display_spec, get_overlay_strings_1)
4001 (push_display_prop): Fix initialization of paragraph direction for
4002 string when that of the parent object is not yet determined.
4003 (reseat_1): Call bidi_init_it to resync the bidi
4004 iterator with IT's position. (Bug#7616)
4005 (find_row_edges): If ROW->start.pos gives position
4006 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4007 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4008 Reset the from_disp_prop_p flag.
4009 (SAVE_IT, RESTORE_IT): New macros.
4010 (pos_visible_p, face_before_or_after_it_pos)
4011 (back_to_previous_visible_line_start)
4012 (move_it_in_display_line_to, move_it_in_display_line)
4013 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4014 (try_scrolling, redisplay_window, display_line): Use them when
4015 saving a temporary copy of the iterator and restoring it back.
4016 (back_to_previous_visible_line_start, reseat_1)
4017 (init_iterator): Empty the bidi cache "stack".
4018 (move_it_in_display_line_to): If iterator ended up at
4019 EOL, but we never saw any buffer positions smaller than
4020 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4021 motion in bidi-reordered lines.
4022 (move_it_in_display_line_to): Record prev_method and prev_pos
4023 immediately before the call to set_iterator_to_next. Fixes cursor
4024 motion in bidi-reordered lines with stretch glyphs and strings
4025 displayed in margins. (Bug#8133) (Bug#8867)
4026 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4027 TO_CHARPOS.
640c8776
SM
4028 (pos_visible_p): Support positions in bidi-reordered lines.
4029 Save and restore bidi cache.
0bb23927
EZ
4030
4031 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4032 (bidi_paragraph_info): Delete unused struct.
4033 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4034 (bidi_cache_start): New variable.
4035 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4036 to zero.
4037 (bidi_cache_fetch_state, bidi_cache_search)
4038 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4039 (bidi_cache_find, bidi_peek_at_next_level)
4040 (bidi_level_of_next_char, bidi_find_other_level_edge)
4041 (bidi_move_to_visually_next): Compare cache index with
4042 bidi_cache_start rather than with zero.
4043 (bidi_fetch_char): Accept new argument STRING; all callers
4044 changed. Support iteration over a string. Support strings with
4045 display properties. Support unibyte strings. Fix the type of
4046 `len' according to what STRING_CHAR_AND_LENGTH expects.
4047 (bidi_paragraph_init, bidi_resolve_explicit_1)
4048 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4049 (bidi_level_of_next_char, bidi_move_to_visually_next):
4050 Support iteration over a string.
0bb23927
EZ
4051 (bidi_set_sor_type, bidi_resolve_explicit_1)
4052 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4053 can now be zero (for strings); special values 0 and -1 were
4054 changed to -1 and -2, respectively.
4055 (bidi_char_at_pos): New function.
4056 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4057 Call it instead of FETCH_MULTIBYTE_CHAR.
4058 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4059 initialized to valid values.
4060 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4061 values.
4062 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4063 the test for valid cached positions. Fix the logic for looking up
4064 the sentinel state in the cache. GCPRO the Lisp string we are
4065 iterating.
4066 (bidi_push_it, bidi_pop_it): New functions.
4067 (bidi_initialize): Initialize the bidi cache start stack pointer.
4068 (bidi_cache_ensure_space): New function, refactored from part of
4069 bidi_cache_iterator_state. Don't assume the required size is just
4070 one BIDI_CACHE_CHUNK away.
4071 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4072 (bidi_count_bytes, bidi_char_at_pos): New functions.
4073 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4074 always valid if bidi_cache_idx is valid.
4075 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4076 is valid if it's going to be used.
4077 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4078 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4079 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4080 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4081 (bidi_find_other_level_edge, bidi_cache_start_stack):
4082 All variables related to cache indices are now EMACS_INT.
c965adc5 4083
0bb23927
EZ
4084 * dispextern.h (struct bidi_string_data): New structure.
4085 (struct bidi_it): New member `string'. Make flag members be 1-bit
4086 fields, and put them last in the struct.
640c8776
SM
4087 (compute_display_string_pos, compute_display_string_end):
4088 Update prototypes.
0bb23927
EZ
4089 (bidi_push_it, bidi_pop_it): Add prototypes.
4090 (struct iterator_stack_entry): New members bidi_p,
4091 paragraph_embedding, and from_disp_prop_p.
4092 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4093 (bidi_shelve_cache, bidi_unshelve_cache):
4094 Declare prototypes.
0bb23927
EZ
4095
4096 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4097 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4098 and vector-like objects.
4099
4100 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4101 cache around display iteration.
4102
4103 * window.c (Fwindow_end, window_scroll_pixel_based)
4104 (displayed_window_lines, Frecenter): Save and restore the bidi
4105 cache around display iteration.
4106
3bbd2265
LMI
41072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4108
4109 * editfns.c (Fdelete_region): Clarify the use of the named
4110 parameters (bug#6788).
4111
adc47434
MR
41122011-07-14 Martin Rudalics <rudalics@gmx.at>
4113
4114 * indent.c (Fvertical_motion): Set and restore w->pointm when
4115 saving and restoring the window's buffer (Bug#9006).
4116
837c31f8
LMI
41172011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4118
4119 * editfns.c (Fstring_to_char): Clarify just what is returned
4120 (bug#6576). Text by Eli Zaretskii.
4121
ac389d0c
JB
41222011-07-13 Juanma Barranquero <lekktu@gmail.com>
4123
4124 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4125
0be0ce47
EZ
41262011-07-13 Eli Zaretskii <eliz@gnu.org>
4127
4128 * buffer.c (mmap_find): Fix a typo.
4129
cd18e7e3
JB
41302011-07-13 Johan Bockgård <bojohan@gnu.org>
4131
4132 Fix execution of x selection hooks.
4133 * xselect.c (Qx_lost_selection_functions)
4134 (Qx_sent_selection_functions): New vars.
4135 (syms_of_xselect): DEFSYM them.
4136 (x_handle_selection_request): Pass Qx_sent_selection_functions
4137 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4138 (x_handle_selection_clear,x_clear_frame_selections):
4139 Pass Qx_lost_selection_functions rather than
4140 Vx_lost_selection_functions to Frun_hook_with_args.
4141
47ea7f44
PE
41422011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4143
ac389d0c 4144 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4145 The old code sometimes used this field without initializing it.
4146
47ea7f44
PE
4147 * alloc.c (gc_sweep): Don't read past end of array.
4148 In theory, the old code could also have corrupted Emacs internals,
4149 though it'd be very unlikely.
4150
bc985c87
AS
41512011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4152
4153 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4154 argument. (Bug#4026)
bc985c87 4155
0cf34688
LMI
41562011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157
b3dadd76
LMI
4158 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4159 key" (bug#4257).
4160
0cf34688
LMI
4161 * window.c (Fset_window_start): Doc fix (bug#4199).
4162 (Fset_window_hscroll): Ditto.
4163
270768cd
PE
41642011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4165
077e3dda 4166 Fix minor new problems caught by GCC 4.6.1.
270768cd 4167 * term.c (init_tty): Remove unused local.
490011a6 4168 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4169 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4170 not used otherwise.
270768cd 4171
b1f58454
CY
41722011-07-12 Chong Yidong <cyd@stupidchicken.com>
4173
4174 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4175
22b9578d
LMI
41762011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4177
6e70ab07
LMI
4178 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4179 are the mini-buffer and the echo area (bug#3320).
4180
22b9578d
LMI
4181 * term.c (init_tty): Remove support for supdup, c10 and perq
4182 terminals, which are no longer supported (bug#1482).
4183
8974cc9f
JB
41842011-07-10 Johan Bockgård <bojohan@gnu.org>
4185
4186 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4187
a560d974
JD
41882011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4189
4190 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4191 for non-popups (Bug#3642).
4192
1dae0f0a
AS
41932011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4194
268c2c36 4195 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4196 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4197 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4198 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4199 * data.c (fmod): Likewise.
4200 * dispnew.c (swap_glyphs_in_rows): Likewise.
4201 * emacs.c (memory_warning_signal): Likewise.
4202 * floatfns.c (float_error): Likewise.
4203 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4204 (otf_open, font_otf_capability, generate_otf_features)
4205 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4206 Likewise.
4207 * image.c (pbm_read_file): Likewise.
4208 * indent.c (string_display_width): Likewise.
4209 * intervals.c (check_for_interval, search_for_interval)
4210 (inc_interval_count, count_intervals, root_interval)
4211 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4212 * lread.c (defalias): Likewise.
268c2c36 4213 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4214 * regex.c (set_image_of_range_1, set_image_of_range)
4215 (regex_grow_registers): Likewise.
4216 * sysdep.c (strerror): Likewise.
4217 * termcap.c (valid_filename_p, tprint, main): Likewise.
4218 * tparam.c (main): Likewise.
4219 * unexhp9k800.c (run_time_remap, save_data_space)
4220 (update_file_ptrs, read_header, write_header, calculate_checksum)
4221 (copy_file, copy_rest, display_header): Likewise.
4222 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4223 Likewise.
4224 * xdisp.c (check_it): Likewise.
4225 * xfaces.c (register_color, unregister_color, unregister_colors):
4226 Likewise.
4227 * xfns.c (print_fontset_result): Likewise.
4228 * xrdb.c (member, fatal, main): Likewise.
4229
99033785
PE
42302011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4231
4232 Fix minor problems found by static checking (Bug#9031).
4233 * chartab.c (char_table_set_range, map_sub_char_table):
4234 Remove unused locals.
4235 (uniprop_table): Now static.
4236 * composite.c (_work_char): Remove unused static var.
4237
9cb2ac56
JB
42382011-07-09 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4241
f25661f0
JD
42422011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4243
4244 * gtkutil.c (qttip_cb): Remove code without function.
4245
8278c4fe
EZ
42462011-07-09 Eli Zaretskii <eliz@gnu.org>
4247
4248 * w32.c (pthread_sigmask): New stub.
4249
1692ae2d 42502011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4251
8a6ebd58 4252 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4253 sigprocmask is portable only for single-threaded applications, and
4254 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4255 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4256 (LIBES): Use it.
4257 * callproc.c (Fcall_process):
4258 * process.c (create_process):
4259 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4260 Use pthread_sigmask, not sigprocmask.
123403e4 4261
1b854618
JD
42622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4263
4264 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4265 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4266 wrong (Bug#8591).
4267
3fe4b549
JD
42682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4269
0ce7e563
JD
4270 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4271 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4272 (xg_hide_tooltip): Fix comment.
4273
3fe4b549
JD
4274 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4275 in registerServicesMenuSendTypes.
4276 (validRequestorForSendType): Don't check ns_return_types.
4277
4278 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4279 ns_return_type.
4280
5df75e47
JR
42812011-07-08 Jason Rumney <jasonr@gnu.org>
4282
22610910
JR
4283 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4284 SH_SHOW for hidden windows (Bug#5482).
4285
5df75e47
JR
4286 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4287 frame struct members of non-existent frames (Bug#6284).
4288
699c10bd
JD
42892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4290
4393663b
JD
4291 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4292 variable firstTime not needed on OSX >= 10.6.
4293 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4294 >= 10.5. Use setKnobProportion, setDoubleValue.
4295
4296 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4297 (MAC_OS_X_VERSION_10_5): Define if not defined.
4298 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4299 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4300 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4301
4302 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4303 cString and lossyCString on OSX >= 10.4
4304
58179cce 4305 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4306 sizeToFit on OSX >= 10.2.
4307
4308 * nsimage.m (allocInitFromFile): Don't use deprecated method
4309 bestRepresentationForDevice on OSX >= 10.6.
4310
4311 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4312 to avoid warning.
4313
4314 * emacs.c: Declare unexec_init_emacs_zone.
4315
a63e0781
JD
4316 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4317
699c10bd
JD
4318 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4319
4320 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4321 on svcsMenu (Bug#8842).
4322
4323 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4324 ns_return_types.
4325 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4326
4327 * nsterm.m (QUTF8_STRING): Declare.
4328 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4329 (validRequestorForSendType): Return type is (id).
4330 Change indexOfObjectIdenticalTo to indexOfObject.
4331 Check if we have local selection before returning self (Bug#8842).
4332 (writeSelectionToPasteboard): Put local selection into paste board
4333 if we have a local selection (Bug#8842).
4334 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4335
4336 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4337 (ns_get_local_selection): Declare.
4338
54e10184
LMI
43392011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4340
9888ff71
LMI
4341 * keymap.c (describe_map_tree): Don't insert a double newline at
4342 the end of the buffer (bug#1169) and return whether we inserted
4343 something.
4344
54e10184
LMI
4345 * callint.c (Fcall_interactively): Change "reading args" to
4346 "providing args" to try to clarify what it does (bug#1010).
4347
15fa4783
KH
43482011-07-07 Kenichi Handa <handa@m17n.org>
4349
4350 * composite.c (composition_compute_stop_pos): Ignore a static
4351 composition starting before CHARPOS (Bug#8915).
4352
4353 * xdisp.c (handle_composition_prop): Likewise.
4354
a8815b00
EZ
43552011-07-07 Eli Zaretskii <eliz@gnu.org>
4356
4357 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4358 (Bug#9015)
4359
ef7b981d 43602011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4361
4362 * character.h (unicode_category_t): New enum type.
4363
4364 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4365 (Qchar_code_property_table): New variable.
4366 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4367 (UNIPROP_COMPRESSED_FORM_P): New macros.
4368 (char_table_ascii): Uncompress the compressed values.
4369 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4370 Uncompress the compressed values.
ac389d0c 4371 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4372 (char_table_ref_and_range): Uncompress the compressed values.
4373 (sub_char_table_set): New arg is_uniprop. Callers changed.
4374 Uncompress the compressed values.
4375 (sub_char_table_set_range): Args changed. Callers changed.
4376 (char_table_set_range): Adjuted for the above change.
4377 (map_sub_char_table): Delete args default_val and parent. Add arg
4378 top. Give decoded values to a Lisp function.
640c8776 4379 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4380 values to a Lisp function. Gcpro more variables.
4381 (uniprop_table_uncompress)
4382 (uniprop_decode_value_run_length): New functions.
4383 (uniprop_decoder, uniprop_decoder_count): New variables.
4384 (uniprop_get_decoder, uniprop_encode_value_character)
4385 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4386 New functions.
4387 (uniprop_encoder, uniprop_encoder_count): New variables.
4388 (uniprop_get_encoder, uniprop_table)
4389 (Funicode_property_table_internal, Fget_unicode_property_internal)
4390 (Fput_unicode_property_internal): New functions.
4391 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4392 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4393 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4394 char-code-property-alist.
4395
640c8776 4396 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4397 Vunicode_category_table.
4398
640c8776 4399 * font.c (font_range): Adjust for the change of
c805dec0
KH
4400 Vunicode_category_table.
4401
76b397fb
DN
44022011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4403
4404 * m/iris4d.h: Remove file, move contents ...
4405 * s/irix6-5.h: ... here.
4406
22b4128e
PE
44072011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4408
4409 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4410 * alloc.c (mark_buffer):
4411 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4412 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4413 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4414 This isn't true in general, and it's particularly not true
4415 if Emacs is configured with --with-wide-int.
4416 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4417 New macros, used in the buffer.c change.
4418
869795d6
JD
44192011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4420
4421 * xsettings.c: Use both GConf and GSettings if both are available.
4422 (store_config_changed_event): Add comment.
4423 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4424 (store_tool_bar_style_changed): New functions.
5e617bc2 4425 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4426 (struct xsettings): Move font inside HAVE_XFT.
4427 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4428 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4429 Move inside HAVE_XFT.
640c8776 4430 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4431 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4432 also.
4433 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4434 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4435 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4436 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4437 (parse_settings): Move check for font inside HAVE_XFT.
4438 (read_settings, apply_xft_settings): Add comment.
4439 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4440 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4441 call store_font_name_changed.
4442 (xft_settings_event): Add comment.
4443 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4444 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4445 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4446 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4447 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4448 (xsettings_get_system_font, xsettings_get_system_normal_font):
4449 Add comment.
869795d6 4450
d8ed26bd
PE
44512011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 Random fixes. E.g., (random) never returned negative values.
4454 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4455 subseconds part to the entropy, as that's a bit more random.
4456 Prefer signed to unsigned, since the signedness doesn't matter and
4457 in general we prefer signed. When given a limit, use a
4458 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4459 latter isn't right if USE_2_TAGS_FOR_INTS.
4460 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4461 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4462
cabf1cac
SM
44632011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4464
4465 * textprop.c (text_property_stickiness):
4466 Obey Vtext_property_default_nonsticky.
4467 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4468 * w32fns.c (syms_of_w32fns):
4469 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4470
6e9b2be9
PE
44712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4472
4473 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4474 This is more efficient than Ffile_directory_p and avoids a minor race.
4475
90186c68
LMI
44762011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4477
7c301272
LMI
4478 * buffer.c (Foverlay_put): Say what the return value is
4479 (bug#7835).
4480
c4f2d8d4
LMI
4481 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4482 is a directory before asking whether to use the file name
4483 (bug#7564).
ad637907
LMI
4484 (barf_or_query_if_file_exists): Make the "File is a directory"
4485 error be more correct.
c4f2d8d4 4486
90186c68
LMI
4487 * fns.c (Frequire): Remove the mention of the .gz files, since
4488 that's installation-specific, but keep the mention of
4489 `get-load-suffixes'.
4490
da64016e
PE
44912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4492
4493 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4494 Report string overflow if the output is too long.
4495
7d47b580
JB
44962011-07-04 Juanma Barranquero <lekktu@gmail.com>
4497
a555cb87
JB
4498 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4499 (syms_of_gnutls): Remove duplicate DEFSYM for
4500 Qgnutls_bootprop_verify_hostname_error, an error for
4501 Qgnutls_bootprop_verify_error (which is no longer used).
4502
7d47b580
JB
4503 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4504 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4505 Also (re)move comments that are misplaced or no longer relevant.
4506
1e49bfab
LMI
45072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4508
4509 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4510
1485f4c0
CY
45112011-07-03 Chong Yidong <cyd@stupidchicken.com>
4512
4513 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4514 and background color parameters if they have been changed.
4515
a9ab721e
LMI
45162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4517
4518 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4519
cf7cff57
PE
45202011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4521
2e13213d
PE
4522 * xsettings.c (SYSTEM_FONT): Define only when used.
4523 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4524
cf7cff57
PE
4525 * keymap.c (access_keymap_1): Now static.
4526
7a8e04f7
CY
45272011-07-02 Chong Yidong <cyd@stupidchicken.com>
4528
4529 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4530 leave any prefix arg for the up event (Bug#1586).
4531
61352f62
LMI
45322011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4533
69bb1ef7
LMI
4534 * lread.c (syms_of_lread): Mention single symbols defined by
4535 `defvar' or `defconst' (bug#7154).
4536
61352f62 4537 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4538 (Frequire): Mention get-load-suffixes.
61352f62 4539
28545e04
MR
45402011-07-02 Martin Rudalics <rudalics@gmx.at>
4541
4542 * window.h (window): Remove clone_number slot.
4543 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4544 Remove.
4545 (make_parent_window, make_window, saved_window)
4546 (Fset_window_configuration, save_window_save): Don't deal with
4547 clone numbers.
4548 * buffer.c (Qclone_number): Remove declaration.
4549 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4550
3349e122
SM
45512011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4552
4553 Add multiple inheritance to keymaps.
4554 * keymap.c (Fmake_composed_keymap): New function.
4555 (Fset_keymap_parent): Simplify.
4556 (fix_submap_inheritance): Remove.
4557 (access_keymap_1): New function extracted from access_keymap to handle
4558 embedded parents and handle lists of maps.
4559 (access_keymap): Use it.
4560 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4561 (Fcopy_keymap): Handle embedded parents.
4562 (Fcommand_remapping, define_as_prefix): Simplify.
4563 (Fkey_binding): Simplify.
4564 (syms_of_keymap): Move minibuffer-local-completion-map,
4565 minibuffer-local-filename-completion-map,
4566 minibuffer-local-must-match-map, and
4567 minibuffer-local-filename-must-match-map to Elisp.
4568 (syms_of_keymap): Defsubr make-composed-keymap.
4569 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4570 (parse_menu_item): Trivial simplification.
4571
3279eb87
GM
45722011-07-01 Glenn Morris <rgm@gnu.org>
4573
4574 * Makefile.in (SETTINGS_LIBS): Fix typo.
4575
4550efdf
KI
45762011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4577
4578 * coding.c (Fencode_coding_string): Record the last coding system
4579 used, as the function doc string says (bug#8738).
4580
0949d2b6
JD
45812011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4582
4583 * xsettings.c (store_monospaced_changed): Take new font as arg and
4584 check for change against current_mono_font.
4585 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4586 (emacs_settings_constructor, emacs_settings_get_property)
4587 (emacs_settings_set_property, emacs_settings_class_init)
4588 (emacs_settings_init, gsettings_obj): Remove.
4589 (something_changedCB): New function for HAVE_GSETTINGS.
4590 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4591 with value as argument.
4592 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4593 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4594 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4595 "changed".
4596
4597 * xgselect.c: Add defined (HAVE_GSETTINGS).
4598 (xgselect_initialize): Ditto.
4599
4600 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4601 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4602 xg_select.
4603
bbc6b304
PE
46042011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4605
4606 * eval.c (struct backtrace): Simplify and port the data structure.
4607 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4608 signed bit field, as this assumption is not portable and it makes
4609 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4610 "char debug_on_exit : 1" as this is not portable either; instead,
4611 use the portable "unsigned int debug_on_exit : 1". Remove unused
4612 member evalargs. Remove obsolete comments about cc bombing out.
4613
9851bfc5
JD
46142011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4615
51bb811f 4616 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4617 Let HAVE_GSETTINGS override HAVE_GCONF.
4618 (store_monospaced_changed): New function.
4619 (EMACS_SETTINGS): A new type derived from GObject to handle
4620 GSettings notifications.
4621 (emacs_settings_constructor, emacs_settings_get_property)
4622 (emacs_settings_set_property, emacs_settings_class_init):
4623 New functions.
4624 (gsettings_client, gsettings_obj): New variables.
4625 (GSETTINGS_SCHEMA): New define.
4626 (something_changedCB): Call store_monospaced_changed.
4627 (init_gsettings): New function.
4628 (xsettings_initialize): Call init_gsettings.
4629 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4630 to NULL.
4631
640c8776 4632 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4633 GCONF_CFLAGS/LIBS.
4634
5386012d
MR
46352011-06-29 Martin Rudalics <rudalics@gmx.at>
4636
4637 * window.c (resize_root_window, grow_mini_window)
4638 (shrink_mini_window): Rename Qresize_root_window to
4639 Qwindow_resize_root_window and Qresize_root_window_vertically to
4640 Qwindow_resize_root_window_vertically.
4641
f13e0b08
PE
46422011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4643
4644 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4645
94515237
JB
46462011-06-27 Juanma Barranquero <lekktu@gmail.com>
4647
4648 * makefile.w32-in: Redesign dependencies so they reflect more
4649 clearly which files are directly included by each source file,
4650 and not through other includes.
4651
e43b6e43
MR
46522011-06-27 Martin Rudalics <rudalics@gmx.at>
4653
4654 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4655 (sort_overlays, overlay_strings): When an overlay's clone number
4656 matches the window's clone number process the overlay even if
4657 the overlay's window property doesn't match the current window.
4658
d68443dc
MR
4659 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4660 (Fwindow_hchild): Rename to Fwindow_left_child.
4661 (Fwindow_next): Rename to Fwindow_next_sibling.
4662 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4663 (resize_window_check): Rename to window_resize_check.
4664 (resize_window_apply): Rename to window_resize_apply.
4665 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4666 (Fdelete_other_windows_internal, resize_frame_windows)
4667 (Fsplit_window_internal, Fdelete_window_internal)
4668 (grow_mini_window, shrink_mini_window)
4669 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4670
c7e73be5
JD
46712011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4672
4673 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4674 (emacs_fixed_set_min_size): Remove.
4675 (emacs_fixed_new): Take frame as argument.
4676
4677 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4678 (_EmacsFixedPrivate): Remove minwidth/height.
4679 Add struct frame *f.
4680 (emacs_fixed_init): Initialize priv->f.
4681 (get_parent_class, emacs_fixed_set_min_size): Remove.
4682 (emacs_fixed_new): Set priv->f to argument.
4683 (emacs_fixed_get_preferred_width)
4684 (emacs_fixed_get_preferred_height): Use min_width/height from
4685 frames size_hint to set minimum and natural (Bug#8919).
4686 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4687 and use min_width/height from frames size_hint to set
4688 min_width/height (Bug#8919).
4689
4690 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4691 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4692 Fix indentation.
c7e73be5 4693
cf99dcf8
EZ
46942011-06-26 Eli Zaretskii <eliz@gnu.org>
4695
4696 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4697 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4698 called at ZV.
4699
029529ac
CY
47002011-06-26 Chong Yidong <cyd@stupidchicken.com>
4701
4702 * process.c (wait_reading_process_output): Bypass select if
4703 waiting for a cell while ignoring keyboard input, and input is
4704 pending. Suggested by Jan Djärv (Bug#8869).
4705
7a7ef429
PE
47062011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4707
4708 Use gnulib's dup2 module instead of rolling our own.
4709 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4710
11fdef7d 47112011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4712
4713 * dispnew.c (scrolling_window): Before scrolling, turn off a
4714 mouse-highlight in the window being scrolled.
4715
cd3520a4
JB
47162011-06-24 Juanma Barranquero <lekktu@gmail.com>
4717
4718 Move DEFSYM to lisp.h and use everywhere.
4719
4720 * character.h (DEFSYM): Move declaration...
4721 * lisp.h (DEFSYM): ...here.
4722
4723 * gnutls.c:
4724 * minibuf.c:
4725 * w32menu.c:
4726 * w32proc.c:
4727 * w32select.c: Don't include character.h.
4728
4729 * alloc.c (syms_of_alloc):
4730 * buffer.c (syms_of_buffer):
4731 * bytecode.c (syms_of_bytecode):
4732 * callint.c (syms_of_callint):
4733 * casefiddle.c (syms_of_casefiddle):
4734 * casetab.c (init_casetab_once):
4735 * category.c (init_category_once, syms_of_category):
4736 * ccl.c (syms_of_ccl):
4737 * cmds.c (syms_of_cmds):
4738 * composite.c (syms_of_composite):
4739 * dbusbind.c (syms_of_dbusbind):
4740 * dired.c (syms_of_dired):
4741 * dispnew.c (syms_of_display):
4742 * doc.c (syms_of_doc):
4743 * editfns.c (syms_of_editfns):
4744 * emacs.c (syms_of_emacs):
4745 * eval.c (syms_of_eval):
4746 * fileio.c (syms_of_fileio):
4747 * fns.c (syms_of_fns):
4748 * frame.c (syms_of_frame):
4749 * fringe.c (syms_of_fringe):
4750 * insdel.c (syms_of_insdel):
4751 * keymap.c (syms_of_keymap):
4752 * lread.c (init_obarray, syms_of_lread):
4753 * macros.c (syms_of_macros):
4754 * msdos.c (syms_of_msdos):
4755 * print.c (syms_of_print):
4756 * process.c (syms_of_process):
4757 * search.c (syms_of_search):
4758 * sound.c (syms_of_sound):
4759 * syntax.c (init_syntax_once, syms_of_syntax):
4760 * terminal.c (syms_of_terminal):
4761 * textprop.c (syms_of_textprop):
4762 * undo.c (syms_of_undo):
4763 * w32.c (globals_of_w32):
4764 * window.c (syms_of_window):
4765 * xdisp.c (syms_of_xdisp):
4766 * xfaces.c (syms_of_xfaces):
4767 * xfns.c (syms_of_xfns):
4768 * xmenu.c (syms_of_xmenu):
4769 * xsettings.c (syms_of_xsettings):
4770 * xterm.c (syms_of_xterm): Use DEFSYM.
4771
4228cf16
TZ
47722011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4773
cd3520a4 4774 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4775
7fcccf1e
PE
47762011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4777
7efb4e0e
PE
4778 Integer and buffer overflow fixes (Bug#8873).
4779
ff5844ad
PE
4780 * print.c (printchar, strout): Check for string overflow.
4781 (PRINTPREPARE, printchar, strout):
4782 Don't set size unless allocation succeeds.
4783
90532f02
PE
4784 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4785 for sizes. Check for string overflow more accurately.
4786 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4787
6d84508d
PE
4788 * macros.c: Integer and buffer overflow fixes.
4789 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4790 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4791 Use ptrdiff_t, not int, for sizes.
4792 Don't increment bufsize until after realloc succeeds.
4793 Check for size-calculation overflow.
4794 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4795
437b2cb4
PE
4796 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4797
8b9ac8b4
PE
4798 * lread.c: Integer overflow fixes.
4799 (read_integer): Radix is now EMACS_INT, not int,
4800 to improve quality of diagnostics for out-of-range radices.
4801 Calculate buffer size correctly for out-of-range radices.
4802 (read1): Check for integer overflow in radices, and in
4803 read-circle numbers.
82cb60d3
PE
4804 (read_escape): Avoid int overflow.
4805 (Fload, openp, read_buffer_size, read1)
4806 (substitute_object_recurse, read_vector, read_list, map_obarray):
4807 Use ptrdiff_t, not int, for sizes.
4808 (read1): Use EMACS_INT, not int, for sizes.
20270765 4809 Check for size overflow.
8b9ac8b4 4810
7fcccf1e
PE
4811 * image.c (cache_image): Check for size arithmetic overflow.
4812
bfbbd7e7
PE
4813 * lread.c: Integer overflow issues.
4814 (saved_doc_string_size, saved_doc_string_length)
4815 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4816 Now ptrdiff_t, not int.
4817 (read1): Don't assume doc string length fits in int. Check for
4818 out-of-range doc string lengths.
4819 (read_list): Don't assume file position fits in int.
39019e54 4820 (read_escape): Check for hex character overflow.
bfbbd7e7 4821
4e323265
LL
48222011-06-22 Leo Liu <sdl.web@gmail.com>
4823
4824 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4825 Move to minibuffer.el.
4826
85fece3e
PE
48272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4828
20b84ce9 4829 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4830 The following patches are for when GLYPH_DEBUG && !XASSERT.
4831 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4832 * dispnew.c (flush_stdout):
4833 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4834 Mark as externally visible.
4835 * dispnew.c (check_window_matrix_pointers): Now static.
4836 * dispnew.c (window_to_frame_vpos):
4837 * xfns.c (unwind_create_frame):
4838 * xterm.c (x_check_font): Remove unused local.
4839 * scroll.c (CHECK_BOUNDS):
4840 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4841 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4842 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4843 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4844 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4845 Now static.
4846 (debug_method_add): Use va_list and vsprintf rather than relying
4847 on undefined behavior with wrong number of arguments.
4848 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4849 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4850 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4851 since we're not interested in debugging glyphs with old libraries.
4852 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4853 GCC 4.6.0's static checking.
4854
0766b489
PE
48552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4856
31fd4b32
PE
4857 Integer overflow and signedness fixes (Bug#8873).
4858 A few related buffer overrun fixes, too.
4859
b79e8648
PE
4860 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4861
0766b489
PE
4862 * dispextern.h (struct face.stipple):
4863 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4864 (x_bitmap_mask, x_allocate_bitmap_record)
4865 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4866 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4867 (x_create_bitmap_from_xpm_data):
4868 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4869 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4870 (.bitmaps_last):
4871 * xfaces.c (load_pixmap):
4872 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4873 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4874 (.bitmaps_last, struct x_output.icon_bitmap):
4875 Use ptrdiff_t, not int, for bitmap indexes.
4876 (x_allocate_bitmap_record): Check for size overflow.
4877 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4878
b081724f
PE
4879 Use ptrdiff_t, not int, for overlay counts.
4880 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4881 * editfns.c (overlays_around, get_pos_property):
4882 * textprop.c (get_char_property_and_overlay):
4883 * xdisp.c (next_overlay_change, note_mouse_highlight):
4884 * xfaces.c (face_at_buffer_position):
21514da7
PE
4885 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4886 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4887 (Fnext_overlay_change, Fprevious_overlay_change)
4888 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4889 Use ptrdiff_t, not int, for sizes.
21514da7 4890 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4891
3de73e5e
PE
4892 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4893
2606c57b
PE
4894 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4895 (x_session_initialize): Do not assume string length fits in int.
4896
aaafe47a
PE
4897 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4898 This is unlikely, but can occur if DPI is outlandish.
4899
2674ddc8 4900 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4901 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4902
28154962
PE
4903 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4904 * xrdb.c (magic_file_p, search_magic_path):
4905 Omit last arg SUFFIX; it was always 0. All callers changed.
4906 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4907
7de51af5
PE
4908 * xfont.c (xfont_match): Avoid need for strlen.
4909
25ed6cc3
PE
4910 * xfns.c: Don't assume strlen fits in int.
4911 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4912
4eab31dd
PE
4913 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4914 not unsigned long, as we prefer signed integers. All callers changed.
4915 Detect integer overflow in repeat count.
4916 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4917 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4918
171e2a58
PE
4919 * termcap.c: Don't assume sizes fit in int and never overflow.
4920 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4921 (gobble_line): Check for size-calculation overflow.
4922
ad39faca 4923 * minibuf.c (Fread_buffer):
6e5bb2dc 4924 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4925 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4926 Don't assume string length fits in int.
4927
52c61c22 4928 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4929 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4930
b5b8c9e5
PE
4931 * font.c: Don't assume string length fits in int.
4932 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4933 Use ptrdiff_t, not int.
ccd6111c
PE
4934 (font_intern_prop): Don't assume string length fits in int.
4935 Don't assume integer property fits in fixnum.
4936 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4937
882f0d81 4938 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4939 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4940 Reformulate so as not to need the command string.
4941 Invoke gzip -cd rather than gunzip, as it's more portable.
4942 (lock_info_type, lock_file_1, lock_file):
4943 Don't assume pid_t and time_t fit in unsigned long.
4944 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4945 (current_lock_owner): Prefer signed type for sizes.
4946 Use memcpy, not strncpy, where memcpy is what is really wanted.
4947 Don't assume (via atoi) that time_t and pid_t fit in int.
4948 Check for time_t and/or pid_t out of range, e.g., via a network share.
4949 Don't alloca where an auto var works fine.
4950
93f4cf88
PE
4951 * fileio.c: Fix some integer overflow issues.
4952 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4953 Don't assume string length fits in int.
4954 (directory_file_name): Don't assume string length fits in long.
4955 (make_temp_name): Don't assume pid fits in int, or that its print
4956 length is less than 20.
4957
f3e92b69
PE
4958 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4959
1bfdaf10
PE
4960 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4961
35016e9a
PE
4962 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4963
3d1e65a1
PE
4964 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4965 We prefer signed integers, even for size calculations.
4966
0b963a93
PE
4967 * emacs.c: Don't assume string length fits in 'int'.
4968 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4969 (main): Don't invoke strlen when not needed.
4970
573f4b54
PE
4971 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4972 (XD_DEBUG_MESSAGE): Don't waste a byte.
4973
989f33ba
PE
4974 * callproc.c (getenv_internal_1, getenv_internal)
4975 (Fgetenv_internal):
965d34eb
PE
4976 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4977
e4d29b33
PE
4978 * lread.c (invalid_syntax): Omit length argument.
4979 All uses changed. This doesn't fix a bug, but it simplifies the
4980 code away from its former Hollerith-constant appearance, and it's
4981 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4982 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4983
eb49b136
PE
4984 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4985 This didn't break anything, but it didn't help either.
4986 It's confusing to put a bogus integer in a place where the actual
4987 value does not matter.
9f62aeb1 4988 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4989 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4990
15375a22
PE
4991 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4992 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4993 implementation.
b61cc01c
PE
4994 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4995 We prefer signed types, and the value cannot exceed the EMACS_INT
4996 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4997 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4998 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4999 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5000
53b2623d
PE
5001 * indent.c (sane_tab_width): New function.
5002 (current_column, scan_for_column, Findent_to, position_indentation)
5003 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5004 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5005
51cab52b 5006 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5007
f2ed8a70
PE
5008 * lisp.h (lint_assume): New macro.
5009 * composite.c (composition_gstring_put_cache):
5010 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5011
abe80cc6
PE
5012 * editfns.c, insdel.c:
5013 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5014
b02c740e
PE
5015 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5016
ebc96716
PE
5017 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5018
b4e50fa0 5019 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5020 Use much-faster test for byte-length change.
311d5d7c 5021 Don't assume string byte-length fits in 'int'.
a4cf38e4 5022 Check that character arg fits in 'int'.
85461888 5023 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5024
c0c1ee9f
PE
5025 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5026
a498d7f4
PE
5027 * fns.c (concat): Catch string overflow earlier.
5028 Do not rely on integer wraparound.
5029
51cab52b
PE
5030 * dispextern.h (struct it.overlay_strings_charpos)
5031 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5032 * xdisp.c (forward_to_next_line_start)
5033 (back_to_previous_visible_line_start)
5034 (reseat_at_next_visible_line_start, next_element_from_buffer):
5035 Don't arbitrarily truncate the value of 'selective' to int.
5036
76031fad
PE
5037 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5038
5eb55db9
PE
5039 * composite.c: Don't truncate sizes to 'int'.
5040 (composition_gstring_p, composition_reseat_it)
5041 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5042 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5043 not EMACS_UINT, for indexes.
5eb55db9 5044
0703a717
PE
5045 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5046
d6202519
PE
5047 * buffer.c: Include <verify.h>.
5048 (struct sortvec.priority, struct sortstr.priority):
8961a454 5049 Now EMACS_INT, not int.
c20998a7 5050 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5051 (struct sortstr.size, record_overlay_string)
5052 (struct sortstrlist.size, struct sortlist.used):
5053 Don't truncate size to int.
5054 (record_overlay_string): Check for size-calculation overflow.
d6202519 5055 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5056
d5a19415
JM
50572011-06-22 Jim Meyering <meyering@redhat.com>
5058
029529ac 5059 Don't leak an XBM-image-sized buffer
d5a19415
JM
5060 * image.c (xbm_load): Free the image buffer after using it.
5061
a9041e6c
PE
50622011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5063
5064 Port to Sun C.
5065 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5066 that Sun C diagnosed.
5067 * fns.c (secure_hash): Fix pointer signedness issue.
5068 * intervals.c (static_offset_intervals): New function.
5069 (offset_intervals): Use it.
5070
7f3f739f
LL
50712011-06-21 Leo Liu <sdl.web@gmail.com>
5072
5073 * deps.mk (fns.o):
5074 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5075 sha512.h.
5076
5077 * fns.c (secure_hash): Rename from crypto_hash_function and change
5078 the first arg to accept symbols.
5b66d427 5079 (Fsecure_hash): New primitive.
7f3f739f
LL
5080 (syms_of_fns): New symbols.
5081
76147d94
DD
50822011-06-20 Deniz Dogan <deniz@dogan.se>
5083
5084 * process.c (Fset_process_buffer): Clarify return value in
5085 docstring.
5086
7d7d0045
CY
50872011-06-18 Chong Yidong <cyd@stupidchicken.com>
5088
5089 * dispnew.c (add_window_display_history): Use BVAR.
5090
5091 * xdisp.c (debug_method_add): Use BVAR.
5092 (check_window_end, dump_glyph_matrix, dump_glyph)
5093 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5094
5095 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5096 Likewise.
5097
5098 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5099 check till after the cache is created in init_frame_faces.
5100
ff2bc410
SM
51012011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5102
5103 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5104
28177add
PE
51052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5106
dd3482fe
PE
5107 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5108 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5109 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5110
393d71f3 5111 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5112 * fileio.c (Finsert_file_contents):
5113 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5114 Remove the old (too-loose) buffer overflow checks.
5115 They weren't needed, since make_gap checks for buffer overflow.
5116 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5117 The old code merely checked for Emacs fixnum overflow, and relied
5118 on undefined (wraparound) behavior. The new code avoids undefined
5119 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5120
2e6813b0 5121 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5122 Tune. Don't use wider integers than needed. Don't use alloca.
5123 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5124
599a9e4f
PE
5125 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5126
99561444
PE
5127 * insdel.c, lisp.h (buffer_overflow): New function.
5128 (insert_from_buffer_1, replace_range, replace_range_2):
5129 * insdel.c (make_gap_larger):
5130 * editfns.c (Finsert_char):
5131 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5132
28177add
PE
5133 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5134
e69dafad
PE
51352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5136
4baa020d 5137 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5138
b1c46f02
PE
5139 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5140 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5141
e69dafad
PE
5142 * fileio.c: Don't assume EMACS_INT fits in off_t.
5143 (emacs_lseek): New static function.
5144 (Finsert_file_contents, Fwrite_region): Use it.
5145 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5146
566684ea
PE
5147 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5148
e6966cd6
PE
5149 * fns.c: Don't overflow int when computing a list length.
5150 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5151 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5152 truncation on 64-bit hosts. Check for QUIT every
5153 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5154 faster and is responsive enough.
5155 (Flength): Report an error instead of overflowing an integer.
5156 (Fsafe_length): Return a float if the value is not representable
5157 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5158 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5159 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5160
dd0b0efb
PE
5161 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5162 (header_size, word_size): New constants.
5163 (allocate_vectorlike): Don't check size overflow here.
5164 (allocate_vector): Check it here instead, since this is the only
5165 caller of allocate_vectorlike that could cause overflow.
5166 Check that the new vector's length is representable as a fixnum.
5167
86fe5cfe
PE
5168 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5169 The previous code was bogus. For example, next_almost_prime (32)
5170 returned 39, which is undesirable as it is a multiple of 3; and
5171 next_almost_prime (24) returned 25, which is a multiple of 5 so
5172 why was the code bothering to check for multiples of 7?
5173
80e88859
PE
5174 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5175
4a2f0ad6
PE
5176 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5177
f66c7cf8
PE
5178 Variadic C functions now count arguments with ptrdiff_t.
5179 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5180 Back then I didn't know that the Emacs coding style prefers signed int.
5181 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5182 were being counted with int, which may truncate counts on 64-bit
5183 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5184 * lisp.h (struct Lisp_Subr.function.aMANY)
5185 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5186 Arg counts are now ptrdiff_t, not size_t.
5187 All variadic functions and their callers changed accordingly.
5188 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5189 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5190 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5191 * callint.c (Fcall_interactively): Check arg count for overflow,
5192 to avoid potential buffer overrun. Use signed char, not 'int',
5193 for 'varies' array, so that we needn't bother to check its size
5194 calculation for overflow.
5195 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5196 * eval.c (apply_lambda):
5197 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5198 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5199 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5200
a1759b76
PE
5201 * callint.c (Fcall_interactively): Don't use index var as event count.
5202
d96be9fc
PE
5203 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5204 * mem-limits.h (SIZE): Remove; no longer used.
5205
a690a978 5206 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5207
578c21e6
PE
5208 Remove unnecessary casts.
5209 * xterm.c (x_term_init):
5210 * xfns.c (x_set_border_pixel):
5211 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5212 These aren't needed now that we assume ANSI C.
5213
96f53c6c
PE
5214 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5215 It's more likely to cause problems (due to unsigned overflow)
5216 than to cure them.
5217
83c77d31
PE
5218 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5219
ee2079f1
PE
5220 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5221
6da65536
PE
5222 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5223
7147c4a4
PE
5224 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5225
193e32d9
PE
5226 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5227
e5533da6
PE
5228 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5229
9910e595
PE
5230 GLYPH_CODE_FACE returns EMACS_INT, not int.
5231 * dispextern.h (merge_faces):
5232 * xfaces.c (merge_faces):
01103c44
PE
5233 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5234 Don't assume EMACS_INT fits in int.
9910e595 5235
2638320e
PE
5236 * character.h (CHAR_VALID_P): Remove unused parameter.
5237 * fontset.c, lisp.h, xdisp.c: All uses changed.
5238
045eb8d9
PE
5239 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5240
c1f134b5
PE
5241 * fns.c (concat): Minor tuning based on overflow analysis.
5242 This doesn't fix any bugs. Use int to hold character, instead
5243 of constantly refetching from Emacs object. Use XFASTINT, not
5244 XINT, for value known to be a character. Don't bother comparing
5245 a single byte to 0400, as it's always less.
5246
395fcb93 5247 * floatfns.c (Fexpt):
327eeec8
PE
5248 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5249
abbd3d23
PE
5250 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5251 for characters.
5252
684a03ef
PE
5253 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5254
0fed43f3
PE
5255 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5256 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5257 incorrectly succeed when S was a string, because 4294967386 was
5258 truncated before it was used.
5259
8fd02eb7
PE
5260 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5261 Otherwise, an out-of-range integer could cause undefined behavior
5262 on a 64-bit host.
5263
f8c86b69
PE
5264 * composite.c: Use int, not EMACS_INT, for characters.
5265 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5266 EMACS_INT, for values that are known to be in character range.
5267 This doesn't fix any bugs but is the usual style inside Emacs and
5268 may generate better code on 32-bit machines.
5269
34206dd2
PE
5270 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5271 This is for reasons similar to the recent CHAR_STRING fix.
5272 * charset.c (Fencode_char): Check that character arg is actually
5273 a character. Pass an int to ENCODE_CHAR.
5274 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5275 wider than 'int', as a compile-time check to prevent future regressions
5276 in this area.
5277
c5958d4c 5278 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5279
5280 Make sure a 64-bit char is never passed to CHAR_STRING.
5281 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5282 by silently ignoring the top 32 bits, allowing some values
5283 that were far too large to be valid characters.
5284 * character.h: Include <verify.h>.
5285 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5286 arguments are no wider than unsigned, as a compile-time check
5287 to prevent future regressions in this area.
5288 * data.c (Faset):
01103c44 5289 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5290 (Fsubst_char_in_region):
5291 * fns.c (concat):
5292 * xdisp.c (decode_mode_spec_coding):
5293 Adjust to CHAR_STRING's new requirement.
5294 * editfns.c (Finsert_char, Fsubst_char_in_region):
5295 * fns.c (concat): Check that character args are actually
5296 characters. Without this test, these functions did the wrong
5297 thing with wildly out-of-range values on 64-bit hosts.
5298
d37ca623
PE
5299 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5300 These casts should not be needed on 32-bit hosts, either.
5301 * keyboard.c (read_char):
5302 * lread.c (Fload): Remove casts to unsigned.
5303
ea204efb
PE
5304 * lisp.h (UNSIGNED_CMP): New macro.
5305 This fixes comparison bugs on 64-bit hosts.
5306 (ASCII_CHAR_P): Use it.
5307 * casefiddle.c (casify_object):
01103c44 5308 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5309 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5310 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5311 * dispextern.h (FACE_FROM_ID):
5312 * keyboard.c (read_char): Use UNSIGNED_CMP.
5313
41cb286c
PE
5314 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5315 not to EMACS_INT, to avoid GCC warning.
5316
4a1b9832
PE
5317 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5318
55daad71
PE
5319 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5320 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5321 isn't needed on 32-bit machines.
8f95c75c 5322
01103c44
PE
5323 * buffer.c (Fgenerate_new_buffer_name):
5324 Use EMACS_INT for count, not int.
0ceccced 5325 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5326
5327 * data.c (Qcompiled_function): Now static.
5328
c6f072e7
PE
5329 * window.c (window_body_lines): Now static.
5330
20ce5912
PE
5331 * image.c (gif_load): Rename local to avoid shadowing.
5332
9c4c5f81
PE
5333 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5334 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5335 * alloc.c (make_save_value): Integer argument is now of type
5336 ptrdiff_t, not int.
5337 (mark_object): Use ptrdiff_t, not int.
5338 * lisp.h (pD): New macro.
5339 * print.c (print_object): Use it.
5340
c0c5c8ae
PE
5341 * alloc.c: Use EMACS_INT, not int, to count objects.
5342 (total_conses, total_markers, total_symbols, total_vector_size)
5343 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5344 (total_free_floats, total_floats, total_free_intervals)
5345 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5346 Now EMACS_INT, not int. All uses changed.
5347 (Fgarbage_collect): Compute overall total using a double, so that
5348 integer overflow is less likely to be a problem. Check for overflow
5349 when converting back to an integer.
5a25e253
PE
5350 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5351 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5352 These were 'int' variables that could overflow on 64-bit hosts;
5353 they were never used, so remove them instead of repairing them.
211a0b2a 5354 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5355 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5356 Previously, this ceilinged at INT_MAX, but that doesn't work on
5357 64-bit machines.
e46bb31a 5358 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5359
c78baabf 5360 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5361 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5362 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5363 when a (possibly-narrower) signed value would do just as well.
5364 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5365
c9d624c6
PE
5366 * alloc.c: Catch some string size overflows that we were missing.
5367 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5368 for convenience in STRING_BYTES_MAX.
5369 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5370 The definition here is exact; the one in lisp.h was approximate.
5371 (allocate_string_data): Check for string overflow. This catches
5372 some instances we weren't catching before. Also, it catches
5373 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5374 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5375 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5376
c9d624c6
PE
5377 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5378 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5379 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5380
353032ce
PE
5381 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5382
2bccce07
PE
5383 * alloc.c (Fmake_string): Check for out-of-range init.
5384
0ac30604
SM
53852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5386
5387 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5388
c195f2de
JD
53892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5390
5391 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5392 xg_get_default_scrollbar_width.
5393
5394 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5395 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5396 (style_changed_cb): Call update_theme_scrollbar_width and call
5397 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5398 all frames (Bug#8505).
5399 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5400 Call gtk_window_set_resizable if HAVE_GTK3.
5401 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5402 and height if HAVE_GTK3 (Bug#8505).
5403 (scroll_bar_width_for_theme): New variable.
5404 (update_theme_scrollbar_width): New function.
5405 (xg_get_default_scrollbar_width): Move code to
5406 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5407 (xg_initialize): Call update_theme_scrollbar_width.
5408
5409 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5410
5411 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5412
e10ac9f1
MR
54132011-06-12 Martin Rudalics <rudalics@gmx.at>
5414
5415 * frame.c (make_frame): Call other_buffer_safely instead of
5416 other_buffer.
5417
5418 * window.c (temp_output_buffer_show): Call display_buffer with
5419 second argument Vtemp_buffer_show_specifiers and reset latter
5420 immediately after the call.
5421 (Vtemp_buffer_show_specifiers): New variable.
5422 (auto_window_vscroll_p, next_screen_context_lines)
5423 (Vscroll_preserve_screen_position): Remove leading asterisks from
5424 doc-strings.
5425
2d3c217e 54262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5427
7b7f97e8 5428 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5429 * buffer.c (Qclone_number): Remove for now, as it's unused.
5430 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5431 (record_buffer): Remove unused local.
5432 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5433 (set_frame_buffer_list): Remove; unused.
5434 * frame.h (other_visible_frames): Remove decl.
5435 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5436 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5437 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5438 if HAVE_GPM.
5439 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5440 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5441 Define only if HAVE_GPM.
5442 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5443 (update_hints_inhibit): Remove; never set. All uses removed.
5444 * widgetprv.h (emacsFrameClassRec): Remove decl.
5445 * window.c (delete_deletable_window): Now returns void, since it
5446 wasn't returning anything.
5447 (compare_window_configurations): Remove unused locals.
5448 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5449 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5450 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5451 the same widths as pointers. This follows up on the 2011-05-06 patch.
5452 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5453 * xterm.h: Likewise.
5454 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5455
1384b89e
JB
54562011-06-12 Juanma Barranquero <lekktu@gmail.com>
5457
5458 * makefile.w32-in: Update dependencies.
5459 (LISP_H): Add lib/intprops.h.
5460
1100a63c
CY
54612011-06-11 Chong Yidong <cyd@stupidchicken.com>
5462
5463 * image.c (gif_load): Add animation frame delay to the metadata.
5464 (syms_of_image): Use DEFSYM. New symbol `delay'.
5465
6198ccd0
MR
54662011-06-11 Martin Rudalics <rudalics@gmx.at>
5467
5468 * window.c (delete_deletable_window): Re-add.
5469 (Fset_window_configuration): Rewrite to handle dead buffers and
5470 consequently deletable windows.
5471 (window_tree, Fwindow_tree): Remove. Supply functionality in
5472 window.el.
5473 (compare_window_configurations): Simplify code.
5474
b6e3633c
AS
54752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5476
1ab0dee5
AS
5477 * image.c (imagemagick_load_image): Fix type mismatch.
5478 (Fimagemagick_types): Likewise.
5479
b6e3633c
AS
5480 * window.h (replace_buffer_in_windows): Declare.
5481
9397e56f
MR
54822011-06-11 Martin Rudalics <rudalics@gmx.at>
5483
5484 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5485 Qclone_number. Remove external declaration of Qdelete_window.
5486 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5487 code.
640c8776
SM
5488 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5489 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5490 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5491 buffer list implementation.
5492 (other_buffer_safely): New function.
5493 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5494 calls to replace_buffer_in_windows and
5495 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5496 if allowed.
5497 (record_buffer): Inhibit quitting and rewrite using quittable
5498 functions. Run Qbuffer_list_update_hook if allowed.
5499 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5500 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5501 Move switch-to-buffer to window.el.
9397e56f
MR
5502 (bury-buffer): Move to window.el.
5503 (Vbuffer_list_update_hook): New variable.
5504
5505 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5506 section.
5507
5508 * window.h (resize_frame_windows): Move up in code.
5509 (Fwindow_frame): Remove EXFUN.
5510 (replace_buffer_in_all_windows): Remove prototype.
5511 (replace_buffer_in_windows_safely): Add prototype.
5512
5513 * window.c: Declare Qdelete_window static again. Move down
5514 declaration of select_count.
5515 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5516 (Fother_window): Move to window.el.
5517 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5518 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5519 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5520 window.el.
5521 (replace_buffer_in_windows): Implement by calling
5522 Qreplace_buffer_in_windows.
5523 (replace_buffer_in_all_windows): Remove with some functionality
5524 moved into replace_buffer_in_windows_safely.
5525 (replace_buffer_in_windows_safely): New function.
5526 (select_window_norecord, select_frame_norecord): Move in front
5527 of run_window_configuration_change_hook. Remove now obsolete
5528 declarations.
640c8776
SM
5529 (Fset_window_buffer): Rewrite doc-string.
5530 Call Qrecord_window_buffer.
9397e56f
MR
5531 (keys_of_window): Move binding for other-window to window.el.
5532
b50691aa
CY
55332011-06-11 Chong Yidong <cyd@stupidchicken.com>
5534
5535 * dispextern.h (struct image): Replace data member, whose int_val
5536 and ptr_val fields were not used by anything, with a single
5537 lisp_val object.
5538
5539 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5540 (gif_clear_image, gif_load, imagemagick_load_image)
5541 (gs_clear_image, gs_load): Callers changed.
5542
3f754b86
PE
55432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5544
cca69397
PE
5545 * buffer.h: Include <time.h>, for time_t.
5546 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5547
109e28d0
PE
5548 Fix minor problems found by static checking.
5549
60737f02
PE
5550 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5551
4b66faf3
PE
5552 Make identifiers static if they are not used in other modules.
5553 * data.c (Qcompiled_function, Qframe, Qvector):
5554 * image.c (QimageMagick, Qsvg):
5555 * minibuf.c (Qmetadata):
5556 * window.c (resize_window_check, resize_root_window): Now static.
5557 * window.h (resize_window_check, resize_root_window): Remove decls.
5558
109e28d0
PE
5559 * window.c (window_deletion_count, delete_deletable_window):
5560 Remove; unused.
46a4ce9e
PE
5561 (window_body_lines): Now static.
5562 (Fdelete_other_windows_internal): Mark vars as initialized.
5563 Make sure 'resize_failed' is initialized.
5564 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5565 (resize_window_apply): Remove unused local.
5566 * window.h (delete_deletable_window): Remove decl.
5567
109e28d0 5568 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5569 (imagemagick_load_image): Fix pointer signedness problem by changing
5570 last arg from unsigned char * to char *. All uses changed.
5571 Also, fix a local for similar reasons.
5572 Remove unused locals. Remove locals to avoid shadowing.
5573 (fn_rsvg_handle_free): Remove; unused.
5574 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5575 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5576
3f754b86
PE
5577 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5578
2547adb1
CY
55792011-06-10 Chong Yidong <cyd@stupidchicken.com>
5580
5581 * image.c (gif_load): Fix omitted cast error introduced by
5582 2011-06-06 change.
5583
2c8e37d4
MR
55842011-06-10 Martin Rudalics <rudalics@gmx.at>
5585
5586 * window.h (resize_proportionally, orig_total_lines)
5587 (orig_top_line): Remove from window structure.
5588 (set_window_height, set_window_width, change_window_heights)
5589 (Fdelete_window): Remove prototypes.
5590 (resize_frame_windows): Remove duplicate declaration.
5591
440a42e3
EZ
55922011-06-10 Eli Zaretskii <eliz@gnu.org>
5593
5594 * window.h (resize_frame_windows, resize_window_check)
5595 (delete_deletable_window, resize_root_window)
5596 (resize_frame_windows): Declare prototypes.
5597
5598 * window.c (resize_window_apply): Make definition be "static" to
5599 match the prototype.
5600
562dd5e9
MR
56012011-06-10 Martin Rudalics <rudalics@gmx.at>
5602
5603 * window.c: Remove declarations of Qwindow_size_fixed,
5604 window_min_size_1, window_min_size_2, window_min_size,
5605 size_window, window_fixed_size_p, enlarge_window, delete_window.
5606 Remove static from declaration of Qdelete_window, it's
5607 temporarily needed by Fbury_buffer.
5608 (replace_window): Don't assign orig_top_line and
5609 orig_total_lines.
5610 (Fdelete_window, delete_window): Remove. Window deletion is
5611 handled by window.el.
640c8776
SM
5612 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5613 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5614 (Fdelete_other_windows): Remove. Deleting other windows is
5615 handled by window.el.
5616 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5617 handled in window.el.
5618 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5619 Window minimum sizes are handled in window.el.
5620 (shrink_windows, size_window, set_window_height)
5621 (set_window_width, change_window_heights, window_height)
5622 (window_width, CURBEG, CURSIZE, enlarge_window)
5623 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5624 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5625 handled in window.el.
5626 (make_dummy_parent): Rename to make_parent_window and give it a
5627 second argument horflag.
5628 (make_window): Don't set resize_proportionally any more.
5629 (Fsplit_window): Remove. Windows are split in window.el.
5630 (save_restore_action, save_restore_orig_size)
5631 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5632 Resize mini windows in window.el.
5633 (grow_mini_window, shrink_mini_window): Implement by calling
5634 Qresize_root_window_vertically, resize_window_check and
5635 resize_window_apply.
640c8776
SM
5636 (saved_window, Fset_window_configuration, save_window_save):
5637 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5638 resize_proportionally.
5639 (window_min_height, window_min_width): Move to window.el.
5640 (keys_of_window): Move bindings for delete-other-windows,
5641 split-window, delete-window and enlarge-window to window.el.
5642
5643 * buffer.c: Temporarily extern Qdelete_window.
5644 (Fbury_buffer): Temporarily call Qdelete_window instead of
5645 Fdelete_window (Fbury_buffer will move to window.el soon).
5646
5647 * frame.c (set_menu_bar_lines_1): Remove code handling
5648 orig_top_line and orig_total_lines.
5649
5650 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5651 set_window_height but set heights directly.
5652 (change_frame_size_1): Use resize_frame_windows.
5653
5654 * xdisp.c (init_xdisp): Don't use set_window_height but set
5655 heights directly.
5656
640c8776
SM
5657 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5658 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5659 run_window_configuration_change_hook.
5660
5661 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5662 instead of change_window_heights and run
5663 run_window_configuration_change_hook.
5664
1a13852e
MR
56652011-06-09 Martin Rudalics <rudalics@gmx.at>
5666
5667 * window.c (replace_window): Rename second argument REPLACEMENT to
5668 NEW. New third argument SETFLAG. Rewrite.
5669 (delete_window, make_dummy_parent): Call replace_window with
5670 third argument 1.
5671 (window_list_1): Move down in code.
5672 (run_window_configuration_change_hook): Move set_buffer part
5673 before select_frame_norecord part in order to unwind correctly.
5674 Rename count1 to count.
5675 (recombine_windows, delete_deletable_window, resize_root_window)
5676 (Fdelete_other_windows_internal)
5677 (Frun_window_configuration_change_hook, make_parent_window)
5678 (resize_window_check, resize_window_apply, Fresize_window_apply)
5679 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5680 (Fdelete_window_internal, Fresize_mini_window_internal):
5681 New functions.
1a13852e
MR
5682 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5683
f3d1777e
MR
56842011-06-08 Martin Rudalics <rudalics@gmx.at>
5685
496e208e
MR
5686 * window.h (window): Add some new members to window structure -
5687 normal_lines, normal_cols, new_total, new_normal, clone_number,
5688 splits, nest, prev_buffers, next_buffers.
5689 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5690 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5691
f3d1777e
MR
5692 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5693 Remove.
496e208e
MR
5694 (make_dummy_parent): Set new members of windows structure.
5695 (make_window): Move down in code. Handle new members of window
5696 structure.
5697 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5698 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5699 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5700 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5701 (Fset_window_next_buffers, Fset_window_clone_number):
5702 New functions.
496e208e
MR
5703 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5704 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5705 Doc-string fixes.
5706 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5707 Argument WINDOW can be now internal window too.
5708 (Fwindow_use_time): Move up in code.
5709 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5710 Rewrite doc-string.
5711 (Fset_window_configuration, saved_window)
5712 (Fcurrent_window_configuration, save_window_save): Handle new
5713 members of window structure.
b9e809c2
MR
5714 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5715 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5716 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5717 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5718 Qget_mru_window, Qresize_root_window,
5719 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5720 Qauto_buffer_name; staticpro them.
f3d1777e 5721
abde8f8c
MR
57222011-06-07 Martin Rudalics <rudalics@gmx.at>
5723
5724 * window.c (Fwindow_total_size, Fwindow_left_column)
5725 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5726 (Fwindow_list_1): New functions.
5727 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5728 (Fwindow_width, Fscroll_left, Fscroll_right):
5729 Use window_body_cols instead of window_box_text_cols.
5730 (delete_window, Fset_window_configuration):
5731 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5732 (delete_all_subwindows): Take a window as argument and not a
5733 structure. Rewrite.
190b47e6
MR
5734 (window_loop): Remove handling of GET_LRU_WINDOW and
5735 GET_LARGEST_WINDOW.
5736 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5737
5738 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5739 window_box_text_cols. delete_all_subwindows now takes a
5740 Lisp_Object as argument.
abde8f8c 5741
640c8776
SM
5742 * indent.c (compute_motion, Fcompute_motion):
5743 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5744
fa8a67e6
MR
5745 * frame.c (delete_frame): Call delete_all_subwindows with root
5746 window as argument.
5747
a54e3482
DC
57482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5749
5750 * fns.c (Fputhash): Document return value.
5751
60002bf5
CY
57522011-06-06 Chong Yidong <cyd@stupidchicken.com>
5753
5754 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5755
0c671da6 57562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5757
b862a52a 5758 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5759
be44ca6c
PE
5760 Check for overflow when converting integer to cons and back.
5761 * charset.c (Fdefine_charset_internal, Fdecode_char):
5762 Use cons_to_unsigned to catch overflow.
5763 (Fencode_char): Use INTEGER_TO_CONS.
5764 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5765 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5766 * data.c (long_to_cons, cons_to_long): Remove.
5767 (cons_to_unsigned, cons_to_signed): New functions.
5768 These signal an error for invalid or out-of-range values.
5769 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5770 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5771 * font.c (Ffont_variation_glyphs):
5772 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5773 * lisp.h: Include <intprops.h>.
5774 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5775 (cons_to_signed, cons_to_unsigned): New decls.
5776 (long_to_cons, cons_to_long): Remove decls.
5777 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5778 (Fprimitive_undo): Use CONS_TO_INTEGER.
5779 * xfns.c (Fx_window_property): Likewise.
5780 * xselect.c: Include <limits.h>.
5781 (x_own_selection, selection_data_to_lisp_data):
5782 Use INTEGER_TO_CONS.
5783 (x_handle_selection_request, x_handle_selection_clear)
5784 (x_get_foreign_selection, Fx_disown_selection_internal)
5785 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5786 (lisp_data_to_selection_data): Use cons_to_unsigned.
5787 (x_fill_property_data): Use cons_to_signed.
5788 Report values out of range.
5789
d1f3d2af
PE
5790 Check for buffer and string overflow more precisely.
5791 * buffer.h (BUF_BYTES_MAX): New macro.
5792 * lisp.h (STRING_BYTES_MAX): New macro.
5793 * alloc.c (Fmake_string):
5794 * character.c (string_escape_byte8):
5795 * coding.c (coding_alloc_by_realloc):
5796 * doprnt.c (doprnt):
5797 * editfns.c (Fformat):
5798 * eval.c (verror):
5799 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5800 since they may not be the same number.
5801 * editfns.c (Finsert_char):
5802 * fileio.c (Finsert_file_contents):
5803 Likewise for BUF_BYTES_MAX.
5804
dd52fcea
PE
5805 * image.c: Use ptrdiff_t, not int, for sizes.
5806 (slurp_file): Switch from int to ptrdiff_t.
5807 All uses changed.
5808 (slurp_file): Check that file size fits in both size_t (for
5809 malloc) and ptrdiff_t (for sanity and safety).
5810
7f9bbdbb
PE
5811 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5812 if b->modtime has its maximal value.
5813
dfe18f82
PE
5814 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5815
84acfcf0
PE
5816 Don't assume time_t can fit into int.
5817 * buffer.h (struct buffer.modtime): Now time_t, not int.
5818 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5819 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5820
ccd9a01a
PE
5821 Minor fixes for signed vs unsigned integers.
5822 * character.h (MAYBE_UNIFY_CHAR):
5823 * charset.c (maybe_unify_char):
5824 * keyboard.c (read_char, reorder_modifiers):
5825 XINT -> XFASTINT, since the integer must be nonnegative.
5826 * ftfont.c (ftfont_spec_pattern):
5827 * keymap.c (access_keymap, silly_event_symbol_error):
5828 XUINT -> XFASTINT, since the integer must be nonnegative.
5829 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5830 since it makes no difference and we prefer signed.
5831 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5832 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5833 nonnegative.
5834
d6d100dd
SM
58352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5836
5837 * window.h (Fwindow_frame): Declare.
5838
2b6148e4
PE
58392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5842 (SPARE_MEMORY): Always define.
5843 (LARGE_REQUEST): Remove.
5844 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5845
f230ecc9
MR
58462011-06-06 Martin Rudalics <rudalics@gmx.at>
5847
727e958e
MR
5848 * lisp.h: Move EXFUNS for Fframe_root_window,
5849 Fframe_first_window and Fset_frame_selected_window to window.h.
5850
5851 * window.h: Move EXFUNS for Fframe_root_window,
5852 Fframe_first_window and Fset_frame_selected_window here from
5853 lisp.h.
5854
5855 * frame.c (Fwindow_frame, Fframe_first_window)
5856 (Fframe_root_window, Fframe_selected_window)
5857 (Fset_frame_selected_window): Move to window.c.
5858 (Factive_minibuffer_window): Move to minibuf.c.
5859 (Fother_visible_frames_p): New function.
5860
5861 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5862
f230ecc9
MR
5863 * window.c (decode_window, decode_any_window): Move up in code.
5864 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5865 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5866 (Fwindow_buffer): Move up and rewrite doc-string.
5867 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5868 (Fwindow_prev): New functions.
727e958e
MR
5869 (Fwindow_frame): Move here from frame.c. Accept any window as
5870 argument.
5871 (Fframe_root_window, Fframe_first_window)
5872 (Fframe_selected_window): Move here from frame.c. Accept frame
5873 or arbitrary window as argument. Update doc-strings.
5874 (Fminibuffer_window): Move up in code.
5875 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5876 (Fset_frame_selected_window): Move here from frame.c.
5877 Marginal rewrite.
727e958e
MR
5878 (Fselected_window, select_window, Fselect_window): Move up in
5879 code. Minor doc-string fixes.
f230ecc9 5880
4d09bcf6
PE
58812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5882
5883 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5884 Do not assume that spare memory exists; that assumption is valid
5885 only if SYSTEM_MALLOC.
5886 (LARGE_REQUEST): New macro, so that the issue of large requests
5887 is separated from the issue of spare memory.
5888
810928a2
AS
58892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5890
172418ad
AS
5891 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5892 format. (Bug#8806)
5893
43f862f7
AS
5894 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5895
810928a2
AS
5896 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5897 before statements.
5898
a059fe24
JD
58992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5900
5901 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5902
5903 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5904
5905 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5906 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5907
989bf368
JB
59082011-06-05 Juanma Barranquero <lekktu@gmail.com>
5909
5910 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5911
4b80f674
CY
59122011-06-04 Chong Yidong <cyd@stupidchicken.com>
5913
5914 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5915 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5916 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5917 New error handlers.
4b80f674
CY
5918 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5919 Obey Vx_select_enable_clipboard_manager. Catch errors in
5920 x_clipboard_manager_save (Bug#8779).
5921 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5922 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5923
99a33b77 59242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5925
5926 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5927
99a33b77 59282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5929
5930 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5931 in the current matrix if keep_current_p is non-zero.
5932
8264569d
EZ
59332011-06-04 Eli Zaretskii <eliz@gnu.org>
5934
5935 * bidi.c (bidi_level_of_next_char): Fix last change.
5936
57f97249
EZ
59372011-06-03 Eli Zaretskii <eliz@gnu.org>
5938
fec2107c 5939 Support bidi reordering of text covered by display properties.
57f97249 5940
fec2107c
EZ
5941 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5942 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5943 (bidi_cache_search, bidi_cache_iterator_state)
5944 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5945 (bidi_level_of_next_char, bidi_move_to_visually_next):
5946 Support character positions inside a run of characters covered by a
fec2107c
EZ
5947 display string.
5948 (bidi_paragraph_init, bidi_resolve_explicit_1)
5949 (bidi_level_of_next_char): Call bidi_fetch_char and
5950 bidi_fetch_char_advance instead of FETCH_CHAR and
5951 FETCH_CHAR_ADVANCE.
5952 (bidi_init_it): Initialize new members.
5953 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5954 definitions.
5955 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5956 instead of using explicit *_CHAR codes.
d6d100dd
SM
5957 (bidi_resolve_explicit, bidi_resolve_weak):
5958 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5959 bidirectional text is supported only in multibyte buffers.
5960 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5961 it to initialize the frame_window_p member of struct bidi_it.
5962 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5963 (bidi_resolve_explicit, bidi_resolve_weak)
5964 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5965 bidi_it->nchars is non-positive.
5966 (bidi_level_of_next_char): Don't try to lookup the cache for the
5967 next/previous character if nothing is cached there yet, or if we
5968 were just reseat()'ed to a new position.
c40e2fb2 5969
0e14fe90
EZ
5970 * xdisp.c (set_cursor_from_row): Set start and stop points
5971 according to the row's direction when priming the loop that looks
5972 for the glyph on which to display cursor.
5973 (single_display_spec_intangible_p): Function deleted.
5974 (display_prop_intangible_p): Reimplement to call
5975 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5976 Accept 3 additional arguments needed by handle_display_spec.
5977 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5978 values: lists, `(when COND...)' forms, etc.
5979 (single_display_spec_string_p): Support property values that are
5980 lists with the argument STRING its top-level element.
5981 (display_prop_string_p): Fix the condition for processing a
5982 property that is a list to be consistent with handle_display_spec.
fec2107c 5983 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5984 last portion of handle_display_prop.
5985 (compute_display_string_pos): Accept additional argument
5986 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5987 value of a `display' property is a "replacing spec".
5988 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5989 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5990 the display property, but just return a value indicating whether
5991 the display property will replace the characters it covers.
5992 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5993 frame_window_p members of struct bidi_it.
d6d100dd
SM
5994 (compute_display_string_pos, compute_display_string_end):
5995 New functions.
fec2107c
EZ
5996 (push_it): Accept second argument POSITION, where pop_it should
5997 jump to continue iteration.
5998 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5999
fec2107c
EZ
6000 * keyboard.c (adjust_point_for_property): Adjust the call to
6001 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6002
6003 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6004 (bidi_init_it): Update prototypes.
6005 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6006 (compute_display_string_pos, compute_display_string_end):
6007 Declare prototypes.
fec2107c
EZ
6008 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6009 EMACS_INT.
fc6f18ce 6010
40087514 60112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6012
57f53182
PE
6013 Malloc failure behavior now depends on size of allocation.
6014 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6015 * lisp.h: Change signatures accordingly.
6016 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6017 All callers changed. (Bug#8762)
6018
6019 * gnutls.c: Use Emacs's memory allocators.
6020 Without this change, the gnutls library would invoke malloc etc.
6021 directly, which causes problems on non-SYNC_INPUT hosts, and which
6022 runs afoul of improving memory_full behavior. (Bug#8761)
6023 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6024 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6025 xfree instead of the default malloc, realloc, free.
6026 (Fgnutls_boot): No need to check for memory allocation failure,
6027 since xmalloc does that for us.
6028
ac32cd99 6029 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6030 * category.c (hash_get_category_set):
6031 * ccl.c (ccl_driver):
6032 * charset.c (Fdefine_charset_internal):
6033 * charset.h (struct charset.hash_index):
6034 * composite.c (get_composition_id, gstring_lookup_cache)
6035 (composition_gstring_put_cache):
6036 * composite.h (struct composition.hash_index):
6037 * dispextern.h (struct image.hash):
6038 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6039 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6040 (hashfn_equal, hashfn_user_defined, make_hash_table)
6041 (maybe_resize_hash_table, hash_lookup, hash_put)
6042 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6043 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6044 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6045 * image.c (make_image, search_image_cache, lookup_image)
6046 (xpm_put_color_table_h):
6047 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6048 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6049 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6050 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6051 * alloc.c (allocate_vectorlike):
6052 Check for overflow in vector size calculations.
6053 * ccl.c (ccl_driver):
6054 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6055 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6056 need to be updated by these changes.
40087514
PE
6057 * fns.c (make_hash_table, maybe_resize_hash_table):
6058 Check for integer overflow with large hash tables.
0de4bb68
PE
6059 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6060 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6061 (SXHASH_REDUCE): New macro.
6062 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6063 Use it instead of discarding useful hash info with large hash values.
6064 (sxhash_float): New function.
6065 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6066 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6067 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6068 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6069 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6070 Adjust signatures to match updated version of code.
6071 (consing_since_gc): Now EMACS_INT, since a single hash table can
6072 use more than INT_MAX bytes.
6073
698d32e2
DN
60742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6075
6076 Make it possible to build with GCC-4.6+ -O2 -flto.
6077
6078 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6079
fd6fa53f
SM
60802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6081
6082 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6083 Call minibuffer-inactive-mode.
6084
864db017
JB
60852011-05-31 Juanma Barranquero <lekktu@gmail.com>
6086
6087 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6088 Update dependencies.
6089
2ad0baf4
DN
60902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6091
6092 * data.c (init_data): Remove code for UTS, this system is not
6093 supported anymore.
6094
4fcc2638
DN
60952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6096
6097 Don't force ./temacs to start in terminal mode.
6098
6099 * frame.c (make_initial_frame): Initialize faces in all cases, not
6100 only when CANNOT_DUMP is defined.
6101 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6102
c56e0fd5
DN
61032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6104
6105 * dispnew.c (add_window_display_history): Use const for the string
6106 pointer. Remove declaration, not needed.
6107
333d54da 61082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6109
55d4c1b2 6110 Use 'inline', not 'INLINE'.
333d54da 6111 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6112 * alloc.c, fontset.c (INLINE): Remove.
6113 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6114 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6115 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6116 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6117 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6118
738db178
DN
61192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6120
6121 Make it possible to run ./temacs.
6122
6123 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6124 syms_of_callproc does the same thing. Remove test for
6125 "initialized", do it in the caller.
6126 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6127
620c53a6
SM
61282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6129
6130 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6131 (read_minibuf): Use get_minibuffer.
6132 (syms_of_minibuf): Use DEFSYM.
6133 (Qmetadata): New var.
6134 * data.c (Qbuffer): Don't make it static.
6135 (syms_of_data): Use DEFSYM.
6136
e003a292
PE
61372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6138
6139 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6140 (CCL_CODE_MIN): New macro.
6141
ed008a6d
PE
61422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6143
3687c2ef
PE
6144 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6145
ed008a6d
PE
6146 * eval.c (Qdebug): Now static.
6147 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6148 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6149 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6150
d66c4c7c
CY
61512011-05-29 Chong Yidong <cyd@stupidchicken.com>
6152
6153 * image.c: Various fixes to ImageMagick code comments.
6154 (Fimagemagick_types): Doc fix.
6155
5fbc2025
PE
61562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6157
0196f88a
PE
6158 Minor fixes prompted by GCC 4.6.0 warnings.
6159
6160 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6161
5fbc2025
PE
6162 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6163 (x_clipboard_manager_save_all): Move extern decl to ...
6164 * xterm.h: ... here, so that it can be checked for consistency.
6165
1dd3c2d9
CY
61662011-05-29 Chong Yidong <cyd@stupidchicken.com>
6167
6168 * xselect.c (x_clipboard_manager_save_frame)
6169 (x_clipboard_manager_save_all): New functions.
6170 (Fx_clipboard_manager_save): Lisp function deleted.
6171
6172 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6173 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6174
6175 * xterm.h: Update prototype.
6176
5ba6571d
WX
61772011-05-28 William Xu <william.xwl@gmail.com>
6178
6179 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6180 exiting (Bug#8239).
6181
3eaff834
JM
61822011-05-28 Jim Meyering <meyering@redhat.com>
6183
e1900994 6184 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6185 * fns.c (to_uchar): Define.
6186 (crypto_hash_function): Use it to convert some newly-signed
6187 variables to unsigned, to avoid sign-extension bugs. For example,
6188 without this change, (md5 "truc") would evaluate to
6189 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6190 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6191 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6192
0f6990a7
PE
61932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6194
6195 Integer overflow fixes.
c8a9ca5a 6196
08686060
PE
6197 * dbusbind.c: Serial number integer overflow fixes.
6198 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6199 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6200 to hold a serial number that is too large for a fixnum.
6201 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6202 Check for serial numbers out of range. Decode any serial number
59568bf0 6203 that was so large that it became a float. (Bug#8722)
08686060 6204
2d1fc3c7
PE
6205 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6206 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6207 Use XFASTINT rather than XUINT when numbers are nonnegative.
6208 (xd_append_arg, Fdbus_method_return_internal):
6209 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6210 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6211 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6212 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6213 (Bug#8722)
2d1fc3c7 6214
c8a9ca5a
PE
6215 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6216
519e1d69
PE
6217 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6218
6df6ae42 6219 ccl: Add integer overflow checks.
30569699
PE
6220 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6221 (IN_INT_RANGE): New macros.
6222 (ccl_driver): Use them to check for integer overflow when
6223 decoding a CCL program. Many of the new checks are whether XINT (x)
6224 fits in int; it doesn't always, on 64-bit hosts. The new version
6225 doesn't catch all possible integer overflows, but it's an
847044ea 6226 improvement. (Bug#8719)
30569699 6227
c11285dc
PE
6228 * alloc.c (make_event_array): Use XINT, not XUINT.
6229 There's no need for unsigned here.
6230
fdccd48e
PE
6231 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6232 This follows up to the 2011-05-06 change that substituted uintptr_t
6233 for EMACS_INT. This case wasn't caught back then.
6234
37910ab2
PE
6235 Rework Fformat to avoid integer overflow issues.
6236 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6237 now (part of C89). Include <verify.h>.
6238 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6239 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6240 (Fformat): Avoid the prepass trying to compute sizes; it was only
6241 approximate and thus did not catch overflow reliably. Instead, walk
6242 through the format just once, formatting and computing sizes as we go,
6243 checking for integer overflow at every step, and allocating a larger
6244 buffer as needed. Keep track separately whether the format is
6245 multibyte. Keep only the most-recently calculated precision, rather
6246 than them all. Record whether each argument has been converted to
6247 string. Use EMACS_INT, not int, for byte and char and arg counts.
6248 Support field widths and precisions larger than INT_MAX. Avoid
6249 sprintf's undefined behavior with conversion specifications such as %#d
6250 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6251 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6252 formatting out-of-range floating point numbers with int
9173deec 6253 formats. (Bug#8668)
37910ab2 6254
2e6578fb
PE
6255 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6256
0ae6bdee
PE
6257 * data.c: Avoid integer truncation in expressions involving floats.
6258 * data.c: Include <intprops.h>.
6259 (arith_driver): When there's an integer overflow in an expression
6260 involving floating point, convert the integers to floating point
6261 so that the resulting value does not suffer from catastrophic
6262 integer truncation. For example, on a 64-bit host (* 4
6263 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6264 Do not rely on undefined behavior after integer overflow.
6265
de883a70
PE
6266 merge count_size_as_multibyte, parse_str_to_multibyte
6267 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6268 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6269 Check for integer overflow.
6270 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6271 since it's now a duplicate of the other. This is more of
6272 a character than a buffer op, so better that it's in character.c.
6273 * fns.c, print.c: Adjust to above changes.
6274
2ff916cb
PE
62752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6276
6277 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6278
f1b54466
PE
62792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6280
fb1ac845
PE
6281 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6282 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6283 (x_clipboard_manager_save): Now static.
6284 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6285
f1b54466
PE
6286 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6287 (crypto_hash_function): Now static.
6288 Fix pointer signedness problems. Avoid unnecessary initializations.
6289
a9f737ee
CY
62902011-05-27 Chong Yidong <cyd@stupidchicken.com>
6291
6292 * termhooks.h (Vselection_alist): Make it terminal-local.
6293
6294 * terminal.c (create_terminal): Initialize it.
6295
6296 * xselect.c: Support for clipboard managers.
6297 (Vselection_alist): Move to termhooks.h as terminal-local var.
6298 (LOCAL_SELECTION): New macro.
6299 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6300 (symbol_to_x_atom): Remove gratuitous arg.
6301 (x_handle_selection_request, lisp_data_to_selection_data)
6302 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6303 (x_own_selection, x_get_local_selection, x_convert_selection):
6304 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6305 (some_frame_on_display): Delete unused function.
6306 (Fx_own_selection_internal, Fx_get_selection_internal)
6307 (Fx_disown_selection_internal, Fx_selection_owner_p)
6308 (Fx_selection_exists_p): New optional frame arg.
6309 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6310 (x_handle_selection_clear): Don't treat other terminals with the
6311 same keyboard specially. Use the terminal-local Vselection_alist.
6312 (x_clear_frame_selections): Use Frun_hook_with_args.
6313
6314 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6315
6316 * xterm.h: Add support for those atoms.
6317
e067f0c1
CY
63182011-05-26 Chong Yidong <cyd@stupidchicken.com>
6319
6320 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6321 (converted_selections, conversion_fail_tag): New global variables.
6322 (x_selection_request_lisp_error): Free the above.
6323 (x_get_local_selection): Remove unnecessary code.
6324 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6325 of converted selections stored in converted_selections.
6326 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6327 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6328 (x_convert_selection): New function.
6329 (x_handle_selection_event): Simplify.
6330 (x_get_foreign_selection): Don't ignore incoming requests while
6331 waiting for an answer; this will fail when we implement
6332 SAVE_TARGETS, and seems unnecessary anyway.
6333 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6334 (Vx_sent_selection_functions): Doc fix.
6335
0f4aebc0
LL
63362011-05-26 Leo Liu <sdl.web@gmail.com>
6337
6338 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6339
e61124cd
YM
63402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6341
6342 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6343
6344 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6345 for fringe update if it has periodic bitmap.
ac389d0c 6346 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6347 and fringe_bitmap_periodic_p.
6348
6349 * fringe.c (get_fringe_bitmap_data): New function.
6350 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6351 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6352 row. Mark glyph row for fringe update if periodicity changed.
6353
6354 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6355 for fringe update unless it has periodic bitmap.
6356
f16d9837
KH
63572011-05-25 Kenichi Handa <handa@m17n.org>
6358
6359 * xdisp.c (get_next_display_element): Set correct it->face_id for
6360 a static composition.
6361
e1b90ef6
LL
63622011-05-24 Leo Liu <sdl.web@gmail.com>
6363
6364 * deps.mk (fns.o):
6365 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6366
6367 * fns.c (crypto_hash_function, Fsha1): New function.
6368 (Fmd5): Use crypto_hash_function.
6369 (syms_of_fns): Add Ssha1.
6370
7400048f
PE
63712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6372
6373 * gnutls.c: Remove unused macros.
6374 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6375 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6376 Remove macros that are defined and never used.
6377 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6378
abb71cf4
CY
63792011-05-22 Chong Yidong <cyd@stupidchicken.com>
6380
6381 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6382 (Fx_get_selection_internal): Minor cleanup.
6383 (Fx_own_selection_internal): Rename arguments for consistency with
6384 select.el.
6385
6307db39
PE
63862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6387
6388 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6389
f3d4e0a4
CY
63902011-05-22 Chong Yidong <cyd@stupidchicken.com>
6391
6392 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6393
4d8ade89
YM
63942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6395
6396 * dispnew.c (scrolling_window): Don't exclude the case that the
6397 last enabled row in the desired matrix touches the bottom boundary.
6398
32078c8d
GM
63992011-05-21 Glenn Morris <rgm@gnu.org>
6400
6401 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6402 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6403 and add some more files.
32078c8d 6404
7285dc67
EZ
64052011-05-20 Eli Zaretskii <eliz@gnu.org>
6406
6407 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6408 report_file_error introduced by the change from 2011-05-07.
6409
89d1bd22
PE
64102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 * systime.h (Time): Define only if emacs is defined.
6413 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6414 where the include path doesn't have X11/X.h by default. See
6415 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6416
cd394be1 64172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6418
6419 * composite.c (find_automatic_composition): Fix previous change.
6420
b9704ad9
GM
64212011-05-20 Glenn Morris <rgm@gnu.org>
6422
6423 * lisp.mk: New file, split from Makefile.in.
6424 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6425 (shortlisp): Remove.
6426 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6427
4a720484
GM
64282011-05-19 Glenn Morris <rgm@gnu.org>
6429
6430 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6431 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6432 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6433 (lisp): Set the order to that of loadup.el.
6434 (shortlisp): Make it a copy of $lisp.
6435 (SOME_MACHINE_LISP): Remove.
6436 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6437 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6438
a28d4396
KH
64392011-05-18 Kenichi Handa <handa@m17n.org>
6440
6441 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6442 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6443 (find_automatic_composition): Mostly rewrite for efficiency.
6444
a2b1fa8e
JB
64452011-05-18 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * makefile.w32-in: Update dependencies.
6448
8e1f5610
CS
64492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6450
6451 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6452 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6453
7025ee00 64542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6455
cdfa6eab
PE
6456 Fix some integer overflow issues, such as string length overflow.
6457
06d6db33
PE
6458 * insdel.c (count_size_as_multibyte): Check for string overflow.
6459
2b4560a8
PE
6460 * character.c (lisp_string_width): Check for string overflow.
6461 Use EMACS_INT, not int, for string indexes and lengths; in
6462 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6463 the resulting string length overflows an EMACS_INT; instead,
6464 report a string overflow if no precision given. When checking for
6465 precision exhaustion, use a check that cannot possibly have
6466 integer overflow. (Bug#8675)
6467 * character.h (lisp_string_width): Adjust to new signature.
6468
cb93f9be
PE
6469 * alloc.c (string_overflow): New function.
6470 (Fmake_string): Use it. This doesn't change behavior, but saves
6471 a few bytes and will simplify future changes.
6472 * character.c (string_escape_byte8): Likewise.
6473 * lisp.h (string_overflow): New decl.
6474
1a1f3366
PE
6475 Fixups, following up to the user-interface timestamp change.
6476 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6477 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6478 * msdos.c (mouse_get_pos): Likewise.
6479 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6480 * w32gui.h (Time): Define by including "systime.h" rather than by
6481 declaring it ourselves. (Bug#8664)
6482
d4e3e4d3
PE
6483 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6484 * image.c (clear_image_cache): Likewise.
6485
f6a24d19
PE
6486 * term.c (term_mouse_position): Don't assume time_t wraparound.
6487
08dc5ae6
PE
6488 Be more systematic about user-interface timestamps.
6489 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6490 and sometimes 'EMACS_UINT', to represent these timestamps.
6491 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6492 This makes the code easier to follow, and makes it easier to catch
6493 integer overflow bugs such as Bug#8664.
6494 * frame.c (Fmouse_position, Fmouse_pixel_position):
6495 Use Time, not unsigned long, for user-interface timestamps.
6496 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6497 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6498 * keyboard.h (last_event_timestamp): Likewise.
6499 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6500 * menu.h (xmenu_show): Likewise.
6501 * term.c (term_mouse_position): Likewise.
6502 * termhooks.h (struct input_event.timestamp): Likewise.
6503 (struct terminal.mouse_position_hook): Likewise.
6504 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6505 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6506 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6507 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6508 what it was before.
6509 * menu.h, termhooks.h: Include "systime.h", for Time.
6510
8e55734a
PE
6511 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6512 Don't assume that the difference between two unsigned long values
6513 can fit into an integer. At this point, we know button_down_time
6514 <= event->timestamp, so the difference must be nonnegative, so
6515 there's no need to cast the result if double-click-time is
6516 nonnegative, as it should be; check that it's nonnegative, just in
6517 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6518 apart (about 25 days). (Bug#8664)
8e55734a 6519
841f1b75 6520 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6521 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6522
3e26f69c
PE
6523 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6524 that always fit in int. Use a sentinel instead of a counter, to
6525 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6526 * frame.h (struct frame): Use int for menu_bar_items_used
6527 instead of EMACS_INT, since it always fits in int.
3e26f69c 6528
5cc152c0
PE
6529 * menu.c (grow_menu_items): Check for int overflow.
6530
d89eb65e
PE
6531 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6532
5235bd3e
PE
6533 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6534 Before, the code was not consistent. These values cannot exceed
6535 2**31 - 1 so there's no need to make them unsigned.
6536 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6537 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6538 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6539 as modifiers.
6540 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6541
bc827e23
PE
6542 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6543 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6544 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6545 presumably because the widths might not match.
6546
78eb494e
PE
6547 * window.c (size_window): Avoid needless test at loop start.
6548
04f2d78b
CB
65492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6550
6551 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6552
d2fc7e3d 65532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6554
6555 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6556
d2fc7e3d 65572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6558
6559 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6560 `width' to `bar_area_x' and `bar_area_width', respectively.
6561 (x_scroll_run): Take account of fringe background extension.
6562
04f2d78b
CB
6563 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6564 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6565 `bar_area_width', respectively.
6566 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6567 background extension.
6568
79b70037
GM
65692011-05-10 Jim Meyering <meyering@redhat.com>
6570
6571 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6572
2f142cc5
JB
65732011-05-10 Juanma Barranquero <lekktu@gmail.com>
6574
6575 * image.c (Finit_image_library): Return t for built-in image types,
6576 like pbm and xbm. (Bug#8640)
6577
57679c86
AS
65782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6579
6580 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6581
888c9e86
EZ
65822011-05-07 Eli Zaretskii <eliz@gnu.org>
6583
b0512a1d
EZ
6584 * w32console.c (Fset_screen_color): Doc fix.
6585 (Fget_screen_color): New function.
6586 (syms_of_ntterm): Defsubr it.
6587
7285dc67
EZ
6588 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6589 unlink the temporary file if Fcall_process didn't create it in the
6590 first place.
6591 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6592 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6593 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6594 cue to call_process_cleanup not to close that handle.
6595
4d3fcc8e
BK
65962011-05-07 Ben Key <bkey76@gmail.com>
6597
6598 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6599 one of two shell specific rules, either bootstrap-temacs-CMD or
6600 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6601 to the previous implementation of the bootstrap-temacs rule.
6602 The bootstrap-temacs-CMD rule is similar to the previous
6603 implementation of the bootstrap-temacs rule except that it
6604 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6605 variable.
6606
6607 These changes, along with some changes to nt/configure.bat,
6608 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6609 earlier fix to add support for --cflags and --ldflags options
6610 that include quotes so that it works whether make uses cmd or
6611 sh as the shell.
6612
b4289b64
MA
66132011-05-06 Michael Albinus <michael.albinus@gmx.de>
6614
6615 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6616 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6617 is a constant.
6618 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6619 a string. Handle both cases.
6620 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6621 (Fdbus_register_method): Use Qinvalid_function.
6622
af4c0e28
JB
66232011-05-06 Juanma Barranquero <lekktu@gmail.com>
6624
6625 * makefile.w32-in: Update dependencies.
6626 (LISP_H): Add inttypes.h and stdin.h.
6627 (PROCESS_H): Add unistd.h.
6628
c51453d9
EZ
66292011-05-06 Eli Zaretskii <eliz@gnu.org>
6630
6631 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6632 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6633
8ff0ac3c 66342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6635
4c4b566b
PE
6636 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6637
aab2b9b5
PE
6638 * term.c (vfatal): Remove stray call to va_end.
6639 It's not needed and the C Standard doesn't allow it here anyway.
6640
c378da0b
PE
6641 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6642 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6643
288b08c7
PE
6644 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6645 bytes.
6646
e3601888
PE
6647 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6648
db6c0e74
PE
6649 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6650
dd5963ea
PE
6651 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6652
88c9450f
PE
6653 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6654
2f9442b8
PE
6655 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6656
c032b5f8
PE
6657 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6658 * charset.c (Fdefine_charset_internal): Don't initialize
6659 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6660 32-bit int (Bug#8600).
a108c10b
PE
6661
6662 * lread.c (read_integer): Be more consistent with string-to-number.
6663 Use string_to_number to do the actual conversion; this avoids
6664 rounding errors and fixes some other screwups. Without this fix,
6665 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6666 (digit_to_number): Move earlier, for benefit of read_integer.
6667 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6668 not a digit in any supported base. (Bug#8602)
a108c10b 6669
ad5f9eea
PE
6670 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6671
aec1708a
PE
6672 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6673 to match comment at start of function. This also removes a
6674 GCC warning about overflow in a 32+64-bit port.
6675
47be4ab5
PE
6676 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6677
371cac43
PE
6678 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6679 Reported by Stefan Monnier in
6680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6681 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6682 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6683
d01a7826
PE
6684 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6685 (EMACS_UINTPTR): Likewise, with uintptr_t.
6686
7fd47d5c
PE
6687 * lisp.h: Prefer 64-bit EMACS_INT if available.
6688 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6689 on 32-bit hosts that have 64-bit int, so that they can access
6690 large files.
122b0c86
PE
6691 However, temporarily disable this change unless the temporary
6692 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6693
8727937b
PE
6694 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6695
8ac068ac
PE
6696 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6697 This removes an assumption that EMACS_INT and long are the same
6698 width as pointers. The assumption is true for Emacs porting targets
6699 now, but we want to make other targets possible.
6700 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6701 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6702 In the rest of the code, change types of integers that hold casted
6703 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6704 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6705 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6706 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6707 No need to cast type when ORing.
6708 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6709 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6710 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6711 assume EMACS_INT is the same width as char *.
6712 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6713 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6714 Remove no-longer-needed casts.
6715 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6716 (xg_tool_bar_help_callback, xg_make_tool_item):
6717 Use EMACS_INTPTR to hold an integer
6718 that will be cast to void *; this can avoid a GCC warning
6719 if EMACS_INT is not the same width as void *.
6720 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6721 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6722 (current_message_1, set_message_1):
6723 Use a local to convert to proper width without a cast.
6724 * xmenu.c (dialog_selection_callback): Likewise.
6725
ede49d71
PE
6726 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6727 Also, don't assume VALBITS / RAND_BITS is less than 5,
6728 and don't rely on undefined behavior when shifting a 1 left into
6729 the sign bit.
6730 * lisp.h (get_random): Change signature to match.
6731
2f30ecd0
PE
6732 * lread.c (hash_string): Use size_t, not int, for hash computation.
6733 Normally we prefer signed values; but hashing is special, because
6734 it's better to use unsigned division on hash table sizes so that
6735 the remainder is nonnegative. Also, size_t is the natural width
6736 for hashing into memory. The previous code used 'int', which doesn't
6737 retain enough info to hash well into very large tables.
6738 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6739
2a866e7b
PE
6740 * dbusbind.c: Don't possibly lose pointer info when converting.
6741 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6742 Use XPNTR rather than XHASH, so that the high-order bits of
6743 the pointer aren't lost when converting through void *.
6744
51639eac
PE
6745 * eval.c (Fautoload): Don't double-shift a pointer.
6746
92394119
PE
6747 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6748
dbdb9a7c
JB
67492011-05-06 Juanma Barranquero <lekktu@gmail.com>
6750
6751 * gnutls.c (DEF_GNUTLS_FN):
6752 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6753
db7a0b4f
AS
67542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6755
6756 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6757 marker. (Bug#8610)
6758
cd394be1 67592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6760
6761 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6762 New version that can reserve upto 2GB of heap space.
6763
f7ff1b0f 67642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6765
6766 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6767
639c109b
TZ
67682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6769
6770 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6771 `gnutls_certificate_set_x509_key_file'.
6772
d2127135
JB
67732011-05-05 Juanma Barranquero <lekktu@gmail.com>
6774
6775 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6776 Update dependencies.
6777
e968f4f3
JB
67782011-05-04 Juanma Barranquero <lekktu@gmail.com>
6779
6780 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6781 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6782 Remove unused parameter `fildes'.
6783 * process.c (read_process_output, send_process): Don't pass it.
6784
84d358f0
JB
67852011-05-04 Juanma Barranquero <lekktu@gmail.com>
6786
6787 Fix previous change: the library cache is defined in w32.c.
6788 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6789 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6790
0898ca10
JB
67912011-05-04 Juanma Barranquero <lekktu@gmail.com>
6792
6793 Implement dynamic loading of GnuTLS on Windows.
6794
6795 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6796 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6797 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6798 Declare.
6799
6800 * gnutls.c (Qgnutls_dll): Define.
6801 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6802 (gnutls_*): Declare function pointers.
6803 (init_gnutls_functions): New function to initialize function pointers.
6804 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6805 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6806 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6807 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6808 (emacs_gnutls_write, emacs_gnutls_read)
6809 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6810 (Fgnutls_available_p): New function.
6811 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6812 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6813 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6814
6815 * image.c: Include w32.h.
6816 (Vimage_type_cache): Delete.
6817 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6818 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6819 (w32_delayed_load): Move to w32.c.
6820
6821 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6822
6823 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6824 (w32_delayed_load): Move from image.c. When loading a library, record
6825 its filename in the :loaded-from property of the library id.
6826 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6827 Initialize and staticpro them.
6828 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6829
6830 * process.c: Include lisp.h before w32.h, not after.
6831 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6832 instead of gnutls_record_check_pending.
6833
6834 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6835
ff4de4aa
TZ
68362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6837
6838 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6839 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6840 as passed in.
6841
abe95abb
JD
68422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6843
6844 * xterm.c (x_set_frame_alpha): Do not set property on anything
6845 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6846
e16e55d4
JB
68472011-05-02 Juanma Barranquero <lekktu@gmail.com>
6848
6849 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6850
bafcf6a5
JB
68512011-05-02 Juanma Barranquero <lekktu@gmail.com>
6852
6853 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6854 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6855 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6856 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6857 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6858 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6859 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6860 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6861 (Qgnutls_bootprop_callbacks_verify): Make static.
6862
e7a6747f
AS
68632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6864
19ed11ba
AS
6865 * callproc.c: Indentation fixup.
6866
e7a6747f 6867 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6868 (wait_for_termination, interruptible_wait_for_termination):
6869 Move after wait_for_termination_1.
e7a6747f 6870
1ef14cb4
LMI
68712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6872
6873 * sysdep.c (interruptible_wait_for_termination): New function
6874 which is like wait_for_termination, but allows keyboard
6875 interruptions.
6876
6877 * callproc.c (Fcall_process): Add (:file "file") as an option for
6878 the STDOUT buffer.
6879 (Fcall_process_region): Ditto.
6880
330d880c
EZ
68812011-04-30 Eli Zaretskii <eliz@gnu.org>
6882
8db90b73
EZ
6883 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6884 rather than `XVECTOR (FOO)->size'.
6885
330d880c
EZ
6886 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6887 inttypes.h, as a gnulib replacement is used if it not available in
6888 system headers.
6889
15cbd324
EZ
68902011-04-21 Eli Zaretskii <eliz@gnu.org>
6891
6892 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6893 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6894 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6895
6896 * coding.c (coding_alloc_by_realloc): Error out if destination
6897 will grow beyond MOST_POSITIVE_FIXNUM.
6898 (decode_coding_emacs_mule): Abort if there isn't enough place in
6899 charbuf for the composition carryover bytes. Reserve an extra
6900 space for up to 2 characters produced in a loop.
6901 (decode_coding_iso_2022): Abort if there isn't enough place in
6902 charbuf for the composition carryover bytes.
6903
69042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6905
ae940cca
EZ
6906 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6907 aborting when %lld or %lll format is passed.
6908 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6909 %llo or %llx format is passed. (Bug#8545)
6910
03ab8921
EZ
6911 * window.c (window_scroll_line_based): Use a marker instead of
6912 simple variables to record original value of point. (Bug#7952)
6913
afda1437
EZ
6914 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6915 produced by %s or %c overflows available buffer space. (Bug#8545)
6916
f76dee0c
PE
69172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6918
6919 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6920 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6921
fdc5744d
JB
69222011-04-28 Juanma Barranquero <lekktu@gmail.com>
6923
6924 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6925
638f053a
JB
69262011-04-28 Juanma Barranquero <lekktu@gmail.com>
6927
6928 * keyboard.c (Qdelayed_warnings_hook): Define.
6929 (command_loop_1): Run `delayed-warnings-hook'
6930 if Vdelayed_warnings_list is non-nil.
6931 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6932 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6933
d178f871
EZ
69342011-04-28 Eli Zaretskii <eliz@gnu.org>
6935
6936 * doprnt.c (doprnt): Don't return value smaller than the buffer
6937 size if the message was truncated. (Bug#8545).
6938
b124fd93
JB
69392011-04-28 Juanma Barranquero <lekktu@gmail.com>
6940
6941 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6942 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6943
e810457d
PE
69442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6945
6946 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6947
ea51cceb
JB
69482011-04-27 Juanma Barranquero <lekktu@gmail.com>
6949
6950 * makefile.w32-in: Update dependencies.
6951
94dcfacf
EZ
69522011-04-27 Eli Zaretskii <eliz@gnu.org>
6953
6954 Improve `doprnt' and its usage. (Bug#8545)
6955 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6956 `format_end'. Remove support for %l as a conversion specifier.
6957 Don't use xrealloc. Improve diagnostics when the %l size modifier
6958 is used. Update the commentary.
6959
6960 * eval.c (verror): Simplify calculation of size_t.
6961
6962 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6963 messages.
6964
f61f41d7
PE
69652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6966
6967 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6968 change.
6969
96fb4434
PE
69702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6971
6972 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6973 This makes this file independent of the recent pseudovector change.
6974
671875da 69752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6976
69e9b5a3
PE
6977 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6978
b5f869a7 6979 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6980 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6981 Remove unused local.
c8926152 6982 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6983
841a1577 6984 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6985 GCC 4.6.0 optimizes based on type-based alias analysis.
6986 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6987 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6988 != &v->size, and therefore "v->size = 1; b->size = 2; return
6989 v->size;" must therefore return 1. This assumption is incorrect
6990 for Emacs, since it type-puns struct Lisp_Vector * with many other
6991 types. To fix this problem, this patch adds a new type struct
f904488f 6992 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6993 and pseudovectors, and helps optimizing compilers not get fooled
6994 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6995 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6996 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6997 the size member.
eab3844f
PE
6998 (XSETPVECTYPE): Rewrite in terms of new macro.
6999 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7000 This is a bit clearer, and further avoids the possibility of
7001 undesirable aliasing.
7002 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7003 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7004 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7005 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7006 (ASIZE): Now uses header.size rather than size.
7007 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7008 to avoid the hassle of writing XVECTOR (foo)->header.size.
7009 (struct vectorlike_header): New type.
eab3844f
PE
7010 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7011 object, to help avoid aliasing.
7012 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7013 (SUBRP): Likewise, since Lisp_Subr is a special case.
7014 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7015 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7016 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7017 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7018 changed to be "header.size" and "header.next".
7019 * buffer.h (struct buffer): Likewise.
7020 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7021 * frame.h (struct frame): Likewise.
7022 * process.h (struct Lisp_Process): Likewise.
7023 * termhooks.h (struct terminal): Likewise.
7024 * window.c (struct save_window_data, struct saved_window): Likewise.
7025 * window.h (struct window): Likewise.
7026 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7027 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7028 * buffer.c (init_buffer_once): Likewise.
7029 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7030 special case.
7031 * process.c (Fformat_network_address): Use local var for size,
7032 for brevity.
7033
0df1eac5
PE
7034 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7035
847ab9d1 7036 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7037 * data.c (atof): Remove decl; no longer used or needed.
7038 (digit_to_number): Move to lread.c.
7039 (Fstring_to_number): Use new string_to_number function, to be
7040 consistent with how the Lisp reader treats infinities and NaNs.
7041 Do not assume that floating-point numbers represent EMACS_INT
7042 without losing information; this is not true on most 64-bit hosts.
7043 Avoid double-rounding errors, by insisting on integers when
7044 parsing non-base-10 numbers, as the documentation specifies.
7045 * lisp.h (string_to_number): New decl, replacing ...
7046 (isfloat_string): Remove.
bc0a5c13 7047 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7048 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7049 appears to have been a coding error. Similarly, do not accept
7050 strings like +-1e0 as floating point numbers. Do not report
7051 overflow for integer overflows unless the base is not 10 which
7052 means we have no simple and reliable way to continue.
7053 Break out the floating-point parsing into a new
7054 function string_to_number, so that Fstring_to_number parses
7055 floating point numbers consistently with the Lisp reader.
04f2d78b 7056 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7057 (E_CHAR, EXP_INT): Remove, replacing with ...
7058 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7059 (string_to_number): New function, replacing isfloat_string.
7060 This function checks for valid syntax and produces the resulting
7061 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7062 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7063 so that overflow for non-base-10 numbers is reported only when
7064 there's no portable and simple way to convert to floating point.
452f4150 7065
67769ffc
PE
7066 * textprop.c (set_text_properties_1): Rewrite for clarity,
7067 and to avoid GCC warning about integer overflow.
7068
c20db43f
PE
7069 * intervals.h (struct interval): Use EMACS_INT for members
7070 where EMACS_UINT might cause problems. See
7071 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7072 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7073 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7074 All uses changed.
37aa2f85
PE
7075 (offset_intervals): Tell GCC not to worry about length overflow
7076 when negating a negative length.
c20db43f 7077
2538aa2f
PE
7078 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7079 (overrun_check_free): Likewise.
7080
f2d3008d
PE
7081 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7082 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7083 word size.
7084
ec8df744
PE
7085 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7086 (gnutls_make_error): Rename local to avoid shadowing.
7087 (gnutls_emacs_global_deinit): ifdef out; not used.
7088 (Fgnutls_boot): Use const for pointer to readonly storage.
7089 Comment out unused local. Fix pointer signedness problems.
7090
640ee02d
PE
7091 * lread.c (openp): Don't stuff size_t into an 'int'.
7092 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7093 about possible signed overflow.
7094
6048fb2a
PE
7095 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7096 (GDK_KEY_g): Don't define if already defined.
7097 (xg_prepare_tooltip): Avoid pointer signedness problem.
7098 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7099
fa3c87e1
PE
7100 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7101 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7102
2172544b
PE
7103 * xfns.c (Fx_window_property): Simplify a bit,
7104 to make a bit faster and to avoid GCC 4.6.0 warning.
7105 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7106
9b821a21
PE
7107 * fns.c (internal_equal): Don't assume size_t fits in int.
7108
3c616cfa
PE
7109 * alloc.c (compact_small_strings): Tighten assertion a little.
7110
c2982e87
PE
7111 Replace pEd with more-general pI, and fix some printf arg casts.
7112 * lisp.h (pI): New macro, generalizing old pEd macro to other
7113 conversion specifiers. For example, use "...%"pI"d..." rather
7114 than "...%"pEd"...".
7115 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7116 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7117 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7118 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7119 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7120 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7121 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7122 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7123 64-bit hosts.
7124 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7125 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7126 * print.c (safe_debug_print, print_object): Likewise.
7127 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7128 to int.
6f04d126
PE
7129 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7130 avoiding the 0 flag, which is not portable.
c2982e87
PE
7131 * process.c (Fmake_network_process): Use pI to avoid cast.
7132 * region-cache.c (pp_cache): Likewise.
7133 * xdisp.c (decode_mode_spec): Likewise.
7134 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7135 behavior on 64-bit hosts with printf arg.
6f04d126 7136 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7137 (x_stop_queuing_selection_requests): Likewise.
7138 (x_get_window_property): Don't truncate byte count to an 'int'
7139 when tracing.
0b432f21 7140
5e073ec7
PE
7141 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7142 here, since it parses constructs like leading '-' and spaces,
7143 which are not wanted; and it overflows with large numbers.
7144 Instead, simply match F[0-9]+, which is what is wanted anyway.
7145
36372bf9
PE
7146 * alloc.c: Remove unportable assumptions about struct layout.
7147 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7148 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7149 (allocate_vectorlike, make_pure_vector): Use the new macros,
7150 plus offsetof, to remove unportable assumptions about struct layout.
7151 These assumptions hold on all porting targets that I know of, but
7152 they are not guaranteed, they're easy to remove, and removing them
7153 makes further changes easier.
7154
0b432f21
PE
7155 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7156 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7157 (string_overrun_cookie): Now const. Use initializers that
7158 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7159 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7160 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7161 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7162 multiple of sizeof (EMACS_INT); it need not be, if
7163 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7164 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7165
895009e1
JB
71662011-04-26 Juanma Barranquero <lekktu@gmail.com>
7167
7168 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7169
6a7a1b0b
TZ
71702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7171
7172 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7173 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7174 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7175
841a1577 71762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7177
7178 * lisp.h (Qdebug): List symbol.
895009e1 7179 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7180 * keyboard.c (debug-on-event): New variable.
7181 (handle_user_signal): Break into debugger when debug-on-event
7182 matches the current signal symbol.
7183
f2d3ba6f
DN
71842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7185
7186 * alloc.c (check_sblock, check_string_bytes)
7187 (check_string_free_list): Convert to standard C.
7188
42ce4c63
TZ
71892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7190
7191 * w32.c (emacs_gnutls_push): Fix typo.
7192
825cd63c
EZ
71932011-04-25 Eli Zaretskii <eliz@gnu.org>
7194
fb11d64d
EZ
7195 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7196 "cast to pointer from integer of different size".
7197
825cd63c
EZ
7198 Improve doprnt and its use in verror. (Bug#8545)
7199 * doprnt.c (doprnt): Document the set of format control sequences
7200 supported by the function. Use SAFE_ALLOCA instead of always
7201 using `alloca'.
7202
7203 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7204 is one byte too soon. Don't use xrealloc; instead xfree and
7205 xmalloc anew.
7206
e061a11b
TZ
72072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7208
7209 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7210 callbacks stage.
7211
7212 * gnutls.c: Renamed global_initialized to
7213 gnutls_global_initialized. Added internals for the
7214 :verify-hostname-error, :verify-error, and :verify-flags
7215 parameters of `gnutls-boot' and documented those parameters in the
7216 docstring. Start callback support.
9173deec
JB
7217 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7218 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7219 on error. Return error code.
e061a11b
TZ
7220 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7221 (emacs_gnutls_read): Likewise.
7222 (Fgnutls_boot): Return handshake error code.
7223 (emacs_gnutls_handle_error): New function.
7224 (wsaerror_to_errno): Likewise.
7225
7226 * w32.h (emacs_gnutls_pull): Add prototype.
7227 (emacs_gnutls_push): Likewise.
7228
7229 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7230 (emacs_gnutls_push): Likewise.
7231
72322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7233
7234 * process.c (wait_reading_process_output): Check if GnuTLS
7235 buffered some data internally if no FDs are set for TLS
7236 connections.
7237
7238 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7239 (LIBS): Link to USER_LIBS.
7240 ($(BLD)/gnutls.$(0)): New target.
7241
fa6996bc
EZ
72422011-04-24 Eli Zaretskii <eliz@gnu.org>
7243
eb35682e
EZ
7244 * xdisp.c (handle_single_display_spec): Rename the
7245 display_replaced_before_p argument into display_replaced_p, to
7246 make it consistent with the commentary. Fix typos in the
7247 commentary.
7248
e2ad650c
EZ
7249 * textprop.c (syms_of_textprop): Remove dead code.
7250 (copy_text_properties): Delete obsolete commentary about an
7251 interface that was deleted long ago. Fix typos in the description
7252 of arguments.
7253
1b2de274
EZ
7254 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7255 to changes in oldXMenu/XMenu.h from 2011-04-16.
7256 <menu_help_message, prev_menu_help_message>: Constify.
7257 (IT_menu_make_room): menu->help_text is now `const char **';
7258 adjust.
7259
7260 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7261 to changes in oldXMenu/XMenu.h from 2011-04-16.
7262 (struct XMenu): Declare `help_text' `const char **'.
7263
7264 * xfaces.c <Qunspecified>: Make extern again.
7265
7266 * syntax.c: Include sys/types.h before including regex.h, as
7267 required by Posix.
7268
762b15be
EZ
7269 * doc.c (get_doc_string): Improve the format passed to `error'.
7270
7271 * doprnt.c (doprnt): Improve commentary.
7272
7273 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7274
7275 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7276 them with etags.
7277
f1052e5d
EZ
7278 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7279 changes in globals.h immediately force recompilation.
762b15be
EZ
7280 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7281 $(CURDIR)/s/ms-w32.h.
7282 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7283
fa6996bc
EZ
7284 * character.c (Fchar_direction): Function deleted.
7285 (syms_of_character): Don't defsubr it.
7286 <char-direction-table>: Deleted.
7287
e6c3da20
EZ
72882011-04-23 Eli Zaretskii <eliz@gnu.org>
7289
7290 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7291 * doprnt.c: Include limits.h.
7292 (SIZE_MAX): New macro.
04f2d78b
CB
7293 (doprnt): Return a size_t value. 2nd arg is now size_t.
7294 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7295 Improve overflow protection. Support `l' modifier for integer
7296 conversions. Support %l conversion. Don't assume an EMACS_INT
7297 argument for integer conversions and for %c.
7298
7299 * lisp.h (doprnt): Restore prototype.
7300
7301 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7302 $(SRC)/character.h.
7303
7304 * Makefile.in (base_obj): Add back doprnt.o.
7305
7306 * deps.mk (doprnt.o): Add back prerequisites.
7307 (callint.o): Depend on character.h.
7308
7309 * eval.c (internal_lisp_condition_case): Include the handler
7310 representation in the error message.
7311 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7312 when breaking from the loop.
7313
7314 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7315
7316 * callint.c (Fcall_interactively): When displaying error message
7317 about invalid control letter, pass the character's codepoint, not
7318 a pointer to its multibyte form. Improve display of the character
7319 in octal and display also its hex code.
7320
7321 * character.c (char_string): Use %x to display the (unsigned)
7322 codepoint of an invalid character, to avoid displaying a bogus
7323 negative value.
7324
7325 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7326 `error', not SYMBOL_NAME itself.
7327
7328 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7329 character arguments to `error'.
7330
7331 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7332 to `error' in error message about FINAL_CHAR argument. Make sure
7333 FINAL_CHAR is a character, and use %c when it is passed as
7334 argument to `error'.
7335
4ffd0d6b 73362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7337
7338 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7339
7340 * w32.c: Include <time.h>.
7341 (sys_localtime): New function.
7342
4ffd0d6b 73432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7344
7345 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7346
4ffd0d6b 7347 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7348
4ffd0d6b 73492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7350
4ffd0d6b
GM
7351 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7352 zombies (Bug#8467).
aac0c6e3 7353
04c56954
EZ
73542011-04-19 Eli Zaretskii <eliz@gnu.org>
7355
7356 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7357 gl_state.e_property when gl_state.object is Qt.
7358
7359 * insdel.c (make_gap_larger): Remove limitation of buffer size
7360 to <= INT_MAX.
7361
16a43933
CY
73622011-04-18 Chong Yidong <cyd@stupidchicken.com>
7363
7364 * xdisp.c (lookup_glyphless_char_display)
7365 (produce_glyphless_glyph): Handle cons cell entry in
7366 glyphless-char-display.
7367 (Vglyphless_char_display): Document it.
7368
7369 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7370 glyphless-char-display.
7371
4581706e
CY
73722011-04-17 Chong Yidong <cyd@stupidchicken.com>
7373
7374 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7375
7376 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7377
7378 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7379 definition for no-X builds.
7380
4887c6e2 73812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7382
fd35b6f9
PE
7383 Static checks with GCC 4.6.0 and non-default toolkits.
7384
5c1ccb01
PE
7385 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7386
006c5daa
PE
7387 * process.c (keyboard_bit_set): Define only if SIGIO.
7388 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7389 (send_process): Repair possible setjmp clobbering.
7390
efc736d3
PE
7391 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7392
4e2fe2e6
PE
7393 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7394
f97334a2
PE
7395 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7396
4e75f29d
PE
7397 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7398 Define only if needed.
7399
90efadd1
PE
7400 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7401 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7402 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7403
3c647824
PE
7404 * dispextern.h (struct redisplay_interface): Rename param
7405 to avoid shadowing.
e264f262 7406 * termhooks.h (struct terminal): Likewise.
761383f4 7407 * xterm.c (xembed_send_message): Likewise.
3c647824 7408
b58c5c4a
PE
7409 * insdel.c (make_gap_smaller): Define only if
7410 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7411
cad59032
PE
7412 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7413 it.
7414
c339dc2e
PE
7415 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7416 so that we aren't warned about unused symbols.
7417
91a3e27b
PE
7418 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7419
399c71d3 7420 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7421
8ffc96f5
PE
7422 * xfns.c (x_real_positions): Mark locals as initialized.
7423
eef9bc79
PE
7424 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7425
098db9dd
PE
7426 * xterm.c: Fix problems found by static analysis with other toolkits.
7427 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7428 (x_dispatch_event): Declare static if USE_GTK, and
7429 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7430 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7431 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7432 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7433 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7434
eb18f6cc
PE
7435 * xmenu.c (menu_help_callback): Pointer type fixes.
7436 Use const pointers when pointing at readonly data. Avoid pointer
7437 signedness clashes.
7438 (FALSE): Remove unused macro.
7439 (update_frame_menubar): Remove unused decl.
7440
1fe72bf8
PE
7441 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7442
60d9e1db
PE
7443 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7444 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7445 (single_menu_item): Rename local to avoid shadowing.
7446
39261c26
PE
7447 * keyboard.c (make_lispy_event): Remove unused local var.
7448
018c5e19
PE
7449 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7450 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7451
63d2b86e
PE
7452 * bitmaps: Change bitmaps from unsigned char back to the X11
7453 compatible char. Avoid the old compiler warnings about
7454 out-of-range initializers by using, for example, '\xab' rather
7455 than 0xab.
7456
aefd87e1
PE
7457 * xgselect.c (xgselect_initialize): Check vs interface
7458 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7459
bf501fb9
PE
7460 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7461
e9829fdf
PE
7462 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7463 to read-only memory.
7464
1086c095
PE
7465 * fns.c (vector): Remove; this old hack is no longer needed.
7466
2baccd04 7467 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7468 Remove unused var.
dde42981 7469 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7470
72391843 7471 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7472
436c16df 7473 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7474 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7475 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7476
92bb796d 7477 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7478 (x_term_init): Remove local to avoid shadowing.
92bb796d 7479
764430a3 7480 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7481
7482 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7483 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7484
d1dfb56c
EZ
74852011-04-16 Eli Zaretskii <eliz@gnu.org>
7486
c4354cb4
EZ
7487 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7488
d1dfb56c
EZ
7489 Fix regex.c, syntax.c and friends for buffers > 2GB.
7490 * syntax.h (struct gl_state_s): Declare character position members
7491 EMACS_INT.
7492
7493 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7494
04f2d78b
CB
7495 * textprop.c (verify_interval_modification, interval_of):
7496 Declare arguments EMACS_INT.
d1dfb56c
EZ
7497
7498 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7499 EMACS_INT.
7500
7501 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7502
7503 * indent.c (Fvertical_motion): Local variable it_start is now
7504 EMACS_INT.
7505
7506 * regex.c (re_match, re_match_2, re_match_2_internal)
7507 (bcmp_translate, regcomp, regexec, print_double_string)
7508 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7509 (re_compile_pattern, re_exec): Declare arguments and local
7510 variables `size_t' and `ssize_t' and return values `regoff_t', as
7511 appropriate.
7512 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7513 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7514 <compile_stack_type>: `size' and `avail' are now `size_t'.
7515
7516 * regex.h <regoff_t>: Use ssize_t, not int.
7517 (re_search, re_search_2, re_match, re_match_2): Arguments that
7518 specify buffer/string position and length are now ssize_t and
7519 size_t. Return type is regoff_t.
7520
613052cd
BK
75212011-04-16 Ben Key <bkey76@gmail.com>
7522
7523 * nsfont.m: Fixed bugs in ns_get_family and
7524 ns_descriptor_to_entity that were caused by using free to
7525 deallocate memory blocks that were allocated by xmalloc (via
7526 xstrdup). This caused Emacs to crash when compiled with
7527 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7528 --enable-checking=xmallocoverrun). xfree is now used to
7529 deallocate these memory blocks.
7530
4170f62f 75312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7532
71b41406
PE
7533 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7534
9587a89d
PE
7535 emacs_write: Accept and return EMACS_INT for sizes.
7536 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7537 et seq.
7538 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7539 Accept and return EMACS_INT.
7540 (emacs_gnutls_write): Return the number of bytes written on
7541 partial writes.
7542 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7543 (emacs_read, emacs_write): Remove check for negative size, as the
7544 Emacs source code has been audited now.
9587a89d
PE
7545 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7546 (emacs_read, emacs_write): Use it.
273a5f82
PE
7547 * process.c (send_process): Adjust to the new signatures of
7548 emacs_write and emacs_gnutls_write. Do not attempt to store
7549 a byte offset into an 'int'; it might overflow.
9587a89d 7550 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7551
3e047f51
PE
7552 * sound.c: Don't assume sizes fit in 'int'.
7553 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7554 Return EMACS_INT, not int.
3e047f51 7555 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7556 Accept EMACS_INT, not int.
7557 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7558 record read return values.
7559
cc39a9db
BK
75602011-04-15 Ben Key <bkey76@gmail.com>
7561
c9d0ec6d
JB
7562 * keyboard.c (Qundefined): Don't declare static since it is used
7563 in nsfns.m.
7564 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7565 static since they are used in nsfont.m.
cc39a9db 7566
6c60eb9f
SM
75672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7568
7569 * process.c (Qprocessp): Don't declare static.
7570 * lisp.h (Qprocessp): Declare again.
7571
7990b61a
JB
75722011-04-15 Juanma Barranquero <lekktu@gmail.com>
7573
7574 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7575
5d4cb038
PE
75762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7577
8bd7b830 7578 Improve C-level modularity by making more things 'static'.
cd64ea1d 7579
e3b27b31
PE
7580 Don't publish debugger-only interfaces to other modules.
7581 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7582 (verify_bytepos, count_markers): Move decls to the only modules
7583 that need them.
7584 * region-cache.h (pp_cache): Likewise.
7585 * window.h (check_all_windows): Likewise.
7586 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7587
5d4cb038
PE
7588 * sysdep.c (croak): Now static, if
7589 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7590 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7591
7592 * alloc.c (refill_memory_reserve): Now static if
7593 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7594 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7595
e87b6180
PE
7596 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7597 Define only if USE_LUCID.
7598
ac64929e
PE
7599 * xrdb.c (x_customization_string, x_rm_string): Now static.
7600
6f37259d
PE
7601 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7602 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7603
1683e3ab
PE
7604 * xdisp.c (draw_row_with_mouse_face): Now static.
7605 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7606
de9c2632
PE
7607 * window.h (check_all_windows): Mark externally visible.
7608
2b96acb7
PE
7609 * window.c (window_deletion_count): Now static.
7610
7611 * undo.c: Make symbols static if they're not exported.
7612 (last_undo_buffer, last_boundary_position, pending_boundary):
7613 Now static.
7614
50436f33
PE
7615 * textprop.c (interval_insert_behind_hooks): Now static.
7616 (interval_insert_in_front_hooks): Likewise.
7617
64520e5c
PE
7618 * term.c: Make symbols static if they're not exported.
7619 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7620 (max_frame_lines, tty_set_terminal_modes):
7621 (tty_reset_terminal_modes, tty_turn_off_highlight):
7622 (get_tty_terminal): Now static.
7623 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7624 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7625 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7626 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7627 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7628
1fa53021
PE
7629 * sysdep.c: Make symbols static if they're not exported.
7630 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7631 Now static.
7632 (sigprocmask_set, full_mask): Remove; unused.
7633 (wait_debugging): Mark as visible.
7634 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7635 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7636
d4b43b22
PE
7637 * syntax.c (syntax_temp): Define only if !__GNUC__.
7638
b7c513d0
PE
7639 * sound.c (current_sound_device, current_sound): Now static.
7640
989b29ad
PE
7641 * search.c (searchbufs, searchbuf_head): Now static.
7642
13a55a78
PE
7643 * scroll.c (scroll_cost): Remove; unused.
7644 * dispextern.h (scroll_cost): Remove decl.
7645
de68a1fc
PE
7646 * region-cache.h (pp_cache): Mark as externally visible.
7647
40ccffa6
PE
7648 * process.c: Make symbols static if they're not exported.
7649 (process_tick, update_tick, create_process, chan_process):
7650 (Vprocess_alist, proc_buffered_char, datagram_access):
7651 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7652 (deactivate_process): Mark defn as static, as well as decl.
7653 * lisp.h (create_process): Remove decl.
7654 * process.h (chan_process, Vprocess_alist): Remove decls.
7655
ad64fc97
PE
7656 * print.c: Make symbols static if they're not exported.
7657 (print_depth, new_backquote_output, being_printed, print_buffer):
7658 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7659 (print_interval, print_number_index, initial_stderr_stream):
7660 Now static.
7661 * lisp.h (Fprinc): Remove decl.
7662 (debug_output_compilation_hack): Mark as externally visible.
7663
adddb265
PE
7664 * sysdep.c (croak): Move decl from here to syssignal.h.
7665 * syssignal.h (croak): Put it here, so the API can be checked when
7666 'croak' is called from dissociate_if_controlling_tty.
7667
1717ede2
PE
7668 * minibuf.c: Make symbols static if they're not exported.
7669 (minibuf_save_list, choose_minibuf_frame): Now static.
7670 * lisp.h (choose_minibuf_frame): Remove decl.
7671
fa5fb2bc
PE
7672 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7673
1e3890d1
PE
7674 * lread.c: Make symbols static if they're not exported.
7675 (read_objects, initial_obarray, oblookup_last_bucket_number):
7676 Now static.
7677 (make_symbol): Remove; unused.
7678 * lisp.h (initial_obarray, make_symbol): Remove decls.
7679
8a1414fa
PE
7680 * keyboard.c: Make symbols static if they're not exported.
7681 (single_kboard, recent_keys_index, total_keys, recent_keys):
7682 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7683 (this_single_command_key_start, echoing, last_auto_save):
7684 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7685 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7686 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7687 (Vlispy_mouse_stem, double_click_count):
7688 Now static.
7689 (force_auto_save_soon): Define only if SIGDANGER.
7690 (ignore_mouse_drag_p): Now static if
7691 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7692 (print_help): Remove; unused.
7693 (stop_character, last_timer_event): Mark as externally visible.
7694 * keyboard.h (ignore_mouse_drag_p): Declare only if
7695 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7696 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7697 * lisp.h (echoing): Remove decl.
7698 (force_auto_save_soon): Declare only if SIGDANGER.
7699 * xdisp.c (redisplay_window): Simplify code, to make it more
7700 obvious that ignore_mouse_drag_p is not accessed if !defined
7701 USE_GTK && !defined HAVE_NS.
7702
93ea6e8f
PE
7703 * intervals.c: Make symbols static if they're not exported.
7704 (merge_properties_sticky, merge_interval_right, delete_interval):
7705 Now static.
7706 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7707
77382fcc
PE
7708 * insdel.c: Make symbols static if they're not exported.
7709 However, leave prepare_to_modify_buffer alone. It's never
7710 called from outside this function, but that appears to be a bug.
7711 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7712 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7713 (adjust_after_replace_noundo): Remove; unused.
7714 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7715 (signal_before_change): Remove decls.
77382fcc 7716
9306c32e
PE
7717 * indent.c (val_compute_motion, val_vmotion): Now static.
7718
cd44d2eb
PE
7719 * image.c: Make symbols static if they're not exported.
7720 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7721 if USE_GTK.
7722 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7723 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7724
ad9a7a06
PE
7725 * fringe.c (standard_bitmaps): Now static.
7726 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7727
81626931
PE
7728 * frame.c: Make symbols static if they're not exported.
7729 (x_report_frame_params, make_terminal_frame): Now static.
7730 (get_frame_param): Now static, unless HAVE_NS.
7731 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7732 (x_get_resource_string): Remove; not used.
7733 * frame.h (make_terminal_frame, x_report_frame_params):
7734 (x_get_resource_string); Remove decls.
7735 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7736 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7737
239f9db9
PE
7738 * font.c, fontset.c: Make symbols static if they're not exported.
7739 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7740 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7741 * font.c (font_close_object): Now static.
7742 * font.h (font_close_object): Remove.
7743 * fontset.c (FONTSET_OBJLIST): Remove.
7744 (free_realized_fontset) #if-0 the body, which does nothing.
7745 (face_suitable_for_char_p): #if-0, as it's never called.
7746 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7747 * xfaces.c (face_at_string_position):
7748 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7749 since 0 is always ASCII.
7750
dfcf3579
PE
7751 * fns.c (weak_hash_tables): Now static.
7752
5045092b
PE
7753 * fileio.c: Make symbols static if they're not exported.
7754 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7755 (Vwrite_region_annotation_buffers): Now static.
7756
57a96f5c
PE
7757 * eval.c: Make symbols static if they're not exported.
7758 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7759 * lisp.h (backtrace_list): Remove decl.
7760
35f08c38
PE
7761 * emacs.c: Make symbols static if they're not exported.
7762 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7763 (fatal_error_code, fatal_error_signal_hook, standard_args):
7764 Now static.
7765 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7766 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7767 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7768 * lisp.h (fatal_error_signal_hook): Remove decl.
7769 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7770
f44bd759
PE
7771 * editfns.c: Move a (normally-unused) function to its only use.
7772 * editfns.c, lisp.h (get_operating_system_release): Remove.
7773 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7774 worth the hassle of breaking this out.
7775
b532497d
PE
7776 * xterm.c: Make symbols static if they're not exported.
7777 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7778 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7779 (x_destroy_window, x_delete_display):
7780 Now static.
7781 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7782 (x_mouse_leave): Remove; unused.
7783 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7784 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7785 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7786 Remove decls.
7787 (x_mouse_leave): Declare only if WINDOWSNT.
7788 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7789 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7790 USE_X_TOOLKIT.
7791
1675728f
PE
7792 * ftxfont.c: Make symbols static if they're not exported.
7793 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7794 HAVE_FREETYPE.
7795 * font.h (ftxfont_driver): Likewise.
7796
e4cebfca
PE
7797 * xfns.c: Make symbols static if they're not exported.
7798 (x_last_font_name, x_display_info_for_name):
7799 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7800 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7801 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7802 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7803 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7804 (last_show_tip_args): Now static.
7805 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7806 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7807 (x_screen_planes): Remove; unused.
7808 * dispextern.h (x_screen_planes): Remove decl.
7809
5bf46f05
PE
7810 * dispnew.c: Make symbols static if they're not exported.
7811 * dispextern.h (redraw_garbaged_frames, scrolling):
7812 (increment_row_positions): Remove.
7813 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7814 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7815 Now static.
7816 (redraw_garbaged_frames): Remove; unused.
7817
435f4c28
PE
7818 * xfaces.c: Make symbols static if they're not exported.
7819 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7820 Remove decls.
7821 * xterm.h (defined_color): Remove decls.
7822 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7823 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7824 (menu_face_changed_default, defined_color, free_realized_face):
7825 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7826 (ascii_face_of_lisp_face): Remove; unused.
7827
8524aef3
PE
7828 * xdisp.c: Make symbols static if they're not exported.
7829 * dispextern.h (scratch_glyph_row, window_box_edges):
7830 (glyph_to_pixel_coords, set_cursor_from_row):
7831 (get_next_display_element, set_iterator_to_next):
7832 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7833 (show_mouse_face): Remove decls
7834 * frame.h (message_buf_print): Likewise.
7835 * lisp.h (pop_message, set_message, check_point_in_composition):
7836 Likewise.
7837 * xterm.h (set_vertical_scroll_bar): Likewise.
7838 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7839 (message_buf_print, scratch_glyph_row, displayed_buffer):
7840 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7841 (get_next_display_element, show_mouse_face, window_box_edges):
7842 (frame_to_window_pixel_xy, check_point_in_composition):
7843 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7844 (glyph_to_pixel_coords): Remove; unused.
7845
16390cd2
PE
7846 * dired.c (file_name_completion): Now static.
7847
7848 * dbusbind.c (xd_in_read_queued_messages): Now static.
7849
a25f4dfa
PE
7850 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7851 * data.c (circular_list_error): Remove.
7852
14a9c8df
PE
7853 * commands.h (last_point_position, last_point_position_buffer):
7854 (last_point_position_window): Remove decls.
7855 * keyboard.c: Make these variables static.
7856
04f2d78b
CB
7857 * coding.h (coding, code_convert_region, encode_coding_gap):
7858 Remove decls.
74ab6df5
PE
7859 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7860 (iso_code_class, detect_coding, code_convert_region): Now static.
7861 (encode_coding_gap): Remove; unused.
7862
38dfbee1
PE
7863 * chartab.c (chartab_chars, chartab_bits): Now static.
7864
a2cb4e63
PE
7865 * charset.h (charset_iso_8859_1): Remove decl.
7866 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7867 Now static.
7868
127198fd
PE
7869 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7870 * ccl.c (Vccl_program_table): Now static.
7871 (check_ccl_update): Remove; unused.
7872
d85b608f
PE
7873 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7874 * category.h: ... from here.
7875 * category.c (check_category_table, set_category_set): Now static.
7876
31cd66f3
PE
7877 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7878 * lisp.h: Remove these decls.
7879
c358e587
PE
7880 * buffer.c (buffer_count): Remove unused var.
7881
e78aecca
PE
7882 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7883 so that it's not optimized away.
7884 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7885 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7886 exported only to the debugger.
7887
e192d7d3 7888 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7889 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7890
92470028
PE
7891 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7892 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7893 was inaccessible from Lisp.
7894 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7895 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7896
244ed907
PE
7897 alloc.c: Import and export fewer symbols, and remove unused items.
7898 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7899 is defined.
7900 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7901 it's not optimized away by whole-program optimization.
7902 (message_enable_multibyte, free_misc): Remove.
7903 (catchlist, handlerlist, mark_backtrace):
7904 Declare only if BYTE_MARK_STACK.
7905 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7906 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7907 (message_enable_multibyte): Remove decl.
7908 (free_misc, interval_free_list, float_block, float_block_index):
7909 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7910 (cons_free_list, last_marked_index):
7911 Now static.
7912 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7913 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7914 (mark_backtrace): Define only if BYTE_MARK_STACK.
7915 * xdisp.c (message_enable_multibyte): Now static.
7916
61c2b50e 7917 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7918 This makes it easier for human readers (and static analyzers)
7919 to see whether these variables are used from other modules.
7920 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7921 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7922 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7923 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7924 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7925 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7926 * xmenu.c, xselect.c:
7927 Declare Q* vars static if they are not used in other modules.
7928 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7929 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7930 Remove decls of unexported vars.
7931 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7932
95c82688
PE
7933 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7934
16a97296
PE
7935 Make Emacs functions such as Fatom 'static' by default.
7936 This makes it easier for human readers (and static analyzers)
7937 to see whether these functions can be called from other modules.
7938 DEFUN now defines a static function. To make the function external
7939 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7940 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7941 (Finit_image_library):
16a97296
PE
7942 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7943 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7944 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7945 Remove decls, since these functions are now static.
7946 (Funintern, Fget_internal_run_time): New decls, since these functions
7947 were already external.
95c82688 7948
16a97296
PE
7949 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7950 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7951 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7952 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7953 * keyboard.c, keymap.c, lread.c:
7954 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7955 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7956 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7957 Mark functions with DEFUE instead of DEFUN,
7958 if they are used in other modules.
7959 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7960 decls for now-static functions.
7961 * buffer.h (Fdelete_overlay): Remove decl.
7962 * callproc.c (Fgetenv_internal): Mark as internal.
7963 * composite.c (Fremove_list_of_text_properties): Remove decl.
7964 (Fcomposition_get_gstring): New forward static decl.
7965 * composite.h (Fcomposite_get_gstring): Remove decl.
7966 * dired.c (Ffile_attributes): New forward static decl.
7967 * doc.c (Fdocumntation_property): New forward static decl.
7968 * eval.c (Ffetch_bytecode): New forward static decl.
7969 (Funintern): Remove extern decl; now in .h file where it belongs.
7970 * fileio.c (Fmake_symbolic_link): New forward static decl.
7971 * image.c (Finit_image_library): New forward static decl.
7972 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7973 * intervals.h (Fprevious_property_change):
7974 (Fremove_list_of_text_properties): Remove decls.
7975 * keyboard.c (Fthis_command_keys): Remove decl.
7976 (Fcommand_execute): New forward static decl.
7977 * keymap.c (Flookup_key): New forward static decl.
7978 (Fcopy_keymap): Now static.
7979 * keymap.h (Flookup_key): Remove decl.
7980 * process.c (Fget_process): New forward static decl.
7981 (Fprocess_datagram_address): Mark as internal.
7982 * syntax.c (Fsyntax_table_p): New forward static decl.
7983 (skip_chars): Remove duplicate decl.
7984 * textprop.c (Fprevious_property_change): New forward static decl.
7985 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7986 Now internal.
7987 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7988 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7989
785bbd42
PE
7990 * editfns.c (Fformat): Remove unreachable code.
7991
8b913b57
AS
79922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7993
7994 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7995 change. (Bug#8496)
7996
a6744a35
EZ
79972011-04-13 Eli Zaretskii <eliz@gnu.org>
7998
7999 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8000 when at ZV. (Bug#8487)
8001
e7974947
AS
80022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8003
baad03f0
AS
8004 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8005 (Bug#8437)
8006 * keyboard.c (parse_tool_bar_item): Likewise.
8007 * sound.c (sound_cleanup, alsa_close): Likewise.
8008 * termcap.c (tgetent): Likewise.
8009 * xfns.c (x_default_font_parameter): Likewise.
8010 * xsettings.c (read_and_apply_settings): Likewise.
8011
e7974947
AS
8012 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8013 (overrun_check_free): Protoize.
8014
28272684
PE
80152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8016
8017 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8018 since callers should never pass a negative size.
8019 Change the signature to match that of plain 'read' and 'write'; see
8020 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8021 * lisp.h: Update prototypes of emacs_write and emacs_read.
8022
11997c76
EZ
80232011-04-11 Eli Zaretskii <eliz@gnu.org>
8024
8025 * xdisp.c (redisplay_window): Don't try to determine the character
8026 position of the scroll margin if the window start point w->startp
e896f03c 8027 is outside the buffer's accessible region. (Bug#8468)
11997c76 8028
8a2cbd72
EZ
80292011-04-10 Eli Zaretskii <eliz@gnu.org>
8030
8031 Fix write-region and its subroutines for buffers > 2GB.
8032 * fileio.c (a_write, e_write): Modify declaration of arguments and
8033 local variables to support buffers larger than 2GB.
8034 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8035
8036 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8037 argument, local variables, and return value.
8038
8039 * lisp.h: Update prototypes of emacs_write and emacs_read.
8040
8041 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8042
4073e537 80432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8044
1ebfdcb6
PE
8045 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8046
b2ded58d
PE
8047 Fix more problems found by GCC 4.6.0's static checks.
8048
7d66342c
PE
8049 * xdisp.c (vmessage): Use a better test for character truncation.
8050
bbf47d44
PE
8051 * charset.c (load_charset_map): <, not <=, for optimization,
8052 and to avoid potential problems with integer overflow.
9248994d 8053 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8054 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8055 * editfns.c (Fformat): Likewise.
1e69125e 8056 * syntax.c (skip_chars): Likewise.
3befa583 8057
e3019616
PE
8058 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8059 This also lets GCC 4.6.0 generate slightly better loop code.
8060
becfa255
PE
8061 * callint.c (Fcall_interactively): <, not <=, for optimization.
8062 (Fcall_interactively): Count the number of arguments produced,
8063 not the number of arguments given. This is simpler and lets GCC
8064 4.6.0 generate slightly better code.
8065
dae0cd48
PE
8066 * ftfont.c: Distingish more carefully between FcChar8 and char.
8067 The previous code passed unsigned char * to a functions like
8068 strlen and xstrcasecmp that expect char *, which does not
8069 conform to the C standard.
8070 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8071 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8072 char * when the C standard requires it.
8073
76032d70
PE
8074 * keyboard.c (read_char): Remove unused var.
8075
eb3f1cc8
PE
8076 * eval.c: Port to Windows vsnprintf (Bug#8435).
8077 Include <limits.h>.
8078 (SIZE_MAX): Define if the headers do not.
8079 (verror): Do not give up if vsnprintf returns a negative count.
8080 Instead, grow the buffer. This ports to Windows vsnprintf, which
8081 does not conform to C99. Problem reported by Eli Zaretskii.
8082 Also, simplify the allocation scheme, by avoiding the need for
8083 calling realloc, and removing the ALLOCATED variable.
8084
70476b54
PE
8085 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8086
12020a9e
PE
8087 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8088 But keep the doprint source code for now, as we might revamp it
8089 and use it again (Bug#8435).
ea6c7ae6
PE
8090 * lisp.h (doprnt): Remove.
8091 * Makefile.in (base_obj): Remove doprnt.o.
8092 * deps.mk (doprnt.o): Remove.
8093
5fdb398c
PE
8094 error: Print 32- and 64-bit integers portably (Bug#8435).
8095 Without this change, on typical 64-bit hosts error ("...%d...", N)
8096 was used to print both 32- and 64-bit integers N, which relied on
8097 undefined behavior.
61bdb816 8098 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8099 * lisp.h (error, verror): Mark as printf-like functions.
8100 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8101 Report overflow in size calculations when allocating printf buffer.
8102 Do not truncate output string at its first null byte.
8103 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8104 Truncate the output at a character boundary, since vsnprintf does not
8105 do that.
8106 * charset.c (check_iso_charset_parameter): Convert internal
8107 character to string before calling 'error', since %c now has the
8108 printf meaning.
8109 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8110 overflow when computing char to be passed to 'error'. Do not
8111 pass Lisp_Object to 'error'; pass the integer instead.
8112 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8113 formatted with plain %d.
8114
b189fa66
PE
8115 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8116
bff87ef0
PE
8117 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8118
7e2cac20
PE
8119 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8120
ce4d90b5
PE
8121 * xterm.c (x_catch_errors): Remove duplicate declaration.
8122
266c9547
PE
8123 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8124
79c49ad2
PE
8125 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8126
368f4090
JM
81272011-04-10 Jim Meyering <meyering@redhat.com>
8128
8129 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8130 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8131 return ssize_t not "int", and use size_t as the buffer length.
8132 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8133 * gnutls.h: Update declarations.
8134 * process.c (read_process_output): Use ssize_t, to match.
8135 (send_process): Likewise.
8136
a32d4040
CY
81372011-04-09 Chong Yidong <cyd@stupidchicken.com>
8138
8139 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8140
8546720e 81412011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8142
04f2d78b
CB
8143 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8144 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8145
8546720e
GM
8146 * xterm.c (handle_one_xevent):
8147 * xmenu.c (create_and_show_popup_menu):
8148 * xselect.c (x_decline_selection_request)
8149 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8150
0a2f5c1a 81512011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8152
8153 Fix some uses of `int' instead of EMACS_INT.
8154 * search.c (string_match_1, fast_string_match)
8155 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8156 (scan_buffer, find_next_newline_no_quit)
8157 (find_before_next_newline, search_command, Freplace_match)
8158 (Fmatch_data): Make some `int' variables be EMACS_INT.
8159
8160 * xdisp.c (display_count_lines): 3rd argument and return value now
8161 EMACS_INT. All callers changed.
8162 (pint2hrstr): Last argument is now EMACS_INT.
8163
8164 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8165 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8166 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8167 (decode_coding_utf_16, decode_coding_emacs_mule)
8168 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8169 (decode_coding_ccl, decode_coding_charset)
8170 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8171 (decode_coding_iso_2022, decode_coding_emacs_mule)
8172 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8173 <char_offset, last_offset>: Declare EMACS_INT.
8174 (encode_coding_utf_8, encode_coding_utf_16)
8175 (encode_coding_emacs_mule, encode_invocation_designation)
8176 (encode_designation_at_bol, encode_coding_iso_2022)
8177 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8178 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8179 Declare EMACS_INT.
8180 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8181 (encode_invocation_designation): Last argument P_NCHARS is now
8182 EMACS_INT.
8183 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8184 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8185
8186 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8187 All users changed.
8188
8189 * ccl.c (Fccl_execute_on_string): Declare some variables
8190 EMACS_INT.
8191
8546720e 81922011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8193
8194 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8195
4e19a977
CS
81962011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8197
8198 * process.c (Fformat_network_address): Doc fix.
8199
87302331
R
82002011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8201
ee7683eb 8202 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8203
cbb59342
CY
82042011-04-08 Chong Yidong <cyd@stupidchicken.com>
8205
8206 * keyboard.c (read_char): Call Lisp function help-form-show,
8207 instead of using internal_with_output_to_temp_buffer.
8208 (Qhelp_form_show): New var.
e0d38eeb 8209 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8210
8211 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8212
8213 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8214
e67a13ab
CY
82152011-04-06 Chong Yidong <cyd@stupidchicken.com>
8216
04f2d78b
CB
8217 * process.c (Flist_processes): Remove to Lisp.
8218 (list_processes_1): Delete.
e67a13ab 8219
973f782d
EZ
82202011-04-06 Eli Zaretskii <eliz@gnu.org>
8221
7c106b1e
EZ
8222 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8223
973f782d
EZ
8224 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8225
41cf7d1a 82262011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8227
ca23cc88
PE
8228 Fix more problems found by GCC 4.6.0's static checks.
8229
f390e2d5
PE
8230 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8231
42eea0d0
PE
8232 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8233
b69769da 8234 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8235
f9541e84
PE
8236 * xdisp.c (vmessage): Mark as a printf-like function.
8237
13841b55
PE
8238 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8239
c136c10f
PE
8240 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8241
5e2d4a30
PE
8242 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8243 printf-like functions.
8244 (tiff_load): Add casts to remove these marks before passing them
8245 to system-supplied API.
8246
583f48b9
PE
8247 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8248
b25d760e
PE
8249 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8250 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8251 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8252 directly, rather than having caller test rule sign. This avoids
8253 some unnecessary tests.
8254 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8255 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8256 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8257
bc7b6697 8258 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8259 (xfont_open): Avoid unnecessary tests.
bc7b6697 8260
27ccc379
PE
8261 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8262
dcd5c89a
PE
8263 * composite.h, composite.c (composition_gstring_put_cache):
8264 Use EMACS_INT, not int, for length.
8265
b13a45c6
PE
8266 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8267 breaking out part of COMPOSITION_DECODE_RULE.
8268 (COMPOSITION_DECODE_RULE): Use it.
8269 * composite.c (get_composition_id): Remove unused local vars,
8270 by using the new macro.
8271
1e792e4d
PE
8272 * textprop.c (set_text_properties_1): Change while to do-while,
8273 since the condition is always true at first.
8274
dc6c6455 8275 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8276 (interval_deletion_adjustment): Return unsigned value.
8277 All uses changed.
dc6c6455 8278
aba7731a
PE
8279 * process.c (list_processes_1, create_pty, read_process_output):
8280 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8281 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8282 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8283 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8284 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8285
fdfc4bf3
PE
8286 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8287
fca8fe46 8288 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8289 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8290
06a0259a 8291 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8292 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8293 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8294
e7b9e80f
PE
8295 * print.c (print_error_message): Avoid int overflow.
8296
56201685
PE
8297 * font.c (font_list_entities): Redo for clarity,
8298 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8299
78834453 8300 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8301 (font_score): Avoid potential overflow in diff calculation.
78834453 8302
0bc0b309 8303 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8304 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8305
e610eaca
PE
8306 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8307
b895abce
PE
8308 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8309 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8310 can always succeed if overflow has undefined behavior.
8311
1f1d9321 8312 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8313 (wordify): Omit three unnecessary tests.
1f1d9321 8314
c59478bc
PE
8315 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8316 All callers changed. This avoids the need for an unused var.
8317
79b73827
PE
8318 * casefiddle.c (casify_region): Remove var that is set but not used.
8319
a4db5dfe
PE
8320 * dired.c (file_name_completion): Remove var that is set but not used.
8321
43aae36e
PE
8322 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8323
2a47c44d 8324 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8325 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8326
a37c69bf
PE
8327 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8328 Check for integer overflow on size calculations.
8329
328ab8e7
PE
8330 * buffer.c (Fprevious_overlay_change): Remove var that is set
8331 but not used.
8332
e5a2a5cb
PE
8333 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8334 Remove vars that are set but not used.
8d84a6eb 8335 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8336 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8337
a60e5f68
PE
8338 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8339
f661cb61 8340 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8341 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8342
f0397f5a
PE
8343 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8344 that are set but not used.
8345
8664db06 8346 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8347 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8348
6abdaa4a
PE
8349 * xselect.c (x_get_local_selection, x_handle_property_notify):
8350 Remove vars that are set but not used.
8351
0ce7538d 8352 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8353 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8354
9ae848fc
PE
8355 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8356 Remove var that is set but not used.
0b918413
PE
8357 (scroll_bar_windows_size): Now size_t, not int.
8358 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8359 Check for overflow.
9ae848fc 8360
a5a62657
PE
8361 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8362 (map_tty_color) [!defined MSDOS]: Likewise.
8363
5c5cdd39
PE
8364 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8365
66ebf983
PE
8366 * coding.c: Remove vars that are set but not used.
8367 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8368 All callers changed.
8369 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8370 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8371 (decode_coding_charset): Remove vars that are set but not used.
8372
1be4d761
PE
8373 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8374 that is set but not used.
8375
47553fa8
PE
8376 * print.c (print_object): Remove var that is set but not used.
8377
1f7196bf 8378 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8379 The gnulib version avoids calling malloc in the usual case,
8380 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8381 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8382 * filelock.c (current_lock_owner): Likewise.
8383 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8384 * sysdep.c: Include allocator.h, careadlinkat.h.
8385 (emacs_no_realloc_allocator): New static constant.
8386 (emacs_readlink): New function.
fdb61804
PE
8387 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8388 ../lib/careadlinkat.h.
d1fdcab7 8389
f84c17c7
SM
83902011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8391
8392 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8393 first non-nil return value).
8394
ef3862ad
JD
83952011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8396
8397 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8398 if not defined (Bug#8403).
8399
376a7006
JB
84002011-04-02 Juanma Barranquero <lekktu@gmail.com>
8401
8402 * xdisp.c (display_count_lines): Remove parameter `start',
8403 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8404 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8405 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8406 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8407 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8408 and thereabouts. All callers changed.
8409 (get_per_char_metric): Remove parameter `f', unused since
8410 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8411
6ca3801d
JM
84122011-04-02 Jim Meyering <meyering@redhat.com>
8413
8414 do not dereference NULL upon failed strdup
8415 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8416 (ns_get_family): Likewise.
8417
d8e2b5ba
JB
84182011-04-02 Juanma Barranquero <lekktu@gmail.com>
8419
8420 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8421
8c74fcbd
JD
84222011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8423
8424 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8425 later (Bug#8403).
8426
7200d79c
SM
84272011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8428
03408648 8429 Add lexical binding.
7200d79c 8430
03408648
SM
8431 * window.c (Ftemp_output_buffer_show): New fun.
8432 (Fsave_window_excursion):
8433 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8434
8435 * lread.c (lisp_file_lexically_bound_p): New function.
8436 (Fload): Bind Qlexical_binding.
8437 (readevalloop): Remove `evalfun' arg.
8438 Bind Qinternal_interpreter_environment.
8439 (Feval_buffer): Bind Qlexical_binding.
8440 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8441 Mark as dynamic.
8442 (syms_of_lread): Declare `lexical-binding'.
8443
8444 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8445
8446 * keyboard.c (eval_dyn): New fun.
8447 (menu_item_eval_property): Use it.
ca105506
SM
8448
8449 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8450
03408648
SM
8451 * fns.c (concat, mapcar1): Accept byte-code-functions.
8452
8453 * eval.c (Fsetq): Handle lexical vars.
8454 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8455 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8456 (FletX, Flet): Obey lexical binding.
8457 (Fcommandp): Handle closures.
8458 (Feval): New `lexical' arg.
8459 (eval_sub): New function extracted from Feval. Use it almost
8460 everywhere where Feval was used. Look up vars in lexical env.
8461 Handle closures.
8462 (Ffunctionp): Move from subr.el.
8463 (Ffuncall): Handle closures.
8464 (apply_lambda): Remove `eval_flags'.
8465 (funcall_lambda): Handle closures and new byte-code-functions.
8466 (Fspecial_variable_p): New function.
8467 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8468 but without exporting it to Lisp.
23aba0ea 8469
23aba0ea 8470 * doc.c (Fdocumentation, store_function_docstring):
03408648 8471 * data.c (Finteractive_form): Handle closures.
23aba0ea 8472
03408648
SM
8473 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8474 interactive spec.
ba83908c 8475
04f2d78b
CB
8476 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8477 New byte-codes.
03408648
SM
8478 (exec_byte_code): New function extracted from Fbyte_code to handle new
8479 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8480
03408648 8481 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8482
03408648 8483 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8484
e2abce01
JB
84852011-03-31 Juanma Barranquero <lekktu@gmail.com>
8486
8487 * xdisp.c (redisplay_internal): Fix prototype.
8488
63696a73 84892011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8490
63696a73 8491 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8492 (try_scrolling): Use it when setting scroll_limit.
8493 Limit scrolling to 100 screen lines.
63696a73
EZ
8494 (redisplay_window): Even when falling back on "recentering",
8495 position point in the window according to scroll-conservatively,
8496 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8497
8498 (try_scrolling): When point is above the window, allow searching
8499 as far as scroll_max, or one screenful, to compute vertical
8500 distance from PT to the scroll margin position. This prevents
8501 try_scrolling from unnecessarily failing when
8502 scroll-conservatively is set to a value slightly larger than the
8503 window height. Clean up the case of PT below the margin at bottom
8504 of window: scroll_max can no longer be INT_MAX. When aggressive
8505 scrolling is in use, don't let point enter the opposite scroll
8506 margin as result of the scroll.
8507 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8508 threshold of 100 lines for never-recentering scrolling.
8509
e4cc2dfc
JB
85102011-03-31 Juanma Barranquero <lekktu@gmail.com>
8511
8512 * dispextern.h (move_it_by_lines):
8513 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8514 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8515 (message_log_check_duplicate): Remove parameters `prev_bol' and
8516 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8517 (redisplay_internal): Remove parameter `preserve_echo_area',
8518 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8519
8520 * indent.c (Fvertical_motion):
8521 * window.c (window_scroll_pixel_based, Frecenter):
8522 Don't pass `need_y_p' to `move_it_by_lines'.
8523
1c470562
SM
85242011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8525
44f230aa
SM
8526 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8527 steal a few bits to be more compact.
8528 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8529 Remove unneeded casts.
8530
1c470562
SM
8531 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8532
888adce9
ZK
85332011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8534
8535 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8536 binding" message (bug#7967).
8537
f838ed7b
PE
85382011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8539
77861b95
PE
8540 Fix more problems found by GCC 4.6.0's static checks.
8541
de6dbc14
PE
8542 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8543 Remove unused local var.
8544
f838ed7b
PE
8545 * editfns.c (Fmessage_box): Remove unused local var.
8546
792c7b2b
PE
8547 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8548 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8549 Omit unused local vars.
c499e557 8550 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8551 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8552 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8553 Omit unused local var.
8554
ba0165e1
PE
8555 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8556 Don't assume string length fits in int.
32ad8845 8557 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8558 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8559
3c59b4c9
PE
8560 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8561 instead of alloca (Bug#8344).
8562
a3eed478 8563 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8564 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8565
eb4d412d
PE
8566 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8567
1658b401
PE
8568 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8569 concerns.
8570
8571 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8572
8573 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8574
9a2c6e05
PE
8575 * keyboard.c (syms_of_keyboard): Use the same style as later
8576 in this function when indexing through an array. This also
8577 works around GCC bug 48267.
8578
03d0a109
PE
8579 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8580
44f730c8
PE
8581 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8582
fe75f926
PE
8583 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8584 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8585
ffa8c828
PE
8586 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8587 This avoids undefined behavior on integer overflow, and is a bit
8588 more convenient anyway since it is compared to a size_t variable.
8589
c5101a77
PE
8590 Variadic C functions now count arguments with size_t, not int.
8591 This avoids an unnecessary limitation on 64-bit machines, which
8592 caused (substring ...) to crash on large vectors (Bug#8344).
8593 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8594 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8595 All variadic functions and their callers changed accordingly.
c5101a77
PE
8596 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8597 * data.c (arith_driver, float_arith_driver): Likewise.
8598 * editfns.c (general_insert_function): Likewise.
8599 * eval.c (struct backtrace.nargs, interactive_p)
8600 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8601 (funcall_lambda, mark_backtrace): Likewise.
8602 * fns.c (concat): Likewise.
8603 * frame.c (x_set_frame_parameters): Likewise.
8604 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8605 0 if not found, not -1. All callers changed.
8606
dd3f25f7
PE
8607 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8608 (stack_copy_size): Now size_t, not int.
8609 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8610
461c2ab9
JB
86112011-03-28 Juanma Barranquero <lekktu@gmail.com>
8612
8613 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8614 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8615 All callers changed.
8616
8617 * lisp.h (multibyte_char_to_unibyte):
8618 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8619 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8620 * character.h (CHAR_TO_BYTE8):
8621 * cmds.c (internal_self_insert):
8622 * editfns.c (general_insert_function):
8623 * keymap.c (push_key_description):
8624 * search.c (Freplace_match):
8625 * xdisp.c (message_dolog, set_message_1): All callers changed.
8626
f6d62986
SM
86272011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8628
8629 * keyboard.c (safe_run_hook_funcall): New function.
8630 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8631 don't set the hook to nil, but remove the offending function instead.
8632 (Qcommand_hook_internal): Remove, unused.
8633 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8634 Vcommand_hook_internal.
8635
8636 * eval.c (enum run_hooks_condition): Remove.
8637 (funcall_nil, funcall_not): New functions.
8638 (run_hook_with_args): Call each function through a `funcall' argument.
8639 Remove `cond' argument, now redundant.
8640 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8641 (Frun_hook_with_args_until_failure): Adjust accordingly.
8642 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8643
1db5b1ad
JB
86442011-03-28 Juanma Barranquero <lekktu@gmail.com>
8645
8646 * dispextern.h (string_buffer_position): Remove declaration.
8647
8648 * print.c (strout): Remove parameter `multibyte', unused since
8649 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8650
8651 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8652 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8653 All callers changed.
8654
8655 * w32.c (_wsa_errlist): Use braces for struct initializers.
8656
8657 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8658 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8659 All callers changed.
8660 (string_buffer_position): Likewise. Also, make static (it's never
8661 used outside xdisp.c).
8662 (cursor_row_p): Remove parameter `w', unused since
8663 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8664 (decode_mode_spec): Remove parameter `precision', introduced during
8665 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8666 All callers changed.
8667
5ffb62aa
JD
86682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8669
8670 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8671
461c2ab9 86722011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8673
8674 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8675 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8676 (ns_update_auto_hide_menu_bar): New functions.
8677 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8678 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8679 ns_constrain_all_frames.
8680 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8681 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8682
5c380ffb
JD
86832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8684
8685 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8686
9af30bdf
GM
86872011-03-27 Glenn Morris <rgm@gnu.org>
8688
8689 * syssignal.h: Replace RETSIGTYPE with void.
8690 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8691 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8692 Replace SIGTYPE with void everywhere.
8693 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8694 * s/template.h (SIGTYPE): Remove commented out definition.
8695
e2abce01
JB
86962011-03-26 Eli Zaretskii <eliz@gnu.org>
8697
8698 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8699 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8700
f868cd8a
JB
87012011-03-26 Juanma Barranquero <lekktu@gmail.com>
8702
59eb0929
JB
8703 * w32.c (read_unc_volume): Use parameter `henum', instead of
8704 global variable `wget_enum_handle'.
8705
8706 * keymap.c (describe_vector): Remove parameters `indices' and
8707 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8708 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8709
f868cd8a
JB
8710 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8711
8712 * keyboard.c (timer_check): Remove parameter `do_it_now',
8713 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8714 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8715 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8716
8717 * keyboard.c (read_char):
8718 * w32menu.c (w32_menu_display_help):
8719 * xmenu.c (show_help_event, menu_help_callback):
8720 Adjust calls to `show_help_echo'.
8721
8722 * gtkutil.c (xg_maybe_add_timer):
8723 * keyboard.c (readable_events):
8724 * process.c (wait_reading_process_output):
8725 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8726
8727 * insdel.c (adjust_markers_gap_motion):
8728 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8729 (gap_left, gap_right): Don't call it.
8730
2ecf6fdb
CY
87312011-03-25 Chong Yidong <cyd@stupidchicken.com>
8732
8733 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8734 incurred during fontification.
8735
6b1f9ba4
JB
87362011-03-25 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8739 (DEFVAR_PER_BUFFER): Don't pass it.
8740
8741 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8742 (scrolling_window): Don't pass it.
8743
0f4a96b5
JB
87442011-03-25 Juanma Barranquero <lekktu@gmail.com>
8745
8746 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8747
8748 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8749 and `suffix'.
8750 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8751 of variables specific to SELinux and computation of `encoded_absname'.
8752
8753 * image.c (XPutPixel): Remove unused variable `height'.
8754
8755 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8756
8757 * unexw32.c (get_section_info): Remove unused variable `section'.
8758
8759 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8760 (system_process_attributes): Remove unused variable `sess'.
8761 (sys_read): Remove unused variable `err'.
8762
8763 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8764 (w32_wnd_proc): Remove unused variable `isdead'.
8765 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8766 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8767 (x_create_tip_frame): Remove unused variable `tem'.
8768
8769 * w32inevt.c (w32_console_read_socket):
8770 Remove unused variable `no_events'.
8771
8772 * w32term.c (x_draw_composite_glyph_string_foreground):
8773 Remove unused variable `width'.
8774
1149507c
JB
87752011-03-24 Juanma Barranquero <lekktu@gmail.com>
8776
8777 * w32term.c (x_set_glyph_string_clipping):
8778 Don't pass uninitialized region to CombineRgn.
8779
9c88f339
JB
87802011-03-23 Juanma Barranquero <lekktu@gmail.com>
8781
8782 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8783 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8784 (Fx_close_connection): Remove unused variable `i'.
8785
8786 * w32font.c (w32font_draw): Return number of glyphs.
8787 (w32font_open_internal): Remove unused variable `i'.
8788 (w32font_driver): Add missing initializer.
8789
8790 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8791 (fill_in_menu): Remove unused variable `items_added'.
8792
8793 * w32term.c (last_mouse_press_frame): Remove static global variable.
8794 (w32_clip_to_row): Remove unused variable `f'.
8795 (x_delete_terminal): Remove unused variable `i'.
8796
8797 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8798 (NOTHING): Remove unused static global variable.
8799 (uniscribe_check_otf): Remove unused variable `table'.
8800 (uniscribe_font_driver): Add missing initializers.
8801
dee091a3
JD
88022011-03-23 Julien Danjou <julien@danjou.info>
8803
8804 * term.c (Fsuspend_tty, Fresume_tty):
8805 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8806 * window.c (temp_output_buffer_show):
8807 * insdel.c (signal_before_change):
8808 * frame.c (Fhandle_switch_frame):
8809 * fileio.c (Fdo_auto_save):
8810 * emacs.c (Fkill_emacs):
8811 * editfns.c (save_excursion_restore):
8812 * cmds.c (internal_self_insert):
8813 * callint.c (Fcall_interactively):
8814 * buffer.c (Fkill_all_local_variables):
8815 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8816 Use Frun_hooks.
0f4a96b5 8817 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8818 unconditionally since it does the check itself.
dee091a3 8819
2c520ab5 88202011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8821
c9c49752
PE
8822 Fix more problems found by GCC 4.5.2's static checks.
8823
8abc3f12
PE
8824 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8825 the first time through the loop, since we know p0 < p1 then.
8826 This also avoids a gcc -Wstrict-overflow warning.
8827
a2d26660
PE
8828 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8829 leading to a memory leak, possible in functions like
8830 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8831 of objects (Bug#8318).
a2d26660 8832
916c72e9
PE
8833 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8834 that could (at least in theory) be that large.
8835
19ab8a18
PE
8836 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8837 This is less likely to overflow, and avoids undefined behavior if
8838 overflow does occur. All callers changed. Use strtoul to scan
8839 for the unsigned long integer.
b7cbbd6f
PE
8840 (pint2hrstr): Simplify and tune code slightly.
8841 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8842
f0641eff
PE
8843 * scroll.c (do_scrolling): Work around GCC bug 48228.
8844 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8845
7f650bb9
PE
8846 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8847 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8848 (validate_x_resource_name): Simplify count usage.
8849 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8850
37dd57d1
PE
8851 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8852 fail (Bug#8306).
81e56e61 8853
699979fc 8854 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8855
401bf9b4
PE
8856 * process.c (Fmake_network_process): Use socklen_t, not int,
8857 where POSIX says socklen_t is required in portable programs.
8858 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8859 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8860 (Fmake_network_process, server_accept_connection):
8861 (wait_reading_process_output, read_process_output):
8862 Likewise.
8863
b93aacde
PE
8864 * process.c: Rename or move locals to avoid shadowing.
8865 (list_processes_1, Fmake_network_process):
8866 (read_process_output_error_handler, exec_sentinel_error_handler):
8867 Rename or move locals.
4dc343ee 8868 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8869 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8870 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8871 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8872 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8873
af8a867c 8874 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8875 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8876 Include tparam.h instead, since it declares them.
af8a867c
PE
8877 * cm.h (PC): Remove extern decl; tparam.h now does this.
8878 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8879 * terminfo.c: Include tparam.h, to check interfaces.
8880 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8881 (tparam): Adjust signature to match interface in tparam.h;
8882 this removes some undefined behavior. Check that outstring and len
8883 are zero, which they always are with Emacs.
8884 * tparam.h (PC, BC, UP): New extern decls.
8885
0248044d 8886 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8887 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8888
8ff096c1 8889 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8890 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8891 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8892 (ftfont_list): Remove unused local.
49eaafba
PE
8893 (get_adstyle_property, ftfont_pattern_entity):
8894 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8895 Rename locals to avoid shadowing.
8ff096c1 8896
e2be39f6
PE
8897 * xfont.c (xfont_list_family): Mark var as initialized.
8898
c9735e30
PE
8899 * xml.c (make_dom): Now static.
8900
8f5201ae
PE
8901 * composite.c (composition_compute_stop_pos): Rename local to
8902 avoid shadowing.
b246f932
PE
8903 (composition_reseat_it): Remove unused locals.
8904 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8905 (composition_update_it): Mark var as initialized.
11b61122
PE
8906 (find_automatic_composition): Mark vars as initialized,
8907 with a FIXME (Bug#8290).
8f5201ae 8908
760fbc2c
PE
8909 character.h: Rename locals to avoid shadowing.
8910 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8911 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8912 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8913 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8914 to avoid shadowing.
8915
ff08eb85
PE
8916 * textprop.c (property_change_between_p): Remove; unused.
8917
fc7bf025
PE
8918 * intervals.c (interval_start_pos): Now static.
8919
235d7abc
PE
8920 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8921
44f230aa
SM
8922 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8923 Rename locals to avoid shadowing.
3e7d6594 8924
50060332
PE
8925 * sound.c (wav_play, au_play, Fplay_sound_internal):
8926 Fix pointer signedness.
d01f234b 8927 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8928 (wav_play): Initialize a variable to 0, to prevent undefined
8929 behavior (Bug#8278).
50060332 8930
c4fc4e30
PE
8931 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8932
918436ed
PE
8933 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8934
c939f91b
PE
8935 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8936 clobbering (Bug#8298).
b9c7f648
PE
8937 * sysdep.c (sys_subshell): Likewise.
8938 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8939
6bd8c144
PE
8940 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8941 This should get cleaned up, so that child_setup has the
8942 same signature on all platforms.
8943
7710357c 8944 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8945 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8946
c59da222
CY
89472011-03-22 Chong Yidong <cyd@stupidchicken.com>
8948
8949 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8950 not to be necessary, and produces flickering.
8951
66b87493
GM
89522011-03-20 Glenn Morris <rgm@gnu.org>
8953
8954 * config.in: Remove file.
8955
45b6f6d5
JB
89562011-03-20 Juanma Barranquero <lekktu@gmail.com>
8957
8958 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8959 are now in src/globals.h.
8960 (syms_of_minibuf): Remove spurious & from previous change.
8961
cd394be1 89622011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8963
8964 * minibuf.c (completing-read-function): New variable.
8965 (completing-read-default): Rename from completing-read.
8966 (completing-read): Call completing-read-function.
8967
b14e3e21
CY
89682011-03-19 Juanma Barranquero <lekktu@gmail.com>
8969
8970 * xfaces.c (Fx_load_color_file):
8971 Read color file from absolute filename (bug#8250).
8972
f2b726e6
JB
89732011-03-19 Juanma Barranquero <lekktu@gmail.com>
8974
8975 * makefile.w32-in: Update dependencies.
8976
09f6ff02
EZ
89772011-03-17 Eli Zaretskii <eliz@gnu.org>
8978
8979 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8980
29a6015a
PE
89812011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8982
a3a6c54e
PE
8983 Fix more problems found by GCC 4.5.2's static checks.
8984
b766f867
PE
8985 * process.c (make_serial_process_unwind, send_process_trap):
8986 (sigchld_handler): Now static.
8987
be02381c
PE
8988 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8989 That way, the code declares only the vars that it needs.
8990 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8991 * s/cygwin.h (PTY_ITERATION): Likewise.
8992 * s/darwin.h (PTY_ITERATION): Likewise.
8993 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8994
57048744
PE
8995 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8996 * process.c (allocate_pty): Don't declare stb unless it's needed.
8997
7914961c 8998 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8999 (CONSTANTLIM): Remove; unused.
9000 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9001 Define only if needed.
7914961c 9002
b3967b18
PE
9003 * unexelf.c (unexec): Name an expression,
9004 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9005 Use a different way to cause a compilation error if anyone uses
9006 n rather than nn, a way that does not involve shadowing.
73366a00 9007 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9008
29a6015a
PE
9009 * deps.mk (unexalpha.o): Remove; unused.
9010
43cfc33e 9011 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9012 * unexec.h: New file.
ce701a33
PE
9013 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9014 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9015 Depend on unexec.h.
9016 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9017 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9018 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9019 Change as necessary to match prototype in unexec.h.
ce701a33 9020
01f44d5a
PE
9021 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9022 shadowing.
4f63c6bb 9023 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9024
a6670b0b
PE
9025 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9026 Rename locals to avoid shadowing.
9027
cef2010d 9028 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9029 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9030
d4d7173a
PE
9031 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9032
f08b802a
PE
9033 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9034 warning when compiling print.c.
9035
3ddb0639
PE
9036 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9037 instead of using an uninitialized var.
5ad03b97 9038 (font_sort_entities): Mark var as initialized.
3ddb0639 9039
170a2692
PE
9040 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9041
e663c700
PE
9042 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9043 pointers to constants.
89bc529a 9044 (font_parse_fcname): Remove unused vars.
7b81e2d0 9045 (font_delete_unmatched): Now static.
ea838e10 9046 (font_get_spec): Remove; unused.
13a547c6
PE
9047 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9048 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9049 Rename or move locals to avoid shadowing.
e663c700 9050
2a80c887 9051 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9052 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9053
1384fa33 9054 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9055 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9056
8b2c52e9
PE
9057 * alloc.c (mark_backtrace): Move decl from here ...
9058 * lisp.h: ... to here, so that it can be checked.
9059
475545b5 9060 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9061 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9062 (lisp_indirect_variable): Name an expression,
9063 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9064 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9065
b1349114 9066 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9067 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9068 Use const pointer when appropriate.
b1349114 9069
a2928364
PE
9070 * lisp.h (get_system_name, get_operating_system_release):
9071 Move decls here, to check interfaces.
9072 * process.c (get_operating_system_release): Move decl to lisp.h.
9073 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9074 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9075 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9076 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9077 (Fformat_time_string, Fencode_time, Finsert_char):
9078 (Ftranslate_region_internal, Fformat):
9079 Rename or remove local vars to avoid shadowing.
9710023e 9080 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9081
a415e694
PE
9082 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9083 avoid shadowing.
9084
8ef4622d
PE
9085 * lisp.h (eassert): Check that the argument compiles, even if
9086 ENABLE_CHECKING is not defined.
9087
946f9a5b
PE
9088 * data.c (Findirect_variable): Name an expression, to avoid
9089 gcc -Wbad-function-cast warning.
112396d6 9090 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9091 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9092 (Fmake_variable_buffer_local, Fmake_local_variable):
9093 Mark variables as initialized.
52746918 9094 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9095
e5aab7e7 9096 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9097 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9098 Rename locals to avoid shadowing.
dff45157
PE
9099 (mark_stack): Move local variables into the #ifdef region where
9100 they're used.
7bc26fdb
PE
9101 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9102 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9103 needed otherwise.
9104 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9105 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9106 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9107
e5aab7e7
PE
9108 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9109 avoids undefined behavior in theory.
9110
4da60324
PE
9111 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9112
88043301
PE
9113 Use functions, not macros, for up- and down-casing (Bug#8254).
9114 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9115 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9116 to use the following functions instead of these macros.
9117 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9118 EMACS_INT, since callers assume the returned value fits in int.
9119 (upcase1): Likewise, for UPCASE_TABLE.
9120 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9121 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9122 the race-condition problem in the old DOWNCASE.
88043301 9123
19ed5445
PE
9124 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9125 Rename locals to avoid shadowing.
9126 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9127 (regex_compile, re_search_2, re_match_2_internal):
9128 Remove unused local vars.
952db0d7
PE
9129 (FREE_VAR): Rewrite so as not to use empty "else",
9130 which gcc can warn about.
da053e48 9131 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9132 (RETALLOC_IF): Define only if needed.
9133 (WORDCHAR_P): Likewise. This one is never needed, but is used
9134 only in a comment talking about a compiler bug, so put inside
9135 the #if 0 of that comment.
9136 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9137 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9138 Remove; unused.
19ed5445 9139
1f3561e4 9140 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9141 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9142 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9143
ded6f8f7
PE
9144 * search.c (simple_search): Remove unused var.
9145
dbd37a95
PE
9146 * dired.c (compile_pattern): Move decl from here ...
9147 * lisp.h: ... to here, so that it can be checked.
9148 (struct re_registers): New forward decl.
9149
7e47afad
PE
9150 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9151
85f24f61
PE
9152 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9153 All uses changed.
9154 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9155 Rename locals to avoid shadowing.
5671df8f 9156 (Fvertical_motion): Mark locals as initialized.
85f24f61 9157
181aa2be 9158 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9159 (casify_region): Mark local as initialized.
181aa2be 9160
930d429c
PE
9161 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9162
7082eac6
PE
9163 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9164 New macros, so that the caller can use some names other than
9165 gcpro1, gcpro2, etc.
9166 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9167 of the new macros.
9168 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9169 argument, for consistency with GCPRO2_VAR, etc: it is now the
9170 prefix of the variable, not the variable itself. All uses
9171 changed.
38b2c076
PE
9172 * dired.c (directory_files_internal, file_name_completion):
9173 Rename locals to avoid shadowing.
9174
15206ed9
PE
9175 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9176 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9177 dired.c's scmp function, had undefined behavior.
9178 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9179 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9180 * buffer.h: ... to here, because these macros use current_buffer,
9181 and the new implementation with inline functions needs to have
9182 current_buffer in scope now, rather than later when the macros
9183 are used.
9184 (downcase, upcase1): New static inline functions.
9185 (DOWNCASE, UPCASE1): Reimplement using these functions.
9186 This avoids undefined behavior in expressions like
9187 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9188 from race conditions in accessing the global variables
9189 case_temp1 and case_temp2.
9190 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9191 * lisp.h (case_temp1, case_temp2): Remove their decls.
9192 * character.h (ASCII_CHAR_P): Move from here ...
9193 * lisp.h: ... to here, so that the inline functions mentioned
9194 above can use them.
9195
4a6bea26
PE
9196 * dired.c (directory_files_internal_unwind): Now static.
9197
f14b7e14
PE
9198 * fileio.c (file_name_as_directory, directory_file_name):
9199 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9200 Now static.
2893f146
PE
9201 (file_name_as_directory): Use const pointers when appropriate.
9202 (Fexpand_file_name): Likewise. In particular, newdir might
9203 point at constant storage, so make it a const pointer.
fd4ead52 9204 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9205 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9206 signedness issues.
f839df0c
PE
9207 (Fset_file_times, Finsert_file_contents, auto_save_error):
9208 Rename locals to avoid shadowing.
f14b7e14 9209
5716756e 9210 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9211 (Ftry_completion, Fall_completions): Rename or remove locals
9212 to avoid shadowing.
5716756e 9213
b4c3046a
PE
9214 * marker.c (bytepos_to_charpos): Remove; unused.
9215
b45db522
PE
9216 * lisp.h (verify_bytepos, count_markers): New decls,
9217 so that gcc does not warn that these functions aren't declared.
9218
85876d07
PE
9219 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9220 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9221 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9222 (copy_text): Remove unused local var.
85876d07 9223
03d78a21 9224 * filelock.c (within_one_second): Now static.
b3dd38ab 9225 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9226
5df8f01b
PE
9227 * buffer.c (fix_overlays_before): Mark locals as initialized.
9228 (fix_start_end_in_overlays): Likewise. This function should be
9229 simplified by using pointers-to-pointers, but that's a different
9230 matter.
b1d876f1 9231 (switch_to_buffer_1): Now static.
8f54f30a
PE
9232 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9233 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9234
a70072c9 9235 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9236 Fix pointer signedness issue.
edced198
PE
9237 (sys_subshell): Mark local as volatile if checking for lint,
9238 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9239 (MAXPATHLEN): Define only if needed.
a70072c9 9240
a0977c44
PE
9241 * process.c (serial_open, serial_configure): Move decls from here ...
9242 * systty.h: ... to here, so that they can be checked.
9243
a884fdcc
PE
9244 * fns.c (get_random, seed_random): Move extern decls from here ...
9245 * lisp.h: ... to here, so that they can be checked.
9246
604efe86 9247 * sysdep.c (reset_io): Now static.
b8950c94 9248 (wait_for_termination_signal): Remove; unused.
604efe86 9249
38fc62d9
PE
9250 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9251 (copy_keymap_item, append_key, push_text_char_description):
9252 Now static.
1004a21a 9253 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9254 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9255 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9256 (describe_map_tree):
9257 Rename locals to avoid shadowing.
38fc62d9 9258
2f2650da
PE
9259 * keyboard.c: Declare functions static if they are not used elsewhere.
9260 (echo_char, echo_dash, cmd_error, top_level_2):
9261 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9262 (read_char, kbd_buffer_get_event, make_lispy_position):
9263 (make_lispy_event, make_lispy_movement, apply_modifiers):
9264 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9265 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9266 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9267 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9268 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9269
a053e86c 9270 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9271 (mark_kboards): Move decl here ...
9272 * alloc.c (mark_kboards): ... from here.
a053e86c 9273
4752793e
PE
9274 * lisp.h (force_auto_save_soon): New decl.
9275
74f10ca7 9276 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9277 (DEFINE_DUMMY_FUNCTION): New macro.
9278 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9279 Use it.
c03cd23f
PE
9280 (main): Add casts to avoid warnings
9281 if GCC considers string literals to be constants.
74f10ca7 9282
022e70d4
PE
9283 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9284
59d6fe83
PE
9285 * dbusbind.c: Pointer signedness fixes.
9286 (xd_signature, xd_append_arg, xd_initialize):
9287 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9288 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9289 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9290 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9291
78320123
PE
9292 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9293 if GCC considers string literals to be constants.
49cebcca 9294 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9295
35ac2a97
SM
92962011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9297
fb103ca9
SM
9298 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9299 (print_preprocess, print_object): New macro to fix last change.
9300
35ac2a97
SM
9301 * print.c (print_preprocess): Don't forget font objects.
9302
62973b41
JB
93032011-03-16 Juanma Barranquero <lekktu@gmail.com>
9304
9305 * emacs.c (USAGE3): Doc fixes.
9306
0e48bb22
AS
93072011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9308
9309 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9310 structure.
9311
7684e57b
JB
93122011-03-14 Juanma Barranquero <lekktu@gmail.com>
9313
9314 * lisp.h (VWindow_system, Qfile_name_history):
9315 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9316 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9317 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9318
9319 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9320 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9321
9322 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9323 * w32console.c (detect_input_pending, read_input_pending)
9324 (encode_terminal_code):
9325 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9326 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9327 (w32_system_caret_y, Qfile_name_history):
9328 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9329 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9330 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9331 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9332 * w32proc.c (Qlocal, report_file_error):
9333 * w32term.c (Vwindow_system, updating_frame):
9334 * w32uniscribe.c (initialized, uniscribe_font_driver):
9335 Remove unneeded extern declarations.
9336
2aa46d6c
CY
93372011-03-14 Chong Yidong <cyd@stupidchicken.com>
9338
c96bbc66 9339 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9340
cffc6f3b
CY
93412011-03-13 Chong Yidong <cyd@stupidchicken.com>
9342
9343 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9344 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9345 These macros can no longer be used for assignment.
9346
44f230aa
SM
9347 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9348 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9349 (record_buffer_markers, fetch_buffer_markers): New functions for
9350 recording and fetching special buffer markers.
9351 (set_buffer_internal_1, set_buffer_temp): Use them.
9352
9353 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9354
9355 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9356
9357 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9358 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9359
9360 * xdisp.c (hscroll_window_tree):
9361 (reconsider_clip_changes): Use PT instead of BUF_PT.
9362
d251f04b
EZ
93632011-03-13 Eli Zaretskii <eliz@gnu.org>
9364
9365 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9366 $(EMACS_ROOT)/lib/intprops.h.
9367
f0c77cd1
PE
93682011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9369
3eca4629
PE
9370 Fix more problems found by GCC 4.5.2's static checks.
9371
7c86ee98
PE
9372 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9373 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9374 (xg_free_frame_widgets): Make it clear that a local variable is
9375 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9376 (gdk_window_get_screen): Make it clear that this macro is needed
9377 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9378 (int_gtk_range_get_value): New function, which avoids a diagnostic
9379 from gcc -Wbad-function-cast.
9380 (xg_set_toolkit_scroll_bar_thumb): Use it.
9381 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9382 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9383 (get_utf8_string, xg_get_file_with_chooser):
9384 Rename locals to avoid shadowing.
9385 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9386
41729b81
PE
9387 * xgselect.c (xg_select): Remove unused var.
9388
f0c77cd1
PE
9389 * image.c (four_corners_best): Mark locals as initialized.
9390 (gif_load): Initialize transparent_p to zero (Bug#8238).
9391 Mark another local as initialized.
ec6cf4c6 9392 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9393
ce0ad53d 9394 * image.c (clear_image_cache): Now static.
d5d5a617 9395 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9396 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9397 (x_edge_detection): Remove unnecessary cast that
9398 gcc -Wbad-function-cast diagnoses.
2037898d 9399 (gif_load): Fix pointer signedness.
6ae141d6
PE
9400 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9401 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9402
33383987 94032011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9404
d32df629
PE
9405 Improve quality of tests for time stamp overflow.
9406 For example, without this patch (encode-time 0 0 0 1 1
9407 1152921504606846976) returns the obviously-bogus value (-948597
9408 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9409 reports time overflow. See
9410 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9411 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9412 * editfns.c: Include limits.h and intprops.h.
9413 (TIME_T_MIN, TIME_T_MAX): New macros.
9414 (time_overflow): Move earlier, to before first use.
9415 (hi_time, lo_time): New functions, for an accurate test for
9416 out-of-range times.
9417 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9418 (Fget_internal_run_time): Don't assume time_t fits in int.
9419 (make_time): Use list2 instead of Fcons twice.
9420 (Fdecode_time): More accurate test for out-of-range times.
9421 (check_tm_member): New function.
9422 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9423 (lisp_time_argument): Don't rely on undefined left-shift and
9424 right-shift behavior when checking for time stamp overflow.
8be6f318 9425
fe31d94c
PE
9426 * editfns.c (time_overflow): New function, refactoring common code.
9427 (Fformat_time_string, Fdecode_time, Fencode_time):
9428 (Fcurrent_time_string): Use it.
9429
8be6f318
PE
9430 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9431 * dired.c (make_time): Move to ...
9432 * editfns.c (make_time): ... here.
9433 * systime.h: Note the move.
9434
09d9db2c 94352011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9436
126bc0dc
YM
9437 * fringe.c (update_window_fringes): Remove unused variables.
9438
c47cbdfd
YM
9439 * unexmacosx.c (copy_data_segment): Also copy __got section.
9440 (Bug#8223)
9441
7ac80be9
EZ
94422011-03-12 Eli Zaretskii <eliz@gnu.org>
9443
c96bbc66 9444 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9445 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9446 Constify `char *' arguments and their references according to
9447 prototypes in tparam.h.
9448
ecb0f94d 9449 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9450
7ac80be9
EZ
9451 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9452 Adapt all references accordingly.
9453
9454 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9455
ef1fd07e
TT
94562011-03-11 Tom Tromey <tromey@redhat.com>
9457
9458 * buffer.c (syms_of_buffer): Remove obsolete comment.
9459
7ef4b50c
EZ
94602011-03-11 Eli Zaretskii <eliz@gnu.org>
9461
9462 * termhooks.h (encode_terminal_code): Declare prototype.
9463
9464 * msdos.c (encode_terminal_code): Don't declare prototype.
9465
9466 * term.c (encode_terminal_code): Now external again, used by
9467 w32console.c and msdos.c.
9468
44f230aa
SM
9469 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9470 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9471
4b1ec863 94722011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9473
1714f52b 9474 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9475
4b1ec863
PE
9476 * fringe.c (update_window_fringes): Mark locals as initialized
9477 (Bug#8227).
9478 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9479
524c7aa6
PE
9480 * alloc.c (mark_fringe_data): Move decl from here ...
9481 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9482 to check its interface.
9483 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9484
a5c0af81 9485 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9486 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9487 (fontset_font): Mark local as initialized.
a9a06e0b 9488 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9489
b4716021
PE
9490 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9491
811e9bac 9492 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9493 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9494 (x_own_selection, Fx_disown_selection_internal): Rename locals
9495 to avoid shadowing.
9496 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9497
7e3ab302
PE
9498 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9499 so that the caller can use some name other than gcpro1.
9500 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9501 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9502 (Fx_backspace_delete_keys_p):
9503 Use them to avoid shadowing, and rename vars to avoid shadowing.
9504 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9505 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9506 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9507 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9508 Remove unused locals.
7e3ab302
PE
9509 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9510 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9511 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9512 macros.
f78faa98 9513
e2b13473
PE
9514 * xterm.h (x_mouse_leave): New decl.
9515
77f23912
PE
9516 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9517 Remove unused functions.
cdf4ba58
PE
9518 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9519 (x_calc_absolute_position): Now static.
7411c686 9520 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9521 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9522 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9523 unless they are used.
38d0b34a
PE
9524 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9525 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9526 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9527 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9528 (x_error_catcher, x_connection_closed, x_error_handler):
9529 (x_error_quitter, xembed_send_message, x_iconify_frame):
9530 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9531 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9532 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9533
44f230aa
SM
9534 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9535 Rename or move locals to avoid shadowing.
6b463e58 9536 (tty_defined_color, merge_face_heights): Now static.
5967d051 9537 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9538 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9539 does not deduce is never used uninitialized.
73719eba
PE
9540 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9541 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9542
426994c3 9543 * terminal.c (store_terminal_param): Now static.
5489860b 9544
032f1620 9545 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9546 (set_frame_menubar): Remove unused local.
d4323972 9547 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9548 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9549 since they might point to immutable storage.
281585b0
PE
9550 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9551 since it's unused otherwise.
032f1620 9552
367c19e5 9553 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9554 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9555 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9556 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9557 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9558 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9559 does not deduce are never used uninitialized.
70739cbe 9560
07b48fa9
PE
9561 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9562
8868a238 9563 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9564 * window.c (window_loop, size_window):
9565 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9566
7e5cf297 9567 * window.c (display_buffer): Now static.
d6550a9f
PE
9568 (size_window): Mark variables that gcc -Wuninitialized
9569 does not deduce are never used uninitialized.
a586633d
PE
9570 * window.h (check_all_windows): New decl, to forestall
9571 gcc -Wmissing-prototypes diagnostic.
5b555da1 9572 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9573
f6095868
PE
9574 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9575 shadowing.
9576 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9577 Include <limits.h>.
9578 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9579 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9580 (load_charset_map): Mark variables that gcc -Wuninitialized
9581 does not deduce are never used uninitialized.
53df7c11 9582 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9583
f38b440c
PE
9584 * coding.c (coding_set_source, coding_set_destination):
9585 Use "else { /* comment */ }" rather than "else /* comment */;"
9586 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9587 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9588 a block, when the outer 'i' will do.
9589 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9590 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9591 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9592 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9593 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9594 Rename locals to avoid shadowing.
9595 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9596 * coding.c (emacs_mule_char, encode_invocation_designation):
9597 Now static, since they're not used elsewhere.
413bb2db 9598 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9599 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9600 (decode_coding_emacs_mule): Mark variables that gcc
9601 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9602 (detect_coding_iso_2022): Initialize a local variable that might
9603 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9604 this initialization is needed. (Bug#8211)
5f58e762
PE
9605 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9606 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9607 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9608 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9609 Remove unused macros.
f38b440c 9610
232b38b9 9611 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9612 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9613 * character.c (string_count_byte8): Likewise.
232b38b9 9614
fb90da1b
PE
9615 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9616 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9617
fb93dbc2
PE
9618 * chartab.c (copy_sub_char_table): Now static, since it's not used
9619 elsewhere.
5c156ace
PE
9620 (sub_char_table_ref_and_range, char_table_ref_and_range):
9621 Rename locals to avoid shadowing.
bbcd0949 9622 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9623
7d3b3862 9624 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9625 (BIDI_BOB): Remove unused macro.
7d3b3862 9626
6be7d3da
PE
9627 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9628 deduce are never used uninitialized.
c2ed9c8b 9629 * term.c (encode_terminal_code): Likewise.
6be7d3da 9630
75f8807f 9631 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9632
50938595
PE
9633 * tparam.h: New file.
9634 * term.c, tparam.h: Include it.
9635 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9636 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9637 Move these decls to tparam.h, and make them agree with what
9638 is actually in tparam.c. The previous trick of using incompatible
9639 decls in different modules does not conform to the C standard.
9640 All callers of tparam changed to use tparam's actual API.
9641 * tparam.c (tparam1, tparam, tgoto):
9642 Use const pointers where appropriate.
9643
fbceeba2
PE
9644 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9645 * cm.h (struct cm): Likewise.
9646 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9647 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9648 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9649 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9650 (turn_on_face, init_tty): Likewise.
9651 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9652
7f3f1250
PE
9653 * term.c (term_mouse_position): Rename local to avoid shadowing.
9654
e6ca6543
PE
9655 * alloc.c (mark_ttys): Move decl from here ...
9656 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9657
c40f8d15
AS
96582011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9659
9660 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9661
cfe0661d
JB
96622011-03-09 Juanma Barranquero <lekktu@gmail.com>
9663
9664 * search.c (compile_pattern_1): Remove argument regp, unused since
9665 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9666 (compile_pattern): Don't pass it.
9667
0afb4571
J
96682011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9669
9670 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9671 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9672 for ! HAVE_GTK3.
9673 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9674
9675 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9676
9677 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9678 gdk_window_get_screen, gdk_window_get_geometry,
9679 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9680 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9681 (xg_get_pixbuf_from_pixmap): New function.
9682 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9683 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9684 Call xg_get_pixbuf_from_pixmap instead of
9685 gdk_pixbuf_get_from_drawable.
9686 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9687 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9688 (xg_check_special_colors): Use GtkStyleContext and its functions
9689 for HAVE_GTK3.
9690 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9691 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9692 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9693 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9694 Call gtk_widget_get_preferred_size.
0afb4571
J
9695 (xg_frame_resized): gdk_window_get_geometry only takes 5
9696 parameters.
44f230aa
SM
9697 (xg_win_to_widget, xg_event_is_for_menubar):
9698 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9699 (xg_set_widget_bg): New function.
9700 (delete_cb): New function.
895009e1 9701 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9702 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9703 (xg_set_background_color): Call xg_set_widget_bg.
9704 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9705 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9706 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9707 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9708 if ! HAVE_GTK3.
9709 (update_frame_tool_bar): Call gtk_widget_hide.
9710 (xg_initialize): Use GDK_KEY_g.
9711
9712 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9713 if ! HAVE_GTK3
9714 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9715
9716 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9717 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9718 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9719
1c2cc4ef
JB
97202011-03-08 Juanma Barranquero <lekktu@gmail.com>
9721
9722 * w32xfns.c (select_palette): Check success of RealizePalette against
9723 GDI_ERROR, not zero.
9724
33383987 9725See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9726
9727;; Local Variables:
9728;; coding: utf-8
aac0c6e3
MR
9729;; End:
9730
acaf905b 9731 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9732
9733 This file is part of GNU Emacs.
9734
9735 GNU Emacs is free software: you can redistribute it and/or modify
9736 it under the terms of the GNU General Public License as published by
9737 the Free Software Foundation, either version 3 of the License, or
9738 (at your option) any later version.
9739
9740 GNU Emacs is distributed in the hope that it will be useful,
9741 but WITHOUT ANY WARRANTY; without even the implied warranty of
9742 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9743 GNU General Public License for more details.
9744
9745 You should have received a copy of the GNU General Public License
9746 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.