Move ULIMIT_BREAK_VALUE from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6de0e799
GM
12012-07-13 Glenn Morris <rgm@gnu.org>
2
dbee5793
GM
3 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4
6de0e799
GM
5 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
6 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
7
b82da769
GM
82012-07-12 Glenn Morris <rgm@gnu.org>
9
4fae5a7a 10 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
11
12 * process.c (init_process_emacs): Rename from init_process.
13 The old name is also the name of a Mach system call.
14 * lisp.h, emacs.c: Update for this name change.
15 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
16 longer needed.
17
5a979817
EZ
182012-07-12 Eli Zaretskii <eliz@gnu.org>
19
20 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
21 memmove call that removes glyphs covered by the left truncation
22 glyph. Improve commentary.
23 (display_line): Fix display of continuation glyphs on GUI frames
24 when the right fringe is turned off and variable-size fonts are
25 used in the window. Move the code that appends a stretch glyph to
26 produce_special_glyphs, so that it could be used for truncation
27 and continuation glyphs alike.
28 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
29 glyph of a suitably computed width, to align the special glyphs at
30 the window margin. Code moved from display_line. (Bug#11832)
31
3e91a053
GM
322012-07-12 Glenn Morris <rgm@gnu.org>
33
ba9e4b84
GM
34 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
35
36 * s/gnu-linux.h, s/hpux10-20.h:
37 Do not unconditionally define HAVE_XRMSETDATABASE.
38
3e91a053
GM
39 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
40
b300b1f4
PE
412012-07-12 Paul Eggert <eggert@cs.ucla.edu>
42
43 Fix typos that broke OS X build.
44 Reported by Randal L. Schwartz in
45 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
46 * nsterm.m (ns_timeout): Add missing local decl.
47 (ns_get_color): snprintf -> sprintf, to fix typo.
48
6e777848
GM
492012-07-12 Glenn Morris <rgm@gnu.org>
50
3f922c37
GM
51 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
52 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
53 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
54 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
55
0ab7b23a
GM
56 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
57 Move PTY_OPEN to configure.
58
6e777848
GM
59 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
60 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
61 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
62
4a7edc24
DA
632012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
64
65 Use empty_unibyte_string where applicable.
66 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
67 * lread.c (read1): Likewise.
68 * xsettings.c (syms_of_xsettings): Likewise.
69
308aab79
GM
702012-07-12 Glenn Morris <rgm@gnu.org>
71
42bd1719
GM
72 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
73 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
74 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
75 * s/hpux10-20.h (RUN_TIME_REMAP):
76 * s/bsd-common.h (TABDLY): Move to configure.
77
78 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
79
80 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
81
ea0bbd17 82 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 83 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
84
85 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 86
308aab79
GM
87 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
88 * s/template.h: Move NARROWPROTO to configure.
89
ee1cf5cf
GM
902012-07-11 Glenn Morris <rgm@gnu.org>
91
30fe9bf4
GM
92 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
93 unused since 2011-01-17 change to systty.h.
94
ee1cf5cf
GM
95 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
96 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
97 Move HAVE_PTYS and HAVE_SOCKETS to configure.
98
63e47e07
PE
992012-07-11 Paul Eggert <eggert@cs.ucla.edu>
100
101 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
102
c43fb4c3
GM
1032012-07-11 Glenn Morris <rgm@gnu.org>
104
105 * s/darwin.h, s/gnu-linux.h, s/template.h:
106 Move INTERRUPT_INPUT to configure.
107
e8df9267
DA
1082012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Minor adjustments to interning code.
111 * lisp.h (intern, intern_c_string): Redefine as static inline
112 wrappers for intern_1 and intern_c_string_1, respectively.
113 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
114 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
115 Vobarray checking.
e8df9267
DA
116 * font.c (font_intern_prop): Likewise. Adjust comment.
117 * w32font.c (intern_font_name): Likewise.
118
34348bd4
AS
1192012-07-11 Andreas Schwab <schwab@linux-m68k.org>
120
d96a1e0c
AS
121 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
122
34348bd4
AS
123 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
124 of Fcar/Fcdr if possible.
125 * font.c (check_otf_features): Likewise.
126 * fontset.c (Fnew_fontset): Likewise.
127 * gnutls.c (Fgnutls_boot): Likewise.
128 * minibuf.c (read_minibuf): Likewise.
129 * msdos.c (IT_set_frame_parameters): Likewise.
130 * xmenu.c (Fx_popup_dialog): Likewise.
131 * w32menu.c (Fx_popup_dialog): Likewise.
132
c8add24e
GM
1332012-07-11 Glenn Morris <rgm@gnu.org>
134
4b575b3c
GM
135 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
136 since nothing has defined it on these platforms.
137
09f4e3b0
GM
138 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
139 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
140
172bedef
GM
141 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
142 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
143 Move CLASH_DETECTION to configure.
144
249685df
GM
145 * s/gnu.h: Remove file, which is now empty.
146
c8add24e
GM
147 * s/gnu.h, s/gnu-linux.h:
148 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
149
b41253a3
JW
1502012-07-11 John Wiegley <johnw@newartisans.com>
151
152 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
153 function attribute, so we only use it if it exists in the
154 compiler.
155
d923b542
DA
1562012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
157
158 Avoid call to strlen in fast_c_string_match_ignore_case.
159 * search.c (fast_c_string_match_ignore_case): Change to use
160 length argument. Adjust users accordingly.
161 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
162
5ebbef1d
PE
1632012-07-11 Paul Eggert <eggert@cs.ucla.edu>
164
bb352260
PE
165 Assume mkdir, rmdir.
166 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
167 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
168
57054ddd
PE
169 Assume rename.
170 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
171
b747d3f7
PE
172 Assume perror.
173 * s/hpux10-20.h (HAVE_PERROR): Remove.
174 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
175 Remove dummy definition, as this problem was obsolete long ago.
176
5ebbef1d
PE
177 Assume strerror.
178 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
179
984e7f30
DA
1802012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
181
182 Avoid calls to strlen in font processing functions.
183 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 184 (font_open_by_name): Change to use length argument. Adjust
984e7f30 185 users accordingly.
d923b542
DA
186 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
187 Adjust prototypes.
188 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
189 Change to return ptrdiff_t.
984e7f30
DA
190 (xfont_list_pattern, xfont_match): Use length returned by
191 xfont_decode_coding_xlfd.
192 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
193
20e94fdd
GM
1942012-07-11 Glenn Morris <rgm@gnu.org>
195
9d596af3
GM
196 * s/darwin.h, s/freebsd.h, s/netbsd.h:
197 Move DONT_REOPEN_PTY to configure.
198
20e94fdd
GM
199 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
200 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
201
e99a530f
PE
2022012-07-10 Paul Eggert <eggert@cs.ucla.edu>
203
22ffb973
PE
204 Remove "#define unix" that is no longer needed (Bug#11905).
205 * s/aix4-2.h (unix): Remove; no longer needed.
206
e9a9ae03
PE
207 EMACS_TIME simplification (Bug#11875).
208 This replaces macros (which typically do not work in GDB)
209 with functions, typedefs and enums, making the code easier to debug.
210 The functional style also makes code easier to read and maintain.
211 * systime.h: Include <sys/time.h> on all hosts, not just if
212 WINDOWSNT, since 'struct timeval' is needed in general.
213 (EMACS_TIME): Now a typedef, not a macro.
214 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
215 not macros.
216 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
217 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
218 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
219 (EMACS_TIME_LE): Now functions, not macros.
220 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
221 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
222 which are not functions. All uses rewritten to use:
223 (make_emacs_time): New function.
224 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
225 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
226 not functions. All uses rewritten to use the following, respectively:
227 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
228 (add_emacs_time, sub_emacs_time): New functions.
229 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
230 * fileio.c (Fcopy_file):
231 * xterm.c (XTflash): Get the current time closer to when it's used.
232 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
233
ffacb126
PE
234 * bytecode.c (targets): Suppress -Woverride-init warnings.
235
e99a530f
PE
236 Simplify by avoiding confusing use of strncpy etc.
237 * doc.c (Fsnarf_documentation):
238 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
239 * frame.c (Fmake_terminal_frame):
240 * gtkutil.c (get_utf8_string):
241 * lread.c (openp):
242 * nsmenu.m (ns_update_menubar):
243 * regex.c (regerror):
244 Prefer memcpy to strncpy and strncat when either will do.
245 * fileio.c (Fsubstitute_in_file_name):
246 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
247 (menu_separator_name_p):
248 * nsmenu.m (ns_update_menubar):
249 Prefer memcmp to strncmp when either will do.
250 * nsterm.m: Include <ftoastr.h>.
251 (ns_get_color):
252 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
253 Prefer snprintf to strncpy.
254 * nsterm.m (ns_term_init):
255 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
256 * nsterm.m (ns_term_init):
257 Avoid the need for strncpy, by using build_string or
258 make_unibyte_string directly. Use dtoastr, not snprintf.
259 * process.c (Fmake_network_process): Diagnose service names that
260 are too long, rather than silently truncating them or creating
261 non-null-terminated names.
262 (Fnetwork_interface_info): Likewise, for interface names.
263 * sysdep.c (system_process_attributes) [GNU_LINUX]:
264 Prefer sprintf to strncat.
265 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
266 Prefer vsnprintf to vsprintf + strncpy.
267
c59592b3
GM
2682012-07-10 Glenn Morris <rgm@gnu.org>
269
270 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
271 Clarify fallback case.
272
7d7bbefd
DA
2732012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
276 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
277 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 278 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
279 where argument type is known to be a Lisp_Cons.
280
3a4c8000
TT
2812012-07-10 Tom Tromey <tromey@redhat.com>
282
283 * bytecode.c (BYTE_CODE_THREADED): New macro.
284 (BYTE_CODES): New macro. Replaces all old byte-code defines.
285 (enum byte_code_op): New type.
286 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
287 (exec_byte_code): Use them. Use token threading when applicable.
288
2a0213a6
DA
2892012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
290
291 Optimize pure C strings initialization.
292 * lisp.h (make_pure_string): Fix prototype.
293 (build_pure_c_string): New function, defined as static inline. This
294 provides a better opportunity to optimize away calls to strlen when
295 the function is called with compile-time constant argument.
296 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
297 argument, adjust users accordingly. Use build_pure_c_string where
298 appropriate.
299 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
300 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
301 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
302
cb1caeaf
DA
3032012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
304
305 Avoid calls to strlen in miscellaneous functions.
306 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
307 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
308 * lread.c (openp): Likewise.
309
c293e30c
DA
3102012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
311
312 Avoid calls to strlen in path processing functions.
313 * fileio.c (file_name_as_directory): Add comment. Change to add
314 srclen argument and return the length of result. Adjust users
315 accordingly.
316 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 317 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
318 users accordingly.
319 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
320
9e059e3f
GM
3212012-07-10 Glenn Morris <rgm@gnu.org>
322
d02eb359
GM
323 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
324 Move PENDING_OUTPUT_COUNT definition to configure.
325
882cf227
GM
326 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
327 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
328 * s/gnu.h (DATA_START): Move definitions to configure.
329
af6e839f
GM
330 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
331 We include usg5-4-common.h, which defines them both.
332
40289a12
GM
333 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
334 O_RDONLY already includes it).
335
9e059e3f
GM
336 Stop ns builds setting the EMACSLOADPATH environment variable.
337 * nsterm.m (ns_load_path): Rename from ns_init_paths.
338 Now it does not set EMACSLOADPATH, just returns the load-path string.
339 * nsterm.h: Update accordingly.
340 * lread.c [HAVE_NS]: Include nsterm.h.
341 (init_lread) [HAVE_NS]: Use ns_load_path.
342 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
343
7c4e8ec0
GM
3442012-07-09 Glenn Morris <rgm@gnu.org>
345
d4f600ff
GM
346 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
347 since the included bsd-common.h does so.
348
cbb31951
GM
349 Stop ns builds setting the EMACSPATH environment variable.
350 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
351 (ns_init_paths): Do not set EMACSPATH.
352 * nsterm.h (ns_exec_path): Add it.
353 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
354 Use ns_exec_path.
355
7c4e8ec0
GM
356 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
357
26bccfae
PE
3582012-07-09 Paul Eggert <eggert@cs.ucla.edu>
359
a0bee46f
PE
360 * process.c (wait_reading_process_output): 'waitchannels' was unset
361 when read_kbd || !NILP (wait_for_cell); fix this.
362
5994c183
PE
363 Add GCC-style 'const' attribute to functions that can use it.
364 * character.h (char_resolve_modifier_mask):
365 * keyboard.h (make_ctrl_char):
366 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
367 (init_character_once, next_almost_prime, init_fns, init_image)
368 (flush_pending_output, init_sound):
369 * mem-limits.h (start_of_data):
370 * menu.h (finish_menu_items):
371 Add ATTRIBUTE_CONST.
372 * emacs.c (DEFINE_DUMMY_FUNCTION):
373 Declare the dummy function with ATTRIBUTE_CONST.
374 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
375 Add decls with ATTRIBUTE_CONST.
376
26bccfae
PE
377 Minor improvements to make_formatted_string.
378 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
379 where int is good enough, as vsprintf returns an int.
380 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
381
a8290ec3
DA
3822012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
383
384 Use make_formatted_string to avoid double length calculation.
385 * lisp.h (make_formatted_string): New prototype.
386 * alloc.c (make_formatted_string): New function.
387 * buffer.c (Fgenerate_new_buffer_name): Use it.
388 * dbus.c (syms_of_dbusbind): Likewise.
389 * editfns.c (Fcurrent_time_zone): Likewise.
390 * filelock.c (get_boot_time): Likewise.
391 * frame.c (make_terminal_frame, set_term_frame_name)
392 (x_report_frame_params): Likewise.
393 * image.c (gs_load): Likewise.
394 * minibuf.c (get_minibuffer): Likewise.
395 * msdos.c (dos_set_window_size): Likewise.
396 * process.c (make_process): Likewise.
397 * xdisp.c (ensure_echo_area_buffers): Likewise.
398 * xsettings.c (apply_xft_settings): Likewise.
399
d01ba2f1
GM
4002012-07-09 Glenn Morris <rgm@gnu.org>
401
402 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
403 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
404 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
405 * nsterm.h (ns_etc_directory): Add it.
406 * callproc.c [HAVE_NS]: Include nsterm.h.
407 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
408
f1f924b6
DA
4092012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
410
411 Move marker debugging code under MARKER_DEBUG.
412 * marker.c (MARKER_DEBUG): Move marker debugging code under
413 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
414 for bootstrap with --enable-checking (~3x slowdown reported
415 by Juanma Barranquero <lekktu@gmail.com>).
416 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
417
ab531b66
PE
4182012-07-08 Paul Eggert <eggert@cs.ucla.edu>
419
420 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
421 See <http://bugs.gnu.org/11825#29>.
422
c4b3bc8a
EZ
4232012-07-08 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
426 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
427 (display_line): Add commentary about displaying truncation glyphs
428 on GUI frames.
429 (produce_special_glyphs): Move here from term.c.
430
431 * term.c (produce_special_glyphs): Move to xdisp.c.
432
433 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
434 section.
c4b3bc8a 435
b676b881
AS
4362012-07-07 Andreas Schwab <schwab@linux-m68k.org>
437
f17c5273
AS
438 * xdisp.c (display_line): Avoid warning about implicit declaration
439 of FRAME_FONT.
440
298819b9
AS
441 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
442
b676b881
AS
443 * lisp.h: Remove empty conditional.
444
6045c4fd
PE
4452012-07-07 Paul Eggert <eggert@cs.ucla.edu>
446
b3350bf9
PE
447 * lread.c (load_path_check): Now static.
448
6045c4fd
PE
449 Fix some minor --with-ns problems found by static checking.
450 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
451 (x_set_font) [!HAVE_X_WINDOWS]:
452 * image.c (xpm_load_image) [HAVE_NS]:
453 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
454 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
455 Remove unused local.
456 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
457 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
458 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
459 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
460 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
461 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
462 Fix pointer signedness problem.
463 * xfaces.c (FRAME_X_FONT_TABLE):
464 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
465
929e7845
GM
4662012-07-07 Glenn Morris <rgm@gnu.org>
467
468 * lread.c (load_path_check): New function, split from init_lread.
469 (init_lread): Reorganize. Motivation:
470 If EMACSLOADPATH is set, check/warn about that rather than the
471 defaults, which we are not going to use. Hence we can remove
472 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
473 Don't warn if site-lisp directories are missing.
474 If not installed, start from a blank load-path, since
475 PATH_LOADSEARCH refers to the eventual installation directories.
476
58dd0aa4
EZ
4772012-07-07 Eli Zaretskii <eliz@gnu.org>
478
479 Support truncation and continuation glyphs on GUI frames, when
480 fringes are disabled. (Bug#11832)
481 * xdisp.c (init_iterator): Get dimensions of truncation and
482 continuation glyphs even if on GUI frames. Adjust
483 it->last_visible_x on GUI frames when the left or right fringes,
484 or both, are absent.
485 (start_display, move_it_in_display_line_to): Handle the case of a
486 GUI frame without a fringe to display continuation or truncation
487 glyphs.
488 (insert_left_trunc_glyphs): Support GUI frames: make sure
489 truncation glyphs overwrite enough glyphs from the current line to
490 have sufficient space in pixels.
491 (display_line): Support truncation and continuation glyphs on GUI
492 frames. If some spare pixels are left on the line after inserting
493 the truncation glyphs, fill that space with a stretch glyph of a
494 suitably computed width.
495
496 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
497 produce_glyphs, to support GUI sessions.
498
31571fd7
PE
4992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
500
5a16b9bc
PE
501 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
502
f3047c75
PE
503 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
504
31571fd7
PE
505 Do not require float-time's arg to fit in time_t (Bug#11825).
506 This works better on hosts where time_t is unsigned, and where
507 float-time is applied to the (negative) difference between two times.
508 * editfns.c (decode_time_components): Last arg is now double *,
509 not int *, and means to store all the result as a double, without
510 worrying about whether the seconds part fits in time_t.
511 All callers changed.
512 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
513 All callers changed.
514 (Ffloat_time): Do not fail merely because the specified time falls
515 outside of time_t range.
516
4516fbef
GM
5172012-07-07 Glenn Morris <rgm@gnu.org>
518
519 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
520 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
521 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
522
07adc2c6
JB
5232012-07-07 Juanma Barranquero <lekktu@gmail.com>
524
525 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
526 Update dependencies.
527
528 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
529
fd573f31
PE
5302012-07-06 Paul Eggert <eggert@cs.ucla.edu>
531
fee5959d
PE
532 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
533 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
534 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
535 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
536 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
537 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
538
fd573f31
PE
539 * xfont.c (compare_font_names): Redo to omit the need for casts.
540
ddadbc0e
AS
5412012-07-06 Andreas Schwab <schwab@linux-m68k.org>
542
fca8d6b6
AS
543 * xfns.c (Fx_change_window_property): Doc fix.
544 * w32fns.c (Fx_change_window_property): Doc fix.
545
ddadbc0e
AS
546 * w32fns.c (Fx_window_property): Accept the same arguments as the
547 X Windows version. Doc fix.
548 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
549
f247498e
JB
5502012-07-06 Juanma Barranquero <lekktu@gmail.com>
551 Eli Zaretskii <eliz@gnu.org>
552
553 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
554 Windows-specific code from nt/config.nt moved here.
555 Obsolete settings removed.
556
216ee680
PE
5572012-07-06 Paul Eggert <eggert@cs.ucla.edu>
558
559 * process.c: Avoid unnecessary calls to gettime.
560 (wait_reading_process_output): Don't get the time of day
561 when gobbling data immediately and not waiting, as there's no need
562 for it in that case. This removes a FIXME.
563
bdd091e4
JD
5642012-07-06 Jan Djärv <jan.h.d@swipnet.se>
565
566 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
567 is defined (Bug#11768).
568
9d44f8ce
DA
5692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
570
571 Fix marker debugging code.
572 * marker.c (byte_char_debug_check): Do not perform the check
573 if buffer is not multibyte.
090bd7cb
JB
574 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
575 Call byte_char_debug_check with correct arguments.
9d44f8ce 576
90fc4786
DA
5772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
578
579 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
580 * marker.c (byte_char_debug_check, count_markers):
581 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
582 (byte_debug_flag): Remove.
583 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
584 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
585
7b7ae965
DA
5862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
587
4e57b342
DA
588 Avoid code repetition in marker-related functions.
589 * marker.c (attach_marker): New function.
590 (Fset_marker, set_marker_restricted, set_marker_both)
591 (set_marker_restricted_both): Use it.
592 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
593 Consistently rename charno to charpos.
594 (marker_position): Add eassert.
595 (marker_byte_position): Convert to eassert.
596
5972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
598
599 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 600 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 601 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 602
657924ff
DA
6032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Introduce fast path for the widely used marker operation.
606 * alloc.c (build_marker): New function.
607 * lisp.h (build_marker): New prototype.
608 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
609 * composite.c (autocmp_chars): Likewise.
610 * editfns.c (buildmark): Remove.
611 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
612 (save_restriction_save): Use build_marker.
613 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
614 * window.c (save_window_save): Likewise.
615
041a49a6
DA
6162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
617
618 Do not use Fdelete_overlay in delete_all_overlays
619 to avoid redundant calls to unchain_overlay.
620 * buffer.c (drop_overlay): New function.
621 (delete_all_overlays, Fdelete_overlay): Use it.
622 * minibuf.c (get_minibuffer): Fix comment.
623
7dca65a4
PE
6242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
625
626 Port to OpenBSD 5.1 amd64.
627 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
628 This is needed for OpenBSD, and should be harmless on all BSD systems.
629 Also, include <sys/sysctl.h>, as it should be available on all
630 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
631 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
632 use p_pid member, not kp_proc.pid.
633
8eb876e2
GM
6342012-07-06 Glenn Morris <rgm@gnu.org>
635
636 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
637
38182d90
PE
6382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
639
640 More xmalloc and related cleanup.
641 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
642 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
643 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
644 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
645 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
646 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
647 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
648 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
649 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
650 * xterm.c:
651 Omit needless casts involving void * pointers and allocation.
652 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
653 as the former is more robust if P's type is changed.
654 Prefer xzalloc to xmalloc + memset 0.
655 Simplify malloc-or-realloc to realloc.
656 Don't worry about xmalloc returning a null pointer.
657 Prefer xstrdup to xmalloc + strcpy.
658 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
659 growing it.
660 * keyboard.c (apply_modifiers_uncached): Prefer local array to
661 alloca of a constant.
662
6dd5a677
EZ
6632012-07-05 Eli Zaretskii <eliz@gnu.org>
664
665 * xdisp.c (display_line): Fix horizontal pixel coordinates when
666 hscroll is larger than the line width. Fixes long and futile
667 looping inside extend_face_to_end_of_line (on a TTY) producing
668 glyphs that are not needed and thrown away.
669
6b312f0f
DA
6702012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
671
672 * marker.c (set_marker_restricted_both): Simplify by using
673 clip_to_bounds.
674
f520ef9b
PE
6752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
676
677 * editfns.c (region_limit): Simplify by using clip_to_bounds.
678
383b7c95
JD
6792012-07-05 Jan Djärv <jan.h.d@swipnet.se>
680
681 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
682 not defined (Bug#11768).
683 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
684 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
685 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
686 followed by gtk_box_set_homogeneous (Bug#11768).
687 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
688 (update_theme_scrollbar_width, xg_create_scroll_bar):
689 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
690 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
691 (is_box_type): New function (Bug#11768).
692 (xg_tool_item_stale_p): Call is_box_type.
5293d758 693 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
694 with default display (Bug#11768).
695
d6e7bf45
EZ
6962012-07-05 Eli Zaretskii <eliz@gnu.org>
697
698 * xdisp.c (window_hscroll_limited): New function.
699 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
700 coordinates when window's hscroll is set to insanely large
701 values. (Bug#11857)
702
431391ec
JB
7032012-07-05 Juanma Barranquero <lekktu@gmail.com>
704
705 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
706 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
707
23f86fce
DA
7082012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
709
710 Cleanup xmalloc.
711 * lisp.h (xzalloc): New prototype. Omit needless casts.
712 * alloc.c (xzalloc): New function. Omit needless casts.
713 * charset.c: Omit needless casts. Convert all calls to
714 xmalloc with following memset to xzalloc.
715 * dispnew.c: Likewise.
716 * fringe.c: Likewise.
717 * image.c: Likewise.
718 * sound.c: Likewise.
719 * term.c: Likewise.
720 * w32fns.c: Likewise.
721 * w32font.c: Likewise.
722 * w32term.c: Likewise.
723 * xfaces.c: Likewise.
724 * xfns.c: Likewise.
725 * xterm.c: Likewise.
726 * atimer.c: Omit needless casts.
727 * buffer.c: Likewise.
728 * callproc.c: Likewise.
729 * ccl.c: Likewise.
730 * coding.c: Likewise.
731 * composite.c: Likewise.
732 * doc.c: Likewise.
733 * doprnt.c: Likewise.
734 * editfns.c: Likewise.
735 * emacs.c: Likewise.
736 * eval.c: Likewise.
737 * filelock.c: Likewise.
738 * fns.c: Likewise.
739 * gtkutil.c: Likewise.
740 * keyboard.c: Likewise.
741 * lisp.h: Likewise.
742 * lread.c: Likewise.
743 * minibuf.c: Likewise.
744 * msdos.c: Likewise.
745 * print.c: Likewise.
746 * process.c: Likewise.
747 * region-cache.c: Likewise.
748 * search.c: Likewise.
749 * sysdep.c: Likewise.
750 * termcap.c: Likewise.
751 * terminal.c: Likewise.
752 * tparam.c: Likewise.
753 * w16select.c: Likewise.
754 * w32.c: Likewise.
755 * w32reg.c: Likewise.
756 * w32select.c: Likewise.
757 * w32uniscribe.c: Likewise.
758 * widget.c: Likewise.
759 * xdisp.c: Likewise.
760 * xmenu.c: Likewise.
761 * xrdb.c: Likewise.
762 * xselect.c: Likewise.
763
0497dc44
PE
7642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
765
766 * fileio.c (time_error_value): Check the right error number.
767 Problem reported by Troels Nielsen in
768 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
769
356e7178
PE
7702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
771
4e71fd89
PE
772 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
773 This should be fixed in a better way; see Eli Zaretskii in
774 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
775 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
776
f0941253
PE
777 * fileio.c (time_error_value): Rename from special_mtime.
778 The old name's problems were noted by Eli Zaretskii in
779 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
780
065c9eb4
PE
781 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
782 This variable's comment says Emacs needs at least one GDB-visible
783 symbol of type enum pvec_type, to work around GDB problems.
784 The symbol's value doesn't matter.
785
356e7178
PE
786 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
787 that causes compilation to fail on pre-C99 compilers.
788
95f61aa2
JB
7892012-07-04 Juanma Barranquero <lekktu@gmail.com>
790
791 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
792 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
793
3884d954
DA
7942012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
795
d209e2fb 796 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
797 headers for buffer_defaults and buffer_local_symbols.
798 Reported by Juanma Barranquero <lekktu@gmail.com>.
799
ee28be33
SM
8002012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
801
802 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
803 * lisp.h (enum pvec_type): Use fewer bits.
804 (PSEUDOVECTOR_SIZE_BITS): New constant.
805 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
806 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
807 change in pvec_type.
808 (PSEUDOVECTOR_TYPEP): New macro.
809 (TYPED_PSEUDOVECTORP): Use it.
810 * fns.c (internal_equal): Adapt code to extract pvectype.
811 * emacs.c (gdb_pvec_type): Update type.
812 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
813 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
814 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
815 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
816 (sweep_vectors): Use it. Use local var `total_bytes' instead of
817 abusing vector->header.next.nbytes.
818 (live_vector_p): Use PVEC_TYPE.
819 (mark_object): Adapt code to extract pvectype. Use switch.
820
c7f2cd7f
PE
8212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
822
823 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
824 Tighten new eassert a bit.
825
8ce70ed2
DA
8262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
827
828 Fix compilation with --enable-gcc-warnings and -O1
829 optimization level.
830 * doprnt.c (doprnt): Change type of tem to int, initialize
831 to avoid compiler warning. Add eassert.
832 * search.c (simple_search): Initialize match_byte to avoid
833 compiler warning. Add eassert.
834
dea7f1e5
PE
8352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
836
24a212eb
PE
837 Avoid weird behavior with large horizontal scrolls.
838 Without this change, for example, large hscroll values would
839 mess up Emacs's display on Fedora 15 x86, presumably due to
840 overflows in int calculations in the display code.
841 Also, if buffers had long lines, Emacs would freeze.
842 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
843 (set_window_hscroll): New function, containing the old guts of
844 Fset_window_hscroll. Return the clipped value.
845 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
846 This avoids the need to check against PTRDIFF_MAX.
847
dea7f1e5
PE
848 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
849
76046526
DA
8502012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
851
852 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
853
39adff0d
PE
8542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
855
63807d47
PE
856 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
857 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
858 since GCC 4.4.6 issues a bogus warning for them.
859
39adff0d
PE
860 Fix bugs in file timestamp newness comparisons.
861 * fileio.c (Ffile_newer_than_file_p):
862 * lread.c (Fload): Use full timestamp resolution of files,
863 not just the 1-second resolution, so that files that are only
864 slightly newer still count as newer.
865 * fileio.c (Ffile_newer_than_file_p): Don't assume file
866 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
867
dbeed9a6
PE
8682012-07-03 Paul Eggert <eggert@cs.ucla.edu>
869
870 * fileio.c: Improve handling of file time marker. (Bug#11852)
871 (special_mtime): New function.
872 (Finsert_file_contents, Fverify_visited_file_modtime):
873 Use it to set special mtime values consistently.
874
636334d6
AS
8752012-07-03 Andreas Schwab <schwab@linux-m68k.org>
876
877 * fileio.c (Finsert_file_contents): Properly handle st_mtime
878 marker for non-existing file. (Bug#11852)
879
e2017fe2
GM
8802012-07-03 Glenn Morris <rgm@gnu.org>
881
882 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
883 and did not make it into globals.h).
884
404dbd37
TT
8852012-07-03 Tom Tromey <tromey@redhat.com>
886
887 * window.c (Fset_window_margins, Fset_window_fringes)
888 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
889 * textprop.c (Fprevious_property_change): No longer static.
890 * syntax.c (Fsyntax_table_p): No longer static.
891 * process.c (Fget_process, Fprocess_datagram_address): No longer
892 static.
893 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
894 * keyboard.c (Fcommand_execute): No longer static.
895 Remove EXFUN.
896 * insdel.c (Fcombine_after_change_execute): No longer static.
897 * image.c (Finit_image_library): No longer static.
898 * fileio.c (Fmake_symbolic_link): No longer static.
899 * eval.c (Ffetch_bytecode): No longer static.
900 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
901 * doc.c (Fdocumentation_property, Fsnarf_documentation):
902 No longer static.
404dbd37
TT
903 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
904 static.
905 * dired.c (Ffile_attributes): No longer static.
906 * composite.c (Fcomposition_get_gstring): No longer static.
907 * callproc.c (Fgetenv_internal): No longer static.
908
909 * ccl.h: Remove EXFUNs.
910 * buffer.h: Remove EXFUNs.
911 * dispextern.h: Remove EXFUNs.
912 * intervals.h: Remove EXFUNs.
913 * fontset.h: Remove EXFUN.
914 * font.h: Remove EXFUNs.
915 * dosfns.c (system_process_attributes): Remove EXFUN.
916 * keymap.h: Remove EXFUNs.
917 * lisp.h: Remove EXFUNs.
918 * w32term.h: Remove EXFUNs.
919 * window.h: Remove EXFUNs.
920 * xsettings.h: Remove EXFUN.
921 * xterm.h: Remove EXFUN.
922
8e4fd1e1
GM
9232012-07-03 Glenn Morris <rgm@gnu.org>
924
925 * lisp.h (Frandom): Make it visible to C.
926 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
927 buffer for invisible buffers. (Bug#1229)
928
ca95b3eb
DA
9292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
930
931 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
932 values which aren't power of 2.
933 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
934 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
935 accordingly.
936
7555c33f
SM
9372012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
938
939 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
940
941 * alloc.c (mark_object): Revert part of last patch to use `switch'.
942
d12e8f5a
DA
9432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
944
945 * alloc.c (allocate_vector_block): Remove redundant
946 calls to mallopt if DOUG_LEA_MALLOC is defined.
947 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
948 avoid calls to mallopt if zero_vector is returned.
949
296094c3
DA
9502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
951
952 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
953 is enabled, avoid dereferencing NULL current_sblock if
954 running undumped.
955
36429c89
DA
9562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
957
958 Cleanup basic buffer management.
959 * buffer.h (struct buffer): Change layout to use generic vector
960 marking code. Fix some comments. Change type of 'clip_changed'
961 to bitfield. Remove unused #ifndef old.
962 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
963 (GET_OVERLAYS_AT): Fix indentation.
964 (for_each_per_buffer_object_at): New macro.
965 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
966 (Fbuffer_local_variables): Use it.
967 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
968 * alloc.c (allocate_buffer): Adjust to match new layout of
969 struct buffer. Fix comment.
970 (mark_overlay): New function.
971 (mark_buffer): Use it. Use mark_vectorlike to mark normal
972 Lisp area of struct buffer.
973 (mark_object): Use it. Adjust marking of misc objects
974 and related comments.
975
3b3e4cac
PE
9762012-07-02 Paul Eggert <eggert@cs.ucla.edu>
977
978 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
979 wrapper that is not needed because the wrapped code is a no-op (zero
980 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
981 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
982
cf5c0175
DA
9832012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
984
985 * alloc.c (mark_buffer): Simplify. Remove prototype.
986 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 987 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
988 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
989 redundant calls to mark_vectorlike for bool vectors.
990
ca26824c
GM
9912012-06-30 Glenn Morris <rgm@gnu.org>
992
2e4c5312
GM
993 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
994
ca26824c
GM
995 * epaths.in (PATH_SITELOADSEARCH): New.
996 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
997 This is rather than relying on --enable-locallisppath elements
998 having "site-lisp" in their names. (Bug#10208#25, 11658)
999
0d23c240
EZ
10002012-06-30 Eli Zaretskii <eliz@gnu.org>
1001
c9240d7a
EZ
1002 * w32proc.c (sys_select): Accept and ignore one more argument.
1003
1004 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1005
0d23c240 1006 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1007 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1008
1009 * sysdep.c: Don't include dos.h and dosfns.h.
1010
1011 * process.c (sys_select):
1012 * msdos.c (sys_select): Accept one more argument and ignore it.
1013
1014 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1015 adapt data types and code to that.
1016
1017 * dosfns.c:
1018 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1019 which clashes with the gnulib function of the same name.
1020
af5a5a98
AS
10212012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1022
c5e4379c
AS
1023 * font.c (font_style_to_value, font_style_symbolic)
1024 (font_prop_validate_style): Add type checks for values in
1025 font_style_table.
1026
af5a5a98
AS
1027 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1028 argument.
1029 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1030 uses.
1031
8d38f461
EZ
10322012-06-29 Eli Zaretskii <eliz@gnu.org>
1033
2e5a6631
EZ
1034 * xdisp.c (try_window_id): Undo last change.
1035
8d38f461
EZ
1036 * w32.c (getwd): Adjust commentary about startup_dir.
1037 (init_environment): Always call sys_access, even in non-MSVC
1038 builds. Don't chdir to the directory of the Emacs executable.
1039 This undoes code from 1997 which was justified by the need to
1040 "avoid conflicts when removing and renaming directories". But its
1041 downside was that every relative file name was being interpreted
1042 relative to the directory of the Emacs executable, which can never
1043 be TRT. In particular, it broke sys_access when called with
1044 relative file names.
1045 (sys_access): Map GetLastError to errno.
1046
2af3565e
DA
10472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1048
1049 * window.h (struct window): Change type of 'fringes_outside_margins'
1050 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1051 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1052 Adjust comment.
1053 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1054 to ptrdiff_t.
1055
c8d3a25c 10562012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1057
c8d3a25c
GM
1058 * gnutls.c (emacs_gnutls_handshake):
1059 Add QUIT to make the loop interruptible.
57570cd3 1060
c8d3a25c 10612012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1062
c8d3a25c
GM
1063 * charset.c (init_charset): Make lack of etc/charsets fatal.
1064
3e984ee8
DA
10652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1066
1067 * editfns.c (region_limit): Fix type mismatch.
1068
ef884f23
DA
10692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1070
1071 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1072 undefined. Convert from xassert to eassert.
1073 * nsmenu.m: Convert from xassert to eassert.
1074 * nsterm.m: Likewise.
1075
7d7e0027
SM
10762012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1077
1078 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1079
aa754e6a
PE
10802012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 Avoid integer overflow on scroll-left and scroll-right.
1083 * window.c (HSCROLL_MAX): New macro.
1084 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1085 overflow when requested scroll falls outside ptrdiff_t range.
1086
80b00b08
DA
10872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1088
1089 * window.h (struct window): Change type of 'hscroll',
1090 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1091 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1092 Adjust users accordingly.
1093 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1094 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1095 from EMACS_INT to ptrdiff_t.
1096 (make_window): Omit redundant initialization.
1097
62b2bcf6
JB
10982012-06-28 Juanma Barranquero <lekktu@gmail.com>
1099
1100 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1101
45942c7d
DA
11022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1103
1104 * window.h (struct window): Change type of 'use_time' and
1105 'sequence_number' from Lisp_Object to int.
1106 * frame.c (make_frame): Adjust users accordingly.
1107 * print.c (print_object): Likewise.
1108 * window.c (select_window, Fwindow_use_time, make_parent_window)
1109 (make_window): Likewise.
1110
e509cfa6
DA
11112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1112
1113 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1114 enabled with --enable-checking=[all,glyphs] configure option.
1115 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1116 adjust comments accordingly.
1117 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1118 undefined, adjust comments accordingly.
1119 * image.c: Likewise.
1120 * scroll.c: Likewise.
1121 * w32fns.c: Likewise.
1122 * w32term.c: Likewise.
1123 * xdisp.c: Likewise.
1124 * xfaces.c: Likewise.
1125 * xfns.c: Likewise.
1126 * xterm.c: Likewise.
1127
a54e2c05
DA
11282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1129
1130 Generalize run-time debugging checks.
1131 * dispextern.h (XASSERTS): Remove.
1132 * fontset.c (xassert): Remove.
1133 Convert from xassert to eassert.
1134 * alloc.c: Convert from xassert to eassert.
1135 * bidi.c: Likewise.
1136 * dispnew.c: Likewise.
1137 * fns.c: Likewise.
1138 * fringe.c: Likewise.
1139 * ftfont.c: Likewise.
1140 * gtkutil.c: Likewise.
1141 * image.c: Likewise.
1142 * keyboard.c: Likewise.
1143 * menu.c: Likewise.
1144 * process.c: Likewise.
1145 * scroll.c: Likewise.
1146 * sound.c: Likewise.
1147 * term.c: Likewise.
1148 * w32console.c: Likewise.
1149 * w32fns.c: Likewise.
1150 * w32term.c: Likewise.
1151 * window.c: Likewise.
1152 * xdisp.c: Likewise.
1153 * xfaces.c: Likewise.
1154 * xfns.c: Likewise.
1155 * xselect.c: Likewise.
1156 * xterm.c: Likewise.
1157
1ec4b7b2
SM
11582012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1159
1160 * fns.c (maybe_resize_hash_table): Output message when growing the
1161 purify-hashtable.
1162
2014308a
DA
11632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1164
1165 * alloc.c (allocate_string_data): Remove dead code.
1166 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1167 avoid GCC warning about unused macro.
1168
246155eb
DA
11692012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 * alloc.c (allocate_string): Omit intervals initialization.
1172 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1173 as in make_pure_string and make_pure_c_string.
1174
43184b7b
DA
11752012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1176
d209e2fb 1177 * alloc.c (allocate_string): Fix last change.
43184b7b 1178
3fe6dd74
DA
11792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1180
d209e2fb 1181 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1182 to memset, add explicit initialization where appropriate.
1183
1ba6038a
GM
11842012-06-27 Glenn Morris <rgm@gnu.org>
1185
1186 * lisp.mk (lisp): Remove paths.elc.
1187
c89926a5
CY
11882012-06-27 Chong Yidong <cyd@gnu.org>
1189
1190 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1191
ed6b3510
JW
11922012-06-26 John Wiegley <johnw@newartisans.com>
1193
1ec4b7b2 1194 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1195 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1196
ed6b3510
JW
1197 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1198 when building with Clang.
1199
8edd4a2b
SM
12002012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1201
1202 * eval.c (Fapply): Allow calling it with a single argument.
1203
f6f62d1b
EZ
12042012-06-26 Eli Zaretskii <eliz@gnu.org>
1205
1206 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1207 _stricmp and _strnicmp.
1208 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1209
62efea5e
DA
12102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1213 allocated window.
1214 (allocate_process): Likewise for new process.
8edd4a2b 1215 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1216 (allocate_frame): Likewise.
1217 * frame.c (make_frame): Omit redundant initialization.
1218 * window.c (make_parent_window): Use memset.
1219 (make_window): Omit redundant initialization.
1220 * process.c (make_process): Omit redundant initialization.
1221 * terminal.c (create_terminal): Likewise.
1222
42997f4d
DA
12232012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1224
1225 * term.c (delete_tty): Remove redundant call to memset.
1226
1130ecfc
DA
12272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1228
1229 * alloc.c: Remove build_string.
1230 * lisp.h: Define build_string as static inline. This provides
1231 a better opportunity to optimize away calls to strlen when the
1232 function is called with compile-time constant argument.
1233 * image.c (imagemagick_error): Convert to build_string.
1234 * w32proc.c (sys_spawnve): Likewise.
1235 * xterm.c (x_term_init): Likewise.
1236
cf38a720
PE
12372012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1238
99027bdd
PE
1239 Use sprintf return value instead of invoking strlen on result.
1240 In the old days this wasn't portable, since some sprintf
1241 implementations returned char *. But they died out years ago and
1242 Emacs already assumes sprintf returns int.
1243 Similarly for float_to_string.
1244 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1245 * ccl.c (ccl_driver):
1246 * character.c (string_escape_byte8):
1247 * data.c (Fnumber_to_string):
1248 * doprnt.c (doprnt):
1249 * print.c (print_object):
1250 * xdisp.c (message_dolog):
1251 * xfns.c (syms_of_xfns):
1252 Use sprintf or float_to_string result to avoid need to call strlen.
1253 * data.c (Fnumber_to_string):
1254 Use make_unibyte_string, since the string must be ASCII.
1255 * lisp.h, print.c (float_to_string): Now returns int length.
1256 * term.c (produce_glyphless_glyph):
1257 Use sprintf result rather than recomputing it.
1258
cf38a720
PE
1259 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1260 * Makefile.in (ALL_CFLAGS):
1261 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1262 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1263
3511c784
DA
12642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1265
0a08eb21 1266 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1267 strcasecmp if available.
1268 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1269
fb7da12e
AS
12702012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1271
1272 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1273 Avoid comma operator.
1274 * menu.c (push_submenu_start, push_submenu_end)
1275 (push_left_right_boundary, push_menu_pane): Likewise.
1276 * msdos.c (dos_rawgetc): Likewise.
1277
afa2ffd8
DA
12782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1279
1280 * xfns.c (xic_create_fontsetname): Remove redundant calls
1281 to memset.
1282
b3b4476b
PE
12832012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1284
4495ff38
PE
1285 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1286 sprintf already null-terminates its output.
1287
b3b4476b
PE
1288 * xfns.c (x_window): Remove redundant cast.
1289
b00876c9
DA
12902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1291
1292 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1293 `const char *' to `char *' to avoid compiler warning.
1294
d188e26b
PE
12952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1296
885d1d74
PE
1297 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1298 instead of truncating it to 63 (admittedly a generous limit).
1299
d188e26b
PE
1300 * process.c: Fix spelling and caps in comments.
1301
e2f560b1
DN
13022012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1303
e86db54b 1304 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1305 * sysdep.c (setpgrp): Remove definition, not used in this file.
1306
7583a3a1
JB
13072012-06-24 Juanma Barranquero <lekktu@gmail.com>
1308
1309 * makefile.w32-in: Update dependencies.
1310
696056c2
EZ
13112012-06-24 Eli Zaretskii <eliz@gnu.org>
1312
1313 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1314 (SYSTIME_H): Add nt/inc/sys/time.h.
1315
1316 * systime.h [WINDOWSNT]: Include sys/time.h.
1317
1318 * s/ms-w32.h (struct timespec): Definition moved from
1319 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1320
845ca893
PE
13212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1324 * buffer.h (buffer_slot_type_mismatch):
1325 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1326 * eval.c (unwind_to_catch):
1327 * image.c (my_png_error, my_error_exit):
1328 * keyboard.c (quit_throw_to_read_char, user_error)
1329 (Fexit_recursive_edit, Fabort_recursive_edit):
1330 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1331 (wrong_type_argument, buffer_overflow, __executable_start)
1332 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1333 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1334 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1335 (fatal):
1336 (child_setup) [!DOS_NT]:
1337 * lread.c (end_of_file_error, invalid_syntax):
1338 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1339 * puresize.h (pure_write_error):
1340 * search.c (matcher_overflow):
1341 * sound.c (sound_perror, alsa_sound_perror):
1342 * sysdep.c, syssignal.h (croak):
1343 * term.c (maybe_fatal, vfatal):
1344 * textprop.c (text_read_only):
1345 * undo.c (user_error):
1346 * unexmacosx.c (unexec_error):
1347 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1348 Use _Noreturn rather than NO_RETURN.
1349 No need for separate decl merely because of _Noreturn.
1350 * sound.c (sound_warning, parse_sound):
1351 Remove unnecessary forward decls.
1352
f1dd8073
PE
13532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1356 * lisp.h (WAIT_READING_MAX): New macro.
1357 * dispnew.c (Fsleep_for, sit_for):
1358 * keyboard.c (kbd_buffer_get_event):
1359 * process.c (Faccept_process_output):
1360 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1361 This improves on the previous patch, which introduced a bug
1362 when time_t is unsigned and as wide as intmax_t.
1363 See <http://bugs.gnu.org/9000#51>.
1364
b82c1755
EZ
13652012-06-23 Eli Zaretskii <eliz@gnu.org>
1366
1367 * dispnew.c (sit_for, Fsleep_for):
1368 * keyboard.c (kbd_buffer_get_event):
1369 * process.c (Faccept_process_output): Avoid compiler warnings when
1370 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1371
ca300656
JB
13722012-06-23 Juanma Barranquero <lekktu@gmail.com>
1373
049ec95b
JB
1374 * makefile.w32-in: Update dependencies.
1375
ca300656
JB
1376 * w32.c (ltime): Add return type and declare static.
1377 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1378
db7b8d06
PE
13792012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1382 Privately reported by Herbert J. Skuhra.
1383 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1384 All uses changed.
1385 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1386 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1387
0bd8297f
EZ
13882012-06-23 Eli Zaretskii <eliz@gnu.org>
1389
96512555
EZ
1390 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1391 last argument of make_unibyte_string.
1392
0bd8297f
EZ
1393 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1394 language ID in the event parameters.
1395
1396 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1397 event.code, not the obscure "character set ID".
1398
63def6b6
CY
13992012-06-23 Chong Yidong <cyd@gnu.org>
1400
1401 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1402
e8a02204
EZ
14032012-06-23 Eli Zaretskii <eliz@gnu.org>
1404
388cdec0
EZ
1405 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1406 * w32.c (fdutimens): New function.
1407
1408 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1409
1410 * s/ms-w32.h (pselect): Redirect to sys_select.
1411
1412 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1413
e8a02204
EZ
1414 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1415 in the logic of incrementing and decrementing the value of
1416 use_relocatable_buffers.
1417
d054f3fb
PE
14182012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1421 Privately reported by Herbert J. Skuhra.
1422 [__FreeBSD__]: Remove "*/" typo after "#include".
1423 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1424 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1425 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1426 Don't assume EMACS_TIME and struct timeval are the same type.
1427
d35af63c
PE
14282012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Support higher-resolution time stamps (Bug#9000).
1431 The time stamps are only nanosecond-resolution at the C level,
1432 since that's the best that any real-world system supports now.
1433 But they are picosecond-resolution at the Lisp level, as that's
1434 easy, and leaves room for future OS improvements.
1435
1436 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1437 (LIBES): Use it.
1438
1439 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1440 Don't get current time unless it's needed.
1441
1442 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1443 now provides it if it's absent.
1444 (start_atimer): Port to higher-res time stamps.
1445 Check for time stamp overflow. Don't get current time more
1446 often than is needed.
1447
1448 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1449 Include systime.h, not time.h.
1450 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1451
1452 * dired.c: Include stat-time.h.
1453 (Ffile-attributes): File times now have higher resolution.
1454
1455 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1456 (struct image): Timestamp now has higher resolution.
1457
1458 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1459 has at least microseconds now. All uses removed.
1460 (update_frame, update_single_window, update_window, update_frame_1)
1461 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1462
1463 * editfns.c (time_overflow): Now extern.
1464 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1465 (float-time, Fformat_time_string, Fcurrent_time_string)
1466 (Fcurrent_time_zone): Accept and generate higher-resolution
1467 time stamps.
1468 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1469 (decode_time_components, lisp_seconds_argument): New functions.
1470 (make_time): Now static.
1471 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1472 Report an error if the time is invalid, rather than having the caller
1473 do that.
1474
1475 * fileio.c: Include <stat-time.h>
1476 (Fcopy_file): Copy higher-resolution time stamps.
1477 Prefer to set the time stamp via a file descriptor if that works.
1478 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1479 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1480 (Fvisited_file_modtime, Fset_visited_file_modtime):
1481 Support higher-resolution time stamps.
1482
1483 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1484
1485 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1486
1487 * image.c (prepare_image_for_display, clear_image_cache)
1488 (lookup_image): Port to higer-resolution time stamps.
1489
1490 * keyboard.c (start_polling, bind_polling_period):
1491 Check for time stamp overflow.
1492 (read_char, kbd_buffer_get_event, timer_start_idle)
1493 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1494 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1495 Port to higher-resolution time stamps. Do not assume time_t is signed.
1496 (decode_timer): New function. Timers are now vectors of length 9,
1497 not 8, to accommodate the picosecond component.
1498 (timer_check_2): Use it.
1499
1500 * nsterm.m (select_timeout, timeval_subtract): Remove.
1501 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1502 as they're a bit more accurate and handle overflow better.
1503 (ns_select): Change prototype to be compatible with pselect.
1504 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1505 * nsterm.h (ns_select): Adjust prototype.
1506
1507 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1508 us-resolution time stamps.
1509 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1510
1511 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1512
1513 * lisp.h (time_overflow): New decl.
1514 (wait_reading_process_output): First arg is now intmax_t, not int,
1515 to accommodate larger waits.
1516
1517 * process.h (struct Lisp_Process.read_output_delay):
1518 Now counts nanoseconds, not microseconds.
1519 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1520 EMACS_HAS_USECS.
1521 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1522 (wait_reading_process_output):
1523 Port to ns-resolution time stamps.
1524 (Faccept_process_output, wait_reading_process_output):
1525 Check for time stamp overflow. Do not assume time_t is signed.
1526 (select_wrapper): Remove; we now use pselect.
1527 (Fprocess_attributes): Now generates ns-resolution time stamps.
1528
1529 * sysdep.c: Include utimens.h. Don't include utime.h
1530 or worry about struct utimbuf; gnulib does that for us now.
1531 (gettimeofday): Remove; gnulib provides a substitute.
1532 (make_timeval): New function.
1533 (set_file_times): Now sets ns-resolution time stamps.
1534 New arg FD; all uses changed.
1535 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1536 (system_process_attributes):
1537 Now returns ns-resolution time stamp. All uses changed.
1538 Check for time stamp overflow.
1539
1540 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1541 provides a substitute now.
1542
1543 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1544 since it guarantees struct timespec.
1545 (EMACS_TIME): Now struct timespec, so that we can support
1546 ns-resolution time stamps.
1547 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1548 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1549 (EMACS_USECS): Remove.
1550 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1551 so multiply the arg by 1000 before storing it.
1552 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1553 New macros.
1554 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1555 Port to ns-resolution time stamps.
1556 (EMACS_TIME_NEG_P): Remove; replaced by....
1557 (EMACS_TIME_SIGN): New macro.
1558 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1559 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1560 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1561 (make_timeval, make_lisp_time, decode_time_components): New decls.
1562 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1563 that it mishandled time_t overflow. You can't compare by subtracting!
1564 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1565 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1566
1567 * term.c: Include <sys/time.h>.
1568 (timeval_to_Time): New function, for proper overflow wraparound.
1569 (term_mouse_position, term_mouse_click): Use it.
1570
1571 * undo.c (record_first_change): Support higher-resolution time stamps
1572 in the undo buffer.
1573 (Fprimitive_undo): Use them when restoring time stamps.
1574
1575 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1576 (w32_get_internal_run_time):
1577 Port to higher-resolution Emacs time stamps.
1578 (ltime): Now accepts single 64-bit integer, as that's more convenient
1579 for callers.
1580
1581 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1582
1583 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1584 for compatibility with pselect. Support ns-resolution time stamps.
1585
1586 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1587
1588 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1589 Check for time stamp overflow, and support ns-resolution time stamps.
1590
1591 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1592 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1593 (timeval_subtract): Remove; no longer needed.
1594 (XTflash, XTring_bell, x_wait_for_event):
1595 Port to ns-resolution time stamps. Don't assume time_t is signed.
1596
b6a92dfe
CY
15972012-06-22 Chong Yidong <cyd@gnu.org>
1598
1599 * xdisp.c (x_consider_frame_title): Revert last change.
1600
d251c37c
EZ
16012012-06-22 Eli Zaretskii <eliz@gnu.org>
1602
1603 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1604 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1605 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1606 staticidx goes up to 1597 out of 1600 = 0x640.)
1607
f10deafb
PE
16082012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1609
1610 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1611 Otherwise, the umask might be mistakenly 0 while handling input signals.
1612
ec6de1e2
SM
16132012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1614
1615 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1616
28be1ada
DA
16172012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1618
1619 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1620 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1621 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1622 access to `contents' member of Lisp_Vector objects with AREF and ASET
1623 where appropriate.
1624
c6bf3022
CY
16252012-06-19 Chong Yidong <cyd@gnu.org>
1626
1627 * frame.c (delete_frame): When selecting a frame on a different
1628 text terminal, do not alter the terminal's top-frame.
1629
1630 * xdisp.c (format_mode_line_unwind_data): Record the target
1631 frame's selected window and its terminal's top-frame.
1632 (unwind_format_mode_line): Restore them.
1633 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1634 Callers changed.
1635 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1636 since tty frames can be explicitly named.
1637 (prepare_menu_bars): Likewise.
1638
1639 * term.c (Ftty_top_frame): New function.
1640
defd4196
PE
16412012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 Port byte-code-meter to modern targets.
1644 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1645 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1646 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1647 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1648 (METER_1, METER_2): Simplify.
1649
1053a871
SM
16502012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1651
1652 * data.c (Fdefalias): Return `symbol' (bug#11686).
1653
b7e8d081
MR
16542012-06-18 Martin Rudalics <rudalics@gmx.at>
1655
1656 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1657 gets killed during executing of this function (Bug#11665).
1658 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1659 (Vkill_buffer_query_functions): In doc-string say that functions
1660 run by this hook should not change the current buffer.
1661
7ea2b339
PE
16622012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 Fix recently-introduced process.c problems found by static checking.
1665 * process.c (write_queue_push, write_queue_pop, send_process):
1666 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1667 (write_queue_pop): Fix pointer signedness problem.
1668 (send_process): Remove unused local.
1669
96a313a1
CY
16702012-06-17 Chong Yidong <cyd@gnu.org>
1671
1672 * xdisp.c (redisplay_internal): No need to redisplay terminal
1673 frames that are not on top.
1674
20ca2e94
TN
16752012-06-17 Troels Nielsen <bn.troels@gmail.com>
1676
1677 * process.c (make_process): Initialize write_queue.
1678 (write_queue_push, write_queue_pop): New functions.
1679 (send_process): Use them to maintain correct ordering of process
1680 writes (Bug#10815).
1681
9a900ca9
PE
16822012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1683
310fbfa8
PE
1684 * lisp.h (eassert): Assume C89 or later.
1685 This removes the need for CHECK.
1686 (CHECK): Remove. Its comments about always evaluating its
1687 argument were confusing, as 'eassert' typically does not evaluate
1688 its argument.
1689
27bb1ca4
PE
1690 * coding.c (produce_chars): Use ptrdiff_t, not int.
1691
9a900ca9
PE
1692 * xterm.c (x_draw_underwave): Check for integer overflow.
1693 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1694
41b7f8bc 16952012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1696
1697 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1698 referenced (Bug#11583).
1699
9b0e3eba
AA
17002012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1701
1702 Implement wave-style variant of underlining.
1703 * dispextern.h (face_underline_type): New enum.
1704 (face): Add field for underline type.
1705 * nsterm.m (ns_draw_underwave): New function.
1706 (ns_draw_text_decoration): Use it.
1707 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1708 New functions.
1709 (x_draw_glyph_string): Use them.
1710 * xfaces.c (Qline, Qwave): New Lisp objects.
1711 (check_lface_attrs, merge_face_ref)
1053a871
SM
1712 (Finternal_set_lisp_face_attribute, realize_x_face):
1713 Handle wave-style underline face attributes.
9b0e3eba
AA
1714 * xterm.c (x_draw_underwave): New function.
1715 (x_draw_glyph_string): Use it.
1716
0fb52f11
JB
17172012-06-16 Juanma Barranquero <lekktu@gmail.com>
1718
1719 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1720 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1721 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1722 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1723 ($(BLD)/w32select.$(O)): Update dependencies.
1724
e5560ff7
AS
17252012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1726
1727 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1728 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1729 * character.c (_fetch_multibyte_char_p): Remove.
1730 * alloc.c: Include "character.h" before "buffer.h".
1731 * bidi.c: Likewise.
1732 * buffer.c: Likewise.
1733 * bytecode.c: Likewise.
1734 * callint.c: Likewise.
1735 * callproc.c: Likewise.
1736 * casefiddle.c: Likewise.
1737 * casetab.c: Likewise.
1738 * category.c: Likewise.
1739 * cmds.c: Likewise.
1740 * coding.c: Likewise.
1741 * composite.c: Likewise.
1742 * dired.c: Likewise.
1743 * dispnew.c: Likewise.
1744 * doc.c: Likewise.
1745 * dosfns.c: Likewise.
1746 * editfns.c: Likewise.
1747 * emacs.c: Likewise.
1748 * fileio.c: Likewise.
1749 * filelock.c: Likewise.
1750 * font.c: Likewise.
1751 * fontset.c: Likewise.
1752 * fringe.c: Likewise.
1753 * indent.c: Likewise.
1754 * insdel.c: Likewise.
1755 * intervals.c: Likewise.
1756 * keyboard.c: Likewise.
1757 * keymap.c: Likewise.
1758 * lread.c: Likewise.
1759 * macros.c: Likewise.
1760 * marker.c: Likewise.
1761 * minibuf.c: Likewise.
1762 * nsfns.m: Likewise.
1763 * nsmenu.m: Likewise.
1764 * print.c: Likewise.
1765 * process.c: Likewise.
1766 * regex.c: Likewise.
1767 * region-cache.c: Likewise.
1768 * search.c: Likewise.
1769 * syntax.c: Likewise.
1770 * term.c: Likewise.
1771 * textprop.c: Likewise.
1772 * undo.c: Likewise.
1773 * unexsol.c: Likewise.
1774 * w16select.c: Likewise.
1775 * w32fns.c: Likewise.
1776 * w32menu.c: Likewise.
1777 * window.c: Likewise.
1778 * xdisp.c: Likewise.
1779 * xfns.c: Likewise.
1780 * xmenu.c: Likewise.
1781 * xml.c: Likewise.
1782 * xselect.c: Likewise.
1783
2f07e6af
EZ
17842012-06-16 Eli Zaretskii <eliz@gnu.org>
1785
1053a871
SM
1786 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1787 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1788 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1789 row.
1790 (handle_face_prop): Use chunk-relative overlay string index when
1791 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1792 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1793 the rightmost. (Bug#11720)
2f07e6af 1794
29b83cec
AS
17952012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1796
1797 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1798 (CATEGORY_MEMBER): Enforce 1/0 value.
1799 * category.c (_temp_category_set): Remove.
1800
4c5501e9
EZ
18012012-06-16 Eli Zaretskii <eliz@gnu.org>
1802
1803 * window.c (Fdelete_other_windows_internal)
1804 (Fdelete_window_internal): Don't access frame's mouse highlight
1805 info of the initial frame. (Bug#11677)
1806
2b570124
PE
18072012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1808
e93864f9
PE
1809 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1810 Assume USE_2_TAGS_FOR_INTS.
1811 (xreload): Adjust $tagmask width to match recent lisp.h change.
1812
2b570124
PE
1813 Simplify lisp.h in minor ways that should not affect code.
1814 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1815 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1816 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1817 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1818 (INTTYPEBITS): New macro, for clarity.
1819 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1820 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1821 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1822 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1823 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1824
81755f69
JB
18252012-06-13 Juanma Barranquero <lekktu@gmail.com>
1826
1827 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1828
16192a57
GM
18292012-06-13 Glenn Morris <rgm@gnu.org>
1830
1831 * s/bsd-common.h (BSD4_3):
1832 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1833
646b5f55
AS
18342012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1835
1836 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1837 instead of union.
1838 (XLI, XIL): Define.
1053a871
SM
1839 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1840 Use them.
1841 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1842 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1843 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1844 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1845 * frame.c (delete_frame): Remove outdated comment.
1846 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1847 USE_LISP_UNION_TYPE.
1848 (Fw32_unregister_hot_key): Likewise.
1849 (Fw32_toggle_lock_key): Likewise.
1850 * w32menu.c (add_menu_item): Likewise.
1851 (w32_menu_display_help): Use XIL instead of checking
1852 USE_LISP_UNION_TYPE.
1853 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1854 (init_heap): Likewise.
1855 * w32term.c (w32_read_socket): Update comment.
1856
1d3823c9
GM
18572012-06-13 Glenn Morris <rgm@gnu.org>
1858
c62ff706
GM
1859 * s/usg5-4-common.h, src/s/unixware.h:
1860 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1861
1d3823c9
GM
1862 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1863
bfe3e0a2
PE
18642012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1867 * alloc.c (make_number) [!defined make_number]:
1868 Remove, as lisp.h always defines this now.
1869 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1870 (roundup_size): Verify that it is a power of 2.
1871 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1872 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1873 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1874 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1875 USE_LSB_TAG now is always defined to be either 0 or 1.
1876 All uses changed.
1877 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1878 code works fine either way, and efficiency is not a concern here,
1879 as the union type is for debugging, not for production.
1880 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1881 Use an inline function on all platforms when using the union type,
1882 since this is simpler and 'static inline' can be used portably
1883 within Emacs now.
1884 (LISP_INITIALLY_ZERO): New macro.
1885 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1886 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1887
45fa9c0f
GM
18882012-06-12 Glenn Morris <rgm@gnu.org>
1889
b4492cba
GM
1890 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1891
1892 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1893
45fa9c0f
GM
1894 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1895 Move BROKEN_SIGIO to configure.
1896
1897 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1898 Move NO_TERMIO to configure.
1899
0e25d334
CY
19002012-06-12 Chong Yidong <cyd@gnu.org>
1901
1902 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1903 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1904 MagickExportImagePixels is undefined.
1905
43682bb6
PE
19062012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * image.c (imagemagick_load_image): Remove unused label.
1909
a9be7d2b
GM
19102012-06-11 Glenn Morris <rgm@gnu.org>
1911
1912 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1913 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1914 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1915 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1916
3017f87f
SM
19172012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1918
1919 * alloc.c (make_byte_code): New function.
1920 (Fmake_byte_code): Use it. Don't purify here.
1921 * lread.c (read1): Use it as well to avoid extra allocation.
1922
1b9b4cf4
CY
19232012-06-11 Chong Yidong <cyd@gnu.org>
1924
1925 * image.c (imagemagick_load_image): Implement transparency.
1926
95988fcf
AS
19272012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1928
1929 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1930 account for preceding backslashes. (Bug#11663)
1931
cd4eb164
CY
19322012-06-09 Chong Yidong <cyd@gnu.org>
1933
1934 * term.c: Support italics in capable terminals (Bug#9652).
1935 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1936 (turn_on_face): Output using TS_enter_italic_mode if available.
1937 Don't handle unused blinking and alt-charset cases.
1938 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1939 and tty_alt_charset_p cases.
1940 (tty_capable_p, init_tty): Support italics.
1941
1942 * termchar.h (struct tty_display_info): Add field for italics.
1943 Remove unused blink field.
1944
1945 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1946 Handle slant.
1947
1948 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1949 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1950 tty_alt_charset_p. Add tty_italic_p.
1951
ff88beb8
MA
19522012-06-09 Michael Albinus <michael.albinus@gmx.de>
1953
1954 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1955 dbus_type_is_basic if available.
1956 (xd_extract_signed, xd_extract_unsigned): Rename from
1957 extract_signed and extract_unsigned, respectively. Adapt callers.
1958
44286096
CY
19592012-06-09 Chong Yidong <cyd@gnu.org>
1960
1682701f
CY
1961 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1962
44286096
CY
1963 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1964 case (Bug#9752).
1965
d86feb17
PE
19662012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 * xdisp.c (vmessage): Treat frame message as multibyte.
1969 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1970 would generate the diagnostic "Making \302\247 buffer-local while
1971 let-bound!".
1972
d5c20fe8
EZ
19732012-06-08 Eli Zaretskii <eliz@gnu.org>
1974
1975 * dispnew.c (showing_window_margins_p): Undo last change, which
1976 was done due to an inadvertent commit.
1977 (adjust_frame_glyphs_for_frame_redisplay): Do call
1978 showing_window_margins_p.
1979
513749ee
SM
19802012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1981
1982 * eval.c (Fmake_var_non_special): New primitive.
1983 (syms_of_eval): Defsubr it.
1984 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1985
d4a8f5c1
JB
19862012-06-08 Juanma Barranquero <lekktu@gmail.com>
1987
1988 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1989 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1990
8bbbc977
EZ
19912012-06-08 Eli Zaretskii <eliz@gnu.org>
1992
1993 * alloc.c (allocate_vectorlike): Fix last change.
1994
f3372c87
DA
19952012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 Block-based vector allocation of small vectors.
1998 * lisp.h (struct vectorlike_header): New field `nbytes',
1999 adjust comment accordingly.
2000 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2001 to denote vector blocks. Adjust users (live_vector_p,
2002 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2003 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2004 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2005 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2006 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2007 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2008 (roundup_size): New constant.
2009 (struct vector_block): New data type.
2010 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2011 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2012 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2013 (sweep_vectors): New functions.
2014 (allocate_vectorlike): Return `zero_vector' as the only vector of
2015 0 items. Allocate new vector from block if vector size is less than
2016 or equal to VBLOCK_BYTES_MAX.
2017 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2018 (init_alloc_once): Add call to init_vectors.
2019
4f18a4ed
SM
20202012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2021
2022 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2023
86f158bc
PE
20242012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * doprnt.c (doprnt): Truncate multibyte char correctly.
2027 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2028 would mishandle a string argument "Xc" if X was a multibyte
2029 character of length 2: it would truncate after X's first byte
2030 rather than including all of X.
2031
c5cfcbe0
CY
20322012-06-06 Chong Yidong <cyd@gnu.org>
2033
2034 * buffer.c (word_wrap): Doc fix.
2035
c05cf390
PE
20362012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2039
0c3461de
GM
20402012-06-03 Glenn Morris <rgm@gnu.org>
2041
2042 * xdisp.c (tool-bar-style): Doc fix.
2043
c71232db
UM
20442012-06-03 Ulrich Müller <ulm@gentoo.org>
2045
2046 * Makefile.in (PAXCTL): Define.
2047 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2048 binary via PaX flags if the paxctl utility is available.
2049 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2050 Restore PaX flags to their default. (Bug#11398)
2051
383f7350
CY
20522012-06-03 Chong Yidong <cyd@gnu.org>
2053
2054 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2055 buffer (Bug#11226).
2056
5f2c76c6
CY
20572012-06-03 Chong Yidong <cyd@gnu.org>
2058
2059 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2060 (note_mode_line_or_margin_highlight): If there is no help echo,
2061 use mode-line-default-help-echo. Handle the case where the mouse
2062 position is past the end of the mode line string.
2063
2064 * buffer.c (buffer_local_value_1): New function, split from
2065 Fbuffer_local_value; can return Qunbound.
2066 (Fbuffer_local_value): Use it.
2067 (Vmode_line_format): Docstring tweaks.
2068
773d47f6
PE
20692012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 * sysdep.c (system_process_attributes): Improve comment.
2072
f2d6a3df
SM
20732012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2074
2075 * keyboard.c: Export real-this-command to Elisp.
2076 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2077 and DEFVAR it. Update all users.
2078
63810350
PE
20792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2080
7bd5c1f4
PE
2081 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2082
63810350
PE
2083 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2084 Convert pctcpu and pctmem to Lisp float properly.
2085 Let the compiler fold better, as 100.0/0x8000 is exact.
2086
a2821611
AS
20872012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2088
2089 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2090 cons_block.
2091
5fceba1d
PE
20922012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2095
c98ff5dd
DA
20962012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2097
2098 For a 'struct window', replace some Lisp_Object fields to
2099 bitfields where appropriate, remove unused fields.
2100 * window.h (struct window): Remove unused 'last_mark_x' and
2101 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2102 change it's type from Lisp_Object to bitfield.
2103 Change type of 'force_start', 'optional_new_start',
2104 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2105 fields from Lisp_Object to bitfield. Adjust users accordingly.
2106
ca34e0be
PE
21072012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 Pacify gcc -Wdouble-precision when using Xaw.
2110 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2111 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2112 Use 'float' consistently, rather than 'float' in most places
2113 and 'double' in a couple of places.
2114
efc00ab1 21152012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2116
2117 * xdisp.c (handle_stop): Detect whether we have overlay strings
2118 loaded by testing it->current.overlay_string_index to be
2119 non-negative, instead of checking whether n_overlay_strings is
2120 positive. (Bug#11587)
2121
efc00ab1 21222012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2123
2124 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2125
2126 * doc.c (Fsubstitute_command_keys): Doc fix.
2127
efc00ab1 21282012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2129
2130 * search.c (search_buffer): Remove calls to
2131 r_alloc_inhibit_buffer_relocation, as it is now called by
2132 maybe_unify_char, which was the cause of relocation of buffer text
2133 in bug#11519.
2134
efc00ab1 21352012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2136
2137 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2138 for the duration of call to load_charset, to avoid problems with
2139 callers of maybe_unify_char that access buffer text through C
2140 pointers.
2141
2142 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2143 decrement the inhibition flag, instead of just setting or
2144 resetting it.
2145
ba93a187
PE
21462012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 Remove obsolete '#define static' cruft.
2149 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2150 This #undef was "temporary" in 2000; it is no longer needed
2151 now that '#define static' has gone away.
2152 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2153 (gray_bitmap_bits): Remove; no longer needed.
2154 All uses replaced with definiens.
2155 * xterm.c: Include "bitmaps/gray.xbm".
2156
9e4bf381
PE
21572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 Clean up __executable_start, monstartup when --enable-profiling.
2160 The following changes affect the code only when profiling.
2161 * dispnew.c (__executable_start): Rename from safe_bcopy.
2162 Define only on platforms that need it.
2163 * emacs.c: Include <sys/gmon.h> when profiling.
2164 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2165 (__executable_start): Remove decl, since lisp.h does it now.
2166 (safe_bcopy): Remove decl; no longer has that name.
2167 (main): Coalesce #if into single bit of code, for simplicity.
2168 Cast pointers to uintptr_t, since standard libraries want integers
2169 and not pointers.
2170 * lisp.h (__executable_start): New decl.
2171
32d72c2f
GM
21722012-05-31 Glenn Morris <rgm@gnu.org>
2173
2174 * image.c (Fimagemagick_types): Doc fix.
2175
baac5bc7
JM
21762012-05-30 Jim Meyering <meyering@redhat.com>
2177
2178 * callproc.c (Fcall_process_region): Include directory component
2179 in mkstemp error message (Bug#11586).
2180
72cb32cf
PE
21812012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 * alloc.c, lisp.h (make_pure_vector): Now static.
2184
61b108cc
SM
21852012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2186
2187 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2188 Move to byte-run.el.
2189 (Fautoload): Do the hash-doc more carefully.
2190 * data.c (Fdefalias): Purify definition, except for keymaps.
2191 (Qdefun): Move from eval.c.
2192 * lisp.h (Qdefun): Remove.
2193 * lread.c (read1): Tiny simplification.
2194
471fe23d
TN
21952012-05-29 Troels Nielsen <bn.troels@gmail.com>
2196
934f3f58 2197 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2198 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2199 Bug#9642, but explicitly check that the buffer the overlay would
2200 be moved to is live and rearrange lines to make sure that errors
2201 will not put the overlay in an inconsistent state.
2202 (Fdelete_overlay): Cosmetics.
2203
85d0efd1
EZ
22042012-05-28 Eli Zaretskii <eliz@gnu.org>
2205
2206 * w32term.c (my_bring_window_to_top): New function.
2207 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2208 could be different from the original one.
2209 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2210 (Bug#11513)
2211
2212 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2213 by calling BringWindowToTop.
2214
2215 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2216 (WM_EMACS_END): Increase by one.
2217
da92a98c
PE
22182012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2221 This avoids undefined behavior that might cause the eassert
2222 to not catch an out-of-range value.
2223
74d1f848
JB
22242012-05-28 Juanma Barranquero <lekktu@gmail.com>
2225
2226 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2227 Update dependencies.
2228
9e1a06fc
EZ
22292012-05-27 Eli Zaretskii <eliz@gnu.org>
2230
2231 * bidi.c (bidi_mirror_char): Fix last change.
2232
f3dd7312
AS
22332012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2236 when referring to sectname field in printf format.
2237
81899c91
PE
22382012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2239
57b81a9f
PE
2240 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2241 Only r_alloc_inhibit_buffer_relocation needed to be added;
2242 the others were already declared.
2243
81899c91
PE
2244 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2245 before checking whether it's out of range. Put the check inside
2246 eassert. See
2247 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2248
33017faf 22492012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2250
2251 * callproc.c (Fcall_process): Restore a line that was accidentally
2252 commented out in the 2011-02-13 change (bug#11547).
2253
33017faf 22542012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2255
2256 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2257 defined on ralloc.c.
2258
2259 * buffer.c [REL_ALLOC]: Remove prototypes of
2260 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2261 they are now on lisp.h.
2262
2263 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2264
2265 * search.c (search_buffer): Use it to inhibit relocation of buffer
2266 text while re_search_2 is doing its job, because re_search_2 is
2267 passed C pointers to buffer text. (Bug#11519)
2268
23415acf
EZ
2269 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2270 Update value to 24.
2271
44e27368
EZ
2272 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2273 state after an additional call to move_it_in_display_line_to, keep
2274 the values of it->max_ascent and it->max_descent found for the
2275 entire line.
2276 (pos_visible_p): Revert the comparison against bottom_y to what it
2277 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2278 (Bug#11464)
2279
c1892f11
PE
22802012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 Fix coding-related core dumps with gcc -ftrapv.
2283 The code was computing A - B, where A and B are pointers, and B is
2284 random garbage. This can lead to core dumps on platforms that
2285 have special pointer registers, and it also leads to core dumps on
2286 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2287 A - B only when B is initialized properly.
2288 * coding.c (coding_set_source, coding_set_destination): Return void.
2289 (coding_change_source, coding_change_destinations): New functions,
2290 with the old behaviors of coding_set_source and coding_set_destination.
2291 All callers that need an offset changed to use these new functions.
2292
eb7afdad
GM
22932012-05-26 Glenn Morris <rgm@gnu.org>
2294
2295 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2296
f12fdf02
EZ
22972012-05-26 Eli Zaretskii <eliz@gnu.org>
2298
53a63be6 2299 Extend mouse support on W32 text-mode console.
61b108cc
SM
2300 * xdisp.c (draw_row_with_mouse_face):
2301 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2302
eb3f6f01 2303 * w32console.c: Include window.h.
61b108cc
SM
2304 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2305 New functions.
eb3f6f01
EZ
2306 (initialize_w32_display): Initialize mouse-highlight data.
2307
53a63be6
EZ
2308 * w32inevt.c: Include termchar.h and window.h.
2309 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2310 moves, call note_mouse_highlight. If help_echo changed, call
2311 gen_help_event to produce help-echo message in the echo area.
2312 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2313 highlight info.
2314
4cfd81f6
PE
23152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 * lread.c (read1): Simplify slightly to avoid an overflow warning
2318 with GCC 4.7.0 on x86-64.
2319
4446092a
EZ
23202012-05-26 Eli Zaretskii <eliz@gnu.org>
2321
2322 * bidi.c (bidi_mirror_char): Revert last change: an int is
2323 definitely wide enough here.
2324
42b2a986 23252012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2326
42b2a986 2327 Fix integer width and related bugs (Bug#9874).
eb106a49 2328 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2329 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2330 (string_bytes, check_sblock, allocate_string_data):
2331 (compact_small_strings, Fmake_bool_vector, make_string)
2332 (make_unibyte_string, make_multibyte_string)
2333 (make_string_from_bytes, make_specified_string)
2334 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2335 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2336 (mark_vectorlike):
2337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2338 (allocate_pseudovector):
2339 Use int, not EMACS_INT, where int is wide enough.
2340 (inhibit_garbage_collection, Fgarbage_collect):
2341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2342 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2343 int might not be wide enough.
2344 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2345 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2346 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2347 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2348 (bidi_level_of_next_char, bidi_move_to_visually_next):
2349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2350 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2351 (Fkill_buffer, Fset_buffer_major_mode)
2352 (advance_to_char_boundary, Fbuffer_swap_text)
2353 (Fset_buffer_multibyte, overlays_at, overlays_in)
2354 (overlay_touches_p, struct sortvec, record_overlay_string)
2355 (overlay_strings, recenter_overlay_lists)
2356 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2357 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2358 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2359 (Foverlay_recenter, last_overlay_modification_hooks_used)
2360 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2362 (validate_region): Omit unnecessary test for b <= e,
2363 since that's guaranteed by the previous test.
d311d28c
PE
2364 (adjust_overlays_for_delete): Avoid pos + length overflow.
2365 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2366 (report_overlay_modification):
2367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2368 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2369 Omit pointer cast, which isn't needed anyway, and doesn't work
2370 after the EMACS_INT -> ptrdiff_t change.
02481186 2371 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2372 * buffer.h: Adjust decls to match defn changes elsewhere.
2373 (struct buffer_text, struct buffer):
2374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2375 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2376 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2377 not int, to avoid needless 32-bit limit on 64-bit hosts.
2378 (exec_byte_code): Use tighter memory-full test, one that checks
2379 for alloca overflow. Don't compute the address of the object just
2380 before an array, as that's not portable. Use EMACS_INT, not
2381 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2382 * callint.c (Fcall_interactively):
2383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2384 * callproc.c (call_process_kill, Fcall_process):
2385 Don't assume pid_t fits into an Emacs fixnum.
2386 (call_process_cleanup, Fcall_process, child_setup):
2387 Don't assume pid_t fits into int.
2388 (call_process_cleanup, Fcall_process, delete_temp_file)
2389 (Fcall_process_region):
2390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2391 (Fcall_process): Simplify handling of volatile integers.
2392 Use int, not EMACS_INT, where int will do.
2393 * casefiddle.c (casify_object, casify_region, operate_on_word)
2394 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2396 (casify_object): Avoid integer overflow when overallocating buffer.
2397 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2398 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2399 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2400 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2401 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2402 integers are now checked earlier. All uses replaced with XINT.
2403 (ccl_driver):
2404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2405 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2406 (ccl_driver, Fregister_code_conversion_map):
2407 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2408 (resolve_symbol_ccl_program): Check that vector header is in range.
2409 Always copy the vector, so that we can check its contents reliably
2410 now rather than having to recheck each instruction as it's being
2411 executed. Check that vector words fit in 'int'.
2412 (ccl_get_compiled_code, Fregister_ccl_program)
2413 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2414 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2415 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2416 contents are in range.
2417 (Fccl_execute_on_string): Check that status is in range.
2418 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2419 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2420 Accept and return EMACS_INT, not int, because callers can pass values
2421 out of 'int' range.
2422 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2423 (multibyte_chars_in_text, parse_str_as_multibyte)
2424 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2425 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2426 (string_escape_byte8, Fget_byte):
2427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2428 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2429 avoid mishandling large integers.
2430 * character.h: Adjust decls to match defn changes elsewhere.
2431 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2432 (Ffind_charset_region):
2433 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2434 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2435 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2436 Don't assume fixnum fits in int.
d311d28c
PE
2437 (load_charset_map_from_vector, Fmap_charset_chars):
2438 Remove now-unnecessary CHECK_NATNUMs.
2439 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2440 Don't rely on undefined behavior with signed left shift overflow.
2441 Don't assume unsigned int fits into fixnum, or that fixnum fits
2442 into unsigned int. Don't require max_code to be a valid fixnum;
2443 that's not true for gb10830 4-byte on a 32-bit host. Allow
2444 invalid_code to be a cons, for the same reason. Require code_offset
2445 to be a character. Avoid int overflow if max_char is close
2446 to INT_MAX.
2447 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2448 this is intended anyway and avoids some undefined behavior.
2449 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2450 INDEX_TO_CODE_POINT, as that's what it expects.
2451 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2452 * charset.h (DECODE_CHAR): Return int, not unsigned;
2453 this is what was intended anyway, and it avoids undefined behavior.
2454 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2455 integer-overflow issues.
2456 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2457 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2458 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2459 * chartab.c (Fmake_char_table, Fset_char_table_range)
2460 (uniprop_get_decoder, uniprop_get_encoder):
2461 Don't assume fixnum fits in int.
2462 * cmds.c (move_point): New function, that does the gist of
2463 Fforward_char and Fbackward_char, but does so while checking
2464 for integer overflow more accurately.
c96e5d6a 2465 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2466 (Fforward_line, Fend_of_line, internal_self_insert)
2467 (internal_self_insert):
2468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2469 Fix a FIXME, by checking for integer overflow when calculating
2470 target_clm and actual_clm.
2471 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2472 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2473 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2474 (coding_alloc_by_making_gap, alloc_destination)
2475 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2476 (encode_coding_utf_16, detect_coding_emacs_mule)
2477 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2478 (detect_coding_iso_2022, decode_coding_iso_2022)
2479 (encode_invocation_designation, encode_designation_at_bol)
2480 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2481 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2482 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2483 (encode_coding_ccl, encode_coding_raw_text)
2484 (detect_coding_charset, decode_coding_charset)
2485 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2486 (produce_composition, produce_charset, produce_annotation)
2487 (decode_coding, handle_composition_annotation)
2488 (handle_charset_annotation, consume_chars, decode_coding_gap)
2489 (decode_coding_object, encode_coding_object, detect_coding_system)
2490 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2491 (code_convert_region, code_convert_string)
8f50130c
PE
2492 (Fdefine_coding_system_internal)
2493 (coding_set_source, coding_set_destination):
d311d28c
PE
2494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2495 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2496 (Fdefine_coding_system_internal):
2497 Don't assume fixnums fit in int.
2498 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2499 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2500 (Funencodable_char_position, Fcheck_coding_systems_region)
2501 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2503 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2504 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2505 Don't access memory outside of the args array.
d311d28c 2506 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2507 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2508 result of ENCODE_CHAR.
d311d28c
PE
2509 * coding.h: Adjust decls to match defn changes elsewhere.
2510 (struct coding_system):
2511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2512 * composite.c (get_composition_id, find_composition)
2513 (run_composition_function, update_compositions)
2514 (compose_text, composition_gstring_put_cache)
2515 (composition_gstring_p, composition_gstring_width)
2516 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2517 (composition_compute_stop_pos, composition_reseat_it)
2518 (composition_update_it, struct position_record)
2519 (find_automatic_composition, composition_adjust_point)
2520 (Fcomposition_get_gstring, Ffind_composition_internal):
2521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2522 (update_compositions):
2523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2524 * composite.h: Adjust decls to match defn changes elsewhere.
2525 (struct composition):
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2528 Do not attempt to compute the address of the object just before a
2529 buffer; this is not portable.
2530 (Faref, Faset):
2531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2532 (Faset): Use int, not EMACS_INT, where int is wide enough.
2533 (Fstring_to_number): Don't assume fixnums fit in int.
2534 (Frem): Don't assume arg is nonnegative.
2535 * dbusbind.c (xd_append_arg): Check for integers out of range.
2536 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2537 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2538 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2539 (xd_get_connection_references): Return ptrdiff_t, not int.
2540 All uses changed.
2541 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2542 (xd_read_message_1):
2543 Use int, not unsigned, where the dbus API uses int.
2544 (Fdbus_message_internal): Don't overflow mtype.
2545 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2546 * dired.c (directory_files_internal, file_name_completion, scmp)
2547 (file_name_completion_stat):
2548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2549 (file_name_completion): Don't overflow matchcount.
2550 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2551 * dispextern.h: Adjust decls to match defn changes elsewhere.
2552 (struct text_pos, struct glyph, struct bidi_saved_info)
2553 (struct bidi_string_data, struct bidi_it, struct composition_it)
2554 (struct it):
2555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2556 (struct display_pos, struct composition_it, struct it):
2557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2558 * dispnew.c (increment_matrix_positions)
2559 (increment_row_positions, mode_line_string)
2560 (marginal_area_string):
2561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2562 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2564 (duration_to_sec_usec): New function, to check for overflow better.
2565 (Fsleep_for, sit_for): Use it.
2566 * doc.c (get_doc_string, store_function_docstring):
2567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2568 (get_doc_string, Fsnarf_documentation):
2569 Use int, not EMACS_INT, where int is wide enough.
2570 (get_doc_string):
2571 Use SAFE_ALLOCA, not alloca.
2572 Check for overflow when converting EMACS_INT to off_t.
2573 * doprnt.c (doprnt):
2574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2575 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2576 Don't assume uid_t fits into fixnum.
2577 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2578 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2579 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2580 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2581 (general_insert_function)
2582 (Finsert_char, make_buffer_string, make_buffer_string_both)
2583 (update_buffer_properties, Fbuffer_substring)
2584 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2585 (Fsubst_char_in_region, check_translation)
2586 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2587 (transpose_markers, Ftranspose_regions):
2588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2589 (clip_to_bounds): Move to lisp.h as an inline function).
2590 (Fconstrain_to_field): Don't assume integers are nonnegative.
2591 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2592 (Fsubst_char_in_region, Fsave_restriction):
2593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2594 (Femacs_pid): Don't assume pid_t fits into fixnum.
2595 (lo_time): Use int, not EMACS_INT, when int suffices.
2596 (lisp_time_argument): Check for usec out of range.
2597 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2598 (Fuser_login_name, Fuser_full_name): Signal an error
2599 if a uid argument is out of range, rather than relying on
2600 undefined behavior.
c8d5c857
PE
2601 (Fformat_time_string): Remove now-unnecessary check.
2602 lisp_time_argument checks for out-of-range usec now.
243e0530 2603 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2604 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2605 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2606 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2607 (init_cmdargs, Fdump_emacs):
2608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2609 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2610 the bottom (typically) 32 bits of the fixnum.
2611 * eval.c (specpdl_size, call_debugger):
2612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2613 (when_entered_debugger, Fbacktrace_debug):
2614 Don't assume fixnum can fit in int.
2615 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2616 the object just before a buffer; this is not portable.
2617 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2618 (grow_specpdl, unbind_to):
2619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2620 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2621 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2622 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2623 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2624 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2626 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2627 (a_write, e_write):
2628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2629 (Fcopy_file, non_regular_nbytes, read_non_regular)
2630 (Finsert_file_contents):
2631 Use int, not EMACS_INT, where int is wide enough.
2632 (READ_BUF_SIZE): Verify that it fits in int.
2633 (Finsert_file_contents): Check that counts are in proper range,
2634 rather than assuming fixnums fit into ptrdiff_t etc.
2635 Don't assume fixnums fit into int.
125b3835 2636 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2637 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2638 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2639 (string_char_to_byte, string_byte_to_char)
2640 (string_make_multibyte, string_to_multibyte)
2641 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2642 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2643 (substring_both, Fdelete, internal_equal, Ffillarray)
2644 (Fclear_string, mapcar1)
2645 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2646 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2647 (larger_vector, make_hash_table, maybe_resize_hash_table)
2648 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2649 (Fmaphash, secure_hash):
2650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2651 (concat): Check for string index and length overflow.
2652 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2653 (Frequire):
2654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2655 (larger_vector): New API (vec, incr_min, size_max) replaces old
2656 one (vec, new_size, init). This catches size overflow.
2657 INIT was removed because it was always Qnil.
2658 All callers changed.
2659 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2660 the upper bound on a hash table index size.
2661 (make_hash_table, maybe_resize_hash_table): Use it.
2662 (secure_hash): Computer start_byte and end_byte only after
2663 they're known to be in ptrdiff_t range.
2664 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2665 (Ffont_get_glyphs, Ffont_at):
2666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2667 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2668 (Flist_fonts, Fopen_font):
2669 Don't assume fixnum can fit in int.
2670 (check_gstring): Don't assume index can fit in int.
2671 (font_match_p): Check that fixnum is a character, not a nonnegative
2672 fixnum, since the later code needs to stuff it into an int.
2673 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2674 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2675 conversion overflow issues.
2676 (Fopen_font): Check for integer out of range.
2677 (Ffont_get_glyphs): Don't assume index can fit in int.
2678 * font.h: Adjust decls to match defn changes elsewhere.
2679 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2680 integer overflow.
2681 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2682 printmax_t, where ptrdiff_t is wide enough.
2683 (Finternal_char_font):
2684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2685 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2686 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2687 (Fset_frame_position, x_set_frame_parameters)
2688 (x_set_line_spacing, x_set_border_width)
2689 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2690 Check that fixnums are in proper range for system types.
2691 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2693 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2694 Use SAFE_ALLOCA_LISP, not alloca.
2695 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2696 intptr_t is wide enough.
2697 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2698 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2699 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2700 Check for fixnum out of range.
2701 * ftfont.c (ftfont_list): Don't assume index fits in int.
2702 Check that fixnums are in proper range for system types.
2703 (ftfont_shape_by_flt):
2704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2705 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2708 Check that fixnums are in proper range for system types.
2709 * gnutls.h: Adjust decls to match defn changes elsewhere.
2710 * gtkutil.c (xg_dialog_run):
2711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2712 (update_frame_tool_bar):
2713 Check that fixnums are in proper range for system types.
2714 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2715 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2716 * indent.c (last_known_column, last_known_column_point):
2717 (current_column_bol_cache):
2718 (skip_invisible, current_column, check_display_width):
2719 (check_display_width, scan_for_column, current_column_1)
2720 (Findent_to, Fcurrent_indentation, position_indentation)
2721 (indented_beyond_p, Fmove_to_column, compute_motion):
2722 (Fcompute_motion, Fvertical_motion):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 (last_known_column_modified): Use EMACS_INT, not int.
2725 (check_display_width):
2726 (Fcompute_motion):
2727 Check that fixnums and floats are in proper range for system types.
2728 (compute_motion): Don't assume index or fixnum fits in int.
2729 (compute_motion, Fcompute_motion):
2730 Use int, not EMACS_INT, when it is wide enough.
2731 (vmotion): Omit local var start_hpos that is always 0; that way
2732 we don't need to worry about overflow in expressions involving it.
2733 * indent.h: Adjust decls to match defn changes elsewhere.
2734 (struct position):
2735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2736 Use int, not EMACS_INT, where int is wide enough.
2737 Remove unused members ovstring_chars_done and tab_offset;
2738 all uses removed.
2739 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2740 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2741 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2742 (make_gap, copy_text, insert, insert_and_inherit)
2743 (insert_before_markers, insert_before_markers_and_inherit)
2744 (insert_1, count_combining_before, count_combining_after)
2745 (insert_1_both, insert_from_string)
2746 (insert_from_string_before_markers, insert_from_string_1)
2747 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2748 (adjust_after_replace, adjust_after_insert, replace_range)
2749 (replace_range_2, del_range, del_range_1, del_range_byte)
2750 (del_range_both, del_range_2, modify_region)
2751 (prepare_to_modify_buffer, signal_before_change)
2752 (signal_after_change, Fcombine_after_change_execute):
2753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2754 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2755 (balance_an_interval, split_interval_right, split_interval_left)
2756 (find_interval, next_interval, update_interval)
2757 (adjust_intervals_for_insertion, delete_node, delete_interval)
2758 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2759 (static_offset_intervals, offset_intervals)
2760 (merge_interval_right, merge_interval_left, make_new_interval)
2761 (graft_intervals_into_buffer, temp_set_point_both)
2762 (temp_set_point, set_point, adjust_for_invis_intang)
2763 (set_point_both, move_if_not_intangible, get_property_and_range)
2764 (get_local_map, copy_intervals, copy_intervals_to_string)
2765 (compare_string_intervals, set_intervals_multibyte_1):
2766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2767 * intervals.h: Adjust decls to match defn changes elsewhere.
2768 (struct interval):
2769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2770 * keyboard.c (this_command_key_count, this_single_command_key_start)
2771 (before_command_key_count, before_command_echo_length, echo_now)
2772 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2773 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2774 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2775 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2777 (last_non_minibuf_size, last_point_position, echo_truncate)
2778 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2779 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2780 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2781 (stuff_buffered_input):
2782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2783 (last_auto_save, command_loop_1, read_char):
2784 Use EMACS_INT, not int, to avoid integer overflow.
2785 (record_char): Avoid overflow in total_keys computation.
2786 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2787 * keyboard.h: Adjust decls to match defn changes elsewhere.
2788 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2789 (Fkey_description, Fdescribe_vector, Flookup_key):
2790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2791 (click_position): New function, to check that positions are in range.
2792 (Fcurrent_active_maps):
2793 (describe_command):
2794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2795 (Faccessible_keymaps, Fkey_description):
2796 (preferred_sequence_p):
2797 Don't assume fixnum can fit into int.
2798 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2799 Check for integer overflow in size calculations.
2800 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2801 avoid mishandling large integers.
2802 * lisp.h: Adjust decls to match defn changes elsewhere.
2803 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2804 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2805 (struct Lisp_Marker):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2808 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2809 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2810 All callers changed.
2811 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2812 Assume the arg has valid form, since it always does.
2813 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2814 unsigned integer system type.
2815 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2816 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2818 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2819 (duration_to_sec_usec): New decl.
2820 * lread.c (read_from_string_index, read_from_string_index_byte)
2821 (read_from_string_limit, readchar, unreadchar, openp)
2822 (read_internal_start, read1, oblookup):
2823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2824 (Fload, readevalloop, Feval_buffer, Feval_region):
2825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2826 (openp): Check for out-of-range argument to 'access'.
2827 (read1): Use int, not EMACS_INT, where int is wide enough.
2828 Don't assume fixnum fits into int.
6efdadfd 2829 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2830 (read_filtered_event): Use duration_to_sec_usec
2831 to do proper overflow checking on durations.
d311d28c
PE
2832 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2833 in size calculation.
2834 (Fexecute_kbd_macro):
2835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2836 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2837 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2838 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2839 (set_marker_both, set_marker_restricted_both, marker_position)
2840 (marker_byte_position, Fbuffer_has_markers_at):
2841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2842 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2843 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2844 It now merely ensures that the menu is large enough, without
2845 necessarily growing it, as this avoids some integer overflow issues.
2846 All callers changed.
2847 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2849 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2850 Use SAFE_ALLOCA_LISP, not alloca.
2851 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2852 to EMACS_INT. Check that fixnums are in proper range for system types.
2853 * minibuf.c (minibuf_prompt_width, string_to_object)
2854 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2855 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2857 (get_minibuffer, read_minibuf_unwind):
2858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2859 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2860 this simplifies overflow checking. All callers changed.
2861 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2862 (Ftest_completion):
2863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2864 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2865 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2866 Check that fixnums are in proper range for system types.
2867 (Fx_create_frame, Fx_show_tip):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 * nsfont.m (ns_findfonts, nsfont_list_family):
2870 Don't assume fixnum fits in long.
2871 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2873 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2874 wide enough.
17fdb222 2875 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2877 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2878 (PRINTDECLARE, PRINTPREPARE):
2879 (strout, print_string):
2880 (print, print_preprocess, print_check_string_charset_prop)
2881 (print_object):
2882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2883 (PRINTDECLARE):
2884 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2886 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2887 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2888 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2889 (print_error_message): Use SAFE_ALLOCA, not alloca.
2890 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2891 (print_depth, new_backquote_output, print_number_index):
2892 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2893 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2894 (Fset_process_window_size, Fformat_network_address)
2895 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2896 (sigchld_handler):
d311d28c 2897 Check that fixnums are in proper range for system types.
d44287d4 2898 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2899 Check for process-ids out of pid_t range rather than relying on
2900 undefined behavior.
e4d81efc 2901 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2902 (Fformat_network_address, read_process_output, send_process)
2903 (Fprocess_send_region, status_notify):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2906 (wait_reading_process_output, read_process_output, exec_sentinel):
2907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2908 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2909 (Faccept_process_output): Use duration_to_sec_usec to do proper
2910 overflow checking on durations.
dde14581
PE
2911 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2912 Don't assume pid_t fits in int.
02481186
PE
2913 * process.h (struct Lisp_Process): Members tick and update_tick
2914 are now of type EMACS_INT, not int.
b62b53e8
PE
2915 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2916 configured --with-wide-int.
d311d28c
PE
2917 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2918 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2919 * search.c (looking_at_1, string_match_1):
2920 (fast_string_match, fast_c_string_match_ignore_case)
2921 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2922 (scan_newline, find_before_next_newline, search_command)
2923 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2924 (set_search_regs, wordify):
2925 (Freplace_match):
2926 (Fmatch_data):
2927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2928 (string_match_1, search_buffer, set_search_regs):
2929 (Fmatch_data):
2930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2931 (wordify): Check for overflow in size calculation.
2932 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2933 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2934 Check that fixnums are in proper range for system types.
2935 * sound.c (struct sound_device)
2936 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2938 (Fplay_sound_internal):
2939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2940 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2941 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2942 (Fparse_partial_sexp):
2943 Don't assume fixnums can fit in int.
2944 (struct lisp_parse_state, find_start_pos, find_start_value)
2945 (find_start_value_byte, find_start_begv)
2946 (update_syntax_table, char_quoted, dec_bytepos)
2947 (find_defun_start, prev_char_comend_first, back_comment):
2948 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2949 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2951 (Finternal_describe_syntax_value): Check that match_lisp is a
2952 character, not an integer, since the code stuffs it into int.
2953 (scan_words, scan_sexps_forward):
2954 Check that fixnums are in proper range for system types.
2955 (Fforward_word):
2956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2957 (scan_sexps_forward):
2958 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2959 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2960 * syntax.h: Adjust decls to match defn changes elsewhere.
2961 (struct gl_state_s):
2962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2963 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2964 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2965 * sysdep.c (wait_for_termination_1, wait_for_termination)
2966 (interruptible_wait_for_termination, mkdir):
2967 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2968 (emacs_read, emacs_write):
2969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2970 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2971 and double all fit in int.
d311d28c
PE
2972 * term.c (set_tty_color_mode):
2973 Check that fixnums are in proper range for system types.
2974 * termhooks.h (struct input_event):
2975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2976 * textprop.c (validate_interval_range, interval_of)
2977 (Fadd_text_properties, set_text_properties_1)
2978 (Fremove_text_properties, Fremove_list_of_text_properties)
2979 (Ftext_property_any, Ftext_property_not_all)
2980 (copy_text_properties, text_property_list, extend_property_ranges)
2981 (verify_interval_modification):
2982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2983 (Fnext_single_char_property_change)
2984 (Fprevious_single_char_property_change):
2985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2986 (copy_text_properties):
2987 Check for integer overflow in index calculation.
d311d28c
PE
2988 * undo.c (last_boundary_position, record_point, record_insert)
2989 (record_delete, record_marker_adjustment, record_change)
2990 (record_property_change):
2991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2992 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2994 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2995 (Fx_hide_tip, Fx_file_dialog):
2996 * w32menu.c (set_frame_menubar):
2997 Use ptrdiff_t, not int, for consistency with rest of code.
2998 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2999 (select_window, Fdelete_other_windows_internal)
3000 (window_scroll_pixel_based, window_scroll_line_based)
3001 (Frecenter, Fset_window_configuration):
3002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3003 (Fset_window_hscroll, run_window_configuration_change_hook)
3004 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3005 (Fscroll_other_window, Frecenter):
d311d28c
PE
3006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3007 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3008 Don't assume fixnum fits in int.
3009 (Fset_window_scroll_bars):
3010 Check that fixnums are in proper range for system types.
3011 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3012 (string_pos, c_string_pos, number_of_chars, init_iterator)
3013 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3014 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3015 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3016 (face_before_or_after_it_pos, handle_invisible_prop)
3017 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3018 (display_prop_intangible_p, string_buffer_position_lim)
3019 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3020 (get_overlay_strings_1, get_overlay_strings)
3021 (iterate_out_of_display_property, forward_to_next_line_start)
3022 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3023 (get_next_display_element, set_iterator_to_next)
3024 (get_visually_first_element, compute_stop_pos_backwards)
3025 (handle_stop_backwards, next_element_from_buffer)
3026 (move_it_in_display_line_to, move_it_in_display_line)
3027 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3028 (add_to_log, message_dolog, message_log_check_duplicate)
3029 (message2, message2_nolog, message3, message3_nolog
3030 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3031 (current_message_1, truncate_echo_area, truncate_message_1)
3032 (set_message, set_message_1, store_mode_line_noprop)
3033 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3034 (text_outside_line_unchanged_p, check_point_in_composition)
3035 (reconsider_clip_changes)
3036 (redisplay_internal, set_cursor_from_row, try_scrolling)
3037 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3038 (redisplay_window, find_last_unchanged_at_beg_row)
3039 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3040 (trailing_whitespace_p, find_row_edges, display_line)
3041 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3042 (display_mode_element, store_mode_line_string)
3043 (pint2str, pint2hrstr, decode_mode_spec)
3044 (display_count_lines, display_string, draw_glyphs)
3045 (x_produce_glyphs, x_insert_glyphs)
3046 (rows_from_pos_range, mouse_face_from_buffer_pos)
3047 (fast_find_string_pos, mouse_face_from_string_pos)
3048 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3050 (safe_call, init_from_display_pos, handle_fontified_prop)
3051 (handle_single_display_spec, load_overlay_strings)
3052 (with_echo_area_buffer, setup_echo_area_for_printing)
3053 (display_echo_area, echo_area_display)
3054 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3055 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3056 (redisplay_window, dump_glyph_row, display_mode_line)
3057 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3058 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3060 (handle_single_display_spec, build_desired_tool_bar_string)
3061 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3062 (get_specified_cursor_type):
3063 Check that fixnums are in proper range for system types.
3064 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3065 (Flookup_image_map):
3066 Don't assume fixnums fit in int.
3067 (compare_overlay_entries):
3068 Avoid mishandling comparisons due to subtraction overflow.
3069 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3070 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3071 (handle_tool_bar_click):
3072 Use int, not unsigned, since we prefer signed and the signedness
3073 doesn't matter here.
3074 (get_next_display_element, next_element_from_display_vector):
3075 Use int, not EMACS_INT, when int is wide enough.
3076 (start_hourglass): Use duration_to_sec_usec to do proper
3077 overflow checking on durations.
3078 * xfaces.c (Fbitmap_spec_p):
3079 Check that fixnums are in proper range for system types.
3080 (compare_fonts_by_sort_order):
3081 Avoid mishandling comparisons due to subtraction overflow.
3082 (Fx_family_fonts, realize_basic_faces):
3083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3084 (Fx_family_fonts):
3085 Don't assume fixnum fits in int.
3086 Use SAFE_ALLOCA_LISP, not alloca.
3087 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3088 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3089 (face_at_buffer_position, face_for_overlay_string)
3090 (face_at_string_position):
3091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3092 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3093 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3094 (Fx_show_tip):
3095 Check that fixnums are in proper range for system types.
3096 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3097 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3099 (Fx_change_window_property): Don't assume fixnums fit in int.
3100 * xfont.c (xfont_chars_supported):
3101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3102 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3103 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3105 * xml.c (parse_region):
3106 * xrdb.c (magic_file_p):
3107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3108 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3109 (x_get_local_selection, x_reply_selection_request)
3110 (x_handle_selection_request, wait_for_property_change):
3111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3112 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3113 short is wide enough.
3114 (x_send_client_event): Don't assume fixnum fits in int.
3115 * xterm.c (x_x_to_emacs_modifiers):
3116 Don't assume EMACS_INT overflows nicely into int.
3117 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3118 may come from Lisp.
3119 (handle_one_xevent): NATNUMP can eval its arg twice.
3120 (x_connection_closed):
3121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3122 * xterm.h: Adjust decls to match defn changes elsewhere.
3123 (struct scroll_bar): Use struct vectorlike_header
3124 rather than rolling our own approximation.
3125 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3126
c6574eb5
GM
31272012-05-25 Glenn Morris <rgm@gnu.org>
3128
3129 * lisp.mk (lisp): Update for more files being compiled now.
3130
e8d32c7e
SM
31312012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3132
48def666
SM
3133 * lread.c: Remove `read_pure' which makes no difference.
3134 (read_pure): Remove var.
3135 (unreadpure): Remove function.
3136 (readevalloop): Don't call read_list with -1 flag.
3137 (read1, read_vector): Don't test read_pure any more.
3138 (read_list): Simplify.
3139
e8d32c7e
SM
3140 * fileio.c, character.h: Minor style tweaks.
3141
4b2addb7
DA
31422012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3143
3144 * window.h (clip_changed): Remove useless declaration.
3145
584461b2
JB
31462012-05-22 Juanma Barranquero <lekktu@gmail.com>
3147
3148 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3149 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3150
34374650
PE
31512012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Remove src/m/*.
3154 This directory predates autoconf and is no longer needed nowadays.
3155 Move its few remaining bits of functionality to where they're needed.
3156 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3157 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3158 * m/template.h: Remove.
3159 * Makefile.in (M_FILE): Remove. All uses removed.
3160 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3161 * lisp.h (USE_LSB_TAG):
3162 * mem-limits.h (EXCEEDS_LISP_PTR):
3163 Use VAL_MAX, not VALBITS, in #if.
3164 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3165 (EMACS_UINT): Define unconditionally now.
3166 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3167 (BITS_PER_EMACS_INT): New constants, replacing
3168 what used to be in config.h, but not useful in #if.
3169 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3170 define them any more.
3171 (VAL_MAX): New macro.
3172 (VALMASK): Use it.
3173 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3174 BITS_PER_EMACS_INT, in #if.
3175 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3176 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3177 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3178 * s/ms-w32.h (DATA_START):
3179 Move here from removed file m/intel386.h.
3180 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3181 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3182
261cb4bb
PE
31832012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 Assume C89 or later.
3186 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3187 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3188 (xrealloc):
3189 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3190 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3191 * textprop.c, tparam.c (NULL): Remove.
3192 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3193 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3194 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3195 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3196 * xterm.c (input_signal_count): Assume volatile works.
3197
ff23cd9f
KB
31982012-05-21 Ken Brown <kbrown@cornell.edu>
3199
3200 * xgselect.c (xg_select): Fix first argument in call to 'select'
3201 (bug#11508).
3202
1b170bc6
KB
32032012-05-20 Ken Brown <kbrown@cornell.edu>
3204
3205 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3206 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3207
b2f4d39f
KB
32082012-05-19 Ken Brown <kbrown@cornell.edu>
3209
3210 * xfns.c (x_in_use): Remove `static' qualifier.
3211 * xterm.h (x_in_use): Declare.
3212 * xgselect.c: Include xterm.h.
3213 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3214 and `display_arg' (bug#9754).
3215
003fdae2
PE
32162012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3217
9232a6d9
PE
3218 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3219
003fdae2
PE
3220 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3221 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3222
784b56e2
EZ
32232012-05-18 Eli Zaretskii <eliz@gnu.org>
3224
3225 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3226
3227 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3228 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3229
3230 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3231 reference to image_cache->refcount.
3232 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3233
a0a79cde
JL
32342012-05-17 Juri Linkov <juri@jurta.org>
3235
3236 * search.c (Fword_search_regexp, Fword_search_backward)
3237 (Fword_search_forward, Fword_search_backward_lax)
3238 (Fword_search_forward_lax): Move functions to isearch.el
3239 (bug#10145, bug#11381).
3240
b0572523
PE
32412012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3244
9660f5fc
SM
32452012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3246
3247 * lread.c (init_obarray): Declare Qt and Qnil as special.
3248
4374de83
GM
32492012-05-14 Glenn Morris <rgm@gnu.org>
3250
3251 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3252 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3253
dc44c39a
PE
32542012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3255
078c97cb
PE
3256 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3257
dc44c39a
PE
3258 * unexaix.c: Port to more-recent AIX compilers.
3259 (report_error, report_error_1, make_hdr, copy_sym)
3260 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3261 Make arguments const char *, not char *, to avoid violations of C
3262 standard and to fix some AIX warnings reported by Gilles Pion.
3263
e18afed7 32642012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3265
3266 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3267 already have overlays loaded.
3268 (handle_single_display_spec): Before returning without displaying
3269 fringe bitmap, synchronize the bidi iterator with the main display
3270 iterator, by calling iterate_out_of_display_property.
3271 (iterate_out_of_display_property): Detect buffer iteration by
3272 testing that it->string is a Lisp string.
3273 (get_next_display_element): When the current object is exhausted,
3274 and there's something on it->stack, call set_iterator_to_next to
3275 proceed with what's on the stack, instead of returning zero.
3276 (set_iterator_to_next): If called at the end of a Lisp string,
3277 proceed to consider_string_end without incrementing string
3278 position. Don't increment display vector index past the end of
3279 the display vector. (Bug#11417)
c8fb9dc6
EZ
3280 (pos_visible_p): Don't report a position visible when move_it_to
3281 stopped at the last line of window, which happens to be scanned
3282 backwards by the bidi iteration. (Bug#11464)
ac268e67 3283
e18afed7 32842012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3285
3286 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3287 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3288 are on a TTY, and thus unable to display on the fringes.
3289 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3290 so we need to signal to the caller that this is a "replacing"
3291 display spec. This fixes display when the spec is invalid or we
3292 are on a TTY.
3293
e18afed7 32942012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3295
3296 * unexaix.c (make_hdr): Fix typo in prototype.
3297 This bug broke the build on AIX. Problem reported by Gilles Pion.
3298
9d0a235a
MA
32992012-05-14 Michael Albinus <michael.albinus@gmx.de>
3300
3301 * keyboard.c (kbd_buffer_get_event): Read special events also in
3302 batch mode. (Bug#11415)
3303
9e6b06ed
GM
33042012-05-12 Glenn Morris <rgm@gnu.org>
3305
3306 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3307
c1a1d7a3
EZ
33082012-05-12 Eli Zaretskii <eliz@gnu.org>
3309
3310 * lisp.mk (lisp): Add newcomment.elc.
3311
3fe7cdc8
GM
33122012-05-12 Glenn Morris <rgm@gnu.org>
3313
3314 * Makefile.in (MKDIR_P): New, set by configure.
3315 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3316
53f7d2c0
PE
33172012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 Remove unused function hourglass_started.
3320 * dispextern.h (hourglass_started):
3321 * w32fns.c (hourglass_started):
3322 * xdisp.c (hourglass_started): Remove.
3323
75aafb17
JB
33242012-05-10 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3327 Update dependencies.
3328
12959e8e
PE
33292012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3330
97107e2e
PE
3331 * xgselect.c (xg_select): Put maxfds+1 into a var.
3332 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3333
12959e8e
PE
3334 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3335
836d29b3
DA
33362012-05-10 Dave Abrahams <dave@boostpro.com>
3337
3338 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3339 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3340
5cb67954
MA
33412012-05-09 Michael Albinus <michael.albinus@gmx.de>
3342
3343 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3344 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3345 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3346 Initialize xd_registered_buses.
3347
3478ec45
PE
33482012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3349
b263a6b0
PE
3350 Untag more efficiently if USE_LSB_TAG.
3351 This is based on a proposal by YAMAMOTO Mitsuharu in
3352 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3353 For an admittedly artificial (nth 8000 longlist) benchmark on
3354 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3355 Emacs's overall text size by 1%.
3356 * lisp.h (XUNTAG): New macro.
3357 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3358 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3359 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3360 * eval.c (Fautoload):
3361 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3362 * frame.h (XFRAME): Use XUNTAG.
3363
3478ec45
PE
3364 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3365 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3366 Remove unportable assumptions about print widths of types like
3367 dbus_uint32_t.
3368 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3369 intptr_t when converting between pointer and integer, to avoid GCC
3370 warnings about wrong width.
3371
666b903b 33722012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3373
3374 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3375 stack for each reader_thread, instead of defaulting to 8MB
3376 determined by the linker. This avoids failures in creating
3377 subprocesses on Windows 7, see the discussion in this thread:
3378 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3379
b120cc17
JC
33802012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3381
3382 Fix up display of the *Minibuf-0* buffer in the mini window.
3383 * keyboard.c (read_char): Don't clear the echo area if there's no
3384 message to clear.
3385 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3386 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3387
9a4b36f8
MA
33882012-05-07 Michael Albinus <michael.albinus@gmx.de>
3389
3390 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3391 batch mode.
3392
e5f9458f
CY
33932012-05-06 Chong Yidong <cyd@gnu.org>
3394
3395 * lisp.mk (lisp): Update.
3396
eceeb5fc 33972012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3398
3399 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3400
71873e2b
SM
34012012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3402
3403 * data.c (PUT_ERROR): New macro.
3404 (syms_of_data): Use it. Add new error type `user-error'.
3405 * undo.c (user_error): New function.
3406 (Fprimitive_undo): Use it.
3407 * print.c (print_error_message): Adjust print style for `user-error'.
3408 * keyboard.c (user_error): New function.
3409 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3410
ab0fa4e4
PE
34112012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3412
3413 Do not limit current-time-string to years 1000..9999.
3414 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3415 (Fcurrent_time_string): Support any year that is supported by the
3416 underlying localtime representation. Don't use asctime, as it
3417 has undefined behavior for years outside the range -999..9999.
3418
7ed806a7
PE
34192012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 Fix race conditions involving setenv, gmtime, localtime, asctime.
3422 Without this fix, interrupts could mess up code that uses these
3423 nonreentrant functions, since setting TZ invalidates existing
3424 tm_zone or tzname values, and since most of these functions return
3425 pointers to static storage.
3426 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3427 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3428 Grow the critical sections to include not just invoking
3429 localtime/gmtime, but also accessing these functions' results
3430 including their tm_zone values if any, and any related TZ setting.
3431 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3432 so that the struct tm is saved in the critical section.
3433 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3434 motivated by the fact that memory allocation needs to be outside
3435 the critical section.
3436
0c16dfed
DA
34372012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3438
3439 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3440 with RESET_INTERVAL.
3441
3442 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3443 Remove duplicated buffer name initialization.
3444
3f83ace8
JM
34452012-05-02 Jim Meyering <jim@meyering.net>
3446
3447 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3448
c7b8541e
JM
3449 * xfns.c (x_window): Use xstrdup (Bug#11375).
3450
90207a15 34512012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3452
3453 * xdisp.c (pos_visible_p): If already at a newline from the
3454 display string before the 'while' loop, don't walk back the glyphs
3455 from it3.glyph_row. Solves assertion violation when the display
3456 string begins with a newline (egg.el). (Bug#11367)
3457
b593d6a9
AH
34582012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3459
3460 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3461 Move to simple.el.
3462
4737362e
GM
34632012-05-01 Glenn Morris <rgm@gnu.org>
3464
99cf43f9
GM
3465 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3466 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3467 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3468 All were removed before 23.1.
3469
9311dcff
GM
3470 * dispnew.c: Remove HAVE_LIBNCURSES test;
3471 it is always true on relevant platforms.
3472
4d5c6349
GM
3473 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3474 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3475
4737362e
GM
3476 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3477
74dd3a6b
AS
34782012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3479
3480 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3481 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3482 Remove.
3483
13c379ee
PE
34842012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 Do not avoid creating empty evaporating overlays (Bug#9642).
3487 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3488 That is, do not delete an evaporating overlay if it becomes
3489 empty after its bounds are adjusted to fit within its buffer.
3490 This fix caused other problems, and I'm reverting it until we get
3491 to the bottom of them.
3492
a8e7d6d7 34932012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3494
3495 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3496
a8e7d6d7 34972012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3498
3499 * xdisp.c (pos_visible_p): If the window start position is beyond
3500 ZV, start the display from buffer beginning. Prevents assertion
3501 violation in init_iterator when the minibuffer window is scrolled
3502 via the scroll bar.
3503
3504 * window.c (window_scroll_pixel_based): Likewise.
3505
a8e7d6d7 35062012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3507
3508 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3509
a8e7d6d7 35102012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3511
3512 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3513 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3514
a8e7d6d7 35152012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3516
b593d6a9
AH
3517 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3518 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3519
1c6900d9
EZ
35202012-04-26 Eli Zaretskii <eliz@gnu.org>
3521
4c3fa1d9
EZ
3522 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3523 display element, check also the underlying string or buffer
3524 character. (Bug#11341)
3525
1c6900d9
EZ
3526 * w32menu.c: Include w32heap.h.
3527 (add_menu_item): If the call to AppendMenuW (via
3528 unicode_append_menu) fails, disable Unicode menus only if we are
3529 running on Windows 9X/Me.
3530
42bf8205
AS
35312012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3532
3533 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3534 (xgetint): Add missing shift for LSB tags.
3535
b1bac16e
MR
35362012-04-24 Martin Rudalics <rudalics@gmx.at>
3537
3538 * keyboard.c (read_char): Don't wipe echo area for select window
3539 events: These might get delayed via `mouse-autoselect-window'
3540 (Bug#11304).
3541
d69621cc
JB
35422012-04-24 Juanma Barranquero <lekktu@gmail.com>
3543
3544 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3545 manipulation of :loaded-from data.
3546
02fd101b
JB
35472012-04-23 Juanma Barranquero <lekktu@gmail.com>
3548
3549 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3550 now a cons (bug#11311).
3551
888bec30
PE
35522012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3553
89a438bd
PE
3554 Do not create empty overlays with the evaporate property (Bug#9642).
3555 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3556 if it becomes empty after its bounds are adjusted to fit within
3557 its buffer. Without this fix, in a nonempty buffer (let ((o
3558 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3559 yields an empty overlay that has the evaporate property, which is
3560 not supposed to happen.
3561
1068fe4d
PE
3562 Fix minor GTK3 problems found by static checking.
3563 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3564 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3565 (struct _EmacsFixedClass, emacs_fixed_get_type):
3566 Move decls here from emacsgtkfixed.h, since they needn't be public.
3567 (emacs_fixed_get_type): Now static.
3568 (emacs_fixed_class_init): Omit unused local.
3569 (emacs_fixed_child_type): Remove; unused.
3570 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3571 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3572 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3573 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3574 (EMACS_FIXED_GET_CLASS): Remove; unused.
3575 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3576
888bec30
PE
3577 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3578 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3579
de85e130
PE
35802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3581
d0baac98 3582 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3583 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3584 (__malloc_size_t, __malloc_ptrdiff_t):
3585 Remove. All uses removed, replaced by the definiens if needed,
3586 since we can assume C89 or better now.
3587 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3588 (protect_malloc_state, align, get_contiguous_space)
3589 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3590 (malloc_atfork_handler_child, malloc_enable_thread)
3591 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3592 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3593 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3594 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3595 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3596 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3597 Define using prototypes, not old style.
3598 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3599 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3600 (align): Don't assume that signed integer overflow wraps around.
3601 Omit unused local var.
3602 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3603 (_free_internal_nolock, memalign, mallochook, reallochook):
3604 Omit no-longer-needed casts.
3605 (valloc): Use getpagesize, not __getpagesize.
3606 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3607 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3608
de85e130
PE
3609 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3610
dcbf5805
MA
36112012-04-22 Michael Albinus <michael.albinus@gmx.de>
3612
3613 Move functions from C to Lisp. Make non-blocking method calls
3614 the default. Implement further D-Bus standard interfaces.
3615
3616 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3617 (QCdbus_request_name_allow_replacement)
3618 (QCdbus_request_name_replace_existing)
3619 (QCdbus_request_name_do_not_queue)
3620 (QCdbus_request_name_reply_primary_owner)
3621 (QCdbus_request_name_reply_in_queue)
3622 (QCdbus_request_name_reply_exists)
3623 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3624 (QCdbus_registered_serial, QCdbus_registered_method)
3625 (QCdbus_registered_signal): New Lisp objects.
3626 (XD_DEBUG_MESSAGE): Use sizeof.
3627 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3628 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3629 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3630 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3631 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3632 (xd_signature, xd_append_arg): Allow float for integer types.
3633 (xd_get_connection_references): New function.
b593d6a9
AH
3634 (xd_get_connection_address): Rename from xd_initialize.
3635 Return cached address.
dcbf5805
MA
3636 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3637 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3638 level.
3639 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3640 Return number of refcounts.
dcbf5805
MA
3641 (Fdbus_get_unique_name): Make stronger parameter check.
3642 (Fdbus_message_internal): New defun.
3643 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3644 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3645 (Fdbus_send_signal, Fdbus_register_service)
3646 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3647 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3648 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3649 (Vdbus_compiled_version, Vdbus_runtime_version)
3650 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3651 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3652 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3653 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3654 Adapt docstring.
dcbf5805 3655
52828e02
PE
36562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3657
da05bc4c
PE
3658 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3659 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3660 Do not assume ptrdiff_t is the same width as 'int'.
3661
52828e02
PE
3662 * alloc.c: Handle unusual debugging option combinations.
3663 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3664 since the two debugging options are incompatible.
3665 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3666 is defined.
3667 (mem_init, mem_insert, mem_insert_fixup):
3668 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3669 (NEED_MEM_INSERT): Remove; no longer needed.
3670
f01769f9
LL
36712012-04-22 Leo Liu <sdl.web@gmail.com>
3672
3673 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3674
5790543d
PE
36752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3676
3677 * sysdep.c [__FreeBSD__]: Minor cleanups.
3678 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3679 Use Emacs indenting style more consistently. Avoid some casts.
3680 Use 'double' consistently rather than mixing 'float' and 'double'.
3681
b91b7e4d
EW
36822012-04-21 Eduard Wiebe <usenet@pusto.de>
3683
b593d6a9
AH
3684 * sysdep.c (list_system_processes, system_process_attributes):
3685 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3686
6114eb15
AS
36872012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3688
3689 * lisp.mk (lisp): Update.
3690
2f38dff7
PE
36912012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3692
3693 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3694 It is never used otherwise.
3695
4ae29f89
SM
36962012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3697
3698 * print.c (print_preprocess): Only check print_depth if print-circle
3699 is nil.
3700 (print_object): Check for cycles even when print-circle is nil and
3701 print-gensym is t, but only check print_depth if print-circle is nil.
3702
f30d612a
CY
37032012-04-20 Chong Yidong <cyd@gnu.org>
3704
3705 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3706 set the status to "failed" and ensure that sentinel is run.
3707
c07a4c0b 37082012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3709
3710 * process.c (Fset_process_inherit_coding_system_flag)
3711 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3712 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3713
c07a4c0b 37142012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3715
3716 * xdisp.c (string_buffer_position_lim): Limit starting position to
3717 BEGV.
3718 (set_cursor_from_row): If called for a mode-line or header-line
3719 row, return zero immediately.
3720 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3721 farther than the first row after the header line, if any.
3722 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3723 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3724
c07a4c0b 37252012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3726
4ae29f89
SM
3727 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3728 (bug#11238).
ad3a2b41 3729
c07a4c0b 37302012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 37312012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3732
3733 configure: new option --enable-gcc-warnings (Bug#11207)
3734 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3735 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3736 (ALL_CFLAGS): Use new macros rather than old.
3737 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3738 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3739 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3740 -Wunused-result, -Wunused-variable. This should go away once
3741 the Emacs and Gnulib regex code is merged.
3742 (xmalloc, xrealloc): Now static.
3743
aba027e8
PE
37442012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 * dired.c (Fsystem_groups): Remove unused local.
3747
e5a36063
GM
37482012-04-17 Glenn Morris <rgm@gnu.org>
3749
3750 * dired.c (Fsystem_users): Doc fix.
3751
316411f0
DA
37522012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3753
3754 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3755 (syms_of_dired): Add them.
3756
9426aba4
PE
37572012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3758
b62a57be
PE
3759 Fix minor alloc.c problems found by static checking.
3760 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3761 New extern decls, to avoid calling undeclared functions.
3762 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3763 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3764 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3765 (NEED_MEM_INSERT): New macro.
3766 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3767 Remove one incorrect comment and fix another.
b62a57be 3768
3539f31f
PE
3769 Fix minor ralloc.c problems found by static checking.
3770 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3771 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3772 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3773 (r_alloc_sbrk): Now static.
3774
a041960a
PE
3775 Improve ralloc.c interface checking.
3776 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3777 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3778 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3779 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3780 [REL_ALLOC]: ... to here, to check interface.
3781 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3782 Remove decls. This fixes an "It stinks!".
3783
9426aba4
PE
3784 * alloc.c (which_symbols): Fix alignment issue / type clash.
3785
d55c12ed
AS
37862012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3787
3788 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3789 (struct Lisp_Misc_Any): Likewise.
3790 (struct Lisp_Free): Likewise.
3791 * alloc.c (union aligned_Lisp_Symbol): Define.
3792 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3793 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3794 (union aligned_Lisp_Misc): Define.
3795 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3796 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3797 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3798
b948ce8b
PE
37992012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3800
3801 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3802 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3803 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3804 * s/netbsd.h, s/sol2-6.h:
3805 Remove definition of GC_MARK_STACK, since the default now works.
3806 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3807 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3808 no longer the default.
3809 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3810
35dc09a1 38112012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3812
35dc09a1
GM
3813 * lread.c (lisp_file_lexically_bound_p):
3814 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3815
35dc09a1
GM
38162012-04-14 Eli Zaretskii <eliz@gnu.org>
3817
3818 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3819 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3820
38212012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * nsterm.m (constrainFrameRect): Always constrain when there is only
3824 one screen (Bug#10962).
3825
bcd86815
KB
38262012-04-13 Ken Brown <kbrown@cornell.edu>
3827
3828 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3829
c25df26e
RT
38302012-04-13 Reuben Thomas <rrt@sc3d.org>
3831
3832 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3833
0fc59f1e
DC
38342012-04-11 Daniel Colascione <dancol@dancol.org>
3835
3836 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3837 against is gone. It's better to use vfork now so that when Cygwin
3838 gains a new, working vfork, we use it automatically (bug#10398).
3839
de8c03dc
SM
38402012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3841
3842 * window.c (save_window_save): Obey window-point-insertion-type.
3843
2f097256
GM
38442012-04-11 Glenn Morris <rgm@gnu.org>
3845
3846 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3847
453b951e
SM
38482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3849
3850 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3851
75f1671a 38522012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3853
3854 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3855 (force_quit_count): New var.
3856 (handle_interrupt): Use it.
3857
2a8ce227
JB
38582012-04-10 Juanma Barranquero <lekktu@gmail.com>
3859
3860 * w32.c (w32_delayed_load): Record the full path of the library
3861 being loaded (bug#10424).
3862
935396c0
GM
38632012-04-09 Glenn Morris <rgm@gnu.org>
3864
05920a43
GM
3865 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3866 not just in the obarray, before snarfing them. (Bug#11036)
3867
935396c0
GM
3868 * Makefile.in ($(leimdir)/leim-list.el):
3869 Pass EMACS rather than BUILT_EMACS.
3870
a18ecafa
TZ
38712012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3872
3873 * process.c (make_process):
3874 * process.h: Add integer `gnutls_handshakes_tried' member to
3875 process struct.
3876
6bbef4e5
JC
3877 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3878 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3879
3880 * gnutls.c (gnutls_log_function2i): Convenience log function.
3881 (emacs_gnutls_read): Use new log functions,
3882 `gnutls_handshakes_tried' process member, and
3883 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3884 attempts per process (connection).
3885
b4d3bc10
CY
38862012-04-09 Chong Yidong <cyd@gnu.org>
3887
3888 * eval.c (Fuser_variable_p, user_variable_p_eh)
3889 (lisp_indirect_variable): Functions deleted.
3890 (Fdefvar): Caller changed.
3891
3892 * callint.c (Finteractive, Fcall_interactively):
3893 * minibuf.c (Fread_variable): Callers changed.
3894
70f4d973
EZ
38952012-04-09 Eli Zaretskii <eliz@gnu.org>
3896
3897 * xdisp.c (set_cursor_from_row): If the display string appears in
3898 the buffer at position that is closer to point than the position
3899 after the display string, display the cursor on the first glyph of
3900 the display string. Fixes cursor display when a 'display' text
3901 property immediately follows invisible text. (Bug#11094)
3902
cb3c2e3e
PE
39032012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 composite.c: use 'double' consistently
3906 * composite.c (get_composition_id): Use 'double' consistently
3907 instead of converting 'float' to 'double' and vice versa; this is
3908 easier to understand and avoids a GCC warning.
3909
fd06db5d
GM
39102012-04-09 Glenn Morris <rgm@gnu.org>
3911
50fe702a
GM
3912 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3913 preparation for dumping it with emacs. (Bug#4789)
3914 (leimdir): New variable.
3915 ($(leimdir)/leim-list.el): New rule.
3916 (emacs$(EXEEXT)): Depend on leim-list.el.
3917
fd06db5d
GM
3918 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3919 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3920 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3921
55c131ee
AS
39222012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3923
3924 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3925 proper alignment.
3926
9209588f
JB
39272012-04-07 Juanma Barranquero <lekktu@gmail.com>
3928
3929 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3930 Remove unused local variable.
3931
e3fb2efb
PE
39322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3933
3934 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3935 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3936 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3937 objects, as mark_maybe_pointer will catch them otherwise.
3938 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3939 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3940
b5385551
PE
39412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 Fix typo that broke non-Windows builds.
3944 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3945
9078ead6
EZ
39462012-04-07 Eli Zaretskii <eliz@gnu.org>
3947
3948 Support building on MS-Windows with libxml2.
3949
3950 * makefile.w32-in (OBJ2): Add xml.$(O).
3951 (GLOBAL_SOURCES): Add xml.c.
3952 ($(BLD)/xml.$(O)): New dependency list.
3953
3954 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3955 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3956 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3957 [!WINDOWSNT]: New macros.
3958 (init_libxml2_functions, libxml2_loaded_p): New functions.
3959 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3960 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3961 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3962 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3963 linked in).
6bbef4e5
JC
3964 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3965 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3966 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3967
3968 * emacs.c: Don't include libxml/parser.h.
3969 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3970 xmlCleanupParser directly.
3971
3972 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3973
3811fdf3
EZ
39742012-04-07 Eli Zaretskii <eliz@gnu.org>
3975
3976 * indent.c (Fvertical_motion): If there is a display string at
3977 point, use it.vpos to compute how many lines to backtrack after
3978 move_it_to point. (Bug#11133)
3979
2f8e16b2
EZ
39802012-04-06 Eli Zaretskii <eliz@gnu.org>
3981
3982 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3983 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3984 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3985 macros related to unification of CJK characters. For the details,
3986 see the discussion following the message here:
3987 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3988
3d439cd1
CY
39892012-04-04 Chong Yidong <cyd@gnu.org>
3990
3991 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3992
8bc53d00
EZ
39932012-04-01 Eli Zaretskii <eliz@gnu.org>
3994
3995 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3996 instead of alloca. (Bug#11138)
3997
3b0512a3
AS
39982012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3999
4000 * w32menu.c (is_simple_dialog): Properly check lisp types.
4001 (Bug#11141)
4002
8427ddd2
EZ
40032012-03-31 Eli Zaretskii <eliz@gnu.org>
4004
979022ef
EZ
4005 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4006 position we get to after a call to move_it_to fails the
4007 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4008 only if we wind up in a string from display property. (Bug#11063)
4009
a6b1c7cc
EZ
4010 * window.c (Fdelete_other_windows_internal): Invalidate the row
4011 and column information about mouse highlight, so that redisplay
4012 restores it after reallocating the glyph matrices. (Bug#7464)
4013
8427ddd2
EZ
4014 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4015 string comes from a `display' text property, use the buffer
4016 position of that property as if we actually saw that position in
4017 the row's glyphs.
697ba24b
EZ
4018 (move_it_by_lines): Remove the assertion that
4019 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4020 violated when there's a before-string at the beginning of a line.
4021 (Bug#11063)
8427ddd2 4022
65a0a738
EZ
40232012-03-30 Eli Zaretskii <eliz@gnu.org>
4024
4025 * xdisp.c (append_space_for_newline): If the default face was
4026 remapped, use the remapped face for the appended newline.
4027 (extend_face_to_end_of_line): Use the remapped default face for
4028 extending the face to the end of the line.
4029 (display_line): Call extend_face_to_end_of_line when the default
4030 face was remapped. (Bug#11068)
4031
581355cc
EZ
40322012-03-29 Eli Zaretskii <eliz@gnu.org>
4033
4034 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4035
e8fc049f
SM
40362012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4037
4038 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4039
4fb9a543
GM
40402012-03-27 Glenn Morris <rgm@gnu.org>
4041
4042 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4043 Doc fixes.
4044
679910f1
KH
40452012-03-26 Kenichi Handa <handa@m17n.org>
4046
4047 * dispextern.h (struct glyph): Fix previous change. Change the
4048 bit length of glyphless.ch to 25 (Bug#11082).
4049
90d49b7f
CY
40502012-03-26 Chong Yidong <cyd@gnu.org>
4051
4052 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4053 (command_loop_1): Use it; inhibit selection update for
4054 handle-select-window too (Bug#8996).
4055
f514f6f0
FP
40562012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4057
e8fc049f 4058 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4059
bf43fa51
KH
40602012-03-25 Kenichi Handa <handa@m17n.org>
4061
4062 * dispextern.h (struct glyph): Change the bit length of
4063 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4064
8a0c01dd
EZ
40652012-03-24 Eli Zaretskii <eliz@gnu.org>
4066
4067 * s/ms-w32.h (tzname): Include time.h before redirecting to
4068 _tzname. Fixes the MSVC build. (Bug#9960)
4069
7d1c3a76
AS
40702012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4071
8ed79523
AS
4072 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4073 characters.
4074
7d1c3a76
AS
4075 * xterm.c (XTread_socket): Only modify handling_signal if
4076 !SYNC_INPUT. (Bug#11080)
4077
e99a9b8b
EZ
40782012-03-23 Eli Zaretskii <eliz@gnu.org>
4079
4080 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4081 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4082 when fetching a multibyte character consumes more bytes than
4083 CHAR_BYTES returns, due to unification of CJK characters in
4084 string_char. (Bug#11073)
4085
5063c0e1
TN
40862012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4087
4088 * process.c (wait_reading_process_output): Handle pty disconnect
4089 by refraining from sending oneself a SIGCHLD (bug#10933).
4090
9f851fbd
CY
40912012-03-22 Chong Yidong <cyd@gnu.org>
4092
4093 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4094
5063c0e1 4095 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4096 Mark string as coming from a prefix property.
4097 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4098 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4099
fb5b8aca
CY
41002012-03-21 Chong Yidong <cyd@gnu.org>
4101
4102 * xfaces.c (Vface_remapping_alist): Doc fix.
4103
62356a1b
EZ
41042012-03-20 Eli Zaretskii <eliz@gnu.org>
4105
4106 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4107 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4108 Doc fixes.
62356a1b 4109
025de85b
CY
41102012-03-20 Chong Yidong <cyd@gnu.org>
4111
4112 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4113 to reflect default non-nil value of redisplay-dont-pause.
4114
4827f94e
KH
41152012-03-19 Kenichi Handa <handa@m17n.org>
4116
4117 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4118 it fit in a valid range (Bug#11003).
4119
e50a24a2
EZ
41202012-03-18 Eli Zaretskii <eliz@gnu.org>
4121
4122 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4123 that is not from display property, accept the row as a "cursor
4124 row" if one of the string's character has a non-nil `cursor'
4125 property. Fixes cursor positioning when there are newlines in
4126 overlay strings, e.g. in icomplete.el. (Bug#11035)
4127
9af5ed87
PE
41282012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4131
d1f55f16
CY
41322012-03-12 Chong Yidong <cyd@gnu.org>
4133
4134 * eval.c (inhibit_lisp_code): Rename from
4135 inhibit_window_configuration_change_hook; move from window.c.
4136
4137 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4138 * window.c (run_window_configuration_change_hook)
4139 (syms_of_window): Callers changed.
4140
66c5eebd
CY
41412012-03-11 Chong Yidong <cyd@gnu.org>
4142
413df973
CY
4143 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4144
66c5eebd
CY
4145 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4146
1de11f56
CY
41472012-03-10 Chong Yidong <cyd@gnu.org>
4148
4149 * frame.c (other_visible_frames): Don't assume the selected frame
4150 is visible (Bug#10955).
4151
cae07000
SM
41522012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4153
4154 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4155
89c94350
JD
41562012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4157
4158 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4159 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4160 zero (Bug#10954).
4161
999dd333
GM
41622012-03-03 Glenn Morris <rgm@gnu.org>
4163
01a6dcc8 4164 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4165
de0100f2
EZ
41662012-03-02 Eli Zaretskii <eliz@gnu.org>
4167
4168 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4169 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4170 (redisplay_window, next_element_from_string): Fix typos in
4171 comments.
3e441275
EZ
4172 (redisplay_window): Pass to move_it_vertically the margin in
4173 pixels, not in screen lines.
de0100f2 4174
96a72ee9
GM
41752012-03-02 Glenn Morris <rgm@gnu.org>
4176
4177 * buffer.c (buffer-list-update-hook): Doc fix.
4178
312508d7
EZ
41792012-02-29 Eli Zaretskii <eliz@gnu.org>
4180
4181 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4182 push_it before setting up the iterator for the first overlay
4183 string, even if we have an empty string loaded.
4184 (next_overlay_string): If there's an empty string on the iterator
4185 stack, pop the stack. (Bug#10903)
4186
27f3c637
PE
41872012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4188
4189 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4190 Suggested by Stefan Monnier in
4191 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4192 * alloc.c (widen_to_Lisp_Object): New static function.
4193 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4194 and widening them to Lisp_Objects. This would work even if
4195 USE_LSB_TAG is defined and wide integers are used, which might
4196 happen in a future version of Emacs.
4197
3c9dfce6
CY
41982012-02-25 Chong Yidong <cyd@gnu.org>
4199
fa74b241
CY
4200 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4201 Doc fix.
4202
3c9dfce6
CY
4203 * xselect.c (Fx_selection_exists_p): Doc fix.
4204 (x_clipboard_manager_save_all): Print an informative message
4205 before saving to clipboard manager.
4206
9486df08
CY
42072012-02-24 Chong Yidong <cyd@gnu.org>
4208
4209 * keyboard.c (process_special_events): Handle all X selection
4210 requests in kbd_buffer, not just the next one (Bug#8869).
4211
f01d3321
CY
42122012-02-23 Chong Yidong <cyd@gnu.org>
4213
4214 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4215 call when setting menu-bar-lines and tool-bar-lines parameters.
4216 (unwind_create_frame_1): New helper function.
4217
4218 * window.c (inhibit_window_configuration_change_hook): New var.
4219 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4220 (syms_of_window): Initialize it.
f01d3321 4221
86b847b6
CY
42222012-02-22 Chong Yidong <cyd@gnu.org>
4223
4224 * xterm.c (x_draw_image_relief): Add missing type check for
4225 Vtool_bar_button_margin (Bug#10743).
4226
a59225b1
CY
42272012-02-21 Chong Yidong <cyd@gnu.org>
4228
4229 * fileio.c (Vfile_name_handler_alist): Doc fix.
4230
4231 * buffer.c (Fget_file_buffer): Protect against invalid file
4232 handler return value.
4233
310f5bd4
PE
42342012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4235
cb3a28cc
PE
4236 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4237 when computing $valmask.
4238
310f5bd4
PE
4239 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4240 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4241 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4242 It's useless in that case, and it can cause problems on hosts
4243 that allocate halves of EMACS_INT values separately.
4244 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4245 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4246 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4247 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4248 it avoids undefined behavior on hosts where shifting right by more
4249 than the word width has undefined behavior.
4250
2375c96a
CY
42512012-02-19 Chong Yidong <cyd@gnu.org>
4252
4253 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4254 (Funhandled_file_name_directory, Ffile_name_as_directory)
4255 (Fdirectory_file_name, Fexpand_file_name)
4256 (Fsubstitute_in_file_name): Protect against invalid file handler
4257 return values (Bug#10845).
4258
3eb49e71
EZ
42592012-02-18 Eli Zaretskii <eliz@gnu.org>
4260
4261 * .gdbinit (pitx): Fix incorrect references to fields of the
4262 iterator stack.
4263
7b926f3f
CY
42642012-02-17 Chong Yidong <cyd@gnu.org>
4265
4266 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4267
11273115
PE
42682012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4269
4270 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4271 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4272
c3a70e2b
CY
42732012-02-15 Chong Yidong <cyd@gnu.org>
4274
4275 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4276 marked as special. Also, starting docstrings with * is obsolete.
4277
0ca43699
AS
42782012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4279
4280 * gnutls.c (emacs_gnutls_write): Fix last change.
4281
2e8f3c56
LI
42822012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4283
4284 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4285 send_process.
4286
af70074f
SM
42872012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4288
4289 * keymap.c (Fsingle_key_description): Handle char ranges.
4290
95986d52
CY
42912012-02-12 Chong Yidong <cyd@gnu.org>
4292
afd83bd1
CY
4293 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4294 as that creates a dangerous corner case.
4295
95986d52
CY
4296 * window.c (Fdelete_window_internal): Invalidate the mouse
4297 highlight (Bug#9904).
4298
bd7da63e
GM
42992012-02-12 Glenn Morris <rgm@gnu.org>
4300
4301 * xselect.c (Fx_own_selection_internal)
4302 (Fx_get_selection_internal, Fx_disown_selection_internal)
4303 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4304 * nsselect.m (Fx_own_selection_internal)
4305 (Fx_disown_selection_internal, Fx_selection_exists_p)
4306 (Fx_selection_owner_p, Fx_get_selection_internal):
4307 Sync docs and argument specs with the xselect.c versions.
4308
77abcbc2
LI
43092012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4310
4311 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4312
90b671e2
EZ
43132012-02-11 Eli Zaretskii <eliz@gnu.org>
4314
1c0ca0b7
EZ
4315 * w32select.c (Fx_selection_exists_p): Sync doc string and
4316 argument list with xselect.c. (Bug#10783)
4317
4318 * w16select.c (Fx_selection_exists_p): Sync doc string and
4319 argument list with xselect.c. (Bug#10783)
90b671e2 4320
49241268
GM
43212012-02-10 Glenn Morris <rgm@gnu.org>
4322
4323 * fns.c (Fsecure_hash): Doc fix.
4324
f998bbe7 43252012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4326
4327 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4328
0992bd9c
CY
43292012-02-07 Chong Yidong <cyd@gnu.org>
4330
4331 * buffer.c (Fbuffer_local_variables)
4332 (buffer_lisp_local_variables): Handle unbound vars correctly;
4333 don't let Qunbound leak into Lisp.
4334
af008560
GM
43352012-02-07 Glenn Morris <rgm@gnu.org>
4336
dd605cc4
GM
4337 * image.c (Fimagemagick_types): Doc fix.
4338
af008560
GM
4339 * image.c (imagemagick-render-type): Change it from a lisp object
4340 to an integer. Move the doc here from the lisp manual.
4341 Treat all values not equal to 0 the same.
4342
1449fa1d
CY
43432012-02-06 Chong Yidong <cyd@gnu.org>
4344
4345 * doc.c (store_function_docstring): Avoid applying docstring of
4346 alias to base function (Bug#2603).
4347
3723ec07
AS
43482012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4349
4350 * .gdbinit (pp1, pv1): Remove redundant defines.
4351 (pr): Use pp.
4352
79c1cc1e
CY
43532012-02-04 Chong Yidong <cyd@gnu.org>
4354
4355 * nsterm.m: Declare a global (Bug#10694).
4356
d7f29f8e
EZ
43572012-02-04 Eli Zaretskii <eliz@gnu.org>
4358
cae07000
SM
4359 * w32.c (get_emacs_configuration_options):
4360 Include --enable-checking, if specified, in the return value.
d7f29f8e 4361
3b95a6f9
MR
43622012-02-04 Martin Rudalics <rudalics@gmx.at>
4363
4364 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4365 after rounding frame sizes. (Bug#9723)
4366
d6fa96a6
EZ
43672012-02-04 Eli Zaretskii <eliz@gnu.org>
4368
4369 * keyboard.c (adjust_point_for_property): Don't position point
4370 before BEGV. (Bug#10696)
4371
df0b2940
PE
43722012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4373
4374 Handle overflow when computing char display width (Bug#9496).
4375 * character.c (char_width): Return EMACS_INT, not int.
4376 (char_width, c_string_width): Check for overflow when
4377 computing the width; this is possible now that individual
4378 characters can have unbounded width. Problem introduced
4379 by merge from Emacs 23 on 2012-01-19.
4380
6bee44d6
MA
43812012-02-02 Michael Albinus <michael.albinus@gmx.de>
4382
4383 * dbusbind.c (Fdbus_register_method): Mention the return value
4384 :ignore in the docstring.
4385
44f92739
GM
43862012-02-02 Glenn Morris <rgm@gnu.org>
4387
1b9f60cc
GM
4388 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4389
44f92739
GM
4390 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4391 Unconditionally set to t. (Bug#10673)
4392 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4393 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4394 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4395
c5d3843c
KH
43962012-02-02 Kenichi Handa <handa@m17n.org>
4397
4398 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4399 0, do not call append_composite_glyph.
4400
159462d4 44012012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4402
4403 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4404 NULL (Bug#6988).
4405 (x_produce_glyphs): If the component of a composition is a null
4406 string, set it->pixel_width to 1 to avoid zero-width glyph.
4407
78cef877
EZ
44082012-02-01 Eli Zaretskii <eliz@gnu.org>
4409
4410 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4411 first 2 arguments are identical. This makes inserting large
4412 output from a subprocess an order of magnitude faster on
4413 MS-Windows, where all sbrk'ed memory is always contiguous.
4414
97897668
GM
44152012-01-31 Glenn Morris <rgm@gnu.org>
4416
4417 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4418 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4419 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4420
31fd3586
GM
44212012-01-29 Glenn Morris <rgm@gnu.org>
4422
4423 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4424
0e24a8b2
CY
44252012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4426
4427 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4428
cc0adcb0
CY
44292012-01-28 Chong Yidong <cyd@gnu.org>
4430
4431 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4432
acc28cb9
CY
44332012-01-26 Chong Yidong <cyd@gnu.org>
4434
9c69cfb7
CY
4435 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4436
acc28cb9
CY
4437 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4438 repeat counts (Bug#10507).
4439
48da7392
GM
44402012-01-26 Glenn Morris <rgm@gnu.org>
4441
4442 * lread.c (syms_of_lread): Doc fix.
4443
14af5f7f
CY
44442012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4445
4446 * coding.c (encode_designation_at_bol): Change return value to
4447 EMACS_INT.
4448
0b21c100
CY
44492012-01-25 Chong Yidong <cyd@gnu.org>
4450
4451 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4452
3c2907f7
CY
44532012-01-21 Chong Yidong <cyd@gnu.org>
4454
4455 * floatfns.c (Fcopysign): Make the second argument non-optional,
4456 since nil is not allowed anyway.
4457
959ad23f
AS
44582012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4459
4460 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4461 (send_process): Likewise.
4462
34a02f46
MR
44632012-01-19 Martin Rudalics <rudalics@gmx.at>
4464
4465 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4466 (Vwindow_persistent_parameters): Do not use Qstate.
4467 Rewrite doc-strings.
34a02f46 4468
1259009a 44692012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4470
4471 * character.c (char_width): New function.
70d4fdf6
GM
4472 (Fchar_width, c_string_width, lisp_string_width):
4473 Use char_width (Bug#9496).
25ed9e61 4474
6a6ee00d
MR
44752012-01-16 Martin Rudalics <rudalics@gmx.at>
4476
4477 * window.c (Vwindow_persistent_parameters): New variable.
4478 (Fset_window_configuration, save_window_save): Handle persistent
4479 window parameters.
4480
c85efaf7
EZ
44812012-01-14 Eli Zaretskii <eliz@gnu.org>
4482
4483 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4484 thrashing the stack of the thread. (Bug#9087)
4485
5944709e
PE
44862012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4487
4488 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4489
e71f5d99
EZ
44902012-01-11 Eli Zaretskii <eliz@gnu.org>
4491
4492 * xdisp.c (rows_from_pos_range): Handle the case where the
4493 highlight ends on a newline. (Bug#10464)
4494 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4495 he end column for display of highlight that ends on a newline
4496 before a R2L line.
4497
ce316182
GM
44982012-01-11 Glenn Morris <rgm@gnu.org>
4499
4500 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4501 from load-path also when installation-directory is nil. (Bug#10208)
4502
5b43da69
GM
45032012-01-10 Glenn Morris <rgm@gnu.org>
4504
74cc8ff9
GM
4505 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4506
7d8d6e4e
GM
4507 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4508 Update template values to be closer to their typical values these days.
5b43da69 4509
a0db8d43
EZ
45102012-01-09 Eli Zaretskii <eliz@gnu.org>
4511
4512 * xdisp.c (rows_from_pos_range): Accept additional argument
4513 DISP_STRING, and accept any glyph in a row whose object is that
4514 string as eligible for mouse highlight. Fixes mouse highlight of
4515 display strings from overlays. (Bug#10464)
4516
9a0115ab 45172012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4518
b9110d6a 4519 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4520 * fileio.c (auto_saving_dir_umask): New static var.
4521 (Fmake_directory_internal): Use it.
4522 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4523 creating the directory. The old code temporarily assigns
4524 too-generous permissions to the directory.
4525 (do_auto_save_eh): Clear it.
b9110d6a 4526 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4527 that the var is always cleared.
4528
6c1bd3f3
EZ
45292012-01-07 Eli Zaretskii <eliz@gnu.org>
4530
4531 * search.c (scan_buffer): Pass character positions to
4532 know_region_cache, not byte positions. (Bug#6540)
4533
069d2b50
L
45342012-01-07 LynX <_LynX@bk.ru> (tiny change)
4535
4536 * w32.c (sys_rename): Report EXDEV when rename of a directory
4537 fails because the target is on another logical disk. (Bug#10284)
4538
75bf0d33
DB
45392012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4540
4541 * xterm.c (x_embed_request_focus): New function.
4542
4543 * xterm.h: Add prototype.
4544
4545 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4546
1c6e5a32
GM
45472012-01-05 Glenn Morris <rgm@gnu.org>
4548
4549 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4550
651e947e
EZ
45512012-01-01 Eli Zaretskii <eliz@gnu.org>
4552
4553 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4554 Load gnutls_transport_set_lowat only if GnuTLS version is below
4555 2.11.1.
4556 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4557 GnuTLS versions below 2.11.1.
4558
3778cdd8
AL
45592011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4560
4561 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4562 to the doc string advising against its use for altering the way
4563 windows are scrolled.
4564
0e5317f7
KH
45652011-12-28 Kenichi Handa <handa@m17n.org>
4566
4567 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4568 coding-system ASCII compatible only when it does not produce BOM
4569 on encoding (Bug#10383).
4570
93d5ca1f
JD
45712011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4572
4573 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4574 can scroll.
4575 (create_and_show_popup_menu): Always use menu_position_func for
4576 Gtk3 (Bug#10361).
4577
ca22b785
AS
45782011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4579
4580 * callint.c (Fcall_interactively): Don't truncate prompt string.
4581
d048e1e6
EZ
45822011-12-23 Eli Zaretskii <eliz@gnu.org>
4583
4584 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4585 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4586 resumed from there (after widening). (Bug#10360)
d048e1e6 4587
5ccaba1f
JD
45882011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4589
4590 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4591
204ee57f
JD
45922011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4593
b81d40f0
JB
4594 * nsterm.m (x_free_frame_resources):
4595 Release f->output_data.ns->miniimage.
204ee57f
JD
4596 (ns_index_color): Fix indentation. Do not retain
4597 color_table->colors[i].
4598
4599 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4600 before returning.
4601
4602 * nsfns.m (x_set_background_color): Assign return value from
4603 ns_index_color to face-background instead of NSColor*.
4604 (ns_implicitly_set_icon_type): Fix indentation.
4605 Change assignment in for loop to comparison.
4606
4607 * emacs.c (ns_pool): New variable.
4608 (main): Assign ns_pool.
4609 (Fkill_emacs): Call ns_release_autorelease_pool.
4610
4611 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4612 autorelease fdesc, release fdAttrs and tdict.
4613 (ns_get_covering_families): Release charset.
4614 (ns_findfonts): Release NSFontDescriptor created with new.
4615 (ns_uni_to_glyphs): Fix indentation.
4616 (setString): Release attrStr before assigning new value.
4617
c803b2b7
JD
46182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4619
678f4426
JD
4620 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4621 and NS_IMPL_COCOA.
4622 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4623 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4624
cd394be1 46252011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4626
5fecd5fc
JD
4627 * nsterm.m (ns_term_init): Subscribe for notifications
4628 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4629 to method trackingNotification in EmacsMenu.
4630
4631 * nsmenu.m (trackingMenu): New variable.
3771cb17 4632 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4633 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4634 from Aquamacs (Bug#7030).
678f4426
JD
4635
46362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4637
c803b2b7
JD
4638 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4639 (symbol_to_nsstring): Fix indentation.
4640 (ns_symbol_to_pb): New function.
cae07000
SM
4641 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4642 (Fns_rotate_cut_buffers_internal): Remove.
4643 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4644 Fns_store_cut_buffer_internal.
4645 (ns_get_foreign_selection, Fx_own_selection_internal)
4646 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4647 (Fns_get_selection_internal, Fns_store_selection_internal):
4648 Use ns_symbol_to_pb and check if return value is nil.
4649 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4650 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4651 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4652 renamed to Sns_store_selection_internal.
4653 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4654 and remove this function.
4655 (ns_handle_selection_clear): Remove, never used.
4656 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4657 here.
4658
e1b01a3a
KB
46592011-12-17 Ken Brown <kbrown@cornell.edu>
4660
4661 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4662 GID is unknown (Bug#10257).
4663
2adb6e85
PE
46642011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4665
4666 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4667 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4668 which caused a build failure on GNU/Linux IA-64. This problem was
4669 introduced by my 2011-10-07 patch.
4670
d1d7b339
JL
46712011-12-15 Juri Linkov <juri@jurta.org>
4672
4673 * image.c (imagemagick_error): New function. (Bug#10112)
4674 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4675 Use `imagemagick_error' where ImageMagick functions return
4676 `MagickFalse'.
4677 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4678 proper order.
4679
100d5755
KH
46802011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4681
4682 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4683 fill background (Bug#8992).
4684
454592a6
MR
46852011-12-13 Martin Rudalics <rudalics@gmx.at>
4686
4687 * window.c (Vwindow_combination_resize)
4688 (Vwindow_combination_limit): Use t instead of non-nil in
4689 doc-strings.
61d4b438
MR
4690 (Vrecenter_redisplay): Add first sentence of doc-string on
4691 separate line.
53524d93 4692 (Frecenter): Fix doc-string typo.
454592a6 4693
3633e3aa
KH
46942011-12-11 Kenichi Handa <handa@m17n.org>
4695
4696 * coding.c (Funencodable_char_position): Pay attention to the
4697 buffer text relocation (Bug#9389).
4698
7b9d523a 46992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4700
7b9d523a
JD
4701 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4702 gtk_init (Bug#10100).
4703
b73189c6
EZ
47042011-12-10 Eli Zaretskii <eliz@gnu.org>
4705
4706 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4707 IT->string is nil. (Bug#10263)
4708
f7dfe5d6
JD
47092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4710
83faebb4
JD
4711 * nsterm.h (x_free_frame_resources): Declare.
4712
f7dfe5d6
JD
4713 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4714 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4715
4716 * nsterm.h (ns_get_defaults_value): Declare.
4717
4718 * nsterm.m (ns_default): Call ns_get_defaults_value.
4719
7cd4e72c
EZ
47202011-12-09 Eli Zaretskii <eliz@gnu.org>
4721
4722 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4723 (Bug#10170)
4724
b34d7317
YM
47252011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4726
4727 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4728 that where the value of an _OBJC_* symbol points to is in the .bss
4729 section (Bug#10240).
4730
76470ad1
KH
47312011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4732
4733 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4734 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4735
745fff94
KH
47362011-12-08 Kenichi Handa <handa@m17n.org>
4737
4738 * ftfont.c (get_adstyle_property): Fix previous change
4739 (Bug#10233).
4740
6e44397c
JB
47412011-12-07 Juanma Barranquero <lekktu@gmail.com>
4742
4743 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4744 dirs from the default value of EMACSLOADPATH (bug#10208).
4745
7efa6272
GM
47462011-12-07 Glenn Morris <rgm@gnu.org>
4747
4748 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4749 installation and source directories as well. (Bug#10208)
4750
f6fc4d87
CY
47512011-12-06 Chong Yidong <cyd@gnu.org>
4752
4753 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4754
2bf26180
GM
47552011-12-06 Glenn Morris <rgm@gnu.org>
4756
4757 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4758 as an error, not just -1. (Bug#10217)
4759
3a6ad4f0
CY
47602011-12-05 Chong Yidong <cyd@gnu.org>
4761
4762 * keyboard.c (process_special_events): New function.
4763 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4764
75a3b399
PE
47652011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * coding.c (encode_designation_at_bol): Don't use uninitialized
4768 local variable (Bug#9318).
4769
c3c9e25e
KH
47702011-12-05 Kenichi Handa <handa@m17n.org>
4771
4772 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4773 return Qnil (Bug#8046, Bug#10193).
4774
5eb05ea3
KH
47752011-12-05 Kenichi Handa <handa@m17n.org>
4776
4777 * coding.c (encode_designation_at_bol): New args charbuf_end and
4778 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4779 (coding_set_source): Return how many bytes coding->source was
4780 relocated.
4781 (coding_set_destination): Return how many bytes
4782 coding->destination was relocated.
4783 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4784 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4785
47862011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4787
4788 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4789 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4790 macro (Bug#9318).
4791
47922011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4793
4794 The following changes are to fix Bug#9318.
4795
a79703f5 4796 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4797 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4798 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4799 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4800
7dbda6df
JB
48012011-12-05 Juanma Barranquero <lekktu@gmail.com>
4802
4803 * lisp.h (process_quit_flag): Fix external declaration.
4804
6d5eb5b0
SM
48052011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4806
4807 Don't macro-inline non-performance-critical code.
4808 * eval.c (process_quit_flag): New function.
4809 * lisp.h (QUIT): Use it.
4810
a0c3fad0
JD
48112011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4812
4813 * nsfns.m (get_geometry_from_preferences): New function.
4814 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4815
6c07aac2
AS
48162011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4817
4818 * emacs.c (Qkill_emacs): Define.
4819 (syms_of_emacs): Initialize it.
4820 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4821 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4822 (quit_throw_to_read_char): Add parameter `from_signal'.
4823 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4824 * lisp.h (QUIT): Call Fkill_emacs if requested.
4825
c052ead4
JD
48262011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4827
4828 * widget.c (update_wm_hints): Return if wmshell is null.
4829 (widget_update_wm_size_hints): New function.
4830
4831 * widget.h (widget_update_wm_size_hints): Declare.
4832
4833 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4834 widget_update_wm_size_hints (Bug#10104).
4835
9e49252b
EZ
48362011-12-03 Eli Zaretskii <eliz@gnu.org>
4837
4838 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4839 before a newline, prepare the bidi iterator for consuming the
4840 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4841 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4842
02b16839
JL
48432011-12-02 Juri Linkov <juri@jurta.org>
4844
4845 * search.c (Fword_search_regexp): New Lisp function created from
4846 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4847 (Fword_search_backward, Fword_search_forward)
4848 (Fword_search_backward_lax, Fword_search_forward_lax):
4849 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4850 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4851
0068070e
SM
48522011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4853
4854 * fileio.c (Finsert_file_contents): Move after-change-function call
4855 to before the "handled:" label, since all "goto handled" appear in
4856 cases where the *-change-functions have already been properly called
4857 (bug#10117).
4858
3360a3fc
AS
48592011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4860
4861 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4862 waiting for input. (Bug#10169)
4863
73d6c093
EZ
48642011-11-30 Eli Zaretskii <eliz@gnu.org>
4865
4866 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4867 verifies glyph row's hash code--we have just reallocated the
4868 glyphs, so their contents can be complete garbage. (Bug#10164)
4869
febe6bea
JB
48702011-11-30 Juanma Barranquero <lekktu@gmail.com>
4871
4872 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4873
801a4313
EZ
48742011-11-30 Eli Zaretskii <eliz@gnu.org>
4875
4876 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4877 attributes are tested _before_ calling verify_row_hash, to protect
4878 against GCC re-ordering of the tests. (Bug#10164)
4879
2b56b87e
JD
48802011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4881
4882 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4883
4884 * xterm.c (handle_one_xevent): Only set async_visible and friends
4885 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4886 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4887 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4888
dbf31225
PE
48892011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4892 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4893 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4894 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4895 All uses changed to use GCPRO1 etc.
4896 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4897 Revert to old implementation (i.e., before 2011-03-11).
4898
1305621b
YM
48992011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4900
4901 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4902 of scroll runs so as to avoid assigning disabled bogus rows and
4903 unnecessary graphics copy operations.
4904
8c9afb46
EZ
49052011-11-27 Eli Zaretskii <eliz@gnu.org>
4906
4907 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4908 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4909 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4910 (malloc, free, realloc, calloc): Redirect to e_* only when
4911 compiling Emacs.
4912
4913 * lisp.h (GCTYPEBITS): Move before first use.
4914 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4915 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4916 this macro definition.
4917
4918 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4919 _MSC_VER.
4920
54e9e3bf
JD
49212011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4922
6d5eb5b0
SM
4923 * gtkutil.c (xg_create_frame_widgets):
4924 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4925 present with Gtk+ 2.0.
4926
83aca1cb
PE
49272011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4928
4929 * fileio.c (Finsert_file_contents): Undo previous change; see
4930 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4931
5b76caa4
PE
49322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4933
4934 Rename locals to avoid shadowing.
4935 * fileio.c (Finsert_file_contents):
4936 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4937 * process.c (wait_reading_process_output):
4938 Rename inner 'proc' to 'p' to avoid shadowing.
4939 Indent for consistency with usual Emacs style.
4940
8c535114
EZ
49412011-11-25 Eli Zaretskii <eliz@gnu.org>
4942
4943 * xdisp.c (redisplay_window): If cursor row is not fully visible
4944 after recentering, and scroll-conservatively is set to a large
4945 number, scroll window by a few more lines to make the cursor fully
4946 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4947 (start_display): Don't move to the next line if the display should
4948 start at a newline that is part of a display vector or an overlay
4949 string. (Bug#10119)
8c535114 4950
fa4fdb5c
JL
49512011-11-24 Juri Linkov <juri@jurta.org>
4952
4953 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4954 after the `MagickPingImage' call. (Bug#10112)
4955
90ec88df
CY
49562011-11-23 Chong Yidong <cyd@gnu.org>
4957
4958 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4959
56e2e794
MR
49602011-11-23 Martin Rudalics <rudalics@gmx.at>
4961
4962 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4963 making another buffer current. (Bug#10114)
4964
b6e64c41
GM
49652011-11-23 Glenn Morris <rgm@gnu.org>
4966
4967 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4968
6b21de18
CY
49692011-11-23 Chong Yidong <cyd@gnu.org>
4970
4971 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4972 using it (Bug#5984).
4973
b12cd789
EZ
49742011-11-22 Eli Zaretskii <eliz@gnu.org>
4975
4976 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4977 and header-lines, as they don't have one computed for them.
4978 (Bug#10098)
4979
4980 * .gdbinit (prow): Make displayed values more self-explaining.
4981 Add row's hash code.
4982
261b6fd4
LMI
49832011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4984
4985 * process.c (wait_reading_process_output): Fix asynchrounous
4986 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4987 (wait_reading_process_output): Add comment and URL.
261b6fd4 4988
e7cfd277
JD
49892011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4990
4991 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4992
a9b9b7f5
CY
49932011-11-21 Chong Yidong <cyd@gnu.org>
4994
4995 * window.c (Fnext_window, Fprevious_window): Doc fix.
4996
b0d15b4f
SM
49972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4998
4999 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5000
fe7a3057
JB
50012011-11-20 Juanma Barranquero <lekktu@gmail.com>
5002
5003 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5004
d2999b1a
MR
50052011-11-20 Martin Rudalics <rudalics@gmx.at>
5006
5007 * window.c (Fset_window_combination_limit): Rename argument
5008 STATUS to LIMIT.
5009 (Vwindow_combination_limit): Remove "status" from doc-string.
5010
d5ff9cd0
AS
50112011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5012
5013 * m/ibms390.h: Remove.
5014 * m/ibms390x.h: Don't include "ibms390.h".
5015
a5bb9bd3
SM
50162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5017
5018 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5019 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5020
cd1181db
JB
50212011-11-20 Juanma Barranquero <lekktu@gmail.com>
5022
5023 * casetab.c (Fset_case_table):
5024 * charset.c (Fcharset_after): Fix typos.
5025
615a3b8d 50262011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5027
17e845af
PE
5028 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5029 Otherwise, valgrind does not work on some platforms.
5030 Problem reported by Andreas Schwab in
6a0bf43d
PE
5031 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5032 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5033 is set, removing the need for VIRT_ADDRESS_VARIES.
5034 (PURE_P): Use a more-efficient implementation that needs just one
5035 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5036 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5037 to 4 (xorl, subq, cmpq, setbe).
5038 * alloc.c (pure): Always extern now, since that's the
5039 VIRT_ADDR_VARIES behavior.
5040 (PURE_POINTER_P): Use a single comparison, not two, for
5041 consistency with the new puresize.h.
5042 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5043 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5044 Remove VIRT_ADDR_VARIES no longer needed.
5045
f8fe6f96
EZ
50462011-11-19 Eli Zaretskii <eliz@gnu.org>
5047
5048 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5049 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5050 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5051 behave as if the cursor position were at the window margin.
5052
5053 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5054 and the cursor position is out of bounds, behave as if the cursor
5055 position were at the window margin. (Bug#10075)
5056
df05a53c
CY
50572011-11-18 Chong Yidong <cyd@gnu.org>
5058
5059 * window.c (Fwindow_combination_limit): Make first argument
5060 non-optional, since it is meaningless for live windows like the
5061 selected window.
61ccba97 5062
2071918e
DA
50632011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5064
5065 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5066
b50a28de
SM
50672011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5068
5069 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5070 (graft_intervals_into_buffer): Simplify.
5071
015137db
EZ
50722011-11-18 Eli Zaretskii <eliz@gnu.org>
5073
5074 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5075 hash values of the two rows.
5076 (copy_row_except_pointers): Preserve the used[] arrays and the
5077 hash values of the two rows. (Bug#10035)
68c95424 5078 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5079
5080 * xdisp.c (row_hash): New function, body extracted from
5081 compute_line_metrics.
5082 (compute_line_metrics): Call row_hash, instead of computing the
5083 hash code inline.
5084
5085 * dispnew.c (verify_row_hash): Call row_hash for computing the
5086 hash code of a row, instead of duplicating code from xdisp.c.
5087
5088 * dispextern.h (row_hash): Add prototype.
5089
a2addb04
TH
50902011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5091
5092 * frame.c (delete_frame): Don't delete the terminal when the last
5093 X frame is closed if emacs is built with GTK toolkit.
5094
df85d315
JB
50952011-11-17 Juanma Barranquero <lekktu@gmail.com>
5096
5097 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5098
a0c2d0ae
MR
50992011-11-17 Martin Rudalics <rudalics@gmx.at>
5100
5101 * window.c (Vwindow_splits): Rename to
5102 Vwindow_combination_resize. Suggested by Juri Linkov.
5103 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5104 of Vwindow_splits.
5105
58179cce
JB
51062011-11-16 Juanma Barranquero <lekktu@gmail.com>
5107
7877f373
JB
5108 * nsfns.m (Fns_font_name):
5109 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5110
b6f67890
MR
51112011-11-16 Martin Rudalics <rudalics@gmx.at>
5112
5113 * window.h (window): Rename slot "nest" to "combination_limit".
5114 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5115 (Fset_window_nest): Rename to Fset_window_combination_limit.
5116 (Vwindow_nest): Rename to Vwindow_combination_limit.
5117 (recombine_windows, make_parent_window, make_window)
5118 (Fsplit_window_internal, saved_window)
5119 (Fset_window_configuration, save_window_save): Rename all
5120 occurrences of window_nest to window_combination_limit.
5121
c7015153
JB
51222011-11-15 Juanma Barranquero <lekktu@gmail.com>
5123
5124 * image.c (imagemagick_load_image): Fix typo.
5125
322ad6ec
EZ
51262011-11-14 Eli Zaretskii <eliz@gnu.org>
5127
5128 * xdisp.c (display_line): Move the call to
5129 highlight_trailing_whitespace before the call to
5130 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5131 faces of all the glyphs to compute ROW's hash value.
5132 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5133
f067b8ec
JB
51342011-11-14 Juanma Barranquero <lekktu@gmail.com>
5135
5136 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5137 just return (bug#10044).
5138
1e5b2111
EZ
51392011-11-12 Eli Zaretskii <eliz@gnu.org>
5140
7ef3cbd5
EZ
5141 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5142 with user-defined heap size. Bump the default size of the temacs
5143 heap to 27MB, to avoid memory warning when running temacs.
5144 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5145
1e5b2111
EZ
5146 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5147 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5148 (verify_row_hash) [XASSERTS]: New function.
5149 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5150 that the hash value of glyph rows is correct.
1e5b2111 5151
89d61221
MR
51522011-11-12 Martin Rudalics <rudalics@gmx.at>
5153
5154 * window.h (window): Remove splits slot.
5155 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5156 (Fdelete_other_windows_internal, make_parent_window)
5157 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5158 (Fset_window_configuration, save_window_save): Don't deal with
5159 split status of windows.
5160 (saved_window): Remove splits slot.
5161 (Vwindow_splits): Rewrite doc-string.
5162
97f18cc8
JD
51632011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5164
5165 * xfns.c (unwind_create_frame):
5166 * nsfns.m (unwind_create_frame):
5167 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5168 Vframe_list (Bug#9999).
5169
22a648b4
DA
51702011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5171
0b381c7e 5172 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5173
659afede
KH
51742011-11-11 Kenichi Handa <handa@m17n.org>
5175
5176 * callproc.c (Fcall_process): Set the member dst_multibyte of
5177 process_coding.
5178
9ac0394b
KH
51792011-11-11 Johan Bockgård <bojohan@gnu.org>
5180
5181 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5182 avoid a crash (bug#9496).
5183
2fbdc249
CY
51842011-11-09 Chong Yidong <cyd@gnu.org>
5185
5186 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5187 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5188
ac6b1f81
PE
51892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5190
5191 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5192
09db192c
PE
51932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 Avoid some portability problems by eschewing 'extern inline' functions.
5196 The trivial performance wins aren't worth the portability hassles; see
5197 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5198 et seq.
5199 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5200 (window_box_width, window_box_left, window_box_left_offset)
5201 (window_box_right, window_box_right_offset): Undo previous change,
5202 by removing the "extern"s.
5203 * intervals.c (adjust_intervals_for_insertion)
5204 (adjust_intervals_for_deletion): Undo previous change,
5205 making these static again.
5206 (offset_intervals, temp_set_point_both, temp_set_point)
5207 (copy_intervals_to_string): No longer inline.
5208 * xdisp.c (window_text_bottom_y, window_box_width)
5209 (window_box_height, window_box_left_offset)
5210 (window_box_right_offset, window_box_left, window_box_right)
5211 (window_box): No longer inline.
5212
105216ed
CY
52132011-11-08 Chong Yidong <cyd@gnu.org>
5214
5215 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5216 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5217 Signal an error if not a live window.
105216ed
CY
5218 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5219 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5220
ae9e237f
JB
52212011-11-07 Juanma Barranquero <lekktu@gmail.com>
5222
5223 * lisp.h (syms_of_abbrev): Remove declaration.
5224 Reported by CHENG Gao <chenggao@royau.me>.
5225
c7aa8333
EZ
52262011-11-07 Eli Zaretskii <eliz@gnu.org>
5227
5228 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5229 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5230 of temacs in GUI mode.
5231
be7f5545
MR
52322011-11-07 Martin Rudalics <rudalics@gmx.at>
5233
5234 * window.h: Declare delete_all_child_windows instead of
5235 delete_all_subwindows.
5236 * window.c (Fwindow_nest, Fset_window_nest)
5237 (Fset_window_new_total, Fset_window_new_normal)
5238 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5239 (delete_all_subwindows): Rename to delete_all_child_windows.
5240 (Fdelete_other_windows_internal, Fset_window_configuration):
5241 Call delete_all_child_windows instead of delete_all_subwindows.
5242 * frame.c (delete_frame): Call delete_all_child_windows instead
5243 of delete_all_subwindows.
5244
ca78dc43
PE
52452011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5248 This is also needed for porting to any host where GC_MARK_STACK is
5249 not GC_MAKE_GCPROS_NOOPS.
5250 (which_symbols): Use it.
5251
a0241d01
KH
52522011-11-07 Kenichi Handa <handa@m17n.org>
5253
5254 * coding.c (coding_set_destination): Check coding->src_pos only
5255 when coding->src_object is a buffer (bug#9910).
5256
5257 * process.c (send_process): Set the member src_multibyte of coding
5258 to 0 (bug#9911) when sending a unibyte text.
5259
5260 * callproc.c (Fcall_process): Set the member src_multibyte of
5261 process_coding to 0 (bug#9912).
5262
a64bfdfa 52632011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5264
5265 * xmenu.c (cleanup_widget_value_tree): New function.
5266 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5267 calling free_menubar_widget_value_tree directly (Bug#9830).
5268
cb41b32a
PE
52692011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5270
5271 Fix some portability problems with 'inline'.
5272 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5273 (window_box_width, window_box_left, window_box_left_offset)
5274 (window_box_right, window_box_right_offset): Declare extern.
5275 Otherwise, these inline functions do not conform to C99 and
5276 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5277 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5278 * intervals.c (adjust_intervals_for_insertion)
5279 (adjust_intervals_for_deletion): Now extern, because otherwise the
5280 extern inline functions 'offset_intervals' couldn't refer to it.
5281 (static_offset_intervals): Remove.
5282 (offset_intervals): Rewrite using the old contents of
5283 static_offset_intervals. The old version didn't conform to C99
5284 because an extern inline function contained a reference to an
5285 identifier with static linkage.
5286
b7041366
AS
52872011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5288
5289 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5290 GC.
5291
88a37c4d
EZ
52922011-11-06 Eli Zaretskii <eliz@gnu.org>
5293
5294 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5295 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5296 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5297 return Qleft_to_right.
5298
49745b39
CY
52992011-11-06 Chong Yidong <cyd@gnu.org>
5300
5301 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5302 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5303 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5304 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5305 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5306 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5307 (Fwindow_vscroll): Doc fix.
5308 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5309 argument, since it makes no sense to pass a live window and for
5310 consistency with window-child.
5311
1f05cd82
CS
53122011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5313
5314 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5315 support MSVC.
5316
22610910
JR
53172011-11-05 Jason Rumney <jasonr@gnu.org>
5318
5319 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5320 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5321 fonts (Bug#6029).
5322 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5323 bitwise arithmetic preventing use of unicode-sip and non-truetype
5324 opentype fonts.
5325
a06776b2
EZ
53262011-11-05 Eli Zaretskii <eliz@gnu.org>
5327
3ad924ba
EZ
5328 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5329 "emacs"-only part.
5330
a06776b2
EZ
5331 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5332 initialization code to keep similarity to xfns.c after changes
5333 from 2011-11-05.
5334
c9e7db78
JD
53352011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5336
a97f8f3f
JD
5337 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5338 (unwind_create_frame): New function (Bug#9943).
5339 (Fx_create_frame): Restructure code to be more similar to the one in
5340 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5341 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5342 Move terminal->reference_count++ just before making the frame official
5343 (Bug#9943).
5344
5345 * nsterm.m (x_free_frame_resources): New function.
5346 (x_destroy_window): Move code to x_free_frame_resources.
5347
c9e7db78 5348 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5349 (Fx_create_frame, x_create_tip_frame):
5350 Move terminal->reference_count++ just before making the frame
75f1671a 5351 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5352 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5353
a6fc3b5c
EZ
53542011-11-05 Eli Zaretskii <eliz@gnu.org>
5355
5356 Support MSVC build with newer versions of Visual Studio.
5357 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5358 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5359 nt/gmake.defs.
5360
5361 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5362 which are not supported by MSVC.
5363 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5364 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5365 bitfields.
5366 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5367 types in bitfields.
5368 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5369
5370 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5371
58179cce 53722011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5373
5374 Support MSVC build with newer versions of Visual Studio.
5375 * w32.c: Don't include w32api.h for MSVC.
5376 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5377
5378 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5379 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5380 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5381 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5382 e_* cousins.
5383 (alloca) [_MSC_VER]: Define to _alloca.
5384
5385 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5386
5387 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5388
a58c13ed
EZ
53892011-11-04 Eli Zaretskii <eliz@gnu.org>
5390
5391 * xdisp.c (note_mouse_highlight): If either of
5392 previous/next-single-property-change returns nil, treat that as
5393 the beginning or the end of the buffer. (Bug#9955)
5394
fe0b6370
JD
53952011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5396
a58c13ed 5397 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5398 label is not null (Bug#9951).
5399 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5400 may be NULL.
5401
89bd5ee1
EZ
54022011-11-04 Eli Zaretskii <eliz@gnu.org>
5403
5404 * window.c (Fwindow_body_size): Mention in the doc string that the
5405 return value is in frame's canonical units. (Bug#9949)
5406
84c3edb9
EZ
54072011-11-03 Eli Zaretskii <eliz@gnu.org>
5408
4e2fb5c7
EZ
5409 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5410
84c3edb9 5411 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5412 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5413 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5414
bc17a887
EZ
54152011-11-01 Eli Zaretskii <eliz@gnu.org>
5416
5417 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5418 Don't stop backward scan on the continuation glyph, even though
5419 its CHARPOS is positive.
6d5eb5b0
SM
5420 (mouse_face_from_buffer_pos, note_mouse_highlight):
5421 Rename cover_string to disp_string.
bc17a887 5422
4ee88440
MR
54232011-11-01 Martin Rudalics <rudalics@gmx.at>
5424
5425 * window.c (temp_output_buffer_show): Don't use
5426 Vtemp_buffer_show_specifiers.
5427 (Vtemp_buffer_show_specifiers): Remove unused variable.
5428
c2ff3c02
EZ
54292011-10-30 Eli Zaretskii <eliz@gnu.org>
5430
5431 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5432 past the beginning of the current glyph matrix.
5433
58179cce 54342011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5435
5436 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5437 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5438 HAVE_GTK3 (Bug#9869).
b77a6a7f 5439
3b574623
JD
5440 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5441 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5442
b77a6a7f
JD
5443 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5444
5445 * xterm.c: Declare x_handle_net_wm_state to return int.
5446 (handle_one_xevent): Check if we are iconified but don't have
5447 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5448 (get_current_wm_state): Return non-zero if not hidden,
5449 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5450 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5451 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5452 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5453
196e41e4
PE
54542011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5455
5456 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5457 so that this new function doesn't get optimized away by a
5458 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5459
021f2e1a
AS
54602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5461
5462 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5463
8b058d44
EZ
54642011-10-29 Eli Zaretskii <eliz@gnu.org>
5465
5466 Fix the `xbytecode' command.
5467 * .gdbinit (xprintbytestr): New command.
b50a28de 5468 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5469 (xbytecode): Print the byte-code string as well.
5470
4452fb80
EZ
54712011-10-29 Kim Storm <storm@cua.dk>
5472
8b058d44
EZ
5473 * alloc.c (which_symbols): New function.
5474
21b72067
AS
54752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5476
5477 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5478 line. (Bug#9903)
5479
83ed7b5c
GM
54802011-10-29 Glenn Morris <rgm@gnu.org>
5481
5482 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5483 Not clear what it was for, and it causes various bugs. (Bug#9839)
5484
5a7a728b
EZ
54852011-10-28 Eli Zaretskii <eliz@gnu.org>
5486
5487 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5488 possible random value that matches one of those tested as
5489 condition to clear the mouse face.
5490
d3d0842f
CY
54912011-10-28 Chong Yidong <cyd@gnu.org>
5492
5493 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5494
31b39d13
DN
54952011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5496
5497 * window.c (make_window): Initialize phys_cursor_on_p.
5498
9aba6043
SM
54992011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5500
5501 * lisp.h (struct Lisp_Symbol): Update comments.
5502
c20992f4
JB
55032011-10-28 Juanma Barranquero <lekktu@gmail.com>
5504
5505 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5506
db4f02f2
EZ
55072011-10-28 Eli Zaretskii <eliz@gnu.org>
5508
5509 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5510 <oslsachem@gmail.com> for helping to debug this.
5511
5512 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5513 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5514 (g_b_init_get_glyph_outline_w): New static variables.
5515 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5516 (GetGlyphOutlineW_Proc): New typedefs.
5517 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5518 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5519 New functions.
5520 (w32font_open_internal, compute_metrics):
5521 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5522 instead of calling the "wide" APIs directly.
5523
5524 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5525
5526 * w32.h (syms_of_w32font): Add prototype.
5527
87e68db4
JB
55282011-10-27 Juanma Barranquero <lekktu@gmail.com>
5529
5530 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5531 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5532 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5533 (Fmove_to_window_line): Doc fix.
5534
435c1d67
CY
55352011-10-27 Chong Yidong <cyd@gnu.org>
5536
5537 * process.c (make_process): Set gnutls_state to NULL.
5538
5539 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5540 non-NULL, regardless of GNUTLS_INITSTAGE.
5541 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5542 an error. Set process slots as soon as we allocate them.
5543
5544 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5545
9c6c6f49
CY
55462011-10-27 Chong Yidong <cyd@gnu.org>
5547
9aba6043
SM
5548 * gnutls.c (emacs_gnutls_deinit): New function.
5549 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5550 (Fgnutls_deinit, Fgnutls_boot): Use it.
5551
5552 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5553 (deactivate_process): Call emacs_gnutls_deinit.
5554
657d08d3
JB
55552011-10-27 Juanma Barranquero <lekktu@gmail.com>
5556
5557 * image.c (x_create_x_image_and_pixmap):
5558 * w32.c (sys_rename, w32_delayed_load):
5559 * w32font.c (fill_in_logfont):
5560 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5561
5430d399
JB
55622011-10-26 Juanma Barranquero <lekktu@gmail.com>
5563
5564 * w32fns.c (w32_default_color_map): New function,
5565 extracted from Fw32_default_color_map.
a7ef684b 5566 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5567
fe0055fa
PE
55682011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5569
5570 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5571
e6346438
SM
55722011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5573
5574 * keyboard.c (test_undefined): New function (bug#9751).
5575 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5576
e112cc37
ET
55772011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5578
5579 * sysdep.c (init_sys_modes): Fix the check for the controlling
5580 terminal (Bug#6649).
5581
7b5d6677
EZ
55822011-10-20 Eli Zaretskii <eliz@gnu.org>
5583
5584 * dispextern.h (struct bidi_it): New member next_en_type.
5585
5586 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5587 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5588 current character, check also for next_en_type being WEAK_EN.
5589 (bidi_resolve_weak): Don't enter the expensive loop if the current
5590 position is before next_en_pos. Record the bidi type of the first
5591 non-ET, non-BN character we find, in addition to its position.
5592 (bidi_level_of_next_char): Invalidate next_en_type when
5593 next_en_pos is over-stepped.
5594
7da0b018
PE
55952011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5596
5597 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5598 * editfns.c: Rewrite current-time-zone so that it invokes
5599 the equivalent of (format-time-string "%Z") to get the time zone name.
5600 This fixes a bug when the time zone name contains characters that
5601 need converting from the system time locale to Emacs internal format.
5602 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5603 that patch fixed format-time-string to do the conversion, but
5604 I forgot to fix current-time-zone.
5605 (format_time_string): New function, containing most of
5606 what Fformat_time_string used to contain.
5607 (Fformat_time_string): Rewrite in terms of format_time_string.
5608 This doesn't change this function's behavior.
5609 (current-time-zone): Rewrite to use format_time_string.
5610 This fixes the bug reported by Michael Schierl in
5611 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5612 Jason Rumney's 2007-06-07 change worked around this bug, but
5613 didn't fix it.
5614 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5615
8547b010
EZ
56162011-10-19 Eli Zaretskii <eliz@gnu.org>
5617
5618 * xdisp.c (start_display): If the character at POS is displayed
5619 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5620 (try_window_reusing_current_matrix): If a line ends in a display
5621 vector or the next line starts in a display vector, continue
5622 redrawing the window even though the character position of
5623 start_row was reached.
8547b010
EZ
5624 (Bug#9771, part 2)
5625
4e948d15
CY
56262011-10-18 Chong Yidong <cyd@gnu.org>
5627
5628 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5629 with nobreak-char-display too.
5630
4787455f
EZ
56312011-10-18 Eli Zaretskii <eliz@gnu.org>
5632
5633 Fix part 3 of bug#9771.
5634 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5635 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5636 non-neutral characters if the current character is a paragraph
5637 separator (a.k.a. Newline). This avoids running the same
5638 expensive loop twice, once when we consume the preceding newline
5639 and the other time when the line actually needs to be displayed.
5640 Avoid the loop when we see neutrals on the base embedding level
5641 following a character whose directionality is the same as the
5642 paragraph's. This avoids running the expensive loop when a line
5643 ends in a long sequence of neutrals, like control characters.
5644 Add assertion against STRONG_AL type. Slightly rearrange code
5645 that determines the type of a neutral given the first non-neutral
5646 that follows it.
5647 (bidi_level_of_next_char): Set next_en_pos to zero when
5648 invalidating its info.
5649
2c91f553
EZ
56502011-10-17 Eli Zaretskii <eliz@gnu.org>
5651
5652 * xdisp.c (push_display_prop): Determine whether to record string
5653 or buffer position by IT->string, not by IT->method. Allow
5654 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5655 (move_it_vertically_backward): Don't look for character position
5656 immediately after the newline when in a continuation line.
5657 (Bug#9771, part 1)
2c91f553 5658
c7b08b0d
MR
56592011-10-15 Martin Rudalics <rudalics@gmx.at>
5660
5661 * window.c (coordinates_in_window): Rewrite and delabelize
5662 vertical border check. (Bug#5357) (Bug#9618)
5663
6b02f655
SM
56642011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5665
5666 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5667 errors in XSetWindowBorder (bug#9310).
5668
81d40c92
DA
56692011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5670
5671 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5672 avoid crash when xmalloc overrun checking is enabled.
5673
d4172c3b
EZ
56742011-10-13 Eli Zaretskii <eliz@gnu.org>
5675
5676 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5677 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5678 cursor motion with <left> and <right> arrow keys.
5679
5680 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5681 some callers set that themselves.
5682
b00eea75
EZ
56832011-10-12 Eli Zaretskii <eliz@gnu.org>
5684
5685 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5686 display string and the previous row comes from the same string and
5687 is empty. (Bug#9739) (Bug#9738)
5688
8fe012c4
SM
56892011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5690
5691 * doc.c (get_doc_string): Encode file name (bug#9735).
5692
0074aef2
EZ
56932011-10-12 Eli Zaretskii <eliz@gnu.org>
5694
79beb178
EZ
5695 * bidi.c (bidi_level_of_next_char):
5696 * xdisp.c (get_visually_first_element): Remove old incorrect
5697 comments regarding the Unicode Line Separator character.
5698
0074aef2
EZ
5699 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5700
6e4b3fbe
DA
57012011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5702
5703 * alloc.c (Fgc_status): Do not access beyond zombies array
5704 boundary if nzombies > MAX_ZOMBIES.
5705 * alloc.c (dump_zombies): Add missing format specifier.
5706
0324f3af
PE
57072011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5708
b5525cac
PE
5709 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5710 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5711
0324f3af
PE
5712 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5713 Some packages use them to denote characters with modifiers.
5714
e9b5f888
AS
57152011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5716
5717 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5718 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5719 matching a pp-number. Rename parameter var to var1.
5720
127827c0
SM
57212011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5722
5723 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5724
c8fd3bd0
GM
57252011-10-08 Glenn Morris <rgm@gnu.org>
5726
5727 * callint.c (Fcall_interactively): Give a more explicit error for the
5728 'c' case with a non-character input. (Bug#8479)
5729
352ec8ff
EZ
57302011-10-08 Eli Zaretskii <eliz@gnu.org>
5731
03669ccb
EZ
5732 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5733 lines.
7061c986
EZ
5734 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5735 lines that are hscrolled on the left.
03669ccb 5736
352ec8ff
EZ
5737 * dispnew.c (buffer_posn_from_coords): Account for a possible
5738 presence of header-line. (Bug#4426)
5739
a66cfb1c
SM
57402011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5741
6b02f655
SM
5742 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5743 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5744
7c5ee88e
PE
57452011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5746
5747 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5748 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5749 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5750 this makes Emacs dump core during garbage collection on rare
5751 occasions. sizeof is obviously inferior to offsetof here, so
5752 stick with offsetof.
5753 (GC_POINTER_ALIGNMENT): New macro.
5754 (mark_memory): Omit 3rd (offset) arg; caller changed.
5755 Don't assume EMACS_INT alignment is the same as pointer alignment.
5756
df1bbe5b
SM
57572011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5758
5759 * keyboard.c (read_key_sequence_remapped): New var.
5760 (read_key_sequence): Compute remapping in the right buffer.
5761 (command_loop_1): Use read_key_sequence's remapping directly.
5762
51553db6
SM
57632011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5764
32c1fffd
SM
5765 * dired.c (file_name_completion): Don't expand file name.
5766 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5767 before checking file name handler.
5768
51553db6
SM
5769 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5770 they've been requested explicitly (bug#9591).
5771
b6bd1599 57722011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5773
5774 * keymap.c (Fsingle_key_description): Use make_specified_string
5775 instead of build_string to build string from push_key_description.
5776 (Bug#5193)
5777
f701dc2a
PE
57782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5779
4222c55d
PE
5780 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5781 This fixes a Y2038 bug on 64-bit hosts.
5782 * buffer.c (reset_buffer):
5783 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5784 (Fclear_buffer_auto_save_failure):
5785 Use 0, not -1, to represent an unset failure time, since time_t
5786 might not be signed.
5787
f701dc2a
PE
5788 Remove dependency on glibc malloc internals.
5789 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5790 Move back here from lisp.h, but with their new implementations.
5791 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5792 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5793 * charset.c (charset_table_init): New static var.
5794 (syms_of_charset): Use it instead of xmalloc. This removes a
5795 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5796 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5797 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5798 Move back to alloc.c.
5799 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5800 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5801
9ceebf39
JD
58022011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5803
5804 * nsterm.m (windowDidResize): Call x_set_window_size only when
5805 ns_in_resize is true. Otherwise set pixelwidth/height and
5806 call change_frame_size (Bug#9628).
5807
cb993c58
PE
58082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5809
3930c88b
PE
5810 Port --enable-checking=all to Fedora 14 x86-64.
5811 * charset.c (syms_of_charset): Also account for glibc malloc's
5812 internal overhead when calculating the initial malloc maximum.
5813
cb993c58
PE
5814 Port --enable-checking=all to Fedora 14 x86.
5815 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5816 Move to lisp.h.
5817 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5818 (overrun_check_realloc, overrun_check_free):
5819 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5820 That way, xmalloc returns a properly-aligned pointer even if
5821 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5822 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5823 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5824 into account when calculating the initial malloc maximum.
5825 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5826 Move here from alloc.c, so that charset.c can use it too.
5827 Properly align; the old code wasn't right for common 32-bit hosts
5828 when configured with --enable-checking=all.
5829 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5830 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5831
31bed486
EZ
58322011-09-29 Eli Zaretskii <eliz@gnu.org>
5833
04c70788 5834 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5835 use EDOM.
5836
fbcaa2f3
EZ
58372011-09-28 Eli Zaretskii <eliz@gnu.org>
5838
5839 * xdisp.c (compute_display_string_end): If there's no display
5840 string at CHARPOS, return -1.
5841
5842 * bidi.c (bidi_fetch_char): When compute_display_string_end
5843 returns a negative value, treat the character as a normal
5844 character not covered by a display string. (Bug#9624)
5845
a239d4e9
JB
58462011-09-28 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * lread.c (Fread_from_string): Fix typo in docstring.
5849
88652fd5
EZ
58502011-09-27 Eli Zaretskii <eliz@gnu.org>
5851
5852 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5853 newline, reseat the iterator instead of bidi-iterating there one
5854 character at a time. (Bug#9610)
32c1fffd
SM
5855 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5856 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5857
ed497dd4
AS
58582011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5859
5860 * lread.c (readevalloop): Use correct code for NBSP.
5861 (read1): Likewise. (Bug#9608)
5862
b2bf61aa
MA
58632011-09-25 Michael Albinus <michael.albinus@gmx.de>
5864
5865 * dbusbind.c (Fdbus_register_signal): When service is not
5866 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5867
32bbb17c
GM
58682011-09-25 Glenn Morris <rgm@gnu.org>
5869
5870 * buffer.c (truncate-lines): Doc fix.
5871
94e0933e
CY
58722011-09-24 Chong Yidong <cyd@stupidchicken.com>
5873
5874 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5875 (Fset_window_next_buffers): Doc fix.
5876
cddde921
GM
58772011-09-24 Glenn Morris <rgm@gnu.org>
5878
5879 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5880
1260aef1
PE
58812011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5882
25b4bfa0
PE
5883 Fix minor problems found by static checking.
5884 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5885 * indent.c (Fvertical_motion): Fix == vs = typo.
5886
e3cbd34b
EZ
58872011-09-24 Eli Zaretskii <eliz@gnu.org>
5888
a66cfb1c
SM
5889 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5890 Default value is now t. Doc fix.
6bf7006f 5891
e3cbd34b 5892 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5893 logic when moving up, not only when moving down. Fix the
e3cbd34b 5894 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5895 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5896
5897 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5898 CHARPOS is covered by a display string which includes newlines.
5899 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5900 is covered by a display string with embedded newlines.
5901
a3de0cbd
MA
59022011-09-24 Michael Albinus <michael.albinus@gmx.de>
5903
5904 * dbusbind.c (Fdbus_register_signal): Add match rule to
5905 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5906 (Fdbus_register_method, Vdbus_registered_objects_table):
5907 Fix docstring.
a3de0cbd 5908
b260039d
JM
59092011-09-24 Jim Meyering <meyering@redhat.com>
5910
32c1fffd 5911 do not ignore write error for any output size
b260039d
JM
5912 The previous change was incomplete.
5913 While it makes emacs --batch detect the vast majority of stdout
5914 write failures, errors were still ignored whenever the output size is
5915 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5916 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5917 && echo FAIL: ignored write error
5918 FAIL: ignored write error
5919 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5920 && echo FAIL: ignored write error
5921 FAIL: ignored write error
5922 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5923
8eca8a7c
AS
59242011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5925
5926 * emacs.c (Fkill_emacs): In noninteractive mode exit
5927 non-successfully if a write error occurred on stdout. (Bug#9574)
5928
3341db62
EZ
59292011-09-21 Eli Zaretskii <eliz@gnu.org>
5930
5931 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5932 the xassert test.
5933
5934 * dispextern.h (struct it): Update the comment documenting what
5935 can it->OBJECT be.
5936
8c203dbf
EZ
59372011-09-20 Eli Zaretskii <eliz@gnu.org>
5938
5939 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5940 a display string, extend search for cursor position to end of row.
5941 (find_row_edges): If the row ends in a newline from a display
5942 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5943 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5944 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5945 non-empty line. Fixes confusing cursor motion with arrow keys at
5946 the beginning of a line that starts with whitespace.
8c203dbf 5947
a4824228
LMI
59482011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5949
5950 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5951 (bug#9493).
5952
33ed493b
CY
59532011-09-18 Chong Yidong <cyd@stupidchicken.com>
5954
5955 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5956 boolean (Bug#9154).
5957
56cd55c8
EZ
59582011-09-18 Eli Zaretskii <eliz@gnu.org>
5959
5960 * xdisp.c (display_line): Record maximum and minimum buffer
5961 positions even if no glyphs were produced (e.g., by a zero-width
5962 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5963 buffer positions that will be removed from the glyph row because
5964 they don't fit.
c02dcedf
EZ
5965 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5966 column is beyond frame width: don't subtract 1 "pixel" when
5967 computing width of the stretch.
3e62b7e0
EZ
5968 (reseat_at_next_visible_line_start): Undo the change made on
5969 2011-09-17 that saved paragraph information and restored it after
5970 the call to `reseat'. (Bug#9545)
56cd55c8 5971
5ed99d36 59722011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5973
5974 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5975 and turn window cursor on if cleared (Bug#9415).
5976
5ed99d36 59772011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5978
5979 * search.c (boyer_moore): Take unibyte characters from pattern
5980 literally. (Bug#9458)
5981
9bade7b2
EZ
59822011-09-18 Eli Zaretskii <eliz@gnu.org>
5983
5984 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5985
e5e9d610
PE
59862011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5987
87e4427a
PE
5988 Fix minor problem found by static checking.
5989 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5990 initialized, to pacify gcc -Wuninitialized.
5991
e5e9d610
PE
5992 * fileio.c: Report proper errno when syscall falls.
5993 (Finsert_file_contents): Save and restore errno,
5994 so that report_file_error outputs the correct diagnostic.
5995 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5996
a1674f0b
EZ
59972011-09-18 Eli Zaretskii <eliz@gnu.org>
5998
5999 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6000
fbfb6dd4
EZ
60012011-09-17 Eli Zaretskii <eliz@gnu.org>
6002
6003 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6004 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6005
bb187662
EZ
60062011-09-17 Eli Zaretskii <eliz@gnu.org>
6007
1137e8b8 6008 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6009 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6010
6011 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6012 (bidi_find_paragraph_start): Search back for paragraph beginning
6013 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6014 (bidi_move_to_visually_next): Only trigger paragraph-related
6015 computations when the last character is a newline or at EOB, not
6016 just any NEUTRAL_B. (Bug#9470)
6017
bb187662
EZ
6018 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6019 truncated lines if point is covered by a display string. (Bug#9524)
6020
2e621251
PE
60212011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6024 (cons_to_x_long): New function.
6025 (lisp_data_to_selection_data): Use it. Correct the test for
6026 short-versus-long data; it was negated. Break out of vector
6027 loop, for efficiency, when a long datum is discovered.
6028
91a15bc6
SM
60292011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6030
6031 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6032
b41c3a35
EZ
60332011-09-16 Eli Zaretskii <eliz@gnu.org>
6034
6035 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6036 GCC PR/17406) by declaring this function with external scope.
6037
7812ba2d
PE
60382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6039
6040 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6041 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6042
cf7edc2a
AS
60432011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6044
6045 * editfns.c (Fformat): Correctly handle text properties on "%%".
6046
bd01620e
EZ
60472011-09-15 Eli Zaretskii <eliz@gnu.org>
6048
6049 * xterm.c (x_draw_composite_glyph_string_foreground):
6050 * w32term.c (x_draw_composite_glyph_string_foreground):
6051 * term.c (encode_terminal_code):
6052 * composite.c (composition_update_it, get_composition_id):
6053 * xdisp.c (get_next_display_element)
6054 (fill_composite_glyph_string): Add comments about special meaning
6055 of TAB characters in a composition.
6056
a02719a3
PE
60572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6058
6059 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6060 This occurs when processing a multibyte format.
6061 Problem reported by Wolfgang Jenker.
a02719a3 6062
72589a3c
JB
60632011-09-15 Johan Bockgård <bojohan@gnu.org>
6064
6065 * xdisp.c (try_cursor_movement): Only check for exact match if
6066 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6067
1c14176c
PE
60682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6069
6070 Remove unused external symbols.
6071 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6072 * xdisp.c (calc_pixel_width_or_height): Now static.
6073 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6074 * indent.c (check_display_width):
6075 * w32term.c: Fix comment to match code.
6076 * xterm.c, xterm.h (x_catching_errors): Remove.
6077
d2eea5b5
PE
60782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6079
6080 * xselect.c: Use signed conversions more consistently (Bug#9498).
6081 (selection_data_to_lisp_data): Assume incoming selection data are
6082 signed integers, not unsigned. This is to be consistent with
6083 outgoing selection data, which was modified to use signed integers
6084 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6085 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6086 expects long, not unsigned long.
6087
46888499
EZ
60882011-09-14 Eli Zaretskii <eliz@gnu.org>
6089
6090 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6091 computation of loop end. Reported by Johan Bockgård
6092 <bojohan@gnu.org>.
6093
ef8ef9fb
CY
60942011-09-13 Chong Yidong <cyd@stupidchicken.com>
6095
6096 * frame.c (Fother_visible_frames_p): Function deleted.
6097
fa819fed
EZ
60982011-09-12 Eli Zaretskii <eliz@gnu.org>
6099
6100 * indent.c (compute_motion): Process display vector front to back
6101 rather than the other way around. (Bug#2496)
6102
2ba8e008
SM
61032011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6104
6105 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6106
20f53c69
CY
61072011-09-11 Chong Yidong <cyd@stupidchicken.com>
6108
6109 * minibuf.c (Fread_from_minibuffer): Doc fix.
6110
d562d7a4
EZ
61112011-09-11 Eli Zaretskii <eliz@gnu.org>
6112
6113 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6114 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6115
1c4d7f3d
LMI
61162011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6117
6118 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6119 value for non-existent files.
6120
b885bf36
EZ
61212011-09-11 Eli Zaretskii <eliz@gnu.org>
6122
6123 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6124 set its "size" to -1. This will set the modtime_size field of
6125 the corresponding buffer to -1, which is what
6126 verify-visited-file-modtime expects for files that do not exist.
6127 (Bug#9139)
6128
6612f0bf
PE
61292011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6130
6131 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6132 here ...
6133 * lisp.h: ... from here. push_key_description is no longer
6134 defined in keyboard.c, so its declaration should not be in
6135 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6136 logically belongs with push_key_description.
6137
dfb3f755
PE
61382011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6139
6140 * buffer.h: Include <sys/types.h> instead of <time.h>.
6141 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6142 Problem reported by Herbert J. Skuhra.
6143
3134906c
LMI
61442011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6145
6146 * xml.c (parse_region): Make the parsing work for
6147 non-comment-starting XML files again (bug#9144).
6148
8d903f4e
AS
61492011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6150
6151 * image.c (gif_load): Fix calculation of bottom and right corner.
6152 (Bug#9468)
6153
80ad64f4
EZ
61542011-09-10 Eli Zaretskii <eliz@gnu.org>
6155
6156 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6157 redisplay in small windows.
6158
208a048d
EZ
61592011-09-09 Eli Zaretskii <eliz@gnu.org>
6160
6161 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6162
9b1c252e
MR
61632011-09-08 Martin Rudalics <rudalics@gmx.at>
6164
6165 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6166 Operate on live windows only.
6167
2949f33b
JB
61682011-09-08 Juanma Barranquero <lekktu@gmail.com>
6169
6170 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6171
e08dcafd
EZ
61722011-09-07 Eli Zaretskii <eliz@gnu.org>
6173
6174 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6175 only under bidi iteration.
6176
115b96bd
JD
61772011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6178
6179 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6180
c8199d0f
PE
61812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6182
6183 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6184 Without this fix, the command to link temacs failed due to an
6185 undefined symbol __builtin_isnan. This is because
6186 /usr/include/iso/math_c99.h #defines isnan(x) to
6187 __builtin_isnan(x), but the bundled gcc, which identifies itself
6188 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6189 a __builtin_isnan.
6190 * floatfns.c (isnan): #undef, and then #define to a clone of
6191 what's in data.c.
6192 (Fisnan): Always define, since it's always available now.
6193 (syms_of_floatfns): Always define isnan at the Lisp level.
6194
e39b275c 61952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6196
6197 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6198
b2db44d9 61992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6200
f4af5137 6201 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6202 The previous code assumed that file offsets (off_t values) fit in
6203 EMACS_INT variables, which is not true on typical 32-bit hosts.
6204 The code messed up by falsely reporting buffer overflow in cases
6205 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6206 when "big" contains more than 2**29 bytes, even though this
6207 inserts just one byte and does not overflow the buffer.
6208 (Finsert_file_contents): Store file offsets as off_t
6209 values, not as EMACS_INT values. Check for overflow when
6210 converting between EMACS_INT and off_t. When checking for
6211 buffer overflow or for overlap, take the offsets into account.
6212 Don't use EMACS_INT for small values where int suffices.
6213 When checking for overlap, fix a typo: ZV was used where
6214 ZV_BYTE was intended.
6215 (Fwrite_region): Don't assume off_t fits into 'long'.
6216 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6217
ecfc0a49
MA
62182011-09-05 Michael Albinus <michael.albinus@gmx.de>
6219
6220 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6221
6511acf2 62222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6223
0999621a 6224 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6225
6226 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6227 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6228 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6229 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6230 (modify_event_symbol): Do not assume that the length of
6231 name_alist_or_stem is safe to alloca and fits in int.
6232 (Fexecute_extended_command): Likewise for function name and binding.
6233 (Frecursion_depth): Wrap around reliably on integer overflow.
6234 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6235 since some callers pass EMACS_INT values.
6236 (Fsingle_key_description): Don't crash if symbol name contains more
6237 than MAX_ALLOCA bytes.
6238 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6239 (get_minibuffer): Arg is now EMACS_INT, not int.
6240 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6241 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6242 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6243
2be7d702
PE
6244 * dbusbind.c (signature_cat): New function.
6245 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6246 Do not overrun buffer; instead, report string overflow.
6247
9d1df220
PE
6248 * dispnew.c (add_window_display_history): Don't overrun buffer.
6249 Truncate instead; this is OK since it's just a log.
6250
33ef5c64
PE
6251 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6252 even if the time zone offset is outlandishly large.
6253 Don't mishandle offset == INT_MIN.
6254
66c6fdd5
PE
6255 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6256 when creating daemon; the previous buffer-overflow check was incorrect.
6257
d749b01b
PE
6258 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6259 which has the guts of the old verror function.
6260
b5cd1905
PE
6261 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6262 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6263
6e1a67fb
PE
6264 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6265 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6266 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6267 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6268 length of string rather than counting it via multiple sprintfs;
6269 that's simpler and more reliable.
c21721cc
PE
6270 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6271 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6272 sprintf, in case result does not fit in int.
6273
c57b67fc
PE
6274 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6275 (fontset_from_font): Print it.
6276
8a401434
PE
6277 * frame.c (tty_frame_count): Now printmax_t, not int.
6278 (make_terminal_frame, set_term_frame_name): Print it.
6279 (x_report_frame_params): In X, window IDs are unsigned long,
6280 not signed long, so print them as unsigned.
6281 (validate_x_resource_name): Check for implausibly long names,
6282 and don't assume name length fits in 'int'.
6283 (x_get_resource_string): Don't blindly alloca invocation name;
6284 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6285 not fit in int.
6286
6e1a67fb
PE
6287 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6288 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6289 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6290
0df02bf3
PE
6291 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6292 Use esprintf, not sprintf, in case result does not fit in int.
6293
48e30793
PE
6294 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6295 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6296 it as a large positive number.
6297 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6298 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6299
a66ff6d8
PE
6300 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6301 in case result does not fit in int.
6302
aca216ff
PE
6303 * print.c (float_to_string): Detect width overflow more reliably.
6304 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6305 buffer overrun. Don't assume list length fits in 'int'. Treat
6306 print length of 0 as 0, not as infinity; to be consistent with other
6307 uses of print length in this function. Don't overflow print length
6308 index. Don't assume hash table size fits in 'long', or that
6309 vectorlike size fits in 'unsigned long'.
6310
31c286f7
PE
6311 * process.c (make_process): Use printmax_t, not int, to format
6312 process-name gensyms.
6313
55e5faa1
PE
6314 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6315
80f2e268
PE
6316 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6317 to avoid potential buffer overrun.
6318
670741ab
PE
6319 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6320 if X resource line is longer than 512 bytes.
6321
b7163a50
PE
6322 * xfns.c (x_window): Make sprintf buffer a bit bigger
6323 to avoid potential buffer overrun.
6324
ae58ff1f
PE
6325 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6326
c43c8a6a
PE
6327 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6328
3f8236f4
PE
63292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6330
53e9fe90 6331 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6332 Without these, Emacs silently mishandles large integers sometimes.
6333 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6334 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6335
6511acf2
PE
6336 * xdisp.c (try_window_id): Check Emacs fixnum range before
6337 converting to 'int'.
806add1d 6338
6511acf2 6339 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6340 Check that an Emacs fixnum is in range before assigning it to 'int'.
6341 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6342 values converted from Emacs fixnums.
6343 (Frecenter): Don't wrap around a line count if it is out of 'int'
6344 range; instead, treat it as an extreme value.
6345 (Fset_window_configuration, compare_window_configurations):
6346 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6347
6511acf2
PE
6348 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6349 that can exceed INT_MAX. Check that EMACS_INT value is in range
6350 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6351 (match_limit): Don't assume that a fixnum can fit in 'int'.
6352
6511acf2 6353 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6354 exceed INT_MAX.
6355
6511acf2 6356 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6357 (Fvertical_motion): Don't wrap around LINES values that don't fit
6358 in 'int'. Instead, treat them as extreme values. This is good
6359 enough for windows, which can't have more than INT_MAX lines anyway.
6360
fcb901a7
LMI
63612011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6362
0f2f6b6d
LMI
6363 * Require libxml/parser.h to avoid compilation warning.
6364
fcb901a7
LMI
6365 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6366
6367 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6368 since this reportedly can destroy thread storage.
6369
6e20a0d4
CY
63702011-08-30 Chong Yidong <cyd@stupidchicken.com>
6371
6372 * syntax.c (find_defun_start): Update all cache variables if
6373 exiting early (Bug#9401).
6374
148ae00e
EZ
63752011-08-30 Eli Zaretskii <eliz@gnu.org>
6376
f6cfbd8f
EZ
6377 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6378
148ae00e
EZ
6379 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6380 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6381 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6382
6383 * term.c (tty_append_glyph): New function.
6384 (produce_stretch_glyph): Static function and its prototype deleted.
6385
a66cfb1c
SM
6386 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6387 Add prototypes.
148ae00e 6388
c4a07a4c
PE
63892011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6390
6391 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6392 when checking :margin (Bug#9390).
6393 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6394 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6395 so that the name doesn't mislead. All uses changed.
6396
6bc8cd65
JB
63972011-08-28 Johan Bockgård <bojohan@gnu.org>
6398
6399 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6400 set_tty_hooks.
6401
dca4927e
EZ
64022011-08-27 Eli Zaretskii <eliz@gnu.org>
6403
6404 * xdisp.c (move_it_to): Don't bail out early when reaching
6405 position beyond to_charpos, if we are scanning backwards.
6406 (move_it_vertically_backward): When DY == 0, make sure we get to
6407 the first character in the line after the newline.
6408
f2cad773
PE
64092011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6410
6411 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6412 (ccl_driver): Do not generate an out-of-range pointer.
6413 (Fccl_execute_on_string): Remove unnecessary check for
6414 integer overflow, noted by Stefan Monnier in
6415 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6416 Remove a FIXME that didn't need fixing.
6417 Simplify the newly-introduced buffer reallocation code.
6418
0cae2cdb
JB
64192011-08-27 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6422
5fc295a4 64232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6424
70c60eb2 6425 Integer and memory overflow issues (Bug#9196).
726e0ab1 6426
d31850da
PE
6427 * doc.c (get_doc_string): Rework so that
6428 get_doc_string_buffer_size is the actual buffer size, rather than
6429 being 1 less than the actual buffer size; this makes xpalloc more
6430 convenient.
6431
a69fbedb
PE
6432 * image.c (x_allocate_bitmap_record, cache_image):
6433 * xselect.c (Fx_register_dnd_atom):
6434 Simplify previous changes by using xpalloc.
6435
fe5c5d37
PE
6436 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6437 since either will do and ptrdiff_t is convenient with xpalloc.
6438
0065d054
PE
6439 * charset.c (charset_table_size)
6440 (struct charset_sort_data.priority): Now ptrdiff_t.
6441 (charset_compare): Don't overflow if priorities differ greatly.
6442 (Fsort_charsets): Don't assume list length fits in int.
6443 Check for size-calculation overflow when allocating sort data.
6444 (syms_of_charset): Allocate an initial charset table that is
6445 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6446
6447 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6448
6449 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6450 The actual value is always <= INT_MAX, and leaving it unsigned made
6451 overflow checking harder.
6452
6453 * dispextern.h (struct glyph_matrix.rows_allocated)
6454 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6455 with xpalloc. The values are still always <= INT_MAX.
6456
6457 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6458
6459 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6460 (SAFE_NALLOCA): New macro.
6461
6462 * region-cache.c (struct boundary.pos, find_cache_boundary)
6463 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6464 (set_cache_region, invalidate_region_cache)
6465 (revalidate_region_cache, know_region_cache, region_cache_forward)
6466 (region_cache_backward, pp_cache):
6467 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6468 so that ptrdiff_t * can be passed to xpalloc.
6469 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6470 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6471 (pp_cache): Don't assume cache_len fits in int.
6472 * region-cache.h: Adjust extern decls to match.
6473
6474 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6475 EMACS_INT, since either will do, for xpalloc.
6476
6477 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6478 (xnmalloc, xnrealloc, xpalloc): New functions.
6479
726e0ab1
PE
6480 * bidi.c (bidi_shelve_header_size): New constant.
6481 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6482 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6483
51f30bc5 6484 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6485 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6486 (overlay_strings):
6487 Don't update size of array until after memory allocation succeeds,
6488 because xmalloc/xrealloc may not return.
0065d054
PE
6489 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6490 now that we have proper integer overflow checking.
6491 (record_overlay_string, overlay_strings): Catch overflows when
6492 calculating size of overlay_str_buf.
726e0ab1 6493
0065d054
PE
6494 * callproc.c (Fcall_process): Check for size overflow when
6495 calculating size of args2.
6496 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6497 Normally we prefer signed values, but sticking with ptrdiff_t would
6498 require adding more-complicated checks.
726e0ab1
PE
6499
6500 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6501 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6502 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6503 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6504
6505 * character.c (Fstring): Check for size-calculation overflow.
6506
6507 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6508 unnecessary integer overflow. Check for size overflow.
6509 (encode_coding_object): Don't update size until xmalloc succeeds.
6510
6511 * composite.c (get_composition_id): Check for overflow in glyph
6512 length calculations.
6513
6514 Integer and memory overflow fixes for display code.
6515 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6516 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6517 (scrolling_window): Check for overflow in size calculations.
6518 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6519 Don't assume glyph table len fits in int.
6520 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6521 (row_table_size): Now ptrdiff_t, not int.
6522 (scrolling_window): Avoid overflow in size calculations.
6523 Don't update size until allocation succeeds.
6524 * fns.c (concat): Check for overflow in size calculations.
6525 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6526 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6527 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6528
6529 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6530 (get_doc_string): Check for size calculation overflow.
6531 Don't update size until allocation succeeds.
6532 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6533 EMACS_INT, where ptrdiff_t will do.
6534 (Fsubstitute_command_keys): Check for string overflow.
6535
6536 * editfns.c (set_time_zone_rule): Don't assume environment length
6537 fits in int.
6538 (message_length): Now ptrdiff_t, not int.
6539 (Fmessage_box): Don't update size until allocation succeeds.
6540 Don't assume message length fits in int.
6541 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6542
0065d054
PE
6543 * emacs.c (main): Do not reallocate argv, since there is a null at
6544 the end that can be overwritten, and this way there's no need to
6545 worry about size-calculation overflow.
6546 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6547
6548 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6549 alloc succeeds.
6550 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6551
6552 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6553 (x_set_scroll_bar_width, x_figure_window_size):
6554 Check for integer overflow.
6555 (x_set_alpha): Do not assume XINT fits in int.
6556
6557 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6558 This is for the members text_lines, text_cols, total_lines, total_cols,
6559 where the system imposes an 'int' limit.
6560
6561 * fringe.c (Fdefine_fringe_bitmap):
6562 Don't update size until alloc works.
6563
6564 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6565 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6566
6567 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6568 Check for size-calculation overflow.
6569 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6570 do, as we prefer signed integers.
6571 (id_to_widget.max_size, id_to_widget.used)
6572 (xg_store_widget_in_map, xg_remove_widget_from_map)
6573 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6574 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6575 Use and return ptrdiff_t, not int.
6576 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6577 * gtkutil.h: Change prototypes to match the above.
6578
6579 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6580 are duplicate now that they've been promoted to lisp.h.
6581 (x_allocate_bitmap_record, x_alloc_image_color)
6582 (make_image_cache, cache_image, xpm_load):
6583 Don't update size until alloc is done.
6584 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6585 (x_detect_edges):
3256efce 6586 Check for size calculation overflow.
726e0ab1
PE
6587 (ct_colors_allocated_max): New constant.
6588 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6589 overflow.
3256efce 6590
726e0ab1
PE
6591 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6592 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6593 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6594 Use ptrdiff_t, not int, to count maps.
6595 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6596 calculations. Don't update size until allocation succeeds.
6597 Redo calculations to avoid overflow.
726e0ab1
PE
6598 * keyboard.h: Change prototypes to match the above.
6599
6600 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6601 to count maps.
6602 (current_minor_maps): Check for size calculation overflow.
6603 * keymap.h: Change prototypes to match the above.
6604
6605 * lread.c (read1, init_obarray): Don't update size until alloc done.
6606
6607 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6608 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6609
726e0ab1
PE
6610 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6611 Now ptrdiff_t, not int.
6612 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6613 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6614
6615 * process.c (Fnetwork_interface_list): Check for overflow
6616 in size calculation.
6617
6618 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6619
6620 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6621 overflow. Don't bother calling xmalloc when xrealloc will do.
6622
6623 * search.c (Freplace_match): Check for size calculation overflow.
6624 (Fset_match_data): Don't assume list lengths fit in 'int'.
6625
6626 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6627 for command line length. Do not attempt to address one before the
6628 beginning of an array, as that's not portable.
6629
6630 * term.c (max_frame_lines): Remove; unused.
6631 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6632 not int.
6633 (encode_terminal_code, calculate_costs): Check for size
6634 calculation overflow.
6635 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6636 table lengths and related sizes. Don't update size until alloc
6637 done. Redo calculations to avoid overflow.
6638 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6639
6640 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6641 subtracting pointers.
6642 (gobble_line): Check for overflow more carefully. Don't update size
6643 until alloc done.
6644
6645 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6646 Don't update size until alloc done.
6647 Redo size calculations to avoid overflow.
6648 Check for size calculation overflow.
0065d054 6649 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6650
6651 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6652 Use ptrdiff_t, not int, for sizes.
6653 (store_mode_line_noprop_char): Don't update size until alloc done.
6654
0065d054
PE
6655 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6656 Use ptrdiff_t, not int, for sizes.
6657 (Finternal_make_lisp_face, cache_face):
6658 Check for size calculation overflow.
6659 (cache_face): Treat size calculation overflows as if they were
6660 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6661
6662 * xfns.c (x_encode_text, x_set_name_internal)
6663 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6664 sizes, since they can exceed INT_MAX in size. Check for size
6665 calculation overflow.
6666
0065d054
PE
6667 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6668 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6669 Don't update size until alloc done.
6670
0065d054 6671 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6672 as sprintf is limited to int lengths.
1d526e2f 6673
252c5ee1
PE
6674 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6675 (X_LONG_MIN): New macros.
864d7ce7
PE
6676 Use them to make the following changes clearer.
6677 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6678 This change doesn't affect the value now, but it may help remind
6679 future maintainers not to raise the value too much later.
6680 (SELECTION_QUANTUM): Remove, replacing with ...
6681 (selection_quantum): ... new function, which avoids overflow.
6682 All uses changed.
6683 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6684 assumption that selection length fits in 'int'.
6685 (x_reply_selection_request, x_handle_selection_request)
6686 (x_get_window_property, receive_incremental_selection)
6687 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6688 (lisp_data_to_selection_data, clean_local_selection_data):
6689 Use ptrdiff_t, not int, to record length of selection.
6690 (x_reply_selection_request, x_get_window_property)
6691 (receive_incremental_selection, x_property_data_to_lisp):
6692 Redo calculations to avoid overflow.
6693 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6694 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6695 something.
6696 (x_get_window_property, receive_incremental_selection)
6697 (lisp_data_to_selection_data, x_property_data_to_lisp):
6698 Check for size-calculation overflow.
6699 (x_get_window_property, receive_incremental_selection)
6700 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6701 Don't store size until memory allocation succeeds.
6702 (x_get_window_property): Plug memory leak on memory exhaustion.
6703 Don't double-block input; malloc is safe here. Don't assume 2**34
6704 - 4 fits in unsigned long. Add an xassert to check
6705 XGetWindowProperty overflow. Be more careful about overflow
6706 calculations, and distinguish size from memory overflow better.
6707 (receive_incremental_selection): When tracing, don't assume
6708 unsigned int is less than INT_MAX.
6709 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6710 harmful) conversions of unsigned short to int.
6711 (lisp_data_to_selection_data): Don't assume that integers
6712 in the range -65535 through -1 fit in an X unsigned short.
6713 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6714 result parameters unless successful. Rely on cons_to_unsigned
6715 to report problems with elements; the old code wasn't right anyway.
6716 (x_check_property_data): Check for int overflow; we cannot use
6717 a wider type due to X limits.
6718 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6719
726e0ab1 6720 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6721
0065d054
PE
6722 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6723 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6724 (x_color_cells): Don't store size until memory allocation succeeds.
6725 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6726 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6727 (x_term_init): Don't assume length fits in int (sprintf is limited
6728 to int size).
bc18e09d 6729
ebfa62c0
PE
6730 Use ptrdiff_t for composition IDs.
6731 * character.c (lisp_string_width):
6732 * composite.c (composition_table_size, n_compositions)
6733 (get_composition_id, composition_gstring_from_id):
6734 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6735 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6736 * window.c (Frecenter):
6737 Use ptrdiff_t, not int, for composition IDs.
6738 * composite.c (get_composition_id): Check for integer overflow.
6739 * composite.h: Adjust prototypes to match the above changes.
6740
d3411f89
PE
6741 Use ptrdiff_t for hash table indexes.
6742 * category.c (hash_get_category_set):
6743 * ccl.c (ccl_driver):
6744 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6745 * coding.c (coding_system_charset_list, detect_coding_system):
6746 * coding.h (struct coding_system.id):
6747 * composite.c (get_composition_id, gstring_lookup_cache):
6748 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6749 * image.c (xpm_get_color_table_h):
6750 * lisp.h (hash_lookup, hash_put):
6751 * minibuf.c (Ftest_completion):
6752 Use ptrdiff_t for hash table indexes, not int (which is too
6753 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6754 32-bit --with-wide-int hosts).
6755
e097a6fa
PE
6756 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6757 Add a FIXME comment about memory leaks.
6758 (syms_of_charset): Don't assume xmalloc returns.
6759
5637687f
PE
6760 Don't assume that stated character widths fit in int.
6761 * character.c (Fchar_width, c_string_width, lisp_string_width):
6762 * character.h (CHAR_WIDTH):
6763 * indent.c (MULTIBYTE_BYTES_WIDTH):
6764 Use sanitize_char_width to avoid undefined and/or bad behavior
6765 with outlandish widths.
a66cfb1c 6766 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6767 now that we have two such functions. All uses changed.
6768 (sanitize_char_width): New inline function.
6769
a2271ba2
PE
6770 Don't assume that tab-width fits in int.
6771 * character.h (sanitize_width): New inline function.
6772 (SANE_TAB_WIDTH): New macro.
6773 (ASCII_CHAR_WIDTH): Use it.
6774 * indent.c (sane_tab_width): Remove. All uses replaced by
6775 SANE_TAB_WIDTH (current_buffer).
6776 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6777
18c52557
PE
6778 * fileio.c: Integer overflow issues with file modes.
6779 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6780
caeeedc1
PE
6781 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6782 Remove unreachable code.
6783 (read_hex, load_charset_map_from_file): Check for integer overflow.
6784
6df6ae42 6785 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6786 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6787 (x_send_scroll_bar_event): Likewise. Check that the size does not
6788 exceed limits imposed by XClientMessageEvent, as well as the usual
6789 ptrdiff_t and size_t limits.
6790
b13995db
PE
6791 * keyboard.c: Overflow, signedness and related fixes.
6792 (make_lispy_movement): Use same integer type in forward decl
6793 that is used in the definition.
6794 (read_key_sequence, keyremap_step):
6795 Change bufsize argument back to int, undoing my 2011-03-30 change.
6796 We prefer signed types, and int is wide enough here.
6797 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6798 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6799 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6800 length, not size_t. Use ptrdiff_t for index, not int.
6801 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6802 possibility of integer overflow.
6803
13464394
PE
6804 Overflow, signedness and related fixes for images.
6805
6806 * dispextern.h (struct it.stack[0].u.image.image_id)
6807 (struct_it.image_id, struct image.id, struct image_cache.size)
6808 (struct image_cache.used, struct image_cache.ref_count):
6809 * gtkutil.c (update_frame_tool_bar):
6810 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6811 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6812 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6813 * nsmenu.m (update_frame_tool_bar):
6814 * xdisp.c (calc_pixel_width_or_height):
6815 * xfns.c (image_cache_refcount):
6816 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6817 on typical 64-bit hosts.
6818
6819 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6820 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6821 Omit unnecessary casts to int.
6822 (parse_image_spec): Check that integers fall into 'int' range
6823 when the callers expect that.
6824 (image_ascent): Redo ascent calculation to avoid int overflow.
6825 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6826 (lookup_image): Remove unnecessary tests.
6827 (xbm_image_p): Locals are now of int, not EMACS_INT,
6828 since parse_image_check makes sure they fit into int.
6829 (png_load, gif_load, svg_load_image):
6830 Prefer int to unsigned where either will do.
6831 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6832 old tiff_error_handler and tiff_warning_handler.
6833 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6834 stack buffer overflows. It uses only the features of vsnprintf
6835 that are common to both POSIX and native Microsoft.
6836 (tiff_error_handler, tiff_warning_handler): Use it.
6837 (tiff_load, gif_load, imagemagick_load_image):
6838 Don't assume :index value fits in 'int'.
6839 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6840 (imagemagick_load_image): Check that crop parameters fit into
6841 the integer types that MagickCropImage accepts. Don't assume
6842 Vimagemagick_render_type has a nonnegative value. Don't assume
6843 size_t fits in 'long'.
6844 (gs_load): Use printmax_t to print the widest integers possible.
6845 Check for integer overflow when computing image height and width.
6846
c11821d4
EZ
68472011-08-26 Eli Zaretskii <eliz@gnu.org>
6848
6849 * xdisp.c (redisplay_window): Don't force window start if point
6850 will be invisible in the resulting window. (Bug#9324)
6851
0c95fcf7
EZ
68522011-08-25 Eli Zaretskii <eliz@gnu.org>
6853
6854 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6855 the display spec is of the form `(space ...)'.
6856 (handle_display_spec): Return the value returned by
6857 handle_single_display_spec, not just 1 or zero.
6858 (handle_single_display_spec): If the display spec is of the form
6859 `(space ...)', and specifies display in the text area, return 2
6860 rather than 1.
fee65a97 6861 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6862 accurately, and prefer exact match for point under bidi.
6863 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6864
6865 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6866 into disp_prop; all users changed.
6867
6868 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6869 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6870 for the text covered by the display property.
6871
e4ed06f1
CY
68722011-08-25 Chong Yidong <cyd@stupidchicken.com>
6873
6874 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6875 Change return value to nil.
6876 (Frecord_buffer): Delete unused function.
6877
f67cdd7f
EZ
68782011-08-24 Eli Zaretskii <eliz@gnu.org>
6879
5980d4c6
EZ
6880 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6881 buffers, return left-to-right.
8610fe8b
EZ
6882 (set_cursor_from_row): Consider candidate row a win if its glyph
6883 represents a newline and point is on that newline. Fixes cursor
6884 positioning on the newline at EOL of R2L text within L2R
6885 paragraph, and vice versa.
6886 (try_cursor_movement): Check continued rows, in addition to
6887 continuation rows. Fixes unwarranted scroll when point enters a
6888 continued line of R2L text within an L2R paragraph, or vice versa.
6889 (cursor_row_p): Consider the case of point being equal to
6890 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6891 from the end of a short line to the beginning of a continued line
6892 of R2L text within L2R paragraph.
6893 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6894 composed characters.
5980d4c6 6895
f67cdd7f
EZ
6896 * bidi.c (bidi_check_type): Use xassert.
6897 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6898 members.
6899
bca633fb
EZ
69002011-08-23 Eli Zaretskii <eliz@gnu.org>
6901
6902 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6903 a character.
6904
4a5885a7
CY
69052011-08-23 Chong Yidong <cyd@stupidchicken.com>
6906
6907 * nsfont.m (ns_otf_to_script): Fix typo.
6908
0902a04e
KH
69092011-08-22 Kenichi Handa <handa@m17n.org>
6910
6911 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6912 extra slot even if the purpose is char-code-property-table.
6913
1a2e6670
EZ
69142011-08-23 Eli Zaretskii <eliz@gnu.org>
6915
8ddde651
EZ
6916 * xdisp.c (redisplay_window): When computing centering_position,
6917 account for the height of the header line. (Bug#8874)
6918
425cc014
EZ
6919 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6920 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6921 candidate is selected by the mouse, and that candidate has a
6922 composed character under the mouse.
6923
1a2e6670
EZ
6924 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6925 coordinates reported by pos-visible-in-window-p for a composed
6926 character in column zero.
6927
8b76d6f8
SM
69282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6929
6930 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6931
dac347dd
EZ
69322011-08-22 Eli Zaretskii <eliz@gnu.org>
6933
6934 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6935 consider it a hit if to_charpos is anywhere in the range of the
6936 composed buffer positions.
6937
e013fb34
CY
69382011-08-22 Chong Yidong <cyd@stupidchicken.com>
6939
6940 * image.c (gif_load): Don't assume that each subimage has the same
6941 dimensions as the base image. Handle disposal method that is
6942 "undefined" by the gif spec (Bug#9335).
6943
bd1ba3e8
CY
69442011-08-20 Chong Yidong <cyd@stupidchicken.com>
6945
6946 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6947 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6948
54a1215b
EZ
69492011-08-19 Eli Zaretskii <eliz@gnu.org>
6950
823564e5
EZ
6951 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6952 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6953 from an Org mode buffer to a Speedbar frame.
6954
54a1215b
EZ
6955 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6956 a composition, take its buffer position from IT->cmp_it.charpos.
6957 Fixes cursor positioning at the beginning of a line that begins
6958 with a composed character.
6959
9778ebcc
EZ
69602011-08-18 Eli Zaretskii <eliz@gnu.org>
6961
0be6ee06
EZ
6962 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6963 character bidirectional type, use STRONG_L instead. Fixes crashes
6964 in a buffer produced by `describe-categories'.
6965
9778ebcc
EZ
6966 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6967 members before the level stack, so they would be saved and
6968 restored when copying iterator state. Fixes incorrect reordering
6969 around TABs covered by display properties.
6970
156bffbe
AS
69712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6972
6b02f655 6973 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6974
72ad093b
CY
69752011-08-17 Chong Yidong <cyd@stupidchicken.com>
6976
6977 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6978 (internal_condition_case_2, internal_condition_case_n):
6979 Remove unnecessary aborts (Bug#9081).
72ad093b 6980
35774242
EZ
69812011-08-17 Eli Zaretskii <eliz@gnu.org>
6982
6983 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6984 has no `load' handler, try opening the file locally. (Bug#9311)
6985
db76dd85
KB
69862011-08-16 Ken Brown <kbrown@cornell.edu>
6987
6988 * gmalloc.c: Expand comment.
6989
b215eee5
EZ
69902011-08-16 Eli Zaretskii <eliz@gnu.org>
6991
6992 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6993 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6994
a4579d33
KB
69952011-08-16 Ken Brown <kbrown@cornell.edu>
6996
6997 Fix memory allocation problems in Cygwin build (Bug#9273).
6998
6999 * unexcw.c ( __malloc_initialized): Declare external variable.
7000 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7001
8b76d6f8
SM
7002 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7003 New variables.
a4579d33
KB
7004 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7005 dumped emacs.
7006 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7007 in the static heap.
7008 [CYGWIN] (special_realloc): New function.
7009 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7010 requests to realloc storage in the static heap.
7011
3ebec551
PE
70122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7013
7014 * bidi.c (bidi_initialize): Remove unused local.
7015
9fd8be00
EZ
70162011-08-15 Eli Zaretskii <eliz@gnu.org>
7017
6b02f655
SM
7018 * bidimirror.h:
7019 * biditype.h: Remove file.
7020 * makefile.w32-in ($(BLD)/bidi.$(O)):
7021 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7022
7023 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7024
7025 * chartab.c: Improve commentary for the uniprop_table API.
7026
32413314
EZ
7027 * bidi.c (bidi_paragraph_init): Support zero value of
7028 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7029 (bidi_initialize): Use uniprop_table instead of including
7030 biditype.h and bidimirror.h.
32413314 7031
9fd8be00
EZ
7032 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7033 coordinates of the iterator when restoring from ppos_it.
7034 (Bug#9296)
7035
5cf2b69b
KH
70362011-08-14 Kenichi Handa <handa@m17n.org>
7037
7038 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7039 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7040
daf17d00
EZ
70412011-08-14 Eli Zaretskii <eliz@gnu.org>
7042
7043 * xdisp.c (move_it_in_display_line_to): Don't invoke
7044 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7045 ppos_it. Fixes vertical cursor motion when line beginning is
7046 covered by an image. (Bug#9296)
7047
08e3161a
JD
70482011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7049
7050 * nsterm.h (ns_run_ascript): Declare.
7051 (NSAPP_DATA2_RUNASSCRIPT): Define.
7052
7053 * nsfns.m (as_script, as_result, as_status): New static variables.
7054 (ns_run_ascript): New function.
5e617bc2 7055 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7056 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7057 the event loop. Get status from as_status (Bug#7276).
7058
7059 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7060 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7061 the event loop (Bug#7276).
7062
a3720aa2
AS
70632011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7064
7065 * gnutls.c (QCgnutls_bootprop_priority)
7066 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7067 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7068 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7069 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7070 (QCgnutls_bootprop_verify_hostname_error)
7071 (QCgnutls_bootprop_callbacks_verify): Rename from
7072 Qgnutls_bootprop_..., all uses changed.
7073
7074 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7075 uses changed.
7076
0a0d27fb
PE
70772011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7078
19d5c50c
PE
7079 * xfaces.c (Qframe_set_background_mode): Now static.
7080 * dispextern.h (Qframe_set_background_mode): Remove decl.
7081
0a0d27fb
PE
7082 * process.c (Fnetwork_interface_info): Declare local only if needed.
7083
377538cb
JD
70842011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7085
7086 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7087 (Fnetwork_interface_list): Allocate in increments of bytes instead
7088 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7089 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7090 sockaddr.
7091 (struct ifflag_def): notrailers is smart on OSX.
7092 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7093 Get hardware address with getifaddrs if available.
7094
08fff70c
EZ
70952011-08-12 Eli Zaretskii <eliz@gnu.org>
7096
7097 * xdisp.c (iterate_out_of_display_property): xassert that
7098 IT->position is set to within IT->object's boundaries. Break from
7099 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7100 when IT->position is set up wrongly due to some bug.
7101 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7102 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7103 entry. Force push_it to save on the stack the current
7104 buffer/string position, to be restored by pop_it. Fix flags in
7105 the iterator structure wrt the object coming from a display
7106 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7107 properties. (Bug#9284)
7108
7be1c708 71092011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7110
7be1c708
CY
7111 * fontset.c (fontset_get_font_group): Add proper type checks.
7112 (Bug#9172)
aac0c6e3 7113
7be1c708 71142011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7115
7be1c708
CY
7116 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7117 and LC_VERSION_MIN_MACOSX.
7118 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7119 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7120
97bb72a6
EZ
71212011-08-08 Eli Zaretskii <eliz@gnu.org>
7122
7123 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7124 no-display-properties-and-no-overlays under bidi display.
7125 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7126 properties and overlays.
97bb72a6 7127
d5617611
CY
71282011-08-08 Chong Yidong <cyd@stupidchicken.com>
7129
37e11a63
CY
7130 * editfns.c (Fset_time_zone_rule): Document relationship with the
7131 setenv function.
7132
d5617611
CY
7133 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7134 the font entity extracted from the cache (Bug#8109).
7135
58872834
CY
71362011-08-07 Chong Yidong <cyd@stupidchicken.com>
7137
7138 * composite.c (autocmp_chars): Don't reset point. That is done by
7139 restore_point_unwind (Bug#5984).
7140
75bfc667
JL
71412011-08-07 Juri Linkov <juri@jurta.org>
7142
7143 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7144 to show the arg `TIME' instead of `TIMEVAL'.
7145
d1410150
EZ
71462011-08-06 Eli Zaretskii <eliz@gnu.org>
7147
7148 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7149 display property strides EOL and includes a newline, as in
7150 longlines-mode. (Bug#9254)
75b771e4
EZ
7151 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7152 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7153
7154 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7155 is non-zero, even if the data buffer is NULL. Fixes a crash in
7156 vertical-motion with longlines-mode. (Bug#9254)
7157
35928349
EZ
71582011-08-05 Eli Zaretskii <eliz@gnu.org>
7159
ec7cc85b
EZ
7160 * bidi.c <bidi_cache_total_alloc>: Now static.
7161 (bidi_initialize): Initialize bidi_cache_total_alloc.
7162
8b76d6f8 7163 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7164 cache. (Bug#9221)
7165
7166 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7167 amount allocated this far in `bidi_cache_total_alloc'.
7168 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7169 non-zero, only free the data buffer without restoring the cache
7170 contents. All callers changed.
7171
7172 * dispextern.h (bidi_unshelve_cache): Update prototype.
7173
7174 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7175 (move_it_in_display_line, move_it_to)
7176 (move_it_vertically_backward, move_it_by_lines): Replace the call
7177 to xfree to an equivalent call to bidi_unshelve_cache.
7178 (move_it_in_display_line_to): Fix logic of returning
412b6358 7179 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7180
e2e2423b
EZ
71812011-08-05 Eli Zaretskii <eliz@gnu.org>
7182
7183 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7184 came from a string character with a `cursor' property. (Bug#9229)
7185
ae9e757a
JD
71862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7187
7188 * Makefile.in (LIB_PTHREAD): New variable.
7189 (LIBES): Add LIB_PTHREAD (Bug#9216).
7190
7191 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7192 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7193
213bd7f2
AS
71942011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7195
6b02f655 7196 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7197
99aaf75f
JD
71982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7199
7200 * xterm.c (x_find_topmost_parent): New function.
7201 (x_set_frame_alpha): Find topmost parent window with
7202 x_find_topmost_parent and set the property there also (bug#9181).
7203 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7204
c74e9d86
PE
72052011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7206
7207 * callproc.c (Fcall_process): Avoid vfork clobbering
7208 the local vars buffer, coding_systems, current_dir.
7209
640c8776
SM
72102011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7211
7212 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7213
f26d0e4c
PE
72142011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7215
8a10d76c
PE
7216 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7217 so that it is not optimized away.
7218
f26d0e4c
PE
7219 * xdisp.c (compute_display_string_pos): Remove unused local.
7220
55439c61
EZ
72212011-08-02 Eli Zaretskii <eliz@gnu.org>
7222
7223 Fix slow cursor motion and scrolling in large buffers with
7224 selective display, like Org Mode buffers. (Bug#9218)
7225
7226 * dispextern.h (struct bidi_it): New member disp_prop_p.
7227
7228 * xdisp.c: Remove one-slot cache of display string positions.
7229 (compute_display_string_pos): Accept an additional argument
5e617bc2 7230 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7231 for a display string or property. If found, set DISP_PROP_P
7232 non-zero.
7233
7234 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7235 DISP_PROP_P, and pass it to compute_display_string_pos.
7236 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7237 non-zero. All callers of bidi_fetch_char changed.
7238
fb33fa43
SM
72392011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7240
7241 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7242
b099e063
DM
72432010-12-03 Don March <don@ohspite.net>
7244
7245 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7246 last character M-[char] is translated to ESC [char] (bug#7541).
7247
5cc7f7af
KH
72482011-08-02 Kenichi Handa <handa@m17n.org>
7249
d0fffa3f 7250 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7251
7252 * chartab.c (uniprop_table): Make it non-static.
7253
525d5e6e
EZ
72542011-08-01 Eli Zaretskii <eliz@gnu.org>
7255
7256 * xdisp.c (forward_to_next_line_start): Accept additional argument
7257 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7258 on the newline.
7259 (reseat_at_next_visible_line_start): Use the bidi iterator state
7260 returned by forward_to_next_line_start to restore the state of
7261 it->bidi_it after backing up to previous newline. (Bug#9212)
7262
31011111
AS
72632011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7264
7265 * regex.c (re_comp): Protoize.
7266 (re_exec): Fix return type.
7267 (regexec): Fix type of `ret'. (Bug#9203)
7268
476371c4
PE
72692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7270
e5d76069
PE
7271 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7272 This is needed if max-image-size is a floating-point number.
7273
9a79b20c
AS
72742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7275
7276 * print.c (print_object): Print empty symbol as ##.
7277
7278 * lread.c (read1): Read ## as empty symbol.
7279
d8c2fa78
AA
72802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7281
7282 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7283 setting frame foreground color (Bug#9175).
7284 (x_set_background_color): Likewise.
7285
ffe57a7a
AA
7286 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7287 contents (Bug#9176).
7288 (EmacsTooltip -init): Remove bezels and add shadows to
7289 tooltip windows.
7290
bf3492a5
AA
7291 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7292 or scroll bar (Bug#8470).
7293
d55e9c53
AA
7294 * nsfont.m (nsfont_open): Remove assignment to voffset and
7295 unnecessary vars hshink, expand, hd, full_height, min_height.
7296 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7297
7298 * nsterm.h (nsfont_info): Remove voffset field.
7299
d8c2fa78 73002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7301
7302 Implement strike-through and overline on NextStep (Bug#8863).
7303
7304 * nsfont.m (nsfont_open): Use underline position provided by font,
7305 instead of hard-coded value of 2.
7306 (nsfont_draw): Call ns_draw_text_decoration instead.
7307
7308 * nsterm.h: Add declaration for ns_draw_text_decoration.
7309
7310 * nsterm.m (ns_draw_text_decoration): New function for drawing
7311 underline, overline, and strike-through.
7312 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7313 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7314 accommodate underlining, etc.
4843aac3 7315
4cc60b9b
EZ
73162011-07-28 Eli Zaretskii <eliz@gnu.org>
7317
bc7ece87
EZ
7318 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7319 default.
4cc60b9b 7320
476371c4
PE
73212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7322
66606eea
PE
7323 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7324 Without this fix, if a signal arrives just after memory fills up,
7325 'malloc' might be invoked reentrantly.
7326
476371c4
PE
7327 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7328 In other words, assume that every image size is allowed, on non-X
7329 hosts. This assumption is probably wrong, but it lets Emacs compile.
7330
f3fcc40d
AS
73312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7332
7333 * regex.c (re_iswctype): Convert return values to boolean.
7334
350c992f
EZ
73352011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7336
7337 * xdisp.c (compute_display_string_pos): Don't use cached display
7338 string position if the buffer had its restriction changed.
7339 (Bug#9184)
7340
5266b4bb
PE
73412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7342
7343 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7344
2573a837 73452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7346
41f55ccd 7347 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7348
39e378da
PE
7349 * bidi.c: Integer size and overflow fixes.
7350 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7351 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7352 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7353 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7354 (bidi_find_other_level_edge):
7355 Use ptrdiff_t instead of EMACS_INT where either will do.
7356 This works better on 32-bit hosts configured --with-wide-int.
7357 (bidi_cache_ensure_space): Check for size-calculation overflow.
7358 Use % rather than repeated addition, for better worst-case speed.
7359 Don't set bidi_cache_size until after xrealloc returns, because it
7360 might not return.
7361 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7362 (bidi_cache_ensure_space): Also check that the bidi cache size
7363 does not exceed that of the largest Lisp string or buffer. See Eli
7364 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7365
5e927815
PE
7366 * alloc.c (__malloc_size_t): Remove.
7367 All uses replaced by size_t. See Andreas Schwab's note
7368 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7369
ca4aa935
PE
7370 * image.c: Improve checking for integer overflow.
7371 (check_image_size): Assume that f is nonnull, since
7372 it is always nonnull in practice. This is one less thing to
7373 worry about when checking for integer overflow later.
7374 (x_check_image_size): New function, which checks for integer
7375 overflow issues inside X.
7376 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7377 This removes the need for a memory_full check.
7378 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7379 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7380 (xbm_read_bitmap_data): Change locals back to 'int', since
7381 their values must fit in 'int'.
7382 (xpm_load_image, png_load, tiff_load):
7383 Invoke x_create_x_image_and_pixmap earlier,
7384 to avoid much needless work if the image is too large.
7385 (tiff_load): Treat overly large images as if
7386 x_create_x_image_and_pixmap failed, not as malloc failures.
7387 (gs_load): Use x_check_image_size.
7388
5f8f9cc2
PE
7389 * gtkutil.c: Omit integer casts.
7390 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7391 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7392
5adf60bc
PE
7393 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7394
c8907a93
PE
7395 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7396 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7397 would wrongly return t on a 64-bit host.
7398
e3c25c68
PE
7399 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7400 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7401 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7402 and therefore cause GCC to emit a bogus diagnostic in some cases.
7403
3f791afe
PE
7404 * image.c: Integer signedness and overflow and related fixes.
7405 This is not an exhaustive set of fixes, but it's time to
7406 record what I've got.
7407 (lookup_pixel_color, check_image_size): Remove redundant decls.
7408 (check_image_size): Don't assume that arbitrary EMACS_INT values
7409 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7410 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7411 (tiff_load, imagemagick_load_image):
7412 Check for overflow in size calculations.
7413 (x_create_x_image_and_pixmap): Remove unnecessary test for
7414 xmalloc returning NULL; that can't happen.
7415 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7416 (xpm_color_bucket): Use better integer hashing function.
7417 (xpm_cache_color): Don't possibly over-allocate memory.
7418 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7419 (gif_memory_source):
7420 Use ptrdiff_t, not int or size_t, to record sizes.
7421 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7422 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7423 either works, as we prefer signed integers.
7424 (tiff_read_from_memory, tiff_write_from_memory):
7425 Return tsize_t, not size_t, since that's what the TIFF API wants.
7426 (tiff_read_from_memory): Don't fail simply because the read would
7427 go past EOF; instead, return a short read.
7428 (tiff_load): Omit no-longer-needed casts.
7429 (Fimagemagick_types): Don't assume size fits into 'int'.
7430
3cc5a532
PE
7431 Improve hashing quality when configured --with-wide-int.
7432 * fns.c (hash_string): New function, taken from sxhash_string.
7433 Do not discard information about ASCII character case; this
7434 discarding is no longer needed.
7435 (sxhash-string): Use it. Change sig to match it. Caller changed.
7436 * lisp.h: Declare it.
7437 * lread.c (hash_string): Remove, since we now use fns.c's version.
7438 The fns.c version returns a wider integer if --with-wide-int is
7439 specified, so this should help the quality of the hashing a bit.
7440
b312a492
PE
7441 * emacs.c: Integer overflow minor fix.
7442 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7443 Define only if GNU_LINUX.
7444 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7445
dfd153ae
PE
7446 * dispnew.c: Integer signedness and overflow fixes.
7447 Remove unnecessary forward decls, that were a maintenance hassle.
7448 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7449 All uses changed.
7450 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7451 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7452 (prepare_desired_row, line_draw_cost):
7453 Use int, not unsigned, where either works.
7454 (save_current_matrix, restore_current_matrix):
7455 Use ptrdiff_t, not size_t, where either works.
7456 (init_display): Check for overflow more accurately, and without
7457 relying on undefined behavior.
7458
a81d11a3
PE
7459 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7460 Remove, replacing with the new symbols in lisp.h. All uses changed.
7461 * fileio.c (make_temp_name):
7462 * filelock.c (lock_file_1, lock_file):
7463 * xdisp.c (message_dolog):
7464 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7465 Use pMd etc. instead.
7466 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7467 replacing the pWIDE etc. symbols removed from editfns.c.
7468
3300e6fd
PE
7469 * keyboard.h (num_input_events): Now uintmax_t.
7470 This is (very slightly) less likely to mess up due to wraparound.
7471 All uses changed.
7472
fd05c7e9
PE
7473 * buffer.c: Integer signedness fixes.
7474 (alloc_buffer_text, enlarge_buffer_text):
7475 Use ptrdiff_t rather than size_t when either will do, as we prefer
7476 signed integers.
7477
903fe15d
PE
7478 * alloc.c: Integer signedness and overflow fixes.
7479 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7480 (__malloc_size_t): Default to size_t, not to int.
7481 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7482 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7483 Prefer ptrdiff_t to size_t when either would do, as we prefer
7484 signed integers.
7485 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7486 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7487 Now const. Initialize with values that are in range even if char
7488 is signed.
7489 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7490 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7491 These functions do the right thing with sizes > 2**32.
7492 (check_depth): Now ptrdiff_t, not int.
7493 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7494 Adjust to new way of storing sizes. Check for size overflow bugs
7495 in rest of code.
7496 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7497 slightly wrong anyway, as it missed one instance of
7498 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7499 (refill_memory_reserve): Omit needless cast to size_t.
7500 (mark_object_loop_halt): Mark as externally visible.
7501
ac82cc6a
PE
7502 * xselect.c: Integer signedness and overflow fixes.
7503 (Fx_register_dnd_atom, x_handle_dnd_message):
7504 Use ptrdiff_t, not size_t, since we prefer signed.
7505 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7506 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7507 x_dnd_atoms_size and x_dnd_atoms_length.
7508
c2d1e36d
PE
7509 * doprnt.c: Prefer signed to unsigned when either works.
7510 * eval.c (verror):
7511 * doprnt.c (doprnt):
7512 * lisp.h (doprnt):
7513 * xdisp.c (vmessage):
7514 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7515 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7516 prefer signed arithmetic to avoid comparison confusion.
7517 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7518 but is a bit tricky.
7519
0e926e56
PE
7520 Assume freestanding C89 headers, string.h, stdlib.h.
7521 * data.c, doprnt.c, floatfns.c, print.c:
7522 Include float.h unconditionally.
7523 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7524 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7525 * regex.c: Likewise for stddef.h, string.h.
7526 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7527 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7528 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7529 (STDC_HEADERS): Remove obsolete defines.
7530 * sysdep.c: Include limits.h unconditionally.
7531
9cfdb3ec
PE
7532 Assume support for memcmp, memcpy, memmove, memset.
7533 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7534 * regex.c (memcmp, memcpy):
7535 Remove; we assume C89 now.
7536
7537 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7538 (__malloc_safe_bcopy): Remove; no longer needed.
7539
cf950e6b 7540 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7541 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7542 well either way, and we prefer signed to unsigned.
7543
dbf38e02
LMI
75442011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7545
7546 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7547 closes the connection while we're reading (bug#9182).
7548
d6f0886c 75492011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7550
d6f0886c
JD
7551 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7552 are specified (Bug#9168).
24e0f6b1 7553
2eb1f9e6
PE
75542011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7555
7556 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7557 Found by GCC static checking and --with-wide-int on a 32-bit host.
7558
22381272 75592011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7560
7561 * xdisp.c (compute_display_string_pos): Fix logic of caching
7562 previous display string position. Initialize cached_prev_pos to
7563 -1. Fixes slow-down at the beginning of a buffer.
7564
f25e39b4
EZ
75652011-07-24 Eli Zaretskii <eliz@gnu.org>
7566
7567 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7568 for attrs[LFACE_FONTSET_INDEX].
7569
04c4b52e
PE
75702011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7571
7572 * xml.c (parse_region): Remove unused local
7573 that was recently introduced.
7574
c1734fbd
EZ
75752011-07-23 Eli Zaretskii <eliz@gnu.org>
7576
be18c5a5
EZ
7577 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7578 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7579
c1734fbd
EZ
7580 * xdisp.c (move_it_in_display_line_to): Record the best matching
7581 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7582 exit if none of the characters scanned was an exact match.
7583 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7584 when exact match is impossible due to invisible text, and the
7585 lines are truncated.
7586
a258d627
JD
75872011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7588
7589 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7590 for OSX >= 10.7.
7591
b6d5a689
EZ
75922011-07-22 Eli Zaretskii <eliz@gnu.org>
7593
0f74f785
EZ
7594 Fix a significant slow-down of cursor motion with C-n, C-p,
7595 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7596 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7597 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7598 (next_element_from_buffer): Call compute_stop_pos_backwards to
7599 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7600 base_level_stop.
7601 (reseat): Don't look for prev_stop, as that could mean a very long
7602 run.
7603 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7604 <cached_disp_overlay_modiff>: Cache for last found display string
7605 position.
551918c1 7606 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7607 about the same buffer in the same area of character positions, and
7608 the buffer wasn't changed since the time the display string
7609 position was cached.
551918c1 7610
b2d0c91a
EZ
76112011-07-22 Eli Zaretskii <eliz@gnu.org>
7612
7613 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7614 is an integer, which is important for empty lines. (Bug#9149)
7615
043604ee
CY
76162011-07-22 Chong Yidong <cyd@stupidchicken.com>
7617
7618 * frame.c (Fmodify_frame_parameters): In tty case, update the
7619 default face if necessary (Bug#4238).
7620
da4adb04
CY
76212011-07-21 Chong Yidong <cyd@stupidchicken.com>
7622
7623 * editfns.c (Fstring_to_char): No need to explain what a character
7624 is in the docstring (Bug#6576).
7625
9abd0532
LMI
76262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7627
7628 * xml.c (parse_region): Make sure we always return a tree.
7629
36881d16
HK
76302011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7631
7632 * xml.c (parse_region): If a document contains only comments,
7633 return that, too.
7634
1e98674d
LMI
76352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7636
7637 * xml.c (make_dom): Return comments, too.
7638
590bd467
PE
76392011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7640
7641 Port to OpenBSD.
7642 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7643 and the surrounding thread.
7644 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7645 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7646 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7647 timer goes off.
7648 * s/openbsd.h (BROKEN_SIGIO): Define.
7649 * unexelf.c (unexec) [__OpenBSD__]:
7650 Don't update the .mdebug section of the Alpha COFF symbol table.
7651
f41628b2
LMI
76522011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7653
7654 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7655 (bug#8460).
7656
b59b67c5
PE
76572011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7658
15e3a074
PE
7659 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7660 This fixes some race conditions on the permissions of any newly
7661 created file.
7662
41bed37d
PE
7663 * alloc.c (valid_pointer_p): Use pipe, not open.
7664 This fixes some permissions issues when debugging.
7665
b59b67c5
PE
7666 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7667 If fchown fails to set both uid and gid, try to set just gid,
7668 as that is sometimes allowed. Adjust the file's mode to eliminate
7669 setuid or setgid bits that are inappropriate if fchown fails.
7670
925a6be7
SM
76712011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7672
7673 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7674 to compare Lisp_Objects.
7675 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7676 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7677 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7678
52968808
AS
76792011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7680
0a6a104b
AS
7681 * lread.c (read_integer): Unread even EOF character.
7682 (read1): Likewise. Properly record start position of symbol.
7683
52968808
AS
7684 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7685 symbol character follows.
7686
9e381cdd
PE
76872011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7688
7689 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7690 This works around a problem with the previous change to Fcopy_file.
7691 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7692 and without this change, GCC might complain about discarding
7693 fchown's return value.
7694
b5641435
JB
76952011-07-16 Juanma Barranquero <lekktu@gmail.com>
7696
7697 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7698
a8031457
PE
76992011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7700
7701 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7702
dd889327
LMI
77032011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7704
750c33f7
LMI
7705 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7706 it's used from the C level.
7707
dd889327
LMI
7708 * process.c: Use the same condition for POLL_FOR_INPUT in both
7709 keyboard.c and process.c (bug#1858).
7710
87e86684
LM
77112011-07-09 Lawrence Mitchell <wence@gmx.li>
7712
7713 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7714 (Fgnutls_boot): Use it.
7715
64348f40
AS
77162011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7717
7718 * doc.c (Fsubstitute_command_keys): Revert last change.
7719
1d698799
LMI
77202011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7721
f863868c
LMI
7722 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7723 quotes the next character, and doesn't affect other longer
7724 sequences (bug#8935).
7725
1d698799
LMI
7726 * lread.c (syms_of_lread): Clarify that is isn't only
7727 `eval-buffer' and `eval-defun' that's affected by
7728 `lexical-binding' (bug#8460).
7729
aa4b6df6
EZ
77302011-07-15 Eli Zaretskii <eliz@gnu.org>
7731
7732 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7733 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7734
5d856da6
PE
77352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7736
ad6042bb
PE
7737 Fix minor problems found by static checking.
7738 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7739 (elsz): Now a signed constant, not a size_t var. We prefer signed
7740 types to unsigned, to avoid integer comparison confusion. Without
7741 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7742 "cannot optimize loop, the loop counter may overflow", a symptom
7743 of the confusion.
f00bbb22 7744 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7745 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7746
6468f31c
LMI
77472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7748
49080b10
LMI
7749 * search.c (Fre_search_backward): Mention `case-fold-search' in
7750 all the re_search_* functions (bug#8138).
7751
6468f31c
LMI
7752 * keyboard.c (Fopen_dribble_file): Document when the file is
7753 closed (bug#8056).
7754
c965adc5
EZ
77552011-07-14 Eli Zaretskii <eliz@gnu.org>
7756
df9733bf
EZ
7757 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7758 bidi_cache_idx.
7759
0bb23927
EZ
7760 Support bidi reordering of display and overlay strings.
7761 * xdisp.c (compute_display_string_pos)
7762 (compute_display_string_end): Accept additional argument STRING.
7763 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7764 (reseat_to_string): Initialize bidi_it->string.s and
7765 bidi_it->string.schars.
7766 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7767 NULL (avoids a crash in bidi_paragraph_init).
7768 Initialize itb.string.lstring.
0bb23927
EZ
7769 (init_iterator): Call bidi_init_it only of a valid
7770 buffer position was specified. Initialize paragraph_embedding to
7771 L2R.
7772 (reseat_to_string): Initialize the bidi iterator.
7773 (display_string): If we need to ignore text properties of
7774 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7775 original value of -1 will not work with bidi.)
7776 (compute_display_string_pos): First arg is now struct
7777 `text_pos *'; all callers changed. Support display properties on
7778 Lisp strings.
7779 (compute_display_string_end): Support display properties on Lisp
7780 strings.
7781 (init_iterator, reseat_1, reseat_to_string): Initialize the
7782 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7783 when iterating on a string not from display properties).
640c8776
SM
7784 (compute_display_string_pos, compute_display_string_end):
7785 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7786 arrow keys.
7787 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7788 base_level_stop; instead, set base_level_stop to BEGV.
7789 Fixes crashes in vertical-motion.
0bb23927
EZ
7790 (next_element_from_buffer): Improve commentary for when
7791 the iterator is before prev_stop.
7792 (init_iterator): Initialize bidi_p from the default value of
7793 bidi-display-reordering, not from buffer-local value. Use the
7794 buffer-local value only if initializing for buffer iteration.
7795 (handle_invisible_prop): Support invisible properties on strings
7796 that are being bidi-reordered.
7797 (set_iterator_to_next): Support bidi reordering of C strings and
7798 Lisp strings.
7799 (next_element_from_string): Support bidi reordering of Lisp
7800 strings.
7801 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7802 (display_string): Support display of R2L glyph rows.
7803 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7804 (init_iterator): Don't initialize it->bidi_p for strings
7805 here.
7806 (reseat_to_string): Initialize it->bidi_p for strings here.
7807 (next_element_from_string, next_element_from_c_string)
7808 (next_element_from_buffer): Add xassert's for correspondence
7809 between IT's object being iterated and it->bidi_it.string
7810 structure.
7811 (face_before_or_after_it_pos): Support bidi iteration.
7812 (next_element_from_c_string): Handle the case of the first string
7813 character that is not the first one in the visual order.
7814 (get_visually_first_element): New function, refactored from common
7815 parts of next_element_from_buffer, next_element_from_string, and
7816 next_element_from_c_string.
7817 (tool_bar_lines_needed, redisplay_tool_bar)
7818 (display_menu_bar): Force left-to-right direction. Add a FIXME
7819 comment for making that be controlled by a user option.
7820 (push_it, pop_it): Save and restore the state of the
7821 bidi iterator. Save and restore the bidi_p flag.
7822 (pop_it): Iterate out of display property for string iteration as
7823 well.
7824 (iterate_out_of_display_property): Support iteration over strings.
7825 (handle_single_display_spec): Set up it->bidi_it for iteration
7826 over a display string, and call bidi_init_it.
7827 (handle_single_display_spec, next_overlay_string)
7828 (get_overlay_strings_1, push_display_prop): Set up the bidi
7829 iterator for displaying display or overlay strings.
7830 (forward_to_next_line_start): Don't use the shortcut if
7831 bidi-iterating.
7832 (back_to_previous_visible_line_start): If handle_display_prop
7833 pushed the iterator stack, restore the internal state of the bidi
7834 iterator by calling bidi_pop_it same number of times.
7835 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7836 and we are bidi-iterating, don't decrement the iterator position;
7837 instead, set the first_elt flag in the bidi iterator, to produce
7838 the same effect.
7839 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7840 (push_display_prop): xassert that we are iterating a buffer.
7841 (push_it, pop_it): Save and restore paragraph_embedding member.
7842 (handle_single_display_spec, next_overlay_string)
7843 (get_overlay_strings_1, reseat_1, reseat_to_string)
7844 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7845 correctly. Don't assume unibyte strings are not bidi-reordered.
7846 (compute_display_string_pos)
7847 (compute_display_string_end): Fix handling the case of C string.
7848 (push_it, pop_it): Save and restore from_disp_prop_p.
7849 (handle_single_display_spec, push_display_prop): Set the
7850 from_disp_prop_p flag.
7851 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7852 (pop_it): Call iterate_out_of_display_property only if we are
7853 popping after iteration over a string that came from a display
7854 property. Fix a typo in popping stretch info. Add an assertion
7855 for verifying that the iterator position is in sync with the bidi
7856 iterator.
7857 (handle_single_display_spec, get_overlay_strings_1)
7858 (push_display_prop): Fix initialization of paragraph direction for
7859 string when that of the parent object is not yet determined.
7860 (reseat_1): Call bidi_init_it to resync the bidi
7861 iterator with IT's position. (Bug#7616)
7862 (find_row_edges): If ROW->start.pos gives position
7863 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7864 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7865 Reset the from_disp_prop_p flag.
7866 (SAVE_IT, RESTORE_IT): New macros.
7867 (pos_visible_p, face_before_or_after_it_pos)
7868 (back_to_previous_visible_line_start)
7869 (move_it_in_display_line_to, move_it_in_display_line)
7870 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7871 (try_scrolling, redisplay_window, display_line): Use them when
7872 saving a temporary copy of the iterator and restoring it back.
7873 (back_to_previous_visible_line_start, reseat_1)
7874 (init_iterator): Empty the bidi cache "stack".
7875 (move_it_in_display_line_to): If iterator ended up at
7876 EOL, but we never saw any buffer positions smaller than
7877 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7878 motion in bidi-reordered lines.
7879 (move_it_in_display_line_to): Record prev_method and prev_pos
7880 immediately before the call to set_iterator_to_next. Fixes cursor
7881 motion in bidi-reordered lines with stretch glyphs and strings
7882 displayed in margins. (Bug#8133) (Bug#8867)
7883 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7884 TO_CHARPOS.
640c8776
SM
7885 (pos_visible_p): Support positions in bidi-reordered lines.
7886 Save and restore bidi cache.
0bb23927
EZ
7887
7888 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7889 (bidi_paragraph_info): Delete unused struct.
7890 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7891 (bidi_cache_start): New variable.
7892 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7893 to zero.
7894 (bidi_cache_fetch_state, bidi_cache_search)
7895 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7896 (bidi_cache_find, bidi_peek_at_next_level)
7897 (bidi_level_of_next_char, bidi_find_other_level_edge)
7898 (bidi_move_to_visually_next): Compare cache index with
7899 bidi_cache_start rather than with zero.
7900 (bidi_fetch_char): Accept new argument STRING; all callers
7901 changed. Support iteration over a string. Support strings with
7902 display properties. Support unibyte strings. Fix the type of
7903 `len' according to what STRING_CHAR_AND_LENGTH expects.
7904 (bidi_paragraph_init, bidi_resolve_explicit_1)
7905 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7906 (bidi_level_of_next_char, bidi_move_to_visually_next):
7907 Support iteration over a string.
0bb23927
EZ
7908 (bidi_set_sor_type, bidi_resolve_explicit_1)
7909 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7910 can now be zero (for strings); special values 0 and -1 were
7911 changed to -1 and -2, respectively.
7912 (bidi_char_at_pos): New function.
7913 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7914 Call it instead of FETCH_MULTIBYTE_CHAR.
7915 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7916 initialized to valid values.
7917 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7918 values.
7919 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7920 the test for valid cached positions. Fix the logic for looking up
7921 the sentinel state in the cache. GCPRO the Lisp string we are
7922 iterating.
7923 (bidi_push_it, bidi_pop_it): New functions.
7924 (bidi_initialize): Initialize the bidi cache start stack pointer.
7925 (bidi_cache_ensure_space): New function, refactored from part of
7926 bidi_cache_iterator_state. Don't assume the required size is just
7927 one BIDI_CACHE_CHUNK away.
7928 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7929 (bidi_count_bytes, bidi_char_at_pos): New functions.
7930 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7931 always valid if bidi_cache_idx is valid.
7932 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7933 is valid if it's going to be used.
7934 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7935 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7936 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7937 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7938 (bidi_find_other_level_edge, bidi_cache_start_stack):
7939 All variables related to cache indices are now EMACS_INT.
c965adc5 7940
0bb23927
EZ
7941 * dispextern.h (struct bidi_string_data): New structure.
7942 (struct bidi_it): New member `string'. Make flag members be 1-bit
7943 fields, and put them last in the struct.
640c8776
SM
7944 (compute_display_string_pos, compute_display_string_end):
7945 Update prototypes.
0bb23927
EZ
7946 (bidi_push_it, bidi_pop_it): Add prototypes.
7947 (struct iterator_stack_entry): New members bidi_p,
7948 paragraph_embedding, and from_disp_prop_p.
7949 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7950 (bidi_shelve_cache, bidi_unshelve_cache):
7951 Declare prototypes.
0bb23927
EZ
7952
7953 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7954 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7955 and vector-like objects.
7956
7957 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7958 cache around display iteration.
7959
7960 * window.c (Fwindow_end, window_scroll_pixel_based)
7961 (displayed_window_lines, Frecenter): Save and restore the bidi
7962 cache around display iteration.
7963
3bbd2265
LMI
79642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7965
7966 * editfns.c (Fdelete_region): Clarify the use of the named
7967 parameters (bug#6788).
7968
adc47434
MR
79692011-07-14 Martin Rudalics <rudalics@gmx.at>
7970
7971 * indent.c (Fvertical_motion): Set and restore w->pointm when
7972 saving and restoring the window's buffer (Bug#9006).
7973
837c31f8
LMI
79742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7975
7976 * editfns.c (Fstring_to_char): Clarify just what is returned
7977 (bug#6576). Text by Eli Zaretskii.
7978
ac389d0c
JB
79792011-07-13 Juanma Barranquero <lekktu@gmail.com>
7980
7981 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7982
0be0ce47
EZ
79832011-07-13 Eli Zaretskii <eliz@gnu.org>
7984
7985 * buffer.c (mmap_find): Fix a typo.
7986
cd18e7e3
JB
79872011-07-13 Johan Bockgård <bojohan@gnu.org>
7988
7989 Fix execution of x selection hooks.
7990 * xselect.c (Qx_lost_selection_functions)
7991 (Qx_sent_selection_functions): New vars.
7992 (syms_of_xselect): DEFSYM them.
7993 (x_handle_selection_request): Pass Qx_sent_selection_functions
7994 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7995 (x_handle_selection_clear,x_clear_frame_selections):
7996 Pass Qx_lost_selection_functions rather than
7997 Vx_lost_selection_functions to Frun_hook_with_args.
7998
47ea7f44
PE
79992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8000
ac389d0c 8001 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8002 The old code sometimes used this field without initializing it.
8003
47ea7f44
PE
8004 * alloc.c (gc_sweep): Don't read past end of array.
8005 In theory, the old code could also have corrupted Emacs internals,
8006 though it'd be very unlikely.
8007
bc985c87
AS
80082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8009
8010 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8011 argument. (Bug#4026)
bc985c87 8012
0cf34688
LMI
80132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8014
b3dadd76
LMI
8015 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8016 key" (bug#4257).
8017
0cf34688
LMI
8018 * window.c (Fset_window_start): Doc fix (bug#4199).
8019 (Fset_window_hscroll): Ditto.
8020
270768cd
PE
80212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8022
077e3dda 8023 Fix minor new problems caught by GCC 4.6.1.
270768cd 8024 * term.c (init_tty): Remove unused local.
490011a6 8025 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8026 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8027 not used otherwise.
270768cd 8028
b1f58454
CY
80292011-07-12 Chong Yidong <cyd@stupidchicken.com>
8030
8031 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8032
22b9578d
LMI
80332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8034
6e70ab07
LMI
8035 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8036 are the mini-buffer and the echo area (bug#3320).
8037
22b9578d
LMI
8038 * term.c (init_tty): Remove support for supdup, c10 and perq
8039 terminals, which are no longer supported (bug#1482).
8040
8974cc9f
JB
80412011-07-10 Johan Bockgård <bojohan@gnu.org>
8042
8043 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8044
a560d974
JD
80452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8046
8047 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8048 for non-popups (Bug#3642).
8049
1dae0f0a
AS
80502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8051
268c2c36 8052 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8053 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8054 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8055 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8056 * data.c (fmod): Likewise.
8057 * dispnew.c (swap_glyphs_in_rows): Likewise.
8058 * emacs.c (memory_warning_signal): Likewise.
8059 * floatfns.c (float_error): Likewise.
8060 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8061 (otf_open, font_otf_capability, generate_otf_features)
8062 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8063 Likewise.
8064 * image.c (pbm_read_file): Likewise.
8065 * indent.c (string_display_width): Likewise.
8066 * intervals.c (check_for_interval, search_for_interval)
8067 (inc_interval_count, count_intervals, root_interval)
8068 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8069 * lread.c (defalias): Likewise.
268c2c36 8070 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8071 * regex.c (set_image_of_range_1, set_image_of_range)
8072 (regex_grow_registers): Likewise.
8073 * sysdep.c (strerror): Likewise.
8074 * termcap.c (valid_filename_p, tprint, main): Likewise.
8075 * tparam.c (main): Likewise.
8076 * unexhp9k800.c (run_time_remap, save_data_space)
8077 (update_file_ptrs, read_header, write_header, calculate_checksum)
8078 (copy_file, copy_rest, display_header): Likewise.
8079 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8080 Likewise.
8081 * xdisp.c (check_it): Likewise.
8082 * xfaces.c (register_color, unregister_color, unregister_colors):
8083 Likewise.
8084 * xfns.c (print_fontset_result): Likewise.
8085 * xrdb.c (member, fatal, main): Likewise.
8086
99033785
PE
80872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8088
8089 Fix minor problems found by static checking (Bug#9031).
8090 * chartab.c (char_table_set_range, map_sub_char_table):
8091 Remove unused locals.
8092 (uniprop_table): Now static.
8093 * composite.c (_work_char): Remove unused static var.
8094
9cb2ac56
JB
80952011-07-09 Juanma Barranquero <lekktu@gmail.com>
8096
8097 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8098
f25661f0
JD
80992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8100
8101 * gtkutil.c (qttip_cb): Remove code without function.
8102
8278c4fe
EZ
81032011-07-09 Eli Zaretskii <eliz@gnu.org>
8104
8105 * w32.c (pthread_sigmask): New stub.
8106
1692ae2d 81072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8108
8a6ebd58 8109 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8110 sigprocmask is portable only for single-threaded applications, and
8111 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8112 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8113 (LIBES): Use it.
8114 * callproc.c (Fcall_process):
8115 * process.c (create_process):
8116 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8117 Use pthread_sigmask, not sigprocmask.
123403e4 8118
1b854618
JD
81192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8120
8121 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8122 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8123 wrong (Bug#8591).
8124
3fe4b549
JD
81252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8126
0ce7e563
JD
8127 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8128 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8129 (xg_hide_tooltip): Fix comment.
8130
3fe4b549
JD
8131 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8132 in registerServicesMenuSendTypes.
8133 (validRequestorForSendType): Don't check ns_return_types.
8134
8135 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8136 ns_return_type.
8137
5df75e47
JR
81382011-07-08 Jason Rumney <jasonr@gnu.org>
8139
22610910
JR
8140 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8141 SH_SHOW for hidden windows (Bug#5482).
8142
5df75e47
JR
8143 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8144 frame struct members of non-existent frames (Bug#6284).
8145
699c10bd
JD
81462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8147
4393663b
JD
8148 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8149 variable firstTime not needed on OSX >= 10.6.
8150 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8151 >= 10.5. Use setKnobProportion, setDoubleValue.
8152
8153 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8154 (MAC_OS_X_VERSION_10_5): Define if not defined.
8155 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8156 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8157 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8158
8159 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8160 cString and lossyCString on OSX >= 10.4.
4393663b 8161
58179cce 8162 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8163 sizeToFit on OSX >= 10.2.
8164
8165 * nsimage.m (allocInitFromFile): Don't use deprecated method
8166 bestRepresentationForDevice on OSX >= 10.6.
8167
8168 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8169 to avoid warning.
8170
8171 * emacs.c: Declare unexec_init_emacs_zone.
8172
a63e0781
JD
8173 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8174
699c10bd
JD
8175 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8176
8177 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8178 on svcsMenu (Bug#8842).
8179
8180 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8181 ns_return_types.
8182 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8183
8184 * nsterm.m (QUTF8_STRING): Declare.
8185 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8186 (validRequestorForSendType): Return type is (id).
8187 Change indexOfObjectIdenticalTo to indexOfObject.
8188 Check if we have local selection before returning self (Bug#8842).
8189 (writeSelectionToPasteboard): Put local selection into paste board
8190 if we have a local selection (Bug#8842).
8191 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8192
8193 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8194 (ns_get_local_selection): Declare.
8195
54e10184
LMI
81962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8197
9888ff71
LMI
8198 * keymap.c (describe_map_tree): Don't insert a double newline at
8199 the end of the buffer (bug#1169) and return whether we inserted
8200 something.
8201
54e10184
LMI
8202 * callint.c (Fcall_interactively): Change "reading args" to
8203 "providing args" to try to clarify what it does (bug#1010).
8204
15fa4783
KH
82052011-07-07 Kenichi Handa <handa@m17n.org>
8206
8207 * composite.c (composition_compute_stop_pos): Ignore a static
8208 composition starting before CHARPOS (Bug#8915).
8209
8210 * xdisp.c (handle_composition_prop): Likewise.
8211
a8815b00
EZ
82122011-07-07 Eli Zaretskii <eliz@gnu.org>
8213
8214 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8215 (Bug#9015)
8216
ef7b981d 82172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8218
8219 * character.h (unicode_category_t): New enum type.
8220
8221 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8222 (Qchar_code_property_table): New variable.
8223 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8224 (UNIPROP_COMPRESSED_FORM_P): New macros.
8225 (char_table_ascii): Uncompress the compressed values.
8226 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8227 Uncompress the compressed values.
ac389d0c 8228 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8229 (char_table_ref_and_range): Uncompress the compressed values.
8230 (sub_char_table_set): New arg is_uniprop. Callers changed.
8231 Uncompress the compressed values.
8232 (sub_char_table_set_range): Args changed. Callers changed.
8233 (char_table_set_range): Adjuted for the above change.
8234 (map_sub_char_table): Delete args default_val and parent. Add arg
8235 top. Give decoded values to a Lisp function.
640c8776 8236 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8237 values to a Lisp function. Gcpro more variables.
8238 (uniprop_table_uncompress)
8239 (uniprop_decode_value_run_length): New functions.
8240 (uniprop_decoder, uniprop_decoder_count): New variables.
8241 (uniprop_get_decoder, uniprop_encode_value_character)
8242 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8243 New functions.
8244 (uniprop_encoder, uniprop_encoder_count): New variables.
8245 (uniprop_get_encoder, uniprop_table)
8246 (Funicode_property_table_internal, Fget_unicode_property_internal)
8247 (Fput_unicode_property_internal): New functions.
8248 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8249 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8250 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8251 char-code-property-alist.
8252
640c8776 8253 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8254 Vunicode_category_table.
8255
640c8776 8256 * font.c (font_range): Adjust for the change of
c805dec0
KH
8257 Vunicode_category_table.
8258
76b397fb
DN
82592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8260
8261 * m/iris4d.h: Remove file, move contents ...
8262 * s/irix6-5.h: ... here.
8263
22b4128e
PE
82642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8265
8266 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8267 * alloc.c (mark_buffer):
8268 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8269 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8270 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8271 This isn't true in general, and it's particularly not true
8272 if Emacs is configured with --with-wide-int.
8273 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8274 New macros, used in the buffer.c change.
8275
869795d6
JD
82762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8277
8278 * xsettings.c: Use both GConf and GSettings if both are available.
8279 (store_config_changed_event): Add comment.
8280 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8281 (store_tool_bar_style_changed): New functions.
5e617bc2 8282 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8283 (struct xsettings): Move font inside HAVE_XFT.
8284 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8285 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8286 Move inside HAVE_XFT.
640c8776 8287 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8288 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8289 also.
8290 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8291 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8292 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8293 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8294 (parse_settings): Move check for font inside HAVE_XFT.
8295 (read_settings, apply_xft_settings): Add comment.
8296 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8297 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8298 call store_font_name_changed.
8299 (xft_settings_event): Add comment.
8300 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8301 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8302 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8303 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8304 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8305 (xsettings_get_system_font, xsettings_get_system_normal_font):
8306 Add comment.
869795d6 8307
d8ed26bd
PE
83082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8309
8310 Random fixes. E.g., (random) never returned negative values.
8311 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8312 subseconds part to the entropy, as that's a bit more random.
8313 Prefer signed to unsigned, since the signedness doesn't matter and
8314 in general we prefer signed. When given a limit, use a
8315 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8316 latter isn't right if USE_2_TAGS_FOR_INTS.
8317 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8318 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8319
cabf1cac
SM
83202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8321
8322 * textprop.c (text_property_stickiness):
8323 Obey Vtext_property_default_nonsticky.
8324 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8325 * w32fns.c (syms_of_w32fns):
8326 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8327
6e9b2be9
PE
83282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8329
8330 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8331 This is more efficient than Ffile_directory_p and avoids a minor race.
8332
90186c68
LMI
83332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8334
7c301272
LMI
8335 * buffer.c (Foverlay_put): Say what the return value is
8336 (bug#7835).
8337
c4f2d8d4
LMI
8338 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8339 is a directory before asking whether to use the file name
8340 (bug#7564).
ad637907
LMI
8341 (barf_or_query_if_file_exists): Make the "File is a directory"
8342 error be more correct.
c4f2d8d4 8343
90186c68
LMI
8344 * fns.c (Frequire): Remove the mention of the .gz files, since
8345 that's installation-specific, but keep the mention of
8346 `get-load-suffixes'.
8347
da64016e
PE
83482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8349
8350 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8351 Report string overflow if the output is too long.
8352
7d47b580
JB
83532011-07-04 Juanma Barranquero <lekktu@gmail.com>
8354
a555cb87
JB
8355 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8356 (syms_of_gnutls): Remove duplicate DEFSYM for
8357 Qgnutls_bootprop_verify_hostname_error, an error for
8358 Qgnutls_bootprop_verify_error (which is no longer used).
8359
7d47b580
JB
8360 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8361 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8362 Also (re)move comments that are misplaced or no longer relevant.
8363
1e49bfab
LMI
83642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8365
8366 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8367
1485f4c0
CY
83682011-07-03 Chong Yidong <cyd@stupidchicken.com>
8369
8370 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8371 and background color parameters if they have been changed.
8372
a9ab721e
LMI
83732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8374
8375 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8376
cf7cff57
PE
83772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8378
2e13213d
PE
8379 * xsettings.c (SYSTEM_FONT): Define only when used.
8380 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8381
cf7cff57
PE
8382 * keymap.c (access_keymap_1): Now static.
8383
7a8e04f7
CY
83842011-07-02 Chong Yidong <cyd@stupidchicken.com>
8385
8386 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8387 leave any prefix arg for the up event (Bug#1586).
8388
61352f62
LMI
83892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8390
69bb1ef7
LMI
8391 * lread.c (syms_of_lread): Mention single symbols defined by
8392 `defvar' or `defconst' (bug#7154).
8393
61352f62 8394 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8395 (Frequire): Mention get-load-suffixes.
61352f62 8396
28545e04
MR
83972011-07-02 Martin Rudalics <rudalics@gmx.at>
8398
8399 * window.h (window): Remove clone_number slot.
8400 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8401 Remove.
8402 (make_parent_window, make_window, saved_window)
8403 (Fset_window_configuration, save_window_save): Don't deal with
8404 clone numbers.
8405 * buffer.c (Qclone_number): Remove declaration.
8406 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8407
3349e122
SM
84082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8409
8410 Add multiple inheritance to keymaps.
8411 * keymap.c (Fmake_composed_keymap): New function.
8412 (Fset_keymap_parent): Simplify.
8413 (fix_submap_inheritance): Remove.
8414 (access_keymap_1): New function extracted from access_keymap to handle
8415 embedded parents and handle lists of maps.
8416 (access_keymap): Use it.
8417 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8418 (Fcopy_keymap): Handle embedded parents.
8419 (Fcommand_remapping, define_as_prefix): Simplify.
8420 (Fkey_binding): Simplify.
8421 (syms_of_keymap): Move minibuffer-local-completion-map,
8422 minibuffer-local-filename-completion-map,
8423 minibuffer-local-must-match-map, and
8424 minibuffer-local-filename-must-match-map to Elisp.
8425 (syms_of_keymap): Defsubr make-composed-keymap.
8426 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8427 (parse_menu_item): Trivial simplification.
8428
3279eb87
GM
84292011-07-01 Glenn Morris <rgm@gnu.org>
8430
8431 * Makefile.in (SETTINGS_LIBS): Fix typo.
8432
4550efdf
KI
84332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8434
8435 * coding.c (Fencode_coding_string): Record the last coding system
8436 used, as the function doc string says (bug#8738).
8437
0949d2b6
JD
84382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8439
8440 * xsettings.c (store_monospaced_changed): Take new font as arg and
8441 check for change against current_mono_font.
8442 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8443 (emacs_settings_constructor, emacs_settings_get_property)
8444 (emacs_settings_set_property, emacs_settings_class_init)
8445 (emacs_settings_init, gsettings_obj): Remove.
8446 (something_changedCB): New function for HAVE_GSETTINGS.
8447 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8448 with value as argument.
8449 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8450 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8451 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8452 "changed".
8453
8454 * xgselect.c: Add defined (HAVE_GSETTINGS).
8455 (xgselect_initialize): Ditto.
8456
8457 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8458 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8459 xg_select.
8460
bbc6b304
PE
84612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8462
8463 * eval.c (struct backtrace): Simplify and port the data structure.
8464 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8465 signed bit field, as this assumption is not portable and it makes
8466 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8467 "char debug_on_exit : 1" as this is not portable either; instead,
8468 use the portable "unsigned int debug_on_exit : 1". Remove unused
8469 member evalargs. Remove obsolete comments about cc bombing out.
8470
9851bfc5
JD
84712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8472
51bb811f 8473 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8474 Let HAVE_GSETTINGS override HAVE_GCONF.
8475 (store_monospaced_changed): New function.
8476 (EMACS_SETTINGS): A new type derived from GObject to handle
8477 GSettings notifications.
8478 (emacs_settings_constructor, emacs_settings_get_property)
8479 (emacs_settings_set_property, emacs_settings_class_init):
8480 New functions.
8481 (gsettings_client, gsettings_obj): New variables.
8482 (GSETTINGS_SCHEMA): New define.
8483 (something_changedCB): Call store_monospaced_changed.
8484 (init_gsettings): New function.
8485 (xsettings_initialize): Call init_gsettings.
8486 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8487 to NULL.
8488
640c8776 8489 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8490 GCONF_CFLAGS/LIBS.
8491
5386012d
MR
84922011-06-29 Martin Rudalics <rudalics@gmx.at>
8493
8494 * window.c (resize_root_window, grow_mini_window)
8495 (shrink_mini_window): Rename Qresize_root_window to
8496 Qwindow_resize_root_window and Qresize_root_window_vertically to
8497 Qwindow_resize_root_window_vertically.
8498
f13e0b08
PE
84992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8500
8501 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8502
94515237
JB
85032011-06-27 Juanma Barranquero <lekktu@gmail.com>
8504
8505 * makefile.w32-in: Redesign dependencies so they reflect more
8506 clearly which files are directly included by each source file,
8507 and not through other includes.
8508
e43b6e43
MR
85092011-06-27 Martin Rudalics <rudalics@gmx.at>
8510
8511 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8512 (sort_overlays, overlay_strings): When an overlay's clone number
8513 matches the window's clone number process the overlay even if
8514 the overlay's window property doesn't match the current window.
8515
d68443dc
MR
8516 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8517 (Fwindow_hchild): Rename to Fwindow_left_child.
8518 (Fwindow_next): Rename to Fwindow_next_sibling.
8519 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8520 (resize_window_check): Rename to window_resize_check.
8521 (resize_window_apply): Rename to window_resize_apply.
8522 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8523 (Fdelete_other_windows_internal, resize_frame_windows)
8524 (Fsplit_window_internal, Fdelete_window_internal)
8525 (grow_mini_window, shrink_mini_window)
8526 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8527
c7e73be5
JD
85282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8529
8530 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8531 (emacs_fixed_set_min_size): Remove.
8532 (emacs_fixed_new): Take frame as argument.
8533
8534 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8535 (_EmacsFixedPrivate): Remove minwidth/height.
8536 Add struct frame *f.
8537 (emacs_fixed_init): Initialize priv->f.
8538 (get_parent_class, emacs_fixed_set_min_size): Remove.
8539 (emacs_fixed_new): Set priv->f to argument.
8540 (emacs_fixed_get_preferred_width)
8541 (emacs_fixed_get_preferred_height): Use min_width/height from
8542 frames size_hint to set minimum and natural (Bug#8919).
8543 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8544 and use min_width/height from frames size_hint to set
8545 min_width/height (Bug#8919).
8546
8547 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8548 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8549 Fix indentation.
c7e73be5 8550
cf99dcf8
EZ
85512011-06-26 Eli Zaretskii <eliz@gnu.org>
8552
8553 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8554 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8555 called at ZV.
8556
029529ac
CY
85572011-06-26 Chong Yidong <cyd@stupidchicken.com>
8558
8559 * process.c (wait_reading_process_output): Bypass select if
8560 waiting for a cell while ignoring keyboard input, and input is
8561 pending. Suggested by Jan Djärv (Bug#8869).
8562
7a7ef429
PE
85632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8564
8565 Use gnulib's dup2 module instead of rolling our own.
8566 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8567
11fdef7d 85682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8569
8570 * dispnew.c (scrolling_window): Before scrolling, turn off a
8571 mouse-highlight in the window being scrolled.
8572
cd3520a4
JB
85732011-06-24 Juanma Barranquero <lekktu@gmail.com>
8574
8575 Move DEFSYM to lisp.h and use everywhere.
8576
8577 * character.h (DEFSYM): Move declaration...
8578 * lisp.h (DEFSYM): ...here.
8579
8580 * gnutls.c:
8581 * minibuf.c:
8582 * w32menu.c:
8583 * w32proc.c:
8584 * w32select.c: Don't include character.h.
8585
8586 * alloc.c (syms_of_alloc):
8587 * buffer.c (syms_of_buffer):
8588 * bytecode.c (syms_of_bytecode):
8589 * callint.c (syms_of_callint):
8590 * casefiddle.c (syms_of_casefiddle):
8591 * casetab.c (init_casetab_once):
8592 * category.c (init_category_once, syms_of_category):
8593 * ccl.c (syms_of_ccl):
8594 * cmds.c (syms_of_cmds):
8595 * composite.c (syms_of_composite):
8596 * dbusbind.c (syms_of_dbusbind):
8597 * dired.c (syms_of_dired):
8598 * dispnew.c (syms_of_display):
8599 * doc.c (syms_of_doc):
8600 * editfns.c (syms_of_editfns):
8601 * emacs.c (syms_of_emacs):
8602 * eval.c (syms_of_eval):
8603 * fileio.c (syms_of_fileio):
8604 * fns.c (syms_of_fns):
8605 * frame.c (syms_of_frame):
8606 * fringe.c (syms_of_fringe):
8607 * insdel.c (syms_of_insdel):
8608 * keymap.c (syms_of_keymap):
8609 * lread.c (init_obarray, syms_of_lread):
8610 * macros.c (syms_of_macros):
8611 * msdos.c (syms_of_msdos):
8612 * print.c (syms_of_print):
8613 * process.c (syms_of_process):
8614 * search.c (syms_of_search):
8615 * sound.c (syms_of_sound):
8616 * syntax.c (init_syntax_once, syms_of_syntax):
8617 * terminal.c (syms_of_terminal):
8618 * textprop.c (syms_of_textprop):
8619 * undo.c (syms_of_undo):
8620 * w32.c (globals_of_w32):
8621 * window.c (syms_of_window):
8622 * xdisp.c (syms_of_xdisp):
8623 * xfaces.c (syms_of_xfaces):
8624 * xfns.c (syms_of_xfns):
8625 * xmenu.c (syms_of_xmenu):
8626 * xsettings.c (syms_of_xsettings):
8627 * xterm.c (syms_of_xterm): Use DEFSYM.
8628
4228cf16
TZ
86292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8630
cd3520a4 8631 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8632
7fcccf1e
PE
86332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8634
7efb4e0e
PE
8635 Integer and buffer overflow fixes (Bug#8873).
8636
ff5844ad
PE
8637 * print.c (printchar, strout): Check for string overflow.
8638 (PRINTPREPARE, printchar, strout):
8639 Don't set size unless allocation succeeds.
8640
90532f02
PE
8641 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8642 for sizes. Check for string overflow more accurately.
8643 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8644
6d84508d
PE
8645 * macros.c: Integer and buffer overflow fixes.
8646 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8647 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8648 Use ptrdiff_t, not int, for sizes.
8649 Don't increment bufsize until after realloc succeeds.
8650 Check for size-calculation overflow.
8651 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8652
437b2cb4
PE
8653 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8654
8b9ac8b4
PE
8655 * lread.c: Integer overflow fixes.
8656 (read_integer): Radix is now EMACS_INT, not int,
8657 to improve quality of diagnostics for out-of-range radices.
8658 Calculate buffer size correctly for out-of-range radices.
8659 (read1): Check for integer overflow in radices, and in
8660 read-circle numbers.
82cb60d3
PE
8661 (read_escape): Avoid int overflow.
8662 (Fload, openp, read_buffer_size, read1)
8663 (substitute_object_recurse, read_vector, read_list, map_obarray):
8664 Use ptrdiff_t, not int, for sizes.
8665 (read1): Use EMACS_INT, not int, for sizes.
20270765 8666 Check for size overflow.
8b9ac8b4 8667
7fcccf1e
PE
8668 * image.c (cache_image): Check for size arithmetic overflow.
8669
bfbbd7e7
PE
8670 * lread.c: Integer overflow issues.
8671 (saved_doc_string_size, saved_doc_string_length)
8672 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8673 Now ptrdiff_t, not int.
8674 (read1): Don't assume doc string length fits in int. Check for
8675 out-of-range doc string lengths.
8676 (read_list): Don't assume file position fits in int.
39019e54 8677 (read_escape): Check for hex character overflow.
bfbbd7e7 8678
4e323265
LL
86792011-06-22 Leo Liu <sdl.web@gmail.com>
8680
8681 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8682 Move to minibuffer.el.
8683
85fece3e
PE
86842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8685
20b84ce9 8686 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8687 The following patches are for when GLYPH_DEBUG && !XASSERT.
8688 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8689 * dispnew.c (flush_stdout):
8690 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8691 Mark as externally visible.
8692 * dispnew.c (check_window_matrix_pointers): Now static.
8693 * dispnew.c (window_to_frame_vpos):
8694 * xfns.c (unwind_create_frame):
8695 * xterm.c (x_check_font): Remove unused local.
8696 * scroll.c (CHECK_BOUNDS):
8697 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8698 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8699 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8700 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8701 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8702 Now static.
8703 (debug_method_add): Use va_list and vsprintf rather than relying
8704 on undefined behavior with wrong number of arguments.
8705 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8706 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8707 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8708 since we're not interested in debugging glyphs with old libraries.
8709 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8710 GCC 4.6.0's static checking.
8711
0766b489
PE
87122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8713
31fd4b32
PE
8714 Integer overflow and signedness fixes (Bug#8873).
8715 A few related buffer overrun fixes, too.
8716
b79e8648
PE
8717 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8718
0766b489
PE
8719 * dispextern.h (struct face.stipple):
8720 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8721 (x_bitmap_mask, x_allocate_bitmap_record)
8722 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8723 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8724 (x_create_bitmap_from_xpm_data):
8725 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8726 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8727 (.bitmaps_last):
8728 * xfaces.c (load_pixmap):
8729 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8730 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8731 (.bitmaps_last, struct x_output.icon_bitmap):
8732 Use ptrdiff_t, not int, for bitmap indexes.
8733 (x_allocate_bitmap_record): Check for size overflow.
8734 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8735
b081724f
PE
8736 Use ptrdiff_t, not int, for overlay counts.
8737 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8738 * editfns.c (overlays_around, get_pos_property):
8739 * textprop.c (get_char_property_and_overlay):
8740 * xdisp.c (next_overlay_change, note_mouse_highlight):
8741 * xfaces.c (face_at_buffer_position):
21514da7
PE
8742 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8743 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8744 (Fnext_overlay_change, Fprevious_overlay_change)
8745 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8746 Use ptrdiff_t, not int, for sizes.
21514da7 8747 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8748
3de73e5e
PE
8749 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8750
2606c57b
PE
8751 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8752 (x_session_initialize): Do not assume string length fits in int.
8753
aaafe47a
PE
8754 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8755 This is unlikely, but can occur if DPI is outlandish.
8756
2674ddc8 8757 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8758 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8759
28154962
PE
8760 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8761 * xrdb.c (magic_file_p, search_magic_path):
8762 Omit last arg SUFFIX; it was always 0. All callers changed.
8763 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8764
7de51af5
PE
8765 * xfont.c (xfont_match): Avoid need for strlen.
8766
25ed6cc3
PE
8767 * xfns.c: Don't assume strlen fits in int.
8768 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8769
4eab31dd
PE
8770 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8771 not unsigned long, as we prefer signed integers. All callers changed.
8772 Detect integer overflow in repeat count.
8773 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8774 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8775
171e2a58
PE
8776 * termcap.c: Don't assume sizes fit in int and never overflow.
8777 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8778 (gobble_line): Check for size-calculation overflow.
8779
ad39faca 8780 * minibuf.c (Fread_buffer):
6e5bb2dc 8781 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8782 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8783 Don't assume string length fits in int.
8784
52c61c22 8785 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8786 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8787
b5b8c9e5
PE
8788 * font.c: Don't assume string length fits in int.
8789 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8790 Use ptrdiff_t, not int.
ccd6111c
PE
8791 (font_intern_prop): Don't assume string length fits in int.
8792 Don't assume integer property fits in fixnum.
8793 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8794
882f0d81 8795 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8796 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8797 Reformulate so as not to need the command string.
8798 Invoke gzip -cd rather than gunzip, as it's more portable.
8799 (lock_info_type, lock_file_1, lock_file):
8800 Don't assume pid_t and time_t fit in unsigned long.
8801 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8802 (current_lock_owner): Prefer signed type for sizes.
8803 Use memcpy, not strncpy, where memcpy is what is really wanted.
8804 Don't assume (via atoi) that time_t and pid_t fit in int.
8805 Check for time_t and/or pid_t out of range, e.g., via a network share.
8806 Don't alloca where an auto var works fine.
8807
93f4cf88
PE
8808 * fileio.c: Fix some integer overflow issues.
8809 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8810 Don't assume string length fits in int.
8811 (directory_file_name): Don't assume string length fits in long.
8812 (make_temp_name): Don't assume pid fits in int, or that its print
8813 length is less than 20.
8814
f3e92b69
PE
8815 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8816
1bfdaf10
PE
8817 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8818
35016e9a
PE
8819 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8820
3d1e65a1
PE
8821 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8822 We prefer signed integers, even for size calculations.
8823
0b963a93
PE
8824 * emacs.c: Don't assume string length fits in 'int'.
8825 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8826 (main): Don't invoke strlen when not needed.
8827
573f4b54
PE
8828 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8829 (XD_DEBUG_MESSAGE): Don't waste a byte.
8830
989f33ba
PE
8831 * callproc.c (getenv_internal_1, getenv_internal)
8832 (Fgetenv_internal):
965d34eb
PE
8833 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8834
e4d29b33
PE
8835 * lread.c (invalid_syntax): Omit length argument.
8836 All uses changed. This doesn't fix a bug, but it simplifies the
8837 code away from its former Hollerith-constant appearance, and it's
8838 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8839 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8840
eb49b136
PE
8841 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8842 This didn't break anything, but it didn't help either.
8843 It's confusing to put a bogus integer in a place where the actual
8844 value does not matter.
9f62aeb1 8845 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8846 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8847
15375a22
PE
8848 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8849 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8850 implementation.
b61cc01c
PE
8851 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8852 We prefer signed types, and the value cannot exceed the EMACS_INT
8853 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8854 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8855 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8856 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8857
53b2623d
PE
8858 * indent.c (sane_tab_width): New function.
8859 (current_column, scan_for_column, Findent_to, position_indentation)
8860 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8861 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8862
51cab52b 8863 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8864
f2ed8a70
PE
8865 * lisp.h (lint_assume): New macro.
8866 * composite.c (composition_gstring_put_cache):
8867 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8868
abe80cc6
PE
8869 * editfns.c, insdel.c:
8870 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8871
b02c740e
PE
8872 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8873
ebc96716
PE
8874 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8875
b4e50fa0 8876 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8877 Use much-faster test for byte-length change.
311d5d7c 8878 Don't assume string byte-length fits in 'int'.
a4cf38e4 8879 Check that character arg fits in 'int'.
85461888 8880 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8881
c0c1ee9f
PE
8882 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8883
a498d7f4
PE
8884 * fns.c (concat): Catch string overflow earlier.
8885 Do not rely on integer wraparound.
8886
51cab52b
PE
8887 * dispextern.h (struct it.overlay_strings_charpos)
8888 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8889 * xdisp.c (forward_to_next_line_start)
8890 (back_to_previous_visible_line_start)
8891 (reseat_at_next_visible_line_start, next_element_from_buffer):
8892 Don't arbitrarily truncate the value of 'selective' to int.
8893
76031fad
PE
8894 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8895
5eb55db9
PE
8896 * composite.c: Don't truncate sizes to 'int'.
8897 (composition_gstring_p, composition_reseat_it)
8898 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8899 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8900 not EMACS_UINT, for indexes.
5eb55db9 8901
0703a717
PE
8902 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8903
d6202519
PE
8904 * buffer.c: Include <verify.h>.
8905 (struct sortvec.priority, struct sortstr.priority):
8961a454 8906 Now EMACS_INT, not int.
c20998a7 8907 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8908 (struct sortstr.size, record_overlay_string)
8909 (struct sortstrlist.size, struct sortlist.used):
8910 Don't truncate size to int.
8911 (record_overlay_string): Check for size-calculation overflow.
d6202519 8912 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8913
d5a19415
JM
89142011-06-22 Jim Meyering <meyering@redhat.com>
8915
029529ac 8916 Don't leak an XBM-image-sized buffer
d5a19415
JM
8917 * image.c (xbm_load): Free the image buffer after using it.
8918
a9041e6c
PE
89192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8920
8921 Port to Sun C.
8922 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8923 that Sun C diagnosed.
8924 * fns.c (secure_hash): Fix pointer signedness issue.
8925 * intervals.c (static_offset_intervals): New function.
8926 (offset_intervals): Use it.
8927
7f3f739f
LL
89282011-06-21 Leo Liu <sdl.web@gmail.com>
8929
8930 * deps.mk (fns.o):
8931 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8932 sha512.h.
8933
8934 * fns.c (secure_hash): Rename from crypto_hash_function and change
8935 the first arg to accept symbols.
5b66d427 8936 (Fsecure_hash): New primitive.
7f3f739f
LL
8937 (syms_of_fns): New symbols.
8938
76147d94
DD
89392011-06-20 Deniz Dogan <deniz@dogan.se>
8940
8941 * process.c (Fset_process_buffer): Clarify return value in
8942 docstring.
8943
7d7d0045
CY
89442011-06-18 Chong Yidong <cyd@stupidchicken.com>
8945
8946 * dispnew.c (add_window_display_history): Use BVAR.
8947
8948 * xdisp.c (debug_method_add): Use BVAR.
8949 (check_window_end, dump_glyph_matrix, dump_glyph)
8950 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8951
8952 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8953 Likewise.
8954
8955 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8956 check till after the cache is created in init_frame_faces.
8957
ff2bc410
SM
89582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8959
8960 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8961
28177add
PE
89622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8963
dd3482fe
PE
8964 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8965 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8966 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8967
393d71f3 8968 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8969 * fileio.c (Finsert_file_contents):
8970 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8971 Remove the old (too-loose) buffer overflow checks.
8972 They weren't needed, since make_gap checks for buffer overflow.
8973 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8974 The old code merely checked for Emacs fixnum overflow, and relied
8975 on undefined (wraparound) behavior. The new code avoids undefined
8976 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8977
2e6813b0 8978 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8979 Tune. Don't use wider integers than needed. Don't use alloca.
8980 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8981
599a9e4f
PE
8982 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8983
99561444
PE
8984 * insdel.c, lisp.h (buffer_overflow): New function.
8985 (insert_from_buffer_1, replace_range, replace_range_2):
8986 * insdel.c (make_gap_larger):
8987 * editfns.c (Finsert_char):
8988 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8989
28177add
PE
8990 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8991
e69dafad
PE
89922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8993
4baa020d 8994 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8995
b1c46f02
PE
8996 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8997 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8998
e69dafad
PE
8999 * fileio.c: Don't assume EMACS_INT fits in off_t.
9000 (emacs_lseek): New static function.
9001 (Finsert_file_contents, Fwrite_region): Use it.
9002 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9003
566684ea
PE
9004 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9005
e6966cd6
PE
9006 * fns.c: Don't overflow int when computing a list length.
9007 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9008 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9009 truncation on 64-bit hosts. Check for QUIT every
9010 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9011 faster and is responsive enough.
9012 (Flength): Report an error instead of overflowing an integer.
9013 (Fsafe_length): Return a float if the value is not representable
9014 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9015 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9016 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9017
dd0b0efb
PE
9018 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9019 (header_size, word_size): New constants.
9020 (allocate_vectorlike): Don't check size overflow here.
9021 (allocate_vector): Check it here instead, since this is the only
9022 caller of allocate_vectorlike that could cause overflow.
9023 Check that the new vector's length is representable as a fixnum.
9024
86fe5cfe
PE
9025 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9026 The previous code was bogus. For example, next_almost_prime (32)
9027 returned 39, which is undesirable as it is a multiple of 3; and
9028 next_almost_prime (24) returned 25, which is a multiple of 5 so
9029 why was the code bothering to check for multiples of 7?
9030
80e88859
PE
9031 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9032
4a2f0ad6
PE
9033 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9034
f66c7cf8
PE
9035 Variadic C functions now count arguments with ptrdiff_t.
9036 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9037 Back then I didn't know that the Emacs coding style prefers signed int.
9038 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9039 were being counted with int, which may truncate counts on 64-bit
9040 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9041 * lisp.h (struct Lisp_Subr.function.aMANY)
9042 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9043 Arg counts are now ptrdiff_t, not size_t.
9044 All variadic functions and their callers changed accordingly.
9045 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9046 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9047 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9048 * callint.c (Fcall_interactively): Check arg count for overflow,
9049 to avoid potential buffer overrun. Use signed char, not 'int',
9050 for 'varies' array, so that we needn't bother to check its size
9051 calculation for overflow.
9052 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9053 * eval.c (apply_lambda):
9054 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9055 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9056 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9057
a1759b76
PE
9058 * callint.c (Fcall_interactively): Don't use index var as event count.
9059
d96be9fc
PE
9060 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9061 * mem-limits.h (SIZE): Remove; no longer used.
9062
a690a978 9063 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9064
578c21e6
PE
9065 Remove unnecessary casts.
9066 * xterm.c (x_term_init):
9067 * xfns.c (x_set_border_pixel):
9068 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9069 These aren't needed now that we assume ANSI C.
9070
96f53c6c
PE
9071 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9072 It's more likely to cause problems (due to unsigned overflow)
9073 than to cure them.
9074
83c77d31
PE
9075 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9076
ee2079f1
PE
9077 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9078
6da65536
PE
9079 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9080
7147c4a4
PE
9081 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9082
193e32d9
PE
9083 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9084
e5533da6
PE
9085 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9086
9910e595
PE
9087 GLYPH_CODE_FACE returns EMACS_INT, not int.
9088 * dispextern.h (merge_faces):
9089 * xfaces.c (merge_faces):
01103c44
PE
9090 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9091 Don't assume EMACS_INT fits in int.
9910e595 9092
2638320e
PE
9093 * character.h (CHAR_VALID_P): Remove unused parameter.
9094 * fontset.c, lisp.h, xdisp.c: All uses changed.
9095
045eb8d9
PE
9096 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9097
c1f134b5
PE
9098 * fns.c (concat): Minor tuning based on overflow analysis.
9099 This doesn't fix any bugs. Use int to hold character, instead
9100 of constantly refetching from Emacs object. Use XFASTINT, not
9101 XINT, for value known to be a character. Don't bother comparing
9102 a single byte to 0400, as it's always less.
9103
395fcb93 9104 * floatfns.c (Fexpt):
327eeec8
PE
9105 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9106
abbd3d23
PE
9107 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9108 for characters.
9109
684a03ef
PE
9110 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9111
0fed43f3
PE
9112 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9113 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9114 incorrectly succeed when S was a string, because 4294967386 was
9115 truncated before it was used.
9116
8fd02eb7
PE
9117 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9118 Otherwise, an out-of-range integer could cause undefined behavior
9119 on a 64-bit host.
9120
f8c86b69
PE
9121 * composite.c: Use int, not EMACS_INT, for characters.
9122 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9123 EMACS_INT, for values that are known to be in character range.
9124 This doesn't fix any bugs but is the usual style inside Emacs and
9125 may generate better code on 32-bit machines.
9126
34206dd2
PE
9127 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9128 This is for reasons similar to the recent CHAR_STRING fix.
9129 * charset.c (Fencode_char): Check that character arg is actually
9130 a character. Pass an int to ENCODE_CHAR.
9131 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9132 wider than 'int', as a compile-time check to prevent future regressions
9133 in this area.
9134
c5958d4c 9135 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9136
9137 Make sure a 64-bit char is never passed to CHAR_STRING.
9138 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9139 by silently ignoring the top 32 bits, allowing some values
9140 that were far too large to be valid characters.
9141 * character.h: Include <verify.h>.
9142 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9143 arguments are no wider than unsigned, as a compile-time check
9144 to prevent future regressions in this area.
9145 * data.c (Faset):
01103c44 9146 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9147 (Fsubst_char_in_region):
9148 * fns.c (concat):
9149 * xdisp.c (decode_mode_spec_coding):
9150 Adjust to CHAR_STRING's new requirement.
9151 * editfns.c (Finsert_char, Fsubst_char_in_region):
9152 * fns.c (concat): Check that character args are actually
9153 characters. Without this test, these functions did the wrong
9154 thing with wildly out-of-range values on 64-bit hosts.
9155
d37ca623
PE
9156 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9157 These casts should not be needed on 32-bit hosts, either.
9158 * keyboard.c (read_char):
9159 * lread.c (Fload): Remove casts to unsigned.
9160
ea204efb
PE
9161 * lisp.h (UNSIGNED_CMP): New macro.
9162 This fixes comparison bugs on 64-bit hosts.
9163 (ASCII_CHAR_P): Use it.
9164 * casefiddle.c (casify_object):
01103c44 9165 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9166 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9167 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9168 * dispextern.h (FACE_FROM_ID):
9169 * keyboard.c (read_char): Use UNSIGNED_CMP.
9170
41cb286c
PE
9171 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9172 not to EMACS_INT, to avoid GCC warning.
9173
4a1b9832
PE
9174 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9175
55daad71
PE
9176 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9177 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9178 isn't needed on 32-bit machines.
8f95c75c 9179
01103c44
PE
9180 * buffer.c (Fgenerate_new_buffer_name):
9181 Use EMACS_INT for count, not int.
0ceccced 9182 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9183
9184 * data.c (Qcompiled_function): Now static.
9185
c6f072e7
PE
9186 * window.c (window_body_lines): Now static.
9187
20ce5912
PE
9188 * image.c (gif_load): Rename local to avoid shadowing.
9189
9c4c5f81
PE
9190 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9191 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9192 * alloc.c (make_save_value): Integer argument is now of type
9193 ptrdiff_t, not int.
9194 (mark_object): Use ptrdiff_t, not int.
9195 * lisp.h (pD): New macro.
9196 * print.c (print_object): Use it.
9197
c0c5c8ae
PE
9198 * alloc.c: Use EMACS_INT, not int, to count objects.
9199 (total_conses, total_markers, total_symbols, total_vector_size)
9200 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9201 (total_free_floats, total_floats, total_free_intervals)
9202 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9203 Now EMACS_INT, not int. All uses changed.
9204 (Fgarbage_collect): Compute overall total using a double, so that
9205 integer overflow is less likely to be a problem. Check for overflow
9206 when converting back to an integer.
5a25e253
PE
9207 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9208 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9209 These were 'int' variables that could overflow on 64-bit hosts;
9210 they were never used, so remove them instead of repairing them.
211a0b2a 9211 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9212 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9213 Previously, this ceilinged at INT_MAX, but that doesn't work on
9214 64-bit machines.
e46bb31a 9215 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9216
c78baabf 9217 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9218 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9219 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9220 when a (possibly-narrower) signed value would do just as well.
9221 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9222
c9d624c6
PE
9223 * alloc.c: Catch some string size overflows that we were missing.
9224 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9225 for convenience in STRING_BYTES_MAX.
9226 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9227 The definition here is exact; the one in lisp.h was approximate.
9228 (allocate_string_data): Check for string overflow. This catches
9229 some instances we weren't catching before. Also, it catches
9230 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9231 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9232 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9233
c9d624c6
PE
9234 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9235 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9236 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9237
353032ce
PE
9238 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9239
2bccce07
PE
9240 * alloc.c (Fmake_string): Check for out-of-range init.
9241
0ac30604
SM
92422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9243
9244 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9245
c195f2de
JD
92462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9247
9248 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9249 xg_get_default_scrollbar_width.
9250
9251 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9252 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9253 (style_changed_cb): Call update_theme_scrollbar_width and call
9254 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9255 all frames (Bug#8505).
9256 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9257 Call gtk_window_set_resizable if HAVE_GTK3.
9258 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9259 and height if HAVE_GTK3 (Bug#8505).
9260 (scroll_bar_width_for_theme): New variable.
9261 (update_theme_scrollbar_width): New function.
9262 (xg_get_default_scrollbar_width): Move code to
9263 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9264 (xg_initialize): Call update_theme_scrollbar_width.
9265
9266 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9267
9268 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9269
e10ac9f1
MR
92702011-06-12 Martin Rudalics <rudalics@gmx.at>
9271
9272 * frame.c (make_frame): Call other_buffer_safely instead of
9273 other_buffer.
9274
9275 * window.c (temp_output_buffer_show): Call display_buffer with
9276 second argument Vtemp_buffer_show_specifiers and reset latter
9277 immediately after the call.
9278 (Vtemp_buffer_show_specifiers): New variable.
9279 (auto_window_vscroll_p, next_screen_context_lines)
9280 (Vscroll_preserve_screen_position): Remove leading asterisks from
9281 doc-strings.
9282
2d3c217e 92832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9284
7b7f97e8 9285 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9286 * buffer.c (Qclone_number): Remove for now, as it's unused.
9287 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9288 (record_buffer): Remove unused local.
9289 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9290 (set_frame_buffer_list): Remove; unused.
9291 * frame.h (other_visible_frames): Remove decl.
9292 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9293 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9294 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9295 if HAVE_GPM.
9296 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9297 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9298 Define only if HAVE_GPM.
9299 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9300 (update_hints_inhibit): Remove; never set. All uses removed.
9301 * widgetprv.h (emacsFrameClassRec): Remove decl.
9302 * window.c (delete_deletable_window): Now returns void, since it
9303 wasn't returning anything.
9304 (compare_window_configurations): Remove unused locals.
9305 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9306 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9307 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9308 the same widths as pointers. This follows up on the 2011-05-06 patch.
9309 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9310 * xterm.h: Likewise.
9311 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9312
1384b89e
JB
93132011-06-12 Juanma Barranquero <lekktu@gmail.com>
9314
9315 * makefile.w32-in: Update dependencies.
9316 (LISP_H): Add lib/intprops.h.
9317
1100a63c
CY
93182011-06-11 Chong Yidong <cyd@stupidchicken.com>
9319
9320 * image.c (gif_load): Add animation frame delay to the metadata.
9321 (syms_of_image): Use DEFSYM. New symbol `delay'.
9322
6198ccd0
MR
93232011-06-11 Martin Rudalics <rudalics@gmx.at>
9324
9325 * window.c (delete_deletable_window): Re-add.
9326 (Fset_window_configuration): Rewrite to handle dead buffers and
9327 consequently deletable windows.
9328 (window_tree, Fwindow_tree): Remove. Supply functionality in
9329 window.el.
9330 (compare_window_configurations): Simplify code.
9331
b6e3633c
AS
93322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9333
1ab0dee5
AS
9334 * image.c (imagemagick_load_image): Fix type mismatch.
9335 (Fimagemagick_types): Likewise.
9336
b6e3633c
AS
9337 * window.h (replace_buffer_in_windows): Declare.
9338
9397e56f
MR
93392011-06-11 Martin Rudalics <rudalics@gmx.at>
9340
9341 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9342 Qclone_number. Remove external declaration of Qdelete_window.
9343 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9344 code.
640c8776
SM
9345 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9346 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9347 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9348 buffer list implementation.
9349 (other_buffer_safely): New function.
9350 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9351 calls to replace_buffer_in_windows and
9352 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9353 if allowed.
9354 (record_buffer): Inhibit quitting and rewrite using quittable
9355 functions. Run Qbuffer_list_update_hook if allowed.
9356 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9357 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9358 Move switch-to-buffer to window.el.
9397e56f
MR
9359 (bury-buffer): Move to window.el.
9360 (Vbuffer_list_update_hook): New variable.
9361
9362 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9363 section.
9364
9365 * window.h (resize_frame_windows): Move up in code.
9366 (Fwindow_frame): Remove EXFUN.
9367 (replace_buffer_in_all_windows): Remove prototype.
9368 (replace_buffer_in_windows_safely): Add prototype.
9369
9370 * window.c: Declare Qdelete_window static again. Move down
9371 declaration of select_count.
9372 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9373 (Fother_window): Move to window.el.
9374 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9375 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9376 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9377 window.el.
9378 (replace_buffer_in_windows): Implement by calling
9379 Qreplace_buffer_in_windows.
9380 (replace_buffer_in_all_windows): Remove with some functionality
9381 moved into replace_buffer_in_windows_safely.
9382 (replace_buffer_in_windows_safely): New function.
9383 (select_window_norecord, select_frame_norecord): Move in front
9384 of run_window_configuration_change_hook. Remove now obsolete
9385 declarations.
640c8776
SM
9386 (Fset_window_buffer): Rewrite doc-string.
9387 Call Qrecord_window_buffer.
9397e56f
MR
9388 (keys_of_window): Move binding for other-window to window.el.
9389
b50691aa
CY
93902011-06-11 Chong Yidong <cyd@stupidchicken.com>
9391
9392 * dispextern.h (struct image): Replace data member, whose int_val
9393 and ptr_val fields were not used by anything, with a single
9394 lisp_val object.
9395
9396 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9397 (gif_clear_image, gif_load, imagemagick_load_image)
9398 (gs_clear_image, gs_load): Callers changed.
9399
3f754b86
PE
94002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9401
cca69397
PE
9402 * buffer.h: Include <time.h>, for time_t.
9403 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9404
109e28d0
PE
9405 Fix minor problems found by static checking.
9406
60737f02
PE
9407 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9408
4b66faf3
PE
9409 Make identifiers static if they are not used in other modules.
9410 * data.c (Qcompiled_function, Qframe, Qvector):
9411 * image.c (QimageMagick, Qsvg):
9412 * minibuf.c (Qmetadata):
9413 * window.c (resize_window_check, resize_root_window): Now static.
9414 * window.h (resize_window_check, resize_root_window): Remove decls.
9415
109e28d0
PE
9416 * window.c (window_deletion_count, delete_deletable_window):
9417 Remove; unused.
46a4ce9e
PE
9418 (window_body_lines): Now static.
9419 (Fdelete_other_windows_internal): Mark vars as initialized.
9420 Make sure 'resize_failed' is initialized.
9421 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9422 (resize_window_apply): Remove unused local.
9423 * window.h (delete_deletable_window): Remove decl.
9424
109e28d0 9425 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9426 (imagemagick_load_image): Fix pointer signedness problem by changing
9427 last arg from unsigned char * to char *. All uses changed.
9428 Also, fix a local for similar reasons.
9429 Remove unused locals. Remove locals to avoid shadowing.
9430 (fn_rsvg_handle_free): Remove; unused.
9431 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9432 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9433
3f754b86
PE
9434 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9435
2547adb1
CY
94362011-06-10 Chong Yidong <cyd@stupidchicken.com>
9437
9438 * image.c (gif_load): Fix omitted cast error introduced by
9439 2011-06-06 change.
9440
2c8e37d4
MR
94412011-06-10 Martin Rudalics <rudalics@gmx.at>
9442
9443 * window.h (resize_proportionally, orig_total_lines)
9444 (orig_top_line): Remove from window structure.
9445 (set_window_height, set_window_width, change_window_heights)
9446 (Fdelete_window): Remove prototypes.
9447 (resize_frame_windows): Remove duplicate declaration.
9448
440a42e3
EZ
94492011-06-10 Eli Zaretskii <eliz@gnu.org>
9450
9451 * window.h (resize_frame_windows, resize_window_check)
9452 (delete_deletable_window, resize_root_window)
9453 (resize_frame_windows): Declare prototypes.
9454
9455 * window.c (resize_window_apply): Make definition be "static" to
9456 match the prototype.
9457
562dd5e9
MR
94582011-06-10 Martin Rudalics <rudalics@gmx.at>
9459
9460 * window.c: Remove declarations of Qwindow_size_fixed,
9461 window_min_size_1, window_min_size_2, window_min_size,
9462 size_window, window_fixed_size_p, enlarge_window, delete_window.
9463 Remove static from declaration of Qdelete_window, it's
9464 temporarily needed by Fbury_buffer.
9465 (replace_window): Don't assign orig_top_line and
9466 orig_total_lines.
9467 (Fdelete_window, delete_window): Remove. Window deletion is
9468 handled by window.el.
640c8776
SM
9469 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9470 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9471 (Fdelete_other_windows): Remove. Deleting other windows is
9472 handled by window.el.
9473 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9474 handled in window.el.
9475 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9476 Window minimum sizes are handled in window.el.
9477 (shrink_windows, size_window, set_window_height)
9478 (set_window_width, change_window_heights, window_height)
9479 (window_width, CURBEG, CURSIZE, enlarge_window)
9480 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9481 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9482 handled in window.el.
9483 (make_dummy_parent): Rename to make_parent_window and give it a
9484 second argument horflag.
9485 (make_window): Don't set resize_proportionally any more.
9486 (Fsplit_window): Remove. Windows are split in window.el.
9487 (save_restore_action, save_restore_orig_size)
9488 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9489 Resize mini windows in window.el.
9490 (grow_mini_window, shrink_mini_window): Implement by calling
9491 Qresize_root_window_vertically, resize_window_check and
9492 resize_window_apply.
640c8776
SM
9493 (saved_window, Fset_window_configuration, save_window_save):
9494 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9495 resize_proportionally.
9496 (window_min_height, window_min_width): Move to window.el.
9497 (keys_of_window): Move bindings for delete-other-windows,
9498 split-window, delete-window and enlarge-window to window.el.
9499
9500 * buffer.c: Temporarily extern Qdelete_window.
9501 (Fbury_buffer): Temporarily call Qdelete_window instead of
9502 Fdelete_window (Fbury_buffer will move to window.el soon).
9503
9504 * frame.c (set_menu_bar_lines_1): Remove code handling
9505 orig_top_line and orig_total_lines.
9506
9507 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9508 set_window_height but set heights directly.
9509 (change_frame_size_1): Use resize_frame_windows.
9510
9511 * xdisp.c (init_xdisp): Don't use set_window_height but set
9512 heights directly.
9513
640c8776
SM
9514 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9515 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9516 run_window_configuration_change_hook.
9517
9518 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9519 instead of change_window_heights and run
9520 run_window_configuration_change_hook.
9521
1a13852e
MR
95222011-06-09 Martin Rudalics <rudalics@gmx.at>
9523
9524 * window.c (replace_window): Rename second argument REPLACEMENT to
9525 NEW. New third argument SETFLAG. Rewrite.
9526 (delete_window, make_dummy_parent): Call replace_window with
9527 third argument 1.
9528 (window_list_1): Move down in code.
9529 (run_window_configuration_change_hook): Move set_buffer part
9530 before select_frame_norecord part in order to unwind correctly.
9531 Rename count1 to count.
9532 (recombine_windows, delete_deletable_window, resize_root_window)
9533 (Fdelete_other_windows_internal)
9534 (Frun_window_configuration_change_hook, make_parent_window)
9535 (resize_window_check, resize_window_apply, Fresize_window_apply)
9536 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9537 (Fdelete_window_internal, Fresize_mini_window_internal):
9538 New functions.
1a13852e
MR
9539 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9540
f3d1777e
MR
95412011-06-08 Martin Rudalics <rudalics@gmx.at>
9542
496e208e
MR
9543 * window.h (window): Add some new members to window structure -
9544 normal_lines, normal_cols, new_total, new_normal, clone_number,
9545 splits, nest, prev_buffers, next_buffers.
9546 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9547 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9548
f3d1777e
MR
9549 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9550 Remove.
496e208e
MR
9551 (make_dummy_parent): Set new members of windows structure.
9552 (make_window): Move down in code. Handle new members of window
9553 structure.
9554 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9555 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9556 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9557 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9558 (Fset_window_next_buffers, Fset_window_clone_number):
9559 New functions.
496e208e
MR
9560 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9561 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9562 Doc-string fixes.
9563 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9564 Argument WINDOW can be now internal window too.
9565 (Fwindow_use_time): Move up in code.
9566 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9567 Rewrite doc-string.
9568 (Fset_window_configuration, saved_window)
9569 (Fcurrent_window_configuration, save_window_save): Handle new
9570 members of window structure.
b9e809c2
MR
9571 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9572 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9573 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9574 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9575 Qget_mru_window, Qresize_root_window,
9576 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9577 Qauto_buffer_name; staticpro them.
f3d1777e 9578
abde8f8c
MR
95792011-06-07 Martin Rudalics <rudalics@gmx.at>
9580
9581 * window.c (Fwindow_total_size, Fwindow_left_column)
9582 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9583 (Fwindow_list_1): New functions.
9584 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9585 (Fwindow_width, Fscroll_left, Fscroll_right):
9586 Use window_body_cols instead of window_box_text_cols.
9587 (delete_window, Fset_window_configuration):
9588 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9589 (delete_all_subwindows): Take a window as argument and not a
9590 structure. Rewrite.
190b47e6
MR
9591 (window_loop): Remove handling of GET_LRU_WINDOW and
9592 GET_LARGEST_WINDOW.
9593 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9594
9595 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9596 window_box_text_cols. delete_all_subwindows now takes a
9597 Lisp_Object as argument.
abde8f8c 9598
640c8776
SM
9599 * indent.c (compute_motion, Fcompute_motion):
9600 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9601
fa8a67e6
MR
9602 * frame.c (delete_frame): Call delete_all_subwindows with root
9603 window as argument.
9604
a54e3482
DC
96052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9606
9607 * fns.c (Fputhash): Document return value.
9608
60002bf5
CY
96092011-06-06 Chong Yidong <cyd@stupidchicken.com>
9610
9611 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9612
0c671da6 96132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9614
b862a52a 9615 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9616
be44ca6c
PE
9617 Check for overflow when converting integer to cons and back.
9618 * charset.c (Fdefine_charset_internal, Fdecode_char):
9619 Use cons_to_unsigned to catch overflow.
9620 (Fencode_char): Use INTEGER_TO_CONS.
9621 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9622 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9623 * data.c (long_to_cons, cons_to_long): Remove.
9624 (cons_to_unsigned, cons_to_signed): New functions.
9625 These signal an error for invalid or out-of-range values.
9626 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9627 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9628 * font.c (Ffont_variation_glyphs):
9629 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9630 * lisp.h: Include <intprops.h>.
9631 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9632 (cons_to_signed, cons_to_unsigned): New decls.
9633 (long_to_cons, cons_to_long): Remove decls.
9634 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9635 (Fprimitive_undo): Use CONS_TO_INTEGER.
9636 * xfns.c (Fx_window_property): Likewise.
9637 * xselect.c: Include <limits.h>.
9638 (x_own_selection, selection_data_to_lisp_data):
9639 Use INTEGER_TO_CONS.
9640 (x_handle_selection_request, x_handle_selection_clear)
9641 (x_get_foreign_selection, Fx_disown_selection_internal)
9642 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9643 (lisp_data_to_selection_data): Use cons_to_unsigned.
9644 (x_fill_property_data): Use cons_to_signed.
9645 Report values out of range.
9646
d1f3d2af
PE
9647 Check for buffer and string overflow more precisely.
9648 * buffer.h (BUF_BYTES_MAX): New macro.
9649 * lisp.h (STRING_BYTES_MAX): New macro.
9650 * alloc.c (Fmake_string):
9651 * character.c (string_escape_byte8):
9652 * coding.c (coding_alloc_by_realloc):
9653 * doprnt.c (doprnt):
9654 * editfns.c (Fformat):
9655 * eval.c (verror):
9656 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9657 since they may not be the same number.
9658 * editfns.c (Finsert_char):
9659 * fileio.c (Finsert_file_contents):
9660 Likewise for BUF_BYTES_MAX.
9661
dd52fcea
PE
9662 * image.c: Use ptrdiff_t, not int, for sizes.
9663 (slurp_file): Switch from int to ptrdiff_t.
9664 All uses changed.
9665 (slurp_file): Check that file size fits in both size_t (for
9666 malloc) and ptrdiff_t (for sanity and safety).
9667
7f9bbdbb
PE
9668 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9669 if b->modtime has its maximal value.
9670
dfe18f82
PE
9671 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9672
84acfcf0
PE
9673 Don't assume time_t can fit into int.
9674 * buffer.h (struct buffer.modtime): Now time_t, not int.
9675 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9676 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9677
ccd9a01a
PE
9678 Minor fixes for signed vs unsigned integers.
9679 * character.h (MAYBE_UNIFY_CHAR):
9680 * charset.c (maybe_unify_char):
9681 * keyboard.c (read_char, reorder_modifiers):
9682 XINT -> XFASTINT, since the integer must be nonnegative.
9683 * ftfont.c (ftfont_spec_pattern):
9684 * keymap.c (access_keymap, silly_event_symbol_error):
9685 XUINT -> XFASTINT, since the integer must be nonnegative.
9686 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9687 since it makes no difference and we prefer signed.
9688 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9689 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9690 nonnegative.
9691
d6d100dd
SM
96922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9693
9694 * window.h (Fwindow_frame): Declare.
9695
2b6148e4
PE
96962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9697
9698 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9699 (SPARE_MEMORY): Always define.
9700 (LARGE_REQUEST): Remove.
9701 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9702
f230ecc9
MR
97032011-06-06 Martin Rudalics <rudalics@gmx.at>
9704
727e958e
MR
9705 * lisp.h: Move EXFUNS for Fframe_root_window,
9706 Fframe_first_window and Fset_frame_selected_window to window.h.
9707
9708 * window.h: Move EXFUNS for Fframe_root_window,
9709 Fframe_first_window and Fset_frame_selected_window here from
9710 lisp.h.
9711
9712 * frame.c (Fwindow_frame, Fframe_first_window)
9713 (Fframe_root_window, Fframe_selected_window)
9714 (Fset_frame_selected_window): Move to window.c.
9715 (Factive_minibuffer_window): Move to minibuf.c.
9716 (Fother_visible_frames_p): New function.
9717
9718 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9719
f230ecc9
MR
9720 * window.c (decode_window, decode_any_window): Move up in code.
9721 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9722 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9723 (Fwindow_buffer): Move up and rewrite doc-string.
9724 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9725 (Fwindow_prev): New functions.
727e958e
MR
9726 (Fwindow_frame): Move here from frame.c. Accept any window as
9727 argument.
9728 (Fframe_root_window, Fframe_first_window)
9729 (Fframe_selected_window): Move here from frame.c. Accept frame
9730 or arbitrary window as argument. Update doc-strings.
9731 (Fminibuffer_window): Move up in code.
9732 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9733 (Fset_frame_selected_window): Move here from frame.c.
9734 Marginal rewrite.
727e958e
MR
9735 (Fselected_window, select_window, Fselect_window): Move up in
9736 code. Minor doc-string fixes.
f230ecc9 9737
4d09bcf6
PE
97382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9739
9740 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9741 Do not assume that spare memory exists; that assumption is valid
9742 only if SYSTEM_MALLOC.
9743 (LARGE_REQUEST): New macro, so that the issue of large requests
9744 is separated from the issue of spare memory.
9745
810928a2
AS
97462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9747
172418ad
AS
9748 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9749 format. (Bug#8806)
9750
43f862f7
AS
9751 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9752
810928a2
AS
9753 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9754 before statements.
9755
a059fe24
JD
97562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9757
9758 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9759
9760 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9761
9762 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9763 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9764
989bf368
JB
97652011-06-05 Juanma Barranquero <lekktu@gmail.com>
9766
9767 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9768
4b80f674
CY
97692011-06-04 Chong Yidong <cyd@stupidchicken.com>
9770
9771 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9772 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9773 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9774 New error handlers.
4b80f674
CY
9775 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9776 Obey Vx_select_enable_clipboard_manager. Catch errors in
9777 x_clipboard_manager_save (Bug#8779).
9778 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9779 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9780
99a33b77 97812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9782
9783 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9784
99a33b77 97852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9786
9787 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9788 in the current matrix if keep_current_p is non-zero.
9789
8264569d
EZ
97902011-06-04 Eli Zaretskii <eliz@gnu.org>
9791
9792 * bidi.c (bidi_level_of_next_char): Fix last change.
9793
57f97249
EZ
97942011-06-03 Eli Zaretskii <eliz@gnu.org>
9795
fec2107c 9796 Support bidi reordering of text covered by display properties.
57f97249 9797
fec2107c
EZ
9798 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9799 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9800 (bidi_cache_search, bidi_cache_iterator_state)
9801 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9802 (bidi_level_of_next_char, bidi_move_to_visually_next):
9803 Support character positions inside a run of characters covered by a
fec2107c
EZ
9804 display string.
9805 (bidi_paragraph_init, bidi_resolve_explicit_1)
9806 (bidi_level_of_next_char): Call bidi_fetch_char and
9807 bidi_fetch_char_advance instead of FETCH_CHAR and
9808 FETCH_CHAR_ADVANCE.
9809 (bidi_init_it): Initialize new members.
9810 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9811 definitions.
9812 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9813 instead of using explicit *_CHAR codes.
d6d100dd
SM
9814 (bidi_resolve_explicit, bidi_resolve_weak):
9815 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9816 bidirectional text is supported only in multibyte buffers.
9817 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9818 it to initialize the frame_window_p member of struct bidi_it.
9819 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9820 (bidi_resolve_explicit, bidi_resolve_weak)
9821 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9822 bidi_it->nchars is non-positive.
9823 (bidi_level_of_next_char): Don't try to lookup the cache for the
9824 next/previous character if nothing is cached there yet, or if we
9825 were just reseat()'ed to a new position.
c40e2fb2 9826
0e14fe90
EZ
9827 * xdisp.c (set_cursor_from_row): Set start and stop points
9828 according to the row's direction when priming the loop that looks
9829 for the glyph on which to display cursor.
9830 (single_display_spec_intangible_p): Function deleted.
9831 (display_prop_intangible_p): Reimplement to call
9832 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9833 Accept 3 additional arguments needed by handle_display_spec.
9834 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9835 values: lists, `(when COND...)' forms, etc.
9836 (single_display_spec_string_p): Support property values that are
9837 lists with the argument STRING its top-level element.
9838 (display_prop_string_p): Fix the condition for processing a
9839 property that is a list to be consistent with handle_display_spec.
fec2107c 9840 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9841 last portion of handle_display_prop.
9842 (compute_display_string_pos): Accept additional argument
9843 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9844 value of a `display' property is a "replacing spec".
9845 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9846 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9847 the display property, but just return a value indicating whether
9848 the display property will replace the characters it covers.
9849 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9850 frame_window_p members of struct bidi_it.
d6d100dd
SM
9851 (compute_display_string_pos, compute_display_string_end):
9852 New functions.
fec2107c
EZ
9853 (push_it): Accept second argument POSITION, where pop_it should
9854 jump to continue iteration.
9855 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9856
fec2107c
EZ
9857 * keyboard.c (adjust_point_for_property): Adjust the call to
9858 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9859
9860 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9861 (bidi_init_it): Update prototypes.
9862 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9863 (compute_display_string_pos, compute_display_string_end):
9864 Declare prototypes.
fec2107c
EZ
9865 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9866 EMACS_INT.
fc6f18ce 9867
40087514 98682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9869
57f53182
PE
9870 Malloc failure behavior now depends on size of allocation.
9871 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9872 * lisp.h: Change signatures accordingly.
9873 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9874 All callers changed. (Bug#8762)
9875
9876 * gnutls.c: Use Emacs's memory allocators.
9877 Without this change, the gnutls library would invoke malloc etc.
9878 directly, which causes problems on non-SYNC_INPUT hosts, and which
9879 runs afoul of improving memory_full behavior. (Bug#8761)
9880 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9881 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9882 xfree instead of the default malloc, realloc, free.
9883 (Fgnutls_boot): No need to check for memory allocation failure,
9884 since xmalloc does that for us.
9885
ac32cd99 9886 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9887 * category.c (hash_get_category_set):
9888 * ccl.c (ccl_driver):
9889 * charset.c (Fdefine_charset_internal):
9890 * charset.h (struct charset.hash_index):
9891 * composite.c (get_composition_id, gstring_lookup_cache)
9892 (composition_gstring_put_cache):
9893 * composite.h (struct composition.hash_index):
9894 * dispextern.h (struct image.hash):
9895 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9896 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9897 (hashfn_equal, hashfn_user_defined, make_hash_table)
9898 (maybe_resize_hash_table, hash_lookup, hash_put)
9899 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9900 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9901 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9902 * image.c (make_image, search_image_cache, lookup_image)
9903 (xpm_put_color_table_h):
9904 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9905 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9906 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9907 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9908 * alloc.c (allocate_vectorlike):
9909 Check for overflow in vector size calculations.
9910 * ccl.c (ccl_driver):
9911 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9912 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9913 need to be updated by these changes.
40087514
PE
9914 * fns.c (make_hash_table, maybe_resize_hash_table):
9915 Check for integer overflow with large hash tables.
0de4bb68
PE
9916 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9917 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9918 (SXHASH_REDUCE): New macro.
9919 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9920 Use it instead of discarding useful hash info with large hash values.
9921 (sxhash_float): New function.
9922 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9923 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9924 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9925 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9926 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9927 Adjust signatures to match updated version of code.
9928 (consing_since_gc): Now EMACS_INT, since a single hash table can
9929 use more than INT_MAX bytes.
9930
698d32e2
DN
99312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9932
9933 Make it possible to build with GCC-4.6+ -O2 -flto.
9934
9935 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9936
fd6fa53f
SM
99372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9938
9939 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9940 Call minibuffer-inactive-mode.
9941
864db017
JB
99422011-05-31 Juanma Barranquero <lekktu@gmail.com>
9943
9944 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9945 Update dependencies.
9946
2ad0baf4
DN
99472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9948
9949 * data.c (init_data): Remove code for UTS, this system is not
9950 supported anymore.
9951
4fcc2638
DN
99522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9953
9954 Don't force ./temacs to start in terminal mode.
9955
9956 * frame.c (make_initial_frame): Initialize faces in all cases, not
9957 only when CANNOT_DUMP is defined.
9958 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9959
c56e0fd5
DN
99602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9961
9962 * dispnew.c (add_window_display_history): Use const for the string
9963 pointer. Remove declaration, not needed.
9964
333d54da 99652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9966
55d4c1b2 9967 Use 'inline', not 'INLINE'.
333d54da 9968 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9969 * alloc.c, fontset.c (INLINE): Remove.
9970 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9971 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9972 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9973 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9974 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9975
738db178
DN
99762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9977
9978 Make it possible to run ./temacs.
9979
9980 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9981 syms_of_callproc does the same thing. Remove test for
9982 "initialized", do it in the caller.
9983 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9984
620c53a6
SM
99852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9986
9987 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9988 (read_minibuf): Use get_minibuffer.
9989 (syms_of_minibuf): Use DEFSYM.
9990 (Qmetadata): New var.
9991 * data.c (Qbuffer): Don't make it static.
9992 (syms_of_data): Use DEFSYM.
9993
e003a292
PE
99942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9995
9996 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9997 (CCL_CODE_MIN): New macro.
9998
ed008a6d
PE
99992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10000
3687c2ef
PE
10001 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10002
ed008a6d
PE
10003 * eval.c (Qdebug): Now static.
10004 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10005 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10006 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10007
d66c4c7c
CY
100082011-05-29 Chong Yidong <cyd@stupidchicken.com>
10009
10010 * image.c: Various fixes to ImageMagick code comments.
10011 (Fimagemagick_types): Doc fix.
10012
5fbc2025
PE
100132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10014
0196f88a
PE
10015 Minor fixes prompted by GCC 4.6.0 warnings.
10016
10017 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10018
5fbc2025
PE
10019 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10020 (x_clipboard_manager_save_all): Move extern decl to ...
10021 * xterm.h: ... here, so that it can be checked for consistency.
10022
1dd3c2d9
CY
100232011-05-29 Chong Yidong <cyd@stupidchicken.com>
10024
10025 * xselect.c (x_clipboard_manager_save_frame)
10026 (x_clipboard_manager_save_all): New functions.
10027 (Fx_clipboard_manager_save): Lisp function deleted.
10028
10029 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10030 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10031
10032 * xterm.h: Update prototype.
10033
5ba6571d
WX
100342011-05-28 William Xu <william.xwl@gmail.com>
10035
10036 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10037 exiting (Bug#8239).
10038
3eaff834
JM
100392011-05-28 Jim Meyering <meyering@redhat.com>
10040
e1900994 10041 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10042 * fns.c (to_uchar): Define.
10043 (crypto_hash_function): Use it to convert some newly-signed
10044 variables to unsigned, to avoid sign-extension bugs. For example,
10045 without this change, (md5 "truc") would evaluate to
10046 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10047 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10048 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10049
0f6990a7
PE
100502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10051
10052 Integer overflow fixes.
c8a9ca5a 10053
08686060
PE
10054 * dbusbind.c: Serial number integer overflow fixes.
10055 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10056 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10057 to hold a serial number that is too large for a fixnum.
10058 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10059 Check for serial numbers out of range. Decode any serial number
59568bf0 10060 that was so large that it became a float. (Bug#8722)
08686060 10061
2d1fc3c7
PE
10062 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10063 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10064 Use XFASTINT rather than XUINT when numbers are nonnegative.
10065 (xd_append_arg, Fdbus_method_return_internal):
10066 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10067 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10068 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10069 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10070 (Bug#8722)
2d1fc3c7 10071
c8a9ca5a
PE
10072 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10073
519e1d69
PE
10074 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10075
6df6ae42 10076 ccl: Add integer overflow checks.
30569699
PE
10077 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10078 (IN_INT_RANGE): New macros.
10079 (ccl_driver): Use them to check for integer overflow when
10080 decoding a CCL program. Many of the new checks are whether XINT (x)
10081 fits in int; it doesn't always, on 64-bit hosts. The new version
10082 doesn't catch all possible integer overflows, but it's an
847044ea 10083 improvement. (Bug#8719)
30569699 10084
c11285dc
PE
10085 * alloc.c (make_event_array): Use XINT, not XUINT.
10086 There's no need for unsigned here.
10087
fdccd48e
PE
10088 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10089 This follows up to the 2011-05-06 change that substituted uintptr_t
10090 for EMACS_INT. This case wasn't caught back then.
10091
37910ab2
PE
10092 Rework Fformat to avoid integer overflow issues.
10093 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10094 now (part of C89). Include <verify.h>.
10095 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10096 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10097 (Fformat): Avoid the prepass trying to compute sizes; it was only
10098 approximate and thus did not catch overflow reliably. Instead, walk
10099 through the format just once, formatting and computing sizes as we go,
10100 checking for integer overflow at every step, and allocating a larger
10101 buffer as needed. Keep track separately whether the format is
10102 multibyte. Keep only the most-recently calculated precision, rather
10103 than them all. Record whether each argument has been converted to
10104 string. Use EMACS_INT, not int, for byte and char and arg counts.
10105 Support field widths and precisions larger than INT_MAX. Avoid
10106 sprintf's undefined behavior with conversion specifications such as %#d
10107 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10108 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10109 formatting out-of-range floating point numbers with int
9173deec 10110 formats. (Bug#8668)
37910ab2 10111
2e6578fb
PE
10112 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10113
0ae6bdee
PE
10114 * data.c: Avoid integer truncation in expressions involving floats.
10115 * data.c: Include <intprops.h>.
10116 (arith_driver): When there's an integer overflow in an expression
10117 involving floating point, convert the integers to floating point
10118 so that the resulting value does not suffer from catastrophic
10119 integer truncation. For example, on a 64-bit host (* 4
10120 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10121 Do not rely on undefined behavior after integer overflow.
10122
de883a70
PE
10123 merge count_size_as_multibyte, parse_str_to_multibyte
10124 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10125 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10126 Check for integer overflow.
10127 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10128 since it's now a duplicate of the other. This is more of
10129 a character than a buffer op, so better that it's in character.c.
10130 * fns.c, print.c: Adjust to above changes.
10131
2ff916cb
PE
101322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10133
10134 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10135
f1b54466
PE
101362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10137
fb1ac845
PE
10138 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10139 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10140 (x_clipboard_manager_save): Now static.
10141 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10142
f1b54466
PE
10143 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10144 (crypto_hash_function): Now static.
10145 Fix pointer signedness problems. Avoid unnecessary initializations.
10146
a9f737ee
CY
101472011-05-27 Chong Yidong <cyd@stupidchicken.com>
10148
10149 * termhooks.h (Vselection_alist): Make it terminal-local.
10150
10151 * terminal.c (create_terminal): Initialize it.
10152
10153 * xselect.c: Support for clipboard managers.
10154 (Vselection_alist): Move to termhooks.h as terminal-local var.
10155 (LOCAL_SELECTION): New macro.
10156 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10157 (symbol_to_x_atom): Remove gratuitous arg.
10158 (x_handle_selection_request, lisp_data_to_selection_data)
10159 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10160 (x_own_selection, x_get_local_selection, x_convert_selection):
10161 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10162 (some_frame_on_display): Delete unused function.
10163 (Fx_own_selection_internal, Fx_get_selection_internal)
10164 (Fx_disown_selection_internal, Fx_selection_owner_p)
10165 (Fx_selection_exists_p): New optional frame arg.
10166 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10167 (x_handle_selection_clear): Don't treat other terminals with the
10168 same keyboard specially. Use the terminal-local Vselection_alist.
10169 (x_clear_frame_selections): Use Frun_hook_with_args.
10170
10171 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10172
10173 * xterm.h: Add support for those atoms.
10174
e067f0c1
CY
101752011-05-26 Chong Yidong <cyd@stupidchicken.com>
10176
10177 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10178 (converted_selections, conversion_fail_tag): New global variables.
10179 (x_selection_request_lisp_error): Free the above.
10180 (x_get_local_selection): Remove unnecessary code.
10181 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10182 of converted selections stored in converted_selections.
10183 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10184 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10185 (x_convert_selection): New function.
10186 (x_handle_selection_event): Simplify.
10187 (x_get_foreign_selection): Don't ignore incoming requests while
10188 waiting for an answer; this will fail when we implement
10189 SAVE_TARGETS, and seems unnecessary anyway.
10190 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10191 (Vx_sent_selection_functions): Doc fix.
10192
0f4aebc0
LL
101932011-05-26 Leo Liu <sdl.web@gmail.com>
10194
10195 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10196
e61124cd
YM
101972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10198
10199 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10200
10201 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10202 for fringe update if it has periodic bitmap.
ac389d0c 10203 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10204 and fringe_bitmap_periodic_p.
10205
10206 * fringe.c (get_fringe_bitmap_data): New function.
10207 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10208 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10209 row. Mark glyph row for fringe update if periodicity changed.
10210
10211 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10212 for fringe update unless it has periodic bitmap.
10213
f16d9837
KH
102142011-05-25 Kenichi Handa <handa@m17n.org>
10215
10216 * xdisp.c (get_next_display_element): Set correct it->face_id for
10217 a static composition.
10218
e1b90ef6
LL
102192011-05-24 Leo Liu <sdl.web@gmail.com>
10220
10221 * deps.mk (fns.o):
10222 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10223
10224 * fns.c (crypto_hash_function, Fsha1): New function.
10225 (Fmd5): Use crypto_hash_function.
10226 (syms_of_fns): Add Ssha1.
10227
7400048f
PE
102282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10229
10230 * gnutls.c: Remove unused macros.
10231 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10232 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10233 Remove macros that are defined and never used.
10234 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10235
abb71cf4
CY
102362011-05-22 Chong Yidong <cyd@stupidchicken.com>
10237
10238 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10239 (Fx_get_selection_internal): Minor cleanup.
10240 (Fx_own_selection_internal): Rename arguments for consistency with
10241 select.el.
10242
6307db39
PE
102432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10244
10245 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10246
f3d4e0a4
CY
102472011-05-22 Chong Yidong <cyd@stupidchicken.com>
10248
10249 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10250
4d8ade89
YM
102512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10252
10253 * dispnew.c (scrolling_window): Don't exclude the case that the
10254 last enabled row in the desired matrix touches the bottom boundary.
10255
32078c8d
GM
102562011-05-21 Glenn Morris <rgm@gnu.org>
10257
10258 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10259 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10260 and add some more files.
32078c8d 10261
7285dc67
EZ
102622011-05-20 Eli Zaretskii <eliz@gnu.org>
10263
10264 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10265 report_file_error introduced by the change from 2011-05-07.
10266
89d1bd22
PE
102672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10268
10269 * systime.h (Time): Define only if emacs is defined.
10270 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10271 where the include path doesn't have X11/X.h by default. See
10272 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10273
cd394be1 102742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10275
10276 * composite.c (find_automatic_composition): Fix previous change.
10277
b9704ad9
GM
102782011-05-20 Glenn Morris <rgm@gnu.org>
10279
10280 * lisp.mk: New file, split from Makefile.in.
10281 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10282 (shortlisp): Remove.
10283 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10284
4a720484
GM
102852011-05-19 Glenn Morris <rgm@gnu.org>
10286
10287 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10288 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10289 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10290 (lisp): Set the order to that of loadup.el.
10291 (shortlisp): Make it a copy of $lisp.
10292 (SOME_MACHINE_LISP): Remove.
10293 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10294 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10295
a28d4396
KH
102962011-05-18 Kenichi Handa <handa@m17n.org>
10297
10298 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10299 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10300 (find_automatic_composition): Mostly rewrite for efficiency.
10301
a2b1fa8e
JB
103022011-05-18 Juanma Barranquero <lekktu@gmail.com>
10303
10304 * makefile.w32-in: Update dependencies.
10305
8e1f5610
CS
103062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10307
10308 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10309 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10310
7025ee00 103112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10312
cdfa6eab
PE
10313 Fix some integer overflow issues, such as string length overflow.
10314
06d6db33
PE
10315 * insdel.c (count_size_as_multibyte): Check for string overflow.
10316
2b4560a8
PE
10317 * character.c (lisp_string_width): Check for string overflow.
10318 Use EMACS_INT, not int, for string indexes and lengths; in
10319 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10320 the resulting string length overflows an EMACS_INT; instead,
10321 report a string overflow if no precision given. When checking for
10322 precision exhaustion, use a check that cannot possibly have
10323 integer overflow. (Bug#8675)
10324 * character.h (lisp_string_width): Adjust to new signature.
10325
cb93f9be
PE
10326 * alloc.c (string_overflow): New function.
10327 (Fmake_string): Use it. This doesn't change behavior, but saves
10328 a few bytes and will simplify future changes.
10329 * character.c (string_escape_byte8): Likewise.
10330 * lisp.h (string_overflow): New decl.
10331
1a1f3366
PE
10332 Fixups, following up to the user-interface timestamp change.
10333 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10334 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10335 * msdos.c (mouse_get_pos): Likewise.
10336 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10337 * w32gui.h (Time): Define by including "systime.h" rather than by
10338 declaring it ourselves. (Bug#8664)
10339
d4e3e4d3
PE
10340 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10341 * image.c (clear_image_cache): Likewise.
10342
f6a24d19
PE
10343 * term.c (term_mouse_position): Don't assume time_t wraparound.
10344
08dc5ae6
PE
10345 Be more systematic about user-interface timestamps.
10346 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10347 and sometimes 'EMACS_UINT', to represent these timestamps.
10348 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10349 This makes the code easier to follow, and makes it easier to catch
10350 integer overflow bugs such as Bug#8664.
10351 * frame.c (Fmouse_position, Fmouse_pixel_position):
10352 Use Time, not unsigned long, for user-interface timestamps.
10353 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10354 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10355 * keyboard.h (last_event_timestamp): Likewise.
10356 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10357 * menu.h (xmenu_show): Likewise.
10358 * term.c (term_mouse_position): Likewise.
10359 * termhooks.h (struct input_event.timestamp): Likewise.
10360 (struct terminal.mouse_position_hook): Likewise.
10361 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10362 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10363 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10364 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10365 what it was before.
10366 * menu.h, termhooks.h: Include "systime.h", for Time.
10367
8e55734a
PE
10368 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10369 Don't assume that the difference between two unsigned long values
10370 can fit into an integer. At this point, we know button_down_time
10371 <= event->timestamp, so the difference must be nonnegative, so
10372 there's no need to cast the result if double-click-time is
10373 nonnegative, as it should be; check that it's nonnegative, just in
10374 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10375 apart (about 25 days). (Bug#8664)
8e55734a 10376
841f1b75 10377 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10378 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10379
3e26f69c
PE
10380 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10381 that always fit in int. Use a sentinel instead of a counter, to
10382 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10383 * frame.h (struct frame): Use int for menu_bar_items_used
10384 instead of EMACS_INT, since it always fits in int.
3e26f69c 10385
5cc152c0
PE
10386 * menu.c (grow_menu_items): Check for int overflow.
10387
d89eb65e
PE
10388 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10389
5235bd3e
PE
10390 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10391 Before, the code was not consistent. These values cannot exceed
10392 2**31 - 1 so there's no need to make them unsigned.
10393 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10394 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10395 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10396 as modifiers.
10397 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10398
bc827e23
PE
10399 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10400 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10401 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10402 presumably because the widths might not match.
10403
78eb494e
PE
10404 * window.c (size_window): Avoid needless test at loop start.
10405
04f2d78b
CB
104062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10407
10408 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10409
d2fc7e3d 104102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10411
10412 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10413
d2fc7e3d 104142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10415
10416 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10417 `width' to `bar_area_x' and `bar_area_width', respectively.
10418 (x_scroll_run): Take account of fringe background extension.
10419
04f2d78b
CB
10420 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10421 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10422 `bar_area_width', respectively.
10423 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10424 background extension.
10425
79b70037
GM
104262011-05-10 Jim Meyering <meyering@redhat.com>
10427
10428 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10429
2f142cc5
JB
104302011-05-10 Juanma Barranquero <lekktu@gmail.com>
10431
10432 * image.c (Finit_image_library): Return t for built-in image types,
10433 like pbm and xbm. (Bug#8640)
10434
57679c86
AS
104352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10436
10437 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10438
888c9e86
EZ
104392011-05-07 Eli Zaretskii <eliz@gnu.org>
10440
b0512a1d
EZ
10441 * w32console.c (Fset_screen_color): Doc fix.
10442 (Fget_screen_color): New function.
10443 (syms_of_ntterm): Defsubr it.
10444
7285dc67
EZ
10445 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10446 unlink the temporary file if Fcall_process didn't create it in the
10447 first place.
10448 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10449 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10450 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10451 cue to call_process_cleanup not to close that handle.
10452
4d3fcc8e
BK
104532011-05-07 Ben Key <bkey76@gmail.com>
10454
10455 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10456 one of two shell specific rules, either bootstrap-temacs-CMD or
10457 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10458 to the previous implementation of the bootstrap-temacs rule.
10459 The bootstrap-temacs-CMD rule is similar to the previous
10460 implementation of the bootstrap-temacs rule except that it
10461 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10462 variable.
10463
10464 These changes, along with some changes to nt/configure.bat,
10465 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10466 earlier fix to add support for --cflags and --ldflags options
10467 that include quotes so that it works whether make uses cmd or
10468 sh as the shell.
10469
b4289b64
MA
104702011-05-06 Michael Albinus <michael.albinus@gmx.de>
10471
10472 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10473 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10474 is a constant.
10475 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10476 a string. Handle both cases.
10477 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10478 (Fdbus_register_method): Use Qinvalid_function.
10479
af4c0e28
JB
104802011-05-06 Juanma Barranquero <lekktu@gmail.com>
10481
10482 * makefile.w32-in: Update dependencies.
10483 (LISP_H): Add inttypes.h and stdin.h.
10484 (PROCESS_H): Add unistd.h.
10485
c51453d9
EZ
104862011-05-06 Eli Zaretskii <eliz@gnu.org>
10487
10488 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10489 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10490
8ff0ac3c 104912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10492
4c4b566b
PE
10493 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10494
aab2b9b5
PE
10495 * term.c (vfatal): Remove stray call to va_end.
10496 It's not needed and the C Standard doesn't allow it here anyway.
10497
c378da0b
PE
10498 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10499 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10500
288b08c7
PE
10501 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10502 bytes.
10503
e3601888
PE
10504 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10505
db6c0e74
PE
10506 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10507
dd5963ea
PE
10508 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10509
88c9450f
PE
10510 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10511
2f9442b8
PE
10512 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10513
c032b5f8
PE
10514 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10515 * charset.c (Fdefine_charset_internal): Don't initialize
10516 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10517 32-bit int (Bug#8600).
a108c10b
PE
10518
10519 * lread.c (read_integer): Be more consistent with string-to-number.
10520 Use string_to_number to do the actual conversion; this avoids
10521 rounding errors and fixes some other screwups. Without this fix,
10522 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10523 (digit_to_number): Move earlier, for benefit of read_integer.
10524 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10525 not a digit in any supported base. (Bug#8602)
a108c10b 10526
ad5f9eea
PE
10527 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10528
aec1708a
PE
10529 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10530 to match comment at start of function. This also removes a
10531 GCC warning about overflow in a 32+64-bit port.
10532
47be4ab5
PE
10533 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10534
371cac43
PE
10535 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10536 Reported by Stefan Monnier in
10537 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10538 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10539 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10540
d01a7826
PE
10541 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10542 (EMACS_UINTPTR): Likewise, with uintptr_t.
10543
7fd47d5c
PE
10544 * lisp.h: Prefer 64-bit EMACS_INT if available.
10545 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10546 on 32-bit hosts that have 64-bit int, so that they can access
10547 large files.
122b0c86
PE
10548 However, temporarily disable this change unless the temporary
10549 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10550
8727937b
PE
10551 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10552
8ac068ac
PE
10553 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10554 This removes an assumption that EMACS_INT and long are the same
10555 width as pointers. The assumption is true for Emacs porting targets
10556 now, but we want to make other targets possible.
10557 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10558 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10559 In the rest of the code, change types of integers that hold casted
10560 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10561 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10562 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10563 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10564 No need to cast type when ORing.
10565 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10566 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10567 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10568 assume EMACS_INT is the same width as char *.
10569 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10570 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10571 Remove no-longer-needed casts.
10572 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10573 (xg_tool_bar_help_callback, xg_make_tool_item):
10574 Use EMACS_INTPTR to hold an integer
10575 that will be cast to void *; this can avoid a GCC warning
10576 if EMACS_INT is not the same width as void *.
10577 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10578 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10579 (current_message_1, set_message_1):
10580 Use a local to convert to proper width without a cast.
10581 * xmenu.c (dialog_selection_callback): Likewise.
10582
ede49d71
PE
10583 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10584 Also, don't assume VALBITS / RAND_BITS is less than 5,
10585 and don't rely on undefined behavior when shifting a 1 left into
10586 the sign bit.
10587 * lisp.h (get_random): Change signature to match.
10588
2f30ecd0
PE
10589 * lread.c (hash_string): Use size_t, not int, for hash computation.
10590 Normally we prefer signed values; but hashing is special, because
10591 it's better to use unsigned division on hash table sizes so that
10592 the remainder is nonnegative. Also, size_t is the natural width
10593 for hashing into memory. The previous code used 'int', which doesn't
10594 retain enough info to hash well into very large tables.
10595 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10596
2a866e7b
PE
10597 * dbusbind.c: Don't possibly lose pointer info when converting.
10598 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10599 Use XPNTR rather than XHASH, so that the high-order bits of
10600 the pointer aren't lost when converting through void *.
10601
51639eac
PE
10602 * eval.c (Fautoload): Don't double-shift a pointer.
10603
92394119
PE
10604 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10605
dbdb9a7c
JB
106062011-05-06 Juanma Barranquero <lekktu@gmail.com>
10607
10608 * gnutls.c (DEF_GNUTLS_FN):
10609 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10610
db7a0b4f
AS
106112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10612
10613 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10614 marker. (Bug#8610)
10615
cd394be1 106162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10617
10618 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10619 New version that can reserve upto 2GB of heap space.
10620
f7ff1b0f 106212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10622
10623 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10624
639c109b
TZ
106252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10626
10627 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10628 `gnutls_certificate_set_x509_key_file'.
10629
d2127135
JB
106302011-05-05 Juanma Barranquero <lekktu@gmail.com>
10631
10632 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10633 Update dependencies.
10634
e968f4f3
JB
106352011-05-04 Juanma Barranquero <lekktu@gmail.com>
10636
10637 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10638 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10639 Remove unused parameter `fildes'.
10640 * process.c (read_process_output, send_process): Don't pass it.
10641
84d358f0
JB
106422011-05-04 Juanma Barranquero <lekktu@gmail.com>
10643
10644 Fix previous change: the library cache is defined in w32.c.
10645 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10646 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10647
0898ca10
JB
106482011-05-04 Juanma Barranquero <lekktu@gmail.com>
10649
10650 Implement dynamic loading of GnuTLS on Windows.
10651
10652 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10653 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10654 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10655 Declare.
10656
10657 * gnutls.c (Qgnutls_dll): Define.
10658 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10659 (gnutls_*): Declare function pointers.
10660 (init_gnutls_functions): New function to initialize function pointers.
10661 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10662 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10663 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10664 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10665 (emacs_gnutls_write, emacs_gnutls_read)
10666 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10667 (Fgnutls_available_p): New function.
10668 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10669 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10670 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10671
10672 * image.c: Include w32.h.
10673 (Vimage_type_cache): Delete.
10674 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10675 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10676 (w32_delayed_load): Move to w32.c.
10677
10678 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10679
10680 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10681 (w32_delayed_load): Move from image.c. When loading a library, record
10682 its filename in the :loaded-from property of the library id.
10683 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10684 Initialize and staticpro them.
10685 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10686
10687 * process.c: Include lisp.h before w32.h, not after.
10688 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10689 instead of gnutls_record_check_pending.
10690
10691 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10692
ff4de4aa
TZ
106932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10694
10695 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10696 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10697 as passed in.
10698
abe95abb
JD
106992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10700
10701 * xterm.c (x_set_frame_alpha): Do not set property on anything
10702 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10703
e16e55d4
JB
107042011-05-02 Juanma Barranquero <lekktu@gmail.com>
10705
10706 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10707
bafcf6a5
JB
107082011-05-02 Juanma Barranquero <lekktu@gmail.com>
10709
10710 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10711 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10712 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10713 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10714 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10715 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10716 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10717 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10718 (Qgnutls_bootprop_callbacks_verify): Make static.
10719
e7a6747f
AS
107202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10721
19ed11ba
AS
10722 * callproc.c: Indentation fixup.
10723
e7a6747f 10724 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10725 (wait_for_termination, interruptible_wait_for_termination):
10726 Move after wait_for_termination_1.
e7a6747f 10727
1ef14cb4
LMI
107282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10729
10730 * sysdep.c (interruptible_wait_for_termination): New function
10731 which is like wait_for_termination, but allows keyboard
10732 interruptions.
10733
10734 * callproc.c (Fcall_process): Add (:file "file") as an option for
10735 the STDOUT buffer.
10736 (Fcall_process_region): Ditto.
10737
330d880c
EZ
107382011-04-30 Eli Zaretskii <eliz@gnu.org>
10739
8db90b73
EZ
10740 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10741 rather than `XVECTOR (FOO)->size'.
10742
330d880c
EZ
10743 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10744 inttypes.h, as a gnulib replacement is used if it not available in
10745 system headers.
10746
15cbd324
EZ
107472011-04-21 Eli Zaretskii <eliz@gnu.org>
10748
10749 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10750 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10751 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10752
10753 * coding.c (coding_alloc_by_realloc): Error out if destination
10754 will grow beyond MOST_POSITIVE_FIXNUM.
10755 (decode_coding_emacs_mule): Abort if there isn't enough place in
10756 charbuf for the composition carryover bytes. Reserve an extra
10757 space for up to 2 characters produced in a loop.
10758 (decode_coding_iso_2022): Abort if there isn't enough place in
10759 charbuf for the composition carryover bytes.
10760
107612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10762
ae940cca
EZ
10763 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10764 aborting when %lld or %lll format is passed.
10765 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10766 %llo or %llx format is passed. (Bug#8545)
10767
03ab8921
EZ
10768 * window.c (window_scroll_line_based): Use a marker instead of
10769 simple variables to record original value of point. (Bug#7952)
10770
afda1437
EZ
10771 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10772 produced by %s or %c overflows available buffer space. (Bug#8545)
10773
f76dee0c
PE
107742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10775
10776 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10777 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10778
fdc5744d
JB
107792011-04-28 Juanma Barranquero <lekktu@gmail.com>
10780
10781 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10782
638f053a
JB
107832011-04-28 Juanma Barranquero <lekktu@gmail.com>
10784
10785 * keyboard.c (Qdelayed_warnings_hook): Define.
10786 (command_loop_1): Run `delayed-warnings-hook'
10787 if Vdelayed_warnings_list is non-nil.
10788 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10789 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10790
d178f871
EZ
107912011-04-28 Eli Zaretskii <eliz@gnu.org>
10792
10793 * doprnt.c (doprnt): Don't return value smaller than the buffer
10794 size if the message was truncated. (Bug#8545).
10795
b124fd93
JB
107962011-04-28 Juanma Barranquero <lekktu@gmail.com>
10797
10798 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10799 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10800
e810457d
PE
108012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10802
10803 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10804
ea51cceb
JB
108052011-04-27 Juanma Barranquero <lekktu@gmail.com>
10806
10807 * makefile.w32-in: Update dependencies.
10808
94dcfacf
EZ
108092011-04-27 Eli Zaretskii <eliz@gnu.org>
10810
10811 Improve `doprnt' and its usage. (Bug#8545)
10812 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10813 `format_end'. Remove support for %l as a conversion specifier.
10814 Don't use xrealloc. Improve diagnostics when the %l size modifier
10815 is used. Update the commentary.
10816
10817 * eval.c (verror): Simplify calculation of size_t.
10818
10819 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10820 messages.
10821
f61f41d7
PE
108222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10823
10824 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10825 change.
10826
96fb4434
PE
108272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10828
10829 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10830 This makes this file independent of the recent pseudovector change.
10831
671875da 108322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10833
69e9b5a3
PE
10834 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10835
b5f869a7 10836 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10837 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10838 Remove unused local.
c8926152 10839 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10840
841a1577 10841 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10842 GCC 4.6.0 optimizes based on type-based alias analysis.
10843 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10844 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10845 != &v->size, and therefore "v->size = 1; b->size = 2; return
10846 v->size;" must therefore return 1. This assumption is incorrect
10847 for Emacs, since it type-puns struct Lisp_Vector * with many other
10848 types. To fix this problem, this patch adds a new type struct
f904488f 10849 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10850 and pseudovectors, and helps optimizing compilers not get fooled
10851 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10852 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10853 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10854 the size member.
eab3844f
PE
10855 (XSETPVECTYPE): Rewrite in terms of new macro.
10856 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10857 This is a bit clearer, and further avoids the possibility of
10858 undesirable aliasing.
10859 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10860 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10861 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10862 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10863 (ASIZE): Now uses header.size rather than size.
10864 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10865 to avoid the hassle of writing XVECTOR (foo)->header.size.
10866 (struct vectorlike_header): New type.
eab3844f
PE
10867 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10868 object, to help avoid aliasing.
10869 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10870 (SUBRP): Likewise, since Lisp_Subr is a special case.
10871 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10872 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10873 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10874 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10875 changed to be "header.size" and "header.next".
10876 * buffer.h (struct buffer): Likewise.
10877 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10878 * frame.h (struct frame): Likewise.
10879 * process.h (struct Lisp_Process): Likewise.
10880 * termhooks.h (struct terminal): Likewise.
10881 * window.c (struct save_window_data, struct saved_window): Likewise.
10882 * window.h (struct window): Likewise.
10883 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10884 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10885 * buffer.c (init_buffer_once): Likewise.
10886 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10887 special case.
10888 * process.c (Fformat_network_address): Use local var for size,
10889 for brevity.
10890
0df1eac5
PE
10891 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10892
847ab9d1 10893 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10894 * data.c (atof): Remove decl; no longer used or needed.
10895 (digit_to_number): Move to lread.c.
10896 (Fstring_to_number): Use new string_to_number function, to be
10897 consistent with how the Lisp reader treats infinities and NaNs.
10898 Do not assume that floating-point numbers represent EMACS_INT
10899 without losing information; this is not true on most 64-bit hosts.
10900 Avoid double-rounding errors, by insisting on integers when
10901 parsing non-base-10 numbers, as the documentation specifies.
10902 * lisp.h (string_to_number): New decl, replacing ...
10903 (isfloat_string): Remove.
bc0a5c13 10904 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10905 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10906 appears to have been a coding error. Similarly, do not accept
10907 strings like +-1e0 as floating point numbers. Do not report
10908 overflow for integer overflows unless the base is not 10 which
10909 means we have no simple and reliable way to continue.
10910 Break out the floating-point parsing into a new
10911 function string_to_number, so that Fstring_to_number parses
10912 floating point numbers consistently with the Lisp reader.
04f2d78b 10913 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10914 (E_CHAR, EXP_INT): Remove, replacing with ...
10915 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10916 (string_to_number): New function, replacing isfloat_string.
10917 This function checks for valid syntax and produces the resulting
10918 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10919 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10920 so that overflow for non-base-10 numbers is reported only when
10921 there's no portable and simple way to convert to floating point.
452f4150 10922
67769ffc
PE
10923 * textprop.c (set_text_properties_1): Rewrite for clarity,
10924 and to avoid GCC warning about integer overflow.
10925
c20db43f
PE
10926 * intervals.h (struct interval): Use EMACS_INT for members
10927 where EMACS_UINT might cause problems. See
10928 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10929 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10930 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10931 All uses changed.
37aa2f85
PE
10932 (offset_intervals): Tell GCC not to worry about length overflow
10933 when negating a negative length.
c20db43f 10934
2538aa2f
PE
10935 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10936 (overrun_check_free): Likewise.
10937
f2d3008d
PE
10938 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10939 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10940 word size.
10941
ec8df744
PE
10942 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10943 (gnutls_make_error): Rename local to avoid shadowing.
10944 (gnutls_emacs_global_deinit): ifdef out; not used.
10945 (Fgnutls_boot): Use const for pointer to readonly storage.
10946 Comment out unused local. Fix pointer signedness problems.
10947
640ee02d
PE
10948 * lread.c (openp): Don't stuff size_t into an 'int'.
10949 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10950 about possible signed overflow.
10951
6048fb2a
PE
10952 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10953 (GDK_KEY_g): Don't define if already defined.
10954 (xg_prepare_tooltip): Avoid pointer signedness problem.
10955 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10956
fa3c87e1
PE
10957 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10958 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10959
2172544b
PE
10960 * xfns.c (Fx_window_property): Simplify a bit,
10961 to make a bit faster and to avoid GCC 4.6.0 warning.
10962 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10963
9b821a21
PE
10964 * fns.c (internal_equal): Don't assume size_t fits in int.
10965
3c616cfa
PE
10966 * alloc.c (compact_small_strings): Tighten assertion a little.
10967
c2982e87
PE
10968 Replace pEd with more-general pI, and fix some printf arg casts.
10969 * lisp.h (pI): New macro, generalizing old pEd macro to other
10970 conversion specifiers. For example, use "...%"pI"d..." rather
10971 than "...%"pEd"...".
10972 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10973 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10974 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10975 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10976 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10977 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10978 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10979 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10980 64-bit hosts.
10981 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10982 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10983 * print.c (safe_debug_print, print_object): Likewise.
10984 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10985 to int.
6f04d126
PE
10986 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10987 avoiding the 0 flag, which is not portable.
c2982e87
PE
10988 * process.c (Fmake_network_process): Use pI to avoid cast.
10989 * region-cache.c (pp_cache): Likewise.
10990 * xdisp.c (decode_mode_spec): Likewise.
10991 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10992 behavior on 64-bit hosts with printf arg.
6f04d126 10993 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10994 (x_stop_queuing_selection_requests): Likewise.
10995 (x_get_window_property): Don't truncate byte count to an 'int'
10996 when tracing.
0b432f21 10997
5e073ec7
PE
10998 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10999 here, since it parses constructs like leading '-' and spaces,
11000 which are not wanted; and it overflows with large numbers.
11001 Instead, simply match F[0-9]+, which is what is wanted anyway.
11002
36372bf9
PE
11003 * alloc.c: Remove unportable assumptions about struct layout.
11004 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11005 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11006 (allocate_vectorlike, make_pure_vector): Use the new macros,
11007 plus offsetof, to remove unportable assumptions about struct layout.
11008 These assumptions hold on all porting targets that I know of, but
11009 they are not guaranteed, they're easy to remove, and removing them
11010 makes further changes easier.
11011
0b432f21
PE
11012 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11013 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11014 (string_overrun_cookie): Now const. Use initializers that
11015 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11016 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11017 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11018 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11019 multiple of sizeof (EMACS_INT); it need not be, if
11020 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11021 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11022
895009e1
JB
110232011-04-26 Juanma Barranquero <lekktu@gmail.com>
11024
11025 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11026
6a7a1b0b
TZ
110272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11028
11029 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11030 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11031 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11032
841a1577 110332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11034
11035 * lisp.h (Qdebug): List symbol.
895009e1 11036 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11037 * keyboard.c (debug-on-event): New variable.
11038 (handle_user_signal): Break into debugger when debug-on-event
11039 matches the current signal symbol.
11040
f2d3ba6f
DN
110412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11042
11043 * alloc.c (check_sblock, check_string_bytes)
11044 (check_string_free_list): Convert to standard C.
11045
42ce4c63
TZ
110462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11047
11048 * w32.c (emacs_gnutls_push): Fix typo.
11049
825cd63c
EZ
110502011-04-25 Eli Zaretskii <eliz@gnu.org>
11051
fb11d64d
EZ
11052 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11053 "cast to pointer from integer of different size".
11054
825cd63c
EZ
11055 Improve doprnt and its use in verror. (Bug#8545)
11056 * doprnt.c (doprnt): Document the set of format control sequences
11057 supported by the function. Use SAFE_ALLOCA instead of always
11058 using `alloca'.
11059
11060 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11061 is one byte too soon. Don't use xrealloc; instead xfree and
11062 xmalloc anew.
11063
e061a11b
TZ
110642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11065
11066 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11067 callbacks stage.
11068
11069 * gnutls.c: Renamed global_initialized to
11070 gnutls_global_initialized. Added internals for the
11071 :verify-hostname-error, :verify-error, and :verify-flags
11072 parameters of `gnutls-boot' and documented those parameters in the
11073 docstring. Start callback support.
9173deec
JB
11074 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11075 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11076 on error. Return error code.
e061a11b
TZ
11077 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11078 (emacs_gnutls_read): Likewise.
11079 (Fgnutls_boot): Return handshake error code.
11080 (emacs_gnutls_handle_error): New function.
11081 (wsaerror_to_errno): Likewise.
11082
11083 * w32.h (emacs_gnutls_pull): Add prototype.
11084 (emacs_gnutls_push): Likewise.
11085
11086 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11087 (emacs_gnutls_push): Likewise.
11088
110892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11090
11091 * process.c (wait_reading_process_output): Check if GnuTLS
11092 buffered some data internally if no FDs are set for TLS
11093 connections.
11094
11095 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11096 (LIBS): Link to USER_LIBS.
11097 ($(BLD)/gnutls.$(0)): New target.
11098
fa6996bc
EZ
110992011-04-24 Eli Zaretskii <eliz@gnu.org>
11100
eb35682e
EZ
11101 * xdisp.c (handle_single_display_spec): Rename the
11102 display_replaced_before_p argument into display_replaced_p, to
11103 make it consistent with the commentary. Fix typos in the
11104 commentary.
11105
e2ad650c
EZ
11106 * textprop.c (syms_of_textprop): Remove dead code.
11107 (copy_text_properties): Delete obsolete commentary about an
11108 interface that was deleted long ago. Fix typos in the description
11109 of arguments.
11110
1b2de274
EZ
11111 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11112 to changes in oldXMenu/XMenu.h from 2011-04-16.
11113 <menu_help_message, prev_menu_help_message>: Constify.
11114 (IT_menu_make_room): menu->help_text is now `const char **';
11115 adjust.
11116
11117 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11118 to changes in oldXMenu/XMenu.h from 2011-04-16.
11119 (struct XMenu): Declare `help_text' `const char **'.
11120
11121 * xfaces.c <Qunspecified>: Make extern again.
11122
11123 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11124 required by POSIX.
1b2de274 11125
762b15be
EZ
11126 * doc.c (get_doc_string): Improve the format passed to `error'.
11127
11128 * doprnt.c (doprnt): Improve commentary.
11129
11130 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11131
11132 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11133 them with etags.
11134
f1052e5d
EZ
11135 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11136 changes in globals.h immediately force recompilation.
762b15be
EZ
11137 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11138 $(CURDIR)/s/ms-w32.h.
11139 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11140
fa6996bc
EZ
11141 * character.c (Fchar_direction): Function deleted.
11142 (syms_of_character): Don't defsubr it.
11143 <char-direction-table>: Deleted.
11144
e6c3da20
EZ
111452011-04-23 Eli Zaretskii <eliz@gnu.org>
11146
11147 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11148 * doprnt.c: Include limits.h.
11149 (SIZE_MAX): New macro.
04f2d78b
CB
11150 (doprnt): Return a size_t value. 2nd arg is now size_t.
11151 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11152 Improve overflow protection. Support `l' modifier for integer
11153 conversions. Support %l conversion. Don't assume an EMACS_INT
11154 argument for integer conversions and for %c.
11155
11156 * lisp.h (doprnt): Restore prototype.
11157
11158 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11159 $(SRC)/character.h.
11160
11161 * Makefile.in (base_obj): Add back doprnt.o.
11162
11163 * deps.mk (doprnt.o): Add back prerequisites.
11164 (callint.o): Depend on character.h.
11165
11166 * eval.c (internal_lisp_condition_case): Include the handler
11167 representation in the error message.
11168 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11169 when breaking from the loop.
11170
11171 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11172
11173 * callint.c (Fcall_interactively): When displaying error message
11174 about invalid control letter, pass the character's codepoint, not
11175 a pointer to its multibyte form. Improve display of the character
11176 in octal and display also its hex code.
11177
11178 * character.c (char_string): Use %x to display the (unsigned)
11179 codepoint of an invalid character, to avoid displaying a bogus
11180 negative value.
11181
11182 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11183 `error', not SYMBOL_NAME itself.
11184
11185 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11186 character arguments to `error'.
11187
11188 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11189 to `error' in error message about FINAL_CHAR argument. Make sure
11190 FINAL_CHAR is a character, and use %c when it is passed as
11191 argument to `error'.
11192
4ffd0d6b 111932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11194
11195 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11196
11197 * w32.c: Include <time.h>.
11198 (sys_localtime): New function.
11199
4ffd0d6b 112002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11201
11202 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11203
4ffd0d6b 11204 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11205
4ffd0d6b 112062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11207
4ffd0d6b
GM
11208 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11209 zombies (Bug#8467).
aac0c6e3 11210
04c56954
EZ
112112011-04-19 Eli Zaretskii <eliz@gnu.org>
11212
11213 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11214 gl_state.e_property when gl_state.object is Qt.
11215
11216 * insdel.c (make_gap_larger): Remove limitation of buffer size
11217 to <= INT_MAX.
11218
16a43933
CY
112192011-04-18 Chong Yidong <cyd@stupidchicken.com>
11220
11221 * xdisp.c (lookup_glyphless_char_display)
11222 (produce_glyphless_glyph): Handle cons cell entry in
11223 glyphless-char-display.
11224 (Vglyphless_char_display): Document it.
11225
11226 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11227 glyphless-char-display.
11228
4581706e
CY
112292011-04-17 Chong Yidong <cyd@stupidchicken.com>
11230
11231 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11232
11233 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11234
11235 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11236 definition for no-X builds.
11237
4887c6e2 112382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11239
fd35b6f9
PE
11240 Static checks with GCC 4.6.0 and non-default toolkits.
11241
5c1ccb01
PE
11242 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11243
006c5daa
PE
11244 * process.c (keyboard_bit_set): Define only if SIGIO.
11245 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11246 (send_process): Repair possible setjmp clobbering.
11247
efc736d3
PE
11248 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11249
4e2fe2e6
PE
11250 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11251
f97334a2
PE
11252 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11253
4e75f29d
PE
11254 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11255 Define only if needed.
11256
90efadd1
PE
11257 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11258 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11259 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11260
3c647824
PE
11261 * dispextern.h (struct redisplay_interface): Rename param
11262 to avoid shadowing.
e264f262 11263 * termhooks.h (struct terminal): Likewise.
761383f4 11264 * xterm.c (xembed_send_message): Likewise.
3c647824 11265
b58c5c4a
PE
11266 * insdel.c (make_gap_smaller): Define only if
11267 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11268
cad59032
PE
11269 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11270 it.
11271
c339dc2e
PE
11272 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11273 so that we aren't warned about unused symbols.
11274
91a3e27b
PE
11275 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11276
399c71d3 11277 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11278
8ffc96f5
PE
11279 * xfns.c (x_real_positions): Mark locals as initialized.
11280
eef9bc79
PE
11281 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11282
098db9dd
PE
11283 * xterm.c: Fix problems found by static analysis with other toolkits.
11284 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11285 (x_dispatch_event): Declare static if USE_GTK, and
11286 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11287 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11288 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11289 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11290 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11291
eb18f6cc
PE
11292 * xmenu.c (menu_help_callback): Pointer type fixes.
11293 Use const pointers when pointing at readonly data. Avoid pointer
11294 signedness clashes.
11295 (FALSE): Remove unused macro.
11296 (update_frame_menubar): Remove unused decl.
11297
1fe72bf8
PE
11298 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11299
60d9e1db
PE
11300 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11301 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11302 (single_menu_item): Rename local to avoid shadowing.
11303
39261c26
PE
11304 * keyboard.c (make_lispy_event): Remove unused local var.
11305
018c5e19
PE
11306 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11307 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11308
63d2b86e
PE
11309 * bitmaps: Change bitmaps from unsigned char back to the X11
11310 compatible char. Avoid the old compiler warnings about
11311 out-of-range initializers by using, for example, '\xab' rather
11312 than 0xab.
11313
aefd87e1
PE
11314 * xgselect.c (xgselect_initialize): Check vs interface
11315 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11316
bf501fb9
PE
11317 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11318
e9829fdf
PE
11319 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11320 to read-only memory.
11321
1086c095
PE
11322 * fns.c (vector): Remove; this old hack is no longer needed.
11323
2baccd04 11324 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11325 Remove unused var.
dde42981 11326 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11327
72391843 11328 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11329
436c16df 11330 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11331 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11332 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11333
92bb796d 11334 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11335 (x_term_init): Remove local to avoid shadowing.
92bb796d 11336
764430a3 11337 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11338
11339 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11340 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11341
d1dfb56c
EZ
113422011-04-16 Eli Zaretskii <eliz@gnu.org>
11343
c4354cb4
EZ
11344 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11345
d1dfb56c
EZ
11346 Fix regex.c, syntax.c and friends for buffers > 2GB.
11347 * syntax.h (struct gl_state_s): Declare character position members
11348 EMACS_INT.
11349
11350 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11351
04f2d78b
CB
11352 * textprop.c (verify_interval_modification, interval_of):
11353 Declare arguments EMACS_INT.
d1dfb56c
EZ
11354
11355 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11356 EMACS_INT.
11357
11358 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11359
11360 * indent.c (Fvertical_motion): Local variable it_start is now
11361 EMACS_INT.
11362
11363 * regex.c (re_match, re_match_2, re_match_2_internal)
11364 (bcmp_translate, regcomp, regexec, print_double_string)
11365 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11366 (re_compile_pattern, re_exec): Declare arguments and local
11367 variables `size_t' and `ssize_t' and return values `regoff_t', as
11368 appropriate.
11369 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11370 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11371 <compile_stack_type>: `size' and `avail' are now `size_t'.
11372
11373 * regex.h <regoff_t>: Use ssize_t, not int.
11374 (re_search, re_search_2, re_match, re_match_2): Arguments that
11375 specify buffer/string position and length are now ssize_t and
11376 size_t. Return type is regoff_t.
11377
613052cd
BK
113782011-04-16 Ben Key <bkey76@gmail.com>
11379
11380 * nsfont.m: Fixed bugs in ns_get_family and
11381 ns_descriptor_to_entity that were caused by using free to
11382 deallocate memory blocks that were allocated by xmalloc (via
11383 xstrdup). This caused Emacs to crash when compiled with
11384 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11385 --enable-checking=xmallocoverrun). xfree is now used to
11386 deallocate these memory blocks.
11387
4170f62f 113882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11389
71b41406
PE
11390 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11391
9587a89d
PE
11392 emacs_write: Accept and return EMACS_INT for sizes.
11393 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11394 et seq.
11395 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11396 Accept and return EMACS_INT.
11397 (emacs_gnutls_write): Return the number of bytes written on
11398 partial writes.
11399 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11400 (emacs_read, emacs_write): Remove check for negative size, as the
11401 Emacs source code has been audited now.
9587a89d
PE
11402 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11403 (emacs_read, emacs_write): Use it.
273a5f82
PE
11404 * process.c (send_process): Adjust to the new signatures of
11405 emacs_write and emacs_gnutls_write. Do not attempt to store
11406 a byte offset into an 'int'; it might overflow.
9587a89d 11407 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11408
3e047f51
PE
11409 * sound.c: Don't assume sizes fit in 'int'.
11410 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11411 Return EMACS_INT, not int.
3e047f51 11412 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11413 Accept EMACS_INT, not int.
11414 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11415 record read return values.
11416
cc39a9db
BK
114172011-04-15 Ben Key <bkey76@gmail.com>
11418
c9d0ec6d
JB
11419 * keyboard.c (Qundefined): Don't declare static since it is used
11420 in nsfns.m.
11421 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11422 static since they are used in nsfont.m.
cc39a9db 11423
6c60eb9f
SM
114242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11425
11426 * process.c (Qprocessp): Don't declare static.
11427 * lisp.h (Qprocessp): Declare again.
11428
7990b61a
JB
114292011-04-15 Juanma Barranquero <lekktu@gmail.com>
11430
11431 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11432
5d4cb038
PE
114332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11434
8bd7b830 11435 Improve C-level modularity by making more things 'static'.
cd64ea1d 11436
e3b27b31
PE
11437 Don't publish debugger-only interfaces to other modules.
11438 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11439 (verify_bytepos, count_markers): Move decls to the only modules
11440 that need them.
11441 * region-cache.h (pp_cache): Likewise.
11442 * window.h (check_all_windows): Likewise.
11443 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11444
5d4cb038
PE
11445 * sysdep.c (croak): Now static, if
11446 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11447 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11448
11449 * alloc.c (refill_memory_reserve): Now static if
11450 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11451 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11452
e87b6180
PE
11453 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11454 Define only if USE_LUCID.
11455
ac64929e
PE
11456 * xrdb.c (x_customization_string, x_rm_string): Now static.
11457
6f37259d
PE
11458 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11459 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11460
1683e3ab
PE
11461 * xdisp.c (draw_row_with_mouse_face): Now static.
11462 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11463
de9c2632
PE
11464 * window.h (check_all_windows): Mark externally visible.
11465
2b96acb7
PE
11466 * window.c (window_deletion_count): Now static.
11467
11468 * undo.c: Make symbols static if they're not exported.
11469 (last_undo_buffer, last_boundary_position, pending_boundary):
11470 Now static.
11471
50436f33
PE
11472 * textprop.c (interval_insert_behind_hooks): Now static.
11473 (interval_insert_in_front_hooks): Likewise.
11474
64520e5c
PE
11475 * term.c: Make symbols static if they're not exported.
11476 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11477 (max_frame_lines, tty_set_terminal_modes):
11478 (tty_reset_terminal_modes, tty_turn_off_highlight):
11479 (get_tty_terminal): Now static.
11480 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11481 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11482 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11483 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11484 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11485
1fa53021
PE
11486 * sysdep.c: Make symbols static if they're not exported.
11487 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11488 Now static.
11489 (sigprocmask_set, full_mask): Remove; unused.
11490 (wait_debugging): Mark as visible.
11491 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11492 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11493
d4b43b22
PE
11494 * syntax.c (syntax_temp): Define only if !__GNUC__.
11495
b7c513d0
PE
11496 * sound.c (current_sound_device, current_sound): Now static.
11497
989b29ad
PE
11498 * search.c (searchbufs, searchbuf_head): Now static.
11499
13a55a78
PE
11500 * scroll.c (scroll_cost): Remove; unused.
11501 * dispextern.h (scroll_cost): Remove decl.
11502
de68a1fc
PE
11503 * region-cache.h (pp_cache): Mark as externally visible.
11504
40ccffa6
PE
11505 * process.c: Make symbols static if they're not exported.
11506 (process_tick, update_tick, create_process, chan_process):
11507 (Vprocess_alist, proc_buffered_char, datagram_access):
11508 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11509 (deactivate_process): Mark defn as static, as well as decl.
11510 * lisp.h (create_process): Remove decl.
11511 * process.h (chan_process, Vprocess_alist): Remove decls.
11512
ad64fc97
PE
11513 * print.c: Make symbols static if they're not exported.
11514 (print_depth, new_backquote_output, being_printed, print_buffer):
11515 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11516 (print_interval, print_number_index, initial_stderr_stream):
11517 Now static.
11518 * lisp.h (Fprinc): Remove decl.
11519 (debug_output_compilation_hack): Mark as externally visible.
11520
adddb265
PE
11521 * sysdep.c (croak): Move decl from here to syssignal.h.
11522 * syssignal.h (croak): Put it here, so the API can be checked when
11523 'croak' is called from dissociate_if_controlling_tty.
11524
1717ede2
PE
11525 * minibuf.c: Make symbols static if they're not exported.
11526 (minibuf_save_list, choose_minibuf_frame): Now static.
11527 * lisp.h (choose_minibuf_frame): Remove decl.
11528
fa5fb2bc
PE
11529 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11530
1e3890d1
PE
11531 * lread.c: Make symbols static if they're not exported.
11532 (read_objects, initial_obarray, oblookup_last_bucket_number):
11533 Now static.
11534 (make_symbol): Remove; unused.
11535 * lisp.h (initial_obarray, make_symbol): Remove decls.
11536
8a1414fa
PE
11537 * keyboard.c: Make symbols static if they're not exported.
11538 (single_kboard, recent_keys_index, total_keys, recent_keys):
11539 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11540 (this_single_command_key_start, echoing, last_auto_save):
11541 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11542 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11543 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11544 (Vlispy_mouse_stem, double_click_count):
11545 Now static.
11546 (force_auto_save_soon): Define only if SIGDANGER.
11547 (ignore_mouse_drag_p): Now static if
11548 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11549 (print_help): Remove; unused.
11550 (stop_character, last_timer_event): Mark as externally visible.
11551 * keyboard.h (ignore_mouse_drag_p): Declare only if
11552 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11553 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11554 * lisp.h (echoing): Remove decl.
11555 (force_auto_save_soon): Declare only if SIGDANGER.
11556 * xdisp.c (redisplay_window): Simplify code, to make it more
11557 obvious that ignore_mouse_drag_p is not accessed if !defined
11558 USE_GTK && !defined HAVE_NS.
11559
93ea6e8f
PE
11560 * intervals.c: Make symbols static if they're not exported.
11561 (merge_properties_sticky, merge_interval_right, delete_interval):
11562 Now static.
11563 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11564
77382fcc
PE
11565 * insdel.c: Make symbols static if they're not exported.
11566 However, leave prepare_to_modify_buffer alone. It's never
11567 called from outside this function, but that appears to be a bug.
11568 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11569 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11570 (adjust_after_replace_noundo): Remove; unused.
11571 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11572 (signal_before_change): Remove decls.
77382fcc 11573
9306c32e
PE
11574 * indent.c (val_compute_motion, val_vmotion): Now static.
11575
cd44d2eb
PE
11576 * image.c: Make symbols static if they're not exported.
11577 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11578 if USE_GTK.
11579 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11580 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11581
ad9a7a06
PE
11582 * fringe.c (standard_bitmaps): Now static.
11583 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11584
81626931
PE
11585 * frame.c: Make symbols static if they're not exported.
11586 (x_report_frame_params, make_terminal_frame): Now static.
11587 (get_frame_param): Now static, unless HAVE_NS.
11588 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11589 (x_get_resource_string): Remove; not used.
11590 * frame.h (make_terminal_frame, x_report_frame_params):
11591 (x_get_resource_string); Remove decls.
11592 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11593 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11594
239f9db9
PE
11595 * font.c, fontset.c: Make symbols static if they're not exported.
11596 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11597 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11598 * font.c (font_close_object): Now static.
11599 * font.h (font_close_object): Remove.
11600 * fontset.c (FONTSET_OBJLIST): Remove.
11601 (free_realized_fontset) #if-0 the body, which does nothing.
11602 (face_suitable_for_char_p): #if-0, as it's never called.
11603 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11604 * xfaces.c (face_at_string_position):
11605 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11606 since 0 is always ASCII.
11607
dfcf3579
PE
11608 * fns.c (weak_hash_tables): Now static.
11609
5045092b
PE
11610 * fileio.c: Make symbols static if they're not exported.
11611 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11612 (Vwrite_region_annotation_buffers): Now static.
11613
57a96f5c
PE
11614 * eval.c: Make symbols static if they're not exported.
11615 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11616 * lisp.h (backtrace_list): Remove decl.
11617
35f08c38
PE
11618 * emacs.c: Make symbols static if they're not exported.
11619 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11620 (fatal_error_code, fatal_error_signal_hook, standard_args):
11621 Now static.
11622 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11623 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11624 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11625 * lisp.h (fatal_error_signal_hook): Remove decl.
11626 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11627
f44bd759
PE
11628 * editfns.c: Move a (normally-unused) function to its only use.
11629 * editfns.c, lisp.h (get_operating_system_release): Remove.
11630 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11631 worth the hassle of breaking this out.
11632
b532497d
PE
11633 * xterm.c: Make symbols static if they're not exported.
11634 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11635 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11636 (x_destroy_window, x_delete_display):
11637 Now static.
11638 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11639 (x_mouse_leave): Remove; unused.
11640 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11641 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11642 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11643 Remove decls.
11644 (x_mouse_leave): Declare only if WINDOWSNT.
11645 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11646 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11647 USE_X_TOOLKIT.
11648
1675728f
PE
11649 * ftxfont.c: Make symbols static if they're not exported.
11650 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11651 HAVE_FREETYPE.
11652 * font.h (ftxfont_driver): Likewise.
11653
e4cebfca
PE
11654 * xfns.c: Make symbols static if they're not exported.
11655 (x_last_font_name, x_display_info_for_name):
11656 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11657 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11658 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11659 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11660 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11661 (last_show_tip_args): Now static.
11662 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11663 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11664 (x_screen_planes): Remove; unused.
11665 * dispextern.h (x_screen_planes): Remove decl.
11666
5bf46f05
PE
11667 * dispnew.c: Make symbols static if they're not exported.
11668 * dispextern.h (redraw_garbaged_frames, scrolling):
11669 (increment_row_positions): Remove.
11670 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11671 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11672 Now static.
11673 (redraw_garbaged_frames): Remove; unused.
11674
435f4c28
PE
11675 * xfaces.c: Make symbols static if they're not exported.
11676 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11677 Remove decls.
11678 * xterm.h (defined_color): Remove decls.
11679 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11680 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11681 (menu_face_changed_default, defined_color, free_realized_face):
11682 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11683 (ascii_face_of_lisp_face): Remove; unused.
11684
8524aef3
PE
11685 * xdisp.c: Make symbols static if they're not exported.
11686 * dispextern.h (scratch_glyph_row, window_box_edges):
11687 (glyph_to_pixel_coords, set_cursor_from_row):
11688 (get_next_display_element, set_iterator_to_next):
11689 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11690 (show_mouse_face): Remove decls
11691 * frame.h (message_buf_print): Likewise.
11692 * lisp.h (pop_message, set_message, check_point_in_composition):
11693 Likewise.
11694 * xterm.h (set_vertical_scroll_bar): Likewise.
11695 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11696 (message_buf_print, scratch_glyph_row, displayed_buffer):
11697 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11698 (get_next_display_element, show_mouse_face, window_box_edges):
11699 (frame_to_window_pixel_xy, check_point_in_composition):
11700 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11701 (glyph_to_pixel_coords): Remove; unused.
11702
16390cd2
PE
11703 * dired.c (file_name_completion): Now static.
11704
11705 * dbusbind.c (xd_in_read_queued_messages): Now static.
11706
a25f4dfa
PE
11707 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11708 * data.c (circular_list_error): Remove.
11709
14a9c8df
PE
11710 * commands.h (last_point_position, last_point_position_buffer):
11711 (last_point_position_window): Remove decls.
11712 * keyboard.c: Make these variables static.
11713
04f2d78b
CB
11714 * coding.h (coding, code_convert_region, encode_coding_gap):
11715 Remove decls.
74ab6df5
PE
11716 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11717 (iso_code_class, detect_coding, code_convert_region): Now static.
11718 (encode_coding_gap): Remove; unused.
11719
38dfbee1
PE
11720 * chartab.c (chartab_chars, chartab_bits): Now static.
11721
a2cb4e63
PE
11722 * charset.h (charset_iso_8859_1): Remove decl.
11723 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11724 Now static.
11725
127198fd
PE
11726 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11727 * ccl.c (Vccl_program_table): Now static.
11728 (check_ccl_update): Remove; unused.
11729
d85b608f
PE
11730 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11731 * category.h: ... from here.
11732 * category.c (check_category_table, set_category_set): Now static.
11733
31cd66f3
PE
11734 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11735 * lisp.h: Remove these decls.
11736
c358e587
PE
11737 * buffer.c (buffer_count): Remove unused var.
11738
e78aecca
PE
11739 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11740 so that it's not optimized away.
11741 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11742 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11743 exported only to the debugger.
11744
e192d7d3 11745 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11746 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11747
92470028
PE
11748 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11749 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11750 was inaccessible from Lisp.
11751 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11752 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11753
244ed907
PE
11754 alloc.c: Import and export fewer symbols, and remove unused items.
11755 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11756 is defined.
11757 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11758 it's not optimized away by whole-program optimization.
11759 (message_enable_multibyte, free_misc): Remove.
11760 (catchlist, handlerlist, mark_backtrace):
11761 Declare only if BYTE_MARK_STACK.
11762 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11763 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11764 (message_enable_multibyte): Remove decl.
11765 (free_misc, interval_free_list, float_block, float_block_index):
11766 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11767 (cons_free_list, last_marked_index):
11768 Now static.
11769 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11770 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11771 (mark_backtrace): Define only if BYTE_MARK_STACK.
11772 * xdisp.c (message_enable_multibyte): Now static.
11773
61c2b50e 11774 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11775 This makes it easier for human readers (and static analyzers)
11776 to see whether these variables are used from other modules.
11777 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11778 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11779 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11780 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11781 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11782 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11783 * xmenu.c, xselect.c:
11784 Declare Q* vars static if they are not used in other modules.
11785 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11786 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11787 Remove decls of unexported vars.
11788 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11789
95c82688
PE
11790 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11791
16a97296
PE
11792 Make Emacs functions such as Fatom 'static' by default.
11793 This makes it easier for human readers (and static analyzers)
11794 to see whether these functions can be called from other modules.
11795 DEFUN now defines a static function. To make the function external
11796 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11797 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11798 (Finit_image_library):
16a97296
PE
11799 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11800 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11801 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11802 Remove decls, since these functions are now static.
11803 (Funintern, Fget_internal_run_time): New decls, since these functions
11804 were already external.
95c82688 11805
16a97296
PE
11806 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11807 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11808 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11809 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11810 * keyboard.c, keymap.c, lread.c:
11811 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11812 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11813 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11814 Mark functions with DEFUE instead of DEFUN,
11815 if they are used in other modules.
11816 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11817 decls for now-static functions.
11818 * buffer.h (Fdelete_overlay): Remove decl.
11819 * callproc.c (Fgetenv_internal): Mark as internal.
11820 * composite.c (Fremove_list_of_text_properties): Remove decl.
11821 (Fcomposition_get_gstring): New forward static decl.
11822 * composite.h (Fcomposite_get_gstring): Remove decl.
11823 * dired.c (Ffile_attributes): New forward static decl.
11824 * doc.c (Fdocumntation_property): New forward static decl.
11825 * eval.c (Ffetch_bytecode): New forward static decl.
11826 (Funintern): Remove extern decl; now in .h file where it belongs.
11827 * fileio.c (Fmake_symbolic_link): New forward static decl.
11828 * image.c (Finit_image_library): New forward static decl.
11829 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11830 * intervals.h (Fprevious_property_change):
11831 (Fremove_list_of_text_properties): Remove decls.
11832 * keyboard.c (Fthis_command_keys): Remove decl.
11833 (Fcommand_execute): New forward static decl.
11834 * keymap.c (Flookup_key): New forward static decl.
11835 (Fcopy_keymap): Now static.
11836 * keymap.h (Flookup_key): Remove decl.
11837 * process.c (Fget_process): New forward static decl.
11838 (Fprocess_datagram_address): Mark as internal.
11839 * syntax.c (Fsyntax_table_p): New forward static decl.
11840 (skip_chars): Remove duplicate decl.
11841 * textprop.c (Fprevious_property_change): New forward static decl.
11842 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11843 Now internal.
11844 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11845 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11846
785bbd42
PE
11847 * editfns.c (Fformat): Remove unreachable code.
11848
8b913b57
AS
118492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11850
11851 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11852 change. (Bug#8496)
11853
a6744a35
EZ
118542011-04-13 Eli Zaretskii <eliz@gnu.org>
11855
11856 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11857 when at ZV. (Bug#8487)
11858
e7974947
AS
118592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11860
baad03f0
AS
11861 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11862 (Bug#8437)
11863 * keyboard.c (parse_tool_bar_item): Likewise.
11864 * sound.c (sound_cleanup, alsa_close): Likewise.
11865 * termcap.c (tgetent): Likewise.
11866 * xfns.c (x_default_font_parameter): Likewise.
11867 * xsettings.c (read_and_apply_settings): Likewise.
11868
e7974947
AS
11869 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11870 (overrun_check_free): Protoize.
11871
28272684
PE
118722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11873
11874 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11875 since callers should never pass a negative size.
11876 Change the signature to match that of plain 'read' and 'write'; see
11877 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11878 * lisp.h: Update prototypes of emacs_write and emacs_read.
11879
11997c76
EZ
118802011-04-11 Eli Zaretskii <eliz@gnu.org>
11881
11882 * xdisp.c (redisplay_window): Don't try to determine the character
11883 position of the scroll margin if the window start point w->startp
e896f03c 11884 is outside the buffer's accessible region. (Bug#8468)
11997c76 11885
8a2cbd72
EZ
118862011-04-10 Eli Zaretskii <eliz@gnu.org>
11887
11888 Fix write-region and its subroutines for buffers > 2GB.
11889 * fileio.c (a_write, e_write): Modify declaration of arguments and
11890 local variables to support buffers larger than 2GB.
11891 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11892
11893 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11894 argument, local variables, and return value.
11895
11896 * lisp.h: Update prototypes of emacs_write and emacs_read.
11897
11898 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11899
4073e537 119002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11901
1ebfdcb6
PE
11902 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11903
b2ded58d
PE
11904 Fix more problems found by GCC 4.6.0's static checks.
11905
7d66342c
PE
11906 * xdisp.c (vmessage): Use a better test for character truncation.
11907
bbf47d44
PE
11908 * charset.c (load_charset_map): <, not <=, for optimization,
11909 and to avoid potential problems with integer overflow.
9248994d 11910 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11911 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11912 * editfns.c (Fformat): Likewise.
1e69125e 11913 * syntax.c (skip_chars): Likewise.
3befa583 11914
e3019616
PE
11915 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11916 This also lets GCC 4.6.0 generate slightly better loop code.
11917
becfa255
PE
11918 * callint.c (Fcall_interactively): <, not <=, for optimization.
11919 (Fcall_interactively): Count the number of arguments produced,
11920 not the number of arguments given. This is simpler and lets GCC
11921 4.6.0 generate slightly better code.
11922
dae0cd48
PE
11923 * ftfont.c: Distingish more carefully between FcChar8 and char.
11924 The previous code passed unsigned char * to a functions like
11925 strlen and xstrcasecmp that expect char *, which does not
11926 conform to the C standard.
11927 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11928 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11929 char * when the C standard requires it.
11930
76032d70
PE
11931 * keyboard.c (read_char): Remove unused var.
11932
eb3f1cc8
PE
11933 * eval.c: Port to Windows vsnprintf (Bug#8435).
11934 Include <limits.h>.
11935 (SIZE_MAX): Define if the headers do not.
11936 (verror): Do not give up if vsnprintf returns a negative count.
11937 Instead, grow the buffer. This ports to Windows vsnprintf, which
11938 does not conform to C99. Problem reported by Eli Zaretskii.
11939 Also, simplify the allocation scheme, by avoiding the need for
11940 calling realloc, and removing the ALLOCATED variable.
11941
70476b54
PE
11942 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11943
12020a9e
PE
11944 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11945 But keep the doprint source code for now, as we might revamp it
11946 and use it again (Bug#8435).
ea6c7ae6
PE
11947 * lisp.h (doprnt): Remove.
11948 * Makefile.in (base_obj): Remove doprnt.o.
11949 * deps.mk (doprnt.o): Remove.
11950
5fdb398c
PE
11951 error: Print 32- and 64-bit integers portably (Bug#8435).
11952 Without this change, on typical 64-bit hosts error ("...%d...", N)
11953 was used to print both 32- and 64-bit integers N, which relied on
11954 undefined behavior.
61bdb816 11955 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11956 * lisp.h (error, verror): Mark as printf-like functions.
11957 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11958 Report overflow in size calculations when allocating printf buffer.
11959 Do not truncate output string at its first null byte.
11960 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11961 Truncate the output at a character boundary, since vsnprintf does not
11962 do that.
11963 * charset.c (check_iso_charset_parameter): Convert internal
11964 character to string before calling 'error', since %c now has the
11965 printf meaning.
11966 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11967 overflow when computing char to be passed to 'error'. Do not
11968 pass Lisp_Object to 'error'; pass the integer instead.
11969 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11970 formatted with plain %d.
11971
b189fa66
PE
11972 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11973
bff87ef0
PE
11974 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11975
7e2cac20
PE
11976 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11977
ce4d90b5
PE
11978 * xterm.c (x_catch_errors): Remove duplicate declaration.
11979
266c9547
PE
11980 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11981
79c49ad2
PE
11982 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11983
368f4090
JM
119842011-04-10 Jim Meyering <meyering@redhat.com>
11985
11986 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11987 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11988 return ssize_t not "int", and use size_t as the buffer length.
11989 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11990 * gnutls.h: Update declarations.
11991 * process.c (read_process_output): Use ssize_t, to match.
11992 (send_process): Likewise.
11993
a32d4040
CY
119942011-04-09 Chong Yidong <cyd@stupidchicken.com>
11995
11996 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11997
8546720e 119982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11999
04f2d78b
CB
12000 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12001 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12002
8546720e
GM
12003 * xterm.c (handle_one_xevent):
12004 * xmenu.c (create_and_show_popup_menu):
12005 * xselect.c (x_decline_selection_request)
12006 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12007
0a2f5c1a 120082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12009
12010 Fix some uses of `int' instead of EMACS_INT.
12011 * search.c (string_match_1, fast_string_match)
12012 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12013 (scan_buffer, find_next_newline_no_quit)
12014 (find_before_next_newline, search_command, Freplace_match)
12015 (Fmatch_data): Make some `int' variables be EMACS_INT.
12016
12017 * xdisp.c (display_count_lines): 3rd argument and return value now
12018 EMACS_INT. All callers changed.
12019 (pint2hrstr): Last argument is now EMACS_INT.
12020
12021 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12022 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12023 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12024 (decode_coding_utf_16, decode_coding_emacs_mule)
12025 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12026 (decode_coding_ccl, decode_coding_charset)
12027 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12028 (decode_coding_iso_2022, decode_coding_emacs_mule)
12029 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12030 <char_offset, last_offset>: Declare EMACS_INT.
12031 (encode_coding_utf_8, encode_coding_utf_16)
12032 (encode_coding_emacs_mule, encode_invocation_designation)
12033 (encode_designation_at_bol, encode_coding_iso_2022)
12034 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12035 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12036 Declare EMACS_INT.
12037 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12038 (encode_invocation_designation): Last argument P_NCHARS is now
12039 EMACS_INT.
12040 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12041 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12042
12043 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12044 All users changed.
12045
12046 * ccl.c (Fccl_execute_on_string): Declare some variables
12047 EMACS_INT.
12048
8546720e 120492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12050
12051 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12052
4e19a977
CS
120532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12054
12055 * process.c (Fformat_network_address): Doc fix.
12056
87302331
R
120572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12058
ee7683eb 12059 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12060
cbb59342
CY
120612011-04-08 Chong Yidong <cyd@stupidchicken.com>
12062
12063 * keyboard.c (read_char): Call Lisp function help-form-show,
12064 instead of using internal_with_output_to_temp_buffer.
12065 (Qhelp_form_show): New var.
e0d38eeb 12066 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12067
12068 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12069
12070 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12071
e67a13ab
CY
120722011-04-06 Chong Yidong <cyd@stupidchicken.com>
12073
04f2d78b
CB
12074 * process.c (Flist_processes): Remove to Lisp.
12075 (list_processes_1): Delete.
e67a13ab 12076
973f782d
EZ
120772011-04-06 Eli Zaretskii <eliz@gnu.org>
12078
7c106b1e
EZ
12079 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12080
973f782d
EZ
12081 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12082
41cf7d1a 120832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12084
ca23cc88
PE
12085 Fix more problems found by GCC 4.6.0's static checks.
12086
f390e2d5
PE
12087 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12088
42eea0d0
PE
12089 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12090
b69769da 12091 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12092
f9541e84
PE
12093 * xdisp.c (vmessage): Mark as a printf-like function.
12094
13841b55
PE
12095 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12096
c136c10f
PE
12097 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12098
5e2d4a30
PE
12099 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12100 printf-like functions.
12101 (tiff_load): Add casts to remove these marks before passing them
12102 to system-supplied API.
12103
583f48b9
PE
12104 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12105
b25d760e
PE
12106 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12107 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12108 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12109 directly, rather than having caller test rule sign. This avoids
12110 some unnecessary tests.
12111 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12112 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12113 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12114
bc7b6697 12115 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12116 (xfont_open): Avoid unnecessary tests.
bc7b6697 12117
27ccc379
PE
12118 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12119
dcd5c89a
PE
12120 * composite.h, composite.c (composition_gstring_put_cache):
12121 Use EMACS_INT, not int, for length.
12122
b13a45c6
PE
12123 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12124 breaking out part of COMPOSITION_DECODE_RULE.
12125 (COMPOSITION_DECODE_RULE): Use it.
12126 * composite.c (get_composition_id): Remove unused local vars,
12127 by using the new macro.
12128
1e792e4d
PE
12129 * textprop.c (set_text_properties_1): Change while to do-while,
12130 since the condition is always true at first.
12131
dc6c6455 12132 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12133 (interval_deletion_adjustment): Return unsigned value.
12134 All uses changed.
dc6c6455 12135
aba7731a
PE
12136 * process.c (list_processes_1, create_pty, read_process_output):
12137 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12138 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12139 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12140 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12141 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12142
fdfc4bf3
PE
12143 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12144
fca8fe46 12145 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12146 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12147
06a0259a 12148 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12149 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12150 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12151
e7b9e80f
PE
12152 * print.c (print_error_message): Avoid int overflow.
12153
56201685
PE
12154 * font.c (font_list_entities): Redo for clarity,
12155 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12156
78834453 12157 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12158 (font_score): Avoid potential overflow in diff calculation.
78834453 12159
0bc0b309 12160 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12161 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12162
e610eaca
PE
12163 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12164
b895abce
PE
12165 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12166 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12167 can always succeed if overflow has undefined behavior.
12168
1f1d9321 12169 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12170 (wordify): Omit three unnecessary tests.
1f1d9321 12171
c59478bc
PE
12172 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12173 All callers changed. This avoids the need for an unused var.
12174
79b73827
PE
12175 * casefiddle.c (casify_region): Remove var that is set but not used.
12176
a4db5dfe
PE
12177 * dired.c (file_name_completion): Remove var that is set but not used.
12178
43aae36e
PE
12179 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12180
2a47c44d 12181 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12182 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12183
a37c69bf
PE
12184 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12185 Check for integer overflow on size calculations.
12186
328ab8e7
PE
12187 * buffer.c (Fprevious_overlay_change): Remove var that is set
12188 but not used.
12189
e5a2a5cb
PE
12190 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12191 Remove vars that are set but not used.
8d84a6eb 12192 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12193 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12194
a60e5f68
PE
12195 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12196
f661cb61 12197 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12198 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12199
f0397f5a
PE
12200 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12201 that are set but not used.
12202
8664db06 12203 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12204 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12205
6abdaa4a
PE
12206 * xselect.c (x_get_local_selection, x_handle_property_notify):
12207 Remove vars that are set but not used.
12208
0ce7538d 12209 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12210 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12211
9ae848fc
PE
12212 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12213 Remove var that is set but not used.
0b918413
PE
12214 (scroll_bar_windows_size): Now size_t, not int.
12215 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12216 Check for overflow.
9ae848fc 12217
a5a62657
PE
12218 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12219 (map_tty_color) [!defined MSDOS]: Likewise.
12220
5c5cdd39
PE
12221 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12222
66ebf983
PE
12223 * coding.c: Remove vars that are set but not used.
12224 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12225 All callers changed.
12226 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12227 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12228 (decode_coding_charset): Remove vars that are set but not used.
12229
1be4d761
PE
12230 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12231 that is set but not used.
12232
47553fa8
PE
12233 * print.c (print_object): Remove var that is set but not used.
12234
1f7196bf 12235 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12236 The gnulib version avoids calling malloc in the usual case,
12237 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12238 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12239 * filelock.c (current_lock_owner): Likewise.
12240 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12241 * sysdep.c: Include allocator.h, careadlinkat.h.
12242 (emacs_no_realloc_allocator): New static constant.
12243 (emacs_readlink): New function.
fdb61804
PE
12244 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12245 ../lib/careadlinkat.h.
d1fdcab7 12246
f84c17c7
SM
122472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12248
12249 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12250 first non-nil return value).
12251
ef3862ad
JD
122522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12253
12254 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12255 if not defined (Bug#8403).
12256
376a7006
JB
122572011-04-02 Juanma Barranquero <lekktu@gmail.com>
12258
12259 * xdisp.c (display_count_lines): Remove parameter `start',
12260 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12261 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12262 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12263 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12264 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12265 and thereabouts. All callers changed.
12266 (get_per_char_metric): Remove parameter `f', unused since
12267 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12268
6ca3801d
JM
122692011-04-02 Jim Meyering <meyering@redhat.com>
12270
12271 do not dereference NULL upon failed strdup
12272 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12273 (ns_get_family): Likewise.
12274
d8e2b5ba
JB
122752011-04-02 Juanma Barranquero <lekktu@gmail.com>
12276
12277 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12278
8c74fcbd
JD
122792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12280
12281 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12282 later (Bug#8403).
12283
7200d79c
SM
122842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12285
03408648 12286 Add lexical binding.
7200d79c 12287
03408648
SM
12288 * window.c (Ftemp_output_buffer_show): New fun.
12289 (Fsave_window_excursion):
12290 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12291
12292 * lread.c (lisp_file_lexically_bound_p): New function.
12293 (Fload): Bind Qlexical_binding.
12294 (readevalloop): Remove `evalfun' arg.
12295 Bind Qinternal_interpreter_environment.
12296 (Feval_buffer): Bind Qlexical_binding.
12297 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12298 Mark as dynamic.
12299 (syms_of_lread): Declare `lexical-binding'.
12300
12301 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12302
12303 * keyboard.c (eval_dyn): New fun.
12304 (menu_item_eval_property): Use it.
ca105506
SM
12305
12306 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12307
03408648
SM
12308 * fns.c (concat, mapcar1): Accept byte-code-functions.
12309
12310 * eval.c (Fsetq): Handle lexical vars.
12311 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12312 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12313 (FletX, Flet): Obey lexical binding.
12314 (Fcommandp): Handle closures.
12315 (Feval): New `lexical' arg.
12316 (eval_sub): New function extracted from Feval. Use it almost
12317 everywhere where Feval was used. Look up vars in lexical env.
12318 Handle closures.
12319 (Ffunctionp): Move from subr.el.
12320 (Ffuncall): Handle closures.
12321 (apply_lambda): Remove `eval_flags'.
12322 (funcall_lambda): Handle closures and new byte-code-functions.
12323 (Fspecial_variable_p): New function.
12324 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12325 but without exporting it to Lisp.
23aba0ea 12326
23aba0ea 12327 * doc.c (Fdocumentation, store_function_docstring):
03408648 12328 * data.c (Finteractive_form): Handle closures.
23aba0ea 12329
03408648
SM
12330 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12331 interactive spec.
ba83908c 12332
04f2d78b
CB
12333 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12334 New byte-codes.
03408648
SM
12335 (exec_byte_code): New function extracted from Fbyte_code to handle new
12336 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12337
03408648 12338 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12339
03408648 12340 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12341
e2abce01
JB
123422011-03-31 Juanma Barranquero <lekktu@gmail.com>
12343
12344 * xdisp.c (redisplay_internal): Fix prototype.
12345
63696a73 123462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12347
63696a73 12348 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12349 (try_scrolling): Use it when setting scroll_limit.
12350 Limit scrolling to 100 screen lines.
63696a73
EZ
12351 (redisplay_window): Even when falling back on "recentering",
12352 position point in the window according to scroll-conservatively,
12353 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12354
12355 (try_scrolling): When point is above the window, allow searching
12356 as far as scroll_max, or one screenful, to compute vertical
12357 distance from PT to the scroll margin position. This prevents
12358 try_scrolling from unnecessarily failing when
12359 scroll-conservatively is set to a value slightly larger than the
12360 window height. Clean up the case of PT below the margin at bottom
12361 of window: scroll_max can no longer be INT_MAX. When aggressive
12362 scrolling is in use, don't let point enter the opposite scroll
12363 margin as result of the scroll.
12364 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12365 threshold of 100 lines for never-recentering scrolling.
12366
e4cc2dfc
JB
123672011-03-31 Juanma Barranquero <lekktu@gmail.com>
12368
12369 * dispextern.h (move_it_by_lines):
12370 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12371 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12372 (message_log_check_duplicate): Remove parameters `prev_bol' and
12373 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12374 (redisplay_internal): Remove parameter `preserve_echo_area',
12375 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12376
12377 * indent.c (Fvertical_motion):
12378 * window.c (window_scroll_pixel_based, Frecenter):
12379 Don't pass `need_y_p' to `move_it_by_lines'.
12380
1c470562
SM
123812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12382
44f230aa
SM
12383 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12384 steal a few bits to be more compact.
12385 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12386 Remove unneeded casts.
12387
1c470562
SM
12388 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12389
888adce9
ZK
123902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12391
12392 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12393 binding" message (bug#7967).
12394
f838ed7b
PE
123952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12396
77861b95
PE
12397 Fix more problems found by GCC 4.6.0's static checks.
12398
de6dbc14
PE
12399 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12400 Remove unused local var.
12401
f838ed7b
PE
12402 * editfns.c (Fmessage_box): Remove unused local var.
12403
792c7b2b
PE
12404 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12405 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12406 Omit unused local vars.
c499e557 12407 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12408 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12409 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12410 Omit unused local var.
12411
ba0165e1
PE
12412 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12413 Don't assume string length fits in int.
32ad8845 12414 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12415 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12416
3c59b4c9
PE
12417 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12418 instead of alloca (Bug#8344).
12419
a3eed478 12420 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12421 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12422
eb4d412d
PE
12423 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12424
1658b401
PE
12425 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12426 concerns.
12427
12428 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12429
12430 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12431
9a2c6e05
PE
12432 * keyboard.c (syms_of_keyboard): Use the same style as later
12433 in this function when indexing through an array. This also
12434 works around GCC bug 48267.
12435
03d0a109
PE
12436 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12437
44f730c8
PE
12438 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12439
fe75f926
PE
12440 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12441 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12442
ffa8c828
PE
12443 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12444 This avoids undefined behavior on integer overflow, and is a bit
12445 more convenient anyway since it is compared to a size_t variable.
12446
c5101a77
PE
12447 Variadic C functions now count arguments with size_t, not int.
12448 This avoids an unnecessary limitation on 64-bit machines, which
12449 caused (substring ...) to crash on large vectors (Bug#8344).
12450 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12451 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12452 All variadic functions and their callers changed accordingly.
c5101a77
PE
12453 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12454 * data.c (arith_driver, float_arith_driver): Likewise.
12455 * editfns.c (general_insert_function): Likewise.
12456 * eval.c (struct backtrace.nargs, interactive_p)
12457 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12458 (funcall_lambda, mark_backtrace): Likewise.
12459 * fns.c (concat): Likewise.
12460 * frame.c (x_set_frame_parameters): Likewise.
12461 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12462 0 if not found, not -1. All callers changed.
12463
dd3f25f7
PE
12464 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12465 (stack_copy_size): Now size_t, not int.
12466 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12467
461c2ab9
JB
124682011-03-28 Juanma Barranquero <lekktu@gmail.com>
12469
12470 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12471 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12472 All callers changed.
12473
12474 * lisp.h (multibyte_char_to_unibyte):
12475 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12476 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12477 * character.h (CHAR_TO_BYTE8):
12478 * cmds.c (internal_self_insert):
12479 * editfns.c (general_insert_function):
12480 * keymap.c (push_key_description):
12481 * search.c (Freplace_match):
12482 * xdisp.c (message_dolog, set_message_1): All callers changed.
12483
f6d62986
SM
124842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12485
12486 * keyboard.c (safe_run_hook_funcall): New function.
12487 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12488 don't set the hook to nil, but remove the offending function instead.
12489 (Qcommand_hook_internal): Remove, unused.
12490 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12491 Vcommand_hook_internal.
12492
12493 * eval.c (enum run_hooks_condition): Remove.
12494 (funcall_nil, funcall_not): New functions.
12495 (run_hook_with_args): Call each function through a `funcall' argument.
12496 Remove `cond' argument, now redundant.
12497 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12498 (Frun_hook_with_args_until_failure): Adjust accordingly.
12499 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12500
1db5b1ad
JB
125012011-03-28 Juanma Barranquero <lekktu@gmail.com>
12502
12503 * dispextern.h (string_buffer_position): Remove declaration.
12504
12505 * print.c (strout): Remove parameter `multibyte', unused since
12506 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12507
12508 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12509 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12510 All callers changed.
12511
12512 * w32.c (_wsa_errlist): Use braces for struct initializers.
12513
12514 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12515 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12516 All callers changed.
12517 (string_buffer_position): Likewise. Also, make static (it's never
12518 used outside xdisp.c).
12519 (cursor_row_p): Remove parameter `w', unused since
12520 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12521 (decode_mode_spec): Remove parameter `precision', introduced during
12522 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12523 All callers changed.
12524
5ffb62aa
JD
125252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12526
12527 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12528
461c2ab9 125292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12530
12531 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12532 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12533 (ns_update_auto_hide_menu_bar): New functions.
12534 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12535 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12536 ns_constrain_all_frames.
12537 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12538 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12539
5c380ffb
JD
125402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12541
12542 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12543
9af30bdf
GM
125442011-03-27 Glenn Morris <rgm@gnu.org>
12545
12546 * syssignal.h: Replace RETSIGTYPE with void.
12547 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12548 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12549 Replace SIGTYPE with void everywhere.
12550 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12551 * s/template.h (SIGTYPE): Remove commented out definition.
12552
e2abce01
JB
125532011-03-26 Eli Zaretskii <eliz@gnu.org>
12554
12555 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12556 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12557
f868cd8a
JB
125582011-03-26 Juanma Barranquero <lekktu@gmail.com>
12559
59eb0929
JB
12560 * w32.c (read_unc_volume): Use parameter `henum', instead of
12561 global variable `wget_enum_handle'.
12562
12563 * keymap.c (describe_vector): Remove parameters `indices' and
12564 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12565 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12566
f868cd8a
JB
12567 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12568
12569 * keyboard.c (timer_check): Remove parameter `do_it_now',
12570 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12571 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12572 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12573
12574 * keyboard.c (read_char):
12575 * w32menu.c (w32_menu_display_help):
12576 * xmenu.c (show_help_event, menu_help_callback):
12577 Adjust calls to `show_help_echo'.
12578
12579 * gtkutil.c (xg_maybe_add_timer):
12580 * keyboard.c (readable_events):
12581 * process.c (wait_reading_process_output):
12582 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12583
12584 * insdel.c (adjust_markers_gap_motion):
12585 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12586 (gap_left, gap_right): Don't call it.
12587
2ecf6fdb
CY
125882011-03-25 Chong Yidong <cyd@stupidchicken.com>
12589
12590 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12591 incurred during fontification.
12592
6b1f9ba4
JB
125932011-03-25 Juanma Barranquero <lekktu@gmail.com>
12594
12595 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12596 (DEFVAR_PER_BUFFER): Don't pass it.
12597
12598 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12599 (scrolling_window): Don't pass it.
12600
0f4a96b5
JB
126012011-03-25 Juanma Barranquero <lekktu@gmail.com>
12602
12603 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12604
12605 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12606 and `suffix'.
12607 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12608 of variables specific to SELinux and computation of `encoded_absname'.
12609
12610 * image.c (XPutPixel): Remove unused variable `height'.
12611
12612 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12613
12614 * unexw32.c (get_section_info): Remove unused variable `section'.
12615
12616 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12617 (system_process_attributes): Remove unused variable `sess'.
12618 (sys_read): Remove unused variable `err'.
12619
12620 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12621 (w32_wnd_proc): Remove unused variable `isdead'.
12622 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12623 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12624 (x_create_tip_frame): Remove unused variable `tem'.
12625
12626 * w32inevt.c (w32_console_read_socket):
12627 Remove unused variable `no_events'.
12628
12629 * w32term.c (x_draw_composite_glyph_string_foreground):
12630 Remove unused variable `width'.
12631
1149507c
JB
126322011-03-24 Juanma Barranquero <lekktu@gmail.com>
12633
12634 * w32term.c (x_set_glyph_string_clipping):
12635 Don't pass uninitialized region to CombineRgn.
12636
9c88f339
JB
126372011-03-23 Juanma Barranquero <lekktu@gmail.com>
12638
12639 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12640 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12641 (Fx_close_connection): Remove unused variable `i'.
12642
12643 * w32font.c (w32font_draw): Return number of glyphs.
12644 (w32font_open_internal): Remove unused variable `i'.
12645 (w32font_driver): Add missing initializer.
12646
12647 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12648 (fill_in_menu): Remove unused variable `items_added'.
12649
12650 * w32term.c (last_mouse_press_frame): Remove static global variable.
12651 (w32_clip_to_row): Remove unused variable `f'.
12652 (x_delete_terminal): Remove unused variable `i'.
12653
12654 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12655 (NOTHING): Remove unused static global variable.
12656 (uniscribe_check_otf): Remove unused variable `table'.
12657 (uniscribe_font_driver): Add missing initializers.
12658
dee091a3
JD
126592011-03-23 Julien Danjou <julien@danjou.info>
12660
12661 * term.c (Fsuspend_tty, Fresume_tty):
12662 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12663 * window.c (temp_output_buffer_show):
12664 * insdel.c (signal_before_change):
12665 * frame.c (Fhandle_switch_frame):
12666 * fileio.c (Fdo_auto_save):
12667 * emacs.c (Fkill_emacs):
12668 * editfns.c (save_excursion_restore):
12669 * cmds.c (internal_self_insert):
12670 * callint.c (Fcall_interactively):
12671 * buffer.c (Fkill_all_local_variables):
12672 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12673 Use Frun_hooks.
0f4a96b5 12674 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12675 unconditionally since it does the check itself.
dee091a3 12676
2c520ab5 126772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12678
c9c49752
PE
12679 Fix more problems found by GCC 4.5.2's static checks.
12680
8abc3f12
PE
12681 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12682 the first time through the loop, since we know p0 < p1 then.
12683 This also avoids a gcc -Wstrict-overflow warning.
12684
a2d26660
PE
12685 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12686 leading to a memory leak, possible in functions like
12687 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12688 of objects (Bug#8318).
a2d26660 12689
916c72e9
PE
12690 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12691 that could (at least in theory) be that large.
12692
19ab8a18
PE
12693 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12694 This is less likely to overflow, and avoids undefined behavior if
12695 overflow does occur. All callers changed. Use strtoul to scan
12696 for the unsigned long integer.
b7cbbd6f
PE
12697 (pint2hrstr): Simplify and tune code slightly.
12698 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12699
f0641eff
PE
12700 * scroll.c (do_scrolling): Work around GCC bug 48228.
12701 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12702
7f650bb9
PE
12703 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12704 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12705 (validate_x_resource_name): Simplify count usage.
12706 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12707
37dd57d1
PE
12708 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12709 fail (Bug#8306).
81e56e61 12710
699979fc 12711 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12712
401bf9b4
PE
12713 * process.c (Fmake_network_process): Use socklen_t, not int,
12714 where POSIX says socklen_t is required in portable programs.
12715 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12716 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12717 (Fmake_network_process, server_accept_connection):
12718 (wait_reading_process_output, read_process_output):
12719 Likewise.
12720
b93aacde
PE
12721 * process.c: Rename or move locals to avoid shadowing.
12722 (list_processes_1, Fmake_network_process):
12723 (read_process_output_error_handler, exec_sentinel_error_handler):
12724 Rename or move locals.
4dc343ee 12725 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12726 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12727 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12728 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12729 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12730
af8a867c 12731 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12732 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12733 Include tparam.h instead, since it declares them.
af8a867c
PE
12734 * cm.h (PC): Remove extern decl; tparam.h now does this.
12735 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12736 * terminfo.c: Include tparam.h, to check interfaces.
12737 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12738 (tparam): Adjust signature to match interface in tparam.h;
12739 this removes some undefined behavior. Check that outstring and len
12740 are zero, which they always are with Emacs.
12741 * tparam.h (PC, BC, UP): New extern decls.
12742
0248044d 12743 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12744 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12745
8ff096c1 12746 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12747 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12748 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12749 (ftfont_list): Remove unused local.
49eaafba
PE
12750 (get_adstyle_property, ftfont_pattern_entity):
12751 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12752 Rename locals to avoid shadowing.
8ff096c1 12753
e2be39f6
PE
12754 * xfont.c (xfont_list_family): Mark var as initialized.
12755
c9735e30
PE
12756 * xml.c (make_dom): Now static.
12757
8f5201ae
PE
12758 * composite.c (composition_compute_stop_pos): Rename local to
12759 avoid shadowing.
b246f932
PE
12760 (composition_reseat_it): Remove unused locals.
12761 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12762 (composition_update_it): Mark var as initialized.
11b61122
PE
12763 (find_automatic_composition): Mark vars as initialized,
12764 with a FIXME (Bug#8290).
8f5201ae 12765
760fbc2c
PE
12766 character.h: Rename locals to avoid shadowing.
12767 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12768 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12769 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12770 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12771 to avoid shadowing.
12772
ff08eb85
PE
12773 * textprop.c (property_change_between_p): Remove; unused.
12774
fc7bf025
PE
12775 * intervals.c (interval_start_pos): Now static.
12776
235d7abc
PE
12777 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12778
44f230aa
SM
12779 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12780 Rename locals to avoid shadowing.
3e7d6594 12781
50060332
PE
12782 * sound.c (wav_play, au_play, Fplay_sound_internal):
12783 Fix pointer signedness.
d01f234b 12784 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12785 (wav_play): Initialize a variable to 0, to prevent undefined
12786 behavior (Bug#8278).
50060332 12787
c4fc4e30
PE
12788 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12789
918436ed
PE
12790 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12791
c939f91b
PE
12792 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12793 clobbering (Bug#8298).
b9c7f648
PE
12794 * sysdep.c (sys_subshell): Likewise.
12795 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12796
6bd8c144
PE
12797 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12798 This should get cleaned up, so that child_setup has the
12799 same signature on all platforms.
12800
7710357c 12801 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12802 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12803
c59da222
CY
128042011-03-22 Chong Yidong <cyd@stupidchicken.com>
12805
12806 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12807 not to be necessary, and produces flickering.
12808
66b87493
GM
128092011-03-20 Glenn Morris <rgm@gnu.org>
12810
12811 * config.in: Remove file.
12812
45b6f6d5
JB
128132011-03-20 Juanma Barranquero <lekktu@gmail.com>
12814
12815 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12816 are now in src/globals.h.
12817 (syms_of_minibuf): Remove spurious & from previous change.
12818
cd394be1 128192011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12820
12821 * minibuf.c (completing-read-function): New variable.
12822 (completing-read-default): Rename from completing-read.
12823 (completing-read): Call completing-read-function.
12824
b14e3e21
CY
128252011-03-19 Juanma Barranquero <lekktu@gmail.com>
12826
12827 * xfaces.c (Fx_load_color_file):
12828 Read color file from absolute filename (bug#8250).
12829
f2b726e6
JB
128302011-03-19 Juanma Barranquero <lekktu@gmail.com>
12831
12832 * makefile.w32-in: Update dependencies.
12833
09f6ff02
EZ
128342011-03-17 Eli Zaretskii <eliz@gnu.org>
12835
12836 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12837
29a6015a
PE
128382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12839
a3a6c54e
PE
12840 Fix more problems found by GCC 4.5.2's static checks.
12841
b766f867
PE
12842 * process.c (make_serial_process_unwind, send_process_trap):
12843 (sigchld_handler): Now static.
12844
be02381c
PE
12845 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12846 That way, the code declares only the vars that it needs.
12847 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12848 * s/cygwin.h (PTY_ITERATION): Likewise.
12849 * s/darwin.h (PTY_ITERATION): Likewise.
12850 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12851
57048744
PE
12852 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12853 * process.c (allocate_pty): Don't declare stb unless it's needed.
12854
7914961c 12855 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12856 (CONSTANTLIM): Remove; unused.
12857 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12858 Define only if needed.
7914961c 12859
b3967b18
PE
12860 * unexelf.c (unexec): Name an expression,
12861 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12862 Use a different way to cause a compilation error if anyone uses
12863 n rather than nn, a way that does not involve shadowing.
73366a00 12864 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12865
29a6015a
PE
12866 * deps.mk (unexalpha.o): Remove; unused.
12867
43cfc33e 12868 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12869 * unexec.h: New file.
ce701a33
PE
12870 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12871 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12872 Depend on unexec.h.
12873 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12874 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12875 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12876 Change as necessary to match prototype in unexec.h.
ce701a33 12877
01f44d5a
PE
12878 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12879 shadowing.
4f63c6bb 12880 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12881
a6670b0b
PE
12882 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12883 Rename locals to avoid shadowing.
12884
cef2010d 12885 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12886 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12887
d4d7173a
PE
12888 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12889
f08b802a
PE
12890 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12891 warning when compiling print.c.
12892
3ddb0639
PE
12893 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12894 instead of using an uninitialized var.
5ad03b97 12895 (font_sort_entities): Mark var as initialized.
3ddb0639 12896
170a2692
PE
12897 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12898
e663c700
PE
12899 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12900 pointers to constants.
89bc529a 12901 (font_parse_fcname): Remove unused vars.
7b81e2d0 12902 (font_delete_unmatched): Now static.
ea838e10 12903 (font_get_spec): Remove; unused.
13a547c6
PE
12904 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12905 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12906 Rename or move locals to avoid shadowing.
e663c700 12907
2a80c887 12908 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12909 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12910
1384fa33 12911 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12912 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12913
8b2c52e9
PE
12914 * alloc.c (mark_backtrace): Move decl from here ...
12915 * lisp.h: ... to here, so that it can be checked.
12916
475545b5 12917 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12918 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12919 (lisp_indirect_variable): Name an expression,
12920 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12921 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12922
b1349114 12923 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12924 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12925 Use const pointer when appropriate.
b1349114 12926
a2928364
PE
12927 * lisp.h (get_system_name, get_operating_system_release):
12928 Move decls here, to check interfaces.
12929 * process.c (get_operating_system_release): Move decl to lisp.h.
12930 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12931 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12932 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12933 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12934 (Fformat_time_string, Fencode_time, Finsert_char):
12935 (Ftranslate_region_internal, Fformat):
12936 Rename or remove local vars to avoid shadowing.
9710023e 12937 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12938
a415e694
PE
12939 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12940 avoid shadowing.
12941
8ef4622d
PE
12942 * lisp.h (eassert): Check that the argument compiles, even if
12943 ENABLE_CHECKING is not defined.
12944
946f9a5b
PE
12945 * data.c (Findirect_variable): Name an expression, to avoid
12946 gcc -Wbad-function-cast warning.
112396d6 12947 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12948 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12949 (Fmake_variable_buffer_local, Fmake_local_variable):
12950 Mark variables as initialized.
52746918 12951 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12952
e5aab7e7 12953 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12954 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12955 Rename locals to avoid shadowing.
dff45157
PE
12956 (mark_stack): Move local variables into the #ifdef region where
12957 they're used.
7bc26fdb
PE
12958 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12959 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12960 needed otherwise.
12961 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12962 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12963 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12964
e5aab7e7
PE
12965 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12966 avoids undefined behavior in theory.
12967
4da60324
PE
12968 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12969
88043301
PE
12970 Use functions, not macros, for up- and down-casing (Bug#8254).
12971 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12972 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12973 to use the following functions instead of these macros.
12974 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12975 EMACS_INT, since callers assume the returned value fits in int.
12976 (upcase1): Likewise, for UPCASE_TABLE.
12977 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12978 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12979 the race-condition problem in the old DOWNCASE.
88043301 12980
19ed5445
PE
12981 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12982 Rename locals to avoid shadowing.
12983 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12984 (regex_compile, re_search_2, re_match_2_internal):
12985 Remove unused local vars.
952db0d7
PE
12986 (FREE_VAR): Rewrite so as not to use empty "else",
12987 which gcc can warn about.
da053e48 12988 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12989 (RETALLOC_IF): Define only if needed.
12990 (WORDCHAR_P): Likewise. This one is never needed, but is used
12991 only in a comment talking about a compiler bug, so put inside
12992 the #if 0 of that comment.
12993 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12994 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12995 Remove; unused.
19ed5445 12996
1f3561e4 12997 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12998 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12999 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13000
ded6f8f7
PE
13001 * search.c (simple_search): Remove unused var.
13002
dbd37a95
PE
13003 * dired.c (compile_pattern): Move decl from here ...
13004 * lisp.h: ... to here, so that it can be checked.
13005 (struct re_registers): New forward decl.
13006
7e47afad
PE
13007 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13008
85f24f61
PE
13009 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13010 All uses changed.
13011 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13012 Rename locals to avoid shadowing.
5671df8f 13013 (Fvertical_motion): Mark locals as initialized.
85f24f61 13014
181aa2be 13015 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13016 (casify_region): Mark local as initialized.
181aa2be 13017
930d429c
PE
13018 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13019
7082eac6
PE
13020 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13021 New macros, so that the caller can use some names other than
13022 gcpro1, gcpro2, etc.
13023 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13024 of the new macros.
13025 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13026 argument, for consistency with GCPRO2_VAR, etc: it is now the
13027 prefix of the variable, not the variable itself. All uses
13028 changed.
38b2c076
PE
13029 * dired.c (directory_files_internal, file_name_completion):
13030 Rename locals to avoid shadowing.
13031
15206ed9
PE
13032 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13033 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13034 dired.c's scmp function, had undefined behavior.
13035 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13036 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13037 * buffer.h: ... to here, because these macros use current_buffer,
13038 and the new implementation with inline functions needs to have
13039 current_buffer in scope now, rather than later when the macros
13040 are used.
13041 (downcase, upcase1): New static inline functions.
13042 (DOWNCASE, UPCASE1): Reimplement using these functions.
13043 This avoids undefined behavior in expressions like
13044 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13045 from race conditions in accessing the global variables
13046 case_temp1 and case_temp2.
13047 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13048 * lisp.h (case_temp1, case_temp2): Remove their decls.
13049 * character.h (ASCII_CHAR_P): Move from here ...
13050 * lisp.h: ... to here, so that the inline functions mentioned
13051 above can use them.
13052
4a6bea26
PE
13053 * dired.c (directory_files_internal_unwind): Now static.
13054
f14b7e14
PE
13055 * fileio.c (file_name_as_directory, directory_file_name):
13056 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13057 Now static.
2893f146
PE
13058 (file_name_as_directory): Use const pointers when appropriate.
13059 (Fexpand_file_name): Likewise. In particular, newdir might
13060 point at constant storage, so make it a const pointer.
fd4ead52 13061 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13062 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13063 signedness issues.
f839df0c
PE
13064 (Fset_file_times, Finsert_file_contents, auto_save_error):
13065 Rename locals to avoid shadowing.
f14b7e14 13066
5716756e 13067 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13068 (Ftry_completion, Fall_completions): Rename or remove locals
13069 to avoid shadowing.
5716756e 13070
b4c3046a
PE
13071 * marker.c (bytepos_to_charpos): Remove; unused.
13072
b45db522
PE
13073 * lisp.h (verify_bytepos, count_markers): New decls,
13074 so that gcc does not warn that these functions aren't declared.
13075
85876d07
PE
13076 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13077 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13078 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13079 (copy_text): Remove unused local var.
85876d07 13080
03d78a21 13081 * filelock.c (within_one_second): Now static.
b3dd38ab 13082 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13083
5df8f01b
PE
13084 * buffer.c (fix_overlays_before): Mark locals as initialized.
13085 (fix_start_end_in_overlays): Likewise. This function should be
13086 simplified by using pointers-to-pointers, but that's a different
13087 matter.
b1d876f1 13088 (switch_to_buffer_1): Now static.
8f54f30a
PE
13089 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13090 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13091
a70072c9 13092 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13093 Fix pointer signedness issue.
edced198
PE
13094 (sys_subshell): Mark local as volatile if checking for lint,
13095 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13096 (MAXPATHLEN): Define only if needed.
a70072c9 13097
a0977c44
PE
13098 * process.c (serial_open, serial_configure): Move decls from here ...
13099 * systty.h: ... to here, so that they can be checked.
13100
a884fdcc
PE
13101 * fns.c (get_random, seed_random): Move extern decls from here ...
13102 * lisp.h: ... to here, so that they can be checked.
13103
604efe86 13104 * sysdep.c (reset_io): Now static.
b8950c94 13105 (wait_for_termination_signal): Remove; unused.
604efe86 13106
38fc62d9
PE
13107 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13108 (copy_keymap_item, append_key, push_text_char_description):
13109 Now static.
1004a21a 13110 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13111 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13112 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13113 (describe_map_tree):
13114 Rename locals to avoid shadowing.
38fc62d9 13115
2f2650da
PE
13116 * keyboard.c: Declare functions static if they are not used elsewhere.
13117 (echo_char, echo_dash, cmd_error, top_level_2):
13118 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13119 (read_char, kbd_buffer_get_event, make_lispy_position):
13120 (make_lispy_event, make_lispy_movement, apply_modifiers):
13121 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13122 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13123 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13124 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13125 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13126
a053e86c 13127 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13128 (mark_kboards): Move decl here ...
13129 * alloc.c (mark_kboards): ... from here.
a053e86c 13130
4752793e
PE
13131 * lisp.h (force_auto_save_soon): New decl.
13132
74f10ca7 13133 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13134 (DEFINE_DUMMY_FUNCTION): New macro.
13135 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13136 Use it.
c03cd23f
PE
13137 (main): Add casts to avoid warnings
13138 if GCC considers string literals to be constants.
74f10ca7 13139
022e70d4
PE
13140 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13141
59d6fe83
PE
13142 * dbusbind.c: Pointer signedness fixes.
13143 (xd_signature, xd_append_arg, xd_initialize):
13144 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13145 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13146 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13147 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13148
78320123
PE
13149 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13150 if GCC considers string literals to be constants.
49cebcca 13151 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13152
35ac2a97
SM
131532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13154
fb103ca9
SM
13155 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13156 (print_preprocess, print_object): New macro to fix last change.
13157
35ac2a97
SM
13158 * print.c (print_preprocess): Don't forget font objects.
13159
62973b41
JB
131602011-03-16 Juanma Barranquero <lekktu@gmail.com>
13161
13162 * emacs.c (USAGE3): Doc fixes.
13163
0e48bb22
AS
131642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13165
13166 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13167 structure.
13168
7684e57b
JB
131692011-03-14 Juanma Barranquero <lekktu@gmail.com>
13170
13171 * lisp.h (VWindow_system, Qfile_name_history):
13172 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13173 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13174 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13175
13176 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13177 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13178
13179 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13180 * w32console.c (detect_input_pending, read_input_pending)
13181 (encode_terminal_code):
13182 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13183 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13184 (w32_system_caret_y, Qfile_name_history):
13185 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13186 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13187 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13188 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13189 * w32proc.c (Qlocal, report_file_error):
13190 * w32term.c (Vwindow_system, updating_frame):
13191 * w32uniscribe.c (initialized, uniscribe_font_driver):
13192 Remove unneeded extern declarations.
13193
2aa46d6c
CY
131942011-03-14 Chong Yidong <cyd@stupidchicken.com>
13195
c96bbc66 13196 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13197
cffc6f3b
CY
131982011-03-13 Chong Yidong <cyd@stupidchicken.com>
13199
13200 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13201 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13202 These macros can no longer be used for assignment.
13203
44f230aa
SM
13204 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13205 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13206 (record_buffer_markers, fetch_buffer_markers): New functions for
13207 recording and fetching special buffer markers.
13208 (set_buffer_internal_1, set_buffer_temp): Use them.
13209
13210 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13211
13212 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13213
13214 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13215 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13216
13217 * xdisp.c (hscroll_window_tree):
13218 (reconsider_clip_changes): Use PT instead of BUF_PT.
13219
d251f04b
EZ
132202011-03-13 Eli Zaretskii <eliz@gnu.org>
13221
13222 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13223 $(EMACS_ROOT)/lib/intprops.h.
13224
f0c77cd1
PE
132252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13226
3eca4629
PE
13227 Fix more problems found by GCC 4.5.2's static checks.
13228
7c86ee98
PE
13229 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13230 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13231 (xg_free_frame_widgets): Make it clear that a local variable is
13232 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13233 (gdk_window_get_screen): Make it clear that this macro is needed
13234 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13235 (int_gtk_range_get_value): New function, which avoids a diagnostic
13236 from gcc -Wbad-function-cast.
13237 (xg_set_toolkit_scroll_bar_thumb): Use it.
13238 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13239 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13240 (get_utf8_string, xg_get_file_with_chooser):
13241 Rename locals to avoid shadowing.
13242 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13243
41729b81
PE
13244 * xgselect.c (xg_select): Remove unused var.
13245
f0c77cd1
PE
13246 * image.c (four_corners_best): Mark locals as initialized.
13247 (gif_load): Initialize transparent_p to zero (Bug#8238).
13248 Mark another local as initialized.
ec6cf4c6 13249 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13250
ce0ad53d 13251 * image.c (clear_image_cache): Now static.
d5d5a617 13252 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13253 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13254 (x_edge_detection): Remove unnecessary cast that
13255 gcc -Wbad-function-cast diagnoses.
2037898d 13256 (gif_load): Fix pointer signedness.
6ae141d6
PE
13257 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13258 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13259
33383987 132602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13261
d32df629
PE
13262 Improve quality of tests for time stamp overflow.
13263 For example, without this patch (encode-time 0 0 0 1 1
13264 1152921504606846976) returns the obviously-bogus value (-948597
13265 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13266 reports time overflow. See
13267 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13268 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13269 * editfns.c: Include limits.h and intprops.h.
13270 (TIME_T_MIN, TIME_T_MAX): New macros.
13271 (time_overflow): Move earlier, to before first use.
13272 (hi_time, lo_time): New functions, for an accurate test for
13273 out-of-range times.
13274 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13275 (Fget_internal_run_time): Don't assume time_t fits in int.
13276 (make_time): Use list2 instead of Fcons twice.
13277 (Fdecode_time): More accurate test for out-of-range times.
13278 (check_tm_member): New function.
13279 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13280 (lisp_time_argument): Don't rely on undefined left-shift and
13281 right-shift behavior when checking for time stamp overflow.
8be6f318 13282
fe31d94c
PE
13283 * editfns.c (time_overflow): New function, refactoring common code.
13284 (Fformat_time_string, Fdecode_time, Fencode_time):
13285 (Fcurrent_time_string): Use it.
13286
8be6f318
PE
13287 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13288 * dired.c (make_time): Move to ...
13289 * editfns.c (make_time): ... here.
13290 * systime.h: Note the move.
13291
09d9db2c 132922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13293
126bc0dc
YM
13294 * fringe.c (update_window_fringes): Remove unused variables.
13295
c47cbdfd
YM
13296 * unexmacosx.c (copy_data_segment): Also copy __got section.
13297 (Bug#8223)
13298
7ac80be9
EZ
132992011-03-12 Eli Zaretskii <eliz@gnu.org>
13300
c96bbc66 13301 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13302 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13303 Constify `char *' arguments and their references according to
13304 prototypes in tparam.h.
13305
ecb0f94d 13306 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13307
7ac80be9
EZ
13308 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13309 Adapt all references accordingly.
13310
13311 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13312
ef1fd07e
TT
133132011-03-11 Tom Tromey <tromey@redhat.com>
13314
13315 * buffer.c (syms_of_buffer): Remove obsolete comment.
13316
7ef4b50c
EZ
133172011-03-11 Eli Zaretskii <eliz@gnu.org>
13318
13319 * termhooks.h (encode_terminal_code): Declare prototype.
13320
13321 * msdos.c (encode_terminal_code): Don't declare prototype.
13322
13323 * term.c (encode_terminal_code): Now external again, used by
13324 w32console.c and msdos.c.
13325
44f230aa
SM
13326 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13327 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13328
4b1ec863 133292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13330
1714f52b 13331 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13332
4b1ec863
PE
13333 * fringe.c (update_window_fringes): Mark locals as initialized
13334 (Bug#8227).
13335 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13336
524c7aa6
PE
13337 * alloc.c (mark_fringe_data): Move decl from here ...
13338 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13339 to check its interface.
13340 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13341
a5c0af81 13342 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13343 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13344 (fontset_font): Mark local as initialized.
a9a06e0b 13345 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13346
b4716021
PE
13347 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13348
811e9bac 13349 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13350 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13351 (x_own_selection, Fx_disown_selection_internal): Rename locals
13352 to avoid shadowing.
13353 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13354
7e3ab302
PE
13355 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13356 so that the caller can use some name other than gcpro1.
13357 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13358 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13359 (Fx_backspace_delete_keys_p):
13360 Use them to avoid shadowing, and rename vars to avoid shadowing.
13361 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13362 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13363 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13364 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13365 Remove unused locals.
7e3ab302
PE
13366 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13367 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13368 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13369 macros.
f78faa98 13370
e2b13473
PE
13371 * xterm.h (x_mouse_leave): New decl.
13372
77f23912
PE
13373 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13374 Remove unused functions.
cdf4ba58
PE
13375 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13376 (x_calc_absolute_position): Now static.
7411c686 13377 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13378 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13379 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13380 unless they are used.
38d0b34a
PE
13381 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13382 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13383 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13384 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13385 (x_error_catcher, x_connection_closed, x_error_handler):
13386 (x_error_quitter, xembed_send_message, x_iconify_frame):
13387 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13388 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13389 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13390
44f230aa
SM
13391 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13392 Rename or move locals to avoid shadowing.
6b463e58 13393 (tty_defined_color, merge_face_heights): Now static.
5967d051 13394 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13395 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13396 does not deduce is never used uninitialized.
73719eba
PE
13397 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13398 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13399
426994c3 13400 * terminal.c (store_terminal_param): Now static.
5489860b 13401
032f1620 13402 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13403 (set_frame_menubar): Remove unused local.
d4323972 13404 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13405 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13406 since they might point to immutable storage.
281585b0
PE
13407 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13408 since it's unused otherwise.
032f1620 13409
367c19e5 13410 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13411 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13412 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13413 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13414 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13415 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13416 does not deduce are never used uninitialized.
70739cbe 13417
07b48fa9
PE
13418 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13419
8868a238 13420 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13421 * window.c (window_loop, size_window):
13422 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13423
7e5cf297 13424 * window.c (display_buffer): Now static.
d6550a9f
PE
13425 (size_window): Mark variables that gcc -Wuninitialized
13426 does not deduce are never used uninitialized.
a586633d
PE
13427 * window.h (check_all_windows): New decl, to forestall
13428 gcc -Wmissing-prototypes diagnostic.
5b555da1 13429 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13430
f6095868
PE
13431 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13432 shadowing.
13433 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13434 Include <limits.h>.
13435 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13436 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13437 (load_charset_map): Mark variables that gcc -Wuninitialized
13438 does not deduce are never used uninitialized.
53df7c11 13439 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13440
f38b440c
PE
13441 * coding.c (coding_set_source, coding_set_destination):
13442 Use "else { /* comment */ }" rather than "else /* comment */;"
13443 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13444 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13445 a block, when the outer 'i' will do.
13446 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13447 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13448 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13449 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13450 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13451 Rename locals to avoid shadowing.
13452 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13453 * coding.c (emacs_mule_char, encode_invocation_designation):
13454 Now static, since they're not used elsewhere.
413bb2db 13455 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13456 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13457 (decode_coding_emacs_mule): Mark variables that gcc
13458 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13459 (detect_coding_iso_2022): Initialize a local variable that might
13460 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13461 this initialization is needed. (Bug#8211)
5f58e762
PE
13462 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13463 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13464 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13465 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13466 Remove unused macros.
f38b440c 13467
232b38b9 13468 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13469 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13470 * character.c (string_count_byte8): Likewise.
232b38b9 13471
fb90da1b
PE
13472 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13473 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13474
fb93dbc2
PE
13475 * chartab.c (copy_sub_char_table): Now static, since it's not used
13476 elsewhere.
5c156ace
PE
13477 (sub_char_table_ref_and_range, char_table_ref_and_range):
13478 Rename locals to avoid shadowing.
bbcd0949 13479 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13480
7d3b3862 13481 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13482 (BIDI_BOB): Remove unused macro.
7d3b3862 13483
6be7d3da
PE
13484 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13485 deduce are never used uninitialized.
c2ed9c8b 13486 * term.c (encode_terminal_code): Likewise.
6be7d3da 13487
75f8807f 13488 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13489
50938595
PE
13490 * tparam.h: New file.
13491 * term.c, tparam.h: Include it.
13492 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13493 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13494 Move these decls to tparam.h, and make them agree with what
13495 is actually in tparam.c. The previous trick of using incompatible
13496 decls in different modules does not conform to the C standard.
13497 All callers of tparam changed to use tparam's actual API.
13498 * tparam.c (tparam1, tparam, tgoto):
13499 Use const pointers where appropriate.
13500
fbceeba2
PE
13501 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13502 * cm.h (struct cm): Likewise.
13503 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13504 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13505 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13506 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13507 (turn_on_face, init_tty): Likewise.
13508 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13509
7f3f1250
PE
13510 * term.c (term_mouse_position): Rename local to avoid shadowing.
13511
e6ca6543
PE
13512 * alloc.c (mark_ttys): Move decl from here ...
13513 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13514
c40f8d15
AS
135152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13516
13517 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13518
cfe0661d
JB
135192011-03-09 Juanma Barranquero <lekktu@gmail.com>
13520
13521 * search.c (compile_pattern_1): Remove argument regp, unused since
13522 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13523 (compile_pattern): Don't pass it.
13524
0afb4571
J
135252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13526
13527 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13528 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13529 for ! HAVE_GTK3.
13530 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13531
13532 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13533
13534 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13535 gdk_window_get_screen, gdk_window_get_geometry,
13536 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13537 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13538 (xg_get_pixbuf_from_pixmap): New function.
13539 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13540 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13541 Call xg_get_pixbuf_from_pixmap instead of
13542 gdk_pixbuf_get_from_drawable.
13543 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13544 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13545 (xg_check_special_colors): Use GtkStyleContext and its functions
13546 for HAVE_GTK3.
13547 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13548 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13549 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13550 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13551 Call gtk_widget_get_preferred_size.
0afb4571
J
13552 (xg_frame_resized): gdk_window_get_geometry only takes 5
13553 parameters.
44f230aa
SM
13554 (xg_win_to_widget, xg_event_is_for_menubar):
13555 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13556 (xg_set_widget_bg): New function.
13557 (delete_cb): New function.
895009e1 13558 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13559 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13560 (xg_set_background_color): Call xg_set_widget_bg.
13561 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13562 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13563 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13564 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13565 if ! HAVE_GTK3.
13566 (update_frame_tool_bar): Call gtk_widget_hide.
13567 (xg_initialize): Use GDK_KEY_g.
13568
13569 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13570 if ! HAVE_GTK3
13571 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13572
13573 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13574 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13575 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13576
1c2cc4ef
JB
135772011-03-08 Juanma Barranquero <lekktu@gmail.com>
13578
13579 * w32xfns.c (select_palette): Check success of RealizePalette against
13580 GDI_ERROR, not zero.
13581
33383987 13582See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13583
13584;; Local Variables:
13585;; coding: utf-8
aac0c6e3
MR
13586;; End:
13587
2f097256 13588 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13589
13590 This file is part of GNU Emacs.
13591
13592 GNU Emacs is free software: you can redistribute it and/or modify
13593 it under the terms of the GNU General Public License as published by
13594 the Free Software Foundation, either version 3 of the License, or
13595 (at your option) any later version.
13596
13597 GNU Emacs is distributed in the hope that it will be useful,
13598 but WITHOUT ANY WARRANTY; without even the implied warranty of
13599 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13600 GNU General Public License for more details.
13601
13602 You should have received a copy of the GNU General Public License
13603 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.