Spelling fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
58179cce
JB
12011-11-16 Juanma Barranquero <lekktu@gmail.com>
2
7877f373
JB
3 * nsfns.m (Fns_font_name):
4 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5
b6f67890
MR
62011-11-16 Martin Rudalics <rudalics@gmx.at>
7
8 * window.h (window): Rename slot "nest" to "combination_limit".
9 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
10 (Fset_window_nest): Rename to Fset_window_combination_limit.
11 (Vwindow_nest): Rename to Vwindow_combination_limit.
12 (recombine_windows, make_parent_window, make_window)
13 (Fsplit_window_internal, saved_window)
14 (Fset_window_configuration, save_window_save): Rename all
15 occurrences of window_nest to window_combination_limit.
16
c7015153
JB
172011-11-15 Juanma Barranquero <lekktu@gmail.com>
18
19 * image.c (imagemagick_load_image): Fix typo.
20
322ad6ec
EZ
212011-11-14 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (display_line): Move the call to
24 highlight_trailing_whitespace before the call to
25 compute_line_metrics, since the latter needs to see the final
26 faces of all the glyphs to compute ROW's hash value. Fixes
27 assertion violations in row_equal_p. (Bug#10035)
28
f067b8ec
JB
292011-11-14 Juanma Barranquero <lekktu@gmail.com>
30
31 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
32 just return (bug#10044).
33
1e5b2111
EZ
342011-11-12 Eli Zaretskii <eliz@gnu.org>
35
7ef3cbd5
EZ
36 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
37 with user-defined heap size. Bump the default size of the temacs
38 heap to 27MB, to avoid memory warning when running temacs.
39 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
40
1e5b2111
EZ
41 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
42 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
43 (verify_row_hash) [XASSERTS]: New function.
44 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
45 that the hash value of glyph rows is correct.
1e5b2111 46
89d61221
MR
472011-11-12 Martin Rudalics <rudalics@gmx.at>
48
49 * window.h (window): Remove splits slot.
50 * window.c (Fwindow_splits, Fset_window_splits): Remove.
51 (Fdelete_other_windows_internal, make_parent_window)
52 (make_window, Fsplit_window_internal, Fdelete_window_internal)
53 (Fset_window_configuration, save_window_save): Don't deal with
54 split status of windows.
55 (saved_window): Remove splits slot.
56 (Vwindow_splits): Rewrite doc-string.
57
97f18cc8
JD
582011-11-11 Jan Djärv <jan.h.d@swipnet.se>
59
60 * xfns.c (unwind_create_frame):
61 * nsfns.m (unwind_create_frame):
62 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
63 Vframe_list (Bug#9999).
64
22a648b4
DA
652011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
66
0b381c7e 67 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 68
659afede
KH
692011-11-11 Kenichi Handa <handa@m17n.org>
70
71 * callproc.c (Fcall_process): Set the member dst_multibyte of
72 process_coding.
73
9ac0394b
KH
742011-11-11 Johan Bockgård <bojohan@gnu.org>
75
76 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
77 avoid a crash (bug#9496).
78
2fbdc249
CY
792011-11-09 Chong Yidong <cyd@gnu.org>
80
81 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
82 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
83
ac6b1f81
PE
842011-11-08 Paul Eggert <eggert@cs.ucla.edu>
85
86 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
87
09db192c
PE
882011-11-08 Paul Eggert <eggert@cs.ucla.edu>
89
90 Avoid some portability problems by eschewing 'extern inline' functions.
91 The trivial performance wins aren't worth the portability hassles; see
92 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
93 et seq.
94 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
95 (window_box_width, window_box_left, window_box_left_offset)
96 (window_box_right, window_box_right_offset): Undo previous change,
97 by removing the "extern"s.
98 * intervals.c (adjust_intervals_for_insertion)
99 (adjust_intervals_for_deletion): Undo previous change,
100 making these static again.
101 (offset_intervals, temp_set_point_both, temp_set_point)
102 (copy_intervals_to_string): No longer inline.
103 * xdisp.c (window_text_bottom_y, window_box_width)
104 (window_box_height, window_box_left_offset)
105 (window_box_right_offset, window_box_left, window_box_right)
106 (window_box): No longer inline.
107
105216ed
CY
1082011-11-08 Chong Yidong <cyd@gnu.org>
109
110 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
111 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
112 an error if not a live window.
113 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
114 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
115
ae9e237f
JB
1162011-11-07 Juanma Barranquero <lekktu@gmail.com>
117
118 * lisp.h (syms_of_abbrev): Remove declaration.
119 Reported by CHENG Gao <chenggao@royau.me>.
120
c7aa8333
EZ
1212011-11-07 Eli Zaretskii <eliz@gnu.org>
122
123 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
124 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
125 of temacs in GUI mode.
126
be7f5545
MR
1272011-11-07 Martin Rudalics <rudalics@gmx.at>
128
129 * window.h: Declare delete_all_child_windows instead of
130 delete_all_subwindows.
131 * window.c (Fwindow_nest, Fset_window_nest)
132 (Fset_window_new_total, Fset_window_new_normal)
133 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
134 (delete_all_subwindows): Rename to delete_all_child_windows.
135 (Fdelete_other_windows_internal, Fset_window_configuration):
136 Call delete_all_child_windows instead of delete_all_subwindows.
137 * frame.c (delete_frame): Call delete_all_child_windows instead
138 of delete_all_subwindows.
139
ca78dc43
PE
1402011-11-07 Paul Eggert <eggert@cs.ucla.edu>
141
142 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
143 This is also needed for porting to any host where GC_MARK_STACK is
144 not GC_MAKE_GCPROS_NOOPS.
145 (which_symbols): Use it.
146
a0241d01
KH
1472011-11-07 Kenichi Handa <handa@m17n.org>
148
149 * coding.c (coding_set_destination): Check coding->src_pos only
150 when coding->src_object is a buffer (bug#9910).
151
152 * process.c (send_process): Set the member src_multibyte of coding
153 to 0 (bug#9911) when sending a unibyte text.
154
155 * callproc.c (Fcall_process): Set the member src_multibyte of
156 process_coding to 0 (bug#9912).
157
a64bfdfa 1582011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
159
160 * xmenu.c (cleanup_widget_value_tree): New function.
161 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
162 calling free_menubar_widget_value_tree directly (Bug#9830).
163
cb41b32a
PE
1642011-11-06 Paul Eggert <eggert@cs.ucla.edu>
165
166 Fix some portability problems with 'inline'.
167 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
168 (window_box_width, window_box_left, window_box_left_offset)
169 (window_box_right, window_box_right_offset): Declare extern.
170 Otherwise, these inline functions do not conform to C99 and
171 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
172 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
173 * intervals.c (adjust_intervals_for_insertion)
174 (adjust_intervals_for_deletion): Now extern, because otherwise the
175 extern inline functions 'offset_intervals' couldn't refer to it.
176 (static_offset_intervals): Remove.
177 (offset_intervals): Rewrite using the old contents of
178 static_offset_intervals. The old version didn't conform to C99
179 because an extern inline function contained a reference to an
180 identifier with static linkage.
181
b7041366
AS
1822011-11-06 Andreas Schwab <schwab@linux-m68k.org>
183
184 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
185 GC.
186
88a37c4d
EZ
1872011-11-06 Eli Zaretskii <eliz@gnu.org>
188
189 * xdisp.c (init_iterator, reseat_to_string): Don't set the
190 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
191 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
192 return Qleft_to_right.
193
49745b39
CY
1942011-11-06 Chong Yidong <cyd@gnu.org>
195
196 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
197 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
198 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
199 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
200 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
201 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
202 (Fwindow_vscroll): Doc fix.
203 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
204 argument, since it makes no sense to pass a live window and for
205 consistency with window-child.
206
1f05cd82
CS
2072011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
208
209 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
210 support MSVC.
211
22610910
JR
2122011-11-05 Jason Rumney <jasonr@gnu.org>
213
214 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
215 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
216 fonts (Bug#6029).
217 (add_font_entity_to_list): Fix logic errors in mixed boolean and
218 bitwise arithmetic preventing use of unicode-sip and non-truetype
219 opentype fonts.
220
a06776b2
EZ
2212011-11-05 Eli Zaretskii <eliz@gnu.org>
222
3ad924ba
EZ
223 * s/ms-w32.h (fstat, stat, utime): Move redirections to
224 "emacs"-only part.
225
a06776b2
EZ
226 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
227 initialization code to keep similarity to xfns.c after changes
228 from 2011-11-05.
229
c9e7db78
JD
2302011-11-05 Jan Djärv <jan.h.d@swipnet.se>
231
a97f8f3f
JD
232 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
233 (unwind_create_frame): New function (Bug#9943).
234 (Fx_create_frame): Restructure code to be more similar to the one in
235 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
236 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
237 Move terminal->reference_count++ just before making the frame official
238 (Bug#9943).
239
240 * nsterm.m (x_free_frame_resources): New function.
241 (x_destroy_window): Move code to x_free_frame_resources.
242
c9e7db78
JD
243 * xfns.c (unwind_create_frame): Fix comment.
244 (Fx_create_frame, x_create_tip_frame): Move
245 terminal->reference_count++ just before making the frame
246 official. Move initialization of image_cache_refcount and
247 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
248
a6fc3b5c
EZ
2492011-11-05 Eli Zaretskii <eliz@gnu.org>
250
251 Support MSVC build with newer versions of Visual Studio.
252 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
253 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
254 nt/gmake.defs.
255
256 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
257 which are not supported by MSVC.
258 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
259 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
260 bitfields.
261 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
262 types in bitfields.
263 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
264
265 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
266
58179cce 2672011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
268
269 Support MSVC build with newer versions of Visual Studio.
270 * w32.c: Don't include w32api.h for MSVC.
271 (init_environment) [_MSC_VER]: Call sys_access, not _access.
272
273 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
274 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
275 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
276 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
277 e_* cousins.
278 (alloca) [_MSC_VER]: Define to _alloca.
279
280 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
281
282 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
283
a58c13ed
EZ
2842011-11-04 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (note_mouse_highlight): If either of
287 previous/next-single-property-change returns nil, treat that as
288 the beginning or the end of the buffer. (Bug#9955)
289
fe0b6370
JD
2902011-11-04 Jan Djärv <jan.h.d@swipnet.se>
291
a58c13ed 292 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
293 label is not null (Bug#9951).
294 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
295 may be NULL.
296
89bd5ee1
EZ
2972011-11-04 Eli Zaretskii <eliz@gnu.org>
298
299 * window.c (Fwindow_body_size): Mention in the doc string that the
300 return value is in frame's canonical units. (Bug#9949)
301
84c3edb9
EZ
3022011-11-03 Eli Zaretskii <eliz@gnu.org>
303
4e2fb5c7
EZ
304 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
305
84c3edb9 306 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 307 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 308 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 309
bc17a887
EZ
3102011-11-01 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
313 Don't stop backward scan on the continuation glyph, even though
314 its CHARPOS is positive.
26b46e51
EZ
315 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
316 cover_string to disp_string.
bc17a887 317
4ee88440
MR
3182011-11-01 Martin Rudalics <rudalics@gmx.at>
319
320 * window.c (temp_output_buffer_show): Don't use
321 Vtemp_buffer_show_specifiers.
322 (Vtemp_buffer_show_specifiers): Remove unused variable.
323
c2ff3c02
EZ
3242011-10-30 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
327 past the beginning of the current glyph matrix.
328
58179cce 3292011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
330
331 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
332 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
333 HAVE_GTK3 (Bug#9869).
b77a6a7f 334
3b574623
JD
335 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
336 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
337
b77a6a7f
JD
338 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
339
340 * xterm.c: Declare x_handle_net_wm_state to return int.
341 (handle_one_xevent): Check if we are iconified but don't have
342 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
343 (get_current_wm_state): Return non-zero if not hidden,
344 check for _NET_WM_STATE_HIDDEN (Bug#9893).
345 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
346 (x_handle_net_wm_state): Return what get_current_wm_state returns.
347 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
348
196e41e4
PE
3492011-10-29 Paul Eggert <eggert@cs.ucla.edu>
350
351 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
352 so that this new function doesn't get optimized away by a
353 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
354
021f2e1a
AS
3552011-10-29 Andreas Schwab <schwab@linux-m68k.org>
356
357 * frame.h (MOUSE_HL_INFO): Remove excess parens.
358
8b058d44
EZ
3592011-10-29 Eli Zaretskii <eliz@gnu.org>
360
361 Fix the `xbytecode' command.
362 * .gdbinit (xprintbytestr): New command.
363 (xwhichsymbols): Renamed from `which'; all callers changed.
364 (xbytecode): Print the byte-code string as well.
365
4452fb80
EZ
3662011-10-29 Kim Storm <storm@cua.dk>
367
8b058d44
EZ
368 * alloc.c (which_symbols): New function.
369
21b72067
AS
3702011-10-29 Andreas Schwab <schwab@linux-m68k.org>
371
372 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
373 line. (Bug#9903)
374
83ed7b5c
GM
3752011-10-29 Glenn Morris <rgm@gnu.org>
376
377 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
378 Not clear what it was for, and it causes various bugs. (Bug#9839)
379
5a7a728b
EZ
3802011-10-28 Eli Zaretskii <eliz@gnu.org>
381
382 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
383 possible random value that matches one of those tested as
384 condition to clear the mouse face.
385
d3d0842f
CY
3862011-10-28 Chong Yidong <cyd@gnu.org>
387
388 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
389
31b39d13
DN
3902011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
391
392 * window.c (make_window): Initialize phys_cursor_on_p.
393
9aba6043
SM
3942011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
395
396 * lisp.h (struct Lisp_Symbol): Update comments.
397
c20992f4
JB
3982011-10-28 Juanma Barranquero <lekktu@gmail.com>
399
400 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
401
db4f02f2
EZ
4022011-10-28 Eli Zaretskii <eliz@gnu.org>
403
404 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
405 <oslsachem@gmail.com> for helping to debug this.
406
407 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
408 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
409 (g_b_init_get_glyph_outline_w): New static variables.
410 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
411 (GetGlyphOutlineW_Proc): New typedefs.
412 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
413 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
414 New functions.
415 (w32font_open_internal, compute_metrics):
416 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
417 instead of calling the "wide" APIs directly.
418
419 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
420
421 * w32.h (syms_of_w32font): Add prototype.
422
87e68db4
JB
4232011-10-27 Juanma Barranquero <lekktu@gmail.com>
424
425 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
426 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
427 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
428 (Fmove_to_window_line): Doc fix.
429
435c1d67
CY
4302011-10-27 Chong Yidong <cyd@gnu.org>
431
432 * process.c (make_process): Set gnutls_state to NULL.
433
434 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
435 non-NULL, regardless of GNUTLS_INITSTAGE.
436 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
437 an error. Set process slots as soon as we allocate them.
438
439 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
440
9c6c6f49
CY
4412011-10-27 Chong Yidong <cyd@gnu.org>
442
9aba6043
SM
443 * gnutls.c (emacs_gnutls_deinit): New function.
444 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
445 (Fgnutls_deinit, Fgnutls_boot): Use it.
446
447 * process.c (make_process): Initialize GnuTLS credentials to NULL.
448 (deactivate_process): Call emacs_gnutls_deinit.
449
657d08d3
JB
4502011-10-27 Juanma Barranquero <lekktu@gmail.com>
451
452 * image.c (x_create_x_image_and_pixmap):
453 * w32.c (sys_rename, w32_delayed_load):
454 * w32font.c (fill_in_logfont):
455 * w32reg.c (x_get_string_resource): Silence compiler warnings.
456
5430d399
JB
4572011-10-26 Juanma Barranquero <lekktu@gmail.com>
458
459 * w32fns.c (w32_default_color_map): New function,
460 extracted from Fw32_default_color_map.
a7ef684b 461 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 462
fe0055fa
PE
4632011-10-25 Paul Eggert <eggert@cs.ucla.edu>
464
465 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
466
e6346438
SM
4672011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
468
469 * keyboard.c (test_undefined): New function (bug#9751).
470 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
471
e112cc37
ET
4722011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
473
474 * sysdep.c (init_sys_modes): Fix the check for the controlling
475 terminal (Bug#6649).
476
7b5d6677
EZ
4772011-10-20 Eli Zaretskii <eliz@gnu.org>
478
479 * dispextern.h (struct bidi_it): New member next_en_type.
480
481 * bidi.c (bidi_line_init): Initialize the next_en_type member.
482 (bidi_resolve_explicit_1): When next_en_pos is valid for the
483 current character, check also for next_en_type being WEAK_EN.
484 (bidi_resolve_weak): Don't enter the expensive loop if the current
485 position is before next_en_pos. Record the bidi type of the first
486 non-ET, non-BN character we find, in addition to its position.
487 (bidi_level_of_next_char): Invalidate next_en_type when
488 next_en_pos is over-stepped.
489
7da0b018
PE
4902011-10-20 Paul Eggert <eggert@cs.ucla.edu>
491
492 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
493 * editfns.c: Rewrite current-time-zone so that it invokes
494 the equivalent of (format-time-string "%Z") to get the time zone name.
495 This fixes a bug when the time zone name contains characters that
496 need converting from the system time locale to Emacs internal format.
497 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
498 that patch fixed format-time-string to do the conversion, but
499 I forgot to fix current-time-zone.
500 (format_time_string): New function, containing most of
501 what Fformat_time_string used to contain.
502 (Fformat_time_string): Rewrite in terms of format_time_string.
503 This doesn't change this function's behavior.
504 (current-time-zone): Rewrite to use format_time_string.
505 This fixes the bug reported by Michael Schierl in
506 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
507 Jason Rumney's 2007-06-07 change worked around this bug, but
508 didn't fix it.
509 * systime.h (tzname, timezone): Remove no-longer-used declarations.
510
8547b010
EZ
5112011-10-19 Eli Zaretskii <eliz@gnu.org>
512
513 * xdisp.c (start_display): If the character at POS is displayed
514 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
515 (try_window_reusing_current_matrix): If a line ends in a display
516 vector or the next line starts in a display vector, continue
517 redrawing the window even though the character position of
518 start_row was reached.
8547b010
EZ
519 (Bug#9771, part 2)
520
4e948d15
CY
5212011-10-18 Chong Yidong <cyd@gnu.org>
522
523 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
524 with nobreak-char-display too.
525
4787455f
EZ
5262011-10-18 Eli Zaretskii <eliz@gnu.org>
527
528 Fix part 3 of bug#9771.
529 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
530 (bidi_resolve_neutral): Don't enter the expensive loop looking for
531 non-neutral characters if the current character is a paragraph
532 separator (a.k.a. Newline). This avoids running the same
533 expensive loop twice, once when we consume the preceding newline
534 and the other time when the line actually needs to be displayed.
535 Avoid the loop when we see neutrals on the base embedding level
536 following a character whose directionality is the same as the
537 paragraph's. This avoids running the expensive loop when a line
538 ends in a long sequence of neutrals, like control characters.
539 Add assertion against STRONG_AL type. Slightly rearrange code
540 that determines the type of a neutral given the first non-neutral
541 that follows it.
542 (bidi_level_of_next_char): Set next_en_pos to zero when
543 invalidating its info.
544
2c91f553
EZ
5452011-10-17 Eli Zaretskii <eliz@gnu.org>
546
547 * xdisp.c (push_display_prop): Determine whether to record string
548 or buffer position by IT->string, not by IT->method. Allow
549 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
550 (move_it_vertically_backward): Don't look for character position
551 immediately after the newline when in a continuation line.
552 (Bug#9771, part 1)
2c91f553 553
c7b08b0d
MR
5542011-10-15 Martin Rudalics <rudalics@gmx.at>
555
556 * window.c (coordinates_in_window): Rewrite and delabelize
557 vertical border check. (Bug#5357) (Bug#9618)
558
6b02f655
SM
5592011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
562 errors in XSetWindowBorder (bug#9310).
563
81d40c92
DA
5642011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
565
566 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
567 avoid crash when xmalloc overrun checking is enabled.
568
d4172c3b
EZ
5692011-10-13 Eli Zaretskii <eliz@gnu.org>
570
571 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
572 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
573 cursor motion with <left> and <right> arrow keys.
574
575 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
576 some callers set that themselves.
577
b00eea75
EZ
5782011-10-12 Eli Zaretskii <eliz@gnu.org>
579
580 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
581 display string and the previous row comes from the same string and
582 is empty. (Bug#9739) (Bug#9738)
583
8fe012c4
SM
5842011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
585
586 * doc.c (get_doc_string): Encode file name (bug#9735).
587
0074aef2
EZ
5882011-10-12 Eli Zaretskii <eliz@gnu.org>
589
79beb178
EZ
590 * bidi.c (bidi_level_of_next_char):
591 * xdisp.c (get_visually_first_element): Remove old incorrect
592 comments regarding the Unicode Line Separator character.
593
0074aef2
EZ
594 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
595
6e4b3fbe
DA
5962011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
597
598 * alloc.c (Fgc_status): Do not access beyond zombies array
599 boundary if nzombies > MAX_ZOMBIES.
600 * alloc.c (dump_zombies): Add missing format specifier.
601
0324f3af
PE
6022011-10-12 Paul Eggert <eggert@cs.ucla.edu>
603
b5525cac
PE
604 * xdisp.c (set_cursor_from_row): Simplify conditionals,
605 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
606
0324f3af
PE
607 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
608 Some packages use them to denote characters with modifiers.
609
e9b5f888
AS
6102011-10-11 Andreas Schwab <schwab@linux-m68k.org>
611
612 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
613 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
614 matching a pp-number. Rename parameter var to var1.
615
127827c0
SM
6162011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
617
618 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
619
c8fd3bd0
GM
6202011-10-08 Glenn Morris <rgm@gnu.org>
621
622 * callint.c (Fcall_interactively): Give a more explicit error for the
623 'c' case with a non-character input. (Bug#8479)
624
352ec8ff
EZ
6252011-10-08 Eli Zaretskii <eliz@gnu.org>
626
03669ccb
EZ
627 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
628 lines.
7061c986
EZ
629 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
630 lines that are hscrolled on the left.
03669ccb 631
352ec8ff
EZ
632 * dispnew.c (buffer_posn_from_coords): Account for a possible
633 presence of header-line. (Bug#4426)
634
a66cfb1c
SM
6352011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
636
6b02f655
SM
637 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
638 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 639
7c5ee88e
PE
6402011-10-07 Paul Eggert <eggert@cs.ucla.edu>
641
642 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
643 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
644 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
645 this makes Emacs dump core during garbage collection on rare
646 occasions. sizeof is obviously inferior to offsetof here, so
647 stick with offsetof.
648 (GC_POINTER_ALIGNMENT): New macro.
649 (mark_memory): Omit 3rd (offset) arg; caller changed.
650 Don't assume EMACS_INT alignment is the same as pointer alignment.
651
df1bbe5b
SM
6522011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
653
654 * keyboard.c (read_key_sequence_remapped): New var.
655 (read_key_sequence): Compute remapping in the right buffer.
656 (command_loop_1): Use read_key_sequence's remapping directly.
657
51553db6
SM
6582011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
659
32c1fffd
SM
660 * dired.c (file_name_completion): Don't expand file name.
661 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
662 before checking file name handler.
663
51553db6
SM
664 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
665 they've been requested explicitly (bug#9591).
666
b6bd1599 6672011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
668
669 * keymap.c (Fsingle_key_description): Use make_specified_string
670 instead of build_string to build string from push_key_description.
671 (Bug#5193)
672
f701dc2a
PE
6732011-09-30 Paul Eggert <eggert@cs.ucla.edu>
674
4222c55d
PE
675 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
676 This fixes a Y2038 bug on 64-bit hosts.
677 * buffer.c (reset_buffer):
678 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
679 (Fclear_buffer_auto_save_failure):
680 Use 0, not -1, to represent an unset failure time, since time_t
681 might not be signed.
682
f701dc2a
PE
683 Remove dependency on glibc malloc internals.
684 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
685 Move back here from lisp.h, but with their new implementations.
686 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
687 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
688 * charset.c (charset_table_init): New static var.
689 (syms_of_charset): Use it instead of xmalloc. This removes a
690 dependency on glibc malloc internals. See Eli Zaretskii's comment in
691 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
692 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
693 Move back to alloc.c.
694 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
695 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
696
9ceebf39
JD
6972011-09-30 Jan Djärv <jan.h.d@swipnet.se>
698
699 * nsterm.m (windowDidResize): Call x_set_window_size only when
700 ns_in_resize is true. Otherwise set pixelwidth/height and
701 call change_frame_size (Bug#9628).
702
cb993c58
PE
7032011-09-30 Paul Eggert <eggert@cs.ucla.edu>
704
3930c88b
PE
705 Port --enable-checking=all to Fedora 14 x86-64.
706 * charset.c (syms_of_charset): Also account for glibc malloc's
707 internal overhead when calculating the initial malloc maximum.
708
cb993c58
PE
709 Port --enable-checking=all to Fedora 14 x86.
710 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
711 Move to lisp.h.
712 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
713 (overrun_check_realloc, overrun_check_free):
714 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
715 That way, xmalloc returns a properly-aligned pointer even if
716 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
717 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
718 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
719 into account when calculating the initial malloc maximum.
720 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
721 Move here from alloc.c, so that charset.c can use it too.
722 Properly align; the old code wasn't right for common 32-bit hosts
723 when configured with --enable-checking=all.
724 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
725 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
726
31bed486
EZ
7272011-09-29 Eli Zaretskii <eliz@gnu.org>
728
04c70788 729 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
730 use EDOM.
731
fbcaa2f3
EZ
7322011-09-28 Eli Zaretskii <eliz@gnu.org>
733
734 * xdisp.c (compute_display_string_end): If there's no display
735 string at CHARPOS, return -1.
736
737 * bidi.c (bidi_fetch_char): When compute_display_string_end
738 returns a negative value, treat the character as a normal
739 character not covered by a display string. (Bug#9624)
740
a239d4e9
JB
7412011-09-28 Juanma Barranquero <lekktu@gmail.com>
742
743 * lread.c (Fread_from_string): Fix typo in docstring.
744
88652fd5
EZ
7452011-09-27 Eli Zaretskii <eliz@gnu.org>
746
747 * xdisp.c (handle_invisible_prop): If invisible text ends on a
748 newline, reseat the iterator instead of bidi-iterating there one
749 character at a time. (Bug#9610)
32c1fffd
SM
750 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
751 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 752
ed497dd4
AS
7532011-09-27 Andreas Schwab <schwab@linux-m68k.org>
754
755 * lread.c (readevalloop): Use correct code for NBSP.
756 (read1): Likewise. (Bug#9608)
757
b2bf61aa
MA
7582011-09-25 Michael Albinus <michael.albinus@gmx.de>
759
760 * dbusbind.c (Fdbus_register_signal): When service is not
761 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
762
32bbb17c
GM
7632011-09-25 Glenn Morris <rgm@gnu.org>
764
765 * buffer.c (truncate-lines): Doc fix.
766
94e0933e
CY
7672011-09-24 Chong Yidong <cyd@stupidchicken.com>
768
769 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
770 (Fset_window_next_buffers): Doc fix.
771
cddde921
GM
7722011-09-24 Glenn Morris <rgm@gnu.org>
773
774 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
775
1260aef1
PE
7762011-09-24 Paul Eggert <eggert@cs.ucla.edu>
777
25b4bfa0
PE
778 Fix minor problems found by static checking.
779 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
780 * indent.c (Fvertical_motion): Fix == vs = typo.
781
e3cbd34b
EZ
7822011-09-24 Eli Zaretskii <eliz@gnu.org>
783
a66cfb1c
SM
784 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
785 Default value is now t. Doc fix.
6bf7006f 786
e3cbd34b 787 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 788 logic when moving up, not only when moving down. Fix the
e3cbd34b 789 confusing name and values of the it_overshoot_expected variable;
32c1fffd 790 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
791
792 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
793 CHARPOS is covered by a display string which includes newlines.
794 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
795 is covered by a display string with embedded newlines.
796
a3de0cbd
MA
7972011-09-24 Michael Albinus <michael.albinus@gmx.de>
798
799 * dbusbind.c (Fdbus_register_signal): Add match rule to
800 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
801 (Fdbus_register_method, Vdbus_registered_objects_table):
802 Fix docstring.
a3de0cbd 803
b260039d
JM
8042011-09-24 Jim Meyering <meyering@redhat.com>
805
32c1fffd 806 do not ignore write error for any output size
b260039d
JM
807 The previous change was incomplete.
808 While it makes emacs --batch detect the vast majority of stdout
809 write failures, errors were still ignored whenever the output size is
810 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
811 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
812 && echo FAIL: ignored write error
813 FAIL: ignored write error
814 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
815 && echo FAIL: ignored write error
816 FAIL: ignored write error
817 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
818
8eca8a7c
AS
8192011-09-23 Andreas Schwab <schwab@linux-m68k.org>
820
821 * emacs.c (Fkill_emacs): In noninteractive mode exit
822 non-successfully if a write error occurred on stdout. (Bug#9574)
823
3341db62
EZ
8242011-09-21 Eli Zaretskii <eliz@gnu.org>
825
826 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
827 the xassert test.
828
829 * dispextern.h (struct it): Update the comment documenting what
830 can it->OBJECT be.
831
8c203dbf
EZ
8322011-09-20 Eli Zaretskii <eliz@gnu.org>
833
834 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
835 a display string, extend search for cursor position to end of row.
836 (find_row_edges): If the row ends in a newline from a display
837 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
838 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
839 (Fcurrent_bidi_paragraph_direction): Fix search for previous
840 non-empty line. Fixes confusing cursor motion with arrow keys at
841 the beginning of a line that starts with whitespace.
8c203dbf 842
a4824228
LMI
8432011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
844
845 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
846 (bug#9493).
847
33ed493b
CY
8482011-09-18 Chong Yidong <cyd@stupidchicken.com>
849
850 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
851 boolean (Bug#9154).
852
56cd55c8
EZ
8532011-09-18 Eli Zaretskii <eliz@gnu.org>
854
855 * xdisp.c (display_line): Record maximum and minimum buffer
856 positions even if no glyphs were produced (e.g., by a zero-width
857 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
858 buffer positions that will be removed from the glyph row because
859 they don't fit.
c02dcedf
EZ
860 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
861 column is beyond frame width: don't subtract 1 "pixel" when
862 computing width of the stretch.
3e62b7e0
EZ
863 (reseat_at_next_visible_line_start): Undo the change made on
864 2011-09-17 that saved paragraph information and restored it after
865 the call to `reseat'. (Bug#9545)
56cd55c8 866
5ed99d36 8672011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
868
869 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
870 and turn window cursor on if cleared (Bug#9415).
871
5ed99d36 8722011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
873
874 * search.c (boyer_moore): Take unibyte characters from pattern
875 literally. (Bug#9458)
876
9bade7b2
EZ
8772011-09-18 Eli Zaretskii <eliz@gnu.org>
878
879 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
880
e5e9d610
PE
8812011-09-18 Paul Eggert <eggert@cs.ucla.edu>
882
87e4427a
PE
883 Fix minor problem found by static checking.
884 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
885 initialized, to pacify gcc -Wuninitialized.
886
e5e9d610
PE
887 * fileio.c: Report proper errno when syscall falls.
888 (Finsert_file_contents): Save and restore errno,
889 so that report_file_error outputs the correct diagnostic.
890 (Fwrite_region) [CLASH_DETECTION]: Likewise.
891
a1674f0b
EZ
8922011-09-18 Eli Zaretskii <eliz@gnu.org>
893
894 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
895
fbfb6dd4
EZ
8962011-09-17 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
899 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
900
bb187662
EZ
9012011-09-17 Eli Zaretskii <eliz@gnu.org>
902
1137e8b8 903 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 904 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
905
906 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
907 (bidi_find_paragraph_start): Search back for paragraph beginning
908 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
909 (bidi_move_to_visually_next): Only trigger paragraph-related
910 computations when the last character is a newline or at EOB, not
911 just any NEUTRAL_B. (Bug#9470)
912
bb187662
EZ
913 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
914 truncated lines if point is covered by a display string. (Bug#9524)
915
2e621251
PE
9162011-09-16 Paul Eggert <eggert@cs.ucla.edu>
917
918 * xselect.c: Relax test for outgoing X longs (Bug#9498).
919 (cons_to_x_long): New function.
920 (lisp_data_to_selection_data): Use it. Correct the test for
921 short-versus-long data; it was negated. Break out of vector
922 loop, for efficiency, when a long datum is discovered.
923
91a15bc6
SM
9242011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
925
926 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
927
b41c3a35
EZ
9282011-09-16 Eli Zaretskii <eliz@gnu.org>
929
930 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
931 GCC PR/17406) by declaring this function with external scope.
932
7812ba2d
PE
9332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
934
935 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
936 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
937
cf7edc2a
AS
9382011-09-15 Andreas Schwab <schwab@linux-m68k.org>
939
940 * editfns.c (Fformat): Correctly handle text properties on "%%".
941
bd01620e
EZ
9422011-09-15 Eli Zaretskii <eliz@gnu.org>
943
944 * xterm.c (x_draw_composite_glyph_string_foreground):
945 * w32term.c (x_draw_composite_glyph_string_foreground):
946 * term.c (encode_terminal_code):
947 * composite.c (composition_update_it, get_composition_id):
948 * xdisp.c (get_next_display_element)
949 (fill_composite_glyph_string): Add comments about special meaning
950 of TAB characters in a composition.
951
a02719a3
PE
9522011-09-15 Paul Eggert <eggert@cs.ucla.edu>
953
954 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
955 This occurs when processing a multibyte format.
956 Problem reported by Wolfgang Jenker.
a02719a3 957
72589a3c
JB
9582011-09-15 Johan Bockgård <bojohan@gnu.org>
959
960 * xdisp.c (try_cursor_movement): Only check for exact match if
961 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
962
1c14176c
PE
9632011-09-14 Paul Eggert <eggert@cs.ucla.edu>
964
965 Remove unused external symbols.
966 * dispextern.h (calc_pixel_width_or_height): Remove decl.
967 * xdisp.c (calc_pixel_width_or_height): Now static.
968 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
969 * indent.c (check_display_width):
970 * w32term.c: Fix comment to match code.
971 * xterm.c, xterm.h (x_catching_errors): Remove.
972
d2eea5b5
PE
9732011-09-14 Paul Eggert <eggert@cs.ucla.edu>
974
975 * xselect.c: Use signed conversions more consistently (Bug#9498).
976 (selection_data_to_lisp_data): Assume incoming selection data are
977 signed integers, not unsigned. This is to be consistent with
978 outgoing selection data, which was modified to use signed integers
979 in as part of the fix to Bug#9196 in response to Jan D.'s comment
980 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
981 expects long, not unsigned long.
982
46888499
EZ
9832011-09-14 Eli Zaretskii <eliz@gnu.org>
984
985 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
986 computation of loop end. Reported by Johan Bockgård
987 <bojohan@gnu.org>.
988
ef8ef9fb
CY
9892011-09-13 Chong Yidong <cyd@stupidchicken.com>
990
991 * frame.c (Fother_visible_frames_p): Function deleted.
992
fa819fed
EZ
9932011-09-12 Eli Zaretskii <eliz@gnu.org>
994
995 * indent.c (compute_motion): Process display vector front to back
996 rather than the other way around. (Bug#2496)
997
2ba8e008
SM
9982011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
999
1000 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1001
20f53c69
CY
10022011-09-11 Chong Yidong <cyd@stupidchicken.com>
1003
1004 * minibuf.c (Fread_from_minibuffer): Doc fix.
1005
d562d7a4
EZ
10062011-09-11 Eli Zaretskii <eliz@gnu.org>
1007
1008 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1009 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1010
1c4d7f3d
LMI
10112011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1012
1013 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1014 value for non-existent files.
1015
b885bf36
EZ
10162011-09-11 Eli Zaretskii <eliz@gnu.org>
1017
1018 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1019 set its "size" to -1. This will set the modtime_size field of
1020 the corresponding buffer to -1, which is what
1021 verify-visited-file-modtime expects for files that do not exist.
1022 (Bug#9139)
1023
6612f0bf
PE
10242011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1027 here ...
1028 * lisp.h: ... from here. push_key_description is no longer
1029 defined in keyboard.c, so its declaration should not be in
1030 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1031 logically belongs with push_key_description.
1032
dfb3f755
PE
10332011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * buffer.h: Include <sys/types.h> instead of <time.h>.
1036 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1037 Problem reported by Herbert J. Skuhra.
1038
3134906c
LMI
10392011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1040
1041 * xml.c (parse_region): Make the parsing work for
1042 non-comment-starting XML files again (bug#9144).
1043
8d903f4e
AS
10442011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1045
1046 * image.c (gif_load): Fix calculation of bottom and right corner.
1047 (Bug#9468)
1048
80ad64f4
EZ
10492011-09-10 Eli Zaretskii <eliz@gnu.org>
1050
1051 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1052 redisplay in small windows.
1053
208a048d
EZ
10542011-09-09 Eli Zaretskii <eliz@gnu.org>
1055
1056 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1057
9b1c252e
MR
10582011-09-08 Martin Rudalics <rudalics@gmx.at>
1059
1060 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1061 Operate on live windows only.
1062
2949f33b
JB
10632011-09-08 Juanma Barranquero <lekktu@gmail.com>
1064
1065 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1066
e08dcafd
EZ
10672011-09-07 Eli Zaretskii <eliz@gnu.org>
1068
1069 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1070 only under bidi iteration.
1071
115b96bd
JD
10722011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1073
1074 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1075
c8199d0f
PE
10762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1079 Without this fix, the command to link temacs failed due to an
1080 undefined symbol __builtin_isnan. This is because
1081 /usr/include/iso/math_c99.h #defines isnan(x) to
1082 __builtin_isnan(x), but the bundled gcc, which identifies itself
1083 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1084 a __builtin_isnan.
1085 * floatfns.c (isnan): #undef, and then #define to a clone of
1086 what's in data.c.
1087 (Fisnan): Always define, since it's always available now.
1088 (syms_of_floatfns): Always define isnan at the Lisp level.
1089
e39b275c 10902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1091
1092 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1093
b2db44d9 10942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1095
f4af5137 1096 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1097 The previous code assumed that file offsets (off_t values) fit in
1098 EMACS_INT variables, which is not true on typical 32-bit hosts.
1099 The code messed up by falsely reporting buffer overflow in cases
1100 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1101 when "big" contains more than 2**29 bytes, even though this
1102 inserts just one byte and does not overflow the buffer.
1103 (Finsert_file_contents): Store file offsets as off_t
1104 values, not as EMACS_INT values. Check for overflow when
1105 converting between EMACS_INT and off_t. When checking for
1106 buffer overflow or for overlap, take the offsets into account.
1107 Don't use EMACS_INT for small values where int suffices.
1108 When checking for overlap, fix a typo: ZV was used where
1109 ZV_BYTE was intended.
1110 (Fwrite_region): Don't assume off_t fits into 'long'.
1111 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1112
ecfc0a49
MA
11132011-09-05 Michael Albinus <michael.albinus@gmx.de>
1114
1115 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1116
6511acf2 11172011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1118
0999621a 1119 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1120
1121 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1122 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1123 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1124 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1125 (modify_event_symbol): Do not assume that the length of
1126 name_alist_or_stem is safe to alloca and fits in int.
1127 (Fexecute_extended_command): Likewise for function name and binding.
1128 (Frecursion_depth): Wrap around reliably on integer overflow.
1129 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1130 since some callers pass EMACS_INT values.
1131 (Fsingle_key_description): Don't crash if symbol name contains more
1132 than MAX_ALLOCA bytes.
1133 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1134 (get_minibuffer): Arg is now EMACS_INT, not int.
1135 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1136 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1137 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1138
2be7d702
PE
1139 * dbusbind.c (signature_cat): New function.
1140 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1141 Do not overrun buffer; instead, report string overflow.
1142
9d1df220
PE
1143 * dispnew.c (add_window_display_history): Don't overrun buffer.
1144 Truncate instead; this is OK since it's just a log.
1145
33ef5c64
PE
1146 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1147 even if the time zone offset is outlandishly large.
1148 Don't mishandle offset == INT_MIN.
1149
66c6fdd5
PE
1150 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1151 when creating daemon; the previous buffer-overflow check was incorrect.
1152
d749b01b
PE
1153 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1154 which has the guts of the old verror function.
1155
b5cd1905
PE
1156 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1157 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1158
6e1a67fb
PE
1159 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1160 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1161 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1162 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1163 length of string rather than counting it via multiple sprintfs;
1164 that's simpler and more reliable.
c21721cc
PE
1165 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1166 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1167 sprintf, in case result does not fit in int.
1168
c57b67fc
PE
1169 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1170 (fontset_from_font): Print it.
1171
8a401434
PE
1172 * frame.c (tty_frame_count): Now printmax_t, not int.
1173 (make_terminal_frame, set_term_frame_name): Print it.
1174 (x_report_frame_params): In X, window IDs are unsigned long,
1175 not signed long, so print them as unsigned.
1176 (validate_x_resource_name): Check for implausibly long names,
1177 and don't assume name length fits in 'int'.
1178 (x_get_resource_string): Don't blindly alloca invocation name;
1179 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1180 not fit in int.
1181
6e1a67fb
PE
1182 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1183 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1184 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1185
0df02bf3
PE
1186 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1187 Use esprintf, not sprintf, in case result does not fit in int.
1188
48e30793
PE
1189 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1190 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1191 it as a large positive number.
1192 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1193 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1194
a66ff6d8
PE
1195 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1196 in case result does not fit in int.
1197
aca216ff
PE
1198 * print.c (float_to_string): Detect width overflow more reliably.
1199 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1200 buffer overrun. Don't assume list length fits in 'int'. Treat
1201 print length of 0 as 0, not as infinity; to be consistent with other
1202 uses of print length in this function. Don't overflow print length
1203 index. Don't assume hash table size fits in 'long', or that
1204 vectorlike size fits in 'unsigned long'.
1205
31c286f7
PE
1206 * process.c (make_process): Use printmax_t, not int, to format
1207 process-name gensyms.
1208
55e5faa1
PE
1209 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1210
80f2e268
PE
1211 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1212 to avoid potential buffer overrun.
1213
670741ab
PE
1214 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1215 if X resource line is longer than 512 bytes.
1216
b7163a50
PE
1217 * xfns.c (x_window): Make sprintf buffer a bit bigger
1218 to avoid potential buffer overrun.
1219
ae58ff1f
PE
1220 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1221
c43c8a6a
PE
1222 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1223
3f8236f4
PE
12242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1225
53e9fe90 1226 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1227 Without these, Emacs silently mishandles large integers sometimes.
1228 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1229 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1230
6511acf2
PE
1231 * xdisp.c (try_window_id): Check Emacs fixnum range before
1232 converting to 'int'.
806add1d 1233
6511acf2 1234 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1235 Check that an Emacs fixnum is in range before assigning it to 'int'.
1236 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1237 values converted from Emacs fixnums.
1238 (Frecenter): Don't wrap around a line count if it is out of 'int'
1239 range; instead, treat it as an extreme value.
1240 (Fset_window_configuration, compare_window_configurations):
1241 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1242
6511acf2
PE
1243 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1244 that can exceed INT_MAX. Check that EMACS_INT value is in range
1245 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1246 (match_limit): Don't assume that a fixnum can fit in 'int'.
1247
6511acf2 1248 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1249 exceed INT_MAX.
1250
6511acf2 1251 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1252 (Fvertical_motion): Don't wrap around LINES values that don't fit
1253 in 'int'. Instead, treat them as extreme values. This is good
1254 enough for windows, which can't have more than INT_MAX lines anyway.
1255
fcb901a7
LMI
12562011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1257
0f2f6b6d
LMI
1258 * Require libxml/parser.h to avoid compilation warning.
1259
fcb901a7
LMI
1260 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1261
1262 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1263 since this reportedly can destroy thread storage.
1264
6e20a0d4
CY
12652011-08-30 Chong Yidong <cyd@stupidchicken.com>
1266
1267 * syntax.c (find_defun_start): Update all cache variables if
1268 exiting early (Bug#9401).
1269
148ae00e
EZ
12702011-08-30 Eli Zaretskii <eliz@gnu.org>
1271
f6cfbd8f
EZ
1272 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1273
148ae00e
EZ
1274 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1275 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1276 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1277
1278 * term.c (tty_append_glyph): New function.
1279 (produce_stretch_glyph): Static function and its prototype deleted.
1280
a66cfb1c
SM
1281 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1282 Add prototypes.
148ae00e 1283
c4a07a4c
PE
12842011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1287 when checking :margin (Bug#9390).
1288 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1289 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1290 so that the name doesn't mislead. All uses changed.
1291
6bc8cd65
JB
12922011-08-28 Johan Bockgård <bojohan@gnu.org>
1293
1294 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1295 set_tty_hooks.
1296
dca4927e
EZ
12972011-08-27 Eli Zaretskii <eliz@gnu.org>
1298
1299 * xdisp.c (move_it_to): Don't bail out early when reaching
1300 position beyond to_charpos, if we are scanning backwards.
1301 (move_it_vertically_backward): When DY == 0, make sure we get to
1302 the first character in the line after the newline.
1303
f2cad773
PE
13042011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1307 (ccl_driver): Do not generate an out-of-range pointer.
1308 (Fccl_execute_on_string): Remove unnecessary check for
1309 integer overflow, noted by Stefan Monnier in
1310 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1311 Remove a FIXME that didn't need fixing.
1312 Simplify the newly-introduced buffer reallocation code.
1313
0cae2cdb
JB
13142011-08-27 Juanma Barranquero <lekktu@gmail.com>
1315
1316 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1317
5fc295a4 13182011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1319
70c60eb2 1320 Integer and memory overflow issues (Bug#9196).
726e0ab1 1321
d31850da
PE
1322 * doc.c (get_doc_string): Rework so that
1323 get_doc_string_buffer_size is the actual buffer size, rather than
1324 being 1 less than the actual buffer size; this makes xpalloc more
1325 convenient.
1326
a69fbedb
PE
1327 * image.c (x_allocate_bitmap_record, cache_image):
1328 * xselect.c (Fx_register_dnd_atom):
1329 Simplify previous changes by using xpalloc.
1330
fe5c5d37
PE
1331 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1332 since either will do and ptrdiff_t is convenient with xpalloc.
1333
0065d054
PE
1334 * charset.c (charset_table_size)
1335 (struct charset_sort_data.priority): Now ptrdiff_t.
1336 (charset_compare): Don't overflow if priorities differ greatly.
1337 (Fsort_charsets): Don't assume list length fits in int.
1338 Check for size-calculation overflow when allocating sort data.
1339 (syms_of_charset): Allocate an initial charset table that is
1340 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1341
1342 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1343
1344 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1345 The actual value is always <= INT_MAX, and leaving it unsigned made
1346 overflow checking harder.
1347
1348 * dispextern.h (struct glyph_matrix.rows_allocated)
1349 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1350 with xpalloc. The values are still always <= INT_MAX.
1351
1352 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1353
1354 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1355 (SAFE_NALLOCA): New macro.
1356
1357 * region-cache.c (struct boundary.pos, find_cache_boundary)
1358 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1359 (set_cache_region, invalidate_region_cache)
1360 (revalidate_region_cache, know_region_cache, region_cache_forward)
1361 (region_cache_backward, pp_cache):
1362 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1363 so that ptrdiff_t * can be passed to xpalloc.
1364 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1365 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1366 (pp_cache): Don't assume cache_len fits in int.
1367 * region-cache.h: Adjust extern decls to match.
1368
1369 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1370 EMACS_INT, since either will do, for xpalloc.
1371
1372 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1373 (xnmalloc, xnrealloc, xpalloc): New functions.
1374
726e0ab1
PE
1375 * bidi.c (bidi_shelve_header_size): New constant.
1376 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1377 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1378
51f30bc5 1379 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1380 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1381 (overlay_strings):
1382 Don't update size of array until after memory allocation succeeds,
1383 because xmalloc/xrealloc may not return.
0065d054
PE
1384 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1385 now that we have proper integer overflow checking.
1386 (record_overlay_string, overlay_strings): Catch overflows when
1387 calculating size of overlay_str_buf.
726e0ab1 1388
0065d054
PE
1389 * callproc.c (Fcall_process): Check for size overflow when
1390 calculating size of args2.
1391 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1392 Normally we prefer signed values, but sticking with ptrdiff_t would
1393 require adding more-complicated checks.
726e0ab1
PE
1394
1395 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1396 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1397 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1398 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1399
1400 * character.c (Fstring): Check for size-calculation overflow.
1401
1402 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1403 unnecessary integer overflow. Check for size overflow.
1404 (encode_coding_object): Don't update size until xmalloc succeeds.
1405
1406 * composite.c (get_composition_id): Check for overflow in glyph
1407 length calculations.
1408
1409 Integer and memory overflow fixes for display code.
1410 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1411 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1412 (scrolling_window): Check for overflow in size calculations.
1413 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1414 Don't assume glyph table len fits in int.
1415 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1416 (row_table_size): Now ptrdiff_t, not int.
1417 (scrolling_window): Avoid overflow in size calculations.
1418 Don't update size until allocation succeeds.
1419 * fns.c (concat): Check for overflow in size calculations.
1420 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1421 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1422 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1423
1424 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1425 (get_doc_string): Check for size calculation overflow.
1426 Don't update size until allocation succeeds.
1427 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1428 EMACS_INT, where ptrdiff_t will do.
1429 (Fsubstitute_command_keys): Check for string overflow.
1430
1431 * editfns.c (set_time_zone_rule): Don't assume environment length
1432 fits in int.
1433 (message_length): Now ptrdiff_t, not int.
1434 (Fmessage_box): Don't update size until allocation succeeds.
1435 Don't assume message length fits in int.
1436 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1437
0065d054
PE
1438 * emacs.c (main): Do not reallocate argv, since there is a null at
1439 the end that can be overwritten, and this way there's no need to
1440 worry about size-calculation overflow.
1441 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1442
1443 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1444 alloc succeeds.
1445 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1446
1447 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1448 (x_set_scroll_bar_width, x_figure_window_size):
1449 Check for integer overflow.
1450 (x_set_alpha): Do not assume XINT fits in int.
1451
1452 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1453 This is for the members text_lines, text_cols, total_lines, total_cols,
1454 where the system imposes an 'int' limit.
1455
1456 * fringe.c (Fdefine_fringe_bitmap):
1457 Don't update size until alloc works.
1458
1459 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1460 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1461
1462 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1463 Check for size-calculation overflow.
1464 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1465 do, as we prefer signed integers.
1466 (id_to_widget.max_size, id_to_widget.used)
1467 (xg_store_widget_in_map, xg_remove_widget_from_map)
1468 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1469 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1470 Use and return ptrdiff_t, not int.
1471 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1472 * gtkutil.h: Change prototypes to match the above.
1473
1474 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1475 are duplicate now that they've been promoted to lisp.h.
1476 (x_allocate_bitmap_record, x_alloc_image_color)
1477 (make_image_cache, cache_image, xpm_load):
1478 Don't update size until alloc is done.
1479 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1480 (x_detect_edges):
3256efce 1481 Check for size calculation overflow.
726e0ab1
PE
1482 (ct_colors_allocated_max): New constant.
1483 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1484 overflow.
3256efce 1485
726e0ab1
PE
1486 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1487 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1488 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1489 Use ptrdiff_t, not int, to count maps.
1490 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1491 calculations. Don't update size until allocation succeeds.
1492 Redo calculations to avoid overflow.
726e0ab1
PE
1493 * keyboard.h: Change prototypes to match the above.
1494
1495 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1496 to count maps.
1497 (current_minor_maps): Check for size calculation overflow.
1498 * keymap.h: Change prototypes to match the above.
1499
1500 * lread.c (read1, init_obarray): Don't update size until alloc done.
1501
1502 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1503 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1504
726e0ab1
PE
1505 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1506 Now ptrdiff_t, not int.
1507 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1508 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1509
1510 * process.c (Fnetwork_interface_list): Check for overflow
1511 in size calculation.
1512
1513 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1514
1515 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1516 overflow. Don't bother calling xmalloc when xrealloc will do.
1517
1518 * search.c (Freplace_match): Check for size calculation overflow.
1519 (Fset_match_data): Don't assume list lengths fit in 'int'.
1520
1521 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1522 for command line length. Do not attempt to address one before the
1523 beginning of an array, as that's not portable.
1524
1525 * term.c (max_frame_lines): Remove; unused.
1526 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1527 not int.
1528 (encode_terminal_code, calculate_costs): Check for size
1529 calculation overflow.
1530 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1531 table lengths and related sizes. Don't update size until alloc
1532 done. Redo calculations to avoid overflow.
1533 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1534
1535 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1536 subtracting pointers.
1537 (gobble_line): Check for overflow more carefully. Don't update size
1538 until alloc done.
1539
1540 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1541 Don't update size until alloc done.
1542 Redo size calculations to avoid overflow.
1543 Check for size calculation overflow.
0065d054 1544 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1545
1546 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1547 Use ptrdiff_t, not int, for sizes.
1548 (store_mode_line_noprop_char): Don't update size until alloc done.
1549
0065d054
PE
1550 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1551 Use ptrdiff_t, not int, for sizes.
1552 (Finternal_make_lisp_face, cache_face):
1553 Check for size calculation overflow.
1554 (cache_face): Treat size calculation overflows as if they were
1555 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1556
1557 * xfns.c (x_encode_text, x_set_name_internal)
1558 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1559 sizes, since they can exceed INT_MAX in size. Check for size
1560 calculation overflow.
1561
0065d054
PE
1562 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1563 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1564 Don't update size until alloc done.
1565
0065d054 1566 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1567 as sprintf is limited to int lengths.
1d526e2f 1568
252c5ee1
PE
1569 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1570 (X_LONG_MIN): New macros.
864d7ce7
PE
1571 Use them to make the following changes clearer.
1572 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1573 This change doesn't affect the value now, but it may help remind
1574 future maintainers not to raise the value too much later.
1575 (SELECTION_QUANTUM): Remove, replacing with ...
1576 (selection_quantum): ... new function, which avoids overflow.
1577 All uses changed.
1578 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1579 assumption that selection length fits in 'int'.
1580 (x_reply_selection_request, x_handle_selection_request)
1581 (x_get_window_property, receive_incremental_selection)
1582 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1583 (lisp_data_to_selection_data, clean_local_selection_data):
1584 Use ptrdiff_t, not int, to record length of selection.
1585 (x_reply_selection_request, x_get_window_property)
1586 (receive_incremental_selection, x_property_data_to_lisp):
1587 Redo calculations to avoid overflow.
1588 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1589 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1590 something.
1591 (x_get_window_property, receive_incremental_selection)
1592 (lisp_data_to_selection_data, x_property_data_to_lisp):
1593 Check for size-calculation overflow.
1594 (x_get_window_property, receive_incremental_selection)
1595 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1596 Don't store size until memory allocation succeeds.
1597 (x_get_window_property): Plug memory leak on memory exhaustion.
1598 Don't double-block input; malloc is safe here. Don't assume 2**34
1599 - 4 fits in unsigned long. Add an xassert to check
1600 XGetWindowProperty overflow. Be more careful about overflow
1601 calculations, and distinguish size from memory overflow better.
1602 (receive_incremental_selection): When tracing, don't assume
1603 unsigned int is less than INT_MAX.
1604 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1605 harmful) conversions of unsigned short to int.
1606 (lisp_data_to_selection_data): Don't assume that integers
1607 in the range -65535 through -1 fit in an X unsigned short.
1608 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1609 result parameters unless successful. Rely on cons_to_unsigned
1610 to report problems with elements; the old code wasn't right anyway.
1611 (x_check_property_data): Check for int overflow; we cannot use
1612 a wider type due to X limits.
1613 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1614
726e0ab1 1615 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1616
0065d054
PE
1617 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1618 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1619 (x_color_cells): Don't store size until memory allocation succeeds.
1620 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1621 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1622 (x_term_init): Don't assume length fits in int (sprintf is limited
1623 to int size).
bc18e09d 1624
ebfa62c0
PE
1625 Use ptrdiff_t for composition IDs.
1626 * character.c (lisp_string_width):
1627 * composite.c (composition_table_size, n_compositions)
1628 (get_composition_id, composition_gstring_from_id):
1629 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1630 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1631 * window.c (Frecenter):
1632 Use ptrdiff_t, not int, for composition IDs.
1633 * composite.c (get_composition_id): Check for integer overflow.
1634 * composite.h: Adjust prototypes to match the above changes.
1635
d3411f89
PE
1636 Use ptrdiff_t for hash table indexes.
1637 * category.c (hash_get_category_set):
1638 * ccl.c (ccl_driver):
1639 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1640 * coding.c (coding_system_charset_list, detect_coding_system):
1641 * coding.h (struct coding_system.id):
1642 * composite.c (get_composition_id, gstring_lookup_cache):
1643 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1644 * image.c (xpm_get_color_table_h):
1645 * lisp.h (hash_lookup, hash_put):
1646 * minibuf.c (Ftest_completion):
1647 Use ptrdiff_t for hash table indexes, not int (which is too
1648 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1649 32-bit --with-wide-int hosts).
1650
e097a6fa
PE
1651 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1652 Add a FIXME comment about memory leaks.
1653 (syms_of_charset): Don't assume xmalloc returns.
1654
5637687f
PE
1655 Don't assume that stated character widths fit in int.
1656 * character.c (Fchar_width, c_string_width, lisp_string_width):
1657 * character.h (CHAR_WIDTH):
1658 * indent.c (MULTIBYTE_BYTES_WIDTH):
1659 Use sanitize_char_width to avoid undefined and/or bad behavior
1660 with outlandish widths.
a66cfb1c 1661 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1662 now that we have two such functions. All uses changed.
1663 (sanitize_char_width): New inline function.
1664
a2271ba2
PE
1665 Don't assume that tab-width fits in int.
1666 * character.h (sanitize_width): New inline function.
1667 (SANE_TAB_WIDTH): New macro.
1668 (ASCII_CHAR_WIDTH): Use it.
1669 * indent.c (sane_tab_width): Remove. All uses replaced by
1670 SANE_TAB_WIDTH (current_buffer).
1671 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1672
18c52557
PE
1673 * fileio.c: Integer overflow issues with file modes.
1674 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1675
caeeedc1
PE
1676 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1677 Remove unreachable code.
1678 (read_hex, load_charset_map_from_file): Check for integer overflow.
1679
50849c52
PE
1680 * xterm.c: don't go over XClientMessageEvent limit
1681 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1682 (x_send_scroll_bar_event): Likewise. Check that the size does not
1683 exceed limits imposed by XClientMessageEvent, as well as the usual
1684 ptrdiff_t and size_t limits.
1685
b13995db
PE
1686 * keyboard.c: Overflow, signedness and related fixes.
1687 (make_lispy_movement): Use same integer type in forward decl
1688 that is used in the definition.
1689 (read_key_sequence, keyremap_step):
1690 Change bufsize argument back to int, undoing my 2011-03-30 change.
1691 We prefer signed types, and int is wide enough here.
1692 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1693 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1694 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1695 length, not size_t. Use ptrdiff_t for index, not int.
1696 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1697 possibility of integer overflow.
1698
13464394
PE
1699 Overflow, signedness and related fixes for images.
1700
1701 * dispextern.h (struct it.stack[0].u.image.image_id)
1702 (struct_it.image_id, struct image.id, struct image_cache.size)
1703 (struct image_cache.used, struct image_cache.ref_count):
1704 * gtkutil.c (update_frame_tool_bar):
1705 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1706 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1707 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1708 * nsmenu.m (update_frame_tool_bar):
1709 * xdisp.c (calc_pixel_width_or_height):
1710 * xfns.c (image_cache_refcount):
1711 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1712 on typical 64-bit hosts.
1713
1714 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1715 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1716 Omit unnecessary casts to int.
1717 (parse_image_spec): Check that integers fall into 'int' range
1718 when the callers expect that.
1719 (image_ascent): Redo ascent calculation to avoid int overflow.
1720 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1721 (lookup_image): Remove unnecessary tests.
1722 (xbm_image_p): Locals are now of int, not EMACS_INT,
1723 since parse_image_check makes sure they fit into int.
1724 (png_load, gif_load, svg_load_image):
1725 Prefer int to unsigned where either will do.
1726 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1727 old tiff_error_handler and tiff_warning_handler.
1728 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1729 stack buffer overflows. It uses only the features of vsnprintf
1730 that are common to both POSIX and native Microsoft.
1731 (tiff_error_handler, tiff_warning_handler): Use it.
1732 (tiff_load, gif_load, imagemagick_load_image):
1733 Don't assume :index value fits in 'int'.
1734 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1735 (imagemagick_load_image): Check that crop parameters fit into
1736 the integer types that MagickCropImage accepts. Don't assume
1737 Vimagemagick_render_type has a nonnegative value. Don't assume
1738 size_t fits in 'long'.
1739 (gs_load): Use printmax_t to print the widest integers possible.
1740 Check for integer overflow when computing image height and width.
1741
c11821d4
EZ
17422011-08-26 Eli Zaretskii <eliz@gnu.org>
1743
1744 * xdisp.c (redisplay_window): Don't force window start if point
1745 will be invisible in the resulting window. (Bug#9324)
1746
0c95fcf7
EZ
17472011-08-25 Eli Zaretskii <eliz@gnu.org>
1748
1749 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1750 the display spec is of the form `(space ...)'.
1751 (handle_display_spec): Return the value returned by
1752 handle_single_display_spec, not just 1 or zero.
1753 (handle_single_display_spec): If the display spec is of the form
1754 `(space ...)', and specifies display in the text area, return 2
1755 rather than 1.
fee65a97 1756 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1757 accurately, and prefer exact match for point under bidi.
1758 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1759
1760 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1761 into disp_prop; all users changed.
1762
1763 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1764 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1765 for the text covered by the display property.
1766
e4ed06f1
CY
17672011-08-25 Chong Yidong <cyd@stupidchicken.com>
1768
1769 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1770 Change return value to nil.
1771 (Frecord_buffer): Delete unused function.
1772
f67cdd7f
EZ
17732011-08-24 Eli Zaretskii <eliz@gnu.org>
1774
5980d4c6
EZ
1775 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1776 buffers, return left-to-right.
8610fe8b
EZ
1777 (set_cursor_from_row): Consider candidate row a win if its glyph
1778 represents a newline and point is on that newline. Fixes cursor
1779 positioning on the newline at EOL of R2L text within L2R
1780 paragraph, and vice versa.
1781 (try_cursor_movement): Check continued rows, in addition to
1782 continuation rows. Fixes unwarranted scroll when point enters a
1783 continued line of R2L text within an L2R paragraph, or vice versa.
1784 (cursor_row_p): Consider the case of point being equal to
1785 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1786 from the end of a short line to the beginning of a continued line
1787 of R2L text within L2R paragraph.
1788 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1789 composed characters.
5980d4c6 1790
f67cdd7f
EZ
1791 * bidi.c (bidi_check_type): Use xassert.
1792 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1793 members.
1794
bca633fb
EZ
17952011-08-23 Eli Zaretskii <eliz@gnu.org>
1796
1797 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1798 a character.
1799
4a5885a7
CY
18002011-08-23 Chong Yidong <cyd@stupidchicken.com>
1801
1802 * nsfont.m (ns_otf_to_script): Fix typo.
1803
0902a04e
KH
18042011-08-22 Kenichi Handa <handa@m17n.org>
1805
1806 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1807 extra slot even if the purpose is char-code-property-table.
1808
1a2e6670
EZ
18092011-08-23 Eli Zaretskii <eliz@gnu.org>
1810
8ddde651
EZ
1811 * xdisp.c (redisplay_window): When computing centering_position,
1812 account for the height of the header line. (Bug#8874)
1813
425cc014
EZ
1814 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1815 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1816 candidate is selected by the mouse, and that candidate has a
1817 composed character under the mouse.
1818
1a2e6670
EZ
1819 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1820 coordinates reported by pos-visible-in-window-p for a composed
1821 character in column zero.
1822
8b76d6f8
SM
18232011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1824
1825 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1826
dac347dd
EZ
18272011-08-22 Eli Zaretskii <eliz@gnu.org>
1828
1829 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1830 consider it a hit if to_charpos is anywhere in the range of the
1831 composed buffer positions.
1832
e013fb34
CY
18332011-08-22 Chong Yidong <cyd@stupidchicken.com>
1834
1835 * image.c (gif_load): Don't assume that each subimage has the same
1836 dimensions as the base image. Handle disposal method that is
1837 "undefined" by the gif spec (Bug#9335).
1838
bd1ba3e8
CY
18392011-08-20 Chong Yidong <cyd@stupidchicken.com>
1840
1841 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1842 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1843
54a1215b
EZ
18442011-08-19 Eli Zaretskii <eliz@gnu.org>
1845
823564e5
EZ
1846 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1847 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1848 from an Org mode buffer to a Speedbar frame.
1849
54a1215b
EZ
1850 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1851 a composition, take its buffer position from IT->cmp_it.charpos.
1852 Fixes cursor positioning at the beginning of a line that begins
1853 with a composed character.
1854
9778ebcc
EZ
18552011-08-18 Eli Zaretskii <eliz@gnu.org>
1856
0be6ee06
EZ
1857 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1858 character bidirectional type, use STRONG_L instead. Fixes crashes
1859 in a buffer produced by `describe-categories'.
1860
9778ebcc
EZ
1861 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1862 members before the level stack, so they would be saved and
1863 restored when copying iterator state. Fixes incorrect reordering
1864 around TABs covered by display properties.
1865
156bffbe
AS
18662011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1867
6b02f655 1868 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1869
72ad093b
CY
18702011-08-17 Chong Yidong <cyd@stupidchicken.com>
1871
1872 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1873 (internal_condition_case_2, internal_condition_case_n):
1874 Remove unnecessary aborts (Bug#9081).
72ad093b 1875
35774242
EZ
18762011-08-17 Eli Zaretskii <eliz@gnu.org>
1877
1878 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1879 has no `load' handler, try opening the file locally. (Bug#9311)
1880
db76dd85
KB
18812011-08-16 Ken Brown <kbrown@cornell.edu>
1882
1883 * gmalloc.c: Expand comment.
1884
b215eee5
EZ
18852011-08-16 Eli Zaretskii <eliz@gnu.org>
1886
1887 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1888 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1889
a4579d33
KB
18902011-08-16 Ken Brown <kbrown@cornell.edu>
1891
1892 Fix memory allocation problems in Cygwin build (Bug#9273).
1893
1894 * unexcw.c ( __malloc_initialized): Declare external variable.
1895 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1896
8b76d6f8
SM
1897 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1898 New variables.
a4579d33
KB
1899 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1900 dumped emacs.
1901 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1902 in the static heap.
1903 [CYGWIN] (special_realloc): New function.
1904 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1905 requests to realloc storage in the static heap.
1906
3ebec551
PE
19072011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 * bidi.c (bidi_initialize): Remove unused local.
1910
9fd8be00
EZ
19112011-08-15 Eli Zaretskii <eliz@gnu.org>
1912
6b02f655
SM
1913 * bidimirror.h:
1914 * biditype.h: Remove file.
1915 * makefile.w32-in ($(BLD)/bidi.$(O)):
1916 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1917
1918 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1919
1920 * chartab.c: Improve commentary for the uniprop_table API.
1921
32413314
EZ
1922 * bidi.c (bidi_paragraph_init): Support zero value of
1923 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1924 (bidi_initialize): Use uniprop_table instead of including
1925 biditype.h and bidimirror.h.
32413314 1926
9fd8be00
EZ
1927 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1928 coordinates of the iterator when restoring from ppos_it.
1929 (Bug#9296)
1930
5cf2b69b
KH
19312011-08-14 Kenichi Handa <handa@m17n.org>
1932
1933 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1934 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1935
daf17d00
EZ
19362011-08-14 Eli Zaretskii <eliz@gnu.org>
1937
1938 * xdisp.c (move_it_in_display_line_to): Don't invoke
1939 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1940 ppos_it. Fixes vertical cursor motion when line beginning is
1941 covered by an image. (Bug#9296)
1942
08e3161a
JD
19432011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1944
1945 * nsterm.h (ns_run_ascript): Declare.
1946 (NSAPP_DATA2_RUNASSCRIPT): Define.
1947
1948 * nsfns.m (as_script, as_result, as_status): New static variables.
1949 (ns_run_ascript): New function.
5e617bc2 1950 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1951 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1952 the event loop. Get status from as_status (Bug#7276).
1953
1954 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1955 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1956 the event loop (Bug#7276).
1957
a3720aa2
AS
19582011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1959
1960 * gnutls.c (QCgnutls_bootprop_priority)
1961 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1962 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1963 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1964 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1965 (QCgnutls_bootprop_verify_hostname_error)
1966 (QCgnutls_bootprop_callbacks_verify): Rename from
1967 Qgnutls_bootprop_..., all uses changed.
1968
1969 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1970 uses changed.
1971
0a0d27fb
PE
19722011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1973
19d5c50c
PE
1974 * xfaces.c (Qframe_set_background_mode): Now static.
1975 * dispextern.h (Qframe_set_background_mode): Remove decl.
1976
0a0d27fb
PE
1977 * process.c (Fnetwork_interface_info): Declare local only if needed.
1978
377538cb
JD
19792011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1980
1981 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1982 (Fnetwork_interface_list): Allocate in increments of bytes instead
1983 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1984 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1985 sockaddr.
1986 (struct ifflag_def): notrailers is smart on OSX.
1987 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1988 Get hardware address with getifaddrs if available.
1989
08fff70c
EZ
19902011-08-12 Eli Zaretskii <eliz@gnu.org>
1991
1992 * xdisp.c (iterate_out_of_display_property): xassert that
1993 IT->position is set to within IT->object's boundaries. Break from
1994 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1995 when IT->position is set up wrongly due to some bug.
1996 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1997 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1998 entry. Force push_it to save on the stack the current
1999 buffer/string position, to be restored by pop_it. Fix flags in
2000 the iterator structure wrt the object coming from a display
2001 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2002 properties. (Bug#9284)
2003
7be1c708 20042011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2005
7be1c708
CY
2006 * fontset.c (fontset_get_font_group): Add proper type checks.
2007 (Bug#9172)
aac0c6e3 2008
7be1c708 20092011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2010
7be1c708
CY
2011 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2012 and LC_VERSION_MIN_MACOSX.
2013 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2014 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2015
97bb72a6
EZ
20162011-08-08 Eli Zaretskii <eliz@gnu.org>
2017
2018 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2019 no-display-properties-and-no-overlays under bidi display.
2020 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2021 properties and overlays.
97bb72a6 2022
d5617611
CY
20232011-08-08 Chong Yidong <cyd@stupidchicken.com>
2024
37e11a63
CY
2025 * editfns.c (Fset_time_zone_rule): Document relationship with the
2026 setenv function.
2027
d5617611
CY
2028 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2029 the font entity extracted from the cache (Bug#8109).
2030
58872834
CY
20312011-08-07 Chong Yidong <cyd@stupidchicken.com>
2032
2033 * composite.c (autocmp_chars): Don't reset point. That is done by
2034 restore_point_unwind (Bug#5984).
2035
75bfc667
JL
20362011-08-07 Juri Linkov <juri@jurta.org>
2037
2038 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2039 to show the arg `TIME' instead of `TIMEVAL'.
2040
d1410150
EZ
20412011-08-06 Eli Zaretskii <eliz@gnu.org>
2042
2043 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2044 display property strides EOL and includes a newline, as in
2045 longlines-mode. (Bug#9254)
75b771e4
EZ
2046 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2047 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2048
2049 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2050 is non-zero, even if the data buffer is NULL. Fixes a crash in
2051 vertical-motion with longlines-mode. (Bug#9254)
2052
35928349
EZ
20532011-08-05 Eli Zaretskii <eliz@gnu.org>
2054
ec7cc85b
EZ
2055 * bidi.c <bidi_cache_total_alloc>: Now static.
2056 (bidi_initialize): Initialize bidi_cache_total_alloc.
2057
8b76d6f8 2058 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2059 cache. (Bug#9221)
2060
2061 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2062 amount allocated this far in `bidi_cache_total_alloc'.
2063 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2064 non-zero, only free the data buffer without restoring the cache
2065 contents. All callers changed.
2066
2067 * dispextern.h (bidi_unshelve_cache): Update prototype.
2068
2069 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2070 (move_it_in_display_line, move_it_to)
2071 (move_it_vertically_backward, move_it_by_lines): Replace the call
2072 to xfree to an equivalent call to bidi_unshelve_cache.
2073 (move_it_in_display_line_to): Fix logic of returning
412b6358 2074 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2075
e2e2423b
EZ
20762011-08-05 Eli Zaretskii <eliz@gnu.org>
2077
2078 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2079 came from a string character with a `cursor' property. (Bug#9229)
2080
ae9e757a
JD
20812011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2082
2083 * Makefile.in (LIB_PTHREAD): New variable.
2084 (LIBES): Add LIB_PTHREAD (Bug#9216).
2085
2086 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2087 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2088
213bd7f2
AS
20892011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2090
6b02f655 2091 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2092
99aaf75f
JD
20932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2094
2095 * xterm.c (x_find_topmost_parent): New function.
2096 (x_set_frame_alpha): Find topmost parent window with
2097 x_find_topmost_parent and set the property there also (bug#9181).
2098 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2099
c74e9d86
PE
21002011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2101
2102 * callproc.c (Fcall_process): Avoid vfork clobbering
2103 the local vars buffer, coding_systems, current_dir.
2104
640c8776
SM
21052011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2106
2107 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2108
f26d0e4c
PE
21092011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2110
8a10d76c
PE
2111 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2112 so that it is not optimized away.
2113
f26d0e4c
PE
2114 * xdisp.c (compute_display_string_pos): Remove unused local.
2115
55439c61
EZ
21162011-08-02 Eli Zaretskii <eliz@gnu.org>
2117
2118 Fix slow cursor motion and scrolling in large buffers with
2119 selective display, like Org Mode buffers. (Bug#9218)
2120
2121 * dispextern.h (struct bidi_it): New member disp_prop_p.
2122
2123 * xdisp.c: Remove one-slot cache of display string positions.
2124 (compute_display_string_pos): Accept an additional argument
5e617bc2 2125 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2126 for a display string or property. If found, set DISP_PROP_P
2127 non-zero.
2128
2129 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2130 DISP_PROP_P, and pass it to compute_display_string_pos.
2131 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2132 non-zero. All callers of bidi_fetch_char changed.
2133
fb33fa43
SM
21342011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2135
2136 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2137
b099e063
DM
21382010-12-03 Don March <don@ohspite.net>
2139
2140 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2141 last character M-[char] is translated to ESC [char] (bug#7541).
2142
5cc7f7af
KH
21432011-08-02 Kenichi Handa <handa@m17n.org>
2144
d0fffa3f 2145 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2146
2147 * chartab.c (uniprop_table): Make it non-static.
2148
525d5e6e
EZ
21492011-08-01 Eli Zaretskii <eliz@gnu.org>
2150
2151 * xdisp.c (forward_to_next_line_start): Accept additional argument
2152 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2153 on the newline.
2154 (reseat_at_next_visible_line_start): Use the bidi iterator state
2155 returned by forward_to_next_line_start to restore the state of
2156 it->bidi_it after backing up to previous newline. (Bug#9212)
2157
31011111
AS
21582011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2159
2160 * regex.c (re_comp): Protoize.
2161 (re_exec): Fix return type.
2162 (regexec): Fix type of `ret'. (Bug#9203)
2163
476371c4
PE
21642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2165
e5d76069
PE
2166 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2167 This is needed if max-image-size is a floating-point number.
2168
9a79b20c
AS
21692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2170
2171 * print.c (print_object): Print empty symbol as ##.
2172
2173 * lread.c (read1): Read ## as empty symbol.
2174
d8c2fa78
AA
21752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2176
2177 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2178 setting frame foreground color (Bug#9175).
2179 (x_set_background_color): Likewise.
2180
ffe57a7a
AA
2181 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2182 contents (Bug#9176).
2183 (EmacsTooltip -init): Remove bezels and add shadows to
2184 tooltip windows.
2185
bf3492a5
AA
2186 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2187 or scroll bar (Bug#8470).
2188
d55e9c53
AA
2189 * nsfont.m (nsfont_open): Remove assignment to voffset and
2190 unnecessary vars hshink, expand, hd, full_height, min_height.
2191 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2192
2193 * nsterm.h (nsfont_info): Remove voffset field.
2194
d8c2fa78 21952011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2196
2197 Implement strike-through and overline on NextStep (Bug#8863).
2198
2199 * nsfont.m (nsfont_open): Use underline position provided by font,
2200 instead of hard-coded value of 2.
2201 (nsfont_draw): Call ns_draw_text_decoration instead.
2202
2203 * nsterm.h: Add declaration for ns_draw_text_decoration.
2204
2205 * nsterm.m (ns_draw_text_decoration): New function for drawing
2206 underline, overline, and strike-through.
2207 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2208 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2209 accommodate underlining, etc.
4843aac3 2210
4cc60b9b
EZ
22112011-07-28 Eli Zaretskii <eliz@gnu.org>
2212
bc7ece87
EZ
2213 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2214 default.
4cc60b9b 2215
476371c4
PE
22162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2217
66606eea
PE
2218 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2219 Without this fix, if a signal arrives just after memory fills up,
2220 'malloc' might be invoked reentrantly.
2221
476371c4
PE
2222 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2223 In other words, assume that every image size is allowed, on non-X
2224 hosts. This assumption is probably wrong, but it lets Emacs compile.
2225
f3fcc40d
AS
22262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2227
2228 * regex.c (re_iswctype): Convert return values to boolean.
2229
350c992f
EZ
22302011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2231
2232 * xdisp.c (compute_display_string_pos): Don't use cached display
2233 string position if the buffer had its restriction changed.
2234 (Bug#9184)
2235
5266b4bb
PE
22362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2239
2573a837 22402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2241
41f55ccd 2242 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2243
39e378da
PE
2244 * bidi.c: Integer size and overflow fixes.
2245 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2246 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2247 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2248 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2249 (bidi_find_other_level_edge):
2250 Use ptrdiff_t instead of EMACS_INT where either will do.
2251 This works better on 32-bit hosts configured --with-wide-int.
2252 (bidi_cache_ensure_space): Check for size-calculation overflow.
2253 Use % rather than repeated addition, for better worst-case speed.
2254 Don't set bidi_cache_size until after xrealloc returns, because it
2255 might not return.
2256 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2257 (bidi_cache_ensure_space): Also check that the bidi cache size
2258 does not exceed that of the largest Lisp string or buffer. See Eli
2259 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2260
5e927815
PE
2261 * alloc.c (__malloc_size_t): Remove.
2262 All uses replaced by size_t. See Andreas Schwab's note
2263 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2264
ca4aa935
PE
2265 * image.c: Improve checking for integer overflow.
2266 (check_image_size): Assume that f is nonnull, since
2267 it is always nonnull in practice. This is one less thing to
2268 worry about when checking for integer overflow later.
2269 (x_check_image_size): New function, which checks for integer
2270 overflow issues inside X.
2271 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2272 This removes the need for a memory_full check.
2273 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2274 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2275 (xbm_read_bitmap_data): Change locals back to 'int', since
2276 their values must fit in 'int'.
2277 (xpm_load_image, png_load, tiff_load):
2278 Invoke x_create_x_image_and_pixmap earlier,
2279 to avoid much needless work if the image is too large.
2280 (tiff_load): Treat overly large images as if
2281 x_create_x_image_and_pixmap failed, not as malloc failures.
2282 (gs_load): Use x_check_image_size.
2283
5f8f9cc2
PE
2284 * gtkutil.c: Omit integer casts.
2285 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2286 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2287
5adf60bc
PE
2288 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2289
c8907a93
PE
2290 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2291 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2292 would wrongly return t on a 64-bit host.
2293
e3c25c68
PE
2294 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2295 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2296 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2297 and therefore cause GCC to emit a bogus diagnostic in some cases.
2298
3f791afe
PE
2299 * image.c: Integer signedness and overflow and related fixes.
2300 This is not an exhaustive set of fixes, but it's time to
2301 record what I've got.
2302 (lookup_pixel_color, check_image_size): Remove redundant decls.
2303 (check_image_size): Don't assume that arbitrary EMACS_INT values
2304 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2305 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2306 (tiff_load, imagemagick_load_image):
2307 Check for overflow in size calculations.
2308 (x_create_x_image_and_pixmap): Remove unnecessary test for
2309 xmalloc returning NULL; that can't happen.
2310 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2311 (xpm_color_bucket): Use better integer hashing function.
2312 (xpm_cache_color): Don't possibly over-allocate memory.
2313 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2314 (gif_memory_source):
2315 Use ptrdiff_t, not int or size_t, to record sizes.
2316 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2317 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2318 either works, as we prefer signed integers.
2319 (tiff_read_from_memory, tiff_write_from_memory):
2320 Return tsize_t, not size_t, since that's what the TIFF API wants.
2321 (tiff_read_from_memory): Don't fail simply because the read would
2322 go past EOF; instead, return a short read.
2323 (tiff_load): Omit no-longer-needed casts.
2324 (Fimagemagick_types): Don't assume size fits into 'int'.
2325
3cc5a532
PE
2326 Improve hashing quality when configured --with-wide-int.
2327 * fns.c (hash_string): New function, taken from sxhash_string.
2328 Do not discard information about ASCII character case; this
2329 discarding is no longer needed.
2330 (sxhash-string): Use it. Change sig to match it. Caller changed.
2331 * lisp.h: Declare it.
2332 * lread.c (hash_string): Remove, since we now use fns.c's version.
2333 The fns.c version returns a wider integer if --with-wide-int is
2334 specified, so this should help the quality of the hashing a bit.
2335
b312a492
PE
2336 * emacs.c: Integer overflow minor fix.
2337 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2338 Define only if GNU_LINUX.
2339 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2340
dfd153ae
PE
2341 * dispnew.c: Integer signedness and overflow fixes.
2342 Remove unnecessary forward decls, that were a maintenance hassle.
2343 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2344 All uses changed.
2345 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2346 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2347 (prepare_desired_row, line_draw_cost):
2348 Use int, not unsigned, where either works.
2349 (save_current_matrix, restore_current_matrix):
2350 Use ptrdiff_t, not size_t, where either works.
2351 (init_display): Check for overflow more accurately, and without
2352 relying on undefined behavior.
2353
a81d11a3
PE
2354 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2355 Remove, replacing with the new symbols in lisp.h. All uses changed.
2356 * fileio.c (make_temp_name):
2357 * filelock.c (lock_file_1, lock_file):
2358 * xdisp.c (message_dolog):
2359 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2360 Use pMd etc. instead.
2361 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2362 replacing the pWIDE etc. symbols removed from editfns.c.
2363
3300e6fd
PE
2364 * keyboard.h (num_input_events): Now uintmax_t.
2365 This is (very slightly) less likely to mess up due to wraparound.
2366 All uses changed.
2367
fd05c7e9
PE
2368 * buffer.c: Integer signedness fixes.
2369 (alloc_buffer_text, enlarge_buffer_text):
2370 Use ptrdiff_t rather than size_t when either will do, as we prefer
2371 signed integers.
2372
903fe15d
PE
2373 * alloc.c: Integer signedness and overflow fixes.
2374 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2375 (__malloc_size_t): Default to size_t, not to int.
2376 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2377 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2378 Prefer ptrdiff_t to size_t when either would do, as we prefer
2379 signed integers.
2380 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2381 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2382 Now const. Initialize with values that are in range even if char
2383 is signed.
2384 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2385 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2386 These functions do the right thing with sizes > 2**32.
2387 (check_depth): Now ptrdiff_t, not int.
2388 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2389 Adjust to new way of storing sizes. Check for size overflow bugs
2390 in rest of code.
2391 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2392 slightly wrong anyway, as it missed one instance of
2393 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2394 (refill_memory_reserve): Omit needless cast to size_t.
2395 (mark_object_loop_halt): Mark as externally visible.
2396
ac82cc6a
PE
2397 * xselect.c: Integer signedness and overflow fixes.
2398 (Fx_register_dnd_atom, x_handle_dnd_message):
2399 Use ptrdiff_t, not size_t, since we prefer signed.
2400 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2401 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2402 x_dnd_atoms_size and x_dnd_atoms_length.
2403
c2d1e36d
PE
2404 * doprnt.c: Prefer signed to unsigned when either works.
2405 * eval.c (verror):
2406 * doprnt.c (doprnt):
2407 * lisp.h (doprnt):
2408 * xdisp.c (vmessage):
2409 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2410 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2411 prefer signed arithmetic to avoid comparison confusion.
2412 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2413 but is a bit tricky.
2414
0e926e56
PE
2415 Assume freestanding C89 headers, string.h, stdlib.h.
2416 * data.c, doprnt.c, floatfns.c, print.c:
2417 Include float.h unconditionally.
2418 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2419 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2420 * regex.c: Likewise for stddef.h, string.h.
2421 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2422 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2423 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2424 (STDC_HEADERS): Remove obsolete defines.
2425 * sysdep.c: Include limits.h unconditionally.
2426
9cfdb3ec
PE
2427 Assume support for memcmp, memcpy, memmove, memset.
2428 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2429 * regex.c (memcmp, memcpy):
2430 Remove; we assume C89 now.
2431
2432 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2433 (__malloc_safe_bcopy): Remove; no longer needed.
2434
cf950e6b 2435 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2436 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2437 well either way, and we prefer signed to unsigned.
2438
dbf38e02
LMI
24392011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2440
2441 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2442 closes the connection while we're reading (bug#9182).
2443
d6f0886c 24442011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2445
d6f0886c
JD
2446 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2447 are specified (Bug#9168).
24e0f6b1 2448
2eb1f9e6
PE
24492011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2450
2451 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2452 Found by GCC static checking and --with-wide-int on a 32-bit host.
2453
22381272 24542011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2455
2456 * xdisp.c (compute_display_string_pos): Fix logic of caching
2457 previous display string position. Initialize cached_prev_pos to
2458 -1. Fixes slow-down at the beginning of a buffer.
2459
f25e39b4
EZ
24602011-07-24 Eli Zaretskii <eliz@gnu.org>
2461
2462 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2463 for attrs[LFACE_FONTSET_INDEX].
2464
04c4b52e
PE
24652011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 * xml.c (parse_region): Remove unused local
2468 that was recently introduced.
2469
c1734fbd
EZ
24702011-07-23 Eli Zaretskii <eliz@gnu.org>
2471
be18c5a5
EZ
2472 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2473 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2474
c1734fbd
EZ
2475 * xdisp.c (move_it_in_display_line_to): Record the best matching
2476 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2477 exit if none of the characters scanned was an exact match.
2478 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2479 when exact match is impossible due to invisible text, and the
2480 lines are truncated.
2481
a258d627
JD
24822011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2483
2484 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2485 for OSX >= 10.7.
2486
b6d5a689
EZ
24872011-07-22 Eli Zaretskii <eliz@gnu.org>
2488
0f74f785
EZ
2489 Fix a significant slow-down of cursor motion with C-n, C-p,
2490 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2491 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2492 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2493 (next_element_from_buffer): Call compute_stop_pos_backwards to
2494 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2495 base_level_stop.
2496 (reseat): Don't look for prev_stop, as that could mean a very long
2497 run.
2498 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2499 <cached_disp_overlay_modiff>: Cache for last found display string
2500 position.
551918c1 2501 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2502 about the same buffer in the same area of character positions, and
2503 the buffer wasn't changed since the time the display string
2504 position was cached.
551918c1 2505
b2d0c91a
EZ
25062011-07-22 Eli Zaretskii <eliz@gnu.org>
2507
2508 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2509 is an integer, which is important for empty lines. (Bug#9149)
2510
043604ee
CY
25112011-07-22 Chong Yidong <cyd@stupidchicken.com>
2512
2513 * frame.c (Fmodify_frame_parameters): In tty case, update the
2514 default face if necessary (Bug#4238).
2515
da4adb04
CY
25162011-07-21 Chong Yidong <cyd@stupidchicken.com>
2517
2518 * editfns.c (Fstring_to_char): No need to explain what a character
2519 is in the docstring (Bug#6576).
2520
9abd0532
LMI
25212011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2522
2523 * xml.c (parse_region): Make sure we always return a tree.
2524
36881d16
HK
25252011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2526
2527 * xml.c (parse_region): If a document contains only comments,
2528 return that, too.
2529
1e98674d
LMI
25302011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2531
2532 * xml.c (make_dom): Return comments, too.
2533
590bd467
PE
25342011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 Port to OpenBSD.
2537 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2538 and the surrounding thread.
2539 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2540 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2541 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2542 timer goes off.
2543 * s/openbsd.h (BROKEN_SIGIO): Define.
2544 * unexelf.c (unexec) [__OpenBSD__]:
2545 Don't update the .mdebug section of the Alpha COFF symbol table.
2546
f41628b2
LMI
25472011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2548
2549 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2550 (bug#8460).
2551
b59b67c5
PE
25522011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2553
15e3a074
PE
2554 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2555 This fixes some race conditions on the permissions of any newly
2556 created file.
2557
41bed37d
PE
2558 * alloc.c (valid_pointer_p): Use pipe, not open.
2559 This fixes some permissions issues when debugging.
2560
b59b67c5
PE
2561 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2562 If fchown fails to set both uid and gid, try to set just gid,
2563 as that is sometimes allowed. Adjust the file's mode to eliminate
2564 setuid or setgid bits that are inappropriate if fchown fails.
2565
925a6be7
SM
25662011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2567
2568 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2569 to compare Lisp_Objects.
2570 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2571 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2572 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2573
52968808
AS
25742011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2575
0a6a104b
AS
2576 * lread.c (read_integer): Unread even EOF character.
2577 (read1): Likewise. Properly record start position of symbol.
2578
52968808
AS
2579 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2580 symbol character follows.
2581
9e381cdd
PE
25822011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2583
2584 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2585 This works around a problem with the previous change to Fcopy_file.
2586 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2587 and without this change, GCC might complain about discarding
2588 fchown's return value.
2589
b5641435
JB
25902011-07-16 Juanma Barranquero <lekktu@gmail.com>
2591
2592 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2593
a8031457
PE
25942011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2597
dd889327
LMI
25982011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2599
750c33f7
LMI
2600 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2601 it's used from the C level.
2602
dd889327
LMI
2603 * process.c: Use the same condition for POLL_FOR_INPUT in both
2604 keyboard.c and process.c (bug#1858).
2605
87e86684
LM
26062011-07-09 Lawrence Mitchell <wence@gmx.li>
2607
2608 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2609 (Fgnutls_boot): Use it.
2610
64348f40
AS
26112011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2612
2613 * doc.c (Fsubstitute_command_keys): Revert last change.
2614
1d698799
LMI
26152011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2616
f863868c
LMI
2617 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2618 quotes the next character, and doesn't affect other longer
2619 sequences (bug#8935).
2620
1d698799
LMI
2621 * lread.c (syms_of_lread): Clarify that is isn't only
2622 `eval-buffer' and `eval-defun' that's affected by
2623 `lexical-binding' (bug#8460).
2624
aa4b6df6
EZ
26252011-07-15 Eli Zaretskii <eliz@gnu.org>
2626
2627 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2628 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2629
5d856da6
PE
26302011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2631
ad6042bb
PE
2632 Fix minor problems found by static checking.
2633 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2634 (elsz): Now a signed constant, not a size_t var. We prefer signed
2635 types to unsigned, to avoid integer comparison confusion. Without
2636 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2637 "cannot optimize loop, the loop counter may overflow", a symptom
2638 of the confusion.
f00bbb22 2639 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2640 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2641
6468f31c
LMI
26422011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2643
49080b10
LMI
2644 * search.c (Fre_search_backward): Mention `case-fold-search' in
2645 all the re_search_* functions (bug#8138).
2646
6468f31c
LMI
2647 * keyboard.c (Fopen_dribble_file): Document when the file is
2648 closed (bug#8056).
2649
c965adc5
EZ
26502011-07-14 Eli Zaretskii <eliz@gnu.org>
2651
df9733bf
EZ
2652 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2653 bidi_cache_idx.
2654
0bb23927
EZ
2655 Support bidi reordering of display and overlay strings.
2656 * xdisp.c (compute_display_string_pos)
2657 (compute_display_string_end): Accept additional argument STRING.
2658 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2659 (reseat_to_string): Initialize bidi_it->string.s and
2660 bidi_it->string.schars.
2661 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2662 NULL (avoids a crash in bidi_paragraph_init).
2663 Initialize itb.string.lstring.
0bb23927
EZ
2664 (init_iterator): Call bidi_init_it only of a valid
2665 buffer position was specified. Initialize paragraph_embedding to
2666 L2R.
2667 (reseat_to_string): Initialize the bidi iterator.
2668 (display_string): If we need to ignore text properties of
2669 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2670 original value of -1 will not work with bidi.)
2671 (compute_display_string_pos): First arg is now struct
2672 `text_pos *'; all callers changed. Support display properties on
2673 Lisp strings.
2674 (compute_display_string_end): Support display properties on Lisp
2675 strings.
2676 (init_iterator, reseat_1, reseat_to_string): Initialize the
2677 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2678 when iterating on a string not from display properties).
640c8776
SM
2679 (compute_display_string_pos, compute_display_string_end):
2680 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2681 arrow keys.
2682 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2683 base_level_stop; instead, set base_level_stop to BEGV.
2684 Fixes crashes in vertical-motion.
0bb23927
EZ
2685 (next_element_from_buffer): Improve commentary for when
2686 the iterator is before prev_stop.
2687 (init_iterator): Initialize bidi_p from the default value of
2688 bidi-display-reordering, not from buffer-local value. Use the
2689 buffer-local value only if initializing for buffer iteration.
2690 (handle_invisible_prop): Support invisible properties on strings
2691 that are being bidi-reordered.
2692 (set_iterator_to_next): Support bidi reordering of C strings and
2693 Lisp strings.
2694 (next_element_from_string): Support bidi reordering of Lisp
2695 strings.
2696 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2697 (display_string): Support display of R2L glyph rows.
2698 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2699 (init_iterator): Don't initialize it->bidi_p for strings
2700 here.
2701 (reseat_to_string): Initialize it->bidi_p for strings here.
2702 (next_element_from_string, next_element_from_c_string)
2703 (next_element_from_buffer): Add xassert's for correspondence
2704 between IT's object being iterated and it->bidi_it.string
2705 structure.
2706 (face_before_or_after_it_pos): Support bidi iteration.
2707 (next_element_from_c_string): Handle the case of the first string
2708 character that is not the first one in the visual order.
2709 (get_visually_first_element): New function, refactored from common
2710 parts of next_element_from_buffer, next_element_from_string, and
2711 next_element_from_c_string.
2712 (tool_bar_lines_needed, redisplay_tool_bar)
2713 (display_menu_bar): Force left-to-right direction. Add a FIXME
2714 comment for making that be controlled by a user option.
2715 (push_it, pop_it): Save and restore the state of the
2716 bidi iterator. Save and restore the bidi_p flag.
2717 (pop_it): Iterate out of display property for string iteration as
2718 well.
2719 (iterate_out_of_display_property): Support iteration over strings.
2720 (handle_single_display_spec): Set up it->bidi_it for iteration
2721 over a display string, and call bidi_init_it.
2722 (handle_single_display_spec, next_overlay_string)
2723 (get_overlay_strings_1, push_display_prop): Set up the bidi
2724 iterator for displaying display or overlay strings.
2725 (forward_to_next_line_start): Don't use the shortcut if
2726 bidi-iterating.
2727 (back_to_previous_visible_line_start): If handle_display_prop
2728 pushed the iterator stack, restore the internal state of the bidi
2729 iterator by calling bidi_pop_it same number of times.
2730 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2731 and we are bidi-iterating, don't decrement the iterator position;
2732 instead, set the first_elt flag in the bidi iterator, to produce
2733 the same effect.
2734 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2735 (push_display_prop): xassert that we are iterating a buffer.
2736 (push_it, pop_it): Save and restore paragraph_embedding member.
2737 (handle_single_display_spec, next_overlay_string)
2738 (get_overlay_strings_1, reseat_1, reseat_to_string)
2739 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2740 correctly. Don't assume unibyte strings are not bidi-reordered.
2741 (compute_display_string_pos)
2742 (compute_display_string_end): Fix handling the case of C string.
2743 (push_it, pop_it): Save and restore from_disp_prop_p.
2744 (handle_single_display_spec, push_display_prop): Set the
2745 from_disp_prop_p flag.
2746 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2747 (pop_it): Call iterate_out_of_display_property only if we are
2748 popping after iteration over a string that came from a display
2749 property. Fix a typo in popping stretch info. Add an assertion
2750 for verifying that the iterator position is in sync with the bidi
2751 iterator.
2752 (handle_single_display_spec, get_overlay_strings_1)
2753 (push_display_prop): Fix initialization of paragraph direction for
2754 string when that of the parent object is not yet determined.
2755 (reseat_1): Call bidi_init_it to resync the bidi
2756 iterator with IT's position. (Bug#7616)
2757 (find_row_edges): If ROW->start.pos gives position
2758 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2759 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2760 Reset the from_disp_prop_p flag.
2761 (SAVE_IT, RESTORE_IT): New macros.
2762 (pos_visible_p, face_before_or_after_it_pos)
2763 (back_to_previous_visible_line_start)
2764 (move_it_in_display_line_to, move_it_in_display_line)
2765 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2766 (try_scrolling, redisplay_window, display_line): Use them when
2767 saving a temporary copy of the iterator and restoring it back.
2768 (back_to_previous_visible_line_start, reseat_1)
2769 (init_iterator): Empty the bidi cache "stack".
2770 (move_it_in_display_line_to): If iterator ended up at
2771 EOL, but we never saw any buffer positions smaller than
2772 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2773 motion in bidi-reordered lines.
2774 (move_it_in_display_line_to): Record prev_method and prev_pos
2775 immediately before the call to set_iterator_to_next. Fixes cursor
2776 motion in bidi-reordered lines with stretch glyphs and strings
2777 displayed in margins. (Bug#8133) (Bug#8867)
2778 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2779 TO_CHARPOS.
640c8776
SM
2780 (pos_visible_p): Support positions in bidi-reordered lines.
2781 Save and restore bidi cache.
0bb23927
EZ
2782
2783 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2784 (bidi_paragraph_info): Delete unused struct.
2785 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2786 (bidi_cache_start): New variable.
2787 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2788 to zero.
2789 (bidi_cache_fetch_state, bidi_cache_search)
2790 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2791 (bidi_cache_find, bidi_peek_at_next_level)
2792 (bidi_level_of_next_char, bidi_find_other_level_edge)
2793 (bidi_move_to_visually_next): Compare cache index with
2794 bidi_cache_start rather than with zero.
2795 (bidi_fetch_char): Accept new argument STRING; all callers
2796 changed. Support iteration over a string. Support strings with
2797 display properties. Support unibyte strings. Fix the type of
2798 `len' according to what STRING_CHAR_AND_LENGTH expects.
2799 (bidi_paragraph_init, bidi_resolve_explicit_1)
2800 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2801 (bidi_level_of_next_char, bidi_move_to_visually_next):
2802 Support iteration over a string.
0bb23927
EZ
2803 (bidi_set_sor_type, bidi_resolve_explicit_1)
2804 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2805 can now be zero (for strings); special values 0 and -1 were
2806 changed to -1 and -2, respectively.
2807 (bidi_char_at_pos): New function.
2808 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2809 Call it instead of FETCH_MULTIBYTE_CHAR.
2810 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2811 initialized to valid values.
2812 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2813 values.
2814 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2815 the test for valid cached positions. Fix the logic for looking up
2816 the sentinel state in the cache. GCPRO the Lisp string we are
2817 iterating.
2818 (bidi_push_it, bidi_pop_it): New functions.
2819 (bidi_initialize): Initialize the bidi cache start stack pointer.
2820 (bidi_cache_ensure_space): New function, refactored from part of
2821 bidi_cache_iterator_state. Don't assume the required size is just
2822 one BIDI_CACHE_CHUNK away.
2823 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2824 (bidi_count_bytes, bidi_char_at_pos): New functions.
2825 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2826 always valid if bidi_cache_idx is valid.
2827 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2828 is valid if it's going to be used.
2829 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2830 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2831 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2832 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2833 (bidi_find_other_level_edge, bidi_cache_start_stack):
2834 All variables related to cache indices are now EMACS_INT.
c965adc5 2835
0bb23927
EZ
2836 * dispextern.h (struct bidi_string_data): New structure.
2837 (struct bidi_it): New member `string'. Make flag members be 1-bit
2838 fields, and put them last in the struct.
640c8776
SM
2839 (compute_display_string_pos, compute_display_string_end):
2840 Update prototypes.
0bb23927
EZ
2841 (bidi_push_it, bidi_pop_it): Add prototypes.
2842 (struct iterator_stack_entry): New members bidi_p,
2843 paragraph_embedding, and from_disp_prop_p.
2844 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2845 (bidi_shelve_cache, bidi_unshelve_cache):
2846 Declare prototypes.
0bb23927
EZ
2847
2848 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2849 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2850 and vector-like objects.
2851
2852 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2853 cache around display iteration.
2854
2855 * window.c (Fwindow_end, window_scroll_pixel_based)
2856 (displayed_window_lines, Frecenter): Save and restore the bidi
2857 cache around display iteration.
2858
3bbd2265
LMI
28592011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2860
2861 * editfns.c (Fdelete_region): Clarify the use of the named
2862 parameters (bug#6788).
2863
adc47434
MR
28642011-07-14 Martin Rudalics <rudalics@gmx.at>
2865
2866 * indent.c (Fvertical_motion): Set and restore w->pointm when
2867 saving and restoring the window's buffer (Bug#9006).
2868
837c31f8
LMI
28692011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2870
2871 * editfns.c (Fstring_to_char): Clarify just what is returned
2872 (bug#6576). Text by Eli Zaretskii.
2873
ac389d0c
JB
28742011-07-13 Juanma Barranquero <lekktu@gmail.com>
2875
2876 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2877
0be0ce47
EZ
28782011-07-13 Eli Zaretskii <eliz@gnu.org>
2879
2880 * buffer.c (mmap_find): Fix a typo.
2881
cd18e7e3
JB
28822011-07-13 Johan Bockgård <bojohan@gnu.org>
2883
2884 Fix execution of x selection hooks.
2885 * xselect.c (Qx_lost_selection_functions)
2886 (Qx_sent_selection_functions): New vars.
2887 (syms_of_xselect): DEFSYM them.
2888 (x_handle_selection_request): Pass Qx_sent_selection_functions
2889 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2890 (x_handle_selection_clear,x_clear_frame_selections):
2891 Pass Qx_lost_selection_functions rather than
2892 Vx_lost_selection_functions to Frun_hook_with_args.
2893
47ea7f44
PE
28942011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2895
ac389d0c 2896 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2897 The old code sometimes used this field without initializing it.
2898
47ea7f44
PE
2899 * alloc.c (gc_sweep): Don't read past end of array.
2900 In theory, the old code could also have corrupted Emacs internals,
2901 though it'd be very unlikely.
2902
bc985c87
AS
29032011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2904
2905 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2906 argument. (Bug#4026)
bc985c87 2907
0cf34688
LMI
29082011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2909
b3dadd76
LMI
2910 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2911 key" (bug#4257).
2912
0cf34688
LMI
2913 * window.c (Fset_window_start): Doc fix (bug#4199).
2914 (Fset_window_hscroll): Ditto.
2915
270768cd
PE
29162011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2917
077e3dda 2918 Fix minor new problems caught by GCC 4.6.1.
270768cd 2919 * term.c (init_tty): Remove unused local.
490011a6 2920 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2921 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2922 not used otherwise.
270768cd 2923
b1f58454
CY
29242011-07-12 Chong Yidong <cyd@stupidchicken.com>
2925
2926 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2927
22b9578d
LMI
29282011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2929
6e70ab07
LMI
2930 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2931 are the mini-buffer and the echo area (bug#3320).
2932
22b9578d
LMI
2933 * term.c (init_tty): Remove support for supdup, c10 and perq
2934 terminals, which are no longer supported (bug#1482).
2935
8974cc9f
JB
29362011-07-10 Johan Bockgård <bojohan@gnu.org>
2937
2938 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2939
a560d974
JD
29402011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2941
2942 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2943 for non-popups (Bug#3642).
2944
1dae0f0a
AS
29452011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2946
268c2c36 2947 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2948 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2949 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2950 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2951 * data.c (fmod): Likewise.
2952 * dispnew.c (swap_glyphs_in_rows): Likewise.
2953 * emacs.c (memory_warning_signal): Likewise.
2954 * floatfns.c (float_error): Likewise.
2955 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2956 (otf_open, font_otf_capability, generate_otf_features)
2957 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2958 Likewise.
2959 * image.c (pbm_read_file): Likewise.
2960 * indent.c (string_display_width): Likewise.
2961 * intervals.c (check_for_interval, search_for_interval)
2962 (inc_interval_count, count_intervals, root_interval)
2963 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2964 * lread.c (defalias): Likewise.
268c2c36 2965 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2966 * regex.c (set_image_of_range_1, set_image_of_range)
2967 (regex_grow_registers): Likewise.
2968 * sysdep.c (strerror): Likewise.
2969 * termcap.c (valid_filename_p, tprint, main): Likewise.
2970 * tparam.c (main): Likewise.
2971 * unexhp9k800.c (run_time_remap, save_data_space)
2972 (update_file_ptrs, read_header, write_header, calculate_checksum)
2973 (copy_file, copy_rest, display_header): Likewise.
2974 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2975 Likewise.
2976 * xdisp.c (check_it): Likewise.
2977 * xfaces.c (register_color, unregister_color, unregister_colors):
2978 Likewise.
2979 * xfns.c (print_fontset_result): Likewise.
2980 * xrdb.c (member, fatal, main): Likewise.
2981
99033785
PE
29822011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2983
2984 Fix minor problems found by static checking (Bug#9031).
2985 * chartab.c (char_table_set_range, map_sub_char_table):
2986 Remove unused locals.
2987 (uniprop_table): Now static.
2988 * composite.c (_work_char): Remove unused static var.
2989
9cb2ac56
JB
29902011-07-09 Juanma Barranquero <lekktu@gmail.com>
2991
2992 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2993
f25661f0
JD
29942011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2995
2996 * gtkutil.c (qttip_cb): Remove code without function.
2997
8278c4fe
EZ
29982011-07-09 Eli Zaretskii <eliz@gnu.org>
2999
3000 * w32.c (pthread_sigmask): New stub.
3001
1692ae2d 30022011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3003
8a6ebd58 3004 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3005 sigprocmask is portable only for single-threaded applications, and
3006 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3007 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3008 (LIBES): Use it.
3009 * callproc.c (Fcall_process):
3010 * process.c (create_process):
3011 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3012 Use pthread_sigmask, not sigprocmask.
123403e4 3013
1b854618
JD
30142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3015
3016 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3017 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3018 wrong (Bug#8591).
3019
3fe4b549
JD
30202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3021
0ce7e563
JD
3022 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3023 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3024 (xg_hide_tooltip): Fix comment.
3025
3fe4b549
JD
3026 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3027 in registerServicesMenuSendTypes.
3028 (validRequestorForSendType): Don't check ns_return_types.
3029
3030 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3031 ns_return_type.
3032
5df75e47
JR
30332011-07-08 Jason Rumney <jasonr@gnu.org>
3034
22610910
JR
3035 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3036 SH_SHOW for hidden windows (Bug#5482).
3037
5df75e47
JR
3038 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3039 frame struct members of non-existent frames (Bug#6284).
3040
699c10bd
JD
30412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3042
4393663b
JD
3043 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3044 variable firstTime not needed on OSX >= 10.6.
3045 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3046 >= 10.5. Use setKnobProportion, setDoubleValue.
3047
3048 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3049 (MAC_OS_X_VERSION_10_5): Define if not defined.
3050 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3051 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3052 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3053
3054 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3055 cString and lossyCString on OSX >= 10.4
3056
58179cce 3057 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3058 sizeToFit on OSX >= 10.2.
3059
3060 * nsimage.m (allocInitFromFile): Don't use deprecated method
3061 bestRepresentationForDevice on OSX >= 10.6.
3062
3063 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3064 to avoid warning.
3065
3066 * emacs.c: Declare unexec_init_emacs_zone.
3067
a63e0781
JD
3068 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3069
699c10bd
JD
3070 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3071
3072 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3073 on svcsMenu (Bug#8842).
3074
3075 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3076 ns_return_types.
3077 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3078
3079 * nsterm.m (QUTF8_STRING): Declare.
3080 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3081 (validRequestorForSendType): Return type is (id).
3082 Change indexOfObjectIdenticalTo to indexOfObject.
3083 Check if we have local selection before returning self (Bug#8842).
3084 (writeSelectionToPasteboard): Put local selection into paste board
3085 if we have a local selection (Bug#8842).
3086 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3087
3088 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3089 (ns_get_local_selection): Declare.
3090
54e10184
LMI
30912011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3092
9888ff71
LMI
3093 * keymap.c (describe_map_tree): Don't insert a double newline at
3094 the end of the buffer (bug#1169) and return whether we inserted
3095 something.
3096
54e10184
LMI
3097 * callint.c (Fcall_interactively): Change "reading args" to
3098 "providing args" to try to clarify what it does (bug#1010).
3099
15fa4783
KH
31002011-07-07 Kenichi Handa <handa@m17n.org>
3101
3102 * composite.c (composition_compute_stop_pos): Ignore a static
3103 composition starting before CHARPOS (Bug#8915).
3104
3105 * xdisp.c (handle_composition_prop): Likewise.
3106
a8815b00
EZ
31072011-07-07 Eli Zaretskii <eliz@gnu.org>
3108
3109 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3110 (Bug#9015)
3111
ef7b981d 31122011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3113
3114 * character.h (unicode_category_t): New enum type.
3115
3116 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3117 (Qchar_code_property_table): New variable.
3118 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3119 (UNIPROP_COMPRESSED_FORM_P): New macros.
3120 (char_table_ascii): Uncompress the compressed values.
3121 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3122 Uncompress the compressed values.
ac389d0c 3123 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3124 (char_table_ref_and_range): Uncompress the compressed values.
3125 (sub_char_table_set): New arg is_uniprop. Callers changed.
3126 Uncompress the compressed values.
3127 (sub_char_table_set_range): Args changed. Callers changed.
3128 (char_table_set_range): Adjuted for the above change.
3129 (map_sub_char_table): Delete args default_val and parent. Add arg
3130 top. Give decoded values to a Lisp function.
640c8776 3131 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3132 values to a Lisp function. Gcpro more variables.
3133 (uniprop_table_uncompress)
3134 (uniprop_decode_value_run_length): New functions.
3135 (uniprop_decoder, uniprop_decoder_count): New variables.
3136 (uniprop_get_decoder, uniprop_encode_value_character)
3137 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3138 New functions.
3139 (uniprop_encoder, uniprop_encoder_count): New variables.
3140 (uniprop_get_encoder, uniprop_table)
3141 (Funicode_property_table_internal, Fget_unicode_property_internal)
3142 (Fput_unicode_property_internal): New functions.
3143 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3144 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3145 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3146 char-code-property-alist.
3147
640c8776 3148 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3149 Vunicode_category_table.
3150
640c8776 3151 * font.c (font_range): Adjust for the change of
c805dec0
KH
3152 Vunicode_category_table.
3153
76b397fb
DN
31542011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3155
3156 * m/iris4d.h: Remove file, move contents ...
3157 * s/irix6-5.h: ... here.
3158
22b4128e
PE
31592011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3162 * alloc.c (mark_buffer):
3163 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3164 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3165 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3166 This isn't true in general, and it's particularly not true
3167 if Emacs is configured with --with-wide-int.
3168 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3169 New macros, used in the buffer.c change.
3170
869795d6
JD
31712011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3172
3173 * xsettings.c: Use both GConf and GSettings if both are available.
3174 (store_config_changed_event): Add comment.
3175 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3176 (store_tool_bar_style_changed): New functions.
5e617bc2 3177 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3178 (struct xsettings): Move font inside HAVE_XFT.
3179 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3180 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3181 Move inside HAVE_XFT.
640c8776 3182 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3183 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3184 also.
3185 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3186 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3187 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3188 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3189 (parse_settings): Move check for font inside HAVE_XFT.
3190 (read_settings, apply_xft_settings): Add comment.
3191 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3192 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3193 call store_font_name_changed.
3194 (xft_settings_event): Add comment.
3195 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3196 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3197 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3198 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3199 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3200 (xsettings_get_system_font, xsettings_get_system_normal_font):
3201 Add comment.
869795d6 3202
d8ed26bd
PE
32032011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 Random fixes. E.g., (random) never returned negative values.
3206 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3207 subseconds part to the entropy, as that's a bit more random.
3208 Prefer signed to unsigned, since the signedness doesn't matter and
3209 in general we prefer signed. When given a limit, use a
3210 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3211 latter isn't right if USE_2_TAGS_FOR_INTS.
3212 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3213 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3214
cabf1cac
SM
32152011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3216
3217 * textprop.c (text_property_stickiness):
3218 Obey Vtext_property_default_nonsticky.
3219 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3220 * w32fns.c (syms_of_w32fns):
3221 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3222
6e9b2be9
PE
32232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3226 This is more efficient than Ffile_directory_p and avoids a minor race.
3227
90186c68
LMI
32282011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3229
7c301272
LMI
3230 * buffer.c (Foverlay_put): Say what the return value is
3231 (bug#7835).
3232
c4f2d8d4
LMI
3233 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3234 is a directory before asking whether to use the file name
3235 (bug#7564).
ad637907
LMI
3236 (barf_or_query_if_file_exists): Make the "File is a directory"
3237 error be more correct.
c4f2d8d4 3238
90186c68
LMI
3239 * fns.c (Frequire): Remove the mention of the .gz files, since
3240 that's installation-specific, but keep the mention of
3241 `get-load-suffixes'.
3242
da64016e
PE
32432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3246 Report string overflow if the output is too long.
3247
7d47b580
JB
32482011-07-04 Juanma Barranquero <lekktu@gmail.com>
3249
a555cb87
JB
3250 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3251 (syms_of_gnutls): Remove duplicate DEFSYM for
3252 Qgnutls_bootprop_verify_hostname_error, an error for
3253 Qgnutls_bootprop_verify_error (which is no longer used).
3254
7d47b580
JB
3255 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3256 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3257 Also (re)move comments that are misplaced or no longer relevant.
3258
1e49bfab
LMI
32592011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3260
3261 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3262
1485f4c0
CY
32632011-07-03 Chong Yidong <cyd@stupidchicken.com>
3264
3265 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3266 and background color parameters if they have been changed.
3267
a9ab721e
LMI
32682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3269
3270 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3271
cf7cff57
PE
32722011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3273
2e13213d
PE
3274 * xsettings.c (SYSTEM_FONT): Define only when used.
3275 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3276
cf7cff57
PE
3277 * keymap.c (access_keymap_1): Now static.
3278
7a8e04f7
CY
32792011-07-02 Chong Yidong <cyd@stupidchicken.com>
3280
3281 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3282 leave any prefix arg for the up event (Bug#1586).
3283
61352f62
LMI
32842011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3285
69bb1ef7
LMI
3286 * lread.c (syms_of_lread): Mention single symbols defined by
3287 `defvar' or `defconst' (bug#7154).
3288
61352f62 3289 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3290 (Frequire): Mention get-load-suffixes.
61352f62 3291
28545e04
MR
32922011-07-02 Martin Rudalics <rudalics@gmx.at>
3293
3294 * window.h (window): Remove clone_number slot.
3295 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3296 Remove.
3297 (make_parent_window, make_window, saved_window)
3298 (Fset_window_configuration, save_window_save): Don't deal with
3299 clone numbers.
3300 * buffer.c (Qclone_number): Remove declaration.
3301 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3302
3349e122
SM
33032011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3304
3305 Add multiple inheritance to keymaps.
3306 * keymap.c (Fmake_composed_keymap): New function.
3307 (Fset_keymap_parent): Simplify.
3308 (fix_submap_inheritance): Remove.
3309 (access_keymap_1): New function extracted from access_keymap to handle
3310 embedded parents and handle lists of maps.
3311 (access_keymap): Use it.
3312 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3313 (Fcopy_keymap): Handle embedded parents.
3314 (Fcommand_remapping, define_as_prefix): Simplify.
3315 (Fkey_binding): Simplify.
3316 (syms_of_keymap): Move minibuffer-local-completion-map,
3317 minibuffer-local-filename-completion-map,
3318 minibuffer-local-must-match-map, and
3319 minibuffer-local-filename-must-match-map to Elisp.
3320 (syms_of_keymap): Defsubr make-composed-keymap.
3321 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3322 (parse_menu_item): Trivial simplification.
3323
3279eb87
GM
33242011-07-01 Glenn Morris <rgm@gnu.org>
3325
3326 * Makefile.in (SETTINGS_LIBS): Fix typo.
3327
4550efdf
KI
33282011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3329
3330 * coding.c (Fencode_coding_string): Record the last coding system
3331 used, as the function doc string says (bug#8738).
3332
0949d2b6
JD
33332011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3334
3335 * xsettings.c (store_monospaced_changed): Take new font as arg and
3336 check for change against current_mono_font.
3337 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3338 (emacs_settings_constructor, emacs_settings_get_property)
3339 (emacs_settings_set_property, emacs_settings_class_init)
3340 (emacs_settings_init, gsettings_obj): Remove.
3341 (something_changedCB): New function for HAVE_GSETTINGS.
3342 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3343 with value as argument.
3344 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3345 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3346 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3347 "changed".
3348
3349 * xgselect.c: Add defined (HAVE_GSETTINGS).
3350 (xgselect_initialize): Ditto.
3351
3352 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3353 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3354 xg_select.
3355
bbc6b304
PE
33562011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3357
3358 * eval.c (struct backtrace): Simplify and port the data structure.
3359 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3360 signed bit field, as this assumption is not portable and it makes
3361 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3362 "char debug_on_exit : 1" as this is not portable either; instead,
3363 use the portable "unsigned int debug_on_exit : 1". Remove unused
3364 member evalargs. Remove obsolete comments about cc bombing out.
3365
9851bfc5
JD
33662011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3367
51bb811f 3368 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3369 Let HAVE_GSETTINGS override HAVE_GCONF.
3370 (store_monospaced_changed): New function.
3371 (EMACS_SETTINGS): A new type derived from GObject to handle
3372 GSettings notifications.
3373 (emacs_settings_constructor, emacs_settings_get_property)
3374 (emacs_settings_set_property, emacs_settings_class_init):
3375 New functions.
3376 (gsettings_client, gsettings_obj): New variables.
3377 (GSETTINGS_SCHEMA): New define.
3378 (something_changedCB): Call store_monospaced_changed.
3379 (init_gsettings): New function.
3380 (xsettings_initialize): Call init_gsettings.
3381 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3382 to NULL.
3383
640c8776 3384 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3385 GCONF_CFLAGS/LIBS.
3386
5386012d
MR
33872011-06-29 Martin Rudalics <rudalics@gmx.at>
3388
3389 * window.c (resize_root_window, grow_mini_window)
3390 (shrink_mini_window): Rename Qresize_root_window to
3391 Qwindow_resize_root_window and Qresize_root_window_vertically to
3392 Qwindow_resize_root_window_vertically.
3393
f13e0b08
PE
33942011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3395
3396 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3397
94515237
JB
33982011-06-27 Juanma Barranquero <lekktu@gmail.com>
3399
3400 * makefile.w32-in: Redesign dependencies so they reflect more
3401 clearly which files are directly included by each source file,
3402 and not through other includes.
3403
e43b6e43
MR
34042011-06-27 Martin Rudalics <rudalics@gmx.at>
3405
3406 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3407 (sort_overlays, overlay_strings): When an overlay's clone number
3408 matches the window's clone number process the overlay even if
3409 the overlay's window property doesn't match the current window.
3410
d68443dc
MR
3411 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3412 (Fwindow_hchild): Rename to Fwindow_left_child.
3413 (Fwindow_next): Rename to Fwindow_next_sibling.
3414 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3415 (resize_window_check): Rename to window_resize_check.
3416 (resize_window_apply): Rename to window_resize_apply.
3417 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3418 (Fdelete_other_windows_internal, resize_frame_windows)
3419 (Fsplit_window_internal, Fdelete_window_internal)
3420 (grow_mini_window, shrink_mini_window)
3421 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3422
c7e73be5
JD
34232011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3424
3425 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3426 (emacs_fixed_set_min_size): Remove.
3427 (emacs_fixed_new): Take frame as argument.
3428
3429 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3430 (_EmacsFixedPrivate): Remove minwidth/height.
3431 Add struct frame *f.
3432 (emacs_fixed_init): Initialize priv->f.
3433 (get_parent_class, emacs_fixed_set_min_size): Remove.
3434 (emacs_fixed_new): Set priv->f to argument.
3435 (emacs_fixed_get_preferred_width)
3436 (emacs_fixed_get_preferred_height): Use min_width/height from
3437 frames size_hint to set minimum and natural (Bug#8919).
3438 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3439 and use min_width/height from frames size_hint to set
3440 min_width/height (Bug#8919).
3441
3442 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3443 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3444 Fix indentation.
c7e73be5 3445
cf99dcf8
EZ
34462011-06-26 Eli Zaretskii <eliz@gnu.org>
3447
3448 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3449 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3450 called at ZV.
3451
029529ac
CY
34522011-06-26 Chong Yidong <cyd@stupidchicken.com>
3453
3454 * process.c (wait_reading_process_output): Bypass select if
3455 waiting for a cell while ignoring keyboard input, and input is
3456 pending. Suggested by Jan Djärv (Bug#8869).
3457
7a7ef429
PE
34582011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 Use gnulib's dup2 module instead of rolling our own.
3461 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3462
11fdef7d 34632011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3464
3465 * dispnew.c (scrolling_window): Before scrolling, turn off a
3466 mouse-highlight in the window being scrolled.
3467
cd3520a4
JB
34682011-06-24 Juanma Barranquero <lekktu@gmail.com>
3469
3470 Move DEFSYM to lisp.h and use everywhere.
3471
3472 * character.h (DEFSYM): Move declaration...
3473 * lisp.h (DEFSYM): ...here.
3474
3475 * gnutls.c:
3476 * minibuf.c:
3477 * w32menu.c:
3478 * w32proc.c:
3479 * w32select.c: Don't include character.h.
3480
3481 * alloc.c (syms_of_alloc):
3482 * buffer.c (syms_of_buffer):
3483 * bytecode.c (syms_of_bytecode):
3484 * callint.c (syms_of_callint):
3485 * casefiddle.c (syms_of_casefiddle):
3486 * casetab.c (init_casetab_once):
3487 * category.c (init_category_once, syms_of_category):
3488 * ccl.c (syms_of_ccl):
3489 * cmds.c (syms_of_cmds):
3490 * composite.c (syms_of_composite):
3491 * dbusbind.c (syms_of_dbusbind):
3492 * dired.c (syms_of_dired):
3493 * dispnew.c (syms_of_display):
3494 * doc.c (syms_of_doc):
3495 * editfns.c (syms_of_editfns):
3496 * emacs.c (syms_of_emacs):
3497 * eval.c (syms_of_eval):
3498 * fileio.c (syms_of_fileio):
3499 * fns.c (syms_of_fns):
3500 * frame.c (syms_of_frame):
3501 * fringe.c (syms_of_fringe):
3502 * insdel.c (syms_of_insdel):
3503 * keymap.c (syms_of_keymap):
3504 * lread.c (init_obarray, syms_of_lread):
3505 * macros.c (syms_of_macros):
3506 * msdos.c (syms_of_msdos):
3507 * print.c (syms_of_print):
3508 * process.c (syms_of_process):
3509 * search.c (syms_of_search):
3510 * sound.c (syms_of_sound):
3511 * syntax.c (init_syntax_once, syms_of_syntax):
3512 * terminal.c (syms_of_terminal):
3513 * textprop.c (syms_of_textprop):
3514 * undo.c (syms_of_undo):
3515 * w32.c (globals_of_w32):
3516 * window.c (syms_of_window):
3517 * xdisp.c (syms_of_xdisp):
3518 * xfaces.c (syms_of_xfaces):
3519 * xfns.c (syms_of_xfns):
3520 * xmenu.c (syms_of_xmenu):
3521 * xsettings.c (syms_of_xsettings):
3522 * xterm.c (syms_of_xterm): Use DEFSYM.
3523
4228cf16
TZ
35242011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3525
cd3520a4 3526 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3527
7fcccf1e
PE
35282011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3529
7efb4e0e
PE
3530 Integer and buffer overflow fixes (Bug#8873).
3531
ff5844ad
PE
3532 * print.c (printchar, strout): Check for string overflow.
3533 (PRINTPREPARE, printchar, strout):
3534 Don't set size unless allocation succeeds.
3535
90532f02
PE
3536 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3537 for sizes. Check for string overflow more accurately.
3538 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3539
6d84508d
PE
3540 * macros.c: Integer and buffer overflow fixes.
3541 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3542 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3543 Use ptrdiff_t, not int, for sizes.
3544 Don't increment bufsize until after realloc succeeds.
3545 Check for size-calculation overflow.
3546 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3547
437b2cb4
PE
3548 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3549
8b9ac8b4
PE
3550 * lread.c: Integer overflow fixes.
3551 (read_integer): Radix is now EMACS_INT, not int,
3552 to improve quality of diagnostics for out-of-range radices.
3553 Calculate buffer size correctly for out-of-range radices.
3554 (read1): Check for integer overflow in radices, and in
3555 read-circle numbers.
82cb60d3
PE
3556 (read_escape): Avoid int overflow.
3557 (Fload, openp, read_buffer_size, read1)
3558 (substitute_object_recurse, read_vector, read_list, map_obarray):
3559 Use ptrdiff_t, not int, for sizes.
3560 (read1): Use EMACS_INT, not int, for sizes.
20270765 3561 Check for size overflow.
8b9ac8b4 3562
7fcccf1e
PE
3563 * image.c (cache_image): Check for size arithmetic overflow.
3564
bfbbd7e7
PE
3565 * lread.c: Integer overflow issues.
3566 (saved_doc_string_size, saved_doc_string_length)
3567 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3568 Now ptrdiff_t, not int.
3569 (read1): Don't assume doc string length fits in int. Check for
3570 out-of-range doc string lengths.
3571 (read_list): Don't assume file position fits in int.
39019e54 3572 (read_escape): Check for hex character overflow.
bfbbd7e7 3573
4e323265
LL
35742011-06-22 Leo Liu <sdl.web@gmail.com>
3575
3576 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3577 Move to minibuffer.el.
3578
85fece3e
PE
35792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3580
20b84ce9 3581 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3582 The following patches are for when GLYPH_DEBUG && !XASSERT.
3583 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3584 * dispnew.c (flush_stdout):
3585 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3586 Mark as externally visible.
3587 * dispnew.c (check_window_matrix_pointers): Now static.
3588 * dispnew.c (window_to_frame_vpos):
3589 * xfns.c (unwind_create_frame):
3590 * xterm.c (x_check_font): Remove unused local.
3591 * scroll.c (CHECK_BOUNDS):
3592 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3593 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3594 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3595 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3596 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3597 Now static.
3598 (debug_method_add): Use va_list and vsprintf rather than relying
3599 on undefined behavior with wrong number of arguments.
3600 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3601 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3602 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3603 since we're not interested in debugging glyphs with old libraries.
3604 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3605 GCC 4.6.0's static checking.
3606
0766b489
PE
36072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3608
31fd4b32
PE
3609 Integer overflow and signedness fixes (Bug#8873).
3610 A few related buffer overrun fixes, too.
3611
b79e8648
PE
3612 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3613
0766b489
PE
3614 * dispextern.h (struct face.stipple):
3615 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3616 (x_bitmap_mask, x_allocate_bitmap_record)
3617 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3618 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3619 (x_create_bitmap_from_xpm_data):
3620 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3621 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3622 (.bitmaps_last):
3623 * xfaces.c (load_pixmap):
3624 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3625 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3626 (.bitmaps_last, struct x_output.icon_bitmap):
3627 Use ptrdiff_t, not int, for bitmap indexes.
3628 (x_allocate_bitmap_record): Check for size overflow.
3629 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3630
b081724f
PE
3631 Use ptrdiff_t, not int, for overlay counts.
3632 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3633 * editfns.c (overlays_around, get_pos_property):
3634 * textprop.c (get_char_property_and_overlay):
3635 * xdisp.c (next_overlay_change, note_mouse_highlight):
3636 * xfaces.c (face_at_buffer_position):
21514da7
PE
3637 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3638 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3639 (Fnext_overlay_change, Fprevious_overlay_change)
3640 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3641 Use ptrdiff_t, not int, for sizes.
21514da7 3642 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3643
3de73e5e
PE
3644 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3645
2606c57b
PE
3646 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3647 (x_session_initialize): Do not assume string length fits in int.
3648
aaafe47a
PE
3649 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3650 This is unlikely, but can occur if DPI is outlandish.
3651
2674ddc8 3652 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3653 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3654
28154962
PE
3655 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3656 * xrdb.c (magic_file_p, search_magic_path):
3657 Omit last arg SUFFIX; it was always 0. All callers changed.
3658 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3659
7de51af5
PE
3660 * xfont.c (xfont_match): Avoid need for strlen.
3661
25ed6cc3
PE
3662 * xfns.c: Don't assume strlen fits in int.
3663 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3664
4eab31dd
PE
3665 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3666 not unsigned long, as we prefer signed integers. All callers changed.
3667 Detect integer overflow in repeat count.
3668 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3669 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3670
171e2a58
PE
3671 * termcap.c: Don't assume sizes fit in int and never overflow.
3672 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3673 (gobble_line): Check for size-calculation overflow.
3674
ad39faca 3675 * minibuf.c (Fread_buffer):
6e5bb2dc 3676 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3677 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3678 Don't assume string length fits in int.
3679
52c61c22 3680 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3681 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3682
b5b8c9e5
PE
3683 * font.c: Don't assume string length fits in int.
3684 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3685 Use ptrdiff_t, not int.
ccd6111c
PE
3686 (font_intern_prop): Don't assume string length fits in int.
3687 Don't assume integer property fits in fixnum.
3688 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3689
882f0d81 3690 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3691 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3692 Reformulate so as not to need the command string.
3693 Invoke gzip -cd rather than gunzip, as it's more portable.
3694 (lock_info_type, lock_file_1, lock_file):
3695 Don't assume pid_t and time_t fit in unsigned long.
3696 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3697 (current_lock_owner): Prefer signed type for sizes.
3698 Use memcpy, not strncpy, where memcpy is what is really wanted.
3699 Don't assume (via atoi) that time_t and pid_t fit in int.
3700 Check for time_t and/or pid_t out of range, e.g., via a network share.
3701 Don't alloca where an auto var works fine.
3702
93f4cf88
PE
3703 * fileio.c: Fix some integer overflow issues.
3704 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3705 Don't assume string length fits in int.
3706 (directory_file_name): Don't assume string length fits in long.
3707 (make_temp_name): Don't assume pid fits in int, or that its print
3708 length is less than 20.
3709
f3e92b69
PE
3710 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3711
1bfdaf10
PE
3712 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3713
35016e9a
PE
3714 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3715
3d1e65a1
PE
3716 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3717 We prefer signed integers, even for size calculations.
3718
0b963a93
PE
3719 * emacs.c: Don't assume string length fits in 'int'.
3720 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3721 (main): Don't invoke strlen when not needed.
3722
573f4b54
PE
3723 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3724 (XD_DEBUG_MESSAGE): Don't waste a byte.
3725
989f33ba
PE
3726 * callproc.c (getenv_internal_1, getenv_internal)
3727 (Fgetenv_internal):
965d34eb
PE
3728 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3729
e4d29b33
PE
3730 * lread.c (invalid_syntax): Omit length argument.
3731 All uses changed. This doesn't fix a bug, but it simplifies the
3732 code away from its former Hollerith-constant appearance, and it's
3733 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3734 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3735
eb49b136
PE
3736 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3737 This didn't break anything, but it didn't help either.
3738 It's confusing to put a bogus integer in a place where the actual
3739 value does not matter.
9f62aeb1 3740 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3741 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3742
15375a22
PE
3743 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3744 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3745 implementation.
b61cc01c
PE
3746 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3747 We prefer signed types, and the value cannot exceed the EMACS_INT
3748 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3749 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3750 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3751 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3752
53b2623d
PE
3753 * indent.c (sane_tab_width): New function.
3754 (current_column, scan_for_column, Findent_to, position_indentation)
3755 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3756 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3757
51cab52b 3758 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3759
f2ed8a70
PE
3760 * lisp.h (lint_assume): New macro.
3761 * composite.c (composition_gstring_put_cache):
3762 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3763
abe80cc6
PE
3764 * editfns.c, insdel.c:
3765 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3766
b02c740e
PE
3767 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3768
ebc96716
PE
3769 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3770
b4e50fa0 3771 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3772 Use much-faster test for byte-length change.
311d5d7c 3773 Don't assume string byte-length fits in 'int'.
a4cf38e4 3774 Check that character arg fits in 'int'.
85461888 3775 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3776
c0c1ee9f
PE
3777 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3778
a498d7f4
PE
3779 * fns.c (concat): Catch string overflow earlier.
3780 Do not rely on integer wraparound.
3781
51cab52b
PE
3782 * dispextern.h (struct it.overlay_strings_charpos)
3783 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3784 * xdisp.c (forward_to_next_line_start)
3785 (back_to_previous_visible_line_start)
3786 (reseat_at_next_visible_line_start, next_element_from_buffer):
3787 Don't arbitrarily truncate the value of 'selective' to int.
3788
76031fad
PE
3789 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3790
5eb55db9
PE
3791 * composite.c: Don't truncate sizes to 'int'.
3792 (composition_gstring_p, composition_reseat_it)
3793 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3794 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3795 not EMACS_UINT, for indexes.
5eb55db9 3796
0703a717
PE
3797 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3798
d6202519
PE
3799 * buffer.c: Include <verify.h>.
3800 (struct sortvec.priority, struct sortstr.priority):
8961a454 3801 Now EMACS_INT, not int.
c20998a7 3802 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3803 (struct sortstr.size, record_overlay_string)
3804 (struct sortstrlist.size, struct sortlist.used):
3805 Don't truncate size to int.
3806 (record_overlay_string): Check for size-calculation overflow.
d6202519 3807 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3808
d5a19415
JM
38092011-06-22 Jim Meyering <meyering@redhat.com>
3810
029529ac 3811 Don't leak an XBM-image-sized buffer
d5a19415
JM
3812 * image.c (xbm_load): Free the image buffer after using it.
3813
a9041e6c
PE
38142011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 Port to Sun C.
3817 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3818 that Sun C diagnosed.
3819 * fns.c (secure_hash): Fix pointer signedness issue.
3820 * intervals.c (static_offset_intervals): New function.
3821 (offset_intervals): Use it.
3822
7f3f739f
LL
38232011-06-21 Leo Liu <sdl.web@gmail.com>
3824
3825 * deps.mk (fns.o):
3826 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3827 sha512.h.
3828
3829 * fns.c (secure_hash): Rename from crypto_hash_function and change
3830 the first arg to accept symbols.
5b66d427 3831 (Fsecure_hash): New primitive.
7f3f739f
LL
3832 (syms_of_fns): New symbols.
3833
76147d94
DD
38342011-06-20 Deniz Dogan <deniz@dogan.se>
3835
3836 * process.c (Fset_process_buffer): Clarify return value in
3837 docstring.
3838
7d7d0045
CY
38392011-06-18 Chong Yidong <cyd@stupidchicken.com>
3840
3841 * dispnew.c (add_window_display_history): Use BVAR.
3842
3843 * xdisp.c (debug_method_add): Use BVAR.
3844 (check_window_end, dump_glyph_matrix, dump_glyph)
3845 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3846
3847 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3848 Likewise.
3849
3850 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3851 check till after the cache is created in init_frame_faces.
3852
ff2bc410
SM
38532011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3854
3855 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3856
28177add
PE
38572011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3858
dd3482fe
PE
3859 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3860 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3861 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3862
393d71f3 3863 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3864 * fileio.c (Finsert_file_contents):
3865 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3866 Remove the old (too-loose) buffer overflow checks.
3867 They weren't needed, since make_gap checks for buffer overflow.
3868 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3869 The old code merely checked for Emacs fixnum overflow, and relied
3870 on undefined (wraparound) behavior. The new code avoids undefined
3871 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3872
2e6813b0 3873 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3874 Tune. Don't use wider integers than needed. Don't use alloca.
3875 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3876
599a9e4f
PE
3877 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3878
99561444
PE
3879 * insdel.c, lisp.h (buffer_overflow): New function.
3880 (insert_from_buffer_1, replace_range, replace_range_2):
3881 * insdel.c (make_gap_larger):
3882 * editfns.c (Finsert_char):
3883 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3884
28177add
PE
3885 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3886
e69dafad
PE
38872011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3888
a7af7fde 3889 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3890
b1c46f02
PE
3891 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3892 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3893
e69dafad
PE
3894 * fileio.c: Don't assume EMACS_INT fits in off_t.
3895 (emacs_lseek): New static function.
3896 (Finsert_file_contents, Fwrite_region): Use it.
3897 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3898
566684ea
PE
3899 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3900
e6966cd6
PE
3901 * fns.c: Don't overflow int when computing a list length.
3902 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3903 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3904 truncation on 64-bit hosts. Check for QUIT every
3905 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3906 faster and is responsive enough.
3907 (Flength): Report an error instead of overflowing an integer.
3908 (Fsafe_length): Return a float if the value is not representable
3909 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3910 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3911 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3912
dd0b0efb
PE
3913 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3914 (header_size, word_size): New constants.
3915 (allocate_vectorlike): Don't check size overflow here.
3916 (allocate_vector): Check it here instead, since this is the only
3917 caller of allocate_vectorlike that could cause overflow.
3918 Check that the new vector's length is representable as a fixnum.
3919
86fe5cfe
PE
3920 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3921 The previous code was bogus. For example, next_almost_prime (32)
3922 returned 39, which is undesirable as it is a multiple of 3; and
3923 next_almost_prime (24) returned 25, which is a multiple of 5 so
3924 why was the code bothering to check for multiples of 7?
3925
80e88859
PE
3926 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3927
4a2f0ad6
PE
3928 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3929
f66c7cf8
PE
3930 Variadic C functions now count arguments with ptrdiff_t.
3931 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3932 Back then I didn't know that the Emacs coding style prefers signed int.
3933 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3934 were being counted with int, which may truncate counts on 64-bit
3935 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3936 * lisp.h (struct Lisp_Subr.function.aMANY)
3937 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3938 Arg counts are now ptrdiff_t, not size_t.
3939 All variadic functions and their callers changed accordingly.
3940 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3941 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3942 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3943 * callint.c (Fcall_interactively): Check arg count for overflow,
3944 to avoid potential buffer overrun. Use signed char, not 'int',
3945 for 'varies' array, so that we needn't bother to check its size
3946 calculation for overflow.
3947 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3948 * eval.c (apply_lambda):
3949 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3950 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3951 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3952
a1759b76
PE
3953 * callint.c (Fcall_interactively): Don't use index var as event count.
3954
d96be9fc
PE
3955 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3956 * mem-limits.h (SIZE): Remove; no longer used.
3957
a690a978 3958 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3959
578c21e6
PE
3960 Remove unnecessary casts.
3961 * xterm.c (x_term_init):
3962 * xfns.c (x_set_border_pixel):
3963 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3964 These aren't needed now that we assume ANSI C.
3965
96f53c6c
PE
3966 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3967 It's more likely to cause problems (due to unsigned overflow)
3968 than to cure them.
3969
83c77d31
PE
3970 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3971
ee2079f1
PE
3972 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3973
6da65536
PE
3974 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3975
7147c4a4
PE
3976 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3977
193e32d9
PE
3978 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3979
e5533da6
PE
3980 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3981
9910e595
PE
3982 GLYPH_CODE_FACE returns EMACS_INT, not int.
3983 * dispextern.h (merge_faces):
3984 * xfaces.c (merge_faces):
01103c44
PE
3985 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3986 Don't assume EMACS_INT fits in int.
9910e595 3987
2638320e
PE
3988 * character.h (CHAR_VALID_P): Remove unused parameter.
3989 * fontset.c, lisp.h, xdisp.c: All uses changed.
3990
045eb8d9
PE
3991 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3992
c1f134b5
PE
3993 * fns.c (concat): Minor tuning based on overflow analysis.
3994 This doesn't fix any bugs. Use int to hold character, instead
3995 of constantly refetching from Emacs object. Use XFASTINT, not
3996 XINT, for value known to be a character. Don't bother comparing
3997 a single byte to 0400, as it's always less.
3998
395fcb93 3999 * floatfns.c (Fexpt):
327eeec8
PE
4000 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4001
abbd3d23
PE
4002 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4003 for characters.
4004
684a03ef
PE
4005 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4006
0fed43f3
PE
4007 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4008 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4009 incorrectly succeed when S was a string, because 4294967386 was
4010 truncated before it was used.
4011
8fd02eb7
PE
4012 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4013 Otherwise, an out-of-range integer could cause undefined behavior
4014 on a 64-bit host.
4015
f8c86b69
PE
4016 * composite.c: Use int, not EMACS_INT, for characters.
4017 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4018 EMACS_INT, for values that are known to be in character range.
4019 This doesn't fix any bugs but is the usual style inside Emacs and
4020 may generate better code on 32-bit machines.
4021
34206dd2
PE
4022 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4023 This is for reasons similar to the recent CHAR_STRING fix.
4024 * charset.c (Fencode_char): Check that character arg is actually
4025 a character. Pass an int to ENCODE_CHAR.
4026 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4027 wider than 'int', as a compile-time check to prevent future regressions
4028 in this area.
4029
c5958d4c 4030 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4031
4032 Make sure a 64-bit char is never passed to CHAR_STRING.
4033 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4034 by silently ignoring the top 32 bits, allowing some values
4035 that were far too large to be valid characters.
4036 * character.h: Include <verify.h>.
4037 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4038 arguments are no wider than unsigned, as a compile-time check
4039 to prevent future regressions in this area.
4040 * data.c (Faset):
01103c44 4041 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4042 (Fsubst_char_in_region):
4043 * fns.c (concat):
4044 * xdisp.c (decode_mode_spec_coding):
4045 Adjust to CHAR_STRING's new requirement.
4046 * editfns.c (Finsert_char, Fsubst_char_in_region):
4047 * fns.c (concat): Check that character args are actually
4048 characters. Without this test, these functions did the wrong
4049 thing with wildly out-of-range values on 64-bit hosts.
4050
d37ca623
PE
4051 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4052 These casts should not be needed on 32-bit hosts, either.
4053 * keyboard.c (read_char):
4054 * lread.c (Fload): Remove casts to unsigned.
4055
ea204efb
PE
4056 * lisp.h (UNSIGNED_CMP): New macro.
4057 This fixes comparison bugs on 64-bit hosts.
4058 (ASCII_CHAR_P): Use it.
4059 * casefiddle.c (casify_object):
01103c44 4060 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4061 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4062 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4063 * dispextern.h (FACE_FROM_ID):
4064 * keyboard.c (read_char): Use UNSIGNED_CMP.
4065
41cb286c
PE
4066 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4067 not to EMACS_INT, to avoid GCC warning.
4068
4a1b9832
PE
4069 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4070
55daad71
PE
4071 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4072 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4073 isn't needed on 32-bit machines.
8f95c75c 4074
01103c44
PE
4075 * buffer.c (Fgenerate_new_buffer_name):
4076 Use EMACS_INT for count, not int.
0ceccced 4077 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4078
4079 * data.c (Qcompiled_function): Now static.
4080
c6f072e7
PE
4081 * window.c (window_body_lines): Now static.
4082
20ce5912
PE
4083 * image.c (gif_load): Rename local to avoid shadowing.
4084
9c4c5f81
PE
4085 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4086 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4087 * alloc.c (make_save_value): Integer argument is now of type
4088 ptrdiff_t, not int.
4089 (mark_object): Use ptrdiff_t, not int.
4090 * lisp.h (pD): New macro.
4091 * print.c (print_object): Use it.
4092
c0c5c8ae
PE
4093 * alloc.c: Use EMACS_INT, not int, to count objects.
4094 (total_conses, total_markers, total_symbols, total_vector_size)
4095 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4096 (total_free_floats, total_floats, total_free_intervals)
4097 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4098 Now EMACS_INT, not int. All uses changed.
4099 (Fgarbage_collect): Compute overall total using a double, so that
4100 integer overflow is less likely to be a problem. Check for overflow
4101 when converting back to an integer.
5a25e253
PE
4102 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4103 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4104 These were 'int' variables that could overflow on 64-bit hosts;
4105 they were never used, so remove them instead of repairing them.
211a0b2a 4106 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4107 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4108 Previously, this ceilinged at INT_MAX, but that doesn't work on
4109 64-bit machines.
e46bb31a 4110 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4111
c78baabf 4112 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4113 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4114 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4115 when a (possibly-narrower) signed value would do just as well.
4116 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4117
c9d624c6
PE
4118 * alloc.c: Catch some string size overflows that we were missing.
4119 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4120 for convenience in STRING_BYTES_MAX.
4121 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4122 The definition here is exact; the one in lisp.h was approximate.
4123 (allocate_string_data): Check for string overflow. This catches
4124 some instances we weren't catching before. Also, it catches
4125 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4126 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4127 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4128
c9d624c6
PE
4129 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4130 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4131 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4132
353032ce
PE
4133 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4134
2bccce07
PE
4135 * alloc.c (Fmake_string): Check for out-of-range init.
4136
0ac30604
SM
41372011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4138
4139 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4140
c195f2de
JD
41412011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4142
4143 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4144 xg_get_default_scrollbar_width.
4145
4146 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4147 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4148 (style_changed_cb): Call update_theme_scrollbar_width and call
4149 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4150 all frames (Bug#8505).
4151 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4152 Call gtk_window_set_resizable if HAVE_GTK3.
4153 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4154 and height if HAVE_GTK3 (Bug#8505).
4155 (scroll_bar_width_for_theme): New variable.
4156 (update_theme_scrollbar_width): New function.
4157 (xg_get_default_scrollbar_width): Move code to
4158 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4159 (xg_initialize): Call update_theme_scrollbar_width.
4160
4161 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4162
4163 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4164
e10ac9f1
MR
41652011-06-12 Martin Rudalics <rudalics@gmx.at>
4166
4167 * frame.c (make_frame): Call other_buffer_safely instead of
4168 other_buffer.
4169
4170 * window.c (temp_output_buffer_show): Call display_buffer with
4171 second argument Vtemp_buffer_show_specifiers and reset latter
4172 immediately after the call.
4173 (Vtemp_buffer_show_specifiers): New variable.
4174 (auto_window_vscroll_p, next_screen_context_lines)
4175 (Vscroll_preserve_screen_position): Remove leading asterisks from
4176 doc-strings.
4177
2d3c217e 41782011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4179
7b7f97e8 4180 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4181 * buffer.c (Qclone_number): Remove for now, as it's unused.
4182 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4183 (record_buffer): Remove unused local.
4184 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4185 (set_frame_buffer_list): Remove; unused.
4186 * frame.h (other_visible_frames): Remove decl.
4187 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4188 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4189 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4190 if HAVE_GPM.
4191 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4192 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4193 Define only if HAVE_GPM.
4194 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4195 (update_hints_inhibit): Remove; never set. All uses removed.
4196 * widgetprv.h (emacsFrameClassRec): Remove decl.
4197 * window.c (delete_deletable_window): Now returns void, since it
4198 wasn't returning anything.
4199 (compare_window_configurations): Remove unused locals.
4200 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4201 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4202 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4203 the same widths as pointers. This follows up on the 2011-05-06 patch.
4204 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4205 * xterm.h: Likewise.
4206 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4207
1384b89e
JB
42082011-06-12 Juanma Barranquero <lekktu@gmail.com>
4209
4210 * makefile.w32-in: Update dependencies.
4211 (LISP_H): Add lib/intprops.h.
4212
1100a63c
CY
42132011-06-11 Chong Yidong <cyd@stupidchicken.com>
4214
4215 * image.c (gif_load): Add animation frame delay to the metadata.
4216 (syms_of_image): Use DEFSYM. New symbol `delay'.
4217
6198ccd0
MR
42182011-06-11 Martin Rudalics <rudalics@gmx.at>
4219
4220 * window.c (delete_deletable_window): Re-add.
4221 (Fset_window_configuration): Rewrite to handle dead buffers and
4222 consequently deletable windows.
4223 (window_tree, Fwindow_tree): Remove. Supply functionality in
4224 window.el.
4225 (compare_window_configurations): Simplify code.
4226
b6e3633c
AS
42272011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4228
1ab0dee5
AS
4229 * image.c (imagemagick_load_image): Fix type mismatch.
4230 (Fimagemagick_types): Likewise.
4231
b6e3633c
AS
4232 * window.h (replace_buffer_in_windows): Declare.
4233
9397e56f
MR
42342011-06-11 Martin Rudalics <rudalics@gmx.at>
4235
4236 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4237 Qclone_number. Remove external declaration of Qdelete_window.
4238 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4239 code.
640c8776
SM
4240 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4241 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4242 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4243 buffer list implementation.
4244 (other_buffer_safely): New function.
4245 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4246 calls to replace_buffer_in_windows and
4247 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4248 if allowed.
4249 (record_buffer): Inhibit quitting and rewrite using quittable
4250 functions. Run Qbuffer_list_update_hook if allowed.
4251 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4252 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4253 Move switch-to-buffer to window.el.
9397e56f
MR
4254 (bury-buffer): Move to window.el.
4255 (Vbuffer_list_update_hook): New variable.
4256
4257 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4258 section.
4259
4260 * window.h (resize_frame_windows): Move up in code.
4261 (Fwindow_frame): Remove EXFUN.
4262 (replace_buffer_in_all_windows): Remove prototype.
4263 (replace_buffer_in_windows_safely): Add prototype.
4264
4265 * window.c: Declare Qdelete_window static again. Move down
4266 declaration of select_count.
4267 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4268 (Fother_window): Move to window.el.
4269 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4270 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4271 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4272 window.el.
4273 (replace_buffer_in_windows): Implement by calling
4274 Qreplace_buffer_in_windows.
4275 (replace_buffer_in_all_windows): Remove with some functionality
4276 moved into replace_buffer_in_windows_safely.
4277 (replace_buffer_in_windows_safely): New function.
4278 (select_window_norecord, select_frame_norecord): Move in front
4279 of run_window_configuration_change_hook. Remove now obsolete
4280 declarations.
640c8776
SM
4281 (Fset_window_buffer): Rewrite doc-string.
4282 Call Qrecord_window_buffer.
9397e56f
MR
4283 (keys_of_window): Move binding for other-window to window.el.
4284
b50691aa
CY
42852011-06-11 Chong Yidong <cyd@stupidchicken.com>
4286
4287 * dispextern.h (struct image): Replace data member, whose int_val
4288 and ptr_val fields were not used by anything, with a single
4289 lisp_val object.
4290
4291 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4292 (gif_clear_image, gif_load, imagemagick_load_image)
4293 (gs_clear_image, gs_load): Callers changed.
4294
3f754b86
PE
42952011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4296
cca69397
PE
4297 * buffer.h: Include <time.h>, for time_t.
4298 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4299
109e28d0
PE
4300 Fix minor problems found by static checking.
4301
60737f02
PE
4302 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4303
4b66faf3
PE
4304 Make identifiers static if they are not used in other modules.
4305 * data.c (Qcompiled_function, Qframe, Qvector):
4306 * image.c (QimageMagick, Qsvg):
4307 * minibuf.c (Qmetadata):
4308 * window.c (resize_window_check, resize_root_window): Now static.
4309 * window.h (resize_window_check, resize_root_window): Remove decls.
4310
109e28d0
PE
4311 * window.c (window_deletion_count, delete_deletable_window):
4312 Remove; unused.
46a4ce9e
PE
4313 (window_body_lines): Now static.
4314 (Fdelete_other_windows_internal): Mark vars as initialized.
4315 Make sure 'resize_failed' is initialized.
4316 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4317 (resize_window_apply): Remove unused local.
4318 * window.h (delete_deletable_window): Remove decl.
4319
109e28d0 4320 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4321 (imagemagick_load_image): Fix pointer signedness problem by changing
4322 last arg from unsigned char * to char *. All uses changed.
4323 Also, fix a local for similar reasons.
4324 Remove unused locals. Remove locals to avoid shadowing.
4325 (fn_rsvg_handle_free): Remove; unused.
4326 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4327 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4328
3f754b86
PE
4329 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4330
2547adb1
CY
43312011-06-10 Chong Yidong <cyd@stupidchicken.com>
4332
4333 * image.c (gif_load): Fix omitted cast error introduced by
4334 2011-06-06 change.
4335
2c8e37d4
MR
43362011-06-10 Martin Rudalics <rudalics@gmx.at>
4337
4338 * window.h (resize_proportionally, orig_total_lines)
4339 (orig_top_line): Remove from window structure.
4340 (set_window_height, set_window_width, change_window_heights)
4341 (Fdelete_window): Remove prototypes.
4342 (resize_frame_windows): Remove duplicate declaration.
4343
440a42e3
EZ
43442011-06-10 Eli Zaretskii <eliz@gnu.org>
4345
4346 * window.h (resize_frame_windows, resize_window_check)
4347 (delete_deletable_window, resize_root_window)
4348 (resize_frame_windows): Declare prototypes.
4349
4350 * window.c (resize_window_apply): Make definition be "static" to
4351 match the prototype.
4352
562dd5e9
MR
43532011-06-10 Martin Rudalics <rudalics@gmx.at>
4354
4355 * window.c: Remove declarations of Qwindow_size_fixed,
4356 window_min_size_1, window_min_size_2, window_min_size,
4357 size_window, window_fixed_size_p, enlarge_window, delete_window.
4358 Remove static from declaration of Qdelete_window, it's
4359 temporarily needed by Fbury_buffer.
4360 (replace_window): Don't assign orig_top_line and
4361 orig_total_lines.
4362 (Fdelete_window, delete_window): Remove. Window deletion is
4363 handled by window.el.
640c8776
SM
4364 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4365 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4366 (Fdelete_other_windows): Remove. Deleting other windows is
4367 handled by window.el.
4368 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4369 handled in window.el.
4370 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4371 Window minimum sizes are handled in window.el.
4372 (shrink_windows, size_window, set_window_height)
4373 (set_window_width, change_window_heights, window_height)
4374 (window_width, CURBEG, CURSIZE, enlarge_window)
4375 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4376 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4377 handled in window.el.
4378 (make_dummy_parent): Rename to make_parent_window and give it a
4379 second argument horflag.
4380 (make_window): Don't set resize_proportionally any more.
4381 (Fsplit_window): Remove. Windows are split in window.el.
4382 (save_restore_action, save_restore_orig_size)
4383 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4384 Resize mini windows in window.el.
4385 (grow_mini_window, shrink_mini_window): Implement by calling
4386 Qresize_root_window_vertically, resize_window_check and
4387 resize_window_apply.
640c8776
SM
4388 (saved_window, Fset_window_configuration, save_window_save):
4389 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4390 resize_proportionally.
4391 (window_min_height, window_min_width): Move to window.el.
4392 (keys_of_window): Move bindings for delete-other-windows,
4393 split-window, delete-window and enlarge-window to window.el.
4394
4395 * buffer.c: Temporarily extern Qdelete_window.
4396 (Fbury_buffer): Temporarily call Qdelete_window instead of
4397 Fdelete_window (Fbury_buffer will move to window.el soon).
4398
4399 * frame.c (set_menu_bar_lines_1): Remove code handling
4400 orig_top_line and orig_total_lines.
4401
4402 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4403 set_window_height but set heights directly.
4404 (change_frame_size_1): Use resize_frame_windows.
4405
4406 * xdisp.c (init_xdisp): Don't use set_window_height but set
4407 heights directly.
4408
640c8776
SM
4409 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4410 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4411 run_window_configuration_change_hook.
4412
4413 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4414 instead of change_window_heights and run
4415 run_window_configuration_change_hook.
4416
1a13852e
MR
44172011-06-09 Martin Rudalics <rudalics@gmx.at>
4418
4419 * window.c (replace_window): Rename second argument REPLACEMENT to
4420 NEW. New third argument SETFLAG. Rewrite.
4421 (delete_window, make_dummy_parent): Call replace_window with
4422 third argument 1.
4423 (window_list_1): Move down in code.
4424 (run_window_configuration_change_hook): Move set_buffer part
4425 before select_frame_norecord part in order to unwind correctly.
4426 Rename count1 to count.
4427 (recombine_windows, delete_deletable_window, resize_root_window)
4428 (Fdelete_other_windows_internal)
4429 (Frun_window_configuration_change_hook, make_parent_window)
4430 (resize_window_check, resize_window_apply, Fresize_window_apply)
4431 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4432 (Fdelete_window_internal, Fresize_mini_window_internal):
4433 New functions.
1a13852e
MR
4434 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4435
f3d1777e
MR
44362011-06-08 Martin Rudalics <rudalics@gmx.at>
4437
496e208e
MR
4438 * window.h (window): Add some new members to window structure -
4439 normal_lines, normal_cols, new_total, new_normal, clone_number,
4440 splits, nest, prev_buffers, next_buffers.
4441 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4442 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4443
f3d1777e
MR
4444 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4445 Remove.
496e208e
MR
4446 (make_dummy_parent): Set new members of windows structure.
4447 (make_window): Move down in code. Handle new members of window
4448 structure.
4449 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4450 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4451 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4452 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4453 (Fset_window_next_buffers, Fset_window_clone_number):
4454 New functions.
496e208e
MR
4455 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4456 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4457 Doc-string fixes.
4458 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4459 Argument WINDOW can be now internal window too.
4460 (Fwindow_use_time): Move up in code.
4461 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4462 Rewrite doc-string.
4463 (Fset_window_configuration, saved_window)
4464 (Fcurrent_window_configuration, save_window_save): Handle new
4465 members of window structure.
b9e809c2
MR
4466 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4467 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4468 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4469 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4470 Qget_mru_window, Qresize_root_window,
4471 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4472 Qauto_buffer_name; staticpro them.
f3d1777e 4473
abde8f8c
MR
44742011-06-07 Martin Rudalics <rudalics@gmx.at>
4475
4476 * window.c (Fwindow_total_size, Fwindow_left_column)
4477 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4478 (Fwindow_list_1): New functions.
4479 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4480 (Fwindow_width, Fscroll_left, Fscroll_right):
4481 Use window_body_cols instead of window_box_text_cols.
4482 (delete_window, Fset_window_configuration):
4483 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4484 (delete_all_subwindows): Take a window as argument and not a
4485 structure. Rewrite.
190b47e6
MR
4486 (window_loop): Remove handling of GET_LRU_WINDOW and
4487 GET_LARGEST_WINDOW.
4488 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4489
4490 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4491 window_box_text_cols. delete_all_subwindows now takes a
4492 Lisp_Object as argument.
abde8f8c 4493
640c8776
SM
4494 * indent.c (compute_motion, Fcompute_motion):
4495 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4496
fa8a67e6
MR
4497 * frame.c (delete_frame): Call delete_all_subwindows with root
4498 window as argument.
4499
a54e3482
DC
45002011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4501
4502 * fns.c (Fputhash): Document return value.
4503
60002bf5
CY
45042011-06-06 Chong Yidong <cyd@stupidchicken.com>
4505
4506 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4507
0c671da6 45082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4509
b862a52a 4510 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4511
be44ca6c
PE
4512 Check for overflow when converting integer to cons and back.
4513 * charset.c (Fdefine_charset_internal, Fdecode_char):
4514 Use cons_to_unsigned to catch overflow.
4515 (Fencode_char): Use INTEGER_TO_CONS.
4516 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4517 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4518 * data.c (long_to_cons, cons_to_long): Remove.
4519 (cons_to_unsigned, cons_to_signed): New functions.
4520 These signal an error for invalid or out-of-range values.
4521 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4522 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4523 * font.c (Ffont_variation_glyphs):
4524 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4525 * lisp.h: Include <intprops.h>.
4526 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4527 (cons_to_signed, cons_to_unsigned): New decls.
4528 (long_to_cons, cons_to_long): Remove decls.
4529 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4530 (Fprimitive_undo): Use CONS_TO_INTEGER.
4531 * xfns.c (Fx_window_property): Likewise.
4532 * xselect.c: Include <limits.h>.
4533 (x_own_selection, selection_data_to_lisp_data):
4534 Use INTEGER_TO_CONS.
4535 (x_handle_selection_request, x_handle_selection_clear)
4536 (x_get_foreign_selection, Fx_disown_selection_internal)
4537 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4538 (lisp_data_to_selection_data): Use cons_to_unsigned.
4539 (x_fill_property_data): Use cons_to_signed.
4540 Report values out of range.
4541
d1f3d2af
PE
4542 Check for buffer and string overflow more precisely.
4543 * buffer.h (BUF_BYTES_MAX): New macro.
4544 * lisp.h (STRING_BYTES_MAX): New macro.
4545 * alloc.c (Fmake_string):
4546 * character.c (string_escape_byte8):
4547 * coding.c (coding_alloc_by_realloc):
4548 * doprnt.c (doprnt):
4549 * editfns.c (Fformat):
4550 * eval.c (verror):
4551 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4552 since they may not be the same number.
4553 * editfns.c (Finsert_char):
4554 * fileio.c (Finsert_file_contents):
4555 Likewise for BUF_BYTES_MAX.
4556
dd52fcea
PE
4557 * image.c: Use ptrdiff_t, not int, for sizes.
4558 (slurp_file): Switch from int to ptrdiff_t.
4559 All uses changed.
4560 (slurp_file): Check that file size fits in both size_t (for
4561 malloc) and ptrdiff_t (for sanity and safety).
4562
7f9bbdbb
PE
4563 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4564 if b->modtime has its maximal value.
4565
dfe18f82
PE
4566 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4567
84acfcf0
PE
4568 Don't assume time_t can fit into int.
4569 * buffer.h (struct buffer.modtime): Now time_t, not int.
4570 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4571 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4572
ccd9a01a
PE
4573 Minor fixes for signed vs unsigned integers.
4574 * character.h (MAYBE_UNIFY_CHAR):
4575 * charset.c (maybe_unify_char):
4576 * keyboard.c (read_char, reorder_modifiers):
4577 XINT -> XFASTINT, since the integer must be nonnegative.
4578 * ftfont.c (ftfont_spec_pattern):
4579 * keymap.c (access_keymap, silly_event_symbol_error):
4580 XUINT -> XFASTINT, since the integer must be nonnegative.
4581 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4582 since it makes no difference and we prefer signed.
4583 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4584 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4585 nonnegative.
4586
d6d100dd
SM
45872011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4588
4589 * window.h (Fwindow_frame): Declare.
4590
2b6148e4
PE
45912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4594 (SPARE_MEMORY): Always define.
4595 (LARGE_REQUEST): Remove.
4596 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4597
f230ecc9
MR
45982011-06-06 Martin Rudalics <rudalics@gmx.at>
4599
727e958e
MR
4600 * lisp.h: Move EXFUNS for Fframe_root_window,
4601 Fframe_first_window and Fset_frame_selected_window to window.h.
4602
4603 * window.h: Move EXFUNS for Fframe_root_window,
4604 Fframe_first_window and Fset_frame_selected_window here from
4605 lisp.h.
4606
4607 * frame.c (Fwindow_frame, Fframe_first_window)
4608 (Fframe_root_window, Fframe_selected_window)
4609 (Fset_frame_selected_window): Move to window.c.
4610 (Factive_minibuffer_window): Move to minibuf.c.
4611 (Fother_visible_frames_p): New function.
4612
4613 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4614
f230ecc9
MR
4615 * window.c (decode_window, decode_any_window): Move up in code.
4616 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4617 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4618 (Fwindow_buffer): Move up and rewrite doc-string.
4619 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4620 (Fwindow_prev): New functions.
727e958e
MR
4621 (Fwindow_frame): Move here from frame.c. Accept any window as
4622 argument.
4623 (Fframe_root_window, Fframe_first_window)
4624 (Fframe_selected_window): Move here from frame.c. Accept frame
4625 or arbitrary window as argument. Update doc-strings.
4626 (Fminibuffer_window): Move up in code.
4627 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4628 (Fset_frame_selected_window): Move here from frame.c.
4629 Marginal rewrite.
727e958e
MR
4630 (Fselected_window, select_window, Fselect_window): Move up in
4631 code. Minor doc-string fixes.
f230ecc9 4632
4d09bcf6
PE
46332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4636 Do not assume that spare memory exists; that assumption is valid
4637 only if SYSTEM_MALLOC.
4638 (LARGE_REQUEST): New macro, so that the issue of large requests
4639 is separated from the issue of spare memory.
4640
810928a2
AS
46412011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4642
172418ad
AS
4643 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4644 format. (Bug#8806)
4645
43f862f7
AS
4646 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4647
810928a2
AS
4648 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4649 before statements.
4650
a059fe24
JD
46512011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4652
4653 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4654
4655 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4656
4657 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4658 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4659
989bf368
JB
46602011-06-05 Juanma Barranquero <lekktu@gmail.com>
4661
4662 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4663
4b80f674
CY
46642011-06-04 Chong Yidong <cyd@stupidchicken.com>
4665
4666 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4667 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4668 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4669 New error handlers.
4b80f674
CY
4670 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4671 Obey Vx_select_enable_clipboard_manager. Catch errors in
4672 x_clipboard_manager_save (Bug#8779).
4673 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4674 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4675
99a33b77 46762011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4677
4678 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4679
99a33b77 46802011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4681
4682 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4683 in the current matrix if keep_current_p is non-zero.
4684
8264569d
EZ
46852011-06-04 Eli Zaretskii <eliz@gnu.org>
4686
4687 * bidi.c (bidi_level_of_next_char): Fix last change.
4688
57f97249
EZ
46892011-06-03 Eli Zaretskii <eliz@gnu.org>
4690
fec2107c 4691 Support bidi reordering of text covered by display properties.
57f97249 4692
fec2107c
EZ
4693 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4694 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4695 (bidi_cache_search, bidi_cache_iterator_state)
4696 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4697 (bidi_level_of_next_char, bidi_move_to_visually_next):
4698 Support character positions inside a run of characters covered by a
fec2107c
EZ
4699 display string.
4700 (bidi_paragraph_init, bidi_resolve_explicit_1)
4701 (bidi_level_of_next_char): Call bidi_fetch_char and
4702 bidi_fetch_char_advance instead of FETCH_CHAR and
4703 FETCH_CHAR_ADVANCE.
4704 (bidi_init_it): Initialize new members.
4705 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4706 definitions.
4707 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4708 instead of using explicit *_CHAR codes.
d6d100dd
SM
4709 (bidi_resolve_explicit, bidi_resolve_weak):
4710 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4711 bidirectional text is supported only in multibyte buffers.
4712 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4713 it to initialize the frame_window_p member of struct bidi_it.
4714 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4715 (bidi_resolve_explicit, bidi_resolve_weak)
4716 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4717 bidi_it->nchars is non-positive.
4718 (bidi_level_of_next_char): Don't try to lookup the cache for the
4719 next/previous character if nothing is cached there yet, or if we
4720 were just reseat()'ed to a new position.
c40e2fb2 4721
0e14fe90
EZ
4722 * xdisp.c (set_cursor_from_row): Set start and stop points
4723 according to the row's direction when priming the loop that looks
4724 for the glyph on which to display cursor.
4725 (single_display_spec_intangible_p): Function deleted.
4726 (display_prop_intangible_p): Reimplement to call
4727 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4728 Accept 3 additional arguments needed by handle_display_spec.
4729 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4730 values: lists, `(when COND...)' forms, etc.
4731 (single_display_spec_string_p): Support property values that are
4732 lists with the argument STRING its top-level element.
4733 (display_prop_string_p): Fix the condition for processing a
4734 property that is a list to be consistent with handle_display_spec.
fec2107c 4735 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4736 last portion of handle_display_prop.
4737 (compute_display_string_pos): Accept additional argument
4738 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4739 value of a `display' property is a "replacing spec".
4740 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4741 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4742 the display property, but just return a value indicating whether
4743 the display property will replace the characters it covers.
4744 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4745 frame_window_p members of struct bidi_it.
d6d100dd
SM
4746 (compute_display_string_pos, compute_display_string_end):
4747 New functions.
fec2107c
EZ
4748 (push_it): Accept second argument POSITION, where pop_it should
4749 jump to continue iteration.
4750 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4751
fec2107c
EZ
4752 * keyboard.c (adjust_point_for_property): Adjust the call to
4753 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4754
4755 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4756 (bidi_init_it): Update prototypes.
4757 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4758 (compute_display_string_pos, compute_display_string_end):
4759 Declare prototypes.
fec2107c
EZ
4760 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4761 EMACS_INT.
fc6f18ce 4762
40087514 47632011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4764
57f53182
PE
4765 Malloc failure behavior now depends on size of allocation.
4766 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4767 * lisp.h: Change signatures accordingly.
4768 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4769 All callers changed. (Bug#8762)
4770
4771 * gnutls.c: Use Emacs's memory allocators.
4772 Without this change, the gnutls library would invoke malloc etc.
4773 directly, which causes problems on non-SYNC_INPUT hosts, and which
4774 runs afoul of improving memory_full behavior. (Bug#8761)
4775 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4776 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4777 xfree instead of the default malloc, realloc, free.
4778 (Fgnutls_boot): No need to check for memory allocation failure,
4779 since xmalloc does that for us.
4780
ac32cd99 4781 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4782 * category.c (hash_get_category_set):
4783 * ccl.c (ccl_driver):
4784 * charset.c (Fdefine_charset_internal):
4785 * charset.h (struct charset.hash_index):
4786 * composite.c (get_composition_id, gstring_lookup_cache)
4787 (composition_gstring_put_cache):
4788 * composite.h (struct composition.hash_index):
4789 * dispextern.h (struct image.hash):
4790 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4791 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4792 (hashfn_equal, hashfn_user_defined, make_hash_table)
4793 (maybe_resize_hash_table, hash_lookup, hash_put)
4794 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4795 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4796 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4797 * image.c (make_image, search_image_cache, lookup_image)
4798 (xpm_put_color_table_h):
4799 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4800 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4801 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4802 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4803 * alloc.c (allocate_vectorlike):
4804 Check for overflow in vector size calculations.
4805 * ccl.c (ccl_driver):
4806 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4807 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4808 need to be updated by these changes.
40087514
PE
4809 * fns.c (make_hash_table, maybe_resize_hash_table):
4810 Check for integer overflow with large hash tables.
0de4bb68
PE
4811 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4812 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4813 (SXHASH_REDUCE): New macro.
4814 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4815 Use it instead of discarding useful hash info with large hash values.
4816 (sxhash_float): New function.
4817 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4818 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4819 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4820 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4821 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4822 Adjust signatures to match updated version of code.
4823 (consing_since_gc): Now EMACS_INT, since a single hash table can
4824 use more than INT_MAX bytes.
4825
698d32e2
DN
48262011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4827
4828 Make it possible to build with GCC-4.6+ -O2 -flto.
4829
4830 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4831
fd6fa53f
SM
48322011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4833
4834 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4835 Call minibuffer-inactive-mode.
4836
864db017
JB
48372011-05-31 Juanma Barranquero <lekktu@gmail.com>
4838
4839 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4840 Update dependencies.
4841
2ad0baf4
DN
48422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4843
4844 * data.c (init_data): Remove code for UTS, this system is not
4845 supported anymore.
4846
4fcc2638
DN
48472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4848
4849 Don't force ./temacs to start in terminal mode.
4850
4851 * frame.c (make_initial_frame): Initialize faces in all cases, not
4852 only when CANNOT_DUMP is defined.
4853 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4854
c56e0fd5
DN
48552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4856
4857 * dispnew.c (add_window_display_history): Use const for the string
4858 pointer. Remove declaration, not needed.
4859
333d54da 48602011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4861
55d4c1b2 4862 Use 'inline', not 'INLINE'.
333d54da 4863 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4864 * alloc.c, fontset.c (INLINE): Remove.
4865 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4866 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4867 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4868 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4869 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4870
738db178
DN
48712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4872
4873 Make it possible to run ./temacs.
4874
4875 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4876 syms_of_callproc does the same thing. Remove test for
4877 "initialized", do it in the caller.
4878 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4879
620c53a6
SM
48802011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4881
4882 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4883 (read_minibuf): Use get_minibuffer.
4884 (syms_of_minibuf): Use DEFSYM.
4885 (Qmetadata): New var.
4886 * data.c (Qbuffer): Don't make it static.
4887 (syms_of_data): Use DEFSYM.
4888
e003a292
PE
48892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4892 (CCL_CODE_MIN): New macro.
4893
ed008a6d
PE
48942011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4895
3687c2ef
PE
4896 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4897
ed008a6d
PE
4898 * eval.c (Qdebug): Now static.
4899 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4900 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4901 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4902
d66c4c7c
CY
49032011-05-29 Chong Yidong <cyd@stupidchicken.com>
4904
4905 * image.c: Various fixes to ImageMagick code comments.
4906 (Fimagemagick_types): Doc fix.
4907
5fbc2025
PE
49082011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4909
0196f88a
PE
4910 Minor fixes prompted by GCC 4.6.0 warnings.
4911
4912 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4913
5fbc2025
PE
4914 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4915 (x_clipboard_manager_save_all): Move extern decl to ...
4916 * xterm.h: ... here, so that it can be checked for consistency.
4917
1dd3c2d9
CY
49182011-05-29 Chong Yidong <cyd@stupidchicken.com>
4919
4920 * xselect.c (x_clipboard_manager_save_frame)
4921 (x_clipboard_manager_save_all): New functions.
4922 (Fx_clipboard_manager_save): Lisp function deleted.
4923
4924 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4925 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4926
4927 * xterm.h: Update prototype.
4928
5ba6571d
WX
49292011-05-28 William Xu <william.xwl@gmail.com>
4930
4931 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4932 exiting (Bug#8239).
4933
3eaff834
JM
49342011-05-28 Jim Meyering <meyering@redhat.com>
4935
e1900994 4936 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4937 * fns.c (to_uchar): Define.
4938 (crypto_hash_function): Use it to convert some newly-signed
4939 variables to unsigned, to avoid sign-extension bugs. For example,
4940 without this change, (md5 "truc") would evaluate to
4941 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4942 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4943 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4944
0f6990a7
PE
49452011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4946
4947 Integer overflow fixes.
c8a9ca5a 4948
08686060
PE
4949 * dbusbind.c: Serial number integer overflow fixes.
4950 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4951 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4952 to hold a serial number that is too large for a fixnum.
4953 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4954 Check for serial numbers out of range. Decode any serial number
59568bf0 4955 that was so large that it became a float. (Bug#8722)
08686060 4956
2d1fc3c7
PE
4957 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4958 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4959 Use XFASTINT rather than XUINT when numbers are nonnegative.
4960 (xd_append_arg, Fdbus_method_return_internal):
4961 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4962 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4963 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4964 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4965 (Bug#8722)
2d1fc3c7 4966
c8a9ca5a
PE
4967 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4968
519e1d69
PE
4969 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4970
30569699
PE
4971 ccl: add integer overflow checks
4972 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4973 (IN_INT_RANGE): New macros.
4974 (ccl_driver): Use them to check for integer overflow when
4975 decoding a CCL program. Many of the new checks are whether XINT (x)
4976 fits in int; it doesn't always, on 64-bit hosts. The new version
4977 doesn't catch all possible integer overflows, but it's an
847044ea 4978 improvement. (Bug#8719)
30569699 4979
c11285dc
PE
4980 * alloc.c (make_event_array): Use XINT, not XUINT.
4981 There's no need for unsigned here.
4982
fdccd48e
PE
4983 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4984 This follows up to the 2011-05-06 change that substituted uintptr_t
4985 for EMACS_INT. This case wasn't caught back then.
4986
37910ab2
PE
4987 Rework Fformat to avoid integer overflow issues.
4988 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4989 now (part of C89). Include <verify.h>.
4990 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4991 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4992 (Fformat): Avoid the prepass trying to compute sizes; it was only
4993 approximate and thus did not catch overflow reliably. Instead, walk
4994 through the format just once, formatting and computing sizes as we go,
4995 checking for integer overflow at every step, and allocating a larger
4996 buffer as needed. Keep track separately whether the format is
4997 multibyte. Keep only the most-recently calculated precision, rather
4998 than them all. Record whether each argument has been converted to
4999 string. Use EMACS_INT, not int, for byte and char and arg counts.
5000 Support field widths and precisions larger than INT_MAX. Avoid
5001 sprintf's undefined behavior with conversion specifications such as %#d
5002 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5003 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5004 formatting out-of-range floating point numbers with int
9173deec 5005 formats. (Bug#8668)
37910ab2 5006
2e6578fb
PE
5007 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5008
0ae6bdee
PE
5009 * data.c: Avoid integer truncation in expressions involving floats.
5010 * data.c: Include <intprops.h>.
5011 (arith_driver): When there's an integer overflow in an expression
5012 involving floating point, convert the integers to floating point
5013 so that the resulting value does not suffer from catastrophic
5014 integer truncation. For example, on a 64-bit host (* 4
5015 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5016 Do not rely on undefined behavior after integer overflow.
5017
de883a70
PE
5018 merge count_size_as_multibyte, parse_str_to_multibyte
5019 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5020 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5021 Check for integer overflow.
5022 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5023 since it's now a duplicate of the other. This is more of
5024 a character than a buffer op, so better that it's in character.c.
5025 * fns.c, print.c: Adjust to above changes.
5026
2ff916cb
PE
50272011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5028
5029 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5030
f1b54466
PE
50312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5032
fb1ac845
PE
5033 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5034 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5035 (x_clipboard_manager_save): Now static.
5036 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5037
f1b54466
PE
5038 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5039 (crypto_hash_function): Now static.
5040 Fix pointer signedness problems. Avoid unnecessary initializations.
5041
a9f737ee
CY
50422011-05-27 Chong Yidong <cyd@stupidchicken.com>
5043
5044 * termhooks.h (Vselection_alist): Make it terminal-local.
5045
5046 * terminal.c (create_terminal): Initialize it.
5047
5048 * xselect.c: Support for clipboard managers.
5049 (Vselection_alist): Move to termhooks.h as terminal-local var.
5050 (LOCAL_SELECTION): New macro.
5051 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5052 (symbol_to_x_atom): Remove gratuitous arg.
5053 (x_handle_selection_request, lisp_data_to_selection_data)
5054 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5055 (x_own_selection, x_get_local_selection, x_convert_selection):
5056 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5057 (some_frame_on_display): Delete unused function.
5058 (Fx_own_selection_internal, Fx_get_selection_internal)
5059 (Fx_disown_selection_internal, Fx_selection_owner_p)
5060 (Fx_selection_exists_p): New optional frame arg.
5061 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5062 (x_handle_selection_clear): Don't treat other terminals with the
5063 same keyboard specially. Use the terminal-local Vselection_alist.
5064 (x_clear_frame_selections): Use Frun_hook_with_args.
5065
5066 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5067
5068 * xterm.h: Add support for those atoms.
5069
e067f0c1
CY
50702011-05-26 Chong Yidong <cyd@stupidchicken.com>
5071
5072 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5073 (converted_selections, conversion_fail_tag): New global variables.
5074 (x_selection_request_lisp_error): Free the above.
5075 (x_get_local_selection): Remove unnecessary code.
5076 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5077 of converted selections stored in converted_selections.
5078 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5079 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5080 (x_convert_selection): New function.
5081 (x_handle_selection_event): Simplify.
5082 (x_get_foreign_selection): Don't ignore incoming requests while
5083 waiting for an answer; this will fail when we implement
5084 SAVE_TARGETS, and seems unnecessary anyway.
5085 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5086 (Vx_sent_selection_functions): Doc fix.
5087
0f4aebc0
LL
50882011-05-26 Leo Liu <sdl.web@gmail.com>
5089
5090 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5091
e61124cd
YM
50922011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5093
5094 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5095
5096 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5097 for fringe update if it has periodic bitmap.
ac389d0c 5098 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5099 and fringe_bitmap_periodic_p.
5100
5101 * fringe.c (get_fringe_bitmap_data): New function.
5102 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5103 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5104 row. Mark glyph row for fringe update if periodicity changed.
5105
5106 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5107 for fringe update unless it has periodic bitmap.
5108
f16d9837
KH
51092011-05-25 Kenichi Handa <handa@m17n.org>
5110
5111 * xdisp.c (get_next_display_element): Set correct it->face_id for
5112 a static composition.
5113
e1b90ef6
LL
51142011-05-24 Leo Liu <sdl.web@gmail.com>
5115
5116 * deps.mk (fns.o):
5117 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5118
5119 * fns.c (crypto_hash_function, Fsha1): New function.
5120 (Fmd5): Use crypto_hash_function.
5121 (syms_of_fns): Add Ssha1.
5122
7400048f
PE
51232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5124
5125 * gnutls.c: Remove unused macros.
5126 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5127 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5128 Remove macros that are defined and never used.
5129 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5130
abb71cf4
CY
51312011-05-22 Chong Yidong <cyd@stupidchicken.com>
5132
5133 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5134 (Fx_get_selection_internal): Minor cleanup.
5135 (Fx_own_selection_internal): Rename arguments for consistency with
5136 select.el.
5137
6307db39
PE
51382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5139
5140 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5141
f3d4e0a4
CY
51422011-05-22 Chong Yidong <cyd@stupidchicken.com>
5143
5144 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5145
4d8ade89
YM
51462011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5147
5148 * dispnew.c (scrolling_window): Don't exclude the case that the
5149 last enabled row in the desired matrix touches the bottom boundary.
5150
32078c8d
GM
51512011-05-21 Glenn Morris <rgm@gnu.org>
5152
5153 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5154 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5155 and add some more files.
32078c8d 5156
7285dc67
EZ
51572011-05-20 Eli Zaretskii <eliz@gnu.org>
5158
5159 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5160 report_file_error introduced by the change from 2011-05-07.
5161
89d1bd22
PE
51622011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5163
5164 * systime.h (Time): Define only if emacs is defined.
5165 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5166 where the include path doesn't have X11/X.h by default. See
5167 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5168
e23640bb 51692011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5170
5171 * composite.c (find_automatic_composition): Fix previous change.
5172
b9704ad9
GM
51732011-05-20 Glenn Morris <rgm@gnu.org>
5174
5175 * lisp.mk: New file, split from Makefile.in.
5176 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5177 (shortlisp): Remove.
5178 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5179
4a720484
GM
51802011-05-19 Glenn Morris <rgm@gnu.org>
5181
5182 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5183 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5184 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5185 (lisp): Set the order to that of loadup.el.
5186 (shortlisp): Make it a copy of $lisp.
5187 (SOME_MACHINE_LISP): Remove.
5188 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5189 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5190
a28d4396
KH
51912011-05-18 Kenichi Handa <handa@m17n.org>
5192
5193 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5194 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5195 (find_automatic_composition): Mostly rewrite for efficiency.
5196
a2b1fa8e
JB
51972011-05-18 Juanma Barranquero <lekktu@gmail.com>
5198
5199 * makefile.w32-in: Update dependencies.
5200
8e1f5610
CS
52012011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5202
5203 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5204 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5205
7025ee00 52062011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5207
cdfa6eab
PE
5208 Fix some integer overflow issues, such as string length overflow.
5209
06d6db33
PE
5210 * insdel.c (count_size_as_multibyte): Check for string overflow.
5211
2b4560a8
PE
5212 * character.c (lisp_string_width): Check for string overflow.
5213 Use EMACS_INT, not int, for string indexes and lengths; in
5214 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5215 the resulting string length overflows an EMACS_INT; instead,
5216 report a string overflow if no precision given. When checking for
5217 precision exhaustion, use a check that cannot possibly have
5218 integer overflow. (Bug#8675)
5219 * character.h (lisp_string_width): Adjust to new signature.
5220
cb93f9be
PE
5221 * alloc.c (string_overflow): New function.
5222 (Fmake_string): Use it. This doesn't change behavior, but saves
5223 a few bytes and will simplify future changes.
5224 * character.c (string_escape_byte8): Likewise.
5225 * lisp.h (string_overflow): New decl.
5226
1a1f3366
PE
5227 Fixups, following up to the user-interface timestamp change.
5228 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5229 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5230 * msdos.c (mouse_get_pos): Likewise.
5231 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5232 * w32gui.h (Time): Define by including "systime.h" rather than by
5233 declaring it ourselves. (Bug#8664)
5234
d4e3e4d3
PE
5235 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5236 * image.c (clear_image_cache): Likewise.
5237
f6a24d19
PE
5238 * term.c (term_mouse_position): Don't assume time_t wraparound.
5239
08dc5ae6
PE
5240 Be more systematic about user-interface timestamps.
5241 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5242 and sometimes 'EMACS_UINT', to represent these timestamps.
5243 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5244 This makes the code easier to follow, and makes it easier to catch
5245 integer overflow bugs such as Bug#8664.
5246 * frame.c (Fmouse_position, Fmouse_pixel_position):
5247 Use Time, not unsigned long, for user-interface timestamps.
5248 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5249 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5250 * keyboard.h (last_event_timestamp): Likewise.
5251 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5252 * menu.h (xmenu_show): Likewise.
5253 * term.c (term_mouse_position): Likewise.
5254 * termhooks.h (struct input_event.timestamp): Likewise.
5255 (struct terminal.mouse_position_hook): Likewise.
5256 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5257 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5258 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5259 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5260 what it was before.
5261 * menu.h, termhooks.h: Include "systime.h", for Time.
5262
8e55734a
PE
5263 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5264 Don't assume that the difference between two unsigned long values
5265 can fit into an integer. At this point, we know button_down_time
5266 <= event->timestamp, so the difference must be nonnegative, so
5267 there's no need to cast the result if double-click-time is
5268 nonnegative, as it should be; check that it's nonnegative, just in
5269 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5270 apart (about 25 days). (Bug#8664)
8e55734a 5271
841f1b75 5272 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5273 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5274
3e26f69c
PE
5275 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5276 that always fit in int. Use a sentinel instead of a counter, to
5277 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5278 * frame.h (struct frame): Use int for menu_bar_items_used
5279 instead of EMACS_INT, since it always fits in int.
3e26f69c 5280
5cc152c0
PE
5281 * menu.c (grow_menu_items): Check for int overflow.
5282
d89eb65e
PE
5283 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5284
5235bd3e
PE
5285 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5286 Before, the code was not consistent. These values cannot exceed
5287 2**31 - 1 so there's no need to make them unsigned.
5288 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5289 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5290 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5291 as modifiers.
5292 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5293
bc827e23
PE
5294 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5295 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5296 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5297 presumably because the widths might not match.
5298
78eb494e
PE
5299 * window.c (size_window): Avoid needless test at loop start.
5300
04f2d78b
CB
53012011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5302
5303 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5304
d2fc7e3d 53052011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5306
5307 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5308
d2fc7e3d 53092011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5310
5311 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5312 `width' to `bar_area_x' and `bar_area_width', respectively.
5313 (x_scroll_run): Take account of fringe background extension.
5314
04f2d78b
CB
5315 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5316 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5317 `bar_area_width', respectively.
5318 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5319 background extension.
5320
79b70037
GM
53212011-05-10 Jim Meyering <meyering@redhat.com>
5322
5323 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5324
2f142cc5
JB
53252011-05-10 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * image.c (Finit_image_library): Return t for built-in image types,
5328 like pbm and xbm. (Bug#8640)
5329
57679c86
AS
53302011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5331
5332 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5333
888c9e86
EZ
53342011-05-07 Eli Zaretskii <eliz@gnu.org>
5335
b0512a1d
EZ
5336 * w32console.c (Fset_screen_color): Doc fix.
5337 (Fget_screen_color): New function.
5338 (syms_of_ntterm): Defsubr it.
5339
7285dc67
EZ
5340 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5341 unlink the temporary file if Fcall_process didn't create it in the
5342 first place.
5343 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5344 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5345 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5346 cue to call_process_cleanup not to close that handle.
5347
4d3fcc8e
BK
53482011-05-07 Ben Key <bkey76@gmail.com>
5349
5350 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5351 one of two shell specific rules, either bootstrap-temacs-CMD or
5352 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5353 to the previous implementation of the bootstrap-temacs rule.
5354 The bootstrap-temacs-CMD rule is similar to the previous
5355 implementation of the bootstrap-temacs rule except that it
5356 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5357 variable.
5358
5359 These changes, along with some changes to nt/configure.bat,
5360 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5361 earlier fix to add support for --cflags and --ldflags options
5362 that include quotes so that it works whether make uses cmd or
5363 sh as the shell.
5364
b4289b64
MA
53652011-05-06 Michael Albinus <michael.albinus@gmx.de>
5366
5367 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5368 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5369 is a constant.
5370 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5371 a string. Handle both cases.
5372 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5373 (Fdbus_register_method): Use Qinvalid_function.
5374
af4c0e28
JB
53752011-05-06 Juanma Barranquero <lekktu@gmail.com>
5376
5377 * makefile.w32-in: Update dependencies.
5378 (LISP_H): Add inttypes.h and stdin.h.
5379 (PROCESS_H): Add unistd.h.
5380
c51453d9
EZ
53812011-05-06 Eli Zaretskii <eliz@gnu.org>
5382
5383 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5384 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5385
8ff0ac3c 53862011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5387
4c4b566b
PE
5388 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5389
aab2b9b5
PE
5390 * term.c (vfatal): Remove stray call to va_end.
5391 It's not needed and the C Standard doesn't allow it here anyway.
5392
c378da0b
PE
5393 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5394 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5395
288b08c7
PE
5396 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5397 bytes.
5398
e3601888
PE
5399 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5400
db6c0e74
PE
5401 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5402
dd5963ea
PE
5403 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5404
88c9450f
PE
5405 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5406
2f9442b8
PE
5407 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5408
c032b5f8
PE
5409 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5410 * charset.c (Fdefine_charset_internal): Don't initialize
5411 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5412 32-bit int (Bug#8600).
a108c10b
PE
5413
5414 * lread.c (read_integer): Be more consistent with string-to-number.
5415 Use string_to_number to do the actual conversion; this avoids
5416 rounding errors and fixes some other screwups. Without this fix,
5417 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5418 (digit_to_number): Move earlier, for benefit of read_integer.
5419 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5420 not a digit in any supported base. (Bug#8602)
a108c10b 5421
ad5f9eea
PE
5422 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5423
aec1708a
PE
5424 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5425 to match comment at start of function. This also removes a
5426 GCC warning about overflow in a 32+64-bit port.
5427
47be4ab5
PE
5428 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5429
371cac43
PE
5430 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5431 Reported by Stefan Monnier in
5432 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5433 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5434 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5435
d01a7826
PE
5436 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5437 (EMACS_UINTPTR): Likewise, with uintptr_t.
5438
7fd47d5c
PE
5439 * lisp.h: Prefer 64-bit EMACS_INT if available.
5440 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5441 on 32-bit hosts that have 64-bit int, so that they can access
5442 large files.
122b0c86
PE
5443 However, temporarily disable this change unless the temporary
5444 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5445
8727937b
PE
5446 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5447
8ac068ac
PE
5448 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5449 This removes an assumption that EMACS_INT and long are the same
5450 width as pointers. The assumption is true for Emacs porting targets
5451 now, but we want to make other targets possible.
5452 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5453 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5454 In the rest of the code, change types of integers that hold casted
5455 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5456 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5457 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5458 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5459 No need to cast type when ORing.
5460 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5461 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5462 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5463 assume EMACS_INT is the same width as char *.
5464 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5465 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5466 Remove no-longer-needed casts.
5467 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5468 (xg_tool_bar_help_callback, xg_make_tool_item):
5469 Use EMACS_INTPTR to hold an integer
5470 that will be cast to void *; this can avoid a GCC warning
5471 if EMACS_INT is not the same width as void *.
5472 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5473 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5474 (current_message_1, set_message_1):
5475 Use a local to convert to proper width without a cast.
5476 * xmenu.c (dialog_selection_callback): Likewise.
5477
ede49d71
PE
5478 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5479 Also, don't assume VALBITS / RAND_BITS is less than 5,
5480 and don't rely on undefined behavior when shifting a 1 left into
5481 the sign bit.
5482 * lisp.h (get_random): Change signature to match.
5483
2f30ecd0
PE
5484 * lread.c (hash_string): Use size_t, not int, for hash computation.
5485 Normally we prefer signed values; but hashing is special, because
5486 it's better to use unsigned division on hash table sizes so that
5487 the remainder is nonnegative. Also, size_t is the natural width
5488 for hashing into memory. The previous code used 'int', which doesn't
5489 retain enough info to hash well into very large tables.
5490 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5491
2a866e7b
PE
5492 * dbusbind.c: Don't possibly lose pointer info when converting.
5493 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5494 Use XPNTR rather than XHASH, so that the high-order bits of
5495 the pointer aren't lost when converting through void *.
5496
51639eac
PE
5497 * eval.c (Fautoload): Don't double-shift a pointer.
5498
92394119
PE
5499 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5500
dbdb9a7c
JB
55012011-05-06 Juanma Barranquero <lekktu@gmail.com>
5502
5503 * gnutls.c (DEF_GNUTLS_FN):
5504 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5505
db7a0b4f
AS
55062011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5507
5508 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5509 marker. (Bug#8610)
5510
f7ff1b0f 55112011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5512
5513 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5514 New version that can reserve upto 2GB of heap space.
5515
f7ff1b0f 55162011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5517
5518 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5519
639c109b
TZ
55202011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5521
5522 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5523 `gnutls_certificate_set_x509_key_file'.
5524
d2127135
JB
55252011-05-05 Juanma Barranquero <lekktu@gmail.com>
5526
5527 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5528 Update dependencies.
5529
e968f4f3
JB
55302011-05-04 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5533 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5534 Remove unused parameter `fildes'.
5535 * process.c (read_process_output, send_process): Don't pass it.
5536
84d358f0
JB
55372011-05-04 Juanma Barranquero <lekktu@gmail.com>
5538
5539 Fix previous change: the library cache is defined in w32.c.
5540 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5541 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5542
0898ca10
JB
55432011-05-04 Juanma Barranquero <lekktu@gmail.com>
5544
5545 Implement dynamic loading of GnuTLS on Windows.
5546
5547 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5548 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5549 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5550 Declare.
5551
5552 * gnutls.c (Qgnutls_dll): Define.
5553 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5554 (gnutls_*): Declare function pointers.
5555 (init_gnutls_functions): New function to initialize function pointers.
5556 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5557 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5558 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5559 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5560 (emacs_gnutls_write, emacs_gnutls_read)
5561 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5562 (Fgnutls_available_p): New function.
5563 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5564 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5565 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5566
5567 * image.c: Include w32.h.
5568 (Vimage_type_cache): Delete.
5569 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5570 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5571 (w32_delayed_load): Move to w32.c.
5572
5573 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5574
5575 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5576 (w32_delayed_load): Move from image.c. When loading a library, record
5577 its filename in the :loaded-from property of the library id.
5578 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5579 Initialize and staticpro them.
5580 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5581
5582 * process.c: Include lisp.h before w32.h, not after.
5583 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5584 instead of gnutls_record_check_pending.
5585
5586 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5587
ff4de4aa
TZ
55882011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5589
5590 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5591 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5592 as passed in.
5593
abe95abb
JD
55942011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5595
5596 * xterm.c (x_set_frame_alpha): Do not set property on anything
5597 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5598
e16e55d4
JB
55992011-05-02 Juanma Barranquero <lekktu@gmail.com>
5600
5601 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5602
bafcf6a5
JB
56032011-05-02 Juanma Barranquero <lekktu@gmail.com>
5604
5605 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5606 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5607 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5608 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5609 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5610 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5611 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5612 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5613 (Qgnutls_bootprop_callbacks_verify): Make static.
5614
e7a6747f
AS
56152011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5616
19ed11ba
AS
5617 * callproc.c: Indentation fixup.
5618
e7a6747f 5619 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5620 (wait_for_termination, interruptible_wait_for_termination):
5621 Move after wait_for_termination_1.
e7a6747f 5622
1ef14cb4
LMI
56232011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5624
5625 * sysdep.c (interruptible_wait_for_termination): New function
5626 which is like wait_for_termination, but allows keyboard
5627 interruptions.
5628
5629 * callproc.c (Fcall_process): Add (:file "file") as an option for
5630 the STDOUT buffer.
5631 (Fcall_process_region): Ditto.
5632
330d880c
EZ
56332011-04-30 Eli Zaretskii <eliz@gnu.org>
5634
8db90b73
EZ
5635 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5636 rather than `XVECTOR (FOO)->size'.
5637
330d880c
EZ
5638 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5639 inttypes.h, as a gnulib replacement is used if it not available in
5640 system headers.
5641
15cbd324
EZ
56422011-04-21 Eli Zaretskii <eliz@gnu.org>
5643
5644 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5645 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5646 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5647
5648 * coding.c (coding_alloc_by_realloc): Error out if destination
5649 will grow beyond MOST_POSITIVE_FIXNUM.
5650 (decode_coding_emacs_mule): Abort if there isn't enough place in
5651 charbuf for the composition carryover bytes. Reserve an extra
5652 space for up to 2 characters produced in a loop.
5653 (decode_coding_iso_2022): Abort if there isn't enough place in
5654 charbuf for the composition carryover bytes.
5655
56562011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5657
ae940cca
EZ
5658 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5659 aborting when %lld or %lll format is passed.
5660 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5661 %llo or %llx format is passed. (Bug#8545)
5662
03ab8921
EZ
5663 * window.c (window_scroll_line_based): Use a marker instead of
5664 simple variables to record original value of point. (Bug#7952)
5665
afda1437
EZ
5666 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5667 produced by %s or %c overflows available buffer space. (Bug#8545)
5668
f76dee0c
PE
56692011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5670
5671 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5672 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5673
fdc5744d
JB
56742011-04-28 Juanma Barranquero <lekktu@gmail.com>
5675
5676 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5677
638f053a
JB
56782011-04-28 Juanma Barranquero <lekktu@gmail.com>
5679
5680 * keyboard.c (Qdelayed_warnings_hook): Define.
5681 (command_loop_1): Run `delayed-warnings-hook'
5682 if Vdelayed_warnings_list is non-nil.
5683 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5684 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5685
d178f871
EZ
56862011-04-28 Eli Zaretskii <eliz@gnu.org>
5687
5688 * doprnt.c (doprnt): Don't return value smaller than the buffer
5689 size if the message was truncated. (Bug#8545).
5690
b124fd93
JB
56912011-04-28 Juanma Barranquero <lekktu@gmail.com>
5692
5693 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5694 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5695
e810457d
PE
56962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5697
5698 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5699
ea51cceb
JB
57002011-04-27 Juanma Barranquero <lekktu@gmail.com>
5701
5702 * makefile.w32-in: Update dependencies.
5703
94dcfacf
EZ
57042011-04-27 Eli Zaretskii <eliz@gnu.org>
5705
5706 Improve `doprnt' and its usage. (Bug#8545)
5707 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5708 `format_end'. Remove support for %l as a conversion specifier.
5709 Don't use xrealloc. Improve diagnostics when the %l size modifier
5710 is used. Update the commentary.
5711
5712 * eval.c (verror): Simplify calculation of size_t.
5713
5714 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5715 messages.
5716
f61f41d7
PE
57172011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5718
5719 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5720 change.
5721
96fb4434
PE
57222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5725 This makes this file independent of the recent pseudovector change.
5726
671875da 57272011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5728
69e9b5a3
PE
5729 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5730
b5f869a7 5731 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5732 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5733 Remove unused local.
c8926152 5734 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5735
841a1577 5736 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5737 GCC 4.6.0 optimizes based on type-based alias analysis.
5738 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5739 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5740 != &v->size, and therefore "v->size = 1; b->size = 2; return
5741 v->size;" must therefore return 1. This assumption is incorrect
5742 for Emacs, since it type-puns struct Lisp_Vector * with many other
5743 types. To fix this problem, this patch adds a new type struct
f904488f 5744 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5745 and pseudovectors, and helps optimizing compilers not get fooled
5746 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5747 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5748 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5749 the size member.
eab3844f
PE
5750 (XSETPVECTYPE): Rewrite in terms of new macro.
5751 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5752 This is a bit clearer, and further avoids the possibility of
5753 undesirable aliasing.
5754 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5755 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5756 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5757 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5758 (ASIZE): Now uses header.size rather than size.
5759 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5760 to avoid the hassle of writing XVECTOR (foo)->header.size.
5761 (struct vectorlike_header): New type.
eab3844f
PE
5762 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5763 object, to help avoid aliasing.
5764 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5765 (SUBRP): Likewise, since Lisp_Subr is a special case.
5766 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5767 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5768 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5769 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5770 changed to be "header.size" and "header.next".
5771 * buffer.h (struct buffer): Likewise.
5772 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5773 * frame.h (struct frame): Likewise.
5774 * process.h (struct Lisp_Process): Likewise.
5775 * termhooks.h (struct terminal): Likewise.
5776 * window.c (struct save_window_data, struct saved_window): Likewise.
5777 * window.h (struct window): Likewise.
5778 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5779 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5780 * buffer.c (init_buffer_once): Likewise.
5781 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5782 special case.
5783 * process.c (Fformat_network_address): Use local var for size,
5784 for brevity.
5785
0df1eac5
PE
5786 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5787
847ab9d1 5788 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5789 * data.c (atof): Remove decl; no longer used or needed.
5790 (digit_to_number): Move to lread.c.
5791 (Fstring_to_number): Use new string_to_number function, to be
5792 consistent with how the Lisp reader treats infinities and NaNs.
5793 Do not assume that floating-point numbers represent EMACS_INT
5794 without losing information; this is not true on most 64-bit hosts.
5795 Avoid double-rounding errors, by insisting on integers when
5796 parsing non-base-10 numbers, as the documentation specifies.
5797 * lisp.h (string_to_number): New decl, replacing ...
5798 (isfloat_string): Remove.
bc0a5c13 5799 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5800 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5801 appears to have been a coding error. Similarly, do not accept
5802 strings like +-1e0 as floating point numbers. Do not report
5803 overflow for integer overflows unless the base is not 10 which
5804 means we have no simple and reliable way to continue.
5805 Break out the floating-point parsing into a new
5806 function string_to_number, so that Fstring_to_number parses
5807 floating point numbers consistently with the Lisp reader.
04f2d78b 5808 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5809 (E_CHAR, EXP_INT): Remove, replacing with ...
5810 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5811 (string_to_number): New function, replacing isfloat_string.
5812 This function checks for valid syntax and produces the resulting
5813 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5814 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5815 so that overflow for non-base-10 numbers is reported only when
5816 there's no portable and simple way to convert to floating point.
452f4150 5817
67769ffc
PE
5818 * textprop.c (set_text_properties_1): Rewrite for clarity,
5819 and to avoid GCC warning about integer overflow.
5820
c20db43f
PE
5821 * intervals.h (struct interval): Use EMACS_INT for members
5822 where EMACS_UINT might cause problems. See
5823 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5824 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5825 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5826 All uses changed.
37aa2f85
PE
5827 (offset_intervals): Tell GCC not to worry about length overflow
5828 when negating a negative length.
c20db43f 5829
2538aa2f
PE
5830 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5831 (overrun_check_free): Likewise.
5832
f2d3008d
PE
5833 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5834 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5835 word size.
5836
ec8df744
PE
5837 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5838 (gnutls_make_error): Rename local to avoid shadowing.
5839 (gnutls_emacs_global_deinit): ifdef out; not used.
5840 (Fgnutls_boot): Use const for pointer to readonly storage.
5841 Comment out unused local. Fix pointer signedness problems.
5842
640ee02d
PE
5843 * lread.c (openp): Don't stuff size_t into an 'int'.
5844 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5845 about possible signed overflow.
5846
6048fb2a
PE
5847 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5848 (GDK_KEY_g): Don't define if already defined.
5849 (xg_prepare_tooltip): Avoid pointer signedness problem.
5850 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5851
fa3c87e1
PE
5852 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5853 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5854
2172544b
PE
5855 * xfns.c (Fx_window_property): Simplify a bit,
5856 to make a bit faster and to avoid GCC 4.6.0 warning.
5857 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5858
9b821a21
PE
5859 * fns.c (internal_equal): Don't assume size_t fits in int.
5860
3c616cfa
PE
5861 * alloc.c (compact_small_strings): Tighten assertion a little.
5862
c2982e87
PE
5863 Replace pEd with more-general pI, and fix some printf arg casts.
5864 * lisp.h (pI): New macro, generalizing old pEd macro to other
5865 conversion specifiers. For example, use "...%"pI"d..." rather
5866 than "...%"pEd"...".
5867 (pEd): Remove. All uses replaced with similar uses of pI.
5868 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5869 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5870 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5871 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5872 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5873 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5874 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5875 64-bit hosts.
5876 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5877 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5878 * print.c (safe_debug_print, print_object): Likewise.
5879 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5880 to int.
6f04d126
PE
5881 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5882 avoiding the 0 flag, which is not portable.
c2982e87
PE
5883 * process.c (Fmake_network_process): Use pI to avoid cast.
5884 * region-cache.c (pp_cache): Likewise.
5885 * xdisp.c (decode_mode_spec): Likewise.
5886 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5887 behavior on 64-bit hosts with printf arg.
6f04d126 5888 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5889 (x_stop_queuing_selection_requests): Likewise.
5890 (x_get_window_property): Don't truncate byte count to an 'int'
5891 when tracing.
0b432f21 5892
5e073ec7
PE
5893 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5894 here, since it parses constructs like leading '-' and spaces,
5895 which are not wanted; and it overflows with large numbers.
5896 Instead, simply match F[0-9]+, which is what is wanted anyway.
5897
36372bf9
PE
5898 * alloc.c: Remove unportable assumptions about struct layout.
5899 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5900 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5901 (allocate_vectorlike, make_pure_vector): Use the new macros,
5902 plus offsetof, to remove unportable assumptions about struct layout.
5903 These assumptions hold on all porting targets that I know of, but
5904 they are not guaranteed, they're easy to remove, and removing them
5905 makes further changes easier.
5906
0b432f21
PE
5907 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5908 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5909 (string_overrun_cookie): Now const. Use initializers that
5910 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5911 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5912 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5913 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5914 multiple of sizeof (EMACS_INT); it need not be, if
5915 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5916 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5917
895009e1
JB
59182011-04-26 Juanma Barranquero <lekktu@gmail.com>
5919
5920 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5921
6a7a1b0b
TZ
59222011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5923
5924 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5925 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5926 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5927
841a1577 59282011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5929
5930 * lisp.h (Qdebug): List symbol.
895009e1 5931 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5932 * keyboard.c (debug-on-event): New variable.
5933 (handle_user_signal): Break into debugger when debug-on-event
5934 matches the current signal symbol.
5935
f2d3ba6f
DN
59362011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5937
5938 * alloc.c (check_sblock, check_string_bytes)
5939 (check_string_free_list): Convert to standard C.
5940
42ce4c63
TZ
59412011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5942
5943 * w32.c (emacs_gnutls_push): Fix typo.
5944
825cd63c
EZ
59452011-04-25 Eli Zaretskii <eliz@gnu.org>
5946
fb11d64d
EZ
5947 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5948 "cast to pointer from integer of different size".
5949
825cd63c
EZ
5950 Improve doprnt and its use in verror. (Bug#8545)
5951 * doprnt.c (doprnt): Document the set of format control sequences
5952 supported by the function. Use SAFE_ALLOCA instead of always
5953 using `alloca'.
5954
5955 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5956 is one byte too soon. Don't use xrealloc; instead xfree and
5957 xmalloc anew.
5958
e061a11b
TZ
59592011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5960
5961 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5962 callbacks stage.
5963
5964 * gnutls.c: Renamed global_initialized to
5965 gnutls_global_initialized. Added internals for the
5966 :verify-hostname-error, :verify-error, and :verify-flags
5967 parameters of `gnutls-boot' and documented those parameters in the
5968 docstring. Start callback support.
9173deec
JB
5969 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5970 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5971 on error. Return error code.
e061a11b
TZ
5972 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5973 (emacs_gnutls_read): Likewise.
5974 (Fgnutls_boot): Return handshake error code.
5975 (emacs_gnutls_handle_error): New function.
5976 (wsaerror_to_errno): Likewise.
5977
5978 * w32.h (emacs_gnutls_pull): Add prototype.
5979 (emacs_gnutls_push): Likewise.
5980
5981 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5982 (emacs_gnutls_push): Likewise.
5983
59842011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5985
5986 * process.c (wait_reading_process_output): Check if GnuTLS
5987 buffered some data internally if no FDs are set for TLS
5988 connections.
5989
5990 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5991 (LIBS): Link to USER_LIBS.
5992 ($(BLD)/gnutls.$(0)): New target.
5993
fa6996bc
EZ
59942011-04-24 Eli Zaretskii <eliz@gnu.org>
5995
eb35682e
EZ
5996 * xdisp.c (handle_single_display_spec): Rename the
5997 display_replaced_before_p argument into display_replaced_p, to
5998 make it consistent with the commentary. Fix typos in the
5999 commentary.
6000
e2ad650c
EZ
6001 * textprop.c (syms_of_textprop): Remove dead code.
6002 (copy_text_properties): Delete obsolete commentary about an
6003 interface that was deleted long ago. Fix typos in the description
6004 of arguments.
6005
1b2de274
EZ
6006 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6007 to changes in oldXMenu/XMenu.h from 2011-04-16.
6008 <menu_help_message, prev_menu_help_message>: Constify.
6009 (IT_menu_make_room): menu->help_text is now `const char **';
6010 adjust.
6011
6012 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6013 to changes in oldXMenu/XMenu.h from 2011-04-16.
6014 (struct XMenu): Declare `help_text' `const char **'.
6015
6016 * xfaces.c <Qunspecified>: Make extern again.
6017
6018 * syntax.c: Include sys/types.h before including regex.h, as
6019 required by Posix.
6020
762b15be
EZ
6021 * doc.c (get_doc_string): Improve the format passed to `error'.
6022
6023 * doprnt.c (doprnt): Improve commentary.
6024
6025 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6026
6027 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6028 them with etags.
6029
f1052e5d
EZ
6030 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6031 changes in globals.h immediately force recompilation.
762b15be
EZ
6032 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6033 $(CURDIR)/s/ms-w32.h.
6034 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6035
fa6996bc
EZ
6036 * character.c (Fchar_direction): Function deleted.
6037 (syms_of_character): Don't defsubr it.
6038 <char-direction-table>: Deleted.
6039
e6c3da20
EZ
60402011-04-23 Eli Zaretskii <eliz@gnu.org>
6041
6042 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6043 * doprnt.c: Include limits.h.
6044 (SIZE_MAX): New macro.
04f2d78b
CB
6045 (doprnt): Return a size_t value. 2nd arg is now size_t.
6046 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6047 Improve overflow protection. Support `l' modifier for integer
6048 conversions. Support %l conversion. Don't assume an EMACS_INT
6049 argument for integer conversions and for %c.
6050
6051 * lisp.h (doprnt): Restore prototype.
6052
6053 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6054 $(SRC)/character.h.
6055
6056 * Makefile.in (base_obj): Add back doprnt.o.
6057
6058 * deps.mk (doprnt.o): Add back prerequisites.
6059 (callint.o): Depend on character.h.
6060
6061 * eval.c (internal_lisp_condition_case): Include the handler
6062 representation in the error message.
6063 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6064 when breaking from the loop.
6065
6066 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6067
6068 * callint.c (Fcall_interactively): When displaying error message
6069 about invalid control letter, pass the character's codepoint, not
6070 a pointer to its multibyte form. Improve display of the character
6071 in octal and display also its hex code.
6072
6073 * character.c (char_string): Use %x to display the (unsigned)
6074 codepoint of an invalid character, to avoid displaying a bogus
6075 negative value.
6076
6077 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6078 `error', not SYMBOL_NAME itself.
6079
6080 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6081 character arguments to `error'.
6082
6083 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6084 to `error' in error message about FINAL_CHAR argument. Make sure
6085 FINAL_CHAR is a character, and use %c when it is passed as
6086 argument to `error'.
6087
4ffd0d6b 60882011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6089
6090 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6091
6092 * w32.c: Include <time.h>.
6093 (sys_localtime): New function.
6094
4ffd0d6b 60952011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6096
6097 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6098
4ffd0d6b 6099 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6100
4ffd0d6b 61012011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6102
4ffd0d6b
GM
6103 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6104 zombies (Bug#8467).
aac0c6e3 6105
04c56954
EZ
61062011-04-19 Eli Zaretskii <eliz@gnu.org>
6107
6108 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6109 gl_state.e_property when gl_state.object is Qt.
6110
6111 * insdel.c (make_gap_larger): Remove limitation of buffer size
6112 to <= INT_MAX.
6113
16a43933
CY
61142011-04-18 Chong Yidong <cyd@stupidchicken.com>
6115
6116 * xdisp.c (lookup_glyphless_char_display)
6117 (produce_glyphless_glyph): Handle cons cell entry in
6118 glyphless-char-display.
6119 (Vglyphless_char_display): Document it.
6120
6121 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6122 glyphless-char-display.
6123
4581706e
CY
61242011-04-17 Chong Yidong <cyd@stupidchicken.com>
6125
6126 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6127
6128 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6129
6130 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6131 definition for no-X builds.
6132
4887c6e2 61332011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6134
fd35b6f9
PE
6135 Static checks with GCC 4.6.0 and non-default toolkits.
6136
5c1ccb01
PE
6137 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6138
006c5daa
PE
6139 * process.c (keyboard_bit_set): Define only if SIGIO.
6140 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6141 (send_process): Repair possible setjmp clobbering.
6142
efc736d3
PE
6143 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6144
4e2fe2e6
PE
6145 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6146
f97334a2
PE
6147 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6148
4e75f29d
PE
6149 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6150 Define only if needed.
6151
90efadd1
PE
6152 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6153 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6154 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6155
3c647824
PE
6156 * dispextern.h (struct redisplay_interface): Rename param
6157 to avoid shadowing.
e264f262 6158 * termhooks.h (struct terminal): Likewise.
761383f4 6159 * xterm.c (xembed_send_message): Likewise.
3c647824 6160
b58c5c4a
PE
6161 * insdel.c (make_gap_smaller): Define only if
6162 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6163
cad59032
PE
6164 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6165 it.
6166
c339dc2e
PE
6167 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6168 so that we aren't warned about unused symbols.
6169
91a3e27b
PE
6170 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6171
399c71d3 6172 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6173
8ffc96f5
PE
6174 * xfns.c (x_real_positions): Mark locals as initialized.
6175
eef9bc79
PE
6176 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6177
098db9dd
PE
6178 * xterm.c: Fix problems found by static analysis with other toolkits.
6179 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6180 (x_dispatch_event): Declare static if USE_GTK, and
6181 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6182 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6183 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6184 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6185 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6186
eb18f6cc
PE
6187 * xmenu.c (menu_help_callback): Pointer type fixes.
6188 Use const pointers when pointing at readonly data. Avoid pointer
6189 signedness clashes.
6190 (FALSE): Remove unused macro.
6191 (update_frame_menubar): Remove unused decl.
6192
1fe72bf8
PE
6193 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6194
60d9e1db
PE
6195 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6196 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6197 (single_menu_item): Rename local to avoid shadowing.
6198
39261c26
PE
6199 * keyboard.c (make_lispy_event): Remove unused local var.
6200
018c5e19
PE
6201 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6202 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6203
63d2b86e
PE
6204 * bitmaps: Change bitmaps from unsigned char back to the X11
6205 compatible char. Avoid the old compiler warnings about
6206 out-of-range initializers by using, for example, '\xab' rather
6207 than 0xab.
6208
aefd87e1
PE
6209 * xgselect.c (xgselect_initialize): Check vs interface
6210 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6211
bf501fb9
PE
6212 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6213
e9829fdf
PE
6214 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6215 to read-only memory.
6216
1086c095
PE
6217 * fns.c (vector): Remove; this old hack is no longer needed.
6218
2baccd04 6219 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6220 Remove unused var.
dde42981 6221 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6222
72391843 6223 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6224
436c16df 6225 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6226 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6227 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6228
92bb796d 6229 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6230 (x_term_init): Remove local to avoid shadowing.
92bb796d 6231
764430a3 6232 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6233
6234 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6235 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6236
d1dfb56c
EZ
62372011-04-16 Eli Zaretskii <eliz@gnu.org>
6238
c4354cb4
EZ
6239 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6240
d1dfb56c
EZ
6241 Fix regex.c, syntax.c and friends for buffers > 2GB.
6242 * syntax.h (struct gl_state_s): Declare character position members
6243 EMACS_INT.
6244
6245 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6246
04f2d78b
CB
6247 * textprop.c (verify_interval_modification, interval_of):
6248 Declare arguments EMACS_INT.
d1dfb56c
EZ
6249
6250 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6251 EMACS_INT.
6252
6253 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6254
6255 * indent.c (Fvertical_motion): Local variable it_start is now
6256 EMACS_INT.
6257
6258 * regex.c (re_match, re_match_2, re_match_2_internal)
6259 (bcmp_translate, regcomp, regexec, print_double_string)
6260 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6261 (re_compile_pattern, re_exec): Declare arguments and local
6262 variables `size_t' and `ssize_t' and return values `regoff_t', as
6263 appropriate.
6264 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6265 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6266 <compile_stack_type>: `size' and `avail' are now `size_t'.
6267
6268 * regex.h <regoff_t>: Use ssize_t, not int.
6269 (re_search, re_search_2, re_match, re_match_2): Arguments that
6270 specify buffer/string position and length are now ssize_t and
6271 size_t. Return type is regoff_t.
6272
613052cd
BK
62732011-04-16 Ben Key <bkey76@gmail.com>
6274
6275 * nsfont.m: Fixed bugs in ns_get_family and
6276 ns_descriptor_to_entity that were caused by using free to
6277 deallocate memory blocks that were allocated by xmalloc (via
6278 xstrdup). This caused Emacs to crash when compiled with
6279 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6280 --enable-checking=xmallocoverrun). xfree is now used to
6281 deallocate these memory blocks.
6282
4170f62f 62832011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6284
71b41406
PE
6285 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6286
9587a89d
PE
6287 emacs_write: Accept and return EMACS_INT for sizes.
6288 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6289 et seq.
6290 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6291 Accept and return EMACS_INT.
6292 (emacs_gnutls_write): Return the number of bytes written on
6293 partial writes.
6294 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6295 (emacs_read, emacs_write): Remove check for negative size, as the
6296 Emacs source code has been audited now.
9587a89d
PE
6297 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6298 (emacs_read, emacs_write): Use it.
273a5f82
PE
6299 * process.c (send_process): Adjust to the new signatures of
6300 emacs_write and emacs_gnutls_write. Do not attempt to store
6301 a byte offset into an 'int'; it might overflow.
9587a89d 6302 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6303
3e047f51
PE
6304 * sound.c: Don't assume sizes fit in 'int'.
6305 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6306 Return EMACS_INT, not int.
3e047f51 6307 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6308 Accept EMACS_INT, not int.
6309 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6310 record read return values.
6311
cc39a9db
BK
63122011-04-15 Ben Key <bkey76@gmail.com>
6313
c9d0ec6d
JB
6314 * keyboard.c (Qundefined): Don't declare static since it is used
6315 in nsfns.m.
6316 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6317 static since they are used in nsfont.m.
cc39a9db 6318
6c60eb9f
SM
63192011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6320
6321 * process.c (Qprocessp): Don't declare static.
6322 * lisp.h (Qprocessp): Declare again.
6323
7990b61a
JB
63242011-04-15 Juanma Barranquero <lekktu@gmail.com>
6325
6326 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6327
5d4cb038
PE
63282011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6329
8bd7b830 6330 Improve C-level modularity by making more things 'static'.
cd64ea1d 6331
e3b27b31
PE
6332 Don't publish debugger-only interfaces to other modules.
6333 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6334 (verify_bytepos, count_markers): Move decls to the only modules
6335 that need them.
6336 * region-cache.h (pp_cache): Likewise.
6337 * window.h (check_all_windows): Likewise.
6338 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6339
5d4cb038
PE
6340 * sysdep.c (croak): Now static, if
6341 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6342 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6343
6344 * alloc.c (refill_memory_reserve): Now static if
6345 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6346 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6347
e87b6180
PE
6348 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6349 Define only if USE_LUCID.
6350
ac64929e
PE
6351 * xrdb.c (x_customization_string, x_rm_string): Now static.
6352
6f37259d
PE
6353 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6354 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6355
1683e3ab
PE
6356 * xdisp.c (draw_row_with_mouse_face): Now static.
6357 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6358
de9c2632
PE
6359 * window.h (check_all_windows): Mark externally visible.
6360
2b96acb7
PE
6361 * window.c (window_deletion_count): Now static.
6362
6363 * undo.c: Make symbols static if they're not exported.
6364 (last_undo_buffer, last_boundary_position, pending_boundary):
6365 Now static.
6366
50436f33
PE
6367 * textprop.c (interval_insert_behind_hooks): Now static.
6368 (interval_insert_in_front_hooks): Likewise.
6369
64520e5c
PE
6370 * term.c: Make symbols static if they're not exported.
6371 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6372 (max_frame_lines, tty_set_terminal_modes):
6373 (tty_reset_terminal_modes, tty_turn_off_highlight):
6374 (get_tty_terminal): Now static.
6375 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6376 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6377 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6378 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6379 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6380
1fa53021
PE
6381 * sysdep.c: Make symbols static if they're not exported.
6382 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6383 Now static.
6384 (sigprocmask_set, full_mask): Remove; unused.
6385 (wait_debugging): Mark as visible.
6386 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6387 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6388
d4b43b22
PE
6389 * syntax.c (syntax_temp): Define only if !__GNUC__.
6390
b7c513d0
PE
6391 * sound.c (current_sound_device, current_sound): Now static.
6392
989b29ad
PE
6393 * search.c (searchbufs, searchbuf_head): Now static.
6394
13a55a78
PE
6395 * scroll.c (scroll_cost): Remove; unused.
6396 * dispextern.h (scroll_cost): Remove decl.
6397
de68a1fc
PE
6398 * region-cache.h (pp_cache): Mark as externally visible.
6399
40ccffa6
PE
6400 * process.c: Make symbols static if they're not exported.
6401 (process_tick, update_tick, create_process, chan_process):
6402 (Vprocess_alist, proc_buffered_char, datagram_access):
6403 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6404 (deactivate_process): Mark defn as static, as well as decl.
6405 * lisp.h (create_process): Remove decl.
6406 * process.h (chan_process, Vprocess_alist): Remove decls.
6407
ad64fc97
PE
6408 * print.c: Make symbols static if they're not exported.
6409 (print_depth, new_backquote_output, being_printed, print_buffer):
6410 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6411 (print_interval, print_number_index, initial_stderr_stream):
6412 Now static.
6413 * lisp.h (Fprinc): Remove decl.
6414 (debug_output_compilation_hack): Mark as externally visible.
6415
adddb265
PE
6416 * sysdep.c (croak): Move decl from here to syssignal.h.
6417 * syssignal.h (croak): Put it here, so the API can be checked when
6418 'croak' is called from dissociate_if_controlling_tty.
6419
1717ede2
PE
6420 * minibuf.c: Make symbols static if they're not exported.
6421 (minibuf_save_list, choose_minibuf_frame): Now static.
6422 * lisp.h (choose_minibuf_frame): Remove decl.
6423
fa5fb2bc
PE
6424 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6425
1e3890d1
PE
6426 * lread.c: Make symbols static if they're not exported.
6427 (read_objects, initial_obarray, oblookup_last_bucket_number):
6428 Now static.
6429 (make_symbol): Remove; unused.
6430 * lisp.h (initial_obarray, make_symbol): Remove decls.
6431
8a1414fa
PE
6432 * keyboard.c: Make symbols static if they're not exported.
6433 (single_kboard, recent_keys_index, total_keys, recent_keys):
6434 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6435 (this_single_command_key_start, echoing, last_auto_save):
6436 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6437 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6438 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6439 (Vlispy_mouse_stem, double_click_count):
6440 Now static.
6441 (force_auto_save_soon): Define only if SIGDANGER.
6442 (ignore_mouse_drag_p): Now static if
6443 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6444 (print_help): Remove; unused.
6445 (stop_character, last_timer_event): Mark as externally visible.
6446 * keyboard.h (ignore_mouse_drag_p): Declare only if
6447 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6448 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6449 * lisp.h (echoing): Remove decl.
6450 (force_auto_save_soon): Declare only if SIGDANGER.
6451 * xdisp.c (redisplay_window): Simplify code, to make it more
6452 obvious that ignore_mouse_drag_p is not accessed if !defined
6453 USE_GTK && !defined HAVE_NS.
6454
93ea6e8f
PE
6455 * intervals.c: Make symbols static if they're not exported.
6456 (merge_properties_sticky, merge_interval_right, delete_interval):
6457 Now static.
6458 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6459
77382fcc
PE
6460 * insdel.c: Make symbols static if they're not exported.
6461 However, leave prepare_to_modify_buffer alone. It's never
6462 called from outside this function, but that appears to be a bug.
6463 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6464 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6465 (adjust_after_replace_noundo): Remove; unused.
6466 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6467 (signal_before_change): Remove decls.
77382fcc 6468
9306c32e
PE
6469 * indent.c (val_compute_motion, val_vmotion): Now static.
6470
cd44d2eb
PE
6471 * image.c: Make symbols static if they're not exported.
6472 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6473 if USE_GTK.
6474 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6475 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6476
ad9a7a06
PE
6477 * fringe.c (standard_bitmaps): Now static.
6478 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6479
81626931
PE
6480 * frame.c: Make symbols static if they're not exported.
6481 (x_report_frame_params, make_terminal_frame): Now static.
6482 (get_frame_param): Now static, unless HAVE_NS.
6483 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6484 (x_get_resource_string): Remove; not used.
6485 * frame.h (make_terminal_frame, x_report_frame_params):
6486 (x_get_resource_string); Remove decls.
6487 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6488 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6489
239f9db9
PE
6490 * font.c, fontset.c: Make symbols static if they're not exported.
6491 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6492 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6493 * font.c (font_close_object): Now static.
6494 * font.h (font_close_object): Remove.
6495 * fontset.c (FONTSET_OBJLIST): Remove.
6496 (free_realized_fontset) #if-0 the body, which does nothing.
6497 (face_suitable_for_char_p): #if-0, as it's never called.
6498 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6499 * xfaces.c (face_at_string_position):
6500 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6501 since 0 is always ASCII.
6502
dfcf3579
PE
6503 * fns.c (weak_hash_tables): Now static.
6504
5045092b
PE
6505 * fileio.c: Make symbols static if they're not exported.
6506 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6507 (Vwrite_region_annotation_buffers): Now static.
6508
57a96f5c
PE
6509 * eval.c: Make symbols static if they're not exported.
6510 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6511 * lisp.h (backtrace_list): Remove decl.
6512
35f08c38
PE
6513 * emacs.c: Make symbols static if they're not exported.
6514 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6515 (fatal_error_code, fatal_error_signal_hook, standard_args):
6516 Now static.
6517 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6518 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6519 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6520 * lisp.h (fatal_error_signal_hook): Remove decl.
6521 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6522
f44bd759
PE
6523 * editfns.c: Move a (normally-unused) function to its only use.
6524 * editfns.c, lisp.h (get_operating_system_release): Remove.
6525 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6526 worth the hassle of breaking this out.
6527
b532497d
PE
6528 * xterm.c: Make symbols static if they're not exported.
6529 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6530 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6531 (x_destroy_window, x_delete_display):
6532 Now static.
6533 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6534 (x_mouse_leave): Remove; unused.
6535 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6536 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6537 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6538 Remove decls.
6539 (x_mouse_leave): Declare only if WINDOWSNT.
6540 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6541 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6542 USE_X_TOOLKIT.
6543
1675728f
PE
6544 * ftxfont.c: Make symbols static if they're not exported.
6545 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6546 HAVE_FREETYPE.
6547 * font.h (ftxfont_driver): Likewise.
6548
e4cebfca
PE
6549 * xfns.c: Make symbols static if they're not exported.
6550 (x_last_font_name, x_display_info_for_name):
6551 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6552 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6553 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6554 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6555 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6556 (last_show_tip_args): Now static.
6557 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6558 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6559 (x_screen_planes): Remove; unused.
6560 * dispextern.h (x_screen_planes): Remove decl.
6561
5bf46f05
PE
6562 * dispnew.c: Make symbols static if they're not exported.
6563 * dispextern.h (redraw_garbaged_frames, scrolling):
6564 (increment_row_positions): Remove.
6565 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6566 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6567 Now static.
6568 (redraw_garbaged_frames): Remove; unused.
6569
435f4c28
PE
6570 * xfaces.c: Make symbols static if they're not exported.
6571 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6572 Remove decls.
6573 * xterm.h (defined_color): Remove decls.
6574 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6575 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6576 (menu_face_changed_default, defined_color, free_realized_face):
6577 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6578 (ascii_face_of_lisp_face): Remove; unused.
6579
8524aef3
PE
6580 * xdisp.c: Make symbols static if they're not exported.
6581 * dispextern.h (scratch_glyph_row, window_box_edges):
6582 (glyph_to_pixel_coords, set_cursor_from_row):
6583 (get_next_display_element, set_iterator_to_next):
6584 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6585 (show_mouse_face): Remove decls
6586 * frame.h (message_buf_print): Likewise.
6587 * lisp.h (pop_message, set_message, check_point_in_composition):
6588 Likewise.
6589 * xterm.h (set_vertical_scroll_bar): Likewise.
6590 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6591 (message_buf_print, scratch_glyph_row, displayed_buffer):
6592 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6593 (get_next_display_element, show_mouse_face, window_box_edges):
6594 (frame_to_window_pixel_xy, check_point_in_composition):
6595 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6596 (glyph_to_pixel_coords): Remove; unused.
6597
16390cd2
PE
6598 * dired.c (file_name_completion): Now static.
6599
6600 * dbusbind.c (xd_in_read_queued_messages): Now static.
6601
a25f4dfa
PE
6602 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6603 * data.c (circular_list_error): Remove.
6604
14a9c8df
PE
6605 * commands.h (last_point_position, last_point_position_buffer):
6606 (last_point_position_window): Remove decls.
6607 * keyboard.c: Make these variables static.
6608
04f2d78b
CB
6609 * coding.h (coding, code_convert_region, encode_coding_gap):
6610 Remove decls.
74ab6df5
PE
6611 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6612 (iso_code_class, detect_coding, code_convert_region): Now static.
6613 (encode_coding_gap): Remove; unused.
6614
38dfbee1
PE
6615 * chartab.c (chartab_chars, chartab_bits): Now static.
6616
a2cb4e63
PE
6617 * charset.h (charset_iso_8859_1): Remove decl.
6618 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6619 Now static.
6620
127198fd
PE
6621 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6622 * ccl.c (Vccl_program_table): Now static.
6623 (check_ccl_update): Remove; unused.
6624
d85b608f
PE
6625 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6626 * category.h: ... from here.
6627 * category.c (check_category_table, set_category_set): Now static.
6628
31cd66f3
PE
6629 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6630 * lisp.h: Remove these decls.
6631
c358e587
PE
6632 * buffer.c (buffer_count): Remove unused var.
6633
e78aecca
PE
6634 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6635 so that it's not optimized away.
6636 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6637 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6638 exported only to the debugger.
6639
e192d7d3 6640 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6641 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6642
92470028
PE
6643 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6644 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6645 was inaccessible from Lisp.
6646 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6647 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6648
244ed907
PE
6649 alloc.c: Import and export fewer symbols, and remove unused items.
6650 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6651 is defined.
6652 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6653 it's not optimized away by whole-program optimization.
6654 (message_enable_multibyte, free_misc): Remove.
6655 (catchlist, handlerlist, mark_backtrace):
6656 Declare only if BYTE_MARK_STACK.
6657 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6658 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6659 (message_enable_multibyte): Remove decl.
6660 (free_misc, interval_free_list, float_block, float_block_index):
6661 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6662 (cons_free_list, last_marked_index):
6663 Now static.
6664 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6665 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6666 (mark_backtrace): Define only if BYTE_MARK_STACK.
6667 * xdisp.c (message_enable_multibyte): Now static.
6668
61c2b50e 6669 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6670 This makes it easier for human readers (and static analyzers)
6671 to see whether these variables are used from other modules.
6672 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6673 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6674 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6675 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6676 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6677 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6678 * xmenu.c, xselect.c:
6679 Declare Q* vars static if they are not used in other modules.
6680 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6681 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6682 Remove decls of unexported vars.
6683 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6684
95c82688
PE
6685 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6686
16a97296
PE
6687 Make Emacs functions such as Fatom 'static' by default.
6688 This makes it easier for human readers (and static analyzers)
6689 to see whether these functions can be called from other modules.
6690 DEFUN now defines a static function. To make the function external
6691 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6692 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6693 (Finit_image_library):
16a97296
PE
6694 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6695 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6696 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6697 Remove decls, since these functions are now static.
6698 (Funintern, Fget_internal_run_time): New decls, since these functions
6699 were already external.
95c82688 6700
16a97296
PE
6701 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6702 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6703 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6704 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6705 * keyboard.c, keymap.c, lread.c:
6706 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6707 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6708 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6709 Mark functions with DEFUE instead of DEFUN,
6710 if they are used in other modules.
6711 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6712 decls for now-static functions.
6713 * buffer.h (Fdelete_overlay): Remove decl.
6714 * callproc.c (Fgetenv_internal): Mark as internal.
6715 * composite.c (Fremove_list_of_text_properties): Remove decl.
6716 (Fcomposition_get_gstring): New forward static decl.
6717 * composite.h (Fcomposite_get_gstring): Remove decl.
6718 * dired.c (Ffile_attributes): New forward static decl.
6719 * doc.c (Fdocumntation_property): New forward static decl.
6720 * eval.c (Ffetch_bytecode): New forward static decl.
6721 (Funintern): Remove extern decl; now in .h file where it belongs.
6722 * fileio.c (Fmake_symbolic_link): New forward static decl.
6723 * image.c (Finit_image_library): New forward static decl.
6724 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6725 * intervals.h (Fprevious_property_change):
6726 (Fremove_list_of_text_properties): Remove decls.
6727 * keyboard.c (Fthis_command_keys): Remove decl.
6728 (Fcommand_execute): New forward static decl.
6729 * keymap.c (Flookup_key): New forward static decl.
6730 (Fcopy_keymap): Now static.
6731 * keymap.h (Flookup_key): Remove decl.
6732 * process.c (Fget_process): New forward static decl.
6733 (Fprocess_datagram_address): Mark as internal.
6734 * syntax.c (Fsyntax_table_p): New forward static decl.
6735 (skip_chars): Remove duplicate decl.
6736 * textprop.c (Fprevious_property_change): New forward static decl.
6737 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6738 Now internal.
6739 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6740 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6741
785bbd42
PE
6742 * editfns.c (Fformat): Remove unreachable code.
6743
8b913b57
AS
67442011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6745
6746 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6747 change. (Bug#8496)
6748
a6744a35
EZ
67492011-04-13 Eli Zaretskii <eliz@gnu.org>
6750
6751 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6752 when at ZV. (Bug#8487)
6753
e7974947
AS
67542011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6755
baad03f0
AS
6756 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6757 (Bug#8437)
6758 * keyboard.c (parse_tool_bar_item): Likewise.
6759 * sound.c (sound_cleanup, alsa_close): Likewise.
6760 * termcap.c (tgetent): Likewise.
6761 * xfns.c (x_default_font_parameter): Likewise.
6762 * xsettings.c (read_and_apply_settings): Likewise.
6763
e7974947
AS
6764 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6765 (overrun_check_free): Protoize.
6766
28272684
PE
67672011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6768
6769 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6770 since callers should never pass a negative size.
6771 Change the signature to match that of plain 'read' and 'write'; see
6772 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6773 * lisp.h: Update prototypes of emacs_write and emacs_read.
6774
11997c76
EZ
67752011-04-11 Eli Zaretskii <eliz@gnu.org>
6776
6777 * xdisp.c (redisplay_window): Don't try to determine the character
6778 position of the scroll margin if the window start point w->startp
e896f03c 6779 is outside the buffer's accessible region. (Bug#8468)
11997c76 6780
8a2cbd72
EZ
67812011-04-10 Eli Zaretskii <eliz@gnu.org>
6782
6783 Fix write-region and its subroutines for buffers > 2GB.
6784 * fileio.c (a_write, e_write): Modify declaration of arguments and
6785 local variables to support buffers larger than 2GB.
6786 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6787
6788 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6789 argument, local variables, and return value.
6790
6791 * lisp.h: Update prototypes of emacs_write and emacs_read.
6792
6793 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6794
4073e537 67952011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6796
1ebfdcb6
PE
6797 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6798
b2ded58d
PE
6799 Fix more problems found by GCC 4.6.0's static checks.
6800
7d66342c
PE
6801 * xdisp.c (vmessage): Use a better test for character truncation.
6802
bbf47d44
PE
6803 * charset.c (load_charset_map): <, not <=, for optimization,
6804 and to avoid potential problems with integer overflow.
9248994d 6805 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6806 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6807 * editfns.c (Fformat): Likewise.
1e69125e 6808 * syntax.c (skip_chars): Likewise.
3befa583 6809
e3019616
PE
6810 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6811 This also lets GCC 4.6.0 generate slightly better loop code.
6812
becfa255
PE
6813 * callint.c (Fcall_interactively): <, not <=, for optimization.
6814 (Fcall_interactively): Count the number of arguments produced,
6815 not the number of arguments given. This is simpler and lets GCC
6816 4.6.0 generate slightly better code.
6817
dae0cd48
PE
6818 * ftfont.c: Distingish more carefully between FcChar8 and char.
6819 The previous code passed unsigned char * to a functions like
6820 strlen and xstrcasecmp that expect char *, which does not
6821 conform to the C standard.
6822 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6823 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6824 char * when the C standard requires it.
6825
76032d70
PE
6826 * keyboard.c (read_char): Remove unused var.
6827
eb3f1cc8
PE
6828 * eval.c: Port to Windows vsnprintf (Bug#8435).
6829 Include <limits.h>.
6830 (SIZE_MAX): Define if the headers do not.
6831 (verror): Do not give up if vsnprintf returns a negative count.
6832 Instead, grow the buffer. This ports to Windows vsnprintf, which
6833 does not conform to C99. Problem reported by Eli Zaretskii.
6834 Also, simplify the allocation scheme, by avoiding the need for
6835 calling realloc, and removing the ALLOCATED variable.
6836
70476b54
PE
6837 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6838
12020a9e
PE
6839 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6840 But keep the doprint source code for now, as we might revamp it
6841 and use it again (Bug#8435).
ea6c7ae6
PE
6842 * lisp.h (doprnt): Remove.
6843 * Makefile.in (base_obj): Remove doprnt.o.
6844 * deps.mk (doprnt.o): Remove.
6845
5fdb398c
PE
6846 error: Print 32- and 64-bit integers portably (Bug#8435).
6847 Without this change, on typical 64-bit hosts error ("...%d...", N)
6848 was used to print both 32- and 64-bit integers N, which relied on
6849 undefined behavior.
6850 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6851 New macro.
6852 * lisp.h (error, verror): Mark as printf-like functions.
6853 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6854 Report overflow in size calculations when allocating printf buffer.
6855 Do not truncate output string at its first null byte.
6856 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6857 Truncate the output at a character boundary, since vsnprintf does not
6858 do that.
6859 * charset.c (check_iso_charset_parameter): Convert internal
6860 character to string before calling 'error', since %c now has the
6861 printf meaning.
6862 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6863 overflow when computing char to be passed to 'error'. Do not
6864 pass Lisp_Object to 'error'; pass the integer instead.
6865 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6866 formatted with plain %d.
6867
b189fa66
PE
6868 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6869
bff87ef0
PE
6870 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6871
7e2cac20
PE
6872 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6873
ce4d90b5
PE
6874 * xterm.c (x_catch_errors): Remove duplicate declaration.
6875
266c9547
PE
6876 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6877
79c49ad2
PE
6878 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6879
368f4090
JM
68802011-04-10 Jim Meyering <meyering@redhat.com>
6881
6882 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6883 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6884 return ssize_t not "int", and use size_t as the buffer length.
6885 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6886 * gnutls.h: Update declarations.
6887 * process.c (read_process_output): Use ssize_t, to match.
6888 (send_process): Likewise.
6889
a32d4040
CY
68902011-04-09 Chong Yidong <cyd@stupidchicken.com>
6891
6892 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6893
8546720e 68942011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6895
04f2d78b
CB
6896 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6897 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6898
8546720e
GM
6899 * xterm.c (handle_one_xevent):
6900 * xmenu.c (create_and_show_popup_menu):
6901 * xselect.c (x_decline_selection_request)
6902 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6903
0a2f5c1a 69042011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6905
6906 Fix some uses of `int' instead of EMACS_INT.
6907 * search.c (string_match_1, fast_string_match)
6908 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6909 (scan_buffer, find_next_newline_no_quit)
6910 (find_before_next_newline, search_command, Freplace_match)
6911 (Fmatch_data): Make some `int' variables be EMACS_INT.
6912
6913 * xdisp.c (display_count_lines): 3rd argument and return value now
6914 EMACS_INT. All callers changed.
6915 (pint2hrstr): Last argument is now EMACS_INT.
6916
6917 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6918 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6919 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6920 (decode_coding_utf_16, decode_coding_emacs_mule)
6921 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6922 (decode_coding_ccl, decode_coding_charset)
6923 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6924 (decode_coding_iso_2022, decode_coding_emacs_mule)
6925 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6926 <char_offset, last_offset>: Declare EMACS_INT.
6927 (encode_coding_utf_8, encode_coding_utf_16)
6928 (encode_coding_emacs_mule, encode_invocation_designation)
6929 (encode_designation_at_bol, encode_coding_iso_2022)
6930 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6931 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6932 Declare EMACS_INT.
6933 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6934 (encode_invocation_designation): Last argument P_NCHARS is now
6935 EMACS_INT.
6936 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6937 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6938
6939 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6940 All users changed.
6941
6942 * ccl.c (Fccl_execute_on_string): Declare some variables
6943 EMACS_INT.
6944
8546720e 69452011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6946
6947 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6948
4e19a977
CS
69492011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6950
6951 * process.c (Fformat_network_address): Doc fix.
6952
87302331
R
69532011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6954
6955 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6956
cbb59342
CY
69572011-04-08 Chong Yidong <cyd@stupidchicken.com>
6958
6959 * keyboard.c (read_char): Call Lisp function help-form-show,
6960 instead of using internal_with_output_to_temp_buffer.
6961 (Qhelp_form_show): New var.
e0d38eeb 6962 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6963
6964 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6965
6966 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6967
e67a13ab
CY
69682011-04-06 Chong Yidong <cyd@stupidchicken.com>
6969
04f2d78b
CB
6970 * process.c (Flist_processes): Remove to Lisp.
6971 (list_processes_1): Delete.
e67a13ab 6972
973f782d
EZ
69732011-04-06 Eli Zaretskii <eliz@gnu.org>
6974
7c106b1e
EZ
6975 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6976
973f782d
EZ
6977 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6978
41cf7d1a 69792011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6980
ca23cc88
PE
6981 Fix more problems found by GCC 4.6.0's static checks.
6982
f390e2d5
PE
6983 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6984
42eea0d0
PE
6985 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6986
b69769da 6987 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6988
f9541e84
PE
6989 * xdisp.c (vmessage): Mark as a printf-like function.
6990
13841b55
PE
6991 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6992
c136c10f
PE
6993 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6994
5e2d4a30
PE
6995 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6996 printf-like functions.
6997 (tiff_load): Add casts to remove these marks before passing them
6998 to system-supplied API.
6999
583f48b9
PE
7000 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7001
b25d760e
PE
7002 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7003 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7004 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7005 directly, rather than having caller test rule sign. This avoids
7006 some unnecessary tests.
7007 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7008 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7009 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7010
bc7b6697 7011 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7012 (xfont_open): Avoid unnecessary tests.
bc7b6697 7013
27ccc379
PE
7014 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7015
dcd5c89a
PE
7016 * composite.h, composite.c (composition_gstring_put_cache):
7017 Use EMACS_INT, not int, for length.
7018
b13a45c6
PE
7019 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7020 breaking out part of COMPOSITION_DECODE_RULE.
7021 (COMPOSITION_DECODE_RULE): Use it.
7022 * composite.c (get_composition_id): Remove unused local vars,
7023 by using the new macro.
7024
1e792e4d
PE
7025 * textprop.c (set_text_properties_1): Change while to do-while,
7026 since the condition is always true at first.
7027
dc6c6455 7028 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7029 (interval_deletion_adjustment): Return unsigned value.
7030 All uses changed.
dc6c6455 7031
aba7731a
PE
7032 * process.c (list_processes_1, create_pty, read_process_output):
7033 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7034 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7035 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7036 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7037 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7038
fdfc4bf3
PE
7039 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7040
fca8fe46 7041 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7042 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7043
06a0259a 7044 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7045 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7046 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7047
e7b9e80f
PE
7048 * print.c (print_error_message): Avoid int overflow.
7049
56201685
PE
7050 * font.c (font_list_entities): Redo for clarity,
7051 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7052
78834453 7053 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7054 (font_score): Avoid potential overflow in diff calculation.
78834453 7055
0bc0b309 7056 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7057 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7058
e610eaca
PE
7059 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7060
b895abce
PE
7061 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7062 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7063 can always succeed if overflow has undefined behavior.
7064
1f1d9321 7065 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7066 (wordify): Omit three unnecessary tests.
1f1d9321 7067
c59478bc
PE
7068 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7069 All callers changed. This avoids the need for an unused var.
7070
79b73827
PE
7071 * casefiddle.c (casify_region): Remove var that is set but not used.
7072
a4db5dfe
PE
7073 * dired.c (file_name_completion): Remove var that is set but not used.
7074
43aae36e
PE
7075 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7076
2a47c44d 7077 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7078 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7079
a37c69bf
PE
7080 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7081 Check for integer overflow on size calculations.
7082
328ab8e7
PE
7083 * buffer.c (Fprevious_overlay_change): Remove var that is set
7084 but not used.
7085
e5a2a5cb
PE
7086 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7087 Remove vars that are set but not used.
8d84a6eb 7088 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7089 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7090
a60e5f68
PE
7091 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7092
f661cb61 7093 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7094 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7095
f0397f5a
PE
7096 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7097 that are set but not used.
7098
8664db06 7099 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7100 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7101
6abdaa4a
PE
7102 * xselect.c (x_get_local_selection, x_handle_property_notify):
7103 Remove vars that are set but not used.
7104
0ce7538d 7105 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7106 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7107
9ae848fc
PE
7108 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7109 Remove var that is set but not used.
0b918413
PE
7110 (scroll_bar_windows_size): Now size_t, not int.
7111 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7112 Check for overflow.
9ae848fc 7113
a5a62657
PE
7114 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7115 (map_tty_color) [!defined MSDOS]: Likewise.
7116
5c5cdd39
PE
7117 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7118
66ebf983
PE
7119 * coding.c: Remove vars that are set but not used.
7120 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7121 All callers changed.
7122 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7123 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7124 (decode_coding_charset): Remove vars that are set but not used.
7125
1be4d761
PE
7126 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7127 that is set but not used.
7128
47553fa8
PE
7129 * print.c (print_object): Remove var that is set but not used.
7130
1f7196bf 7131 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7132 The gnulib version avoids calling malloc in the usual case,
7133 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7134 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7135 * filelock.c (current_lock_owner): Likewise.
7136 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7137 * sysdep.c: Include allocator.h, careadlinkat.h.
7138 (emacs_no_realloc_allocator): New static constant.
7139 (emacs_readlink): New function.
fdb61804
PE
7140 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7141 ../lib/careadlinkat.h.
d1fdcab7 7142
f84c17c7
SM
71432011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7144
7145 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7146 first non-nil return value).
7147
ef3862ad
JD
71482011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7149
7150 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7151 if not defined (Bug#8403).
7152
376a7006
JB
71532011-04-02 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * xdisp.c (display_count_lines): Remove parameter `start',
7156 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7157 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7158 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7159 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7160 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7161 and thereabouts. All callers changed.
7162 (get_per_char_metric): Remove parameter `f', unused since
7163 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7164
6ca3801d
JM
71652011-04-02 Jim Meyering <meyering@redhat.com>
7166
7167 do not dereference NULL upon failed strdup
7168 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7169 (ns_get_family): Likewise.
7170
d8e2b5ba
JB
71712011-04-02 Juanma Barranquero <lekktu@gmail.com>
7172
7173 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7174
8c74fcbd
JD
71752011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7176
7177 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7178 later (Bug#8403).
7179
7200d79c
SM
71802011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7181
03408648 7182 Add lexical binding.
7200d79c 7183
03408648
SM
7184 * window.c (Ftemp_output_buffer_show): New fun.
7185 (Fsave_window_excursion):
7186 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7187
7188 * lread.c (lisp_file_lexically_bound_p): New function.
7189 (Fload): Bind Qlexical_binding.
7190 (readevalloop): Remove `evalfun' arg.
7191 Bind Qinternal_interpreter_environment.
7192 (Feval_buffer): Bind Qlexical_binding.
7193 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7194 Mark as dynamic.
7195 (syms_of_lread): Declare `lexical-binding'.
7196
7197 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7198
7199 * keyboard.c (eval_dyn): New fun.
7200 (menu_item_eval_property): Use it.
ca105506
SM
7201
7202 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7203
03408648
SM
7204 * fns.c (concat, mapcar1): Accept byte-code-functions.
7205
7206 * eval.c (Fsetq): Handle lexical vars.
7207 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7208 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7209 (FletX, Flet): Obey lexical binding.
7210 (Fcommandp): Handle closures.
7211 (Feval): New `lexical' arg.
7212 (eval_sub): New function extracted from Feval. Use it almost
7213 everywhere where Feval was used. Look up vars in lexical env.
7214 Handle closures.
7215 (Ffunctionp): Move from subr.el.
7216 (Ffuncall): Handle closures.
7217 (apply_lambda): Remove `eval_flags'.
7218 (funcall_lambda): Handle closures and new byte-code-functions.
7219 (Fspecial_variable_p): New function.
7220 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7221 but without exporting it to Lisp.
23aba0ea 7222
23aba0ea 7223 * doc.c (Fdocumentation, store_function_docstring):
03408648 7224 * data.c (Finteractive_form): Handle closures.
23aba0ea 7225
03408648
SM
7226 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7227 interactive spec.
ba83908c 7228
04f2d78b
CB
7229 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7230 New byte-codes.
03408648
SM
7231 (exec_byte_code): New function extracted from Fbyte_code to handle new
7232 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7233
03408648 7234 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7235
03408648 7236 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7237
e2abce01
JB
72382011-03-31 Juanma Barranquero <lekktu@gmail.com>
7239
7240 * xdisp.c (redisplay_internal): Fix prototype.
7241
63696a73 72422011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7243
63696a73 7244 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7245 (try_scrolling): Use it when setting scroll_limit.
7246 Limit scrolling to 100 screen lines.
63696a73
EZ
7247 (redisplay_window): Even when falling back on "recentering",
7248 position point in the window according to scroll-conservatively,
7249 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7250
7251 (try_scrolling): When point is above the window, allow searching
7252 as far as scroll_max, or one screenful, to compute vertical
7253 distance from PT to the scroll margin position. This prevents
7254 try_scrolling from unnecessarily failing when
7255 scroll-conservatively is set to a value slightly larger than the
7256 window height. Clean up the case of PT below the margin at bottom
7257 of window: scroll_max can no longer be INT_MAX. When aggressive
7258 scrolling is in use, don't let point enter the opposite scroll
7259 margin as result of the scroll.
7260 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7261 threshold of 100 lines for never-recentering scrolling.
7262
e4cc2dfc
JB
72632011-03-31 Juanma Barranquero <lekktu@gmail.com>
7264
7265 * dispextern.h (move_it_by_lines):
7266 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7267 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7268 (message_log_check_duplicate): Remove parameters `prev_bol' and
7269 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7270 (redisplay_internal): Remove parameter `preserve_echo_area',
7271 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7272
7273 * indent.c (Fvertical_motion):
7274 * window.c (window_scroll_pixel_based, Frecenter):
7275 Don't pass `need_y_p' to `move_it_by_lines'.
7276
1c470562
SM
72772011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7278
44f230aa
SM
7279 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7280 steal a few bits to be more compact.
7281 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7282 Remove unneeded casts.
7283
1c470562
SM
7284 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7285
888adce9
ZK
72862011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7287
7288 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7289 binding" message (bug#7967).
7290
f838ed7b
PE
72912011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7292
77861b95
PE
7293 Fix more problems found by GCC 4.6.0's static checks.
7294
de6dbc14
PE
7295 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7296 Remove unused local var.
7297
f838ed7b
PE
7298 * editfns.c (Fmessage_box): Remove unused local var.
7299
792c7b2b
PE
7300 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7301 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7302 Omit unused local vars.
c499e557 7303 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7304 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7305 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7306 Omit unused local var.
7307
ba0165e1
PE
7308 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7309 Don't assume string length fits in int.
32ad8845 7310 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7311 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7312
3c59b4c9
PE
7313 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7314 instead of alloca (Bug#8344).
7315
a3eed478 7316 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7317 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7318
eb4d412d
PE
7319 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7320
1658b401
PE
7321 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7322 concerns.
7323
7324 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7325
7326 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7327
9a2c6e05
PE
7328 * keyboard.c (syms_of_keyboard): Use the same style as later
7329 in this function when indexing through an array. This also
7330 works around GCC bug 48267.
7331
03d0a109
PE
7332 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7333
44f730c8
PE
7334 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7335
fe75f926
PE
7336 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7337 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7338
ffa8c828
PE
7339 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7340 This avoids undefined behavior on integer overflow, and is a bit
7341 more convenient anyway since it is compared to a size_t variable.
7342
c5101a77
PE
7343 Variadic C functions now count arguments with size_t, not int.
7344 This avoids an unnecessary limitation on 64-bit machines, which
7345 caused (substring ...) to crash on large vectors (Bug#8344).
7346 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7347 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7348 All variadic functions and their callers changed accordingly.
c5101a77
PE
7349 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7350 * data.c (arith_driver, float_arith_driver): Likewise.
7351 * editfns.c (general_insert_function): Likewise.
7352 * eval.c (struct backtrace.nargs, interactive_p)
7353 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7354 (funcall_lambda, mark_backtrace): Likewise.
7355 * fns.c (concat): Likewise.
7356 * frame.c (x_set_frame_parameters): Likewise.
7357 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7358 0 if not found, not -1. All callers changed.
7359
dd3f25f7
PE
7360 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7361 (stack_copy_size): Now size_t, not int.
7362 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7363
461c2ab9
JB
73642011-03-28 Juanma Barranquero <lekktu@gmail.com>
7365
7366 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7367 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7368 All callers changed.
7369
7370 * lisp.h (multibyte_char_to_unibyte):
7371 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7372 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7373 * character.h (CHAR_TO_BYTE8):
7374 * cmds.c (internal_self_insert):
7375 * editfns.c (general_insert_function):
7376 * keymap.c (push_key_description):
7377 * search.c (Freplace_match):
7378 * xdisp.c (message_dolog, set_message_1): All callers changed.
7379
f6d62986
SM
73802011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7381
7382 * keyboard.c (safe_run_hook_funcall): New function.
7383 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7384 don't set the hook to nil, but remove the offending function instead.
7385 (Qcommand_hook_internal): Remove, unused.
7386 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7387 Vcommand_hook_internal.
7388
7389 * eval.c (enum run_hooks_condition): Remove.
7390 (funcall_nil, funcall_not): New functions.
7391 (run_hook_with_args): Call each function through a `funcall' argument.
7392 Remove `cond' argument, now redundant.
7393 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7394 (Frun_hook_with_args_until_failure): Adjust accordingly.
7395 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7396
1db5b1ad
JB
73972011-03-28 Juanma Barranquero <lekktu@gmail.com>
7398
7399 * dispextern.h (string_buffer_position): Remove declaration.
7400
7401 * print.c (strout): Remove parameter `multibyte', unused since
7402 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7403
7404 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7405 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7406 All callers changed.
7407
7408 * w32.c (_wsa_errlist): Use braces for struct initializers.
7409
7410 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7411 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7412 All callers changed.
7413 (string_buffer_position): Likewise. Also, make static (it's never
7414 used outside xdisp.c).
7415 (cursor_row_p): Remove parameter `w', unused since
7416 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7417 (decode_mode_spec): Remove parameter `precision', introduced during
7418 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7419 All callers changed.
7420
5ffb62aa
JD
74212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7422
7423 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7424
461c2ab9 74252011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7426
7427 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7428 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7429 (ns_update_auto_hide_menu_bar): New functions.
7430 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7431 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7432 ns_constrain_all_frames.
7433 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7434 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7435
5c380ffb
JD
74362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7437
7438 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7439
9af30bdf
GM
74402011-03-27 Glenn Morris <rgm@gnu.org>
7441
7442 * syssignal.h: Replace RETSIGTYPE with void.
7443 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7444 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7445 Replace SIGTYPE with void everywhere.
7446 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7447 * s/template.h (SIGTYPE): Remove commented out definition.
7448
e2abce01
JB
74492011-03-26 Eli Zaretskii <eliz@gnu.org>
7450
7451 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7452 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7453
f868cd8a
JB
74542011-03-26 Juanma Barranquero <lekktu@gmail.com>
7455
59eb0929
JB
7456 * w32.c (read_unc_volume): Use parameter `henum', instead of
7457 global variable `wget_enum_handle'.
7458
7459 * keymap.c (describe_vector): Remove parameters `indices' and
7460 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7461 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7462
f868cd8a
JB
7463 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7464
7465 * keyboard.c (timer_check): Remove parameter `do_it_now',
7466 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7467 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7468 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7469
7470 * keyboard.c (read_char):
7471 * w32menu.c (w32_menu_display_help):
7472 * xmenu.c (show_help_event, menu_help_callback):
7473 Adjust calls to `show_help_echo'.
7474
7475 * gtkutil.c (xg_maybe_add_timer):
7476 * keyboard.c (readable_events):
7477 * process.c (wait_reading_process_output):
7478 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7479
7480 * insdel.c (adjust_markers_gap_motion):
7481 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7482 (gap_left, gap_right): Don't call it.
7483
2ecf6fdb
CY
74842011-03-25 Chong Yidong <cyd@stupidchicken.com>
7485
7486 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7487 incurred during fontification.
7488
6b1f9ba4
JB
74892011-03-25 Juanma Barranquero <lekktu@gmail.com>
7490
7491 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7492 (DEFVAR_PER_BUFFER): Don't pass it.
7493
7494 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7495 (scrolling_window): Don't pass it.
7496
0f4a96b5
JB
74972011-03-25 Juanma Barranquero <lekktu@gmail.com>
7498
7499 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7500
7501 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7502 and `suffix'.
7503 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7504 of variables specific to SELinux and computation of `encoded_absname'.
7505
7506 * image.c (XPutPixel): Remove unused variable `height'.
7507
7508 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7509
7510 * unexw32.c (get_section_info): Remove unused variable `section'.
7511
7512 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7513 (system_process_attributes): Remove unused variable `sess'.
7514 (sys_read): Remove unused variable `err'.
7515
7516 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7517 (w32_wnd_proc): Remove unused variable `isdead'.
7518 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7519 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7520 (x_create_tip_frame): Remove unused variable `tem'.
7521
7522 * w32inevt.c (w32_console_read_socket):
7523 Remove unused variable `no_events'.
7524
7525 * w32term.c (x_draw_composite_glyph_string_foreground):
7526 Remove unused variable `width'.
7527
1149507c
JB
75282011-03-24 Juanma Barranquero <lekktu@gmail.com>
7529
7530 * w32term.c (x_set_glyph_string_clipping):
7531 Don't pass uninitialized region to CombineRgn.
7532
9c88f339
JB
75332011-03-23 Juanma Barranquero <lekktu@gmail.com>
7534
7535 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7536 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7537 (Fx_close_connection): Remove unused variable `i'.
7538
7539 * w32font.c (w32font_draw): Return number of glyphs.
7540 (w32font_open_internal): Remove unused variable `i'.
7541 (w32font_driver): Add missing initializer.
7542
7543 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7544 (fill_in_menu): Remove unused variable `items_added'.
7545
7546 * w32term.c (last_mouse_press_frame): Remove static global variable.
7547 (w32_clip_to_row): Remove unused variable `f'.
7548 (x_delete_terminal): Remove unused variable `i'.
7549
7550 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7551 (NOTHING): Remove unused static global variable.
7552 (uniscribe_check_otf): Remove unused variable `table'.
7553 (uniscribe_font_driver): Add missing initializers.
7554
dee091a3
JD
75552011-03-23 Julien Danjou <julien@danjou.info>
7556
7557 * term.c (Fsuspend_tty, Fresume_tty):
7558 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7559 * window.c (temp_output_buffer_show):
7560 * insdel.c (signal_before_change):
7561 * frame.c (Fhandle_switch_frame):
7562 * fileio.c (Fdo_auto_save):
7563 * emacs.c (Fkill_emacs):
7564 * editfns.c (save_excursion_restore):
7565 * cmds.c (internal_self_insert):
7566 * callint.c (Fcall_interactively):
7567 * buffer.c (Fkill_all_local_variables):
7568 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7569 Use Frun_hooks.
0f4a96b5 7570 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7571 unconditionnaly since it does the check itself.
7572
2c520ab5 75732011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7574
c9c49752
PE
7575 Fix more problems found by GCC 4.5.2's static checks.
7576
8abc3f12
PE
7577 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7578 the first time through the loop, since we know p0 < p1 then.
7579 This also avoids a gcc -Wstrict-overflow warning.
7580
a2d26660
PE
7581 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7582 leading to a memory leak, possible in functions like
7583 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7584 of objects (Bug#8318).
a2d26660 7585
916c72e9
PE
7586 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7587 that could (at least in theory) be that large.
7588
19ab8a18
PE
7589 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7590 This is less likely to overflow, and avoids undefined behavior if
7591 overflow does occur. All callers changed. Use strtoul to scan
7592 for the unsigned long integer.
b7cbbd6f
PE
7593 (pint2hrstr): Simplify and tune code slightly.
7594 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7595
f0641eff
PE
7596 * scroll.c (do_scrolling): Work around GCC bug 48228.
7597 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7598
7f650bb9
PE
7599 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7600 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7601 (validate_x_resource_name): Simplify count usage.
7602 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7603
37dd57d1
PE
7604 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7605 fail (Bug#8306).
81e56e61 7606
699979fc 7607 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7608
401bf9b4
PE
7609 * process.c (Fmake_network_process): Use socklen_t, not int,
7610 where POSIX says socklen_t is required in portable programs.
7611 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7612 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7613 (Fmake_network_process, server_accept_connection):
7614 (wait_reading_process_output, read_process_output):
7615 Likewise.
7616
b93aacde
PE
7617 * process.c: Rename or move locals to avoid shadowing.
7618 (list_processes_1, Fmake_network_process):
7619 (read_process_output_error_handler, exec_sentinel_error_handler):
7620 Rename or move locals.
4dc343ee 7621 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7622 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7623 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7624 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7625 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7626
af8a867c 7627 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7628 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7629 Include tparam.h instead, since it declares them.
af8a867c
PE
7630 * cm.h (PC): Remove extern decl; tparam.h now does this.
7631 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7632 * terminfo.c: Include tparam.h, to check interfaces.
7633 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7634 (tparam): Adjust signature to match interface in tparam.h;
7635 this removes some undefined behavior. Check that outstring and len
7636 are zero, which they always are with Emacs.
7637 * tparam.h (PC, BC, UP): New extern decls.
7638
0248044d 7639 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7640 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7641
8ff096c1 7642 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7643 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7644 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7645 (ftfont_list): Remove unused local.
49eaafba
PE
7646 (get_adstyle_property, ftfont_pattern_entity):
7647 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7648 Rename locals to avoid shadowing.
8ff096c1 7649
e2be39f6
PE
7650 * xfont.c (xfont_list_family): Mark var as initialized.
7651
c9735e30
PE
7652 * xml.c (make_dom): Now static.
7653
8f5201ae
PE
7654 * composite.c (composition_compute_stop_pos): Rename local to
7655 avoid shadowing.
b246f932
PE
7656 (composition_reseat_it): Remove unused locals.
7657 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7658 (composition_update_it): Mark var as initialized.
11b61122
PE
7659 (find_automatic_composition): Mark vars as initialized,
7660 with a FIXME (Bug#8290).
8f5201ae 7661
760fbc2c
PE
7662 character.h: Rename locals to avoid shadowing.
7663 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7664 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7665 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7666 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7667 to avoid shadowing.
7668
ff08eb85
PE
7669 * textprop.c (property_change_between_p): Remove; unused.
7670
fc7bf025
PE
7671 * intervals.c (interval_start_pos): Now static.
7672
235d7abc
PE
7673 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7674
44f230aa
SM
7675 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7676 Rename locals to avoid shadowing.
3e7d6594 7677
50060332
PE
7678 * sound.c (wav_play, au_play, Fplay_sound_internal):
7679 Fix pointer signedness.
d01f234b 7680 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7681 (wav_play): Initialize a variable to 0, to prevent undefined
7682 behavior (Bug#8278).
50060332 7683
c4fc4e30
PE
7684 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7685
918436ed
PE
7686 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7687
c939f91b
PE
7688 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7689 clobbering (Bug#8298).
b9c7f648
PE
7690 * sysdep.c (sys_subshell): Likewise.
7691 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7692
6bd8c144
PE
7693 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7694 This should get cleaned up, so that child_setup has the
7695 same signature on all platforms.
7696
7710357c 7697 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7698 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7699
c59da222
CY
77002011-03-22 Chong Yidong <cyd@stupidchicken.com>
7701
7702 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7703 not to be necessary, and produces flickering.
7704
66b87493
GM
77052011-03-20 Glenn Morris <rgm@gnu.org>
7706
7707 * config.in: Remove file.
7708
45b6f6d5
JB
77092011-03-20 Juanma Barranquero <lekktu@gmail.com>
7710
7711 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7712 are now in src/globals.h.
7713 (syms_of_minibuf): Remove spurious & from previous change.
7714
3ec03f7e
LL
77152011-03-20 Leo <sdl.web@gmail.com>
7716
7717 * minibuf.c (completing-read-function): New variable.
7718 (completing-read-default): Rename from completing-read.
7719 (completing-read): Call completing-read-function.
7720
b14e3e21
CY
77212011-03-19 Juanma Barranquero <lekktu@gmail.com>
7722
7723 * xfaces.c (Fx_load_color_file):
7724 Read color file from absolute filename (bug#8250).
7725
f2b726e6
JB
77262011-03-19 Juanma Barranquero <lekktu@gmail.com>
7727
7728 * makefile.w32-in: Update dependencies.
7729
09f6ff02
EZ
77302011-03-17 Eli Zaretskii <eliz@gnu.org>
7731
7732 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7733
29a6015a
PE
77342011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7735
a3a6c54e
PE
7736 Fix more problems found by GCC 4.5.2's static checks.
7737
b766f867
PE
7738 * process.c (make_serial_process_unwind, send_process_trap):
7739 (sigchld_handler): Now static.
7740
be02381c
PE
7741 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7742 That way, the code declares only the vars that it needs.
7743 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7744 * s/cygwin.h (PTY_ITERATION): Likewise.
7745 * s/darwin.h (PTY_ITERATION): Likewise.
7746 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7747
57048744
PE
7748 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7749 * process.c (allocate_pty): Don't declare stb unless it's needed.
7750
7914961c 7751 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7752 (CONSTANTLIM): Remove; unused.
7753 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7754 Define only if needed.
7914961c 7755
b3967b18
PE
7756 * unexelf.c (unexec): Name an expression,
7757 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7758 Use a different way to cause a compilation error if anyone uses
7759 n rather than nn, a way that does not involve shadowing.
73366a00 7760 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7761
29a6015a
PE
7762 * deps.mk (unexalpha.o): Remove; unused.
7763
43cfc33e 7764 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7765 * unexec.h: New file.
ce701a33
PE
7766 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7767 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7768 Depend on unexec.h.
7769 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7770 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7771 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7772 Change as necessary to match prototype in unexec.h.
ce701a33 7773
01f44d5a
PE
7774 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7775 shadowing.
4f63c6bb 7776 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7777
a6670b0b
PE
7778 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7779 Rename locals to avoid shadowing.
7780
cef2010d 7781 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7782 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7783
d4d7173a
PE
7784 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7785
f08b802a
PE
7786 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7787 warning when compiling print.c.
7788
3ddb0639
PE
7789 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7790 instead of using an uninitialized var.
5ad03b97 7791 (font_sort_entities): Mark var as initialized.
3ddb0639 7792
170a2692
PE
7793 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7794
e663c700
PE
7795 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7796 pointers to constants.
89bc529a 7797 (font_parse_fcname): Remove unused vars.
7b81e2d0 7798 (font_delete_unmatched): Now static.
ea838e10 7799 (font_get_spec): Remove; unused.
13a547c6
PE
7800 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7801 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7802 Rename or move locals to avoid shadowing.
e663c700 7803
2a80c887 7804 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7805 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7806
1384fa33 7807 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7808 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7809
8b2c52e9
PE
7810 * alloc.c (mark_backtrace): Move decl from here ...
7811 * lisp.h: ... to here, so that it can be checked.
7812
475545b5 7813 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7814 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7815 (lisp_indirect_variable): Name an expression,
7816 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7817 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7818
b1349114 7819 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7820 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7821 Use const pointer when appropriate.
b1349114 7822
a2928364
PE
7823 * lisp.h (get_system_name, get_operating_system_release):
7824 Move decls here, to check interfaces.
7825 * process.c (get_operating_system_release): Move decl to lisp.h.
7826 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7827 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7828 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7829 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7830 (Fformat_time_string, Fencode_time, Finsert_char):
7831 (Ftranslate_region_internal, Fformat):
7832 Rename or remove local vars to avoid shadowing.
9710023e 7833 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7834
a415e694
PE
7835 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7836 avoid shadowing.
7837
8ef4622d
PE
7838 * lisp.h (eassert): Check that the argument compiles, even if
7839 ENABLE_CHECKING is not defined.
7840
946f9a5b
PE
7841 * data.c (Findirect_variable): Name an expression, to avoid
7842 gcc -Wbad-function-cast warning.
112396d6 7843 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7844 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7845 (Fmake_variable_buffer_local, Fmake_local_variable):
7846 Mark variables as initialized.
52746918 7847 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7848
e5aab7e7 7849 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7850 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7851 Rename locals to avoid shadowing.
dff45157
PE
7852 (mark_stack): Move local variables into the #ifdef region where
7853 they're used.
7bc26fdb
PE
7854 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7855 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7856 needed otherwise.
7857 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7858 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7859 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7860
e5aab7e7
PE
7861 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7862 avoids undefined behavior in theory.
7863
4da60324
PE
7864 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7865
88043301
PE
7866 Use functions, not macros, for up- and down-casing (Bug#8254).
7867 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7868 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7869 to use the following functions instead of these macros.
7870 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7871 EMACS_INT, since callers assume the returned value fits in int.
7872 (upcase1): Likewise, for UPCASE_TABLE.
7873 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7874 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7875 the race-condition problem in the old DOWNCASE.
88043301 7876
19ed5445
PE
7877 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7878 Rename locals to avoid shadowing.
7879 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7880 (regex_compile, re_search_2, re_match_2_internal):
7881 Remove unused local vars.
952db0d7
PE
7882 (FREE_VAR): Rewrite so as not to use empty "else",
7883 which gcc can warn about.
da053e48 7884 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7885 (RETALLOC_IF): Define only if needed.
7886 (WORDCHAR_P): Likewise. This one is never needed, but is used
7887 only in a comment talking about a compiler bug, so put inside
7888 the #if 0 of that comment.
7889 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7890 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7891 Remove; unused.
19ed5445 7892
1f3561e4 7893 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7894 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7895 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7896
ded6f8f7
PE
7897 * search.c (simple_search): Remove unused var.
7898
dbd37a95
PE
7899 * dired.c (compile_pattern): Move decl from here ...
7900 * lisp.h: ... to here, so that it can be checked.
7901 (struct re_registers): New forward decl.
7902
7e47afad
PE
7903 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7904
85f24f61
PE
7905 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7906 All uses changed.
7907 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7908 Rename locals to avoid shadowing.
5671df8f 7909 (Fvertical_motion): Mark locals as initialized.
85f24f61 7910
181aa2be 7911 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7912 (casify_region): Mark local as initialized.
181aa2be 7913
930d429c
PE
7914 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7915
7082eac6
PE
7916 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7917 New macros, so that the caller can use some names other than
7918 gcpro1, gcpro2, etc.
7919 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7920 of the new macros.
7921 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7922 argument, for consistency with GCPRO2_VAR, etc: it is now the
7923 prefix of the variable, not the variable itself. All uses
7924 changed.
38b2c076
PE
7925 * dired.c (directory_files_internal, file_name_completion):
7926 Rename locals to avoid shadowing.
7927
15206ed9
PE
7928 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7929 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7930 dired.c's scmp function, had undefined behavior.
7931 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7932 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7933 * buffer.h: ... to here, because these macros use current_buffer,
7934 and the new implementation with inline functions needs to have
7935 current_buffer in scope now, rather than later when the macros
7936 are used.
7937 (downcase, upcase1): New static inline functions.
7938 (DOWNCASE, UPCASE1): Reimplement using these functions.
7939 This avoids undefined behavior in expressions like
7940 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7941 from race conditions in accessing the global variables
7942 case_temp1 and case_temp2.
7943 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7944 * lisp.h (case_temp1, case_temp2): Remove their decls.
7945 * character.h (ASCII_CHAR_P): Move from here ...
7946 * lisp.h: ... to here, so that the inline functions mentioned
7947 above can use them.
7948
4a6bea26
PE
7949 * dired.c (directory_files_internal_unwind): Now static.
7950
f14b7e14
PE
7951 * fileio.c (file_name_as_directory, directory_file_name):
7952 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7953 Now static.
2893f146
PE
7954 (file_name_as_directory): Use const pointers when appropriate.
7955 (Fexpand_file_name): Likewise. In particular, newdir might
7956 point at constant storage, so make it a const pointer.
fd4ead52 7957 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7958 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7959 signedness issues.
f839df0c
PE
7960 (Fset_file_times, Finsert_file_contents, auto_save_error):
7961 Rename locals to avoid shadowing.
f14b7e14 7962
5716756e 7963 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7964 (Ftry_completion, Fall_completions): Rename or remove locals
7965 to avoid shadowing.
5716756e 7966
b4c3046a
PE
7967 * marker.c (bytepos_to_charpos): Remove; unused.
7968
b45db522
PE
7969 * lisp.h (verify_bytepos, count_markers): New decls,
7970 so that gcc does not warn that these functions aren't declared.
7971
85876d07
PE
7972 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7973 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7974 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7975 (copy_text): Remove unused local var.
85876d07 7976
03d78a21 7977 * filelock.c (within_one_second): Now static.
b3dd38ab 7978 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7979
5df8f01b
PE
7980 * buffer.c (fix_overlays_before): Mark locals as initialized.
7981 (fix_start_end_in_overlays): Likewise. This function should be
7982 simplified by using pointers-to-pointers, but that's a different
7983 matter.
b1d876f1 7984 (switch_to_buffer_1): Now static.
8f54f30a
PE
7985 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7986 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7987
a70072c9 7988 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7989 Fix pointer signedness issue.
edced198
PE
7990 (sys_subshell): Mark local as volatile if checking for lint,
7991 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7992 (MAXPATHLEN): Define only if needed.
a70072c9 7993
a0977c44
PE
7994 * process.c (serial_open, serial_configure): Move decls from here ...
7995 * systty.h: ... to here, so that they can be checked.
7996
a884fdcc
PE
7997 * fns.c (get_random, seed_random): Move extern decls from here ...
7998 * lisp.h: ... to here, so that they can be checked.
7999
604efe86 8000 * sysdep.c (reset_io): Now static.
b8950c94 8001 (wait_for_termination_signal): Remove; unused.
604efe86 8002
38fc62d9
PE
8003 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8004 (copy_keymap_item, append_key, push_text_char_description):
8005 Now static.
1004a21a 8006 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8007 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8008 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8009 (describe_map_tree):
8010 Rename locals to avoid shadowing.
38fc62d9 8011
2f2650da
PE
8012 * keyboard.c: Declare functions static if they are not used elsewhere.
8013 (echo_char, echo_dash, cmd_error, top_level_2):
8014 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8015 (read_char, kbd_buffer_get_event, make_lispy_position):
8016 (make_lispy_event, make_lispy_movement, apply_modifiers):
8017 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8018 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8019 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8020 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8021 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8022
a053e86c 8023 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8024 (mark_kboards): Move decl here ...
8025 * alloc.c (mark_kboards): ... from here.
a053e86c 8026
4752793e
PE
8027 * lisp.h (force_auto_save_soon): New decl.
8028
74f10ca7 8029 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8030 (DEFINE_DUMMY_FUNCTION): New macro.
8031 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8032 Use it.
c03cd23f
PE
8033 (main): Add casts to avoid warnings
8034 if GCC considers string literals to be constants.
74f10ca7 8035
022e70d4
PE
8036 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8037
59d6fe83
PE
8038 * dbusbind.c: Pointer signedness fixes.
8039 (xd_signature, xd_append_arg, xd_initialize):
8040 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8041 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8042 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8043 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8044
78320123
PE
8045 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8046 if GCC considers string literals to be constants.
49cebcca 8047 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8048
35ac2a97
SM
80492011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8050
fb103ca9
SM
8051 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8052 (print_preprocess, print_object): New macro to fix last change.
8053
35ac2a97
SM
8054 * print.c (print_preprocess): Don't forget font objects.
8055
62973b41
JB
80562011-03-16 Juanma Barranquero <lekktu@gmail.com>
8057
8058 * emacs.c (USAGE3): Doc fixes.
8059
0e48bb22
AS
80602011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8061
8062 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8063 structure.
8064
7684e57b
JB
80652011-03-14 Juanma Barranquero <lekktu@gmail.com>
8066
8067 * lisp.h (VWindow_system, Qfile_name_history):
8068 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8069 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8070 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8071
8072 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8073 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8074
8075 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8076 * w32console.c (detect_input_pending, read_input_pending)
8077 (encode_terminal_code):
8078 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8079 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8080 (w32_system_caret_y, Qfile_name_history):
8081 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8082 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8083 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8084 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8085 * w32proc.c (Qlocal, report_file_error):
8086 * w32term.c (Vwindow_system, updating_frame):
8087 * w32uniscribe.c (initialized, uniscribe_font_driver):
8088 Remove unneeded extern declarations.
8089
2aa46d6c
CY
80902011-03-14 Chong Yidong <cyd@stupidchicken.com>
8091
c96bbc66 8092 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8093
cffc6f3b
CY
80942011-03-13 Chong Yidong <cyd@stupidchicken.com>
8095
8096 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8097 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8098 These macros can no longer be used for assignment.
8099
44f230aa
SM
8100 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8101 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8102 (record_buffer_markers, fetch_buffer_markers): New functions for
8103 recording and fetching special buffer markers.
8104 (set_buffer_internal_1, set_buffer_temp): Use them.
8105
8106 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8107
8108 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8109
8110 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8111 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8112
8113 * xdisp.c (hscroll_window_tree):
8114 (reconsider_clip_changes): Use PT instead of BUF_PT.
8115
d251f04b
EZ
81162011-03-13 Eli Zaretskii <eliz@gnu.org>
8117
8118 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8119 $(EMACS_ROOT)/lib/intprops.h.
8120
f0c77cd1
PE
81212011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8122
3eca4629
PE
8123 Fix more problems found by GCC 4.5.2's static checks.
8124
7c86ee98
PE
8125 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8126 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8127 (xg_free_frame_widgets): Make it clear that a local variable is
8128 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8129 (gdk_window_get_screen): Make it clear that this macro is needed
8130 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8131 (int_gtk_range_get_value): New function, which avoids a diagnostic
8132 from gcc -Wbad-function-cast.
8133 (xg_set_toolkit_scroll_bar_thumb): Use it.
8134 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8135 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8136 (get_utf8_string, xg_get_file_with_chooser):
8137 Rename locals to avoid shadowing.
8138 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8139
41729b81
PE
8140 * xgselect.c (xg_select): Remove unused var.
8141
f0c77cd1
PE
8142 * image.c (four_corners_best): Mark locals as initialized.
8143 (gif_load): Initialize transparent_p to zero (Bug#8238).
8144 Mark another local as initialized.
ec6cf4c6 8145 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8146
ce0ad53d 8147 * image.c (clear_image_cache): Now static.
d5d5a617 8148 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8149 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8150 (x_edge_detection): Remove unnecessary cast that
8151 gcc -Wbad-function-cast diagnoses.
2037898d 8152 (gif_load): Fix pointer signedness.
6ae141d6
PE
8153 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8154 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8155
33383987 81562011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8157
d32df629
PE
8158 Improve quality of tests for time stamp overflow.
8159 For example, without this patch (encode-time 0 0 0 1 1
8160 1152921504606846976) returns the obviously-bogus value (-948597
8161 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8162 reports time overflow. See
8163 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8164 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8165 * editfns.c: Include limits.h and intprops.h.
8166 (TIME_T_MIN, TIME_T_MAX): New macros.
8167 (time_overflow): Move earlier, to before first use.
8168 (hi_time, lo_time): New functions, for an accurate test for
8169 out-of-range times.
8170 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8171 (Fget_internal_run_time): Don't assume time_t fits in int.
8172 (make_time): Use list2 instead of Fcons twice.
8173 (Fdecode_time): More accurate test for out-of-range times.
8174 (check_tm_member): New function.
8175 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8176 (lisp_time_argument): Don't rely on undefined left-shift and
8177 right-shift behavior when checking for time stamp overflow.
8be6f318 8178
fe31d94c
PE
8179 * editfns.c (time_overflow): New function, refactoring common code.
8180 (Fformat_time_string, Fdecode_time, Fencode_time):
8181 (Fcurrent_time_string): Use it.
8182
8be6f318
PE
8183 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8184 * dired.c (make_time): Move to ...
8185 * editfns.c (make_time): ... here.
8186 * systime.h: Note the move.
8187
09d9db2c 81882011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8189
126bc0dc
YM
8190 * fringe.c (update_window_fringes): Remove unused variables.
8191
c47cbdfd
YM
8192 * unexmacosx.c (copy_data_segment): Also copy __got section.
8193 (Bug#8223)
8194
7ac80be9
EZ
81952011-03-12 Eli Zaretskii <eliz@gnu.org>
8196
c96bbc66 8197 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8198 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8199 Constify `char *' arguments and their references according to
8200 prototypes in tparam.h.
8201
ecb0f94d 8202 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8203
7ac80be9
EZ
8204 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8205 Adapt all references accordingly.
8206
8207 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8208
ef1fd07e
TT
82092011-03-11 Tom Tromey <tromey@redhat.com>
8210
8211 * buffer.c (syms_of_buffer): Remove obsolete comment.
8212
7ef4b50c
EZ
82132011-03-11 Eli Zaretskii <eliz@gnu.org>
8214
8215 * termhooks.h (encode_terminal_code): Declare prototype.
8216
8217 * msdos.c (encode_terminal_code): Don't declare prototype.
8218
8219 * term.c (encode_terminal_code): Now external again, used by
8220 w32console.c and msdos.c.
8221
44f230aa
SM
8222 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8223 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8224
4b1ec863 82252011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8226
1714f52b 8227 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8228
4b1ec863
PE
8229 * fringe.c (update_window_fringes): Mark locals as initialized
8230 (Bug#8227).
8231 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8232
524c7aa6
PE
8233 * alloc.c (mark_fringe_data): Move decl from here ...
8234 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8235 to check its interface.
8236 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8237
a5c0af81 8238 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8239 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8240 (fontset_font): Mark local as initialized.
a9a06e0b 8241 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8242
b4716021
PE
8243 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8244
811e9bac 8245 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8246 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8247 (x_own_selection, Fx_disown_selection_internal): Rename locals
8248 to avoid shadowing.
8249 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8250
7e3ab302
PE
8251 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8252 so that the caller can use some name other than gcpro1.
8253 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8254 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8255 (Fx_backspace_delete_keys_p):
8256 Use them to avoid shadowing, and rename vars to avoid shadowing.
8257 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8258 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8259 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8260 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8261 Remove unused locals.
7e3ab302
PE
8262 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8263 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8264 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8265 macros.
f78faa98 8266
e2b13473
PE
8267 * xterm.h (x_mouse_leave): New decl.
8268
77f23912
PE
8269 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8270 Remove unused functions.
cdf4ba58
PE
8271 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8272 (x_calc_absolute_position): Now static.
7411c686 8273 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8274 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8275 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8276 unless they are used.
38d0b34a
PE
8277 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8278 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8279 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8280 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8281 (x_error_catcher, x_connection_closed, x_error_handler):
8282 (x_error_quitter, xembed_send_message, x_iconify_frame):
8283 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8284 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8285 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8286
44f230aa
SM
8287 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8288 Rename or move locals to avoid shadowing.
6b463e58 8289 (tty_defined_color, merge_face_heights): Now static.
5967d051 8290 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8291 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8292 does not deduce is never used uninitialized.
73719eba
PE
8293 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8294 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8295
426994c3 8296 * terminal.c (store_terminal_param): Now static.
5489860b 8297
032f1620 8298 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8299 (set_frame_menubar): Remove unused local.
d4323972 8300 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8301 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8302 since they might point to immutable storage.
281585b0
PE
8303 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8304 since it's unused otherwise.
032f1620 8305
367c19e5 8306 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8307 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8308 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8309 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8310 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8311 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8312 does not deduce are never used uninitialized.
70739cbe 8313
07b48fa9
PE
8314 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8315
8868a238 8316 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8317 * window.c (window_loop, size_window):
8318 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8319
7e5cf297 8320 * window.c (display_buffer): Now static.
d6550a9f
PE
8321 (size_window): Mark variables that gcc -Wuninitialized
8322 does not deduce are never used uninitialized.
a586633d
PE
8323 * window.h (check_all_windows): New decl, to forestall
8324 gcc -Wmissing-prototypes diagnostic.
5b555da1 8325 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8326
f6095868
PE
8327 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8328 shadowing.
8329 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8330 Include <limits.h>.
8331 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8332 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8333 (load_charset_map): Mark variables that gcc -Wuninitialized
8334 does not deduce are never used uninitialized.
53df7c11 8335 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8336
f38b440c
PE
8337 * coding.c (coding_set_source, coding_set_destination):
8338 Use "else { /* comment */ }" rather than "else /* comment */;"
8339 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8340 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8341 a block, when the outer 'i' will do.
8342 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8343 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8344 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8345 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8346 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8347 Rename locals to avoid shadowing.
8348 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8349 * coding.c (emacs_mule_char, encode_invocation_designation):
8350 Now static, since they're not used elsewhere.
413bb2db 8351 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8352 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8353 (decode_coding_emacs_mule): Mark variables that gcc
8354 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8355 (detect_coding_iso_2022): Initialize a local variable that might
8356 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8357 this initialization is needed. (Bug#8211)
5f58e762
PE
8358 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8359 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8360 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8361 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8362 Remove unused macros.
f38b440c 8363
232b38b9 8364 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8365 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8366 * character.c (string_count_byte8): Likewise.
232b38b9 8367
fb90da1b
PE
8368 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8369 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8370
fb93dbc2
PE
8371 * chartab.c (copy_sub_char_table): Now static, since it's not used
8372 elsewhere.
5c156ace
PE
8373 (sub_char_table_ref_and_range, char_table_ref_and_range):
8374 Rename locals to avoid shadowing.
bbcd0949 8375 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8376
7d3b3862 8377 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8378 (BIDI_BOB): Remove unused macro.
7d3b3862 8379
6be7d3da
PE
8380 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8381 deduce are never used uninitialized.
c2ed9c8b 8382 * term.c (encode_terminal_code): Likewise.
6be7d3da 8383
75f8807f 8384 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8385
50938595
PE
8386 * tparam.h: New file.
8387 * term.c, tparam.h: Include it.
8388 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8389 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8390 Move these decls to tparam.h, and make them agree with what
8391 is actually in tparam.c. The previous trick of using incompatible
8392 decls in different modules does not conform to the C standard.
8393 All callers of tparam changed to use tparam's actual API.
8394 * tparam.c (tparam1, tparam, tgoto):
8395 Use const pointers where appropriate.
8396
fbceeba2
PE
8397 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8398 * cm.h (struct cm): Likewise.
8399 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8400 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8401 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8402 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8403 (turn_on_face, init_tty): Likewise.
8404 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8405
7f3f1250
PE
8406 * term.c (term_mouse_position): Rename local to avoid shadowing.
8407
e6ca6543
PE
8408 * alloc.c (mark_ttys): Move decl from here ...
8409 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8410
c40f8d15
AS
84112011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8412
8413 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8414
cfe0661d
JB
84152011-03-09 Juanma Barranquero <lekktu@gmail.com>
8416
8417 * search.c (compile_pattern_1): Remove argument regp, unused since
8418 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8419 (compile_pattern): Don't pass it.
8420
0afb4571
J
84212011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8422
8423 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8424 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8425 for ! HAVE_GTK3.
8426 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8427
8428 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8429
8430 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8431 gdk_window_get_screen, gdk_window_get_geometry,
8432 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8433 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8434 (xg_get_pixbuf_from_pixmap): New function.
8435 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8436 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8437 Call xg_get_pixbuf_from_pixmap instead of
8438 gdk_pixbuf_get_from_drawable.
8439 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8440 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8441 (xg_check_special_colors): Use GtkStyleContext and its functions
8442 for HAVE_GTK3.
8443 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8444 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8445 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8446 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8447 Call gtk_widget_get_preferred_size.
0afb4571
J
8448 (xg_frame_resized): gdk_window_get_geometry only takes 5
8449 parameters.
44f230aa
SM
8450 (xg_win_to_widget, xg_event_is_for_menubar):
8451 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8452 (xg_set_widget_bg): New function.
8453 (delete_cb): New function.
895009e1 8454 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8455 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8456 (xg_set_background_color): Call xg_set_widget_bg.
8457 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8458 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8459 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8460 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8461 if ! HAVE_GTK3.
8462 (update_frame_tool_bar): Call gtk_widget_hide.
8463 (xg_initialize): Use GDK_KEY_g.
8464
8465 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8466 if ! HAVE_GTK3
8467 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8468
8469 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8470 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8471 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8472
1c2cc4ef
JB
84732011-03-08 Juanma Barranquero <lekktu@gmail.com>
8474
8475 * w32xfns.c (select_palette): Check success of RealizePalette against
8476 GDI_ERROR, not zero.
8477
33383987 8478See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8479
8480;; Local Variables:
8481;; coding: utf-8
aac0c6e3
MR
8482;; End:
8483
33383987 8484 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8485
8486 This file is part of GNU Emacs.
8487
8488 GNU Emacs is free software: you can redistribute it and/or modify
8489 it under the terms of the GNU General Public License as published by
8490 the Free Software Foundation, either version 3 of the License, or
8491 (at your option) any later version.
8492
8493 GNU Emacs is distributed in the hope that it will be useful,
8494 but WITHOUT ANY WARRANTY; without even the implied warranty of
8495 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8496 GNU General Public License for more details.
8497
8498 You should have received a copy of the GNU General Public License
8499 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.