Fix bug #9963 with abort in "temacs -nw".
[bpt/emacs.git] / src / ChangeLog
CommitLineData
88a37c4d
EZ
12011-11-06 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6 return Qleft_to_right.
7
49745b39
CY
82011-11-06 Chong Yidong <cyd@gnu.org>
9
10 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
11 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
12 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
13 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
14 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
15 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
16 (Fwindow_vscroll): Doc fix.
17 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
18 argument, since it makes no sense to pass a live window and for
19 consistency with window-child.
20
1f05cd82
CS
212011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
22
23 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
24 support MSVC.
25
22610910
JR
262011-11-05 Jason Rumney <jasonr@gnu.org>
27
28 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
29 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
30 fonts (Bug#6029).
31 (add_font_entity_to_list): Fix logic errors in mixed boolean and
32 bitwise arithmetic preventing use of unicode-sip and non-truetype
33 opentype fonts.
34
a06776b2
EZ
352011-11-05 Eli Zaretskii <eliz@gnu.org>
36
3ad924ba
EZ
37 * s/ms-w32.h (fstat, stat, utime): Move redirections to
38 "emacs"-only part.
39
a06776b2
EZ
40 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
41 initialization code to keep similarity to xfns.c after changes
42 from 2011-11-05.
43
c9e7db78
JD
442011-11-05 Jan Djärv <jan.h.d@swipnet.se>
45
a97f8f3f
JD
46 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
47 (unwind_create_frame): New function (Bug#9943).
48 (Fx_create_frame): Restructure code to be more similar to the one in
49 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
50 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
51 Move terminal->reference_count++ just before making the frame official
52 (Bug#9943).
53
54 * nsterm.m (x_free_frame_resources): New function.
55 (x_destroy_window): Move code to x_free_frame_resources.
56
c9e7db78
JD
57 * xfns.c (unwind_create_frame): Fix comment.
58 (Fx_create_frame, x_create_tip_frame): Move
59 terminal->reference_count++ just before making the frame
60 official. Move initialization of image_cache_refcount and
61 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
62
a6fc3b5c
EZ
632011-11-05 Eli Zaretskii <eliz@gnu.org>
64
65 Support MSVC build with newer versions of Visual Studio.
66 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
67 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
68 nt/gmake.defs.
69
70 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
71 which are not supported by MSVC.
72 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
73 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
74 bitfields.
75 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
76 types in bitfields.
77 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
78
79 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
80
812011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
82
83 Support MSVC build with newer versions of Visual Studio.
84 * w32.c: Don't include w32api.h for MSVC.
85 (init_environment) [_MSC_VER]: Call sys_access, not _access.
86
87 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
88 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
89 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
90 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
91 e_* cousins.
92 (alloca) [_MSC_VER]: Define to _alloca.
93
94 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
95
96 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
97
a58c13ed
EZ
982011-11-04 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (note_mouse_highlight): If either of
101 previous/next-single-property-change returns nil, treat that as
102 the beginning or the end of the buffer. (Bug#9955)
103
fe0b6370
JD
1042011-11-04 Jan Djärv <jan.h.d@swipnet.se>
105
a58c13ed 106 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
107 label is not null (Bug#9951).
108 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
109 may be NULL.
110
89bd5ee1
EZ
1112011-11-04 Eli Zaretskii <eliz@gnu.org>
112
113 * window.c (Fwindow_body_size): Mention in the doc string that the
114 return value is in frame's canonical units. (Bug#9949)
115
84c3edb9
EZ
1162011-11-03 Eli Zaretskii <eliz@gnu.org>
117
4e2fb5c7
EZ
118 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
119
84c3edb9 120 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 121 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 122 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 123
bc17a887
EZ
1242011-11-01 Eli Zaretskii <eliz@gnu.org>
125
126 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
127 Don't stop backward scan on the continuation glyph, even though
128 its CHARPOS is positive.
26b46e51
EZ
129 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
130 cover_string to disp_string.
bc17a887 131
4ee88440
MR
1322011-11-01 Martin Rudalics <rudalics@gmx.at>
133
134 * window.c (temp_output_buffer_show): Don't use
135 Vtemp_buffer_show_specifiers.
136 (Vtemp_buffer_show_specifiers): Remove unused variable.
137
c2ff3c02
EZ
1382011-10-30 Eli Zaretskii <eliz@gnu.org>
139
140 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
141 past the beginning of the current glyph matrix.
142
6e56383b
JD
1432011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
144
145 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
146 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
147 HAVE_GTK3 (Bug#9869).
b77a6a7f 148
3b574623
JD
149 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
150 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
151
b77a6a7f
JD
152 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
153
154 * xterm.c: Declare x_handle_net_wm_state to return int.
155 (handle_one_xevent): Check if we are iconified but don't have
156 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
157 (get_current_wm_state): Return non-zero if not hidden,
158 check for _NET_WM_STATE_HIDDEN (Bug#9893).
159 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
160 (x_handle_net_wm_state): Return what get_current_wm_state returns.
161 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
162
196e41e4
PE
1632011-10-29 Paul Eggert <eggert@cs.ucla.edu>
164
165 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
166 so that this new function doesn't get optimized away by a
167 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
168
021f2e1a
AS
1692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
170
171 * frame.h (MOUSE_HL_INFO): Remove excess parens.
172
8b058d44
EZ
1732011-10-29 Eli Zaretskii <eliz@gnu.org>
174
175 Fix the `xbytecode' command.
176 * .gdbinit (xprintbytestr): New command.
177 (xwhichsymbols): Renamed from `which'; all callers changed.
178 (xbytecode): Print the byte-code string as well.
179
4452fb80
EZ
1802011-10-29 Kim Storm <storm@cua.dk>
181
8b058d44
EZ
182 * alloc.c (which_symbols): New function.
183
21b72067
AS
1842011-10-29 Andreas Schwab <schwab@linux-m68k.org>
185
186 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
187 line. (Bug#9903)
188
83ed7b5c
GM
1892011-10-29 Glenn Morris <rgm@gnu.org>
190
191 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
192 Not clear what it was for, and it causes various bugs. (Bug#9839)
193
5a7a728b
EZ
1942011-10-28 Eli Zaretskii <eliz@gnu.org>
195
196 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
197 possible random value that matches one of those tested as
198 condition to clear the mouse face.
199
d3d0842f
CY
2002011-10-28 Chong Yidong <cyd@gnu.org>
201
202 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
203
31b39d13
DN
2042011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
205
206 * window.c (make_window): Initialize phys_cursor_on_p.
207
9aba6043
SM
2082011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
209
210 * lisp.h (struct Lisp_Symbol): Update comments.
211
c20992f4
JB
2122011-10-28 Juanma Barranquero <lekktu@gmail.com>
213
214 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
215
db4f02f2
EZ
2162011-10-28 Eli Zaretskii <eliz@gnu.org>
217
218 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
219 <oslsachem@gmail.com> for helping to debug this.
220
221 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
222 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
223 (g_b_init_get_glyph_outline_w): New static variables.
224 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
225 (GetGlyphOutlineW_Proc): New typedefs.
226 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
227 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
228 New functions.
229 (w32font_open_internal, compute_metrics):
230 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
231 instead of calling the "wide" APIs directly.
232
233 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
234
235 * w32.h (syms_of_w32font): Add prototype.
236
87e68db4
JB
2372011-10-27 Juanma Barranquero <lekktu@gmail.com>
238
239 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
240 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
241 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
242 (Fmove_to_window_line): Doc fix.
243
435c1d67
CY
2442011-10-27 Chong Yidong <cyd@gnu.org>
245
246 * process.c (make_process): Set gnutls_state to NULL.
247
248 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
249 non-NULL, regardless of GNUTLS_INITSTAGE.
250 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
251 an error. Set process slots as soon as we allocate them.
252
253 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
254
9c6c6f49
CY
2552011-10-27 Chong Yidong <cyd@gnu.org>
256
9aba6043
SM
257 * gnutls.c (emacs_gnutls_deinit): New function.
258 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
259 (Fgnutls_deinit, Fgnutls_boot): Use it.
260
261 * process.c (make_process): Initialize GnuTLS credentials to NULL.
262 (deactivate_process): Call emacs_gnutls_deinit.
263
657d08d3
JB
2642011-10-27 Juanma Barranquero <lekktu@gmail.com>
265
266 * image.c (x_create_x_image_and_pixmap):
267 * w32.c (sys_rename, w32_delayed_load):
268 * w32font.c (fill_in_logfont):
269 * w32reg.c (x_get_string_resource): Silence compiler warnings.
270
5430d399
JB
2712011-10-26 Juanma Barranquero <lekktu@gmail.com>
272
273 * w32fns.c (w32_default_color_map): New function,
274 extracted from Fw32_default_color_map.
a7ef684b 275 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 276
fe0055fa
PE
2772011-10-25 Paul Eggert <eggert@cs.ucla.edu>
278
279 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
280
e6346438
SM
2812011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
282
283 * keyboard.c (test_undefined): New function (bug#9751).
284 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
285
e112cc37
ET
2862011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
287
288 * sysdep.c (init_sys_modes): Fix the check for the controlling
289 terminal (Bug#6649).
290
7b5d6677
EZ
2912011-10-20 Eli Zaretskii <eliz@gnu.org>
292
293 * dispextern.h (struct bidi_it): New member next_en_type.
294
295 * bidi.c (bidi_line_init): Initialize the next_en_type member.
296 (bidi_resolve_explicit_1): When next_en_pos is valid for the
297 current character, check also for next_en_type being WEAK_EN.
298 (bidi_resolve_weak): Don't enter the expensive loop if the current
299 position is before next_en_pos. Record the bidi type of the first
300 non-ET, non-BN character we find, in addition to its position.
301 (bidi_level_of_next_char): Invalidate next_en_type when
302 next_en_pos is over-stepped.
303
7da0b018
PE
3042011-10-20 Paul Eggert <eggert@cs.ucla.edu>
305
306 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
307 * editfns.c: Rewrite current-time-zone so that it invokes
308 the equivalent of (format-time-string "%Z") to get the time zone name.
309 This fixes a bug when the time zone name contains characters that
310 need converting from the system time locale to Emacs internal format.
311 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
312 that patch fixed format-time-string to do the conversion, but
313 I forgot to fix current-time-zone.
314 (format_time_string): New function, containing most of
315 what Fformat_time_string used to contain.
316 (Fformat_time_string): Rewrite in terms of format_time_string.
317 This doesn't change this function's behavior.
318 (current-time-zone): Rewrite to use format_time_string.
319 This fixes the bug reported by Michael Schierl in
320 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
321 Jason Rumney's 2007-06-07 change worked around this bug, but
322 didn't fix it.
323 * systime.h (tzname, timezone): Remove no-longer-used declarations.
324
8547b010
EZ
3252011-10-19 Eli Zaretskii <eliz@gnu.org>
326
327 * xdisp.c (start_display): If the character at POS is displayed
328 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
329 (try_window_reusing_current_matrix): If a line ends in a display
330 vector or the next line starts in a display vector, continue
331 redrawing the window even though the character position of
332 start_row was reached.
8547b010
EZ
333 (Bug#9771, part 2)
334
4e948d15
CY
3352011-10-18 Chong Yidong <cyd@gnu.org>
336
337 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
338 with nobreak-char-display too.
339
4787455f
EZ
3402011-10-18 Eli Zaretskii <eliz@gnu.org>
341
342 Fix part 3 of bug#9771.
343 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
344 (bidi_resolve_neutral): Don't enter the expensive loop looking for
345 non-neutral characters if the current character is a paragraph
346 separator (a.k.a. Newline). This avoids running the same
347 expensive loop twice, once when we consume the preceding newline
348 and the other time when the line actually needs to be displayed.
349 Avoid the loop when we see neutrals on the base embedding level
350 following a character whose directionality is the same as the
351 paragraph's. This avoids running the expensive loop when a line
352 ends in a long sequence of neutrals, like control characters.
353 Add assertion against STRONG_AL type. Slightly rearrange code
354 that determines the type of a neutral given the first non-neutral
355 that follows it.
356 (bidi_level_of_next_char): Set next_en_pos to zero when
357 invalidating its info.
358
2c91f553
EZ
3592011-10-17 Eli Zaretskii <eliz@gnu.org>
360
361 * xdisp.c (push_display_prop): Determine whether to record string
362 or buffer position by IT->string, not by IT->method. Allow
363 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
364 (move_it_vertically_backward): Don't look for character position
365 immediately after the newline when in a continuation line.
366 (Bug#9771, part 1)
2c91f553 367
c7b08b0d
MR
3682011-10-15 Martin Rudalics <rudalics@gmx.at>
369
370 * window.c (coordinates_in_window): Rewrite and delabelize
371 vertical border check. (Bug#5357) (Bug#9618)
372
6b02f655
SM
3732011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
374
375 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
376 errors in XSetWindowBorder (bug#9310).
377
81d40c92
DA
3782011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
379
380 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
381 avoid crash when xmalloc overrun checking is enabled.
382
d4172c3b
EZ
3832011-10-13 Eli Zaretskii <eliz@gnu.org>
384
385 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
386 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
387 cursor motion with <left> and <right> arrow keys.
388
389 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
390 some callers set that themselves.
391
b00eea75
EZ
3922011-10-12 Eli Zaretskii <eliz@gnu.org>
393
394 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
395 display string and the previous row comes from the same string and
396 is empty. (Bug#9739) (Bug#9738)
397
8fe012c4
SM
3982011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
399
400 * doc.c (get_doc_string): Encode file name (bug#9735).
401
0074aef2
EZ
4022011-10-12 Eli Zaretskii <eliz@gnu.org>
403
79beb178
EZ
404 * bidi.c (bidi_level_of_next_char):
405 * xdisp.c (get_visually_first_element): Remove old incorrect
406 comments regarding the Unicode Line Separator character.
407
0074aef2
EZ
408 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
409
6e4b3fbe
DA
4102011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
411
412 * alloc.c (Fgc_status): Do not access beyond zombies array
413 boundary if nzombies > MAX_ZOMBIES.
414 * alloc.c (dump_zombies): Add missing format specifier.
415
0324f3af
PE
4162011-10-12 Paul Eggert <eggert@cs.ucla.edu>
417
b5525cac
PE
418 * xdisp.c (set_cursor_from_row): Simplify conditionals,
419 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
420
0324f3af
PE
421 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
422 Some packages use them to denote characters with modifiers.
423
e9b5f888
AS
4242011-10-11 Andreas Schwab <schwab@linux-m68k.org>
425
426 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
427 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
428 matching a pp-number. Rename parameter var to var1.
429
127827c0
SM
4302011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
431
432 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
433
c8fd3bd0
GM
4342011-10-08 Glenn Morris <rgm@gnu.org>
435
436 * callint.c (Fcall_interactively): Give a more explicit error for the
437 'c' case with a non-character input. (Bug#8479)
438
352ec8ff
EZ
4392011-10-08 Eli Zaretskii <eliz@gnu.org>
440
03669ccb
EZ
441 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
442 lines.
7061c986
EZ
443 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
444 lines that are hscrolled on the left.
03669ccb 445
352ec8ff
EZ
446 * dispnew.c (buffer_posn_from_coords): Account for a possible
447 presence of header-line. (Bug#4426)
448
a66cfb1c
SM
4492011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
450
6b02f655
SM
451 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
452 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 453
7c5ee88e
PE
4542011-10-07 Paul Eggert <eggert@cs.ucla.edu>
455
456 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
457 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
458 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
459 this makes Emacs dump core during garbage collection on rare
460 occasions. sizeof is obviously inferior to offsetof here, so
461 stick with offsetof.
462 (GC_POINTER_ALIGNMENT): New macro.
463 (mark_memory): Omit 3rd (offset) arg; caller changed.
464 Don't assume EMACS_INT alignment is the same as pointer alignment.
465
df1bbe5b
SM
4662011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
467
468 * keyboard.c (read_key_sequence_remapped): New var.
469 (read_key_sequence): Compute remapping in the right buffer.
470 (command_loop_1): Use read_key_sequence's remapping directly.
471
51553db6
SM
4722011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
473
32c1fffd
SM
474 * dired.c (file_name_completion): Don't expand file name.
475 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
476 before checking file name handler.
477
51553db6
SM
478 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
479 they've been requested explicitly (bug#9591).
480
b6bd1599 4812011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
482
483 * keymap.c (Fsingle_key_description): Use make_specified_string
484 instead of build_string to build string from push_key_description.
485 (Bug#5193)
486
f701dc2a
PE
4872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
488
4222c55d
PE
489 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
490 This fixes a Y2038 bug on 64-bit hosts.
491 * buffer.c (reset_buffer):
492 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
493 (Fclear_buffer_auto_save_failure):
494 Use 0, not -1, to represent an unset failure time, since time_t
495 might not be signed.
496
f701dc2a
PE
497 Remove dependency on glibc malloc internals.
498 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
499 Move back here from lisp.h, but with their new implementations.
500 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
501 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
502 * charset.c (charset_table_init): New static var.
503 (syms_of_charset): Use it instead of xmalloc. This removes a
504 dependency on glibc malloc internals. See Eli Zaretskii's comment in
505 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
506 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
507 Move back to alloc.c.
508 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
509 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
510
9ceebf39
JD
5112011-09-30 Jan Djärv <jan.h.d@swipnet.se>
512
513 * nsterm.m (windowDidResize): Call x_set_window_size only when
514 ns_in_resize is true. Otherwise set pixelwidth/height and
515 call change_frame_size (Bug#9628).
516
cb993c58
PE
5172011-09-30 Paul Eggert <eggert@cs.ucla.edu>
518
3930c88b
PE
519 Port --enable-checking=all to Fedora 14 x86-64.
520 * charset.c (syms_of_charset): Also account for glibc malloc's
521 internal overhead when calculating the initial malloc maximum.
522
cb993c58
PE
523 Port --enable-checking=all to Fedora 14 x86.
524 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
525 Move to lisp.h.
526 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
527 (overrun_check_realloc, overrun_check_free):
528 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
529 That way, xmalloc returns a properly-aligned pointer even if
530 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
531 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
532 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
533 into account when calculating the initial malloc maximum.
534 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
535 Move here from alloc.c, so that charset.c can use it too.
536 Properly align; the old code wasn't right for common 32-bit hosts
537 when configured with --enable-checking=all.
538 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
539 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
540
31bed486
EZ
5412011-09-29 Eli Zaretskii <eliz@gnu.org>
542
04c70788 543 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
544 use EDOM.
545
fbcaa2f3
EZ
5462011-09-28 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (compute_display_string_end): If there's no display
549 string at CHARPOS, return -1.
550
551 * bidi.c (bidi_fetch_char): When compute_display_string_end
552 returns a negative value, treat the character as a normal
553 character not covered by a display string. (Bug#9624)
554
a239d4e9
JB
5552011-09-28 Juanma Barranquero <lekktu@gmail.com>
556
557 * lread.c (Fread_from_string): Fix typo in docstring.
558
88652fd5
EZ
5592011-09-27 Eli Zaretskii <eliz@gnu.org>
560
561 * xdisp.c (handle_invisible_prop): If invisible text ends on a
562 newline, reseat the iterator instead of bidi-iterating there one
563 character at a time. (Bug#9610)
32c1fffd
SM
564 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
565 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 566
ed497dd4
AS
5672011-09-27 Andreas Schwab <schwab@linux-m68k.org>
568
569 * lread.c (readevalloop): Use correct code for NBSP.
570 (read1): Likewise. (Bug#9608)
571
b2bf61aa
MA
5722011-09-25 Michael Albinus <michael.albinus@gmx.de>
573
574 * dbusbind.c (Fdbus_register_signal): When service is not
575 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
576
32bbb17c
GM
5772011-09-25 Glenn Morris <rgm@gnu.org>
578
579 * buffer.c (truncate-lines): Doc fix.
580
94e0933e
CY
5812011-09-24 Chong Yidong <cyd@stupidchicken.com>
582
583 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
584 (Fset_window_next_buffers): Doc fix.
585
cddde921
GM
5862011-09-24 Glenn Morris <rgm@gnu.org>
587
588 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
589
1260aef1
PE
5902011-09-24 Paul Eggert <eggert@cs.ucla.edu>
591
25b4bfa0
PE
592 Fix minor problems found by static checking.
593 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
594 * indent.c (Fvertical_motion): Fix == vs = typo.
595
e3cbd34b
EZ
5962011-09-24 Eli Zaretskii <eliz@gnu.org>
597
a66cfb1c
SM
598 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
599 Default value is now t. Doc fix.
6bf7006f 600
e3cbd34b 601 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 602 logic when moving up, not only when moving down. Fix the
e3cbd34b 603 confusing name and values of the it_overshoot_expected variable;
32c1fffd 604 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
605
606 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
607 CHARPOS is covered by a display string which includes newlines.
608 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
609 is covered by a display string with embedded newlines.
610
a3de0cbd
MA
6112011-09-24 Michael Albinus <michael.albinus@gmx.de>
612
613 * dbusbind.c (Fdbus_register_signal): Add match rule to
614 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
615 (Fdbus_register_method, Vdbus_registered_objects_table):
616 Fix docstring.
a3de0cbd 617
b260039d
JM
6182011-09-24 Jim Meyering <meyering@redhat.com>
619
32c1fffd 620 do not ignore write error for any output size
b260039d
JM
621 The previous change was incomplete.
622 While it makes emacs --batch detect the vast majority of stdout
623 write failures, errors were still ignored whenever the output size is
624 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
625 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
626 && echo FAIL: ignored write error
627 FAIL: ignored write error
628 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
629 && echo FAIL: ignored write error
630 FAIL: ignored write error
631 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
632
8eca8a7c
AS
6332011-09-23 Andreas Schwab <schwab@linux-m68k.org>
634
635 * emacs.c (Fkill_emacs): In noninteractive mode exit
636 non-successfully if a write error occurred on stdout. (Bug#9574)
637
3341db62
EZ
6382011-09-21 Eli Zaretskii <eliz@gnu.org>
639
640 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
641 the xassert test.
642
643 * dispextern.h (struct it): Update the comment documenting what
644 can it->OBJECT be.
645
8c203dbf
EZ
6462011-09-20 Eli Zaretskii <eliz@gnu.org>
647
648 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
649 a display string, extend search for cursor position to end of row.
650 (find_row_edges): If the row ends in a newline from a display
651 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
652 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
653 (Fcurrent_bidi_paragraph_direction): Fix search for previous
654 non-empty line. Fixes confusing cursor motion with arrow keys at
655 the beginning of a line that starts with whitespace.
8c203dbf 656
a4824228
LMI
6572011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
658
659 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
660 (bug#9493).
661
33ed493b
CY
6622011-09-18 Chong Yidong <cyd@stupidchicken.com>
663
664 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
665 boolean (Bug#9154).
666
56cd55c8
EZ
6672011-09-18 Eli Zaretskii <eliz@gnu.org>
668
669 * xdisp.c (display_line): Record maximum and minimum buffer
670 positions even if no glyphs were produced (e.g., by a zero-width
671 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
672 buffer positions that will be removed from the glyph row because
673 they don't fit.
c02dcedf
EZ
674 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
675 column is beyond frame width: don't subtract 1 "pixel" when
676 computing width of the stretch.
3e62b7e0
EZ
677 (reseat_at_next_visible_line_start): Undo the change made on
678 2011-09-17 that saved paragraph information and restored it after
679 the call to `reseat'. (Bug#9545)
56cd55c8 680
5ed99d36 6812011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
682
683 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
684 and turn window cursor on if cleared (Bug#9415).
685
5ed99d36 6862011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
687
688 * search.c (boyer_moore): Take unibyte characters from pattern
689 literally. (Bug#9458)
690
9bade7b2
EZ
6912011-09-18 Eli Zaretskii <eliz@gnu.org>
692
693 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
694
e5e9d610
PE
6952011-09-18 Paul Eggert <eggert@cs.ucla.edu>
696
87e4427a
PE
697 Fix minor problem found by static checking.
698 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
699 initialized, to pacify gcc -Wuninitialized.
700
e5e9d610
PE
701 * fileio.c: Report proper errno when syscall falls.
702 (Finsert_file_contents): Save and restore errno,
703 so that report_file_error outputs the correct diagnostic.
704 (Fwrite_region) [CLASH_DETECTION]: Likewise.
705
a1674f0b
EZ
7062011-09-18 Eli Zaretskii <eliz@gnu.org>
707
708 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
709
fbfb6dd4
EZ
7102011-09-17 Eli Zaretskii <eliz@gnu.org>
711
712 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
713 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
714
bb187662
EZ
7152011-09-17 Eli Zaretskii <eliz@gnu.org>
716
1137e8b8 717 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 718 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
719
720 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
721 (bidi_find_paragraph_start): Search back for paragraph beginning
722 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
723 (bidi_move_to_visually_next): Only trigger paragraph-related
724 computations when the last character is a newline or at EOB, not
725 just any NEUTRAL_B. (Bug#9470)
726
bb187662
EZ
727 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
728 truncated lines if point is covered by a display string. (Bug#9524)
729
2e621251
PE
7302011-09-16 Paul Eggert <eggert@cs.ucla.edu>
731
732 * xselect.c: Relax test for outgoing X longs (Bug#9498).
733 (cons_to_x_long): New function.
734 (lisp_data_to_selection_data): Use it. Correct the test for
735 short-versus-long data; it was negated. Break out of vector
736 loop, for efficiency, when a long datum is discovered.
737
91a15bc6
SM
7382011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
739
740 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
741
b41c3a35
EZ
7422011-09-16 Eli Zaretskii <eliz@gnu.org>
743
744 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
745 GCC PR/17406) by declaring this function with external scope.
746
7812ba2d
PE
7472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
748
749 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
750 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
751
cf7edc2a
AS
7522011-09-15 Andreas Schwab <schwab@linux-m68k.org>
753
754 * editfns.c (Fformat): Correctly handle text properties on "%%".
755
bd01620e
EZ
7562011-09-15 Eli Zaretskii <eliz@gnu.org>
757
758 * xterm.c (x_draw_composite_glyph_string_foreground):
759 * w32term.c (x_draw_composite_glyph_string_foreground):
760 * term.c (encode_terminal_code):
761 * composite.c (composition_update_it, get_composition_id):
762 * xdisp.c (get_next_display_element)
763 (fill_composite_glyph_string): Add comments about special meaning
764 of TAB characters in a composition.
765
a02719a3
PE
7662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
767
768 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
769 This occurs when processing a multibyte format.
770 Problem reported by Wolfgang Jenker.
a02719a3 771
72589a3c
JB
7722011-09-15 Johan Bockgård <bojohan@gnu.org>
773
774 * xdisp.c (try_cursor_movement): Only check for exact match if
775 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
776
1c14176c
PE
7772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
778
779 Remove unused external symbols.
780 * dispextern.h (calc_pixel_width_or_height): Remove decl.
781 * xdisp.c (calc_pixel_width_or_height): Now static.
782 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
783 * indent.c (check_display_width):
784 * w32term.c: Fix comment to match code.
785 * xterm.c, xterm.h (x_catching_errors): Remove.
786
d2eea5b5
PE
7872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
788
789 * xselect.c: Use signed conversions more consistently (Bug#9498).
790 (selection_data_to_lisp_data): Assume incoming selection data are
791 signed integers, not unsigned. This is to be consistent with
792 outgoing selection data, which was modified to use signed integers
793 in as part of the fix to Bug#9196 in response to Jan D.'s comment
794 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
795 expects long, not unsigned long.
796
46888499
EZ
7972011-09-14 Eli Zaretskii <eliz@gnu.org>
798
799 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
800 computation of loop end. Reported by Johan Bockgård
801 <bojohan@gnu.org>.
802
ef8ef9fb
CY
8032011-09-13 Chong Yidong <cyd@stupidchicken.com>
804
805 * frame.c (Fother_visible_frames_p): Function deleted.
806
fa819fed
EZ
8072011-09-12 Eli Zaretskii <eliz@gnu.org>
808
809 * indent.c (compute_motion): Process display vector front to back
810 rather than the other way around. (Bug#2496)
811
2ba8e008
SM
8122011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
813
814 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
815
20f53c69
CY
8162011-09-11 Chong Yidong <cyd@stupidchicken.com>
817
818 * minibuf.c (Fread_from_minibuffer): Doc fix.
819
d562d7a4
EZ
8202011-09-11 Eli Zaretskii <eliz@gnu.org>
821
822 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
823 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
824
1c4d7f3d
LMI
8252011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
826
827 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
828 value for non-existent files.
829
b885bf36
EZ
8302011-09-11 Eli Zaretskii <eliz@gnu.org>
831
832 * fileio.c (Finsert_file_contents): If the file cannot be opened,
833 set its "size" to -1. This will set the modtime_size field of
834 the corresponding buffer to -1, which is what
835 verify-visited-file-modtime expects for files that do not exist.
836 (Bug#9139)
837
6612f0bf
PE
8382011-09-11 Paul Eggert <eggert@cs.ucla.edu>
839
840 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
841 here ...
842 * lisp.h: ... from here. push_key_description is no longer
843 defined in keyboard.c, so its declaration should not be in
844 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
845 logically belongs with push_key_description.
846
dfb3f755
PE
8472011-09-10 Paul Eggert <eggert@cs.ucla.edu>
848
849 * buffer.h: Include <sys/types.h> instead of <time.h>.
850 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
851 Problem reported by Herbert J. Skuhra.
852
3134906c
LMI
8532011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
854
855 * xml.c (parse_region): Make the parsing work for
856 non-comment-starting XML files again (bug#9144).
857
8d903f4e
AS
8582011-09-10 Andreas Schwab <schwab@linux-m68k.org>
859
860 * image.c (gif_load): Fix calculation of bottom and right corner.
861 (Bug#9468)
862
80ad64f4
EZ
8632011-09-10 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
866 redisplay in small windows.
867
208a048d
EZ
8682011-09-09 Eli Zaretskii <eliz@gnu.org>
869
870 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
871
9b1c252e
MR
8722011-09-08 Martin Rudalics <rudalics@gmx.at>
873
874 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
875 Operate on live windows only.
876
2949f33b
JB
8772011-09-08 Juanma Barranquero <lekktu@gmail.com>
878
879 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
880
e08dcafd
EZ
8812011-09-07 Eli Zaretskii <eliz@gnu.org>
882
883 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
884 only under bidi iteration.
885
115b96bd
JD
8862011-09-07 Jan Djärv <jan.h.d@swipnet.se>
887
888 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
889
c8199d0f
PE
8902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
891
892 isnan: Fix porting problem to Solaris 10 with bundled gcc.
893 Without this fix, the command to link temacs failed due to an
894 undefined symbol __builtin_isnan. This is because
895 /usr/include/iso/math_c99.h #defines isnan(x) to
896 __builtin_isnan(x), but the bundled gcc, which identifies itself
897 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
898 a __builtin_isnan.
899 * floatfns.c (isnan): #undef, and then #define to a clone of
900 what's in data.c.
901 (Fisnan): Always define, since it's always available now.
902 (syms_of_floatfns): Always define isnan at the Lisp level.
903
e39b275c 9042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
905
906 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
907
b2db44d9 9082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 909
f4af5137 910 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
911 The previous code assumed that file offsets (off_t values) fit in
912 EMACS_INT variables, which is not true on typical 32-bit hosts.
913 The code messed up by falsely reporting buffer overflow in cases
914 such as (insert-file-contents "big" nil 1 2) into an empty buffer
915 when "big" contains more than 2**29 bytes, even though this
916 inserts just one byte and does not overflow the buffer.
917 (Finsert_file_contents): Store file offsets as off_t
918 values, not as EMACS_INT values. Check for overflow when
919 converting between EMACS_INT and off_t. When checking for
920 buffer overflow or for overlap, take the offsets into account.
921 Don't use EMACS_INT for small values where int suffices.
922 When checking for overlap, fix a typo: ZV was used where
923 ZV_BYTE was intended.
924 (Fwrite_region): Don't assume off_t fits into 'long'.
925 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
926
ecfc0a49
MA
9272011-09-05 Michael Albinus <michael.albinus@gmx.de>
928
929 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
930
6511acf2 9312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 932
0999621a 933 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
934
935 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 936 (esprintf, exprintf, evxprintf): New functions.
62f19c19 937 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 938 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
939 (modify_event_symbol): Do not assume that the length of
940 name_alist_or_stem is safe to alloca and fits in int.
941 (Fexecute_extended_command): Likewise for function name and binding.
942 (Frecursion_depth): Wrap around reliably on integer overflow.
943 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
944 since some callers pass EMACS_INT values.
945 (Fsingle_key_description): Don't crash if symbol name contains more
946 than MAX_ALLOCA bytes.
947 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
948 (get_minibuffer): Arg is now EMACS_INT, not int.
949 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 950 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
951 * window.h (command_loop_level, minibuf_level): Reflect API changes.
952
2be7d702
PE
953 * dbusbind.c (signature_cat): New function.
954 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
955 Do not overrun buffer; instead, report string overflow.
956
9d1df220
PE
957 * dispnew.c (add_window_display_history): Don't overrun buffer.
958 Truncate instead; this is OK since it's just a log.
959
33ef5c64
PE
960 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
961 even if the time zone offset is outlandishly large.
962 Don't mishandle offset == INT_MIN.
963
66c6fdd5
PE
964 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
965 when creating daemon; the previous buffer-overflow check was incorrect.
966
d749b01b
PE
967 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
968 which has the guts of the old verror function.
969
b5cd1905
PE
970 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
971 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
972
6e1a67fb
PE
973 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
974 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 975 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 976 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
977 length of string rather than counting it via multiple sprintfs;
978 that's simpler and more reliable.
c21721cc
PE
979 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
980 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
981 sprintf, in case result does not fit in int.
982
c57b67fc
PE
983 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
984 (fontset_from_font): Print it.
985
8a401434
PE
986 * frame.c (tty_frame_count): Now printmax_t, not int.
987 (make_terminal_frame, set_term_frame_name): Print it.
988 (x_report_frame_params): In X, window IDs are unsigned long,
989 not signed long, so print them as unsigned.
990 (validate_x_resource_name): Check for implausibly long names,
991 and don't assume name length fits in 'int'.
992 (x_get_resource_string): Don't blindly alloca invocation name;
993 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
994 not fit in int.
995
6e1a67fb
PE
996 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
997 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
998 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
999
0df02bf3
PE
1000 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1001 Use esprintf, not sprintf, in case result does not fit in int.
1002
48e30793
PE
1003 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1004 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1005 it as a large positive number.
1006 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1007 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1008
a66ff6d8
PE
1009 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1010 in case result does not fit in int.
1011
aca216ff
PE
1012 * print.c (float_to_string): Detect width overflow more reliably.
1013 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1014 buffer overrun. Don't assume list length fits in 'int'. Treat
1015 print length of 0 as 0, not as infinity; to be consistent with other
1016 uses of print length in this function. Don't overflow print length
1017 index. Don't assume hash table size fits in 'long', or that
1018 vectorlike size fits in 'unsigned long'.
1019
31c286f7
PE
1020 * process.c (make_process): Use printmax_t, not int, to format
1021 process-name gensyms.
1022
55e5faa1
PE
1023 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1024
80f2e268
PE
1025 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1026 to avoid potential buffer overrun.
1027
670741ab
PE
1028 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1029 if X resource line is longer than 512 bytes.
1030
b7163a50
PE
1031 * xfns.c (x_window): Make sprintf buffer a bit bigger
1032 to avoid potential buffer overrun.
1033
ae58ff1f
PE
1034 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1035
c43c8a6a
PE
1036 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1037
3f8236f4
PE
10382011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1039
53e9fe90 1040 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1041 Without these, Emacs silently mishandles large integers sometimes.
1042 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1043 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1044
6511acf2
PE
1045 * xdisp.c (try_window_id): Check Emacs fixnum range before
1046 converting to 'int'.
806add1d 1047
6511acf2 1048 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1049 Check that an Emacs fixnum is in range before assigning it to 'int'.
1050 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1051 values converted from Emacs fixnums.
1052 (Frecenter): Don't wrap around a line count if it is out of 'int'
1053 range; instead, treat it as an extreme value.
1054 (Fset_window_configuration, compare_window_configurations):
1055 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1056
6511acf2
PE
1057 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1058 that can exceed INT_MAX. Check that EMACS_INT value is in range
1059 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1060 (match_limit): Don't assume that a fixnum can fit in 'int'.
1061
6511acf2 1062 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1063 exceed INT_MAX.
1064
6511acf2 1065 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1066 (Fvertical_motion): Don't wrap around LINES values that don't fit
1067 in 'int'. Instead, treat them as extreme values. This is good
1068 enough for windows, which can't have more than INT_MAX lines anyway.
1069
fcb901a7
LMI
10702011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1071
0f2f6b6d
LMI
1072 * Require libxml/parser.h to avoid compilation warning.
1073
fcb901a7
LMI
1074 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1075
1076 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1077 since this reportedly can destroy thread storage.
1078
6e20a0d4
CY
10792011-08-30 Chong Yidong <cyd@stupidchicken.com>
1080
1081 * syntax.c (find_defun_start): Update all cache variables if
1082 exiting early (Bug#9401).
1083
148ae00e
EZ
10842011-08-30 Eli Zaretskii <eliz@gnu.org>
1085
f6cfbd8f
EZ
1086 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1087
148ae00e
EZ
1088 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1089 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1090 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1091
1092 * term.c (tty_append_glyph): New function.
1093 (produce_stretch_glyph): Static function and its prototype deleted.
1094
a66cfb1c
SM
1095 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1096 Add prototypes.
148ae00e 1097
c4a07a4c
PE
10982011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1101 when checking :margin (Bug#9390).
1102 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1103 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1104 so that the name doesn't mislead. All uses changed.
1105
6bc8cd65
JB
11062011-08-28 Johan Bockgård <bojohan@gnu.org>
1107
1108 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1109 set_tty_hooks.
1110
dca4927e
EZ
11112011-08-27 Eli Zaretskii <eliz@gnu.org>
1112
1113 * xdisp.c (move_it_to): Don't bail out early when reaching
1114 position beyond to_charpos, if we are scanning backwards.
1115 (move_it_vertically_backward): When DY == 0, make sure we get to
1116 the first character in the line after the newline.
1117
f2cad773
PE
11182011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1121 (ccl_driver): Do not generate an out-of-range pointer.
1122 (Fccl_execute_on_string): Remove unnecessary check for
1123 integer overflow, noted by Stefan Monnier in
1124 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1125 Remove a FIXME that didn't need fixing.
1126 Simplify the newly-introduced buffer reallocation code.
1127
0cae2cdb
JB
11282011-08-27 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1131
5fc295a4 11322011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1133
70c60eb2 1134 Integer and memory overflow issues (Bug#9196).
726e0ab1 1135
d31850da
PE
1136 * doc.c (get_doc_string): Rework so that
1137 get_doc_string_buffer_size is the actual buffer size, rather than
1138 being 1 less than the actual buffer size; this makes xpalloc more
1139 convenient.
1140
a69fbedb
PE
1141 * image.c (x_allocate_bitmap_record, cache_image):
1142 * xselect.c (Fx_register_dnd_atom):
1143 Simplify previous changes by using xpalloc.
1144
fe5c5d37
PE
1145 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1146 since either will do and ptrdiff_t is convenient with xpalloc.
1147
0065d054
PE
1148 * charset.c (charset_table_size)
1149 (struct charset_sort_data.priority): Now ptrdiff_t.
1150 (charset_compare): Don't overflow if priorities differ greatly.
1151 (Fsort_charsets): Don't assume list length fits in int.
1152 Check for size-calculation overflow when allocating sort data.
1153 (syms_of_charset): Allocate an initial charset table that is
1154 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1155
1156 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1157
1158 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1159 The actual value is always <= INT_MAX, and leaving it unsigned made
1160 overflow checking harder.
1161
1162 * dispextern.h (struct glyph_matrix.rows_allocated)
1163 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1164 with xpalloc. The values are still always <= INT_MAX.
1165
1166 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1167
1168 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1169 (SAFE_NALLOCA): New macro.
1170
1171 * region-cache.c (struct boundary.pos, find_cache_boundary)
1172 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1173 (set_cache_region, invalidate_region_cache)
1174 (revalidate_region_cache, know_region_cache, region_cache_forward)
1175 (region_cache_backward, pp_cache):
1176 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1177 so that ptrdiff_t * can be passed to xpalloc.
1178 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1179 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1180 (pp_cache): Don't assume cache_len fits in int.
1181 * region-cache.h: Adjust extern decls to match.
1182
1183 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1184 EMACS_INT, since either will do, for xpalloc.
1185
1186 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1187 (xnmalloc, xnrealloc, xpalloc): New functions.
1188
726e0ab1
PE
1189 * bidi.c (bidi_shelve_header_size): New constant.
1190 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1191 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1192
51f30bc5 1193 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1194 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1195 (overlay_strings):
1196 Don't update size of array until after memory allocation succeeds,
1197 because xmalloc/xrealloc may not return.
0065d054
PE
1198 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1199 now that we have proper integer overflow checking.
1200 (record_overlay_string, overlay_strings): Catch overflows when
1201 calculating size of overlay_str_buf.
726e0ab1 1202
0065d054
PE
1203 * callproc.c (Fcall_process): Check for size overflow when
1204 calculating size of args2.
1205 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1206 Normally we prefer signed values, but sticking with ptrdiff_t would
1207 require adding more-complicated checks.
726e0ab1
PE
1208
1209 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1210 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1211 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1212 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1213
1214 * character.c (Fstring): Check for size-calculation overflow.
1215
1216 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1217 unnecessary integer overflow. Check for size overflow.
1218 (encode_coding_object): Don't update size until xmalloc succeeds.
1219
1220 * composite.c (get_composition_id): Check for overflow in glyph
1221 length calculations.
1222
1223 Integer and memory overflow fixes for display code.
1224 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1225 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1226 (scrolling_window): Check for overflow in size calculations.
1227 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1228 Don't assume glyph table len fits in int.
1229 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1230 (row_table_size): Now ptrdiff_t, not int.
1231 (scrolling_window): Avoid overflow in size calculations.
1232 Don't update size until allocation succeeds.
1233 * fns.c (concat): Check for overflow in size calculations.
1234 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1235 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1236 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1237
1238 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1239 (get_doc_string): Check for size calculation overflow.
1240 Don't update size until allocation succeeds.
1241 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1242 EMACS_INT, where ptrdiff_t will do.
1243 (Fsubstitute_command_keys): Check for string overflow.
1244
1245 * editfns.c (set_time_zone_rule): Don't assume environment length
1246 fits in int.
1247 (message_length): Now ptrdiff_t, not int.
1248 (Fmessage_box): Don't update size until allocation succeeds.
1249 Don't assume message length fits in int.
1250 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1251
0065d054
PE
1252 * emacs.c (main): Do not reallocate argv, since there is a null at
1253 the end that can be overwritten, and this way there's no need to
1254 worry about size-calculation overflow.
1255 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1256
1257 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1258 alloc succeeds.
1259 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1260
1261 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1262 (x_set_scroll_bar_width, x_figure_window_size):
1263 Check for integer overflow.
1264 (x_set_alpha): Do not assume XINT fits in int.
1265
1266 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1267 This is for the members text_lines, text_cols, total_lines, total_cols,
1268 where the system imposes an 'int' limit.
1269
1270 * fringe.c (Fdefine_fringe_bitmap):
1271 Don't update size until alloc works.
1272
1273 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1274 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1275
1276 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1277 Check for size-calculation overflow.
1278 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1279 do, as we prefer signed integers.
1280 (id_to_widget.max_size, id_to_widget.used)
1281 (xg_store_widget_in_map, xg_remove_widget_from_map)
1282 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1283 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1284 Use and return ptrdiff_t, not int.
1285 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1286 * gtkutil.h: Change prototypes to match the above.
1287
1288 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1289 are duplicate now that they've been promoted to lisp.h.
1290 (x_allocate_bitmap_record, x_alloc_image_color)
1291 (make_image_cache, cache_image, xpm_load):
1292 Don't update size until alloc is done.
1293 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1294 (x_detect_edges):
3256efce 1295 Check for size calculation overflow.
726e0ab1
PE
1296 (ct_colors_allocated_max): New constant.
1297 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1298 overflow.
3256efce 1299
726e0ab1
PE
1300 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1301 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1302 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1303 Use ptrdiff_t, not int, to count maps.
1304 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1305 calculations. Don't update size until allocation succeeds.
1306 Redo calculations to avoid overflow.
726e0ab1
PE
1307 * keyboard.h: Change prototypes to match the above.
1308
1309 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1310 to count maps.
1311 (current_minor_maps): Check for size calculation overflow.
1312 * keymap.h: Change prototypes to match the above.
1313
1314 * lread.c (read1, init_obarray): Don't update size until alloc done.
1315
1316 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1317 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1318
726e0ab1
PE
1319 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1320 Now ptrdiff_t, not int.
1321 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1322 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1323
1324 * process.c (Fnetwork_interface_list): Check for overflow
1325 in size calculation.
1326
1327 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1328
1329 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1330 overflow. Don't bother calling xmalloc when xrealloc will do.
1331
1332 * search.c (Freplace_match): Check for size calculation overflow.
1333 (Fset_match_data): Don't assume list lengths fit in 'int'.
1334
1335 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1336 for command line length. Do not attempt to address one before the
1337 beginning of an array, as that's not portable.
1338
1339 * term.c (max_frame_lines): Remove; unused.
1340 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1341 not int.
1342 (encode_terminal_code, calculate_costs): Check for size
1343 calculation overflow.
1344 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1345 table lengths and related sizes. Don't update size until alloc
1346 done. Redo calculations to avoid overflow.
1347 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1348
1349 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1350 subtracting pointers.
1351 (gobble_line): Check for overflow more carefully. Don't update size
1352 until alloc done.
1353
1354 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1355 Don't update size until alloc done.
1356 Redo size calculations to avoid overflow.
1357 Check for size calculation overflow.
0065d054 1358 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1359
1360 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1361 Use ptrdiff_t, not int, for sizes.
1362 (store_mode_line_noprop_char): Don't update size until alloc done.
1363
0065d054
PE
1364 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1365 Use ptrdiff_t, not int, for sizes.
1366 (Finternal_make_lisp_face, cache_face):
1367 Check for size calculation overflow.
1368 (cache_face): Treat size calculation overflows as if they were
1369 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1370
1371 * xfns.c (x_encode_text, x_set_name_internal)
1372 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1373 sizes, since they can exceed INT_MAX in size. Check for size
1374 calculation overflow.
1375
0065d054
PE
1376 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1377 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1378 Don't update size until alloc done.
1379
0065d054 1380 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1381 as sprintf is limited to int lengths.
1d526e2f 1382
252c5ee1
PE
1383 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1384 (X_LONG_MIN): New macros.
864d7ce7
PE
1385 Use them to make the following changes clearer.
1386 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1387 This change doesn't affect the value now, but it may help remind
1388 future maintainers not to raise the value too much later.
1389 (SELECTION_QUANTUM): Remove, replacing with ...
1390 (selection_quantum): ... new function, which avoids overflow.
1391 All uses changed.
1392 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1393 assumption that selection length fits in 'int'.
1394 (x_reply_selection_request, x_handle_selection_request)
1395 (x_get_window_property, receive_incremental_selection)
1396 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1397 (lisp_data_to_selection_data, clean_local_selection_data):
1398 Use ptrdiff_t, not int, to record length of selection.
1399 (x_reply_selection_request, x_get_window_property)
1400 (receive_incremental_selection, x_property_data_to_lisp):
1401 Redo calculations to avoid overflow.
1402 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1403 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1404 something.
1405 (x_get_window_property, receive_incremental_selection)
1406 (lisp_data_to_selection_data, x_property_data_to_lisp):
1407 Check for size-calculation overflow.
1408 (x_get_window_property, receive_incremental_selection)
1409 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1410 Don't store size until memory allocation succeeds.
1411 (x_get_window_property): Plug memory leak on memory exhaustion.
1412 Don't double-block input; malloc is safe here. Don't assume 2**34
1413 - 4 fits in unsigned long. Add an xassert to check
1414 XGetWindowProperty overflow. Be more careful about overflow
1415 calculations, and distinguish size from memory overflow better.
1416 (receive_incremental_selection): When tracing, don't assume
1417 unsigned int is less than INT_MAX.
1418 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1419 harmful) conversions of unsigned short to int.
1420 (lisp_data_to_selection_data): Don't assume that integers
1421 in the range -65535 through -1 fit in an X unsigned short.
1422 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1423 result parameters unless successful. Rely on cons_to_unsigned
1424 to report problems with elements; the old code wasn't right anyway.
1425 (x_check_property_data): Check for int overflow; we cannot use
1426 a wider type due to X limits.
1427 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1428
726e0ab1 1429 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1430
0065d054
PE
1431 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1432 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1433 (x_color_cells): Don't store size until memory allocation succeeds.
1434 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1435 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1436 (x_term_init): Don't assume length fits in int (sprintf is limited
1437 to int size).
bc18e09d 1438
ebfa62c0
PE
1439 Use ptrdiff_t for composition IDs.
1440 * character.c (lisp_string_width):
1441 * composite.c (composition_table_size, n_compositions)
1442 (get_composition_id, composition_gstring_from_id):
1443 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1444 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1445 * window.c (Frecenter):
1446 Use ptrdiff_t, not int, for composition IDs.
1447 * composite.c (get_composition_id): Check for integer overflow.
1448 * composite.h: Adjust prototypes to match the above changes.
1449
d3411f89
PE
1450 Use ptrdiff_t for hash table indexes.
1451 * category.c (hash_get_category_set):
1452 * ccl.c (ccl_driver):
1453 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1454 * coding.c (coding_system_charset_list, detect_coding_system):
1455 * coding.h (struct coding_system.id):
1456 * composite.c (get_composition_id, gstring_lookup_cache):
1457 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1458 * image.c (xpm_get_color_table_h):
1459 * lisp.h (hash_lookup, hash_put):
1460 * minibuf.c (Ftest_completion):
1461 Use ptrdiff_t for hash table indexes, not int (which is too
1462 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1463 32-bit --with-wide-int hosts).
1464
e097a6fa
PE
1465 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1466 Add a FIXME comment about memory leaks.
1467 (syms_of_charset): Don't assume xmalloc returns.
1468
5637687f
PE
1469 Don't assume that stated character widths fit in int.
1470 * character.c (Fchar_width, c_string_width, lisp_string_width):
1471 * character.h (CHAR_WIDTH):
1472 * indent.c (MULTIBYTE_BYTES_WIDTH):
1473 Use sanitize_char_width to avoid undefined and/or bad behavior
1474 with outlandish widths.
a66cfb1c 1475 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1476 now that we have two such functions. All uses changed.
1477 (sanitize_char_width): New inline function.
1478
a2271ba2
PE
1479 Don't assume that tab-width fits in int.
1480 * character.h (sanitize_width): New inline function.
1481 (SANE_TAB_WIDTH): New macro.
1482 (ASCII_CHAR_WIDTH): Use it.
1483 * indent.c (sane_tab_width): Remove. All uses replaced by
1484 SANE_TAB_WIDTH (current_buffer).
1485 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1486
18c52557
PE
1487 * fileio.c: Integer overflow issues with file modes.
1488 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1489
caeeedc1
PE
1490 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1491 Remove unreachable code.
1492 (read_hex, load_charset_map_from_file): Check for integer overflow.
1493
50849c52
PE
1494 * xterm.c: don't go over XClientMessageEvent limit
1495 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1496 (x_send_scroll_bar_event): Likewise. Check that the size does not
1497 exceed limits imposed by XClientMessageEvent, as well as the usual
1498 ptrdiff_t and size_t limits.
1499
b13995db
PE
1500 * keyboard.c: Overflow, signedness and related fixes.
1501 (make_lispy_movement): Use same integer type in forward decl
1502 that is used in the definition.
1503 (read_key_sequence, keyremap_step):
1504 Change bufsize argument back to int, undoing my 2011-03-30 change.
1505 We prefer signed types, and int is wide enough here.
1506 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1507 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1508 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1509 length, not size_t. Use ptrdiff_t for index, not int.
1510 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1511 possibility of integer overflow.
1512
13464394
PE
1513 Overflow, signedness and related fixes for images.
1514
1515 * dispextern.h (struct it.stack[0].u.image.image_id)
1516 (struct_it.image_id, struct image.id, struct image_cache.size)
1517 (struct image_cache.used, struct image_cache.ref_count):
1518 * gtkutil.c (update_frame_tool_bar):
1519 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1520 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1521 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1522 * nsmenu.m (update_frame_tool_bar):
1523 * xdisp.c (calc_pixel_width_or_height):
1524 * xfns.c (image_cache_refcount):
1525 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1526 on typical 64-bit hosts.
1527
1528 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1529 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1530 Omit unnecessary casts to int.
1531 (parse_image_spec): Check that integers fall into 'int' range
1532 when the callers expect that.
1533 (image_ascent): Redo ascent calculation to avoid int overflow.
1534 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1535 (lookup_image): Remove unnecessary tests.
1536 (xbm_image_p): Locals are now of int, not EMACS_INT,
1537 since parse_image_check makes sure they fit into int.
1538 (png_load, gif_load, svg_load_image):
1539 Prefer int to unsigned where either will do.
1540 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1541 old tiff_error_handler and tiff_warning_handler.
1542 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1543 stack buffer overflows. It uses only the features of vsnprintf
1544 that are common to both POSIX and native Microsoft.
1545 (tiff_error_handler, tiff_warning_handler): Use it.
1546 (tiff_load, gif_load, imagemagick_load_image):
1547 Don't assume :index value fits in 'int'.
1548 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1549 (imagemagick_load_image): Check that crop parameters fit into
1550 the integer types that MagickCropImage accepts. Don't assume
1551 Vimagemagick_render_type has a nonnegative value. Don't assume
1552 size_t fits in 'long'.
1553 (gs_load): Use printmax_t to print the widest integers possible.
1554 Check for integer overflow when computing image height and width.
1555
c11821d4
EZ
15562011-08-26 Eli Zaretskii <eliz@gnu.org>
1557
1558 * xdisp.c (redisplay_window): Don't force window start if point
1559 will be invisible in the resulting window. (Bug#9324)
1560
0c95fcf7
EZ
15612011-08-25 Eli Zaretskii <eliz@gnu.org>
1562
1563 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1564 the display spec is of the form `(space ...)'.
1565 (handle_display_spec): Return the value returned by
1566 handle_single_display_spec, not just 1 or zero.
1567 (handle_single_display_spec): If the display spec is of the form
1568 `(space ...)', and specifies display in the text area, return 2
1569 rather than 1.
fee65a97 1570 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1571 accurately, and prefer exact match for point under bidi.
1572 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1573
1574 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1575 into disp_prop; all users changed.
1576
1577 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1578 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1579 for the text covered by the display property.
1580
e4ed06f1
CY
15812011-08-25 Chong Yidong <cyd@stupidchicken.com>
1582
1583 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1584 Change return value to nil.
1585 (Frecord_buffer): Delete unused function.
1586
f67cdd7f
EZ
15872011-08-24 Eli Zaretskii <eliz@gnu.org>
1588
5980d4c6
EZ
1589 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1590 buffers, return left-to-right.
8610fe8b
EZ
1591 (set_cursor_from_row): Consider candidate row a win if its glyph
1592 represents a newline and point is on that newline. Fixes cursor
1593 positioning on the newline at EOL of R2L text within L2R
1594 paragraph, and vice versa.
1595 (try_cursor_movement): Check continued rows, in addition to
1596 continuation rows. Fixes unwarranted scroll when point enters a
1597 continued line of R2L text within an L2R paragraph, or vice versa.
1598 (cursor_row_p): Consider the case of point being equal to
1599 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1600 from the end of a short line to the beginning of a continued line
1601 of R2L text within L2R paragraph.
1602 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1603 composed characters.
5980d4c6 1604
f67cdd7f
EZ
1605 * bidi.c (bidi_check_type): Use xassert.
1606 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1607 members.
1608
bca633fb
EZ
16092011-08-23 Eli Zaretskii <eliz@gnu.org>
1610
1611 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1612 a character.
1613
4a5885a7
CY
16142011-08-23 Chong Yidong <cyd@stupidchicken.com>
1615
1616 * nsfont.m (ns_otf_to_script): Fix typo.
1617
0902a04e
KH
16182011-08-22 Kenichi Handa <handa@m17n.org>
1619
1620 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1621 extra slot even if the purpose is char-code-property-table.
1622
1a2e6670
EZ
16232011-08-23 Eli Zaretskii <eliz@gnu.org>
1624
8ddde651
EZ
1625 * xdisp.c (redisplay_window): When computing centering_position,
1626 account for the height of the header line. (Bug#8874)
1627
425cc014
EZ
1628 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1629 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1630 candidate is selected by the mouse, and that candidate has a
1631 composed character under the mouse.
1632
1a2e6670
EZ
1633 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1634 coordinates reported by pos-visible-in-window-p for a composed
1635 character in column zero.
1636
8b76d6f8
SM
16372011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1640
dac347dd
EZ
16412011-08-22 Eli Zaretskii <eliz@gnu.org>
1642
1643 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1644 consider it a hit if to_charpos is anywhere in the range of the
1645 composed buffer positions.
1646
e013fb34
CY
16472011-08-22 Chong Yidong <cyd@stupidchicken.com>
1648
1649 * image.c (gif_load): Don't assume that each subimage has the same
1650 dimensions as the base image. Handle disposal method that is
1651 "undefined" by the gif spec (Bug#9335).
1652
bd1ba3e8
CY
16532011-08-20 Chong Yidong <cyd@stupidchicken.com>
1654
1655 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1656 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1657
54a1215b
EZ
16582011-08-19 Eli Zaretskii <eliz@gnu.org>
1659
823564e5
EZ
1660 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1661 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1662 from an Org mode buffer to a Speedbar frame.
1663
54a1215b
EZ
1664 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1665 a composition, take its buffer position from IT->cmp_it.charpos.
1666 Fixes cursor positioning at the beginning of a line that begins
1667 with a composed character.
1668
9778ebcc
EZ
16692011-08-18 Eli Zaretskii <eliz@gnu.org>
1670
0be6ee06
EZ
1671 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1672 character bidirectional type, use STRONG_L instead. Fixes crashes
1673 in a buffer produced by `describe-categories'.
1674
9778ebcc
EZ
1675 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1676 members before the level stack, so they would be saved and
1677 restored when copying iterator state. Fixes incorrect reordering
1678 around TABs covered by display properties.
1679
156bffbe
AS
16802011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1681
6b02f655 1682 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1683
72ad093b
CY
16842011-08-17 Chong Yidong <cyd@stupidchicken.com>
1685
1686 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1687 (internal_condition_case_2, internal_condition_case_n):
1688 Remove unnecessary aborts (Bug#9081).
72ad093b 1689
35774242
EZ
16902011-08-17 Eli Zaretskii <eliz@gnu.org>
1691
1692 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1693 has no `load' handler, try opening the file locally. (Bug#9311)
1694
db76dd85
KB
16952011-08-16 Ken Brown <kbrown@cornell.edu>
1696
1697 * gmalloc.c: Expand comment.
1698
b215eee5
EZ
16992011-08-16 Eli Zaretskii <eliz@gnu.org>
1700
1701 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1702 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1703
a4579d33
KB
17042011-08-16 Ken Brown <kbrown@cornell.edu>
1705
1706 Fix memory allocation problems in Cygwin build (Bug#9273).
1707
1708 * unexcw.c ( __malloc_initialized): Declare external variable.
1709 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1710
8b76d6f8
SM
1711 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1712 New variables.
a4579d33
KB
1713 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1714 dumped emacs.
1715 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1716 in the static heap.
1717 [CYGWIN] (special_realloc): New function.
1718 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1719 requests to realloc storage in the static heap.
1720
3ebec551
PE
17212011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1722
1723 * bidi.c (bidi_initialize): Remove unused local.
1724
9fd8be00
EZ
17252011-08-15 Eli Zaretskii <eliz@gnu.org>
1726
6b02f655
SM
1727 * bidimirror.h:
1728 * biditype.h: Remove file.
1729 * makefile.w32-in ($(BLD)/bidi.$(O)):
1730 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1731
1732 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1733
1734 * chartab.c: Improve commentary for the uniprop_table API.
1735
32413314
EZ
1736 * bidi.c (bidi_paragraph_init): Support zero value of
1737 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1738 (bidi_initialize): Use uniprop_table instead of including
1739 biditype.h and bidimirror.h.
32413314 1740
9fd8be00
EZ
1741 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1742 coordinates of the iterator when restoring from ppos_it.
1743 (Bug#9296)
1744
5cf2b69b
KH
17452011-08-14 Kenichi Handa <handa@m17n.org>
1746
1747 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1748 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1749
daf17d00
EZ
17502011-08-14 Eli Zaretskii <eliz@gnu.org>
1751
1752 * xdisp.c (move_it_in_display_line_to): Don't invoke
1753 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1754 ppos_it. Fixes vertical cursor motion when line beginning is
1755 covered by an image. (Bug#9296)
1756
08e3161a
JD
17572011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1758
1759 * nsterm.h (ns_run_ascript): Declare.
1760 (NSAPP_DATA2_RUNASSCRIPT): Define.
1761
1762 * nsfns.m (as_script, as_result, as_status): New static variables.
1763 (ns_run_ascript): New function.
5e617bc2 1764 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1765 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1766 the event loop. Get status from as_status (Bug#7276).
1767
1768 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1769 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1770 the event loop (Bug#7276).
1771
a3720aa2
AS
17722011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1773
1774 * gnutls.c (QCgnutls_bootprop_priority)
1775 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1776 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1777 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1778 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1779 (QCgnutls_bootprop_verify_hostname_error)
1780 (QCgnutls_bootprop_callbacks_verify): Rename from
1781 Qgnutls_bootprop_..., all uses changed.
1782
1783 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1784 uses changed.
1785
0a0d27fb
PE
17862011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1787
19d5c50c
PE
1788 * xfaces.c (Qframe_set_background_mode): Now static.
1789 * dispextern.h (Qframe_set_background_mode): Remove decl.
1790
0a0d27fb
PE
1791 * process.c (Fnetwork_interface_info): Declare local only if needed.
1792
377538cb
JD
17932011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1794
1795 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1796 (Fnetwork_interface_list): Allocate in increments of bytes instead
1797 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1798 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1799 sockaddr.
1800 (struct ifflag_def): notrailers is smart on OSX.
1801 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1802 Get hardware address with getifaddrs if available.
1803
08fff70c
EZ
18042011-08-12 Eli Zaretskii <eliz@gnu.org>
1805
1806 * xdisp.c (iterate_out_of_display_property): xassert that
1807 IT->position is set to within IT->object's boundaries. Break from
1808 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1809 when IT->position is set up wrongly due to some bug.
1810 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1811 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1812 entry. Force push_it to save on the stack the current
1813 buffer/string position, to be restored by pop_it. Fix flags in
1814 the iterator structure wrt the object coming from a display
1815 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1816 properties. (Bug#9284)
1817
7be1c708 18182011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1819
7be1c708
CY
1820 * fontset.c (fontset_get_font_group): Add proper type checks.
1821 (Bug#9172)
aac0c6e3 1822
7be1c708 18232011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1824
7be1c708
CY
1825 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1826 and LC_VERSION_MIN_MACOSX.
1827 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1828 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1829
97bb72a6
EZ
18302011-08-08 Eli Zaretskii <eliz@gnu.org>
1831
1832 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1833 no-display-properties-and-no-overlays under bidi display.
1834 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1835 properties and overlays.
97bb72a6 1836
d5617611
CY
18372011-08-08 Chong Yidong <cyd@stupidchicken.com>
1838
37e11a63
CY
1839 * editfns.c (Fset_time_zone_rule): Document relationship with the
1840 setenv function.
1841
d5617611
CY
1842 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1843 the font entity extracted from the cache (Bug#8109).
1844
58872834
CY
18452011-08-07 Chong Yidong <cyd@stupidchicken.com>
1846
1847 * composite.c (autocmp_chars): Don't reset point. That is done by
1848 restore_point_unwind (Bug#5984).
1849
75bfc667
JL
18502011-08-07 Juri Linkov <juri@jurta.org>
1851
1852 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1853 to show the arg `TIME' instead of `TIMEVAL'.
1854
d1410150
EZ
18552011-08-06 Eli Zaretskii <eliz@gnu.org>
1856
1857 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1858 display property strides EOL and includes a newline, as in
1859 longlines-mode. (Bug#9254)
75b771e4
EZ
1860 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1861 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1862
1863 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1864 is non-zero, even if the data buffer is NULL. Fixes a crash in
1865 vertical-motion with longlines-mode. (Bug#9254)
1866
35928349
EZ
18672011-08-05 Eli Zaretskii <eliz@gnu.org>
1868
ec7cc85b
EZ
1869 * bidi.c <bidi_cache_total_alloc>: Now static.
1870 (bidi_initialize): Initialize bidi_cache_total_alloc.
1871
8b76d6f8 1872 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1873 cache. (Bug#9221)
1874
1875 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1876 amount allocated this far in `bidi_cache_total_alloc'.
1877 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1878 non-zero, only free the data buffer without restoring the cache
1879 contents. All callers changed.
1880
1881 * dispextern.h (bidi_unshelve_cache): Update prototype.
1882
1883 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1884 (move_it_in_display_line, move_it_to)
1885 (move_it_vertically_backward, move_it_by_lines): Replace the call
1886 to xfree to an equivalent call to bidi_unshelve_cache.
1887 (move_it_in_display_line_to): Fix logic of returning
412b6358 1888 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1889
e2e2423b
EZ
18902011-08-05 Eli Zaretskii <eliz@gnu.org>
1891
1892 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1893 came from a string character with a `cursor' property. (Bug#9229)
1894
ae9e757a
JD
18952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1896
1897 * Makefile.in (LIB_PTHREAD): New variable.
1898 (LIBES): Add LIB_PTHREAD (Bug#9216).
1899
1900 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1901 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1902
213bd7f2
AS
19032011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1904
6b02f655 1905 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1906
99aaf75f
JD
19072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1908
1909 * xterm.c (x_find_topmost_parent): New function.
1910 (x_set_frame_alpha): Find topmost parent window with
1911 x_find_topmost_parent and set the property there also (bug#9181).
1912 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1913
c74e9d86
PE
19142011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1915
1916 * callproc.c (Fcall_process): Avoid vfork clobbering
1917 the local vars buffer, coding_systems, current_dir.
1918
640c8776
SM
19192011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1920
1921 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1922
f26d0e4c
PE
19232011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1924
8a10d76c
PE
1925 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1926 so that it is not optimized away.
1927
f26d0e4c
PE
1928 * xdisp.c (compute_display_string_pos): Remove unused local.
1929
55439c61
EZ
19302011-08-02 Eli Zaretskii <eliz@gnu.org>
1931
1932 Fix slow cursor motion and scrolling in large buffers with
1933 selective display, like Org Mode buffers. (Bug#9218)
1934
1935 * dispextern.h (struct bidi_it): New member disp_prop_p.
1936
1937 * xdisp.c: Remove one-slot cache of display string positions.
1938 (compute_display_string_pos): Accept an additional argument
5e617bc2 1939 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1940 for a display string or property. If found, set DISP_PROP_P
1941 non-zero.
1942
1943 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1944 DISP_PROP_P, and pass it to compute_display_string_pos.
1945 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1946 non-zero. All callers of bidi_fetch_char changed.
1947
fb33fa43
SM
19482011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1949
1950 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1951
b099e063
DM
19522010-12-03 Don March <don@ohspite.net>
1953
1954 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1955 last character M-[char] is translated to ESC [char] (bug#7541).
1956
5cc7f7af
KH
19572011-08-02 Kenichi Handa <handa@m17n.org>
1958
d0fffa3f 1959 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1960
1961 * chartab.c (uniprop_table): Make it non-static.
1962
525d5e6e
EZ
19632011-08-01 Eli Zaretskii <eliz@gnu.org>
1964
1965 * xdisp.c (forward_to_next_line_start): Accept additional argument
1966 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1967 on the newline.
1968 (reseat_at_next_visible_line_start): Use the bidi iterator state
1969 returned by forward_to_next_line_start to restore the state of
1970 it->bidi_it after backing up to previous newline. (Bug#9212)
1971
31011111
AS
19722011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1973
1974 * regex.c (re_comp): Protoize.
1975 (re_exec): Fix return type.
1976 (regexec): Fix type of `ret'. (Bug#9203)
1977
476371c4
PE
19782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1979
e5d76069
PE
1980 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1981 This is needed if max-image-size is a floating-point number.
1982
9a79b20c
AS
19832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1984
1985 * print.c (print_object): Print empty symbol as ##.
1986
1987 * lread.c (read1): Read ## as empty symbol.
1988
d8c2fa78
AA
19892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1990
1991 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1992 setting frame foreground color (Bug#9175).
1993 (x_set_background_color): Likewise.
1994
ffe57a7a
AA
1995 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1996 contents (Bug#9176).
1997 (EmacsTooltip -init): Remove bezels and add shadows to
1998 tooltip windows.
1999
bf3492a5
AA
2000 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2001 or scroll bar (Bug#8470).
2002
d55e9c53
AA
2003 * nsfont.m (nsfont_open): Remove assignment to voffset and
2004 unnecessary vars hshink, expand, hd, full_height, min_height.
2005 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2006
2007 * nsterm.h (nsfont_info): Remove voffset field.
2008
d8c2fa78 20092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2010
2011 Implement strike-through and overline on NextStep (Bug#8863).
2012
2013 * nsfont.m (nsfont_open): Use underline position provided by font,
2014 instead of hard-coded value of 2.
2015 (nsfont_draw): Call ns_draw_text_decoration instead.
2016
2017 * nsterm.h: Add declaration for ns_draw_text_decoration.
2018
2019 * nsterm.m (ns_draw_text_decoration): New function for drawing
2020 underline, overline, and strike-through.
2021 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2022 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2023 accommodate underlining, etc.
4843aac3 2024
4cc60b9b
EZ
20252011-07-28 Eli Zaretskii <eliz@gnu.org>
2026
bc7ece87
EZ
2027 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2028 default.
4cc60b9b 2029
476371c4
PE
20302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2031
66606eea
PE
2032 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2033 Without this fix, if a signal arrives just after memory fills up,
2034 'malloc' might be invoked reentrantly.
2035
476371c4
PE
2036 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2037 In other words, assume that every image size is allowed, on non-X
2038 hosts. This assumption is probably wrong, but it lets Emacs compile.
2039
f3fcc40d
AS
20402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2041
2042 * regex.c (re_iswctype): Convert return values to boolean.
2043
350c992f
EZ
20442011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2045
2046 * xdisp.c (compute_display_string_pos): Don't use cached display
2047 string position if the buffer had its restriction changed.
2048 (Bug#9184)
2049
5266b4bb
PE
20502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2053
2573a837 20542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2055
41f55ccd 2056 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2057
39e378da
PE
2058 * bidi.c: Integer size and overflow fixes.
2059 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2060 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2061 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2062 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2063 (bidi_find_other_level_edge):
2064 Use ptrdiff_t instead of EMACS_INT where either will do.
2065 This works better on 32-bit hosts configured --with-wide-int.
2066 (bidi_cache_ensure_space): Check for size-calculation overflow.
2067 Use % rather than repeated addition, for better worst-case speed.
2068 Don't set bidi_cache_size until after xrealloc returns, because it
2069 might not return.
2070 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2071 (bidi_cache_ensure_space): Also check that the bidi cache size
2072 does not exceed that of the largest Lisp string or buffer. See Eli
2073 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2074
5e927815
PE
2075 * alloc.c (__malloc_size_t): Remove.
2076 All uses replaced by size_t. See Andreas Schwab's note
2077 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2078
ca4aa935
PE
2079 * image.c: Improve checking for integer overflow.
2080 (check_image_size): Assume that f is nonnull, since
2081 it is always nonnull in practice. This is one less thing to
2082 worry about when checking for integer overflow later.
2083 (x_check_image_size): New function, which checks for integer
2084 overflow issues inside X.
2085 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2086 This removes the need for a memory_full check.
2087 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2088 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2089 (xbm_read_bitmap_data): Change locals back to 'int', since
2090 their values must fit in 'int'.
2091 (xpm_load_image, png_load, tiff_load):
2092 Invoke x_create_x_image_and_pixmap earlier,
2093 to avoid much needless work if the image is too large.
2094 (tiff_load): Treat overly large images as if
2095 x_create_x_image_and_pixmap failed, not as malloc failures.
2096 (gs_load): Use x_check_image_size.
2097
5f8f9cc2
PE
2098 * gtkutil.c: Omit integer casts.
2099 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2100 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2101
5adf60bc
PE
2102 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2103
c8907a93
PE
2104 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2105 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2106 would wrongly return t on a 64-bit host.
2107
e3c25c68
PE
2108 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2109 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2110 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2111 and therefore cause GCC to emit a bogus diagnostic in some cases.
2112
3f791afe
PE
2113 * image.c: Integer signedness and overflow and related fixes.
2114 This is not an exhaustive set of fixes, but it's time to
2115 record what I've got.
2116 (lookup_pixel_color, check_image_size): Remove redundant decls.
2117 (check_image_size): Don't assume that arbitrary EMACS_INT values
2118 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2119 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2120 (tiff_load, imagemagick_load_image):
2121 Check for overflow in size calculations.
2122 (x_create_x_image_and_pixmap): Remove unnecessary test for
2123 xmalloc returning NULL; that can't happen.
2124 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2125 (xpm_color_bucket): Use better integer hashing function.
2126 (xpm_cache_color): Don't possibly over-allocate memory.
2127 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2128 (gif_memory_source):
2129 Use ptrdiff_t, not int or size_t, to record sizes.
2130 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2131 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2132 either works, as we prefer signed integers.
2133 (tiff_read_from_memory, tiff_write_from_memory):
2134 Return tsize_t, not size_t, since that's what the TIFF API wants.
2135 (tiff_read_from_memory): Don't fail simply because the read would
2136 go past EOF; instead, return a short read.
2137 (tiff_load): Omit no-longer-needed casts.
2138 (Fimagemagick_types): Don't assume size fits into 'int'.
2139
3cc5a532
PE
2140 Improve hashing quality when configured --with-wide-int.
2141 * fns.c (hash_string): New function, taken from sxhash_string.
2142 Do not discard information about ASCII character case; this
2143 discarding is no longer needed.
2144 (sxhash-string): Use it. Change sig to match it. Caller changed.
2145 * lisp.h: Declare it.
2146 * lread.c (hash_string): Remove, since we now use fns.c's version.
2147 The fns.c version returns a wider integer if --with-wide-int is
2148 specified, so this should help the quality of the hashing a bit.
2149
b312a492
PE
2150 * emacs.c: Integer overflow minor fix.
2151 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2152 Define only if GNU_LINUX.
2153 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2154
dfd153ae
PE
2155 * dispnew.c: Integer signedness and overflow fixes.
2156 Remove unnecessary forward decls, that were a maintenance hassle.
2157 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2158 All uses changed.
2159 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2160 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2161 (prepare_desired_row, line_draw_cost):
2162 Use int, not unsigned, where either works.
2163 (save_current_matrix, restore_current_matrix):
2164 Use ptrdiff_t, not size_t, where either works.
2165 (init_display): Check for overflow more accurately, and without
2166 relying on undefined behavior.
2167
a81d11a3
PE
2168 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2169 Remove, replacing with the new symbols in lisp.h. All uses changed.
2170 * fileio.c (make_temp_name):
2171 * filelock.c (lock_file_1, lock_file):
2172 * xdisp.c (message_dolog):
2173 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2174 Use pMd etc. instead.
2175 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2176 replacing the pWIDE etc. symbols removed from editfns.c.
2177
3300e6fd
PE
2178 * keyboard.h (num_input_events): Now uintmax_t.
2179 This is (very slightly) less likely to mess up due to wraparound.
2180 All uses changed.
2181
fd05c7e9
PE
2182 * buffer.c: Integer signedness fixes.
2183 (alloc_buffer_text, enlarge_buffer_text):
2184 Use ptrdiff_t rather than size_t when either will do, as we prefer
2185 signed integers.
2186
903fe15d
PE
2187 * alloc.c: Integer signedness and overflow fixes.
2188 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2189 (__malloc_size_t): Default to size_t, not to int.
2190 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2191 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2192 Prefer ptrdiff_t to size_t when either would do, as we prefer
2193 signed integers.
2194 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2195 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2196 Now const. Initialize with values that are in range even if char
2197 is signed.
2198 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2199 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2200 These functions do the right thing with sizes > 2**32.
2201 (check_depth): Now ptrdiff_t, not int.
2202 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2203 Adjust to new way of storing sizes. Check for size overflow bugs
2204 in rest of code.
2205 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2206 slightly wrong anyway, as it missed one instance of
2207 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2208 (refill_memory_reserve): Omit needless cast to size_t.
2209 (mark_object_loop_halt): Mark as externally visible.
2210
ac82cc6a
PE
2211 * xselect.c: Integer signedness and overflow fixes.
2212 (Fx_register_dnd_atom, x_handle_dnd_message):
2213 Use ptrdiff_t, not size_t, since we prefer signed.
2214 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2215 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2216 x_dnd_atoms_size and x_dnd_atoms_length.
2217
c2d1e36d
PE
2218 * doprnt.c: Prefer signed to unsigned when either works.
2219 * eval.c (verror):
2220 * doprnt.c (doprnt):
2221 * lisp.h (doprnt):
2222 * xdisp.c (vmessage):
2223 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2224 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2225 prefer signed arithmetic to avoid comparison confusion.
2226 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2227 but is a bit tricky.
2228
0e926e56
PE
2229 Assume freestanding C89 headers, string.h, stdlib.h.
2230 * data.c, doprnt.c, floatfns.c, print.c:
2231 Include float.h unconditionally.
2232 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2233 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2234 * regex.c: Likewise for stddef.h, string.h.
2235 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2236 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2237 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2238 (STDC_HEADERS): Remove obsolete defines.
2239 * sysdep.c: Include limits.h unconditionally.
2240
9cfdb3ec
PE
2241 Assume support for memcmp, memcpy, memmove, memset.
2242 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2243 * regex.c (memcmp, memcpy):
2244 Remove; we assume C89 now.
2245
2246 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2247 (__malloc_safe_bcopy): Remove; no longer needed.
2248
cf950e6b 2249 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2250 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2251 well either way, and we prefer signed to unsigned.
2252
dbf38e02
LMI
22532011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2254
2255 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2256 closes the connection while we're reading (bug#9182).
2257
d6f0886c 22582011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2259
d6f0886c
JD
2260 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2261 are specified (Bug#9168).
24e0f6b1 2262
2eb1f9e6
PE
22632011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2266 Found by GCC static checking and --with-wide-int on a 32-bit host.
2267
22381272 22682011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2269
2270 * xdisp.c (compute_display_string_pos): Fix logic of caching
2271 previous display string position. Initialize cached_prev_pos to
2272 -1. Fixes slow-down at the beginning of a buffer.
2273
f25e39b4
EZ
22742011-07-24 Eli Zaretskii <eliz@gnu.org>
2275
2276 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2277 for attrs[LFACE_FONTSET_INDEX].
2278
04c4b52e
PE
22792011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 * xml.c (parse_region): Remove unused local
2282 that was recently introduced.
2283
c1734fbd
EZ
22842011-07-23 Eli Zaretskii <eliz@gnu.org>
2285
be18c5a5
EZ
2286 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2287 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2288
c1734fbd
EZ
2289 * xdisp.c (move_it_in_display_line_to): Record the best matching
2290 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2291 exit if none of the characters scanned was an exact match.
2292 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2293 when exact match is impossible due to invisible text, and the
2294 lines are truncated.
2295
a258d627
JD
22962011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2297
2298 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2299 for OSX >= 10.7.
2300
b6d5a689
EZ
23012011-07-22 Eli Zaretskii <eliz@gnu.org>
2302
0f74f785
EZ
2303 Fix a significant slow-down of cursor motion with C-n, C-p,
2304 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2305 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2306 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2307 (next_element_from_buffer): Call compute_stop_pos_backwards to
2308 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2309 base_level_stop.
2310 (reseat): Don't look for prev_stop, as that could mean a very long
2311 run.
2312 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2313 <cached_disp_overlay_modiff>: Cache for last found display string
2314 position.
551918c1 2315 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2316 about the same buffer in the same area of character positions, and
2317 the buffer wasn't changed since the time the display string
2318 position was cached.
551918c1 2319
b2d0c91a
EZ
23202011-07-22 Eli Zaretskii <eliz@gnu.org>
2321
2322 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2323 is an integer, which is important for empty lines. (Bug#9149)
2324
043604ee
CY
23252011-07-22 Chong Yidong <cyd@stupidchicken.com>
2326
2327 * frame.c (Fmodify_frame_parameters): In tty case, update the
2328 default face if necessary (Bug#4238).
2329
da4adb04
CY
23302011-07-21 Chong Yidong <cyd@stupidchicken.com>
2331
2332 * editfns.c (Fstring_to_char): No need to explain what a character
2333 is in the docstring (Bug#6576).
2334
9abd0532
LMI
23352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2336
2337 * xml.c (parse_region): Make sure we always return a tree.
2338
36881d16
HK
23392011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2340
2341 * xml.c (parse_region): If a document contains only comments,
2342 return that, too.
2343
1e98674d
LMI
23442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2345
2346 * xml.c (make_dom): Return comments, too.
2347
590bd467
PE
23482011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2349
2350 Port to OpenBSD.
2351 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2352 and the surrounding thread.
2353 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2354 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2355 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2356 timer goes off.
2357 * s/openbsd.h (BROKEN_SIGIO): Define.
2358 * unexelf.c (unexec) [__OpenBSD__]:
2359 Don't update the .mdebug section of the Alpha COFF symbol table.
2360
f41628b2
LMI
23612011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2362
2363 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2364 (bug#8460).
2365
b59b67c5
PE
23662011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2367
15e3a074
PE
2368 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2369 This fixes some race conditions on the permissions of any newly
2370 created file.
2371
41bed37d
PE
2372 * alloc.c (valid_pointer_p): Use pipe, not open.
2373 This fixes some permissions issues when debugging.
2374
b59b67c5
PE
2375 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2376 If fchown fails to set both uid and gid, try to set just gid,
2377 as that is sometimes allowed. Adjust the file's mode to eliminate
2378 setuid or setgid bits that are inappropriate if fchown fails.
2379
925a6be7
SM
23802011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2381
2382 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2383 to compare Lisp_Objects.
2384 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2385 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2386 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2387
52968808
AS
23882011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2389
0a6a104b
AS
2390 * lread.c (read_integer): Unread even EOF character.
2391 (read1): Likewise. Properly record start position of symbol.
2392
52968808
AS
2393 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2394 symbol character follows.
2395
9e381cdd
PE
23962011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2397
2398 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2399 This works around a problem with the previous change to Fcopy_file.
2400 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2401 and without this change, GCC might complain about discarding
2402 fchown's return value.
2403
b5641435
JB
24042011-07-16 Juanma Barranquero <lekktu@gmail.com>
2405
2406 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2407
a8031457
PE
24082011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2411
dd889327
LMI
24122011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2413
750c33f7
LMI
2414 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2415 it's used from the C level.
2416
dd889327
LMI
2417 * process.c: Use the same condition for POLL_FOR_INPUT in both
2418 keyboard.c and process.c (bug#1858).
2419
87e86684
LM
24202011-07-09 Lawrence Mitchell <wence@gmx.li>
2421
2422 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2423 (Fgnutls_boot): Use it.
2424
64348f40
AS
24252011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2426
2427 * doc.c (Fsubstitute_command_keys): Revert last change.
2428
1d698799
LMI
24292011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2430
f863868c
LMI
2431 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2432 quotes the next character, and doesn't affect other longer
2433 sequences (bug#8935).
2434
1d698799
LMI
2435 * lread.c (syms_of_lread): Clarify that is isn't only
2436 `eval-buffer' and `eval-defun' that's affected by
2437 `lexical-binding' (bug#8460).
2438
aa4b6df6
EZ
24392011-07-15 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2442 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2443
5d856da6
PE
24442011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2445
ad6042bb
PE
2446 Fix minor problems found by static checking.
2447 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2448 (elsz): Now a signed constant, not a size_t var. We prefer signed
2449 types to unsigned, to avoid integer comparison confusion. Without
2450 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2451 "cannot optimize loop, the loop counter may overflow", a symptom
2452 of the confusion.
f00bbb22 2453 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2454 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2455
6468f31c
LMI
24562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2457
49080b10
LMI
2458 * search.c (Fre_search_backward): Mention `case-fold-search' in
2459 all the re_search_* functions (bug#8138).
2460
6468f31c
LMI
2461 * keyboard.c (Fopen_dribble_file): Document when the file is
2462 closed (bug#8056).
2463
c965adc5
EZ
24642011-07-14 Eli Zaretskii <eliz@gnu.org>
2465
df9733bf
EZ
2466 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2467 bidi_cache_idx.
2468
0bb23927
EZ
2469 Support bidi reordering of display and overlay strings.
2470 * xdisp.c (compute_display_string_pos)
2471 (compute_display_string_end): Accept additional argument STRING.
2472 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2473 (reseat_to_string): Initialize bidi_it->string.s and
2474 bidi_it->string.schars.
2475 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2476 NULL (avoids a crash in bidi_paragraph_init).
2477 Initialize itb.string.lstring.
0bb23927
EZ
2478 (init_iterator): Call bidi_init_it only of a valid
2479 buffer position was specified. Initialize paragraph_embedding to
2480 L2R.
2481 (reseat_to_string): Initialize the bidi iterator.
2482 (display_string): If we need to ignore text properties of
2483 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2484 original value of -1 will not work with bidi.)
2485 (compute_display_string_pos): First arg is now struct
2486 `text_pos *'; all callers changed. Support display properties on
2487 Lisp strings.
2488 (compute_display_string_end): Support display properties on Lisp
2489 strings.
2490 (init_iterator, reseat_1, reseat_to_string): Initialize the
2491 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2492 when iterating on a string not from display properties).
640c8776
SM
2493 (compute_display_string_pos, compute_display_string_end):
2494 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2495 arrow keys.
2496 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2497 base_level_stop; instead, set base_level_stop to BEGV.
2498 Fixes crashes in vertical-motion.
0bb23927
EZ
2499 (next_element_from_buffer): Improve commentary for when
2500 the iterator is before prev_stop.
2501 (init_iterator): Initialize bidi_p from the default value of
2502 bidi-display-reordering, not from buffer-local value. Use the
2503 buffer-local value only if initializing for buffer iteration.
2504 (handle_invisible_prop): Support invisible properties on strings
2505 that are being bidi-reordered.
2506 (set_iterator_to_next): Support bidi reordering of C strings and
2507 Lisp strings.
2508 (next_element_from_string): Support bidi reordering of Lisp
2509 strings.
2510 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2511 (display_string): Support display of R2L glyph rows.
2512 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2513 (init_iterator): Don't initialize it->bidi_p for strings
2514 here.
2515 (reseat_to_string): Initialize it->bidi_p for strings here.
2516 (next_element_from_string, next_element_from_c_string)
2517 (next_element_from_buffer): Add xassert's for correspondence
2518 between IT's object being iterated and it->bidi_it.string
2519 structure.
2520 (face_before_or_after_it_pos): Support bidi iteration.
2521 (next_element_from_c_string): Handle the case of the first string
2522 character that is not the first one in the visual order.
2523 (get_visually_first_element): New function, refactored from common
2524 parts of next_element_from_buffer, next_element_from_string, and
2525 next_element_from_c_string.
2526 (tool_bar_lines_needed, redisplay_tool_bar)
2527 (display_menu_bar): Force left-to-right direction. Add a FIXME
2528 comment for making that be controlled by a user option.
2529 (push_it, pop_it): Save and restore the state of the
2530 bidi iterator. Save and restore the bidi_p flag.
2531 (pop_it): Iterate out of display property for string iteration as
2532 well.
2533 (iterate_out_of_display_property): Support iteration over strings.
2534 (handle_single_display_spec): Set up it->bidi_it for iteration
2535 over a display string, and call bidi_init_it.
2536 (handle_single_display_spec, next_overlay_string)
2537 (get_overlay_strings_1, push_display_prop): Set up the bidi
2538 iterator for displaying display or overlay strings.
2539 (forward_to_next_line_start): Don't use the shortcut if
2540 bidi-iterating.
2541 (back_to_previous_visible_line_start): If handle_display_prop
2542 pushed the iterator stack, restore the internal state of the bidi
2543 iterator by calling bidi_pop_it same number of times.
2544 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2545 and we are bidi-iterating, don't decrement the iterator position;
2546 instead, set the first_elt flag in the bidi iterator, to produce
2547 the same effect.
2548 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2549 (push_display_prop): xassert that we are iterating a buffer.
2550 (push_it, pop_it): Save and restore paragraph_embedding member.
2551 (handle_single_display_spec, next_overlay_string)
2552 (get_overlay_strings_1, reseat_1, reseat_to_string)
2553 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2554 correctly. Don't assume unibyte strings are not bidi-reordered.
2555 (compute_display_string_pos)
2556 (compute_display_string_end): Fix handling the case of C string.
2557 (push_it, pop_it): Save and restore from_disp_prop_p.
2558 (handle_single_display_spec, push_display_prop): Set the
2559 from_disp_prop_p flag.
2560 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2561 (pop_it): Call iterate_out_of_display_property only if we are
2562 popping after iteration over a string that came from a display
2563 property. Fix a typo in popping stretch info. Add an assertion
2564 for verifying that the iterator position is in sync with the bidi
2565 iterator.
2566 (handle_single_display_spec, get_overlay_strings_1)
2567 (push_display_prop): Fix initialization of paragraph direction for
2568 string when that of the parent object is not yet determined.
2569 (reseat_1): Call bidi_init_it to resync the bidi
2570 iterator with IT's position. (Bug#7616)
2571 (find_row_edges): If ROW->start.pos gives position
2572 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2573 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2574 Reset the from_disp_prop_p flag.
2575 (SAVE_IT, RESTORE_IT): New macros.
2576 (pos_visible_p, face_before_or_after_it_pos)
2577 (back_to_previous_visible_line_start)
2578 (move_it_in_display_line_to, move_it_in_display_line)
2579 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2580 (try_scrolling, redisplay_window, display_line): Use them when
2581 saving a temporary copy of the iterator and restoring it back.
2582 (back_to_previous_visible_line_start, reseat_1)
2583 (init_iterator): Empty the bidi cache "stack".
2584 (move_it_in_display_line_to): If iterator ended up at
2585 EOL, but we never saw any buffer positions smaller than
2586 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2587 motion in bidi-reordered lines.
2588 (move_it_in_display_line_to): Record prev_method and prev_pos
2589 immediately before the call to set_iterator_to_next. Fixes cursor
2590 motion in bidi-reordered lines with stretch glyphs and strings
2591 displayed in margins. (Bug#8133) (Bug#8867)
2592 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2593 TO_CHARPOS.
640c8776
SM
2594 (pos_visible_p): Support positions in bidi-reordered lines.
2595 Save and restore bidi cache.
0bb23927
EZ
2596
2597 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2598 (bidi_paragraph_info): Delete unused struct.
2599 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2600 (bidi_cache_start): New variable.
2601 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2602 to zero.
2603 (bidi_cache_fetch_state, bidi_cache_search)
2604 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2605 (bidi_cache_find, bidi_peek_at_next_level)
2606 (bidi_level_of_next_char, bidi_find_other_level_edge)
2607 (bidi_move_to_visually_next): Compare cache index with
2608 bidi_cache_start rather than with zero.
2609 (bidi_fetch_char): Accept new argument STRING; all callers
2610 changed. Support iteration over a string. Support strings with
2611 display properties. Support unibyte strings. Fix the type of
2612 `len' according to what STRING_CHAR_AND_LENGTH expects.
2613 (bidi_paragraph_init, bidi_resolve_explicit_1)
2614 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2615 (bidi_level_of_next_char, bidi_move_to_visually_next):
2616 Support iteration over a string.
0bb23927
EZ
2617 (bidi_set_sor_type, bidi_resolve_explicit_1)
2618 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2619 can now be zero (for strings); special values 0 and -1 were
2620 changed to -1 and -2, respectively.
2621 (bidi_char_at_pos): New function.
2622 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2623 Call it instead of FETCH_MULTIBYTE_CHAR.
2624 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2625 initialized to valid values.
2626 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2627 values.
2628 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2629 the test for valid cached positions. Fix the logic for looking up
2630 the sentinel state in the cache. GCPRO the Lisp string we are
2631 iterating.
2632 (bidi_push_it, bidi_pop_it): New functions.
2633 (bidi_initialize): Initialize the bidi cache start stack pointer.
2634 (bidi_cache_ensure_space): New function, refactored from part of
2635 bidi_cache_iterator_state. Don't assume the required size is just
2636 one BIDI_CACHE_CHUNK away.
2637 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2638 (bidi_count_bytes, bidi_char_at_pos): New functions.
2639 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2640 always valid if bidi_cache_idx is valid.
2641 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2642 is valid if it's going to be used.
2643 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2644 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2645 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2646 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2647 (bidi_find_other_level_edge, bidi_cache_start_stack):
2648 All variables related to cache indices are now EMACS_INT.
c965adc5 2649
0bb23927
EZ
2650 * dispextern.h (struct bidi_string_data): New structure.
2651 (struct bidi_it): New member `string'. Make flag members be 1-bit
2652 fields, and put them last in the struct.
640c8776
SM
2653 (compute_display_string_pos, compute_display_string_end):
2654 Update prototypes.
0bb23927
EZ
2655 (bidi_push_it, bidi_pop_it): Add prototypes.
2656 (struct iterator_stack_entry): New members bidi_p,
2657 paragraph_embedding, and from_disp_prop_p.
2658 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2659 (bidi_shelve_cache, bidi_unshelve_cache):
2660 Declare prototypes.
0bb23927
EZ
2661
2662 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2663 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2664 and vector-like objects.
2665
2666 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2667 cache around display iteration.
2668
2669 * window.c (Fwindow_end, window_scroll_pixel_based)
2670 (displayed_window_lines, Frecenter): Save and restore the bidi
2671 cache around display iteration.
2672
3bbd2265
LMI
26732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2674
2675 * editfns.c (Fdelete_region): Clarify the use of the named
2676 parameters (bug#6788).
2677
adc47434
MR
26782011-07-14 Martin Rudalics <rudalics@gmx.at>
2679
2680 * indent.c (Fvertical_motion): Set and restore w->pointm when
2681 saving and restoring the window's buffer (Bug#9006).
2682
837c31f8
LMI
26832011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2684
2685 * editfns.c (Fstring_to_char): Clarify just what is returned
2686 (bug#6576). Text by Eli Zaretskii.
2687
ac389d0c
JB
26882011-07-13 Juanma Barranquero <lekktu@gmail.com>
2689
2690 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2691
0be0ce47
EZ
26922011-07-13 Eli Zaretskii <eliz@gnu.org>
2693
2694 * buffer.c (mmap_find): Fix a typo.
2695
cd18e7e3
JB
26962011-07-13 Johan Bockgård <bojohan@gnu.org>
2697
2698 Fix execution of x selection hooks.
2699 * xselect.c (Qx_lost_selection_functions)
2700 (Qx_sent_selection_functions): New vars.
2701 (syms_of_xselect): DEFSYM them.
2702 (x_handle_selection_request): Pass Qx_sent_selection_functions
2703 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2704 (x_handle_selection_clear,x_clear_frame_selections):
2705 Pass Qx_lost_selection_functions rather than
2706 Vx_lost_selection_functions to Frun_hook_with_args.
2707
47ea7f44
PE
27082011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2709
ac389d0c 2710 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2711 The old code sometimes used this field without initializing it.
2712
47ea7f44
PE
2713 * alloc.c (gc_sweep): Don't read past end of array.
2714 In theory, the old code could also have corrupted Emacs internals,
2715 though it'd be very unlikely.
2716
bc985c87
AS
27172011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2718
2719 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2720 argument. (Bug#4026)
bc985c87 2721
0cf34688
LMI
27222011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2723
b3dadd76
LMI
2724 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2725 key" (bug#4257).
2726
0cf34688
LMI
2727 * window.c (Fset_window_start): Doc fix (bug#4199).
2728 (Fset_window_hscroll): Ditto.
2729
270768cd
PE
27302011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2731
077e3dda 2732 Fix minor new problems caught by GCC 4.6.1.
270768cd 2733 * term.c (init_tty): Remove unused local.
490011a6 2734 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2735 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2736 not used otherwise.
270768cd 2737
b1f58454
CY
27382011-07-12 Chong Yidong <cyd@stupidchicken.com>
2739
2740 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2741
22b9578d
LMI
27422011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2743
6e70ab07
LMI
2744 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2745 are the mini-buffer and the echo area (bug#3320).
2746
22b9578d
LMI
2747 * term.c (init_tty): Remove support for supdup, c10 and perq
2748 terminals, which are no longer supported (bug#1482).
2749
8974cc9f
JB
27502011-07-10 Johan Bockgård <bojohan@gnu.org>
2751
2752 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2753
a560d974
JD
27542011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2755
2756 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2757 for non-popups (Bug#3642).
2758
1dae0f0a
AS
27592011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2760
268c2c36 2761 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2762 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2763 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2764 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2765 * data.c (fmod): Likewise.
2766 * dispnew.c (swap_glyphs_in_rows): Likewise.
2767 * emacs.c (memory_warning_signal): Likewise.
2768 * floatfns.c (float_error): Likewise.
2769 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2770 (otf_open, font_otf_capability, generate_otf_features)
2771 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2772 Likewise.
2773 * image.c (pbm_read_file): Likewise.
2774 * indent.c (string_display_width): Likewise.
2775 * intervals.c (check_for_interval, search_for_interval)
2776 (inc_interval_count, count_intervals, root_interval)
2777 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2778 * lread.c (defalias): Likewise.
268c2c36 2779 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2780 * regex.c (set_image_of_range_1, set_image_of_range)
2781 (regex_grow_registers): Likewise.
2782 * sysdep.c (strerror): Likewise.
2783 * termcap.c (valid_filename_p, tprint, main): Likewise.
2784 * tparam.c (main): Likewise.
2785 * unexhp9k800.c (run_time_remap, save_data_space)
2786 (update_file_ptrs, read_header, write_header, calculate_checksum)
2787 (copy_file, copy_rest, display_header): Likewise.
2788 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2789 Likewise.
2790 * xdisp.c (check_it): Likewise.
2791 * xfaces.c (register_color, unregister_color, unregister_colors):
2792 Likewise.
2793 * xfns.c (print_fontset_result): Likewise.
2794 * xrdb.c (member, fatal, main): Likewise.
2795
99033785
PE
27962011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 Fix minor problems found by static checking (Bug#9031).
2799 * chartab.c (char_table_set_range, map_sub_char_table):
2800 Remove unused locals.
2801 (uniprop_table): Now static.
2802 * composite.c (_work_char): Remove unused static var.
2803
9cb2ac56
JB
28042011-07-09 Juanma Barranquero <lekktu@gmail.com>
2805
2806 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2807
f25661f0
JD
28082011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2809
2810 * gtkutil.c (qttip_cb): Remove code without function.
2811
8278c4fe
EZ
28122011-07-09 Eli Zaretskii <eliz@gnu.org>
2813
2814 * w32.c (pthread_sigmask): New stub.
2815
1692ae2d 28162011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2817
8a6ebd58 2818 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2819 sigprocmask is portable only for single-threaded applications, and
2820 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2821 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2822 (LIBES): Use it.
2823 * callproc.c (Fcall_process):
2824 * process.c (create_process):
2825 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2826 Use pthread_sigmask, not sigprocmask.
123403e4 2827
1b854618
JD
28282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2829
2830 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2831 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2832 wrong (Bug#8591).
2833
3fe4b549
JD
28342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2835
0ce7e563
JD
2836 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2837 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2838 (xg_hide_tooltip): Fix comment.
2839
3fe4b549
JD
2840 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2841 in registerServicesMenuSendTypes.
2842 (validRequestorForSendType): Don't check ns_return_types.
2843
2844 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2845 ns_return_type.
2846
5df75e47
JR
28472011-07-08 Jason Rumney <jasonr@gnu.org>
2848
22610910
JR
2849 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2850 SH_SHOW for hidden windows (Bug#5482).
2851
5df75e47
JR
2852 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2853 frame struct members of non-existent frames (Bug#6284).
2854
699c10bd
JD
28552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2856
4393663b
JD
2857 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2858 variable firstTime not needed on OSX >= 10.6.
2859 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2860 >= 10.5. Use setKnobProportion, setDoubleValue.
2861
2862 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2863 (MAC_OS_X_VERSION_10_5): Define if not defined.
2864 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2865 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2866 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2867
2868 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2869 cString and lossyCString on OSX >= 10.4
2870
2871 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2872 sizeToFit on OSX >= 10.2.
2873
2874 * nsimage.m (allocInitFromFile): Don't use deprecated method
2875 bestRepresentationForDevice on OSX >= 10.6.
2876
2877 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2878 to avoid warning.
2879
2880 * emacs.c: Declare unexec_init_emacs_zone.
2881
a63e0781
JD
2882 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2883
699c10bd
JD
2884 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2885
2886 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2887 on svcsMenu (Bug#8842).
2888
2889 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2890 ns_return_types.
2891 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2892
2893 * nsterm.m (QUTF8_STRING): Declare.
2894 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2895 (validRequestorForSendType): Return type is (id).
2896 Change indexOfObjectIdenticalTo to indexOfObject.
2897 Check if we have local selection before returning self (Bug#8842).
2898 (writeSelectionToPasteboard): Put local selection into paste board
2899 if we have a local selection (Bug#8842).
2900 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2901
2902 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2903 (ns_get_local_selection): Declare.
2904
54e10184
LMI
29052011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2906
9888ff71
LMI
2907 * keymap.c (describe_map_tree): Don't insert a double newline at
2908 the end of the buffer (bug#1169) and return whether we inserted
2909 something.
2910
54e10184
LMI
2911 * callint.c (Fcall_interactively): Change "reading args" to
2912 "providing args" to try to clarify what it does (bug#1010).
2913
15fa4783
KH
29142011-07-07 Kenichi Handa <handa@m17n.org>
2915
2916 * composite.c (composition_compute_stop_pos): Ignore a static
2917 composition starting before CHARPOS (Bug#8915).
2918
2919 * xdisp.c (handle_composition_prop): Likewise.
2920
a8815b00
EZ
29212011-07-07 Eli Zaretskii <eliz@gnu.org>
2922
2923 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2924 (Bug#9015)
2925
ef7b981d 29262011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2927
2928 * character.h (unicode_category_t): New enum type.
2929
2930 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2931 (Qchar_code_property_table): New variable.
2932 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2933 (UNIPROP_COMPRESSED_FORM_P): New macros.
2934 (char_table_ascii): Uncompress the compressed values.
2935 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2936 Uncompress the compressed values.
ac389d0c 2937 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2938 (char_table_ref_and_range): Uncompress the compressed values.
2939 (sub_char_table_set): New arg is_uniprop. Callers changed.
2940 Uncompress the compressed values.
2941 (sub_char_table_set_range): Args changed. Callers changed.
2942 (char_table_set_range): Adjuted for the above change.
2943 (map_sub_char_table): Delete args default_val and parent. Add arg
2944 top. Give decoded values to a Lisp function.
640c8776 2945 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2946 values to a Lisp function. Gcpro more variables.
2947 (uniprop_table_uncompress)
2948 (uniprop_decode_value_run_length): New functions.
2949 (uniprop_decoder, uniprop_decoder_count): New variables.
2950 (uniprop_get_decoder, uniprop_encode_value_character)
2951 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2952 New functions.
2953 (uniprop_encoder, uniprop_encoder_count): New variables.
2954 (uniprop_get_encoder, uniprop_table)
2955 (Funicode_property_table_internal, Fget_unicode_property_internal)
2956 (Fput_unicode_property_internal): New functions.
2957 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2958 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2959 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2960 char-code-property-alist.
2961
640c8776 2962 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2963 Vunicode_category_table.
2964
640c8776 2965 * font.c (font_range): Adjust for the change of
c805dec0
KH
2966 Vunicode_category_table.
2967
76b397fb
DN
29682011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2969
2970 * m/iris4d.h: Remove file, move contents ...
2971 * s/irix6-5.h: ... here.
2972
22b4128e
PE
29732011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2974
2975 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2976 * alloc.c (mark_buffer):
2977 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2978 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2979 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2980 This isn't true in general, and it's particularly not true
2981 if Emacs is configured with --with-wide-int.
2982 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2983 New macros, used in the buffer.c change.
2984
869795d6
JD
29852011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2986
2987 * xsettings.c: Use both GConf and GSettings if both are available.
2988 (store_config_changed_event): Add comment.
2989 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2990 (store_tool_bar_style_changed): New functions.
5e617bc2 2991 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2992 (struct xsettings): Move font inside HAVE_XFT.
2993 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2994 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2995 Move inside HAVE_XFT.
640c8776 2996 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2997 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2998 also.
2999 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3000 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3001 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3002 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3003 (parse_settings): Move check for font inside HAVE_XFT.
3004 (read_settings, apply_xft_settings): Add comment.
3005 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3006 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3007 call store_font_name_changed.
3008 (xft_settings_event): Add comment.
3009 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3010 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3011 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3012 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3013 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3014 (xsettings_get_system_font, xsettings_get_system_normal_font):
3015 Add comment.
869795d6 3016
d8ed26bd
PE
30172011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 Random fixes. E.g., (random) never returned negative values.
3020 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3021 subseconds part to the entropy, as that's a bit more random.
3022 Prefer signed to unsigned, since the signedness doesn't matter and
3023 in general we prefer signed. When given a limit, use a
3024 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3025 latter isn't right if USE_2_TAGS_FOR_INTS.
3026 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3027 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3028
cabf1cac
SM
30292011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3030
3031 * textprop.c (text_property_stickiness):
3032 Obey Vtext_property_default_nonsticky.
3033 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3034 * w32fns.c (syms_of_w32fns):
3035 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3036
6e9b2be9
PE
30372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3040 This is more efficient than Ffile_directory_p and avoids a minor race.
3041
90186c68
LMI
30422011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3043
7c301272
LMI
3044 * buffer.c (Foverlay_put): Say what the return value is
3045 (bug#7835).
3046
c4f2d8d4
LMI
3047 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3048 is a directory before asking whether to use the file name
3049 (bug#7564).
ad637907
LMI
3050 (barf_or_query_if_file_exists): Make the "File is a directory"
3051 error be more correct.
c4f2d8d4 3052
90186c68
LMI
3053 * fns.c (Frequire): Remove the mention of the .gz files, since
3054 that's installation-specific, but keep the mention of
3055 `get-load-suffixes'.
3056
da64016e
PE
30572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3060 Report string overflow if the output is too long.
3061
7d47b580
JB
30622011-07-04 Juanma Barranquero <lekktu@gmail.com>
3063
a555cb87
JB
3064 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3065 (syms_of_gnutls): Remove duplicate DEFSYM for
3066 Qgnutls_bootprop_verify_hostname_error, an error for
3067 Qgnutls_bootprop_verify_error (which is no longer used).
3068
7d47b580
JB
3069 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3070 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3071 Also (re)move comments that are misplaced or no longer relevant.
3072
1e49bfab
LMI
30732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3074
3075 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3076
1485f4c0
CY
30772011-07-03 Chong Yidong <cyd@stupidchicken.com>
3078
3079 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3080 and background color parameters if they have been changed.
3081
a9ab721e
LMI
30822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3083
3084 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3085
cf7cff57
PE
30862011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3087
2e13213d
PE
3088 * xsettings.c (SYSTEM_FONT): Define only when used.
3089 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3090
cf7cff57
PE
3091 * keymap.c (access_keymap_1): Now static.
3092
7a8e04f7
CY
30932011-07-02 Chong Yidong <cyd@stupidchicken.com>
3094
3095 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3096 leave any prefix arg for the up event (Bug#1586).
3097
61352f62
LMI
30982011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3099
69bb1ef7
LMI
3100 * lread.c (syms_of_lread): Mention single symbols defined by
3101 `defvar' or `defconst' (bug#7154).
3102
61352f62 3103 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3104 (Frequire): Mention get-load-suffixes.
61352f62 3105
28545e04
MR
31062011-07-02 Martin Rudalics <rudalics@gmx.at>
3107
3108 * window.h (window): Remove clone_number slot.
3109 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3110 Remove.
3111 (make_parent_window, make_window, saved_window)
3112 (Fset_window_configuration, save_window_save): Don't deal with
3113 clone numbers.
3114 * buffer.c (Qclone_number): Remove declaration.
3115 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3116
3349e122
SM
31172011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3118
3119 Add multiple inheritance to keymaps.
3120 * keymap.c (Fmake_composed_keymap): New function.
3121 (Fset_keymap_parent): Simplify.
3122 (fix_submap_inheritance): Remove.
3123 (access_keymap_1): New function extracted from access_keymap to handle
3124 embedded parents and handle lists of maps.
3125 (access_keymap): Use it.
3126 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3127 (Fcopy_keymap): Handle embedded parents.
3128 (Fcommand_remapping, define_as_prefix): Simplify.
3129 (Fkey_binding): Simplify.
3130 (syms_of_keymap): Move minibuffer-local-completion-map,
3131 minibuffer-local-filename-completion-map,
3132 minibuffer-local-must-match-map, and
3133 minibuffer-local-filename-must-match-map to Elisp.
3134 (syms_of_keymap): Defsubr make-composed-keymap.
3135 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3136 (parse_menu_item): Trivial simplification.
3137
3279eb87
GM
31382011-07-01 Glenn Morris <rgm@gnu.org>
3139
3140 * Makefile.in (SETTINGS_LIBS): Fix typo.
3141
4550efdf
KI
31422011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3143
3144 * coding.c (Fencode_coding_string): Record the last coding system
3145 used, as the function doc string says (bug#8738).
3146
0949d2b6
JD
31472011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3148
3149 * xsettings.c (store_monospaced_changed): Take new font as arg and
3150 check for change against current_mono_font.
3151 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3152 (emacs_settings_constructor, emacs_settings_get_property)
3153 (emacs_settings_set_property, emacs_settings_class_init)
3154 (emacs_settings_init, gsettings_obj): Remove.
3155 (something_changedCB): New function for HAVE_GSETTINGS.
3156 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3157 with value as argument.
3158 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3159 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3160 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3161 "changed".
3162
3163 * xgselect.c: Add defined (HAVE_GSETTINGS).
3164 (xgselect_initialize): Ditto.
3165
3166 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3167 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3168 xg_select.
3169
bbc6b304
PE
31702011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3171
3172 * eval.c (struct backtrace): Simplify and port the data structure.
3173 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3174 signed bit field, as this assumption is not portable and it makes
3175 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3176 "char debug_on_exit : 1" as this is not portable either; instead,
3177 use the portable "unsigned int debug_on_exit : 1". Remove unused
3178 member evalargs. Remove obsolete comments about cc bombing out.
3179
9851bfc5
JD
31802011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3181
51bb811f 3182 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3183 Let HAVE_GSETTINGS override HAVE_GCONF.
3184 (store_monospaced_changed): New function.
3185 (EMACS_SETTINGS): A new type derived from GObject to handle
3186 GSettings notifications.
3187 (emacs_settings_constructor, emacs_settings_get_property)
3188 (emacs_settings_set_property, emacs_settings_class_init):
3189 New functions.
3190 (gsettings_client, gsettings_obj): New variables.
3191 (GSETTINGS_SCHEMA): New define.
3192 (something_changedCB): Call store_monospaced_changed.
3193 (init_gsettings): New function.
3194 (xsettings_initialize): Call init_gsettings.
3195 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3196 to NULL.
3197
640c8776 3198 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3199 GCONF_CFLAGS/LIBS.
3200
5386012d
MR
32012011-06-29 Martin Rudalics <rudalics@gmx.at>
3202
3203 * window.c (resize_root_window, grow_mini_window)
3204 (shrink_mini_window): Rename Qresize_root_window to
3205 Qwindow_resize_root_window and Qresize_root_window_vertically to
3206 Qwindow_resize_root_window_vertically.
3207
f13e0b08
PE
32082011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3209
3210 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3211
94515237
JB
32122011-06-27 Juanma Barranquero <lekktu@gmail.com>
3213
3214 * makefile.w32-in: Redesign dependencies so they reflect more
3215 clearly which files are directly included by each source file,
3216 and not through other includes.
3217
e43b6e43
MR
32182011-06-27 Martin Rudalics <rudalics@gmx.at>
3219
3220 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3221 (sort_overlays, overlay_strings): When an overlay's clone number
3222 matches the window's clone number process the overlay even if
3223 the overlay's window property doesn't match the current window.
3224
d68443dc
MR
3225 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3226 (Fwindow_hchild): Rename to Fwindow_left_child.
3227 (Fwindow_next): Rename to Fwindow_next_sibling.
3228 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3229 (resize_window_check): Rename to window_resize_check.
3230 (resize_window_apply): Rename to window_resize_apply.
3231 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3232 (Fdelete_other_windows_internal, resize_frame_windows)
3233 (Fsplit_window_internal, Fdelete_window_internal)
3234 (grow_mini_window, shrink_mini_window)
3235 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3236
c7e73be5
JD
32372011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3238
3239 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3240 (emacs_fixed_set_min_size): Remove.
3241 (emacs_fixed_new): Take frame as argument.
3242
3243 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3244 (_EmacsFixedPrivate): Remove minwidth/height.
3245 Add struct frame *f.
3246 (emacs_fixed_init): Initialize priv->f.
3247 (get_parent_class, emacs_fixed_set_min_size): Remove.
3248 (emacs_fixed_new): Set priv->f to argument.
3249 (emacs_fixed_get_preferred_width)
3250 (emacs_fixed_get_preferred_height): Use min_width/height from
3251 frames size_hint to set minimum and natural (Bug#8919).
3252 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3253 and use min_width/height from frames size_hint to set
3254 min_width/height (Bug#8919).
3255
3256 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3257 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3258 Fix indentation.
c7e73be5 3259
cf99dcf8
EZ
32602011-06-26 Eli Zaretskii <eliz@gnu.org>
3261
3262 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3263 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3264 called at ZV.
3265
029529ac
CY
32662011-06-26 Chong Yidong <cyd@stupidchicken.com>
3267
3268 * process.c (wait_reading_process_output): Bypass select if
3269 waiting for a cell while ignoring keyboard input, and input is
3270 pending. Suggested by Jan Djärv (Bug#8869).
3271
7a7ef429
PE
32722011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 Use gnulib's dup2 module instead of rolling our own.
3275 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3276
11fdef7d 32772011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3278
3279 * dispnew.c (scrolling_window): Before scrolling, turn off a
3280 mouse-highlight in the window being scrolled.
3281
cd3520a4
JB
32822011-06-24 Juanma Barranquero <lekktu@gmail.com>
3283
3284 Move DEFSYM to lisp.h and use everywhere.
3285
3286 * character.h (DEFSYM): Move declaration...
3287 * lisp.h (DEFSYM): ...here.
3288
3289 * gnutls.c:
3290 * minibuf.c:
3291 * w32menu.c:
3292 * w32proc.c:
3293 * w32select.c: Don't include character.h.
3294
3295 * alloc.c (syms_of_alloc):
3296 * buffer.c (syms_of_buffer):
3297 * bytecode.c (syms_of_bytecode):
3298 * callint.c (syms_of_callint):
3299 * casefiddle.c (syms_of_casefiddle):
3300 * casetab.c (init_casetab_once):
3301 * category.c (init_category_once, syms_of_category):
3302 * ccl.c (syms_of_ccl):
3303 * cmds.c (syms_of_cmds):
3304 * composite.c (syms_of_composite):
3305 * dbusbind.c (syms_of_dbusbind):
3306 * dired.c (syms_of_dired):
3307 * dispnew.c (syms_of_display):
3308 * doc.c (syms_of_doc):
3309 * editfns.c (syms_of_editfns):
3310 * emacs.c (syms_of_emacs):
3311 * eval.c (syms_of_eval):
3312 * fileio.c (syms_of_fileio):
3313 * fns.c (syms_of_fns):
3314 * frame.c (syms_of_frame):
3315 * fringe.c (syms_of_fringe):
3316 * insdel.c (syms_of_insdel):
3317 * keymap.c (syms_of_keymap):
3318 * lread.c (init_obarray, syms_of_lread):
3319 * macros.c (syms_of_macros):
3320 * msdos.c (syms_of_msdos):
3321 * print.c (syms_of_print):
3322 * process.c (syms_of_process):
3323 * search.c (syms_of_search):
3324 * sound.c (syms_of_sound):
3325 * syntax.c (init_syntax_once, syms_of_syntax):
3326 * terminal.c (syms_of_terminal):
3327 * textprop.c (syms_of_textprop):
3328 * undo.c (syms_of_undo):
3329 * w32.c (globals_of_w32):
3330 * window.c (syms_of_window):
3331 * xdisp.c (syms_of_xdisp):
3332 * xfaces.c (syms_of_xfaces):
3333 * xfns.c (syms_of_xfns):
3334 * xmenu.c (syms_of_xmenu):
3335 * xsettings.c (syms_of_xsettings):
3336 * xterm.c (syms_of_xterm): Use DEFSYM.
3337
4228cf16
TZ
33382011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3339
cd3520a4 3340 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3341
7fcccf1e
PE
33422011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3343
7efb4e0e
PE
3344 Integer and buffer overflow fixes (Bug#8873).
3345
ff5844ad
PE
3346 * print.c (printchar, strout): Check for string overflow.
3347 (PRINTPREPARE, printchar, strout):
3348 Don't set size unless allocation succeeds.
3349
90532f02
PE
3350 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3351 for sizes. Check for string overflow more accurately.
3352 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3353
6d84508d
PE
3354 * macros.c: Integer and buffer overflow fixes.
3355 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3356 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3357 Use ptrdiff_t, not int, for sizes.
3358 Don't increment bufsize until after realloc succeeds.
3359 Check for size-calculation overflow.
3360 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3361
437b2cb4
PE
3362 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3363
8b9ac8b4
PE
3364 * lread.c: Integer overflow fixes.
3365 (read_integer): Radix is now EMACS_INT, not int,
3366 to improve quality of diagnostics for out-of-range radices.
3367 Calculate buffer size correctly for out-of-range radices.
3368 (read1): Check for integer overflow in radices, and in
3369 read-circle numbers.
82cb60d3
PE
3370 (read_escape): Avoid int overflow.
3371 (Fload, openp, read_buffer_size, read1)
3372 (substitute_object_recurse, read_vector, read_list, map_obarray):
3373 Use ptrdiff_t, not int, for sizes.
3374 (read1): Use EMACS_INT, not int, for sizes.
20270765 3375 Check for size overflow.
8b9ac8b4 3376
7fcccf1e
PE
3377 * image.c (cache_image): Check for size arithmetic overflow.
3378
bfbbd7e7
PE
3379 * lread.c: Integer overflow issues.
3380 (saved_doc_string_size, saved_doc_string_length)
3381 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3382 Now ptrdiff_t, not int.
3383 (read1): Don't assume doc string length fits in int. Check for
3384 out-of-range doc string lengths.
3385 (read_list): Don't assume file position fits in int.
39019e54 3386 (read_escape): Check for hex character overflow.
bfbbd7e7 3387
4e323265
LL
33882011-06-22 Leo Liu <sdl.web@gmail.com>
3389
3390 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3391 Move to minibuffer.el.
3392
85fece3e
PE
33932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3394
20b84ce9 3395 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3396 The following patches are for when GLYPH_DEBUG && !XASSERT.
3397 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3398 * dispnew.c (flush_stdout):
3399 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3400 Mark as externally visible.
3401 * dispnew.c (check_window_matrix_pointers): Now static.
3402 * dispnew.c (window_to_frame_vpos):
3403 * xfns.c (unwind_create_frame):
3404 * xterm.c (x_check_font): Remove unused local.
3405 * scroll.c (CHECK_BOUNDS):
3406 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3407 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3408 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3409 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3410 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3411 Now static.
3412 (debug_method_add): Use va_list and vsprintf rather than relying
3413 on undefined behavior with wrong number of arguments.
3414 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3415 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3416 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3417 since we're not interested in debugging glyphs with old libraries.
3418 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3419 GCC 4.6.0's static checking.
3420
0766b489
PE
34212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3422
31fd4b32
PE
3423 Integer overflow and signedness fixes (Bug#8873).
3424 A few related buffer overrun fixes, too.
3425
b79e8648
PE
3426 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3427
0766b489
PE
3428 * dispextern.h (struct face.stipple):
3429 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3430 (x_bitmap_mask, x_allocate_bitmap_record)
3431 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3432 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3433 (x_create_bitmap_from_xpm_data):
3434 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3435 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3436 (.bitmaps_last):
3437 * xfaces.c (load_pixmap):
3438 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3439 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3440 (.bitmaps_last, struct x_output.icon_bitmap):
3441 Use ptrdiff_t, not int, for bitmap indexes.
3442 (x_allocate_bitmap_record): Check for size overflow.
3443 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3444
b081724f
PE
3445 Use ptrdiff_t, not int, for overlay counts.
3446 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3447 * editfns.c (overlays_around, get_pos_property):
3448 * textprop.c (get_char_property_and_overlay):
3449 * xdisp.c (next_overlay_change, note_mouse_highlight):
3450 * xfaces.c (face_at_buffer_position):
21514da7
PE
3451 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3452 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3453 (Fnext_overlay_change, Fprevious_overlay_change)
3454 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3455 Use ptrdiff_t, not int, for sizes.
21514da7 3456 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3457
3de73e5e
PE
3458 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3459
2606c57b
PE
3460 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3461 (x_session_initialize): Do not assume string length fits in int.
3462
aaafe47a
PE
3463 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3464 This is unlikely, but can occur if DPI is outlandish.
3465
2674ddc8 3466 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3467 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3468
28154962
PE
3469 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3470 * xrdb.c (magic_file_p, search_magic_path):
3471 Omit last arg SUFFIX; it was always 0. All callers changed.
3472 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3473
7de51af5
PE
3474 * xfont.c (xfont_match): Avoid need for strlen.
3475
25ed6cc3
PE
3476 * xfns.c: Don't assume strlen fits in int.
3477 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3478
4eab31dd
PE
3479 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3480 not unsigned long, as we prefer signed integers. All callers changed.
3481 Detect integer overflow in repeat count.
3482 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3483 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3484
171e2a58
PE
3485 * termcap.c: Don't assume sizes fit in int and never overflow.
3486 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3487 (gobble_line): Check for size-calculation overflow.
3488
ad39faca 3489 * minibuf.c (Fread_buffer):
6e5bb2dc 3490 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3491 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3492 Don't assume string length fits in int.
3493
52c61c22 3494 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3495 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3496
b5b8c9e5
PE
3497 * font.c: Don't assume string length fits in int.
3498 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3499 Use ptrdiff_t, not int.
ccd6111c
PE
3500 (font_intern_prop): Don't assume string length fits in int.
3501 Don't assume integer property fits in fixnum.
3502 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3503
882f0d81 3504 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3505 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3506 Reformulate so as not to need the command string.
3507 Invoke gzip -cd rather than gunzip, as it's more portable.
3508 (lock_info_type, lock_file_1, lock_file):
3509 Don't assume pid_t and time_t fit in unsigned long.
3510 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3511 (current_lock_owner): Prefer signed type for sizes.
3512 Use memcpy, not strncpy, where memcpy is what is really wanted.
3513 Don't assume (via atoi) that time_t and pid_t fit in int.
3514 Check for time_t and/or pid_t out of range, e.g., via a network share.
3515 Don't alloca where an auto var works fine.
3516
93f4cf88
PE
3517 * fileio.c: Fix some integer overflow issues.
3518 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3519 Don't assume string length fits in int.
3520 (directory_file_name): Don't assume string length fits in long.
3521 (make_temp_name): Don't assume pid fits in int, or that its print
3522 length is less than 20.
3523
f3e92b69
PE
3524 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3525
1bfdaf10
PE
3526 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3527
35016e9a
PE
3528 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3529
3d1e65a1
PE
3530 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3531 We prefer signed integers, even for size calculations.
3532
0b963a93
PE
3533 * emacs.c: Don't assume string length fits in 'int'.
3534 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3535 (main): Don't invoke strlen when not needed.
3536
573f4b54
PE
3537 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3538 (XD_DEBUG_MESSAGE): Don't waste a byte.
3539
989f33ba
PE
3540 * callproc.c (getenv_internal_1, getenv_internal)
3541 (Fgetenv_internal):
965d34eb
PE
3542 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3543
e4d29b33
PE
3544 * lread.c (invalid_syntax): Omit length argument.
3545 All uses changed. This doesn't fix a bug, but it simplifies the
3546 code away from its former Hollerith-constant appearance, and it's
3547 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3548 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3549
eb49b136
PE
3550 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3551 This didn't break anything, but it didn't help either.
3552 It's confusing to put a bogus integer in a place where the actual
3553 value does not matter.
9f62aeb1 3554 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3555 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3556
15375a22
PE
3557 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3558 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3559 implementation.
b61cc01c
PE
3560 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3561 We prefer signed types, and the value cannot exceed the EMACS_INT
3562 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3563 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3564 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3565 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3566
53b2623d
PE
3567 * indent.c (sane_tab_width): New function.
3568 (current_column, scan_for_column, Findent_to, position_indentation)
3569 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3570 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3571
51cab52b 3572 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3573
f2ed8a70
PE
3574 * lisp.h (lint_assume): New macro.
3575 * composite.c (composition_gstring_put_cache):
3576 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3577
abe80cc6
PE
3578 * editfns.c, insdel.c:
3579 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3580
b02c740e
PE
3581 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3582
ebc96716
PE
3583 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3584
b4e50fa0 3585 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3586 Use much-faster test for byte-length change.
311d5d7c 3587 Don't assume string byte-length fits in 'int'.
a4cf38e4 3588 Check that character arg fits in 'int'.
85461888 3589 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3590
c0c1ee9f
PE
3591 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3592
a498d7f4
PE
3593 * fns.c (concat): Catch string overflow earlier.
3594 Do not rely on integer wraparound.
3595
51cab52b
PE
3596 * dispextern.h (struct it.overlay_strings_charpos)
3597 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3598 * xdisp.c (forward_to_next_line_start)
3599 (back_to_previous_visible_line_start)
3600 (reseat_at_next_visible_line_start, next_element_from_buffer):
3601 Don't arbitrarily truncate the value of 'selective' to int.
3602
76031fad
PE
3603 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3604
5eb55db9
PE
3605 * composite.c: Don't truncate sizes to 'int'.
3606 (composition_gstring_p, composition_reseat_it)
3607 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3608 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3609 not EMACS_UINT, for indexes.
5eb55db9 3610
0703a717
PE
3611 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3612
d6202519
PE
3613 * buffer.c: Include <verify.h>.
3614 (struct sortvec.priority, struct sortstr.priority):
8961a454 3615 Now EMACS_INT, not int.
c20998a7 3616 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3617 (struct sortstr.size, record_overlay_string)
3618 (struct sortstrlist.size, struct sortlist.used):
3619 Don't truncate size to int.
3620 (record_overlay_string): Check for size-calculation overflow.
d6202519 3621 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3622
d5a19415
JM
36232011-06-22 Jim Meyering <meyering@redhat.com>
3624
029529ac 3625 Don't leak an XBM-image-sized buffer
d5a19415
JM
3626 * image.c (xbm_load): Free the image buffer after using it.
3627
a9041e6c
PE
36282011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Port to Sun C.
3631 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3632 that Sun C diagnosed.
3633 * fns.c (secure_hash): Fix pointer signedness issue.
3634 * intervals.c (static_offset_intervals): New function.
3635 (offset_intervals): Use it.
3636
7f3f739f
LL
36372011-06-21 Leo Liu <sdl.web@gmail.com>
3638
3639 * deps.mk (fns.o):
3640 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3641 sha512.h.
3642
3643 * fns.c (secure_hash): Rename from crypto_hash_function and change
3644 the first arg to accept symbols.
5b66d427 3645 (Fsecure_hash): New primitive.
7f3f739f
LL
3646 (syms_of_fns): New symbols.
3647
76147d94
DD
36482011-06-20 Deniz Dogan <deniz@dogan.se>
3649
3650 * process.c (Fset_process_buffer): Clarify return value in
3651 docstring.
3652
7d7d0045
CY
36532011-06-18 Chong Yidong <cyd@stupidchicken.com>
3654
3655 * dispnew.c (add_window_display_history): Use BVAR.
3656
3657 * xdisp.c (debug_method_add): Use BVAR.
3658 (check_window_end, dump_glyph_matrix, dump_glyph)
3659 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3660
3661 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3662 Likewise.
3663
3664 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3665 check till after the cache is created in init_frame_faces.
3666
ff2bc410
SM
36672011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3668
3669 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3670
28177add
PE
36712011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3672
dd3482fe
PE
3673 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3674 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3675 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3676
393d71f3 3677 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3678 * fileio.c (Finsert_file_contents):
3679 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3680 Remove the old (too-loose) buffer overflow checks.
3681 They weren't needed, since make_gap checks for buffer overflow.
3682 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3683 The old code merely checked for Emacs fixnum overflow, and relied
3684 on undefined (wraparound) behavior. The new code avoids undefined
3685 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3686
2e6813b0 3687 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3688 Tune. Don't use wider integers than needed. Don't use alloca.
3689 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3690
599a9e4f
PE
3691 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3692
99561444
PE
3693 * insdel.c, lisp.h (buffer_overflow): New function.
3694 (insert_from_buffer_1, replace_range, replace_range_2):
3695 * insdel.c (make_gap_larger):
3696 * editfns.c (Finsert_char):
3697 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3698
28177add
PE
3699 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3700
e69dafad
PE
37012011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3702
a7af7fde 3703 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3704
b1c46f02
PE
3705 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3706 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3707
e69dafad
PE
3708 * fileio.c: Don't assume EMACS_INT fits in off_t.
3709 (emacs_lseek): New static function.
3710 (Finsert_file_contents, Fwrite_region): Use it.
3711 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3712
566684ea
PE
3713 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3714
e6966cd6
PE
3715 * fns.c: Don't overflow int when computing a list length.
3716 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3717 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3718 truncation on 64-bit hosts. Check for QUIT every
3719 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3720 faster and is responsive enough.
3721 (Flength): Report an error instead of overflowing an integer.
3722 (Fsafe_length): Return a float if the value is not representable
3723 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3724 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3725 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3726
dd0b0efb
PE
3727 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3728 (header_size, word_size): New constants.
3729 (allocate_vectorlike): Don't check size overflow here.
3730 (allocate_vector): Check it here instead, since this is the only
3731 caller of allocate_vectorlike that could cause overflow.
3732 Check that the new vector's length is representable as a fixnum.
3733
86fe5cfe
PE
3734 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3735 The previous code was bogus. For example, next_almost_prime (32)
3736 returned 39, which is undesirable as it is a multiple of 3; and
3737 next_almost_prime (24) returned 25, which is a multiple of 5 so
3738 why was the code bothering to check for multiples of 7?
3739
80e88859
PE
3740 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3741
4a2f0ad6
PE
3742 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3743
f66c7cf8
PE
3744 Variadic C functions now count arguments with ptrdiff_t.
3745 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3746 Back then I didn't know that the Emacs coding style prefers signed int.
3747 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3748 were being counted with int, which may truncate counts on 64-bit
3749 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3750 * lisp.h (struct Lisp_Subr.function.aMANY)
3751 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3752 Arg counts are now ptrdiff_t, not size_t.
3753 All variadic functions and their callers changed accordingly.
3754 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3755 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3756 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3757 * callint.c (Fcall_interactively): Check arg count for overflow,
3758 to avoid potential buffer overrun. Use signed char, not 'int',
3759 for 'varies' array, so that we needn't bother to check its size
3760 calculation for overflow.
3761 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3762 * eval.c (apply_lambda):
3763 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3764 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3765 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3766
a1759b76
PE
3767 * callint.c (Fcall_interactively): Don't use index var as event count.
3768
d96be9fc
PE
3769 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3770 * mem-limits.h (SIZE): Remove; no longer used.
3771
a690a978 3772 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3773
578c21e6
PE
3774 Remove unnecessary casts.
3775 * xterm.c (x_term_init):
3776 * xfns.c (x_set_border_pixel):
3777 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3778 These aren't needed now that we assume ANSI C.
3779
96f53c6c
PE
3780 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3781 It's more likely to cause problems (due to unsigned overflow)
3782 than to cure them.
3783
83c77d31
PE
3784 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3785
ee2079f1
PE
3786 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3787
6da65536
PE
3788 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3789
7147c4a4
PE
3790 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3791
193e32d9
PE
3792 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3793
e5533da6
PE
3794 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3795
9910e595
PE
3796 GLYPH_CODE_FACE returns EMACS_INT, not int.
3797 * dispextern.h (merge_faces):
3798 * xfaces.c (merge_faces):
01103c44
PE
3799 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3800 Don't assume EMACS_INT fits in int.
9910e595 3801
2638320e
PE
3802 * character.h (CHAR_VALID_P): Remove unused parameter.
3803 * fontset.c, lisp.h, xdisp.c: All uses changed.
3804
045eb8d9
PE
3805 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3806
c1f134b5
PE
3807 * fns.c (concat): Minor tuning based on overflow analysis.
3808 This doesn't fix any bugs. Use int to hold character, instead
3809 of constantly refetching from Emacs object. Use XFASTINT, not
3810 XINT, for value known to be a character. Don't bother comparing
3811 a single byte to 0400, as it's always less.
3812
395fcb93 3813 * floatfns.c (Fexpt):
327eeec8
PE
3814 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3815
abbd3d23
PE
3816 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3817 for characters.
3818
684a03ef
PE
3819 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3820
0fed43f3
PE
3821 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3822 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3823 incorrectly succeed when S was a string, because 4294967386 was
3824 truncated before it was used.
3825
8fd02eb7
PE
3826 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3827 Otherwise, an out-of-range integer could cause undefined behavior
3828 on a 64-bit host.
3829
f8c86b69
PE
3830 * composite.c: Use int, not EMACS_INT, for characters.
3831 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3832 EMACS_INT, for values that are known to be in character range.
3833 This doesn't fix any bugs but is the usual style inside Emacs and
3834 may generate better code on 32-bit machines.
3835
34206dd2
PE
3836 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3837 This is for reasons similar to the recent CHAR_STRING fix.
3838 * charset.c (Fencode_char): Check that character arg is actually
3839 a character. Pass an int to ENCODE_CHAR.
3840 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3841 wider than 'int', as a compile-time check to prevent future regressions
3842 in this area.
3843
c5958d4c 3844 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3845
3846 Make sure a 64-bit char is never passed to CHAR_STRING.
3847 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3848 by silently ignoring the top 32 bits, allowing some values
3849 that were far too large to be valid characters.
3850 * character.h: Include <verify.h>.
3851 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3852 arguments are no wider than unsigned, as a compile-time check
3853 to prevent future regressions in this area.
3854 * data.c (Faset):
01103c44 3855 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3856 (Fsubst_char_in_region):
3857 * fns.c (concat):
3858 * xdisp.c (decode_mode_spec_coding):
3859 Adjust to CHAR_STRING's new requirement.
3860 * editfns.c (Finsert_char, Fsubst_char_in_region):
3861 * fns.c (concat): Check that character args are actually
3862 characters. Without this test, these functions did the wrong
3863 thing with wildly out-of-range values on 64-bit hosts.
3864
d37ca623
PE
3865 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3866 These casts should not be needed on 32-bit hosts, either.
3867 * keyboard.c (read_char):
3868 * lread.c (Fload): Remove casts to unsigned.
3869
ea204efb
PE
3870 * lisp.h (UNSIGNED_CMP): New macro.
3871 This fixes comparison bugs on 64-bit hosts.
3872 (ASCII_CHAR_P): Use it.
3873 * casefiddle.c (casify_object):
01103c44 3874 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3875 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3876 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3877 * dispextern.h (FACE_FROM_ID):
3878 * keyboard.c (read_char): Use UNSIGNED_CMP.
3879
41cb286c
PE
3880 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3881 not to EMACS_INT, to avoid GCC warning.
3882
4a1b9832
PE
3883 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3884
55daad71
PE
3885 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3886 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3887 isn't needed on 32-bit machines.
8f95c75c 3888
01103c44
PE
3889 * buffer.c (Fgenerate_new_buffer_name):
3890 Use EMACS_INT for count, not int.
0ceccced 3891 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3892
3893 * data.c (Qcompiled_function): Now static.
3894
c6f072e7
PE
3895 * window.c (window_body_lines): Now static.
3896
20ce5912
PE
3897 * image.c (gif_load): Rename local to avoid shadowing.
3898
9c4c5f81
PE
3899 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3900 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3901 * alloc.c (make_save_value): Integer argument is now of type
3902 ptrdiff_t, not int.
3903 (mark_object): Use ptrdiff_t, not int.
3904 * lisp.h (pD): New macro.
3905 * print.c (print_object): Use it.
3906
c0c5c8ae
PE
3907 * alloc.c: Use EMACS_INT, not int, to count objects.
3908 (total_conses, total_markers, total_symbols, total_vector_size)
3909 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3910 (total_free_floats, total_floats, total_free_intervals)
3911 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3912 Now EMACS_INT, not int. All uses changed.
3913 (Fgarbage_collect): Compute overall total using a double, so that
3914 integer overflow is less likely to be a problem. Check for overflow
3915 when converting back to an integer.
5a25e253
PE
3916 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3917 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3918 These were 'int' variables that could overflow on 64-bit hosts;
3919 they were never used, so remove them instead of repairing them.
211a0b2a 3920 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3921 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3922 Previously, this ceilinged at INT_MAX, but that doesn't work on
3923 64-bit machines.
e46bb31a 3924 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3925
c78baabf 3926 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3927 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3928 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3929 when a (possibly-narrower) signed value would do just as well.
3930 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3931
c9d624c6
PE
3932 * alloc.c: Catch some string size overflows that we were missing.
3933 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3934 for convenience in STRING_BYTES_MAX.
3935 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3936 The definition here is exact; the one in lisp.h was approximate.
3937 (allocate_string_data): Check for string overflow. This catches
3938 some instances we weren't catching before. Also, it catches
3939 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3940 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3941 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3942
c9d624c6
PE
3943 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3944 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3945 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3946
353032ce
PE
3947 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3948
2bccce07
PE
3949 * alloc.c (Fmake_string): Check for out-of-range init.
3950
0ac30604
SM
39512011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3952
3953 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3954
c195f2de
JD
39552011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3956
3957 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3958 xg_get_default_scrollbar_width.
3959
3960 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3961 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3962 (style_changed_cb): Call update_theme_scrollbar_width and call
3963 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3964 all frames (Bug#8505).
3965 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3966 Call gtk_window_set_resizable if HAVE_GTK3.
3967 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3968 and height if HAVE_GTK3 (Bug#8505).
3969 (scroll_bar_width_for_theme): New variable.
3970 (update_theme_scrollbar_width): New function.
3971 (xg_get_default_scrollbar_width): Move code to
3972 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3973 (xg_initialize): Call update_theme_scrollbar_width.
3974
3975 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3976
3977 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3978
e10ac9f1
MR
39792011-06-12 Martin Rudalics <rudalics@gmx.at>
3980
3981 * frame.c (make_frame): Call other_buffer_safely instead of
3982 other_buffer.
3983
3984 * window.c (temp_output_buffer_show): Call display_buffer with
3985 second argument Vtemp_buffer_show_specifiers and reset latter
3986 immediately after the call.
3987 (Vtemp_buffer_show_specifiers): New variable.
3988 (auto_window_vscroll_p, next_screen_context_lines)
3989 (Vscroll_preserve_screen_position): Remove leading asterisks from
3990 doc-strings.
3991
2d3c217e 39922011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3993
7b7f97e8 3994 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3995 * buffer.c (Qclone_number): Remove for now, as it's unused.
3996 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3997 (record_buffer): Remove unused local.
3998 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3999 (set_frame_buffer_list): Remove; unused.
4000 * frame.h (other_visible_frames): Remove decl.
4001 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4002 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4003 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4004 if HAVE_GPM.
4005 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4006 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4007 Define only if HAVE_GPM.
4008 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4009 (update_hints_inhibit): Remove; never set. All uses removed.
4010 * widgetprv.h (emacsFrameClassRec): Remove decl.
4011 * window.c (delete_deletable_window): Now returns void, since it
4012 wasn't returning anything.
4013 (compare_window_configurations): Remove unused locals.
4014 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4015 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4016 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4017 the same widths as pointers. This follows up on the 2011-05-06 patch.
4018 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4019 * xterm.h: Likewise.
4020 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4021
1384b89e
JB
40222011-06-12 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * makefile.w32-in: Update dependencies.
4025 (LISP_H): Add lib/intprops.h.
4026
1100a63c
CY
40272011-06-11 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * image.c (gif_load): Add animation frame delay to the metadata.
4030 (syms_of_image): Use DEFSYM. New symbol `delay'.
4031
6198ccd0
MR
40322011-06-11 Martin Rudalics <rudalics@gmx.at>
4033
4034 * window.c (delete_deletable_window): Re-add.
4035 (Fset_window_configuration): Rewrite to handle dead buffers and
4036 consequently deletable windows.
4037 (window_tree, Fwindow_tree): Remove. Supply functionality in
4038 window.el.
4039 (compare_window_configurations): Simplify code.
4040
b6e3633c
AS
40412011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4042
1ab0dee5
AS
4043 * image.c (imagemagick_load_image): Fix type mismatch.
4044 (Fimagemagick_types): Likewise.
4045
b6e3633c
AS
4046 * window.h (replace_buffer_in_windows): Declare.
4047
9397e56f
MR
40482011-06-11 Martin Rudalics <rudalics@gmx.at>
4049
4050 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4051 Qclone_number. Remove external declaration of Qdelete_window.
4052 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4053 code.
640c8776
SM
4054 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4055 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4056 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4057 buffer list implementation.
4058 (other_buffer_safely): New function.
4059 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4060 calls to replace_buffer_in_windows and
4061 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4062 if allowed.
4063 (record_buffer): Inhibit quitting and rewrite using quittable
4064 functions. Run Qbuffer_list_update_hook if allowed.
4065 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4066 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4067 Move switch-to-buffer to window.el.
9397e56f
MR
4068 (bury-buffer): Move to window.el.
4069 (Vbuffer_list_update_hook): New variable.
4070
4071 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4072 section.
4073
4074 * window.h (resize_frame_windows): Move up in code.
4075 (Fwindow_frame): Remove EXFUN.
4076 (replace_buffer_in_all_windows): Remove prototype.
4077 (replace_buffer_in_windows_safely): Add prototype.
4078
4079 * window.c: Declare Qdelete_window static again. Move down
4080 declaration of select_count.
4081 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4082 (Fother_window): Move to window.el.
4083 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4084 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4085 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4086 window.el.
4087 (replace_buffer_in_windows): Implement by calling
4088 Qreplace_buffer_in_windows.
4089 (replace_buffer_in_all_windows): Remove with some functionality
4090 moved into replace_buffer_in_windows_safely.
4091 (replace_buffer_in_windows_safely): New function.
4092 (select_window_norecord, select_frame_norecord): Move in front
4093 of run_window_configuration_change_hook. Remove now obsolete
4094 declarations.
640c8776
SM
4095 (Fset_window_buffer): Rewrite doc-string.
4096 Call Qrecord_window_buffer.
9397e56f
MR
4097 (keys_of_window): Move binding for other-window to window.el.
4098
b50691aa
CY
40992011-06-11 Chong Yidong <cyd@stupidchicken.com>
4100
4101 * dispextern.h (struct image): Replace data member, whose int_val
4102 and ptr_val fields were not used by anything, with a single
4103 lisp_val object.
4104
4105 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4106 (gif_clear_image, gif_load, imagemagick_load_image)
4107 (gs_clear_image, gs_load): Callers changed.
4108
3f754b86
PE
41092011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4110
cca69397
PE
4111 * buffer.h: Include <time.h>, for time_t.
4112 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4113
109e28d0
PE
4114 Fix minor problems found by static checking.
4115
60737f02
PE
4116 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4117
4b66faf3
PE
4118 Make identifiers static if they are not used in other modules.
4119 * data.c (Qcompiled_function, Qframe, Qvector):
4120 * image.c (QimageMagick, Qsvg):
4121 * minibuf.c (Qmetadata):
4122 * window.c (resize_window_check, resize_root_window): Now static.
4123 * window.h (resize_window_check, resize_root_window): Remove decls.
4124
109e28d0
PE
4125 * window.c (window_deletion_count, delete_deletable_window):
4126 Remove; unused.
46a4ce9e
PE
4127 (window_body_lines): Now static.
4128 (Fdelete_other_windows_internal): Mark vars as initialized.
4129 Make sure 'resize_failed' is initialized.
4130 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4131 (resize_window_apply): Remove unused local.
4132 * window.h (delete_deletable_window): Remove decl.
4133
109e28d0 4134 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4135 (imagemagick_load_image): Fix pointer signedness problem by changing
4136 last arg from unsigned char * to char *. All uses changed.
4137 Also, fix a local for similar reasons.
4138 Remove unused locals. Remove locals to avoid shadowing.
4139 (fn_rsvg_handle_free): Remove; unused.
4140 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4141 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4142
3f754b86
PE
4143 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4144
2547adb1
CY
41452011-06-10 Chong Yidong <cyd@stupidchicken.com>
4146
4147 * image.c (gif_load): Fix omitted cast error introduced by
4148 2011-06-06 change.
4149
2c8e37d4
MR
41502011-06-10 Martin Rudalics <rudalics@gmx.at>
4151
4152 * window.h (resize_proportionally, orig_total_lines)
4153 (orig_top_line): Remove from window structure.
4154 (set_window_height, set_window_width, change_window_heights)
4155 (Fdelete_window): Remove prototypes.
4156 (resize_frame_windows): Remove duplicate declaration.
4157
440a42e3
EZ
41582011-06-10 Eli Zaretskii <eliz@gnu.org>
4159
4160 * window.h (resize_frame_windows, resize_window_check)
4161 (delete_deletable_window, resize_root_window)
4162 (resize_frame_windows): Declare prototypes.
4163
4164 * window.c (resize_window_apply): Make definition be "static" to
4165 match the prototype.
4166
562dd5e9
MR
41672011-06-10 Martin Rudalics <rudalics@gmx.at>
4168
4169 * window.c: Remove declarations of Qwindow_size_fixed,
4170 window_min_size_1, window_min_size_2, window_min_size,
4171 size_window, window_fixed_size_p, enlarge_window, delete_window.
4172 Remove static from declaration of Qdelete_window, it's
4173 temporarily needed by Fbury_buffer.
4174 (replace_window): Don't assign orig_top_line and
4175 orig_total_lines.
4176 (Fdelete_window, delete_window): Remove. Window deletion is
4177 handled by window.el.
640c8776
SM
4178 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4179 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4180 (Fdelete_other_windows): Remove. Deleting other windows is
4181 handled by window.el.
4182 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4183 handled in window.el.
4184 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4185 Window minimum sizes are handled in window.el.
4186 (shrink_windows, size_window, set_window_height)
4187 (set_window_width, change_window_heights, window_height)
4188 (window_width, CURBEG, CURSIZE, enlarge_window)
4189 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4190 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4191 handled in window.el.
4192 (make_dummy_parent): Rename to make_parent_window and give it a
4193 second argument horflag.
4194 (make_window): Don't set resize_proportionally any more.
4195 (Fsplit_window): Remove. Windows are split in window.el.
4196 (save_restore_action, save_restore_orig_size)
4197 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4198 Resize mini windows in window.el.
4199 (grow_mini_window, shrink_mini_window): Implement by calling
4200 Qresize_root_window_vertically, resize_window_check and
4201 resize_window_apply.
640c8776
SM
4202 (saved_window, Fset_window_configuration, save_window_save):
4203 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4204 resize_proportionally.
4205 (window_min_height, window_min_width): Move to window.el.
4206 (keys_of_window): Move bindings for delete-other-windows,
4207 split-window, delete-window and enlarge-window to window.el.
4208
4209 * buffer.c: Temporarily extern Qdelete_window.
4210 (Fbury_buffer): Temporarily call Qdelete_window instead of
4211 Fdelete_window (Fbury_buffer will move to window.el soon).
4212
4213 * frame.c (set_menu_bar_lines_1): Remove code handling
4214 orig_top_line and orig_total_lines.
4215
4216 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4217 set_window_height but set heights directly.
4218 (change_frame_size_1): Use resize_frame_windows.
4219
4220 * xdisp.c (init_xdisp): Don't use set_window_height but set
4221 heights directly.
4222
640c8776
SM
4223 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4224 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4225 run_window_configuration_change_hook.
4226
4227 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4228 instead of change_window_heights and run
4229 run_window_configuration_change_hook.
4230
1a13852e
MR
42312011-06-09 Martin Rudalics <rudalics@gmx.at>
4232
4233 * window.c (replace_window): Rename second argument REPLACEMENT to
4234 NEW. New third argument SETFLAG. Rewrite.
4235 (delete_window, make_dummy_parent): Call replace_window with
4236 third argument 1.
4237 (window_list_1): Move down in code.
4238 (run_window_configuration_change_hook): Move set_buffer part
4239 before select_frame_norecord part in order to unwind correctly.
4240 Rename count1 to count.
4241 (recombine_windows, delete_deletable_window, resize_root_window)
4242 (Fdelete_other_windows_internal)
4243 (Frun_window_configuration_change_hook, make_parent_window)
4244 (resize_window_check, resize_window_apply, Fresize_window_apply)
4245 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4246 (Fdelete_window_internal, Fresize_mini_window_internal):
4247 New functions.
1a13852e
MR
4248 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4249
f3d1777e
MR
42502011-06-08 Martin Rudalics <rudalics@gmx.at>
4251
496e208e
MR
4252 * window.h (window): Add some new members to window structure -
4253 normal_lines, normal_cols, new_total, new_normal, clone_number,
4254 splits, nest, prev_buffers, next_buffers.
4255 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4256 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4257
f3d1777e
MR
4258 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4259 Remove.
496e208e
MR
4260 (make_dummy_parent): Set new members of windows structure.
4261 (make_window): Move down in code. Handle new members of window
4262 structure.
4263 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4264 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4265 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4266 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4267 (Fset_window_next_buffers, Fset_window_clone_number):
4268 New functions.
496e208e
MR
4269 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4270 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4271 Doc-string fixes.
4272 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4273 Argument WINDOW can be now internal window too.
4274 (Fwindow_use_time): Move up in code.
4275 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4276 Rewrite doc-string.
4277 (Fset_window_configuration, saved_window)
4278 (Fcurrent_window_configuration, save_window_save): Handle new
4279 members of window structure.
b9e809c2
MR
4280 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4281 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4282 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4283 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4284 Qget_mru_window, Qresize_root_window,
4285 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4286 Qauto_buffer_name; staticpro them.
f3d1777e 4287
abde8f8c
MR
42882011-06-07 Martin Rudalics <rudalics@gmx.at>
4289
4290 * window.c (Fwindow_total_size, Fwindow_left_column)
4291 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4292 (Fwindow_list_1): New functions.
4293 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4294 (Fwindow_width, Fscroll_left, Fscroll_right):
4295 Use window_body_cols instead of window_box_text_cols.
4296 (delete_window, Fset_window_configuration):
4297 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4298 (delete_all_subwindows): Take a window as argument and not a
4299 structure. Rewrite.
190b47e6
MR
4300 (window_loop): Remove handling of GET_LRU_WINDOW and
4301 GET_LARGEST_WINDOW.
4302 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4303
4304 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4305 window_box_text_cols. delete_all_subwindows now takes a
4306 Lisp_Object as argument.
abde8f8c 4307
640c8776
SM
4308 * indent.c (compute_motion, Fcompute_motion):
4309 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4310
fa8a67e6
MR
4311 * frame.c (delete_frame): Call delete_all_subwindows with root
4312 window as argument.
4313
a54e3482
DC
43142011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4315
4316 * fns.c (Fputhash): Document return value.
4317
60002bf5
CY
43182011-06-06 Chong Yidong <cyd@stupidchicken.com>
4319
4320 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4321
0c671da6 43222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4323
b862a52a 4324 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4325
be44ca6c
PE
4326 Check for overflow when converting integer to cons and back.
4327 * charset.c (Fdefine_charset_internal, Fdecode_char):
4328 Use cons_to_unsigned to catch overflow.
4329 (Fencode_char): Use INTEGER_TO_CONS.
4330 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4331 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4332 * data.c (long_to_cons, cons_to_long): Remove.
4333 (cons_to_unsigned, cons_to_signed): New functions.
4334 These signal an error for invalid or out-of-range values.
4335 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4336 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4337 * font.c (Ffont_variation_glyphs):
4338 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4339 * lisp.h: Include <intprops.h>.
4340 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4341 (cons_to_signed, cons_to_unsigned): New decls.
4342 (long_to_cons, cons_to_long): Remove decls.
4343 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4344 (Fprimitive_undo): Use CONS_TO_INTEGER.
4345 * xfns.c (Fx_window_property): Likewise.
4346 * xselect.c: Include <limits.h>.
4347 (x_own_selection, selection_data_to_lisp_data):
4348 Use INTEGER_TO_CONS.
4349 (x_handle_selection_request, x_handle_selection_clear)
4350 (x_get_foreign_selection, Fx_disown_selection_internal)
4351 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4352 (lisp_data_to_selection_data): Use cons_to_unsigned.
4353 (x_fill_property_data): Use cons_to_signed.
4354 Report values out of range.
4355
d1f3d2af
PE
4356 Check for buffer and string overflow more precisely.
4357 * buffer.h (BUF_BYTES_MAX): New macro.
4358 * lisp.h (STRING_BYTES_MAX): New macro.
4359 * alloc.c (Fmake_string):
4360 * character.c (string_escape_byte8):
4361 * coding.c (coding_alloc_by_realloc):
4362 * doprnt.c (doprnt):
4363 * editfns.c (Fformat):
4364 * eval.c (verror):
4365 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4366 since they may not be the same number.
4367 * editfns.c (Finsert_char):
4368 * fileio.c (Finsert_file_contents):
4369 Likewise for BUF_BYTES_MAX.
4370
dd52fcea
PE
4371 * image.c: Use ptrdiff_t, not int, for sizes.
4372 (slurp_file): Switch from int to ptrdiff_t.
4373 All uses changed.
4374 (slurp_file): Check that file size fits in both size_t (for
4375 malloc) and ptrdiff_t (for sanity and safety).
4376
7f9bbdbb
PE
4377 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4378 if b->modtime has its maximal value.
4379
dfe18f82
PE
4380 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4381
84acfcf0
PE
4382 Don't assume time_t can fit into int.
4383 * buffer.h (struct buffer.modtime): Now time_t, not int.
4384 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4385 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4386
ccd9a01a
PE
4387 Minor fixes for signed vs unsigned integers.
4388 * character.h (MAYBE_UNIFY_CHAR):
4389 * charset.c (maybe_unify_char):
4390 * keyboard.c (read_char, reorder_modifiers):
4391 XINT -> XFASTINT, since the integer must be nonnegative.
4392 * ftfont.c (ftfont_spec_pattern):
4393 * keymap.c (access_keymap, silly_event_symbol_error):
4394 XUINT -> XFASTINT, since the integer must be nonnegative.
4395 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4396 since it makes no difference and we prefer signed.
4397 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4398 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4399 nonnegative.
4400
d6d100dd
SM
44012011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4402
4403 * window.h (Fwindow_frame): Declare.
4404
2b6148e4
PE
44052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4408 (SPARE_MEMORY): Always define.
4409 (LARGE_REQUEST): Remove.
4410 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4411
f230ecc9
MR
44122011-06-06 Martin Rudalics <rudalics@gmx.at>
4413
727e958e
MR
4414 * lisp.h: Move EXFUNS for Fframe_root_window,
4415 Fframe_first_window and Fset_frame_selected_window to window.h.
4416
4417 * window.h: Move EXFUNS for Fframe_root_window,
4418 Fframe_first_window and Fset_frame_selected_window here from
4419 lisp.h.
4420
4421 * frame.c (Fwindow_frame, Fframe_first_window)
4422 (Fframe_root_window, Fframe_selected_window)
4423 (Fset_frame_selected_window): Move to window.c.
4424 (Factive_minibuffer_window): Move to minibuf.c.
4425 (Fother_visible_frames_p): New function.
4426
4427 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4428
f230ecc9
MR
4429 * window.c (decode_window, decode_any_window): Move up in code.
4430 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4431 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4432 (Fwindow_buffer): Move up and rewrite doc-string.
4433 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4434 (Fwindow_prev): New functions.
727e958e
MR
4435 (Fwindow_frame): Move here from frame.c. Accept any window as
4436 argument.
4437 (Fframe_root_window, Fframe_first_window)
4438 (Fframe_selected_window): Move here from frame.c. Accept frame
4439 or arbitrary window as argument. Update doc-strings.
4440 (Fminibuffer_window): Move up in code.
4441 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4442 (Fset_frame_selected_window): Move here from frame.c.
4443 Marginal rewrite.
727e958e
MR
4444 (Fselected_window, select_window, Fselect_window): Move up in
4445 code. Minor doc-string fixes.
f230ecc9 4446
4d09bcf6
PE
44472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4448
4449 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4450 Do not assume that spare memory exists; that assumption is valid
4451 only if SYSTEM_MALLOC.
4452 (LARGE_REQUEST): New macro, so that the issue of large requests
4453 is separated from the issue of spare memory.
4454
810928a2
AS
44552011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4456
172418ad
AS
4457 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4458 format. (Bug#8806)
4459
43f862f7
AS
4460 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4461
810928a2
AS
4462 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4463 before statements.
4464
a059fe24
JD
44652011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4466
4467 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4468
4469 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4470
4471 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4472 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4473
989bf368
JB
44742011-06-05 Juanma Barranquero <lekktu@gmail.com>
4475
4476 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4477
4b80f674
CY
44782011-06-04 Chong Yidong <cyd@stupidchicken.com>
4479
4480 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4481 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4482 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4483 New error handlers.
4b80f674
CY
4484 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4485 Obey Vx_select_enable_clipboard_manager. Catch errors in
4486 x_clipboard_manager_save (Bug#8779).
4487 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4488 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4489
99a33b77 44902011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4491
4492 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4493
99a33b77 44942011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4495
4496 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4497 in the current matrix if keep_current_p is non-zero.
4498
8264569d
EZ
44992011-06-04 Eli Zaretskii <eliz@gnu.org>
4500
4501 * bidi.c (bidi_level_of_next_char): Fix last change.
4502
57f97249
EZ
45032011-06-03 Eli Zaretskii <eliz@gnu.org>
4504
fec2107c 4505 Support bidi reordering of text covered by display properties.
57f97249 4506
fec2107c
EZ
4507 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4508 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4509 (bidi_cache_search, bidi_cache_iterator_state)
4510 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4511 (bidi_level_of_next_char, bidi_move_to_visually_next):
4512 Support character positions inside a run of characters covered by a
fec2107c
EZ
4513 display string.
4514 (bidi_paragraph_init, bidi_resolve_explicit_1)
4515 (bidi_level_of_next_char): Call bidi_fetch_char and
4516 bidi_fetch_char_advance instead of FETCH_CHAR and
4517 FETCH_CHAR_ADVANCE.
4518 (bidi_init_it): Initialize new members.
4519 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4520 definitions.
4521 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4522 instead of using explicit *_CHAR codes.
d6d100dd
SM
4523 (bidi_resolve_explicit, bidi_resolve_weak):
4524 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4525 bidirectional text is supported only in multibyte buffers.
4526 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4527 it to initialize the frame_window_p member of struct bidi_it.
4528 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4529 (bidi_resolve_explicit, bidi_resolve_weak)
4530 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4531 bidi_it->nchars is non-positive.
4532 (bidi_level_of_next_char): Don't try to lookup the cache for the
4533 next/previous character if nothing is cached there yet, or if we
4534 were just reseat()'ed to a new position.
c40e2fb2 4535
0e14fe90
EZ
4536 * xdisp.c (set_cursor_from_row): Set start and stop points
4537 according to the row's direction when priming the loop that looks
4538 for the glyph on which to display cursor.
4539 (single_display_spec_intangible_p): Function deleted.
4540 (display_prop_intangible_p): Reimplement to call
4541 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4542 Accept 3 additional arguments needed by handle_display_spec.
4543 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4544 values: lists, `(when COND...)' forms, etc.
4545 (single_display_spec_string_p): Support property values that are
4546 lists with the argument STRING its top-level element.
4547 (display_prop_string_p): Fix the condition for processing a
4548 property that is a list to be consistent with handle_display_spec.
fec2107c 4549 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4550 last portion of handle_display_prop.
4551 (compute_display_string_pos): Accept additional argument
4552 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4553 value of a `display' property is a "replacing spec".
4554 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4555 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4556 the display property, but just return a value indicating whether
4557 the display property will replace the characters it covers.
4558 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4559 frame_window_p members of struct bidi_it.
d6d100dd
SM
4560 (compute_display_string_pos, compute_display_string_end):
4561 New functions.
fec2107c
EZ
4562 (push_it): Accept second argument POSITION, where pop_it should
4563 jump to continue iteration.
4564 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4565
fec2107c
EZ
4566 * keyboard.c (adjust_point_for_property): Adjust the call to
4567 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4568
4569 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4570 (bidi_init_it): Update prototypes.
4571 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4572 (compute_display_string_pos, compute_display_string_end):
4573 Declare prototypes.
fec2107c
EZ
4574 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4575 EMACS_INT.
fc6f18ce 4576
40087514 45772011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4578
57f53182
PE
4579 Malloc failure behavior now depends on size of allocation.
4580 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4581 * lisp.h: Change signatures accordingly.
4582 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4583 All callers changed. (Bug#8762)
4584
4585 * gnutls.c: Use Emacs's memory allocators.
4586 Without this change, the gnutls library would invoke malloc etc.
4587 directly, which causes problems on non-SYNC_INPUT hosts, and which
4588 runs afoul of improving memory_full behavior. (Bug#8761)
4589 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4590 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4591 xfree instead of the default malloc, realloc, free.
4592 (Fgnutls_boot): No need to check for memory allocation failure,
4593 since xmalloc does that for us.
4594
ac32cd99 4595 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4596 * category.c (hash_get_category_set):
4597 * ccl.c (ccl_driver):
4598 * charset.c (Fdefine_charset_internal):
4599 * charset.h (struct charset.hash_index):
4600 * composite.c (get_composition_id, gstring_lookup_cache)
4601 (composition_gstring_put_cache):
4602 * composite.h (struct composition.hash_index):
4603 * dispextern.h (struct image.hash):
4604 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4605 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4606 (hashfn_equal, hashfn_user_defined, make_hash_table)
4607 (maybe_resize_hash_table, hash_lookup, hash_put)
4608 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4609 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4610 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4611 * image.c (make_image, search_image_cache, lookup_image)
4612 (xpm_put_color_table_h):
4613 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4614 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4615 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4616 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4617 * alloc.c (allocate_vectorlike):
4618 Check for overflow in vector size calculations.
4619 * ccl.c (ccl_driver):
4620 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4621 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4622 need to be updated by these changes.
40087514
PE
4623 * fns.c (make_hash_table, maybe_resize_hash_table):
4624 Check for integer overflow with large hash tables.
0de4bb68
PE
4625 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4626 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4627 (SXHASH_REDUCE): New macro.
4628 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4629 Use it instead of discarding useful hash info with large hash values.
4630 (sxhash_float): New function.
4631 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4632 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4633 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4634 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4635 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4636 Adjust signatures to match updated version of code.
4637 (consing_since_gc): Now EMACS_INT, since a single hash table can
4638 use more than INT_MAX bytes.
4639
698d32e2
DN
46402011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4641
4642 Make it possible to build with GCC-4.6+ -O2 -flto.
4643
4644 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4645
fd6fa53f
SM
46462011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4647
4648 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4649 Call minibuffer-inactive-mode.
4650
864db017
JB
46512011-05-31 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4654 Update dependencies.
4655
2ad0baf4
DN
46562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4657
4658 * data.c (init_data): Remove code for UTS, this system is not
4659 supported anymore.
4660
4fcc2638
DN
46612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4662
4663 Don't force ./temacs to start in terminal mode.
4664
4665 * frame.c (make_initial_frame): Initialize faces in all cases, not
4666 only when CANNOT_DUMP is defined.
4667 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4668
c56e0fd5
DN
46692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4670
4671 * dispnew.c (add_window_display_history): Use const for the string
4672 pointer. Remove declaration, not needed.
4673
333d54da 46742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4675
55d4c1b2 4676 Use 'inline', not 'INLINE'.
333d54da 4677 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4678 * alloc.c, fontset.c (INLINE): Remove.
4679 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4680 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4681 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4682 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4683 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4684
738db178
DN
46852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4686
4687 Make it possible to run ./temacs.
4688
4689 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4690 syms_of_callproc does the same thing. Remove test for
4691 "initialized", do it in the caller.
4692 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4693
620c53a6
SM
46942011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4695
4696 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4697 (read_minibuf): Use get_minibuffer.
4698 (syms_of_minibuf): Use DEFSYM.
4699 (Qmetadata): New var.
4700 * data.c (Qbuffer): Don't make it static.
4701 (syms_of_data): Use DEFSYM.
4702
e003a292
PE
47032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4704
4705 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4706 (CCL_CODE_MIN): New macro.
4707
ed008a6d
PE
47082011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4709
3687c2ef
PE
4710 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4711
ed008a6d
PE
4712 * eval.c (Qdebug): Now static.
4713 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4714 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4715 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4716
d66c4c7c
CY
47172011-05-29 Chong Yidong <cyd@stupidchicken.com>
4718
4719 * image.c: Various fixes to ImageMagick code comments.
4720 (Fimagemagick_types): Doc fix.
4721
5fbc2025
PE
47222011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4723
0196f88a
PE
4724 Minor fixes prompted by GCC 4.6.0 warnings.
4725
4726 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4727
5fbc2025
PE
4728 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4729 (x_clipboard_manager_save_all): Move extern decl to ...
4730 * xterm.h: ... here, so that it can be checked for consistency.
4731
1dd3c2d9
CY
47322011-05-29 Chong Yidong <cyd@stupidchicken.com>
4733
4734 * xselect.c (x_clipboard_manager_save_frame)
4735 (x_clipboard_manager_save_all): New functions.
4736 (Fx_clipboard_manager_save): Lisp function deleted.
4737
4738 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4739 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4740
4741 * xterm.h: Update prototype.
4742
5ba6571d
WX
47432011-05-28 William Xu <william.xwl@gmail.com>
4744
4745 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4746 exiting (Bug#8239).
4747
3eaff834
JM
47482011-05-28 Jim Meyering <meyering@redhat.com>
4749
e1900994 4750 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4751 * fns.c (to_uchar): Define.
4752 (crypto_hash_function): Use it to convert some newly-signed
4753 variables to unsigned, to avoid sign-extension bugs. For example,
4754 without this change, (md5 "truc") would evaluate to
4755 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4756 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4757 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4758
0f6990a7
PE
47592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4760
4761 Integer overflow fixes.
c8a9ca5a 4762
08686060
PE
4763 * dbusbind.c: Serial number integer overflow fixes.
4764 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4765 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4766 to hold a serial number that is too large for a fixnum.
4767 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4768 Check for serial numbers out of range. Decode any serial number
59568bf0 4769 that was so large that it became a float. (Bug#8722)
08686060 4770
2d1fc3c7
PE
4771 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4772 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4773 Use XFASTINT rather than XUINT when numbers are nonnegative.
4774 (xd_append_arg, Fdbus_method_return_internal):
4775 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4776 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4777 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4778 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4779 (Bug#8722)
2d1fc3c7 4780
c8a9ca5a
PE
4781 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4782
519e1d69
PE
4783 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4784
30569699
PE
4785 ccl: add integer overflow checks
4786 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4787 (IN_INT_RANGE): New macros.
4788 (ccl_driver): Use them to check for integer overflow when
4789 decoding a CCL program. Many of the new checks are whether XINT (x)
4790 fits in int; it doesn't always, on 64-bit hosts. The new version
4791 doesn't catch all possible integer overflows, but it's an
847044ea 4792 improvement. (Bug#8719)
30569699 4793
c11285dc
PE
4794 * alloc.c (make_event_array): Use XINT, not XUINT.
4795 There's no need for unsigned here.
4796
fdccd48e
PE
4797 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4798 This follows up to the 2011-05-06 change that substituted uintptr_t
4799 for EMACS_INT. This case wasn't caught back then.
4800
37910ab2
PE
4801 Rework Fformat to avoid integer overflow issues.
4802 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4803 now (part of C89). Include <verify.h>.
4804 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4805 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4806 (Fformat): Avoid the prepass trying to compute sizes; it was only
4807 approximate and thus did not catch overflow reliably. Instead, walk
4808 through the format just once, formatting and computing sizes as we go,
4809 checking for integer overflow at every step, and allocating a larger
4810 buffer as needed. Keep track separately whether the format is
4811 multibyte. Keep only the most-recently calculated precision, rather
4812 than them all. Record whether each argument has been converted to
4813 string. Use EMACS_INT, not int, for byte and char and arg counts.
4814 Support field widths and precisions larger than INT_MAX. Avoid
4815 sprintf's undefined behavior with conversion specifications such as %#d
4816 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4817 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4818 formatting out-of-range floating point numbers with int
9173deec 4819 formats. (Bug#8668)
37910ab2 4820
2e6578fb
PE
4821 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4822
0ae6bdee
PE
4823 * data.c: Avoid integer truncation in expressions involving floats.
4824 * data.c: Include <intprops.h>.
4825 (arith_driver): When there's an integer overflow in an expression
4826 involving floating point, convert the integers to floating point
4827 so that the resulting value does not suffer from catastrophic
4828 integer truncation. For example, on a 64-bit host (* 4
4829 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4830 Do not rely on undefined behavior after integer overflow.
4831
de883a70
PE
4832 merge count_size_as_multibyte, parse_str_to_multibyte
4833 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4834 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4835 Check for integer overflow.
4836 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4837 since it's now a duplicate of the other. This is more of
4838 a character than a buffer op, so better that it's in character.c.
4839 * fns.c, print.c: Adjust to above changes.
4840
2ff916cb
PE
48412011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4842
4843 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4844
f1b54466
PE
48452011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4846
fb1ac845
PE
4847 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4848 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4849 (x_clipboard_manager_save): Now static.
4850 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4851
f1b54466
PE
4852 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4853 (crypto_hash_function): Now static.
4854 Fix pointer signedness problems. Avoid unnecessary initializations.
4855
a9f737ee
CY
48562011-05-27 Chong Yidong <cyd@stupidchicken.com>
4857
4858 * termhooks.h (Vselection_alist): Make it terminal-local.
4859
4860 * terminal.c (create_terminal): Initialize it.
4861
4862 * xselect.c: Support for clipboard managers.
4863 (Vselection_alist): Move to termhooks.h as terminal-local var.
4864 (LOCAL_SELECTION): New macro.
4865 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4866 (symbol_to_x_atom): Remove gratuitous arg.
4867 (x_handle_selection_request, lisp_data_to_selection_data)
4868 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4869 (x_own_selection, x_get_local_selection, x_convert_selection):
4870 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4871 (some_frame_on_display): Delete unused function.
4872 (Fx_own_selection_internal, Fx_get_selection_internal)
4873 (Fx_disown_selection_internal, Fx_selection_owner_p)
4874 (Fx_selection_exists_p): New optional frame arg.
4875 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4876 (x_handle_selection_clear): Don't treat other terminals with the
4877 same keyboard specially. Use the terminal-local Vselection_alist.
4878 (x_clear_frame_selections): Use Frun_hook_with_args.
4879
4880 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4881
4882 * xterm.h: Add support for those atoms.
4883
e067f0c1
CY
48842011-05-26 Chong Yidong <cyd@stupidchicken.com>
4885
4886 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4887 (converted_selections, conversion_fail_tag): New global variables.
4888 (x_selection_request_lisp_error): Free the above.
4889 (x_get_local_selection): Remove unnecessary code.
4890 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4891 of converted selections stored in converted_selections.
4892 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4893 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4894 (x_convert_selection): New function.
4895 (x_handle_selection_event): Simplify.
4896 (x_get_foreign_selection): Don't ignore incoming requests while
4897 waiting for an answer; this will fail when we implement
4898 SAVE_TARGETS, and seems unnecessary anyway.
4899 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4900 (Vx_sent_selection_functions): Doc fix.
4901
0f4aebc0
LL
49022011-05-26 Leo Liu <sdl.web@gmail.com>
4903
4904 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4905
e61124cd
YM
49062011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4907
4908 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4909
4910 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4911 for fringe update if it has periodic bitmap.
ac389d0c 4912 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4913 and fringe_bitmap_periodic_p.
4914
4915 * fringe.c (get_fringe_bitmap_data): New function.
4916 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4917 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4918 row. Mark glyph row for fringe update if periodicity changed.
4919
4920 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4921 for fringe update unless it has periodic bitmap.
4922
f16d9837
KH
49232011-05-25 Kenichi Handa <handa@m17n.org>
4924
4925 * xdisp.c (get_next_display_element): Set correct it->face_id for
4926 a static composition.
4927
e1b90ef6
LL
49282011-05-24 Leo Liu <sdl.web@gmail.com>
4929
4930 * deps.mk (fns.o):
4931 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4932
4933 * fns.c (crypto_hash_function, Fsha1): New function.
4934 (Fmd5): Use crypto_hash_function.
4935 (syms_of_fns): Add Ssha1.
4936
7400048f
PE
49372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4938
4939 * gnutls.c: Remove unused macros.
4940 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4941 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4942 Remove macros that are defined and never used.
4943 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4944
abb71cf4
CY
49452011-05-22 Chong Yidong <cyd@stupidchicken.com>
4946
4947 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4948 (Fx_get_selection_internal): Minor cleanup.
4949 (Fx_own_selection_internal): Rename arguments for consistency with
4950 select.el.
4951
6307db39
PE
49522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4953
4954 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4955
f3d4e0a4
CY
49562011-05-22 Chong Yidong <cyd@stupidchicken.com>
4957
4958 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4959
4d8ade89
YM
49602011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4961
4962 * dispnew.c (scrolling_window): Don't exclude the case that the
4963 last enabled row in the desired matrix touches the bottom boundary.
4964
32078c8d
GM
49652011-05-21 Glenn Morris <rgm@gnu.org>
4966
4967 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4968 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4969 and add some more files.
32078c8d 4970
7285dc67
EZ
49712011-05-20 Eli Zaretskii <eliz@gnu.org>
4972
4973 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4974 report_file_error introduced by the change from 2011-05-07.
4975
89d1bd22
PE
49762011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4977
4978 * systime.h (Time): Define only if emacs is defined.
4979 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4980 where the include path doesn't have X11/X.h by default. See
4981 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4982
e23640bb 49832011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4984
4985 * composite.c (find_automatic_composition): Fix previous change.
4986
b9704ad9
GM
49872011-05-20 Glenn Morris <rgm@gnu.org>
4988
4989 * lisp.mk: New file, split from Makefile.in.
4990 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4991 (shortlisp): Remove.
4992 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4993
4a720484
GM
49942011-05-19 Glenn Morris <rgm@gnu.org>
4995
4996 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4997 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4998 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4999 (lisp): Set the order to that of loadup.el.
5000 (shortlisp): Make it a copy of $lisp.
5001 (SOME_MACHINE_LISP): Remove.
5002 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5003 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5004
a28d4396
KH
50052011-05-18 Kenichi Handa <handa@m17n.org>
5006
5007 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5008 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5009 (find_automatic_composition): Mostly rewrite for efficiency.
5010
a2b1fa8e
JB
50112011-05-18 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * makefile.w32-in: Update dependencies.
5014
8e1f5610
CS
50152011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5016
5017 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5018 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5019
7025ee00 50202011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5021
cdfa6eab
PE
5022 Fix some integer overflow issues, such as string length overflow.
5023
06d6db33
PE
5024 * insdel.c (count_size_as_multibyte): Check for string overflow.
5025
2b4560a8
PE
5026 * character.c (lisp_string_width): Check for string overflow.
5027 Use EMACS_INT, not int, for string indexes and lengths; in
5028 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5029 the resulting string length overflows an EMACS_INT; instead,
5030 report a string overflow if no precision given. When checking for
5031 precision exhaustion, use a check that cannot possibly have
5032 integer overflow. (Bug#8675)
5033 * character.h (lisp_string_width): Adjust to new signature.
5034
cb93f9be
PE
5035 * alloc.c (string_overflow): New function.
5036 (Fmake_string): Use it. This doesn't change behavior, but saves
5037 a few bytes and will simplify future changes.
5038 * character.c (string_escape_byte8): Likewise.
5039 * lisp.h (string_overflow): New decl.
5040
1a1f3366
PE
5041 Fixups, following up to the user-interface timestamp change.
5042 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5043 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5044 * msdos.c (mouse_get_pos): Likewise.
5045 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5046 * w32gui.h (Time): Define by including "systime.h" rather than by
5047 declaring it ourselves. (Bug#8664)
5048
d4e3e4d3
PE
5049 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5050 * image.c (clear_image_cache): Likewise.
5051
f6a24d19
PE
5052 * term.c (term_mouse_position): Don't assume time_t wraparound.
5053
08dc5ae6
PE
5054 Be more systematic about user-interface timestamps.
5055 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5056 and sometimes 'EMACS_UINT', to represent these timestamps.
5057 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5058 This makes the code easier to follow, and makes it easier to catch
5059 integer overflow bugs such as Bug#8664.
5060 * frame.c (Fmouse_position, Fmouse_pixel_position):
5061 Use Time, not unsigned long, for user-interface timestamps.
5062 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5063 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5064 * keyboard.h (last_event_timestamp): Likewise.
5065 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5066 * menu.h (xmenu_show): Likewise.
5067 * term.c (term_mouse_position): Likewise.
5068 * termhooks.h (struct input_event.timestamp): Likewise.
5069 (struct terminal.mouse_position_hook): Likewise.
5070 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5071 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5072 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5073 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5074 what it was before.
5075 * menu.h, termhooks.h: Include "systime.h", for Time.
5076
8e55734a
PE
5077 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5078 Don't assume that the difference between two unsigned long values
5079 can fit into an integer. At this point, we know button_down_time
5080 <= event->timestamp, so the difference must be nonnegative, so
5081 there's no need to cast the result if double-click-time is
5082 nonnegative, as it should be; check that it's nonnegative, just in
5083 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5084 apart (about 25 days). (Bug#8664)
8e55734a 5085
841f1b75 5086 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5087 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5088
3e26f69c
PE
5089 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5090 that always fit in int. Use a sentinel instead of a counter, to
5091 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5092 * frame.h (struct frame): Use int for menu_bar_items_used
5093 instead of EMACS_INT, since it always fits in int.
3e26f69c 5094
5cc152c0
PE
5095 * menu.c (grow_menu_items): Check for int overflow.
5096
d89eb65e
PE
5097 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5098
5235bd3e
PE
5099 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5100 Before, the code was not consistent. These values cannot exceed
5101 2**31 - 1 so there's no need to make them unsigned.
5102 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5103 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5104 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5105 as modifiers.
5106 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5107
bc827e23
PE
5108 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5109 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5110 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5111 presumably because the widths might not match.
5112
78eb494e
PE
5113 * window.c (size_window): Avoid needless test at loop start.
5114
04f2d78b
CB
51152011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5116
5117 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5118
d2fc7e3d 51192011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5120
5121 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5122
d2fc7e3d 51232011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5124
5125 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5126 `width' to `bar_area_x' and `bar_area_width', respectively.
5127 (x_scroll_run): Take account of fringe background extension.
5128
04f2d78b
CB
5129 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5130 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5131 `bar_area_width', respectively.
5132 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5133 background extension.
5134
79b70037
GM
51352011-05-10 Jim Meyering <meyering@redhat.com>
5136
5137 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5138
2f142cc5
JB
51392011-05-10 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * image.c (Finit_image_library): Return t for built-in image types,
5142 like pbm and xbm. (Bug#8640)
5143
57679c86
AS
51442011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5145
5146 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5147
888c9e86
EZ
51482011-05-07 Eli Zaretskii <eliz@gnu.org>
5149
b0512a1d
EZ
5150 * w32console.c (Fset_screen_color): Doc fix.
5151 (Fget_screen_color): New function.
5152 (syms_of_ntterm): Defsubr it.
5153
7285dc67
EZ
5154 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5155 unlink the temporary file if Fcall_process didn't create it in the
5156 first place.
5157 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5158 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5159 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5160 cue to call_process_cleanup not to close that handle.
5161
4d3fcc8e
BK
51622011-05-07 Ben Key <bkey76@gmail.com>
5163
5164 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5165 one of two shell specific rules, either bootstrap-temacs-CMD or
5166 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5167 to the previous implementation of the bootstrap-temacs rule.
5168 The bootstrap-temacs-CMD rule is similar to the previous
5169 implementation of the bootstrap-temacs rule except that it
5170 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5171 variable.
5172
5173 These changes, along with some changes to nt/configure.bat,
5174 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5175 earlier fix to add support for --cflags and --ldflags options
5176 that include quotes so that it works whether make uses cmd or
5177 sh as the shell.
5178
b4289b64
MA
51792011-05-06 Michael Albinus <michael.albinus@gmx.de>
5180
5181 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5182 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5183 is a constant.
5184 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5185 a string. Handle both cases.
5186 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5187 (Fdbus_register_method): Use Qinvalid_function.
5188
af4c0e28
JB
51892011-05-06 Juanma Barranquero <lekktu@gmail.com>
5190
5191 * makefile.w32-in: Update dependencies.
5192 (LISP_H): Add inttypes.h and stdin.h.
5193 (PROCESS_H): Add unistd.h.
5194
c51453d9
EZ
51952011-05-06 Eli Zaretskii <eliz@gnu.org>
5196
5197 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5198 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5199
8ff0ac3c 52002011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5201
4c4b566b
PE
5202 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5203
aab2b9b5
PE
5204 * term.c (vfatal): Remove stray call to va_end.
5205 It's not needed and the C Standard doesn't allow it here anyway.
5206
c378da0b
PE
5207 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5208 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5209
288b08c7
PE
5210 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5211 bytes.
5212
e3601888
PE
5213 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5214
db6c0e74
PE
5215 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5216
dd5963ea
PE
5217 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5218
88c9450f
PE
5219 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5220
2f9442b8
PE
5221 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5222
c032b5f8
PE
5223 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5224 * charset.c (Fdefine_charset_internal): Don't initialize
5225 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5226 32-bit int (Bug#8600).
a108c10b
PE
5227
5228 * lread.c (read_integer): Be more consistent with string-to-number.
5229 Use string_to_number to do the actual conversion; this avoids
5230 rounding errors and fixes some other screwups. Without this fix,
5231 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5232 (digit_to_number): Move earlier, for benefit of read_integer.
5233 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5234 not a digit in any supported base. (Bug#8602)
a108c10b 5235
ad5f9eea
PE
5236 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5237
aec1708a
PE
5238 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5239 to match comment at start of function. This also removes a
5240 GCC warning about overflow in a 32+64-bit port.
5241
47be4ab5
PE
5242 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5243
371cac43
PE
5244 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5245 Reported by Stefan Monnier in
5246 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5247 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5248 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5249
d01a7826
PE
5250 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5251 (EMACS_UINTPTR): Likewise, with uintptr_t.
5252
7fd47d5c
PE
5253 * lisp.h: Prefer 64-bit EMACS_INT if available.
5254 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5255 on 32-bit hosts that have 64-bit int, so that they can access
5256 large files.
122b0c86
PE
5257 However, temporarily disable this change unless the temporary
5258 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5259
8727937b
PE
5260 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5261
8ac068ac
PE
5262 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5263 This removes an assumption that EMACS_INT and long are the same
5264 width as pointers. The assumption is true for Emacs porting targets
5265 now, but we want to make other targets possible.
5266 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5267 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5268 In the rest of the code, change types of integers that hold casted
5269 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5270 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5271 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5272 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5273 No need to cast type when ORing.
5274 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5275 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5276 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5277 assume EMACS_INT is the same width as char *.
5278 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5279 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5280 Remove no-longer-needed casts.
5281 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5282 (xg_tool_bar_help_callback, xg_make_tool_item):
5283 Use EMACS_INTPTR to hold an integer
5284 that will be cast to void *; this can avoid a GCC warning
5285 if EMACS_INT is not the same width as void *.
5286 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5287 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5288 (current_message_1, set_message_1):
5289 Use a local to convert to proper width without a cast.
5290 * xmenu.c (dialog_selection_callback): Likewise.
5291
ede49d71
PE
5292 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5293 Also, don't assume VALBITS / RAND_BITS is less than 5,
5294 and don't rely on undefined behavior when shifting a 1 left into
5295 the sign bit.
5296 * lisp.h (get_random): Change signature to match.
5297
2f30ecd0
PE
5298 * lread.c (hash_string): Use size_t, not int, for hash computation.
5299 Normally we prefer signed values; but hashing is special, because
5300 it's better to use unsigned division on hash table sizes so that
5301 the remainder is nonnegative. Also, size_t is the natural width
5302 for hashing into memory. The previous code used 'int', which doesn't
5303 retain enough info to hash well into very large tables.
5304 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5305
2a866e7b
PE
5306 * dbusbind.c: Don't possibly lose pointer info when converting.
5307 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5308 Use XPNTR rather than XHASH, so that the high-order bits of
5309 the pointer aren't lost when converting through void *.
5310
51639eac
PE
5311 * eval.c (Fautoload): Don't double-shift a pointer.
5312
92394119
PE
5313 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5314
dbdb9a7c
JB
53152011-05-06 Juanma Barranquero <lekktu@gmail.com>
5316
5317 * gnutls.c (DEF_GNUTLS_FN):
5318 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5319
db7a0b4f
AS
53202011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5321
5322 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5323 marker. (Bug#8610)
5324
f7ff1b0f 53252011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5326
5327 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5328 New version that can reserve upto 2GB of heap space.
5329
f7ff1b0f 53302011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5331
5332 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5333
639c109b
TZ
53342011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5335
5336 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5337 `gnutls_certificate_set_x509_key_file'.
5338
d2127135
JB
53392011-05-05 Juanma Barranquero <lekktu@gmail.com>
5340
5341 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5342 Update dependencies.
5343
e968f4f3
JB
53442011-05-04 Juanma Barranquero <lekktu@gmail.com>
5345
5346 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5347 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5348 Remove unused parameter `fildes'.
5349 * process.c (read_process_output, send_process): Don't pass it.
5350
84d358f0
JB
53512011-05-04 Juanma Barranquero <lekktu@gmail.com>
5352
5353 Fix previous change: the library cache is defined in w32.c.
5354 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5355 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5356
0898ca10
JB
53572011-05-04 Juanma Barranquero <lekktu@gmail.com>
5358
5359 Implement dynamic loading of GnuTLS on Windows.
5360
5361 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5362 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5363 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5364 Declare.
5365
5366 * gnutls.c (Qgnutls_dll): Define.
5367 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5368 (gnutls_*): Declare function pointers.
5369 (init_gnutls_functions): New function to initialize function pointers.
5370 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5371 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5372 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5373 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5374 (emacs_gnutls_write, emacs_gnutls_read)
5375 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5376 (Fgnutls_available_p): New function.
5377 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5378 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5379 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5380
5381 * image.c: Include w32.h.
5382 (Vimage_type_cache): Delete.
5383 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5384 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5385 (w32_delayed_load): Move to w32.c.
5386
5387 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5388
5389 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5390 (w32_delayed_load): Move from image.c. When loading a library, record
5391 its filename in the :loaded-from property of the library id.
5392 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5393 Initialize and staticpro them.
5394 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5395
5396 * process.c: Include lisp.h before w32.h, not after.
5397 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5398 instead of gnutls_record_check_pending.
5399
5400 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5401
ff4de4aa
TZ
54022011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5403
5404 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5405 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5406 as passed in.
5407
abe95abb
JD
54082011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5409
5410 * xterm.c (x_set_frame_alpha): Do not set property on anything
5411 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5412
e16e55d4
JB
54132011-05-02 Juanma Barranquero <lekktu@gmail.com>
5414
5415 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5416
bafcf6a5
JB
54172011-05-02 Juanma Barranquero <lekktu@gmail.com>
5418
5419 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5420 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5421 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5422 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5423 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5424 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5425 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5426 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5427 (Qgnutls_bootprop_callbacks_verify): Make static.
5428
e7a6747f
AS
54292011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5430
19ed11ba
AS
5431 * callproc.c: Indentation fixup.
5432
e7a6747f 5433 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5434 (wait_for_termination, interruptible_wait_for_termination):
5435 Move after wait_for_termination_1.
e7a6747f 5436
1ef14cb4
LMI
54372011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5438
5439 * sysdep.c (interruptible_wait_for_termination): New function
5440 which is like wait_for_termination, but allows keyboard
5441 interruptions.
5442
5443 * callproc.c (Fcall_process): Add (:file "file") as an option for
5444 the STDOUT buffer.
5445 (Fcall_process_region): Ditto.
5446
330d880c
EZ
54472011-04-30 Eli Zaretskii <eliz@gnu.org>
5448
8db90b73
EZ
5449 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5450 rather than `XVECTOR (FOO)->size'.
5451
330d880c
EZ
5452 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5453 inttypes.h, as a gnulib replacement is used if it not available in
5454 system headers.
5455
15cbd324
EZ
54562011-04-21 Eli Zaretskii <eliz@gnu.org>
5457
5458 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5459 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5460 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5461
5462 * coding.c (coding_alloc_by_realloc): Error out if destination
5463 will grow beyond MOST_POSITIVE_FIXNUM.
5464 (decode_coding_emacs_mule): Abort if there isn't enough place in
5465 charbuf for the composition carryover bytes. Reserve an extra
5466 space for up to 2 characters produced in a loop.
5467 (decode_coding_iso_2022): Abort if there isn't enough place in
5468 charbuf for the composition carryover bytes.
5469
54702011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5471
ae940cca
EZ
5472 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5473 aborting when %lld or %lll format is passed.
5474 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5475 %llo or %llx format is passed. (Bug#8545)
5476
03ab8921
EZ
5477 * window.c (window_scroll_line_based): Use a marker instead of
5478 simple variables to record original value of point. (Bug#7952)
5479
afda1437
EZ
5480 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5481 produced by %s or %c overflows available buffer space. (Bug#8545)
5482
f76dee0c
PE
54832011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5484
5485 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5486 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5487
fdc5744d
JB
54882011-04-28 Juanma Barranquero <lekktu@gmail.com>
5489
5490 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5491
638f053a
JB
54922011-04-28 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * keyboard.c (Qdelayed_warnings_hook): Define.
5495 (command_loop_1): Run `delayed-warnings-hook'
5496 if Vdelayed_warnings_list is non-nil.
5497 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5498 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5499
d178f871
EZ
55002011-04-28 Eli Zaretskii <eliz@gnu.org>
5501
5502 * doprnt.c (doprnt): Don't return value smaller than the buffer
5503 size if the message was truncated. (Bug#8545).
5504
b124fd93
JB
55052011-04-28 Juanma Barranquero <lekktu@gmail.com>
5506
5507 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5508 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5509
e810457d
PE
55102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5511
5512 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5513
ea51cceb
JB
55142011-04-27 Juanma Barranquero <lekktu@gmail.com>
5515
5516 * makefile.w32-in: Update dependencies.
5517
94dcfacf
EZ
55182011-04-27 Eli Zaretskii <eliz@gnu.org>
5519
5520 Improve `doprnt' and its usage. (Bug#8545)
5521 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5522 `format_end'. Remove support for %l as a conversion specifier.
5523 Don't use xrealloc. Improve diagnostics when the %l size modifier
5524 is used. Update the commentary.
5525
5526 * eval.c (verror): Simplify calculation of size_t.
5527
5528 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5529 messages.
5530
f61f41d7
PE
55312011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5532
5533 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5534 change.
5535
96fb4434
PE
55362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5537
5538 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5539 This makes this file independent of the recent pseudovector change.
5540
671875da 55412011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5542
69e9b5a3
PE
5543 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5544
b5f869a7 5545 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5546 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5547 Remove unused local.
c8926152 5548 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5549
841a1577 5550 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5551 GCC 4.6.0 optimizes based on type-based alias analysis.
5552 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5553 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5554 != &v->size, and therefore "v->size = 1; b->size = 2; return
5555 v->size;" must therefore return 1. This assumption is incorrect
5556 for Emacs, since it type-puns struct Lisp_Vector * with many other
5557 types. To fix this problem, this patch adds a new type struct
f904488f 5558 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5559 and pseudovectors, and helps optimizing compilers not get fooled
5560 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5561 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5562 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5563 the size member.
eab3844f
PE
5564 (XSETPVECTYPE): Rewrite in terms of new macro.
5565 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5566 This is a bit clearer, and further avoids the possibility of
5567 undesirable aliasing.
5568 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5569 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5570 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5571 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5572 (ASIZE): Now uses header.size rather than size.
5573 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5574 to avoid the hassle of writing XVECTOR (foo)->header.size.
5575 (struct vectorlike_header): New type.
eab3844f
PE
5576 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5577 object, to help avoid aliasing.
5578 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5579 (SUBRP): Likewise, since Lisp_Subr is a special case.
5580 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5581 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5582 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5583 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5584 changed to be "header.size" and "header.next".
5585 * buffer.h (struct buffer): Likewise.
5586 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5587 * frame.h (struct frame): Likewise.
5588 * process.h (struct Lisp_Process): Likewise.
5589 * termhooks.h (struct terminal): Likewise.
5590 * window.c (struct save_window_data, struct saved_window): Likewise.
5591 * window.h (struct window): Likewise.
5592 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5593 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5594 * buffer.c (init_buffer_once): Likewise.
5595 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5596 special case.
5597 * process.c (Fformat_network_address): Use local var for size,
5598 for brevity.
5599
0df1eac5
PE
5600 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5601
847ab9d1 5602 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5603 * data.c (atof): Remove decl; no longer used or needed.
5604 (digit_to_number): Move to lread.c.
5605 (Fstring_to_number): Use new string_to_number function, to be
5606 consistent with how the Lisp reader treats infinities and NaNs.
5607 Do not assume that floating-point numbers represent EMACS_INT
5608 without losing information; this is not true on most 64-bit hosts.
5609 Avoid double-rounding errors, by insisting on integers when
5610 parsing non-base-10 numbers, as the documentation specifies.
5611 * lisp.h (string_to_number): New decl, replacing ...
5612 (isfloat_string): Remove.
bc0a5c13 5613 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5614 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5615 appears to have been a coding error. Similarly, do not accept
5616 strings like +-1e0 as floating point numbers. Do not report
5617 overflow for integer overflows unless the base is not 10 which
5618 means we have no simple and reliable way to continue.
5619 Break out the floating-point parsing into a new
5620 function string_to_number, so that Fstring_to_number parses
5621 floating point numbers consistently with the Lisp reader.
04f2d78b 5622 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5623 (E_CHAR, EXP_INT): Remove, replacing with ...
5624 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5625 (string_to_number): New function, replacing isfloat_string.
5626 This function checks for valid syntax and produces the resulting
5627 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5628 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5629 so that overflow for non-base-10 numbers is reported only when
5630 there's no portable and simple way to convert to floating point.
452f4150 5631
67769ffc
PE
5632 * textprop.c (set_text_properties_1): Rewrite for clarity,
5633 and to avoid GCC warning about integer overflow.
5634
c20db43f
PE
5635 * intervals.h (struct interval): Use EMACS_INT for members
5636 where EMACS_UINT might cause problems. See
5637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5638 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5639 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5640 All uses changed.
37aa2f85
PE
5641 (offset_intervals): Tell GCC not to worry about length overflow
5642 when negating a negative length.
c20db43f 5643
2538aa2f
PE
5644 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5645 (overrun_check_free): Likewise.
5646
f2d3008d
PE
5647 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5648 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5649 word size.
5650
ec8df744
PE
5651 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5652 (gnutls_make_error): Rename local to avoid shadowing.
5653 (gnutls_emacs_global_deinit): ifdef out; not used.
5654 (Fgnutls_boot): Use const for pointer to readonly storage.
5655 Comment out unused local. Fix pointer signedness problems.
5656
640ee02d
PE
5657 * lread.c (openp): Don't stuff size_t into an 'int'.
5658 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5659 about possible signed overflow.
5660
6048fb2a
PE
5661 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5662 (GDK_KEY_g): Don't define if already defined.
5663 (xg_prepare_tooltip): Avoid pointer signedness problem.
5664 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5665
fa3c87e1
PE
5666 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5667 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5668
2172544b
PE
5669 * xfns.c (Fx_window_property): Simplify a bit,
5670 to make a bit faster and to avoid GCC 4.6.0 warning.
5671 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5672
9b821a21
PE
5673 * fns.c (internal_equal): Don't assume size_t fits in int.
5674
3c616cfa
PE
5675 * alloc.c (compact_small_strings): Tighten assertion a little.
5676
c2982e87
PE
5677 Replace pEd with more-general pI, and fix some printf arg casts.
5678 * lisp.h (pI): New macro, generalizing old pEd macro to other
5679 conversion specifiers. For example, use "...%"pI"d..." rather
5680 than "...%"pEd"...".
5681 (pEd): Remove. All uses replaced with similar uses of pI.
5682 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5683 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5684 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5685 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5686 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5687 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5688 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5689 64-bit hosts.
5690 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5691 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5692 * print.c (safe_debug_print, print_object): Likewise.
5693 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5694 to int.
6f04d126
PE
5695 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5696 avoiding the 0 flag, which is not portable.
c2982e87
PE
5697 * process.c (Fmake_network_process): Use pI to avoid cast.
5698 * region-cache.c (pp_cache): Likewise.
5699 * xdisp.c (decode_mode_spec): Likewise.
5700 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5701 behavior on 64-bit hosts with printf arg.
6f04d126 5702 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5703 (x_stop_queuing_selection_requests): Likewise.
5704 (x_get_window_property): Don't truncate byte count to an 'int'
5705 when tracing.
0b432f21 5706
5e073ec7
PE
5707 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5708 here, since it parses constructs like leading '-' and spaces,
5709 which are not wanted; and it overflows with large numbers.
5710 Instead, simply match F[0-9]+, which is what is wanted anyway.
5711
36372bf9
PE
5712 * alloc.c: Remove unportable assumptions about struct layout.
5713 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5714 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5715 (allocate_vectorlike, make_pure_vector): Use the new macros,
5716 plus offsetof, to remove unportable assumptions about struct layout.
5717 These assumptions hold on all porting targets that I know of, but
5718 they are not guaranteed, they're easy to remove, and removing them
5719 makes further changes easier.
5720
0b432f21
PE
5721 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5722 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5723 (string_overrun_cookie): Now const. Use initializers that
5724 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5725 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5726 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5727 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5728 multiple of sizeof (EMACS_INT); it need not be, if
5729 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5730 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5731
895009e1
JB
57322011-04-26 Juanma Barranquero <lekktu@gmail.com>
5733
5734 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5735
6a7a1b0b
TZ
57362011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5737
5738 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5739 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5740 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5741
841a1577 57422011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5743
5744 * lisp.h (Qdebug): List symbol.
895009e1 5745 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5746 * keyboard.c (debug-on-event): New variable.
5747 (handle_user_signal): Break into debugger when debug-on-event
5748 matches the current signal symbol.
5749
f2d3ba6f
DN
57502011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5751
5752 * alloc.c (check_sblock, check_string_bytes)
5753 (check_string_free_list): Convert to standard C.
5754
42ce4c63
TZ
57552011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5756
5757 * w32.c (emacs_gnutls_push): Fix typo.
5758
825cd63c
EZ
57592011-04-25 Eli Zaretskii <eliz@gnu.org>
5760
fb11d64d
EZ
5761 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5762 "cast to pointer from integer of different size".
5763
825cd63c
EZ
5764 Improve doprnt and its use in verror. (Bug#8545)
5765 * doprnt.c (doprnt): Document the set of format control sequences
5766 supported by the function. Use SAFE_ALLOCA instead of always
5767 using `alloca'.
5768
5769 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5770 is one byte too soon. Don't use xrealloc; instead xfree and
5771 xmalloc anew.
5772
e061a11b
TZ
57732011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5774
5775 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5776 callbacks stage.
5777
5778 * gnutls.c: Renamed global_initialized to
5779 gnutls_global_initialized. Added internals for the
5780 :verify-hostname-error, :verify-error, and :verify-flags
5781 parameters of `gnutls-boot' and documented those parameters in the
5782 docstring. Start callback support.
9173deec
JB
5783 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5784 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5785 on error. Return error code.
e061a11b
TZ
5786 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5787 (emacs_gnutls_read): Likewise.
5788 (Fgnutls_boot): Return handshake error code.
5789 (emacs_gnutls_handle_error): New function.
5790 (wsaerror_to_errno): Likewise.
5791
5792 * w32.h (emacs_gnutls_pull): Add prototype.
5793 (emacs_gnutls_push): Likewise.
5794
5795 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5796 (emacs_gnutls_push): Likewise.
5797
57982011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5799
5800 * process.c (wait_reading_process_output): Check if GnuTLS
5801 buffered some data internally if no FDs are set for TLS
5802 connections.
5803
5804 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5805 (LIBS): Link to USER_LIBS.
5806 ($(BLD)/gnutls.$(0)): New target.
5807
fa6996bc
EZ
58082011-04-24 Eli Zaretskii <eliz@gnu.org>
5809
eb35682e
EZ
5810 * xdisp.c (handle_single_display_spec): Rename the
5811 display_replaced_before_p argument into display_replaced_p, to
5812 make it consistent with the commentary. Fix typos in the
5813 commentary.
5814
e2ad650c
EZ
5815 * textprop.c (syms_of_textprop): Remove dead code.
5816 (copy_text_properties): Delete obsolete commentary about an
5817 interface that was deleted long ago. Fix typos in the description
5818 of arguments.
5819
1b2de274
EZ
5820 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5821 to changes in oldXMenu/XMenu.h from 2011-04-16.
5822 <menu_help_message, prev_menu_help_message>: Constify.
5823 (IT_menu_make_room): menu->help_text is now `const char **';
5824 adjust.
5825
5826 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5827 to changes in oldXMenu/XMenu.h from 2011-04-16.
5828 (struct XMenu): Declare `help_text' `const char **'.
5829
5830 * xfaces.c <Qunspecified>: Make extern again.
5831
5832 * syntax.c: Include sys/types.h before including regex.h, as
5833 required by Posix.
5834
762b15be
EZ
5835 * doc.c (get_doc_string): Improve the format passed to `error'.
5836
5837 * doprnt.c (doprnt): Improve commentary.
5838
5839 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5840
5841 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5842 them with etags.
5843
f1052e5d
EZ
5844 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5845 changes in globals.h immediately force recompilation.
762b15be
EZ
5846 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5847 $(CURDIR)/s/ms-w32.h.
5848 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5849
fa6996bc
EZ
5850 * character.c (Fchar_direction): Function deleted.
5851 (syms_of_character): Don't defsubr it.
5852 <char-direction-table>: Deleted.
5853
e6c3da20
EZ
58542011-04-23 Eli Zaretskii <eliz@gnu.org>
5855
5856 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5857 * doprnt.c: Include limits.h.
5858 (SIZE_MAX): New macro.
04f2d78b
CB
5859 (doprnt): Return a size_t value. 2nd arg is now size_t.
5860 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5861 Improve overflow protection. Support `l' modifier for integer
5862 conversions. Support %l conversion. Don't assume an EMACS_INT
5863 argument for integer conversions and for %c.
5864
5865 * lisp.h (doprnt): Restore prototype.
5866
5867 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5868 $(SRC)/character.h.
5869
5870 * Makefile.in (base_obj): Add back doprnt.o.
5871
5872 * deps.mk (doprnt.o): Add back prerequisites.
5873 (callint.o): Depend on character.h.
5874
5875 * eval.c (internal_lisp_condition_case): Include the handler
5876 representation in the error message.
5877 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5878 when breaking from the loop.
5879
5880 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5881
5882 * callint.c (Fcall_interactively): When displaying error message
5883 about invalid control letter, pass the character's codepoint, not
5884 a pointer to its multibyte form. Improve display of the character
5885 in octal and display also its hex code.
5886
5887 * character.c (char_string): Use %x to display the (unsigned)
5888 codepoint of an invalid character, to avoid displaying a bogus
5889 negative value.
5890
5891 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5892 `error', not SYMBOL_NAME itself.
5893
5894 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5895 character arguments to `error'.
5896
5897 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5898 to `error' in error message about FINAL_CHAR argument. Make sure
5899 FINAL_CHAR is a character, and use %c when it is passed as
5900 argument to `error'.
5901
4ffd0d6b 59022011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5903
5904 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5905
5906 * w32.c: Include <time.h>.
5907 (sys_localtime): New function.
5908
4ffd0d6b 59092011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5910
5911 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5912
4ffd0d6b 5913 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5914
4ffd0d6b 59152011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5916
4ffd0d6b
GM
5917 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5918 zombies (Bug#8467).
aac0c6e3 5919
04c56954
EZ
59202011-04-19 Eli Zaretskii <eliz@gnu.org>
5921
5922 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5923 gl_state.e_property when gl_state.object is Qt.
5924
5925 * insdel.c (make_gap_larger): Remove limitation of buffer size
5926 to <= INT_MAX.
5927
16a43933
CY
59282011-04-18 Chong Yidong <cyd@stupidchicken.com>
5929
5930 * xdisp.c (lookup_glyphless_char_display)
5931 (produce_glyphless_glyph): Handle cons cell entry in
5932 glyphless-char-display.
5933 (Vglyphless_char_display): Document it.
5934
5935 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5936 glyphless-char-display.
5937
4581706e
CY
59382011-04-17 Chong Yidong <cyd@stupidchicken.com>
5939
5940 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5941
5942 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5943
5944 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5945 definition for no-X builds.
5946
4887c6e2 59472011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5948
fd35b6f9
PE
5949 Static checks with GCC 4.6.0 and non-default toolkits.
5950
5c1ccb01
PE
5951 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5952
006c5daa
PE
5953 * process.c (keyboard_bit_set): Define only if SIGIO.
5954 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5955 (send_process): Repair possible setjmp clobbering.
5956
efc736d3
PE
5957 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5958
4e2fe2e6
PE
5959 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5960
f97334a2
PE
5961 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5962
4e75f29d
PE
5963 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5964 Define only if needed.
5965
90efadd1
PE
5966 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5967 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5968 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5969
3c647824
PE
5970 * dispextern.h (struct redisplay_interface): Rename param
5971 to avoid shadowing.
e264f262 5972 * termhooks.h (struct terminal): Likewise.
761383f4 5973 * xterm.c (xembed_send_message): Likewise.
3c647824 5974
b58c5c4a
PE
5975 * insdel.c (make_gap_smaller): Define only if
5976 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5977
cad59032
PE
5978 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5979 it.
5980
c339dc2e
PE
5981 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5982 so that we aren't warned about unused symbols.
5983
91a3e27b
PE
5984 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5985
399c71d3 5986 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5987
8ffc96f5
PE
5988 * xfns.c (x_real_positions): Mark locals as initialized.
5989
eef9bc79
PE
5990 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5991
098db9dd
PE
5992 * xterm.c: Fix problems found by static analysis with other toolkits.
5993 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5994 (x_dispatch_event): Declare static if USE_GTK, and
5995 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5996 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5997 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5998 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5999 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6000
eb18f6cc
PE
6001 * xmenu.c (menu_help_callback): Pointer type fixes.
6002 Use const pointers when pointing at readonly data. Avoid pointer
6003 signedness clashes.
6004 (FALSE): Remove unused macro.
6005 (update_frame_menubar): Remove unused decl.
6006
1fe72bf8
PE
6007 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6008
60d9e1db
PE
6009 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6010 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6011 (single_menu_item): Rename local to avoid shadowing.
6012
39261c26
PE
6013 * keyboard.c (make_lispy_event): Remove unused local var.
6014
018c5e19
PE
6015 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6016 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6017
63d2b86e
PE
6018 * bitmaps: Change bitmaps from unsigned char back to the X11
6019 compatible char. Avoid the old compiler warnings about
6020 out-of-range initializers by using, for example, '\xab' rather
6021 than 0xab.
6022
aefd87e1
PE
6023 * xgselect.c (xgselect_initialize): Check vs interface
6024 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6025
bf501fb9
PE
6026 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6027
e9829fdf
PE
6028 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6029 to read-only memory.
6030
1086c095
PE
6031 * fns.c (vector): Remove; this old hack is no longer needed.
6032
2baccd04 6033 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6034 Remove unused var.
dde42981 6035 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6036
72391843 6037 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6038
436c16df 6039 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6040 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6041 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6042
92bb796d 6043 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6044 (x_term_init): Remove local to avoid shadowing.
92bb796d 6045
764430a3 6046 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6047
6048 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6049 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6050
d1dfb56c
EZ
60512011-04-16 Eli Zaretskii <eliz@gnu.org>
6052
c4354cb4
EZ
6053 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6054
d1dfb56c
EZ
6055 Fix regex.c, syntax.c and friends for buffers > 2GB.
6056 * syntax.h (struct gl_state_s): Declare character position members
6057 EMACS_INT.
6058
6059 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6060
04f2d78b
CB
6061 * textprop.c (verify_interval_modification, interval_of):
6062 Declare arguments EMACS_INT.
d1dfb56c
EZ
6063
6064 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6065 EMACS_INT.
6066
6067 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6068
6069 * indent.c (Fvertical_motion): Local variable it_start is now
6070 EMACS_INT.
6071
6072 * regex.c (re_match, re_match_2, re_match_2_internal)
6073 (bcmp_translate, regcomp, regexec, print_double_string)
6074 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6075 (re_compile_pattern, re_exec): Declare arguments and local
6076 variables `size_t' and `ssize_t' and return values `regoff_t', as
6077 appropriate.
6078 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6079 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6080 <compile_stack_type>: `size' and `avail' are now `size_t'.
6081
6082 * regex.h <regoff_t>: Use ssize_t, not int.
6083 (re_search, re_search_2, re_match, re_match_2): Arguments that
6084 specify buffer/string position and length are now ssize_t and
6085 size_t. Return type is regoff_t.
6086
613052cd
BK
60872011-04-16 Ben Key <bkey76@gmail.com>
6088
6089 * nsfont.m: Fixed bugs in ns_get_family and
6090 ns_descriptor_to_entity that were caused by using free to
6091 deallocate memory blocks that were allocated by xmalloc (via
6092 xstrdup). This caused Emacs to crash when compiled with
6093 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6094 --enable-checking=xmallocoverrun). xfree is now used to
6095 deallocate these memory blocks.
6096
4170f62f 60972011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6098
71b41406
PE
6099 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6100
9587a89d
PE
6101 emacs_write: Accept and return EMACS_INT for sizes.
6102 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6103 et seq.
6104 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6105 Accept and return EMACS_INT.
6106 (emacs_gnutls_write): Return the number of bytes written on
6107 partial writes.
6108 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6109 (emacs_read, emacs_write): Remove check for negative size, as the
6110 Emacs source code has been audited now.
9587a89d
PE
6111 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6112 (emacs_read, emacs_write): Use it.
273a5f82
PE
6113 * process.c (send_process): Adjust to the new signatures of
6114 emacs_write and emacs_gnutls_write. Do not attempt to store
6115 a byte offset into an 'int'; it might overflow.
9587a89d 6116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6117
3e047f51
PE
6118 * sound.c: Don't assume sizes fit in 'int'.
6119 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6120 Return EMACS_INT, not int.
3e047f51 6121 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6122 Accept EMACS_INT, not int.
6123 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6124 record read return values.
6125
cc39a9db
BK
61262011-04-15 Ben Key <bkey76@gmail.com>
6127
c9d0ec6d
JB
6128 * keyboard.c (Qundefined): Don't declare static since it is used
6129 in nsfns.m.
6130 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6131 static since they are used in nsfont.m.
cc39a9db 6132
6c60eb9f
SM
61332011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6134
6135 * process.c (Qprocessp): Don't declare static.
6136 * lisp.h (Qprocessp): Declare again.
6137
7990b61a
JB
61382011-04-15 Juanma Barranquero <lekktu@gmail.com>
6139
6140 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6141
5d4cb038
PE
61422011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6143
8bd7b830 6144 Improve C-level modularity by making more things 'static'.
cd64ea1d 6145
e3b27b31
PE
6146 Don't publish debugger-only interfaces to other modules.
6147 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6148 (verify_bytepos, count_markers): Move decls to the only modules
6149 that need them.
6150 * region-cache.h (pp_cache): Likewise.
6151 * window.h (check_all_windows): Likewise.
6152 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6153
5d4cb038
PE
6154 * sysdep.c (croak): Now static, if
6155 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6156 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6157
6158 * alloc.c (refill_memory_reserve): Now static if
6159 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6160 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6161
e87b6180
PE
6162 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6163 Define only if USE_LUCID.
6164
ac64929e
PE
6165 * xrdb.c (x_customization_string, x_rm_string): Now static.
6166
6f37259d
PE
6167 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6168 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6169
1683e3ab
PE
6170 * xdisp.c (draw_row_with_mouse_face): Now static.
6171 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6172
de9c2632
PE
6173 * window.h (check_all_windows): Mark externally visible.
6174
2b96acb7
PE
6175 * window.c (window_deletion_count): Now static.
6176
6177 * undo.c: Make symbols static if they're not exported.
6178 (last_undo_buffer, last_boundary_position, pending_boundary):
6179 Now static.
6180
50436f33
PE
6181 * textprop.c (interval_insert_behind_hooks): Now static.
6182 (interval_insert_in_front_hooks): Likewise.
6183
64520e5c
PE
6184 * term.c: Make symbols static if they're not exported.
6185 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6186 (max_frame_lines, tty_set_terminal_modes):
6187 (tty_reset_terminal_modes, tty_turn_off_highlight):
6188 (get_tty_terminal): Now static.
6189 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6190 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6191 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6192 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6193 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6194
1fa53021
PE
6195 * sysdep.c: Make symbols static if they're not exported.
6196 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6197 Now static.
6198 (sigprocmask_set, full_mask): Remove; unused.
6199 (wait_debugging): Mark as visible.
6200 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6201 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6202
d4b43b22
PE
6203 * syntax.c (syntax_temp): Define only if !__GNUC__.
6204
b7c513d0
PE
6205 * sound.c (current_sound_device, current_sound): Now static.
6206
989b29ad
PE
6207 * search.c (searchbufs, searchbuf_head): Now static.
6208
13a55a78
PE
6209 * scroll.c (scroll_cost): Remove; unused.
6210 * dispextern.h (scroll_cost): Remove decl.
6211
de68a1fc
PE
6212 * region-cache.h (pp_cache): Mark as externally visible.
6213
40ccffa6
PE
6214 * process.c: Make symbols static if they're not exported.
6215 (process_tick, update_tick, create_process, chan_process):
6216 (Vprocess_alist, proc_buffered_char, datagram_access):
6217 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6218 (deactivate_process): Mark defn as static, as well as decl.
6219 * lisp.h (create_process): Remove decl.
6220 * process.h (chan_process, Vprocess_alist): Remove decls.
6221
ad64fc97
PE
6222 * print.c: Make symbols static if they're not exported.
6223 (print_depth, new_backquote_output, being_printed, print_buffer):
6224 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6225 (print_interval, print_number_index, initial_stderr_stream):
6226 Now static.
6227 * lisp.h (Fprinc): Remove decl.
6228 (debug_output_compilation_hack): Mark as externally visible.
6229
adddb265
PE
6230 * sysdep.c (croak): Move decl from here to syssignal.h.
6231 * syssignal.h (croak): Put it here, so the API can be checked when
6232 'croak' is called from dissociate_if_controlling_tty.
6233
1717ede2
PE
6234 * minibuf.c: Make symbols static if they're not exported.
6235 (minibuf_save_list, choose_minibuf_frame): Now static.
6236 * lisp.h (choose_minibuf_frame): Remove decl.
6237
fa5fb2bc
PE
6238 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6239
1e3890d1
PE
6240 * lread.c: Make symbols static if they're not exported.
6241 (read_objects, initial_obarray, oblookup_last_bucket_number):
6242 Now static.
6243 (make_symbol): Remove; unused.
6244 * lisp.h (initial_obarray, make_symbol): Remove decls.
6245
8a1414fa
PE
6246 * keyboard.c: Make symbols static if they're not exported.
6247 (single_kboard, recent_keys_index, total_keys, recent_keys):
6248 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6249 (this_single_command_key_start, echoing, last_auto_save):
6250 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6251 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6252 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6253 (Vlispy_mouse_stem, double_click_count):
6254 Now static.
6255 (force_auto_save_soon): Define only if SIGDANGER.
6256 (ignore_mouse_drag_p): Now static if
6257 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6258 (print_help): Remove; unused.
6259 (stop_character, last_timer_event): Mark as externally visible.
6260 * keyboard.h (ignore_mouse_drag_p): Declare only if
6261 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6262 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6263 * lisp.h (echoing): Remove decl.
6264 (force_auto_save_soon): Declare only if SIGDANGER.
6265 * xdisp.c (redisplay_window): Simplify code, to make it more
6266 obvious that ignore_mouse_drag_p is not accessed if !defined
6267 USE_GTK && !defined HAVE_NS.
6268
93ea6e8f
PE
6269 * intervals.c: Make symbols static if they're not exported.
6270 (merge_properties_sticky, merge_interval_right, delete_interval):
6271 Now static.
6272 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6273
77382fcc
PE
6274 * insdel.c: Make symbols static if they're not exported.
6275 However, leave prepare_to_modify_buffer alone. It's never
6276 called from outside this function, but that appears to be a bug.
6277 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6278 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6279 (adjust_after_replace_noundo): Remove; unused.
6280 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6281 (signal_before_change): Remove decls.
77382fcc 6282
9306c32e
PE
6283 * indent.c (val_compute_motion, val_vmotion): Now static.
6284
cd44d2eb
PE
6285 * image.c: Make symbols static if they're not exported.
6286 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6287 if USE_GTK.
6288 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6289 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6290
ad9a7a06
PE
6291 * fringe.c (standard_bitmaps): Now static.
6292 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6293
81626931
PE
6294 * frame.c: Make symbols static if they're not exported.
6295 (x_report_frame_params, make_terminal_frame): Now static.
6296 (get_frame_param): Now static, unless HAVE_NS.
6297 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6298 (x_get_resource_string): Remove; not used.
6299 * frame.h (make_terminal_frame, x_report_frame_params):
6300 (x_get_resource_string); Remove decls.
6301 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6302 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6303
239f9db9
PE
6304 * font.c, fontset.c: Make symbols static if they're not exported.
6305 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6306 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6307 * font.c (font_close_object): Now static.
6308 * font.h (font_close_object): Remove.
6309 * fontset.c (FONTSET_OBJLIST): Remove.
6310 (free_realized_fontset) #if-0 the body, which does nothing.
6311 (face_suitable_for_char_p): #if-0, as it's never called.
6312 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6313 * xfaces.c (face_at_string_position):
6314 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6315 since 0 is always ASCII.
6316
dfcf3579
PE
6317 * fns.c (weak_hash_tables): Now static.
6318
5045092b
PE
6319 * fileio.c: Make symbols static if they're not exported.
6320 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6321 (Vwrite_region_annotation_buffers): Now static.
6322
57a96f5c
PE
6323 * eval.c: Make symbols static if they're not exported.
6324 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6325 * lisp.h (backtrace_list): Remove decl.
6326
35f08c38
PE
6327 * emacs.c: Make symbols static if they're not exported.
6328 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6329 (fatal_error_code, fatal_error_signal_hook, standard_args):
6330 Now static.
6331 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6332 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6333 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6334 * lisp.h (fatal_error_signal_hook): Remove decl.
6335 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6336
f44bd759
PE
6337 * editfns.c: Move a (normally-unused) function to its only use.
6338 * editfns.c, lisp.h (get_operating_system_release): Remove.
6339 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6340 worth the hassle of breaking this out.
6341
b532497d
PE
6342 * xterm.c: Make symbols static if they're not exported.
6343 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6344 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6345 (x_destroy_window, x_delete_display):
6346 Now static.
6347 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6348 (x_mouse_leave): Remove; unused.
6349 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6350 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6351 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6352 Remove decls.
6353 (x_mouse_leave): Declare only if WINDOWSNT.
6354 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6355 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6356 USE_X_TOOLKIT.
6357
1675728f
PE
6358 * ftxfont.c: Make symbols static if they're not exported.
6359 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6360 HAVE_FREETYPE.
6361 * font.h (ftxfont_driver): Likewise.
6362
e4cebfca
PE
6363 * xfns.c: Make symbols static if they're not exported.
6364 (x_last_font_name, x_display_info_for_name):
6365 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6366 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6367 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6368 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6369 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6370 (last_show_tip_args): Now static.
6371 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6372 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6373 (x_screen_planes): Remove; unused.
6374 * dispextern.h (x_screen_planes): Remove decl.
6375
5bf46f05
PE
6376 * dispnew.c: Make symbols static if they're not exported.
6377 * dispextern.h (redraw_garbaged_frames, scrolling):
6378 (increment_row_positions): Remove.
6379 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6380 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6381 Now static.
6382 (redraw_garbaged_frames): Remove; unused.
6383
435f4c28
PE
6384 * xfaces.c: Make symbols static if they're not exported.
6385 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6386 Remove decls.
6387 * xterm.h (defined_color): Remove decls.
6388 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6389 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6390 (menu_face_changed_default, defined_color, free_realized_face):
6391 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6392 (ascii_face_of_lisp_face): Remove; unused.
6393
8524aef3
PE
6394 * xdisp.c: Make symbols static if they're not exported.
6395 * dispextern.h (scratch_glyph_row, window_box_edges):
6396 (glyph_to_pixel_coords, set_cursor_from_row):
6397 (get_next_display_element, set_iterator_to_next):
6398 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6399 (show_mouse_face): Remove decls
6400 * frame.h (message_buf_print): Likewise.
6401 * lisp.h (pop_message, set_message, check_point_in_composition):
6402 Likewise.
6403 * xterm.h (set_vertical_scroll_bar): Likewise.
6404 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6405 (message_buf_print, scratch_glyph_row, displayed_buffer):
6406 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6407 (get_next_display_element, show_mouse_face, window_box_edges):
6408 (frame_to_window_pixel_xy, check_point_in_composition):
6409 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6410 (glyph_to_pixel_coords): Remove; unused.
6411
16390cd2
PE
6412 * dired.c (file_name_completion): Now static.
6413
6414 * dbusbind.c (xd_in_read_queued_messages): Now static.
6415
a25f4dfa
PE
6416 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6417 * data.c (circular_list_error): Remove.
6418
14a9c8df
PE
6419 * commands.h (last_point_position, last_point_position_buffer):
6420 (last_point_position_window): Remove decls.
6421 * keyboard.c: Make these variables static.
6422
04f2d78b
CB
6423 * coding.h (coding, code_convert_region, encode_coding_gap):
6424 Remove decls.
74ab6df5
PE
6425 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6426 (iso_code_class, detect_coding, code_convert_region): Now static.
6427 (encode_coding_gap): Remove; unused.
6428
38dfbee1
PE
6429 * chartab.c (chartab_chars, chartab_bits): Now static.
6430
a2cb4e63
PE
6431 * charset.h (charset_iso_8859_1): Remove decl.
6432 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6433 Now static.
6434
127198fd
PE
6435 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6436 * ccl.c (Vccl_program_table): Now static.
6437 (check_ccl_update): Remove; unused.
6438
d85b608f
PE
6439 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6440 * category.h: ... from here.
6441 * category.c (check_category_table, set_category_set): Now static.
6442
31cd66f3
PE
6443 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6444 * lisp.h: Remove these decls.
6445
c358e587
PE
6446 * buffer.c (buffer_count): Remove unused var.
6447
e78aecca
PE
6448 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6449 so that it's not optimized away.
6450 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6451 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6452 exported only to the debugger.
6453
e192d7d3 6454 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6455 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6456
92470028
PE
6457 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6458 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6459 was inaccessible from Lisp.
6460 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6461 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6462
244ed907
PE
6463 alloc.c: Import and export fewer symbols, and remove unused items.
6464 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6465 is defined.
6466 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6467 it's not optimized away by whole-program optimization.
6468 (message_enable_multibyte, free_misc): Remove.
6469 (catchlist, handlerlist, mark_backtrace):
6470 Declare only if BYTE_MARK_STACK.
6471 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6472 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6473 (message_enable_multibyte): Remove decl.
6474 (free_misc, interval_free_list, float_block, float_block_index):
6475 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6476 (cons_free_list, last_marked_index):
6477 Now static.
6478 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6479 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6480 (mark_backtrace): Define only if BYTE_MARK_STACK.
6481 * xdisp.c (message_enable_multibyte): Now static.
6482
61c2b50e 6483 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6484 This makes it easier for human readers (and static analyzers)
6485 to see whether these variables are used from other modules.
6486 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6487 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6488 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6489 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6490 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6491 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6492 * xmenu.c, xselect.c:
6493 Declare Q* vars static if they are not used in other modules.
6494 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6495 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6496 Remove decls of unexported vars.
6497 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6498
95c82688
PE
6499 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6500
16a97296
PE
6501 Make Emacs functions such as Fatom 'static' by default.
6502 This makes it easier for human readers (and static analyzers)
6503 to see whether these functions can be called from other modules.
6504 DEFUN now defines a static function. To make the function external
6505 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6506 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6507 (Finit_image_library):
16a97296
PE
6508 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6509 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6510 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6511 Remove decls, since these functions are now static.
6512 (Funintern, Fget_internal_run_time): New decls, since these functions
6513 were already external.
95c82688 6514
16a97296
PE
6515 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6516 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6517 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6518 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6519 * keyboard.c, keymap.c, lread.c:
6520 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6521 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6522 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6523 Mark functions with DEFUE instead of DEFUN,
6524 if they are used in other modules.
6525 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6526 decls for now-static functions.
6527 * buffer.h (Fdelete_overlay): Remove decl.
6528 * callproc.c (Fgetenv_internal): Mark as internal.
6529 * composite.c (Fremove_list_of_text_properties): Remove decl.
6530 (Fcomposition_get_gstring): New forward static decl.
6531 * composite.h (Fcomposite_get_gstring): Remove decl.
6532 * dired.c (Ffile_attributes): New forward static decl.
6533 * doc.c (Fdocumntation_property): New forward static decl.
6534 * eval.c (Ffetch_bytecode): New forward static decl.
6535 (Funintern): Remove extern decl; now in .h file where it belongs.
6536 * fileio.c (Fmake_symbolic_link): New forward static decl.
6537 * image.c (Finit_image_library): New forward static decl.
6538 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6539 * intervals.h (Fprevious_property_change):
6540 (Fremove_list_of_text_properties): Remove decls.
6541 * keyboard.c (Fthis_command_keys): Remove decl.
6542 (Fcommand_execute): New forward static decl.
6543 * keymap.c (Flookup_key): New forward static decl.
6544 (Fcopy_keymap): Now static.
6545 * keymap.h (Flookup_key): Remove decl.
6546 * process.c (Fget_process): New forward static decl.
6547 (Fprocess_datagram_address): Mark as internal.
6548 * syntax.c (Fsyntax_table_p): New forward static decl.
6549 (skip_chars): Remove duplicate decl.
6550 * textprop.c (Fprevious_property_change): New forward static decl.
6551 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6552 Now internal.
6553 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6554 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6555
785bbd42
PE
6556 * editfns.c (Fformat): Remove unreachable code.
6557
8b913b57
AS
65582011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6559
6560 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6561 change. (Bug#8496)
6562
a6744a35
EZ
65632011-04-13 Eli Zaretskii <eliz@gnu.org>
6564
6565 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6566 when at ZV. (Bug#8487)
6567
e7974947
AS
65682011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6569
baad03f0
AS
6570 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6571 (Bug#8437)
6572 * keyboard.c (parse_tool_bar_item): Likewise.
6573 * sound.c (sound_cleanup, alsa_close): Likewise.
6574 * termcap.c (tgetent): Likewise.
6575 * xfns.c (x_default_font_parameter): Likewise.
6576 * xsettings.c (read_and_apply_settings): Likewise.
6577
e7974947
AS
6578 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6579 (overrun_check_free): Protoize.
6580
28272684
PE
65812011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6582
6583 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6584 since callers should never pass a negative size.
6585 Change the signature to match that of plain 'read' and 'write'; see
6586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6587 * lisp.h: Update prototypes of emacs_write and emacs_read.
6588
11997c76
EZ
65892011-04-11 Eli Zaretskii <eliz@gnu.org>
6590
6591 * xdisp.c (redisplay_window): Don't try to determine the character
6592 position of the scroll margin if the window start point w->startp
e896f03c 6593 is outside the buffer's accessible region. (Bug#8468)
11997c76 6594
8a2cbd72
EZ
65952011-04-10 Eli Zaretskii <eliz@gnu.org>
6596
6597 Fix write-region and its subroutines for buffers > 2GB.
6598 * fileio.c (a_write, e_write): Modify declaration of arguments and
6599 local variables to support buffers larger than 2GB.
6600 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6601
6602 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6603 argument, local variables, and return value.
6604
6605 * lisp.h: Update prototypes of emacs_write and emacs_read.
6606
6607 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6608
4073e537 66092011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6610
1ebfdcb6
PE
6611 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6612
b2ded58d
PE
6613 Fix more problems found by GCC 4.6.0's static checks.
6614
7d66342c
PE
6615 * xdisp.c (vmessage): Use a better test for character truncation.
6616
bbf47d44
PE
6617 * charset.c (load_charset_map): <, not <=, for optimization,
6618 and to avoid potential problems with integer overflow.
9248994d 6619 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6620 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6621 * editfns.c (Fformat): Likewise.
1e69125e 6622 * syntax.c (skip_chars): Likewise.
3befa583 6623
e3019616
PE
6624 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6625 This also lets GCC 4.6.0 generate slightly better loop code.
6626
becfa255
PE
6627 * callint.c (Fcall_interactively): <, not <=, for optimization.
6628 (Fcall_interactively): Count the number of arguments produced,
6629 not the number of arguments given. This is simpler and lets GCC
6630 4.6.0 generate slightly better code.
6631
dae0cd48
PE
6632 * ftfont.c: Distingish more carefully between FcChar8 and char.
6633 The previous code passed unsigned char * to a functions like
6634 strlen and xstrcasecmp that expect char *, which does not
6635 conform to the C standard.
6636 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6637 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6638 char * when the C standard requires it.
6639
76032d70
PE
6640 * keyboard.c (read_char): Remove unused var.
6641
eb3f1cc8
PE
6642 * eval.c: Port to Windows vsnprintf (Bug#8435).
6643 Include <limits.h>.
6644 (SIZE_MAX): Define if the headers do not.
6645 (verror): Do not give up if vsnprintf returns a negative count.
6646 Instead, grow the buffer. This ports to Windows vsnprintf, which
6647 does not conform to C99. Problem reported by Eli Zaretskii.
6648 Also, simplify the allocation scheme, by avoiding the need for
6649 calling realloc, and removing the ALLOCATED variable.
6650
70476b54
PE
6651 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6652
12020a9e
PE
6653 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6654 But keep the doprint source code for now, as we might revamp it
6655 and use it again (Bug#8435).
ea6c7ae6
PE
6656 * lisp.h (doprnt): Remove.
6657 * Makefile.in (base_obj): Remove doprnt.o.
6658 * deps.mk (doprnt.o): Remove.
6659
5fdb398c
PE
6660 error: Print 32- and 64-bit integers portably (Bug#8435).
6661 Without this change, on typical 64-bit hosts error ("...%d...", N)
6662 was used to print both 32- and 64-bit integers N, which relied on
6663 undefined behavior.
6664 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6665 New macro.
6666 * lisp.h (error, verror): Mark as printf-like functions.
6667 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6668 Report overflow in size calculations when allocating printf buffer.
6669 Do not truncate output string at its first null byte.
6670 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6671 Truncate the output at a character boundary, since vsnprintf does not
6672 do that.
6673 * charset.c (check_iso_charset_parameter): Convert internal
6674 character to string before calling 'error', since %c now has the
6675 printf meaning.
6676 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6677 overflow when computing char to be passed to 'error'. Do not
6678 pass Lisp_Object to 'error'; pass the integer instead.
6679 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6680 formatted with plain %d.
6681
b189fa66
PE
6682 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6683
bff87ef0
PE
6684 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6685
7e2cac20
PE
6686 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6687
ce4d90b5
PE
6688 * xterm.c (x_catch_errors): Remove duplicate declaration.
6689
266c9547
PE
6690 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6691
79c49ad2
PE
6692 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6693
368f4090
JM
66942011-04-10 Jim Meyering <meyering@redhat.com>
6695
6696 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6697 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6698 return ssize_t not "int", and use size_t as the buffer length.
6699 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6700 * gnutls.h: Update declarations.
6701 * process.c (read_process_output): Use ssize_t, to match.
6702 (send_process): Likewise.
6703
a32d4040
CY
67042011-04-09 Chong Yidong <cyd@stupidchicken.com>
6705
6706 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6707
8546720e 67082011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6709
04f2d78b
CB
6710 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6711 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6712
8546720e
GM
6713 * xterm.c (handle_one_xevent):
6714 * xmenu.c (create_and_show_popup_menu):
6715 * xselect.c (x_decline_selection_request)
6716 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6717
0a2f5c1a 67182011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6719
6720 Fix some uses of `int' instead of EMACS_INT.
6721 * search.c (string_match_1, fast_string_match)
6722 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6723 (scan_buffer, find_next_newline_no_quit)
6724 (find_before_next_newline, search_command, Freplace_match)
6725 (Fmatch_data): Make some `int' variables be EMACS_INT.
6726
6727 * xdisp.c (display_count_lines): 3rd argument and return value now
6728 EMACS_INT. All callers changed.
6729 (pint2hrstr): Last argument is now EMACS_INT.
6730
6731 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6732 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6733 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6734 (decode_coding_utf_16, decode_coding_emacs_mule)
6735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6736 (decode_coding_ccl, decode_coding_charset)
6737 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6738 (decode_coding_iso_2022, decode_coding_emacs_mule)
6739 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6740 <char_offset, last_offset>: Declare EMACS_INT.
6741 (encode_coding_utf_8, encode_coding_utf_16)
6742 (encode_coding_emacs_mule, encode_invocation_designation)
6743 (encode_designation_at_bol, encode_coding_iso_2022)
6744 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6745 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6746 Declare EMACS_INT.
6747 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6748 (encode_invocation_designation): Last argument P_NCHARS is now
6749 EMACS_INT.
6750 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6751 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6752
6753 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6754 All users changed.
6755
6756 * ccl.c (Fccl_execute_on_string): Declare some variables
6757 EMACS_INT.
6758
8546720e 67592011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6760
6761 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6762
4e19a977
CS
67632011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6764
6765 * process.c (Fformat_network_address): Doc fix.
6766
87302331
R
67672011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6768
6769 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6770
cbb59342
CY
67712011-04-08 Chong Yidong <cyd@stupidchicken.com>
6772
6773 * keyboard.c (read_char): Call Lisp function help-form-show,
6774 instead of using internal_with_output_to_temp_buffer.
6775 (Qhelp_form_show): New var.
e0d38eeb 6776 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6777
6778 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6779
6780 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6781
e67a13ab
CY
67822011-04-06 Chong Yidong <cyd@stupidchicken.com>
6783
04f2d78b
CB
6784 * process.c (Flist_processes): Remove to Lisp.
6785 (list_processes_1): Delete.
e67a13ab 6786
973f782d
EZ
67872011-04-06 Eli Zaretskii <eliz@gnu.org>
6788
7c106b1e
EZ
6789 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6790
973f782d
EZ
6791 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6792
41cf7d1a 67932011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6794
ca23cc88
PE
6795 Fix more problems found by GCC 4.6.0's static checks.
6796
f390e2d5
PE
6797 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6798
42eea0d0
PE
6799 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6800
b69769da 6801 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6802
f9541e84
PE
6803 * xdisp.c (vmessage): Mark as a printf-like function.
6804
13841b55
PE
6805 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6806
c136c10f
PE
6807 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6808
5e2d4a30
PE
6809 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6810 printf-like functions.
6811 (tiff_load): Add casts to remove these marks before passing them
6812 to system-supplied API.
6813
583f48b9
PE
6814 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6815
b25d760e
PE
6816 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6817 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6818 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6819 directly, rather than having caller test rule sign. This avoids
6820 some unnecessary tests.
6821 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6822 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6823 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6824
bc7b6697 6825 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6826 (xfont_open): Avoid unnecessary tests.
bc7b6697 6827
27ccc379
PE
6828 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6829
dcd5c89a
PE
6830 * composite.h, composite.c (composition_gstring_put_cache):
6831 Use EMACS_INT, not int, for length.
6832
b13a45c6
PE
6833 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6834 breaking out part of COMPOSITION_DECODE_RULE.
6835 (COMPOSITION_DECODE_RULE): Use it.
6836 * composite.c (get_composition_id): Remove unused local vars,
6837 by using the new macro.
6838
1e792e4d
PE
6839 * textprop.c (set_text_properties_1): Change while to do-while,
6840 since the condition is always true at first.
6841
dc6c6455 6842 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6843 (interval_deletion_adjustment): Return unsigned value.
6844 All uses changed.
dc6c6455 6845
aba7731a
PE
6846 * process.c (list_processes_1, create_pty, read_process_output):
6847 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6848 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6849 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6850 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6851 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6852
fdfc4bf3
PE
6853 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6854
fca8fe46 6855 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6856 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6857
06a0259a 6858 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6859 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6860 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6861
e7b9e80f
PE
6862 * print.c (print_error_message): Avoid int overflow.
6863
56201685
PE
6864 * font.c (font_list_entities): Redo for clarity,
6865 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6866
78834453 6867 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6868 (font_score): Avoid potential overflow in diff calculation.
78834453 6869
0bc0b309 6870 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6871 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6872
e610eaca
PE
6873 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6874
b895abce
PE
6875 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6876 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6877 can always succeed if overflow has undefined behavior.
6878
1f1d9321 6879 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6880 (wordify): Omit three unnecessary tests.
1f1d9321 6881
c59478bc
PE
6882 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6883 All callers changed. This avoids the need for an unused var.
6884
79b73827
PE
6885 * casefiddle.c (casify_region): Remove var that is set but not used.
6886
a4db5dfe
PE
6887 * dired.c (file_name_completion): Remove var that is set but not used.
6888
43aae36e
PE
6889 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6890
2a47c44d 6891 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6892 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6893
a37c69bf
PE
6894 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6895 Check for integer overflow on size calculations.
6896
328ab8e7
PE
6897 * buffer.c (Fprevious_overlay_change): Remove var that is set
6898 but not used.
6899
e5a2a5cb
PE
6900 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6901 Remove vars that are set but not used.
8d84a6eb 6902 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6903 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6904
a60e5f68
PE
6905 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6906
f661cb61 6907 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6908 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6909
f0397f5a
PE
6910 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6911 that are set but not used.
6912
8664db06 6913 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6914 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6915
6abdaa4a
PE
6916 * xselect.c (x_get_local_selection, x_handle_property_notify):
6917 Remove vars that are set but not used.
6918
0ce7538d 6919 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6920 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6921
9ae848fc
PE
6922 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6923 Remove var that is set but not used.
0b918413
PE
6924 (scroll_bar_windows_size): Now size_t, not int.
6925 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6926 Check for overflow.
9ae848fc 6927
a5a62657
PE
6928 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6929 (map_tty_color) [!defined MSDOS]: Likewise.
6930
5c5cdd39
PE
6931 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6932
66ebf983
PE
6933 * coding.c: Remove vars that are set but not used.
6934 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6935 All callers changed.
6936 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6937 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6938 (decode_coding_charset): Remove vars that are set but not used.
6939
1be4d761
PE
6940 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6941 that is set but not used.
6942
47553fa8
PE
6943 * print.c (print_object): Remove var that is set but not used.
6944
1f7196bf 6945 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6946 The gnulib version avoids calling malloc in the usual case,
6947 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6948 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6949 * filelock.c (current_lock_owner): Likewise.
6950 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6951 * sysdep.c: Include allocator.h, careadlinkat.h.
6952 (emacs_no_realloc_allocator): New static constant.
6953 (emacs_readlink): New function.
fdb61804
PE
6954 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6955 ../lib/careadlinkat.h.
d1fdcab7 6956
f84c17c7
SM
69572011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6958
6959 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6960 first non-nil return value).
6961
ef3862ad
JD
69622011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6963
6964 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6965 if not defined (Bug#8403).
6966
376a7006
JB
69672011-04-02 Juanma Barranquero <lekktu@gmail.com>
6968
6969 * xdisp.c (display_count_lines): Remove parameter `start',
6970 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6971 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6972 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6973 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6974 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6975 and thereabouts. All callers changed.
6976 (get_per_char_metric): Remove parameter `f', unused since
6977 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6978
6ca3801d
JM
69792011-04-02 Jim Meyering <meyering@redhat.com>
6980
6981 do not dereference NULL upon failed strdup
6982 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6983 (ns_get_family): Likewise.
6984
d8e2b5ba
JB
69852011-04-02 Juanma Barranquero <lekktu@gmail.com>
6986
6987 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6988
8c74fcbd
JD
69892011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6990
6991 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6992 later (Bug#8403).
6993
7200d79c
SM
69942011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6995
03408648 6996 Add lexical binding.
7200d79c 6997
03408648
SM
6998 * window.c (Ftemp_output_buffer_show): New fun.
6999 (Fsave_window_excursion):
7000 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7001
7002 * lread.c (lisp_file_lexically_bound_p): New function.
7003 (Fload): Bind Qlexical_binding.
7004 (readevalloop): Remove `evalfun' arg.
7005 Bind Qinternal_interpreter_environment.
7006 (Feval_buffer): Bind Qlexical_binding.
7007 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7008 Mark as dynamic.
7009 (syms_of_lread): Declare `lexical-binding'.
7010
7011 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7012
7013 * keyboard.c (eval_dyn): New fun.
7014 (menu_item_eval_property): Use it.
ca105506
SM
7015
7016 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7017
03408648
SM
7018 * fns.c (concat, mapcar1): Accept byte-code-functions.
7019
7020 * eval.c (Fsetq): Handle lexical vars.
7021 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7022 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7023 (FletX, Flet): Obey lexical binding.
7024 (Fcommandp): Handle closures.
7025 (Feval): New `lexical' arg.
7026 (eval_sub): New function extracted from Feval. Use it almost
7027 everywhere where Feval was used. Look up vars in lexical env.
7028 Handle closures.
7029 (Ffunctionp): Move from subr.el.
7030 (Ffuncall): Handle closures.
7031 (apply_lambda): Remove `eval_flags'.
7032 (funcall_lambda): Handle closures and new byte-code-functions.
7033 (Fspecial_variable_p): New function.
7034 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7035 but without exporting it to Lisp.
23aba0ea 7036
23aba0ea 7037 * doc.c (Fdocumentation, store_function_docstring):
03408648 7038 * data.c (Finteractive_form): Handle closures.
23aba0ea 7039
03408648
SM
7040 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7041 interactive spec.
ba83908c 7042
04f2d78b
CB
7043 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7044 New byte-codes.
03408648
SM
7045 (exec_byte_code): New function extracted from Fbyte_code to handle new
7046 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7047
03408648 7048 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7049
03408648 7050 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7051
e2abce01
JB
70522011-03-31 Juanma Barranquero <lekktu@gmail.com>
7053
7054 * xdisp.c (redisplay_internal): Fix prototype.
7055
63696a73 70562011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7057
63696a73 7058 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7059 (try_scrolling): Use it when setting scroll_limit.
7060 Limit scrolling to 100 screen lines.
63696a73
EZ
7061 (redisplay_window): Even when falling back on "recentering",
7062 position point in the window according to scroll-conservatively,
7063 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7064
7065 (try_scrolling): When point is above the window, allow searching
7066 as far as scroll_max, or one screenful, to compute vertical
7067 distance from PT to the scroll margin position. This prevents
7068 try_scrolling from unnecessarily failing when
7069 scroll-conservatively is set to a value slightly larger than the
7070 window height. Clean up the case of PT below the margin at bottom
7071 of window: scroll_max can no longer be INT_MAX. When aggressive
7072 scrolling is in use, don't let point enter the opposite scroll
7073 margin as result of the scroll.
7074 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7075 threshold of 100 lines for never-recentering scrolling.
7076
e4cc2dfc
JB
70772011-03-31 Juanma Barranquero <lekktu@gmail.com>
7078
7079 * dispextern.h (move_it_by_lines):
7080 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7081 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7082 (message_log_check_duplicate): Remove parameters `prev_bol' and
7083 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7084 (redisplay_internal): Remove parameter `preserve_echo_area',
7085 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7086
7087 * indent.c (Fvertical_motion):
7088 * window.c (window_scroll_pixel_based, Frecenter):
7089 Don't pass `need_y_p' to `move_it_by_lines'.
7090
1c470562
SM
70912011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7092
44f230aa
SM
7093 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7094 steal a few bits to be more compact.
7095 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7096 Remove unneeded casts.
7097
1c470562
SM
7098 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7099
888adce9
ZK
71002011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7101
7102 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7103 binding" message (bug#7967).
7104
f838ed7b
PE
71052011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7106
77861b95
PE
7107 Fix more problems found by GCC 4.6.0's static checks.
7108
de6dbc14
PE
7109 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7110 Remove unused local var.
7111
f838ed7b
PE
7112 * editfns.c (Fmessage_box): Remove unused local var.
7113
792c7b2b
PE
7114 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7115 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7116 Omit unused local vars.
c499e557 7117 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7118 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7119 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7120 Omit unused local var.
7121
ba0165e1
PE
7122 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7123 Don't assume string length fits in int.
32ad8845 7124 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7125 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7126
3c59b4c9
PE
7127 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7128 instead of alloca (Bug#8344).
7129
a3eed478 7130 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7131 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7132
eb4d412d
PE
7133 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7134
1658b401
PE
7135 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7136 concerns.
7137
7138 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7139
7140 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7141
9a2c6e05
PE
7142 * keyboard.c (syms_of_keyboard): Use the same style as later
7143 in this function when indexing through an array. This also
7144 works around GCC bug 48267.
7145
03d0a109
PE
7146 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7147
44f730c8
PE
7148 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7149
fe75f926
PE
7150 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7151 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7152
ffa8c828
PE
7153 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7154 This avoids undefined behavior on integer overflow, and is a bit
7155 more convenient anyway since it is compared to a size_t variable.
7156
c5101a77
PE
7157 Variadic C functions now count arguments with size_t, not int.
7158 This avoids an unnecessary limitation on 64-bit machines, which
7159 caused (substring ...) to crash on large vectors (Bug#8344).
7160 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7161 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7162 All variadic functions and their callers changed accordingly.
c5101a77
PE
7163 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7164 * data.c (arith_driver, float_arith_driver): Likewise.
7165 * editfns.c (general_insert_function): Likewise.
7166 * eval.c (struct backtrace.nargs, interactive_p)
7167 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7168 (funcall_lambda, mark_backtrace): Likewise.
7169 * fns.c (concat): Likewise.
7170 * frame.c (x_set_frame_parameters): Likewise.
7171 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7172 0 if not found, not -1. All callers changed.
7173
dd3f25f7
PE
7174 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7175 (stack_copy_size): Now size_t, not int.
7176 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7177
461c2ab9
JB
71782011-03-28 Juanma Barranquero <lekktu@gmail.com>
7179
7180 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7181 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7182 All callers changed.
7183
7184 * lisp.h (multibyte_char_to_unibyte):
7185 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7186 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7187 * character.h (CHAR_TO_BYTE8):
7188 * cmds.c (internal_self_insert):
7189 * editfns.c (general_insert_function):
7190 * keymap.c (push_key_description):
7191 * search.c (Freplace_match):
7192 * xdisp.c (message_dolog, set_message_1): All callers changed.
7193
f6d62986
SM
71942011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7195
7196 * keyboard.c (safe_run_hook_funcall): New function.
7197 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7198 don't set the hook to nil, but remove the offending function instead.
7199 (Qcommand_hook_internal): Remove, unused.
7200 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7201 Vcommand_hook_internal.
7202
7203 * eval.c (enum run_hooks_condition): Remove.
7204 (funcall_nil, funcall_not): New functions.
7205 (run_hook_with_args): Call each function through a `funcall' argument.
7206 Remove `cond' argument, now redundant.
7207 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7208 (Frun_hook_with_args_until_failure): Adjust accordingly.
7209 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7210
1db5b1ad
JB
72112011-03-28 Juanma Barranquero <lekktu@gmail.com>
7212
7213 * dispextern.h (string_buffer_position): Remove declaration.
7214
7215 * print.c (strout): Remove parameter `multibyte', unused since
7216 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7217
7218 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7219 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7220 All callers changed.
7221
7222 * w32.c (_wsa_errlist): Use braces for struct initializers.
7223
7224 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7225 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7226 All callers changed.
7227 (string_buffer_position): Likewise. Also, make static (it's never
7228 used outside xdisp.c).
7229 (cursor_row_p): Remove parameter `w', unused since
7230 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7231 (decode_mode_spec): Remove parameter `precision', introduced during
7232 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7233 All callers changed.
7234
5ffb62aa
JD
72352011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7236
7237 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7238
461c2ab9 72392011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7240
7241 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7242 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7243 (ns_update_auto_hide_menu_bar): New functions.
7244 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7245 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7246 ns_constrain_all_frames.
7247 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7248 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7249
5c380ffb
JD
72502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7251
7252 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7253
9af30bdf
GM
72542011-03-27 Glenn Morris <rgm@gnu.org>
7255
7256 * syssignal.h: Replace RETSIGTYPE with void.
7257 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7258 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7259 Replace SIGTYPE with void everywhere.
7260 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7261 * s/template.h (SIGTYPE): Remove commented out definition.
7262
e2abce01
JB
72632011-03-26 Eli Zaretskii <eliz@gnu.org>
7264
7265 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7266 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7267
f868cd8a
JB
72682011-03-26 Juanma Barranquero <lekktu@gmail.com>
7269
59eb0929
JB
7270 * w32.c (read_unc_volume): Use parameter `henum', instead of
7271 global variable `wget_enum_handle'.
7272
7273 * keymap.c (describe_vector): Remove parameters `indices' and
7274 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7275 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7276
f868cd8a
JB
7277 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7278
7279 * keyboard.c (timer_check): Remove parameter `do_it_now',
7280 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7281 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7282 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7283
7284 * keyboard.c (read_char):
7285 * w32menu.c (w32_menu_display_help):
7286 * xmenu.c (show_help_event, menu_help_callback):
7287 Adjust calls to `show_help_echo'.
7288
7289 * gtkutil.c (xg_maybe_add_timer):
7290 * keyboard.c (readable_events):
7291 * process.c (wait_reading_process_output):
7292 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7293
7294 * insdel.c (adjust_markers_gap_motion):
7295 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7296 (gap_left, gap_right): Don't call it.
7297
2ecf6fdb
CY
72982011-03-25 Chong Yidong <cyd@stupidchicken.com>
7299
7300 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7301 incurred during fontification.
7302
6b1f9ba4
JB
73032011-03-25 Juanma Barranquero <lekktu@gmail.com>
7304
7305 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7306 (DEFVAR_PER_BUFFER): Don't pass it.
7307
7308 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7309 (scrolling_window): Don't pass it.
7310
0f4a96b5
JB
73112011-03-25 Juanma Barranquero <lekktu@gmail.com>
7312
7313 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7314
7315 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7316 and `suffix'.
7317 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7318 of variables specific to SELinux and computation of `encoded_absname'.
7319
7320 * image.c (XPutPixel): Remove unused variable `height'.
7321
7322 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7323
7324 * unexw32.c (get_section_info): Remove unused variable `section'.
7325
7326 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7327 (system_process_attributes): Remove unused variable `sess'.
7328 (sys_read): Remove unused variable `err'.
7329
7330 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7331 (w32_wnd_proc): Remove unused variable `isdead'.
7332 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7333 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7334 (x_create_tip_frame): Remove unused variable `tem'.
7335
7336 * w32inevt.c (w32_console_read_socket):
7337 Remove unused variable `no_events'.
7338
7339 * w32term.c (x_draw_composite_glyph_string_foreground):
7340 Remove unused variable `width'.
7341
1149507c
JB
73422011-03-24 Juanma Barranquero <lekktu@gmail.com>
7343
7344 * w32term.c (x_set_glyph_string_clipping):
7345 Don't pass uninitialized region to CombineRgn.
7346
9c88f339
JB
73472011-03-23 Juanma Barranquero <lekktu@gmail.com>
7348
7349 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7350 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7351 (Fx_close_connection): Remove unused variable `i'.
7352
7353 * w32font.c (w32font_draw): Return number of glyphs.
7354 (w32font_open_internal): Remove unused variable `i'.
7355 (w32font_driver): Add missing initializer.
7356
7357 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7358 (fill_in_menu): Remove unused variable `items_added'.
7359
7360 * w32term.c (last_mouse_press_frame): Remove static global variable.
7361 (w32_clip_to_row): Remove unused variable `f'.
7362 (x_delete_terminal): Remove unused variable `i'.
7363
7364 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7365 (NOTHING): Remove unused static global variable.
7366 (uniscribe_check_otf): Remove unused variable `table'.
7367 (uniscribe_font_driver): Add missing initializers.
7368
dee091a3
JD
73692011-03-23 Julien Danjou <julien@danjou.info>
7370
7371 * term.c (Fsuspend_tty, Fresume_tty):
7372 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7373 * window.c (temp_output_buffer_show):
7374 * insdel.c (signal_before_change):
7375 * frame.c (Fhandle_switch_frame):
7376 * fileio.c (Fdo_auto_save):
7377 * emacs.c (Fkill_emacs):
7378 * editfns.c (save_excursion_restore):
7379 * cmds.c (internal_self_insert):
7380 * callint.c (Fcall_interactively):
7381 * buffer.c (Fkill_all_local_variables):
7382 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7383 Use Frun_hooks.
0f4a96b5 7384 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7385 unconditionnaly since it does the check itself.
7386
2c520ab5 73872011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7388
c9c49752
PE
7389 Fix more problems found by GCC 4.5.2's static checks.
7390
8abc3f12
PE
7391 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7392 the first time through the loop, since we know p0 < p1 then.
7393 This also avoids a gcc -Wstrict-overflow warning.
7394
a2d26660
PE
7395 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7396 leading to a memory leak, possible in functions like
7397 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7398 of objects (Bug#8318).
a2d26660 7399
916c72e9
PE
7400 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7401 that could (at least in theory) be that large.
7402
19ab8a18
PE
7403 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7404 This is less likely to overflow, and avoids undefined behavior if
7405 overflow does occur. All callers changed. Use strtoul to scan
7406 for the unsigned long integer.
b7cbbd6f
PE
7407 (pint2hrstr): Simplify and tune code slightly.
7408 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7409
f0641eff
PE
7410 * scroll.c (do_scrolling): Work around GCC bug 48228.
7411 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7412
7f650bb9
PE
7413 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7414 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7415 (validate_x_resource_name): Simplify count usage.
7416 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7417
37dd57d1
PE
7418 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7419 fail (Bug#8306).
81e56e61 7420
699979fc 7421 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7422
401bf9b4
PE
7423 * process.c (Fmake_network_process): Use socklen_t, not int,
7424 where POSIX says socklen_t is required in portable programs.
7425 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7426 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7427 (Fmake_network_process, server_accept_connection):
7428 (wait_reading_process_output, read_process_output):
7429 Likewise.
7430
b93aacde
PE
7431 * process.c: Rename or move locals to avoid shadowing.
7432 (list_processes_1, Fmake_network_process):
7433 (read_process_output_error_handler, exec_sentinel_error_handler):
7434 Rename or move locals.
4dc343ee 7435 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7436 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7437 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7438 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7439 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7440
af8a867c 7441 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7442 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7443 Include tparam.h instead, since it declares them.
af8a867c
PE
7444 * cm.h (PC): Remove extern decl; tparam.h now does this.
7445 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7446 * terminfo.c: Include tparam.h, to check interfaces.
7447 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7448 (tparam): Adjust signature to match interface in tparam.h;
7449 this removes some undefined behavior. Check that outstring and len
7450 are zero, which they always are with Emacs.
7451 * tparam.h (PC, BC, UP): New extern decls.
7452
0248044d 7453 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7454 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7455
8ff096c1 7456 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7457 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7458 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7459 (ftfont_list): Remove unused local.
49eaafba
PE
7460 (get_adstyle_property, ftfont_pattern_entity):
7461 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7462 Rename locals to avoid shadowing.
8ff096c1 7463
e2be39f6
PE
7464 * xfont.c (xfont_list_family): Mark var as initialized.
7465
c9735e30
PE
7466 * xml.c (make_dom): Now static.
7467
8f5201ae
PE
7468 * composite.c (composition_compute_stop_pos): Rename local to
7469 avoid shadowing.
b246f932
PE
7470 (composition_reseat_it): Remove unused locals.
7471 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7472 (composition_update_it): Mark var as initialized.
11b61122
PE
7473 (find_automatic_composition): Mark vars as initialized,
7474 with a FIXME (Bug#8290).
8f5201ae 7475
760fbc2c
PE
7476 character.h: Rename locals to avoid shadowing.
7477 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7478 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7479 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7480 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7481 to avoid shadowing.
7482
ff08eb85
PE
7483 * textprop.c (property_change_between_p): Remove; unused.
7484
fc7bf025
PE
7485 * intervals.c (interval_start_pos): Now static.
7486
235d7abc
PE
7487 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7488
44f230aa
SM
7489 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7490 Rename locals to avoid shadowing.
3e7d6594 7491
50060332
PE
7492 * sound.c (wav_play, au_play, Fplay_sound_internal):
7493 Fix pointer signedness.
d01f234b 7494 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7495 (wav_play): Initialize a variable to 0, to prevent undefined
7496 behavior (Bug#8278).
50060332 7497
c4fc4e30
PE
7498 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7499
918436ed
PE
7500 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7501
c939f91b
PE
7502 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7503 clobbering (Bug#8298).
b9c7f648
PE
7504 * sysdep.c (sys_subshell): Likewise.
7505 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7506
6bd8c144
PE
7507 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7508 This should get cleaned up, so that child_setup has the
7509 same signature on all platforms.
7510
7710357c 7511 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7512 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7513
c59da222
CY
75142011-03-22 Chong Yidong <cyd@stupidchicken.com>
7515
7516 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7517 not to be necessary, and produces flickering.
7518
66b87493
GM
75192011-03-20 Glenn Morris <rgm@gnu.org>
7520
7521 * config.in: Remove file.
7522
45b6f6d5
JB
75232011-03-20 Juanma Barranquero <lekktu@gmail.com>
7524
7525 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7526 are now in src/globals.h.
7527 (syms_of_minibuf): Remove spurious & from previous change.
7528
3ec03f7e
LL
75292011-03-20 Leo <sdl.web@gmail.com>
7530
7531 * minibuf.c (completing-read-function): New variable.
7532 (completing-read-default): Rename from completing-read.
7533 (completing-read): Call completing-read-function.
7534
b14e3e21
CY
75352011-03-19 Juanma Barranquero <lekktu@gmail.com>
7536
7537 * xfaces.c (Fx_load_color_file):
7538 Read color file from absolute filename (bug#8250).
7539
f2b726e6
JB
75402011-03-19 Juanma Barranquero <lekktu@gmail.com>
7541
7542 * makefile.w32-in: Update dependencies.
7543
09f6ff02
EZ
75442011-03-17 Eli Zaretskii <eliz@gnu.org>
7545
7546 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7547
29a6015a
PE
75482011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7549
a3a6c54e
PE
7550 Fix more problems found by GCC 4.5.2's static checks.
7551
b766f867
PE
7552 * process.c (make_serial_process_unwind, send_process_trap):
7553 (sigchld_handler): Now static.
7554
be02381c
PE
7555 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7556 That way, the code declares only the vars that it needs.
7557 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7558 * s/cygwin.h (PTY_ITERATION): Likewise.
7559 * s/darwin.h (PTY_ITERATION): Likewise.
7560 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7561
57048744
PE
7562 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7563 * process.c (allocate_pty): Don't declare stb unless it's needed.
7564
7914961c 7565 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7566 (CONSTANTLIM): Remove; unused.
7567 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7568 Define only if needed.
7914961c 7569
b3967b18
PE
7570 * unexelf.c (unexec): Name an expression,
7571 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7572 Use a different way to cause a compilation error if anyone uses
7573 n rather than nn, a way that does not involve shadowing.
73366a00 7574 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7575
29a6015a
PE
7576 * deps.mk (unexalpha.o): Remove; unused.
7577
43cfc33e 7578 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7579 * unexec.h: New file.
ce701a33
PE
7580 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7581 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7582 Depend on unexec.h.
7583 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7584 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7585 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7586 Change as necessary to match prototype in unexec.h.
ce701a33 7587
01f44d5a
PE
7588 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7589 shadowing.
4f63c6bb 7590 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7591
a6670b0b
PE
7592 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7593 Rename locals to avoid shadowing.
7594
cef2010d 7595 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7596 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7597
d4d7173a
PE
7598 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7599
f08b802a
PE
7600 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7601 warning when compiling print.c.
7602
3ddb0639
PE
7603 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7604 instead of using an uninitialized var.
5ad03b97 7605 (font_sort_entities): Mark var as initialized.
3ddb0639 7606
170a2692
PE
7607 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7608
e663c700
PE
7609 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7610 pointers to constants.
89bc529a 7611 (font_parse_fcname): Remove unused vars.
7b81e2d0 7612 (font_delete_unmatched): Now static.
ea838e10 7613 (font_get_spec): Remove; unused.
13a547c6
PE
7614 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7615 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7616 Rename or move locals to avoid shadowing.
e663c700 7617
2a80c887 7618 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7619 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7620
1384fa33 7621 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7622 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7623
8b2c52e9
PE
7624 * alloc.c (mark_backtrace): Move decl from here ...
7625 * lisp.h: ... to here, so that it can be checked.
7626
475545b5 7627 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7628 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7629 (lisp_indirect_variable): Name an expression,
7630 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7631 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7632
b1349114 7633 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7634 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7635 Use const pointer when appropriate.
b1349114 7636
a2928364
PE
7637 * lisp.h (get_system_name, get_operating_system_release):
7638 Move decls here, to check interfaces.
7639 * process.c (get_operating_system_release): Move decl to lisp.h.
7640 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7641 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7642 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7643 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7644 (Fformat_time_string, Fencode_time, Finsert_char):
7645 (Ftranslate_region_internal, Fformat):
7646 Rename or remove local vars to avoid shadowing.
9710023e 7647 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7648
a415e694
PE
7649 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7650 avoid shadowing.
7651
8ef4622d
PE
7652 * lisp.h (eassert): Check that the argument compiles, even if
7653 ENABLE_CHECKING is not defined.
7654
946f9a5b
PE
7655 * data.c (Findirect_variable): Name an expression, to avoid
7656 gcc -Wbad-function-cast warning.
112396d6 7657 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7658 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7659 (Fmake_variable_buffer_local, Fmake_local_variable):
7660 Mark variables as initialized.
52746918 7661 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7662
e5aab7e7 7663 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7664 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7665 Rename locals to avoid shadowing.
dff45157
PE
7666 (mark_stack): Move local variables into the #ifdef region where
7667 they're used.
7bc26fdb
PE
7668 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7669 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7670 needed otherwise.
7671 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7672 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7673 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7674
e5aab7e7
PE
7675 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7676 avoids undefined behavior in theory.
7677
4da60324
PE
7678 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7679
88043301
PE
7680 Use functions, not macros, for up- and down-casing (Bug#8254).
7681 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7682 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7683 to use the following functions instead of these macros.
7684 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7685 EMACS_INT, since callers assume the returned value fits in int.
7686 (upcase1): Likewise, for UPCASE_TABLE.
7687 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7688 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7689 the race-condition problem in the old DOWNCASE.
88043301 7690
19ed5445
PE
7691 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7692 Rename locals to avoid shadowing.
7693 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7694 (regex_compile, re_search_2, re_match_2_internal):
7695 Remove unused local vars.
952db0d7
PE
7696 (FREE_VAR): Rewrite so as not to use empty "else",
7697 which gcc can warn about.
da053e48 7698 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7699 (RETALLOC_IF): Define only if needed.
7700 (WORDCHAR_P): Likewise. This one is never needed, but is used
7701 only in a comment talking about a compiler bug, so put inside
7702 the #if 0 of that comment.
7703 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7704 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7705 Remove; unused.
19ed5445 7706
1f3561e4 7707 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7708 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7709 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7710
ded6f8f7
PE
7711 * search.c (simple_search): Remove unused var.
7712
dbd37a95
PE
7713 * dired.c (compile_pattern): Move decl from here ...
7714 * lisp.h: ... to here, so that it can be checked.
7715 (struct re_registers): New forward decl.
7716
7e47afad
PE
7717 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7718
85f24f61
PE
7719 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7720 All uses changed.
7721 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7722 Rename locals to avoid shadowing.
5671df8f 7723 (Fvertical_motion): Mark locals as initialized.
85f24f61 7724
181aa2be 7725 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7726 (casify_region): Mark local as initialized.
181aa2be 7727
930d429c
PE
7728 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7729
7082eac6
PE
7730 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7731 New macros, so that the caller can use some names other than
7732 gcpro1, gcpro2, etc.
7733 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7734 of the new macros.
7735 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7736 argument, for consistency with GCPRO2_VAR, etc: it is now the
7737 prefix of the variable, not the variable itself. All uses
7738 changed.
38b2c076
PE
7739 * dired.c (directory_files_internal, file_name_completion):
7740 Rename locals to avoid shadowing.
7741
15206ed9
PE
7742 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7743 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7744 dired.c's scmp function, had undefined behavior.
7745 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7746 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7747 * buffer.h: ... to here, because these macros use current_buffer,
7748 and the new implementation with inline functions needs to have
7749 current_buffer in scope now, rather than later when the macros
7750 are used.
7751 (downcase, upcase1): New static inline functions.
7752 (DOWNCASE, UPCASE1): Reimplement using these functions.
7753 This avoids undefined behavior in expressions like
7754 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7755 from race conditions in accessing the global variables
7756 case_temp1 and case_temp2.
7757 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7758 * lisp.h (case_temp1, case_temp2): Remove their decls.
7759 * character.h (ASCII_CHAR_P): Move from here ...
7760 * lisp.h: ... to here, so that the inline functions mentioned
7761 above can use them.
7762
4a6bea26
PE
7763 * dired.c (directory_files_internal_unwind): Now static.
7764
f14b7e14
PE
7765 * fileio.c (file_name_as_directory, directory_file_name):
7766 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7767 Now static.
2893f146
PE
7768 (file_name_as_directory): Use const pointers when appropriate.
7769 (Fexpand_file_name): Likewise. In particular, newdir might
7770 point at constant storage, so make it a const pointer.
fd4ead52 7771 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7772 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7773 signedness issues.
f839df0c
PE
7774 (Fset_file_times, Finsert_file_contents, auto_save_error):
7775 Rename locals to avoid shadowing.
f14b7e14 7776
5716756e 7777 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7778 (Ftry_completion, Fall_completions): Rename or remove locals
7779 to avoid shadowing.
5716756e 7780
b4c3046a
PE
7781 * marker.c (bytepos_to_charpos): Remove; unused.
7782
b45db522
PE
7783 * lisp.h (verify_bytepos, count_markers): New decls,
7784 so that gcc does not warn that these functions aren't declared.
7785
85876d07
PE
7786 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7787 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7788 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7789 (copy_text): Remove unused local var.
85876d07 7790
03d78a21 7791 * filelock.c (within_one_second): Now static.
b3dd38ab 7792 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7793
5df8f01b
PE
7794 * buffer.c (fix_overlays_before): Mark locals as initialized.
7795 (fix_start_end_in_overlays): Likewise. This function should be
7796 simplified by using pointers-to-pointers, but that's a different
7797 matter.
b1d876f1 7798 (switch_to_buffer_1): Now static.
8f54f30a
PE
7799 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7800 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7801
a70072c9 7802 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7803 Fix pointer signedness issue.
edced198
PE
7804 (sys_subshell): Mark local as volatile if checking for lint,
7805 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7806 (MAXPATHLEN): Define only if needed.
a70072c9 7807
a0977c44
PE
7808 * process.c (serial_open, serial_configure): Move decls from here ...
7809 * systty.h: ... to here, so that they can be checked.
7810
a884fdcc
PE
7811 * fns.c (get_random, seed_random): Move extern decls from here ...
7812 * lisp.h: ... to here, so that they can be checked.
7813
604efe86 7814 * sysdep.c (reset_io): Now static.
b8950c94 7815 (wait_for_termination_signal): Remove; unused.
604efe86 7816
38fc62d9
PE
7817 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7818 (copy_keymap_item, append_key, push_text_char_description):
7819 Now static.
1004a21a 7820 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7821 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7822 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7823 (describe_map_tree):
7824 Rename locals to avoid shadowing.
38fc62d9 7825
2f2650da
PE
7826 * keyboard.c: Declare functions static if they are not used elsewhere.
7827 (echo_char, echo_dash, cmd_error, top_level_2):
7828 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7829 (read_char, kbd_buffer_get_event, make_lispy_position):
7830 (make_lispy_event, make_lispy_movement, apply_modifiers):
7831 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7832 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7833 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7834 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7835 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7836
a053e86c 7837 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7838 (mark_kboards): Move decl here ...
7839 * alloc.c (mark_kboards): ... from here.
a053e86c 7840
4752793e
PE
7841 * lisp.h (force_auto_save_soon): New decl.
7842
74f10ca7 7843 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7844 (DEFINE_DUMMY_FUNCTION): New macro.
7845 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7846 Use it.
c03cd23f
PE
7847 (main): Add casts to avoid warnings
7848 if GCC considers string literals to be constants.
74f10ca7 7849
022e70d4
PE
7850 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7851
59d6fe83
PE
7852 * dbusbind.c: Pointer signedness fixes.
7853 (xd_signature, xd_append_arg, xd_initialize):
7854 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7855 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7856 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7857 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7858
78320123
PE
7859 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7860 if GCC considers string literals to be constants.
49cebcca 7861 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7862
35ac2a97
SM
78632011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7864
fb103ca9
SM
7865 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7866 (print_preprocess, print_object): New macro to fix last change.
7867
35ac2a97
SM
7868 * print.c (print_preprocess): Don't forget font objects.
7869
62973b41
JB
78702011-03-16 Juanma Barranquero <lekktu@gmail.com>
7871
7872 * emacs.c (USAGE3): Doc fixes.
7873
0e48bb22
AS
78742011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7875
7876 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7877 structure.
7878
7684e57b
JB
78792011-03-14 Juanma Barranquero <lekktu@gmail.com>
7880
7881 * lisp.h (VWindow_system, Qfile_name_history):
7882 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7883 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7884 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7885
7886 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7887 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7888
7889 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7890 * w32console.c (detect_input_pending, read_input_pending)
7891 (encode_terminal_code):
7892 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7893 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7894 (w32_system_caret_y, Qfile_name_history):
7895 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7896 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7897 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7898 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7899 * w32proc.c (Qlocal, report_file_error):
7900 * w32term.c (Vwindow_system, updating_frame):
7901 * w32uniscribe.c (initialized, uniscribe_font_driver):
7902 Remove unneeded extern declarations.
7903
2aa46d6c
CY
79042011-03-14 Chong Yidong <cyd@stupidchicken.com>
7905
c96bbc66 7906 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7907
cffc6f3b
CY
79082011-03-13 Chong Yidong <cyd@stupidchicken.com>
7909
7910 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7911 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7912 These macros can no longer be used for assignment.
7913
44f230aa
SM
7914 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7915 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7916 (record_buffer_markers, fetch_buffer_markers): New functions for
7917 recording and fetching special buffer markers.
7918 (set_buffer_internal_1, set_buffer_temp): Use them.
7919
7920 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7921
7922 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7923
7924 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7925 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7926
7927 * xdisp.c (hscroll_window_tree):
7928 (reconsider_clip_changes): Use PT instead of BUF_PT.
7929
d251f04b
EZ
79302011-03-13 Eli Zaretskii <eliz@gnu.org>
7931
7932 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7933 $(EMACS_ROOT)/lib/intprops.h.
7934
f0c77cd1
PE
79352011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7936
3eca4629
PE
7937 Fix more problems found by GCC 4.5.2's static checks.
7938
7c86ee98
PE
7939 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7940 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7941 (xg_free_frame_widgets): Make it clear that a local variable is
7942 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7943 (gdk_window_get_screen): Make it clear that this macro is needed
7944 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7945 (int_gtk_range_get_value): New function, which avoids a diagnostic
7946 from gcc -Wbad-function-cast.
7947 (xg_set_toolkit_scroll_bar_thumb): Use it.
7948 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7949 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7950 (get_utf8_string, xg_get_file_with_chooser):
7951 Rename locals to avoid shadowing.
7952 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7953
41729b81
PE
7954 * xgselect.c (xg_select): Remove unused var.
7955
f0c77cd1
PE
7956 * image.c (four_corners_best): Mark locals as initialized.
7957 (gif_load): Initialize transparent_p to zero (Bug#8238).
7958 Mark another local as initialized.
ec6cf4c6 7959 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7960
ce0ad53d 7961 * image.c (clear_image_cache): Now static.
d5d5a617 7962 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7963 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7964 (x_edge_detection): Remove unnecessary cast that
7965 gcc -Wbad-function-cast diagnoses.
2037898d 7966 (gif_load): Fix pointer signedness.
6ae141d6
PE
7967 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7968 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7969
33383987 79702011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7971
d32df629
PE
7972 Improve quality of tests for time stamp overflow.
7973 For example, without this patch (encode-time 0 0 0 1 1
7974 1152921504606846976) returns the obviously-bogus value (-948597
7975 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7976 reports time overflow. See
7977 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7978 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7979 * editfns.c: Include limits.h and intprops.h.
7980 (TIME_T_MIN, TIME_T_MAX): New macros.
7981 (time_overflow): Move earlier, to before first use.
7982 (hi_time, lo_time): New functions, for an accurate test for
7983 out-of-range times.
7984 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7985 (Fget_internal_run_time): Don't assume time_t fits in int.
7986 (make_time): Use list2 instead of Fcons twice.
7987 (Fdecode_time): More accurate test for out-of-range times.
7988 (check_tm_member): New function.
7989 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7990 (lisp_time_argument): Don't rely on undefined left-shift and
7991 right-shift behavior when checking for time stamp overflow.
8be6f318 7992
fe31d94c
PE
7993 * editfns.c (time_overflow): New function, refactoring common code.
7994 (Fformat_time_string, Fdecode_time, Fencode_time):
7995 (Fcurrent_time_string): Use it.
7996
8be6f318
PE
7997 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7998 * dired.c (make_time): Move to ...
7999 * editfns.c (make_time): ... here.
8000 * systime.h: Note the move.
8001
09d9db2c 80022011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8003
126bc0dc
YM
8004 * fringe.c (update_window_fringes): Remove unused variables.
8005
c47cbdfd
YM
8006 * unexmacosx.c (copy_data_segment): Also copy __got section.
8007 (Bug#8223)
8008
7ac80be9
EZ
80092011-03-12 Eli Zaretskii <eliz@gnu.org>
8010
c96bbc66 8011 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8012 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8013 Constify `char *' arguments and their references according to
8014 prototypes in tparam.h.
8015
ecb0f94d 8016 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8017
7ac80be9
EZ
8018 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8019 Adapt all references accordingly.
8020
8021 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8022
ef1fd07e
TT
80232011-03-11 Tom Tromey <tromey@redhat.com>
8024
8025 * buffer.c (syms_of_buffer): Remove obsolete comment.
8026
7ef4b50c
EZ
80272011-03-11 Eli Zaretskii <eliz@gnu.org>
8028
8029 * termhooks.h (encode_terminal_code): Declare prototype.
8030
8031 * msdos.c (encode_terminal_code): Don't declare prototype.
8032
8033 * term.c (encode_terminal_code): Now external again, used by
8034 w32console.c and msdos.c.
8035
44f230aa
SM
8036 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8037 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8038
4b1ec863 80392011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8040
1714f52b 8041 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8042
4b1ec863
PE
8043 * fringe.c (update_window_fringes): Mark locals as initialized
8044 (Bug#8227).
8045 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8046
524c7aa6
PE
8047 * alloc.c (mark_fringe_data): Move decl from here ...
8048 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8049 to check its interface.
8050 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8051
a5c0af81 8052 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8053 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8054 (fontset_font): Mark local as initialized.
a9a06e0b 8055 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8056
b4716021
PE
8057 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8058
811e9bac 8059 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8060 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8061 (x_own_selection, Fx_disown_selection_internal): Rename locals
8062 to avoid shadowing.
8063 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8064
7e3ab302
PE
8065 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8066 so that the caller can use some name other than gcpro1.
8067 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8068 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8069 (Fx_backspace_delete_keys_p):
8070 Use them to avoid shadowing, and rename vars to avoid shadowing.
8071 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8072 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8073 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8074 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8075 Remove unused locals.
7e3ab302
PE
8076 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8077 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8078 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8079 macros.
f78faa98 8080
e2b13473
PE
8081 * xterm.h (x_mouse_leave): New decl.
8082
77f23912
PE
8083 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8084 Remove unused functions.
cdf4ba58
PE
8085 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8086 (x_calc_absolute_position): Now static.
7411c686 8087 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8088 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8089 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8090 unless they are used.
38d0b34a
PE
8091 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8092 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8093 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8094 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8095 (x_error_catcher, x_connection_closed, x_error_handler):
8096 (x_error_quitter, xembed_send_message, x_iconify_frame):
8097 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8098 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8099 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8100
44f230aa
SM
8101 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8102 Rename or move locals to avoid shadowing.
6b463e58 8103 (tty_defined_color, merge_face_heights): Now static.
5967d051 8104 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8105 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8106 does not deduce is never used uninitialized.
73719eba
PE
8107 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8108 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8109
426994c3 8110 * terminal.c (store_terminal_param): Now static.
5489860b 8111
032f1620 8112 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8113 (set_frame_menubar): Remove unused local.
d4323972 8114 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8115 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8116 since they might point to immutable storage.
281585b0
PE
8117 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8118 since it's unused otherwise.
032f1620 8119
367c19e5 8120 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8121 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8122 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8123 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8124 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8125 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8126 does not deduce are never used uninitialized.
70739cbe 8127
07b48fa9
PE
8128 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8129
8868a238 8130 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8131 * window.c (window_loop, size_window):
8132 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8133
7e5cf297 8134 * window.c (display_buffer): Now static.
d6550a9f
PE
8135 (size_window): Mark variables that gcc -Wuninitialized
8136 does not deduce are never used uninitialized.
a586633d
PE
8137 * window.h (check_all_windows): New decl, to forestall
8138 gcc -Wmissing-prototypes diagnostic.
5b555da1 8139 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8140
f6095868
PE
8141 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8142 shadowing.
8143 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8144 Include <limits.h>.
8145 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8146 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8147 (load_charset_map): Mark variables that gcc -Wuninitialized
8148 does not deduce are never used uninitialized.
53df7c11 8149 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8150
f38b440c
PE
8151 * coding.c (coding_set_source, coding_set_destination):
8152 Use "else { /* comment */ }" rather than "else /* comment */;"
8153 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8154 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8155 a block, when the outer 'i' will do.
8156 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8157 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8158 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8159 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8160 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8161 Rename locals to avoid shadowing.
8162 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8163 * coding.c (emacs_mule_char, encode_invocation_designation):
8164 Now static, since they're not used elsewhere.
413bb2db 8165 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8166 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8167 (decode_coding_emacs_mule): Mark variables that gcc
8168 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8169 (detect_coding_iso_2022): Initialize a local variable that might
8170 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8171 this initialization is needed. (Bug#8211)
5f58e762
PE
8172 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8173 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8174 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8175 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8176 Remove unused macros.
f38b440c 8177
232b38b9 8178 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8179 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8180 * character.c (string_count_byte8): Likewise.
232b38b9 8181
fb90da1b
PE
8182 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8183 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8184
fb93dbc2
PE
8185 * chartab.c (copy_sub_char_table): Now static, since it's not used
8186 elsewhere.
5c156ace
PE
8187 (sub_char_table_ref_and_range, char_table_ref_and_range):
8188 Rename locals to avoid shadowing.
bbcd0949 8189 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8190
7d3b3862 8191 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8192 (BIDI_BOB): Remove unused macro.
7d3b3862 8193
6be7d3da
PE
8194 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8195 deduce are never used uninitialized.
c2ed9c8b 8196 * term.c (encode_terminal_code): Likewise.
6be7d3da 8197
75f8807f 8198 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8199
50938595
PE
8200 * tparam.h: New file.
8201 * term.c, tparam.h: Include it.
8202 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8203 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8204 Move these decls to tparam.h, and make them agree with what
8205 is actually in tparam.c. The previous trick of using incompatible
8206 decls in different modules does not conform to the C standard.
8207 All callers of tparam changed to use tparam's actual API.
8208 * tparam.c (tparam1, tparam, tgoto):
8209 Use const pointers where appropriate.
8210
fbceeba2
PE
8211 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8212 * cm.h (struct cm): Likewise.
8213 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8214 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8215 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8216 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8217 (turn_on_face, init_tty): Likewise.
8218 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8219
7f3f1250
PE
8220 * term.c (term_mouse_position): Rename local to avoid shadowing.
8221
e6ca6543
PE
8222 * alloc.c (mark_ttys): Move decl from here ...
8223 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8224
c40f8d15
AS
82252011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8226
8227 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8228
cfe0661d
JB
82292011-03-09 Juanma Barranquero <lekktu@gmail.com>
8230
8231 * search.c (compile_pattern_1): Remove argument regp, unused since
8232 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8233 (compile_pattern): Don't pass it.
8234
0afb4571
J
82352011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8236
8237 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8238 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8239 for ! HAVE_GTK3.
8240 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8241
8242 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8243
8244 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8245 gdk_window_get_screen, gdk_window_get_geometry,
8246 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8247 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8248 (xg_get_pixbuf_from_pixmap): New function.
8249 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8250 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8251 Call xg_get_pixbuf_from_pixmap instead of
8252 gdk_pixbuf_get_from_drawable.
8253 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8254 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8255 (xg_check_special_colors): Use GtkStyleContext and its functions
8256 for HAVE_GTK3.
8257 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8258 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8259 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8260 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8261 Call gtk_widget_get_preferred_size.
0afb4571
J
8262 (xg_frame_resized): gdk_window_get_geometry only takes 5
8263 parameters.
44f230aa
SM
8264 (xg_win_to_widget, xg_event_is_for_menubar):
8265 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8266 (xg_set_widget_bg): New function.
8267 (delete_cb): New function.
895009e1 8268 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8269 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8270 (xg_set_background_color): Call xg_set_widget_bg.
8271 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8272 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8273 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8274 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8275 if ! HAVE_GTK3.
8276 (update_frame_tool_bar): Call gtk_widget_hide.
8277 (xg_initialize): Use GDK_KEY_g.
8278
8279 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8280 if ! HAVE_GTK3
8281 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8282
8283 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8284 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8285 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8286
1c2cc4ef
JB
82872011-03-08 Juanma Barranquero <lekktu@gmail.com>
8288
8289 * w32xfns.c (select_palette): Check success of RealizePalette against
8290 GDI_ERROR, not zero.
8291
33383987 8292See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8293
8294;; Local Variables:
8295;; coding: utf-8
aac0c6e3
MR
8296;; End:
8297
33383987 8298 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8299
8300 This file is part of GNU Emacs.
8301
8302 GNU Emacs is free software: you can redistribute it and/or modify
8303 it under the terms of the GNU General Public License as published by
8304 the Free Software Foundation, either version 3 of the License, or
8305 (at your option) any later version.
8306
8307 GNU Emacs is distributed in the hope that it will be useful,
8308 but WITHOUT ANY WARRANTY; without even the implied warranty of
8309 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8310 GNU General Public License for more details.
8311
8312 You should have received a copy of the GNU General Public License
8313 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.