* erc.el (erc-generate-new-buffer-name): Reuse old buffer names
[bpt/emacs.git] / src / ChangeLog
CommitLineData
90186c68
LMI
12011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * fns.c (Frequire): Remove the mention of the .gz files, since
4 that's installation-specific, but keep the mention of
5 `get-load-suffixes'.
6
da64016e
PE
72011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8
9 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10 Report string overflow if the output is too long.
11
7d47b580
JB
122011-07-04 Juanma Barranquero <lekktu@gmail.com>
13
a555cb87
JB
14 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
15 (syms_of_gnutls): Remove duplicate DEFSYM for
16 Qgnutls_bootprop_verify_hostname_error, an error for
17 Qgnutls_bootprop_verify_error (which is no longer used).
18
7d47b580
JB
19 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
20 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
21 Also (re)move comments that are misplaced or no longer relevant.
22
1e49bfab
LMI
232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
24
25 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
26
1485f4c0
CY
272011-07-03 Chong Yidong <cyd@stupidchicken.com>
28
29 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
30 and background color parameters if they have been changed.
31
a9ab721e
LMI
322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
33
34 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
35
cf7cff57
PE
362011-07-03 Paul Eggert <eggert@cs.ucla.edu>
37
2e13213d
PE
38 * xsettings.c (SYSTEM_FONT): Define only when used.
39 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
40
cf7cff57
PE
41 * keymap.c (access_keymap_1): Now static.
42
7a8e04f7
CY
432011-07-02 Chong Yidong <cyd@stupidchicken.com>
44
45 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
46 leave any prefix arg for the up event (Bug#1586).
47
61352f62
LMI
482011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
49
69bb1ef7
LMI
50 * lread.c (syms_of_lread): Mention single symbols defined by
51 `defvar' or `defconst' (bug#7154).
52
61352f62 53 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 54 (Frequire): Mention get-load-suffixes.
61352f62 55
28545e04
MR
562011-07-02 Martin Rudalics <rudalics@gmx.at>
57
58 * window.h (window): Remove clone_number slot.
59 * window.c (Fwindow_clone_number, Fset_window_clone_number):
60 Remove.
61 (make_parent_window, make_window, saved_window)
62 (Fset_window_configuration, save_window_save): Don't deal with
63 clone numbers.
64 * buffer.c (Qclone_number): Remove declaration.
65 (sort_overlays, overlay_strings): Don't deal with clone numbers.
66
3349e122
SM
672011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 Add multiple inheritance to keymaps.
70 * keymap.c (Fmake_composed_keymap): New function.
71 (Fset_keymap_parent): Simplify.
72 (fix_submap_inheritance): Remove.
73 (access_keymap_1): New function extracted from access_keymap to handle
74 embedded parents and handle lists of maps.
75 (access_keymap): Use it.
76 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
77 (Fcopy_keymap): Handle embedded parents.
78 (Fcommand_remapping, define_as_prefix): Simplify.
79 (Fkey_binding): Simplify.
80 (syms_of_keymap): Move minibuffer-local-completion-map,
81 minibuffer-local-filename-completion-map,
82 minibuffer-local-must-match-map, and
83 minibuffer-local-filename-must-match-map to Elisp.
84 (syms_of_keymap): Defsubr make-composed-keymap.
85 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
86 (parse_menu_item): Trivial simplification.
87
3279eb87
GM
882011-07-01 Glenn Morris <rgm@gnu.org>
89
90 * Makefile.in (SETTINGS_LIBS): Fix typo.
91
4550efdf
KI
922011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
93
94 * coding.c (Fencode_coding_string): Record the last coding system
95 used, as the function doc string says (bug#8738).
96
0949d2b6
JD
972011-07-01 Jan Djärv <jan.h.d@swipnet.se>
98
99 * xsettings.c (store_monospaced_changed): Take new font as arg and
100 check for change against current_mono_font.
101 (EMACS_TYPE_SETTINGS): Remove this and related defines.
102 (emacs_settings_constructor, emacs_settings_get_property)
103 (emacs_settings_set_property, emacs_settings_class_init)
104 (emacs_settings_init, gsettings_obj): Remove.
105 (something_changedCB): New function for HAVE_GSETTINGS.
106 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
107 with value as argument.
108 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
109 g_settings_new (Bug#8967). Do not create gsettings_obj.
110 Remove calls to g_settings_bind. Connect something_changedCB to
111 "changed".
112
113 * xgselect.c: Add defined (HAVE_GSETTINGS).
114 (xgselect_initialize): Ditto.
115
116 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
117 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
118 xg_select.
119
bbc6b304
PE
1202011-07-01 Paul Eggert <eggert@cs.ucla.edu>
121
122 * eval.c (struct backtrace): Simplify and port the data structure.
123 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
124 signed bit field, as this assumption is not portable and it makes
125 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
126 "char debug_on_exit : 1" as this is not portable either; instead,
127 use the portable "unsigned int debug_on_exit : 1". Remove unused
128 member evalargs. Remove obsolete comments about cc bombing out.
129
9851bfc5
JD
1302011-06-30 Jan Djärv <jan.h.d@swipnet.se>
131
51bb811f 132 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
133 Let HAVE_GSETTINGS override HAVE_GCONF.
134 (store_monospaced_changed): New function.
135 (EMACS_SETTINGS): A new type derived from GObject to handle
136 GSettings notifications.
137 (emacs_settings_constructor, emacs_settings_get_property)
138 (emacs_settings_set_property, emacs_settings_class_init):
139 New functions.
140 (gsettings_client, gsettings_obj): New variables.
141 (GSETTINGS_SCHEMA): New define.
142 (something_changedCB): Call store_monospaced_changed.
143 (init_gsettings): New function.
144 (xsettings_initialize): Call init_gsettings.
145 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
146 to NULL.
147
148 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
149 GCONF_CFLAGS/LIBS.
150
5386012d
MR
1512011-06-29 Martin Rudalics <rudalics@gmx.at>
152
153 * window.c (resize_root_window, grow_mini_window)
154 (shrink_mini_window): Rename Qresize_root_window to
155 Qwindow_resize_root_window and Qresize_root_window_vertically to
156 Qwindow_resize_root_window_vertically.
157
f13e0b08
PE
1582011-06-28 Paul Eggert <eggert@cs.ucla.edu>
159
160 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
161
94515237
JB
1622011-06-27 Juanma Barranquero <lekktu@gmail.com>
163
164 * makefile.w32-in: Redesign dependencies so they reflect more
165 clearly which files are directly included by each source file,
166 and not through other includes.
167
e43b6e43
MR
1682011-06-27 Martin Rudalics <rudalics@gmx.at>
169
170 * buffer.c (Qclone_number): Declare static and DEFSYM it.
171 (sort_overlays, overlay_strings): When an overlay's clone number
172 matches the window's clone number process the overlay even if
173 the overlay's window property doesn't match the current window.
174
d68443dc
MR
175 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
176 (Fwindow_hchild): Rename to Fwindow_left_child.
177 (Fwindow_next): Rename to Fwindow_next_sibling.
178 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
179 (resize_window_check): Rename to window_resize_check.
180 (resize_window_apply): Rename to window_resize_apply.
181 (Fresize_window_apply): Rename to Fwindow_resize_apply.
182 (Fdelete_other_windows_internal, resize_frame_windows)
183 (Fsplit_window_internal, Fdelete_window_internal)
184 (grow_mini_window, shrink_mini_window)
185 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 186
c7e73be5
JD
1872011-06-26 Jan Djärv <jan.h.d@swipnet.se>
188
189 * emacsgtkfixed.h: State that this is only used with Gtk+3.
190 (emacs_fixed_set_min_size): Remove.
191 (emacs_fixed_new): Take frame as argument.
192
193 * emacsgtkfixed.c: State that this is only used with Gtk+3.
194 (_EmacsFixedPrivate): Remove minwidth/height.
195 Add struct frame *f.
196 (emacs_fixed_init): Initialize priv->f.
197 (get_parent_class, emacs_fixed_set_min_size): Remove.
198 (emacs_fixed_new): Set priv->f to argument.
199 (emacs_fixed_get_preferred_width)
200 (emacs_fixed_get_preferred_height): Use min_width/height from
201 frames size_hint to set minimum and natural (Bug#8919).
202 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
203 and use min_width/height from frames size_hint to set
204 min_width/height (Bug#8919).
205
206 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
207 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
208 indentation.
209
cf99dcf8
EZ
2102011-06-26 Eli Zaretskii <eliz@gnu.org>
211
212 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
213 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
214 called at ZV.
215
029529ac
CY
2162011-06-26 Chong Yidong <cyd@stupidchicken.com>
217
218 * process.c (wait_reading_process_output): Bypass select if
219 waiting for a cell while ignoring keyboard input, and input is
220 pending. Suggested by Jan Djärv (Bug#8869).
221
7a7ef429
PE
2222011-06-25 Paul Eggert <eggert@cs.ucla.edu>
223
224 Use gnulib's dup2 module instead of rolling our own.
225 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
226
11fdef7d 2272011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
228
229 * dispnew.c (scrolling_window): Before scrolling, turn off a
230 mouse-highlight in the window being scrolled.
231
cd3520a4
JB
2322011-06-24 Juanma Barranquero <lekktu@gmail.com>
233
234 Move DEFSYM to lisp.h and use everywhere.
235
236 * character.h (DEFSYM): Move declaration...
237 * lisp.h (DEFSYM): ...here.
238
239 * gnutls.c:
240 * minibuf.c:
241 * w32menu.c:
242 * w32proc.c:
243 * w32select.c: Don't include character.h.
244
245 * alloc.c (syms_of_alloc):
246 * buffer.c (syms_of_buffer):
247 * bytecode.c (syms_of_bytecode):
248 * callint.c (syms_of_callint):
249 * casefiddle.c (syms_of_casefiddle):
250 * casetab.c (init_casetab_once):
251 * category.c (init_category_once, syms_of_category):
252 * ccl.c (syms_of_ccl):
253 * cmds.c (syms_of_cmds):
254 * composite.c (syms_of_composite):
255 * dbusbind.c (syms_of_dbusbind):
256 * dired.c (syms_of_dired):
257 * dispnew.c (syms_of_display):
258 * doc.c (syms_of_doc):
259 * editfns.c (syms_of_editfns):
260 * emacs.c (syms_of_emacs):
261 * eval.c (syms_of_eval):
262 * fileio.c (syms_of_fileio):
263 * fns.c (syms_of_fns):
264 * frame.c (syms_of_frame):
265 * fringe.c (syms_of_fringe):
266 * insdel.c (syms_of_insdel):
267 * keymap.c (syms_of_keymap):
268 * lread.c (init_obarray, syms_of_lread):
269 * macros.c (syms_of_macros):
270 * msdos.c (syms_of_msdos):
271 * print.c (syms_of_print):
272 * process.c (syms_of_process):
273 * search.c (syms_of_search):
274 * sound.c (syms_of_sound):
275 * syntax.c (init_syntax_once, syms_of_syntax):
276 * terminal.c (syms_of_terminal):
277 * textprop.c (syms_of_textprop):
278 * undo.c (syms_of_undo):
279 * w32.c (globals_of_w32):
280 * window.c (syms_of_window):
281 * xdisp.c (syms_of_xdisp):
282 * xfaces.c (syms_of_xfaces):
283 * xfns.c (syms_of_xfns):
284 * xmenu.c (syms_of_xmenu):
285 * xsettings.c (syms_of_xsettings):
286 * xterm.c (syms_of_xterm): Use DEFSYM.
287
4228cf16
TZ
2882011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
289
cd3520a4 290 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 291
7fcccf1e
PE
2922011-06-23 Paul Eggert <eggert@cs.ucla.edu>
293
7efb4e0e
PE
294 Integer and buffer overflow fixes (Bug#8873).
295
ff5844ad
PE
296 * print.c (printchar, strout): Check for string overflow.
297 (PRINTPREPARE, printchar, strout):
298 Don't set size unless allocation succeeds.
299
90532f02
PE
300 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
301 for sizes. Check for string overflow more accurately.
302 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
303
6d84508d
PE
304 * macros.c: Integer and buffer overflow fixes.
305 * keyboard.h (struct keyboard.kbd_macro_bufsize):
306 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
307 Use ptrdiff_t, not int, for sizes.
308 Don't increment bufsize until after realloc succeeds.
309 Check for size-calculation overflow.
310 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
311
437b2cb4
PE
312 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
313
8b9ac8b4
PE
314 * lread.c: Integer overflow fixes.
315 (read_integer): Radix is now EMACS_INT, not int,
316 to improve quality of diagnostics for out-of-range radices.
317 Calculate buffer size correctly for out-of-range radices.
318 (read1): Check for integer overflow in radices, and in
319 read-circle numbers.
82cb60d3
PE
320 (read_escape): Avoid int overflow.
321 (Fload, openp, read_buffer_size, read1)
322 (substitute_object_recurse, read_vector, read_list, map_obarray):
323 Use ptrdiff_t, not int, for sizes.
324 (read1): Use EMACS_INT, not int, for sizes.
20270765 325 Check for size overflow.
8b9ac8b4 326
7fcccf1e
PE
327 * image.c (cache_image): Check for size arithmetic overflow.
328
bfbbd7e7
PE
329 * lread.c: Integer overflow issues.
330 (saved_doc_string_size, saved_doc_string_length)
331 (prev_saved_doc_string_size, prev_saved_doc_string_length):
332 Now ptrdiff_t, not int.
333 (read1): Don't assume doc string length fits in int. Check for
334 out-of-range doc string lengths.
335 (read_list): Don't assume file position fits in int.
39019e54 336 (read_escape): Check for hex character overflow.
bfbbd7e7 337
4e323265
LL
3382011-06-22 Leo Liu <sdl.web@gmail.com>
339
340 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
341 Move to minibuffer.el.
342
85fece3e
PE
3432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
344
20b84ce9 345 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
346 The following patches are for when GLYPH_DEBUG && !XASSERT.
347 * dispextern.h (trace_redisplay_p, dump_glyph_string):
348 * dispnew.c (flush_stdout):
349 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
350 Mark as externally visible.
351 * dispnew.c (check_window_matrix_pointers): Now static.
352 * dispnew.c (window_to_frame_vpos):
353 * xfns.c (unwind_create_frame):
354 * xterm.c (x_check_font): Remove unused local.
355 * scroll.c (CHECK_BOUNDS):
356 * xfaces.c (cache_fache): Rename local to avoid shadowing.
357 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
358 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
359 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
360 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
361 Now static.
362 (debug_method_add): Use va_list and vsprintf rather than relying
363 on undefined behavior with wrong number of arguments.
364 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
365 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
366 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
367 since we're not interested in debugging glyphs with old libraries.
368 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
369 GCC 4.6.0's static checking.
370
0766b489
PE
3712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
372
31fd4b32
PE
373 Integer overflow and signedness fixes (Bug#8873).
374 A few related buffer overrun fixes, too.
375
b79e8648
PE
376 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
377
0766b489
PE
378 * dispextern.h (struct face.stipple):
379 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
380 (x_bitmap_mask, x_allocate_bitmap_record)
381 (x_create_bitmap_from_data, x_create_bitmap_from_file)
382 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
383 (x_create_bitmap_from_xpm_data):
384 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
385 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
386 (.bitmaps_last):
387 * xfaces.c (load_pixmap):
388 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
389 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
390 (.bitmaps_last, struct x_output.icon_bitmap):
391 Use ptrdiff_t, not int, for bitmap indexes.
392 (x_allocate_bitmap_record): Check for size overflow.
393 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
394
b081724f
PE
395 Use ptrdiff_t, not int, for overlay counts.
396 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
397 * editfns.c (overlays_around, get_pos_property):
398 * textprop.c (get_char_property_and_overlay):
399 * xdisp.c (next_overlay_change, note_mouse_highlight):
400 * xfaces.c (face_at_buffer_position):
21514da7
PE
401 * buffer.c (OVERLAY_COUNT_MAX): New macro.
402 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
403 (Fnext_overlay_change, Fprevious_overlay_change)
404 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 405 Use ptrdiff_t, not int, for sizes.
21514da7 406 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 407
3de73e5e
PE
408 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
409
2606c57b
PE
410 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
411 (x_session_initialize): Do not assume string length fits in int.
412
aaafe47a
PE
413 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
414 This is unlikely, but can occur if DPI is outlandish.
415
2674ddc8 416 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
417 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
418
28154962
PE
419 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
420 * xrdb.c (magic_file_p, search_magic_path):
421 Omit last arg SUFFIX; it was always 0. All callers changed.
422 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
423
7de51af5
PE
424 * xfont.c (xfont_match): Avoid need for strlen.
425
25ed6cc3
PE
426 * xfns.c: Don't assume strlen fits in int.
427 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
428
4eab31dd
PE
429 * xdisp.c (message_log_check_duplicate): Return intmax_t,
430 not unsigned long, as we prefer signed integers. All callers changed.
431 Detect integer overflow in repeat count.
432 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 433 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 434
171e2a58
PE
435 * termcap.c: Don't assume sizes fit in int and never overflow.
436 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
437 (gobble_line): Check for size-calculation overflow.
438
ad39faca 439 * minibuf.c (Fread_buffer):
6e5bb2dc 440 * lread.c (intern, intern_c_string):
74ca2eb3
PE
441 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
442 Don't assume string length fits in int.
443
52c61c22 444 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
445 * gtkutil.c (style_changed_cb): Avoid need for strlen.
446
b5b8c9e5
PE
447 * font.c: Don't assume string length fits in int.
448 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
449 Use ptrdiff_t, not int.
ccd6111c
PE
450 (font_intern_prop): Don't assume string length fits in int.
451 Don't assume integer property fits in fixnum.
452 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 453
882f0d81 454 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 455 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
456 Reformulate so as not to need the command string.
457 Invoke gzip -cd rather than gunzip, as it's more portable.
458 (lock_info_type, lock_file_1, lock_file):
459 Don't assume pid_t and time_t fit in unsigned long.
460 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
461 (current_lock_owner): Prefer signed type for sizes.
462 Use memcpy, not strncpy, where memcpy is what is really wanted.
463 Don't assume (via atoi) that time_t and pid_t fit in int.
464 Check for time_t and/or pid_t out of range, e.g., via a network share.
465 Don't alloca where an auto var works fine.
466
93f4cf88
PE
467 * fileio.c: Fix some integer overflow issues.
468 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
469 Don't assume string length fits in int.
470 (directory_file_name): Don't assume string length fits in long.
471 (make_temp_name): Don't assume pid fits in int, or that its print
472 length is less than 20.
473
f3e92b69
PE
474 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
475
1bfdaf10
PE
476 * coding.c (make_subsidiaries): Don't assume string length fits in int.
477
35016e9a
PE
478 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
479
3d1e65a1
PE
480 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
481 We prefer signed integers, even for size calculations.
482
0b963a93
PE
483 * emacs.c: Don't assume string length fits in 'int'.
484 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
485 (main): Don't invoke strlen when not needed.
486
573f4b54
PE
487 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
488 (XD_DEBUG_MESSAGE): Don't waste a byte.
489
989f33ba
PE
490 * callproc.c (getenv_internal_1, getenv_internal)
491 (Fgetenv_internal):
965d34eb
PE
492 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
493
e4d29b33
PE
494 * lread.c (invalid_syntax): Omit length argument.
495 All uses changed. This doesn't fix a bug, but it simplifies the
496 code away from its former Hollerith-constant appearance, and it's
497 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 498 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 499
eb49b136
PE
500 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
501 This didn't break anything, but it didn't help either.
502 It's confusing to put a bogus integer in a place where the actual
503 value does not matter.
9f62aeb1 504 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 505 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 506
15375a22
PE
507 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
508 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
509 implementation.
b61cc01c
PE
510 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
511 We prefer signed types, and the value cannot exceed the EMACS_INT
512 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
513 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
514 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
515 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 516
53b2623d
PE
517 * indent.c (sane_tab_width): New function.
518 (current_column, scan_for_column, Findent_to, position_indentation)
519 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 520 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 521
51cab52b 522 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 523
f2ed8a70
PE
524 * lisp.h (lint_assume): New macro.
525 * composite.c (composition_gstring_put_cache):
526 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
527
abe80cc6
PE
528 * editfns.c, insdel.c:
529 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 530
b02c740e
PE
531 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
532
ebc96716
PE
533 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
534
b4e50fa0 535 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 536 Use much-faster test for byte-length change.
311d5d7c 537 Don't assume string byte-length fits in 'int'.
a4cf38e4 538 Check that character arg fits in 'int'.
85461888 539 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 540
c0c1ee9f
PE
541 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
542
a498d7f4
PE
543 * fns.c (concat): Catch string overflow earlier.
544 Do not rely on integer wraparound.
545
51cab52b
PE
546 * dispextern.h (struct it.overlay_strings_charpos)
547 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
548 * xdisp.c (forward_to_next_line_start)
549 (back_to_previous_visible_line_start)
550 (reseat_at_next_visible_line_start, next_element_from_buffer):
551 Don't arbitrarily truncate the value of 'selective' to int.
552
76031fad
PE
553 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
554
5eb55db9
PE
555 * composite.c: Don't truncate sizes to 'int'.
556 (composition_gstring_p, composition_reseat_it)
557 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
558 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
559 not EMACS_UINT, for indexes.
5eb55db9 560
0703a717
PE
561 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
562
d6202519
PE
563 * buffer.c: Include <verify.h>.
564 (struct sortvec.priority, struct sortstr.priority):
8961a454 565 Now EMACS_INT, not int.
c20998a7 566 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
567 (struct sortstr.size, record_overlay_string)
568 (struct sortstrlist.size, struct sortlist.used):
569 Don't truncate size to int.
570 (record_overlay_string): Check for size-calculation overflow.
d6202519 571 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 572
d5a19415
JM
5732011-06-22 Jim Meyering <meyering@redhat.com>
574
029529ac 575 Don't leak an XBM-image-sized buffer
d5a19415
JM
576 * image.c (xbm_load): Free the image buffer after using it.
577
a9041e6c
PE
5782011-06-21 Paul Eggert <eggert@cs.ucla.edu>
579
580 Port to Sun C.
581 * composite.c (find_automatic_composition): Omit needless 'return 0;'
582 that Sun C diagnosed.
583 * fns.c (secure_hash): Fix pointer signedness issue.
584 * intervals.c (static_offset_intervals): New function.
585 (offset_intervals): Use it.
586
7f3f739f
LL
5872011-06-21 Leo Liu <sdl.web@gmail.com>
588
589 * deps.mk (fns.o):
590 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
591 sha512.h.
592
593 * fns.c (secure_hash): Rename from crypto_hash_function and change
594 the first arg to accept symbols.
5b66d427 595 (Fsecure_hash): New primitive.
7f3f739f
LL
596 (syms_of_fns): New symbols.
597
76147d94
DD
5982011-06-20 Deniz Dogan <deniz@dogan.se>
599
600 * process.c (Fset_process_buffer): Clarify return value in
601 docstring.
602
7d7d0045
CY
6032011-06-18 Chong Yidong <cyd@stupidchicken.com>
604
605 * dispnew.c (add_window_display_history): Use BVAR.
606
607 * xdisp.c (debug_method_add): Use BVAR.
608 (check_window_end, dump_glyph_matrix, dump_glyph)
609 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
610
611 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
612 Likewise.
613
614 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
615 check till after the cache is created in init_frame_faces.
616
ff2bc410
SM
6172011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
618
619 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
620
28177add
PE
6212011-06-16 Paul Eggert <eggert@cs.ucla.edu>
622
dd3482fe
PE
623 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
624 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
625 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
626
393d71f3 627 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
628 * fileio.c (Finsert_file_contents):
629 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
630 Remove the old (too-loose) buffer overflow checks.
631 They weren't needed, since make_gap checks for buffer overflow.
632 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
633 The old code merely checked for Emacs fixnum overflow, and relied
634 on undefined (wraparound) behavior. The new code avoids undefined
635 behavior, and also checks for ptrdiff_t and/or size_t overflow.
636
2e6813b0 637 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
638 Tune. Don't use wider integers than needed. Don't use alloca.
639 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 640
599a9e4f
PE
641 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
642
99561444
PE
643 * insdel.c, lisp.h (buffer_overflow): New function.
644 (insert_from_buffer_1, replace_range, replace_range_2):
645 * insdel.c (make_gap_larger):
646 * editfns.c (Finsert_char):
647 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
648
28177add
PE
649 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
650
e69dafad
PE
6512011-06-15 Paul Eggert <eggert@cs.ucla.edu>
652
a7af7fde 653 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 654
b1c46f02
PE
655 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
656 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
657
e69dafad
PE
658 * fileio.c: Don't assume EMACS_INT fits in off_t.
659 (emacs_lseek): New static function.
660 (Finsert_file_contents, Fwrite_region): Use it.
661 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
662
566684ea
PE
663 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
664
e6966cd6
PE
665 * fns.c: Don't overflow int when computing a list length.
666 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
667 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
668 truncation on 64-bit hosts. Check for QUIT every
669 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
670 faster and is responsive enough.
671 (Flength): Report an error instead of overflowing an integer.
672 (Fsafe_length): Return a float if the value is not representable
673 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 674 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 675 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 676
dd0b0efb
PE
677 * alloc.c: Check that resized vectors' lengths fit in fixnums.
678 (header_size, word_size): New constants.
679 (allocate_vectorlike): Don't check size overflow here.
680 (allocate_vector): Check it here instead, since this is the only
681 caller of allocate_vectorlike that could cause overflow.
682 Check that the new vector's length is representable as a fixnum.
683
86fe5cfe
PE
684 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
685 The previous code was bogus. For example, next_almost_prime (32)
686 returned 39, which is undesirable as it is a multiple of 3; and
687 next_almost_prime (24) returned 25, which is a multiple of 5 so
688 why was the code bothering to check for multiples of 7?
689
80e88859
PE
690 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
691
4a2f0ad6
PE
692 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
693
f66c7cf8
PE
694 Variadic C functions now count arguments with ptrdiff_t.
695 This partly undoes my 2011-03-30 change, which replaced int with size_t.
696 Back then I didn't know that the Emacs coding style prefers signed int.
697 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
698 were being counted with int, which may truncate counts on 64-bit
699 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
700 * lisp.h (struct Lisp_Subr.function.aMANY)
701 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
702 Arg counts are now ptrdiff_t, not size_t.
703 All variadic functions and their callers changed accordingly.
704 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
705 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
706 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
707 * callint.c (Fcall_interactively): Check arg count for overflow,
708 to avoid potential buffer overrun. Use signed char, not 'int',
709 for 'varies' array, so that we needn't bother to check its size
710 calculation for overflow.
711 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
712 * eval.c (apply_lambda):
713 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
714 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
715 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
716
a1759b76
PE
717 * callint.c (Fcall_interactively): Don't use index var as event count.
718
d96be9fc
PE
719 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
720 * mem-limits.h (SIZE): Remove; no longer used.
721
a690a978 722 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 723
578c21e6
PE
724 Remove unnecessary casts.
725 * xterm.c (x_term_init):
726 * xfns.c (x_set_border_pixel):
727 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
728 These aren't needed now that we assume ANSI C.
729
96f53c6c
PE
730 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
731 It's more likely to cause problems (due to unsigned overflow)
732 than to cure them.
733
83c77d31
PE
734 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
735
ee2079f1
PE
736 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
737
6da65536
PE
738 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
739
7147c4a4
PE
740 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
741
193e32d9
PE
742 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
743
e5533da6
PE
744 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
745
9910e595
PE
746 GLYPH_CODE_FACE returns EMACS_INT, not int.
747 * dispextern.h (merge_faces):
748 * xfaces.c (merge_faces):
01103c44
PE
749 * xdisp.c (get_next_display_element, next_element_from_display_vector):
750 Don't assume EMACS_INT fits in int.
9910e595 751
2638320e
PE
752 * character.h (CHAR_VALID_P): Remove unused parameter.
753 * fontset.c, lisp.h, xdisp.c: All uses changed.
754
045eb8d9
PE
755 * editfns.c (Ftranslate_region_internal): Omit redundant test.
756
c1f134b5
PE
757 * fns.c (concat): Minor tuning based on overflow analysis.
758 This doesn't fix any bugs. Use int to hold character, instead
759 of constantly refetching from Emacs object. Use XFASTINT, not
760 XINT, for value known to be a character. Don't bother comparing
761 a single byte to 0400, as it's always less.
762
395fcb93 763 * floatfns.c (Fexpt):
327eeec8
PE
764 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
765
abbd3d23
PE
766 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
767 for characters.
768
684a03ef
PE
769 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
770
0fed43f3
PE
771 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
772 Without this fix, on a 64-bit host (aset S 0 4294967386) would
773 incorrectly succeed when S was a string, because 4294967386 was
774 truncated before it was used.
775
8fd02eb7
PE
776 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
777 Otherwise, an out-of-range integer could cause undefined behavior
778 on a 64-bit host.
779
f8c86b69
PE
780 * composite.c: Use int, not EMACS_INT, for characters.
781 (fill_gstring_body, composition_compute_stop_pos): Use int, not
782 EMACS_INT, for values that are known to be in character range.
783 This doesn't fix any bugs but is the usual style inside Emacs and
784 may generate better code on 32-bit machines.
785
34206dd2
PE
786 Make sure a 64-bit char is never passed to ENCODE_CHAR.
787 This is for reasons similar to the recent CHAR_STRING fix.
788 * charset.c (Fencode_char): Check that character arg is actually
789 a character. Pass an int to ENCODE_CHAR.
790 * charset.h (ENCODE_CHAR): Verify that the character argument is no
791 wider than 'int', as a compile-time check to prevent future regressions
792 in this area.
793
c5958d4c 794 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
795
796 Make sure a 64-bit char is never passed to CHAR_STRING.
797 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
798 by silently ignoring the top 32 bits, allowing some values
799 that were far too large to be valid characters.
800 * character.h: Include <verify.h>.
801 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
802 arguments are no wider than unsigned, as a compile-time check
803 to prevent future regressions in this area.
804 * data.c (Faset):
01103c44 805 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
806 (Fsubst_char_in_region):
807 * fns.c (concat):
808 * xdisp.c (decode_mode_spec_coding):
809 Adjust to CHAR_STRING's new requirement.
810 * editfns.c (Finsert_char, Fsubst_char_in_region):
811 * fns.c (concat): Check that character args are actually
812 characters. Without this test, these functions did the wrong
813 thing with wildly out-of-range values on 64-bit hosts.
814
d37ca623
PE
815 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
816 These casts should not be needed on 32-bit hosts, either.
817 * keyboard.c (read_char):
818 * lread.c (Fload): Remove casts to unsigned.
819
ea204efb
PE
820 * lisp.h (UNSIGNED_CMP): New macro.
821 This fixes comparison bugs on 64-bit hosts.
822 (ASCII_CHAR_P): Use it.
823 * casefiddle.c (casify_object):
01103c44 824 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
825 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
826 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
827 * dispextern.h (FACE_FROM_ID):
828 * keyboard.c (read_char): Use UNSIGNED_CMP.
829
41cb286c
PE
830 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
831 not to EMACS_INT, to avoid GCC warning.
832
4a1b9832
PE
833 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
834
55daad71
PE
835 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
836 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
837 isn't needed on 32-bit machines.
8f95c75c 838
01103c44
PE
839 * buffer.c (Fgenerate_new_buffer_name):
840 Use EMACS_INT for count, not int.
0ceccced 841 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
842
843 * data.c (Qcompiled_function): Now static.
844
c6f072e7
PE
845 * window.c (window_body_lines): Now static.
846
20ce5912
PE
847 * image.c (gif_load): Rename local to avoid shadowing.
848
9c4c5f81
PE
849 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
850 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
851 * alloc.c (make_save_value): Integer argument is now of type
852 ptrdiff_t, not int.
853 (mark_object): Use ptrdiff_t, not int.
854 * lisp.h (pD): New macro.
855 * print.c (print_object): Use it.
856
c0c5c8ae
PE
857 * alloc.c: Use EMACS_INT, not int, to count objects.
858 (total_conses, total_markers, total_symbols, total_vector_size)
859 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
860 (total_free_floats, total_floats, total_free_intervals)
861 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
862 Now EMACS_INT, not int. All uses changed.
863 (Fgarbage_collect): Compute overall total using a double, so that
864 integer overflow is less likely to be a problem. Check for overflow
865 when converting back to an integer.
5a25e253
PE
866 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
867 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
868 These were 'int' variables that could overflow on 64-bit hosts;
869 they were never used, so remove them instead of repairing them.
211a0b2a 870 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
871 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
872 Previously, this ceilinged at INT_MAX, but that doesn't work on
873 64-bit machines.
e46bb31a 874 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 875
c78baabf 876 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 877 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
878 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
879 when a (possibly-narrower) signed value would do just as well.
880 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 881
c9d624c6
PE
882 * alloc.c: Catch some string size overflows that we were missing.
883 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
884 for convenience in STRING_BYTES_MAX.
885 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
886 The definition here is exact; the one in lisp.h was approximate.
887 (allocate_string_data): Check for string overflow. This catches
888 some instances we weren't catching before. Also, it catches
889 size_t overflow on (unusual) hosts where SIZE_MAX <= min
890 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
891 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 892
c9d624c6
PE
893 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
894 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
895 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
896
353032ce
PE
897 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
898
2bccce07
PE
899 * alloc.c (Fmake_string): Check for out-of-range init.
900
0ac30604
SM
9012011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
902
903 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
904
c195f2de
JD
9052011-06-14 Jan Djärv <jan.h.d@swipnet.se>
906
907 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
908 xg_get_default_scrollbar_width.
909
910 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
911 (int_gtk_range_get_value): Move to the scroll bar part of the file.
912 (style_changed_cb): Call update_theme_scrollbar_width and call
913 x_set_scroll_bar_default_width and xg_frame_set_char_size for
914 all frames (Bug#8505).
915 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
916 Call gtk_window_set_resizable if HAVE_GTK3.
917 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
918 and height if HAVE_GTK3 (Bug#8505).
919 (scroll_bar_width_for_theme): New variable.
920 (update_theme_scrollbar_width): New function.
921 (xg_get_default_scrollbar_width): Move code to
922 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
923 (xg_initialize): Call update_theme_scrollbar_width.
924
925 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
926
927 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
928
e10ac9f1
MR
9292011-06-12 Martin Rudalics <rudalics@gmx.at>
930
931 * frame.c (make_frame): Call other_buffer_safely instead of
932 other_buffer.
933
934 * window.c (temp_output_buffer_show): Call display_buffer with
935 second argument Vtemp_buffer_show_specifiers and reset latter
936 immediately after the call.
937 (Vtemp_buffer_show_specifiers): New variable.
938 (auto_window_vscroll_p, next_screen_context_lines)
939 (Vscroll_preserve_screen_position): Remove leading asterisks from
940 doc-strings.
941
2d3c217e 9422011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 943
7b7f97e8 944 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
945 * buffer.c (Qclone_number): Remove for now, as it's unused.
946 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
947 (record_buffer): Remove unused local.
948 * frame.c (other_visible_frames, frame_buffer_list): Now static.
949 (set_frame_buffer_list): Remove; unused.
950 * frame.h (other_visible_frames): Remove decl.
951 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
952 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
953 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
954 if HAVE_GPM.
955 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
956 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
957 Define only if HAVE_GPM.
958 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
959 (update_hints_inhibit): Remove; never set. All uses removed.
960 * widgetprv.h (emacsFrameClassRec): Remove decl.
961 * window.c (delete_deletable_window): Now returns void, since it
962 wasn't returning anything.
963 (compare_window_configurations): Remove unused locals.
964 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
965 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
966 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
967 the same widths as pointers. This follows up on the 2011-05-06 patch.
968 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
969 * xterm.h: Likewise.
970 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
971
1384b89e
JB
9722011-06-12 Juanma Barranquero <lekktu@gmail.com>
973
974 * makefile.w32-in: Update dependencies.
975 (LISP_H): Add lib/intprops.h.
976
1100a63c
CY
9772011-06-11 Chong Yidong <cyd@stupidchicken.com>
978
979 * image.c (gif_load): Add animation frame delay to the metadata.
980 (syms_of_image): Use DEFSYM. New symbol `delay'.
981
6198ccd0
MR
9822011-06-11 Martin Rudalics <rudalics@gmx.at>
983
984 * window.c (delete_deletable_window): Re-add.
985 (Fset_window_configuration): Rewrite to handle dead buffers and
986 consequently deletable windows.
987 (window_tree, Fwindow_tree): Remove. Supply functionality in
988 window.el.
989 (compare_window_configurations): Simplify code.
990
b6e3633c
AS
9912011-06-11 Andreas Schwab <schwab@linux-m68k.org>
992
1ab0dee5
AS
993 * image.c (imagemagick_load_image): Fix type mismatch.
994 (Fimagemagick_types): Likewise.
995
b6e3633c
AS
996 * window.h (replace_buffer_in_windows): Declare.
997
9397e56f
MR
9982011-06-11 Martin Rudalics <rudalics@gmx.at>
999
1000 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1001 Qclone_number. Remove external declaration of Qdelete_window.
1002 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1003 code.
1004 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1005 Qbuffer_list_update_hook if allowed.
1006 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1007 buffer list implementation.
1008 (other_buffer_safely): New function.
1009 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1010 calls to replace_buffer_in_windows and
1011 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1012 if allowed.
1013 (record_buffer): Inhibit quitting and rewrite using quittable
1014 functions. Run Qbuffer_list_update_hook if allowed.
1015 (Frecord_buffer, Funrecord_buffer): New functions.
1016 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1017 switch-to-buffer to window.el.
1018 (bury-buffer): Move to window.el.
1019 (Vbuffer_list_update_hook): New variable.
1020
1021 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1022 section.
1023
1024 * window.h (resize_frame_windows): Move up in code.
1025 (Fwindow_frame): Remove EXFUN.
1026 (replace_buffer_in_all_windows): Remove prototype.
1027 (replace_buffer_in_windows_safely): Add prototype.
1028
1029 * window.c: Declare Qdelete_window static again. Move down
1030 declaration of select_count.
1031 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1032 (Fother_window): Move to window.el.
1033 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1034 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1035 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1036 window.el.
1037 (replace_buffer_in_windows): Implement by calling
1038 Qreplace_buffer_in_windows.
1039 (replace_buffer_in_all_windows): Remove with some functionality
1040 moved into replace_buffer_in_windows_safely.
1041 (replace_buffer_in_windows_safely): New function.
1042 (select_window_norecord, select_frame_norecord): Move in front
1043 of run_window_configuration_change_hook. Remove now obsolete
1044 declarations.
1045 (Fset_window_buffer): Rewrite doc-string. Call
1046 Qrecord_window_buffer.
1047 (keys_of_window): Move binding for other-window to window.el.
1048
b50691aa
CY
10492011-06-11 Chong Yidong <cyd@stupidchicken.com>
1050
1051 * dispextern.h (struct image): Replace data member, whose int_val
1052 and ptr_val fields were not used by anything, with a single
1053 lisp_val object.
1054
1055 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1056 (gif_clear_image, gif_load, imagemagick_load_image)
1057 (gs_clear_image, gs_load): Callers changed.
1058
3f754b86
PE
10592011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1060
cca69397
PE
1061 * buffer.h: Include <time.h>, for time_t.
1062 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1063
109e28d0
PE
1064 Fix minor problems found by static checking.
1065
60737f02
PE
1066 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1067
4b66faf3
PE
1068 Make identifiers static if they are not used in other modules.
1069 * data.c (Qcompiled_function, Qframe, Qvector):
1070 * image.c (QimageMagick, Qsvg):
1071 * minibuf.c (Qmetadata):
1072 * window.c (resize_window_check, resize_root_window): Now static.
1073 * window.h (resize_window_check, resize_root_window): Remove decls.
1074
109e28d0
PE
1075 * window.c (window_deletion_count, delete_deletable_window):
1076 Remove; unused.
46a4ce9e
PE
1077 (window_body_lines): Now static.
1078 (Fdelete_other_windows_internal): Mark vars as initialized.
1079 Make sure 'resize_failed' is initialized.
1080 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1081 (resize_window_apply): Remove unused local.
1082 * window.h (delete_deletable_window): Remove decl.
1083
109e28d0 1084 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1085 (imagemagick_load_image): Fix pointer signedness problem by changing
1086 last arg from unsigned char * to char *. All uses changed.
1087 Also, fix a local for similar reasons.
1088 Remove unused locals. Remove locals to avoid shadowing.
1089 (fn_rsvg_handle_free): Remove; unused.
1090 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1091 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1092
3f754b86
PE
1093 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1094
2547adb1
CY
10952011-06-10 Chong Yidong <cyd@stupidchicken.com>
1096
1097 * image.c (gif_load): Fix omitted cast error introduced by
1098 2011-06-06 change.
1099
2c8e37d4
MR
11002011-06-10 Martin Rudalics <rudalics@gmx.at>
1101
1102 * window.h (resize_proportionally, orig_total_lines)
1103 (orig_top_line): Remove from window structure.
1104 (set_window_height, set_window_width, change_window_heights)
1105 (Fdelete_window): Remove prototypes.
1106 (resize_frame_windows): Remove duplicate declaration.
1107
440a42e3
EZ
11082011-06-10 Eli Zaretskii <eliz@gnu.org>
1109
1110 * window.h (resize_frame_windows, resize_window_check)
1111 (delete_deletable_window, resize_root_window)
1112 (resize_frame_windows): Declare prototypes.
1113
1114 * window.c (resize_window_apply): Make definition be "static" to
1115 match the prototype.
1116
562dd5e9
MR
11172011-06-10 Martin Rudalics <rudalics@gmx.at>
1118
1119 * window.c: Remove declarations of Qwindow_size_fixed,
1120 window_min_size_1, window_min_size_2, window_min_size,
1121 size_window, window_fixed_size_p, enlarge_window, delete_window.
1122 Remove static from declaration of Qdelete_window, it's
1123 temporarily needed by Fbury_buffer.
1124 (replace_window): Don't assign orig_top_line and
1125 orig_total_lines.
1126 (Fdelete_window, delete_window): Remove. Window deletion is
1127 handled by window.el.
1128 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1129 Fdelete_window calls with calls to Qdelete_window.
1130 (Fdelete_other_windows): Remove. Deleting other windows is
1131 handled by window.el.
1132 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1133 handled in window.el.
1134 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1135 Window minimum sizes are handled in window.el.
1136 (shrink_windows, size_window, set_window_height)
1137 (set_window_width, change_window_heights, window_height)
1138 (window_width, CURBEG, CURSIZE, enlarge_window)
1139 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1140 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1141 handled in window.el.
1142 (make_dummy_parent): Rename to make_parent_window and give it a
1143 second argument horflag.
1144 (make_window): Don't set resize_proportionally any more.
1145 (Fsplit_window): Remove. Windows are split in window.el.
1146 (save_restore_action, save_restore_orig_size)
1147 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1148 Resize mini windows in window.el.
1149 (grow_mini_window, shrink_mini_window): Implement by calling
1150 Qresize_root_window_vertically, resize_window_check and
1151 resize_window_apply.
1152 (saved_window, Fset_window_configuration, save_window_save): Do
1153 not handle orig_top_line, orig_total_lines, and
1154 resize_proportionally.
1155 (window_min_height, window_min_width): Move to window.el.
1156 (keys_of_window): Move bindings for delete-other-windows,
1157 split-window, delete-window and enlarge-window to window.el.
1158
1159 * buffer.c: Temporarily extern Qdelete_window.
1160 (Fbury_buffer): Temporarily call Qdelete_window instead of
1161 Fdelete_window (Fbury_buffer will move to window.el soon).
1162
1163 * frame.c (set_menu_bar_lines_1): Remove code handling
1164 orig_top_line and orig_total_lines.
1165
1166 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1167 set_window_height but set heights directly.
1168 (change_frame_size_1): Use resize_frame_windows.
1169
1170 * xdisp.c (init_xdisp): Don't use set_window_height but set
1171 heights directly.
1172
1173 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1174 resize_frame_windows instead of change_window_heights and run
1175 run_window_configuration_change_hook.
1176
1177 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1178 instead of change_window_heights and run
1179 run_window_configuration_change_hook.
1180
1a13852e
MR
11812011-06-09 Martin Rudalics <rudalics@gmx.at>
1182
1183 * window.c (replace_window): Rename second argument REPLACEMENT to
1184 NEW. New third argument SETFLAG. Rewrite.
1185 (delete_window, make_dummy_parent): Call replace_window with
1186 third argument 1.
1187 (window_list_1): Move down in code.
1188 (run_window_configuration_change_hook): Move set_buffer part
1189 before select_frame_norecord part in order to unwind correctly.
1190 Rename count1 to count.
1191 (recombine_windows, delete_deletable_window, resize_root_window)
1192 (Fdelete_other_windows_internal)
1193 (Frun_window_configuration_change_hook, make_parent_window)
1194 (resize_window_check, resize_window_apply, Fresize_window_apply)
1195 (resize_frame_windows, Fsplit_window_internal)
1196 (Fdelete_window_internal, Fresize_mini_window_internal): New
1197 functions.
1198 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1199
f3d1777e
MR
12002011-06-08 Martin Rudalics <rudalics@gmx.at>
1201
496e208e
MR
1202 * window.h (window): Add some new members to window structure -
1203 normal_lines, normal_cols, new_total, new_normal, clone_number,
1204 splits, nest, prev_buffers, next_buffers.
1205 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1206 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1207
f3d1777e
MR
1208 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1209 Remove.
496e208e
MR
1210 (make_dummy_parent): Set new members of windows structure.
1211 (make_window): Move down in code. Handle new members of window
1212 structure.
1213 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1214 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1215 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1216 (Fset_window_prev_buffers, Fwindow_next_buffers)
1217 (Fset_window_next_buffers, Fset_window_clone_number): New
1218 functions.
1219 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1220 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1221 Doc-string fixes.
1222 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1223 Argument WINDOW can be now internal window too.
1224 (Fwindow_use_time): Move up in code.
1225 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1226 Rewrite doc-string.
1227 (Fset_window_configuration, saved_window)
1228 (Fcurrent_window_configuration, save_window_save): Handle new
1229 members of window structure.
b9e809c2
MR
1230 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1231 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1232 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1233 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1234 Qget_mru_window, Qresize_root_window,
1235 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1236 Qauto_buffer_name; staticpro them.
f3d1777e 1237
abde8f8c
MR
12382011-06-07 Martin Rudalics <rudalics@gmx.at>
1239
1240 * window.c (Fwindow_total_size, Fwindow_left_column)
1241 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1242 (Fwindow_list_1): New functions.
1243 (window_box_text_cols): Replace with window_body_cols.
1244 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1245 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1246 (delete_window, Fset_window_configuration): Call
1247 delete_all_subwindows with window as argument.
1248 (delete_all_subwindows): Take a window as argument and not a
1249 structure. Rewrite.
190b47e6
MR
1250 (window_loop): Remove handling of GET_LRU_WINDOW and
1251 GET_LARGEST_WINDOW.
1252 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1253
1254 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1255 window_box_text_cols. delete_all_subwindows now takes a
1256 Lisp_Object as argument.
abde8f8c
MR
1257
1258 * indent.c (compute_motion, Fcompute_motion): Use
1259 window_body_cols instead of window_box_text_cols.
1260
fa8a67e6
MR
1261 * frame.c (delete_frame): Call delete_all_subwindows with root
1262 window as argument.
1263
a54e3482
DC
12642011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1265
1266 * fns.c (Fputhash): Document return value.
1267
60002bf5
CY
12682011-06-06 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1271
0c671da6 12722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1273
b862a52a 1274 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1275
be44ca6c
PE
1276 Check for overflow when converting integer to cons and back.
1277 * charset.c (Fdefine_charset_internal, Fdecode_char):
1278 Use cons_to_unsigned to catch overflow.
1279 (Fencode_char): Use INTEGER_TO_CONS.
1280 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1281 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1282 * data.c (long_to_cons, cons_to_long): Remove.
1283 (cons_to_unsigned, cons_to_signed): New functions.
1284 These signal an error for invalid or out-of-range values.
1285 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1286 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1287 * font.c (Ffont_variation_glyphs):
1288 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1289 * lisp.h: Include <intprops.h>.
1290 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1291 (cons_to_signed, cons_to_unsigned): New decls.
1292 (long_to_cons, cons_to_long): Remove decls.
1293 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1294 (Fprimitive_undo): Use CONS_TO_INTEGER.
1295 * xfns.c (Fx_window_property): Likewise.
1296 * xselect.c: Include <limits.h>.
1297 (x_own_selection, selection_data_to_lisp_data):
1298 Use INTEGER_TO_CONS.
1299 (x_handle_selection_request, x_handle_selection_clear)
1300 (x_get_foreign_selection, Fx_disown_selection_internal)
1301 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1302 (lisp_data_to_selection_data): Use cons_to_unsigned.
1303 (x_fill_property_data): Use cons_to_signed.
1304 Report values out of range.
1305
d1f3d2af
PE
1306 Check for buffer and string overflow more precisely.
1307 * buffer.h (BUF_BYTES_MAX): New macro.
1308 * lisp.h (STRING_BYTES_MAX): New macro.
1309 * alloc.c (Fmake_string):
1310 * character.c (string_escape_byte8):
1311 * coding.c (coding_alloc_by_realloc):
1312 * doprnt.c (doprnt):
1313 * editfns.c (Fformat):
1314 * eval.c (verror):
1315 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1316 since they may not be the same number.
1317 * editfns.c (Finsert_char):
1318 * fileio.c (Finsert_file_contents):
1319 Likewise for BUF_BYTES_MAX.
1320
dd52fcea
PE
1321 * image.c: Use ptrdiff_t, not int, for sizes.
1322 (slurp_file): Switch from int to ptrdiff_t.
1323 All uses changed.
1324 (slurp_file): Check that file size fits in both size_t (for
1325 malloc) and ptrdiff_t (for sanity and safety).
1326
7f9bbdbb
PE
1327 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1328 if b->modtime has its maximal value.
1329
dfe18f82
PE
1330 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1331
84acfcf0
PE
1332 Don't assume time_t can fit into int.
1333 * buffer.h (struct buffer.modtime): Now time_t, not int.
1334 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1335 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1336
ccd9a01a
PE
1337 Minor fixes for signed vs unsigned integers.
1338 * character.h (MAYBE_UNIFY_CHAR):
1339 * charset.c (maybe_unify_char):
1340 * keyboard.c (read_char, reorder_modifiers):
1341 XINT -> XFASTINT, since the integer must be nonnegative.
1342 * ftfont.c (ftfont_spec_pattern):
1343 * keymap.c (access_keymap, silly_event_symbol_error):
1344 XUINT -> XFASTINT, since the integer must be nonnegative.
1345 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1346 since it makes no difference and we prefer signed.
1347 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1348 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1349 nonnegative.
1350
d6d100dd
SM
13512011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1352
1353 * window.h (Fwindow_frame): Declare.
1354
2b6148e4
PE
13552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1358 (SPARE_MEMORY): Always define.
1359 (LARGE_REQUEST): Remove.
1360 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1361
f230ecc9
MR
13622011-06-06 Martin Rudalics <rudalics@gmx.at>
1363
727e958e
MR
1364 * lisp.h: Move EXFUNS for Fframe_root_window,
1365 Fframe_first_window and Fset_frame_selected_window to window.h.
1366
1367 * window.h: Move EXFUNS for Fframe_root_window,
1368 Fframe_first_window and Fset_frame_selected_window here from
1369 lisp.h.
1370
1371 * frame.c (Fwindow_frame, Fframe_first_window)
1372 (Fframe_root_window, Fframe_selected_window)
1373 (Fset_frame_selected_window): Move to window.c.
1374 (Factive_minibuffer_window): Move to minibuf.c.
1375 (Fother_visible_frames_p): New function.
1376
1377 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1378
f230ecc9
MR
1379 * window.c (decode_window, decode_any_window): Move up in code.
1380 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1381 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1382 (Fwindow_buffer): Move up and rewrite doc-string.
1383 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1384 (Fwindow_prev): New functions.
727e958e
MR
1385 (Fwindow_frame): Move here from frame.c. Accept any window as
1386 argument.
1387 (Fframe_root_window, Fframe_first_window)
1388 (Fframe_selected_window): Move here from frame.c. Accept frame
1389 or arbitrary window as argument. Update doc-strings.
1390 (Fminibuffer_window): Move up in code.
1391 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1392 (Fset_frame_selected_window): Move here from frame.c.
1393 Marginal rewrite.
727e958e
MR
1394 (Fselected_window, select_window, Fselect_window): Move up in
1395 code. Minor doc-string fixes.
f230ecc9 1396
4d09bcf6
PE
13972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1398
1399 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1400 Do not assume that spare memory exists; that assumption is valid
1401 only if SYSTEM_MALLOC.
1402 (LARGE_REQUEST): New macro, so that the issue of large requests
1403 is separated from the issue of spare memory.
1404
810928a2
AS
14052011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1406
172418ad
AS
1407 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1408 format. (Bug#8806)
1409
43f862f7
AS
1410 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1411
810928a2
AS
1412 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1413 before statements.
1414
a059fe24
JD
14152011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1416
1417 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1418
1419 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1420
1421 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1422 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1423
989bf368
JB
14242011-06-05 Juanma Barranquero <lekktu@gmail.com>
1425
1426 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1427
4b80f674
CY
14282011-06-04 Chong Yidong <cyd@stupidchicken.com>
1429
1430 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1431 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1432 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1433 New error handlers.
4b80f674
CY
1434 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1435 Obey Vx_select_enable_clipboard_manager. Catch errors in
1436 x_clipboard_manager_save (Bug#8779).
1437 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1438 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1439
99a33b77 14402011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1441
1442 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1443
99a33b77 14442011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1445
1446 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1447 in the current matrix if keep_current_p is non-zero.
1448
8264569d
EZ
14492011-06-04 Eli Zaretskii <eliz@gnu.org>
1450
1451 * bidi.c (bidi_level_of_next_char): Fix last change.
1452
57f97249
EZ
14532011-06-03 Eli Zaretskii <eliz@gnu.org>
1454
fec2107c 1455 Support bidi reordering of text covered by display properties.
57f97249 1456
fec2107c
EZ
1457 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1458 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1459 (bidi_cache_search, bidi_cache_iterator_state)
1460 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1461 (bidi_level_of_next_char, bidi_move_to_visually_next):
1462 Support character positions inside a run of characters covered by a
fec2107c
EZ
1463 display string.
1464 (bidi_paragraph_init, bidi_resolve_explicit_1)
1465 (bidi_level_of_next_char): Call bidi_fetch_char and
1466 bidi_fetch_char_advance instead of FETCH_CHAR and
1467 FETCH_CHAR_ADVANCE.
1468 (bidi_init_it): Initialize new members.
1469 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1470 definitions.
1471 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1472 instead of using explicit *_CHAR codes.
d6d100dd
SM
1473 (bidi_resolve_explicit, bidi_resolve_weak):
1474 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1475 bidirectional text is supported only in multibyte buffers.
1476 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1477 it to initialize the frame_window_p member of struct bidi_it.
1478 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1479 (bidi_resolve_explicit, bidi_resolve_weak)
1480 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1481 bidi_it->nchars is non-positive.
1482 (bidi_level_of_next_char): Don't try to lookup the cache for the
1483 next/previous character if nothing is cached there yet, or if we
1484 were just reseat()'ed to a new position.
c40e2fb2 1485
0e14fe90
EZ
1486 * xdisp.c (set_cursor_from_row): Set start and stop points
1487 according to the row's direction when priming the loop that looks
1488 for the glyph on which to display cursor.
1489 (single_display_spec_intangible_p): Function deleted.
1490 (display_prop_intangible_p): Reimplement to call
1491 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1492 Accept 3 additional arguments needed by handle_display_spec.
1493 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1494 values: lists, `(when COND...)' forms, etc.
1495 (single_display_spec_string_p): Support property values that are
1496 lists with the argument STRING its top-level element.
1497 (display_prop_string_p): Fix the condition for processing a
1498 property that is a list to be consistent with handle_display_spec.
fec2107c 1499 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1500 last portion of handle_display_prop.
1501 (compute_display_string_pos): Accept additional argument
1502 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1503 value of a `display' property is a "replacing spec".
1504 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1505 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1506 the display property, but just return a value indicating whether
1507 the display property will replace the characters it covers.
1508 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1509 frame_window_p members of struct bidi_it.
d6d100dd
SM
1510 (compute_display_string_pos, compute_display_string_end):
1511 New functions.
fec2107c
EZ
1512 (push_it): Accept second argument POSITION, where pop_it should
1513 jump to continue iteration.
1514 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1515
fec2107c
EZ
1516 * keyboard.c (adjust_point_for_property): Adjust the call to
1517 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1518
1519 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1520 (bidi_init_it): Update prototypes.
1521 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1522 (compute_display_string_pos, compute_display_string_end):
1523 Declare prototypes.
fec2107c
EZ
1524 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1525 EMACS_INT.
fc6f18ce 1526
40087514 15272011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1528
57f53182
PE
1529 Malloc failure behavior now depends on size of allocation.
1530 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1531 * lisp.h: Change signatures accordingly.
1532 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1533 All callers changed. (Bug#8762)
1534
1535 * gnutls.c: Use Emacs's memory allocators.
1536 Without this change, the gnutls library would invoke malloc etc.
1537 directly, which causes problems on non-SYNC_INPUT hosts, and which
1538 runs afoul of improving memory_full behavior. (Bug#8761)
1539 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1540 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1541 xfree instead of the default malloc, realloc, free.
1542 (Fgnutls_boot): No need to check for memory allocation failure,
1543 since xmalloc does that for us.
1544
ac32cd99 1545 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1546 * category.c (hash_get_category_set):
1547 * ccl.c (ccl_driver):
1548 * charset.c (Fdefine_charset_internal):
1549 * charset.h (struct charset.hash_index):
1550 * composite.c (get_composition_id, gstring_lookup_cache)
1551 (composition_gstring_put_cache):
1552 * composite.h (struct composition.hash_index):
1553 * dispextern.h (struct image.hash):
1554 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1555 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1556 (hashfn_equal, hashfn_user_defined, make_hash_table)
1557 (maybe_resize_hash_table, hash_lookup, hash_put)
1558 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1559 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1560 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1561 * image.c (make_image, search_image_cache, lookup_image)
1562 (xpm_put_color_table_h):
1563 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1564 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1565 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1566 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1567 * alloc.c (allocate_vectorlike):
1568 Check for overflow in vector size calculations.
1569 * ccl.c (ccl_driver):
1570 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1571 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1572 need to be updated by these changes.
40087514
PE
1573 * fns.c (make_hash_table, maybe_resize_hash_table):
1574 Check for integer overflow with large hash tables.
0de4bb68
PE
1575 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1576 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1577 (SXHASH_REDUCE): New macro.
1578 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1579 Use it instead of discarding useful hash info with large hash values.
1580 (sxhash_float): New function.
1581 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1582 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1583 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1584 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1585 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1586 Adjust signatures to match updated version of code.
1587 (consing_since_gc): Now EMACS_INT, since a single hash table can
1588 use more than INT_MAX bytes.
1589
698d32e2
DN
15902011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1591
1592 Make it possible to build with GCC-4.6+ -O2 -flto.
1593
1594 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1595
fd6fa53f
SM
15962011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1597
1598 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1599 Call minibuffer-inactive-mode.
1600
864db017
JB
16012011-05-31 Juanma Barranquero <lekktu@gmail.com>
1602
1603 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1604 Update dependencies.
1605
2ad0baf4
DN
16062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1607
1608 * data.c (init_data): Remove code for UTS, this system is not
1609 supported anymore.
1610
4fcc2638
DN
16112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1612
1613 Don't force ./temacs to start in terminal mode.
1614
1615 * frame.c (make_initial_frame): Initialize faces in all cases, not
1616 only when CANNOT_DUMP is defined.
1617 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1618
c56e0fd5
DN
16192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1620
1621 * dispnew.c (add_window_display_history): Use const for the string
1622 pointer. Remove declaration, not needed.
1623
333d54da 16242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1625
55d4c1b2 1626 Use 'inline', not 'INLINE'.
333d54da 1627 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1628 * alloc.c, fontset.c (INLINE): Remove.
1629 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1630 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1631 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1632 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1633 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1634
738db178
DN
16352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1636
1637 Make it possible to run ./temacs.
1638
1639 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1640 syms_of_callproc does the same thing. Remove test for
1641 "initialized", do it in the caller.
1642 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1643
620c53a6
SM
16442011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1645
1646 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1647 (read_minibuf): Use get_minibuffer.
1648 (syms_of_minibuf): Use DEFSYM.
1649 (Qmetadata): New var.
1650 * data.c (Qbuffer): Don't make it static.
1651 (syms_of_data): Use DEFSYM.
1652
e003a292
PE
16532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1656 (CCL_CODE_MIN): New macro.
1657
ed008a6d
PE
16582011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1659
3687c2ef
PE
1660 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1661
ed008a6d
PE
1662 * eval.c (Qdebug): Now static.
1663 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1664 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1665 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1666
d66c4c7c
CY
16672011-05-29 Chong Yidong <cyd@stupidchicken.com>
1668
1669 * image.c: Various fixes to ImageMagick code comments.
1670 (Fimagemagick_types): Doc fix.
1671
5fbc2025
PE
16722011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1673
0196f88a
PE
1674 Minor fixes prompted by GCC 4.6.0 warnings.
1675
1676 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1677
5fbc2025
PE
1678 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1679 (x_clipboard_manager_save_all): Move extern decl to ...
1680 * xterm.h: ... here, so that it can be checked for consistency.
1681
1dd3c2d9
CY
16822011-05-29 Chong Yidong <cyd@stupidchicken.com>
1683
1684 * xselect.c (x_clipboard_manager_save_frame)
1685 (x_clipboard_manager_save_all): New functions.
1686 (Fx_clipboard_manager_save): Lisp function deleted.
1687
1688 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1689 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1690
1691 * xterm.h: Update prototype.
1692
5ba6571d
WX
16932011-05-28 William Xu <william.xwl@gmail.com>
1694
1695 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1696 exiting (Bug#8239).
1697
3eaff834
JM
16982011-05-28 Jim Meyering <meyering@redhat.com>
1699
e1900994 1700 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1701 * fns.c (to_uchar): Define.
1702 (crypto_hash_function): Use it to convert some newly-signed
1703 variables to unsigned, to avoid sign-extension bugs. For example,
1704 without this change, (md5 "truc") would evaluate to
1705 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1706 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1707 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1708
0f6990a7
PE
17092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 Integer overflow fixes.
c8a9ca5a 1712
08686060
PE
1713 * dbusbind.c: Serial number integer overflow fixes.
1714 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1715 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1716 to hold a serial number that is too large for a fixnum.
1717 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1718 Check for serial numbers out of range. Decode any serial number
59568bf0 1719 that was so large that it became a float. (Bug#8722)
08686060 1720
2d1fc3c7
PE
1721 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1722 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1723 Use XFASTINT rather than XUINT when numbers are nonnegative.
1724 (xd_append_arg, Fdbus_method_return_internal):
1725 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1726 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1727 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1728 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1729 (Bug#8722)
2d1fc3c7 1730
c8a9ca5a
PE
1731 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1732
519e1d69
PE
1733 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1734
30569699
PE
1735 ccl: add integer overflow checks
1736 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1737 (IN_INT_RANGE): New macros.
1738 (ccl_driver): Use them to check for integer overflow when
1739 decoding a CCL program. Many of the new checks are whether XINT (x)
1740 fits in int; it doesn't always, on 64-bit hosts. The new version
1741 doesn't catch all possible integer overflows, but it's an
847044ea 1742 improvement. (Bug#8719)
30569699 1743
c11285dc
PE
1744 * alloc.c (make_event_array): Use XINT, not XUINT.
1745 There's no need for unsigned here.
1746
fdccd48e
PE
1747 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1748 This follows up to the 2011-05-06 change that substituted uintptr_t
1749 for EMACS_INT. This case wasn't caught back then.
1750
37910ab2
PE
1751 Rework Fformat to avoid integer overflow issues.
1752 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1753 now (part of C89). Include <verify.h>.
1754 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1755 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1756 (Fformat): Avoid the prepass trying to compute sizes; it was only
1757 approximate and thus did not catch overflow reliably. Instead, walk
1758 through the format just once, formatting and computing sizes as we go,
1759 checking for integer overflow at every step, and allocating a larger
1760 buffer as needed. Keep track separately whether the format is
1761 multibyte. Keep only the most-recently calculated precision, rather
1762 than them all. Record whether each argument has been converted to
1763 string. Use EMACS_INT, not int, for byte and char and arg counts.
1764 Support field widths and precisions larger than INT_MAX. Avoid
1765 sprintf's undefined behavior with conversion specifications such as %#d
1766 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1767 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1768 formatting out-of-range floating point numbers with int
1769 formats. (Bug#8668)
1770
2e6578fb
PE
1771 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1772
0ae6bdee
PE
1773 * data.c: Avoid integer truncation in expressions involving floats.
1774 * data.c: Include <intprops.h>.
1775 (arith_driver): When there's an integer overflow in an expression
1776 involving floating point, convert the integers to floating point
1777 so that the resulting value does not suffer from catastrophic
1778 integer truncation. For example, on a 64-bit host (* 4
1779 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1780 Do not rely on undefined behavior after integer overflow.
1781
de883a70
PE
1782 merge count_size_as_multibyte, parse_str_to_multibyte
1783 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1784 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1785 Check for integer overflow.
1786 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1787 since it's now a duplicate of the other. This is more of
1788 a character than a buffer op, so better that it's in character.c.
1789 * fns.c, print.c: Adjust to above changes.
1790
2ff916cb
PE
17912011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1792
1793 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1794
f1b54466
PE
17952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1796
fb1ac845
PE
1797 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1798 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1799 (x_clipboard_manager_save): Now static.
1800 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1801
f1b54466
PE
1802 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1803 (crypto_hash_function): Now static.
1804 Fix pointer signedness problems. Avoid unnecessary initializations.
1805
a9f737ee
CY
18062011-05-27 Chong Yidong <cyd@stupidchicken.com>
1807
1808 * termhooks.h (Vselection_alist): Make it terminal-local.
1809
1810 * terminal.c (create_terminal): Initialize it.
1811
1812 * xselect.c: Support for clipboard managers.
1813 (Vselection_alist): Move to termhooks.h as terminal-local var.
1814 (LOCAL_SELECTION): New macro.
1815 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1816 (symbol_to_x_atom): Remove gratuitous arg.
1817 (x_handle_selection_request, lisp_data_to_selection_data)
1818 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1819 (x_own_selection, x_get_local_selection, x_convert_selection):
1820 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1821 (some_frame_on_display): Delete unused function.
1822 (Fx_own_selection_internal, Fx_get_selection_internal)
1823 (Fx_disown_selection_internal, Fx_selection_owner_p)
1824 (Fx_selection_exists_p): New optional frame arg.
1825 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1826 (x_handle_selection_clear): Don't treat other terminals with the
1827 same keyboard specially. Use the terminal-local Vselection_alist.
1828 (x_clear_frame_selections): Use Frun_hook_with_args.
1829
1830 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1831
1832 * xterm.h: Add support for those atoms.
1833
e067f0c1
CY
18342011-05-26 Chong Yidong <cyd@stupidchicken.com>
1835
1836 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1837 (converted_selections, conversion_fail_tag): New global variables.
1838 (x_selection_request_lisp_error): Free the above.
1839 (x_get_local_selection): Remove unnecessary code.
1840 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1841 of converted selections stored in converted_selections.
1842 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1843 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1844 (x_convert_selection): New function.
1845 (x_handle_selection_event): Simplify.
1846 (x_get_foreign_selection): Don't ignore incoming requests while
1847 waiting for an answer; this will fail when we implement
1848 SAVE_TARGETS, and seems unnecessary anyway.
1849 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1850 (Vx_sent_selection_functions): Doc fix.
1851
0f4aebc0
LL
18522011-05-26 Leo Liu <sdl.web@gmail.com>
1853
1854 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1855
e61124cd
YM
18562011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1857
1858 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1859
1860 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1861 for fringe update if it has periodic bitmap.
1862 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1863 and fringe_bitmap_periodic_p.
1864
1865 * fringe.c (get_fringe_bitmap_data): New function.
1866 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1867 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1868 row. Mark glyph row for fringe update if periodicity changed.
1869
1870 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1871 for fringe update unless it has periodic bitmap.
1872
f16d9837
KH
18732011-05-25 Kenichi Handa <handa@m17n.org>
1874
1875 * xdisp.c (get_next_display_element): Set correct it->face_id for
1876 a static composition.
1877
e1b90ef6
LL
18782011-05-24 Leo Liu <sdl.web@gmail.com>
1879
1880 * deps.mk (fns.o):
1881 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1882
1883 * fns.c (crypto_hash_function, Fsha1): New function.
1884 (Fmd5): Use crypto_hash_function.
1885 (syms_of_fns): Add Ssha1.
1886
7400048f
PE
18872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1888
1889 * gnutls.c: Remove unused macros.
1890 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1891 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1892 Remove macros that are defined and never used.
1893 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1894
abb71cf4
CY
18952011-05-22 Chong Yidong <cyd@stupidchicken.com>
1896
1897 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1898 (Fx_get_selection_internal): Minor cleanup.
1899 (Fx_own_selection_internal): Rename arguments for consistency with
1900 select.el.
1901
6307db39
PE
19022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1905
f3d4e0a4
CY
19062011-05-22 Chong Yidong <cyd@stupidchicken.com>
1907
1908 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1909
4d8ade89
YM
19102011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1911
1912 * dispnew.c (scrolling_window): Don't exclude the case that the
1913 last enabled row in the desired matrix touches the bottom boundary.
1914
32078c8d
GM
19152011-05-21 Glenn Morris <rgm@gnu.org>
1916
1917 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1918 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1919 and add some more files.
32078c8d 1920
7285dc67
EZ
19212011-05-20 Eli Zaretskii <eliz@gnu.org>
1922
1923 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1924 report_file_error introduced by the change from 2011-05-07.
1925
89d1bd22
PE
19262011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * systime.h (Time): Define only if emacs is defined.
1929 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1930 where the include path doesn't have X11/X.h by default. See
1931 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1932
e23640bb 19332011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1934
1935 * composite.c (find_automatic_composition): Fix previous change.
1936
b9704ad9
GM
19372011-05-20 Glenn Morris <rgm@gnu.org>
1938
1939 * lisp.mk: New file, split from Makefile.in.
1940 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1941 (shortlisp): Remove.
1942 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1943
4a720484
GM
19442011-05-19 Glenn Morris <rgm@gnu.org>
1945
1946 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1947 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1948 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1949 (lisp): Set the order to that of loadup.el.
1950 (shortlisp): Make it a copy of $lisp.
1951 (SOME_MACHINE_LISP): Remove.
1952 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1953 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1954
a28d4396
KH
19552011-05-18 Kenichi Handa <handa@m17n.org>
1956
1957 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1958 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1959 (find_automatic_composition): Mostly rewrite for efficiency.
1960
a2b1fa8e
JB
19612011-05-18 Juanma Barranquero <lekktu@gmail.com>
1962
1963 * makefile.w32-in: Update dependencies.
1964
8e1f5610
CS
19652011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1966
1967 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1968 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1969
7025ee00 19702011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1971
cdfa6eab
PE
1972 Fix some integer overflow issues, such as string length overflow.
1973
06d6db33
PE
1974 * insdel.c (count_size_as_multibyte): Check for string overflow.
1975
2b4560a8
PE
1976 * character.c (lisp_string_width): Check for string overflow.
1977 Use EMACS_INT, not int, for string indexes and lengths; in
1978 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1979 the resulting string length overflows an EMACS_INT; instead,
1980 report a string overflow if no precision given. When checking for
1981 precision exhaustion, use a check that cannot possibly have
1982 integer overflow. (Bug#8675)
1983 * character.h (lisp_string_width): Adjust to new signature.
1984
cb93f9be
PE
1985 * alloc.c (string_overflow): New function.
1986 (Fmake_string): Use it. This doesn't change behavior, but saves
1987 a few bytes and will simplify future changes.
1988 * character.c (string_escape_byte8): Likewise.
1989 * lisp.h (string_overflow): New decl.
1990
1a1f3366
PE
1991 Fixups, following up to the user-interface timestamp change.
1992 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1993 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1994 * msdos.c (mouse_get_pos): Likewise.
1995 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1996 * w32gui.h (Time): Define by including "systime.h" rather than by
1997 declaring it ourselves. (Bug#8664)
1998
d4e3e4d3
PE
1999 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2000 * image.c (clear_image_cache): Likewise.
2001
f6a24d19
PE
2002 * term.c (term_mouse_position): Don't assume time_t wraparound.
2003
08dc5ae6
PE
2004 Be more systematic about user-interface timestamps.
2005 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2006 and sometimes 'EMACS_UINT', to represent these timestamps.
2007 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2008 This makes the code easier to follow, and makes it easier to catch
2009 integer overflow bugs such as Bug#8664.
2010 * frame.c (Fmouse_position, Fmouse_pixel_position):
2011 Use Time, not unsigned long, for user-interface timestamps.
2012 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2013 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2014 * keyboard.h (last_event_timestamp): Likewise.
2015 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2016 * menu.h (xmenu_show): Likewise.
2017 * term.c (term_mouse_position): Likewise.
2018 * termhooks.h (struct input_event.timestamp): Likewise.
2019 (struct terminal.mouse_position_hook): Likewise.
2020 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2021 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2022 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2023 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2024 what it was before.
2025 * menu.h, termhooks.h: Include "systime.h", for Time.
2026
8e55734a
PE
2027 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2028 Don't assume that the difference between two unsigned long values
2029 can fit into an integer. At this point, we know button_down_time
2030 <= event->timestamp, so the difference must be nonnegative, so
2031 there's no need to cast the result if double-click-time is
2032 nonnegative, as it should be; check that it's nonnegative, just in
2033 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2034 apart (about 25 days). (Bug#8664)
8e55734a 2035
841f1b75 2036 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2037 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2038
3e26f69c
PE
2039 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2040 that always fit in int. Use a sentinel instead of a counter, to
2041 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2042 * frame.h (struct frame): Use int for menu_bar_items_used
2043 instead of EMACS_INT, since it always fits in int.
3e26f69c 2044
5cc152c0
PE
2045 * menu.c (grow_menu_items): Check for int overflow.
2046
d89eb65e
PE
2047 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2048
5235bd3e
PE
2049 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2050 Before, the code was not consistent. These values cannot exceed
2051 2**31 - 1 so there's no need to make them unsigned.
2052 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2053 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2054 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2055 as modifiers.
2056 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2057
bc827e23
PE
2058 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2059 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2060 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2061 presumably because the widths might not match.
2062
78eb494e
PE
2063 * window.c (size_window): Avoid needless test at loop start.
2064
04f2d78b
CB
20652011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2066
2067 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2068
d2fc7e3d 20692011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2070
2071 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2072
d2fc7e3d 20732011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2074
2075 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2076 `width' to `bar_area_x' and `bar_area_width', respectively.
2077 (x_scroll_run): Take account of fringe background extension.
2078
04f2d78b
CB
2079 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2080 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2081 `bar_area_width', respectively.
2082 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2083 background extension.
2084
79b70037
GM
20852011-05-10 Jim Meyering <meyering@redhat.com>
2086
2087 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2088
2f142cc5
JB
20892011-05-10 Juanma Barranquero <lekktu@gmail.com>
2090
2091 * image.c (Finit_image_library): Return t for built-in image types,
2092 like pbm and xbm. (Bug#8640)
2093
57679c86
AS
20942011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2095
2096 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2097
888c9e86
EZ
20982011-05-07 Eli Zaretskii <eliz@gnu.org>
2099
b0512a1d
EZ
2100 * w32console.c (Fset_screen_color): Doc fix.
2101 (Fget_screen_color): New function.
2102 (syms_of_ntterm): Defsubr it.
2103
7285dc67
EZ
2104 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2105 unlink the temporary file if Fcall_process didn't create it in the
2106 first place.
2107 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2108 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2109 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2110 cue to call_process_cleanup not to close that handle.
2111
4d3fcc8e
BK
21122011-05-07 Ben Key <bkey76@gmail.com>
2113
2114 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2115 one of two shell specific rules, either bootstrap-temacs-CMD or
2116 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2117 to the previous implementation of the bootstrap-temacs rule.
2118 The bootstrap-temacs-CMD rule is similar to the previous
2119 implementation of the bootstrap-temacs rule except that it
2120 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2121 variable.
2122
2123 These changes, along with some changes to nt/configure.bat,
2124 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2125 earlier fix to add support for --cflags and --ldflags options
2126 that include quotes so that it works whether make uses cmd or
2127 sh as the shell.
2128
b4289b64
MA
21292011-05-06 Michael Albinus <michael.albinus@gmx.de>
2130
2131 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2132 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2133 is a constant.
2134 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2135 a string. Handle both cases.
2136 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2137 (Fdbus_register_method): Use Qinvalid_function.
2138
af4c0e28
JB
21392011-05-06 Juanma Barranquero <lekktu@gmail.com>
2140
2141 * makefile.w32-in: Update dependencies.
2142 (LISP_H): Add inttypes.h and stdin.h.
2143 (PROCESS_H): Add unistd.h.
2144
c51453d9
EZ
21452011-05-06 Eli Zaretskii <eliz@gnu.org>
2146
2147 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2148 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2149
8ff0ac3c 21502011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2151
4c4b566b
PE
2152 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2153
aab2b9b5
PE
2154 * term.c (vfatal): Remove stray call to va_end.
2155 It's not needed and the C Standard doesn't allow it here anyway.
2156
c378da0b
PE
2157 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2158 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2159
288b08c7
PE
2160 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2161 bytes.
2162
e3601888
PE
2163 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2164
db6c0e74
PE
2165 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2166
dd5963ea
PE
2167 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2168
88c9450f
PE
2169 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2170
2f9442b8
PE
2171 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2172
c032b5f8
PE
2173 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2174 * charset.c (Fdefine_charset_internal): Don't initialize
2175 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2176 32-bit int (Bug#8600).
a108c10b
PE
2177
2178 * lread.c (read_integer): Be more consistent with string-to-number.
2179 Use string_to_number to do the actual conversion; this avoids
2180 rounding errors and fixes some other screwups. Without this fix,
2181 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2182 (digit_to_number): Move earlier, for benefit of read_integer.
2183 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2184 not a digit in any supported base. (Bug#8602)
a108c10b 2185
ad5f9eea
PE
2186 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2187
aec1708a
PE
2188 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2189 to match comment at start of function. This also removes a
2190 GCC warning about overflow in a 32+64-bit port.
2191
47be4ab5
PE
2192 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2193
371cac43
PE
2194 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2195 Reported by Stefan Monnier in
2196 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2197 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2198 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2199
d01a7826
PE
2200 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2201 (EMACS_UINTPTR): Likewise, with uintptr_t.
2202
7fd47d5c
PE
2203 * lisp.h: Prefer 64-bit EMACS_INT if available.
2204 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2205 on 32-bit hosts that have 64-bit int, so that they can access
2206 large files.
122b0c86
PE
2207 However, temporarily disable this change unless the temporary
2208 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2209
8727937b
PE
2210 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2211
8ac068ac
PE
2212 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2213 This removes an assumption that EMACS_INT and long are the same
2214 width as pointers. The assumption is true for Emacs porting targets
2215 now, but we want to make other targets possible.
2216 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2217 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2218 In the rest of the code, change types of integers that hold casted
2219 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2220 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2221 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2222 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2223 No need to cast type when ORing.
2224 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2225 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2226 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2227 assume EMACS_INT is the same width as char *.
2228 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2229 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2230 Remove no-longer-needed casts.
2231 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2232 (xg_tool_bar_help_callback, xg_make_tool_item):
2233 Use EMACS_INTPTR to hold an integer
2234 that will be cast to void *; this can avoid a GCC warning
2235 if EMACS_INT is not the same width as void *.
2236 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2237 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2238 (current_message_1, set_message_1):
2239 Use a local to convert to proper width without a cast.
2240 * xmenu.c (dialog_selection_callback): Likewise.
2241
ede49d71
PE
2242 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2243 Also, don't assume VALBITS / RAND_BITS is less than 5,
2244 and don't rely on undefined behavior when shifting a 1 left into
2245 the sign bit.
2246 * lisp.h (get_random): Change signature to match.
2247
2f30ecd0
PE
2248 * lread.c (hash_string): Use size_t, not int, for hash computation.
2249 Normally we prefer signed values; but hashing is special, because
2250 it's better to use unsigned division on hash table sizes so that
2251 the remainder is nonnegative. Also, size_t is the natural width
2252 for hashing into memory. The previous code used 'int', which doesn't
2253 retain enough info to hash well into very large tables.
2254 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2255
2a866e7b
PE
2256 * dbusbind.c: Don't possibly lose pointer info when converting.
2257 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2258 Use XPNTR rather than XHASH, so that the high-order bits of
2259 the pointer aren't lost when converting through void *.
2260
51639eac
PE
2261 * eval.c (Fautoload): Don't double-shift a pointer.
2262
92394119
PE
2263 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2264
dbdb9a7c
JB
22652011-05-06 Juanma Barranquero <lekktu@gmail.com>
2266
2267 * gnutls.c (DEF_GNUTLS_FN):
2268 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2269
db7a0b4f
AS
22702011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2271
2272 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2273 marker. (Bug#8610)
2274
f7ff1b0f 22752011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2276
2277 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2278 New version that can reserve upto 2GB of heap space.
2279
f7ff1b0f 22802011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2281
2282 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2283
639c109b
TZ
22842011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2285
2286 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2287 `gnutls_certificate_set_x509_key_file'.
2288
d2127135
JB
22892011-05-05 Juanma Barranquero <lekktu@gmail.com>
2290
2291 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2292 Update dependencies.
2293
e968f4f3
JB
22942011-05-04 Juanma Barranquero <lekktu@gmail.com>
2295
2296 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2297 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2298 Remove unused parameter `fildes'.
2299 * process.c (read_process_output, send_process): Don't pass it.
2300
84d358f0
JB
23012011-05-04 Juanma Barranquero <lekktu@gmail.com>
2302
2303 Fix previous change: the library cache is defined in w32.c.
2304 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2305 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2306
0898ca10
JB
23072011-05-04 Juanma Barranquero <lekktu@gmail.com>
2308
2309 Implement dynamic loading of GnuTLS on Windows.
2310
2311 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2312 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2313 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2314 Declare.
2315
2316 * gnutls.c (Qgnutls_dll): Define.
2317 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2318 (gnutls_*): Declare function pointers.
2319 (init_gnutls_functions): New function to initialize function pointers.
2320 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2321 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2322 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2323 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2324 (emacs_gnutls_write, emacs_gnutls_read)
2325 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2326 (Fgnutls_available_p): New function.
2327 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2328 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2329 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2330
2331 * image.c: Include w32.h.
2332 (Vimage_type_cache): Delete.
2333 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2334 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2335 (w32_delayed_load): Move to w32.c.
2336
2337 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2338
2339 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2340 (w32_delayed_load): Move from image.c. When loading a library, record
2341 its filename in the :loaded-from property of the library id.
2342 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2343 Initialize and staticpro them.
2344 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2345
2346 * process.c: Include lisp.h before w32.h, not after.
2347 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2348 instead of gnutls_record_check_pending.
2349
2350 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2351
ff4de4aa
TZ
23522011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2353
2354 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2355 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2356 as passed in.
2357
abe95abb
JD
23582011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2359
2360 * xterm.c (x_set_frame_alpha): Do not set property on anything
2361 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2362
e16e55d4
JB
23632011-05-02 Juanma Barranquero <lekktu@gmail.com>
2364
2365 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2366
bafcf6a5
JB
23672011-05-02 Juanma Barranquero <lekktu@gmail.com>
2368
2369 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2370 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2371 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2372 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2373 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2374 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2375 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2376 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2377 (Qgnutls_bootprop_callbacks_verify): Make static.
2378
e7a6747f
AS
23792011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2380
19ed11ba
AS
2381 * callproc.c: Indentation fixup.
2382
e7a6747f 2383 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2384 (wait_for_termination, interruptible_wait_for_termination):
2385 Move after wait_for_termination_1.
e7a6747f 2386
1ef14cb4
LMI
23872011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2388
2389 * sysdep.c (interruptible_wait_for_termination): New function
2390 which is like wait_for_termination, but allows keyboard
2391 interruptions.
2392
2393 * callproc.c (Fcall_process): Add (:file "file") as an option for
2394 the STDOUT buffer.
2395 (Fcall_process_region): Ditto.
2396
330d880c
EZ
23972011-04-30 Eli Zaretskii <eliz@gnu.org>
2398
8db90b73
EZ
2399 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2400 rather than `XVECTOR (FOO)->size'.
2401
330d880c
EZ
2402 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2403 inttypes.h, as a gnulib replacement is used if it not available in
2404 system headers.
2405
15cbd324
EZ
24062011-04-21 Eli Zaretskii <eliz@gnu.org>
2407
2408 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2409 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2410 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2411
2412 * coding.c (coding_alloc_by_realloc): Error out if destination
2413 will grow beyond MOST_POSITIVE_FIXNUM.
2414 (decode_coding_emacs_mule): Abort if there isn't enough place in
2415 charbuf for the composition carryover bytes. Reserve an extra
2416 space for up to 2 characters produced in a loop.
2417 (decode_coding_iso_2022): Abort if there isn't enough place in
2418 charbuf for the composition carryover bytes.
2419
24202011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2421
ae940cca
EZ
2422 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2423 aborting when %lld or %lll format is passed.
2424 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2425 %llo or %llx format is passed. (Bug#8545)
2426
03ab8921
EZ
2427 * window.c (window_scroll_line_based): Use a marker instead of
2428 simple variables to record original value of point. (Bug#7952)
2429
afda1437
EZ
2430 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2431 produced by %s or %c overflows available buffer space. (Bug#8545)
2432
f76dee0c
PE
24332011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2434
2435 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2436 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2437
fdc5744d
JB
24382011-04-28 Juanma Barranquero <lekktu@gmail.com>
2439
2440 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2441
638f053a
JB
24422011-04-28 Juanma Barranquero <lekktu@gmail.com>
2443
2444 * keyboard.c (Qdelayed_warnings_hook): Define.
2445 (command_loop_1): Run `delayed-warnings-hook'
2446 if Vdelayed_warnings_list is non-nil.
2447 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2448 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2449
d178f871
EZ
24502011-04-28 Eli Zaretskii <eliz@gnu.org>
2451
2452 * doprnt.c (doprnt): Don't return value smaller than the buffer
2453 size if the message was truncated. (Bug#8545).
2454
b124fd93
JB
24552011-04-28 Juanma Barranquero <lekktu@gmail.com>
2456
2457 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2458 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2459
e810457d
PE
24602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2463
ea51cceb
JB
24642011-04-27 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * makefile.w32-in: Update dependencies.
2467
94dcfacf
EZ
24682011-04-27 Eli Zaretskii <eliz@gnu.org>
2469
2470 Improve `doprnt' and its usage. (Bug#8545)
2471 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2472 `format_end'. Remove support for %l as a conversion specifier.
2473 Don't use xrealloc. Improve diagnostics when the %l size modifier
2474 is used. Update the commentary.
2475
2476 * eval.c (verror): Simplify calculation of size_t.
2477
2478 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2479 messages.
2480
f61f41d7
PE
24812011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2482
2483 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2484 change.
2485
96fb4434
PE
24862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2489 This makes this file independent of the recent pseudovector change.
2490
671875da 24912011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2492
69e9b5a3
PE
2493 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2494
b5f869a7 2495 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2496 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2497 Remove unused local.
c8926152 2498 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2499
841a1577 2500 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2501 GCC 4.6.0 optimizes based on type-based alias analysis.
2502 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2503 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2504 != &v->size, and therefore "v->size = 1; b->size = 2; return
2505 v->size;" must therefore return 1. This assumption is incorrect
2506 for Emacs, since it type-puns struct Lisp_Vector * with many other
2507 types. To fix this problem, this patch adds a new type struct
f904488f 2508 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2509 and pseudovectors, and helps optimizing compilers not get fooled
2510 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2511 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2512 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2513 the size member.
eab3844f
PE
2514 (XSETPVECTYPE): Rewrite in terms of new macro.
2515 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2516 This is a bit clearer, and further avoids the possibility of
2517 undesirable aliasing.
2518 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2519 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2520 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2521 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2522 (ASIZE): Now uses header.size rather than size.
2523 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2524 to avoid the hassle of writing XVECTOR (foo)->header.size.
2525 (struct vectorlike_header): New type.
eab3844f
PE
2526 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2527 object, to help avoid aliasing.
2528 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2529 (SUBRP): Likewise, since Lisp_Subr is a special case.
2530 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2531 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2532 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2533 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2534 changed to be "header.size" and "header.next".
2535 * buffer.h (struct buffer): Likewise.
2536 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2537 * frame.h (struct frame): Likewise.
2538 * process.h (struct Lisp_Process): Likewise.
2539 * termhooks.h (struct terminal): Likewise.
2540 * window.c (struct save_window_data, struct saved_window): Likewise.
2541 * window.h (struct window): Likewise.
2542 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2543 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2544 * buffer.c (init_buffer_once): Likewise.
2545 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2546 special case.
2547 * process.c (Fformat_network_address): Use local var for size,
2548 for brevity.
2549
0df1eac5
PE
2550 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2551
847ab9d1 2552 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2553 * data.c (atof): Remove decl; no longer used or needed.
2554 (digit_to_number): Move to lread.c.
2555 (Fstring_to_number): Use new string_to_number function, to be
2556 consistent with how the Lisp reader treats infinities and NaNs.
2557 Do not assume that floating-point numbers represent EMACS_INT
2558 without losing information; this is not true on most 64-bit hosts.
2559 Avoid double-rounding errors, by insisting on integers when
2560 parsing non-base-10 numbers, as the documentation specifies.
2561 * lisp.h (string_to_number): New decl, replacing ...
2562 (isfloat_string): Remove.
bc0a5c13 2563 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2564 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2565 appears to have been a coding error. Similarly, do not accept
2566 strings like +-1e0 as floating point numbers. Do not report
2567 overflow for integer overflows unless the base is not 10 which
2568 means we have no simple and reliable way to continue.
2569 Break out the floating-point parsing into a new
2570 function string_to_number, so that Fstring_to_number parses
2571 floating point numbers consistently with the Lisp reader.
04f2d78b 2572 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2573 (E_CHAR, EXP_INT): Remove, replacing with ...
2574 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2575 (string_to_number): New function, replacing isfloat_string.
2576 This function checks for valid syntax and produces the resulting
2577 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2578 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2579 so that overflow for non-base-10 numbers is reported only when
2580 there's no portable and simple way to convert to floating point.
452f4150 2581
67769ffc
PE
2582 * textprop.c (set_text_properties_1): Rewrite for clarity,
2583 and to avoid GCC warning about integer overflow.
2584
c20db43f
PE
2585 * intervals.h (struct interval): Use EMACS_INT for members
2586 where EMACS_UINT might cause problems. See
2587 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2588 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2589 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2590 All uses changed.
37aa2f85
PE
2591 (offset_intervals): Tell GCC not to worry about length overflow
2592 when negating a negative length.
c20db43f 2593
2538aa2f
PE
2594 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2595 (overrun_check_free): Likewise.
2596
f2d3008d
PE
2597 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2598 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2599 word size.
2600
ec8df744
PE
2601 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2602 (gnutls_make_error): Rename local to avoid shadowing.
2603 (gnutls_emacs_global_deinit): ifdef out; not used.
2604 (Fgnutls_boot): Use const for pointer to readonly storage.
2605 Comment out unused local. Fix pointer signedness problems.
2606
640ee02d
PE
2607 * lread.c (openp): Don't stuff size_t into an 'int'.
2608 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2609 about possible signed overflow.
2610
6048fb2a
PE
2611 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2612 (GDK_KEY_g): Don't define if already defined.
2613 (xg_prepare_tooltip): Avoid pointer signedness problem.
2614 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2615
fa3c87e1
PE
2616 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2617 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2618
2172544b
PE
2619 * xfns.c (Fx_window_property): Simplify a bit,
2620 to make a bit faster and to avoid GCC 4.6.0 warning.
2621 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2622
9b821a21
PE
2623 * fns.c (internal_equal): Don't assume size_t fits in int.
2624
3c616cfa
PE
2625 * alloc.c (compact_small_strings): Tighten assertion a little.
2626
c2982e87
PE
2627 Replace pEd with more-general pI, and fix some printf arg casts.
2628 * lisp.h (pI): New macro, generalizing old pEd macro to other
2629 conversion specifiers. For example, use "...%"pI"d..." rather
2630 than "...%"pEd"...".
2631 (pEd): Remove. All uses replaced with similar uses of pI.
2632 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2633 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2634 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2635 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2636 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2637 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2638 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2639 64-bit hosts.
2640 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2641 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2642 * print.c (safe_debug_print, print_object): Likewise.
2643 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2644 to int.
6f04d126
PE
2645 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2646 avoiding the 0 flag, which is not portable.
c2982e87
PE
2647 * process.c (Fmake_network_process): Use pI to avoid cast.
2648 * region-cache.c (pp_cache): Likewise.
2649 * xdisp.c (decode_mode_spec): Likewise.
2650 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2651 behavior on 64-bit hosts with printf arg.
6f04d126 2652 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2653 (x_stop_queuing_selection_requests): Likewise.
2654 (x_get_window_property): Don't truncate byte count to an 'int'
2655 when tracing.
0b432f21 2656
5e073ec7
PE
2657 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2658 here, since it parses constructs like leading '-' and spaces,
2659 which are not wanted; and it overflows with large numbers.
2660 Instead, simply match F[0-9]+, which is what is wanted anyway.
2661
36372bf9
PE
2662 * alloc.c: Remove unportable assumptions about struct layout.
2663 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2664 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2665 (allocate_vectorlike, make_pure_vector): Use the new macros,
2666 plus offsetof, to remove unportable assumptions about struct layout.
2667 These assumptions hold on all porting targets that I know of, but
2668 they are not guaranteed, they're easy to remove, and removing them
2669 makes further changes easier.
2670
0b432f21
PE
2671 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2672 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2673 (string_overrun_cookie): Now const. Use initializers that
2674 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2675 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2676 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2677 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2678 multiple of sizeof (EMACS_INT); it need not be, if
2679 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2680 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2681
895009e1
JB
26822011-04-26 Juanma Barranquero <lekktu@gmail.com>
2683
2684 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2685
6a7a1b0b
TZ
26862011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2687
2688 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2689 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2690 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2691
841a1577 26922011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2693
2694 * lisp.h (Qdebug): List symbol.
895009e1 2695 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2696 * keyboard.c (debug-on-event): New variable.
2697 (handle_user_signal): Break into debugger when debug-on-event
2698 matches the current signal symbol.
2699
f2d3ba6f
DN
27002011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2701
2702 * alloc.c (check_sblock, check_string_bytes)
2703 (check_string_free_list): Convert to standard C.
2704
42ce4c63
TZ
27052011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2706
2707 * w32.c (emacs_gnutls_push): Fix typo.
2708
825cd63c
EZ
27092011-04-25 Eli Zaretskii <eliz@gnu.org>
2710
fb11d64d
EZ
2711 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2712 "cast to pointer from integer of different size".
2713
825cd63c
EZ
2714 Improve doprnt and its use in verror. (Bug#8545)
2715 * doprnt.c (doprnt): Document the set of format control sequences
2716 supported by the function. Use SAFE_ALLOCA instead of always
2717 using `alloca'.
2718
2719 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2720 is one byte too soon. Don't use xrealloc; instead xfree and
2721 xmalloc anew.
2722
e061a11b
TZ
27232011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2724
2725 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2726 callbacks stage.
2727
2728 * gnutls.c: Renamed global_initialized to
2729 gnutls_global_initialized. Added internals for the
2730 :verify-hostname-error, :verify-error, and :verify-flags
2731 parameters of `gnutls-boot' and documented those parameters in the
2732 docstring. Start callback support.
2733 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2734 unless a fatal error occured. Call gnutls_alert_send_appropriate
2735 on error. Return error code.
2736 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2737 (emacs_gnutls_read): Likewise.
2738 (Fgnutls_boot): Return handshake error code.
2739 (emacs_gnutls_handle_error): New function.
2740 (wsaerror_to_errno): Likewise.
2741
2742 * w32.h (emacs_gnutls_pull): Add prototype.
2743 (emacs_gnutls_push): Likewise.
2744
2745 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2746 (emacs_gnutls_push): Likewise.
2747
27482011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2749
2750 * process.c (wait_reading_process_output): Check if GnuTLS
2751 buffered some data internally if no FDs are set for TLS
2752 connections.
2753
2754 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2755 (LIBS): Link to USER_LIBS.
2756 ($(BLD)/gnutls.$(0)): New target.
2757
fa6996bc
EZ
27582011-04-24 Eli Zaretskii <eliz@gnu.org>
2759
eb35682e
EZ
2760 * xdisp.c (handle_single_display_spec): Rename the
2761 display_replaced_before_p argument into display_replaced_p, to
2762 make it consistent with the commentary. Fix typos in the
2763 commentary.
2764
e2ad650c
EZ
2765 * textprop.c (syms_of_textprop): Remove dead code.
2766 (copy_text_properties): Delete obsolete commentary about an
2767 interface that was deleted long ago. Fix typos in the description
2768 of arguments.
2769
1b2de274
EZ
2770 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2771 to changes in oldXMenu/XMenu.h from 2011-04-16.
2772 <menu_help_message, prev_menu_help_message>: Constify.
2773 (IT_menu_make_room): menu->help_text is now `const char **';
2774 adjust.
2775
2776 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2777 to changes in oldXMenu/XMenu.h from 2011-04-16.
2778 (struct XMenu): Declare `help_text' `const char **'.
2779
2780 * xfaces.c <Qunspecified>: Make extern again.
2781
2782 * syntax.c: Include sys/types.h before including regex.h, as
2783 required by Posix.
2784
762b15be
EZ
2785 * doc.c (get_doc_string): Improve the format passed to `error'.
2786
2787 * doprnt.c (doprnt): Improve commentary.
2788
2789 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2790
2791 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2792 them with etags.
2793
f1052e5d
EZ
2794 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2795 changes in globals.h immediately force recompilation.
762b15be
EZ
2796 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2797 $(CURDIR)/s/ms-w32.h.
2798 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2799
fa6996bc
EZ
2800 * character.c (Fchar_direction): Function deleted.
2801 (syms_of_character): Don't defsubr it.
2802 <char-direction-table>: Deleted.
2803
e6c3da20
EZ
28042011-04-23 Eli Zaretskii <eliz@gnu.org>
2805
2806 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2807 * doprnt.c: Include limits.h.
2808 (SIZE_MAX): New macro.
04f2d78b
CB
2809 (doprnt): Return a size_t value. 2nd arg is now size_t.
2810 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2811 Improve overflow protection. Support `l' modifier for integer
2812 conversions. Support %l conversion. Don't assume an EMACS_INT
2813 argument for integer conversions and for %c.
2814
2815 * lisp.h (doprnt): Restore prototype.
2816
2817 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2818 $(SRC)/character.h.
2819
2820 * Makefile.in (base_obj): Add back doprnt.o.
2821
2822 * deps.mk (doprnt.o): Add back prerequisites.
2823 (callint.o): Depend on character.h.
2824
2825 * eval.c (internal_lisp_condition_case): Include the handler
2826 representation in the error message.
2827 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2828 when breaking from the loop.
2829
2830 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2831
2832 * callint.c (Fcall_interactively): When displaying error message
2833 about invalid control letter, pass the character's codepoint, not
2834 a pointer to its multibyte form. Improve display of the character
2835 in octal and display also its hex code.
2836
2837 * character.c (char_string): Use %x to display the (unsigned)
2838 codepoint of an invalid character, to avoid displaying a bogus
2839 negative value.
2840
2841 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2842 `error', not SYMBOL_NAME itself.
2843
2844 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2845 character arguments to `error'.
2846
2847 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2848 to `error' in error message about FINAL_CHAR argument. Make sure
2849 FINAL_CHAR is a character, and use %c when it is passed as
2850 argument to `error'.
2851
4ffd0d6b 28522011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2853
2854 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2855
2856 * w32.c: Include <time.h>.
2857 (sys_localtime): New function.
2858
4ffd0d6b 28592011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2860
2861 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2862
4ffd0d6b 2863 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2864
4ffd0d6b 28652011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2866
4ffd0d6b
GM
2867 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2868 zombies (Bug#8467).
aac0c6e3 2869
04c56954
EZ
28702011-04-19 Eli Zaretskii <eliz@gnu.org>
2871
2872 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2873 gl_state.e_property when gl_state.object is Qt.
2874
2875 * insdel.c (make_gap_larger): Remove limitation of buffer size
2876 to <= INT_MAX.
2877
16a43933
CY
28782011-04-18 Chong Yidong <cyd@stupidchicken.com>
2879
2880 * xdisp.c (lookup_glyphless_char_display)
2881 (produce_glyphless_glyph): Handle cons cell entry in
2882 glyphless-char-display.
2883 (Vglyphless_char_display): Document it.
2884
2885 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2886 glyphless-char-display.
2887
4581706e
CY
28882011-04-17 Chong Yidong <cyd@stupidchicken.com>
2889
2890 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2891
2892 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2893
2894 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2895 definition for no-X builds.
2896
4887c6e2 28972011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2898
fd35b6f9
PE
2899 Static checks with GCC 4.6.0 and non-default toolkits.
2900
5c1ccb01
PE
2901 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2902
006c5daa
PE
2903 * process.c (keyboard_bit_set): Define only if SIGIO.
2904 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2905 (send_process): Repair possible setjmp clobbering.
2906
efc736d3
PE
2907 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2908
4e2fe2e6
PE
2909 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2910
f97334a2
PE
2911 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2912
4e75f29d
PE
2913 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2914 Define only if needed.
2915
90efadd1
PE
2916 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2917 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2918 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2919
3c647824
PE
2920 * dispextern.h (struct redisplay_interface): Rename param
2921 to avoid shadowing.
e264f262 2922 * termhooks.h (struct terminal): Likewise.
761383f4 2923 * xterm.c (xembed_send_message): Likewise.
3c647824 2924
b58c5c4a
PE
2925 * insdel.c (make_gap_smaller): Define only if
2926 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2927
cad59032
PE
2928 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2929 it.
2930
c339dc2e
PE
2931 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2932 so that we aren't warned about unused symbols.
2933
91a3e27b
PE
2934 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2935
399c71d3 2936 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2937
8ffc96f5
PE
2938 * xfns.c (x_real_positions): Mark locals as initialized.
2939
eef9bc79
PE
2940 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2941
098db9dd
PE
2942 * xterm.c: Fix problems found by static analysis with other toolkits.
2943 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2944 (x_dispatch_event): Declare static if USE_GTK, and
2945 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2946 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2947 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2948 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2949 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2950
eb18f6cc
PE
2951 * xmenu.c (menu_help_callback): Pointer type fixes.
2952 Use const pointers when pointing at readonly data. Avoid pointer
2953 signedness clashes.
2954 (FALSE): Remove unused macro.
2955 (update_frame_menubar): Remove unused decl.
2956
1fe72bf8
PE
2957 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2958
60d9e1db
PE
2959 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2960 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2961 (single_menu_item): Rename local to avoid shadowing.
2962
39261c26
PE
2963 * keyboard.c (make_lispy_event): Remove unused local var.
2964
018c5e19
PE
2965 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2966 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2967
63d2b86e
PE
2968 * bitmaps: Change bitmaps from unsigned char back to the X11
2969 compatible char. Avoid the old compiler warnings about
2970 out-of-range initializers by using, for example, '\xab' rather
2971 than 0xab.
2972
aefd87e1
PE
2973 * xgselect.c (xgselect_initialize): Check vs interface
2974 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2975
bf501fb9
PE
2976 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2977
e9829fdf
PE
2978 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2979 to read-only memory.
2980
1086c095
PE
2981 * fns.c (vector): Remove; this old hack is no longer needed.
2982
2baccd04 2983 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2984 Remove unused var.
dde42981 2985 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2986
72391843 2987 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2988
436c16df 2989 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2990 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2991 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2992
92bb796d 2993 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2994 (x_term_init): Remove local to avoid shadowing.
92bb796d 2995
764430a3 2996 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2997
2998 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2999 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3000
d1dfb56c
EZ
30012011-04-16 Eli Zaretskii <eliz@gnu.org>
3002
c4354cb4
EZ
3003 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3004
d1dfb56c
EZ
3005 Fix regex.c, syntax.c and friends for buffers > 2GB.
3006 * syntax.h (struct gl_state_s): Declare character position members
3007 EMACS_INT.
3008
3009 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3010
04f2d78b
CB
3011 * textprop.c (verify_interval_modification, interval_of):
3012 Declare arguments EMACS_INT.
d1dfb56c
EZ
3013
3014 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3015 EMACS_INT.
3016
3017 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3018
3019 * indent.c (Fvertical_motion): Local variable it_start is now
3020 EMACS_INT.
3021
3022 * regex.c (re_match, re_match_2, re_match_2_internal)
3023 (bcmp_translate, regcomp, regexec, print_double_string)
3024 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3025 (re_compile_pattern, re_exec): Declare arguments and local
3026 variables `size_t' and `ssize_t' and return values `regoff_t', as
3027 appropriate.
3028 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3029 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3030 <compile_stack_type>: `size' and `avail' are now `size_t'.
3031
3032 * regex.h <regoff_t>: Use ssize_t, not int.
3033 (re_search, re_search_2, re_match, re_match_2): Arguments that
3034 specify buffer/string position and length are now ssize_t and
3035 size_t. Return type is regoff_t.
3036
613052cd
BK
30372011-04-16 Ben Key <bkey76@gmail.com>
3038
3039 * nsfont.m: Fixed bugs in ns_get_family and
3040 ns_descriptor_to_entity that were caused by using free to
3041 deallocate memory blocks that were allocated by xmalloc (via
3042 xstrdup). This caused Emacs to crash when compiled with
3043 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3044 --enable-checking=xmallocoverrun). xfree is now used to
3045 deallocate these memory blocks.
3046
4170f62f 30472011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3048
71b41406
PE
3049 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3050
9587a89d
PE
3051 emacs_write: Accept and return EMACS_INT for sizes.
3052 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3053 et seq.
3054 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3055 Accept and return EMACS_INT.
3056 (emacs_gnutls_write): Return the number of bytes written on
3057 partial writes.
3058 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3059 (emacs_read, emacs_write): Remove check for negative size, as the
3060 Emacs source code has been audited now.
9587a89d
PE
3061 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3062 (emacs_read, emacs_write): Use it.
273a5f82
PE
3063 * process.c (send_process): Adjust to the new signatures of
3064 emacs_write and emacs_gnutls_write. Do not attempt to store
3065 a byte offset into an 'int'; it might overflow.
9587a89d 3066 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3067
3e047f51
PE
3068 * sound.c: Don't assume sizes fit in 'int'.
3069 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3070 Return EMACS_INT, not int.
3e047f51 3071 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3072 Accept EMACS_INT, not int.
3073 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3074 record read return values.
3075
cc39a9db
BK
30762011-04-15 Ben Key <bkey76@gmail.com>
3077
c9d0ec6d
JB
3078 * keyboard.c (Qundefined): Don't declare static since it is used
3079 in nsfns.m.
3080 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3081 static since they are used in nsfont.m.
cc39a9db 3082
6c60eb9f
SM
30832011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3084
3085 * process.c (Qprocessp): Don't declare static.
3086 * lisp.h (Qprocessp): Declare again.
3087
7990b61a
JB
30882011-04-15 Juanma Barranquero <lekktu@gmail.com>
3089
3090 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3091
5d4cb038
PE
30922011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3093
8bd7b830 3094 Improve C-level modularity by making more things 'static'.
cd64ea1d 3095
e3b27b31
PE
3096 Don't publish debugger-only interfaces to other modules.
3097 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3098 (verify_bytepos, count_markers): Move decls to the only modules
3099 that need them.
3100 * region-cache.h (pp_cache): Likewise.
3101 * window.h (check_all_windows): Likewise.
3102 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3103
5d4cb038
PE
3104 * sysdep.c (croak): Now static, if
3105 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3106 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3107
3108 * alloc.c (refill_memory_reserve): Now static if
3109 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3110 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3111
e87b6180
PE
3112 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3113 Define only if USE_LUCID.
3114
ac64929e
PE
3115 * xrdb.c (x_customization_string, x_rm_string): Now static.
3116
6f37259d
PE
3117 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3118 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3119
1683e3ab
PE
3120 * xdisp.c (draw_row_with_mouse_face): Now static.
3121 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3122
de9c2632
PE
3123 * window.h (check_all_windows): Mark externally visible.
3124
2b96acb7
PE
3125 * window.c (window_deletion_count): Now static.
3126
3127 * undo.c: Make symbols static if they're not exported.
3128 (last_undo_buffer, last_boundary_position, pending_boundary):
3129 Now static.
3130
50436f33
PE
3131 * textprop.c (interval_insert_behind_hooks): Now static.
3132 (interval_insert_in_front_hooks): Likewise.
3133
64520e5c
PE
3134 * term.c: Make symbols static if they're not exported.
3135 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3136 (max_frame_lines, tty_set_terminal_modes):
3137 (tty_reset_terminal_modes, tty_turn_off_highlight):
3138 (get_tty_terminal): Now static.
3139 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3140 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3141 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3142 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3143 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3144
1fa53021
PE
3145 * sysdep.c: Make symbols static if they're not exported.
3146 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3147 Now static.
3148 (sigprocmask_set, full_mask): Remove; unused.
3149 (wait_debugging): Mark as visible.
3150 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3151 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3152
d4b43b22
PE
3153 * syntax.c (syntax_temp): Define only if !__GNUC__.
3154
b7c513d0
PE
3155 * sound.c (current_sound_device, current_sound): Now static.
3156
989b29ad
PE
3157 * search.c (searchbufs, searchbuf_head): Now static.
3158
13a55a78
PE
3159 * scroll.c (scroll_cost): Remove; unused.
3160 * dispextern.h (scroll_cost): Remove decl.
3161
de68a1fc
PE
3162 * region-cache.h (pp_cache): Mark as externally visible.
3163
40ccffa6
PE
3164 * process.c: Make symbols static if they're not exported.
3165 (process_tick, update_tick, create_process, chan_process):
3166 (Vprocess_alist, proc_buffered_char, datagram_access):
3167 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3168 (deactivate_process): Mark defn as static, as well as decl.
3169 * lisp.h (create_process): Remove decl.
3170 * process.h (chan_process, Vprocess_alist): Remove decls.
3171
ad64fc97
PE
3172 * print.c: Make symbols static if they're not exported.
3173 (print_depth, new_backquote_output, being_printed, print_buffer):
3174 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3175 (print_interval, print_number_index, initial_stderr_stream):
3176 Now static.
3177 * lisp.h (Fprinc): Remove decl.
3178 (debug_output_compilation_hack): Mark as externally visible.
3179
adddb265
PE
3180 * sysdep.c (croak): Move decl from here to syssignal.h.
3181 * syssignal.h (croak): Put it here, so the API can be checked when
3182 'croak' is called from dissociate_if_controlling_tty.
3183
1717ede2
PE
3184 * minibuf.c: Make symbols static if they're not exported.
3185 (minibuf_save_list, choose_minibuf_frame): Now static.
3186 * lisp.h (choose_minibuf_frame): Remove decl.
3187
fa5fb2bc
PE
3188 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3189
1e3890d1
PE
3190 * lread.c: Make symbols static if they're not exported.
3191 (read_objects, initial_obarray, oblookup_last_bucket_number):
3192 Now static.
3193 (make_symbol): Remove; unused.
3194 * lisp.h (initial_obarray, make_symbol): Remove decls.
3195
8a1414fa
PE
3196 * keyboard.c: Make symbols static if they're not exported.
3197 (single_kboard, recent_keys_index, total_keys, recent_keys):
3198 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3199 (this_single_command_key_start, echoing, last_auto_save):
3200 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3201 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3202 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3203 (Vlispy_mouse_stem, double_click_count):
3204 Now static.
3205 (force_auto_save_soon): Define only if SIGDANGER.
3206 (ignore_mouse_drag_p): Now static if
3207 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3208 (print_help): Remove; unused.
3209 (stop_character, last_timer_event): Mark as externally visible.
3210 * keyboard.h (ignore_mouse_drag_p): Declare only if
3211 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3212 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3213 * lisp.h (echoing): Remove decl.
3214 (force_auto_save_soon): Declare only if SIGDANGER.
3215 * xdisp.c (redisplay_window): Simplify code, to make it more
3216 obvious that ignore_mouse_drag_p is not accessed if !defined
3217 USE_GTK && !defined HAVE_NS.
3218
93ea6e8f
PE
3219 * intervals.c: Make symbols static if they're not exported.
3220 (merge_properties_sticky, merge_interval_right, delete_interval):
3221 Now static.
3222 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3223
77382fcc
PE
3224 * insdel.c: Make symbols static if they're not exported.
3225 However, leave prepare_to_modify_buffer alone. It's never
3226 called from outside this function, but that appears to be a bug.
3227 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3228 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3229 (adjust_after_replace_noundo): Remove; unused.
3230 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3231 (signal_before_change): Remove decls.
77382fcc 3232
9306c32e
PE
3233 * indent.c (val_compute_motion, val_vmotion): Now static.
3234
cd44d2eb
PE
3235 * image.c: Make symbols static if they're not exported.
3236 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3237 if USE_GTK.
3238 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3239 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3240
ad9a7a06
PE
3241 * fringe.c (standard_bitmaps): Now static.
3242 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3243
81626931
PE
3244 * frame.c: Make symbols static if they're not exported.
3245 (x_report_frame_params, make_terminal_frame): Now static.
3246 (get_frame_param): Now static, unless HAVE_NS.
3247 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3248 (x_get_resource_string): Remove; not used.
3249 * frame.h (make_terminal_frame, x_report_frame_params):
3250 (x_get_resource_string); Remove decls.
3251 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3252 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3253
239f9db9
PE
3254 * font.c, fontset.c: Make symbols static if they're not exported.
3255 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3256 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3257 * font.c (font_close_object): Now static.
3258 * font.h (font_close_object): Remove.
3259 * fontset.c (FONTSET_OBJLIST): Remove.
3260 (free_realized_fontset) #if-0 the body, which does nothing.
3261 (face_suitable_for_char_p): #if-0, as it's never called.
3262 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3263 * xfaces.c (face_at_string_position):
3264 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3265 since 0 is always ASCII.
3266
dfcf3579
PE
3267 * fns.c (weak_hash_tables): Now static.
3268
5045092b
PE
3269 * fileio.c: Make symbols static if they're not exported.
3270 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3271 (Vwrite_region_annotation_buffers): Now static.
3272
57a96f5c
PE
3273 * eval.c: Make symbols static if they're not exported.
3274 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3275 * lisp.h (backtrace_list): Remove decl.
3276
35f08c38
PE
3277 * emacs.c: Make symbols static if they're not exported.
3278 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3279 (fatal_error_code, fatal_error_signal_hook, standard_args):
3280 Now static.
3281 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3282 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3283 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3284 * lisp.h (fatal_error_signal_hook): Remove decl.
3285 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3286
f44bd759
PE
3287 * editfns.c: Move a (normally-unused) function to its only use.
3288 * editfns.c, lisp.h (get_operating_system_release): Remove.
3289 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3290 worth the hassle of breaking this out.
3291
b532497d
PE
3292 * xterm.c: Make symbols static if they're not exported.
3293 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3294 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3295 (x_destroy_window, x_delete_display):
3296 Now static.
3297 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3298 (x_mouse_leave): Remove; unused.
3299 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3300 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3301 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3302 Remove decls.
3303 (x_mouse_leave): Declare only if WINDOWSNT.
3304 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3305 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3306 USE_X_TOOLKIT.
3307
1675728f
PE
3308 * ftxfont.c: Make symbols static if they're not exported.
3309 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3310 HAVE_FREETYPE.
3311 * font.h (ftxfont_driver): Likewise.
3312
e4cebfca
PE
3313 * xfns.c: Make symbols static if they're not exported.
3314 (x_last_font_name, x_display_info_for_name):
3315 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3316 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3317 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3318 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3319 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3320 (last_show_tip_args): Now static.
3321 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3322 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3323 (x_screen_planes): Remove; unused.
3324 * dispextern.h (x_screen_planes): Remove decl.
3325
5bf46f05
PE
3326 * dispnew.c: Make symbols static if they're not exported.
3327 * dispextern.h (redraw_garbaged_frames, scrolling):
3328 (increment_row_positions): Remove.
3329 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3330 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3331 Now static.
3332 (redraw_garbaged_frames): Remove; unused.
3333
435f4c28
PE
3334 * xfaces.c: Make symbols static if they're not exported.
3335 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3336 Remove decls.
3337 * xterm.h (defined_color): Remove decls.
3338 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3339 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3340 (menu_face_changed_default, defined_color, free_realized_face):
3341 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3342 (ascii_face_of_lisp_face): Remove; unused.
3343
8524aef3
PE
3344 * xdisp.c: Make symbols static if they're not exported.
3345 * dispextern.h (scratch_glyph_row, window_box_edges):
3346 (glyph_to_pixel_coords, set_cursor_from_row):
3347 (get_next_display_element, set_iterator_to_next):
3348 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3349 (show_mouse_face): Remove decls
3350 * frame.h (message_buf_print): Likewise.
3351 * lisp.h (pop_message, set_message, check_point_in_composition):
3352 Likewise.
3353 * xterm.h (set_vertical_scroll_bar): Likewise.
3354 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3355 (message_buf_print, scratch_glyph_row, displayed_buffer):
3356 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3357 (get_next_display_element, show_mouse_face, window_box_edges):
3358 (frame_to_window_pixel_xy, check_point_in_composition):
3359 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3360 (glyph_to_pixel_coords): Remove; unused.
3361
16390cd2
PE
3362 * dired.c (file_name_completion): Now static.
3363
3364 * dbusbind.c (xd_in_read_queued_messages): Now static.
3365
a25f4dfa
PE
3366 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3367 * data.c (circular_list_error): Remove.
3368
14a9c8df
PE
3369 * commands.h (last_point_position, last_point_position_buffer):
3370 (last_point_position_window): Remove decls.
3371 * keyboard.c: Make these variables static.
3372
04f2d78b
CB
3373 * coding.h (coding, code_convert_region, encode_coding_gap):
3374 Remove decls.
74ab6df5
PE
3375 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3376 (iso_code_class, detect_coding, code_convert_region): Now static.
3377 (encode_coding_gap): Remove; unused.
3378
38dfbee1
PE
3379 * chartab.c (chartab_chars, chartab_bits): Now static.
3380
a2cb4e63
PE
3381 * charset.h (charset_iso_8859_1): Remove decl.
3382 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3383 Now static.
3384
127198fd
PE
3385 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3386 * ccl.c (Vccl_program_table): Now static.
3387 (check_ccl_update): Remove; unused.
3388
d85b608f
PE
3389 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3390 * category.h: ... from here.
3391 * category.c (check_category_table, set_category_set): Now static.
3392
31cd66f3
PE
3393 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3394 * lisp.h: Remove these decls.
3395
c358e587
PE
3396 * buffer.c (buffer_count): Remove unused var.
3397
e78aecca
PE
3398 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3399 so that it's not optimized away.
3400 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3401 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3402 exported only to the debugger.
3403
e192d7d3 3404 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3405 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3406
92470028
PE
3407 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3408 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3409 was inaccessible from Lisp.
3410 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3411 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3412
244ed907
PE
3413 alloc.c: Import and export fewer symbols, and remove unused items.
3414 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3415 is defined.
3416 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3417 it's not optimized away by whole-program optimization.
3418 (message_enable_multibyte, free_misc): Remove.
3419 (catchlist, handlerlist, mark_backtrace):
3420 Declare only if BYTE_MARK_STACK.
3421 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3422 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3423 (message_enable_multibyte): Remove decl.
3424 (free_misc, interval_free_list, float_block, float_block_index):
3425 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3426 (cons_free_list, last_marked_index):
3427 Now static.
3428 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3429 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3430 (mark_backtrace): Define only if BYTE_MARK_STACK.
3431 * xdisp.c (message_enable_multibyte): Now static.
3432
61c2b50e 3433 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3434 This makes it easier for human readers (and static analyzers)
3435 to see whether these variables are used from other modules.
3436 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3437 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3438 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3439 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3440 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3441 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3442 * xmenu.c, xselect.c:
3443 Declare Q* vars static if they are not used in other modules.
3444 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3445 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3446 Remove decls of unexported vars.
3447 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3448
95c82688
PE
3449 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3450
16a97296
PE
3451 Make Emacs functions such as Fatom 'static' by default.
3452 This makes it easier for human readers (and static analyzers)
3453 to see whether these functions can be called from other modules.
3454 DEFUN now defines a static function. To make the function external
3455 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3456 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3457 (Finit_image_library):
16a97296
PE
3458 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3459 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3460 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3461 Remove decls, since these functions are now static.
3462 (Funintern, Fget_internal_run_time): New decls, since these functions
3463 were already external.
95c82688 3464
16a97296
PE
3465 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3466 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3467 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3468 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3469 * keyboard.c, keymap.c, lread.c:
3470 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3471 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3472 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3473 Mark functions with DEFUE instead of DEFUN,
3474 if they are used in other modules.
3475 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3476 decls for now-static functions.
3477 * buffer.h (Fdelete_overlay): Remove decl.
3478 * callproc.c (Fgetenv_internal): Mark as internal.
3479 * composite.c (Fremove_list_of_text_properties): Remove decl.
3480 (Fcomposition_get_gstring): New forward static decl.
3481 * composite.h (Fcomposite_get_gstring): Remove decl.
3482 * dired.c (Ffile_attributes): New forward static decl.
3483 * doc.c (Fdocumntation_property): New forward static decl.
3484 * eval.c (Ffetch_bytecode): New forward static decl.
3485 (Funintern): Remove extern decl; now in .h file where it belongs.
3486 * fileio.c (Fmake_symbolic_link): New forward static decl.
3487 * image.c (Finit_image_library): New forward static decl.
3488 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3489 * intervals.h (Fprevious_property_change):
3490 (Fremove_list_of_text_properties): Remove decls.
3491 * keyboard.c (Fthis_command_keys): Remove decl.
3492 (Fcommand_execute): New forward static decl.
3493 * keymap.c (Flookup_key): New forward static decl.
3494 (Fcopy_keymap): Now static.
3495 * keymap.h (Flookup_key): Remove decl.
3496 * process.c (Fget_process): New forward static decl.
3497 (Fprocess_datagram_address): Mark as internal.
3498 * syntax.c (Fsyntax_table_p): New forward static decl.
3499 (skip_chars): Remove duplicate decl.
3500 * textprop.c (Fprevious_property_change): New forward static decl.
3501 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3502 Now internal.
3503 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3504 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3505
785bbd42
PE
3506 * editfns.c (Fformat): Remove unreachable code.
3507
8b913b57
AS
35082011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3509
3510 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3511 change. (Bug#8496)
3512
a6744a35
EZ
35132011-04-13 Eli Zaretskii <eliz@gnu.org>
3514
3515 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3516 when at ZV. (Bug#8487)
3517
e7974947
AS
35182011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3519
baad03f0
AS
3520 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3521 (Bug#8437)
3522 * keyboard.c (parse_tool_bar_item): Likewise.
3523 * sound.c (sound_cleanup, alsa_close): Likewise.
3524 * termcap.c (tgetent): Likewise.
3525 * xfns.c (x_default_font_parameter): Likewise.
3526 * xsettings.c (read_and_apply_settings): Likewise.
3527
e7974947
AS
3528 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3529 (overrun_check_free): Protoize.
3530
28272684
PE
35312011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3534 since callers should never pass a negative size.
3535 Change the signature to match that of plain 'read' and 'write'; see
3536 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3537 * lisp.h: Update prototypes of emacs_write and emacs_read.
3538
11997c76
EZ
35392011-04-11 Eli Zaretskii <eliz@gnu.org>
3540
3541 * xdisp.c (redisplay_window): Don't try to determine the character
3542 position of the scroll margin if the window start point w->startp
e896f03c 3543 is outside the buffer's accessible region. (Bug#8468)
11997c76 3544
8a2cbd72
EZ
35452011-04-10 Eli Zaretskii <eliz@gnu.org>
3546
3547 Fix write-region and its subroutines for buffers > 2GB.
3548 * fileio.c (a_write, e_write): Modify declaration of arguments and
3549 local variables to support buffers larger than 2GB.
3550 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3551
3552 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3553 argument, local variables, and return value.
3554
3555 * lisp.h: Update prototypes of emacs_write and emacs_read.
3556
3557 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3558
4073e537 35592011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3560
1ebfdcb6
PE
3561 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3562
b2ded58d
PE
3563 Fix more problems found by GCC 4.6.0's static checks.
3564
7d66342c
PE
3565 * xdisp.c (vmessage): Use a better test for character truncation.
3566
bbf47d44
PE
3567 * charset.c (load_charset_map): <, not <=, for optimization,
3568 and to avoid potential problems with integer overflow.
9248994d 3569 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3570 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3571 * editfns.c (Fformat): Likewise.
1e69125e 3572 * syntax.c (skip_chars): Likewise.
3befa583 3573
e3019616
PE
3574 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3575 This also lets GCC 4.6.0 generate slightly better loop code.
3576
becfa255
PE
3577 * callint.c (Fcall_interactively): <, not <=, for optimization.
3578 (Fcall_interactively): Count the number of arguments produced,
3579 not the number of arguments given. This is simpler and lets GCC
3580 4.6.0 generate slightly better code.
3581
dae0cd48
PE
3582 * ftfont.c: Distingish more carefully between FcChar8 and char.
3583 The previous code passed unsigned char * to a functions like
3584 strlen and xstrcasecmp that expect char *, which does not
3585 conform to the C standard.
3586 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3587 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3588 char * when the C standard requires it.
3589
76032d70
PE
3590 * keyboard.c (read_char): Remove unused var.
3591
eb3f1cc8
PE
3592 * eval.c: Port to Windows vsnprintf (Bug#8435).
3593 Include <limits.h>.
3594 (SIZE_MAX): Define if the headers do not.
3595 (verror): Do not give up if vsnprintf returns a negative count.
3596 Instead, grow the buffer. This ports to Windows vsnprintf, which
3597 does not conform to C99. Problem reported by Eli Zaretskii.
3598 Also, simplify the allocation scheme, by avoiding the need for
3599 calling realloc, and removing the ALLOCATED variable.
3600
70476b54
PE
3601 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3602
12020a9e
PE
3603 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3604 But keep the doprint source code for now, as we might revamp it
3605 and use it again (Bug#8435).
ea6c7ae6
PE
3606 * lisp.h (doprnt): Remove.
3607 * Makefile.in (base_obj): Remove doprnt.o.
3608 * deps.mk (doprnt.o): Remove.
3609
5fdb398c
PE
3610 error: Print 32- and 64-bit integers portably (Bug#8435).
3611 Without this change, on typical 64-bit hosts error ("...%d...", N)
3612 was used to print both 32- and 64-bit integers N, which relied on
3613 undefined behavior.
3614 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3615 New macro.
3616 * lisp.h (error, verror): Mark as printf-like functions.
3617 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3618 Report overflow in size calculations when allocating printf buffer.
3619 Do not truncate output string at its first null byte.
3620 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3621 Truncate the output at a character boundary, since vsnprintf does not
3622 do that.
3623 * charset.c (check_iso_charset_parameter): Convert internal
3624 character to string before calling 'error', since %c now has the
3625 printf meaning.
3626 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3627 overflow when computing char to be passed to 'error'. Do not
3628 pass Lisp_Object to 'error'; pass the integer instead.
3629 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3630 formatted with plain %d.
3631
b189fa66
PE
3632 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3633
bff87ef0
PE
3634 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3635
7e2cac20
PE
3636 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3637
ce4d90b5
PE
3638 * xterm.c (x_catch_errors): Remove duplicate declaration.
3639
266c9547
PE
3640 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3641
79c49ad2
PE
3642 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3643
368f4090
JM
36442011-04-10 Jim Meyering <meyering@redhat.com>
3645
3646 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3647 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3648 return ssize_t not "int", and use size_t as the buffer length.
3649 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3650 * gnutls.h: Update declarations.
3651 * process.c (read_process_output): Use ssize_t, to match.
3652 (send_process): Likewise.
3653
a32d4040
CY
36542011-04-09 Chong Yidong <cyd@stupidchicken.com>
3655
3656 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3657
8546720e 36582011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3659
04f2d78b
CB
3660 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3661 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3662
8546720e
GM
3663 * xterm.c (handle_one_xevent):
3664 * xmenu.c (create_and_show_popup_menu):
3665 * xselect.c (x_decline_selection_request)
3666 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3667
0a2f5c1a 36682011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3669
3670 Fix some uses of `int' instead of EMACS_INT.
3671 * search.c (string_match_1, fast_string_match)
3672 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3673 (scan_buffer, find_next_newline_no_quit)
3674 (find_before_next_newline, search_command, Freplace_match)
3675 (Fmatch_data): Make some `int' variables be EMACS_INT.
3676
3677 * xdisp.c (display_count_lines): 3rd argument and return value now
3678 EMACS_INT. All callers changed.
3679 (pint2hrstr): Last argument is now EMACS_INT.
3680
3681 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3682 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3683 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3684 (decode_coding_utf_16, decode_coding_emacs_mule)
3685 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3686 (decode_coding_ccl, decode_coding_charset)
3687 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3688 (decode_coding_iso_2022, decode_coding_emacs_mule)
3689 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3690 <char_offset, last_offset>: Declare EMACS_INT.
3691 (encode_coding_utf_8, encode_coding_utf_16)
3692 (encode_coding_emacs_mule, encode_invocation_designation)
3693 (encode_designation_at_bol, encode_coding_iso_2022)
3694 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3695 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3696 Declare EMACS_INT.
3697 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3698 (encode_invocation_designation): Last argument P_NCHARS is now
3699 EMACS_INT.
3700 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3701 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3702
3703 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3704 All users changed.
3705
3706 * ccl.c (Fccl_execute_on_string): Declare some variables
3707 EMACS_INT.
3708
8546720e 37092011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3710
3711 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3712
4e19a977
CS
37132011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3714
3715 * process.c (Fformat_network_address): Doc fix.
3716
87302331
R
37172011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3718
3719 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3720
cbb59342
CY
37212011-04-08 Chong Yidong <cyd@stupidchicken.com>
3722
3723 * keyboard.c (read_char): Call Lisp function help-form-show,
3724 instead of using internal_with_output_to_temp_buffer.
3725 (Qhelp_form_show): New var.
e0d38eeb 3726 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3727
3728 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3729
3730 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3731
e67a13ab
CY
37322011-04-06 Chong Yidong <cyd@stupidchicken.com>
3733
04f2d78b
CB
3734 * process.c (Flist_processes): Remove to Lisp.
3735 (list_processes_1): Delete.
e67a13ab 3736
973f782d
EZ
37372011-04-06 Eli Zaretskii <eliz@gnu.org>
3738
7c106b1e
EZ
3739 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3740
973f782d
EZ
3741 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3742
41cf7d1a 37432011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3744
ca23cc88
PE
3745 Fix more problems found by GCC 4.6.0's static checks.
3746
f390e2d5
PE
3747 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3748
42eea0d0
PE
3749 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3750
b69769da 3751 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3752
f9541e84
PE
3753 * xdisp.c (vmessage): Mark as a printf-like function.
3754
13841b55
PE
3755 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3756
c136c10f
PE
3757 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3758
5e2d4a30
PE
3759 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3760 printf-like functions.
3761 (tiff_load): Add casts to remove these marks before passing them
3762 to system-supplied API.
3763
583f48b9
PE
3764 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3765
b25d760e
PE
3766 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3767 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3768 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3769 directly, rather than having caller test rule sign. This avoids
3770 some unnecessary tests.
3771 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3772 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3773 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3774
bc7b6697 3775 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3776 (xfont_open): Avoid unnecessary tests.
bc7b6697 3777
27ccc379
PE
3778 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3779
dcd5c89a
PE
3780 * composite.h, composite.c (composition_gstring_put_cache):
3781 Use EMACS_INT, not int, for length.
3782
b13a45c6
PE
3783 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3784 breaking out part of COMPOSITION_DECODE_RULE.
3785 (COMPOSITION_DECODE_RULE): Use it.
3786 * composite.c (get_composition_id): Remove unused local vars,
3787 by using the new macro.
3788
1e792e4d
PE
3789 * textprop.c (set_text_properties_1): Change while to do-while,
3790 since the condition is always true at first.
3791
dc6c6455 3792 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3793 (interval_deletion_adjustment): Return unsigned value.
3794 All uses changed.
dc6c6455 3795
aba7731a
PE
3796 * process.c (list_processes_1, create_pty, read_process_output):
3797 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3798 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3799 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3800 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3801 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3802
fdfc4bf3
PE
3803 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3804
fca8fe46 3805 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3806 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3807
06a0259a 3808 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3809 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3810 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3811
e7b9e80f
PE
3812 * print.c (print_error_message): Avoid int overflow.
3813
56201685
PE
3814 * font.c (font_list_entities): Redo for clarity,
3815 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3816
78834453 3817 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3818 (font_score): Avoid potential overflow in diff calculation.
78834453 3819
0bc0b309 3820 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3821 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3822
e610eaca
PE
3823 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3824
b895abce
PE
3825 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3826 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3827 can always succeed if overflow has undefined behavior.
3828
1f1d9321 3829 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3830 (wordify): Omit three unnecessary tests.
1f1d9321 3831
c59478bc
PE
3832 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3833 All callers changed. This avoids the need for an unused var.
3834
79b73827
PE
3835 * casefiddle.c (casify_region): Remove var that is set but not used.
3836
a4db5dfe
PE
3837 * dired.c (file_name_completion): Remove var that is set but not used.
3838
43aae36e
PE
3839 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3840
2a47c44d 3841 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3842 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3843
a37c69bf
PE
3844 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3845 Check for integer overflow on size calculations.
3846
328ab8e7
PE
3847 * buffer.c (Fprevious_overlay_change): Remove var that is set
3848 but not used.
3849
e5a2a5cb
PE
3850 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3851 Remove vars that are set but not used.
8d84a6eb 3852 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3853 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3854
a60e5f68
PE
3855 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3856
f661cb61 3857 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3858 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3859
f0397f5a
PE
3860 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3861 that are set but not used.
3862
8664db06 3863 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3864 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3865
6abdaa4a
PE
3866 * xselect.c (x_get_local_selection, x_handle_property_notify):
3867 Remove vars that are set but not used.
3868
0ce7538d 3869 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3870 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3871
9ae848fc
PE
3872 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3873 Remove var that is set but not used.
0b918413
PE
3874 (scroll_bar_windows_size): Now size_t, not int.
3875 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3876 Check for overflow.
9ae848fc 3877
a5a62657
PE
3878 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3879 (map_tty_color) [!defined MSDOS]: Likewise.
3880
5c5cdd39
PE
3881 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3882
66ebf983
PE
3883 * coding.c: Remove vars that are set but not used.
3884 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3885 All callers changed.
3886 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3887 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3888 (decode_coding_charset): Remove vars that are set but not used.
3889
1be4d761
PE
3890 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3891 that is set but not used.
3892
47553fa8
PE
3893 * print.c (print_object): Remove var that is set but not used.
3894
1f7196bf 3895 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3896 The gnulib version avoids calling malloc in the usual case,
3897 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3898 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3899 * filelock.c (current_lock_owner): Likewise.
3900 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3901 * sysdep.c: Include allocator.h, careadlinkat.h.
3902 (emacs_no_realloc_allocator): New static constant.
3903 (emacs_readlink): New function.
fdb61804
PE
3904 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3905 ../lib/careadlinkat.h.
d1fdcab7 3906
f84c17c7
SM
39072011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3908
3909 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3910 first non-nil return value).
3911
ef3862ad
JD
39122011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3913
3914 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3915 if not defined (Bug#8403).
3916
376a7006
JB
39172011-04-02 Juanma Barranquero <lekktu@gmail.com>
3918
3919 * xdisp.c (display_count_lines): Remove parameter `start',
3920 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3921 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3922 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3923 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3924 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3925 and thereabouts. All callers changed.
3926 (get_per_char_metric): Remove parameter `f', unused since
3927 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3928
6ca3801d
JM
39292011-04-02 Jim Meyering <meyering@redhat.com>
3930
3931 do not dereference NULL upon failed strdup
3932 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3933 (ns_get_family): Likewise.
3934
d8e2b5ba
JB
39352011-04-02 Juanma Barranquero <lekktu@gmail.com>
3936
3937 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3938
8c74fcbd
JD
39392011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3940
3941 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3942 later (Bug#8403).
3943
7200d79c
SM
39442011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3945
03408648 3946 Add lexical binding.
7200d79c 3947
03408648
SM
3948 * window.c (Ftemp_output_buffer_show): New fun.
3949 (Fsave_window_excursion):
3950 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3951
3952 * lread.c (lisp_file_lexically_bound_p): New function.
3953 (Fload): Bind Qlexical_binding.
3954 (readevalloop): Remove `evalfun' arg.
3955 Bind Qinternal_interpreter_environment.
3956 (Feval_buffer): Bind Qlexical_binding.
3957 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3958 Mark as dynamic.
3959 (syms_of_lread): Declare `lexical-binding'.
3960
3961 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3962
3963 * keyboard.c (eval_dyn): New fun.
3964 (menu_item_eval_property): Use it.
ca105506
SM
3965
3966 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3967
03408648
SM
3968 * fns.c (concat, mapcar1): Accept byte-code-functions.
3969
3970 * eval.c (Fsetq): Handle lexical vars.
3971 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3972 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3973 (FletX, Flet): Obey lexical binding.
3974 (Fcommandp): Handle closures.
3975 (Feval): New `lexical' arg.
3976 (eval_sub): New function extracted from Feval. Use it almost
3977 everywhere where Feval was used. Look up vars in lexical env.
3978 Handle closures.
3979 (Ffunctionp): Move from subr.el.
3980 (Ffuncall): Handle closures.
3981 (apply_lambda): Remove `eval_flags'.
3982 (funcall_lambda): Handle closures and new byte-code-functions.
3983 (Fspecial_variable_p): New function.
3984 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3985 but without exporting it to Lisp.
23aba0ea 3986
23aba0ea 3987 * doc.c (Fdocumentation, store_function_docstring):
03408648 3988 * data.c (Finteractive_form): Handle closures.
23aba0ea 3989
03408648
SM
3990 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3991 interactive spec.
ba83908c 3992
04f2d78b
CB
3993 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3994 New byte-codes.
03408648
SM
3995 (exec_byte_code): New function extracted from Fbyte_code to handle new
3996 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3997
03408648 3998 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3999
03408648 4000 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4001
e2abce01
JB
40022011-03-31 Juanma Barranquero <lekktu@gmail.com>
4003
4004 * xdisp.c (redisplay_internal): Fix prototype.
4005
63696a73 40062011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4007
63696a73 4008 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4009 (try_scrolling): Use it when setting scroll_limit.
4010 Limit scrolling to 100 screen lines.
63696a73
EZ
4011 (redisplay_window): Even when falling back on "recentering",
4012 position point in the window according to scroll-conservatively,
4013 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4014
4015 (try_scrolling): When point is above the window, allow searching
4016 as far as scroll_max, or one screenful, to compute vertical
4017 distance from PT to the scroll margin position. This prevents
4018 try_scrolling from unnecessarily failing when
4019 scroll-conservatively is set to a value slightly larger than the
4020 window height. Clean up the case of PT below the margin at bottom
4021 of window: scroll_max can no longer be INT_MAX. When aggressive
4022 scrolling is in use, don't let point enter the opposite scroll
4023 margin as result of the scroll.
4024 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4025 threshold of 100 lines for never-recentering scrolling.
4026
e4cc2dfc
JB
40272011-03-31 Juanma Barranquero <lekktu@gmail.com>
4028
4029 * dispextern.h (move_it_by_lines):
4030 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4031 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4032 (message_log_check_duplicate): Remove parameters `prev_bol' and
4033 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4034 (redisplay_internal): Remove parameter `preserve_echo_area',
4035 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4036
4037 * indent.c (Fvertical_motion):
4038 * window.c (window_scroll_pixel_based, Frecenter):
4039 Don't pass `need_y_p' to `move_it_by_lines'.
4040
1c470562
SM
40412011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4042
44f230aa
SM
4043 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4044 steal a few bits to be more compact.
4045 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4046 Remove unneeded casts.
4047
1c470562
SM
4048 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4049
888adce9
ZK
40502011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4051
4052 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4053 binding" message (bug#7967).
4054
f838ed7b
PE
40552011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4056
77861b95
PE
4057 Fix more problems found by GCC 4.6.0's static checks.
4058
de6dbc14
PE
4059 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4060 Remove unused local var.
4061
f838ed7b
PE
4062 * editfns.c (Fmessage_box): Remove unused local var.
4063
792c7b2b
PE
4064 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4065 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4066 Omit unused local vars.
c499e557 4067 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4068 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4069 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4070 Omit unused local var.
4071
ba0165e1
PE
4072 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4073 Don't assume string length fits in int.
32ad8845 4074 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4075 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4076
3c59b4c9
PE
4077 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4078 instead of alloca (Bug#8344).
4079
a3eed478 4080 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4081 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4082
eb4d412d
PE
4083 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4084
1658b401
PE
4085 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4086 concerns.
4087
4088 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4089
4090 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4091
9a2c6e05
PE
4092 * keyboard.c (syms_of_keyboard): Use the same style as later
4093 in this function when indexing through an array. This also
4094 works around GCC bug 48267.
4095
03d0a109
PE
4096 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4097
44f730c8
PE
4098 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4099
fe75f926
PE
4100 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4101 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4102
ffa8c828
PE
4103 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4104 This avoids undefined behavior on integer overflow, and is a bit
4105 more convenient anyway since it is compared to a size_t variable.
4106
c5101a77
PE
4107 Variadic C functions now count arguments with size_t, not int.
4108 This avoids an unnecessary limitation on 64-bit machines, which
4109 caused (substring ...) to crash on large vectors (Bug#8344).
4110 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4111 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4112 All variadic functions and their callers changed accordingly.
c5101a77
PE
4113 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4114 * data.c (arith_driver, float_arith_driver): Likewise.
4115 * editfns.c (general_insert_function): Likewise.
4116 * eval.c (struct backtrace.nargs, interactive_p)
4117 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4118 (funcall_lambda, mark_backtrace): Likewise.
4119 * fns.c (concat): Likewise.
4120 * frame.c (x_set_frame_parameters): Likewise.
4121 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4122 0 if not found, not -1. All callers changed.
4123
dd3f25f7
PE
4124 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4125 (stack_copy_size): Now size_t, not int.
4126 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4127
461c2ab9
JB
41282011-03-28 Juanma Barranquero <lekktu@gmail.com>
4129
4130 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4131 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4132 All callers changed.
4133
4134 * lisp.h (multibyte_char_to_unibyte):
4135 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4136 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4137 * character.h (CHAR_TO_BYTE8):
4138 * cmds.c (internal_self_insert):
4139 * editfns.c (general_insert_function):
4140 * keymap.c (push_key_description):
4141 * search.c (Freplace_match):
4142 * xdisp.c (message_dolog, set_message_1): All callers changed.
4143
f6d62986
SM
41442011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4145
4146 * keyboard.c (safe_run_hook_funcall): New function.
4147 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4148 don't set the hook to nil, but remove the offending function instead.
4149 (Qcommand_hook_internal): Remove, unused.
4150 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4151 Vcommand_hook_internal.
4152
4153 * eval.c (enum run_hooks_condition): Remove.
4154 (funcall_nil, funcall_not): New functions.
4155 (run_hook_with_args): Call each function through a `funcall' argument.
4156 Remove `cond' argument, now redundant.
4157 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4158 (Frun_hook_with_args_until_failure): Adjust accordingly.
4159 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4160
1db5b1ad
JB
41612011-03-28 Juanma Barranquero <lekktu@gmail.com>
4162
4163 * dispextern.h (string_buffer_position): Remove declaration.
4164
4165 * print.c (strout): Remove parameter `multibyte', unused since
4166 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4167
4168 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4169 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4170 All callers changed.
4171
4172 * w32.c (_wsa_errlist): Use braces for struct initializers.
4173
4174 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4175 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4176 All callers changed.
4177 (string_buffer_position): Likewise. Also, make static (it's never
4178 used outside xdisp.c).
4179 (cursor_row_p): Remove parameter `w', unused since
4180 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4181 (decode_mode_spec): Remove parameter `precision', introduced during
4182 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4183 All callers changed.
4184
5ffb62aa
JD
41852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4186
4187 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4188
461c2ab9 41892011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4190
4191 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4192 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4193 (ns_update_auto_hide_menu_bar): New functions.
4194 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4195 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4196 ns_constrain_all_frames.
4197 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4198 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4199
5c380ffb
JD
42002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4201
4202 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4203
9af30bdf
GM
42042011-03-27 Glenn Morris <rgm@gnu.org>
4205
4206 * syssignal.h: Replace RETSIGTYPE with void.
4207 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4208 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4209 Replace SIGTYPE with void everywhere.
4210 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4211 * s/template.h (SIGTYPE): Remove commented out definition.
4212
e2abce01
JB
42132011-03-26 Eli Zaretskii <eliz@gnu.org>
4214
4215 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4216 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4217
f868cd8a
JB
42182011-03-26 Juanma Barranquero <lekktu@gmail.com>
4219
59eb0929
JB
4220 * w32.c (read_unc_volume): Use parameter `henum', instead of
4221 global variable `wget_enum_handle'.
4222
4223 * keymap.c (describe_vector): Remove parameters `indices' and
4224 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4225 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4226
f868cd8a
JB
4227 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4228
4229 * keyboard.c (timer_check): Remove parameter `do_it_now',
4230 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4231 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4232 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4233
4234 * keyboard.c (read_char):
4235 * w32menu.c (w32_menu_display_help):
4236 * xmenu.c (show_help_event, menu_help_callback):
4237 Adjust calls to `show_help_echo'.
4238
4239 * gtkutil.c (xg_maybe_add_timer):
4240 * keyboard.c (readable_events):
4241 * process.c (wait_reading_process_output):
4242 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4243
4244 * insdel.c (adjust_markers_gap_motion):
4245 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4246 (gap_left, gap_right): Don't call it.
4247
2ecf6fdb
CY
42482011-03-25 Chong Yidong <cyd@stupidchicken.com>
4249
4250 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4251 incurred during fontification.
4252
6b1f9ba4
JB
42532011-03-25 Juanma Barranquero <lekktu@gmail.com>
4254
4255 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4256 (DEFVAR_PER_BUFFER): Don't pass it.
4257
4258 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4259 (scrolling_window): Don't pass it.
4260
0f4a96b5
JB
42612011-03-25 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4264
4265 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4266 and `suffix'.
4267 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4268 of variables specific to SELinux and computation of `encoded_absname'.
4269
4270 * image.c (XPutPixel): Remove unused variable `height'.
4271
4272 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4273
4274 * unexw32.c (get_section_info): Remove unused variable `section'.
4275
4276 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4277 (system_process_attributes): Remove unused variable `sess'.
4278 (sys_read): Remove unused variable `err'.
4279
4280 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4281 (w32_wnd_proc): Remove unused variable `isdead'.
4282 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4283 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4284 (x_create_tip_frame): Remove unused variable `tem'.
4285
4286 * w32inevt.c (w32_console_read_socket):
4287 Remove unused variable `no_events'.
4288
4289 * w32term.c (x_draw_composite_glyph_string_foreground):
4290 Remove unused variable `width'.
4291
1149507c
JB
42922011-03-24 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * w32term.c (x_set_glyph_string_clipping):
4295 Don't pass uninitialized region to CombineRgn.
4296
9c88f339
JB
42972011-03-23 Juanma Barranquero <lekktu@gmail.com>
4298
4299 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4300 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4301 (Fx_close_connection): Remove unused variable `i'.
4302
4303 * w32font.c (w32font_draw): Return number of glyphs.
4304 (w32font_open_internal): Remove unused variable `i'.
4305 (w32font_driver): Add missing initializer.
4306
4307 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4308 (fill_in_menu): Remove unused variable `items_added'.
4309
4310 * w32term.c (last_mouse_press_frame): Remove static global variable.
4311 (w32_clip_to_row): Remove unused variable `f'.
4312 (x_delete_terminal): Remove unused variable `i'.
4313
4314 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4315 (NOTHING): Remove unused static global variable.
4316 (uniscribe_check_otf): Remove unused variable `table'.
4317 (uniscribe_font_driver): Add missing initializers.
4318
dee091a3
JD
43192011-03-23 Julien Danjou <julien@danjou.info>
4320
4321 * term.c (Fsuspend_tty, Fresume_tty):
4322 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4323 * window.c (temp_output_buffer_show):
4324 * insdel.c (signal_before_change):
4325 * frame.c (Fhandle_switch_frame):
4326 * fileio.c (Fdo_auto_save):
4327 * emacs.c (Fkill_emacs):
4328 * editfns.c (save_excursion_restore):
4329 * cmds.c (internal_self_insert):
4330 * callint.c (Fcall_interactively):
4331 * buffer.c (Fkill_all_local_variables):
4332 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4333 Use Frun_hooks.
0f4a96b5 4334 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4335 unconditionnaly since it does the check itself.
4336
2c520ab5 43372011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4338
c9c49752
PE
4339 Fix more problems found by GCC 4.5.2's static checks.
4340
8abc3f12
PE
4341 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4342 the first time through the loop, since we know p0 < p1 then.
4343 This also avoids a gcc -Wstrict-overflow warning.
4344
a2d26660
PE
4345 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4346 leading to a memory leak, possible in functions like
4347 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4348 of objects (Bug#8318).
a2d26660 4349
916c72e9
PE
4350 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4351 that could (at least in theory) be that large.
4352
19ab8a18
PE
4353 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4354 This is less likely to overflow, and avoids undefined behavior if
4355 overflow does occur. All callers changed. Use strtoul to scan
4356 for the unsigned long integer.
b7cbbd6f
PE
4357 (pint2hrstr): Simplify and tune code slightly.
4358 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4359
f0641eff
PE
4360 * scroll.c (do_scrolling): Work around GCC bug 48228.
4361 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4362
7f650bb9
PE
4363 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4364 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4365 (validate_x_resource_name): Simplify count usage.
4366 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4367
37dd57d1
PE
4368 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4369 fail (Bug#8306).
81e56e61 4370
699979fc 4371 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4372
401bf9b4
PE
4373 * process.c (Fmake_network_process): Use socklen_t, not int,
4374 where POSIX says socklen_t is required in portable programs.
4375 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4376 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4377 (Fmake_network_process, server_accept_connection):
4378 (wait_reading_process_output, read_process_output):
4379 Likewise.
4380
b93aacde
PE
4381 * process.c: Rename or move locals to avoid shadowing.
4382 (list_processes_1, Fmake_network_process):
4383 (read_process_output_error_handler, exec_sentinel_error_handler):
4384 Rename or move locals.
4dc343ee 4385 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4386 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4387 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4388 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4389 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4390
af8a867c 4391 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4392 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4393 Include tparam.h instead, since it declares them.
af8a867c
PE
4394 * cm.h (PC): Remove extern decl; tparam.h now does this.
4395 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4396 * terminfo.c: Include tparam.h, to check interfaces.
4397 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4398 (tparam): Adjust signature to match interface in tparam.h;
4399 this removes some undefined behavior. Check that outstring and len
4400 are zero, which they always are with Emacs.
4401 * tparam.h (PC, BC, UP): New extern decls.
4402
0248044d 4403 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4404 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4405
8ff096c1 4406 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4407 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4408 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4409 (ftfont_list): Remove unused local.
49eaafba
PE
4410 (get_adstyle_property, ftfont_pattern_entity):
4411 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4412 Rename locals to avoid shadowing.
8ff096c1 4413
e2be39f6
PE
4414 * xfont.c (xfont_list_family): Mark var as initialized.
4415
c9735e30
PE
4416 * xml.c (make_dom): Now static.
4417
8f5201ae
PE
4418 * composite.c (composition_compute_stop_pos): Rename local to
4419 avoid shadowing.
b246f932
PE
4420 (composition_reseat_it): Remove unused locals.
4421 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4422 (composition_update_it): Mark var as initialized.
11b61122
PE
4423 (find_automatic_composition): Mark vars as initialized,
4424 with a FIXME (Bug#8290).
8f5201ae 4425
760fbc2c
PE
4426 character.h: Rename locals to avoid shadowing.
4427 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4428 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4429 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4430 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4431 to avoid shadowing.
4432
ff08eb85
PE
4433 * textprop.c (property_change_between_p): Remove; unused.
4434
fc7bf025
PE
4435 * intervals.c (interval_start_pos): Now static.
4436
235d7abc
PE
4437 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4438
44f230aa
SM
4439 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4440 Rename locals to avoid shadowing.
3e7d6594 4441
50060332
PE
4442 * sound.c (wav_play, au_play, Fplay_sound_internal):
4443 Fix pointer signedness.
d01f234b 4444 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4445 (wav_play): Initialize a variable to 0, to prevent undefined
4446 behavior (Bug#8278).
50060332 4447
c4fc4e30
PE
4448 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4449
918436ed
PE
4450 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4451
c939f91b
PE
4452 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4453 clobbering (Bug#8298).
b9c7f648
PE
4454 * sysdep.c (sys_subshell): Likewise.
4455 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4456
6bd8c144
PE
4457 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4458 This should get cleaned up, so that child_setup has the
4459 same signature on all platforms.
4460
7710357c 4461 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4462 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4463
c59da222
CY
44642011-03-22 Chong Yidong <cyd@stupidchicken.com>
4465
4466 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4467 not to be necessary, and produces flickering.
4468
66b87493
GM
44692011-03-20 Glenn Morris <rgm@gnu.org>
4470
4471 * config.in: Remove file.
4472
45b6f6d5
JB
44732011-03-20 Juanma Barranquero <lekktu@gmail.com>
4474
4475 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4476 are now in src/globals.h.
4477 (syms_of_minibuf): Remove spurious & from previous change.
4478
3ec03f7e
LL
44792011-03-20 Leo <sdl.web@gmail.com>
4480
4481 * minibuf.c (completing-read-function): New variable.
4482 (completing-read-default): Rename from completing-read.
4483 (completing-read): Call completing-read-function.
4484
b14e3e21
CY
44852011-03-19 Juanma Barranquero <lekktu@gmail.com>
4486
4487 * xfaces.c (Fx_load_color_file):
4488 Read color file from absolute filename (bug#8250).
4489
f2b726e6
JB
44902011-03-19 Juanma Barranquero <lekktu@gmail.com>
4491
4492 * makefile.w32-in: Update dependencies.
4493
09f6ff02
EZ
44942011-03-17 Eli Zaretskii <eliz@gnu.org>
4495
4496 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4497
29a6015a
PE
44982011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4499
a3a6c54e
PE
4500 Fix more problems found by GCC 4.5.2's static checks.
4501
b766f867
PE
4502 * process.c (make_serial_process_unwind, send_process_trap):
4503 (sigchld_handler): Now static.
4504
be02381c
PE
4505 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4506 That way, the code declares only the vars that it needs.
4507 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4508 * s/cygwin.h (PTY_ITERATION): Likewise.
4509 * s/darwin.h (PTY_ITERATION): Likewise.
4510 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4511
57048744
PE
4512 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4513 * process.c (allocate_pty): Don't declare stb unless it's needed.
4514
7914961c 4515 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4516 (CONSTANTLIM): Remove; unused.
4517 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4518 Define only if needed.
7914961c 4519
b3967b18
PE
4520 * unexelf.c (unexec): Name an expression,
4521 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4522 Use a different way to cause a compilation error if anyone uses
4523 n rather than nn, a way that does not involve shadowing.
73366a00 4524 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4525
29a6015a
PE
4526 * deps.mk (unexalpha.o): Remove; unused.
4527
43cfc33e 4528 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4529 * unexec.h: New file.
ce701a33
PE
4530 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4531 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4532 Depend on unexec.h.
4533 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4534 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4535 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4536 Change as necessary to match prototype in unexec.h.
ce701a33 4537
01f44d5a
PE
4538 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4539 shadowing.
4f63c6bb 4540 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4541
a6670b0b
PE
4542 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4543 Rename locals to avoid shadowing.
4544
cef2010d 4545 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4546 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4547
d4d7173a
PE
4548 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4549
f08b802a
PE
4550 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4551 warning when compiling print.c.
4552
3ddb0639
PE
4553 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4554 instead of using an uninitialized var.
5ad03b97 4555 (font_sort_entities): Mark var as initialized.
3ddb0639 4556
170a2692
PE
4557 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4558
e663c700
PE
4559 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4560 pointers to constants.
89bc529a 4561 (font_parse_fcname): Remove unused vars.
7b81e2d0 4562 (font_delete_unmatched): Now static.
ea838e10 4563 (font_get_spec): Remove; unused.
13a547c6
PE
4564 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4565 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4566 Rename or move locals to avoid shadowing.
e663c700 4567
2a80c887 4568 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4569 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4570
1384fa33 4571 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4572 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4573
8b2c52e9
PE
4574 * alloc.c (mark_backtrace): Move decl from here ...
4575 * lisp.h: ... to here, so that it can be checked.
4576
475545b5 4577 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4578 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4579 (lisp_indirect_variable): Name an expression,
4580 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4581 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4582
b1349114 4583 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4584 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4585 Use const pointer when appropriate.
b1349114 4586
a2928364
PE
4587 * lisp.h (get_system_name, get_operating_system_release):
4588 Move decls here, to check interfaces.
4589 * process.c (get_operating_system_release): Move decl to lisp.h.
4590 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4591 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4592 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4593 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4594 (Fformat_time_string, Fencode_time, Finsert_char):
4595 (Ftranslate_region_internal, Fformat):
4596 Rename or remove local vars to avoid shadowing.
9710023e 4597 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4598
a415e694
PE
4599 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4600 avoid shadowing.
4601
8ef4622d
PE
4602 * lisp.h (eassert): Check that the argument compiles, even if
4603 ENABLE_CHECKING is not defined.
4604
946f9a5b
PE
4605 * data.c (Findirect_variable): Name an expression, to avoid
4606 gcc -Wbad-function-cast warning.
112396d6 4607 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4608 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4609 (Fmake_variable_buffer_local, Fmake_local_variable):
4610 Mark variables as initialized.
52746918 4611 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4612
e5aab7e7 4613 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4614 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4615 Rename locals to avoid shadowing.
dff45157
PE
4616 (mark_stack): Move local variables into the #ifdef region where
4617 they're used.
7bc26fdb
PE
4618 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4619 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4620 needed otherwise.
4621 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4622 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4623 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4624
e5aab7e7
PE
4625 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4626 avoids undefined behavior in theory.
4627
4da60324
PE
4628 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4629
88043301
PE
4630 Use functions, not macros, for up- and down-casing (Bug#8254).
4631 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4632 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4633 to use the following functions instead of these macros.
4634 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4635 EMACS_INT, since callers assume the returned value fits in int.
4636 (upcase1): Likewise, for UPCASE_TABLE.
4637 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4638 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4639 the race-condition problem in the old DOWNCASE.
88043301 4640
19ed5445
PE
4641 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4642 Rename locals to avoid shadowing.
4643 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4644 (regex_compile, re_search_2, re_match_2_internal):
4645 Remove unused local vars.
952db0d7
PE
4646 (FREE_VAR): Rewrite so as not to use empty "else",
4647 which gcc can warn about.
da053e48 4648 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4649 (RETALLOC_IF): Define only if needed.
4650 (WORDCHAR_P): Likewise. This one is never needed, but is used
4651 only in a comment talking about a compiler bug, so put inside
4652 the #if 0 of that comment.
4653 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4654 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4655 Remove; unused.
19ed5445 4656
1f3561e4 4657 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4658 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4659 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4660
ded6f8f7
PE
4661 * search.c (simple_search): Remove unused var.
4662
dbd37a95
PE
4663 * dired.c (compile_pattern): Move decl from here ...
4664 * lisp.h: ... to here, so that it can be checked.
4665 (struct re_registers): New forward decl.
4666
7e47afad
PE
4667 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4668
85f24f61
PE
4669 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4670 All uses changed.
4671 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4672 Rename locals to avoid shadowing.
5671df8f 4673 (Fvertical_motion): Mark locals as initialized.
85f24f61 4674
181aa2be 4675 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4676 (casify_region): Mark local as initialized.
181aa2be 4677
930d429c
PE
4678 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4679
7082eac6
PE
4680 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4681 New macros, so that the caller can use some names other than
4682 gcpro1, gcpro2, etc.
4683 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4684 of the new macros.
4685 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4686 argument, for consistency with GCPRO2_VAR, etc: it is now the
4687 prefix of the variable, not the variable itself. All uses
4688 changed.
38b2c076
PE
4689 * dired.c (directory_files_internal, file_name_completion):
4690 Rename locals to avoid shadowing.
4691
15206ed9
PE
4692 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4693 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4694 dired.c's scmp function, had undefined behavior.
4695 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4696 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4697 * buffer.h: ... to here, because these macros use current_buffer,
4698 and the new implementation with inline functions needs to have
4699 current_buffer in scope now, rather than later when the macros
4700 are used.
4701 (downcase, upcase1): New static inline functions.
4702 (DOWNCASE, UPCASE1): Reimplement using these functions.
4703 This avoids undefined behavior in expressions like
4704 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4705 from race conditions in accessing the global variables
4706 case_temp1 and case_temp2.
4707 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4708 * lisp.h (case_temp1, case_temp2): Remove their decls.
4709 * character.h (ASCII_CHAR_P): Move from here ...
4710 * lisp.h: ... to here, so that the inline functions mentioned
4711 above can use them.
4712
4a6bea26
PE
4713 * dired.c (directory_files_internal_unwind): Now static.
4714
f14b7e14
PE
4715 * fileio.c (file_name_as_directory, directory_file_name):
4716 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4717 Now static.
2893f146
PE
4718 (file_name_as_directory): Use const pointers when appropriate.
4719 (Fexpand_file_name): Likewise. In particular, newdir might
4720 point at constant storage, so make it a const pointer.
fd4ead52 4721 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4722 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4723 signedness issues.
f839df0c
PE
4724 (Fset_file_times, Finsert_file_contents, auto_save_error):
4725 Rename locals to avoid shadowing.
f14b7e14 4726
5716756e 4727 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4728 (Ftry_completion, Fall_completions): Rename or remove locals
4729 to avoid shadowing.
5716756e 4730
b4c3046a
PE
4731 * marker.c (bytepos_to_charpos): Remove; unused.
4732
b45db522
PE
4733 * lisp.h (verify_bytepos, count_markers): New decls,
4734 so that gcc does not warn that these functions aren't declared.
4735
85876d07
PE
4736 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4737 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4738 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4739 (copy_text): Remove unused local var.
85876d07 4740
03d78a21 4741 * filelock.c (within_one_second): Now static.
b3dd38ab 4742 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4743
5df8f01b
PE
4744 * buffer.c (fix_overlays_before): Mark locals as initialized.
4745 (fix_start_end_in_overlays): Likewise. This function should be
4746 simplified by using pointers-to-pointers, but that's a different
4747 matter.
b1d876f1 4748 (switch_to_buffer_1): Now static.
8f54f30a
PE
4749 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4750 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4751
a70072c9 4752 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4753 Fix pointer signedness issue.
edced198
PE
4754 (sys_subshell): Mark local as volatile if checking for lint,
4755 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4756 (MAXPATHLEN): Define only if needed.
a70072c9 4757
a0977c44
PE
4758 * process.c (serial_open, serial_configure): Move decls from here ...
4759 * systty.h: ... to here, so that they can be checked.
4760
a884fdcc
PE
4761 * fns.c (get_random, seed_random): Move extern decls from here ...
4762 * lisp.h: ... to here, so that they can be checked.
4763
604efe86 4764 * sysdep.c (reset_io): Now static.
b8950c94 4765 (wait_for_termination_signal): Remove; unused.
604efe86 4766
38fc62d9
PE
4767 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4768 (copy_keymap_item, append_key, push_text_char_description):
4769 Now static.
1004a21a 4770 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4771 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4772 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4773 (describe_map_tree):
4774 Rename locals to avoid shadowing.
38fc62d9 4775
2f2650da
PE
4776 * keyboard.c: Declare functions static if they are not used elsewhere.
4777 (echo_char, echo_dash, cmd_error, top_level_2):
4778 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4779 (read_char, kbd_buffer_get_event, make_lispy_position):
4780 (make_lispy_event, make_lispy_movement, apply_modifiers):
4781 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4782 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4783 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4784 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4785 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4786
a053e86c 4787 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4788 (mark_kboards): Move decl here ...
4789 * alloc.c (mark_kboards): ... from here.
a053e86c 4790
4752793e
PE
4791 * lisp.h (force_auto_save_soon): New decl.
4792
74f10ca7 4793 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4794 (DEFINE_DUMMY_FUNCTION): New macro.
4795 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4796 Use it.
c03cd23f
PE
4797 (main): Add casts to avoid warnings
4798 if GCC considers string literals to be constants.
74f10ca7 4799
022e70d4
PE
4800 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4801
59d6fe83
PE
4802 * dbusbind.c: Pointer signedness fixes.
4803 (xd_signature, xd_append_arg, xd_initialize):
4804 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4805 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4806 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4807 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4808
78320123
PE
4809 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4810 if GCC considers string literals to be constants.
49cebcca 4811 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4812
35ac2a97
SM
48132011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4814
fb103ca9
SM
4815 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4816 (print_preprocess, print_object): New macro to fix last change.
4817
35ac2a97
SM
4818 * print.c (print_preprocess): Don't forget font objects.
4819
62973b41
JB
48202011-03-16 Juanma Barranquero <lekktu@gmail.com>
4821
4822 * emacs.c (USAGE3): Doc fixes.
4823
0e48bb22
AS
48242011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4825
4826 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4827 structure.
4828
7684e57b
JB
48292011-03-14 Juanma Barranquero <lekktu@gmail.com>
4830
4831 * lisp.h (VWindow_system, Qfile_name_history):
4832 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4833 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4834 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4835
4836 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4837 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4838
4839 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4840 * w32console.c (detect_input_pending, read_input_pending)
4841 (encode_terminal_code):
4842 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4843 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4844 (w32_system_caret_y, Qfile_name_history):
4845 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4846 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4847 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4848 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4849 * w32proc.c (Qlocal, report_file_error):
4850 * w32term.c (Vwindow_system, updating_frame):
4851 * w32uniscribe.c (initialized, uniscribe_font_driver):
4852 Remove unneeded extern declarations.
4853
2aa46d6c
CY
48542011-03-14 Chong Yidong <cyd@stupidchicken.com>
4855
c96bbc66 4856 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4857
cffc6f3b
CY
48582011-03-13 Chong Yidong <cyd@stupidchicken.com>
4859
4860 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4861 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4862 These macros can no longer be used for assignment.
4863
44f230aa
SM
4864 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4865 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4866 (record_buffer_markers, fetch_buffer_markers): New functions for
4867 recording and fetching special buffer markers.
4868 (set_buffer_internal_1, set_buffer_temp): Use them.
4869
4870 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4871
4872 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4873
4874 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4875 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4876
4877 * xdisp.c (hscroll_window_tree):
4878 (reconsider_clip_changes): Use PT instead of BUF_PT.
4879
d251f04b
EZ
48802011-03-13 Eli Zaretskii <eliz@gnu.org>
4881
4882 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4883 $(EMACS_ROOT)/lib/intprops.h.
4884
f0c77cd1
PE
48852011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4886
3eca4629
PE
4887 Fix more problems found by GCC 4.5.2's static checks.
4888
7c86ee98
PE
4889 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4890 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4891 (xg_free_frame_widgets): Make it clear that a local variable is
4892 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4893 (gdk_window_get_screen): Make it clear that this macro is needed
4894 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4895 (int_gtk_range_get_value): New function, which avoids a diagnostic
4896 from gcc -Wbad-function-cast.
4897 (xg_set_toolkit_scroll_bar_thumb): Use it.
4898 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4899 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4900 (get_utf8_string, xg_get_file_with_chooser):
4901 Rename locals to avoid shadowing.
4902 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4903
41729b81
PE
4904 * xgselect.c (xg_select): Remove unused var.
4905
f0c77cd1
PE
4906 * image.c (four_corners_best): Mark locals as initialized.
4907 (gif_load): Initialize transparent_p to zero (Bug#8238).
4908 Mark another local as initialized.
ec6cf4c6 4909 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4910
ce0ad53d 4911 * image.c (clear_image_cache): Now static.
d5d5a617 4912 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4913 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4914 (x_edge_detection): Remove unnecessary cast that
4915 gcc -Wbad-function-cast diagnoses.
2037898d 4916 (gif_load): Fix pointer signedness.
6ae141d6
PE
4917 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4918 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4919
33383987 49202011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4921
d32df629
PE
4922 Improve quality of tests for time stamp overflow.
4923 For example, without this patch (encode-time 0 0 0 1 1
4924 1152921504606846976) returns the obviously-bogus value (-948597
4925 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4926 reports time overflow. See
4927 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4928 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4929 * editfns.c: Include limits.h and intprops.h.
4930 (TIME_T_MIN, TIME_T_MAX): New macros.
4931 (time_overflow): Move earlier, to before first use.
4932 (hi_time, lo_time): New functions, for an accurate test for
4933 out-of-range times.
4934 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4935 (Fget_internal_run_time): Don't assume time_t fits in int.
4936 (make_time): Use list2 instead of Fcons twice.
4937 (Fdecode_time): More accurate test for out-of-range times.
4938 (check_tm_member): New function.
4939 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4940 (lisp_time_argument): Don't rely on undefined left-shift and
4941 right-shift behavior when checking for time stamp overflow.
8be6f318 4942
fe31d94c
PE
4943 * editfns.c (time_overflow): New function, refactoring common code.
4944 (Fformat_time_string, Fdecode_time, Fencode_time):
4945 (Fcurrent_time_string): Use it.
4946
8be6f318
PE
4947 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4948 * dired.c (make_time): Move to ...
4949 * editfns.c (make_time): ... here.
4950 * systime.h: Note the move.
4951
09d9db2c 49522011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4953
126bc0dc
YM
4954 * fringe.c (update_window_fringes): Remove unused variables.
4955
c47cbdfd
YM
4956 * unexmacosx.c (copy_data_segment): Also copy __got section.
4957 (Bug#8223)
4958
7ac80be9
EZ
49592011-03-12 Eli Zaretskii <eliz@gnu.org>
4960
c96bbc66 4961 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4962 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4963 Constify `char *' arguments and their references according to
4964 prototypes in tparam.h.
4965
ecb0f94d 4966 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4967
7ac80be9
EZ
4968 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4969 Adapt all references accordingly.
4970
4971 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4972
ef1fd07e
TT
49732011-03-11 Tom Tromey <tromey@redhat.com>
4974
4975 * buffer.c (syms_of_buffer): Remove obsolete comment.
4976
7ef4b50c
EZ
49772011-03-11 Eli Zaretskii <eliz@gnu.org>
4978
4979 * termhooks.h (encode_terminal_code): Declare prototype.
4980
4981 * msdos.c (encode_terminal_code): Don't declare prototype.
4982
4983 * term.c (encode_terminal_code): Now external again, used by
4984 w32console.c and msdos.c.
4985
44f230aa
SM
4986 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4987 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4988
4b1ec863 49892011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4990
1714f52b 4991 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4992
4b1ec863
PE
4993 * fringe.c (update_window_fringes): Mark locals as initialized
4994 (Bug#8227).
4995 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4996
524c7aa6
PE
4997 * alloc.c (mark_fringe_data): Move decl from here ...
4998 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4999 to check its interface.
5000 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5001
a5c0af81 5002 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5003 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5004 (fontset_font): Mark local as initialized.
a9a06e0b 5005 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5006
b4716021
PE
5007 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5008
811e9bac 5009 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5010 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5011 (x_own_selection, Fx_disown_selection_internal): Rename locals
5012 to avoid shadowing.
5013 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5014
7e3ab302
PE
5015 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5016 so that the caller can use some name other than gcpro1.
5017 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5018 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5019 (Fx_backspace_delete_keys_p):
5020 Use them to avoid shadowing, and rename vars to avoid shadowing.
5021 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5022 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5023 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5024 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5025 Remove unused locals.
7e3ab302
PE
5026 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5027 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5028 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5029 macros.
f78faa98 5030
e2b13473
PE
5031 * xterm.h (x_mouse_leave): New decl.
5032
77f23912
PE
5033 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5034 Remove unused functions.
cdf4ba58
PE
5035 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5036 (x_calc_absolute_position): Now static.
7411c686 5037 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5038 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5039 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5040 unless they are used.
38d0b34a
PE
5041 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5042 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5043 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5044 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5045 (x_error_catcher, x_connection_closed, x_error_handler):
5046 (x_error_quitter, xembed_send_message, x_iconify_frame):
5047 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5048 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5049 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5050
44f230aa
SM
5051 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5052 Rename or move locals to avoid shadowing.
6b463e58 5053 (tty_defined_color, merge_face_heights): Now static.
5967d051 5054 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5055 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5056 does not deduce is never used uninitialized.
73719eba
PE
5057 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5058 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5059
426994c3 5060 * terminal.c (store_terminal_param): Now static.
5489860b 5061
032f1620 5062 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5063 (set_frame_menubar): Remove unused local.
d4323972 5064 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5065 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5066 since they might point to immutable storage.
281585b0
PE
5067 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5068 since it's unused otherwise.
032f1620 5069
367c19e5 5070 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5071 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5072 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5073 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5074 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5075 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5076 does not deduce are never used uninitialized.
70739cbe 5077
07b48fa9
PE
5078 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5079
8868a238 5080 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5081 * window.c (window_loop, size_window):
5082 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5083
7e5cf297 5084 * window.c (display_buffer): Now static.
d6550a9f
PE
5085 (size_window): Mark variables that gcc -Wuninitialized
5086 does not deduce are never used uninitialized.
a586633d
PE
5087 * window.h (check_all_windows): New decl, to forestall
5088 gcc -Wmissing-prototypes diagnostic.
5b555da1 5089 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5090
f6095868
PE
5091 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5092 shadowing.
5093 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5094 Include <limits.h>.
5095 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5096 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5097 (load_charset_map): Mark variables that gcc -Wuninitialized
5098 does not deduce are never used uninitialized.
53df7c11 5099 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5100
f38b440c
PE
5101 * coding.c (coding_set_source, coding_set_destination):
5102 Use "else { /* comment */ }" rather than "else /* comment */;"
5103 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5104 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5105 a block, when the outer 'i' will do.
5106 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5107 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5108 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5109 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5110 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5111 Rename locals to avoid shadowing.
5112 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5113 * coding.c (emacs_mule_char, encode_invocation_designation):
5114 Now static, since they're not used elsewhere.
413bb2db 5115 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5116 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5117 (decode_coding_emacs_mule): Mark variables that gcc
5118 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5119 (detect_coding_iso_2022): Initialize a local variable that might
5120 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5121 this initialization is needed. (Bug#8211)
5f58e762
PE
5122 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5123 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5124 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5125 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5126 Remove unused macros.
f38b440c 5127
232b38b9 5128 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5129 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5130 * character.c (string_count_byte8): Likewise.
232b38b9 5131
fb90da1b
PE
5132 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5133 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5134
fb93dbc2
PE
5135 * chartab.c (copy_sub_char_table): Now static, since it's not used
5136 elsewhere.
5c156ace
PE
5137 (sub_char_table_ref_and_range, char_table_ref_and_range):
5138 Rename locals to avoid shadowing.
bbcd0949 5139 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5140
7d3b3862 5141 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5142 (BIDI_BOB): Remove unused macro.
7d3b3862 5143
6be7d3da
PE
5144 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5145 deduce are never used uninitialized.
c2ed9c8b 5146 * term.c (encode_terminal_code): Likewise.
6be7d3da 5147
75f8807f 5148 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5149
50938595
PE
5150 * tparam.h: New file.
5151 * term.c, tparam.h: Include it.
5152 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5153 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5154 Move these decls to tparam.h, and make them agree with what
5155 is actually in tparam.c. The previous trick of using incompatible
5156 decls in different modules does not conform to the C standard.
5157 All callers of tparam changed to use tparam's actual API.
5158 * tparam.c (tparam1, tparam, tgoto):
5159 Use const pointers where appropriate.
5160
fbceeba2
PE
5161 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5162 * cm.h (struct cm): Likewise.
5163 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5164 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5165 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5166 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5167 (turn_on_face, init_tty): Likewise.
5168 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5169
7f3f1250
PE
5170 * term.c (term_mouse_position): Rename local to avoid shadowing.
5171
e6ca6543
PE
5172 * alloc.c (mark_ttys): Move decl from here ...
5173 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5174
c40f8d15
AS
51752011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5176
5177 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5178
cfe0661d
JB
51792011-03-09 Juanma Barranquero <lekktu@gmail.com>
5180
5181 * search.c (compile_pattern_1): Remove argument regp, unused since
5182 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5183 (compile_pattern): Don't pass it.
5184
0afb4571
J
51852011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5186
5187 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5188 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5189 for ! HAVE_GTK3.
5190 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5191
5192 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5193
5194 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5195 gdk_window_get_screen, gdk_window_get_geometry,
5196 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5197 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5198 (xg_get_pixbuf_from_pixmap): New function.
5199 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5200 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5201 Call xg_get_pixbuf_from_pixmap instead of
5202 gdk_pixbuf_get_from_drawable.
5203 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5204 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5205 (xg_check_special_colors): Use GtkStyleContext and its functions
5206 for HAVE_GTK3.
5207 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5208 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5209 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5210 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5211 Call gtk_widget_get_preferred_size.
0afb4571
J
5212 (xg_frame_resized): gdk_window_get_geometry only takes 5
5213 parameters.
44f230aa
SM
5214 (xg_win_to_widget, xg_event_is_for_menubar):
5215 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5216 (xg_set_widget_bg): New function.
5217 (delete_cb): New function.
895009e1 5218 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5219 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5220 (xg_set_background_color): Call xg_set_widget_bg.
5221 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5222 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5223 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5224 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5225 if ! HAVE_GTK3.
5226 (update_frame_tool_bar): Call gtk_widget_hide.
5227 (xg_initialize): Use GDK_KEY_g.
5228
5229 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5230 if ! HAVE_GTK3
5231 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5232
5233 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5234 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5235 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5236
1c2cc4ef
JB
52372011-03-08 Juanma Barranquero <lekktu@gmail.com>
5238
5239 * w32xfns.c (select_palette): Check success of RealizePalette against
5240 GDI_ERROR, not zero.
5241
33383987 5242See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5243
5244;; Local Variables:
5245;; coding: utf-8
aac0c6e3
MR
5246;; End:
5247
33383987 5248 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5249
5250 This file is part of GNU Emacs.
5251
5252 GNU Emacs is free software: you can redistribute it and/or modify
5253 it under the terms of the GNU General Public License as published by
5254 the Free Software Foundation, either version 3 of the License, or
5255 (at your option) any later version.
5256
5257 GNU Emacs is distributed in the hope that it will be useful,
5258 but WITHOUT ANY WARRANTY; without even the implied warranty of
5259 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5260 GNU General Public License for more details.
5261
5262 You should have received a copy of the GNU General Public License
5263 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.