src/gnutls.c: Fix previous change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d69621cc
JB
12012-04-24 Juanma Barranquero <lekktu@gmail.com>
2
3 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4 manipulation of :loaded-from data.
5
02fd101b
JB
62012-04-23 Juanma Barranquero <lekktu@gmail.com>
7
8 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
9 now a cons (bug#11311).
10
888bec30
PE
112012-04-23 Paul Eggert <eggert@cs.ucla.edu>
12
89a438bd
PE
13 Do not create empty overlays with the evaporate property (Bug#9642).
14 * buffer.c (Fmove_overlay): Delete an evaporating overlay
15 if it becomes empty after its bounds are adjusted to fit within
16 its buffer. Without this fix, in a nonempty buffer (let ((o
17 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
18 yields an empty overlay that has the evaporate property, which is
19 not supposed to happen.
20
1068fe4d
PE
21 Fix minor GTK3 problems found by static checking.
22 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
23 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
24 (struct _EmacsFixedClass, emacs_fixed_get_type):
25 Move decls here from emacsgtkfixed.h, since they needn't be public.
26 (emacs_fixed_get_type): Now static.
27 (emacs_fixed_class_init): Omit unused local.
28 (emacs_fixed_child_type): Remove; unused.
29 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
30 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
31 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
32 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
33 (EMACS_FIXED_GET_CLASS): Remove; unused.
34 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
35
888bec30
PE
36 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
37 Problem reported by Juanma Barranquero for Windows -Wunused-function.
38
de85e130
PE
392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
40
d0baac98
PE
41 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
42 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
43 (__malloc_size_t, __malloc_ptrdiff_t):
44 Remove. All uses removed, replaced by the definiens if needed,
45 since we can assume C89 or better now.
46 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
47 (protect_malloc_state, align, get_contiguous_space)
48 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
49 (malloc_atfork_handler_child, malloc_enable_thread)
50 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
51 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
52 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
53 (special_realloc, _realloc_internal_nolock, _realloc_internal)
54 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
55 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
56 Define using prototypes, not old style.
57 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
58 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
59 (align): Don't assume that signed integer overflow wraps around.
60 Omit unused local var.
61 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
62 (_free_internal_nolock, memalign, mallochook, reallochook):
63 Omit no-longer-needed casts.
64 (valloc): Use getpagesize, not __getpagesize.
65 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
66 (struct hdr): The 'magic' member is now size_t, not unsigned long.
67
de85e130
PE
68 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
69
dcbf5805
MA
702012-04-22 Michael Albinus <michael.albinus@gmx.de>
71
72 Move functions from C to Lisp. Make non-blocking method calls
73 the default. Implement further D-Bus standard interfaces.
74
75 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
76 (QCdbus_request_name_allow_replacement)
77 (QCdbus_request_name_replace_existing)
78 (QCdbus_request_name_do_not_queue)
79 (QCdbus_request_name_reply_primary_owner)
80 (QCdbus_request_name_reply_in_queue)
81 (QCdbus_request_name_reply_exists)
82 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
83 (QCdbus_registered_serial, QCdbus_registered_method)
84 (QCdbus_registered_signal): New Lisp objects.
85 (XD_DEBUG_MESSAGE): Use sizeof.
86 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
87 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
88 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
89 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
90 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
91 (xd_signature, xd_append_arg): Allow float for integer types.
92 (xd_get_connection_references): New function.
93 (xd_get_connection_address): Rename from xd_initialize. Return
94 cached address.
95 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
96 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
97 level.
98 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
99 Return number of recounts.
100 (Fdbus_get_unique_name): Make stronger parameter check.
101 (Fdbus_message_internal): New defun.
102 (Fdbus_call_method, Fdbus_call_method_asynchronously)
103 (Fdbus_method_return_internal, Fdbus_method_error_internal)
104 (Fdbus_send_signal, Fdbus_register_service)
105 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
106 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
107 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
108 (Vdbus_compiled_version, Vdbus_runtime_version)
109 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
110 (Vdbus_message_type_method_return, Vdbus_message_type_error)
111 (Vdbus_message_type_signal): New defvars.
112 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
113 docstring.
114
52828e02
PE
1152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
116
da05bc4c
PE
117 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
118 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
119 Do not assume ptrdiff_t is the same width as 'int'.
120
52828e02
PE
121 * alloc.c: Handle unusual debugging option combinations.
122 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
123 since the two debugging options are incompatible.
124 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
125 is defined.
126 (mem_init, mem_insert, mem_insert_fixup):
127 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
128 (NEED_MEM_INSERT): Remove; no longer needed.
129
f01769f9
LL
1302012-04-22 Leo Liu <sdl.web@gmail.com>
131
132 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
133
5790543d
PE
1342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
135
136 * sysdep.c [__FreeBSD__]: Minor cleanups.
137 (list_system_processes, system_process_attributes) [__FreeBSD__]:
138 Use Emacs indenting style more consistently. Avoid some casts.
139 Use 'double' consistently rather than mixing 'float' and 'double'.
140
b91b7e4d
EW
1412012-04-21 Eduard Wiebe <usenet@pusto.de>
142
143 * sysdep.c (list_system_processes, system_process_attributes): Add
144 implementation for FreeBSD (Bug#5243).
145
6114eb15
AS
1462012-04-21 Andreas Schwab <schwab@linux-m68k.org>
147
148 * lisp.mk (lisp): Update.
149
2f38dff7
PE
1502012-04-20 Paul Eggert <eggert@cs.ucla.edu>
151
152 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
153 It is never used otherwise.
154
4ae29f89
SM
1552012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
156
157 * print.c (print_preprocess): Only check print_depth if print-circle
158 is nil.
159 (print_object): Check for cycles even when print-circle is nil and
160 print-gensym is t, but only check print_depth if print-circle is nil.
161
f30d612a
CY
1622012-04-20 Chong Yidong <cyd@gnu.org>
163
164 * process.c (wait_reading_process_output): If EIO occurs on a pty,
165 set the status to "failed" and ensure that sentinel is run.
166
c07a4c0b 1672012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
168
169 * process.c (Fset_process_inherit_coding_system_flag)
170 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 171 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 172
c07a4c0b 1732012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
174
175 * xdisp.c (string_buffer_position_lim): Limit starting position to
176 BEGV.
177 (set_cursor_from_row): If called for a mode-line or header-line
178 row, return zero immediately.
179 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
180 farther than the first row after the header line, if any.
181 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
182 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
183
c07a4c0b 1842012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 185
4ae29f89
SM
186 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
187 (bug#11238).
ad3a2b41 188
c07a4c0b 1892012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 1902012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
191
192 configure: new option --enable-gcc-warnings (Bug#11207)
193 * Makefile.in (C_WARNINGS_SWITCH): Remove.
194 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
195 (ALL_CFLAGS): Use new macros rather than old.
196 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
197 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
198 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
199 -Wunused-result, -Wunused-variable. This should go away once
200 the Emacs and Gnulib regex code is merged.
201 (xmalloc, xrealloc): Now static.
202
aba027e8
PE
2032012-04-17 Paul Eggert <eggert@cs.ucla.edu>
204
205 * dired.c (Fsystem_groups): Remove unused local.
206
e5a36063
GM
2072012-04-17 Glenn Morris <rgm@gnu.org>
208
209 * dired.c (Fsystem_users): Doc fix.
210
316411f0
DA
2112012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
212
213 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
214 (syms_of_dired): Add them.
215
9426aba4
PE
2162012-04-16 Paul Eggert <eggert@cs.ucla.edu>
217
b62a57be
PE
218 Fix minor alloc.c problems found by static checking.
219 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
220 New extern decls, to avoid calling undeclared functions.
221 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
222 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
223 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
224 (NEED_MEM_INSERT): New macro.
225 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 226 Remove one incorrect comment and fix another.
b62a57be 227
3539f31f
PE
228 Fix minor ralloc.c problems found by static checking.
229 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
230 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
231 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
232 (r_alloc_sbrk): Now static.
233
a041960a
PE
234 Improve ralloc.c interface checking.
235 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
236 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
237 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
238 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
239 [REL_ALLOC]: ... to here, to check interface.
240 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
241 Remove decls. This fixes an "It stinks!".
242
9426aba4
PE
243 * alloc.c (which_symbols): Fix alignment issue / type clash.
244
d55c12ed
AS
2452012-04-15 Andreas Schwab <schwab@linux-m68k.org>
246
247 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
248 (struct Lisp_Misc_Any): Likewise.
249 (struct Lisp_Free): Likewise.
250 * alloc.c (union aligned_Lisp_Symbol): Define.
251 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
252 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
253 (union aligned_Lisp_Misc): Define.
254 (MARKER_BLOCK_SIZE, struct marker_block): Use union
255 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 256 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 257
b948ce8b
PE
2582012-04-14 Paul Eggert <eggert@cs.ucla.edu>
259
260 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
261 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
262 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
263 * s/netbsd.h, s/sol2-6.h:
264 Remove definition of GC_MARK_STACK, since the default now works.
265 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
266 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
267 no longer the default.
268 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
269
35dc09a1 2702012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 271
35dc09a1
GM
272 * lread.c (lisp_file_lexically_bound_p):
273 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 274
35dc09a1
GM
2752012-04-14 Eli Zaretskii <eliz@gnu.org>
276
277 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
278 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
279
2802012-04-14 Jan Djärv <jan.h.d@swipnet.se>
281
282 * nsterm.m (constrainFrameRect): Always constrain when there is only
283 one screen (Bug#10962).
284
bcd86815
KB
2852012-04-13 Ken Brown <kbrown@cornell.edu>
286
287 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
288
c25df26e
RT
2892012-04-13 Reuben Thomas <rrt@sc3d.org>
290
291 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
292
0fc59f1e
DC
2932012-04-11 Daniel Colascione <dancol@dancol.org>
294
295 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
296 against is gone. It's better to use vfork now so that when Cygwin
297 gains a new, working vfork, we use it automatically (bug#10398).
298
de8c03dc
SM
2992012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
300
301 * window.c (save_window_save): Obey window-point-insertion-type.
302
2f097256
GM
3032012-04-11 Glenn Morris <rgm@gnu.org>
304
305 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
306
453b951e
SM
3072012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
308
309 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
310
75f1671a 3112012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
312
313 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
314 (force_quit_count): New var.
315 (handle_interrupt): Use it.
316
2a8ce227
JB
3172012-04-10 Juanma Barranquero <lekktu@gmail.com>
318
319 * w32.c (w32_delayed_load): Record the full path of the library
320 being loaded (bug#10424).
321
935396c0
GM
3222012-04-09 Glenn Morris <rgm@gnu.org>
323
05920a43
GM
324 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
325 not just in the obarray, before snarfing them. (Bug#11036)
326
935396c0
GM
327 * Makefile.in ($(leimdir)/leim-list.el):
328 Pass EMACS rather than BUILT_EMACS.
329
a18ecafa
TZ
3302012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
331
332 * process.c (make_process):
333 * process.h: Add integer `gnutls_handshakes_tried' member to
334 process struct.
335
6bbef4e5
JC
336 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
337 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
338
339 * gnutls.c (gnutls_log_function2i): Convenience log function.
340 (emacs_gnutls_read): Use new log functions,
341 `gnutls_handshakes_tried' process member, and
342 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
343 attempts per process (connection).
344
b4d3bc10
CY
3452012-04-09 Chong Yidong <cyd@gnu.org>
346
347 * eval.c (Fuser_variable_p, user_variable_p_eh)
348 (lisp_indirect_variable): Functions deleted.
349 (Fdefvar): Caller changed.
350
351 * callint.c (Finteractive, Fcall_interactively):
352 * minibuf.c (Fread_variable): Callers changed.
353
70f4d973
EZ
3542012-04-09 Eli Zaretskii <eliz@gnu.org>
355
356 * xdisp.c (set_cursor_from_row): If the display string appears in
357 the buffer at position that is closer to point than the position
358 after the display string, display the cursor on the first glyph of
359 the display string. Fixes cursor display when a 'display' text
360 property immediately follows invisible text. (Bug#11094)
361
cb3c2e3e
PE
3622012-04-09 Paul Eggert <eggert@cs.ucla.edu>
363
364 composite.c: use 'double' consistently
365 * composite.c (get_composition_id): Use 'double' consistently
366 instead of converting 'float' to 'double' and vice versa; this is
367 easier to understand and avoids a GCC warning.
368
fd06db5d
GM
3692012-04-09 Glenn Morris <rgm@gnu.org>
370
50fe702a
GM
371 * Makefile.in: Generate leim-list with bootstrap-emacs, in
372 preparation for dumping it with emacs. (Bug#4789)
373 (leimdir): New variable.
374 ($(leimdir)/leim-list.el): New rule.
375 (emacs$(EXEEXT)): Depend on leim-list.el.
376
fd06db5d
GM
377 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
378 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
379 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
380
55c131ee
AS
3812012-04-08 Andreas Schwab <schwab@linux-m68k.org>
382
383 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
384 proper alignment.
385
9209588f
JB
3862012-04-07 Juanma Barranquero <lekktu@gmail.com>
387
388 * xml.c (init_libxml2_functions) [WINDOWSNT]:
389 Remove unused local variable.
390
e3fb2efb
PE
3912012-04-07 Paul Eggert <eggert@cs.ucla.edu>
392
393 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
394 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
395 (mark_memory): Mark Lisp_Objects only if pointers might hide in
396 objects, as mark_maybe_pointer will catch them otherwise.
397 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
398 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
399
b5385551
PE
4002012-04-07 Paul Eggert <eggert@cs.ucla.edu>
401
402 Fix typo that broke non-Windows builds.
403 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
404
9078ead6
EZ
4052012-04-07 Eli Zaretskii <eliz@gnu.org>
406
407 Support building on MS-Windows with libxml2.
408
409 * makefile.w32-in (OBJ2): Add xml.$(O).
410 (GLOBAL_SOURCES): Add xml.c.
411 ($(BLD)/xml.$(O)): New dependency list.
412
413 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
414 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
415 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
416 [!WINDOWSNT]: New macros.
417 (init_libxml2_functions, libxml2_loaded_p): New functions.
418 (parse_region): Call fn_xmlCheckVersion instead of using the macro
419 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
420 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
421 Calls xmlCleanupParser only if libxml2 was loaded (or statically
422 linked in).
6bbef4e5
JC
423 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
424 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
425 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
426
427 * emacs.c: Don't include libxml/parser.h.
428 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
429 xmlCleanupParser directly.
430
431 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
432
3811fdf3
EZ
4332012-04-07 Eli Zaretskii <eliz@gnu.org>
434
435 * indent.c (Fvertical_motion): If there is a display string at
436 point, use it.vpos to compute how many lines to backtrack after
437 move_it_to point. (Bug#11133)
438
2f8e16b2
EZ
4392012-04-06 Eli Zaretskii <eliz@gnu.org>
440
441 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
442 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
443 about subtle differences between FETCH_CHAR* and STRING_CHAR*
444 macros related to unification of CJK characters. For the details,
445 see the discussion following the message here:
446 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
447
3d439cd1
CY
4482012-04-04 Chong Yidong <cyd@gnu.org>
449
450 * keyboard.c (Vdelayed_warnings_list): Doc fix.
451
8bc53d00
EZ
4522012-04-01 Eli Zaretskii <eliz@gnu.org>
453
454 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
455 instead of alloca. (Bug#11138)
456
3b0512a3
AS
4572012-04-01 Andreas Schwab <schwab@linux-m68k.org>
458
459 * w32menu.c (is_simple_dialog): Properly check lisp types.
460 (Bug#11141)
461
8427ddd2
EZ
4622012-03-31 Eli Zaretskii <eliz@gnu.org>
463
979022ef
EZ
464 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
465 position we get to after a call to move_it_to fails the
466 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
467 only if we wind up in a string from display property. (Bug#11063)
468
a6b1c7cc
EZ
469 * window.c (Fdelete_other_windows_internal): Invalidate the row
470 and column information about mouse highlight, so that redisplay
471 restores it after reallocating the glyph matrices. (Bug#7464)
472
8427ddd2
EZ
473 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
474 string comes from a `display' text property, use the buffer
475 position of that property as if we actually saw that position in
476 the row's glyphs.
697ba24b
EZ
477 (move_it_by_lines): Remove the assertion that
478 "it->current_x == 0 && it->hpos == 0" which can be legitimately
479 violated when there's a before-string at the beginning of a line.
480 (Bug#11063)
8427ddd2 481
65a0a738
EZ
4822012-03-30 Eli Zaretskii <eliz@gnu.org>
483
484 * xdisp.c (append_space_for_newline): If the default face was
485 remapped, use the remapped face for the appended newline.
486 (extend_face_to_end_of_line): Use the remapped default face for
487 extending the face to the end of the line.
488 (display_line): Call extend_face_to_end_of_line when the default
489 face was remapped. (Bug#11068)
490
581355cc
EZ
4912012-03-29 Eli Zaretskii <eliz@gnu.org>
492
493 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
494
e8fc049f
SM
4952012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
496
497 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
498
4fb9a543
GM
4992012-03-27 Glenn Morris <rgm@gnu.org>
500
501 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
502 Doc fixes.
503
679910f1
KH
5042012-03-26 Kenichi Handa <handa@m17n.org>
505
506 * dispextern.h (struct glyph): Fix previous change. Change the
507 bit length of glyphless.ch to 25 (Bug#11082).
508
90d49b7f
CY
5092012-03-26 Chong Yidong <cyd@gnu.org>
510
511 * keyboard.c (Vselection_inhibit_update_commands): New variable.
512 (command_loop_1): Use it; inhibit selection update for
513 handle-select-window too (Bug#8996).
514
f514f6f0
FP
5152012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
516
e8fc049f 517 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 518
bf43fa51
KH
5192012-03-25 Kenichi Handa <handa@m17n.org>
520
521 * dispextern.h (struct glyph): Change the bit length of
522 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
523
8a0c01dd
EZ
5242012-03-24 Eli Zaretskii <eliz@gnu.org>
525
526 * s/ms-w32.h (tzname): Include time.h before redirecting to
527 _tzname. Fixes the MSVC build. (Bug#9960)
528
7d1c3a76
AS
5292012-03-24 Andreas Schwab <schwab@linux-m68k.org>
530
8ed79523
AS
531 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
532 characters.
533
7d1c3a76
AS
534 * xterm.c (XTread_socket): Only modify handling_signal if
535 !SYNC_INPUT. (Bug#11080)
536
e99a9b8b
EZ
5372012-03-23 Eli Zaretskii <eliz@gnu.org>
538
539 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
540 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
541 when fetching a multibyte character consumes more bytes than
542 CHAR_BYTES returns, due to unification of CJK characters in
543 string_char. (Bug#11073)
544
5063c0e1
TN
5452012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
546
547 * process.c (wait_reading_process_output): Handle pty disconnect
548 by refraining from sending oneself a SIGCHLD (bug#10933).
549
9f851fbd
CY
5502012-03-22 Chong Yidong <cyd@gnu.org>
551
552 * dispextern.h (struct it): New member string_from_prefix_prop_p.
553
5063c0e1 554 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
555 Mark string as coming from a prefix property.
556 (handle_face_prop): Use default face for prefix strings (Bug#4281).
557 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
558
fb5b8aca
CY
5592012-03-21 Chong Yidong <cyd@gnu.org>
560
561 * xfaces.c (Vface_remapping_alist): Doc fix.
562
62356a1b
EZ
5632012-03-20 Eli Zaretskii <eliz@gnu.org>
564
565 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
566 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
567 Doc fixes.
62356a1b 568
025de85b
CY
5692012-03-20 Chong Yidong <cyd@gnu.org>
570
571 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
572 to reflect default non-nil value of redisplay-dont-pause.
573
4827f94e
KH
5742012-03-19 Kenichi Handa <handa@m17n.org>
575
576 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
577 it fit in a valid range (Bug#11003).
578
e50a24a2
EZ
5792012-03-18 Eli Zaretskii <eliz@gnu.org>
580
581 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
582 that is not from display property, accept the row as a "cursor
583 row" if one of the string's character has a non-nil `cursor'
584 property. Fixes cursor positioning when there are newlines in
585 overlay strings, e.g. in icomplete.el. (Bug#11035)
586
9af5ed87
PE
5872012-03-12 Paul Eggert <eggert@cs.ucla.edu>
588
589 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
590
d1f55f16
CY
5912012-03-12 Chong Yidong <cyd@gnu.org>
592
593 * eval.c (inhibit_lisp_code): Rename from
594 inhibit_window_configuration_change_hook; move from window.c.
595
596 * xfns.c (unwind_create_frame_1, Fx_create_frame):
597 * window.c (run_window_configuration_change_hook)
598 (syms_of_window): Callers changed.
599
66c5eebd
CY
6002012-03-11 Chong Yidong <cyd@gnu.org>
601
413df973
CY
602 * keymap.c (Fkey_description): Doc fix (Bug#9700).
603
66c5eebd
CY
604 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
605
1de11f56
CY
6062012-03-10 Chong Yidong <cyd@gnu.org>
607
608 * frame.c (other_visible_frames): Don't assume the selected frame
609 is visible (Bug#10955).
610
cae07000
SM
6112012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
612
613 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
614
89c94350
JD
6152012-03-08 Jan Djärv <jan.h.d@swipnet.se>
616
617 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
618 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
619 zero (Bug#10954).
620
999dd333
GM
6212012-03-03 Glenn Morris <rgm@gnu.org>
622
01a6dcc8 623 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 624
de0100f2
EZ
6252012-03-02 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
628 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
629 (redisplay_window, next_element_from_string): Fix typos in
630 comments.
3e441275
EZ
631 (redisplay_window): Pass to move_it_vertically the margin in
632 pixels, not in screen lines.
de0100f2 633
96a72ee9
GM
6342012-03-02 Glenn Morris <rgm@gnu.org>
635
636 * buffer.c (buffer-list-update-hook): Doc fix.
637
312508d7
EZ
6382012-02-29 Eli Zaretskii <eliz@gnu.org>
639
640 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
641 push_it before setting up the iterator for the first overlay
642 string, even if we have an empty string loaded.
643 (next_overlay_string): If there's an empty string on the iterator
644 stack, pop the stack. (Bug#10903)
645
27f3c637
PE
6462012-02-25 Paul Eggert <eggert@cs.ucla.edu>
647
648 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
649 Suggested by Stefan Monnier in
650 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
651 * alloc.c (widen_to_Lisp_Object): New static function.
652 (mark_memory): Also mark Lisp_Objects by fetching pointer words
653 and widening them to Lisp_Objects. This would work even if
654 USE_LSB_TAG is defined and wide integers are used, which might
655 happen in a future version of Emacs.
656
3c9dfce6
CY
6572012-02-25 Chong Yidong <cyd@gnu.org>
658
fa74b241
CY
659 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
660 Doc fix.
661
3c9dfce6
CY
662 * xselect.c (Fx_selection_exists_p): Doc fix.
663 (x_clipboard_manager_save_all): Print an informative message
664 before saving to clipboard manager.
665
9486df08
CY
6662012-02-24 Chong Yidong <cyd@gnu.org>
667
668 * keyboard.c (process_special_events): Handle all X selection
669 requests in kbd_buffer, not just the next one (Bug#8869).
670
f01d3321
CY
6712012-02-23 Chong Yidong <cyd@gnu.org>
672
673 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
674 call when setting menu-bar-lines and tool-bar-lines parameters.
675 (unwind_create_frame_1): New helper function.
676
677 * window.c (inhibit_window_configuration_change_hook): New var.
678 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 679 (syms_of_window): Initialize it.
f01d3321 680
86b847b6
CY
6812012-02-22 Chong Yidong <cyd@gnu.org>
682
683 * xterm.c (x_draw_image_relief): Add missing type check for
684 Vtool_bar_button_margin (Bug#10743).
685
a59225b1
CY
6862012-02-21 Chong Yidong <cyd@gnu.org>
687
688 * fileio.c (Vfile_name_handler_alist): Doc fix.
689
690 * buffer.c (Fget_file_buffer): Protect against invalid file
691 handler return value.
692
310f5bd4
PE
6932012-02-20 Paul Eggert <eggert@cs.ucla.edu>
694
cb3a28cc
PE
695 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
696 when computing $valmask.
697
310f5bd4
PE
698 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
699 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
700 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
701 It's useless in that case, and it can cause problems on hosts
702 that allocate halves of EMACS_INT values separately.
703 Reported by Dan Horák. Diagnosed by Andreas Schwab in
704 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
705 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
706 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
707 it avoids undefined behavior on hosts where shifting right by more
708 than the word width has undefined behavior.
709
2375c96a
CY
7102012-02-19 Chong Yidong <cyd@gnu.org>
711
712 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
713 (Funhandled_file_name_directory, Ffile_name_as_directory)
714 (Fdirectory_file_name, Fexpand_file_name)
715 (Fsubstitute_in_file_name): Protect against invalid file handler
716 return values (Bug#10845).
717
3eb49e71
EZ
7182012-02-18 Eli Zaretskii <eliz@gnu.org>
719
720 * .gdbinit (pitx): Fix incorrect references to fields of the
721 iterator stack.
722
7b926f3f
CY
7232012-02-17 Chong Yidong <cyd@gnu.org>
724
725 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
726
11273115
PE
7272012-02-15 Paul Eggert <eggert@cs.ucla.edu>
728
729 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
730 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
731
c3a70e2b
CY
7322012-02-15 Chong Yidong <cyd@gnu.org>
733
734 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
735 marked as special. Also, starting docstrings with * is obsolete.
736
0ca43699
AS
7372012-02-13 Andreas Schwab <schwab@linux-m68k.org>
738
739 * gnutls.c (emacs_gnutls_write): Fix last change.
740
2e8f3c56
LI
7412012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
742
743 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
744 send_process.
745
af70074f
SM
7462012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
747
748 * keymap.c (Fsingle_key_description): Handle char ranges.
749
95986d52
CY
7502012-02-12 Chong Yidong <cyd@gnu.org>
751
afd83bd1
CY
752 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
753 as that creates a dangerous corner case.
754
95986d52
CY
755 * window.c (Fdelete_window_internal): Invalidate the mouse
756 highlight (Bug#9904).
757
bd7da63e
GM
7582012-02-12 Glenn Morris <rgm@gnu.org>
759
760 * xselect.c (Fx_own_selection_internal)
761 (Fx_get_selection_internal, Fx_disown_selection_internal)
762 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
763 * nsselect.m (Fx_own_selection_internal)
764 (Fx_disown_selection_internal, Fx_selection_exists_p)
765 (Fx_selection_owner_p, Fx_get_selection_internal):
766 Sync docs and argument specs with the xselect.c versions.
767
77abcbc2
LI
7682012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
769
770 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
771
90b671e2
EZ
7722012-02-11 Eli Zaretskii <eliz@gnu.org>
773
1c0ca0b7
EZ
774 * w32select.c (Fx_selection_exists_p): Sync doc string and
775 argument list with xselect.c. (Bug#10783)
776
777 * w16select.c (Fx_selection_exists_p): Sync doc string and
778 argument list with xselect.c. (Bug#10783)
90b671e2 779
49241268
GM
7802012-02-10 Glenn Morris <rgm@gnu.org>
781
782 * fns.c (Fsecure_hash): Doc fix.
783
f998bbe7 7842012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
785
786 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
787
0992bd9c
CY
7882012-02-07 Chong Yidong <cyd@gnu.org>
789
790 * buffer.c (Fbuffer_local_variables)
791 (buffer_lisp_local_variables): Handle unbound vars correctly;
792 don't let Qunbound leak into Lisp.
793
af008560
GM
7942012-02-07 Glenn Morris <rgm@gnu.org>
795
dd605cc4
GM
796 * image.c (Fimagemagick_types): Doc fix.
797
af008560
GM
798 * image.c (imagemagick-render-type): Change it from a lisp object
799 to an integer. Move the doc here from the lisp manual.
800 Treat all values not equal to 0 the same.
801
1449fa1d
CY
8022012-02-06 Chong Yidong <cyd@gnu.org>
803
804 * doc.c (store_function_docstring): Avoid applying docstring of
805 alias to base function (Bug#2603).
806
3723ec07
AS
8072012-02-04 Andreas Schwab <schwab@linux-m68k.org>
808
809 * .gdbinit (pp1, pv1): Remove redundant defines.
810 (pr): Use pp.
811
79c1cc1e
CY
8122012-02-04 Chong Yidong <cyd@gnu.org>
813
814 * nsterm.m: Declare a global (Bug#10694).
815
d7f29f8e
EZ
8162012-02-04 Eli Zaretskii <eliz@gnu.org>
817
cae07000
SM
818 * w32.c (get_emacs_configuration_options):
819 Include --enable-checking, if specified, in the return value.
d7f29f8e 820
3b95a6f9
MR
8212012-02-04 Martin Rudalics <rudalics@gmx.at>
822
823 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
824 after rounding frame sizes. (Bug#9723)
825
d6fa96a6
EZ
8262012-02-04 Eli Zaretskii <eliz@gnu.org>
827
828 * keyboard.c (adjust_point_for_property): Don't position point
829 before BEGV. (Bug#10696)
830
df0b2940
PE
8312012-02-03 Paul Eggert <eggert@cs.ucla.edu>
832
833 Handle overflow when computing char display width (Bug#9496).
834 * character.c (char_width): Return EMACS_INT, not int.
835 (char_width, c_string_width): Check for overflow when
836 computing the width; this is possible now that individual
837 characters can have unbounded width. Problem introduced
838 by merge from Emacs 23 on 2012-01-19.
839
6bee44d6
MA
8402012-02-02 Michael Albinus <michael.albinus@gmx.de>
841
842 * dbusbind.c (Fdbus_register_method): Mention the return value
843 :ignore in the docstring.
844
44f92739
GM
8452012-02-02 Glenn Morris <rgm@gnu.org>
846
1b9f60cc
GM
847 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
848
44f92739
GM
849 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
850 Unconditionally set to t. (Bug#10673)
851 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
852 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
853 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
854
c5d3843c
KH
8552012-02-02 Kenichi Handa <handa@m17n.org>
856
857 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
858 0, do not call append_composite_glyph.
859
159462d4 8602012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
861
862 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
863 NULL (Bug#6988).
864 (x_produce_glyphs): If the component of a composition is a null
865 string, set it->pixel_width to 1 to avoid zero-width glyph.
866
78cef877
EZ
8672012-02-01 Eli Zaretskii <eliz@gnu.org>
868
869 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
870 first 2 arguments are identical. This makes inserting large
871 output from a subprocess an order of magnitude faster on
872 MS-Windows, where all sbrk'ed memory is always contiguous.
873
97897668
GM
8742012-01-31 Glenn Morris <rgm@gnu.org>
875
876 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 877 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
878 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
879
31fd3586
GM
8802012-01-29 Glenn Morris <rgm@gnu.org>
881
882 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
883
0e24a8b2
CY
8842012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
885
886 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
887
cc0adcb0
CY
8882012-01-28 Chong Yidong <cyd@gnu.org>
889
890 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
891
acc28cb9
CY
8922012-01-26 Chong Yidong <cyd@gnu.org>
893
9c69cfb7
CY
894 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
895
acc28cb9
CY
896 * search.c (Fsearch_forward, Fsearch_backward): Document negative
897 repeat counts (Bug#10507).
898
48da7392
GM
8992012-01-26 Glenn Morris <rgm@gnu.org>
900
901 * lread.c (syms_of_lread): Doc fix.
902
14af5f7f
CY
9032012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
904
905 * coding.c (encode_designation_at_bol): Change return value to
906 EMACS_INT.
907
0b21c100
CY
9082012-01-25 Chong Yidong <cyd@gnu.org>
909
910 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
911
3c2907f7
CY
9122012-01-21 Chong Yidong <cyd@gnu.org>
913
914 * floatfns.c (Fcopysign): Make the second argument non-optional,
915 since nil is not allowed anyway.
916
959ad23f
AS
9172012-01-21 Andreas Schwab <schwab@linux-m68k.org>
918
919 * process.c (read_process_output): Use p instead of XPROCESS (proc).
920 (send_process): Likewise.
921
34a02f46
MR
9222012-01-19 Martin Rudalics <rudalics@gmx.at>
923
924 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
925 (Vwindow_persistent_parameters): Do not use Qstate.
926 Rewrite doc-strings.
34a02f46 927
1259009a 9282012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
929
930 * character.c (char_width): New function.
70d4fdf6
GM
931 (Fchar_width, c_string_width, lisp_string_width):
932 Use char_width (Bug#9496).
25ed9e61 933
6a6ee00d
MR
9342012-01-16 Martin Rudalics <rudalics@gmx.at>
935
936 * window.c (Vwindow_persistent_parameters): New variable.
937 (Fset_window_configuration, save_window_save): Handle persistent
938 window parameters.
939
c85efaf7
EZ
9402012-01-14 Eli Zaretskii <eliz@gnu.org>
941
942 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
943 thrashing the stack of the thread. (Bug#9087)
944
5944709e
PE
9452012-01-12 Paul Eggert <eggert@cs.ucla.edu>
946
947 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
948
e71f5d99
EZ
9492012-01-11 Eli Zaretskii <eliz@gnu.org>
950
951 * xdisp.c (rows_from_pos_range): Handle the case where the
952 highlight ends on a newline. (Bug#10464)
953 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
954 he end column for display of highlight that ends on a newline
955 before a R2L line.
956
ce316182
GM
9572012-01-11 Glenn Morris <rgm@gnu.org>
958
959 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
960 from load-path also when installation-directory is nil. (Bug#10208)
961
5b43da69
GM
9622012-01-10 Glenn Morris <rgm@gnu.org>
963
74cc8ff9
GM
964 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
965
7d8d6e4e
GM
966 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
967 Update template values to be closer to their typical values these days.
5b43da69 968
a0db8d43
EZ
9692012-01-09 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (rows_from_pos_range): Accept additional argument
972 DISP_STRING, and accept any glyph in a row whose object is that
973 string as eligible for mouse highlight. Fixes mouse highlight of
974 display strings from overlays. (Bug#10464)
975
9a0115ab 9762012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 977
b9110d6a 978 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
979 * fileio.c (auto_saving_dir_umask): New static var.
980 (Fmake_directory_internal): Use it.
981 (do_auto_save_make_dir): Set it, instead of invoking chmod after
982 creating the directory. The old code temporarily assigns
983 too-generous permissions to the directory.
984 (do_auto_save_eh): Clear it.
b9110d6a 985 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
986 that the var is always cleared.
987
6c1bd3f3
EZ
9882012-01-07 Eli Zaretskii <eliz@gnu.org>
989
990 * search.c (scan_buffer): Pass character positions to
991 know_region_cache, not byte positions. (Bug#6540)
992
069d2b50
L
9932012-01-07 LynX <_LynX@bk.ru> (tiny change)
994
995 * w32.c (sys_rename): Report EXDEV when rename of a directory
996 fails because the target is on another logical disk. (Bug#10284)
997
75bf0d33
DB
9982012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
999
1000 * xterm.c (x_embed_request_focus): New function.
1001
1002 * xterm.h: Add prototype.
1003
1004 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1005
1c6e5a32
GM
10062012-01-05 Glenn Morris <rgm@gnu.org>
1007
1008 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1009
651e947e
EZ
10102012-01-01 Eli Zaretskii <eliz@gnu.org>
1011
1012 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1013 Load gnutls_transport_set_lowat only if GnuTLS version is below
1014 2.11.1.
1015 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1016 GnuTLS versions below 2.11.1.
1017
3778cdd8
AL
10182011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1019
1020 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1021 to the doc string advising against its use for altering the way
1022 windows are scrolled.
1023
0e5317f7
KH
10242011-12-28 Kenichi Handa <handa@m17n.org>
1025
1026 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1027 coding-system ASCII compatible only when it does not produce BOM
1028 on encoding (Bug#10383).
1029
93d5ca1f
JD
10302011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1031
1032 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1033 can scroll.
1034 (create_and_show_popup_menu): Always use menu_position_func for
1035 Gtk3 (Bug#10361).
1036
ca22b785
AS
10372011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1038
1039 * callint.c (Fcall_interactively): Don't truncate prompt string.
1040
d048e1e6
EZ
10412011-12-23 Eli Zaretskii <eliz@gnu.org>
1042
1043 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1044 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1045 resumed from there (after widening). (Bug#10360)
d048e1e6 1046
5ccaba1f
JD
10472011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1048
1049 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1050
204ee57f
JD
10512011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1052
b81d40f0
JB
1053 * nsterm.m (x_free_frame_resources):
1054 Release f->output_data.ns->miniimage.
204ee57f
JD
1055 (ns_index_color): Fix indentation. Do not retain
1056 color_table->colors[i].
1057
1058 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1059 before returning.
1060
1061 * nsfns.m (x_set_background_color): Assign return value from
1062 ns_index_color to face-background instead of NSColor*.
1063 (ns_implicitly_set_icon_type): Fix indentation.
1064 Change assignment in for loop to comparison.
1065
1066 * emacs.c (ns_pool): New variable.
1067 (main): Assign ns_pool.
1068 (Fkill_emacs): Call ns_release_autorelease_pool.
1069
1070 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1071 autorelease fdesc, release fdAttrs and tdict.
1072 (ns_get_covering_families): Release charset.
1073 (ns_findfonts): Release NSFontDescriptor created with new.
1074 (ns_uni_to_glyphs): Fix indentation.
1075 (setString): Release attrStr before assigning new value.
1076
c803b2b7
JD
10772011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1078
678f4426
JD
1079 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1080 and NS_IMPL_COCOA.
1081 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1082 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1083
cd394be1 10842011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1085
5fecd5fc
JD
1086 * nsterm.m (ns_term_init): Subscribe for notifications
1087 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1088 to method trackingNotification in EmacsMenu.
1089
1090 * nsmenu.m (trackingMenu): New variable.
3771cb17 1091 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1092 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1093 from Aquamacs (Bug#7030).
678f4426
JD
1094
10952011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1096
c803b2b7
JD
1097 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1098 (symbol_to_nsstring): Fix indentation.
1099 (ns_symbol_to_pb): New function.
cae07000
SM
1100 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1101 (Fns_rotate_cut_buffers_internal): Remove.
1102 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1103 Fns_store_cut_buffer_internal.
1104 (ns_get_foreign_selection, Fx_own_selection_internal)
1105 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1106 (Fns_get_selection_internal, Fns_store_selection_internal):
1107 Use ns_symbol_to_pb and check if return value is nil.
1108 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1109 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1110 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1111 renamed to Sns_store_selection_internal.
1112 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1113 and remove this function.
1114 (ns_handle_selection_clear): Remove, never used.
1115 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1116 here.
1117
e1b01a3a
KB
11182011-12-17 Ken Brown <kbrown@cornell.edu>
1119
1120 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1121 GID is unknown (Bug#10257).
1122
2adb6e85
PE
11232011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1126 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1127 which caused a build failure on GNU/Linux IA-64. This problem was
1128 introduced by my 2011-10-07 patch.
1129
d1d7b339
JL
11302011-12-15 Juri Linkov <juri@jurta.org>
1131
1132 * image.c (imagemagick_error): New function. (Bug#10112)
1133 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1134 Use `imagemagick_error' where ImageMagick functions return
1135 `MagickFalse'.
1136 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1137 proper order.
1138
100d5755
KH
11392011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1140
1141 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1142 fill background (Bug#8992).
1143
454592a6
MR
11442011-12-13 Martin Rudalics <rudalics@gmx.at>
1145
1146 * window.c (Vwindow_combination_resize)
1147 (Vwindow_combination_limit): Use t instead of non-nil in
1148 doc-strings.
61d4b438
MR
1149 (Vrecenter_redisplay): Add first sentence of doc-string on
1150 separate line.
53524d93 1151 (Frecenter): Fix doc-string typo.
454592a6 1152
3633e3aa
KH
11532011-12-11 Kenichi Handa <handa@m17n.org>
1154
1155 * coding.c (Funencodable_char_position): Pay attention to the
1156 buffer text relocation (Bug#9389).
1157
7b9d523a
JD
11582011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1159
1160 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1161 gtk_init (Bug#10100).
1162
b73189c6
EZ
11632011-12-10 Eli Zaretskii <eliz@gnu.org>
1164
1165 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1166 IT->string is nil. (Bug#10263)
1167
f7dfe5d6
JD
11682011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1169
83faebb4
JD
1170 * nsterm.h (x_free_frame_resources): Declare.
1171
f7dfe5d6
JD
1172 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1173 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1174
1175 * nsterm.h (ns_get_defaults_value): Declare.
1176
1177 * nsterm.m (ns_default): Call ns_get_defaults_value.
1178
7cd4e72c
EZ
11792011-12-09 Eli Zaretskii <eliz@gnu.org>
1180
1181 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1182 (Bug#10170)
1183
b34d7317
YM
11842011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1185
1186 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1187 that where the value of an _OBJC_* symbol points to is in the .bss
1188 section (Bug#10240).
1189
76470ad1
KH
11902011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1191
1192 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1193 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1194
745fff94
KH
11952011-12-08 Kenichi Handa <handa@m17n.org>
1196
1197 * ftfont.c (get_adstyle_property): Fix previous change
1198 (Bug#10233).
1199
6e44397c
JB
12002011-12-07 Juanma Barranquero <lekktu@gmail.com>
1201
1202 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1203 dirs from the default value of EMACSLOADPATH (bug#10208).
1204
7efa6272
GM
12052011-12-07 Glenn Morris <rgm@gnu.org>
1206
1207 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1208 installation and source directories as well. (Bug#10208)
1209
f6fc4d87
CY
12102011-12-06 Chong Yidong <cyd@gnu.org>
1211
1212 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1213
2bf26180
GM
12142011-12-06 Glenn Morris <rgm@gnu.org>
1215
1216 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1217 as an error, not just -1. (Bug#10217)
1218
3a6ad4f0
CY
12192011-12-05 Chong Yidong <cyd@gnu.org>
1220
1221 * keyboard.c (process_special_events): New function.
1222 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1223
75a3b399
PE
12242011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 * coding.c (encode_designation_at_bol): Don't use uninitialized
1227 local variable (Bug#9318).
1228
c3c9e25e
KH
12292011-12-05 Kenichi Handa <handa@m17n.org>
1230
1231 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1232 return Qnil (Bug#8046, Bug#10193).
1233
5eb05ea3
KH
12342011-12-05 Kenichi Handa <handa@m17n.org>
1235
1236 * coding.c (encode_designation_at_bol): New args charbuf_end and
1237 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1238 (coding_set_source): Return how many bytes coding->source was
1239 relocated.
1240 (coding_set_destination): Return how many bytes
1241 coding->destination was relocated.
1242 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1243 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1244
12452011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1246
1247 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1248 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1249 macro (Bug#9318).
1250
12512011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1252
1253 The following changes are to fix Bug#9318.
1254
a79703f5 1255 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1256 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1257 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1258 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1259
7dbda6df
JB
12602011-12-05 Juanma Barranquero <lekktu@gmail.com>
1261
1262 * lisp.h (process_quit_flag): Fix external declaration.
1263
6d5eb5b0
SM
12642011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1265
1266 Don't macro-inline non-performance-critical code.
1267 * eval.c (process_quit_flag): New function.
1268 * lisp.h (QUIT): Use it.
1269
a0c3fad0
JD
12702011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1271
1272 * nsfns.m (get_geometry_from_preferences): New function.
1273 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1274
6c07aac2
AS
12752011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1276
1277 * emacs.c (Qkill_emacs): Define.
1278 (syms_of_emacs): Initialize it.
1279 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1280 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1281 (quit_throw_to_read_char): Add parameter `from_signal'.
1282 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1283 * lisp.h (QUIT): Call Fkill_emacs if requested.
1284
c052ead4
JD
12852011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1286
1287 * widget.c (update_wm_hints): Return if wmshell is null.
1288 (widget_update_wm_size_hints): New function.
1289
1290 * widget.h (widget_update_wm_size_hints): Declare.
1291
1292 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1293 widget_update_wm_size_hints (Bug#10104).
1294
9e49252b
EZ
12952011-12-03 Eli Zaretskii <eliz@gnu.org>
1296
1297 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1298 before a newline, prepare the bidi iterator for consuming the
1299 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1300 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1301
02b16839
JL
13022011-12-02 Juri Linkov <juri@jurta.org>
1303
1304 * search.c (Fword_search_regexp): New Lisp function created from
1305 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1306 (Fword_search_backward, Fword_search_forward)
1307 (Fword_search_backward_lax, Fword_search_forward_lax):
1308 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1309 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1310
0068070e
SM
13112011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1312
1313 * fileio.c (Finsert_file_contents): Move after-change-function call
1314 to before the "handled:" label, since all "goto handled" appear in
1315 cases where the *-change-functions have already been properly called
1316 (bug#10117).
1317
3360a3fc
AS
13182011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1321 waiting for input. (Bug#10169)
1322
73d6c093
EZ
13232011-11-30 Eli Zaretskii <eliz@gnu.org>
1324
1325 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1326 verifies glyph row's hash code--we have just reallocated the
1327 glyphs, so their contents can be complete garbage. (Bug#10164)
1328
febe6bea
JB
13292011-11-30 Juanma Barranquero <lekktu@gmail.com>
1330
1331 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1332
801a4313
EZ
13332011-11-30 Eli Zaretskii <eliz@gnu.org>
1334
1335 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1336 attributes are tested _before_ calling verify_row_hash, to protect
1337 against GCC re-ordering of the tests. (Bug#10164)
1338
2b56b87e
JD
13392011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1340
1341 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1342
1343 * xterm.c (handle_one_xevent): Only set async_visible and friends
1344 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1345 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1346 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1347
dbf31225
PE
13482011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1351 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1352 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1353 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1354 All uses changed to use GCPRO1 etc.
1355 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1356 Revert to old implementation (i.e., before 2011-03-11).
1357
1305621b
YM
13582011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1359
1360 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1361 of scroll runs so as to avoid assigning disabled bogus rows and
1362 unnecessary graphics copy operations.
1363
8c9afb46
EZ
13642011-11-27 Eli Zaretskii <eliz@gnu.org>
1365
1366 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1367 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1368 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1369 (malloc, free, realloc, calloc): Redirect to e_* only when
1370 compiling Emacs.
1371
1372 * lisp.h (GCTYPEBITS): Move before first use.
1373 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1374 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1375 this macro definition.
1376
1377 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1378 _MSC_VER.
1379
54e9e3bf
JD
13802011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1381
6d5eb5b0
SM
1382 * gtkutil.c (xg_create_frame_widgets):
1383 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1384 present with Gtk+ 2.0.
1385
83aca1cb
PE
13862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * fileio.c (Finsert_file_contents): Undo previous change; see
1389 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1390
5b76caa4
PE
13912011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 Rename locals to avoid shadowing.
1394 * fileio.c (Finsert_file_contents):
1395 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1396 * process.c (wait_reading_process_output):
1397 Rename inner 'proc' to 'p' to avoid shadowing.
1398 Indent for consistency with usual Emacs style.
1399
8c535114
EZ
14002011-11-25 Eli Zaretskii <eliz@gnu.org>
1401
1402 * xdisp.c (redisplay_window): If cursor row is not fully visible
1403 after recentering, and scroll-conservatively is set to a large
1404 number, scroll window by a few more lines to make the cursor fully
1405 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1406 (start_display): Don't move to the next line if the display should
1407 start at a newline that is part of a display vector or an overlay
1408 string. (Bug#10119)
8c535114 1409
fa4fdb5c
JL
14102011-11-24 Juri Linkov <juri@jurta.org>
1411
1412 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1413 after the `MagickPingImage' call. (Bug#10112)
1414
90ec88df
CY
14152011-11-23 Chong Yidong <cyd@gnu.org>
1416
1417 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1418
56e2e794
MR
14192011-11-23 Martin Rudalics <rudalics@gmx.at>
1420
1421 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1422 making another buffer current. (Bug#10114)
1423
b6e64c41
GM
14242011-11-23 Glenn Morris <rgm@gnu.org>
1425
1426 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1427
6b21de18
CY
14282011-11-23 Chong Yidong <cyd@gnu.org>
1429
1430 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1431 using it (Bug#5984).
1432
b12cd789
EZ
14332011-11-22 Eli Zaretskii <eliz@gnu.org>
1434
1435 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1436 and header-lines, as they don't have one computed for them.
1437 (Bug#10098)
1438
1439 * .gdbinit (prow): Make displayed values more self-explaining.
1440 Add row's hash code.
1441
261b6fd4
LMI
14422011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1443
1444 * process.c (wait_reading_process_output): Fix asynchrounous
1445 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1446 (wait_reading_process_output): Add comment and URL.
261b6fd4 1447
e7cfd277
JD
14482011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1449
1450 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1451
a9b9b7f5
CY
14522011-11-21 Chong Yidong <cyd@gnu.org>
1453
1454 * window.c (Fnext_window, Fprevious_window): Doc fix.
1455
b0d15b4f
SM
14562011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1457
1458 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1459
fe7a3057
JB
14602011-11-20 Juanma Barranquero <lekktu@gmail.com>
1461
1462 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1463
d2999b1a
MR
14642011-11-20 Martin Rudalics <rudalics@gmx.at>
1465
1466 * window.c (Fset_window_combination_limit): Rename argument
1467 STATUS to LIMIT.
1468 (Vwindow_combination_limit): Remove "status" from doc-string.
1469
d5ff9cd0
AS
14702011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1471
1472 * m/ibms390.h: Remove.
1473 * m/ibms390x.h: Don't include "ibms390.h".
1474
a5bb9bd3
SM
14752011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1476
1477 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1478 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1479
cd1181db
JB
14802011-11-20 Juanma Barranquero <lekktu@gmail.com>
1481
1482 * casetab.c (Fset_case_table):
1483 * charset.c (Fcharset_after): Fix typos.
1484
615a3b8d 14852011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1486
17e845af
PE
1487 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1488 Otherwise, valgrind does not work on some platforms.
1489 Problem reported by Andreas Schwab in
6a0bf43d
PE
1490 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1491 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1492 is set, removing the need for VIRT_ADDRESS_VARIES.
1493 (PURE_P): Use a more-efficient implementation that needs just one
1494 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1495 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1496 to 4 (xorl, subq, cmpq, setbe).
1497 * alloc.c (pure): Always extern now, since that's the
1498 VIRT_ADDR_VARIES behavior.
1499 (PURE_POINTER_P): Use a single comparison, not two, for
1500 consistency with the new puresize.h.
1501 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1502 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1503 Remove VIRT_ADDR_VARIES no longer needed.
1504
f8fe6f96
EZ
15052011-11-19 Eli Zaretskii <eliz@gnu.org>
1506
1507 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1508 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1509 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1510 behave as if the cursor position were at the window margin.
1511
1512 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1513 and the cursor position is out of bounds, behave as if the cursor
1514 position were at the window margin. (Bug#10075)
1515
df05a53c
CY
15162011-11-18 Chong Yidong <cyd@gnu.org>
1517
1518 * window.c (Fwindow_combination_limit): Make first argument
1519 non-optional, since it is meaningless for live windows like the
1520 selected window.
1521
2071918e
DA
15222011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1523
1524 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1525
b50a28de
SM
15262011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1527
1528 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1529 (graft_intervals_into_buffer): Simplify.
1530
015137db
EZ
15312011-11-18 Eli Zaretskii <eliz@gnu.org>
1532
1533 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1534 hash values of the two rows.
1535 (copy_row_except_pointers): Preserve the used[] arrays and the
1536 hash values of the two rows. (Bug#10035)
68c95424 1537 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1538
1539 * xdisp.c (row_hash): New function, body extracted from
1540 compute_line_metrics.
1541 (compute_line_metrics): Call row_hash, instead of computing the
1542 hash code inline.
1543
1544 * dispnew.c (verify_row_hash): Call row_hash for computing the
1545 hash code of a row, instead of duplicating code from xdisp.c.
1546
1547 * dispextern.h (row_hash): Add prototype.
1548
a2addb04
TH
15492011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1550
1551 * frame.c (delete_frame): Don't delete the terminal when the last
1552 X frame is closed if emacs is built with GTK toolkit.
1553
df85d315
JB
15542011-11-17 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1557
a0c2d0ae
MR
15582011-11-17 Martin Rudalics <rudalics@gmx.at>
1559
1560 * window.c (Vwindow_splits): Rename to
1561 Vwindow_combination_resize. Suggested by Juri Linkov.
1562 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1563 of Vwindow_splits.
1564
58179cce
JB
15652011-11-16 Juanma Barranquero <lekktu@gmail.com>
1566
7877f373
JB
1567 * nsfns.m (Fns_font_name):
1568 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1569
b6f67890
MR
15702011-11-16 Martin Rudalics <rudalics@gmx.at>
1571
1572 * window.h (window): Rename slot "nest" to "combination_limit".
1573 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1574 (Fset_window_nest): Rename to Fset_window_combination_limit.
1575 (Vwindow_nest): Rename to Vwindow_combination_limit.
1576 (recombine_windows, make_parent_window, make_window)
1577 (Fsplit_window_internal, saved_window)
1578 (Fset_window_configuration, save_window_save): Rename all
1579 occurrences of window_nest to window_combination_limit.
1580
c7015153
JB
15812011-11-15 Juanma Barranquero <lekktu@gmail.com>
1582
1583 * image.c (imagemagick_load_image): Fix typo.
1584
322ad6ec
EZ
15852011-11-14 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (display_line): Move the call to
1588 highlight_trailing_whitespace before the call to
1589 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1590 faces of all the glyphs to compute ROW's hash value.
1591 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1592
f067b8ec
JB
15932011-11-14 Juanma Barranquero <lekktu@gmail.com>
1594
1595 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1596 just return (bug#10044).
1597
1e5b2111
EZ
15982011-11-12 Eli Zaretskii <eliz@gnu.org>
1599
7ef3cbd5
EZ
1600 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1601 with user-defined heap size. Bump the default size of the temacs
1602 heap to 27MB, to avoid memory warning when running temacs.
1603 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1604
1e5b2111
EZ
1605 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1606 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1607 (verify_row_hash) [XASSERTS]: New function.
1608 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1609 that the hash value of glyph rows is correct.
1e5b2111 1610
89d61221
MR
16112011-11-12 Martin Rudalics <rudalics@gmx.at>
1612
1613 * window.h (window): Remove splits slot.
1614 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1615 (Fdelete_other_windows_internal, make_parent_window)
1616 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1617 (Fset_window_configuration, save_window_save): Don't deal with
1618 split status of windows.
1619 (saved_window): Remove splits slot.
1620 (Vwindow_splits): Rewrite doc-string.
1621
97f18cc8
JD
16222011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1623
1624 * xfns.c (unwind_create_frame):
1625 * nsfns.m (unwind_create_frame):
1626 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1627 Vframe_list (Bug#9999).
1628
22a648b4
DA
16292011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1630
0b381c7e 1631 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1632
659afede
KH
16332011-11-11 Kenichi Handa <handa@m17n.org>
1634
1635 * callproc.c (Fcall_process): Set the member dst_multibyte of
1636 process_coding.
1637
9ac0394b
KH
16382011-11-11 Johan Bockgård <bojohan@gnu.org>
1639
1640 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1641 avoid a crash (bug#9496).
1642
2fbdc249
CY
16432011-11-09 Chong Yidong <cyd@gnu.org>
1644
1645 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1646 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1647
ac6b1f81
PE
16482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1651
09db192c
PE
16522011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1653
1654 Avoid some portability problems by eschewing 'extern inline' functions.
1655 The trivial performance wins aren't worth the portability hassles; see
1656 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1657 et seq.
1658 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1659 (window_box_width, window_box_left, window_box_left_offset)
1660 (window_box_right, window_box_right_offset): Undo previous change,
1661 by removing the "extern"s.
1662 * intervals.c (adjust_intervals_for_insertion)
1663 (adjust_intervals_for_deletion): Undo previous change,
1664 making these static again.
1665 (offset_intervals, temp_set_point_both, temp_set_point)
1666 (copy_intervals_to_string): No longer inline.
1667 * xdisp.c (window_text_bottom_y, window_box_width)
1668 (window_box_height, window_box_left_offset)
1669 (window_box_right_offset, window_box_left, window_box_right)
1670 (window_box): No longer inline.
1671
105216ed
CY
16722011-11-08 Chong Yidong <cyd@gnu.org>
1673
1674 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1675 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1676 Signal an error if not a live window.
105216ed
CY
1677 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1678 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1679
ae9e237f
JB
16802011-11-07 Juanma Barranquero <lekktu@gmail.com>
1681
1682 * lisp.h (syms_of_abbrev): Remove declaration.
1683 Reported by CHENG Gao <chenggao@royau.me>.
1684
c7aa8333
EZ
16852011-11-07 Eli Zaretskii <eliz@gnu.org>
1686
1687 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1688 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1689 of temacs in GUI mode.
1690
be7f5545
MR
16912011-11-07 Martin Rudalics <rudalics@gmx.at>
1692
1693 * window.h: Declare delete_all_child_windows instead of
1694 delete_all_subwindows.
1695 * window.c (Fwindow_nest, Fset_window_nest)
1696 (Fset_window_new_total, Fset_window_new_normal)
1697 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1698 (delete_all_subwindows): Rename to delete_all_child_windows.
1699 (Fdelete_other_windows_internal, Fset_window_configuration):
1700 Call delete_all_child_windows instead of delete_all_subwindows.
1701 * frame.c (delete_frame): Call delete_all_child_windows instead
1702 of delete_all_subwindows.
1703
ca78dc43
PE
17042011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1705
1706 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1707 This is also needed for porting to any host where GC_MARK_STACK is
1708 not GC_MAKE_GCPROS_NOOPS.
1709 (which_symbols): Use it.
1710
a0241d01
KH
17112011-11-07 Kenichi Handa <handa@m17n.org>
1712
1713 * coding.c (coding_set_destination): Check coding->src_pos only
1714 when coding->src_object is a buffer (bug#9910).
1715
1716 * process.c (send_process): Set the member src_multibyte of coding
1717 to 0 (bug#9911) when sending a unibyte text.
1718
1719 * callproc.c (Fcall_process): Set the member src_multibyte of
1720 process_coding to 0 (bug#9912).
1721
a64bfdfa 17222011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1723
1724 * xmenu.c (cleanup_widget_value_tree): New function.
1725 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1726 calling free_menubar_widget_value_tree directly (Bug#9830).
1727
cb41b32a
PE
17282011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 Fix some portability problems with 'inline'.
1731 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1732 (window_box_width, window_box_left, window_box_left_offset)
1733 (window_box_right, window_box_right_offset): Declare extern.
1734 Otherwise, these inline functions do not conform to C99 and
1735 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1736 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1737 * intervals.c (adjust_intervals_for_insertion)
1738 (adjust_intervals_for_deletion): Now extern, because otherwise the
1739 extern inline functions 'offset_intervals' couldn't refer to it.
1740 (static_offset_intervals): Remove.
1741 (offset_intervals): Rewrite using the old contents of
1742 static_offset_intervals. The old version didn't conform to C99
1743 because an extern inline function contained a reference to an
1744 identifier with static linkage.
1745
b7041366
AS
17462011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1747
1748 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1749 GC.
1750
88a37c4d
EZ
17512011-11-06 Eli Zaretskii <eliz@gnu.org>
1752
1753 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1754 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1755 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1756 return Qleft_to_right.
1757
49745b39
CY
17582011-11-06 Chong Yidong <cyd@gnu.org>
1759
1760 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1761 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1762 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1763 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1764 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1765 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1766 (Fwindow_vscroll): Doc fix.
1767 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1768 argument, since it makes no sense to pass a live window and for
1769 consistency with window-child.
1770
1f05cd82
CS
17712011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1772
1773 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1774 support MSVC.
1775
22610910
JR
17762011-11-05 Jason Rumney <jasonr@gnu.org>
1777
1778 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1779 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1780 fonts (Bug#6029).
1781 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1782 bitwise arithmetic preventing use of unicode-sip and non-truetype
1783 opentype fonts.
1784
a06776b2
EZ
17852011-11-05 Eli Zaretskii <eliz@gnu.org>
1786
3ad924ba
EZ
1787 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1788 "emacs"-only part.
1789
a06776b2
EZ
1790 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1791 initialization code to keep similarity to xfns.c after changes
1792 from 2011-11-05.
1793
c9e7db78
JD
17942011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1795
a97f8f3f
JD
1796 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1797 (unwind_create_frame): New function (Bug#9943).
1798 (Fx_create_frame): Restructure code to be more similar to the one in
1799 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1800 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1801 Move terminal->reference_count++ just before making the frame official
1802 (Bug#9943).
1803
1804 * nsterm.m (x_free_frame_resources): New function.
1805 (x_destroy_window): Move code to x_free_frame_resources.
1806
c9e7db78 1807 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1808 (Fx_create_frame, x_create_tip_frame):
1809 Move terminal->reference_count++ just before making the frame
75f1671a 1810 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1811 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1812
a6fc3b5c
EZ
18132011-11-05 Eli Zaretskii <eliz@gnu.org>
1814
1815 Support MSVC build with newer versions of Visual Studio.
1816 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1817 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1818 nt/gmake.defs.
1819
1820 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1821 which are not supported by MSVC.
1822 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1823 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1824 bitfields.
1825 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1826 types in bitfields.
1827 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1828
1829 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1830
58179cce 18312011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1832
1833 Support MSVC build with newer versions of Visual Studio.
1834 * w32.c: Don't include w32api.h for MSVC.
1835 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1836
1837 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1838 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1839 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1840 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1841 e_* cousins.
1842 (alloca) [_MSC_VER]: Define to _alloca.
1843
1844 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1845
1846 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1847
a58c13ed
EZ
18482011-11-04 Eli Zaretskii <eliz@gnu.org>
1849
1850 * xdisp.c (note_mouse_highlight): If either of
1851 previous/next-single-property-change returns nil, treat that as
1852 the beginning or the end of the buffer. (Bug#9955)
1853
fe0b6370
JD
18542011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1855
a58c13ed 1856 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1857 label is not null (Bug#9951).
1858 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1859 may be NULL.
1860
89bd5ee1
EZ
18612011-11-04 Eli Zaretskii <eliz@gnu.org>
1862
1863 * window.c (Fwindow_body_size): Mention in the doc string that the
1864 return value is in frame's canonical units. (Bug#9949)
1865
84c3edb9
EZ
18662011-11-03 Eli Zaretskii <eliz@gnu.org>
1867
4e2fb5c7
EZ
1868 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1869
84c3edb9 1870 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1871 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1872 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1873
bc17a887
EZ
18742011-11-01 Eli Zaretskii <eliz@gnu.org>
1875
1876 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1877 Don't stop backward scan on the continuation glyph, even though
1878 its CHARPOS is positive.
6d5eb5b0
SM
1879 (mouse_face_from_buffer_pos, note_mouse_highlight):
1880 Rename cover_string to disp_string.
bc17a887 1881
4ee88440
MR
18822011-11-01 Martin Rudalics <rudalics@gmx.at>
1883
1884 * window.c (temp_output_buffer_show): Don't use
1885 Vtemp_buffer_show_specifiers.
1886 (Vtemp_buffer_show_specifiers): Remove unused variable.
1887
c2ff3c02
EZ
18882011-10-30 Eli Zaretskii <eliz@gnu.org>
1889
1890 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1891 past the beginning of the current glyph matrix.
1892
58179cce 18932011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1894
1895 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1896 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1897 HAVE_GTK3 (Bug#9869).
b77a6a7f 1898
3b574623
JD
1899 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1900 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1901
b77a6a7f
JD
1902 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1903
1904 * xterm.c: Declare x_handle_net_wm_state to return int.
1905 (handle_one_xevent): Check if we are iconified but don't have
1906 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1907 (get_current_wm_state): Return non-zero if not hidden,
1908 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1909 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1910 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1911 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1912
196e41e4
PE
19132011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1916 so that this new function doesn't get optimized away by a
1917 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1918
021f2e1a
AS
19192011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1920
1921 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1922
8b058d44
EZ
19232011-10-29 Eli Zaretskii <eliz@gnu.org>
1924
1925 Fix the `xbytecode' command.
1926 * .gdbinit (xprintbytestr): New command.
b50a28de 1927 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1928 (xbytecode): Print the byte-code string as well.
1929
4452fb80
EZ
19302011-10-29 Kim Storm <storm@cua.dk>
1931
8b058d44
EZ
1932 * alloc.c (which_symbols): New function.
1933
21b72067
AS
19342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1935
1936 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1937 line. (Bug#9903)
1938
83ed7b5c
GM
19392011-10-29 Glenn Morris <rgm@gnu.org>
1940
1941 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1942 Not clear what it was for, and it causes various bugs. (Bug#9839)
1943
5a7a728b
EZ
19442011-10-28 Eli Zaretskii <eliz@gnu.org>
1945
1946 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1947 possible random value that matches one of those tested as
1948 condition to clear the mouse face.
1949
d3d0842f
CY
19502011-10-28 Chong Yidong <cyd@gnu.org>
1951
1952 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1953
31b39d13
DN
19542011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1955
1956 * window.c (make_window): Initialize phys_cursor_on_p.
1957
9aba6043
SM
19582011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1959
1960 * lisp.h (struct Lisp_Symbol): Update comments.
1961
c20992f4
JB
19622011-10-28 Juanma Barranquero <lekktu@gmail.com>
1963
1964 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1965
db4f02f2
EZ
19662011-10-28 Eli Zaretskii <eliz@gnu.org>
1967
1968 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1969 <oslsachem@gmail.com> for helping to debug this.
1970
1971 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1972 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1973 (g_b_init_get_glyph_outline_w): New static variables.
1974 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1975 (GetGlyphOutlineW_Proc): New typedefs.
1976 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1977 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1978 New functions.
1979 (w32font_open_internal, compute_metrics):
1980 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1981 instead of calling the "wide" APIs directly.
1982
1983 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1984
1985 * w32.h (syms_of_w32font): Add prototype.
1986
87e68db4
JB
19872011-10-27 Juanma Barranquero <lekktu@gmail.com>
1988
1989 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1990 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1991 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1992 (Fmove_to_window_line): Doc fix.
1993
435c1d67
CY
19942011-10-27 Chong Yidong <cyd@gnu.org>
1995
1996 * process.c (make_process): Set gnutls_state to NULL.
1997
1998 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1999 non-NULL, regardless of GNUTLS_INITSTAGE.
2000 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2001 an error. Set process slots as soon as we allocate them.
2002
2003 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2004
9c6c6f49
CY
20052011-10-27 Chong Yidong <cyd@gnu.org>
2006
9aba6043
SM
2007 * gnutls.c (emacs_gnutls_deinit): New function.
2008 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2009 (Fgnutls_deinit, Fgnutls_boot): Use it.
2010
2011 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2012 (deactivate_process): Call emacs_gnutls_deinit.
2013
657d08d3
JB
20142011-10-27 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * image.c (x_create_x_image_and_pixmap):
2017 * w32.c (sys_rename, w32_delayed_load):
2018 * w32font.c (fill_in_logfont):
2019 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2020
5430d399
JB
20212011-10-26 Juanma Barranquero <lekktu@gmail.com>
2022
2023 * w32fns.c (w32_default_color_map): New function,
2024 extracted from Fw32_default_color_map.
a7ef684b 2025 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2026
fe0055fa
PE
20272011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2028
2029 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2030
e6346438
SM
20312011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2032
2033 * keyboard.c (test_undefined): New function (bug#9751).
2034 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2035
e112cc37
ET
20362011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2037
2038 * sysdep.c (init_sys_modes): Fix the check for the controlling
2039 terminal (Bug#6649).
2040
7b5d6677
EZ
20412011-10-20 Eli Zaretskii <eliz@gnu.org>
2042
2043 * dispextern.h (struct bidi_it): New member next_en_type.
2044
2045 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2046 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2047 current character, check also for next_en_type being WEAK_EN.
2048 (bidi_resolve_weak): Don't enter the expensive loop if the current
2049 position is before next_en_pos. Record the bidi type of the first
2050 non-ET, non-BN character we find, in addition to its position.
2051 (bidi_level_of_next_char): Invalidate next_en_type when
2052 next_en_pos is over-stepped.
2053
7da0b018
PE
20542011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2057 * editfns.c: Rewrite current-time-zone so that it invokes
2058 the equivalent of (format-time-string "%Z") to get the time zone name.
2059 This fixes a bug when the time zone name contains characters that
2060 need converting from the system time locale to Emacs internal format.
2061 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2062 that patch fixed format-time-string to do the conversion, but
2063 I forgot to fix current-time-zone.
2064 (format_time_string): New function, containing most of
2065 what Fformat_time_string used to contain.
2066 (Fformat_time_string): Rewrite in terms of format_time_string.
2067 This doesn't change this function's behavior.
2068 (current-time-zone): Rewrite to use format_time_string.
2069 This fixes the bug reported by Michael Schierl in
2070 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2071 Jason Rumney's 2007-06-07 change worked around this bug, but
2072 didn't fix it.
2073 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2074
8547b010
EZ
20752011-10-19 Eli Zaretskii <eliz@gnu.org>
2076
2077 * xdisp.c (start_display): If the character at POS is displayed
2078 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2079 (try_window_reusing_current_matrix): If a line ends in a display
2080 vector or the next line starts in a display vector, continue
2081 redrawing the window even though the character position of
2082 start_row was reached.
8547b010
EZ
2083 (Bug#9771, part 2)
2084
4e948d15
CY
20852011-10-18 Chong Yidong <cyd@gnu.org>
2086
2087 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2088 with nobreak-char-display too.
2089
4787455f
EZ
20902011-10-18 Eli Zaretskii <eliz@gnu.org>
2091
2092 Fix part 3 of bug#9771.
2093 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2094 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2095 non-neutral characters if the current character is a paragraph
2096 separator (a.k.a. Newline). This avoids running the same
2097 expensive loop twice, once when we consume the preceding newline
2098 and the other time when the line actually needs to be displayed.
2099 Avoid the loop when we see neutrals on the base embedding level
2100 following a character whose directionality is the same as the
2101 paragraph's. This avoids running the expensive loop when a line
2102 ends in a long sequence of neutrals, like control characters.
2103 Add assertion against STRONG_AL type. Slightly rearrange code
2104 that determines the type of a neutral given the first non-neutral
2105 that follows it.
2106 (bidi_level_of_next_char): Set next_en_pos to zero when
2107 invalidating its info.
2108
2c91f553
EZ
21092011-10-17 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (push_display_prop): Determine whether to record string
2112 or buffer position by IT->string, not by IT->method. Allow
2113 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2114 (move_it_vertically_backward): Don't look for character position
2115 immediately after the newline when in a continuation line.
2116 (Bug#9771, part 1)
2c91f553 2117
c7b08b0d
MR
21182011-10-15 Martin Rudalics <rudalics@gmx.at>
2119
2120 * window.c (coordinates_in_window): Rewrite and delabelize
2121 vertical border check. (Bug#5357) (Bug#9618)
2122
6b02f655
SM
21232011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2124
2125 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2126 errors in XSetWindowBorder (bug#9310).
2127
81d40c92
DA
21282011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2129
2130 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2131 avoid crash when xmalloc overrun checking is enabled.
2132
d4172c3b
EZ
21332011-10-13 Eli Zaretskii <eliz@gnu.org>
2134
2135 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2136 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2137 cursor motion with <left> and <right> arrow keys.
2138
2139 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2140 some callers set that themselves.
2141
b00eea75
EZ
21422011-10-12 Eli Zaretskii <eliz@gnu.org>
2143
2144 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2145 display string and the previous row comes from the same string and
2146 is empty. (Bug#9739) (Bug#9738)
2147
8fe012c4
SM
21482011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2149
2150 * doc.c (get_doc_string): Encode file name (bug#9735).
2151
0074aef2
EZ
21522011-10-12 Eli Zaretskii <eliz@gnu.org>
2153
79beb178
EZ
2154 * bidi.c (bidi_level_of_next_char):
2155 * xdisp.c (get_visually_first_element): Remove old incorrect
2156 comments regarding the Unicode Line Separator character.
2157
0074aef2
EZ
2158 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2159
6e4b3fbe
DA
21602011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2161
2162 * alloc.c (Fgc_status): Do not access beyond zombies array
2163 boundary if nzombies > MAX_ZOMBIES.
2164 * alloc.c (dump_zombies): Add missing format specifier.
2165
0324f3af
PE
21662011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2167
b5525cac
PE
2168 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2169 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2170
0324f3af
PE
2171 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2172 Some packages use them to denote characters with modifiers.
2173
e9b5f888
AS
21742011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2175
2176 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2177 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2178 matching a pp-number. Rename parameter var to var1.
2179
127827c0
SM
21802011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2181
2182 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2183
c8fd3bd0
GM
21842011-10-08 Glenn Morris <rgm@gnu.org>
2185
2186 * callint.c (Fcall_interactively): Give a more explicit error for the
2187 'c' case with a non-character input. (Bug#8479)
2188
352ec8ff
EZ
21892011-10-08 Eli Zaretskii <eliz@gnu.org>
2190
03669ccb
EZ
2191 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2192 lines.
7061c986
EZ
2193 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2194 lines that are hscrolled on the left.
03669ccb 2195
352ec8ff
EZ
2196 * dispnew.c (buffer_posn_from_coords): Account for a possible
2197 presence of header-line. (Bug#4426)
2198
a66cfb1c
SM
21992011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2200
6b02f655
SM
2201 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2202 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2203
7c5ee88e
PE
22042011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2205
2206 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2207 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2208 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2209 this makes Emacs dump core during garbage collection on rare
2210 occasions. sizeof is obviously inferior to offsetof here, so
2211 stick with offsetof.
2212 (GC_POINTER_ALIGNMENT): New macro.
2213 (mark_memory): Omit 3rd (offset) arg; caller changed.
2214 Don't assume EMACS_INT alignment is the same as pointer alignment.
2215
df1bbe5b
SM
22162011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2217
2218 * keyboard.c (read_key_sequence_remapped): New var.
2219 (read_key_sequence): Compute remapping in the right buffer.
2220 (command_loop_1): Use read_key_sequence's remapping directly.
2221
51553db6
SM
22222011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2223
32c1fffd
SM
2224 * dired.c (file_name_completion): Don't expand file name.
2225 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2226 before checking file name handler.
2227
51553db6
SM
2228 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2229 they've been requested explicitly (bug#9591).
2230
b6bd1599 22312011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2232
2233 * keymap.c (Fsingle_key_description): Use make_specified_string
2234 instead of build_string to build string from push_key_description.
2235 (Bug#5193)
2236
f701dc2a
PE
22372011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2238
4222c55d
PE
2239 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2240 This fixes a Y2038 bug on 64-bit hosts.
2241 * buffer.c (reset_buffer):
2242 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2243 (Fclear_buffer_auto_save_failure):
2244 Use 0, not -1, to represent an unset failure time, since time_t
2245 might not be signed.
2246
f701dc2a
PE
2247 Remove dependency on glibc malloc internals.
2248 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2249 Move back here from lisp.h, but with their new implementations.
2250 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2251 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2252 * charset.c (charset_table_init): New static var.
2253 (syms_of_charset): Use it instead of xmalloc. This removes a
2254 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2255 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2256 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2257 Move back to alloc.c.
2258 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2259 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2260
9ceebf39
JD
22612011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2262
2263 * nsterm.m (windowDidResize): Call x_set_window_size only when
2264 ns_in_resize is true. Otherwise set pixelwidth/height and
2265 call change_frame_size (Bug#9628).
2266
cb993c58
PE
22672011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2268
3930c88b
PE
2269 Port --enable-checking=all to Fedora 14 x86-64.
2270 * charset.c (syms_of_charset): Also account for glibc malloc's
2271 internal overhead when calculating the initial malloc maximum.
2272
cb993c58
PE
2273 Port --enable-checking=all to Fedora 14 x86.
2274 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2275 Move to lisp.h.
2276 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2277 (overrun_check_realloc, overrun_check_free):
2278 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2279 That way, xmalloc returns a properly-aligned pointer even if
2280 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2281 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2282 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2283 into account when calculating the initial malloc maximum.
2284 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2285 Move here from alloc.c, so that charset.c can use it too.
2286 Properly align; the old code wasn't right for common 32-bit hosts
2287 when configured with --enable-checking=all.
2288 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2289 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2290
31bed486
EZ
22912011-09-29 Eli Zaretskii <eliz@gnu.org>
2292
04c70788 2293 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2294 use EDOM.
2295
fbcaa2f3
EZ
22962011-09-28 Eli Zaretskii <eliz@gnu.org>
2297
2298 * xdisp.c (compute_display_string_end): If there's no display
2299 string at CHARPOS, return -1.
2300
2301 * bidi.c (bidi_fetch_char): When compute_display_string_end
2302 returns a negative value, treat the character as a normal
2303 character not covered by a display string. (Bug#9624)
2304
a239d4e9
JB
23052011-09-28 Juanma Barranquero <lekktu@gmail.com>
2306
2307 * lread.c (Fread_from_string): Fix typo in docstring.
2308
88652fd5
EZ
23092011-09-27 Eli Zaretskii <eliz@gnu.org>
2310
2311 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2312 newline, reseat the iterator instead of bidi-iterating there one
2313 character at a time. (Bug#9610)
32c1fffd
SM
2314 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2315 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2316
ed497dd4
AS
23172011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2318
2319 * lread.c (readevalloop): Use correct code for NBSP.
2320 (read1): Likewise. (Bug#9608)
2321
b2bf61aa
MA
23222011-09-25 Michael Albinus <michael.albinus@gmx.de>
2323
2324 * dbusbind.c (Fdbus_register_signal): When service is not
2325 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2326
32bbb17c
GM
23272011-09-25 Glenn Morris <rgm@gnu.org>
2328
2329 * buffer.c (truncate-lines): Doc fix.
2330
94e0933e
CY
23312011-09-24 Chong Yidong <cyd@stupidchicken.com>
2332
2333 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2334 (Fset_window_next_buffers): Doc fix.
2335
cddde921
GM
23362011-09-24 Glenn Morris <rgm@gnu.org>
2337
2338 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2339
1260aef1
PE
23402011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2341
25b4bfa0
PE
2342 Fix minor problems found by static checking.
2343 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2344 * indent.c (Fvertical_motion): Fix == vs = typo.
2345
e3cbd34b
EZ
23462011-09-24 Eli Zaretskii <eliz@gnu.org>
2347
a66cfb1c
SM
2348 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2349 Default value is now t. Doc fix.
6bf7006f 2350
e3cbd34b 2351 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2352 logic when moving up, not only when moving down. Fix the
e3cbd34b 2353 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2354 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2355
2356 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2357 CHARPOS is covered by a display string which includes newlines.
2358 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2359 is covered by a display string with embedded newlines.
2360
a3de0cbd
MA
23612011-09-24 Michael Albinus <michael.albinus@gmx.de>
2362
2363 * dbusbind.c (Fdbus_register_signal): Add match rule to
2364 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2365 (Fdbus_register_method, Vdbus_registered_objects_table):
2366 Fix docstring.
a3de0cbd 2367
b260039d
JM
23682011-09-24 Jim Meyering <meyering@redhat.com>
2369
32c1fffd 2370 do not ignore write error for any output size
b260039d
JM
2371 The previous change was incomplete.
2372 While it makes emacs --batch detect the vast majority of stdout
2373 write failures, errors were still ignored whenever the output size is
2374 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2375 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2376 && echo FAIL: ignored write error
2377 FAIL: ignored write error
2378 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2379 && echo FAIL: ignored write error
2380 FAIL: ignored write error
2381 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2382
8eca8a7c
AS
23832011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2384
2385 * emacs.c (Fkill_emacs): In noninteractive mode exit
2386 non-successfully if a write error occurred on stdout. (Bug#9574)
2387
3341db62
EZ
23882011-09-21 Eli Zaretskii <eliz@gnu.org>
2389
2390 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2391 the xassert test.
2392
2393 * dispextern.h (struct it): Update the comment documenting what
2394 can it->OBJECT be.
2395
8c203dbf
EZ
23962011-09-20 Eli Zaretskii <eliz@gnu.org>
2397
2398 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2399 a display string, extend search for cursor position to end of row.
2400 (find_row_edges): If the row ends in a newline from a display
2401 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2402 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2403 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2404 non-empty line. Fixes confusing cursor motion with arrow keys at
2405 the beginning of a line that starts with whitespace.
8c203dbf 2406
a4824228
LMI
24072011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2408
2409 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2410 (bug#9493).
2411
33ed493b
CY
24122011-09-18 Chong Yidong <cyd@stupidchicken.com>
2413
2414 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2415 boolean (Bug#9154).
2416
56cd55c8
EZ
24172011-09-18 Eli Zaretskii <eliz@gnu.org>
2418
2419 * xdisp.c (display_line): Record maximum and minimum buffer
2420 positions even if no glyphs were produced (e.g., by a zero-width
2421 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2422 buffer positions that will be removed from the glyph row because
2423 they don't fit.
c02dcedf
EZ
2424 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2425 column is beyond frame width: don't subtract 1 "pixel" when
2426 computing width of the stretch.
3e62b7e0
EZ
2427 (reseat_at_next_visible_line_start): Undo the change made on
2428 2011-09-17 that saved paragraph information and restored it after
2429 the call to `reseat'. (Bug#9545)
56cd55c8 2430
5ed99d36 24312011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2432
2433 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2434 and turn window cursor on if cleared (Bug#9415).
2435
5ed99d36 24362011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2437
2438 * search.c (boyer_moore): Take unibyte characters from pattern
2439 literally. (Bug#9458)
2440
9bade7b2
EZ
24412011-09-18 Eli Zaretskii <eliz@gnu.org>
2442
2443 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2444
e5e9d610
PE
24452011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2446
87e4427a
PE
2447 Fix minor problem found by static checking.
2448 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2449 initialized, to pacify gcc -Wuninitialized.
2450
e5e9d610
PE
2451 * fileio.c: Report proper errno when syscall falls.
2452 (Finsert_file_contents): Save and restore errno,
2453 so that report_file_error outputs the correct diagnostic.
2454 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2455
a1674f0b
EZ
24562011-09-18 Eli Zaretskii <eliz@gnu.org>
2457
2458 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2459
fbfb6dd4
EZ
24602011-09-17 Eli Zaretskii <eliz@gnu.org>
2461
2462 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2463 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2464
bb187662
EZ
24652011-09-17 Eli Zaretskii <eliz@gnu.org>
2466
1137e8b8 2467 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2468 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2469
2470 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2471 (bidi_find_paragraph_start): Search back for paragraph beginning
2472 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2473 (bidi_move_to_visually_next): Only trigger paragraph-related
2474 computations when the last character is a newline or at EOB, not
2475 just any NEUTRAL_B. (Bug#9470)
2476
bb187662
EZ
2477 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2478 truncated lines if point is covered by a display string. (Bug#9524)
2479
2e621251
PE
24802011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2481
2482 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2483 (cons_to_x_long): New function.
2484 (lisp_data_to_selection_data): Use it. Correct the test for
2485 short-versus-long data; it was negated. Break out of vector
2486 loop, for efficiency, when a long datum is discovered.
2487
91a15bc6
SM
24882011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2489
2490 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2491
b41c3a35
EZ
24922011-09-16 Eli Zaretskii <eliz@gnu.org>
2493
2494 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2495 GCC PR/17406) by declaring this function with external scope.
2496
7812ba2d
PE
24972011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2500 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2501
cf7edc2a
AS
25022011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2503
2504 * editfns.c (Fformat): Correctly handle text properties on "%%".
2505
bd01620e
EZ
25062011-09-15 Eli Zaretskii <eliz@gnu.org>
2507
2508 * xterm.c (x_draw_composite_glyph_string_foreground):
2509 * w32term.c (x_draw_composite_glyph_string_foreground):
2510 * term.c (encode_terminal_code):
2511 * composite.c (composition_update_it, get_composition_id):
2512 * xdisp.c (get_next_display_element)
2513 (fill_composite_glyph_string): Add comments about special meaning
2514 of TAB characters in a composition.
2515
a02719a3
PE
25162011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2519 This occurs when processing a multibyte format.
2520 Problem reported by Wolfgang Jenker.
a02719a3 2521
72589a3c
JB
25222011-09-15 Johan Bockgård <bojohan@gnu.org>
2523
2524 * xdisp.c (try_cursor_movement): Only check for exact match if
2525 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2526
1c14176c
PE
25272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 Remove unused external symbols.
2530 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2531 * xdisp.c (calc_pixel_width_or_height): Now static.
2532 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2533 * indent.c (check_display_width):
2534 * w32term.c: Fix comment to match code.
2535 * xterm.c, xterm.h (x_catching_errors): Remove.
2536
d2eea5b5
PE
25372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2538
2539 * xselect.c: Use signed conversions more consistently (Bug#9498).
2540 (selection_data_to_lisp_data): Assume incoming selection data are
2541 signed integers, not unsigned. This is to be consistent with
2542 outgoing selection data, which was modified to use signed integers
2543 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2544 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2545 expects long, not unsigned long.
2546
46888499
EZ
25472011-09-14 Eli Zaretskii <eliz@gnu.org>
2548
2549 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2550 computation of loop end. Reported by Johan Bockgård
2551 <bojohan@gnu.org>.
2552
ef8ef9fb
CY
25532011-09-13 Chong Yidong <cyd@stupidchicken.com>
2554
2555 * frame.c (Fother_visible_frames_p): Function deleted.
2556
fa819fed
EZ
25572011-09-12 Eli Zaretskii <eliz@gnu.org>
2558
2559 * indent.c (compute_motion): Process display vector front to back
2560 rather than the other way around. (Bug#2496)
2561
2ba8e008
SM
25622011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2563
2564 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2565
20f53c69
CY
25662011-09-11 Chong Yidong <cyd@stupidchicken.com>
2567
2568 * minibuf.c (Fread_from_minibuffer): Doc fix.
2569
d562d7a4
EZ
25702011-09-11 Eli Zaretskii <eliz@gnu.org>
2571
2572 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2573 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2574
1c4d7f3d
LMI
25752011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2576
2577 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2578 value for non-existent files.
2579
b885bf36
EZ
25802011-09-11 Eli Zaretskii <eliz@gnu.org>
2581
2582 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2583 set its "size" to -1. This will set the modtime_size field of
2584 the corresponding buffer to -1, which is what
2585 verify-visited-file-modtime expects for files that do not exist.
2586 (Bug#9139)
2587
6612f0bf
PE
25882011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2591 here ...
2592 * lisp.h: ... from here. push_key_description is no longer
2593 defined in keyboard.c, so its declaration should not be in
2594 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2595 logically belongs with push_key_description.
2596
dfb3f755
PE
25972011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * buffer.h: Include <sys/types.h> instead of <time.h>.
2600 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2601 Problem reported by Herbert J. Skuhra.
2602
3134906c
LMI
26032011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2604
2605 * xml.c (parse_region): Make the parsing work for
2606 non-comment-starting XML files again (bug#9144).
2607
8d903f4e
AS
26082011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2609
2610 * image.c (gif_load): Fix calculation of bottom and right corner.
2611 (Bug#9468)
2612
80ad64f4
EZ
26132011-09-10 Eli Zaretskii <eliz@gnu.org>
2614
2615 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2616 redisplay in small windows.
2617
208a048d
EZ
26182011-09-09 Eli Zaretskii <eliz@gnu.org>
2619
2620 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2621
9b1c252e
MR
26222011-09-08 Martin Rudalics <rudalics@gmx.at>
2623
2624 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2625 Operate on live windows only.
2626
2949f33b
JB
26272011-09-08 Juanma Barranquero <lekktu@gmail.com>
2628
2629 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2630
e08dcafd
EZ
26312011-09-07 Eli Zaretskii <eliz@gnu.org>
2632
2633 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2634 only under bidi iteration.
2635
115b96bd
JD
26362011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2637
2638 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2639
c8199d0f
PE
26402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2643 Without this fix, the command to link temacs failed due to an
2644 undefined symbol __builtin_isnan. This is because
2645 /usr/include/iso/math_c99.h #defines isnan(x) to
2646 __builtin_isnan(x), but the bundled gcc, which identifies itself
2647 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2648 a __builtin_isnan.
2649 * floatfns.c (isnan): #undef, and then #define to a clone of
2650 what's in data.c.
2651 (Fisnan): Always define, since it's always available now.
2652 (syms_of_floatfns): Always define isnan at the Lisp level.
2653
e39b275c 26542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2655
2656 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2657
b2db44d9 26582011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2659
f4af5137 2660 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2661 The previous code assumed that file offsets (off_t values) fit in
2662 EMACS_INT variables, which is not true on typical 32-bit hosts.
2663 The code messed up by falsely reporting buffer overflow in cases
2664 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2665 when "big" contains more than 2**29 bytes, even though this
2666 inserts just one byte and does not overflow the buffer.
2667 (Finsert_file_contents): Store file offsets as off_t
2668 values, not as EMACS_INT values. Check for overflow when
2669 converting between EMACS_INT and off_t. When checking for
2670 buffer overflow or for overlap, take the offsets into account.
2671 Don't use EMACS_INT for small values where int suffices.
2672 When checking for overlap, fix a typo: ZV was used where
2673 ZV_BYTE was intended.
2674 (Fwrite_region): Don't assume off_t fits into 'long'.
2675 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2676
ecfc0a49
MA
26772011-09-05 Michael Albinus <michael.albinus@gmx.de>
2678
2679 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2680
6511acf2 26812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2682
0999621a 2683 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2684
2685 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2686 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2687 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2688 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2689 (modify_event_symbol): Do not assume that the length of
2690 name_alist_or_stem is safe to alloca and fits in int.
2691 (Fexecute_extended_command): Likewise for function name and binding.
2692 (Frecursion_depth): Wrap around reliably on integer overflow.
2693 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2694 since some callers pass EMACS_INT values.
2695 (Fsingle_key_description): Don't crash if symbol name contains more
2696 than MAX_ALLOCA bytes.
2697 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2698 (get_minibuffer): Arg is now EMACS_INT, not int.
2699 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2700 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2701 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2702
2be7d702
PE
2703 * dbusbind.c (signature_cat): New function.
2704 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2705 Do not overrun buffer; instead, report string overflow.
2706
9d1df220
PE
2707 * dispnew.c (add_window_display_history): Don't overrun buffer.
2708 Truncate instead; this is OK since it's just a log.
2709
33ef5c64
PE
2710 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2711 even if the time zone offset is outlandishly large.
2712 Don't mishandle offset == INT_MIN.
2713
66c6fdd5
PE
2714 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2715 when creating daemon; the previous buffer-overflow check was incorrect.
2716
d749b01b
PE
2717 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2718 which has the guts of the old verror function.
2719
b5cd1905
PE
2720 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2721 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2722
6e1a67fb
PE
2723 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2724 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2725 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2726 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2727 length of string rather than counting it via multiple sprintfs;
2728 that's simpler and more reliable.
c21721cc
PE
2729 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2730 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2731 sprintf, in case result does not fit in int.
2732
c57b67fc
PE
2733 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2734 (fontset_from_font): Print it.
2735
8a401434
PE
2736 * frame.c (tty_frame_count): Now printmax_t, not int.
2737 (make_terminal_frame, set_term_frame_name): Print it.
2738 (x_report_frame_params): In X, window IDs are unsigned long,
2739 not signed long, so print them as unsigned.
2740 (validate_x_resource_name): Check for implausibly long names,
2741 and don't assume name length fits in 'int'.
2742 (x_get_resource_string): Don't blindly alloca invocation name;
2743 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2744 not fit in int.
2745
6e1a67fb
PE
2746 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2747 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2748 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2749
0df02bf3
PE
2750 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2751 Use esprintf, not sprintf, in case result does not fit in int.
2752
48e30793
PE
2753 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2754 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2755 it as a large positive number.
2756 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2757 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2758
a66ff6d8
PE
2759 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2760 in case result does not fit in int.
2761
aca216ff
PE
2762 * print.c (float_to_string): Detect width overflow more reliably.
2763 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2764 buffer overrun. Don't assume list length fits in 'int'. Treat
2765 print length of 0 as 0, not as infinity; to be consistent with other
2766 uses of print length in this function. Don't overflow print length
2767 index. Don't assume hash table size fits in 'long', or that
2768 vectorlike size fits in 'unsigned long'.
2769
31c286f7
PE
2770 * process.c (make_process): Use printmax_t, not int, to format
2771 process-name gensyms.
2772
55e5faa1
PE
2773 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2774
80f2e268
PE
2775 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2776 to avoid potential buffer overrun.
2777
670741ab
PE
2778 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2779 if X resource line is longer than 512 bytes.
2780
b7163a50
PE
2781 * xfns.c (x_window): Make sprintf buffer a bit bigger
2782 to avoid potential buffer overrun.
2783
ae58ff1f
PE
2784 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2785
c43c8a6a
PE
2786 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2787
3f8236f4
PE
27882011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2789
53e9fe90 2790 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2791 Without these, Emacs silently mishandles large integers sometimes.
2792 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2793 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2794
6511acf2
PE
2795 * xdisp.c (try_window_id): Check Emacs fixnum range before
2796 converting to 'int'.
806add1d 2797
6511acf2 2798 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2799 Check that an Emacs fixnum is in range before assigning it to 'int'.
2800 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2801 values converted from Emacs fixnums.
2802 (Frecenter): Don't wrap around a line count if it is out of 'int'
2803 range; instead, treat it as an extreme value.
2804 (Fset_window_configuration, compare_window_configurations):
2805 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2806
6511acf2
PE
2807 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2808 that can exceed INT_MAX. Check that EMACS_INT value is in range
2809 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2810 (match_limit): Don't assume that a fixnum can fit in 'int'.
2811
6511acf2 2812 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2813 exceed INT_MAX.
2814
6511acf2 2815 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2816 (Fvertical_motion): Don't wrap around LINES values that don't fit
2817 in 'int'. Instead, treat them as extreme values. This is good
2818 enough for windows, which can't have more than INT_MAX lines anyway.
2819
fcb901a7
LMI
28202011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2821
0f2f6b6d
LMI
2822 * Require libxml/parser.h to avoid compilation warning.
2823
fcb901a7
LMI
2824 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2825
2826 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2827 since this reportedly can destroy thread storage.
2828
6e20a0d4
CY
28292011-08-30 Chong Yidong <cyd@stupidchicken.com>
2830
2831 * syntax.c (find_defun_start): Update all cache variables if
2832 exiting early (Bug#9401).
2833
148ae00e
EZ
28342011-08-30 Eli Zaretskii <eliz@gnu.org>
2835
f6cfbd8f
EZ
2836 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2837
148ae00e
EZ
2838 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2839 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2840 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2841
2842 * term.c (tty_append_glyph): New function.
2843 (produce_stretch_glyph): Static function and its prototype deleted.
2844
a66cfb1c
SM
2845 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2846 Add prototypes.
148ae00e 2847
c4a07a4c
PE
28482011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2851 when checking :margin (Bug#9390).
2852 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2853 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2854 so that the name doesn't mislead. All uses changed.
2855
6bc8cd65
JB
28562011-08-28 Johan Bockgård <bojohan@gnu.org>
2857
2858 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2859 set_tty_hooks.
2860
dca4927e
EZ
28612011-08-27 Eli Zaretskii <eliz@gnu.org>
2862
2863 * xdisp.c (move_it_to): Don't bail out early when reaching
2864 position beyond to_charpos, if we are scanning backwards.
2865 (move_it_vertically_backward): When DY == 0, make sure we get to
2866 the first character in the line after the newline.
2867
f2cad773
PE
28682011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2869
2870 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2871 (ccl_driver): Do not generate an out-of-range pointer.
2872 (Fccl_execute_on_string): Remove unnecessary check for
2873 integer overflow, noted by Stefan Monnier in
2874 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2875 Remove a FIXME that didn't need fixing.
2876 Simplify the newly-introduced buffer reallocation code.
2877
0cae2cdb
JB
28782011-08-27 Juanma Barranquero <lekktu@gmail.com>
2879
2880 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2881
5fc295a4 28822011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2883
70c60eb2 2884 Integer and memory overflow issues (Bug#9196).
726e0ab1 2885
d31850da
PE
2886 * doc.c (get_doc_string): Rework so that
2887 get_doc_string_buffer_size is the actual buffer size, rather than
2888 being 1 less than the actual buffer size; this makes xpalloc more
2889 convenient.
2890
a69fbedb
PE
2891 * image.c (x_allocate_bitmap_record, cache_image):
2892 * xselect.c (Fx_register_dnd_atom):
2893 Simplify previous changes by using xpalloc.
2894
fe5c5d37
PE
2895 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2896 since either will do and ptrdiff_t is convenient with xpalloc.
2897
0065d054
PE
2898 * charset.c (charset_table_size)
2899 (struct charset_sort_data.priority): Now ptrdiff_t.
2900 (charset_compare): Don't overflow if priorities differ greatly.
2901 (Fsort_charsets): Don't assume list length fits in int.
2902 Check for size-calculation overflow when allocating sort data.
2903 (syms_of_charset): Allocate an initial charset table that is
2904 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2905
2906 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2907
2908 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2909 The actual value is always <= INT_MAX, and leaving it unsigned made
2910 overflow checking harder.
2911
2912 * dispextern.h (struct glyph_matrix.rows_allocated)
2913 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2914 with xpalloc. The values are still always <= INT_MAX.
2915
2916 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2917
2918 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2919 (SAFE_NALLOCA): New macro.
2920
2921 * region-cache.c (struct boundary.pos, find_cache_boundary)
2922 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2923 (set_cache_region, invalidate_region_cache)
2924 (revalidate_region_cache, know_region_cache, region_cache_forward)
2925 (region_cache_backward, pp_cache):
2926 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2927 so that ptrdiff_t * can be passed to xpalloc.
2928 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2929 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2930 (pp_cache): Don't assume cache_len fits in int.
2931 * region-cache.h: Adjust extern decls to match.
2932
2933 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2934 EMACS_INT, since either will do, for xpalloc.
2935
2936 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2937 (xnmalloc, xnrealloc, xpalloc): New functions.
2938
726e0ab1
PE
2939 * bidi.c (bidi_shelve_header_size): New constant.
2940 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2941 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2942
51f30bc5 2943 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2944 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2945 (overlay_strings):
2946 Don't update size of array until after memory allocation succeeds,
2947 because xmalloc/xrealloc may not return.
0065d054
PE
2948 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2949 now that we have proper integer overflow checking.
2950 (record_overlay_string, overlay_strings): Catch overflows when
2951 calculating size of overlay_str_buf.
726e0ab1 2952
0065d054
PE
2953 * callproc.c (Fcall_process): Check for size overflow when
2954 calculating size of args2.
2955 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2956 Normally we prefer signed values, but sticking with ptrdiff_t would
2957 require adding more-complicated checks.
726e0ab1
PE
2958
2959 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2960 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2961 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2962 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2963
2964 * character.c (Fstring): Check for size-calculation overflow.
2965
2966 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2967 unnecessary integer overflow. Check for size overflow.
2968 (encode_coding_object): Don't update size until xmalloc succeeds.
2969
2970 * composite.c (get_composition_id): Check for overflow in glyph
2971 length calculations.
2972
2973 Integer and memory overflow fixes for display code.
2974 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2975 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2976 (scrolling_window): Check for overflow in size calculations.
2977 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2978 Don't assume glyph table len fits in int.
2979 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2980 (row_table_size): Now ptrdiff_t, not int.
2981 (scrolling_window): Avoid overflow in size calculations.
2982 Don't update size until allocation succeeds.
2983 * fns.c (concat): Check for overflow in size calculations.
2984 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2985 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2986 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2987
2988 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2989 (get_doc_string): Check for size calculation overflow.
2990 Don't update size until allocation succeeds.
2991 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2992 EMACS_INT, where ptrdiff_t will do.
2993 (Fsubstitute_command_keys): Check for string overflow.
2994
2995 * editfns.c (set_time_zone_rule): Don't assume environment length
2996 fits in int.
2997 (message_length): Now ptrdiff_t, not int.
2998 (Fmessage_box): Don't update size until allocation succeeds.
2999 Don't assume message length fits in int.
3000 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3001
0065d054
PE
3002 * emacs.c (main): Do not reallocate argv, since there is a null at
3003 the end that can be overwritten, and this way there's no need to
3004 worry about size-calculation overflow.
3005 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3006
3007 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3008 alloc succeeds.
3009 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3010
3011 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3012 (x_set_scroll_bar_width, x_figure_window_size):
3013 Check for integer overflow.
3014 (x_set_alpha): Do not assume XINT fits in int.
3015
3016 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3017 This is for the members text_lines, text_cols, total_lines, total_cols,
3018 where the system imposes an 'int' limit.
3019
3020 * fringe.c (Fdefine_fringe_bitmap):
3021 Don't update size until alloc works.
3022
3023 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3024 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3025
3026 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3027 Check for size-calculation overflow.
3028 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3029 do, as we prefer signed integers.
3030 (id_to_widget.max_size, id_to_widget.used)
3031 (xg_store_widget_in_map, xg_remove_widget_from_map)
3032 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3033 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3034 Use and return ptrdiff_t, not int.
3035 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3036 * gtkutil.h: Change prototypes to match the above.
3037
3038 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3039 are duplicate now that they've been promoted to lisp.h.
3040 (x_allocate_bitmap_record, x_alloc_image_color)
3041 (make_image_cache, cache_image, xpm_load):
3042 Don't update size until alloc is done.
3043 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3044 (x_detect_edges):
3256efce 3045 Check for size calculation overflow.
726e0ab1
PE
3046 (ct_colors_allocated_max): New constant.
3047 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3048 overflow.
3256efce 3049
726e0ab1
PE
3050 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3051 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3052 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3053 Use ptrdiff_t, not int, to count maps.
3054 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3055 calculations. Don't update size until allocation succeeds.
3056 Redo calculations to avoid overflow.
726e0ab1
PE
3057 * keyboard.h: Change prototypes to match the above.
3058
3059 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3060 to count maps.
3061 (current_minor_maps): Check for size calculation overflow.
3062 * keymap.h: Change prototypes to match the above.
3063
3064 * lread.c (read1, init_obarray): Don't update size until alloc done.
3065
3066 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3067 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3068
726e0ab1
PE
3069 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3070 Now ptrdiff_t, not int.
3071 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3072 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3073
3074 * process.c (Fnetwork_interface_list): Check for overflow
3075 in size calculation.
3076
3077 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3078
3079 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3080 overflow. Don't bother calling xmalloc when xrealloc will do.
3081
3082 * search.c (Freplace_match): Check for size calculation overflow.
3083 (Fset_match_data): Don't assume list lengths fit in 'int'.
3084
3085 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3086 for command line length. Do not attempt to address one before the
3087 beginning of an array, as that's not portable.
3088
3089 * term.c (max_frame_lines): Remove; unused.
3090 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3091 not int.
3092 (encode_terminal_code, calculate_costs): Check for size
3093 calculation overflow.
3094 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3095 table lengths and related sizes. Don't update size until alloc
3096 done. Redo calculations to avoid overflow.
3097 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3098
3099 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3100 subtracting pointers.
3101 (gobble_line): Check for overflow more carefully. Don't update size
3102 until alloc done.
3103
3104 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3105 Don't update size until alloc done.
3106 Redo size calculations to avoid overflow.
3107 Check for size calculation overflow.
0065d054 3108 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3109
3110 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3111 Use ptrdiff_t, not int, for sizes.
3112 (store_mode_line_noprop_char): Don't update size until alloc done.
3113
0065d054
PE
3114 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3115 Use ptrdiff_t, not int, for sizes.
3116 (Finternal_make_lisp_face, cache_face):
3117 Check for size calculation overflow.
3118 (cache_face): Treat size calculation overflows as if they were
3119 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3120
3121 * xfns.c (x_encode_text, x_set_name_internal)
3122 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3123 sizes, since they can exceed INT_MAX in size. Check for size
3124 calculation overflow.
3125
0065d054
PE
3126 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3127 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3128 Don't update size until alloc done.
3129
0065d054 3130 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3131 as sprintf is limited to int lengths.
1d526e2f 3132
252c5ee1
PE
3133 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3134 (X_LONG_MIN): New macros.
864d7ce7
PE
3135 Use them to make the following changes clearer.
3136 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3137 This change doesn't affect the value now, but it may help remind
3138 future maintainers not to raise the value too much later.
3139 (SELECTION_QUANTUM): Remove, replacing with ...
3140 (selection_quantum): ... new function, which avoids overflow.
3141 All uses changed.
3142 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3143 assumption that selection length fits in 'int'.
3144 (x_reply_selection_request, x_handle_selection_request)
3145 (x_get_window_property, receive_incremental_selection)
3146 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3147 (lisp_data_to_selection_data, clean_local_selection_data):
3148 Use ptrdiff_t, not int, to record length of selection.
3149 (x_reply_selection_request, x_get_window_property)
3150 (receive_incremental_selection, x_property_data_to_lisp):
3151 Redo calculations to avoid overflow.
3152 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3153 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3154 something.
3155 (x_get_window_property, receive_incremental_selection)
3156 (lisp_data_to_selection_data, x_property_data_to_lisp):
3157 Check for size-calculation overflow.
3158 (x_get_window_property, receive_incremental_selection)
3159 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3160 Don't store size until memory allocation succeeds.
3161 (x_get_window_property): Plug memory leak on memory exhaustion.
3162 Don't double-block input; malloc is safe here. Don't assume 2**34
3163 - 4 fits in unsigned long. Add an xassert to check
3164 XGetWindowProperty overflow. Be more careful about overflow
3165 calculations, and distinguish size from memory overflow better.
3166 (receive_incremental_selection): When tracing, don't assume
3167 unsigned int is less than INT_MAX.
3168 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3169 harmful) conversions of unsigned short to int.
3170 (lisp_data_to_selection_data): Don't assume that integers
3171 in the range -65535 through -1 fit in an X unsigned short.
3172 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3173 result parameters unless successful. Rely on cons_to_unsigned
3174 to report problems with elements; the old code wasn't right anyway.
3175 (x_check_property_data): Check for int overflow; we cannot use
3176 a wider type due to X limits.
3177 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3178
726e0ab1 3179 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3180
0065d054
PE
3181 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3182 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3183 (x_color_cells): Don't store size until memory allocation succeeds.
3184 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3185 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3186 (x_term_init): Don't assume length fits in int (sprintf is limited
3187 to int size).
bc18e09d 3188
ebfa62c0
PE
3189 Use ptrdiff_t for composition IDs.
3190 * character.c (lisp_string_width):
3191 * composite.c (composition_table_size, n_compositions)
3192 (get_composition_id, composition_gstring_from_id):
3193 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3194 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3195 * window.c (Frecenter):
3196 Use ptrdiff_t, not int, for composition IDs.
3197 * composite.c (get_composition_id): Check for integer overflow.
3198 * composite.h: Adjust prototypes to match the above changes.
3199
d3411f89
PE
3200 Use ptrdiff_t for hash table indexes.
3201 * category.c (hash_get_category_set):
3202 * ccl.c (ccl_driver):
3203 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3204 * coding.c (coding_system_charset_list, detect_coding_system):
3205 * coding.h (struct coding_system.id):
3206 * composite.c (get_composition_id, gstring_lookup_cache):
3207 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3208 * image.c (xpm_get_color_table_h):
3209 * lisp.h (hash_lookup, hash_put):
3210 * minibuf.c (Ftest_completion):
3211 Use ptrdiff_t for hash table indexes, not int (which is too
3212 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3213 32-bit --with-wide-int hosts).
3214
e097a6fa
PE
3215 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3216 Add a FIXME comment about memory leaks.
3217 (syms_of_charset): Don't assume xmalloc returns.
3218
5637687f
PE
3219 Don't assume that stated character widths fit in int.
3220 * character.c (Fchar_width, c_string_width, lisp_string_width):
3221 * character.h (CHAR_WIDTH):
3222 * indent.c (MULTIBYTE_BYTES_WIDTH):
3223 Use sanitize_char_width to avoid undefined and/or bad behavior
3224 with outlandish widths.
a66cfb1c 3225 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3226 now that we have two such functions. All uses changed.
3227 (sanitize_char_width): New inline function.
3228
a2271ba2
PE
3229 Don't assume that tab-width fits in int.
3230 * character.h (sanitize_width): New inline function.
3231 (SANE_TAB_WIDTH): New macro.
3232 (ASCII_CHAR_WIDTH): Use it.
3233 * indent.c (sane_tab_width): Remove. All uses replaced by
3234 SANE_TAB_WIDTH (current_buffer).
3235 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3236
18c52557
PE
3237 * fileio.c: Integer overflow issues with file modes.
3238 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3239
caeeedc1
PE
3240 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3241 Remove unreachable code.
3242 (read_hex, load_charset_map_from_file): Check for integer overflow.
3243
6df6ae42 3244 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3245 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3246 (x_send_scroll_bar_event): Likewise. Check that the size does not
3247 exceed limits imposed by XClientMessageEvent, as well as the usual
3248 ptrdiff_t and size_t limits.
3249
b13995db
PE
3250 * keyboard.c: Overflow, signedness and related fixes.
3251 (make_lispy_movement): Use same integer type in forward decl
3252 that is used in the definition.
3253 (read_key_sequence, keyremap_step):
3254 Change bufsize argument back to int, undoing my 2011-03-30 change.
3255 We prefer signed types, and int is wide enough here.
3256 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3257 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3258 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3259 length, not size_t. Use ptrdiff_t for index, not int.
3260 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3261 possibility of integer overflow.
3262
13464394
PE
3263 Overflow, signedness and related fixes for images.
3264
3265 * dispextern.h (struct it.stack[0].u.image.image_id)
3266 (struct_it.image_id, struct image.id, struct image_cache.size)
3267 (struct image_cache.used, struct image_cache.ref_count):
3268 * gtkutil.c (update_frame_tool_bar):
3269 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3270 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3271 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3272 * nsmenu.m (update_frame_tool_bar):
3273 * xdisp.c (calc_pixel_width_or_height):
3274 * xfns.c (image_cache_refcount):
3275 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3276 on typical 64-bit hosts.
3277
3278 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3279 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3280 Omit unnecessary casts to int.
3281 (parse_image_spec): Check that integers fall into 'int' range
3282 when the callers expect that.
3283 (image_ascent): Redo ascent calculation to avoid int overflow.
3284 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3285 (lookup_image): Remove unnecessary tests.
3286 (xbm_image_p): Locals are now of int, not EMACS_INT,
3287 since parse_image_check makes sure they fit into int.
3288 (png_load, gif_load, svg_load_image):
3289 Prefer int to unsigned where either will do.
3290 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3291 old tiff_error_handler and tiff_warning_handler.
3292 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3293 stack buffer overflows. It uses only the features of vsnprintf
3294 that are common to both POSIX and native Microsoft.
3295 (tiff_error_handler, tiff_warning_handler): Use it.
3296 (tiff_load, gif_load, imagemagick_load_image):
3297 Don't assume :index value fits in 'int'.
3298 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3299 (imagemagick_load_image): Check that crop parameters fit into
3300 the integer types that MagickCropImage accepts. Don't assume
3301 Vimagemagick_render_type has a nonnegative value. Don't assume
3302 size_t fits in 'long'.
3303 (gs_load): Use printmax_t to print the widest integers possible.
3304 Check for integer overflow when computing image height and width.
3305
c11821d4
EZ
33062011-08-26 Eli Zaretskii <eliz@gnu.org>
3307
3308 * xdisp.c (redisplay_window): Don't force window start if point
3309 will be invisible in the resulting window. (Bug#9324)
3310
0c95fcf7
EZ
33112011-08-25 Eli Zaretskii <eliz@gnu.org>
3312
3313 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3314 the display spec is of the form `(space ...)'.
3315 (handle_display_spec): Return the value returned by
3316 handle_single_display_spec, not just 1 or zero.
3317 (handle_single_display_spec): If the display spec is of the form
3318 `(space ...)', and specifies display in the text area, return 2
3319 rather than 1.
fee65a97 3320 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3321 accurately, and prefer exact match for point under bidi.
3322 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3323
3324 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3325 into disp_prop; all users changed.
3326
3327 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3328 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3329 for the text covered by the display property.
3330
e4ed06f1
CY
33312011-08-25 Chong Yidong <cyd@stupidchicken.com>
3332
3333 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3334 Change return value to nil.
3335 (Frecord_buffer): Delete unused function.
3336
f67cdd7f
EZ
33372011-08-24 Eli Zaretskii <eliz@gnu.org>
3338
5980d4c6
EZ
3339 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3340 buffers, return left-to-right.
8610fe8b
EZ
3341 (set_cursor_from_row): Consider candidate row a win if its glyph
3342 represents a newline and point is on that newline. Fixes cursor
3343 positioning on the newline at EOL of R2L text within L2R
3344 paragraph, and vice versa.
3345 (try_cursor_movement): Check continued rows, in addition to
3346 continuation rows. Fixes unwarranted scroll when point enters a
3347 continued line of R2L text within an L2R paragraph, or vice versa.
3348 (cursor_row_p): Consider the case of point being equal to
3349 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3350 from the end of a short line to the beginning of a continued line
3351 of R2L text within L2R paragraph.
3352 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3353 composed characters.
5980d4c6 3354
f67cdd7f
EZ
3355 * bidi.c (bidi_check_type): Use xassert.
3356 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3357 members.
3358
bca633fb
EZ
33592011-08-23 Eli Zaretskii <eliz@gnu.org>
3360
3361 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3362 a character.
3363
4a5885a7
CY
33642011-08-23 Chong Yidong <cyd@stupidchicken.com>
3365
3366 * nsfont.m (ns_otf_to_script): Fix typo.
3367
0902a04e
KH
33682011-08-22 Kenichi Handa <handa@m17n.org>
3369
3370 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3371 extra slot even if the purpose is char-code-property-table.
3372
1a2e6670
EZ
33732011-08-23 Eli Zaretskii <eliz@gnu.org>
3374
8ddde651
EZ
3375 * xdisp.c (redisplay_window): When computing centering_position,
3376 account for the height of the header line. (Bug#8874)
3377
425cc014
EZ
3378 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3379 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3380 candidate is selected by the mouse, and that candidate has a
3381 composed character under the mouse.
3382
1a2e6670
EZ
3383 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3384 coordinates reported by pos-visible-in-window-p for a composed
3385 character in column zero.
3386
8b76d6f8
SM
33872011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3388
3389 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3390
dac347dd
EZ
33912011-08-22 Eli Zaretskii <eliz@gnu.org>
3392
3393 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3394 consider it a hit if to_charpos is anywhere in the range of the
3395 composed buffer positions.
3396
e013fb34
CY
33972011-08-22 Chong Yidong <cyd@stupidchicken.com>
3398
3399 * image.c (gif_load): Don't assume that each subimage has the same
3400 dimensions as the base image. Handle disposal method that is
3401 "undefined" by the gif spec (Bug#9335).
3402
bd1ba3e8
CY
34032011-08-20 Chong Yidong <cyd@stupidchicken.com>
3404
3405 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3406 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3407
54a1215b
EZ
34082011-08-19 Eli Zaretskii <eliz@gnu.org>
3409
823564e5
EZ
3410 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3411 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3412 from an Org mode buffer to a Speedbar frame.
3413
54a1215b
EZ
3414 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3415 a composition, take its buffer position from IT->cmp_it.charpos.
3416 Fixes cursor positioning at the beginning of a line that begins
3417 with a composed character.
3418
9778ebcc
EZ
34192011-08-18 Eli Zaretskii <eliz@gnu.org>
3420
0be6ee06
EZ
3421 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3422 character bidirectional type, use STRONG_L instead. Fixes crashes
3423 in a buffer produced by `describe-categories'.
3424
9778ebcc
EZ
3425 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3426 members before the level stack, so they would be saved and
3427 restored when copying iterator state. Fixes incorrect reordering
3428 around TABs covered by display properties.
3429
156bffbe
AS
34302011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3431
6b02f655 3432 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3433
72ad093b
CY
34342011-08-17 Chong Yidong <cyd@stupidchicken.com>
3435
3436 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3437 (internal_condition_case_2, internal_condition_case_n):
3438 Remove unnecessary aborts (Bug#9081).
72ad093b 3439
35774242
EZ
34402011-08-17 Eli Zaretskii <eliz@gnu.org>
3441
3442 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3443 has no `load' handler, try opening the file locally. (Bug#9311)
3444
db76dd85
KB
34452011-08-16 Ken Brown <kbrown@cornell.edu>
3446
3447 * gmalloc.c: Expand comment.
3448
b215eee5
EZ
34492011-08-16 Eli Zaretskii <eliz@gnu.org>
3450
3451 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3452 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3453
a4579d33
KB
34542011-08-16 Ken Brown <kbrown@cornell.edu>
3455
3456 Fix memory allocation problems in Cygwin build (Bug#9273).
3457
3458 * unexcw.c ( __malloc_initialized): Declare external variable.
3459 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3460
8b76d6f8
SM
3461 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3462 New variables.
a4579d33
KB
3463 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3464 dumped emacs.
3465 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3466 in the static heap.
3467 [CYGWIN] (special_realloc): New function.
3468 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3469 requests to realloc storage in the static heap.
3470
3ebec551
PE
34712011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3472
3473 * bidi.c (bidi_initialize): Remove unused local.
3474
9fd8be00
EZ
34752011-08-15 Eli Zaretskii <eliz@gnu.org>
3476
6b02f655
SM
3477 * bidimirror.h:
3478 * biditype.h: Remove file.
3479 * makefile.w32-in ($(BLD)/bidi.$(O)):
3480 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3481
3482 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3483
3484 * chartab.c: Improve commentary for the uniprop_table API.
3485
32413314
EZ
3486 * bidi.c (bidi_paragraph_init): Support zero value of
3487 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3488 (bidi_initialize): Use uniprop_table instead of including
3489 biditype.h and bidimirror.h.
32413314 3490
9fd8be00
EZ
3491 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3492 coordinates of the iterator when restoring from ppos_it.
3493 (Bug#9296)
3494
5cf2b69b
KH
34952011-08-14 Kenichi Handa <handa@m17n.org>
3496
3497 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3498 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3499
daf17d00
EZ
35002011-08-14 Eli Zaretskii <eliz@gnu.org>
3501
3502 * xdisp.c (move_it_in_display_line_to): Don't invoke
3503 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3504 ppos_it. Fixes vertical cursor motion when line beginning is
3505 covered by an image. (Bug#9296)
3506
08e3161a
JD
35072011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3508
3509 * nsterm.h (ns_run_ascript): Declare.
3510 (NSAPP_DATA2_RUNASSCRIPT): Define.
3511
3512 * nsfns.m (as_script, as_result, as_status): New static variables.
3513 (ns_run_ascript): New function.
5e617bc2 3514 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3515 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3516 the event loop. Get status from as_status (Bug#7276).
3517
3518 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3519 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3520 the event loop (Bug#7276).
3521
a3720aa2
AS
35222011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3523
3524 * gnutls.c (QCgnutls_bootprop_priority)
3525 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3526 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3527 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3528 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3529 (QCgnutls_bootprop_verify_hostname_error)
3530 (QCgnutls_bootprop_callbacks_verify): Rename from
3531 Qgnutls_bootprop_..., all uses changed.
3532
3533 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3534 uses changed.
3535
0a0d27fb
PE
35362011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3537
19d5c50c
PE
3538 * xfaces.c (Qframe_set_background_mode): Now static.
3539 * dispextern.h (Qframe_set_background_mode): Remove decl.
3540
0a0d27fb
PE
3541 * process.c (Fnetwork_interface_info): Declare local only if needed.
3542
377538cb
JD
35432011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3544
3545 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3546 (Fnetwork_interface_list): Allocate in increments of bytes instead
3547 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3548 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3549 sockaddr.
3550 (struct ifflag_def): notrailers is smart on OSX.
3551 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3552 Get hardware address with getifaddrs if available.
3553
08fff70c
EZ
35542011-08-12 Eli Zaretskii <eliz@gnu.org>
3555
3556 * xdisp.c (iterate_out_of_display_property): xassert that
3557 IT->position is set to within IT->object's boundaries. Break from
3558 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3559 when IT->position is set up wrongly due to some bug.
3560 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3561 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3562 entry. Force push_it to save on the stack the current
3563 buffer/string position, to be restored by pop_it. Fix flags in
3564 the iterator structure wrt the object coming from a display
3565 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3566 properties. (Bug#9284)
3567
7be1c708 35682011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3569
7be1c708
CY
3570 * fontset.c (fontset_get_font_group): Add proper type checks.
3571 (Bug#9172)
aac0c6e3 3572
7be1c708 35732011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3574
7be1c708
CY
3575 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3576 and LC_VERSION_MIN_MACOSX.
3577 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3578 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3579
97bb72a6
EZ
35802011-08-08 Eli Zaretskii <eliz@gnu.org>
3581
3582 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3583 no-display-properties-and-no-overlays under bidi display.
3584 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3585 properties and overlays.
97bb72a6 3586
d5617611
CY
35872011-08-08 Chong Yidong <cyd@stupidchicken.com>
3588
37e11a63
CY
3589 * editfns.c (Fset_time_zone_rule): Document relationship with the
3590 setenv function.
3591
d5617611
CY
3592 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3593 the font entity extracted from the cache (Bug#8109).
3594
58872834
CY
35952011-08-07 Chong Yidong <cyd@stupidchicken.com>
3596
3597 * composite.c (autocmp_chars): Don't reset point. That is done by
3598 restore_point_unwind (Bug#5984).
3599
75bfc667
JL
36002011-08-07 Juri Linkov <juri@jurta.org>
3601
3602 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3603 to show the arg `TIME' instead of `TIMEVAL'.
3604
d1410150
EZ
36052011-08-06 Eli Zaretskii <eliz@gnu.org>
3606
3607 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3608 display property strides EOL and includes a newline, as in
3609 longlines-mode. (Bug#9254)
75b771e4
EZ
3610 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3611 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3612
3613 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3614 is non-zero, even if the data buffer is NULL. Fixes a crash in
3615 vertical-motion with longlines-mode. (Bug#9254)
3616
35928349
EZ
36172011-08-05 Eli Zaretskii <eliz@gnu.org>
3618
ec7cc85b
EZ
3619 * bidi.c <bidi_cache_total_alloc>: Now static.
3620 (bidi_initialize): Initialize bidi_cache_total_alloc.
3621
8b76d6f8 3622 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3623 cache. (Bug#9221)
3624
3625 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3626 amount allocated this far in `bidi_cache_total_alloc'.
3627 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3628 non-zero, only free the data buffer without restoring the cache
3629 contents. All callers changed.
3630
3631 * dispextern.h (bidi_unshelve_cache): Update prototype.
3632
3633 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3634 (move_it_in_display_line, move_it_to)
3635 (move_it_vertically_backward, move_it_by_lines): Replace the call
3636 to xfree to an equivalent call to bidi_unshelve_cache.
3637 (move_it_in_display_line_to): Fix logic of returning
412b6358 3638 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3639
e2e2423b
EZ
36402011-08-05 Eli Zaretskii <eliz@gnu.org>
3641
3642 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3643 came from a string character with a `cursor' property. (Bug#9229)
3644
ae9e757a
JD
36452011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3646
3647 * Makefile.in (LIB_PTHREAD): New variable.
3648 (LIBES): Add LIB_PTHREAD (Bug#9216).
3649
3650 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3651 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3652
213bd7f2
AS
36532011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3654
6b02f655 3655 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3656
99aaf75f
JD
36572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3658
3659 * xterm.c (x_find_topmost_parent): New function.
3660 (x_set_frame_alpha): Find topmost parent window with
3661 x_find_topmost_parent and set the property there also (bug#9181).
3662 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3663
c74e9d86
PE
36642011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 * callproc.c (Fcall_process): Avoid vfork clobbering
3667 the local vars buffer, coding_systems, current_dir.
3668
640c8776
SM
36692011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3670
3671 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3672
f26d0e4c
PE
36732011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3674
8a10d76c
PE
3675 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3676 so that it is not optimized away.
3677
f26d0e4c
PE
3678 * xdisp.c (compute_display_string_pos): Remove unused local.
3679
55439c61
EZ
36802011-08-02 Eli Zaretskii <eliz@gnu.org>
3681
3682 Fix slow cursor motion and scrolling in large buffers with
3683 selective display, like Org Mode buffers. (Bug#9218)
3684
3685 * dispextern.h (struct bidi_it): New member disp_prop_p.
3686
3687 * xdisp.c: Remove one-slot cache of display string positions.
3688 (compute_display_string_pos): Accept an additional argument
5e617bc2 3689 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3690 for a display string or property. If found, set DISP_PROP_P
3691 non-zero.
3692
3693 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3694 DISP_PROP_P, and pass it to compute_display_string_pos.
3695 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3696 non-zero. All callers of bidi_fetch_char changed.
3697
fb33fa43
SM
36982011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3699
3700 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3701
b099e063
DM
37022010-12-03 Don March <don@ohspite.net>
3703
3704 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3705 last character M-[char] is translated to ESC [char] (bug#7541).
3706
5cc7f7af
KH
37072011-08-02 Kenichi Handa <handa@m17n.org>
3708
d0fffa3f 3709 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3710
3711 * chartab.c (uniprop_table): Make it non-static.
3712
525d5e6e
EZ
37132011-08-01 Eli Zaretskii <eliz@gnu.org>
3714
3715 * xdisp.c (forward_to_next_line_start): Accept additional argument
3716 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3717 on the newline.
3718 (reseat_at_next_visible_line_start): Use the bidi iterator state
3719 returned by forward_to_next_line_start to restore the state of
3720 it->bidi_it after backing up to previous newline. (Bug#9212)
3721
31011111
AS
37222011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3723
3724 * regex.c (re_comp): Protoize.
3725 (re_exec): Fix return type.
3726 (regexec): Fix type of `ret'. (Bug#9203)
3727
476371c4
PE
37282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3729
e5d76069
PE
3730 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3731 This is needed if max-image-size is a floating-point number.
3732
9a79b20c
AS
37332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3734
3735 * print.c (print_object): Print empty symbol as ##.
3736
3737 * lread.c (read1): Read ## as empty symbol.
3738
d8c2fa78
AA
37392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3740
3741 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3742 setting frame foreground color (Bug#9175).
3743 (x_set_background_color): Likewise.
3744
ffe57a7a
AA
3745 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3746 contents (Bug#9176).
3747 (EmacsTooltip -init): Remove bezels and add shadows to
3748 tooltip windows.
3749
bf3492a5
AA
3750 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3751 or scroll bar (Bug#8470).
3752
d55e9c53
AA
3753 * nsfont.m (nsfont_open): Remove assignment to voffset and
3754 unnecessary vars hshink, expand, hd, full_height, min_height.
3755 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3756
3757 * nsterm.h (nsfont_info): Remove voffset field.
3758
d8c2fa78 37592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3760
3761 Implement strike-through and overline on NextStep (Bug#8863).
3762
3763 * nsfont.m (nsfont_open): Use underline position provided by font,
3764 instead of hard-coded value of 2.
3765 (nsfont_draw): Call ns_draw_text_decoration instead.
3766
3767 * nsterm.h: Add declaration for ns_draw_text_decoration.
3768
3769 * nsterm.m (ns_draw_text_decoration): New function for drawing
3770 underline, overline, and strike-through.
3771 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3772 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3773 accommodate underlining, etc.
4843aac3 3774
4cc60b9b
EZ
37752011-07-28 Eli Zaretskii <eliz@gnu.org>
3776
bc7ece87
EZ
3777 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3778 default.
4cc60b9b 3779
476371c4
PE
37802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3781
66606eea
PE
3782 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3783 Without this fix, if a signal arrives just after memory fills up,
3784 'malloc' might be invoked reentrantly.
3785
476371c4
PE
3786 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3787 In other words, assume that every image size is allowed, on non-X
3788 hosts. This assumption is probably wrong, but it lets Emacs compile.
3789
f3fcc40d
AS
37902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3791
3792 * regex.c (re_iswctype): Convert return values to boolean.
3793
350c992f
EZ
37942011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3795
3796 * xdisp.c (compute_display_string_pos): Don't use cached display
3797 string position if the buffer had its restriction changed.
3798 (Bug#9184)
3799
5266b4bb
PE
38002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3801
3802 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3803
2573a837 38042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3805
41f55ccd 3806 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3807
39e378da
PE
3808 * bidi.c: Integer size and overflow fixes.
3809 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3810 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3811 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3812 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3813 (bidi_find_other_level_edge):
3814 Use ptrdiff_t instead of EMACS_INT where either will do.
3815 This works better on 32-bit hosts configured --with-wide-int.
3816 (bidi_cache_ensure_space): Check for size-calculation overflow.
3817 Use % rather than repeated addition, for better worst-case speed.
3818 Don't set bidi_cache_size until after xrealloc returns, because it
3819 might not return.
3820 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3821 (bidi_cache_ensure_space): Also check that the bidi cache size
3822 does not exceed that of the largest Lisp string or buffer. See Eli
3823 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3824
5e927815
PE
3825 * alloc.c (__malloc_size_t): Remove.
3826 All uses replaced by size_t. See Andreas Schwab's note
3827 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3828
ca4aa935
PE
3829 * image.c: Improve checking for integer overflow.
3830 (check_image_size): Assume that f is nonnull, since
3831 it is always nonnull in practice. This is one less thing to
3832 worry about when checking for integer overflow later.
3833 (x_check_image_size): New function, which checks for integer
3834 overflow issues inside X.
3835 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3836 This removes the need for a memory_full check.
3837 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3838 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3839 (xbm_read_bitmap_data): Change locals back to 'int', since
3840 their values must fit in 'int'.
3841 (xpm_load_image, png_load, tiff_load):
3842 Invoke x_create_x_image_and_pixmap earlier,
3843 to avoid much needless work if the image is too large.
3844 (tiff_load): Treat overly large images as if
3845 x_create_x_image_and_pixmap failed, not as malloc failures.
3846 (gs_load): Use x_check_image_size.
3847
5f8f9cc2
PE
3848 * gtkutil.c: Omit integer casts.
3849 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3850 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3851
5adf60bc
PE
3852 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3853
c8907a93
PE
3854 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3855 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3856 would wrongly return t on a 64-bit host.
3857
e3c25c68
PE
3858 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3859 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3860 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3861 and therefore cause GCC to emit a bogus diagnostic in some cases.
3862
3f791afe
PE
3863 * image.c: Integer signedness and overflow and related fixes.
3864 This is not an exhaustive set of fixes, but it's time to
3865 record what I've got.
3866 (lookup_pixel_color, check_image_size): Remove redundant decls.
3867 (check_image_size): Don't assume that arbitrary EMACS_INT values
3868 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3869 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3870 (tiff_load, imagemagick_load_image):
3871 Check for overflow in size calculations.
3872 (x_create_x_image_and_pixmap): Remove unnecessary test for
3873 xmalloc returning NULL; that can't happen.
3874 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3875 (xpm_color_bucket): Use better integer hashing function.
3876 (xpm_cache_color): Don't possibly over-allocate memory.
3877 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3878 (gif_memory_source):
3879 Use ptrdiff_t, not int or size_t, to record sizes.
3880 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3881 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3882 either works, as we prefer signed integers.
3883 (tiff_read_from_memory, tiff_write_from_memory):
3884 Return tsize_t, not size_t, since that's what the TIFF API wants.
3885 (tiff_read_from_memory): Don't fail simply because the read would
3886 go past EOF; instead, return a short read.
3887 (tiff_load): Omit no-longer-needed casts.
3888 (Fimagemagick_types): Don't assume size fits into 'int'.
3889
3cc5a532
PE
3890 Improve hashing quality when configured --with-wide-int.
3891 * fns.c (hash_string): New function, taken from sxhash_string.
3892 Do not discard information about ASCII character case; this
3893 discarding is no longer needed.
3894 (sxhash-string): Use it. Change sig to match it. Caller changed.
3895 * lisp.h: Declare it.
3896 * lread.c (hash_string): Remove, since we now use fns.c's version.
3897 The fns.c version returns a wider integer if --with-wide-int is
3898 specified, so this should help the quality of the hashing a bit.
3899
b312a492
PE
3900 * emacs.c: Integer overflow minor fix.
3901 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3902 Define only if GNU_LINUX.
3903 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3904
dfd153ae
PE
3905 * dispnew.c: Integer signedness and overflow fixes.
3906 Remove unnecessary forward decls, that were a maintenance hassle.
3907 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3908 All uses changed.
3909 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3910 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3911 (prepare_desired_row, line_draw_cost):
3912 Use int, not unsigned, where either works.
3913 (save_current_matrix, restore_current_matrix):
3914 Use ptrdiff_t, not size_t, where either works.
3915 (init_display): Check for overflow more accurately, and without
3916 relying on undefined behavior.
3917
a81d11a3
PE
3918 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3919 Remove, replacing with the new symbols in lisp.h. All uses changed.
3920 * fileio.c (make_temp_name):
3921 * filelock.c (lock_file_1, lock_file):
3922 * xdisp.c (message_dolog):
3923 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3924 Use pMd etc. instead.
3925 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3926 replacing the pWIDE etc. symbols removed from editfns.c.
3927
3300e6fd
PE
3928 * keyboard.h (num_input_events): Now uintmax_t.
3929 This is (very slightly) less likely to mess up due to wraparound.
3930 All uses changed.
3931
fd05c7e9
PE
3932 * buffer.c: Integer signedness fixes.
3933 (alloc_buffer_text, enlarge_buffer_text):
3934 Use ptrdiff_t rather than size_t when either will do, as we prefer
3935 signed integers.
3936
903fe15d
PE
3937 * alloc.c: Integer signedness and overflow fixes.
3938 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3939 (__malloc_size_t): Default to size_t, not to int.
3940 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3941 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3942 Prefer ptrdiff_t to size_t when either would do, as we prefer
3943 signed integers.
3944 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3945 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3946 Now const. Initialize with values that are in range even if char
3947 is signed.
3948 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3949 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3950 These functions do the right thing with sizes > 2**32.
3951 (check_depth): Now ptrdiff_t, not int.
3952 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3953 Adjust to new way of storing sizes. Check for size overflow bugs
3954 in rest of code.
3955 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3956 slightly wrong anyway, as it missed one instance of
3957 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3958 (refill_memory_reserve): Omit needless cast to size_t.
3959 (mark_object_loop_halt): Mark as externally visible.
3960
ac82cc6a
PE
3961 * xselect.c: Integer signedness and overflow fixes.
3962 (Fx_register_dnd_atom, x_handle_dnd_message):
3963 Use ptrdiff_t, not size_t, since we prefer signed.
3964 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3965 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3966 x_dnd_atoms_size and x_dnd_atoms_length.
3967
c2d1e36d
PE
3968 * doprnt.c: Prefer signed to unsigned when either works.
3969 * eval.c (verror):
3970 * doprnt.c (doprnt):
3971 * lisp.h (doprnt):
3972 * xdisp.c (vmessage):
3973 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3974 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3975 prefer signed arithmetic to avoid comparison confusion.
3976 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3977 but is a bit tricky.
3978
0e926e56
PE
3979 Assume freestanding C89 headers, string.h, stdlib.h.
3980 * data.c, doprnt.c, floatfns.c, print.c:
3981 Include float.h unconditionally.
3982 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3983 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3984 * regex.c: Likewise for stddef.h, string.h.
3985 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3986 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3987 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3988 (STDC_HEADERS): Remove obsolete defines.
3989 * sysdep.c: Include limits.h unconditionally.
3990
9cfdb3ec
PE
3991 Assume support for memcmp, memcpy, memmove, memset.
3992 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3993 * regex.c (memcmp, memcpy):
3994 Remove; we assume C89 now.
3995
3996 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3997 (__malloc_safe_bcopy): Remove; no longer needed.
3998
cf950e6b 3999 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4000 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4001 well either way, and we prefer signed to unsigned.
4002
dbf38e02
LMI
40032011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4004
4005 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4006 closes the connection while we're reading (bug#9182).
4007
d6f0886c 40082011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4009
d6f0886c
JD
4010 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4011 are specified (Bug#9168).
24e0f6b1 4012
2eb1f9e6
PE
40132011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4014
4015 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4016 Found by GCC static checking and --with-wide-int on a 32-bit host.
4017
22381272 40182011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4019
4020 * xdisp.c (compute_display_string_pos): Fix logic of caching
4021 previous display string position. Initialize cached_prev_pos to
4022 -1. Fixes slow-down at the beginning of a buffer.
4023
f25e39b4
EZ
40242011-07-24 Eli Zaretskii <eliz@gnu.org>
4025
4026 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4027 for attrs[LFACE_FONTSET_INDEX].
4028
04c4b52e
PE
40292011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 * xml.c (parse_region): Remove unused local
4032 that was recently introduced.
4033
c1734fbd
EZ
40342011-07-23 Eli Zaretskii <eliz@gnu.org>
4035
be18c5a5
EZ
4036 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4037 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4038
c1734fbd
EZ
4039 * xdisp.c (move_it_in_display_line_to): Record the best matching
4040 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4041 exit if none of the characters scanned was an exact match.
4042 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4043 when exact match is impossible due to invisible text, and the
4044 lines are truncated.
4045
a258d627
JD
40462011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4047
4048 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4049 for OSX >= 10.7.
4050
b6d5a689
EZ
40512011-07-22 Eli Zaretskii <eliz@gnu.org>
4052
0f74f785
EZ
4053 Fix a significant slow-down of cursor motion with C-n, C-p,
4054 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4055 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4056 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4057 (next_element_from_buffer): Call compute_stop_pos_backwards to
4058 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4059 base_level_stop.
4060 (reseat): Don't look for prev_stop, as that could mean a very long
4061 run.
4062 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4063 <cached_disp_overlay_modiff>: Cache for last found display string
4064 position.
551918c1 4065 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4066 about the same buffer in the same area of character positions, and
4067 the buffer wasn't changed since the time the display string
4068 position was cached.
551918c1 4069
b2d0c91a
EZ
40702011-07-22 Eli Zaretskii <eliz@gnu.org>
4071
4072 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4073 is an integer, which is important for empty lines. (Bug#9149)
4074
043604ee
CY
40752011-07-22 Chong Yidong <cyd@stupidchicken.com>
4076
4077 * frame.c (Fmodify_frame_parameters): In tty case, update the
4078 default face if necessary (Bug#4238).
4079
da4adb04
CY
40802011-07-21 Chong Yidong <cyd@stupidchicken.com>
4081
4082 * editfns.c (Fstring_to_char): No need to explain what a character
4083 is in the docstring (Bug#6576).
4084
9abd0532
LMI
40852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4086
4087 * xml.c (parse_region): Make sure we always return a tree.
4088
36881d16
HK
40892011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4090
4091 * xml.c (parse_region): If a document contains only comments,
4092 return that, too.
4093
1e98674d
LMI
40942011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4095
4096 * xml.c (make_dom): Return comments, too.
4097
590bd467
PE
40982011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 Port to OpenBSD.
4101 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4102 and the surrounding thread.
4103 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4104 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4105 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4106 timer goes off.
4107 * s/openbsd.h (BROKEN_SIGIO): Define.
4108 * unexelf.c (unexec) [__OpenBSD__]:
4109 Don't update the .mdebug section of the Alpha COFF symbol table.
4110
f41628b2
LMI
41112011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4112
4113 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4114 (bug#8460).
4115
b59b67c5
PE
41162011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4117
15e3a074
PE
4118 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4119 This fixes some race conditions on the permissions of any newly
4120 created file.
4121
41bed37d
PE
4122 * alloc.c (valid_pointer_p): Use pipe, not open.
4123 This fixes some permissions issues when debugging.
4124
b59b67c5
PE
4125 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4126 If fchown fails to set both uid and gid, try to set just gid,
4127 as that is sometimes allowed. Adjust the file's mode to eliminate
4128 setuid or setgid bits that are inappropriate if fchown fails.
4129
925a6be7
SM
41302011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4131
4132 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4133 to compare Lisp_Objects.
4134 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4135 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4136 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4137
52968808
AS
41382011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4139
0a6a104b
AS
4140 * lread.c (read_integer): Unread even EOF character.
4141 (read1): Likewise. Properly record start position of symbol.
4142
52968808
AS
4143 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4144 symbol character follows.
4145
9e381cdd
PE
41462011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4149 This works around a problem with the previous change to Fcopy_file.
4150 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4151 and without this change, GCC might complain about discarding
4152 fchown's return value.
4153
b5641435
JB
41542011-07-16 Juanma Barranquero <lekktu@gmail.com>
4155
4156 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4157
a8031457
PE
41582011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4159
4160 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4161
dd889327
LMI
41622011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163
750c33f7
LMI
4164 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4165 it's used from the C level.
4166
dd889327
LMI
4167 * process.c: Use the same condition for POLL_FOR_INPUT in both
4168 keyboard.c and process.c (bug#1858).
4169
87e86684
LM
41702011-07-09 Lawrence Mitchell <wence@gmx.li>
4171
4172 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4173 (Fgnutls_boot): Use it.
4174
64348f40
AS
41752011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4176
4177 * doc.c (Fsubstitute_command_keys): Revert last change.
4178
1d698799
LMI
41792011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4180
f863868c
LMI
4181 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4182 quotes the next character, and doesn't affect other longer
4183 sequences (bug#8935).
4184
1d698799
LMI
4185 * lread.c (syms_of_lread): Clarify that is isn't only
4186 `eval-buffer' and `eval-defun' that's affected by
4187 `lexical-binding' (bug#8460).
4188
aa4b6df6
EZ
41892011-07-15 Eli Zaretskii <eliz@gnu.org>
4190
4191 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4192 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4193
5d856da6
PE
41942011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4195
ad6042bb
PE
4196 Fix minor problems found by static checking.
4197 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4198 (elsz): Now a signed constant, not a size_t var. We prefer signed
4199 types to unsigned, to avoid integer comparison confusion. Without
4200 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4201 "cannot optimize loop, the loop counter may overflow", a symptom
4202 of the confusion.
f00bbb22 4203 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4204 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4205
6468f31c
LMI
42062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4207
49080b10
LMI
4208 * search.c (Fre_search_backward): Mention `case-fold-search' in
4209 all the re_search_* functions (bug#8138).
4210
6468f31c
LMI
4211 * keyboard.c (Fopen_dribble_file): Document when the file is
4212 closed (bug#8056).
4213
c965adc5
EZ
42142011-07-14 Eli Zaretskii <eliz@gnu.org>
4215
df9733bf
EZ
4216 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4217 bidi_cache_idx.
4218
0bb23927
EZ
4219 Support bidi reordering of display and overlay strings.
4220 * xdisp.c (compute_display_string_pos)
4221 (compute_display_string_end): Accept additional argument STRING.
4222 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4223 (reseat_to_string): Initialize bidi_it->string.s and
4224 bidi_it->string.schars.
4225 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4226 NULL (avoids a crash in bidi_paragraph_init).
4227 Initialize itb.string.lstring.
0bb23927
EZ
4228 (init_iterator): Call bidi_init_it only of a valid
4229 buffer position was specified. Initialize paragraph_embedding to
4230 L2R.
4231 (reseat_to_string): Initialize the bidi iterator.
4232 (display_string): If we need to ignore text properties of
4233 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4234 original value of -1 will not work with bidi.)
4235 (compute_display_string_pos): First arg is now struct
4236 `text_pos *'; all callers changed. Support display properties on
4237 Lisp strings.
4238 (compute_display_string_end): Support display properties on Lisp
4239 strings.
4240 (init_iterator, reseat_1, reseat_to_string): Initialize the
4241 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4242 when iterating on a string not from display properties).
640c8776
SM
4243 (compute_display_string_pos, compute_display_string_end):
4244 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4245 arrow keys.
4246 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4247 base_level_stop; instead, set base_level_stop to BEGV.
4248 Fixes crashes in vertical-motion.
0bb23927
EZ
4249 (next_element_from_buffer): Improve commentary for when
4250 the iterator is before prev_stop.
4251 (init_iterator): Initialize bidi_p from the default value of
4252 bidi-display-reordering, not from buffer-local value. Use the
4253 buffer-local value only if initializing for buffer iteration.
4254 (handle_invisible_prop): Support invisible properties on strings
4255 that are being bidi-reordered.
4256 (set_iterator_to_next): Support bidi reordering of C strings and
4257 Lisp strings.
4258 (next_element_from_string): Support bidi reordering of Lisp
4259 strings.
4260 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4261 (display_string): Support display of R2L glyph rows.
4262 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4263 (init_iterator): Don't initialize it->bidi_p for strings
4264 here.
4265 (reseat_to_string): Initialize it->bidi_p for strings here.
4266 (next_element_from_string, next_element_from_c_string)
4267 (next_element_from_buffer): Add xassert's for correspondence
4268 between IT's object being iterated and it->bidi_it.string
4269 structure.
4270 (face_before_or_after_it_pos): Support bidi iteration.
4271 (next_element_from_c_string): Handle the case of the first string
4272 character that is not the first one in the visual order.
4273 (get_visually_first_element): New function, refactored from common
4274 parts of next_element_from_buffer, next_element_from_string, and
4275 next_element_from_c_string.
4276 (tool_bar_lines_needed, redisplay_tool_bar)
4277 (display_menu_bar): Force left-to-right direction. Add a FIXME
4278 comment for making that be controlled by a user option.
4279 (push_it, pop_it): Save and restore the state of the
4280 bidi iterator. Save and restore the bidi_p flag.
4281 (pop_it): Iterate out of display property for string iteration as
4282 well.
4283 (iterate_out_of_display_property): Support iteration over strings.
4284 (handle_single_display_spec): Set up it->bidi_it for iteration
4285 over a display string, and call bidi_init_it.
4286 (handle_single_display_spec, next_overlay_string)
4287 (get_overlay_strings_1, push_display_prop): Set up the bidi
4288 iterator for displaying display or overlay strings.
4289 (forward_to_next_line_start): Don't use the shortcut if
4290 bidi-iterating.
4291 (back_to_previous_visible_line_start): If handle_display_prop
4292 pushed the iterator stack, restore the internal state of the bidi
4293 iterator by calling bidi_pop_it same number of times.
4294 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4295 and we are bidi-iterating, don't decrement the iterator position;
4296 instead, set the first_elt flag in the bidi iterator, to produce
4297 the same effect.
4298 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4299 (push_display_prop): xassert that we are iterating a buffer.
4300 (push_it, pop_it): Save and restore paragraph_embedding member.
4301 (handle_single_display_spec, next_overlay_string)
4302 (get_overlay_strings_1, reseat_1, reseat_to_string)
4303 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4304 correctly. Don't assume unibyte strings are not bidi-reordered.
4305 (compute_display_string_pos)
4306 (compute_display_string_end): Fix handling the case of C string.
4307 (push_it, pop_it): Save and restore from_disp_prop_p.
4308 (handle_single_display_spec, push_display_prop): Set the
4309 from_disp_prop_p flag.
4310 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4311 (pop_it): Call iterate_out_of_display_property only if we are
4312 popping after iteration over a string that came from a display
4313 property. Fix a typo in popping stretch info. Add an assertion
4314 for verifying that the iterator position is in sync with the bidi
4315 iterator.
4316 (handle_single_display_spec, get_overlay_strings_1)
4317 (push_display_prop): Fix initialization of paragraph direction for
4318 string when that of the parent object is not yet determined.
4319 (reseat_1): Call bidi_init_it to resync the bidi
4320 iterator with IT's position. (Bug#7616)
4321 (find_row_edges): If ROW->start.pos gives position
4322 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4323 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4324 Reset the from_disp_prop_p flag.
4325 (SAVE_IT, RESTORE_IT): New macros.
4326 (pos_visible_p, face_before_or_after_it_pos)
4327 (back_to_previous_visible_line_start)
4328 (move_it_in_display_line_to, move_it_in_display_line)
4329 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4330 (try_scrolling, redisplay_window, display_line): Use them when
4331 saving a temporary copy of the iterator and restoring it back.
4332 (back_to_previous_visible_line_start, reseat_1)
4333 (init_iterator): Empty the bidi cache "stack".
4334 (move_it_in_display_line_to): If iterator ended up at
4335 EOL, but we never saw any buffer positions smaller than
4336 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4337 motion in bidi-reordered lines.
4338 (move_it_in_display_line_to): Record prev_method and prev_pos
4339 immediately before the call to set_iterator_to_next. Fixes cursor
4340 motion in bidi-reordered lines with stretch glyphs and strings
4341 displayed in margins. (Bug#8133) (Bug#8867)
4342 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4343 TO_CHARPOS.
640c8776
SM
4344 (pos_visible_p): Support positions in bidi-reordered lines.
4345 Save and restore bidi cache.
0bb23927
EZ
4346
4347 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4348 (bidi_paragraph_info): Delete unused struct.
4349 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4350 (bidi_cache_start): New variable.
4351 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4352 to zero.
4353 (bidi_cache_fetch_state, bidi_cache_search)
4354 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4355 (bidi_cache_find, bidi_peek_at_next_level)
4356 (bidi_level_of_next_char, bidi_find_other_level_edge)
4357 (bidi_move_to_visually_next): Compare cache index with
4358 bidi_cache_start rather than with zero.
4359 (bidi_fetch_char): Accept new argument STRING; all callers
4360 changed. Support iteration over a string. Support strings with
4361 display properties. Support unibyte strings. Fix the type of
4362 `len' according to what STRING_CHAR_AND_LENGTH expects.
4363 (bidi_paragraph_init, bidi_resolve_explicit_1)
4364 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4365 (bidi_level_of_next_char, bidi_move_to_visually_next):
4366 Support iteration over a string.
0bb23927
EZ
4367 (bidi_set_sor_type, bidi_resolve_explicit_1)
4368 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4369 can now be zero (for strings); special values 0 and -1 were
4370 changed to -1 and -2, respectively.
4371 (bidi_char_at_pos): New function.
4372 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4373 Call it instead of FETCH_MULTIBYTE_CHAR.
4374 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4375 initialized to valid values.
4376 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4377 values.
4378 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4379 the test for valid cached positions. Fix the logic for looking up
4380 the sentinel state in the cache. GCPRO the Lisp string we are
4381 iterating.
4382 (bidi_push_it, bidi_pop_it): New functions.
4383 (bidi_initialize): Initialize the bidi cache start stack pointer.
4384 (bidi_cache_ensure_space): New function, refactored from part of
4385 bidi_cache_iterator_state. Don't assume the required size is just
4386 one BIDI_CACHE_CHUNK away.
4387 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4388 (bidi_count_bytes, bidi_char_at_pos): New functions.
4389 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4390 always valid if bidi_cache_idx is valid.
4391 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4392 is valid if it's going to be used.
4393 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4394 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4395 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4396 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4397 (bidi_find_other_level_edge, bidi_cache_start_stack):
4398 All variables related to cache indices are now EMACS_INT.
c965adc5 4399
0bb23927
EZ
4400 * dispextern.h (struct bidi_string_data): New structure.
4401 (struct bidi_it): New member `string'. Make flag members be 1-bit
4402 fields, and put them last in the struct.
640c8776
SM
4403 (compute_display_string_pos, compute_display_string_end):
4404 Update prototypes.
0bb23927
EZ
4405 (bidi_push_it, bidi_pop_it): Add prototypes.
4406 (struct iterator_stack_entry): New members bidi_p,
4407 paragraph_embedding, and from_disp_prop_p.
4408 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4409 (bidi_shelve_cache, bidi_unshelve_cache):
4410 Declare prototypes.
0bb23927
EZ
4411
4412 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4413 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4414 and vector-like objects.
4415
4416 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4417 cache around display iteration.
4418
4419 * window.c (Fwindow_end, window_scroll_pixel_based)
4420 (displayed_window_lines, Frecenter): Save and restore the bidi
4421 cache around display iteration.
4422
3bbd2265
LMI
44232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4424
4425 * editfns.c (Fdelete_region): Clarify the use of the named
4426 parameters (bug#6788).
4427
adc47434
MR
44282011-07-14 Martin Rudalics <rudalics@gmx.at>
4429
4430 * indent.c (Fvertical_motion): Set and restore w->pointm when
4431 saving and restoring the window's buffer (Bug#9006).
4432
837c31f8
LMI
44332011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4434
4435 * editfns.c (Fstring_to_char): Clarify just what is returned
4436 (bug#6576). Text by Eli Zaretskii.
4437
ac389d0c
JB
44382011-07-13 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4441
0be0ce47
EZ
44422011-07-13 Eli Zaretskii <eliz@gnu.org>
4443
4444 * buffer.c (mmap_find): Fix a typo.
4445
cd18e7e3
JB
44462011-07-13 Johan Bockgård <bojohan@gnu.org>
4447
4448 Fix execution of x selection hooks.
4449 * xselect.c (Qx_lost_selection_functions)
4450 (Qx_sent_selection_functions): New vars.
4451 (syms_of_xselect): DEFSYM them.
4452 (x_handle_selection_request): Pass Qx_sent_selection_functions
4453 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4454 (x_handle_selection_clear,x_clear_frame_selections):
4455 Pass Qx_lost_selection_functions rather than
4456 Vx_lost_selection_functions to Frun_hook_with_args.
4457
47ea7f44
PE
44582011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4459
ac389d0c 4460 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4461 The old code sometimes used this field without initializing it.
4462
47ea7f44
PE
4463 * alloc.c (gc_sweep): Don't read past end of array.
4464 In theory, the old code could also have corrupted Emacs internals,
4465 though it'd be very unlikely.
4466
bc985c87
AS
44672011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4468
4469 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4470 argument. (Bug#4026)
bc985c87 4471
0cf34688
LMI
44722011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4473
b3dadd76
LMI
4474 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4475 key" (bug#4257).
4476
0cf34688
LMI
4477 * window.c (Fset_window_start): Doc fix (bug#4199).
4478 (Fset_window_hscroll): Ditto.
4479
270768cd
PE
44802011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4481
077e3dda 4482 Fix minor new problems caught by GCC 4.6.1.
270768cd 4483 * term.c (init_tty): Remove unused local.
490011a6 4484 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4485 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4486 not used otherwise.
270768cd 4487
b1f58454
CY
44882011-07-12 Chong Yidong <cyd@stupidchicken.com>
4489
4490 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4491
22b9578d
LMI
44922011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4493
6e70ab07
LMI
4494 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4495 are the mini-buffer and the echo area (bug#3320).
4496
22b9578d
LMI
4497 * term.c (init_tty): Remove support for supdup, c10 and perq
4498 terminals, which are no longer supported (bug#1482).
4499
8974cc9f
JB
45002011-07-10 Johan Bockgård <bojohan@gnu.org>
4501
4502 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4503
a560d974
JD
45042011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4505
4506 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4507 for non-popups (Bug#3642).
4508
1dae0f0a
AS
45092011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4510
268c2c36 4511 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4512 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4513 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4514 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4515 * data.c (fmod): Likewise.
4516 * dispnew.c (swap_glyphs_in_rows): Likewise.
4517 * emacs.c (memory_warning_signal): Likewise.
4518 * floatfns.c (float_error): Likewise.
4519 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4520 (otf_open, font_otf_capability, generate_otf_features)
4521 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4522 Likewise.
4523 * image.c (pbm_read_file): Likewise.
4524 * indent.c (string_display_width): Likewise.
4525 * intervals.c (check_for_interval, search_for_interval)
4526 (inc_interval_count, count_intervals, root_interval)
4527 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4528 * lread.c (defalias): Likewise.
268c2c36 4529 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4530 * regex.c (set_image_of_range_1, set_image_of_range)
4531 (regex_grow_registers): Likewise.
4532 * sysdep.c (strerror): Likewise.
4533 * termcap.c (valid_filename_p, tprint, main): Likewise.
4534 * tparam.c (main): Likewise.
4535 * unexhp9k800.c (run_time_remap, save_data_space)
4536 (update_file_ptrs, read_header, write_header, calculate_checksum)
4537 (copy_file, copy_rest, display_header): Likewise.
4538 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4539 Likewise.
4540 * xdisp.c (check_it): Likewise.
4541 * xfaces.c (register_color, unregister_color, unregister_colors):
4542 Likewise.
4543 * xfns.c (print_fontset_result): Likewise.
4544 * xrdb.c (member, fatal, main): Likewise.
4545
99033785
PE
45462011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 Fix minor problems found by static checking (Bug#9031).
4549 * chartab.c (char_table_set_range, map_sub_char_table):
4550 Remove unused locals.
4551 (uniprop_table): Now static.
4552 * composite.c (_work_char): Remove unused static var.
4553
9cb2ac56
JB
45542011-07-09 Juanma Barranquero <lekktu@gmail.com>
4555
4556 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4557
f25661f0
JD
45582011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4559
4560 * gtkutil.c (qttip_cb): Remove code without function.
4561
8278c4fe
EZ
45622011-07-09 Eli Zaretskii <eliz@gnu.org>
4563
4564 * w32.c (pthread_sigmask): New stub.
4565
1692ae2d 45662011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4567
8a6ebd58 4568 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4569 sigprocmask is portable only for single-threaded applications, and
4570 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4571 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4572 (LIBES): Use it.
4573 * callproc.c (Fcall_process):
4574 * process.c (create_process):
4575 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4576 Use pthread_sigmask, not sigprocmask.
123403e4 4577
1b854618
JD
45782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4579
4580 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4581 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4582 wrong (Bug#8591).
4583
3fe4b549
JD
45842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4585
0ce7e563
JD
4586 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4587 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4588 (xg_hide_tooltip): Fix comment.
4589
3fe4b549
JD
4590 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4591 in registerServicesMenuSendTypes.
4592 (validRequestorForSendType): Don't check ns_return_types.
4593
4594 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4595 ns_return_type.
4596
5df75e47
JR
45972011-07-08 Jason Rumney <jasonr@gnu.org>
4598
22610910
JR
4599 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4600 SH_SHOW for hidden windows (Bug#5482).
4601
5df75e47
JR
4602 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4603 frame struct members of non-existent frames (Bug#6284).
4604
699c10bd
JD
46052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4606
4393663b
JD
4607 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4608 variable firstTime not needed on OSX >= 10.6.
4609 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4610 >= 10.5. Use setKnobProportion, setDoubleValue.
4611
4612 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4613 (MAC_OS_X_VERSION_10_5): Define if not defined.
4614 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4615 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4616 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4617
4618 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4619 cString and lossyCString on OSX >= 10.4
4620
58179cce 4621 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4622 sizeToFit on OSX >= 10.2.
4623
4624 * nsimage.m (allocInitFromFile): Don't use deprecated method
4625 bestRepresentationForDevice on OSX >= 10.6.
4626
4627 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4628 to avoid warning.
4629
4630 * emacs.c: Declare unexec_init_emacs_zone.
4631
a63e0781
JD
4632 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4633
699c10bd
JD
4634 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4635
4636 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4637 on svcsMenu (Bug#8842).
4638
4639 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4640 ns_return_types.
4641 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4642
4643 * nsterm.m (QUTF8_STRING): Declare.
4644 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4645 (validRequestorForSendType): Return type is (id).
4646 Change indexOfObjectIdenticalTo to indexOfObject.
4647 Check if we have local selection before returning self (Bug#8842).
4648 (writeSelectionToPasteboard): Put local selection into paste board
4649 if we have a local selection (Bug#8842).
4650 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4651
4652 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4653 (ns_get_local_selection): Declare.
4654
54e10184
LMI
46552011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4656
9888ff71
LMI
4657 * keymap.c (describe_map_tree): Don't insert a double newline at
4658 the end of the buffer (bug#1169) and return whether we inserted
4659 something.
4660
54e10184
LMI
4661 * callint.c (Fcall_interactively): Change "reading args" to
4662 "providing args" to try to clarify what it does (bug#1010).
4663
15fa4783
KH
46642011-07-07 Kenichi Handa <handa@m17n.org>
4665
4666 * composite.c (composition_compute_stop_pos): Ignore a static
4667 composition starting before CHARPOS (Bug#8915).
4668
4669 * xdisp.c (handle_composition_prop): Likewise.
4670
a8815b00
EZ
46712011-07-07 Eli Zaretskii <eliz@gnu.org>
4672
4673 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4674 (Bug#9015)
4675
ef7b981d 46762011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4677
4678 * character.h (unicode_category_t): New enum type.
4679
4680 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4681 (Qchar_code_property_table): New variable.
4682 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4683 (UNIPROP_COMPRESSED_FORM_P): New macros.
4684 (char_table_ascii): Uncompress the compressed values.
4685 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4686 Uncompress the compressed values.
ac389d0c 4687 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4688 (char_table_ref_and_range): Uncompress the compressed values.
4689 (sub_char_table_set): New arg is_uniprop. Callers changed.
4690 Uncompress the compressed values.
4691 (sub_char_table_set_range): Args changed. Callers changed.
4692 (char_table_set_range): Adjuted for the above change.
4693 (map_sub_char_table): Delete args default_val and parent. Add arg
4694 top. Give decoded values to a Lisp function.
640c8776 4695 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4696 values to a Lisp function. Gcpro more variables.
4697 (uniprop_table_uncompress)
4698 (uniprop_decode_value_run_length): New functions.
4699 (uniprop_decoder, uniprop_decoder_count): New variables.
4700 (uniprop_get_decoder, uniprop_encode_value_character)
4701 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4702 New functions.
4703 (uniprop_encoder, uniprop_encoder_count): New variables.
4704 (uniprop_get_encoder, uniprop_table)
4705 (Funicode_property_table_internal, Fget_unicode_property_internal)
4706 (Fput_unicode_property_internal): New functions.
4707 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4708 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4709 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4710 char-code-property-alist.
4711
640c8776 4712 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4713 Vunicode_category_table.
4714
640c8776 4715 * font.c (font_range): Adjust for the change of
c805dec0
KH
4716 Vunicode_category_table.
4717
76b397fb
DN
47182011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4719
4720 * m/iris4d.h: Remove file, move contents ...
4721 * s/irix6-5.h: ... here.
4722
22b4128e
PE
47232011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4726 * alloc.c (mark_buffer):
4727 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4728 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4729 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4730 This isn't true in general, and it's particularly not true
4731 if Emacs is configured with --with-wide-int.
4732 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4733 New macros, used in the buffer.c change.
4734
869795d6
JD
47352011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4736
4737 * xsettings.c: Use both GConf and GSettings if both are available.
4738 (store_config_changed_event): Add comment.
4739 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4740 (store_tool_bar_style_changed): New functions.
5e617bc2 4741 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4742 (struct xsettings): Move font inside HAVE_XFT.
4743 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4744 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4745 Move inside HAVE_XFT.
640c8776 4746 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4747 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4748 also.
4749 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4750 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4751 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4752 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4753 (parse_settings): Move check for font inside HAVE_XFT.
4754 (read_settings, apply_xft_settings): Add comment.
4755 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4756 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4757 call store_font_name_changed.
4758 (xft_settings_event): Add comment.
4759 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4760 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4761 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4762 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4763 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4764 (xsettings_get_system_font, xsettings_get_system_normal_font):
4765 Add comment.
869795d6 4766
d8ed26bd
PE
47672011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4768
4769 Random fixes. E.g., (random) never returned negative values.
4770 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4771 subseconds part to the entropy, as that's a bit more random.
4772 Prefer signed to unsigned, since the signedness doesn't matter and
4773 in general we prefer signed. When given a limit, use a
4774 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4775 latter isn't right if USE_2_TAGS_FOR_INTS.
4776 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4777 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4778
cabf1cac
SM
47792011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4780
4781 * textprop.c (text_property_stickiness):
4782 Obey Vtext_property_default_nonsticky.
4783 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4784 * w32fns.c (syms_of_w32fns):
4785 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4786
6e9b2be9
PE
47872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4788
4789 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4790 This is more efficient than Ffile_directory_p and avoids a minor race.
4791
90186c68
LMI
47922011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4793
7c301272
LMI
4794 * buffer.c (Foverlay_put): Say what the return value is
4795 (bug#7835).
4796
c4f2d8d4
LMI
4797 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4798 is a directory before asking whether to use the file name
4799 (bug#7564).
ad637907
LMI
4800 (barf_or_query_if_file_exists): Make the "File is a directory"
4801 error be more correct.
c4f2d8d4 4802
90186c68
LMI
4803 * fns.c (Frequire): Remove the mention of the .gz files, since
4804 that's installation-specific, but keep the mention of
4805 `get-load-suffixes'.
4806
da64016e
PE
48072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4810 Report string overflow if the output is too long.
4811
7d47b580
JB
48122011-07-04 Juanma Barranquero <lekktu@gmail.com>
4813
a555cb87
JB
4814 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4815 (syms_of_gnutls): Remove duplicate DEFSYM for
4816 Qgnutls_bootprop_verify_hostname_error, an error for
4817 Qgnutls_bootprop_verify_error (which is no longer used).
4818
7d47b580
JB
4819 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4820 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4821 Also (re)move comments that are misplaced or no longer relevant.
4822
1e49bfab
LMI
48232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4824
4825 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4826
1485f4c0
CY
48272011-07-03 Chong Yidong <cyd@stupidchicken.com>
4828
4829 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4830 and background color parameters if they have been changed.
4831
a9ab721e
LMI
48322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4833
4834 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4835
cf7cff57
PE
48362011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4837
2e13213d
PE
4838 * xsettings.c (SYSTEM_FONT): Define only when used.
4839 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4840
cf7cff57
PE
4841 * keymap.c (access_keymap_1): Now static.
4842
7a8e04f7
CY
48432011-07-02 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4846 leave any prefix arg for the up event (Bug#1586).
4847
61352f62
LMI
48482011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4849
69bb1ef7
LMI
4850 * lread.c (syms_of_lread): Mention single symbols defined by
4851 `defvar' or `defconst' (bug#7154).
4852
61352f62 4853 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4854 (Frequire): Mention get-load-suffixes.
61352f62 4855
28545e04
MR
48562011-07-02 Martin Rudalics <rudalics@gmx.at>
4857
4858 * window.h (window): Remove clone_number slot.
4859 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4860 Remove.
4861 (make_parent_window, make_window, saved_window)
4862 (Fset_window_configuration, save_window_save): Don't deal with
4863 clone numbers.
4864 * buffer.c (Qclone_number): Remove declaration.
4865 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4866
3349e122
SM
48672011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4868
4869 Add multiple inheritance to keymaps.
4870 * keymap.c (Fmake_composed_keymap): New function.
4871 (Fset_keymap_parent): Simplify.
4872 (fix_submap_inheritance): Remove.
4873 (access_keymap_1): New function extracted from access_keymap to handle
4874 embedded parents and handle lists of maps.
4875 (access_keymap): Use it.
4876 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4877 (Fcopy_keymap): Handle embedded parents.
4878 (Fcommand_remapping, define_as_prefix): Simplify.
4879 (Fkey_binding): Simplify.
4880 (syms_of_keymap): Move minibuffer-local-completion-map,
4881 minibuffer-local-filename-completion-map,
4882 minibuffer-local-must-match-map, and
4883 minibuffer-local-filename-must-match-map to Elisp.
4884 (syms_of_keymap): Defsubr make-composed-keymap.
4885 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4886 (parse_menu_item): Trivial simplification.
4887
3279eb87
GM
48882011-07-01 Glenn Morris <rgm@gnu.org>
4889
4890 * Makefile.in (SETTINGS_LIBS): Fix typo.
4891
4550efdf
KI
48922011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4893
4894 * coding.c (Fencode_coding_string): Record the last coding system
4895 used, as the function doc string says (bug#8738).
4896
0949d2b6
JD
48972011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4898
4899 * xsettings.c (store_monospaced_changed): Take new font as arg and
4900 check for change against current_mono_font.
4901 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4902 (emacs_settings_constructor, emacs_settings_get_property)
4903 (emacs_settings_set_property, emacs_settings_class_init)
4904 (emacs_settings_init, gsettings_obj): Remove.
4905 (something_changedCB): New function for HAVE_GSETTINGS.
4906 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4907 with value as argument.
4908 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4909 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4910 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4911 "changed".
4912
4913 * xgselect.c: Add defined (HAVE_GSETTINGS).
4914 (xgselect_initialize): Ditto.
4915
4916 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4917 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4918 xg_select.
4919
bbc6b304
PE
49202011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4921
4922 * eval.c (struct backtrace): Simplify and port the data structure.
4923 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4924 signed bit field, as this assumption is not portable and it makes
4925 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4926 "char debug_on_exit : 1" as this is not portable either; instead,
4927 use the portable "unsigned int debug_on_exit : 1". Remove unused
4928 member evalargs. Remove obsolete comments about cc bombing out.
4929
9851bfc5
JD
49302011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4931
51bb811f 4932 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4933 Let HAVE_GSETTINGS override HAVE_GCONF.
4934 (store_monospaced_changed): New function.
4935 (EMACS_SETTINGS): A new type derived from GObject to handle
4936 GSettings notifications.
4937 (emacs_settings_constructor, emacs_settings_get_property)
4938 (emacs_settings_set_property, emacs_settings_class_init):
4939 New functions.
4940 (gsettings_client, gsettings_obj): New variables.
4941 (GSETTINGS_SCHEMA): New define.
4942 (something_changedCB): Call store_monospaced_changed.
4943 (init_gsettings): New function.
4944 (xsettings_initialize): Call init_gsettings.
4945 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4946 to NULL.
4947
640c8776 4948 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4949 GCONF_CFLAGS/LIBS.
4950
5386012d
MR
49512011-06-29 Martin Rudalics <rudalics@gmx.at>
4952
4953 * window.c (resize_root_window, grow_mini_window)
4954 (shrink_mini_window): Rename Qresize_root_window to
4955 Qwindow_resize_root_window and Qresize_root_window_vertically to
4956 Qwindow_resize_root_window_vertically.
4957
f13e0b08
PE
49582011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4959
4960 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4961
94515237
JB
49622011-06-27 Juanma Barranquero <lekktu@gmail.com>
4963
4964 * makefile.w32-in: Redesign dependencies so they reflect more
4965 clearly which files are directly included by each source file,
4966 and not through other includes.
4967
e43b6e43
MR
49682011-06-27 Martin Rudalics <rudalics@gmx.at>
4969
4970 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4971 (sort_overlays, overlay_strings): When an overlay's clone number
4972 matches the window's clone number process the overlay even if
4973 the overlay's window property doesn't match the current window.
4974
d68443dc
MR
4975 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4976 (Fwindow_hchild): Rename to Fwindow_left_child.
4977 (Fwindow_next): Rename to Fwindow_next_sibling.
4978 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4979 (resize_window_check): Rename to window_resize_check.
4980 (resize_window_apply): Rename to window_resize_apply.
4981 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4982 (Fdelete_other_windows_internal, resize_frame_windows)
4983 (Fsplit_window_internal, Fdelete_window_internal)
4984 (grow_mini_window, shrink_mini_window)
4985 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4986
c7e73be5
JD
49872011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4988
4989 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4990 (emacs_fixed_set_min_size): Remove.
4991 (emacs_fixed_new): Take frame as argument.
4992
4993 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4994 (_EmacsFixedPrivate): Remove minwidth/height.
4995 Add struct frame *f.
4996 (emacs_fixed_init): Initialize priv->f.
4997 (get_parent_class, emacs_fixed_set_min_size): Remove.
4998 (emacs_fixed_new): Set priv->f to argument.
4999 (emacs_fixed_get_preferred_width)
5000 (emacs_fixed_get_preferred_height): Use min_width/height from
5001 frames size_hint to set minimum and natural (Bug#8919).
5002 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5003 and use min_width/height from frames size_hint to set
5004 min_width/height (Bug#8919).
5005
5006 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5007 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5008 Fix indentation.
c7e73be5 5009
cf99dcf8
EZ
50102011-06-26 Eli Zaretskii <eliz@gnu.org>
5011
5012 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5013 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5014 called at ZV.
5015
029529ac
CY
50162011-06-26 Chong Yidong <cyd@stupidchicken.com>
5017
5018 * process.c (wait_reading_process_output): Bypass select if
5019 waiting for a cell while ignoring keyboard input, and input is
5020 pending. Suggested by Jan Djärv (Bug#8869).
5021
7a7ef429
PE
50222011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 Use gnulib's dup2 module instead of rolling our own.
5025 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5026
11fdef7d 50272011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5028
5029 * dispnew.c (scrolling_window): Before scrolling, turn off a
5030 mouse-highlight in the window being scrolled.
5031
cd3520a4
JB
50322011-06-24 Juanma Barranquero <lekktu@gmail.com>
5033
5034 Move DEFSYM to lisp.h and use everywhere.
5035
5036 * character.h (DEFSYM): Move declaration...
5037 * lisp.h (DEFSYM): ...here.
5038
5039 * gnutls.c:
5040 * minibuf.c:
5041 * w32menu.c:
5042 * w32proc.c:
5043 * w32select.c: Don't include character.h.
5044
5045 * alloc.c (syms_of_alloc):
5046 * buffer.c (syms_of_buffer):
5047 * bytecode.c (syms_of_bytecode):
5048 * callint.c (syms_of_callint):
5049 * casefiddle.c (syms_of_casefiddle):
5050 * casetab.c (init_casetab_once):
5051 * category.c (init_category_once, syms_of_category):
5052 * ccl.c (syms_of_ccl):
5053 * cmds.c (syms_of_cmds):
5054 * composite.c (syms_of_composite):
5055 * dbusbind.c (syms_of_dbusbind):
5056 * dired.c (syms_of_dired):
5057 * dispnew.c (syms_of_display):
5058 * doc.c (syms_of_doc):
5059 * editfns.c (syms_of_editfns):
5060 * emacs.c (syms_of_emacs):
5061 * eval.c (syms_of_eval):
5062 * fileio.c (syms_of_fileio):
5063 * fns.c (syms_of_fns):
5064 * frame.c (syms_of_frame):
5065 * fringe.c (syms_of_fringe):
5066 * insdel.c (syms_of_insdel):
5067 * keymap.c (syms_of_keymap):
5068 * lread.c (init_obarray, syms_of_lread):
5069 * macros.c (syms_of_macros):
5070 * msdos.c (syms_of_msdos):
5071 * print.c (syms_of_print):
5072 * process.c (syms_of_process):
5073 * search.c (syms_of_search):
5074 * sound.c (syms_of_sound):
5075 * syntax.c (init_syntax_once, syms_of_syntax):
5076 * terminal.c (syms_of_terminal):
5077 * textprop.c (syms_of_textprop):
5078 * undo.c (syms_of_undo):
5079 * w32.c (globals_of_w32):
5080 * window.c (syms_of_window):
5081 * xdisp.c (syms_of_xdisp):
5082 * xfaces.c (syms_of_xfaces):
5083 * xfns.c (syms_of_xfns):
5084 * xmenu.c (syms_of_xmenu):
5085 * xsettings.c (syms_of_xsettings):
5086 * xterm.c (syms_of_xterm): Use DEFSYM.
5087
4228cf16
TZ
50882011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5089
cd3520a4 5090 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5091
7fcccf1e
PE
50922011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5093
7efb4e0e
PE
5094 Integer and buffer overflow fixes (Bug#8873).
5095
ff5844ad
PE
5096 * print.c (printchar, strout): Check for string overflow.
5097 (PRINTPREPARE, printchar, strout):
5098 Don't set size unless allocation succeeds.
5099
90532f02
PE
5100 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5101 for sizes. Check for string overflow more accurately.
5102 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5103
6d84508d
PE
5104 * macros.c: Integer and buffer overflow fixes.
5105 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5106 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5107 Use ptrdiff_t, not int, for sizes.
5108 Don't increment bufsize until after realloc succeeds.
5109 Check for size-calculation overflow.
5110 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5111
437b2cb4
PE
5112 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5113
8b9ac8b4
PE
5114 * lread.c: Integer overflow fixes.
5115 (read_integer): Radix is now EMACS_INT, not int,
5116 to improve quality of diagnostics for out-of-range radices.
5117 Calculate buffer size correctly for out-of-range radices.
5118 (read1): Check for integer overflow in radices, and in
5119 read-circle numbers.
82cb60d3
PE
5120 (read_escape): Avoid int overflow.
5121 (Fload, openp, read_buffer_size, read1)
5122 (substitute_object_recurse, read_vector, read_list, map_obarray):
5123 Use ptrdiff_t, not int, for sizes.
5124 (read1): Use EMACS_INT, not int, for sizes.
20270765 5125 Check for size overflow.
8b9ac8b4 5126
7fcccf1e
PE
5127 * image.c (cache_image): Check for size arithmetic overflow.
5128
bfbbd7e7
PE
5129 * lread.c: Integer overflow issues.
5130 (saved_doc_string_size, saved_doc_string_length)
5131 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5132 Now ptrdiff_t, not int.
5133 (read1): Don't assume doc string length fits in int. Check for
5134 out-of-range doc string lengths.
5135 (read_list): Don't assume file position fits in int.
39019e54 5136 (read_escape): Check for hex character overflow.
bfbbd7e7 5137
4e323265
LL
51382011-06-22 Leo Liu <sdl.web@gmail.com>
5139
5140 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5141 Move to minibuffer.el.
5142
85fece3e
PE
51432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5144
20b84ce9 5145 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5146 The following patches are for when GLYPH_DEBUG && !XASSERT.
5147 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5148 * dispnew.c (flush_stdout):
5149 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5150 Mark as externally visible.
5151 * dispnew.c (check_window_matrix_pointers): Now static.
5152 * dispnew.c (window_to_frame_vpos):
5153 * xfns.c (unwind_create_frame):
5154 * xterm.c (x_check_font): Remove unused local.
5155 * scroll.c (CHECK_BOUNDS):
5156 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5157 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5158 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5159 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5160 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5161 Now static.
5162 (debug_method_add): Use va_list and vsprintf rather than relying
5163 on undefined behavior with wrong number of arguments.
5164 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5165 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5166 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5167 since we're not interested in debugging glyphs with old libraries.
5168 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5169 GCC 4.6.0's static checking.
5170
0766b489
PE
51712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5172
31fd4b32
PE
5173 Integer overflow and signedness fixes (Bug#8873).
5174 A few related buffer overrun fixes, too.
5175
b79e8648
PE
5176 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5177
0766b489
PE
5178 * dispextern.h (struct face.stipple):
5179 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5180 (x_bitmap_mask, x_allocate_bitmap_record)
5181 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5182 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5183 (x_create_bitmap_from_xpm_data):
5184 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5185 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5186 (.bitmaps_last):
5187 * xfaces.c (load_pixmap):
5188 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5189 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5190 (.bitmaps_last, struct x_output.icon_bitmap):
5191 Use ptrdiff_t, not int, for bitmap indexes.
5192 (x_allocate_bitmap_record): Check for size overflow.
5193 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5194
b081724f
PE
5195 Use ptrdiff_t, not int, for overlay counts.
5196 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5197 * editfns.c (overlays_around, get_pos_property):
5198 * textprop.c (get_char_property_and_overlay):
5199 * xdisp.c (next_overlay_change, note_mouse_highlight):
5200 * xfaces.c (face_at_buffer_position):
21514da7
PE
5201 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5202 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5203 (Fnext_overlay_change, Fprevious_overlay_change)
5204 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5205 Use ptrdiff_t, not int, for sizes.
21514da7 5206 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5207
3de73e5e
PE
5208 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5209
2606c57b
PE
5210 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5211 (x_session_initialize): Do not assume string length fits in int.
5212
aaafe47a
PE
5213 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5214 This is unlikely, but can occur if DPI is outlandish.
5215
2674ddc8 5216 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5217 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5218
28154962
PE
5219 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5220 * xrdb.c (magic_file_p, search_magic_path):
5221 Omit last arg SUFFIX; it was always 0. All callers changed.
5222 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5223
7de51af5
PE
5224 * xfont.c (xfont_match): Avoid need for strlen.
5225
25ed6cc3
PE
5226 * xfns.c: Don't assume strlen fits in int.
5227 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5228
4eab31dd
PE
5229 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5230 not unsigned long, as we prefer signed integers. All callers changed.
5231 Detect integer overflow in repeat count.
5232 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5233 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5234
171e2a58
PE
5235 * termcap.c: Don't assume sizes fit in int and never overflow.
5236 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5237 (gobble_line): Check for size-calculation overflow.
5238
ad39faca 5239 * minibuf.c (Fread_buffer):
6e5bb2dc 5240 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5241 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5242 Don't assume string length fits in int.
5243
52c61c22 5244 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5245 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5246
b5b8c9e5
PE
5247 * font.c: Don't assume string length fits in int.
5248 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5249 Use ptrdiff_t, not int.
ccd6111c
PE
5250 (font_intern_prop): Don't assume string length fits in int.
5251 Don't assume integer property fits in fixnum.
5252 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5253
882f0d81 5254 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5255 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5256 Reformulate so as not to need the command string.
5257 Invoke gzip -cd rather than gunzip, as it's more portable.
5258 (lock_info_type, lock_file_1, lock_file):
5259 Don't assume pid_t and time_t fit in unsigned long.
5260 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5261 (current_lock_owner): Prefer signed type for sizes.
5262 Use memcpy, not strncpy, where memcpy is what is really wanted.
5263 Don't assume (via atoi) that time_t and pid_t fit in int.
5264 Check for time_t and/or pid_t out of range, e.g., via a network share.
5265 Don't alloca where an auto var works fine.
5266
93f4cf88
PE
5267 * fileio.c: Fix some integer overflow issues.
5268 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5269 Don't assume string length fits in int.
5270 (directory_file_name): Don't assume string length fits in long.
5271 (make_temp_name): Don't assume pid fits in int, or that its print
5272 length is less than 20.
5273
f3e92b69
PE
5274 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5275
1bfdaf10
PE
5276 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5277
35016e9a
PE
5278 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5279
3d1e65a1
PE
5280 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5281 We prefer signed integers, even for size calculations.
5282
0b963a93
PE
5283 * emacs.c: Don't assume string length fits in 'int'.
5284 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5285 (main): Don't invoke strlen when not needed.
5286
573f4b54
PE
5287 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5288 (XD_DEBUG_MESSAGE): Don't waste a byte.
5289
989f33ba
PE
5290 * callproc.c (getenv_internal_1, getenv_internal)
5291 (Fgetenv_internal):
965d34eb
PE
5292 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5293
e4d29b33
PE
5294 * lread.c (invalid_syntax): Omit length argument.
5295 All uses changed. This doesn't fix a bug, but it simplifies the
5296 code away from its former Hollerith-constant appearance, and it's
5297 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5298 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5299
eb49b136
PE
5300 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5301 This didn't break anything, but it didn't help either.
5302 It's confusing to put a bogus integer in a place where the actual
5303 value does not matter.
9f62aeb1 5304 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5305 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5306
15375a22
PE
5307 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5308 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5309 implementation.
b61cc01c
PE
5310 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5311 We prefer signed types, and the value cannot exceed the EMACS_INT
5312 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5313 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5314 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5315 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5316
53b2623d
PE
5317 * indent.c (sane_tab_width): New function.
5318 (current_column, scan_for_column, Findent_to, position_indentation)
5319 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5320 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5321
51cab52b 5322 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5323
f2ed8a70
PE
5324 * lisp.h (lint_assume): New macro.
5325 * composite.c (composition_gstring_put_cache):
5326 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5327
abe80cc6
PE
5328 * editfns.c, insdel.c:
5329 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5330
b02c740e
PE
5331 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5332
ebc96716
PE
5333 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5334
b4e50fa0 5335 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5336 Use much-faster test for byte-length change.
311d5d7c 5337 Don't assume string byte-length fits in 'int'.
a4cf38e4 5338 Check that character arg fits in 'int'.
85461888 5339 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5340
c0c1ee9f
PE
5341 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5342
a498d7f4
PE
5343 * fns.c (concat): Catch string overflow earlier.
5344 Do not rely on integer wraparound.
5345
51cab52b
PE
5346 * dispextern.h (struct it.overlay_strings_charpos)
5347 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5348 * xdisp.c (forward_to_next_line_start)
5349 (back_to_previous_visible_line_start)
5350 (reseat_at_next_visible_line_start, next_element_from_buffer):
5351 Don't arbitrarily truncate the value of 'selective' to int.
5352
76031fad
PE
5353 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5354
5eb55db9
PE
5355 * composite.c: Don't truncate sizes to 'int'.
5356 (composition_gstring_p, composition_reseat_it)
5357 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5358 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5359 not EMACS_UINT, for indexes.
5eb55db9 5360
0703a717
PE
5361 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5362
d6202519
PE
5363 * buffer.c: Include <verify.h>.
5364 (struct sortvec.priority, struct sortstr.priority):
8961a454 5365 Now EMACS_INT, not int.
c20998a7 5366 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5367 (struct sortstr.size, record_overlay_string)
5368 (struct sortstrlist.size, struct sortlist.used):
5369 Don't truncate size to int.
5370 (record_overlay_string): Check for size-calculation overflow.
d6202519 5371 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5372
d5a19415
JM
53732011-06-22 Jim Meyering <meyering@redhat.com>
5374
029529ac 5375 Don't leak an XBM-image-sized buffer
d5a19415
JM
5376 * image.c (xbm_load): Free the image buffer after using it.
5377
a9041e6c
PE
53782011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5379
5380 Port to Sun C.
5381 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5382 that Sun C diagnosed.
5383 * fns.c (secure_hash): Fix pointer signedness issue.
5384 * intervals.c (static_offset_intervals): New function.
5385 (offset_intervals): Use it.
5386
7f3f739f
LL
53872011-06-21 Leo Liu <sdl.web@gmail.com>
5388
5389 * deps.mk (fns.o):
5390 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5391 sha512.h.
5392
5393 * fns.c (secure_hash): Rename from crypto_hash_function and change
5394 the first arg to accept symbols.
5b66d427 5395 (Fsecure_hash): New primitive.
7f3f739f
LL
5396 (syms_of_fns): New symbols.
5397
76147d94
DD
53982011-06-20 Deniz Dogan <deniz@dogan.se>
5399
5400 * process.c (Fset_process_buffer): Clarify return value in
5401 docstring.
5402
7d7d0045
CY
54032011-06-18 Chong Yidong <cyd@stupidchicken.com>
5404
5405 * dispnew.c (add_window_display_history): Use BVAR.
5406
5407 * xdisp.c (debug_method_add): Use BVAR.
5408 (check_window_end, dump_glyph_matrix, dump_glyph)
5409 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5410
5411 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5412 Likewise.
5413
5414 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5415 check till after the cache is created in init_frame_faces.
5416
ff2bc410
SM
54172011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5418
5419 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5420
28177add
PE
54212011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5422
dd3482fe
PE
5423 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5424 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5425 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5426
393d71f3 5427 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5428 * fileio.c (Finsert_file_contents):
5429 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5430 Remove the old (too-loose) buffer overflow checks.
5431 They weren't needed, since make_gap checks for buffer overflow.
5432 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5433 The old code merely checked for Emacs fixnum overflow, and relied
5434 on undefined (wraparound) behavior. The new code avoids undefined
5435 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5436
2e6813b0 5437 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5438 Tune. Don't use wider integers than needed. Don't use alloca.
5439 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5440
599a9e4f
PE
5441 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5442
99561444
PE
5443 * insdel.c, lisp.h (buffer_overflow): New function.
5444 (insert_from_buffer_1, replace_range, replace_range_2):
5445 * insdel.c (make_gap_larger):
5446 * editfns.c (Finsert_char):
5447 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5448
28177add
PE
5449 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5450
e69dafad
PE
54512011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5452
4baa020d 5453 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5454
b1c46f02
PE
5455 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5456 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5457
e69dafad
PE
5458 * fileio.c: Don't assume EMACS_INT fits in off_t.
5459 (emacs_lseek): New static function.
5460 (Finsert_file_contents, Fwrite_region): Use it.
5461 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5462
566684ea
PE
5463 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5464
e6966cd6
PE
5465 * fns.c: Don't overflow int when computing a list length.
5466 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5467 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5468 truncation on 64-bit hosts. Check for QUIT every
5469 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5470 faster and is responsive enough.
5471 (Flength): Report an error instead of overflowing an integer.
5472 (Fsafe_length): Return a float if the value is not representable
5473 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5474 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5475 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5476
dd0b0efb
PE
5477 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5478 (header_size, word_size): New constants.
5479 (allocate_vectorlike): Don't check size overflow here.
5480 (allocate_vector): Check it here instead, since this is the only
5481 caller of allocate_vectorlike that could cause overflow.
5482 Check that the new vector's length is representable as a fixnum.
5483
86fe5cfe
PE
5484 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5485 The previous code was bogus. For example, next_almost_prime (32)
5486 returned 39, which is undesirable as it is a multiple of 3; and
5487 next_almost_prime (24) returned 25, which is a multiple of 5 so
5488 why was the code bothering to check for multiples of 7?
5489
80e88859
PE
5490 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5491
4a2f0ad6
PE
5492 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5493
f66c7cf8
PE
5494 Variadic C functions now count arguments with ptrdiff_t.
5495 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5496 Back then I didn't know that the Emacs coding style prefers signed int.
5497 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5498 were being counted with int, which may truncate counts on 64-bit
5499 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5500 * lisp.h (struct Lisp_Subr.function.aMANY)
5501 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5502 Arg counts are now ptrdiff_t, not size_t.
5503 All variadic functions and their callers changed accordingly.
5504 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5505 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5506 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5507 * callint.c (Fcall_interactively): Check arg count for overflow,
5508 to avoid potential buffer overrun. Use signed char, not 'int',
5509 for 'varies' array, so that we needn't bother to check its size
5510 calculation for overflow.
5511 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5512 * eval.c (apply_lambda):
5513 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5514 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5515 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5516
a1759b76
PE
5517 * callint.c (Fcall_interactively): Don't use index var as event count.
5518
d96be9fc
PE
5519 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5520 * mem-limits.h (SIZE): Remove; no longer used.
5521
a690a978 5522 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5523
578c21e6
PE
5524 Remove unnecessary casts.
5525 * xterm.c (x_term_init):
5526 * xfns.c (x_set_border_pixel):
5527 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5528 These aren't needed now that we assume ANSI C.
5529
96f53c6c
PE
5530 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5531 It's more likely to cause problems (due to unsigned overflow)
5532 than to cure them.
5533
83c77d31
PE
5534 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5535
ee2079f1
PE
5536 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5537
6da65536
PE
5538 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5539
7147c4a4
PE
5540 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5541
193e32d9
PE
5542 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5543
e5533da6
PE
5544 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5545
9910e595
PE
5546 GLYPH_CODE_FACE returns EMACS_INT, not int.
5547 * dispextern.h (merge_faces):
5548 * xfaces.c (merge_faces):
01103c44
PE
5549 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5550 Don't assume EMACS_INT fits in int.
9910e595 5551
2638320e
PE
5552 * character.h (CHAR_VALID_P): Remove unused parameter.
5553 * fontset.c, lisp.h, xdisp.c: All uses changed.
5554
045eb8d9
PE
5555 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5556
c1f134b5
PE
5557 * fns.c (concat): Minor tuning based on overflow analysis.
5558 This doesn't fix any bugs. Use int to hold character, instead
5559 of constantly refetching from Emacs object. Use XFASTINT, not
5560 XINT, for value known to be a character. Don't bother comparing
5561 a single byte to 0400, as it's always less.
5562
395fcb93 5563 * floatfns.c (Fexpt):
327eeec8
PE
5564 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5565
abbd3d23
PE
5566 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5567 for characters.
5568
684a03ef
PE
5569 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5570
0fed43f3
PE
5571 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5572 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5573 incorrectly succeed when S was a string, because 4294967386 was
5574 truncated before it was used.
5575
8fd02eb7
PE
5576 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5577 Otherwise, an out-of-range integer could cause undefined behavior
5578 on a 64-bit host.
5579
f8c86b69
PE
5580 * composite.c: Use int, not EMACS_INT, for characters.
5581 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5582 EMACS_INT, for values that are known to be in character range.
5583 This doesn't fix any bugs but is the usual style inside Emacs and
5584 may generate better code on 32-bit machines.
5585
34206dd2
PE
5586 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5587 This is for reasons similar to the recent CHAR_STRING fix.
5588 * charset.c (Fencode_char): Check that character arg is actually
5589 a character. Pass an int to ENCODE_CHAR.
5590 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5591 wider than 'int', as a compile-time check to prevent future regressions
5592 in this area.
5593
c5958d4c 5594 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5595
5596 Make sure a 64-bit char is never passed to CHAR_STRING.
5597 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5598 by silently ignoring the top 32 bits, allowing some values
5599 that were far too large to be valid characters.
5600 * character.h: Include <verify.h>.
5601 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5602 arguments are no wider than unsigned, as a compile-time check
5603 to prevent future regressions in this area.
5604 * data.c (Faset):
01103c44 5605 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5606 (Fsubst_char_in_region):
5607 * fns.c (concat):
5608 * xdisp.c (decode_mode_spec_coding):
5609 Adjust to CHAR_STRING's new requirement.
5610 * editfns.c (Finsert_char, Fsubst_char_in_region):
5611 * fns.c (concat): Check that character args are actually
5612 characters. Without this test, these functions did the wrong
5613 thing with wildly out-of-range values on 64-bit hosts.
5614
d37ca623
PE
5615 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5616 These casts should not be needed on 32-bit hosts, either.
5617 * keyboard.c (read_char):
5618 * lread.c (Fload): Remove casts to unsigned.
5619
ea204efb
PE
5620 * lisp.h (UNSIGNED_CMP): New macro.
5621 This fixes comparison bugs on 64-bit hosts.
5622 (ASCII_CHAR_P): Use it.
5623 * casefiddle.c (casify_object):
01103c44 5624 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5625 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5626 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5627 * dispextern.h (FACE_FROM_ID):
5628 * keyboard.c (read_char): Use UNSIGNED_CMP.
5629
41cb286c
PE
5630 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5631 not to EMACS_INT, to avoid GCC warning.
5632
4a1b9832
PE
5633 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5634
55daad71
PE
5635 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5636 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5637 isn't needed on 32-bit machines.
8f95c75c 5638
01103c44
PE
5639 * buffer.c (Fgenerate_new_buffer_name):
5640 Use EMACS_INT for count, not int.
0ceccced 5641 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5642
5643 * data.c (Qcompiled_function): Now static.
5644
c6f072e7
PE
5645 * window.c (window_body_lines): Now static.
5646
20ce5912
PE
5647 * image.c (gif_load): Rename local to avoid shadowing.
5648
9c4c5f81
PE
5649 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5650 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5651 * alloc.c (make_save_value): Integer argument is now of type
5652 ptrdiff_t, not int.
5653 (mark_object): Use ptrdiff_t, not int.
5654 * lisp.h (pD): New macro.
5655 * print.c (print_object): Use it.
5656
c0c5c8ae
PE
5657 * alloc.c: Use EMACS_INT, not int, to count objects.
5658 (total_conses, total_markers, total_symbols, total_vector_size)
5659 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5660 (total_free_floats, total_floats, total_free_intervals)
5661 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5662 Now EMACS_INT, not int. All uses changed.
5663 (Fgarbage_collect): Compute overall total using a double, so that
5664 integer overflow is less likely to be a problem. Check for overflow
5665 when converting back to an integer.
5a25e253
PE
5666 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5667 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5668 These were 'int' variables that could overflow on 64-bit hosts;
5669 they were never used, so remove them instead of repairing them.
211a0b2a 5670 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5671 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5672 Previously, this ceilinged at INT_MAX, but that doesn't work on
5673 64-bit machines.
e46bb31a 5674 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5675
c78baabf 5676 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5677 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5678 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5679 when a (possibly-narrower) signed value would do just as well.
5680 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5681
c9d624c6
PE
5682 * alloc.c: Catch some string size overflows that we were missing.
5683 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5684 for convenience in STRING_BYTES_MAX.
5685 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5686 The definition here is exact; the one in lisp.h was approximate.
5687 (allocate_string_data): Check for string overflow. This catches
5688 some instances we weren't catching before. Also, it catches
5689 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5690 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5691 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5692
c9d624c6
PE
5693 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5694 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5695 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5696
353032ce
PE
5697 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5698
2bccce07
PE
5699 * alloc.c (Fmake_string): Check for out-of-range init.
5700
0ac30604
SM
57012011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5702
5703 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5704
c195f2de
JD
57052011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5706
5707 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5708 xg_get_default_scrollbar_width.
5709
5710 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5711 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5712 (style_changed_cb): Call update_theme_scrollbar_width and call
5713 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5714 all frames (Bug#8505).
5715 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5716 Call gtk_window_set_resizable if HAVE_GTK3.
5717 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5718 and height if HAVE_GTK3 (Bug#8505).
5719 (scroll_bar_width_for_theme): New variable.
5720 (update_theme_scrollbar_width): New function.
5721 (xg_get_default_scrollbar_width): Move code to
5722 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5723 (xg_initialize): Call update_theme_scrollbar_width.
5724
5725 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5726
5727 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5728
e10ac9f1
MR
57292011-06-12 Martin Rudalics <rudalics@gmx.at>
5730
5731 * frame.c (make_frame): Call other_buffer_safely instead of
5732 other_buffer.
5733
5734 * window.c (temp_output_buffer_show): Call display_buffer with
5735 second argument Vtemp_buffer_show_specifiers and reset latter
5736 immediately after the call.
5737 (Vtemp_buffer_show_specifiers): New variable.
5738 (auto_window_vscroll_p, next_screen_context_lines)
5739 (Vscroll_preserve_screen_position): Remove leading asterisks from
5740 doc-strings.
5741
2d3c217e 57422011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5743
7b7f97e8 5744 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5745 * buffer.c (Qclone_number): Remove for now, as it's unused.
5746 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5747 (record_buffer): Remove unused local.
5748 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5749 (set_frame_buffer_list): Remove; unused.
5750 * frame.h (other_visible_frames): Remove decl.
5751 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5752 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5753 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5754 if HAVE_GPM.
5755 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5756 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5757 Define only if HAVE_GPM.
5758 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5759 (update_hints_inhibit): Remove; never set. All uses removed.
5760 * widgetprv.h (emacsFrameClassRec): Remove decl.
5761 * window.c (delete_deletable_window): Now returns void, since it
5762 wasn't returning anything.
5763 (compare_window_configurations): Remove unused locals.
5764 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5765 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5766 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5767 the same widths as pointers. This follows up on the 2011-05-06 patch.
5768 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5769 * xterm.h: Likewise.
5770 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5771
1384b89e
JB
57722011-06-12 Juanma Barranquero <lekktu@gmail.com>
5773
5774 * makefile.w32-in: Update dependencies.
5775 (LISP_H): Add lib/intprops.h.
5776
1100a63c
CY
57772011-06-11 Chong Yidong <cyd@stupidchicken.com>
5778
5779 * image.c (gif_load): Add animation frame delay to the metadata.
5780 (syms_of_image): Use DEFSYM. New symbol `delay'.
5781
6198ccd0
MR
57822011-06-11 Martin Rudalics <rudalics@gmx.at>
5783
5784 * window.c (delete_deletable_window): Re-add.
5785 (Fset_window_configuration): Rewrite to handle dead buffers and
5786 consequently deletable windows.
5787 (window_tree, Fwindow_tree): Remove. Supply functionality in
5788 window.el.
5789 (compare_window_configurations): Simplify code.
5790
b6e3633c
AS
57912011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5792
1ab0dee5
AS
5793 * image.c (imagemagick_load_image): Fix type mismatch.
5794 (Fimagemagick_types): Likewise.
5795
b6e3633c
AS
5796 * window.h (replace_buffer_in_windows): Declare.
5797
9397e56f
MR
57982011-06-11 Martin Rudalics <rudalics@gmx.at>
5799
5800 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5801 Qclone_number. Remove external declaration of Qdelete_window.
5802 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5803 code.
640c8776
SM
5804 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5805 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5806 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5807 buffer list implementation.
5808 (other_buffer_safely): New function.
5809 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5810 calls to replace_buffer_in_windows and
5811 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5812 if allowed.
5813 (record_buffer): Inhibit quitting and rewrite using quittable
5814 functions. Run Qbuffer_list_update_hook if allowed.
5815 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5816 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5817 Move switch-to-buffer to window.el.
9397e56f
MR
5818 (bury-buffer): Move to window.el.
5819 (Vbuffer_list_update_hook): New variable.
5820
5821 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5822 section.
5823
5824 * window.h (resize_frame_windows): Move up in code.
5825 (Fwindow_frame): Remove EXFUN.
5826 (replace_buffer_in_all_windows): Remove prototype.
5827 (replace_buffer_in_windows_safely): Add prototype.
5828
5829 * window.c: Declare Qdelete_window static again. Move down
5830 declaration of select_count.
5831 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5832 (Fother_window): Move to window.el.
5833 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5834 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5835 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5836 window.el.
5837 (replace_buffer_in_windows): Implement by calling
5838 Qreplace_buffer_in_windows.
5839 (replace_buffer_in_all_windows): Remove with some functionality
5840 moved into replace_buffer_in_windows_safely.
5841 (replace_buffer_in_windows_safely): New function.
5842 (select_window_norecord, select_frame_norecord): Move in front
5843 of run_window_configuration_change_hook. Remove now obsolete
5844 declarations.
640c8776
SM
5845 (Fset_window_buffer): Rewrite doc-string.
5846 Call Qrecord_window_buffer.
9397e56f
MR
5847 (keys_of_window): Move binding for other-window to window.el.
5848
b50691aa
CY
58492011-06-11 Chong Yidong <cyd@stupidchicken.com>
5850
5851 * dispextern.h (struct image): Replace data member, whose int_val
5852 and ptr_val fields were not used by anything, with a single
5853 lisp_val object.
5854
5855 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5856 (gif_clear_image, gif_load, imagemagick_load_image)
5857 (gs_clear_image, gs_load): Callers changed.
5858
3f754b86
PE
58592011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5860
cca69397
PE
5861 * buffer.h: Include <time.h>, for time_t.
5862 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5863
109e28d0
PE
5864 Fix minor problems found by static checking.
5865
60737f02
PE
5866 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5867
4b66faf3
PE
5868 Make identifiers static if they are not used in other modules.
5869 * data.c (Qcompiled_function, Qframe, Qvector):
5870 * image.c (QimageMagick, Qsvg):
5871 * minibuf.c (Qmetadata):
5872 * window.c (resize_window_check, resize_root_window): Now static.
5873 * window.h (resize_window_check, resize_root_window): Remove decls.
5874
109e28d0
PE
5875 * window.c (window_deletion_count, delete_deletable_window):
5876 Remove; unused.
46a4ce9e
PE
5877 (window_body_lines): Now static.
5878 (Fdelete_other_windows_internal): Mark vars as initialized.
5879 Make sure 'resize_failed' is initialized.
5880 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5881 (resize_window_apply): Remove unused local.
5882 * window.h (delete_deletable_window): Remove decl.
5883
109e28d0 5884 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5885 (imagemagick_load_image): Fix pointer signedness problem by changing
5886 last arg from unsigned char * to char *. All uses changed.
5887 Also, fix a local for similar reasons.
5888 Remove unused locals. Remove locals to avoid shadowing.
5889 (fn_rsvg_handle_free): Remove; unused.
5890 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5891 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5892
3f754b86
PE
5893 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5894
2547adb1
CY
58952011-06-10 Chong Yidong <cyd@stupidchicken.com>
5896
5897 * image.c (gif_load): Fix omitted cast error introduced by
5898 2011-06-06 change.
5899
2c8e37d4
MR
59002011-06-10 Martin Rudalics <rudalics@gmx.at>
5901
5902 * window.h (resize_proportionally, orig_total_lines)
5903 (orig_top_line): Remove from window structure.
5904 (set_window_height, set_window_width, change_window_heights)
5905 (Fdelete_window): Remove prototypes.
5906 (resize_frame_windows): Remove duplicate declaration.
5907
440a42e3
EZ
59082011-06-10 Eli Zaretskii <eliz@gnu.org>
5909
5910 * window.h (resize_frame_windows, resize_window_check)
5911 (delete_deletable_window, resize_root_window)
5912 (resize_frame_windows): Declare prototypes.
5913
5914 * window.c (resize_window_apply): Make definition be "static" to
5915 match the prototype.
5916
562dd5e9
MR
59172011-06-10 Martin Rudalics <rudalics@gmx.at>
5918
5919 * window.c: Remove declarations of Qwindow_size_fixed,
5920 window_min_size_1, window_min_size_2, window_min_size,
5921 size_window, window_fixed_size_p, enlarge_window, delete_window.
5922 Remove static from declaration of Qdelete_window, it's
5923 temporarily needed by Fbury_buffer.
5924 (replace_window): Don't assign orig_top_line and
5925 orig_total_lines.
5926 (Fdelete_window, delete_window): Remove. Window deletion is
5927 handled by window.el.
640c8776
SM
5928 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5929 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5930 (Fdelete_other_windows): Remove. Deleting other windows is
5931 handled by window.el.
5932 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5933 handled in window.el.
5934 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5935 Window minimum sizes are handled in window.el.
5936 (shrink_windows, size_window, set_window_height)
5937 (set_window_width, change_window_heights, window_height)
5938 (window_width, CURBEG, CURSIZE, enlarge_window)
5939 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5940 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5941 handled in window.el.
5942 (make_dummy_parent): Rename to make_parent_window and give it a
5943 second argument horflag.
5944 (make_window): Don't set resize_proportionally any more.
5945 (Fsplit_window): Remove. Windows are split in window.el.
5946 (save_restore_action, save_restore_orig_size)
5947 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5948 Resize mini windows in window.el.
5949 (grow_mini_window, shrink_mini_window): Implement by calling
5950 Qresize_root_window_vertically, resize_window_check and
5951 resize_window_apply.
640c8776
SM
5952 (saved_window, Fset_window_configuration, save_window_save):
5953 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5954 resize_proportionally.
5955 (window_min_height, window_min_width): Move to window.el.
5956 (keys_of_window): Move bindings for delete-other-windows,
5957 split-window, delete-window and enlarge-window to window.el.
5958
5959 * buffer.c: Temporarily extern Qdelete_window.
5960 (Fbury_buffer): Temporarily call Qdelete_window instead of
5961 Fdelete_window (Fbury_buffer will move to window.el soon).
5962
5963 * frame.c (set_menu_bar_lines_1): Remove code handling
5964 orig_top_line and orig_total_lines.
5965
5966 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5967 set_window_height but set heights directly.
5968 (change_frame_size_1): Use resize_frame_windows.
5969
5970 * xdisp.c (init_xdisp): Don't use set_window_height but set
5971 heights directly.
5972
640c8776
SM
5973 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5974 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5975 run_window_configuration_change_hook.
5976
5977 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5978 instead of change_window_heights and run
5979 run_window_configuration_change_hook.
5980
1a13852e
MR
59812011-06-09 Martin Rudalics <rudalics@gmx.at>
5982
5983 * window.c (replace_window): Rename second argument REPLACEMENT to
5984 NEW. New third argument SETFLAG. Rewrite.
5985 (delete_window, make_dummy_parent): Call replace_window with
5986 third argument 1.
5987 (window_list_1): Move down in code.
5988 (run_window_configuration_change_hook): Move set_buffer part
5989 before select_frame_norecord part in order to unwind correctly.
5990 Rename count1 to count.
5991 (recombine_windows, delete_deletable_window, resize_root_window)
5992 (Fdelete_other_windows_internal)
5993 (Frun_window_configuration_change_hook, make_parent_window)
5994 (resize_window_check, resize_window_apply, Fresize_window_apply)
5995 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5996 (Fdelete_window_internal, Fresize_mini_window_internal):
5997 New functions.
1a13852e
MR
5998 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5999
f3d1777e
MR
60002011-06-08 Martin Rudalics <rudalics@gmx.at>
6001
496e208e
MR
6002 * window.h (window): Add some new members to window structure -
6003 normal_lines, normal_cols, new_total, new_normal, clone_number,
6004 splits, nest, prev_buffers, next_buffers.
6005 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6006 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6007
f3d1777e
MR
6008 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6009 Remove.
496e208e
MR
6010 (make_dummy_parent): Set new members of windows structure.
6011 (make_window): Move down in code. Handle new members of window
6012 structure.
6013 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6014 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6015 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6016 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6017 (Fset_window_next_buffers, Fset_window_clone_number):
6018 New functions.
496e208e
MR
6019 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6020 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6021 Doc-string fixes.
6022 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6023 Argument WINDOW can be now internal window too.
6024 (Fwindow_use_time): Move up in code.
6025 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6026 Rewrite doc-string.
6027 (Fset_window_configuration, saved_window)
6028 (Fcurrent_window_configuration, save_window_save): Handle new
6029 members of window structure.
b9e809c2
MR
6030 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6031 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6032 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6033 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6034 Qget_mru_window, Qresize_root_window,
6035 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6036 Qauto_buffer_name; staticpro them.
f3d1777e 6037
abde8f8c
MR
60382011-06-07 Martin Rudalics <rudalics@gmx.at>
6039
6040 * window.c (Fwindow_total_size, Fwindow_left_column)
6041 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6042 (Fwindow_list_1): New functions.
6043 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6044 (Fwindow_width, Fscroll_left, Fscroll_right):
6045 Use window_body_cols instead of window_box_text_cols.
6046 (delete_window, Fset_window_configuration):
6047 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6048 (delete_all_subwindows): Take a window as argument and not a
6049 structure. Rewrite.
190b47e6
MR
6050 (window_loop): Remove handling of GET_LRU_WINDOW and
6051 GET_LARGEST_WINDOW.
6052 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6053
6054 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6055 window_box_text_cols. delete_all_subwindows now takes a
6056 Lisp_Object as argument.
abde8f8c 6057
640c8776
SM
6058 * indent.c (compute_motion, Fcompute_motion):
6059 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6060
fa8a67e6
MR
6061 * frame.c (delete_frame): Call delete_all_subwindows with root
6062 window as argument.
6063
a54e3482
DC
60642011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6065
6066 * fns.c (Fputhash): Document return value.
6067
60002bf5
CY
60682011-06-06 Chong Yidong <cyd@stupidchicken.com>
6069
6070 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6071
0c671da6 60722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6073
b862a52a 6074 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6075
be44ca6c
PE
6076 Check for overflow when converting integer to cons and back.
6077 * charset.c (Fdefine_charset_internal, Fdecode_char):
6078 Use cons_to_unsigned to catch overflow.
6079 (Fencode_char): Use INTEGER_TO_CONS.
6080 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6081 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6082 * data.c (long_to_cons, cons_to_long): Remove.
6083 (cons_to_unsigned, cons_to_signed): New functions.
6084 These signal an error for invalid or out-of-range values.
6085 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6086 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6087 * font.c (Ffont_variation_glyphs):
6088 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6089 * lisp.h: Include <intprops.h>.
6090 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6091 (cons_to_signed, cons_to_unsigned): New decls.
6092 (long_to_cons, cons_to_long): Remove decls.
6093 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6094 (Fprimitive_undo): Use CONS_TO_INTEGER.
6095 * xfns.c (Fx_window_property): Likewise.
6096 * xselect.c: Include <limits.h>.
6097 (x_own_selection, selection_data_to_lisp_data):
6098 Use INTEGER_TO_CONS.
6099 (x_handle_selection_request, x_handle_selection_clear)
6100 (x_get_foreign_selection, Fx_disown_selection_internal)
6101 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6102 (lisp_data_to_selection_data): Use cons_to_unsigned.
6103 (x_fill_property_data): Use cons_to_signed.
6104 Report values out of range.
6105
d1f3d2af
PE
6106 Check for buffer and string overflow more precisely.
6107 * buffer.h (BUF_BYTES_MAX): New macro.
6108 * lisp.h (STRING_BYTES_MAX): New macro.
6109 * alloc.c (Fmake_string):
6110 * character.c (string_escape_byte8):
6111 * coding.c (coding_alloc_by_realloc):
6112 * doprnt.c (doprnt):
6113 * editfns.c (Fformat):
6114 * eval.c (verror):
6115 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6116 since they may not be the same number.
6117 * editfns.c (Finsert_char):
6118 * fileio.c (Finsert_file_contents):
6119 Likewise for BUF_BYTES_MAX.
6120
dd52fcea
PE
6121 * image.c: Use ptrdiff_t, not int, for sizes.
6122 (slurp_file): Switch from int to ptrdiff_t.
6123 All uses changed.
6124 (slurp_file): Check that file size fits in both size_t (for
6125 malloc) and ptrdiff_t (for sanity and safety).
6126
7f9bbdbb
PE
6127 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6128 if b->modtime has its maximal value.
6129
dfe18f82
PE
6130 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6131
84acfcf0
PE
6132 Don't assume time_t can fit into int.
6133 * buffer.h (struct buffer.modtime): Now time_t, not int.
6134 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6135 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6136
ccd9a01a
PE
6137 Minor fixes for signed vs unsigned integers.
6138 * character.h (MAYBE_UNIFY_CHAR):
6139 * charset.c (maybe_unify_char):
6140 * keyboard.c (read_char, reorder_modifiers):
6141 XINT -> XFASTINT, since the integer must be nonnegative.
6142 * ftfont.c (ftfont_spec_pattern):
6143 * keymap.c (access_keymap, silly_event_symbol_error):
6144 XUINT -> XFASTINT, since the integer must be nonnegative.
6145 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6146 since it makes no difference and we prefer signed.
6147 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6148 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6149 nonnegative.
6150
d6d100dd
SM
61512011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6152
6153 * window.h (Fwindow_frame): Declare.
6154
2b6148e4
PE
61552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6156
6157 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6158 (SPARE_MEMORY): Always define.
6159 (LARGE_REQUEST): Remove.
6160 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6161
f230ecc9
MR
61622011-06-06 Martin Rudalics <rudalics@gmx.at>
6163
727e958e
MR
6164 * lisp.h: Move EXFUNS for Fframe_root_window,
6165 Fframe_first_window and Fset_frame_selected_window to window.h.
6166
6167 * window.h: Move EXFUNS for Fframe_root_window,
6168 Fframe_first_window and Fset_frame_selected_window here from
6169 lisp.h.
6170
6171 * frame.c (Fwindow_frame, Fframe_first_window)
6172 (Fframe_root_window, Fframe_selected_window)
6173 (Fset_frame_selected_window): Move to window.c.
6174 (Factive_minibuffer_window): Move to minibuf.c.
6175 (Fother_visible_frames_p): New function.
6176
6177 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6178
f230ecc9
MR
6179 * window.c (decode_window, decode_any_window): Move up in code.
6180 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6181 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6182 (Fwindow_buffer): Move up and rewrite doc-string.
6183 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6184 (Fwindow_prev): New functions.
727e958e
MR
6185 (Fwindow_frame): Move here from frame.c. Accept any window as
6186 argument.
6187 (Fframe_root_window, Fframe_first_window)
6188 (Fframe_selected_window): Move here from frame.c. Accept frame
6189 or arbitrary window as argument. Update doc-strings.
6190 (Fminibuffer_window): Move up in code.
6191 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6192 (Fset_frame_selected_window): Move here from frame.c.
6193 Marginal rewrite.
727e958e
MR
6194 (Fselected_window, select_window, Fselect_window): Move up in
6195 code. Minor doc-string fixes.
f230ecc9 6196
4d09bcf6
PE
61972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6198
6199 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6200 Do not assume that spare memory exists; that assumption is valid
6201 only if SYSTEM_MALLOC.
6202 (LARGE_REQUEST): New macro, so that the issue of large requests
6203 is separated from the issue of spare memory.
6204
810928a2
AS
62052011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6206
172418ad
AS
6207 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6208 format. (Bug#8806)
6209
43f862f7
AS
6210 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6211
810928a2
AS
6212 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6213 before statements.
6214
a059fe24
JD
62152011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6216
6217 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6218
6219 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6220
6221 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6222 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6223
989bf368
JB
62242011-06-05 Juanma Barranquero <lekktu@gmail.com>
6225
6226 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6227
4b80f674
CY
62282011-06-04 Chong Yidong <cyd@stupidchicken.com>
6229
6230 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6231 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6232 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6233 New error handlers.
4b80f674
CY
6234 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6235 Obey Vx_select_enable_clipboard_manager. Catch errors in
6236 x_clipboard_manager_save (Bug#8779).
6237 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6238 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6239
99a33b77 62402011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6241
6242 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6243
99a33b77 62442011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6245
6246 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6247 in the current matrix if keep_current_p is non-zero.
6248
8264569d
EZ
62492011-06-04 Eli Zaretskii <eliz@gnu.org>
6250
6251 * bidi.c (bidi_level_of_next_char): Fix last change.
6252
57f97249
EZ
62532011-06-03 Eli Zaretskii <eliz@gnu.org>
6254
fec2107c 6255 Support bidi reordering of text covered by display properties.
57f97249 6256
fec2107c
EZ
6257 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6258 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6259 (bidi_cache_search, bidi_cache_iterator_state)
6260 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6261 (bidi_level_of_next_char, bidi_move_to_visually_next):
6262 Support character positions inside a run of characters covered by a
fec2107c
EZ
6263 display string.
6264 (bidi_paragraph_init, bidi_resolve_explicit_1)
6265 (bidi_level_of_next_char): Call bidi_fetch_char and
6266 bidi_fetch_char_advance instead of FETCH_CHAR and
6267 FETCH_CHAR_ADVANCE.
6268 (bidi_init_it): Initialize new members.
6269 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6270 definitions.
6271 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6272 instead of using explicit *_CHAR codes.
d6d100dd
SM
6273 (bidi_resolve_explicit, bidi_resolve_weak):
6274 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6275 bidirectional text is supported only in multibyte buffers.
6276 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6277 it to initialize the frame_window_p member of struct bidi_it.
6278 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6279 (bidi_resolve_explicit, bidi_resolve_weak)
6280 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6281 bidi_it->nchars is non-positive.
6282 (bidi_level_of_next_char): Don't try to lookup the cache for the
6283 next/previous character if nothing is cached there yet, or if we
6284 were just reseat()'ed to a new position.
c40e2fb2 6285
0e14fe90
EZ
6286 * xdisp.c (set_cursor_from_row): Set start and stop points
6287 according to the row's direction when priming the loop that looks
6288 for the glyph on which to display cursor.
6289 (single_display_spec_intangible_p): Function deleted.
6290 (display_prop_intangible_p): Reimplement to call
6291 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6292 Accept 3 additional arguments needed by handle_display_spec.
6293 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6294 values: lists, `(when COND...)' forms, etc.
6295 (single_display_spec_string_p): Support property values that are
6296 lists with the argument STRING its top-level element.
6297 (display_prop_string_p): Fix the condition for processing a
6298 property that is a list to be consistent with handle_display_spec.
fec2107c 6299 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6300 last portion of handle_display_prop.
6301 (compute_display_string_pos): Accept additional argument
6302 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6303 value of a `display' property is a "replacing spec".
6304 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6305 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6306 the display property, but just return a value indicating whether
6307 the display property will replace the characters it covers.
6308 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6309 frame_window_p members of struct bidi_it.
d6d100dd
SM
6310 (compute_display_string_pos, compute_display_string_end):
6311 New functions.
fec2107c
EZ
6312 (push_it): Accept second argument POSITION, where pop_it should
6313 jump to continue iteration.
6314 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6315
fec2107c
EZ
6316 * keyboard.c (adjust_point_for_property): Adjust the call to
6317 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6318
6319 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6320 (bidi_init_it): Update prototypes.
6321 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6322 (compute_display_string_pos, compute_display_string_end):
6323 Declare prototypes.
fec2107c
EZ
6324 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6325 EMACS_INT.
fc6f18ce 6326
40087514 63272011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6328
57f53182
PE
6329 Malloc failure behavior now depends on size of allocation.
6330 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6331 * lisp.h: Change signatures accordingly.
6332 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6333 All callers changed. (Bug#8762)
6334
6335 * gnutls.c: Use Emacs's memory allocators.
6336 Without this change, the gnutls library would invoke malloc etc.
6337 directly, which causes problems on non-SYNC_INPUT hosts, and which
6338 runs afoul of improving memory_full behavior. (Bug#8761)
6339 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6340 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6341 xfree instead of the default malloc, realloc, free.
6342 (Fgnutls_boot): No need to check for memory allocation failure,
6343 since xmalloc does that for us.
6344
ac32cd99 6345 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6346 * category.c (hash_get_category_set):
6347 * ccl.c (ccl_driver):
6348 * charset.c (Fdefine_charset_internal):
6349 * charset.h (struct charset.hash_index):
6350 * composite.c (get_composition_id, gstring_lookup_cache)
6351 (composition_gstring_put_cache):
6352 * composite.h (struct composition.hash_index):
6353 * dispextern.h (struct image.hash):
6354 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6355 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6356 (hashfn_equal, hashfn_user_defined, make_hash_table)
6357 (maybe_resize_hash_table, hash_lookup, hash_put)
6358 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6359 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6360 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6361 * image.c (make_image, search_image_cache, lookup_image)
6362 (xpm_put_color_table_h):
6363 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6364 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6365 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6366 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6367 * alloc.c (allocate_vectorlike):
6368 Check for overflow in vector size calculations.
6369 * ccl.c (ccl_driver):
6370 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6371 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6372 need to be updated by these changes.
40087514
PE
6373 * fns.c (make_hash_table, maybe_resize_hash_table):
6374 Check for integer overflow with large hash tables.
0de4bb68
PE
6375 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6376 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6377 (SXHASH_REDUCE): New macro.
6378 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6379 Use it instead of discarding useful hash info with large hash values.
6380 (sxhash_float): New function.
6381 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6382 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6383 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6384 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6385 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6386 Adjust signatures to match updated version of code.
6387 (consing_since_gc): Now EMACS_INT, since a single hash table can
6388 use more than INT_MAX bytes.
6389
698d32e2
DN
63902011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6391
6392 Make it possible to build with GCC-4.6+ -O2 -flto.
6393
6394 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6395
fd6fa53f
SM
63962011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6397
6398 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6399 Call minibuffer-inactive-mode.
6400
864db017
JB
64012011-05-31 Juanma Barranquero <lekktu@gmail.com>
6402
6403 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6404 Update dependencies.
6405
2ad0baf4
DN
64062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6407
6408 * data.c (init_data): Remove code for UTS, this system is not
6409 supported anymore.
6410
4fcc2638
DN
64112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6412
6413 Don't force ./temacs to start in terminal mode.
6414
6415 * frame.c (make_initial_frame): Initialize faces in all cases, not
6416 only when CANNOT_DUMP is defined.
6417 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6418
c56e0fd5
DN
64192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6420
6421 * dispnew.c (add_window_display_history): Use const for the string
6422 pointer. Remove declaration, not needed.
6423
333d54da 64242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6425
55d4c1b2 6426 Use 'inline', not 'INLINE'.
333d54da 6427 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6428 * alloc.c, fontset.c (INLINE): Remove.
6429 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6430 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6431 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6432 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6433 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6434
738db178
DN
64352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6436
6437 Make it possible to run ./temacs.
6438
6439 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6440 syms_of_callproc does the same thing. Remove test for
6441 "initialized", do it in the caller.
6442 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6443
620c53a6
SM
64442011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6445
6446 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6447 (read_minibuf): Use get_minibuffer.
6448 (syms_of_minibuf): Use DEFSYM.
6449 (Qmetadata): New var.
6450 * data.c (Qbuffer): Don't make it static.
6451 (syms_of_data): Use DEFSYM.
6452
e003a292
PE
64532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6454
6455 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6456 (CCL_CODE_MIN): New macro.
6457
ed008a6d
PE
64582011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6459
3687c2ef
PE
6460 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6461
ed008a6d
PE
6462 * eval.c (Qdebug): Now static.
6463 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6464 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6465 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6466
d66c4c7c
CY
64672011-05-29 Chong Yidong <cyd@stupidchicken.com>
6468
6469 * image.c: Various fixes to ImageMagick code comments.
6470 (Fimagemagick_types): Doc fix.
6471
5fbc2025
PE
64722011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6473
0196f88a
PE
6474 Minor fixes prompted by GCC 4.6.0 warnings.
6475
6476 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6477
5fbc2025
PE
6478 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6479 (x_clipboard_manager_save_all): Move extern decl to ...
6480 * xterm.h: ... here, so that it can be checked for consistency.
6481
1dd3c2d9
CY
64822011-05-29 Chong Yidong <cyd@stupidchicken.com>
6483
6484 * xselect.c (x_clipboard_manager_save_frame)
6485 (x_clipboard_manager_save_all): New functions.
6486 (Fx_clipboard_manager_save): Lisp function deleted.
6487
6488 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6489 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6490
6491 * xterm.h: Update prototype.
6492
5ba6571d
WX
64932011-05-28 William Xu <william.xwl@gmail.com>
6494
6495 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6496 exiting (Bug#8239).
6497
3eaff834
JM
64982011-05-28 Jim Meyering <meyering@redhat.com>
6499
e1900994 6500 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6501 * fns.c (to_uchar): Define.
6502 (crypto_hash_function): Use it to convert some newly-signed
6503 variables to unsigned, to avoid sign-extension bugs. For example,
6504 without this change, (md5 "truc") would evaluate to
6505 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6506 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6507 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6508
0f6990a7
PE
65092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6510
6511 Integer overflow fixes.
c8a9ca5a 6512
08686060
PE
6513 * dbusbind.c: Serial number integer overflow fixes.
6514 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6515 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6516 to hold a serial number that is too large for a fixnum.
6517 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6518 Check for serial numbers out of range. Decode any serial number
59568bf0 6519 that was so large that it became a float. (Bug#8722)
08686060 6520
2d1fc3c7
PE
6521 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6522 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6523 Use XFASTINT rather than XUINT when numbers are nonnegative.
6524 (xd_append_arg, Fdbus_method_return_internal):
6525 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6526 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6527 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6528 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6529 (Bug#8722)
2d1fc3c7 6530
c8a9ca5a
PE
6531 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6532
519e1d69
PE
6533 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6534
6df6ae42 6535 ccl: Add integer overflow checks.
30569699
PE
6536 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6537 (IN_INT_RANGE): New macros.
6538 (ccl_driver): Use them to check for integer overflow when
6539 decoding a CCL program. Many of the new checks are whether XINT (x)
6540 fits in int; it doesn't always, on 64-bit hosts. The new version
6541 doesn't catch all possible integer overflows, but it's an
847044ea 6542 improvement. (Bug#8719)
30569699 6543
c11285dc
PE
6544 * alloc.c (make_event_array): Use XINT, not XUINT.
6545 There's no need for unsigned here.
6546
fdccd48e
PE
6547 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6548 This follows up to the 2011-05-06 change that substituted uintptr_t
6549 for EMACS_INT. This case wasn't caught back then.
6550
37910ab2
PE
6551 Rework Fformat to avoid integer overflow issues.
6552 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6553 now (part of C89). Include <verify.h>.
6554 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6555 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6556 (Fformat): Avoid the prepass trying to compute sizes; it was only
6557 approximate and thus did not catch overflow reliably. Instead, walk
6558 through the format just once, formatting and computing sizes as we go,
6559 checking for integer overflow at every step, and allocating a larger
6560 buffer as needed. Keep track separately whether the format is
6561 multibyte. Keep only the most-recently calculated precision, rather
6562 than them all. Record whether each argument has been converted to
6563 string. Use EMACS_INT, not int, for byte and char and arg counts.
6564 Support field widths and precisions larger than INT_MAX. Avoid
6565 sprintf's undefined behavior with conversion specifications such as %#d
6566 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6567 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6568 formatting out-of-range floating point numbers with int
9173deec 6569 formats. (Bug#8668)
37910ab2 6570
2e6578fb
PE
6571 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6572
0ae6bdee
PE
6573 * data.c: Avoid integer truncation in expressions involving floats.
6574 * data.c: Include <intprops.h>.
6575 (arith_driver): When there's an integer overflow in an expression
6576 involving floating point, convert the integers to floating point
6577 so that the resulting value does not suffer from catastrophic
6578 integer truncation. For example, on a 64-bit host (* 4
6579 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6580 Do not rely on undefined behavior after integer overflow.
6581
de883a70
PE
6582 merge count_size_as_multibyte, parse_str_to_multibyte
6583 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6584 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6585 Check for integer overflow.
6586 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6587 since it's now a duplicate of the other. This is more of
6588 a character than a buffer op, so better that it's in character.c.
6589 * fns.c, print.c: Adjust to above changes.
6590
2ff916cb
PE
65912011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6592
6593 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6594
f1b54466
PE
65952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6596
fb1ac845
PE
6597 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6598 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6599 (x_clipboard_manager_save): Now static.
6600 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6601
f1b54466
PE
6602 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6603 (crypto_hash_function): Now static.
6604 Fix pointer signedness problems. Avoid unnecessary initializations.
6605
a9f737ee
CY
66062011-05-27 Chong Yidong <cyd@stupidchicken.com>
6607
6608 * termhooks.h (Vselection_alist): Make it terminal-local.
6609
6610 * terminal.c (create_terminal): Initialize it.
6611
6612 * xselect.c: Support for clipboard managers.
6613 (Vselection_alist): Move to termhooks.h as terminal-local var.
6614 (LOCAL_SELECTION): New macro.
6615 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6616 (symbol_to_x_atom): Remove gratuitous arg.
6617 (x_handle_selection_request, lisp_data_to_selection_data)
6618 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6619 (x_own_selection, x_get_local_selection, x_convert_selection):
6620 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6621 (some_frame_on_display): Delete unused function.
6622 (Fx_own_selection_internal, Fx_get_selection_internal)
6623 (Fx_disown_selection_internal, Fx_selection_owner_p)
6624 (Fx_selection_exists_p): New optional frame arg.
6625 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6626 (x_handle_selection_clear): Don't treat other terminals with the
6627 same keyboard specially. Use the terminal-local Vselection_alist.
6628 (x_clear_frame_selections): Use Frun_hook_with_args.
6629
6630 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6631
6632 * xterm.h: Add support for those atoms.
6633
e067f0c1
CY
66342011-05-26 Chong Yidong <cyd@stupidchicken.com>
6635
6636 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6637 (converted_selections, conversion_fail_tag): New global variables.
6638 (x_selection_request_lisp_error): Free the above.
6639 (x_get_local_selection): Remove unnecessary code.
6640 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6641 of converted selections stored in converted_selections.
6642 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6643 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6644 (x_convert_selection): New function.
6645 (x_handle_selection_event): Simplify.
6646 (x_get_foreign_selection): Don't ignore incoming requests while
6647 waiting for an answer; this will fail when we implement
6648 SAVE_TARGETS, and seems unnecessary anyway.
6649 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6650 (Vx_sent_selection_functions): Doc fix.
6651
0f4aebc0
LL
66522011-05-26 Leo Liu <sdl.web@gmail.com>
6653
6654 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6655
e61124cd
YM
66562011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6657
6658 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6659
6660 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6661 for fringe update if it has periodic bitmap.
ac389d0c 6662 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6663 and fringe_bitmap_periodic_p.
6664
6665 * fringe.c (get_fringe_bitmap_data): New function.
6666 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6667 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6668 row. Mark glyph row for fringe update if periodicity changed.
6669
6670 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6671 for fringe update unless it has periodic bitmap.
6672
f16d9837
KH
66732011-05-25 Kenichi Handa <handa@m17n.org>
6674
6675 * xdisp.c (get_next_display_element): Set correct it->face_id for
6676 a static composition.
6677
e1b90ef6
LL
66782011-05-24 Leo Liu <sdl.web@gmail.com>
6679
6680 * deps.mk (fns.o):
6681 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6682
6683 * fns.c (crypto_hash_function, Fsha1): New function.
6684 (Fmd5): Use crypto_hash_function.
6685 (syms_of_fns): Add Ssha1.
6686
7400048f
PE
66872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6688
6689 * gnutls.c: Remove unused macros.
6690 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6691 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6692 Remove macros that are defined and never used.
6693 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6694
abb71cf4
CY
66952011-05-22 Chong Yidong <cyd@stupidchicken.com>
6696
6697 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6698 (Fx_get_selection_internal): Minor cleanup.
6699 (Fx_own_selection_internal): Rename arguments for consistency with
6700 select.el.
6701
6307db39
PE
67022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6703
6704 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6705
f3d4e0a4
CY
67062011-05-22 Chong Yidong <cyd@stupidchicken.com>
6707
6708 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6709
4d8ade89
YM
67102011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6711
6712 * dispnew.c (scrolling_window): Don't exclude the case that the
6713 last enabled row in the desired matrix touches the bottom boundary.
6714
32078c8d
GM
67152011-05-21 Glenn Morris <rgm@gnu.org>
6716
6717 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6718 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6719 and add some more files.
32078c8d 6720
7285dc67
EZ
67212011-05-20 Eli Zaretskii <eliz@gnu.org>
6722
6723 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6724 report_file_error introduced by the change from 2011-05-07.
6725
89d1bd22
PE
67262011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6727
6728 * systime.h (Time): Define only if emacs is defined.
6729 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6730 where the include path doesn't have X11/X.h by default. See
6731 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6732
cd394be1 67332011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6734
6735 * composite.c (find_automatic_composition): Fix previous change.
6736
b9704ad9
GM
67372011-05-20 Glenn Morris <rgm@gnu.org>
6738
6739 * lisp.mk: New file, split from Makefile.in.
6740 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6741 (shortlisp): Remove.
6742 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6743
4a720484
GM
67442011-05-19 Glenn Morris <rgm@gnu.org>
6745
6746 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6747 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6748 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6749 (lisp): Set the order to that of loadup.el.
6750 (shortlisp): Make it a copy of $lisp.
6751 (SOME_MACHINE_LISP): Remove.
6752 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6753 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6754
a28d4396
KH
67552011-05-18 Kenichi Handa <handa@m17n.org>
6756
6757 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6758 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6759 (find_automatic_composition): Mostly rewrite for efficiency.
6760
a2b1fa8e
JB
67612011-05-18 Juanma Barranquero <lekktu@gmail.com>
6762
6763 * makefile.w32-in: Update dependencies.
6764
8e1f5610
CS
67652011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6766
6767 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6768 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6769
7025ee00 67702011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6771
cdfa6eab
PE
6772 Fix some integer overflow issues, such as string length overflow.
6773
06d6db33
PE
6774 * insdel.c (count_size_as_multibyte): Check for string overflow.
6775
2b4560a8
PE
6776 * character.c (lisp_string_width): Check for string overflow.
6777 Use EMACS_INT, not int, for string indexes and lengths; in
6778 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6779 the resulting string length overflows an EMACS_INT; instead,
6780 report a string overflow if no precision given. When checking for
6781 precision exhaustion, use a check that cannot possibly have
6782 integer overflow. (Bug#8675)
6783 * character.h (lisp_string_width): Adjust to new signature.
6784
cb93f9be
PE
6785 * alloc.c (string_overflow): New function.
6786 (Fmake_string): Use it. This doesn't change behavior, but saves
6787 a few bytes and will simplify future changes.
6788 * character.c (string_escape_byte8): Likewise.
6789 * lisp.h (string_overflow): New decl.
6790
1a1f3366
PE
6791 Fixups, following up to the user-interface timestamp change.
6792 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6793 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6794 * msdos.c (mouse_get_pos): Likewise.
6795 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6796 * w32gui.h (Time): Define by including "systime.h" rather than by
6797 declaring it ourselves. (Bug#8664)
6798
d4e3e4d3
PE
6799 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6800 * image.c (clear_image_cache): Likewise.
6801
f6a24d19
PE
6802 * term.c (term_mouse_position): Don't assume time_t wraparound.
6803
08dc5ae6
PE
6804 Be more systematic about user-interface timestamps.
6805 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6806 and sometimes 'EMACS_UINT', to represent these timestamps.
6807 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6808 This makes the code easier to follow, and makes it easier to catch
6809 integer overflow bugs such as Bug#8664.
6810 * frame.c (Fmouse_position, Fmouse_pixel_position):
6811 Use Time, not unsigned long, for user-interface timestamps.
6812 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6813 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6814 * keyboard.h (last_event_timestamp): Likewise.
6815 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6816 * menu.h (xmenu_show): Likewise.
6817 * term.c (term_mouse_position): Likewise.
6818 * termhooks.h (struct input_event.timestamp): Likewise.
6819 (struct terminal.mouse_position_hook): Likewise.
6820 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6821 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6822 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6823 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6824 what it was before.
6825 * menu.h, termhooks.h: Include "systime.h", for Time.
6826
8e55734a
PE
6827 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6828 Don't assume that the difference between two unsigned long values
6829 can fit into an integer. At this point, we know button_down_time
6830 <= event->timestamp, so the difference must be nonnegative, so
6831 there's no need to cast the result if double-click-time is
6832 nonnegative, as it should be; check that it's nonnegative, just in
6833 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6834 apart (about 25 days). (Bug#8664)
8e55734a 6835
841f1b75 6836 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6837 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6838
3e26f69c
PE
6839 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6840 that always fit in int. Use a sentinel instead of a counter, to
6841 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6842 * frame.h (struct frame): Use int for menu_bar_items_used
6843 instead of EMACS_INT, since it always fits in int.
3e26f69c 6844
5cc152c0
PE
6845 * menu.c (grow_menu_items): Check for int overflow.
6846
d89eb65e
PE
6847 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6848
5235bd3e
PE
6849 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6850 Before, the code was not consistent. These values cannot exceed
6851 2**31 - 1 so there's no need to make them unsigned.
6852 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6853 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6854 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6855 as modifiers.
6856 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6857
bc827e23
PE
6858 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6859 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6860 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6861 presumably because the widths might not match.
6862
78eb494e
PE
6863 * window.c (size_window): Avoid needless test at loop start.
6864
04f2d78b
CB
68652011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6866
6867 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6868
d2fc7e3d 68692011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6870
6871 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6872
d2fc7e3d 68732011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6874
6875 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6876 `width' to `bar_area_x' and `bar_area_width', respectively.
6877 (x_scroll_run): Take account of fringe background extension.
6878
04f2d78b
CB
6879 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6880 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6881 `bar_area_width', respectively.
6882 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6883 background extension.
6884
79b70037
GM
68852011-05-10 Jim Meyering <meyering@redhat.com>
6886
6887 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6888
2f142cc5
JB
68892011-05-10 Juanma Barranquero <lekktu@gmail.com>
6890
6891 * image.c (Finit_image_library): Return t for built-in image types,
6892 like pbm and xbm. (Bug#8640)
6893
57679c86
AS
68942011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6895
6896 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6897
888c9e86
EZ
68982011-05-07 Eli Zaretskii <eliz@gnu.org>
6899
b0512a1d
EZ
6900 * w32console.c (Fset_screen_color): Doc fix.
6901 (Fget_screen_color): New function.
6902 (syms_of_ntterm): Defsubr it.
6903
7285dc67
EZ
6904 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6905 unlink the temporary file if Fcall_process didn't create it in the
6906 first place.
6907 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6908 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6909 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6910 cue to call_process_cleanup not to close that handle.
6911
4d3fcc8e
BK
69122011-05-07 Ben Key <bkey76@gmail.com>
6913
6914 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6915 one of two shell specific rules, either bootstrap-temacs-CMD or
6916 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6917 to the previous implementation of the bootstrap-temacs rule.
6918 The bootstrap-temacs-CMD rule is similar to the previous
6919 implementation of the bootstrap-temacs rule except that it
6920 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6921 variable.
6922
6923 These changes, along with some changes to nt/configure.bat,
6924 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6925 earlier fix to add support for --cflags and --ldflags options
6926 that include quotes so that it works whether make uses cmd or
6927 sh as the shell.
6928
b4289b64
MA
69292011-05-06 Michael Albinus <michael.albinus@gmx.de>
6930
6931 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6932 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6933 is a constant.
6934 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6935 a string. Handle both cases.
6936 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6937 (Fdbus_register_method): Use Qinvalid_function.
6938
af4c0e28
JB
69392011-05-06 Juanma Barranquero <lekktu@gmail.com>
6940
6941 * makefile.w32-in: Update dependencies.
6942 (LISP_H): Add inttypes.h and stdin.h.
6943 (PROCESS_H): Add unistd.h.
6944
c51453d9
EZ
69452011-05-06 Eli Zaretskii <eliz@gnu.org>
6946
6947 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6948 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6949
8ff0ac3c 69502011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6951
4c4b566b
PE
6952 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6953
aab2b9b5
PE
6954 * term.c (vfatal): Remove stray call to va_end.
6955 It's not needed and the C Standard doesn't allow it here anyway.
6956
c378da0b
PE
6957 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6958 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6959
288b08c7
PE
6960 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6961 bytes.
6962
e3601888
PE
6963 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6964
db6c0e74
PE
6965 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6966
dd5963ea
PE
6967 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6968
88c9450f
PE
6969 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6970
2f9442b8
PE
6971 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6972
c032b5f8
PE
6973 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6974 * charset.c (Fdefine_charset_internal): Don't initialize
6975 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6976 32-bit int (Bug#8600).
a108c10b
PE
6977
6978 * lread.c (read_integer): Be more consistent with string-to-number.
6979 Use string_to_number to do the actual conversion; this avoids
6980 rounding errors and fixes some other screwups. Without this fix,
6981 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6982 (digit_to_number): Move earlier, for benefit of read_integer.
6983 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6984 not a digit in any supported base. (Bug#8602)
a108c10b 6985
ad5f9eea
PE
6986 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6987
aec1708a
PE
6988 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6989 to match comment at start of function. This also removes a
6990 GCC warning about overflow in a 32+64-bit port.
6991
47be4ab5
PE
6992 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6993
371cac43
PE
6994 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6995 Reported by Stefan Monnier in
6996 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6997 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6998 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6999
d01a7826
PE
7000 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7001 (EMACS_UINTPTR): Likewise, with uintptr_t.
7002
7fd47d5c
PE
7003 * lisp.h: Prefer 64-bit EMACS_INT if available.
7004 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7005 on 32-bit hosts that have 64-bit int, so that they can access
7006 large files.
122b0c86
PE
7007 However, temporarily disable this change unless the temporary
7008 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7009
8727937b
PE
7010 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7011
8ac068ac
PE
7012 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7013 This removes an assumption that EMACS_INT and long are the same
7014 width as pointers. The assumption is true for Emacs porting targets
7015 now, but we want to make other targets possible.
7016 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7017 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7018 In the rest of the code, change types of integers that hold casted
7019 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7020 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7021 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7022 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7023 No need to cast type when ORing.
7024 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7025 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7026 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7027 assume EMACS_INT is the same width as char *.
7028 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7029 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7030 Remove no-longer-needed casts.
7031 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7032 (xg_tool_bar_help_callback, xg_make_tool_item):
7033 Use EMACS_INTPTR to hold an integer
7034 that will be cast to void *; this can avoid a GCC warning
7035 if EMACS_INT is not the same width as void *.
7036 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7037 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7038 (current_message_1, set_message_1):
7039 Use a local to convert to proper width without a cast.
7040 * xmenu.c (dialog_selection_callback): Likewise.
7041
ede49d71
PE
7042 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7043 Also, don't assume VALBITS / RAND_BITS is less than 5,
7044 and don't rely on undefined behavior when shifting a 1 left into
7045 the sign bit.
7046 * lisp.h (get_random): Change signature to match.
7047
2f30ecd0
PE
7048 * lread.c (hash_string): Use size_t, not int, for hash computation.
7049 Normally we prefer signed values; but hashing is special, because
7050 it's better to use unsigned division on hash table sizes so that
7051 the remainder is nonnegative. Also, size_t is the natural width
7052 for hashing into memory. The previous code used 'int', which doesn't
7053 retain enough info to hash well into very large tables.
7054 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7055
2a866e7b
PE
7056 * dbusbind.c: Don't possibly lose pointer info when converting.
7057 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7058 Use XPNTR rather than XHASH, so that the high-order bits of
7059 the pointer aren't lost when converting through void *.
7060
51639eac
PE
7061 * eval.c (Fautoload): Don't double-shift a pointer.
7062
92394119
PE
7063 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7064
dbdb9a7c
JB
70652011-05-06 Juanma Barranquero <lekktu@gmail.com>
7066
7067 * gnutls.c (DEF_GNUTLS_FN):
7068 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7069
db7a0b4f
AS
70702011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7071
7072 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7073 marker. (Bug#8610)
7074
cd394be1 70752011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7076
7077 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7078 New version that can reserve upto 2GB of heap space.
7079
f7ff1b0f 70802011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7081
7082 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7083
639c109b
TZ
70842011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7085
7086 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7087 `gnutls_certificate_set_x509_key_file'.
7088
d2127135
JB
70892011-05-05 Juanma Barranquero <lekktu@gmail.com>
7090
7091 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7092 Update dependencies.
7093
e968f4f3
JB
70942011-05-04 Juanma Barranquero <lekktu@gmail.com>
7095
7096 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7097 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7098 Remove unused parameter `fildes'.
7099 * process.c (read_process_output, send_process): Don't pass it.
7100
84d358f0
JB
71012011-05-04 Juanma Barranquero <lekktu@gmail.com>
7102
7103 Fix previous change: the library cache is defined in w32.c.
7104 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7105 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7106
0898ca10
JB
71072011-05-04 Juanma Barranquero <lekktu@gmail.com>
7108
7109 Implement dynamic loading of GnuTLS on Windows.
7110
7111 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7112 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7113 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7114 Declare.
7115
7116 * gnutls.c (Qgnutls_dll): Define.
7117 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7118 (gnutls_*): Declare function pointers.
7119 (init_gnutls_functions): New function to initialize function pointers.
7120 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7121 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7122 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7123 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7124 (emacs_gnutls_write, emacs_gnutls_read)
7125 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7126 (Fgnutls_available_p): New function.
7127 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7128 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7129 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7130
7131 * image.c: Include w32.h.
7132 (Vimage_type_cache): Delete.
7133 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7134 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7135 (w32_delayed_load): Move to w32.c.
7136
7137 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7138
7139 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7140 (w32_delayed_load): Move from image.c. When loading a library, record
7141 its filename in the :loaded-from property of the library id.
7142 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7143 Initialize and staticpro them.
7144 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7145
7146 * process.c: Include lisp.h before w32.h, not after.
7147 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7148 instead of gnutls_record_check_pending.
7149
7150 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7151
ff4de4aa
TZ
71522011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7153
7154 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7155 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7156 as passed in.
7157
abe95abb
JD
71582011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7159
7160 * xterm.c (x_set_frame_alpha): Do not set property on anything
7161 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7162
e16e55d4
JB
71632011-05-02 Juanma Barranquero <lekktu@gmail.com>
7164
7165 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7166
bafcf6a5
JB
71672011-05-02 Juanma Barranquero <lekktu@gmail.com>
7168
7169 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7170 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7171 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7172 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7173 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7174 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7175 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7176 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7177 (Qgnutls_bootprop_callbacks_verify): Make static.
7178
e7a6747f
AS
71792011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7180
19ed11ba
AS
7181 * callproc.c: Indentation fixup.
7182
e7a6747f 7183 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7184 (wait_for_termination, interruptible_wait_for_termination):
7185 Move after wait_for_termination_1.
e7a6747f 7186
1ef14cb4
LMI
71872011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7188
7189 * sysdep.c (interruptible_wait_for_termination): New function
7190 which is like wait_for_termination, but allows keyboard
7191 interruptions.
7192
7193 * callproc.c (Fcall_process): Add (:file "file") as an option for
7194 the STDOUT buffer.
7195 (Fcall_process_region): Ditto.
7196
330d880c
EZ
71972011-04-30 Eli Zaretskii <eliz@gnu.org>
7198
8db90b73
EZ
7199 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7200 rather than `XVECTOR (FOO)->size'.
7201
330d880c
EZ
7202 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7203 inttypes.h, as a gnulib replacement is used if it not available in
7204 system headers.
7205
15cbd324
EZ
72062011-04-21 Eli Zaretskii <eliz@gnu.org>
7207
7208 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7209 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7210 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7211
7212 * coding.c (coding_alloc_by_realloc): Error out if destination
7213 will grow beyond MOST_POSITIVE_FIXNUM.
7214 (decode_coding_emacs_mule): Abort if there isn't enough place in
7215 charbuf for the composition carryover bytes. Reserve an extra
7216 space for up to 2 characters produced in a loop.
7217 (decode_coding_iso_2022): Abort if there isn't enough place in
7218 charbuf for the composition carryover bytes.
7219
72202011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7221
ae940cca
EZ
7222 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7223 aborting when %lld or %lll format is passed.
7224 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7225 %llo or %llx format is passed. (Bug#8545)
7226
03ab8921
EZ
7227 * window.c (window_scroll_line_based): Use a marker instead of
7228 simple variables to record original value of point. (Bug#7952)
7229
afda1437
EZ
7230 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7231 produced by %s or %c overflows available buffer space. (Bug#8545)
7232
f76dee0c
PE
72332011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7234
7235 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7236 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7237
fdc5744d
JB
72382011-04-28 Juanma Barranquero <lekktu@gmail.com>
7239
7240 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7241
638f053a
JB
72422011-04-28 Juanma Barranquero <lekktu@gmail.com>
7243
7244 * keyboard.c (Qdelayed_warnings_hook): Define.
7245 (command_loop_1): Run `delayed-warnings-hook'
7246 if Vdelayed_warnings_list is non-nil.
7247 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7248 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7249
d178f871
EZ
72502011-04-28 Eli Zaretskii <eliz@gnu.org>
7251
7252 * doprnt.c (doprnt): Don't return value smaller than the buffer
7253 size if the message was truncated. (Bug#8545).
7254
b124fd93
JB
72552011-04-28 Juanma Barranquero <lekktu@gmail.com>
7256
7257 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7258 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7259
e810457d
PE
72602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7261
7262 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7263
ea51cceb
JB
72642011-04-27 Juanma Barranquero <lekktu@gmail.com>
7265
7266 * makefile.w32-in: Update dependencies.
7267
94dcfacf
EZ
72682011-04-27 Eli Zaretskii <eliz@gnu.org>
7269
7270 Improve `doprnt' and its usage. (Bug#8545)
7271 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7272 `format_end'. Remove support for %l as a conversion specifier.
7273 Don't use xrealloc. Improve diagnostics when the %l size modifier
7274 is used. Update the commentary.
7275
7276 * eval.c (verror): Simplify calculation of size_t.
7277
7278 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7279 messages.
7280
f61f41d7
PE
72812011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7282
7283 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7284 change.
7285
96fb4434
PE
72862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7287
7288 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7289 This makes this file independent of the recent pseudovector change.
7290
671875da 72912011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7292
69e9b5a3
PE
7293 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7294
b5f869a7 7295 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7296 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7297 Remove unused local.
c8926152 7298 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7299
841a1577 7300 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7301 GCC 4.6.0 optimizes based on type-based alias analysis.
7302 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7303 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7304 != &v->size, and therefore "v->size = 1; b->size = 2; return
7305 v->size;" must therefore return 1. This assumption is incorrect
7306 for Emacs, since it type-puns struct Lisp_Vector * with many other
7307 types. To fix this problem, this patch adds a new type struct
f904488f 7308 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7309 and pseudovectors, and helps optimizing compilers not get fooled
7310 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7311 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7312 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7313 the size member.
eab3844f
PE
7314 (XSETPVECTYPE): Rewrite in terms of new macro.
7315 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7316 This is a bit clearer, and further avoids the possibility of
7317 undesirable aliasing.
7318 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7319 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7320 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7321 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7322 (ASIZE): Now uses header.size rather than size.
7323 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7324 to avoid the hassle of writing XVECTOR (foo)->header.size.
7325 (struct vectorlike_header): New type.
eab3844f
PE
7326 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7327 object, to help avoid aliasing.
7328 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7329 (SUBRP): Likewise, since Lisp_Subr is a special case.
7330 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7331 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7332 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7333 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7334 changed to be "header.size" and "header.next".
7335 * buffer.h (struct buffer): Likewise.
7336 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7337 * frame.h (struct frame): Likewise.
7338 * process.h (struct Lisp_Process): Likewise.
7339 * termhooks.h (struct terminal): Likewise.
7340 * window.c (struct save_window_data, struct saved_window): Likewise.
7341 * window.h (struct window): Likewise.
7342 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7343 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7344 * buffer.c (init_buffer_once): Likewise.
7345 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7346 special case.
7347 * process.c (Fformat_network_address): Use local var for size,
7348 for brevity.
7349
0df1eac5
PE
7350 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7351
847ab9d1 7352 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7353 * data.c (atof): Remove decl; no longer used or needed.
7354 (digit_to_number): Move to lread.c.
7355 (Fstring_to_number): Use new string_to_number function, to be
7356 consistent with how the Lisp reader treats infinities and NaNs.
7357 Do not assume that floating-point numbers represent EMACS_INT
7358 without losing information; this is not true on most 64-bit hosts.
7359 Avoid double-rounding errors, by insisting on integers when
7360 parsing non-base-10 numbers, as the documentation specifies.
7361 * lisp.h (string_to_number): New decl, replacing ...
7362 (isfloat_string): Remove.
bc0a5c13 7363 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7364 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7365 appears to have been a coding error. Similarly, do not accept
7366 strings like +-1e0 as floating point numbers. Do not report
7367 overflow for integer overflows unless the base is not 10 which
7368 means we have no simple and reliable way to continue.
7369 Break out the floating-point parsing into a new
7370 function string_to_number, so that Fstring_to_number parses
7371 floating point numbers consistently with the Lisp reader.
04f2d78b 7372 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7373 (E_CHAR, EXP_INT): Remove, replacing with ...
7374 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7375 (string_to_number): New function, replacing isfloat_string.
7376 This function checks for valid syntax and produces the resulting
7377 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7378 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7379 so that overflow for non-base-10 numbers is reported only when
7380 there's no portable and simple way to convert to floating point.
452f4150 7381
67769ffc
PE
7382 * textprop.c (set_text_properties_1): Rewrite for clarity,
7383 and to avoid GCC warning about integer overflow.
7384
c20db43f
PE
7385 * intervals.h (struct interval): Use EMACS_INT for members
7386 where EMACS_UINT might cause problems. See
7387 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7388 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7389 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7390 All uses changed.
37aa2f85
PE
7391 (offset_intervals): Tell GCC not to worry about length overflow
7392 when negating a negative length.
c20db43f 7393
2538aa2f
PE
7394 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7395 (overrun_check_free): Likewise.
7396
f2d3008d
PE
7397 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7398 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7399 word size.
7400
ec8df744
PE
7401 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7402 (gnutls_make_error): Rename local to avoid shadowing.
7403 (gnutls_emacs_global_deinit): ifdef out; not used.
7404 (Fgnutls_boot): Use const for pointer to readonly storage.
7405 Comment out unused local. Fix pointer signedness problems.
7406
640ee02d
PE
7407 * lread.c (openp): Don't stuff size_t into an 'int'.
7408 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7409 about possible signed overflow.
7410
6048fb2a
PE
7411 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7412 (GDK_KEY_g): Don't define if already defined.
7413 (xg_prepare_tooltip): Avoid pointer signedness problem.
7414 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7415
fa3c87e1
PE
7416 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7417 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7418
2172544b
PE
7419 * xfns.c (Fx_window_property): Simplify a bit,
7420 to make a bit faster and to avoid GCC 4.6.0 warning.
7421 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7422
9b821a21
PE
7423 * fns.c (internal_equal): Don't assume size_t fits in int.
7424
3c616cfa
PE
7425 * alloc.c (compact_small_strings): Tighten assertion a little.
7426
c2982e87
PE
7427 Replace pEd with more-general pI, and fix some printf arg casts.
7428 * lisp.h (pI): New macro, generalizing old pEd macro to other
7429 conversion specifiers. For example, use "...%"pI"d..." rather
7430 than "...%"pEd"...".
7431 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7432 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7433 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7434 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7435 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7436 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7437 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7438 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7439 64-bit hosts.
7440 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7441 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7442 * print.c (safe_debug_print, print_object): Likewise.
7443 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7444 to int.
6f04d126
PE
7445 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7446 avoiding the 0 flag, which is not portable.
c2982e87
PE
7447 * process.c (Fmake_network_process): Use pI to avoid cast.
7448 * region-cache.c (pp_cache): Likewise.
7449 * xdisp.c (decode_mode_spec): Likewise.
7450 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7451 behavior on 64-bit hosts with printf arg.
6f04d126 7452 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7453 (x_stop_queuing_selection_requests): Likewise.
7454 (x_get_window_property): Don't truncate byte count to an 'int'
7455 when tracing.
0b432f21 7456
5e073ec7
PE
7457 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7458 here, since it parses constructs like leading '-' and spaces,
7459 which are not wanted; and it overflows with large numbers.
7460 Instead, simply match F[0-9]+, which is what is wanted anyway.
7461
36372bf9
PE
7462 * alloc.c: Remove unportable assumptions about struct layout.
7463 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7464 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7465 (allocate_vectorlike, make_pure_vector): Use the new macros,
7466 plus offsetof, to remove unportable assumptions about struct layout.
7467 These assumptions hold on all porting targets that I know of, but
7468 they are not guaranteed, they're easy to remove, and removing them
7469 makes further changes easier.
7470
0b432f21
PE
7471 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7472 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7473 (string_overrun_cookie): Now const. Use initializers that
7474 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7475 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7476 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7477 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7478 multiple of sizeof (EMACS_INT); it need not be, if
7479 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7480 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7481
895009e1
JB
74822011-04-26 Juanma Barranquero <lekktu@gmail.com>
7483
7484 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7485
6a7a1b0b
TZ
74862011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7487
7488 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7489 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7490 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7491
841a1577 74922011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7493
7494 * lisp.h (Qdebug): List symbol.
895009e1 7495 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7496 * keyboard.c (debug-on-event): New variable.
7497 (handle_user_signal): Break into debugger when debug-on-event
7498 matches the current signal symbol.
7499
f2d3ba6f
DN
75002011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7501
7502 * alloc.c (check_sblock, check_string_bytes)
7503 (check_string_free_list): Convert to standard C.
7504
42ce4c63
TZ
75052011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7506
7507 * w32.c (emacs_gnutls_push): Fix typo.
7508
825cd63c
EZ
75092011-04-25 Eli Zaretskii <eliz@gnu.org>
7510
fb11d64d
EZ
7511 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7512 "cast to pointer from integer of different size".
7513
825cd63c
EZ
7514 Improve doprnt and its use in verror. (Bug#8545)
7515 * doprnt.c (doprnt): Document the set of format control sequences
7516 supported by the function. Use SAFE_ALLOCA instead of always
7517 using `alloca'.
7518
7519 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7520 is one byte too soon. Don't use xrealloc; instead xfree and
7521 xmalloc anew.
7522
e061a11b
TZ
75232011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7524
7525 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7526 callbacks stage.
7527
7528 * gnutls.c: Renamed global_initialized to
7529 gnutls_global_initialized. Added internals for the
7530 :verify-hostname-error, :verify-error, and :verify-flags
7531 parameters of `gnutls-boot' and documented those parameters in the
7532 docstring. Start callback support.
9173deec
JB
7533 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7534 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7535 on error. Return error code.
e061a11b
TZ
7536 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7537 (emacs_gnutls_read): Likewise.
7538 (Fgnutls_boot): Return handshake error code.
7539 (emacs_gnutls_handle_error): New function.
7540 (wsaerror_to_errno): Likewise.
7541
7542 * w32.h (emacs_gnutls_pull): Add prototype.
7543 (emacs_gnutls_push): Likewise.
7544
7545 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7546 (emacs_gnutls_push): Likewise.
7547
75482011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7549
7550 * process.c (wait_reading_process_output): Check if GnuTLS
7551 buffered some data internally if no FDs are set for TLS
7552 connections.
7553
7554 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7555 (LIBS): Link to USER_LIBS.
7556 ($(BLD)/gnutls.$(0)): New target.
7557
fa6996bc
EZ
75582011-04-24 Eli Zaretskii <eliz@gnu.org>
7559
eb35682e
EZ
7560 * xdisp.c (handle_single_display_spec): Rename the
7561 display_replaced_before_p argument into display_replaced_p, to
7562 make it consistent with the commentary. Fix typos in the
7563 commentary.
7564
e2ad650c
EZ
7565 * textprop.c (syms_of_textprop): Remove dead code.
7566 (copy_text_properties): Delete obsolete commentary about an
7567 interface that was deleted long ago. Fix typos in the description
7568 of arguments.
7569
1b2de274
EZ
7570 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7571 to changes in oldXMenu/XMenu.h from 2011-04-16.
7572 <menu_help_message, prev_menu_help_message>: Constify.
7573 (IT_menu_make_room): menu->help_text is now `const char **';
7574 adjust.
7575
7576 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7577 to changes in oldXMenu/XMenu.h from 2011-04-16.
7578 (struct XMenu): Declare `help_text' `const char **'.
7579
7580 * xfaces.c <Qunspecified>: Make extern again.
7581
7582 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7583 required by POSIX.
1b2de274 7584
762b15be
EZ
7585 * doc.c (get_doc_string): Improve the format passed to `error'.
7586
7587 * doprnt.c (doprnt): Improve commentary.
7588
7589 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7590
7591 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7592 them with etags.
7593
f1052e5d
EZ
7594 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7595 changes in globals.h immediately force recompilation.
762b15be
EZ
7596 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7597 $(CURDIR)/s/ms-w32.h.
7598 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7599
fa6996bc
EZ
7600 * character.c (Fchar_direction): Function deleted.
7601 (syms_of_character): Don't defsubr it.
7602 <char-direction-table>: Deleted.
7603
e6c3da20
EZ
76042011-04-23 Eli Zaretskii <eliz@gnu.org>
7605
7606 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7607 * doprnt.c: Include limits.h.
7608 (SIZE_MAX): New macro.
04f2d78b
CB
7609 (doprnt): Return a size_t value. 2nd arg is now size_t.
7610 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7611 Improve overflow protection. Support `l' modifier for integer
7612 conversions. Support %l conversion. Don't assume an EMACS_INT
7613 argument for integer conversions and for %c.
7614
7615 * lisp.h (doprnt): Restore prototype.
7616
7617 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7618 $(SRC)/character.h.
7619
7620 * Makefile.in (base_obj): Add back doprnt.o.
7621
7622 * deps.mk (doprnt.o): Add back prerequisites.
7623 (callint.o): Depend on character.h.
7624
7625 * eval.c (internal_lisp_condition_case): Include the handler
7626 representation in the error message.
7627 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7628 when breaking from the loop.
7629
7630 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7631
7632 * callint.c (Fcall_interactively): When displaying error message
7633 about invalid control letter, pass the character's codepoint, not
7634 a pointer to its multibyte form. Improve display of the character
7635 in octal and display also its hex code.
7636
7637 * character.c (char_string): Use %x to display the (unsigned)
7638 codepoint of an invalid character, to avoid displaying a bogus
7639 negative value.
7640
7641 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7642 `error', not SYMBOL_NAME itself.
7643
7644 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7645 character arguments to `error'.
7646
7647 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7648 to `error' in error message about FINAL_CHAR argument. Make sure
7649 FINAL_CHAR is a character, and use %c when it is passed as
7650 argument to `error'.
7651
4ffd0d6b 76522011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7653
7654 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7655
7656 * w32.c: Include <time.h>.
7657 (sys_localtime): New function.
7658
4ffd0d6b 76592011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7660
7661 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7662
4ffd0d6b 7663 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7664
4ffd0d6b 76652011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7666
4ffd0d6b
GM
7667 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7668 zombies (Bug#8467).
aac0c6e3 7669
04c56954
EZ
76702011-04-19 Eli Zaretskii <eliz@gnu.org>
7671
7672 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7673 gl_state.e_property when gl_state.object is Qt.
7674
7675 * insdel.c (make_gap_larger): Remove limitation of buffer size
7676 to <= INT_MAX.
7677
16a43933
CY
76782011-04-18 Chong Yidong <cyd@stupidchicken.com>
7679
7680 * xdisp.c (lookup_glyphless_char_display)
7681 (produce_glyphless_glyph): Handle cons cell entry in
7682 glyphless-char-display.
7683 (Vglyphless_char_display): Document it.
7684
7685 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7686 glyphless-char-display.
7687
4581706e
CY
76882011-04-17 Chong Yidong <cyd@stupidchicken.com>
7689
7690 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7691
7692 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7693
7694 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7695 definition for no-X builds.
7696
4887c6e2 76972011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7698
fd35b6f9
PE
7699 Static checks with GCC 4.6.0 and non-default toolkits.
7700
5c1ccb01
PE
7701 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7702
006c5daa
PE
7703 * process.c (keyboard_bit_set): Define only if SIGIO.
7704 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7705 (send_process): Repair possible setjmp clobbering.
7706
efc736d3
PE
7707 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7708
4e2fe2e6
PE
7709 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7710
f97334a2
PE
7711 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7712
4e75f29d
PE
7713 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7714 Define only if needed.
7715
90efadd1
PE
7716 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7717 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7718 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7719
3c647824
PE
7720 * dispextern.h (struct redisplay_interface): Rename param
7721 to avoid shadowing.
e264f262 7722 * termhooks.h (struct terminal): Likewise.
761383f4 7723 * xterm.c (xembed_send_message): Likewise.
3c647824 7724
b58c5c4a
PE
7725 * insdel.c (make_gap_smaller): Define only if
7726 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7727
cad59032
PE
7728 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7729 it.
7730
c339dc2e
PE
7731 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7732 so that we aren't warned about unused symbols.
7733
91a3e27b
PE
7734 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7735
399c71d3 7736 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7737
8ffc96f5
PE
7738 * xfns.c (x_real_positions): Mark locals as initialized.
7739
eef9bc79
PE
7740 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7741
098db9dd
PE
7742 * xterm.c: Fix problems found by static analysis with other toolkits.
7743 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7744 (x_dispatch_event): Declare static if USE_GTK, and
7745 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7746 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7747 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7748 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7749 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7750
eb18f6cc
PE
7751 * xmenu.c (menu_help_callback): Pointer type fixes.
7752 Use const pointers when pointing at readonly data. Avoid pointer
7753 signedness clashes.
7754 (FALSE): Remove unused macro.
7755 (update_frame_menubar): Remove unused decl.
7756
1fe72bf8
PE
7757 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7758
60d9e1db
PE
7759 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7760 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7761 (single_menu_item): Rename local to avoid shadowing.
7762
39261c26
PE
7763 * keyboard.c (make_lispy_event): Remove unused local var.
7764
018c5e19
PE
7765 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7766 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7767
63d2b86e
PE
7768 * bitmaps: Change bitmaps from unsigned char back to the X11
7769 compatible char. Avoid the old compiler warnings about
7770 out-of-range initializers by using, for example, '\xab' rather
7771 than 0xab.
7772
aefd87e1
PE
7773 * xgselect.c (xgselect_initialize): Check vs interface
7774 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7775
bf501fb9
PE
7776 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7777
e9829fdf
PE
7778 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7779 to read-only memory.
7780
1086c095
PE
7781 * fns.c (vector): Remove; this old hack is no longer needed.
7782
2baccd04 7783 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7784 Remove unused var.
dde42981 7785 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7786
72391843 7787 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7788
436c16df 7789 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7790 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7791 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7792
92bb796d 7793 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7794 (x_term_init): Remove local to avoid shadowing.
92bb796d 7795
764430a3 7796 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7797
7798 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7799 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7800
d1dfb56c
EZ
78012011-04-16 Eli Zaretskii <eliz@gnu.org>
7802
c4354cb4
EZ
7803 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7804
d1dfb56c
EZ
7805 Fix regex.c, syntax.c and friends for buffers > 2GB.
7806 * syntax.h (struct gl_state_s): Declare character position members
7807 EMACS_INT.
7808
7809 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7810
04f2d78b
CB
7811 * textprop.c (verify_interval_modification, interval_of):
7812 Declare arguments EMACS_INT.
d1dfb56c
EZ
7813
7814 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7815 EMACS_INT.
7816
7817 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7818
7819 * indent.c (Fvertical_motion): Local variable it_start is now
7820 EMACS_INT.
7821
7822 * regex.c (re_match, re_match_2, re_match_2_internal)
7823 (bcmp_translate, regcomp, regexec, print_double_string)
7824 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7825 (re_compile_pattern, re_exec): Declare arguments and local
7826 variables `size_t' and `ssize_t' and return values `regoff_t', as
7827 appropriate.
7828 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7829 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7830 <compile_stack_type>: `size' and `avail' are now `size_t'.
7831
7832 * regex.h <regoff_t>: Use ssize_t, not int.
7833 (re_search, re_search_2, re_match, re_match_2): Arguments that
7834 specify buffer/string position and length are now ssize_t and
7835 size_t. Return type is regoff_t.
7836
613052cd
BK
78372011-04-16 Ben Key <bkey76@gmail.com>
7838
7839 * nsfont.m: Fixed bugs in ns_get_family and
7840 ns_descriptor_to_entity that were caused by using free to
7841 deallocate memory blocks that were allocated by xmalloc (via
7842 xstrdup). This caused Emacs to crash when compiled with
7843 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7844 --enable-checking=xmallocoverrun). xfree is now used to
7845 deallocate these memory blocks.
7846
4170f62f 78472011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7848
71b41406
PE
7849 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7850
9587a89d
PE
7851 emacs_write: Accept and return EMACS_INT for sizes.
7852 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7853 et seq.
7854 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7855 Accept and return EMACS_INT.
7856 (emacs_gnutls_write): Return the number of bytes written on
7857 partial writes.
7858 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7859 (emacs_read, emacs_write): Remove check for negative size, as the
7860 Emacs source code has been audited now.
9587a89d
PE
7861 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7862 (emacs_read, emacs_write): Use it.
273a5f82
PE
7863 * process.c (send_process): Adjust to the new signatures of
7864 emacs_write and emacs_gnutls_write. Do not attempt to store
7865 a byte offset into an 'int'; it might overflow.
9587a89d 7866 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7867
3e047f51
PE
7868 * sound.c: Don't assume sizes fit in 'int'.
7869 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7870 Return EMACS_INT, not int.
3e047f51 7871 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7872 Accept EMACS_INT, not int.
7873 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7874 record read return values.
7875
cc39a9db
BK
78762011-04-15 Ben Key <bkey76@gmail.com>
7877
c9d0ec6d
JB
7878 * keyboard.c (Qundefined): Don't declare static since it is used
7879 in nsfns.m.
7880 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7881 static since they are used in nsfont.m.
cc39a9db 7882
6c60eb9f
SM
78832011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7884
7885 * process.c (Qprocessp): Don't declare static.
7886 * lisp.h (Qprocessp): Declare again.
7887
7990b61a
JB
78882011-04-15 Juanma Barranquero <lekktu@gmail.com>
7889
7890 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7891
5d4cb038
PE
78922011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7893
8bd7b830 7894 Improve C-level modularity by making more things 'static'.
cd64ea1d 7895
e3b27b31
PE
7896 Don't publish debugger-only interfaces to other modules.
7897 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7898 (verify_bytepos, count_markers): Move decls to the only modules
7899 that need them.
7900 * region-cache.h (pp_cache): Likewise.
7901 * window.h (check_all_windows): Likewise.
7902 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7903
5d4cb038
PE
7904 * sysdep.c (croak): Now static, if
7905 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7906 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7907
7908 * alloc.c (refill_memory_reserve): Now static if
7909 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7910 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7911
e87b6180
PE
7912 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7913 Define only if USE_LUCID.
7914
ac64929e
PE
7915 * xrdb.c (x_customization_string, x_rm_string): Now static.
7916
6f37259d
PE
7917 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7918 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7919
1683e3ab
PE
7920 * xdisp.c (draw_row_with_mouse_face): Now static.
7921 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7922
de9c2632
PE
7923 * window.h (check_all_windows): Mark externally visible.
7924
2b96acb7
PE
7925 * window.c (window_deletion_count): Now static.
7926
7927 * undo.c: Make symbols static if they're not exported.
7928 (last_undo_buffer, last_boundary_position, pending_boundary):
7929 Now static.
7930
50436f33
PE
7931 * textprop.c (interval_insert_behind_hooks): Now static.
7932 (interval_insert_in_front_hooks): Likewise.
7933
64520e5c
PE
7934 * term.c: Make symbols static if they're not exported.
7935 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7936 (max_frame_lines, tty_set_terminal_modes):
7937 (tty_reset_terminal_modes, tty_turn_off_highlight):
7938 (get_tty_terminal): Now static.
7939 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7940 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7941 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7942 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7943 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7944
1fa53021
PE
7945 * sysdep.c: Make symbols static if they're not exported.
7946 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7947 Now static.
7948 (sigprocmask_set, full_mask): Remove; unused.
7949 (wait_debugging): Mark as visible.
7950 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7951 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7952
d4b43b22
PE
7953 * syntax.c (syntax_temp): Define only if !__GNUC__.
7954
b7c513d0
PE
7955 * sound.c (current_sound_device, current_sound): Now static.
7956
989b29ad
PE
7957 * search.c (searchbufs, searchbuf_head): Now static.
7958
13a55a78
PE
7959 * scroll.c (scroll_cost): Remove; unused.
7960 * dispextern.h (scroll_cost): Remove decl.
7961
de68a1fc
PE
7962 * region-cache.h (pp_cache): Mark as externally visible.
7963
40ccffa6
PE
7964 * process.c: Make symbols static if they're not exported.
7965 (process_tick, update_tick, create_process, chan_process):
7966 (Vprocess_alist, proc_buffered_char, datagram_access):
7967 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7968 (deactivate_process): Mark defn as static, as well as decl.
7969 * lisp.h (create_process): Remove decl.
7970 * process.h (chan_process, Vprocess_alist): Remove decls.
7971
ad64fc97
PE
7972 * print.c: Make symbols static if they're not exported.
7973 (print_depth, new_backquote_output, being_printed, print_buffer):
7974 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7975 (print_interval, print_number_index, initial_stderr_stream):
7976 Now static.
7977 * lisp.h (Fprinc): Remove decl.
7978 (debug_output_compilation_hack): Mark as externally visible.
7979
adddb265
PE
7980 * sysdep.c (croak): Move decl from here to syssignal.h.
7981 * syssignal.h (croak): Put it here, so the API can be checked when
7982 'croak' is called from dissociate_if_controlling_tty.
7983
1717ede2
PE
7984 * minibuf.c: Make symbols static if they're not exported.
7985 (minibuf_save_list, choose_minibuf_frame): Now static.
7986 * lisp.h (choose_minibuf_frame): Remove decl.
7987
fa5fb2bc
PE
7988 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7989
1e3890d1
PE
7990 * lread.c: Make symbols static if they're not exported.
7991 (read_objects, initial_obarray, oblookup_last_bucket_number):
7992 Now static.
7993 (make_symbol): Remove; unused.
7994 * lisp.h (initial_obarray, make_symbol): Remove decls.
7995
8a1414fa
PE
7996 * keyboard.c: Make symbols static if they're not exported.
7997 (single_kboard, recent_keys_index, total_keys, recent_keys):
7998 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7999 (this_single_command_key_start, echoing, last_auto_save):
8000 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8001 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8002 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8003 (Vlispy_mouse_stem, double_click_count):
8004 Now static.
8005 (force_auto_save_soon): Define only if SIGDANGER.
8006 (ignore_mouse_drag_p): Now static if
8007 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8008 (print_help): Remove; unused.
8009 (stop_character, last_timer_event): Mark as externally visible.
8010 * keyboard.h (ignore_mouse_drag_p): Declare only if
8011 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8012 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8013 * lisp.h (echoing): Remove decl.
8014 (force_auto_save_soon): Declare only if SIGDANGER.
8015 * xdisp.c (redisplay_window): Simplify code, to make it more
8016 obvious that ignore_mouse_drag_p is not accessed if !defined
8017 USE_GTK && !defined HAVE_NS.
8018
93ea6e8f
PE
8019 * intervals.c: Make symbols static if they're not exported.
8020 (merge_properties_sticky, merge_interval_right, delete_interval):
8021 Now static.
8022 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8023
77382fcc
PE
8024 * insdel.c: Make symbols static if they're not exported.
8025 However, leave prepare_to_modify_buffer alone. It's never
8026 called from outside this function, but that appears to be a bug.
8027 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8028 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8029 (adjust_after_replace_noundo): Remove; unused.
8030 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8031 (signal_before_change): Remove decls.
77382fcc 8032
9306c32e
PE
8033 * indent.c (val_compute_motion, val_vmotion): Now static.
8034
cd44d2eb
PE
8035 * image.c: Make symbols static if they're not exported.
8036 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8037 if USE_GTK.
8038 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8039 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8040
ad9a7a06
PE
8041 * fringe.c (standard_bitmaps): Now static.
8042 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8043
81626931
PE
8044 * frame.c: Make symbols static if they're not exported.
8045 (x_report_frame_params, make_terminal_frame): Now static.
8046 (get_frame_param): Now static, unless HAVE_NS.
8047 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8048 (x_get_resource_string): Remove; not used.
8049 * frame.h (make_terminal_frame, x_report_frame_params):
8050 (x_get_resource_string); Remove decls.
8051 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8052 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8053
239f9db9
PE
8054 * font.c, fontset.c: Make symbols static if they're not exported.
8055 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8056 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8057 * font.c (font_close_object): Now static.
8058 * font.h (font_close_object): Remove.
8059 * fontset.c (FONTSET_OBJLIST): Remove.
8060 (free_realized_fontset) #if-0 the body, which does nothing.
8061 (face_suitable_for_char_p): #if-0, as it's never called.
8062 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8063 * xfaces.c (face_at_string_position):
8064 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8065 since 0 is always ASCII.
8066
dfcf3579
PE
8067 * fns.c (weak_hash_tables): Now static.
8068
5045092b
PE
8069 * fileio.c: Make symbols static if they're not exported.
8070 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8071 (Vwrite_region_annotation_buffers): Now static.
8072
57a96f5c
PE
8073 * eval.c: Make symbols static if they're not exported.
8074 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8075 * lisp.h (backtrace_list): Remove decl.
8076
35f08c38
PE
8077 * emacs.c: Make symbols static if they're not exported.
8078 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8079 (fatal_error_code, fatal_error_signal_hook, standard_args):
8080 Now static.
8081 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8082 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8083 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8084 * lisp.h (fatal_error_signal_hook): Remove decl.
8085 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8086
f44bd759
PE
8087 * editfns.c: Move a (normally-unused) function to its only use.
8088 * editfns.c, lisp.h (get_operating_system_release): Remove.
8089 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8090 worth the hassle of breaking this out.
8091
b532497d
PE
8092 * xterm.c: Make symbols static if they're not exported.
8093 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8094 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8095 (x_destroy_window, x_delete_display):
8096 Now static.
8097 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8098 (x_mouse_leave): Remove; unused.
8099 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8100 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8101 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8102 Remove decls.
8103 (x_mouse_leave): Declare only if WINDOWSNT.
8104 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8105 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8106 USE_X_TOOLKIT.
8107
1675728f
PE
8108 * ftxfont.c: Make symbols static if they're not exported.
8109 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8110 HAVE_FREETYPE.
8111 * font.h (ftxfont_driver): Likewise.
8112
e4cebfca
PE
8113 * xfns.c: Make symbols static if they're not exported.
8114 (x_last_font_name, x_display_info_for_name):
8115 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8116 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8117 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8118 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8119 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8120 (last_show_tip_args): Now static.
8121 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8122 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8123 (x_screen_planes): Remove; unused.
8124 * dispextern.h (x_screen_planes): Remove decl.
8125
5bf46f05
PE
8126 * dispnew.c: Make symbols static if they're not exported.
8127 * dispextern.h (redraw_garbaged_frames, scrolling):
8128 (increment_row_positions): Remove.
8129 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8130 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8131 Now static.
8132 (redraw_garbaged_frames): Remove; unused.
8133
435f4c28
PE
8134 * xfaces.c: Make symbols static if they're not exported.
8135 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8136 Remove decls.
8137 * xterm.h (defined_color): Remove decls.
8138 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8139 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8140 (menu_face_changed_default, defined_color, free_realized_face):
8141 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8142 (ascii_face_of_lisp_face): Remove; unused.
8143
8524aef3
PE
8144 * xdisp.c: Make symbols static if they're not exported.
8145 * dispextern.h (scratch_glyph_row, window_box_edges):
8146 (glyph_to_pixel_coords, set_cursor_from_row):
8147 (get_next_display_element, set_iterator_to_next):
8148 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8149 (show_mouse_face): Remove decls
8150 * frame.h (message_buf_print): Likewise.
8151 * lisp.h (pop_message, set_message, check_point_in_composition):
8152 Likewise.
8153 * xterm.h (set_vertical_scroll_bar): Likewise.
8154 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8155 (message_buf_print, scratch_glyph_row, displayed_buffer):
8156 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8157 (get_next_display_element, show_mouse_face, window_box_edges):
8158 (frame_to_window_pixel_xy, check_point_in_composition):
8159 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8160 (glyph_to_pixel_coords): Remove; unused.
8161
16390cd2
PE
8162 * dired.c (file_name_completion): Now static.
8163
8164 * dbusbind.c (xd_in_read_queued_messages): Now static.
8165
a25f4dfa
PE
8166 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8167 * data.c (circular_list_error): Remove.
8168
14a9c8df
PE
8169 * commands.h (last_point_position, last_point_position_buffer):
8170 (last_point_position_window): Remove decls.
8171 * keyboard.c: Make these variables static.
8172
04f2d78b
CB
8173 * coding.h (coding, code_convert_region, encode_coding_gap):
8174 Remove decls.
74ab6df5
PE
8175 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8176 (iso_code_class, detect_coding, code_convert_region): Now static.
8177 (encode_coding_gap): Remove; unused.
8178
38dfbee1
PE
8179 * chartab.c (chartab_chars, chartab_bits): Now static.
8180
a2cb4e63
PE
8181 * charset.h (charset_iso_8859_1): Remove decl.
8182 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8183 Now static.
8184
127198fd
PE
8185 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8186 * ccl.c (Vccl_program_table): Now static.
8187 (check_ccl_update): Remove; unused.
8188
d85b608f
PE
8189 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8190 * category.h: ... from here.
8191 * category.c (check_category_table, set_category_set): Now static.
8192
31cd66f3
PE
8193 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8194 * lisp.h: Remove these decls.
8195
c358e587
PE
8196 * buffer.c (buffer_count): Remove unused var.
8197
e78aecca
PE
8198 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8199 so that it's not optimized away.
8200 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8201 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8202 exported only to the debugger.
8203
e192d7d3 8204 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8205 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8206
92470028
PE
8207 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8208 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8209 was inaccessible from Lisp.
8210 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8211 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8212
244ed907
PE
8213 alloc.c: Import and export fewer symbols, and remove unused items.
8214 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8215 is defined.
8216 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8217 it's not optimized away by whole-program optimization.
8218 (message_enable_multibyte, free_misc): Remove.
8219 (catchlist, handlerlist, mark_backtrace):
8220 Declare only if BYTE_MARK_STACK.
8221 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8222 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8223 (message_enable_multibyte): Remove decl.
8224 (free_misc, interval_free_list, float_block, float_block_index):
8225 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8226 (cons_free_list, last_marked_index):
8227 Now static.
8228 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8229 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8230 (mark_backtrace): Define only if BYTE_MARK_STACK.
8231 * xdisp.c (message_enable_multibyte): Now static.
8232
61c2b50e 8233 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8234 This makes it easier for human readers (and static analyzers)
8235 to see whether these variables are used from other modules.
8236 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8237 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8238 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8239 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8240 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8241 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8242 * xmenu.c, xselect.c:
8243 Declare Q* vars static if they are not used in other modules.
8244 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8245 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8246 Remove decls of unexported vars.
8247 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8248
95c82688
PE
8249 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8250
16a97296
PE
8251 Make Emacs functions such as Fatom 'static' by default.
8252 This makes it easier for human readers (and static analyzers)
8253 to see whether these functions can be called from other modules.
8254 DEFUN now defines a static function. To make the function external
8255 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8256 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8257 (Finit_image_library):
16a97296
PE
8258 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8259 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8260 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8261 Remove decls, since these functions are now static.
8262 (Funintern, Fget_internal_run_time): New decls, since these functions
8263 were already external.
95c82688 8264
16a97296
PE
8265 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8266 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8267 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8268 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8269 * keyboard.c, keymap.c, lread.c:
8270 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8271 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8272 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8273 Mark functions with DEFUE instead of DEFUN,
8274 if they are used in other modules.
8275 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8276 decls for now-static functions.
8277 * buffer.h (Fdelete_overlay): Remove decl.
8278 * callproc.c (Fgetenv_internal): Mark as internal.
8279 * composite.c (Fremove_list_of_text_properties): Remove decl.
8280 (Fcomposition_get_gstring): New forward static decl.
8281 * composite.h (Fcomposite_get_gstring): Remove decl.
8282 * dired.c (Ffile_attributes): New forward static decl.
8283 * doc.c (Fdocumntation_property): New forward static decl.
8284 * eval.c (Ffetch_bytecode): New forward static decl.
8285 (Funintern): Remove extern decl; now in .h file where it belongs.
8286 * fileio.c (Fmake_symbolic_link): New forward static decl.
8287 * image.c (Finit_image_library): New forward static decl.
8288 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8289 * intervals.h (Fprevious_property_change):
8290 (Fremove_list_of_text_properties): Remove decls.
8291 * keyboard.c (Fthis_command_keys): Remove decl.
8292 (Fcommand_execute): New forward static decl.
8293 * keymap.c (Flookup_key): New forward static decl.
8294 (Fcopy_keymap): Now static.
8295 * keymap.h (Flookup_key): Remove decl.
8296 * process.c (Fget_process): New forward static decl.
8297 (Fprocess_datagram_address): Mark as internal.
8298 * syntax.c (Fsyntax_table_p): New forward static decl.
8299 (skip_chars): Remove duplicate decl.
8300 * textprop.c (Fprevious_property_change): New forward static decl.
8301 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8302 Now internal.
8303 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8304 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8305
785bbd42
PE
8306 * editfns.c (Fformat): Remove unreachable code.
8307
8b913b57
AS
83082011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8309
8310 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8311 change. (Bug#8496)
8312
a6744a35
EZ
83132011-04-13 Eli Zaretskii <eliz@gnu.org>
8314
8315 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8316 when at ZV. (Bug#8487)
8317
e7974947
AS
83182011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8319
baad03f0
AS
8320 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8321 (Bug#8437)
8322 * keyboard.c (parse_tool_bar_item): Likewise.
8323 * sound.c (sound_cleanup, alsa_close): Likewise.
8324 * termcap.c (tgetent): Likewise.
8325 * xfns.c (x_default_font_parameter): Likewise.
8326 * xsettings.c (read_and_apply_settings): Likewise.
8327
e7974947
AS
8328 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8329 (overrun_check_free): Protoize.
8330
28272684
PE
83312011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8332
8333 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8334 since callers should never pass a negative size.
8335 Change the signature to match that of plain 'read' and 'write'; see
8336 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8337 * lisp.h: Update prototypes of emacs_write and emacs_read.
8338
11997c76
EZ
83392011-04-11 Eli Zaretskii <eliz@gnu.org>
8340
8341 * xdisp.c (redisplay_window): Don't try to determine the character
8342 position of the scroll margin if the window start point w->startp
e896f03c 8343 is outside the buffer's accessible region. (Bug#8468)
11997c76 8344
8a2cbd72
EZ
83452011-04-10 Eli Zaretskii <eliz@gnu.org>
8346
8347 Fix write-region and its subroutines for buffers > 2GB.
8348 * fileio.c (a_write, e_write): Modify declaration of arguments and
8349 local variables to support buffers larger than 2GB.
8350 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8351
8352 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8353 argument, local variables, and return value.
8354
8355 * lisp.h: Update prototypes of emacs_write and emacs_read.
8356
8357 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8358
4073e537 83592011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8360
1ebfdcb6
PE
8361 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8362
b2ded58d
PE
8363 Fix more problems found by GCC 4.6.0's static checks.
8364
7d66342c
PE
8365 * xdisp.c (vmessage): Use a better test for character truncation.
8366
bbf47d44
PE
8367 * charset.c (load_charset_map): <, not <=, for optimization,
8368 and to avoid potential problems with integer overflow.
9248994d 8369 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8370 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8371 * editfns.c (Fformat): Likewise.
1e69125e 8372 * syntax.c (skip_chars): Likewise.
3befa583 8373
e3019616
PE
8374 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8375 This also lets GCC 4.6.0 generate slightly better loop code.
8376
becfa255
PE
8377 * callint.c (Fcall_interactively): <, not <=, for optimization.
8378 (Fcall_interactively): Count the number of arguments produced,
8379 not the number of arguments given. This is simpler and lets GCC
8380 4.6.0 generate slightly better code.
8381
dae0cd48
PE
8382 * ftfont.c: Distingish more carefully between FcChar8 and char.
8383 The previous code passed unsigned char * to a functions like
8384 strlen and xstrcasecmp that expect char *, which does not
8385 conform to the C standard.
8386 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8387 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8388 char * when the C standard requires it.
8389
76032d70
PE
8390 * keyboard.c (read_char): Remove unused var.
8391
eb3f1cc8
PE
8392 * eval.c: Port to Windows vsnprintf (Bug#8435).
8393 Include <limits.h>.
8394 (SIZE_MAX): Define if the headers do not.
8395 (verror): Do not give up if vsnprintf returns a negative count.
8396 Instead, grow the buffer. This ports to Windows vsnprintf, which
8397 does not conform to C99. Problem reported by Eli Zaretskii.
8398 Also, simplify the allocation scheme, by avoiding the need for
8399 calling realloc, and removing the ALLOCATED variable.
8400
70476b54
PE
8401 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8402
12020a9e
PE
8403 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8404 But keep the doprint source code for now, as we might revamp it
8405 and use it again (Bug#8435).
ea6c7ae6
PE
8406 * lisp.h (doprnt): Remove.
8407 * Makefile.in (base_obj): Remove doprnt.o.
8408 * deps.mk (doprnt.o): Remove.
8409
5fdb398c
PE
8410 error: Print 32- and 64-bit integers portably (Bug#8435).
8411 Without this change, on typical 64-bit hosts error ("...%d...", N)
8412 was used to print both 32- and 64-bit integers N, which relied on
8413 undefined behavior.
61bdb816 8414 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8415 * lisp.h (error, verror): Mark as printf-like functions.
8416 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8417 Report overflow in size calculations when allocating printf buffer.
8418 Do not truncate output string at its first null byte.
8419 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8420 Truncate the output at a character boundary, since vsnprintf does not
8421 do that.
8422 * charset.c (check_iso_charset_parameter): Convert internal
8423 character to string before calling 'error', since %c now has the
8424 printf meaning.
8425 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8426 overflow when computing char to be passed to 'error'. Do not
8427 pass Lisp_Object to 'error'; pass the integer instead.
8428 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8429 formatted with plain %d.
8430
b189fa66
PE
8431 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8432
bff87ef0
PE
8433 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8434
7e2cac20
PE
8435 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8436
ce4d90b5
PE
8437 * xterm.c (x_catch_errors): Remove duplicate declaration.
8438
266c9547
PE
8439 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8440
79c49ad2
PE
8441 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8442
368f4090
JM
84432011-04-10 Jim Meyering <meyering@redhat.com>
8444
8445 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8446 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8447 return ssize_t not "int", and use size_t as the buffer length.
8448 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8449 * gnutls.h: Update declarations.
8450 * process.c (read_process_output): Use ssize_t, to match.
8451 (send_process): Likewise.
8452
a32d4040
CY
84532011-04-09 Chong Yidong <cyd@stupidchicken.com>
8454
8455 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8456
8546720e 84572011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8458
04f2d78b
CB
8459 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8460 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8461
8546720e
GM
8462 * xterm.c (handle_one_xevent):
8463 * xmenu.c (create_and_show_popup_menu):
8464 * xselect.c (x_decline_selection_request)
8465 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8466
0a2f5c1a 84672011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8468
8469 Fix some uses of `int' instead of EMACS_INT.
8470 * search.c (string_match_1, fast_string_match)
8471 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8472 (scan_buffer, find_next_newline_no_quit)
8473 (find_before_next_newline, search_command, Freplace_match)
8474 (Fmatch_data): Make some `int' variables be EMACS_INT.
8475
8476 * xdisp.c (display_count_lines): 3rd argument and return value now
8477 EMACS_INT. All callers changed.
8478 (pint2hrstr): Last argument is now EMACS_INT.
8479
8480 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8481 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8482 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8483 (decode_coding_utf_16, decode_coding_emacs_mule)
8484 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8485 (decode_coding_ccl, decode_coding_charset)
8486 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8487 (decode_coding_iso_2022, decode_coding_emacs_mule)
8488 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8489 <char_offset, last_offset>: Declare EMACS_INT.
8490 (encode_coding_utf_8, encode_coding_utf_16)
8491 (encode_coding_emacs_mule, encode_invocation_designation)
8492 (encode_designation_at_bol, encode_coding_iso_2022)
8493 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8494 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8495 Declare EMACS_INT.
8496 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8497 (encode_invocation_designation): Last argument P_NCHARS is now
8498 EMACS_INT.
8499 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8500 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8501
8502 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8503 All users changed.
8504
8505 * ccl.c (Fccl_execute_on_string): Declare some variables
8506 EMACS_INT.
8507
8546720e 85082011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8509
8510 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8511
4e19a977
CS
85122011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8513
8514 * process.c (Fformat_network_address): Doc fix.
8515
87302331
R
85162011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8517
ee7683eb 8518 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8519
cbb59342
CY
85202011-04-08 Chong Yidong <cyd@stupidchicken.com>
8521
8522 * keyboard.c (read_char): Call Lisp function help-form-show,
8523 instead of using internal_with_output_to_temp_buffer.
8524 (Qhelp_form_show): New var.
e0d38eeb 8525 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8526
8527 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8528
8529 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8530
e67a13ab
CY
85312011-04-06 Chong Yidong <cyd@stupidchicken.com>
8532
04f2d78b
CB
8533 * process.c (Flist_processes): Remove to Lisp.
8534 (list_processes_1): Delete.
e67a13ab 8535
973f782d
EZ
85362011-04-06 Eli Zaretskii <eliz@gnu.org>
8537
7c106b1e
EZ
8538 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8539
973f782d
EZ
8540 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8541
41cf7d1a 85422011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8543
ca23cc88
PE
8544 Fix more problems found by GCC 4.6.0's static checks.
8545
f390e2d5
PE
8546 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8547
42eea0d0
PE
8548 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8549
b69769da 8550 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8551
f9541e84
PE
8552 * xdisp.c (vmessage): Mark as a printf-like function.
8553
13841b55
PE
8554 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8555
c136c10f
PE
8556 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8557
5e2d4a30
PE
8558 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8559 printf-like functions.
8560 (tiff_load): Add casts to remove these marks before passing them
8561 to system-supplied API.
8562
583f48b9
PE
8563 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8564
b25d760e
PE
8565 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8566 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8567 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8568 directly, rather than having caller test rule sign. This avoids
8569 some unnecessary tests.
8570 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8571 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8572 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8573
bc7b6697 8574 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8575 (xfont_open): Avoid unnecessary tests.
bc7b6697 8576
27ccc379
PE
8577 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8578
dcd5c89a
PE
8579 * composite.h, composite.c (composition_gstring_put_cache):
8580 Use EMACS_INT, not int, for length.
8581
b13a45c6
PE
8582 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8583 breaking out part of COMPOSITION_DECODE_RULE.
8584 (COMPOSITION_DECODE_RULE): Use it.
8585 * composite.c (get_composition_id): Remove unused local vars,
8586 by using the new macro.
8587
1e792e4d
PE
8588 * textprop.c (set_text_properties_1): Change while to do-while,
8589 since the condition is always true at first.
8590
dc6c6455 8591 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8592 (interval_deletion_adjustment): Return unsigned value.
8593 All uses changed.
dc6c6455 8594
aba7731a
PE
8595 * process.c (list_processes_1, create_pty, read_process_output):
8596 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8597 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8598 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8599 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8600 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8601
fdfc4bf3
PE
8602 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8603
fca8fe46 8604 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8605 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8606
06a0259a 8607 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8608 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8609 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8610
e7b9e80f
PE
8611 * print.c (print_error_message): Avoid int overflow.
8612
56201685
PE
8613 * font.c (font_list_entities): Redo for clarity,
8614 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8615
78834453 8616 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8617 (font_score): Avoid potential overflow in diff calculation.
78834453 8618
0bc0b309 8619 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8620 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8621
e610eaca
PE
8622 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8623
b895abce
PE
8624 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8625 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8626 can always succeed if overflow has undefined behavior.
8627
1f1d9321 8628 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8629 (wordify): Omit three unnecessary tests.
1f1d9321 8630
c59478bc
PE
8631 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8632 All callers changed. This avoids the need for an unused var.
8633
79b73827
PE
8634 * casefiddle.c (casify_region): Remove var that is set but not used.
8635
a4db5dfe
PE
8636 * dired.c (file_name_completion): Remove var that is set but not used.
8637
43aae36e
PE
8638 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8639
2a47c44d 8640 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8641 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8642
a37c69bf
PE
8643 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8644 Check for integer overflow on size calculations.
8645
328ab8e7
PE
8646 * buffer.c (Fprevious_overlay_change): Remove var that is set
8647 but not used.
8648
e5a2a5cb
PE
8649 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8650 Remove vars that are set but not used.
8d84a6eb 8651 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8652 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8653
a60e5f68
PE
8654 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8655
f661cb61 8656 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8657 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8658
f0397f5a
PE
8659 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8660 that are set but not used.
8661
8664db06 8662 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8663 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8664
6abdaa4a
PE
8665 * xselect.c (x_get_local_selection, x_handle_property_notify):
8666 Remove vars that are set but not used.
8667
0ce7538d 8668 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8669 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8670
9ae848fc
PE
8671 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8672 Remove var that is set but not used.
0b918413
PE
8673 (scroll_bar_windows_size): Now size_t, not int.
8674 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8675 Check for overflow.
9ae848fc 8676
a5a62657
PE
8677 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8678 (map_tty_color) [!defined MSDOS]: Likewise.
8679
5c5cdd39
PE
8680 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8681
66ebf983
PE
8682 * coding.c: Remove vars that are set but not used.
8683 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8684 All callers changed.
8685 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8686 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8687 (decode_coding_charset): Remove vars that are set but not used.
8688
1be4d761
PE
8689 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8690 that is set but not used.
8691
47553fa8
PE
8692 * print.c (print_object): Remove var that is set but not used.
8693
1f7196bf 8694 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8695 The gnulib version avoids calling malloc in the usual case,
8696 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8697 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8698 * filelock.c (current_lock_owner): Likewise.
8699 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8700 * sysdep.c: Include allocator.h, careadlinkat.h.
8701 (emacs_no_realloc_allocator): New static constant.
8702 (emacs_readlink): New function.
fdb61804
PE
8703 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8704 ../lib/careadlinkat.h.
d1fdcab7 8705
f84c17c7
SM
87062011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8707
8708 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8709 first non-nil return value).
8710
ef3862ad
JD
87112011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8712
8713 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8714 if not defined (Bug#8403).
8715
376a7006
JB
87162011-04-02 Juanma Barranquero <lekktu@gmail.com>
8717
8718 * xdisp.c (display_count_lines): Remove parameter `start',
8719 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8720 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8721 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8722 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8723 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8724 and thereabouts. All callers changed.
8725 (get_per_char_metric): Remove parameter `f', unused since
8726 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8727
6ca3801d
JM
87282011-04-02 Jim Meyering <meyering@redhat.com>
8729
8730 do not dereference NULL upon failed strdup
8731 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8732 (ns_get_family): Likewise.
8733
d8e2b5ba
JB
87342011-04-02 Juanma Barranquero <lekktu@gmail.com>
8735
8736 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8737
8c74fcbd
JD
87382011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8739
8740 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8741 later (Bug#8403).
8742
7200d79c
SM
87432011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8744
03408648 8745 Add lexical binding.
7200d79c 8746
03408648
SM
8747 * window.c (Ftemp_output_buffer_show): New fun.
8748 (Fsave_window_excursion):
8749 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8750
8751 * lread.c (lisp_file_lexically_bound_p): New function.
8752 (Fload): Bind Qlexical_binding.
8753 (readevalloop): Remove `evalfun' arg.
8754 Bind Qinternal_interpreter_environment.
8755 (Feval_buffer): Bind Qlexical_binding.
8756 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8757 Mark as dynamic.
8758 (syms_of_lread): Declare `lexical-binding'.
8759
8760 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8761
8762 * keyboard.c (eval_dyn): New fun.
8763 (menu_item_eval_property): Use it.
ca105506
SM
8764
8765 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8766
03408648
SM
8767 * fns.c (concat, mapcar1): Accept byte-code-functions.
8768
8769 * eval.c (Fsetq): Handle lexical vars.
8770 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8771 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8772 (FletX, Flet): Obey lexical binding.
8773 (Fcommandp): Handle closures.
8774 (Feval): New `lexical' arg.
8775 (eval_sub): New function extracted from Feval. Use it almost
8776 everywhere where Feval was used. Look up vars in lexical env.
8777 Handle closures.
8778 (Ffunctionp): Move from subr.el.
8779 (Ffuncall): Handle closures.
8780 (apply_lambda): Remove `eval_flags'.
8781 (funcall_lambda): Handle closures and new byte-code-functions.
8782 (Fspecial_variable_p): New function.
8783 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8784 but without exporting it to Lisp.
23aba0ea 8785
23aba0ea 8786 * doc.c (Fdocumentation, store_function_docstring):
03408648 8787 * data.c (Finteractive_form): Handle closures.
23aba0ea 8788
03408648
SM
8789 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8790 interactive spec.
ba83908c 8791
04f2d78b
CB
8792 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8793 New byte-codes.
03408648
SM
8794 (exec_byte_code): New function extracted from Fbyte_code to handle new
8795 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8796
03408648 8797 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8798
03408648 8799 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8800
e2abce01
JB
88012011-03-31 Juanma Barranquero <lekktu@gmail.com>
8802
8803 * xdisp.c (redisplay_internal): Fix prototype.
8804
63696a73 88052011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8806
63696a73 8807 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8808 (try_scrolling): Use it when setting scroll_limit.
8809 Limit scrolling to 100 screen lines.
63696a73
EZ
8810 (redisplay_window): Even when falling back on "recentering",
8811 position point in the window according to scroll-conservatively,
8812 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8813
8814 (try_scrolling): When point is above the window, allow searching
8815 as far as scroll_max, or one screenful, to compute vertical
8816 distance from PT to the scroll margin position. This prevents
8817 try_scrolling from unnecessarily failing when
8818 scroll-conservatively is set to a value slightly larger than the
8819 window height. Clean up the case of PT below the margin at bottom
8820 of window: scroll_max can no longer be INT_MAX. When aggressive
8821 scrolling is in use, don't let point enter the opposite scroll
8822 margin as result of the scroll.
8823 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8824 threshold of 100 lines for never-recentering scrolling.
8825
e4cc2dfc
JB
88262011-03-31 Juanma Barranquero <lekktu@gmail.com>
8827
8828 * dispextern.h (move_it_by_lines):
8829 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8830 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8831 (message_log_check_duplicate): Remove parameters `prev_bol' and
8832 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8833 (redisplay_internal): Remove parameter `preserve_echo_area',
8834 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8835
8836 * indent.c (Fvertical_motion):
8837 * window.c (window_scroll_pixel_based, Frecenter):
8838 Don't pass `need_y_p' to `move_it_by_lines'.
8839
1c470562
SM
88402011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8841
44f230aa
SM
8842 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8843 steal a few bits to be more compact.
8844 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8845 Remove unneeded casts.
8846
1c470562
SM
8847 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8848
888adce9
ZK
88492011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8850
8851 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8852 binding" message (bug#7967).
8853
f838ed7b
PE
88542011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8855
77861b95
PE
8856 Fix more problems found by GCC 4.6.0's static checks.
8857
de6dbc14
PE
8858 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8859 Remove unused local var.
8860
f838ed7b
PE
8861 * editfns.c (Fmessage_box): Remove unused local var.
8862
792c7b2b
PE
8863 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8864 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8865 Omit unused local vars.
c499e557 8866 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8867 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8868 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8869 Omit unused local var.
8870
ba0165e1
PE
8871 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8872 Don't assume string length fits in int.
32ad8845 8873 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8874 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8875
3c59b4c9
PE
8876 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8877 instead of alloca (Bug#8344).
8878
a3eed478 8879 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8880 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8881
eb4d412d
PE
8882 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8883
1658b401
PE
8884 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8885 concerns.
8886
8887 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8888
8889 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8890
9a2c6e05
PE
8891 * keyboard.c (syms_of_keyboard): Use the same style as later
8892 in this function when indexing through an array. This also
8893 works around GCC bug 48267.
8894
03d0a109
PE
8895 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8896
44f730c8
PE
8897 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8898
fe75f926
PE
8899 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8900 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8901
ffa8c828
PE
8902 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8903 This avoids undefined behavior on integer overflow, and is a bit
8904 more convenient anyway since it is compared to a size_t variable.
8905
c5101a77
PE
8906 Variadic C functions now count arguments with size_t, not int.
8907 This avoids an unnecessary limitation on 64-bit machines, which
8908 caused (substring ...) to crash on large vectors (Bug#8344).
8909 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8910 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8911 All variadic functions and their callers changed accordingly.
c5101a77
PE
8912 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8913 * data.c (arith_driver, float_arith_driver): Likewise.
8914 * editfns.c (general_insert_function): Likewise.
8915 * eval.c (struct backtrace.nargs, interactive_p)
8916 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8917 (funcall_lambda, mark_backtrace): Likewise.
8918 * fns.c (concat): Likewise.
8919 * frame.c (x_set_frame_parameters): Likewise.
8920 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8921 0 if not found, not -1. All callers changed.
8922
dd3f25f7
PE
8923 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8924 (stack_copy_size): Now size_t, not int.
8925 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8926
461c2ab9
JB
89272011-03-28 Juanma Barranquero <lekktu@gmail.com>
8928
8929 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8930 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8931 All callers changed.
8932
8933 * lisp.h (multibyte_char_to_unibyte):
8934 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8935 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8936 * character.h (CHAR_TO_BYTE8):
8937 * cmds.c (internal_self_insert):
8938 * editfns.c (general_insert_function):
8939 * keymap.c (push_key_description):
8940 * search.c (Freplace_match):
8941 * xdisp.c (message_dolog, set_message_1): All callers changed.
8942
f6d62986
SM
89432011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8944
8945 * keyboard.c (safe_run_hook_funcall): New function.
8946 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8947 don't set the hook to nil, but remove the offending function instead.
8948 (Qcommand_hook_internal): Remove, unused.
8949 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8950 Vcommand_hook_internal.
8951
8952 * eval.c (enum run_hooks_condition): Remove.
8953 (funcall_nil, funcall_not): New functions.
8954 (run_hook_with_args): Call each function through a `funcall' argument.
8955 Remove `cond' argument, now redundant.
8956 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8957 (Frun_hook_with_args_until_failure): Adjust accordingly.
8958 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8959
1db5b1ad
JB
89602011-03-28 Juanma Barranquero <lekktu@gmail.com>
8961
8962 * dispextern.h (string_buffer_position): Remove declaration.
8963
8964 * print.c (strout): Remove parameter `multibyte', unused since
8965 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8966
8967 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8968 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8969 All callers changed.
8970
8971 * w32.c (_wsa_errlist): Use braces for struct initializers.
8972
8973 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8974 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8975 All callers changed.
8976 (string_buffer_position): Likewise. Also, make static (it's never
8977 used outside xdisp.c).
8978 (cursor_row_p): Remove parameter `w', unused since
8979 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8980 (decode_mode_spec): Remove parameter `precision', introduced during
8981 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8982 All callers changed.
8983
5ffb62aa
JD
89842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8985
8986 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8987
461c2ab9 89882011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8989
8990 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8991 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8992 (ns_update_auto_hide_menu_bar): New functions.
8993 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8994 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8995 ns_constrain_all_frames.
8996 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8997 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8998
5c380ffb
JD
89992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9000
9001 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9002
9af30bdf
GM
90032011-03-27 Glenn Morris <rgm@gnu.org>
9004
9005 * syssignal.h: Replace RETSIGTYPE with void.
9006 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9007 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9008 Replace SIGTYPE with void everywhere.
9009 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9010 * s/template.h (SIGTYPE): Remove commented out definition.
9011
e2abce01
JB
90122011-03-26 Eli Zaretskii <eliz@gnu.org>
9013
9014 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9015 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9016
f868cd8a
JB
90172011-03-26 Juanma Barranquero <lekktu@gmail.com>
9018
59eb0929
JB
9019 * w32.c (read_unc_volume): Use parameter `henum', instead of
9020 global variable `wget_enum_handle'.
9021
9022 * keymap.c (describe_vector): Remove parameters `indices' and
9023 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9024 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9025
f868cd8a
JB
9026 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9027
9028 * keyboard.c (timer_check): Remove parameter `do_it_now',
9029 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9030 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9031 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9032
9033 * keyboard.c (read_char):
9034 * w32menu.c (w32_menu_display_help):
9035 * xmenu.c (show_help_event, menu_help_callback):
9036 Adjust calls to `show_help_echo'.
9037
9038 * gtkutil.c (xg_maybe_add_timer):
9039 * keyboard.c (readable_events):
9040 * process.c (wait_reading_process_output):
9041 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9042
9043 * insdel.c (adjust_markers_gap_motion):
9044 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9045 (gap_left, gap_right): Don't call it.
9046
2ecf6fdb
CY
90472011-03-25 Chong Yidong <cyd@stupidchicken.com>
9048
9049 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9050 incurred during fontification.
9051
6b1f9ba4
JB
90522011-03-25 Juanma Barranquero <lekktu@gmail.com>
9053
9054 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9055 (DEFVAR_PER_BUFFER): Don't pass it.
9056
9057 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9058 (scrolling_window): Don't pass it.
9059
0f4a96b5
JB
90602011-03-25 Juanma Barranquero <lekktu@gmail.com>
9061
9062 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9063
9064 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9065 and `suffix'.
9066 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9067 of variables specific to SELinux and computation of `encoded_absname'.
9068
9069 * image.c (XPutPixel): Remove unused variable `height'.
9070
9071 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9072
9073 * unexw32.c (get_section_info): Remove unused variable `section'.
9074
9075 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9076 (system_process_attributes): Remove unused variable `sess'.
9077 (sys_read): Remove unused variable `err'.
9078
9079 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9080 (w32_wnd_proc): Remove unused variable `isdead'.
9081 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9082 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9083 (x_create_tip_frame): Remove unused variable `tem'.
9084
9085 * w32inevt.c (w32_console_read_socket):
9086 Remove unused variable `no_events'.
9087
9088 * w32term.c (x_draw_composite_glyph_string_foreground):
9089 Remove unused variable `width'.
9090
1149507c
JB
90912011-03-24 Juanma Barranquero <lekktu@gmail.com>
9092
9093 * w32term.c (x_set_glyph_string_clipping):
9094 Don't pass uninitialized region to CombineRgn.
9095
9c88f339
JB
90962011-03-23 Juanma Barranquero <lekktu@gmail.com>
9097
9098 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9099 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9100 (Fx_close_connection): Remove unused variable `i'.
9101
9102 * w32font.c (w32font_draw): Return number of glyphs.
9103 (w32font_open_internal): Remove unused variable `i'.
9104 (w32font_driver): Add missing initializer.
9105
9106 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9107 (fill_in_menu): Remove unused variable `items_added'.
9108
9109 * w32term.c (last_mouse_press_frame): Remove static global variable.
9110 (w32_clip_to_row): Remove unused variable `f'.
9111 (x_delete_terminal): Remove unused variable `i'.
9112
9113 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9114 (NOTHING): Remove unused static global variable.
9115 (uniscribe_check_otf): Remove unused variable `table'.
9116 (uniscribe_font_driver): Add missing initializers.
9117
dee091a3
JD
91182011-03-23 Julien Danjou <julien@danjou.info>
9119
9120 * term.c (Fsuspend_tty, Fresume_tty):
9121 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9122 * window.c (temp_output_buffer_show):
9123 * insdel.c (signal_before_change):
9124 * frame.c (Fhandle_switch_frame):
9125 * fileio.c (Fdo_auto_save):
9126 * emacs.c (Fkill_emacs):
9127 * editfns.c (save_excursion_restore):
9128 * cmds.c (internal_self_insert):
9129 * callint.c (Fcall_interactively):
9130 * buffer.c (Fkill_all_local_variables):
9131 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9132 Use Frun_hooks.
0f4a96b5 9133 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9134 unconditionally since it does the check itself.
dee091a3 9135
2c520ab5 91362011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9137
c9c49752
PE
9138 Fix more problems found by GCC 4.5.2's static checks.
9139
8abc3f12
PE
9140 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9141 the first time through the loop, since we know p0 < p1 then.
9142 This also avoids a gcc -Wstrict-overflow warning.
9143
a2d26660
PE
9144 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9145 leading to a memory leak, possible in functions like
9146 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9147 of objects (Bug#8318).
a2d26660 9148
916c72e9
PE
9149 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9150 that could (at least in theory) be that large.
9151
19ab8a18
PE
9152 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9153 This is less likely to overflow, and avoids undefined behavior if
9154 overflow does occur. All callers changed. Use strtoul to scan
9155 for the unsigned long integer.
b7cbbd6f
PE
9156 (pint2hrstr): Simplify and tune code slightly.
9157 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9158
f0641eff
PE
9159 * scroll.c (do_scrolling): Work around GCC bug 48228.
9160 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9161
7f650bb9
PE
9162 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9163 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9164 (validate_x_resource_name): Simplify count usage.
9165 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9166
37dd57d1
PE
9167 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9168 fail (Bug#8306).
81e56e61 9169
699979fc 9170 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9171
401bf9b4
PE
9172 * process.c (Fmake_network_process): Use socklen_t, not int,
9173 where POSIX says socklen_t is required in portable programs.
9174 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9175 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9176 (Fmake_network_process, server_accept_connection):
9177 (wait_reading_process_output, read_process_output):
9178 Likewise.
9179
b93aacde
PE
9180 * process.c: Rename or move locals to avoid shadowing.
9181 (list_processes_1, Fmake_network_process):
9182 (read_process_output_error_handler, exec_sentinel_error_handler):
9183 Rename or move locals.
4dc343ee 9184 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9185 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9186 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9187 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9188 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9189
af8a867c 9190 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9191 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9192 Include tparam.h instead, since it declares them.
af8a867c
PE
9193 * cm.h (PC): Remove extern decl; tparam.h now does this.
9194 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9195 * terminfo.c: Include tparam.h, to check interfaces.
9196 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9197 (tparam): Adjust signature to match interface in tparam.h;
9198 this removes some undefined behavior. Check that outstring and len
9199 are zero, which they always are with Emacs.
9200 * tparam.h (PC, BC, UP): New extern decls.
9201
0248044d 9202 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9203 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9204
8ff096c1 9205 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9206 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9207 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9208 (ftfont_list): Remove unused local.
49eaafba
PE
9209 (get_adstyle_property, ftfont_pattern_entity):
9210 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9211 Rename locals to avoid shadowing.
8ff096c1 9212
e2be39f6
PE
9213 * xfont.c (xfont_list_family): Mark var as initialized.
9214
c9735e30
PE
9215 * xml.c (make_dom): Now static.
9216
8f5201ae
PE
9217 * composite.c (composition_compute_stop_pos): Rename local to
9218 avoid shadowing.
b246f932
PE
9219 (composition_reseat_it): Remove unused locals.
9220 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9221 (composition_update_it): Mark var as initialized.
11b61122
PE
9222 (find_automatic_composition): Mark vars as initialized,
9223 with a FIXME (Bug#8290).
8f5201ae 9224
760fbc2c
PE
9225 character.h: Rename locals to avoid shadowing.
9226 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9227 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9228 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9229 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9230 to avoid shadowing.
9231
ff08eb85
PE
9232 * textprop.c (property_change_between_p): Remove; unused.
9233
fc7bf025
PE
9234 * intervals.c (interval_start_pos): Now static.
9235
235d7abc
PE
9236 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9237
44f230aa
SM
9238 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9239 Rename locals to avoid shadowing.
3e7d6594 9240
50060332
PE
9241 * sound.c (wav_play, au_play, Fplay_sound_internal):
9242 Fix pointer signedness.
d01f234b 9243 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9244 (wav_play): Initialize a variable to 0, to prevent undefined
9245 behavior (Bug#8278).
50060332 9246
c4fc4e30
PE
9247 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9248
918436ed
PE
9249 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9250
c939f91b
PE
9251 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9252 clobbering (Bug#8298).
b9c7f648
PE
9253 * sysdep.c (sys_subshell): Likewise.
9254 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9255
6bd8c144
PE
9256 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9257 This should get cleaned up, so that child_setup has the
9258 same signature on all platforms.
9259
7710357c 9260 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9261 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9262
c59da222
CY
92632011-03-22 Chong Yidong <cyd@stupidchicken.com>
9264
9265 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9266 not to be necessary, and produces flickering.
9267
66b87493
GM
92682011-03-20 Glenn Morris <rgm@gnu.org>
9269
9270 * config.in: Remove file.
9271
45b6f6d5
JB
92722011-03-20 Juanma Barranquero <lekktu@gmail.com>
9273
9274 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9275 are now in src/globals.h.
9276 (syms_of_minibuf): Remove spurious & from previous change.
9277
cd394be1 92782011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9279
9280 * minibuf.c (completing-read-function): New variable.
9281 (completing-read-default): Rename from completing-read.
9282 (completing-read): Call completing-read-function.
9283
b14e3e21
CY
92842011-03-19 Juanma Barranquero <lekktu@gmail.com>
9285
9286 * xfaces.c (Fx_load_color_file):
9287 Read color file from absolute filename (bug#8250).
9288
f2b726e6
JB
92892011-03-19 Juanma Barranquero <lekktu@gmail.com>
9290
9291 * makefile.w32-in: Update dependencies.
9292
09f6ff02
EZ
92932011-03-17 Eli Zaretskii <eliz@gnu.org>
9294
9295 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9296
29a6015a
PE
92972011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9298
a3a6c54e
PE
9299 Fix more problems found by GCC 4.5.2's static checks.
9300
b766f867
PE
9301 * process.c (make_serial_process_unwind, send_process_trap):
9302 (sigchld_handler): Now static.
9303
be02381c
PE
9304 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9305 That way, the code declares only the vars that it needs.
9306 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9307 * s/cygwin.h (PTY_ITERATION): Likewise.
9308 * s/darwin.h (PTY_ITERATION): Likewise.
9309 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9310
57048744
PE
9311 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9312 * process.c (allocate_pty): Don't declare stb unless it's needed.
9313
7914961c 9314 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9315 (CONSTANTLIM): Remove; unused.
9316 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9317 Define only if needed.
7914961c 9318
b3967b18
PE
9319 * unexelf.c (unexec): Name an expression,
9320 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9321 Use a different way to cause a compilation error if anyone uses
9322 n rather than nn, a way that does not involve shadowing.
73366a00 9323 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9324
29a6015a
PE
9325 * deps.mk (unexalpha.o): Remove; unused.
9326
43cfc33e 9327 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9328 * unexec.h: New file.
ce701a33
PE
9329 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9330 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9331 Depend on unexec.h.
9332 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9333 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9334 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9335 Change as necessary to match prototype in unexec.h.
ce701a33 9336
01f44d5a
PE
9337 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9338 shadowing.
4f63c6bb 9339 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9340
a6670b0b
PE
9341 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9342 Rename locals to avoid shadowing.
9343
cef2010d 9344 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9345 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9346
d4d7173a
PE
9347 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9348
f08b802a
PE
9349 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9350 warning when compiling print.c.
9351
3ddb0639
PE
9352 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9353 instead of using an uninitialized var.
5ad03b97 9354 (font_sort_entities): Mark var as initialized.
3ddb0639 9355
170a2692
PE
9356 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9357
e663c700
PE
9358 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9359 pointers to constants.
89bc529a 9360 (font_parse_fcname): Remove unused vars.
7b81e2d0 9361 (font_delete_unmatched): Now static.
ea838e10 9362 (font_get_spec): Remove; unused.
13a547c6
PE
9363 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9364 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9365 Rename or move locals to avoid shadowing.
e663c700 9366
2a80c887 9367 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9368 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9369
1384fa33 9370 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9371 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9372
8b2c52e9
PE
9373 * alloc.c (mark_backtrace): Move decl from here ...
9374 * lisp.h: ... to here, so that it can be checked.
9375
475545b5 9376 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9377 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9378 (lisp_indirect_variable): Name an expression,
9379 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9380 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9381
b1349114 9382 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9383 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9384 Use const pointer when appropriate.
b1349114 9385
a2928364
PE
9386 * lisp.h (get_system_name, get_operating_system_release):
9387 Move decls here, to check interfaces.
9388 * process.c (get_operating_system_release): Move decl to lisp.h.
9389 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9390 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9391 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9392 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9393 (Fformat_time_string, Fencode_time, Finsert_char):
9394 (Ftranslate_region_internal, Fformat):
9395 Rename or remove local vars to avoid shadowing.
9710023e 9396 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9397
a415e694
PE
9398 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9399 avoid shadowing.
9400
8ef4622d
PE
9401 * lisp.h (eassert): Check that the argument compiles, even if
9402 ENABLE_CHECKING is not defined.
9403
946f9a5b
PE
9404 * data.c (Findirect_variable): Name an expression, to avoid
9405 gcc -Wbad-function-cast warning.
112396d6 9406 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9407 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9408 (Fmake_variable_buffer_local, Fmake_local_variable):
9409 Mark variables as initialized.
52746918 9410 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9411
e5aab7e7 9412 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9413 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9414 Rename locals to avoid shadowing.
dff45157
PE
9415 (mark_stack): Move local variables into the #ifdef region where
9416 they're used.
7bc26fdb
PE
9417 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9418 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9419 needed otherwise.
9420 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9421 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9422 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9423
e5aab7e7
PE
9424 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9425 avoids undefined behavior in theory.
9426
4da60324
PE
9427 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9428
88043301
PE
9429 Use functions, not macros, for up- and down-casing (Bug#8254).
9430 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9431 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9432 to use the following functions instead of these macros.
9433 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9434 EMACS_INT, since callers assume the returned value fits in int.
9435 (upcase1): Likewise, for UPCASE_TABLE.
9436 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9437 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9438 the race-condition problem in the old DOWNCASE.
88043301 9439
19ed5445
PE
9440 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9441 Rename locals to avoid shadowing.
9442 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9443 (regex_compile, re_search_2, re_match_2_internal):
9444 Remove unused local vars.
952db0d7
PE
9445 (FREE_VAR): Rewrite so as not to use empty "else",
9446 which gcc can warn about.
da053e48 9447 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9448 (RETALLOC_IF): Define only if needed.
9449 (WORDCHAR_P): Likewise. This one is never needed, but is used
9450 only in a comment talking about a compiler bug, so put inside
9451 the #if 0 of that comment.
9452 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9453 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9454 Remove; unused.
19ed5445 9455
1f3561e4 9456 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9457 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9458 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9459
ded6f8f7
PE
9460 * search.c (simple_search): Remove unused var.
9461
dbd37a95
PE
9462 * dired.c (compile_pattern): Move decl from here ...
9463 * lisp.h: ... to here, so that it can be checked.
9464 (struct re_registers): New forward decl.
9465
7e47afad
PE
9466 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9467
85f24f61
PE
9468 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9469 All uses changed.
9470 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9471 Rename locals to avoid shadowing.
5671df8f 9472 (Fvertical_motion): Mark locals as initialized.
85f24f61 9473
181aa2be 9474 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9475 (casify_region): Mark local as initialized.
181aa2be 9476
930d429c
PE
9477 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9478
7082eac6
PE
9479 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9480 New macros, so that the caller can use some names other than
9481 gcpro1, gcpro2, etc.
9482 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9483 of the new macros.
9484 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9485 argument, for consistency with GCPRO2_VAR, etc: it is now the
9486 prefix of the variable, not the variable itself. All uses
9487 changed.
38b2c076
PE
9488 * dired.c (directory_files_internal, file_name_completion):
9489 Rename locals to avoid shadowing.
9490
15206ed9
PE
9491 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9492 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9493 dired.c's scmp function, had undefined behavior.
9494 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9495 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9496 * buffer.h: ... to here, because these macros use current_buffer,
9497 and the new implementation with inline functions needs to have
9498 current_buffer in scope now, rather than later when the macros
9499 are used.
9500 (downcase, upcase1): New static inline functions.
9501 (DOWNCASE, UPCASE1): Reimplement using these functions.
9502 This avoids undefined behavior in expressions like
9503 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9504 from race conditions in accessing the global variables
9505 case_temp1 and case_temp2.
9506 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9507 * lisp.h (case_temp1, case_temp2): Remove their decls.
9508 * character.h (ASCII_CHAR_P): Move from here ...
9509 * lisp.h: ... to here, so that the inline functions mentioned
9510 above can use them.
9511
4a6bea26
PE
9512 * dired.c (directory_files_internal_unwind): Now static.
9513
f14b7e14
PE
9514 * fileio.c (file_name_as_directory, directory_file_name):
9515 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9516 Now static.
2893f146
PE
9517 (file_name_as_directory): Use const pointers when appropriate.
9518 (Fexpand_file_name): Likewise. In particular, newdir might
9519 point at constant storage, so make it a const pointer.
fd4ead52 9520 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9521 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9522 signedness issues.
f839df0c
PE
9523 (Fset_file_times, Finsert_file_contents, auto_save_error):
9524 Rename locals to avoid shadowing.
f14b7e14 9525
5716756e 9526 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9527 (Ftry_completion, Fall_completions): Rename or remove locals
9528 to avoid shadowing.
5716756e 9529
b4c3046a
PE
9530 * marker.c (bytepos_to_charpos): Remove; unused.
9531
b45db522
PE
9532 * lisp.h (verify_bytepos, count_markers): New decls,
9533 so that gcc does not warn that these functions aren't declared.
9534
85876d07
PE
9535 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9536 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9537 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9538 (copy_text): Remove unused local var.
85876d07 9539
03d78a21 9540 * filelock.c (within_one_second): Now static.
b3dd38ab 9541 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9542
5df8f01b
PE
9543 * buffer.c (fix_overlays_before): Mark locals as initialized.
9544 (fix_start_end_in_overlays): Likewise. This function should be
9545 simplified by using pointers-to-pointers, but that's a different
9546 matter.
b1d876f1 9547 (switch_to_buffer_1): Now static.
8f54f30a
PE
9548 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9549 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9550
a70072c9 9551 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9552 Fix pointer signedness issue.
edced198
PE
9553 (sys_subshell): Mark local as volatile if checking for lint,
9554 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9555 (MAXPATHLEN): Define only if needed.
a70072c9 9556
a0977c44
PE
9557 * process.c (serial_open, serial_configure): Move decls from here ...
9558 * systty.h: ... to here, so that they can be checked.
9559
a884fdcc
PE
9560 * fns.c (get_random, seed_random): Move extern decls from here ...
9561 * lisp.h: ... to here, so that they can be checked.
9562
604efe86 9563 * sysdep.c (reset_io): Now static.
b8950c94 9564 (wait_for_termination_signal): Remove; unused.
604efe86 9565
38fc62d9
PE
9566 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9567 (copy_keymap_item, append_key, push_text_char_description):
9568 Now static.
1004a21a 9569 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9570 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9571 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9572 (describe_map_tree):
9573 Rename locals to avoid shadowing.
38fc62d9 9574
2f2650da
PE
9575 * keyboard.c: Declare functions static if they are not used elsewhere.
9576 (echo_char, echo_dash, cmd_error, top_level_2):
9577 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9578 (read_char, kbd_buffer_get_event, make_lispy_position):
9579 (make_lispy_event, make_lispy_movement, apply_modifiers):
9580 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9581 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9582 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9583 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9584 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9585
a053e86c 9586 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9587 (mark_kboards): Move decl here ...
9588 * alloc.c (mark_kboards): ... from here.
a053e86c 9589
4752793e
PE
9590 * lisp.h (force_auto_save_soon): New decl.
9591
74f10ca7 9592 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9593 (DEFINE_DUMMY_FUNCTION): New macro.
9594 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9595 Use it.
c03cd23f
PE
9596 (main): Add casts to avoid warnings
9597 if GCC considers string literals to be constants.
74f10ca7 9598
022e70d4
PE
9599 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9600
59d6fe83
PE
9601 * dbusbind.c: Pointer signedness fixes.
9602 (xd_signature, xd_append_arg, xd_initialize):
9603 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9604 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9605 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9606 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9607
78320123
PE
9608 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9609 if GCC considers string literals to be constants.
49cebcca 9610 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9611
35ac2a97
SM
96122011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9613
fb103ca9
SM
9614 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9615 (print_preprocess, print_object): New macro to fix last change.
9616
35ac2a97
SM
9617 * print.c (print_preprocess): Don't forget font objects.
9618
62973b41
JB
96192011-03-16 Juanma Barranquero <lekktu@gmail.com>
9620
9621 * emacs.c (USAGE3): Doc fixes.
9622
0e48bb22
AS
96232011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9624
9625 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9626 structure.
9627
7684e57b
JB
96282011-03-14 Juanma Barranquero <lekktu@gmail.com>
9629
9630 * lisp.h (VWindow_system, Qfile_name_history):
9631 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9632 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9633 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9634
9635 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9636 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9637
9638 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9639 * w32console.c (detect_input_pending, read_input_pending)
9640 (encode_terminal_code):
9641 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9642 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9643 (w32_system_caret_y, Qfile_name_history):
9644 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9645 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9646 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9647 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9648 * w32proc.c (Qlocal, report_file_error):
9649 * w32term.c (Vwindow_system, updating_frame):
9650 * w32uniscribe.c (initialized, uniscribe_font_driver):
9651 Remove unneeded extern declarations.
9652
2aa46d6c
CY
96532011-03-14 Chong Yidong <cyd@stupidchicken.com>
9654
c96bbc66 9655 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9656
cffc6f3b
CY
96572011-03-13 Chong Yidong <cyd@stupidchicken.com>
9658
9659 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9660 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9661 These macros can no longer be used for assignment.
9662
44f230aa
SM
9663 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9664 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9665 (record_buffer_markers, fetch_buffer_markers): New functions for
9666 recording and fetching special buffer markers.
9667 (set_buffer_internal_1, set_buffer_temp): Use them.
9668
9669 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9670
9671 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9672
9673 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9674 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9675
9676 * xdisp.c (hscroll_window_tree):
9677 (reconsider_clip_changes): Use PT instead of BUF_PT.
9678
d251f04b
EZ
96792011-03-13 Eli Zaretskii <eliz@gnu.org>
9680
9681 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9682 $(EMACS_ROOT)/lib/intprops.h.
9683
f0c77cd1
PE
96842011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9685
3eca4629
PE
9686 Fix more problems found by GCC 4.5.2's static checks.
9687
7c86ee98
PE
9688 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9689 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9690 (xg_free_frame_widgets): Make it clear that a local variable is
9691 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9692 (gdk_window_get_screen): Make it clear that this macro is needed
9693 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9694 (int_gtk_range_get_value): New function, which avoids a diagnostic
9695 from gcc -Wbad-function-cast.
9696 (xg_set_toolkit_scroll_bar_thumb): Use it.
9697 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9698 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9699 (get_utf8_string, xg_get_file_with_chooser):
9700 Rename locals to avoid shadowing.
9701 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9702
41729b81
PE
9703 * xgselect.c (xg_select): Remove unused var.
9704
f0c77cd1
PE
9705 * image.c (four_corners_best): Mark locals as initialized.
9706 (gif_load): Initialize transparent_p to zero (Bug#8238).
9707 Mark another local as initialized.
ec6cf4c6 9708 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9709
ce0ad53d 9710 * image.c (clear_image_cache): Now static.
d5d5a617 9711 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9712 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9713 (x_edge_detection): Remove unnecessary cast that
9714 gcc -Wbad-function-cast diagnoses.
2037898d 9715 (gif_load): Fix pointer signedness.
6ae141d6
PE
9716 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9717 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9718
33383987 97192011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9720
d32df629
PE
9721 Improve quality of tests for time stamp overflow.
9722 For example, without this patch (encode-time 0 0 0 1 1
9723 1152921504606846976) returns the obviously-bogus value (-948597
9724 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9725 reports time overflow. See
9726 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9727 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9728 * editfns.c: Include limits.h and intprops.h.
9729 (TIME_T_MIN, TIME_T_MAX): New macros.
9730 (time_overflow): Move earlier, to before first use.
9731 (hi_time, lo_time): New functions, for an accurate test for
9732 out-of-range times.
9733 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9734 (Fget_internal_run_time): Don't assume time_t fits in int.
9735 (make_time): Use list2 instead of Fcons twice.
9736 (Fdecode_time): More accurate test for out-of-range times.
9737 (check_tm_member): New function.
9738 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9739 (lisp_time_argument): Don't rely on undefined left-shift and
9740 right-shift behavior when checking for time stamp overflow.
8be6f318 9741
fe31d94c
PE
9742 * editfns.c (time_overflow): New function, refactoring common code.
9743 (Fformat_time_string, Fdecode_time, Fencode_time):
9744 (Fcurrent_time_string): Use it.
9745
8be6f318
PE
9746 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9747 * dired.c (make_time): Move to ...
9748 * editfns.c (make_time): ... here.
9749 * systime.h: Note the move.
9750
09d9db2c 97512011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9752
126bc0dc
YM
9753 * fringe.c (update_window_fringes): Remove unused variables.
9754
c47cbdfd
YM
9755 * unexmacosx.c (copy_data_segment): Also copy __got section.
9756 (Bug#8223)
9757
7ac80be9
EZ
97582011-03-12 Eli Zaretskii <eliz@gnu.org>
9759
c96bbc66 9760 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9761 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9762 Constify `char *' arguments and their references according to
9763 prototypes in tparam.h.
9764
ecb0f94d 9765 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9766
7ac80be9
EZ
9767 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9768 Adapt all references accordingly.
9769
9770 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9771
ef1fd07e
TT
97722011-03-11 Tom Tromey <tromey@redhat.com>
9773
9774 * buffer.c (syms_of_buffer): Remove obsolete comment.
9775
7ef4b50c
EZ
97762011-03-11 Eli Zaretskii <eliz@gnu.org>
9777
9778 * termhooks.h (encode_terminal_code): Declare prototype.
9779
9780 * msdos.c (encode_terminal_code): Don't declare prototype.
9781
9782 * term.c (encode_terminal_code): Now external again, used by
9783 w32console.c and msdos.c.
9784
44f230aa
SM
9785 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9786 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9787
4b1ec863 97882011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9789
1714f52b 9790 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9791
4b1ec863
PE
9792 * fringe.c (update_window_fringes): Mark locals as initialized
9793 (Bug#8227).
9794 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9795
524c7aa6
PE
9796 * alloc.c (mark_fringe_data): Move decl from here ...
9797 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9798 to check its interface.
9799 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9800
a5c0af81 9801 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9802 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9803 (fontset_font): Mark local as initialized.
a9a06e0b 9804 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9805
b4716021
PE
9806 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9807
811e9bac 9808 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9809 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9810 (x_own_selection, Fx_disown_selection_internal): Rename locals
9811 to avoid shadowing.
9812 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9813
7e3ab302
PE
9814 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9815 so that the caller can use some name other than gcpro1.
9816 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9817 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9818 (Fx_backspace_delete_keys_p):
9819 Use them to avoid shadowing, and rename vars to avoid shadowing.
9820 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9821 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9822 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9823 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9824 Remove unused locals.
7e3ab302
PE
9825 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9826 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9827 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9828 macros.
f78faa98 9829
e2b13473
PE
9830 * xterm.h (x_mouse_leave): New decl.
9831
77f23912
PE
9832 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9833 Remove unused functions.
cdf4ba58
PE
9834 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9835 (x_calc_absolute_position): Now static.
7411c686 9836 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9837 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9838 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9839 unless they are used.
38d0b34a
PE
9840 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9841 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9842 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9843 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9844 (x_error_catcher, x_connection_closed, x_error_handler):
9845 (x_error_quitter, xembed_send_message, x_iconify_frame):
9846 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9847 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9848 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9849
44f230aa
SM
9850 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9851 Rename or move locals to avoid shadowing.
6b463e58 9852 (tty_defined_color, merge_face_heights): Now static.
5967d051 9853 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9854 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9855 does not deduce is never used uninitialized.
73719eba
PE
9856 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9857 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9858
426994c3 9859 * terminal.c (store_terminal_param): Now static.
5489860b 9860
032f1620 9861 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9862 (set_frame_menubar): Remove unused local.
d4323972 9863 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9864 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9865 since they might point to immutable storage.
281585b0
PE
9866 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9867 since it's unused otherwise.
032f1620 9868
367c19e5 9869 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9870 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9871 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9872 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9873 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9874 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9875 does not deduce are never used uninitialized.
70739cbe 9876
07b48fa9
PE
9877 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9878
8868a238 9879 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9880 * window.c (window_loop, size_window):
9881 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9882
7e5cf297 9883 * window.c (display_buffer): Now static.
d6550a9f
PE
9884 (size_window): Mark variables that gcc -Wuninitialized
9885 does not deduce are never used uninitialized.
a586633d
PE
9886 * window.h (check_all_windows): New decl, to forestall
9887 gcc -Wmissing-prototypes diagnostic.
5b555da1 9888 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9889
f6095868
PE
9890 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9891 shadowing.
9892 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9893 Include <limits.h>.
9894 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9895 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9896 (load_charset_map): Mark variables that gcc -Wuninitialized
9897 does not deduce are never used uninitialized.
53df7c11 9898 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9899
f38b440c
PE
9900 * coding.c (coding_set_source, coding_set_destination):
9901 Use "else { /* comment */ }" rather than "else /* comment */;"
9902 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9903 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9904 a block, when the outer 'i' will do.
9905 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9906 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9907 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9908 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9909 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9910 Rename locals to avoid shadowing.
9911 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9912 * coding.c (emacs_mule_char, encode_invocation_designation):
9913 Now static, since they're not used elsewhere.
413bb2db 9914 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9915 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9916 (decode_coding_emacs_mule): Mark variables that gcc
9917 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9918 (detect_coding_iso_2022): Initialize a local variable that might
9919 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9920 this initialization is needed. (Bug#8211)
5f58e762
PE
9921 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9922 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9923 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9924 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9925 Remove unused macros.
f38b440c 9926
232b38b9 9927 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9928 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9929 * character.c (string_count_byte8): Likewise.
232b38b9 9930
fb90da1b
PE
9931 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9932 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9933
fb93dbc2
PE
9934 * chartab.c (copy_sub_char_table): Now static, since it's not used
9935 elsewhere.
5c156ace
PE
9936 (sub_char_table_ref_and_range, char_table_ref_and_range):
9937 Rename locals to avoid shadowing.
bbcd0949 9938 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9939
7d3b3862 9940 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9941 (BIDI_BOB): Remove unused macro.
7d3b3862 9942
6be7d3da
PE
9943 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9944 deduce are never used uninitialized.
c2ed9c8b 9945 * term.c (encode_terminal_code): Likewise.
6be7d3da 9946
75f8807f 9947 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9948
50938595
PE
9949 * tparam.h: New file.
9950 * term.c, tparam.h: Include it.
9951 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9952 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9953 Move these decls to tparam.h, and make them agree with what
9954 is actually in tparam.c. The previous trick of using incompatible
9955 decls in different modules does not conform to the C standard.
9956 All callers of tparam changed to use tparam's actual API.
9957 * tparam.c (tparam1, tparam, tgoto):
9958 Use const pointers where appropriate.
9959
fbceeba2
PE
9960 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9961 * cm.h (struct cm): Likewise.
9962 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9963 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9964 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9965 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9966 (turn_on_face, init_tty): Likewise.
9967 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9968
7f3f1250
PE
9969 * term.c (term_mouse_position): Rename local to avoid shadowing.
9970
e6ca6543
PE
9971 * alloc.c (mark_ttys): Move decl from here ...
9972 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9973
c40f8d15
AS
99742011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9975
9976 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9977
cfe0661d
JB
99782011-03-09 Juanma Barranquero <lekktu@gmail.com>
9979
9980 * search.c (compile_pattern_1): Remove argument regp, unused since
9981 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9982 (compile_pattern): Don't pass it.
9983
0afb4571
J
99842011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9985
9986 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9987 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9988 for ! HAVE_GTK3.
9989 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9990
9991 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9992
9993 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9994 gdk_window_get_screen, gdk_window_get_geometry,
9995 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9996 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9997 (xg_get_pixbuf_from_pixmap): New function.
9998 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9999 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10000 Call xg_get_pixbuf_from_pixmap instead of
10001 gdk_pixbuf_get_from_drawable.
10002 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10003 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10004 (xg_check_special_colors): Use GtkStyleContext and its functions
10005 for HAVE_GTK3.
10006 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10007 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10008 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10009 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10010 Call gtk_widget_get_preferred_size.
0afb4571
J
10011 (xg_frame_resized): gdk_window_get_geometry only takes 5
10012 parameters.
44f230aa
SM
10013 (xg_win_to_widget, xg_event_is_for_menubar):
10014 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10015 (xg_set_widget_bg): New function.
10016 (delete_cb): New function.
895009e1 10017 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10018 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10019 (xg_set_background_color): Call xg_set_widget_bg.
10020 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10021 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10022 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10023 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10024 if ! HAVE_GTK3.
10025 (update_frame_tool_bar): Call gtk_widget_hide.
10026 (xg_initialize): Use GDK_KEY_g.
10027
10028 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10029 if ! HAVE_GTK3
10030 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10031
10032 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10033 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10034 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10035
1c2cc4ef
JB
100362011-03-08 Juanma Barranquero <lekktu@gmail.com>
10037
10038 * w32xfns.c (select_palette): Check success of RealizePalette against
10039 GDI_ERROR, not zero.
10040
33383987 10041See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10042
10043;; Local Variables:
10044;; coding: utf-8
aac0c6e3
MR
10045;; End:
10046
2f097256 10047 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10048
10049 This file is part of GNU Emacs.
10050
10051 GNU Emacs is free software: you can redistribute it and/or modify
10052 it under the terms of the GNU General Public License as published by
10053 the Free Software Foundation, either version 3 of the License, or
10054 (at your option) any later version.
10055
10056 GNU Emacs is distributed in the hope that it will be useful,
10057 but WITHOUT ANY WARRANTY; without even the implied warranty of
10058 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10059 GNU General Public License for more details.
10060
10061 You should have received a copy of the GNU General Public License
10062 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.