* etc/NEWS: Update for renamed variable.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
383f7350
CY
12012-06-03 Chong Yidong <cyd@gnu.org>
2
3 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4 buffer (Bug#11226).
5
5f2c76c6
CY
62012-06-03 Chong Yidong <cyd@gnu.org>
7
8 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
9 (note_mode_line_or_margin_highlight): If there is no help echo,
10 use mode-line-default-help-echo. Handle the case where the mouse
11 position is past the end of the mode line string.
12
13 * buffer.c (buffer_local_value_1): New function, split from
14 Fbuffer_local_value; can return Qunbound.
15 (Fbuffer_local_value): Use it.
16 (Vmode_line_format): Docstring tweaks.
17
773d47f6
PE
182012-06-02 Paul Eggert <eggert@cs.ucla.edu>
19
20 * sysdep.c (system_process_attributes): Improve comment.
21
f2d6a3df
SM
222012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
23
24 * keyboard.c: Export real-this-command to Elisp.
25 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
26 and DEFVAR it. Update all users.
27
63810350
PE
282012-06-02 Paul Eggert <eggert@cs.ucla.edu>
29
7bd5c1f4
PE
30 * minibuf.c (Fassoc_string): Remove duplicate declaration.
31
63810350
PE
32 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
33 Convert pctcpu and pctmem to Lisp float properly.
34 Let the compiler fold better, as 100.0/0x8000 is exact.
35
a2821611
AS
362012-06-02 Andreas Schwab <schwab@linux-m68k.org>
37
38 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
39 cons_block.
40
5fceba1d
PE
412012-06-01 Paul Eggert <eggert@cs.ucla.edu>
42
43 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
44
c98ff5dd
DA
452012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
46
47 For a 'struct window', replace some Lisp_Object fields to
48 bitfields where appropriate, remove unused fields.
49 * window.h (struct window): Remove unused 'last_mark_x' and
50 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
51 change it's type from Lisp_Object to bitfield.
52 Change type of 'force_start', 'optional_new_start',
53 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
54 fields from Lisp_Object to bitfield. Adjust users accordingly.
55
ca34e0be
PE
562012-05-31 Paul Eggert <eggert@cs.ucla.edu>
57
58 Pacify gcc -Wdouble-precision when using Xaw.
59 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
60 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
61 Use 'float' consistently, rather than 'float' in most places
62 and 'double' in a couple of places.
63
efc00ab1 642012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
65
66 * xdisp.c (handle_stop): Detect whether we have overlay strings
67 loaded by testing it->current.overlay_string_index to be
68 non-negative, instead of checking whether n_overlay_strings is
69 positive. (Bug#11587)
70
efc00ab1 712012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
72
73 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
74
75 * doc.c (Fsubstitute_command_keys): Doc fix.
76
efc00ab1 772012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
78
79 * search.c (search_buffer): Remove calls to
80 r_alloc_inhibit_buffer_relocation, as it is now called by
81 maybe_unify_char, which was the cause of relocation of buffer text
82 in bug#11519.
83
efc00ab1 842012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
85
86 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
87 for the duration of call to load_charset, to avoid problems with
88 callers of maybe_unify_char that access buffer text through C
89 pointers.
90
91 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
92 decrement the inhibition flag, instead of just setting or
93 resetting it.
94
ba93a187
PE
952012-05-31 Paul Eggert <eggert@cs.ucla.edu>
96
97 Remove obsolete '#define static' cruft.
98 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
99 This #undef was "temporary" in 2000; it is no longer needed
100 now that '#define static' has gone away.
101 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
102 (gray_bitmap_bits): Remove; no longer needed.
103 All uses replaced with definiens.
104 * xterm.c: Include "bitmaps/gray.xbm".
105
9e4bf381
PE
1062012-05-30 Paul Eggert <eggert@cs.ucla.edu>
107
108 Clean up __executable_start, monstartup when --enable-profiling.
109 The following changes affect the code only when profiling.
110 * dispnew.c (__executable_start): Rename from safe_bcopy.
111 Define only on platforms that need it.
112 * emacs.c: Include <sys/gmon.h> when profiling.
113 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
114 (__executable_start): Remove decl, since lisp.h does it now.
115 (safe_bcopy): Remove decl; no longer has that name.
116 (main): Coalesce #if into single bit of code, for simplicity.
117 Cast pointers to uintptr_t, since standard libraries want integers
118 and not pointers.
119 * lisp.h (__executable_start): New decl.
120
32d72c2f
GM
1212012-05-31 Glenn Morris <rgm@gnu.org>
122
123 * image.c (Fimagemagick_types): Doc fix.
124
baac5bc7
JM
1252012-05-30 Jim Meyering <meyering@redhat.com>
126
127 * callproc.c (Fcall_process_region): Include directory component
128 in mkstemp error message (Bug#11586).
129
72cb32cf
PE
1302012-05-30 Paul Eggert <eggert@cs.ucla.edu>
131
132 * alloc.c, lisp.h (make_pure_vector): Now static.
133
61b108cc
SM
1342012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
135
136 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
137 Move to byte-run.el.
138 (Fautoload): Do the hash-doc more carefully.
139 * data.c (Fdefalias): Purify definition, except for keymaps.
140 (Qdefun): Move from eval.c.
141 * lisp.h (Qdefun): Remove.
142 * lread.c (read1): Tiny simplification.
143
471fe23d
TN
1442012-05-29 Troels Nielsen <bn.troels@gmail.com>
145
934f3f58 146 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
147 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
148 Bug#9642, but explicitly check that the buffer the overlay would
149 be moved to is live and rearrange lines to make sure that errors
150 will not put the overlay in an inconsistent state.
151 (Fdelete_overlay): Cosmetics.
152
85d0efd1
EZ
1532012-05-28 Eli Zaretskii <eliz@gnu.org>
154
155 * w32term.c (my_bring_window_to_top): New function.
156 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
157 could be different from the original one.
158 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
159 (Bug#11513)
160
161 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
162 by calling BringWindowToTop.
163
164 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
165 (WM_EMACS_END): Increase by one.
166
da92a98c
PE
1672012-05-28 Paul Eggert <eggert@cs.ucla.edu>
168
169 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
170 This avoids undefined behavior that might cause the eassert
171 to not catch an out-of-range value.
172
74d1f848
JB
1732012-05-28 Juanma Barranquero <lekktu@gmail.com>
174
175 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
176 Update dependencies.
177
9e1a06fc
EZ
1782012-05-27 Eli Zaretskii <eliz@gnu.org>
179
180 * bidi.c (bidi_mirror_char): Fix last change.
181
f3dd7312
AS
1822012-05-27 Andreas Schwab <schwab@linux-m68k.org>
183
184 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
185 when referring to sectname field in printf format.
186
81899c91
PE
1872012-05-27 Paul Eggert <eggert@cs.ucla.edu>
188
57b81a9f
PE
189 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
190 Only r_alloc_inhibit_buffer_relocation needed to be added;
191 the others were already declared.
192
81899c91
PE
193 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
194 before checking whether it's out of range. Put the check inside
195 eassert. See
196 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
197
33017faf 1982012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
199
200 * callproc.c (Fcall_process): Restore a line that was accidentally
201 commented out in the 2011-02-13 change (bug#11547).
202
33017faf 2032012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
204
205 * lisp.h [REL_ALLOC]: Add prototypes for external functions
206 defined on ralloc.c.
207
208 * buffer.c [REL_ALLOC]: Remove prototypes of
209 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
210 they are now on lisp.h.
211
212 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
213
214 * search.c (search_buffer): Use it to inhibit relocation of buffer
215 text while re_search_2 is doing its job, because re_search_2 is
216 passed C pointers to buffer text. (Bug#11519)
217
23415acf
EZ
218 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
219 Update value to 24.
220
44e27368
EZ
221 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
222 state after an additional call to move_it_in_display_line_to, keep
223 the values of it->max_ascent and it->max_descent found for the
224 entire line.
225 (pos_visible_p): Revert the comparison against bottom_y to what it
226 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
227 (Bug#11464)
228
c1892f11
PE
2292012-05-26 Paul Eggert <eggert@cs.ucla.edu>
230
231 Fix coding-related core dumps with gcc -ftrapv.
232 The code was computing A - B, where A and B are pointers, and B is
233 random garbage. This can lead to core dumps on platforms that
234 have special pointer registers, and it also leads to core dumps on
235 x86-64 when compiled with gcc -ftrapv. The fix is to compute
236 A - B only when B is initialized properly.
237 * coding.c (coding_set_source, coding_set_destination): Return void.
238 (coding_change_source, coding_change_destinations): New functions,
239 with the old behaviors of coding_set_source and coding_set_destination.
240 All callers that need an offset changed to use these new functions.
241
eb7afdad
GM
2422012-05-26 Glenn Morris <rgm@gnu.org>
243
244 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
245
f12fdf02
EZ
2462012-05-26 Eli Zaretskii <eliz@gnu.org>
247
53a63be6 248 Extend mouse support on W32 text-mode console.
61b108cc
SM
249 * xdisp.c (draw_row_with_mouse_face):
250 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 251
eb3f6f01 252 * w32console.c: Include window.h.
61b108cc
SM
253 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
254 New functions.
eb3f6f01
EZ
255 (initialize_w32_display): Initialize mouse-highlight data.
256
53a63be6
EZ
257 * w32inevt.c: Include termchar.h and window.h.
258 (do_mouse_event): Support mouse-autoselect-window. When the mouse
259 moves, call note_mouse_highlight. If help_echo changed, call
260 gen_help_event to produce help-echo message in the echo area.
261 Call clear_mouse_face if mouse_face_hidden is set in the mouse
262 highlight info.
263
4cfd81f6
PE
2642012-05-26 Paul Eggert <eggert@cs.ucla.edu>
265
266 * lread.c (read1): Simplify slightly to avoid an overflow warning
267 with GCC 4.7.0 on x86-64.
268
4446092a
EZ
2692012-05-26 Eli Zaretskii <eliz@gnu.org>
270
271 * bidi.c (bidi_mirror_char): Revert last change: an int is
272 definitely wide enough here.
273
42b2a986 2742012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 275
42b2a986 276 Fix integer width and related bugs (Bug#9874).
eb106a49 277 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
278 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
279 (string_bytes, check_sblock, allocate_string_data):
280 (compact_small_strings, Fmake_bool_vector, make_string)
281 (make_unibyte_string, make_multibyte_string)
282 (make_string_from_bytes, make_specified_string)
283 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
284 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
285 (mark_vectorlike):
286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
287 (allocate_pseudovector):
288 Use int, not EMACS_INT, where int is wide enough.
289 (inhibit_garbage_collection, Fgarbage_collect):
290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
291 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
292 int might not be wide enough.
293 (bidi_cache_search, bidi_cache_find, bidi_init_it)
294 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
295 (bidi_at_paragraph_end, bidi_find_paragraph_start)
296 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
297 (bidi_level_of_next_char, bidi_move_to_visually_next):
298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
299 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
300 (Fkill_buffer, Fset_buffer_major_mode)
301 (advance_to_char_boundary, Fbuffer_swap_text)
302 (Fset_buffer_multibyte, overlays_at, overlays_in)
303 (overlay_touches_p, struct sortvec, record_overlay_string)
304 (overlay_strings, recenter_overlay_lists)
305 (adjust_overlays_for_insert, adjust_overlays_for_delete)
306 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
307 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
308 (Foverlay_recenter, last_overlay_modification_hooks_used)
309 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
311 (validate_region): Omit unnecessary test for b <= e,
312 since that's guaranteed by the previous test.
d311d28c
PE
313 (adjust_overlays_for_delete): Avoid pos + length overflow.
314 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
315 (report_overlay_modification):
316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
317 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
318 Omit pointer cast, which isn't needed anyway, and doesn't work
319 after the EMACS_INT -> ptrdiff_t change.
02481186 320 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
321 * buffer.h: Adjust decls to match defn changes elsewhere.
322 (struct buffer_text, struct buffer):
323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
324 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
325 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
326 not int, to avoid needless 32-bit limit on 64-bit hosts.
327 (exec_byte_code): Use tighter memory-full test, one that checks
328 for alloca overflow. Don't compute the address of the object just
329 before an array, as that's not portable. Use EMACS_INT, not
330 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
331 * callint.c (Fcall_interactively):
332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
333 * callproc.c (call_process_kill, Fcall_process):
334 Don't assume pid_t fits into an Emacs fixnum.
335 (call_process_cleanup, Fcall_process, child_setup):
336 Don't assume pid_t fits into int.
337 (call_process_cleanup, Fcall_process, delete_temp_file)
338 (Fcall_process_region):
339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
340 (Fcall_process): Simplify handling of volatile integers.
341 Use int, not EMACS_INT, where int will do.
342 * casefiddle.c (casify_object, casify_region, operate_on_word)
343 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
345 (casify_object): Avoid integer overflow when overallocating buffer.
346 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 347 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
348 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
349 * category.h (CATEGORYP): Don't assume arg is nonnegative.
350 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
351 integers are now checked earlier. All uses replaced with XINT.
352 (ccl_driver):
353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
354 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
355 (ccl_driver, Fregister_code_conversion_map):
356 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
357 (resolve_symbol_ccl_program): Check that vector header is in range.
358 Always copy the vector, so that we can check its contents reliably
359 now rather than having to recheck each instruction as it's being
360 executed. Check that vector words fit in 'int'.
361 (ccl_get_compiled_code, Fregister_ccl_program)
362 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
363 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
364 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
365 contents are in range.
366 (Fccl_execute_on_string): Check that status is in range.
367 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
368 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
369 Accept and return EMACS_INT, not int, because callers can pass values
370 out of 'int' range.
371 (c_string_width, strwidth, lisp_string_width, chars_in_text)
372 (multibyte_chars_in_text, parse_str_as_multibyte)
373 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
374 (str_as_unibyte, str_to_unibyte, string_count_byte8)
375 (string_escape_byte8, Fget_byte):
376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 377 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
378 avoid mishandling large integers.
379 * character.h: Adjust decls to match defn changes elsewhere.
380 * charset.c (load_charset_map_from_file, find_charsets_in_text)
381 (Ffind_charset_region):
382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
383 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
384 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 385 Don't assume fixnum fits in int.
d311d28c
PE
386 (load_charset_map_from_vector, Fmap_charset_chars):
387 Remove now-unnecessary CHECK_NATNUMs.
388 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
389 Don't rely on undefined behavior with signed left shift overflow.
390 Don't assume unsigned int fits into fixnum, or that fixnum fits
391 into unsigned int. Don't require max_code to be a valid fixnum;
392 that's not true for gb10830 4-byte on a 32-bit host. Allow
393 invalid_code to be a cons, for the same reason. Require code_offset
394 to be a character. Avoid int overflow if max_char is close
395 to INT_MAX.
396 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
397 this is intended anyway and avoids some undefined behavior.
398 (load_charset_map): Pass unsigned, not int, as 2nd arg of
399 INDEX_TO_CODE_POINT, as that's what it expects.
400 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
401 * charset.h (DECODE_CHAR): Return int, not unsigned;
402 this is what was intended anyway, and it avoids undefined behavior.
403 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
404 integer-overflow issues.
405 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
406 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
407 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
408 * chartab.c (Fmake_char_table, Fset_char_table_range)
409 (uniprop_get_decoder, uniprop_get_encoder):
410 Don't assume fixnum fits in int.
411 * cmds.c (move_point): New function, that does the gist of
412 Fforward_char and Fbackward_char, but does so while checking
413 for integer overflow more accurately.
c96e5d6a 414 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
415 (Fforward_line, Fend_of_line, internal_self_insert)
416 (internal_self_insert):
417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
418 Fix a FIXME, by checking for integer overflow when calculating
419 target_clm and actual_clm.
420 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 421 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
422 (ASSURE_DESTINATION, coding_alloc_by_realloc)
423 (coding_alloc_by_making_gap, alloc_destination)
424 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
425 (encode_coding_utf_16, detect_coding_emacs_mule)
426 (decode_coding_emacs_mule, encode_coding_emacs_mule)
427 (detect_coding_iso_2022, decode_coding_iso_2022)
428 (encode_invocation_designation, encode_designation_at_bol)
429 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
430 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
431 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
432 (encode_coding_ccl, encode_coding_raw_text)
433 (detect_coding_charset, decode_coding_charset)
434 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
435 (produce_composition, produce_charset, produce_annotation)
436 (decode_coding, handle_composition_annotation)
437 (handle_charset_annotation, consume_chars, decode_coding_gap)
438 (decode_coding_object, encode_coding_object, detect_coding_system)
439 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
440 (code_convert_region, code_convert_string)
8f50130c
PE
441 (Fdefine_coding_system_internal)
442 (coding_set_source, coding_set_destination):
d311d28c
PE
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
445 (Fdefine_coding_system_internal):
446 Don't assume fixnums fit in int.
447 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 448 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
449 (Funencodable_char_position, Fcheck_coding_systems_region)
450 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 452 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 453 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 454 Don't access memory outside of the args array.
d311d28c 455 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
456 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
457 result of ENCODE_CHAR.
d311d28c
PE
458 * coding.h: Adjust decls to match defn changes elsewhere.
459 (struct coding_system):
460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
461 * composite.c (get_composition_id, find_composition)
462 (run_composition_function, update_compositions)
463 (compose_text, composition_gstring_put_cache)
464 (composition_gstring_p, composition_gstring_width)
465 (fill_gstring_header, fill_gstring_body, autocmp_chars)
466 (composition_compute_stop_pos, composition_reseat_it)
467 (composition_update_it, struct position_record)
468 (find_automatic_composition, composition_adjust_point)
469 (Fcomposition_get_gstring, Ffind_composition_internal):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (update_compositions):
472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
473 * composite.h: Adjust decls to match defn changes elsewhere.
474 (struct composition):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
477 Do not attempt to compute the address of the object just before a
478 buffer; this is not portable.
479 (Faref, Faset):
480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
481 (Faset): Use int, not EMACS_INT, where int is wide enough.
482 (Fstring_to_number): Don't assume fixnums fit in int.
483 (Frem): Don't assume arg is nonnegative.
484 * dbusbind.c (xd_append_arg): Check for integers out of range.
485 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 486 (extract_signed, extract_unsigned): New functions.
243e0530
PE
487 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
488 (xd_get_connection_references): Return ptrdiff_t, not int.
489 All uses changed.
490 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
491 (xd_read_message_1):
492 Use int, not unsigned, where the dbus API uses int.
493 (Fdbus_message_internal): Don't overflow mtype.
494 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
495 * dired.c (directory_files_internal, file_name_completion, scmp)
496 (file_name_completion_stat):
497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
498 (file_name_completion): Don't overflow matchcount.
499 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
500 * dispextern.h: Adjust decls to match defn changes elsewhere.
501 (struct text_pos, struct glyph, struct bidi_saved_info)
502 (struct bidi_string_data, struct bidi_it, struct composition_it)
503 (struct it):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (struct display_pos, struct composition_it, struct it):
506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
507 * dispnew.c (increment_matrix_positions)
508 (increment_row_positions, mode_line_string)
509 (marginal_area_string):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 511 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
513 (duration_to_sec_usec): New function, to check for overflow better.
514 (Fsleep_for, sit_for): Use it.
515 * doc.c (get_doc_string, store_function_docstring):
516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
517 (get_doc_string, Fsnarf_documentation):
518 Use int, not EMACS_INT, where int is wide enough.
519 (get_doc_string):
520 Use SAFE_ALLOCA, not alloca.
521 Check for overflow when converting EMACS_INT to off_t.
522 * doprnt.c (doprnt):
523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
524 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
525 Don't assume uid_t fits into fixnum.
526 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
527 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
528 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
529 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
530 (general_insert_function)
531 (Finsert_char, make_buffer_string, make_buffer_string_both)
532 (update_buffer_properties, Fbuffer_substring)
533 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
534 (Fsubst_char_in_region, check_translation)
535 (Ftranslate_region_internal, save_restriction_restore, Fformat)
536 (transpose_markers, Ftranspose_regions):
537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
538 (clip_to_bounds): Move to lisp.h as an inline function).
539 (Fconstrain_to_field): Don't assume integers are nonnegative.
540 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
541 (Fsubst_char_in_region, Fsave_restriction):
542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
543 (Femacs_pid): Don't assume pid_t fits into fixnum.
544 (lo_time): Use int, not EMACS_INT, when int suffices.
545 (lisp_time_argument): Check for usec out of range.
546 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
547 (Fuser_login_name, Fuser_full_name): Signal an error
548 if a uid argument is out of range, rather than relying on
549 undefined behavior.
c8d5c857
PE
550 (Fformat_time_string): Remove now-unnecessary check.
551 lisp_time_argument checks for out-of-range usec now.
243e0530 552 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
553 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
554 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
555 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
556 (init_cmdargs, Fdump_emacs):
557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
558 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
559 the bottom (typically) 32 bits of the fixnum.
560 * eval.c (specpdl_size, call_debugger):
561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
562 (when_entered_debugger, Fbacktrace_debug):
563 Don't assume fixnum can fit in int.
564 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
565 the object just before a buffer; this is not portable.
566 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
567 (grow_specpdl, unbind_to):
568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
569 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
570 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 571 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
572 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
573 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
575 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
576 (a_write, e_write):
577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
578 (Fcopy_file, non_regular_nbytes, read_non_regular)
579 (Finsert_file_contents):
580 Use int, not EMACS_INT, where int is wide enough.
581 (READ_BUF_SIZE): Verify that it fits in int.
582 (Finsert_file_contents): Check that counts are in proper range,
583 rather than assuming fixnums fit into ptrdiff_t etc.
584 Don't assume fixnums fit into int.
125b3835 585 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
586 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
587 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
588 (string_char_to_byte, string_byte_to_char)
589 (string_make_multibyte, string_to_multibyte)
590 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
591 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
592 (substring_both, Fdelete, internal_equal, Ffillarray)
593 (Fclear_string, mapcar1)
594 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
595 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
596 (larger_vector, make_hash_table, maybe_resize_hash_table)
597 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
598 (Fmaphash, secure_hash):
599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
600 (concat): Check for string index and length overflow.
601 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
602 (Frequire):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 (larger_vector): New API (vec, incr_min, size_max) replaces old
605 one (vec, new_size, init). This catches size overflow.
606 INIT was removed because it was always Qnil.
607 All callers changed.
608 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
609 the upper bound on a hash table index size.
610 (make_hash_table, maybe_resize_hash_table): Use it.
611 (secure_hash): Computer start_byte and end_byte only after
612 they're known to be in ptrdiff_t range.
613 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
614 (Ffont_get_glyphs, Ffont_at):
615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
616 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
617 (Flist_fonts, Fopen_font):
618 Don't assume fixnum can fit in int.
619 (check_gstring): Don't assume index can fit in int.
620 (font_match_p): Check that fixnum is a character, not a nonnegative
621 fixnum, since the later code needs to stuff it into an int.
622 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
623 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
624 conversion overflow issues.
625 (Fopen_font): Check for integer out of range.
626 (Ffont_get_glyphs): Don't assume index can fit in int.
627 * font.h: Adjust decls to match defn changes elsewhere.
628 * fontset.c (reorder_font_vector): Redo score calculation to avoid
629 integer overflow.
630 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
631 printmax_t, where ptrdiff_t is wide enough.
632 (Finternal_char_font):
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
635 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
636 (Fset_frame_position, x_set_frame_parameters)
637 (x_set_line_spacing, x_set_border_width)
638 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
639 Check that fixnums are in proper range for system types.
640 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
642 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
643 Use SAFE_ALLOCA_LISP, not alloca.
644 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
645 intptr_t is wide enough.
646 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
647 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
648 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
649 Check for fixnum out of range.
650 * ftfont.c (ftfont_list): Don't assume index fits in int.
651 Check that fixnums are in proper range for system types.
652 (ftfont_shape_by_flt):
653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
654 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
657 Check that fixnums are in proper range for system types.
658 * gnutls.h: Adjust decls to match defn changes elsewhere.
659 * gtkutil.c (xg_dialog_run):
660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
661 (update_frame_tool_bar):
662 Check that fixnums are in proper range for system types.
663 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 664 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
665 * indent.c (last_known_column, last_known_column_point):
666 (current_column_bol_cache):
667 (skip_invisible, current_column, check_display_width):
668 (check_display_width, scan_for_column, current_column_1)
669 (Findent_to, Fcurrent_indentation, position_indentation)
670 (indented_beyond_p, Fmove_to_column, compute_motion):
671 (Fcompute_motion, Fvertical_motion):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (last_known_column_modified): Use EMACS_INT, not int.
674 (check_display_width):
675 (Fcompute_motion):
676 Check that fixnums and floats are in proper range for system types.
677 (compute_motion): Don't assume index or fixnum fits in int.
678 (compute_motion, Fcompute_motion):
679 Use int, not EMACS_INT, when it is wide enough.
680 (vmotion): Omit local var start_hpos that is always 0; that way
681 we don't need to worry about overflow in expressions involving it.
682 * indent.h: Adjust decls to match defn changes elsewhere.
683 (struct position):
684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
685 Use int, not EMACS_INT, where int is wide enough.
686 Remove unused members ovstring_chars_done and tab_offset;
687 all uses removed.
688 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
689 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
690 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
691 (make_gap, copy_text, insert, insert_and_inherit)
692 (insert_before_markers, insert_before_markers_and_inherit)
693 (insert_1, count_combining_before, count_combining_after)
694 (insert_1_both, insert_from_string)
695 (insert_from_string_before_markers, insert_from_string_1)
696 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
697 (adjust_after_replace, adjust_after_insert, replace_range)
698 (replace_range_2, del_range, del_range_1, del_range_byte)
699 (del_range_both, del_range_2, modify_region)
700 (prepare_to_modify_buffer, signal_before_change)
701 (signal_after_change, Fcombine_after_change_execute):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 * intervals.c (traverse_intervals, rotate_right, rotate_left)
704 (balance_an_interval, split_interval_right, split_interval_left)
705 (find_interval, next_interval, update_interval)
706 (adjust_intervals_for_insertion, delete_node, delete_interval)
707 (interval_deletion_adjustment, adjust_intervals_for_deletion)
708 (static_offset_intervals, offset_intervals)
709 (merge_interval_right, merge_interval_left, make_new_interval)
710 (graft_intervals_into_buffer, temp_set_point_both)
711 (temp_set_point, set_point, adjust_for_invis_intang)
712 (set_point_both, move_if_not_intangible, get_property_and_range)
713 (get_local_map, copy_intervals, copy_intervals_to_string)
714 (compare_string_intervals, set_intervals_multibyte_1):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 * intervals.h: Adjust decls to match defn changes elsewhere.
717 (struct interval):
718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
719 * keyboard.c (this_command_key_count, this_single_command_key_start)
720 (before_command_key_count, before_command_echo_length, echo_now)
721 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
722 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
723 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
724 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
726 (last_non_minibuf_size, last_point_position, echo_truncate)
727 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
728 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
729 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
730 (stuff_buffered_input):
731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
732 (last_auto_save, command_loop_1, read_char):
733 Use EMACS_INT, not int, to avoid integer overflow.
734 (record_char): Avoid overflow in total_keys computation.
735 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
736 * keyboard.h: Adjust decls to match defn changes elsewhere.
737 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
738 (Fkey_description, Fdescribe_vector, Flookup_key):
739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
740 (click_position): New function, to check that positions are in range.
741 (Fcurrent_active_maps):
742 (describe_command):
743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
744 (Faccessible_keymaps, Fkey_description):
745 (preferred_sequence_p):
746 Don't assume fixnum can fit into int.
747 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
748 Check for integer overflow in size calculations.
749 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
750 avoid mishandling large integers.
751 * lisp.h: Adjust decls to match defn changes elsewhere.
752 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
753 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
754 (struct Lisp_Marker):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
757 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
758 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
759 All callers changed.
760 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
761 Assume the arg has valid form, since it always does.
762 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
763 unsigned integer system type.
764 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
765 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
768 (duration_to_sec_usec): New decl.
769 * lread.c (read_from_string_index, read_from_string_index_byte)
770 (read_from_string_limit, readchar, unreadchar, openp)
771 (read_internal_start, read1, oblookup):
772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
773 (Fload, readevalloop, Feval_buffer, Feval_region):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 (openp): Check for out-of-range argument to 'access'.
776 (read1): Use int, not EMACS_INT, where int is wide enough.
777 Don't assume fixnum fits into int.
6efdadfd 778 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
779 (read_filtered_event): Use duration_to_sec_usec
780 to do proper overflow checking on durations.
d311d28c
PE
781 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
782 in size calculation.
783 (Fexecute_kbd_macro):
784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
785 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
786 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
787 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
788 (set_marker_both, set_marker_restricted_both, marker_position)
789 (marker_byte_position, Fbuffer_has_markers_at):
790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
791 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 792 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
793 It now merely ensures that the menu is large enough, without
794 necessarily growing it, as this avoids some integer overflow issues.
795 All callers changed.
796 (keymap_panes, parse_single_submenu, Fx_popup_menu):
797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
798 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
799 Use SAFE_ALLOCA_LISP, not alloca.
800 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
801 to EMACS_INT. Check that fixnums are in proper range for system types.
802 * minibuf.c (minibuf_prompt_width, string_to_object)
803 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
804 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
806 (get_minibuffer, read_minibuf_unwind):
807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
808 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
809 this simplifies overflow checking. All callers changed.
810 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
811 (Ftest_completion):
812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
813 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
814 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
815 Check that fixnums are in proper range for system types.
816 (Fx_create_frame, Fx_show_tip):
817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
818 * nsfont.m (ns_findfonts, nsfont_list_family):
819 Don't assume fixnum fits in long.
820 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
822 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
823 wide enough.
17fdb222 824 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
827 (PRINTDECLARE, PRINTPREPARE):
828 (strout, print_string):
829 (print, print_preprocess, print_check_string_charset_prop)
830 (print_object):
831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
832 (PRINTDECLARE):
833 (temp_output_buffer_setup, Fprin1_to_string, print_object):
834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
835 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 836 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 837 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
838 (print_error_message): Use SAFE_ALLOCA, not alloca.
839 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
840 (print_depth, new_backquote_output, print_number_index):
841 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
842 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
843 (Fset_process_window_size, Fformat_network_address)
844 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 845 (sigchld_handler):
d311d28c 846 Check that fixnums are in proper range for system types.
d44287d4 847 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
848 Check for process-ids out of pid_t range rather than relying on
849 undefined behavior.
e4d81efc 850 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
851 (Fformat_network_address, read_process_output, send_process)
852 (Fprocess_send_region, status_notify):
853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
854 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
855 (wait_reading_process_output, read_process_output, exec_sentinel):
856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
857 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
858 (Faccept_process_output): Use duration_to_sec_usec to do proper
859 overflow checking on durations.
dde14581
PE
860 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
861 Don't assume pid_t fits in int.
02481186
PE
862 * process.h (struct Lisp_Process): Members tick and update_tick
863 are now of type EMACS_INT, not int.
b62b53e8
PE
864 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
865 configured --with-wide-int.
d311d28c
PE
866 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
867 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
868 * search.c (looking_at_1, string_match_1):
869 (fast_string_match, fast_c_string_match_ignore_case)
870 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
871 (scan_newline, find_before_next_newline, search_command)
872 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
873 (set_search_regs, wordify):
874 (Freplace_match):
875 (Fmatch_data):
876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
877 (string_match_1, search_buffer, set_search_regs):
878 (Fmatch_data):
879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
880 (wordify): Check for overflow in size calculation.
881 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
882 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
883 Check that fixnums are in proper range for system types.
884 * sound.c (struct sound_device)
885 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
887 (Fplay_sound_internal):
888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 889 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
890 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
891 (Fparse_partial_sexp):
892 Don't assume fixnums can fit in int.
893 (struct lisp_parse_state, find_start_pos, find_start_value)
894 (find_start_value_byte, find_start_begv)
895 (update_syntax_table, char_quoted, dec_bytepos)
896 (find_defun_start, prev_char_comend_first, back_comment):
897 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
898 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
900 (Finternal_describe_syntax_value): Check that match_lisp is a
901 character, not an integer, since the code stuffs it into int.
902 (scan_words, scan_sexps_forward):
903 Check that fixnums are in proper range for system types.
904 (Fforward_word):
905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
906 (scan_sexps_forward):
907 Use CHARACTERP, not INTEGERP, since the value must fit into int.
908 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
909 * syntax.h: Adjust decls to match defn changes elsewhere.
910 (struct gl_state_s):
911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
912 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
913 MOST_POSITIVE_FIXNUM.
d311d28c
PE
914 * sysdep.c (wait_for_termination_1, wait_for_termination)
915 (interruptible_wait_for_termination, mkdir):
916 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
917 (emacs_read, emacs_write):
918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
919 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
920 and double all fit in int.
d311d28c
PE
921 * term.c (set_tty_color_mode):
922 Check that fixnums are in proper range for system types.
923 * termhooks.h (struct input_event):
924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
925 * textprop.c (validate_interval_range, interval_of)
926 (Fadd_text_properties, set_text_properties_1)
927 (Fremove_text_properties, Fremove_list_of_text_properties)
928 (Ftext_property_any, Ftext_property_not_all)
929 (copy_text_properties, text_property_list, extend_property_ranges)
930 (verify_interval_modification):
931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
932 (Fnext_single_char_property_change)
933 (Fprevious_single_char_property_change):
934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
935 (copy_text_properties):
936 Check for integer overflow in index calculation.
d311d28c
PE
937 * undo.c (last_boundary_position, record_point, record_insert)
938 (record_delete, record_marker_adjustment, record_change)
939 (record_property_change):
940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
941 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
943 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
944 (Fx_hide_tip, Fx_file_dialog):
945 * w32menu.c (set_frame_menubar):
946 Use ptrdiff_t, not int, for consistency with rest of code.
947 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
948 (select_window, Fdelete_other_windows_internal)
949 (window_scroll_pixel_based, window_scroll_line_based)
950 (Frecenter, Fset_window_configuration):
951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
952 (Fset_window_hscroll, run_window_configuration_change_hook)
953 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 954 (Fscroll_other_window, Frecenter):
d311d28c
PE
955 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
956 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
957 Don't assume fixnum fits in int.
958 (Fset_window_scroll_bars):
959 Check that fixnums are in proper range for system types.
960 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
961 (string_pos, c_string_pos, number_of_chars, init_iterator)
962 (in_ellipses_for_invisible_text_p, init_from_display_pos)
963 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
964 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
965 (face_before_or_after_it_pos, handle_invisible_prop)
966 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
967 (display_prop_intangible_p, string_buffer_position_lim)
968 (string_buffer_position, handle_composition_prop, load_overlay_strings)
969 (get_overlay_strings_1, get_overlay_strings)
970 (iterate_out_of_display_property, forward_to_next_line_start)
971 (back_to_previous_visible_line_start, reseat, reseat_to_string)
972 (get_next_display_element, set_iterator_to_next)
973 (get_visually_first_element, compute_stop_pos_backwards)
974 (handle_stop_backwards, next_element_from_buffer)
975 (move_it_in_display_line_to, move_it_in_display_line)
976 (move_it_to, move_it_vertically_backward, move_it_by_lines)
977 (add_to_log, message_dolog, message_log_check_duplicate)
978 (message2, message2_nolog, message3, message3_nolog
979 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
980 (current_message_1, truncate_echo_area, truncate_message_1)
981 (set_message, set_message_1, store_mode_line_noprop)
982 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
983 (text_outside_line_unchanged_p, check_point_in_composition)
984 (reconsider_clip_changes)
985 (redisplay_internal, set_cursor_from_row, try_scrolling)
986 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
987 (redisplay_window, find_last_unchanged_at_beg_row)
988 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
989 (trailing_whitespace_p, find_row_edges, display_line)
990 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
991 (display_mode_element, store_mode_line_string)
992 (pint2str, pint2hrstr, decode_mode_spec)
993 (display_count_lines, display_string, draw_glyphs)
994 (x_produce_glyphs, x_insert_glyphs)
995 (rows_from_pos_range, mouse_face_from_buffer_pos)
996 (fast_find_string_pos, mouse_face_from_string_pos)
997 (note_mode_line_or_margin_highlight, note_mouse_highlight):
998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
999 (safe_call, init_from_display_pos, handle_fontified_prop)
1000 (handle_single_display_spec, load_overlay_strings)
1001 (with_echo_area_buffer, setup_echo_area_for_printing)
1002 (display_echo_area, echo_area_display)
1003 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1004 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1005 (redisplay_window, dump_glyph_row, display_mode_line)
1006 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1007 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1009 (handle_single_display_spec, build_desired_tool_bar_string)
1010 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1011 (get_specified_cursor_type):
1012 Check that fixnums are in proper range for system types.
1013 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1014 (Flookup_image_map):
1015 Don't assume fixnums fit in int.
1016 (compare_overlay_entries):
1017 Avoid mishandling comparisons due to subtraction overflow.
1018 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1019 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1020 (handle_tool_bar_click):
1021 Use int, not unsigned, since we prefer signed and the signedness
1022 doesn't matter here.
1023 (get_next_display_element, next_element_from_display_vector):
1024 Use int, not EMACS_INT, when int is wide enough.
1025 (start_hourglass): Use duration_to_sec_usec to do proper
1026 overflow checking on durations.
1027 * xfaces.c (Fbitmap_spec_p):
1028 Check that fixnums are in proper range for system types.
1029 (compare_fonts_by_sort_order):
1030 Avoid mishandling comparisons due to subtraction overflow.
1031 (Fx_family_fonts, realize_basic_faces):
1032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1033 (Fx_family_fonts):
1034 Don't assume fixnum fits in int.
1035 Use SAFE_ALLOCA_LISP, not alloca.
1036 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1037 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1038 (face_at_buffer_position, face_for_overlay_string)
1039 (face_at_string_position):
1040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1041 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1042 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1043 (Fx_show_tip):
1044 Check that fixnums are in proper range for system types.
1045 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1046 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1048 (Fx_change_window_property): Don't assume fixnums fit in int.
1049 * xfont.c (xfont_chars_supported):
1050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1051 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1052 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1054 * xml.c (parse_region):
1055 * xrdb.c (magic_file_p):
1056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1057 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1058 (x_get_local_selection, x_reply_selection_request)
1059 (x_handle_selection_request, wait_for_property_change):
1060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1061 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1062 short is wide enough.
1063 (x_send_client_event): Don't assume fixnum fits in int.
1064 * xterm.c (x_x_to_emacs_modifiers):
1065 Don't assume EMACS_INT overflows nicely into int.
1066 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1067 may come from Lisp.
1068 (handle_one_xevent): NATNUMP can eval its arg twice.
1069 (x_connection_closed):
1070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1071 * xterm.h: Adjust decls to match defn changes elsewhere.
1072 (struct scroll_bar): Use struct vectorlike_header
1073 rather than rolling our own approximation.
1074 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1075
c6574eb5
GM
10762012-05-25 Glenn Morris <rgm@gnu.org>
1077
1078 * lisp.mk (lisp): Update for more files being compiled now.
1079
e8d32c7e
SM
10802012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1081
48def666
SM
1082 * lread.c: Remove `read_pure' which makes no difference.
1083 (read_pure): Remove var.
1084 (unreadpure): Remove function.
1085 (readevalloop): Don't call read_list with -1 flag.
1086 (read1, read_vector): Don't test read_pure any more.
1087 (read_list): Simplify.
1088
e8d32c7e
SM
1089 * fileio.c, character.h: Minor style tweaks.
1090
4b2addb7
DA
10912012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1092
1093 * window.h (clip_changed): Remove useless declaration.
1094
584461b2
JB
10952012-05-22 Juanma Barranquero <lekktu@gmail.com>
1096
1097 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1098 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1099
34374650
PE
11002012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Remove src/m/*.
1103 This directory predates autoconf and is no longer needed nowadays.
1104 Move its few remaining bits of functionality to where they're needed.
1105 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1106 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1107 * m/template.h: Remove.
1108 * Makefile.in (M_FILE): Remove. All uses removed.
1109 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1110 * lisp.h (USE_LSB_TAG):
1111 * mem-limits.h (EXCEEDS_LISP_PTR):
1112 Use VAL_MAX, not VALBITS, in #if.
1113 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1114 (EMACS_UINT): Define unconditionally now.
1115 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1116 (BITS_PER_EMACS_INT): New constants, replacing
1117 what used to be in config.h, but not useful in #if.
1118 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1119 define them any more.
1120 (VAL_MAX): New macro.
1121 (VALMASK): Use it.
1122 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1123 BITS_PER_EMACS_INT, in #if.
1124 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1125 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1126 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1127 * s/ms-w32.h (DATA_START):
1128 Move here from removed file m/intel386.h.
1129 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1130 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1131
261cb4bb
PE
11322012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 Assume C89 or later.
1135 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1136 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1137 (xrealloc):
1138 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1139 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1140 * textprop.c, tparam.c (NULL): Remove.
1141 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1142 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1143 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1144 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1145 * xterm.c (input_signal_count): Assume volatile works.
1146
ff23cd9f
KB
11472012-05-21 Ken Brown <kbrown@cornell.edu>
1148
1149 * xgselect.c (xg_select): Fix first argument in call to 'select'
1150 (bug#11508).
1151
1b170bc6
KB
11522012-05-20 Ken Brown <kbrown@cornell.edu>
1153
1154 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1155 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1156
b2f4d39f
KB
11572012-05-19 Ken Brown <kbrown@cornell.edu>
1158
1159 * xfns.c (x_in_use): Remove `static' qualifier.
1160 * xterm.h (x_in_use): Declare.
1161 * xgselect.c: Include xterm.h.
1162 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1163 and `display_arg' (bug#9754).
1164
003fdae2
PE
11652012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1166
9232a6d9
PE
1167 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1168
003fdae2
PE
1169 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1170 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1171
784b56e2
EZ
11722012-05-18 Eli Zaretskii <eliz@gnu.org>
1173
1174 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1175
1176 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1177 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1178
1179 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1180 reference to image_cache->refcount.
1181 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1182
a0a79cde
JL
11832012-05-17 Juri Linkov <juri@jurta.org>
1184
1185 * search.c (Fword_search_regexp, Fword_search_backward)
1186 (Fword_search_forward, Fword_search_backward_lax)
1187 (Fword_search_forward_lax): Move functions to isearch.el
1188 (bug#10145, bug#11381).
1189
b0572523
PE
11902012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1191
1192 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1193
9660f5fc
SM
11942012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1195
1196 * lread.c (init_obarray): Declare Qt and Qnil as special.
1197
4374de83
GM
11982012-05-14 Glenn Morris <rgm@gnu.org>
1199
1200 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1201 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1202
dc44c39a
PE
12032012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1204
078c97cb
PE
1205 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1206
dc44c39a
PE
1207 * unexaix.c: Port to more-recent AIX compilers.
1208 (report_error, report_error_1, make_hdr, copy_sym)
1209 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1210 Make arguments const char *, not char *, to avoid violations of C
1211 standard and to fix some AIX warnings reported by Gilles Pion.
1212
e18afed7 12132012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1214
1215 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1216 already have overlays loaded.
1217 (handle_single_display_spec): Before returning without displaying
1218 fringe bitmap, synchronize the bidi iterator with the main display
1219 iterator, by calling iterate_out_of_display_property.
1220 (iterate_out_of_display_property): Detect buffer iteration by
1221 testing that it->string is a Lisp string.
1222 (get_next_display_element): When the current object is exhausted,
1223 and there's something on it->stack, call set_iterator_to_next to
1224 proceed with what's on the stack, instead of returning zero.
1225 (set_iterator_to_next): If called at the end of a Lisp string,
1226 proceed to consider_string_end without incrementing string
1227 position. Don't increment display vector index past the end of
1228 the display vector. (Bug#11417)
c8fb9dc6
EZ
1229 (pos_visible_p): Don't report a position visible when move_it_to
1230 stopped at the last line of window, which happens to be scanned
1231 backwards by the bidi iteration. (Bug#11464)
ac268e67 1232
e18afed7 12332012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1234
1235 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1236 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1237 are on a TTY, and thus unable to display on the fringes.
1238 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1239 so we need to signal to the caller that this is a "replacing"
1240 display spec. This fixes display when the spec is invalid or we
1241 are on a TTY.
1242
e18afed7 12432012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1244
1245 * unexaix.c (make_hdr): Fix typo in prototype.
1246 This bug broke the build on AIX. Problem reported by Gilles Pion.
1247
9d0a235a
MA
12482012-05-14 Michael Albinus <michael.albinus@gmx.de>
1249
1250 * keyboard.c (kbd_buffer_get_event): Read special events also in
1251 batch mode. (Bug#11415)
1252
9e6b06ed
GM
12532012-05-12 Glenn Morris <rgm@gnu.org>
1254
1255 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1256
c1a1d7a3
EZ
12572012-05-12 Eli Zaretskii <eliz@gnu.org>
1258
1259 * lisp.mk (lisp): Add newcomment.elc.
1260
3fe7cdc8
GM
12612012-05-12 Glenn Morris <rgm@gnu.org>
1262
1263 * Makefile.in (MKDIR_P): New, set by configure.
1264 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1265
53f7d2c0
PE
12662012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 Remove unused function hourglass_started.
1269 * dispextern.h (hourglass_started):
1270 * w32fns.c (hourglass_started):
1271 * xdisp.c (hourglass_started): Remove.
1272
75aafb17
JB
12732012-05-10 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1276 Update dependencies.
1277
12959e8e
PE
12782012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1279
97107e2e
PE
1280 * xgselect.c (xg_select): Put maxfds+1 into a var.
1281 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1282
12959e8e
PE
1283 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1284
836d29b3
DA
12852012-05-10 Dave Abrahams <dave@boostpro.com>
1286
1287 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1288 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1289
5cb67954
MA
12902012-05-09 Michael Albinus <michael.albinus@gmx.de>
1291
1292 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1293 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1294 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1295 Initialize xd_registered_buses.
1296
3478ec45
PE
12972012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1298
b263a6b0
PE
1299 Untag more efficiently if USE_LSB_TAG.
1300 This is based on a proposal by YAMAMOTO Mitsuharu in
1301 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1302 For an admittedly artificial (nth 8000 longlist) benchmark on
1303 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1304 Emacs's overall text size by 1%.
1305 * lisp.h (XUNTAG): New macro.
1306 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1307 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1308 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1309 * eval.c (Fautoload):
1310 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1311 * frame.h (XFRAME): Use XUNTAG.
1312
3478ec45
PE
1313 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1314 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1315 Remove unportable assumptions about print widths of types like
1316 dbus_uint32_t.
1317 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1318 intptr_t when converting between pointer and integer, to avoid GCC
1319 warnings about wrong width.
1320
666b903b 13212012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1322
1323 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1324 stack for each reader_thread, instead of defaulting to 8MB
1325 determined by the linker. This avoids failures in creating
1326 subprocesses on Windows 7, see the discussion in this thread:
1327 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1328
b120cc17
JC
13292012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1330
1331 Fix up display of the *Minibuf-0* buffer in the mini window.
1332 * keyboard.c (read_char): Don't clear the echo area if there's no
1333 message to clear.
1334 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1335 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1336
9a4b36f8
MA
13372012-05-07 Michael Albinus <michael.albinus@gmx.de>
1338
1339 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1340 batch mode.
1341
e5f9458f
CY
13422012-05-06 Chong Yidong <cyd@gnu.org>
1343
1344 * lisp.mk (lisp): Update.
1345
eceeb5fc 13462012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1347
1348 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1349
71873e2b
SM
13502012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1351
1352 * data.c (PUT_ERROR): New macro.
1353 (syms_of_data): Use it. Add new error type `user-error'.
1354 * undo.c (user_error): New function.
1355 (Fprimitive_undo): Use it.
1356 * print.c (print_error_message): Adjust print style for `user-error'.
1357 * keyboard.c (user_error): New function.
1358 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1359
ab0fa4e4
PE
13602012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 Do not limit current-time-string to years 1000..9999.
1363 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1364 (Fcurrent_time_string): Support any year that is supported by the
1365 underlying localtime representation. Don't use asctime, as it
1366 has undefined behavior for years outside the range -999..9999.
1367
7ed806a7
PE
13682012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 Fix race conditions involving setenv, gmtime, localtime, asctime.
1371 Without this fix, interrupts could mess up code that uses these
1372 nonreentrant functions, since setting TZ invalidates existing
1373 tm_zone or tzname values, and since most of these functions return
1374 pointers to static storage.
1375 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1376 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1377 Grow the critical sections to include not just invoking
1378 localtime/gmtime, but also accessing these functions' results
1379 including their tm_zone values if any, and any related TZ setting.
1380 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1381 so that the struct tm is saved in the critical section.
1382 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1383 motivated by the fact that memory allocation needs to be outside
1384 the critical section.
1385
0c16dfed
DA
13862012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1387
1388 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1389 with RESET_INTERVAL.
1390
1391 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1392 Remove duplicated buffer name initialization.
1393
3f83ace8
JM
13942012-05-02 Jim Meyering <jim@meyering.net>
1395
1396 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1397
c7b8541e
JM
1398 * xfns.c (x_window): Use xstrdup (Bug#11375).
1399
90207a15 14002012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1401
1402 * xdisp.c (pos_visible_p): If already at a newline from the
1403 display string before the 'while' loop, don't walk back the glyphs
1404 from it3.glyph_row. Solves assertion violation when the display
1405 string begins with a newline (egg.el). (Bug#11367)
1406
b593d6a9
AH
14072012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1408
1409 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1410 Move to simple.el.
1411
4737362e
GM
14122012-05-01 Glenn Morris <rgm@gnu.org>
1413
99cf43f9
GM
1414 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1415 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1416 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1417 All were removed before 23.1.
1418
9311dcff
GM
1419 * dispnew.c: Remove HAVE_LIBNCURSES test;
1420 it is always true on relevant platforms.
1421
4d5c6349
GM
1422 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1423 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1424
4737362e
GM
1425 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1426
74dd3a6b
AS
14272012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1428
1429 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1430 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1431 Remove.
1432
13c379ee
PE
14332012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 Do not avoid creating empty evaporating overlays (Bug#9642).
1436 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1437 That is, do not delete an evaporating overlay if it becomes
1438 empty after its bounds are adjusted to fit within its buffer.
1439 This fix caused other problems, and I'm reverting it until we get
1440 to the bottom of them.
1441
a8e7d6d7 14422012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1443
1444 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1445
a8e7d6d7 14462012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1447
1448 * xdisp.c (pos_visible_p): If the window start position is beyond
1449 ZV, start the display from buffer beginning. Prevents assertion
1450 violation in init_iterator when the minibuffer window is scrolled
1451 via the scroll bar.
1452
1453 * window.c (window_scroll_pixel_based): Likewise.
1454
a8e7d6d7 14552012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1456
1457 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1458
a8e7d6d7 14592012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1460
1461 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1462 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1463
a8e7d6d7 14642012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1465
b593d6a9
AH
1466 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1467 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1468
1c6900d9
EZ
14692012-04-26 Eli Zaretskii <eliz@gnu.org>
1470
4c3fa1d9
EZ
1471 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1472 display element, check also the underlying string or buffer
1473 character. (Bug#11341)
1474
1c6900d9
EZ
1475 * w32menu.c: Include w32heap.h.
1476 (add_menu_item): If the call to AppendMenuW (via
1477 unicode_append_menu) fails, disable Unicode menus only if we are
1478 running on Windows 9X/Me.
1479
42bf8205
AS
14802012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1481
1482 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1483 (xgetint): Add missing shift for LSB tags.
1484
b1bac16e
MR
14852012-04-24 Martin Rudalics <rudalics@gmx.at>
1486
1487 * keyboard.c (read_char): Don't wipe echo area for select window
1488 events: These might get delayed via `mouse-autoselect-window'
1489 (Bug#11304).
1490
d69621cc
JB
14912012-04-24 Juanma Barranquero <lekktu@gmail.com>
1492
1493 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1494 manipulation of :loaded-from data.
1495
02fd101b
JB
14962012-04-23 Juanma Barranquero <lekktu@gmail.com>
1497
1498 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1499 now a cons (bug#11311).
1500
888bec30
PE
15012012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1502
89a438bd
PE
1503 Do not create empty overlays with the evaporate property (Bug#9642).
1504 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1505 if it becomes empty after its bounds are adjusted to fit within
1506 its buffer. Without this fix, in a nonempty buffer (let ((o
1507 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1508 yields an empty overlay that has the evaporate property, which is
1509 not supposed to happen.
1510
1068fe4d
PE
1511 Fix minor GTK3 problems found by static checking.
1512 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1513 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1514 (struct _EmacsFixedClass, emacs_fixed_get_type):
1515 Move decls here from emacsgtkfixed.h, since they needn't be public.
1516 (emacs_fixed_get_type): Now static.
1517 (emacs_fixed_class_init): Omit unused local.
1518 (emacs_fixed_child_type): Remove; unused.
1519 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1520 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1521 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1522 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1523 (EMACS_FIXED_GET_CLASS): Remove; unused.
1524 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1525
888bec30
PE
1526 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1527 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1528
de85e130
PE
15292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1530
d0baac98 1531 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1532 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1533 (__malloc_size_t, __malloc_ptrdiff_t):
1534 Remove. All uses removed, replaced by the definiens if needed,
1535 since we can assume C89 or better now.
1536 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1537 (protect_malloc_state, align, get_contiguous_space)
1538 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1539 (malloc_atfork_handler_child, malloc_enable_thread)
1540 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1541 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1542 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1543 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1544 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1545 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1546 Define using prototypes, not old style.
1547 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1548 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1549 (align): Don't assume that signed integer overflow wraps around.
1550 Omit unused local var.
1551 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1552 (_free_internal_nolock, memalign, mallochook, reallochook):
1553 Omit no-longer-needed casts.
1554 (valloc): Use getpagesize, not __getpagesize.
1555 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1556 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1557
de85e130
PE
1558 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1559
dcbf5805
MA
15602012-04-22 Michael Albinus <michael.albinus@gmx.de>
1561
1562 Move functions from C to Lisp. Make non-blocking method calls
1563 the default. Implement further D-Bus standard interfaces.
1564
1565 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1566 (QCdbus_request_name_allow_replacement)
1567 (QCdbus_request_name_replace_existing)
1568 (QCdbus_request_name_do_not_queue)
1569 (QCdbus_request_name_reply_primary_owner)
1570 (QCdbus_request_name_reply_in_queue)
1571 (QCdbus_request_name_reply_exists)
1572 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1573 (QCdbus_registered_serial, QCdbus_registered_method)
1574 (QCdbus_registered_signal): New Lisp objects.
1575 (XD_DEBUG_MESSAGE): Use sizeof.
1576 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1577 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1578 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1579 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1580 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1581 (xd_signature, xd_append_arg): Allow float for integer types.
1582 (xd_get_connection_references): New function.
b593d6a9
AH
1583 (xd_get_connection_address): Rename from xd_initialize.
1584 Return cached address.
dcbf5805
MA
1585 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1586 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1587 level.
1588 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1589 Return number of refcounts.
dcbf5805
MA
1590 (Fdbus_get_unique_name): Make stronger parameter check.
1591 (Fdbus_message_internal): New defun.
1592 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1593 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1594 (Fdbus_send_signal, Fdbus_register_service)
1595 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1596 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1597 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1598 (Vdbus_compiled_version, Vdbus_runtime_version)
1599 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1600 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1601 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1602 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1603 Adapt docstring.
dcbf5805 1604
52828e02
PE
16052012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1606
da05bc4c
PE
1607 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1608 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1609 Do not assume ptrdiff_t is the same width as 'int'.
1610
52828e02
PE
1611 * alloc.c: Handle unusual debugging option combinations.
1612 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1613 since the two debugging options are incompatible.
1614 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1615 is defined.
1616 (mem_init, mem_insert, mem_insert_fixup):
1617 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1618 (NEED_MEM_INSERT): Remove; no longer needed.
1619
f01769f9
LL
16202012-04-22 Leo Liu <sdl.web@gmail.com>
1621
1622 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1623
5790543d
PE
16242012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 * sysdep.c [__FreeBSD__]: Minor cleanups.
1627 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1628 Use Emacs indenting style more consistently. Avoid some casts.
1629 Use 'double' consistently rather than mixing 'float' and 'double'.
1630
b91b7e4d
EW
16312012-04-21 Eduard Wiebe <usenet@pusto.de>
1632
b593d6a9
AH
1633 * sysdep.c (list_system_processes, system_process_attributes):
1634 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1635
6114eb15
AS
16362012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1637
1638 * lisp.mk (lisp): Update.
1639
2f38dff7
PE
16402012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1641
1642 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1643 It is never used otherwise.
1644
4ae29f89
SM
16452012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1646
1647 * print.c (print_preprocess): Only check print_depth if print-circle
1648 is nil.
1649 (print_object): Check for cycles even when print-circle is nil and
1650 print-gensym is t, but only check print_depth if print-circle is nil.
1651
f30d612a
CY
16522012-04-20 Chong Yidong <cyd@gnu.org>
1653
1654 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1655 set the status to "failed" and ensure that sentinel is run.
1656
c07a4c0b 16572012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1658
1659 * process.c (Fset_process_inherit_coding_system_flag)
1660 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1661 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1662
c07a4c0b 16632012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1664
1665 * xdisp.c (string_buffer_position_lim): Limit starting position to
1666 BEGV.
1667 (set_cursor_from_row): If called for a mode-line or header-line
1668 row, return zero immediately.
1669 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1670 farther than the first row after the header line, if any.
1671 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1672 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1673
c07a4c0b 16742012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1675
4ae29f89
SM
1676 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1677 (bug#11238).
ad3a2b41 1678
c07a4c0b 16792012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 16802012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1681
1682 configure: new option --enable-gcc-warnings (Bug#11207)
1683 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1684 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1685 (ALL_CFLAGS): Use new macros rather than old.
1686 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1687 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1688 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1689 -Wunused-result, -Wunused-variable. This should go away once
1690 the Emacs and Gnulib regex code is merged.
1691 (xmalloc, xrealloc): Now static.
1692
aba027e8
PE
16932012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 * dired.c (Fsystem_groups): Remove unused local.
1696
e5a36063
GM
16972012-04-17 Glenn Morris <rgm@gnu.org>
1698
1699 * dired.c (Fsystem_users): Doc fix.
1700
316411f0
DA
17012012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1702
1703 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1704 (syms_of_dired): Add them.
1705
9426aba4
PE
17062012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1707
b62a57be
PE
1708 Fix minor alloc.c problems found by static checking.
1709 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1710 New extern decls, to avoid calling undeclared functions.
1711 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1712 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1713 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1714 (NEED_MEM_INSERT): New macro.
1715 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1716 Remove one incorrect comment and fix another.
b62a57be 1717
3539f31f
PE
1718 Fix minor ralloc.c problems found by static checking.
1719 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1720 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1721 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1722 (r_alloc_sbrk): Now static.
1723
a041960a
PE
1724 Improve ralloc.c interface checking.
1725 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1726 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1727 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1728 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1729 [REL_ALLOC]: ... to here, to check interface.
1730 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1731 Remove decls. This fixes an "It stinks!".
1732
9426aba4
PE
1733 * alloc.c (which_symbols): Fix alignment issue / type clash.
1734
d55c12ed
AS
17352012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1736
1737 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1738 (struct Lisp_Misc_Any): Likewise.
1739 (struct Lisp_Free): Likewise.
1740 * alloc.c (union aligned_Lisp_Symbol): Define.
1741 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1742 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1743 (union aligned_Lisp_Misc): Define.
1744 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1745 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1746 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1747
b948ce8b
PE
17482012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1751 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1752 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1753 * s/netbsd.h, s/sol2-6.h:
1754 Remove definition of GC_MARK_STACK, since the default now works.
1755 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1756 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1757 no longer the default.
1758 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1759
35dc09a1 17602012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1761
35dc09a1
GM
1762 * lread.c (lisp_file_lexically_bound_p):
1763 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1764
35dc09a1
GM
17652012-04-14 Eli Zaretskii <eliz@gnu.org>
1766
1767 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1768 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1769
17702012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1771
1772 * nsterm.m (constrainFrameRect): Always constrain when there is only
1773 one screen (Bug#10962).
1774
bcd86815
KB
17752012-04-13 Ken Brown <kbrown@cornell.edu>
1776
1777 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1778
c25df26e
RT
17792012-04-13 Reuben Thomas <rrt@sc3d.org>
1780
1781 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1782
0fc59f1e
DC
17832012-04-11 Daniel Colascione <dancol@dancol.org>
1784
1785 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1786 against is gone. It's better to use vfork now so that when Cygwin
1787 gains a new, working vfork, we use it automatically (bug#10398).
1788
de8c03dc
SM
17892012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1790
1791 * window.c (save_window_save): Obey window-point-insertion-type.
1792
2f097256
GM
17932012-04-11 Glenn Morris <rgm@gnu.org>
1794
1795 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1796
453b951e
SM
17972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1798
1799 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1800
75f1671a 18012012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1802
1803 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1804 (force_quit_count): New var.
1805 (handle_interrupt): Use it.
1806
2a8ce227
JB
18072012-04-10 Juanma Barranquero <lekktu@gmail.com>
1808
1809 * w32.c (w32_delayed_load): Record the full path of the library
1810 being loaded (bug#10424).
1811
935396c0
GM
18122012-04-09 Glenn Morris <rgm@gnu.org>
1813
05920a43
GM
1814 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1815 not just in the obarray, before snarfing them. (Bug#11036)
1816
935396c0
GM
1817 * Makefile.in ($(leimdir)/leim-list.el):
1818 Pass EMACS rather than BUILT_EMACS.
1819
a18ecafa
TZ
18202012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1821
1822 * process.c (make_process):
1823 * process.h: Add integer `gnutls_handshakes_tried' member to
1824 process struct.
1825
6bbef4e5
JC
1826 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1827 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1828
1829 * gnutls.c (gnutls_log_function2i): Convenience log function.
1830 (emacs_gnutls_read): Use new log functions,
1831 `gnutls_handshakes_tried' process member, and
1832 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1833 attempts per process (connection).
1834
b4d3bc10
CY
18352012-04-09 Chong Yidong <cyd@gnu.org>
1836
1837 * eval.c (Fuser_variable_p, user_variable_p_eh)
1838 (lisp_indirect_variable): Functions deleted.
1839 (Fdefvar): Caller changed.
1840
1841 * callint.c (Finteractive, Fcall_interactively):
1842 * minibuf.c (Fread_variable): Callers changed.
1843
70f4d973
EZ
18442012-04-09 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (set_cursor_from_row): If the display string appears in
1847 the buffer at position that is closer to point than the position
1848 after the display string, display the cursor on the first glyph of
1849 the display string. Fixes cursor display when a 'display' text
1850 property immediately follows invisible text. (Bug#11094)
1851
cb3c2e3e
PE
18522012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 composite.c: use 'double' consistently
1855 * composite.c (get_composition_id): Use 'double' consistently
1856 instead of converting 'float' to 'double' and vice versa; this is
1857 easier to understand and avoids a GCC warning.
1858
fd06db5d
GM
18592012-04-09 Glenn Morris <rgm@gnu.org>
1860
50fe702a
GM
1861 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1862 preparation for dumping it with emacs. (Bug#4789)
1863 (leimdir): New variable.
1864 ($(leimdir)/leim-list.el): New rule.
1865 (emacs$(EXEEXT)): Depend on leim-list.el.
1866
fd06db5d
GM
1867 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1868 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1869 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1870
55c131ee
AS
18712012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1872
1873 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1874 proper alignment.
1875
9209588f
JB
18762012-04-07 Juanma Barranquero <lekktu@gmail.com>
1877
1878 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1879 Remove unused local variable.
1880
e3fb2efb
PE
18812012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1884 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1885 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1886 objects, as mark_maybe_pointer will catch them otherwise.
1887 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1888 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1889
b5385551
PE
18902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 Fix typo that broke non-Windows builds.
1893 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1894
9078ead6
EZ
18952012-04-07 Eli Zaretskii <eliz@gnu.org>
1896
1897 Support building on MS-Windows with libxml2.
1898
1899 * makefile.w32-in (OBJ2): Add xml.$(O).
1900 (GLOBAL_SOURCES): Add xml.c.
1901 ($(BLD)/xml.$(O)): New dependency list.
1902
1903 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1904 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1905 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1906 [!WINDOWSNT]: New macros.
1907 (init_libxml2_functions, libxml2_loaded_p): New functions.
1908 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1909 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1910 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1911 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1912 linked in).
6bbef4e5
JC
1913 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1914 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1915 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1916
1917 * emacs.c: Don't include libxml/parser.h.
1918 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1919 xmlCleanupParser directly.
1920
1921 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1922
3811fdf3
EZ
19232012-04-07 Eli Zaretskii <eliz@gnu.org>
1924
1925 * indent.c (Fvertical_motion): If there is a display string at
1926 point, use it.vpos to compute how many lines to backtrack after
1927 move_it_to point. (Bug#11133)
1928
2f8e16b2
EZ
19292012-04-06 Eli Zaretskii <eliz@gnu.org>
1930
1931 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1932 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1933 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1934 macros related to unification of CJK characters. For the details,
1935 see the discussion following the message here:
1936 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1937
3d439cd1
CY
19382012-04-04 Chong Yidong <cyd@gnu.org>
1939
1940 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1941
8bc53d00
EZ
19422012-04-01 Eli Zaretskii <eliz@gnu.org>
1943
1944 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1945 instead of alloca. (Bug#11138)
1946
3b0512a3
AS
19472012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1948
1949 * w32menu.c (is_simple_dialog): Properly check lisp types.
1950 (Bug#11141)
1951
8427ddd2
EZ
19522012-03-31 Eli Zaretskii <eliz@gnu.org>
1953
979022ef
EZ
1954 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1955 position we get to after a call to move_it_to fails the
1956 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1957 only if we wind up in a string from display property. (Bug#11063)
1958
a6b1c7cc
EZ
1959 * window.c (Fdelete_other_windows_internal): Invalidate the row
1960 and column information about mouse highlight, so that redisplay
1961 restores it after reallocating the glyph matrices. (Bug#7464)
1962
8427ddd2
EZ
1963 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1964 string comes from a `display' text property, use the buffer
1965 position of that property as if we actually saw that position in
1966 the row's glyphs.
697ba24b
EZ
1967 (move_it_by_lines): Remove the assertion that
1968 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1969 violated when there's a before-string at the beginning of a line.
1970 (Bug#11063)
8427ddd2 1971
65a0a738
EZ
19722012-03-30 Eli Zaretskii <eliz@gnu.org>
1973
1974 * xdisp.c (append_space_for_newline): If the default face was
1975 remapped, use the remapped face for the appended newline.
1976 (extend_face_to_end_of_line): Use the remapped default face for
1977 extending the face to the end of the line.
1978 (display_line): Call extend_face_to_end_of_line when the default
1979 face was remapped. (Bug#11068)
1980
581355cc
EZ
19812012-03-29 Eli Zaretskii <eliz@gnu.org>
1982
1983 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1984
e8fc049f
SM
19852012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1986
1987 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1988
4fb9a543
GM
19892012-03-27 Glenn Morris <rgm@gnu.org>
1990
1991 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1992 Doc fixes.
1993
679910f1
KH
19942012-03-26 Kenichi Handa <handa@m17n.org>
1995
1996 * dispextern.h (struct glyph): Fix previous change. Change the
1997 bit length of glyphless.ch to 25 (Bug#11082).
1998
90d49b7f
CY
19992012-03-26 Chong Yidong <cyd@gnu.org>
2000
2001 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2002 (command_loop_1): Use it; inhibit selection update for
2003 handle-select-window too (Bug#8996).
2004
f514f6f0
FP
20052012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2006
e8fc049f 2007 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2008
bf43fa51
KH
20092012-03-25 Kenichi Handa <handa@m17n.org>
2010
2011 * dispextern.h (struct glyph): Change the bit length of
2012 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2013
8a0c01dd
EZ
20142012-03-24 Eli Zaretskii <eliz@gnu.org>
2015
2016 * s/ms-w32.h (tzname): Include time.h before redirecting to
2017 _tzname. Fixes the MSVC build. (Bug#9960)
2018
7d1c3a76
AS
20192012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2020
8ed79523
AS
2021 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2022 characters.
2023
7d1c3a76
AS
2024 * xterm.c (XTread_socket): Only modify handling_signal if
2025 !SYNC_INPUT. (Bug#11080)
2026
e99a9b8b
EZ
20272012-03-23 Eli Zaretskii <eliz@gnu.org>
2028
2029 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2030 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2031 when fetching a multibyte character consumes more bytes than
2032 CHAR_BYTES returns, due to unification of CJK characters in
2033 string_char. (Bug#11073)
2034
5063c0e1
TN
20352012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2036
2037 * process.c (wait_reading_process_output): Handle pty disconnect
2038 by refraining from sending oneself a SIGCHLD (bug#10933).
2039
9f851fbd
CY
20402012-03-22 Chong Yidong <cyd@gnu.org>
2041
2042 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2043
5063c0e1 2044 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2045 Mark string as coming from a prefix property.
2046 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2047 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2048
fb5b8aca
CY
20492012-03-21 Chong Yidong <cyd@gnu.org>
2050
2051 * xfaces.c (Vface_remapping_alist): Doc fix.
2052
62356a1b
EZ
20532012-03-20 Eli Zaretskii <eliz@gnu.org>
2054
2055 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2056 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2057 Doc fixes.
62356a1b 2058
025de85b
CY
20592012-03-20 Chong Yidong <cyd@gnu.org>
2060
2061 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2062 to reflect default non-nil value of redisplay-dont-pause.
2063
4827f94e
KH
20642012-03-19 Kenichi Handa <handa@m17n.org>
2065
2066 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2067 it fit in a valid range (Bug#11003).
2068
e50a24a2
EZ
20692012-03-18 Eli Zaretskii <eliz@gnu.org>
2070
2071 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2072 that is not from display property, accept the row as a "cursor
2073 row" if one of the string's character has a non-nil `cursor'
2074 property. Fixes cursor positioning when there are newlines in
2075 overlay strings, e.g. in icomplete.el. (Bug#11035)
2076
9af5ed87
PE
20772012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2078
2079 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2080
d1f55f16
CY
20812012-03-12 Chong Yidong <cyd@gnu.org>
2082
2083 * eval.c (inhibit_lisp_code): Rename from
2084 inhibit_window_configuration_change_hook; move from window.c.
2085
2086 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2087 * window.c (run_window_configuration_change_hook)
2088 (syms_of_window): Callers changed.
2089
66c5eebd
CY
20902012-03-11 Chong Yidong <cyd@gnu.org>
2091
413df973
CY
2092 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2093
66c5eebd
CY
2094 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2095
1de11f56
CY
20962012-03-10 Chong Yidong <cyd@gnu.org>
2097
2098 * frame.c (other_visible_frames): Don't assume the selected frame
2099 is visible (Bug#10955).
2100
cae07000
SM
21012012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2102
2103 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2104
89c94350
JD
21052012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2108 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2109 zero (Bug#10954).
2110
999dd333
GM
21112012-03-03 Glenn Morris <rgm@gnu.org>
2112
01a6dcc8 2113 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2114
de0100f2
EZ
21152012-03-02 Eli Zaretskii <eliz@gnu.org>
2116
2117 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2118 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2119 (redisplay_window, next_element_from_string): Fix typos in
2120 comments.
3e441275
EZ
2121 (redisplay_window): Pass to move_it_vertically the margin in
2122 pixels, not in screen lines.
de0100f2 2123
96a72ee9
GM
21242012-03-02 Glenn Morris <rgm@gnu.org>
2125
2126 * buffer.c (buffer-list-update-hook): Doc fix.
2127
312508d7
EZ
21282012-02-29 Eli Zaretskii <eliz@gnu.org>
2129
2130 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2131 push_it before setting up the iterator for the first overlay
2132 string, even if we have an empty string loaded.
2133 (next_overlay_string): If there's an empty string on the iterator
2134 stack, pop the stack. (Bug#10903)
2135
27f3c637
PE
21362012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2139 Suggested by Stefan Monnier in
2140 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2141 * alloc.c (widen_to_Lisp_Object): New static function.
2142 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2143 and widening them to Lisp_Objects. This would work even if
2144 USE_LSB_TAG is defined and wide integers are used, which might
2145 happen in a future version of Emacs.
2146
3c9dfce6
CY
21472012-02-25 Chong Yidong <cyd@gnu.org>
2148
fa74b241
CY
2149 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2150 Doc fix.
2151
3c9dfce6
CY
2152 * xselect.c (Fx_selection_exists_p): Doc fix.
2153 (x_clipboard_manager_save_all): Print an informative message
2154 before saving to clipboard manager.
2155
9486df08
CY
21562012-02-24 Chong Yidong <cyd@gnu.org>
2157
2158 * keyboard.c (process_special_events): Handle all X selection
2159 requests in kbd_buffer, not just the next one (Bug#8869).
2160
f01d3321
CY
21612012-02-23 Chong Yidong <cyd@gnu.org>
2162
2163 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2164 call when setting menu-bar-lines and tool-bar-lines parameters.
2165 (unwind_create_frame_1): New helper function.
2166
2167 * window.c (inhibit_window_configuration_change_hook): New var.
2168 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2169 (syms_of_window): Initialize it.
f01d3321 2170
86b847b6
CY
21712012-02-22 Chong Yidong <cyd@gnu.org>
2172
2173 * xterm.c (x_draw_image_relief): Add missing type check for
2174 Vtool_bar_button_margin (Bug#10743).
2175
a59225b1
CY
21762012-02-21 Chong Yidong <cyd@gnu.org>
2177
2178 * fileio.c (Vfile_name_handler_alist): Doc fix.
2179
2180 * buffer.c (Fget_file_buffer): Protect against invalid file
2181 handler return value.
2182
310f5bd4
PE
21832012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2184
cb3a28cc
PE
2185 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2186 when computing $valmask.
2187
310f5bd4
PE
2188 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2189 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2190 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2191 It's useless in that case, and it can cause problems on hosts
2192 that allocate halves of EMACS_INT values separately.
2193 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2194 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2195 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2196 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2197 it avoids undefined behavior on hosts where shifting right by more
2198 than the word width has undefined behavior.
2199
2375c96a
CY
22002012-02-19 Chong Yidong <cyd@gnu.org>
2201
2202 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2203 (Funhandled_file_name_directory, Ffile_name_as_directory)
2204 (Fdirectory_file_name, Fexpand_file_name)
2205 (Fsubstitute_in_file_name): Protect against invalid file handler
2206 return values (Bug#10845).
2207
3eb49e71
EZ
22082012-02-18 Eli Zaretskii <eliz@gnu.org>
2209
2210 * .gdbinit (pitx): Fix incorrect references to fields of the
2211 iterator stack.
2212
7b926f3f
CY
22132012-02-17 Chong Yidong <cyd@gnu.org>
2214
2215 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2216
11273115
PE
22172012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2220 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2221
c3a70e2b
CY
22222012-02-15 Chong Yidong <cyd@gnu.org>
2223
2224 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2225 marked as special. Also, starting docstrings with * is obsolete.
2226
0ca43699
AS
22272012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2228
2229 * gnutls.c (emacs_gnutls_write): Fix last change.
2230
2e8f3c56
LI
22312012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2232
2233 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2234 send_process.
2235
af70074f
SM
22362012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2237
2238 * keymap.c (Fsingle_key_description): Handle char ranges.
2239
95986d52
CY
22402012-02-12 Chong Yidong <cyd@gnu.org>
2241
afd83bd1
CY
2242 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2243 as that creates a dangerous corner case.
2244
95986d52
CY
2245 * window.c (Fdelete_window_internal): Invalidate the mouse
2246 highlight (Bug#9904).
2247
bd7da63e
GM
22482012-02-12 Glenn Morris <rgm@gnu.org>
2249
2250 * xselect.c (Fx_own_selection_internal)
2251 (Fx_get_selection_internal, Fx_disown_selection_internal)
2252 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2253 * nsselect.m (Fx_own_selection_internal)
2254 (Fx_disown_selection_internal, Fx_selection_exists_p)
2255 (Fx_selection_owner_p, Fx_get_selection_internal):
2256 Sync docs and argument specs with the xselect.c versions.
2257
77abcbc2
LI
22582012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2259
2260 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2261
90b671e2
EZ
22622012-02-11 Eli Zaretskii <eliz@gnu.org>
2263
1c0ca0b7
EZ
2264 * w32select.c (Fx_selection_exists_p): Sync doc string and
2265 argument list with xselect.c. (Bug#10783)
2266
2267 * w16select.c (Fx_selection_exists_p): Sync doc string and
2268 argument list with xselect.c. (Bug#10783)
90b671e2 2269
49241268
GM
22702012-02-10 Glenn Morris <rgm@gnu.org>
2271
2272 * fns.c (Fsecure_hash): Doc fix.
2273
f998bbe7 22742012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2275
2276 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2277
0992bd9c
CY
22782012-02-07 Chong Yidong <cyd@gnu.org>
2279
2280 * buffer.c (Fbuffer_local_variables)
2281 (buffer_lisp_local_variables): Handle unbound vars correctly;
2282 don't let Qunbound leak into Lisp.
2283
af008560
GM
22842012-02-07 Glenn Morris <rgm@gnu.org>
2285
dd605cc4
GM
2286 * image.c (Fimagemagick_types): Doc fix.
2287
af008560
GM
2288 * image.c (imagemagick-render-type): Change it from a lisp object
2289 to an integer. Move the doc here from the lisp manual.
2290 Treat all values not equal to 0 the same.
2291
1449fa1d
CY
22922012-02-06 Chong Yidong <cyd@gnu.org>
2293
2294 * doc.c (store_function_docstring): Avoid applying docstring of
2295 alias to base function (Bug#2603).
2296
3723ec07
AS
22972012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2298
2299 * .gdbinit (pp1, pv1): Remove redundant defines.
2300 (pr): Use pp.
2301
79c1cc1e
CY
23022012-02-04 Chong Yidong <cyd@gnu.org>
2303
2304 * nsterm.m: Declare a global (Bug#10694).
2305
d7f29f8e
EZ
23062012-02-04 Eli Zaretskii <eliz@gnu.org>
2307
cae07000
SM
2308 * w32.c (get_emacs_configuration_options):
2309 Include --enable-checking, if specified, in the return value.
d7f29f8e 2310
3b95a6f9
MR
23112012-02-04 Martin Rudalics <rudalics@gmx.at>
2312
2313 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2314 after rounding frame sizes. (Bug#9723)
2315
d6fa96a6
EZ
23162012-02-04 Eli Zaretskii <eliz@gnu.org>
2317
2318 * keyboard.c (adjust_point_for_property): Don't position point
2319 before BEGV. (Bug#10696)
2320
df0b2940
PE
23212012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 Handle overflow when computing char display width (Bug#9496).
2324 * character.c (char_width): Return EMACS_INT, not int.
2325 (char_width, c_string_width): Check for overflow when
2326 computing the width; this is possible now that individual
2327 characters can have unbounded width. Problem introduced
2328 by merge from Emacs 23 on 2012-01-19.
2329
6bee44d6
MA
23302012-02-02 Michael Albinus <michael.albinus@gmx.de>
2331
2332 * dbusbind.c (Fdbus_register_method): Mention the return value
2333 :ignore in the docstring.
2334
44f92739
GM
23352012-02-02 Glenn Morris <rgm@gnu.org>
2336
1b9f60cc
GM
2337 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2338
44f92739
GM
2339 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2340 Unconditionally set to t. (Bug#10673)
2341 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2342 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2343 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2344
c5d3843c
KH
23452012-02-02 Kenichi Handa <handa@m17n.org>
2346
2347 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2348 0, do not call append_composite_glyph.
2349
159462d4 23502012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2351
2352 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2353 NULL (Bug#6988).
2354 (x_produce_glyphs): If the component of a composition is a null
2355 string, set it->pixel_width to 1 to avoid zero-width glyph.
2356
78cef877
EZ
23572012-02-01 Eli Zaretskii <eliz@gnu.org>
2358
2359 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2360 first 2 arguments are identical. This makes inserting large
2361 output from a subprocess an order of magnitude faster on
2362 MS-Windows, where all sbrk'ed memory is always contiguous.
2363
97897668
GM
23642012-01-31 Glenn Morris <rgm@gnu.org>
2365
2366 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2367 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2368 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2369
31fd3586
GM
23702012-01-29 Glenn Morris <rgm@gnu.org>
2371
2372 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2373
0e24a8b2
CY
23742012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2375
2376 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2377
cc0adcb0
CY
23782012-01-28 Chong Yidong <cyd@gnu.org>
2379
2380 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2381
acc28cb9
CY
23822012-01-26 Chong Yidong <cyd@gnu.org>
2383
9c69cfb7
CY
2384 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2385
acc28cb9
CY
2386 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2387 repeat counts (Bug#10507).
2388
48da7392
GM
23892012-01-26 Glenn Morris <rgm@gnu.org>
2390
2391 * lread.c (syms_of_lread): Doc fix.
2392
14af5f7f
CY
23932012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2394
2395 * coding.c (encode_designation_at_bol): Change return value to
2396 EMACS_INT.
2397
0b21c100
CY
23982012-01-25 Chong Yidong <cyd@gnu.org>
2399
2400 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2401
3c2907f7
CY
24022012-01-21 Chong Yidong <cyd@gnu.org>
2403
2404 * floatfns.c (Fcopysign): Make the second argument non-optional,
2405 since nil is not allowed anyway.
2406
959ad23f
AS
24072012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2408
2409 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2410 (send_process): Likewise.
2411
34a02f46
MR
24122012-01-19 Martin Rudalics <rudalics@gmx.at>
2413
2414 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2415 (Vwindow_persistent_parameters): Do not use Qstate.
2416 Rewrite doc-strings.
34a02f46 2417
1259009a 24182012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2419
2420 * character.c (char_width): New function.
70d4fdf6
GM
2421 (Fchar_width, c_string_width, lisp_string_width):
2422 Use char_width (Bug#9496).
25ed9e61 2423
6a6ee00d
MR
24242012-01-16 Martin Rudalics <rudalics@gmx.at>
2425
2426 * window.c (Vwindow_persistent_parameters): New variable.
2427 (Fset_window_configuration, save_window_save): Handle persistent
2428 window parameters.
2429
c85efaf7
EZ
24302012-01-14 Eli Zaretskii <eliz@gnu.org>
2431
2432 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2433 thrashing the stack of the thread. (Bug#9087)
2434
5944709e
PE
24352012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2438
e71f5d99
EZ
24392012-01-11 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (rows_from_pos_range): Handle the case where the
2442 highlight ends on a newline. (Bug#10464)
2443 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2444 he end column for display of highlight that ends on a newline
2445 before a R2L line.
2446
ce316182
GM
24472012-01-11 Glenn Morris <rgm@gnu.org>
2448
2449 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2450 from load-path also when installation-directory is nil. (Bug#10208)
2451
5b43da69
GM
24522012-01-10 Glenn Morris <rgm@gnu.org>
2453
74cc8ff9
GM
2454 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2455
7d8d6e4e
GM
2456 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2457 Update template values to be closer to their typical values these days.
5b43da69 2458
a0db8d43
EZ
24592012-01-09 Eli Zaretskii <eliz@gnu.org>
2460
2461 * xdisp.c (rows_from_pos_range): Accept additional argument
2462 DISP_STRING, and accept any glyph in a row whose object is that
2463 string as eligible for mouse highlight. Fixes mouse highlight of
2464 display strings from overlays. (Bug#10464)
2465
9a0115ab 24662012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2467
b9110d6a 2468 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2469 * fileio.c (auto_saving_dir_umask): New static var.
2470 (Fmake_directory_internal): Use it.
2471 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2472 creating the directory. The old code temporarily assigns
2473 too-generous permissions to the directory.
2474 (do_auto_save_eh): Clear it.
b9110d6a 2475 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2476 that the var is always cleared.
2477
6c1bd3f3
EZ
24782012-01-07 Eli Zaretskii <eliz@gnu.org>
2479
2480 * search.c (scan_buffer): Pass character positions to
2481 know_region_cache, not byte positions. (Bug#6540)
2482
069d2b50
L
24832012-01-07 LynX <_LynX@bk.ru> (tiny change)
2484
2485 * w32.c (sys_rename): Report EXDEV when rename of a directory
2486 fails because the target is on another logical disk. (Bug#10284)
2487
75bf0d33
DB
24882012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2489
2490 * xterm.c (x_embed_request_focus): New function.
2491
2492 * xterm.h: Add prototype.
2493
2494 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2495
1c6e5a32
GM
24962012-01-05 Glenn Morris <rgm@gnu.org>
2497
2498 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2499
651e947e
EZ
25002012-01-01 Eli Zaretskii <eliz@gnu.org>
2501
2502 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2503 Load gnutls_transport_set_lowat only if GnuTLS version is below
2504 2.11.1.
2505 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2506 GnuTLS versions below 2.11.1.
2507
3778cdd8
AL
25082011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2509
2510 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2511 to the doc string advising against its use for altering the way
2512 windows are scrolled.
2513
0e5317f7
KH
25142011-12-28 Kenichi Handa <handa@m17n.org>
2515
2516 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2517 coding-system ASCII compatible only when it does not produce BOM
2518 on encoding (Bug#10383).
2519
93d5ca1f
JD
25202011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2521
2522 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2523 can scroll.
2524 (create_and_show_popup_menu): Always use menu_position_func for
2525 Gtk3 (Bug#10361).
2526
ca22b785
AS
25272011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2528
2529 * callint.c (Fcall_interactively): Don't truncate prompt string.
2530
d048e1e6
EZ
25312011-12-23 Eli Zaretskii <eliz@gnu.org>
2532
2533 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2534 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2535 resumed from there (after widening). (Bug#10360)
d048e1e6 2536
5ccaba1f
JD
25372011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2538
2539 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2540
204ee57f
JD
25412011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2542
b81d40f0
JB
2543 * nsterm.m (x_free_frame_resources):
2544 Release f->output_data.ns->miniimage.
204ee57f
JD
2545 (ns_index_color): Fix indentation. Do not retain
2546 color_table->colors[i].
2547
2548 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2549 before returning.
2550
2551 * nsfns.m (x_set_background_color): Assign return value from
2552 ns_index_color to face-background instead of NSColor*.
2553 (ns_implicitly_set_icon_type): Fix indentation.
2554 Change assignment in for loop to comparison.
2555
2556 * emacs.c (ns_pool): New variable.
2557 (main): Assign ns_pool.
2558 (Fkill_emacs): Call ns_release_autorelease_pool.
2559
2560 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2561 autorelease fdesc, release fdAttrs and tdict.
2562 (ns_get_covering_families): Release charset.
2563 (ns_findfonts): Release NSFontDescriptor created with new.
2564 (ns_uni_to_glyphs): Fix indentation.
2565 (setString): Release attrStr before assigning new value.
2566
c803b2b7
JD
25672011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2568
678f4426
JD
2569 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2570 and NS_IMPL_COCOA.
2571 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2572 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2573
cd394be1 25742011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2575
5fecd5fc
JD
2576 * nsterm.m (ns_term_init): Subscribe for notifications
2577 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2578 to method trackingNotification in EmacsMenu.
2579
2580 * nsmenu.m (trackingMenu): New variable.
3771cb17 2581 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2582 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2583 from Aquamacs (Bug#7030).
678f4426
JD
2584
25852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2586
c803b2b7
JD
2587 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2588 (symbol_to_nsstring): Fix indentation.
2589 (ns_symbol_to_pb): New function.
cae07000
SM
2590 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2591 (Fns_rotate_cut_buffers_internal): Remove.
2592 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2593 Fns_store_cut_buffer_internal.
2594 (ns_get_foreign_selection, Fx_own_selection_internal)
2595 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2596 (Fns_get_selection_internal, Fns_store_selection_internal):
2597 Use ns_symbol_to_pb and check if return value is nil.
2598 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2599 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2600 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2601 renamed to Sns_store_selection_internal.
2602 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2603 and remove this function.
2604 (ns_handle_selection_clear): Remove, never used.
2605 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2606 here.
2607
e1b01a3a
KB
26082011-12-17 Ken Brown <kbrown@cornell.edu>
2609
2610 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2611 GID is unknown (Bug#10257).
2612
2adb6e85
PE
26132011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2614
2615 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2616 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2617 which caused a build failure on GNU/Linux IA-64. This problem was
2618 introduced by my 2011-10-07 patch.
2619
d1d7b339
JL
26202011-12-15 Juri Linkov <juri@jurta.org>
2621
2622 * image.c (imagemagick_error): New function. (Bug#10112)
2623 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2624 Use `imagemagick_error' where ImageMagick functions return
2625 `MagickFalse'.
2626 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2627 proper order.
2628
100d5755
KH
26292011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2630
2631 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2632 fill background (Bug#8992).
2633
454592a6
MR
26342011-12-13 Martin Rudalics <rudalics@gmx.at>
2635
2636 * window.c (Vwindow_combination_resize)
2637 (Vwindow_combination_limit): Use t instead of non-nil in
2638 doc-strings.
61d4b438
MR
2639 (Vrecenter_redisplay): Add first sentence of doc-string on
2640 separate line.
53524d93 2641 (Frecenter): Fix doc-string typo.
454592a6 2642
3633e3aa
KH
26432011-12-11 Kenichi Handa <handa@m17n.org>
2644
2645 * coding.c (Funencodable_char_position): Pay attention to the
2646 buffer text relocation (Bug#9389).
2647
7b9d523a 26482011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2649
7b9d523a
JD
2650 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2651 gtk_init (Bug#10100).
2652
b73189c6
EZ
26532011-12-10 Eli Zaretskii <eliz@gnu.org>
2654
2655 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2656 IT->string is nil. (Bug#10263)
2657
f7dfe5d6
JD
26582011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2659
83faebb4
JD
2660 * nsterm.h (x_free_frame_resources): Declare.
2661
f7dfe5d6
JD
2662 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2663 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2664
2665 * nsterm.h (ns_get_defaults_value): Declare.
2666
2667 * nsterm.m (ns_default): Call ns_get_defaults_value.
2668
7cd4e72c
EZ
26692011-12-09 Eli Zaretskii <eliz@gnu.org>
2670
2671 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2672 (Bug#10170)
2673
b34d7317
YM
26742011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2675
2676 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2677 that where the value of an _OBJC_* symbol points to is in the .bss
2678 section (Bug#10240).
2679
76470ad1
KH
26802011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2681
2682 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2683 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2684
745fff94
KH
26852011-12-08 Kenichi Handa <handa@m17n.org>
2686
2687 * ftfont.c (get_adstyle_property): Fix previous change
2688 (Bug#10233).
2689
6e44397c
JB
26902011-12-07 Juanma Barranquero <lekktu@gmail.com>
2691
2692 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2693 dirs from the default value of EMACSLOADPATH (bug#10208).
2694
7efa6272
GM
26952011-12-07 Glenn Morris <rgm@gnu.org>
2696
2697 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2698 installation and source directories as well. (Bug#10208)
2699
f6fc4d87
CY
27002011-12-06 Chong Yidong <cyd@gnu.org>
2701
2702 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2703
2bf26180
GM
27042011-12-06 Glenn Morris <rgm@gnu.org>
2705
2706 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2707 as an error, not just -1. (Bug#10217)
2708
3a6ad4f0
CY
27092011-12-05 Chong Yidong <cyd@gnu.org>
2710
2711 * keyboard.c (process_special_events): New function.
2712 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2713
75a3b399
PE
27142011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * coding.c (encode_designation_at_bol): Don't use uninitialized
2717 local variable (Bug#9318).
2718
c3c9e25e
KH
27192011-12-05 Kenichi Handa <handa@m17n.org>
2720
2721 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2722 return Qnil (Bug#8046, Bug#10193).
2723
5eb05ea3
KH
27242011-12-05 Kenichi Handa <handa@m17n.org>
2725
2726 * coding.c (encode_designation_at_bol): New args charbuf_end and
2727 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2728 (coding_set_source): Return how many bytes coding->source was
2729 relocated.
2730 (coding_set_destination): Return how many bytes
2731 coding->destination was relocated.
2732 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2733 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2734
27352011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2736
2737 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2738 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2739 macro (Bug#9318).
2740
27412011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2742
2743 The following changes are to fix Bug#9318.
2744
a79703f5 2745 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2746 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2747 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2748 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2749
7dbda6df
JB
27502011-12-05 Juanma Barranquero <lekktu@gmail.com>
2751
2752 * lisp.h (process_quit_flag): Fix external declaration.
2753
6d5eb5b0
SM
27542011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2755
2756 Don't macro-inline non-performance-critical code.
2757 * eval.c (process_quit_flag): New function.
2758 * lisp.h (QUIT): Use it.
2759
a0c3fad0
JD
27602011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2761
2762 * nsfns.m (get_geometry_from_preferences): New function.
2763 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2764
6c07aac2
AS
27652011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2766
2767 * emacs.c (Qkill_emacs): Define.
2768 (syms_of_emacs): Initialize it.
2769 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2770 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2771 (quit_throw_to_read_char): Add parameter `from_signal'.
2772 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2773 * lisp.h (QUIT): Call Fkill_emacs if requested.
2774
c052ead4
JD
27752011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2776
2777 * widget.c (update_wm_hints): Return if wmshell is null.
2778 (widget_update_wm_size_hints): New function.
2779
2780 * widget.h (widget_update_wm_size_hints): Declare.
2781
2782 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2783 widget_update_wm_size_hints (Bug#10104).
2784
9e49252b
EZ
27852011-12-03 Eli Zaretskii <eliz@gnu.org>
2786
2787 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2788 before a newline, prepare the bidi iterator for consuming the
2789 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2790 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2791
02b16839
JL
27922011-12-02 Juri Linkov <juri@jurta.org>
2793
2794 * search.c (Fword_search_regexp): New Lisp function created from
2795 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2796 (Fword_search_backward, Fword_search_forward)
2797 (Fword_search_backward_lax, Fword_search_forward_lax):
2798 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2799 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2800
0068070e
SM
28012011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2802
2803 * fileio.c (Finsert_file_contents): Move after-change-function call
2804 to before the "handled:" label, since all "goto handled" appear in
2805 cases where the *-change-functions have already been properly called
2806 (bug#10117).
2807
3360a3fc
AS
28082011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2809
2810 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2811 waiting for input. (Bug#10169)
2812
73d6c093
EZ
28132011-11-30 Eli Zaretskii <eliz@gnu.org>
2814
2815 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2816 verifies glyph row's hash code--we have just reallocated the
2817 glyphs, so their contents can be complete garbage. (Bug#10164)
2818
febe6bea
JB
28192011-11-30 Juanma Barranquero <lekktu@gmail.com>
2820
2821 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2822
801a4313
EZ
28232011-11-30 Eli Zaretskii <eliz@gnu.org>
2824
2825 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2826 attributes are tested _before_ calling verify_row_hash, to protect
2827 against GCC re-ordering of the tests. (Bug#10164)
2828
2b56b87e
JD
28292011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2830
2831 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2832
2833 * xterm.c (handle_one_xevent): Only set async_visible and friends
2834 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2835 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2836 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2837
dbf31225
PE
28382011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2841 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2842 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2843 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2844 All uses changed to use GCPRO1 etc.
2845 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2846 Revert to old implementation (i.e., before 2011-03-11).
2847
1305621b
YM
28482011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2849
2850 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2851 of scroll runs so as to avoid assigning disabled bogus rows and
2852 unnecessary graphics copy operations.
2853
8c9afb46
EZ
28542011-11-27 Eli Zaretskii <eliz@gnu.org>
2855
2856 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2857 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2858 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2859 (malloc, free, realloc, calloc): Redirect to e_* only when
2860 compiling Emacs.
2861
2862 * lisp.h (GCTYPEBITS): Move before first use.
2863 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2864 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2865 this macro definition.
2866
2867 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2868 _MSC_VER.
2869
54e9e3bf
JD
28702011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2871
6d5eb5b0
SM
2872 * gtkutil.c (xg_create_frame_widgets):
2873 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2874 present with Gtk+ 2.0.
2875
83aca1cb
PE
28762011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 * fileio.c (Finsert_file_contents): Undo previous change; see
2879 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2880
5b76caa4
PE
28812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 Rename locals to avoid shadowing.
2884 * fileio.c (Finsert_file_contents):
2885 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2886 * process.c (wait_reading_process_output):
2887 Rename inner 'proc' to 'p' to avoid shadowing.
2888 Indent for consistency with usual Emacs style.
2889
8c535114
EZ
28902011-11-25 Eli Zaretskii <eliz@gnu.org>
2891
2892 * xdisp.c (redisplay_window): If cursor row is not fully visible
2893 after recentering, and scroll-conservatively is set to a large
2894 number, scroll window by a few more lines to make the cursor fully
2895 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2896 (start_display): Don't move to the next line if the display should
2897 start at a newline that is part of a display vector or an overlay
2898 string. (Bug#10119)
8c535114 2899
fa4fdb5c
JL
29002011-11-24 Juri Linkov <juri@jurta.org>
2901
2902 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2903 after the `MagickPingImage' call. (Bug#10112)
2904
90ec88df
CY
29052011-11-23 Chong Yidong <cyd@gnu.org>
2906
2907 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2908
56e2e794
MR
29092011-11-23 Martin Rudalics <rudalics@gmx.at>
2910
2911 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2912 making another buffer current. (Bug#10114)
2913
b6e64c41
GM
29142011-11-23 Glenn Morris <rgm@gnu.org>
2915
2916 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2917
6b21de18
CY
29182011-11-23 Chong Yidong <cyd@gnu.org>
2919
2920 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2921 using it (Bug#5984).
2922
b12cd789
EZ
29232011-11-22 Eli Zaretskii <eliz@gnu.org>
2924
2925 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2926 and header-lines, as they don't have one computed for them.
2927 (Bug#10098)
2928
2929 * .gdbinit (prow): Make displayed values more self-explaining.
2930 Add row's hash code.
2931
261b6fd4
LMI
29322011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2933
2934 * process.c (wait_reading_process_output): Fix asynchrounous
2935 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2936 (wait_reading_process_output): Add comment and URL.
261b6fd4 2937
e7cfd277
JD
29382011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2939
2940 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2941
a9b9b7f5
CY
29422011-11-21 Chong Yidong <cyd@gnu.org>
2943
2944 * window.c (Fnext_window, Fprevious_window): Doc fix.
2945
b0d15b4f
SM
29462011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2947
2948 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2949
fe7a3057
JB
29502011-11-20 Juanma Barranquero <lekktu@gmail.com>
2951
2952 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2953
d2999b1a
MR
29542011-11-20 Martin Rudalics <rudalics@gmx.at>
2955
2956 * window.c (Fset_window_combination_limit): Rename argument
2957 STATUS to LIMIT.
2958 (Vwindow_combination_limit): Remove "status" from doc-string.
2959
d5ff9cd0
AS
29602011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2961
2962 * m/ibms390.h: Remove.
2963 * m/ibms390x.h: Don't include "ibms390.h".
2964
a5bb9bd3
SM
29652011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2966
2967 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2968 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2969
cd1181db
JB
29702011-11-20 Juanma Barranquero <lekktu@gmail.com>
2971
2972 * casetab.c (Fset_case_table):
2973 * charset.c (Fcharset_after): Fix typos.
2974
615a3b8d 29752011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2976
17e845af
PE
2977 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2978 Otherwise, valgrind does not work on some platforms.
2979 Problem reported by Andreas Schwab in
6a0bf43d
PE
2980 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2981 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2982 is set, removing the need for VIRT_ADDRESS_VARIES.
2983 (PURE_P): Use a more-efficient implementation that needs just one
2984 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2985 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2986 to 4 (xorl, subq, cmpq, setbe).
2987 * alloc.c (pure): Always extern now, since that's the
2988 VIRT_ADDR_VARIES behavior.
2989 (PURE_POINTER_P): Use a single comparison, not two, for
2990 consistency with the new puresize.h.
2991 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2992 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2993 Remove VIRT_ADDR_VARIES no longer needed.
2994
f8fe6f96
EZ
29952011-11-19 Eli Zaretskii <eliz@gnu.org>
2996
2997 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2998 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2999 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3000 behave as if the cursor position were at the window margin.
3001
3002 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3003 and the cursor position is out of bounds, behave as if the cursor
3004 position were at the window margin. (Bug#10075)
3005
df05a53c
CY
30062011-11-18 Chong Yidong <cyd@gnu.org>
3007
3008 * window.c (Fwindow_combination_limit): Make first argument
3009 non-optional, since it is meaningless for live windows like the
3010 selected window.
61ccba97 3011
2071918e
DA
30122011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3013
3014 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3015
b50a28de
SM
30162011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3017
3018 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3019 (graft_intervals_into_buffer): Simplify.
3020
015137db
EZ
30212011-11-18 Eli Zaretskii <eliz@gnu.org>
3022
3023 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3024 hash values of the two rows.
3025 (copy_row_except_pointers): Preserve the used[] arrays and the
3026 hash values of the two rows. (Bug#10035)
68c95424 3027 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3028
3029 * xdisp.c (row_hash): New function, body extracted from
3030 compute_line_metrics.
3031 (compute_line_metrics): Call row_hash, instead of computing the
3032 hash code inline.
3033
3034 * dispnew.c (verify_row_hash): Call row_hash for computing the
3035 hash code of a row, instead of duplicating code from xdisp.c.
3036
3037 * dispextern.h (row_hash): Add prototype.
3038
a2addb04
TH
30392011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3040
3041 * frame.c (delete_frame): Don't delete the terminal when the last
3042 X frame is closed if emacs is built with GTK toolkit.
3043
df85d315
JB
30442011-11-17 Juanma Barranquero <lekktu@gmail.com>
3045
3046 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3047
a0c2d0ae
MR
30482011-11-17 Martin Rudalics <rudalics@gmx.at>
3049
3050 * window.c (Vwindow_splits): Rename to
3051 Vwindow_combination_resize. Suggested by Juri Linkov.
3052 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3053 of Vwindow_splits.
3054
58179cce
JB
30552011-11-16 Juanma Barranquero <lekktu@gmail.com>
3056
7877f373
JB
3057 * nsfns.m (Fns_font_name):
3058 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3059
b6f67890
MR
30602011-11-16 Martin Rudalics <rudalics@gmx.at>
3061
3062 * window.h (window): Rename slot "nest" to "combination_limit".
3063 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3064 (Fset_window_nest): Rename to Fset_window_combination_limit.
3065 (Vwindow_nest): Rename to Vwindow_combination_limit.
3066 (recombine_windows, make_parent_window, make_window)
3067 (Fsplit_window_internal, saved_window)
3068 (Fset_window_configuration, save_window_save): Rename all
3069 occurrences of window_nest to window_combination_limit.
3070
c7015153
JB
30712011-11-15 Juanma Barranquero <lekktu@gmail.com>
3072
3073 * image.c (imagemagick_load_image): Fix typo.
3074
322ad6ec
EZ
30752011-11-14 Eli Zaretskii <eliz@gnu.org>
3076
3077 * xdisp.c (display_line): Move the call to
3078 highlight_trailing_whitespace before the call to
3079 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3080 faces of all the glyphs to compute ROW's hash value.
3081 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3082
f067b8ec
JB
30832011-11-14 Juanma Barranquero <lekktu@gmail.com>
3084
3085 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3086 just return (bug#10044).
3087
1e5b2111
EZ
30882011-11-12 Eli Zaretskii <eliz@gnu.org>
3089
7ef3cbd5
EZ
3090 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3091 with user-defined heap size. Bump the default size of the temacs
3092 heap to 27MB, to avoid memory warning when running temacs.
3093 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3094
1e5b2111
EZ
3095 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3096 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3097 (verify_row_hash) [XASSERTS]: New function.
3098 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3099 that the hash value of glyph rows is correct.
1e5b2111 3100
89d61221
MR
31012011-11-12 Martin Rudalics <rudalics@gmx.at>
3102
3103 * window.h (window): Remove splits slot.
3104 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3105 (Fdelete_other_windows_internal, make_parent_window)
3106 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3107 (Fset_window_configuration, save_window_save): Don't deal with
3108 split status of windows.
3109 (saved_window): Remove splits slot.
3110 (Vwindow_splits): Rewrite doc-string.
3111
97f18cc8
JD
31122011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3113
3114 * xfns.c (unwind_create_frame):
3115 * nsfns.m (unwind_create_frame):
3116 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3117 Vframe_list (Bug#9999).
3118
22a648b4
DA
31192011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3120
0b381c7e 3121 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3122
659afede
KH
31232011-11-11 Kenichi Handa <handa@m17n.org>
3124
3125 * callproc.c (Fcall_process): Set the member dst_multibyte of
3126 process_coding.
3127
9ac0394b
KH
31282011-11-11 Johan Bockgård <bojohan@gnu.org>
3129
3130 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3131 avoid a crash (bug#9496).
3132
2fbdc249
CY
31332011-11-09 Chong Yidong <cyd@gnu.org>
3134
3135 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3136 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3137
ac6b1f81
PE
31382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3141
09db192c
PE
31422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3143
3144 Avoid some portability problems by eschewing 'extern inline' functions.
3145 The trivial performance wins aren't worth the portability hassles; see
3146 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3147 et seq.
3148 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3149 (window_box_width, window_box_left, window_box_left_offset)
3150 (window_box_right, window_box_right_offset): Undo previous change,
3151 by removing the "extern"s.
3152 * intervals.c (adjust_intervals_for_insertion)
3153 (adjust_intervals_for_deletion): Undo previous change,
3154 making these static again.
3155 (offset_intervals, temp_set_point_both, temp_set_point)
3156 (copy_intervals_to_string): No longer inline.
3157 * xdisp.c (window_text_bottom_y, window_box_width)
3158 (window_box_height, window_box_left_offset)
3159 (window_box_right_offset, window_box_left, window_box_right)
3160 (window_box): No longer inline.
3161
105216ed
CY
31622011-11-08 Chong Yidong <cyd@gnu.org>
3163
3164 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3165 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3166 Signal an error if not a live window.
105216ed
CY
3167 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3168 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3169
ae9e237f
JB
31702011-11-07 Juanma Barranquero <lekktu@gmail.com>
3171
3172 * lisp.h (syms_of_abbrev): Remove declaration.
3173 Reported by CHENG Gao <chenggao@royau.me>.
3174
c7aa8333
EZ
31752011-11-07 Eli Zaretskii <eliz@gnu.org>
3176
3177 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3178 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3179 of temacs in GUI mode.
3180
be7f5545
MR
31812011-11-07 Martin Rudalics <rudalics@gmx.at>
3182
3183 * window.h: Declare delete_all_child_windows instead of
3184 delete_all_subwindows.
3185 * window.c (Fwindow_nest, Fset_window_nest)
3186 (Fset_window_new_total, Fset_window_new_normal)
3187 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3188 (delete_all_subwindows): Rename to delete_all_child_windows.
3189 (Fdelete_other_windows_internal, Fset_window_configuration):
3190 Call delete_all_child_windows instead of delete_all_subwindows.
3191 * frame.c (delete_frame): Call delete_all_child_windows instead
3192 of delete_all_subwindows.
3193
ca78dc43
PE
31942011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3197 This is also needed for porting to any host where GC_MARK_STACK is
3198 not GC_MAKE_GCPROS_NOOPS.
3199 (which_symbols): Use it.
3200
a0241d01
KH
32012011-11-07 Kenichi Handa <handa@m17n.org>
3202
3203 * coding.c (coding_set_destination): Check coding->src_pos only
3204 when coding->src_object is a buffer (bug#9910).
3205
3206 * process.c (send_process): Set the member src_multibyte of coding
3207 to 0 (bug#9911) when sending a unibyte text.
3208
3209 * callproc.c (Fcall_process): Set the member src_multibyte of
3210 process_coding to 0 (bug#9912).
3211
a64bfdfa 32122011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3213
3214 * xmenu.c (cleanup_widget_value_tree): New function.
3215 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3216 calling free_menubar_widget_value_tree directly (Bug#9830).
3217
cb41b32a
PE
32182011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 Fix some portability problems with 'inline'.
3221 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3222 (window_box_width, window_box_left, window_box_left_offset)
3223 (window_box_right, window_box_right_offset): Declare extern.
3224 Otherwise, these inline functions do not conform to C99 and
3225 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3226 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3227 * intervals.c (adjust_intervals_for_insertion)
3228 (adjust_intervals_for_deletion): Now extern, because otherwise the
3229 extern inline functions 'offset_intervals' couldn't refer to it.
3230 (static_offset_intervals): Remove.
3231 (offset_intervals): Rewrite using the old contents of
3232 static_offset_intervals. The old version didn't conform to C99
3233 because an extern inline function contained a reference to an
3234 identifier with static linkage.
3235
b7041366
AS
32362011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3237
3238 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3239 GC.
3240
88a37c4d
EZ
32412011-11-06 Eli Zaretskii <eliz@gnu.org>
3242
3243 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3244 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3245 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3246 return Qleft_to_right.
3247
49745b39
CY
32482011-11-06 Chong Yidong <cyd@gnu.org>
3249
3250 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3251 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3252 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3253 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3254 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3255 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3256 (Fwindow_vscroll): Doc fix.
3257 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3258 argument, since it makes no sense to pass a live window and for
3259 consistency with window-child.
3260
1f05cd82
CS
32612011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3262
3263 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3264 support MSVC.
3265
22610910
JR
32662011-11-05 Jason Rumney <jasonr@gnu.org>
3267
3268 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3269 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3270 fonts (Bug#6029).
3271 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3272 bitwise arithmetic preventing use of unicode-sip and non-truetype
3273 opentype fonts.
3274
a06776b2
EZ
32752011-11-05 Eli Zaretskii <eliz@gnu.org>
3276
3ad924ba
EZ
3277 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3278 "emacs"-only part.
3279
a06776b2
EZ
3280 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3281 initialization code to keep similarity to xfns.c after changes
3282 from 2011-11-05.
3283
c9e7db78
JD
32842011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3285
a97f8f3f
JD
3286 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3287 (unwind_create_frame): New function (Bug#9943).
3288 (Fx_create_frame): Restructure code to be more similar to the one in
3289 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3290 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3291 Move terminal->reference_count++ just before making the frame official
3292 (Bug#9943).
3293
3294 * nsterm.m (x_free_frame_resources): New function.
3295 (x_destroy_window): Move code to x_free_frame_resources.
3296
c9e7db78 3297 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3298 (Fx_create_frame, x_create_tip_frame):
3299 Move terminal->reference_count++ just before making the frame
75f1671a 3300 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3301 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3302
a6fc3b5c
EZ
33032011-11-05 Eli Zaretskii <eliz@gnu.org>
3304
3305 Support MSVC build with newer versions of Visual Studio.
3306 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3307 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3308 nt/gmake.defs.
3309
3310 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3311 which are not supported by MSVC.
3312 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3313 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3314 bitfields.
3315 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3316 types in bitfields.
3317 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3318
3319 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3320
58179cce 33212011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3322
3323 Support MSVC build with newer versions of Visual Studio.
3324 * w32.c: Don't include w32api.h for MSVC.
3325 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3326
3327 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3328 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3329 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3330 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3331 e_* cousins.
3332 (alloca) [_MSC_VER]: Define to _alloca.
3333
3334 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3335
3336 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3337
a58c13ed
EZ
33382011-11-04 Eli Zaretskii <eliz@gnu.org>
3339
3340 * xdisp.c (note_mouse_highlight): If either of
3341 previous/next-single-property-change returns nil, treat that as
3342 the beginning or the end of the buffer. (Bug#9955)
3343
fe0b6370
JD
33442011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3345
a58c13ed 3346 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3347 label is not null (Bug#9951).
3348 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3349 may be NULL.
3350
89bd5ee1
EZ
33512011-11-04 Eli Zaretskii <eliz@gnu.org>
3352
3353 * window.c (Fwindow_body_size): Mention in the doc string that the
3354 return value is in frame's canonical units. (Bug#9949)
3355
84c3edb9
EZ
33562011-11-03 Eli Zaretskii <eliz@gnu.org>
3357
4e2fb5c7
EZ
3358 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3359
84c3edb9 3360 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3361 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3362 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3363
bc17a887
EZ
33642011-11-01 Eli Zaretskii <eliz@gnu.org>
3365
3366 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3367 Don't stop backward scan on the continuation glyph, even though
3368 its CHARPOS is positive.
6d5eb5b0
SM
3369 (mouse_face_from_buffer_pos, note_mouse_highlight):
3370 Rename cover_string to disp_string.
bc17a887 3371
4ee88440
MR
33722011-11-01 Martin Rudalics <rudalics@gmx.at>
3373
3374 * window.c (temp_output_buffer_show): Don't use
3375 Vtemp_buffer_show_specifiers.
3376 (Vtemp_buffer_show_specifiers): Remove unused variable.
3377
c2ff3c02
EZ
33782011-10-30 Eli Zaretskii <eliz@gnu.org>
3379
3380 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3381 past the beginning of the current glyph matrix.
3382
58179cce 33832011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3384
3385 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3386 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3387 HAVE_GTK3 (Bug#9869).
b77a6a7f 3388
3b574623
JD
3389 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3390 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3391
b77a6a7f
JD
3392 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3393
3394 * xterm.c: Declare x_handle_net_wm_state to return int.
3395 (handle_one_xevent): Check if we are iconified but don't have
3396 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3397 (get_current_wm_state): Return non-zero if not hidden,
3398 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3399 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3400 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3401 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3402
196e41e4
PE
34032011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3406 so that this new function doesn't get optimized away by a
3407 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3408
021f2e1a
AS
34092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3410
3411 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3412
8b058d44
EZ
34132011-10-29 Eli Zaretskii <eliz@gnu.org>
3414
3415 Fix the `xbytecode' command.
3416 * .gdbinit (xprintbytestr): New command.
b50a28de 3417 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3418 (xbytecode): Print the byte-code string as well.
3419
4452fb80
EZ
34202011-10-29 Kim Storm <storm@cua.dk>
3421
8b058d44
EZ
3422 * alloc.c (which_symbols): New function.
3423
21b72067
AS
34242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3425
3426 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3427 line. (Bug#9903)
3428
83ed7b5c
GM
34292011-10-29 Glenn Morris <rgm@gnu.org>
3430
3431 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3432 Not clear what it was for, and it causes various bugs. (Bug#9839)
3433
5a7a728b
EZ
34342011-10-28 Eli Zaretskii <eliz@gnu.org>
3435
3436 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3437 possible random value that matches one of those tested as
3438 condition to clear the mouse face.
3439
d3d0842f
CY
34402011-10-28 Chong Yidong <cyd@gnu.org>
3441
3442 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3443
31b39d13
DN
34442011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3445
3446 * window.c (make_window): Initialize phys_cursor_on_p.
3447
9aba6043
SM
34482011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3449
3450 * lisp.h (struct Lisp_Symbol): Update comments.
3451
c20992f4
JB
34522011-10-28 Juanma Barranquero <lekktu@gmail.com>
3453
3454 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3455
db4f02f2
EZ
34562011-10-28 Eli Zaretskii <eliz@gnu.org>
3457
3458 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3459 <oslsachem@gmail.com> for helping to debug this.
3460
3461 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3462 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3463 (g_b_init_get_glyph_outline_w): New static variables.
3464 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3465 (GetGlyphOutlineW_Proc): New typedefs.
3466 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3467 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3468 New functions.
3469 (w32font_open_internal, compute_metrics):
3470 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3471 instead of calling the "wide" APIs directly.
3472
3473 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3474
3475 * w32.h (syms_of_w32font): Add prototype.
3476
87e68db4
JB
34772011-10-27 Juanma Barranquero <lekktu@gmail.com>
3478
3479 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3480 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3481 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3482 (Fmove_to_window_line): Doc fix.
3483
435c1d67
CY
34842011-10-27 Chong Yidong <cyd@gnu.org>
3485
3486 * process.c (make_process): Set gnutls_state to NULL.
3487
3488 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3489 non-NULL, regardless of GNUTLS_INITSTAGE.
3490 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3491 an error. Set process slots as soon as we allocate them.
3492
3493 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3494
9c6c6f49
CY
34952011-10-27 Chong Yidong <cyd@gnu.org>
3496
9aba6043
SM
3497 * gnutls.c (emacs_gnutls_deinit): New function.
3498 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3499 (Fgnutls_deinit, Fgnutls_boot): Use it.
3500
3501 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3502 (deactivate_process): Call emacs_gnutls_deinit.
3503
657d08d3
JB
35042011-10-27 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * image.c (x_create_x_image_and_pixmap):
3507 * w32.c (sys_rename, w32_delayed_load):
3508 * w32font.c (fill_in_logfont):
3509 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3510
5430d399
JB
35112011-10-26 Juanma Barranquero <lekktu@gmail.com>
3512
3513 * w32fns.c (w32_default_color_map): New function,
3514 extracted from Fw32_default_color_map.
a7ef684b 3515 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3516
fe0055fa
PE
35172011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3520
e6346438
SM
35212011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3522
3523 * keyboard.c (test_undefined): New function (bug#9751).
3524 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3525
e112cc37
ET
35262011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3527
3528 * sysdep.c (init_sys_modes): Fix the check for the controlling
3529 terminal (Bug#6649).
3530
7b5d6677
EZ
35312011-10-20 Eli Zaretskii <eliz@gnu.org>
3532
3533 * dispextern.h (struct bidi_it): New member next_en_type.
3534
3535 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3536 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3537 current character, check also for next_en_type being WEAK_EN.
3538 (bidi_resolve_weak): Don't enter the expensive loop if the current
3539 position is before next_en_pos. Record the bidi type of the first
3540 non-ET, non-BN character we find, in addition to its position.
3541 (bidi_level_of_next_char): Invalidate next_en_type when
3542 next_en_pos is over-stepped.
3543
7da0b018
PE
35442011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3547 * editfns.c: Rewrite current-time-zone so that it invokes
3548 the equivalent of (format-time-string "%Z") to get the time zone name.
3549 This fixes a bug when the time zone name contains characters that
3550 need converting from the system time locale to Emacs internal format.
3551 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3552 that patch fixed format-time-string to do the conversion, but
3553 I forgot to fix current-time-zone.
3554 (format_time_string): New function, containing most of
3555 what Fformat_time_string used to contain.
3556 (Fformat_time_string): Rewrite in terms of format_time_string.
3557 This doesn't change this function's behavior.
3558 (current-time-zone): Rewrite to use format_time_string.
3559 This fixes the bug reported by Michael Schierl in
3560 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3561 Jason Rumney's 2007-06-07 change worked around this bug, but
3562 didn't fix it.
3563 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3564
8547b010
EZ
35652011-10-19 Eli Zaretskii <eliz@gnu.org>
3566
3567 * xdisp.c (start_display): If the character at POS is displayed
3568 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3569 (try_window_reusing_current_matrix): If a line ends in a display
3570 vector or the next line starts in a display vector, continue
3571 redrawing the window even though the character position of
3572 start_row was reached.
8547b010
EZ
3573 (Bug#9771, part 2)
3574
4e948d15
CY
35752011-10-18 Chong Yidong <cyd@gnu.org>
3576
3577 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3578 with nobreak-char-display too.
3579
4787455f
EZ
35802011-10-18 Eli Zaretskii <eliz@gnu.org>
3581
3582 Fix part 3 of bug#9771.
3583 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3584 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3585 non-neutral characters if the current character is a paragraph
3586 separator (a.k.a. Newline). This avoids running the same
3587 expensive loop twice, once when we consume the preceding newline
3588 and the other time when the line actually needs to be displayed.
3589 Avoid the loop when we see neutrals on the base embedding level
3590 following a character whose directionality is the same as the
3591 paragraph's. This avoids running the expensive loop when a line
3592 ends in a long sequence of neutrals, like control characters.
3593 Add assertion against STRONG_AL type. Slightly rearrange code
3594 that determines the type of a neutral given the first non-neutral
3595 that follows it.
3596 (bidi_level_of_next_char): Set next_en_pos to zero when
3597 invalidating its info.
3598
2c91f553
EZ
35992011-10-17 Eli Zaretskii <eliz@gnu.org>
3600
3601 * xdisp.c (push_display_prop): Determine whether to record string
3602 or buffer position by IT->string, not by IT->method. Allow
3603 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3604 (move_it_vertically_backward): Don't look for character position
3605 immediately after the newline when in a continuation line.
3606 (Bug#9771, part 1)
2c91f553 3607
c7b08b0d
MR
36082011-10-15 Martin Rudalics <rudalics@gmx.at>
3609
3610 * window.c (coordinates_in_window): Rewrite and delabelize
3611 vertical border check. (Bug#5357) (Bug#9618)
3612
6b02f655
SM
36132011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3614
3615 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3616 errors in XSetWindowBorder (bug#9310).
3617
81d40c92
DA
36182011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3619
3620 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3621 avoid crash when xmalloc overrun checking is enabled.
3622
d4172c3b
EZ
36232011-10-13 Eli Zaretskii <eliz@gnu.org>
3624
3625 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3626 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3627 cursor motion with <left> and <right> arrow keys.
3628
3629 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3630 some callers set that themselves.
3631
b00eea75
EZ
36322011-10-12 Eli Zaretskii <eliz@gnu.org>
3633
3634 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3635 display string and the previous row comes from the same string and
3636 is empty. (Bug#9739) (Bug#9738)
3637
8fe012c4
SM
36382011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3639
3640 * doc.c (get_doc_string): Encode file name (bug#9735).
3641
0074aef2
EZ
36422011-10-12 Eli Zaretskii <eliz@gnu.org>
3643
79beb178
EZ
3644 * bidi.c (bidi_level_of_next_char):
3645 * xdisp.c (get_visually_first_element): Remove old incorrect
3646 comments regarding the Unicode Line Separator character.
3647
0074aef2
EZ
3648 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3649
6e4b3fbe
DA
36502011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3651
3652 * alloc.c (Fgc_status): Do not access beyond zombies array
3653 boundary if nzombies > MAX_ZOMBIES.
3654 * alloc.c (dump_zombies): Add missing format specifier.
3655
0324f3af
PE
36562011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3657
b5525cac
PE
3658 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3659 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3660
0324f3af
PE
3661 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3662 Some packages use them to denote characters with modifiers.
3663
e9b5f888
AS
36642011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3665
3666 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3667 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3668 matching a pp-number. Rename parameter var to var1.
3669
127827c0
SM
36702011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3671
3672 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3673
c8fd3bd0
GM
36742011-10-08 Glenn Morris <rgm@gnu.org>
3675
3676 * callint.c (Fcall_interactively): Give a more explicit error for the
3677 'c' case with a non-character input. (Bug#8479)
3678
352ec8ff
EZ
36792011-10-08 Eli Zaretskii <eliz@gnu.org>
3680
03669ccb
EZ
3681 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3682 lines.
7061c986
EZ
3683 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3684 lines that are hscrolled on the left.
03669ccb 3685
352ec8ff
EZ
3686 * dispnew.c (buffer_posn_from_coords): Account for a possible
3687 presence of header-line. (Bug#4426)
3688
a66cfb1c
SM
36892011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3690
6b02f655
SM
3691 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3692 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3693
7c5ee88e
PE
36942011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3697 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3698 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3699 this makes Emacs dump core during garbage collection on rare
3700 occasions. sizeof is obviously inferior to offsetof here, so
3701 stick with offsetof.
3702 (GC_POINTER_ALIGNMENT): New macro.
3703 (mark_memory): Omit 3rd (offset) arg; caller changed.
3704 Don't assume EMACS_INT alignment is the same as pointer alignment.
3705
df1bbe5b
SM
37062011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3707
3708 * keyboard.c (read_key_sequence_remapped): New var.
3709 (read_key_sequence): Compute remapping in the right buffer.
3710 (command_loop_1): Use read_key_sequence's remapping directly.
3711
51553db6
SM
37122011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3713
32c1fffd
SM
3714 * dired.c (file_name_completion): Don't expand file name.
3715 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3716 before checking file name handler.
3717
51553db6
SM
3718 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3719 they've been requested explicitly (bug#9591).
3720
b6bd1599 37212011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3722
3723 * keymap.c (Fsingle_key_description): Use make_specified_string
3724 instead of build_string to build string from push_key_description.
3725 (Bug#5193)
3726
f701dc2a
PE
37272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3728
4222c55d
PE
3729 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3730 This fixes a Y2038 bug on 64-bit hosts.
3731 * buffer.c (reset_buffer):
3732 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3733 (Fclear_buffer_auto_save_failure):
3734 Use 0, not -1, to represent an unset failure time, since time_t
3735 might not be signed.
3736
f701dc2a
PE
3737 Remove dependency on glibc malloc internals.
3738 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3739 Move back here from lisp.h, but with their new implementations.
3740 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3741 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3742 * charset.c (charset_table_init): New static var.
3743 (syms_of_charset): Use it instead of xmalloc. This removes a
3744 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3745 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3746 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3747 Move back to alloc.c.
3748 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3749 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3750
9ceebf39
JD
37512011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3752
3753 * nsterm.m (windowDidResize): Call x_set_window_size only when
3754 ns_in_resize is true. Otherwise set pixelwidth/height and
3755 call change_frame_size (Bug#9628).
3756
cb993c58
PE
37572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3758
3930c88b
PE
3759 Port --enable-checking=all to Fedora 14 x86-64.
3760 * charset.c (syms_of_charset): Also account for glibc malloc's
3761 internal overhead when calculating the initial malloc maximum.
3762
cb993c58
PE
3763 Port --enable-checking=all to Fedora 14 x86.
3764 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3765 Move to lisp.h.
3766 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3767 (overrun_check_realloc, overrun_check_free):
3768 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3769 That way, xmalloc returns a properly-aligned pointer even if
3770 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3771 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3772 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3773 into account when calculating the initial malloc maximum.
3774 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3775 Move here from alloc.c, so that charset.c can use it too.
3776 Properly align; the old code wasn't right for common 32-bit hosts
3777 when configured with --enable-checking=all.
3778 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3779 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3780
31bed486
EZ
37812011-09-29 Eli Zaretskii <eliz@gnu.org>
3782
04c70788 3783 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3784 use EDOM.
3785
fbcaa2f3
EZ
37862011-09-28 Eli Zaretskii <eliz@gnu.org>
3787
3788 * xdisp.c (compute_display_string_end): If there's no display
3789 string at CHARPOS, return -1.
3790
3791 * bidi.c (bidi_fetch_char): When compute_display_string_end
3792 returns a negative value, treat the character as a normal
3793 character not covered by a display string. (Bug#9624)
3794
a239d4e9
JB
37952011-09-28 Juanma Barranquero <lekktu@gmail.com>
3796
3797 * lread.c (Fread_from_string): Fix typo in docstring.
3798
88652fd5
EZ
37992011-09-27 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3802 newline, reseat the iterator instead of bidi-iterating there one
3803 character at a time. (Bug#9610)
32c1fffd
SM
3804 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3805 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3806
ed497dd4
AS
38072011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3808
3809 * lread.c (readevalloop): Use correct code for NBSP.
3810 (read1): Likewise. (Bug#9608)
3811
b2bf61aa
MA
38122011-09-25 Michael Albinus <michael.albinus@gmx.de>
3813
3814 * dbusbind.c (Fdbus_register_signal): When service is not
3815 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3816
32bbb17c
GM
38172011-09-25 Glenn Morris <rgm@gnu.org>
3818
3819 * buffer.c (truncate-lines): Doc fix.
3820
94e0933e
CY
38212011-09-24 Chong Yidong <cyd@stupidchicken.com>
3822
3823 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3824 (Fset_window_next_buffers): Doc fix.
3825
cddde921
GM
38262011-09-24 Glenn Morris <rgm@gnu.org>
3827
3828 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3829
1260aef1
PE
38302011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3831
25b4bfa0
PE
3832 Fix minor problems found by static checking.
3833 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3834 * indent.c (Fvertical_motion): Fix == vs = typo.
3835
e3cbd34b
EZ
38362011-09-24 Eli Zaretskii <eliz@gnu.org>
3837
a66cfb1c
SM
3838 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3839 Default value is now t. Doc fix.
6bf7006f 3840
e3cbd34b 3841 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3842 logic when moving up, not only when moving down. Fix the
e3cbd34b 3843 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3844 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3845
3846 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3847 CHARPOS is covered by a display string which includes newlines.
3848 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3849 is covered by a display string with embedded newlines.
3850
a3de0cbd
MA
38512011-09-24 Michael Albinus <michael.albinus@gmx.de>
3852
3853 * dbusbind.c (Fdbus_register_signal): Add match rule to
3854 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3855 (Fdbus_register_method, Vdbus_registered_objects_table):
3856 Fix docstring.
a3de0cbd 3857
b260039d
JM
38582011-09-24 Jim Meyering <meyering@redhat.com>
3859
32c1fffd 3860 do not ignore write error for any output size
b260039d
JM
3861 The previous change was incomplete.
3862 While it makes emacs --batch detect the vast majority of stdout
3863 write failures, errors were still ignored whenever the output size is
3864 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3865 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3866 && echo FAIL: ignored write error
3867 FAIL: ignored write error
3868 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3869 && echo FAIL: ignored write error
3870 FAIL: ignored write error
3871 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3872
8eca8a7c
AS
38732011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3874
3875 * emacs.c (Fkill_emacs): In noninteractive mode exit
3876 non-successfully if a write error occurred on stdout. (Bug#9574)
3877
3341db62
EZ
38782011-09-21 Eli Zaretskii <eliz@gnu.org>
3879
3880 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3881 the xassert test.
3882
3883 * dispextern.h (struct it): Update the comment documenting what
3884 can it->OBJECT be.
3885
8c203dbf
EZ
38862011-09-20 Eli Zaretskii <eliz@gnu.org>
3887
3888 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3889 a display string, extend search for cursor position to end of row.
3890 (find_row_edges): If the row ends in a newline from a display
3891 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3892 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3893 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3894 non-empty line. Fixes confusing cursor motion with arrow keys at
3895 the beginning of a line that starts with whitespace.
8c203dbf 3896
a4824228
LMI
38972011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3898
3899 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3900 (bug#9493).
3901
33ed493b
CY
39022011-09-18 Chong Yidong <cyd@stupidchicken.com>
3903
3904 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3905 boolean (Bug#9154).
3906
56cd55c8
EZ
39072011-09-18 Eli Zaretskii <eliz@gnu.org>
3908
3909 * xdisp.c (display_line): Record maximum and minimum buffer
3910 positions even if no glyphs were produced (e.g., by a zero-width
3911 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3912 buffer positions that will be removed from the glyph row because
3913 they don't fit.
c02dcedf
EZ
3914 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3915 column is beyond frame width: don't subtract 1 "pixel" when
3916 computing width of the stretch.
3e62b7e0
EZ
3917 (reseat_at_next_visible_line_start): Undo the change made on
3918 2011-09-17 that saved paragraph information and restored it after
3919 the call to `reseat'. (Bug#9545)
56cd55c8 3920
5ed99d36 39212011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3922
3923 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3924 and turn window cursor on if cleared (Bug#9415).
3925
5ed99d36 39262011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3927
3928 * search.c (boyer_moore): Take unibyte characters from pattern
3929 literally. (Bug#9458)
3930
9bade7b2
EZ
39312011-09-18 Eli Zaretskii <eliz@gnu.org>
3932
3933 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3934
e5e9d610
PE
39352011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3936
87e4427a
PE
3937 Fix minor problem found by static checking.
3938 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3939 initialized, to pacify gcc -Wuninitialized.
3940
e5e9d610
PE
3941 * fileio.c: Report proper errno when syscall falls.
3942 (Finsert_file_contents): Save and restore errno,
3943 so that report_file_error outputs the correct diagnostic.
3944 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3945
a1674f0b
EZ
39462011-09-18 Eli Zaretskii <eliz@gnu.org>
3947
3948 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3949
fbfb6dd4
EZ
39502011-09-17 Eli Zaretskii <eliz@gnu.org>
3951
3952 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3953 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3954
bb187662
EZ
39552011-09-17 Eli Zaretskii <eliz@gnu.org>
3956
1137e8b8 3957 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3958 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3959
3960 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3961 (bidi_find_paragraph_start): Search back for paragraph beginning
3962 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3963 (bidi_move_to_visually_next): Only trigger paragraph-related
3964 computations when the last character is a newline or at EOB, not
3965 just any NEUTRAL_B. (Bug#9470)
3966
bb187662
EZ
3967 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3968 truncated lines if point is covered by a display string. (Bug#9524)
3969
2e621251
PE
39702011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3973 (cons_to_x_long): New function.
3974 (lisp_data_to_selection_data): Use it. Correct the test for
3975 short-versus-long data; it was negated. Break out of vector
3976 loop, for efficiency, when a long datum is discovered.
3977
91a15bc6
SM
39782011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3979
3980 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3981
b41c3a35
EZ
39822011-09-16 Eli Zaretskii <eliz@gnu.org>
3983
3984 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3985 GCC PR/17406) by declaring this function with external scope.
3986
7812ba2d
PE
39872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3990 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3991
cf7edc2a
AS
39922011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3993
3994 * editfns.c (Fformat): Correctly handle text properties on "%%".
3995
bd01620e
EZ
39962011-09-15 Eli Zaretskii <eliz@gnu.org>
3997
3998 * xterm.c (x_draw_composite_glyph_string_foreground):
3999 * w32term.c (x_draw_composite_glyph_string_foreground):
4000 * term.c (encode_terminal_code):
4001 * composite.c (composition_update_it, get_composition_id):
4002 * xdisp.c (get_next_display_element)
4003 (fill_composite_glyph_string): Add comments about special meaning
4004 of TAB characters in a composition.
4005
a02719a3
PE
40062011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4009 This occurs when processing a multibyte format.
4010 Problem reported by Wolfgang Jenker.
a02719a3 4011
72589a3c
JB
40122011-09-15 Johan Bockgård <bojohan@gnu.org>
4013
4014 * xdisp.c (try_cursor_movement): Only check for exact match if
4015 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4016
1c14176c
PE
40172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4018
4019 Remove unused external symbols.
4020 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4021 * xdisp.c (calc_pixel_width_or_height): Now static.
4022 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4023 * indent.c (check_display_width):
4024 * w32term.c: Fix comment to match code.
4025 * xterm.c, xterm.h (x_catching_errors): Remove.
4026
d2eea5b5
PE
40272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4028
4029 * xselect.c: Use signed conversions more consistently (Bug#9498).
4030 (selection_data_to_lisp_data): Assume incoming selection data are
4031 signed integers, not unsigned. This is to be consistent with
4032 outgoing selection data, which was modified to use signed integers
4033 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4034 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4035 expects long, not unsigned long.
4036
46888499
EZ
40372011-09-14 Eli Zaretskii <eliz@gnu.org>
4038
4039 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4040 computation of loop end. Reported by Johan Bockgård
4041 <bojohan@gnu.org>.
4042
ef8ef9fb
CY
40432011-09-13 Chong Yidong <cyd@stupidchicken.com>
4044
4045 * frame.c (Fother_visible_frames_p): Function deleted.
4046
fa819fed
EZ
40472011-09-12 Eli Zaretskii <eliz@gnu.org>
4048
4049 * indent.c (compute_motion): Process display vector front to back
4050 rather than the other way around. (Bug#2496)
4051
2ba8e008
SM
40522011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4053
4054 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4055
20f53c69
CY
40562011-09-11 Chong Yidong <cyd@stupidchicken.com>
4057
4058 * minibuf.c (Fread_from_minibuffer): Doc fix.
4059
d562d7a4
EZ
40602011-09-11 Eli Zaretskii <eliz@gnu.org>
4061
4062 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4063 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4064
1c4d7f3d
LMI
40652011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4066
4067 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4068 value for non-existent files.
4069
b885bf36
EZ
40702011-09-11 Eli Zaretskii <eliz@gnu.org>
4071
4072 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4073 set its "size" to -1. This will set the modtime_size field of
4074 the corresponding buffer to -1, which is what
4075 verify-visited-file-modtime expects for files that do not exist.
4076 (Bug#9139)
4077
6612f0bf
PE
40782011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4081 here ...
4082 * lisp.h: ... from here. push_key_description is no longer
4083 defined in keyboard.c, so its declaration should not be in
4084 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4085 logically belongs with push_key_description.
4086
dfb3f755
PE
40872011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 * buffer.h: Include <sys/types.h> instead of <time.h>.
4090 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4091 Problem reported by Herbert J. Skuhra.
4092
3134906c
LMI
40932011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4094
4095 * xml.c (parse_region): Make the parsing work for
4096 non-comment-starting XML files again (bug#9144).
4097
8d903f4e
AS
40982011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4099
4100 * image.c (gif_load): Fix calculation of bottom and right corner.
4101 (Bug#9468)
4102
80ad64f4
EZ
41032011-09-10 Eli Zaretskii <eliz@gnu.org>
4104
4105 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4106 redisplay in small windows.
4107
208a048d
EZ
41082011-09-09 Eli Zaretskii <eliz@gnu.org>
4109
4110 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4111
9b1c252e
MR
41122011-09-08 Martin Rudalics <rudalics@gmx.at>
4113
4114 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4115 Operate on live windows only.
4116
2949f33b
JB
41172011-09-08 Juanma Barranquero <lekktu@gmail.com>
4118
4119 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4120
e08dcafd
EZ
41212011-09-07 Eli Zaretskii <eliz@gnu.org>
4122
4123 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4124 only under bidi iteration.
4125
115b96bd
JD
41262011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4127
4128 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4129
c8199d0f
PE
41302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4131
4132 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4133 Without this fix, the command to link temacs failed due to an
4134 undefined symbol __builtin_isnan. This is because
4135 /usr/include/iso/math_c99.h #defines isnan(x) to
4136 __builtin_isnan(x), but the bundled gcc, which identifies itself
4137 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4138 a __builtin_isnan.
4139 * floatfns.c (isnan): #undef, and then #define to a clone of
4140 what's in data.c.
4141 (Fisnan): Always define, since it's always available now.
4142 (syms_of_floatfns): Always define isnan at the Lisp level.
4143
e39b275c 41442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4145
4146 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4147
b2db44d9 41482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4149
f4af5137 4150 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4151 The previous code assumed that file offsets (off_t values) fit in
4152 EMACS_INT variables, which is not true on typical 32-bit hosts.
4153 The code messed up by falsely reporting buffer overflow in cases
4154 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4155 when "big" contains more than 2**29 bytes, even though this
4156 inserts just one byte and does not overflow the buffer.
4157 (Finsert_file_contents): Store file offsets as off_t
4158 values, not as EMACS_INT values. Check for overflow when
4159 converting between EMACS_INT and off_t. When checking for
4160 buffer overflow or for overlap, take the offsets into account.
4161 Don't use EMACS_INT for small values where int suffices.
4162 When checking for overlap, fix a typo: ZV was used where
4163 ZV_BYTE was intended.
4164 (Fwrite_region): Don't assume off_t fits into 'long'.
4165 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4166
ecfc0a49
MA
41672011-09-05 Michael Albinus <michael.albinus@gmx.de>
4168
4169 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4170
6511acf2 41712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4172
0999621a 4173 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4174
4175 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4176 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4177 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4178 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4179 (modify_event_symbol): Do not assume that the length of
4180 name_alist_or_stem is safe to alloca and fits in int.
4181 (Fexecute_extended_command): Likewise for function name and binding.
4182 (Frecursion_depth): Wrap around reliably on integer overflow.
4183 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4184 since some callers pass EMACS_INT values.
4185 (Fsingle_key_description): Don't crash if symbol name contains more
4186 than MAX_ALLOCA bytes.
4187 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4188 (get_minibuffer): Arg is now EMACS_INT, not int.
4189 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4190 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4191 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4192
2be7d702
PE
4193 * dbusbind.c (signature_cat): New function.
4194 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4195 Do not overrun buffer; instead, report string overflow.
4196
9d1df220
PE
4197 * dispnew.c (add_window_display_history): Don't overrun buffer.
4198 Truncate instead; this is OK since it's just a log.
4199
33ef5c64
PE
4200 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4201 even if the time zone offset is outlandishly large.
4202 Don't mishandle offset == INT_MIN.
4203
66c6fdd5
PE
4204 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4205 when creating daemon; the previous buffer-overflow check was incorrect.
4206
d749b01b
PE
4207 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4208 which has the guts of the old verror function.
4209
b5cd1905
PE
4210 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4211 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4212
6e1a67fb
PE
4213 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4214 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4215 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4216 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4217 length of string rather than counting it via multiple sprintfs;
4218 that's simpler and more reliable.
c21721cc
PE
4219 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4220 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4221 sprintf, in case result does not fit in int.
4222
c57b67fc
PE
4223 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4224 (fontset_from_font): Print it.
4225
8a401434
PE
4226 * frame.c (tty_frame_count): Now printmax_t, not int.
4227 (make_terminal_frame, set_term_frame_name): Print it.
4228 (x_report_frame_params): In X, window IDs are unsigned long,
4229 not signed long, so print them as unsigned.
4230 (validate_x_resource_name): Check for implausibly long names,
4231 and don't assume name length fits in 'int'.
4232 (x_get_resource_string): Don't blindly alloca invocation name;
4233 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4234 not fit in int.
4235
6e1a67fb
PE
4236 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4237 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4238 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4239
0df02bf3
PE
4240 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4241 Use esprintf, not sprintf, in case result does not fit in int.
4242
48e30793
PE
4243 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4244 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4245 it as a large positive number.
4246 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4247 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4248
a66ff6d8
PE
4249 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4250 in case result does not fit in int.
4251
aca216ff
PE
4252 * print.c (float_to_string): Detect width overflow more reliably.
4253 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4254 buffer overrun. Don't assume list length fits in 'int'. Treat
4255 print length of 0 as 0, not as infinity; to be consistent with other
4256 uses of print length in this function. Don't overflow print length
4257 index. Don't assume hash table size fits in 'long', or that
4258 vectorlike size fits in 'unsigned long'.
4259
31c286f7
PE
4260 * process.c (make_process): Use printmax_t, not int, to format
4261 process-name gensyms.
4262
55e5faa1
PE
4263 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4264
80f2e268
PE
4265 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4266 to avoid potential buffer overrun.
4267
670741ab
PE
4268 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4269 if X resource line is longer than 512 bytes.
4270
b7163a50
PE
4271 * xfns.c (x_window): Make sprintf buffer a bit bigger
4272 to avoid potential buffer overrun.
4273
ae58ff1f
PE
4274 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4275
c43c8a6a
PE
4276 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4277
3f8236f4
PE
42782011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4279
53e9fe90 4280 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4281 Without these, Emacs silently mishandles large integers sometimes.
4282 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4283 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4284
6511acf2
PE
4285 * xdisp.c (try_window_id): Check Emacs fixnum range before
4286 converting to 'int'.
806add1d 4287
6511acf2 4288 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4289 Check that an Emacs fixnum is in range before assigning it to 'int'.
4290 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4291 values converted from Emacs fixnums.
4292 (Frecenter): Don't wrap around a line count if it is out of 'int'
4293 range; instead, treat it as an extreme value.
4294 (Fset_window_configuration, compare_window_configurations):
4295 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4296
6511acf2
PE
4297 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4298 that can exceed INT_MAX. Check that EMACS_INT value is in range
4299 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4300 (match_limit): Don't assume that a fixnum can fit in 'int'.
4301
6511acf2 4302 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4303 exceed INT_MAX.
4304
6511acf2 4305 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4306 (Fvertical_motion): Don't wrap around LINES values that don't fit
4307 in 'int'. Instead, treat them as extreme values. This is good
4308 enough for windows, which can't have more than INT_MAX lines anyway.
4309
fcb901a7
LMI
43102011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4311
0f2f6b6d
LMI
4312 * Require libxml/parser.h to avoid compilation warning.
4313
fcb901a7
LMI
4314 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4315
4316 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4317 since this reportedly can destroy thread storage.
4318
6e20a0d4
CY
43192011-08-30 Chong Yidong <cyd@stupidchicken.com>
4320
4321 * syntax.c (find_defun_start): Update all cache variables if
4322 exiting early (Bug#9401).
4323
148ae00e
EZ
43242011-08-30 Eli Zaretskii <eliz@gnu.org>
4325
f6cfbd8f
EZ
4326 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4327
148ae00e
EZ
4328 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4329 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4330 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4331
4332 * term.c (tty_append_glyph): New function.
4333 (produce_stretch_glyph): Static function and its prototype deleted.
4334
a66cfb1c
SM
4335 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4336 Add prototypes.
148ae00e 4337
c4a07a4c
PE
43382011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4339
4340 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4341 when checking :margin (Bug#9390).
4342 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4343 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4344 so that the name doesn't mislead. All uses changed.
4345
6bc8cd65
JB
43462011-08-28 Johan Bockgård <bojohan@gnu.org>
4347
4348 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4349 set_tty_hooks.
4350
dca4927e
EZ
43512011-08-27 Eli Zaretskii <eliz@gnu.org>
4352
4353 * xdisp.c (move_it_to): Don't bail out early when reaching
4354 position beyond to_charpos, if we are scanning backwards.
4355 (move_it_vertically_backward): When DY == 0, make sure we get to
4356 the first character in the line after the newline.
4357
f2cad773
PE
43582011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4359
4360 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4361 (ccl_driver): Do not generate an out-of-range pointer.
4362 (Fccl_execute_on_string): Remove unnecessary check for
4363 integer overflow, noted by Stefan Monnier in
4364 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4365 Remove a FIXME that didn't need fixing.
4366 Simplify the newly-introduced buffer reallocation code.
4367
0cae2cdb
JB
43682011-08-27 Juanma Barranquero <lekktu@gmail.com>
4369
4370 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4371
5fc295a4 43722011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4373
70c60eb2 4374 Integer and memory overflow issues (Bug#9196).
726e0ab1 4375
d31850da
PE
4376 * doc.c (get_doc_string): Rework so that
4377 get_doc_string_buffer_size is the actual buffer size, rather than
4378 being 1 less than the actual buffer size; this makes xpalloc more
4379 convenient.
4380
a69fbedb
PE
4381 * image.c (x_allocate_bitmap_record, cache_image):
4382 * xselect.c (Fx_register_dnd_atom):
4383 Simplify previous changes by using xpalloc.
4384
fe5c5d37
PE
4385 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4386 since either will do and ptrdiff_t is convenient with xpalloc.
4387
0065d054
PE
4388 * charset.c (charset_table_size)
4389 (struct charset_sort_data.priority): Now ptrdiff_t.
4390 (charset_compare): Don't overflow if priorities differ greatly.
4391 (Fsort_charsets): Don't assume list length fits in int.
4392 Check for size-calculation overflow when allocating sort data.
4393 (syms_of_charset): Allocate an initial charset table that is
4394 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4395
4396 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4397
4398 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4399 The actual value is always <= INT_MAX, and leaving it unsigned made
4400 overflow checking harder.
4401
4402 * dispextern.h (struct glyph_matrix.rows_allocated)
4403 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4404 with xpalloc. The values are still always <= INT_MAX.
4405
4406 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4407
4408 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4409 (SAFE_NALLOCA): New macro.
4410
4411 * region-cache.c (struct boundary.pos, find_cache_boundary)
4412 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4413 (set_cache_region, invalidate_region_cache)
4414 (revalidate_region_cache, know_region_cache, region_cache_forward)
4415 (region_cache_backward, pp_cache):
4416 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4417 so that ptrdiff_t * can be passed to xpalloc.
4418 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4419 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4420 (pp_cache): Don't assume cache_len fits in int.
4421 * region-cache.h: Adjust extern decls to match.
4422
4423 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4424 EMACS_INT, since either will do, for xpalloc.
4425
4426 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4427 (xnmalloc, xnrealloc, xpalloc): New functions.
4428
726e0ab1
PE
4429 * bidi.c (bidi_shelve_header_size): New constant.
4430 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4431 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4432
51f30bc5 4433 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4434 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4435 (overlay_strings):
4436 Don't update size of array until after memory allocation succeeds,
4437 because xmalloc/xrealloc may not return.
0065d054
PE
4438 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4439 now that we have proper integer overflow checking.
4440 (record_overlay_string, overlay_strings): Catch overflows when
4441 calculating size of overlay_str_buf.
726e0ab1 4442
0065d054
PE
4443 * callproc.c (Fcall_process): Check for size overflow when
4444 calculating size of args2.
4445 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4446 Normally we prefer signed values, but sticking with ptrdiff_t would
4447 require adding more-complicated checks.
726e0ab1
PE
4448
4449 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4450 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4451 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4452 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4453
4454 * character.c (Fstring): Check for size-calculation overflow.
4455
4456 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4457 unnecessary integer overflow. Check for size overflow.
4458 (encode_coding_object): Don't update size until xmalloc succeeds.
4459
4460 * composite.c (get_composition_id): Check for overflow in glyph
4461 length calculations.
4462
4463 Integer and memory overflow fixes for display code.
4464 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4465 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4466 (scrolling_window): Check for overflow in size calculations.
4467 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4468 Don't assume glyph table len fits in int.
4469 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4470 (row_table_size): Now ptrdiff_t, not int.
4471 (scrolling_window): Avoid overflow in size calculations.
4472 Don't update size until allocation succeeds.
4473 * fns.c (concat): Check for overflow in size calculations.
4474 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4475 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4476 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4477
4478 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4479 (get_doc_string): Check for size calculation overflow.
4480 Don't update size until allocation succeeds.
4481 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4482 EMACS_INT, where ptrdiff_t will do.
4483 (Fsubstitute_command_keys): Check for string overflow.
4484
4485 * editfns.c (set_time_zone_rule): Don't assume environment length
4486 fits in int.
4487 (message_length): Now ptrdiff_t, not int.
4488 (Fmessage_box): Don't update size until allocation succeeds.
4489 Don't assume message length fits in int.
4490 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4491
0065d054
PE
4492 * emacs.c (main): Do not reallocate argv, since there is a null at
4493 the end that can be overwritten, and this way there's no need to
4494 worry about size-calculation overflow.
4495 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4496
4497 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4498 alloc succeeds.
4499 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4500
4501 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4502 (x_set_scroll_bar_width, x_figure_window_size):
4503 Check for integer overflow.
4504 (x_set_alpha): Do not assume XINT fits in int.
4505
4506 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4507 This is for the members text_lines, text_cols, total_lines, total_cols,
4508 where the system imposes an 'int' limit.
4509
4510 * fringe.c (Fdefine_fringe_bitmap):
4511 Don't update size until alloc works.
4512
4513 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4514 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4515
4516 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4517 Check for size-calculation overflow.
4518 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4519 do, as we prefer signed integers.
4520 (id_to_widget.max_size, id_to_widget.used)
4521 (xg_store_widget_in_map, xg_remove_widget_from_map)
4522 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4523 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4524 Use and return ptrdiff_t, not int.
4525 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4526 * gtkutil.h: Change prototypes to match the above.
4527
4528 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4529 are duplicate now that they've been promoted to lisp.h.
4530 (x_allocate_bitmap_record, x_alloc_image_color)
4531 (make_image_cache, cache_image, xpm_load):
4532 Don't update size until alloc is done.
4533 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4534 (x_detect_edges):
3256efce 4535 Check for size calculation overflow.
726e0ab1
PE
4536 (ct_colors_allocated_max): New constant.
4537 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4538 overflow.
3256efce 4539
726e0ab1
PE
4540 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4541 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4542 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4543 Use ptrdiff_t, not int, to count maps.
4544 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4545 calculations. Don't update size until allocation succeeds.
4546 Redo calculations to avoid overflow.
726e0ab1
PE
4547 * keyboard.h: Change prototypes to match the above.
4548
4549 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4550 to count maps.
4551 (current_minor_maps): Check for size calculation overflow.
4552 * keymap.h: Change prototypes to match the above.
4553
4554 * lread.c (read1, init_obarray): Don't update size until alloc done.
4555
4556 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4557 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4558
726e0ab1
PE
4559 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4560 Now ptrdiff_t, not int.
4561 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4562 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4563
4564 * process.c (Fnetwork_interface_list): Check for overflow
4565 in size calculation.
4566
4567 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4568
4569 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4570 overflow. Don't bother calling xmalloc when xrealloc will do.
4571
4572 * search.c (Freplace_match): Check for size calculation overflow.
4573 (Fset_match_data): Don't assume list lengths fit in 'int'.
4574
4575 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4576 for command line length. Do not attempt to address one before the
4577 beginning of an array, as that's not portable.
4578
4579 * term.c (max_frame_lines): Remove; unused.
4580 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4581 not int.
4582 (encode_terminal_code, calculate_costs): Check for size
4583 calculation overflow.
4584 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4585 table lengths and related sizes. Don't update size until alloc
4586 done. Redo calculations to avoid overflow.
4587 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4588
4589 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4590 subtracting pointers.
4591 (gobble_line): Check for overflow more carefully. Don't update size
4592 until alloc done.
4593
4594 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4595 Don't update size until alloc done.
4596 Redo size calculations to avoid overflow.
4597 Check for size calculation overflow.
0065d054 4598 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4599
4600 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4601 Use ptrdiff_t, not int, for sizes.
4602 (store_mode_line_noprop_char): Don't update size until alloc done.
4603
0065d054
PE
4604 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4605 Use ptrdiff_t, not int, for sizes.
4606 (Finternal_make_lisp_face, cache_face):
4607 Check for size calculation overflow.
4608 (cache_face): Treat size calculation overflows as if they were
4609 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4610
4611 * xfns.c (x_encode_text, x_set_name_internal)
4612 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4613 sizes, since they can exceed INT_MAX in size. Check for size
4614 calculation overflow.
4615
0065d054
PE
4616 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4617 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4618 Don't update size until alloc done.
4619
0065d054 4620 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4621 as sprintf is limited to int lengths.
1d526e2f 4622
252c5ee1
PE
4623 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4624 (X_LONG_MIN): New macros.
864d7ce7
PE
4625 Use them to make the following changes clearer.
4626 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4627 This change doesn't affect the value now, but it may help remind
4628 future maintainers not to raise the value too much later.
4629 (SELECTION_QUANTUM): Remove, replacing with ...
4630 (selection_quantum): ... new function, which avoids overflow.
4631 All uses changed.
4632 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4633 assumption that selection length fits in 'int'.
4634 (x_reply_selection_request, x_handle_selection_request)
4635 (x_get_window_property, receive_incremental_selection)
4636 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4637 (lisp_data_to_selection_data, clean_local_selection_data):
4638 Use ptrdiff_t, not int, to record length of selection.
4639 (x_reply_selection_request, x_get_window_property)
4640 (receive_incremental_selection, x_property_data_to_lisp):
4641 Redo calculations to avoid overflow.
4642 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4643 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4644 something.
4645 (x_get_window_property, receive_incremental_selection)
4646 (lisp_data_to_selection_data, x_property_data_to_lisp):
4647 Check for size-calculation overflow.
4648 (x_get_window_property, receive_incremental_selection)
4649 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4650 Don't store size until memory allocation succeeds.
4651 (x_get_window_property): Plug memory leak on memory exhaustion.
4652 Don't double-block input; malloc is safe here. Don't assume 2**34
4653 - 4 fits in unsigned long. Add an xassert to check
4654 XGetWindowProperty overflow. Be more careful about overflow
4655 calculations, and distinguish size from memory overflow better.
4656 (receive_incremental_selection): When tracing, don't assume
4657 unsigned int is less than INT_MAX.
4658 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4659 harmful) conversions of unsigned short to int.
4660 (lisp_data_to_selection_data): Don't assume that integers
4661 in the range -65535 through -1 fit in an X unsigned short.
4662 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4663 result parameters unless successful. Rely on cons_to_unsigned
4664 to report problems with elements; the old code wasn't right anyway.
4665 (x_check_property_data): Check for int overflow; we cannot use
4666 a wider type due to X limits.
4667 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4668
726e0ab1 4669 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4670
0065d054
PE
4671 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4672 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4673 (x_color_cells): Don't store size until memory allocation succeeds.
4674 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4675 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4676 (x_term_init): Don't assume length fits in int (sprintf is limited
4677 to int size).
bc18e09d 4678
ebfa62c0
PE
4679 Use ptrdiff_t for composition IDs.
4680 * character.c (lisp_string_width):
4681 * composite.c (composition_table_size, n_compositions)
4682 (get_composition_id, composition_gstring_from_id):
4683 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4684 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4685 * window.c (Frecenter):
4686 Use ptrdiff_t, not int, for composition IDs.
4687 * composite.c (get_composition_id): Check for integer overflow.
4688 * composite.h: Adjust prototypes to match the above changes.
4689
d3411f89
PE
4690 Use ptrdiff_t for hash table indexes.
4691 * category.c (hash_get_category_set):
4692 * ccl.c (ccl_driver):
4693 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4694 * coding.c (coding_system_charset_list, detect_coding_system):
4695 * coding.h (struct coding_system.id):
4696 * composite.c (get_composition_id, gstring_lookup_cache):
4697 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4698 * image.c (xpm_get_color_table_h):
4699 * lisp.h (hash_lookup, hash_put):
4700 * minibuf.c (Ftest_completion):
4701 Use ptrdiff_t for hash table indexes, not int (which is too
4702 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4703 32-bit --with-wide-int hosts).
4704
e097a6fa
PE
4705 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4706 Add a FIXME comment about memory leaks.
4707 (syms_of_charset): Don't assume xmalloc returns.
4708
5637687f
PE
4709 Don't assume that stated character widths fit in int.
4710 * character.c (Fchar_width, c_string_width, lisp_string_width):
4711 * character.h (CHAR_WIDTH):
4712 * indent.c (MULTIBYTE_BYTES_WIDTH):
4713 Use sanitize_char_width to avoid undefined and/or bad behavior
4714 with outlandish widths.
a66cfb1c 4715 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4716 now that we have two such functions. All uses changed.
4717 (sanitize_char_width): New inline function.
4718
a2271ba2
PE
4719 Don't assume that tab-width fits in int.
4720 * character.h (sanitize_width): New inline function.
4721 (SANE_TAB_WIDTH): New macro.
4722 (ASCII_CHAR_WIDTH): Use it.
4723 * indent.c (sane_tab_width): Remove. All uses replaced by
4724 SANE_TAB_WIDTH (current_buffer).
4725 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4726
18c52557
PE
4727 * fileio.c: Integer overflow issues with file modes.
4728 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4729
caeeedc1
PE
4730 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4731 Remove unreachable code.
4732 (read_hex, load_charset_map_from_file): Check for integer overflow.
4733
6df6ae42 4734 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4735 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4736 (x_send_scroll_bar_event): Likewise. Check that the size does not
4737 exceed limits imposed by XClientMessageEvent, as well as the usual
4738 ptrdiff_t and size_t limits.
4739
b13995db
PE
4740 * keyboard.c: Overflow, signedness and related fixes.
4741 (make_lispy_movement): Use same integer type in forward decl
4742 that is used in the definition.
4743 (read_key_sequence, keyremap_step):
4744 Change bufsize argument back to int, undoing my 2011-03-30 change.
4745 We prefer signed types, and int is wide enough here.
4746 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4747 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4748 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4749 length, not size_t. Use ptrdiff_t for index, not int.
4750 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4751 possibility of integer overflow.
4752
13464394
PE
4753 Overflow, signedness and related fixes for images.
4754
4755 * dispextern.h (struct it.stack[0].u.image.image_id)
4756 (struct_it.image_id, struct image.id, struct image_cache.size)
4757 (struct image_cache.used, struct image_cache.ref_count):
4758 * gtkutil.c (update_frame_tool_bar):
4759 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4760 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4761 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4762 * nsmenu.m (update_frame_tool_bar):
4763 * xdisp.c (calc_pixel_width_or_height):
4764 * xfns.c (image_cache_refcount):
4765 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4766 on typical 64-bit hosts.
4767
4768 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4769 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4770 Omit unnecessary casts to int.
4771 (parse_image_spec): Check that integers fall into 'int' range
4772 when the callers expect that.
4773 (image_ascent): Redo ascent calculation to avoid int overflow.
4774 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4775 (lookup_image): Remove unnecessary tests.
4776 (xbm_image_p): Locals are now of int, not EMACS_INT,
4777 since parse_image_check makes sure they fit into int.
4778 (png_load, gif_load, svg_load_image):
4779 Prefer int to unsigned where either will do.
4780 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4781 old tiff_error_handler and tiff_warning_handler.
4782 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4783 stack buffer overflows. It uses only the features of vsnprintf
4784 that are common to both POSIX and native Microsoft.
4785 (tiff_error_handler, tiff_warning_handler): Use it.
4786 (tiff_load, gif_load, imagemagick_load_image):
4787 Don't assume :index value fits in 'int'.
4788 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4789 (imagemagick_load_image): Check that crop parameters fit into
4790 the integer types that MagickCropImage accepts. Don't assume
4791 Vimagemagick_render_type has a nonnegative value. Don't assume
4792 size_t fits in 'long'.
4793 (gs_load): Use printmax_t to print the widest integers possible.
4794 Check for integer overflow when computing image height and width.
4795
c11821d4
EZ
47962011-08-26 Eli Zaretskii <eliz@gnu.org>
4797
4798 * xdisp.c (redisplay_window): Don't force window start if point
4799 will be invisible in the resulting window. (Bug#9324)
4800
0c95fcf7
EZ
48012011-08-25 Eli Zaretskii <eliz@gnu.org>
4802
4803 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4804 the display spec is of the form `(space ...)'.
4805 (handle_display_spec): Return the value returned by
4806 handle_single_display_spec, not just 1 or zero.
4807 (handle_single_display_spec): If the display spec is of the form
4808 `(space ...)', and specifies display in the text area, return 2
4809 rather than 1.
fee65a97 4810 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4811 accurately, and prefer exact match for point under bidi.
4812 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4813
4814 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4815 into disp_prop; all users changed.
4816
4817 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4818 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4819 for the text covered by the display property.
4820
e4ed06f1
CY
48212011-08-25 Chong Yidong <cyd@stupidchicken.com>
4822
4823 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4824 Change return value to nil.
4825 (Frecord_buffer): Delete unused function.
4826
f67cdd7f
EZ
48272011-08-24 Eli Zaretskii <eliz@gnu.org>
4828
5980d4c6
EZ
4829 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4830 buffers, return left-to-right.
8610fe8b
EZ
4831 (set_cursor_from_row): Consider candidate row a win if its glyph
4832 represents a newline and point is on that newline. Fixes cursor
4833 positioning on the newline at EOL of R2L text within L2R
4834 paragraph, and vice versa.
4835 (try_cursor_movement): Check continued rows, in addition to
4836 continuation rows. Fixes unwarranted scroll when point enters a
4837 continued line of R2L text within an L2R paragraph, or vice versa.
4838 (cursor_row_p): Consider the case of point being equal to
4839 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4840 from the end of a short line to the beginning of a continued line
4841 of R2L text within L2R paragraph.
4842 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4843 composed characters.
5980d4c6 4844
f67cdd7f
EZ
4845 * bidi.c (bidi_check_type): Use xassert.
4846 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4847 members.
4848
bca633fb
EZ
48492011-08-23 Eli Zaretskii <eliz@gnu.org>
4850
4851 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4852 a character.
4853
4a5885a7
CY
48542011-08-23 Chong Yidong <cyd@stupidchicken.com>
4855
4856 * nsfont.m (ns_otf_to_script): Fix typo.
4857
0902a04e
KH
48582011-08-22 Kenichi Handa <handa@m17n.org>
4859
4860 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4861 extra slot even if the purpose is char-code-property-table.
4862
1a2e6670
EZ
48632011-08-23 Eli Zaretskii <eliz@gnu.org>
4864
8ddde651
EZ
4865 * xdisp.c (redisplay_window): When computing centering_position,
4866 account for the height of the header line. (Bug#8874)
4867
425cc014
EZ
4868 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4869 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4870 candidate is selected by the mouse, and that candidate has a
4871 composed character under the mouse.
4872
1a2e6670
EZ
4873 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4874 coordinates reported by pos-visible-in-window-p for a composed
4875 character in column zero.
4876
8b76d6f8
SM
48772011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4878
4879 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4880
dac347dd
EZ
48812011-08-22 Eli Zaretskii <eliz@gnu.org>
4882
4883 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4884 consider it a hit if to_charpos is anywhere in the range of the
4885 composed buffer positions.
4886
e013fb34
CY
48872011-08-22 Chong Yidong <cyd@stupidchicken.com>
4888
4889 * image.c (gif_load): Don't assume that each subimage has the same
4890 dimensions as the base image. Handle disposal method that is
4891 "undefined" by the gif spec (Bug#9335).
4892
bd1ba3e8
CY
48932011-08-20 Chong Yidong <cyd@stupidchicken.com>
4894
4895 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4896 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4897
54a1215b
EZ
48982011-08-19 Eli Zaretskii <eliz@gnu.org>
4899
823564e5
EZ
4900 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4901 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4902 from an Org mode buffer to a Speedbar frame.
4903
54a1215b
EZ
4904 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4905 a composition, take its buffer position from IT->cmp_it.charpos.
4906 Fixes cursor positioning at the beginning of a line that begins
4907 with a composed character.
4908
9778ebcc
EZ
49092011-08-18 Eli Zaretskii <eliz@gnu.org>
4910
0be6ee06
EZ
4911 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4912 character bidirectional type, use STRONG_L instead. Fixes crashes
4913 in a buffer produced by `describe-categories'.
4914
9778ebcc
EZ
4915 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4916 members before the level stack, so they would be saved and
4917 restored when copying iterator state. Fixes incorrect reordering
4918 around TABs covered by display properties.
4919
156bffbe
AS
49202011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4921
6b02f655 4922 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4923
72ad093b
CY
49242011-08-17 Chong Yidong <cyd@stupidchicken.com>
4925
4926 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4927 (internal_condition_case_2, internal_condition_case_n):
4928 Remove unnecessary aborts (Bug#9081).
72ad093b 4929
35774242
EZ
49302011-08-17 Eli Zaretskii <eliz@gnu.org>
4931
4932 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4933 has no `load' handler, try opening the file locally. (Bug#9311)
4934
db76dd85
KB
49352011-08-16 Ken Brown <kbrown@cornell.edu>
4936
4937 * gmalloc.c: Expand comment.
4938
b215eee5
EZ
49392011-08-16 Eli Zaretskii <eliz@gnu.org>
4940
4941 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4942 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4943
a4579d33
KB
49442011-08-16 Ken Brown <kbrown@cornell.edu>
4945
4946 Fix memory allocation problems in Cygwin build (Bug#9273).
4947
4948 * unexcw.c ( __malloc_initialized): Declare external variable.
4949 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4950
8b76d6f8
SM
4951 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4952 New variables.
a4579d33
KB
4953 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4954 dumped emacs.
4955 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4956 in the static heap.
4957 [CYGWIN] (special_realloc): New function.
4958 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4959 requests to realloc storage in the static heap.
4960
3ebec551
PE
49612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4962
4963 * bidi.c (bidi_initialize): Remove unused local.
4964
9fd8be00
EZ
49652011-08-15 Eli Zaretskii <eliz@gnu.org>
4966
6b02f655
SM
4967 * bidimirror.h:
4968 * biditype.h: Remove file.
4969 * makefile.w32-in ($(BLD)/bidi.$(O)):
4970 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4971
4972 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4973
4974 * chartab.c: Improve commentary for the uniprop_table API.
4975
32413314
EZ
4976 * bidi.c (bidi_paragraph_init): Support zero value of
4977 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4978 (bidi_initialize): Use uniprop_table instead of including
4979 biditype.h and bidimirror.h.
32413314 4980
9fd8be00
EZ
4981 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4982 coordinates of the iterator when restoring from ppos_it.
4983 (Bug#9296)
4984
5cf2b69b
KH
49852011-08-14 Kenichi Handa <handa@m17n.org>
4986
4987 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4988 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4989
daf17d00
EZ
49902011-08-14 Eli Zaretskii <eliz@gnu.org>
4991
4992 * xdisp.c (move_it_in_display_line_to): Don't invoke
4993 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4994 ppos_it. Fixes vertical cursor motion when line beginning is
4995 covered by an image. (Bug#9296)
4996
08e3161a
JD
49972011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4998
4999 * nsterm.h (ns_run_ascript): Declare.
5000 (NSAPP_DATA2_RUNASSCRIPT): Define.
5001
5002 * nsfns.m (as_script, as_result, as_status): New static variables.
5003 (ns_run_ascript): New function.
5e617bc2 5004 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5005 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5006 the event loop. Get status from as_status (Bug#7276).
5007
5008 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5009 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5010 the event loop (Bug#7276).
5011
a3720aa2
AS
50122011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5013
5014 * gnutls.c (QCgnutls_bootprop_priority)
5015 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5016 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5017 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5018 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5019 (QCgnutls_bootprop_verify_hostname_error)
5020 (QCgnutls_bootprop_callbacks_verify): Rename from
5021 Qgnutls_bootprop_..., all uses changed.
5022
5023 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5024 uses changed.
5025
0a0d27fb
PE
50262011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5027
19d5c50c
PE
5028 * xfaces.c (Qframe_set_background_mode): Now static.
5029 * dispextern.h (Qframe_set_background_mode): Remove decl.
5030
0a0d27fb
PE
5031 * process.c (Fnetwork_interface_info): Declare local only if needed.
5032
377538cb
JD
50332011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5034
5035 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5036 (Fnetwork_interface_list): Allocate in increments of bytes instead
5037 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5038 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5039 sockaddr.
5040 (struct ifflag_def): notrailers is smart on OSX.
5041 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5042 Get hardware address with getifaddrs if available.
5043
08fff70c
EZ
50442011-08-12 Eli Zaretskii <eliz@gnu.org>
5045
5046 * xdisp.c (iterate_out_of_display_property): xassert that
5047 IT->position is set to within IT->object's boundaries. Break from
5048 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5049 when IT->position is set up wrongly due to some bug.
5050 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5051 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5052 entry. Force push_it to save on the stack the current
5053 buffer/string position, to be restored by pop_it. Fix flags in
5054 the iterator structure wrt the object coming from a display
5055 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5056 properties. (Bug#9284)
5057
7be1c708 50582011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5059
7be1c708
CY
5060 * fontset.c (fontset_get_font_group): Add proper type checks.
5061 (Bug#9172)
aac0c6e3 5062
7be1c708 50632011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5064
7be1c708
CY
5065 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5066 and LC_VERSION_MIN_MACOSX.
5067 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5068 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5069
97bb72a6
EZ
50702011-08-08 Eli Zaretskii <eliz@gnu.org>
5071
5072 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5073 no-display-properties-and-no-overlays under bidi display.
5074 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5075 properties and overlays.
97bb72a6 5076
d5617611
CY
50772011-08-08 Chong Yidong <cyd@stupidchicken.com>
5078
37e11a63
CY
5079 * editfns.c (Fset_time_zone_rule): Document relationship with the
5080 setenv function.
5081
d5617611
CY
5082 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5083 the font entity extracted from the cache (Bug#8109).
5084
58872834
CY
50852011-08-07 Chong Yidong <cyd@stupidchicken.com>
5086
5087 * composite.c (autocmp_chars): Don't reset point. That is done by
5088 restore_point_unwind (Bug#5984).
5089
75bfc667
JL
50902011-08-07 Juri Linkov <juri@jurta.org>
5091
5092 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5093 to show the arg `TIME' instead of `TIMEVAL'.
5094
d1410150
EZ
50952011-08-06 Eli Zaretskii <eliz@gnu.org>
5096
5097 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5098 display property strides EOL and includes a newline, as in
5099 longlines-mode. (Bug#9254)
75b771e4
EZ
5100 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5101 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5102
5103 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5104 is non-zero, even if the data buffer is NULL. Fixes a crash in
5105 vertical-motion with longlines-mode. (Bug#9254)
5106
35928349
EZ
51072011-08-05 Eli Zaretskii <eliz@gnu.org>
5108
ec7cc85b
EZ
5109 * bidi.c <bidi_cache_total_alloc>: Now static.
5110 (bidi_initialize): Initialize bidi_cache_total_alloc.
5111
8b76d6f8 5112 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5113 cache. (Bug#9221)
5114
5115 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5116 amount allocated this far in `bidi_cache_total_alloc'.
5117 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5118 non-zero, only free the data buffer without restoring the cache
5119 contents. All callers changed.
5120
5121 * dispextern.h (bidi_unshelve_cache): Update prototype.
5122
5123 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5124 (move_it_in_display_line, move_it_to)
5125 (move_it_vertically_backward, move_it_by_lines): Replace the call
5126 to xfree to an equivalent call to bidi_unshelve_cache.
5127 (move_it_in_display_line_to): Fix logic of returning
412b6358 5128 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5129
e2e2423b
EZ
51302011-08-05 Eli Zaretskii <eliz@gnu.org>
5131
5132 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5133 came from a string character with a `cursor' property. (Bug#9229)
5134
ae9e757a
JD
51352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5136
5137 * Makefile.in (LIB_PTHREAD): New variable.
5138 (LIBES): Add LIB_PTHREAD (Bug#9216).
5139
5140 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5141 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5142
213bd7f2
AS
51432011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5144
6b02f655 5145 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5146
99aaf75f
JD
51472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5148
5149 * xterm.c (x_find_topmost_parent): New function.
5150 (x_set_frame_alpha): Find topmost parent window with
5151 x_find_topmost_parent and set the property there also (bug#9181).
5152 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5153
c74e9d86
PE
51542011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 * callproc.c (Fcall_process): Avoid vfork clobbering
5157 the local vars buffer, coding_systems, current_dir.
5158
640c8776
SM
51592011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5160
5161 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5162
f26d0e4c
PE
51632011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5164
8a10d76c
PE
5165 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5166 so that it is not optimized away.
5167
f26d0e4c
PE
5168 * xdisp.c (compute_display_string_pos): Remove unused local.
5169
55439c61
EZ
51702011-08-02 Eli Zaretskii <eliz@gnu.org>
5171
5172 Fix slow cursor motion and scrolling in large buffers with
5173 selective display, like Org Mode buffers. (Bug#9218)
5174
5175 * dispextern.h (struct bidi_it): New member disp_prop_p.
5176
5177 * xdisp.c: Remove one-slot cache of display string positions.
5178 (compute_display_string_pos): Accept an additional argument
5e617bc2 5179 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5180 for a display string or property. If found, set DISP_PROP_P
5181 non-zero.
5182
5183 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5184 DISP_PROP_P, and pass it to compute_display_string_pos.
5185 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5186 non-zero. All callers of bidi_fetch_char changed.
5187
fb33fa43
SM
51882011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5189
5190 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5191
b099e063
DM
51922010-12-03 Don March <don@ohspite.net>
5193
5194 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5195 last character M-[char] is translated to ESC [char] (bug#7541).
5196
5cc7f7af
KH
51972011-08-02 Kenichi Handa <handa@m17n.org>
5198
d0fffa3f 5199 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5200
5201 * chartab.c (uniprop_table): Make it non-static.
5202
525d5e6e
EZ
52032011-08-01 Eli Zaretskii <eliz@gnu.org>
5204
5205 * xdisp.c (forward_to_next_line_start): Accept additional argument
5206 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5207 on the newline.
5208 (reseat_at_next_visible_line_start): Use the bidi iterator state
5209 returned by forward_to_next_line_start to restore the state of
5210 it->bidi_it after backing up to previous newline. (Bug#9212)
5211
31011111
AS
52122011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5213
5214 * regex.c (re_comp): Protoize.
5215 (re_exec): Fix return type.
5216 (regexec): Fix type of `ret'. (Bug#9203)
5217
476371c4
PE
52182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5219
e5d76069
PE
5220 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5221 This is needed if max-image-size is a floating-point number.
5222
9a79b20c
AS
52232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5224
5225 * print.c (print_object): Print empty symbol as ##.
5226
5227 * lread.c (read1): Read ## as empty symbol.
5228
d8c2fa78
AA
52292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5230
5231 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5232 setting frame foreground color (Bug#9175).
5233 (x_set_background_color): Likewise.
5234
ffe57a7a
AA
5235 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5236 contents (Bug#9176).
5237 (EmacsTooltip -init): Remove bezels and add shadows to
5238 tooltip windows.
5239
bf3492a5
AA
5240 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5241 or scroll bar (Bug#8470).
5242
d55e9c53
AA
5243 * nsfont.m (nsfont_open): Remove assignment to voffset and
5244 unnecessary vars hshink, expand, hd, full_height, min_height.
5245 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5246
5247 * nsterm.h (nsfont_info): Remove voffset field.
5248
d8c2fa78 52492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5250
5251 Implement strike-through and overline on NextStep (Bug#8863).
5252
5253 * nsfont.m (nsfont_open): Use underline position provided by font,
5254 instead of hard-coded value of 2.
5255 (nsfont_draw): Call ns_draw_text_decoration instead.
5256
5257 * nsterm.h: Add declaration for ns_draw_text_decoration.
5258
5259 * nsterm.m (ns_draw_text_decoration): New function for drawing
5260 underline, overline, and strike-through.
5261 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5262 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5263 accommodate underlining, etc.
4843aac3 5264
4cc60b9b
EZ
52652011-07-28 Eli Zaretskii <eliz@gnu.org>
5266
bc7ece87
EZ
5267 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5268 default.
4cc60b9b 5269
476371c4
PE
52702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5271
66606eea
PE
5272 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5273 Without this fix, if a signal arrives just after memory fills up,
5274 'malloc' might be invoked reentrantly.
5275
476371c4
PE
5276 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5277 In other words, assume that every image size is allowed, on non-X
5278 hosts. This assumption is probably wrong, but it lets Emacs compile.
5279
f3fcc40d
AS
52802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5281
5282 * regex.c (re_iswctype): Convert return values to boolean.
5283
350c992f
EZ
52842011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5285
5286 * xdisp.c (compute_display_string_pos): Don't use cached display
5287 string position if the buffer had its restriction changed.
5288 (Bug#9184)
5289
5266b4bb
PE
52902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5291
5292 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5293
2573a837 52942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5295
41f55ccd 5296 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5297
39e378da
PE
5298 * bidi.c: Integer size and overflow fixes.
5299 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5300 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5301 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5302 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5303 (bidi_find_other_level_edge):
5304 Use ptrdiff_t instead of EMACS_INT where either will do.
5305 This works better on 32-bit hosts configured --with-wide-int.
5306 (bidi_cache_ensure_space): Check for size-calculation overflow.
5307 Use % rather than repeated addition, for better worst-case speed.
5308 Don't set bidi_cache_size until after xrealloc returns, because it
5309 might not return.
5310 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5311 (bidi_cache_ensure_space): Also check that the bidi cache size
5312 does not exceed that of the largest Lisp string or buffer. See Eli
5313 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5314
5e927815
PE
5315 * alloc.c (__malloc_size_t): Remove.
5316 All uses replaced by size_t. See Andreas Schwab's note
5317 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5318
ca4aa935
PE
5319 * image.c: Improve checking for integer overflow.
5320 (check_image_size): Assume that f is nonnull, since
5321 it is always nonnull in practice. This is one less thing to
5322 worry about when checking for integer overflow later.
5323 (x_check_image_size): New function, which checks for integer
5324 overflow issues inside X.
5325 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5326 This removes the need for a memory_full check.
5327 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5328 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5329 (xbm_read_bitmap_data): Change locals back to 'int', since
5330 their values must fit in 'int'.
5331 (xpm_load_image, png_load, tiff_load):
5332 Invoke x_create_x_image_and_pixmap earlier,
5333 to avoid much needless work if the image is too large.
5334 (tiff_load): Treat overly large images as if
5335 x_create_x_image_and_pixmap failed, not as malloc failures.
5336 (gs_load): Use x_check_image_size.
5337
5f8f9cc2
PE
5338 * gtkutil.c: Omit integer casts.
5339 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5340 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5341
5adf60bc
PE
5342 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5343
c8907a93
PE
5344 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5345 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5346 would wrongly return t on a 64-bit host.
5347
e3c25c68
PE
5348 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5349 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5350 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5351 and therefore cause GCC to emit a bogus diagnostic in some cases.
5352
3f791afe
PE
5353 * image.c: Integer signedness and overflow and related fixes.
5354 This is not an exhaustive set of fixes, but it's time to
5355 record what I've got.
5356 (lookup_pixel_color, check_image_size): Remove redundant decls.
5357 (check_image_size): Don't assume that arbitrary EMACS_INT values
5358 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5359 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5360 (tiff_load, imagemagick_load_image):
5361 Check for overflow in size calculations.
5362 (x_create_x_image_and_pixmap): Remove unnecessary test for
5363 xmalloc returning NULL; that can't happen.
5364 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5365 (xpm_color_bucket): Use better integer hashing function.
5366 (xpm_cache_color): Don't possibly over-allocate memory.
5367 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5368 (gif_memory_source):
5369 Use ptrdiff_t, not int or size_t, to record sizes.
5370 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5371 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5372 either works, as we prefer signed integers.
5373 (tiff_read_from_memory, tiff_write_from_memory):
5374 Return tsize_t, not size_t, since that's what the TIFF API wants.
5375 (tiff_read_from_memory): Don't fail simply because the read would
5376 go past EOF; instead, return a short read.
5377 (tiff_load): Omit no-longer-needed casts.
5378 (Fimagemagick_types): Don't assume size fits into 'int'.
5379
3cc5a532
PE
5380 Improve hashing quality when configured --with-wide-int.
5381 * fns.c (hash_string): New function, taken from sxhash_string.
5382 Do not discard information about ASCII character case; this
5383 discarding is no longer needed.
5384 (sxhash-string): Use it. Change sig to match it. Caller changed.
5385 * lisp.h: Declare it.
5386 * lread.c (hash_string): Remove, since we now use fns.c's version.
5387 The fns.c version returns a wider integer if --with-wide-int is
5388 specified, so this should help the quality of the hashing a bit.
5389
b312a492
PE
5390 * emacs.c: Integer overflow minor fix.
5391 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5392 Define only if GNU_LINUX.
5393 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5394
dfd153ae
PE
5395 * dispnew.c: Integer signedness and overflow fixes.
5396 Remove unnecessary forward decls, that were a maintenance hassle.
5397 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5398 All uses changed.
5399 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5400 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5401 (prepare_desired_row, line_draw_cost):
5402 Use int, not unsigned, where either works.
5403 (save_current_matrix, restore_current_matrix):
5404 Use ptrdiff_t, not size_t, where either works.
5405 (init_display): Check for overflow more accurately, and without
5406 relying on undefined behavior.
5407
a81d11a3
PE
5408 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5409 Remove, replacing with the new symbols in lisp.h. All uses changed.
5410 * fileio.c (make_temp_name):
5411 * filelock.c (lock_file_1, lock_file):
5412 * xdisp.c (message_dolog):
5413 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5414 Use pMd etc. instead.
5415 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5416 replacing the pWIDE etc. symbols removed from editfns.c.
5417
3300e6fd
PE
5418 * keyboard.h (num_input_events): Now uintmax_t.
5419 This is (very slightly) less likely to mess up due to wraparound.
5420 All uses changed.
5421
fd05c7e9
PE
5422 * buffer.c: Integer signedness fixes.
5423 (alloc_buffer_text, enlarge_buffer_text):
5424 Use ptrdiff_t rather than size_t when either will do, as we prefer
5425 signed integers.
5426
903fe15d
PE
5427 * alloc.c: Integer signedness and overflow fixes.
5428 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5429 (__malloc_size_t): Default to size_t, not to int.
5430 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5431 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5432 Prefer ptrdiff_t to size_t when either would do, as we prefer
5433 signed integers.
5434 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5435 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5436 Now const. Initialize with values that are in range even if char
5437 is signed.
5438 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5439 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5440 These functions do the right thing with sizes > 2**32.
5441 (check_depth): Now ptrdiff_t, not int.
5442 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5443 Adjust to new way of storing sizes. Check for size overflow bugs
5444 in rest of code.
5445 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5446 slightly wrong anyway, as it missed one instance of
5447 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5448 (refill_memory_reserve): Omit needless cast to size_t.
5449 (mark_object_loop_halt): Mark as externally visible.
5450
ac82cc6a
PE
5451 * xselect.c: Integer signedness and overflow fixes.
5452 (Fx_register_dnd_atom, x_handle_dnd_message):
5453 Use ptrdiff_t, not size_t, since we prefer signed.
5454 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5455 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5456 x_dnd_atoms_size and x_dnd_atoms_length.
5457
c2d1e36d
PE
5458 * doprnt.c: Prefer signed to unsigned when either works.
5459 * eval.c (verror):
5460 * doprnt.c (doprnt):
5461 * lisp.h (doprnt):
5462 * xdisp.c (vmessage):
5463 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5464 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5465 prefer signed arithmetic to avoid comparison confusion.
5466 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5467 but is a bit tricky.
5468
0e926e56
PE
5469 Assume freestanding C89 headers, string.h, stdlib.h.
5470 * data.c, doprnt.c, floatfns.c, print.c:
5471 Include float.h unconditionally.
5472 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5473 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5474 * regex.c: Likewise for stddef.h, string.h.
5475 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5476 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5477 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5478 (STDC_HEADERS): Remove obsolete defines.
5479 * sysdep.c: Include limits.h unconditionally.
5480
9cfdb3ec
PE
5481 Assume support for memcmp, memcpy, memmove, memset.
5482 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5483 * regex.c (memcmp, memcpy):
5484 Remove; we assume C89 now.
5485
5486 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5487 (__malloc_safe_bcopy): Remove; no longer needed.
5488
cf950e6b 5489 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5490 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5491 well either way, and we prefer signed to unsigned.
5492
dbf38e02
LMI
54932011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5494
5495 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5496 closes the connection while we're reading (bug#9182).
5497
d6f0886c 54982011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5499
d6f0886c
JD
5500 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5501 are specified (Bug#9168).
24e0f6b1 5502
2eb1f9e6
PE
55032011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5504
5505 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5506 Found by GCC static checking and --with-wide-int on a 32-bit host.
5507
22381272 55082011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5509
5510 * xdisp.c (compute_display_string_pos): Fix logic of caching
5511 previous display string position. Initialize cached_prev_pos to
5512 -1. Fixes slow-down at the beginning of a buffer.
5513
f25e39b4
EZ
55142011-07-24 Eli Zaretskii <eliz@gnu.org>
5515
5516 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5517 for attrs[LFACE_FONTSET_INDEX].
5518
04c4b52e
PE
55192011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 * xml.c (parse_region): Remove unused local
5522 that was recently introduced.
5523
c1734fbd
EZ
55242011-07-23 Eli Zaretskii <eliz@gnu.org>
5525
be18c5a5
EZ
5526 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5527 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5528
c1734fbd
EZ
5529 * xdisp.c (move_it_in_display_line_to): Record the best matching
5530 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5531 exit if none of the characters scanned was an exact match.
5532 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5533 when exact match is impossible due to invisible text, and the
5534 lines are truncated.
5535
a258d627
JD
55362011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5537
5538 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5539 for OSX >= 10.7.
5540
b6d5a689
EZ
55412011-07-22 Eli Zaretskii <eliz@gnu.org>
5542
0f74f785
EZ
5543 Fix a significant slow-down of cursor motion with C-n, C-p,
5544 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5545 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5546 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5547 (next_element_from_buffer): Call compute_stop_pos_backwards to
5548 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5549 base_level_stop.
5550 (reseat): Don't look for prev_stop, as that could mean a very long
5551 run.
5552 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5553 <cached_disp_overlay_modiff>: Cache for last found display string
5554 position.
551918c1 5555 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5556 about the same buffer in the same area of character positions, and
5557 the buffer wasn't changed since the time the display string
5558 position was cached.
551918c1 5559
b2d0c91a
EZ
55602011-07-22 Eli Zaretskii <eliz@gnu.org>
5561
5562 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5563 is an integer, which is important for empty lines. (Bug#9149)
5564
043604ee
CY
55652011-07-22 Chong Yidong <cyd@stupidchicken.com>
5566
5567 * frame.c (Fmodify_frame_parameters): In tty case, update the
5568 default face if necessary (Bug#4238).
5569
da4adb04
CY
55702011-07-21 Chong Yidong <cyd@stupidchicken.com>
5571
5572 * editfns.c (Fstring_to_char): No need to explain what a character
5573 is in the docstring (Bug#6576).
5574
9abd0532
LMI
55752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5576
5577 * xml.c (parse_region): Make sure we always return a tree.
5578
36881d16
HK
55792011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5580
5581 * xml.c (parse_region): If a document contains only comments,
5582 return that, too.
5583
1e98674d
LMI
55842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5585
5586 * xml.c (make_dom): Return comments, too.
5587
590bd467
PE
55882011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5589
5590 Port to OpenBSD.
5591 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5592 and the surrounding thread.
5593 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5594 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5595 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5596 timer goes off.
5597 * s/openbsd.h (BROKEN_SIGIO): Define.
5598 * unexelf.c (unexec) [__OpenBSD__]:
5599 Don't update the .mdebug section of the Alpha COFF symbol table.
5600
f41628b2
LMI
56012011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5602
5603 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5604 (bug#8460).
5605
b59b67c5
PE
56062011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5607
15e3a074
PE
5608 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5609 This fixes some race conditions on the permissions of any newly
5610 created file.
5611
41bed37d
PE
5612 * alloc.c (valid_pointer_p): Use pipe, not open.
5613 This fixes some permissions issues when debugging.
5614
b59b67c5
PE
5615 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5616 If fchown fails to set both uid and gid, try to set just gid,
5617 as that is sometimes allowed. Adjust the file's mode to eliminate
5618 setuid or setgid bits that are inappropriate if fchown fails.
5619
925a6be7
SM
56202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5621
5622 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5623 to compare Lisp_Objects.
5624 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5625 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5626 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5627
52968808
AS
56282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5629
0a6a104b
AS
5630 * lread.c (read_integer): Unread even EOF character.
5631 (read1): Likewise. Properly record start position of symbol.
5632
52968808
AS
5633 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5634 symbol character follows.
5635
9e381cdd
PE
56362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5637
5638 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5639 This works around a problem with the previous change to Fcopy_file.
5640 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5641 and without this change, GCC might complain about discarding
5642 fchown's return value.
5643
b5641435
JB
56442011-07-16 Juanma Barranquero <lekktu@gmail.com>
5645
5646 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5647
a8031457
PE
56482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5649
5650 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5651
dd889327
LMI
56522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5653
750c33f7
LMI
5654 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5655 it's used from the C level.
5656
dd889327
LMI
5657 * process.c: Use the same condition for POLL_FOR_INPUT in both
5658 keyboard.c and process.c (bug#1858).
5659
87e86684
LM
56602011-07-09 Lawrence Mitchell <wence@gmx.li>
5661
5662 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5663 (Fgnutls_boot): Use it.
5664
64348f40
AS
56652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5666
5667 * doc.c (Fsubstitute_command_keys): Revert last change.
5668
1d698799
LMI
56692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5670
f863868c
LMI
5671 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5672 quotes the next character, and doesn't affect other longer
5673 sequences (bug#8935).
5674
1d698799
LMI
5675 * lread.c (syms_of_lread): Clarify that is isn't only
5676 `eval-buffer' and `eval-defun' that's affected by
5677 `lexical-binding' (bug#8460).
5678
aa4b6df6
EZ
56792011-07-15 Eli Zaretskii <eliz@gnu.org>
5680
5681 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5682 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5683
5d856da6
PE
56842011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5685
ad6042bb
PE
5686 Fix minor problems found by static checking.
5687 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5688 (elsz): Now a signed constant, not a size_t var. We prefer signed
5689 types to unsigned, to avoid integer comparison confusion. Without
5690 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5691 "cannot optimize loop, the loop counter may overflow", a symptom
5692 of the confusion.
f00bbb22 5693 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5694 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5695
6468f31c
LMI
56962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5697
49080b10
LMI
5698 * search.c (Fre_search_backward): Mention `case-fold-search' in
5699 all the re_search_* functions (bug#8138).
5700
6468f31c
LMI
5701 * keyboard.c (Fopen_dribble_file): Document when the file is
5702 closed (bug#8056).
5703
c965adc5
EZ
57042011-07-14 Eli Zaretskii <eliz@gnu.org>
5705
df9733bf
EZ
5706 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5707 bidi_cache_idx.
5708
0bb23927
EZ
5709 Support bidi reordering of display and overlay strings.
5710 * xdisp.c (compute_display_string_pos)
5711 (compute_display_string_end): Accept additional argument STRING.
5712 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5713 (reseat_to_string): Initialize bidi_it->string.s and
5714 bidi_it->string.schars.
5715 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5716 NULL (avoids a crash in bidi_paragraph_init).
5717 Initialize itb.string.lstring.
0bb23927
EZ
5718 (init_iterator): Call bidi_init_it only of a valid
5719 buffer position was specified. Initialize paragraph_embedding to
5720 L2R.
5721 (reseat_to_string): Initialize the bidi iterator.
5722 (display_string): If we need to ignore text properties of
5723 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5724 original value of -1 will not work with bidi.)
5725 (compute_display_string_pos): First arg is now struct
5726 `text_pos *'; all callers changed. Support display properties on
5727 Lisp strings.
5728 (compute_display_string_end): Support display properties on Lisp
5729 strings.
5730 (init_iterator, reseat_1, reseat_to_string): Initialize the
5731 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5732 when iterating on a string not from display properties).
640c8776
SM
5733 (compute_display_string_pos, compute_display_string_end):
5734 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5735 arrow keys.
5736 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5737 base_level_stop; instead, set base_level_stop to BEGV.
5738 Fixes crashes in vertical-motion.
0bb23927
EZ
5739 (next_element_from_buffer): Improve commentary for when
5740 the iterator is before prev_stop.
5741 (init_iterator): Initialize bidi_p from the default value of
5742 bidi-display-reordering, not from buffer-local value. Use the
5743 buffer-local value only if initializing for buffer iteration.
5744 (handle_invisible_prop): Support invisible properties on strings
5745 that are being bidi-reordered.
5746 (set_iterator_to_next): Support bidi reordering of C strings and
5747 Lisp strings.
5748 (next_element_from_string): Support bidi reordering of Lisp
5749 strings.
5750 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5751 (display_string): Support display of R2L glyph rows.
5752 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5753 (init_iterator): Don't initialize it->bidi_p for strings
5754 here.
5755 (reseat_to_string): Initialize it->bidi_p for strings here.
5756 (next_element_from_string, next_element_from_c_string)
5757 (next_element_from_buffer): Add xassert's for correspondence
5758 between IT's object being iterated and it->bidi_it.string
5759 structure.
5760 (face_before_or_after_it_pos): Support bidi iteration.
5761 (next_element_from_c_string): Handle the case of the first string
5762 character that is not the first one in the visual order.
5763 (get_visually_first_element): New function, refactored from common
5764 parts of next_element_from_buffer, next_element_from_string, and
5765 next_element_from_c_string.
5766 (tool_bar_lines_needed, redisplay_tool_bar)
5767 (display_menu_bar): Force left-to-right direction. Add a FIXME
5768 comment for making that be controlled by a user option.
5769 (push_it, pop_it): Save and restore the state of the
5770 bidi iterator. Save and restore the bidi_p flag.
5771 (pop_it): Iterate out of display property for string iteration as
5772 well.
5773 (iterate_out_of_display_property): Support iteration over strings.
5774 (handle_single_display_spec): Set up it->bidi_it for iteration
5775 over a display string, and call bidi_init_it.
5776 (handle_single_display_spec, next_overlay_string)
5777 (get_overlay_strings_1, push_display_prop): Set up the bidi
5778 iterator for displaying display or overlay strings.
5779 (forward_to_next_line_start): Don't use the shortcut if
5780 bidi-iterating.
5781 (back_to_previous_visible_line_start): If handle_display_prop
5782 pushed the iterator stack, restore the internal state of the bidi
5783 iterator by calling bidi_pop_it same number of times.
5784 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5785 and we are bidi-iterating, don't decrement the iterator position;
5786 instead, set the first_elt flag in the bidi iterator, to produce
5787 the same effect.
5788 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5789 (push_display_prop): xassert that we are iterating a buffer.
5790 (push_it, pop_it): Save and restore paragraph_embedding member.
5791 (handle_single_display_spec, next_overlay_string)
5792 (get_overlay_strings_1, reseat_1, reseat_to_string)
5793 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5794 correctly. Don't assume unibyte strings are not bidi-reordered.
5795 (compute_display_string_pos)
5796 (compute_display_string_end): Fix handling the case of C string.
5797 (push_it, pop_it): Save and restore from_disp_prop_p.
5798 (handle_single_display_spec, push_display_prop): Set the
5799 from_disp_prop_p flag.
5800 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5801 (pop_it): Call iterate_out_of_display_property only if we are
5802 popping after iteration over a string that came from a display
5803 property. Fix a typo in popping stretch info. Add an assertion
5804 for verifying that the iterator position is in sync with the bidi
5805 iterator.
5806 (handle_single_display_spec, get_overlay_strings_1)
5807 (push_display_prop): Fix initialization of paragraph direction for
5808 string when that of the parent object is not yet determined.
5809 (reseat_1): Call bidi_init_it to resync the bidi
5810 iterator with IT's position. (Bug#7616)
5811 (find_row_edges): If ROW->start.pos gives position
5812 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5813 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5814 Reset the from_disp_prop_p flag.
5815 (SAVE_IT, RESTORE_IT): New macros.
5816 (pos_visible_p, face_before_or_after_it_pos)
5817 (back_to_previous_visible_line_start)
5818 (move_it_in_display_line_to, move_it_in_display_line)
5819 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5820 (try_scrolling, redisplay_window, display_line): Use them when
5821 saving a temporary copy of the iterator and restoring it back.
5822 (back_to_previous_visible_line_start, reseat_1)
5823 (init_iterator): Empty the bidi cache "stack".
5824 (move_it_in_display_line_to): If iterator ended up at
5825 EOL, but we never saw any buffer positions smaller than
5826 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5827 motion in bidi-reordered lines.
5828 (move_it_in_display_line_to): Record prev_method and prev_pos
5829 immediately before the call to set_iterator_to_next. Fixes cursor
5830 motion in bidi-reordered lines with stretch glyphs and strings
5831 displayed in margins. (Bug#8133) (Bug#8867)
5832 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5833 TO_CHARPOS.
640c8776
SM
5834 (pos_visible_p): Support positions in bidi-reordered lines.
5835 Save and restore bidi cache.
0bb23927
EZ
5836
5837 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5838 (bidi_paragraph_info): Delete unused struct.
5839 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5840 (bidi_cache_start): New variable.
5841 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5842 to zero.
5843 (bidi_cache_fetch_state, bidi_cache_search)
5844 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5845 (bidi_cache_find, bidi_peek_at_next_level)
5846 (bidi_level_of_next_char, bidi_find_other_level_edge)
5847 (bidi_move_to_visually_next): Compare cache index with
5848 bidi_cache_start rather than with zero.
5849 (bidi_fetch_char): Accept new argument STRING; all callers
5850 changed. Support iteration over a string. Support strings with
5851 display properties. Support unibyte strings. Fix the type of
5852 `len' according to what STRING_CHAR_AND_LENGTH expects.
5853 (bidi_paragraph_init, bidi_resolve_explicit_1)
5854 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5855 (bidi_level_of_next_char, bidi_move_to_visually_next):
5856 Support iteration over a string.
0bb23927
EZ
5857 (bidi_set_sor_type, bidi_resolve_explicit_1)
5858 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5859 can now be zero (for strings); special values 0 and -1 were
5860 changed to -1 and -2, respectively.
5861 (bidi_char_at_pos): New function.
5862 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5863 Call it instead of FETCH_MULTIBYTE_CHAR.
5864 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5865 initialized to valid values.
5866 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5867 values.
5868 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5869 the test for valid cached positions. Fix the logic for looking up
5870 the sentinel state in the cache. GCPRO the Lisp string we are
5871 iterating.
5872 (bidi_push_it, bidi_pop_it): New functions.
5873 (bidi_initialize): Initialize the bidi cache start stack pointer.
5874 (bidi_cache_ensure_space): New function, refactored from part of
5875 bidi_cache_iterator_state. Don't assume the required size is just
5876 one BIDI_CACHE_CHUNK away.
5877 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5878 (bidi_count_bytes, bidi_char_at_pos): New functions.
5879 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5880 always valid if bidi_cache_idx is valid.
5881 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5882 is valid if it's going to be used.
5883 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5884 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5885 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5886 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5887 (bidi_find_other_level_edge, bidi_cache_start_stack):
5888 All variables related to cache indices are now EMACS_INT.
c965adc5 5889
0bb23927
EZ
5890 * dispextern.h (struct bidi_string_data): New structure.
5891 (struct bidi_it): New member `string'. Make flag members be 1-bit
5892 fields, and put them last in the struct.
640c8776
SM
5893 (compute_display_string_pos, compute_display_string_end):
5894 Update prototypes.
0bb23927
EZ
5895 (bidi_push_it, bidi_pop_it): Add prototypes.
5896 (struct iterator_stack_entry): New members bidi_p,
5897 paragraph_embedding, and from_disp_prop_p.
5898 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5899 (bidi_shelve_cache, bidi_unshelve_cache):
5900 Declare prototypes.
0bb23927
EZ
5901
5902 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5903 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5904 and vector-like objects.
5905
5906 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5907 cache around display iteration.
5908
5909 * window.c (Fwindow_end, window_scroll_pixel_based)
5910 (displayed_window_lines, Frecenter): Save and restore the bidi
5911 cache around display iteration.
5912
3bbd2265
LMI
59132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5914
5915 * editfns.c (Fdelete_region): Clarify the use of the named
5916 parameters (bug#6788).
5917
adc47434
MR
59182011-07-14 Martin Rudalics <rudalics@gmx.at>
5919
5920 * indent.c (Fvertical_motion): Set and restore w->pointm when
5921 saving and restoring the window's buffer (Bug#9006).
5922
837c31f8
LMI
59232011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5924
5925 * editfns.c (Fstring_to_char): Clarify just what is returned
5926 (bug#6576). Text by Eli Zaretskii.
5927
ac389d0c
JB
59282011-07-13 Juanma Barranquero <lekktu@gmail.com>
5929
5930 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5931
0be0ce47
EZ
59322011-07-13 Eli Zaretskii <eliz@gnu.org>
5933
5934 * buffer.c (mmap_find): Fix a typo.
5935
cd18e7e3
JB
59362011-07-13 Johan Bockgård <bojohan@gnu.org>
5937
5938 Fix execution of x selection hooks.
5939 * xselect.c (Qx_lost_selection_functions)
5940 (Qx_sent_selection_functions): New vars.
5941 (syms_of_xselect): DEFSYM them.
5942 (x_handle_selection_request): Pass Qx_sent_selection_functions
5943 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5944 (x_handle_selection_clear,x_clear_frame_selections):
5945 Pass Qx_lost_selection_functions rather than
5946 Vx_lost_selection_functions to Frun_hook_with_args.
5947
47ea7f44
PE
59482011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5949
ac389d0c 5950 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5951 The old code sometimes used this field without initializing it.
5952
47ea7f44
PE
5953 * alloc.c (gc_sweep): Don't read past end of array.
5954 In theory, the old code could also have corrupted Emacs internals,
5955 though it'd be very unlikely.
5956
bc985c87
AS
59572011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5958
5959 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5960 argument. (Bug#4026)
bc985c87 5961
0cf34688
LMI
59622011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5963
b3dadd76
LMI
5964 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5965 key" (bug#4257).
5966
0cf34688
LMI
5967 * window.c (Fset_window_start): Doc fix (bug#4199).
5968 (Fset_window_hscroll): Ditto.
5969
270768cd
PE
59702011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5971
077e3dda 5972 Fix minor new problems caught by GCC 4.6.1.
270768cd 5973 * term.c (init_tty): Remove unused local.
490011a6 5974 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5975 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5976 not used otherwise.
270768cd 5977
b1f58454
CY
59782011-07-12 Chong Yidong <cyd@stupidchicken.com>
5979
5980 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5981
22b9578d
LMI
59822011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5983
6e70ab07
LMI
5984 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5985 are the mini-buffer and the echo area (bug#3320).
5986
22b9578d
LMI
5987 * term.c (init_tty): Remove support for supdup, c10 and perq
5988 terminals, which are no longer supported (bug#1482).
5989
8974cc9f
JB
59902011-07-10 Johan Bockgård <bojohan@gnu.org>
5991
5992 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5993
a560d974
JD
59942011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5995
5996 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5997 for non-popups (Bug#3642).
5998
1dae0f0a
AS
59992011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6000
268c2c36 6001 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6002 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6003 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6004 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6005 * data.c (fmod): Likewise.
6006 * dispnew.c (swap_glyphs_in_rows): Likewise.
6007 * emacs.c (memory_warning_signal): Likewise.
6008 * floatfns.c (float_error): Likewise.
6009 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6010 (otf_open, font_otf_capability, generate_otf_features)
6011 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6012 Likewise.
6013 * image.c (pbm_read_file): Likewise.
6014 * indent.c (string_display_width): Likewise.
6015 * intervals.c (check_for_interval, search_for_interval)
6016 (inc_interval_count, count_intervals, root_interval)
6017 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6018 * lread.c (defalias): Likewise.
268c2c36 6019 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6020 * regex.c (set_image_of_range_1, set_image_of_range)
6021 (regex_grow_registers): Likewise.
6022 * sysdep.c (strerror): Likewise.
6023 * termcap.c (valid_filename_p, tprint, main): Likewise.
6024 * tparam.c (main): Likewise.
6025 * unexhp9k800.c (run_time_remap, save_data_space)
6026 (update_file_ptrs, read_header, write_header, calculate_checksum)
6027 (copy_file, copy_rest, display_header): Likewise.
6028 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6029 Likewise.
6030 * xdisp.c (check_it): Likewise.
6031 * xfaces.c (register_color, unregister_color, unregister_colors):
6032 Likewise.
6033 * xfns.c (print_fontset_result): Likewise.
6034 * xrdb.c (member, fatal, main): Likewise.
6035
99033785
PE
60362011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6037
6038 Fix minor problems found by static checking (Bug#9031).
6039 * chartab.c (char_table_set_range, map_sub_char_table):
6040 Remove unused locals.
6041 (uniprop_table): Now static.
6042 * composite.c (_work_char): Remove unused static var.
6043
9cb2ac56
JB
60442011-07-09 Juanma Barranquero <lekktu@gmail.com>
6045
6046 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6047
f25661f0
JD
60482011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6049
6050 * gtkutil.c (qttip_cb): Remove code without function.
6051
8278c4fe
EZ
60522011-07-09 Eli Zaretskii <eliz@gnu.org>
6053
6054 * w32.c (pthread_sigmask): New stub.
6055
1692ae2d 60562011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6057
8a6ebd58 6058 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6059 sigprocmask is portable only for single-threaded applications, and
6060 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6061 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6062 (LIBES): Use it.
6063 * callproc.c (Fcall_process):
6064 * process.c (create_process):
6065 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6066 Use pthread_sigmask, not sigprocmask.
123403e4 6067
1b854618
JD
60682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6069
6070 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6071 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6072 wrong (Bug#8591).
6073
3fe4b549
JD
60742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6075
0ce7e563
JD
6076 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6077 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6078 (xg_hide_tooltip): Fix comment.
6079
3fe4b549
JD
6080 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6081 in registerServicesMenuSendTypes.
6082 (validRequestorForSendType): Don't check ns_return_types.
6083
6084 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6085 ns_return_type.
6086
5df75e47
JR
60872011-07-08 Jason Rumney <jasonr@gnu.org>
6088
22610910
JR
6089 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6090 SH_SHOW for hidden windows (Bug#5482).
6091
5df75e47
JR
6092 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6093 frame struct members of non-existent frames (Bug#6284).
6094
699c10bd
JD
60952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6096
4393663b
JD
6097 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6098 variable firstTime not needed on OSX >= 10.6.
6099 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6100 >= 10.5. Use setKnobProportion, setDoubleValue.
6101
6102 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6103 (MAC_OS_X_VERSION_10_5): Define if not defined.
6104 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6105 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6106 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6107
6108 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6109 cString and lossyCString on OSX >= 10.4
6110
58179cce 6111 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6112 sizeToFit on OSX >= 10.2.
6113
6114 * nsimage.m (allocInitFromFile): Don't use deprecated method
6115 bestRepresentationForDevice on OSX >= 10.6.
6116
6117 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6118 to avoid warning.
6119
6120 * emacs.c: Declare unexec_init_emacs_zone.
6121
a63e0781
JD
6122 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6123
699c10bd
JD
6124 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6125
6126 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6127 on svcsMenu (Bug#8842).
6128
6129 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6130 ns_return_types.
6131 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6132
6133 * nsterm.m (QUTF8_STRING): Declare.
6134 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6135 (validRequestorForSendType): Return type is (id).
6136 Change indexOfObjectIdenticalTo to indexOfObject.
6137 Check if we have local selection before returning self (Bug#8842).
6138 (writeSelectionToPasteboard): Put local selection into paste board
6139 if we have a local selection (Bug#8842).
6140 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6141
6142 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6143 (ns_get_local_selection): Declare.
6144
54e10184
LMI
61452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6146
9888ff71
LMI
6147 * keymap.c (describe_map_tree): Don't insert a double newline at
6148 the end of the buffer (bug#1169) and return whether we inserted
6149 something.
6150
54e10184
LMI
6151 * callint.c (Fcall_interactively): Change "reading args" to
6152 "providing args" to try to clarify what it does (bug#1010).
6153
15fa4783
KH
61542011-07-07 Kenichi Handa <handa@m17n.org>
6155
6156 * composite.c (composition_compute_stop_pos): Ignore a static
6157 composition starting before CHARPOS (Bug#8915).
6158
6159 * xdisp.c (handle_composition_prop): Likewise.
6160
a8815b00
EZ
61612011-07-07 Eli Zaretskii <eliz@gnu.org>
6162
6163 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6164 (Bug#9015)
6165
ef7b981d 61662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6167
6168 * character.h (unicode_category_t): New enum type.
6169
6170 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6171 (Qchar_code_property_table): New variable.
6172 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6173 (UNIPROP_COMPRESSED_FORM_P): New macros.
6174 (char_table_ascii): Uncompress the compressed values.
6175 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6176 Uncompress the compressed values.
ac389d0c 6177 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6178 (char_table_ref_and_range): Uncompress the compressed values.
6179 (sub_char_table_set): New arg is_uniprop. Callers changed.
6180 Uncompress the compressed values.
6181 (sub_char_table_set_range): Args changed. Callers changed.
6182 (char_table_set_range): Adjuted for the above change.
6183 (map_sub_char_table): Delete args default_val and parent. Add arg
6184 top. Give decoded values to a Lisp function.
640c8776 6185 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6186 values to a Lisp function. Gcpro more variables.
6187 (uniprop_table_uncompress)
6188 (uniprop_decode_value_run_length): New functions.
6189 (uniprop_decoder, uniprop_decoder_count): New variables.
6190 (uniprop_get_decoder, uniprop_encode_value_character)
6191 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6192 New functions.
6193 (uniprop_encoder, uniprop_encoder_count): New variables.
6194 (uniprop_get_encoder, uniprop_table)
6195 (Funicode_property_table_internal, Fget_unicode_property_internal)
6196 (Fput_unicode_property_internal): New functions.
6197 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6198 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6199 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6200 char-code-property-alist.
6201
640c8776 6202 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6203 Vunicode_category_table.
6204
640c8776 6205 * font.c (font_range): Adjust for the change of
c805dec0
KH
6206 Vunicode_category_table.
6207
76b397fb
DN
62082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6209
6210 * m/iris4d.h: Remove file, move contents ...
6211 * s/irix6-5.h: ... here.
6212
22b4128e
PE
62132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6214
6215 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6216 * alloc.c (mark_buffer):
6217 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6218 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6219 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6220 This isn't true in general, and it's particularly not true
6221 if Emacs is configured with --with-wide-int.
6222 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6223 New macros, used in the buffer.c change.
6224
869795d6
JD
62252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6226
6227 * xsettings.c: Use both GConf and GSettings if both are available.
6228 (store_config_changed_event): Add comment.
6229 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6230 (store_tool_bar_style_changed): New functions.
5e617bc2 6231 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6232 (struct xsettings): Move font inside HAVE_XFT.
6233 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6234 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6235 Move inside HAVE_XFT.
640c8776 6236 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6237 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6238 also.
6239 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6240 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6241 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6242 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6243 (parse_settings): Move check for font inside HAVE_XFT.
6244 (read_settings, apply_xft_settings): Add comment.
6245 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6246 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6247 call store_font_name_changed.
6248 (xft_settings_event): Add comment.
6249 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6250 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6251 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6252 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6253 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6254 (xsettings_get_system_font, xsettings_get_system_normal_font):
6255 Add comment.
869795d6 6256
d8ed26bd
PE
62572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6258
6259 Random fixes. E.g., (random) never returned negative values.
6260 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6261 subseconds part to the entropy, as that's a bit more random.
6262 Prefer signed to unsigned, since the signedness doesn't matter and
6263 in general we prefer signed. When given a limit, use a
6264 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6265 latter isn't right if USE_2_TAGS_FOR_INTS.
6266 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6267 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6268
cabf1cac
SM
62692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6270
6271 * textprop.c (text_property_stickiness):
6272 Obey Vtext_property_default_nonsticky.
6273 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6274 * w32fns.c (syms_of_w32fns):
6275 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6276
6e9b2be9
PE
62772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6280 This is more efficient than Ffile_directory_p and avoids a minor race.
6281
90186c68
LMI
62822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6283
7c301272
LMI
6284 * buffer.c (Foverlay_put): Say what the return value is
6285 (bug#7835).
6286
c4f2d8d4
LMI
6287 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6288 is a directory before asking whether to use the file name
6289 (bug#7564).
ad637907
LMI
6290 (barf_or_query_if_file_exists): Make the "File is a directory"
6291 error be more correct.
c4f2d8d4 6292
90186c68
LMI
6293 * fns.c (Frequire): Remove the mention of the .gz files, since
6294 that's installation-specific, but keep the mention of
6295 `get-load-suffixes'.
6296
da64016e
PE
62972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6298
6299 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6300 Report string overflow if the output is too long.
6301
7d47b580
JB
63022011-07-04 Juanma Barranquero <lekktu@gmail.com>
6303
a555cb87
JB
6304 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6305 (syms_of_gnutls): Remove duplicate DEFSYM for
6306 Qgnutls_bootprop_verify_hostname_error, an error for
6307 Qgnutls_bootprop_verify_error (which is no longer used).
6308
7d47b580
JB
6309 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6310 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6311 Also (re)move comments that are misplaced or no longer relevant.
6312
1e49bfab
LMI
63132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6314
6315 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6316
1485f4c0
CY
63172011-07-03 Chong Yidong <cyd@stupidchicken.com>
6318
6319 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6320 and background color parameters if they have been changed.
6321
a9ab721e
LMI
63222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6323
6324 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6325
cf7cff57
PE
63262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6327
2e13213d
PE
6328 * xsettings.c (SYSTEM_FONT): Define only when used.
6329 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6330
cf7cff57
PE
6331 * keymap.c (access_keymap_1): Now static.
6332
7a8e04f7
CY
63332011-07-02 Chong Yidong <cyd@stupidchicken.com>
6334
6335 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6336 leave any prefix arg for the up event (Bug#1586).
6337
61352f62
LMI
63382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6339
69bb1ef7
LMI
6340 * lread.c (syms_of_lread): Mention single symbols defined by
6341 `defvar' or `defconst' (bug#7154).
6342
61352f62 6343 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6344 (Frequire): Mention get-load-suffixes.
61352f62 6345
28545e04
MR
63462011-07-02 Martin Rudalics <rudalics@gmx.at>
6347
6348 * window.h (window): Remove clone_number slot.
6349 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6350 Remove.
6351 (make_parent_window, make_window, saved_window)
6352 (Fset_window_configuration, save_window_save): Don't deal with
6353 clone numbers.
6354 * buffer.c (Qclone_number): Remove declaration.
6355 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6356
3349e122
SM
63572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6358
6359 Add multiple inheritance to keymaps.
6360 * keymap.c (Fmake_composed_keymap): New function.
6361 (Fset_keymap_parent): Simplify.
6362 (fix_submap_inheritance): Remove.
6363 (access_keymap_1): New function extracted from access_keymap to handle
6364 embedded parents and handle lists of maps.
6365 (access_keymap): Use it.
6366 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6367 (Fcopy_keymap): Handle embedded parents.
6368 (Fcommand_remapping, define_as_prefix): Simplify.
6369 (Fkey_binding): Simplify.
6370 (syms_of_keymap): Move minibuffer-local-completion-map,
6371 minibuffer-local-filename-completion-map,
6372 minibuffer-local-must-match-map, and
6373 minibuffer-local-filename-must-match-map to Elisp.
6374 (syms_of_keymap): Defsubr make-composed-keymap.
6375 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6376 (parse_menu_item): Trivial simplification.
6377
3279eb87
GM
63782011-07-01 Glenn Morris <rgm@gnu.org>
6379
6380 * Makefile.in (SETTINGS_LIBS): Fix typo.
6381
4550efdf
KI
63822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6383
6384 * coding.c (Fencode_coding_string): Record the last coding system
6385 used, as the function doc string says (bug#8738).
6386
0949d2b6
JD
63872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6388
6389 * xsettings.c (store_monospaced_changed): Take new font as arg and
6390 check for change against current_mono_font.
6391 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6392 (emacs_settings_constructor, emacs_settings_get_property)
6393 (emacs_settings_set_property, emacs_settings_class_init)
6394 (emacs_settings_init, gsettings_obj): Remove.
6395 (something_changedCB): New function for HAVE_GSETTINGS.
6396 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6397 with value as argument.
6398 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6399 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6400 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6401 "changed".
6402
6403 * xgselect.c: Add defined (HAVE_GSETTINGS).
6404 (xgselect_initialize): Ditto.
6405
6406 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6407 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6408 xg_select.
6409
bbc6b304
PE
64102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 * eval.c (struct backtrace): Simplify and port the data structure.
6413 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6414 signed bit field, as this assumption is not portable and it makes
6415 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6416 "char debug_on_exit : 1" as this is not portable either; instead,
6417 use the portable "unsigned int debug_on_exit : 1". Remove unused
6418 member evalargs. Remove obsolete comments about cc bombing out.
6419
9851bfc5
JD
64202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6421
51bb811f 6422 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6423 Let HAVE_GSETTINGS override HAVE_GCONF.
6424 (store_monospaced_changed): New function.
6425 (EMACS_SETTINGS): A new type derived from GObject to handle
6426 GSettings notifications.
6427 (emacs_settings_constructor, emacs_settings_get_property)
6428 (emacs_settings_set_property, emacs_settings_class_init):
6429 New functions.
6430 (gsettings_client, gsettings_obj): New variables.
6431 (GSETTINGS_SCHEMA): New define.
6432 (something_changedCB): Call store_monospaced_changed.
6433 (init_gsettings): New function.
6434 (xsettings_initialize): Call init_gsettings.
6435 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6436 to NULL.
6437
640c8776 6438 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6439 GCONF_CFLAGS/LIBS.
6440
5386012d
MR
64412011-06-29 Martin Rudalics <rudalics@gmx.at>
6442
6443 * window.c (resize_root_window, grow_mini_window)
6444 (shrink_mini_window): Rename Qresize_root_window to
6445 Qwindow_resize_root_window and Qresize_root_window_vertically to
6446 Qwindow_resize_root_window_vertically.
6447
f13e0b08
PE
64482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6449
6450 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6451
94515237
JB
64522011-06-27 Juanma Barranquero <lekktu@gmail.com>
6453
6454 * makefile.w32-in: Redesign dependencies so they reflect more
6455 clearly which files are directly included by each source file,
6456 and not through other includes.
6457
e43b6e43
MR
64582011-06-27 Martin Rudalics <rudalics@gmx.at>
6459
6460 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6461 (sort_overlays, overlay_strings): When an overlay's clone number
6462 matches the window's clone number process the overlay even if
6463 the overlay's window property doesn't match the current window.
6464
d68443dc
MR
6465 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6466 (Fwindow_hchild): Rename to Fwindow_left_child.
6467 (Fwindow_next): Rename to Fwindow_next_sibling.
6468 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6469 (resize_window_check): Rename to window_resize_check.
6470 (resize_window_apply): Rename to window_resize_apply.
6471 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6472 (Fdelete_other_windows_internal, resize_frame_windows)
6473 (Fsplit_window_internal, Fdelete_window_internal)
6474 (grow_mini_window, shrink_mini_window)
6475 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6476
c7e73be5
JD
64772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6478
6479 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6480 (emacs_fixed_set_min_size): Remove.
6481 (emacs_fixed_new): Take frame as argument.
6482
6483 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6484 (_EmacsFixedPrivate): Remove minwidth/height.
6485 Add struct frame *f.
6486 (emacs_fixed_init): Initialize priv->f.
6487 (get_parent_class, emacs_fixed_set_min_size): Remove.
6488 (emacs_fixed_new): Set priv->f to argument.
6489 (emacs_fixed_get_preferred_width)
6490 (emacs_fixed_get_preferred_height): Use min_width/height from
6491 frames size_hint to set minimum and natural (Bug#8919).
6492 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6493 and use min_width/height from frames size_hint to set
6494 min_width/height (Bug#8919).
6495
6496 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6497 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6498 Fix indentation.
c7e73be5 6499
cf99dcf8
EZ
65002011-06-26 Eli Zaretskii <eliz@gnu.org>
6501
6502 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6503 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6504 called at ZV.
6505
029529ac
CY
65062011-06-26 Chong Yidong <cyd@stupidchicken.com>
6507
6508 * process.c (wait_reading_process_output): Bypass select if
6509 waiting for a cell while ignoring keyboard input, and input is
6510 pending. Suggested by Jan Djärv (Bug#8869).
6511
7a7ef429
PE
65122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6513
6514 Use gnulib's dup2 module instead of rolling our own.
6515 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6516
11fdef7d 65172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6518
6519 * dispnew.c (scrolling_window): Before scrolling, turn off a
6520 mouse-highlight in the window being scrolled.
6521
cd3520a4
JB
65222011-06-24 Juanma Barranquero <lekktu@gmail.com>
6523
6524 Move DEFSYM to lisp.h and use everywhere.
6525
6526 * character.h (DEFSYM): Move declaration...
6527 * lisp.h (DEFSYM): ...here.
6528
6529 * gnutls.c:
6530 * minibuf.c:
6531 * w32menu.c:
6532 * w32proc.c:
6533 * w32select.c: Don't include character.h.
6534
6535 * alloc.c (syms_of_alloc):
6536 * buffer.c (syms_of_buffer):
6537 * bytecode.c (syms_of_bytecode):
6538 * callint.c (syms_of_callint):
6539 * casefiddle.c (syms_of_casefiddle):
6540 * casetab.c (init_casetab_once):
6541 * category.c (init_category_once, syms_of_category):
6542 * ccl.c (syms_of_ccl):
6543 * cmds.c (syms_of_cmds):
6544 * composite.c (syms_of_composite):
6545 * dbusbind.c (syms_of_dbusbind):
6546 * dired.c (syms_of_dired):
6547 * dispnew.c (syms_of_display):
6548 * doc.c (syms_of_doc):
6549 * editfns.c (syms_of_editfns):
6550 * emacs.c (syms_of_emacs):
6551 * eval.c (syms_of_eval):
6552 * fileio.c (syms_of_fileio):
6553 * fns.c (syms_of_fns):
6554 * frame.c (syms_of_frame):
6555 * fringe.c (syms_of_fringe):
6556 * insdel.c (syms_of_insdel):
6557 * keymap.c (syms_of_keymap):
6558 * lread.c (init_obarray, syms_of_lread):
6559 * macros.c (syms_of_macros):
6560 * msdos.c (syms_of_msdos):
6561 * print.c (syms_of_print):
6562 * process.c (syms_of_process):
6563 * search.c (syms_of_search):
6564 * sound.c (syms_of_sound):
6565 * syntax.c (init_syntax_once, syms_of_syntax):
6566 * terminal.c (syms_of_terminal):
6567 * textprop.c (syms_of_textprop):
6568 * undo.c (syms_of_undo):
6569 * w32.c (globals_of_w32):
6570 * window.c (syms_of_window):
6571 * xdisp.c (syms_of_xdisp):
6572 * xfaces.c (syms_of_xfaces):
6573 * xfns.c (syms_of_xfns):
6574 * xmenu.c (syms_of_xmenu):
6575 * xsettings.c (syms_of_xsettings):
6576 * xterm.c (syms_of_xterm): Use DEFSYM.
6577
4228cf16
TZ
65782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6579
cd3520a4 6580 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6581
7fcccf1e
PE
65822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6583
7efb4e0e
PE
6584 Integer and buffer overflow fixes (Bug#8873).
6585
ff5844ad
PE
6586 * print.c (printchar, strout): Check for string overflow.
6587 (PRINTPREPARE, printchar, strout):
6588 Don't set size unless allocation succeeds.
6589
90532f02
PE
6590 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6591 for sizes. Check for string overflow more accurately.
6592 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6593
6d84508d
PE
6594 * macros.c: Integer and buffer overflow fixes.
6595 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6596 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6597 Use ptrdiff_t, not int, for sizes.
6598 Don't increment bufsize until after realloc succeeds.
6599 Check for size-calculation overflow.
6600 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6601
437b2cb4
PE
6602 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6603
8b9ac8b4
PE
6604 * lread.c: Integer overflow fixes.
6605 (read_integer): Radix is now EMACS_INT, not int,
6606 to improve quality of diagnostics for out-of-range radices.
6607 Calculate buffer size correctly for out-of-range radices.
6608 (read1): Check for integer overflow in radices, and in
6609 read-circle numbers.
82cb60d3
PE
6610 (read_escape): Avoid int overflow.
6611 (Fload, openp, read_buffer_size, read1)
6612 (substitute_object_recurse, read_vector, read_list, map_obarray):
6613 Use ptrdiff_t, not int, for sizes.
6614 (read1): Use EMACS_INT, not int, for sizes.
20270765 6615 Check for size overflow.
8b9ac8b4 6616
7fcccf1e
PE
6617 * image.c (cache_image): Check for size arithmetic overflow.
6618
bfbbd7e7
PE
6619 * lread.c: Integer overflow issues.
6620 (saved_doc_string_size, saved_doc_string_length)
6621 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6622 Now ptrdiff_t, not int.
6623 (read1): Don't assume doc string length fits in int. Check for
6624 out-of-range doc string lengths.
6625 (read_list): Don't assume file position fits in int.
39019e54 6626 (read_escape): Check for hex character overflow.
bfbbd7e7 6627
4e323265
LL
66282011-06-22 Leo Liu <sdl.web@gmail.com>
6629
6630 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6631 Move to minibuffer.el.
6632
85fece3e
PE
66332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6634
20b84ce9 6635 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6636 The following patches are for when GLYPH_DEBUG && !XASSERT.
6637 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6638 * dispnew.c (flush_stdout):
6639 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6640 Mark as externally visible.
6641 * dispnew.c (check_window_matrix_pointers): Now static.
6642 * dispnew.c (window_to_frame_vpos):
6643 * xfns.c (unwind_create_frame):
6644 * xterm.c (x_check_font): Remove unused local.
6645 * scroll.c (CHECK_BOUNDS):
6646 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6647 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6648 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6649 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6650 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6651 Now static.
6652 (debug_method_add): Use va_list and vsprintf rather than relying
6653 on undefined behavior with wrong number of arguments.
6654 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6655 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6656 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6657 since we're not interested in debugging glyphs with old libraries.
6658 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6659 GCC 4.6.0's static checking.
6660
0766b489
PE
66612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6662
31fd4b32
PE
6663 Integer overflow and signedness fixes (Bug#8873).
6664 A few related buffer overrun fixes, too.
6665
b79e8648
PE
6666 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6667
0766b489
PE
6668 * dispextern.h (struct face.stipple):
6669 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6670 (x_bitmap_mask, x_allocate_bitmap_record)
6671 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6672 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6673 (x_create_bitmap_from_xpm_data):
6674 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6675 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6676 (.bitmaps_last):
6677 * xfaces.c (load_pixmap):
6678 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6679 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6680 (.bitmaps_last, struct x_output.icon_bitmap):
6681 Use ptrdiff_t, not int, for bitmap indexes.
6682 (x_allocate_bitmap_record): Check for size overflow.
6683 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6684
b081724f
PE
6685 Use ptrdiff_t, not int, for overlay counts.
6686 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6687 * editfns.c (overlays_around, get_pos_property):
6688 * textprop.c (get_char_property_and_overlay):
6689 * xdisp.c (next_overlay_change, note_mouse_highlight):
6690 * xfaces.c (face_at_buffer_position):
21514da7
PE
6691 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6692 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6693 (Fnext_overlay_change, Fprevious_overlay_change)
6694 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6695 Use ptrdiff_t, not int, for sizes.
21514da7 6696 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6697
3de73e5e
PE
6698 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6699
2606c57b
PE
6700 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6701 (x_session_initialize): Do not assume string length fits in int.
6702
aaafe47a
PE
6703 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6704 This is unlikely, but can occur if DPI is outlandish.
6705
2674ddc8 6706 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6707 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6708
28154962
PE
6709 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6710 * xrdb.c (magic_file_p, search_magic_path):
6711 Omit last arg SUFFIX; it was always 0. All callers changed.
6712 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6713
7de51af5
PE
6714 * xfont.c (xfont_match): Avoid need for strlen.
6715
25ed6cc3
PE
6716 * xfns.c: Don't assume strlen fits in int.
6717 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6718
4eab31dd
PE
6719 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6720 not unsigned long, as we prefer signed integers. All callers changed.
6721 Detect integer overflow in repeat count.
6722 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6723 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6724
171e2a58
PE
6725 * termcap.c: Don't assume sizes fit in int and never overflow.
6726 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6727 (gobble_line): Check for size-calculation overflow.
6728
ad39faca 6729 * minibuf.c (Fread_buffer):
6e5bb2dc 6730 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6731 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6732 Don't assume string length fits in int.
6733
52c61c22 6734 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6735 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6736
b5b8c9e5
PE
6737 * font.c: Don't assume string length fits in int.
6738 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6739 Use ptrdiff_t, not int.
ccd6111c
PE
6740 (font_intern_prop): Don't assume string length fits in int.
6741 Don't assume integer property fits in fixnum.
6742 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6743
882f0d81 6744 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6745 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6746 Reformulate so as not to need the command string.
6747 Invoke gzip -cd rather than gunzip, as it's more portable.
6748 (lock_info_type, lock_file_1, lock_file):
6749 Don't assume pid_t and time_t fit in unsigned long.
6750 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6751 (current_lock_owner): Prefer signed type for sizes.
6752 Use memcpy, not strncpy, where memcpy is what is really wanted.
6753 Don't assume (via atoi) that time_t and pid_t fit in int.
6754 Check for time_t and/or pid_t out of range, e.g., via a network share.
6755 Don't alloca where an auto var works fine.
6756
93f4cf88
PE
6757 * fileio.c: Fix some integer overflow issues.
6758 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6759 Don't assume string length fits in int.
6760 (directory_file_name): Don't assume string length fits in long.
6761 (make_temp_name): Don't assume pid fits in int, or that its print
6762 length is less than 20.
6763
f3e92b69
PE
6764 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6765
1bfdaf10
PE
6766 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6767
35016e9a
PE
6768 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6769
3d1e65a1
PE
6770 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6771 We prefer signed integers, even for size calculations.
6772
0b963a93
PE
6773 * emacs.c: Don't assume string length fits in 'int'.
6774 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6775 (main): Don't invoke strlen when not needed.
6776
573f4b54
PE
6777 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6778 (XD_DEBUG_MESSAGE): Don't waste a byte.
6779
989f33ba
PE
6780 * callproc.c (getenv_internal_1, getenv_internal)
6781 (Fgetenv_internal):
965d34eb
PE
6782 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6783
e4d29b33
PE
6784 * lread.c (invalid_syntax): Omit length argument.
6785 All uses changed. This doesn't fix a bug, but it simplifies the
6786 code away from its former Hollerith-constant appearance, and it's
6787 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6788 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6789
eb49b136
PE
6790 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6791 This didn't break anything, but it didn't help either.
6792 It's confusing to put a bogus integer in a place where the actual
6793 value does not matter.
9f62aeb1 6794 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6795 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6796
15375a22
PE
6797 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6798 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6799 implementation.
b61cc01c
PE
6800 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6801 We prefer signed types, and the value cannot exceed the EMACS_INT
6802 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6803 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6804 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6805 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6806
53b2623d
PE
6807 * indent.c (sane_tab_width): New function.
6808 (current_column, scan_for_column, Findent_to, position_indentation)
6809 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6810 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6811
51cab52b 6812 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6813
f2ed8a70
PE
6814 * lisp.h (lint_assume): New macro.
6815 * composite.c (composition_gstring_put_cache):
6816 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6817
abe80cc6
PE
6818 * editfns.c, insdel.c:
6819 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6820
b02c740e
PE
6821 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6822
ebc96716
PE
6823 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6824
b4e50fa0 6825 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6826 Use much-faster test for byte-length change.
311d5d7c 6827 Don't assume string byte-length fits in 'int'.
a4cf38e4 6828 Check that character arg fits in 'int'.
85461888 6829 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6830
c0c1ee9f
PE
6831 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6832
a498d7f4
PE
6833 * fns.c (concat): Catch string overflow earlier.
6834 Do not rely on integer wraparound.
6835
51cab52b
PE
6836 * dispextern.h (struct it.overlay_strings_charpos)
6837 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6838 * xdisp.c (forward_to_next_line_start)
6839 (back_to_previous_visible_line_start)
6840 (reseat_at_next_visible_line_start, next_element_from_buffer):
6841 Don't arbitrarily truncate the value of 'selective' to int.
6842
76031fad
PE
6843 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6844
5eb55db9
PE
6845 * composite.c: Don't truncate sizes to 'int'.
6846 (composition_gstring_p, composition_reseat_it)
6847 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6848 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6849 not EMACS_UINT, for indexes.
5eb55db9 6850
0703a717
PE
6851 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6852
d6202519
PE
6853 * buffer.c: Include <verify.h>.
6854 (struct sortvec.priority, struct sortstr.priority):
8961a454 6855 Now EMACS_INT, not int.
c20998a7 6856 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6857 (struct sortstr.size, record_overlay_string)
6858 (struct sortstrlist.size, struct sortlist.used):
6859 Don't truncate size to int.
6860 (record_overlay_string): Check for size-calculation overflow.
d6202519 6861 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6862
d5a19415
JM
68632011-06-22 Jim Meyering <meyering@redhat.com>
6864
029529ac 6865 Don't leak an XBM-image-sized buffer
d5a19415
JM
6866 * image.c (xbm_load): Free the image buffer after using it.
6867
a9041e6c
PE
68682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6869
6870 Port to Sun C.
6871 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6872 that Sun C diagnosed.
6873 * fns.c (secure_hash): Fix pointer signedness issue.
6874 * intervals.c (static_offset_intervals): New function.
6875 (offset_intervals): Use it.
6876
7f3f739f
LL
68772011-06-21 Leo Liu <sdl.web@gmail.com>
6878
6879 * deps.mk (fns.o):
6880 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6881 sha512.h.
6882
6883 * fns.c (secure_hash): Rename from crypto_hash_function and change
6884 the first arg to accept symbols.
5b66d427 6885 (Fsecure_hash): New primitive.
7f3f739f
LL
6886 (syms_of_fns): New symbols.
6887
76147d94
DD
68882011-06-20 Deniz Dogan <deniz@dogan.se>
6889
6890 * process.c (Fset_process_buffer): Clarify return value in
6891 docstring.
6892
7d7d0045
CY
68932011-06-18 Chong Yidong <cyd@stupidchicken.com>
6894
6895 * dispnew.c (add_window_display_history): Use BVAR.
6896
6897 * xdisp.c (debug_method_add): Use BVAR.
6898 (check_window_end, dump_glyph_matrix, dump_glyph)
6899 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6900
6901 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6902 Likewise.
6903
6904 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6905 check till after the cache is created in init_frame_faces.
6906
ff2bc410
SM
69072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6908
6909 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6910
28177add
PE
69112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6912
dd3482fe
PE
6913 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6914 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6915 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6916
393d71f3 6917 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6918 * fileio.c (Finsert_file_contents):
6919 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6920 Remove the old (too-loose) buffer overflow checks.
6921 They weren't needed, since make_gap checks for buffer overflow.
6922 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6923 The old code merely checked for Emacs fixnum overflow, and relied
6924 on undefined (wraparound) behavior. The new code avoids undefined
6925 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6926
2e6813b0 6927 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6928 Tune. Don't use wider integers than needed. Don't use alloca.
6929 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6930
599a9e4f
PE
6931 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6932
99561444
PE
6933 * insdel.c, lisp.h (buffer_overflow): New function.
6934 (insert_from_buffer_1, replace_range, replace_range_2):
6935 * insdel.c (make_gap_larger):
6936 * editfns.c (Finsert_char):
6937 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6938
28177add
PE
6939 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6940
e69dafad
PE
69412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6942
4baa020d 6943 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6944
b1c46f02
PE
6945 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6946 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6947
e69dafad
PE
6948 * fileio.c: Don't assume EMACS_INT fits in off_t.
6949 (emacs_lseek): New static function.
6950 (Finsert_file_contents, Fwrite_region): Use it.
6951 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6952
566684ea
PE
6953 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6954
e6966cd6
PE
6955 * fns.c: Don't overflow int when computing a list length.
6956 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6957 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6958 truncation on 64-bit hosts. Check for QUIT every
6959 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6960 faster and is responsive enough.
6961 (Flength): Report an error instead of overflowing an integer.
6962 (Fsafe_length): Return a float if the value is not representable
6963 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6964 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6965 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6966
dd0b0efb
PE
6967 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6968 (header_size, word_size): New constants.
6969 (allocate_vectorlike): Don't check size overflow here.
6970 (allocate_vector): Check it here instead, since this is the only
6971 caller of allocate_vectorlike that could cause overflow.
6972 Check that the new vector's length is representable as a fixnum.
6973
86fe5cfe
PE
6974 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6975 The previous code was bogus. For example, next_almost_prime (32)
6976 returned 39, which is undesirable as it is a multiple of 3; and
6977 next_almost_prime (24) returned 25, which is a multiple of 5 so
6978 why was the code bothering to check for multiples of 7?
6979
80e88859
PE
6980 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6981
4a2f0ad6
PE
6982 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6983
f66c7cf8
PE
6984 Variadic C functions now count arguments with ptrdiff_t.
6985 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6986 Back then I didn't know that the Emacs coding style prefers signed int.
6987 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6988 were being counted with int, which may truncate counts on 64-bit
6989 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6990 * lisp.h (struct Lisp_Subr.function.aMANY)
6991 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6992 Arg counts are now ptrdiff_t, not size_t.
6993 All variadic functions and their callers changed accordingly.
6994 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6995 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6996 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6997 * callint.c (Fcall_interactively): Check arg count for overflow,
6998 to avoid potential buffer overrun. Use signed char, not 'int',
6999 for 'varies' array, so that we needn't bother to check its size
7000 calculation for overflow.
7001 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7002 * eval.c (apply_lambda):
7003 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7004 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7005 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7006
a1759b76
PE
7007 * callint.c (Fcall_interactively): Don't use index var as event count.
7008
d96be9fc
PE
7009 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7010 * mem-limits.h (SIZE): Remove; no longer used.
7011
a690a978 7012 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7013
578c21e6
PE
7014 Remove unnecessary casts.
7015 * xterm.c (x_term_init):
7016 * xfns.c (x_set_border_pixel):
7017 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7018 These aren't needed now that we assume ANSI C.
7019
96f53c6c
PE
7020 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7021 It's more likely to cause problems (due to unsigned overflow)
7022 than to cure them.
7023
83c77d31
PE
7024 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7025
ee2079f1
PE
7026 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7027
6da65536
PE
7028 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7029
7147c4a4
PE
7030 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7031
193e32d9
PE
7032 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7033
e5533da6
PE
7034 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7035
9910e595
PE
7036 GLYPH_CODE_FACE returns EMACS_INT, not int.
7037 * dispextern.h (merge_faces):
7038 * xfaces.c (merge_faces):
01103c44
PE
7039 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7040 Don't assume EMACS_INT fits in int.
9910e595 7041
2638320e
PE
7042 * character.h (CHAR_VALID_P): Remove unused parameter.
7043 * fontset.c, lisp.h, xdisp.c: All uses changed.
7044
045eb8d9
PE
7045 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7046
c1f134b5
PE
7047 * fns.c (concat): Minor tuning based on overflow analysis.
7048 This doesn't fix any bugs. Use int to hold character, instead
7049 of constantly refetching from Emacs object. Use XFASTINT, not
7050 XINT, for value known to be a character. Don't bother comparing
7051 a single byte to 0400, as it's always less.
7052
395fcb93 7053 * floatfns.c (Fexpt):
327eeec8
PE
7054 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7055
abbd3d23
PE
7056 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7057 for characters.
7058
684a03ef
PE
7059 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7060
0fed43f3
PE
7061 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7062 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7063 incorrectly succeed when S was a string, because 4294967386 was
7064 truncated before it was used.
7065
8fd02eb7
PE
7066 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7067 Otherwise, an out-of-range integer could cause undefined behavior
7068 on a 64-bit host.
7069
f8c86b69
PE
7070 * composite.c: Use int, not EMACS_INT, for characters.
7071 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7072 EMACS_INT, for values that are known to be in character range.
7073 This doesn't fix any bugs but is the usual style inside Emacs and
7074 may generate better code on 32-bit machines.
7075
34206dd2
PE
7076 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7077 This is for reasons similar to the recent CHAR_STRING fix.
7078 * charset.c (Fencode_char): Check that character arg is actually
7079 a character. Pass an int to ENCODE_CHAR.
7080 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7081 wider than 'int', as a compile-time check to prevent future regressions
7082 in this area.
7083
c5958d4c 7084 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7085
7086 Make sure a 64-bit char is never passed to CHAR_STRING.
7087 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7088 by silently ignoring the top 32 bits, allowing some values
7089 that were far too large to be valid characters.
7090 * character.h: Include <verify.h>.
7091 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7092 arguments are no wider than unsigned, as a compile-time check
7093 to prevent future regressions in this area.
7094 * data.c (Faset):
01103c44 7095 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7096 (Fsubst_char_in_region):
7097 * fns.c (concat):
7098 * xdisp.c (decode_mode_spec_coding):
7099 Adjust to CHAR_STRING's new requirement.
7100 * editfns.c (Finsert_char, Fsubst_char_in_region):
7101 * fns.c (concat): Check that character args are actually
7102 characters. Without this test, these functions did the wrong
7103 thing with wildly out-of-range values on 64-bit hosts.
7104
d37ca623
PE
7105 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7106 These casts should not be needed on 32-bit hosts, either.
7107 * keyboard.c (read_char):
7108 * lread.c (Fload): Remove casts to unsigned.
7109
ea204efb
PE
7110 * lisp.h (UNSIGNED_CMP): New macro.
7111 This fixes comparison bugs on 64-bit hosts.
7112 (ASCII_CHAR_P): Use it.
7113 * casefiddle.c (casify_object):
01103c44 7114 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7115 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7116 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7117 * dispextern.h (FACE_FROM_ID):
7118 * keyboard.c (read_char): Use UNSIGNED_CMP.
7119
41cb286c
PE
7120 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7121 not to EMACS_INT, to avoid GCC warning.
7122
4a1b9832
PE
7123 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7124
55daad71
PE
7125 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7126 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7127 isn't needed on 32-bit machines.
8f95c75c 7128
01103c44
PE
7129 * buffer.c (Fgenerate_new_buffer_name):
7130 Use EMACS_INT for count, not int.
0ceccced 7131 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7132
7133 * data.c (Qcompiled_function): Now static.
7134
c6f072e7
PE
7135 * window.c (window_body_lines): Now static.
7136
20ce5912
PE
7137 * image.c (gif_load): Rename local to avoid shadowing.
7138
9c4c5f81
PE
7139 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7140 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7141 * alloc.c (make_save_value): Integer argument is now of type
7142 ptrdiff_t, not int.
7143 (mark_object): Use ptrdiff_t, not int.
7144 * lisp.h (pD): New macro.
7145 * print.c (print_object): Use it.
7146
c0c5c8ae
PE
7147 * alloc.c: Use EMACS_INT, not int, to count objects.
7148 (total_conses, total_markers, total_symbols, total_vector_size)
7149 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7150 (total_free_floats, total_floats, total_free_intervals)
7151 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7152 Now EMACS_INT, not int. All uses changed.
7153 (Fgarbage_collect): Compute overall total using a double, so that
7154 integer overflow is less likely to be a problem. Check for overflow
7155 when converting back to an integer.
5a25e253
PE
7156 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7157 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7158 These were 'int' variables that could overflow on 64-bit hosts;
7159 they were never used, so remove them instead of repairing them.
211a0b2a 7160 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7161 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7162 Previously, this ceilinged at INT_MAX, but that doesn't work on
7163 64-bit machines.
e46bb31a 7164 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7165
c78baabf 7166 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7167 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7168 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7169 when a (possibly-narrower) signed value would do just as well.
7170 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7171
c9d624c6
PE
7172 * alloc.c: Catch some string size overflows that we were missing.
7173 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7174 for convenience in STRING_BYTES_MAX.
7175 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7176 The definition here is exact; the one in lisp.h was approximate.
7177 (allocate_string_data): Check for string overflow. This catches
7178 some instances we weren't catching before. Also, it catches
7179 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7180 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7181 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7182
c9d624c6
PE
7183 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7184 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7185 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7186
353032ce
PE
7187 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7188
2bccce07
PE
7189 * alloc.c (Fmake_string): Check for out-of-range init.
7190
0ac30604
SM
71912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7192
7193 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7194
c195f2de
JD
71952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7196
7197 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7198 xg_get_default_scrollbar_width.
7199
7200 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7201 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7202 (style_changed_cb): Call update_theme_scrollbar_width and call
7203 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7204 all frames (Bug#8505).
7205 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7206 Call gtk_window_set_resizable if HAVE_GTK3.
7207 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7208 and height if HAVE_GTK3 (Bug#8505).
7209 (scroll_bar_width_for_theme): New variable.
7210 (update_theme_scrollbar_width): New function.
7211 (xg_get_default_scrollbar_width): Move code to
7212 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7213 (xg_initialize): Call update_theme_scrollbar_width.
7214
7215 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7216
7217 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7218
e10ac9f1
MR
72192011-06-12 Martin Rudalics <rudalics@gmx.at>
7220
7221 * frame.c (make_frame): Call other_buffer_safely instead of
7222 other_buffer.
7223
7224 * window.c (temp_output_buffer_show): Call display_buffer with
7225 second argument Vtemp_buffer_show_specifiers and reset latter
7226 immediately after the call.
7227 (Vtemp_buffer_show_specifiers): New variable.
7228 (auto_window_vscroll_p, next_screen_context_lines)
7229 (Vscroll_preserve_screen_position): Remove leading asterisks from
7230 doc-strings.
7231
2d3c217e 72322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7233
7b7f97e8 7234 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7235 * buffer.c (Qclone_number): Remove for now, as it's unused.
7236 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7237 (record_buffer): Remove unused local.
7238 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7239 (set_frame_buffer_list): Remove; unused.
7240 * frame.h (other_visible_frames): Remove decl.
7241 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7242 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7243 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7244 if HAVE_GPM.
7245 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7246 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7247 Define only if HAVE_GPM.
7248 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7249 (update_hints_inhibit): Remove; never set. All uses removed.
7250 * widgetprv.h (emacsFrameClassRec): Remove decl.
7251 * window.c (delete_deletable_window): Now returns void, since it
7252 wasn't returning anything.
7253 (compare_window_configurations): Remove unused locals.
7254 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7255 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7256 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7257 the same widths as pointers. This follows up on the 2011-05-06 patch.
7258 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7259 * xterm.h: Likewise.
7260 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7261
1384b89e
JB
72622011-06-12 Juanma Barranquero <lekktu@gmail.com>
7263
7264 * makefile.w32-in: Update dependencies.
7265 (LISP_H): Add lib/intprops.h.
7266
1100a63c
CY
72672011-06-11 Chong Yidong <cyd@stupidchicken.com>
7268
7269 * image.c (gif_load): Add animation frame delay to the metadata.
7270 (syms_of_image): Use DEFSYM. New symbol `delay'.
7271
6198ccd0
MR
72722011-06-11 Martin Rudalics <rudalics@gmx.at>
7273
7274 * window.c (delete_deletable_window): Re-add.
7275 (Fset_window_configuration): Rewrite to handle dead buffers and
7276 consequently deletable windows.
7277 (window_tree, Fwindow_tree): Remove. Supply functionality in
7278 window.el.
7279 (compare_window_configurations): Simplify code.
7280
b6e3633c
AS
72812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7282
1ab0dee5
AS
7283 * image.c (imagemagick_load_image): Fix type mismatch.
7284 (Fimagemagick_types): Likewise.
7285
b6e3633c
AS
7286 * window.h (replace_buffer_in_windows): Declare.
7287
9397e56f
MR
72882011-06-11 Martin Rudalics <rudalics@gmx.at>
7289
7290 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7291 Qclone_number. Remove external declaration of Qdelete_window.
7292 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7293 code.
640c8776
SM
7294 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7295 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7296 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7297 buffer list implementation.
7298 (other_buffer_safely): New function.
7299 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7300 calls to replace_buffer_in_windows and
7301 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7302 if allowed.
7303 (record_buffer): Inhibit quitting and rewrite using quittable
7304 functions. Run Qbuffer_list_update_hook if allowed.
7305 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7306 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7307 Move switch-to-buffer to window.el.
9397e56f
MR
7308 (bury-buffer): Move to window.el.
7309 (Vbuffer_list_update_hook): New variable.
7310
7311 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7312 section.
7313
7314 * window.h (resize_frame_windows): Move up in code.
7315 (Fwindow_frame): Remove EXFUN.
7316 (replace_buffer_in_all_windows): Remove prototype.
7317 (replace_buffer_in_windows_safely): Add prototype.
7318
7319 * window.c: Declare Qdelete_window static again. Move down
7320 declaration of select_count.
7321 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7322 (Fother_window): Move to window.el.
7323 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7324 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7325 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7326 window.el.
7327 (replace_buffer_in_windows): Implement by calling
7328 Qreplace_buffer_in_windows.
7329 (replace_buffer_in_all_windows): Remove with some functionality
7330 moved into replace_buffer_in_windows_safely.
7331 (replace_buffer_in_windows_safely): New function.
7332 (select_window_norecord, select_frame_norecord): Move in front
7333 of run_window_configuration_change_hook. Remove now obsolete
7334 declarations.
640c8776
SM
7335 (Fset_window_buffer): Rewrite doc-string.
7336 Call Qrecord_window_buffer.
9397e56f
MR
7337 (keys_of_window): Move binding for other-window to window.el.
7338
b50691aa
CY
73392011-06-11 Chong Yidong <cyd@stupidchicken.com>
7340
7341 * dispextern.h (struct image): Replace data member, whose int_val
7342 and ptr_val fields were not used by anything, with a single
7343 lisp_val object.
7344
7345 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7346 (gif_clear_image, gif_load, imagemagick_load_image)
7347 (gs_clear_image, gs_load): Callers changed.
7348
3f754b86
PE
73492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7350
cca69397
PE
7351 * buffer.h: Include <time.h>, for time_t.
7352 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7353
109e28d0
PE
7354 Fix minor problems found by static checking.
7355
60737f02
PE
7356 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7357
4b66faf3
PE
7358 Make identifiers static if they are not used in other modules.
7359 * data.c (Qcompiled_function, Qframe, Qvector):
7360 * image.c (QimageMagick, Qsvg):
7361 * minibuf.c (Qmetadata):
7362 * window.c (resize_window_check, resize_root_window): Now static.
7363 * window.h (resize_window_check, resize_root_window): Remove decls.
7364
109e28d0
PE
7365 * window.c (window_deletion_count, delete_deletable_window):
7366 Remove; unused.
46a4ce9e
PE
7367 (window_body_lines): Now static.
7368 (Fdelete_other_windows_internal): Mark vars as initialized.
7369 Make sure 'resize_failed' is initialized.
7370 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7371 (resize_window_apply): Remove unused local.
7372 * window.h (delete_deletable_window): Remove decl.
7373
109e28d0 7374 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7375 (imagemagick_load_image): Fix pointer signedness problem by changing
7376 last arg from unsigned char * to char *. All uses changed.
7377 Also, fix a local for similar reasons.
7378 Remove unused locals. Remove locals to avoid shadowing.
7379 (fn_rsvg_handle_free): Remove; unused.
7380 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7381 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7382
3f754b86
PE
7383 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7384
2547adb1
CY
73852011-06-10 Chong Yidong <cyd@stupidchicken.com>
7386
7387 * image.c (gif_load): Fix omitted cast error introduced by
7388 2011-06-06 change.
7389
2c8e37d4
MR
73902011-06-10 Martin Rudalics <rudalics@gmx.at>
7391
7392 * window.h (resize_proportionally, orig_total_lines)
7393 (orig_top_line): Remove from window structure.
7394 (set_window_height, set_window_width, change_window_heights)
7395 (Fdelete_window): Remove prototypes.
7396 (resize_frame_windows): Remove duplicate declaration.
7397
440a42e3
EZ
73982011-06-10 Eli Zaretskii <eliz@gnu.org>
7399
7400 * window.h (resize_frame_windows, resize_window_check)
7401 (delete_deletable_window, resize_root_window)
7402 (resize_frame_windows): Declare prototypes.
7403
7404 * window.c (resize_window_apply): Make definition be "static" to
7405 match the prototype.
7406
562dd5e9
MR
74072011-06-10 Martin Rudalics <rudalics@gmx.at>
7408
7409 * window.c: Remove declarations of Qwindow_size_fixed,
7410 window_min_size_1, window_min_size_2, window_min_size,
7411 size_window, window_fixed_size_p, enlarge_window, delete_window.
7412 Remove static from declaration of Qdelete_window, it's
7413 temporarily needed by Fbury_buffer.
7414 (replace_window): Don't assign orig_top_line and
7415 orig_total_lines.
7416 (Fdelete_window, delete_window): Remove. Window deletion is
7417 handled by window.el.
640c8776
SM
7418 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7419 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7420 (Fdelete_other_windows): Remove. Deleting other windows is
7421 handled by window.el.
7422 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7423 handled in window.el.
7424 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7425 Window minimum sizes are handled in window.el.
7426 (shrink_windows, size_window, set_window_height)
7427 (set_window_width, change_window_heights, window_height)
7428 (window_width, CURBEG, CURSIZE, enlarge_window)
7429 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7430 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7431 handled in window.el.
7432 (make_dummy_parent): Rename to make_parent_window and give it a
7433 second argument horflag.
7434 (make_window): Don't set resize_proportionally any more.
7435 (Fsplit_window): Remove. Windows are split in window.el.
7436 (save_restore_action, save_restore_orig_size)
7437 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7438 Resize mini windows in window.el.
7439 (grow_mini_window, shrink_mini_window): Implement by calling
7440 Qresize_root_window_vertically, resize_window_check and
7441 resize_window_apply.
640c8776
SM
7442 (saved_window, Fset_window_configuration, save_window_save):
7443 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7444 resize_proportionally.
7445 (window_min_height, window_min_width): Move to window.el.
7446 (keys_of_window): Move bindings for delete-other-windows,
7447 split-window, delete-window and enlarge-window to window.el.
7448
7449 * buffer.c: Temporarily extern Qdelete_window.
7450 (Fbury_buffer): Temporarily call Qdelete_window instead of
7451 Fdelete_window (Fbury_buffer will move to window.el soon).
7452
7453 * frame.c (set_menu_bar_lines_1): Remove code handling
7454 orig_top_line and orig_total_lines.
7455
7456 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7457 set_window_height but set heights directly.
7458 (change_frame_size_1): Use resize_frame_windows.
7459
7460 * xdisp.c (init_xdisp): Don't use set_window_height but set
7461 heights directly.
7462
640c8776
SM
7463 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7464 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7465 run_window_configuration_change_hook.
7466
7467 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7468 instead of change_window_heights and run
7469 run_window_configuration_change_hook.
7470
1a13852e
MR
74712011-06-09 Martin Rudalics <rudalics@gmx.at>
7472
7473 * window.c (replace_window): Rename second argument REPLACEMENT to
7474 NEW. New third argument SETFLAG. Rewrite.
7475 (delete_window, make_dummy_parent): Call replace_window with
7476 third argument 1.
7477 (window_list_1): Move down in code.
7478 (run_window_configuration_change_hook): Move set_buffer part
7479 before select_frame_norecord part in order to unwind correctly.
7480 Rename count1 to count.
7481 (recombine_windows, delete_deletable_window, resize_root_window)
7482 (Fdelete_other_windows_internal)
7483 (Frun_window_configuration_change_hook, make_parent_window)
7484 (resize_window_check, resize_window_apply, Fresize_window_apply)
7485 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7486 (Fdelete_window_internal, Fresize_mini_window_internal):
7487 New functions.
1a13852e
MR
7488 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7489
f3d1777e
MR
74902011-06-08 Martin Rudalics <rudalics@gmx.at>
7491
496e208e
MR
7492 * window.h (window): Add some new members to window structure -
7493 normal_lines, normal_cols, new_total, new_normal, clone_number,
7494 splits, nest, prev_buffers, next_buffers.
7495 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7496 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7497
f3d1777e
MR
7498 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7499 Remove.
496e208e
MR
7500 (make_dummy_parent): Set new members of windows structure.
7501 (make_window): Move down in code. Handle new members of window
7502 structure.
7503 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7504 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7505 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7506 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7507 (Fset_window_next_buffers, Fset_window_clone_number):
7508 New functions.
496e208e
MR
7509 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7510 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7511 Doc-string fixes.
7512 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7513 Argument WINDOW can be now internal window too.
7514 (Fwindow_use_time): Move up in code.
7515 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7516 Rewrite doc-string.
7517 (Fset_window_configuration, saved_window)
7518 (Fcurrent_window_configuration, save_window_save): Handle new
7519 members of window structure.
b9e809c2
MR
7520 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7521 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7522 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7523 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7524 Qget_mru_window, Qresize_root_window,
7525 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7526 Qauto_buffer_name; staticpro them.
f3d1777e 7527
abde8f8c
MR
75282011-06-07 Martin Rudalics <rudalics@gmx.at>
7529
7530 * window.c (Fwindow_total_size, Fwindow_left_column)
7531 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7532 (Fwindow_list_1): New functions.
7533 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7534 (Fwindow_width, Fscroll_left, Fscroll_right):
7535 Use window_body_cols instead of window_box_text_cols.
7536 (delete_window, Fset_window_configuration):
7537 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7538 (delete_all_subwindows): Take a window as argument and not a
7539 structure. Rewrite.
190b47e6
MR
7540 (window_loop): Remove handling of GET_LRU_WINDOW and
7541 GET_LARGEST_WINDOW.
7542 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7543
7544 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7545 window_box_text_cols. delete_all_subwindows now takes a
7546 Lisp_Object as argument.
abde8f8c 7547
640c8776
SM
7548 * indent.c (compute_motion, Fcompute_motion):
7549 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7550
fa8a67e6
MR
7551 * frame.c (delete_frame): Call delete_all_subwindows with root
7552 window as argument.
7553
a54e3482
DC
75542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7555
7556 * fns.c (Fputhash): Document return value.
7557
60002bf5
CY
75582011-06-06 Chong Yidong <cyd@stupidchicken.com>
7559
7560 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7561
0c671da6 75622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7563
b862a52a 7564 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7565
be44ca6c
PE
7566 Check for overflow when converting integer to cons and back.
7567 * charset.c (Fdefine_charset_internal, Fdecode_char):
7568 Use cons_to_unsigned to catch overflow.
7569 (Fencode_char): Use INTEGER_TO_CONS.
7570 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7571 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7572 * data.c (long_to_cons, cons_to_long): Remove.
7573 (cons_to_unsigned, cons_to_signed): New functions.
7574 These signal an error for invalid or out-of-range values.
7575 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7576 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7577 * font.c (Ffont_variation_glyphs):
7578 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7579 * lisp.h: Include <intprops.h>.
7580 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7581 (cons_to_signed, cons_to_unsigned): New decls.
7582 (long_to_cons, cons_to_long): Remove decls.
7583 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7584 (Fprimitive_undo): Use CONS_TO_INTEGER.
7585 * xfns.c (Fx_window_property): Likewise.
7586 * xselect.c: Include <limits.h>.
7587 (x_own_selection, selection_data_to_lisp_data):
7588 Use INTEGER_TO_CONS.
7589 (x_handle_selection_request, x_handle_selection_clear)
7590 (x_get_foreign_selection, Fx_disown_selection_internal)
7591 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7592 (lisp_data_to_selection_data): Use cons_to_unsigned.
7593 (x_fill_property_data): Use cons_to_signed.
7594 Report values out of range.
7595
d1f3d2af
PE
7596 Check for buffer and string overflow more precisely.
7597 * buffer.h (BUF_BYTES_MAX): New macro.
7598 * lisp.h (STRING_BYTES_MAX): New macro.
7599 * alloc.c (Fmake_string):
7600 * character.c (string_escape_byte8):
7601 * coding.c (coding_alloc_by_realloc):
7602 * doprnt.c (doprnt):
7603 * editfns.c (Fformat):
7604 * eval.c (verror):
7605 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7606 since they may not be the same number.
7607 * editfns.c (Finsert_char):
7608 * fileio.c (Finsert_file_contents):
7609 Likewise for BUF_BYTES_MAX.
7610
dd52fcea
PE
7611 * image.c: Use ptrdiff_t, not int, for sizes.
7612 (slurp_file): Switch from int to ptrdiff_t.
7613 All uses changed.
7614 (slurp_file): Check that file size fits in both size_t (for
7615 malloc) and ptrdiff_t (for sanity and safety).
7616
7f9bbdbb
PE
7617 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7618 if b->modtime has its maximal value.
7619
dfe18f82
PE
7620 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7621
84acfcf0
PE
7622 Don't assume time_t can fit into int.
7623 * buffer.h (struct buffer.modtime): Now time_t, not int.
7624 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7625 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7626
ccd9a01a
PE
7627 Minor fixes for signed vs unsigned integers.
7628 * character.h (MAYBE_UNIFY_CHAR):
7629 * charset.c (maybe_unify_char):
7630 * keyboard.c (read_char, reorder_modifiers):
7631 XINT -> XFASTINT, since the integer must be nonnegative.
7632 * ftfont.c (ftfont_spec_pattern):
7633 * keymap.c (access_keymap, silly_event_symbol_error):
7634 XUINT -> XFASTINT, since the integer must be nonnegative.
7635 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7636 since it makes no difference and we prefer signed.
7637 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7638 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7639 nonnegative.
7640
d6d100dd
SM
76412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7642
7643 * window.h (Fwindow_frame): Declare.
7644
2b6148e4
PE
76452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7646
7647 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7648 (SPARE_MEMORY): Always define.
7649 (LARGE_REQUEST): Remove.
7650 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7651
f230ecc9
MR
76522011-06-06 Martin Rudalics <rudalics@gmx.at>
7653
727e958e
MR
7654 * lisp.h: Move EXFUNS for Fframe_root_window,
7655 Fframe_first_window and Fset_frame_selected_window to window.h.
7656
7657 * window.h: Move EXFUNS for Fframe_root_window,
7658 Fframe_first_window and Fset_frame_selected_window here from
7659 lisp.h.
7660
7661 * frame.c (Fwindow_frame, Fframe_first_window)
7662 (Fframe_root_window, Fframe_selected_window)
7663 (Fset_frame_selected_window): Move to window.c.
7664 (Factive_minibuffer_window): Move to minibuf.c.
7665 (Fother_visible_frames_p): New function.
7666
7667 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7668
f230ecc9
MR
7669 * window.c (decode_window, decode_any_window): Move up in code.
7670 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7671 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7672 (Fwindow_buffer): Move up and rewrite doc-string.
7673 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7674 (Fwindow_prev): New functions.
727e958e
MR
7675 (Fwindow_frame): Move here from frame.c. Accept any window as
7676 argument.
7677 (Fframe_root_window, Fframe_first_window)
7678 (Fframe_selected_window): Move here from frame.c. Accept frame
7679 or arbitrary window as argument. Update doc-strings.
7680 (Fminibuffer_window): Move up in code.
7681 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7682 (Fset_frame_selected_window): Move here from frame.c.
7683 Marginal rewrite.
727e958e
MR
7684 (Fselected_window, select_window, Fselect_window): Move up in
7685 code. Minor doc-string fixes.
f230ecc9 7686
4d09bcf6
PE
76872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7688
7689 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7690 Do not assume that spare memory exists; that assumption is valid
7691 only if SYSTEM_MALLOC.
7692 (LARGE_REQUEST): New macro, so that the issue of large requests
7693 is separated from the issue of spare memory.
7694
810928a2
AS
76952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7696
172418ad
AS
7697 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7698 format. (Bug#8806)
7699
43f862f7
AS
7700 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7701
810928a2
AS
7702 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7703 before statements.
7704
a059fe24
JD
77052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7706
7707 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7708
7709 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7710
7711 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7712 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7713
989bf368
JB
77142011-06-05 Juanma Barranquero <lekktu@gmail.com>
7715
7716 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7717
4b80f674
CY
77182011-06-04 Chong Yidong <cyd@stupidchicken.com>
7719
7720 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7721 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7722 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7723 New error handlers.
4b80f674
CY
7724 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7725 Obey Vx_select_enable_clipboard_manager. Catch errors in
7726 x_clipboard_manager_save (Bug#8779).
7727 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7728 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7729
99a33b77 77302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7731
7732 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7733
99a33b77 77342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7735
7736 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7737 in the current matrix if keep_current_p is non-zero.
7738
8264569d
EZ
77392011-06-04 Eli Zaretskii <eliz@gnu.org>
7740
7741 * bidi.c (bidi_level_of_next_char): Fix last change.
7742
57f97249
EZ
77432011-06-03 Eli Zaretskii <eliz@gnu.org>
7744
fec2107c 7745 Support bidi reordering of text covered by display properties.
57f97249 7746
fec2107c
EZ
7747 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7748 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7749 (bidi_cache_search, bidi_cache_iterator_state)
7750 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7751 (bidi_level_of_next_char, bidi_move_to_visually_next):
7752 Support character positions inside a run of characters covered by a
fec2107c
EZ
7753 display string.
7754 (bidi_paragraph_init, bidi_resolve_explicit_1)
7755 (bidi_level_of_next_char): Call bidi_fetch_char and
7756 bidi_fetch_char_advance instead of FETCH_CHAR and
7757 FETCH_CHAR_ADVANCE.
7758 (bidi_init_it): Initialize new members.
7759 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7760 definitions.
7761 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7762 instead of using explicit *_CHAR codes.
d6d100dd
SM
7763 (bidi_resolve_explicit, bidi_resolve_weak):
7764 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7765 bidirectional text is supported only in multibyte buffers.
7766 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7767 it to initialize the frame_window_p member of struct bidi_it.
7768 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7769 (bidi_resolve_explicit, bidi_resolve_weak)
7770 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7771 bidi_it->nchars is non-positive.
7772 (bidi_level_of_next_char): Don't try to lookup the cache for the
7773 next/previous character if nothing is cached there yet, or if we
7774 were just reseat()'ed to a new position.
c40e2fb2 7775
0e14fe90
EZ
7776 * xdisp.c (set_cursor_from_row): Set start and stop points
7777 according to the row's direction when priming the loop that looks
7778 for the glyph on which to display cursor.
7779 (single_display_spec_intangible_p): Function deleted.
7780 (display_prop_intangible_p): Reimplement to call
7781 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7782 Accept 3 additional arguments needed by handle_display_spec.
7783 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7784 values: lists, `(when COND...)' forms, etc.
7785 (single_display_spec_string_p): Support property values that are
7786 lists with the argument STRING its top-level element.
7787 (display_prop_string_p): Fix the condition for processing a
7788 property that is a list to be consistent with handle_display_spec.
fec2107c 7789 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7790 last portion of handle_display_prop.
7791 (compute_display_string_pos): Accept additional argument
7792 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7793 value of a `display' property is a "replacing spec".
7794 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7795 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7796 the display property, but just return a value indicating whether
7797 the display property will replace the characters it covers.
7798 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7799 frame_window_p members of struct bidi_it.
d6d100dd
SM
7800 (compute_display_string_pos, compute_display_string_end):
7801 New functions.
fec2107c
EZ
7802 (push_it): Accept second argument POSITION, where pop_it should
7803 jump to continue iteration.
7804 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7805
fec2107c
EZ
7806 * keyboard.c (adjust_point_for_property): Adjust the call to
7807 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7808
7809 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7810 (bidi_init_it): Update prototypes.
7811 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7812 (compute_display_string_pos, compute_display_string_end):
7813 Declare prototypes.
fec2107c
EZ
7814 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7815 EMACS_INT.
fc6f18ce 7816
40087514 78172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7818
57f53182
PE
7819 Malloc failure behavior now depends on size of allocation.
7820 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7821 * lisp.h: Change signatures accordingly.
7822 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7823 All callers changed. (Bug#8762)
7824
7825 * gnutls.c: Use Emacs's memory allocators.
7826 Without this change, the gnutls library would invoke malloc etc.
7827 directly, which causes problems on non-SYNC_INPUT hosts, and which
7828 runs afoul of improving memory_full behavior. (Bug#8761)
7829 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7830 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7831 xfree instead of the default malloc, realloc, free.
7832 (Fgnutls_boot): No need to check for memory allocation failure,
7833 since xmalloc does that for us.
7834
ac32cd99 7835 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7836 * category.c (hash_get_category_set):
7837 * ccl.c (ccl_driver):
7838 * charset.c (Fdefine_charset_internal):
7839 * charset.h (struct charset.hash_index):
7840 * composite.c (get_composition_id, gstring_lookup_cache)
7841 (composition_gstring_put_cache):
7842 * composite.h (struct composition.hash_index):
7843 * dispextern.h (struct image.hash):
7844 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7845 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7846 (hashfn_equal, hashfn_user_defined, make_hash_table)
7847 (maybe_resize_hash_table, hash_lookup, hash_put)
7848 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7849 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7850 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7851 * image.c (make_image, search_image_cache, lookup_image)
7852 (xpm_put_color_table_h):
7853 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7854 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7855 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7856 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7857 * alloc.c (allocate_vectorlike):
7858 Check for overflow in vector size calculations.
7859 * ccl.c (ccl_driver):
7860 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7861 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7862 need to be updated by these changes.
40087514
PE
7863 * fns.c (make_hash_table, maybe_resize_hash_table):
7864 Check for integer overflow with large hash tables.
0de4bb68
PE
7865 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7866 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7867 (SXHASH_REDUCE): New macro.
7868 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7869 Use it instead of discarding useful hash info with large hash values.
7870 (sxhash_float): New function.
7871 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7872 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7873 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7874 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7875 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7876 Adjust signatures to match updated version of code.
7877 (consing_since_gc): Now EMACS_INT, since a single hash table can
7878 use more than INT_MAX bytes.
7879
698d32e2
DN
78802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7881
7882 Make it possible to build with GCC-4.6+ -O2 -flto.
7883
7884 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7885
fd6fa53f
SM
78862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7887
7888 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7889 Call minibuffer-inactive-mode.
7890
864db017
JB
78912011-05-31 Juanma Barranquero <lekktu@gmail.com>
7892
7893 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7894 Update dependencies.
7895
2ad0baf4
DN
78962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7897
7898 * data.c (init_data): Remove code for UTS, this system is not
7899 supported anymore.
7900
4fcc2638
DN
79012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7902
7903 Don't force ./temacs to start in terminal mode.
7904
7905 * frame.c (make_initial_frame): Initialize faces in all cases, not
7906 only when CANNOT_DUMP is defined.
7907 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7908
c56e0fd5
DN
79092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7910
7911 * dispnew.c (add_window_display_history): Use const for the string
7912 pointer. Remove declaration, not needed.
7913
333d54da 79142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7915
55d4c1b2 7916 Use 'inline', not 'INLINE'.
333d54da 7917 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7918 * alloc.c, fontset.c (INLINE): Remove.
7919 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7920 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7921 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7922 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7923 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7924
738db178
DN
79252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7926
7927 Make it possible to run ./temacs.
7928
7929 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7930 syms_of_callproc does the same thing. Remove test for
7931 "initialized", do it in the caller.
7932 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7933
620c53a6
SM
79342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7935
7936 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7937 (read_minibuf): Use get_minibuffer.
7938 (syms_of_minibuf): Use DEFSYM.
7939 (Qmetadata): New var.
7940 * data.c (Qbuffer): Don't make it static.
7941 (syms_of_data): Use DEFSYM.
7942
e003a292
PE
79432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7944
7945 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7946 (CCL_CODE_MIN): New macro.
7947
ed008a6d
PE
79482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7949
3687c2ef
PE
7950 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7951
ed008a6d
PE
7952 * eval.c (Qdebug): Now static.
7953 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7954 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7955 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7956
d66c4c7c
CY
79572011-05-29 Chong Yidong <cyd@stupidchicken.com>
7958
7959 * image.c: Various fixes to ImageMagick code comments.
7960 (Fimagemagick_types): Doc fix.
7961
5fbc2025
PE
79622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7963
0196f88a
PE
7964 Minor fixes prompted by GCC 4.6.0 warnings.
7965
7966 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7967
5fbc2025
PE
7968 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7969 (x_clipboard_manager_save_all): Move extern decl to ...
7970 * xterm.h: ... here, so that it can be checked for consistency.
7971
1dd3c2d9
CY
79722011-05-29 Chong Yidong <cyd@stupidchicken.com>
7973
7974 * xselect.c (x_clipboard_manager_save_frame)
7975 (x_clipboard_manager_save_all): New functions.
7976 (Fx_clipboard_manager_save): Lisp function deleted.
7977
7978 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7979 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7980
7981 * xterm.h: Update prototype.
7982
5ba6571d
WX
79832011-05-28 William Xu <william.xwl@gmail.com>
7984
7985 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7986 exiting (Bug#8239).
7987
3eaff834
JM
79882011-05-28 Jim Meyering <meyering@redhat.com>
7989
e1900994 7990 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7991 * fns.c (to_uchar): Define.
7992 (crypto_hash_function): Use it to convert some newly-signed
7993 variables to unsigned, to avoid sign-extension bugs. For example,
7994 without this change, (md5 "truc") would evaluate to
7995 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7996 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7997 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7998
0f6990a7
PE
79992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8000
8001 Integer overflow fixes.
c8a9ca5a 8002
08686060
PE
8003 * dbusbind.c: Serial number integer overflow fixes.
8004 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8005 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8006 to hold a serial number that is too large for a fixnum.
8007 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8008 Check for serial numbers out of range. Decode any serial number
59568bf0 8009 that was so large that it became a float. (Bug#8722)
08686060 8010
2d1fc3c7
PE
8011 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8012 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8013 Use XFASTINT rather than XUINT when numbers are nonnegative.
8014 (xd_append_arg, Fdbus_method_return_internal):
8015 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8016 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8017 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8018 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8019 (Bug#8722)
2d1fc3c7 8020
c8a9ca5a
PE
8021 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8022
519e1d69
PE
8023 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8024
6df6ae42 8025 ccl: Add integer overflow checks.
30569699
PE
8026 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8027 (IN_INT_RANGE): New macros.
8028 (ccl_driver): Use them to check for integer overflow when
8029 decoding a CCL program. Many of the new checks are whether XINT (x)
8030 fits in int; it doesn't always, on 64-bit hosts. The new version
8031 doesn't catch all possible integer overflows, but it's an
847044ea 8032 improvement. (Bug#8719)
30569699 8033
c11285dc
PE
8034 * alloc.c (make_event_array): Use XINT, not XUINT.
8035 There's no need for unsigned here.
8036
fdccd48e
PE
8037 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8038 This follows up to the 2011-05-06 change that substituted uintptr_t
8039 for EMACS_INT. This case wasn't caught back then.
8040
37910ab2
PE
8041 Rework Fformat to avoid integer overflow issues.
8042 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8043 now (part of C89). Include <verify.h>.
8044 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8045 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8046 (Fformat): Avoid the prepass trying to compute sizes; it was only
8047 approximate and thus did not catch overflow reliably. Instead, walk
8048 through the format just once, formatting and computing sizes as we go,
8049 checking for integer overflow at every step, and allocating a larger
8050 buffer as needed. Keep track separately whether the format is
8051 multibyte. Keep only the most-recently calculated precision, rather
8052 than them all. Record whether each argument has been converted to
8053 string. Use EMACS_INT, not int, for byte and char and arg counts.
8054 Support field widths and precisions larger than INT_MAX. Avoid
8055 sprintf's undefined behavior with conversion specifications such as %#d
8056 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8057 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8058 formatting out-of-range floating point numbers with int
9173deec 8059 formats. (Bug#8668)
37910ab2 8060
2e6578fb
PE
8061 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8062
0ae6bdee
PE
8063 * data.c: Avoid integer truncation in expressions involving floats.
8064 * data.c: Include <intprops.h>.
8065 (arith_driver): When there's an integer overflow in an expression
8066 involving floating point, convert the integers to floating point
8067 so that the resulting value does not suffer from catastrophic
8068 integer truncation. For example, on a 64-bit host (* 4
8069 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8070 Do not rely on undefined behavior after integer overflow.
8071
de883a70
PE
8072 merge count_size_as_multibyte, parse_str_to_multibyte
8073 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8074 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8075 Check for integer overflow.
8076 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8077 since it's now a duplicate of the other. This is more of
8078 a character than a buffer op, so better that it's in character.c.
8079 * fns.c, print.c: Adjust to above changes.
8080
2ff916cb
PE
80812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8082
8083 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8084
f1b54466
PE
80852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8086
fb1ac845
PE
8087 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8088 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8089 (x_clipboard_manager_save): Now static.
8090 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8091
f1b54466
PE
8092 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8093 (crypto_hash_function): Now static.
8094 Fix pointer signedness problems. Avoid unnecessary initializations.
8095
a9f737ee
CY
80962011-05-27 Chong Yidong <cyd@stupidchicken.com>
8097
8098 * termhooks.h (Vselection_alist): Make it terminal-local.
8099
8100 * terminal.c (create_terminal): Initialize it.
8101
8102 * xselect.c: Support for clipboard managers.
8103 (Vselection_alist): Move to termhooks.h as terminal-local var.
8104 (LOCAL_SELECTION): New macro.
8105 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8106 (symbol_to_x_atom): Remove gratuitous arg.
8107 (x_handle_selection_request, lisp_data_to_selection_data)
8108 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8109 (x_own_selection, x_get_local_selection, x_convert_selection):
8110 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8111 (some_frame_on_display): Delete unused function.
8112 (Fx_own_selection_internal, Fx_get_selection_internal)
8113 (Fx_disown_selection_internal, Fx_selection_owner_p)
8114 (Fx_selection_exists_p): New optional frame arg.
8115 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8116 (x_handle_selection_clear): Don't treat other terminals with the
8117 same keyboard specially. Use the terminal-local Vselection_alist.
8118 (x_clear_frame_selections): Use Frun_hook_with_args.
8119
8120 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8121
8122 * xterm.h: Add support for those atoms.
8123
e067f0c1
CY
81242011-05-26 Chong Yidong <cyd@stupidchicken.com>
8125
8126 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8127 (converted_selections, conversion_fail_tag): New global variables.
8128 (x_selection_request_lisp_error): Free the above.
8129 (x_get_local_selection): Remove unnecessary code.
8130 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8131 of converted selections stored in converted_selections.
8132 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8133 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8134 (x_convert_selection): New function.
8135 (x_handle_selection_event): Simplify.
8136 (x_get_foreign_selection): Don't ignore incoming requests while
8137 waiting for an answer; this will fail when we implement
8138 SAVE_TARGETS, and seems unnecessary anyway.
8139 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8140 (Vx_sent_selection_functions): Doc fix.
8141
0f4aebc0
LL
81422011-05-26 Leo Liu <sdl.web@gmail.com>
8143
8144 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8145
e61124cd
YM
81462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8147
8148 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8149
8150 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8151 for fringe update if it has periodic bitmap.
ac389d0c 8152 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8153 and fringe_bitmap_periodic_p.
8154
8155 * fringe.c (get_fringe_bitmap_data): New function.
8156 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8157 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8158 row. Mark glyph row for fringe update if periodicity changed.
8159
8160 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8161 for fringe update unless it has periodic bitmap.
8162
f16d9837
KH
81632011-05-25 Kenichi Handa <handa@m17n.org>
8164
8165 * xdisp.c (get_next_display_element): Set correct it->face_id for
8166 a static composition.
8167
e1b90ef6
LL
81682011-05-24 Leo Liu <sdl.web@gmail.com>
8169
8170 * deps.mk (fns.o):
8171 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8172
8173 * fns.c (crypto_hash_function, Fsha1): New function.
8174 (Fmd5): Use crypto_hash_function.
8175 (syms_of_fns): Add Ssha1.
8176
7400048f
PE
81772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8178
8179 * gnutls.c: Remove unused macros.
8180 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8181 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8182 Remove macros that are defined and never used.
8183 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8184
abb71cf4
CY
81852011-05-22 Chong Yidong <cyd@stupidchicken.com>
8186
8187 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8188 (Fx_get_selection_internal): Minor cleanup.
8189 (Fx_own_selection_internal): Rename arguments for consistency with
8190 select.el.
8191
6307db39
PE
81922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8193
8194 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8195
f3d4e0a4
CY
81962011-05-22 Chong Yidong <cyd@stupidchicken.com>
8197
8198 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8199
4d8ade89
YM
82002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8201
8202 * dispnew.c (scrolling_window): Don't exclude the case that the
8203 last enabled row in the desired matrix touches the bottom boundary.
8204
32078c8d
GM
82052011-05-21 Glenn Morris <rgm@gnu.org>
8206
8207 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8208 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8209 and add some more files.
32078c8d 8210
7285dc67
EZ
82112011-05-20 Eli Zaretskii <eliz@gnu.org>
8212
8213 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8214 report_file_error introduced by the change from 2011-05-07.
8215
89d1bd22
PE
82162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8217
8218 * systime.h (Time): Define only if emacs is defined.
8219 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8220 where the include path doesn't have X11/X.h by default. See
8221 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8222
cd394be1 82232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8224
8225 * composite.c (find_automatic_composition): Fix previous change.
8226
b9704ad9
GM
82272011-05-20 Glenn Morris <rgm@gnu.org>
8228
8229 * lisp.mk: New file, split from Makefile.in.
8230 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8231 (shortlisp): Remove.
8232 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8233
4a720484
GM
82342011-05-19 Glenn Morris <rgm@gnu.org>
8235
8236 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8237 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8238 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8239 (lisp): Set the order to that of loadup.el.
8240 (shortlisp): Make it a copy of $lisp.
8241 (SOME_MACHINE_LISP): Remove.
8242 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8243 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8244
a28d4396
KH
82452011-05-18 Kenichi Handa <handa@m17n.org>
8246
8247 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8248 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8249 (find_automatic_composition): Mostly rewrite for efficiency.
8250
a2b1fa8e
JB
82512011-05-18 Juanma Barranquero <lekktu@gmail.com>
8252
8253 * makefile.w32-in: Update dependencies.
8254
8e1f5610
CS
82552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8256
8257 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8258 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8259
7025ee00 82602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8261
cdfa6eab
PE
8262 Fix some integer overflow issues, such as string length overflow.
8263
06d6db33
PE
8264 * insdel.c (count_size_as_multibyte): Check for string overflow.
8265
2b4560a8
PE
8266 * character.c (lisp_string_width): Check for string overflow.
8267 Use EMACS_INT, not int, for string indexes and lengths; in
8268 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8269 the resulting string length overflows an EMACS_INT; instead,
8270 report a string overflow if no precision given. When checking for
8271 precision exhaustion, use a check that cannot possibly have
8272 integer overflow. (Bug#8675)
8273 * character.h (lisp_string_width): Adjust to new signature.
8274
cb93f9be
PE
8275 * alloc.c (string_overflow): New function.
8276 (Fmake_string): Use it. This doesn't change behavior, but saves
8277 a few bytes and will simplify future changes.
8278 * character.c (string_escape_byte8): Likewise.
8279 * lisp.h (string_overflow): New decl.
8280
1a1f3366
PE
8281 Fixups, following up to the user-interface timestamp change.
8282 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8283 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8284 * msdos.c (mouse_get_pos): Likewise.
8285 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8286 * w32gui.h (Time): Define by including "systime.h" rather than by
8287 declaring it ourselves. (Bug#8664)
8288
d4e3e4d3
PE
8289 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8290 * image.c (clear_image_cache): Likewise.
8291
f6a24d19
PE
8292 * term.c (term_mouse_position): Don't assume time_t wraparound.
8293
08dc5ae6
PE
8294 Be more systematic about user-interface timestamps.
8295 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8296 and sometimes 'EMACS_UINT', to represent these timestamps.
8297 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8298 This makes the code easier to follow, and makes it easier to catch
8299 integer overflow bugs such as Bug#8664.
8300 * frame.c (Fmouse_position, Fmouse_pixel_position):
8301 Use Time, not unsigned long, for user-interface timestamps.
8302 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8303 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8304 * keyboard.h (last_event_timestamp): Likewise.
8305 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8306 * menu.h (xmenu_show): Likewise.
8307 * term.c (term_mouse_position): Likewise.
8308 * termhooks.h (struct input_event.timestamp): Likewise.
8309 (struct terminal.mouse_position_hook): Likewise.
8310 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8311 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8312 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8313 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8314 what it was before.
8315 * menu.h, termhooks.h: Include "systime.h", for Time.
8316
8e55734a
PE
8317 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8318 Don't assume that the difference between two unsigned long values
8319 can fit into an integer. At this point, we know button_down_time
8320 <= event->timestamp, so the difference must be nonnegative, so
8321 there's no need to cast the result if double-click-time is
8322 nonnegative, as it should be; check that it's nonnegative, just in
8323 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8324 apart (about 25 days). (Bug#8664)
8e55734a 8325
841f1b75 8326 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8327 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8328
3e26f69c
PE
8329 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8330 that always fit in int. Use a sentinel instead of a counter, to
8331 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8332 * frame.h (struct frame): Use int for menu_bar_items_used
8333 instead of EMACS_INT, since it always fits in int.
3e26f69c 8334
5cc152c0
PE
8335 * menu.c (grow_menu_items): Check for int overflow.
8336
d89eb65e
PE
8337 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8338
5235bd3e
PE
8339 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8340 Before, the code was not consistent. These values cannot exceed
8341 2**31 - 1 so there's no need to make them unsigned.
8342 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8343 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8344 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8345 as modifiers.
8346 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8347
bc827e23
PE
8348 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8349 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8350 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8351 presumably because the widths might not match.
8352
78eb494e
PE
8353 * window.c (size_window): Avoid needless test at loop start.
8354
04f2d78b
CB
83552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8356
8357 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8358
d2fc7e3d 83592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8360
8361 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8362
d2fc7e3d 83632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8364
8365 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8366 `width' to `bar_area_x' and `bar_area_width', respectively.
8367 (x_scroll_run): Take account of fringe background extension.
8368
04f2d78b
CB
8369 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8370 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8371 `bar_area_width', respectively.
8372 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8373 background extension.
8374
79b70037
GM
83752011-05-10 Jim Meyering <meyering@redhat.com>
8376
8377 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8378
2f142cc5
JB
83792011-05-10 Juanma Barranquero <lekktu@gmail.com>
8380
8381 * image.c (Finit_image_library): Return t for built-in image types,
8382 like pbm and xbm. (Bug#8640)
8383
57679c86
AS
83842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8385
8386 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8387
888c9e86
EZ
83882011-05-07 Eli Zaretskii <eliz@gnu.org>
8389
b0512a1d
EZ
8390 * w32console.c (Fset_screen_color): Doc fix.
8391 (Fget_screen_color): New function.
8392 (syms_of_ntterm): Defsubr it.
8393
7285dc67
EZ
8394 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8395 unlink the temporary file if Fcall_process didn't create it in the
8396 first place.
8397 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8398 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8399 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8400 cue to call_process_cleanup not to close that handle.
8401
4d3fcc8e
BK
84022011-05-07 Ben Key <bkey76@gmail.com>
8403
8404 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8405 one of two shell specific rules, either bootstrap-temacs-CMD or
8406 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8407 to the previous implementation of the bootstrap-temacs rule.
8408 The bootstrap-temacs-CMD rule is similar to the previous
8409 implementation of the bootstrap-temacs rule except that it
8410 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8411 variable.
8412
8413 These changes, along with some changes to nt/configure.bat,
8414 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8415 earlier fix to add support for --cflags and --ldflags options
8416 that include quotes so that it works whether make uses cmd or
8417 sh as the shell.
8418
b4289b64
MA
84192011-05-06 Michael Albinus <michael.albinus@gmx.de>
8420
8421 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8422 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8423 is a constant.
8424 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8425 a string. Handle both cases.
8426 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8427 (Fdbus_register_method): Use Qinvalid_function.
8428
af4c0e28
JB
84292011-05-06 Juanma Barranquero <lekktu@gmail.com>
8430
8431 * makefile.w32-in: Update dependencies.
8432 (LISP_H): Add inttypes.h and stdin.h.
8433 (PROCESS_H): Add unistd.h.
8434
c51453d9
EZ
84352011-05-06 Eli Zaretskii <eliz@gnu.org>
8436
8437 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8438 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8439
8ff0ac3c 84402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8441
4c4b566b
PE
8442 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8443
aab2b9b5
PE
8444 * term.c (vfatal): Remove stray call to va_end.
8445 It's not needed and the C Standard doesn't allow it here anyway.
8446
c378da0b
PE
8447 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8448 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8449
288b08c7
PE
8450 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8451 bytes.
8452
e3601888
PE
8453 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8454
db6c0e74
PE
8455 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8456
dd5963ea
PE
8457 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8458
88c9450f
PE
8459 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8460
2f9442b8
PE
8461 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8462
c032b5f8
PE
8463 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8464 * charset.c (Fdefine_charset_internal): Don't initialize
8465 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8466 32-bit int (Bug#8600).
a108c10b
PE
8467
8468 * lread.c (read_integer): Be more consistent with string-to-number.
8469 Use string_to_number to do the actual conversion; this avoids
8470 rounding errors and fixes some other screwups. Without this fix,
8471 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8472 (digit_to_number): Move earlier, for benefit of read_integer.
8473 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8474 not a digit in any supported base. (Bug#8602)
a108c10b 8475
ad5f9eea
PE
8476 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8477
aec1708a
PE
8478 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8479 to match comment at start of function. This also removes a
8480 GCC warning about overflow in a 32+64-bit port.
8481
47be4ab5
PE
8482 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8483
371cac43
PE
8484 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8485 Reported by Stefan Monnier in
8486 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8487 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8488 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8489
d01a7826
PE
8490 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8491 (EMACS_UINTPTR): Likewise, with uintptr_t.
8492
7fd47d5c
PE
8493 * lisp.h: Prefer 64-bit EMACS_INT if available.
8494 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8495 on 32-bit hosts that have 64-bit int, so that they can access
8496 large files.
122b0c86
PE
8497 However, temporarily disable this change unless the temporary
8498 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8499
8727937b
PE
8500 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8501
8ac068ac
PE
8502 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8503 This removes an assumption that EMACS_INT and long are the same
8504 width as pointers. The assumption is true for Emacs porting targets
8505 now, but we want to make other targets possible.
8506 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8507 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8508 In the rest of the code, change types of integers that hold casted
8509 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8510 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8511 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8512 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8513 No need to cast type when ORing.
8514 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8515 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8516 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8517 assume EMACS_INT is the same width as char *.
8518 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8519 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8520 Remove no-longer-needed casts.
8521 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8522 (xg_tool_bar_help_callback, xg_make_tool_item):
8523 Use EMACS_INTPTR to hold an integer
8524 that will be cast to void *; this can avoid a GCC warning
8525 if EMACS_INT is not the same width as void *.
8526 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8527 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8528 (current_message_1, set_message_1):
8529 Use a local to convert to proper width without a cast.
8530 * xmenu.c (dialog_selection_callback): Likewise.
8531
ede49d71
PE
8532 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8533 Also, don't assume VALBITS / RAND_BITS is less than 5,
8534 and don't rely on undefined behavior when shifting a 1 left into
8535 the sign bit.
8536 * lisp.h (get_random): Change signature to match.
8537
2f30ecd0
PE
8538 * lread.c (hash_string): Use size_t, not int, for hash computation.
8539 Normally we prefer signed values; but hashing is special, because
8540 it's better to use unsigned division on hash table sizes so that
8541 the remainder is nonnegative. Also, size_t is the natural width
8542 for hashing into memory. The previous code used 'int', which doesn't
8543 retain enough info to hash well into very large tables.
8544 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8545
2a866e7b
PE
8546 * dbusbind.c: Don't possibly lose pointer info when converting.
8547 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8548 Use XPNTR rather than XHASH, so that the high-order bits of
8549 the pointer aren't lost when converting through void *.
8550
51639eac
PE
8551 * eval.c (Fautoload): Don't double-shift a pointer.
8552
92394119
PE
8553 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8554
dbdb9a7c
JB
85552011-05-06 Juanma Barranquero <lekktu@gmail.com>
8556
8557 * gnutls.c (DEF_GNUTLS_FN):
8558 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8559
db7a0b4f
AS
85602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8561
8562 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8563 marker. (Bug#8610)
8564
cd394be1 85652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8566
8567 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8568 New version that can reserve upto 2GB of heap space.
8569
f7ff1b0f 85702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8571
8572 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8573
639c109b
TZ
85742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8575
8576 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8577 `gnutls_certificate_set_x509_key_file'.
8578
d2127135
JB
85792011-05-05 Juanma Barranquero <lekktu@gmail.com>
8580
8581 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8582 Update dependencies.
8583
e968f4f3
JB
85842011-05-04 Juanma Barranquero <lekktu@gmail.com>
8585
8586 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8587 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8588 Remove unused parameter `fildes'.
8589 * process.c (read_process_output, send_process): Don't pass it.
8590
84d358f0
JB
85912011-05-04 Juanma Barranquero <lekktu@gmail.com>
8592
8593 Fix previous change: the library cache is defined in w32.c.
8594 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8595 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8596
0898ca10
JB
85972011-05-04 Juanma Barranquero <lekktu@gmail.com>
8598
8599 Implement dynamic loading of GnuTLS on Windows.
8600
8601 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8602 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8603 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8604 Declare.
8605
8606 * gnutls.c (Qgnutls_dll): Define.
8607 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8608 (gnutls_*): Declare function pointers.
8609 (init_gnutls_functions): New function to initialize function pointers.
8610 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8611 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8612 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8613 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8614 (emacs_gnutls_write, emacs_gnutls_read)
8615 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8616 (Fgnutls_available_p): New function.
8617 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8618 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8619 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8620
8621 * image.c: Include w32.h.
8622 (Vimage_type_cache): Delete.
8623 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8624 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8625 (w32_delayed_load): Move to w32.c.
8626
8627 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8628
8629 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8630 (w32_delayed_load): Move from image.c. When loading a library, record
8631 its filename in the :loaded-from property of the library id.
8632 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8633 Initialize and staticpro them.
8634 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8635
8636 * process.c: Include lisp.h before w32.h, not after.
8637 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8638 instead of gnutls_record_check_pending.
8639
8640 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8641
ff4de4aa
TZ
86422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8643
8644 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8645 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8646 as passed in.
8647
abe95abb
JD
86482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8649
8650 * xterm.c (x_set_frame_alpha): Do not set property on anything
8651 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8652
e16e55d4
JB
86532011-05-02 Juanma Barranquero <lekktu@gmail.com>
8654
8655 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8656
bafcf6a5
JB
86572011-05-02 Juanma Barranquero <lekktu@gmail.com>
8658
8659 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8660 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8661 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8662 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8663 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8664 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8665 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8666 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8667 (Qgnutls_bootprop_callbacks_verify): Make static.
8668
e7a6747f
AS
86692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8670
19ed11ba
AS
8671 * callproc.c: Indentation fixup.
8672
e7a6747f 8673 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8674 (wait_for_termination, interruptible_wait_for_termination):
8675 Move after wait_for_termination_1.
e7a6747f 8676
1ef14cb4
LMI
86772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8678
8679 * sysdep.c (interruptible_wait_for_termination): New function
8680 which is like wait_for_termination, but allows keyboard
8681 interruptions.
8682
8683 * callproc.c (Fcall_process): Add (:file "file") as an option for
8684 the STDOUT buffer.
8685 (Fcall_process_region): Ditto.
8686
330d880c
EZ
86872011-04-30 Eli Zaretskii <eliz@gnu.org>
8688
8db90b73
EZ
8689 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8690 rather than `XVECTOR (FOO)->size'.
8691
330d880c
EZ
8692 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8693 inttypes.h, as a gnulib replacement is used if it not available in
8694 system headers.
8695
15cbd324
EZ
86962011-04-21 Eli Zaretskii <eliz@gnu.org>
8697
8698 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8699 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8700 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8701
8702 * coding.c (coding_alloc_by_realloc): Error out if destination
8703 will grow beyond MOST_POSITIVE_FIXNUM.
8704 (decode_coding_emacs_mule): Abort if there isn't enough place in
8705 charbuf for the composition carryover bytes. Reserve an extra
8706 space for up to 2 characters produced in a loop.
8707 (decode_coding_iso_2022): Abort if there isn't enough place in
8708 charbuf for the composition carryover bytes.
8709
87102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8711
ae940cca
EZ
8712 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8713 aborting when %lld or %lll format is passed.
8714 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8715 %llo or %llx format is passed. (Bug#8545)
8716
03ab8921
EZ
8717 * window.c (window_scroll_line_based): Use a marker instead of
8718 simple variables to record original value of point. (Bug#7952)
8719
afda1437
EZ
8720 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8721 produced by %s or %c overflows available buffer space. (Bug#8545)
8722
f76dee0c
PE
87232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8724
8725 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8726 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8727
fdc5744d
JB
87282011-04-28 Juanma Barranquero <lekktu@gmail.com>
8729
8730 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8731
638f053a
JB
87322011-04-28 Juanma Barranquero <lekktu@gmail.com>
8733
8734 * keyboard.c (Qdelayed_warnings_hook): Define.
8735 (command_loop_1): Run `delayed-warnings-hook'
8736 if Vdelayed_warnings_list is non-nil.
8737 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8738 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8739
d178f871
EZ
87402011-04-28 Eli Zaretskii <eliz@gnu.org>
8741
8742 * doprnt.c (doprnt): Don't return value smaller than the buffer
8743 size if the message was truncated. (Bug#8545).
8744
b124fd93
JB
87452011-04-28 Juanma Barranquero <lekktu@gmail.com>
8746
8747 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8748 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8749
e810457d
PE
87502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8751
8752 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8753
ea51cceb
JB
87542011-04-27 Juanma Barranquero <lekktu@gmail.com>
8755
8756 * makefile.w32-in: Update dependencies.
8757
94dcfacf
EZ
87582011-04-27 Eli Zaretskii <eliz@gnu.org>
8759
8760 Improve `doprnt' and its usage. (Bug#8545)
8761 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8762 `format_end'. Remove support for %l as a conversion specifier.
8763 Don't use xrealloc. Improve diagnostics when the %l size modifier
8764 is used. Update the commentary.
8765
8766 * eval.c (verror): Simplify calculation of size_t.
8767
8768 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8769 messages.
8770
f61f41d7
PE
87712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8772
8773 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8774 change.
8775
96fb4434
PE
87762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8777
8778 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8779 This makes this file independent of the recent pseudovector change.
8780
671875da 87812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8782
69e9b5a3
PE
8783 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8784
b5f869a7 8785 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8786 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8787 Remove unused local.
c8926152 8788 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8789
841a1577 8790 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8791 GCC 4.6.0 optimizes based on type-based alias analysis.
8792 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8793 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8794 != &v->size, and therefore "v->size = 1; b->size = 2; return
8795 v->size;" must therefore return 1. This assumption is incorrect
8796 for Emacs, since it type-puns struct Lisp_Vector * with many other
8797 types. To fix this problem, this patch adds a new type struct
f904488f 8798 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8799 and pseudovectors, and helps optimizing compilers not get fooled
8800 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8801 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8802 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8803 the size member.
eab3844f
PE
8804 (XSETPVECTYPE): Rewrite in terms of new macro.
8805 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8806 This is a bit clearer, and further avoids the possibility of
8807 undesirable aliasing.
8808 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8809 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8810 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8811 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8812 (ASIZE): Now uses header.size rather than size.
8813 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8814 to avoid the hassle of writing XVECTOR (foo)->header.size.
8815 (struct vectorlike_header): New type.
eab3844f
PE
8816 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8817 object, to help avoid aliasing.
8818 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8819 (SUBRP): Likewise, since Lisp_Subr is a special case.
8820 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8821 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8822 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8823 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8824 changed to be "header.size" and "header.next".
8825 * buffer.h (struct buffer): Likewise.
8826 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8827 * frame.h (struct frame): Likewise.
8828 * process.h (struct Lisp_Process): Likewise.
8829 * termhooks.h (struct terminal): Likewise.
8830 * window.c (struct save_window_data, struct saved_window): Likewise.
8831 * window.h (struct window): Likewise.
8832 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8833 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8834 * buffer.c (init_buffer_once): Likewise.
8835 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8836 special case.
8837 * process.c (Fformat_network_address): Use local var for size,
8838 for brevity.
8839
0df1eac5
PE
8840 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8841
847ab9d1 8842 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8843 * data.c (atof): Remove decl; no longer used or needed.
8844 (digit_to_number): Move to lread.c.
8845 (Fstring_to_number): Use new string_to_number function, to be
8846 consistent with how the Lisp reader treats infinities and NaNs.
8847 Do not assume that floating-point numbers represent EMACS_INT
8848 without losing information; this is not true on most 64-bit hosts.
8849 Avoid double-rounding errors, by insisting on integers when
8850 parsing non-base-10 numbers, as the documentation specifies.
8851 * lisp.h (string_to_number): New decl, replacing ...
8852 (isfloat_string): Remove.
bc0a5c13 8853 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8854 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8855 appears to have been a coding error. Similarly, do not accept
8856 strings like +-1e0 as floating point numbers. Do not report
8857 overflow for integer overflows unless the base is not 10 which
8858 means we have no simple and reliable way to continue.
8859 Break out the floating-point parsing into a new
8860 function string_to_number, so that Fstring_to_number parses
8861 floating point numbers consistently with the Lisp reader.
04f2d78b 8862 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8863 (E_CHAR, EXP_INT): Remove, replacing with ...
8864 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8865 (string_to_number): New function, replacing isfloat_string.
8866 This function checks for valid syntax and produces the resulting
8867 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8868 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8869 so that overflow for non-base-10 numbers is reported only when
8870 there's no portable and simple way to convert to floating point.
452f4150 8871
67769ffc
PE
8872 * textprop.c (set_text_properties_1): Rewrite for clarity,
8873 and to avoid GCC warning about integer overflow.
8874
c20db43f
PE
8875 * intervals.h (struct interval): Use EMACS_INT for members
8876 where EMACS_UINT might cause problems. See
8877 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8878 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8879 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8880 All uses changed.
37aa2f85
PE
8881 (offset_intervals): Tell GCC not to worry about length overflow
8882 when negating a negative length.
c20db43f 8883
2538aa2f
PE
8884 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8885 (overrun_check_free): Likewise.
8886
f2d3008d
PE
8887 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8888 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8889 word size.
8890
ec8df744
PE
8891 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8892 (gnutls_make_error): Rename local to avoid shadowing.
8893 (gnutls_emacs_global_deinit): ifdef out; not used.
8894 (Fgnutls_boot): Use const for pointer to readonly storage.
8895 Comment out unused local. Fix pointer signedness problems.
8896
640ee02d
PE
8897 * lread.c (openp): Don't stuff size_t into an 'int'.
8898 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8899 about possible signed overflow.
8900
6048fb2a
PE
8901 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8902 (GDK_KEY_g): Don't define if already defined.
8903 (xg_prepare_tooltip): Avoid pointer signedness problem.
8904 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8905
fa3c87e1
PE
8906 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8907 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8908
2172544b
PE
8909 * xfns.c (Fx_window_property): Simplify a bit,
8910 to make a bit faster and to avoid GCC 4.6.0 warning.
8911 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8912
9b821a21
PE
8913 * fns.c (internal_equal): Don't assume size_t fits in int.
8914
3c616cfa
PE
8915 * alloc.c (compact_small_strings): Tighten assertion a little.
8916
c2982e87
PE
8917 Replace pEd with more-general pI, and fix some printf arg casts.
8918 * lisp.h (pI): New macro, generalizing old pEd macro to other
8919 conversion specifiers. For example, use "...%"pI"d..." rather
8920 than "...%"pEd"...".
8921 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8922 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8923 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8924 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8925 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8926 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8927 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8928 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8929 64-bit hosts.
8930 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8931 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8932 * print.c (safe_debug_print, print_object): Likewise.
8933 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8934 to int.
6f04d126
PE
8935 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8936 avoiding the 0 flag, which is not portable.
c2982e87
PE
8937 * process.c (Fmake_network_process): Use pI to avoid cast.
8938 * region-cache.c (pp_cache): Likewise.
8939 * xdisp.c (decode_mode_spec): Likewise.
8940 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8941 behavior on 64-bit hosts with printf arg.
6f04d126 8942 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8943 (x_stop_queuing_selection_requests): Likewise.
8944 (x_get_window_property): Don't truncate byte count to an 'int'
8945 when tracing.
0b432f21 8946
5e073ec7
PE
8947 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8948 here, since it parses constructs like leading '-' and spaces,
8949 which are not wanted; and it overflows with large numbers.
8950 Instead, simply match F[0-9]+, which is what is wanted anyway.
8951
36372bf9
PE
8952 * alloc.c: Remove unportable assumptions about struct layout.
8953 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8954 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8955 (allocate_vectorlike, make_pure_vector): Use the new macros,
8956 plus offsetof, to remove unportable assumptions about struct layout.
8957 These assumptions hold on all porting targets that I know of, but
8958 they are not guaranteed, they're easy to remove, and removing them
8959 makes further changes easier.
8960
0b432f21
PE
8961 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8962 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8963 (string_overrun_cookie): Now const. Use initializers that
8964 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8965 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8966 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8967 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8968 multiple of sizeof (EMACS_INT); it need not be, if
8969 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8970 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8971
895009e1
JB
89722011-04-26 Juanma Barranquero <lekktu@gmail.com>
8973
8974 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8975
6a7a1b0b
TZ
89762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8977
8978 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8979 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8980 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8981
841a1577 89822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8983
8984 * lisp.h (Qdebug): List symbol.
895009e1 8985 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8986 * keyboard.c (debug-on-event): New variable.
8987 (handle_user_signal): Break into debugger when debug-on-event
8988 matches the current signal symbol.
8989
f2d3ba6f
DN
89902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8991
8992 * alloc.c (check_sblock, check_string_bytes)
8993 (check_string_free_list): Convert to standard C.
8994
42ce4c63
TZ
89952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8996
8997 * w32.c (emacs_gnutls_push): Fix typo.
8998
825cd63c
EZ
89992011-04-25 Eli Zaretskii <eliz@gnu.org>
9000
fb11d64d
EZ
9001 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9002 "cast to pointer from integer of different size".
9003
825cd63c
EZ
9004 Improve doprnt and its use in verror. (Bug#8545)
9005 * doprnt.c (doprnt): Document the set of format control sequences
9006 supported by the function. Use SAFE_ALLOCA instead of always
9007 using `alloca'.
9008
9009 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9010 is one byte too soon. Don't use xrealloc; instead xfree and
9011 xmalloc anew.
9012
e061a11b
TZ
90132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9014
9015 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9016 callbacks stage.
9017
9018 * gnutls.c: Renamed global_initialized to
9019 gnutls_global_initialized. Added internals for the
9020 :verify-hostname-error, :verify-error, and :verify-flags
9021 parameters of `gnutls-boot' and documented those parameters in the
9022 docstring. Start callback support.
9173deec
JB
9023 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9024 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9025 on error. Return error code.
e061a11b
TZ
9026 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9027 (emacs_gnutls_read): Likewise.
9028 (Fgnutls_boot): Return handshake error code.
9029 (emacs_gnutls_handle_error): New function.
9030 (wsaerror_to_errno): Likewise.
9031
9032 * w32.h (emacs_gnutls_pull): Add prototype.
9033 (emacs_gnutls_push): Likewise.
9034
9035 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9036 (emacs_gnutls_push): Likewise.
9037
90382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9039
9040 * process.c (wait_reading_process_output): Check if GnuTLS
9041 buffered some data internally if no FDs are set for TLS
9042 connections.
9043
9044 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9045 (LIBS): Link to USER_LIBS.
9046 ($(BLD)/gnutls.$(0)): New target.
9047
fa6996bc
EZ
90482011-04-24 Eli Zaretskii <eliz@gnu.org>
9049
eb35682e
EZ
9050 * xdisp.c (handle_single_display_spec): Rename the
9051 display_replaced_before_p argument into display_replaced_p, to
9052 make it consistent with the commentary. Fix typos in the
9053 commentary.
9054
e2ad650c
EZ
9055 * textprop.c (syms_of_textprop): Remove dead code.
9056 (copy_text_properties): Delete obsolete commentary about an
9057 interface that was deleted long ago. Fix typos in the description
9058 of arguments.
9059
1b2de274
EZ
9060 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9061 to changes in oldXMenu/XMenu.h from 2011-04-16.
9062 <menu_help_message, prev_menu_help_message>: Constify.
9063 (IT_menu_make_room): menu->help_text is now `const char **';
9064 adjust.
9065
9066 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9067 to changes in oldXMenu/XMenu.h from 2011-04-16.
9068 (struct XMenu): Declare `help_text' `const char **'.
9069
9070 * xfaces.c <Qunspecified>: Make extern again.
9071
9072 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9073 required by POSIX.
1b2de274 9074
762b15be
EZ
9075 * doc.c (get_doc_string): Improve the format passed to `error'.
9076
9077 * doprnt.c (doprnt): Improve commentary.
9078
9079 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9080
9081 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9082 them with etags.
9083
f1052e5d
EZ
9084 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9085 changes in globals.h immediately force recompilation.
762b15be
EZ
9086 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9087 $(CURDIR)/s/ms-w32.h.
9088 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9089
fa6996bc
EZ
9090 * character.c (Fchar_direction): Function deleted.
9091 (syms_of_character): Don't defsubr it.
9092 <char-direction-table>: Deleted.
9093
e6c3da20
EZ
90942011-04-23 Eli Zaretskii <eliz@gnu.org>
9095
9096 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9097 * doprnt.c: Include limits.h.
9098 (SIZE_MAX): New macro.
04f2d78b
CB
9099 (doprnt): Return a size_t value. 2nd arg is now size_t.
9100 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9101 Improve overflow protection. Support `l' modifier for integer
9102 conversions. Support %l conversion. Don't assume an EMACS_INT
9103 argument for integer conversions and for %c.
9104
9105 * lisp.h (doprnt): Restore prototype.
9106
9107 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9108 $(SRC)/character.h.
9109
9110 * Makefile.in (base_obj): Add back doprnt.o.
9111
9112 * deps.mk (doprnt.o): Add back prerequisites.
9113 (callint.o): Depend on character.h.
9114
9115 * eval.c (internal_lisp_condition_case): Include the handler
9116 representation in the error message.
9117 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9118 when breaking from the loop.
9119
9120 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9121
9122 * callint.c (Fcall_interactively): When displaying error message
9123 about invalid control letter, pass the character's codepoint, not
9124 a pointer to its multibyte form. Improve display of the character
9125 in octal and display also its hex code.
9126
9127 * character.c (char_string): Use %x to display the (unsigned)
9128 codepoint of an invalid character, to avoid displaying a bogus
9129 negative value.
9130
9131 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9132 `error', not SYMBOL_NAME itself.
9133
9134 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9135 character arguments to `error'.
9136
9137 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9138 to `error' in error message about FINAL_CHAR argument. Make sure
9139 FINAL_CHAR is a character, and use %c when it is passed as
9140 argument to `error'.
9141
4ffd0d6b 91422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9143
9144 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9145
9146 * w32.c: Include <time.h>.
9147 (sys_localtime): New function.
9148
4ffd0d6b 91492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9150
9151 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9152
4ffd0d6b 9153 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9154
4ffd0d6b 91552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9156
4ffd0d6b
GM
9157 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9158 zombies (Bug#8467).
aac0c6e3 9159
04c56954
EZ
91602011-04-19 Eli Zaretskii <eliz@gnu.org>
9161
9162 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9163 gl_state.e_property when gl_state.object is Qt.
9164
9165 * insdel.c (make_gap_larger): Remove limitation of buffer size
9166 to <= INT_MAX.
9167
16a43933
CY
91682011-04-18 Chong Yidong <cyd@stupidchicken.com>
9169
9170 * xdisp.c (lookup_glyphless_char_display)
9171 (produce_glyphless_glyph): Handle cons cell entry in
9172 glyphless-char-display.
9173 (Vglyphless_char_display): Document it.
9174
9175 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9176 glyphless-char-display.
9177
4581706e
CY
91782011-04-17 Chong Yidong <cyd@stupidchicken.com>
9179
9180 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9181
9182 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9183
9184 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9185 definition for no-X builds.
9186
4887c6e2 91872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9188
fd35b6f9
PE
9189 Static checks with GCC 4.6.0 and non-default toolkits.
9190
5c1ccb01
PE
9191 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9192
006c5daa
PE
9193 * process.c (keyboard_bit_set): Define only if SIGIO.
9194 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9195 (send_process): Repair possible setjmp clobbering.
9196
efc736d3
PE
9197 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9198
4e2fe2e6
PE
9199 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9200
f97334a2
PE
9201 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9202
4e75f29d
PE
9203 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9204 Define only if needed.
9205
90efadd1
PE
9206 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9207 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9208 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9209
3c647824
PE
9210 * dispextern.h (struct redisplay_interface): Rename param
9211 to avoid shadowing.
e264f262 9212 * termhooks.h (struct terminal): Likewise.
761383f4 9213 * xterm.c (xembed_send_message): Likewise.
3c647824 9214
b58c5c4a
PE
9215 * insdel.c (make_gap_smaller): Define only if
9216 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9217
cad59032
PE
9218 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9219 it.
9220
c339dc2e
PE
9221 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9222 so that we aren't warned about unused symbols.
9223
91a3e27b
PE
9224 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9225
399c71d3 9226 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9227
8ffc96f5
PE
9228 * xfns.c (x_real_positions): Mark locals as initialized.
9229
eef9bc79
PE
9230 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9231
098db9dd
PE
9232 * xterm.c: Fix problems found by static analysis with other toolkits.
9233 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9234 (x_dispatch_event): Declare static if USE_GTK, and
9235 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9236 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9237 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9238 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9239 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9240
eb18f6cc
PE
9241 * xmenu.c (menu_help_callback): Pointer type fixes.
9242 Use const pointers when pointing at readonly data. Avoid pointer
9243 signedness clashes.
9244 (FALSE): Remove unused macro.
9245 (update_frame_menubar): Remove unused decl.
9246
1fe72bf8
PE
9247 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9248
60d9e1db
PE
9249 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9250 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9251 (single_menu_item): Rename local to avoid shadowing.
9252
39261c26
PE
9253 * keyboard.c (make_lispy_event): Remove unused local var.
9254
018c5e19
PE
9255 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9256 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9257
63d2b86e
PE
9258 * bitmaps: Change bitmaps from unsigned char back to the X11
9259 compatible char. Avoid the old compiler warnings about
9260 out-of-range initializers by using, for example, '\xab' rather
9261 than 0xab.
9262
aefd87e1
PE
9263 * xgselect.c (xgselect_initialize): Check vs interface
9264 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9265
bf501fb9
PE
9266 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9267
e9829fdf
PE
9268 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9269 to read-only memory.
9270
1086c095
PE
9271 * fns.c (vector): Remove; this old hack is no longer needed.
9272
2baccd04 9273 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9274 Remove unused var.
dde42981 9275 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9276
72391843 9277 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9278
436c16df 9279 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9280 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9281 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9282
92bb796d 9283 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9284 (x_term_init): Remove local to avoid shadowing.
92bb796d 9285
764430a3 9286 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9287
9288 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9289 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9290
d1dfb56c
EZ
92912011-04-16 Eli Zaretskii <eliz@gnu.org>
9292
c4354cb4
EZ
9293 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9294
d1dfb56c
EZ
9295 Fix regex.c, syntax.c and friends for buffers > 2GB.
9296 * syntax.h (struct gl_state_s): Declare character position members
9297 EMACS_INT.
9298
9299 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9300
04f2d78b
CB
9301 * textprop.c (verify_interval_modification, interval_of):
9302 Declare arguments EMACS_INT.
d1dfb56c
EZ
9303
9304 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9305 EMACS_INT.
9306
9307 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9308
9309 * indent.c (Fvertical_motion): Local variable it_start is now
9310 EMACS_INT.
9311
9312 * regex.c (re_match, re_match_2, re_match_2_internal)
9313 (bcmp_translate, regcomp, regexec, print_double_string)
9314 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9315 (re_compile_pattern, re_exec): Declare arguments and local
9316 variables `size_t' and `ssize_t' and return values `regoff_t', as
9317 appropriate.
9318 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9319 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9320 <compile_stack_type>: `size' and `avail' are now `size_t'.
9321
9322 * regex.h <regoff_t>: Use ssize_t, not int.
9323 (re_search, re_search_2, re_match, re_match_2): Arguments that
9324 specify buffer/string position and length are now ssize_t and
9325 size_t. Return type is regoff_t.
9326
613052cd
BK
93272011-04-16 Ben Key <bkey76@gmail.com>
9328
9329 * nsfont.m: Fixed bugs in ns_get_family and
9330 ns_descriptor_to_entity that were caused by using free to
9331 deallocate memory blocks that were allocated by xmalloc (via
9332 xstrdup). This caused Emacs to crash when compiled with
9333 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9334 --enable-checking=xmallocoverrun). xfree is now used to
9335 deallocate these memory blocks.
9336
4170f62f 93372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9338
71b41406
PE
9339 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9340
9587a89d
PE
9341 emacs_write: Accept and return EMACS_INT for sizes.
9342 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9343 et seq.
9344 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9345 Accept and return EMACS_INT.
9346 (emacs_gnutls_write): Return the number of bytes written on
9347 partial writes.
9348 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9349 (emacs_read, emacs_write): Remove check for negative size, as the
9350 Emacs source code has been audited now.
9587a89d
PE
9351 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9352 (emacs_read, emacs_write): Use it.
273a5f82
PE
9353 * process.c (send_process): Adjust to the new signatures of
9354 emacs_write and emacs_gnutls_write. Do not attempt to store
9355 a byte offset into an 'int'; it might overflow.
9587a89d 9356 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9357
3e047f51
PE
9358 * sound.c: Don't assume sizes fit in 'int'.
9359 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9360 Return EMACS_INT, not int.
3e047f51 9361 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9362 Accept EMACS_INT, not int.
9363 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9364 record read return values.
9365
cc39a9db
BK
93662011-04-15 Ben Key <bkey76@gmail.com>
9367
c9d0ec6d
JB
9368 * keyboard.c (Qundefined): Don't declare static since it is used
9369 in nsfns.m.
9370 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9371 static since they are used in nsfont.m.
cc39a9db 9372
6c60eb9f
SM
93732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9374
9375 * process.c (Qprocessp): Don't declare static.
9376 * lisp.h (Qprocessp): Declare again.
9377
7990b61a
JB
93782011-04-15 Juanma Barranquero <lekktu@gmail.com>
9379
9380 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9381
5d4cb038
PE
93822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9383
8bd7b830 9384 Improve C-level modularity by making more things 'static'.
cd64ea1d 9385
e3b27b31
PE
9386 Don't publish debugger-only interfaces to other modules.
9387 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9388 (verify_bytepos, count_markers): Move decls to the only modules
9389 that need them.
9390 * region-cache.h (pp_cache): Likewise.
9391 * window.h (check_all_windows): Likewise.
9392 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9393
5d4cb038
PE
9394 * sysdep.c (croak): Now static, if
9395 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9396 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9397
9398 * alloc.c (refill_memory_reserve): Now static if
9399 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9400 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9401
e87b6180
PE
9402 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9403 Define only if USE_LUCID.
9404
ac64929e
PE
9405 * xrdb.c (x_customization_string, x_rm_string): Now static.
9406
6f37259d
PE
9407 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9408 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9409
1683e3ab
PE
9410 * xdisp.c (draw_row_with_mouse_face): Now static.
9411 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9412
de9c2632
PE
9413 * window.h (check_all_windows): Mark externally visible.
9414
2b96acb7
PE
9415 * window.c (window_deletion_count): Now static.
9416
9417 * undo.c: Make symbols static if they're not exported.
9418 (last_undo_buffer, last_boundary_position, pending_boundary):
9419 Now static.
9420
50436f33
PE
9421 * textprop.c (interval_insert_behind_hooks): Now static.
9422 (interval_insert_in_front_hooks): Likewise.
9423
64520e5c
PE
9424 * term.c: Make symbols static if they're not exported.
9425 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9426 (max_frame_lines, tty_set_terminal_modes):
9427 (tty_reset_terminal_modes, tty_turn_off_highlight):
9428 (get_tty_terminal): Now static.
9429 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9430 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9431 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9432 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9433 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9434
1fa53021
PE
9435 * sysdep.c: Make symbols static if they're not exported.
9436 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9437 Now static.
9438 (sigprocmask_set, full_mask): Remove; unused.
9439 (wait_debugging): Mark as visible.
9440 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9441 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9442
d4b43b22
PE
9443 * syntax.c (syntax_temp): Define only if !__GNUC__.
9444
b7c513d0
PE
9445 * sound.c (current_sound_device, current_sound): Now static.
9446
989b29ad
PE
9447 * search.c (searchbufs, searchbuf_head): Now static.
9448
13a55a78
PE
9449 * scroll.c (scroll_cost): Remove; unused.
9450 * dispextern.h (scroll_cost): Remove decl.
9451
de68a1fc
PE
9452 * region-cache.h (pp_cache): Mark as externally visible.
9453
40ccffa6
PE
9454 * process.c: Make symbols static if they're not exported.
9455 (process_tick, update_tick, create_process, chan_process):
9456 (Vprocess_alist, proc_buffered_char, datagram_access):
9457 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9458 (deactivate_process): Mark defn as static, as well as decl.
9459 * lisp.h (create_process): Remove decl.
9460 * process.h (chan_process, Vprocess_alist): Remove decls.
9461
ad64fc97
PE
9462 * print.c: Make symbols static if they're not exported.
9463 (print_depth, new_backquote_output, being_printed, print_buffer):
9464 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9465 (print_interval, print_number_index, initial_stderr_stream):
9466 Now static.
9467 * lisp.h (Fprinc): Remove decl.
9468 (debug_output_compilation_hack): Mark as externally visible.
9469
adddb265
PE
9470 * sysdep.c (croak): Move decl from here to syssignal.h.
9471 * syssignal.h (croak): Put it here, so the API can be checked when
9472 'croak' is called from dissociate_if_controlling_tty.
9473
1717ede2
PE
9474 * minibuf.c: Make symbols static if they're not exported.
9475 (minibuf_save_list, choose_minibuf_frame): Now static.
9476 * lisp.h (choose_minibuf_frame): Remove decl.
9477
fa5fb2bc
PE
9478 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9479
1e3890d1
PE
9480 * lread.c: Make symbols static if they're not exported.
9481 (read_objects, initial_obarray, oblookup_last_bucket_number):
9482 Now static.
9483 (make_symbol): Remove; unused.
9484 * lisp.h (initial_obarray, make_symbol): Remove decls.
9485
8a1414fa
PE
9486 * keyboard.c: Make symbols static if they're not exported.
9487 (single_kboard, recent_keys_index, total_keys, recent_keys):
9488 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9489 (this_single_command_key_start, echoing, last_auto_save):
9490 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9491 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9492 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9493 (Vlispy_mouse_stem, double_click_count):
9494 Now static.
9495 (force_auto_save_soon): Define only if SIGDANGER.
9496 (ignore_mouse_drag_p): Now static if
9497 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9498 (print_help): Remove; unused.
9499 (stop_character, last_timer_event): Mark as externally visible.
9500 * keyboard.h (ignore_mouse_drag_p): Declare only if
9501 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9502 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9503 * lisp.h (echoing): Remove decl.
9504 (force_auto_save_soon): Declare only if SIGDANGER.
9505 * xdisp.c (redisplay_window): Simplify code, to make it more
9506 obvious that ignore_mouse_drag_p is not accessed if !defined
9507 USE_GTK && !defined HAVE_NS.
9508
93ea6e8f
PE
9509 * intervals.c: Make symbols static if they're not exported.
9510 (merge_properties_sticky, merge_interval_right, delete_interval):
9511 Now static.
9512 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9513
77382fcc
PE
9514 * insdel.c: Make symbols static if they're not exported.
9515 However, leave prepare_to_modify_buffer alone. It's never
9516 called from outside this function, but that appears to be a bug.
9517 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9518 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9519 (adjust_after_replace_noundo): Remove; unused.
9520 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9521 (signal_before_change): Remove decls.
77382fcc 9522
9306c32e
PE
9523 * indent.c (val_compute_motion, val_vmotion): Now static.
9524
cd44d2eb
PE
9525 * image.c: Make symbols static if they're not exported.
9526 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9527 if USE_GTK.
9528 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9529 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9530
ad9a7a06
PE
9531 * fringe.c (standard_bitmaps): Now static.
9532 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9533
81626931
PE
9534 * frame.c: Make symbols static if they're not exported.
9535 (x_report_frame_params, make_terminal_frame): Now static.
9536 (get_frame_param): Now static, unless HAVE_NS.
9537 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9538 (x_get_resource_string): Remove; not used.
9539 * frame.h (make_terminal_frame, x_report_frame_params):
9540 (x_get_resource_string); Remove decls.
9541 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9542 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9543
239f9db9
PE
9544 * font.c, fontset.c: Make symbols static if they're not exported.
9545 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9546 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9547 * font.c (font_close_object): Now static.
9548 * font.h (font_close_object): Remove.
9549 * fontset.c (FONTSET_OBJLIST): Remove.
9550 (free_realized_fontset) #if-0 the body, which does nothing.
9551 (face_suitable_for_char_p): #if-0, as it's never called.
9552 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9553 * xfaces.c (face_at_string_position):
9554 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9555 since 0 is always ASCII.
9556
dfcf3579
PE
9557 * fns.c (weak_hash_tables): Now static.
9558
5045092b
PE
9559 * fileio.c: Make symbols static if they're not exported.
9560 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9561 (Vwrite_region_annotation_buffers): Now static.
9562
57a96f5c
PE
9563 * eval.c: Make symbols static if they're not exported.
9564 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9565 * lisp.h (backtrace_list): Remove decl.
9566
35f08c38
PE
9567 * emacs.c: Make symbols static if they're not exported.
9568 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9569 (fatal_error_code, fatal_error_signal_hook, standard_args):
9570 Now static.
9571 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9572 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9573 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9574 * lisp.h (fatal_error_signal_hook): Remove decl.
9575 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9576
f44bd759
PE
9577 * editfns.c: Move a (normally-unused) function to its only use.
9578 * editfns.c, lisp.h (get_operating_system_release): Remove.
9579 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9580 worth the hassle of breaking this out.
9581
b532497d
PE
9582 * xterm.c: Make symbols static if they're not exported.
9583 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9584 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9585 (x_destroy_window, x_delete_display):
9586 Now static.
9587 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9588 (x_mouse_leave): Remove; unused.
9589 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9590 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9591 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9592 Remove decls.
9593 (x_mouse_leave): Declare only if WINDOWSNT.
9594 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9595 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9596 USE_X_TOOLKIT.
9597
1675728f
PE
9598 * ftxfont.c: Make symbols static if they're not exported.
9599 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9600 HAVE_FREETYPE.
9601 * font.h (ftxfont_driver): Likewise.
9602
e4cebfca
PE
9603 * xfns.c: Make symbols static if they're not exported.
9604 (x_last_font_name, x_display_info_for_name):
9605 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9606 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9607 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9608 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9609 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9610 (last_show_tip_args): Now static.
9611 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9612 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9613 (x_screen_planes): Remove; unused.
9614 * dispextern.h (x_screen_planes): Remove decl.
9615
5bf46f05
PE
9616 * dispnew.c: Make symbols static if they're not exported.
9617 * dispextern.h (redraw_garbaged_frames, scrolling):
9618 (increment_row_positions): Remove.
9619 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9620 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9621 Now static.
9622 (redraw_garbaged_frames): Remove; unused.
9623
435f4c28
PE
9624 * xfaces.c: Make symbols static if they're not exported.
9625 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9626 Remove decls.
9627 * xterm.h (defined_color): Remove decls.
9628 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9629 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9630 (menu_face_changed_default, defined_color, free_realized_face):
9631 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9632 (ascii_face_of_lisp_face): Remove; unused.
9633
8524aef3
PE
9634 * xdisp.c: Make symbols static if they're not exported.
9635 * dispextern.h (scratch_glyph_row, window_box_edges):
9636 (glyph_to_pixel_coords, set_cursor_from_row):
9637 (get_next_display_element, set_iterator_to_next):
9638 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9639 (show_mouse_face): Remove decls
9640 * frame.h (message_buf_print): Likewise.
9641 * lisp.h (pop_message, set_message, check_point_in_composition):
9642 Likewise.
9643 * xterm.h (set_vertical_scroll_bar): Likewise.
9644 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9645 (message_buf_print, scratch_glyph_row, displayed_buffer):
9646 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9647 (get_next_display_element, show_mouse_face, window_box_edges):
9648 (frame_to_window_pixel_xy, check_point_in_composition):
9649 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9650 (glyph_to_pixel_coords): Remove; unused.
9651
16390cd2
PE
9652 * dired.c (file_name_completion): Now static.
9653
9654 * dbusbind.c (xd_in_read_queued_messages): Now static.
9655
a25f4dfa
PE
9656 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9657 * data.c (circular_list_error): Remove.
9658
14a9c8df
PE
9659 * commands.h (last_point_position, last_point_position_buffer):
9660 (last_point_position_window): Remove decls.
9661 * keyboard.c: Make these variables static.
9662
04f2d78b
CB
9663 * coding.h (coding, code_convert_region, encode_coding_gap):
9664 Remove decls.
74ab6df5
PE
9665 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9666 (iso_code_class, detect_coding, code_convert_region): Now static.
9667 (encode_coding_gap): Remove; unused.
9668
38dfbee1
PE
9669 * chartab.c (chartab_chars, chartab_bits): Now static.
9670
a2cb4e63
PE
9671 * charset.h (charset_iso_8859_1): Remove decl.
9672 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9673 Now static.
9674
127198fd
PE
9675 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9676 * ccl.c (Vccl_program_table): Now static.
9677 (check_ccl_update): Remove; unused.
9678
d85b608f
PE
9679 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9680 * category.h: ... from here.
9681 * category.c (check_category_table, set_category_set): Now static.
9682
31cd66f3
PE
9683 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9684 * lisp.h: Remove these decls.
9685
c358e587
PE
9686 * buffer.c (buffer_count): Remove unused var.
9687
e78aecca
PE
9688 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9689 so that it's not optimized away.
9690 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9691 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9692 exported only to the debugger.
9693
e192d7d3 9694 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9695 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9696
92470028
PE
9697 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9698 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9699 was inaccessible from Lisp.
9700 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9701 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9702
244ed907
PE
9703 alloc.c: Import and export fewer symbols, and remove unused items.
9704 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9705 is defined.
9706 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9707 it's not optimized away by whole-program optimization.
9708 (message_enable_multibyte, free_misc): Remove.
9709 (catchlist, handlerlist, mark_backtrace):
9710 Declare only if BYTE_MARK_STACK.
9711 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9712 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9713 (message_enable_multibyte): Remove decl.
9714 (free_misc, interval_free_list, float_block, float_block_index):
9715 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9716 (cons_free_list, last_marked_index):
9717 Now static.
9718 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9719 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9720 (mark_backtrace): Define only if BYTE_MARK_STACK.
9721 * xdisp.c (message_enable_multibyte): Now static.
9722
61c2b50e 9723 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9724 This makes it easier for human readers (and static analyzers)
9725 to see whether these variables are used from other modules.
9726 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9727 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9728 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9729 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9730 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9731 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9732 * xmenu.c, xselect.c:
9733 Declare Q* vars static if they are not used in other modules.
9734 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9735 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9736 Remove decls of unexported vars.
9737 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9738
95c82688
PE
9739 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9740
16a97296
PE
9741 Make Emacs functions such as Fatom 'static' by default.
9742 This makes it easier for human readers (and static analyzers)
9743 to see whether these functions can be called from other modules.
9744 DEFUN now defines a static function. To make the function external
9745 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9746 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9747 (Finit_image_library):
16a97296
PE
9748 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9749 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9750 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9751 Remove decls, since these functions are now static.
9752 (Funintern, Fget_internal_run_time): New decls, since these functions
9753 were already external.
95c82688 9754
16a97296
PE
9755 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9756 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9757 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9758 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9759 * keyboard.c, keymap.c, lread.c:
9760 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9761 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9762 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9763 Mark functions with DEFUE instead of DEFUN,
9764 if they are used in other modules.
9765 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9766 decls for now-static functions.
9767 * buffer.h (Fdelete_overlay): Remove decl.
9768 * callproc.c (Fgetenv_internal): Mark as internal.
9769 * composite.c (Fremove_list_of_text_properties): Remove decl.
9770 (Fcomposition_get_gstring): New forward static decl.
9771 * composite.h (Fcomposite_get_gstring): Remove decl.
9772 * dired.c (Ffile_attributes): New forward static decl.
9773 * doc.c (Fdocumntation_property): New forward static decl.
9774 * eval.c (Ffetch_bytecode): New forward static decl.
9775 (Funintern): Remove extern decl; now in .h file where it belongs.
9776 * fileio.c (Fmake_symbolic_link): New forward static decl.
9777 * image.c (Finit_image_library): New forward static decl.
9778 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9779 * intervals.h (Fprevious_property_change):
9780 (Fremove_list_of_text_properties): Remove decls.
9781 * keyboard.c (Fthis_command_keys): Remove decl.
9782 (Fcommand_execute): New forward static decl.
9783 * keymap.c (Flookup_key): New forward static decl.
9784 (Fcopy_keymap): Now static.
9785 * keymap.h (Flookup_key): Remove decl.
9786 * process.c (Fget_process): New forward static decl.
9787 (Fprocess_datagram_address): Mark as internal.
9788 * syntax.c (Fsyntax_table_p): New forward static decl.
9789 (skip_chars): Remove duplicate decl.
9790 * textprop.c (Fprevious_property_change): New forward static decl.
9791 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9792 Now internal.
9793 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9794 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9795
785bbd42
PE
9796 * editfns.c (Fformat): Remove unreachable code.
9797
8b913b57
AS
97982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9799
9800 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9801 change. (Bug#8496)
9802
a6744a35
EZ
98032011-04-13 Eli Zaretskii <eliz@gnu.org>
9804
9805 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9806 when at ZV. (Bug#8487)
9807
e7974947
AS
98082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9809
baad03f0
AS
9810 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9811 (Bug#8437)
9812 * keyboard.c (parse_tool_bar_item): Likewise.
9813 * sound.c (sound_cleanup, alsa_close): Likewise.
9814 * termcap.c (tgetent): Likewise.
9815 * xfns.c (x_default_font_parameter): Likewise.
9816 * xsettings.c (read_and_apply_settings): Likewise.
9817
e7974947
AS
9818 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9819 (overrun_check_free): Protoize.
9820
28272684
PE
98212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9822
9823 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9824 since callers should never pass a negative size.
9825 Change the signature to match that of plain 'read' and 'write'; see
9826 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9827 * lisp.h: Update prototypes of emacs_write and emacs_read.
9828
11997c76
EZ
98292011-04-11 Eli Zaretskii <eliz@gnu.org>
9830
9831 * xdisp.c (redisplay_window): Don't try to determine the character
9832 position of the scroll margin if the window start point w->startp
e896f03c 9833 is outside the buffer's accessible region. (Bug#8468)
11997c76 9834
8a2cbd72
EZ
98352011-04-10 Eli Zaretskii <eliz@gnu.org>
9836
9837 Fix write-region and its subroutines for buffers > 2GB.
9838 * fileio.c (a_write, e_write): Modify declaration of arguments and
9839 local variables to support buffers larger than 2GB.
9840 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9841
9842 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9843 argument, local variables, and return value.
9844
9845 * lisp.h: Update prototypes of emacs_write and emacs_read.
9846
9847 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9848
4073e537 98492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9850
1ebfdcb6
PE
9851 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9852
b2ded58d
PE
9853 Fix more problems found by GCC 4.6.0's static checks.
9854
7d66342c
PE
9855 * xdisp.c (vmessage): Use a better test for character truncation.
9856
bbf47d44
PE
9857 * charset.c (load_charset_map): <, not <=, for optimization,
9858 and to avoid potential problems with integer overflow.
9248994d 9859 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9860 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9861 * editfns.c (Fformat): Likewise.
1e69125e 9862 * syntax.c (skip_chars): Likewise.
3befa583 9863
e3019616
PE
9864 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9865 This also lets GCC 4.6.0 generate slightly better loop code.
9866
becfa255
PE
9867 * callint.c (Fcall_interactively): <, not <=, for optimization.
9868 (Fcall_interactively): Count the number of arguments produced,
9869 not the number of arguments given. This is simpler and lets GCC
9870 4.6.0 generate slightly better code.
9871
dae0cd48
PE
9872 * ftfont.c: Distingish more carefully between FcChar8 and char.
9873 The previous code passed unsigned char * to a functions like
9874 strlen and xstrcasecmp that expect char *, which does not
9875 conform to the C standard.
9876 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9877 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9878 char * when the C standard requires it.
9879
76032d70
PE
9880 * keyboard.c (read_char): Remove unused var.
9881
eb3f1cc8
PE
9882 * eval.c: Port to Windows vsnprintf (Bug#8435).
9883 Include <limits.h>.
9884 (SIZE_MAX): Define if the headers do not.
9885 (verror): Do not give up if vsnprintf returns a negative count.
9886 Instead, grow the buffer. This ports to Windows vsnprintf, which
9887 does not conform to C99. Problem reported by Eli Zaretskii.
9888 Also, simplify the allocation scheme, by avoiding the need for
9889 calling realloc, and removing the ALLOCATED variable.
9890
70476b54
PE
9891 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9892
12020a9e
PE
9893 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9894 But keep the doprint source code for now, as we might revamp it
9895 and use it again (Bug#8435).
ea6c7ae6
PE
9896 * lisp.h (doprnt): Remove.
9897 * Makefile.in (base_obj): Remove doprnt.o.
9898 * deps.mk (doprnt.o): Remove.
9899
5fdb398c
PE
9900 error: Print 32- and 64-bit integers portably (Bug#8435).
9901 Without this change, on typical 64-bit hosts error ("...%d...", N)
9902 was used to print both 32- and 64-bit integers N, which relied on
9903 undefined behavior.
61bdb816 9904 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9905 * lisp.h (error, verror): Mark as printf-like functions.
9906 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9907 Report overflow in size calculations when allocating printf buffer.
9908 Do not truncate output string at its first null byte.
9909 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9910 Truncate the output at a character boundary, since vsnprintf does not
9911 do that.
9912 * charset.c (check_iso_charset_parameter): Convert internal
9913 character to string before calling 'error', since %c now has the
9914 printf meaning.
9915 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9916 overflow when computing char to be passed to 'error'. Do not
9917 pass Lisp_Object to 'error'; pass the integer instead.
9918 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9919 formatted with plain %d.
9920
b189fa66
PE
9921 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9922
bff87ef0
PE
9923 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9924
7e2cac20
PE
9925 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9926
ce4d90b5
PE
9927 * xterm.c (x_catch_errors): Remove duplicate declaration.
9928
266c9547
PE
9929 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9930
79c49ad2
PE
9931 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9932
368f4090
JM
99332011-04-10 Jim Meyering <meyering@redhat.com>
9934
9935 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9936 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9937 return ssize_t not "int", and use size_t as the buffer length.
9938 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9939 * gnutls.h: Update declarations.
9940 * process.c (read_process_output): Use ssize_t, to match.
9941 (send_process): Likewise.
9942
a32d4040
CY
99432011-04-09 Chong Yidong <cyd@stupidchicken.com>
9944
9945 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9946
8546720e 99472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9948
04f2d78b
CB
9949 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9950 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9951
8546720e
GM
9952 * xterm.c (handle_one_xevent):
9953 * xmenu.c (create_and_show_popup_menu):
9954 * xselect.c (x_decline_selection_request)
9955 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9956
0a2f5c1a 99572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9958
9959 Fix some uses of `int' instead of EMACS_INT.
9960 * search.c (string_match_1, fast_string_match)
9961 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9962 (scan_buffer, find_next_newline_no_quit)
9963 (find_before_next_newline, search_command, Freplace_match)
9964 (Fmatch_data): Make some `int' variables be EMACS_INT.
9965
9966 * xdisp.c (display_count_lines): 3rd argument and return value now
9967 EMACS_INT. All callers changed.
9968 (pint2hrstr): Last argument is now EMACS_INT.
9969
9970 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9971 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9972 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9973 (decode_coding_utf_16, decode_coding_emacs_mule)
9974 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9975 (decode_coding_ccl, decode_coding_charset)
9976 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9977 (decode_coding_iso_2022, decode_coding_emacs_mule)
9978 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9979 <char_offset, last_offset>: Declare EMACS_INT.
9980 (encode_coding_utf_8, encode_coding_utf_16)
9981 (encode_coding_emacs_mule, encode_invocation_designation)
9982 (encode_designation_at_bol, encode_coding_iso_2022)
9983 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9984 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9985 Declare EMACS_INT.
9986 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9987 (encode_invocation_designation): Last argument P_NCHARS is now
9988 EMACS_INT.
9989 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9990 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9991
9992 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9993 All users changed.
9994
9995 * ccl.c (Fccl_execute_on_string): Declare some variables
9996 EMACS_INT.
9997
8546720e 99982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9999
10000 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10001
4e19a977
CS
100022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10003
10004 * process.c (Fformat_network_address): Doc fix.
10005
87302331
R
100062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10007
ee7683eb 10008 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10009
cbb59342
CY
100102011-04-08 Chong Yidong <cyd@stupidchicken.com>
10011
10012 * keyboard.c (read_char): Call Lisp function help-form-show,
10013 instead of using internal_with_output_to_temp_buffer.
10014 (Qhelp_form_show): New var.
e0d38eeb 10015 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10016
10017 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10018
10019 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10020
e67a13ab
CY
100212011-04-06 Chong Yidong <cyd@stupidchicken.com>
10022
04f2d78b
CB
10023 * process.c (Flist_processes): Remove to Lisp.
10024 (list_processes_1): Delete.
e67a13ab 10025
973f782d
EZ
100262011-04-06 Eli Zaretskii <eliz@gnu.org>
10027
7c106b1e
EZ
10028 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10029
973f782d
EZ
10030 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10031
41cf7d1a 100322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10033
ca23cc88
PE
10034 Fix more problems found by GCC 4.6.0's static checks.
10035
f390e2d5
PE
10036 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10037
42eea0d0
PE
10038 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10039
b69769da 10040 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10041
f9541e84
PE
10042 * xdisp.c (vmessage): Mark as a printf-like function.
10043
13841b55
PE
10044 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10045
c136c10f
PE
10046 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10047
5e2d4a30
PE
10048 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10049 printf-like functions.
10050 (tiff_load): Add casts to remove these marks before passing them
10051 to system-supplied API.
10052
583f48b9
PE
10053 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10054
b25d760e
PE
10055 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10056 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10057 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10058 directly, rather than having caller test rule sign. This avoids
10059 some unnecessary tests.
10060 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10061 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10062 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10063
bc7b6697 10064 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10065 (xfont_open): Avoid unnecessary tests.
bc7b6697 10066
27ccc379
PE
10067 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10068
dcd5c89a
PE
10069 * composite.h, composite.c (composition_gstring_put_cache):
10070 Use EMACS_INT, not int, for length.
10071
b13a45c6
PE
10072 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10073 breaking out part of COMPOSITION_DECODE_RULE.
10074 (COMPOSITION_DECODE_RULE): Use it.
10075 * composite.c (get_composition_id): Remove unused local vars,
10076 by using the new macro.
10077
1e792e4d
PE
10078 * textprop.c (set_text_properties_1): Change while to do-while,
10079 since the condition is always true at first.
10080
dc6c6455 10081 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10082 (interval_deletion_adjustment): Return unsigned value.
10083 All uses changed.
dc6c6455 10084
aba7731a
PE
10085 * process.c (list_processes_1, create_pty, read_process_output):
10086 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10087 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10088 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10089 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10090 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10091
fdfc4bf3
PE
10092 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10093
fca8fe46 10094 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10095 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10096
06a0259a 10097 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10098 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10099 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10100
e7b9e80f
PE
10101 * print.c (print_error_message): Avoid int overflow.
10102
56201685
PE
10103 * font.c (font_list_entities): Redo for clarity,
10104 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10105
78834453 10106 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10107 (font_score): Avoid potential overflow in diff calculation.
78834453 10108
0bc0b309 10109 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10110 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10111
e610eaca
PE
10112 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10113
b895abce
PE
10114 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10115 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10116 can always succeed if overflow has undefined behavior.
10117
1f1d9321 10118 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10119 (wordify): Omit three unnecessary tests.
1f1d9321 10120
c59478bc
PE
10121 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10122 All callers changed. This avoids the need for an unused var.
10123
79b73827
PE
10124 * casefiddle.c (casify_region): Remove var that is set but not used.
10125
a4db5dfe
PE
10126 * dired.c (file_name_completion): Remove var that is set but not used.
10127
43aae36e
PE
10128 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10129
2a47c44d 10130 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10131 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10132
a37c69bf
PE
10133 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10134 Check for integer overflow on size calculations.
10135
328ab8e7
PE
10136 * buffer.c (Fprevious_overlay_change): Remove var that is set
10137 but not used.
10138
e5a2a5cb
PE
10139 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10140 Remove vars that are set but not used.
8d84a6eb 10141 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10142 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10143
a60e5f68
PE
10144 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10145
f661cb61 10146 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10147 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10148
f0397f5a
PE
10149 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10150 that are set but not used.
10151
8664db06 10152 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10153 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10154
6abdaa4a
PE
10155 * xselect.c (x_get_local_selection, x_handle_property_notify):
10156 Remove vars that are set but not used.
10157
0ce7538d 10158 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10159 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10160
9ae848fc
PE
10161 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10162 Remove var that is set but not used.
0b918413
PE
10163 (scroll_bar_windows_size): Now size_t, not int.
10164 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10165 Check for overflow.
9ae848fc 10166
a5a62657
PE
10167 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10168 (map_tty_color) [!defined MSDOS]: Likewise.
10169
5c5cdd39
PE
10170 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10171
66ebf983
PE
10172 * coding.c: Remove vars that are set but not used.
10173 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10174 All callers changed.
10175 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10176 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10177 (decode_coding_charset): Remove vars that are set but not used.
10178
1be4d761
PE
10179 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10180 that is set but not used.
10181
47553fa8
PE
10182 * print.c (print_object): Remove var that is set but not used.
10183
1f7196bf 10184 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10185 The gnulib version avoids calling malloc in the usual case,
10186 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10187 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10188 * filelock.c (current_lock_owner): Likewise.
10189 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10190 * sysdep.c: Include allocator.h, careadlinkat.h.
10191 (emacs_no_realloc_allocator): New static constant.
10192 (emacs_readlink): New function.
fdb61804
PE
10193 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10194 ../lib/careadlinkat.h.
d1fdcab7 10195
f84c17c7
SM
101962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10197
10198 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10199 first non-nil return value).
10200
ef3862ad
JD
102012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10202
10203 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10204 if not defined (Bug#8403).
10205
376a7006
JB
102062011-04-02 Juanma Barranquero <lekktu@gmail.com>
10207
10208 * xdisp.c (display_count_lines): Remove parameter `start',
10209 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10210 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10211 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10212 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10213 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10214 and thereabouts. All callers changed.
10215 (get_per_char_metric): Remove parameter `f', unused since
10216 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10217
6ca3801d
JM
102182011-04-02 Jim Meyering <meyering@redhat.com>
10219
10220 do not dereference NULL upon failed strdup
10221 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10222 (ns_get_family): Likewise.
10223
d8e2b5ba
JB
102242011-04-02 Juanma Barranquero <lekktu@gmail.com>
10225
10226 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10227
8c74fcbd
JD
102282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10229
10230 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10231 later (Bug#8403).
10232
7200d79c
SM
102332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10234
03408648 10235 Add lexical binding.
7200d79c 10236
03408648
SM
10237 * window.c (Ftemp_output_buffer_show): New fun.
10238 (Fsave_window_excursion):
10239 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10240
10241 * lread.c (lisp_file_lexically_bound_p): New function.
10242 (Fload): Bind Qlexical_binding.
10243 (readevalloop): Remove `evalfun' arg.
10244 Bind Qinternal_interpreter_environment.
10245 (Feval_buffer): Bind Qlexical_binding.
10246 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10247 Mark as dynamic.
10248 (syms_of_lread): Declare `lexical-binding'.
10249
10250 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10251
10252 * keyboard.c (eval_dyn): New fun.
10253 (menu_item_eval_property): Use it.
ca105506
SM
10254
10255 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10256
03408648
SM
10257 * fns.c (concat, mapcar1): Accept byte-code-functions.
10258
10259 * eval.c (Fsetq): Handle lexical vars.
10260 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10261 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10262 (FletX, Flet): Obey lexical binding.
10263 (Fcommandp): Handle closures.
10264 (Feval): New `lexical' arg.
10265 (eval_sub): New function extracted from Feval. Use it almost
10266 everywhere where Feval was used. Look up vars in lexical env.
10267 Handle closures.
10268 (Ffunctionp): Move from subr.el.
10269 (Ffuncall): Handle closures.
10270 (apply_lambda): Remove `eval_flags'.
10271 (funcall_lambda): Handle closures and new byte-code-functions.
10272 (Fspecial_variable_p): New function.
10273 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10274 but without exporting it to Lisp.
23aba0ea 10275
23aba0ea 10276 * doc.c (Fdocumentation, store_function_docstring):
03408648 10277 * data.c (Finteractive_form): Handle closures.
23aba0ea 10278
03408648
SM
10279 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10280 interactive spec.
ba83908c 10281
04f2d78b
CB
10282 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10283 New byte-codes.
03408648
SM
10284 (exec_byte_code): New function extracted from Fbyte_code to handle new
10285 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10286
03408648 10287 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10288
03408648 10289 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10290
e2abce01
JB
102912011-03-31 Juanma Barranquero <lekktu@gmail.com>
10292
10293 * xdisp.c (redisplay_internal): Fix prototype.
10294
63696a73 102952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10296
63696a73 10297 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10298 (try_scrolling): Use it when setting scroll_limit.
10299 Limit scrolling to 100 screen lines.
63696a73
EZ
10300 (redisplay_window): Even when falling back on "recentering",
10301 position point in the window according to scroll-conservatively,
10302 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10303
10304 (try_scrolling): When point is above the window, allow searching
10305 as far as scroll_max, or one screenful, to compute vertical
10306 distance from PT to the scroll margin position. This prevents
10307 try_scrolling from unnecessarily failing when
10308 scroll-conservatively is set to a value slightly larger than the
10309 window height. Clean up the case of PT below the margin at bottom
10310 of window: scroll_max can no longer be INT_MAX. When aggressive
10311 scrolling is in use, don't let point enter the opposite scroll
10312 margin as result of the scroll.
10313 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10314 threshold of 100 lines for never-recentering scrolling.
10315
e4cc2dfc
JB
103162011-03-31 Juanma Barranquero <lekktu@gmail.com>
10317
10318 * dispextern.h (move_it_by_lines):
10319 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10320 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10321 (message_log_check_duplicate): Remove parameters `prev_bol' and
10322 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10323 (redisplay_internal): Remove parameter `preserve_echo_area',
10324 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10325
10326 * indent.c (Fvertical_motion):
10327 * window.c (window_scroll_pixel_based, Frecenter):
10328 Don't pass `need_y_p' to `move_it_by_lines'.
10329
1c470562
SM
103302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10331
44f230aa
SM
10332 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10333 steal a few bits to be more compact.
10334 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10335 Remove unneeded casts.
10336
1c470562
SM
10337 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10338
888adce9
ZK
103392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10340
10341 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10342 binding" message (bug#7967).
10343
f838ed7b
PE
103442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10345
77861b95
PE
10346 Fix more problems found by GCC 4.6.0's static checks.
10347
de6dbc14
PE
10348 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10349 Remove unused local var.
10350
f838ed7b
PE
10351 * editfns.c (Fmessage_box): Remove unused local var.
10352
792c7b2b
PE
10353 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10354 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10355 Omit unused local vars.
c499e557 10356 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10357 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10358 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10359 Omit unused local var.
10360
ba0165e1
PE
10361 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10362 Don't assume string length fits in int.
32ad8845 10363 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10364 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10365
3c59b4c9
PE
10366 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10367 instead of alloca (Bug#8344).
10368
a3eed478 10369 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10370 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10371
eb4d412d
PE
10372 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10373
1658b401
PE
10374 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10375 concerns.
10376
10377 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10378
10379 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10380
9a2c6e05
PE
10381 * keyboard.c (syms_of_keyboard): Use the same style as later
10382 in this function when indexing through an array. This also
10383 works around GCC bug 48267.
10384
03d0a109
PE
10385 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10386
44f730c8
PE
10387 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10388
fe75f926
PE
10389 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10390 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10391
ffa8c828
PE
10392 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10393 This avoids undefined behavior on integer overflow, and is a bit
10394 more convenient anyway since it is compared to a size_t variable.
10395
c5101a77
PE
10396 Variadic C functions now count arguments with size_t, not int.
10397 This avoids an unnecessary limitation on 64-bit machines, which
10398 caused (substring ...) to crash on large vectors (Bug#8344).
10399 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10400 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10401 All variadic functions and their callers changed accordingly.
c5101a77
PE
10402 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10403 * data.c (arith_driver, float_arith_driver): Likewise.
10404 * editfns.c (general_insert_function): Likewise.
10405 * eval.c (struct backtrace.nargs, interactive_p)
10406 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10407 (funcall_lambda, mark_backtrace): Likewise.
10408 * fns.c (concat): Likewise.
10409 * frame.c (x_set_frame_parameters): Likewise.
10410 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10411 0 if not found, not -1. All callers changed.
10412
dd3f25f7
PE
10413 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10414 (stack_copy_size): Now size_t, not int.
10415 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10416
461c2ab9
JB
104172011-03-28 Juanma Barranquero <lekktu@gmail.com>
10418
10419 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10420 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10421 All callers changed.
10422
10423 * lisp.h (multibyte_char_to_unibyte):
10424 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10425 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10426 * character.h (CHAR_TO_BYTE8):
10427 * cmds.c (internal_self_insert):
10428 * editfns.c (general_insert_function):
10429 * keymap.c (push_key_description):
10430 * search.c (Freplace_match):
10431 * xdisp.c (message_dolog, set_message_1): All callers changed.
10432
f6d62986
SM
104332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10434
10435 * keyboard.c (safe_run_hook_funcall): New function.
10436 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10437 don't set the hook to nil, but remove the offending function instead.
10438 (Qcommand_hook_internal): Remove, unused.
10439 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10440 Vcommand_hook_internal.
10441
10442 * eval.c (enum run_hooks_condition): Remove.
10443 (funcall_nil, funcall_not): New functions.
10444 (run_hook_with_args): Call each function through a `funcall' argument.
10445 Remove `cond' argument, now redundant.
10446 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10447 (Frun_hook_with_args_until_failure): Adjust accordingly.
10448 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10449
1db5b1ad
JB
104502011-03-28 Juanma Barranquero <lekktu@gmail.com>
10451
10452 * dispextern.h (string_buffer_position): Remove declaration.
10453
10454 * print.c (strout): Remove parameter `multibyte', unused since
10455 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10456
10457 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10458 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10459 All callers changed.
10460
10461 * w32.c (_wsa_errlist): Use braces for struct initializers.
10462
10463 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10464 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10465 All callers changed.
10466 (string_buffer_position): Likewise. Also, make static (it's never
10467 used outside xdisp.c).
10468 (cursor_row_p): Remove parameter `w', unused since
10469 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10470 (decode_mode_spec): Remove parameter `precision', introduced during
10471 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10472 All callers changed.
10473
5ffb62aa
JD
104742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10475
10476 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10477
461c2ab9 104782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10479
10480 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10481 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10482 (ns_update_auto_hide_menu_bar): New functions.
10483 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10484 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10485 ns_constrain_all_frames.
10486 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10487 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10488
5c380ffb
JD
104892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10490
10491 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10492
9af30bdf
GM
104932011-03-27 Glenn Morris <rgm@gnu.org>
10494
10495 * syssignal.h: Replace RETSIGTYPE with void.
10496 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10497 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10498 Replace SIGTYPE with void everywhere.
10499 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10500 * s/template.h (SIGTYPE): Remove commented out definition.
10501
e2abce01
JB
105022011-03-26 Eli Zaretskii <eliz@gnu.org>
10503
10504 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10505 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10506
f868cd8a
JB
105072011-03-26 Juanma Barranquero <lekktu@gmail.com>
10508
59eb0929
JB
10509 * w32.c (read_unc_volume): Use parameter `henum', instead of
10510 global variable `wget_enum_handle'.
10511
10512 * keymap.c (describe_vector): Remove parameters `indices' and
10513 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10514 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10515
f868cd8a
JB
10516 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10517
10518 * keyboard.c (timer_check): Remove parameter `do_it_now',
10519 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10520 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10521 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10522
10523 * keyboard.c (read_char):
10524 * w32menu.c (w32_menu_display_help):
10525 * xmenu.c (show_help_event, menu_help_callback):
10526 Adjust calls to `show_help_echo'.
10527
10528 * gtkutil.c (xg_maybe_add_timer):
10529 * keyboard.c (readable_events):
10530 * process.c (wait_reading_process_output):
10531 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10532
10533 * insdel.c (adjust_markers_gap_motion):
10534 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10535 (gap_left, gap_right): Don't call it.
10536
2ecf6fdb
CY
105372011-03-25 Chong Yidong <cyd@stupidchicken.com>
10538
10539 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10540 incurred during fontification.
10541
6b1f9ba4
JB
105422011-03-25 Juanma Barranquero <lekktu@gmail.com>
10543
10544 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10545 (DEFVAR_PER_BUFFER): Don't pass it.
10546
10547 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10548 (scrolling_window): Don't pass it.
10549
0f4a96b5
JB
105502011-03-25 Juanma Barranquero <lekktu@gmail.com>
10551
10552 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10553
10554 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10555 and `suffix'.
10556 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10557 of variables specific to SELinux and computation of `encoded_absname'.
10558
10559 * image.c (XPutPixel): Remove unused variable `height'.
10560
10561 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10562
10563 * unexw32.c (get_section_info): Remove unused variable `section'.
10564
10565 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10566 (system_process_attributes): Remove unused variable `sess'.
10567 (sys_read): Remove unused variable `err'.
10568
10569 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10570 (w32_wnd_proc): Remove unused variable `isdead'.
10571 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10572 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10573 (x_create_tip_frame): Remove unused variable `tem'.
10574
10575 * w32inevt.c (w32_console_read_socket):
10576 Remove unused variable `no_events'.
10577
10578 * w32term.c (x_draw_composite_glyph_string_foreground):
10579 Remove unused variable `width'.
10580
1149507c
JB
105812011-03-24 Juanma Barranquero <lekktu@gmail.com>
10582
10583 * w32term.c (x_set_glyph_string_clipping):
10584 Don't pass uninitialized region to CombineRgn.
10585
9c88f339
JB
105862011-03-23 Juanma Barranquero <lekktu@gmail.com>
10587
10588 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10589 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10590 (Fx_close_connection): Remove unused variable `i'.
10591
10592 * w32font.c (w32font_draw): Return number of glyphs.
10593 (w32font_open_internal): Remove unused variable `i'.
10594 (w32font_driver): Add missing initializer.
10595
10596 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10597 (fill_in_menu): Remove unused variable `items_added'.
10598
10599 * w32term.c (last_mouse_press_frame): Remove static global variable.
10600 (w32_clip_to_row): Remove unused variable `f'.
10601 (x_delete_terminal): Remove unused variable `i'.
10602
10603 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10604 (NOTHING): Remove unused static global variable.
10605 (uniscribe_check_otf): Remove unused variable `table'.
10606 (uniscribe_font_driver): Add missing initializers.
10607
dee091a3
JD
106082011-03-23 Julien Danjou <julien@danjou.info>
10609
10610 * term.c (Fsuspend_tty, Fresume_tty):
10611 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10612 * window.c (temp_output_buffer_show):
10613 * insdel.c (signal_before_change):
10614 * frame.c (Fhandle_switch_frame):
10615 * fileio.c (Fdo_auto_save):
10616 * emacs.c (Fkill_emacs):
10617 * editfns.c (save_excursion_restore):
10618 * cmds.c (internal_self_insert):
10619 * callint.c (Fcall_interactively):
10620 * buffer.c (Fkill_all_local_variables):
10621 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10622 Use Frun_hooks.
0f4a96b5 10623 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10624 unconditionally since it does the check itself.
dee091a3 10625
2c520ab5 106262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10627
c9c49752
PE
10628 Fix more problems found by GCC 4.5.2's static checks.
10629
8abc3f12
PE
10630 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10631 the first time through the loop, since we know p0 < p1 then.
10632 This also avoids a gcc -Wstrict-overflow warning.
10633
a2d26660
PE
10634 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10635 leading to a memory leak, possible in functions like
10636 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10637 of objects (Bug#8318).
a2d26660 10638
916c72e9
PE
10639 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10640 that could (at least in theory) be that large.
10641
19ab8a18
PE
10642 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10643 This is less likely to overflow, and avoids undefined behavior if
10644 overflow does occur. All callers changed. Use strtoul to scan
10645 for the unsigned long integer.
b7cbbd6f
PE
10646 (pint2hrstr): Simplify and tune code slightly.
10647 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10648
f0641eff
PE
10649 * scroll.c (do_scrolling): Work around GCC bug 48228.
10650 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10651
7f650bb9
PE
10652 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10653 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10654 (validate_x_resource_name): Simplify count usage.
10655 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10656
37dd57d1
PE
10657 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10658 fail (Bug#8306).
81e56e61 10659
699979fc 10660 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10661
401bf9b4
PE
10662 * process.c (Fmake_network_process): Use socklen_t, not int,
10663 where POSIX says socklen_t is required in portable programs.
10664 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10665 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10666 (Fmake_network_process, server_accept_connection):
10667 (wait_reading_process_output, read_process_output):
10668 Likewise.
10669
b93aacde
PE
10670 * process.c: Rename or move locals to avoid shadowing.
10671 (list_processes_1, Fmake_network_process):
10672 (read_process_output_error_handler, exec_sentinel_error_handler):
10673 Rename or move locals.
4dc343ee 10674 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10675 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10676 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10677 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10678 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10679
af8a867c 10680 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10681 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10682 Include tparam.h instead, since it declares them.
af8a867c
PE
10683 * cm.h (PC): Remove extern decl; tparam.h now does this.
10684 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10685 * terminfo.c: Include tparam.h, to check interfaces.
10686 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10687 (tparam): Adjust signature to match interface in tparam.h;
10688 this removes some undefined behavior. Check that outstring and len
10689 are zero, which they always are with Emacs.
10690 * tparam.h (PC, BC, UP): New extern decls.
10691
0248044d 10692 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10693 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10694
8ff096c1 10695 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10696 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10697 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10698 (ftfont_list): Remove unused local.
49eaafba
PE
10699 (get_adstyle_property, ftfont_pattern_entity):
10700 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10701 Rename locals to avoid shadowing.
8ff096c1 10702
e2be39f6
PE
10703 * xfont.c (xfont_list_family): Mark var as initialized.
10704
c9735e30
PE
10705 * xml.c (make_dom): Now static.
10706
8f5201ae
PE
10707 * composite.c (composition_compute_stop_pos): Rename local to
10708 avoid shadowing.
b246f932
PE
10709 (composition_reseat_it): Remove unused locals.
10710 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10711 (composition_update_it): Mark var as initialized.
11b61122
PE
10712 (find_automatic_composition): Mark vars as initialized,
10713 with a FIXME (Bug#8290).
8f5201ae 10714
760fbc2c
PE
10715 character.h: Rename locals to avoid shadowing.
10716 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10717 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10718 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10719 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10720 to avoid shadowing.
10721
ff08eb85
PE
10722 * textprop.c (property_change_between_p): Remove; unused.
10723
fc7bf025
PE
10724 * intervals.c (interval_start_pos): Now static.
10725
235d7abc
PE
10726 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10727
44f230aa
SM
10728 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10729 Rename locals to avoid shadowing.
3e7d6594 10730
50060332
PE
10731 * sound.c (wav_play, au_play, Fplay_sound_internal):
10732 Fix pointer signedness.
d01f234b 10733 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10734 (wav_play): Initialize a variable to 0, to prevent undefined
10735 behavior (Bug#8278).
50060332 10736
c4fc4e30
PE
10737 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10738
918436ed
PE
10739 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10740
c939f91b
PE
10741 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10742 clobbering (Bug#8298).
b9c7f648
PE
10743 * sysdep.c (sys_subshell): Likewise.
10744 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10745
6bd8c144
PE
10746 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10747 This should get cleaned up, so that child_setup has the
10748 same signature on all platforms.
10749
7710357c 10750 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10751 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10752
c59da222
CY
107532011-03-22 Chong Yidong <cyd@stupidchicken.com>
10754
10755 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10756 not to be necessary, and produces flickering.
10757
66b87493
GM
107582011-03-20 Glenn Morris <rgm@gnu.org>
10759
10760 * config.in: Remove file.
10761
45b6f6d5
JB
107622011-03-20 Juanma Barranquero <lekktu@gmail.com>
10763
10764 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10765 are now in src/globals.h.
10766 (syms_of_minibuf): Remove spurious & from previous change.
10767
cd394be1 107682011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10769
10770 * minibuf.c (completing-read-function): New variable.
10771 (completing-read-default): Rename from completing-read.
10772 (completing-read): Call completing-read-function.
10773
b14e3e21
CY
107742011-03-19 Juanma Barranquero <lekktu@gmail.com>
10775
10776 * xfaces.c (Fx_load_color_file):
10777 Read color file from absolute filename (bug#8250).
10778
f2b726e6
JB
107792011-03-19 Juanma Barranquero <lekktu@gmail.com>
10780
10781 * makefile.w32-in: Update dependencies.
10782
09f6ff02
EZ
107832011-03-17 Eli Zaretskii <eliz@gnu.org>
10784
10785 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10786
29a6015a
PE
107872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10788
a3a6c54e
PE
10789 Fix more problems found by GCC 4.5.2's static checks.
10790
b766f867
PE
10791 * process.c (make_serial_process_unwind, send_process_trap):
10792 (sigchld_handler): Now static.
10793
be02381c
PE
10794 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10795 That way, the code declares only the vars that it needs.
10796 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10797 * s/cygwin.h (PTY_ITERATION): Likewise.
10798 * s/darwin.h (PTY_ITERATION): Likewise.
10799 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10800
57048744
PE
10801 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10802 * process.c (allocate_pty): Don't declare stb unless it's needed.
10803
7914961c 10804 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10805 (CONSTANTLIM): Remove; unused.
10806 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10807 Define only if needed.
7914961c 10808
b3967b18
PE
10809 * unexelf.c (unexec): Name an expression,
10810 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10811 Use a different way to cause a compilation error if anyone uses
10812 n rather than nn, a way that does not involve shadowing.
73366a00 10813 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10814
29a6015a
PE
10815 * deps.mk (unexalpha.o): Remove; unused.
10816
43cfc33e 10817 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10818 * unexec.h: New file.
ce701a33
PE
10819 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10820 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10821 Depend on unexec.h.
10822 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10823 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10824 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10825 Change as necessary to match prototype in unexec.h.
ce701a33 10826
01f44d5a
PE
10827 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10828 shadowing.
4f63c6bb 10829 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10830
a6670b0b
PE
10831 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10832 Rename locals to avoid shadowing.
10833
cef2010d 10834 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10835 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10836
d4d7173a
PE
10837 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10838
f08b802a
PE
10839 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10840 warning when compiling print.c.
10841
3ddb0639
PE
10842 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10843 instead of using an uninitialized var.
5ad03b97 10844 (font_sort_entities): Mark var as initialized.
3ddb0639 10845
170a2692
PE
10846 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10847
e663c700
PE
10848 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10849 pointers to constants.
89bc529a 10850 (font_parse_fcname): Remove unused vars.
7b81e2d0 10851 (font_delete_unmatched): Now static.
ea838e10 10852 (font_get_spec): Remove; unused.
13a547c6
PE
10853 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10854 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10855 Rename or move locals to avoid shadowing.
e663c700 10856
2a80c887 10857 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10858 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10859
1384fa33 10860 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10861 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10862
8b2c52e9
PE
10863 * alloc.c (mark_backtrace): Move decl from here ...
10864 * lisp.h: ... to here, so that it can be checked.
10865
475545b5 10866 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10867 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10868 (lisp_indirect_variable): Name an expression,
10869 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10870 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10871
b1349114 10872 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10873 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10874 Use const pointer when appropriate.
b1349114 10875
a2928364
PE
10876 * lisp.h (get_system_name, get_operating_system_release):
10877 Move decls here, to check interfaces.
10878 * process.c (get_operating_system_release): Move decl to lisp.h.
10879 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10880 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10881 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10882 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10883 (Fformat_time_string, Fencode_time, Finsert_char):
10884 (Ftranslate_region_internal, Fformat):
10885 Rename or remove local vars to avoid shadowing.
9710023e 10886 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10887
a415e694
PE
10888 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10889 avoid shadowing.
10890
8ef4622d
PE
10891 * lisp.h (eassert): Check that the argument compiles, even if
10892 ENABLE_CHECKING is not defined.
10893
946f9a5b
PE
10894 * data.c (Findirect_variable): Name an expression, to avoid
10895 gcc -Wbad-function-cast warning.
112396d6 10896 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10897 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10898 (Fmake_variable_buffer_local, Fmake_local_variable):
10899 Mark variables as initialized.
52746918 10900 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10901
e5aab7e7 10902 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10903 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10904 Rename locals to avoid shadowing.
dff45157
PE
10905 (mark_stack): Move local variables into the #ifdef region where
10906 they're used.
7bc26fdb
PE
10907 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10908 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10909 needed otherwise.
10910 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10911 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10912 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10913
e5aab7e7
PE
10914 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10915 avoids undefined behavior in theory.
10916
4da60324
PE
10917 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10918
88043301
PE
10919 Use functions, not macros, for up- and down-casing (Bug#8254).
10920 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10921 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10922 to use the following functions instead of these macros.
10923 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10924 EMACS_INT, since callers assume the returned value fits in int.
10925 (upcase1): Likewise, for UPCASE_TABLE.
10926 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10927 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10928 the race-condition problem in the old DOWNCASE.
88043301 10929
19ed5445
PE
10930 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10931 Rename locals to avoid shadowing.
10932 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10933 (regex_compile, re_search_2, re_match_2_internal):
10934 Remove unused local vars.
952db0d7
PE
10935 (FREE_VAR): Rewrite so as not to use empty "else",
10936 which gcc can warn about.
da053e48 10937 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10938 (RETALLOC_IF): Define only if needed.
10939 (WORDCHAR_P): Likewise. This one is never needed, but is used
10940 only in a comment talking about a compiler bug, so put inside
10941 the #if 0 of that comment.
10942 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10943 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10944 Remove; unused.
19ed5445 10945
1f3561e4 10946 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10947 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10948 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10949
ded6f8f7
PE
10950 * search.c (simple_search): Remove unused var.
10951
dbd37a95
PE
10952 * dired.c (compile_pattern): Move decl from here ...
10953 * lisp.h: ... to here, so that it can be checked.
10954 (struct re_registers): New forward decl.
10955
7e47afad
PE
10956 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10957
85f24f61
PE
10958 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10959 All uses changed.
10960 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10961 Rename locals to avoid shadowing.
5671df8f 10962 (Fvertical_motion): Mark locals as initialized.
85f24f61 10963
181aa2be 10964 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10965 (casify_region): Mark local as initialized.
181aa2be 10966
930d429c
PE
10967 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10968
7082eac6
PE
10969 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10970 New macros, so that the caller can use some names other than
10971 gcpro1, gcpro2, etc.
10972 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10973 of the new macros.
10974 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10975 argument, for consistency with GCPRO2_VAR, etc: it is now the
10976 prefix of the variable, not the variable itself. All uses
10977 changed.
38b2c076
PE
10978 * dired.c (directory_files_internal, file_name_completion):
10979 Rename locals to avoid shadowing.
10980
15206ed9
PE
10981 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10982 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10983 dired.c's scmp function, had undefined behavior.
10984 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10985 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10986 * buffer.h: ... to here, because these macros use current_buffer,
10987 and the new implementation with inline functions needs to have
10988 current_buffer in scope now, rather than later when the macros
10989 are used.
10990 (downcase, upcase1): New static inline functions.
10991 (DOWNCASE, UPCASE1): Reimplement using these functions.
10992 This avoids undefined behavior in expressions like
10993 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10994 from race conditions in accessing the global variables
10995 case_temp1 and case_temp2.
10996 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10997 * lisp.h (case_temp1, case_temp2): Remove their decls.
10998 * character.h (ASCII_CHAR_P): Move from here ...
10999 * lisp.h: ... to here, so that the inline functions mentioned
11000 above can use them.
11001
4a6bea26
PE
11002 * dired.c (directory_files_internal_unwind): Now static.
11003
f14b7e14
PE
11004 * fileio.c (file_name_as_directory, directory_file_name):
11005 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11006 Now static.
2893f146
PE
11007 (file_name_as_directory): Use const pointers when appropriate.
11008 (Fexpand_file_name): Likewise. In particular, newdir might
11009 point at constant storage, so make it a const pointer.
fd4ead52 11010 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11011 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11012 signedness issues.
f839df0c
PE
11013 (Fset_file_times, Finsert_file_contents, auto_save_error):
11014 Rename locals to avoid shadowing.
f14b7e14 11015
5716756e 11016 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11017 (Ftry_completion, Fall_completions): Rename or remove locals
11018 to avoid shadowing.
5716756e 11019
b4c3046a
PE
11020 * marker.c (bytepos_to_charpos): Remove; unused.
11021
b45db522
PE
11022 * lisp.h (verify_bytepos, count_markers): New decls,
11023 so that gcc does not warn that these functions aren't declared.
11024
85876d07
PE
11025 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11026 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11027 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11028 (copy_text): Remove unused local var.
85876d07 11029
03d78a21 11030 * filelock.c (within_one_second): Now static.
b3dd38ab 11031 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11032
5df8f01b
PE
11033 * buffer.c (fix_overlays_before): Mark locals as initialized.
11034 (fix_start_end_in_overlays): Likewise. This function should be
11035 simplified by using pointers-to-pointers, but that's a different
11036 matter.
b1d876f1 11037 (switch_to_buffer_1): Now static.
8f54f30a
PE
11038 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11039 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11040
a70072c9 11041 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11042 Fix pointer signedness issue.
edced198
PE
11043 (sys_subshell): Mark local as volatile if checking for lint,
11044 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11045 (MAXPATHLEN): Define only if needed.
a70072c9 11046
a0977c44
PE
11047 * process.c (serial_open, serial_configure): Move decls from here ...
11048 * systty.h: ... to here, so that they can be checked.
11049
a884fdcc
PE
11050 * fns.c (get_random, seed_random): Move extern decls from here ...
11051 * lisp.h: ... to here, so that they can be checked.
11052
604efe86 11053 * sysdep.c (reset_io): Now static.
b8950c94 11054 (wait_for_termination_signal): Remove; unused.
604efe86 11055
38fc62d9
PE
11056 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11057 (copy_keymap_item, append_key, push_text_char_description):
11058 Now static.
1004a21a 11059 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11060 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11061 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11062 (describe_map_tree):
11063 Rename locals to avoid shadowing.
38fc62d9 11064
2f2650da
PE
11065 * keyboard.c: Declare functions static if they are not used elsewhere.
11066 (echo_char, echo_dash, cmd_error, top_level_2):
11067 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11068 (read_char, kbd_buffer_get_event, make_lispy_position):
11069 (make_lispy_event, make_lispy_movement, apply_modifiers):
11070 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11071 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11072 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11073 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11074 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11075
a053e86c 11076 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11077 (mark_kboards): Move decl here ...
11078 * alloc.c (mark_kboards): ... from here.
a053e86c 11079
4752793e
PE
11080 * lisp.h (force_auto_save_soon): New decl.
11081
74f10ca7 11082 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11083 (DEFINE_DUMMY_FUNCTION): New macro.
11084 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11085 Use it.
c03cd23f
PE
11086 (main): Add casts to avoid warnings
11087 if GCC considers string literals to be constants.
74f10ca7 11088
022e70d4
PE
11089 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11090
59d6fe83
PE
11091 * dbusbind.c: Pointer signedness fixes.
11092 (xd_signature, xd_append_arg, xd_initialize):
11093 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11094 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11095 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11096 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11097
78320123
PE
11098 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11099 if GCC considers string literals to be constants.
49cebcca 11100 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11101
35ac2a97
SM
111022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11103
fb103ca9
SM
11104 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11105 (print_preprocess, print_object): New macro to fix last change.
11106
35ac2a97
SM
11107 * print.c (print_preprocess): Don't forget font objects.
11108
62973b41
JB
111092011-03-16 Juanma Barranquero <lekktu@gmail.com>
11110
11111 * emacs.c (USAGE3): Doc fixes.
11112
0e48bb22
AS
111132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11114
11115 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11116 structure.
11117
7684e57b
JB
111182011-03-14 Juanma Barranquero <lekktu@gmail.com>
11119
11120 * lisp.h (VWindow_system, Qfile_name_history):
11121 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11122 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11123 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11124
11125 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11126 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11127
11128 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11129 * w32console.c (detect_input_pending, read_input_pending)
11130 (encode_terminal_code):
11131 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11132 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11133 (w32_system_caret_y, Qfile_name_history):
11134 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11135 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11136 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11137 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11138 * w32proc.c (Qlocal, report_file_error):
11139 * w32term.c (Vwindow_system, updating_frame):
11140 * w32uniscribe.c (initialized, uniscribe_font_driver):
11141 Remove unneeded extern declarations.
11142
2aa46d6c
CY
111432011-03-14 Chong Yidong <cyd@stupidchicken.com>
11144
c96bbc66 11145 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11146
cffc6f3b
CY
111472011-03-13 Chong Yidong <cyd@stupidchicken.com>
11148
11149 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11150 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11151 These macros can no longer be used for assignment.
11152
44f230aa
SM
11153 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11154 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11155 (record_buffer_markers, fetch_buffer_markers): New functions for
11156 recording and fetching special buffer markers.
11157 (set_buffer_internal_1, set_buffer_temp): Use them.
11158
11159 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11160
11161 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11162
11163 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11164 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11165
11166 * xdisp.c (hscroll_window_tree):
11167 (reconsider_clip_changes): Use PT instead of BUF_PT.
11168
d251f04b
EZ
111692011-03-13 Eli Zaretskii <eliz@gnu.org>
11170
11171 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11172 $(EMACS_ROOT)/lib/intprops.h.
11173
f0c77cd1
PE
111742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11175
3eca4629
PE
11176 Fix more problems found by GCC 4.5.2's static checks.
11177
7c86ee98
PE
11178 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11179 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11180 (xg_free_frame_widgets): Make it clear that a local variable is
11181 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11182 (gdk_window_get_screen): Make it clear that this macro is needed
11183 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11184 (int_gtk_range_get_value): New function, which avoids a diagnostic
11185 from gcc -Wbad-function-cast.
11186 (xg_set_toolkit_scroll_bar_thumb): Use it.
11187 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11188 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11189 (get_utf8_string, xg_get_file_with_chooser):
11190 Rename locals to avoid shadowing.
11191 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11192
41729b81
PE
11193 * xgselect.c (xg_select): Remove unused var.
11194
f0c77cd1
PE
11195 * image.c (four_corners_best): Mark locals as initialized.
11196 (gif_load): Initialize transparent_p to zero (Bug#8238).
11197 Mark another local as initialized.
ec6cf4c6 11198 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11199
ce0ad53d 11200 * image.c (clear_image_cache): Now static.
d5d5a617 11201 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11202 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11203 (x_edge_detection): Remove unnecessary cast that
11204 gcc -Wbad-function-cast diagnoses.
2037898d 11205 (gif_load): Fix pointer signedness.
6ae141d6
PE
11206 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11207 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11208
33383987 112092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11210
d32df629
PE
11211 Improve quality of tests for time stamp overflow.
11212 For example, without this patch (encode-time 0 0 0 1 1
11213 1152921504606846976) returns the obviously-bogus value (-948597
11214 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11215 reports time overflow. See
11216 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11217 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11218 * editfns.c: Include limits.h and intprops.h.
11219 (TIME_T_MIN, TIME_T_MAX): New macros.
11220 (time_overflow): Move earlier, to before first use.
11221 (hi_time, lo_time): New functions, for an accurate test for
11222 out-of-range times.
11223 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11224 (Fget_internal_run_time): Don't assume time_t fits in int.
11225 (make_time): Use list2 instead of Fcons twice.
11226 (Fdecode_time): More accurate test for out-of-range times.
11227 (check_tm_member): New function.
11228 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11229 (lisp_time_argument): Don't rely on undefined left-shift and
11230 right-shift behavior when checking for time stamp overflow.
8be6f318 11231
fe31d94c
PE
11232 * editfns.c (time_overflow): New function, refactoring common code.
11233 (Fformat_time_string, Fdecode_time, Fencode_time):
11234 (Fcurrent_time_string): Use it.
11235
8be6f318
PE
11236 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11237 * dired.c (make_time): Move to ...
11238 * editfns.c (make_time): ... here.
11239 * systime.h: Note the move.
11240
09d9db2c 112412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11242
126bc0dc
YM
11243 * fringe.c (update_window_fringes): Remove unused variables.
11244
c47cbdfd
YM
11245 * unexmacosx.c (copy_data_segment): Also copy __got section.
11246 (Bug#8223)
11247
7ac80be9
EZ
112482011-03-12 Eli Zaretskii <eliz@gnu.org>
11249
c96bbc66 11250 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11251 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11252 Constify `char *' arguments and their references according to
11253 prototypes in tparam.h.
11254
ecb0f94d 11255 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11256
7ac80be9
EZ
11257 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11258 Adapt all references accordingly.
11259
11260 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11261
ef1fd07e
TT
112622011-03-11 Tom Tromey <tromey@redhat.com>
11263
11264 * buffer.c (syms_of_buffer): Remove obsolete comment.
11265
7ef4b50c
EZ
112662011-03-11 Eli Zaretskii <eliz@gnu.org>
11267
11268 * termhooks.h (encode_terminal_code): Declare prototype.
11269
11270 * msdos.c (encode_terminal_code): Don't declare prototype.
11271
11272 * term.c (encode_terminal_code): Now external again, used by
11273 w32console.c and msdos.c.
11274
44f230aa
SM
11275 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11276 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11277
4b1ec863 112782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11279
1714f52b 11280 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11281
4b1ec863
PE
11282 * fringe.c (update_window_fringes): Mark locals as initialized
11283 (Bug#8227).
11284 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11285
524c7aa6
PE
11286 * alloc.c (mark_fringe_data): Move decl from here ...
11287 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11288 to check its interface.
11289 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11290
a5c0af81 11291 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11292 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11293 (fontset_font): Mark local as initialized.
a9a06e0b 11294 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11295
b4716021
PE
11296 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11297
811e9bac 11298 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11299 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11300 (x_own_selection, Fx_disown_selection_internal): Rename locals
11301 to avoid shadowing.
11302 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11303
7e3ab302
PE
11304 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11305 so that the caller can use some name other than gcpro1.
11306 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11307 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11308 (Fx_backspace_delete_keys_p):
11309 Use them to avoid shadowing, and rename vars to avoid shadowing.
11310 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11311 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11312 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11313 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11314 Remove unused locals.
7e3ab302
PE
11315 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11316 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11317 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11318 macros.
f78faa98 11319
e2b13473
PE
11320 * xterm.h (x_mouse_leave): New decl.
11321
77f23912
PE
11322 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11323 Remove unused functions.
cdf4ba58
PE
11324 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11325 (x_calc_absolute_position): Now static.
7411c686 11326 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11327 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11328 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11329 unless they are used.
38d0b34a
PE
11330 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11331 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11332 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11333 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11334 (x_error_catcher, x_connection_closed, x_error_handler):
11335 (x_error_quitter, xembed_send_message, x_iconify_frame):
11336 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11337 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11338 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11339
44f230aa
SM
11340 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11341 Rename or move locals to avoid shadowing.
6b463e58 11342 (tty_defined_color, merge_face_heights): Now static.
5967d051 11343 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11344 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11345 does not deduce is never used uninitialized.
73719eba
PE
11346 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11347 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11348
426994c3 11349 * terminal.c (store_terminal_param): Now static.
5489860b 11350
032f1620 11351 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11352 (set_frame_menubar): Remove unused local.
d4323972 11353 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11354 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11355 since they might point to immutable storage.
281585b0
PE
11356 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11357 since it's unused otherwise.
032f1620 11358
367c19e5 11359 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11360 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11361 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11362 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11363 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11364 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11365 does not deduce are never used uninitialized.
70739cbe 11366
07b48fa9
PE
11367 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11368
8868a238 11369 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11370 * window.c (window_loop, size_window):
11371 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11372
7e5cf297 11373 * window.c (display_buffer): Now static.
d6550a9f
PE
11374 (size_window): Mark variables that gcc -Wuninitialized
11375 does not deduce are never used uninitialized.
a586633d
PE
11376 * window.h (check_all_windows): New decl, to forestall
11377 gcc -Wmissing-prototypes diagnostic.
5b555da1 11378 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11379
f6095868
PE
11380 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11381 shadowing.
11382 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11383 Include <limits.h>.
11384 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11385 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11386 (load_charset_map): Mark variables that gcc -Wuninitialized
11387 does not deduce are never used uninitialized.
53df7c11 11388 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11389
f38b440c
PE
11390 * coding.c (coding_set_source, coding_set_destination):
11391 Use "else { /* comment */ }" rather than "else /* comment */;"
11392 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11393 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11394 a block, when the outer 'i' will do.
11395 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11396 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11397 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11398 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11399 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11400 Rename locals to avoid shadowing.
11401 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11402 * coding.c (emacs_mule_char, encode_invocation_designation):
11403 Now static, since they're not used elsewhere.
413bb2db 11404 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11405 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11406 (decode_coding_emacs_mule): Mark variables that gcc
11407 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11408 (detect_coding_iso_2022): Initialize a local variable that might
11409 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11410 this initialization is needed. (Bug#8211)
5f58e762
PE
11411 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11412 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11413 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11414 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11415 Remove unused macros.
f38b440c 11416
232b38b9 11417 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11418 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11419 * character.c (string_count_byte8): Likewise.
232b38b9 11420
fb90da1b
PE
11421 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11422 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11423
fb93dbc2
PE
11424 * chartab.c (copy_sub_char_table): Now static, since it's not used
11425 elsewhere.
5c156ace
PE
11426 (sub_char_table_ref_and_range, char_table_ref_and_range):
11427 Rename locals to avoid shadowing.
bbcd0949 11428 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11429
7d3b3862 11430 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11431 (BIDI_BOB): Remove unused macro.
7d3b3862 11432
6be7d3da
PE
11433 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11434 deduce are never used uninitialized.
c2ed9c8b 11435 * term.c (encode_terminal_code): Likewise.
6be7d3da 11436
75f8807f 11437 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11438
50938595
PE
11439 * tparam.h: New file.
11440 * term.c, tparam.h: Include it.
11441 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11442 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11443 Move these decls to tparam.h, and make them agree with what
11444 is actually in tparam.c. The previous trick of using incompatible
11445 decls in different modules does not conform to the C standard.
11446 All callers of tparam changed to use tparam's actual API.
11447 * tparam.c (tparam1, tparam, tgoto):
11448 Use const pointers where appropriate.
11449
fbceeba2
PE
11450 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11451 * cm.h (struct cm): Likewise.
11452 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11453 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11454 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11455 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11456 (turn_on_face, init_tty): Likewise.
11457 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11458
7f3f1250
PE
11459 * term.c (term_mouse_position): Rename local to avoid shadowing.
11460
e6ca6543
PE
11461 * alloc.c (mark_ttys): Move decl from here ...
11462 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11463
c40f8d15
AS
114642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11465
11466 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11467
cfe0661d
JB
114682011-03-09 Juanma Barranquero <lekktu@gmail.com>
11469
11470 * search.c (compile_pattern_1): Remove argument regp, unused since
11471 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11472 (compile_pattern): Don't pass it.
11473
0afb4571
J
114742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11475
11476 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11477 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11478 for ! HAVE_GTK3.
11479 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11480
11481 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11482
11483 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11484 gdk_window_get_screen, gdk_window_get_geometry,
11485 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11486 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11487 (xg_get_pixbuf_from_pixmap): New function.
11488 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11489 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11490 Call xg_get_pixbuf_from_pixmap instead of
11491 gdk_pixbuf_get_from_drawable.
11492 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11493 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11494 (xg_check_special_colors): Use GtkStyleContext and its functions
11495 for HAVE_GTK3.
11496 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11497 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11498 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11499 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11500 Call gtk_widget_get_preferred_size.
0afb4571
J
11501 (xg_frame_resized): gdk_window_get_geometry only takes 5
11502 parameters.
44f230aa
SM
11503 (xg_win_to_widget, xg_event_is_for_menubar):
11504 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11505 (xg_set_widget_bg): New function.
11506 (delete_cb): New function.
895009e1 11507 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11508 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11509 (xg_set_background_color): Call xg_set_widget_bg.
11510 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11511 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11512 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11513 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11514 if ! HAVE_GTK3.
11515 (update_frame_tool_bar): Call gtk_widget_hide.
11516 (xg_initialize): Use GDK_KEY_g.
11517
11518 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11519 if ! HAVE_GTK3
11520 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11521
11522 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11523 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11524 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11525
1c2cc4ef
JB
115262011-03-08 Juanma Barranquero <lekktu@gmail.com>
11527
11528 * w32xfns.c (select_palette): Check success of RealizePalette against
11529 GDI_ERROR, not zero.
11530
33383987 11531See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11532
11533;; Local Variables:
11534;; coding: utf-8
aac0c6e3
MR
11535;; End:
11536
2f097256 11537 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11538
11539 This file is part of GNU Emacs.
11540
11541 GNU Emacs is free software: you can redistribute it and/or modify
11542 it under the terms of the GNU General Public License as published by
11543 the Free Software Foundation, either version 3 of the License, or
11544 (at your option) any later version.
11545
11546 GNU Emacs is distributed in the hope that it will be useful,
11547 but WITHOUT ANY WARRANTY; without even the implied warranty of
11548 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11549 GNU General Public License for more details.
11550
11551 You should have received a copy of the GNU General Public License
11552 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.