Move GNU_LIBRARY_PENDING_OUTPUT_COUNT from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c8add24e
GM
12012-07-11 Glenn Morris <rgm@gnu.org>
2
3 * s/gnu.h, s/gnu-linux.h:
4 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
5
b41253a3
JW
62012-07-11 John Wiegley <johnw@newartisans.com>
7
8 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
9 function attribute, so we only use it if it exists in the
10 compiler.
11
d923b542
DA
122012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
13
14 Avoid call to strlen in fast_c_string_match_ignore_case.
15 * search.c (fast_c_string_match_ignore_case): Change to use
16 length argument. Adjust users accordingly.
17 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
18
5ebbef1d
PE
192012-07-11 Paul Eggert <eggert@cs.ucla.edu>
20
57054ddd
PE
21 Assume rename.
22 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
23
b747d3f7
PE
24 Assume perror.
25 * s/hpux10-20.h (HAVE_PERROR): Remove.
26 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
27 Remove dummy definition, as this problem was obsolete long ago.
28
5ebbef1d
PE
29 Assume strerror.
30 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
31
984e7f30
DA
322012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
33
34 Avoid calls to strlen in font processing functions.
35 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 36 (font_open_by_name): Change to use length argument. Adjust
984e7f30 37 users accordingly.
d923b542
DA
38 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
39 Adjust prototypes.
40 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
41 Change to return ptrdiff_t.
984e7f30
DA
42 (xfont_list_pattern, xfont_match): Use length returned by
43 xfont_decode_coding_xlfd.
44 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
45
20e94fdd
GM
462012-07-11 Glenn Morris <rgm@gnu.org>
47
9d596af3
GM
48 * s/darwin.h, s/freebsd.h, s/netbsd.h:
49 Move DONT_REOPEN_PTY to configure.
50
20e94fdd
GM
51 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
52 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
53
e99a530f
PE
542012-07-10 Paul Eggert <eggert@cs.ucla.edu>
55
22ffb973
PE
56 Remove "#define unix" that is no longer needed (Bug#11905).
57 * s/aix4-2.h (unix): Remove; no longer needed.
58
e9a9ae03
PE
59 EMACS_TIME simplification (Bug#11875).
60 This replaces macros (which typically do not work in GDB)
61 with functions, typedefs and enums, making the code easier to debug.
62 The functional style also makes code easier to read and maintain.
63 * systime.h: Include <sys/time.h> on all hosts, not just if
64 WINDOWSNT, since 'struct timeval' is needed in general.
65 (EMACS_TIME): Now a typedef, not a macro.
66 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
67 not macros.
68 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
69 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
70 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
71 (EMACS_TIME_LE): Now functions, not macros.
72 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
73 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
74 which are not functions. All uses rewritten to use:
75 (make_emacs_time): New function.
76 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
77 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
78 not functions. All uses rewritten to use the following, respectively:
79 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
80 (add_emacs_time, sub_emacs_time): New functions.
81 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
82 * fileio.c (Fcopy_file):
83 * xterm.c (XTflash): Get the current time closer to when it's used.
84 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
85
ffacb126
PE
86 * bytecode.c (targets): Suppress -Woverride-init warnings.
87
e99a530f
PE
88 Simplify by avoiding confusing use of strncpy etc.
89 * doc.c (Fsnarf_documentation):
90 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
91 * frame.c (Fmake_terminal_frame):
92 * gtkutil.c (get_utf8_string):
93 * lread.c (openp):
94 * nsmenu.m (ns_update_menubar):
95 * regex.c (regerror):
96 Prefer memcpy to strncpy and strncat when either will do.
97 * fileio.c (Fsubstitute_in_file_name):
98 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
99 (menu_separator_name_p):
100 * nsmenu.m (ns_update_menubar):
101 Prefer memcmp to strncmp when either will do.
102 * nsterm.m: Include <ftoastr.h>.
103 (ns_get_color):
104 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
105 Prefer snprintf to strncpy.
106 * nsterm.m (ns_term_init):
107 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
108 * nsterm.m (ns_term_init):
109 Avoid the need for strncpy, by using build_string or
110 make_unibyte_string directly. Use dtoastr, not snprintf.
111 * process.c (Fmake_network_process): Diagnose service names that
112 are too long, rather than silently truncating them or creating
113 non-null-terminated names.
114 (Fnetwork_interface_info): Likewise, for interface names.
115 * sysdep.c (system_process_attributes) [GNU_LINUX]:
116 Prefer sprintf to strncat.
117 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
118 Prefer vsnprintf to vsprintf + strncpy.
119
c59592b3
GM
1202012-07-10 Glenn Morris <rgm@gnu.org>
121
122 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
123 Clarify fallback case.
124
7d7bbefd
DA
1252012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
126
127 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
128 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
129 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 130 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
131 where argument type is known to be a Lisp_Cons.
132
3a4c8000
TT
1332012-07-10 Tom Tromey <tromey@redhat.com>
134
135 * bytecode.c (BYTE_CODE_THREADED): New macro.
136 (BYTE_CODES): New macro. Replaces all old byte-code defines.
137 (enum byte_code_op): New type.
138 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
139 (exec_byte_code): Use them. Use token threading when applicable.
140
2a0213a6
DA
1412012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
142
143 Optimize pure C strings initialization.
144 * lisp.h (make_pure_string): Fix prototype.
145 (build_pure_c_string): New function, defined as static inline. This
146 provides a better opportunity to optimize away calls to strlen when
147 the function is called with compile-time constant argument.
148 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
149 argument, adjust users accordingly. Use build_pure_c_string where
150 appropriate.
151 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
152 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
153 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
154
cb1caeaf
DA
1552012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
156
157 Avoid calls to strlen in miscellaneous functions.
158 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
159 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
160 * lread.c (openp): Likewise.
161
c293e30c
DA
1622012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Avoid calls to strlen in path processing functions.
165 * fileio.c (file_name_as_directory): Add comment. Change to add
166 srclen argument and return the length of result. Adjust users
167 accordingly.
168 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 169 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
170 users accordingly.
171 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
172
9e059e3f
GM
1732012-07-10 Glenn Morris <rgm@gnu.org>
174
d02eb359
GM
175 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
176 Move PENDING_OUTPUT_COUNT definition to configure.
177
882cf227
GM
178 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
179 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
180 * s/gnu.h (DATA_START): Move definitions to configure.
181
af6e839f
GM
182 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
183 We include usg5-4-common.h, which defines them both.
184
40289a12
GM
185 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
186 O_RDONLY already includes it).
187
9e059e3f
GM
188 Stop ns builds setting the EMACSLOADPATH environment variable.
189 * nsterm.m (ns_load_path): Rename from ns_init_paths.
190 Now it does not set EMACSLOADPATH, just returns the load-path string.
191 * nsterm.h: Update accordingly.
192 * lread.c [HAVE_NS]: Include nsterm.h.
193 (init_lread) [HAVE_NS]: Use ns_load_path.
194 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
195
7c4e8ec0
GM
1962012-07-09 Glenn Morris <rgm@gnu.org>
197
d4f600ff
GM
198 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
199 since the included bsd-common.h does so.
200
cbb31951
GM
201 Stop ns builds setting the EMACSPATH environment variable.
202 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
203 (ns_init_paths): Do not set EMACSPATH.
204 * nsterm.h (ns_exec_path): Add it.
205 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
206 Use ns_exec_path.
207
7c4e8ec0
GM
208 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
209
26bccfae
PE
2102012-07-09 Paul Eggert <eggert@cs.ucla.edu>
211
a0bee46f
PE
212 * process.c (wait_reading_process_output): 'waitchannels' was unset
213 when read_kbd || !NILP (wait_for_cell); fix this.
214
5994c183
PE
215 Add GCC-style 'const' attribute to functions that can use it.
216 * character.h (char_resolve_modifier_mask):
217 * keyboard.h (make_ctrl_char):
218 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
219 (init_character_once, next_almost_prime, init_fns, init_image)
220 (flush_pending_output, init_sound):
221 * mem-limits.h (start_of_data):
222 * menu.h (finish_menu_items):
223 Add ATTRIBUTE_CONST.
224 * emacs.c (DEFINE_DUMMY_FUNCTION):
225 Declare the dummy function with ATTRIBUTE_CONST.
226 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
227 Add decls with ATTRIBUTE_CONST.
228
26bccfae
PE
229 Minor improvements to make_formatted_string.
230 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
231 where int is good enough, as vsprintf returns an int.
232 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
233
a8290ec3
DA
2342012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
235
236 Use make_formatted_string to avoid double length calculation.
237 * lisp.h (make_formatted_string): New prototype.
238 * alloc.c (make_formatted_string): New function.
239 * buffer.c (Fgenerate_new_buffer_name): Use it.
240 * dbus.c (syms_of_dbusbind): Likewise.
241 * editfns.c (Fcurrent_time_zone): Likewise.
242 * filelock.c (get_boot_time): Likewise.
243 * frame.c (make_terminal_frame, set_term_frame_name)
244 (x_report_frame_params): Likewise.
245 * image.c (gs_load): Likewise.
246 * minibuf.c (get_minibuffer): Likewise.
247 * msdos.c (dos_set_window_size): Likewise.
248 * process.c (make_process): Likewise.
249 * xdisp.c (ensure_echo_area_buffers): Likewise.
250 * xsettings.c (apply_xft_settings): Likewise.
251
d01ba2f1
GM
2522012-07-09 Glenn Morris <rgm@gnu.org>
253
254 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
255 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
256 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
257 * nsterm.h (ns_etc_directory): Add it.
258 * callproc.c [HAVE_NS]: Include nsterm.h.
259 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
260
f1f924b6
DA
2612012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Move marker debugging code under MARKER_DEBUG.
264 * marker.c (MARKER_DEBUG): Move marker debugging code under
265 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
266 for bootstrap with --enable-checking (~3x slowdown reported
267 by Juanma Barranquero <lekktu@gmail.com>).
268 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
269
ab531b66
PE
2702012-07-08 Paul Eggert <eggert@cs.ucla.edu>
271
272 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
273 See <http://bugs.gnu.org/11825#29>.
274
c4b3bc8a
EZ
2752012-07-08 Eli Zaretskii <eliz@gnu.org>
276
277 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
278 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
279 (display_line): Add commentary about displaying truncation glyphs
280 on GUI frames.
281 (produce_special_glyphs): Move here from term.c.
282
283 * term.c (produce_special_glyphs): Move to xdisp.c.
284
285 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
286 section.
c4b3bc8a 287
b676b881
AS
2882012-07-07 Andreas Schwab <schwab@linux-m68k.org>
289
f17c5273
AS
290 * xdisp.c (display_line): Avoid warning about implicit declaration
291 of FRAME_FONT.
292
298819b9
AS
293 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
294
b676b881
AS
295 * lisp.h: Remove empty conditional.
296
6045c4fd
PE
2972012-07-07 Paul Eggert <eggert@cs.ucla.edu>
298
b3350bf9
PE
299 * lread.c (load_path_check): Now static.
300
6045c4fd
PE
301 Fix some minor --with-ns problems found by static checking.
302 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
303 (x_set_font) [!HAVE_X_WINDOWS]:
304 * image.c (xpm_load_image) [HAVE_NS]:
305 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
306 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
307 Remove unused local.
308 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
309 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
310 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
311 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
312 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
313 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
314 Fix pointer signedness problem.
315 * xfaces.c (FRAME_X_FONT_TABLE):
316 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
317
929e7845
GM
3182012-07-07 Glenn Morris <rgm@gnu.org>
319
320 * lread.c (load_path_check): New function, split from init_lread.
321 (init_lread): Reorganize. Motivation:
322 If EMACSLOADPATH is set, check/warn about that rather than the
323 defaults, which we are not going to use. Hence we can remove
324 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
325 Don't warn if site-lisp directories are missing.
326 If not installed, start from a blank load-path, since
327 PATH_LOADSEARCH refers to the eventual installation directories.
328
58dd0aa4
EZ
3292012-07-07 Eli Zaretskii <eliz@gnu.org>
330
331 Support truncation and continuation glyphs on GUI frames, when
332 fringes are disabled. (Bug#11832)
333 * xdisp.c (init_iterator): Get dimensions of truncation and
334 continuation glyphs even if on GUI frames. Adjust
335 it->last_visible_x on GUI frames when the left or right fringes,
336 or both, are absent.
337 (start_display, move_it_in_display_line_to): Handle the case of a
338 GUI frame without a fringe to display continuation or truncation
339 glyphs.
340 (insert_left_trunc_glyphs): Support GUI frames: make sure
341 truncation glyphs overwrite enough glyphs from the current line to
342 have sufficient space in pixels.
343 (display_line): Support truncation and continuation glyphs on GUI
344 frames. If some spare pixels are left on the line after inserting
345 the truncation glyphs, fill that space with a stretch glyph of a
346 suitably computed width.
347
348 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
349 produce_glyphs, to support GUI sessions.
350
31571fd7
PE
3512012-07-07 Paul Eggert <eggert@cs.ucla.edu>
352
5a16b9bc
PE
353 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
354
f3047c75
PE
355 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
356
31571fd7
PE
357 Do not require float-time's arg to fit in time_t (Bug#11825).
358 This works better on hosts where time_t is unsigned, and where
359 float-time is applied to the (negative) difference between two times.
360 * editfns.c (decode_time_components): Last arg is now double *,
361 not int *, and means to store all the result as a double, without
362 worrying about whether the seconds part fits in time_t.
363 All callers changed.
364 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
365 All callers changed.
366 (Ffloat_time): Do not fail merely because the specified time falls
367 outside of time_t range.
368
4516fbef
GM
3692012-07-07 Glenn Morris <rgm@gnu.org>
370
371 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
372 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
373 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
374
07adc2c6
JB
3752012-07-07 Juanma Barranquero <lekktu@gmail.com>
376
377 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
378 Update dependencies.
379
380 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
381
fd573f31
PE
3822012-07-06 Paul Eggert <eggert@cs.ucla.edu>
383
fee5959d
PE
384 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
385 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
386 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
387 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
388 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
389 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
390
fd573f31
PE
391 * xfont.c (compare_font_names): Redo to omit the need for casts.
392
ddadbc0e
AS
3932012-07-06 Andreas Schwab <schwab@linux-m68k.org>
394
fca8d6b6
AS
395 * xfns.c (Fx_change_window_property): Doc fix.
396 * w32fns.c (Fx_change_window_property): Doc fix.
397
ddadbc0e
AS
398 * w32fns.c (Fx_window_property): Accept the same arguments as the
399 X Windows version. Doc fix.
400 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
401
f247498e
JB
4022012-07-06 Juanma Barranquero <lekktu@gmail.com>
403 Eli Zaretskii <eliz@gnu.org>
404
405 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
406 Windows-specific code from nt/config.nt moved here.
407 Obsolete settings removed.
408
216ee680
PE
4092012-07-06 Paul Eggert <eggert@cs.ucla.edu>
410
411 * process.c: Avoid unnecessary calls to gettime.
412 (wait_reading_process_output): Don't get the time of day
413 when gobbling data immediately and not waiting, as there's no need
414 for it in that case. This removes a FIXME.
415
bdd091e4
JD
4162012-07-06 Jan Djärv <jan.h.d@swipnet.se>
417
418 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
419 is defined (Bug#11768).
420
9d44f8ce
DA
4212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
422
423 Fix marker debugging code.
424 * marker.c (byte_char_debug_check): Do not perform the check
425 if buffer is not multibyte.
090bd7cb
JB
426 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
427 Call byte_char_debug_check with correct arguments.
9d44f8ce 428
90fc4786
DA
4292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
430
431 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
432 * marker.c (byte_char_debug_check, count_markers):
433 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
434 (byte_debug_flag): Remove.
435 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
436 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
437
7b7ae965
DA
4382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
439
4e57b342
DA
440 Avoid code repetition in marker-related functions.
441 * marker.c (attach_marker): New function.
442 (Fset_marker, set_marker_restricted, set_marker_both)
443 (set_marker_restricted_both): Use it.
444 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
445 Consistently rename charno to charpos.
446 (marker_position): Add eassert.
447 (marker_byte_position): Convert to eassert.
448
4492012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 452 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 453 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 454
657924ff
DA
4552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
456
457 Introduce fast path for the widely used marker operation.
458 * alloc.c (build_marker): New function.
459 * lisp.h (build_marker): New prototype.
460 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
461 * composite.c (autocmp_chars): Likewise.
462 * editfns.c (buildmark): Remove.
463 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
464 (save_restriction_save): Use build_marker.
465 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
466 * window.c (save_window_save): Likewise.
467
041a49a6
DA
4682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
469
470 Do not use Fdelete_overlay in delete_all_overlays
471 to avoid redundant calls to unchain_overlay.
472 * buffer.c (drop_overlay): New function.
473 (delete_all_overlays, Fdelete_overlay): Use it.
474 * minibuf.c (get_minibuffer): Fix comment.
475
7dca65a4
PE
4762012-07-06 Paul Eggert <eggert@cs.ucla.edu>
477
478 Port to OpenBSD 5.1 amd64.
479 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
480 This is needed for OpenBSD, and should be harmless on all BSD systems.
481 Also, include <sys/sysctl.h>, as it should be available on all
482 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
483 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
484 use p_pid member, not kp_proc.pid.
485
8eb876e2
GM
4862012-07-06 Glenn Morris <rgm@gnu.org>
487
488 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
489
38182d90
PE
4902012-07-05 Paul Eggert <eggert@cs.ucla.edu>
491
492 More xmalloc and related cleanup.
493 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
494 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
495 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
496 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
497 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
498 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
499 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
500 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
501 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
502 * xterm.c:
503 Omit needless casts involving void * pointers and allocation.
504 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
505 as the former is more robust if P's type is changed.
506 Prefer xzalloc to xmalloc + memset 0.
507 Simplify malloc-or-realloc to realloc.
508 Don't worry about xmalloc returning a null pointer.
509 Prefer xstrdup to xmalloc + strcpy.
510 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
511 growing it.
512 * keyboard.c (apply_modifiers_uncached): Prefer local array to
513 alloca of a constant.
514
6dd5a677
EZ
5152012-07-05 Eli Zaretskii <eliz@gnu.org>
516
517 * xdisp.c (display_line): Fix horizontal pixel coordinates when
518 hscroll is larger than the line width. Fixes long and futile
519 looping inside extend_face_to_end_of_line (on a TTY) producing
520 glyphs that are not needed and thrown away.
521
6b312f0f
DA
5222012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
523
524 * marker.c (set_marker_restricted_both): Simplify by using
525 clip_to_bounds.
526
f520ef9b
PE
5272012-07-05 Paul Eggert <eggert@cs.ucla.edu>
528
529 * editfns.c (region_limit): Simplify by using clip_to_bounds.
530
383b7c95
JD
5312012-07-05 Jan Djärv <jan.h.d@swipnet.se>
532
533 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
534 not defined (Bug#11768).
535 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
536 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
537 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
538 followed by gtk_box_set_homogeneous (Bug#11768).
539 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
540 (update_theme_scrollbar_width, xg_create_scroll_bar):
541 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
542 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
543 (is_box_type): New function (Bug#11768).
544 (xg_tool_item_stale_p): Call is_box_type.
5293d758 545 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
546 with default display (Bug#11768).
547
d6e7bf45
EZ
5482012-07-05 Eli Zaretskii <eliz@gnu.org>
549
550 * xdisp.c (window_hscroll_limited): New function.
551 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
552 coordinates when window's hscroll is set to insanely large
553 values. (Bug#11857)
554
431391ec
JB
5552012-07-05 Juanma Barranquero <lekktu@gmail.com>
556
557 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
558 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
559
23f86fce
DA
5602012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
561
562 Cleanup xmalloc.
563 * lisp.h (xzalloc): New prototype. Omit needless casts.
564 * alloc.c (xzalloc): New function. Omit needless casts.
565 * charset.c: Omit needless casts. Convert all calls to
566 xmalloc with following memset to xzalloc.
567 * dispnew.c: Likewise.
568 * fringe.c: Likewise.
569 * image.c: Likewise.
570 * sound.c: Likewise.
571 * term.c: Likewise.
572 * w32fns.c: Likewise.
573 * w32font.c: Likewise.
574 * w32term.c: Likewise.
575 * xfaces.c: Likewise.
576 * xfns.c: Likewise.
577 * xterm.c: Likewise.
578 * atimer.c: Omit needless casts.
579 * buffer.c: Likewise.
580 * callproc.c: Likewise.
581 * ccl.c: Likewise.
582 * coding.c: Likewise.
583 * composite.c: Likewise.
584 * doc.c: Likewise.
585 * doprnt.c: Likewise.
586 * editfns.c: Likewise.
587 * emacs.c: Likewise.
588 * eval.c: Likewise.
589 * filelock.c: Likewise.
590 * fns.c: Likewise.
591 * gtkutil.c: Likewise.
592 * keyboard.c: Likewise.
593 * lisp.h: Likewise.
594 * lread.c: Likewise.
595 * minibuf.c: Likewise.
596 * msdos.c: Likewise.
597 * print.c: Likewise.
598 * process.c: Likewise.
599 * region-cache.c: Likewise.
600 * search.c: Likewise.
601 * sysdep.c: Likewise.
602 * termcap.c: Likewise.
603 * terminal.c: Likewise.
604 * tparam.c: Likewise.
605 * w16select.c: Likewise.
606 * w32.c: Likewise.
607 * w32reg.c: Likewise.
608 * w32select.c: Likewise.
609 * w32uniscribe.c: Likewise.
610 * widget.c: Likewise.
611 * xdisp.c: Likewise.
612 * xmenu.c: Likewise.
613 * xrdb.c: Likewise.
614 * xselect.c: Likewise.
615
0497dc44
PE
6162012-07-05 Paul Eggert <eggert@cs.ucla.edu>
617
618 * fileio.c (time_error_value): Check the right error number.
619 Problem reported by Troels Nielsen in
620 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
621
356e7178
PE
6222012-07-04 Paul Eggert <eggert@cs.ucla.edu>
623
4e71fd89
PE
624 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
625 This should be fixed in a better way; see Eli Zaretskii in
626 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
627 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
628
f0941253
PE
629 * fileio.c (time_error_value): Rename from special_mtime.
630 The old name's problems were noted by Eli Zaretskii in
631 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
632
065c9eb4
PE
633 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
634 This variable's comment says Emacs needs at least one GDB-visible
635 symbol of type enum pvec_type, to work around GDB problems.
636 The symbol's value doesn't matter.
637
356e7178
PE
638 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
639 that causes compilation to fail on pre-C99 compilers.
640
95f61aa2
JB
6412012-07-04 Juanma Barranquero <lekktu@gmail.com>
642
643 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
644 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
645
3884d954
DA
6462012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
647
d209e2fb 648 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
649 headers for buffer_defaults and buffer_local_symbols.
650 Reported by Juanma Barranquero <lekktu@gmail.com>.
651
ee28be33
SM
6522012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
653
654 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
655 * lisp.h (enum pvec_type): Use fewer bits.
656 (PSEUDOVECTOR_SIZE_BITS): New constant.
657 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
658 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
659 change in pvec_type.
660 (PSEUDOVECTOR_TYPEP): New macro.
661 (TYPED_PSEUDOVECTORP): Use it.
662 * fns.c (internal_equal): Adapt code to extract pvectype.
663 * emacs.c (gdb_pvec_type): Update type.
664 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
665 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
666 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
667 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
668 (sweep_vectors): Use it. Use local var `total_bytes' instead of
669 abusing vector->header.next.nbytes.
670 (live_vector_p): Use PVEC_TYPE.
671 (mark_object): Adapt code to extract pvectype. Use switch.
672
c7f2cd7f
PE
6732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
674
675 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
676 Tighten new eassert a bit.
677
8ce70ed2
DA
6782012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
679
680 Fix compilation with --enable-gcc-warnings and -O1
681 optimization level.
682 * doprnt.c (doprnt): Change type of tem to int, initialize
683 to avoid compiler warning. Add eassert.
684 * search.c (simple_search): Initialize match_byte to avoid
685 compiler warning. Add eassert.
686
dea7f1e5
PE
6872012-07-04 Paul Eggert <eggert@cs.ucla.edu>
688
24a212eb
PE
689 Avoid weird behavior with large horizontal scrolls.
690 Without this change, for example, large hscroll values would
691 mess up Emacs's display on Fedora 15 x86, presumably due to
692 overflows in int calculations in the display code.
693 Also, if buffers had long lines, Emacs would freeze.
694 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
695 (set_window_hscroll): New function, containing the old guts of
696 Fset_window_hscroll. Return the clipped value.
697 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
698 This avoids the need to check against PTRDIFF_MAX.
699
dea7f1e5
PE
700 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
701
76046526
DA
7022012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
703
704 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
705
39adff0d
PE
7062012-07-04 Paul Eggert <eggert@cs.ucla.edu>
707
63807d47
PE
708 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
709 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
710 since GCC 4.4.6 issues a bogus warning for them.
711
39adff0d
PE
712 Fix bugs in file timestamp newness comparisons.
713 * fileio.c (Ffile_newer_than_file_p):
714 * lread.c (Fload): Use full timestamp resolution of files,
715 not just the 1-second resolution, so that files that are only
716 slightly newer still count as newer.
717 * fileio.c (Ffile_newer_than_file_p): Don't assume file
718 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
719
dbeed9a6
PE
7202012-07-03 Paul Eggert <eggert@cs.ucla.edu>
721
722 * fileio.c: Improve handling of file time marker. (Bug#11852)
723 (special_mtime): New function.
724 (Finsert_file_contents, Fverify_visited_file_modtime):
725 Use it to set special mtime values consistently.
726
636334d6
AS
7272012-07-03 Andreas Schwab <schwab@linux-m68k.org>
728
729 * fileio.c (Finsert_file_contents): Properly handle st_mtime
730 marker for non-existing file. (Bug#11852)
731
e2017fe2
GM
7322012-07-03 Glenn Morris <rgm@gnu.org>
733
734 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
735 and did not make it into globals.h).
736
404dbd37
TT
7372012-07-03 Tom Tromey <tromey@redhat.com>
738
739 * window.c (Fset_window_margins, Fset_window_fringes)
740 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
741 * textprop.c (Fprevious_property_change): No longer static.
742 * syntax.c (Fsyntax_table_p): No longer static.
743 * process.c (Fget_process, Fprocess_datagram_address): No longer
744 static.
745 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
746 * keyboard.c (Fcommand_execute): No longer static.
747 Remove EXFUN.
748 * insdel.c (Fcombine_after_change_execute): No longer static.
749 * image.c (Finit_image_library): No longer static.
750 * fileio.c (Fmake_symbolic_link): No longer static.
751 * eval.c (Ffetch_bytecode): No longer static.
752 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
753 * doc.c (Fdocumentation_property, Fsnarf_documentation):
754 No longer static.
404dbd37
TT
755 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
756 static.
757 * dired.c (Ffile_attributes): No longer static.
758 * composite.c (Fcomposition_get_gstring): No longer static.
759 * callproc.c (Fgetenv_internal): No longer static.
760
761 * ccl.h: Remove EXFUNs.
762 * buffer.h: Remove EXFUNs.
763 * dispextern.h: Remove EXFUNs.
764 * intervals.h: Remove EXFUNs.
765 * fontset.h: Remove EXFUN.
766 * font.h: Remove EXFUNs.
767 * dosfns.c (system_process_attributes): Remove EXFUN.
768 * keymap.h: Remove EXFUNs.
769 * lisp.h: Remove EXFUNs.
770 * w32term.h: Remove EXFUNs.
771 * window.h: Remove EXFUNs.
772 * xsettings.h: Remove EXFUN.
773 * xterm.h: Remove EXFUN.
774
8e4fd1e1
GM
7752012-07-03 Glenn Morris <rgm@gnu.org>
776
777 * lisp.h (Frandom): Make it visible to C.
778 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
779 buffer for invisible buffers. (Bug#1229)
780
ca95b3eb
DA
7812012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
782
783 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
784 values which aren't power of 2.
785 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
786 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
787 accordingly.
788
7555c33f
SM
7892012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
790
791 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
792
793 * alloc.c (mark_object): Revert part of last patch to use `switch'.
794
d12e8f5a
DA
7952012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
796
797 * alloc.c (allocate_vector_block): Remove redundant
798 calls to mallopt if DOUG_LEA_MALLOC is defined.
799 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
800 avoid calls to mallopt if zero_vector is returned.
801
296094c3
DA
8022012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
803
804 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
805 is enabled, avoid dereferencing NULL current_sblock if
806 running undumped.
807
36429c89
DA
8082012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Cleanup basic buffer management.
811 * buffer.h (struct buffer): Change layout to use generic vector
812 marking code. Fix some comments. Change type of 'clip_changed'
813 to bitfield. Remove unused #ifndef old.
814 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
815 (GET_OVERLAYS_AT): Fix indentation.
816 (for_each_per_buffer_object_at): New macro.
817 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
818 (Fbuffer_local_variables): Use it.
819 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
820 * alloc.c (allocate_buffer): Adjust to match new layout of
821 struct buffer. Fix comment.
822 (mark_overlay): New function.
823 (mark_buffer): Use it. Use mark_vectorlike to mark normal
824 Lisp area of struct buffer.
825 (mark_object): Use it. Adjust marking of misc objects
826 and related comments.
827
3b3e4cac
PE
8282012-07-02 Paul Eggert <eggert@cs.ucla.edu>
829
830 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
831 wrapper that is not needed because the wrapped code is a no-op (zero
832 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
833 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
834
cf5c0175
DA
8352012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
836
837 * alloc.c (mark_buffer): Simplify. Remove prototype.
838 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 839 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
840 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
841 redundant calls to mark_vectorlike for bool vectors.
842
ca26824c
GM
8432012-06-30 Glenn Morris <rgm@gnu.org>
844
2e4c5312
GM
845 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
846
ca26824c
GM
847 * epaths.in (PATH_SITELOADSEARCH): New.
848 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
849 This is rather than relying on --enable-locallisppath elements
850 having "site-lisp" in their names. (Bug#10208#25, 11658)
851
0d23c240
EZ
8522012-06-30 Eli Zaretskii <eliz@gnu.org>
853
c9240d7a
EZ
854 * w32proc.c (sys_select): Accept and ignore one more argument.
855
856 * w32.c (emacs_gnutls_pull): Call select with one more argument.
857
0d23c240 858 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 859 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
860
861 * sysdep.c: Don't include dos.h and dosfns.h.
862
863 * process.c (sys_select):
864 * msdos.c (sys_select): Accept one more argument and ignore it.
865
866 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
867 adapt data types and code to that.
868
869 * dosfns.c:
870 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
871 which clashes with the gnulib function of the same name.
872
af5a5a98
AS
8732012-06-30 Andreas Schwab <schwab@linux-m68k.org>
874
c5e4379c
AS
875 * font.c (font_style_to_value, font_style_symbolic)
876 (font_prop_validate_style): Add type checks for values in
877 font_style_table.
878
af5a5a98
AS
879 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
880 argument.
881 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
882 uses.
883
8d38f461
EZ
8842012-06-29 Eli Zaretskii <eliz@gnu.org>
885
2e5a6631
EZ
886 * xdisp.c (try_window_id): Undo last change.
887
8d38f461
EZ
888 * w32.c (getwd): Adjust commentary about startup_dir.
889 (init_environment): Always call sys_access, even in non-MSVC
890 builds. Don't chdir to the directory of the Emacs executable.
891 This undoes code from 1997 which was justified by the need to
892 "avoid conflicts when removing and renaming directories". But its
893 downside was that every relative file name was being interpreted
894 relative to the directory of the Emacs executable, which can never
895 be TRT. In particular, it broke sys_access when called with
896 relative file names.
897 (sys_access): Map GetLastError to errno.
898
2af3565e
DA
8992012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
900
901 * window.h (struct window): Change type of 'fringes_outside_margins'
902 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 903 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
904 Adjust comment.
905 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
906 to ptrdiff_t.
907
c8d3a25c 9082012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 909
c8d3a25c
GM
910 * gnutls.c (emacs_gnutls_handshake):
911 Add QUIT to make the loop interruptible.
57570cd3 912
c8d3a25c 9132012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 914
c8d3a25c
GM
915 * charset.c (init_charset): Make lack of etc/charsets fatal.
916
3e984ee8
DA
9172012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
918
919 * editfns.c (region_limit): Fix type mismatch.
920
ef884f23
DA
9212012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
922
923 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
924 undefined. Convert from xassert to eassert.
925 * nsmenu.m: Convert from xassert to eassert.
926 * nsterm.m: Likewise.
927
7d7e0027
SM
9282012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
929
930 * editfns.c (region_limit): Clip to narrowing (bug#11770).
931
aa754e6a
PE
9322012-06-28 Paul Eggert <eggert@cs.ucla.edu>
933
934 Avoid integer overflow on scroll-left and scroll-right.
935 * window.c (HSCROLL_MAX): New macro.
936 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
937 overflow when requested scroll falls outside ptrdiff_t range.
938
80b00b08
DA
9392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * window.h (struct window): Change type of 'hscroll',
942 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
943 'last_modified' and 'last_overlay_modified' to EMACS_INT.
944 Adjust users accordingly.
945 * xdisp.c (try_cursor_movement): Replace type check with eassert.
946 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
947 from EMACS_INT to ptrdiff_t.
948 (make_window): Omit redundant initialization.
949
62b2bcf6
JB
9502012-06-28 Juanma Barranquero <lekktu@gmail.com>
951
952 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
953
45942c7d
DA
9542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
955
956 * window.h (struct window): Change type of 'use_time' and
957 'sequence_number' from Lisp_Object to int.
958 * frame.c (make_frame): Adjust users accordingly.
959 * print.c (print_object): Likewise.
960 * window.c (select_window, Fwindow_use_time, make_parent_window)
961 (make_window): Likewise.
962
e509cfa6
DA
9632012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
964
965 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
966 enabled with --enable-checking=[all,glyphs] configure option.
967 Fix GLYPH_DEBUG usage assuming that it may be undefined,
968 adjust comments accordingly.
969 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
970 undefined, adjust comments accordingly.
971 * image.c: Likewise.
972 * scroll.c: Likewise.
973 * w32fns.c: Likewise.
974 * w32term.c: Likewise.
975 * xdisp.c: Likewise.
976 * xfaces.c: Likewise.
977 * xfns.c: Likewise.
978 * xterm.c: Likewise.
979
a54e2c05
DA
9802012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
981
982 Generalize run-time debugging checks.
983 * dispextern.h (XASSERTS): Remove.
984 * fontset.c (xassert): Remove.
985 Convert from xassert to eassert.
986 * alloc.c: Convert from xassert to eassert.
987 * bidi.c: Likewise.
988 * dispnew.c: Likewise.
989 * fns.c: Likewise.
990 * fringe.c: Likewise.
991 * ftfont.c: Likewise.
992 * gtkutil.c: Likewise.
993 * image.c: Likewise.
994 * keyboard.c: Likewise.
995 * menu.c: Likewise.
996 * process.c: Likewise.
997 * scroll.c: Likewise.
998 * sound.c: Likewise.
999 * term.c: Likewise.
1000 * w32console.c: Likewise.
1001 * w32fns.c: Likewise.
1002 * w32term.c: Likewise.
1003 * window.c: Likewise.
1004 * xdisp.c: Likewise.
1005 * xfaces.c: Likewise.
1006 * xfns.c: Likewise.
1007 * xselect.c: Likewise.
1008 * xterm.c: Likewise.
1009
1ec4b7b2
SM
10102012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1011
1012 * fns.c (maybe_resize_hash_table): Output message when growing the
1013 purify-hashtable.
1014
2014308a
DA
10152012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 * alloc.c (allocate_string_data): Remove dead code.
1018 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1019 avoid GCC warning about unused macro.
1020
246155eb
DA
10212012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1022
1023 * alloc.c (allocate_string): Omit intervals initialization.
1024 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1025 as in make_pure_string and make_pure_c_string.
1026
43184b7b
DA
10272012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1028
d209e2fb 1029 * alloc.c (allocate_string): Fix last change.
43184b7b 1030
3fe6dd74
DA
10312012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1032
d209e2fb 1033 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1034 to memset, add explicit initialization where appropriate.
1035
1ba6038a
GM
10362012-06-27 Glenn Morris <rgm@gnu.org>
1037
1038 * lisp.mk (lisp): Remove paths.elc.
1039
c89926a5
CY
10402012-06-27 Chong Yidong <cyd@gnu.org>
1041
1042 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1043
ed6b3510
JW
10442012-06-26 John Wiegley <johnw@newartisans.com>
1045
1ec4b7b2 1046 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1047 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1048
ed6b3510
JW
1049 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1050 when building with Clang.
1051
8edd4a2b
SM
10522012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1053
1054 * eval.c (Fapply): Allow calling it with a single argument.
1055
f6f62d1b
EZ
10562012-06-26 Eli Zaretskii <eliz@gnu.org>
1057
1058 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1059 _stricmp and _strnicmp.
1060 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1061
62efea5e
DA
10622012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1063
1064 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1065 allocated window.
1066 (allocate_process): Likewise for new process.
8edd4a2b 1067 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1068 (allocate_frame): Likewise.
1069 * frame.c (make_frame): Omit redundant initialization.
1070 * window.c (make_parent_window): Use memset.
1071 (make_window): Omit redundant initialization.
1072 * process.c (make_process): Omit redundant initialization.
1073 * terminal.c (create_terminal): Likewise.
1074
42997f4d
DA
10752012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1076
1077 * term.c (delete_tty): Remove redundant call to memset.
1078
1130ecfc
DA
10792012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1080
1081 * alloc.c: Remove build_string.
1082 * lisp.h: Define build_string as static inline. This provides
1083 a better opportunity to optimize away calls to strlen when the
1084 function is called with compile-time constant argument.
1085 * image.c (imagemagick_error): Convert to build_string.
1086 * w32proc.c (sys_spawnve): Likewise.
1087 * xterm.c (x_term_init): Likewise.
1088
cf38a720
PE
10892012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1090
99027bdd
PE
1091 Use sprintf return value instead of invoking strlen on result.
1092 In the old days this wasn't portable, since some sprintf
1093 implementations returned char *. But they died out years ago and
1094 Emacs already assumes sprintf returns int.
1095 Similarly for float_to_string.
1096 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1097 * ccl.c (ccl_driver):
1098 * character.c (string_escape_byte8):
1099 * data.c (Fnumber_to_string):
1100 * doprnt.c (doprnt):
1101 * print.c (print_object):
1102 * xdisp.c (message_dolog):
1103 * xfns.c (syms_of_xfns):
1104 Use sprintf or float_to_string result to avoid need to call strlen.
1105 * data.c (Fnumber_to_string):
1106 Use make_unibyte_string, since the string must be ASCII.
1107 * lisp.h, print.c (float_to_string): Now returns int length.
1108 * term.c (produce_glyphless_glyph):
1109 Use sprintf result rather than recomputing it.
1110
cf38a720
PE
1111 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1112 * Makefile.in (ALL_CFLAGS):
1113 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1114 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1115
3511c784
DA
11162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1117
0a08eb21 1118 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1119 strcasecmp if available.
1120 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1121
fb7da12e
AS
11222012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1123
1124 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1125 Avoid comma operator.
1126 * menu.c (push_submenu_start, push_submenu_end)
1127 (push_left_right_boundary, push_menu_pane): Likewise.
1128 * msdos.c (dos_rawgetc): Likewise.
1129
afa2ffd8
DA
11302012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 * xfns.c (xic_create_fontsetname): Remove redundant calls
1133 to memset.
1134
b3b4476b
PE
11352012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1136
4495ff38
PE
1137 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1138 sprintf already null-terminates its output.
1139
b3b4476b
PE
1140 * xfns.c (x_window): Remove redundant cast.
1141
b00876c9
DA
11422012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1145 `const char *' to `char *' to avoid compiler warning.
1146
d188e26b
PE
11472012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1148
885d1d74
PE
1149 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1150 instead of truncating it to 63 (admittedly a generous limit).
1151
d188e26b
PE
1152 * process.c: Fix spelling and caps in comments.
1153
e2f560b1
DN
11542012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1155
e86db54b 1156 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1157 * sysdep.c (setpgrp): Remove definition, not used in this file.
1158
7583a3a1
JB
11592012-06-24 Juanma Barranquero <lekktu@gmail.com>
1160
1161 * makefile.w32-in: Update dependencies.
1162
696056c2
EZ
11632012-06-24 Eli Zaretskii <eliz@gnu.org>
1164
1165 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1166 (SYSTIME_H): Add nt/inc/sys/time.h.
1167
1168 * systime.h [WINDOWSNT]: Include sys/time.h.
1169
1170 * s/ms-w32.h (struct timespec): Definition moved from
1171 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1172
845ca893
PE
11732012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1176 * buffer.h (buffer_slot_type_mismatch):
1177 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1178 * eval.c (unwind_to_catch):
1179 * image.c (my_png_error, my_error_exit):
1180 * keyboard.c (quit_throw_to_read_char, user_error)
1181 (Fexit_recursive_edit, Fabort_recursive_edit):
1182 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1183 (wrong_type_argument, buffer_overflow, __executable_start)
1184 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1185 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1186 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1187 (fatal):
1188 (child_setup) [!DOS_NT]:
1189 * lread.c (end_of_file_error, invalid_syntax):
1190 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1191 * puresize.h (pure_write_error):
1192 * search.c (matcher_overflow):
1193 * sound.c (sound_perror, alsa_sound_perror):
1194 * sysdep.c, syssignal.h (croak):
1195 * term.c (maybe_fatal, vfatal):
1196 * textprop.c (text_read_only):
1197 * undo.c (user_error):
1198 * unexmacosx.c (unexec_error):
1199 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1200 Use _Noreturn rather than NO_RETURN.
1201 No need for separate decl merely because of _Noreturn.
1202 * sound.c (sound_warning, parse_sound):
1203 Remove unnecessary forward decls.
1204
f1dd8073
PE
12052012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1208 * lisp.h (WAIT_READING_MAX): New macro.
1209 * dispnew.c (Fsleep_for, sit_for):
1210 * keyboard.c (kbd_buffer_get_event):
1211 * process.c (Faccept_process_output):
1212 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1213 This improves on the previous patch, which introduced a bug
1214 when time_t is unsigned and as wide as intmax_t.
1215 See <http://bugs.gnu.org/9000#51>.
1216
b82c1755
EZ
12172012-06-23 Eli Zaretskii <eliz@gnu.org>
1218
1219 * dispnew.c (sit_for, Fsleep_for):
1220 * keyboard.c (kbd_buffer_get_event):
1221 * process.c (Faccept_process_output): Avoid compiler warnings when
1222 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1223
ca300656
JB
12242012-06-23 Juanma Barranquero <lekktu@gmail.com>
1225
049ec95b
JB
1226 * makefile.w32-in: Update dependencies.
1227
ca300656
JB
1228 * w32.c (ltime): Add return type and declare static.
1229 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1230
db7b8d06
PE
12312012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1234 Privately reported by Herbert J. Skuhra.
1235 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1236 All uses changed.
1237 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1238 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1239
0bd8297f
EZ
12402012-06-23 Eli Zaretskii <eliz@gnu.org>
1241
96512555
EZ
1242 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1243 last argument of make_unibyte_string.
1244
0bd8297f
EZ
1245 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1246 language ID in the event parameters.
1247
1248 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1249 event.code, not the obscure "character set ID".
1250
63def6b6
CY
12512012-06-23 Chong Yidong <cyd@gnu.org>
1252
1253 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1254
e8a02204
EZ
12552012-06-23 Eli Zaretskii <eliz@gnu.org>
1256
388cdec0
EZ
1257 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1258 * w32.c (fdutimens): New function.
1259
1260 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1261
1262 * s/ms-w32.h (pselect): Redirect to sys_select.
1263
1264 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1265
e8a02204
EZ
1266 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1267 in the logic of incrementing and decrementing the value of
1268 use_relocatable_buffers.
1269
d054f3fb
PE
12702012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1273 Privately reported by Herbert J. Skuhra.
1274 [__FreeBSD__]: Remove "*/" typo after "#include".
1275 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1276 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1277 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1278 Don't assume EMACS_TIME and struct timeval are the same type.
1279
d35af63c
PE
12802012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 Support higher-resolution time stamps (Bug#9000).
1283 The time stamps are only nanosecond-resolution at the C level,
1284 since that's the best that any real-world system supports now.
1285 But they are picosecond-resolution at the Lisp level, as that's
1286 easy, and leaves room for future OS improvements.
1287
1288 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1289 (LIBES): Use it.
1290
1291 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1292 Don't get current time unless it's needed.
1293
1294 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1295 now provides it if it's absent.
1296 (start_atimer): Port to higher-res time stamps.
1297 Check for time stamp overflow. Don't get current time more
1298 often than is needed.
1299
1300 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1301 Include systime.h, not time.h.
1302 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1303
1304 * dired.c: Include stat-time.h.
1305 (Ffile-attributes): File times now have higher resolution.
1306
1307 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1308 (struct image): Timestamp now has higher resolution.
1309
1310 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1311 has at least microseconds now. All uses removed.
1312 (update_frame, update_single_window, update_window, update_frame_1)
1313 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1314
1315 * editfns.c (time_overflow): Now extern.
1316 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1317 (float-time, Fformat_time_string, Fcurrent_time_string)
1318 (Fcurrent_time_zone): Accept and generate higher-resolution
1319 time stamps.
1320 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1321 (decode_time_components, lisp_seconds_argument): New functions.
1322 (make_time): Now static.
1323 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1324 Report an error if the time is invalid, rather than having the caller
1325 do that.
1326
1327 * fileio.c: Include <stat-time.h>
1328 (Fcopy_file): Copy higher-resolution time stamps.
1329 Prefer to set the time stamp via a file descriptor if that works.
1330 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1331 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1332 (Fvisited_file_modtime, Fset_visited_file_modtime):
1333 Support higher-resolution time stamps.
1334
1335 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1336
1337 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1338
1339 * image.c (prepare_image_for_display, clear_image_cache)
1340 (lookup_image): Port to higer-resolution time stamps.
1341
1342 * keyboard.c (start_polling, bind_polling_period):
1343 Check for time stamp overflow.
1344 (read_char, kbd_buffer_get_event, timer_start_idle)
1345 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1346 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1347 Port to higher-resolution time stamps. Do not assume time_t is signed.
1348 (decode_timer): New function. Timers are now vectors of length 9,
1349 not 8, to accommodate the picosecond component.
1350 (timer_check_2): Use it.
1351
1352 * nsterm.m (select_timeout, timeval_subtract): Remove.
1353 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1354 as they're a bit more accurate and handle overflow better.
1355 (ns_select): Change prototype to be compatible with pselect.
1356 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1357 * nsterm.h (ns_select): Adjust prototype.
1358
1359 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1360 us-resolution time stamps.
1361 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1362
1363 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1364
1365 * lisp.h (time_overflow): New decl.
1366 (wait_reading_process_output): First arg is now intmax_t, not int,
1367 to accommodate larger waits.
1368
1369 * process.h (struct Lisp_Process.read_output_delay):
1370 Now counts nanoseconds, not microseconds.
1371 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1372 EMACS_HAS_USECS.
1373 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1374 (wait_reading_process_output):
1375 Port to ns-resolution time stamps.
1376 (Faccept_process_output, wait_reading_process_output):
1377 Check for time stamp overflow. Do not assume time_t is signed.
1378 (select_wrapper): Remove; we now use pselect.
1379 (Fprocess_attributes): Now generates ns-resolution time stamps.
1380
1381 * sysdep.c: Include utimens.h. Don't include utime.h
1382 or worry about struct utimbuf; gnulib does that for us now.
1383 (gettimeofday): Remove; gnulib provides a substitute.
1384 (make_timeval): New function.
1385 (set_file_times): Now sets ns-resolution time stamps.
1386 New arg FD; all uses changed.
1387 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1388 (system_process_attributes):
1389 Now returns ns-resolution time stamp. All uses changed.
1390 Check for time stamp overflow.
1391
1392 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1393 provides a substitute now.
1394
1395 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1396 since it guarantees struct timespec.
1397 (EMACS_TIME): Now struct timespec, so that we can support
1398 ns-resolution time stamps.
1399 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1400 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1401 (EMACS_USECS): Remove.
1402 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1403 so multiply the arg by 1000 before storing it.
1404 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1405 New macros.
1406 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1407 Port to ns-resolution time stamps.
1408 (EMACS_TIME_NEG_P): Remove; replaced by....
1409 (EMACS_TIME_SIGN): New macro.
1410 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1411 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1412 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1413 (make_timeval, make_lisp_time, decode_time_components): New decls.
1414 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1415 that it mishandled time_t overflow. You can't compare by subtracting!
1416 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1417 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1418
1419 * term.c: Include <sys/time.h>.
1420 (timeval_to_Time): New function, for proper overflow wraparound.
1421 (term_mouse_position, term_mouse_click): Use it.
1422
1423 * undo.c (record_first_change): Support higher-resolution time stamps
1424 in the undo buffer.
1425 (Fprimitive_undo): Use them when restoring time stamps.
1426
1427 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1428 (w32_get_internal_run_time):
1429 Port to higher-resolution Emacs time stamps.
1430 (ltime): Now accepts single 64-bit integer, as that's more convenient
1431 for callers.
1432
1433 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1434
1435 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1436 for compatibility with pselect. Support ns-resolution time stamps.
1437
1438 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1439
1440 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1441 Check for time stamp overflow, and support ns-resolution time stamps.
1442
1443 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1444 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1445 (timeval_subtract): Remove; no longer needed.
1446 (XTflash, XTring_bell, x_wait_for_event):
1447 Port to ns-resolution time stamps. Don't assume time_t is signed.
1448
b6a92dfe
CY
14492012-06-22 Chong Yidong <cyd@gnu.org>
1450
1451 * xdisp.c (x_consider_frame_title): Revert last change.
1452
d251c37c
EZ
14532012-06-22 Eli Zaretskii <eliz@gnu.org>
1454
1455 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1456 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1457 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1458 staticidx goes up to 1597 out of 1600 = 0x640.)
1459
f10deafb
PE
14602012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1463 Otherwise, the umask might be mistakenly 0 while handling input signals.
1464
ec6de1e2
SM
14652012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1466
1467 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1468
28be1ada
DA
14692012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1470
1471 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1472 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1473 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1474 access to `contents' member of Lisp_Vector objects with AREF and ASET
1475 where appropriate.
1476
c6bf3022
CY
14772012-06-19 Chong Yidong <cyd@gnu.org>
1478
1479 * frame.c (delete_frame): When selecting a frame on a different
1480 text terminal, do not alter the terminal's top-frame.
1481
1482 * xdisp.c (format_mode_line_unwind_data): Record the target
1483 frame's selected window and its terminal's top-frame.
1484 (unwind_format_mode_line): Restore them.
1485 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1486 Callers changed.
1487 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1488 since tty frames can be explicitly named.
1489 (prepare_menu_bars): Likewise.
1490
1491 * term.c (Ftty_top_frame): New function.
1492
defd4196
PE
14932012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Port byte-code-meter to modern targets.
1496 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1497 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1498 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1499 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1500 (METER_1, METER_2): Simplify.
1501
1053a871
SM
15022012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1503
1504 * data.c (Fdefalias): Return `symbol' (bug#11686).
1505
b7e8d081
MR
15062012-06-18 Martin Rudalics <rudalics@gmx.at>
1507
1508 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1509 gets killed during executing of this function (Bug#11665).
1510 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1511 (Vkill_buffer_query_functions): In doc-string say that functions
1512 run by this hook should not change the current buffer.
1513
7ea2b339
PE
15142012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 Fix recently-introduced process.c problems found by static checking.
1517 * process.c (write_queue_push, write_queue_pop, send_process):
1518 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1519 (write_queue_pop): Fix pointer signedness problem.
1520 (send_process): Remove unused local.
1521
96a313a1
CY
15222012-06-17 Chong Yidong <cyd@gnu.org>
1523
1524 * xdisp.c (redisplay_internal): No need to redisplay terminal
1525 frames that are not on top.
1526
20ca2e94
TN
15272012-06-17 Troels Nielsen <bn.troels@gmail.com>
1528
1529 * process.c (make_process): Initialize write_queue.
1530 (write_queue_push, write_queue_pop): New functions.
1531 (send_process): Use them to maintain correct ordering of process
1532 writes (Bug#10815).
1533
9a900ca9
PE
15342012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1535
310fbfa8
PE
1536 * lisp.h (eassert): Assume C89 or later.
1537 This removes the need for CHECK.
1538 (CHECK): Remove. Its comments about always evaluating its
1539 argument were confusing, as 'eassert' typically does not evaluate
1540 its argument.
1541
27bb1ca4
PE
1542 * coding.c (produce_chars): Use ptrdiff_t, not int.
1543
9a900ca9
PE
1544 * xterm.c (x_draw_underwave): Check for integer overflow.
1545 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1546
41b7f8bc 15472012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1548
1549 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1550 referenced (Bug#11583).
1551
9b0e3eba
AA
15522012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1553
1554 Implement wave-style variant of underlining.
1555 * dispextern.h (face_underline_type): New enum.
1556 (face): Add field for underline type.
1557 * nsterm.m (ns_draw_underwave): New function.
1558 (ns_draw_text_decoration): Use it.
1559 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1560 New functions.
1561 (x_draw_glyph_string): Use them.
1562 * xfaces.c (Qline, Qwave): New Lisp objects.
1563 (check_lface_attrs, merge_face_ref)
1053a871
SM
1564 (Finternal_set_lisp_face_attribute, realize_x_face):
1565 Handle wave-style underline face attributes.
9b0e3eba
AA
1566 * xterm.c (x_draw_underwave): New function.
1567 (x_draw_glyph_string): Use it.
1568
0fb52f11
JB
15692012-06-16 Juanma Barranquero <lekktu@gmail.com>
1570
1571 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1572 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1573 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1574 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1575 ($(BLD)/w32select.$(O)): Update dependencies.
1576
e5560ff7
AS
15772012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1578
1579 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1580 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1581 * character.c (_fetch_multibyte_char_p): Remove.
1582 * alloc.c: Include "character.h" before "buffer.h".
1583 * bidi.c: Likewise.
1584 * buffer.c: Likewise.
1585 * bytecode.c: Likewise.
1586 * callint.c: Likewise.
1587 * callproc.c: Likewise.
1588 * casefiddle.c: Likewise.
1589 * casetab.c: Likewise.
1590 * category.c: Likewise.
1591 * cmds.c: Likewise.
1592 * coding.c: Likewise.
1593 * composite.c: Likewise.
1594 * dired.c: Likewise.
1595 * dispnew.c: Likewise.
1596 * doc.c: Likewise.
1597 * dosfns.c: Likewise.
1598 * editfns.c: Likewise.
1599 * emacs.c: Likewise.
1600 * fileio.c: Likewise.
1601 * filelock.c: Likewise.
1602 * font.c: Likewise.
1603 * fontset.c: Likewise.
1604 * fringe.c: Likewise.
1605 * indent.c: Likewise.
1606 * insdel.c: Likewise.
1607 * intervals.c: Likewise.
1608 * keyboard.c: Likewise.
1609 * keymap.c: Likewise.
1610 * lread.c: Likewise.
1611 * macros.c: Likewise.
1612 * marker.c: Likewise.
1613 * minibuf.c: Likewise.
1614 * nsfns.m: Likewise.
1615 * nsmenu.m: Likewise.
1616 * print.c: Likewise.
1617 * process.c: Likewise.
1618 * regex.c: Likewise.
1619 * region-cache.c: Likewise.
1620 * search.c: Likewise.
1621 * syntax.c: Likewise.
1622 * term.c: Likewise.
1623 * textprop.c: Likewise.
1624 * undo.c: Likewise.
1625 * unexsol.c: Likewise.
1626 * w16select.c: Likewise.
1627 * w32fns.c: Likewise.
1628 * w32menu.c: Likewise.
1629 * window.c: Likewise.
1630 * xdisp.c: Likewise.
1631 * xfns.c: Likewise.
1632 * xmenu.c: Likewise.
1633 * xml.c: Likewise.
1634 * xselect.c: Likewise.
1635
2f07e6af
EZ
16362012-06-16 Eli Zaretskii <eliz@gnu.org>
1637
1053a871
SM
1638 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1639 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1640 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1641 row.
1642 (handle_face_prop): Use chunk-relative overlay string index when
1643 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1644 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1645 the rightmost. (Bug#11720)
2f07e6af 1646
29b83cec
AS
16472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1648
1649 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1650 (CATEGORY_MEMBER): Enforce 1/0 value.
1651 * category.c (_temp_category_set): Remove.
1652
4c5501e9
EZ
16532012-06-16 Eli Zaretskii <eliz@gnu.org>
1654
1655 * window.c (Fdelete_other_windows_internal)
1656 (Fdelete_window_internal): Don't access frame's mouse highlight
1657 info of the initial frame. (Bug#11677)
1658
2b570124
PE
16592012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1660
e93864f9
PE
1661 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1662 Assume USE_2_TAGS_FOR_INTS.
1663 (xreload): Adjust $tagmask width to match recent lisp.h change.
1664
2b570124
PE
1665 Simplify lisp.h in minor ways that should not affect code.
1666 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1667 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1668 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1669 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1670 (INTTYPEBITS): New macro, for clarity.
1671 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1672 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1673 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1674 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1675 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1676
81755f69
JB
16772012-06-13 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1680
16192a57
GM
16812012-06-13 Glenn Morris <rgm@gnu.org>
1682
1683 * s/bsd-common.h (BSD4_3):
1684 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1685
646b5f55
AS
16862012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1687
1688 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1689 instead of union.
1690 (XLI, XIL): Define.
1053a871
SM
1691 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1692 Use them.
1693 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1694 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1695 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1696 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1697 * frame.c (delete_frame): Remove outdated comment.
1698 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1699 USE_LISP_UNION_TYPE.
1700 (Fw32_unregister_hot_key): Likewise.
1701 (Fw32_toggle_lock_key): Likewise.
1702 * w32menu.c (add_menu_item): Likewise.
1703 (w32_menu_display_help): Use XIL instead of checking
1704 USE_LISP_UNION_TYPE.
1705 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1706 (init_heap): Likewise.
1707 * w32term.c (w32_read_socket): Update comment.
1708
1d3823c9
GM
17092012-06-13 Glenn Morris <rgm@gnu.org>
1710
c62ff706
GM
1711 * s/usg5-4-common.h, src/s/unixware.h:
1712 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1713
1d3823c9
GM
1714 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1715
bfe3e0a2
PE
17162012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1719 * alloc.c (make_number) [!defined make_number]:
1720 Remove, as lisp.h always defines this now.
1721 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1722 (roundup_size): Verify that it is a power of 2.
1723 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1724 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1725 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1726 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1727 USE_LSB_TAG now is always defined to be either 0 or 1.
1728 All uses changed.
1729 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1730 code works fine either way, and efficiency is not a concern here,
1731 as the union type is for debugging, not for production.
1732 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1733 Use an inline function on all platforms when using the union type,
1734 since this is simpler and 'static inline' can be used portably
1735 within Emacs now.
1736 (LISP_INITIALLY_ZERO): New macro.
1737 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1738 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1739
45fa9c0f
GM
17402012-06-12 Glenn Morris <rgm@gnu.org>
1741
b4492cba
GM
1742 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1743
1744 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1745
45fa9c0f
GM
1746 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1747 Move BROKEN_SIGIO to configure.
1748
1749 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1750 Move NO_TERMIO to configure.
1751
0e25d334
CY
17522012-06-12 Chong Yidong <cyd@gnu.org>
1753
1754 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1755 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1756 MagickExportImagePixels is undefined.
1757
43682bb6
PE
17582012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 * image.c (imagemagick_load_image): Remove unused label.
1761
a9be7d2b
GM
17622012-06-11 Glenn Morris <rgm@gnu.org>
1763
1764 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1765 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1766 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1767 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1768
3017f87f
SM
17692012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1770
1771 * alloc.c (make_byte_code): New function.
1772 (Fmake_byte_code): Use it. Don't purify here.
1773 * lread.c (read1): Use it as well to avoid extra allocation.
1774
1b9b4cf4
CY
17752012-06-11 Chong Yidong <cyd@gnu.org>
1776
1777 * image.c (imagemagick_load_image): Implement transparency.
1778
95988fcf
AS
17792012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1780
1781 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1782 account for preceding backslashes. (Bug#11663)
1783
cd4eb164
CY
17842012-06-09 Chong Yidong <cyd@gnu.org>
1785
1786 * term.c: Support italics in capable terminals (Bug#9652).
1787 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1788 (turn_on_face): Output using TS_enter_italic_mode if available.
1789 Don't handle unused blinking and alt-charset cases.
1790 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1791 and tty_alt_charset_p cases.
1792 (tty_capable_p, init_tty): Support italics.
1793
1794 * termchar.h (struct tty_display_info): Add field for italics.
1795 Remove unused blink field.
1796
1797 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1798 Handle slant.
1799
1800 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1801 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1802 tty_alt_charset_p. Add tty_italic_p.
1803
ff88beb8
MA
18042012-06-09 Michael Albinus <michael.albinus@gmx.de>
1805
1806 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1807 dbus_type_is_basic if available.
1808 (xd_extract_signed, xd_extract_unsigned): Rename from
1809 extract_signed and extract_unsigned, respectively. Adapt callers.
1810
44286096
CY
18112012-06-09 Chong Yidong <cyd@gnu.org>
1812
1682701f
CY
1813 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1814
44286096
CY
1815 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1816 case (Bug#9752).
1817
d86feb17
PE
18182012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * xdisp.c (vmessage): Treat frame message as multibyte.
1821 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1822 would generate the diagnostic "Making \302\247 buffer-local while
1823 let-bound!".
1824
d5c20fe8
EZ
18252012-06-08 Eli Zaretskii <eliz@gnu.org>
1826
1827 * dispnew.c (showing_window_margins_p): Undo last change, which
1828 was done due to an inadvertent commit.
1829 (adjust_frame_glyphs_for_frame_redisplay): Do call
1830 showing_window_margins_p.
1831
513749ee
SM
18322012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1833
1834 * eval.c (Fmake_var_non_special): New primitive.
1835 (syms_of_eval): Defsubr it.
1836 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1837
d4a8f5c1
JB
18382012-06-08 Juanma Barranquero <lekktu@gmail.com>
1839
1840 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1841 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1842
8bbbc977
EZ
18432012-06-08 Eli Zaretskii <eliz@gnu.org>
1844
1845 * alloc.c (allocate_vectorlike): Fix last change.
1846
f3372c87
DA
18472012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1848
1849 Block-based vector allocation of small vectors.
1850 * lisp.h (struct vectorlike_header): New field `nbytes',
1851 adjust comment accordingly.
1852 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1853 to denote vector blocks. Adjust users (live_vector_p,
1854 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1855 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1856 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1857 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1858 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1859 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1860 (roundup_size): New constant.
1861 (struct vector_block): New data type.
1862 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1863 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1864 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1865 (sweep_vectors): New functions.
1866 (allocate_vectorlike): Return `zero_vector' as the only vector of
1867 0 items. Allocate new vector from block if vector size is less than
1868 or equal to VBLOCK_BYTES_MAX.
1869 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1870 (init_alloc_once): Add call to init_vectors.
1871
4f18a4ed
SM
18722012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1873
1874 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1875
86f158bc
PE
18762012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1877
1878 * doprnt.c (doprnt): Truncate multibyte char correctly.
1879 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1880 would mishandle a string argument "Xc" if X was a multibyte
1881 character of length 2: it would truncate after X's first byte
1882 rather than including all of X.
1883
c5cfcbe0
CY
18842012-06-06 Chong Yidong <cyd@gnu.org>
1885
1886 * buffer.c (word_wrap): Doc fix.
1887
c05cf390
PE
18882012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1891
0c3461de
GM
18922012-06-03 Glenn Morris <rgm@gnu.org>
1893
1894 * xdisp.c (tool-bar-style): Doc fix.
1895
c71232db
UM
18962012-06-03 Ulrich Müller <ulm@gentoo.org>
1897
1898 * Makefile.in (PAXCTL): Define.
1899 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1900 binary via PaX flags if the paxctl utility is available.
1901 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1902 Restore PaX flags to their default. (Bug#11398)
1903
383f7350
CY
19042012-06-03 Chong Yidong <cyd@gnu.org>
1905
1906 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1907 buffer (Bug#11226).
1908
5f2c76c6
CY
19092012-06-03 Chong Yidong <cyd@gnu.org>
1910
1911 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1912 (note_mode_line_or_margin_highlight): If there is no help echo,
1913 use mode-line-default-help-echo. Handle the case where the mouse
1914 position is past the end of the mode line string.
1915
1916 * buffer.c (buffer_local_value_1): New function, split from
1917 Fbuffer_local_value; can return Qunbound.
1918 (Fbuffer_local_value): Use it.
1919 (Vmode_line_format): Docstring tweaks.
1920
773d47f6
PE
19212012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * sysdep.c (system_process_attributes): Improve comment.
1924
f2d6a3df
SM
19252012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1926
1927 * keyboard.c: Export real-this-command to Elisp.
1928 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1929 and DEFVAR it. Update all users.
1930
63810350
PE
19312012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1932
7bd5c1f4
PE
1933 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1934
63810350
PE
1935 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1936 Convert pctcpu and pctmem to Lisp float properly.
1937 Let the compiler fold better, as 100.0/0x8000 is exact.
1938
a2821611
AS
19392012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1940
1941 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1942 cons_block.
1943
5fceba1d
PE
19442012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1947
c98ff5dd
DA
19482012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1949
1950 For a 'struct window', replace some Lisp_Object fields to
1951 bitfields where appropriate, remove unused fields.
1952 * window.h (struct window): Remove unused 'last_mark_x' and
1953 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1954 change it's type from Lisp_Object to bitfield.
1955 Change type of 'force_start', 'optional_new_start',
1956 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1957 fields from Lisp_Object to bitfield. Adjust users accordingly.
1958
ca34e0be
PE
19592012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 Pacify gcc -Wdouble-precision when using Xaw.
1962 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1963 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1964 Use 'float' consistently, rather than 'float' in most places
1965 and 'double' in a couple of places.
1966
efc00ab1 19672012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1968
1969 * xdisp.c (handle_stop): Detect whether we have overlay strings
1970 loaded by testing it->current.overlay_string_index to be
1971 non-negative, instead of checking whether n_overlay_strings is
1972 positive. (Bug#11587)
1973
efc00ab1 19742012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1975
1976 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1977
1978 * doc.c (Fsubstitute_command_keys): Doc fix.
1979
efc00ab1 19802012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1981
1982 * search.c (search_buffer): Remove calls to
1983 r_alloc_inhibit_buffer_relocation, as it is now called by
1984 maybe_unify_char, which was the cause of relocation of buffer text
1985 in bug#11519.
1986
efc00ab1 19872012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1988
1989 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1990 for the duration of call to load_charset, to avoid problems with
1991 callers of maybe_unify_char that access buffer text through C
1992 pointers.
1993
1994 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1995 decrement the inhibition flag, instead of just setting or
1996 resetting it.
1997
ba93a187
PE
19982012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 Remove obsolete '#define static' cruft.
2001 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2002 This #undef was "temporary" in 2000; it is no longer needed
2003 now that '#define static' has gone away.
2004 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2005 (gray_bitmap_bits): Remove; no longer needed.
2006 All uses replaced with definiens.
2007 * xterm.c: Include "bitmaps/gray.xbm".
2008
9e4bf381
PE
20092012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 Clean up __executable_start, monstartup when --enable-profiling.
2012 The following changes affect the code only when profiling.
2013 * dispnew.c (__executable_start): Rename from safe_bcopy.
2014 Define only on platforms that need it.
2015 * emacs.c: Include <sys/gmon.h> when profiling.
2016 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2017 (__executable_start): Remove decl, since lisp.h does it now.
2018 (safe_bcopy): Remove decl; no longer has that name.
2019 (main): Coalesce #if into single bit of code, for simplicity.
2020 Cast pointers to uintptr_t, since standard libraries want integers
2021 and not pointers.
2022 * lisp.h (__executable_start): New decl.
2023
32d72c2f
GM
20242012-05-31 Glenn Morris <rgm@gnu.org>
2025
2026 * image.c (Fimagemagick_types): Doc fix.
2027
baac5bc7
JM
20282012-05-30 Jim Meyering <meyering@redhat.com>
2029
2030 * callproc.c (Fcall_process_region): Include directory component
2031 in mkstemp error message (Bug#11586).
2032
72cb32cf
PE
20332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 * alloc.c, lisp.h (make_pure_vector): Now static.
2036
61b108cc
SM
20372012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2038
2039 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2040 Move to byte-run.el.
2041 (Fautoload): Do the hash-doc more carefully.
2042 * data.c (Fdefalias): Purify definition, except for keymaps.
2043 (Qdefun): Move from eval.c.
2044 * lisp.h (Qdefun): Remove.
2045 * lread.c (read1): Tiny simplification.
2046
471fe23d
TN
20472012-05-29 Troels Nielsen <bn.troels@gmail.com>
2048
934f3f58 2049 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2050 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2051 Bug#9642, but explicitly check that the buffer the overlay would
2052 be moved to is live and rearrange lines to make sure that errors
2053 will not put the overlay in an inconsistent state.
2054 (Fdelete_overlay): Cosmetics.
2055
85d0efd1
EZ
20562012-05-28 Eli Zaretskii <eliz@gnu.org>
2057
2058 * w32term.c (my_bring_window_to_top): New function.
2059 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2060 could be different from the original one.
2061 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2062 (Bug#11513)
2063
2064 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2065 by calling BringWindowToTop.
2066
2067 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2068 (WM_EMACS_END): Increase by one.
2069
da92a98c
PE
20702012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2073 This avoids undefined behavior that might cause the eassert
2074 to not catch an out-of-range value.
2075
74d1f848
JB
20762012-05-28 Juanma Barranquero <lekktu@gmail.com>
2077
2078 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2079 Update dependencies.
2080
9e1a06fc
EZ
20812012-05-27 Eli Zaretskii <eliz@gnu.org>
2082
2083 * bidi.c (bidi_mirror_char): Fix last change.
2084
f3dd7312
AS
20852012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2086
2087 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2088 when referring to sectname field in printf format.
2089
81899c91
PE
20902012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2091
57b81a9f
PE
2092 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2093 Only r_alloc_inhibit_buffer_relocation needed to be added;
2094 the others were already declared.
2095
81899c91
PE
2096 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2097 before checking whether it's out of range. Put the check inside
2098 eassert. See
2099 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2100
33017faf 21012012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2102
2103 * callproc.c (Fcall_process): Restore a line that was accidentally
2104 commented out in the 2011-02-13 change (bug#11547).
2105
33017faf 21062012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2107
2108 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2109 defined on ralloc.c.
2110
2111 * buffer.c [REL_ALLOC]: Remove prototypes of
2112 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2113 they are now on lisp.h.
2114
2115 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2116
2117 * search.c (search_buffer): Use it to inhibit relocation of buffer
2118 text while re_search_2 is doing its job, because re_search_2 is
2119 passed C pointers to buffer text. (Bug#11519)
2120
23415acf
EZ
2121 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2122 Update value to 24.
2123
44e27368
EZ
2124 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2125 state after an additional call to move_it_in_display_line_to, keep
2126 the values of it->max_ascent and it->max_descent found for the
2127 entire line.
2128 (pos_visible_p): Revert the comparison against bottom_y to what it
2129 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2130 (Bug#11464)
2131
c1892f11
PE
21322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 Fix coding-related core dumps with gcc -ftrapv.
2135 The code was computing A - B, where A and B are pointers, and B is
2136 random garbage. This can lead to core dumps on platforms that
2137 have special pointer registers, and it also leads to core dumps on
2138 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2139 A - B only when B is initialized properly.
2140 * coding.c (coding_set_source, coding_set_destination): Return void.
2141 (coding_change_source, coding_change_destinations): New functions,
2142 with the old behaviors of coding_set_source and coding_set_destination.
2143 All callers that need an offset changed to use these new functions.
2144
eb7afdad
GM
21452012-05-26 Glenn Morris <rgm@gnu.org>
2146
2147 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2148
f12fdf02
EZ
21492012-05-26 Eli Zaretskii <eliz@gnu.org>
2150
53a63be6 2151 Extend mouse support on W32 text-mode console.
61b108cc
SM
2152 * xdisp.c (draw_row_with_mouse_face):
2153 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2154
eb3f6f01 2155 * w32console.c: Include window.h.
61b108cc
SM
2156 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2157 New functions.
eb3f6f01
EZ
2158 (initialize_w32_display): Initialize mouse-highlight data.
2159
53a63be6
EZ
2160 * w32inevt.c: Include termchar.h and window.h.
2161 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2162 moves, call note_mouse_highlight. If help_echo changed, call
2163 gen_help_event to produce help-echo message in the echo area.
2164 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2165 highlight info.
2166
4cfd81f6
PE
21672012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2168
2169 * lread.c (read1): Simplify slightly to avoid an overflow warning
2170 with GCC 4.7.0 on x86-64.
2171
4446092a
EZ
21722012-05-26 Eli Zaretskii <eliz@gnu.org>
2173
2174 * bidi.c (bidi_mirror_char): Revert last change: an int is
2175 definitely wide enough here.
2176
42b2a986 21772012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2178
42b2a986 2179 Fix integer width and related bugs (Bug#9874).
eb106a49 2180 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2181 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2182 (string_bytes, check_sblock, allocate_string_data):
2183 (compact_small_strings, Fmake_bool_vector, make_string)
2184 (make_unibyte_string, make_multibyte_string)
2185 (make_string_from_bytes, make_specified_string)
2186 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2187 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2188 (mark_vectorlike):
2189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2190 (allocate_pseudovector):
2191 Use int, not EMACS_INT, where int is wide enough.
2192 (inhibit_garbage_collection, Fgarbage_collect):
2193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2194 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2195 int might not be wide enough.
2196 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2197 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2198 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2199 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2200 (bidi_level_of_next_char, bidi_move_to_visually_next):
2201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2202 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2203 (Fkill_buffer, Fset_buffer_major_mode)
2204 (advance_to_char_boundary, Fbuffer_swap_text)
2205 (Fset_buffer_multibyte, overlays_at, overlays_in)
2206 (overlay_touches_p, struct sortvec, record_overlay_string)
2207 (overlay_strings, recenter_overlay_lists)
2208 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2209 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2210 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2211 (Foverlay_recenter, last_overlay_modification_hooks_used)
2212 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2214 (validate_region): Omit unnecessary test for b <= e,
2215 since that's guaranteed by the previous test.
d311d28c
PE
2216 (adjust_overlays_for_delete): Avoid pos + length overflow.
2217 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2218 (report_overlay_modification):
2219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2220 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2221 Omit pointer cast, which isn't needed anyway, and doesn't work
2222 after the EMACS_INT -> ptrdiff_t change.
02481186 2223 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2224 * buffer.h: Adjust decls to match defn changes elsewhere.
2225 (struct buffer_text, struct buffer):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2228 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2229 not int, to avoid needless 32-bit limit on 64-bit hosts.
2230 (exec_byte_code): Use tighter memory-full test, one that checks
2231 for alloca overflow. Don't compute the address of the object just
2232 before an array, as that's not portable. Use EMACS_INT, not
2233 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2234 * callint.c (Fcall_interactively):
2235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2236 * callproc.c (call_process_kill, Fcall_process):
2237 Don't assume pid_t fits into an Emacs fixnum.
2238 (call_process_cleanup, Fcall_process, child_setup):
2239 Don't assume pid_t fits into int.
2240 (call_process_cleanup, Fcall_process, delete_temp_file)
2241 (Fcall_process_region):
2242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2243 (Fcall_process): Simplify handling of volatile integers.
2244 Use int, not EMACS_INT, where int will do.
2245 * casefiddle.c (casify_object, casify_region, operate_on_word)
2246 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2248 (casify_object): Avoid integer overflow when overallocating buffer.
2249 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2250 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2251 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2252 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2253 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2254 integers are now checked earlier. All uses replaced with XINT.
2255 (ccl_driver):
2256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2257 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2258 (ccl_driver, Fregister_code_conversion_map):
2259 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2260 (resolve_symbol_ccl_program): Check that vector header is in range.
2261 Always copy the vector, so that we can check its contents reliably
2262 now rather than having to recheck each instruction as it's being
2263 executed. Check that vector words fit in 'int'.
2264 (ccl_get_compiled_code, Fregister_ccl_program)
2265 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2266 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2267 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2268 contents are in range.
2269 (Fccl_execute_on_string): Check that status is in range.
2270 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2271 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2272 Accept and return EMACS_INT, not int, because callers can pass values
2273 out of 'int' range.
2274 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2275 (multibyte_chars_in_text, parse_str_as_multibyte)
2276 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2277 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2278 (string_escape_byte8, Fget_byte):
2279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2280 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2281 avoid mishandling large integers.
2282 * character.h: Adjust decls to match defn changes elsewhere.
2283 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2284 (Ffind_charset_region):
2285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2286 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2287 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2288 Don't assume fixnum fits in int.
d311d28c
PE
2289 (load_charset_map_from_vector, Fmap_charset_chars):
2290 Remove now-unnecessary CHECK_NATNUMs.
2291 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2292 Don't rely on undefined behavior with signed left shift overflow.
2293 Don't assume unsigned int fits into fixnum, or that fixnum fits
2294 into unsigned int. Don't require max_code to be a valid fixnum;
2295 that's not true for gb10830 4-byte on a 32-bit host. Allow
2296 invalid_code to be a cons, for the same reason. Require code_offset
2297 to be a character. Avoid int overflow if max_char is close
2298 to INT_MAX.
2299 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2300 this is intended anyway and avoids some undefined behavior.
2301 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2302 INDEX_TO_CODE_POINT, as that's what it expects.
2303 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2304 * charset.h (DECODE_CHAR): Return int, not unsigned;
2305 this is what was intended anyway, and it avoids undefined behavior.
2306 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2307 integer-overflow issues.
2308 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2309 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2310 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2311 * chartab.c (Fmake_char_table, Fset_char_table_range)
2312 (uniprop_get_decoder, uniprop_get_encoder):
2313 Don't assume fixnum fits in int.
2314 * cmds.c (move_point): New function, that does the gist of
2315 Fforward_char and Fbackward_char, but does so while checking
2316 for integer overflow more accurately.
c96e5d6a 2317 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2318 (Fforward_line, Fend_of_line, internal_self_insert)
2319 (internal_self_insert):
2320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2321 Fix a FIXME, by checking for integer overflow when calculating
2322 target_clm and actual_clm.
2323 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2324 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2325 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2326 (coding_alloc_by_making_gap, alloc_destination)
2327 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2328 (encode_coding_utf_16, detect_coding_emacs_mule)
2329 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2330 (detect_coding_iso_2022, decode_coding_iso_2022)
2331 (encode_invocation_designation, encode_designation_at_bol)
2332 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2333 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2334 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2335 (encode_coding_ccl, encode_coding_raw_text)
2336 (detect_coding_charset, decode_coding_charset)
2337 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2338 (produce_composition, produce_charset, produce_annotation)
2339 (decode_coding, handle_composition_annotation)
2340 (handle_charset_annotation, consume_chars, decode_coding_gap)
2341 (decode_coding_object, encode_coding_object, detect_coding_system)
2342 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2343 (code_convert_region, code_convert_string)
8f50130c
PE
2344 (Fdefine_coding_system_internal)
2345 (coding_set_source, coding_set_destination):
d311d28c
PE
2346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2347 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2348 (Fdefine_coding_system_internal):
2349 Don't assume fixnums fit in int.
2350 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2351 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2352 (Funencodable_char_position, Fcheck_coding_systems_region)
2353 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2355 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2356 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2357 Don't access memory outside of the args array.
d311d28c 2358 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2359 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2360 result of ENCODE_CHAR.
d311d28c
PE
2361 * coding.h: Adjust decls to match defn changes elsewhere.
2362 (struct coding_system):
2363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2364 * composite.c (get_composition_id, find_composition)
2365 (run_composition_function, update_compositions)
2366 (compose_text, composition_gstring_put_cache)
2367 (composition_gstring_p, composition_gstring_width)
2368 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2369 (composition_compute_stop_pos, composition_reseat_it)
2370 (composition_update_it, struct position_record)
2371 (find_automatic_composition, composition_adjust_point)
2372 (Fcomposition_get_gstring, Ffind_composition_internal):
2373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2374 (update_compositions):
2375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2376 * composite.h: Adjust decls to match defn changes elsewhere.
2377 (struct composition):
2378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2379 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2380 Do not attempt to compute the address of the object just before a
2381 buffer; this is not portable.
2382 (Faref, Faset):
2383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2384 (Faset): Use int, not EMACS_INT, where int is wide enough.
2385 (Fstring_to_number): Don't assume fixnums fit in int.
2386 (Frem): Don't assume arg is nonnegative.
2387 * dbusbind.c (xd_append_arg): Check for integers out of range.
2388 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2389 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2390 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2391 (xd_get_connection_references): Return ptrdiff_t, not int.
2392 All uses changed.
2393 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2394 (xd_read_message_1):
2395 Use int, not unsigned, where the dbus API uses int.
2396 (Fdbus_message_internal): Don't overflow mtype.
2397 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2398 * dired.c (directory_files_internal, file_name_completion, scmp)
2399 (file_name_completion_stat):
2400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2401 (file_name_completion): Don't overflow matchcount.
2402 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2403 * dispextern.h: Adjust decls to match defn changes elsewhere.
2404 (struct text_pos, struct glyph, struct bidi_saved_info)
2405 (struct bidi_string_data, struct bidi_it, struct composition_it)
2406 (struct it):
2407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2408 (struct display_pos, struct composition_it, struct it):
2409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2410 * dispnew.c (increment_matrix_positions)
2411 (increment_row_positions, mode_line_string)
2412 (marginal_area_string):
2413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2414 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2416 (duration_to_sec_usec): New function, to check for overflow better.
2417 (Fsleep_for, sit_for): Use it.
2418 * doc.c (get_doc_string, store_function_docstring):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 (get_doc_string, Fsnarf_documentation):
2421 Use int, not EMACS_INT, where int is wide enough.
2422 (get_doc_string):
2423 Use SAFE_ALLOCA, not alloca.
2424 Check for overflow when converting EMACS_INT to off_t.
2425 * doprnt.c (doprnt):
2426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2427 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2428 Don't assume uid_t fits into fixnum.
2429 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2430 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2431 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2432 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2433 (general_insert_function)
2434 (Finsert_char, make_buffer_string, make_buffer_string_both)
2435 (update_buffer_properties, Fbuffer_substring)
2436 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2437 (Fsubst_char_in_region, check_translation)
2438 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2439 (transpose_markers, Ftranspose_regions):
2440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2441 (clip_to_bounds): Move to lisp.h as an inline function).
2442 (Fconstrain_to_field): Don't assume integers are nonnegative.
2443 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2444 (Fsubst_char_in_region, Fsave_restriction):
2445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2446 (Femacs_pid): Don't assume pid_t fits into fixnum.
2447 (lo_time): Use int, not EMACS_INT, when int suffices.
2448 (lisp_time_argument): Check for usec out of range.
2449 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2450 (Fuser_login_name, Fuser_full_name): Signal an error
2451 if a uid argument is out of range, rather than relying on
2452 undefined behavior.
c8d5c857
PE
2453 (Fformat_time_string): Remove now-unnecessary check.
2454 lisp_time_argument checks for out-of-range usec now.
243e0530 2455 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2456 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2457 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2458 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2459 (init_cmdargs, Fdump_emacs):
2460 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2461 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2462 the bottom (typically) 32 bits of the fixnum.
2463 * eval.c (specpdl_size, call_debugger):
2464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2465 (when_entered_debugger, Fbacktrace_debug):
2466 Don't assume fixnum can fit in int.
2467 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2468 the object just before a buffer; this is not portable.
2469 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2470 (grow_specpdl, unbind_to):
2471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2472 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2473 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2474 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2475 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2476 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2478 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2479 (a_write, e_write):
2480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2481 (Fcopy_file, non_regular_nbytes, read_non_regular)
2482 (Finsert_file_contents):
2483 Use int, not EMACS_INT, where int is wide enough.
2484 (READ_BUF_SIZE): Verify that it fits in int.
2485 (Finsert_file_contents): Check that counts are in proper range,
2486 rather than assuming fixnums fit into ptrdiff_t etc.
2487 Don't assume fixnums fit into int.
125b3835 2488 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2489 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2490 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2491 (string_char_to_byte, string_byte_to_char)
2492 (string_make_multibyte, string_to_multibyte)
2493 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2494 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2495 (substring_both, Fdelete, internal_equal, Ffillarray)
2496 (Fclear_string, mapcar1)
2497 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2498 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2499 (larger_vector, make_hash_table, maybe_resize_hash_table)
2500 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2501 (Fmaphash, secure_hash):
2502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2503 (concat): Check for string index and length overflow.
2504 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2505 (Frequire):
2506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2507 (larger_vector): New API (vec, incr_min, size_max) replaces old
2508 one (vec, new_size, init). This catches size overflow.
2509 INIT was removed because it was always Qnil.
2510 All callers changed.
2511 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2512 the upper bound on a hash table index size.
2513 (make_hash_table, maybe_resize_hash_table): Use it.
2514 (secure_hash): Computer start_byte and end_byte only after
2515 they're known to be in ptrdiff_t range.
2516 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2517 (Ffont_get_glyphs, Ffont_at):
2518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2519 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2520 (Flist_fonts, Fopen_font):
2521 Don't assume fixnum can fit in int.
2522 (check_gstring): Don't assume index can fit in int.
2523 (font_match_p): Check that fixnum is a character, not a nonnegative
2524 fixnum, since the later code needs to stuff it into an int.
2525 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2526 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2527 conversion overflow issues.
2528 (Fopen_font): Check for integer out of range.
2529 (Ffont_get_glyphs): Don't assume index can fit in int.
2530 * font.h: Adjust decls to match defn changes elsewhere.
2531 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2532 integer overflow.
2533 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2534 printmax_t, where ptrdiff_t is wide enough.
2535 (Finternal_char_font):
2536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2537 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2538 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2539 (Fset_frame_position, x_set_frame_parameters)
2540 (x_set_line_spacing, x_set_border_width)
2541 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2542 Check that fixnums are in proper range for system types.
2543 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2545 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2546 Use SAFE_ALLOCA_LISP, not alloca.
2547 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2548 intptr_t is wide enough.
2549 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2550 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2551 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2552 Check for fixnum out of range.
2553 * ftfont.c (ftfont_list): Don't assume index fits in int.
2554 Check that fixnums are in proper range for system types.
2555 (ftfont_shape_by_flt):
2556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2557 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2559 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2560 Check that fixnums are in proper range for system types.
2561 * gnutls.h: Adjust decls to match defn changes elsewhere.
2562 * gtkutil.c (xg_dialog_run):
2563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2564 (update_frame_tool_bar):
2565 Check that fixnums are in proper range for system types.
2566 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2567 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2568 * indent.c (last_known_column, last_known_column_point):
2569 (current_column_bol_cache):
2570 (skip_invisible, current_column, check_display_width):
2571 (check_display_width, scan_for_column, current_column_1)
2572 (Findent_to, Fcurrent_indentation, position_indentation)
2573 (indented_beyond_p, Fmove_to_column, compute_motion):
2574 (Fcompute_motion, Fvertical_motion):
2575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2576 (last_known_column_modified): Use EMACS_INT, not int.
2577 (check_display_width):
2578 (Fcompute_motion):
2579 Check that fixnums and floats are in proper range for system types.
2580 (compute_motion): Don't assume index or fixnum fits in int.
2581 (compute_motion, Fcompute_motion):
2582 Use int, not EMACS_INT, when it is wide enough.
2583 (vmotion): Omit local var start_hpos that is always 0; that way
2584 we don't need to worry about overflow in expressions involving it.
2585 * indent.h: Adjust decls to match defn changes elsewhere.
2586 (struct position):
2587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2588 Use int, not EMACS_INT, where int is wide enough.
2589 Remove unused members ovstring_chars_done and tab_offset;
2590 all uses removed.
2591 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2592 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2593 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2594 (make_gap, copy_text, insert, insert_and_inherit)
2595 (insert_before_markers, insert_before_markers_and_inherit)
2596 (insert_1, count_combining_before, count_combining_after)
2597 (insert_1_both, insert_from_string)
2598 (insert_from_string_before_markers, insert_from_string_1)
2599 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2600 (adjust_after_replace, adjust_after_insert, replace_range)
2601 (replace_range_2, del_range, del_range_1, del_range_byte)
2602 (del_range_both, del_range_2, modify_region)
2603 (prepare_to_modify_buffer, signal_before_change)
2604 (signal_after_change, Fcombine_after_change_execute):
2605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2606 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2607 (balance_an_interval, split_interval_right, split_interval_left)
2608 (find_interval, next_interval, update_interval)
2609 (adjust_intervals_for_insertion, delete_node, delete_interval)
2610 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2611 (static_offset_intervals, offset_intervals)
2612 (merge_interval_right, merge_interval_left, make_new_interval)
2613 (graft_intervals_into_buffer, temp_set_point_both)
2614 (temp_set_point, set_point, adjust_for_invis_intang)
2615 (set_point_both, move_if_not_intangible, get_property_and_range)
2616 (get_local_map, copy_intervals, copy_intervals_to_string)
2617 (compare_string_intervals, set_intervals_multibyte_1):
2618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2619 * intervals.h: Adjust decls to match defn changes elsewhere.
2620 (struct interval):
2621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2622 * keyboard.c (this_command_key_count, this_single_command_key_start)
2623 (before_command_key_count, before_command_echo_length, echo_now)
2624 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2625 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2626 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2627 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2629 (last_non_minibuf_size, last_point_position, echo_truncate)
2630 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2631 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2632 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2633 (stuff_buffered_input):
2634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2635 (last_auto_save, command_loop_1, read_char):
2636 Use EMACS_INT, not int, to avoid integer overflow.
2637 (record_char): Avoid overflow in total_keys computation.
2638 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2639 * keyboard.h: Adjust decls to match defn changes elsewhere.
2640 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2641 (Fkey_description, Fdescribe_vector, Flookup_key):
2642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2643 (click_position): New function, to check that positions are in range.
2644 (Fcurrent_active_maps):
2645 (describe_command):
2646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2647 (Faccessible_keymaps, Fkey_description):
2648 (preferred_sequence_p):
2649 Don't assume fixnum can fit into int.
2650 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2651 Check for integer overflow in size calculations.
2652 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2653 avoid mishandling large integers.
2654 * lisp.h: Adjust decls to match defn changes elsewhere.
2655 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2656 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2657 (struct Lisp_Marker):
2658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2659 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2660 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2661 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2662 All callers changed.
2663 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2664 Assume the arg has valid form, since it always does.
2665 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2666 unsigned integer system type.
2667 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2668 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2670 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2671 (duration_to_sec_usec): New decl.
2672 * lread.c (read_from_string_index, read_from_string_index_byte)
2673 (read_from_string_limit, readchar, unreadchar, openp)
2674 (read_internal_start, read1, oblookup):
2675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2676 (Fload, readevalloop, Feval_buffer, Feval_region):
2677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2678 (openp): Check for out-of-range argument to 'access'.
2679 (read1): Use int, not EMACS_INT, where int is wide enough.
2680 Don't assume fixnum fits into int.
6efdadfd 2681 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2682 (read_filtered_event): Use duration_to_sec_usec
2683 to do proper overflow checking on durations.
d311d28c
PE
2684 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2685 in size calculation.
2686 (Fexecute_kbd_macro):
2687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2688 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2689 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2690 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2691 (set_marker_both, set_marker_restricted_both, marker_position)
2692 (marker_byte_position, Fbuffer_has_markers_at):
2693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2694 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2695 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2696 It now merely ensures that the menu is large enough, without
2697 necessarily growing it, as this avoids some integer overflow issues.
2698 All callers changed.
2699 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2701 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2702 Use SAFE_ALLOCA_LISP, not alloca.
2703 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2704 to EMACS_INT. Check that fixnums are in proper range for system types.
2705 * minibuf.c (minibuf_prompt_width, string_to_object)
2706 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2707 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2709 (get_minibuffer, read_minibuf_unwind):
2710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2711 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2712 this simplifies overflow checking. All callers changed.
2713 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2714 (Ftest_completion):
2715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2716 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2717 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2718 Check that fixnums are in proper range for system types.
2719 (Fx_create_frame, Fx_show_tip):
2720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2721 * nsfont.m (ns_findfonts, nsfont_list_family):
2722 Don't assume fixnum fits in long.
2723 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2725 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2726 wide enough.
17fdb222 2727 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2729 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2730 (PRINTDECLARE, PRINTPREPARE):
2731 (strout, print_string):
2732 (print, print_preprocess, print_check_string_charset_prop)
2733 (print_object):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (PRINTDECLARE):
2736 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2739 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2740 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2741 (print_error_message): Use SAFE_ALLOCA, not alloca.
2742 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2743 (print_depth, new_backquote_output, print_number_index):
2744 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2745 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2746 (Fset_process_window_size, Fformat_network_address)
2747 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2748 (sigchld_handler):
d311d28c 2749 Check that fixnums are in proper range for system types.
d44287d4 2750 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2751 Check for process-ids out of pid_t range rather than relying on
2752 undefined behavior.
e4d81efc 2753 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2754 (Fformat_network_address, read_process_output, send_process)
2755 (Fprocess_send_region, status_notify):
2756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2757 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2758 (wait_reading_process_output, read_process_output, exec_sentinel):
2759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2760 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2761 (Faccept_process_output): Use duration_to_sec_usec to do proper
2762 overflow checking on durations.
dde14581
PE
2763 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2764 Don't assume pid_t fits in int.
02481186
PE
2765 * process.h (struct Lisp_Process): Members tick and update_tick
2766 are now of type EMACS_INT, not int.
b62b53e8
PE
2767 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2768 configured --with-wide-int.
d311d28c
PE
2769 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2770 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2771 * search.c (looking_at_1, string_match_1):
2772 (fast_string_match, fast_c_string_match_ignore_case)
2773 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2774 (scan_newline, find_before_next_newline, search_command)
2775 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2776 (set_search_regs, wordify):
2777 (Freplace_match):
2778 (Fmatch_data):
2779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2780 (string_match_1, search_buffer, set_search_regs):
2781 (Fmatch_data):
2782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2783 (wordify): Check for overflow in size calculation.
2784 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2785 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2786 Check that fixnums are in proper range for system types.
2787 * sound.c (struct sound_device)
2788 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2790 (Fplay_sound_internal):
2791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2792 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2793 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2794 (Fparse_partial_sexp):
2795 Don't assume fixnums can fit in int.
2796 (struct lisp_parse_state, find_start_pos, find_start_value)
2797 (find_start_value_byte, find_start_begv)
2798 (update_syntax_table, char_quoted, dec_bytepos)
2799 (find_defun_start, prev_char_comend_first, back_comment):
2800 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2801 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2803 (Finternal_describe_syntax_value): Check that match_lisp is a
2804 character, not an integer, since the code stuffs it into int.
2805 (scan_words, scan_sexps_forward):
2806 Check that fixnums are in proper range for system types.
2807 (Fforward_word):
2808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2809 (scan_sexps_forward):
2810 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2811 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2812 * syntax.h: Adjust decls to match defn changes elsewhere.
2813 (struct gl_state_s):
2814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2815 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2816 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2817 * sysdep.c (wait_for_termination_1, wait_for_termination)
2818 (interruptible_wait_for_termination, mkdir):
2819 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2820 (emacs_read, emacs_write):
2821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2822 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2823 and double all fit in int.
d311d28c
PE
2824 * term.c (set_tty_color_mode):
2825 Check that fixnums are in proper range for system types.
2826 * termhooks.h (struct input_event):
2827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2828 * textprop.c (validate_interval_range, interval_of)
2829 (Fadd_text_properties, set_text_properties_1)
2830 (Fremove_text_properties, Fremove_list_of_text_properties)
2831 (Ftext_property_any, Ftext_property_not_all)
2832 (copy_text_properties, text_property_list, extend_property_ranges)
2833 (verify_interval_modification):
2834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2835 (Fnext_single_char_property_change)
2836 (Fprevious_single_char_property_change):
2837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2838 (copy_text_properties):
2839 Check for integer overflow in index calculation.
d311d28c
PE
2840 * undo.c (last_boundary_position, record_point, record_insert)
2841 (record_delete, record_marker_adjustment, record_change)
2842 (record_property_change):
2843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2844 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2846 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2847 (Fx_hide_tip, Fx_file_dialog):
2848 * w32menu.c (set_frame_menubar):
2849 Use ptrdiff_t, not int, for consistency with rest of code.
2850 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2851 (select_window, Fdelete_other_windows_internal)
2852 (window_scroll_pixel_based, window_scroll_line_based)
2853 (Frecenter, Fset_window_configuration):
2854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2855 (Fset_window_hscroll, run_window_configuration_change_hook)
2856 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2857 (Fscroll_other_window, Frecenter):
d311d28c
PE
2858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2859 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2860 Don't assume fixnum fits in int.
2861 (Fset_window_scroll_bars):
2862 Check that fixnums are in proper range for system types.
2863 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2864 (string_pos, c_string_pos, number_of_chars, init_iterator)
2865 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2866 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2867 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2868 (face_before_or_after_it_pos, handle_invisible_prop)
2869 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2870 (display_prop_intangible_p, string_buffer_position_lim)
2871 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2872 (get_overlay_strings_1, get_overlay_strings)
2873 (iterate_out_of_display_property, forward_to_next_line_start)
2874 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2875 (get_next_display_element, set_iterator_to_next)
2876 (get_visually_first_element, compute_stop_pos_backwards)
2877 (handle_stop_backwards, next_element_from_buffer)
2878 (move_it_in_display_line_to, move_it_in_display_line)
2879 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2880 (add_to_log, message_dolog, message_log_check_duplicate)
2881 (message2, message2_nolog, message3, message3_nolog
2882 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2883 (current_message_1, truncate_echo_area, truncate_message_1)
2884 (set_message, set_message_1, store_mode_line_noprop)
2885 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2886 (text_outside_line_unchanged_p, check_point_in_composition)
2887 (reconsider_clip_changes)
2888 (redisplay_internal, set_cursor_from_row, try_scrolling)
2889 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2890 (redisplay_window, find_last_unchanged_at_beg_row)
2891 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2892 (trailing_whitespace_p, find_row_edges, display_line)
2893 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2894 (display_mode_element, store_mode_line_string)
2895 (pint2str, pint2hrstr, decode_mode_spec)
2896 (display_count_lines, display_string, draw_glyphs)
2897 (x_produce_glyphs, x_insert_glyphs)
2898 (rows_from_pos_range, mouse_face_from_buffer_pos)
2899 (fast_find_string_pos, mouse_face_from_string_pos)
2900 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2902 (safe_call, init_from_display_pos, handle_fontified_prop)
2903 (handle_single_display_spec, load_overlay_strings)
2904 (with_echo_area_buffer, setup_echo_area_for_printing)
2905 (display_echo_area, echo_area_display)
2906 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2907 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2908 (redisplay_window, dump_glyph_row, display_mode_line)
2909 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2910 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2912 (handle_single_display_spec, build_desired_tool_bar_string)
2913 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2914 (get_specified_cursor_type):
2915 Check that fixnums are in proper range for system types.
2916 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2917 (Flookup_image_map):
2918 Don't assume fixnums fit in int.
2919 (compare_overlay_entries):
2920 Avoid mishandling comparisons due to subtraction overflow.
2921 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2922 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2923 (handle_tool_bar_click):
2924 Use int, not unsigned, since we prefer signed and the signedness
2925 doesn't matter here.
2926 (get_next_display_element, next_element_from_display_vector):
2927 Use int, not EMACS_INT, when int is wide enough.
2928 (start_hourglass): Use duration_to_sec_usec to do proper
2929 overflow checking on durations.
2930 * xfaces.c (Fbitmap_spec_p):
2931 Check that fixnums are in proper range for system types.
2932 (compare_fonts_by_sort_order):
2933 Avoid mishandling comparisons due to subtraction overflow.
2934 (Fx_family_fonts, realize_basic_faces):
2935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2936 (Fx_family_fonts):
2937 Don't assume fixnum fits in int.
2938 Use SAFE_ALLOCA_LISP, not alloca.
2939 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2940 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2941 (face_at_buffer_position, face_for_overlay_string)
2942 (face_at_string_position):
2943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2944 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2945 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2946 (Fx_show_tip):
2947 Check that fixnums are in proper range for system types.
2948 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2949 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2951 (Fx_change_window_property): Don't assume fixnums fit in int.
2952 * xfont.c (xfont_chars_supported):
2953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2954 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2955 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2957 * xml.c (parse_region):
2958 * xrdb.c (magic_file_p):
2959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2960 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2961 (x_get_local_selection, x_reply_selection_request)
2962 (x_handle_selection_request, wait_for_property_change):
2963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2964 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2965 short is wide enough.
2966 (x_send_client_event): Don't assume fixnum fits in int.
2967 * xterm.c (x_x_to_emacs_modifiers):
2968 Don't assume EMACS_INT overflows nicely into int.
2969 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2970 may come from Lisp.
2971 (handle_one_xevent): NATNUMP can eval its arg twice.
2972 (x_connection_closed):
2973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2974 * xterm.h: Adjust decls to match defn changes elsewhere.
2975 (struct scroll_bar): Use struct vectorlike_header
2976 rather than rolling our own approximation.
2977 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2978
c6574eb5
GM
29792012-05-25 Glenn Morris <rgm@gnu.org>
2980
2981 * lisp.mk (lisp): Update for more files being compiled now.
2982
e8d32c7e
SM
29832012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2984
48def666
SM
2985 * lread.c: Remove `read_pure' which makes no difference.
2986 (read_pure): Remove var.
2987 (unreadpure): Remove function.
2988 (readevalloop): Don't call read_list with -1 flag.
2989 (read1, read_vector): Don't test read_pure any more.
2990 (read_list): Simplify.
2991
e8d32c7e
SM
2992 * fileio.c, character.h: Minor style tweaks.
2993
4b2addb7
DA
29942012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2995
2996 * window.h (clip_changed): Remove useless declaration.
2997
584461b2
JB
29982012-05-22 Juanma Barranquero <lekktu@gmail.com>
2999
3000 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3001 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3002
34374650
PE
30032012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3004
3005 Remove src/m/*.
3006 This directory predates autoconf and is no longer needed nowadays.
3007 Move its few remaining bits of functionality to where they're needed.
3008 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3009 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3010 * m/template.h: Remove.
3011 * Makefile.in (M_FILE): Remove. All uses removed.
3012 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3013 * lisp.h (USE_LSB_TAG):
3014 * mem-limits.h (EXCEEDS_LISP_PTR):
3015 Use VAL_MAX, not VALBITS, in #if.
3016 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3017 (EMACS_UINT): Define unconditionally now.
3018 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3019 (BITS_PER_EMACS_INT): New constants, replacing
3020 what used to be in config.h, but not useful in #if.
3021 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3022 define them any more.
3023 (VAL_MAX): New macro.
3024 (VALMASK): Use it.
3025 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3026 BITS_PER_EMACS_INT, in #if.
3027 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3028 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3029 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3030 * s/ms-w32.h (DATA_START):
3031 Move here from removed file m/intel386.h.
3032 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3033 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3034
261cb4bb
PE
30352012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3036
3037 Assume C89 or later.
3038 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3039 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3040 (xrealloc):
3041 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3042 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3043 * textprop.c, tparam.c (NULL): Remove.
3044 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3045 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3046 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3047 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3048 * xterm.c (input_signal_count): Assume volatile works.
3049
ff23cd9f
KB
30502012-05-21 Ken Brown <kbrown@cornell.edu>
3051
3052 * xgselect.c (xg_select): Fix first argument in call to 'select'
3053 (bug#11508).
3054
1b170bc6
KB
30552012-05-20 Ken Brown <kbrown@cornell.edu>
3056
3057 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3058 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3059
b2f4d39f
KB
30602012-05-19 Ken Brown <kbrown@cornell.edu>
3061
3062 * xfns.c (x_in_use): Remove `static' qualifier.
3063 * xterm.h (x_in_use): Declare.
3064 * xgselect.c: Include xterm.h.
3065 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3066 and `display_arg' (bug#9754).
3067
003fdae2
PE
30682012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3069
9232a6d9
PE
3070 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3071
003fdae2
PE
3072 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3073 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3074
784b56e2
EZ
30752012-05-18 Eli Zaretskii <eliz@gnu.org>
3076
3077 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3078
3079 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3080 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3081
3082 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3083 reference to image_cache->refcount.
3084 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3085
a0a79cde
JL
30862012-05-17 Juri Linkov <juri@jurta.org>
3087
3088 * search.c (Fword_search_regexp, Fword_search_backward)
3089 (Fword_search_forward, Fword_search_backward_lax)
3090 (Fword_search_forward_lax): Move functions to isearch.el
3091 (bug#10145, bug#11381).
3092
b0572523
PE
30932012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3094
3095 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3096
9660f5fc
SM
30972012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3098
3099 * lread.c (init_obarray): Declare Qt and Qnil as special.
3100
4374de83
GM
31012012-05-14 Glenn Morris <rgm@gnu.org>
3102
3103 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3104 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3105
dc44c39a
PE
31062012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3107
078c97cb
PE
3108 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3109
dc44c39a
PE
3110 * unexaix.c: Port to more-recent AIX compilers.
3111 (report_error, report_error_1, make_hdr, copy_sym)
3112 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3113 Make arguments const char *, not char *, to avoid violations of C
3114 standard and to fix some AIX warnings reported by Gilles Pion.
3115
e18afed7 31162012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3117
3118 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3119 already have overlays loaded.
3120 (handle_single_display_spec): Before returning without displaying
3121 fringe bitmap, synchronize the bidi iterator with the main display
3122 iterator, by calling iterate_out_of_display_property.
3123 (iterate_out_of_display_property): Detect buffer iteration by
3124 testing that it->string is a Lisp string.
3125 (get_next_display_element): When the current object is exhausted,
3126 and there's something on it->stack, call set_iterator_to_next to
3127 proceed with what's on the stack, instead of returning zero.
3128 (set_iterator_to_next): If called at the end of a Lisp string,
3129 proceed to consider_string_end without incrementing string
3130 position. Don't increment display vector index past the end of
3131 the display vector. (Bug#11417)
c8fb9dc6
EZ
3132 (pos_visible_p): Don't report a position visible when move_it_to
3133 stopped at the last line of window, which happens to be scanned
3134 backwards by the bidi iteration. (Bug#11464)
ac268e67 3135
e18afed7 31362012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3137
3138 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3139 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3140 are on a TTY, and thus unable to display on the fringes.
3141 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3142 so we need to signal to the caller that this is a "replacing"
3143 display spec. This fixes display when the spec is invalid or we
3144 are on a TTY.
3145
e18afed7 31462012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3147
3148 * unexaix.c (make_hdr): Fix typo in prototype.
3149 This bug broke the build on AIX. Problem reported by Gilles Pion.
3150
9d0a235a
MA
31512012-05-14 Michael Albinus <michael.albinus@gmx.de>
3152
3153 * keyboard.c (kbd_buffer_get_event): Read special events also in
3154 batch mode. (Bug#11415)
3155
9e6b06ed
GM
31562012-05-12 Glenn Morris <rgm@gnu.org>
3157
3158 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3159
c1a1d7a3
EZ
31602012-05-12 Eli Zaretskii <eliz@gnu.org>
3161
3162 * lisp.mk (lisp): Add newcomment.elc.
3163
3fe7cdc8
GM
31642012-05-12 Glenn Morris <rgm@gnu.org>
3165
3166 * Makefile.in (MKDIR_P): New, set by configure.
3167 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3168
53f7d2c0
PE
31692012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 Remove unused function hourglass_started.
3172 * dispextern.h (hourglass_started):
3173 * w32fns.c (hourglass_started):
3174 * xdisp.c (hourglass_started): Remove.
3175
75aafb17
JB
31762012-05-10 Juanma Barranquero <lekktu@gmail.com>
3177
3178 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3179 Update dependencies.
3180
12959e8e
PE
31812012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3182
97107e2e
PE
3183 * xgselect.c (xg_select): Put maxfds+1 into a var.
3184 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3185
12959e8e
PE
3186 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3187
836d29b3
DA
31882012-05-10 Dave Abrahams <dave@boostpro.com>
3189
3190 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3191 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3192
5cb67954
MA
31932012-05-09 Michael Albinus <michael.albinus@gmx.de>
3194
3195 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3196 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3197 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3198 Initialize xd_registered_buses.
3199
3478ec45
PE
32002012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3201
b263a6b0
PE
3202 Untag more efficiently if USE_LSB_TAG.
3203 This is based on a proposal by YAMAMOTO Mitsuharu in
3204 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3205 For an admittedly artificial (nth 8000 longlist) benchmark on
3206 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3207 Emacs's overall text size by 1%.
3208 * lisp.h (XUNTAG): New macro.
3209 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3210 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3211 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3212 * eval.c (Fautoload):
3213 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3214 * frame.h (XFRAME): Use XUNTAG.
3215
3478ec45
PE
3216 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3217 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3218 Remove unportable assumptions about print widths of types like
3219 dbus_uint32_t.
3220 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3221 intptr_t when converting between pointer and integer, to avoid GCC
3222 warnings about wrong width.
3223
666b903b 32242012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3225
3226 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3227 stack for each reader_thread, instead of defaulting to 8MB
3228 determined by the linker. This avoids failures in creating
3229 subprocesses on Windows 7, see the discussion in this thread:
3230 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3231
b120cc17
JC
32322012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3233
3234 Fix up display of the *Minibuf-0* buffer in the mini window.
3235 * keyboard.c (read_char): Don't clear the echo area if there's no
3236 message to clear.
3237 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3238 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3239
9a4b36f8
MA
32402012-05-07 Michael Albinus <michael.albinus@gmx.de>
3241
3242 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3243 batch mode.
3244
e5f9458f
CY
32452012-05-06 Chong Yidong <cyd@gnu.org>
3246
3247 * lisp.mk (lisp): Update.
3248
eceeb5fc 32492012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3250
3251 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3252
71873e2b
SM
32532012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3254
3255 * data.c (PUT_ERROR): New macro.
3256 (syms_of_data): Use it. Add new error type `user-error'.
3257 * undo.c (user_error): New function.
3258 (Fprimitive_undo): Use it.
3259 * print.c (print_error_message): Adjust print style for `user-error'.
3260 * keyboard.c (user_error): New function.
3261 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3262
ab0fa4e4
PE
32632012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 Do not limit current-time-string to years 1000..9999.
3266 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3267 (Fcurrent_time_string): Support any year that is supported by the
3268 underlying localtime representation. Don't use asctime, as it
3269 has undefined behavior for years outside the range -999..9999.
3270
7ed806a7
PE
32712012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 Fix race conditions involving setenv, gmtime, localtime, asctime.
3274 Without this fix, interrupts could mess up code that uses these
3275 nonreentrant functions, since setting TZ invalidates existing
3276 tm_zone or tzname values, and since most of these functions return
3277 pointers to static storage.
3278 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3279 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3280 Grow the critical sections to include not just invoking
3281 localtime/gmtime, but also accessing these functions' results
3282 including their tm_zone values if any, and any related TZ setting.
3283 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3284 so that the struct tm is saved in the critical section.
3285 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3286 motivated by the fact that memory allocation needs to be outside
3287 the critical section.
3288
0c16dfed
DA
32892012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3290
3291 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3292 with RESET_INTERVAL.
3293
3294 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3295 Remove duplicated buffer name initialization.
3296
3f83ace8
JM
32972012-05-02 Jim Meyering <jim@meyering.net>
3298
3299 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3300
c7b8541e
JM
3301 * xfns.c (x_window): Use xstrdup (Bug#11375).
3302
90207a15 33032012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3304
3305 * xdisp.c (pos_visible_p): If already at a newline from the
3306 display string before the 'while' loop, don't walk back the glyphs
3307 from it3.glyph_row. Solves assertion violation when the display
3308 string begins with a newline (egg.el). (Bug#11367)
3309
b593d6a9
AH
33102012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3311
3312 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3313 Move to simple.el.
3314
4737362e
GM
33152012-05-01 Glenn Morris <rgm@gnu.org>
3316
99cf43f9
GM
3317 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3318 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3319 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3320 All were removed before 23.1.
3321
9311dcff
GM
3322 * dispnew.c: Remove HAVE_LIBNCURSES test;
3323 it is always true on relevant platforms.
3324
4d5c6349
GM
3325 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3326 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3327
4737362e
GM
3328 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3329
74dd3a6b
AS
33302012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3331
3332 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3333 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3334 Remove.
3335
13c379ee
PE
33362012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3337
3338 Do not avoid creating empty evaporating overlays (Bug#9642).
3339 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3340 That is, do not delete an evaporating overlay if it becomes
3341 empty after its bounds are adjusted to fit within its buffer.
3342 This fix caused other problems, and I'm reverting it until we get
3343 to the bottom of them.
3344
a8e7d6d7 33452012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3346
3347 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3348
a8e7d6d7 33492012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3350
3351 * xdisp.c (pos_visible_p): If the window start position is beyond
3352 ZV, start the display from buffer beginning. Prevents assertion
3353 violation in init_iterator when the minibuffer window is scrolled
3354 via the scroll bar.
3355
3356 * window.c (window_scroll_pixel_based): Likewise.
3357
a8e7d6d7 33582012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3359
3360 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3361
a8e7d6d7 33622012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3363
3364 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3365 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3366
a8e7d6d7 33672012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3368
b593d6a9
AH
3369 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3370 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3371
1c6900d9
EZ
33722012-04-26 Eli Zaretskii <eliz@gnu.org>
3373
4c3fa1d9
EZ
3374 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3375 display element, check also the underlying string or buffer
3376 character. (Bug#11341)
3377
1c6900d9
EZ
3378 * w32menu.c: Include w32heap.h.
3379 (add_menu_item): If the call to AppendMenuW (via
3380 unicode_append_menu) fails, disable Unicode menus only if we are
3381 running on Windows 9X/Me.
3382
42bf8205
AS
33832012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3384
3385 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3386 (xgetint): Add missing shift for LSB tags.
3387
b1bac16e
MR
33882012-04-24 Martin Rudalics <rudalics@gmx.at>
3389
3390 * keyboard.c (read_char): Don't wipe echo area for select window
3391 events: These might get delayed via `mouse-autoselect-window'
3392 (Bug#11304).
3393
d69621cc
JB
33942012-04-24 Juanma Barranquero <lekktu@gmail.com>
3395
3396 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3397 manipulation of :loaded-from data.
3398
02fd101b
JB
33992012-04-23 Juanma Barranquero <lekktu@gmail.com>
3400
3401 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3402 now a cons (bug#11311).
3403
888bec30
PE
34042012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3405
89a438bd
PE
3406 Do not create empty overlays with the evaporate property (Bug#9642).
3407 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3408 if it becomes empty after its bounds are adjusted to fit within
3409 its buffer. Without this fix, in a nonempty buffer (let ((o
3410 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3411 yields an empty overlay that has the evaporate property, which is
3412 not supposed to happen.
3413
1068fe4d
PE
3414 Fix minor GTK3 problems found by static checking.
3415 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3416 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3417 (struct _EmacsFixedClass, emacs_fixed_get_type):
3418 Move decls here from emacsgtkfixed.h, since they needn't be public.
3419 (emacs_fixed_get_type): Now static.
3420 (emacs_fixed_class_init): Omit unused local.
3421 (emacs_fixed_child_type): Remove; unused.
3422 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3423 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3424 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3425 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3426 (EMACS_FIXED_GET_CLASS): Remove; unused.
3427 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3428
888bec30
PE
3429 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3430 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3431
de85e130
PE
34322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3433
d0baac98 3434 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3435 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3436 (__malloc_size_t, __malloc_ptrdiff_t):
3437 Remove. All uses removed, replaced by the definiens if needed,
3438 since we can assume C89 or better now.
3439 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3440 (protect_malloc_state, align, get_contiguous_space)
3441 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3442 (malloc_atfork_handler_child, malloc_enable_thread)
3443 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3444 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3445 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3446 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3447 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3448 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3449 Define using prototypes, not old style.
3450 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3451 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3452 (align): Don't assume that signed integer overflow wraps around.
3453 Omit unused local var.
3454 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3455 (_free_internal_nolock, memalign, mallochook, reallochook):
3456 Omit no-longer-needed casts.
3457 (valloc): Use getpagesize, not __getpagesize.
3458 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3459 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3460
de85e130
PE
3461 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3462
dcbf5805
MA
34632012-04-22 Michael Albinus <michael.albinus@gmx.de>
3464
3465 Move functions from C to Lisp. Make non-blocking method calls
3466 the default. Implement further D-Bus standard interfaces.
3467
3468 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3469 (QCdbus_request_name_allow_replacement)
3470 (QCdbus_request_name_replace_existing)
3471 (QCdbus_request_name_do_not_queue)
3472 (QCdbus_request_name_reply_primary_owner)
3473 (QCdbus_request_name_reply_in_queue)
3474 (QCdbus_request_name_reply_exists)
3475 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3476 (QCdbus_registered_serial, QCdbus_registered_method)
3477 (QCdbus_registered_signal): New Lisp objects.
3478 (XD_DEBUG_MESSAGE): Use sizeof.
3479 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3480 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3481 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3482 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3483 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3484 (xd_signature, xd_append_arg): Allow float for integer types.
3485 (xd_get_connection_references): New function.
b593d6a9
AH
3486 (xd_get_connection_address): Rename from xd_initialize.
3487 Return cached address.
dcbf5805
MA
3488 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3489 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3490 level.
3491 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3492 Return number of refcounts.
dcbf5805
MA
3493 (Fdbus_get_unique_name): Make stronger parameter check.
3494 (Fdbus_message_internal): New defun.
3495 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3496 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3497 (Fdbus_send_signal, Fdbus_register_service)
3498 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3499 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3500 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3501 (Vdbus_compiled_version, Vdbus_runtime_version)
3502 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3503 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3504 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3505 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3506 Adapt docstring.
dcbf5805 3507
52828e02
PE
35082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3509
da05bc4c
PE
3510 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3511 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3512 Do not assume ptrdiff_t is the same width as 'int'.
3513
52828e02
PE
3514 * alloc.c: Handle unusual debugging option combinations.
3515 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3516 since the two debugging options are incompatible.
3517 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3518 is defined.
3519 (mem_init, mem_insert, mem_insert_fixup):
3520 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3521 (NEED_MEM_INSERT): Remove; no longer needed.
3522
f01769f9
LL
35232012-04-22 Leo Liu <sdl.web@gmail.com>
3524
3525 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3526
5790543d
PE
35272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3528
3529 * sysdep.c [__FreeBSD__]: Minor cleanups.
3530 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3531 Use Emacs indenting style more consistently. Avoid some casts.
3532 Use 'double' consistently rather than mixing 'float' and 'double'.
3533
b91b7e4d
EW
35342012-04-21 Eduard Wiebe <usenet@pusto.de>
3535
b593d6a9
AH
3536 * sysdep.c (list_system_processes, system_process_attributes):
3537 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3538
6114eb15
AS
35392012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3540
3541 * lisp.mk (lisp): Update.
3542
2f38dff7
PE
35432012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3546 It is never used otherwise.
3547
4ae29f89
SM
35482012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3549
3550 * print.c (print_preprocess): Only check print_depth if print-circle
3551 is nil.
3552 (print_object): Check for cycles even when print-circle is nil and
3553 print-gensym is t, but only check print_depth if print-circle is nil.
3554
f30d612a
CY
35552012-04-20 Chong Yidong <cyd@gnu.org>
3556
3557 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3558 set the status to "failed" and ensure that sentinel is run.
3559
c07a4c0b 35602012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3561
3562 * process.c (Fset_process_inherit_coding_system_flag)
3563 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3564 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3565
c07a4c0b 35662012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3567
3568 * xdisp.c (string_buffer_position_lim): Limit starting position to
3569 BEGV.
3570 (set_cursor_from_row): If called for a mode-line or header-line
3571 row, return zero immediately.
3572 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3573 farther than the first row after the header line, if any.
3574 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3575 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3576
c07a4c0b 35772012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3578
4ae29f89
SM
3579 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3580 (bug#11238).
ad3a2b41 3581
c07a4c0b 35822012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35832012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3584
3585 configure: new option --enable-gcc-warnings (Bug#11207)
3586 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3587 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3588 (ALL_CFLAGS): Use new macros rather than old.
3589 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3590 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3591 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3592 -Wunused-result, -Wunused-variable. This should go away once
3593 the Emacs and Gnulib regex code is merged.
3594 (xmalloc, xrealloc): Now static.
3595
aba027e8
PE
35962012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 * dired.c (Fsystem_groups): Remove unused local.
3599
e5a36063
GM
36002012-04-17 Glenn Morris <rgm@gnu.org>
3601
3602 * dired.c (Fsystem_users): Doc fix.
3603
316411f0
DA
36042012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3605
3606 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3607 (syms_of_dired): Add them.
3608
9426aba4
PE
36092012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3610
b62a57be
PE
3611 Fix minor alloc.c problems found by static checking.
3612 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3613 New extern decls, to avoid calling undeclared functions.
3614 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3615 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3616 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3617 (NEED_MEM_INSERT): New macro.
3618 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3619 Remove one incorrect comment and fix another.
b62a57be 3620
3539f31f
PE
3621 Fix minor ralloc.c problems found by static checking.
3622 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3623 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3624 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3625 (r_alloc_sbrk): Now static.
3626
a041960a
PE
3627 Improve ralloc.c interface checking.
3628 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3629 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3630 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3631 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3632 [REL_ALLOC]: ... to here, to check interface.
3633 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3634 Remove decls. This fixes an "It stinks!".
3635
9426aba4
PE
3636 * alloc.c (which_symbols): Fix alignment issue / type clash.
3637
d55c12ed
AS
36382012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3641 (struct Lisp_Misc_Any): Likewise.
3642 (struct Lisp_Free): Likewise.
3643 * alloc.c (union aligned_Lisp_Symbol): Define.
3644 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3645 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3646 (union aligned_Lisp_Misc): Define.
3647 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3648 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3649 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3650
b948ce8b
PE
36512012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3654 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3655 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3656 * s/netbsd.h, s/sol2-6.h:
3657 Remove definition of GC_MARK_STACK, since the default now works.
3658 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3659 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3660 no longer the default.
3661 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3662
35dc09a1 36632012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3664
35dc09a1
GM
3665 * lread.c (lisp_file_lexically_bound_p):
3666 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3667
35dc09a1
GM
36682012-04-14 Eli Zaretskii <eliz@gnu.org>
3669
3670 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3671 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3672
36732012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3674
3675 * nsterm.m (constrainFrameRect): Always constrain when there is only
3676 one screen (Bug#10962).
3677
bcd86815
KB
36782012-04-13 Ken Brown <kbrown@cornell.edu>
3679
3680 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3681
c25df26e
RT
36822012-04-13 Reuben Thomas <rrt@sc3d.org>
3683
3684 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3685
0fc59f1e
DC
36862012-04-11 Daniel Colascione <dancol@dancol.org>
3687
3688 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3689 against is gone. It's better to use vfork now so that when Cygwin
3690 gains a new, working vfork, we use it automatically (bug#10398).
3691
de8c03dc
SM
36922012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3693
3694 * window.c (save_window_save): Obey window-point-insertion-type.
3695
2f097256
GM
36962012-04-11 Glenn Morris <rgm@gnu.org>
3697
3698 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3699
453b951e
SM
37002012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3701
3702 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3703
75f1671a 37042012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3705
3706 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3707 (force_quit_count): New var.
3708 (handle_interrupt): Use it.
3709
2a8ce227
JB
37102012-04-10 Juanma Barranquero <lekktu@gmail.com>
3711
3712 * w32.c (w32_delayed_load): Record the full path of the library
3713 being loaded (bug#10424).
3714
935396c0
GM
37152012-04-09 Glenn Morris <rgm@gnu.org>
3716
05920a43
GM
3717 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3718 not just in the obarray, before snarfing them. (Bug#11036)
3719
935396c0
GM
3720 * Makefile.in ($(leimdir)/leim-list.el):
3721 Pass EMACS rather than BUILT_EMACS.
3722
a18ecafa
TZ
37232012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3724
3725 * process.c (make_process):
3726 * process.h: Add integer `gnutls_handshakes_tried' member to
3727 process struct.
3728
6bbef4e5
JC
3729 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3730 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3731
3732 * gnutls.c (gnutls_log_function2i): Convenience log function.
3733 (emacs_gnutls_read): Use new log functions,
3734 `gnutls_handshakes_tried' process member, and
3735 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3736 attempts per process (connection).
3737
b4d3bc10
CY
37382012-04-09 Chong Yidong <cyd@gnu.org>
3739
3740 * eval.c (Fuser_variable_p, user_variable_p_eh)
3741 (lisp_indirect_variable): Functions deleted.
3742 (Fdefvar): Caller changed.
3743
3744 * callint.c (Finteractive, Fcall_interactively):
3745 * minibuf.c (Fread_variable): Callers changed.
3746
70f4d973
EZ
37472012-04-09 Eli Zaretskii <eliz@gnu.org>
3748
3749 * xdisp.c (set_cursor_from_row): If the display string appears in
3750 the buffer at position that is closer to point than the position
3751 after the display string, display the cursor on the first glyph of
3752 the display string. Fixes cursor display when a 'display' text
3753 property immediately follows invisible text. (Bug#11094)
3754
cb3c2e3e
PE
37552012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3756
3757 composite.c: use 'double' consistently
3758 * composite.c (get_composition_id): Use 'double' consistently
3759 instead of converting 'float' to 'double' and vice versa; this is
3760 easier to understand and avoids a GCC warning.
3761
fd06db5d
GM
37622012-04-09 Glenn Morris <rgm@gnu.org>
3763
50fe702a
GM
3764 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3765 preparation for dumping it with emacs. (Bug#4789)
3766 (leimdir): New variable.
3767 ($(leimdir)/leim-list.el): New rule.
3768 (emacs$(EXEEXT)): Depend on leim-list.el.
3769
fd06db5d
GM
3770 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3771 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3772 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3773
55c131ee
AS
37742012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3775
3776 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3777 proper alignment.
3778
9209588f
JB
37792012-04-07 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3782 Remove unused local variable.
3783
e3fb2efb
PE
37842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3785
3786 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3787 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3788 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3789 objects, as mark_maybe_pointer will catch them otherwise.
3790 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3791 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3792
b5385551
PE
37932012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3794
3795 Fix typo that broke non-Windows builds.
3796 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3797
9078ead6
EZ
37982012-04-07 Eli Zaretskii <eliz@gnu.org>
3799
3800 Support building on MS-Windows with libxml2.
3801
3802 * makefile.w32-in (OBJ2): Add xml.$(O).
3803 (GLOBAL_SOURCES): Add xml.c.
3804 ($(BLD)/xml.$(O)): New dependency list.
3805
3806 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3807 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3808 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3809 [!WINDOWSNT]: New macros.
3810 (init_libxml2_functions, libxml2_loaded_p): New functions.
3811 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3812 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3813 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3814 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3815 linked in).
6bbef4e5
JC
3816 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3817 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3818 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3819
3820 * emacs.c: Don't include libxml/parser.h.
3821 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3822 xmlCleanupParser directly.
3823
3824 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3825
3811fdf3
EZ
38262012-04-07 Eli Zaretskii <eliz@gnu.org>
3827
3828 * indent.c (Fvertical_motion): If there is a display string at
3829 point, use it.vpos to compute how many lines to backtrack after
3830 move_it_to point. (Bug#11133)
3831
2f8e16b2
EZ
38322012-04-06 Eli Zaretskii <eliz@gnu.org>
3833
3834 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3835 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3836 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3837 macros related to unification of CJK characters. For the details,
3838 see the discussion following the message here:
3839 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3840
3d439cd1
CY
38412012-04-04 Chong Yidong <cyd@gnu.org>
3842
3843 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3844
8bc53d00
EZ
38452012-04-01 Eli Zaretskii <eliz@gnu.org>
3846
3847 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3848 instead of alloca. (Bug#11138)
3849
3b0512a3
AS
38502012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3851
3852 * w32menu.c (is_simple_dialog): Properly check lisp types.
3853 (Bug#11141)
3854
8427ddd2
EZ
38552012-03-31 Eli Zaretskii <eliz@gnu.org>
3856
979022ef
EZ
3857 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3858 position we get to after a call to move_it_to fails the
3859 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3860 only if we wind up in a string from display property. (Bug#11063)
3861
a6b1c7cc
EZ
3862 * window.c (Fdelete_other_windows_internal): Invalidate the row
3863 and column information about mouse highlight, so that redisplay
3864 restores it after reallocating the glyph matrices. (Bug#7464)
3865
8427ddd2
EZ
3866 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3867 string comes from a `display' text property, use the buffer
3868 position of that property as if we actually saw that position in
3869 the row's glyphs.
697ba24b
EZ
3870 (move_it_by_lines): Remove the assertion that
3871 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3872 violated when there's a before-string at the beginning of a line.
3873 (Bug#11063)
8427ddd2 3874
65a0a738
EZ
38752012-03-30 Eli Zaretskii <eliz@gnu.org>
3876
3877 * xdisp.c (append_space_for_newline): If the default face was
3878 remapped, use the remapped face for the appended newline.
3879 (extend_face_to_end_of_line): Use the remapped default face for
3880 extending the face to the end of the line.
3881 (display_line): Call extend_face_to_end_of_line when the default
3882 face was remapped. (Bug#11068)
3883
581355cc
EZ
38842012-03-29 Eli Zaretskii <eliz@gnu.org>
3885
3886 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3887
e8fc049f
SM
38882012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3889
3890 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3891
4fb9a543
GM
38922012-03-27 Glenn Morris <rgm@gnu.org>
3893
3894 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3895 Doc fixes.
3896
679910f1
KH
38972012-03-26 Kenichi Handa <handa@m17n.org>
3898
3899 * dispextern.h (struct glyph): Fix previous change. Change the
3900 bit length of glyphless.ch to 25 (Bug#11082).
3901
90d49b7f
CY
39022012-03-26 Chong Yidong <cyd@gnu.org>
3903
3904 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3905 (command_loop_1): Use it; inhibit selection update for
3906 handle-select-window too (Bug#8996).
3907
f514f6f0
FP
39082012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3909
e8fc049f 3910 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3911
bf43fa51
KH
39122012-03-25 Kenichi Handa <handa@m17n.org>
3913
3914 * dispextern.h (struct glyph): Change the bit length of
3915 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3916
8a0c01dd
EZ
39172012-03-24 Eli Zaretskii <eliz@gnu.org>
3918
3919 * s/ms-w32.h (tzname): Include time.h before redirecting to
3920 _tzname. Fixes the MSVC build. (Bug#9960)
3921
7d1c3a76
AS
39222012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3923
8ed79523
AS
3924 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3925 characters.
3926
7d1c3a76
AS
3927 * xterm.c (XTread_socket): Only modify handling_signal if
3928 !SYNC_INPUT. (Bug#11080)
3929
e99a9b8b
EZ
39302012-03-23 Eli Zaretskii <eliz@gnu.org>
3931
3932 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3933 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3934 when fetching a multibyte character consumes more bytes than
3935 CHAR_BYTES returns, due to unification of CJK characters in
3936 string_char. (Bug#11073)
3937
5063c0e1
TN
39382012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3939
3940 * process.c (wait_reading_process_output): Handle pty disconnect
3941 by refraining from sending oneself a SIGCHLD (bug#10933).
3942
9f851fbd
CY
39432012-03-22 Chong Yidong <cyd@gnu.org>
3944
3945 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3946
5063c0e1 3947 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3948 Mark string as coming from a prefix property.
3949 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3950 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3951
fb5b8aca
CY
39522012-03-21 Chong Yidong <cyd@gnu.org>
3953
3954 * xfaces.c (Vface_remapping_alist): Doc fix.
3955
62356a1b
EZ
39562012-03-20 Eli Zaretskii <eliz@gnu.org>
3957
3958 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3959 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3960 Doc fixes.
62356a1b 3961
025de85b
CY
39622012-03-20 Chong Yidong <cyd@gnu.org>
3963
3964 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3965 to reflect default non-nil value of redisplay-dont-pause.
3966
4827f94e
KH
39672012-03-19 Kenichi Handa <handa@m17n.org>
3968
3969 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3970 it fit in a valid range (Bug#11003).
3971
e50a24a2
EZ
39722012-03-18 Eli Zaretskii <eliz@gnu.org>
3973
3974 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3975 that is not from display property, accept the row as a "cursor
3976 row" if one of the string's character has a non-nil `cursor'
3977 property. Fixes cursor positioning when there are newlines in
3978 overlay strings, e.g. in icomplete.el. (Bug#11035)
3979
9af5ed87
PE
39802012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3983
d1f55f16
CY
39842012-03-12 Chong Yidong <cyd@gnu.org>
3985
3986 * eval.c (inhibit_lisp_code): Rename from
3987 inhibit_window_configuration_change_hook; move from window.c.
3988
3989 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3990 * window.c (run_window_configuration_change_hook)
3991 (syms_of_window): Callers changed.
3992
66c5eebd
CY
39932012-03-11 Chong Yidong <cyd@gnu.org>
3994
413df973
CY
3995 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3996
66c5eebd
CY
3997 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3998
1de11f56
CY
39992012-03-10 Chong Yidong <cyd@gnu.org>
4000
4001 * frame.c (other_visible_frames): Don't assume the selected frame
4002 is visible (Bug#10955).
4003
cae07000
SM
40042012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4005
4006 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4007
89c94350
JD
40082012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4009
4010 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4011 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4012 zero (Bug#10954).
4013
999dd333
GM
40142012-03-03 Glenn Morris <rgm@gnu.org>
4015
01a6dcc8 4016 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4017
de0100f2
EZ
40182012-03-02 Eli Zaretskii <eliz@gnu.org>
4019
4020 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4021 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4022 (redisplay_window, next_element_from_string): Fix typos in
4023 comments.
3e441275
EZ
4024 (redisplay_window): Pass to move_it_vertically the margin in
4025 pixels, not in screen lines.
de0100f2 4026
96a72ee9
GM
40272012-03-02 Glenn Morris <rgm@gnu.org>
4028
4029 * buffer.c (buffer-list-update-hook): Doc fix.
4030
312508d7
EZ
40312012-02-29 Eli Zaretskii <eliz@gnu.org>
4032
4033 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4034 push_it before setting up the iterator for the first overlay
4035 string, even if we have an empty string loaded.
4036 (next_overlay_string): If there's an empty string on the iterator
4037 stack, pop the stack. (Bug#10903)
4038
27f3c637
PE
40392012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4042 Suggested by Stefan Monnier in
4043 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4044 * alloc.c (widen_to_Lisp_Object): New static function.
4045 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4046 and widening them to Lisp_Objects. This would work even if
4047 USE_LSB_TAG is defined and wide integers are used, which might
4048 happen in a future version of Emacs.
4049
3c9dfce6
CY
40502012-02-25 Chong Yidong <cyd@gnu.org>
4051
fa74b241
CY
4052 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4053 Doc fix.
4054
3c9dfce6
CY
4055 * xselect.c (Fx_selection_exists_p): Doc fix.
4056 (x_clipboard_manager_save_all): Print an informative message
4057 before saving to clipboard manager.
4058
9486df08
CY
40592012-02-24 Chong Yidong <cyd@gnu.org>
4060
4061 * keyboard.c (process_special_events): Handle all X selection
4062 requests in kbd_buffer, not just the next one (Bug#8869).
4063
f01d3321
CY
40642012-02-23 Chong Yidong <cyd@gnu.org>
4065
4066 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4067 call when setting menu-bar-lines and tool-bar-lines parameters.
4068 (unwind_create_frame_1): New helper function.
4069
4070 * window.c (inhibit_window_configuration_change_hook): New var.
4071 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4072 (syms_of_window): Initialize it.
f01d3321 4073
86b847b6
CY
40742012-02-22 Chong Yidong <cyd@gnu.org>
4075
4076 * xterm.c (x_draw_image_relief): Add missing type check for
4077 Vtool_bar_button_margin (Bug#10743).
4078
a59225b1
CY
40792012-02-21 Chong Yidong <cyd@gnu.org>
4080
4081 * fileio.c (Vfile_name_handler_alist): Doc fix.
4082
4083 * buffer.c (Fget_file_buffer): Protect against invalid file
4084 handler return value.
4085
310f5bd4
PE
40862012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4087
cb3a28cc
PE
4088 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4089 when computing $valmask.
4090
310f5bd4
PE
4091 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4092 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4093 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4094 It's useless in that case, and it can cause problems on hosts
4095 that allocate halves of EMACS_INT values separately.
4096 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4097 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4098 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4099 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4100 it avoids undefined behavior on hosts where shifting right by more
4101 than the word width has undefined behavior.
4102
2375c96a
CY
41032012-02-19 Chong Yidong <cyd@gnu.org>
4104
4105 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4106 (Funhandled_file_name_directory, Ffile_name_as_directory)
4107 (Fdirectory_file_name, Fexpand_file_name)
4108 (Fsubstitute_in_file_name): Protect against invalid file handler
4109 return values (Bug#10845).
4110
3eb49e71
EZ
41112012-02-18 Eli Zaretskii <eliz@gnu.org>
4112
4113 * .gdbinit (pitx): Fix incorrect references to fields of the
4114 iterator stack.
4115
7b926f3f
CY
41162012-02-17 Chong Yidong <cyd@gnu.org>
4117
4118 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4119
11273115
PE
41202012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4123 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4124
c3a70e2b
CY
41252012-02-15 Chong Yidong <cyd@gnu.org>
4126
4127 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4128 marked as special. Also, starting docstrings with * is obsolete.
4129
0ca43699
AS
41302012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4131
4132 * gnutls.c (emacs_gnutls_write): Fix last change.
4133
2e8f3c56
LI
41342012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4135
4136 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4137 send_process.
4138
af70074f
SM
41392012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4140
4141 * keymap.c (Fsingle_key_description): Handle char ranges.
4142
95986d52
CY
41432012-02-12 Chong Yidong <cyd@gnu.org>
4144
afd83bd1
CY
4145 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4146 as that creates a dangerous corner case.
4147
95986d52
CY
4148 * window.c (Fdelete_window_internal): Invalidate the mouse
4149 highlight (Bug#9904).
4150
bd7da63e
GM
41512012-02-12 Glenn Morris <rgm@gnu.org>
4152
4153 * xselect.c (Fx_own_selection_internal)
4154 (Fx_get_selection_internal, Fx_disown_selection_internal)
4155 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4156 * nsselect.m (Fx_own_selection_internal)
4157 (Fx_disown_selection_internal, Fx_selection_exists_p)
4158 (Fx_selection_owner_p, Fx_get_selection_internal):
4159 Sync docs and argument specs with the xselect.c versions.
4160
77abcbc2
LI
41612012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4162
4163 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4164
90b671e2
EZ
41652012-02-11 Eli Zaretskii <eliz@gnu.org>
4166
1c0ca0b7
EZ
4167 * w32select.c (Fx_selection_exists_p): Sync doc string and
4168 argument list with xselect.c. (Bug#10783)
4169
4170 * w16select.c (Fx_selection_exists_p): Sync doc string and
4171 argument list with xselect.c. (Bug#10783)
90b671e2 4172
49241268
GM
41732012-02-10 Glenn Morris <rgm@gnu.org>
4174
4175 * fns.c (Fsecure_hash): Doc fix.
4176
f998bbe7 41772012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4178
4179 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4180
0992bd9c
CY
41812012-02-07 Chong Yidong <cyd@gnu.org>
4182
4183 * buffer.c (Fbuffer_local_variables)
4184 (buffer_lisp_local_variables): Handle unbound vars correctly;
4185 don't let Qunbound leak into Lisp.
4186
af008560
GM
41872012-02-07 Glenn Morris <rgm@gnu.org>
4188
dd605cc4
GM
4189 * image.c (Fimagemagick_types): Doc fix.
4190
af008560
GM
4191 * image.c (imagemagick-render-type): Change it from a lisp object
4192 to an integer. Move the doc here from the lisp manual.
4193 Treat all values not equal to 0 the same.
4194
1449fa1d
CY
41952012-02-06 Chong Yidong <cyd@gnu.org>
4196
4197 * doc.c (store_function_docstring): Avoid applying docstring of
4198 alias to base function (Bug#2603).
4199
3723ec07
AS
42002012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4201
4202 * .gdbinit (pp1, pv1): Remove redundant defines.
4203 (pr): Use pp.
4204
79c1cc1e
CY
42052012-02-04 Chong Yidong <cyd@gnu.org>
4206
4207 * nsterm.m: Declare a global (Bug#10694).
4208
d7f29f8e
EZ
42092012-02-04 Eli Zaretskii <eliz@gnu.org>
4210
cae07000
SM
4211 * w32.c (get_emacs_configuration_options):
4212 Include --enable-checking, if specified, in the return value.
d7f29f8e 4213
3b95a6f9
MR
42142012-02-04 Martin Rudalics <rudalics@gmx.at>
4215
4216 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4217 after rounding frame sizes. (Bug#9723)
4218
d6fa96a6
EZ
42192012-02-04 Eli Zaretskii <eliz@gnu.org>
4220
4221 * keyboard.c (adjust_point_for_property): Don't position point
4222 before BEGV. (Bug#10696)
4223
df0b2940
PE
42242012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 Handle overflow when computing char display width (Bug#9496).
4227 * character.c (char_width): Return EMACS_INT, not int.
4228 (char_width, c_string_width): Check for overflow when
4229 computing the width; this is possible now that individual
4230 characters can have unbounded width. Problem introduced
4231 by merge from Emacs 23 on 2012-01-19.
4232
6bee44d6
MA
42332012-02-02 Michael Albinus <michael.albinus@gmx.de>
4234
4235 * dbusbind.c (Fdbus_register_method): Mention the return value
4236 :ignore in the docstring.
4237
44f92739
GM
42382012-02-02 Glenn Morris <rgm@gnu.org>
4239
1b9f60cc
GM
4240 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4241
44f92739
GM
4242 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4243 Unconditionally set to t. (Bug#10673)
4244 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4245 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4246 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4247
c5d3843c
KH
42482012-02-02 Kenichi Handa <handa@m17n.org>
4249
4250 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4251 0, do not call append_composite_glyph.
4252
159462d4 42532012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4254
4255 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4256 NULL (Bug#6988).
4257 (x_produce_glyphs): If the component of a composition is a null
4258 string, set it->pixel_width to 1 to avoid zero-width glyph.
4259
78cef877
EZ
42602012-02-01 Eli Zaretskii <eliz@gnu.org>
4261
4262 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4263 first 2 arguments are identical. This makes inserting large
4264 output from a subprocess an order of magnitude faster on
4265 MS-Windows, where all sbrk'ed memory is always contiguous.
4266
97897668
GM
42672012-01-31 Glenn Morris <rgm@gnu.org>
4268
4269 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4270 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4271 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4272
31fd3586
GM
42732012-01-29 Glenn Morris <rgm@gnu.org>
4274
4275 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4276
0e24a8b2
CY
42772012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4278
4279 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4280
cc0adcb0
CY
42812012-01-28 Chong Yidong <cyd@gnu.org>
4282
4283 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4284
acc28cb9
CY
42852012-01-26 Chong Yidong <cyd@gnu.org>
4286
9c69cfb7
CY
4287 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4288
acc28cb9
CY
4289 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4290 repeat counts (Bug#10507).
4291
48da7392
GM
42922012-01-26 Glenn Morris <rgm@gnu.org>
4293
4294 * lread.c (syms_of_lread): Doc fix.
4295
14af5f7f
CY
42962012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4297
4298 * coding.c (encode_designation_at_bol): Change return value to
4299 EMACS_INT.
4300
0b21c100
CY
43012012-01-25 Chong Yidong <cyd@gnu.org>
4302
4303 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4304
3c2907f7
CY
43052012-01-21 Chong Yidong <cyd@gnu.org>
4306
4307 * floatfns.c (Fcopysign): Make the second argument non-optional,
4308 since nil is not allowed anyway.
4309
959ad23f
AS
43102012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4311
4312 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4313 (send_process): Likewise.
4314
34a02f46
MR
43152012-01-19 Martin Rudalics <rudalics@gmx.at>
4316
4317 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4318 (Vwindow_persistent_parameters): Do not use Qstate.
4319 Rewrite doc-strings.
34a02f46 4320
1259009a 43212012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4322
4323 * character.c (char_width): New function.
70d4fdf6
GM
4324 (Fchar_width, c_string_width, lisp_string_width):
4325 Use char_width (Bug#9496).
25ed9e61 4326
6a6ee00d
MR
43272012-01-16 Martin Rudalics <rudalics@gmx.at>
4328
4329 * window.c (Vwindow_persistent_parameters): New variable.
4330 (Fset_window_configuration, save_window_save): Handle persistent
4331 window parameters.
4332
c85efaf7
EZ
43332012-01-14 Eli Zaretskii <eliz@gnu.org>
4334
4335 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4336 thrashing the stack of the thread. (Bug#9087)
4337
5944709e
PE
43382012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4339
4340 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4341
e71f5d99
EZ
43422012-01-11 Eli Zaretskii <eliz@gnu.org>
4343
4344 * xdisp.c (rows_from_pos_range): Handle the case where the
4345 highlight ends on a newline. (Bug#10464)
4346 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4347 he end column for display of highlight that ends on a newline
4348 before a R2L line.
4349
ce316182
GM
43502012-01-11 Glenn Morris <rgm@gnu.org>
4351
4352 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4353 from load-path also when installation-directory is nil. (Bug#10208)
4354
5b43da69
GM
43552012-01-10 Glenn Morris <rgm@gnu.org>
4356
74cc8ff9
GM
4357 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4358
7d8d6e4e
GM
4359 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4360 Update template values to be closer to their typical values these days.
5b43da69 4361
a0db8d43
EZ
43622012-01-09 Eli Zaretskii <eliz@gnu.org>
4363
4364 * xdisp.c (rows_from_pos_range): Accept additional argument
4365 DISP_STRING, and accept any glyph in a row whose object is that
4366 string as eligible for mouse highlight. Fixes mouse highlight of
4367 display strings from overlays. (Bug#10464)
4368
9a0115ab 43692012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4370
b9110d6a 4371 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4372 * fileio.c (auto_saving_dir_umask): New static var.
4373 (Fmake_directory_internal): Use it.
4374 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4375 creating the directory. The old code temporarily assigns
4376 too-generous permissions to the directory.
4377 (do_auto_save_eh): Clear it.
b9110d6a 4378 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4379 that the var is always cleared.
4380
6c1bd3f3
EZ
43812012-01-07 Eli Zaretskii <eliz@gnu.org>
4382
4383 * search.c (scan_buffer): Pass character positions to
4384 know_region_cache, not byte positions. (Bug#6540)
4385
069d2b50
L
43862012-01-07 LynX <_LynX@bk.ru> (tiny change)
4387
4388 * w32.c (sys_rename): Report EXDEV when rename of a directory
4389 fails because the target is on another logical disk. (Bug#10284)
4390
75bf0d33
DB
43912012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4392
4393 * xterm.c (x_embed_request_focus): New function.
4394
4395 * xterm.h: Add prototype.
4396
4397 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4398
1c6e5a32
GM
43992012-01-05 Glenn Morris <rgm@gnu.org>
4400
4401 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4402
651e947e
EZ
44032012-01-01 Eli Zaretskii <eliz@gnu.org>
4404
4405 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4406 Load gnutls_transport_set_lowat only if GnuTLS version is below
4407 2.11.1.
4408 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4409 GnuTLS versions below 2.11.1.
4410
3778cdd8
AL
44112011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4412
4413 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4414 to the doc string advising against its use for altering the way
4415 windows are scrolled.
4416
0e5317f7
KH
44172011-12-28 Kenichi Handa <handa@m17n.org>
4418
4419 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4420 coding-system ASCII compatible only when it does not produce BOM
4421 on encoding (Bug#10383).
4422
93d5ca1f
JD
44232011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4424
4425 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4426 can scroll.
4427 (create_and_show_popup_menu): Always use menu_position_func for
4428 Gtk3 (Bug#10361).
4429
ca22b785
AS
44302011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4431
4432 * callint.c (Fcall_interactively): Don't truncate prompt string.
4433
d048e1e6
EZ
44342011-12-23 Eli Zaretskii <eliz@gnu.org>
4435
4436 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4437 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4438 resumed from there (after widening). (Bug#10360)
d048e1e6 4439
5ccaba1f
JD
44402011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4441
4442 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4443
204ee57f
JD
44442011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4445
b81d40f0
JB
4446 * nsterm.m (x_free_frame_resources):
4447 Release f->output_data.ns->miniimage.
204ee57f
JD
4448 (ns_index_color): Fix indentation. Do not retain
4449 color_table->colors[i].
4450
4451 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4452 before returning.
4453
4454 * nsfns.m (x_set_background_color): Assign return value from
4455 ns_index_color to face-background instead of NSColor*.
4456 (ns_implicitly_set_icon_type): Fix indentation.
4457 Change assignment in for loop to comparison.
4458
4459 * emacs.c (ns_pool): New variable.
4460 (main): Assign ns_pool.
4461 (Fkill_emacs): Call ns_release_autorelease_pool.
4462
4463 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4464 autorelease fdesc, release fdAttrs and tdict.
4465 (ns_get_covering_families): Release charset.
4466 (ns_findfonts): Release NSFontDescriptor created with new.
4467 (ns_uni_to_glyphs): Fix indentation.
4468 (setString): Release attrStr before assigning new value.
4469
c803b2b7
JD
44702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4471
678f4426
JD
4472 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4473 and NS_IMPL_COCOA.
4474 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4475 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4476
cd394be1 44772011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4478
5fecd5fc
JD
4479 * nsterm.m (ns_term_init): Subscribe for notifications
4480 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4481 to method trackingNotification in EmacsMenu.
4482
4483 * nsmenu.m (trackingMenu): New variable.
3771cb17 4484 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4485 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4486 from Aquamacs (Bug#7030).
678f4426
JD
4487
44882011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4489
c803b2b7
JD
4490 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4491 (symbol_to_nsstring): Fix indentation.
4492 (ns_symbol_to_pb): New function.
cae07000
SM
4493 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4494 (Fns_rotate_cut_buffers_internal): Remove.
4495 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4496 Fns_store_cut_buffer_internal.
4497 (ns_get_foreign_selection, Fx_own_selection_internal)
4498 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4499 (Fns_get_selection_internal, Fns_store_selection_internal):
4500 Use ns_symbol_to_pb and check if return value is nil.
4501 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4502 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4503 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4504 renamed to Sns_store_selection_internal.
4505 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4506 and remove this function.
4507 (ns_handle_selection_clear): Remove, never used.
4508 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4509 here.
4510
e1b01a3a
KB
45112011-12-17 Ken Brown <kbrown@cornell.edu>
4512
4513 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4514 GID is unknown (Bug#10257).
4515
2adb6e85
PE
45162011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4517
4518 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4519 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4520 which caused a build failure on GNU/Linux IA-64. This problem was
4521 introduced by my 2011-10-07 patch.
4522
d1d7b339
JL
45232011-12-15 Juri Linkov <juri@jurta.org>
4524
4525 * image.c (imagemagick_error): New function. (Bug#10112)
4526 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4527 Use `imagemagick_error' where ImageMagick functions return
4528 `MagickFalse'.
4529 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4530 proper order.
4531
100d5755
KH
45322011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4533
4534 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4535 fill background (Bug#8992).
4536
454592a6
MR
45372011-12-13 Martin Rudalics <rudalics@gmx.at>
4538
4539 * window.c (Vwindow_combination_resize)
4540 (Vwindow_combination_limit): Use t instead of non-nil in
4541 doc-strings.
61d4b438
MR
4542 (Vrecenter_redisplay): Add first sentence of doc-string on
4543 separate line.
53524d93 4544 (Frecenter): Fix doc-string typo.
454592a6 4545
3633e3aa
KH
45462011-12-11 Kenichi Handa <handa@m17n.org>
4547
4548 * coding.c (Funencodable_char_position): Pay attention to the
4549 buffer text relocation (Bug#9389).
4550
7b9d523a 45512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4552
7b9d523a
JD
4553 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4554 gtk_init (Bug#10100).
4555
b73189c6
EZ
45562011-12-10 Eli Zaretskii <eliz@gnu.org>
4557
4558 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4559 IT->string is nil. (Bug#10263)
4560
f7dfe5d6
JD
45612011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4562
83faebb4
JD
4563 * nsterm.h (x_free_frame_resources): Declare.
4564
f7dfe5d6
JD
4565 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4566 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4567
4568 * nsterm.h (ns_get_defaults_value): Declare.
4569
4570 * nsterm.m (ns_default): Call ns_get_defaults_value.
4571
7cd4e72c
EZ
45722011-12-09 Eli Zaretskii <eliz@gnu.org>
4573
4574 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4575 (Bug#10170)
4576
b34d7317
YM
45772011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4578
4579 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4580 that where the value of an _OBJC_* symbol points to is in the .bss
4581 section (Bug#10240).
4582
76470ad1
KH
45832011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4584
4585 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4586 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4587
745fff94
KH
45882011-12-08 Kenichi Handa <handa@m17n.org>
4589
4590 * ftfont.c (get_adstyle_property): Fix previous change
4591 (Bug#10233).
4592
6e44397c
JB
45932011-12-07 Juanma Barranquero <lekktu@gmail.com>
4594
4595 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4596 dirs from the default value of EMACSLOADPATH (bug#10208).
4597
7efa6272
GM
45982011-12-07 Glenn Morris <rgm@gnu.org>
4599
4600 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4601 installation and source directories as well. (Bug#10208)
4602
f6fc4d87
CY
46032011-12-06 Chong Yidong <cyd@gnu.org>
4604
4605 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4606
2bf26180
GM
46072011-12-06 Glenn Morris <rgm@gnu.org>
4608
4609 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4610 as an error, not just -1. (Bug#10217)
4611
3a6ad4f0
CY
46122011-12-05 Chong Yidong <cyd@gnu.org>
4613
4614 * keyboard.c (process_special_events): New function.
4615 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4616
75a3b399
PE
46172011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 * coding.c (encode_designation_at_bol): Don't use uninitialized
4620 local variable (Bug#9318).
4621
c3c9e25e
KH
46222011-12-05 Kenichi Handa <handa@m17n.org>
4623
4624 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4625 return Qnil (Bug#8046, Bug#10193).
4626
5eb05ea3
KH
46272011-12-05 Kenichi Handa <handa@m17n.org>
4628
4629 * coding.c (encode_designation_at_bol): New args charbuf_end and
4630 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4631 (coding_set_source): Return how many bytes coding->source was
4632 relocated.
4633 (coding_set_destination): Return how many bytes
4634 coding->destination was relocated.
4635 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4636 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4637
46382011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4639
4640 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4641 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4642 macro (Bug#9318).
4643
46442011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4645
4646 The following changes are to fix Bug#9318.
4647
a79703f5 4648 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4649 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4650 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4651 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4652
7dbda6df
JB
46532011-12-05 Juanma Barranquero <lekktu@gmail.com>
4654
4655 * lisp.h (process_quit_flag): Fix external declaration.
4656
6d5eb5b0
SM
46572011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4658
4659 Don't macro-inline non-performance-critical code.
4660 * eval.c (process_quit_flag): New function.
4661 * lisp.h (QUIT): Use it.
4662
a0c3fad0
JD
46632011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4664
4665 * nsfns.m (get_geometry_from_preferences): New function.
4666 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4667
6c07aac2
AS
46682011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4669
4670 * emacs.c (Qkill_emacs): Define.
4671 (syms_of_emacs): Initialize it.
4672 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4673 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4674 (quit_throw_to_read_char): Add parameter `from_signal'.
4675 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4676 * lisp.h (QUIT): Call Fkill_emacs if requested.
4677
c052ead4
JD
46782011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4679
4680 * widget.c (update_wm_hints): Return if wmshell is null.
4681 (widget_update_wm_size_hints): New function.
4682
4683 * widget.h (widget_update_wm_size_hints): Declare.
4684
4685 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4686 widget_update_wm_size_hints (Bug#10104).
4687
9e49252b
EZ
46882011-12-03 Eli Zaretskii <eliz@gnu.org>
4689
4690 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4691 before a newline, prepare the bidi iterator for consuming the
4692 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4693 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4694
02b16839
JL
46952011-12-02 Juri Linkov <juri@jurta.org>
4696
4697 * search.c (Fword_search_regexp): New Lisp function created from
4698 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4699 (Fword_search_backward, Fword_search_forward)
4700 (Fword_search_backward_lax, Fword_search_forward_lax):
4701 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4702 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4703
0068070e
SM
47042011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4705
4706 * fileio.c (Finsert_file_contents): Move after-change-function call
4707 to before the "handled:" label, since all "goto handled" appear in
4708 cases where the *-change-functions have already been properly called
4709 (bug#10117).
4710
3360a3fc
AS
47112011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4712
4713 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4714 waiting for input. (Bug#10169)
4715
73d6c093
EZ
47162011-11-30 Eli Zaretskii <eliz@gnu.org>
4717
4718 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4719 verifies glyph row's hash code--we have just reallocated the
4720 glyphs, so their contents can be complete garbage. (Bug#10164)
4721
febe6bea
JB
47222011-11-30 Juanma Barranquero <lekktu@gmail.com>
4723
4724 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4725
801a4313
EZ
47262011-11-30 Eli Zaretskii <eliz@gnu.org>
4727
4728 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4729 attributes are tested _before_ calling verify_row_hash, to protect
4730 against GCC re-ordering of the tests. (Bug#10164)
4731
2b56b87e
JD
47322011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4733
4734 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4735
4736 * xterm.c (handle_one_xevent): Only set async_visible and friends
4737 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4738 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4739 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4740
dbf31225
PE
47412011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4742
4743 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4744 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4745 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4746 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4747 All uses changed to use GCPRO1 etc.
4748 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4749 Revert to old implementation (i.e., before 2011-03-11).
4750
1305621b
YM
47512011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4752
4753 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4754 of scroll runs so as to avoid assigning disabled bogus rows and
4755 unnecessary graphics copy operations.
4756
8c9afb46
EZ
47572011-11-27 Eli Zaretskii <eliz@gnu.org>
4758
4759 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4760 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4761 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4762 (malloc, free, realloc, calloc): Redirect to e_* only when
4763 compiling Emacs.
4764
4765 * lisp.h (GCTYPEBITS): Move before first use.
4766 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4767 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4768 this macro definition.
4769
4770 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4771 _MSC_VER.
4772
54e9e3bf
JD
47732011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4774
6d5eb5b0
SM
4775 * gtkutil.c (xg_create_frame_widgets):
4776 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4777 present with Gtk+ 2.0.
4778
83aca1cb
PE
47792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4780
4781 * fileio.c (Finsert_file_contents): Undo previous change; see
4782 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4783
5b76caa4
PE
47842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4785
4786 Rename locals to avoid shadowing.
4787 * fileio.c (Finsert_file_contents):
4788 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4789 * process.c (wait_reading_process_output):
4790 Rename inner 'proc' to 'p' to avoid shadowing.
4791 Indent for consistency with usual Emacs style.
4792
8c535114
EZ
47932011-11-25 Eli Zaretskii <eliz@gnu.org>
4794
4795 * xdisp.c (redisplay_window): If cursor row is not fully visible
4796 after recentering, and scroll-conservatively is set to a large
4797 number, scroll window by a few more lines to make the cursor fully
4798 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4799 (start_display): Don't move to the next line if the display should
4800 start at a newline that is part of a display vector or an overlay
4801 string. (Bug#10119)
8c535114 4802
fa4fdb5c
JL
48032011-11-24 Juri Linkov <juri@jurta.org>
4804
4805 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4806 after the `MagickPingImage' call. (Bug#10112)
4807
90ec88df
CY
48082011-11-23 Chong Yidong <cyd@gnu.org>
4809
4810 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4811
56e2e794
MR
48122011-11-23 Martin Rudalics <rudalics@gmx.at>
4813
4814 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4815 making another buffer current. (Bug#10114)
4816
b6e64c41
GM
48172011-11-23 Glenn Morris <rgm@gnu.org>
4818
4819 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4820
6b21de18
CY
48212011-11-23 Chong Yidong <cyd@gnu.org>
4822
4823 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4824 using it (Bug#5984).
4825
b12cd789
EZ
48262011-11-22 Eli Zaretskii <eliz@gnu.org>
4827
4828 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4829 and header-lines, as they don't have one computed for them.
4830 (Bug#10098)
4831
4832 * .gdbinit (prow): Make displayed values more self-explaining.
4833 Add row's hash code.
4834
261b6fd4
LMI
48352011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4836
4837 * process.c (wait_reading_process_output): Fix asynchrounous
4838 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4839 (wait_reading_process_output): Add comment and URL.
261b6fd4 4840
e7cfd277
JD
48412011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4842
4843 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4844
a9b9b7f5
CY
48452011-11-21 Chong Yidong <cyd@gnu.org>
4846
4847 * window.c (Fnext_window, Fprevious_window): Doc fix.
4848
b0d15b4f
SM
48492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4850
4851 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4852
fe7a3057
JB
48532011-11-20 Juanma Barranquero <lekktu@gmail.com>
4854
4855 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4856
d2999b1a
MR
48572011-11-20 Martin Rudalics <rudalics@gmx.at>
4858
4859 * window.c (Fset_window_combination_limit): Rename argument
4860 STATUS to LIMIT.
4861 (Vwindow_combination_limit): Remove "status" from doc-string.
4862
d5ff9cd0
AS
48632011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4864
4865 * m/ibms390.h: Remove.
4866 * m/ibms390x.h: Don't include "ibms390.h".
4867
a5bb9bd3
SM
48682011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4869
4870 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4871 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4872
cd1181db
JB
48732011-11-20 Juanma Barranquero <lekktu@gmail.com>
4874
4875 * casetab.c (Fset_case_table):
4876 * charset.c (Fcharset_after): Fix typos.
4877
615a3b8d 48782011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4879
17e845af
PE
4880 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4881 Otherwise, valgrind does not work on some platforms.
4882 Problem reported by Andreas Schwab in
6a0bf43d
PE
4883 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4884 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4885 is set, removing the need for VIRT_ADDRESS_VARIES.
4886 (PURE_P): Use a more-efficient implementation that needs just one
4887 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4888 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4889 to 4 (xorl, subq, cmpq, setbe).
4890 * alloc.c (pure): Always extern now, since that's the
4891 VIRT_ADDR_VARIES behavior.
4892 (PURE_POINTER_P): Use a single comparison, not two, for
4893 consistency with the new puresize.h.
4894 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4895 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4896 Remove VIRT_ADDR_VARIES no longer needed.
4897
f8fe6f96
EZ
48982011-11-19 Eli Zaretskii <eliz@gnu.org>
4899
4900 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4901 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4902 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4903 behave as if the cursor position were at the window margin.
4904
4905 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4906 and the cursor position is out of bounds, behave as if the cursor
4907 position were at the window margin. (Bug#10075)
4908
df05a53c
CY
49092011-11-18 Chong Yidong <cyd@gnu.org>
4910
4911 * window.c (Fwindow_combination_limit): Make first argument
4912 non-optional, since it is meaningless for live windows like the
4913 selected window.
61ccba97 4914
2071918e
DA
49152011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4916
4917 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4918
b50a28de
SM
49192011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4920
4921 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4922 (graft_intervals_into_buffer): Simplify.
4923
015137db
EZ
49242011-11-18 Eli Zaretskii <eliz@gnu.org>
4925
4926 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4927 hash values of the two rows.
4928 (copy_row_except_pointers): Preserve the used[] arrays and the
4929 hash values of the two rows. (Bug#10035)
68c95424 4930 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4931
4932 * xdisp.c (row_hash): New function, body extracted from
4933 compute_line_metrics.
4934 (compute_line_metrics): Call row_hash, instead of computing the
4935 hash code inline.
4936
4937 * dispnew.c (verify_row_hash): Call row_hash for computing the
4938 hash code of a row, instead of duplicating code from xdisp.c.
4939
4940 * dispextern.h (row_hash): Add prototype.
4941
a2addb04
TH
49422011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4943
4944 * frame.c (delete_frame): Don't delete the terminal when the last
4945 X frame is closed if emacs is built with GTK toolkit.
4946
df85d315
JB
49472011-11-17 Juanma Barranquero <lekktu@gmail.com>
4948
4949 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4950
a0c2d0ae
MR
49512011-11-17 Martin Rudalics <rudalics@gmx.at>
4952
4953 * window.c (Vwindow_splits): Rename to
4954 Vwindow_combination_resize. Suggested by Juri Linkov.
4955 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4956 of Vwindow_splits.
4957
58179cce
JB
49582011-11-16 Juanma Barranquero <lekktu@gmail.com>
4959
7877f373
JB
4960 * nsfns.m (Fns_font_name):
4961 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4962
b6f67890
MR
49632011-11-16 Martin Rudalics <rudalics@gmx.at>
4964
4965 * window.h (window): Rename slot "nest" to "combination_limit".
4966 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4967 (Fset_window_nest): Rename to Fset_window_combination_limit.
4968 (Vwindow_nest): Rename to Vwindow_combination_limit.
4969 (recombine_windows, make_parent_window, make_window)
4970 (Fsplit_window_internal, saved_window)
4971 (Fset_window_configuration, save_window_save): Rename all
4972 occurrences of window_nest to window_combination_limit.
4973
c7015153
JB
49742011-11-15 Juanma Barranquero <lekktu@gmail.com>
4975
4976 * image.c (imagemagick_load_image): Fix typo.
4977
322ad6ec
EZ
49782011-11-14 Eli Zaretskii <eliz@gnu.org>
4979
4980 * xdisp.c (display_line): Move the call to
4981 highlight_trailing_whitespace before the call to
4982 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4983 faces of all the glyphs to compute ROW's hash value.
4984 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4985
f067b8ec
JB
49862011-11-14 Juanma Barranquero <lekktu@gmail.com>
4987
4988 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4989 just return (bug#10044).
4990
1e5b2111
EZ
49912011-11-12 Eli Zaretskii <eliz@gnu.org>
4992
7ef3cbd5
EZ
4993 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4994 with user-defined heap size. Bump the default size of the temacs
4995 heap to 27MB, to avoid memory warning when running temacs.
4996 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4997
1e5b2111
EZ
4998 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4999 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5000 (verify_row_hash) [XASSERTS]: New function.
5001 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5002 that the hash value of glyph rows is correct.
1e5b2111 5003
89d61221
MR
50042011-11-12 Martin Rudalics <rudalics@gmx.at>
5005
5006 * window.h (window): Remove splits slot.
5007 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5008 (Fdelete_other_windows_internal, make_parent_window)
5009 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5010 (Fset_window_configuration, save_window_save): Don't deal with
5011 split status of windows.
5012 (saved_window): Remove splits slot.
5013 (Vwindow_splits): Rewrite doc-string.
5014
97f18cc8
JD
50152011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5016
5017 * xfns.c (unwind_create_frame):
5018 * nsfns.m (unwind_create_frame):
5019 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5020 Vframe_list (Bug#9999).
5021
22a648b4
DA
50222011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5023
0b381c7e 5024 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5025
659afede
KH
50262011-11-11 Kenichi Handa <handa@m17n.org>
5027
5028 * callproc.c (Fcall_process): Set the member dst_multibyte of
5029 process_coding.
5030
9ac0394b
KH
50312011-11-11 Johan Bockgård <bojohan@gnu.org>
5032
5033 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5034 avoid a crash (bug#9496).
5035
2fbdc249
CY
50362011-11-09 Chong Yidong <cyd@gnu.org>
5037
5038 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5039 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5040
ac6b1f81
PE
50412011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5042
5043 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5044
09db192c
PE
50452011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 Avoid some portability problems by eschewing 'extern inline' functions.
5048 The trivial performance wins aren't worth the portability hassles; see
5049 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5050 et seq.
5051 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5052 (window_box_width, window_box_left, window_box_left_offset)
5053 (window_box_right, window_box_right_offset): Undo previous change,
5054 by removing the "extern"s.
5055 * intervals.c (adjust_intervals_for_insertion)
5056 (adjust_intervals_for_deletion): Undo previous change,
5057 making these static again.
5058 (offset_intervals, temp_set_point_both, temp_set_point)
5059 (copy_intervals_to_string): No longer inline.
5060 * xdisp.c (window_text_bottom_y, window_box_width)
5061 (window_box_height, window_box_left_offset)
5062 (window_box_right_offset, window_box_left, window_box_right)
5063 (window_box): No longer inline.
5064
105216ed
CY
50652011-11-08 Chong Yidong <cyd@gnu.org>
5066
5067 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5068 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5069 Signal an error if not a live window.
105216ed
CY
5070 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5071 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5072
ae9e237f
JB
50732011-11-07 Juanma Barranquero <lekktu@gmail.com>
5074
5075 * lisp.h (syms_of_abbrev): Remove declaration.
5076 Reported by CHENG Gao <chenggao@royau.me>.
5077
c7aa8333
EZ
50782011-11-07 Eli Zaretskii <eliz@gnu.org>
5079
5080 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5081 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5082 of temacs in GUI mode.
5083
be7f5545
MR
50842011-11-07 Martin Rudalics <rudalics@gmx.at>
5085
5086 * window.h: Declare delete_all_child_windows instead of
5087 delete_all_subwindows.
5088 * window.c (Fwindow_nest, Fset_window_nest)
5089 (Fset_window_new_total, Fset_window_new_normal)
5090 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5091 (delete_all_subwindows): Rename to delete_all_child_windows.
5092 (Fdelete_other_windows_internal, Fset_window_configuration):
5093 Call delete_all_child_windows instead of delete_all_subwindows.
5094 * frame.c (delete_frame): Call delete_all_child_windows instead
5095 of delete_all_subwindows.
5096
ca78dc43
PE
50972011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5098
5099 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5100 This is also needed for porting to any host where GC_MARK_STACK is
5101 not GC_MAKE_GCPROS_NOOPS.
5102 (which_symbols): Use it.
5103
a0241d01
KH
51042011-11-07 Kenichi Handa <handa@m17n.org>
5105
5106 * coding.c (coding_set_destination): Check coding->src_pos only
5107 when coding->src_object is a buffer (bug#9910).
5108
5109 * process.c (send_process): Set the member src_multibyte of coding
5110 to 0 (bug#9911) when sending a unibyte text.
5111
5112 * callproc.c (Fcall_process): Set the member src_multibyte of
5113 process_coding to 0 (bug#9912).
5114
a64bfdfa 51152011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5116
5117 * xmenu.c (cleanup_widget_value_tree): New function.
5118 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5119 calling free_menubar_widget_value_tree directly (Bug#9830).
5120
cb41b32a
PE
51212011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5122
5123 Fix some portability problems with 'inline'.
5124 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5125 (window_box_width, window_box_left, window_box_left_offset)
5126 (window_box_right, window_box_right_offset): Declare extern.
5127 Otherwise, these inline functions do not conform to C99 and
5128 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5129 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5130 * intervals.c (adjust_intervals_for_insertion)
5131 (adjust_intervals_for_deletion): Now extern, because otherwise the
5132 extern inline functions 'offset_intervals' couldn't refer to it.
5133 (static_offset_intervals): Remove.
5134 (offset_intervals): Rewrite using the old contents of
5135 static_offset_intervals. The old version didn't conform to C99
5136 because an extern inline function contained a reference to an
5137 identifier with static linkage.
5138
b7041366
AS
51392011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5140
5141 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5142 GC.
5143
88a37c4d
EZ
51442011-11-06 Eli Zaretskii <eliz@gnu.org>
5145
5146 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5147 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5148 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5149 return Qleft_to_right.
5150
49745b39
CY
51512011-11-06 Chong Yidong <cyd@gnu.org>
5152
5153 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5154 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5155 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5156 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5157 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5158 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5159 (Fwindow_vscroll): Doc fix.
5160 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5161 argument, since it makes no sense to pass a live window and for
5162 consistency with window-child.
5163
1f05cd82
CS
51642011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5165
5166 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5167 support MSVC.
5168
22610910
JR
51692011-11-05 Jason Rumney <jasonr@gnu.org>
5170
5171 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5172 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5173 fonts (Bug#6029).
5174 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5175 bitwise arithmetic preventing use of unicode-sip and non-truetype
5176 opentype fonts.
5177
a06776b2
EZ
51782011-11-05 Eli Zaretskii <eliz@gnu.org>
5179
3ad924ba
EZ
5180 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5181 "emacs"-only part.
5182
a06776b2
EZ
5183 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5184 initialization code to keep similarity to xfns.c after changes
5185 from 2011-11-05.
5186
c9e7db78
JD
51872011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5188
a97f8f3f
JD
5189 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5190 (unwind_create_frame): New function (Bug#9943).
5191 (Fx_create_frame): Restructure code to be more similar to the one in
5192 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5193 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5194 Move terminal->reference_count++ just before making the frame official
5195 (Bug#9943).
5196
5197 * nsterm.m (x_free_frame_resources): New function.
5198 (x_destroy_window): Move code to x_free_frame_resources.
5199
c9e7db78 5200 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5201 (Fx_create_frame, x_create_tip_frame):
5202 Move terminal->reference_count++ just before making the frame
75f1671a 5203 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5204 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5205
a6fc3b5c
EZ
52062011-11-05 Eli Zaretskii <eliz@gnu.org>
5207
5208 Support MSVC build with newer versions of Visual Studio.
5209 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5210 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5211 nt/gmake.defs.
5212
5213 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5214 which are not supported by MSVC.
5215 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5216 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5217 bitfields.
5218 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5219 types in bitfields.
5220 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5221
5222 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5223
58179cce 52242011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5225
5226 Support MSVC build with newer versions of Visual Studio.
5227 * w32.c: Don't include w32api.h for MSVC.
5228 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5229
5230 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5231 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5232 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5233 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5234 e_* cousins.
5235 (alloca) [_MSC_VER]: Define to _alloca.
5236
5237 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5238
5239 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5240
a58c13ed
EZ
52412011-11-04 Eli Zaretskii <eliz@gnu.org>
5242
5243 * xdisp.c (note_mouse_highlight): If either of
5244 previous/next-single-property-change returns nil, treat that as
5245 the beginning or the end of the buffer. (Bug#9955)
5246
fe0b6370
JD
52472011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5248
a58c13ed 5249 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5250 label is not null (Bug#9951).
5251 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5252 may be NULL.
5253
89bd5ee1
EZ
52542011-11-04 Eli Zaretskii <eliz@gnu.org>
5255
5256 * window.c (Fwindow_body_size): Mention in the doc string that the
5257 return value is in frame's canonical units. (Bug#9949)
5258
84c3edb9
EZ
52592011-11-03 Eli Zaretskii <eliz@gnu.org>
5260
4e2fb5c7
EZ
5261 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5262
84c3edb9 5263 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5264 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5265 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5266
bc17a887
EZ
52672011-11-01 Eli Zaretskii <eliz@gnu.org>
5268
5269 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5270 Don't stop backward scan on the continuation glyph, even though
5271 its CHARPOS is positive.
6d5eb5b0
SM
5272 (mouse_face_from_buffer_pos, note_mouse_highlight):
5273 Rename cover_string to disp_string.
bc17a887 5274
4ee88440
MR
52752011-11-01 Martin Rudalics <rudalics@gmx.at>
5276
5277 * window.c (temp_output_buffer_show): Don't use
5278 Vtemp_buffer_show_specifiers.
5279 (Vtemp_buffer_show_specifiers): Remove unused variable.
5280
c2ff3c02
EZ
52812011-10-30 Eli Zaretskii <eliz@gnu.org>
5282
5283 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5284 past the beginning of the current glyph matrix.
5285
58179cce 52862011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5287
5288 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5289 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5290 HAVE_GTK3 (Bug#9869).
b77a6a7f 5291
3b574623
JD
5292 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5293 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5294
b77a6a7f
JD
5295 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5296
5297 * xterm.c: Declare x_handle_net_wm_state to return int.
5298 (handle_one_xevent): Check if we are iconified but don't have
5299 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5300 (get_current_wm_state): Return non-zero if not hidden,
5301 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5302 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5303 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5304 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5305
196e41e4
PE
53062011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5307
5308 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5309 so that this new function doesn't get optimized away by a
5310 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5311
021f2e1a
AS
53122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5313
5314 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5315
8b058d44
EZ
53162011-10-29 Eli Zaretskii <eliz@gnu.org>
5317
5318 Fix the `xbytecode' command.
5319 * .gdbinit (xprintbytestr): New command.
b50a28de 5320 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5321 (xbytecode): Print the byte-code string as well.
5322
4452fb80
EZ
53232011-10-29 Kim Storm <storm@cua.dk>
5324
8b058d44
EZ
5325 * alloc.c (which_symbols): New function.
5326
21b72067
AS
53272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5328
5329 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5330 line. (Bug#9903)
5331
83ed7b5c
GM
53322011-10-29 Glenn Morris <rgm@gnu.org>
5333
5334 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5335 Not clear what it was for, and it causes various bugs. (Bug#9839)
5336
5a7a728b
EZ
53372011-10-28 Eli Zaretskii <eliz@gnu.org>
5338
5339 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5340 possible random value that matches one of those tested as
5341 condition to clear the mouse face.
5342
d3d0842f
CY
53432011-10-28 Chong Yidong <cyd@gnu.org>
5344
5345 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5346
31b39d13
DN
53472011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5348
5349 * window.c (make_window): Initialize phys_cursor_on_p.
5350
9aba6043
SM
53512011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5352
5353 * lisp.h (struct Lisp_Symbol): Update comments.
5354
c20992f4
JB
53552011-10-28 Juanma Barranquero <lekktu@gmail.com>
5356
5357 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5358
db4f02f2
EZ
53592011-10-28 Eli Zaretskii <eliz@gnu.org>
5360
5361 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5362 <oslsachem@gmail.com> for helping to debug this.
5363
5364 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5365 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5366 (g_b_init_get_glyph_outline_w): New static variables.
5367 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5368 (GetGlyphOutlineW_Proc): New typedefs.
5369 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5370 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5371 New functions.
5372 (w32font_open_internal, compute_metrics):
5373 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5374 instead of calling the "wide" APIs directly.
5375
5376 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5377
5378 * w32.h (syms_of_w32font): Add prototype.
5379
87e68db4
JB
53802011-10-27 Juanma Barranquero <lekktu@gmail.com>
5381
5382 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5383 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5384 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5385 (Fmove_to_window_line): Doc fix.
5386
435c1d67
CY
53872011-10-27 Chong Yidong <cyd@gnu.org>
5388
5389 * process.c (make_process): Set gnutls_state to NULL.
5390
5391 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5392 non-NULL, regardless of GNUTLS_INITSTAGE.
5393 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5394 an error. Set process slots as soon as we allocate them.
5395
5396 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5397
9c6c6f49
CY
53982011-10-27 Chong Yidong <cyd@gnu.org>
5399
9aba6043
SM
5400 * gnutls.c (emacs_gnutls_deinit): New function.
5401 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5402 (Fgnutls_deinit, Fgnutls_boot): Use it.
5403
5404 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5405 (deactivate_process): Call emacs_gnutls_deinit.
5406
657d08d3
JB
54072011-10-27 Juanma Barranquero <lekktu@gmail.com>
5408
5409 * image.c (x_create_x_image_and_pixmap):
5410 * w32.c (sys_rename, w32_delayed_load):
5411 * w32font.c (fill_in_logfont):
5412 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5413
5430d399
JB
54142011-10-26 Juanma Barranquero <lekktu@gmail.com>
5415
5416 * w32fns.c (w32_default_color_map): New function,
5417 extracted from Fw32_default_color_map.
a7ef684b 5418 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5419
fe0055fa
PE
54202011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5421
5422 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5423
e6346438
SM
54242011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5425
5426 * keyboard.c (test_undefined): New function (bug#9751).
5427 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5428
e112cc37
ET
54292011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5430
5431 * sysdep.c (init_sys_modes): Fix the check for the controlling
5432 terminal (Bug#6649).
5433
7b5d6677
EZ
54342011-10-20 Eli Zaretskii <eliz@gnu.org>
5435
5436 * dispextern.h (struct bidi_it): New member next_en_type.
5437
5438 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5439 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5440 current character, check also for next_en_type being WEAK_EN.
5441 (bidi_resolve_weak): Don't enter the expensive loop if the current
5442 position is before next_en_pos. Record the bidi type of the first
5443 non-ET, non-BN character we find, in addition to its position.
5444 (bidi_level_of_next_char): Invalidate next_en_type when
5445 next_en_pos is over-stepped.
5446
7da0b018
PE
54472011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5448
5449 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5450 * editfns.c: Rewrite current-time-zone so that it invokes
5451 the equivalent of (format-time-string "%Z") to get the time zone name.
5452 This fixes a bug when the time zone name contains characters that
5453 need converting from the system time locale to Emacs internal format.
5454 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5455 that patch fixed format-time-string to do the conversion, but
5456 I forgot to fix current-time-zone.
5457 (format_time_string): New function, containing most of
5458 what Fformat_time_string used to contain.
5459 (Fformat_time_string): Rewrite in terms of format_time_string.
5460 This doesn't change this function's behavior.
5461 (current-time-zone): Rewrite to use format_time_string.
5462 This fixes the bug reported by Michael Schierl in
5463 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5464 Jason Rumney's 2007-06-07 change worked around this bug, but
5465 didn't fix it.
5466 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5467
8547b010
EZ
54682011-10-19 Eli Zaretskii <eliz@gnu.org>
5469
5470 * xdisp.c (start_display): If the character at POS is displayed
5471 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5472 (try_window_reusing_current_matrix): If a line ends in a display
5473 vector or the next line starts in a display vector, continue
5474 redrawing the window even though the character position of
5475 start_row was reached.
8547b010
EZ
5476 (Bug#9771, part 2)
5477
4e948d15
CY
54782011-10-18 Chong Yidong <cyd@gnu.org>
5479
5480 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5481 with nobreak-char-display too.
5482
4787455f
EZ
54832011-10-18 Eli Zaretskii <eliz@gnu.org>
5484
5485 Fix part 3 of bug#9771.
5486 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5487 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5488 non-neutral characters if the current character is a paragraph
5489 separator (a.k.a. Newline). This avoids running the same
5490 expensive loop twice, once when we consume the preceding newline
5491 and the other time when the line actually needs to be displayed.
5492 Avoid the loop when we see neutrals on the base embedding level
5493 following a character whose directionality is the same as the
5494 paragraph's. This avoids running the expensive loop when a line
5495 ends in a long sequence of neutrals, like control characters.
5496 Add assertion against STRONG_AL type. Slightly rearrange code
5497 that determines the type of a neutral given the first non-neutral
5498 that follows it.
5499 (bidi_level_of_next_char): Set next_en_pos to zero when
5500 invalidating its info.
5501
2c91f553
EZ
55022011-10-17 Eli Zaretskii <eliz@gnu.org>
5503
5504 * xdisp.c (push_display_prop): Determine whether to record string
5505 or buffer position by IT->string, not by IT->method. Allow
5506 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5507 (move_it_vertically_backward): Don't look for character position
5508 immediately after the newline when in a continuation line.
5509 (Bug#9771, part 1)
2c91f553 5510
c7b08b0d
MR
55112011-10-15 Martin Rudalics <rudalics@gmx.at>
5512
5513 * window.c (coordinates_in_window): Rewrite and delabelize
5514 vertical border check. (Bug#5357) (Bug#9618)
5515
6b02f655
SM
55162011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5517
5518 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5519 errors in XSetWindowBorder (bug#9310).
5520
81d40c92
DA
55212011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5522
5523 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5524 avoid crash when xmalloc overrun checking is enabled.
5525
d4172c3b
EZ
55262011-10-13 Eli Zaretskii <eliz@gnu.org>
5527
5528 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5529 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5530 cursor motion with <left> and <right> arrow keys.
5531
5532 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5533 some callers set that themselves.
5534
b00eea75
EZ
55352011-10-12 Eli Zaretskii <eliz@gnu.org>
5536
5537 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5538 display string and the previous row comes from the same string and
5539 is empty. (Bug#9739) (Bug#9738)
5540
8fe012c4
SM
55412011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5542
5543 * doc.c (get_doc_string): Encode file name (bug#9735).
5544
0074aef2
EZ
55452011-10-12 Eli Zaretskii <eliz@gnu.org>
5546
79beb178
EZ
5547 * bidi.c (bidi_level_of_next_char):
5548 * xdisp.c (get_visually_first_element): Remove old incorrect
5549 comments regarding the Unicode Line Separator character.
5550
0074aef2
EZ
5551 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5552
6e4b3fbe
DA
55532011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5554
5555 * alloc.c (Fgc_status): Do not access beyond zombies array
5556 boundary if nzombies > MAX_ZOMBIES.
5557 * alloc.c (dump_zombies): Add missing format specifier.
5558
0324f3af
PE
55592011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5560
b5525cac
PE
5561 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5562 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5563
0324f3af
PE
5564 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5565 Some packages use them to denote characters with modifiers.
5566
e9b5f888
AS
55672011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5568
5569 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5570 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5571 matching a pp-number. Rename parameter var to var1.
5572
127827c0
SM
55732011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5574
5575 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5576
c8fd3bd0
GM
55772011-10-08 Glenn Morris <rgm@gnu.org>
5578
5579 * callint.c (Fcall_interactively): Give a more explicit error for the
5580 'c' case with a non-character input. (Bug#8479)
5581
352ec8ff
EZ
55822011-10-08 Eli Zaretskii <eliz@gnu.org>
5583
03669ccb
EZ
5584 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5585 lines.
7061c986
EZ
5586 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5587 lines that are hscrolled on the left.
03669ccb 5588
352ec8ff
EZ
5589 * dispnew.c (buffer_posn_from_coords): Account for a possible
5590 presence of header-line. (Bug#4426)
5591
a66cfb1c
SM
55922011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5593
6b02f655
SM
5594 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5595 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5596
7c5ee88e
PE
55972011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5598
5599 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5600 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5601 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5602 this makes Emacs dump core during garbage collection on rare
5603 occasions. sizeof is obviously inferior to offsetof here, so
5604 stick with offsetof.
5605 (GC_POINTER_ALIGNMENT): New macro.
5606 (mark_memory): Omit 3rd (offset) arg; caller changed.
5607 Don't assume EMACS_INT alignment is the same as pointer alignment.
5608
df1bbe5b
SM
56092011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5610
5611 * keyboard.c (read_key_sequence_remapped): New var.
5612 (read_key_sequence): Compute remapping in the right buffer.
5613 (command_loop_1): Use read_key_sequence's remapping directly.
5614
51553db6
SM
56152011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5616
32c1fffd
SM
5617 * dired.c (file_name_completion): Don't expand file name.
5618 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5619 before checking file name handler.
5620
51553db6
SM
5621 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5622 they've been requested explicitly (bug#9591).
5623
b6bd1599 56242011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5625
5626 * keymap.c (Fsingle_key_description): Use make_specified_string
5627 instead of build_string to build string from push_key_description.
5628 (Bug#5193)
5629
f701dc2a
PE
56302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5631
4222c55d
PE
5632 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5633 This fixes a Y2038 bug on 64-bit hosts.
5634 * buffer.c (reset_buffer):
5635 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5636 (Fclear_buffer_auto_save_failure):
5637 Use 0, not -1, to represent an unset failure time, since time_t
5638 might not be signed.
5639
f701dc2a
PE
5640 Remove dependency on glibc malloc internals.
5641 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5642 Move back here from lisp.h, but with their new implementations.
5643 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5644 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5645 * charset.c (charset_table_init): New static var.
5646 (syms_of_charset): Use it instead of xmalloc. This removes a
5647 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5648 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5649 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5650 Move back to alloc.c.
5651 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5652 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5653
9ceebf39
JD
56542011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5655
5656 * nsterm.m (windowDidResize): Call x_set_window_size only when
5657 ns_in_resize is true. Otherwise set pixelwidth/height and
5658 call change_frame_size (Bug#9628).
5659
cb993c58
PE
56602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5661
3930c88b
PE
5662 Port --enable-checking=all to Fedora 14 x86-64.
5663 * charset.c (syms_of_charset): Also account for glibc malloc's
5664 internal overhead when calculating the initial malloc maximum.
5665
cb993c58
PE
5666 Port --enable-checking=all to Fedora 14 x86.
5667 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5668 Move to lisp.h.
5669 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5670 (overrun_check_realloc, overrun_check_free):
5671 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5672 That way, xmalloc returns a properly-aligned pointer even if
5673 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5674 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5675 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5676 into account when calculating the initial malloc maximum.
5677 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5678 Move here from alloc.c, so that charset.c can use it too.
5679 Properly align; the old code wasn't right for common 32-bit hosts
5680 when configured with --enable-checking=all.
5681 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5682 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5683
31bed486
EZ
56842011-09-29 Eli Zaretskii <eliz@gnu.org>
5685
04c70788 5686 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5687 use EDOM.
5688
fbcaa2f3
EZ
56892011-09-28 Eli Zaretskii <eliz@gnu.org>
5690
5691 * xdisp.c (compute_display_string_end): If there's no display
5692 string at CHARPOS, return -1.
5693
5694 * bidi.c (bidi_fetch_char): When compute_display_string_end
5695 returns a negative value, treat the character as a normal
5696 character not covered by a display string. (Bug#9624)
5697
a239d4e9
JB
56982011-09-28 Juanma Barranquero <lekktu@gmail.com>
5699
5700 * lread.c (Fread_from_string): Fix typo in docstring.
5701
88652fd5
EZ
57022011-09-27 Eli Zaretskii <eliz@gnu.org>
5703
5704 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5705 newline, reseat the iterator instead of bidi-iterating there one
5706 character at a time. (Bug#9610)
32c1fffd
SM
5707 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5708 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5709
ed497dd4
AS
57102011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5711
5712 * lread.c (readevalloop): Use correct code for NBSP.
5713 (read1): Likewise. (Bug#9608)
5714
b2bf61aa
MA
57152011-09-25 Michael Albinus <michael.albinus@gmx.de>
5716
5717 * dbusbind.c (Fdbus_register_signal): When service is not
5718 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5719
32bbb17c
GM
57202011-09-25 Glenn Morris <rgm@gnu.org>
5721
5722 * buffer.c (truncate-lines): Doc fix.
5723
94e0933e
CY
57242011-09-24 Chong Yidong <cyd@stupidchicken.com>
5725
5726 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5727 (Fset_window_next_buffers): Doc fix.
5728
cddde921
GM
57292011-09-24 Glenn Morris <rgm@gnu.org>
5730
5731 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5732
1260aef1
PE
57332011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5734
25b4bfa0
PE
5735 Fix minor problems found by static checking.
5736 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5737 * indent.c (Fvertical_motion): Fix == vs = typo.
5738
e3cbd34b
EZ
57392011-09-24 Eli Zaretskii <eliz@gnu.org>
5740
a66cfb1c
SM
5741 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5742 Default value is now t. Doc fix.
6bf7006f 5743
e3cbd34b 5744 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5745 logic when moving up, not only when moving down. Fix the
e3cbd34b 5746 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5747 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5748
5749 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5750 CHARPOS is covered by a display string which includes newlines.
5751 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5752 is covered by a display string with embedded newlines.
5753
a3de0cbd
MA
57542011-09-24 Michael Albinus <michael.albinus@gmx.de>
5755
5756 * dbusbind.c (Fdbus_register_signal): Add match rule to
5757 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5758 (Fdbus_register_method, Vdbus_registered_objects_table):
5759 Fix docstring.
a3de0cbd 5760
b260039d
JM
57612011-09-24 Jim Meyering <meyering@redhat.com>
5762
32c1fffd 5763 do not ignore write error for any output size
b260039d
JM
5764 The previous change was incomplete.
5765 While it makes emacs --batch detect the vast majority of stdout
5766 write failures, errors were still ignored whenever the output size is
5767 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5768 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5769 && echo FAIL: ignored write error
5770 FAIL: ignored write error
5771 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5772 && echo FAIL: ignored write error
5773 FAIL: ignored write error
5774 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5775
8eca8a7c
AS
57762011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5777
5778 * emacs.c (Fkill_emacs): In noninteractive mode exit
5779 non-successfully if a write error occurred on stdout. (Bug#9574)
5780
3341db62
EZ
57812011-09-21 Eli Zaretskii <eliz@gnu.org>
5782
5783 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5784 the xassert test.
5785
5786 * dispextern.h (struct it): Update the comment documenting what
5787 can it->OBJECT be.
5788
8c203dbf
EZ
57892011-09-20 Eli Zaretskii <eliz@gnu.org>
5790
5791 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5792 a display string, extend search for cursor position to end of row.
5793 (find_row_edges): If the row ends in a newline from a display
5794 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5795 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5796 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5797 non-empty line. Fixes confusing cursor motion with arrow keys at
5798 the beginning of a line that starts with whitespace.
8c203dbf 5799
a4824228
LMI
58002011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5801
5802 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5803 (bug#9493).
5804
33ed493b
CY
58052011-09-18 Chong Yidong <cyd@stupidchicken.com>
5806
5807 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5808 boolean (Bug#9154).
5809
56cd55c8
EZ
58102011-09-18 Eli Zaretskii <eliz@gnu.org>
5811
5812 * xdisp.c (display_line): Record maximum and minimum buffer
5813 positions even if no glyphs were produced (e.g., by a zero-width
5814 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5815 buffer positions that will be removed from the glyph row because
5816 they don't fit.
c02dcedf
EZ
5817 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5818 column is beyond frame width: don't subtract 1 "pixel" when
5819 computing width of the stretch.
3e62b7e0
EZ
5820 (reseat_at_next_visible_line_start): Undo the change made on
5821 2011-09-17 that saved paragraph information and restored it after
5822 the call to `reseat'. (Bug#9545)
56cd55c8 5823
5ed99d36 58242011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5825
5826 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5827 and turn window cursor on if cleared (Bug#9415).
5828
5ed99d36 58292011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5830
5831 * search.c (boyer_moore): Take unibyte characters from pattern
5832 literally. (Bug#9458)
5833
9bade7b2
EZ
58342011-09-18 Eli Zaretskii <eliz@gnu.org>
5835
5836 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5837
e5e9d610
PE
58382011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5839
87e4427a
PE
5840 Fix minor problem found by static checking.
5841 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5842 initialized, to pacify gcc -Wuninitialized.
5843
e5e9d610
PE
5844 * fileio.c: Report proper errno when syscall falls.
5845 (Finsert_file_contents): Save and restore errno,
5846 so that report_file_error outputs the correct diagnostic.
5847 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5848
a1674f0b
EZ
58492011-09-18 Eli Zaretskii <eliz@gnu.org>
5850
5851 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5852
fbfb6dd4
EZ
58532011-09-17 Eli Zaretskii <eliz@gnu.org>
5854
5855 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5856 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5857
bb187662
EZ
58582011-09-17 Eli Zaretskii <eliz@gnu.org>
5859
1137e8b8 5860 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5861 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5862
5863 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5864 (bidi_find_paragraph_start): Search back for paragraph beginning
5865 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5866 (bidi_move_to_visually_next): Only trigger paragraph-related
5867 computations when the last character is a newline or at EOB, not
5868 just any NEUTRAL_B. (Bug#9470)
5869
bb187662
EZ
5870 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5871 truncated lines if point is covered by a display string. (Bug#9524)
5872
2e621251
PE
58732011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5874
5875 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5876 (cons_to_x_long): New function.
5877 (lisp_data_to_selection_data): Use it. Correct the test for
5878 short-versus-long data; it was negated. Break out of vector
5879 loop, for efficiency, when a long datum is discovered.
5880
91a15bc6
SM
58812011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5882
5883 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5884
b41c3a35
EZ
58852011-09-16 Eli Zaretskii <eliz@gnu.org>
5886
5887 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5888 GCC PR/17406) by declaring this function with external scope.
5889
7812ba2d
PE
58902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5891
5892 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5893 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5894
cf7edc2a
AS
58952011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5896
5897 * editfns.c (Fformat): Correctly handle text properties on "%%".
5898
bd01620e
EZ
58992011-09-15 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xterm.c (x_draw_composite_glyph_string_foreground):
5902 * w32term.c (x_draw_composite_glyph_string_foreground):
5903 * term.c (encode_terminal_code):
5904 * composite.c (composition_update_it, get_composition_id):
5905 * xdisp.c (get_next_display_element)
5906 (fill_composite_glyph_string): Add comments about special meaning
5907 of TAB characters in a composition.
5908
a02719a3
PE
59092011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5910
5911 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5912 This occurs when processing a multibyte format.
5913 Problem reported by Wolfgang Jenker.
a02719a3 5914
72589a3c
JB
59152011-09-15 Johan Bockgård <bojohan@gnu.org>
5916
5917 * xdisp.c (try_cursor_movement): Only check for exact match if
5918 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5919
1c14176c
PE
59202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5921
5922 Remove unused external symbols.
5923 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5924 * xdisp.c (calc_pixel_width_or_height): Now static.
5925 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5926 * indent.c (check_display_width):
5927 * w32term.c: Fix comment to match code.
5928 * xterm.c, xterm.h (x_catching_errors): Remove.
5929
d2eea5b5
PE
59302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * xselect.c: Use signed conversions more consistently (Bug#9498).
5933 (selection_data_to_lisp_data): Assume incoming selection data are
5934 signed integers, not unsigned. This is to be consistent with
5935 outgoing selection data, which was modified to use signed integers
5936 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5937 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5938 expects long, not unsigned long.
5939
46888499
EZ
59402011-09-14 Eli Zaretskii <eliz@gnu.org>
5941
5942 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5943 computation of loop end. Reported by Johan Bockgård
5944 <bojohan@gnu.org>.
5945
ef8ef9fb
CY
59462011-09-13 Chong Yidong <cyd@stupidchicken.com>
5947
5948 * frame.c (Fother_visible_frames_p): Function deleted.
5949
fa819fed
EZ
59502011-09-12 Eli Zaretskii <eliz@gnu.org>
5951
5952 * indent.c (compute_motion): Process display vector front to back
5953 rather than the other way around. (Bug#2496)
5954
2ba8e008
SM
59552011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5956
5957 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5958
20f53c69
CY
59592011-09-11 Chong Yidong <cyd@stupidchicken.com>
5960
5961 * minibuf.c (Fread_from_minibuffer): Doc fix.
5962
d562d7a4
EZ
59632011-09-11 Eli Zaretskii <eliz@gnu.org>
5964
5965 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5966 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5967
1c4d7f3d
LMI
59682011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5969
5970 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5971 value for non-existent files.
5972
b885bf36
EZ
59732011-09-11 Eli Zaretskii <eliz@gnu.org>
5974
5975 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5976 set its "size" to -1. This will set the modtime_size field of
5977 the corresponding buffer to -1, which is what
5978 verify-visited-file-modtime expects for files that do not exist.
5979 (Bug#9139)
5980
6612f0bf
PE
59812011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5982
5983 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5984 here ...
5985 * lisp.h: ... from here. push_key_description is no longer
5986 defined in keyboard.c, so its declaration should not be in
5987 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5988 logically belongs with push_key_description.
5989
dfb3f755
PE
59902011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5991
5992 * buffer.h: Include <sys/types.h> instead of <time.h>.
5993 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5994 Problem reported by Herbert J. Skuhra.
5995
3134906c
LMI
59962011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5997
5998 * xml.c (parse_region): Make the parsing work for
5999 non-comment-starting XML files again (bug#9144).
6000
8d903f4e
AS
60012011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6002
6003 * image.c (gif_load): Fix calculation of bottom and right corner.
6004 (Bug#9468)
6005
80ad64f4
EZ
60062011-09-10 Eli Zaretskii <eliz@gnu.org>
6007
6008 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6009 redisplay in small windows.
6010
208a048d
EZ
60112011-09-09 Eli Zaretskii <eliz@gnu.org>
6012
6013 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6014
9b1c252e
MR
60152011-09-08 Martin Rudalics <rudalics@gmx.at>
6016
6017 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6018 Operate on live windows only.
6019
2949f33b
JB
60202011-09-08 Juanma Barranquero <lekktu@gmail.com>
6021
6022 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6023
e08dcafd
EZ
60242011-09-07 Eli Zaretskii <eliz@gnu.org>
6025
6026 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6027 only under bidi iteration.
6028
115b96bd
JD
60292011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6030
6031 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6032
c8199d0f
PE
60332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6034
6035 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6036 Without this fix, the command to link temacs failed due to an
6037 undefined symbol __builtin_isnan. This is because
6038 /usr/include/iso/math_c99.h #defines isnan(x) to
6039 __builtin_isnan(x), but the bundled gcc, which identifies itself
6040 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6041 a __builtin_isnan.
6042 * floatfns.c (isnan): #undef, and then #define to a clone of
6043 what's in data.c.
6044 (Fisnan): Always define, since it's always available now.
6045 (syms_of_floatfns): Always define isnan at the Lisp level.
6046
e39b275c 60472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6048
6049 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6050
b2db44d9 60512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6052
f4af5137 6053 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6054 The previous code assumed that file offsets (off_t values) fit in
6055 EMACS_INT variables, which is not true on typical 32-bit hosts.
6056 The code messed up by falsely reporting buffer overflow in cases
6057 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6058 when "big" contains more than 2**29 bytes, even though this
6059 inserts just one byte and does not overflow the buffer.
6060 (Finsert_file_contents): Store file offsets as off_t
6061 values, not as EMACS_INT values. Check for overflow when
6062 converting between EMACS_INT and off_t. When checking for
6063 buffer overflow or for overlap, take the offsets into account.
6064 Don't use EMACS_INT for small values where int suffices.
6065 When checking for overlap, fix a typo: ZV was used where
6066 ZV_BYTE was intended.
6067 (Fwrite_region): Don't assume off_t fits into 'long'.
6068 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6069
ecfc0a49
MA
60702011-09-05 Michael Albinus <michael.albinus@gmx.de>
6071
6072 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6073
6511acf2 60742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6075
0999621a 6076 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6077
6078 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6079 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6080 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6081 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6082 (modify_event_symbol): Do not assume that the length of
6083 name_alist_or_stem is safe to alloca and fits in int.
6084 (Fexecute_extended_command): Likewise for function name and binding.
6085 (Frecursion_depth): Wrap around reliably on integer overflow.
6086 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6087 since some callers pass EMACS_INT values.
6088 (Fsingle_key_description): Don't crash if symbol name contains more
6089 than MAX_ALLOCA bytes.
6090 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6091 (get_minibuffer): Arg is now EMACS_INT, not int.
6092 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6093 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6094 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6095
2be7d702
PE
6096 * dbusbind.c (signature_cat): New function.
6097 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6098 Do not overrun buffer; instead, report string overflow.
6099
9d1df220
PE
6100 * dispnew.c (add_window_display_history): Don't overrun buffer.
6101 Truncate instead; this is OK since it's just a log.
6102
33ef5c64
PE
6103 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6104 even if the time zone offset is outlandishly large.
6105 Don't mishandle offset == INT_MIN.
6106
66c6fdd5
PE
6107 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6108 when creating daemon; the previous buffer-overflow check was incorrect.
6109
d749b01b
PE
6110 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6111 which has the guts of the old verror function.
6112
b5cd1905
PE
6113 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6114 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6115
6e1a67fb
PE
6116 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6117 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6118 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6119 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6120 length of string rather than counting it via multiple sprintfs;
6121 that's simpler and more reliable.
c21721cc
PE
6122 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6123 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6124 sprintf, in case result does not fit in int.
6125
c57b67fc
PE
6126 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6127 (fontset_from_font): Print it.
6128
8a401434
PE
6129 * frame.c (tty_frame_count): Now printmax_t, not int.
6130 (make_terminal_frame, set_term_frame_name): Print it.
6131 (x_report_frame_params): In X, window IDs are unsigned long,
6132 not signed long, so print them as unsigned.
6133 (validate_x_resource_name): Check for implausibly long names,
6134 and don't assume name length fits in 'int'.
6135 (x_get_resource_string): Don't blindly alloca invocation name;
6136 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6137 not fit in int.
6138
6e1a67fb
PE
6139 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6140 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6141 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6142
0df02bf3
PE
6143 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6144 Use esprintf, not sprintf, in case result does not fit in int.
6145
48e30793
PE
6146 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6147 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6148 it as a large positive number.
6149 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6150 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6151
a66ff6d8
PE
6152 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6153 in case result does not fit in int.
6154
aca216ff
PE
6155 * print.c (float_to_string): Detect width overflow more reliably.
6156 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6157 buffer overrun. Don't assume list length fits in 'int'. Treat
6158 print length of 0 as 0, not as infinity; to be consistent with other
6159 uses of print length in this function. Don't overflow print length
6160 index. Don't assume hash table size fits in 'long', or that
6161 vectorlike size fits in 'unsigned long'.
6162
31c286f7
PE
6163 * process.c (make_process): Use printmax_t, not int, to format
6164 process-name gensyms.
6165
55e5faa1
PE
6166 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6167
80f2e268
PE
6168 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6169 to avoid potential buffer overrun.
6170
670741ab
PE
6171 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6172 if X resource line is longer than 512 bytes.
6173
b7163a50
PE
6174 * xfns.c (x_window): Make sprintf buffer a bit bigger
6175 to avoid potential buffer overrun.
6176
ae58ff1f
PE
6177 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6178
c43c8a6a
PE
6179 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6180
3f8236f4
PE
61812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6182
53e9fe90 6183 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6184 Without these, Emacs silently mishandles large integers sometimes.
6185 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6186 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6187
6511acf2
PE
6188 * xdisp.c (try_window_id): Check Emacs fixnum range before
6189 converting to 'int'.
806add1d 6190
6511acf2 6191 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6192 Check that an Emacs fixnum is in range before assigning it to 'int'.
6193 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6194 values converted from Emacs fixnums.
6195 (Frecenter): Don't wrap around a line count if it is out of 'int'
6196 range; instead, treat it as an extreme value.
6197 (Fset_window_configuration, compare_window_configurations):
6198 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6199
6511acf2
PE
6200 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6201 that can exceed INT_MAX. Check that EMACS_INT value is in range
6202 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6203 (match_limit): Don't assume that a fixnum can fit in 'int'.
6204
6511acf2 6205 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6206 exceed INT_MAX.
6207
6511acf2 6208 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6209 (Fvertical_motion): Don't wrap around LINES values that don't fit
6210 in 'int'. Instead, treat them as extreme values. This is good
6211 enough for windows, which can't have more than INT_MAX lines anyway.
6212
fcb901a7
LMI
62132011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6214
0f2f6b6d
LMI
6215 * Require libxml/parser.h to avoid compilation warning.
6216
fcb901a7
LMI
6217 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6218
6219 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6220 since this reportedly can destroy thread storage.
6221
6e20a0d4
CY
62222011-08-30 Chong Yidong <cyd@stupidchicken.com>
6223
6224 * syntax.c (find_defun_start): Update all cache variables if
6225 exiting early (Bug#9401).
6226
148ae00e
EZ
62272011-08-30 Eli Zaretskii <eliz@gnu.org>
6228
f6cfbd8f
EZ
6229 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6230
148ae00e
EZ
6231 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6232 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6233 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6234
6235 * term.c (tty_append_glyph): New function.
6236 (produce_stretch_glyph): Static function and its prototype deleted.
6237
a66cfb1c
SM
6238 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6239 Add prototypes.
148ae00e 6240
c4a07a4c
PE
62412011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6242
6243 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6244 when checking :margin (Bug#9390).
6245 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6246 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6247 so that the name doesn't mislead. All uses changed.
6248
6bc8cd65
JB
62492011-08-28 Johan Bockgård <bojohan@gnu.org>
6250
6251 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6252 set_tty_hooks.
6253
dca4927e
EZ
62542011-08-27 Eli Zaretskii <eliz@gnu.org>
6255
6256 * xdisp.c (move_it_to): Don't bail out early when reaching
6257 position beyond to_charpos, if we are scanning backwards.
6258 (move_it_vertically_backward): When DY == 0, make sure we get to
6259 the first character in the line after the newline.
6260
f2cad773
PE
62612011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6262
6263 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6264 (ccl_driver): Do not generate an out-of-range pointer.
6265 (Fccl_execute_on_string): Remove unnecessary check for
6266 integer overflow, noted by Stefan Monnier in
6267 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6268 Remove a FIXME that didn't need fixing.
6269 Simplify the newly-introduced buffer reallocation code.
6270
0cae2cdb
JB
62712011-08-27 Juanma Barranquero <lekktu@gmail.com>
6272
6273 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6274
5fc295a4 62752011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6276
70c60eb2 6277 Integer and memory overflow issues (Bug#9196).
726e0ab1 6278
d31850da
PE
6279 * doc.c (get_doc_string): Rework so that
6280 get_doc_string_buffer_size is the actual buffer size, rather than
6281 being 1 less than the actual buffer size; this makes xpalloc more
6282 convenient.
6283
a69fbedb
PE
6284 * image.c (x_allocate_bitmap_record, cache_image):
6285 * xselect.c (Fx_register_dnd_atom):
6286 Simplify previous changes by using xpalloc.
6287
fe5c5d37
PE
6288 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6289 since either will do and ptrdiff_t is convenient with xpalloc.
6290
0065d054
PE
6291 * charset.c (charset_table_size)
6292 (struct charset_sort_data.priority): Now ptrdiff_t.
6293 (charset_compare): Don't overflow if priorities differ greatly.
6294 (Fsort_charsets): Don't assume list length fits in int.
6295 Check for size-calculation overflow when allocating sort data.
6296 (syms_of_charset): Allocate an initial charset table that is
6297 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6298
6299 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6300
6301 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6302 The actual value is always <= INT_MAX, and leaving it unsigned made
6303 overflow checking harder.
6304
6305 * dispextern.h (struct glyph_matrix.rows_allocated)
6306 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6307 with xpalloc. The values are still always <= INT_MAX.
6308
6309 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6310
6311 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6312 (SAFE_NALLOCA): New macro.
6313
6314 * region-cache.c (struct boundary.pos, find_cache_boundary)
6315 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6316 (set_cache_region, invalidate_region_cache)
6317 (revalidate_region_cache, know_region_cache, region_cache_forward)
6318 (region_cache_backward, pp_cache):
6319 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6320 so that ptrdiff_t * can be passed to xpalloc.
6321 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6322 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6323 (pp_cache): Don't assume cache_len fits in int.
6324 * region-cache.h: Adjust extern decls to match.
6325
6326 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6327 EMACS_INT, since either will do, for xpalloc.
6328
6329 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6330 (xnmalloc, xnrealloc, xpalloc): New functions.
6331
726e0ab1
PE
6332 * bidi.c (bidi_shelve_header_size): New constant.
6333 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6334 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6335
51f30bc5 6336 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6337 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6338 (overlay_strings):
6339 Don't update size of array until after memory allocation succeeds,
6340 because xmalloc/xrealloc may not return.
0065d054
PE
6341 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6342 now that we have proper integer overflow checking.
6343 (record_overlay_string, overlay_strings): Catch overflows when
6344 calculating size of overlay_str_buf.
726e0ab1 6345
0065d054
PE
6346 * callproc.c (Fcall_process): Check for size overflow when
6347 calculating size of args2.
6348 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6349 Normally we prefer signed values, but sticking with ptrdiff_t would
6350 require adding more-complicated checks.
726e0ab1
PE
6351
6352 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6353 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6354 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6355 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6356
6357 * character.c (Fstring): Check for size-calculation overflow.
6358
6359 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6360 unnecessary integer overflow. Check for size overflow.
6361 (encode_coding_object): Don't update size until xmalloc succeeds.
6362
6363 * composite.c (get_composition_id): Check for overflow in glyph
6364 length calculations.
6365
6366 Integer and memory overflow fixes for display code.
6367 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6368 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6369 (scrolling_window): Check for overflow in size calculations.
6370 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6371 Don't assume glyph table len fits in int.
6372 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6373 (row_table_size): Now ptrdiff_t, not int.
6374 (scrolling_window): Avoid overflow in size calculations.
6375 Don't update size until allocation succeeds.
6376 * fns.c (concat): Check for overflow in size calculations.
6377 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6378 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6379 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6380
6381 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6382 (get_doc_string): Check for size calculation overflow.
6383 Don't update size until allocation succeeds.
6384 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6385 EMACS_INT, where ptrdiff_t will do.
6386 (Fsubstitute_command_keys): Check for string overflow.
6387
6388 * editfns.c (set_time_zone_rule): Don't assume environment length
6389 fits in int.
6390 (message_length): Now ptrdiff_t, not int.
6391 (Fmessage_box): Don't update size until allocation succeeds.
6392 Don't assume message length fits in int.
6393 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6394
0065d054
PE
6395 * emacs.c (main): Do not reallocate argv, since there is a null at
6396 the end that can be overwritten, and this way there's no need to
6397 worry about size-calculation overflow.
6398 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6399
6400 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6401 alloc succeeds.
6402 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6403
6404 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6405 (x_set_scroll_bar_width, x_figure_window_size):
6406 Check for integer overflow.
6407 (x_set_alpha): Do not assume XINT fits in int.
6408
6409 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6410 This is for the members text_lines, text_cols, total_lines, total_cols,
6411 where the system imposes an 'int' limit.
6412
6413 * fringe.c (Fdefine_fringe_bitmap):
6414 Don't update size until alloc works.
6415
6416 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6417 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6418
6419 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6420 Check for size-calculation overflow.
6421 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6422 do, as we prefer signed integers.
6423 (id_to_widget.max_size, id_to_widget.used)
6424 (xg_store_widget_in_map, xg_remove_widget_from_map)
6425 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6426 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6427 Use and return ptrdiff_t, not int.
6428 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6429 * gtkutil.h: Change prototypes to match the above.
6430
6431 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6432 are duplicate now that they've been promoted to lisp.h.
6433 (x_allocate_bitmap_record, x_alloc_image_color)
6434 (make_image_cache, cache_image, xpm_load):
6435 Don't update size until alloc is done.
6436 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6437 (x_detect_edges):
3256efce 6438 Check for size calculation overflow.
726e0ab1
PE
6439 (ct_colors_allocated_max): New constant.
6440 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6441 overflow.
3256efce 6442
726e0ab1
PE
6443 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6444 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6445 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6446 Use ptrdiff_t, not int, to count maps.
6447 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6448 calculations. Don't update size until allocation succeeds.
6449 Redo calculations to avoid overflow.
726e0ab1
PE
6450 * keyboard.h: Change prototypes to match the above.
6451
6452 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6453 to count maps.
6454 (current_minor_maps): Check for size calculation overflow.
6455 * keymap.h: Change prototypes to match the above.
6456
6457 * lread.c (read1, init_obarray): Don't update size until alloc done.
6458
6459 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6460 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6461
726e0ab1
PE
6462 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6463 Now ptrdiff_t, not int.
6464 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6465 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6466
6467 * process.c (Fnetwork_interface_list): Check for overflow
6468 in size calculation.
6469
6470 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6471
6472 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6473 overflow. Don't bother calling xmalloc when xrealloc will do.
6474
6475 * search.c (Freplace_match): Check for size calculation overflow.
6476 (Fset_match_data): Don't assume list lengths fit in 'int'.
6477
6478 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6479 for command line length. Do not attempt to address one before the
6480 beginning of an array, as that's not portable.
6481
6482 * term.c (max_frame_lines): Remove; unused.
6483 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6484 not int.
6485 (encode_terminal_code, calculate_costs): Check for size
6486 calculation overflow.
6487 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6488 table lengths and related sizes. Don't update size until alloc
6489 done. Redo calculations to avoid overflow.
6490 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6491
6492 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6493 subtracting pointers.
6494 (gobble_line): Check for overflow more carefully. Don't update size
6495 until alloc done.
6496
6497 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6498 Don't update size until alloc done.
6499 Redo size calculations to avoid overflow.
6500 Check for size calculation overflow.
0065d054 6501 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6502
6503 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6504 Use ptrdiff_t, not int, for sizes.
6505 (store_mode_line_noprop_char): Don't update size until alloc done.
6506
0065d054
PE
6507 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6508 Use ptrdiff_t, not int, for sizes.
6509 (Finternal_make_lisp_face, cache_face):
6510 Check for size calculation overflow.
6511 (cache_face): Treat size calculation overflows as if they were
6512 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6513
6514 * xfns.c (x_encode_text, x_set_name_internal)
6515 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6516 sizes, since they can exceed INT_MAX in size. Check for size
6517 calculation overflow.
6518
0065d054
PE
6519 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6520 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6521 Don't update size until alloc done.
6522
0065d054 6523 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6524 as sprintf is limited to int lengths.
1d526e2f 6525
252c5ee1
PE
6526 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6527 (X_LONG_MIN): New macros.
864d7ce7
PE
6528 Use them to make the following changes clearer.
6529 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6530 This change doesn't affect the value now, but it may help remind
6531 future maintainers not to raise the value too much later.
6532 (SELECTION_QUANTUM): Remove, replacing with ...
6533 (selection_quantum): ... new function, which avoids overflow.
6534 All uses changed.
6535 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6536 assumption that selection length fits in 'int'.
6537 (x_reply_selection_request, x_handle_selection_request)
6538 (x_get_window_property, receive_incremental_selection)
6539 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6540 (lisp_data_to_selection_data, clean_local_selection_data):
6541 Use ptrdiff_t, not int, to record length of selection.
6542 (x_reply_selection_request, x_get_window_property)
6543 (receive_incremental_selection, x_property_data_to_lisp):
6544 Redo calculations to avoid overflow.
6545 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6546 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6547 something.
6548 (x_get_window_property, receive_incremental_selection)
6549 (lisp_data_to_selection_data, x_property_data_to_lisp):
6550 Check for size-calculation overflow.
6551 (x_get_window_property, receive_incremental_selection)
6552 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6553 Don't store size until memory allocation succeeds.
6554 (x_get_window_property): Plug memory leak on memory exhaustion.
6555 Don't double-block input; malloc is safe here. Don't assume 2**34
6556 - 4 fits in unsigned long. Add an xassert to check
6557 XGetWindowProperty overflow. Be more careful about overflow
6558 calculations, and distinguish size from memory overflow better.
6559 (receive_incremental_selection): When tracing, don't assume
6560 unsigned int is less than INT_MAX.
6561 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6562 harmful) conversions of unsigned short to int.
6563 (lisp_data_to_selection_data): Don't assume that integers
6564 in the range -65535 through -1 fit in an X unsigned short.
6565 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6566 result parameters unless successful. Rely on cons_to_unsigned
6567 to report problems with elements; the old code wasn't right anyway.
6568 (x_check_property_data): Check for int overflow; we cannot use
6569 a wider type due to X limits.
6570 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6571
726e0ab1 6572 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6573
0065d054
PE
6574 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6575 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6576 (x_color_cells): Don't store size until memory allocation succeeds.
6577 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6578 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6579 (x_term_init): Don't assume length fits in int (sprintf is limited
6580 to int size).
bc18e09d 6581
ebfa62c0
PE
6582 Use ptrdiff_t for composition IDs.
6583 * character.c (lisp_string_width):
6584 * composite.c (composition_table_size, n_compositions)
6585 (get_composition_id, composition_gstring_from_id):
6586 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6587 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6588 * window.c (Frecenter):
6589 Use ptrdiff_t, not int, for composition IDs.
6590 * composite.c (get_composition_id): Check for integer overflow.
6591 * composite.h: Adjust prototypes to match the above changes.
6592
d3411f89
PE
6593 Use ptrdiff_t for hash table indexes.
6594 * category.c (hash_get_category_set):
6595 * ccl.c (ccl_driver):
6596 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6597 * coding.c (coding_system_charset_list, detect_coding_system):
6598 * coding.h (struct coding_system.id):
6599 * composite.c (get_composition_id, gstring_lookup_cache):
6600 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6601 * image.c (xpm_get_color_table_h):
6602 * lisp.h (hash_lookup, hash_put):
6603 * minibuf.c (Ftest_completion):
6604 Use ptrdiff_t for hash table indexes, not int (which is too
6605 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6606 32-bit --with-wide-int hosts).
6607
e097a6fa
PE
6608 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6609 Add a FIXME comment about memory leaks.
6610 (syms_of_charset): Don't assume xmalloc returns.
6611
5637687f
PE
6612 Don't assume that stated character widths fit in int.
6613 * character.c (Fchar_width, c_string_width, lisp_string_width):
6614 * character.h (CHAR_WIDTH):
6615 * indent.c (MULTIBYTE_BYTES_WIDTH):
6616 Use sanitize_char_width to avoid undefined and/or bad behavior
6617 with outlandish widths.
a66cfb1c 6618 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6619 now that we have two such functions. All uses changed.
6620 (sanitize_char_width): New inline function.
6621
a2271ba2
PE
6622 Don't assume that tab-width fits in int.
6623 * character.h (sanitize_width): New inline function.
6624 (SANE_TAB_WIDTH): New macro.
6625 (ASCII_CHAR_WIDTH): Use it.
6626 * indent.c (sane_tab_width): Remove. All uses replaced by
6627 SANE_TAB_WIDTH (current_buffer).
6628 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6629
18c52557
PE
6630 * fileio.c: Integer overflow issues with file modes.
6631 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6632
caeeedc1
PE
6633 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6634 Remove unreachable code.
6635 (read_hex, load_charset_map_from_file): Check for integer overflow.
6636
6df6ae42 6637 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6638 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6639 (x_send_scroll_bar_event): Likewise. Check that the size does not
6640 exceed limits imposed by XClientMessageEvent, as well as the usual
6641 ptrdiff_t and size_t limits.
6642
b13995db
PE
6643 * keyboard.c: Overflow, signedness and related fixes.
6644 (make_lispy_movement): Use same integer type in forward decl
6645 that is used in the definition.
6646 (read_key_sequence, keyremap_step):
6647 Change bufsize argument back to int, undoing my 2011-03-30 change.
6648 We prefer signed types, and int is wide enough here.
6649 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6650 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6651 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6652 length, not size_t. Use ptrdiff_t for index, not int.
6653 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6654 possibility of integer overflow.
6655
13464394
PE
6656 Overflow, signedness and related fixes for images.
6657
6658 * dispextern.h (struct it.stack[0].u.image.image_id)
6659 (struct_it.image_id, struct image.id, struct image_cache.size)
6660 (struct image_cache.used, struct image_cache.ref_count):
6661 * gtkutil.c (update_frame_tool_bar):
6662 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6663 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6664 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6665 * nsmenu.m (update_frame_tool_bar):
6666 * xdisp.c (calc_pixel_width_or_height):
6667 * xfns.c (image_cache_refcount):
6668 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6669 on typical 64-bit hosts.
6670
6671 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6672 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6673 Omit unnecessary casts to int.
6674 (parse_image_spec): Check that integers fall into 'int' range
6675 when the callers expect that.
6676 (image_ascent): Redo ascent calculation to avoid int overflow.
6677 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6678 (lookup_image): Remove unnecessary tests.
6679 (xbm_image_p): Locals are now of int, not EMACS_INT,
6680 since parse_image_check makes sure they fit into int.
6681 (png_load, gif_load, svg_load_image):
6682 Prefer int to unsigned where either will do.
6683 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6684 old tiff_error_handler and tiff_warning_handler.
6685 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6686 stack buffer overflows. It uses only the features of vsnprintf
6687 that are common to both POSIX and native Microsoft.
6688 (tiff_error_handler, tiff_warning_handler): Use it.
6689 (tiff_load, gif_load, imagemagick_load_image):
6690 Don't assume :index value fits in 'int'.
6691 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6692 (imagemagick_load_image): Check that crop parameters fit into
6693 the integer types that MagickCropImage accepts. Don't assume
6694 Vimagemagick_render_type has a nonnegative value. Don't assume
6695 size_t fits in 'long'.
6696 (gs_load): Use printmax_t to print the widest integers possible.
6697 Check for integer overflow when computing image height and width.
6698
c11821d4
EZ
66992011-08-26 Eli Zaretskii <eliz@gnu.org>
6700
6701 * xdisp.c (redisplay_window): Don't force window start if point
6702 will be invisible in the resulting window. (Bug#9324)
6703
0c95fcf7
EZ
67042011-08-25 Eli Zaretskii <eliz@gnu.org>
6705
6706 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6707 the display spec is of the form `(space ...)'.
6708 (handle_display_spec): Return the value returned by
6709 handle_single_display_spec, not just 1 or zero.
6710 (handle_single_display_spec): If the display spec is of the form
6711 `(space ...)', and specifies display in the text area, return 2
6712 rather than 1.
fee65a97 6713 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6714 accurately, and prefer exact match for point under bidi.
6715 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6716
6717 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6718 into disp_prop; all users changed.
6719
6720 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6721 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6722 for the text covered by the display property.
6723
e4ed06f1
CY
67242011-08-25 Chong Yidong <cyd@stupidchicken.com>
6725
6726 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6727 Change return value to nil.
6728 (Frecord_buffer): Delete unused function.
6729
f67cdd7f
EZ
67302011-08-24 Eli Zaretskii <eliz@gnu.org>
6731
5980d4c6
EZ
6732 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6733 buffers, return left-to-right.
8610fe8b
EZ
6734 (set_cursor_from_row): Consider candidate row a win if its glyph
6735 represents a newline and point is on that newline. Fixes cursor
6736 positioning on the newline at EOL of R2L text within L2R
6737 paragraph, and vice versa.
6738 (try_cursor_movement): Check continued rows, in addition to
6739 continuation rows. Fixes unwarranted scroll when point enters a
6740 continued line of R2L text within an L2R paragraph, or vice versa.
6741 (cursor_row_p): Consider the case of point being equal to
6742 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6743 from the end of a short line to the beginning of a continued line
6744 of R2L text within L2R paragraph.
6745 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6746 composed characters.
5980d4c6 6747
f67cdd7f
EZ
6748 * bidi.c (bidi_check_type): Use xassert.
6749 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6750 members.
6751
bca633fb
EZ
67522011-08-23 Eli Zaretskii <eliz@gnu.org>
6753
6754 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6755 a character.
6756
4a5885a7
CY
67572011-08-23 Chong Yidong <cyd@stupidchicken.com>
6758
6759 * nsfont.m (ns_otf_to_script): Fix typo.
6760
0902a04e
KH
67612011-08-22 Kenichi Handa <handa@m17n.org>
6762
6763 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6764 extra slot even if the purpose is char-code-property-table.
6765
1a2e6670
EZ
67662011-08-23 Eli Zaretskii <eliz@gnu.org>
6767
8ddde651
EZ
6768 * xdisp.c (redisplay_window): When computing centering_position,
6769 account for the height of the header line. (Bug#8874)
6770
425cc014
EZ
6771 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6772 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6773 candidate is selected by the mouse, and that candidate has a
6774 composed character under the mouse.
6775
1a2e6670
EZ
6776 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6777 coordinates reported by pos-visible-in-window-p for a composed
6778 character in column zero.
6779
8b76d6f8
SM
67802011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6781
6782 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6783
dac347dd
EZ
67842011-08-22 Eli Zaretskii <eliz@gnu.org>
6785
6786 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6787 consider it a hit if to_charpos is anywhere in the range of the
6788 composed buffer positions.
6789
e013fb34
CY
67902011-08-22 Chong Yidong <cyd@stupidchicken.com>
6791
6792 * image.c (gif_load): Don't assume that each subimage has the same
6793 dimensions as the base image. Handle disposal method that is
6794 "undefined" by the gif spec (Bug#9335).
6795
bd1ba3e8
CY
67962011-08-20 Chong Yidong <cyd@stupidchicken.com>
6797
6798 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6799 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6800
54a1215b
EZ
68012011-08-19 Eli Zaretskii <eliz@gnu.org>
6802
823564e5
EZ
6803 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6804 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6805 from an Org mode buffer to a Speedbar frame.
6806
54a1215b
EZ
6807 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6808 a composition, take its buffer position from IT->cmp_it.charpos.
6809 Fixes cursor positioning at the beginning of a line that begins
6810 with a composed character.
6811
9778ebcc
EZ
68122011-08-18 Eli Zaretskii <eliz@gnu.org>
6813
0be6ee06
EZ
6814 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6815 character bidirectional type, use STRONG_L instead. Fixes crashes
6816 in a buffer produced by `describe-categories'.
6817
9778ebcc
EZ
6818 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6819 members before the level stack, so they would be saved and
6820 restored when copying iterator state. Fixes incorrect reordering
6821 around TABs covered by display properties.
6822
156bffbe
AS
68232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6824
6b02f655 6825 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6826
72ad093b
CY
68272011-08-17 Chong Yidong <cyd@stupidchicken.com>
6828
6829 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6830 (internal_condition_case_2, internal_condition_case_n):
6831 Remove unnecessary aborts (Bug#9081).
72ad093b 6832
35774242
EZ
68332011-08-17 Eli Zaretskii <eliz@gnu.org>
6834
6835 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6836 has no `load' handler, try opening the file locally. (Bug#9311)
6837
db76dd85
KB
68382011-08-16 Ken Brown <kbrown@cornell.edu>
6839
6840 * gmalloc.c: Expand comment.
6841
b215eee5
EZ
68422011-08-16 Eli Zaretskii <eliz@gnu.org>
6843
6844 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6845 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6846
a4579d33
KB
68472011-08-16 Ken Brown <kbrown@cornell.edu>
6848
6849 Fix memory allocation problems in Cygwin build (Bug#9273).
6850
6851 * unexcw.c ( __malloc_initialized): Declare external variable.
6852 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6853
8b76d6f8
SM
6854 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6855 New variables.
a4579d33
KB
6856 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6857 dumped emacs.
6858 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6859 in the static heap.
6860 [CYGWIN] (special_realloc): New function.
6861 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6862 requests to realloc storage in the static heap.
6863
3ebec551
PE
68642011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6865
6866 * bidi.c (bidi_initialize): Remove unused local.
6867
9fd8be00
EZ
68682011-08-15 Eli Zaretskii <eliz@gnu.org>
6869
6b02f655
SM
6870 * bidimirror.h:
6871 * biditype.h: Remove file.
6872 * makefile.w32-in ($(BLD)/bidi.$(O)):
6873 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6874
6875 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6876
6877 * chartab.c: Improve commentary for the uniprop_table API.
6878
32413314
EZ
6879 * bidi.c (bidi_paragraph_init): Support zero value of
6880 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6881 (bidi_initialize): Use uniprop_table instead of including
6882 biditype.h and bidimirror.h.
32413314 6883
9fd8be00
EZ
6884 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6885 coordinates of the iterator when restoring from ppos_it.
6886 (Bug#9296)
6887
5cf2b69b
KH
68882011-08-14 Kenichi Handa <handa@m17n.org>
6889
6890 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6891 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6892
daf17d00
EZ
68932011-08-14 Eli Zaretskii <eliz@gnu.org>
6894
6895 * xdisp.c (move_it_in_display_line_to): Don't invoke
6896 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6897 ppos_it. Fixes vertical cursor motion when line beginning is
6898 covered by an image. (Bug#9296)
6899
08e3161a
JD
69002011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6901
6902 * nsterm.h (ns_run_ascript): Declare.
6903 (NSAPP_DATA2_RUNASSCRIPT): Define.
6904
6905 * nsfns.m (as_script, as_result, as_status): New static variables.
6906 (ns_run_ascript): New function.
5e617bc2 6907 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6908 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6909 the event loop. Get status from as_status (Bug#7276).
6910
6911 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6912 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6913 the event loop (Bug#7276).
6914
a3720aa2
AS
69152011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6916
6917 * gnutls.c (QCgnutls_bootprop_priority)
6918 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6919 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6920 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6921 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6922 (QCgnutls_bootprop_verify_hostname_error)
6923 (QCgnutls_bootprop_callbacks_verify): Rename from
6924 Qgnutls_bootprop_..., all uses changed.
6925
6926 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6927 uses changed.
6928
0a0d27fb
PE
69292011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6930
19d5c50c
PE
6931 * xfaces.c (Qframe_set_background_mode): Now static.
6932 * dispextern.h (Qframe_set_background_mode): Remove decl.
6933
0a0d27fb
PE
6934 * process.c (Fnetwork_interface_info): Declare local only if needed.
6935
377538cb
JD
69362011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6937
6938 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6939 (Fnetwork_interface_list): Allocate in increments of bytes instead
6940 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6941 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6942 sockaddr.
6943 (struct ifflag_def): notrailers is smart on OSX.
6944 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6945 Get hardware address with getifaddrs if available.
6946
08fff70c
EZ
69472011-08-12 Eli Zaretskii <eliz@gnu.org>
6948
6949 * xdisp.c (iterate_out_of_display_property): xassert that
6950 IT->position is set to within IT->object's boundaries. Break from
6951 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6952 when IT->position is set up wrongly due to some bug.
6953 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6954 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6955 entry. Force push_it to save on the stack the current
6956 buffer/string position, to be restored by pop_it. Fix flags in
6957 the iterator structure wrt the object coming from a display
6958 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6959 properties. (Bug#9284)
6960
7be1c708 69612011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6962
7be1c708
CY
6963 * fontset.c (fontset_get_font_group): Add proper type checks.
6964 (Bug#9172)
aac0c6e3 6965
7be1c708 69662011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6967
7be1c708
CY
6968 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6969 and LC_VERSION_MIN_MACOSX.
6970 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6971 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6972
97bb72a6
EZ
69732011-08-08 Eli Zaretskii <eliz@gnu.org>
6974
6975 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6976 no-display-properties-and-no-overlays under bidi display.
6977 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6978 properties and overlays.
97bb72a6 6979
d5617611
CY
69802011-08-08 Chong Yidong <cyd@stupidchicken.com>
6981
37e11a63
CY
6982 * editfns.c (Fset_time_zone_rule): Document relationship with the
6983 setenv function.
6984
d5617611
CY
6985 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6986 the font entity extracted from the cache (Bug#8109).
6987
58872834
CY
69882011-08-07 Chong Yidong <cyd@stupidchicken.com>
6989
6990 * composite.c (autocmp_chars): Don't reset point. That is done by
6991 restore_point_unwind (Bug#5984).
6992
75bfc667
JL
69932011-08-07 Juri Linkov <juri@jurta.org>
6994
6995 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6996 to show the arg `TIME' instead of `TIMEVAL'.
6997
d1410150
EZ
69982011-08-06 Eli Zaretskii <eliz@gnu.org>
6999
7000 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7001 display property strides EOL and includes a newline, as in
7002 longlines-mode. (Bug#9254)
75b771e4
EZ
7003 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7004 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7005
7006 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7007 is non-zero, even if the data buffer is NULL. Fixes a crash in
7008 vertical-motion with longlines-mode. (Bug#9254)
7009
35928349
EZ
70102011-08-05 Eli Zaretskii <eliz@gnu.org>
7011
ec7cc85b
EZ
7012 * bidi.c <bidi_cache_total_alloc>: Now static.
7013 (bidi_initialize): Initialize bidi_cache_total_alloc.
7014
8b76d6f8 7015 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7016 cache. (Bug#9221)
7017
7018 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7019 amount allocated this far in `bidi_cache_total_alloc'.
7020 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7021 non-zero, only free the data buffer without restoring the cache
7022 contents. All callers changed.
7023
7024 * dispextern.h (bidi_unshelve_cache): Update prototype.
7025
7026 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7027 (move_it_in_display_line, move_it_to)
7028 (move_it_vertically_backward, move_it_by_lines): Replace the call
7029 to xfree to an equivalent call to bidi_unshelve_cache.
7030 (move_it_in_display_line_to): Fix logic of returning
412b6358 7031 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7032
e2e2423b
EZ
70332011-08-05 Eli Zaretskii <eliz@gnu.org>
7034
7035 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7036 came from a string character with a `cursor' property. (Bug#9229)
7037
ae9e757a
JD
70382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7039
7040 * Makefile.in (LIB_PTHREAD): New variable.
7041 (LIBES): Add LIB_PTHREAD (Bug#9216).
7042
7043 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7044 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7045
213bd7f2
AS
70462011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7047
6b02f655 7048 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7049
99aaf75f
JD
70502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7051
7052 * xterm.c (x_find_topmost_parent): New function.
7053 (x_set_frame_alpha): Find topmost parent window with
7054 x_find_topmost_parent and set the property there also (bug#9181).
7055 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7056
c74e9d86
PE
70572011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7058
7059 * callproc.c (Fcall_process): Avoid vfork clobbering
7060 the local vars buffer, coding_systems, current_dir.
7061
640c8776
SM
70622011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7063
7064 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7065
f26d0e4c
PE
70662011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7067
8a10d76c
PE
7068 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7069 so that it is not optimized away.
7070
f26d0e4c
PE
7071 * xdisp.c (compute_display_string_pos): Remove unused local.
7072
55439c61
EZ
70732011-08-02 Eli Zaretskii <eliz@gnu.org>
7074
7075 Fix slow cursor motion and scrolling in large buffers with
7076 selective display, like Org Mode buffers. (Bug#9218)
7077
7078 * dispextern.h (struct bidi_it): New member disp_prop_p.
7079
7080 * xdisp.c: Remove one-slot cache of display string positions.
7081 (compute_display_string_pos): Accept an additional argument
5e617bc2 7082 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7083 for a display string or property. If found, set DISP_PROP_P
7084 non-zero.
7085
7086 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7087 DISP_PROP_P, and pass it to compute_display_string_pos.
7088 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7089 non-zero. All callers of bidi_fetch_char changed.
7090
fb33fa43
SM
70912011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7092
7093 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7094
b099e063
DM
70952010-12-03 Don March <don@ohspite.net>
7096
7097 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7098 last character M-[char] is translated to ESC [char] (bug#7541).
7099
5cc7f7af
KH
71002011-08-02 Kenichi Handa <handa@m17n.org>
7101
d0fffa3f 7102 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7103
7104 * chartab.c (uniprop_table): Make it non-static.
7105
525d5e6e
EZ
71062011-08-01 Eli Zaretskii <eliz@gnu.org>
7107
7108 * xdisp.c (forward_to_next_line_start): Accept additional argument
7109 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7110 on the newline.
7111 (reseat_at_next_visible_line_start): Use the bidi iterator state
7112 returned by forward_to_next_line_start to restore the state of
7113 it->bidi_it after backing up to previous newline. (Bug#9212)
7114
31011111
AS
71152011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7116
7117 * regex.c (re_comp): Protoize.
7118 (re_exec): Fix return type.
7119 (regexec): Fix type of `ret'. (Bug#9203)
7120
476371c4
PE
71212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7122
e5d76069
PE
7123 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7124 This is needed if max-image-size is a floating-point number.
7125
9a79b20c
AS
71262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7127
7128 * print.c (print_object): Print empty symbol as ##.
7129
7130 * lread.c (read1): Read ## as empty symbol.
7131
d8c2fa78
AA
71322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7133
7134 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7135 setting frame foreground color (Bug#9175).
7136 (x_set_background_color): Likewise.
7137
ffe57a7a
AA
7138 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7139 contents (Bug#9176).
7140 (EmacsTooltip -init): Remove bezels and add shadows to
7141 tooltip windows.
7142
bf3492a5
AA
7143 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7144 or scroll bar (Bug#8470).
7145
d55e9c53
AA
7146 * nsfont.m (nsfont_open): Remove assignment to voffset and
7147 unnecessary vars hshink, expand, hd, full_height, min_height.
7148 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7149
7150 * nsterm.h (nsfont_info): Remove voffset field.
7151
d8c2fa78 71522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7153
7154 Implement strike-through and overline on NextStep (Bug#8863).
7155
7156 * nsfont.m (nsfont_open): Use underline position provided by font,
7157 instead of hard-coded value of 2.
7158 (nsfont_draw): Call ns_draw_text_decoration instead.
7159
7160 * nsterm.h: Add declaration for ns_draw_text_decoration.
7161
7162 * nsterm.m (ns_draw_text_decoration): New function for drawing
7163 underline, overline, and strike-through.
7164 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7165 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7166 accommodate underlining, etc.
4843aac3 7167
4cc60b9b
EZ
71682011-07-28 Eli Zaretskii <eliz@gnu.org>
7169
bc7ece87
EZ
7170 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7171 default.
4cc60b9b 7172
476371c4
PE
71732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7174
66606eea
PE
7175 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7176 Without this fix, if a signal arrives just after memory fills up,
7177 'malloc' might be invoked reentrantly.
7178
476371c4
PE
7179 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7180 In other words, assume that every image size is allowed, on non-X
7181 hosts. This assumption is probably wrong, but it lets Emacs compile.
7182
f3fcc40d
AS
71832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7184
7185 * regex.c (re_iswctype): Convert return values to boolean.
7186
350c992f
EZ
71872011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7188
7189 * xdisp.c (compute_display_string_pos): Don't use cached display
7190 string position if the buffer had its restriction changed.
7191 (Bug#9184)
7192
5266b4bb
PE
71932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7194
7195 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7196
2573a837 71972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7198
41f55ccd 7199 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7200
39e378da
PE
7201 * bidi.c: Integer size and overflow fixes.
7202 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7203 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7204 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7205 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7206 (bidi_find_other_level_edge):
7207 Use ptrdiff_t instead of EMACS_INT where either will do.
7208 This works better on 32-bit hosts configured --with-wide-int.
7209 (bidi_cache_ensure_space): Check for size-calculation overflow.
7210 Use % rather than repeated addition, for better worst-case speed.
7211 Don't set bidi_cache_size until after xrealloc returns, because it
7212 might not return.
7213 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7214 (bidi_cache_ensure_space): Also check that the bidi cache size
7215 does not exceed that of the largest Lisp string or buffer. See Eli
7216 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7217
5e927815
PE
7218 * alloc.c (__malloc_size_t): Remove.
7219 All uses replaced by size_t. See Andreas Schwab's note
7220 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7221
ca4aa935
PE
7222 * image.c: Improve checking for integer overflow.
7223 (check_image_size): Assume that f is nonnull, since
7224 it is always nonnull in practice. This is one less thing to
7225 worry about when checking for integer overflow later.
7226 (x_check_image_size): New function, which checks for integer
7227 overflow issues inside X.
7228 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7229 This removes the need for a memory_full check.
7230 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7231 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7232 (xbm_read_bitmap_data): Change locals back to 'int', since
7233 their values must fit in 'int'.
7234 (xpm_load_image, png_load, tiff_load):
7235 Invoke x_create_x_image_and_pixmap earlier,
7236 to avoid much needless work if the image is too large.
7237 (tiff_load): Treat overly large images as if
7238 x_create_x_image_and_pixmap failed, not as malloc failures.
7239 (gs_load): Use x_check_image_size.
7240
5f8f9cc2
PE
7241 * gtkutil.c: Omit integer casts.
7242 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7243 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7244
5adf60bc
PE
7245 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7246
c8907a93
PE
7247 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7248 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7249 would wrongly return t on a 64-bit host.
7250
e3c25c68
PE
7251 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7252 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7253 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7254 and therefore cause GCC to emit a bogus diagnostic in some cases.
7255
3f791afe
PE
7256 * image.c: Integer signedness and overflow and related fixes.
7257 This is not an exhaustive set of fixes, but it's time to
7258 record what I've got.
7259 (lookup_pixel_color, check_image_size): Remove redundant decls.
7260 (check_image_size): Don't assume that arbitrary EMACS_INT values
7261 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7262 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7263 (tiff_load, imagemagick_load_image):
7264 Check for overflow in size calculations.
7265 (x_create_x_image_and_pixmap): Remove unnecessary test for
7266 xmalloc returning NULL; that can't happen.
7267 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7268 (xpm_color_bucket): Use better integer hashing function.
7269 (xpm_cache_color): Don't possibly over-allocate memory.
7270 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7271 (gif_memory_source):
7272 Use ptrdiff_t, not int or size_t, to record sizes.
7273 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7274 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7275 either works, as we prefer signed integers.
7276 (tiff_read_from_memory, tiff_write_from_memory):
7277 Return tsize_t, not size_t, since that's what the TIFF API wants.
7278 (tiff_read_from_memory): Don't fail simply because the read would
7279 go past EOF; instead, return a short read.
7280 (tiff_load): Omit no-longer-needed casts.
7281 (Fimagemagick_types): Don't assume size fits into 'int'.
7282
3cc5a532
PE
7283 Improve hashing quality when configured --with-wide-int.
7284 * fns.c (hash_string): New function, taken from sxhash_string.
7285 Do not discard information about ASCII character case; this
7286 discarding is no longer needed.
7287 (sxhash-string): Use it. Change sig to match it. Caller changed.
7288 * lisp.h: Declare it.
7289 * lread.c (hash_string): Remove, since we now use fns.c's version.
7290 The fns.c version returns a wider integer if --with-wide-int is
7291 specified, so this should help the quality of the hashing a bit.
7292
b312a492
PE
7293 * emacs.c: Integer overflow minor fix.
7294 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7295 Define only if GNU_LINUX.
7296 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7297
dfd153ae
PE
7298 * dispnew.c: Integer signedness and overflow fixes.
7299 Remove unnecessary forward decls, that were a maintenance hassle.
7300 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7301 All uses changed.
7302 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7303 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7304 (prepare_desired_row, line_draw_cost):
7305 Use int, not unsigned, where either works.
7306 (save_current_matrix, restore_current_matrix):
7307 Use ptrdiff_t, not size_t, where either works.
7308 (init_display): Check for overflow more accurately, and without
7309 relying on undefined behavior.
7310
a81d11a3
PE
7311 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7312 Remove, replacing with the new symbols in lisp.h. All uses changed.
7313 * fileio.c (make_temp_name):
7314 * filelock.c (lock_file_1, lock_file):
7315 * xdisp.c (message_dolog):
7316 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7317 Use pMd etc. instead.
7318 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7319 replacing the pWIDE etc. symbols removed from editfns.c.
7320
3300e6fd
PE
7321 * keyboard.h (num_input_events): Now uintmax_t.
7322 This is (very slightly) less likely to mess up due to wraparound.
7323 All uses changed.
7324
fd05c7e9
PE
7325 * buffer.c: Integer signedness fixes.
7326 (alloc_buffer_text, enlarge_buffer_text):
7327 Use ptrdiff_t rather than size_t when either will do, as we prefer
7328 signed integers.
7329
903fe15d
PE
7330 * alloc.c: Integer signedness and overflow fixes.
7331 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7332 (__malloc_size_t): Default to size_t, not to int.
7333 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7334 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7335 Prefer ptrdiff_t to size_t when either would do, as we prefer
7336 signed integers.
7337 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7338 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7339 Now const. Initialize with values that are in range even if char
7340 is signed.
7341 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7342 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7343 These functions do the right thing with sizes > 2**32.
7344 (check_depth): Now ptrdiff_t, not int.
7345 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7346 Adjust to new way of storing sizes. Check for size overflow bugs
7347 in rest of code.
7348 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7349 slightly wrong anyway, as it missed one instance of
7350 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7351 (refill_memory_reserve): Omit needless cast to size_t.
7352 (mark_object_loop_halt): Mark as externally visible.
7353
ac82cc6a
PE
7354 * xselect.c: Integer signedness and overflow fixes.
7355 (Fx_register_dnd_atom, x_handle_dnd_message):
7356 Use ptrdiff_t, not size_t, since we prefer signed.
7357 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7358 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7359 x_dnd_atoms_size and x_dnd_atoms_length.
7360
c2d1e36d
PE
7361 * doprnt.c: Prefer signed to unsigned when either works.
7362 * eval.c (verror):
7363 * doprnt.c (doprnt):
7364 * lisp.h (doprnt):
7365 * xdisp.c (vmessage):
7366 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7367 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7368 prefer signed arithmetic to avoid comparison confusion.
7369 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7370 but is a bit tricky.
7371
0e926e56
PE
7372 Assume freestanding C89 headers, string.h, stdlib.h.
7373 * data.c, doprnt.c, floatfns.c, print.c:
7374 Include float.h unconditionally.
7375 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7376 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7377 * regex.c: Likewise for stddef.h, string.h.
7378 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7379 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7380 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7381 (STDC_HEADERS): Remove obsolete defines.
7382 * sysdep.c: Include limits.h unconditionally.
7383
9cfdb3ec
PE
7384 Assume support for memcmp, memcpy, memmove, memset.
7385 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7386 * regex.c (memcmp, memcpy):
7387 Remove; we assume C89 now.
7388
7389 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7390 (__malloc_safe_bcopy): Remove; no longer needed.
7391
cf950e6b 7392 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7393 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7394 well either way, and we prefer signed to unsigned.
7395
dbf38e02
LMI
73962011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7397
7398 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7399 closes the connection while we're reading (bug#9182).
7400
d6f0886c 74012011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7402
d6f0886c
JD
7403 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7404 are specified (Bug#9168).
24e0f6b1 7405
2eb1f9e6
PE
74062011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7407
7408 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7409 Found by GCC static checking and --with-wide-int on a 32-bit host.
7410
22381272 74112011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7412
7413 * xdisp.c (compute_display_string_pos): Fix logic of caching
7414 previous display string position. Initialize cached_prev_pos to
7415 -1. Fixes slow-down at the beginning of a buffer.
7416
f25e39b4
EZ
74172011-07-24 Eli Zaretskii <eliz@gnu.org>
7418
7419 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7420 for attrs[LFACE_FONTSET_INDEX].
7421
04c4b52e
PE
74222011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7423
7424 * xml.c (parse_region): Remove unused local
7425 that was recently introduced.
7426
c1734fbd
EZ
74272011-07-23 Eli Zaretskii <eliz@gnu.org>
7428
be18c5a5
EZ
7429 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7430 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7431
c1734fbd
EZ
7432 * xdisp.c (move_it_in_display_line_to): Record the best matching
7433 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7434 exit if none of the characters scanned was an exact match.
7435 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7436 when exact match is impossible due to invisible text, and the
7437 lines are truncated.
7438
a258d627
JD
74392011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7440
7441 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7442 for OSX >= 10.7.
7443
b6d5a689
EZ
74442011-07-22 Eli Zaretskii <eliz@gnu.org>
7445
0f74f785
EZ
7446 Fix a significant slow-down of cursor motion with C-n, C-p,
7447 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7448 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7449 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7450 (next_element_from_buffer): Call compute_stop_pos_backwards to
7451 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7452 base_level_stop.
7453 (reseat): Don't look for prev_stop, as that could mean a very long
7454 run.
7455 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7456 <cached_disp_overlay_modiff>: Cache for last found display string
7457 position.
551918c1 7458 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7459 about the same buffer in the same area of character positions, and
7460 the buffer wasn't changed since the time the display string
7461 position was cached.
551918c1 7462
b2d0c91a
EZ
74632011-07-22 Eli Zaretskii <eliz@gnu.org>
7464
7465 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7466 is an integer, which is important for empty lines. (Bug#9149)
7467
043604ee
CY
74682011-07-22 Chong Yidong <cyd@stupidchicken.com>
7469
7470 * frame.c (Fmodify_frame_parameters): In tty case, update the
7471 default face if necessary (Bug#4238).
7472
da4adb04
CY
74732011-07-21 Chong Yidong <cyd@stupidchicken.com>
7474
7475 * editfns.c (Fstring_to_char): No need to explain what a character
7476 is in the docstring (Bug#6576).
7477
9abd0532
LMI
74782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7479
7480 * xml.c (parse_region): Make sure we always return a tree.
7481
36881d16
HK
74822011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7483
7484 * xml.c (parse_region): If a document contains only comments,
7485 return that, too.
7486
1e98674d
LMI
74872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7488
7489 * xml.c (make_dom): Return comments, too.
7490
590bd467
PE
74912011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7492
7493 Port to OpenBSD.
7494 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7495 and the surrounding thread.
7496 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7497 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7498 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7499 timer goes off.
7500 * s/openbsd.h (BROKEN_SIGIO): Define.
7501 * unexelf.c (unexec) [__OpenBSD__]:
7502 Don't update the .mdebug section of the Alpha COFF symbol table.
7503
f41628b2
LMI
75042011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7505
7506 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7507 (bug#8460).
7508
b59b67c5
PE
75092011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7510
15e3a074
PE
7511 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7512 This fixes some race conditions on the permissions of any newly
7513 created file.
7514
41bed37d
PE
7515 * alloc.c (valid_pointer_p): Use pipe, not open.
7516 This fixes some permissions issues when debugging.
7517
b59b67c5
PE
7518 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7519 If fchown fails to set both uid and gid, try to set just gid,
7520 as that is sometimes allowed. Adjust the file's mode to eliminate
7521 setuid or setgid bits that are inappropriate if fchown fails.
7522
925a6be7
SM
75232011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7524
7525 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7526 to compare Lisp_Objects.
7527 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7528 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7529 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7530
52968808
AS
75312011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7532
0a6a104b
AS
7533 * lread.c (read_integer): Unread even EOF character.
7534 (read1): Likewise. Properly record start position of symbol.
7535
52968808
AS
7536 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7537 symbol character follows.
7538
9e381cdd
PE
75392011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7540
7541 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7542 This works around a problem with the previous change to Fcopy_file.
7543 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7544 and without this change, GCC might complain about discarding
7545 fchown's return value.
7546
b5641435
JB
75472011-07-16 Juanma Barranquero <lekktu@gmail.com>
7548
7549 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7550
a8031457
PE
75512011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7552
7553 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7554
dd889327
LMI
75552011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7556
750c33f7
LMI
7557 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7558 it's used from the C level.
7559
dd889327
LMI
7560 * process.c: Use the same condition for POLL_FOR_INPUT in both
7561 keyboard.c and process.c (bug#1858).
7562
87e86684
LM
75632011-07-09 Lawrence Mitchell <wence@gmx.li>
7564
7565 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7566 (Fgnutls_boot): Use it.
7567
64348f40
AS
75682011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7569
7570 * doc.c (Fsubstitute_command_keys): Revert last change.
7571
1d698799
LMI
75722011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7573
f863868c
LMI
7574 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7575 quotes the next character, and doesn't affect other longer
7576 sequences (bug#8935).
7577
1d698799
LMI
7578 * lread.c (syms_of_lread): Clarify that is isn't only
7579 `eval-buffer' and `eval-defun' that's affected by
7580 `lexical-binding' (bug#8460).
7581
aa4b6df6
EZ
75822011-07-15 Eli Zaretskii <eliz@gnu.org>
7583
7584 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7585 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7586
5d856da6
PE
75872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7588
ad6042bb
PE
7589 Fix minor problems found by static checking.
7590 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7591 (elsz): Now a signed constant, not a size_t var. We prefer signed
7592 types to unsigned, to avoid integer comparison confusion. Without
7593 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7594 "cannot optimize loop, the loop counter may overflow", a symptom
7595 of the confusion.
f00bbb22 7596 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7597 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7598
6468f31c
LMI
75992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7600
49080b10
LMI
7601 * search.c (Fre_search_backward): Mention `case-fold-search' in
7602 all the re_search_* functions (bug#8138).
7603
6468f31c
LMI
7604 * keyboard.c (Fopen_dribble_file): Document when the file is
7605 closed (bug#8056).
7606
c965adc5
EZ
76072011-07-14 Eli Zaretskii <eliz@gnu.org>
7608
df9733bf
EZ
7609 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7610 bidi_cache_idx.
7611
0bb23927
EZ
7612 Support bidi reordering of display and overlay strings.
7613 * xdisp.c (compute_display_string_pos)
7614 (compute_display_string_end): Accept additional argument STRING.
7615 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7616 (reseat_to_string): Initialize bidi_it->string.s and
7617 bidi_it->string.schars.
7618 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7619 NULL (avoids a crash in bidi_paragraph_init).
7620 Initialize itb.string.lstring.
0bb23927
EZ
7621 (init_iterator): Call bidi_init_it only of a valid
7622 buffer position was specified. Initialize paragraph_embedding to
7623 L2R.
7624 (reseat_to_string): Initialize the bidi iterator.
7625 (display_string): If we need to ignore text properties of
7626 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7627 original value of -1 will not work with bidi.)
7628 (compute_display_string_pos): First arg is now struct
7629 `text_pos *'; all callers changed. Support display properties on
7630 Lisp strings.
7631 (compute_display_string_end): Support display properties on Lisp
7632 strings.
7633 (init_iterator, reseat_1, reseat_to_string): Initialize the
7634 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7635 when iterating on a string not from display properties).
640c8776
SM
7636 (compute_display_string_pos, compute_display_string_end):
7637 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7638 arrow keys.
7639 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7640 base_level_stop; instead, set base_level_stop to BEGV.
7641 Fixes crashes in vertical-motion.
0bb23927
EZ
7642 (next_element_from_buffer): Improve commentary for when
7643 the iterator is before prev_stop.
7644 (init_iterator): Initialize bidi_p from the default value of
7645 bidi-display-reordering, not from buffer-local value. Use the
7646 buffer-local value only if initializing for buffer iteration.
7647 (handle_invisible_prop): Support invisible properties on strings
7648 that are being bidi-reordered.
7649 (set_iterator_to_next): Support bidi reordering of C strings and
7650 Lisp strings.
7651 (next_element_from_string): Support bidi reordering of Lisp
7652 strings.
7653 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7654 (display_string): Support display of R2L glyph rows.
7655 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7656 (init_iterator): Don't initialize it->bidi_p for strings
7657 here.
7658 (reseat_to_string): Initialize it->bidi_p for strings here.
7659 (next_element_from_string, next_element_from_c_string)
7660 (next_element_from_buffer): Add xassert's for correspondence
7661 between IT's object being iterated and it->bidi_it.string
7662 structure.
7663 (face_before_or_after_it_pos): Support bidi iteration.
7664 (next_element_from_c_string): Handle the case of the first string
7665 character that is not the first one in the visual order.
7666 (get_visually_first_element): New function, refactored from common
7667 parts of next_element_from_buffer, next_element_from_string, and
7668 next_element_from_c_string.
7669 (tool_bar_lines_needed, redisplay_tool_bar)
7670 (display_menu_bar): Force left-to-right direction. Add a FIXME
7671 comment for making that be controlled by a user option.
7672 (push_it, pop_it): Save and restore the state of the
7673 bidi iterator. Save and restore the bidi_p flag.
7674 (pop_it): Iterate out of display property for string iteration as
7675 well.
7676 (iterate_out_of_display_property): Support iteration over strings.
7677 (handle_single_display_spec): Set up it->bidi_it for iteration
7678 over a display string, and call bidi_init_it.
7679 (handle_single_display_spec, next_overlay_string)
7680 (get_overlay_strings_1, push_display_prop): Set up the bidi
7681 iterator for displaying display or overlay strings.
7682 (forward_to_next_line_start): Don't use the shortcut if
7683 bidi-iterating.
7684 (back_to_previous_visible_line_start): If handle_display_prop
7685 pushed the iterator stack, restore the internal state of the bidi
7686 iterator by calling bidi_pop_it same number of times.
7687 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7688 and we are bidi-iterating, don't decrement the iterator position;
7689 instead, set the first_elt flag in the bidi iterator, to produce
7690 the same effect.
7691 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7692 (push_display_prop): xassert that we are iterating a buffer.
7693 (push_it, pop_it): Save and restore paragraph_embedding member.
7694 (handle_single_display_spec, next_overlay_string)
7695 (get_overlay_strings_1, reseat_1, reseat_to_string)
7696 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7697 correctly. Don't assume unibyte strings are not bidi-reordered.
7698 (compute_display_string_pos)
7699 (compute_display_string_end): Fix handling the case of C string.
7700 (push_it, pop_it): Save and restore from_disp_prop_p.
7701 (handle_single_display_spec, push_display_prop): Set the
7702 from_disp_prop_p flag.
7703 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7704 (pop_it): Call iterate_out_of_display_property only if we are
7705 popping after iteration over a string that came from a display
7706 property. Fix a typo in popping stretch info. Add an assertion
7707 for verifying that the iterator position is in sync with the bidi
7708 iterator.
7709 (handle_single_display_spec, get_overlay_strings_1)
7710 (push_display_prop): Fix initialization of paragraph direction for
7711 string when that of the parent object is not yet determined.
7712 (reseat_1): Call bidi_init_it to resync the bidi
7713 iterator with IT's position. (Bug#7616)
7714 (find_row_edges): If ROW->start.pos gives position
7715 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7716 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7717 Reset the from_disp_prop_p flag.
7718 (SAVE_IT, RESTORE_IT): New macros.
7719 (pos_visible_p, face_before_or_after_it_pos)
7720 (back_to_previous_visible_line_start)
7721 (move_it_in_display_line_to, move_it_in_display_line)
7722 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7723 (try_scrolling, redisplay_window, display_line): Use them when
7724 saving a temporary copy of the iterator and restoring it back.
7725 (back_to_previous_visible_line_start, reseat_1)
7726 (init_iterator): Empty the bidi cache "stack".
7727 (move_it_in_display_line_to): If iterator ended up at
7728 EOL, but we never saw any buffer positions smaller than
7729 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7730 motion in bidi-reordered lines.
7731 (move_it_in_display_line_to): Record prev_method and prev_pos
7732 immediately before the call to set_iterator_to_next. Fixes cursor
7733 motion in bidi-reordered lines with stretch glyphs and strings
7734 displayed in margins. (Bug#8133) (Bug#8867)
7735 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7736 TO_CHARPOS.
640c8776
SM
7737 (pos_visible_p): Support positions in bidi-reordered lines.
7738 Save and restore bidi cache.
0bb23927
EZ
7739
7740 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7741 (bidi_paragraph_info): Delete unused struct.
7742 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7743 (bidi_cache_start): New variable.
7744 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7745 to zero.
7746 (bidi_cache_fetch_state, bidi_cache_search)
7747 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7748 (bidi_cache_find, bidi_peek_at_next_level)
7749 (bidi_level_of_next_char, bidi_find_other_level_edge)
7750 (bidi_move_to_visually_next): Compare cache index with
7751 bidi_cache_start rather than with zero.
7752 (bidi_fetch_char): Accept new argument STRING; all callers
7753 changed. Support iteration over a string. Support strings with
7754 display properties. Support unibyte strings. Fix the type of
7755 `len' according to what STRING_CHAR_AND_LENGTH expects.
7756 (bidi_paragraph_init, bidi_resolve_explicit_1)
7757 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7758 (bidi_level_of_next_char, bidi_move_to_visually_next):
7759 Support iteration over a string.
0bb23927
EZ
7760 (bidi_set_sor_type, bidi_resolve_explicit_1)
7761 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7762 can now be zero (for strings); special values 0 and -1 were
7763 changed to -1 and -2, respectively.
7764 (bidi_char_at_pos): New function.
7765 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7766 Call it instead of FETCH_MULTIBYTE_CHAR.
7767 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7768 initialized to valid values.
7769 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7770 values.
7771 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7772 the test for valid cached positions. Fix the logic for looking up
7773 the sentinel state in the cache. GCPRO the Lisp string we are
7774 iterating.
7775 (bidi_push_it, bidi_pop_it): New functions.
7776 (bidi_initialize): Initialize the bidi cache start stack pointer.
7777 (bidi_cache_ensure_space): New function, refactored from part of
7778 bidi_cache_iterator_state. Don't assume the required size is just
7779 one BIDI_CACHE_CHUNK away.
7780 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7781 (bidi_count_bytes, bidi_char_at_pos): New functions.
7782 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7783 always valid if bidi_cache_idx is valid.
7784 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7785 is valid if it's going to be used.
7786 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7787 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7788 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7789 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7790 (bidi_find_other_level_edge, bidi_cache_start_stack):
7791 All variables related to cache indices are now EMACS_INT.
c965adc5 7792
0bb23927
EZ
7793 * dispextern.h (struct bidi_string_data): New structure.
7794 (struct bidi_it): New member `string'. Make flag members be 1-bit
7795 fields, and put them last in the struct.
640c8776
SM
7796 (compute_display_string_pos, compute_display_string_end):
7797 Update prototypes.
0bb23927
EZ
7798 (bidi_push_it, bidi_pop_it): Add prototypes.
7799 (struct iterator_stack_entry): New members bidi_p,
7800 paragraph_embedding, and from_disp_prop_p.
7801 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7802 (bidi_shelve_cache, bidi_unshelve_cache):
7803 Declare prototypes.
0bb23927
EZ
7804
7805 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7806 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7807 and vector-like objects.
7808
7809 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7810 cache around display iteration.
7811
7812 * window.c (Fwindow_end, window_scroll_pixel_based)
7813 (displayed_window_lines, Frecenter): Save and restore the bidi
7814 cache around display iteration.
7815
3bbd2265
LMI
78162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7817
7818 * editfns.c (Fdelete_region): Clarify the use of the named
7819 parameters (bug#6788).
7820
adc47434
MR
78212011-07-14 Martin Rudalics <rudalics@gmx.at>
7822
7823 * indent.c (Fvertical_motion): Set and restore w->pointm when
7824 saving and restoring the window's buffer (Bug#9006).
7825
837c31f8
LMI
78262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7827
7828 * editfns.c (Fstring_to_char): Clarify just what is returned
7829 (bug#6576). Text by Eli Zaretskii.
7830
ac389d0c
JB
78312011-07-13 Juanma Barranquero <lekktu@gmail.com>
7832
7833 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7834
0be0ce47
EZ
78352011-07-13 Eli Zaretskii <eliz@gnu.org>
7836
7837 * buffer.c (mmap_find): Fix a typo.
7838
cd18e7e3
JB
78392011-07-13 Johan Bockgård <bojohan@gnu.org>
7840
7841 Fix execution of x selection hooks.
7842 * xselect.c (Qx_lost_selection_functions)
7843 (Qx_sent_selection_functions): New vars.
7844 (syms_of_xselect): DEFSYM them.
7845 (x_handle_selection_request): Pass Qx_sent_selection_functions
7846 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7847 (x_handle_selection_clear,x_clear_frame_selections):
7848 Pass Qx_lost_selection_functions rather than
7849 Vx_lost_selection_functions to Frun_hook_with_args.
7850
47ea7f44
PE
78512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7852
ac389d0c 7853 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7854 The old code sometimes used this field without initializing it.
7855
47ea7f44
PE
7856 * alloc.c (gc_sweep): Don't read past end of array.
7857 In theory, the old code could also have corrupted Emacs internals,
7858 though it'd be very unlikely.
7859
bc985c87
AS
78602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7861
7862 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7863 argument. (Bug#4026)
bc985c87 7864
0cf34688
LMI
78652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7866
b3dadd76
LMI
7867 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7868 key" (bug#4257).
7869
0cf34688
LMI
7870 * window.c (Fset_window_start): Doc fix (bug#4199).
7871 (Fset_window_hscroll): Ditto.
7872
270768cd
PE
78732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7874
077e3dda 7875 Fix minor new problems caught by GCC 4.6.1.
270768cd 7876 * term.c (init_tty): Remove unused local.
490011a6 7877 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7878 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7879 not used otherwise.
270768cd 7880
b1f58454
CY
78812011-07-12 Chong Yidong <cyd@stupidchicken.com>
7882
7883 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7884
22b9578d
LMI
78852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7886
6e70ab07
LMI
7887 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7888 are the mini-buffer and the echo area (bug#3320).
7889
22b9578d
LMI
7890 * term.c (init_tty): Remove support for supdup, c10 and perq
7891 terminals, which are no longer supported (bug#1482).
7892
8974cc9f
JB
78932011-07-10 Johan Bockgård <bojohan@gnu.org>
7894
7895 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7896
a560d974
JD
78972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7898
7899 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7900 for non-popups (Bug#3642).
7901
1dae0f0a
AS
79022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7903
268c2c36 7904 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7905 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7906 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7907 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7908 * data.c (fmod): Likewise.
7909 * dispnew.c (swap_glyphs_in_rows): Likewise.
7910 * emacs.c (memory_warning_signal): Likewise.
7911 * floatfns.c (float_error): Likewise.
7912 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7913 (otf_open, font_otf_capability, generate_otf_features)
7914 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7915 Likewise.
7916 * image.c (pbm_read_file): Likewise.
7917 * indent.c (string_display_width): Likewise.
7918 * intervals.c (check_for_interval, search_for_interval)
7919 (inc_interval_count, count_intervals, root_interval)
7920 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7921 * lread.c (defalias): Likewise.
268c2c36 7922 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7923 * regex.c (set_image_of_range_1, set_image_of_range)
7924 (regex_grow_registers): Likewise.
7925 * sysdep.c (strerror): Likewise.
7926 * termcap.c (valid_filename_p, tprint, main): Likewise.
7927 * tparam.c (main): Likewise.
7928 * unexhp9k800.c (run_time_remap, save_data_space)
7929 (update_file_ptrs, read_header, write_header, calculate_checksum)
7930 (copy_file, copy_rest, display_header): Likewise.
7931 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7932 Likewise.
7933 * xdisp.c (check_it): Likewise.
7934 * xfaces.c (register_color, unregister_color, unregister_colors):
7935 Likewise.
7936 * xfns.c (print_fontset_result): Likewise.
7937 * xrdb.c (member, fatal, main): Likewise.
7938
99033785
PE
79392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7940
7941 Fix minor problems found by static checking (Bug#9031).
7942 * chartab.c (char_table_set_range, map_sub_char_table):
7943 Remove unused locals.
7944 (uniprop_table): Now static.
7945 * composite.c (_work_char): Remove unused static var.
7946
9cb2ac56
JB
79472011-07-09 Juanma Barranquero <lekktu@gmail.com>
7948
7949 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7950
f25661f0
JD
79512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7952
7953 * gtkutil.c (qttip_cb): Remove code without function.
7954
8278c4fe
EZ
79552011-07-09 Eli Zaretskii <eliz@gnu.org>
7956
7957 * w32.c (pthread_sigmask): New stub.
7958
1692ae2d 79592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7960
8a6ebd58 7961 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7962 sigprocmask is portable only for single-threaded applications, and
7963 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7964 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7965 (LIBES): Use it.
7966 * callproc.c (Fcall_process):
7967 * process.c (create_process):
7968 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7969 Use pthread_sigmask, not sigprocmask.
123403e4 7970
1b854618
JD
79712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7972
7973 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7974 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7975 wrong (Bug#8591).
7976
3fe4b549
JD
79772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7978
0ce7e563
JD
7979 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7980 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7981 (xg_hide_tooltip): Fix comment.
7982
3fe4b549
JD
7983 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7984 in registerServicesMenuSendTypes.
7985 (validRequestorForSendType): Don't check ns_return_types.
7986
7987 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7988 ns_return_type.
7989
5df75e47
JR
79902011-07-08 Jason Rumney <jasonr@gnu.org>
7991
22610910
JR
7992 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7993 SH_SHOW for hidden windows (Bug#5482).
7994
5df75e47
JR
7995 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7996 frame struct members of non-existent frames (Bug#6284).
7997
699c10bd
JD
79982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7999
4393663b
JD
8000 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8001 variable firstTime not needed on OSX >= 10.6.
8002 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8003 >= 10.5. Use setKnobProportion, setDoubleValue.
8004
8005 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8006 (MAC_OS_X_VERSION_10_5): Define if not defined.
8007 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8008 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8009 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8010
8011 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8012 cString and lossyCString on OSX >= 10.4.
4393663b 8013
58179cce 8014 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8015 sizeToFit on OSX >= 10.2.
8016
8017 * nsimage.m (allocInitFromFile): Don't use deprecated method
8018 bestRepresentationForDevice on OSX >= 10.6.
8019
8020 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8021 to avoid warning.
8022
8023 * emacs.c: Declare unexec_init_emacs_zone.
8024
a63e0781
JD
8025 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8026
699c10bd
JD
8027 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8028
8029 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8030 on svcsMenu (Bug#8842).
8031
8032 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8033 ns_return_types.
8034 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8035
8036 * nsterm.m (QUTF8_STRING): Declare.
8037 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8038 (validRequestorForSendType): Return type is (id).
8039 Change indexOfObjectIdenticalTo to indexOfObject.
8040 Check if we have local selection before returning self (Bug#8842).
8041 (writeSelectionToPasteboard): Put local selection into paste board
8042 if we have a local selection (Bug#8842).
8043 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8044
8045 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8046 (ns_get_local_selection): Declare.
8047
54e10184
LMI
80482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8049
9888ff71
LMI
8050 * keymap.c (describe_map_tree): Don't insert a double newline at
8051 the end of the buffer (bug#1169) and return whether we inserted
8052 something.
8053
54e10184
LMI
8054 * callint.c (Fcall_interactively): Change "reading args" to
8055 "providing args" to try to clarify what it does (bug#1010).
8056
15fa4783
KH
80572011-07-07 Kenichi Handa <handa@m17n.org>
8058
8059 * composite.c (composition_compute_stop_pos): Ignore a static
8060 composition starting before CHARPOS (Bug#8915).
8061
8062 * xdisp.c (handle_composition_prop): Likewise.
8063
a8815b00
EZ
80642011-07-07 Eli Zaretskii <eliz@gnu.org>
8065
8066 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8067 (Bug#9015)
8068
ef7b981d 80692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8070
8071 * character.h (unicode_category_t): New enum type.
8072
8073 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8074 (Qchar_code_property_table): New variable.
8075 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8076 (UNIPROP_COMPRESSED_FORM_P): New macros.
8077 (char_table_ascii): Uncompress the compressed values.
8078 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8079 Uncompress the compressed values.
ac389d0c 8080 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8081 (char_table_ref_and_range): Uncompress the compressed values.
8082 (sub_char_table_set): New arg is_uniprop. Callers changed.
8083 Uncompress the compressed values.
8084 (sub_char_table_set_range): Args changed. Callers changed.
8085 (char_table_set_range): Adjuted for the above change.
8086 (map_sub_char_table): Delete args default_val and parent. Add arg
8087 top. Give decoded values to a Lisp function.
640c8776 8088 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8089 values to a Lisp function. Gcpro more variables.
8090 (uniprop_table_uncompress)
8091 (uniprop_decode_value_run_length): New functions.
8092 (uniprop_decoder, uniprop_decoder_count): New variables.
8093 (uniprop_get_decoder, uniprop_encode_value_character)
8094 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8095 New functions.
8096 (uniprop_encoder, uniprop_encoder_count): New variables.
8097 (uniprop_get_encoder, uniprop_table)
8098 (Funicode_property_table_internal, Fget_unicode_property_internal)
8099 (Fput_unicode_property_internal): New functions.
8100 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8101 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8102 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8103 char-code-property-alist.
8104
640c8776 8105 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8106 Vunicode_category_table.
8107
640c8776 8108 * font.c (font_range): Adjust for the change of
c805dec0
KH
8109 Vunicode_category_table.
8110
76b397fb
DN
81112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8112
8113 * m/iris4d.h: Remove file, move contents ...
8114 * s/irix6-5.h: ... here.
8115
22b4128e
PE
81162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8117
8118 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8119 * alloc.c (mark_buffer):
8120 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8121 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8122 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8123 This isn't true in general, and it's particularly not true
8124 if Emacs is configured with --with-wide-int.
8125 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8126 New macros, used in the buffer.c change.
8127
869795d6
JD
81282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8129
8130 * xsettings.c: Use both GConf and GSettings if both are available.
8131 (store_config_changed_event): Add comment.
8132 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8133 (store_tool_bar_style_changed): New functions.
5e617bc2 8134 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8135 (struct xsettings): Move font inside HAVE_XFT.
8136 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8137 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8138 Move inside HAVE_XFT.
640c8776 8139 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8140 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8141 also.
8142 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8143 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8144 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8145 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8146 (parse_settings): Move check for font inside HAVE_XFT.
8147 (read_settings, apply_xft_settings): Add comment.
8148 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8149 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8150 call store_font_name_changed.
8151 (xft_settings_event): Add comment.
8152 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8153 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8154 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8155 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8156 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8157 (xsettings_get_system_font, xsettings_get_system_normal_font):
8158 Add comment.
869795d6 8159
d8ed26bd
PE
81602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8161
8162 Random fixes. E.g., (random) never returned negative values.
8163 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8164 subseconds part to the entropy, as that's a bit more random.
8165 Prefer signed to unsigned, since the signedness doesn't matter and
8166 in general we prefer signed. When given a limit, use a
8167 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8168 latter isn't right if USE_2_TAGS_FOR_INTS.
8169 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8170 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8171
cabf1cac
SM
81722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8173
8174 * textprop.c (text_property_stickiness):
8175 Obey Vtext_property_default_nonsticky.
8176 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8177 * w32fns.c (syms_of_w32fns):
8178 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8179
6e9b2be9
PE
81802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8181
8182 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8183 This is more efficient than Ffile_directory_p and avoids a minor race.
8184
90186c68
LMI
81852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8186
7c301272
LMI
8187 * buffer.c (Foverlay_put): Say what the return value is
8188 (bug#7835).
8189
c4f2d8d4
LMI
8190 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8191 is a directory before asking whether to use the file name
8192 (bug#7564).
ad637907
LMI
8193 (barf_or_query_if_file_exists): Make the "File is a directory"
8194 error be more correct.
c4f2d8d4 8195
90186c68
LMI
8196 * fns.c (Frequire): Remove the mention of the .gz files, since
8197 that's installation-specific, but keep the mention of
8198 `get-load-suffixes'.
8199
da64016e
PE
82002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8201
8202 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8203 Report string overflow if the output is too long.
8204
7d47b580
JB
82052011-07-04 Juanma Barranquero <lekktu@gmail.com>
8206
a555cb87
JB
8207 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8208 (syms_of_gnutls): Remove duplicate DEFSYM for
8209 Qgnutls_bootprop_verify_hostname_error, an error for
8210 Qgnutls_bootprop_verify_error (which is no longer used).
8211
7d47b580
JB
8212 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8213 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8214 Also (re)move comments that are misplaced or no longer relevant.
8215
1e49bfab
LMI
82162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8217
8218 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8219
1485f4c0
CY
82202011-07-03 Chong Yidong <cyd@stupidchicken.com>
8221
8222 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8223 and background color parameters if they have been changed.
8224
a9ab721e
LMI
82252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8226
8227 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8228
cf7cff57
PE
82292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8230
2e13213d
PE
8231 * xsettings.c (SYSTEM_FONT): Define only when used.
8232 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8233
cf7cff57
PE
8234 * keymap.c (access_keymap_1): Now static.
8235
7a8e04f7
CY
82362011-07-02 Chong Yidong <cyd@stupidchicken.com>
8237
8238 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8239 leave any prefix arg for the up event (Bug#1586).
8240
61352f62
LMI
82412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8242
69bb1ef7
LMI
8243 * lread.c (syms_of_lread): Mention single symbols defined by
8244 `defvar' or `defconst' (bug#7154).
8245
61352f62 8246 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8247 (Frequire): Mention get-load-suffixes.
61352f62 8248
28545e04
MR
82492011-07-02 Martin Rudalics <rudalics@gmx.at>
8250
8251 * window.h (window): Remove clone_number slot.
8252 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8253 Remove.
8254 (make_parent_window, make_window, saved_window)
8255 (Fset_window_configuration, save_window_save): Don't deal with
8256 clone numbers.
8257 * buffer.c (Qclone_number): Remove declaration.
8258 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8259
3349e122
SM
82602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8261
8262 Add multiple inheritance to keymaps.
8263 * keymap.c (Fmake_composed_keymap): New function.
8264 (Fset_keymap_parent): Simplify.
8265 (fix_submap_inheritance): Remove.
8266 (access_keymap_1): New function extracted from access_keymap to handle
8267 embedded parents and handle lists of maps.
8268 (access_keymap): Use it.
8269 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8270 (Fcopy_keymap): Handle embedded parents.
8271 (Fcommand_remapping, define_as_prefix): Simplify.
8272 (Fkey_binding): Simplify.
8273 (syms_of_keymap): Move minibuffer-local-completion-map,
8274 minibuffer-local-filename-completion-map,
8275 minibuffer-local-must-match-map, and
8276 minibuffer-local-filename-must-match-map to Elisp.
8277 (syms_of_keymap): Defsubr make-composed-keymap.
8278 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8279 (parse_menu_item): Trivial simplification.
8280
3279eb87
GM
82812011-07-01 Glenn Morris <rgm@gnu.org>
8282
8283 * Makefile.in (SETTINGS_LIBS): Fix typo.
8284
4550efdf
KI
82852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8286
8287 * coding.c (Fencode_coding_string): Record the last coding system
8288 used, as the function doc string says (bug#8738).
8289
0949d2b6
JD
82902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8291
8292 * xsettings.c (store_monospaced_changed): Take new font as arg and
8293 check for change against current_mono_font.
8294 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8295 (emacs_settings_constructor, emacs_settings_get_property)
8296 (emacs_settings_set_property, emacs_settings_class_init)
8297 (emacs_settings_init, gsettings_obj): Remove.
8298 (something_changedCB): New function for HAVE_GSETTINGS.
8299 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8300 with value as argument.
8301 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8302 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8303 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8304 "changed".
8305
8306 * xgselect.c: Add defined (HAVE_GSETTINGS).
8307 (xgselect_initialize): Ditto.
8308
8309 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8310 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8311 xg_select.
8312
bbc6b304
PE
83132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8314
8315 * eval.c (struct backtrace): Simplify and port the data structure.
8316 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8317 signed bit field, as this assumption is not portable and it makes
8318 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8319 "char debug_on_exit : 1" as this is not portable either; instead,
8320 use the portable "unsigned int debug_on_exit : 1". Remove unused
8321 member evalargs. Remove obsolete comments about cc bombing out.
8322
9851bfc5
JD
83232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8324
51bb811f 8325 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8326 Let HAVE_GSETTINGS override HAVE_GCONF.
8327 (store_monospaced_changed): New function.
8328 (EMACS_SETTINGS): A new type derived from GObject to handle
8329 GSettings notifications.
8330 (emacs_settings_constructor, emacs_settings_get_property)
8331 (emacs_settings_set_property, emacs_settings_class_init):
8332 New functions.
8333 (gsettings_client, gsettings_obj): New variables.
8334 (GSETTINGS_SCHEMA): New define.
8335 (something_changedCB): Call store_monospaced_changed.
8336 (init_gsettings): New function.
8337 (xsettings_initialize): Call init_gsettings.
8338 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8339 to NULL.
8340
640c8776 8341 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8342 GCONF_CFLAGS/LIBS.
8343
5386012d
MR
83442011-06-29 Martin Rudalics <rudalics@gmx.at>
8345
8346 * window.c (resize_root_window, grow_mini_window)
8347 (shrink_mini_window): Rename Qresize_root_window to
8348 Qwindow_resize_root_window and Qresize_root_window_vertically to
8349 Qwindow_resize_root_window_vertically.
8350
f13e0b08
PE
83512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8352
8353 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8354
94515237
JB
83552011-06-27 Juanma Barranquero <lekktu@gmail.com>
8356
8357 * makefile.w32-in: Redesign dependencies so they reflect more
8358 clearly which files are directly included by each source file,
8359 and not through other includes.
8360
e43b6e43
MR
83612011-06-27 Martin Rudalics <rudalics@gmx.at>
8362
8363 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8364 (sort_overlays, overlay_strings): When an overlay's clone number
8365 matches the window's clone number process the overlay even if
8366 the overlay's window property doesn't match the current window.
8367
d68443dc
MR
8368 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8369 (Fwindow_hchild): Rename to Fwindow_left_child.
8370 (Fwindow_next): Rename to Fwindow_next_sibling.
8371 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8372 (resize_window_check): Rename to window_resize_check.
8373 (resize_window_apply): Rename to window_resize_apply.
8374 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8375 (Fdelete_other_windows_internal, resize_frame_windows)
8376 (Fsplit_window_internal, Fdelete_window_internal)
8377 (grow_mini_window, shrink_mini_window)
8378 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8379
c7e73be5
JD
83802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8381
8382 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8383 (emacs_fixed_set_min_size): Remove.
8384 (emacs_fixed_new): Take frame as argument.
8385
8386 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8387 (_EmacsFixedPrivate): Remove minwidth/height.
8388 Add struct frame *f.
8389 (emacs_fixed_init): Initialize priv->f.
8390 (get_parent_class, emacs_fixed_set_min_size): Remove.
8391 (emacs_fixed_new): Set priv->f to argument.
8392 (emacs_fixed_get_preferred_width)
8393 (emacs_fixed_get_preferred_height): Use min_width/height from
8394 frames size_hint to set minimum and natural (Bug#8919).
8395 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8396 and use min_width/height from frames size_hint to set
8397 min_width/height (Bug#8919).
8398
8399 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8400 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8401 Fix indentation.
c7e73be5 8402
cf99dcf8
EZ
84032011-06-26 Eli Zaretskii <eliz@gnu.org>
8404
8405 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8406 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8407 called at ZV.
8408
029529ac
CY
84092011-06-26 Chong Yidong <cyd@stupidchicken.com>
8410
8411 * process.c (wait_reading_process_output): Bypass select if
8412 waiting for a cell while ignoring keyboard input, and input is
8413 pending. Suggested by Jan Djärv (Bug#8869).
8414
7a7ef429
PE
84152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8416
8417 Use gnulib's dup2 module instead of rolling our own.
8418 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8419
11fdef7d 84202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8421
8422 * dispnew.c (scrolling_window): Before scrolling, turn off a
8423 mouse-highlight in the window being scrolled.
8424
cd3520a4
JB
84252011-06-24 Juanma Barranquero <lekktu@gmail.com>
8426
8427 Move DEFSYM to lisp.h and use everywhere.
8428
8429 * character.h (DEFSYM): Move declaration...
8430 * lisp.h (DEFSYM): ...here.
8431
8432 * gnutls.c:
8433 * minibuf.c:
8434 * w32menu.c:
8435 * w32proc.c:
8436 * w32select.c: Don't include character.h.
8437
8438 * alloc.c (syms_of_alloc):
8439 * buffer.c (syms_of_buffer):
8440 * bytecode.c (syms_of_bytecode):
8441 * callint.c (syms_of_callint):
8442 * casefiddle.c (syms_of_casefiddle):
8443 * casetab.c (init_casetab_once):
8444 * category.c (init_category_once, syms_of_category):
8445 * ccl.c (syms_of_ccl):
8446 * cmds.c (syms_of_cmds):
8447 * composite.c (syms_of_composite):
8448 * dbusbind.c (syms_of_dbusbind):
8449 * dired.c (syms_of_dired):
8450 * dispnew.c (syms_of_display):
8451 * doc.c (syms_of_doc):
8452 * editfns.c (syms_of_editfns):
8453 * emacs.c (syms_of_emacs):
8454 * eval.c (syms_of_eval):
8455 * fileio.c (syms_of_fileio):
8456 * fns.c (syms_of_fns):
8457 * frame.c (syms_of_frame):
8458 * fringe.c (syms_of_fringe):
8459 * insdel.c (syms_of_insdel):
8460 * keymap.c (syms_of_keymap):
8461 * lread.c (init_obarray, syms_of_lread):
8462 * macros.c (syms_of_macros):
8463 * msdos.c (syms_of_msdos):
8464 * print.c (syms_of_print):
8465 * process.c (syms_of_process):
8466 * search.c (syms_of_search):
8467 * sound.c (syms_of_sound):
8468 * syntax.c (init_syntax_once, syms_of_syntax):
8469 * terminal.c (syms_of_terminal):
8470 * textprop.c (syms_of_textprop):
8471 * undo.c (syms_of_undo):
8472 * w32.c (globals_of_w32):
8473 * window.c (syms_of_window):
8474 * xdisp.c (syms_of_xdisp):
8475 * xfaces.c (syms_of_xfaces):
8476 * xfns.c (syms_of_xfns):
8477 * xmenu.c (syms_of_xmenu):
8478 * xsettings.c (syms_of_xsettings):
8479 * xterm.c (syms_of_xterm): Use DEFSYM.
8480
4228cf16
TZ
84812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8482
cd3520a4 8483 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8484
7fcccf1e
PE
84852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8486
7efb4e0e
PE
8487 Integer and buffer overflow fixes (Bug#8873).
8488
ff5844ad
PE
8489 * print.c (printchar, strout): Check for string overflow.
8490 (PRINTPREPARE, printchar, strout):
8491 Don't set size unless allocation succeeds.
8492
90532f02
PE
8493 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8494 for sizes. Check for string overflow more accurately.
8495 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8496
6d84508d
PE
8497 * macros.c: Integer and buffer overflow fixes.
8498 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8499 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8500 Use ptrdiff_t, not int, for sizes.
8501 Don't increment bufsize until after realloc succeeds.
8502 Check for size-calculation overflow.
8503 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8504
437b2cb4
PE
8505 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8506
8b9ac8b4
PE
8507 * lread.c: Integer overflow fixes.
8508 (read_integer): Radix is now EMACS_INT, not int,
8509 to improve quality of diagnostics for out-of-range radices.
8510 Calculate buffer size correctly for out-of-range radices.
8511 (read1): Check for integer overflow in radices, and in
8512 read-circle numbers.
82cb60d3
PE
8513 (read_escape): Avoid int overflow.
8514 (Fload, openp, read_buffer_size, read1)
8515 (substitute_object_recurse, read_vector, read_list, map_obarray):
8516 Use ptrdiff_t, not int, for sizes.
8517 (read1): Use EMACS_INT, not int, for sizes.
20270765 8518 Check for size overflow.
8b9ac8b4 8519
7fcccf1e
PE
8520 * image.c (cache_image): Check for size arithmetic overflow.
8521
bfbbd7e7
PE
8522 * lread.c: Integer overflow issues.
8523 (saved_doc_string_size, saved_doc_string_length)
8524 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8525 Now ptrdiff_t, not int.
8526 (read1): Don't assume doc string length fits in int. Check for
8527 out-of-range doc string lengths.
8528 (read_list): Don't assume file position fits in int.
39019e54 8529 (read_escape): Check for hex character overflow.
bfbbd7e7 8530
4e323265
LL
85312011-06-22 Leo Liu <sdl.web@gmail.com>
8532
8533 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8534 Move to minibuffer.el.
8535
85fece3e
PE
85362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8537
20b84ce9 8538 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8539 The following patches are for when GLYPH_DEBUG && !XASSERT.
8540 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8541 * dispnew.c (flush_stdout):
8542 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8543 Mark as externally visible.
8544 * dispnew.c (check_window_matrix_pointers): Now static.
8545 * dispnew.c (window_to_frame_vpos):
8546 * xfns.c (unwind_create_frame):
8547 * xterm.c (x_check_font): Remove unused local.
8548 * scroll.c (CHECK_BOUNDS):
8549 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8550 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8551 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8552 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8553 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8554 Now static.
8555 (debug_method_add): Use va_list and vsprintf rather than relying
8556 on undefined behavior with wrong number of arguments.
8557 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8558 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8559 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8560 since we're not interested in debugging glyphs with old libraries.
8561 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8562 GCC 4.6.0's static checking.
8563
0766b489
PE
85642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8565
31fd4b32
PE
8566 Integer overflow and signedness fixes (Bug#8873).
8567 A few related buffer overrun fixes, too.
8568
b79e8648
PE
8569 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8570
0766b489
PE
8571 * dispextern.h (struct face.stipple):
8572 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8573 (x_bitmap_mask, x_allocate_bitmap_record)
8574 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8575 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8576 (x_create_bitmap_from_xpm_data):
8577 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8578 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8579 (.bitmaps_last):
8580 * xfaces.c (load_pixmap):
8581 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8582 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8583 (.bitmaps_last, struct x_output.icon_bitmap):
8584 Use ptrdiff_t, not int, for bitmap indexes.
8585 (x_allocate_bitmap_record): Check for size overflow.
8586 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8587
b081724f
PE
8588 Use ptrdiff_t, not int, for overlay counts.
8589 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8590 * editfns.c (overlays_around, get_pos_property):
8591 * textprop.c (get_char_property_and_overlay):
8592 * xdisp.c (next_overlay_change, note_mouse_highlight):
8593 * xfaces.c (face_at_buffer_position):
21514da7
PE
8594 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8595 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8596 (Fnext_overlay_change, Fprevious_overlay_change)
8597 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8598 Use ptrdiff_t, not int, for sizes.
21514da7 8599 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8600
3de73e5e
PE
8601 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8602
2606c57b
PE
8603 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8604 (x_session_initialize): Do not assume string length fits in int.
8605
aaafe47a
PE
8606 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8607 This is unlikely, but can occur if DPI is outlandish.
8608
2674ddc8 8609 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8610 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8611
28154962
PE
8612 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8613 * xrdb.c (magic_file_p, search_magic_path):
8614 Omit last arg SUFFIX; it was always 0. All callers changed.
8615 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8616
7de51af5
PE
8617 * xfont.c (xfont_match): Avoid need for strlen.
8618
25ed6cc3
PE
8619 * xfns.c: Don't assume strlen fits in int.
8620 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8621
4eab31dd
PE
8622 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8623 not unsigned long, as we prefer signed integers. All callers changed.
8624 Detect integer overflow in repeat count.
8625 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8626 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8627
171e2a58
PE
8628 * termcap.c: Don't assume sizes fit in int and never overflow.
8629 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8630 (gobble_line): Check for size-calculation overflow.
8631
ad39faca 8632 * minibuf.c (Fread_buffer):
6e5bb2dc 8633 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8634 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8635 Don't assume string length fits in int.
8636
52c61c22 8637 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8638 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8639
b5b8c9e5
PE
8640 * font.c: Don't assume string length fits in int.
8641 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8642 Use ptrdiff_t, not int.
ccd6111c
PE
8643 (font_intern_prop): Don't assume string length fits in int.
8644 Don't assume integer property fits in fixnum.
8645 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8646
882f0d81 8647 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8648 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8649 Reformulate so as not to need the command string.
8650 Invoke gzip -cd rather than gunzip, as it's more portable.
8651 (lock_info_type, lock_file_1, lock_file):
8652 Don't assume pid_t and time_t fit in unsigned long.
8653 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8654 (current_lock_owner): Prefer signed type for sizes.
8655 Use memcpy, not strncpy, where memcpy is what is really wanted.
8656 Don't assume (via atoi) that time_t and pid_t fit in int.
8657 Check for time_t and/or pid_t out of range, e.g., via a network share.
8658 Don't alloca where an auto var works fine.
8659
93f4cf88
PE
8660 * fileio.c: Fix some integer overflow issues.
8661 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8662 Don't assume string length fits in int.
8663 (directory_file_name): Don't assume string length fits in long.
8664 (make_temp_name): Don't assume pid fits in int, or that its print
8665 length is less than 20.
8666
f3e92b69
PE
8667 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8668
1bfdaf10
PE
8669 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8670
35016e9a
PE
8671 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8672
3d1e65a1
PE
8673 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8674 We prefer signed integers, even for size calculations.
8675
0b963a93
PE
8676 * emacs.c: Don't assume string length fits in 'int'.
8677 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8678 (main): Don't invoke strlen when not needed.
8679
573f4b54
PE
8680 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8681 (XD_DEBUG_MESSAGE): Don't waste a byte.
8682
989f33ba
PE
8683 * callproc.c (getenv_internal_1, getenv_internal)
8684 (Fgetenv_internal):
965d34eb
PE
8685 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8686
e4d29b33
PE
8687 * lread.c (invalid_syntax): Omit length argument.
8688 All uses changed. This doesn't fix a bug, but it simplifies the
8689 code away from its former Hollerith-constant appearance, and it's
8690 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8691 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8692
eb49b136
PE
8693 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8694 This didn't break anything, but it didn't help either.
8695 It's confusing to put a bogus integer in a place where the actual
8696 value does not matter.
9f62aeb1 8697 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8698 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8699
15375a22
PE
8700 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8701 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8702 implementation.
b61cc01c
PE
8703 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8704 We prefer signed types, and the value cannot exceed the EMACS_INT
8705 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8706 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8707 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8708 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8709
53b2623d
PE
8710 * indent.c (sane_tab_width): New function.
8711 (current_column, scan_for_column, Findent_to, position_indentation)
8712 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8713 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8714
51cab52b 8715 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8716
f2ed8a70
PE
8717 * lisp.h (lint_assume): New macro.
8718 * composite.c (composition_gstring_put_cache):
8719 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8720
abe80cc6
PE
8721 * editfns.c, insdel.c:
8722 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8723
b02c740e
PE
8724 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8725
ebc96716
PE
8726 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8727
b4e50fa0 8728 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8729 Use much-faster test for byte-length change.
311d5d7c 8730 Don't assume string byte-length fits in 'int'.
a4cf38e4 8731 Check that character arg fits in 'int'.
85461888 8732 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8733
c0c1ee9f
PE
8734 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8735
a498d7f4
PE
8736 * fns.c (concat): Catch string overflow earlier.
8737 Do not rely on integer wraparound.
8738
51cab52b
PE
8739 * dispextern.h (struct it.overlay_strings_charpos)
8740 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8741 * xdisp.c (forward_to_next_line_start)
8742 (back_to_previous_visible_line_start)
8743 (reseat_at_next_visible_line_start, next_element_from_buffer):
8744 Don't arbitrarily truncate the value of 'selective' to int.
8745
76031fad
PE
8746 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8747
5eb55db9
PE
8748 * composite.c: Don't truncate sizes to 'int'.
8749 (composition_gstring_p, composition_reseat_it)
8750 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8751 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8752 not EMACS_UINT, for indexes.
5eb55db9 8753
0703a717
PE
8754 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8755
d6202519
PE
8756 * buffer.c: Include <verify.h>.
8757 (struct sortvec.priority, struct sortstr.priority):
8961a454 8758 Now EMACS_INT, not int.
c20998a7 8759 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8760 (struct sortstr.size, record_overlay_string)
8761 (struct sortstrlist.size, struct sortlist.used):
8762 Don't truncate size to int.
8763 (record_overlay_string): Check for size-calculation overflow.
d6202519 8764 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8765
d5a19415
JM
87662011-06-22 Jim Meyering <meyering@redhat.com>
8767
029529ac 8768 Don't leak an XBM-image-sized buffer
d5a19415
JM
8769 * image.c (xbm_load): Free the image buffer after using it.
8770
a9041e6c
PE
87712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8772
8773 Port to Sun C.
8774 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8775 that Sun C diagnosed.
8776 * fns.c (secure_hash): Fix pointer signedness issue.
8777 * intervals.c (static_offset_intervals): New function.
8778 (offset_intervals): Use it.
8779
7f3f739f
LL
87802011-06-21 Leo Liu <sdl.web@gmail.com>
8781
8782 * deps.mk (fns.o):
8783 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8784 sha512.h.
8785
8786 * fns.c (secure_hash): Rename from crypto_hash_function and change
8787 the first arg to accept symbols.
5b66d427 8788 (Fsecure_hash): New primitive.
7f3f739f
LL
8789 (syms_of_fns): New symbols.
8790
76147d94
DD
87912011-06-20 Deniz Dogan <deniz@dogan.se>
8792
8793 * process.c (Fset_process_buffer): Clarify return value in
8794 docstring.
8795
7d7d0045
CY
87962011-06-18 Chong Yidong <cyd@stupidchicken.com>
8797
8798 * dispnew.c (add_window_display_history): Use BVAR.
8799
8800 * xdisp.c (debug_method_add): Use BVAR.
8801 (check_window_end, dump_glyph_matrix, dump_glyph)
8802 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8803
8804 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8805 Likewise.
8806
8807 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8808 check till after the cache is created in init_frame_faces.
8809
ff2bc410
SM
88102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8811
8812 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8813
28177add
PE
88142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8815
dd3482fe
PE
8816 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8817 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8818 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8819
393d71f3 8820 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8821 * fileio.c (Finsert_file_contents):
8822 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8823 Remove the old (too-loose) buffer overflow checks.
8824 They weren't needed, since make_gap checks for buffer overflow.
8825 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8826 The old code merely checked for Emacs fixnum overflow, and relied
8827 on undefined (wraparound) behavior. The new code avoids undefined
8828 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8829
2e6813b0 8830 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8831 Tune. Don't use wider integers than needed. Don't use alloca.
8832 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8833
599a9e4f
PE
8834 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8835
99561444
PE
8836 * insdel.c, lisp.h (buffer_overflow): New function.
8837 (insert_from_buffer_1, replace_range, replace_range_2):
8838 * insdel.c (make_gap_larger):
8839 * editfns.c (Finsert_char):
8840 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8841
28177add
PE
8842 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8843
e69dafad
PE
88442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8845
4baa020d 8846 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8847
b1c46f02
PE
8848 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8849 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8850
e69dafad
PE
8851 * fileio.c: Don't assume EMACS_INT fits in off_t.
8852 (emacs_lseek): New static function.
8853 (Finsert_file_contents, Fwrite_region): Use it.
8854 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8855
566684ea
PE
8856 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8857
e6966cd6
PE
8858 * fns.c: Don't overflow int when computing a list length.
8859 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8860 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8861 truncation on 64-bit hosts. Check for QUIT every
8862 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8863 faster and is responsive enough.
8864 (Flength): Report an error instead of overflowing an integer.
8865 (Fsafe_length): Return a float if the value is not representable
8866 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8867 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8868 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8869
dd0b0efb
PE
8870 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8871 (header_size, word_size): New constants.
8872 (allocate_vectorlike): Don't check size overflow here.
8873 (allocate_vector): Check it here instead, since this is the only
8874 caller of allocate_vectorlike that could cause overflow.
8875 Check that the new vector's length is representable as a fixnum.
8876
86fe5cfe
PE
8877 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8878 The previous code was bogus. For example, next_almost_prime (32)
8879 returned 39, which is undesirable as it is a multiple of 3; and
8880 next_almost_prime (24) returned 25, which is a multiple of 5 so
8881 why was the code bothering to check for multiples of 7?
8882
80e88859
PE
8883 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8884
4a2f0ad6
PE
8885 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8886
f66c7cf8
PE
8887 Variadic C functions now count arguments with ptrdiff_t.
8888 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8889 Back then I didn't know that the Emacs coding style prefers signed int.
8890 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8891 were being counted with int, which may truncate counts on 64-bit
8892 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8893 * lisp.h (struct Lisp_Subr.function.aMANY)
8894 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8895 Arg counts are now ptrdiff_t, not size_t.
8896 All variadic functions and their callers changed accordingly.
8897 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8898 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8899 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8900 * callint.c (Fcall_interactively): Check arg count for overflow,
8901 to avoid potential buffer overrun. Use signed char, not 'int',
8902 for 'varies' array, so that we needn't bother to check its size
8903 calculation for overflow.
8904 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8905 * eval.c (apply_lambda):
8906 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8907 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8908 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8909
a1759b76
PE
8910 * callint.c (Fcall_interactively): Don't use index var as event count.
8911
d96be9fc
PE
8912 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8913 * mem-limits.h (SIZE): Remove; no longer used.
8914
a690a978 8915 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8916
578c21e6
PE
8917 Remove unnecessary casts.
8918 * xterm.c (x_term_init):
8919 * xfns.c (x_set_border_pixel):
8920 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8921 These aren't needed now that we assume ANSI C.
8922
96f53c6c
PE
8923 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8924 It's more likely to cause problems (due to unsigned overflow)
8925 than to cure them.
8926
83c77d31
PE
8927 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8928
ee2079f1
PE
8929 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8930
6da65536
PE
8931 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8932
7147c4a4
PE
8933 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8934
193e32d9
PE
8935 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8936
e5533da6
PE
8937 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8938
9910e595
PE
8939 GLYPH_CODE_FACE returns EMACS_INT, not int.
8940 * dispextern.h (merge_faces):
8941 * xfaces.c (merge_faces):
01103c44
PE
8942 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8943 Don't assume EMACS_INT fits in int.
9910e595 8944
2638320e
PE
8945 * character.h (CHAR_VALID_P): Remove unused parameter.
8946 * fontset.c, lisp.h, xdisp.c: All uses changed.
8947
045eb8d9
PE
8948 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8949
c1f134b5
PE
8950 * fns.c (concat): Minor tuning based on overflow analysis.
8951 This doesn't fix any bugs. Use int to hold character, instead
8952 of constantly refetching from Emacs object. Use XFASTINT, not
8953 XINT, for value known to be a character. Don't bother comparing
8954 a single byte to 0400, as it's always less.
8955
395fcb93 8956 * floatfns.c (Fexpt):
327eeec8
PE
8957 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8958
abbd3d23
PE
8959 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8960 for characters.
8961
684a03ef
PE
8962 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8963
0fed43f3
PE
8964 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8965 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8966 incorrectly succeed when S was a string, because 4294967386 was
8967 truncated before it was used.
8968
8fd02eb7
PE
8969 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8970 Otherwise, an out-of-range integer could cause undefined behavior
8971 on a 64-bit host.
8972
f8c86b69
PE
8973 * composite.c: Use int, not EMACS_INT, for characters.
8974 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8975 EMACS_INT, for values that are known to be in character range.
8976 This doesn't fix any bugs but is the usual style inside Emacs and
8977 may generate better code on 32-bit machines.
8978
34206dd2
PE
8979 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8980 This is for reasons similar to the recent CHAR_STRING fix.
8981 * charset.c (Fencode_char): Check that character arg is actually
8982 a character. Pass an int to ENCODE_CHAR.
8983 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8984 wider than 'int', as a compile-time check to prevent future regressions
8985 in this area.
8986
c5958d4c 8987 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8988
8989 Make sure a 64-bit char is never passed to CHAR_STRING.
8990 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8991 by silently ignoring the top 32 bits, allowing some values
8992 that were far too large to be valid characters.
8993 * character.h: Include <verify.h>.
8994 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8995 arguments are no wider than unsigned, as a compile-time check
8996 to prevent future regressions in this area.
8997 * data.c (Faset):
01103c44 8998 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8999 (Fsubst_char_in_region):
9000 * fns.c (concat):
9001 * xdisp.c (decode_mode_spec_coding):
9002 Adjust to CHAR_STRING's new requirement.
9003 * editfns.c (Finsert_char, Fsubst_char_in_region):
9004 * fns.c (concat): Check that character args are actually
9005 characters. Without this test, these functions did the wrong
9006 thing with wildly out-of-range values on 64-bit hosts.
9007
d37ca623
PE
9008 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9009 These casts should not be needed on 32-bit hosts, either.
9010 * keyboard.c (read_char):
9011 * lread.c (Fload): Remove casts to unsigned.
9012
ea204efb
PE
9013 * lisp.h (UNSIGNED_CMP): New macro.
9014 This fixes comparison bugs on 64-bit hosts.
9015 (ASCII_CHAR_P): Use it.
9016 * casefiddle.c (casify_object):
01103c44 9017 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9018 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9019 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9020 * dispextern.h (FACE_FROM_ID):
9021 * keyboard.c (read_char): Use UNSIGNED_CMP.
9022
41cb286c
PE
9023 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9024 not to EMACS_INT, to avoid GCC warning.
9025
4a1b9832
PE
9026 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9027
55daad71
PE
9028 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9029 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9030 isn't needed on 32-bit machines.
8f95c75c 9031
01103c44
PE
9032 * buffer.c (Fgenerate_new_buffer_name):
9033 Use EMACS_INT for count, not int.
0ceccced 9034 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9035
9036 * data.c (Qcompiled_function): Now static.
9037
c6f072e7
PE
9038 * window.c (window_body_lines): Now static.
9039
20ce5912
PE
9040 * image.c (gif_load): Rename local to avoid shadowing.
9041
9c4c5f81
PE
9042 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9043 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9044 * alloc.c (make_save_value): Integer argument is now of type
9045 ptrdiff_t, not int.
9046 (mark_object): Use ptrdiff_t, not int.
9047 * lisp.h (pD): New macro.
9048 * print.c (print_object): Use it.
9049
c0c5c8ae
PE
9050 * alloc.c: Use EMACS_INT, not int, to count objects.
9051 (total_conses, total_markers, total_symbols, total_vector_size)
9052 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9053 (total_free_floats, total_floats, total_free_intervals)
9054 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9055 Now EMACS_INT, not int. All uses changed.
9056 (Fgarbage_collect): Compute overall total using a double, so that
9057 integer overflow is less likely to be a problem. Check for overflow
9058 when converting back to an integer.
5a25e253
PE
9059 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9060 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9061 These were 'int' variables that could overflow on 64-bit hosts;
9062 they were never used, so remove them instead of repairing them.
211a0b2a 9063 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9064 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9065 Previously, this ceilinged at INT_MAX, but that doesn't work on
9066 64-bit machines.
e46bb31a 9067 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9068
c78baabf 9069 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9070 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9071 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9072 when a (possibly-narrower) signed value would do just as well.
9073 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9074
c9d624c6
PE
9075 * alloc.c: Catch some string size overflows that we were missing.
9076 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9077 for convenience in STRING_BYTES_MAX.
9078 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9079 The definition here is exact; the one in lisp.h was approximate.
9080 (allocate_string_data): Check for string overflow. This catches
9081 some instances we weren't catching before. Also, it catches
9082 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9083 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9084 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9085
c9d624c6
PE
9086 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9087 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9088 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9089
353032ce
PE
9090 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9091
2bccce07
PE
9092 * alloc.c (Fmake_string): Check for out-of-range init.
9093
0ac30604
SM
90942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9095
9096 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9097
c195f2de
JD
90982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9099
9100 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9101 xg_get_default_scrollbar_width.
9102
9103 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9104 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9105 (style_changed_cb): Call update_theme_scrollbar_width and call
9106 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9107 all frames (Bug#8505).
9108 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9109 Call gtk_window_set_resizable if HAVE_GTK3.
9110 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9111 and height if HAVE_GTK3 (Bug#8505).
9112 (scroll_bar_width_for_theme): New variable.
9113 (update_theme_scrollbar_width): New function.
9114 (xg_get_default_scrollbar_width): Move code to
9115 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9116 (xg_initialize): Call update_theme_scrollbar_width.
9117
9118 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9119
9120 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9121
e10ac9f1
MR
91222011-06-12 Martin Rudalics <rudalics@gmx.at>
9123
9124 * frame.c (make_frame): Call other_buffer_safely instead of
9125 other_buffer.
9126
9127 * window.c (temp_output_buffer_show): Call display_buffer with
9128 second argument Vtemp_buffer_show_specifiers and reset latter
9129 immediately after the call.
9130 (Vtemp_buffer_show_specifiers): New variable.
9131 (auto_window_vscroll_p, next_screen_context_lines)
9132 (Vscroll_preserve_screen_position): Remove leading asterisks from
9133 doc-strings.
9134
2d3c217e 91352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9136
7b7f97e8 9137 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9138 * buffer.c (Qclone_number): Remove for now, as it's unused.
9139 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9140 (record_buffer): Remove unused local.
9141 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9142 (set_frame_buffer_list): Remove; unused.
9143 * frame.h (other_visible_frames): Remove decl.
9144 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9145 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9146 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9147 if HAVE_GPM.
9148 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9149 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9150 Define only if HAVE_GPM.
9151 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9152 (update_hints_inhibit): Remove; never set. All uses removed.
9153 * widgetprv.h (emacsFrameClassRec): Remove decl.
9154 * window.c (delete_deletable_window): Now returns void, since it
9155 wasn't returning anything.
9156 (compare_window_configurations): Remove unused locals.
9157 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9158 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9159 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9160 the same widths as pointers. This follows up on the 2011-05-06 patch.
9161 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9162 * xterm.h: Likewise.
9163 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9164
1384b89e
JB
91652011-06-12 Juanma Barranquero <lekktu@gmail.com>
9166
9167 * makefile.w32-in: Update dependencies.
9168 (LISP_H): Add lib/intprops.h.
9169
1100a63c
CY
91702011-06-11 Chong Yidong <cyd@stupidchicken.com>
9171
9172 * image.c (gif_load): Add animation frame delay to the metadata.
9173 (syms_of_image): Use DEFSYM. New symbol `delay'.
9174
6198ccd0
MR
91752011-06-11 Martin Rudalics <rudalics@gmx.at>
9176
9177 * window.c (delete_deletable_window): Re-add.
9178 (Fset_window_configuration): Rewrite to handle dead buffers and
9179 consequently deletable windows.
9180 (window_tree, Fwindow_tree): Remove. Supply functionality in
9181 window.el.
9182 (compare_window_configurations): Simplify code.
9183
b6e3633c
AS
91842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9185
1ab0dee5
AS
9186 * image.c (imagemagick_load_image): Fix type mismatch.
9187 (Fimagemagick_types): Likewise.
9188
b6e3633c
AS
9189 * window.h (replace_buffer_in_windows): Declare.
9190
9397e56f
MR
91912011-06-11 Martin Rudalics <rudalics@gmx.at>
9192
9193 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9194 Qclone_number. Remove external declaration of Qdelete_window.
9195 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9196 code.
640c8776
SM
9197 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9198 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9199 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9200 buffer list implementation.
9201 (other_buffer_safely): New function.
9202 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9203 calls to replace_buffer_in_windows and
9204 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9205 if allowed.
9206 (record_buffer): Inhibit quitting and rewrite using quittable
9207 functions. Run Qbuffer_list_update_hook if allowed.
9208 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9209 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9210 Move switch-to-buffer to window.el.
9397e56f
MR
9211 (bury-buffer): Move to window.el.
9212 (Vbuffer_list_update_hook): New variable.
9213
9214 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9215 section.
9216
9217 * window.h (resize_frame_windows): Move up in code.
9218 (Fwindow_frame): Remove EXFUN.
9219 (replace_buffer_in_all_windows): Remove prototype.
9220 (replace_buffer_in_windows_safely): Add prototype.
9221
9222 * window.c: Declare Qdelete_window static again. Move down
9223 declaration of select_count.
9224 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9225 (Fother_window): Move to window.el.
9226 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9227 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9228 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9229 window.el.
9230 (replace_buffer_in_windows): Implement by calling
9231 Qreplace_buffer_in_windows.
9232 (replace_buffer_in_all_windows): Remove with some functionality
9233 moved into replace_buffer_in_windows_safely.
9234 (replace_buffer_in_windows_safely): New function.
9235 (select_window_norecord, select_frame_norecord): Move in front
9236 of run_window_configuration_change_hook. Remove now obsolete
9237 declarations.
640c8776
SM
9238 (Fset_window_buffer): Rewrite doc-string.
9239 Call Qrecord_window_buffer.
9397e56f
MR
9240 (keys_of_window): Move binding for other-window to window.el.
9241
b50691aa
CY
92422011-06-11 Chong Yidong <cyd@stupidchicken.com>
9243
9244 * dispextern.h (struct image): Replace data member, whose int_val
9245 and ptr_val fields were not used by anything, with a single
9246 lisp_val object.
9247
9248 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9249 (gif_clear_image, gif_load, imagemagick_load_image)
9250 (gs_clear_image, gs_load): Callers changed.
9251
3f754b86
PE
92522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9253
cca69397
PE
9254 * buffer.h: Include <time.h>, for time_t.
9255 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9256
109e28d0
PE
9257 Fix minor problems found by static checking.
9258
60737f02
PE
9259 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9260
4b66faf3
PE
9261 Make identifiers static if they are not used in other modules.
9262 * data.c (Qcompiled_function, Qframe, Qvector):
9263 * image.c (QimageMagick, Qsvg):
9264 * minibuf.c (Qmetadata):
9265 * window.c (resize_window_check, resize_root_window): Now static.
9266 * window.h (resize_window_check, resize_root_window): Remove decls.
9267
109e28d0
PE
9268 * window.c (window_deletion_count, delete_deletable_window):
9269 Remove; unused.
46a4ce9e
PE
9270 (window_body_lines): Now static.
9271 (Fdelete_other_windows_internal): Mark vars as initialized.
9272 Make sure 'resize_failed' is initialized.
9273 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9274 (resize_window_apply): Remove unused local.
9275 * window.h (delete_deletable_window): Remove decl.
9276
109e28d0 9277 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9278 (imagemagick_load_image): Fix pointer signedness problem by changing
9279 last arg from unsigned char * to char *. All uses changed.
9280 Also, fix a local for similar reasons.
9281 Remove unused locals. Remove locals to avoid shadowing.
9282 (fn_rsvg_handle_free): Remove; unused.
9283 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9284 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9285
3f754b86
PE
9286 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9287
2547adb1
CY
92882011-06-10 Chong Yidong <cyd@stupidchicken.com>
9289
9290 * image.c (gif_load): Fix omitted cast error introduced by
9291 2011-06-06 change.
9292
2c8e37d4
MR
92932011-06-10 Martin Rudalics <rudalics@gmx.at>
9294
9295 * window.h (resize_proportionally, orig_total_lines)
9296 (orig_top_line): Remove from window structure.
9297 (set_window_height, set_window_width, change_window_heights)
9298 (Fdelete_window): Remove prototypes.
9299 (resize_frame_windows): Remove duplicate declaration.
9300
440a42e3
EZ
93012011-06-10 Eli Zaretskii <eliz@gnu.org>
9302
9303 * window.h (resize_frame_windows, resize_window_check)
9304 (delete_deletable_window, resize_root_window)
9305 (resize_frame_windows): Declare prototypes.
9306
9307 * window.c (resize_window_apply): Make definition be "static" to
9308 match the prototype.
9309
562dd5e9
MR
93102011-06-10 Martin Rudalics <rudalics@gmx.at>
9311
9312 * window.c: Remove declarations of Qwindow_size_fixed,
9313 window_min_size_1, window_min_size_2, window_min_size,
9314 size_window, window_fixed_size_p, enlarge_window, delete_window.
9315 Remove static from declaration of Qdelete_window, it's
9316 temporarily needed by Fbury_buffer.
9317 (replace_window): Don't assign orig_top_line and
9318 orig_total_lines.
9319 (Fdelete_window, delete_window): Remove. Window deletion is
9320 handled by window.el.
640c8776
SM
9321 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9322 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9323 (Fdelete_other_windows): Remove. Deleting other windows is
9324 handled by window.el.
9325 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9326 handled in window.el.
9327 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9328 Window minimum sizes are handled in window.el.
9329 (shrink_windows, size_window, set_window_height)
9330 (set_window_width, change_window_heights, window_height)
9331 (window_width, CURBEG, CURSIZE, enlarge_window)
9332 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9333 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9334 handled in window.el.
9335 (make_dummy_parent): Rename to make_parent_window and give it a
9336 second argument horflag.
9337 (make_window): Don't set resize_proportionally any more.
9338 (Fsplit_window): Remove. Windows are split in window.el.
9339 (save_restore_action, save_restore_orig_size)
9340 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9341 Resize mini windows in window.el.
9342 (grow_mini_window, shrink_mini_window): Implement by calling
9343 Qresize_root_window_vertically, resize_window_check and
9344 resize_window_apply.
640c8776
SM
9345 (saved_window, Fset_window_configuration, save_window_save):
9346 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9347 resize_proportionally.
9348 (window_min_height, window_min_width): Move to window.el.
9349 (keys_of_window): Move bindings for delete-other-windows,
9350 split-window, delete-window and enlarge-window to window.el.
9351
9352 * buffer.c: Temporarily extern Qdelete_window.
9353 (Fbury_buffer): Temporarily call Qdelete_window instead of
9354 Fdelete_window (Fbury_buffer will move to window.el soon).
9355
9356 * frame.c (set_menu_bar_lines_1): Remove code handling
9357 orig_top_line and orig_total_lines.
9358
9359 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9360 set_window_height but set heights directly.
9361 (change_frame_size_1): Use resize_frame_windows.
9362
9363 * xdisp.c (init_xdisp): Don't use set_window_height but set
9364 heights directly.
9365
640c8776
SM
9366 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9367 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9368 run_window_configuration_change_hook.
9369
9370 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9371 instead of change_window_heights and run
9372 run_window_configuration_change_hook.
9373
1a13852e
MR
93742011-06-09 Martin Rudalics <rudalics@gmx.at>
9375
9376 * window.c (replace_window): Rename second argument REPLACEMENT to
9377 NEW. New third argument SETFLAG. Rewrite.
9378 (delete_window, make_dummy_parent): Call replace_window with
9379 third argument 1.
9380 (window_list_1): Move down in code.
9381 (run_window_configuration_change_hook): Move set_buffer part
9382 before select_frame_norecord part in order to unwind correctly.
9383 Rename count1 to count.
9384 (recombine_windows, delete_deletable_window, resize_root_window)
9385 (Fdelete_other_windows_internal)
9386 (Frun_window_configuration_change_hook, make_parent_window)
9387 (resize_window_check, resize_window_apply, Fresize_window_apply)
9388 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9389 (Fdelete_window_internal, Fresize_mini_window_internal):
9390 New functions.
1a13852e
MR
9391 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9392
f3d1777e
MR
93932011-06-08 Martin Rudalics <rudalics@gmx.at>
9394
496e208e
MR
9395 * window.h (window): Add some new members to window structure -
9396 normal_lines, normal_cols, new_total, new_normal, clone_number,
9397 splits, nest, prev_buffers, next_buffers.
9398 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9399 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9400
f3d1777e
MR
9401 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9402 Remove.
496e208e
MR
9403 (make_dummy_parent): Set new members of windows structure.
9404 (make_window): Move down in code. Handle new members of window
9405 structure.
9406 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9407 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9408 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9409 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9410 (Fset_window_next_buffers, Fset_window_clone_number):
9411 New functions.
496e208e
MR
9412 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9413 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9414 Doc-string fixes.
9415 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9416 Argument WINDOW can be now internal window too.
9417 (Fwindow_use_time): Move up in code.
9418 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9419 Rewrite doc-string.
9420 (Fset_window_configuration, saved_window)
9421 (Fcurrent_window_configuration, save_window_save): Handle new
9422 members of window structure.
b9e809c2
MR
9423 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9424 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9425 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9426 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9427 Qget_mru_window, Qresize_root_window,
9428 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9429 Qauto_buffer_name; staticpro them.
f3d1777e 9430
abde8f8c
MR
94312011-06-07 Martin Rudalics <rudalics@gmx.at>
9432
9433 * window.c (Fwindow_total_size, Fwindow_left_column)
9434 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9435 (Fwindow_list_1): New functions.
9436 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9437 (Fwindow_width, Fscroll_left, Fscroll_right):
9438 Use window_body_cols instead of window_box_text_cols.
9439 (delete_window, Fset_window_configuration):
9440 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9441 (delete_all_subwindows): Take a window as argument and not a
9442 structure. Rewrite.
190b47e6
MR
9443 (window_loop): Remove handling of GET_LRU_WINDOW and
9444 GET_LARGEST_WINDOW.
9445 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9446
9447 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9448 window_box_text_cols. delete_all_subwindows now takes a
9449 Lisp_Object as argument.
abde8f8c 9450
640c8776
SM
9451 * indent.c (compute_motion, Fcompute_motion):
9452 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9453
fa8a67e6
MR
9454 * frame.c (delete_frame): Call delete_all_subwindows with root
9455 window as argument.
9456
a54e3482
DC
94572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9458
9459 * fns.c (Fputhash): Document return value.
9460
60002bf5
CY
94612011-06-06 Chong Yidong <cyd@stupidchicken.com>
9462
9463 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9464
0c671da6 94652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9466
b862a52a 9467 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9468
be44ca6c
PE
9469 Check for overflow when converting integer to cons and back.
9470 * charset.c (Fdefine_charset_internal, Fdecode_char):
9471 Use cons_to_unsigned to catch overflow.
9472 (Fencode_char): Use INTEGER_TO_CONS.
9473 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9474 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9475 * data.c (long_to_cons, cons_to_long): Remove.
9476 (cons_to_unsigned, cons_to_signed): New functions.
9477 These signal an error for invalid or out-of-range values.
9478 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9479 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9480 * font.c (Ffont_variation_glyphs):
9481 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9482 * lisp.h: Include <intprops.h>.
9483 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9484 (cons_to_signed, cons_to_unsigned): New decls.
9485 (long_to_cons, cons_to_long): Remove decls.
9486 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9487 (Fprimitive_undo): Use CONS_TO_INTEGER.
9488 * xfns.c (Fx_window_property): Likewise.
9489 * xselect.c: Include <limits.h>.
9490 (x_own_selection, selection_data_to_lisp_data):
9491 Use INTEGER_TO_CONS.
9492 (x_handle_selection_request, x_handle_selection_clear)
9493 (x_get_foreign_selection, Fx_disown_selection_internal)
9494 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9495 (lisp_data_to_selection_data): Use cons_to_unsigned.
9496 (x_fill_property_data): Use cons_to_signed.
9497 Report values out of range.
9498
d1f3d2af
PE
9499 Check for buffer and string overflow more precisely.
9500 * buffer.h (BUF_BYTES_MAX): New macro.
9501 * lisp.h (STRING_BYTES_MAX): New macro.
9502 * alloc.c (Fmake_string):
9503 * character.c (string_escape_byte8):
9504 * coding.c (coding_alloc_by_realloc):
9505 * doprnt.c (doprnt):
9506 * editfns.c (Fformat):
9507 * eval.c (verror):
9508 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9509 since they may not be the same number.
9510 * editfns.c (Finsert_char):
9511 * fileio.c (Finsert_file_contents):
9512 Likewise for BUF_BYTES_MAX.
9513
dd52fcea
PE
9514 * image.c: Use ptrdiff_t, not int, for sizes.
9515 (slurp_file): Switch from int to ptrdiff_t.
9516 All uses changed.
9517 (slurp_file): Check that file size fits in both size_t (for
9518 malloc) and ptrdiff_t (for sanity and safety).
9519
7f9bbdbb
PE
9520 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9521 if b->modtime has its maximal value.
9522
dfe18f82
PE
9523 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9524
84acfcf0
PE
9525 Don't assume time_t can fit into int.
9526 * buffer.h (struct buffer.modtime): Now time_t, not int.
9527 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9528 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9529
ccd9a01a
PE
9530 Minor fixes for signed vs unsigned integers.
9531 * character.h (MAYBE_UNIFY_CHAR):
9532 * charset.c (maybe_unify_char):
9533 * keyboard.c (read_char, reorder_modifiers):
9534 XINT -> XFASTINT, since the integer must be nonnegative.
9535 * ftfont.c (ftfont_spec_pattern):
9536 * keymap.c (access_keymap, silly_event_symbol_error):
9537 XUINT -> XFASTINT, since the integer must be nonnegative.
9538 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9539 since it makes no difference and we prefer signed.
9540 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9541 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9542 nonnegative.
9543
d6d100dd
SM
95442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9545
9546 * window.h (Fwindow_frame): Declare.
9547
2b6148e4
PE
95482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9549
9550 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9551 (SPARE_MEMORY): Always define.
9552 (LARGE_REQUEST): Remove.
9553 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9554
f230ecc9
MR
95552011-06-06 Martin Rudalics <rudalics@gmx.at>
9556
727e958e
MR
9557 * lisp.h: Move EXFUNS for Fframe_root_window,
9558 Fframe_first_window and Fset_frame_selected_window to window.h.
9559
9560 * window.h: Move EXFUNS for Fframe_root_window,
9561 Fframe_first_window and Fset_frame_selected_window here from
9562 lisp.h.
9563
9564 * frame.c (Fwindow_frame, Fframe_first_window)
9565 (Fframe_root_window, Fframe_selected_window)
9566 (Fset_frame_selected_window): Move to window.c.
9567 (Factive_minibuffer_window): Move to minibuf.c.
9568 (Fother_visible_frames_p): New function.
9569
9570 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9571
f230ecc9
MR
9572 * window.c (decode_window, decode_any_window): Move up in code.
9573 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9574 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9575 (Fwindow_buffer): Move up and rewrite doc-string.
9576 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9577 (Fwindow_prev): New functions.
727e958e
MR
9578 (Fwindow_frame): Move here from frame.c. Accept any window as
9579 argument.
9580 (Fframe_root_window, Fframe_first_window)
9581 (Fframe_selected_window): Move here from frame.c. Accept frame
9582 or arbitrary window as argument. Update doc-strings.
9583 (Fminibuffer_window): Move up in code.
9584 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9585 (Fset_frame_selected_window): Move here from frame.c.
9586 Marginal rewrite.
727e958e
MR
9587 (Fselected_window, select_window, Fselect_window): Move up in
9588 code. Minor doc-string fixes.
f230ecc9 9589
4d09bcf6
PE
95902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9591
9592 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9593 Do not assume that spare memory exists; that assumption is valid
9594 only if SYSTEM_MALLOC.
9595 (LARGE_REQUEST): New macro, so that the issue of large requests
9596 is separated from the issue of spare memory.
9597
810928a2
AS
95982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9599
172418ad
AS
9600 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9601 format. (Bug#8806)
9602
43f862f7
AS
9603 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9604
810928a2
AS
9605 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9606 before statements.
9607
a059fe24
JD
96082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9609
9610 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9611
9612 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9613
9614 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9615 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9616
989bf368
JB
96172011-06-05 Juanma Barranquero <lekktu@gmail.com>
9618
9619 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9620
4b80f674
CY
96212011-06-04 Chong Yidong <cyd@stupidchicken.com>
9622
9623 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9624 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9625 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9626 New error handlers.
4b80f674
CY
9627 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9628 Obey Vx_select_enable_clipboard_manager. Catch errors in
9629 x_clipboard_manager_save (Bug#8779).
9630 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9631 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9632
99a33b77 96332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9634
9635 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9636
99a33b77 96372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9638
9639 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9640 in the current matrix if keep_current_p is non-zero.
9641
8264569d
EZ
96422011-06-04 Eli Zaretskii <eliz@gnu.org>
9643
9644 * bidi.c (bidi_level_of_next_char): Fix last change.
9645
57f97249
EZ
96462011-06-03 Eli Zaretskii <eliz@gnu.org>
9647
fec2107c 9648 Support bidi reordering of text covered by display properties.
57f97249 9649
fec2107c
EZ
9650 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9651 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9652 (bidi_cache_search, bidi_cache_iterator_state)
9653 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9654 (bidi_level_of_next_char, bidi_move_to_visually_next):
9655 Support character positions inside a run of characters covered by a
fec2107c
EZ
9656 display string.
9657 (bidi_paragraph_init, bidi_resolve_explicit_1)
9658 (bidi_level_of_next_char): Call bidi_fetch_char and
9659 bidi_fetch_char_advance instead of FETCH_CHAR and
9660 FETCH_CHAR_ADVANCE.
9661 (bidi_init_it): Initialize new members.
9662 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9663 definitions.
9664 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9665 instead of using explicit *_CHAR codes.
d6d100dd
SM
9666 (bidi_resolve_explicit, bidi_resolve_weak):
9667 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9668 bidirectional text is supported only in multibyte buffers.
9669 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9670 it to initialize the frame_window_p member of struct bidi_it.
9671 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9672 (bidi_resolve_explicit, bidi_resolve_weak)
9673 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9674 bidi_it->nchars is non-positive.
9675 (bidi_level_of_next_char): Don't try to lookup the cache for the
9676 next/previous character if nothing is cached there yet, or if we
9677 were just reseat()'ed to a new position.
c40e2fb2 9678
0e14fe90
EZ
9679 * xdisp.c (set_cursor_from_row): Set start and stop points
9680 according to the row's direction when priming the loop that looks
9681 for the glyph on which to display cursor.
9682 (single_display_spec_intangible_p): Function deleted.
9683 (display_prop_intangible_p): Reimplement to call
9684 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9685 Accept 3 additional arguments needed by handle_display_spec.
9686 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9687 values: lists, `(when COND...)' forms, etc.
9688 (single_display_spec_string_p): Support property values that are
9689 lists with the argument STRING its top-level element.
9690 (display_prop_string_p): Fix the condition for processing a
9691 property that is a list to be consistent with handle_display_spec.
fec2107c 9692 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9693 last portion of handle_display_prop.
9694 (compute_display_string_pos): Accept additional argument
9695 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9696 value of a `display' property is a "replacing spec".
9697 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9698 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9699 the display property, but just return a value indicating whether
9700 the display property will replace the characters it covers.
9701 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9702 frame_window_p members of struct bidi_it.
d6d100dd
SM
9703 (compute_display_string_pos, compute_display_string_end):
9704 New functions.
fec2107c
EZ
9705 (push_it): Accept second argument POSITION, where pop_it should
9706 jump to continue iteration.
9707 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9708
fec2107c
EZ
9709 * keyboard.c (adjust_point_for_property): Adjust the call to
9710 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9711
9712 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9713 (bidi_init_it): Update prototypes.
9714 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9715 (compute_display_string_pos, compute_display_string_end):
9716 Declare prototypes.
fec2107c
EZ
9717 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9718 EMACS_INT.
fc6f18ce 9719
40087514 97202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9721
57f53182
PE
9722 Malloc failure behavior now depends on size of allocation.
9723 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9724 * lisp.h: Change signatures accordingly.
9725 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9726 All callers changed. (Bug#8762)
9727
9728 * gnutls.c: Use Emacs's memory allocators.
9729 Without this change, the gnutls library would invoke malloc etc.
9730 directly, which causes problems on non-SYNC_INPUT hosts, and which
9731 runs afoul of improving memory_full behavior. (Bug#8761)
9732 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9733 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9734 xfree instead of the default malloc, realloc, free.
9735 (Fgnutls_boot): No need to check for memory allocation failure,
9736 since xmalloc does that for us.
9737
ac32cd99 9738 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9739 * category.c (hash_get_category_set):
9740 * ccl.c (ccl_driver):
9741 * charset.c (Fdefine_charset_internal):
9742 * charset.h (struct charset.hash_index):
9743 * composite.c (get_composition_id, gstring_lookup_cache)
9744 (composition_gstring_put_cache):
9745 * composite.h (struct composition.hash_index):
9746 * dispextern.h (struct image.hash):
9747 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9748 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9749 (hashfn_equal, hashfn_user_defined, make_hash_table)
9750 (maybe_resize_hash_table, hash_lookup, hash_put)
9751 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9752 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9753 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9754 * image.c (make_image, search_image_cache, lookup_image)
9755 (xpm_put_color_table_h):
9756 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9757 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9758 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9759 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9760 * alloc.c (allocate_vectorlike):
9761 Check for overflow in vector size calculations.
9762 * ccl.c (ccl_driver):
9763 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9764 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9765 need to be updated by these changes.
40087514
PE
9766 * fns.c (make_hash_table, maybe_resize_hash_table):
9767 Check for integer overflow with large hash tables.
0de4bb68
PE
9768 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9769 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9770 (SXHASH_REDUCE): New macro.
9771 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9772 Use it instead of discarding useful hash info with large hash values.
9773 (sxhash_float): New function.
9774 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9775 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9776 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9777 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9778 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9779 Adjust signatures to match updated version of code.
9780 (consing_since_gc): Now EMACS_INT, since a single hash table can
9781 use more than INT_MAX bytes.
9782
698d32e2
DN
97832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9784
9785 Make it possible to build with GCC-4.6+ -O2 -flto.
9786
9787 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9788
fd6fa53f
SM
97892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9790
9791 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9792 Call minibuffer-inactive-mode.
9793
864db017
JB
97942011-05-31 Juanma Barranquero <lekktu@gmail.com>
9795
9796 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9797 Update dependencies.
9798
2ad0baf4
DN
97992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9800
9801 * data.c (init_data): Remove code for UTS, this system is not
9802 supported anymore.
9803
4fcc2638
DN
98042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9805
9806 Don't force ./temacs to start in terminal mode.
9807
9808 * frame.c (make_initial_frame): Initialize faces in all cases, not
9809 only when CANNOT_DUMP is defined.
9810 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9811
c56e0fd5
DN
98122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9813
9814 * dispnew.c (add_window_display_history): Use const for the string
9815 pointer. Remove declaration, not needed.
9816
333d54da 98172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9818
55d4c1b2 9819 Use 'inline', not 'INLINE'.
333d54da 9820 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9821 * alloc.c, fontset.c (INLINE): Remove.
9822 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9823 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9824 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9825 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9826 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9827
738db178
DN
98282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9829
9830 Make it possible to run ./temacs.
9831
9832 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9833 syms_of_callproc does the same thing. Remove test for
9834 "initialized", do it in the caller.
9835 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9836
620c53a6
SM
98372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9838
9839 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9840 (read_minibuf): Use get_minibuffer.
9841 (syms_of_minibuf): Use DEFSYM.
9842 (Qmetadata): New var.
9843 * data.c (Qbuffer): Don't make it static.
9844 (syms_of_data): Use DEFSYM.
9845
e003a292
PE
98462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9847
9848 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9849 (CCL_CODE_MIN): New macro.
9850
ed008a6d
PE
98512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9852
3687c2ef
PE
9853 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9854
ed008a6d
PE
9855 * eval.c (Qdebug): Now static.
9856 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9857 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9858 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9859
d66c4c7c
CY
98602011-05-29 Chong Yidong <cyd@stupidchicken.com>
9861
9862 * image.c: Various fixes to ImageMagick code comments.
9863 (Fimagemagick_types): Doc fix.
9864
5fbc2025
PE
98652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9866
0196f88a
PE
9867 Minor fixes prompted by GCC 4.6.0 warnings.
9868
9869 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9870
5fbc2025
PE
9871 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9872 (x_clipboard_manager_save_all): Move extern decl to ...
9873 * xterm.h: ... here, so that it can be checked for consistency.
9874
1dd3c2d9
CY
98752011-05-29 Chong Yidong <cyd@stupidchicken.com>
9876
9877 * xselect.c (x_clipboard_manager_save_frame)
9878 (x_clipboard_manager_save_all): New functions.
9879 (Fx_clipboard_manager_save): Lisp function deleted.
9880
9881 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9882 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9883
9884 * xterm.h: Update prototype.
9885
5ba6571d
WX
98862011-05-28 William Xu <william.xwl@gmail.com>
9887
9888 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9889 exiting (Bug#8239).
9890
3eaff834
JM
98912011-05-28 Jim Meyering <meyering@redhat.com>
9892
e1900994 9893 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9894 * fns.c (to_uchar): Define.
9895 (crypto_hash_function): Use it to convert some newly-signed
9896 variables to unsigned, to avoid sign-extension bugs. For example,
9897 without this change, (md5 "truc") would evaluate to
9898 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9899 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9900 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9901
0f6990a7
PE
99022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9903
9904 Integer overflow fixes.
c8a9ca5a 9905
08686060
PE
9906 * dbusbind.c: Serial number integer overflow fixes.
9907 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9908 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9909 to hold a serial number that is too large for a fixnum.
9910 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9911 Check for serial numbers out of range. Decode any serial number
59568bf0 9912 that was so large that it became a float. (Bug#8722)
08686060 9913
2d1fc3c7
PE
9914 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9915 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9916 Use XFASTINT rather than XUINT when numbers are nonnegative.
9917 (xd_append_arg, Fdbus_method_return_internal):
9918 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9919 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9920 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9921 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9922 (Bug#8722)
2d1fc3c7 9923
c8a9ca5a
PE
9924 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9925
519e1d69
PE
9926 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9927
6df6ae42 9928 ccl: Add integer overflow checks.
30569699
PE
9929 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9930 (IN_INT_RANGE): New macros.
9931 (ccl_driver): Use them to check for integer overflow when
9932 decoding a CCL program. Many of the new checks are whether XINT (x)
9933 fits in int; it doesn't always, on 64-bit hosts. The new version
9934 doesn't catch all possible integer overflows, but it's an
847044ea 9935 improvement. (Bug#8719)
30569699 9936
c11285dc
PE
9937 * alloc.c (make_event_array): Use XINT, not XUINT.
9938 There's no need for unsigned here.
9939
fdccd48e
PE
9940 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9941 This follows up to the 2011-05-06 change that substituted uintptr_t
9942 for EMACS_INT. This case wasn't caught back then.
9943
37910ab2
PE
9944 Rework Fformat to avoid integer overflow issues.
9945 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9946 now (part of C89). Include <verify.h>.
9947 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9948 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9949 (Fformat): Avoid the prepass trying to compute sizes; it was only
9950 approximate and thus did not catch overflow reliably. Instead, walk
9951 through the format just once, formatting and computing sizes as we go,
9952 checking for integer overflow at every step, and allocating a larger
9953 buffer as needed. Keep track separately whether the format is
9954 multibyte. Keep only the most-recently calculated precision, rather
9955 than them all. Record whether each argument has been converted to
9956 string. Use EMACS_INT, not int, for byte and char and arg counts.
9957 Support field widths and precisions larger than INT_MAX. Avoid
9958 sprintf's undefined behavior with conversion specifications such as %#d
9959 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9960 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9961 formatting out-of-range floating point numbers with int
9173deec 9962 formats. (Bug#8668)
37910ab2 9963
2e6578fb
PE
9964 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9965
0ae6bdee
PE
9966 * data.c: Avoid integer truncation in expressions involving floats.
9967 * data.c: Include <intprops.h>.
9968 (arith_driver): When there's an integer overflow in an expression
9969 involving floating point, convert the integers to floating point
9970 so that the resulting value does not suffer from catastrophic
9971 integer truncation. For example, on a 64-bit host (* 4
9972 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9973 Do not rely on undefined behavior after integer overflow.
9974
de883a70
PE
9975 merge count_size_as_multibyte, parse_str_to_multibyte
9976 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9977 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9978 Check for integer overflow.
9979 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9980 since it's now a duplicate of the other. This is more of
9981 a character than a buffer op, so better that it's in character.c.
9982 * fns.c, print.c: Adjust to above changes.
9983
2ff916cb
PE
99842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9985
9986 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9987
f1b54466
PE
99882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9989
fb1ac845
PE
9990 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9991 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9992 (x_clipboard_manager_save): Now static.
9993 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9994
f1b54466
PE
9995 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9996 (crypto_hash_function): Now static.
9997 Fix pointer signedness problems. Avoid unnecessary initializations.
9998
a9f737ee
CY
99992011-05-27 Chong Yidong <cyd@stupidchicken.com>
10000
10001 * termhooks.h (Vselection_alist): Make it terminal-local.
10002
10003 * terminal.c (create_terminal): Initialize it.
10004
10005 * xselect.c: Support for clipboard managers.
10006 (Vselection_alist): Move to termhooks.h as terminal-local var.
10007 (LOCAL_SELECTION): New macro.
10008 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10009 (symbol_to_x_atom): Remove gratuitous arg.
10010 (x_handle_selection_request, lisp_data_to_selection_data)
10011 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10012 (x_own_selection, x_get_local_selection, x_convert_selection):
10013 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10014 (some_frame_on_display): Delete unused function.
10015 (Fx_own_selection_internal, Fx_get_selection_internal)
10016 (Fx_disown_selection_internal, Fx_selection_owner_p)
10017 (Fx_selection_exists_p): New optional frame arg.
10018 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10019 (x_handle_selection_clear): Don't treat other terminals with the
10020 same keyboard specially. Use the terminal-local Vselection_alist.
10021 (x_clear_frame_selections): Use Frun_hook_with_args.
10022
10023 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10024
10025 * xterm.h: Add support for those atoms.
10026
e067f0c1
CY
100272011-05-26 Chong Yidong <cyd@stupidchicken.com>
10028
10029 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10030 (converted_selections, conversion_fail_tag): New global variables.
10031 (x_selection_request_lisp_error): Free the above.
10032 (x_get_local_selection): Remove unnecessary code.
10033 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10034 of converted selections stored in converted_selections.
10035 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10036 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10037 (x_convert_selection): New function.
10038 (x_handle_selection_event): Simplify.
10039 (x_get_foreign_selection): Don't ignore incoming requests while
10040 waiting for an answer; this will fail when we implement
10041 SAVE_TARGETS, and seems unnecessary anyway.
10042 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10043 (Vx_sent_selection_functions): Doc fix.
10044
0f4aebc0
LL
100452011-05-26 Leo Liu <sdl.web@gmail.com>
10046
10047 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10048
e61124cd
YM
100492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10050
10051 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10052
10053 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10054 for fringe update if it has periodic bitmap.
ac389d0c 10055 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10056 and fringe_bitmap_periodic_p.
10057
10058 * fringe.c (get_fringe_bitmap_data): New function.
10059 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10060 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10061 row. Mark glyph row for fringe update if periodicity changed.
10062
10063 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10064 for fringe update unless it has periodic bitmap.
10065
f16d9837
KH
100662011-05-25 Kenichi Handa <handa@m17n.org>
10067
10068 * xdisp.c (get_next_display_element): Set correct it->face_id for
10069 a static composition.
10070
e1b90ef6
LL
100712011-05-24 Leo Liu <sdl.web@gmail.com>
10072
10073 * deps.mk (fns.o):
10074 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10075
10076 * fns.c (crypto_hash_function, Fsha1): New function.
10077 (Fmd5): Use crypto_hash_function.
10078 (syms_of_fns): Add Ssha1.
10079
7400048f
PE
100802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10081
10082 * gnutls.c: Remove unused macros.
10083 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10084 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10085 Remove macros that are defined and never used.
10086 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10087
abb71cf4
CY
100882011-05-22 Chong Yidong <cyd@stupidchicken.com>
10089
10090 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10091 (Fx_get_selection_internal): Minor cleanup.
10092 (Fx_own_selection_internal): Rename arguments for consistency with
10093 select.el.
10094
6307db39
PE
100952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10096
10097 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10098
f3d4e0a4
CY
100992011-05-22 Chong Yidong <cyd@stupidchicken.com>
10100
10101 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10102
4d8ade89
YM
101032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10104
10105 * dispnew.c (scrolling_window): Don't exclude the case that the
10106 last enabled row in the desired matrix touches the bottom boundary.
10107
32078c8d
GM
101082011-05-21 Glenn Morris <rgm@gnu.org>
10109
10110 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10111 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10112 and add some more files.
32078c8d 10113
7285dc67
EZ
101142011-05-20 Eli Zaretskii <eliz@gnu.org>
10115
10116 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10117 report_file_error introduced by the change from 2011-05-07.
10118
89d1bd22
PE
101192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10120
10121 * systime.h (Time): Define only if emacs is defined.
10122 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10123 where the include path doesn't have X11/X.h by default. See
10124 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10125
cd394be1 101262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10127
10128 * composite.c (find_automatic_composition): Fix previous change.
10129
b9704ad9
GM
101302011-05-20 Glenn Morris <rgm@gnu.org>
10131
10132 * lisp.mk: New file, split from Makefile.in.
10133 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10134 (shortlisp): Remove.
10135 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10136
4a720484
GM
101372011-05-19 Glenn Morris <rgm@gnu.org>
10138
10139 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10140 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10141 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10142 (lisp): Set the order to that of loadup.el.
10143 (shortlisp): Make it a copy of $lisp.
10144 (SOME_MACHINE_LISP): Remove.
10145 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10146 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10147
a28d4396
KH
101482011-05-18 Kenichi Handa <handa@m17n.org>
10149
10150 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10151 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10152 (find_automatic_composition): Mostly rewrite for efficiency.
10153
a2b1fa8e
JB
101542011-05-18 Juanma Barranquero <lekktu@gmail.com>
10155
10156 * makefile.w32-in: Update dependencies.
10157
8e1f5610
CS
101582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10159
10160 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10161 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10162
7025ee00 101632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10164
cdfa6eab
PE
10165 Fix some integer overflow issues, such as string length overflow.
10166
06d6db33
PE
10167 * insdel.c (count_size_as_multibyte): Check for string overflow.
10168
2b4560a8
PE
10169 * character.c (lisp_string_width): Check for string overflow.
10170 Use EMACS_INT, not int, for string indexes and lengths; in
10171 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10172 the resulting string length overflows an EMACS_INT; instead,
10173 report a string overflow if no precision given. When checking for
10174 precision exhaustion, use a check that cannot possibly have
10175 integer overflow. (Bug#8675)
10176 * character.h (lisp_string_width): Adjust to new signature.
10177
cb93f9be
PE
10178 * alloc.c (string_overflow): New function.
10179 (Fmake_string): Use it. This doesn't change behavior, but saves
10180 a few bytes and will simplify future changes.
10181 * character.c (string_escape_byte8): Likewise.
10182 * lisp.h (string_overflow): New decl.
10183
1a1f3366
PE
10184 Fixups, following up to the user-interface timestamp change.
10185 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10186 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10187 * msdos.c (mouse_get_pos): Likewise.
10188 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10189 * w32gui.h (Time): Define by including "systime.h" rather than by
10190 declaring it ourselves. (Bug#8664)
10191
d4e3e4d3
PE
10192 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10193 * image.c (clear_image_cache): Likewise.
10194
f6a24d19
PE
10195 * term.c (term_mouse_position): Don't assume time_t wraparound.
10196
08dc5ae6
PE
10197 Be more systematic about user-interface timestamps.
10198 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10199 and sometimes 'EMACS_UINT', to represent these timestamps.
10200 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10201 This makes the code easier to follow, and makes it easier to catch
10202 integer overflow bugs such as Bug#8664.
10203 * frame.c (Fmouse_position, Fmouse_pixel_position):
10204 Use Time, not unsigned long, for user-interface timestamps.
10205 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10206 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10207 * keyboard.h (last_event_timestamp): Likewise.
10208 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10209 * menu.h (xmenu_show): Likewise.
10210 * term.c (term_mouse_position): Likewise.
10211 * termhooks.h (struct input_event.timestamp): Likewise.
10212 (struct terminal.mouse_position_hook): Likewise.
10213 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10214 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10215 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10216 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10217 what it was before.
10218 * menu.h, termhooks.h: Include "systime.h", for Time.
10219
8e55734a
PE
10220 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10221 Don't assume that the difference between two unsigned long values
10222 can fit into an integer. At this point, we know button_down_time
10223 <= event->timestamp, so the difference must be nonnegative, so
10224 there's no need to cast the result if double-click-time is
10225 nonnegative, as it should be; check that it's nonnegative, just in
10226 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10227 apart (about 25 days). (Bug#8664)
8e55734a 10228
841f1b75 10229 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10230 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10231
3e26f69c
PE
10232 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10233 that always fit in int. Use a sentinel instead of a counter, to
10234 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10235 * frame.h (struct frame): Use int for menu_bar_items_used
10236 instead of EMACS_INT, since it always fits in int.
3e26f69c 10237
5cc152c0
PE
10238 * menu.c (grow_menu_items): Check for int overflow.
10239
d89eb65e
PE
10240 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10241
5235bd3e
PE
10242 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10243 Before, the code was not consistent. These values cannot exceed
10244 2**31 - 1 so there's no need to make them unsigned.
10245 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10246 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10247 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10248 as modifiers.
10249 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10250
bc827e23
PE
10251 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10252 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10253 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10254 presumably because the widths might not match.
10255
78eb494e
PE
10256 * window.c (size_window): Avoid needless test at loop start.
10257
04f2d78b
CB
102582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10259
10260 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10261
d2fc7e3d 102622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10263
10264 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10265
d2fc7e3d 102662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10267
10268 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10269 `width' to `bar_area_x' and `bar_area_width', respectively.
10270 (x_scroll_run): Take account of fringe background extension.
10271
04f2d78b
CB
10272 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10273 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10274 `bar_area_width', respectively.
10275 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10276 background extension.
10277
79b70037
GM
102782011-05-10 Jim Meyering <meyering@redhat.com>
10279
10280 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10281
2f142cc5
JB
102822011-05-10 Juanma Barranquero <lekktu@gmail.com>
10283
10284 * image.c (Finit_image_library): Return t for built-in image types,
10285 like pbm and xbm. (Bug#8640)
10286
57679c86
AS
102872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10288
10289 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10290
888c9e86
EZ
102912011-05-07 Eli Zaretskii <eliz@gnu.org>
10292
b0512a1d
EZ
10293 * w32console.c (Fset_screen_color): Doc fix.
10294 (Fget_screen_color): New function.
10295 (syms_of_ntterm): Defsubr it.
10296
7285dc67
EZ
10297 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10298 unlink the temporary file if Fcall_process didn't create it in the
10299 first place.
10300 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10301 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10302 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10303 cue to call_process_cleanup not to close that handle.
10304
4d3fcc8e
BK
103052011-05-07 Ben Key <bkey76@gmail.com>
10306
10307 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10308 one of two shell specific rules, either bootstrap-temacs-CMD or
10309 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10310 to the previous implementation of the bootstrap-temacs rule.
10311 The bootstrap-temacs-CMD rule is similar to the previous
10312 implementation of the bootstrap-temacs rule except that it
10313 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10314 variable.
10315
10316 These changes, along with some changes to nt/configure.bat,
10317 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10318 earlier fix to add support for --cflags and --ldflags options
10319 that include quotes so that it works whether make uses cmd or
10320 sh as the shell.
10321
b4289b64
MA
103222011-05-06 Michael Albinus <michael.albinus@gmx.de>
10323
10324 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10325 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10326 is a constant.
10327 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10328 a string. Handle both cases.
10329 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10330 (Fdbus_register_method): Use Qinvalid_function.
10331
af4c0e28
JB
103322011-05-06 Juanma Barranquero <lekktu@gmail.com>
10333
10334 * makefile.w32-in: Update dependencies.
10335 (LISP_H): Add inttypes.h and stdin.h.
10336 (PROCESS_H): Add unistd.h.
10337
c51453d9
EZ
103382011-05-06 Eli Zaretskii <eliz@gnu.org>
10339
10340 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10341 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10342
8ff0ac3c 103432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10344
4c4b566b
PE
10345 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10346
aab2b9b5
PE
10347 * term.c (vfatal): Remove stray call to va_end.
10348 It's not needed and the C Standard doesn't allow it here anyway.
10349
c378da0b
PE
10350 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10351 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10352
288b08c7
PE
10353 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10354 bytes.
10355
e3601888
PE
10356 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10357
db6c0e74
PE
10358 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10359
dd5963ea
PE
10360 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10361
88c9450f
PE
10362 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10363
2f9442b8
PE
10364 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10365
c032b5f8
PE
10366 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10367 * charset.c (Fdefine_charset_internal): Don't initialize
10368 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10369 32-bit int (Bug#8600).
a108c10b
PE
10370
10371 * lread.c (read_integer): Be more consistent with string-to-number.
10372 Use string_to_number to do the actual conversion; this avoids
10373 rounding errors and fixes some other screwups. Without this fix,
10374 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10375 (digit_to_number): Move earlier, for benefit of read_integer.
10376 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10377 not a digit in any supported base. (Bug#8602)
a108c10b 10378
ad5f9eea
PE
10379 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10380
aec1708a
PE
10381 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10382 to match comment at start of function. This also removes a
10383 GCC warning about overflow in a 32+64-bit port.
10384
47be4ab5
PE
10385 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10386
371cac43
PE
10387 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10388 Reported by Stefan Monnier in
10389 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10390 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10391 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10392
d01a7826
PE
10393 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10394 (EMACS_UINTPTR): Likewise, with uintptr_t.
10395
7fd47d5c
PE
10396 * lisp.h: Prefer 64-bit EMACS_INT if available.
10397 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10398 on 32-bit hosts that have 64-bit int, so that they can access
10399 large files.
122b0c86
PE
10400 However, temporarily disable this change unless the temporary
10401 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10402
8727937b
PE
10403 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10404
8ac068ac
PE
10405 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10406 This removes an assumption that EMACS_INT and long are the same
10407 width as pointers. The assumption is true for Emacs porting targets
10408 now, but we want to make other targets possible.
10409 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10410 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10411 In the rest of the code, change types of integers that hold casted
10412 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10413 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10414 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10415 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10416 No need to cast type when ORing.
10417 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10418 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10419 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10420 assume EMACS_INT is the same width as char *.
10421 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10422 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10423 Remove no-longer-needed casts.
10424 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10425 (xg_tool_bar_help_callback, xg_make_tool_item):
10426 Use EMACS_INTPTR to hold an integer
10427 that will be cast to void *; this can avoid a GCC warning
10428 if EMACS_INT is not the same width as void *.
10429 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10430 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10431 (current_message_1, set_message_1):
10432 Use a local to convert to proper width without a cast.
10433 * xmenu.c (dialog_selection_callback): Likewise.
10434
ede49d71
PE
10435 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10436 Also, don't assume VALBITS / RAND_BITS is less than 5,
10437 and don't rely on undefined behavior when shifting a 1 left into
10438 the sign bit.
10439 * lisp.h (get_random): Change signature to match.
10440
2f30ecd0
PE
10441 * lread.c (hash_string): Use size_t, not int, for hash computation.
10442 Normally we prefer signed values; but hashing is special, because
10443 it's better to use unsigned division on hash table sizes so that
10444 the remainder is nonnegative. Also, size_t is the natural width
10445 for hashing into memory. The previous code used 'int', which doesn't
10446 retain enough info to hash well into very large tables.
10447 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10448
2a866e7b
PE
10449 * dbusbind.c: Don't possibly lose pointer info when converting.
10450 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10451 Use XPNTR rather than XHASH, so that the high-order bits of
10452 the pointer aren't lost when converting through void *.
10453
51639eac
PE
10454 * eval.c (Fautoload): Don't double-shift a pointer.
10455
92394119
PE
10456 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10457
dbdb9a7c
JB
104582011-05-06 Juanma Barranquero <lekktu@gmail.com>
10459
10460 * gnutls.c (DEF_GNUTLS_FN):
10461 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10462
db7a0b4f
AS
104632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10464
10465 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10466 marker. (Bug#8610)
10467
cd394be1 104682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10469
10470 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10471 New version that can reserve upto 2GB of heap space.
10472
f7ff1b0f 104732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10474
10475 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10476
639c109b
TZ
104772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10478
10479 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10480 `gnutls_certificate_set_x509_key_file'.
10481
d2127135
JB
104822011-05-05 Juanma Barranquero <lekktu@gmail.com>
10483
10484 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10485 Update dependencies.
10486
e968f4f3
JB
104872011-05-04 Juanma Barranquero <lekktu@gmail.com>
10488
10489 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10490 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10491 Remove unused parameter `fildes'.
10492 * process.c (read_process_output, send_process): Don't pass it.
10493
84d358f0
JB
104942011-05-04 Juanma Barranquero <lekktu@gmail.com>
10495
10496 Fix previous change: the library cache is defined in w32.c.
10497 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10498 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10499
0898ca10
JB
105002011-05-04 Juanma Barranquero <lekktu@gmail.com>
10501
10502 Implement dynamic loading of GnuTLS on Windows.
10503
10504 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10505 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10506 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10507 Declare.
10508
10509 * gnutls.c (Qgnutls_dll): Define.
10510 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10511 (gnutls_*): Declare function pointers.
10512 (init_gnutls_functions): New function to initialize function pointers.
10513 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10514 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10515 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10516 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10517 (emacs_gnutls_write, emacs_gnutls_read)
10518 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10519 (Fgnutls_available_p): New function.
10520 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10521 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10522 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10523
10524 * image.c: Include w32.h.
10525 (Vimage_type_cache): Delete.
10526 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10527 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10528 (w32_delayed_load): Move to w32.c.
10529
10530 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10531
10532 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10533 (w32_delayed_load): Move from image.c. When loading a library, record
10534 its filename in the :loaded-from property of the library id.
10535 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10536 Initialize and staticpro them.
10537 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10538
10539 * process.c: Include lisp.h before w32.h, not after.
10540 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10541 instead of gnutls_record_check_pending.
10542
10543 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10544
ff4de4aa
TZ
105452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10546
10547 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10548 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10549 as passed in.
10550
abe95abb
JD
105512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10552
10553 * xterm.c (x_set_frame_alpha): Do not set property on anything
10554 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10555
e16e55d4
JB
105562011-05-02 Juanma Barranquero <lekktu@gmail.com>
10557
10558 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10559
bafcf6a5
JB
105602011-05-02 Juanma Barranquero <lekktu@gmail.com>
10561
10562 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10563 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10564 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10565 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10566 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10567 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10568 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10569 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10570 (Qgnutls_bootprop_callbacks_verify): Make static.
10571
e7a6747f
AS
105722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10573
19ed11ba
AS
10574 * callproc.c: Indentation fixup.
10575
e7a6747f 10576 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10577 (wait_for_termination, interruptible_wait_for_termination):
10578 Move after wait_for_termination_1.
e7a6747f 10579
1ef14cb4
LMI
105802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10581
10582 * sysdep.c (interruptible_wait_for_termination): New function
10583 which is like wait_for_termination, but allows keyboard
10584 interruptions.
10585
10586 * callproc.c (Fcall_process): Add (:file "file") as an option for
10587 the STDOUT buffer.
10588 (Fcall_process_region): Ditto.
10589
330d880c
EZ
105902011-04-30 Eli Zaretskii <eliz@gnu.org>
10591
8db90b73
EZ
10592 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10593 rather than `XVECTOR (FOO)->size'.
10594
330d880c
EZ
10595 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10596 inttypes.h, as a gnulib replacement is used if it not available in
10597 system headers.
10598
15cbd324
EZ
105992011-04-21 Eli Zaretskii <eliz@gnu.org>
10600
10601 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10602 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10603 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10604
10605 * coding.c (coding_alloc_by_realloc): Error out if destination
10606 will grow beyond MOST_POSITIVE_FIXNUM.
10607 (decode_coding_emacs_mule): Abort if there isn't enough place in
10608 charbuf for the composition carryover bytes. Reserve an extra
10609 space for up to 2 characters produced in a loop.
10610 (decode_coding_iso_2022): Abort if there isn't enough place in
10611 charbuf for the composition carryover bytes.
10612
106132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10614
ae940cca
EZ
10615 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10616 aborting when %lld or %lll format is passed.
10617 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10618 %llo or %llx format is passed. (Bug#8545)
10619
03ab8921
EZ
10620 * window.c (window_scroll_line_based): Use a marker instead of
10621 simple variables to record original value of point. (Bug#7952)
10622
afda1437
EZ
10623 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10624 produced by %s or %c overflows available buffer space. (Bug#8545)
10625
f76dee0c
PE
106262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10627
10628 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10629 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10630
fdc5744d
JB
106312011-04-28 Juanma Barranquero <lekktu@gmail.com>
10632
10633 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10634
638f053a
JB
106352011-04-28 Juanma Barranquero <lekktu@gmail.com>
10636
10637 * keyboard.c (Qdelayed_warnings_hook): Define.
10638 (command_loop_1): Run `delayed-warnings-hook'
10639 if Vdelayed_warnings_list is non-nil.
10640 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10641 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10642
d178f871
EZ
106432011-04-28 Eli Zaretskii <eliz@gnu.org>
10644
10645 * doprnt.c (doprnt): Don't return value smaller than the buffer
10646 size if the message was truncated. (Bug#8545).
10647
b124fd93
JB
106482011-04-28 Juanma Barranquero <lekktu@gmail.com>
10649
10650 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10651 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10652
e810457d
PE
106532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10654
10655 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10656
ea51cceb
JB
106572011-04-27 Juanma Barranquero <lekktu@gmail.com>
10658
10659 * makefile.w32-in: Update dependencies.
10660
94dcfacf
EZ
106612011-04-27 Eli Zaretskii <eliz@gnu.org>
10662
10663 Improve `doprnt' and its usage. (Bug#8545)
10664 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10665 `format_end'. Remove support for %l as a conversion specifier.
10666 Don't use xrealloc. Improve diagnostics when the %l size modifier
10667 is used. Update the commentary.
10668
10669 * eval.c (verror): Simplify calculation of size_t.
10670
10671 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10672 messages.
10673
f61f41d7
PE
106742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10675
10676 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10677 change.
10678
96fb4434
PE
106792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10680
10681 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10682 This makes this file independent of the recent pseudovector change.
10683
671875da 106842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10685
69e9b5a3
PE
10686 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10687
b5f869a7 10688 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10689 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10690 Remove unused local.
c8926152 10691 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10692
841a1577 10693 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10694 GCC 4.6.0 optimizes based on type-based alias analysis.
10695 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10696 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10697 != &v->size, and therefore "v->size = 1; b->size = 2; return
10698 v->size;" must therefore return 1. This assumption is incorrect
10699 for Emacs, since it type-puns struct Lisp_Vector * with many other
10700 types. To fix this problem, this patch adds a new type struct
f904488f 10701 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10702 and pseudovectors, and helps optimizing compilers not get fooled
10703 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10704 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10705 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10706 the size member.
eab3844f
PE
10707 (XSETPVECTYPE): Rewrite in terms of new macro.
10708 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10709 This is a bit clearer, and further avoids the possibility of
10710 undesirable aliasing.
10711 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10712 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10713 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10714 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10715 (ASIZE): Now uses header.size rather than size.
10716 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10717 to avoid the hassle of writing XVECTOR (foo)->header.size.
10718 (struct vectorlike_header): New type.
eab3844f
PE
10719 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10720 object, to help avoid aliasing.
10721 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10722 (SUBRP): Likewise, since Lisp_Subr is a special case.
10723 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10724 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10725 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10726 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10727 changed to be "header.size" and "header.next".
10728 * buffer.h (struct buffer): Likewise.
10729 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10730 * frame.h (struct frame): Likewise.
10731 * process.h (struct Lisp_Process): Likewise.
10732 * termhooks.h (struct terminal): Likewise.
10733 * window.c (struct save_window_data, struct saved_window): Likewise.
10734 * window.h (struct window): Likewise.
10735 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10736 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10737 * buffer.c (init_buffer_once): Likewise.
10738 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10739 special case.
10740 * process.c (Fformat_network_address): Use local var for size,
10741 for brevity.
10742
0df1eac5
PE
10743 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10744
847ab9d1 10745 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10746 * data.c (atof): Remove decl; no longer used or needed.
10747 (digit_to_number): Move to lread.c.
10748 (Fstring_to_number): Use new string_to_number function, to be
10749 consistent with how the Lisp reader treats infinities and NaNs.
10750 Do not assume that floating-point numbers represent EMACS_INT
10751 without losing information; this is not true on most 64-bit hosts.
10752 Avoid double-rounding errors, by insisting on integers when
10753 parsing non-base-10 numbers, as the documentation specifies.
10754 * lisp.h (string_to_number): New decl, replacing ...
10755 (isfloat_string): Remove.
bc0a5c13 10756 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10757 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10758 appears to have been a coding error. Similarly, do not accept
10759 strings like +-1e0 as floating point numbers. Do not report
10760 overflow for integer overflows unless the base is not 10 which
10761 means we have no simple and reliable way to continue.
10762 Break out the floating-point parsing into a new
10763 function string_to_number, so that Fstring_to_number parses
10764 floating point numbers consistently with the Lisp reader.
04f2d78b 10765 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10766 (E_CHAR, EXP_INT): Remove, replacing with ...
10767 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10768 (string_to_number): New function, replacing isfloat_string.
10769 This function checks for valid syntax and produces the resulting
10770 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10771 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10772 so that overflow for non-base-10 numbers is reported only when
10773 there's no portable and simple way to convert to floating point.
452f4150 10774
67769ffc
PE
10775 * textprop.c (set_text_properties_1): Rewrite for clarity,
10776 and to avoid GCC warning about integer overflow.
10777
c20db43f
PE
10778 * intervals.h (struct interval): Use EMACS_INT for members
10779 where EMACS_UINT might cause problems. See
10780 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10781 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10782 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10783 All uses changed.
37aa2f85
PE
10784 (offset_intervals): Tell GCC not to worry about length overflow
10785 when negating a negative length.
c20db43f 10786
2538aa2f
PE
10787 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10788 (overrun_check_free): Likewise.
10789
f2d3008d
PE
10790 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10791 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10792 word size.
10793
ec8df744
PE
10794 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10795 (gnutls_make_error): Rename local to avoid shadowing.
10796 (gnutls_emacs_global_deinit): ifdef out; not used.
10797 (Fgnutls_boot): Use const for pointer to readonly storage.
10798 Comment out unused local. Fix pointer signedness problems.
10799
640ee02d
PE
10800 * lread.c (openp): Don't stuff size_t into an 'int'.
10801 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10802 about possible signed overflow.
10803
6048fb2a
PE
10804 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10805 (GDK_KEY_g): Don't define if already defined.
10806 (xg_prepare_tooltip): Avoid pointer signedness problem.
10807 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10808
fa3c87e1
PE
10809 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10810 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10811
2172544b
PE
10812 * xfns.c (Fx_window_property): Simplify a bit,
10813 to make a bit faster and to avoid GCC 4.6.0 warning.
10814 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10815
9b821a21
PE
10816 * fns.c (internal_equal): Don't assume size_t fits in int.
10817
3c616cfa
PE
10818 * alloc.c (compact_small_strings): Tighten assertion a little.
10819
c2982e87
PE
10820 Replace pEd with more-general pI, and fix some printf arg casts.
10821 * lisp.h (pI): New macro, generalizing old pEd macro to other
10822 conversion specifiers. For example, use "...%"pI"d..." rather
10823 than "...%"pEd"...".
10824 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10825 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10826 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10827 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10828 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10829 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10830 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10831 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10832 64-bit hosts.
10833 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10834 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10835 * print.c (safe_debug_print, print_object): Likewise.
10836 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10837 to int.
6f04d126
PE
10838 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10839 avoiding the 0 flag, which is not portable.
c2982e87
PE
10840 * process.c (Fmake_network_process): Use pI to avoid cast.
10841 * region-cache.c (pp_cache): Likewise.
10842 * xdisp.c (decode_mode_spec): Likewise.
10843 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10844 behavior on 64-bit hosts with printf arg.
6f04d126 10845 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10846 (x_stop_queuing_selection_requests): Likewise.
10847 (x_get_window_property): Don't truncate byte count to an 'int'
10848 when tracing.
0b432f21 10849
5e073ec7
PE
10850 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10851 here, since it parses constructs like leading '-' and spaces,
10852 which are not wanted; and it overflows with large numbers.
10853 Instead, simply match F[0-9]+, which is what is wanted anyway.
10854
36372bf9
PE
10855 * alloc.c: Remove unportable assumptions about struct layout.
10856 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10857 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10858 (allocate_vectorlike, make_pure_vector): Use the new macros,
10859 plus offsetof, to remove unportable assumptions about struct layout.
10860 These assumptions hold on all porting targets that I know of, but
10861 they are not guaranteed, they're easy to remove, and removing them
10862 makes further changes easier.
10863
0b432f21
PE
10864 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10865 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10866 (string_overrun_cookie): Now const. Use initializers that
10867 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10868 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10869 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10870 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10871 multiple of sizeof (EMACS_INT); it need not be, if
10872 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10873 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10874
895009e1
JB
108752011-04-26 Juanma Barranquero <lekktu@gmail.com>
10876
10877 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10878
6a7a1b0b
TZ
108792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10880
10881 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10882 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10883 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10884
841a1577 108852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10886
10887 * lisp.h (Qdebug): List symbol.
895009e1 10888 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10889 * keyboard.c (debug-on-event): New variable.
10890 (handle_user_signal): Break into debugger when debug-on-event
10891 matches the current signal symbol.
10892
f2d3ba6f
DN
108932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10894
10895 * alloc.c (check_sblock, check_string_bytes)
10896 (check_string_free_list): Convert to standard C.
10897
42ce4c63
TZ
108982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10899
10900 * w32.c (emacs_gnutls_push): Fix typo.
10901
825cd63c
EZ
109022011-04-25 Eli Zaretskii <eliz@gnu.org>
10903
fb11d64d
EZ
10904 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10905 "cast to pointer from integer of different size".
10906
825cd63c
EZ
10907 Improve doprnt and its use in verror. (Bug#8545)
10908 * doprnt.c (doprnt): Document the set of format control sequences
10909 supported by the function. Use SAFE_ALLOCA instead of always
10910 using `alloca'.
10911
10912 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10913 is one byte too soon. Don't use xrealloc; instead xfree and
10914 xmalloc anew.
10915
e061a11b
TZ
109162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10917
10918 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10919 callbacks stage.
10920
10921 * gnutls.c: Renamed global_initialized to
10922 gnutls_global_initialized. Added internals for the
10923 :verify-hostname-error, :verify-error, and :verify-flags
10924 parameters of `gnutls-boot' and documented those parameters in the
10925 docstring. Start callback support.
9173deec
JB
10926 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10927 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10928 on error. Return error code.
e061a11b
TZ
10929 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10930 (emacs_gnutls_read): Likewise.
10931 (Fgnutls_boot): Return handshake error code.
10932 (emacs_gnutls_handle_error): New function.
10933 (wsaerror_to_errno): Likewise.
10934
10935 * w32.h (emacs_gnutls_pull): Add prototype.
10936 (emacs_gnutls_push): Likewise.
10937
10938 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10939 (emacs_gnutls_push): Likewise.
10940
109412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10942
10943 * process.c (wait_reading_process_output): Check if GnuTLS
10944 buffered some data internally if no FDs are set for TLS
10945 connections.
10946
10947 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10948 (LIBS): Link to USER_LIBS.
10949 ($(BLD)/gnutls.$(0)): New target.
10950
fa6996bc
EZ
109512011-04-24 Eli Zaretskii <eliz@gnu.org>
10952
eb35682e
EZ
10953 * xdisp.c (handle_single_display_spec): Rename the
10954 display_replaced_before_p argument into display_replaced_p, to
10955 make it consistent with the commentary. Fix typos in the
10956 commentary.
10957
e2ad650c
EZ
10958 * textprop.c (syms_of_textprop): Remove dead code.
10959 (copy_text_properties): Delete obsolete commentary about an
10960 interface that was deleted long ago. Fix typos in the description
10961 of arguments.
10962
1b2de274
EZ
10963 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10964 to changes in oldXMenu/XMenu.h from 2011-04-16.
10965 <menu_help_message, prev_menu_help_message>: Constify.
10966 (IT_menu_make_room): menu->help_text is now `const char **';
10967 adjust.
10968
10969 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10970 to changes in oldXMenu/XMenu.h from 2011-04-16.
10971 (struct XMenu): Declare `help_text' `const char **'.
10972
10973 * xfaces.c <Qunspecified>: Make extern again.
10974
10975 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10976 required by POSIX.
1b2de274 10977
762b15be
EZ
10978 * doc.c (get_doc_string): Improve the format passed to `error'.
10979
10980 * doprnt.c (doprnt): Improve commentary.
10981
10982 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10983
10984 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10985 them with etags.
10986
f1052e5d
EZ
10987 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10988 changes in globals.h immediately force recompilation.
762b15be
EZ
10989 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10990 $(CURDIR)/s/ms-w32.h.
10991 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10992
fa6996bc
EZ
10993 * character.c (Fchar_direction): Function deleted.
10994 (syms_of_character): Don't defsubr it.
10995 <char-direction-table>: Deleted.
10996
e6c3da20
EZ
109972011-04-23 Eli Zaretskii <eliz@gnu.org>
10998
10999 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11000 * doprnt.c: Include limits.h.
11001 (SIZE_MAX): New macro.
04f2d78b
CB
11002 (doprnt): Return a size_t value. 2nd arg is now size_t.
11003 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11004 Improve overflow protection. Support `l' modifier for integer
11005 conversions. Support %l conversion. Don't assume an EMACS_INT
11006 argument for integer conversions and for %c.
11007
11008 * lisp.h (doprnt): Restore prototype.
11009
11010 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11011 $(SRC)/character.h.
11012
11013 * Makefile.in (base_obj): Add back doprnt.o.
11014
11015 * deps.mk (doprnt.o): Add back prerequisites.
11016 (callint.o): Depend on character.h.
11017
11018 * eval.c (internal_lisp_condition_case): Include the handler
11019 representation in the error message.
11020 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11021 when breaking from the loop.
11022
11023 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11024
11025 * callint.c (Fcall_interactively): When displaying error message
11026 about invalid control letter, pass the character's codepoint, not
11027 a pointer to its multibyte form. Improve display of the character
11028 in octal and display also its hex code.
11029
11030 * character.c (char_string): Use %x to display the (unsigned)
11031 codepoint of an invalid character, to avoid displaying a bogus
11032 negative value.
11033
11034 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11035 `error', not SYMBOL_NAME itself.
11036
11037 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11038 character arguments to `error'.
11039
11040 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11041 to `error' in error message about FINAL_CHAR argument. Make sure
11042 FINAL_CHAR is a character, and use %c when it is passed as
11043 argument to `error'.
11044
4ffd0d6b 110452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11046
11047 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11048
11049 * w32.c: Include <time.h>.
11050 (sys_localtime): New function.
11051
4ffd0d6b 110522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11053
11054 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11055
4ffd0d6b 11056 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11057
4ffd0d6b 110582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11059
4ffd0d6b
GM
11060 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11061 zombies (Bug#8467).
aac0c6e3 11062
04c56954
EZ
110632011-04-19 Eli Zaretskii <eliz@gnu.org>
11064
11065 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11066 gl_state.e_property when gl_state.object is Qt.
11067
11068 * insdel.c (make_gap_larger): Remove limitation of buffer size
11069 to <= INT_MAX.
11070
16a43933
CY
110712011-04-18 Chong Yidong <cyd@stupidchicken.com>
11072
11073 * xdisp.c (lookup_glyphless_char_display)
11074 (produce_glyphless_glyph): Handle cons cell entry in
11075 glyphless-char-display.
11076 (Vglyphless_char_display): Document it.
11077
11078 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11079 glyphless-char-display.
11080
4581706e
CY
110812011-04-17 Chong Yidong <cyd@stupidchicken.com>
11082
11083 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11084
11085 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11086
11087 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11088 definition for no-X builds.
11089
4887c6e2 110902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11091
fd35b6f9
PE
11092 Static checks with GCC 4.6.0 and non-default toolkits.
11093
5c1ccb01
PE
11094 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11095
006c5daa
PE
11096 * process.c (keyboard_bit_set): Define only if SIGIO.
11097 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11098 (send_process): Repair possible setjmp clobbering.
11099
efc736d3
PE
11100 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11101
4e2fe2e6
PE
11102 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11103
f97334a2
PE
11104 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11105
4e75f29d
PE
11106 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11107 Define only if needed.
11108
90efadd1
PE
11109 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11110 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11111 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11112
3c647824
PE
11113 * dispextern.h (struct redisplay_interface): Rename param
11114 to avoid shadowing.
e264f262 11115 * termhooks.h (struct terminal): Likewise.
761383f4 11116 * xterm.c (xembed_send_message): Likewise.
3c647824 11117
b58c5c4a
PE
11118 * insdel.c (make_gap_smaller): Define only if
11119 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11120
cad59032
PE
11121 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11122 it.
11123
c339dc2e
PE
11124 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11125 so that we aren't warned about unused symbols.
11126
91a3e27b
PE
11127 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11128
399c71d3 11129 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11130
8ffc96f5
PE
11131 * xfns.c (x_real_positions): Mark locals as initialized.
11132
eef9bc79
PE
11133 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11134
098db9dd
PE
11135 * xterm.c: Fix problems found by static analysis with other toolkits.
11136 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11137 (x_dispatch_event): Declare static if USE_GTK, and
11138 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11139 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11140 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11141 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11142 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11143
eb18f6cc
PE
11144 * xmenu.c (menu_help_callback): Pointer type fixes.
11145 Use const pointers when pointing at readonly data. Avoid pointer
11146 signedness clashes.
11147 (FALSE): Remove unused macro.
11148 (update_frame_menubar): Remove unused decl.
11149
1fe72bf8
PE
11150 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11151
60d9e1db
PE
11152 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11153 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11154 (single_menu_item): Rename local to avoid shadowing.
11155
39261c26
PE
11156 * keyboard.c (make_lispy_event): Remove unused local var.
11157
018c5e19
PE
11158 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11159 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11160
63d2b86e
PE
11161 * bitmaps: Change bitmaps from unsigned char back to the X11
11162 compatible char. Avoid the old compiler warnings about
11163 out-of-range initializers by using, for example, '\xab' rather
11164 than 0xab.
11165
aefd87e1
PE
11166 * xgselect.c (xgselect_initialize): Check vs interface
11167 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11168
bf501fb9
PE
11169 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11170
e9829fdf
PE
11171 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11172 to read-only memory.
11173
1086c095
PE
11174 * fns.c (vector): Remove; this old hack is no longer needed.
11175
2baccd04 11176 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11177 Remove unused var.
dde42981 11178 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11179
72391843 11180 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11181
436c16df 11182 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11183 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11184 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11185
92bb796d 11186 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11187 (x_term_init): Remove local to avoid shadowing.
92bb796d 11188
764430a3 11189 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11190
11191 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11192 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11193
d1dfb56c
EZ
111942011-04-16 Eli Zaretskii <eliz@gnu.org>
11195
c4354cb4
EZ
11196 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11197
d1dfb56c
EZ
11198 Fix regex.c, syntax.c and friends for buffers > 2GB.
11199 * syntax.h (struct gl_state_s): Declare character position members
11200 EMACS_INT.
11201
11202 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11203
04f2d78b
CB
11204 * textprop.c (verify_interval_modification, interval_of):
11205 Declare arguments EMACS_INT.
d1dfb56c
EZ
11206
11207 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11208 EMACS_INT.
11209
11210 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11211
11212 * indent.c (Fvertical_motion): Local variable it_start is now
11213 EMACS_INT.
11214
11215 * regex.c (re_match, re_match_2, re_match_2_internal)
11216 (bcmp_translate, regcomp, regexec, print_double_string)
11217 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11218 (re_compile_pattern, re_exec): Declare arguments and local
11219 variables `size_t' and `ssize_t' and return values `regoff_t', as
11220 appropriate.
11221 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11222 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11223 <compile_stack_type>: `size' and `avail' are now `size_t'.
11224
11225 * regex.h <regoff_t>: Use ssize_t, not int.
11226 (re_search, re_search_2, re_match, re_match_2): Arguments that
11227 specify buffer/string position and length are now ssize_t and
11228 size_t. Return type is regoff_t.
11229
613052cd
BK
112302011-04-16 Ben Key <bkey76@gmail.com>
11231
11232 * nsfont.m: Fixed bugs in ns_get_family and
11233 ns_descriptor_to_entity that were caused by using free to
11234 deallocate memory blocks that were allocated by xmalloc (via
11235 xstrdup). This caused Emacs to crash when compiled with
11236 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11237 --enable-checking=xmallocoverrun). xfree is now used to
11238 deallocate these memory blocks.
11239
4170f62f 112402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11241
71b41406
PE
11242 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11243
9587a89d
PE
11244 emacs_write: Accept and return EMACS_INT for sizes.
11245 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11246 et seq.
11247 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11248 Accept and return EMACS_INT.
11249 (emacs_gnutls_write): Return the number of bytes written on
11250 partial writes.
11251 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11252 (emacs_read, emacs_write): Remove check for negative size, as the
11253 Emacs source code has been audited now.
9587a89d
PE
11254 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11255 (emacs_read, emacs_write): Use it.
273a5f82
PE
11256 * process.c (send_process): Adjust to the new signatures of
11257 emacs_write and emacs_gnutls_write. Do not attempt to store
11258 a byte offset into an 'int'; it might overflow.
9587a89d 11259 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11260
3e047f51
PE
11261 * sound.c: Don't assume sizes fit in 'int'.
11262 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11263 Return EMACS_INT, not int.
3e047f51 11264 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11265 Accept EMACS_INT, not int.
11266 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11267 record read return values.
11268
cc39a9db
BK
112692011-04-15 Ben Key <bkey76@gmail.com>
11270
c9d0ec6d
JB
11271 * keyboard.c (Qundefined): Don't declare static since it is used
11272 in nsfns.m.
11273 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11274 static since they are used in nsfont.m.
cc39a9db 11275
6c60eb9f
SM
112762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11277
11278 * process.c (Qprocessp): Don't declare static.
11279 * lisp.h (Qprocessp): Declare again.
11280
7990b61a
JB
112812011-04-15 Juanma Barranquero <lekktu@gmail.com>
11282
11283 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11284
5d4cb038
PE
112852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11286
8bd7b830 11287 Improve C-level modularity by making more things 'static'.
cd64ea1d 11288
e3b27b31
PE
11289 Don't publish debugger-only interfaces to other modules.
11290 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11291 (verify_bytepos, count_markers): Move decls to the only modules
11292 that need them.
11293 * region-cache.h (pp_cache): Likewise.
11294 * window.h (check_all_windows): Likewise.
11295 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11296
5d4cb038
PE
11297 * sysdep.c (croak): Now static, if
11298 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11299 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11300
11301 * alloc.c (refill_memory_reserve): Now static if
11302 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11303 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11304
e87b6180
PE
11305 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11306 Define only if USE_LUCID.
11307
ac64929e
PE
11308 * xrdb.c (x_customization_string, x_rm_string): Now static.
11309
6f37259d
PE
11310 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11311 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11312
1683e3ab
PE
11313 * xdisp.c (draw_row_with_mouse_face): Now static.
11314 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11315
de9c2632
PE
11316 * window.h (check_all_windows): Mark externally visible.
11317
2b96acb7
PE
11318 * window.c (window_deletion_count): Now static.
11319
11320 * undo.c: Make symbols static if they're not exported.
11321 (last_undo_buffer, last_boundary_position, pending_boundary):
11322 Now static.
11323
50436f33
PE
11324 * textprop.c (interval_insert_behind_hooks): Now static.
11325 (interval_insert_in_front_hooks): Likewise.
11326
64520e5c
PE
11327 * term.c: Make symbols static if they're not exported.
11328 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11329 (max_frame_lines, tty_set_terminal_modes):
11330 (tty_reset_terminal_modes, tty_turn_off_highlight):
11331 (get_tty_terminal): Now static.
11332 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11333 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11334 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11335 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11336 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11337
1fa53021
PE
11338 * sysdep.c: Make symbols static if they're not exported.
11339 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11340 Now static.
11341 (sigprocmask_set, full_mask): Remove; unused.
11342 (wait_debugging): Mark as visible.
11343 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11344 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11345
d4b43b22
PE
11346 * syntax.c (syntax_temp): Define only if !__GNUC__.
11347
b7c513d0
PE
11348 * sound.c (current_sound_device, current_sound): Now static.
11349
989b29ad
PE
11350 * search.c (searchbufs, searchbuf_head): Now static.
11351
13a55a78
PE
11352 * scroll.c (scroll_cost): Remove; unused.
11353 * dispextern.h (scroll_cost): Remove decl.
11354
de68a1fc
PE
11355 * region-cache.h (pp_cache): Mark as externally visible.
11356
40ccffa6
PE
11357 * process.c: Make symbols static if they're not exported.
11358 (process_tick, update_tick, create_process, chan_process):
11359 (Vprocess_alist, proc_buffered_char, datagram_access):
11360 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11361 (deactivate_process): Mark defn as static, as well as decl.
11362 * lisp.h (create_process): Remove decl.
11363 * process.h (chan_process, Vprocess_alist): Remove decls.
11364
ad64fc97
PE
11365 * print.c: Make symbols static if they're not exported.
11366 (print_depth, new_backquote_output, being_printed, print_buffer):
11367 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11368 (print_interval, print_number_index, initial_stderr_stream):
11369 Now static.
11370 * lisp.h (Fprinc): Remove decl.
11371 (debug_output_compilation_hack): Mark as externally visible.
11372
adddb265
PE
11373 * sysdep.c (croak): Move decl from here to syssignal.h.
11374 * syssignal.h (croak): Put it here, so the API can be checked when
11375 'croak' is called from dissociate_if_controlling_tty.
11376
1717ede2
PE
11377 * minibuf.c: Make symbols static if they're not exported.
11378 (minibuf_save_list, choose_minibuf_frame): Now static.
11379 * lisp.h (choose_minibuf_frame): Remove decl.
11380
fa5fb2bc
PE
11381 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11382
1e3890d1
PE
11383 * lread.c: Make symbols static if they're not exported.
11384 (read_objects, initial_obarray, oblookup_last_bucket_number):
11385 Now static.
11386 (make_symbol): Remove; unused.
11387 * lisp.h (initial_obarray, make_symbol): Remove decls.
11388
8a1414fa
PE
11389 * keyboard.c: Make symbols static if they're not exported.
11390 (single_kboard, recent_keys_index, total_keys, recent_keys):
11391 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11392 (this_single_command_key_start, echoing, last_auto_save):
11393 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11394 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11395 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11396 (Vlispy_mouse_stem, double_click_count):
11397 Now static.
11398 (force_auto_save_soon): Define only if SIGDANGER.
11399 (ignore_mouse_drag_p): Now static if
11400 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11401 (print_help): Remove; unused.
11402 (stop_character, last_timer_event): Mark as externally visible.
11403 * keyboard.h (ignore_mouse_drag_p): Declare only if
11404 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11405 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11406 * lisp.h (echoing): Remove decl.
11407 (force_auto_save_soon): Declare only if SIGDANGER.
11408 * xdisp.c (redisplay_window): Simplify code, to make it more
11409 obvious that ignore_mouse_drag_p is not accessed if !defined
11410 USE_GTK && !defined HAVE_NS.
11411
93ea6e8f
PE
11412 * intervals.c: Make symbols static if they're not exported.
11413 (merge_properties_sticky, merge_interval_right, delete_interval):
11414 Now static.
11415 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11416
77382fcc
PE
11417 * insdel.c: Make symbols static if they're not exported.
11418 However, leave prepare_to_modify_buffer alone. It's never
11419 called from outside this function, but that appears to be a bug.
11420 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11421 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11422 (adjust_after_replace_noundo): Remove; unused.
11423 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11424 (signal_before_change): Remove decls.
77382fcc 11425
9306c32e
PE
11426 * indent.c (val_compute_motion, val_vmotion): Now static.
11427
cd44d2eb
PE
11428 * image.c: Make symbols static if they're not exported.
11429 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11430 if USE_GTK.
11431 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11432 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11433
ad9a7a06
PE
11434 * fringe.c (standard_bitmaps): Now static.
11435 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11436
81626931
PE
11437 * frame.c: Make symbols static if they're not exported.
11438 (x_report_frame_params, make_terminal_frame): Now static.
11439 (get_frame_param): Now static, unless HAVE_NS.
11440 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11441 (x_get_resource_string): Remove; not used.
11442 * frame.h (make_terminal_frame, x_report_frame_params):
11443 (x_get_resource_string); Remove decls.
11444 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11445 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11446
239f9db9
PE
11447 * font.c, fontset.c: Make symbols static if they're not exported.
11448 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11449 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11450 * font.c (font_close_object): Now static.
11451 * font.h (font_close_object): Remove.
11452 * fontset.c (FONTSET_OBJLIST): Remove.
11453 (free_realized_fontset) #if-0 the body, which does nothing.
11454 (face_suitable_for_char_p): #if-0, as it's never called.
11455 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11456 * xfaces.c (face_at_string_position):
11457 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11458 since 0 is always ASCII.
11459
dfcf3579
PE
11460 * fns.c (weak_hash_tables): Now static.
11461
5045092b
PE
11462 * fileio.c: Make symbols static if they're not exported.
11463 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11464 (Vwrite_region_annotation_buffers): Now static.
11465
57a96f5c
PE
11466 * eval.c: Make symbols static if they're not exported.
11467 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11468 * lisp.h (backtrace_list): Remove decl.
11469
35f08c38
PE
11470 * emacs.c: Make symbols static if they're not exported.
11471 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11472 (fatal_error_code, fatal_error_signal_hook, standard_args):
11473 Now static.
11474 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11475 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11476 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11477 * lisp.h (fatal_error_signal_hook): Remove decl.
11478 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11479
f44bd759
PE
11480 * editfns.c: Move a (normally-unused) function to its only use.
11481 * editfns.c, lisp.h (get_operating_system_release): Remove.
11482 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11483 worth the hassle of breaking this out.
11484
b532497d
PE
11485 * xterm.c: Make symbols static if they're not exported.
11486 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11487 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11488 (x_destroy_window, x_delete_display):
11489 Now static.
11490 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11491 (x_mouse_leave): Remove; unused.
11492 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11493 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11494 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11495 Remove decls.
11496 (x_mouse_leave): Declare only if WINDOWSNT.
11497 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11498 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11499 USE_X_TOOLKIT.
11500
1675728f
PE
11501 * ftxfont.c: Make symbols static if they're not exported.
11502 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11503 HAVE_FREETYPE.
11504 * font.h (ftxfont_driver): Likewise.
11505
e4cebfca
PE
11506 * xfns.c: Make symbols static if they're not exported.
11507 (x_last_font_name, x_display_info_for_name):
11508 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11509 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11510 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11511 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11512 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11513 (last_show_tip_args): Now static.
11514 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11515 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11516 (x_screen_planes): Remove; unused.
11517 * dispextern.h (x_screen_planes): Remove decl.
11518
5bf46f05
PE
11519 * dispnew.c: Make symbols static if they're not exported.
11520 * dispextern.h (redraw_garbaged_frames, scrolling):
11521 (increment_row_positions): Remove.
11522 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11523 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11524 Now static.
11525 (redraw_garbaged_frames): Remove; unused.
11526
435f4c28
PE
11527 * xfaces.c: Make symbols static if they're not exported.
11528 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11529 Remove decls.
11530 * xterm.h (defined_color): Remove decls.
11531 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11532 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11533 (menu_face_changed_default, defined_color, free_realized_face):
11534 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11535 (ascii_face_of_lisp_face): Remove; unused.
11536
8524aef3
PE
11537 * xdisp.c: Make symbols static if they're not exported.
11538 * dispextern.h (scratch_glyph_row, window_box_edges):
11539 (glyph_to_pixel_coords, set_cursor_from_row):
11540 (get_next_display_element, set_iterator_to_next):
11541 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11542 (show_mouse_face): Remove decls
11543 * frame.h (message_buf_print): Likewise.
11544 * lisp.h (pop_message, set_message, check_point_in_composition):
11545 Likewise.
11546 * xterm.h (set_vertical_scroll_bar): Likewise.
11547 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11548 (message_buf_print, scratch_glyph_row, displayed_buffer):
11549 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11550 (get_next_display_element, show_mouse_face, window_box_edges):
11551 (frame_to_window_pixel_xy, check_point_in_composition):
11552 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11553 (glyph_to_pixel_coords): Remove; unused.
11554
16390cd2
PE
11555 * dired.c (file_name_completion): Now static.
11556
11557 * dbusbind.c (xd_in_read_queued_messages): Now static.
11558
a25f4dfa
PE
11559 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11560 * data.c (circular_list_error): Remove.
11561
14a9c8df
PE
11562 * commands.h (last_point_position, last_point_position_buffer):
11563 (last_point_position_window): Remove decls.
11564 * keyboard.c: Make these variables static.
11565
04f2d78b
CB
11566 * coding.h (coding, code_convert_region, encode_coding_gap):
11567 Remove decls.
74ab6df5
PE
11568 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11569 (iso_code_class, detect_coding, code_convert_region): Now static.
11570 (encode_coding_gap): Remove; unused.
11571
38dfbee1
PE
11572 * chartab.c (chartab_chars, chartab_bits): Now static.
11573
a2cb4e63
PE
11574 * charset.h (charset_iso_8859_1): Remove decl.
11575 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11576 Now static.
11577
127198fd
PE
11578 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11579 * ccl.c (Vccl_program_table): Now static.
11580 (check_ccl_update): Remove; unused.
11581
d85b608f
PE
11582 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11583 * category.h: ... from here.
11584 * category.c (check_category_table, set_category_set): Now static.
11585
31cd66f3
PE
11586 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11587 * lisp.h: Remove these decls.
11588
c358e587
PE
11589 * buffer.c (buffer_count): Remove unused var.
11590
e78aecca
PE
11591 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11592 so that it's not optimized away.
11593 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11594 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11595 exported only to the debugger.
11596
e192d7d3 11597 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11598 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11599
92470028
PE
11600 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11601 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11602 was inaccessible from Lisp.
11603 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11604 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11605
244ed907
PE
11606 alloc.c: Import and export fewer symbols, and remove unused items.
11607 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11608 is defined.
11609 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11610 it's not optimized away by whole-program optimization.
11611 (message_enable_multibyte, free_misc): Remove.
11612 (catchlist, handlerlist, mark_backtrace):
11613 Declare only if BYTE_MARK_STACK.
11614 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11615 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11616 (message_enable_multibyte): Remove decl.
11617 (free_misc, interval_free_list, float_block, float_block_index):
11618 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11619 (cons_free_list, last_marked_index):
11620 Now static.
11621 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11622 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11623 (mark_backtrace): Define only if BYTE_MARK_STACK.
11624 * xdisp.c (message_enable_multibyte): Now static.
11625
61c2b50e 11626 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11627 This makes it easier for human readers (and static analyzers)
11628 to see whether these variables are used from other modules.
11629 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11630 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11631 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11632 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11633 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11634 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11635 * xmenu.c, xselect.c:
11636 Declare Q* vars static if they are not used in other modules.
11637 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11638 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11639 Remove decls of unexported vars.
11640 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11641
95c82688
PE
11642 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11643
16a97296
PE
11644 Make Emacs functions such as Fatom 'static' by default.
11645 This makes it easier for human readers (and static analyzers)
11646 to see whether these functions can be called from other modules.
11647 DEFUN now defines a static function. To make the function external
11648 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11649 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11650 (Finit_image_library):
16a97296
PE
11651 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11652 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11653 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11654 Remove decls, since these functions are now static.
11655 (Funintern, Fget_internal_run_time): New decls, since these functions
11656 were already external.
95c82688 11657
16a97296
PE
11658 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11659 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11660 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11661 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11662 * keyboard.c, keymap.c, lread.c:
11663 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11664 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11665 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11666 Mark functions with DEFUE instead of DEFUN,
11667 if they are used in other modules.
11668 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11669 decls for now-static functions.
11670 * buffer.h (Fdelete_overlay): Remove decl.
11671 * callproc.c (Fgetenv_internal): Mark as internal.
11672 * composite.c (Fremove_list_of_text_properties): Remove decl.
11673 (Fcomposition_get_gstring): New forward static decl.
11674 * composite.h (Fcomposite_get_gstring): Remove decl.
11675 * dired.c (Ffile_attributes): New forward static decl.
11676 * doc.c (Fdocumntation_property): New forward static decl.
11677 * eval.c (Ffetch_bytecode): New forward static decl.
11678 (Funintern): Remove extern decl; now in .h file where it belongs.
11679 * fileio.c (Fmake_symbolic_link): New forward static decl.
11680 * image.c (Finit_image_library): New forward static decl.
11681 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11682 * intervals.h (Fprevious_property_change):
11683 (Fremove_list_of_text_properties): Remove decls.
11684 * keyboard.c (Fthis_command_keys): Remove decl.
11685 (Fcommand_execute): New forward static decl.
11686 * keymap.c (Flookup_key): New forward static decl.
11687 (Fcopy_keymap): Now static.
11688 * keymap.h (Flookup_key): Remove decl.
11689 * process.c (Fget_process): New forward static decl.
11690 (Fprocess_datagram_address): Mark as internal.
11691 * syntax.c (Fsyntax_table_p): New forward static decl.
11692 (skip_chars): Remove duplicate decl.
11693 * textprop.c (Fprevious_property_change): New forward static decl.
11694 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11695 Now internal.
11696 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11697 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11698
785bbd42
PE
11699 * editfns.c (Fformat): Remove unreachable code.
11700
8b913b57
AS
117012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11702
11703 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11704 change. (Bug#8496)
11705
a6744a35
EZ
117062011-04-13 Eli Zaretskii <eliz@gnu.org>
11707
11708 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11709 when at ZV. (Bug#8487)
11710
e7974947
AS
117112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11712
baad03f0
AS
11713 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11714 (Bug#8437)
11715 * keyboard.c (parse_tool_bar_item): Likewise.
11716 * sound.c (sound_cleanup, alsa_close): Likewise.
11717 * termcap.c (tgetent): Likewise.
11718 * xfns.c (x_default_font_parameter): Likewise.
11719 * xsettings.c (read_and_apply_settings): Likewise.
11720
e7974947
AS
11721 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11722 (overrun_check_free): Protoize.
11723
28272684
PE
117242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11725
11726 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11727 since callers should never pass a negative size.
11728 Change the signature to match that of plain 'read' and 'write'; see
11729 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11730 * lisp.h: Update prototypes of emacs_write and emacs_read.
11731
11997c76
EZ
117322011-04-11 Eli Zaretskii <eliz@gnu.org>
11733
11734 * xdisp.c (redisplay_window): Don't try to determine the character
11735 position of the scroll margin if the window start point w->startp
e896f03c 11736 is outside the buffer's accessible region. (Bug#8468)
11997c76 11737
8a2cbd72
EZ
117382011-04-10 Eli Zaretskii <eliz@gnu.org>
11739
11740 Fix write-region and its subroutines for buffers > 2GB.
11741 * fileio.c (a_write, e_write): Modify declaration of arguments and
11742 local variables to support buffers larger than 2GB.
11743 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11744
11745 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11746 argument, local variables, and return value.
11747
11748 * lisp.h: Update prototypes of emacs_write and emacs_read.
11749
11750 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11751
4073e537 117522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11753
1ebfdcb6
PE
11754 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11755
b2ded58d
PE
11756 Fix more problems found by GCC 4.6.0's static checks.
11757
7d66342c
PE
11758 * xdisp.c (vmessage): Use a better test for character truncation.
11759
bbf47d44
PE
11760 * charset.c (load_charset_map): <, not <=, for optimization,
11761 and to avoid potential problems with integer overflow.
9248994d 11762 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11763 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11764 * editfns.c (Fformat): Likewise.
1e69125e 11765 * syntax.c (skip_chars): Likewise.
3befa583 11766
e3019616
PE
11767 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11768 This also lets GCC 4.6.0 generate slightly better loop code.
11769
becfa255
PE
11770 * callint.c (Fcall_interactively): <, not <=, for optimization.
11771 (Fcall_interactively): Count the number of arguments produced,
11772 not the number of arguments given. This is simpler and lets GCC
11773 4.6.0 generate slightly better code.
11774
dae0cd48
PE
11775 * ftfont.c: Distingish more carefully between FcChar8 and char.
11776 The previous code passed unsigned char * to a functions like
11777 strlen and xstrcasecmp that expect char *, which does not
11778 conform to the C standard.
11779 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11780 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11781 char * when the C standard requires it.
11782
76032d70
PE
11783 * keyboard.c (read_char): Remove unused var.
11784
eb3f1cc8
PE
11785 * eval.c: Port to Windows vsnprintf (Bug#8435).
11786 Include <limits.h>.
11787 (SIZE_MAX): Define if the headers do not.
11788 (verror): Do not give up if vsnprintf returns a negative count.
11789 Instead, grow the buffer. This ports to Windows vsnprintf, which
11790 does not conform to C99. Problem reported by Eli Zaretskii.
11791 Also, simplify the allocation scheme, by avoiding the need for
11792 calling realloc, and removing the ALLOCATED variable.
11793
70476b54
PE
11794 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11795
12020a9e
PE
11796 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11797 But keep the doprint source code for now, as we might revamp it
11798 and use it again (Bug#8435).
ea6c7ae6
PE
11799 * lisp.h (doprnt): Remove.
11800 * Makefile.in (base_obj): Remove doprnt.o.
11801 * deps.mk (doprnt.o): Remove.
11802
5fdb398c
PE
11803 error: Print 32- and 64-bit integers portably (Bug#8435).
11804 Without this change, on typical 64-bit hosts error ("...%d...", N)
11805 was used to print both 32- and 64-bit integers N, which relied on
11806 undefined behavior.
61bdb816 11807 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11808 * lisp.h (error, verror): Mark as printf-like functions.
11809 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11810 Report overflow in size calculations when allocating printf buffer.
11811 Do not truncate output string at its first null byte.
11812 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11813 Truncate the output at a character boundary, since vsnprintf does not
11814 do that.
11815 * charset.c (check_iso_charset_parameter): Convert internal
11816 character to string before calling 'error', since %c now has the
11817 printf meaning.
11818 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11819 overflow when computing char to be passed to 'error'. Do not
11820 pass Lisp_Object to 'error'; pass the integer instead.
11821 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11822 formatted with plain %d.
11823
b189fa66
PE
11824 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11825
bff87ef0
PE
11826 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11827
7e2cac20
PE
11828 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11829
ce4d90b5
PE
11830 * xterm.c (x_catch_errors): Remove duplicate declaration.
11831
266c9547
PE
11832 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11833
79c49ad2
PE
11834 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11835
368f4090
JM
118362011-04-10 Jim Meyering <meyering@redhat.com>
11837
11838 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11839 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11840 return ssize_t not "int", and use size_t as the buffer length.
11841 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11842 * gnutls.h: Update declarations.
11843 * process.c (read_process_output): Use ssize_t, to match.
11844 (send_process): Likewise.
11845
a32d4040
CY
118462011-04-09 Chong Yidong <cyd@stupidchicken.com>
11847
11848 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11849
8546720e 118502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11851
04f2d78b
CB
11852 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11853 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11854
8546720e
GM
11855 * xterm.c (handle_one_xevent):
11856 * xmenu.c (create_and_show_popup_menu):
11857 * xselect.c (x_decline_selection_request)
11858 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11859
0a2f5c1a 118602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11861
11862 Fix some uses of `int' instead of EMACS_INT.
11863 * search.c (string_match_1, fast_string_match)
11864 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11865 (scan_buffer, find_next_newline_no_quit)
11866 (find_before_next_newline, search_command, Freplace_match)
11867 (Fmatch_data): Make some `int' variables be EMACS_INT.
11868
11869 * xdisp.c (display_count_lines): 3rd argument and return value now
11870 EMACS_INT. All callers changed.
11871 (pint2hrstr): Last argument is now EMACS_INT.
11872
11873 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11874 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11875 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11876 (decode_coding_utf_16, decode_coding_emacs_mule)
11877 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11878 (decode_coding_ccl, decode_coding_charset)
11879 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11880 (decode_coding_iso_2022, decode_coding_emacs_mule)
11881 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11882 <char_offset, last_offset>: Declare EMACS_INT.
11883 (encode_coding_utf_8, encode_coding_utf_16)
11884 (encode_coding_emacs_mule, encode_invocation_designation)
11885 (encode_designation_at_bol, encode_coding_iso_2022)
11886 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11887 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11888 Declare EMACS_INT.
11889 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11890 (encode_invocation_designation): Last argument P_NCHARS is now
11891 EMACS_INT.
11892 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11893 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11894
11895 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11896 All users changed.
11897
11898 * ccl.c (Fccl_execute_on_string): Declare some variables
11899 EMACS_INT.
11900
8546720e 119012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11902
11903 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11904
4e19a977
CS
119052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11906
11907 * process.c (Fformat_network_address): Doc fix.
11908
87302331
R
119092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11910
ee7683eb 11911 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11912
cbb59342
CY
119132011-04-08 Chong Yidong <cyd@stupidchicken.com>
11914
11915 * keyboard.c (read_char): Call Lisp function help-form-show,
11916 instead of using internal_with_output_to_temp_buffer.
11917 (Qhelp_form_show): New var.
e0d38eeb 11918 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11919
11920 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11921
11922 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11923
e67a13ab
CY
119242011-04-06 Chong Yidong <cyd@stupidchicken.com>
11925
04f2d78b
CB
11926 * process.c (Flist_processes): Remove to Lisp.
11927 (list_processes_1): Delete.
e67a13ab 11928
973f782d
EZ
119292011-04-06 Eli Zaretskii <eliz@gnu.org>
11930
7c106b1e
EZ
11931 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11932
973f782d
EZ
11933 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11934
41cf7d1a 119352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11936
ca23cc88
PE
11937 Fix more problems found by GCC 4.6.0's static checks.
11938
f390e2d5
PE
11939 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11940
42eea0d0
PE
11941 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11942
b69769da 11943 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11944
f9541e84
PE
11945 * xdisp.c (vmessage): Mark as a printf-like function.
11946
13841b55
PE
11947 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11948
c136c10f
PE
11949 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11950
5e2d4a30
PE
11951 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11952 printf-like functions.
11953 (tiff_load): Add casts to remove these marks before passing them
11954 to system-supplied API.
11955
583f48b9
PE
11956 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11957
b25d760e
PE
11958 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11959 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11960 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11961 directly, rather than having caller test rule sign. This avoids
11962 some unnecessary tests.
11963 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11964 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11965 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11966
bc7b6697 11967 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11968 (xfont_open): Avoid unnecessary tests.
bc7b6697 11969
27ccc379
PE
11970 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11971
dcd5c89a
PE
11972 * composite.h, composite.c (composition_gstring_put_cache):
11973 Use EMACS_INT, not int, for length.
11974
b13a45c6
PE
11975 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11976 breaking out part of COMPOSITION_DECODE_RULE.
11977 (COMPOSITION_DECODE_RULE): Use it.
11978 * composite.c (get_composition_id): Remove unused local vars,
11979 by using the new macro.
11980
1e792e4d
PE
11981 * textprop.c (set_text_properties_1): Change while to do-while,
11982 since the condition is always true at first.
11983
dc6c6455 11984 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11985 (interval_deletion_adjustment): Return unsigned value.
11986 All uses changed.
dc6c6455 11987
aba7731a
PE
11988 * process.c (list_processes_1, create_pty, read_process_output):
11989 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11990 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11991 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11992 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11993 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11994
fdfc4bf3
PE
11995 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11996
fca8fe46 11997 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11998 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11999
06a0259a 12000 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12001 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12002 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12003
e7b9e80f
PE
12004 * print.c (print_error_message): Avoid int overflow.
12005
56201685
PE
12006 * font.c (font_list_entities): Redo for clarity,
12007 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12008
78834453 12009 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12010 (font_score): Avoid potential overflow in diff calculation.
78834453 12011
0bc0b309 12012 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12013 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12014
e610eaca
PE
12015 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12016
b895abce
PE
12017 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12018 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12019 can always succeed if overflow has undefined behavior.
12020
1f1d9321 12021 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12022 (wordify): Omit three unnecessary tests.
1f1d9321 12023
c59478bc
PE
12024 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12025 All callers changed. This avoids the need for an unused var.
12026
79b73827
PE
12027 * casefiddle.c (casify_region): Remove var that is set but not used.
12028
a4db5dfe
PE
12029 * dired.c (file_name_completion): Remove var that is set but not used.
12030
43aae36e
PE
12031 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12032
2a47c44d 12033 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12034 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12035
a37c69bf
PE
12036 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12037 Check for integer overflow on size calculations.
12038
328ab8e7
PE
12039 * buffer.c (Fprevious_overlay_change): Remove var that is set
12040 but not used.
12041
e5a2a5cb
PE
12042 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12043 Remove vars that are set but not used.
8d84a6eb 12044 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12045 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12046
a60e5f68
PE
12047 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12048
f661cb61 12049 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12050 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12051
f0397f5a
PE
12052 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12053 that are set but not used.
12054
8664db06 12055 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12056 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12057
6abdaa4a
PE
12058 * xselect.c (x_get_local_selection, x_handle_property_notify):
12059 Remove vars that are set but not used.
12060
0ce7538d 12061 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12062 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12063
9ae848fc
PE
12064 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12065 Remove var that is set but not used.
0b918413
PE
12066 (scroll_bar_windows_size): Now size_t, not int.
12067 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12068 Check for overflow.
9ae848fc 12069
a5a62657
PE
12070 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12071 (map_tty_color) [!defined MSDOS]: Likewise.
12072
5c5cdd39
PE
12073 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12074
66ebf983
PE
12075 * coding.c: Remove vars that are set but not used.
12076 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12077 All callers changed.
12078 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12079 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12080 (decode_coding_charset): Remove vars that are set but not used.
12081
1be4d761
PE
12082 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12083 that is set but not used.
12084
47553fa8
PE
12085 * print.c (print_object): Remove var that is set but not used.
12086
1f7196bf 12087 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12088 The gnulib version avoids calling malloc in the usual case,
12089 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12090 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12091 * filelock.c (current_lock_owner): Likewise.
12092 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12093 * sysdep.c: Include allocator.h, careadlinkat.h.
12094 (emacs_no_realloc_allocator): New static constant.
12095 (emacs_readlink): New function.
fdb61804
PE
12096 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12097 ../lib/careadlinkat.h.
d1fdcab7 12098
f84c17c7
SM
120992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12100
12101 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12102 first non-nil return value).
12103
ef3862ad
JD
121042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12105
12106 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12107 if not defined (Bug#8403).
12108
376a7006
JB
121092011-04-02 Juanma Barranquero <lekktu@gmail.com>
12110
12111 * xdisp.c (display_count_lines): Remove parameter `start',
12112 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12113 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12114 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12115 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12116 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12117 and thereabouts. All callers changed.
12118 (get_per_char_metric): Remove parameter `f', unused since
12119 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12120
6ca3801d
JM
121212011-04-02 Jim Meyering <meyering@redhat.com>
12122
12123 do not dereference NULL upon failed strdup
12124 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12125 (ns_get_family): Likewise.
12126
d8e2b5ba
JB
121272011-04-02 Juanma Barranquero <lekktu@gmail.com>
12128
12129 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12130
8c74fcbd
JD
121312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12132
12133 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12134 later (Bug#8403).
12135
7200d79c
SM
121362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12137
03408648 12138 Add lexical binding.
7200d79c 12139
03408648
SM
12140 * window.c (Ftemp_output_buffer_show): New fun.
12141 (Fsave_window_excursion):
12142 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12143
12144 * lread.c (lisp_file_lexically_bound_p): New function.
12145 (Fload): Bind Qlexical_binding.
12146 (readevalloop): Remove `evalfun' arg.
12147 Bind Qinternal_interpreter_environment.
12148 (Feval_buffer): Bind Qlexical_binding.
12149 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12150 Mark as dynamic.
12151 (syms_of_lread): Declare `lexical-binding'.
12152
12153 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12154
12155 * keyboard.c (eval_dyn): New fun.
12156 (menu_item_eval_property): Use it.
ca105506
SM
12157
12158 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12159
03408648
SM
12160 * fns.c (concat, mapcar1): Accept byte-code-functions.
12161
12162 * eval.c (Fsetq): Handle lexical vars.
12163 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12164 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12165 (FletX, Flet): Obey lexical binding.
12166 (Fcommandp): Handle closures.
12167 (Feval): New `lexical' arg.
12168 (eval_sub): New function extracted from Feval. Use it almost
12169 everywhere where Feval was used. Look up vars in lexical env.
12170 Handle closures.
12171 (Ffunctionp): Move from subr.el.
12172 (Ffuncall): Handle closures.
12173 (apply_lambda): Remove `eval_flags'.
12174 (funcall_lambda): Handle closures and new byte-code-functions.
12175 (Fspecial_variable_p): New function.
12176 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12177 but without exporting it to Lisp.
23aba0ea 12178
23aba0ea 12179 * doc.c (Fdocumentation, store_function_docstring):
03408648 12180 * data.c (Finteractive_form): Handle closures.
23aba0ea 12181
03408648
SM
12182 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12183 interactive spec.
ba83908c 12184
04f2d78b
CB
12185 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12186 New byte-codes.
03408648
SM
12187 (exec_byte_code): New function extracted from Fbyte_code to handle new
12188 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12189
03408648 12190 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12191
03408648 12192 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12193
e2abce01
JB
121942011-03-31 Juanma Barranquero <lekktu@gmail.com>
12195
12196 * xdisp.c (redisplay_internal): Fix prototype.
12197
63696a73 121982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12199
63696a73 12200 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12201 (try_scrolling): Use it when setting scroll_limit.
12202 Limit scrolling to 100 screen lines.
63696a73
EZ
12203 (redisplay_window): Even when falling back on "recentering",
12204 position point in the window according to scroll-conservatively,
12205 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12206
12207 (try_scrolling): When point is above the window, allow searching
12208 as far as scroll_max, or one screenful, to compute vertical
12209 distance from PT to the scroll margin position. This prevents
12210 try_scrolling from unnecessarily failing when
12211 scroll-conservatively is set to a value slightly larger than the
12212 window height. Clean up the case of PT below the margin at bottom
12213 of window: scroll_max can no longer be INT_MAX. When aggressive
12214 scrolling is in use, don't let point enter the opposite scroll
12215 margin as result of the scroll.
12216 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12217 threshold of 100 lines for never-recentering scrolling.
12218
e4cc2dfc
JB
122192011-03-31 Juanma Barranquero <lekktu@gmail.com>
12220
12221 * dispextern.h (move_it_by_lines):
12222 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12223 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12224 (message_log_check_duplicate): Remove parameters `prev_bol' and
12225 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12226 (redisplay_internal): Remove parameter `preserve_echo_area',
12227 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12228
12229 * indent.c (Fvertical_motion):
12230 * window.c (window_scroll_pixel_based, Frecenter):
12231 Don't pass `need_y_p' to `move_it_by_lines'.
12232
1c470562
SM
122332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12234
44f230aa
SM
12235 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12236 steal a few bits to be more compact.
12237 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12238 Remove unneeded casts.
12239
1c470562
SM
12240 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12241
888adce9
ZK
122422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12243
12244 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12245 binding" message (bug#7967).
12246
f838ed7b
PE
122472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12248
77861b95
PE
12249 Fix more problems found by GCC 4.6.0's static checks.
12250
de6dbc14
PE
12251 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12252 Remove unused local var.
12253
f838ed7b
PE
12254 * editfns.c (Fmessage_box): Remove unused local var.
12255
792c7b2b
PE
12256 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12257 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12258 Omit unused local vars.
c499e557 12259 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12260 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12261 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12262 Omit unused local var.
12263
ba0165e1
PE
12264 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12265 Don't assume string length fits in int.
32ad8845 12266 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12267 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12268
3c59b4c9
PE
12269 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12270 instead of alloca (Bug#8344).
12271
a3eed478 12272 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12273 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12274
eb4d412d
PE
12275 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12276
1658b401
PE
12277 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12278 concerns.
12279
12280 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12281
12282 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12283
9a2c6e05
PE
12284 * keyboard.c (syms_of_keyboard): Use the same style as later
12285 in this function when indexing through an array. This also
12286 works around GCC bug 48267.
12287
03d0a109
PE
12288 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12289
44f730c8
PE
12290 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12291
fe75f926
PE
12292 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12293 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12294
ffa8c828
PE
12295 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12296 This avoids undefined behavior on integer overflow, and is a bit
12297 more convenient anyway since it is compared to a size_t variable.
12298
c5101a77
PE
12299 Variadic C functions now count arguments with size_t, not int.
12300 This avoids an unnecessary limitation on 64-bit machines, which
12301 caused (substring ...) to crash on large vectors (Bug#8344).
12302 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12303 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12304 All variadic functions and their callers changed accordingly.
c5101a77
PE
12305 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12306 * data.c (arith_driver, float_arith_driver): Likewise.
12307 * editfns.c (general_insert_function): Likewise.
12308 * eval.c (struct backtrace.nargs, interactive_p)
12309 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12310 (funcall_lambda, mark_backtrace): Likewise.
12311 * fns.c (concat): Likewise.
12312 * frame.c (x_set_frame_parameters): Likewise.
12313 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12314 0 if not found, not -1. All callers changed.
12315
dd3f25f7
PE
12316 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12317 (stack_copy_size): Now size_t, not int.
12318 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12319
461c2ab9
JB
123202011-03-28 Juanma Barranquero <lekktu@gmail.com>
12321
12322 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12323 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12324 All callers changed.
12325
12326 * lisp.h (multibyte_char_to_unibyte):
12327 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12328 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12329 * character.h (CHAR_TO_BYTE8):
12330 * cmds.c (internal_self_insert):
12331 * editfns.c (general_insert_function):
12332 * keymap.c (push_key_description):
12333 * search.c (Freplace_match):
12334 * xdisp.c (message_dolog, set_message_1): All callers changed.
12335
f6d62986
SM
123362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12337
12338 * keyboard.c (safe_run_hook_funcall): New function.
12339 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12340 don't set the hook to nil, but remove the offending function instead.
12341 (Qcommand_hook_internal): Remove, unused.
12342 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12343 Vcommand_hook_internal.
12344
12345 * eval.c (enum run_hooks_condition): Remove.
12346 (funcall_nil, funcall_not): New functions.
12347 (run_hook_with_args): Call each function through a `funcall' argument.
12348 Remove `cond' argument, now redundant.
12349 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12350 (Frun_hook_with_args_until_failure): Adjust accordingly.
12351 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12352
1db5b1ad
JB
123532011-03-28 Juanma Barranquero <lekktu@gmail.com>
12354
12355 * dispextern.h (string_buffer_position): Remove declaration.
12356
12357 * print.c (strout): Remove parameter `multibyte', unused since
12358 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12359
12360 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12361 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12362 All callers changed.
12363
12364 * w32.c (_wsa_errlist): Use braces for struct initializers.
12365
12366 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12367 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12368 All callers changed.
12369 (string_buffer_position): Likewise. Also, make static (it's never
12370 used outside xdisp.c).
12371 (cursor_row_p): Remove parameter `w', unused since
12372 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12373 (decode_mode_spec): Remove parameter `precision', introduced during
12374 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12375 All callers changed.
12376
5ffb62aa
JD
123772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12378
12379 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12380
461c2ab9 123812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12382
12383 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12384 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12385 (ns_update_auto_hide_menu_bar): New functions.
12386 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12387 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12388 ns_constrain_all_frames.
12389 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12390 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12391
5c380ffb
JD
123922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12393
12394 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12395
9af30bdf
GM
123962011-03-27 Glenn Morris <rgm@gnu.org>
12397
12398 * syssignal.h: Replace RETSIGTYPE with void.
12399 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12400 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12401 Replace SIGTYPE with void everywhere.
12402 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12403 * s/template.h (SIGTYPE): Remove commented out definition.
12404
e2abce01
JB
124052011-03-26 Eli Zaretskii <eliz@gnu.org>
12406
12407 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12408 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12409
f868cd8a
JB
124102011-03-26 Juanma Barranquero <lekktu@gmail.com>
12411
59eb0929
JB
12412 * w32.c (read_unc_volume): Use parameter `henum', instead of
12413 global variable `wget_enum_handle'.
12414
12415 * keymap.c (describe_vector): Remove parameters `indices' and
12416 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12417 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12418
f868cd8a
JB
12419 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12420
12421 * keyboard.c (timer_check): Remove parameter `do_it_now',
12422 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12423 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12424 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12425
12426 * keyboard.c (read_char):
12427 * w32menu.c (w32_menu_display_help):
12428 * xmenu.c (show_help_event, menu_help_callback):
12429 Adjust calls to `show_help_echo'.
12430
12431 * gtkutil.c (xg_maybe_add_timer):
12432 * keyboard.c (readable_events):
12433 * process.c (wait_reading_process_output):
12434 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12435
12436 * insdel.c (adjust_markers_gap_motion):
12437 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12438 (gap_left, gap_right): Don't call it.
12439
2ecf6fdb
CY
124402011-03-25 Chong Yidong <cyd@stupidchicken.com>
12441
12442 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12443 incurred during fontification.
12444
6b1f9ba4
JB
124452011-03-25 Juanma Barranquero <lekktu@gmail.com>
12446
12447 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12448 (DEFVAR_PER_BUFFER): Don't pass it.
12449
12450 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12451 (scrolling_window): Don't pass it.
12452
0f4a96b5
JB
124532011-03-25 Juanma Barranquero <lekktu@gmail.com>
12454
12455 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12456
12457 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12458 and `suffix'.
12459 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12460 of variables specific to SELinux and computation of `encoded_absname'.
12461
12462 * image.c (XPutPixel): Remove unused variable `height'.
12463
12464 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12465
12466 * unexw32.c (get_section_info): Remove unused variable `section'.
12467
12468 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12469 (system_process_attributes): Remove unused variable `sess'.
12470 (sys_read): Remove unused variable `err'.
12471
12472 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12473 (w32_wnd_proc): Remove unused variable `isdead'.
12474 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12475 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12476 (x_create_tip_frame): Remove unused variable `tem'.
12477
12478 * w32inevt.c (w32_console_read_socket):
12479 Remove unused variable `no_events'.
12480
12481 * w32term.c (x_draw_composite_glyph_string_foreground):
12482 Remove unused variable `width'.
12483
1149507c
JB
124842011-03-24 Juanma Barranquero <lekktu@gmail.com>
12485
12486 * w32term.c (x_set_glyph_string_clipping):
12487 Don't pass uninitialized region to CombineRgn.
12488
9c88f339
JB
124892011-03-23 Juanma Barranquero <lekktu@gmail.com>
12490
12491 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12492 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12493 (Fx_close_connection): Remove unused variable `i'.
12494
12495 * w32font.c (w32font_draw): Return number of glyphs.
12496 (w32font_open_internal): Remove unused variable `i'.
12497 (w32font_driver): Add missing initializer.
12498
12499 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12500 (fill_in_menu): Remove unused variable `items_added'.
12501
12502 * w32term.c (last_mouse_press_frame): Remove static global variable.
12503 (w32_clip_to_row): Remove unused variable `f'.
12504 (x_delete_terminal): Remove unused variable `i'.
12505
12506 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12507 (NOTHING): Remove unused static global variable.
12508 (uniscribe_check_otf): Remove unused variable `table'.
12509 (uniscribe_font_driver): Add missing initializers.
12510
dee091a3
JD
125112011-03-23 Julien Danjou <julien@danjou.info>
12512
12513 * term.c (Fsuspend_tty, Fresume_tty):
12514 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12515 * window.c (temp_output_buffer_show):
12516 * insdel.c (signal_before_change):
12517 * frame.c (Fhandle_switch_frame):
12518 * fileio.c (Fdo_auto_save):
12519 * emacs.c (Fkill_emacs):
12520 * editfns.c (save_excursion_restore):
12521 * cmds.c (internal_self_insert):
12522 * callint.c (Fcall_interactively):
12523 * buffer.c (Fkill_all_local_variables):
12524 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12525 Use Frun_hooks.
0f4a96b5 12526 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12527 unconditionally since it does the check itself.
dee091a3 12528
2c520ab5 125292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12530
c9c49752
PE
12531 Fix more problems found by GCC 4.5.2's static checks.
12532
8abc3f12
PE
12533 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12534 the first time through the loop, since we know p0 < p1 then.
12535 This also avoids a gcc -Wstrict-overflow warning.
12536
a2d26660
PE
12537 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12538 leading to a memory leak, possible in functions like
12539 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12540 of objects (Bug#8318).
a2d26660 12541
916c72e9
PE
12542 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12543 that could (at least in theory) be that large.
12544
19ab8a18
PE
12545 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12546 This is less likely to overflow, and avoids undefined behavior if
12547 overflow does occur. All callers changed. Use strtoul to scan
12548 for the unsigned long integer.
b7cbbd6f
PE
12549 (pint2hrstr): Simplify and tune code slightly.
12550 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12551
f0641eff
PE
12552 * scroll.c (do_scrolling): Work around GCC bug 48228.
12553 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12554
7f650bb9
PE
12555 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12556 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12557 (validate_x_resource_name): Simplify count usage.
12558 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12559
37dd57d1
PE
12560 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12561 fail (Bug#8306).
81e56e61 12562
699979fc 12563 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12564
401bf9b4
PE
12565 * process.c (Fmake_network_process): Use socklen_t, not int,
12566 where POSIX says socklen_t is required in portable programs.
12567 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12568 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12569 (Fmake_network_process, server_accept_connection):
12570 (wait_reading_process_output, read_process_output):
12571 Likewise.
12572
b93aacde
PE
12573 * process.c: Rename or move locals to avoid shadowing.
12574 (list_processes_1, Fmake_network_process):
12575 (read_process_output_error_handler, exec_sentinel_error_handler):
12576 Rename or move locals.
4dc343ee 12577 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12578 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12579 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12580 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12581 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12582
af8a867c 12583 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12584 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12585 Include tparam.h instead, since it declares them.
af8a867c
PE
12586 * cm.h (PC): Remove extern decl; tparam.h now does this.
12587 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12588 * terminfo.c: Include tparam.h, to check interfaces.
12589 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12590 (tparam): Adjust signature to match interface in tparam.h;
12591 this removes some undefined behavior. Check that outstring and len
12592 are zero, which they always are with Emacs.
12593 * tparam.h (PC, BC, UP): New extern decls.
12594
0248044d 12595 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12596 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12597
8ff096c1 12598 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12599 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12600 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12601 (ftfont_list): Remove unused local.
49eaafba
PE
12602 (get_adstyle_property, ftfont_pattern_entity):
12603 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12604 Rename locals to avoid shadowing.
8ff096c1 12605
e2be39f6
PE
12606 * xfont.c (xfont_list_family): Mark var as initialized.
12607
c9735e30
PE
12608 * xml.c (make_dom): Now static.
12609
8f5201ae
PE
12610 * composite.c (composition_compute_stop_pos): Rename local to
12611 avoid shadowing.
b246f932
PE
12612 (composition_reseat_it): Remove unused locals.
12613 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12614 (composition_update_it): Mark var as initialized.
11b61122
PE
12615 (find_automatic_composition): Mark vars as initialized,
12616 with a FIXME (Bug#8290).
8f5201ae 12617
760fbc2c
PE
12618 character.h: Rename locals to avoid shadowing.
12619 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12620 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12621 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12622 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12623 to avoid shadowing.
12624
ff08eb85
PE
12625 * textprop.c (property_change_between_p): Remove; unused.
12626
fc7bf025
PE
12627 * intervals.c (interval_start_pos): Now static.
12628
235d7abc
PE
12629 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12630
44f230aa
SM
12631 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12632 Rename locals to avoid shadowing.
3e7d6594 12633
50060332
PE
12634 * sound.c (wav_play, au_play, Fplay_sound_internal):
12635 Fix pointer signedness.
d01f234b 12636 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12637 (wav_play): Initialize a variable to 0, to prevent undefined
12638 behavior (Bug#8278).
50060332 12639
c4fc4e30
PE
12640 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12641
918436ed
PE
12642 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12643
c939f91b
PE
12644 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12645 clobbering (Bug#8298).
b9c7f648
PE
12646 * sysdep.c (sys_subshell): Likewise.
12647 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12648
6bd8c144
PE
12649 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12650 This should get cleaned up, so that child_setup has the
12651 same signature on all platforms.
12652
7710357c 12653 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12654 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12655
c59da222
CY
126562011-03-22 Chong Yidong <cyd@stupidchicken.com>
12657
12658 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12659 not to be necessary, and produces flickering.
12660
66b87493
GM
126612011-03-20 Glenn Morris <rgm@gnu.org>
12662
12663 * config.in: Remove file.
12664
45b6f6d5
JB
126652011-03-20 Juanma Barranquero <lekktu@gmail.com>
12666
12667 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12668 are now in src/globals.h.
12669 (syms_of_minibuf): Remove spurious & from previous change.
12670
cd394be1 126712011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12672
12673 * minibuf.c (completing-read-function): New variable.
12674 (completing-read-default): Rename from completing-read.
12675 (completing-read): Call completing-read-function.
12676
b14e3e21
CY
126772011-03-19 Juanma Barranquero <lekktu@gmail.com>
12678
12679 * xfaces.c (Fx_load_color_file):
12680 Read color file from absolute filename (bug#8250).
12681
f2b726e6
JB
126822011-03-19 Juanma Barranquero <lekktu@gmail.com>
12683
12684 * makefile.w32-in: Update dependencies.
12685
09f6ff02
EZ
126862011-03-17 Eli Zaretskii <eliz@gnu.org>
12687
12688 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12689
29a6015a
PE
126902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12691
a3a6c54e
PE
12692 Fix more problems found by GCC 4.5.2's static checks.
12693
b766f867
PE
12694 * process.c (make_serial_process_unwind, send_process_trap):
12695 (sigchld_handler): Now static.
12696
be02381c
PE
12697 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12698 That way, the code declares only the vars that it needs.
12699 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12700 * s/cygwin.h (PTY_ITERATION): Likewise.
12701 * s/darwin.h (PTY_ITERATION): Likewise.
12702 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12703
57048744
PE
12704 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12705 * process.c (allocate_pty): Don't declare stb unless it's needed.
12706
7914961c 12707 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12708 (CONSTANTLIM): Remove; unused.
12709 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12710 Define only if needed.
7914961c 12711
b3967b18
PE
12712 * unexelf.c (unexec): Name an expression,
12713 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12714 Use a different way to cause a compilation error if anyone uses
12715 n rather than nn, a way that does not involve shadowing.
73366a00 12716 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12717
29a6015a
PE
12718 * deps.mk (unexalpha.o): Remove; unused.
12719
43cfc33e 12720 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12721 * unexec.h: New file.
ce701a33
PE
12722 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12723 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12724 Depend on unexec.h.
12725 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12726 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12727 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12728 Change as necessary to match prototype in unexec.h.
ce701a33 12729
01f44d5a
PE
12730 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12731 shadowing.
4f63c6bb 12732 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12733
a6670b0b
PE
12734 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12735 Rename locals to avoid shadowing.
12736
cef2010d 12737 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12738 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12739
d4d7173a
PE
12740 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12741
f08b802a
PE
12742 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12743 warning when compiling print.c.
12744
3ddb0639
PE
12745 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12746 instead of using an uninitialized var.
5ad03b97 12747 (font_sort_entities): Mark var as initialized.
3ddb0639 12748
170a2692
PE
12749 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12750
e663c700
PE
12751 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12752 pointers to constants.
89bc529a 12753 (font_parse_fcname): Remove unused vars.
7b81e2d0 12754 (font_delete_unmatched): Now static.
ea838e10 12755 (font_get_spec): Remove; unused.
13a547c6
PE
12756 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12757 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12758 Rename or move locals to avoid shadowing.
e663c700 12759
2a80c887 12760 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12761 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12762
1384fa33 12763 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12764 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12765
8b2c52e9
PE
12766 * alloc.c (mark_backtrace): Move decl from here ...
12767 * lisp.h: ... to here, so that it can be checked.
12768
475545b5 12769 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12770 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12771 (lisp_indirect_variable): Name an expression,
12772 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12773 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12774
b1349114 12775 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12776 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12777 Use const pointer when appropriate.
b1349114 12778
a2928364
PE
12779 * lisp.h (get_system_name, get_operating_system_release):
12780 Move decls here, to check interfaces.
12781 * process.c (get_operating_system_release): Move decl to lisp.h.
12782 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12783 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12784 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12785 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12786 (Fformat_time_string, Fencode_time, Finsert_char):
12787 (Ftranslate_region_internal, Fformat):
12788 Rename or remove local vars to avoid shadowing.
9710023e 12789 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12790
a415e694
PE
12791 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12792 avoid shadowing.
12793
8ef4622d
PE
12794 * lisp.h (eassert): Check that the argument compiles, even if
12795 ENABLE_CHECKING is not defined.
12796
946f9a5b
PE
12797 * data.c (Findirect_variable): Name an expression, to avoid
12798 gcc -Wbad-function-cast warning.
112396d6 12799 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12800 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12801 (Fmake_variable_buffer_local, Fmake_local_variable):
12802 Mark variables as initialized.
52746918 12803 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12804
e5aab7e7 12805 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12806 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12807 Rename locals to avoid shadowing.
dff45157
PE
12808 (mark_stack): Move local variables into the #ifdef region where
12809 they're used.
7bc26fdb
PE
12810 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12811 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12812 needed otherwise.
12813 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12814 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12815 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12816
e5aab7e7
PE
12817 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12818 avoids undefined behavior in theory.
12819
4da60324
PE
12820 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12821
88043301
PE
12822 Use functions, not macros, for up- and down-casing (Bug#8254).
12823 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12824 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12825 to use the following functions instead of these macros.
12826 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12827 EMACS_INT, since callers assume the returned value fits in int.
12828 (upcase1): Likewise, for UPCASE_TABLE.
12829 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12830 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12831 the race-condition problem in the old DOWNCASE.
88043301 12832
19ed5445
PE
12833 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12834 Rename locals to avoid shadowing.
12835 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12836 (regex_compile, re_search_2, re_match_2_internal):
12837 Remove unused local vars.
952db0d7
PE
12838 (FREE_VAR): Rewrite so as not to use empty "else",
12839 which gcc can warn about.
da053e48 12840 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12841 (RETALLOC_IF): Define only if needed.
12842 (WORDCHAR_P): Likewise. This one is never needed, but is used
12843 only in a comment talking about a compiler bug, so put inside
12844 the #if 0 of that comment.
12845 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12846 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12847 Remove; unused.
19ed5445 12848
1f3561e4 12849 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12850 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12851 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12852
ded6f8f7
PE
12853 * search.c (simple_search): Remove unused var.
12854
dbd37a95
PE
12855 * dired.c (compile_pattern): Move decl from here ...
12856 * lisp.h: ... to here, so that it can be checked.
12857 (struct re_registers): New forward decl.
12858
7e47afad
PE
12859 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12860
85f24f61
PE
12861 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12862 All uses changed.
12863 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12864 Rename locals to avoid shadowing.
5671df8f 12865 (Fvertical_motion): Mark locals as initialized.
85f24f61 12866
181aa2be 12867 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12868 (casify_region): Mark local as initialized.
181aa2be 12869
930d429c
PE
12870 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12871
7082eac6
PE
12872 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12873 New macros, so that the caller can use some names other than
12874 gcpro1, gcpro2, etc.
12875 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12876 of the new macros.
12877 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12878 argument, for consistency with GCPRO2_VAR, etc: it is now the
12879 prefix of the variable, not the variable itself. All uses
12880 changed.
38b2c076
PE
12881 * dired.c (directory_files_internal, file_name_completion):
12882 Rename locals to avoid shadowing.
12883
15206ed9
PE
12884 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12885 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12886 dired.c's scmp function, had undefined behavior.
12887 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12888 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12889 * buffer.h: ... to here, because these macros use current_buffer,
12890 and the new implementation with inline functions needs to have
12891 current_buffer in scope now, rather than later when the macros
12892 are used.
12893 (downcase, upcase1): New static inline functions.
12894 (DOWNCASE, UPCASE1): Reimplement using these functions.
12895 This avoids undefined behavior in expressions like
12896 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12897 from race conditions in accessing the global variables
12898 case_temp1 and case_temp2.
12899 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12900 * lisp.h (case_temp1, case_temp2): Remove their decls.
12901 * character.h (ASCII_CHAR_P): Move from here ...
12902 * lisp.h: ... to here, so that the inline functions mentioned
12903 above can use them.
12904
4a6bea26
PE
12905 * dired.c (directory_files_internal_unwind): Now static.
12906
f14b7e14
PE
12907 * fileio.c (file_name_as_directory, directory_file_name):
12908 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12909 Now static.
2893f146
PE
12910 (file_name_as_directory): Use const pointers when appropriate.
12911 (Fexpand_file_name): Likewise. In particular, newdir might
12912 point at constant storage, so make it a const pointer.
fd4ead52 12913 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12914 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12915 signedness issues.
f839df0c
PE
12916 (Fset_file_times, Finsert_file_contents, auto_save_error):
12917 Rename locals to avoid shadowing.
f14b7e14 12918
5716756e 12919 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12920 (Ftry_completion, Fall_completions): Rename or remove locals
12921 to avoid shadowing.
5716756e 12922
b4c3046a
PE
12923 * marker.c (bytepos_to_charpos): Remove; unused.
12924
b45db522
PE
12925 * lisp.h (verify_bytepos, count_markers): New decls,
12926 so that gcc does not warn that these functions aren't declared.
12927
85876d07
PE
12928 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12929 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12930 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12931 (copy_text): Remove unused local var.
85876d07 12932
03d78a21 12933 * filelock.c (within_one_second): Now static.
b3dd38ab 12934 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12935
5df8f01b
PE
12936 * buffer.c (fix_overlays_before): Mark locals as initialized.
12937 (fix_start_end_in_overlays): Likewise. This function should be
12938 simplified by using pointers-to-pointers, but that's a different
12939 matter.
b1d876f1 12940 (switch_to_buffer_1): Now static.
8f54f30a
PE
12941 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12942 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12943
a70072c9 12944 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12945 Fix pointer signedness issue.
edced198
PE
12946 (sys_subshell): Mark local as volatile if checking for lint,
12947 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12948 (MAXPATHLEN): Define only if needed.
a70072c9 12949
a0977c44
PE
12950 * process.c (serial_open, serial_configure): Move decls from here ...
12951 * systty.h: ... to here, so that they can be checked.
12952
a884fdcc
PE
12953 * fns.c (get_random, seed_random): Move extern decls from here ...
12954 * lisp.h: ... to here, so that they can be checked.
12955
604efe86 12956 * sysdep.c (reset_io): Now static.
b8950c94 12957 (wait_for_termination_signal): Remove; unused.
604efe86 12958
38fc62d9
PE
12959 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12960 (copy_keymap_item, append_key, push_text_char_description):
12961 Now static.
1004a21a 12962 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12963 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12964 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12965 (describe_map_tree):
12966 Rename locals to avoid shadowing.
38fc62d9 12967
2f2650da
PE
12968 * keyboard.c: Declare functions static if they are not used elsewhere.
12969 (echo_char, echo_dash, cmd_error, top_level_2):
12970 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12971 (read_char, kbd_buffer_get_event, make_lispy_position):
12972 (make_lispy_event, make_lispy_movement, apply_modifiers):
12973 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12974 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12975 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12976 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12977 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12978
a053e86c 12979 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12980 (mark_kboards): Move decl here ...
12981 * alloc.c (mark_kboards): ... from here.
a053e86c 12982
4752793e
PE
12983 * lisp.h (force_auto_save_soon): New decl.
12984
74f10ca7 12985 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12986 (DEFINE_DUMMY_FUNCTION): New macro.
12987 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12988 Use it.
c03cd23f
PE
12989 (main): Add casts to avoid warnings
12990 if GCC considers string literals to be constants.
74f10ca7 12991
022e70d4
PE
12992 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12993
59d6fe83
PE
12994 * dbusbind.c: Pointer signedness fixes.
12995 (xd_signature, xd_append_arg, xd_initialize):
12996 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12997 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12998 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12999 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13000
78320123
PE
13001 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13002 if GCC considers string literals to be constants.
49cebcca 13003 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13004
35ac2a97
SM
130052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13006
fb103ca9
SM
13007 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13008 (print_preprocess, print_object): New macro to fix last change.
13009
35ac2a97
SM
13010 * print.c (print_preprocess): Don't forget font objects.
13011
62973b41
JB
130122011-03-16 Juanma Barranquero <lekktu@gmail.com>
13013
13014 * emacs.c (USAGE3): Doc fixes.
13015
0e48bb22
AS
130162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13017
13018 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13019 structure.
13020
7684e57b
JB
130212011-03-14 Juanma Barranquero <lekktu@gmail.com>
13022
13023 * lisp.h (VWindow_system, Qfile_name_history):
13024 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13025 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13026 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13027
13028 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13029 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13030
13031 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13032 * w32console.c (detect_input_pending, read_input_pending)
13033 (encode_terminal_code):
13034 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13035 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13036 (w32_system_caret_y, Qfile_name_history):
13037 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13038 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13039 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13040 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13041 * w32proc.c (Qlocal, report_file_error):
13042 * w32term.c (Vwindow_system, updating_frame):
13043 * w32uniscribe.c (initialized, uniscribe_font_driver):
13044 Remove unneeded extern declarations.
13045
2aa46d6c
CY
130462011-03-14 Chong Yidong <cyd@stupidchicken.com>
13047
c96bbc66 13048 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13049
cffc6f3b
CY
130502011-03-13 Chong Yidong <cyd@stupidchicken.com>
13051
13052 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13053 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13054 These macros can no longer be used for assignment.
13055
44f230aa
SM
13056 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13057 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13058 (record_buffer_markers, fetch_buffer_markers): New functions for
13059 recording and fetching special buffer markers.
13060 (set_buffer_internal_1, set_buffer_temp): Use them.
13061
13062 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13063
13064 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13065
13066 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13067 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13068
13069 * xdisp.c (hscroll_window_tree):
13070 (reconsider_clip_changes): Use PT instead of BUF_PT.
13071
d251f04b
EZ
130722011-03-13 Eli Zaretskii <eliz@gnu.org>
13073
13074 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13075 $(EMACS_ROOT)/lib/intprops.h.
13076
f0c77cd1
PE
130772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13078
3eca4629
PE
13079 Fix more problems found by GCC 4.5.2's static checks.
13080
7c86ee98
PE
13081 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13082 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13083 (xg_free_frame_widgets): Make it clear that a local variable is
13084 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13085 (gdk_window_get_screen): Make it clear that this macro is needed
13086 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13087 (int_gtk_range_get_value): New function, which avoids a diagnostic
13088 from gcc -Wbad-function-cast.
13089 (xg_set_toolkit_scroll_bar_thumb): Use it.
13090 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13091 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13092 (get_utf8_string, xg_get_file_with_chooser):
13093 Rename locals to avoid shadowing.
13094 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13095
41729b81
PE
13096 * xgselect.c (xg_select): Remove unused var.
13097
f0c77cd1
PE
13098 * image.c (four_corners_best): Mark locals as initialized.
13099 (gif_load): Initialize transparent_p to zero (Bug#8238).
13100 Mark another local as initialized.
ec6cf4c6 13101 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13102
ce0ad53d 13103 * image.c (clear_image_cache): Now static.
d5d5a617 13104 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13105 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13106 (x_edge_detection): Remove unnecessary cast that
13107 gcc -Wbad-function-cast diagnoses.
2037898d 13108 (gif_load): Fix pointer signedness.
6ae141d6
PE
13109 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13110 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13111
33383987 131122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13113
d32df629
PE
13114 Improve quality of tests for time stamp overflow.
13115 For example, without this patch (encode-time 0 0 0 1 1
13116 1152921504606846976) returns the obviously-bogus value (-948597
13117 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13118 reports time overflow. See
13119 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13120 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13121 * editfns.c: Include limits.h and intprops.h.
13122 (TIME_T_MIN, TIME_T_MAX): New macros.
13123 (time_overflow): Move earlier, to before first use.
13124 (hi_time, lo_time): New functions, for an accurate test for
13125 out-of-range times.
13126 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13127 (Fget_internal_run_time): Don't assume time_t fits in int.
13128 (make_time): Use list2 instead of Fcons twice.
13129 (Fdecode_time): More accurate test for out-of-range times.
13130 (check_tm_member): New function.
13131 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13132 (lisp_time_argument): Don't rely on undefined left-shift and
13133 right-shift behavior when checking for time stamp overflow.
8be6f318 13134
fe31d94c
PE
13135 * editfns.c (time_overflow): New function, refactoring common code.
13136 (Fformat_time_string, Fdecode_time, Fencode_time):
13137 (Fcurrent_time_string): Use it.
13138
8be6f318
PE
13139 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13140 * dired.c (make_time): Move to ...
13141 * editfns.c (make_time): ... here.
13142 * systime.h: Note the move.
13143
09d9db2c 131442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13145
126bc0dc
YM
13146 * fringe.c (update_window_fringes): Remove unused variables.
13147
c47cbdfd
YM
13148 * unexmacosx.c (copy_data_segment): Also copy __got section.
13149 (Bug#8223)
13150
7ac80be9
EZ
131512011-03-12 Eli Zaretskii <eliz@gnu.org>
13152
c96bbc66 13153 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13154 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13155 Constify `char *' arguments and their references according to
13156 prototypes in tparam.h.
13157
ecb0f94d 13158 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13159
7ac80be9
EZ
13160 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13161 Adapt all references accordingly.
13162
13163 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13164
ef1fd07e
TT
131652011-03-11 Tom Tromey <tromey@redhat.com>
13166
13167 * buffer.c (syms_of_buffer): Remove obsolete comment.
13168
7ef4b50c
EZ
131692011-03-11 Eli Zaretskii <eliz@gnu.org>
13170
13171 * termhooks.h (encode_terminal_code): Declare prototype.
13172
13173 * msdos.c (encode_terminal_code): Don't declare prototype.
13174
13175 * term.c (encode_terminal_code): Now external again, used by
13176 w32console.c and msdos.c.
13177
44f230aa
SM
13178 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13179 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13180
4b1ec863 131812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13182
1714f52b 13183 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13184
4b1ec863
PE
13185 * fringe.c (update_window_fringes): Mark locals as initialized
13186 (Bug#8227).
13187 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13188
524c7aa6
PE
13189 * alloc.c (mark_fringe_data): Move decl from here ...
13190 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13191 to check its interface.
13192 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13193
a5c0af81 13194 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13195 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13196 (fontset_font): Mark local as initialized.
a9a06e0b 13197 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13198
b4716021
PE
13199 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13200
811e9bac 13201 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13202 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13203 (x_own_selection, Fx_disown_selection_internal): Rename locals
13204 to avoid shadowing.
13205 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13206
7e3ab302
PE
13207 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13208 so that the caller can use some name other than gcpro1.
13209 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13210 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13211 (Fx_backspace_delete_keys_p):
13212 Use them to avoid shadowing, and rename vars to avoid shadowing.
13213 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13214 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13215 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13216 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13217 Remove unused locals.
7e3ab302
PE
13218 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13219 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13220 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13221 macros.
f78faa98 13222
e2b13473
PE
13223 * xterm.h (x_mouse_leave): New decl.
13224
77f23912
PE
13225 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13226 Remove unused functions.
cdf4ba58
PE
13227 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13228 (x_calc_absolute_position): Now static.
7411c686 13229 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13230 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13231 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13232 unless they are used.
38d0b34a
PE
13233 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13234 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13235 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13236 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13237 (x_error_catcher, x_connection_closed, x_error_handler):
13238 (x_error_quitter, xembed_send_message, x_iconify_frame):
13239 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13240 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13241 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13242
44f230aa
SM
13243 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13244 Rename or move locals to avoid shadowing.
6b463e58 13245 (tty_defined_color, merge_face_heights): Now static.
5967d051 13246 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13247 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13248 does not deduce is never used uninitialized.
73719eba
PE
13249 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13250 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13251
426994c3 13252 * terminal.c (store_terminal_param): Now static.
5489860b 13253
032f1620 13254 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13255 (set_frame_menubar): Remove unused local.
d4323972 13256 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13257 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13258 since they might point to immutable storage.
281585b0
PE
13259 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13260 since it's unused otherwise.
032f1620 13261
367c19e5 13262 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13263 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13264 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13265 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13266 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13267 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13268 does not deduce are never used uninitialized.
70739cbe 13269
07b48fa9
PE
13270 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13271
8868a238 13272 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13273 * window.c (window_loop, size_window):
13274 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13275
7e5cf297 13276 * window.c (display_buffer): Now static.
d6550a9f
PE
13277 (size_window): Mark variables that gcc -Wuninitialized
13278 does not deduce are never used uninitialized.
a586633d
PE
13279 * window.h (check_all_windows): New decl, to forestall
13280 gcc -Wmissing-prototypes diagnostic.
5b555da1 13281 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13282
f6095868
PE
13283 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13284 shadowing.
13285 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13286 Include <limits.h>.
13287 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13288 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13289 (load_charset_map): Mark variables that gcc -Wuninitialized
13290 does not deduce are never used uninitialized.
53df7c11 13291 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13292
f38b440c
PE
13293 * coding.c (coding_set_source, coding_set_destination):
13294 Use "else { /* comment */ }" rather than "else /* comment */;"
13295 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13296 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13297 a block, when the outer 'i' will do.
13298 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13299 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13300 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13301 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13302 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13303 Rename locals to avoid shadowing.
13304 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13305 * coding.c (emacs_mule_char, encode_invocation_designation):
13306 Now static, since they're not used elsewhere.
413bb2db 13307 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13308 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13309 (decode_coding_emacs_mule): Mark variables that gcc
13310 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13311 (detect_coding_iso_2022): Initialize a local variable that might
13312 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13313 this initialization is needed. (Bug#8211)
5f58e762
PE
13314 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13315 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13316 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13317 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13318 Remove unused macros.
f38b440c 13319
232b38b9 13320 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13321 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13322 * character.c (string_count_byte8): Likewise.
232b38b9 13323
fb90da1b
PE
13324 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13325 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13326
fb93dbc2
PE
13327 * chartab.c (copy_sub_char_table): Now static, since it's not used
13328 elsewhere.
5c156ace
PE
13329 (sub_char_table_ref_and_range, char_table_ref_and_range):
13330 Rename locals to avoid shadowing.
bbcd0949 13331 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13332
7d3b3862 13333 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13334 (BIDI_BOB): Remove unused macro.
7d3b3862 13335
6be7d3da
PE
13336 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13337 deduce are never used uninitialized.
c2ed9c8b 13338 * term.c (encode_terminal_code): Likewise.
6be7d3da 13339
75f8807f 13340 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13341
50938595
PE
13342 * tparam.h: New file.
13343 * term.c, tparam.h: Include it.
13344 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13345 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13346 Move these decls to tparam.h, and make them agree with what
13347 is actually in tparam.c. The previous trick of using incompatible
13348 decls in different modules does not conform to the C standard.
13349 All callers of tparam changed to use tparam's actual API.
13350 * tparam.c (tparam1, tparam, tgoto):
13351 Use const pointers where appropriate.
13352
fbceeba2
PE
13353 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13354 * cm.h (struct cm): Likewise.
13355 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13356 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13357 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13358 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13359 (turn_on_face, init_tty): Likewise.
13360 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13361
7f3f1250
PE
13362 * term.c (term_mouse_position): Rename local to avoid shadowing.
13363
e6ca6543
PE
13364 * alloc.c (mark_ttys): Move decl from here ...
13365 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13366
c40f8d15
AS
133672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13368
13369 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13370
cfe0661d
JB
133712011-03-09 Juanma Barranquero <lekktu@gmail.com>
13372
13373 * search.c (compile_pattern_1): Remove argument regp, unused since
13374 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13375 (compile_pattern): Don't pass it.
13376
0afb4571
J
133772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13378
13379 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13380 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13381 for ! HAVE_GTK3.
13382 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13383
13384 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13385
13386 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13387 gdk_window_get_screen, gdk_window_get_geometry,
13388 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13389 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13390 (xg_get_pixbuf_from_pixmap): New function.
13391 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13392 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13393 Call xg_get_pixbuf_from_pixmap instead of
13394 gdk_pixbuf_get_from_drawable.
13395 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13396 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13397 (xg_check_special_colors): Use GtkStyleContext and its functions
13398 for HAVE_GTK3.
13399 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13400 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13401 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13402 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13403 Call gtk_widget_get_preferred_size.
0afb4571
J
13404 (xg_frame_resized): gdk_window_get_geometry only takes 5
13405 parameters.
44f230aa
SM
13406 (xg_win_to_widget, xg_event_is_for_menubar):
13407 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13408 (xg_set_widget_bg): New function.
13409 (delete_cb): New function.
895009e1 13410 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13411 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13412 (xg_set_background_color): Call xg_set_widget_bg.
13413 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13414 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13415 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13416 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13417 if ! HAVE_GTK3.
13418 (update_frame_tool_bar): Call gtk_widget_hide.
13419 (xg_initialize): Use GDK_KEY_g.
13420
13421 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13422 if ! HAVE_GTK3
13423 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13424
13425 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13426 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13427 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13428
1c2cc4ef
JB
134292011-03-08 Juanma Barranquero <lekktu@gmail.com>
13430
13431 * w32xfns.c (select_palette): Check success of RealizePalette against
13432 GDI_ERROR, not zero.
13433
33383987 13434See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13435
13436;; Local Variables:
13437;; coding: utf-8
aac0c6e3
MR
13438;; End:
13439
2f097256 13440 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13441
13442 This file is part of GNU Emacs.
13443
13444 GNU Emacs is free software: you can redistribute it and/or modify
13445 it under the terms of the GNU General Public License as published by
13446 the Free Software Foundation, either version 3 of the License, or
13447 (at your option) any later version.
13448
13449 GNU Emacs is distributed in the hope that it will be useful,
13450 but WITHOUT ANY WARRANTY; without even the implied warranty of
13451 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13452 GNU General Public License for more details.
13453
13454 You should have received a copy of the GNU General Public License
13455 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.