Re-fill contributor list
[bpt/emacs.git] / src / ChangeLog
CommitLineData
77abcbc2
LI
12012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2
3 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4
90b671e2
EZ
52012-02-11 Eli Zaretskii <eliz@gnu.org>
6
1c0ca0b7
EZ
7 * w32select.c (Fx_selection_exists_p): Sync doc string and
8 argument list with xselect.c. (Bug#10783)
9
10 * w16select.c (Fx_selection_exists_p): Sync doc string and
11 argument list with xselect.c. (Bug#10783)
90b671e2 12
49241268
GM
132012-02-10 Glenn Morris <rgm@gnu.org>
14
15 * fns.c (Fsecure_hash): Doc fix.
16
f998bbe7 172012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
18
19 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
20
0992bd9c
CY
212012-02-07 Chong Yidong <cyd@gnu.org>
22
23 * buffer.c (Fbuffer_local_variables)
24 (buffer_lisp_local_variables): Handle unbound vars correctly;
25 don't let Qunbound leak into Lisp.
26
af008560
GM
272012-02-07 Glenn Morris <rgm@gnu.org>
28
dd605cc4
GM
29 * image.c (Fimagemagick_types): Doc fix.
30
af008560
GM
31 * image.c (imagemagick-render-type): Change it from a lisp object
32 to an integer. Move the doc here from the lisp manual.
33 Treat all values not equal to 0 the same.
34
1449fa1d
CY
352012-02-06 Chong Yidong <cyd@gnu.org>
36
37 * doc.c (store_function_docstring): Avoid applying docstring of
38 alias to base function (Bug#2603).
39
3723ec07
AS
402012-02-04 Andreas Schwab <schwab@linux-m68k.org>
41
42 * .gdbinit (pp1, pv1): Remove redundant defines.
43 (pr): Use pp.
44
79c1cc1e
CY
452012-02-04 Chong Yidong <cyd@gnu.org>
46
47 * nsterm.m: Declare a global (Bug#10694).
48
d7f29f8e
EZ
492012-02-04 Eli Zaretskii <eliz@gnu.org>
50
51 * w32.c (get_emacs_configuration_options): Include
52 --enable-checking, if specified, in the return value.
53
3b95a6f9
MR
542012-02-04 Martin Rudalics <rudalics@gmx.at>
55
56 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
57 after rounding frame sizes. (Bug#9723)
58
d6fa96a6
EZ
592012-02-04 Eli Zaretskii <eliz@gnu.org>
60
61 * keyboard.c (adjust_point_for_property): Don't position point
62 before BEGV. (Bug#10696)
63
df0b2940
PE
642012-02-03 Paul Eggert <eggert@cs.ucla.edu>
65
66 Handle overflow when computing char display width (Bug#9496).
67 * character.c (char_width): Return EMACS_INT, not int.
68 (char_width, c_string_width): Check for overflow when
69 computing the width; this is possible now that individual
70 characters can have unbounded width. Problem introduced
71 by merge from Emacs 23 on 2012-01-19.
72
6bee44d6
MA
732012-02-02 Michael Albinus <michael.albinus@gmx.de>
74
75 * dbusbind.c (Fdbus_register_method): Mention the return value
76 :ignore in the docstring.
77
44f92739
GM
782012-02-02 Glenn Morris <rgm@gnu.org>
79
1b9f60cc
GM
80 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
81
44f92739
GM
82 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
83 Unconditionally set to t. (Bug#10673)
84 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
85 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
86 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
87
c5d3843c
KH
882012-02-02 Kenichi Handa <handa@m17n.org>
89
90 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
91 0, do not call append_composite_glyph.
92
159462d4 932012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
94
95 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
96 NULL (Bug#6988).
97 (x_produce_glyphs): If the component of a composition is a null
98 string, set it->pixel_width to 1 to avoid zero-width glyph.
99
78cef877
EZ
1002012-02-01 Eli Zaretskii <eliz@gnu.org>
101
102 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
103 first 2 arguments are identical. This makes inserting large
104 output from a subprocess an order of magnitude faster on
105 MS-Windows, where all sbrk'ed memory is always contiguous.
106
97897668
GM
1072012-01-31 Glenn Morris <rgm@gnu.org>
108
109 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 110 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
111 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
112
31fd3586
GM
1132012-01-29 Glenn Morris <rgm@gnu.org>
114
115 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
116
0e24a8b2
CY
1172012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
118
119 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
120
cc0adcb0
CY
1212012-01-28 Chong Yidong <cyd@gnu.org>
122
123 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
124
acc28cb9
CY
1252012-01-26 Chong Yidong <cyd@gnu.org>
126
9c69cfb7
CY
127 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
128
acc28cb9
CY
129 * search.c (Fsearch_forward, Fsearch_backward): Document negative
130 repeat counts (Bug#10507).
131
48da7392
GM
1322012-01-26 Glenn Morris <rgm@gnu.org>
133
134 * lread.c (syms_of_lread): Doc fix.
135
14af5f7f
CY
1362012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
137
138 * coding.c (encode_designation_at_bol): Change return value to
139 EMACS_INT.
140
0b21c100
CY
1412012-01-25 Chong Yidong <cyd@gnu.org>
142
143 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
144
3c2907f7
CY
1452012-01-21 Chong Yidong <cyd@gnu.org>
146
147 * floatfns.c (Fcopysign): Make the second argument non-optional,
148 since nil is not allowed anyway.
149
959ad23f
AS
1502012-01-21 Andreas Schwab <schwab@linux-m68k.org>
151
152 * process.c (read_process_output): Use p instead of XPROCESS (proc).
153 (send_process): Likewise.
154
34a02f46
MR
1552012-01-19 Martin Rudalics <rudalics@gmx.at>
156
157 * window.c (save_window_save, Fcurrent_window_configuration)
158 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
159 doc-strings.
160
1259009a 1612012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
162
163 * character.c (char_width): New function.
70d4fdf6
GM
164 (Fchar_width, c_string_width, lisp_string_width):
165 Use char_width (Bug#9496).
25ed9e61 166
6a6ee00d
MR
1672012-01-16 Martin Rudalics <rudalics@gmx.at>
168
169 * window.c (Vwindow_persistent_parameters): New variable.
170 (Fset_window_configuration, save_window_save): Handle persistent
171 window parameters.
172
c85efaf7
EZ
1732012-01-14 Eli Zaretskii <eliz@gnu.org>
174
175 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
176 thrashing the stack of the thread. (Bug#9087)
177
5944709e
PE
1782012-01-12 Paul Eggert <eggert@cs.ucla.edu>
179
180 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
181
e71f5d99
EZ
1822012-01-11 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (rows_from_pos_range): Handle the case where the
185 highlight ends on a newline. (Bug#10464)
186 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
187 he end column for display of highlight that ends on a newline
188 before a R2L line.
189
ce316182
GM
1902012-01-11 Glenn Morris <rgm@gnu.org>
191
192 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
193 from load-path also when installation-directory is nil. (Bug#10208)
194
5b43da69
GM
1952012-01-10 Glenn Morris <rgm@gnu.org>
196
74cc8ff9
GM
197 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
198
7d8d6e4e
GM
199 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
200 Update template values to be closer to their typical values these days.
5b43da69 201
a0db8d43
EZ
2022012-01-09 Eli Zaretskii <eliz@gnu.org>
203
204 * xdisp.c (rows_from_pos_range): Accept additional argument
205 DISP_STRING, and accept any glyph in a row whose object is that
206 string as eligible for mouse highlight. Fixes mouse highlight of
207 display strings from overlays. (Bug#10464)
208
9a0115ab 2092012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 210
b9110d6a 211 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
212 * fileio.c (auto_saving_dir_umask): New static var.
213 (Fmake_directory_internal): Use it.
214 (do_auto_save_make_dir): Set it, instead of invoking chmod after
215 creating the directory. The old code temporarily assigns
216 too-generous permissions to the directory.
217 (do_auto_save_eh): Clear it.
b9110d6a 218 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
219 that the var is always cleared.
220
6c1bd3f3
EZ
2212012-01-07 Eli Zaretskii <eliz@gnu.org>
222
223 * search.c (scan_buffer): Pass character positions to
224 know_region_cache, not byte positions. (Bug#6540)
225
069d2b50
L
2262012-01-07 LynX <_LynX@bk.ru> (tiny change)
227
228 * w32.c (sys_rename): Report EXDEV when rename of a directory
229 fails because the target is on another logical disk. (Bug#10284)
230
75bf0d33
DB
2312012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
232
233 * xterm.c (x_embed_request_focus): New function.
234
235 * xterm.h: Add prototype.
236
237 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
238
1c6e5a32
GM
2392012-01-05 Glenn Morris <rgm@gnu.org>
240
241 * emacs.c (emacs_copyright): Update short copyright year to 2012.
242
651e947e
EZ
2432012-01-01 Eli Zaretskii <eliz@gnu.org>
244
245 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
246 Load gnutls_transport_set_lowat only if GnuTLS version is below
247 2.11.1.
248 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
249 GnuTLS versions below 2.11.1.
250
3778cdd8
AL
2512011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
252
253 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
254 to the doc string advising against its use for altering the way
255 windows are scrolled.
256
0e5317f7
KH
2572011-12-28 Kenichi Handa <handa@m17n.org>
258
259 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
260 coding-system ASCII compatible only when it does not produce BOM
261 on encoding (Bug#10383).
262
93d5ca1f
JD
2632011-12-26 Jan Djärv <jan.h.d@swipnet.se>
264
265 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
266 can scroll.
267 (create_and_show_popup_menu): Always use menu_position_func for
268 Gtk3 (Bug#10361).
269
ca22b785
AS
2702011-12-24 Andreas Schwab <schwab@linux-m68k.org>
271
272 * callint.c (Fcall_interactively): Don't truncate prompt string.
273
d048e1e6
EZ
2742011-12-23 Eli Zaretskii <eliz@gnu.org>
275
276 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
277 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 278 resumed from there (after widening). (Bug#10360)
d048e1e6 279
5ccaba1f
JD
2802011-12-22 Jan Djärv <jan.h.d@swipnet.se>
281
282 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
283
204ee57f
JD
2842011-12-21 Jan Djärv <jan.h.d@swipnet.se>
285
b81d40f0
JB
286 * nsterm.m (x_free_frame_resources):
287 Release f->output_data.ns->miniimage.
204ee57f
JD
288 (ns_index_color): Fix indentation. Do not retain
289 color_table->colors[i].
290
291 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
292 before returning.
293
294 * nsfns.m (x_set_background_color): Assign return value from
295 ns_index_color to face-background instead of NSColor*.
296 (ns_implicitly_set_icon_type): Fix indentation.
297 Change assignment in for loop to comparison.
298
299 * emacs.c (ns_pool): New variable.
300 (main): Assign ns_pool.
301 (Fkill_emacs): Call ns_release_autorelease_pool.
302
303 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
304 autorelease fdesc, release fdAttrs and tdict.
305 (ns_get_covering_families): Release charset.
306 (ns_findfonts): Release NSFontDescriptor created with new.
307 (ns_uni_to_glyphs): Fix indentation.
308 (setString): Release attrStr before assigning new value.
309
c803b2b7
JD
3102011-12-18 Jan Djärv <jan.h.d@swipnet.se>
311
678f4426
JD
312 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
313 and NS_IMPL_COCOA.
314 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
315 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
316
cd394be1 3172011-12-18 David Reitter <reitter@cmu.edu>
678f4426 318
5fecd5fc
JD
319 * nsterm.m (ns_term_init): Subscribe for notifications
320 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
321 to method trackingNotification in EmacsMenu.
322
323 * nsmenu.m (trackingMenu): New variable.
3771cb17 324 (trackingNotification): New method (from Aquamacs).
5fecd5fc 325 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 326 from Aquamacs (Bug#7030).
678f4426
JD
327
3282011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 329
c803b2b7
JD
330 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
331 (symbol_to_nsstring): Fix indentation.
332 (ns_symbol_to_pb): New function.
333 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
334 (Fns_rotate_cut_buffers_internal): Removed.
335 (Fns_store_selection_internal): Renamed from
336 Fns_store_cut_buffer_internal.
337 (ns_get_foreign_selection, Fx_own_selection_internal)
338 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
339 (Fns_get_selection_internal, Fns_store_selection_internal):
340 Use ns_symbol_to_pb and check if return value is nil.
341 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
342 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
343 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
344 renamed to Sns_store_selection_internal.
345 (ns_handle_selection_request): Move code to Fx_own_selection_internal
346 and remove this function.
347 (ns_handle_selection_clear): Remove, never used.
348 (Fx_own_selection_internal): Move code from ns_handle_selection_request
349 here.
350
e1b01a3a
KB
3512011-12-17 Ken Brown <kbrown@cornell.edu>
352
353 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
354 GID is unknown (Bug#10257).
355
2adb6e85
PE
3562011-12-17 Paul Eggert <eggert@cs.ucla.edu>
357
358 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
359 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
360 which caused a build failure on GNU/Linux IA-64. This problem was
361 introduced by my 2011-10-07 patch.
362
d1d7b339
JL
3632011-12-15 Juri Linkov <juri@jurta.org>
364
365 * image.c (imagemagick_error): New function. (Bug#10112)
366 (imagemagick_load_image): Comment out `MagickSetResolution' call.
367 Use `imagemagick_error' where ImageMagick functions return
368 `MagickFalse'.
369 (Fimagemagick_types): Add `Fnreverse' to return the list in the
370 proper order.
371
100d5755
KH
3722011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
373
374 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
375 fill background (Bug#8992).
376
454592a6
MR
3772011-12-13 Martin Rudalics <rudalics@gmx.at>
378
379 * window.c (Vwindow_combination_resize)
380 (Vwindow_combination_limit): Use t instead of non-nil in
381 doc-strings.
61d4b438
MR
382 (Vrecenter_redisplay): Add first sentence of doc-string on
383 separate line.
53524d93 384 (Frecenter): Fix doc-string typo.
454592a6 385
3633e3aa
KH
3862011-12-11 Kenichi Handa <handa@m17n.org>
387
388 * coding.c (Funencodable_char_position): Pay attention to the
389 buffer text relocation (Bug#9389).
390
7b9d523a
JD
3912011-12-10 Jan Djärv <jan.h.d@swipnet.se>
392
393 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
394 gtk_init (Bug#10100).
395
b73189c6
EZ
3962011-12-10 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
399 IT->string is nil. (Bug#10263)
400
f7dfe5d6
JD
4012011-12-10 Jan Djärv <jan.h.d@swipnet.se>
402
83faebb4
JD
403 * nsterm.h (x_free_frame_resources): Declare.
404
f7dfe5d6
JD
405 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
406 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
407
408 * nsterm.h (ns_get_defaults_value): Declare.
409
410 * nsterm.m (ns_default): Call ns_get_defaults_value.
411
7cd4e72c
EZ
4122011-12-09 Eli Zaretskii <eliz@gnu.org>
413
414 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
415 (Bug#10170)
416
b34d7317
YM
4172011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
418
419 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
420 that where the value of an _OBJC_* symbol points to is in the .bss
421 section (Bug#10240).
422
76470ad1
KH
4232011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
424
425 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 426 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 427
745fff94
KH
4282011-12-08 Kenichi Handa <handa@m17n.org>
429
430 * ftfont.c (get_adstyle_property): Fix previous change
431 (Bug#10233).
432
6e44397c
JB
4332011-12-07 Juanma Barranquero <lekktu@gmail.com>
434
435 * w32.c (init_environment): If no_site_lisp, remove site-lisp
436 dirs from the default value of EMACSLOADPATH (bug#10208).
437
7efa6272
GM
4382011-12-07 Glenn Morris <rgm@gnu.org>
439
440 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
441 installation and source directories as well. (Bug#10208)
442
f6fc4d87
CY
4432011-12-06 Chong Yidong <cyd@gnu.org>
444
445 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
446
2bf26180
GM
4472011-12-06 Glenn Morris <rgm@gnu.org>
448
449 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
450 as an error, not just -1. (Bug#10217)
451
3a6ad4f0
CY
4522011-12-05 Chong Yidong <cyd@gnu.org>
453
454 * keyboard.c (process_special_events): New function.
455 (swallow_events, Finput_pending_p): Use it (Bug#10195).
456
75a3b399
PE
4572011-12-05 Paul Eggert <eggert@cs.ucla.edu>
458
459 * coding.c (encode_designation_at_bol): Don't use uninitialized
460 local variable (Bug#9318).
461
c3c9e25e
KH
4622011-12-05 Kenichi Handa <handa@m17n.org>
463
464 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
465 return Qnil (Bug#8046, Bug#10193).
466
5eb05ea3
KH
4672011-12-05 Kenichi Handa <handa@m17n.org>
468
469 * coding.c (encode_designation_at_bol): New args charbuf_end and
470 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
471 (coding_set_source): Return how many bytes coding->source was
472 relocated.
473 (coding_set_destination): Return how many bytes
474 coding->destination was relocated.
475 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
476 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
477
4782011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
479
480 * coding.c (CODING_CHAR_CHARSET_P): New macro.
481 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
482 macro (Bug#9318).
483
4842011-12-05 Andreas Schwab <schwab@linux-m68k.org>
485
486 The following changes are to fix Bug#9318.
487
a79703f5 488 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
489 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
490 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 491 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 492
7dbda6df
JB
4932011-12-05 Juanma Barranquero <lekktu@gmail.com>
494
495 * lisp.h (process_quit_flag): Fix external declaration.
496
6d5eb5b0
SM
4972011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
498
499 Don't macro-inline non-performance-critical code.
500 * eval.c (process_quit_flag): New function.
501 * lisp.h (QUIT): Use it.
502
a0c3fad0
JD
5032011-12-04 Jan Djärv <jan.h.d@swipnet.se>
504
505 * nsfns.m (get_geometry_from_preferences): New function.
506 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
507
6c07aac2
AS
5082011-12-04 Andreas Schwab <schwab@linux-m68k.org>
509
510 * emacs.c (Qkill_emacs): Define.
511 (syms_of_emacs): Initialize it.
512 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
513 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
514 (quit_throw_to_read_char): Add parameter `from_signal'.
515 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
516 * lisp.h (QUIT): Call Fkill_emacs if requested.
517
c052ead4
JD
5182011-12-03 Jan Djärv <jan.h.d@swipnet.se>
519
520 * widget.c (update_wm_hints): Return if wmshell is null.
521 (widget_update_wm_size_hints): New function.
522
523 * widget.h (widget_update_wm_size_hints): Declare.
524
525 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
526 widget_update_wm_size_hints (Bug#10104).
527
9e49252b
EZ
5282011-12-03 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (handle_invisible_prop): If the invisible text ends just
531 before a newline, prepare the bidi iterator for consuming the
532 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 533 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 534
02b16839
JL
5352011-12-02 Juri Linkov <juri@jurta.org>
536
537 * search.c (Fword_search_regexp): New Lisp function created from
538 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
539 (Fword_search_backward, Fword_search_forward)
540 (Fword_search_backward_lax, Fword_search_forward_lax):
541 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
542 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
543
0068070e
SM
5442011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
545
546 * fileio.c (Finsert_file_contents): Move after-change-function call
547 to before the "handled:" label, since all "goto handled" appear in
548 cases where the *-change-functions have already been properly called
549 (bug#10117).
550
3360a3fc
AS
5512011-12-01 Andreas Schwab <schwab@linux-m68k.org>
552
553 * keyboard.c (interrupt_signal): Don't call kill-emacs when
554 waiting for input. (Bug#10169)
555
73d6c093
EZ
5562011-11-30 Eli Zaretskii <eliz@gnu.org>
557
558 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
559 verifies glyph row's hash code--we have just reallocated the
560 glyphs, so their contents can be complete garbage. (Bug#10164)
561
febe6bea
JB
5622011-11-30 Juanma Barranquero <lekktu@gmail.com>
563
564 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
565
801a4313
EZ
5662011-11-30 Eli Zaretskii <eliz@gnu.org>
567
568 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
569 attributes are tested _before_ calling verify_row_hash, to protect
570 against GCC re-ordering of the tests. (Bug#10164)
571
2b56b87e
JD
5722011-11-29 Jan Djärv <jan.h.d@swipnet.se>
573
574 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
575
576 * xterm.c (handle_one_xevent): Only set async_visible and friends
577 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 578 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
579 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
580
dbf31225
PE
5812011-11-28 Paul Eggert <eggert@cs.ucla.edu>
582
583 Remove GCPRO-related macros that exist only to avoid shadowing locals.
584 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
585 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
586 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
587 All uses changed to use GCPRO1 etc.
588 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
589 Revert to old implementation (i.e., before 2011-03-11).
590
1305621b
YM
5912011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
592
593 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
594 of scroll runs so as to avoid assigning disabled bogus rows and
595 unnecessary graphics copy operations.
596
8c9afb46
EZ
5972011-11-27 Eli Zaretskii <eliz@gnu.org>
598
599 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
600 (snprintf) [_MSC_VER]: Redirect to _snprintf.
601 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
602 (malloc, free, realloc, calloc): Redirect to e_* only when
603 compiling Emacs.
604
605 * lisp.h (GCTYPEBITS): Move before first use.
606 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
607 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
608 this macro definition.
609
610 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
611 _MSC_VER.
612
54e9e3bf
JD
6132011-11-27 Jan Djärv <jan.h.d@swipnet.se>
614
6d5eb5b0
SM
615 * gtkutil.c (xg_create_frame_widgets):
616 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
617 present with Gtk+ 2.0.
618
83aca1cb
PE
6192011-11-26 Paul Eggert <eggert@cs.ucla.edu>
620
621 * fileio.c (Finsert_file_contents): Undo previous change; see
622 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
623
5b76caa4
PE
6242011-11-26 Paul Eggert <eggert@cs.ucla.edu>
625
626 Rename locals to avoid shadowing.
627 * fileio.c (Finsert_file_contents):
628 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
629 * process.c (wait_reading_process_output):
630 Rename inner 'proc' to 'p' to avoid shadowing.
631 Indent for consistency with usual Emacs style.
632
8c535114
EZ
6332011-11-25 Eli Zaretskii <eliz@gnu.org>
634
635 * xdisp.c (redisplay_window): If cursor row is not fully visible
636 after recentering, and scroll-conservatively is set to a large
637 number, scroll window by a few more lines to make the cursor fully
638 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
639 (start_display): Don't move to the next line if the display should
640 start at a newline that is part of a display vector or an overlay
641 string. (Bug#10119)
8c535114 642
fa4fdb5c
JL
6432011-11-24 Juri Linkov <juri@jurta.org>
644
645 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
646 after the `MagickPingImage' call. (Bug#10112)
647
90ec88df
CY
6482011-11-23 Chong Yidong <cyd@gnu.org>
649
650 * window.c (Fcoordinates_in_window_p): Accept only live windows.
651
56e2e794
MR
6522011-11-23 Martin Rudalics <rudalics@gmx.at>
653
654 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
655 making another buffer current. (Bug#10114)
656
b6e64c41
GM
6572011-11-23 Glenn Morris <rgm@gnu.org>
658
659 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
660
6b21de18
CY
6612011-11-23 Chong Yidong <cyd@gnu.org>
662
663 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
664 using it (Bug#5984).
665
b12cd789
EZ
6662011-11-22 Eli Zaretskii <eliz@gnu.org>
667
668 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
669 and header-lines, as they don't have one computed for them.
670 (Bug#10098)
671
672 * .gdbinit (prow): Make displayed values more self-explaining.
673 Add row's hash code.
674
261b6fd4
LMI
6752011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
676
677 * process.c (wait_reading_process_output): Fix asynchrounous
678 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 679 (wait_reading_process_output): Add comment and URL.
261b6fd4 680
e7cfd277
JD
6812011-11-21 Jan Djärv <jan.h.d@swipnet.se>
682
683 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
684
a9b9b7f5
CY
6852011-11-21 Chong Yidong <cyd@gnu.org>
686
687 * window.c (Fnext_window, Fprevious_window): Doc fix.
688
b0d15b4f
SM
6892011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
690
691 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
692
fe7a3057
JB
6932011-11-20 Juanma Barranquero <lekktu@gmail.com>
694
695 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
696
d2999b1a
MR
6972011-11-20 Martin Rudalics <rudalics@gmx.at>
698
699 * window.c (Fset_window_combination_limit): Rename argument
700 STATUS to LIMIT.
701 (Vwindow_combination_limit): Remove "status" from doc-string.
702
d5ff9cd0
AS
7032011-11-20 Andreas Schwab <schwab@linux-m68k.org>
704
705 * m/ibms390.h: Remove.
706 * m/ibms390x.h: Don't include "ibms390.h".
707
a5bb9bd3
SM
7082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
711 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
712
cd1181db
JB
7132011-11-20 Juanma Barranquero <lekktu@gmail.com>
714
715 * casetab.c (Fset_case_table):
716 * charset.c (Fcharset_after): Fix typos.
717
615a3b8d 7182011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 719
17e845af
PE
720 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
721 Otherwise, valgrind does not work on some platforms.
722 Problem reported by Andreas Schwab in
6a0bf43d
PE
723 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
724 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
725 is set, removing the need for VIRT_ADDRESS_VARIES.
726 (PURE_P): Use a more-efficient implementation that needs just one
727 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
728 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
729 to 4 (xorl, subq, cmpq, setbe).
730 * alloc.c (pure): Always extern now, since that's the
731 VIRT_ADDR_VARIES behavior.
732 (PURE_POINTER_P): Use a single comparison, not two, for
733 consistency with the new puresize.h.
734 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
735 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
736 Remove VIRT_ADDR_VARIES no longer needed.
737
f8fe6f96
EZ
7382011-11-19 Eli Zaretskii <eliz@gnu.org>
739
740 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
741 (erase_phys_cursor, update_window_cursor, show_mouse_face)
742 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
743 behave as if the cursor position were at the window margin.
744
745 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
746 and the cursor position is out of bounds, behave as if the cursor
747 position were at the window margin. (Bug#10075)
748
df05a53c
CY
7492011-11-18 Chong Yidong <cyd@gnu.org>
750
751 * window.c (Fwindow_combination_limit): Make first argument
752 non-optional, since it is meaningless for live windows like the
753 selected window.
754
2071918e
DA
7552011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
756
757 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
758
b50a28de
SM
7592011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
760
761 * intervals.c: Fix grafting over the whole buffer (bug#10071).
762 (graft_intervals_into_buffer): Simplify.
763
015137db
EZ
7642011-11-18 Eli Zaretskii <eliz@gnu.org>
765
766 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
767 hash values of the two rows.
768 (copy_row_except_pointers): Preserve the used[] arrays and the
769 hash values of the two rows. (Bug#10035)
68c95424 770 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
771
772 * xdisp.c (row_hash): New function, body extracted from
773 compute_line_metrics.
774 (compute_line_metrics): Call row_hash, instead of computing the
775 hash code inline.
776
777 * dispnew.c (verify_row_hash): Call row_hash for computing the
778 hash code of a row, instead of duplicating code from xdisp.c.
779
780 * dispextern.h (row_hash): Add prototype.
781
a2addb04
TH
7822011-11-18 Tassilo Horn <tassilo@member.fsf.org>
783
784 * frame.c (delete_frame): Don't delete the terminal when the last
785 X frame is closed if emacs is built with GTK toolkit.
786
df85d315
JB
7872011-11-17 Juanma Barranquero <lekktu@gmail.com>
788
789 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
790
a0c2d0ae
MR
7912011-11-17 Martin Rudalics <rudalics@gmx.at>
792
793 * window.c (Vwindow_splits): Rename to
794 Vwindow_combination_resize. Suggested by Juri Linkov.
795 (Fsplit_window_internal): Use Vwindow_combination_resize instead
796 of Vwindow_splits.
797
58179cce
JB
7982011-11-16 Juanma Barranquero <lekktu@gmail.com>
799
7877f373
JB
800 * nsfns.m (Fns_font_name):
801 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 802
b6f67890
MR
8032011-11-16 Martin Rudalics <rudalics@gmx.at>
804
805 * window.h (window): Rename slot "nest" to "combination_limit".
806 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
807 (Fset_window_nest): Rename to Fset_window_combination_limit.
808 (Vwindow_nest): Rename to Vwindow_combination_limit.
809 (recombine_windows, make_parent_window, make_window)
810 (Fsplit_window_internal, saved_window)
811 (Fset_window_configuration, save_window_save): Rename all
812 occurrences of window_nest to window_combination_limit.
813
c7015153
JB
8142011-11-15 Juanma Barranquero <lekktu@gmail.com>
815
816 * image.c (imagemagick_load_image): Fix typo.
817
322ad6ec
EZ
8182011-11-14 Eli Zaretskii <eliz@gnu.org>
819
820 * xdisp.c (display_line): Move the call to
821 highlight_trailing_whitespace before the call to
822 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
823 faces of all the glyphs to compute ROW's hash value.
824 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 825
f067b8ec
JB
8262011-11-14 Juanma Barranquero <lekktu@gmail.com>
827
828 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
829 just return (bug#10044).
830
1e5b2111
EZ
8312011-11-12 Eli Zaretskii <eliz@gnu.org>
832
7ef3cbd5
EZ
833 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
834 with user-defined heap size. Bump the default size of the temacs
835 heap to 27MB, to avoid memory warning when running temacs.
836 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
837
1e5b2111
EZ
838 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
839 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
840 (verify_row_hash) [XASSERTS]: New function.
841 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
842 that the hash value of glyph rows is correct.
1e5b2111 843
89d61221
MR
8442011-11-12 Martin Rudalics <rudalics@gmx.at>
845
846 * window.h (window): Remove splits slot.
847 * window.c (Fwindow_splits, Fset_window_splits): Remove.
848 (Fdelete_other_windows_internal, make_parent_window)
849 (make_window, Fsplit_window_internal, Fdelete_window_internal)
850 (Fset_window_configuration, save_window_save): Don't deal with
851 split status of windows.
852 (saved_window): Remove splits slot.
853 (Vwindow_splits): Rewrite doc-string.
854
97f18cc8
JD
8552011-11-11 Jan Djärv <jan.h.d@swipnet.se>
856
857 * xfns.c (unwind_create_frame):
858 * nsfns.m (unwind_create_frame):
859 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
860 Vframe_list (Bug#9999).
861
22a648b4
DA
8622011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
863
0b381c7e 864 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 865
659afede
KH
8662011-11-11 Kenichi Handa <handa@m17n.org>
867
868 * callproc.c (Fcall_process): Set the member dst_multibyte of
869 process_coding.
870
9ac0394b
KH
8712011-11-11 Johan Bockgård <bojohan@gnu.org>
872
873 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
874 avoid a crash (bug#9496).
875
2fbdc249
CY
8762011-11-09 Chong Yidong <cyd@gnu.org>
877
878 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
879 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
880
ac6b1f81
PE
8812011-11-08 Paul Eggert <eggert@cs.ucla.edu>
882
883 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
884
09db192c
PE
8852011-11-08 Paul Eggert <eggert@cs.ucla.edu>
886
887 Avoid some portability problems by eschewing 'extern inline' functions.
888 The trivial performance wins aren't worth the portability hassles; see
889 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
890 et seq.
891 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
892 (window_box_width, window_box_left, window_box_left_offset)
893 (window_box_right, window_box_right_offset): Undo previous change,
894 by removing the "extern"s.
895 * intervals.c (adjust_intervals_for_insertion)
896 (adjust_intervals_for_deletion): Undo previous change,
897 making these static again.
898 (offset_intervals, temp_set_point_both, temp_set_point)
899 (copy_intervals_to_string): No longer inline.
900 * xdisp.c (window_text_bottom_y, window_box_width)
901 (window_box_height, window_box_left_offset)
902 (window_box_right_offset, window_box_left, window_box_right)
903 (window_box): No longer inline.
904
105216ed
CY
9052011-11-08 Chong Yidong <cyd@gnu.org>
906
907 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
908 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
909 Signal an error if not a live window.
105216ed
CY
910 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
911 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
912
ae9e237f
JB
9132011-11-07 Juanma Barranquero <lekktu@gmail.com>
914
915 * lisp.h (syms_of_abbrev): Remove declaration.
916 Reported by CHENG Gao <chenggao@royau.me>.
917
c7aa8333
EZ
9182011-11-07 Eli Zaretskii <eliz@gnu.org>
919
920 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
921 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
922 of temacs in GUI mode.
923
be7f5545
MR
9242011-11-07 Martin Rudalics <rudalics@gmx.at>
925
926 * window.h: Declare delete_all_child_windows instead of
927 delete_all_subwindows.
928 * window.c (Fwindow_nest, Fset_window_nest)
929 (Fset_window_new_total, Fset_window_new_normal)
930 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
931 (delete_all_subwindows): Rename to delete_all_child_windows.
932 (Fdelete_other_windows_internal, Fset_window_configuration):
933 Call delete_all_child_windows instead of delete_all_subwindows.
934 * frame.c (delete_frame): Call delete_all_child_windows instead
935 of delete_all_subwindows.
936
ca78dc43
PE
9372011-11-07 Paul Eggert <eggert@cs.ucla.edu>
938
939 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
940 This is also needed for porting to any host where GC_MARK_STACK is
941 not GC_MAKE_GCPROS_NOOPS.
942 (which_symbols): Use it.
943
a0241d01
KH
9442011-11-07 Kenichi Handa <handa@m17n.org>
945
946 * coding.c (coding_set_destination): Check coding->src_pos only
947 when coding->src_object is a buffer (bug#9910).
948
949 * process.c (send_process): Set the member src_multibyte of coding
950 to 0 (bug#9911) when sending a unibyte text.
951
952 * callproc.c (Fcall_process): Set the member src_multibyte of
953 process_coding to 0 (bug#9912).
954
a64bfdfa 9552011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
956
957 * xmenu.c (cleanup_widget_value_tree): New function.
958 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
959 calling free_menubar_widget_value_tree directly (Bug#9830).
960
cb41b32a
PE
9612011-11-06 Paul Eggert <eggert@cs.ucla.edu>
962
963 Fix some portability problems with 'inline'.
964 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
965 (window_box_width, window_box_left, window_box_left_offset)
966 (window_box_right, window_box_right_offset): Declare extern.
967 Otherwise, these inline functions do not conform to C99 and
968 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
969 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
970 * intervals.c (adjust_intervals_for_insertion)
971 (adjust_intervals_for_deletion): Now extern, because otherwise the
972 extern inline functions 'offset_intervals' couldn't refer to it.
973 (static_offset_intervals): Remove.
974 (offset_intervals): Rewrite using the old contents of
975 static_offset_intervals. The old version didn't conform to C99
976 because an extern inline function contained a reference to an
977 identifier with static linkage.
978
b7041366
AS
9792011-11-06 Andreas Schwab <schwab@linux-m68k.org>
980
981 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
982 GC.
983
88a37c4d
EZ
9842011-11-06 Eli Zaretskii <eliz@gnu.org>
985
986 * xdisp.c (init_iterator, reseat_to_string): Don't set the
987 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
988 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
989 return Qleft_to_right.
990
49745b39
CY
9912011-11-06 Chong Yidong <cyd@gnu.org>
992
993 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
994 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
995 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
996 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
997 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
998 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
999 (Fwindow_vscroll): Doc fix.
1000 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1001 argument, since it makes no sense to pass a live window and for
1002 consistency with window-child.
1003
1f05cd82
CS
10042011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1005
1006 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1007 support MSVC.
1008
22610910
JR
10092011-11-05 Jason Rumney <jasonr@gnu.org>
1010
1011 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1012 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1013 fonts (Bug#6029).
1014 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1015 bitwise arithmetic preventing use of unicode-sip and non-truetype
1016 opentype fonts.
1017
a06776b2
EZ
10182011-11-05 Eli Zaretskii <eliz@gnu.org>
1019
3ad924ba
EZ
1020 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1021 "emacs"-only part.
1022
a06776b2
EZ
1023 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1024 initialization code to keep similarity to xfns.c after changes
1025 from 2011-11-05.
1026
c9e7db78
JD
10272011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1028
a97f8f3f
JD
1029 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1030 (unwind_create_frame): New function (Bug#9943).
1031 (Fx_create_frame): Restructure code to be more similar to the one in
1032 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1033 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1034 Move terminal->reference_count++ just before making the frame official
1035 (Bug#9943).
1036
1037 * nsterm.m (x_free_frame_resources): New function.
1038 (x_destroy_window): Move code to x_free_frame_resources.
1039
c9e7db78 1040 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1041 (Fx_create_frame, x_create_tip_frame):
1042 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1043 official. Move initialization of image_cache_refcount and
1044 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1045
a6fc3b5c
EZ
10462011-11-05 Eli Zaretskii <eliz@gnu.org>
1047
1048 Support MSVC build with newer versions of Visual Studio.
1049 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1050 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1051 nt/gmake.defs.
1052
1053 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1054 which are not supported by MSVC.
1055 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1056 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1057 bitfields.
1058 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1059 types in bitfields.
1060 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1061
1062 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1063
58179cce 10642011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1065
1066 Support MSVC build with newer versions of Visual Studio.
1067 * w32.c: Don't include w32api.h for MSVC.
1068 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1069
1070 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1071 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1072 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1073 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1074 e_* cousins.
1075 (alloca) [_MSC_VER]: Define to _alloca.
1076
1077 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1078
1079 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1080
a58c13ed
EZ
10812011-11-04 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (note_mouse_highlight): If either of
1084 previous/next-single-property-change returns nil, treat that as
1085 the beginning or the end of the buffer. (Bug#9955)
1086
fe0b6370
JD
10872011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1088
a58c13ed 1089 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1090 label is not null (Bug#9951).
1091 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1092 may be NULL.
1093
89bd5ee1
EZ
10942011-11-04 Eli Zaretskii <eliz@gnu.org>
1095
1096 * window.c (Fwindow_body_size): Mention in the doc string that the
1097 return value is in frame's canonical units. (Bug#9949)
1098
84c3edb9
EZ
10992011-11-03 Eli Zaretskii <eliz@gnu.org>
1100
4e2fb5c7
EZ
1101 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1102
84c3edb9 1103 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1104 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1105 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1106
bc17a887
EZ
11072011-11-01 Eli Zaretskii <eliz@gnu.org>
1108
1109 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1110 Don't stop backward scan on the continuation glyph, even though
1111 its CHARPOS is positive.
6d5eb5b0
SM
1112 (mouse_face_from_buffer_pos, note_mouse_highlight):
1113 Rename cover_string to disp_string.
bc17a887 1114
4ee88440
MR
11152011-11-01 Martin Rudalics <rudalics@gmx.at>
1116
1117 * window.c (temp_output_buffer_show): Don't use
1118 Vtemp_buffer_show_specifiers.
1119 (Vtemp_buffer_show_specifiers): Remove unused variable.
1120
c2ff3c02
EZ
11212011-10-30 Eli Zaretskii <eliz@gnu.org>
1122
1123 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1124 past the beginning of the current glyph matrix.
1125
58179cce 11262011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1127
1128 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1129 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1130 HAVE_GTK3 (Bug#9869).
b77a6a7f 1131
3b574623
JD
1132 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1133 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1134
b77a6a7f
JD
1135 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1136
1137 * xterm.c: Declare x_handle_net_wm_state to return int.
1138 (handle_one_xevent): Check if we are iconified but don't have
1139 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1140 (get_current_wm_state): Return non-zero if not hidden,
1141 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1142 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1143 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1144 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1145
196e41e4
PE
11462011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1149 so that this new function doesn't get optimized away by a
1150 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1151
021f2e1a
AS
11522011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1153
1154 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1155
8b058d44
EZ
11562011-10-29 Eli Zaretskii <eliz@gnu.org>
1157
1158 Fix the `xbytecode' command.
1159 * .gdbinit (xprintbytestr): New command.
b50a28de 1160 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1161 (xbytecode): Print the byte-code string as well.
1162
4452fb80
EZ
11632011-10-29 Kim Storm <storm@cua.dk>
1164
8b058d44
EZ
1165 * alloc.c (which_symbols): New function.
1166
21b72067
AS
11672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1168
1169 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1170 line. (Bug#9903)
1171
83ed7b5c
GM
11722011-10-29 Glenn Morris <rgm@gnu.org>
1173
1174 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1175 Not clear what it was for, and it causes various bugs. (Bug#9839)
1176
5a7a728b
EZ
11772011-10-28 Eli Zaretskii <eliz@gnu.org>
1178
1179 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1180 possible random value that matches one of those tested as
1181 condition to clear the mouse face.
1182
d3d0842f
CY
11832011-10-28 Chong Yidong <cyd@gnu.org>
1184
1185 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1186
31b39d13
DN
11872011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1188
1189 * window.c (make_window): Initialize phys_cursor_on_p.
1190
9aba6043
SM
11912011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1192
1193 * lisp.h (struct Lisp_Symbol): Update comments.
1194
c20992f4
JB
11952011-10-28 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1198
db4f02f2
EZ
11992011-10-28 Eli Zaretskii <eliz@gnu.org>
1200
1201 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1202 <oslsachem@gmail.com> for helping to debug this.
1203
1204 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1205 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1206 (g_b_init_get_glyph_outline_w): New static variables.
1207 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1208 (GetGlyphOutlineW_Proc): New typedefs.
1209 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1210 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1211 New functions.
1212 (w32font_open_internal, compute_metrics):
1213 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1214 instead of calling the "wide" APIs directly.
1215
1216 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1217
1218 * w32.h (syms_of_w32font): Add prototype.
1219
87e68db4
JB
12202011-10-27 Juanma Barranquero <lekktu@gmail.com>
1221
1222 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1223 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1224 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1225 (Fmove_to_window_line): Doc fix.
1226
435c1d67
CY
12272011-10-27 Chong Yidong <cyd@gnu.org>
1228
1229 * process.c (make_process): Set gnutls_state to NULL.
1230
1231 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1232 non-NULL, regardless of GNUTLS_INITSTAGE.
1233 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1234 an error. Set process slots as soon as we allocate them.
1235
1236 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1237
9c6c6f49
CY
12382011-10-27 Chong Yidong <cyd@gnu.org>
1239
9aba6043
SM
1240 * gnutls.c (emacs_gnutls_deinit): New function.
1241 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1242 (Fgnutls_deinit, Fgnutls_boot): Use it.
1243
1244 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1245 (deactivate_process): Call emacs_gnutls_deinit.
1246
657d08d3
JB
12472011-10-27 Juanma Barranquero <lekktu@gmail.com>
1248
1249 * image.c (x_create_x_image_and_pixmap):
1250 * w32.c (sys_rename, w32_delayed_load):
1251 * w32font.c (fill_in_logfont):
1252 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1253
5430d399
JB
12542011-10-26 Juanma Barranquero <lekktu@gmail.com>
1255
1256 * w32fns.c (w32_default_color_map): New function,
1257 extracted from Fw32_default_color_map.
a7ef684b 1258 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1259
fe0055fa
PE
12602011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1263
e6346438
SM
12642011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1265
1266 * keyboard.c (test_undefined): New function (bug#9751).
1267 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1268
e112cc37
ET
12692011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1270
1271 * sysdep.c (init_sys_modes): Fix the check for the controlling
1272 terminal (Bug#6649).
1273
7b5d6677
EZ
12742011-10-20 Eli Zaretskii <eliz@gnu.org>
1275
1276 * dispextern.h (struct bidi_it): New member next_en_type.
1277
1278 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1279 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1280 current character, check also for next_en_type being WEAK_EN.
1281 (bidi_resolve_weak): Don't enter the expensive loop if the current
1282 position is before next_en_pos. Record the bidi type of the first
1283 non-ET, non-BN character we find, in addition to its position.
1284 (bidi_level_of_next_char): Invalidate next_en_type when
1285 next_en_pos is over-stepped.
1286
7da0b018
PE
12872011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1290 * editfns.c: Rewrite current-time-zone so that it invokes
1291 the equivalent of (format-time-string "%Z") to get the time zone name.
1292 This fixes a bug when the time zone name contains characters that
1293 need converting from the system time locale to Emacs internal format.
1294 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1295 that patch fixed format-time-string to do the conversion, but
1296 I forgot to fix current-time-zone.
1297 (format_time_string): New function, containing most of
1298 what Fformat_time_string used to contain.
1299 (Fformat_time_string): Rewrite in terms of format_time_string.
1300 This doesn't change this function's behavior.
1301 (current-time-zone): Rewrite to use format_time_string.
1302 This fixes the bug reported by Michael Schierl in
1303 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1304 Jason Rumney's 2007-06-07 change worked around this bug, but
1305 didn't fix it.
1306 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1307
8547b010
EZ
13082011-10-19 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (start_display): If the character at POS is displayed
1311 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1312 (try_window_reusing_current_matrix): If a line ends in a display
1313 vector or the next line starts in a display vector, continue
1314 redrawing the window even though the character position of
1315 start_row was reached.
8547b010
EZ
1316 (Bug#9771, part 2)
1317
4e948d15
CY
13182011-10-18 Chong Yidong <cyd@gnu.org>
1319
1320 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1321 with nobreak-char-display too.
1322
4787455f
EZ
13232011-10-18 Eli Zaretskii <eliz@gnu.org>
1324
1325 Fix part 3 of bug#9771.
1326 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1327 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1328 non-neutral characters if the current character is a paragraph
1329 separator (a.k.a. Newline). This avoids running the same
1330 expensive loop twice, once when we consume the preceding newline
1331 and the other time when the line actually needs to be displayed.
1332 Avoid the loop when we see neutrals on the base embedding level
1333 following a character whose directionality is the same as the
1334 paragraph's. This avoids running the expensive loop when a line
1335 ends in a long sequence of neutrals, like control characters.
1336 Add assertion against STRONG_AL type. Slightly rearrange code
1337 that determines the type of a neutral given the first non-neutral
1338 that follows it.
1339 (bidi_level_of_next_char): Set next_en_pos to zero when
1340 invalidating its info.
1341
2c91f553
EZ
13422011-10-17 Eli Zaretskii <eliz@gnu.org>
1343
1344 * xdisp.c (push_display_prop): Determine whether to record string
1345 or buffer position by IT->string, not by IT->method. Allow
1346 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1347 (move_it_vertically_backward): Don't look for character position
1348 immediately after the newline when in a continuation line.
1349 (Bug#9771, part 1)
2c91f553 1350
c7b08b0d
MR
13512011-10-15 Martin Rudalics <rudalics@gmx.at>
1352
1353 * window.c (coordinates_in_window): Rewrite and delabelize
1354 vertical border check. (Bug#5357) (Bug#9618)
1355
6b02f655
SM
13562011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1357
1358 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1359 errors in XSetWindowBorder (bug#9310).
1360
81d40c92
DA
13612011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1362
1363 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1364 avoid crash when xmalloc overrun checking is enabled.
1365
d4172c3b
EZ
13662011-10-13 Eli Zaretskii <eliz@gnu.org>
1367
1368 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1369 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1370 cursor motion with <left> and <right> arrow keys.
1371
1372 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1373 some callers set that themselves.
1374
b00eea75
EZ
13752011-10-12 Eli Zaretskii <eliz@gnu.org>
1376
1377 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1378 display string and the previous row comes from the same string and
1379 is empty. (Bug#9739) (Bug#9738)
1380
8fe012c4
SM
13812011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1382
1383 * doc.c (get_doc_string): Encode file name (bug#9735).
1384
0074aef2
EZ
13852011-10-12 Eli Zaretskii <eliz@gnu.org>
1386
79beb178
EZ
1387 * bidi.c (bidi_level_of_next_char):
1388 * xdisp.c (get_visually_first_element): Remove old incorrect
1389 comments regarding the Unicode Line Separator character.
1390
0074aef2
EZ
1391 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1392
6e4b3fbe
DA
13932011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1394
1395 * alloc.c (Fgc_status): Do not access beyond zombies array
1396 boundary if nzombies > MAX_ZOMBIES.
1397 * alloc.c (dump_zombies): Add missing format specifier.
1398
0324f3af
PE
13992011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1400
b5525cac
PE
1401 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1402 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1403
0324f3af
PE
1404 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1405 Some packages use them to denote characters with modifiers.
1406
e9b5f888
AS
14072011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1408
1409 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1410 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1411 matching a pp-number. Rename parameter var to var1.
1412
127827c0
SM
14132011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1414
1415 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1416
c8fd3bd0
GM
14172011-10-08 Glenn Morris <rgm@gnu.org>
1418
1419 * callint.c (Fcall_interactively): Give a more explicit error for the
1420 'c' case with a non-character input. (Bug#8479)
1421
352ec8ff
EZ
14222011-10-08 Eli Zaretskii <eliz@gnu.org>
1423
03669ccb
EZ
1424 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1425 lines.
7061c986
EZ
1426 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1427 lines that are hscrolled on the left.
03669ccb 1428
352ec8ff
EZ
1429 * dispnew.c (buffer_posn_from_coords): Account for a possible
1430 presence of header-line. (Bug#4426)
1431
a66cfb1c
SM
14322011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1433
6b02f655
SM
1434 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1435 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1436
7c5ee88e
PE
14372011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1440 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1441 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1442 this makes Emacs dump core during garbage collection on rare
1443 occasions. sizeof is obviously inferior to offsetof here, so
1444 stick with offsetof.
1445 (GC_POINTER_ALIGNMENT): New macro.
1446 (mark_memory): Omit 3rd (offset) arg; caller changed.
1447 Don't assume EMACS_INT alignment is the same as pointer alignment.
1448
df1bbe5b
SM
14492011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1450
1451 * keyboard.c (read_key_sequence_remapped): New var.
1452 (read_key_sequence): Compute remapping in the right buffer.
1453 (command_loop_1): Use read_key_sequence's remapping directly.
1454
51553db6
SM
14552011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1456
32c1fffd
SM
1457 * dired.c (file_name_completion): Don't expand file name.
1458 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1459 before checking file name handler.
1460
51553db6
SM
1461 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1462 they've been requested explicitly (bug#9591).
1463
b6bd1599 14642011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1465
1466 * keymap.c (Fsingle_key_description): Use make_specified_string
1467 instead of build_string to build string from push_key_description.
1468 (Bug#5193)
1469
f701dc2a
PE
14702011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1471
4222c55d
PE
1472 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1473 This fixes a Y2038 bug on 64-bit hosts.
1474 * buffer.c (reset_buffer):
1475 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1476 (Fclear_buffer_auto_save_failure):
1477 Use 0, not -1, to represent an unset failure time, since time_t
1478 might not be signed.
1479
f701dc2a
PE
1480 Remove dependency on glibc malloc internals.
1481 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1482 Move back here from lisp.h, but with their new implementations.
1483 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1484 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1485 * charset.c (charset_table_init): New static var.
1486 (syms_of_charset): Use it instead of xmalloc. This removes a
1487 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1488 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1489 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1490 Move back to alloc.c.
1491 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1492 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1493
9ceebf39
JD
14942011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1495
1496 * nsterm.m (windowDidResize): Call x_set_window_size only when
1497 ns_in_resize is true. Otherwise set pixelwidth/height and
1498 call change_frame_size (Bug#9628).
1499
cb993c58
PE
15002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1501
3930c88b
PE
1502 Port --enable-checking=all to Fedora 14 x86-64.
1503 * charset.c (syms_of_charset): Also account for glibc malloc's
1504 internal overhead when calculating the initial malloc maximum.
1505
cb993c58
PE
1506 Port --enable-checking=all to Fedora 14 x86.
1507 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1508 Move to lisp.h.
1509 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1510 (overrun_check_realloc, overrun_check_free):
1511 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1512 That way, xmalloc returns a properly-aligned pointer even if
1513 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1514 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1515 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1516 into account when calculating the initial malloc maximum.
1517 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1518 Move here from alloc.c, so that charset.c can use it too.
1519 Properly align; the old code wasn't right for common 32-bit hosts
1520 when configured with --enable-checking=all.
1521 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1522 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1523
31bed486
EZ
15242011-09-29 Eli Zaretskii <eliz@gnu.org>
1525
04c70788 1526 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1527 use EDOM.
1528
fbcaa2f3
EZ
15292011-09-28 Eli Zaretskii <eliz@gnu.org>
1530
1531 * xdisp.c (compute_display_string_end): If there's no display
1532 string at CHARPOS, return -1.
1533
1534 * bidi.c (bidi_fetch_char): When compute_display_string_end
1535 returns a negative value, treat the character as a normal
1536 character not covered by a display string. (Bug#9624)
1537
a239d4e9
JB
15382011-09-28 Juanma Barranquero <lekktu@gmail.com>
1539
1540 * lread.c (Fread_from_string): Fix typo in docstring.
1541
88652fd5
EZ
15422011-09-27 Eli Zaretskii <eliz@gnu.org>
1543
1544 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1545 newline, reseat the iterator instead of bidi-iterating there one
1546 character at a time. (Bug#9610)
32c1fffd
SM
1547 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1548 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1549
ed497dd4
AS
15502011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1551
1552 * lread.c (readevalloop): Use correct code for NBSP.
1553 (read1): Likewise. (Bug#9608)
1554
b2bf61aa
MA
15552011-09-25 Michael Albinus <michael.albinus@gmx.de>
1556
1557 * dbusbind.c (Fdbus_register_signal): When service is not
1558 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1559
32bbb17c
GM
15602011-09-25 Glenn Morris <rgm@gnu.org>
1561
1562 * buffer.c (truncate-lines): Doc fix.
1563
94e0933e
CY
15642011-09-24 Chong Yidong <cyd@stupidchicken.com>
1565
1566 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1567 (Fset_window_next_buffers): Doc fix.
1568
cddde921
GM
15692011-09-24 Glenn Morris <rgm@gnu.org>
1570
1571 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1572
1260aef1
PE
15732011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1574
25b4bfa0
PE
1575 Fix minor problems found by static checking.
1576 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1577 * indent.c (Fvertical_motion): Fix == vs = typo.
1578
e3cbd34b
EZ
15792011-09-24 Eli Zaretskii <eliz@gnu.org>
1580
a66cfb1c
SM
1581 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1582 Default value is now t. Doc fix.
6bf7006f 1583
e3cbd34b 1584 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1585 logic when moving up, not only when moving down. Fix the
e3cbd34b 1586 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1587 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1588
1589 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1590 CHARPOS is covered by a display string which includes newlines.
1591 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1592 is covered by a display string with embedded newlines.
1593
a3de0cbd
MA
15942011-09-24 Michael Albinus <michael.albinus@gmx.de>
1595
1596 * dbusbind.c (Fdbus_register_signal): Add match rule to
1597 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1598 (Fdbus_register_method, Vdbus_registered_objects_table):
1599 Fix docstring.
a3de0cbd 1600
b260039d
JM
16012011-09-24 Jim Meyering <meyering@redhat.com>
1602
32c1fffd 1603 do not ignore write error for any output size
b260039d
JM
1604 The previous change was incomplete.
1605 While it makes emacs --batch detect the vast majority of stdout
1606 write failures, errors were still ignored whenever the output size is
1607 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1608 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1609 && echo FAIL: ignored write error
1610 FAIL: ignored write error
1611 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1612 && echo FAIL: ignored write error
1613 FAIL: ignored write error
1614 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1615
8eca8a7c
AS
16162011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1617
1618 * emacs.c (Fkill_emacs): In noninteractive mode exit
1619 non-successfully if a write error occurred on stdout. (Bug#9574)
1620
3341db62
EZ
16212011-09-21 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1624 the xassert test.
1625
1626 * dispextern.h (struct it): Update the comment documenting what
1627 can it->OBJECT be.
1628
8c203dbf
EZ
16292011-09-20 Eli Zaretskii <eliz@gnu.org>
1630
1631 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1632 a display string, extend search for cursor position to end of row.
1633 (find_row_edges): If the row ends in a newline from a display
1634 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1635 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1636 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1637 non-empty line. Fixes confusing cursor motion with arrow keys at
1638 the beginning of a line that starts with whitespace.
8c203dbf 1639
a4824228
LMI
16402011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1641
1642 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1643 (bug#9493).
1644
33ed493b
CY
16452011-09-18 Chong Yidong <cyd@stupidchicken.com>
1646
1647 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1648 boolean (Bug#9154).
1649
56cd55c8
EZ
16502011-09-18 Eli Zaretskii <eliz@gnu.org>
1651
1652 * xdisp.c (display_line): Record maximum and minimum buffer
1653 positions even if no glyphs were produced (e.g., by a zero-width
1654 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1655 buffer positions that will be removed from the glyph row because
1656 they don't fit.
c02dcedf
EZ
1657 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1658 column is beyond frame width: don't subtract 1 "pixel" when
1659 computing width of the stretch.
3e62b7e0
EZ
1660 (reseat_at_next_visible_line_start): Undo the change made on
1661 2011-09-17 that saved paragraph information and restored it after
1662 the call to `reseat'. (Bug#9545)
56cd55c8 1663
5ed99d36 16642011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1665
1666 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1667 and turn window cursor on if cleared (Bug#9415).
1668
5ed99d36 16692011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1670
1671 * search.c (boyer_moore): Take unibyte characters from pattern
1672 literally. (Bug#9458)
1673
9bade7b2
EZ
16742011-09-18 Eli Zaretskii <eliz@gnu.org>
1675
1676 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1677
e5e9d610
PE
16782011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1679
87e4427a
PE
1680 Fix minor problem found by static checking.
1681 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1682 initialized, to pacify gcc -Wuninitialized.
1683
e5e9d610
PE
1684 * fileio.c: Report proper errno when syscall falls.
1685 (Finsert_file_contents): Save and restore errno,
1686 so that report_file_error outputs the correct diagnostic.
1687 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1688
a1674f0b
EZ
16892011-09-18 Eli Zaretskii <eliz@gnu.org>
1690
1691 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1692
fbfb6dd4
EZ
16932011-09-17 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1696 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1697
bb187662
EZ
16982011-09-17 Eli Zaretskii <eliz@gnu.org>
1699
1137e8b8 1700 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1701 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1702
1703 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1704 (bidi_find_paragraph_start): Search back for paragraph beginning
1705 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1706 (bidi_move_to_visually_next): Only trigger paragraph-related
1707 computations when the last character is a newline or at EOB, not
1708 just any NEUTRAL_B. (Bug#9470)
1709
bb187662
EZ
1710 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1711 truncated lines if point is covered by a display string. (Bug#9524)
1712
2e621251
PE
17132011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1716 (cons_to_x_long): New function.
1717 (lisp_data_to_selection_data): Use it. Correct the test for
1718 short-versus-long data; it was negated. Break out of vector
1719 loop, for efficiency, when a long datum is discovered.
1720
91a15bc6
SM
17212011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1722
1723 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1724
b41c3a35
EZ
17252011-09-16 Eli Zaretskii <eliz@gnu.org>
1726
1727 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1728 GCC PR/17406) by declaring this function with external scope.
1729
7812ba2d
PE
17302011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1733 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1734
cf7edc2a
AS
17352011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1736
1737 * editfns.c (Fformat): Correctly handle text properties on "%%".
1738
bd01620e
EZ
17392011-09-15 Eli Zaretskii <eliz@gnu.org>
1740
1741 * xterm.c (x_draw_composite_glyph_string_foreground):
1742 * w32term.c (x_draw_composite_glyph_string_foreground):
1743 * term.c (encode_terminal_code):
1744 * composite.c (composition_update_it, get_composition_id):
1745 * xdisp.c (get_next_display_element)
1746 (fill_composite_glyph_string): Add comments about special meaning
1747 of TAB characters in a composition.
1748
a02719a3
PE
17492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1752 This occurs when processing a multibyte format.
1753 Problem reported by Wolfgang Jenker.
a02719a3 1754
72589a3c
JB
17552011-09-15 Johan Bockgård <bojohan@gnu.org>
1756
1757 * xdisp.c (try_cursor_movement): Only check for exact match if
1758 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1759
1c14176c
PE
17602011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 Remove unused external symbols.
1763 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1764 * xdisp.c (calc_pixel_width_or_height): Now static.
1765 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1766 * indent.c (check_display_width):
1767 * w32term.c: Fix comment to match code.
1768 * xterm.c, xterm.h (x_catching_errors): Remove.
1769
d2eea5b5
PE
17702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * xselect.c: Use signed conversions more consistently (Bug#9498).
1773 (selection_data_to_lisp_data): Assume incoming selection data are
1774 signed integers, not unsigned. This is to be consistent with
1775 outgoing selection data, which was modified to use signed integers
1776 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1777 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1778 expects long, not unsigned long.
1779
46888499
EZ
17802011-09-14 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1783 computation of loop end. Reported by Johan Bockgård
1784 <bojohan@gnu.org>.
1785
ef8ef9fb
CY
17862011-09-13 Chong Yidong <cyd@stupidchicken.com>
1787
1788 * frame.c (Fother_visible_frames_p): Function deleted.
1789
fa819fed
EZ
17902011-09-12 Eli Zaretskii <eliz@gnu.org>
1791
1792 * indent.c (compute_motion): Process display vector front to back
1793 rather than the other way around. (Bug#2496)
1794
2ba8e008
SM
17952011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1796
1797 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1798
20f53c69
CY
17992011-09-11 Chong Yidong <cyd@stupidchicken.com>
1800
1801 * minibuf.c (Fread_from_minibuffer): Doc fix.
1802
d562d7a4
EZ
18032011-09-11 Eli Zaretskii <eliz@gnu.org>
1804
1805 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1806 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1807
1c4d7f3d
LMI
18082011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1809
1810 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1811 value for non-existent files.
1812
b885bf36
EZ
18132011-09-11 Eli Zaretskii <eliz@gnu.org>
1814
1815 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1816 set its "size" to -1. This will set the modtime_size field of
1817 the corresponding buffer to -1, which is what
1818 verify-visited-file-modtime expects for files that do not exist.
1819 (Bug#9139)
1820
6612f0bf
PE
18212011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1824 here ...
1825 * lisp.h: ... from here. push_key_description is no longer
1826 defined in keyboard.c, so its declaration should not be in
1827 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1828 logically belongs with push_key_description.
1829
dfb3f755
PE
18302011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1831
1832 * buffer.h: Include <sys/types.h> instead of <time.h>.
1833 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1834 Problem reported by Herbert J. Skuhra.
1835
3134906c
LMI
18362011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1837
1838 * xml.c (parse_region): Make the parsing work for
1839 non-comment-starting XML files again (bug#9144).
1840
8d903f4e
AS
18412011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1842
1843 * image.c (gif_load): Fix calculation of bottom and right corner.
1844 (Bug#9468)
1845
80ad64f4
EZ
18462011-09-10 Eli Zaretskii <eliz@gnu.org>
1847
1848 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1849 redisplay in small windows.
1850
208a048d
EZ
18512011-09-09 Eli Zaretskii <eliz@gnu.org>
1852
1853 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1854
9b1c252e
MR
18552011-09-08 Martin Rudalics <rudalics@gmx.at>
1856
1857 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1858 Operate on live windows only.
1859
2949f33b
JB
18602011-09-08 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1863
e08dcafd
EZ
18642011-09-07 Eli Zaretskii <eliz@gnu.org>
1865
1866 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1867 only under bidi iteration.
1868
115b96bd
JD
18692011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1870
1871 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1872
c8199d0f
PE
18732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1876 Without this fix, the command to link temacs failed due to an
1877 undefined symbol __builtin_isnan. This is because
1878 /usr/include/iso/math_c99.h #defines isnan(x) to
1879 __builtin_isnan(x), but the bundled gcc, which identifies itself
1880 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1881 a __builtin_isnan.
1882 * floatfns.c (isnan): #undef, and then #define to a clone of
1883 what's in data.c.
1884 (Fisnan): Always define, since it's always available now.
1885 (syms_of_floatfns): Always define isnan at the Lisp level.
1886
e39b275c 18872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1888
1889 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1890
b2db44d9 18912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1892
f4af5137 1893 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1894 The previous code assumed that file offsets (off_t values) fit in
1895 EMACS_INT variables, which is not true on typical 32-bit hosts.
1896 The code messed up by falsely reporting buffer overflow in cases
1897 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1898 when "big" contains more than 2**29 bytes, even though this
1899 inserts just one byte and does not overflow the buffer.
1900 (Finsert_file_contents): Store file offsets as off_t
1901 values, not as EMACS_INT values. Check for overflow when
1902 converting between EMACS_INT and off_t. When checking for
1903 buffer overflow or for overlap, take the offsets into account.
1904 Don't use EMACS_INT for small values where int suffices.
1905 When checking for overlap, fix a typo: ZV was used where
1906 ZV_BYTE was intended.
1907 (Fwrite_region): Don't assume off_t fits into 'long'.
1908 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1909
ecfc0a49
MA
19102011-09-05 Michael Albinus <michael.albinus@gmx.de>
1911
1912 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1913
6511acf2 19142011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1915
0999621a 1916 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1917
1918 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1919 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1920 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1921 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1922 (modify_event_symbol): Do not assume that the length of
1923 name_alist_or_stem is safe to alloca and fits in int.
1924 (Fexecute_extended_command): Likewise for function name and binding.
1925 (Frecursion_depth): Wrap around reliably on integer overflow.
1926 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1927 since some callers pass EMACS_INT values.
1928 (Fsingle_key_description): Don't crash if symbol name contains more
1929 than MAX_ALLOCA bytes.
1930 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1931 (get_minibuffer): Arg is now EMACS_INT, not int.
1932 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1933 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1934 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1935
2be7d702
PE
1936 * dbusbind.c (signature_cat): New function.
1937 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1938 Do not overrun buffer; instead, report string overflow.
1939
9d1df220
PE
1940 * dispnew.c (add_window_display_history): Don't overrun buffer.
1941 Truncate instead; this is OK since it's just a log.
1942
33ef5c64
PE
1943 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1944 even if the time zone offset is outlandishly large.
1945 Don't mishandle offset == INT_MIN.
1946
66c6fdd5
PE
1947 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1948 when creating daemon; the previous buffer-overflow check was incorrect.
1949
d749b01b
PE
1950 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1951 which has the guts of the old verror function.
1952
b5cd1905
PE
1953 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1954 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1955
6e1a67fb
PE
1956 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1957 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1958 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1959 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1960 length of string rather than counting it via multiple sprintfs;
1961 that's simpler and more reliable.
c21721cc
PE
1962 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1963 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1964 sprintf, in case result does not fit in int.
1965
c57b67fc
PE
1966 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1967 (fontset_from_font): Print it.
1968
8a401434
PE
1969 * frame.c (tty_frame_count): Now printmax_t, not int.
1970 (make_terminal_frame, set_term_frame_name): Print it.
1971 (x_report_frame_params): In X, window IDs are unsigned long,
1972 not signed long, so print them as unsigned.
1973 (validate_x_resource_name): Check for implausibly long names,
1974 and don't assume name length fits in 'int'.
1975 (x_get_resource_string): Don't blindly alloca invocation name;
1976 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1977 not fit in int.
1978
6e1a67fb
PE
1979 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1980 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1981 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1982
0df02bf3
PE
1983 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1984 Use esprintf, not sprintf, in case result does not fit in int.
1985
48e30793
PE
1986 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1987 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1988 it as a large positive number.
1989 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1990 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1991
a66ff6d8
PE
1992 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1993 in case result does not fit in int.
1994
aca216ff
PE
1995 * print.c (float_to_string): Detect width overflow more reliably.
1996 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1997 buffer overrun. Don't assume list length fits in 'int'. Treat
1998 print length of 0 as 0, not as infinity; to be consistent with other
1999 uses of print length in this function. Don't overflow print length
2000 index. Don't assume hash table size fits in 'long', or that
2001 vectorlike size fits in 'unsigned long'.
2002
31c286f7
PE
2003 * process.c (make_process): Use printmax_t, not int, to format
2004 process-name gensyms.
2005
55e5faa1
PE
2006 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2007
80f2e268
PE
2008 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2009 to avoid potential buffer overrun.
2010
670741ab
PE
2011 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2012 if X resource line is longer than 512 bytes.
2013
b7163a50
PE
2014 * xfns.c (x_window): Make sprintf buffer a bit bigger
2015 to avoid potential buffer overrun.
2016
ae58ff1f
PE
2017 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2018
c43c8a6a
PE
2019 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2020
3f8236f4
PE
20212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2022
53e9fe90 2023 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2024 Without these, Emacs silently mishandles large integers sometimes.
2025 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2026 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2027
6511acf2
PE
2028 * xdisp.c (try_window_id): Check Emacs fixnum range before
2029 converting to 'int'.
806add1d 2030
6511acf2 2031 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2032 Check that an Emacs fixnum is in range before assigning it to 'int'.
2033 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2034 values converted from Emacs fixnums.
2035 (Frecenter): Don't wrap around a line count if it is out of 'int'
2036 range; instead, treat it as an extreme value.
2037 (Fset_window_configuration, compare_window_configurations):
2038 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2039
6511acf2
PE
2040 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2041 that can exceed INT_MAX. Check that EMACS_INT value is in range
2042 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2043 (match_limit): Don't assume that a fixnum can fit in 'int'.
2044
6511acf2 2045 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2046 exceed INT_MAX.
2047
6511acf2 2048 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2049 (Fvertical_motion): Don't wrap around LINES values that don't fit
2050 in 'int'. Instead, treat them as extreme values. This is good
2051 enough for windows, which can't have more than INT_MAX lines anyway.
2052
fcb901a7
LMI
20532011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2054
0f2f6b6d
LMI
2055 * Require libxml/parser.h to avoid compilation warning.
2056
fcb901a7
LMI
2057 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2058
2059 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2060 since this reportedly can destroy thread storage.
2061
6e20a0d4
CY
20622011-08-30 Chong Yidong <cyd@stupidchicken.com>
2063
2064 * syntax.c (find_defun_start): Update all cache variables if
2065 exiting early (Bug#9401).
2066
148ae00e
EZ
20672011-08-30 Eli Zaretskii <eliz@gnu.org>
2068
f6cfbd8f
EZ
2069 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2070
148ae00e
EZ
2071 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2072 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2073 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2074
2075 * term.c (tty_append_glyph): New function.
2076 (produce_stretch_glyph): Static function and its prototype deleted.
2077
a66cfb1c
SM
2078 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2079 Add prototypes.
148ae00e 2080
c4a07a4c
PE
20812011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2084 when checking :margin (Bug#9390).
2085 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2086 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2087 so that the name doesn't mislead. All uses changed.
2088
6bc8cd65
JB
20892011-08-28 Johan Bockgård <bojohan@gnu.org>
2090
2091 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2092 set_tty_hooks.
2093
dca4927e
EZ
20942011-08-27 Eli Zaretskii <eliz@gnu.org>
2095
2096 * xdisp.c (move_it_to): Don't bail out early when reaching
2097 position beyond to_charpos, if we are scanning backwards.
2098 (move_it_vertically_backward): When DY == 0, make sure we get to
2099 the first character in the line after the newline.
2100
f2cad773
PE
21012011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2102
2103 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2104 (ccl_driver): Do not generate an out-of-range pointer.
2105 (Fccl_execute_on_string): Remove unnecessary check for
2106 integer overflow, noted by Stefan Monnier in
2107 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2108 Remove a FIXME that didn't need fixing.
2109 Simplify the newly-introduced buffer reallocation code.
2110
0cae2cdb
JB
21112011-08-27 Juanma Barranquero <lekktu@gmail.com>
2112
2113 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2114
5fc295a4 21152011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2116
70c60eb2 2117 Integer and memory overflow issues (Bug#9196).
726e0ab1 2118
d31850da
PE
2119 * doc.c (get_doc_string): Rework so that
2120 get_doc_string_buffer_size is the actual buffer size, rather than
2121 being 1 less than the actual buffer size; this makes xpalloc more
2122 convenient.
2123
a69fbedb
PE
2124 * image.c (x_allocate_bitmap_record, cache_image):
2125 * xselect.c (Fx_register_dnd_atom):
2126 Simplify previous changes by using xpalloc.
2127
fe5c5d37
PE
2128 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2129 since either will do and ptrdiff_t is convenient with xpalloc.
2130
0065d054
PE
2131 * charset.c (charset_table_size)
2132 (struct charset_sort_data.priority): Now ptrdiff_t.
2133 (charset_compare): Don't overflow if priorities differ greatly.
2134 (Fsort_charsets): Don't assume list length fits in int.
2135 Check for size-calculation overflow when allocating sort data.
2136 (syms_of_charset): Allocate an initial charset table that is
2137 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2138
2139 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2140
2141 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2142 The actual value is always <= INT_MAX, and leaving it unsigned made
2143 overflow checking harder.
2144
2145 * dispextern.h (struct glyph_matrix.rows_allocated)
2146 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2147 with xpalloc. The values are still always <= INT_MAX.
2148
2149 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2150
2151 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2152 (SAFE_NALLOCA): New macro.
2153
2154 * region-cache.c (struct boundary.pos, find_cache_boundary)
2155 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2156 (set_cache_region, invalidate_region_cache)
2157 (revalidate_region_cache, know_region_cache, region_cache_forward)
2158 (region_cache_backward, pp_cache):
2159 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2160 so that ptrdiff_t * can be passed to xpalloc.
2161 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2162 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2163 (pp_cache): Don't assume cache_len fits in int.
2164 * region-cache.h: Adjust extern decls to match.
2165
2166 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2167 EMACS_INT, since either will do, for xpalloc.
2168
2169 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2170 (xnmalloc, xnrealloc, xpalloc): New functions.
2171
726e0ab1
PE
2172 * bidi.c (bidi_shelve_header_size): New constant.
2173 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2174 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2175
51f30bc5 2176 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2177 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2178 (overlay_strings):
2179 Don't update size of array until after memory allocation succeeds,
2180 because xmalloc/xrealloc may not return.
0065d054
PE
2181 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2182 now that we have proper integer overflow checking.
2183 (record_overlay_string, overlay_strings): Catch overflows when
2184 calculating size of overlay_str_buf.
726e0ab1 2185
0065d054
PE
2186 * callproc.c (Fcall_process): Check for size overflow when
2187 calculating size of args2.
2188 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2189 Normally we prefer signed values, but sticking with ptrdiff_t would
2190 require adding more-complicated checks.
726e0ab1
PE
2191
2192 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2193 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2194 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2195 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2196
2197 * character.c (Fstring): Check for size-calculation overflow.
2198
2199 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2200 unnecessary integer overflow. Check for size overflow.
2201 (encode_coding_object): Don't update size until xmalloc succeeds.
2202
2203 * composite.c (get_composition_id): Check for overflow in glyph
2204 length calculations.
2205
2206 Integer and memory overflow fixes for display code.
2207 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2208 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2209 (scrolling_window): Check for overflow in size calculations.
2210 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2211 Don't assume glyph table len fits in int.
2212 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2213 (row_table_size): Now ptrdiff_t, not int.
2214 (scrolling_window): Avoid overflow in size calculations.
2215 Don't update size until allocation succeeds.
2216 * fns.c (concat): Check for overflow in size calculations.
2217 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2218 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2219 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2220
2221 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2222 (get_doc_string): Check for size calculation overflow.
2223 Don't update size until allocation succeeds.
2224 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2225 EMACS_INT, where ptrdiff_t will do.
2226 (Fsubstitute_command_keys): Check for string overflow.
2227
2228 * editfns.c (set_time_zone_rule): Don't assume environment length
2229 fits in int.
2230 (message_length): Now ptrdiff_t, not int.
2231 (Fmessage_box): Don't update size until allocation succeeds.
2232 Don't assume message length fits in int.
2233 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2234
0065d054
PE
2235 * emacs.c (main): Do not reallocate argv, since there is a null at
2236 the end that can be overwritten, and this way there's no need to
2237 worry about size-calculation overflow.
2238 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2239
2240 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2241 alloc succeeds.
2242 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2243
2244 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2245 (x_set_scroll_bar_width, x_figure_window_size):
2246 Check for integer overflow.
2247 (x_set_alpha): Do not assume XINT fits in int.
2248
2249 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2250 This is for the members text_lines, text_cols, total_lines, total_cols,
2251 where the system imposes an 'int' limit.
2252
2253 * fringe.c (Fdefine_fringe_bitmap):
2254 Don't update size until alloc works.
2255
2256 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2257 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2258
2259 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2260 Check for size-calculation overflow.
2261 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2262 do, as we prefer signed integers.
2263 (id_to_widget.max_size, id_to_widget.used)
2264 (xg_store_widget_in_map, xg_remove_widget_from_map)
2265 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2266 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2267 Use and return ptrdiff_t, not int.
2268 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2269 * gtkutil.h: Change prototypes to match the above.
2270
2271 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2272 are duplicate now that they've been promoted to lisp.h.
2273 (x_allocate_bitmap_record, x_alloc_image_color)
2274 (make_image_cache, cache_image, xpm_load):
2275 Don't update size until alloc is done.
2276 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2277 (x_detect_edges):
3256efce 2278 Check for size calculation overflow.
726e0ab1
PE
2279 (ct_colors_allocated_max): New constant.
2280 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2281 overflow.
3256efce 2282
726e0ab1
PE
2283 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2284 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2285 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2286 Use ptrdiff_t, not int, to count maps.
2287 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2288 calculations. Don't update size until allocation succeeds.
2289 Redo calculations to avoid overflow.
726e0ab1
PE
2290 * keyboard.h: Change prototypes to match the above.
2291
2292 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2293 to count maps.
2294 (current_minor_maps): Check for size calculation overflow.
2295 * keymap.h: Change prototypes to match the above.
2296
2297 * lread.c (read1, init_obarray): Don't update size until alloc done.
2298
2299 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2300 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2301
726e0ab1
PE
2302 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2303 Now ptrdiff_t, not int.
2304 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2305 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2306
2307 * process.c (Fnetwork_interface_list): Check for overflow
2308 in size calculation.
2309
2310 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2311
2312 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2313 overflow. Don't bother calling xmalloc when xrealloc will do.
2314
2315 * search.c (Freplace_match): Check for size calculation overflow.
2316 (Fset_match_data): Don't assume list lengths fit in 'int'.
2317
2318 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2319 for command line length. Do not attempt to address one before the
2320 beginning of an array, as that's not portable.
2321
2322 * term.c (max_frame_lines): Remove; unused.
2323 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2324 not int.
2325 (encode_terminal_code, calculate_costs): Check for size
2326 calculation overflow.
2327 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2328 table lengths and related sizes. Don't update size until alloc
2329 done. Redo calculations to avoid overflow.
2330 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2331
2332 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2333 subtracting pointers.
2334 (gobble_line): Check for overflow more carefully. Don't update size
2335 until alloc done.
2336
2337 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2338 Don't update size until alloc done.
2339 Redo size calculations to avoid overflow.
2340 Check for size calculation overflow.
0065d054 2341 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2342
2343 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2344 Use ptrdiff_t, not int, for sizes.
2345 (store_mode_line_noprop_char): Don't update size until alloc done.
2346
0065d054
PE
2347 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2348 Use ptrdiff_t, not int, for sizes.
2349 (Finternal_make_lisp_face, cache_face):
2350 Check for size calculation overflow.
2351 (cache_face): Treat size calculation overflows as if they were
2352 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2353
2354 * xfns.c (x_encode_text, x_set_name_internal)
2355 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2356 sizes, since they can exceed INT_MAX in size. Check for size
2357 calculation overflow.
2358
0065d054
PE
2359 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2360 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2361 Don't update size until alloc done.
2362
0065d054 2363 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2364 as sprintf is limited to int lengths.
1d526e2f 2365
252c5ee1
PE
2366 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2367 (X_LONG_MIN): New macros.
864d7ce7
PE
2368 Use them to make the following changes clearer.
2369 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2370 This change doesn't affect the value now, but it may help remind
2371 future maintainers not to raise the value too much later.
2372 (SELECTION_QUANTUM): Remove, replacing with ...
2373 (selection_quantum): ... new function, which avoids overflow.
2374 All uses changed.
2375 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2376 assumption that selection length fits in 'int'.
2377 (x_reply_selection_request, x_handle_selection_request)
2378 (x_get_window_property, receive_incremental_selection)
2379 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2380 (lisp_data_to_selection_data, clean_local_selection_data):
2381 Use ptrdiff_t, not int, to record length of selection.
2382 (x_reply_selection_request, x_get_window_property)
2383 (receive_incremental_selection, x_property_data_to_lisp):
2384 Redo calculations to avoid overflow.
2385 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2386 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2387 something.
2388 (x_get_window_property, receive_incremental_selection)
2389 (lisp_data_to_selection_data, x_property_data_to_lisp):
2390 Check for size-calculation overflow.
2391 (x_get_window_property, receive_incremental_selection)
2392 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2393 Don't store size until memory allocation succeeds.
2394 (x_get_window_property): Plug memory leak on memory exhaustion.
2395 Don't double-block input; malloc is safe here. Don't assume 2**34
2396 - 4 fits in unsigned long. Add an xassert to check
2397 XGetWindowProperty overflow. Be more careful about overflow
2398 calculations, and distinguish size from memory overflow better.
2399 (receive_incremental_selection): When tracing, don't assume
2400 unsigned int is less than INT_MAX.
2401 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2402 harmful) conversions of unsigned short to int.
2403 (lisp_data_to_selection_data): Don't assume that integers
2404 in the range -65535 through -1 fit in an X unsigned short.
2405 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2406 result parameters unless successful. Rely on cons_to_unsigned
2407 to report problems with elements; the old code wasn't right anyway.
2408 (x_check_property_data): Check for int overflow; we cannot use
2409 a wider type due to X limits.
2410 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2411
726e0ab1 2412 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2413
0065d054
PE
2414 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2415 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2416 (x_color_cells): Don't store size until memory allocation succeeds.
2417 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2418 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2419 (x_term_init): Don't assume length fits in int (sprintf is limited
2420 to int size).
bc18e09d 2421
ebfa62c0
PE
2422 Use ptrdiff_t for composition IDs.
2423 * character.c (lisp_string_width):
2424 * composite.c (composition_table_size, n_compositions)
2425 (get_composition_id, composition_gstring_from_id):
2426 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2427 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2428 * window.c (Frecenter):
2429 Use ptrdiff_t, not int, for composition IDs.
2430 * composite.c (get_composition_id): Check for integer overflow.
2431 * composite.h: Adjust prototypes to match the above changes.
2432
d3411f89
PE
2433 Use ptrdiff_t for hash table indexes.
2434 * category.c (hash_get_category_set):
2435 * ccl.c (ccl_driver):
2436 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2437 * coding.c (coding_system_charset_list, detect_coding_system):
2438 * coding.h (struct coding_system.id):
2439 * composite.c (get_composition_id, gstring_lookup_cache):
2440 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2441 * image.c (xpm_get_color_table_h):
2442 * lisp.h (hash_lookup, hash_put):
2443 * minibuf.c (Ftest_completion):
2444 Use ptrdiff_t for hash table indexes, not int (which is too
2445 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2446 32-bit --with-wide-int hosts).
2447
e097a6fa
PE
2448 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2449 Add a FIXME comment about memory leaks.
2450 (syms_of_charset): Don't assume xmalloc returns.
2451
5637687f
PE
2452 Don't assume that stated character widths fit in int.
2453 * character.c (Fchar_width, c_string_width, lisp_string_width):
2454 * character.h (CHAR_WIDTH):
2455 * indent.c (MULTIBYTE_BYTES_WIDTH):
2456 Use sanitize_char_width to avoid undefined and/or bad behavior
2457 with outlandish widths.
a66cfb1c 2458 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2459 now that we have two such functions. All uses changed.
2460 (sanitize_char_width): New inline function.
2461
a2271ba2
PE
2462 Don't assume that tab-width fits in int.
2463 * character.h (sanitize_width): New inline function.
2464 (SANE_TAB_WIDTH): New macro.
2465 (ASCII_CHAR_WIDTH): Use it.
2466 * indent.c (sane_tab_width): Remove. All uses replaced by
2467 SANE_TAB_WIDTH (current_buffer).
2468 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2469
18c52557
PE
2470 * fileio.c: Integer overflow issues with file modes.
2471 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2472
caeeedc1
PE
2473 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2474 Remove unreachable code.
2475 (read_hex, load_charset_map_from_file): Check for integer overflow.
2476
6df6ae42 2477 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2478 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2479 (x_send_scroll_bar_event): Likewise. Check that the size does not
2480 exceed limits imposed by XClientMessageEvent, as well as the usual
2481 ptrdiff_t and size_t limits.
2482
b13995db
PE
2483 * keyboard.c: Overflow, signedness and related fixes.
2484 (make_lispy_movement): Use same integer type in forward decl
2485 that is used in the definition.
2486 (read_key_sequence, keyremap_step):
2487 Change bufsize argument back to int, undoing my 2011-03-30 change.
2488 We prefer signed types, and int is wide enough here.
2489 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2490 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2491 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2492 length, not size_t. Use ptrdiff_t for index, not int.
2493 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2494 possibility of integer overflow.
2495
13464394
PE
2496 Overflow, signedness and related fixes for images.
2497
2498 * dispextern.h (struct it.stack[0].u.image.image_id)
2499 (struct_it.image_id, struct image.id, struct image_cache.size)
2500 (struct image_cache.used, struct image_cache.ref_count):
2501 * gtkutil.c (update_frame_tool_bar):
2502 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2503 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2504 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2505 * nsmenu.m (update_frame_tool_bar):
2506 * xdisp.c (calc_pixel_width_or_height):
2507 * xfns.c (image_cache_refcount):
2508 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2509 on typical 64-bit hosts.
2510
2511 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2512 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2513 Omit unnecessary casts to int.
2514 (parse_image_spec): Check that integers fall into 'int' range
2515 when the callers expect that.
2516 (image_ascent): Redo ascent calculation to avoid int overflow.
2517 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2518 (lookup_image): Remove unnecessary tests.
2519 (xbm_image_p): Locals are now of int, not EMACS_INT,
2520 since parse_image_check makes sure they fit into int.
2521 (png_load, gif_load, svg_load_image):
2522 Prefer int to unsigned where either will do.
2523 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2524 old tiff_error_handler and tiff_warning_handler.
2525 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2526 stack buffer overflows. It uses only the features of vsnprintf
2527 that are common to both POSIX and native Microsoft.
2528 (tiff_error_handler, tiff_warning_handler): Use it.
2529 (tiff_load, gif_load, imagemagick_load_image):
2530 Don't assume :index value fits in 'int'.
2531 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2532 (imagemagick_load_image): Check that crop parameters fit into
2533 the integer types that MagickCropImage accepts. Don't assume
2534 Vimagemagick_render_type has a nonnegative value. Don't assume
2535 size_t fits in 'long'.
2536 (gs_load): Use printmax_t to print the widest integers possible.
2537 Check for integer overflow when computing image height and width.
2538
c11821d4
EZ
25392011-08-26 Eli Zaretskii <eliz@gnu.org>
2540
2541 * xdisp.c (redisplay_window): Don't force window start if point
2542 will be invisible in the resulting window. (Bug#9324)
2543
0c95fcf7
EZ
25442011-08-25 Eli Zaretskii <eliz@gnu.org>
2545
2546 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2547 the display spec is of the form `(space ...)'.
2548 (handle_display_spec): Return the value returned by
2549 handle_single_display_spec, not just 1 or zero.
2550 (handle_single_display_spec): If the display spec is of the form
2551 `(space ...)', and specifies display in the text area, return 2
2552 rather than 1.
fee65a97 2553 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2554 accurately, and prefer exact match for point under bidi.
2555 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2556
2557 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2558 into disp_prop; all users changed.
2559
2560 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2561 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2562 for the text covered by the display property.
2563
e4ed06f1
CY
25642011-08-25 Chong Yidong <cyd@stupidchicken.com>
2565
2566 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2567 Change return value to nil.
2568 (Frecord_buffer): Delete unused function.
2569
f67cdd7f
EZ
25702011-08-24 Eli Zaretskii <eliz@gnu.org>
2571
5980d4c6
EZ
2572 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2573 buffers, return left-to-right.
8610fe8b
EZ
2574 (set_cursor_from_row): Consider candidate row a win if its glyph
2575 represents a newline and point is on that newline. Fixes cursor
2576 positioning on the newline at EOL of R2L text within L2R
2577 paragraph, and vice versa.
2578 (try_cursor_movement): Check continued rows, in addition to
2579 continuation rows. Fixes unwarranted scroll when point enters a
2580 continued line of R2L text within an L2R paragraph, or vice versa.
2581 (cursor_row_p): Consider the case of point being equal to
2582 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2583 from the end of a short line to the beginning of a continued line
2584 of R2L text within L2R paragraph.
2585 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2586 composed characters.
5980d4c6 2587
f67cdd7f
EZ
2588 * bidi.c (bidi_check_type): Use xassert.
2589 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2590 members.
2591
bca633fb
EZ
25922011-08-23 Eli Zaretskii <eliz@gnu.org>
2593
2594 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2595 a character.
2596
4a5885a7
CY
25972011-08-23 Chong Yidong <cyd@stupidchicken.com>
2598
2599 * nsfont.m (ns_otf_to_script): Fix typo.
2600
0902a04e
KH
26012011-08-22 Kenichi Handa <handa@m17n.org>
2602
2603 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2604 extra slot even if the purpose is char-code-property-table.
2605
1a2e6670
EZ
26062011-08-23 Eli Zaretskii <eliz@gnu.org>
2607
8ddde651
EZ
2608 * xdisp.c (redisplay_window): When computing centering_position,
2609 account for the height of the header line. (Bug#8874)
2610
425cc014
EZ
2611 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2612 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2613 candidate is selected by the mouse, and that candidate has a
2614 composed character under the mouse.
2615
1a2e6670
EZ
2616 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2617 coordinates reported by pos-visible-in-window-p for a composed
2618 character in column zero.
2619
8b76d6f8
SM
26202011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2621
2622 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2623
dac347dd
EZ
26242011-08-22 Eli Zaretskii <eliz@gnu.org>
2625
2626 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2627 consider it a hit if to_charpos is anywhere in the range of the
2628 composed buffer positions.
2629
e013fb34
CY
26302011-08-22 Chong Yidong <cyd@stupidchicken.com>
2631
2632 * image.c (gif_load): Don't assume that each subimage has the same
2633 dimensions as the base image. Handle disposal method that is
2634 "undefined" by the gif spec (Bug#9335).
2635
bd1ba3e8
CY
26362011-08-20 Chong Yidong <cyd@stupidchicken.com>
2637
2638 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2639 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2640
54a1215b
EZ
26412011-08-19 Eli Zaretskii <eliz@gnu.org>
2642
823564e5
EZ
2643 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2644 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2645 from an Org mode buffer to a Speedbar frame.
2646
54a1215b
EZ
2647 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2648 a composition, take its buffer position from IT->cmp_it.charpos.
2649 Fixes cursor positioning at the beginning of a line that begins
2650 with a composed character.
2651
9778ebcc
EZ
26522011-08-18 Eli Zaretskii <eliz@gnu.org>
2653
0be6ee06
EZ
2654 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2655 character bidirectional type, use STRONG_L instead. Fixes crashes
2656 in a buffer produced by `describe-categories'.
2657
9778ebcc
EZ
2658 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2659 members before the level stack, so they would be saved and
2660 restored when copying iterator state. Fixes incorrect reordering
2661 around TABs covered by display properties.
2662
156bffbe
AS
26632011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2664
6b02f655 2665 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2666
72ad093b
CY
26672011-08-17 Chong Yidong <cyd@stupidchicken.com>
2668
2669 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2670 (internal_condition_case_2, internal_condition_case_n):
2671 Remove unnecessary aborts (Bug#9081).
72ad093b 2672
35774242
EZ
26732011-08-17 Eli Zaretskii <eliz@gnu.org>
2674
2675 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2676 has no `load' handler, try opening the file locally. (Bug#9311)
2677
db76dd85
KB
26782011-08-16 Ken Brown <kbrown@cornell.edu>
2679
2680 * gmalloc.c: Expand comment.
2681
b215eee5
EZ
26822011-08-16 Eli Zaretskii <eliz@gnu.org>
2683
2684 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2685 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2686
a4579d33
KB
26872011-08-16 Ken Brown <kbrown@cornell.edu>
2688
2689 Fix memory allocation problems in Cygwin build (Bug#9273).
2690
2691 * unexcw.c ( __malloc_initialized): Declare external variable.
2692 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2693
8b76d6f8
SM
2694 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2695 New variables.
a4579d33
KB
2696 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2697 dumped emacs.
2698 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2699 in the static heap.
2700 [CYGWIN] (special_realloc): New function.
2701 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2702 requests to realloc storage in the static heap.
2703
3ebec551
PE
27042011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 * bidi.c (bidi_initialize): Remove unused local.
2707
9fd8be00
EZ
27082011-08-15 Eli Zaretskii <eliz@gnu.org>
2709
6b02f655
SM
2710 * bidimirror.h:
2711 * biditype.h: Remove file.
2712 * makefile.w32-in ($(BLD)/bidi.$(O)):
2713 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2714
2715 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2716
2717 * chartab.c: Improve commentary for the uniprop_table API.
2718
32413314
EZ
2719 * bidi.c (bidi_paragraph_init): Support zero value of
2720 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2721 (bidi_initialize): Use uniprop_table instead of including
2722 biditype.h and bidimirror.h.
32413314 2723
9fd8be00
EZ
2724 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2725 coordinates of the iterator when restoring from ppos_it.
2726 (Bug#9296)
2727
5cf2b69b
KH
27282011-08-14 Kenichi Handa <handa@m17n.org>
2729
2730 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2731 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2732
daf17d00
EZ
27332011-08-14 Eli Zaretskii <eliz@gnu.org>
2734
2735 * xdisp.c (move_it_in_display_line_to): Don't invoke
2736 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2737 ppos_it. Fixes vertical cursor motion when line beginning is
2738 covered by an image. (Bug#9296)
2739
08e3161a
JD
27402011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2741
2742 * nsterm.h (ns_run_ascript): Declare.
2743 (NSAPP_DATA2_RUNASSCRIPT): Define.
2744
2745 * nsfns.m (as_script, as_result, as_status): New static variables.
2746 (ns_run_ascript): New function.
5e617bc2 2747 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2748 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2749 the event loop. Get status from as_status (Bug#7276).
2750
2751 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2752 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2753 the event loop (Bug#7276).
2754
a3720aa2
AS
27552011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2756
2757 * gnutls.c (QCgnutls_bootprop_priority)
2758 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2759 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2760 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2761 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2762 (QCgnutls_bootprop_verify_hostname_error)
2763 (QCgnutls_bootprop_callbacks_verify): Rename from
2764 Qgnutls_bootprop_..., all uses changed.
2765
2766 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2767 uses changed.
2768
0a0d27fb
PE
27692011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2770
19d5c50c
PE
2771 * xfaces.c (Qframe_set_background_mode): Now static.
2772 * dispextern.h (Qframe_set_background_mode): Remove decl.
2773
0a0d27fb
PE
2774 * process.c (Fnetwork_interface_info): Declare local only if needed.
2775
377538cb
JD
27762011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2777
2778 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2779 (Fnetwork_interface_list): Allocate in increments of bytes instead
2780 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2781 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2782 sockaddr.
2783 (struct ifflag_def): notrailers is smart on OSX.
2784 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2785 Get hardware address with getifaddrs if available.
2786
08fff70c
EZ
27872011-08-12 Eli Zaretskii <eliz@gnu.org>
2788
2789 * xdisp.c (iterate_out_of_display_property): xassert that
2790 IT->position is set to within IT->object's boundaries. Break from
2791 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2792 when IT->position is set up wrongly due to some bug.
2793 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2794 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2795 entry. Force push_it to save on the stack the current
2796 buffer/string position, to be restored by pop_it. Fix flags in
2797 the iterator structure wrt the object coming from a display
2798 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2799 properties. (Bug#9284)
2800
7be1c708 28012011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2802
7be1c708
CY
2803 * fontset.c (fontset_get_font_group): Add proper type checks.
2804 (Bug#9172)
aac0c6e3 2805
7be1c708 28062011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2807
7be1c708
CY
2808 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2809 and LC_VERSION_MIN_MACOSX.
2810 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2811 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2812
97bb72a6
EZ
28132011-08-08 Eli Zaretskii <eliz@gnu.org>
2814
2815 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2816 no-display-properties-and-no-overlays under bidi display.
2817 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2818 properties and overlays.
97bb72a6 2819
d5617611
CY
28202011-08-08 Chong Yidong <cyd@stupidchicken.com>
2821
37e11a63
CY
2822 * editfns.c (Fset_time_zone_rule): Document relationship with the
2823 setenv function.
2824
d5617611
CY
2825 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2826 the font entity extracted from the cache (Bug#8109).
2827
58872834
CY
28282011-08-07 Chong Yidong <cyd@stupidchicken.com>
2829
2830 * composite.c (autocmp_chars): Don't reset point. That is done by
2831 restore_point_unwind (Bug#5984).
2832
75bfc667
JL
28332011-08-07 Juri Linkov <juri@jurta.org>
2834
2835 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2836 to show the arg `TIME' instead of `TIMEVAL'.
2837
d1410150
EZ
28382011-08-06 Eli Zaretskii <eliz@gnu.org>
2839
2840 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2841 display property strides EOL and includes a newline, as in
2842 longlines-mode. (Bug#9254)
75b771e4
EZ
2843 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2844 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2845
2846 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2847 is non-zero, even if the data buffer is NULL. Fixes a crash in
2848 vertical-motion with longlines-mode. (Bug#9254)
2849
35928349
EZ
28502011-08-05 Eli Zaretskii <eliz@gnu.org>
2851
ec7cc85b
EZ
2852 * bidi.c <bidi_cache_total_alloc>: Now static.
2853 (bidi_initialize): Initialize bidi_cache_total_alloc.
2854
8b76d6f8 2855 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2856 cache. (Bug#9221)
2857
2858 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2859 amount allocated this far in `bidi_cache_total_alloc'.
2860 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2861 non-zero, only free the data buffer without restoring the cache
2862 contents. All callers changed.
2863
2864 * dispextern.h (bidi_unshelve_cache): Update prototype.
2865
2866 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2867 (move_it_in_display_line, move_it_to)
2868 (move_it_vertically_backward, move_it_by_lines): Replace the call
2869 to xfree to an equivalent call to bidi_unshelve_cache.
2870 (move_it_in_display_line_to): Fix logic of returning
412b6358 2871 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2872
e2e2423b
EZ
28732011-08-05 Eli Zaretskii <eliz@gnu.org>
2874
2875 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2876 came from a string character with a `cursor' property. (Bug#9229)
2877
ae9e757a
JD
28782011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2879
2880 * Makefile.in (LIB_PTHREAD): New variable.
2881 (LIBES): Add LIB_PTHREAD (Bug#9216).
2882
2883 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2884 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2885
213bd7f2
AS
28862011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2887
6b02f655 2888 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2889
99aaf75f
JD
28902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2891
2892 * xterm.c (x_find_topmost_parent): New function.
2893 (x_set_frame_alpha): Find topmost parent window with
2894 x_find_topmost_parent and set the property there also (bug#9181).
2895 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2896
c74e9d86
PE
28972011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * callproc.c (Fcall_process): Avoid vfork clobbering
2900 the local vars buffer, coding_systems, current_dir.
2901
640c8776
SM
29022011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2903
2904 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2905
f26d0e4c
PE
29062011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2907
8a10d76c
PE
2908 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2909 so that it is not optimized away.
2910
f26d0e4c
PE
2911 * xdisp.c (compute_display_string_pos): Remove unused local.
2912
55439c61
EZ
29132011-08-02 Eli Zaretskii <eliz@gnu.org>
2914
2915 Fix slow cursor motion and scrolling in large buffers with
2916 selective display, like Org Mode buffers. (Bug#9218)
2917
2918 * dispextern.h (struct bidi_it): New member disp_prop_p.
2919
2920 * xdisp.c: Remove one-slot cache of display string positions.
2921 (compute_display_string_pos): Accept an additional argument
5e617bc2 2922 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2923 for a display string or property. If found, set DISP_PROP_P
2924 non-zero.
2925
2926 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2927 DISP_PROP_P, and pass it to compute_display_string_pos.
2928 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2929 non-zero. All callers of bidi_fetch_char changed.
2930
fb33fa43
SM
29312011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2932
2933 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2934
b099e063
DM
29352010-12-03 Don March <don@ohspite.net>
2936
2937 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2938 last character M-[char] is translated to ESC [char] (bug#7541).
2939
5cc7f7af
KH
29402011-08-02 Kenichi Handa <handa@m17n.org>
2941
d0fffa3f 2942 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2943
2944 * chartab.c (uniprop_table): Make it non-static.
2945
525d5e6e
EZ
29462011-08-01 Eli Zaretskii <eliz@gnu.org>
2947
2948 * xdisp.c (forward_to_next_line_start): Accept additional argument
2949 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2950 on the newline.
2951 (reseat_at_next_visible_line_start): Use the bidi iterator state
2952 returned by forward_to_next_line_start to restore the state of
2953 it->bidi_it after backing up to previous newline. (Bug#9212)
2954
31011111
AS
29552011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2956
2957 * regex.c (re_comp): Protoize.
2958 (re_exec): Fix return type.
2959 (regexec): Fix type of `ret'. (Bug#9203)
2960
476371c4
PE
29612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2962
e5d76069
PE
2963 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2964 This is needed if max-image-size is a floating-point number.
2965
9a79b20c
AS
29662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2967
2968 * print.c (print_object): Print empty symbol as ##.
2969
2970 * lread.c (read1): Read ## as empty symbol.
2971
d8c2fa78
AA
29722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2973
2974 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2975 setting frame foreground color (Bug#9175).
2976 (x_set_background_color): Likewise.
2977
ffe57a7a
AA
2978 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2979 contents (Bug#9176).
2980 (EmacsTooltip -init): Remove bezels and add shadows to
2981 tooltip windows.
2982
bf3492a5
AA
2983 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2984 or scroll bar (Bug#8470).
2985
d55e9c53
AA
2986 * nsfont.m (nsfont_open): Remove assignment to voffset and
2987 unnecessary vars hshink, expand, hd, full_height, min_height.
2988 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2989
2990 * nsterm.h (nsfont_info): Remove voffset field.
2991
d8c2fa78 29922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2993
2994 Implement strike-through and overline on NextStep (Bug#8863).
2995
2996 * nsfont.m (nsfont_open): Use underline position provided by font,
2997 instead of hard-coded value of 2.
2998 (nsfont_draw): Call ns_draw_text_decoration instead.
2999
3000 * nsterm.h: Add declaration for ns_draw_text_decoration.
3001
3002 * nsterm.m (ns_draw_text_decoration): New function for drawing
3003 underline, overline, and strike-through.
3004 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3005 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3006 accommodate underlining, etc.
4843aac3 3007
4cc60b9b
EZ
30082011-07-28 Eli Zaretskii <eliz@gnu.org>
3009
bc7ece87
EZ
3010 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3011 default.
4cc60b9b 3012
476371c4
PE
30132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3014
66606eea
PE
3015 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3016 Without this fix, if a signal arrives just after memory fills up,
3017 'malloc' might be invoked reentrantly.
3018
476371c4
PE
3019 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3020 In other words, assume that every image size is allowed, on non-X
3021 hosts. This assumption is probably wrong, but it lets Emacs compile.
3022
f3fcc40d
AS
30232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3024
3025 * regex.c (re_iswctype): Convert return values to boolean.
3026
350c992f
EZ
30272011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3028
3029 * xdisp.c (compute_display_string_pos): Don't use cached display
3030 string position if the buffer had its restriction changed.
3031 (Bug#9184)
3032
5266b4bb
PE
30332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3036
2573a837 30372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3038
41f55ccd 3039 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3040
39e378da
PE
3041 * bidi.c: Integer size and overflow fixes.
3042 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3043 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3044 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3045 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3046 (bidi_find_other_level_edge):
3047 Use ptrdiff_t instead of EMACS_INT where either will do.
3048 This works better on 32-bit hosts configured --with-wide-int.
3049 (bidi_cache_ensure_space): Check for size-calculation overflow.
3050 Use % rather than repeated addition, for better worst-case speed.
3051 Don't set bidi_cache_size until after xrealloc returns, because it
3052 might not return.
3053 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3054 (bidi_cache_ensure_space): Also check that the bidi cache size
3055 does not exceed that of the largest Lisp string or buffer. See Eli
3056 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3057
5e927815
PE
3058 * alloc.c (__malloc_size_t): Remove.
3059 All uses replaced by size_t. See Andreas Schwab's note
3060 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3061
ca4aa935
PE
3062 * image.c: Improve checking for integer overflow.
3063 (check_image_size): Assume that f is nonnull, since
3064 it is always nonnull in practice. This is one less thing to
3065 worry about when checking for integer overflow later.
3066 (x_check_image_size): New function, which checks for integer
3067 overflow issues inside X.
3068 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3069 This removes the need for a memory_full check.
3070 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3071 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3072 (xbm_read_bitmap_data): Change locals back to 'int', since
3073 their values must fit in 'int'.
3074 (xpm_load_image, png_load, tiff_load):
3075 Invoke x_create_x_image_and_pixmap earlier,
3076 to avoid much needless work if the image is too large.
3077 (tiff_load): Treat overly large images as if
3078 x_create_x_image_and_pixmap failed, not as malloc failures.
3079 (gs_load): Use x_check_image_size.
3080
5f8f9cc2
PE
3081 * gtkutil.c: Omit integer casts.
3082 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3083 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3084
5adf60bc
PE
3085 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3086
c8907a93
PE
3087 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3088 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3089 would wrongly return t on a 64-bit host.
3090
e3c25c68
PE
3091 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3092 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3093 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3094 and therefore cause GCC to emit a bogus diagnostic in some cases.
3095
3f791afe
PE
3096 * image.c: Integer signedness and overflow and related fixes.
3097 This is not an exhaustive set of fixes, but it's time to
3098 record what I've got.
3099 (lookup_pixel_color, check_image_size): Remove redundant decls.
3100 (check_image_size): Don't assume that arbitrary EMACS_INT values
3101 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3102 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3103 (tiff_load, imagemagick_load_image):
3104 Check for overflow in size calculations.
3105 (x_create_x_image_and_pixmap): Remove unnecessary test for
3106 xmalloc returning NULL; that can't happen.
3107 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3108 (xpm_color_bucket): Use better integer hashing function.
3109 (xpm_cache_color): Don't possibly over-allocate memory.
3110 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3111 (gif_memory_source):
3112 Use ptrdiff_t, not int or size_t, to record sizes.
3113 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3114 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3115 either works, as we prefer signed integers.
3116 (tiff_read_from_memory, tiff_write_from_memory):
3117 Return tsize_t, not size_t, since that's what the TIFF API wants.
3118 (tiff_read_from_memory): Don't fail simply because the read would
3119 go past EOF; instead, return a short read.
3120 (tiff_load): Omit no-longer-needed casts.
3121 (Fimagemagick_types): Don't assume size fits into 'int'.
3122
3cc5a532
PE
3123 Improve hashing quality when configured --with-wide-int.
3124 * fns.c (hash_string): New function, taken from sxhash_string.
3125 Do not discard information about ASCII character case; this
3126 discarding is no longer needed.
3127 (sxhash-string): Use it. Change sig to match it. Caller changed.
3128 * lisp.h: Declare it.
3129 * lread.c (hash_string): Remove, since we now use fns.c's version.
3130 The fns.c version returns a wider integer if --with-wide-int is
3131 specified, so this should help the quality of the hashing a bit.
3132
b312a492
PE
3133 * emacs.c: Integer overflow minor fix.
3134 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3135 Define only if GNU_LINUX.
3136 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3137
dfd153ae
PE
3138 * dispnew.c: Integer signedness and overflow fixes.
3139 Remove unnecessary forward decls, that were a maintenance hassle.
3140 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3141 All uses changed.
3142 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3143 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3144 (prepare_desired_row, line_draw_cost):
3145 Use int, not unsigned, where either works.
3146 (save_current_matrix, restore_current_matrix):
3147 Use ptrdiff_t, not size_t, where either works.
3148 (init_display): Check for overflow more accurately, and without
3149 relying on undefined behavior.
3150
a81d11a3
PE
3151 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3152 Remove, replacing with the new symbols in lisp.h. All uses changed.
3153 * fileio.c (make_temp_name):
3154 * filelock.c (lock_file_1, lock_file):
3155 * xdisp.c (message_dolog):
3156 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3157 Use pMd etc. instead.
3158 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3159 replacing the pWIDE etc. symbols removed from editfns.c.
3160
3300e6fd
PE
3161 * keyboard.h (num_input_events): Now uintmax_t.
3162 This is (very slightly) less likely to mess up due to wraparound.
3163 All uses changed.
3164
fd05c7e9
PE
3165 * buffer.c: Integer signedness fixes.
3166 (alloc_buffer_text, enlarge_buffer_text):
3167 Use ptrdiff_t rather than size_t when either will do, as we prefer
3168 signed integers.
3169
903fe15d
PE
3170 * alloc.c: Integer signedness and overflow fixes.
3171 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3172 (__malloc_size_t): Default to size_t, not to int.
3173 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3174 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3175 Prefer ptrdiff_t to size_t when either would do, as we prefer
3176 signed integers.
3177 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3178 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3179 Now const. Initialize with values that are in range even if char
3180 is signed.
3181 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3182 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3183 These functions do the right thing with sizes > 2**32.
3184 (check_depth): Now ptrdiff_t, not int.
3185 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3186 Adjust to new way of storing sizes. Check for size overflow bugs
3187 in rest of code.
3188 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3189 slightly wrong anyway, as it missed one instance of
3190 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3191 (refill_memory_reserve): Omit needless cast to size_t.
3192 (mark_object_loop_halt): Mark as externally visible.
3193
ac82cc6a
PE
3194 * xselect.c: Integer signedness and overflow fixes.
3195 (Fx_register_dnd_atom, x_handle_dnd_message):
3196 Use ptrdiff_t, not size_t, since we prefer signed.
3197 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3198 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3199 x_dnd_atoms_size and x_dnd_atoms_length.
3200
c2d1e36d
PE
3201 * doprnt.c: Prefer signed to unsigned when either works.
3202 * eval.c (verror):
3203 * doprnt.c (doprnt):
3204 * lisp.h (doprnt):
3205 * xdisp.c (vmessage):
3206 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3207 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3208 prefer signed arithmetic to avoid comparison confusion.
3209 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3210 but is a bit tricky.
3211
0e926e56
PE
3212 Assume freestanding C89 headers, string.h, stdlib.h.
3213 * data.c, doprnt.c, floatfns.c, print.c:
3214 Include float.h unconditionally.
3215 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3216 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3217 * regex.c: Likewise for stddef.h, string.h.
3218 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3219 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3220 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3221 (STDC_HEADERS): Remove obsolete defines.
3222 * sysdep.c: Include limits.h unconditionally.
3223
9cfdb3ec
PE
3224 Assume support for memcmp, memcpy, memmove, memset.
3225 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3226 * regex.c (memcmp, memcpy):
3227 Remove; we assume C89 now.
3228
3229 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3230 (__malloc_safe_bcopy): Remove; no longer needed.
3231
cf950e6b 3232 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3233 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3234 well either way, and we prefer signed to unsigned.
3235
dbf38e02
LMI
32362011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3237
3238 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3239 closes the connection while we're reading (bug#9182).
3240
d6f0886c 32412011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3242
d6f0886c
JD
3243 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3244 are specified (Bug#9168).
24e0f6b1 3245
2eb1f9e6
PE
32462011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3249 Found by GCC static checking and --with-wide-int on a 32-bit host.
3250
22381272 32512011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3252
3253 * xdisp.c (compute_display_string_pos): Fix logic of caching
3254 previous display string position. Initialize cached_prev_pos to
3255 -1. Fixes slow-down at the beginning of a buffer.
3256
f25e39b4
EZ
32572011-07-24 Eli Zaretskii <eliz@gnu.org>
3258
3259 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3260 for attrs[LFACE_FONTSET_INDEX].
3261
04c4b52e
PE
32622011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 * xml.c (parse_region): Remove unused local
3265 that was recently introduced.
3266
c1734fbd
EZ
32672011-07-23 Eli Zaretskii <eliz@gnu.org>
3268
be18c5a5
EZ
3269 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3270 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3271
c1734fbd
EZ
3272 * xdisp.c (move_it_in_display_line_to): Record the best matching
3273 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3274 exit if none of the characters scanned was an exact match.
3275 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3276 when exact match is impossible due to invisible text, and the
3277 lines are truncated.
3278
a258d627
JD
32792011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3280
3281 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3282 for OSX >= 10.7.
3283
b6d5a689
EZ
32842011-07-22 Eli Zaretskii <eliz@gnu.org>
3285
0f74f785
EZ
3286 Fix a significant slow-down of cursor motion with C-n, C-p,
3287 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3288 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3289 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3290 (next_element_from_buffer): Call compute_stop_pos_backwards to
3291 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3292 base_level_stop.
3293 (reseat): Don't look for prev_stop, as that could mean a very long
3294 run.
3295 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3296 <cached_disp_overlay_modiff>: Cache for last found display string
3297 position.
551918c1 3298 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3299 about the same buffer in the same area of character positions, and
3300 the buffer wasn't changed since the time the display string
3301 position was cached.
551918c1 3302
b2d0c91a
EZ
33032011-07-22 Eli Zaretskii <eliz@gnu.org>
3304
3305 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3306 is an integer, which is important for empty lines. (Bug#9149)
3307
043604ee
CY
33082011-07-22 Chong Yidong <cyd@stupidchicken.com>
3309
3310 * frame.c (Fmodify_frame_parameters): In tty case, update the
3311 default face if necessary (Bug#4238).
3312
da4adb04
CY
33132011-07-21 Chong Yidong <cyd@stupidchicken.com>
3314
3315 * editfns.c (Fstring_to_char): No need to explain what a character
3316 is in the docstring (Bug#6576).
3317
9abd0532
LMI
33182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3319
3320 * xml.c (parse_region): Make sure we always return a tree.
3321
36881d16
HK
33222011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3323
3324 * xml.c (parse_region): If a document contains only comments,
3325 return that, too.
3326
1e98674d
LMI
33272011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3328
3329 * xml.c (make_dom): Return comments, too.
3330
590bd467
PE
33312011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3332
3333 Port to OpenBSD.
3334 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3335 and the surrounding thread.
3336 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3337 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3338 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3339 timer goes off.
3340 * s/openbsd.h (BROKEN_SIGIO): Define.
3341 * unexelf.c (unexec) [__OpenBSD__]:
3342 Don't update the .mdebug section of the Alpha COFF symbol table.
3343
f41628b2
LMI
33442011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3345
3346 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3347 (bug#8460).
3348
b59b67c5
PE
33492011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3350
15e3a074
PE
3351 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3352 This fixes some race conditions on the permissions of any newly
3353 created file.
3354
41bed37d
PE
3355 * alloc.c (valid_pointer_p): Use pipe, not open.
3356 This fixes some permissions issues when debugging.
3357
b59b67c5
PE
3358 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3359 If fchown fails to set both uid and gid, try to set just gid,
3360 as that is sometimes allowed. Adjust the file's mode to eliminate
3361 setuid or setgid bits that are inappropriate if fchown fails.
3362
925a6be7
SM
33632011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3364
3365 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3366 to compare Lisp_Objects.
3367 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3368 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3369 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3370
52968808
AS
33712011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3372
0a6a104b
AS
3373 * lread.c (read_integer): Unread even EOF character.
3374 (read1): Likewise. Properly record start position of symbol.
3375
52968808
AS
3376 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3377 symbol character follows.
3378
9e381cdd
PE
33792011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3380
3381 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3382 This works around a problem with the previous change to Fcopy_file.
3383 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3384 and without this change, GCC might complain about discarding
3385 fchown's return value.
3386
b5641435
JB
33872011-07-16 Juanma Barranquero <lekktu@gmail.com>
3388
3389 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3390
a8031457
PE
33912011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3394
dd889327
LMI
33952011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3396
750c33f7
LMI
3397 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3398 it's used from the C level.
3399
dd889327
LMI
3400 * process.c: Use the same condition for POLL_FOR_INPUT in both
3401 keyboard.c and process.c (bug#1858).
3402
87e86684
LM
34032011-07-09 Lawrence Mitchell <wence@gmx.li>
3404
3405 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3406 (Fgnutls_boot): Use it.
3407
64348f40
AS
34082011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3409
3410 * doc.c (Fsubstitute_command_keys): Revert last change.
3411
1d698799
LMI
34122011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3413
f863868c
LMI
3414 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3415 quotes the next character, and doesn't affect other longer
3416 sequences (bug#8935).
3417
1d698799
LMI
3418 * lread.c (syms_of_lread): Clarify that is isn't only
3419 `eval-buffer' and `eval-defun' that's affected by
3420 `lexical-binding' (bug#8460).
3421
aa4b6df6
EZ
34222011-07-15 Eli Zaretskii <eliz@gnu.org>
3423
3424 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3425 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3426
5d856da6
PE
34272011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3428
ad6042bb
PE
3429 Fix minor problems found by static checking.
3430 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3431 (elsz): Now a signed constant, not a size_t var. We prefer signed
3432 types to unsigned, to avoid integer comparison confusion. Without
3433 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3434 "cannot optimize loop, the loop counter may overflow", a symptom
3435 of the confusion.
f00bbb22 3436 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3437 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3438
6468f31c
LMI
34392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3440
49080b10
LMI
3441 * search.c (Fre_search_backward): Mention `case-fold-search' in
3442 all the re_search_* functions (bug#8138).
3443
6468f31c
LMI
3444 * keyboard.c (Fopen_dribble_file): Document when the file is
3445 closed (bug#8056).
3446
c965adc5
EZ
34472011-07-14 Eli Zaretskii <eliz@gnu.org>
3448
df9733bf
EZ
3449 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3450 bidi_cache_idx.
3451
0bb23927
EZ
3452 Support bidi reordering of display and overlay strings.
3453 * xdisp.c (compute_display_string_pos)
3454 (compute_display_string_end): Accept additional argument STRING.
3455 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3456 (reseat_to_string): Initialize bidi_it->string.s and
3457 bidi_it->string.schars.
3458 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3459 NULL (avoids a crash in bidi_paragraph_init).
3460 Initialize itb.string.lstring.
0bb23927
EZ
3461 (init_iterator): Call bidi_init_it only of a valid
3462 buffer position was specified. Initialize paragraph_embedding to
3463 L2R.
3464 (reseat_to_string): Initialize the bidi iterator.
3465 (display_string): If we need to ignore text properties of
3466 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3467 original value of -1 will not work with bidi.)
3468 (compute_display_string_pos): First arg is now struct
3469 `text_pos *'; all callers changed. Support display properties on
3470 Lisp strings.
3471 (compute_display_string_end): Support display properties on Lisp
3472 strings.
3473 (init_iterator, reseat_1, reseat_to_string): Initialize the
3474 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3475 when iterating on a string not from display properties).
640c8776
SM
3476 (compute_display_string_pos, compute_display_string_end):
3477 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3478 arrow keys.
3479 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3480 base_level_stop; instead, set base_level_stop to BEGV.
3481 Fixes crashes in vertical-motion.
0bb23927
EZ
3482 (next_element_from_buffer): Improve commentary for when
3483 the iterator is before prev_stop.
3484 (init_iterator): Initialize bidi_p from the default value of
3485 bidi-display-reordering, not from buffer-local value. Use the
3486 buffer-local value only if initializing for buffer iteration.
3487 (handle_invisible_prop): Support invisible properties on strings
3488 that are being bidi-reordered.
3489 (set_iterator_to_next): Support bidi reordering of C strings and
3490 Lisp strings.
3491 (next_element_from_string): Support bidi reordering of Lisp
3492 strings.
3493 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3494 (display_string): Support display of R2L glyph rows.
3495 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3496 (init_iterator): Don't initialize it->bidi_p for strings
3497 here.
3498 (reseat_to_string): Initialize it->bidi_p for strings here.
3499 (next_element_from_string, next_element_from_c_string)
3500 (next_element_from_buffer): Add xassert's for correspondence
3501 between IT's object being iterated and it->bidi_it.string
3502 structure.
3503 (face_before_or_after_it_pos): Support bidi iteration.
3504 (next_element_from_c_string): Handle the case of the first string
3505 character that is not the first one in the visual order.
3506 (get_visually_first_element): New function, refactored from common
3507 parts of next_element_from_buffer, next_element_from_string, and
3508 next_element_from_c_string.
3509 (tool_bar_lines_needed, redisplay_tool_bar)
3510 (display_menu_bar): Force left-to-right direction. Add a FIXME
3511 comment for making that be controlled by a user option.
3512 (push_it, pop_it): Save and restore the state of the
3513 bidi iterator. Save and restore the bidi_p flag.
3514 (pop_it): Iterate out of display property for string iteration as
3515 well.
3516 (iterate_out_of_display_property): Support iteration over strings.
3517 (handle_single_display_spec): Set up it->bidi_it for iteration
3518 over a display string, and call bidi_init_it.
3519 (handle_single_display_spec, next_overlay_string)
3520 (get_overlay_strings_1, push_display_prop): Set up the bidi
3521 iterator for displaying display or overlay strings.
3522 (forward_to_next_line_start): Don't use the shortcut if
3523 bidi-iterating.
3524 (back_to_previous_visible_line_start): If handle_display_prop
3525 pushed the iterator stack, restore the internal state of the bidi
3526 iterator by calling bidi_pop_it same number of times.
3527 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3528 and we are bidi-iterating, don't decrement the iterator position;
3529 instead, set the first_elt flag in the bidi iterator, to produce
3530 the same effect.
3531 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3532 (push_display_prop): xassert that we are iterating a buffer.
3533 (push_it, pop_it): Save and restore paragraph_embedding member.
3534 (handle_single_display_spec, next_overlay_string)
3535 (get_overlay_strings_1, reseat_1, reseat_to_string)
3536 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3537 correctly. Don't assume unibyte strings are not bidi-reordered.
3538 (compute_display_string_pos)
3539 (compute_display_string_end): Fix handling the case of C string.
3540 (push_it, pop_it): Save and restore from_disp_prop_p.
3541 (handle_single_display_spec, push_display_prop): Set the
3542 from_disp_prop_p flag.
3543 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3544 (pop_it): Call iterate_out_of_display_property only if we are
3545 popping after iteration over a string that came from a display
3546 property. Fix a typo in popping stretch info. Add an assertion
3547 for verifying that the iterator position is in sync with the bidi
3548 iterator.
3549 (handle_single_display_spec, get_overlay_strings_1)
3550 (push_display_prop): Fix initialization of paragraph direction for
3551 string when that of the parent object is not yet determined.
3552 (reseat_1): Call bidi_init_it to resync the bidi
3553 iterator with IT's position. (Bug#7616)
3554 (find_row_edges): If ROW->start.pos gives position
3555 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3556 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3557 Reset the from_disp_prop_p flag.
3558 (SAVE_IT, RESTORE_IT): New macros.
3559 (pos_visible_p, face_before_or_after_it_pos)
3560 (back_to_previous_visible_line_start)
3561 (move_it_in_display_line_to, move_it_in_display_line)
3562 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3563 (try_scrolling, redisplay_window, display_line): Use them when
3564 saving a temporary copy of the iterator and restoring it back.
3565 (back_to_previous_visible_line_start, reseat_1)
3566 (init_iterator): Empty the bidi cache "stack".
3567 (move_it_in_display_line_to): If iterator ended up at
3568 EOL, but we never saw any buffer positions smaller than
3569 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3570 motion in bidi-reordered lines.
3571 (move_it_in_display_line_to): Record prev_method and prev_pos
3572 immediately before the call to set_iterator_to_next. Fixes cursor
3573 motion in bidi-reordered lines with stretch glyphs and strings
3574 displayed in margins. (Bug#8133) (Bug#8867)
3575 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3576 TO_CHARPOS.
640c8776
SM
3577 (pos_visible_p): Support positions in bidi-reordered lines.
3578 Save and restore bidi cache.
0bb23927
EZ
3579
3580 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3581 (bidi_paragraph_info): Delete unused struct.
3582 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3583 (bidi_cache_start): New variable.
3584 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3585 to zero.
3586 (bidi_cache_fetch_state, bidi_cache_search)
3587 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3588 (bidi_cache_find, bidi_peek_at_next_level)
3589 (bidi_level_of_next_char, bidi_find_other_level_edge)
3590 (bidi_move_to_visually_next): Compare cache index with
3591 bidi_cache_start rather than with zero.
3592 (bidi_fetch_char): Accept new argument STRING; all callers
3593 changed. Support iteration over a string. Support strings with
3594 display properties. Support unibyte strings. Fix the type of
3595 `len' according to what STRING_CHAR_AND_LENGTH expects.
3596 (bidi_paragraph_init, bidi_resolve_explicit_1)
3597 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3598 (bidi_level_of_next_char, bidi_move_to_visually_next):
3599 Support iteration over a string.
0bb23927
EZ
3600 (bidi_set_sor_type, bidi_resolve_explicit_1)
3601 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3602 can now be zero (for strings); special values 0 and -1 were
3603 changed to -1 and -2, respectively.
3604 (bidi_char_at_pos): New function.
3605 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3606 Call it instead of FETCH_MULTIBYTE_CHAR.
3607 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3608 initialized to valid values.
3609 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3610 values.
3611 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3612 the test for valid cached positions. Fix the logic for looking up
3613 the sentinel state in the cache. GCPRO the Lisp string we are
3614 iterating.
3615 (bidi_push_it, bidi_pop_it): New functions.
3616 (bidi_initialize): Initialize the bidi cache start stack pointer.
3617 (bidi_cache_ensure_space): New function, refactored from part of
3618 bidi_cache_iterator_state. Don't assume the required size is just
3619 one BIDI_CACHE_CHUNK away.
3620 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3621 (bidi_count_bytes, bidi_char_at_pos): New functions.
3622 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3623 always valid if bidi_cache_idx is valid.
3624 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3625 is valid if it's going to be used.
3626 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3627 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3628 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3629 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3630 (bidi_find_other_level_edge, bidi_cache_start_stack):
3631 All variables related to cache indices are now EMACS_INT.
c965adc5 3632
0bb23927
EZ
3633 * dispextern.h (struct bidi_string_data): New structure.
3634 (struct bidi_it): New member `string'. Make flag members be 1-bit
3635 fields, and put them last in the struct.
640c8776
SM
3636 (compute_display_string_pos, compute_display_string_end):
3637 Update prototypes.
0bb23927
EZ
3638 (bidi_push_it, bidi_pop_it): Add prototypes.
3639 (struct iterator_stack_entry): New members bidi_p,
3640 paragraph_embedding, and from_disp_prop_p.
3641 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3642 (bidi_shelve_cache, bidi_unshelve_cache):
3643 Declare prototypes.
0bb23927
EZ
3644
3645 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3646 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3647 and vector-like objects.
3648
3649 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3650 cache around display iteration.
3651
3652 * window.c (Fwindow_end, window_scroll_pixel_based)
3653 (displayed_window_lines, Frecenter): Save and restore the bidi
3654 cache around display iteration.
3655
3bbd2265
LMI
36562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3657
3658 * editfns.c (Fdelete_region): Clarify the use of the named
3659 parameters (bug#6788).
3660
adc47434
MR
36612011-07-14 Martin Rudalics <rudalics@gmx.at>
3662
3663 * indent.c (Fvertical_motion): Set and restore w->pointm when
3664 saving and restoring the window's buffer (Bug#9006).
3665
837c31f8
LMI
36662011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3667
3668 * editfns.c (Fstring_to_char): Clarify just what is returned
3669 (bug#6576). Text by Eli Zaretskii.
3670
ac389d0c
JB
36712011-07-13 Juanma Barranquero <lekktu@gmail.com>
3672
3673 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3674
0be0ce47
EZ
36752011-07-13 Eli Zaretskii <eliz@gnu.org>
3676
3677 * buffer.c (mmap_find): Fix a typo.
3678
cd18e7e3
JB
36792011-07-13 Johan Bockgård <bojohan@gnu.org>
3680
3681 Fix execution of x selection hooks.
3682 * xselect.c (Qx_lost_selection_functions)
3683 (Qx_sent_selection_functions): New vars.
3684 (syms_of_xselect): DEFSYM them.
3685 (x_handle_selection_request): Pass Qx_sent_selection_functions
3686 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3687 (x_handle_selection_clear,x_clear_frame_selections):
3688 Pass Qx_lost_selection_functions rather than
3689 Vx_lost_selection_functions to Frun_hook_with_args.
3690
47ea7f44
PE
36912011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3692
ac389d0c 3693 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3694 The old code sometimes used this field without initializing it.
3695
47ea7f44
PE
3696 * alloc.c (gc_sweep): Don't read past end of array.
3697 In theory, the old code could also have corrupted Emacs internals,
3698 though it'd be very unlikely.
3699
bc985c87
AS
37002011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3701
3702 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3703 argument. (Bug#4026)
bc985c87 3704
0cf34688
LMI
37052011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3706
b3dadd76
LMI
3707 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3708 key" (bug#4257).
3709
0cf34688
LMI
3710 * window.c (Fset_window_start): Doc fix (bug#4199).
3711 (Fset_window_hscroll): Ditto.
3712
270768cd
PE
37132011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3714
077e3dda 3715 Fix minor new problems caught by GCC 4.6.1.
270768cd 3716 * term.c (init_tty): Remove unused local.
490011a6 3717 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3718 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3719 not used otherwise.
270768cd 3720
b1f58454
CY
37212011-07-12 Chong Yidong <cyd@stupidchicken.com>
3722
3723 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3724
22b9578d
LMI
37252011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3726
6e70ab07
LMI
3727 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3728 are the mini-buffer and the echo area (bug#3320).
3729
22b9578d
LMI
3730 * term.c (init_tty): Remove support for supdup, c10 and perq
3731 terminals, which are no longer supported (bug#1482).
3732
8974cc9f
JB
37332011-07-10 Johan Bockgård <bojohan@gnu.org>
3734
3735 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3736
a560d974
JD
37372011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3738
3739 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3740 for non-popups (Bug#3642).
3741
1dae0f0a
AS
37422011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3743
268c2c36 3744 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3745 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3746 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3747 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3748 * data.c (fmod): Likewise.
3749 * dispnew.c (swap_glyphs_in_rows): Likewise.
3750 * emacs.c (memory_warning_signal): Likewise.
3751 * floatfns.c (float_error): Likewise.
3752 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3753 (otf_open, font_otf_capability, generate_otf_features)
3754 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3755 Likewise.
3756 * image.c (pbm_read_file): Likewise.
3757 * indent.c (string_display_width): Likewise.
3758 * intervals.c (check_for_interval, search_for_interval)
3759 (inc_interval_count, count_intervals, root_interval)
3760 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3761 * lread.c (defalias): Likewise.
268c2c36 3762 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3763 * regex.c (set_image_of_range_1, set_image_of_range)
3764 (regex_grow_registers): Likewise.
3765 * sysdep.c (strerror): Likewise.
3766 * termcap.c (valid_filename_p, tprint, main): Likewise.
3767 * tparam.c (main): Likewise.
3768 * unexhp9k800.c (run_time_remap, save_data_space)
3769 (update_file_ptrs, read_header, write_header, calculate_checksum)
3770 (copy_file, copy_rest, display_header): Likewise.
3771 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3772 Likewise.
3773 * xdisp.c (check_it): Likewise.
3774 * xfaces.c (register_color, unregister_color, unregister_colors):
3775 Likewise.
3776 * xfns.c (print_fontset_result): Likewise.
3777 * xrdb.c (member, fatal, main): Likewise.
3778
99033785
PE
37792011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3780
3781 Fix minor problems found by static checking (Bug#9031).
3782 * chartab.c (char_table_set_range, map_sub_char_table):
3783 Remove unused locals.
3784 (uniprop_table): Now static.
3785 * composite.c (_work_char): Remove unused static var.
3786
9cb2ac56
JB
37872011-07-09 Juanma Barranquero <lekktu@gmail.com>
3788
3789 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3790
f25661f0
JD
37912011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3792
3793 * gtkutil.c (qttip_cb): Remove code without function.
3794
8278c4fe
EZ
37952011-07-09 Eli Zaretskii <eliz@gnu.org>
3796
3797 * w32.c (pthread_sigmask): New stub.
3798
1692ae2d 37992011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3800
8a6ebd58 3801 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3802 sigprocmask is portable only for single-threaded applications, and
3803 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3804 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3805 (LIBES): Use it.
3806 * callproc.c (Fcall_process):
3807 * process.c (create_process):
3808 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3809 Use pthread_sigmask, not sigprocmask.
123403e4 3810
1b854618
JD
38112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3812
3813 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3814 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3815 wrong (Bug#8591).
3816
3fe4b549
JD
38172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3818
0ce7e563
JD
3819 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3820 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3821 (xg_hide_tooltip): Fix comment.
3822
3fe4b549
JD
3823 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3824 in registerServicesMenuSendTypes.
3825 (validRequestorForSendType): Don't check ns_return_types.
3826
3827 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3828 ns_return_type.
3829
5df75e47
JR
38302011-07-08 Jason Rumney <jasonr@gnu.org>
3831
22610910
JR
3832 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3833 SH_SHOW for hidden windows (Bug#5482).
3834
5df75e47
JR
3835 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3836 frame struct members of non-existent frames (Bug#6284).
3837
699c10bd
JD
38382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3839
4393663b
JD
3840 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3841 variable firstTime not needed on OSX >= 10.6.
3842 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3843 >= 10.5. Use setKnobProportion, setDoubleValue.
3844
3845 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3846 (MAC_OS_X_VERSION_10_5): Define if not defined.
3847 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3848 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3849 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3850
3851 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3852 cString and lossyCString on OSX >= 10.4
3853
58179cce 3854 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3855 sizeToFit on OSX >= 10.2.
3856
3857 * nsimage.m (allocInitFromFile): Don't use deprecated method
3858 bestRepresentationForDevice on OSX >= 10.6.
3859
3860 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3861 to avoid warning.
3862
3863 * emacs.c: Declare unexec_init_emacs_zone.
3864
a63e0781
JD
3865 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3866
699c10bd
JD
3867 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3868
3869 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3870 on svcsMenu (Bug#8842).
3871
3872 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3873 ns_return_types.
3874 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3875
3876 * nsterm.m (QUTF8_STRING): Declare.
3877 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3878 (validRequestorForSendType): Return type is (id).
3879 Change indexOfObjectIdenticalTo to indexOfObject.
3880 Check if we have local selection before returning self (Bug#8842).
3881 (writeSelectionToPasteboard): Put local selection into paste board
3882 if we have a local selection (Bug#8842).
3883 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3884
3885 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3886 (ns_get_local_selection): Declare.
3887
54e10184
LMI
38882011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889
9888ff71
LMI
3890 * keymap.c (describe_map_tree): Don't insert a double newline at
3891 the end of the buffer (bug#1169) and return whether we inserted
3892 something.
3893
54e10184
LMI
3894 * callint.c (Fcall_interactively): Change "reading args" to
3895 "providing args" to try to clarify what it does (bug#1010).
3896
15fa4783
KH
38972011-07-07 Kenichi Handa <handa@m17n.org>
3898
3899 * composite.c (composition_compute_stop_pos): Ignore a static
3900 composition starting before CHARPOS (Bug#8915).
3901
3902 * xdisp.c (handle_composition_prop): Likewise.
3903
a8815b00
EZ
39042011-07-07 Eli Zaretskii <eliz@gnu.org>
3905
3906 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3907 (Bug#9015)
3908
ef7b981d 39092011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3910
3911 * character.h (unicode_category_t): New enum type.
3912
3913 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3914 (Qchar_code_property_table): New variable.
3915 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3916 (UNIPROP_COMPRESSED_FORM_P): New macros.
3917 (char_table_ascii): Uncompress the compressed values.
3918 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3919 Uncompress the compressed values.
ac389d0c 3920 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3921 (char_table_ref_and_range): Uncompress the compressed values.
3922 (sub_char_table_set): New arg is_uniprop. Callers changed.
3923 Uncompress the compressed values.
3924 (sub_char_table_set_range): Args changed. Callers changed.
3925 (char_table_set_range): Adjuted for the above change.
3926 (map_sub_char_table): Delete args default_val and parent. Add arg
3927 top. Give decoded values to a Lisp function.
640c8776 3928 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3929 values to a Lisp function. Gcpro more variables.
3930 (uniprop_table_uncompress)
3931 (uniprop_decode_value_run_length): New functions.
3932 (uniprop_decoder, uniprop_decoder_count): New variables.
3933 (uniprop_get_decoder, uniprop_encode_value_character)
3934 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3935 New functions.
3936 (uniprop_encoder, uniprop_encoder_count): New variables.
3937 (uniprop_get_encoder, uniprop_table)
3938 (Funicode_property_table_internal, Fget_unicode_property_internal)
3939 (Fput_unicode_property_internal): New functions.
3940 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3941 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3942 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3943 char-code-property-alist.
3944
640c8776 3945 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3946 Vunicode_category_table.
3947
640c8776 3948 * font.c (font_range): Adjust for the change of
c805dec0
KH
3949 Vunicode_category_table.
3950
76b397fb
DN
39512011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3952
3953 * m/iris4d.h: Remove file, move contents ...
3954 * s/irix6-5.h: ... here.
3955
22b4128e
PE
39562011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3959 * alloc.c (mark_buffer):
3960 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3961 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3962 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3963 This isn't true in general, and it's particularly not true
3964 if Emacs is configured with --with-wide-int.
3965 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3966 New macros, used in the buffer.c change.
3967
869795d6
JD
39682011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3969
3970 * xsettings.c: Use both GConf and GSettings if both are available.
3971 (store_config_changed_event): Add comment.
3972 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3973 (store_tool_bar_style_changed): New functions.
5e617bc2 3974 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3975 (struct xsettings): Move font inside HAVE_XFT.
3976 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3977 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3978 Move inside HAVE_XFT.
640c8776 3979 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3980 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3981 also.
3982 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3983 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3984 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3985 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3986 (parse_settings): Move check for font inside HAVE_XFT.
3987 (read_settings, apply_xft_settings): Add comment.
3988 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3989 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3990 call store_font_name_changed.
3991 (xft_settings_event): Add comment.
3992 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3993 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3994 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3995 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3996 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3997 (xsettings_get_system_font, xsettings_get_system_normal_font):
3998 Add comment.
869795d6 3999
d8ed26bd
PE
40002011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 Random fixes. E.g., (random) never returned negative values.
4003 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4004 subseconds part to the entropy, as that's a bit more random.
4005 Prefer signed to unsigned, since the signedness doesn't matter and
4006 in general we prefer signed. When given a limit, use a
4007 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4008 latter isn't right if USE_2_TAGS_FOR_INTS.
4009 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4010 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4011
cabf1cac
SM
40122011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4013
4014 * textprop.c (text_property_stickiness):
4015 Obey Vtext_property_default_nonsticky.
4016 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4017 * w32fns.c (syms_of_w32fns):
4018 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4019
6e9b2be9
PE
40202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4023 This is more efficient than Ffile_directory_p and avoids a minor race.
4024
90186c68
LMI
40252011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4026
7c301272
LMI
4027 * buffer.c (Foverlay_put): Say what the return value is
4028 (bug#7835).
4029
c4f2d8d4
LMI
4030 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4031 is a directory before asking whether to use the file name
4032 (bug#7564).
ad637907
LMI
4033 (barf_or_query_if_file_exists): Make the "File is a directory"
4034 error be more correct.
c4f2d8d4 4035
90186c68
LMI
4036 * fns.c (Frequire): Remove the mention of the .gz files, since
4037 that's installation-specific, but keep the mention of
4038 `get-load-suffixes'.
4039
da64016e
PE
40402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4043 Report string overflow if the output is too long.
4044
7d47b580
JB
40452011-07-04 Juanma Barranquero <lekktu@gmail.com>
4046
a555cb87
JB
4047 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4048 (syms_of_gnutls): Remove duplicate DEFSYM for
4049 Qgnutls_bootprop_verify_hostname_error, an error for
4050 Qgnutls_bootprop_verify_error (which is no longer used).
4051
7d47b580
JB
4052 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4053 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4054 Also (re)move comments that are misplaced or no longer relevant.
4055
1e49bfab
LMI
40562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4057
4058 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4059
1485f4c0
CY
40602011-07-03 Chong Yidong <cyd@stupidchicken.com>
4061
4062 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4063 and background color parameters if they have been changed.
4064
a9ab721e
LMI
40652011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4066
4067 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4068
cf7cff57
PE
40692011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4070
2e13213d
PE
4071 * xsettings.c (SYSTEM_FONT): Define only when used.
4072 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4073
cf7cff57
PE
4074 * keymap.c (access_keymap_1): Now static.
4075
7a8e04f7
CY
40762011-07-02 Chong Yidong <cyd@stupidchicken.com>
4077
4078 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4079 leave any prefix arg for the up event (Bug#1586).
4080
61352f62
LMI
40812011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4082
69bb1ef7
LMI
4083 * lread.c (syms_of_lread): Mention single symbols defined by
4084 `defvar' or `defconst' (bug#7154).
4085
61352f62 4086 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4087 (Frequire): Mention get-load-suffixes.
61352f62 4088
28545e04
MR
40892011-07-02 Martin Rudalics <rudalics@gmx.at>
4090
4091 * window.h (window): Remove clone_number slot.
4092 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4093 Remove.
4094 (make_parent_window, make_window, saved_window)
4095 (Fset_window_configuration, save_window_save): Don't deal with
4096 clone numbers.
4097 * buffer.c (Qclone_number): Remove declaration.
4098 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4099
3349e122
SM
41002011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4101
4102 Add multiple inheritance to keymaps.
4103 * keymap.c (Fmake_composed_keymap): New function.
4104 (Fset_keymap_parent): Simplify.
4105 (fix_submap_inheritance): Remove.
4106 (access_keymap_1): New function extracted from access_keymap to handle
4107 embedded parents and handle lists of maps.
4108 (access_keymap): Use it.
4109 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4110 (Fcopy_keymap): Handle embedded parents.
4111 (Fcommand_remapping, define_as_prefix): Simplify.
4112 (Fkey_binding): Simplify.
4113 (syms_of_keymap): Move minibuffer-local-completion-map,
4114 minibuffer-local-filename-completion-map,
4115 minibuffer-local-must-match-map, and
4116 minibuffer-local-filename-must-match-map to Elisp.
4117 (syms_of_keymap): Defsubr make-composed-keymap.
4118 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4119 (parse_menu_item): Trivial simplification.
4120
3279eb87
GM
41212011-07-01 Glenn Morris <rgm@gnu.org>
4122
4123 * Makefile.in (SETTINGS_LIBS): Fix typo.
4124
4550efdf
KI
41252011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4126
4127 * coding.c (Fencode_coding_string): Record the last coding system
4128 used, as the function doc string says (bug#8738).
4129
0949d2b6
JD
41302011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4131
4132 * xsettings.c (store_monospaced_changed): Take new font as arg and
4133 check for change against current_mono_font.
4134 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4135 (emacs_settings_constructor, emacs_settings_get_property)
4136 (emacs_settings_set_property, emacs_settings_class_init)
4137 (emacs_settings_init, gsettings_obj): Remove.
4138 (something_changedCB): New function for HAVE_GSETTINGS.
4139 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4140 with value as argument.
4141 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4142 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4143 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4144 "changed".
4145
4146 * xgselect.c: Add defined (HAVE_GSETTINGS).
4147 (xgselect_initialize): Ditto.
4148
4149 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4150 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4151 xg_select.
4152
bbc6b304
PE
41532011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4154
4155 * eval.c (struct backtrace): Simplify and port the data structure.
4156 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4157 signed bit field, as this assumption is not portable and it makes
4158 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4159 "char debug_on_exit : 1" as this is not portable either; instead,
4160 use the portable "unsigned int debug_on_exit : 1". Remove unused
4161 member evalargs. Remove obsolete comments about cc bombing out.
4162
9851bfc5
JD
41632011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4164
51bb811f 4165 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4166 Let HAVE_GSETTINGS override HAVE_GCONF.
4167 (store_monospaced_changed): New function.
4168 (EMACS_SETTINGS): A new type derived from GObject to handle
4169 GSettings notifications.
4170 (emacs_settings_constructor, emacs_settings_get_property)
4171 (emacs_settings_set_property, emacs_settings_class_init):
4172 New functions.
4173 (gsettings_client, gsettings_obj): New variables.
4174 (GSETTINGS_SCHEMA): New define.
4175 (something_changedCB): Call store_monospaced_changed.
4176 (init_gsettings): New function.
4177 (xsettings_initialize): Call init_gsettings.
4178 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4179 to NULL.
4180
640c8776 4181 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4182 GCONF_CFLAGS/LIBS.
4183
5386012d
MR
41842011-06-29 Martin Rudalics <rudalics@gmx.at>
4185
4186 * window.c (resize_root_window, grow_mini_window)
4187 (shrink_mini_window): Rename Qresize_root_window to
4188 Qwindow_resize_root_window and Qresize_root_window_vertically to
4189 Qwindow_resize_root_window_vertically.
4190
f13e0b08
PE
41912011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4194
94515237
JB
41952011-06-27 Juanma Barranquero <lekktu@gmail.com>
4196
4197 * makefile.w32-in: Redesign dependencies so they reflect more
4198 clearly which files are directly included by each source file,
4199 and not through other includes.
4200
e43b6e43
MR
42012011-06-27 Martin Rudalics <rudalics@gmx.at>
4202
4203 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4204 (sort_overlays, overlay_strings): When an overlay's clone number
4205 matches the window's clone number process the overlay even if
4206 the overlay's window property doesn't match the current window.
4207
d68443dc
MR
4208 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4209 (Fwindow_hchild): Rename to Fwindow_left_child.
4210 (Fwindow_next): Rename to Fwindow_next_sibling.
4211 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4212 (resize_window_check): Rename to window_resize_check.
4213 (resize_window_apply): Rename to window_resize_apply.
4214 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4215 (Fdelete_other_windows_internal, resize_frame_windows)
4216 (Fsplit_window_internal, Fdelete_window_internal)
4217 (grow_mini_window, shrink_mini_window)
4218 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4219
c7e73be5
JD
42202011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4221
4222 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4223 (emacs_fixed_set_min_size): Remove.
4224 (emacs_fixed_new): Take frame as argument.
4225
4226 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4227 (_EmacsFixedPrivate): Remove minwidth/height.
4228 Add struct frame *f.
4229 (emacs_fixed_init): Initialize priv->f.
4230 (get_parent_class, emacs_fixed_set_min_size): Remove.
4231 (emacs_fixed_new): Set priv->f to argument.
4232 (emacs_fixed_get_preferred_width)
4233 (emacs_fixed_get_preferred_height): Use min_width/height from
4234 frames size_hint to set minimum and natural (Bug#8919).
4235 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4236 and use min_width/height from frames size_hint to set
4237 min_width/height (Bug#8919).
4238
4239 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4240 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4241 Fix indentation.
c7e73be5 4242
cf99dcf8
EZ
42432011-06-26 Eli Zaretskii <eliz@gnu.org>
4244
4245 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4246 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4247 called at ZV.
4248
029529ac
CY
42492011-06-26 Chong Yidong <cyd@stupidchicken.com>
4250
4251 * process.c (wait_reading_process_output): Bypass select if
4252 waiting for a cell while ignoring keyboard input, and input is
4253 pending. Suggested by Jan Djärv (Bug#8869).
4254
7a7ef429
PE
42552011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 Use gnulib's dup2 module instead of rolling our own.
4258 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4259
11fdef7d 42602011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4261
4262 * dispnew.c (scrolling_window): Before scrolling, turn off a
4263 mouse-highlight in the window being scrolled.
4264
cd3520a4
JB
42652011-06-24 Juanma Barranquero <lekktu@gmail.com>
4266
4267 Move DEFSYM to lisp.h and use everywhere.
4268
4269 * character.h (DEFSYM): Move declaration...
4270 * lisp.h (DEFSYM): ...here.
4271
4272 * gnutls.c:
4273 * minibuf.c:
4274 * w32menu.c:
4275 * w32proc.c:
4276 * w32select.c: Don't include character.h.
4277
4278 * alloc.c (syms_of_alloc):
4279 * buffer.c (syms_of_buffer):
4280 * bytecode.c (syms_of_bytecode):
4281 * callint.c (syms_of_callint):
4282 * casefiddle.c (syms_of_casefiddle):
4283 * casetab.c (init_casetab_once):
4284 * category.c (init_category_once, syms_of_category):
4285 * ccl.c (syms_of_ccl):
4286 * cmds.c (syms_of_cmds):
4287 * composite.c (syms_of_composite):
4288 * dbusbind.c (syms_of_dbusbind):
4289 * dired.c (syms_of_dired):
4290 * dispnew.c (syms_of_display):
4291 * doc.c (syms_of_doc):
4292 * editfns.c (syms_of_editfns):
4293 * emacs.c (syms_of_emacs):
4294 * eval.c (syms_of_eval):
4295 * fileio.c (syms_of_fileio):
4296 * fns.c (syms_of_fns):
4297 * frame.c (syms_of_frame):
4298 * fringe.c (syms_of_fringe):
4299 * insdel.c (syms_of_insdel):
4300 * keymap.c (syms_of_keymap):
4301 * lread.c (init_obarray, syms_of_lread):
4302 * macros.c (syms_of_macros):
4303 * msdos.c (syms_of_msdos):
4304 * print.c (syms_of_print):
4305 * process.c (syms_of_process):
4306 * search.c (syms_of_search):
4307 * sound.c (syms_of_sound):
4308 * syntax.c (init_syntax_once, syms_of_syntax):
4309 * terminal.c (syms_of_terminal):
4310 * textprop.c (syms_of_textprop):
4311 * undo.c (syms_of_undo):
4312 * w32.c (globals_of_w32):
4313 * window.c (syms_of_window):
4314 * xdisp.c (syms_of_xdisp):
4315 * xfaces.c (syms_of_xfaces):
4316 * xfns.c (syms_of_xfns):
4317 * xmenu.c (syms_of_xmenu):
4318 * xsettings.c (syms_of_xsettings):
4319 * xterm.c (syms_of_xterm): Use DEFSYM.
4320
4228cf16
TZ
43212011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4322
cd3520a4 4323 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4324
7fcccf1e
PE
43252011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4326
7efb4e0e
PE
4327 Integer and buffer overflow fixes (Bug#8873).
4328
ff5844ad
PE
4329 * print.c (printchar, strout): Check for string overflow.
4330 (PRINTPREPARE, printchar, strout):
4331 Don't set size unless allocation succeeds.
4332
90532f02
PE
4333 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4334 for sizes. Check for string overflow more accurately.
4335 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4336
6d84508d
PE
4337 * macros.c: Integer and buffer overflow fixes.
4338 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4339 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4340 Use ptrdiff_t, not int, for sizes.
4341 Don't increment bufsize until after realloc succeeds.
4342 Check for size-calculation overflow.
4343 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4344
437b2cb4
PE
4345 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4346
8b9ac8b4
PE
4347 * lread.c: Integer overflow fixes.
4348 (read_integer): Radix is now EMACS_INT, not int,
4349 to improve quality of diagnostics for out-of-range radices.
4350 Calculate buffer size correctly for out-of-range radices.
4351 (read1): Check for integer overflow in radices, and in
4352 read-circle numbers.
82cb60d3
PE
4353 (read_escape): Avoid int overflow.
4354 (Fload, openp, read_buffer_size, read1)
4355 (substitute_object_recurse, read_vector, read_list, map_obarray):
4356 Use ptrdiff_t, not int, for sizes.
4357 (read1): Use EMACS_INT, not int, for sizes.
20270765 4358 Check for size overflow.
8b9ac8b4 4359
7fcccf1e
PE
4360 * image.c (cache_image): Check for size arithmetic overflow.
4361
bfbbd7e7
PE
4362 * lread.c: Integer overflow issues.
4363 (saved_doc_string_size, saved_doc_string_length)
4364 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4365 Now ptrdiff_t, not int.
4366 (read1): Don't assume doc string length fits in int. Check for
4367 out-of-range doc string lengths.
4368 (read_list): Don't assume file position fits in int.
39019e54 4369 (read_escape): Check for hex character overflow.
bfbbd7e7 4370
4e323265
LL
43712011-06-22 Leo Liu <sdl.web@gmail.com>
4372
4373 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4374 Move to minibuffer.el.
4375
85fece3e
PE
43762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4377
20b84ce9 4378 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4379 The following patches are for when GLYPH_DEBUG && !XASSERT.
4380 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4381 * dispnew.c (flush_stdout):
4382 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4383 Mark as externally visible.
4384 * dispnew.c (check_window_matrix_pointers): Now static.
4385 * dispnew.c (window_to_frame_vpos):
4386 * xfns.c (unwind_create_frame):
4387 * xterm.c (x_check_font): Remove unused local.
4388 * scroll.c (CHECK_BOUNDS):
4389 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4390 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4391 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4392 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4393 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4394 Now static.
4395 (debug_method_add): Use va_list and vsprintf rather than relying
4396 on undefined behavior with wrong number of arguments.
4397 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4398 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4399 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4400 since we're not interested in debugging glyphs with old libraries.
4401 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4402 GCC 4.6.0's static checking.
4403
0766b489
PE
44042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4405
31fd4b32
PE
4406 Integer overflow and signedness fixes (Bug#8873).
4407 A few related buffer overrun fixes, too.
4408
b79e8648
PE
4409 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4410
0766b489
PE
4411 * dispextern.h (struct face.stipple):
4412 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4413 (x_bitmap_mask, x_allocate_bitmap_record)
4414 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4415 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4416 (x_create_bitmap_from_xpm_data):
4417 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4418 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4419 (.bitmaps_last):
4420 * xfaces.c (load_pixmap):
4421 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4422 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4423 (.bitmaps_last, struct x_output.icon_bitmap):
4424 Use ptrdiff_t, not int, for bitmap indexes.
4425 (x_allocate_bitmap_record): Check for size overflow.
4426 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4427
b081724f
PE
4428 Use ptrdiff_t, not int, for overlay counts.
4429 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4430 * editfns.c (overlays_around, get_pos_property):
4431 * textprop.c (get_char_property_and_overlay):
4432 * xdisp.c (next_overlay_change, note_mouse_highlight):
4433 * xfaces.c (face_at_buffer_position):
21514da7
PE
4434 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4435 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4436 (Fnext_overlay_change, Fprevious_overlay_change)
4437 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4438 Use ptrdiff_t, not int, for sizes.
21514da7 4439 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4440
3de73e5e
PE
4441 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4442
2606c57b
PE
4443 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4444 (x_session_initialize): Do not assume string length fits in int.
4445
aaafe47a
PE
4446 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4447 This is unlikely, but can occur if DPI is outlandish.
4448
2674ddc8 4449 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4450 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4451
28154962
PE
4452 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4453 * xrdb.c (magic_file_p, search_magic_path):
4454 Omit last arg SUFFIX; it was always 0. All callers changed.
4455 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4456
7de51af5
PE
4457 * xfont.c (xfont_match): Avoid need for strlen.
4458
25ed6cc3
PE
4459 * xfns.c: Don't assume strlen fits in int.
4460 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4461
4eab31dd
PE
4462 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4463 not unsigned long, as we prefer signed integers. All callers changed.
4464 Detect integer overflow in repeat count.
4465 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4466 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4467
171e2a58
PE
4468 * termcap.c: Don't assume sizes fit in int and never overflow.
4469 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4470 (gobble_line): Check for size-calculation overflow.
4471
ad39faca 4472 * minibuf.c (Fread_buffer):
6e5bb2dc 4473 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4474 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4475 Don't assume string length fits in int.
4476
52c61c22 4477 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4478 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4479
b5b8c9e5
PE
4480 * font.c: Don't assume string length fits in int.
4481 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4482 Use ptrdiff_t, not int.
ccd6111c
PE
4483 (font_intern_prop): Don't assume string length fits in int.
4484 Don't assume integer property fits in fixnum.
4485 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4486
882f0d81 4487 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4488 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4489 Reformulate so as not to need the command string.
4490 Invoke gzip -cd rather than gunzip, as it's more portable.
4491 (lock_info_type, lock_file_1, lock_file):
4492 Don't assume pid_t and time_t fit in unsigned long.
4493 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4494 (current_lock_owner): Prefer signed type for sizes.
4495 Use memcpy, not strncpy, where memcpy is what is really wanted.
4496 Don't assume (via atoi) that time_t and pid_t fit in int.
4497 Check for time_t and/or pid_t out of range, e.g., via a network share.
4498 Don't alloca where an auto var works fine.
4499
93f4cf88
PE
4500 * fileio.c: Fix some integer overflow issues.
4501 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4502 Don't assume string length fits in int.
4503 (directory_file_name): Don't assume string length fits in long.
4504 (make_temp_name): Don't assume pid fits in int, or that its print
4505 length is less than 20.
4506
f3e92b69
PE
4507 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4508
1bfdaf10
PE
4509 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4510
35016e9a
PE
4511 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4512
3d1e65a1
PE
4513 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4514 We prefer signed integers, even for size calculations.
4515
0b963a93
PE
4516 * emacs.c: Don't assume string length fits in 'int'.
4517 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4518 (main): Don't invoke strlen when not needed.
4519
573f4b54
PE
4520 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4521 (XD_DEBUG_MESSAGE): Don't waste a byte.
4522
989f33ba
PE
4523 * callproc.c (getenv_internal_1, getenv_internal)
4524 (Fgetenv_internal):
965d34eb
PE
4525 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4526
e4d29b33
PE
4527 * lread.c (invalid_syntax): Omit length argument.
4528 All uses changed. This doesn't fix a bug, but it simplifies the
4529 code away from its former Hollerith-constant appearance, and it's
4530 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4531 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4532
eb49b136
PE
4533 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4534 This didn't break anything, but it didn't help either.
4535 It's confusing to put a bogus integer in a place where the actual
4536 value does not matter.
9f62aeb1 4537 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4538 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4539
15375a22
PE
4540 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4541 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4542 implementation.
b61cc01c
PE
4543 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4544 We prefer signed types, and the value cannot exceed the EMACS_INT
4545 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4546 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4547 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4548 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4549
53b2623d
PE
4550 * indent.c (sane_tab_width): New function.
4551 (current_column, scan_for_column, Findent_to, position_indentation)
4552 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4553 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4554
51cab52b 4555 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4556
f2ed8a70
PE
4557 * lisp.h (lint_assume): New macro.
4558 * composite.c (composition_gstring_put_cache):
4559 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4560
abe80cc6
PE
4561 * editfns.c, insdel.c:
4562 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4563
b02c740e
PE
4564 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4565
ebc96716
PE
4566 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4567
b4e50fa0 4568 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4569 Use much-faster test for byte-length change.
311d5d7c 4570 Don't assume string byte-length fits in 'int'.
a4cf38e4 4571 Check that character arg fits in 'int'.
85461888 4572 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4573
c0c1ee9f
PE
4574 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4575
a498d7f4
PE
4576 * fns.c (concat): Catch string overflow earlier.
4577 Do not rely on integer wraparound.
4578
51cab52b
PE
4579 * dispextern.h (struct it.overlay_strings_charpos)
4580 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4581 * xdisp.c (forward_to_next_line_start)
4582 (back_to_previous_visible_line_start)
4583 (reseat_at_next_visible_line_start, next_element_from_buffer):
4584 Don't arbitrarily truncate the value of 'selective' to int.
4585
76031fad
PE
4586 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4587
5eb55db9
PE
4588 * composite.c: Don't truncate sizes to 'int'.
4589 (composition_gstring_p, composition_reseat_it)
4590 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4591 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4592 not EMACS_UINT, for indexes.
5eb55db9 4593
0703a717
PE
4594 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4595
d6202519
PE
4596 * buffer.c: Include <verify.h>.
4597 (struct sortvec.priority, struct sortstr.priority):
8961a454 4598 Now EMACS_INT, not int.
c20998a7 4599 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4600 (struct sortstr.size, record_overlay_string)
4601 (struct sortstrlist.size, struct sortlist.used):
4602 Don't truncate size to int.
4603 (record_overlay_string): Check for size-calculation overflow.
d6202519 4604 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4605
d5a19415
JM
46062011-06-22 Jim Meyering <meyering@redhat.com>
4607
029529ac 4608 Don't leak an XBM-image-sized buffer
d5a19415
JM
4609 * image.c (xbm_load): Free the image buffer after using it.
4610
a9041e6c
PE
46112011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4612
4613 Port to Sun C.
4614 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4615 that Sun C diagnosed.
4616 * fns.c (secure_hash): Fix pointer signedness issue.
4617 * intervals.c (static_offset_intervals): New function.
4618 (offset_intervals): Use it.
4619
7f3f739f
LL
46202011-06-21 Leo Liu <sdl.web@gmail.com>
4621
4622 * deps.mk (fns.o):
4623 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4624 sha512.h.
4625
4626 * fns.c (secure_hash): Rename from crypto_hash_function and change
4627 the first arg to accept symbols.
5b66d427 4628 (Fsecure_hash): New primitive.
7f3f739f
LL
4629 (syms_of_fns): New symbols.
4630
76147d94
DD
46312011-06-20 Deniz Dogan <deniz@dogan.se>
4632
4633 * process.c (Fset_process_buffer): Clarify return value in
4634 docstring.
4635
7d7d0045
CY
46362011-06-18 Chong Yidong <cyd@stupidchicken.com>
4637
4638 * dispnew.c (add_window_display_history): Use BVAR.
4639
4640 * xdisp.c (debug_method_add): Use BVAR.
4641 (check_window_end, dump_glyph_matrix, dump_glyph)
4642 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4643
4644 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4645 Likewise.
4646
4647 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4648 check till after the cache is created in init_frame_faces.
4649
ff2bc410
SM
46502011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4651
4652 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4653
28177add
PE
46542011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4655
dd3482fe
PE
4656 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4657 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4658 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4659
393d71f3 4660 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4661 * fileio.c (Finsert_file_contents):
4662 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4663 Remove the old (too-loose) buffer overflow checks.
4664 They weren't needed, since make_gap checks for buffer overflow.
4665 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4666 The old code merely checked for Emacs fixnum overflow, and relied
4667 on undefined (wraparound) behavior. The new code avoids undefined
4668 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4669
2e6813b0 4670 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4671 Tune. Don't use wider integers than needed. Don't use alloca.
4672 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4673
599a9e4f
PE
4674 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4675
99561444
PE
4676 * insdel.c, lisp.h (buffer_overflow): New function.
4677 (insert_from_buffer_1, replace_range, replace_range_2):
4678 * insdel.c (make_gap_larger):
4679 * editfns.c (Finsert_char):
4680 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4681
28177add
PE
4682 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4683
e69dafad
PE
46842011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4685
4baa020d 4686 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4687
b1c46f02
PE
4688 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4689 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4690
e69dafad
PE
4691 * fileio.c: Don't assume EMACS_INT fits in off_t.
4692 (emacs_lseek): New static function.
4693 (Finsert_file_contents, Fwrite_region): Use it.
4694 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4695
566684ea
PE
4696 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4697
e6966cd6
PE
4698 * fns.c: Don't overflow int when computing a list length.
4699 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4700 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4701 truncation on 64-bit hosts. Check for QUIT every
4702 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4703 faster and is responsive enough.
4704 (Flength): Report an error instead of overflowing an integer.
4705 (Fsafe_length): Return a float if the value is not representable
4706 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4707 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4708 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4709
dd0b0efb
PE
4710 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4711 (header_size, word_size): New constants.
4712 (allocate_vectorlike): Don't check size overflow here.
4713 (allocate_vector): Check it here instead, since this is the only
4714 caller of allocate_vectorlike that could cause overflow.
4715 Check that the new vector's length is representable as a fixnum.
4716
86fe5cfe
PE
4717 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4718 The previous code was bogus. For example, next_almost_prime (32)
4719 returned 39, which is undesirable as it is a multiple of 3; and
4720 next_almost_prime (24) returned 25, which is a multiple of 5 so
4721 why was the code bothering to check for multiples of 7?
4722
80e88859
PE
4723 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4724
4a2f0ad6
PE
4725 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4726
f66c7cf8
PE
4727 Variadic C functions now count arguments with ptrdiff_t.
4728 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4729 Back then I didn't know that the Emacs coding style prefers signed int.
4730 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4731 were being counted with int, which may truncate counts on 64-bit
4732 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4733 * lisp.h (struct Lisp_Subr.function.aMANY)
4734 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4735 Arg counts are now ptrdiff_t, not size_t.
4736 All variadic functions and their callers changed accordingly.
4737 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4738 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4739 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4740 * callint.c (Fcall_interactively): Check arg count for overflow,
4741 to avoid potential buffer overrun. Use signed char, not 'int',
4742 for 'varies' array, so that we needn't bother to check its size
4743 calculation for overflow.
4744 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4745 * eval.c (apply_lambda):
4746 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4747 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4748 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4749
a1759b76
PE
4750 * callint.c (Fcall_interactively): Don't use index var as event count.
4751
d96be9fc
PE
4752 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4753 * mem-limits.h (SIZE): Remove; no longer used.
4754
a690a978 4755 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4756
578c21e6
PE
4757 Remove unnecessary casts.
4758 * xterm.c (x_term_init):
4759 * xfns.c (x_set_border_pixel):
4760 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4761 These aren't needed now that we assume ANSI C.
4762
96f53c6c
PE
4763 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4764 It's more likely to cause problems (due to unsigned overflow)
4765 than to cure them.
4766
83c77d31
PE
4767 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4768
ee2079f1
PE
4769 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4770
6da65536
PE
4771 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4772
7147c4a4
PE
4773 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4774
193e32d9
PE
4775 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4776
e5533da6
PE
4777 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4778
9910e595
PE
4779 GLYPH_CODE_FACE returns EMACS_INT, not int.
4780 * dispextern.h (merge_faces):
4781 * xfaces.c (merge_faces):
01103c44
PE
4782 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4783 Don't assume EMACS_INT fits in int.
9910e595 4784
2638320e
PE
4785 * character.h (CHAR_VALID_P): Remove unused parameter.
4786 * fontset.c, lisp.h, xdisp.c: All uses changed.
4787
045eb8d9
PE
4788 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4789
c1f134b5
PE
4790 * fns.c (concat): Minor tuning based on overflow analysis.
4791 This doesn't fix any bugs. Use int to hold character, instead
4792 of constantly refetching from Emacs object. Use XFASTINT, not
4793 XINT, for value known to be a character. Don't bother comparing
4794 a single byte to 0400, as it's always less.
4795
395fcb93 4796 * floatfns.c (Fexpt):
327eeec8
PE
4797 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4798
abbd3d23
PE
4799 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4800 for characters.
4801
684a03ef
PE
4802 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4803
0fed43f3
PE
4804 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4805 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4806 incorrectly succeed when S was a string, because 4294967386 was
4807 truncated before it was used.
4808
8fd02eb7
PE
4809 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4810 Otherwise, an out-of-range integer could cause undefined behavior
4811 on a 64-bit host.
4812
f8c86b69
PE
4813 * composite.c: Use int, not EMACS_INT, for characters.
4814 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4815 EMACS_INT, for values that are known to be in character range.
4816 This doesn't fix any bugs but is the usual style inside Emacs and
4817 may generate better code on 32-bit machines.
4818
34206dd2
PE
4819 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4820 This is for reasons similar to the recent CHAR_STRING fix.
4821 * charset.c (Fencode_char): Check that character arg is actually
4822 a character. Pass an int to ENCODE_CHAR.
4823 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4824 wider than 'int', as a compile-time check to prevent future regressions
4825 in this area.
4826
c5958d4c 4827 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4828
4829 Make sure a 64-bit char is never passed to CHAR_STRING.
4830 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4831 by silently ignoring the top 32 bits, allowing some values
4832 that were far too large to be valid characters.
4833 * character.h: Include <verify.h>.
4834 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4835 arguments are no wider than unsigned, as a compile-time check
4836 to prevent future regressions in this area.
4837 * data.c (Faset):
01103c44 4838 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4839 (Fsubst_char_in_region):
4840 * fns.c (concat):
4841 * xdisp.c (decode_mode_spec_coding):
4842 Adjust to CHAR_STRING's new requirement.
4843 * editfns.c (Finsert_char, Fsubst_char_in_region):
4844 * fns.c (concat): Check that character args are actually
4845 characters. Without this test, these functions did the wrong
4846 thing with wildly out-of-range values on 64-bit hosts.
4847
d37ca623
PE
4848 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4849 These casts should not be needed on 32-bit hosts, either.
4850 * keyboard.c (read_char):
4851 * lread.c (Fload): Remove casts to unsigned.
4852
ea204efb
PE
4853 * lisp.h (UNSIGNED_CMP): New macro.
4854 This fixes comparison bugs on 64-bit hosts.
4855 (ASCII_CHAR_P): Use it.
4856 * casefiddle.c (casify_object):
01103c44 4857 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4858 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4859 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4860 * dispextern.h (FACE_FROM_ID):
4861 * keyboard.c (read_char): Use UNSIGNED_CMP.
4862
41cb286c
PE
4863 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4864 not to EMACS_INT, to avoid GCC warning.
4865
4a1b9832
PE
4866 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4867
55daad71
PE
4868 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4869 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4870 isn't needed on 32-bit machines.
8f95c75c 4871
01103c44
PE
4872 * buffer.c (Fgenerate_new_buffer_name):
4873 Use EMACS_INT for count, not int.
0ceccced 4874 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4875
4876 * data.c (Qcompiled_function): Now static.
4877
c6f072e7
PE
4878 * window.c (window_body_lines): Now static.
4879
20ce5912
PE
4880 * image.c (gif_load): Rename local to avoid shadowing.
4881
9c4c5f81
PE
4882 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4883 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4884 * alloc.c (make_save_value): Integer argument is now of type
4885 ptrdiff_t, not int.
4886 (mark_object): Use ptrdiff_t, not int.
4887 * lisp.h (pD): New macro.
4888 * print.c (print_object): Use it.
4889
c0c5c8ae
PE
4890 * alloc.c: Use EMACS_INT, not int, to count objects.
4891 (total_conses, total_markers, total_symbols, total_vector_size)
4892 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4893 (total_free_floats, total_floats, total_free_intervals)
4894 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4895 Now EMACS_INT, not int. All uses changed.
4896 (Fgarbage_collect): Compute overall total using a double, so that
4897 integer overflow is less likely to be a problem. Check for overflow
4898 when converting back to an integer.
5a25e253
PE
4899 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4900 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4901 These were 'int' variables that could overflow on 64-bit hosts;
4902 they were never used, so remove them instead of repairing them.
211a0b2a 4903 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4904 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4905 Previously, this ceilinged at INT_MAX, but that doesn't work on
4906 64-bit machines.
e46bb31a 4907 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4908
c78baabf 4909 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4910 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4911 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4912 when a (possibly-narrower) signed value would do just as well.
4913 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4914
c9d624c6
PE
4915 * alloc.c: Catch some string size overflows that we were missing.
4916 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4917 for convenience in STRING_BYTES_MAX.
4918 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4919 The definition here is exact; the one in lisp.h was approximate.
4920 (allocate_string_data): Check for string overflow. This catches
4921 some instances we weren't catching before. Also, it catches
4922 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4923 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4924 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4925
c9d624c6
PE
4926 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4927 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4928 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4929
353032ce
PE
4930 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4931
2bccce07
PE
4932 * alloc.c (Fmake_string): Check for out-of-range init.
4933
0ac30604
SM
49342011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4935
4936 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4937
c195f2de
JD
49382011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4939
4940 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4941 xg_get_default_scrollbar_width.
4942
4943 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4944 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4945 (style_changed_cb): Call update_theme_scrollbar_width and call
4946 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4947 all frames (Bug#8505).
4948 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4949 Call gtk_window_set_resizable if HAVE_GTK3.
4950 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4951 and height if HAVE_GTK3 (Bug#8505).
4952 (scroll_bar_width_for_theme): New variable.
4953 (update_theme_scrollbar_width): New function.
4954 (xg_get_default_scrollbar_width): Move code to
4955 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4956 (xg_initialize): Call update_theme_scrollbar_width.
4957
4958 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4959
4960 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4961
e10ac9f1
MR
49622011-06-12 Martin Rudalics <rudalics@gmx.at>
4963
4964 * frame.c (make_frame): Call other_buffer_safely instead of
4965 other_buffer.
4966
4967 * window.c (temp_output_buffer_show): Call display_buffer with
4968 second argument Vtemp_buffer_show_specifiers and reset latter
4969 immediately after the call.
4970 (Vtemp_buffer_show_specifiers): New variable.
4971 (auto_window_vscroll_p, next_screen_context_lines)
4972 (Vscroll_preserve_screen_position): Remove leading asterisks from
4973 doc-strings.
4974
2d3c217e 49752011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4976
7b7f97e8 4977 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4978 * buffer.c (Qclone_number): Remove for now, as it's unused.
4979 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4980 (record_buffer): Remove unused local.
4981 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4982 (set_frame_buffer_list): Remove; unused.
4983 * frame.h (other_visible_frames): Remove decl.
4984 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4985 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4986 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4987 if HAVE_GPM.
4988 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4989 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4990 Define only if HAVE_GPM.
4991 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4992 (update_hints_inhibit): Remove; never set. All uses removed.
4993 * widgetprv.h (emacsFrameClassRec): Remove decl.
4994 * window.c (delete_deletable_window): Now returns void, since it
4995 wasn't returning anything.
4996 (compare_window_configurations): Remove unused locals.
4997 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4998 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4999 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5000 the same widths as pointers. This follows up on the 2011-05-06 patch.
5001 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5002 * xterm.h: Likewise.
5003 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5004
1384b89e
JB
50052011-06-12 Juanma Barranquero <lekktu@gmail.com>
5006
5007 * makefile.w32-in: Update dependencies.
5008 (LISP_H): Add lib/intprops.h.
5009
1100a63c
CY
50102011-06-11 Chong Yidong <cyd@stupidchicken.com>
5011
5012 * image.c (gif_load): Add animation frame delay to the metadata.
5013 (syms_of_image): Use DEFSYM. New symbol `delay'.
5014
6198ccd0
MR
50152011-06-11 Martin Rudalics <rudalics@gmx.at>
5016
5017 * window.c (delete_deletable_window): Re-add.
5018 (Fset_window_configuration): Rewrite to handle dead buffers and
5019 consequently deletable windows.
5020 (window_tree, Fwindow_tree): Remove. Supply functionality in
5021 window.el.
5022 (compare_window_configurations): Simplify code.
5023
b6e3633c
AS
50242011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5025
1ab0dee5
AS
5026 * image.c (imagemagick_load_image): Fix type mismatch.
5027 (Fimagemagick_types): Likewise.
5028
b6e3633c
AS
5029 * window.h (replace_buffer_in_windows): Declare.
5030
9397e56f
MR
50312011-06-11 Martin Rudalics <rudalics@gmx.at>
5032
5033 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5034 Qclone_number. Remove external declaration of Qdelete_window.
5035 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5036 code.
640c8776
SM
5037 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5038 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5039 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5040 buffer list implementation.
5041 (other_buffer_safely): New function.
5042 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5043 calls to replace_buffer_in_windows and
5044 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5045 if allowed.
5046 (record_buffer): Inhibit quitting and rewrite using quittable
5047 functions. Run Qbuffer_list_update_hook if allowed.
5048 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5049 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5050 Move switch-to-buffer to window.el.
9397e56f
MR
5051 (bury-buffer): Move to window.el.
5052 (Vbuffer_list_update_hook): New variable.
5053
5054 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5055 section.
5056
5057 * window.h (resize_frame_windows): Move up in code.
5058 (Fwindow_frame): Remove EXFUN.
5059 (replace_buffer_in_all_windows): Remove prototype.
5060 (replace_buffer_in_windows_safely): Add prototype.
5061
5062 * window.c: Declare Qdelete_window static again. Move down
5063 declaration of select_count.
5064 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5065 (Fother_window): Move to window.el.
5066 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5067 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5068 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5069 window.el.
5070 (replace_buffer_in_windows): Implement by calling
5071 Qreplace_buffer_in_windows.
5072 (replace_buffer_in_all_windows): Remove with some functionality
5073 moved into replace_buffer_in_windows_safely.
5074 (replace_buffer_in_windows_safely): New function.
5075 (select_window_norecord, select_frame_norecord): Move in front
5076 of run_window_configuration_change_hook. Remove now obsolete
5077 declarations.
640c8776
SM
5078 (Fset_window_buffer): Rewrite doc-string.
5079 Call Qrecord_window_buffer.
9397e56f
MR
5080 (keys_of_window): Move binding for other-window to window.el.
5081
b50691aa
CY
50822011-06-11 Chong Yidong <cyd@stupidchicken.com>
5083
5084 * dispextern.h (struct image): Replace data member, whose int_val
5085 and ptr_val fields were not used by anything, with a single
5086 lisp_val object.
5087
5088 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5089 (gif_clear_image, gif_load, imagemagick_load_image)
5090 (gs_clear_image, gs_load): Callers changed.
5091
3f754b86
PE
50922011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5093
cca69397
PE
5094 * buffer.h: Include <time.h>, for time_t.
5095 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5096
109e28d0
PE
5097 Fix minor problems found by static checking.
5098
60737f02
PE
5099 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5100
4b66faf3
PE
5101 Make identifiers static if they are not used in other modules.
5102 * data.c (Qcompiled_function, Qframe, Qvector):
5103 * image.c (QimageMagick, Qsvg):
5104 * minibuf.c (Qmetadata):
5105 * window.c (resize_window_check, resize_root_window): Now static.
5106 * window.h (resize_window_check, resize_root_window): Remove decls.
5107
109e28d0
PE
5108 * window.c (window_deletion_count, delete_deletable_window):
5109 Remove; unused.
46a4ce9e
PE
5110 (window_body_lines): Now static.
5111 (Fdelete_other_windows_internal): Mark vars as initialized.
5112 Make sure 'resize_failed' is initialized.
5113 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5114 (resize_window_apply): Remove unused local.
5115 * window.h (delete_deletable_window): Remove decl.
5116
109e28d0 5117 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5118 (imagemagick_load_image): Fix pointer signedness problem by changing
5119 last arg from unsigned char * to char *. All uses changed.
5120 Also, fix a local for similar reasons.
5121 Remove unused locals. Remove locals to avoid shadowing.
5122 (fn_rsvg_handle_free): Remove; unused.
5123 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5124 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5125
3f754b86
PE
5126 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5127
2547adb1
CY
51282011-06-10 Chong Yidong <cyd@stupidchicken.com>
5129
5130 * image.c (gif_load): Fix omitted cast error introduced by
5131 2011-06-06 change.
5132
2c8e37d4
MR
51332011-06-10 Martin Rudalics <rudalics@gmx.at>
5134
5135 * window.h (resize_proportionally, orig_total_lines)
5136 (orig_top_line): Remove from window structure.
5137 (set_window_height, set_window_width, change_window_heights)
5138 (Fdelete_window): Remove prototypes.
5139 (resize_frame_windows): Remove duplicate declaration.
5140
440a42e3
EZ
51412011-06-10 Eli Zaretskii <eliz@gnu.org>
5142
5143 * window.h (resize_frame_windows, resize_window_check)
5144 (delete_deletable_window, resize_root_window)
5145 (resize_frame_windows): Declare prototypes.
5146
5147 * window.c (resize_window_apply): Make definition be "static" to
5148 match the prototype.
5149
562dd5e9
MR
51502011-06-10 Martin Rudalics <rudalics@gmx.at>
5151
5152 * window.c: Remove declarations of Qwindow_size_fixed,
5153 window_min_size_1, window_min_size_2, window_min_size,
5154 size_window, window_fixed_size_p, enlarge_window, delete_window.
5155 Remove static from declaration of Qdelete_window, it's
5156 temporarily needed by Fbury_buffer.
5157 (replace_window): Don't assign orig_top_line and
5158 orig_total_lines.
5159 (Fdelete_window, delete_window): Remove. Window deletion is
5160 handled by window.el.
640c8776
SM
5161 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5162 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5163 (Fdelete_other_windows): Remove. Deleting other windows is
5164 handled by window.el.
5165 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5166 handled in window.el.
5167 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5168 Window minimum sizes are handled in window.el.
5169 (shrink_windows, size_window, set_window_height)
5170 (set_window_width, change_window_heights, window_height)
5171 (window_width, CURBEG, CURSIZE, enlarge_window)
5172 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5173 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5174 handled in window.el.
5175 (make_dummy_parent): Rename to make_parent_window and give it a
5176 second argument horflag.
5177 (make_window): Don't set resize_proportionally any more.
5178 (Fsplit_window): Remove. Windows are split in window.el.
5179 (save_restore_action, save_restore_orig_size)
5180 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5181 Resize mini windows in window.el.
5182 (grow_mini_window, shrink_mini_window): Implement by calling
5183 Qresize_root_window_vertically, resize_window_check and
5184 resize_window_apply.
640c8776
SM
5185 (saved_window, Fset_window_configuration, save_window_save):
5186 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5187 resize_proportionally.
5188 (window_min_height, window_min_width): Move to window.el.
5189 (keys_of_window): Move bindings for delete-other-windows,
5190 split-window, delete-window and enlarge-window to window.el.
5191
5192 * buffer.c: Temporarily extern Qdelete_window.
5193 (Fbury_buffer): Temporarily call Qdelete_window instead of
5194 Fdelete_window (Fbury_buffer will move to window.el soon).
5195
5196 * frame.c (set_menu_bar_lines_1): Remove code handling
5197 orig_top_line and orig_total_lines.
5198
5199 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5200 set_window_height but set heights directly.
5201 (change_frame_size_1): Use resize_frame_windows.
5202
5203 * xdisp.c (init_xdisp): Don't use set_window_height but set
5204 heights directly.
5205
640c8776
SM
5206 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5207 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5208 run_window_configuration_change_hook.
5209
5210 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5211 instead of change_window_heights and run
5212 run_window_configuration_change_hook.
5213
1a13852e
MR
52142011-06-09 Martin Rudalics <rudalics@gmx.at>
5215
5216 * window.c (replace_window): Rename second argument REPLACEMENT to
5217 NEW. New third argument SETFLAG. Rewrite.
5218 (delete_window, make_dummy_parent): Call replace_window with
5219 third argument 1.
5220 (window_list_1): Move down in code.
5221 (run_window_configuration_change_hook): Move set_buffer part
5222 before select_frame_norecord part in order to unwind correctly.
5223 Rename count1 to count.
5224 (recombine_windows, delete_deletable_window, resize_root_window)
5225 (Fdelete_other_windows_internal)
5226 (Frun_window_configuration_change_hook, make_parent_window)
5227 (resize_window_check, resize_window_apply, Fresize_window_apply)
5228 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5229 (Fdelete_window_internal, Fresize_mini_window_internal):
5230 New functions.
1a13852e
MR
5231 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5232
f3d1777e
MR
52332011-06-08 Martin Rudalics <rudalics@gmx.at>
5234
496e208e
MR
5235 * window.h (window): Add some new members to window structure -
5236 normal_lines, normal_cols, new_total, new_normal, clone_number,
5237 splits, nest, prev_buffers, next_buffers.
5238 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5239 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5240
f3d1777e
MR
5241 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5242 Remove.
496e208e
MR
5243 (make_dummy_parent): Set new members of windows structure.
5244 (make_window): Move down in code. Handle new members of window
5245 structure.
5246 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5247 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5248 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5249 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5250 (Fset_window_next_buffers, Fset_window_clone_number):
5251 New functions.
496e208e
MR
5252 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5253 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5254 Doc-string fixes.
5255 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5256 Argument WINDOW can be now internal window too.
5257 (Fwindow_use_time): Move up in code.
5258 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5259 Rewrite doc-string.
5260 (Fset_window_configuration, saved_window)
5261 (Fcurrent_window_configuration, save_window_save): Handle new
5262 members of window structure.
b9e809c2
MR
5263 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5264 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5265 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5266 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5267 Qget_mru_window, Qresize_root_window,
5268 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5269 Qauto_buffer_name; staticpro them.
f3d1777e 5270
abde8f8c
MR
52712011-06-07 Martin Rudalics <rudalics@gmx.at>
5272
5273 * window.c (Fwindow_total_size, Fwindow_left_column)
5274 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5275 (Fwindow_list_1): New functions.
5276 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5277 (Fwindow_width, Fscroll_left, Fscroll_right):
5278 Use window_body_cols instead of window_box_text_cols.
5279 (delete_window, Fset_window_configuration):
5280 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5281 (delete_all_subwindows): Take a window as argument and not a
5282 structure. Rewrite.
190b47e6
MR
5283 (window_loop): Remove handling of GET_LRU_WINDOW and
5284 GET_LARGEST_WINDOW.
5285 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5286
5287 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5288 window_box_text_cols. delete_all_subwindows now takes a
5289 Lisp_Object as argument.
abde8f8c 5290
640c8776
SM
5291 * indent.c (compute_motion, Fcompute_motion):
5292 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5293
fa8a67e6
MR
5294 * frame.c (delete_frame): Call delete_all_subwindows with root
5295 window as argument.
5296
a54e3482
DC
52972011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5298
5299 * fns.c (Fputhash): Document return value.
5300
60002bf5
CY
53012011-06-06 Chong Yidong <cyd@stupidchicken.com>
5302
5303 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5304
0c671da6 53052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5306
b862a52a 5307 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5308
be44ca6c
PE
5309 Check for overflow when converting integer to cons and back.
5310 * charset.c (Fdefine_charset_internal, Fdecode_char):
5311 Use cons_to_unsigned to catch overflow.
5312 (Fencode_char): Use INTEGER_TO_CONS.
5313 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5314 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5315 * data.c (long_to_cons, cons_to_long): Remove.
5316 (cons_to_unsigned, cons_to_signed): New functions.
5317 These signal an error for invalid or out-of-range values.
5318 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5319 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5320 * font.c (Ffont_variation_glyphs):
5321 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5322 * lisp.h: Include <intprops.h>.
5323 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5324 (cons_to_signed, cons_to_unsigned): New decls.
5325 (long_to_cons, cons_to_long): Remove decls.
5326 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5327 (Fprimitive_undo): Use CONS_TO_INTEGER.
5328 * xfns.c (Fx_window_property): Likewise.
5329 * xselect.c: Include <limits.h>.
5330 (x_own_selection, selection_data_to_lisp_data):
5331 Use INTEGER_TO_CONS.
5332 (x_handle_selection_request, x_handle_selection_clear)
5333 (x_get_foreign_selection, Fx_disown_selection_internal)
5334 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5335 (lisp_data_to_selection_data): Use cons_to_unsigned.
5336 (x_fill_property_data): Use cons_to_signed.
5337 Report values out of range.
5338
d1f3d2af
PE
5339 Check for buffer and string overflow more precisely.
5340 * buffer.h (BUF_BYTES_MAX): New macro.
5341 * lisp.h (STRING_BYTES_MAX): New macro.
5342 * alloc.c (Fmake_string):
5343 * character.c (string_escape_byte8):
5344 * coding.c (coding_alloc_by_realloc):
5345 * doprnt.c (doprnt):
5346 * editfns.c (Fformat):
5347 * eval.c (verror):
5348 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5349 since they may not be the same number.
5350 * editfns.c (Finsert_char):
5351 * fileio.c (Finsert_file_contents):
5352 Likewise for BUF_BYTES_MAX.
5353
dd52fcea
PE
5354 * image.c: Use ptrdiff_t, not int, for sizes.
5355 (slurp_file): Switch from int to ptrdiff_t.
5356 All uses changed.
5357 (slurp_file): Check that file size fits in both size_t (for
5358 malloc) and ptrdiff_t (for sanity and safety).
5359
7f9bbdbb
PE
5360 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5361 if b->modtime has its maximal value.
5362
dfe18f82
PE
5363 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5364
84acfcf0
PE
5365 Don't assume time_t can fit into int.
5366 * buffer.h (struct buffer.modtime): Now time_t, not int.
5367 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5368 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5369
ccd9a01a
PE
5370 Minor fixes for signed vs unsigned integers.
5371 * character.h (MAYBE_UNIFY_CHAR):
5372 * charset.c (maybe_unify_char):
5373 * keyboard.c (read_char, reorder_modifiers):
5374 XINT -> XFASTINT, since the integer must be nonnegative.
5375 * ftfont.c (ftfont_spec_pattern):
5376 * keymap.c (access_keymap, silly_event_symbol_error):
5377 XUINT -> XFASTINT, since the integer must be nonnegative.
5378 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5379 since it makes no difference and we prefer signed.
5380 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5381 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5382 nonnegative.
5383
d6d100dd
SM
53842011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5385
5386 * window.h (Fwindow_frame): Declare.
5387
2b6148e4
PE
53882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5389
5390 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5391 (SPARE_MEMORY): Always define.
5392 (LARGE_REQUEST): Remove.
5393 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5394
f230ecc9
MR
53952011-06-06 Martin Rudalics <rudalics@gmx.at>
5396
727e958e
MR
5397 * lisp.h: Move EXFUNS for Fframe_root_window,
5398 Fframe_first_window and Fset_frame_selected_window to window.h.
5399
5400 * window.h: Move EXFUNS for Fframe_root_window,
5401 Fframe_first_window and Fset_frame_selected_window here from
5402 lisp.h.
5403
5404 * frame.c (Fwindow_frame, Fframe_first_window)
5405 (Fframe_root_window, Fframe_selected_window)
5406 (Fset_frame_selected_window): Move to window.c.
5407 (Factive_minibuffer_window): Move to minibuf.c.
5408 (Fother_visible_frames_p): New function.
5409
5410 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5411
f230ecc9
MR
5412 * window.c (decode_window, decode_any_window): Move up in code.
5413 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5414 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5415 (Fwindow_buffer): Move up and rewrite doc-string.
5416 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5417 (Fwindow_prev): New functions.
727e958e
MR
5418 (Fwindow_frame): Move here from frame.c. Accept any window as
5419 argument.
5420 (Fframe_root_window, Fframe_first_window)
5421 (Fframe_selected_window): Move here from frame.c. Accept frame
5422 or arbitrary window as argument. Update doc-strings.
5423 (Fminibuffer_window): Move up in code.
5424 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5425 (Fset_frame_selected_window): Move here from frame.c.
5426 Marginal rewrite.
727e958e
MR
5427 (Fselected_window, select_window, Fselect_window): Move up in
5428 code. Minor doc-string fixes.
f230ecc9 5429
4d09bcf6
PE
54302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5431
5432 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5433 Do not assume that spare memory exists; that assumption is valid
5434 only if SYSTEM_MALLOC.
5435 (LARGE_REQUEST): New macro, so that the issue of large requests
5436 is separated from the issue of spare memory.
5437
810928a2
AS
54382011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5439
172418ad
AS
5440 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5441 format. (Bug#8806)
5442
43f862f7
AS
5443 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5444
810928a2
AS
5445 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5446 before statements.
5447
a059fe24
JD
54482011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5449
5450 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5451
5452 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5453
5454 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5455 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5456
989bf368
JB
54572011-06-05 Juanma Barranquero <lekktu@gmail.com>
5458
5459 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5460
4b80f674
CY
54612011-06-04 Chong Yidong <cyd@stupidchicken.com>
5462
5463 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5464 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5465 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5466 New error handlers.
4b80f674
CY
5467 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5468 Obey Vx_select_enable_clipboard_manager. Catch errors in
5469 x_clipboard_manager_save (Bug#8779).
5470 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5471 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5472
99a33b77 54732011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5474
5475 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5476
99a33b77 54772011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5478
5479 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5480 in the current matrix if keep_current_p is non-zero.
5481
8264569d
EZ
54822011-06-04 Eli Zaretskii <eliz@gnu.org>
5483
5484 * bidi.c (bidi_level_of_next_char): Fix last change.
5485
57f97249
EZ
54862011-06-03 Eli Zaretskii <eliz@gnu.org>
5487
fec2107c 5488 Support bidi reordering of text covered by display properties.
57f97249 5489
fec2107c
EZ
5490 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5491 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5492 (bidi_cache_search, bidi_cache_iterator_state)
5493 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5494 (bidi_level_of_next_char, bidi_move_to_visually_next):
5495 Support character positions inside a run of characters covered by a
fec2107c
EZ
5496 display string.
5497 (bidi_paragraph_init, bidi_resolve_explicit_1)
5498 (bidi_level_of_next_char): Call bidi_fetch_char and
5499 bidi_fetch_char_advance instead of FETCH_CHAR and
5500 FETCH_CHAR_ADVANCE.
5501 (bidi_init_it): Initialize new members.
5502 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5503 definitions.
5504 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5505 instead of using explicit *_CHAR codes.
d6d100dd
SM
5506 (bidi_resolve_explicit, bidi_resolve_weak):
5507 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5508 bidirectional text is supported only in multibyte buffers.
5509 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5510 it to initialize the frame_window_p member of struct bidi_it.
5511 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5512 (bidi_resolve_explicit, bidi_resolve_weak)
5513 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5514 bidi_it->nchars is non-positive.
5515 (bidi_level_of_next_char): Don't try to lookup the cache for the
5516 next/previous character if nothing is cached there yet, or if we
5517 were just reseat()'ed to a new position.
c40e2fb2 5518
0e14fe90
EZ
5519 * xdisp.c (set_cursor_from_row): Set start and stop points
5520 according to the row's direction when priming the loop that looks
5521 for the glyph on which to display cursor.
5522 (single_display_spec_intangible_p): Function deleted.
5523 (display_prop_intangible_p): Reimplement to call
5524 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5525 Accept 3 additional arguments needed by handle_display_spec.
5526 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5527 values: lists, `(when COND...)' forms, etc.
5528 (single_display_spec_string_p): Support property values that are
5529 lists with the argument STRING its top-level element.
5530 (display_prop_string_p): Fix the condition for processing a
5531 property that is a list to be consistent with handle_display_spec.
fec2107c 5532 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5533 last portion of handle_display_prop.
5534 (compute_display_string_pos): Accept additional argument
5535 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5536 value of a `display' property is a "replacing spec".
5537 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5538 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5539 the display property, but just return a value indicating whether
5540 the display property will replace the characters it covers.
5541 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5542 frame_window_p members of struct bidi_it.
d6d100dd
SM
5543 (compute_display_string_pos, compute_display_string_end):
5544 New functions.
fec2107c
EZ
5545 (push_it): Accept second argument POSITION, where pop_it should
5546 jump to continue iteration.
5547 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5548
fec2107c
EZ
5549 * keyboard.c (adjust_point_for_property): Adjust the call to
5550 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5551
5552 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5553 (bidi_init_it): Update prototypes.
5554 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5555 (compute_display_string_pos, compute_display_string_end):
5556 Declare prototypes.
fec2107c
EZ
5557 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5558 EMACS_INT.
fc6f18ce 5559
40087514 55602011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5561
57f53182
PE
5562 Malloc failure behavior now depends on size of allocation.
5563 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5564 * lisp.h: Change signatures accordingly.
5565 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5566 All callers changed. (Bug#8762)
5567
5568 * gnutls.c: Use Emacs's memory allocators.
5569 Without this change, the gnutls library would invoke malloc etc.
5570 directly, which causes problems on non-SYNC_INPUT hosts, and which
5571 runs afoul of improving memory_full behavior. (Bug#8761)
5572 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5573 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5574 xfree instead of the default malloc, realloc, free.
5575 (Fgnutls_boot): No need to check for memory allocation failure,
5576 since xmalloc does that for us.
5577
ac32cd99 5578 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5579 * category.c (hash_get_category_set):
5580 * ccl.c (ccl_driver):
5581 * charset.c (Fdefine_charset_internal):
5582 * charset.h (struct charset.hash_index):
5583 * composite.c (get_composition_id, gstring_lookup_cache)
5584 (composition_gstring_put_cache):
5585 * composite.h (struct composition.hash_index):
5586 * dispextern.h (struct image.hash):
5587 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5588 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5589 (hashfn_equal, hashfn_user_defined, make_hash_table)
5590 (maybe_resize_hash_table, hash_lookup, hash_put)
5591 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5592 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5593 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5594 * image.c (make_image, search_image_cache, lookup_image)
5595 (xpm_put_color_table_h):
5596 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5597 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5598 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5599 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5600 * alloc.c (allocate_vectorlike):
5601 Check for overflow in vector size calculations.
5602 * ccl.c (ccl_driver):
5603 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5604 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5605 need to be updated by these changes.
40087514
PE
5606 * fns.c (make_hash_table, maybe_resize_hash_table):
5607 Check for integer overflow with large hash tables.
0de4bb68
PE
5608 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5609 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5610 (SXHASH_REDUCE): New macro.
5611 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5612 Use it instead of discarding useful hash info with large hash values.
5613 (sxhash_float): New function.
5614 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5615 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5616 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5617 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5618 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5619 Adjust signatures to match updated version of code.
5620 (consing_since_gc): Now EMACS_INT, since a single hash table can
5621 use more than INT_MAX bytes.
5622
698d32e2
DN
56232011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5624
5625 Make it possible to build with GCC-4.6+ -O2 -flto.
5626
5627 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5628
fd6fa53f
SM
56292011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5630
5631 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5632 Call minibuffer-inactive-mode.
5633
864db017
JB
56342011-05-31 Juanma Barranquero <lekktu@gmail.com>
5635
5636 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5637 Update dependencies.
5638
2ad0baf4
DN
56392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5640
5641 * data.c (init_data): Remove code for UTS, this system is not
5642 supported anymore.
5643
4fcc2638
DN
56442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5645
5646 Don't force ./temacs to start in terminal mode.
5647
5648 * frame.c (make_initial_frame): Initialize faces in all cases, not
5649 only when CANNOT_DUMP is defined.
5650 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5651
c56e0fd5
DN
56522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5653
5654 * dispnew.c (add_window_display_history): Use const for the string
5655 pointer. Remove declaration, not needed.
5656
333d54da 56572011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5658
55d4c1b2 5659 Use 'inline', not 'INLINE'.
333d54da 5660 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5661 * alloc.c, fontset.c (INLINE): Remove.
5662 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5663 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5664 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5665 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5666 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5667
738db178
DN
56682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5669
5670 Make it possible to run ./temacs.
5671
5672 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5673 syms_of_callproc does the same thing. Remove test for
5674 "initialized", do it in the caller.
5675 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5676
620c53a6
SM
56772011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5678
5679 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5680 (read_minibuf): Use get_minibuffer.
5681 (syms_of_minibuf): Use DEFSYM.
5682 (Qmetadata): New var.
5683 * data.c (Qbuffer): Don't make it static.
5684 (syms_of_data): Use DEFSYM.
5685
e003a292
PE
56862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5687
5688 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5689 (CCL_CODE_MIN): New macro.
5690
ed008a6d
PE
56912011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5692
3687c2ef
PE
5693 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5694
ed008a6d
PE
5695 * eval.c (Qdebug): Now static.
5696 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5697 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5698 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5699
d66c4c7c
CY
57002011-05-29 Chong Yidong <cyd@stupidchicken.com>
5701
5702 * image.c: Various fixes to ImageMagick code comments.
5703 (Fimagemagick_types): Doc fix.
5704
5fbc2025
PE
57052011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5706
0196f88a
PE
5707 Minor fixes prompted by GCC 4.6.0 warnings.
5708
5709 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5710
5fbc2025
PE
5711 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5712 (x_clipboard_manager_save_all): Move extern decl to ...
5713 * xterm.h: ... here, so that it can be checked for consistency.
5714
1dd3c2d9
CY
57152011-05-29 Chong Yidong <cyd@stupidchicken.com>
5716
5717 * xselect.c (x_clipboard_manager_save_frame)
5718 (x_clipboard_manager_save_all): New functions.
5719 (Fx_clipboard_manager_save): Lisp function deleted.
5720
5721 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5722 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5723
5724 * xterm.h: Update prototype.
5725
5ba6571d
WX
57262011-05-28 William Xu <william.xwl@gmail.com>
5727
5728 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5729 exiting (Bug#8239).
5730
3eaff834
JM
57312011-05-28 Jim Meyering <meyering@redhat.com>
5732
e1900994 5733 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5734 * fns.c (to_uchar): Define.
5735 (crypto_hash_function): Use it to convert some newly-signed
5736 variables to unsigned, to avoid sign-extension bugs. For example,
5737 without this change, (md5 "truc") would evaluate to
5738 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5739 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5740 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5741
0f6990a7
PE
57422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5743
5744 Integer overflow fixes.
c8a9ca5a 5745
08686060
PE
5746 * dbusbind.c: Serial number integer overflow fixes.
5747 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5748 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5749 to hold a serial number that is too large for a fixnum.
5750 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5751 Check for serial numbers out of range. Decode any serial number
59568bf0 5752 that was so large that it became a float. (Bug#8722)
08686060 5753
2d1fc3c7
PE
5754 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5755 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5756 Use XFASTINT rather than XUINT when numbers are nonnegative.
5757 (xd_append_arg, Fdbus_method_return_internal):
5758 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5759 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5760 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5761 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5762 (Bug#8722)
2d1fc3c7 5763
c8a9ca5a
PE
5764 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5765
519e1d69
PE
5766 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5767
6df6ae42 5768 ccl: Add integer overflow checks.
30569699
PE
5769 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5770 (IN_INT_RANGE): New macros.
5771 (ccl_driver): Use them to check for integer overflow when
5772 decoding a CCL program. Many of the new checks are whether XINT (x)
5773 fits in int; it doesn't always, on 64-bit hosts. The new version
5774 doesn't catch all possible integer overflows, but it's an
847044ea 5775 improvement. (Bug#8719)
30569699 5776
c11285dc
PE
5777 * alloc.c (make_event_array): Use XINT, not XUINT.
5778 There's no need for unsigned here.
5779
fdccd48e
PE
5780 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5781 This follows up to the 2011-05-06 change that substituted uintptr_t
5782 for EMACS_INT. This case wasn't caught back then.
5783
37910ab2
PE
5784 Rework Fformat to avoid integer overflow issues.
5785 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5786 now (part of C89). Include <verify.h>.
5787 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5788 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5789 (Fformat): Avoid the prepass trying to compute sizes; it was only
5790 approximate and thus did not catch overflow reliably. Instead, walk
5791 through the format just once, formatting and computing sizes as we go,
5792 checking for integer overflow at every step, and allocating a larger
5793 buffer as needed. Keep track separately whether the format is
5794 multibyte. Keep only the most-recently calculated precision, rather
5795 than them all. Record whether each argument has been converted to
5796 string. Use EMACS_INT, not int, for byte and char and arg counts.
5797 Support field widths and precisions larger than INT_MAX. Avoid
5798 sprintf's undefined behavior with conversion specifications such as %#d
5799 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5800 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5801 formatting out-of-range floating point numbers with int
9173deec 5802 formats. (Bug#8668)
37910ab2 5803
2e6578fb
PE
5804 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5805
0ae6bdee
PE
5806 * data.c: Avoid integer truncation in expressions involving floats.
5807 * data.c: Include <intprops.h>.
5808 (arith_driver): When there's an integer overflow in an expression
5809 involving floating point, convert the integers to floating point
5810 so that the resulting value does not suffer from catastrophic
5811 integer truncation. For example, on a 64-bit host (* 4
5812 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5813 Do not rely on undefined behavior after integer overflow.
5814
de883a70
PE
5815 merge count_size_as_multibyte, parse_str_to_multibyte
5816 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5817 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5818 Check for integer overflow.
5819 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5820 since it's now a duplicate of the other. This is more of
5821 a character than a buffer op, so better that it's in character.c.
5822 * fns.c, print.c: Adjust to above changes.
5823
2ff916cb
PE
58242011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5825
5826 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5827
f1b54466
PE
58282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5829
fb1ac845
PE
5830 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5831 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5832 (x_clipboard_manager_save): Now static.
5833 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5834
f1b54466
PE
5835 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5836 (crypto_hash_function): Now static.
5837 Fix pointer signedness problems. Avoid unnecessary initializations.
5838
a9f737ee
CY
58392011-05-27 Chong Yidong <cyd@stupidchicken.com>
5840
5841 * termhooks.h (Vselection_alist): Make it terminal-local.
5842
5843 * terminal.c (create_terminal): Initialize it.
5844
5845 * xselect.c: Support for clipboard managers.
5846 (Vselection_alist): Move to termhooks.h as terminal-local var.
5847 (LOCAL_SELECTION): New macro.
5848 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5849 (symbol_to_x_atom): Remove gratuitous arg.
5850 (x_handle_selection_request, lisp_data_to_selection_data)
5851 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5852 (x_own_selection, x_get_local_selection, x_convert_selection):
5853 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5854 (some_frame_on_display): Delete unused function.
5855 (Fx_own_selection_internal, Fx_get_selection_internal)
5856 (Fx_disown_selection_internal, Fx_selection_owner_p)
5857 (Fx_selection_exists_p): New optional frame arg.
5858 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5859 (x_handle_selection_clear): Don't treat other terminals with the
5860 same keyboard specially. Use the terminal-local Vselection_alist.
5861 (x_clear_frame_selections): Use Frun_hook_with_args.
5862
5863 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5864
5865 * xterm.h: Add support for those atoms.
5866
e067f0c1
CY
58672011-05-26 Chong Yidong <cyd@stupidchicken.com>
5868
5869 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5870 (converted_selections, conversion_fail_tag): New global variables.
5871 (x_selection_request_lisp_error): Free the above.
5872 (x_get_local_selection): Remove unnecessary code.
5873 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5874 of converted selections stored in converted_selections.
5875 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5876 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5877 (x_convert_selection): New function.
5878 (x_handle_selection_event): Simplify.
5879 (x_get_foreign_selection): Don't ignore incoming requests while
5880 waiting for an answer; this will fail when we implement
5881 SAVE_TARGETS, and seems unnecessary anyway.
5882 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5883 (Vx_sent_selection_functions): Doc fix.
5884
0f4aebc0
LL
58852011-05-26 Leo Liu <sdl.web@gmail.com>
5886
5887 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5888
e61124cd
YM
58892011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5890
5891 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5892
5893 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5894 for fringe update if it has periodic bitmap.
ac389d0c 5895 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5896 and fringe_bitmap_periodic_p.
5897
5898 * fringe.c (get_fringe_bitmap_data): New function.
5899 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5900 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5901 row. Mark glyph row for fringe update if periodicity changed.
5902
5903 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5904 for fringe update unless it has periodic bitmap.
5905
f16d9837
KH
59062011-05-25 Kenichi Handa <handa@m17n.org>
5907
5908 * xdisp.c (get_next_display_element): Set correct it->face_id for
5909 a static composition.
5910
e1b90ef6
LL
59112011-05-24 Leo Liu <sdl.web@gmail.com>
5912
5913 * deps.mk (fns.o):
5914 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5915
5916 * fns.c (crypto_hash_function, Fsha1): New function.
5917 (Fmd5): Use crypto_hash_function.
5918 (syms_of_fns): Add Ssha1.
5919
7400048f
PE
59202011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5921
5922 * gnutls.c: Remove unused macros.
5923 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5924 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5925 Remove macros that are defined and never used.
5926 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5927
abb71cf4
CY
59282011-05-22 Chong Yidong <cyd@stupidchicken.com>
5929
5930 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5931 (Fx_get_selection_internal): Minor cleanup.
5932 (Fx_own_selection_internal): Rename arguments for consistency with
5933 select.el.
5934
6307db39
PE
59352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5936
5937 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5938
f3d4e0a4
CY
59392011-05-22 Chong Yidong <cyd@stupidchicken.com>
5940
5941 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5942
4d8ade89
YM
59432011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5944
5945 * dispnew.c (scrolling_window): Don't exclude the case that the
5946 last enabled row in the desired matrix touches the bottom boundary.
5947
32078c8d
GM
59482011-05-21 Glenn Morris <rgm@gnu.org>
5949
5950 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5951 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5952 and add some more files.
32078c8d 5953
7285dc67
EZ
59542011-05-20 Eli Zaretskii <eliz@gnu.org>
5955
5956 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5957 report_file_error introduced by the change from 2011-05-07.
5958
89d1bd22
PE
59592011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 * systime.h (Time): Define only if emacs is defined.
5962 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5963 where the include path doesn't have X11/X.h by default. See
5964 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5965
cd394be1 59662011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5967
5968 * composite.c (find_automatic_composition): Fix previous change.
5969
b9704ad9
GM
59702011-05-20 Glenn Morris <rgm@gnu.org>
5971
5972 * lisp.mk: New file, split from Makefile.in.
5973 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5974 (shortlisp): Remove.
5975 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5976
4a720484
GM
59772011-05-19 Glenn Morris <rgm@gnu.org>
5978
5979 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5980 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5981 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5982 (lisp): Set the order to that of loadup.el.
5983 (shortlisp): Make it a copy of $lisp.
5984 (SOME_MACHINE_LISP): Remove.
5985 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5986 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5987
a28d4396
KH
59882011-05-18 Kenichi Handa <handa@m17n.org>
5989
5990 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5991 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5992 (find_automatic_composition): Mostly rewrite for efficiency.
5993
a2b1fa8e
JB
59942011-05-18 Juanma Barranquero <lekktu@gmail.com>
5995
5996 * makefile.w32-in: Update dependencies.
5997
8e1f5610
CS
59982011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5999
6000 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6001 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6002
7025ee00 60032011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6004
cdfa6eab
PE
6005 Fix some integer overflow issues, such as string length overflow.
6006
06d6db33
PE
6007 * insdel.c (count_size_as_multibyte): Check for string overflow.
6008
2b4560a8
PE
6009 * character.c (lisp_string_width): Check for string overflow.
6010 Use EMACS_INT, not int, for string indexes and lengths; in
6011 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6012 the resulting string length overflows an EMACS_INT; instead,
6013 report a string overflow if no precision given. When checking for
6014 precision exhaustion, use a check that cannot possibly have
6015 integer overflow. (Bug#8675)
6016 * character.h (lisp_string_width): Adjust to new signature.
6017
cb93f9be
PE
6018 * alloc.c (string_overflow): New function.
6019 (Fmake_string): Use it. This doesn't change behavior, but saves
6020 a few bytes and will simplify future changes.
6021 * character.c (string_escape_byte8): Likewise.
6022 * lisp.h (string_overflow): New decl.
6023
1a1f3366
PE
6024 Fixups, following up to the user-interface timestamp change.
6025 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6026 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6027 * msdos.c (mouse_get_pos): Likewise.
6028 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6029 * w32gui.h (Time): Define by including "systime.h" rather than by
6030 declaring it ourselves. (Bug#8664)
6031
d4e3e4d3
PE
6032 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6033 * image.c (clear_image_cache): Likewise.
6034
f6a24d19
PE
6035 * term.c (term_mouse_position): Don't assume time_t wraparound.
6036
08dc5ae6
PE
6037 Be more systematic about user-interface timestamps.
6038 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6039 and sometimes 'EMACS_UINT', to represent these timestamps.
6040 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6041 This makes the code easier to follow, and makes it easier to catch
6042 integer overflow bugs such as Bug#8664.
6043 * frame.c (Fmouse_position, Fmouse_pixel_position):
6044 Use Time, not unsigned long, for user-interface timestamps.
6045 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6046 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6047 * keyboard.h (last_event_timestamp): Likewise.
6048 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6049 * menu.h (xmenu_show): Likewise.
6050 * term.c (term_mouse_position): Likewise.
6051 * termhooks.h (struct input_event.timestamp): Likewise.
6052 (struct terminal.mouse_position_hook): Likewise.
6053 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6054 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6055 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6056 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6057 what it was before.
6058 * menu.h, termhooks.h: Include "systime.h", for Time.
6059
8e55734a
PE
6060 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6061 Don't assume that the difference between two unsigned long values
6062 can fit into an integer. At this point, we know button_down_time
6063 <= event->timestamp, so the difference must be nonnegative, so
6064 there's no need to cast the result if double-click-time is
6065 nonnegative, as it should be; check that it's nonnegative, just in
6066 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6067 apart (about 25 days). (Bug#8664)
8e55734a 6068
841f1b75 6069 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6070 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6071
3e26f69c
PE
6072 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6073 that always fit in int. Use a sentinel instead of a counter, to
6074 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6075 * frame.h (struct frame): Use int for menu_bar_items_used
6076 instead of EMACS_INT, since it always fits in int.
3e26f69c 6077
5cc152c0
PE
6078 * menu.c (grow_menu_items): Check for int overflow.
6079
d89eb65e
PE
6080 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6081
5235bd3e
PE
6082 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6083 Before, the code was not consistent. These values cannot exceed
6084 2**31 - 1 so there's no need to make them unsigned.
6085 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6086 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6087 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6088 as modifiers.
6089 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6090
bc827e23
PE
6091 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6092 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6093 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6094 presumably because the widths might not match.
6095
78eb494e
PE
6096 * window.c (size_window): Avoid needless test at loop start.
6097
04f2d78b
CB
60982011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6099
6100 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6101
d2fc7e3d 61022011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6103
6104 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6105
d2fc7e3d 61062011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6107
6108 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6109 `width' to `bar_area_x' and `bar_area_width', respectively.
6110 (x_scroll_run): Take account of fringe background extension.
6111
04f2d78b
CB
6112 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6113 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6114 `bar_area_width', respectively.
6115 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6116 background extension.
6117
79b70037
GM
61182011-05-10 Jim Meyering <meyering@redhat.com>
6119
6120 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6121
2f142cc5
JB
61222011-05-10 Juanma Barranquero <lekktu@gmail.com>
6123
6124 * image.c (Finit_image_library): Return t for built-in image types,
6125 like pbm and xbm. (Bug#8640)
6126
57679c86
AS
61272011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6128
6129 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6130
888c9e86
EZ
61312011-05-07 Eli Zaretskii <eliz@gnu.org>
6132
b0512a1d
EZ
6133 * w32console.c (Fset_screen_color): Doc fix.
6134 (Fget_screen_color): New function.
6135 (syms_of_ntterm): Defsubr it.
6136
7285dc67
EZ
6137 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6138 unlink the temporary file if Fcall_process didn't create it in the
6139 first place.
6140 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6141 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6142 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6143 cue to call_process_cleanup not to close that handle.
6144
4d3fcc8e
BK
61452011-05-07 Ben Key <bkey76@gmail.com>
6146
6147 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6148 one of two shell specific rules, either bootstrap-temacs-CMD or
6149 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6150 to the previous implementation of the bootstrap-temacs rule.
6151 The bootstrap-temacs-CMD rule is similar to the previous
6152 implementation of the bootstrap-temacs rule except that it
6153 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6154 variable.
6155
6156 These changes, along with some changes to nt/configure.bat,
6157 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6158 earlier fix to add support for --cflags and --ldflags options
6159 that include quotes so that it works whether make uses cmd or
6160 sh as the shell.
6161
b4289b64
MA
61622011-05-06 Michael Albinus <michael.albinus@gmx.de>
6163
6164 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6165 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6166 is a constant.
6167 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6168 a string. Handle both cases.
6169 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6170 (Fdbus_register_method): Use Qinvalid_function.
6171
af4c0e28
JB
61722011-05-06 Juanma Barranquero <lekktu@gmail.com>
6173
6174 * makefile.w32-in: Update dependencies.
6175 (LISP_H): Add inttypes.h and stdin.h.
6176 (PROCESS_H): Add unistd.h.
6177
c51453d9
EZ
61782011-05-06 Eli Zaretskii <eliz@gnu.org>
6179
6180 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6181 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6182
8ff0ac3c 61832011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6184
4c4b566b
PE
6185 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6186
aab2b9b5
PE
6187 * term.c (vfatal): Remove stray call to va_end.
6188 It's not needed and the C Standard doesn't allow it here anyway.
6189
c378da0b
PE
6190 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6191 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6192
288b08c7
PE
6193 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6194 bytes.
6195
e3601888
PE
6196 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6197
db6c0e74
PE
6198 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6199
dd5963ea
PE
6200 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6201
88c9450f
PE
6202 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6203
2f9442b8
PE
6204 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6205
c032b5f8
PE
6206 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6207 * charset.c (Fdefine_charset_internal): Don't initialize
6208 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6209 32-bit int (Bug#8600).
a108c10b
PE
6210
6211 * lread.c (read_integer): Be more consistent with string-to-number.
6212 Use string_to_number to do the actual conversion; this avoids
6213 rounding errors and fixes some other screwups. Without this fix,
6214 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6215 (digit_to_number): Move earlier, for benefit of read_integer.
6216 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6217 not a digit in any supported base. (Bug#8602)
a108c10b 6218
ad5f9eea
PE
6219 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6220
aec1708a
PE
6221 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6222 to match comment at start of function. This also removes a
6223 GCC warning about overflow in a 32+64-bit port.
6224
47be4ab5
PE
6225 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6226
371cac43
PE
6227 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6228 Reported by Stefan Monnier in
6229 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6230 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6231 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6232
d01a7826
PE
6233 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6234 (EMACS_UINTPTR): Likewise, with uintptr_t.
6235
7fd47d5c
PE
6236 * lisp.h: Prefer 64-bit EMACS_INT if available.
6237 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6238 on 32-bit hosts that have 64-bit int, so that they can access
6239 large files.
122b0c86
PE
6240 However, temporarily disable this change unless the temporary
6241 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6242
8727937b
PE
6243 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6244
8ac068ac
PE
6245 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6246 This removes an assumption that EMACS_INT and long are the same
6247 width as pointers. The assumption is true for Emacs porting targets
6248 now, but we want to make other targets possible.
6249 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6250 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6251 In the rest of the code, change types of integers that hold casted
6252 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6253 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6254 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6255 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6256 No need to cast type when ORing.
6257 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6258 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6259 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6260 assume EMACS_INT is the same width as char *.
6261 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6262 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6263 Remove no-longer-needed casts.
6264 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6265 (xg_tool_bar_help_callback, xg_make_tool_item):
6266 Use EMACS_INTPTR to hold an integer
6267 that will be cast to void *; this can avoid a GCC warning
6268 if EMACS_INT is not the same width as void *.
6269 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6270 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6271 (current_message_1, set_message_1):
6272 Use a local to convert to proper width without a cast.
6273 * xmenu.c (dialog_selection_callback): Likewise.
6274
ede49d71
PE
6275 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6276 Also, don't assume VALBITS / RAND_BITS is less than 5,
6277 and don't rely on undefined behavior when shifting a 1 left into
6278 the sign bit.
6279 * lisp.h (get_random): Change signature to match.
6280
2f30ecd0
PE
6281 * lread.c (hash_string): Use size_t, not int, for hash computation.
6282 Normally we prefer signed values; but hashing is special, because
6283 it's better to use unsigned division on hash table sizes so that
6284 the remainder is nonnegative. Also, size_t is the natural width
6285 for hashing into memory. The previous code used 'int', which doesn't
6286 retain enough info to hash well into very large tables.
6287 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6288
2a866e7b
PE
6289 * dbusbind.c: Don't possibly lose pointer info when converting.
6290 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6291 Use XPNTR rather than XHASH, so that the high-order bits of
6292 the pointer aren't lost when converting through void *.
6293
51639eac
PE
6294 * eval.c (Fautoload): Don't double-shift a pointer.
6295
92394119
PE
6296 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6297
dbdb9a7c
JB
62982011-05-06 Juanma Barranquero <lekktu@gmail.com>
6299
6300 * gnutls.c (DEF_GNUTLS_FN):
6301 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6302
db7a0b4f
AS
63032011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6304
6305 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6306 marker. (Bug#8610)
6307
cd394be1 63082011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6309
6310 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6311 New version that can reserve upto 2GB of heap space.
6312
f7ff1b0f 63132011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6314
6315 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6316
639c109b
TZ
63172011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6318
6319 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6320 `gnutls_certificate_set_x509_key_file'.
6321
d2127135
JB
63222011-05-05 Juanma Barranquero <lekktu@gmail.com>
6323
6324 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6325 Update dependencies.
6326
e968f4f3
JB
63272011-05-04 Juanma Barranquero <lekktu@gmail.com>
6328
6329 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6330 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6331 Remove unused parameter `fildes'.
6332 * process.c (read_process_output, send_process): Don't pass it.
6333
84d358f0
JB
63342011-05-04 Juanma Barranquero <lekktu@gmail.com>
6335
6336 Fix previous change: the library cache is defined in w32.c.
6337 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6338 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6339
0898ca10
JB
63402011-05-04 Juanma Barranquero <lekktu@gmail.com>
6341
6342 Implement dynamic loading of GnuTLS on Windows.
6343
6344 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6345 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6346 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6347 Declare.
6348
6349 * gnutls.c (Qgnutls_dll): Define.
6350 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6351 (gnutls_*): Declare function pointers.
6352 (init_gnutls_functions): New function to initialize function pointers.
6353 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6354 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6355 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6356 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6357 (emacs_gnutls_write, emacs_gnutls_read)
6358 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6359 (Fgnutls_available_p): New function.
6360 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6361 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6362 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6363
6364 * image.c: Include w32.h.
6365 (Vimage_type_cache): Delete.
6366 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6367 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6368 (w32_delayed_load): Move to w32.c.
6369
6370 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6371
6372 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6373 (w32_delayed_load): Move from image.c. When loading a library, record
6374 its filename in the :loaded-from property of the library id.
6375 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6376 Initialize and staticpro them.
6377 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6378
6379 * process.c: Include lisp.h before w32.h, not after.
6380 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6381 instead of gnutls_record_check_pending.
6382
6383 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6384
ff4de4aa
TZ
63852011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6386
6387 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6388 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6389 as passed in.
6390
abe95abb
JD
63912011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6392
6393 * xterm.c (x_set_frame_alpha): Do not set property on anything
6394 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6395
e16e55d4
JB
63962011-05-02 Juanma Barranquero <lekktu@gmail.com>
6397
6398 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6399
bafcf6a5
JB
64002011-05-02 Juanma Barranquero <lekktu@gmail.com>
6401
6402 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6403 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6404 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6405 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6406 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6407 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6408 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6409 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6410 (Qgnutls_bootprop_callbacks_verify): Make static.
6411
e7a6747f
AS
64122011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6413
19ed11ba
AS
6414 * callproc.c: Indentation fixup.
6415
e7a6747f 6416 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6417 (wait_for_termination, interruptible_wait_for_termination):
6418 Move after wait_for_termination_1.
e7a6747f 6419
1ef14cb4
LMI
64202011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6421
6422 * sysdep.c (interruptible_wait_for_termination): New function
6423 which is like wait_for_termination, but allows keyboard
6424 interruptions.
6425
6426 * callproc.c (Fcall_process): Add (:file "file") as an option for
6427 the STDOUT buffer.
6428 (Fcall_process_region): Ditto.
6429
330d880c
EZ
64302011-04-30 Eli Zaretskii <eliz@gnu.org>
6431
8db90b73
EZ
6432 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6433 rather than `XVECTOR (FOO)->size'.
6434
330d880c
EZ
6435 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6436 inttypes.h, as a gnulib replacement is used if it not available in
6437 system headers.
6438
15cbd324
EZ
64392011-04-21 Eli Zaretskii <eliz@gnu.org>
6440
6441 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6442 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6443 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6444
6445 * coding.c (coding_alloc_by_realloc): Error out if destination
6446 will grow beyond MOST_POSITIVE_FIXNUM.
6447 (decode_coding_emacs_mule): Abort if there isn't enough place in
6448 charbuf for the composition carryover bytes. Reserve an extra
6449 space for up to 2 characters produced in a loop.
6450 (decode_coding_iso_2022): Abort if there isn't enough place in
6451 charbuf for the composition carryover bytes.
6452
64532011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6454
ae940cca
EZ
6455 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6456 aborting when %lld or %lll format is passed.
6457 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6458 %llo or %llx format is passed. (Bug#8545)
6459
03ab8921
EZ
6460 * window.c (window_scroll_line_based): Use a marker instead of
6461 simple variables to record original value of point. (Bug#7952)
6462
afda1437
EZ
6463 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6464 produced by %s or %c overflows available buffer space. (Bug#8545)
6465
f76dee0c
PE
64662011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6467
6468 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6469 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6470
fdc5744d
JB
64712011-04-28 Juanma Barranquero <lekktu@gmail.com>
6472
6473 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6474
638f053a
JB
64752011-04-28 Juanma Barranquero <lekktu@gmail.com>
6476
6477 * keyboard.c (Qdelayed_warnings_hook): Define.
6478 (command_loop_1): Run `delayed-warnings-hook'
6479 if Vdelayed_warnings_list is non-nil.
6480 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6481 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6482
d178f871
EZ
64832011-04-28 Eli Zaretskii <eliz@gnu.org>
6484
6485 * doprnt.c (doprnt): Don't return value smaller than the buffer
6486 size if the message was truncated. (Bug#8545).
6487
b124fd93
JB
64882011-04-28 Juanma Barranquero <lekktu@gmail.com>
6489
6490 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6491 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6492
e810457d
PE
64932011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6494
6495 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6496
ea51cceb
JB
64972011-04-27 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * makefile.w32-in: Update dependencies.
6500
94dcfacf
EZ
65012011-04-27 Eli Zaretskii <eliz@gnu.org>
6502
6503 Improve `doprnt' and its usage. (Bug#8545)
6504 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6505 `format_end'. Remove support for %l as a conversion specifier.
6506 Don't use xrealloc. Improve diagnostics when the %l size modifier
6507 is used. Update the commentary.
6508
6509 * eval.c (verror): Simplify calculation of size_t.
6510
6511 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6512 messages.
6513
f61f41d7
PE
65142011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6515
6516 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6517 change.
6518
96fb4434
PE
65192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6520
6521 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6522 This makes this file independent of the recent pseudovector change.
6523
671875da 65242011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6525
69e9b5a3
PE
6526 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6527
b5f869a7 6528 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6529 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6530 Remove unused local.
c8926152 6531 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6532
841a1577 6533 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6534 GCC 4.6.0 optimizes based on type-based alias analysis.
6535 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6536 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6537 != &v->size, and therefore "v->size = 1; b->size = 2; return
6538 v->size;" must therefore return 1. This assumption is incorrect
6539 for Emacs, since it type-puns struct Lisp_Vector * with many other
6540 types. To fix this problem, this patch adds a new type struct
f904488f 6541 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6542 and pseudovectors, and helps optimizing compilers not get fooled
6543 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6544 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6545 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6546 the size member.
eab3844f
PE
6547 (XSETPVECTYPE): Rewrite in terms of new macro.
6548 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6549 This is a bit clearer, and further avoids the possibility of
6550 undesirable aliasing.
6551 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6552 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6553 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6554 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6555 (ASIZE): Now uses header.size rather than size.
6556 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6557 to avoid the hassle of writing XVECTOR (foo)->header.size.
6558 (struct vectorlike_header): New type.
eab3844f
PE
6559 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6560 object, to help avoid aliasing.
6561 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6562 (SUBRP): Likewise, since Lisp_Subr is a special case.
6563 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6564 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6565 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6566 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6567 changed to be "header.size" and "header.next".
6568 * buffer.h (struct buffer): Likewise.
6569 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6570 * frame.h (struct frame): Likewise.
6571 * process.h (struct Lisp_Process): Likewise.
6572 * termhooks.h (struct terminal): Likewise.
6573 * window.c (struct save_window_data, struct saved_window): Likewise.
6574 * window.h (struct window): Likewise.
6575 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6576 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6577 * buffer.c (init_buffer_once): Likewise.
6578 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6579 special case.
6580 * process.c (Fformat_network_address): Use local var for size,
6581 for brevity.
6582
0df1eac5
PE
6583 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6584
847ab9d1 6585 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6586 * data.c (atof): Remove decl; no longer used or needed.
6587 (digit_to_number): Move to lread.c.
6588 (Fstring_to_number): Use new string_to_number function, to be
6589 consistent with how the Lisp reader treats infinities and NaNs.
6590 Do not assume that floating-point numbers represent EMACS_INT
6591 without losing information; this is not true on most 64-bit hosts.
6592 Avoid double-rounding errors, by insisting on integers when
6593 parsing non-base-10 numbers, as the documentation specifies.
6594 * lisp.h (string_to_number): New decl, replacing ...
6595 (isfloat_string): Remove.
bc0a5c13 6596 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6597 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6598 appears to have been a coding error. Similarly, do not accept
6599 strings like +-1e0 as floating point numbers. Do not report
6600 overflow for integer overflows unless the base is not 10 which
6601 means we have no simple and reliable way to continue.
6602 Break out the floating-point parsing into a new
6603 function string_to_number, so that Fstring_to_number parses
6604 floating point numbers consistently with the Lisp reader.
04f2d78b 6605 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6606 (E_CHAR, EXP_INT): Remove, replacing with ...
6607 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6608 (string_to_number): New function, replacing isfloat_string.
6609 This function checks for valid syntax and produces the resulting
6610 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6611 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6612 so that overflow for non-base-10 numbers is reported only when
6613 there's no portable and simple way to convert to floating point.
452f4150 6614
67769ffc
PE
6615 * textprop.c (set_text_properties_1): Rewrite for clarity,
6616 and to avoid GCC warning about integer overflow.
6617
c20db43f
PE
6618 * intervals.h (struct interval): Use EMACS_INT for members
6619 where EMACS_UINT might cause problems. See
6620 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6621 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6622 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6623 All uses changed.
37aa2f85
PE
6624 (offset_intervals): Tell GCC not to worry about length overflow
6625 when negating a negative length.
c20db43f 6626
2538aa2f
PE
6627 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6628 (overrun_check_free): Likewise.
6629
f2d3008d
PE
6630 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6631 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6632 word size.
6633
ec8df744
PE
6634 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6635 (gnutls_make_error): Rename local to avoid shadowing.
6636 (gnutls_emacs_global_deinit): ifdef out; not used.
6637 (Fgnutls_boot): Use const for pointer to readonly storage.
6638 Comment out unused local. Fix pointer signedness problems.
6639
640ee02d
PE
6640 * lread.c (openp): Don't stuff size_t into an 'int'.
6641 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6642 about possible signed overflow.
6643
6048fb2a
PE
6644 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6645 (GDK_KEY_g): Don't define if already defined.
6646 (xg_prepare_tooltip): Avoid pointer signedness problem.
6647 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6648
fa3c87e1
PE
6649 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6650 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6651
2172544b
PE
6652 * xfns.c (Fx_window_property): Simplify a bit,
6653 to make a bit faster and to avoid GCC 4.6.0 warning.
6654 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6655
9b821a21
PE
6656 * fns.c (internal_equal): Don't assume size_t fits in int.
6657
3c616cfa
PE
6658 * alloc.c (compact_small_strings): Tighten assertion a little.
6659
c2982e87
PE
6660 Replace pEd with more-general pI, and fix some printf arg casts.
6661 * lisp.h (pI): New macro, generalizing old pEd macro to other
6662 conversion specifiers. For example, use "...%"pI"d..." rather
6663 than "...%"pEd"...".
6664 (pEd): Remove. All uses replaced with similar uses of pI.
6665 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6666 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6667 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6668 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6669 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6670 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6671 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6672 64-bit hosts.
6673 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6674 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6675 * print.c (safe_debug_print, print_object): Likewise.
6676 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6677 to int.
6f04d126
PE
6678 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6679 avoiding the 0 flag, which is not portable.
c2982e87
PE
6680 * process.c (Fmake_network_process): Use pI to avoid cast.
6681 * region-cache.c (pp_cache): Likewise.
6682 * xdisp.c (decode_mode_spec): Likewise.
6683 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6684 behavior on 64-bit hosts with printf arg.
6f04d126 6685 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6686 (x_stop_queuing_selection_requests): Likewise.
6687 (x_get_window_property): Don't truncate byte count to an 'int'
6688 when tracing.
0b432f21 6689
5e073ec7
PE
6690 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6691 here, since it parses constructs like leading '-' and spaces,
6692 which are not wanted; and it overflows with large numbers.
6693 Instead, simply match F[0-9]+, which is what is wanted anyway.
6694
36372bf9
PE
6695 * alloc.c: Remove unportable assumptions about struct layout.
6696 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6697 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6698 (allocate_vectorlike, make_pure_vector): Use the new macros,
6699 plus offsetof, to remove unportable assumptions about struct layout.
6700 These assumptions hold on all porting targets that I know of, but
6701 they are not guaranteed, they're easy to remove, and removing them
6702 makes further changes easier.
6703
0b432f21
PE
6704 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6705 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6706 (string_overrun_cookie): Now const. Use initializers that
6707 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6708 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6709 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6710 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6711 multiple of sizeof (EMACS_INT); it need not be, if
6712 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6713 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6714
895009e1
JB
67152011-04-26 Juanma Barranquero <lekktu@gmail.com>
6716
6717 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6718
6a7a1b0b
TZ
67192011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6720
6721 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6722 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6723 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6724
841a1577 67252011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6726
6727 * lisp.h (Qdebug): List symbol.
895009e1 6728 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6729 * keyboard.c (debug-on-event): New variable.
6730 (handle_user_signal): Break into debugger when debug-on-event
6731 matches the current signal symbol.
6732
f2d3ba6f
DN
67332011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6734
6735 * alloc.c (check_sblock, check_string_bytes)
6736 (check_string_free_list): Convert to standard C.
6737
42ce4c63
TZ
67382011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6739
6740 * w32.c (emacs_gnutls_push): Fix typo.
6741
825cd63c
EZ
67422011-04-25 Eli Zaretskii <eliz@gnu.org>
6743
fb11d64d
EZ
6744 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6745 "cast to pointer from integer of different size".
6746
825cd63c
EZ
6747 Improve doprnt and its use in verror. (Bug#8545)
6748 * doprnt.c (doprnt): Document the set of format control sequences
6749 supported by the function. Use SAFE_ALLOCA instead of always
6750 using `alloca'.
6751
6752 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6753 is one byte too soon. Don't use xrealloc; instead xfree and
6754 xmalloc anew.
6755
e061a11b
TZ
67562011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6757
6758 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6759 callbacks stage.
6760
6761 * gnutls.c: Renamed global_initialized to
6762 gnutls_global_initialized. Added internals for the
6763 :verify-hostname-error, :verify-error, and :verify-flags
6764 parameters of `gnutls-boot' and documented those parameters in the
6765 docstring. Start callback support.
9173deec
JB
6766 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6767 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6768 on error. Return error code.
e061a11b
TZ
6769 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6770 (emacs_gnutls_read): Likewise.
6771 (Fgnutls_boot): Return handshake error code.
6772 (emacs_gnutls_handle_error): New function.
6773 (wsaerror_to_errno): Likewise.
6774
6775 * w32.h (emacs_gnutls_pull): Add prototype.
6776 (emacs_gnutls_push): Likewise.
6777
6778 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6779 (emacs_gnutls_push): Likewise.
6780
67812011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6782
6783 * process.c (wait_reading_process_output): Check if GnuTLS
6784 buffered some data internally if no FDs are set for TLS
6785 connections.
6786
6787 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6788 (LIBS): Link to USER_LIBS.
6789 ($(BLD)/gnutls.$(0)): New target.
6790
fa6996bc
EZ
67912011-04-24 Eli Zaretskii <eliz@gnu.org>
6792
eb35682e
EZ
6793 * xdisp.c (handle_single_display_spec): Rename the
6794 display_replaced_before_p argument into display_replaced_p, to
6795 make it consistent with the commentary. Fix typos in the
6796 commentary.
6797
e2ad650c
EZ
6798 * textprop.c (syms_of_textprop): Remove dead code.
6799 (copy_text_properties): Delete obsolete commentary about an
6800 interface that was deleted long ago. Fix typos in the description
6801 of arguments.
6802
1b2de274
EZ
6803 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6804 to changes in oldXMenu/XMenu.h from 2011-04-16.
6805 <menu_help_message, prev_menu_help_message>: Constify.
6806 (IT_menu_make_room): menu->help_text is now `const char **';
6807 adjust.
6808
6809 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6810 to changes in oldXMenu/XMenu.h from 2011-04-16.
6811 (struct XMenu): Declare `help_text' `const char **'.
6812
6813 * xfaces.c <Qunspecified>: Make extern again.
6814
6815 * syntax.c: Include sys/types.h before including regex.h, as
6816 required by Posix.
6817
762b15be
EZ
6818 * doc.c (get_doc_string): Improve the format passed to `error'.
6819
6820 * doprnt.c (doprnt): Improve commentary.
6821
6822 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6823
6824 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6825 them with etags.
6826
f1052e5d
EZ
6827 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6828 changes in globals.h immediately force recompilation.
762b15be
EZ
6829 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6830 $(CURDIR)/s/ms-w32.h.
6831 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6832
fa6996bc
EZ
6833 * character.c (Fchar_direction): Function deleted.
6834 (syms_of_character): Don't defsubr it.
6835 <char-direction-table>: Deleted.
6836
e6c3da20
EZ
68372011-04-23 Eli Zaretskii <eliz@gnu.org>
6838
6839 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6840 * doprnt.c: Include limits.h.
6841 (SIZE_MAX): New macro.
04f2d78b
CB
6842 (doprnt): Return a size_t value. 2nd arg is now size_t.
6843 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6844 Improve overflow protection. Support `l' modifier for integer
6845 conversions. Support %l conversion. Don't assume an EMACS_INT
6846 argument for integer conversions and for %c.
6847
6848 * lisp.h (doprnt): Restore prototype.
6849
6850 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6851 $(SRC)/character.h.
6852
6853 * Makefile.in (base_obj): Add back doprnt.o.
6854
6855 * deps.mk (doprnt.o): Add back prerequisites.
6856 (callint.o): Depend on character.h.
6857
6858 * eval.c (internal_lisp_condition_case): Include the handler
6859 representation in the error message.
6860 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6861 when breaking from the loop.
6862
6863 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6864
6865 * callint.c (Fcall_interactively): When displaying error message
6866 about invalid control letter, pass the character's codepoint, not
6867 a pointer to its multibyte form. Improve display of the character
6868 in octal and display also its hex code.
6869
6870 * character.c (char_string): Use %x to display the (unsigned)
6871 codepoint of an invalid character, to avoid displaying a bogus
6872 negative value.
6873
6874 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6875 `error', not SYMBOL_NAME itself.
6876
6877 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6878 character arguments to `error'.
6879
6880 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6881 to `error' in error message about FINAL_CHAR argument. Make sure
6882 FINAL_CHAR is a character, and use %c when it is passed as
6883 argument to `error'.
6884
4ffd0d6b 68852011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6886
6887 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6888
6889 * w32.c: Include <time.h>.
6890 (sys_localtime): New function.
6891
4ffd0d6b 68922011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6893
6894 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6895
4ffd0d6b 6896 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6897
4ffd0d6b 68982011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6899
4ffd0d6b
GM
6900 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6901 zombies (Bug#8467).
aac0c6e3 6902
04c56954
EZ
69032011-04-19 Eli Zaretskii <eliz@gnu.org>
6904
6905 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6906 gl_state.e_property when gl_state.object is Qt.
6907
6908 * insdel.c (make_gap_larger): Remove limitation of buffer size
6909 to <= INT_MAX.
6910
16a43933
CY
69112011-04-18 Chong Yidong <cyd@stupidchicken.com>
6912
6913 * xdisp.c (lookup_glyphless_char_display)
6914 (produce_glyphless_glyph): Handle cons cell entry in
6915 glyphless-char-display.
6916 (Vglyphless_char_display): Document it.
6917
6918 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6919 glyphless-char-display.
6920
4581706e
CY
69212011-04-17 Chong Yidong <cyd@stupidchicken.com>
6922
6923 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6924
6925 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6926
6927 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6928 definition for no-X builds.
6929
4887c6e2 69302011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6931
fd35b6f9
PE
6932 Static checks with GCC 4.6.0 and non-default toolkits.
6933
5c1ccb01
PE
6934 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6935
006c5daa
PE
6936 * process.c (keyboard_bit_set): Define only if SIGIO.
6937 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6938 (send_process): Repair possible setjmp clobbering.
6939
efc736d3
PE
6940 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6941
4e2fe2e6
PE
6942 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6943
f97334a2
PE
6944 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6945
4e75f29d
PE
6946 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6947 Define only if needed.
6948
90efadd1
PE
6949 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6950 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6951 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6952
3c647824
PE
6953 * dispextern.h (struct redisplay_interface): Rename param
6954 to avoid shadowing.
e264f262 6955 * termhooks.h (struct terminal): Likewise.
761383f4 6956 * xterm.c (xembed_send_message): Likewise.
3c647824 6957
b58c5c4a
PE
6958 * insdel.c (make_gap_smaller): Define only if
6959 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6960
cad59032
PE
6961 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6962 it.
6963
c339dc2e
PE
6964 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6965 so that we aren't warned about unused symbols.
6966
91a3e27b
PE
6967 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6968
399c71d3 6969 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6970
8ffc96f5
PE
6971 * xfns.c (x_real_positions): Mark locals as initialized.
6972
eef9bc79
PE
6973 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6974
098db9dd
PE
6975 * xterm.c: Fix problems found by static analysis with other toolkits.
6976 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6977 (x_dispatch_event): Declare static if USE_GTK, and
6978 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6979 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6980 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6981 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6982 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6983
eb18f6cc
PE
6984 * xmenu.c (menu_help_callback): Pointer type fixes.
6985 Use const pointers when pointing at readonly data. Avoid pointer
6986 signedness clashes.
6987 (FALSE): Remove unused macro.
6988 (update_frame_menubar): Remove unused decl.
6989
1fe72bf8
PE
6990 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6991
60d9e1db
PE
6992 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6993 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6994 (single_menu_item): Rename local to avoid shadowing.
6995
39261c26
PE
6996 * keyboard.c (make_lispy_event): Remove unused local var.
6997
018c5e19
PE
6998 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6999 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7000
63d2b86e
PE
7001 * bitmaps: Change bitmaps from unsigned char back to the X11
7002 compatible char. Avoid the old compiler warnings about
7003 out-of-range initializers by using, for example, '\xab' rather
7004 than 0xab.
7005
aefd87e1
PE
7006 * xgselect.c (xgselect_initialize): Check vs interface
7007 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7008
bf501fb9
PE
7009 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7010
e9829fdf
PE
7011 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7012 to read-only memory.
7013
1086c095
PE
7014 * fns.c (vector): Remove; this old hack is no longer needed.
7015
2baccd04 7016 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7017 Remove unused var.
dde42981 7018 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7019
72391843 7020 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7021
436c16df 7022 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7023 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7024 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7025
92bb796d 7026 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7027 (x_term_init): Remove local to avoid shadowing.
92bb796d 7028
764430a3 7029 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7030
7031 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7032 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7033
d1dfb56c
EZ
70342011-04-16 Eli Zaretskii <eliz@gnu.org>
7035
c4354cb4
EZ
7036 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7037
d1dfb56c
EZ
7038 Fix regex.c, syntax.c and friends for buffers > 2GB.
7039 * syntax.h (struct gl_state_s): Declare character position members
7040 EMACS_INT.
7041
7042 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7043
04f2d78b
CB
7044 * textprop.c (verify_interval_modification, interval_of):
7045 Declare arguments EMACS_INT.
d1dfb56c
EZ
7046
7047 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7048 EMACS_INT.
7049
7050 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7051
7052 * indent.c (Fvertical_motion): Local variable it_start is now
7053 EMACS_INT.
7054
7055 * regex.c (re_match, re_match_2, re_match_2_internal)
7056 (bcmp_translate, regcomp, regexec, print_double_string)
7057 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7058 (re_compile_pattern, re_exec): Declare arguments and local
7059 variables `size_t' and `ssize_t' and return values `regoff_t', as
7060 appropriate.
7061 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7062 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7063 <compile_stack_type>: `size' and `avail' are now `size_t'.
7064
7065 * regex.h <regoff_t>: Use ssize_t, not int.
7066 (re_search, re_search_2, re_match, re_match_2): Arguments that
7067 specify buffer/string position and length are now ssize_t and
7068 size_t. Return type is regoff_t.
7069
613052cd
BK
70702011-04-16 Ben Key <bkey76@gmail.com>
7071
7072 * nsfont.m: Fixed bugs in ns_get_family and
7073 ns_descriptor_to_entity that were caused by using free to
7074 deallocate memory blocks that were allocated by xmalloc (via
7075 xstrdup). This caused Emacs to crash when compiled with
7076 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7077 --enable-checking=xmallocoverrun). xfree is now used to
7078 deallocate these memory blocks.
7079
4170f62f 70802011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7081
71b41406
PE
7082 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7083
9587a89d
PE
7084 emacs_write: Accept and return EMACS_INT for sizes.
7085 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7086 et seq.
7087 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7088 Accept and return EMACS_INT.
7089 (emacs_gnutls_write): Return the number of bytes written on
7090 partial writes.
7091 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7092 (emacs_read, emacs_write): Remove check for negative size, as the
7093 Emacs source code has been audited now.
9587a89d
PE
7094 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7095 (emacs_read, emacs_write): Use it.
273a5f82
PE
7096 * process.c (send_process): Adjust to the new signatures of
7097 emacs_write and emacs_gnutls_write. Do not attempt to store
7098 a byte offset into an 'int'; it might overflow.
9587a89d 7099 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7100
3e047f51
PE
7101 * sound.c: Don't assume sizes fit in 'int'.
7102 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7103 Return EMACS_INT, not int.
3e047f51 7104 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7105 Accept EMACS_INT, not int.
7106 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7107 record read return values.
7108
cc39a9db
BK
71092011-04-15 Ben Key <bkey76@gmail.com>
7110
c9d0ec6d
JB
7111 * keyboard.c (Qundefined): Don't declare static since it is used
7112 in nsfns.m.
7113 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7114 static since they are used in nsfont.m.
cc39a9db 7115
6c60eb9f
SM
71162011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7117
7118 * process.c (Qprocessp): Don't declare static.
7119 * lisp.h (Qprocessp): Declare again.
7120
7990b61a
JB
71212011-04-15 Juanma Barranquero <lekktu@gmail.com>
7122
7123 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7124
5d4cb038
PE
71252011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7126
8bd7b830 7127 Improve C-level modularity by making more things 'static'.
cd64ea1d 7128
e3b27b31
PE
7129 Don't publish debugger-only interfaces to other modules.
7130 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7131 (verify_bytepos, count_markers): Move decls to the only modules
7132 that need them.
7133 * region-cache.h (pp_cache): Likewise.
7134 * window.h (check_all_windows): Likewise.
7135 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7136
5d4cb038
PE
7137 * sysdep.c (croak): Now static, if
7138 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7139 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7140
7141 * alloc.c (refill_memory_reserve): Now static if
7142 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7143 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7144
e87b6180
PE
7145 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7146 Define only if USE_LUCID.
7147
ac64929e
PE
7148 * xrdb.c (x_customization_string, x_rm_string): Now static.
7149
6f37259d
PE
7150 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7151 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7152
1683e3ab
PE
7153 * xdisp.c (draw_row_with_mouse_face): Now static.
7154 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7155
de9c2632
PE
7156 * window.h (check_all_windows): Mark externally visible.
7157
2b96acb7
PE
7158 * window.c (window_deletion_count): Now static.
7159
7160 * undo.c: Make symbols static if they're not exported.
7161 (last_undo_buffer, last_boundary_position, pending_boundary):
7162 Now static.
7163
50436f33
PE
7164 * textprop.c (interval_insert_behind_hooks): Now static.
7165 (interval_insert_in_front_hooks): Likewise.
7166
64520e5c
PE
7167 * term.c: Make symbols static if they're not exported.
7168 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7169 (max_frame_lines, tty_set_terminal_modes):
7170 (tty_reset_terminal_modes, tty_turn_off_highlight):
7171 (get_tty_terminal): Now static.
7172 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7173 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7174 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7175 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7176 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7177
1fa53021
PE
7178 * sysdep.c: Make symbols static if they're not exported.
7179 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7180 Now static.
7181 (sigprocmask_set, full_mask): Remove; unused.
7182 (wait_debugging): Mark as visible.
7183 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7184 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7185
d4b43b22
PE
7186 * syntax.c (syntax_temp): Define only if !__GNUC__.
7187
b7c513d0
PE
7188 * sound.c (current_sound_device, current_sound): Now static.
7189
989b29ad
PE
7190 * search.c (searchbufs, searchbuf_head): Now static.
7191
13a55a78
PE
7192 * scroll.c (scroll_cost): Remove; unused.
7193 * dispextern.h (scroll_cost): Remove decl.
7194
de68a1fc
PE
7195 * region-cache.h (pp_cache): Mark as externally visible.
7196
40ccffa6
PE
7197 * process.c: Make symbols static if they're not exported.
7198 (process_tick, update_tick, create_process, chan_process):
7199 (Vprocess_alist, proc_buffered_char, datagram_access):
7200 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7201 (deactivate_process): Mark defn as static, as well as decl.
7202 * lisp.h (create_process): Remove decl.
7203 * process.h (chan_process, Vprocess_alist): Remove decls.
7204
ad64fc97
PE
7205 * print.c: Make symbols static if they're not exported.
7206 (print_depth, new_backquote_output, being_printed, print_buffer):
7207 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7208 (print_interval, print_number_index, initial_stderr_stream):
7209 Now static.
7210 * lisp.h (Fprinc): Remove decl.
7211 (debug_output_compilation_hack): Mark as externally visible.
7212
adddb265
PE
7213 * sysdep.c (croak): Move decl from here to syssignal.h.
7214 * syssignal.h (croak): Put it here, so the API can be checked when
7215 'croak' is called from dissociate_if_controlling_tty.
7216
1717ede2
PE
7217 * minibuf.c: Make symbols static if they're not exported.
7218 (minibuf_save_list, choose_minibuf_frame): Now static.
7219 * lisp.h (choose_minibuf_frame): Remove decl.
7220
fa5fb2bc
PE
7221 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7222
1e3890d1
PE
7223 * lread.c: Make symbols static if they're not exported.
7224 (read_objects, initial_obarray, oblookup_last_bucket_number):
7225 Now static.
7226 (make_symbol): Remove; unused.
7227 * lisp.h (initial_obarray, make_symbol): Remove decls.
7228
8a1414fa
PE
7229 * keyboard.c: Make symbols static if they're not exported.
7230 (single_kboard, recent_keys_index, total_keys, recent_keys):
7231 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7232 (this_single_command_key_start, echoing, last_auto_save):
7233 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7234 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7235 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7236 (Vlispy_mouse_stem, double_click_count):
7237 Now static.
7238 (force_auto_save_soon): Define only if SIGDANGER.
7239 (ignore_mouse_drag_p): Now static if
7240 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7241 (print_help): Remove; unused.
7242 (stop_character, last_timer_event): Mark as externally visible.
7243 * keyboard.h (ignore_mouse_drag_p): Declare only if
7244 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7245 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7246 * lisp.h (echoing): Remove decl.
7247 (force_auto_save_soon): Declare only if SIGDANGER.
7248 * xdisp.c (redisplay_window): Simplify code, to make it more
7249 obvious that ignore_mouse_drag_p is not accessed if !defined
7250 USE_GTK && !defined HAVE_NS.
7251
93ea6e8f
PE
7252 * intervals.c: Make symbols static if they're not exported.
7253 (merge_properties_sticky, merge_interval_right, delete_interval):
7254 Now static.
7255 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7256
77382fcc
PE
7257 * insdel.c: Make symbols static if they're not exported.
7258 However, leave prepare_to_modify_buffer alone. It's never
7259 called from outside this function, but that appears to be a bug.
7260 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7261 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7262 (adjust_after_replace_noundo): Remove; unused.
7263 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7264 (signal_before_change): Remove decls.
77382fcc 7265
9306c32e
PE
7266 * indent.c (val_compute_motion, val_vmotion): Now static.
7267
cd44d2eb
PE
7268 * image.c: Make symbols static if they're not exported.
7269 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7270 if USE_GTK.
7271 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7272 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7273
ad9a7a06
PE
7274 * fringe.c (standard_bitmaps): Now static.
7275 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7276
81626931
PE
7277 * frame.c: Make symbols static if they're not exported.
7278 (x_report_frame_params, make_terminal_frame): Now static.
7279 (get_frame_param): Now static, unless HAVE_NS.
7280 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7281 (x_get_resource_string): Remove; not used.
7282 * frame.h (make_terminal_frame, x_report_frame_params):
7283 (x_get_resource_string); Remove decls.
7284 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7285 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7286
239f9db9
PE
7287 * font.c, fontset.c: Make symbols static if they're not exported.
7288 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7289 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7290 * font.c (font_close_object): Now static.
7291 * font.h (font_close_object): Remove.
7292 * fontset.c (FONTSET_OBJLIST): Remove.
7293 (free_realized_fontset) #if-0 the body, which does nothing.
7294 (face_suitable_for_char_p): #if-0, as it's never called.
7295 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7296 * xfaces.c (face_at_string_position):
7297 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7298 since 0 is always ASCII.
7299
dfcf3579
PE
7300 * fns.c (weak_hash_tables): Now static.
7301
5045092b
PE
7302 * fileio.c: Make symbols static if they're not exported.
7303 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7304 (Vwrite_region_annotation_buffers): Now static.
7305
57a96f5c
PE
7306 * eval.c: Make symbols static if they're not exported.
7307 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7308 * lisp.h (backtrace_list): Remove decl.
7309
35f08c38
PE
7310 * emacs.c: Make symbols static if they're not exported.
7311 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7312 (fatal_error_code, fatal_error_signal_hook, standard_args):
7313 Now static.
7314 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7315 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7316 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7317 * lisp.h (fatal_error_signal_hook): Remove decl.
7318 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7319
f44bd759
PE
7320 * editfns.c: Move a (normally-unused) function to its only use.
7321 * editfns.c, lisp.h (get_operating_system_release): Remove.
7322 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7323 worth the hassle of breaking this out.
7324
b532497d
PE
7325 * xterm.c: Make symbols static if they're not exported.
7326 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7327 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7328 (x_destroy_window, x_delete_display):
7329 Now static.
7330 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7331 (x_mouse_leave): Remove; unused.
7332 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7333 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7334 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7335 Remove decls.
7336 (x_mouse_leave): Declare only if WINDOWSNT.
7337 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7338 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7339 USE_X_TOOLKIT.
7340
1675728f
PE
7341 * ftxfont.c: Make symbols static if they're not exported.
7342 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7343 HAVE_FREETYPE.
7344 * font.h (ftxfont_driver): Likewise.
7345
e4cebfca
PE
7346 * xfns.c: Make symbols static if they're not exported.
7347 (x_last_font_name, x_display_info_for_name):
7348 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7349 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7350 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7351 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7352 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7353 (last_show_tip_args): Now static.
7354 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7355 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7356 (x_screen_planes): Remove; unused.
7357 * dispextern.h (x_screen_planes): Remove decl.
7358
5bf46f05
PE
7359 * dispnew.c: Make symbols static if they're not exported.
7360 * dispextern.h (redraw_garbaged_frames, scrolling):
7361 (increment_row_positions): Remove.
7362 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7363 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7364 Now static.
7365 (redraw_garbaged_frames): Remove; unused.
7366
435f4c28
PE
7367 * xfaces.c: Make symbols static if they're not exported.
7368 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7369 Remove decls.
7370 * xterm.h (defined_color): Remove decls.
7371 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7372 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7373 (menu_face_changed_default, defined_color, free_realized_face):
7374 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7375 (ascii_face_of_lisp_face): Remove; unused.
7376
8524aef3
PE
7377 * xdisp.c: Make symbols static if they're not exported.
7378 * dispextern.h (scratch_glyph_row, window_box_edges):
7379 (glyph_to_pixel_coords, set_cursor_from_row):
7380 (get_next_display_element, set_iterator_to_next):
7381 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7382 (show_mouse_face): Remove decls
7383 * frame.h (message_buf_print): Likewise.
7384 * lisp.h (pop_message, set_message, check_point_in_composition):
7385 Likewise.
7386 * xterm.h (set_vertical_scroll_bar): Likewise.
7387 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7388 (message_buf_print, scratch_glyph_row, displayed_buffer):
7389 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7390 (get_next_display_element, show_mouse_face, window_box_edges):
7391 (frame_to_window_pixel_xy, check_point_in_composition):
7392 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7393 (glyph_to_pixel_coords): Remove; unused.
7394
16390cd2
PE
7395 * dired.c (file_name_completion): Now static.
7396
7397 * dbusbind.c (xd_in_read_queued_messages): Now static.
7398
a25f4dfa
PE
7399 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7400 * data.c (circular_list_error): Remove.
7401
14a9c8df
PE
7402 * commands.h (last_point_position, last_point_position_buffer):
7403 (last_point_position_window): Remove decls.
7404 * keyboard.c: Make these variables static.
7405
04f2d78b
CB
7406 * coding.h (coding, code_convert_region, encode_coding_gap):
7407 Remove decls.
74ab6df5
PE
7408 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7409 (iso_code_class, detect_coding, code_convert_region): Now static.
7410 (encode_coding_gap): Remove; unused.
7411
38dfbee1
PE
7412 * chartab.c (chartab_chars, chartab_bits): Now static.
7413
a2cb4e63
PE
7414 * charset.h (charset_iso_8859_1): Remove decl.
7415 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7416 Now static.
7417
127198fd
PE
7418 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7419 * ccl.c (Vccl_program_table): Now static.
7420 (check_ccl_update): Remove; unused.
7421
d85b608f
PE
7422 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7423 * category.h: ... from here.
7424 * category.c (check_category_table, set_category_set): Now static.
7425
31cd66f3
PE
7426 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7427 * lisp.h: Remove these decls.
7428
c358e587
PE
7429 * buffer.c (buffer_count): Remove unused var.
7430
e78aecca
PE
7431 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7432 so that it's not optimized away.
7433 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7434 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7435 exported only to the debugger.
7436
e192d7d3 7437 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7438 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7439
92470028
PE
7440 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7441 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7442 was inaccessible from Lisp.
7443 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7444 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7445
244ed907
PE
7446 alloc.c: Import and export fewer symbols, and remove unused items.
7447 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7448 is defined.
7449 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7450 it's not optimized away by whole-program optimization.
7451 (message_enable_multibyte, free_misc): Remove.
7452 (catchlist, handlerlist, mark_backtrace):
7453 Declare only if BYTE_MARK_STACK.
7454 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7455 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7456 (message_enable_multibyte): Remove decl.
7457 (free_misc, interval_free_list, float_block, float_block_index):
7458 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7459 (cons_free_list, last_marked_index):
7460 Now static.
7461 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7462 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7463 (mark_backtrace): Define only if BYTE_MARK_STACK.
7464 * xdisp.c (message_enable_multibyte): Now static.
7465
61c2b50e 7466 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7467 This makes it easier for human readers (and static analyzers)
7468 to see whether these variables are used from other modules.
7469 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7470 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7471 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7472 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7473 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7474 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7475 * xmenu.c, xselect.c:
7476 Declare Q* vars static if they are not used in other modules.
7477 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7478 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7479 Remove decls of unexported vars.
7480 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7481
95c82688
PE
7482 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7483
16a97296
PE
7484 Make Emacs functions such as Fatom 'static' by default.
7485 This makes it easier for human readers (and static analyzers)
7486 to see whether these functions can be called from other modules.
7487 DEFUN now defines a static function. To make the function external
7488 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7489 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7490 (Finit_image_library):
16a97296
PE
7491 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7492 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7493 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7494 Remove decls, since these functions are now static.
7495 (Funintern, Fget_internal_run_time): New decls, since these functions
7496 were already external.
95c82688 7497
16a97296
PE
7498 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7499 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7500 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7501 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7502 * keyboard.c, keymap.c, lread.c:
7503 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7504 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7505 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7506 Mark functions with DEFUE instead of DEFUN,
7507 if they are used in other modules.
7508 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7509 decls for now-static functions.
7510 * buffer.h (Fdelete_overlay): Remove decl.
7511 * callproc.c (Fgetenv_internal): Mark as internal.
7512 * composite.c (Fremove_list_of_text_properties): Remove decl.
7513 (Fcomposition_get_gstring): New forward static decl.
7514 * composite.h (Fcomposite_get_gstring): Remove decl.
7515 * dired.c (Ffile_attributes): New forward static decl.
7516 * doc.c (Fdocumntation_property): New forward static decl.
7517 * eval.c (Ffetch_bytecode): New forward static decl.
7518 (Funintern): Remove extern decl; now in .h file where it belongs.
7519 * fileio.c (Fmake_symbolic_link): New forward static decl.
7520 * image.c (Finit_image_library): New forward static decl.
7521 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7522 * intervals.h (Fprevious_property_change):
7523 (Fremove_list_of_text_properties): Remove decls.
7524 * keyboard.c (Fthis_command_keys): Remove decl.
7525 (Fcommand_execute): New forward static decl.
7526 * keymap.c (Flookup_key): New forward static decl.
7527 (Fcopy_keymap): Now static.
7528 * keymap.h (Flookup_key): Remove decl.
7529 * process.c (Fget_process): New forward static decl.
7530 (Fprocess_datagram_address): Mark as internal.
7531 * syntax.c (Fsyntax_table_p): New forward static decl.
7532 (skip_chars): Remove duplicate decl.
7533 * textprop.c (Fprevious_property_change): New forward static decl.
7534 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7535 Now internal.
7536 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7537 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7538
785bbd42
PE
7539 * editfns.c (Fformat): Remove unreachable code.
7540
8b913b57
AS
75412011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7542
7543 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7544 change. (Bug#8496)
7545
a6744a35
EZ
75462011-04-13 Eli Zaretskii <eliz@gnu.org>
7547
7548 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7549 when at ZV. (Bug#8487)
7550
e7974947
AS
75512011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7552
baad03f0
AS
7553 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7554 (Bug#8437)
7555 * keyboard.c (parse_tool_bar_item): Likewise.
7556 * sound.c (sound_cleanup, alsa_close): Likewise.
7557 * termcap.c (tgetent): Likewise.
7558 * xfns.c (x_default_font_parameter): Likewise.
7559 * xsettings.c (read_and_apply_settings): Likewise.
7560
e7974947
AS
7561 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7562 (overrun_check_free): Protoize.
7563
28272684
PE
75642011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7565
7566 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7567 since callers should never pass a negative size.
7568 Change the signature to match that of plain 'read' and 'write'; see
7569 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7570 * lisp.h: Update prototypes of emacs_write and emacs_read.
7571
11997c76
EZ
75722011-04-11 Eli Zaretskii <eliz@gnu.org>
7573
7574 * xdisp.c (redisplay_window): Don't try to determine the character
7575 position of the scroll margin if the window start point w->startp
e896f03c 7576 is outside the buffer's accessible region. (Bug#8468)
11997c76 7577
8a2cbd72
EZ
75782011-04-10 Eli Zaretskii <eliz@gnu.org>
7579
7580 Fix write-region and its subroutines for buffers > 2GB.
7581 * fileio.c (a_write, e_write): Modify declaration of arguments and
7582 local variables to support buffers larger than 2GB.
7583 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7584
7585 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7586 argument, local variables, and return value.
7587
7588 * lisp.h: Update prototypes of emacs_write and emacs_read.
7589
7590 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7591
4073e537 75922011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7593
1ebfdcb6
PE
7594 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7595
b2ded58d
PE
7596 Fix more problems found by GCC 4.6.0's static checks.
7597
7d66342c
PE
7598 * xdisp.c (vmessage): Use a better test for character truncation.
7599
bbf47d44
PE
7600 * charset.c (load_charset_map): <, not <=, for optimization,
7601 and to avoid potential problems with integer overflow.
9248994d 7602 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7603 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7604 * editfns.c (Fformat): Likewise.
1e69125e 7605 * syntax.c (skip_chars): Likewise.
3befa583 7606
e3019616
PE
7607 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7608 This also lets GCC 4.6.0 generate slightly better loop code.
7609
becfa255
PE
7610 * callint.c (Fcall_interactively): <, not <=, for optimization.
7611 (Fcall_interactively): Count the number of arguments produced,
7612 not the number of arguments given. This is simpler and lets GCC
7613 4.6.0 generate slightly better code.
7614
dae0cd48
PE
7615 * ftfont.c: Distingish more carefully between FcChar8 and char.
7616 The previous code passed unsigned char * to a functions like
7617 strlen and xstrcasecmp that expect char *, which does not
7618 conform to the C standard.
7619 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7620 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7621 char * when the C standard requires it.
7622
76032d70
PE
7623 * keyboard.c (read_char): Remove unused var.
7624
eb3f1cc8
PE
7625 * eval.c: Port to Windows vsnprintf (Bug#8435).
7626 Include <limits.h>.
7627 (SIZE_MAX): Define if the headers do not.
7628 (verror): Do not give up if vsnprintf returns a negative count.
7629 Instead, grow the buffer. This ports to Windows vsnprintf, which
7630 does not conform to C99. Problem reported by Eli Zaretskii.
7631 Also, simplify the allocation scheme, by avoiding the need for
7632 calling realloc, and removing the ALLOCATED variable.
7633
70476b54
PE
7634 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7635
12020a9e
PE
7636 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7637 But keep the doprint source code for now, as we might revamp it
7638 and use it again (Bug#8435).
ea6c7ae6
PE
7639 * lisp.h (doprnt): Remove.
7640 * Makefile.in (base_obj): Remove doprnt.o.
7641 * deps.mk (doprnt.o): Remove.
7642
5fdb398c
PE
7643 error: Print 32- and 64-bit integers portably (Bug#8435).
7644 Without this change, on typical 64-bit hosts error ("...%d...", N)
7645 was used to print both 32- and 64-bit integers N, which relied on
7646 undefined behavior.
7647 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7648 New macro.
7649 * lisp.h (error, verror): Mark as printf-like functions.
7650 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7651 Report overflow in size calculations when allocating printf buffer.
7652 Do not truncate output string at its first null byte.
7653 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7654 Truncate the output at a character boundary, since vsnprintf does not
7655 do that.
7656 * charset.c (check_iso_charset_parameter): Convert internal
7657 character to string before calling 'error', since %c now has the
7658 printf meaning.
7659 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7660 overflow when computing char to be passed to 'error'. Do not
7661 pass Lisp_Object to 'error'; pass the integer instead.
7662 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7663 formatted with plain %d.
7664
b189fa66
PE
7665 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7666
bff87ef0
PE
7667 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7668
7e2cac20
PE
7669 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7670
ce4d90b5
PE
7671 * xterm.c (x_catch_errors): Remove duplicate declaration.
7672
266c9547
PE
7673 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7674
79c49ad2
PE
7675 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7676
368f4090
JM
76772011-04-10 Jim Meyering <meyering@redhat.com>
7678
7679 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7680 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7681 return ssize_t not "int", and use size_t as the buffer length.
7682 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7683 * gnutls.h: Update declarations.
7684 * process.c (read_process_output): Use ssize_t, to match.
7685 (send_process): Likewise.
7686
a32d4040
CY
76872011-04-09 Chong Yidong <cyd@stupidchicken.com>
7688
7689 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7690
8546720e 76912011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7692
04f2d78b
CB
7693 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7694 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7695
8546720e
GM
7696 * xterm.c (handle_one_xevent):
7697 * xmenu.c (create_and_show_popup_menu):
7698 * xselect.c (x_decline_selection_request)
7699 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7700
0a2f5c1a 77012011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7702
7703 Fix some uses of `int' instead of EMACS_INT.
7704 * search.c (string_match_1, fast_string_match)
7705 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7706 (scan_buffer, find_next_newline_no_quit)
7707 (find_before_next_newline, search_command, Freplace_match)
7708 (Fmatch_data): Make some `int' variables be EMACS_INT.
7709
7710 * xdisp.c (display_count_lines): 3rd argument and return value now
7711 EMACS_INT. All callers changed.
7712 (pint2hrstr): Last argument is now EMACS_INT.
7713
7714 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7715 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7716 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7717 (decode_coding_utf_16, decode_coding_emacs_mule)
7718 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7719 (decode_coding_ccl, decode_coding_charset)
7720 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7721 (decode_coding_iso_2022, decode_coding_emacs_mule)
7722 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7723 <char_offset, last_offset>: Declare EMACS_INT.
7724 (encode_coding_utf_8, encode_coding_utf_16)
7725 (encode_coding_emacs_mule, encode_invocation_designation)
7726 (encode_designation_at_bol, encode_coding_iso_2022)
7727 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7728 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7729 Declare EMACS_INT.
7730 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7731 (encode_invocation_designation): Last argument P_NCHARS is now
7732 EMACS_INT.
7733 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7734 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7735
7736 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7737 All users changed.
7738
7739 * ccl.c (Fccl_execute_on_string): Declare some variables
7740 EMACS_INT.
7741
8546720e 77422011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7743
7744 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7745
4e19a977
CS
77462011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7747
7748 * process.c (Fformat_network_address): Doc fix.
7749
87302331
R
77502011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7751
ee7683eb 7752 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7753
cbb59342
CY
77542011-04-08 Chong Yidong <cyd@stupidchicken.com>
7755
7756 * keyboard.c (read_char): Call Lisp function help-form-show,
7757 instead of using internal_with_output_to_temp_buffer.
7758 (Qhelp_form_show): New var.
e0d38eeb 7759 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7760
7761 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7762
7763 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7764
e67a13ab
CY
77652011-04-06 Chong Yidong <cyd@stupidchicken.com>
7766
04f2d78b
CB
7767 * process.c (Flist_processes): Remove to Lisp.
7768 (list_processes_1): Delete.
e67a13ab 7769
973f782d
EZ
77702011-04-06 Eli Zaretskii <eliz@gnu.org>
7771
7c106b1e
EZ
7772 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7773
973f782d
EZ
7774 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7775
41cf7d1a 77762011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7777
ca23cc88
PE
7778 Fix more problems found by GCC 4.6.0's static checks.
7779
f390e2d5
PE
7780 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7781
42eea0d0
PE
7782 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7783
b69769da 7784 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7785
f9541e84
PE
7786 * xdisp.c (vmessage): Mark as a printf-like function.
7787
13841b55
PE
7788 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7789
c136c10f
PE
7790 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7791
5e2d4a30
PE
7792 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7793 printf-like functions.
7794 (tiff_load): Add casts to remove these marks before passing them
7795 to system-supplied API.
7796
583f48b9
PE
7797 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7798
b25d760e
PE
7799 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7800 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7801 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7802 directly, rather than having caller test rule sign. This avoids
7803 some unnecessary tests.
7804 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7805 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7806 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7807
bc7b6697 7808 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7809 (xfont_open): Avoid unnecessary tests.
bc7b6697 7810
27ccc379
PE
7811 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7812
dcd5c89a
PE
7813 * composite.h, composite.c (composition_gstring_put_cache):
7814 Use EMACS_INT, not int, for length.
7815
b13a45c6
PE
7816 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7817 breaking out part of COMPOSITION_DECODE_RULE.
7818 (COMPOSITION_DECODE_RULE): Use it.
7819 * composite.c (get_composition_id): Remove unused local vars,
7820 by using the new macro.
7821
1e792e4d
PE
7822 * textprop.c (set_text_properties_1): Change while to do-while,
7823 since the condition is always true at first.
7824
dc6c6455 7825 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7826 (interval_deletion_adjustment): Return unsigned value.
7827 All uses changed.
dc6c6455 7828
aba7731a
PE
7829 * process.c (list_processes_1, create_pty, read_process_output):
7830 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7831 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7832 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7833 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7834 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7835
fdfc4bf3
PE
7836 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7837
fca8fe46 7838 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7839 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7840
06a0259a 7841 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7842 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7843 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7844
e7b9e80f
PE
7845 * print.c (print_error_message): Avoid int overflow.
7846
56201685
PE
7847 * font.c (font_list_entities): Redo for clarity,
7848 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7849
78834453 7850 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7851 (font_score): Avoid potential overflow in diff calculation.
78834453 7852
0bc0b309 7853 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7854 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7855
e610eaca
PE
7856 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7857
b895abce
PE
7858 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7859 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7860 can always succeed if overflow has undefined behavior.
7861
1f1d9321 7862 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7863 (wordify): Omit three unnecessary tests.
1f1d9321 7864
c59478bc
PE
7865 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7866 All callers changed. This avoids the need for an unused var.
7867
79b73827
PE
7868 * casefiddle.c (casify_region): Remove var that is set but not used.
7869
a4db5dfe
PE
7870 * dired.c (file_name_completion): Remove var that is set but not used.
7871
43aae36e
PE
7872 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7873
2a47c44d 7874 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7875 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7876
a37c69bf
PE
7877 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7878 Check for integer overflow on size calculations.
7879
328ab8e7
PE
7880 * buffer.c (Fprevious_overlay_change): Remove var that is set
7881 but not used.
7882
e5a2a5cb
PE
7883 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7884 Remove vars that are set but not used.
8d84a6eb 7885 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7886 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7887
a60e5f68
PE
7888 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7889
f661cb61 7890 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7891 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7892
f0397f5a
PE
7893 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7894 that are set but not used.
7895
8664db06 7896 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7897 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7898
6abdaa4a
PE
7899 * xselect.c (x_get_local_selection, x_handle_property_notify):
7900 Remove vars that are set but not used.
7901
0ce7538d 7902 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7903 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7904
9ae848fc
PE
7905 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7906 Remove var that is set but not used.
0b918413
PE
7907 (scroll_bar_windows_size): Now size_t, not int.
7908 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7909 Check for overflow.
9ae848fc 7910
a5a62657
PE
7911 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7912 (map_tty_color) [!defined MSDOS]: Likewise.
7913
5c5cdd39
PE
7914 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7915
66ebf983
PE
7916 * coding.c: Remove vars that are set but not used.
7917 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7918 All callers changed.
7919 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7920 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7921 (decode_coding_charset): Remove vars that are set but not used.
7922
1be4d761
PE
7923 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7924 that is set but not used.
7925
47553fa8
PE
7926 * print.c (print_object): Remove var that is set but not used.
7927
1f7196bf 7928 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7929 The gnulib version avoids calling malloc in the usual case,
7930 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7931 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7932 * filelock.c (current_lock_owner): Likewise.
7933 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7934 * sysdep.c: Include allocator.h, careadlinkat.h.
7935 (emacs_no_realloc_allocator): New static constant.
7936 (emacs_readlink): New function.
fdb61804
PE
7937 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7938 ../lib/careadlinkat.h.
d1fdcab7 7939
f84c17c7
SM
79402011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7941
7942 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7943 first non-nil return value).
7944
ef3862ad
JD
79452011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7946
7947 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7948 if not defined (Bug#8403).
7949
376a7006
JB
79502011-04-02 Juanma Barranquero <lekktu@gmail.com>
7951
7952 * xdisp.c (display_count_lines): Remove parameter `start',
7953 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7954 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7955 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7956 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7957 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7958 and thereabouts. All callers changed.
7959 (get_per_char_metric): Remove parameter `f', unused since
7960 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7961
6ca3801d
JM
79622011-04-02 Jim Meyering <meyering@redhat.com>
7963
7964 do not dereference NULL upon failed strdup
7965 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7966 (ns_get_family): Likewise.
7967
d8e2b5ba
JB
79682011-04-02 Juanma Barranquero <lekktu@gmail.com>
7969
7970 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7971
8c74fcbd
JD
79722011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7973
7974 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7975 later (Bug#8403).
7976
7200d79c
SM
79772011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7978
03408648 7979 Add lexical binding.
7200d79c 7980
03408648
SM
7981 * window.c (Ftemp_output_buffer_show): New fun.
7982 (Fsave_window_excursion):
7983 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7984
7985 * lread.c (lisp_file_lexically_bound_p): New function.
7986 (Fload): Bind Qlexical_binding.
7987 (readevalloop): Remove `evalfun' arg.
7988 Bind Qinternal_interpreter_environment.
7989 (Feval_buffer): Bind Qlexical_binding.
7990 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7991 Mark as dynamic.
7992 (syms_of_lread): Declare `lexical-binding'.
7993
7994 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7995
7996 * keyboard.c (eval_dyn): New fun.
7997 (menu_item_eval_property): Use it.
ca105506
SM
7998
7999 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8000
03408648
SM
8001 * fns.c (concat, mapcar1): Accept byte-code-functions.
8002
8003 * eval.c (Fsetq): Handle lexical vars.
8004 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8005 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8006 (FletX, Flet): Obey lexical binding.
8007 (Fcommandp): Handle closures.
8008 (Feval): New `lexical' arg.
8009 (eval_sub): New function extracted from Feval. Use it almost
8010 everywhere where Feval was used. Look up vars in lexical env.
8011 Handle closures.
8012 (Ffunctionp): Move from subr.el.
8013 (Ffuncall): Handle closures.
8014 (apply_lambda): Remove `eval_flags'.
8015 (funcall_lambda): Handle closures and new byte-code-functions.
8016 (Fspecial_variable_p): New function.
8017 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8018 but without exporting it to Lisp.
23aba0ea 8019
23aba0ea 8020 * doc.c (Fdocumentation, store_function_docstring):
03408648 8021 * data.c (Finteractive_form): Handle closures.
23aba0ea 8022
03408648
SM
8023 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8024 interactive spec.
ba83908c 8025
04f2d78b
CB
8026 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8027 New byte-codes.
03408648
SM
8028 (exec_byte_code): New function extracted from Fbyte_code to handle new
8029 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8030
03408648 8031 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8032
03408648 8033 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8034
e2abce01
JB
80352011-03-31 Juanma Barranquero <lekktu@gmail.com>
8036
8037 * xdisp.c (redisplay_internal): Fix prototype.
8038
63696a73 80392011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8040
63696a73 8041 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8042 (try_scrolling): Use it when setting scroll_limit.
8043 Limit scrolling to 100 screen lines.
63696a73
EZ
8044 (redisplay_window): Even when falling back on "recentering",
8045 position point in the window according to scroll-conservatively,
8046 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8047
8048 (try_scrolling): When point is above the window, allow searching
8049 as far as scroll_max, or one screenful, to compute vertical
8050 distance from PT to the scroll margin position. This prevents
8051 try_scrolling from unnecessarily failing when
8052 scroll-conservatively is set to a value slightly larger than the
8053 window height. Clean up the case of PT below the margin at bottom
8054 of window: scroll_max can no longer be INT_MAX. When aggressive
8055 scrolling is in use, don't let point enter the opposite scroll
8056 margin as result of the scroll.
8057 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8058 threshold of 100 lines for never-recentering scrolling.
8059
e4cc2dfc
JB
80602011-03-31 Juanma Barranquero <lekktu@gmail.com>
8061
8062 * dispextern.h (move_it_by_lines):
8063 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8064 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8065 (message_log_check_duplicate): Remove parameters `prev_bol' and
8066 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8067 (redisplay_internal): Remove parameter `preserve_echo_area',
8068 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8069
8070 * indent.c (Fvertical_motion):
8071 * window.c (window_scroll_pixel_based, Frecenter):
8072 Don't pass `need_y_p' to `move_it_by_lines'.
8073
1c470562
SM
80742011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8075
44f230aa
SM
8076 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8077 steal a few bits to be more compact.
8078 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8079 Remove unneeded casts.
8080
1c470562
SM
8081 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8082
888adce9
ZK
80832011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8084
8085 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8086 binding" message (bug#7967).
8087
f838ed7b
PE
80882011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8089
77861b95
PE
8090 Fix more problems found by GCC 4.6.0's static checks.
8091
de6dbc14
PE
8092 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8093 Remove unused local var.
8094
f838ed7b
PE
8095 * editfns.c (Fmessage_box): Remove unused local var.
8096
792c7b2b
PE
8097 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8098 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8099 Omit unused local vars.
c499e557 8100 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8101 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8102 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8103 Omit unused local var.
8104
ba0165e1
PE
8105 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8106 Don't assume string length fits in int.
32ad8845 8107 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8108 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8109
3c59b4c9
PE
8110 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8111 instead of alloca (Bug#8344).
8112
a3eed478 8113 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8114 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8115
eb4d412d
PE
8116 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8117
1658b401
PE
8118 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8119 concerns.
8120
8121 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8122
8123 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8124
9a2c6e05
PE
8125 * keyboard.c (syms_of_keyboard): Use the same style as later
8126 in this function when indexing through an array. This also
8127 works around GCC bug 48267.
8128
03d0a109
PE
8129 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8130
44f730c8
PE
8131 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8132
fe75f926
PE
8133 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8134 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8135
ffa8c828
PE
8136 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8137 This avoids undefined behavior on integer overflow, and is a bit
8138 more convenient anyway since it is compared to a size_t variable.
8139
c5101a77
PE
8140 Variadic C functions now count arguments with size_t, not int.
8141 This avoids an unnecessary limitation on 64-bit machines, which
8142 caused (substring ...) to crash on large vectors (Bug#8344).
8143 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8144 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8145 All variadic functions and their callers changed accordingly.
c5101a77
PE
8146 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8147 * data.c (arith_driver, float_arith_driver): Likewise.
8148 * editfns.c (general_insert_function): Likewise.
8149 * eval.c (struct backtrace.nargs, interactive_p)
8150 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8151 (funcall_lambda, mark_backtrace): Likewise.
8152 * fns.c (concat): Likewise.
8153 * frame.c (x_set_frame_parameters): Likewise.
8154 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8155 0 if not found, not -1. All callers changed.
8156
dd3f25f7
PE
8157 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8158 (stack_copy_size): Now size_t, not int.
8159 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8160
461c2ab9
JB
81612011-03-28 Juanma Barranquero <lekktu@gmail.com>
8162
8163 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8164 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8165 All callers changed.
8166
8167 * lisp.h (multibyte_char_to_unibyte):
8168 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8169 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8170 * character.h (CHAR_TO_BYTE8):
8171 * cmds.c (internal_self_insert):
8172 * editfns.c (general_insert_function):
8173 * keymap.c (push_key_description):
8174 * search.c (Freplace_match):
8175 * xdisp.c (message_dolog, set_message_1): All callers changed.
8176
f6d62986
SM
81772011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8178
8179 * keyboard.c (safe_run_hook_funcall): New function.
8180 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8181 don't set the hook to nil, but remove the offending function instead.
8182 (Qcommand_hook_internal): Remove, unused.
8183 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8184 Vcommand_hook_internal.
8185
8186 * eval.c (enum run_hooks_condition): Remove.
8187 (funcall_nil, funcall_not): New functions.
8188 (run_hook_with_args): Call each function through a `funcall' argument.
8189 Remove `cond' argument, now redundant.
8190 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8191 (Frun_hook_with_args_until_failure): Adjust accordingly.
8192 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8193
1db5b1ad
JB
81942011-03-28 Juanma Barranquero <lekktu@gmail.com>
8195
8196 * dispextern.h (string_buffer_position): Remove declaration.
8197
8198 * print.c (strout): Remove parameter `multibyte', unused since
8199 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8200
8201 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8202 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8203 All callers changed.
8204
8205 * w32.c (_wsa_errlist): Use braces for struct initializers.
8206
8207 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8208 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8209 All callers changed.
8210 (string_buffer_position): Likewise. Also, make static (it's never
8211 used outside xdisp.c).
8212 (cursor_row_p): Remove parameter `w', unused since
8213 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8214 (decode_mode_spec): Remove parameter `precision', introduced during
8215 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8216 All callers changed.
8217
5ffb62aa
JD
82182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8219
8220 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8221
461c2ab9 82222011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8223
8224 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8225 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8226 (ns_update_auto_hide_menu_bar): New functions.
8227 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8228 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8229 ns_constrain_all_frames.
8230 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8231 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8232
5c380ffb
JD
82332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8234
8235 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8236
9af30bdf
GM
82372011-03-27 Glenn Morris <rgm@gnu.org>
8238
8239 * syssignal.h: Replace RETSIGTYPE with void.
8240 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8241 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8242 Replace SIGTYPE with void everywhere.
8243 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8244 * s/template.h (SIGTYPE): Remove commented out definition.
8245
e2abce01
JB
82462011-03-26 Eli Zaretskii <eliz@gnu.org>
8247
8248 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8249 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8250
f868cd8a
JB
82512011-03-26 Juanma Barranquero <lekktu@gmail.com>
8252
59eb0929
JB
8253 * w32.c (read_unc_volume): Use parameter `henum', instead of
8254 global variable `wget_enum_handle'.
8255
8256 * keymap.c (describe_vector): Remove parameters `indices' and
8257 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8258 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8259
f868cd8a
JB
8260 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8261
8262 * keyboard.c (timer_check): Remove parameter `do_it_now',
8263 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8264 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8265 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8266
8267 * keyboard.c (read_char):
8268 * w32menu.c (w32_menu_display_help):
8269 * xmenu.c (show_help_event, menu_help_callback):
8270 Adjust calls to `show_help_echo'.
8271
8272 * gtkutil.c (xg_maybe_add_timer):
8273 * keyboard.c (readable_events):
8274 * process.c (wait_reading_process_output):
8275 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8276
8277 * insdel.c (adjust_markers_gap_motion):
8278 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8279 (gap_left, gap_right): Don't call it.
8280
2ecf6fdb
CY
82812011-03-25 Chong Yidong <cyd@stupidchicken.com>
8282
8283 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8284 incurred during fontification.
8285
6b1f9ba4
JB
82862011-03-25 Juanma Barranquero <lekktu@gmail.com>
8287
8288 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8289 (DEFVAR_PER_BUFFER): Don't pass it.
8290
8291 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8292 (scrolling_window): Don't pass it.
8293
0f4a96b5
JB
82942011-03-25 Juanma Barranquero <lekktu@gmail.com>
8295
8296 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8297
8298 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8299 and `suffix'.
8300 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8301 of variables specific to SELinux and computation of `encoded_absname'.
8302
8303 * image.c (XPutPixel): Remove unused variable `height'.
8304
8305 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8306
8307 * unexw32.c (get_section_info): Remove unused variable `section'.
8308
8309 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8310 (system_process_attributes): Remove unused variable `sess'.
8311 (sys_read): Remove unused variable `err'.
8312
8313 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8314 (w32_wnd_proc): Remove unused variable `isdead'.
8315 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8316 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8317 (x_create_tip_frame): Remove unused variable `tem'.
8318
8319 * w32inevt.c (w32_console_read_socket):
8320 Remove unused variable `no_events'.
8321
8322 * w32term.c (x_draw_composite_glyph_string_foreground):
8323 Remove unused variable `width'.
8324
1149507c
JB
83252011-03-24 Juanma Barranquero <lekktu@gmail.com>
8326
8327 * w32term.c (x_set_glyph_string_clipping):
8328 Don't pass uninitialized region to CombineRgn.
8329
9c88f339
JB
83302011-03-23 Juanma Barranquero <lekktu@gmail.com>
8331
8332 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8333 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8334 (Fx_close_connection): Remove unused variable `i'.
8335
8336 * w32font.c (w32font_draw): Return number of glyphs.
8337 (w32font_open_internal): Remove unused variable `i'.
8338 (w32font_driver): Add missing initializer.
8339
8340 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8341 (fill_in_menu): Remove unused variable `items_added'.
8342
8343 * w32term.c (last_mouse_press_frame): Remove static global variable.
8344 (w32_clip_to_row): Remove unused variable `f'.
8345 (x_delete_terminal): Remove unused variable `i'.
8346
8347 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8348 (NOTHING): Remove unused static global variable.
8349 (uniscribe_check_otf): Remove unused variable `table'.
8350 (uniscribe_font_driver): Add missing initializers.
8351
dee091a3
JD
83522011-03-23 Julien Danjou <julien@danjou.info>
8353
8354 * term.c (Fsuspend_tty, Fresume_tty):
8355 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8356 * window.c (temp_output_buffer_show):
8357 * insdel.c (signal_before_change):
8358 * frame.c (Fhandle_switch_frame):
8359 * fileio.c (Fdo_auto_save):
8360 * emacs.c (Fkill_emacs):
8361 * editfns.c (save_excursion_restore):
8362 * cmds.c (internal_self_insert):
8363 * callint.c (Fcall_interactively):
8364 * buffer.c (Fkill_all_local_variables):
8365 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8366 Use Frun_hooks.
0f4a96b5 8367 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8368 unconditionally since it does the check itself.
dee091a3 8369
2c520ab5 83702011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8371
c9c49752
PE
8372 Fix more problems found by GCC 4.5.2's static checks.
8373
8abc3f12
PE
8374 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8375 the first time through the loop, since we know p0 < p1 then.
8376 This also avoids a gcc -Wstrict-overflow warning.
8377
a2d26660
PE
8378 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8379 leading to a memory leak, possible in functions like
8380 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8381 of objects (Bug#8318).
a2d26660 8382
916c72e9
PE
8383 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8384 that could (at least in theory) be that large.
8385
19ab8a18
PE
8386 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8387 This is less likely to overflow, and avoids undefined behavior if
8388 overflow does occur. All callers changed. Use strtoul to scan
8389 for the unsigned long integer.
b7cbbd6f
PE
8390 (pint2hrstr): Simplify and tune code slightly.
8391 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8392
f0641eff
PE
8393 * scroll.c (do_scrolling): Work around GCC bug 48228.
8394 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8395
7f650bb9
PE
8396 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8397 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8398 (validate_x_resource_name): Simplify count usage.
8399 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8400
37dd57d1
PE
8401 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8402 fail (Bug#8306).
81e56e61 8403
699979fc 8404 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8405
401bf9b4
PE
8406 * process.c (Fmake_network_process): Use socklen_t, not int,
8407 where POSIX says socklen_t is required in portable programs.
8408 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8409 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8410 (Fmake_network_process, server_accept_connection):
8411 (wait_reading_process_output, read_process_output):
8412 Likewise.
8413
b93aacde
PE
8414 * process.c: Rename or move locals to avoid shadowing.
8415 (list_processes_1, Fmake_network_process):
8416 (read_process_output_error_handler, exec_sentinel_error_handler):
8417 Rename or move locals.
4dc343ee 8418 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8419 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8420 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8421 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8422 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8423
af8a867c 8424 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8425 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8426 Include tparam.h instead, since it declares them.
af8a867c
PE
8427 * cm.h (PC): Remove extern decl; tparam.h now does this.
8428 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8429 * terminfo.c: Include tparam.h, to check interfaces.
8430 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8431 (tparam): Adjust signature to match interface in tparam.h;
8432 this removes some undefined behavior. Check that outstring and len
8433 are zero, which they always are with Emacs.
8434 * tparam.h (PC, BC, UP): New extern decls.
8435
0248044d 8436 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8437 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8438
8ff096c1 8439 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8440 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8441 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8442 (ftfont_list): Remove unused local.
49eaafba
PE
8443 (get_adstyle_property, ftfont_pattern_entity):
8444 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8445 Rename locals to avoid shadowing.
8ff096c1 8446
e2be39f6
PE
8447 * xfont.c (xfont_list_family): Mark var as initialized.
8448
c9735e30
PE
8449 * xml.c (make_dom): Now static.
8450
8f5201ae
PE
8451 * composite.c (composition_compute_stop_pos): Rename local to
8452 avoid shadowing.
b246f932
PE
8453 (composition_reseat_it): Remove unused locals.
8454 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8455 (composition_update_it): Mark var as initialized.
11b61122
PE
8456 (find_automatic_composition): Mark vars as initialized,
8457 with a FIXME (Bug#8290).
8f5201ae 8458
760fbc2c
PE
8459 character.h: Rename locals to avoid shadowing.
8460 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8461 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8462 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8463 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8464 to avoid shadowing.
8465
ff08eb85
PE
8466 * textprop.c (property_change_between_p): Remove; unused.
8467
fc7bf025
PE
8468 * intervals.c (interval_start_pos): Now static.
8469
235d7abc
PE
8470 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8471
44f230aa
SM
8472 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8473 Rename locals to avoid shadowing.
3e7d6594 8474
50060332
PE
8475 * sound.c (wav_play, au_play, Fplay_sound_internal):
8476 Fix pointer signedness.
d01f234b 8477 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8478 (wav_play): Initialize a variable to 0, to prevent undefined
8479 behavior (Bug#8278).
50060332 8480
c4fc4e30
PE
8481 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8482
918436ed
PE
8483 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8484
c939f91b
PE
8485 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8486 clobbering (Bug#8298).
b9c7f648
PE
8487 * sysdep.c (sys_subshell): Likewise.
8488 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8489
6bd8c144
PE
8490 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8491 This should get cleaned up, so that child_setup has the
8492 same signature on all platforms.
8493
7710357c 8494 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8495 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8496
c59da222
CY
84972011-03-22 Chong Yidong <cyd@stupidchicken.com>
8498
8499 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8500 not to be necessary, and produces flickering.
8501
66b87493
GM
85022011-03-20 Glenn Morris <rgm@gnu.org>
8503
8504 * config.in: Remove file.
8505
45b6f6d5
JB
85062011-03-20 Juanma Barranquero <lekktu@gmail.com>
8507
8508 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8509 are now in src/globals.h.
8510 (syms_of_minibuf): Remove spurious & from previous change.
8511
cd394be1 85122011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8513
8514 * minibuf.c (completing-read-function): New variable.
8515 (completing-read-default): Rename from completing-read.
8516 (completing-read): Call completing-read-function.
8517
b14e3e21
CY
85182011-03-19 Juanma Barranquero <lekktu@gmail.com>
8519
8520 * xfaces.c (Fx_load_color_file):
8521 Read color file from absolute filename (bug#8250).
8522
f2b726e6
JB
85232011-03-19 Juanma Barranquero <lekktu@gmail.com>
8524
8525 * makefile.w32-in: Update dependencies.
8526
09f6ff02
EZ
85272011-03-17 Eli Zaretskii <eliz@gnu.org>
8528
8529 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8530
29a6015a
PE
85312011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8532
a3a6c54e
PE
8533 Fix more problems found by GCC 4.5.2's static checks.
8534
b766f867
PE
8535 * process.c (make_serial_process_unwind, send_process_trap):
8536 (sigchld_handler): Now static.
8537
be02381c
PE
8538 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8539 That way, the code declares only the vars that it needs.
8540 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8541 * s/cygwin.h (PTY_ITERATION): Likewise.
8542 * s/darwin.h (PTY_ITERATION): Likewise.
8543 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8544
57048744
PE
8545 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8546 * process.c (allocate_pty): Don't declare stb unless it's needed.
8547
7914961c 8548 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8549 (CONSTANTLIM): Remove; unused.
8550 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8551 Define only if needed.
7914961c 8552
b3967b18
PE
8553 * unexelf.c (unexec): Name an expression,
8554 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8555 Use a different way to cause a compilation error if anyone uses
8556 n rather than nn, a way that does not involve shadowing.
73366a00 8557 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8558
29a6015a
PE
8559 * deps.mk (unexalpha.o): Remove; unused.
8560
43cfc33e 8561 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8562 * unexec.h: New file.
ce701a33
PE
8563 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8564 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8565 Depend on unexec.h.
8566 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8567 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8568 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8569 Change as necessary to match prototype in unexec.h.
ce701a33 8570
01f44d5a
PE
8571 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8572 shadowing.
4f63c6bb 8573 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8574
a6670b0b
PE
8575 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8576 Rename locals to avoid shadowing.
8577
cef2010d 8578 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8579 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8580
d4d7173a
PE
8581 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8582
f08b802a
PE
8583 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8584 warning when compiling print.c.
8585
3ddb0639
PE
8586 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8587 instead of using an uninitialized var.
5ad03b97 8588 (font_sort_entities): Mark var as initialized.
3ddb0639 8589
170a2692
PE
8590 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8591
e663c700
PE
8592 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8593 pointers to constants.
89bc529a 8594 (font_parse_fcname): Remove unused vars.
7b81e2d0 8595 (font_delete_unmatched): Now static.
ea838e10 8596 (font_get_spec): Remove; unused.
13a547c6
PE
8597 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8598 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8599 Rename or move locals to avoid shadowing.
e663c700 8600
2a80c887 8601 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8602 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8603
1384fa33 8604 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8605 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8606
8b2c52e9
PE
8607 * alloc.c (mark_backtrace): Move decl from here ...
8608 * lisp.h: ... to here, so that it can be checked.
8609
475545b5 8610 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8611 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8612 (lisp_indirect_variable): Name an expression,
8613 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8614 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8615
b1349114 8616 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8617 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8618 Use const pointer when appropriate.
b1349114 8619
a2928364
PE
8620 * lisp.h (get_system_name, get_operating_system_release):
8621 Move decls here, to check interfaces.
8622 * process.c (get_operating_system_release): Move decl to lisp.h.
8623 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8624 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8625 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8626 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8627 (Fformat_time_string, Fencode_time, Finsert_char):
8628 (Ftranslate_region_internal, Fformat):
8629 Rename or remove local vars to avoid shadowing.
9710023e 8630 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8631
a415e694
PE
8632 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8633 avoid shadowing.
8634
8ef4622d
PE
8635 * lisp.h (eassert): Check that the argument compiles, even if
8636 ENABLE_CHECKING is not defined.
8637
946f9a5b
PE
8638 * data.c (Findirect_variable): Name an expression, to avoid
8639 gcc -Wbad-function-cast warning.
112396d6 8640 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8641 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8642 (Fmake_variable_buffer_local, Fmake_local_variable):
8643 Mark variables as initialized.
52746918 8644 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8645
e5aab7e7 8646 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8647 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8648 Rename locals to avoid shadowing.
dff45157
PE
8649 (mark_stack): Move local variables into the #ifdef region where
8650 they're used.
7bc26fdb
PE
8651 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8652 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8653 needed otherwise.
8654 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8655 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8656 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8657
e5aab7e7
PE
8658 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8659 avoids undefined behavior in theory.
8660
4da60324
PE
8661 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8662
88043301
PE
8663 Use functions, not macros, for up- and down-casing (Bug#8254).
8664 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8665 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8666 to use the following functions instead of these macros.
8667 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8668 EMACS_INT, since callers assume the returned value fits in int.
8669 (upcase1): Likewise, for UPCASE_TABLE.
8670 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8671 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8672 the race-condition problem in the old DOWNCASE.
88043301 8673
19ed5445
PE
8674 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8675 Rename locals to avoid shadowing.
8676 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8677 (regex_compile, re_search_2, re_match_2_internal):
8678 Remove unused local vars.
952db0d7
PE
8679 (FREE_VAR): Rewrite so as not to use empty "else",
8680 which gcc can warn about.
da053e48 8681 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8682 (RETALLOC_IF): Define only if needed.
8683 (WORDCHAR_P): Likewise. This one is never needed, but is used
8684 only in a comment talking about a compiler bug, so put inside
8685 the #if 0 of that comment.
8686 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8687 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8688 Remove; unused.
19ed5445 8689
1f3561e4 8690 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8691 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8692 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8693
ded6f8f7
PE
8694 * search.c (simple_search): Remove unused var.
8695
dbd37a95
PE
8696 * dired.c (compile_pattern): Move decl from here ...
8697 * lisp.h: ... to here, so that it can be checked.
8698 (struct re_registers): New forward decl.
8699
7e47afad
PE
8700 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8701
85f24f61
PE
8702 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8703 All uses changed.
8704 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8705 Rename locals to avoid shadowing.
5671df8f 8706 (Fvertical_motion): Mark locals as initialized.
85f24f61 8707
181aa2be 8708 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8709 (casify_region): Mark local as initialized.
181aa2be 8710
930d429c
PE
8711 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8712
7082eac6
PE
8713 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8714 New macros, so that the caller can use some names other than
8715 gcpro1, gcpro2, etc.
8716 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8717 of the new macros.
8718 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8719 argument, for consistency with GCPRO2_VAR, etc: it is now the
8720 prefix of the variable, not the variable itself. All uses
8721 changed.
38b2c076
PE
8722 * dired.c (directory_files_internal, file_name_completion):
8723 Rename locals to avoid shadowing.
8724
15206ed9
PE
8725 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8726 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8727 dired.c's scmp function, had undefined behavior.
8728 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8729 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8730 * buffer.h: ... to here, because these macros use current_buffer,
8731 and the new implementation with inline functions needs to have
8732 current_buffer in scope now, rather than later when the macros
8733 are used.
8734 (downcase, upcase1): New static inline functions.
8735 (DOWNCASE, UPCASE1): Reimplement using these functions.
8736 This avoids undefined behavior in expressions like
8737 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8738 from race conditions in accessing the global variables
8739 case_temp1 and case_temp2.
8740 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8741 * lisp.h (case_temp1, case_temp2): Remove their decls.
8742 * character.h (ASCII_CHAR_P): Move from here ...
8743 * lisp.h: ... to here, so that the inline functions mentioned
8744 above can use them.
8745
4a6bea26
PE
8746 * dired.c (directory_files_internal_unwind): Now static.
8747
f14b7e14
PE
8748 * fileio.c (file_name_as_directory, directory_file_name):
8749 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8750 Now static.
2893f146
PE
8751 (file_name_as_directory): Use const pointers when appropriate.
8752 (Fexpand_file_name): Likewise. In particular, newdir might
8753 point at constant storage, so make it a const pointer.
fd4ead52 8754 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8755 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8756 signedness issues.
f839df0c
PE
8757 (Fset_file_times, Finsert_file_contents, auto_save_error):
8758 Rename locals to avoid shadowing.
f14b7e14 8759
5716756e 8760 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8761 (Ftry_completion, Fall_completions): Rename or remove locals
8762 to avoid shadowing.
5716756e 8763
b4c3046a
PE
8764 * marker.c (bytepos_to_charpos): Remove; unused.
8765
b45db522
PE
8766 * lisp.h (verify_bytepos, count_markers): New decls,
8767 so that gcc does not warn that these functions aren't declared.
8768
85876d07
PE
8769 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8770 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8771 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8772 (copy_text): Remove unused local var.
85876d07 8773
03d78a21 8774 * filelock.c (within_one_second): Now static.
b3dd38ab 8775 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8776
5df8f01b
PE
8777 * buffer.c (fix_overlays_before): Mark locals as initialized.
8778 (fix_start_end_in_overlays): Likewise. This function should be
8779 simplified by using pointers-to-pointers, but that's a different
8780 matter.
b1d876f1 8781 (switch_to_buffer_1): Now static.
8f54f30a
PE
8782 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8783 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8784
a70072c9 8785 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8786 Fix pointer signedness issue.
edced198
PE
8787 (sys_subshell): Mark local as volatile if checking for lint,
8788 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8789 (MAXPATHLEN): Define only if needed.
a70072c9 8790
a0977c44
PE
8791 * process.c (serial_open, serial_configure): Move decls from here ...
8792 * systty.h: ... to here, so that they can be checked.
8793
a884fdcc
PE
8794 * fns.c (get_random, seed_random): Move extern decls from here ...
8795 * lisp.h: ... to here, so that they can be checked.
8796
604efe86 8797 * sysdep.c (reset_io): Now static.
b8950c94 8798 (wait_for_termination_signal): Remove; unused.
604efe86 8799
38fc62d9
PE
8800 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8801 (copy_keymap_item, append_key, push_text_char_description):
8802 Now static.
1004a21a 8803 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8804 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8805 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8806 (describe_map_tree):
8807 Rename locals to avoid shadowing.
38fc62d9 8808
2f2650da
PE
8809 * keyboard.c: Declare functions static if they are not used elsewhere.
8810 (echo_char, echo_dash, cmd_error, top_level_2):
8811 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8812 (read_char, kbd_buffer_get_event, make_lispy_position):
8813 (make_lispy_event, make_lispy_movement, apply_modifiers):
8814 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8815 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8816 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8817 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8818 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8819
a053e86c 8820 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8821 (mark_kboards): Move decl here ...
8822 * alloc.c (mark_kboards): ... from here.
a053e86c 8823
4752793e
PE
8824 * lisp.h (force_auto_save_soon): New decl.
8825
74f10ca7 8826 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8827 (DEFINE_DUMMY_FUNCTION): New macro.
8828 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8829 Use it.
c03cd23f
PE
8830 (main): Add casts to avoid warnings
8831 if GCC considers string literals to be constants.
74f10ca7 8832
022e70d4
PE
8833 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8834
59d6fe83
PE
8835 * dbusbind.c: Pointer signedness fixes.
8836 (xd_signature, xd_append_arg, xd_initialize):
8837 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8838 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8839 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8840 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8841
78320123
PE
8842 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8843 if GCC considers string literals to be constants.
49cebcca 8844 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8845
35ac2a97
SM
88462011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8847
fb103ca9
SM
8848 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8849 (print_preprocess, print_object): New macro to fix last change.
8850
35ac2a97
SM
8851 * print.c (print_preprocess): Don't forget font objects.
8852
62973b41
JB
88532011-03-16 Juanma Barranquero <lekktu@gmail.com>
8854
8855 * emacs.c (USAGE3): Doc fixes.
8856
0e48bb22
AS
88572011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8858
8859 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8860 structure.
8861
7684e57b
JB
88622011-03-14 Juanma Barranquero <lekktu@gmail.com>
8863
8864 * lisp.h (VWindow_system, Qfile_name_history):
8865 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8866 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8867 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8868
8869 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8870 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8871
8872 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8873 * w32console.c (detect_input_pending, read_input_pending)
8874 (encode_terminal_code):
8875 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8876 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8877 (w32_system_caret_y, Qfile_name_history):
8878 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8879 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8880 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8881 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8882 * w32proc.c (Qlocal, report_file_error):
8883 * w32term.c (Vwindow_system, updating_frame):
8884 * w32uniscribe.c (initialized, uniscribe_font_driver):
8885 Remove unneeded extern declarations.
8886
2aa46d6c
CY
88872011-03-14 Chong Yidong <cyd@stupidchicken.com>
8888
c96bbc66 8889 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8890
cffc6f3b
CY
88912011-03-13 Chong Yidong <cyd@stupidchicken.com>
8892
8893 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8894 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8895 These macros can no longer be used for assignment.
8896
44f230aa
SM
8897 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8898 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8899 (record_buffer_markers, fetch_buffer_markers): New functions for
8900 recording and fetching special buffer markers.
8901 (set_buffer_internal_1, set_buffer_temp): Use them.
8902
8903 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8904
8905 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8906
8907 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8908 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8909
8910 * xdisp.c (hscroll_window_tree):
8911 (reconsider_clip_changes): Use PT instead of BUF_PT.
8912
d251f04b
EZ
89132011-03-13 Eli Zaretskii <eliz@gnu.org>
8914
8915 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8916 $(EMACS_ROOT)/lib/intprops.h.
8917
f0c77cd1
PE
89182011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8919
3eca4629
PE
8920 Fix more problems found by GCC 4.5.2's static checks.
8921
7c86ee98
PE
8922 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8923 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8924 (xg_free_frame_widgets): Make it clear that a local variable is
8925 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8926 (gdk_window_get_screen): Make it clear that this macro is needed
8927 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8928 (int_gtk_range_get_value): New function, which avoids a diagnostic
8929 from gcc -Wbad-function-cast.
8930 (xg_set_toolkit_scroll_bar_thumb): Use it.
8931 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8932 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8933 (get_utf8_string, xg_get_file_with_chooser):
8934 Rename locals to avoid shadowing.
8935 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8936
41729b81
PE
8937 * xgselect.c (xg_select): Remove unused var.
8938
f0c77cd1
PE
8939 * image.c (four_corners_best): Mark locals as initialized.
8940 (gif_load): Initialize transparent_p to zero (Bug#8238).
8941 Mark another local as initialized.
ec6cf4c6 8942 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8943
ce0ad53d 8944 * image.c (clear_image_cache): Now static.
d5d5a617 8945 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8946 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8947 (x_edge_detection): Remove unnecessary cast that
8948 gcc -Wbad-function-cast diagnoses.
2037898d 8949 (gif_load): Fix pointer signedness.
6ae141d6
PE
8950 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8951 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8952
33383987 89532011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8954
d32df629
PE
8955 Improve quality of tests for time stamp overflow.
8956 For example, without this patch (encode-time 0 0 0 1 1
8957 1152921504606846976) returns the obviously-bogus value (-948597
8958 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8959 reports time overflow. See
8960 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8961 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8962 * editfns.c: Include limits.h and intprops.h.
8963 (TIME_T_MIN, TIME_T_MAX): New macros.
8964 (time_overflow): Move earlier, to before first use.
8965 (hi_time, lo_time): New functions, for an accurate test for
8966 out-of-range times.
8967 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8968 (Fget_internal_run_time): Don't assume time_t fits in int.
8969 (make_time): Use list2 instead of Fcons twice.
8970 (Fdecode_time): More accurate test for out-of-range times.
8971 (check_tm_member): New function.
8972 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8973 (lisp_time_argument): Don't rely on undefined left-shift and
8974 right-shift behavior when checking for time stamp overflow.
8be6f318 8975
fe31d94c
PE
8976 * editfns.c (time_overflow): New function, refactoring common code.
8977 (Fformat_time_string, Fdecode_time, Fencode_time):
8978 (Fcurrent_time_string): Use it.
8979
8be6f318
PE
8980 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8981 * dired.c (make_time): Move to ...
8982 * editfns.c (make_time): ... here.
8983 * systime.h: Note the move.
8984
09d9db2c 89852011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8986
126bc0dc
YM
8987 * fringe.c (update_window_fringes): Remove unused variables.
8988
c47cbdfd
YM
8989 * unexmacosx.c (copy_data_segment): Also copy __got section.
8990 (Bug#8223)
8991
7ac80be9
EZ
89922011-03-12 Eli Zaretskii <eliz@gnu.org>
8993
c96bbc66 8994 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8995 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8996 Constify `char *' arguments and their references according to
8997 prototypes in tparam.h.
8998
ecb0f94d 8999 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9000
7ac80be9
EZ
9001 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9002 Adapt all references accordingly.
9003
9004 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9005
ef1fd07e
TT
90062011-03-11 Tom Tromey <tromey@redhat.com>
9007
9008 * buffer.c (syms_of_buffer): Remove obsolete comment.
9009
7ef4b50c
EZ
90102011-03-11 Eli Zaretskii <eliz@gnu.org>
9011
9012 * termhooks.h (encode_terminal_code): Declare prototype.
9013
9014 * msdos.c (encode_terminal_code): Don't declare prototype.
9015
9016 * term.c (encode_terminal_code): Now external again, used by
9017 w32console.c and msdos.c.
9018
44f230aa
SM
9019 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9020 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9021
4b1ec863 90222011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9023
1714f52b 9024 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9025
4b1ec863
PE
9026 * fringe.c (update_window_fringes): Mark locals as initialized
9027 (Bug#8227).
9028 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9029
524c7aa6
PE
9030 * alloc.c (mark_fringe_data): Move decl from here ...
9031 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9032 to check its interface.
9033 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9034
a5c0af81 9035 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9036 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9037 (fontset_font): Mark local as initialized.
a9a06e0b 9038 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9039
b4716021
PE
9040 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9041
811e9bac 9042 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9043 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9044 (x_own_selection, Fx_disown_selection_internal): Rename locals
9045 to avoid shadowing.
9046 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9047
7e3ab302
PE
9048 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9049 so that the caller can use some name other than gcpro1.
9050 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9051 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9052 (Fx_backspace_delete_keys_p):
9053 Use them to avoid shadowing, and rename vars to avoid shadowing.
9054 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9055 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9056 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9057 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9058 Remove unused locals.
7e3ab302
PE
9059 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9060 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9061 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9062 macros.
f78faa98 9063
e2b13473
PE
9064 * xterm.h (x_mouse_leave): New decl.
9065
77f23912
PE
9066 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9067 Remove unused functions.
cdf4ba58
PE
9068 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9069 (x_calc_absolute_position): Now static.
7411c686 9070 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9071 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9072 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9073 unless they are used.
38d0b34a
PE
9074 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9075 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9076 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9077 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9078 (x_error_catcher, x_connection_closed, x_error_handler):
9079 (x_error_quitter, xembed_send_message, x_iconify_frame):
9080 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9081 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9082 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9083
44f230aa
SM
9084 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9085 Rename or move locals to avoid shadowing.
6b463e58 9086 (tty_defined_color, merge_face_heights): Now static.
5967d051 9087 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9088 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9089 does not deduce is never used uninitialized.
73719eba
PE
9090 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9091 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9092
426994c3 9093 * terminal.c (store_terminal_param): Now static.
5489860b 9094
032f1620 9095 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9096 (set_frame_menubar): Remove unused local.
d4323972 9097 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9098 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9099 since they might point to immutable storage.
281585b0
PE
9100 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9101 since it's unused otherwise.
032f1620 9102
367c19e5 9103 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9104 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9105 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9106 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9107 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9108 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9109 does not deduce are never used uninitialized.
70739cbe 9110
07b48fa9
PE
9111 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9112
8868a238 9113 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9114 * window.c (window_loop, size_window):
9115 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9116
7e5cf297 9117 * window.c (display_buffer): Now static.
d6550a9f
PE
9118 (size_window): Mark variables that gcc -Wuninitialized
9119 does not deduce are never used uninitialized.
a586633d
PE
9120 * window.h (check_all_windows): New decl, to forestall
9121 gcc -Wmissing-prototypes diagnostic.
5b555da1 9122 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9123
f6095868
PE
9124 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9125 shadowing.
9126 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9127 Include <limits.h>.
9128 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9129 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9130 (load_charset_map): Mark variables that gcc -Wuninitialized
9131 does not deduce are never used uninitialized.
53df7c11 9132 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9133
f38b440c
PE
9134 * coding.c (coding_set_source, coding_set_destination):
9135 Use "else { /* comment */ }" rather than "else /* comment */;"
9136 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9137 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9138 a block, when the outer 'i' will do.
9139 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9140 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9141 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9142 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9143 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9144 Rename locals to avoid shadowing.
9145 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9146 * coding.c (emacs_mule_char, encode_invocation_designation):
9147 Now static, since they're not used elsewhere.
413bb2db 9148 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9149 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9150 (decode_coding_emacs_mule): Mark variables that gcc
9151 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9152 (detect_coding_iso_2022): Initialize a local variable that might
9153 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9154 this initialization is needed. (Bug#8211)
5f58e762
PE
9155 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9156 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9157 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9158 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9159 Remove unused macros.
f38b440c 9160
232b38b9 9161 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9162 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9163 * character.c (string_count_byte8): Likewise.
232b38b9 9164
fb90da1b
PE
9165 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9166 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9167
fb93dbc2
PE
9168 * chartab.c (copy_sub_char_table): Now static, since it's not used
9169 elsewhere.
5c156ace
PE
9170 (sub_char_table_ref_and_range, char_table_ref_and_range):
9171 Rename locals to avoid shadowing.
bbcd0949 9172 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9173
7d3b3862 9174 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9175 (BIDI_BOB): Remove unused macro.
7d3b3862 9176
6be7d3da
PE
9177 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9178 deduce are never used uninitialized.
c2ed9c8b 9179 * term.c (encode_terminal_code): Likewise.
6be7d3da 9180
75f8807f 9181 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9182
50938595
PE
9183 * tparam.h: New file.
9184 * term.c, tparam.h: Include it.
9185 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9186 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9187 Move these decls to tparam.h, and make them agree with what
9188 is actually in tparam.c. The previous trick of using incompatible
9189 decls in different modules does not conform to the C standard.
9190 All callers of tparam changed to use tparam's actual API.
9191 * tparam.c (tparam1, tparam, tgoto):
9192 Use const pointers where appropriate.
9193
fbceeba2
PE
9194 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9195 * cm.h (struct cm): Likewise.
9196 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9197 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9198 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9199 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9200 (turn_on_face, init_tty): Likewise.
9201 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9202
7f3f1250
PE
9203 * term.c (term_mouse_position): Rename local to avoid shadowing.
9204
e6ca6543
PE
9205 * alloc.c (mark_ttys): Move decl from here ...
9206 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9207
c40f8d15
AS
92082011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9209
9210 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9211
cfe0661d
JB
92122011-03-09 Juanma Barranquero <lekktu@gmail.com>
9213
9214 * search.c (compile_pattern_1): Remove argument regp, unused since
9215 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9216 (compile_pattern): Don't pass it.
9217
0afb4571
J
92182011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9219
9220 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9221 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9222 for ! HAVE_GTK3.
9223 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9224
9225 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9226
9227 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9228 gdk_window_get_screen, gdk_window_get_geometry,
9229 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9230 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9231 (xg_get_pixbuf_from_pixmap): New function.
9232 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9233 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9234 Call xg_get_pixbuf_from_pixmap instead of
9235 gdk_pixbuf_get_from_drawable.
9236 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9237 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9238 (xg_check_special_colors): Use GtkStyleContext and its functions
9239 for HAVE_GTK3.
9240 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9241 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9242 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9243 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9244 Call gtk_widget_get_preferred_size.
0afb4571
J
9245 (xg_frame_resized): gdk_window_get_geometry only takes 5
9246 parameters.
44f230aa
SM
9247 (xg_win_to_widget, xg_event_is_for_menubar):
9248 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9249 (xg_set_widget_bg): New function.
9250 (delete_cb): New function.
895009e1 9251 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9252 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9253 (xg_set_background_color): Call xg_set_widget_bg.
9254 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9255 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9256 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9257 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9258 if ! HAVE_GTK3.
9259 (update_frame_tool_bar): Call gtk_widget_hide.
9260 (xg_initialize): Use GDK_KEY_g.
9261
9262 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9263 if ! HAVE_GTK3
9264 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9265
9266 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9267 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9268 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9269
1c2cc4ef
JB
92702011-03-08 Juanma Barranquero <lekktu@gmail.com>
9271
9272 * w32xfns.c (select_palette): Check success of RealizePalette against
9273 GDI_ERROR, not zero.
9274
33383987 9275See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9276
9277;; Local Variables:
9278;; coding: utf-8
aac0c6e3
MR
9279;; End:
9280
acaf905b 9281 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9282
9283 This file is part of GNU Emacs.
9284
9285 GNU Emacs is free software: you can redistribute it and/or modify
9286 it under the terms of the GNU General Public License as published by
9287 the Free Software Foundation, either version 3 of the License, or
9288 (at your option) any later version.
9289
9290 GNU Emacs is distributed in the hope that it will be useful,
9291 but WITHOUT ANY WARRANTY; without even the implied warranty of
9292 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9293 GNU General Public License for more details.
9294
9295 You should have received a copy of the GNU General Public License
9296 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.