* dired.c (file_name_completion): Now static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a25f4dfa
PE
12011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2
16390cd2
PE
3 * dired.c (file_name_completion): Now static.
4
5 * dbusbind.c (xd_in_read_queued_messages): Now static.
6
a25f4dfa
PE
7 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8 * data.c (circular_list_error): Remove.
9
16a97296
PE
102011-04-11 Paul Eggert <eggert@cs.ucla.edu>
11
14a9c8df
PE
12 * commands.h (last_point_position, last_point_position_buffer):
13 (last_point_position_window): Remove decls.
14 * keyboard.c: Make these variables static.
15
74ab6df5
PE
16 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
17 decls.
18 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
19 (iso_code_class, detect_coding, code_convert_region): Now static.
20 (encode_coding_gap): Remove; unused.
21
38dfbee1
PE
22 * chartab.c (chartab_chars, chartab_bits): Now static.
23
a2cb4e63
PE
24 * charset.h (charset_iso_8859_1): Remove decl.
25 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
26 Now static.
27
127198fd
PE
28 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
29 * ccl.c (Vccl_program_table): Now static.
30 (check_ccl_update): Remove; unused.
31
d85b608f
PE
32 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
33 * category.h: ... from here.
34 * category.c (check_category_table, set_category_set): Now static.
35
31cd66f3
PE
36 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
37 * lisp.h: Remove these decls.
38
c358e587
PE
39 * buffer.c (buffer_count): Remove unused var.
40
e78aecca
PE
41 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
42 so that it's not optimized away.
43 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
44 * dispextern.h (bidi_dump_cached_states): Remove, since it's
45 exported only to the debugger.
46
e192d7d3
PE
47 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
48 * atimer.h (run_all_atimers): Removed; not exported.
49
92470028
PE
50 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
51 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
52 was inaccessible from Lisp.
53 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
54 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
55
244ed907
PE
56 alloc.c: Import and export fewer symbols, and remove unused items.
57 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
58 is defined.
59 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
60 it's not optimized away by whole-program optimization.
61 (message_enable_multibyte, free_misc): Remove.
62 (catchlist, handlerlist, mark_backtrace):
63 Declare only if BYTE_MARK_STACK.
64 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
65 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
66 (message_enable_multibyte): Remove decl.
67 (free_misc, interval_free_list, float_block, float_block_index):
68 (n_float_blocks, float_free_list, cons_block, cons_block_index):
69 (cons_free_list, last_marked_index):
70 Now static.
71 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
72 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
73 (mark_backtrace): Define only if BYTE_MARK_STACK.
74 * xdisp.c (message_enable_multibyte): Now static.
75
955cbe7b
PE
76 Declare Lisp_Object Q* variables to be 'static' if not exproted.
77 This makes it easier for human readers (and static analyzers)
78 to see whether these variables are used from other modules.
79 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
80 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
81 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
82 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
83 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
84 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
85 * xmenu.c, xselect.c:
86 Declare Q* vars static if they are not used in other modules.
87 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
88 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
89 Remove decls of unexported vars.
90 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
91
95c82688
PE
92 * lisp.h (DEFINE_FUNC): Make sname 'static'.
93
16a97296
PE
94 Make Emacs functions such as Fatom 'static' by default.
95 This makes it easier for human readers (and static analyzers)
96 to see whether these functions can be called from other modules.
97 DEFUN now defines a static function. To make the function external
98 so that it can be used in other C modules, use the new macro DEFUE.
99 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
100 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
101 static function definition. Use DEFUE if you want an extern one.
102 (DEFUE, INFUN): New macros.
103 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
104 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
105 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
106 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
107 Remove decls, since these functions are now static.
108 (Funintern, Fget_internal_run_time): New decls, since these functions
109 were already external.
95c82688 110
16a97296
PE
111 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
112 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
113 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
114 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
115 * keyboard.c, keymap.c, lread.c:
116 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
117 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
118 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
119 Mark functions with DEFUE instead of DEFUN,
120 if they are used in other modules.
121 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
122 decls for now-static functions.
123 * buffer.h (Fdelete_overlay): Remove decl.
124 * callproc.c (Fgetenv_internal): Mark as internal.
125 * composite.c (Fremove_list_of_text_properties): Remove decl.
126 (Fcomposition_get_gstring): New forward static decl.
127 * composite.h (Fcomposite_get_gstring): Remove decl.
128 * dired.c (Ffile_attributes): New forward static decl.
129 * doc.c (Fdocumntation_property): New forward static decl.
130 * eval.c (Ffetch_bytecode): New forward static decl.
131 (Funintern): Remove extern decl; now in .h file where it belongs.
132 * fileio.c (Fmake_symbolic_link): New forward static decl.
133 * image.c (Finit_image_library): New forward static decl.
134 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
135 * intervals.h (Fprevious_property_change):
136 (Fremove_list_of_text_properties): Remove decls.
137 * keyboard.c (Fthis_command_keys): Remove decl.
138 (Fcommand_execute): New forward static decl.
139 * keymap.c (Flookup_key): New forward static decl.
140 (Fcopy_keymap): Now static.
141 * keymap.h (Flookup_key): Remove decl.
142 * process.c (Fget_process): New forward static decl.
143 (Fprocess_datagram_address): Mark as internal.
144 * syntax.c (Fsyntax_table_p): New forward static decl.
145 (skip_chars): Remove duplicate decl.
146 * textprop.c (Fprevious_property_change): New forward static decl.
147 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
148 Now internal.
149 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
150 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
151
785bbd42
PE
1522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
153
154 * editfns.c (Fformat): Remove unreachable code.
155
4073e537 1562011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 157
b2ded58d
PE
158 Fix more problems found by GCC 4.6.0's static checks.
159
7d66342c
PE
160 * xdisp.c (vmessage): Use a better test for character truncation.
161
bbf47d44
PE
162 * charset.c (load_charset_map): <, not <=, for optimization,
163 and to avoid potential problems with integer overflow.
9248994d 164 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 165 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 166 * editfns.c (Fformat): Likewise.
1e69125e 167 * syntax.c (skip_chars): Likewise.
3befa583 168
e3019616
PE
169 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
170 This also lets GCC 4.6.0 generate slightly better loop code.
171
becfa255
PE
172 * callint.c (Fcall_interactively): <, not <=, for optimization.
173 (Fcall_interactively): Count the number of arguments produced,
174 not the number of arguments given. This is simpler and lets GCC
175 4.6.0 generate slightly better code.
176
dae0cd48
PE
177 * ftfont.c: Distingish more carefully between FcChar8 and char.
178 The previous code passed unsigned char * to a functions like
179 strlen and xstrcasecmp that expect char *, which does not
180 conform to the C standard.
181 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
182 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
183 char * when the C standard requires it.
184
76032d70
PE
185 * keyboard.c (read_char): Remove unused var.
186
eb3f1cc8
PE
187 * eval.c: Port to Windows vsnprintf (Bug#8435).
188 Include <limits.h>.
189 (SIZE_MAX): Define if the headers do not.
190 (verror): Do not give up if vsnprintf returns a negative count.
191 Instead, grow the buffer. This ports to Windows vsnprintf, which
192 does not conform to C99. Problem reported by Eli Zaretskii.
193 Also, simplify the allocation scheme, by avoiding the need for
194 calling realloc, and removing the ALLOCATED variable.
195
70476b54
PE
196 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
197
12020a9e
PE
198 Remove invocations of doprnt, as Emacs now uses vsnprintf.
199 But keep the doprint source code for now, as we might revamp it
200 and use it again (Bug#8435).
ea6c7ae6
PE
201 * lisp.h (doprnt): Remove.
202 * Makefile.in (base_obj): Remove doprnt.o.
203 * deps.mk (doprnt.o): Remove.
204
5fdb398c
PE
205 error: Print 32- and 64-bit integers portably (Bug#8435).
206 Without this change, on typical 64-bit hosts error ("...%d...", N)
207 was used to print both 32- and 64-bit integers N, which relied on
208 undefined behavior.
209 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
210 New macro.
211 * lisp.h (error, verror): Mark as printf-like functions.
212 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
213 Report overflow in size calculations when allocating printf buffer.
214 Do not truncate output string at its first null byte.
215 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
216 Truncate the output at a character boundary, since vsnprintf does not
217 do that.
218 * charset.c (check_iso_charset_parameter): Convert internal
219 character to string before calling 'error', since %c now has the
220 printf meaning.
221 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
222 overflow when computing char to be passed to 'error'. Do not
223 pass Lisp_Object to 'error'; pass the integer instead.
224 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
225 formatted with plain %d.
226
b189fa66
PE
227 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
228
bff87ef0
PE
229 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
230
7e2cac20
PE
231 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
232
ce4d90b5
PE
233 * xterm.c (x_catch_errors): Remove duplicate declaration.
234
266c9547
PE
235 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
236
79c49ad2
PE
237 * xdisp.c, lisp.h (message_nolog): Remove; unused.
238
368f4090
JM
2392011-04-10 Jim Meyering <meyering@redhat.com>
240
241 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
242 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
243 return ssize_t not "int", and use size_t as the buffer length.
244 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
245 * gnutls.h: Update declarations.
246 * process.c (read_process_output): Use ssize_t, to match.
247 (send_process): Likewise.
248
a32d4040
CY
2492011-04-09 Chong Yidong <cyd@stupidchicken.com>
250
251 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
252
8546720e 2532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 254
8546720e
GM
255 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
256 unsigned char, to match FcChar8 type definition.
aac0c6e3 257
8546720e
GM
258 * xterm.c (handle_one_xevent):
259 * xmenu.c (create_and_show_popup_menu):
260 * xselect.c (x_decline_selection_request)
261 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 262
a53e2e89
EZ
2632011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
264
265 Fix some uses of `int' instead of EMACS_INT.
266 * search.c (string_match_1, fast_string_match)
267 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
268 (scan_buffer, find_next_newline_no_quit)
269 (find_before_next_newline, search_command, Freplace_match)
270 (Fmatch_data): Make some `int' variables be EMACS_INT.
271
272 * xdisp.c (display_count_lines): 3rd argument and return value now
273 EMACS_INT. All callers changed.
274 (pint2hrstr): Last argument is now EMACS_INT.
275
276 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
277 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
278 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
279 (decode_coding_utf_16, decode_coding_emacs_mule)
280 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
281 (decode_coding_ccl, decode_coding_charset)
282 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
283 (decode_coding_iso_2022, decode_coding_emacs_mule)
284 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
285 <char_offset, last_offset>: Declare EMACS_INT.
286 (encode_coding_utf_8, encode_coding_utf_16)
287 (encode_coding_emacs_mule, encode_invocation_designation)
288 (encode_designation_at_bol, encode_coding_iso_2022)
289 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
290 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
291 Declare EMACS_INT.
292 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
293 (encode_invocation_designation): Last argument P_NCHARS is now
294 EMACS_INT.
295 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
296 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
297
298 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
299 All users changed.
300
301 * ccl.c (Fccl_execute_on_string): Declare some variables
302 EMACS_INT.
303
8546720e 3042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
305
306 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
307
4e19a977
CS
3082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
309
310 * process.c (Fformat_network_address): Doc fix.
311
87302331
R
3122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
313
314 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
315
cbb59342
CY
3162011-04-08 Chong Yidong <cyd@stupidchicken.com>
317
318 * keyboard.c (read_char): Call Lisp function help-form-show,
319 instead of using internal_with_output_to_temp_buffer.
320 (Qhelp_form_show): New var.
e0d38eeb 321 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
322
323 * print.c (internal_with_output_to_temp_buffer): Function deleted.
324
325 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
326
e67a13ab
CY
3272011-04-06 Chong Yidong <cyd@stupidchicken.com>
328
329 * process.c (Flist_processes): Removed to Lisp.
330 (list_processes_1): Deleted.
331
973f782d
EZ
3322011-04-06 Eli Zaretskii <eliz@gnu.org>
333
7c106b1e
EZ
334 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
335
973f782d
EZ
336 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
337
41cf7d1a 3382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 339
ca23cc88
PE
340 Fix more problems found by GCC 4.6.0's static checks.
341
f390e2d5
PE
342 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
343
42eea0d0
PE
344 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
345
b69769da 346 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 347
f9541e84
PE
348 * xdisp.c (vmessage): Mark as a printf-like function.
349
13841b55
PE
350 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
351
c136c10f
PE
352 * sound.c (sound_warning): Don't crash if arg contains a printf format.
353
5e2d4a30
PE
354 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
355 printf-like functions.
356 (tiff_load): Add casts to remove these marks before passing them
357 to system-supplied API.
358
583f48b9
PE
359 * eval.c (Fsignal): Remove excess argument to 'fatal'.
360
b25d760e
PE
361 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
362 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
363 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
364 directly, rather than having caller test rule sign. This avoids
365 some unnecessary tests.
366 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
367 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
368 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 369
bc7b6697 370 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 371 (xfont_open): Avoid unnecessary tests.
bc7b6697 372
27ccc379
PE
373 * composite.c (composition_gstring_put_cache): Use unsigned integer.
374
dcd5c89a
PE
375 * composite.h, composite.c (composition_gstring_put_cache):
376 Use EMACS_INT, not int, for length.
377
b13a45c6
PE
378 * composite.h (COMPOSITION_DECODE_REFS): New macro,
379 breaking out part of COMPOSITION_DECODE_RULE.
380 (COMPOSITION_DECODE_RULE): Use it.
381 * composite.c (get_composition_id): Remove unused local vars,
382 by using the new macro.
383
1e792e4d
PE
384 * textprop.c (set_text_properties_1): Change while to do-while,
385 since the condition is always true at first.
386
dc6c6455 387 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
388 (interval_deletion_adjustment): Return unsigned value.
389 All uses changed.
dc6c6455 390
aba7731a
PE
391 * process.c (list_processes_1, create_pty, read_process_output):
392 (exec_sentinel): Remove vars that were set but not used.
afd4052b 393 (create_pty): Remove unnecessary "volatile"s.
bc57d757 394 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 395 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 396 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 397
fdfc4bf3
PE
398 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
399
fca8fe46 400 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 401 (update_syntax_table): Use unsigned instead of int.
fca8fe46 402
06a0259a 403 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 404 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 405 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 406
e7b9e80f
PE
407 * print.c (print_error_message): Avoid int overflow.
408
56201685
PE
409 * font.c (font_list_entities): Redo for clarity,
410 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
411
78834453 412 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 413 (font_score): Avoid potential overflow in diff calculation.
78834453 414
0bc0b309 415 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 416 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 417
e610eaca
PE
418 * eval.c (funcall_lambda): Rename local to avoid shadowing.
419
b895abce
PE
420 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
421 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
422 can always succeed if overflow has undefined behavior.
423
1f1d9321 424 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 425 (wordify): Omit three unnecessary tests.
1f1d9321 426
c59478bc
PE
427 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
428 All callers changed. This avoids the need for an unused var.
429
79b73827
PE
430 * casefiddle.c (casify_region): Remove var that is set but not used.
431
a4db5dfe
PE
432 * dired.c (file_name_completion): Remove var that is set but not used.
433
43aae36e
PE
434 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
435
2a47c44d 436 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 437 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 438
a37c69bf
PE
439 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
440 Check for integer overflow on size calculations.
441
328ab8e7
PE
442 * buffer.c (Fprevious_overlay_change): Remove var that is set
443 but not used.
444
e5a2a5cb
PE
445 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
446 Remove vars that are set but not used.
8d84a6eb 447 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 448 (timer_check_2): Mark vars as initialized.
e5a2a5cb 449
a60e5f68
PE
450 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
451
f661cb61 452 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 453 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 454
f0397f5a
PE
455 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
456 that are set but not used.
457
8664db06 458 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 459 if XCreateBitmapFromData fails (Bug#8410).
8664db06 460
6abdaa4a
PE
461 * xselect.c (x_get_local_selection, x_handle_property_notify):
462 Remove vars that are set but not used.
463
0ce7538d 464 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 465 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 466
9ae848fc
PE
467 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
468 Remove var that is set but not used.
0b918413
PE
469 (scroll_bar_windows_size): Now size_t, not int.
470 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
471 Check for overflow.
9ae848fc 472
a5a62657
PE
473 * xfaces.c (realize_named_face): Remove vars that are set but not used.
474 (map_tty_color) [!defined MSDOS]: Likewise.
475
5c5cdd39
PE
476 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
477
66ebf983
PE
478 * coding.c: Remove vars that are set but not used.
479 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
480 All callers changed.
481 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
482 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
483 (decode_coding_charset): Remove vars that are set but not used.
484
1be4d761
PE
485 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
486 that is set but not used.
487
47553fa8
PE
488 * print.c (print_object): Remove var that is set but not used.
489
1f7196bf 490 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
491 The gnulib version avoids calling malloc in the usual case,
492 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
493 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
494 * filelock.c (current_lock_owner): Likewise.
495 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
496 * sysdep.c: Include allocator.h, careadlinkat.h.
497 (emacs_no_realloc_allocator): New static constant.
498 (emacs_readlink): New function.
fdb61804
PE
499 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
500 ../lib/careadlinkat.h.
d1fdcab7 501
f84c17c7
SM
5022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
503
504 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
505 first non-nil return value).
506
ef3862ad
JD
5072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
508
509 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
510 if not defined (Bug#8403).
511
376a7006
JB
5122011-04-02 Juanma Barranquero <lekktu@gmail.com>
513
514 * xdisp.c (display_count_lines): Remove parameter `start',
515 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
516 (get_char_face_and_encoding): Remove parameter `multibyte_p',
517 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
518 (fill_stretch_glyph_string): Remove parameters `row' and `area',
519 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
520 and thereabouts. All callers changed.
521 (get_per_char_metric): Remove parameter `f', unused since
522 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
523
6ca3801d
JM
5242011-04-02 Jim Meyering <meyering@redhat.com>
525
526 do not dereference NULL upon failed strdup
527 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
528 (ns_get_family): Likewise.
529
d8e2b5ba
JB
5302011-04-02 Juanma Barranquero <lekktu@gmail.com>
531
532 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
533
8c74fcbd
JD
5342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
535
536 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
537 later (Bug#8403).
538
7200d79c
SM
5392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
540
03408648 541 Add lexical binding.
7200d79c 542
03408648
SM
543 * window.c (Ftemp_output_buffer_show): New fun.
544 (Fsave_window_excursion):
545 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
546
547 * lread.c (lisp_file_lexically_bound_p): New function.
548 (Fload): Bind Qlexical_binding.
549 (readevalloop): Remove `evalfun' arg.
550 Bind Qinternal_interpreter_environment.
551 (Feval_buffer): Bind Qlexical_binding.
552 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
553 Mark as dynamic.
554 (syms_of_lread): Declare `lexical-binding'.
555
556 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
557
558 * keyboard.c (eval_dyn): New fun.
559 (menu_item_eval_property): Use it.
ca105506
SM
560
561 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 562
03408648
SM
563 * fns.c (concat, mapcar1): Accept byte-code-functions.
564
565 * eval.c (Fsetq): Handle lexical vars.
566 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
567 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
568 (FletX, Flet): Obey lexical binding.
569 (Fcommandp): Handle closures.
570 (Feval): New `lexical' arg.
571 (eval_sub): New function extracted from Feval. Use it almost
572 everywhere where Feval was used. Look up vars in lexical env.
573 Handle closures.
574 (Ffunctionp): Move from subr.el.
575 (Ffuncall): Handle closures.
576 (apply_lambda): Remove `eval_flags'.
577 (funcall_lambda): Handle closures and new byte-code-functions.
578 (Fspecial_variable_p): New function.
579 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
580 but without exporting it to Lisp.
23aba0ea 581
23aba0ea 582 * doc.c (Fdocumentation, store_function_docstring):
03408648 583 * data.c (Finteractive_form): Handle closures.
23aba0ea 584
03408648
SM
585 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
586 interactive spec.
ba83908c 587
03408648
SM
588 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
589 byte-codes.
590 (exec_byte_code): New function extracted from Fbyte_code to handle new
591 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 592
03408648 593 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 594
03408648 595 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 596
e2abce01
JB
5972011-03-31 Juanma Barranquero <lekktu@gmail.com>
598
599 * xdisp.c (redisplay_internal): Fix prototype.
600
63696a73 6012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 602
63696a73
EZ
603 * xdisp.c (SCROLL_LIMIT): New macro.
604 (try_scrolling): Use it when setting scroll_limit. Limit
605 scrolling to 100 screen lines.
606 (redisplay_window): Even when falling back on "recentering",
607 position point in the window according to scroll-conservatively,
608 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
609
610 (try_scrolling): When point is above the window, allow searching
611 as far as scroll_max, or one screenful, to compute vertical
612 distance from PT to the scroll margin position. This prevents
613 try_scrolling from unnecessarily failing when
614 scroll-conservatively is set to a value slightly larger than the
615 window height. Clean up the case of PT below the margin at bottom
616 of window: scroll_max can no longer be INT_MAX. When aggressive
617 scrolling is in use, don't let point enter the opposite scroll
618 margin as result of the scroll.
619 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
620 threshold of 100 lines for never-recentering scrolling.
621
e4cc2dfc
JB
6222011-03-31 Juanma Barranquero <lekktu@gmail.com>
623
624 * dispextern.h (move_it_by_lines):
625 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
626 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
627 (message_log_check_duplicate): Remove parameters `prev_bol' and
628 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
629 (redisplay_internal): Remove parameter `preserve_echo_area',
630 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
631
632 * indent.c (Fvertical_motion):
633 * window.c (window_scroll_pixel_based, Frecenter):
634 Don't pass `need_y_p' to `move_it_by_lines'.
635
1c470562
SM
6362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
637
44f230aa
SM
638 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
639 steal a few bits to be more compact.
640 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
641 Remove unneeded casts.
642
1c470562
SM
643 * bytecode.c (Fbyte_code): CAR and CDR can GC.
644
888adce9
ZK
6452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
646
647 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
648 binding" message (bug#7967).
649
f838ed7b
PE
6502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
651
77861b95
PE
652 Fix more problems found by GCC 4.6.0's static checks.
653
de6dbc14
PE
654 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
655 Remove unused local var.
656
f838ed7b
PE
657 * editfns.c (Fmessage_box): Remove unused local var.
658
792c7b2b
PE
659 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
660 (note_mode_line_or_margin_highlight, note_mouse_highlight):
661 Omit unused local vars.
c499e557 662 * window.c (shrink_windows): Omit unused local var.
b01a1c29 663 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
664 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
665 Omit unused local var.
666
ba0165e1
PE
667 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
668 Don't assume string length fits in int.
32ad8845 669 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 670 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 671
3c59b4c9
PE
672 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
673 instead of alloca (Bug#8344).
674
a3eed478 675 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 676 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 677
eb4d412d
PE
678 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
679
1658b401
PE
680 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
681 concerns.
682
683 * term.c (produce_glyphless_glyph): Remove unnecessary test.
684
685 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 686
9a2c6e05
PE
687 * keyboard.c (syms_of_keyboard): Use the same style as later
688 in this function when indexing through an array. This also
689 works around GCC bug 48267.
690
03d0a109
PE
691 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
692
44f730c8
PE
693 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
694
fe75f926
PE
695 * chartab.c (sub_char_table_ref_and_range): Redo for slight
696 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
697
ffa8c828
PE
698 * keyboard.c, keyboard.h (num_input_events): Now size_t.
699 This avoids undefined behavior on integer overflow, and is a bit
700 more convenient anyway since it is compared to a size_t variable.
701
c5101a77
PE
702 Variadic C functions now count arguments with size_t, not int.
703 This avoids an unnecessary limitation on 64-bit machines, which
704 caused (substring ...) to crash on large vectors (Bug#8344).
705 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
706 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 707 All variadic functions and their callers changed accordingly.
c5101a77
PE
708 (struct gcpro.nvars): Now size_t, not int. All uses changed.
709 * data.c (arith_driver, float_arith_driver): Likewise.
710 * editfns.c (general_insert_function): Likewise.
711 * eval.c (struct backtrace.nargs, interactive_p)
712 (internal_condition_case_n, run_hook_with_args, apply_lambda)
713 (funcall_lambda, mark_backtrace): Likewise.
714 * fns.c (concat): Likewise.
715 * frame.c (x_set_frame_parameters): Likewise.
716 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
717 0 if not found, not -1. All callers changed.
718
dd3f25f7
PE
719 * alloc.c (garbage_collect): Don't assume stack size fits in int.
720 (stack_copy_size): Now size_t, not int.
721 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
722
461c2ab9
JB
7232011-03-28 Juanma Barranquero <lekktu@gmail.com>
724
725 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
726 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
727 All callers changed.
728
729 * lisp.h (multibyte_char_to_unibyte):
730 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
731 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
732 * character.h (CHAR_TO_BYTE8):
733 * cmds.c (internal_self_insert):
734 * editfns.c (general_insert_function):
735 * keymap.c (push_key_description):
736 * search.c (Freplace_match):
737 * xdisp.c (message_dolog, set_message_1): All callers changed.
738
f6d62986
SM
7392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
740
741 * keyboard.c (safe_run_hook_funcall): New function.
742 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
743 don't set the hook to nil, but remove the offending function instead.
744 (Qcommand_hook_internal): Remove, unused.
745 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
746 Vcommand_hook_internal.
747
748 * eval.c (enum run_hooks_condition): Remove.
749 (funcall_nil, funcall_not): New functions.
750 (run_hook_with_args): Call each function through a `funcall' argument.
751 Remove `cond' argument, now redundant.
752 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
753 (Frun_hook_with_args_until_failure): Adjust accordingly.
754 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
755
1db5b1ad
JB
7562011-03-28 Juanma Barranquero <lekktu@gmail.com>
757
758 * dispextern.h (string_buffer_position): Remove declaration.
759
760 * print.c (strout): Remove parameter `multibyte', unused since
761 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
762
763 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
764 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
765 All callers changed.
766
767 * w32.c (_wsa_errlist): Use braces for struct initializers.
768
769 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
770 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
771 All callers changed.
772 (string_buffer_position): Likewise. Also, make static (it's never
773 used outside xdisp.c).
774 (cursor_row_p): Remove parameter `w', unused since
775 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
776 (decode_mode_spec): Remove parameter `precision', introduced during
777 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
778 All callers changed.
779
5ffb62aa
JD
7802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
781
782 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
783
461c2ab9 7842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
785
786 * nsterm.m (ns_menu_bar_is_hidden): New variable.
787 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
788 (ns_update_auto_hide_menu_bar): New functions.
789 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
790 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
791 ns_constrain_all_frames.
792 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
793 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
794
5c380ffb
JD
7952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
796
797 * nsmenu.m (runDialogAt): Remove argument to timer_check.
798
9af30bdf
GM
7992011-03-27 Glenn Morris <rgm@gnu.org>
800
801 * syssignal.h: Replace RETSIGTYPE with void.
802 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
803 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
804 Replace SIGTYPE with void everywhere.
805 * s/usg5-4-common.h (SIGTYPE): Remove definition.
806 * s/template.h (SIGTYPE): Remove commented out definition.
807
e2abce01
JB
8082011-03-26 Eli Zaretskii <eliz@gnu.org>
809
810 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
811 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
812
f868cd8a
JB
8132011-03-26 Juanma Barranquero <lekktu@gmail.com>
814
59eb0929
JB
815 * w32.c (read_unc_volume): Use parameter `henum', instead of
816 global variable `wget_enum_handle'.
817
818 * keymap.c (describe_vector): Remove parameters `indices' and
819 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
820 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
821
f868cd8a
JB
822 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
823
824 * keyboard.c (timer_check): Remove parameter `do_it_now',
825 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
826 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
827 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
828
829 * keyboard.c (read_char):
830 * w32menu.c (w32_menu_display_help):
831 * xmenu.c (show_help_event, menu_help_callback):
832 Adjust calls to `show_help_echo'.
833
834 * gtkutil.c (xg_maybe_add_timer):
835 * keyboard.c (readable_events):
836 * process.c (wait_reading_process_output):
837 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
838
839 * insdel.c (adjust_markers_gap_motion):
840 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
841 (gap_left, gap_right): Don't call it.
842
2ecf6fdb
CY
8432011-03-25 Chong Yidong <cyd@stupidchicken.com>
844
845 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
846 incurred during fontification.
847
6b1f9ba4
JB
8482011-03-25 Juanma Barranquero <lekktu@gmail.com>
849
850 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
851 (DEFVAR_PER_BUFFER): Don't pass it.
852
853 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
854 (scrolling_window): Don't pass it.
855
0f4a96b5
JB
8562011-03-25 Juanma Barranquero <lekktu@gmail.com>
857
858 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
859
860 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
861 and `suffix'.
862 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
863 of variables specific to SELinux and computation of `encoded_absname'.
864
865 * image.c (XPutPixel): Remove unused variable `height'.
866
867 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
868
869 * unexw32.c (get_section_info): Remove unused variable `section'.
870
871 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
872 (system_process_attributes): Remove unused variable `sess'.
873 (sys_read): Remove unused variable `err'.
874
875 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
876 (w32_wnd_proc): Remove unused variable `isdead'.
877 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
878 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
879 (x_create_tip_frame): Remove unused variable `tem'.
880
881 * w32inevt.c (w32_console_read_socket):
882 Remove unused variable `no_events'.
883
884 * w32term.c (x_draw_composite_glyph_string_foreground):
885 Remove unused variable `width'.
886
1149507c
JB
8872011-03-24 Juanma Barranquero <lekktu@gmail.com>
888
889 * w32term.c (x_set_glyph_string_clipping):
890 Don't pass uninitialized region to CombineRgn.
891
9c88f339
JB
8922011-03-23 Juanma Barranquero <lekktu@gmail.com>
893
894 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
895 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
896 (Fx_close_connection): Remove unused variable `i'.
897
898 * w32font.c (w32font_draw): Return number of glyphs.
899 (w32font_open_internal): Remove unused variable `i'.
900 (w32font_driver): Add missing initializer.
901
902 * w32menu.c (utf8to16): Remove unused variable `utf16'.
903 (fill_in_menu): Remove unused variable `items_added'.
904
905 * w32term.c (last_mouse_press_frame): Remove static global variable.
906 (w32_clip_to_row): Remove unused variable `f'.
907 (x_delete_terminal): Remove unused variable `i'.
908
909 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
910 (NOTHING): Remove unused static global variable.
911 (uniscribe_check_otf): Remove unused variable `table'.
912 (uniscribe_font_driver): Add missing initializers.
913
dee091a3
JD
9142011-03-23 Julien Danjou <julien@danjou.info>
915
916 * term.c (Fsuspend_tty, Fresume_tty):
917 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
918 * window.c (temp_output_buffer_show):
919 * insdel.c (signal_before_change):
920 * frame.c (Fhandle_switch_frame):
921 * fileio.c (Fdo_auto_save):
922 * emacs.c (Fkill_emacs):
923 * editfns.c (save_excursion_restore):
924 * cmds.c (internal_self_insert):
925 * callint.c (Fcall_interactively):
926 * buffer.c (Fkill_all_local_variables):
927 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
928 Use Frun_hooks.
0f4a96b5 929 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
930 unconditionnaly since it does the check itself.
931
2c520ab5 9322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 933
c9c49752
PE
934 Fix more problems found by GCC 4.5.2's static checks.
935
8abc3f12
PE
936 * coding.c (encode_coding_raw_text): Avoid unnecessary test
937 the first time through the loop, since we know p0 < p1 then.
938 This also avoids a gcc -Wstrict-overflow warning.
939
a2d26660
PE
940 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
941 leading to a memory leak, possible in functions like
942 load_charset_map_from_file that can allocate an unbounded number
b12ef411 943 of objects (Bug#8318).
a2d26660 944
916c72e9
PE
945 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
946 that could (at least in theory) be that large.
947
19ab8a18
PE
948 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
949 This is less likely to overflow, and avoids undefined behavior if
950 overflow does occur. All callers changed. Use strtoul to scan
951 for the unsigned long integer.
b7cbbd6f
PE
952 (pint2hrstr): Simplify and tune code slightly.
953 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 954
f0641eff
PE
955 * scroll.c (do_scrolling): Work around GCC bug 48228.
956 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
957
7f650bb9
PE
958 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
959 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
960 (validate_x_resource_name): Simplify count usage.
961 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 962
37dd57d1
PE
963 * fileio.c (Fcopy_file): Report error if fchown or fchmod
964 fail (Bug#8306).
81e56e61 965
699979fc 966 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 967
401bf9b4
PE
968 * process.c (Fmake_network_process): Use socklen_t, not int,
969 where POSIX says socklen_t is required in portable programs.
970 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 971 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
972 (Fmake_network_process, server_accept_connection):
973 (wait_reading_process_output, read_process_output):
974 Likewise.
975
b93aacde
PE
976 * process.c: Rename or move locals to avoid shadowing.
977 (list_processes_1, Fmake_network_process):
978 (read_process_output_error_handler, exec_sentinel_error_handler):
979 Rename or move locals.
4dc343ee 980 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 981 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 982 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 983 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 984 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 985
af8a867c 986 Make tparam.h and terminfo.c consistent.
44f230aa
SM
987 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
988 Include tparam.h instead, since it declares them.
af8a867c
PE
989 * cm.h (PC): Remove extern decl; tparam.h now does this.
990 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
991 * terminfo.c: Include tparam.h, to check interfaces.
992 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
993 (tparam): Adjust signature to match interface in tparam.h;
994 this removes some undefined behavior. Check that outstring and len
995 are zero, which they always are with Emacs.
996 * tparam.h (PC, BC, UP): New extern decls.
997
0248044d 998 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 999 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1000
8ff096c1 1001 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1002 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1003 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1004 (ftfont_list): Remove unused local.
49eaafba
PE
1005 (get_adstyle_property, ftfont_pattern_entity):
1006 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1007 Rename locals to avoid shadowing.
8ff096c1 1008
e2be39f6
PE
1009 * xfont.c (xfont_list_family): Mark var as initialized.
1010
c9735e30
PE
1011 * xml.c (make_dom): Now static.
1012
8f5201ae
PE
1013 * composite.c (composition_compute_stop_pos): Rename local to
1014 avoid shadowing.
b246f932
PE
1015 (composition_reseat_it): Remove unused locals.
1016 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1017 (composition_update_it): Mark var as initialized.
11b61122
PE
1018 (find_automatic_composition): Mark vars as initialized,
1019 with a FIXME (Bug#8290).
8f5201ae 1020
760fbc2c
PE
1021 character.h: Rename locals to avoid shadowing.
1022 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1023 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1024 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1025 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1026 to avoid shadowing.
1027
ff08eb85
PE
1028 * textprop.c (property_change_between_p): Remove; unused.
1029
fc7bf025
PE
1030 * intervals.c (interval_start_pos): Now static.
1031
235d7abc
PE
1032 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1033
44f230aa
SM
1034 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1035 Rename locals to avoid shadowing.
3e7d6594 1036
50060332
PE
1037 * sound.c (wav_play, au_play, Fplay_sound_internal):
1038 Fix pointer signedness.
d01f234b 1039 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1040 (wav_play): Initialize a variable to 0, to prevent undefined
1041 behavior (Bug#8278).
50060332 1042
c4fc4e30
PE
1043 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1044
918436ed
PE
1045 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1046
c939f91b
PE
1047 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1048 clobbering (Bug#8298).
b9c7f648
PE
1049 * sysdep.c (sys_subshell): Likewise.
1050 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1051
6bd8c144
PE
1052 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1053 This should get cleaned up, so that child_setup has the
1054 same signature on all platforms.
1055
7710357c 1056 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1057 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1058
c59da222
CY
10592011-03-22 Chong Yidong <cyd@stupidchicken.com>
1060
1061 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1062 not to be necessary, and produces flickering.
1063
66b87493
GM
10642011-03-20 Glenn Morris <rgm@gnu.org>
1065
1066 * config.in: Remove file.
1067
45b6f6d5
JB
10682011-03-20 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1071 are now in src/globals.h.
1072 (syms_of_minibuf): Remove spurious & from previous change.
1073
3ec03f7e
LL
10742011-03-20 Leo <sdl.web@gmail.com>
1075
1076 * minibuf.c (completing-read-function): New variable.
1077 (completing-read-default): Rename from completing-read.
1078 (completing-read): Call completing-read-function.
1079
b14e3e21
CY
10802011-03-19 Juanma Barranquero <lekktu@gmail.com>
1081
1082 * xfaces.c (Fx_load_color_file):
1083 Read color file from absolute filename (bug#8250).
1084
f2b726e6
JB
10852011-03-19 Juanma Barranquero <lekktu@gmail.com>
1086
1087 * makefile.w32-in: Update dependencies.
1088
09f6ff02
EZ
10892011-03-17 Eli Zaretskii <eliz@gnu.org>
1090
1091 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1092
29a6015a
PE
10932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1094
a3a6c54e
PE
1095 Fix more problems found by GCC 4.5.2's static checks.
1096
b766f867
PE
1097 * process.c (make_serial_process_unwind, send_process_trap):
1098 (sigchld_handler): Now static.
1099
be02381c
PE
1100 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1101 That way, the code declares only the vars that it needs.
1102 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1103 * s/cygwin.h (PTY_ITERATION): Likewise.
1104 * s/darwin.h (PTY_ITERATION): Likewise.
1105 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1106
57048744
PE
1107 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1108 * process.c (allocate_pty): Don't declare stb unless it's needed.
1109
7914961c 1110 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1111 (CONSTANTLIM): Remove; unused.
1112 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1113 Define only if needed.
7914961c 1114
b3967b18
PE
1115 * unexelf.c (unexec): Name an expression,
1116 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1117 Use a different way to cause a compilation error if anyone uses
1118 n rather than nn, a way that does not involve shadowing.
73366a00 1119 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1120
29a6015a
PE
1121 * deps.mk (unexalpha.o): Remove; unused.
1122
43cfc33e 1123 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1124 * unexec.h: New file.
ce701a33
PE
1125 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1126 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1127 Depend on unexec.h.
1128 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1129 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1130 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1131 Change as necessary to match prototype in unexec.h.
ce701a33 1132
01f44d5a
PE
1133 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1134 shadowing.
4f63c6bb 1135 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1136
a6670b0b
PE
1137 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1138 Rename locals to avoid shadowing.
1139
cef2010d 1140 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1141 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1142
d4d7173a
PE
1143 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1144
f08b802a
PE
1145 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1146 warning when compiling print.c.
1147
3ddb0639
PE
1148 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1149 instead of using an uninitialized var.
5ad03b97 1150 (font_sort_entities): Mark var as initialized.
3ddb0639 1151
170a2692
PE
1152 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1153
e663c700
PE
1154 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1155 pointers to constants.
89bc529a 1156 (font_parse_fcname): Remove unused vars.
7b81e2d0 1157 (font_delete_unmatched): Now static.
ea838e10 1158 (font_get_spec): Remove; unused.
13a547c6
PE
1159 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1160 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1161 Rename or move locals to avoid shadowing.
e663c700 1162
2a80c887 1163 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1164 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1165
1384fa33 1166 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1167 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1168
8b2c52e9
PE
1169 * alloc.c (mark_backtrace): Move decl from here ...
1170 * lisp.h: ... to here, so that it can be checked.
1171
475545b5 1172 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1173 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1174 (lisp_indirect_variable): Name an expression,
1175 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1176 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1177
b1349114 1178 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1179 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1180 Use const pointer when appropriate.
b1349114 1181
a2928364
PE
1182 * lisp.h (get_system_name, get_operating_system_release):
1183 Move decls here, to check interfaces.
1184 * process.c (get_operating_system_release): Move decl to lisp.h.
1185 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1186 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1187 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1188 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1189 (Fformat_time_string, Fencode_time, Finsert_char):
1190 (Ftranslate_region_internal, Fformat):
1191 Rename or remove local vars to avoid shadowing.
9710023e 1192 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1193
a415e694
PE
1194 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1195 avoid shadowing.
1196
8ef4622d
PE
1197 * lisp.h (eassert): Check that the argument compiles, even if
1198 ENABLE_CHECKING is not defined.
1199
946f9a5b
PE
1200 * data.c (Findirect_variable): Name an expression, to avoid
1201 gcc -Wbad-function-cast warning.
112396d6 1202 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1203 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1204 (Fmake_variable_buffer_local, Fmake_local_variable):
1205 Mark variables as initialized.
52746918 1206 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1207
e5aab7e7 1208 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1209 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1210 Rename locals to avoid shadowing.
dff45157
PE
1211 (mark_stack): Move local variables into the #ifdef region where
1212 they're used.
7bc26fdb
PE
1213 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1214 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1215 needed otherwise.
1216 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1217 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1218 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1219
e5aab7e7
PE
1220 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1221 avoids undefined behavior in theory.
1222
4da60324
PE
1223 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1224
88043301
PE
1225 Use functions, not macros, for up- and down-casing (Bug#8254).
1226 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1227 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1228 to use the following functions instead of these macros.
1229 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1230 EMACS_INT, since callers assume the returned value fits in int.
1231 (upcase1): Likewise, for UPCASE_TABLE.
1232 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1233 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1234 the race-condition problem in the old DOWNCASE.
88043301 1235
19ed5445
PE
1236 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1237 Rename locals to avoid shadowing.
1238 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1239 (regex_compile, re_search_2, re_match_2_internal):
1240 Remove unused local vars.
952db0d7
PE
1241 (FREE_VAR): Rewrite so as not to use empty "else",
1242 which gcc can warn about.
da053e48 1243 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1244 (RETALLOC_IF): Define only if needed.
1245 (WORDCHAR_P): Likewise. This one is never needed, but is used
1246 only in a comment talking about a compiler bug, so put inside
1247 the #if 0 of that comment.
1248 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1249 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1250 Remove; unused.
19ed5445 1251
1f3561e4 1252 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1253 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1254 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1255
ded6f8f7
PE
1256 * search.c (simple_search): Remove unused var.
1257
dbd37a95
PE
1258 * dired.c (compile_pattern): Move decl from here ...
1259 * lisp.h: ... to here, so that it can be checked.
1260 (struct re_registers): New forward decl.
1261
7e47afad
PE
1262 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1263
85f24f61
PE
1264 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1265 All uses changed.
1266 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1267 Rename locals to avoid shadowing.
5671df8f 1268 (Fvertical_motion): Mark locals as initialized.
85f24f61 1269
181aa2be 1270 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1271 (casify_region): Mark local as initialized.
181aa2be 1272
930d429c
PE
1273 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1274
7082eac6
PE
1275 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1276 New macros, so that the caller can use some names other than
1277 gcpro1, gcpro2, etc.
1278 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1279 of the new macros.
1280 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1281 argument, for consistency with GCPRO2_VAR, etc: it is now the
1282 prefix of the variable, not the variable itself. All uses
1283 changed.
38b2c076
PE
1284 * dired.c (directory_files_internal, file_name_completion):
1285 Rename locals to avoid shadowing.
1286
15206ed9
PE
1287 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1288 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1289 dired.c's scmp function, had undefined behavior.
1290 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1291 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1292 * buffer.h: ... to here, because these macros use current_buffer,
1293 and the new implementation with inline functions needs to have
1294 current_buffer in scope now, rather than later when the macros
1295 are used.
1296 (downcase, upcase1): New static inline functions.
1297 (DOWNCASE, UPCASE1): Reimplement using these functions.
1298 This avoids undefined behavior in expressions like
1299 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1300 from race conditions in accessing the global variables
1301 case_temp1 and case_temp2.
1302 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1303 * lisp.h (case_temp1, case_temp2): Remove their decls.
1304 * character.h (ASCII_CHAR_P): Move from here ...
1305 * lisp.h: ... to here, so that the inline functions mentioned
1306 above can use them.
1307
4a6bea26
PE
1308 * dired.c (directory_files_internal_unwind): Now static.
1309
f14b7e14
PE
1310 * fileio.c (file_name_as_directory, directory_file_name):
1311 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1312 Now static.
2893f146
PE
1313 (file_name_as_directory): Use const pointers when appropriate.
1314 (Fexpand_file_name): Likewise. In particular, newdir might
1315 point at constant storage, so make it a const pointer.
fd4ead52 1316 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1317 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1318 signedness issues.
f839df0c
PE
1319 (Fset_file_times, Finsert_file_contents, auto_save_error):
1320 Rename locals to avoid shadowing.
f14b7e14 1321
5716756e 1322 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1323 (Ftry_completion, Fall_completions): Rename or remove locals
1324 to avoid shadowing.
5716756e 1325
b4c3046a
PE
1326 * marker.c (bytepos_to_charpos): Remove; unused.
1327
b45db522
PE
1328 * lisp.h (verify_bytepos, count_markers): New decls,
1329 so that gcc does not warn that these functions aren't declared.
1330
85876d07
PE
1331 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1332 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1333 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1334 (copy_text): Remove unused local var.
85876d07 1335
03d78a21 1336 * filelock.c (within_one_second): Now static.
b3dd38ab 1337 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1338
5df8f01b
PE
1339 * buffer.c (fix_overlays_before): Mark locals as initialized.
1340 (fix_start_end_in_overlays): Likewise. This function should be
1341 simplified by using pointers-to-pointers, but that's a different
1342 matter.
b1d876f1 1343 (switch_to_buffer_1): Now static.
8f54f30a
PE
1344 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1345 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1346
a70072c9 1347 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1348 Fix pointer signedness issue.
edced198
PE
1349 (sys_subshell): Mark local as volatile if checking for lint,
1350 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1351 (MAXPATHLEN): Define only if needed.
a70072c9 1352
a0977c44
PE
1353 * process.c (serial_open, serial_configure): Move decls from here ...
1354 * systty.h: ... to here, so that they can be checked.
1355
a884fdcc
PE
1356 * fns.c (get_random, seed_random): Move extern decls from here ...
1357 * lisp.h: ... to here, so that they can be checked.
1358
604efe86 1359 * sysdep.c (reset_io): Now static.
b8950c94 1360 (wait_for_termination_signal): Remove; unused.
604efe86 1361
38fc62d9
PE
1362 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1363 (copy_keymap_item, append_key, push_text_char_description):
1364 Now static.
1004a21a 1365 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1366 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1367 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1368 (describe_map_tree):
1369 Rename locals to avoid shadowing.
38fc62d9 1370
2f2650da
PE
1371 * keyboard.c: Declare functions static if they are not used elsewhere.
1372 (echo_char, echo_dash, cmd_error, top_level_2):
1373 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1374 (read_char, kbd_buffer_get_event, make_lispy_position):
1375 (make_lispy_event, make_lispy_movement, apply_modifiers):
1376 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1377 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1378 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1379 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1380 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1381
a053e86c 1382 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1383 (mark_kboards): Move decl here ...
1384 * alloc.c (mark_kboards): ... from here.
a053e86c 1385
4752793e
PE
1386 * lisp.h (force_auto_save_soon): New decl.
1387
74f10ca7 1388 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1389 (DEFINE_DUMMY_FUNCTION): New macro.
1390 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1391 Use it.
c03cd23f
PE
1392 (main): Add casts to avoid warnings
1393 if GCC considers string literals to be constants.
74f10ca7 1394
022e70d4
PE
1395 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1396
59d6fe83
PE
1397 * dbusbind.c: Pointer signedness fixes.
1398 (xd_signature, xd_append_arg, xd_initialize):
1399 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1400 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1401 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1402 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1403
78320123
PE
1404 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1405 if GCC considers string literals to be constants.
49cebcca 1406 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1407
35ac2a97
SM
14082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1409
fb103ca9
SM
1410 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1411 (print_preprocess, print_object): New macro to fix last change.
1412
35ac2a97
SM
1413 * print.c (print_preprocess): Don't forget font objects.
1414
62973b41
JB
14152011-03-16 Juanma Barranquero <lekktu@gmail.com>
1416
1417 * emacs.c (USAGE3): Doc fixes.
1418
0e48bb22
AS
14192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1420
1421 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1422 structure.
1423
7684e57b
JB
14242011-03-14 Juanma Barranquero <lekktu@gmail.com>
1425
1426 * lisp.h (VWindow_system, Qfile_name_history):
1427 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1428 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1429 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1430
1431 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1432 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1433
1434 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1435 * w32console.c (detect_input_pending, read_input_pending)
1436 (encode_terminal_code):
1437 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1438 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1439 (w32_system_caret_y, Qfile_name_history):
1440 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1441 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1442 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1443 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1444 * w32proc.c (Qlocal, report_file_error):
1445 * w32term.c (Vwindow_system, updating_frame):
1446 * w32uniscribe.c (initialized, uniscribe_font_driver):
1447 Remove unneeded extern declarations.
1448
2aa46d6c
CY
14492011-03-14 Chong Yidong <cyd@stupidchicken.com>
1450
c96bbc66 1451 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1452
cffc6f3b
CY
14532011-03-13 Chong Yidong <cyd@stupidchicken.com>
1454
1455 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1456 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1457 These macros can no longer be used for assignment.
1458
44f230aa
SM
1459 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1460 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1461 (record_buffer_markers, fetch_buffer_markers): New functions for
1462 recording and fetching special buffer markers.
1463 (set_buffer_internal_1, set_buffer_temp): Use them.
1464
1465 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1466
1467 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1468
1469 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1470 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1471
1472 * xdisp.c (hscroll_window_tree):
1473 (reconsider_clip_changes): Use PT instead of BUF_PT.
1474
d251f04b
EZ
14752011-03-13 Eli Zaretskii <eliz@gnu.org>
1476
1477 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1478 $(EMACS_ROOT)/lib/intprops.h.
1479
f0c77cd1
PE
14802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1481
3eca4629
PE
1482 Fix more problems found by GCC 4.5.2's static checks.
1483
7c86ee98
PE
1484 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1485 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1486 (xg_free_frame_widgets): Make it clear that a local variable is
1487 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1488 (gdk_window_get_screen): Make it clear that this macro is needed
1489 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1490 (int_gtk_range_get_value): New function, which avoids a diagnostic
1491 from gcc -Wbad-function-cast.
1492 (xg_set_toolkit_scroll_bar_thumb): Use it.
1493 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1494 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1495 (get_utf8_string, xg_get_file_with_chooser):
1496 Rename locals to avoid shadowing.
1497 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1498
41729b81
PE
1499 * xgselect.c (xg_select): Remove unused var.
1500
f0c77cd1
PE
1501 * image.c (four_corners_best): Mark locals as initialized.
1502 (gif_load): Initialize transparent_p to zero (Bug#8238).
1503 Mark another local as initialized.
ec6cf4c6 1504 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1505
ce0ad53d 1506 * image.c (clear_image_cache): Now static.
d5d5a617 1507 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1508 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1509 (x_edge_detection): Remove unnecessary cast that
1510 gcc -Wbad-function-cast diagnoses.
2037898d 1511 (gif_load): Fix pointer signedness.
6ae141d6
PE
1512 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1513 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1514
33383987 15152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1516
d32df629
PE
1517 Improve quality of tests for time stamp overflow.
1518 For example, without this patch (encode-time 0 0 0 1 1
1519 1152921504606846976) returns the obviously-bogus value (-948597
1520 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1521 reports time overflow. See
1522 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1523 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1524 * editfns.c: Include limits.h and intprops.h.
1525 (TIME_T_MIN, TIME_T_MAX): New macros.
1526 (time_overflow): Move earlier, to before first use.
1527 (hi_time, lo_time): New functions, for an accurate test for
1528 out-of-range times.
1529 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1530 (Fget_internal_run_time): Don't assume time_t fits in int.
1531 (make_time): Use list2 instead of Fcons twice.
1532 (Fdecode_time): More accurate test for out-of-range times.
1533 (check_tm_member): New function.
1534 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1535 (lisp_time_argument): Don't rely on undefined left-shift and
1536 right-shift behavior when checking for time stamp overflow.
8be6f318 1537
fe31d94c
PE
1538 * editfns.c (time_overflow): New function, refactoring common code.
1539 (Fformat_time_string, Fdecode_time, Fencode_time):
1540 (Fcurrent_time_string): Use it.
1541
8be6f318
PE
1542 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1543 * dired.c (make_time): Move to ...
1544 * editfns.c (make_time): ... here.
1545 * systime.h: Note the move.
1546
09d9db2c 15472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1548
126bc0dc
YM
1549 * fringe.c (update_window_fringes): Remove unused variables.
1550
c47cbdfd
YM
1551 * unexmacosx.c (copy_data_segment): Also copy __got section.
1552 (Bug#8223)
1553
7ac80be9
EZ
15542011-03-12 Eli Zaretskii <eliz@gnu.org>
1555
c96bbc66 1556 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1557 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1558 Constify `char *' arguments and their references according to
1559 prototypes in tparam.h.
1560
ecb0f94d 1561 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1562
7ac80be9
EZ
1563 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1564 Adapt all references accordingly.
1565
1566 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1567
ef1fd07e
TT
15682011-03-11 Tom Tromey <tromey@redhat.com>
1569
1570 * buffer.c (syms_of_buffer): Remove obsolete comment.
1571
7ef4b50c
EZ
15722011-03-11 Eli Zaretskii <eliz@gnu.org>
1573
1574 * termhooks.h (encode_terminal_code): Declare prototype.
1575
1576 * msdos.c (encode_terminal_code): Don't declare prototype.
1577
1578 * term.c (encode_terminal_code): Now external again, used by
1579 w32console.c and msdos.c.
1580
44f230aa
SM
1581 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1582 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1583
4b1ec863 15842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1585
1714f52b 1586 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1587
4b1ec863
PE
1588 * fringe.c (update_window_fringes): Mark locals as initialized
1589 (Bug#8227).
1590 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1591
524c7aa6
PE
1592 * alloc.c (mark_fringe_data): Move decl from here ...
1593 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1594 to check its interface.
1595 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1596
a5c0af81 1597 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1598 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1599 (fontset_font): Mark local as initialized.
a9a06e0b 1600 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1601
b4716021
PE
1602 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1603
811e9bac 1604 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1605 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1606 (x_own_selection, Fx_disown_selection_internal): Rename locals
1607 to avoid shadowing.
1608 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1609
7e3ab302
PE
1610 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1611 so that the caller can use some name other than gcpro1.
1612 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1613 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1614 (Fx_backspace_delete_keys_p):
1615 Use them to avoid shadowing, and rename vars to avoid shadowing.
1616 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1617 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1618 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1619 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1620 Remove unused locals.
7e3ab302
PE
1621 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1622 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1623 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1624 macros.
f78faa98 1625
e2b13473
PE
1626 * xterm.h (x_mouse_leave): New decl.
1627
77f23912
PE
1628 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1629 Remove unused functions.
cdf4ba58
PE
1630 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1631 (x_calc_absolute_position): Now static.
7411c686 1632 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1633 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1634 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1635 unless they are used.
38d0b34a
PE
1636 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1637 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1638 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1639 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1640 (x_error_catcher, x_connection_closed, x_error_handler):
1641 (x_error_quitter, xembed_send_message, x_iconify_frame):
1642 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1643 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1644 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1645
44f230aa
SM
1646 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1647 Rename or move locals to avoid shadowing.
6b463e58 1648 (tty_defined_color, merge_face_heights): Now static.
5967d051 1649 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1650 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1651 does not deduce is never used uninitialized.
73719eba
PE
1652 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1653 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1654
426994c3 1655 * terminal.c (store_terminal_param): Now static.
5489860b 1656
032f1620 1657 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1658 (set_frame_menubar): Remove unused local.
d4323972 1659 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1660 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1661 since they might point to immutable storage.
281585b0
PE
1662 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1663 since it's unused otherwise.
032f1620 1664
367c19e5 1665 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1666 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1667 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1668 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1669 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1670 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1671 does not deduce are never used uninitialized.
70739cbe 1672
07b48fa9
PE
1673 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1674
8868a238 1675 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1676 * window.c (window_loop, size_window):
1677 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1678
7e5cf297 1679 * window.c (display_buffer): Now static.
d6550a9f
PE
1680 (size_window): Mark variables that gcc -Wuninitialized
1681 does not deduce are never used uninitialized.
a586633d
PE
1682 * window.h (check_all_windows): New decl, to forestall
1683 gcc -Wmissing-prototypes diagnostic.
5b555da1 1684 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1685
f6095868
PE
1686 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1687 shadowing.
1688 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1689 Include <limits.h>.
1690 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1691 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1692 (load_charset_map): Mark variables that gcc -Wuninitialized
1693 does not deduce are never used uninitialized.
53df7c11 1694 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1695
f38b440c
PE
1696 * coding.c (coding_set_source, coding_set_destination):
1697 Use "else { /* comment */ }" rather than "else /* comment */;"
1698 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1699 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1700 a block, when the outer 'i' will do.
1701 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1702 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1703 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1704 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1705 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1706 Rename locals to avoid shadowing.
1707 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1708 * coding.c (emacs_mule_char, encode_invocation_designation):
1709 Now static, since they're not used elsewhere.
413bb2db 1710 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1711 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1712 (decode_coding_emacs_mule): Mark variables that gcc
1713 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1714 (detect_coding_iso_2022): Initialize a local variable that might
1715 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1716 this initialization is needed. (Bug#8211)
5f58e762
PE
1717 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1718 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1719 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1720 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1721 Remove unused macros.
f38b440c 1722
232b38b9 1723 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1724 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1725 * character.c (string_count_byte8): Likewise.
232b38b9 1726
fb90da1b
PE
1727 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1728 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1729
fb93dbc2
PE
1730 * chartab.c (copy_sub_char_table): Now static, since it's not used
1731 elsewhere.
5c156ace
PE
1732 (sub_char_table_ref_and_range, char_table_ref_and_range):
1733 Rename locals to avoid shadowing.
bbcd0949 1734 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1735
7d3b3862 1736 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1737 (BIDI_BOB): Remove unused macro.
7d3b3862 1738
6be7d3da
PE
1739 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1740 deduce are never used uninitialized.
c2ed9c8b 1741 * term.c (encode_terminal_code): Likewise.
6be7d3da 1742
75f8807f 1743 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1744
50938595
PE
1745 * tparam.h: New file.
1746 * term.c, tparam.h: Include it.
1747 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1748 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1749 Move these decls to tparam.h, and make them agree with what
1750 is actually in tparam.c. The previous trick of using incompatible
1751 decls in different modules does not conform to the C standard.
1752 All callers of tparam changed to use tparam's actual API.
1753 * tparam.c (tparam1, tparam, tgoto):
1754 Use const pointers where appropriate.
1755
fbceeba2
PE
1756 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1757 * cm.h (struct cm): Likewise.
1758 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1759 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1760 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1761 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1762 (turn_on_face, init_tty): Likewise.
1763 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1764
7f3f1250
PE
1765 * term.c (term_mouse_position): Rename local to avoid shadowing.
1766
e6ca6543
PE
1767 * alloc.c (mark_ttys): Move decl from here ...
1768 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1769
c40f8d15
AS
17702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1773
cfe0661d
JB
17742011-03-09 Juanma Barranquero <lekktu@gmail.com>
1775
1776 * search.c (compile_pattern_1): Remove argument regp, unused since
1777 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1778 (compile_pattern): Don't pass it.
1779
0afb4571
J
17802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1781
1782 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1783 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1784 for ! HAVE_GTK3.
1785 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1786
1787 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1788
1789 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1790 gdk_window_get_screen, gdk_window_get_geometry,
1791 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1792 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1793 (xg_get_pixbuf_from_pixmap): New function.
1794 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1795 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1796 Call xg_get_pixbuf_from_pixmap instead of
1797 gdk_pixbuf_get_from_drawable.
1798 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1799 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1800 (xg_check_special_colors): Use GtkStyleContext and its functions
1801 for HAVE_GTK3.
1802 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1803 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1804 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1805 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1806 Call gtk_widget_get_preferred_size.
0afb4571
J
1807 (xg_frame_resized): gdk_window_get_geometry only takes 5
1808 parameters.
44f230aa
SM
1809 (xg_win_to_widget, xg_event_is_for_menubar):
1810 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1811 (xg_set_widget_bg): New function.
1812 (delete_cb): New function.
1813 (xg_create_frame_widgets): connect delete-event to delete_cb.
1814 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1815 (xg_set_background_color): Call xg_set_widget_bg.
1816 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1817 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1818 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1819 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1820 if ! HAVE_GTK3.
1821 (update_frame_tool_bar): Call gtk_widget_hide.
1822 (xg_initialize): Use GDK_KEY_g.
1823
1824 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1825 if ! HAVE_GTK3
1826 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1827
1828 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1829 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1830 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1831
1c2cc4ef
JB
18322011-03-08 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * w32xfns.c (select_palette): Check success of RealizePalette against
1835 GDI_ERROR, not zero.
1836
33383987 1837See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1838
1839;; Local Variables:
1840;; coding: utf-8
aac0c6e3
MR
1841;; End:
1842
33383987 1843 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1844
1845 This file is part of GNU Emacs.
1846
1847 GNU Emacs is free software: you can redistribute it and/or modify
1848 it under the terms of the GNU General Public License as published by
1849 the Free Software Foundation, either version 3 of the License, or
1850 (at your option) any later version.
1851
1852 GNU Emacs is distributed in the hope that it will be useful,
1853 but WITHOUT ANY WARRANTY; without even the implied warranty of
1854 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1855 GNU General Public License for more details.
1856
1857 You should have received a copy of the GNU General Public License
1858 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.