qp.el (quoted-printable-decode-region): Decode multiple bytes at once.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
31d02438
GM
12012-08-30 Glenn Morris <rgm@gnu.org>
2
3 * lread.c (init_lread): For out-of-tree builds, only add the
4 source directory's site-lisp dir to the load-path if it exists,
5 consistent with in-tree builds. (Bug#12302)
6
7f8941d8
JD
72012-08-28 Jan Djärv <jan.h.d@swipnet.se>
8
9 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
10 button_values to NULL. Call setStykeMask so dialogs get a close button.
11 (windowShouldClose:): Set window_closed.
12 (dealloc): New member, free button_values.
13 (process_dialog:): Make member function. Remove window argument,
14 replace window with self. Count buttons and allocate and store values
15 in button_values.
16 (addButton:value:row:): value is int with the name tag. Call setTag
17 with tag. Remove return self, declare return value as void.
18 (addString:row:): Remove return self, declare return value as void.
19 (addSplit): Remove return self, declare return value as void.
20 (clicked:): Remove return self, declare return value as void.
21 Set dialog_return to button_values[seltag]. Code formatting change.
22 (initFromContents:isQuestion:): Adjust call to process_dialog.
23 Code formatting change.
24 (timeout_handler:): Set timer_fired to YES.
25 (runDialogAt:): Set timer_fired to NO.
26 Handle click on close button as quit.
27
28 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
29 Add window_closed and button_values. Add void as return value for
30 add(Button|String|Split). addButton takes int instead of Lisp_Object.
31 Add process_dialog as new member.
32
eada0861 332012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 34
eada0861
GM
35 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
36 is not one of the heaps we manage. (Bug#12242)
37
382012-08-28 Glenn Morris <rgm@gnu.org>
39
40 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
41
457294dd
MR
422012-08-28 Martin Rudalics <rudalics@gmx.at>
43
44 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
45 auto-buffer-name window parameter. Install revision of reverted
46 fix.
457294dd 47
4f2daf31
DA
482012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
49
50 Do not allow to set major mode for a dead buffer.
51 * buffer.c (Fset_buffer_major_mode): Signal an error
52 if the buffer is dead.
53 (Fother_buffer, other_buffer_safely): Remove redundant
54 nested declaration.
55
66322887
DA
562012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
57
58 Always use set_buffer_if_live to restore original buffer at unwind.
59 * buffer.h (record_unwind_current_buffer): New function.
60 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
61 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
62 * undo.c, window.c: Adjust users.
63 * buffer.c (set_buffer_if_live): Fix comment.
64
a3d794a1
DA
652012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Fix usage of set_buffer_internal.
68 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
69 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
70 * coding.c (decode_coding): Omit redundant test.
71 * fileio.c (decide_coding_unwind): Likewise.
72 * fns.c (secure_hash): Likewise.
73 * insdel.c (modify_region): Likewise.
74 * keyboard.c (command_loop_1): Likewise.
75 * print.c (PRINTFINISH): Likewise.
76 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
77
59ea14cd
PE
782012-08-27 Paul Eggert <eggert@cs.ucla.edu>
79
80 * dispnew.c: Use bool for boolean.
81 (frame_garbaged, display_completed, delayed_size_change)
82 (fonts_changed_p, add_window_display_history)
83 (add_frame_display_history, verify_row_hash)
84 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
85 (row_equal_p, realloc_glyph_pool)
86 (allocate_matrices_for_frame_redisplay)
87 (showing_window_margins_p)
88 (adjust_frame_glyphs_for_frame_redisplay)
89 (build_frame_matrix_from_leaf_window, make_current)
90 (mirrored_line_dance, mirror_line_dance, update_frame)
91 (update_window_tree, update_single_window)
92 (check_current_matrix_flags, update_window, update_text_area)
93 (update_window_line, set_window_update_flags, scrolling_window)
94 (update_frame_1, scrolling, buffer_posn_from_coords)
95 (do_pending_window_change, change_frame_size)
96 (change_frame_size_1, sit_for):
97 Use bool for boolean.
98 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
99 and remove last int (actually boolean) argument, which was always 0.
100 All callers changed.
101 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
102 * dispextern.h (struct composition_it): Use bool for boolean.
103 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
104 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
105 * dired.c (file_name_completion):
106 Use bool for boolean. (This was missed in an earlier change.)
107
95072a94
MR
1082012-08-27 Martin Rudalics <rudalics@gmx.at>
109
110 * window.c (Fset_window_configuration): Revert first part of
111 last change.
112
0f19feff
JD
1132012-08-27 Jan Djärv <jan.h.d@swipnet.se>
114
115 * nsterm.h (NSPanel): New class variable dialog_return.
116
117 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
118 dialog_return.
119 (windowShouldClose:): Use stop instead of stopModalWithCode.
120 (clicked:): Ditto, and also set dialog_return (Bug#12258).
121 (timeout_handler:): Use stop instead of abortModal. Send a dummy
122 event.
123 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
124 modal loop returns.
125
f10fe38f
PE
1262012-08-27 Paul Eggert <eggert@cs.ucla.edu>
127
de1339b0
PE
128 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
129 * composite.c (find_composition, composition_gstring_p)
130 (composition_reseat_it, find_automatic_composition):
131 * data.c (let_shadows_buffer_binding_p)
132 (let_shadows_global_binding_p, set_internal, make_blv)
133 (Fmake_variable_buffer_local, Fmake_local_variable)
134 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
135 (cons_to_signed, arith_driver):
136 * dbusbind.c (xd_in_read_queued_messages):
137 * dired.c (directory_files_internal, file_name_completion):
138 Use bool for booleans.
139 * dired.c (file_name_completion):
140 * process.h (fd_callback):
141 Omit int (actually boolean) argument. It wasn't being used.
142 All uses changed.
143 * composite.h, lisp.h: Reflect above API changes.
144
f10fe38f
PE
145 * cmds.c, coding.c: Use bool for booleans.
146 * cmds.c (move_point, Fself_insert_command):
147 * coding.h (struct composition status, struct coding_system):
148 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
149 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
150 (emacs_mule_char, decode_coding_emacs_mule)
151 (encode_coding_emacs_mule, detect_coding_iso_2022)
152 (decode_coding_iso_2022, encode_invocation_designation)
153 (encode_designation_at_bol, encode_coding_iso_2022)
154 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
155 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
156 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
157 (encode_coding_raw_text, detect_coding_charset)
158 (decode_coding_charset, encode_coding_charset, detect_eol)
159 (detect_coding, get_translation_table, produce_chars)
160 (consume_chars, reused_workbuf_in_use)
161 (make_conversion_work_buffer, code_conversion_save)
162 (decode_coding_object, encode_coding_object)
163 (detect_coding_system, char_encodable_p)
164 (Funencodable_char_position, code_convert_region)
165 (code_convert_string, code_convert_string_norecord)
166 (Fset_coding_system_priority):
167 * fileio.c (Finsert_file_contents):
168 Use bool for booleans.
169 * coding.h, lisp.h: Reflect above API changes.
170 * coding.c: Remove unnecessary static function decls.
171 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
172 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
173 not a boolean 'int', since callers never look at the return value.
174 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
175 * coding.h (decoding_buffer_size, encoding_buffer_size)
176 (emacs_mule_string_char): Remove unused extern decls.
177 (struct iso_2022_spec, struct coding_system):
178 Use 'unsigned int : 1' for boolean fields, since there's more than one.
179 (struct emacs_mule_spec): Remove unused field 'full_support'.
180 All initializations removed.
181 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
182
5474c384
DA
1832012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
184
f10fe38f 185 Fix spare memory change (Bug#12286).
5474c384
DA
186 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
187 (valid_lisp_object_p): Likewise.
188
c4b6914d
MR
1892012-08-27 Martin Rudalics <rudalics@gmx.at>
190
191 * window.c (Fset_window_configuration): Record any window's old
192 buffer if it's replaced (see Bug#8789). If the new current
193 buffer doesn't appear in the selected window, go to its old
194 point (Bug#12208).
195
35aaa1ea
DA
1962012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
197
198 Special MEM_TYPE_SPARE to denote reserved memory.
199 * alloc.c (enum mem_type): New memory type.
200 (refill_memory_reserve): Use new type for spare memory.
201 This prevents live_cons_p and live_string_p from incorrect
202 detection of uninitialized objects from spare memory as live.
203
6af64513
PE
2042012-08-26 Paul Eggert <eggert@cs.ucla.edu>
205
8b2e00a3
PE
206 Spelling fixes.
207 * Makefile.in (.PHONY): versioclean -> versionclean.
208
b52d6985
PE
209 Remove unused external symbols.
210 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
211 * window.c (Qwindow_valid_p, decode_valid_window):
212 Now static, not extern.
213 * data.c (Qinterval): Remove; unused.
214 (syms_of_data): Do not define 'interval'.
215 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
216 * window.h (decode_valid_window):
217 Remove decls.
218
d5172d4f
PE
219 * character.c, charset.c, chartab.c: Use bool for booleans.
220 * character.c (lisp_string_width, string_count_byte8)
221 (string_escape_byte8):
222 * charset.c (charset_map_loaded, load_charset_map, read_hex):
223 (load_charset_map_from_file, map_charset_chars)
224 (Fdefine_charset_internal, define_charset_internal)
225 (Fdeclare_equiv_charset, find_charsets_in_text)
226 (Ffind_charset_region, char_charset, Fiso_charset):
227 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
228 (sub_char_table_set, sub_char_table_set_range)
229 (char_table_set_range, optimize_sub_char_table)
230 (map_sub_char_table):
231 Use bool for boolean.
232 * character.c (str_to_unibyte): Omit last boolean argument; it was
233 always 0. All callers changed.
234 * character.h, charset.h: Adjust to match previous changes.
235 * character.h (char_printable_p): Remove decl of nonexistent function.
236 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
237 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
238 are all boolean, so make them single-bit bitfields.
239
6af64513
PE
240 * lisp.h (ASET): Remove attempt to detect side effects.
241 It was meant to be temporary and it often doesn't work,
242 because when IDX has side effects the behavior of IDX==IDX
243 is undefined. See Stefan Monnier in
244 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
245
e1f29348
BR
2462012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
247
248 * lisp.h (functionp): New function (extracted from Ffunctionp).
249 (FUNCTIONP): Use it.
250 * eval.c (Ffunctionp): Use it.
251
17c05d74
PE
2522012-08-25 Paul Eggert <eggert@cs.ucla.edu>
253
0f46bc75
PE
254 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
255 as that's faster and simpler than static storage. Don't bother
256 with the g_main_context_query overhead if g_main_context_pending
257 says no events are pending.
258 (gfds, gfds_size): Remove these static vars.
259 (xgselect_initialize): Remove; no longer needed.
260 All uses and decls removed.
261
ee4c0f69
PE
262 * emacs.c (fatal_error_signal_hook): Remove.
263 All uses removed. This leftover from old code was always 0.
264
17c05d74
PE
265 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
266 * casefiddle.c (casify_object, casify_region):
267 * casetab.c (set_case_table):
268 * category.c, category.h (word_boundary_p):
269 * category.h (CHAR_HAS_CATEGORY):
270 Use bool for booleans, instead of int.
271
391ceac5
EZ
2722012-08-25 Eli Zaretskii <eliz@gnu.org>
273
274 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
275
2f221583
PE
2762012-08-25 Paul Eggert <eggert@cs.ucla.edu>
277
f4a681b0
PE
278 On assertion failure, print backtrace if available.
279 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
280 (die) [ENABLE_CHECKING]: Print a backtrace if available.
281 * Makefile.in (LIB_EXECINFO): New macro.
282 (LIBES): Use it.
283
2f221583
PE
284 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
285 * bytecode.c (exec_byte_code):
286 * callint.c (check_mark, Fcall_interactively):
287 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
288 (getenv_internal, sync_process_alive, call_process_exited):
289 * lisp.h (USE_SAFE_ALLOCA):
290 Use bool for booleans, instead of int.
291 * lisp.h, process.h: Adjust prototypes to match above changes.
292 * callint.c (Fcall_interactively): Don't assume the mark's
293 offset fits in 'int'.
294
37ef52bb
PE
2952012-08-24 Paul Eggert <eggert@cs.ucla.edu>
296
297 * buffer.c, buffer.h: Use bool for boolean.
298 * buffer.c (reset_buffer_local_variables)
299 (buffer_lisp_local_variables, Fset_buffer_modified_p)
300 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
301 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
302 (overlay_touches_p, overlay_strings, Foverlay_put)
303 (report_overlay_modification, call_overlay_mod_hooks):
304 (mmap_enlarge, mmap_set_vars):
305 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
306 Use bool for booleans, instead of int.
307 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
308 since the 1-or-0 return value is always ignored anyway.
309 (mmap_initialized_p):
310 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
311 * buffer.h, lisp.h: Adjust prototypes to match above changes.
312
2cc21167
PE
3132012-08-23 Paul Eggert <eggert@cs.ucla.edu>
314
315 * bidi.c: Use bool for boolean.
316 This is a bit more readable, and makes the text segment of bidi.o
317 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
318 Presumably it's faster too.
319 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
320 Now bool.
321 (bidi_cache_find_level_change, bidi_cache_iterator_state)
322 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
323 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
324 (bidi_explicit_dir_char, bidi_level_of_next_char)
325 (bidi_find_other_level_edge, bidi_move_to_visually_next):
326 Use bool for booleans, instead of int.
327 * dispextern.h (bidi_init_it, bidi_paragraph_init)
328 (bidi_unshelve_cache): Adjust decls to match code.
329
7db4ddf4
MR
3302012-08-23 Martin Rudalics <rudalics@gmx.at>
331
332 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
333 argument.
334
b1bb8011
PE
3352012-08-23 Paul Eggert <eggert@cs.ucla.edu>
336
337 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
338 * atimer.h: Include <stdbool.h>.
339
ff687885
DN
3402012-08-22 Dan Nicolaescu <dann@gnu.org>
341
342 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
343 compile time tests instead of run time tests on systems that do
344 not use them.
345 (FRAME_MAC_P): Remove leftover from deleted code.
346 * frame.c (syms_of_frame): Remove leftover from deleted code.
347
4ce7a138
JD
3482012-08-22 Jan Djärv <jan.h.d@swipnet.se>
349
350 * nsterm.m (insertText:): Don't clear modifiers if code is space.
351
d733ec6d
PE
3522012-08-22 Paul Eggert <eggert@cs.ucla.edu>
353
354 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
355 Otherwise, the compiler complains about (A?B:C) where B is void
356 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
357 (fontset_add): Return void, for FONTSET_ADD.
358
d0d2d26f
PE
3592012-08-21 Paul Eggert <eggert@cs.ucla.edu>
360
fce31d69
PE
361 * alloc.c: Use bool for booleans.
362 (gc_in_progress, abort_on_gc)
363 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
364 (dont_register_blocks) [GC_MALLOC_CHECK]:
365 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
366 (check_string_bytes, make_specified_string, memory_full)
367 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
368 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
369 (mark_stack, valid_pointer_p, make_pure_string)
370 (Fgarbage_collect, survives_gc_p, gc_sweep):
371 Use bool for booleans, instead of int.
372 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
373 Remove unused local.
374 * alloc.c (PURE_POINTER_P):
375 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
376 * editfns.c (Fformat):
377 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
378 (Fdo_auto_save):
379 * fns.c (sweep_weak_table):
380 * lisp.h (suppress_checking, push_message, survives_gc_p)
381 (make_pure_string, gc_in_progress, abort_on_gc):
382 * lread.c (readchar, read1):
383 * print.c (Fprin1_to_string):
384 * xdisp.c (push_message):
385 Use bool for booleans affected directly or indirectly by
386 alloc.c's changes.
387
d0d2d26f
PE
388 Make recently-introduced setters macros.
389 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
390 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
391 (set_fontset_default, set_fontset_fallback): Rename from their
392 upper-case counterparts, and make them functions rather than macros.
393 This is more consistent with the other recently-introduced setters.
394 These don't need to be inline, since they're local.
395
d18e2bb6
JD
3962012-08-21 Jan Djärv <jan.h.d@swipnet.se>
397
398 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
399 the loop (Bug#12247).
400
1b9d9d16
PE
4012012-08-21 Paul Eggert <eggert@cs.ucla.edu>
402
403 * lisp.h (vcopy): Use memcpy rather than our own loop.
404 This fixes a performance regression introduced by the recent
405 addition of vcopy. This means 'vcopy' will need to be modified
406 for a copying collector, but that's OK. Also, tighten the
407 checking in the assertion.
408
b2f09701
EZ
4092012-08-21 Eli Zaretskii <eliz@gnu.org>
410
411 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
412 components for RTL text (Bug#11860). Adjust X-OFFSET of each
413 non-base glyph for the width of the base character, according to
e1f29348
BR
414 what x_draw_composite_glyph_string_foreground expects.
415 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
416 expectations, to produce correct width of the composed character.
417 Reverse the sign of the DU offset produced by ScriptPlace.
418
9b994fed
PE
4192012-08-21 Paul Eggert <eggert@cs.ucla.edu>
420
421 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
422
086ca913
DA
4232012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
424
425 Avoid direct writes to contents member of struct Lisp_Vector.
426 * lisp.h (vcopy): New function to copy data into vector.
427 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
428 * fns.c (Ffillarray): Use ASET.
429 * keyboard.c (timer_check_2): Use AREF and ASET.
430 (append_tool_bar_item, Frecent_keys): Use vcopy.
431 * lread.c (read_vector): Use ASET.
432 * msdos.c (Frecent_doskeys): Use vcopy.
433 * xface.c (Finternal_copy_lisp_face): Use vcopy.
434 (Finternal_merge_in_global_face): Use ASET and vcopy.
435 * xfont.c (xfont_list_pattern): Likewise.
436
5481664a
MR
4372012-08-21 Martin Rudalics <rudalics@gmx.at>
438
439 * window.c (Fwindow_point): For the selected window always return
440 the position of its buffer's point.
441 (Fset_window_point): For the selected window always go in its
442 buffer to the specified position.
443
6d470bdd
DA
4442012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
445
446 Setter macros for fontsets.
447 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
448 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
449 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
450 Adjust users.
451
24564fe1
GM
4522012-08-20 Glenn Morris <rgm@gnu.org>
453
454 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
455 Don't assume that `ln -f' works.
456
0a05a035
EZ
4572012-08-20 Eli Zaretskii <eliz@gnu.org>
458
459 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
460 and later about non-assignments with no effect. See discussion at
461 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
462 details.
463
e46f2325
DA
4642012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
465
466 Inline setter functions for Lisp_Objects slots of struct specbinding.
467 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
468 Adjust users.
469
734fbd86
MR
4702012-08-20 Martin Rudalics <rudalics@gmx.at>
471
472 * window.c (select_window): Always make selected window's buffer
473 current.
474
f1a95992
DA
4752012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
476
477 Use AREF and ASET for docstrings of category tables.
478 * category.h (CATEGORY_DOCSTRING): Use AREF.
479 (SET_CATEGORY_DOCSTRING): Use ASET.
480 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
481
e83064be
DA
4822012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
483
484 Inline setter functions for hash table members.
485 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
486 (set_hash_hash, set_hash_index): Rename with _slot suffix.
487 (set_hash_key_and_value, set_hash_index, set_hash_next)
488 (set_hash_hash): New functions.
489 * charset.c, fns.c: Adjust users.
490
4ce60d2e
DA
4912012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
492
493 Inline getter and setter functions for per-buffer values.
494 * buffer.h (per_buffer_default, set_per_buffer_default)
495 (per_buffer_value, set_per_buffer_value): New functions.
496 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
497 * buffer.c, data.c: Adjust users.
498
c06c9690
JB
4992012-08-20 Juanma Barranquero <lekktu@gmail.com>
500
501 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
502
32bd4250
PE
5032012-08-19 Paul Eggert <eggert@cs.ucla.edu>
504
bad03192 505 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
506 as gnulib does this if the system doesn't.
507 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
508 Remove declaration. MS-Windows declares it on stdlib.h which is
509 included by conf_post.h.
b69a6d22
PE
510 * emacs.c (environ) [DOUG_LEA_MALLOC]:
511 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
512 * vm-limit.c: Include <unistd.h>, for 'environ'.
513
22d7feb2
PE
514 * unexaix.c, unexcoff.c: Include "mem-limits.h".
515 (start_of_data): Remove decl; mem-limits.h provides it.
516
32bd4250
PE
517 * xdisp.c (handle_invisible_prop): Make it a bit faster
518 and avoid a gcc -Wmaybe-uninitialized diagnostic.
519
450809af
CY
5202012-08-19 Chong Yidong <cyd@gnu.org>
521
522 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
523 ends (Bug#3874).
524
9e677988
AS
5252012-08-19 Andreas Schwab <schwab@linux-m68k.org>
526
6b1319ce
AS
527 * .gdbinit: Use call instead of set when calling a function in the
528 inferior.
529
9e677988
AS
530 * data.c (set_internal): Don't use set_blv_found.
531 (Fkill_local_variable): Likewise.
532
d7191076
AA
5332012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
534
535 * nsfont.m (ns_ascii_average_width): Ensure the string
536 ascii_printable is initialized with a null-terminated character
537 array. Otherwise, it can contain undesired extra characters.
538
e757f1c6
PE
5392012-08-18 Paul Eggert <eggert@cs.ucla.edu>
540
541 port new setting code to Sun C 5.8 2005/10/13
542 * chartab.c, lisp.h (char_table_set, char_table_set_range):
543 Return void, not Lisp_Object. Otherwise, the compiler
544 complains about (A?B:C) where B is void and C is Lisp_Object
545 when compiling CHAR_TABLE_SET, due to the recent change to
546 the API of sub_char_table_set_contents.
547
a999ce26
CY
5482012-08-18 Chong Yidong <cyd@gnu.org>
549
550 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
551 for the string case (Bug#3874).
552
3f22b86f
PE
5532012-08-18 Paul Eggert <eggert@cs.ucla.edu>
554
39eb03f1
PE
555 * buffer.h (BSET): Remove (Bug#12215).
556 Replace all uses with calls to new setter functions.
557 (bset_bidi_paragraph_direction, bset_case_canon_table)
558 (bset_case_eqv_table, bset_directory, bset_display_count)
559 (bset_display_time, bset_downcase_table)
560 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
561 (bset_last_selected_window, bset_local_var_alist)
562 (bset_mark_active, bset_point_before_scroll, bset_read_only)
563 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
564 (bset_width_table):
565 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
566 (bset_auto_fill_function, bset_auto_save_file_format)
567 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
568 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
569 (bset_cache_long_line_scans, bset_case_fold_search)
570 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
571 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
572 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
573 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
574 (bset_header_line_format, bset_indicate_buffer_boundaries)
575 (bset_indicate_empty_lines, bset_invisibility_spec)
576 (bset_left_fringe_width, bset_major_mode, bset_mark)
577 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
578 (bset_name, bset_overwrite_mode, bset_pt_marker)
579 (bset_right_fringe_width, bset_save_length)
580 (bset_scroll_bar_width, bset_scroll_down_aggressively)
581 (bset_scroll_up_aggressively, bset_selective_display)
582 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
583 (bset_word_wrap, bset_zv_marker):
584 * category.c (bset_category_table):
585 * syntax.c (bset_syntax_table):
586 New setter functions.
587
6a09a33b
PE
588 * process.h (PSET): Remove (Bug#12215).
589 Replace all uses with calls to new setter functions.
590 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
591 (PROCESS_INLINE): New macro.
592 (pset_childp): New setter function.
593 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
594 * process.c (PROCESS_INLINE):
595 Define to EXTERN_INLINE, so that the corresponding functions
596 are compiled into code.
597 (pset_buffer, pset_command, pset_decode_coding_system)
598 (pset_decoding_buf, pset_encode_coding_system)
599 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
600 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
601 (pset_type, pset_write_queue): New setter functions.
602
e8c17b81
PE
603 * window.h (WSET): Remove (Bug#12215).
604 Replace all uses with calls to new setter functions.
605 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
606 (WINDOW_INLINE): New macro.
607 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
608 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
609 (wset_total_lines, wset_vertical_scroll_bar)
610 (wset_window_end_pos, wset_window_end_valid)
611 (wset_window_end_vpos): New setter functions.
612 * window.c (WINDOW_INLINE):
613 Define to EXTERN_INLINE, so that the corresponding functions
614 are compiled into code.
615 (wset_combination_limit, wset_dedicated, wset_display_table)
616 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
617 (wset_new_normal, wset_new_total, wset_next_buffers)
618 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
619 (wset_prev_buffers, wset_right_fringe_width)
620 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
621 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
622 (wset_window_parameters):
623 * xdisp.c (wset_base_line_number, wset_base_line_pos)
624 (wset_column_number_displayed, wset_region_showing):
625 New setter functions.
626
3f22b86f
PE
627 * termhooks.h (TSET): Remove (Bug#12215).
628 Replace all uses with calls to new setter functions.
629 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
630 (TERMHOOKS_INLINE): New macro.
631 (tset_charset_list, tset_selection_alist): New setter functions.
632 * terminal.c (TERMHOOKS_INLINE):
633 Define to EXTERN_INLINE, so that the corresponding functions
634 are compiled into code.
635 (tset_param_alist): New setter function.
636
742af32f
PE
6372012-08-17 Paul Eggert <eggert@cs.ucla.edu>
638
15dbb4d6
PE
639 * keyboard.h (KSET): Remove (Bug#12215).
640 Replace all uses with calls to new setter functions.
641 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
642 (KEYBOARD_INLINE): New macro.
643 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
644 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
645 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
646 New setter functions.
647 * keyboard.c (KEYBOARD_INLINE):
648 Define to EXTERN_INLINE, so that the corresponding functions
649 are compiled into code.
650 (kset_echo_string, kset_kbd_queue)
651 (kset_keyboard_translate_table, kset_last_prefix_arg)
652 (kset_last_repeatable_command, kset_local_function_key_map)
653 (kset_overriding_terminal_local_map, kset_real_last_command)
654 (kset_system_key_syms): New setter functions.
655
f00af5b1
PE
656 * frame.h (FSET): Remove (Bug#12215).
657 Replace all uses with calls to new setter functions.
658 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
659 (FRAME_INLINE): New macro.
660 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
661 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
662 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
663 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
664 (fset_param_alist, fset_root_window, fset_scroll_bars)
665 (fset_selected_window, fset_title, fset_tool_bar_items)
666 (fset_tool_bar_position, fset_tool_bar_window): New functions.
667 * frame.c (FRAME_INLINE):
668 Define to EXTERN_INLINE, so that the corresponding functions
669 are compiled into code.
670 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
671
0c94c8d6
PE
672 A few more naming-convention fixes for getters and setters.
673 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
674 and rename from buffer_overlays_set_before.
675 (set_buffer_overlays_after): Move here from buffer.h, and rename
676 from buffer_overlays_set_after.
677 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
678 All uses changed.
679 (set_buffer_intervals): Rename from buffer_set_intervals.
680 * intervals.c (set_interval_object): Move here from intervals.h,
681 and rename from interval_set_object.
682 (set_interval_left): Move here from intervals.h, and rename from
683 interval_set_left.
684 (set_interval_right): Move here from intervals.h, and rename from
685 interval_set_right.
686 (copy_interval_parent): Move here from intervals.h, and rename from
687 interval_copy_parent.
688 * intervals.h (set_interval_parent): Rename from interval_set_parent.
689 (set_interval_plist): Rename from interval_set_plist.
690 Return void, not Lisp_Object, since no caller uses the result.
691 * lisp.h (string_intervals): Rename from string_get_intervals.
692 (set_string_intervals): Rename from string_set_intervals.
693
34dabdb7
PE
694 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
695 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 696 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
697 All uses changed. See the end of
698 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
699
742af32f
PE
700 * lisp.h (CSET): Remove (Bug#12215).
701 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
702 (set_char_table_purpose): New functions,
703 replacing CSET. All uses changed. For example, replace
704 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 705 "set_char_table_parent (char_table, parent);".
742af32f
PE
706 The old version was confusing because it used the same name
707 'parent' for two different things.
708
a04e2c62
DA
7092012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
710
711 Functions to get and set Lisp_Object fields of buffer-local variables.
712 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
713 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
714 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
715 * data.c, eval.c, frame.c: Adjust users.
716
383dcbf9
CY
7172012-08-17 Chong Yidong <cyd@gnu.org>
718
719 * xfaces.c (merge_face_vectors): If the target font specfies a
720 font spec, make the font's attributes take precedence over
721 directly-specified attributes.
722 (merge_face_ref): Recognize :font.
723
44386687
DA
7242012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
725
726 Do not use memcpy for copying intervals.
727 * intervals.c (reproduce_interval): New function.
728 (reproduce_tree, reproduce_tree_obj): Use it.
729 (reproduce_tree_obj): Remove prototype.
730
927c7216
PE
7312012-08-17 Paul Eggert <eggert@cs.ucla.edu>
732
733 * lisp.h (duration_to_sec_usec): Remove unused decl.
734
93044f7b
AA
7352012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
736
737 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
738 to an allocated instance of NSString, not to the class itself.
739
9851e4a5
JB
7402012-08-17 Juanma Barranquero <lekktu@gmail.com>
741
742 * makefile.w32-in (C_CTYPE_H): New macro.
743 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
744 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
745 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
746
620f13b0
PE
7472012-08-16 Paul Eggert <eggert@cs.ucla.edu>
748
749 Use ASCII tests for character types.
750 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
751 * xfns.c, xterm.c:
752 Don't include <ctype.h>; was not needed.
753 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
754 * sysdep.c, xfaces.c:
755 Include <c-ctype.h> instead of <ctype.h>.
756 * nsterm.m: Include <c-ctype.h>.
757 * charset.c (read_hex):
758 * doc.c (Fsnarf_documentation):
759 * fileio.c (IS_DRIVE) [WINDOWSNT]:
760 (DRIVE_LETTER) [DOS_NT]:
761 (Ffile_name_directory, Fexpand_file_name)
762 (Fsubstitute_in_file_name):
763 * font.c (font_parse_xlfd, font_parse_fcname):
764 * frame.c (x_set_font_backend):
765 * gtkutil.c (xg_get_font):
766 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
767 * nsimage.m (hexchar):
768 * nsterm.m (ns_xlfd_to_fontname):
769 * sysdep.c (system_process_attributes):
770 * xfaces.c (hash_string_case_insensitive):
771 Use C-locale tests instead of locale-specific tests for character
772 types, since we want the ASCII interpretation here, not the
773 interpretation suitable for whatever happens to be the current locale.
774
52162052
MR
7752012-08-16 Martin Rudalics <rudalics@gmx.at>
776
777 Consistently check windows for validity/liveness
778 (Bug#11984, Bug#12025, Bug#12026).
779 * lisp.h (CHECK_VALID_WINDOW): New macro.
780 * window.c (decode_window): Rename to decode_live_window.
781 (decode_valid_window, Fwindow_valid_p): New functions.
782 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
783 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
784 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
785 (Fwindow_prev_sibling, Fwindow_combination_limit)
786 (Fset_window_combination_limit, Fwindow_use_time)
787 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
788 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
789 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
790 (Fwindow_hscroll, Fset_window_hscroll)
791 (Fwindow_redisplay_end_trigger)
792 (Fset_window_redisplay_end_trigger, Fwindow_edges)
793 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
794 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
795 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
796 (Fwindow_end, Fset_window_point, Fset_window_start)
797 (Fpos_visible_in_window_p, Fwindow_line_height)
798 (Fwindow_dedicated_p, Fset_window_dedicated_p)
799 (Fwindow_prev_buffers, Fset_window_prev_buffers)
800 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
801 (Fset_window_parameter, Fwindow_display_table)
802 (Fset_window_display_table, Fdelete_other_windows_internal)
803 (Fset_window_buffer, Fset_window_new_total)
804 (Fset_window_new_normal, Fdelete_window_internal)
805 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
806 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
807 (Fwindow_scroll_bars): Check whether argument window is a valid or
808 live window. Update doc-strings.
809 (syms_of_window): New symbol Qwindow_valid_p.
810 * keyboard.c (Fposn_at_x_y): Check whether argument
811 frame_or_window denotes a valid window.
812
2751c80f
DA
8132012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
814
815 Fix previous char table change.
816 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
817 * chartab.c (optimize_sub_char_table): Likewise.
818
032a42c8
CY
8192012-08-16 Chong Yidong <cyd@gnu.org>
820
a2d19368
CY
821 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
822
032a42c8
CY
823 * xfont.c (xfont_open):
824 * xftfont.c (xftfont_open): Set the font's max_width field.
825
826 * nsfont.m (nsfont_open): Similar to the Xft backend, set
827 min_width to space_width and average_width to the average over
828 printable ASCII characters.
829 (ns_char_width): Code cleanup.
830 (ns_ascii_average_width): New utility function.
831
832 * font.h (struct font): Update comments.
833
a098c930
DA
8342012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
835
032a42c8 836 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
837 * lisp.h (CSET): New macro.
838 (char_table_set_extras, char_table_set_contents)
839 (sub_char_table_set_contents): New function.
840 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
841 * syntax.c: Adjust users.
842
8be3a09c
SM
8432012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
844
845 * eval.c (eval_sub): Bind lexical-binding.
846 * lread.c (Qlexical_binding): Make non-static.
847
ac4845a6
JD
8482012-08-15 Jan Djärv <jan.h.d@swipnet.se>
849
ddee6515
JD
850 * nsmenu.m (popupSession): Remove.
851 (pop_down_menu): Remove endModalSession.
852 (timeout_handler:): New method.
853 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
854 Call runModalForWindow. Check timer_fired when it returns.
855 If not set, cancel timer and break out of loop.
856 Otherwise loop again, with a new timeout.
857
858 * nsterm.m: Include fcntl.h if present.
859 (fd_entry, t_readfds, inNsSelect): Remove.
860 (select_writefds, select_valid, select_timeout, selfds)
861 (select_mutex, apploopnr): Add.
862 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
863 Otherwise call kbd_buffer_store_event.
864 (ns_send_appdefined): Remove release of fd_entry.
865 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
866 Increment and decrement apploopnr.
867 (ns_select): If no file descriptors, just do a NSTimer.
868 Otherwise copy read/write masks and start select thread (fd_handler).
869 Start main loop and wait for application defined event.
870 Inform select thread to stop selecting after main loop is exited.
871 (ns_term_init): Create selfds pipe and set non-blocking.
872 Initialize select_mutex. Start the select thread (fd_handler).
873 (fd_handler:): Loop forever, wait for info from the main thread
874 to either start or stop selecting. When select returns, send
875 and appdefined event.
876 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
877 If not call kbd_buffer_store_event.
878
879 * nsterm.h (EmacsApp): fd_handler takes id argument.
880 (EmacsDialogPanel): Add timer_fired and timeout_handler.
881
ac4845a6
JD
882 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
883
eb424fe3
EZ
8842012-08-15 Eli Zaretskii <eliz@gnu.org>
885
886 * region-cache.c (move_cache_gap): Update gap_len using the actual
887 growth of the boundaries array. Do not change cache_len.
888 (Bug#12196)
889
4e6a86c6
DA
8902012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
891
892 Generalize and cleanup font subsystem checks.
893 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
894 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
895 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 896
5bf192ca
DA
8972012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
898
899 * gtkutil.c (xg_get_font): Use pango_units_to_double.
900
f2045622
CY
9012012-08-15 Chong Yidong <cyd@gnu.org>
902
8be3a09c
SM
903 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
904 When using the new font chooser, use gtk_font_chooser_get_font_desc to
905 extract the font descriptor instead of just the font name.
906 In that case, return a font spec instead of a string.
f2045622
CY
907 (x_last_font_name): Move to this file from xfns.c.
908
909 * xfns.c (Fx_select_font): The return value can also be a font
910 spec. Move x_last_font_name management to gtkutil.c.
911
912 * xfaces.c: Make font weight and style symbols non-static.
913
7f6feb56
SM
9142012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
915
916 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
917 (bug#12117).
918
fecbd8ff
SM
9192012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
920
921 * alloc.c (Fgarbage_collect): Use plural form consistently.
922
9b8d5165
EZ
9232012-08-14 Eli Zaretskii <eliz@gnu.org>
924
925 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
926 iteration through the command loop. Fixes a problem whereby mouse
927 movements are ignored until the first mouse click.
928
f5d9e83a
PE
9292012-08-14 Paul Eggert <eggert@cs.ucla.edu>
930
931 Use bool, not int, for Lisp booleans.
932 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
933 makes Emacs a bit smaller and presumably a bit faster.
934 * lisp.h: Include <stdbool.h>.
935 (struct Lisp_Boolfwd, defvar_bool):
936 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
937 * regex.c [!emacs]: Include <stdbool.h>.
938 (false, true): Remove; <stdbool.h> does this for us now.
939
55802e4a
CY
9402012-08-14 Chong Yidong <cyd@gnu.org>
941
4abcdac8
CY
942 * character.c (Fcharacterp): Doc fix (Bug#12076).
943
944 * data.c (Findirect_variable): Doc fix (Bug#11040).
945
55802e4a
CY
946 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
947
948 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 949 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 950
8e99d072
BR
9512012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
952
953 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
954 (bug#12022).
955
08908aca
MR
9562012-08-14 Martin Rudalics <rudalics@gmx.at>
957
958 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
959 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
960 * minibuf.c (choose_minibuf_frame, read_minibuf):
961 * w32fns.c (x_create_tip_frame):
962 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
963 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
964
56120d6f
PE
9652012-08-14 Paul Eggert <eggert@cs.ucla.edu>
966
967 * intervals.c (offset_intervals): Remove obsolete comment.
968
67b77c0b
AS
9692012-08-14 Andreas Schwab <schwab@linux-m68k.org>
970
971 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
972
f48b82fd
GR
9732012-08-14 Gergely Risko <gergely@risko.hu>
974
975 * coding.c (decode_coding): Record buffer modification before
976 disabling undo_list (Bug#11773).
977
fd318b54
DA
9782012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
979
980 Revert and cleanup some recent overlay changes.
981 * buffer.h (enum overlay_type): Remove.
982 (buffer_get_overlays, buffer_set_overlays): Likewise.
983 (buffer_set_overlays_before, buffer_set_overlays_after):
984 New function. Adjust users.
985 (unchain_both): Add eassert.
986
41a62dd9
DA
9872012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
988
989 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
990
5884c324
PE
9912012-08-14 Paul Eggert <eggert@cs.ucla.edu>
992
993 * gtkutil.c (xg_mark_data): Don't assume C99.
994
ca06f160
JD
9952012-08-13 Jan Djärv <jan.h.d@swipnet.se>
996
997 * gtkutil.c (xg_frame_tb_info): New struct.
998 (TB_INFO_KEY): New define.
999 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1000 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1001 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1002 if not present.
1003 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1004 is up to date. Otherwise store new data.
1005 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1006
7864a3f7
DA
10072012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1008
1009 Use KSET for write access to Lisp_Object members of struct kboard.
1010 * keyboard.h (KSET): New macro.
1011 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1012 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1013 * xterm.c: Adjust users.
1014
4c31be61
DA
10152012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1016
1017 Use BSET for write access to Lisp_Object members of struct buffer.
1018 * buffer.h (BSET): New macro.
1019 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1020 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1021 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1022 * window.c, xdisp.c, xfns.c: Adjust users.
1023
14ae4239
BT
10242012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1025
1026 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1027
32bcadb4
JD
10282012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1029
3d29b2ce
JD
1030 * nsterm.m (not_in_argv): New function.
1031 (application:openFile, application:openTempFile:):
1032 (application:openFileWithoutUI:, application:openFiles:): Open file
1033 if not_in_argv returns non-zero (bug#12171).
1034
32bcadb4 1035 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1036 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1037 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1038 (xg_get_font_name): Use those functions/macros here.
1039 Reported by Frans Oilinki <moilinki@gmail.com>.
1040
9ff9402d 10412012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1042
1043 * unexmacosx.c (copy_data_segment): Copy initialized data in
1044 statically linked libraries from input file rather than memory.
1045
db74a5fc
YM
1046 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1047 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1048 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1049
25e65510
GM
10502012-08-10 Glenn Morris <rgm@gnu.org>
1051
1052 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1053 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1054
7961135c
DA
10552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1056
1057 Fix last change to allow compilation with low optimization levels.
1058 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1059 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1060
42b3a444
DA
10612012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 Use common inline syntax in intervals.h.
1064 * intervals.h (INTERVALS_INLINE): New macro.
1065 Change all users from LISP_INLINE.
1066
9fb0c957
DA
10672012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 Define Qnone once for all platforms.
1070 * frame.c (Qnone): Define here.
1071 (syms_of_frame): DEFSYM it.
1072 * lisp.h (Qnone): New declaration.
1073 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1074 * xfns.c: Remove duplication. Adjust users.
1075
65e8ee52
DA
10762012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 Remove unused macros from intervals.h.
1079 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1080 * intervals.c: Adjust comment.
1081
9b855fd6
EZ
10822012-08-10 Eli Zaretskii <eliz@gnu.org>
1083
1084 * w32fns.c <w32_unicode_gui>: New static variable.
1085 (globals_of_w32fns): Initialize it according to os_subtype.
1086 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1087 testing os_subtype.
1088
39cb9e56 10892012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1090 Eli Zaretskii <eliz@gnu.org>
1091
1092 Fix bug #10299 with Unicode characters sent by customized
1093 keyboards created by MSKLC.
1094 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1095 (w32_init_class): Use it to initialize the Emacs class with either
1096 ANSI or Unicode API calls.
1097 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1098 later.
1099 (w32_wnd_proc): If the character code sent by WM_CHAR or
1100 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1101 original message. Call DefWindowProcW on NT and later.
1102
9374581a
GM
11032012-08-10 Glenn Morris <rgm@gnu.org>
1104
4b94e8cf
GM
1105 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1106
9374581a
GM
1107 * lisp.h (DIRECTORY_SEP): Let configure set it.
1108
a2752828
DA
11092012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 Use TSET for write access to Lisp_Object slots of struct terminal.
1112 * termhooks.h (TSET): New macro.
1113 * coding.c, terminal.c, xselect.c: Adjust users.
1114
cc92c454
SM
11152012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1118 the failing expression, include them in the error message.
1119 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1120 * lisp.h (internal_condition_case_n): Update declaration.
1121
4cb3e6b3
DA
11222012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1123
1124 Inline functions to examine and change buffer overlays.
1125 * buffer.c (unchain_both): New function.
1126 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1127 (buffer_has_overlays): New function.
1128 (enum overlay_type): New enum.
1129 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1130 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1131
8707c1e5
DA
11322012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1133
1134 Inline functions to examine and change buffer intervals.
1135 * alloc.c (mark_interval_tree): Remove.
1136 (MARK_INTERVAL_TREE): Simplify.
1137 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1138 * intervals.c (buffer_balance_intervals): New function.
1139 (graft_intervals_into_buffer): Adjust indentation.
1140 (set_intervals_multibyte): Simplify.
1141 * buffer.h (BUF_INTERVALS): Remove.
1142 (buffer_get_intervals, buffer_set_intervals): New function.
1143 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1144 * intervals.c, textprop.c: Adjust users.
1145
ad8c997f
DA
11462012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1147
1148 Inline functions to examine and change string intervals.
1149 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1150 (string_get_intervals, string_set_intervals): New function.
1151 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1152 * lread.c, print.c, textprop.c: Adjust users.
1153
32ac3a6b
GM
11542012-08-08 Glenn Morris <rgm@gnu.org>
1155
1156 * lisp.mk (lisp): Remove language/persian.elc.
1157
77c7bcb1
DA
11582012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1159
1160 Cleanup intervals.
1161 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1162 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1163 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1164 Adjust comment. Move under #if 0.
77c7bcb1
DA
1165 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1166 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1167
9c08a8d4
DA
11682012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1169
1170 Check total length of intervals with eassert.
1171 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1172 * intervals.c: Change all users to eassert.
1173
26d16b35
EZ
11742012-08-07 Eli Zaretskii <eliz@gnu.org>
1175
14ae4239
BT
1176 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1177 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1178 INTERNAL_FIELD in Lisp_Cons.
1179
c644523b
DA
11802012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1181
1182 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1183 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1184 name since all xname users are fixed long time ago. Do not
1185 use INTERNAL_FIELD.
1186 (set_symbol_name, set_symbol_function, set_symbol_plist):
1187 (set_symbol_next, set_overlay_plist): New function.
1188 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1189 (struct Lisp_Overlay): Likewise.
1190 (CVAR, MVAR, SVAR): Remove.
1191 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1192 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1193 * xterm.c: Adjust users.
1194 * .gdbinit: Change to use name field of struct Lisp_Symbol
1195 where appropriate.
1196
6a3d20cc
DA
11972012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1198
1199 Basic functions to set Lisp_Object and pointer slots of intervals.
1200 * intervals.h (interval_set_parent, interval_set_object):
1201 (interval_set_left, interval_set_right, interval_set_plist):
1202 (interval_copy_parent): New function.
1203 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1204 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1205 Adjust indentation.
6a3d20cc
DA
1206 (INTERVAL_SIZE): Remove. Adjust users.
1207 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1208
4d2b044c
DA
12092012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1210
1211 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1212 * process.h (PGET): Remove.
1213 (struct Lisp_Process): Do not use INTERNAL_FIELD.
1214 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1215
d3d50620
DA
12162012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 Drop WGET and revert read access to Lisp_Objects slots of struct window.
1219 * window.h (WGET): Remove.
1220 (struct window): Do not use INTERNAL_FIELD.
1221 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1222 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1223 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1224 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1225 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1226 Adjust users.
1227
d10a51dc
CY
12282012-08-07 Chong Yidong <cyd@gnu.org>
1229
1230 * window.c (Fwindow_edges, Fwindow_pixel_edges)
1231 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
1232 (Fdelete_window_internal): Signal an error if the window is not on
1233 a live frame (Bug#12025).
1234
e69b0960
DA
12352012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1236
1237 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
1238 * frame.h (FGET): Remove.
1239 (struct frame): Do not use INTERNAL_FIELD.
1240 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1241 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1242 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1243 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1244
25a20a3a
JB
12452012-08-06 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * w32.c: Silence compiler warnings.
1248 (map_w32_filename): Remove unused variable `is_fat'.
1249 (chase_symlinks): Add parentheses around expression.
1250
1c6f11f4
GM
12512012-08-06 Glenn Morris <rgm@gnu.org>
1252
1db4583a
GM
1253 * sysdep.c: Respect BROKEN_GETWD.
1254
1c6f11f4
GM
1255 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
1256 Let configure handle it.
1257 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
1258
2b90362b
DA
12592012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1260
1261 Use GCALIGNMENT where appropriate.
1262 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
1263 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
1264 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
1265
5f50daf2
EZ
12662012-08-06 Eli Zaretskii <eliz@gnu.org>
1267
14ae4239
BT
1268 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
1269 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 1270
cbcc7007
SM
12712012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
1272
1273 * buffer.h (struct buffer): Revert `indirections' to a simple int;
1274 that should be sufficient for everyone.
1275
4d365fa4
JD
12762012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1277
1278 * keyboard.c (timer_check_2): Add break so timer_check returns next
1279 timeout.
1280
dd86bd82
DA
12812012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1282
1283 Fix Windows build errors introduced after converting to WGET and WSET.
1284 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
1285 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1286
054e1668
JD
12872012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1288
1289 * nsterm.m (ns_frame_rehighlight): Use FSET.
1290
1291 * nsmenu.m (ns_update_menubar): Use FSET.
1292
21238f11
DA
12932012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1294
1295 Separate read and write access to Lisp_Object slots of Lisp_Process.
1296 * process.h (PGET, PSET): New macros similar to AREF and ASET.
1297 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1298
077288cf
DA
12992012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 Separate read and write access to Lisp_Object slots of struct window.
1302 * window.h (WGET, WSET): New macros similar to AREF and ASET.
1303 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1304 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1305 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1306 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1307 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1308 Adjust users.
1309
71688bd7
DA
13102012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Fix Windows build errors introduced after converting to FGET and FSET.
1313 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
1314 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
1315 (w32_judge_scroll_bars): Change to use FSET.
1316 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1317
f99bac93
DA
13182012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1319
1320 Fix replacement typo.
1321 * window.c (replace_window): Set root_window instead of
1322 selected_window. This fixes a total window subsystem
1323 malfunction reported by Bastien Guerry <bzg@gnu.org>.
1324
8c2a0f2d
GM
13252012-08-06 Glenn Morris <rgm@gnu.org>
1326
1327 * lisp.mk (lisp): Add language/persian.elc.
1328
edd74c35
DA
13292012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1330
1331 Separate read and write access to Lisp_Object slots of struct frame.
1332 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
1333 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1334 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1335 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1336 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1337
8671676c
AS
13382012-08-05 Andreas Schwab <schwab@linux-m68k.org>
1339
1340 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
1341
663e2b3f
DA
13422012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1343
1344 Generalize common compile-time constants.
1345 * lisp.h (header_size, bool_header_size, word_size): Now here.
1346 (struct Lisp_Vector): Add comment.
1347 (struct Lisp_Bool_Vector): Move up to define handy constants.
1348 (VECSIZE, PSEUDOVECSIZE): Simplify.
1349 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
1350 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
1351 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
1352 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
1353 * xfont.c, xmenu.c: Use word_size where appropriate.
1354
d32e47af
LM
13552012-08-05 Lawrence Mitchell <wence@gmx.li>
1356
1357 * search.c (Freplace_match): Treat \? in the replacement text
1358 literally (Bug#8161).
1359
e5d9c0d1
CY
13602012-08-05 Chong Yidong <cyd@gnu.org>
1361
1362 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
1363 * frame.c (Vdelete_frame_functions):
1364 * emacs.c (Vkill_emacs_hook): Doc fix.
1365
8da0576b
EZ
13662012-08-04 Eli Zaretskii <eliz@gnu.org>
1367
1368 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
1369 --with-x-toolkit=no builds.
1370 Reported by Carsten Mattner <carstenmattner@gmail.com>.
1371
02676e5d
CY
13722012-08-04 Chong Yidong <cyd@gnu.org>
1373
1374 * syntax.c (Fmodify_syntax_entry): Doc fix.
1375
97147da9
EZ
13762012-08-04 Eli Zaretskii <eliz@gnu.org>
1377
76151e2c
EZ
1378 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
1379 * w32.c (init_environment): Change the default values of many
1380 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
1381 them into environment when they were not already defined.
1382 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 1383 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
1384 (check_windows_init_file): Now external, not static.
1385 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
1386 called when Vload_path is already set up.
1387
1388 * w32.h (check_windows_init_file): Add prototype.
1389
1390 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
1391 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
1392 compatibility with Posix platforms.
1393 (main): Move the call to check_windows_init_file to here from
1394 w32.c.
1395 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
1396 any, in the DEFALT argument into the root of the Emacs build or
1397 installation tree, as appropriate.
1398
1399 * callproc.c (init_callproc_1): Call decode_env_path instead of
1400 doing its equivalent by hand.
1401 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
1402 the code that sets Vexec_path run on MS-Windows.
1403
1404 * lread.c (init_lread): Add comments to #ifdef's.
1405
97147da9
EZ
1406 * msdos.c (dos_set_window_size, IT_update_begin)
1407 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
1408 instead of direct references.
1409
185ee146
PE
14102012-08-04 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 Export DEFAULT_REHASH_* to GDB.
1413 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
1414 Now constants, not macros.
1415
8834c57a
PE
14162012-08-03 Paul Eggert <eggert@cs.ucla.edu>
1417
98c6f1e3
PE
1418 Remove unnecessary casts involving pointers.
1419 These casts are no longer needed now that we assume C89 or later,
1420 since they involve casting to or from void *.
1421 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
1422 (make_pure_float, make_pure_vector):
1423 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
1424 * macros.c (Fstart_kbd_macro):
1425 * menu.c (find_and_return_menu_selection):
1426 * minibuf.c (read_minibuf_noninteractive):
1427 * sysdep.c (closedir):
1428 * xdisp.c (x_produce_glyphs):
1429 * xfaces.c (compare_fonts_by_sort_order):
1430 * xfns.c (x_real_positions, select_visual):
1431 * xselect.c (x_stop_queuing_selection_requests)
1432 (x_get_window_property, x_get_window_property_as_lisp_data):
1433 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
1434 Remove unnecessary pointer casts.
1435 * alloc.c (record_xmalloc): New function.
1436 * lisp.h (record_xmalloc): New decl.
1437 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
1438 more like a function. This is because the pointer cast is not
1439 needed. All uses changed.
1440 * print.c (print_string, print_error_message): Avoid length recalc.
1441
8834c57a
PE
1442 Improve fix for macroexp crash with debugging (Bug#12118).
1443 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
1444 ARRAY_MARK_FLAG when checking subscripts, because ASET is
1445 not supposed to be invoked from the garbage collector.
1446 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
1447 (gc_aset): New function, which is like ASET but can be
1448 used in the garbage collector.
1449 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1450 (set_hash_index): Use it instead of ASET.
1451
6dad7178
EZ
14522012-08-03 Eli Zaretskii <eliz@gnu.org>
1453
1454 Support symlinks on latest versions of MS-Windows.
1455 * w32.c: Include winioctl.h and aclapi.h.
1456 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
1457 (revert_to_self): Forward declarations of static functions.
1458 <static BOOL g_b_init_get_security_info>:
1459 <g_b_init_create_symbolic_link>: New static flags.
1460 (globals_of_w32): Initialize them to zero.
1461 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
1462 (map_w32_filename): Improve commentary. Simplify switch.
1463 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
1464 headers (most versions of MinGW w32api don't).
1465 (get_security_info, create_symbolic_link)
1466 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
1467 New functions.
1468 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
1469 in the argument file name.
1470 (sys_access): Call unc_volume_file_attributes only if
1471 GetFileAttributes fails with network-related error codes.
1472 (sys_rename): Diagnose renaming of a symlink when the user doesn't
1473 have the required privileges.
14ae4239 1474 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
1475 get_file_security_desc.
1476 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
1477 with addition of handling of symlinks and support for 'lstat'.
1478 If possible, get file's attributes and security information by
6dad7178
EZ
1479 handle, not by name. Produce S_IFLNK bit for symlinks, when
1480 called from 'lstat'.
1481 (stat, lstat): New functions, call 'stat_worker'.
1482 (symlink, readlink, careadlinkat): Rewritten to create and resolve
1483 symlinks when the underlying filesystem supports them.
1484
f162bcc3
PE
14852012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1486
79ea6c20
PE
1487 Fix macroexp crash on Windows with debugging (Bug#12118).
1488 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
1489 checking subscripts; problem introduced with the recent
1490 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
1491 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1492 since it's used in non-static inline functions now.
1493
c0ce93fd
PE
1494 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1495 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1496
f162bcc3
PE
1497 Use C99-style 'extern inline' if available.
1498 * buffer.h (BUFFER_INLINE):
1499 * category.h (CATEGORY_INLINE):
1500 * character.h (CHARACTER_INLINE):
1501 * charset.h (CHARSET_INLINE):
1502 * composite.h (COMPOSITE_INLINE):
1503 * dispextern.h (DISPEXTERN_INLINE):
1504 * lisp.h (LISP_INLINE):
1505 * systime.h (SYSTIME_INLINE):
1506 New macro, replacing 'static inline' in this header.
1507 * buffer.h, category.h, character.h, charset.h, composite.h:
1508 * dispextern.h, lisp.h, systime.h:
1509 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1510 * alloc.c (LISP_INLINE):
1511 * buffer.c (BUFFER_INLINE):
1512 * category.c (CATEGORY_INLINE):
1513 * character.c (CHARACTER_INLINE):
1514 * charset.c (CHARSET_INLINE):
1515 * composite.c (COMPOSITE_INLINE):
1516 * dispnew.c (DISPEXTERN_INLINE):
1517 * sysdep.c (SYSTIME_INLINE):
1518 Define to EXTERN_INLINE, so that the corresponding functions
1519 are compiled into code.
1520 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1521 (INLINE_HEADER_END): New macros.
1522 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1523 since it's used in non-static inline functions now.
a8333d03 1524 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1525
837b365b
GM
15262012-08-02 Glenn Morris <rgm@gnu.org>
1527
d66b744d
GM
1528 * s/: Remove empty directory.
1529
837b365b
GM
1530 * s/ms-w32.h: Move to ../nt/inc.
1531 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1532 Update for new ms-w32.h location.
1533
13294f95
PE
15342012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 Port to Solaris 8.
1537 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1538
90df0db3
GM
15392012-08-02 Glenn Morris <rgm@gnu.org>
1540
1541 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1542 hard-coding the path separator.
1543
4939150c
PE
15442012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1545
1546 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1547 This how ASET and AREF are supposed to work, and makes
1548 it easier to think about future improvements. See
1549 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1550 * charset.h (set_charset_attr): New function.
1551 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1552 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1553 (aref_addr): New function. All uses of &AREF(...) changed.
1554 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1555 (set_hash_index): New functions. All lvalue-style uses of
1556 HASH_KEY etc. changed.
1557 * keyboard.c (set_prop): New function. All lvalue-style uses
1558 of PROP changed.
1559
947b2afd
AA
15602012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1561
1562 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1563 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1564 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1565 * nsfns.m (ns_set_name_as_filename): Likewise.
1566 * nsmenu.m (ns_update_menubar): Likewise.
1567 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1568
4f5d0325
EZ
15692012-08-01 Eli Zaretskii <eliz@gnu.org>
1570
2008beae
EZ
1571 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1572 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1573 objects.
2008beae 1574
4f5d0325
EZ
1575 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1576
fe3cc771
GM
15772012-08-01 Glenn Morris <rgm@gnu.org>
1578
1579 * s/msdos.h: Remove file.
1580 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1581 * Makefile.in (S_FILE): Remove.
1582 (config_h): Remove S_FILE.
1583
c90acc54
JB
15842012-08-01 Juanma Barranquero <lekktu@gmail.com>
1585
1586 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1587 Remove; moved to nt/config.nt.
1588
d8a05828
DA
15892012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1590
1591 Use INTERNAL_FIELD for conses and overlays.
1592 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1593 Remove obsolete comment.
1594 (MVAR): New macro.
1595 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1596 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1597
8271d590
DA
15982012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1599
1600 Use INTERNAL_FIELD for symbols.
1601 * lisp.h (SVAR): New macro. Adjust users.
1602 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1603 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1604
3193acd2
DA
16052012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1606
1607 Use INTERNAL_FIELD for processes.
1608 * process.h (PVAR): New macro. Adjust style.
1609 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1610 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1611
3a45383a
DA
16122012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1613
1614 Use INTERNAL_FIELD for windows.
1615 * window.h (WVAR): New macro.
1616 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1617 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1618 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1619 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1620 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1621 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1622
c1dbc63c
PE
16232012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1626
5c0c0e8a
GM
16272012-08-01 Glenn Morris <rgm@gnu.org>
1628
1629 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1630 Move to configure.ac.
1631
552a99b4
JB
16322012-08-01 Juanma Barranquero <lekktu@gmail.com>
1633
1634 * makefile.w32-in (CONFIG_H): Update dependencies.
1635 (CONF_POST_H): New macro.
1636
1637 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1638
8d8e2dfe
GM
16392012-07-31 Glenn Morris <rgm@gnu.org>
1640
bc96620a
GM
1641 * Makefile.in (S_FILE): No longer set by configure.
1642
476b1b2d
GM
1643 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1644 is available.
1645 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1646
b2c7a106
GM
1647 * process.h (NULL_DEVICE):
1648 * emacs.c (SEPCHAR):
1649 * editfns.c (USER_FULL_NAME): Let configure set them.
1650
d53d062a
GM
1651 * s/README, s/template.h: Remove files.
1652
4515017f
GM
1653 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1654
8d8e2dfe
GM
1655 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1656 Move to configure.ac.
1657
5b20b3cc
EZ
16582012-07-31 Eli Zaretskii <eliz@gnu.org>
1659
1e0afd9a
EZ
1660 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1661 resulting renaming of 'struct frame' members.
1662
5b20b3cc
EZ
1663 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1664
1665 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1666 after introduction of FVAR.
1667
f1310128
JD
16682012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1669
79e721e0
JD
1670 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1671
1672 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1673 instead of compositeToPoint.
1674 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1675
8d7c7eed 1676 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1677
e34f7f79
DA
16782012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1679
1680 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1681 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1682 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1683 (BVAR): Change to use INTERNAL_FIELD.
1684 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1685 (KVAR): Change to use INTERNAL_FIELD.
1686 * frame.h (FVAR): New macro.
1687 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1688 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1689 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1690 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1691 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1692
c09bfb2f
DA
16932012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1694
1695 Miscellaneous fixes for non-default X toolkits.
1696 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1697 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1698 Move under #ifdef USE_LUCID.
1699 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1700 definition and usage to avoid warnings.
1701
14c114ae
JD
17022012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1703
1704 * nsterm.m (openFiles): Fix previous checkin.
1705
3bd21e82
PE
17062012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1707
1708 * indent.c (compute_motion): Remove unused local.
1709
c1529ded
GM
17102012-07-31 Glenn Morris <rgm@gnu.org>
1711
400d5621
GM
1712 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1713
268e2432
GM
1714 * conf_post.h [USG5_4]:
1715 Move remaining contents of s/usg5-4-common.h here.
1716 * s/usg5-4-common.h: Remove file.
1717
7552f3ee
GM
1718 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1719 * s/irix6-5.h: Remove file.
1720
6a381852
GM
1721 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1722 * s/darwin.h: Remove file.
1723
c1529ded
GM
1724 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1725 * s/hpux10-20.h: Remove file, which is now empty.
1726
b429a4ee
GM
17272012-07-30 Glenn Morris <rgm@gnu.org>
1728
1729 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1730 * Makefile.in (config_h): Add conf_post.h.
1731 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1732
adff3182
JD
17332012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1734
1735 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1736 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1737 (openFile, openTempFile, openFileWithoutUI, openFiles):
1738 Open files only if ns_do_open_file.
adff3182 1739
c32af1e4
PE
17402012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1741
7393bcbb
PE
1742 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1743 This no-op macro hasn't been needed for many years.
1744 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1745
c32af1e4
PE
1746 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1747 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1748 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1749 gdb_make_enums_visible.
1750 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1751 (DIRECTORY_SEP): Now a constant, not a macro.
1752
302fc036
EZ
17532012-07-30 Eli Zaretskii <eliz@gnu.org>
1754
1755 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1756 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1757
1758 * w32term.c <w32_keyboard_codepage>: Renamed from
1759 keyboard_codepage and now external. All users changed.
1760
1761 * w32term.h: Add declaration of w32_keyboard_codepage.
1762
1763 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1764 the codepage to translate keys to Unicode. If this argument is
1765 -1, use the value returned by GetConsoleCP. All callers changed.
1766
88fb40b4
PE
17672012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1768
0aee6912
PE
1769 Update .PHONY listings in makefiles.
1770 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1771 bootstrap-clean, distclean, maintainer-clean, versioclean,
1772 extraclean, frc.
1773
88fb40b4
PE
1774 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1775 This is a bit clearer. Fix some commentary typos.
1776
0a763bd1
GM
17772012-07-30 Glenn Morris <rgm@gnu.org>
1778
32bac6d6
GM
1779 * s/netbsd.h: Let configure include signal.h if needed.
1780 Remove file, which is now empty.
1781
b65e7c46
GM
1782 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1783 Let configure set them.
1784 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1785 No more need to undefine.
0a763bd1 1786
169304bd
AS
17872012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1788
1789 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1790 non-single-byte char when adding meta modifier. (Bug#12090)
1791
6cd7a139
DA
17922012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 Convert safe_call to use variable number of arguments.
1795 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1796 (safe_call2): Fix comment.
1797 * lisp.h (safe_call): Adjust prototype.
1798 * coding.c (encode_coding_object): Change to use safe_call2.
1799 * xfaces.c (merge_face_heights): Change to use safe_call1.
1800
d34d6ffc
GM
18012012-07-30 Glenn Morris <rgm@gnu.org>
1802
7b8a48e4 1803 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1804 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1805
d34d6ffc
GM
1806 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1807 Remove empty files.
1808
03a660a6
PE
18092012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Export to GDB most of lisp.h's remaining object-like macros.
1812 * lisp.h (min, max): Move earlier, because they're used earlier now.
1813 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1814 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1815 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1816 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1817 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1818 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1819 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1820 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1821 Now constants, for GDB. They need not be macros.
1822 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1823 Now constants, for GDB, as well as macros, for static initializers.
1824 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1825 Move to after the definition of struct Lisp_Char_Table,
1826 since the former now needs that type defined.
1827 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1828 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1829 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1830 New enums, for gdb_make_enums_visible.
1831 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1832 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1833 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1834 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1835 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1836 enum maxargs, enum MAX_ALLOCA.
1837 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1838 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1839 no longer needed, now that they are done in lisp.h.
1840
e499d0ee
DA
18412012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1842
1843 Cleanup string bytes checking.
1844 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1845 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1846 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1847 (check_sblock, compact_small_strings): Simplify.
1848
d5040d2d
PE
18492012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1852 These macros are confusing and no longer need to be defined, as
1853 the enum values now suffice. All uses replaced with definiens.
1854 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1855
7f259ae6
JB
18562012-07-29 Juanma Barranquero <lekktu@gmail.com>
1857
1858 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1859 ($(BLD)/w32console.$(O)): Update dependencies.
1860
7e63e0c3
DA
18612012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1862
1863 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1864 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1865 time. Adjust users.
1866 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1867
ffd817eb
JD
18682012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1869
1870 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1871 setting sitelisp (Bug#12010).
1872
417a7a0e
EZ
18732012-07-29 Eli Zaretskii <eliz@gnu.org>
1874
14ae4239 1875 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1876
1877 * w32heap.c (cache_system_info):
1878 * w32.c (sys_rename):
1879 * w32proc.c (find_child_console, sys_kill): All users changed.
1880
387d4d92
PE
18812012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1884
55a6cca6
EZ
18852012-07-29 Eli Zaretskii <eliz@gnu.org>
1886
1887 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1888
dbcf001c
DA
18892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1890
1891 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1892 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1893 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1894
e2688e4a
DA
18952012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1896
1897 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1898 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1899 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1900 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1901 (replace_range, replace_range_2, del_range_2): Change to eassert.
1902 * marker.c (byte_char_debug_check): Adjust style.
1903
b46a6a83
PE
19042012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1907 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1908 long-ago-commented-out code that talks about "WIN32".
1909 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1910 All uses changed.
1911
e32a5799
PE
19122012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1915 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1916 Simplify by using alignof.
1917 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1918 * lisp.h: Include <stdalign.h>.
1919 (GCALIGNMENT): New macro and constant.
1920 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1921 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1922 (stdalign): New macro, if not already defined.
1923
df81cd29
EZ
19242012-07-28 Eli Zaretskii <eliz@gnu.org>
1925
01bd1b0d
EZ
1926 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1927 * w32inevt.c: Include w32inevt.h.
1928 (w32_read_console_input): New inline function, calls either
1929 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1930 w32_console_unicode_input.
1931 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1932 (w32_kbd_patch_key, key_event): Use the codepage returned by
1933 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1934 (key_event): use uChar.UnicodeChar only if
1935 w32_console_unicode_input is non-zero.
1936
1937 * w32console.c: Include w32heap.h.
1938 <w32_console_unicode_input>: New global variable.
1939 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1940 family of Windows, zero otherwise.
1941
1942 * w32inevt.h: Declare w32_console_unicode_input.
1943
df81cd29
EZ
1944 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1945 --without-x. (Bug#11742)
1946
c20fdd9e
PE
19472012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Adjust GDB to reflect pvec_type changes (Bug#12036).
1950 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1951 2012-07-04 changes to pseudovector representation.
1952 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1953
32770973 19542012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1955
1956 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1957 bus address.
1958 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1959
3438fe21
EZ
19602012-07-27 Eli Zaretskii <eliz@gnu.org>
1961
bcfbc9de
EZ
1962 * alloc.c (listn): Fix the order the arguments are consed onto the
1963 list.
1964
3438fe21
EZ
1965 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1966 enumeration constants, as PURE and HEAP are too general, and clash
1967 with other headers and sources, such as gmalloc.c and the
1968 MS-Windows system headers. All users changed.
1969
eeaea515
DA
19702012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1971
1972 Revert last save_excursion_save and save_excursion_restore changes.
1973 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1974 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1975
073c88c2
DA
19762012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1977
1978 Fix recently-introduced typos in Windows port.
1979 Reported by Martin Rudalics <rudalics@gmx.at>.
1980 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1981 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1982
4706125e
PE
19832012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 Improve GDB symbol export (Bug#12036).
1986 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1987 arms of an 'if', not using conditional expressions; otherwise GDB
1988 complains about the types in the unevaluated arm when the argument
1989 is an integer literal.
1990 (xgetint): Simplify expression.
1991 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1992 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1993 Zaretskii in <http://bugs.gnu.org/12036#13>.
1994 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1995 needed now that we have gdb_make_enums_visible.
1996 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1997 (enum enum_USE_LSB_TAG):
1998 New enum types, packaging up enums that need to be exported to GDB.
1999
694b6c97
DA
20002012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2001
2002 Utility function to make a list from specified amount of objects.
2003 * lisp.h (enum constype): New datatype.
2004 (listn): New prototype.
2005 * alloc.c (listn): New function.
2006 (Fmemory_use_count, syms_of_alloc): Use it.
2007 * buffer.c (syms_of_buffer): Likewise.
2008 * callint.c (syms_of_callint): Likewise.
2009 * charset.c (define_charset_internal): Likewise.
2010 * coding.c (syms_of_coding): Likewise.
2011 * keymap.c (syms_of_keymap): Likewise.
2012 * search.c (syms_of_search): Likewise.
2013 * syntax.c (syms_of_syntax): Likewise.
2014 * w32.c (init_environment): Likewise.
2015 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2016 * xdisp.c (syms_of_xdisp): Likewise.
2017 * xfns.c (syms_of_xfns): Likewise.
2018
6195f384
DA
20192012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2020
2021 Fast save_excursion_save and save_excursion_restore.
2022 * lisp.h (struct Lisp_Excursion): New data type.
2023 (PVEC_EXCURSION): New pseudovector type.
2024 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2025 to deal with it. Adjust comments.
2026 (init_marker, attach_marker): New prototype.
2027 (unchain_marker): Adjust prototype.
2028 * marker.c (attach_marker): Change to global.
2029 (init_marker): New function.
2030 * alloc.c (Fmake_marker, build_marker): Use it.
2031 (build_marker): More easserts.
2032 (mark_object): Handle struct Lisp_Excursion.
2033 * editfns.c (save_excursion_save, save_excursion_restore):
2034 Reimplement to use struct Lisp_Excursion. Add comments.
2035
5eceb8fb
PE
20362012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 Fix export of symbols to GDB (Bug#12036).
2039 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2040 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2041 emacs.c, as this is a more-suitable home. Had this been done earlier
2042 the fix for 12036 would have avoided some of the problems noted in
2043 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2044 would have been more obvious.
562157c8
PE
2045 * emacs.c: Do not include <verify.h>; no longer needed.
2046 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2047 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2048 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2049 Remove; now done in lisp.h.
2050 * lisp.h (PUBLISH_TO_GDB): New macro.
2051 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2052 (DATA_SEG_BITS): Use it.
2053 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2054 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2055 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2056 not be usable in #if. This simplifies things.
2057
d6749401
JB
20582012-07-26 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2061
1781b9e9
PE
20622012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2063
d89518db 2064 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2065 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2066 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2067 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2068 Adjust to changes in lisp.h and emacs.c, by using
2069 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2070 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2071 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2072 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2073 instead of gdb_valbits.
2074 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2075 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2076 instead of gdb_array_mark_flag.
2077 (xboolvector): Get size from $->size, not $->header.size.
2078 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2079 (xreload, hook-run, hookpost-run): Remove.
2080 * emacs.c: Include <verify.h>.
2081 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2082 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2083 Remove.
2084 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2085 (gdb_USE_LSB_TAG): New enum constants.
2086 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2087 Also define these as enum constants, so they're visible to GDB.
2088 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2089 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2090 as constants, so they're visible to GDB.
2091 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2092 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2093 Now enum constants, not macros, so they're visible to GDB.
2094 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2095 more convenient now. All uses changed.
2096 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2097 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2098
3628596a
DA
20992012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2100
2101 Explicitly free restriction data that are not needed anymore.
2102 * editfns.c (save_restriction_restore): Free restriction data.
2103
7abaf5cc
SM
21042012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2105
2106 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2107 add argument, tune behavior, and adjust all callers.
2108
71f88e00
PE
21092012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 Use typedef for EMACS_INT, EMACS_UINT.
2112 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2113 than macros. This simplifies debugging in the usual case, since
2114 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2115 and it allows expressions involving EMACS_INT casts.
2116 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2117
57ec3034
JD
21182012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2119
2120 * nsterm.m (ns_read_socket): Return early if there is a modal
2121 window (Bug#12043).
2122
8137e7b3
MR
21232012-07-25 Martin Rudalics <rudalics@gmx.at>
2124
2125 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2126 that FOCUS-FRAME can be omitted.
2127
04e9897c
DA
21282012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2129
2130 Adjust buffer text indirection counters at the end of Fkill_buffer.
2131 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2132 buffer is definitely dead. This should really fix an issue reported
2133 by Christoph Scholtes again. (Bug#12007).
2134 (init_buffer_once): Initialize indirection counters of
2135 buffer_defaults and buffer_local_symbols (for sanity and safety).
2136
8a0484e1
EZ
21372012-07-24 Eli Zaretskii <eliz@gnu.org>
2138
2139 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2140 and continuation glyphs on tooltip frames, leave them at zero.
2141 Avoids continued lines in tooltips. (Bug#11832)
2142
fa691a83
DA
21432012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2144
2145 Simplify copy_overlay.
04e9897c 2146 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2147 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2148
436bc8e0
EZ
21492012-07-23 Eli Zaretskii <eliz@gnu.org>
2150
2151 * print.c (print_object): Don't crash when a frame's name is nil
2152 or invalid. (Bug#12025)
2153
2154 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2155 it signals an error when a tooltip frame is being created.
2156
d7a7fda3
DA
21572012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2158
2159 Cleanup miscellaneous objects allocation and initialization.
2160 * alloc.c (allocate_misc): Change to static. Add argument to
2161 specify the subtype. Adjust comment and users.
2162 (build_overlay): New function.
2163 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2164 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2165 (allocate_misc): Remove prototype.
2166 (build_overlay): Add prototype.
2167
21682012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2169
2170 Swap buffer text indirection counters in Fbuffer_swap_text.
2171 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2172 This avoids crash reported by Christoph Scholtes at
2173 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2174
9d7fa573
JD
21752012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2176
2177 * nsmenu.m (Popdown_data): New struct.
2178 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2179 free Popdown_data.
2180 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2181 (initWithContentRect): Make imgView and contentView non-static
2182 and autorelease them. Also autorelease img and matrix (Bug#12005).
2183 (dealloc): Remove (Bug#12005).
2184
0dd6d66d
DA
21852012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2186
2187 Adjust consing_since_gc when objects are explicitly freed.
2188 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2189 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2190 (free_cons, free_misc): Subtract object size from consing_since_gc.
2191
d36d71df
DA
21922012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2193
2194 Simplify and cleanup markers positioning code.
2195 * marker.c (attach_marker): More useful eassert.
2196 (live_buffer, set_marker_internal): New function.
2197 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2198 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2199
fb9ea40f
PE
22002012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2201
2202 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2203 as it's limited by the amount of memory, not by INT_MAX.
2204
2d5c5f7d
EZ
22052012-07-21 Eli Zaretskii <eliz@gnu.org>
2206
07fb592e
EZ
2207 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2208 in special-event-map. See the discussion at
2209 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2210 for the reasons.
2211
37a9eac8 2212 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
2213 info.dwItemData. Fixes crashes on 64-bit Windows.
2214 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 2215
c4328746
JD
22162012-07-21 Jan Djärv <jan.h.d@swipnet.se>
2217
2218 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 2219 (conversationIdentifier): Return value is NSInteger.
784051c4 2220 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 2221
6e5d1c12
CY
22222012-07-21 Chong Yidong <cyd@gnu.org>
2223
2224 * window.c (decode_any_window): Signal an error if the window is
2225 on a dead frame (Bug#11984).
2226
9928463d
DA
22272012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2228
2229 Add indirection counting to speed up Fkill_buffer.
2230 * buffer.h (struct buffer): New member.
2231 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
2232 (Fmake_indirect_buffer): Set indirection counter to -1, increment
2233 base buffer indirection counter.
2234 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
2235 (Fkill_buffer): Adjust indirection counters as needed, don't walk
2236 through buffer list if indirection counter is 0.
2237
f8643a6b
DA
22382012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2239
2240 Extend the value returned by Fgarbage_collect with heap statistics.
2241 * alloc.c (Qheap): New symbol.
2242 (syms_of_alloc): DEFSYM it.
2243 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
2244 (Fmemory_free): Remove.
2245 (syms_of_alloc): Don't defsubr it.
2246 * buffer.c (Fcompact_buffer): Remove.
2247 (syms_of_buffer): Don't defsubr it.
2248
dac616ff
DA
22492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2250
2251 Make maybe_gc inline.
2252 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
2253 * lisp.h (consing_since_gc, gc_relative_threshold)
2254 (memory_full_cons_threshold): Revert declaration.
2255 (maybe_gc): Remove prototype, define as inline.
2256 * alloc.c: Remove old commented-out code.
2257 (consing_since_gc, gc_relative_threshold)
2258 (memory_full_cons_threshold): Revert to global.
2259 (maybe_gc): Remove.
2260
d7ea76b4
DA
22612012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2262
2263 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
2264 * lisp.h (build_unibyte_string): New function.
2265 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
2266 * sysdep.c, w32fns.c, xfns.c: Use it.
2267 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
2268 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
2269 Adjust users accordingly.
2270 * font.h (font_open_by_name): Adjust prototype.
2271
765e61e3
DA
22722012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2273
2274 Cleanup calls to Fgarbage_collect.
2275 * lisp.h (maybe_gc): New prototype.
2276 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2277 Remove declarations.
2278 * alloc.c (maybe_gc): New function.
2279 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2280 Make them static.
2281 * bytecode.c (MAYBE_GC): Use maybe_gc.
2282 * eval.c (eval_sub, Ffuncall): Likewise.
2283 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
2284 to avoid dependency from auto-save feature.
2285
52b852c7
PE
22862012-07-19 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
2289 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
2290 'for_each_per_buffer_object_at'.
2291 All uses changed. It's better to use upper-case for macros that
2292 cannot be implemented as functions, to give the reader a clue
2293 that they're special.
2294
5db81e33
SM
22952012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
2296
2297 * alloc.c (Fgarbage_collect): Tweak docstring.
2298
5b835e1d
DA
22992012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2300
2301 Tweak the value returned from Fgarbage_collect again.
2302 * alloc.c (Fgarbage_collect): New return value, as confirmed in
2303 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
2304 Adjust documentation.
2305 (total_vector_bytes): Rename to total_vector_slots, adjust
2306 accounting.
2307 (total_free_vector_bytes): Rename to total_free_vector_slots,
2308 adjust accounting.
2309 (Qstring_bytes, Qvector_slots): New symbols.
2310 (syms_of_alloc): DEFSYM them.
2311
9cd47b72
DA
23122012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2313
2314 Buffer compaction primitive which may be used from Lisp.
2315 * buffer.c (compact_buffer, Fcompact_buffer): New function.
2316 (syms_of_buffer): Register Fcompact_buffer.
2317 * alloc.c (Fgarbage_collect): Use compact_buffer.
2318 * buffer.h (compact_buffer): New prototype.
2319 (struct buffer_text): New member.
2320
d17337e5
DA
23212012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2322
2323 New macro to iterate over all buffers, miscellaneous cleanups.
2324 * lisp.h (all_buffers): Remove declaration.
2325 * buffer.h (all_buffers): Add declaration, with comment.
2326 (for_each_buffer): New macro.
2327 * alloc.c (Fgarbage_collect, mark_object): Use it.
2328 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
2329 (init_buffer): Likewise.
2330 * data.c (Fset_default): Likewise.
2331 * coding.c (code_conversion_restore): Remove redundant check
2332 for dead buffer.
2333 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
2334
60cfd278
AS
23352012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2336
2337 Fix bug that created negative-length intervals.
2338 * intervals.c (merge_interval_right, merge_interval_left):
2339 Do not zero out this interval if it is absorbed by its children,
2340 as this interval's total length doesn't change in that case. See
2341 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
2342
d06714cb
PE
23432012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2344
83713154
PE
2345 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
2346 when invoking (make-bool-vector N t) and N is a positive
2347 multiple of 8 -- the last 8 bits were mistakenly cleared.
2348
d06714cb
PE
2349 Remove some struct layout assumptions in bool vectors.
2350 * alloc.c (bool_header_size): New constant.
2351 (header_size, word_size): Move earlier, as they're now used earlier.
2352 Use 'word_size' in a few more places, where it's appropriate.
2353 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
2354 padding before the data member of a bool vector.
2355 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
2356 than doing the check by hand with an abort ().
2357
464d5a5e
SM
23582012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2359
5fbc0409
SM
2360 * eval.c (Fdefvar): Don't check constants since we only set the var if
2361 it's not yet defined anyway (bug#11904).
2362
464d5a5e
SM
2363 * lisp.h (last_undo_boundary): Declare new var.
2364 * keyboard.c (command_loop_1): Set it.
2365 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
2366 were auto-added by the command loop (bug#11774).
2367
8dc2e44a
AS
23682012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2369
2370 * w32font.c (Qsymbol): Remove local definition.
2371 (syms_of_w32font): Don't DEFSYM it.
2372
169925ec
DA
23732012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 Fix sweep_vectors to handle large bool vectors correctly.
2376 * alloc.c (sweep_vectors): Account total_vector_bytes for
2377 bool vectors larger than VBLOCK_BYTES_MAX.
2378
5fbfb018
CY
23792012-07-18 Chong Yidong <cyd@gnu.org>
2380
2381 * frame.c (x_set_frame_parameters): Revert bogus change introduced
2382 in 2012-05-25 commit by Paul Eggert (Bug#11738).
2383
3ab6e069
DA
23842012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2385
2386 Return more descriptive data from Fgarbage_collect.
2387 Suggested by Stefan Monnier in
2388 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
2389 * alloc.c (bounded_number): New function.
2390 (total_buffers, total_vectors): New variable.
2391 (total_string_size): Rename to total_string_bytes, adjust users.
2392 (total_vector_size): Rename to total_vector_bytes, adjust users.
2393 (sweep_vectors): Account total_vectors and total_vector_bytes.
2394 (Fgarbage_collect): New return value. Adjust documentation.
2395 (gc_sweep): Account total_buffers.
2396 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
2397 (VECTOR_SIZE): Remove.
2398 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
2399 (Qinterval, Qmisc): New symbols.
2400 (syms_of_data): Initialize them.
2401 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
2402 (Qcons, Qbuffer): New declarations.
2403
6d02fe5b
PE
24042012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 * alloc.c (Fmemory_free): Account for memory-free's own storage.
2407 Round up, not down. Improve doc.
2408
b7ffe040
DA
24092012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2410
2411 Restore old code in allocate_string_data to avoid Faset breakage.
2412 Reported by Julien Danjou <julien@danjou.info> in
2413 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
2414 * alloc.c (allocate_string_data): Restore old code with minor
2415 adjustments, fix comment to explain this subtle issue.
2416
4dc7c8d5
SM
24172012-07-17 Eli Zaretskii <eliz@gnu.org>
2418
2419 Remove FILE_SYSTEM_CASE.
2420 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
2421
2422 * fileio.c (FILE_SYSTEM_CASE): Don't define.
2423 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
2424 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
2425 call-process-region passes it through expand-file-name.
2426
2427 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
2428
24292012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2430
2431 Fix crash when creating indirect buffer (Bug#11917)
2432 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
2433 Don't handle unbound variables specially if non-zero.
2434 (Fbuffer_local_variables): Pass zero.
2435 (clone_per_buffer_values): Pass non-zero.
2436
24372012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2438
2439 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
2440 to make the loop interruptible.
2441
24422012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2443
2444 * gnutls.c (emacs_gnutls_handshake): Only retry if
2445 GNUTLS_E_INTERRUPTED.
2446
cce7fefc
DA
24472012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2448
2449 Cleanup and convert miscellaneous checks to eassert.
2450 * alloc.c (mark_interval): Fix comment, partially rephrase
2451 old comment from intervals.h (see below).
2452 * intervals.c (find_interval, adjust_intervals_for_insertion)
2453 (delete_interval, adjust_intervals_for_deletion)
2454 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
2455 Convert to eassert.
2456 (adjust_intervals_for_insertion, make_new_interval):
2457 Remove obsolete and unused code.
2458 * intervals.h (struct interval): Remove obsolete comment.
2459 * textprotp.c (erase_properties): Remove unused code.
2460 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
2461 (Fremove_list_of_text_properties): Convert to eassert.
2462
9ea10cc3
CY
24632012-07-17 Chong Yidong <cyd@gnu.org>
2464
2465 * editfns.c (Finsert_char): Doc fix.
2466
3900d5de
DA
24672012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2468
2469 Fix previous change to make Fmemory_free always accurate.
2470 * alloc.c (make_interval): Update total_free_intervals.
2471 (make_float): Likewise for total_free_floats.
2472 (free_cons, Fcons): Likewise for total_free_conses.
2473 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
2474 Likewise for total_free_vector_bytes.
2475 (Fmake_symbol): Likewise for total_free_symbols.
2476 (bytes_free): Remove.
2477
7098646f
DA
24782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2479
2480 Simple free memory accounting feature.
2481 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
2482 (sweep_vectors): Accumulate size of free vectors.
2483 (Fgarbage_collect): Setup bytes_free.
2484 (Fmemory_free): New function.
2485 (syms_of_alloc): Register it.
2486
22657b40
DA
24872012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2488
2489 Cleanup overlays checking.
2490 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
2491 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2492 eassert and OVERLAYP.
2493 (sort_overlays): Change to use OVERLAYP.
2494
ddfc8813
RK
24952012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2496
2497 * editfns.c (Finsert_char): Make it interactive, and make the
2498 second arg optional. Copy interactive spec and docstring from
2499 ucs-insert.
2500
7c26cf3c
PE
25012012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2504 Unlike the other wrapped functions, fabs has an unspecified
2505 effect on errno.
2506
5d127af9
JD
25072012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2508
2509 * nsterm.m (keyDown): Interpret flags without left/right bits
2510 as the left key (Bug#11670).
2511
6a0dd1d7
DA
25122012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2513
2514 Remove empty and useless init functions.
2515 * lisp.h (init_character_once, init_fns, init_image)
2516 (init_filelock, init_sound): Remove prototype.
2517 * character.c (init_character_once): Remove.
2518 * filelock.c (init_filelock): Likewise.
2519 * fns.c (init_fns): Likewise.
2520 * image.c (init_image): Likewise.
2521 * sound.c (init_sound): Likewise.
2522 * emacs.c (main): Adjust accordingly.
2523
7a6136fd
DA
25242012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2525
2526 * gtkutil.h: Tiny cleanups.
2527 (use_old_gtk_file_dialog): Remove useless declaration.
2528 (xg_uses_old_file_dialog): Add suggested const attribute.
2529
ce811ad9
EZ
25302012-07-15 Eli Zaretskii <eliz@gnu.org>
2531
2532 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2533 (bidi_paragraph_init): Use it to limit search forward for a strong
2534 directional character in abnormally large paragraphs full of
2535 neutral or weak characters. (Bug#11943)
2536
c9adfeaa
SF
25372012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2538
2539 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2540 the toolbar (Bug#9451).
2541 (xg_make_tool_item): Give the widget event box a transparent
2542 background.
2543
fff62aa9
DA
25442012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2545
2546 Cleanup basic allocation variables and functions.
2547 * alloc.c (ignore_warnings, init_intervals, init_float)
2548 (init_cons, init_symbol, init_marker): Remove.
2549 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2550 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2551 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2552 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2553 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2554 (staticidx, init_alloc_once, init_strings, free_ablock):
2555 Remove redundant initialization.
2556 * fns.c (init_weak_hash_tables): Remove.
2557 * lisp.h (init_weak_hash_tables): Remove prototype.
2558
9730daca
DA
25592012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2560
2561 Use zero_vector where appropriate.
2562 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2563 accordingly.
2564 * lisp.h (zero_vector): New declaration.
2565 * font.c (null_vector): Remove.
2566 (syms_of_font): Remove initialization and staticpro.
2567 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2568 * keymap.c (Faccessible_keymaps): Likewise.
2569
2e2d2a13
LL
25702012-07-15 Leo Liu <sdl.web@gmail.com>
2571
2572 * fringe.c: Fix typo in comments.
2573
cd276f6e
LL
25742012-07-14 Leo Liu <sdl.web@gmail.com>
2575
2576 * fringe.c: Add a new bitmap exclamation-mark.
2577
5a1131d9
EZ
25782012-07-14 Eli Zaretskii <eliz@gnu.org>
2579
2580 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2581
2582 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2583 (HAVE_MENUS): Don't define, defined by editing config.in with
2584 msdos/sed2v2.inp.
2585 (GMALLOC_INHIBIT_VALLOC): Don't define.
2586 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2587
22e983b7
JB
25882012-07-14 Juanma Barranquero <lekktu@gmail.com>
2589
2590 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2591
5b3f250f
GM
25922012-07-14 Glenn Morris <rgm@gnu.org>
2593
2594 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2595 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2596 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2597
33d63ff4
GM
25982012-07-13 Glenn Morris <rgm@gnu.org>
2599
5b633342
GM
2600 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2601
33d63ff4
GM
2602 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2603 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2604
b55b9f85
JD
26052012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2606
0dc8cf50
JD
2607 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2608 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2609 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2610 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2611 where appropriate.
2612 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2613 as boolean expression.
2614 (x_set_window_size): Remove unused variable toolbar.
2615 (ns_get_color_default, ns_mod_to_lisp): Remove.
2616 (ns_mouse_position): Remove unused variables xchar and ychar.
2617 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2618 (ns_set_vertical_scroll_bar): Remove unused variable count.
2619 (ns_delete_terminal): Remove unused variable i.
2620 (ns_term_init): Remove unused variables r, g and b.
2621 (mouseDown): Remove unused variable window.
2622 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2623 (initFrameFromEmacs): Remove unused variable vbextra.
2624 (mouseEntered): Remove unused variables p and dpyinfo.
2625 (mouseExited): Remove unused variables p and r.
2626 (ns_define_frame_cursor, ns_clear_frame_area)
2627 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2628 (menuDown): Assign [sender tag] to variable and cast the variable.
2629
2630 * nsterm.h (menuDown): Add id as type to argument sender.
2631 (ns_display_info_for_name): Add Lisp_Object argument.
2632 (ns_term_init): Add Lisp_Object argument.
2633 (ns_map_event_to_object): Add void argument.
2634 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2635 prototype with arguments and only declare if __OBJC__.
2636 (nxatoms_of_nsselect): Add void argument.
2637 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2638 (ns_alloc_autorelease_pool): Add void argument.
2639 (ns_release_autorelease_pool): Add void* argument.
2640 (ns_get_defaults_value): Add const char* argument.
2641
2642 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2643 (initFromContents): Use SSDATA where appropriate.
2644 (ns_update_menubar): Add braces to ambigous if-else.
2645 (initWithTitle): Put () around assignment in if statement.
2646 (ns_menu_show): Remove unused variables window and keymap.
2647 (update_frame_tool_bar): Remove unused variable selected_p.
2648 (initWithContentRect): Remove unused variable this_cmd_name.
2649
2650 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2651 appropriate.
2652 (setXBMColor): Remove unused variable len.
2653 (setPixmapData): Put () around assignment in loop statement.
2654
2655 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2656 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2657 where appropriate.
2658 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2659 around assignment in loop statement.
2660 (nsfont_open): Remove unused variable i.
2661 (nsfont_open): Remove unused variable len.
2662 (nsfont_draw): Remove unused variable cs.
2663
2664 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2665 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2666 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2667 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2668 (Fns_font_name, Fns_perform_service)
2669 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2670 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2671 (ns_set_name): Remove unused variable view.
2672 (x_set_menu_bar_lines): Remove unused variable olines.
2673 (x_set_tool_bar_lines): Remove unused variable root_window.
2674 (Fns_list_colors): Put () around assignment in while statement.
2675 (Fns_perform_service): Remove unused variable len.
2676 (Fns_display_usable_bounds): Remove unused variable top.
2677 (syms_of_nsfns): Remove unused variable i.
2678
b55b9f85
JD
2679 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2680 memcpy (Bug#11907).
2681
ed9265fc 26822012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2683
2684 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2685 and free it with DestroyExceptionInfo (Bug#11558).
2686
ef099b57
JB
26872012-07-13 Juanma Barranquero <lekktu@gmail.com>
2688
2689 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2690 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2691 Set here, not in nt/config.nt.
2692
ea814a5d
EZ
26932012-07-13 Eli Zaretskii <eliz@gnu.org>
2694
2695 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2696 cursor overflow into the last glyph on display line when the right
2697 fringe is off. (Bug#11832)
2698
1a952767
PE
26992012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 * xdisp.c (produce_special_glyphs): Now static.
2702 * dispextern.h (produce_special_glyphs): Remove decl.
2703
983188fd
GM
27042012-07-13 Glenn Morris <rgm@gnu.org>
2705
8d7c7eed 2706 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2707 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2708
983188fd
GM
2709 * s/usg5-4-common.h (USG, USG5):
2710 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2711 * s/sol2-6.h (SOLARIS2):
2712 * s/irix6-5.h (IRIX6_5):
2713 * s/hpux10-20.h (USG, USG5, HPUX):
2714 * s/gnu-linux.h (USG, GNU_LINUX):
2715 * s/freebsd.h (BSD_SYSTEM):
2716 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2717 * s/cygwin.h (CYGWIN):
2718 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2719 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2720
d1e68667 27212012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2722
2723 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2724
6de0e799
GM
27252012-07-13 Glenn Morris <rgm@gnu.org>
2726
739ae010
GM
2727 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2728
dbee5793
GM
2729 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2730
6de0e799
GM
2731 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2732 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2733
b82da769
GM
27342012-07-12 Glenn Morris <rgm@gnu.org>
2735
4fae5a7a 2736 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2737
2738 * process.c (init_process_emacs): Rename from init_process.
2739 The old name is also the name of a Mach system call.
2740 * lisp.h, emacs.c: Update for this name change.
2741 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2742 longer needed.
2743
5a979817
EZ
27442012-07-12 Eli Zaretskii <eliz@gnu.org>
2745
2746 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2747 memmove call that removes glyphs covered by the left truncation
2748 glyph. Improve commentary.
2749 (display_line): Fix display of continuation glyphs on GUI frames
2750 when the right fringe is turned off and variable-size fonts are
2751 used in the window. Move the code that appends a stretch glyph to
2752 produce_special_glyphs, so that it could be used for truncation
2753 and continuation glyphs alike.
2754 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2755 glyph of a suitably computed width, to align the special glyphs at
2756 the window margin. Code moved from display_line. (Bug#11832)
2757
3e91a053
GM
27582012-07-12 Glenn Morris <rgm@gnu.org>
2759
ba9e4b84
GM
2760 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2761
2762 * s/gnu-linux.h, s/hpux10-20.h:
2763 Do not unconditionally define HAVE_XRMSETDATABASE.
2764
3e91a053
GM
2765 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2766
b300b1f4
PE
27672012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2768
2769 Fix typos that broke OS X build.
2770 Reported by Randal L. Schwartz in
2771 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2772 * nsterm.m (ns_timeout): Add missing local decl.
2773 (ns_get_color): snprintf -> sprintf, to fix typo.
2774
6e777848
GM
27752012-07-12 Glenn Morris <rgm@gnu.org>
2776
3f922c37
GM
2777 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2778 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2779 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2780 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2781
0ab7b23a
GM
2782 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2783 Move PTY_OPEN to configure.
2784
6e777848
GM
2785 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2786 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2787 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2788
4a7edc24
DA
27892012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2790
2791 Use empty_unibyte_string where applicable.
2792 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2793 * lread.c (read1): Likewise.
2794 * xsettings.c (syms_of_xsettings): Likewise.
2795
308aab79
GM
27962012-07-12 Glenn Morris <rgm@gnu.org>
2797
42bd1719
GM
2798 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2799 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2800 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2801 * s/hpux10-20.h (RUN_TIME_REMAP):
2802 * s/bsd-common.h (TABDLY): Move to configure.
2803
2804 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2805
2806 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2807
ea0bbd17 2808 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2809 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2810
2811 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2812
308aab79
GM
2813 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2814 * s/template.h: Move NARROWPROTO to configure.
2815
ee1cf5cf
GM
28162012-07-11 Glenn Morris <rgm@gnu.org>
2817
30fe9bf4
GM
2818 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2819 unused since 2011-01-17 change to systty.h.
2820
ee1cf5cf
GM
2821 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2822 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2823 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2824
63e47e07
PE
28252012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2828
c43fb4c3
GM
28292012-07-11 Glenn Morris <rgm@gnu.org>
2830
2831 * s/darwin.h, s/gnu-linux.h, s/template.h:
2832 Move INTERRUPT_INPUT to configure.
2833
e8df9267
DA
28342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2835
2836 Minor adjustments to interning code.
2837 * lisp.h (intern, intern_c_string): Redefine as static inline
2838 wrappers for intern_1 and intern_c_string_1, respectively.
2839 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2840 * lread.c (intern_1, intern_c_string_1, oblookup):
2841 Simplify Vobarray checking.
e8df9267
DA
2842 * font.c (font_intern_prop): Likewise. Adjust comment.
2843 * w32font.c (intern_font_name): Likewise.
2844
34348bd4
AS
28452012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2846
d96a1e0c
AS
2847 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2848
34348bd4
AS
2849 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2850 of Fcar/Fcdr if possible.
2851 * font.c (check_otf_features): Likewise.
2852 * fontset.c (Fnew_fontset): Likewise.
2853 * gnutls.c (Fgnutls_boot): Likewise.
2854 * minibuf.c (read_minibuf): Likewise.
2855 * msdos.c (IT_set_frame_parameters): Likewise.
2856 * xmenu.c (Fx_popup_dialog): Likewise.
2857 * w32menu.c (Fx_popup_dialog): Likewise.
2858
c8add24e
GM
28592012-07-11 Glenn Morris <rgm@gnu.org>
2860
4b575b3c
GM
2861 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2862 since nothing has defined it on these platforms.
2863
09f4e3b0
GM
2864 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2865 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2866
172bedef
GM
2867 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2868 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2869 Move CLASH_DETECTION to configure.
2870
249685df
GM
2871 * s/gnu.h: Remove file, which is now empty.
2872
c8add24e
GM
2873 * s/gnu.h, s/gnu-linux.h:
2874 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2875
b41253a3
JW
28762012-07-11 John Wiegley <johnw@newartisans.com>
2877
2878 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2879 function attribute, so we only use it if it exists in the
2880 compiler.
2881
d923b542
DA
28822012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2883
2884 Avoid call to strlen in fast_c_string_match_ignore_case.
2885 * search.c (fast_c_string_match_ignore_case): Change to use
2886 length argument. Adjust users accordingly.
2887 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2888
5ebbef1d
PE
28892012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2890
bb352260
PE
2891 Assume mkdir, rmdir.
2892 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2893 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2894
57054ddd
PE
2895 Assume rename.
2896 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2897
b747d3f7
PE
2898 Assume perror.
2899 * s/hpux10-20.h (HAVE_PERROR): Remove.
2900 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2901 Remove dummy definition, as this problem was obsolete long ago.
2902
5ebbef1d
PE
2903 Assume strerror.
2904 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2905
984e7f30
DA
29062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2907
2908 Avoid calls to strlen in font processing functions.
2909 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2910 (font_open_by_name): Change to use length argument.
2911 Adjust users accordingly.
d923b542
DA
2912 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2913 Adjust prototypes.
2914 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2915 Change to return ptrdiff_t.
984e7f30
DA
2916 (xfont_list_pattern, xfont_match): Use length returned by
2917 xfont_decode_coding_xlfd.
2918 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2919
20e94fdd
GM
29202012-07-11 Glenn Morris <rgm@gnu.org>
2921
9d596af3
GM
2922 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2923 Move DONT_REOPEN_PTY to configure.
2924
20e94fdd
GM
2925 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2926 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2927
e99a530f
PE
29282012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2929
22ffb973
PE
2930 Remove "#define unix" that is no longer needed (Bug#11905).
2931 * s/aix4-2.h (unix): Remove; no longer needed.
2932
e9a9ae03
PE
2933 EMACS_TIME simplification (Bug#11875).
2934 This replaces macros (which typically do not work in GDB)
2935 with functions, typedefs and enums, making the code easier to debug.
2936 The functional style also makes code easier to read and maintain.
2937 * systime.h: Include <sys/time.h> on all hosts, not just if
2938 WINDOWSNT, since 'struct timeval' is needed in general.
2939 (EMACS_TIME): Now a typedef, not a macro.
2940 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2941 not macros.
2942 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2943 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2944 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2945 (EMACS_TIME_LE): Now functions, not macros.
2946 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2947 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2948 which are not functions. All uses rewritten to use:
2949 (make_emacs_time): New function.
2950 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2951 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2952 not functions. All uses rewritten to use the following, respectively:
2953 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2954 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2955 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2956 * fileio.c (Fcopy_file):
2957 * xterm.c (XTflash): Get the current time closer to when it's used.
2958 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2959
ffacb126
PE
2960 * bytecode.c (targets): Suppress -Woverride-init warnings.
2961
e99a530f
PE
2962 Simplify by avoiding confusing use of strncpy etc.
2963 * doc.c (Fsnarf_documentation):
2964 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2965 * frame.c (Fmake_terminal_frame):
2966 * gtkutil.c (get_utf8_string):
2967 * lread.c (openp):
2968 * nsmenu.m (ns_update_menubar):
2969 * regex.c (regerror):
2970 Prefer memcpy to strncpy and strncat when either will do.
2971 * fileio.c (Fsubstitute_in_file_name):
2972 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2973 (menu_separator_name_p):
2974 * nsmenu.m (ns_update_menubar):
2975 Prefer memcmp to strncmp when either will do.
2976 * nsterm.m: Include <ftoastr.h>.
2977 (ns_get_color):
2978 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2979 Prefer snprintf to strncpy.
2980 * nsterm.m (ns_term_init):
2981 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2982 * nsterm.m (ns_term_init):
2983 Avoid the need for strncpy, by using build_string or
2984 make_unibyte_string directly. Use dtoastr, not snprintf.
2985 * process.c (Fmake_network_process): Diagnose service names that
2986 are too long, rather than silently truncating them or creating
2987 non-null-terminated names.
2988 (Fnetwork_interface_info): Likewise, for interface names.
2989 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2990 Prefer sprintf to strncat.
2991 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2992 Prefer vsnprintf to vsprintf + strncpy.
2993
c59592b3
GM
29942012-07-10 Glenn Morris <rgm@gnu.org>
2995
2996 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2997 Clarify fallback case.
2998
7d7bbefd
DA
29992012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3000
3001 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3002 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3003 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3004 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3005 where argument type is known to be a Lisp_Cons.
3006
3a4c8000
TT
30072012-07-10 Tom Tromey <tromey@redhat.com>
3008
3009 * bytecode.c (BYTE_CODE_THREADED): New macro.
3010 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3011 (enum byte_code_op): New type.
3012 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3013 (exec_byte_code): Use them. Use token threading when applicable.
3014
2a0213a6
DA
30152012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3016
3017 Optimize pure C strings initialization.
3018 * lisp.h (make_pure_string): Fix prototype.
3019 (build_pure_c_string): New function, defined as static inline. This
3020 provides a better opportunity to optimize away calls to strlen when
3021 the function is called with compile-time constant argument.
3022 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3023 argument, adjust users accordingly. Use build_pure_c_string where
3024 appropriate.
3025 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3026 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3027 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3028
cb1caeaf
DA
30292012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3030
3031 Avoid calls to strlen in miscellaneous functions.
3032 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3033 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3034 * lread.c (openp): Likewise.
3035
c293e30c
DA
30362012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3037
3038 Avoid calls to strlen in path processing functions.
3039 * fileio.c (file_name_as_directory): Add comment. Change to add
3040 srclen argument and return the length of result. Adjust users
3041 accordingly.
3042 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3043 swap 1st and 2nd arguments to obey the common convention.
3044 Adjust users accordingly.
c293e30c
DA
3045 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3046
9e059e3f
GM
30472012-07-10 Glenn Morris <rgm@gnu.org>
3048
d02eb359
GM
3049 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3050 Move PENDING_OUTPUT_COUNT definition to configure.
3051
882cf227
GM
3052 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3053 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3054 * s/gnu.h (DATA_START): Move definitions to configure.
3055
af6e839f
GM
3056 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3057 We include usg5-4-common.h, which defines them both.
3058
40289a12
GM
3059 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3060 O_RDONLY already includes it).
3061
9e059e3f
GM
3062 Stop ns builds setting the EMACSLOADPATH environment variable.
3063 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3064 Now it does not set EMACSLOADPATH, just returns the load-path string.
3065 * nsterm.h: Update accordingly.
3066 * lread.c [HAVE_NS]: Include nsterm.h.
3067 (init_lread) [HAVE_NS]: Use ns_load_path.
3068 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3069
7c4e8ec0
GM
30702012-07-09 Glenn Morris <rgm@gnu.org>
3071
d4f600ff
GM
3072 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3073 since the included bsd-common.h does so.
3074
cbb31951
GM
3075 Stop ns builds setting the EMACSPATH environment variable.
3076 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3077 (ns_init_paths): Do not set EMACSPATH.
3078 * nsterm.h (ns_exec_path): Add it.
3079 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3080 Use ns_exec_path.
3081
7c4e8ec0
GM
3082 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3083
26bccfae
PE
30842012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3085
a0bee46f
PE
3086 * process.c (wait_reading_process_output): 'waitchannels' was unset
3087 when read_kbd || !NILP (wait_for_cell); fix this.
3088
5994c183
PE
3089 Add GCC-style 'const' attribute to functions that can use it.
3090 * character.h (char_resolve_modifier_mask):
3091 * keyboard.h (make_ctrl_char):
3092 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3093 (init_character_once, next_almost_prime, init_fns, init_image)
3094 (flush_pending_output, init_sound):
3095 * mem-limits.h (start_of_data):
3096 * menu.h (finish_menu_items):
3097 Add ATTRIBUTE_CONST.
3098 * emacs.c (DEFINE_DUMMY_FUNCTION):
3099 Declare the dummy function with ATTRIBUTE_CONST.
3100 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3101 Add decls with ATTRIBUTE_CONST.
3102
26bccfae
PE
3103 Minor improvements to make_formatted_string.
3104 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3105 where int is good enough, as vsprintf returns an int.
3106 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3107
a8290ec3
DA
31082012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3109
3110 Use make_formatted_string to avoid double length calculation.
3111 * lisp.h (make_formatted_string): New prototype.
3112 * alloc.c (make_formatted_string): New function.
3113 * buffer.c (Fgenerate_new_buffer_name): Use it.
3114 * dbus.c (syms_of_dbusbind): Likewise.
3115 * editfns.c (Fcurrent_time_zone): Likewise.
3116 * filelock.c (get_boot_time): Likewise.
3117 * frame.c (make_terminal_frame, set_term_frame_name)
3118 (x_report_frame_params): Likewise.
3119 * image.c (gs_load): Likewise.
3120 * minibuf.c (get_minibuffer): Likewise.
3121 * msdos.c (dos_set_window_size): Likewise.
3122 * process.c (make_process): Likewise.
3123 * xdisp.c (ensure_echo_area_buffers): Likewise.
3124 * xsettings.c (apply_xft_settings): Likewise.
3125
d01ba2f1
GM
31262012-07-09 Glenn Morris <rgm@gnu.org>
3127
3128 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3129 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3130 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3131 * nsterm.h (ns_etc_directory): Add it.
3132 * callproc.c [HAVE_NS]: Include nsterm.h.
3133 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3134
f1f924b6
DA
31352012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3136
3137 Move marker debugging code under MARKER_DEBUG.
3138 * marker.c (MARKER_DEBUG): Move marker debugging code under
3139 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3140 for bootstrap with --enable-checking (~3x slowdown reported
3141 by Juanma Barranquero <lekktu@gmail.com>).
3142 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3143
ab531b66
PE
31442012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3147 See <http://bugs.gnu.org/11825#29>.
3148
c4b3bc8a
EZ
31492012-07-08 Eli Zaretskii <eliz@gnu.org>
3150
3151 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3152 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3153 (display_line): Add commentary about displaying truncation glyphs
3154 on GUI frames.
3155 (produce_special_glyphs): Move here from term.c.
3156
3157 * term.c (produce_special_glyphs): Move to xdisp.c.
3158
3159 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3160 section.
c4b3bc8a 3161
b676b881
AS
31622012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3163
f17c5273
AS
3164 * xdisp.c (display_line): Avoid warning about implicit declaration
3165 of FRAME_FONT.
3166
298819b9
AS
3167 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3168
b676b881
AS
3169 * lisp.h: Remove empty conditional.
3170
6045c4fd
PE
31712012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3172
b3350bf9
PE
3173 * lread.c (load_path_check): Now static.
3174
6045c4fd
PE
3175 Fix some minor --with-ns problems found by static checking.
3176 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3177 (x_set_font) [!HAVE_X_WINDOWS]:
3178 * image.c (xpm_load_image) [HAVE_NS]:
3179 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3180 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3181 Remove unused local.
3182 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3183 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3184 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3185 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3186 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3187 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3188 Fix pointer signedness problem.
3189 * xfaces.c (FRAME_X_FONT_TABLE):
3190 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3191
929e7845
GM
31922012-07-07 Glenn Morris <rgm@gnu.org>
3193
3194 * lread.c (load_path_check): New function, split from init_lread.
3195 (init_lread): Reorganize. Motivation:
3196 If EMACSLOADPATH is set, check/warn about that rather than the
3197 defaults, which we are not going to use. Hence we can remove
3198 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3199 Don't warn if site-lisp directories are missing.
3200 If not installed, start from a blank load-path, since
3201 PATH_LOADSEARCH refers to the eventual installation directories.
3202
58dd0aa4
EZ
32032012-07-07 Eli Zaretskii <eliz@gnu.org>
3204
3205 Support truncation and continuation glyphs on GUI frames, when
3206 fringes are disabled. (Bug#11832)
3207 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3208 continuation glyphs even if on GUI frames.
3209 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3210 or both, are absent.
3211 (start_display, move_it_in_display_line_to): Handle the case of a
3212 GUI frame without a fringe to display continuation or truncation
3213 glyphs.
3214 (insert_left_trunc_glyphs): Support GUI frames: make sure
3215 truncation glyphs overwrite enough glyphs from the current line to
3216 have sufficient space in pixels.
3217 (display_line): Support truncation and continuation glyphs on GUI
3218 frames. If some spare pixels are left on the line after inserting
3219 the truncation glyphs, fill that space with a stretch glyph of a
3220 suitably computed width.
3221
3222 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
3223 produce_glyphs, to support GUI sessions.
3224
31571fd7
PE
32252012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3226
5a16b9bc
PE
3227 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
3228
f3047c75
PE
3229 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
3230
31571fd7
PE
3231 Do not require float-time's arg to fit in time_t (Bug#11825).
3232 This works better on hosts where time_t is unsigned, and where
3233 float-time is applied to the (negative) difference between two times.
3234 * editfns.c (decode_time_components): Last arg is now double *,
3235 not int *, and means to store all the result as a double, without
3236 worrying about whether the seconds part fits in time_t.
3237 All callers changed.
3238 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
3239 All callers changed.
3240 (Ffloat_time): Do not fail merely because the specified time falls
3241 outside of time_t range.
3242
4516fbef
GM
32432012-07-07 Glenn Morris <rgm@gnu.org>
3244
3245 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
3246 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
3247 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
3248
07adc2c6
JB
32492012-07-07 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
3252 Update dependencies.
3253
3254 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
3255
fd573f31
PE
32562012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3257
fee5959d
PE
3258 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
3259 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
3260 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
3261 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
3262 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
3263 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
3264
fd573f31
PE
3265 * xfont.c (compare_font_names): Redo to omit the need for casts.
3266
ddadbc0e
AS
32672012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3268
fca8d6b6
AS
3269 * xfns.c (Fx_change_window_property): Doc fix.
3270 * w32fns.c (Fx_change_window_property): Doc fix.
3271
ddadbc0e
AS
3272 * w32fns.c (Fx_window_property): Accept the same arguments as the
3273 X Windows version. Doc fix.
3274 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
3275
ed9265fc 32762012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
3277 Eli Zaretskii <eliz@gnu.org>
3278
3279 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
3280 Windows-specific code from nt/config.nt moved here.
3281 Obsolete settings removed.
3282
216ee680
PE
32832012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 * process.c: Avoid unnecessary calls to gettime.
3286 (wait_reading_process_output): Don't get the time of day
3287 when gobbling data immediately and not waiting, as there's no need
3288 for it in that case. This removes a FIXME.
3289
bdd091e4
JD
32902012-07-06 Jan Djärv <jan.h.d@swipnet.se>
3291
3292 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
3293 is defined (Bug#11768).
3294
9d44f8ce
DA
32952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3296
3297 Fix marker debugging code.
3298 * marker.c (byte_char_debug_check): Do not perform the check
3299 if buffer is not multibyte.
090bd7cb
JB
3300 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3301 Call byte_char_debug_check with correct arguments.
9d44f8ce 3302
90fc4786
DA
33032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3304
3305 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
3306 * marker.c (byte_char_debug_check, count_markers):
3307 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
3308 (byte_debug_flag): Remove.
3309 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3310 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
3311
7b7ae965
DA
33122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3313
4e57b342
DA
3314 Avoid code repetition in marker-related functions.
3315 * marker.c (attach_marker): New function.
3316 (Fset_marker, set_marker_restricted, set_marker_both)
3317 (set_marker_restricted_both): Use it.
3318 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
3319 Consistently rename charno to charpos.
3320 (marker_position): Add eassert.
3321 (marker_byte_position): Convert to eassert.
3322
33232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3324
3325 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 3326 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 3327 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 3328
657924ff
DA
33292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3330
3331 Introduce fast path for the widely used marker operation.
3332 * alloc.c (build_marker): New function.
3333 * lisp.h (build_marker): New prototype.
3334 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
3335 * composite.c (autocmp_chars): Likewise.
3336 * editfns.c (buildmark): Remove.
3337 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
3338 (save_restriction_save): Use build_marker.
3339 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
3340 * window.c (save_window_save): Likewise.
3341
041a49a6
DA
33422012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3343
3344 Do not use Fdelete_overlay in delete_all_overlays
3345 to avoid redundant calls to unchain_overlay.
3346 * buffer.c (drop_overlay): New function.
3347 (delete_all_overlays, Fdelete_overlay): Use it.
3348 * minibuf.c (get_minibuffer): Fix comment.
3349
7dca65a4
PE
33502012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3351
3352 Port to OpenBSD 5.1 amd64.
3353 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
3354 This is needed for OpenBSD, and should be harmless on all BSD systems.
3355 Also, include <sys/sysctl.h>, as it should be available on all
3356 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
3357 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
3358 use p_pid member, not kp_proc.pid.
3359
8eb876e2
GM
33602012-07-06 Glenn Morris <rgm@gnu.org>
3361
3362 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
3363
38182d90
PE
33642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 More xmalloc and related cleanup.
3367 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
3368 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
3369 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
3370 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
3371 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
3372 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
3373 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
3374 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
3375 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
3376 * xterm.c:
3377 Omit needless casts involving void * pointers and allocation.
3378 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
3379 as the former is more robust if P's type is changed.
3380 Prefer xzalloc to xmalloc + memset 0.
3381 Simplify malloc-or-realloc to realloc.
3382 Don't worry about xmalloc returning a null pointer.
3383 Prefer xstrdup to xmalloc + strcpy.
3384 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
3385 growing it.
3386 * keyboard.c (apply_modifiers_uncached): Prefer local array to
3387 alloca of a constant.
3388
6dd5a677
EZ
33892012-07-05 Eli Zaretskii <eliz@gnu.org>
3390
3391 * xdisp.c (display_line): Fix horizontal pixel coordinates when
3392 hscroll is larger than the line width. Fixes long and futile
3393 looping inside extend_face_to_end_of_line (on a TTY) producing
3394 glyphs that are not needed and thrown away.
3395
6b312f0f
DA
33962012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3397
3398 * marker.c (set_marker_restricted_both): Simplify by using
3399 clip_to_bounds.
3400
f520ef9b
PE
34012012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * editfns.c (region_limit): Simplify by using clip_to_bounds.
3404
383b7c95
JD
34052012-07-05 Jan Djärv <jan.h.d@swipnet.se>
3406
3407 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
3408 not defined (Bug#11768).
3409 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
3410 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
3411 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
3412 followed by gtk_box_set_homogeneous (Bug#11768).
3413 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
3414 (update_theme_scrollbar_width, xg_create_scroll_bar):
3415 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
3416 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
3417 (is_box_type): New function (Bug#11768).
3418 (xg_tool_item_stale_p): Call is_box_type.
5293d758 3419 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
3420 with default display (Bug#11768).
3421
d6e7bf45
EZ
34222012-07-05 Eli Zaretskii <eliz@gnu.org>
3423
3424 * xdisp.c (window_hscroll_limited): New function.
3425 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
3426 coordinates when window's hscroll is set to insanely large
3427 values. (Bug#11857)
3428
431391ec
JB
34292012-07-05 Juanma Barranquero <lekktu@gmail.com>
3430
3431 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
3432 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
3433
23f86fce
DA
34342012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3435
3436 Cleanup xmalloc.
3437 * lisp.h (xzalloc): New prototype. Omit needless casts.
3438 * alloc.c (xzalloc): New function. Omit needless casts.
3439 * charset.c: Omit needless casts. Convert all calls to
3440 xmalloc with following memset to xzalloc.
3441 * dispnew.c: Likewise.
3442 * fringe.c: Likewise.
3443 * image.c: Likewise.
3444 * sound.c: Likewise.
3445 * term.c: Likewise.
3446 * w32fns.c: Likewise.
3447 * w32font.c: Likewise.
3448 * w32term.c: Likewise.
3449 * xfaces.c: Likewise.
3450 * xfns.c: Likewise.
3451 * xterm.c: Likewise.
3452 * atimer.c: Omit needless casts.
3453 * buffer.c: Likewise.
3454 * callproc.c: Likewise.
3455 * ccl.c: Likewise.
3456 * coding.c: Likewise.
3457 * composite.c: Likewise.
3458 * doc.c: Likewise.
3459 * doprnt.c: Likewise.
3460 * editfns.c: Likewise.
3461 * emacs.c: Likewise.
3462 * eval.c: Likewise.
3463 * filelock.c: Likewise.
3464 * fns.c: Likewise.
3465 * gtkutil.c: Likewise.
3466 * keyboard.c: Likewise.
3467 * lisp.h: Likewise.
3468 * lread.c: Likewise.
3469 * minibuf.c: Likewise.
3470 * msdos.c: Likewise.
3471 * print.c: Likewise.
3472 * process.c: Likewise.
3473 * region-cache.c: Likewise.
3474 * search.c: Likewise.
3475 * sysdep.c: Likewise.
3476 * termcap.c: Likewise.
3477 * terminal.c: Likewise.
3478 * tparam.c: Likewise.
3479 * w16select.c: Likewise.
3480 * w32.c: Likewise.
3481 * w32reg.c: Likewise.
3482 * w32select.c: Likewise.
3483 * w32uniscribe.c: Likewise.
3484 * widget.c: Likewise.
3485 * xdisp.c: Likewise.
3486 * xmenu.c: Likewise.
3487 * xrdb.c: Likewise.
3488 * xselect.c: Likewise.
3489
0497dc44
PE
34902012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * fileio.c (time_error_value): Check the right error number.
3493 Problem reported by Troels Nielsen in
3494 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3495
356e7178
PE
34962012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3497
4e71fd89
PE
3498 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3499 This should be fixed in a better way; see Eli Zaretskii in
3500 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3501 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3502
f0941253
PE
3503 * fileio.c (time_error_value): Rename from special_mtime.
3504 The old name's problems were noted by Eli Zaretskii in
3505 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3506
065c9eb4
PE
3507 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3508 This variable's comment says Emacs needs at least one GDB-visible
3509 symbol of type enum pvec_type, to work around GDB problems.
3510 The symbol's value doesn't matter.
3511
356e7178
PE
3512 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3513 that causes compilation to fail on pre-C99 compilers.
3514
ed9265fc 35152012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3516
3517 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3518 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3519
3884d954
DA
35202012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3521
d209e2fb 3522 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3523 headers for buffer_defaults and buffer_local_symbols.
3524 Reported by Juanma Barranquero <lekktu@gmail.com>.
3525
ee28be33
SM
35262012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3527
3528 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3529 * lisp.h (enum pvec_type): Use fewer bits.
3530 (PSEUDOVECTOR_SIZE_BITS): New constant.
3531 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3532 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3533 change in pvec_type.
3534 (PSEUDOVECTOR_TYPEP): New macro.
3535 (TYPED_PSEUDOVECTORP): Use it.
3536 * fns.c (internal_equal): Adapt code to extract pvectype.
3537 * emacs.c (gdb_pvec_type): Update type.
3538 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3539 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3540 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3541 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3542 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3543 abusing vector->header.next.nbytes.
3544 (live_vector_p): Use PVEC_TYPE.
3545 (mark_object): Adapt code to extract pvectype. Use switch.
3546
c7f2cd7f
PE
35472012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3548
3549 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3550 Tighten new eassert a bit.
3551
8ce70ed2
DA
35522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3553
3554 Fix compilation with --enable-gcc-warnings and -O1
3555 optimization level.
3556 * doprnt.c (doprnt): Change type of tem to int, initialize
3557 to avoid compiler warning. Add eassert.
3558 * search.c (simple_search): Initialize match_byte to avoid
3559 compiler warning. Add eassert.
3560
dea7f1e5
PE
35612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3562
24a212eb
PE
3563 Avoid weird behavior with large horizontal scrolls.
3564 Without this change, for example, large hscroll values would
3565 mess up Emacs's display on Fedora 15 x86, presumably due to
3566 overflows in int calculations in the display code.
3567 Also, if buffers had long lines, Emacs would freeze.
3568 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3569 (set_window_hscroll): New function, containing the old guts of
3570 Fset_window_hscroll. Return the clipped value.
3571 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3572 This avoids the need to check against PTRDIFF_MAX.
3573
dea7f1e5
PE
3574 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3575
76046526
DA
35762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3577
3578 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3579
39adff0d
PE
35802012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3581
63807d47
PE
3582 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3583 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3584 since GCC 4.4.6 issues a bogus warning for them.
3585
39adff0d
PE
3586 Fix bugs in file timestamp newness comparisons.
3587 * fileio.c (Ffile_newer_than_file_p):
3588 * lread.c (Fload): Use full timestamp resolution of files,
3589 not just the 1-second resolution, so that files that are only
3590 slightly newer still count as newer.
3591 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3592 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3593
dbeed9a6
PE
35942012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3595
3596 * fileio.c: Improve handling of file time marker. (Bug#11852)
3597 (special_mtime): New function.
3598 (Finsert_file_contents, Fverify_visited_file_modtime):
3599 Use it to set special mtime values consistently.
3600
636334d6
AS
36012012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3602
3603 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3604 marker for non-existing file. (Bug#11852)
3605
e2017fe2
GM
36062012-07-03 Glenn Morris <rgm@gnu.org>
3607
3608 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3609 and did not make it into globals.h).
3610
404dbd37
TT
36112012-07-03 Tom Tromey <tromey@redhat.com>
3612
3613 * window.c (Fset_window_margins, Fset_window_fringes)
3614 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3615 * textprop.c (Fprevious_property_change): No longer static.
3616 * syntax.c (Fsyntax_table_p): No longer static.
3617 * process.c (Fget_process, Fprocess_datagram_address): No longer
3618 static.
3619 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3620 * keyboard.c (Fcommand_execute): No longer static.
3621 Remove EXFUN.
3622 * insdel.c (Fcombine_after_change_execute): No longer static.
3623 * image.c (Finit_image_library): No longer static.
3624 * fileio.c (Fmake_symbolic_link): No longer static.
3625 * eval.c (Ffetch_bytecode): No longer static.
3626 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3627 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3628 No longer static.
404dbd37
TT
3629 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3630 static.
3631 * dired.c (Ffile_attributes): No longer static.
3632 * composite.c (Fcomposition_get_gstring): No longer static.
3633 * callproc.c (Fgetenv_internal): No longer static.
3634
3635 * ccl.h: Remove EXFUNs.
3636 * buffer.h: Remove EXFUNs.
3637 * dispextern.h: Remove EXFUNs.
3638 * intervals.h: Remove EXFUNs.
3639 * fontset.h: Remove EXFUN.
3640 * font.h: Remove EXFUNs.
3641 * dosfns.c (system_process_attributes): Remove EXFUN.
3642 * keymap.h: Remove EXFUNs.
3643 * lisp.h: Remove EXFUNs.
3644 * w32term.h: Remove EXFUNs.
3645 * window.h: Remove EXFUNs.
3646 * xsettings.h: Remove EXFUN.
3647 * xterm.h: Remove EXFUN.
3648
8e4fd1e1
GM
36492012-07-03 Glenn Morris <rgm@gnu.org>
3650
3651 * lisp.h (Frandom): Make it visible to C.
3652 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3653 buffer for invisible buffers. (Bug#1229)
3654
ca95b3eb
DA
36552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3656
3657 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3658 values which aren't power of 2.
14ae4239
BT
3659 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3660 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3661 accordingly.
3662
7555c33f
SM
36632012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3664
3665 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3666
3667 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3668
d12e8f5a
DA
36692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3670
3671 * alloc.c (allocate_vector_block): Remove redundant
3672 calls to mallopt if DOUG_LEA_MALLOC is defined.
3673 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3674 avoid calls to mallopt if zero_vector is returned.
3675
296094c3
DA
36762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3677
3678 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3679 is enabled, avoid dereferencing NULL current_sblock if
3680 running undumped.
3681
36429c89
DA
36822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3683
3684 Cleanup basic buffer management.
3685 * buffer.h (struct buffer): Change layout to use generic vector
3686 marking code. Fix some comments. Change type of 'clip_changed'
3687 to bitfield. Remove unused #ifndef old.
3688 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3689 (GET_OVERLAYS_AT): Fix indentation.
3690 (for_each_per_buffer_object_at): New macro.
3691 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3692 (Fbuffer_local_variables): Use it.
3693 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3694 * alloc.c (allocate_buffer): Adjust to match new layout of
3695 struct buffer. Fix comment.
3696 (mark_overlay): New function.
3697 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3698 Lisp area of struct buffer.
3699 (mark_object): Use it. Adjust marking of misc objects
3700 and related comments.
3701
3b3e4cac
PE
37022012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3705 wrapper that is not needed because the wrapped code is a no-op (zero
3706 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3707 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3708
cf5c0175
DA
37092012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3710
3711 * alloc.c (mark_buffer): Simplify. Remove prototype.
3712 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3713 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3714 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3715 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3716
ca26824c
GM
37172012-06-30 Glenn Morris <rgm@gnu.org>
3718
2e4c5312
GM
3719 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3720
ca26824c
GM
3721 * epaths.in (PATH_SITELOADSEARCH): New.
3722 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3723 This is rather than relying on --enable-locallisppath elements
3724 having "site-lisp" in their names. (Bug#10208#25, 11658)
3725
0d23c240
EZ
37262012-06-30 Eli Zaretskii <eliz@gnu.org>
3727
c9240d7a
EZ
3728 * w32proc.c (sys_select): Accept and ignore one more argument.
3729
3730 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3731
0d23c240 3732 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3733 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3734
3735 * sysdep.c: Don't include dos.h and dosfns.h.
3736
3737 * process.c (sys_select):
3738 * msdos.c (sys_select): Accept one more argument and ignore it.
3739
3740 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3741 adapt data types and code to that.
3742
3743 * dosfns.c:
3744 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3745 which clashes with the gnulib function of the same name.
3746
af5a5a98
AS
37472012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3748
c5e4379c
AS
3749 * font.c (font_style_to_value, font_style_symbolic)
3750 (font_prop_validate_style): Add type checks for values in
3751 font_style_table.
3752
af5a5a98
AS
3753 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3754 argument.
3755 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3756 uses.
3757
8d38f461
EZ
37582012-06-29 Eli Zaretskii <eliz@gnu.org>
3759
2e5a6631
EZ
3760 * xdisp.c (try_window_id): Undo last change.
3761
8d38f461
EZ
3762 * w32.c (getwd): Adjust commentary about startup_dir.
3763 (init_environment): Always call sys_access, even in non-MSVC
3764 builds. Don't chdir to the directory of the Emacs executable.
3765 This undoes code from 1997 which was justified by the need to
3766 "avoid conflicts when removing and renaming directories". But its
3767 downside was that every relative file name was being interpreted
3768 relative to the directory of the Emacs executable, which can never
3769 be TRT. In particular, it broke sys_access when called with
3770 relative file names.
3771 (sys_access): Map GetLastError to errno.
3772
2af3565e
DA
37732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3774
3775 * window.h (struct window): Change type of 'fringes_outside_margins'
3776 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3777 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3778 Adjust comment.
3779 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3780 to ptrdiff_t.
3781
c8d3a25c 37822012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3783
c8d3a25c
GM
3784 * gnutls.c (emacs_gnutls_handshake):
3785 Add QUIT to make the loop interruptible.
57570cd3 3786
c8d3a25c 37872012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3788
c8d3a25c
GM
3789 * charset.c (init_charset): Make lack of etc/charsets fatal.
3790
3e984ee8
DA
37912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3792
3793 * editfns.c (region_limit): Fix type mismatch.
3794
ef884f23
DA
37952012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3796
3797 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3798 undefined. Convert from xassert to eassert.
3799 * nsmenu.m: Convert from xassert to eassert.
3800 * nsterm.m: Likewise.
3801
7d7e0027
SM
38022012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3803
3804 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3805
aa754e6a
PE
38062012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Avoid integer overflow on scroll-left and scroll-right.
3809 * window.c (HSCROLL_MAX): New macro.
3810 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3811 overflow when requested scroll falls outside ptrdiff_t range.
3812
80b00b08
DA
38132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3814
3815 * window.h (struct window): Change type of 'hscroll',
3816 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3817 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3818 Adjust users accordingly.
3819 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3820 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3821 from EMACS_INT to ptrdiff_t.
3822 (make_window): Omit redundant initialization.
3823
62b2bcf6
JB
38242012-06-28 Juanma Barranquero <lekktu@gmail.com>
3825
3826 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3827
45942c7d
DA
38282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3829
3830 * window.h (struct window): Change type of 'use_time' and
3831 'sequence_number' from Lisp_Object to int.
3832 * frame.c (make_frame): Adjust users accordingly.
3833 * print.c (print_object): Likewise.
3834 * window.c (select_window, Fwindow_use_time, make_parent_window)
3835 (make_window): Likewise.
3836
e509cfa6
DA
38372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3838
3839 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3840 enabled with --enable-checking=[all,glyphs] configure option.
3841 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3842 adjust comments accordingly.
3843 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3844 undefined, adjust comments accordingly.
3845 * image.c: Likewise.
3846 * scroll.c: Likewise.
3847 * w32fns.c: Likewise.
3848 * w32term.c: Likewise.
3849 * xdisp.c: Likewise.
3850 * xfaces.c: Likewise.
3851 * xfns.c: Likewise.
3852 * xterm.c: Likewise.
3853
a54e2c05
DA
38542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3855
3856 Generalize run-time debugging checks.
3857 * dispextern.h (XASSERTS): Remove.
3858 * fontset.c (xassert): Remove.
3859 Convert from xassert to eassert.
3860 * alloc.c: Convert from xassert to eassert.
3861 * bidi.c: Likewise.
3862 * dispnew.c: Likewise.
3863 * fns.c: Likewise.
3864 * fringe.c: Likewise.
3865 * ftfont.c: Likewise.
3866 * gtkutil.c: Likewise.
3867 * image.c: Likewise.
3868 * keyboard.c: Likewise.
3869 * menu.c: Likewise.
3870 * process.c: Likewise.
3871 * scroll.c: Likewise.
3872 * sound.c: Likewise.
3873 * term.c: Likewise.
3874 * w32console.c: Likewise.
3875 * w32fns.c: Likewise.
3876 * w32term.c: Likewise.
3877 * window.c: Likewise.
3878 * xdisp.c: Likewise.
3879 * xfaces.c: Likewise.
3880 * xfns.c: Likewise.
3881 * xselect.c: Likewise.
3882 * xterm.c: Likewise.
3883
1ec4b7b2
SM
38842012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3885
3886 * fns.c (maybe_resize_hash_table): Output message when growing the
3887 purify-hashtable.
3888
2014308a
DA
38892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3890
3891 * alloc.c (allocate_string_data): Remove dead code.
3892 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3893 avoid GCC warning about unused macro.
3894
246155eb
DA
38952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3896
3897 * alloc.c (allocate_string): Omit intervals initialization.
3898 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3899 as in make_pure_string and make_pure_c_string.
3900
43184b7b
DA
39012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3902
d209e2fb 3903 * alloc.c (allocate_string): Fix last change.
43184b7b 3904
3fe6dd74
DA
39052012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3906
d209e2fb 3907 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3908 to memset, add explicit initialization where appropriate.
3909
1ba6038a
GM
39102012-06-27 Glenn Morris <rgm@gnu.org>
3911
3912 * lisp.mk (lisp): Remove paths.elc.
3913
c89926a5
CY
39142012-06-27 Chong Yidong <cyd@gnu.org>
3915
3916 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3917
ed6b3510
JW
39182012-06-26 John Wiegley <johnw@newartisans.com>
3919
1ec4b7b2 3920 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3921 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3922
ed6b3510
JW
3923 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3924 when building with Clang.
3925
8edd4a2b
SM
39262012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3927
3928 * eval.c (Fapply): Allow calling it with a single argument.
3929
f6f62d1b
EZ
39302012-06-26 Eli Zaretskii <eliz@gnu.org>
3931
3932 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3933 _stricmp and _strnicmp.
3934 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3935
62efea5e
DA
39362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3937
3938 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3939 allocated window.
3940 (allocate_process): Likewise for new process.
8edd4a2b 3941 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3942 (allocate_frame): Likewise.
3943 * frame.c (make_frame): Omit redundant initialization.
3944 * window.c (make_parent_window): Use memset.
3945 (make_window): Omit redundant initialization.
3946 * process.c (make_process): Omit redundant initialization.
3947 * terminal.c (create_terminal): Likewise.
3948
42997f4d
DA
39492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3950
3951 * term.c (delete_tty): Remove redundant call to memset.
3952
1130ecfc
DA
39532012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3954
3955 * alloc.c: Remove build_string.
3956 * lisp.h: Define build_string as static inline. This provides
3957 a better opportunity to optimize away calls to strlen when the
3958 function is called with compile-time constant argument.
3959 * image.c (imagemagick_error): Convert to build_string.
3960 * w32proc.c (sys_spawnve): Likewise.
3961 * xterm.c (x_term_init): Likewise.
3962
cf38a720
PE
39632012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3964
99027bdd
PE
3965 Use sprintf return value instead of invoking strlen on result.
3966 In the old days this wasn't portable, since some sprintf
3967 implementations returned char *. But they died out years ago and
3968 Emacs already assumes sprintf returns int.
3969 Similarly for float_to_string.
3970 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3971 * ccl.c (ccl_driver):
3972 * character.c (string_escape_byte8):
3973 * data.c (Fnumber_to_string):
3974 * doprnt.c (doprnt):
3975 * print.c (print_object):
3976 * xdisp.c (message_dolog):
3977 * xfns.c (syms_of_xfns):
3978 Use sprintf or float_to_string result to avoid need to call strlen.
3979 * data.c (Fnumber_to_string):
3980 Use make_unibyte_string, since the string must be ASCII.
3981 * lisp.h, print.c (float_to_string): Now returns int length.
3982 * term.c (produce_glyphless_glyph):
3983 Use sprintf result rather than recomputing it.
3984
cf38a720
PE
3985 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3986 * Makefile.in (ALL_CFLAGS):
3987 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3988 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3989
3511c784
DA
39902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3991
0a08eb21 3992 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3993 strcasecmp if available.
3994 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3995
fb7da12e
AS
39962012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3997
3998 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3999 Avoid comma operator.
4000 * menu.c (push_submenu_start, push_submenu_end)
4001 (push_left_right_boundary, push_menu_pane): Likewise.
4002 * msdos.c (dos_rawgetc): Likewise.
4003
afa2ffd8
DA
40042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4005
4006 * xfns.c (xic_create_fontsetname): Remove redundant calls
4007 to memset.
4008
b3b4476b
PE
40092012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4010
4495ff38
PE
4011 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4012 sprintf already null-terminates its output.
4013
b3b4476b
PE
4014 * xfns.c (x_window): Remove redundant cast.
4015
b00876c9
DA
40162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4017
4018 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4019 `const char *' to `char *' to avoid compiler warning.
4020
d188e26b
PE
40212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4022
885d1d74
PE
4023 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4024 instead of truncating it to 63 (admittedly a generous limit).
4025
d188e26b
PE
4026 * process.c: Fix spelling and caps in comments.
4027
e2f560b1
DN
40282012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4029
e86db54b 4030 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4031 * sysdep.c (setpgrp): Remove definition, not used in this file.
4032
7583a3a1
JB
40332012-06-24 Juanma Barranquero <lekktu@gmail.com>
4034
4035 * makefile.w32-in: Update dependencies.
4036
696056c2
EZ
40372012-06-24 Eli Zaretskii <eliz@gnu.org>
4038
4039 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4040 (SYSTIME_H): Add nt/inc/sys/time.h.
4041
4042 * systime.h [WINDOWSNT]: Include sys/time.h.
4043
4044 * s/ms-w32.h (struct timespec): Definition moved from
4045 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4046
845ca893
PE
40472012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4048
4049 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4050 * buffer.h (buffer_slot_type_mismatch):
4051 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4052 * eval.c (unwind_to_catch):
4053 * image.c (my_png_error, my_error_exit):
4054 * keyboard.c (quit_throw_to_read_char, user_error)
4055 (Fexit_recursive_edit, Fabort_recursive_edit):
4056 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4057 (wrong_type_argument, buffer_overflow, __executable_start)
4058 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4059 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4060 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4061 (fatal):
4062 (child_setup) [!DOS_NT]:
4063 * lread.c (end_of_file_error, invalid_syntax):
4064 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4065 * puresize.h (pure_write_error):
4066 * search.c (matcher_overflow):
4067 * sound.c (sound_perror, alsa_sound_perror):
4068 * sysdep.c, syssignal.h (croak):
4069 * term.c (maybe_fatal, vfatal):
4070 * textprop.c (text_read_only):
4071 * undo.c (user_error):
4072 * unexmacosx.c (unexec_error):
4073 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4074 Use _Noreturn rather than NO_RETURN.
4075 No need for separate decl merely because of _Noreturn.
4076 * sound.c (sound_warning, parse_sound):
4077 Remove unnecessary forward decls.
4078
f1dd8073
PE
40792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4080
4081 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4082 * lisp.h (WAIT_READING_MAX): New macro.
4083 * dispnew.c (Fsleep_for, sit_for):
4084 * keyboard.c (kbd_buffer_get_event):
4085 * process.c (Faccept_process_output):
4086 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4087 This improves on the previous patch, which introduced a bug
4088 when time_t is unsigned and as wide as intmax_t.
4089 See <http://bugs.gnu.org/9000#51>.
4090
b82c1755
EZ
40912012-06-23 Eli Zaretskii <eliz@gnu.org>
4092
4093 * dispnew.c (sit_for, Fsleep_for):
4094 * keyboard.c (kbd_buffer_get_event):
4095 * process.c (Faccept_process_output): Avoid compiler warnings when
4096 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4097
ca300656
JB
40982012-06-23 Juanma Barranquero <lekktu@gmail.com>
4099
049ec95b
JB
4100 * makefile.w32-in: Update dependencies.
4101
ca300656
JB
4102 * w32.c (ltime): Add return type and declare static.
4103 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4104
db7b8d06
PE
41052012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4106
4107 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4108 Privately reported by Herbert J. Skuhra.
4109 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4110 All uses changed.
4111 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4112 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4113
0bd8297f
EZ
41142012-06-23 Eli Zaretskii <eliz@gnu.org>
4115
96512555
EZ
4116 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4117 last argument of make_unibyte_string.
4118
0bd8297f
EZ
4119 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4120 language ID in the event parameters.
4121
4122 * w32term.c (w32_read_socket): Put the new keyboard codepage into
4123 event.code, not the obscure "character set ID".
4124
63def6b6
CY
41252012-06-23 Chong Yidong <cyd@gnu.org>
4126
4127 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4128
e8a02204
EZ
41292012-06-23 Eli Zaretskii <eliz@gnu.org>
4130
388cdec0
EZ
4131 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4132 * w32.c (fdutimens): New function.
4133
4134 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4135
4136 * s/ms-w32.h (pselect): Redirect to sys_select.
4137
4138 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4139
e8a02204
EZ
4140 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4141 in the logic of incrementing and decrementing the value of
4142 use_relocatable_buffers.
4143
d054f3fb
PE
41442012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4147 Privately reported by Herbert J. Skuhra.
4148 [__FreeBSD__]: Remove "*/" typo after "#include".
4149 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4150 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4151 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4152 Don't assume EMACS_TIME and struct timeval are the same type.
4153
d35af63c
PE
41542012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 Support higher-resolution time stamps (Bug#9000).
4157 The time stamps are only nanosecond-resolution at the C level,
4158 since that's the best that any real-world system supports now.
4159 But they are picosecond-resolution at the Lisp level, as that's
4160 easy, and leaves room for future OS improvements.
4161
4162 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4163 (LIBES): Use it.
4164
4165 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4166 Don't get current time unless it's needed.
4167
4168 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4169 now provides it if it's absent.
4170 (start_atimer): Port to higher-res time stamps.
4171 Check for time stamp overflow. Don't get current time more
4172 often than is needed.
4173
4174 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4175 Include systime.h, not time.h.
4176 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4177
4178 * dired.c: Include stat-time.h.
4179 (Ffile-attributes): File times now have higher resolution.
4180
4181 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4182 (struct image): Timestamp now has higher resolution.
4183
4184 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4185 has at least microseconds now. All uses removed.
4186 (update_frame, update_single_window, update_window, update_frame_1)
4187 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4188 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4189
4190 * editfns.c (time_overflow): Now extern.
4191 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4192 (float-time, Fformat_time_string, Fcurrent_time_string)
4193 (Fcurrent_time_zone): Accept and generate higher-resolution
4194 time stamps.
4195 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4196 (decode_time_components, lisp_seconds_argument): New functions.
4197 (make_time): Now static.
4198 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4199 Report an error if the time is invalid, rather than having the caller
4200 do that.
4201
4202 * fileio.c: Include <stat-time.h>
4203 (Fcopy_file): Copy higher-resolution time stamps.
4204 Prefer to set the time stamp via a file descriptor if that works.
4205 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4206 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4207 (Fvisited_file_modtime, Fset_visited_file_modtime):
4208 Support higher-resolution time stamps.
4209
4210 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4211
4212 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
4213
4214 * image.c (prepare_image_for_display, clear_image_cache)
4215 (lookup_image): Port to higer-resolution time stamps.
4216
4217 * keyboard.c (start_polling, bind_polling_period):
4218 Check for time stamp overflow.
4219 (read_char, kbd_buffer_get_event, timer_start_idle)
4220 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
4221 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
4222 Port to higher-resolution time stamps. Do not assume time_t is signed.
4223 (decode_timer): New function. Timers are now vectors of length 9,
4224 not 8, to accommodate the picosecond component.
4225 (timer_check_2): Use it.
4226
4227 * nsterm.m (select_timeout, timeval_subtract): Remove.
4228 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
4229 as they're a bit more accurate and handle overflow better.
4230 (ns_select): Change prototype to be compatible with pselect.
4231 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
4232 * nsterm.h (ns_select): Adjust prototype.
4233
4234 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
4235 us-resolution time stamps.
4236 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
4237
4238 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
4239
4240 * lisp.h (time_overflow): New decl.
4241 (wait_reading_process_output): First arg is now intmax_t, not int,
4242 to accommodate larger waits.
4243
4244 * process.h (struct Lisp_Process.read_output_delay):
4245 Now counts nanoseconds, not microseconds.
4246 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
4247 EMACS_HAS_USECS.
4248 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
4249 (wait_reading_process_output):
4250 Port to ns-resolution time stamps.
4251 (Faccept_process_output, wait_reading_process_output):
4252 Check for time stamp overflow. Do not assume time_t is signed.
4253 (select_wrapper): Remove; we now use pselect.
4254 (Fprocess_attributes): Now generates ns-resolution time stamps.
4255
4256 * sysdep.c: Include utimens.h. Don't include utime.h
4257 or worry about struct utimbuf; gnulib does that for us now.
4258 (gettimeofday): Remove; gnulib provides a substitute.
4259 (make_timeval): New function.
4260 (set_file_times): Now sets ns-resolution time stamps.
4261 New arg FD; all uses changed.
4262 (time_from_jiffies, ltime_from_jiffies, get_up_time)
4263 (system_process_attributes):
4264 Now returns ns-resolution time stamp. All uses changed.
4265 Check for time stamp overflow.
4266
4267 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
4268 provides a substitute now.
4269
4270 * systime.h: Include timespec.h rather than sys/time.h and time.h,
4271 since it guarantees struct timespec.
4272 (EMACS_TIME): Now struct timespec, so that we can support
4273 ns-resolution time stamps.
4274 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
4275 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
4276 (EMACS_USECS): Remove.
4277 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
4278 so multiply the arg by 1000 before storing it.
4279 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
4280 New macros.
4281 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
4282 Port to ns-resolution time stamps.
4283 (EMACS_TIME_NEG_P): Remove; replaced by....
4284 (EMACS_TIME_SIGN): New macro.
4285 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
4286 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
4287 (set_file_times, make_time, lisp_time_argument): Adjust signature.
4288 (make_timeval, make_lisp_time, decode_time_components): New decls.
4289 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
4290 that it mishandled time_t overflow. You can't compare by subtracting!
4291 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
4292 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
4293
4294 * term.c: Include <sys/time.h>.
4295 (timeval_to_Time): New function, for proper overflow wraparound.
4296 (term_mouse_position, term_mouse_click): Use it.
4297
4298 * undo.c (record_first_change): Support higher-resolution time stamps
4299 in the undo buffer.
4300 (Fprimitive_undo): Use them when restoring time stamps.
4301
4302 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
4303 (w32_get_internal_run_time):
4304 Port to higher-resolution Emacs time stamps.
4305 (ltime): Now accepts single 64-bit integer, as that's more convenient
4306 for callers.
4307
4308 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
4309
4310 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
4311 for compatibility with pselect. Support ns-resolution time stamps.
4312
4313 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
4314
4315 * xselect.c (wait_for_property_change, x_get_foreign_selection):
4316 Check for time stamp overflow, and support ns-resolution time stamps.
4317
4318 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
4319 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
4320 (timeval_subtract): Remove; no longer needed.
4321 (XTflash, XTring_bell, x_wait_for_event):
4322 Port to ns-resolution time stamps. Don't assume time_t is signed.
4323
b6a92dfe
CY
43242012-06-22 Chong Yidong <cyd@gnu.org>
4325
4326 * xdisp.c (x_consider_frame_title): Revert last change.
4327
d251c37c
EZ
43282012-06-22 Eli Zaretskii <eliz@gnu.org>
4329
4330 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
4331 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
4332 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
4333 staticidx goes up to 1597 out of 1600 = 0x640.)
4334
f10deafb
PE
43352012-06-20 Paul Eggert <eggert@cs.ucla.edu>
4336
4337 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
4338 Otherwise, the umask might be mistakenly 0 while handling input signals.
4339
ec6de1e2
SM
43402012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
4341
4342 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4343
28be1ada
DA
43442012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
4345
4346 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4347 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
4348 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
4349 access to `contents' member of Lisp_Vector objects with AREF and ASET
4350 where appropriate.
4351
c6bf3022
CY
43522012-06-19 Chong Yidong <cyd@gnu.org>
4353
4354 * frame.c (delete_frame): When selecting a frame on a different
4355 text terminal, do not alter the terminal's top-frame.
4356
4357 * xdisp.c (format_mode_line_unwind_data): Record the target
4358 frame's selected window and its terminal's top-frame.
4359 (unwind_format_mode_line): Restore them.
4360 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
4361 Callers changed.
4362 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
4363 since tty frames can be explicitly named.
4364 (prepare_menu_bars): Likewise.
4365
4366 * term.c (Ftty_top_frame): New function.
4367
defd4196
PE
43682012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4369
4370 Port byte-code-meter to modern targets.
4371 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
4372 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 4373 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
4374 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
4375 (METER_1, METER_2): Simplify.
4376
1053a871
SM
43772012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
4378
4379 * data.c (Fdefalias): Return `symbol' (bug#11686).
4380
b7e8d081
MR
43812012-06-18 Martin Rudalics <rudalics@gmx.at>
4382
4383 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
4384 gets killed during executing of this function (Bug#11665).
4385 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
4386 (Vkill_buffer_query_functions): In doc-string say that functions
4387 run by this hook should not change the current buffer.
4388
7ea2b339
PE
43892012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 Fix recently-introduced process.c problems found by static checking.
4392 * process.c (write_queue_push, write_queue_pop, send_process):
4393 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
4394 (write_queue_pop): Fix pointer signedness problem.
4395 (send_process): Remove unused local.
4396
96a313a1
CY
43972012-06-17 Chong Yidong <cyd@gnu.org>
4398
4399 * xdisp.c (redisplay_internal): No need to redisplay terminal
4400 frames that are not on top.
4401
20ca2e94
TN
44022012-06-17 Troels Nielsen <bn.troels@gmail.com>
4403
4404 * process.c (make_process): Initialize write_queue.
4405 (write_queue_push, write_queue_pop): New functions.
4406 (send_process): Use them to maintain correct ordering of process
4407 writes (Bug#10815).
4408
9a900ca9
PE
44092012-06-17 Paul Eggert <eggert@cs.ucla.edu>
4410
310fbfa8
PE
4411 * lisp.h (eassert): Assume C89 or later.
4412 This removes the need for CHECK.
4413 (CHECK): Remove. Its comments about always evaluating its
4414 argument were confusing, as 'eassert' typically does not evaluate
4415 its argument.
4416
27bb1ca4
PE
4417 * coding.c (produce_chars): Use ptrdiff_t, not int.
4418
9a900ca9
PE
4419 * xterm.c (x_draw_underwave): Check for integer overflow.
4420 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
4421
41b7f8bc 44222012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
4423
4424 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4425 referenced (Bug#11583).
4426
9b0e3eba
AA
44272012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
4428
4429 Implement wave-style variant of underlining.
4430 * dispextern.h (face_underline_type): New enum.
4431 (face): Add field for underline type.
4432 * nsterm.m (ns_draw_underwave): New function.
4433 (ns_draw_text_decoration): Use it.
4434 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
4435 New functions.
4436 (x_draw_glyph_string): Use them.
4437 * xfaces.c (Qline, Qwave): New Lisp objects.
4438 (check_lface_attrs, merge_face_ref)
1053a871
SM
4439 (Finternal_set_lisp_face_attribute, realize_x_face):
4440 Handle wave-style underline face attributes.
9b0e3eba
AA
4441 * xterm.c (x_draw_underwave): New function.
4442 (x_draw_glyph_string): Use it.
4443
0fb52f11
JB
44442012-06-16 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4447 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
4448 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
4449 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
4450 ($(BLD)/w32select.$(O)): Update dependencies.
4451
e5560ff7
AS
44522012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4453
4454 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4455 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
4456 * character.c (_fetch_multibyte_char_p): Remove.
4457 * alloc.c: Include "character.h" before "buffer.h".
4458 * bidi.c: Likewise.
4459 * buffer.c: Likewise.
4460 * bytecode.c: Likewise.
4461 * callint.c: Likewise.
4462 * callproc.c: Likewise.
4463 * casefiddle.c: Likewise.
4464 * casetab.c: Likewise.
4465 * category.c: Likewise.
4466 * cmds.c: Likewise.
4467 * coding.c: Likewise.
4468 * composite.c: Likewise.
4469 * dired.c: Likewise.
4470 * dispnew.c: Likewise.
4471 * doc.c: Likewise.
4472 * dosfns.c: Likewise.
4473 * editfns.c: Likewise.
4474 * emacs.c: Likewise.
4475 * fileio.c: Likewise.
4476 * filelock.c: Likewise.
4477 * font.c: Likewise.
4478 * fontset.c: Likewise.
4479 * fringe.c: Likewise.
4480 * indent.c: Likewise.
4481 * insdel.c: Likewise.
4482 * intervals.c: Likewise.
4483 * keyboard.c: Likewise.
4484 * keymap.c: Likewise.
4485 * lread.c: Likewise.
4486 * macros.c: Likewise.
4487 * marker.c: Likewise.
4488 * minibuf.c: Likewise.
4489 * nsfns.m: Likewise.
4490 * nsmenu.m: Likewise.
4491 * print.c: Likewise.
4492 * process.c: Likewise.
4493 * regex.c: Likewise.
4494 * region-cache.c: Likewise.
4495 * search.c: Likewise.
4496 * syntax.c: Likewise.
4497 * term.c: Likewise.
4498 * textprop.c: Likewise.
4499 * undo.c: Likewise.
4500 * unexsol.c: Likewise.
4501 * w16select.c: Likewise.
4502 * w32fns.c: Likewise.
4503 * w32menu.c: Likewise.
4504 * window.c: Likewise.
4505 * xdisp.c: Likewise.
4506 * xfns.c: Likewise.
4507 * xmenu.c: Likewise.
4508 * xml.c: Likewise.
4509 * xselect.c: Likewise.
4510
2f07e6af
EZ
45112012-06-16 Eli Zaretskii <eliz@gnu.org>
4512
1053a871
SM
4513 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4514 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4515 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4516 row.
4517 (handle_face_prop): Use chunk-relative overlay string index when
4518 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4519 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4520 the rightmost. (Bug#11720)
2f07e6af 4521
29b83cec
AS
45222012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4523
4524 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4525 (CATEGORY_MEMBER): Enforce 1/0 value.
4526 * category.c (_temp_category_set): Remove.
4527
4c5501e9
EZ
45282012-06-16 Eli Zaretskii <eliz@gnu.org>
4529
4530 * window.c (Fdelete_other_windows_internal)
4531 (Fdelete_window_internal): Don't access frame's mouse highlight
4532 info of the initial frame. (Bug#11677)
4533
2b570124
PE
45342012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4535
e93864f9
PE
4536 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4537 Assume USE_2_TAGS_FOR_INTS.
4538 (xreload): Adjust $tagmask width to match recent lisp.h change.
4539
2b570124
PE
4540 Simplify lisp.h in minor ways that should not affect code.
4541 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4542 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4543 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4544 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4545 (INTTYPEBITS): New macro, for clarity.
4546 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4547 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4548 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4549 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4550 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4551
81755f69
JB
45522012-06-13 Juanma Barranquero <lekktu@gmail.com>
4553
4554 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4555
16192a57
GM
45562012-06-13 Glenn Morris <rgm@gnu.org>
4557
4558 * s/bsd-common.h (BSD4_3):
4559 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4560
646b5f55
AS
45612012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4562
4563 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4564 instead of union.
4565 (XLI, XIL): Define.
1053a871
SM
4566 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4567 Use them.
4568 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4569 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4570 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4571 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4572 * frame.c (delete_frame): Remove outdated comment.
4573 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4574 USE_LISP_UNION_TYPE.
4575 (Fw32_unregister_hot_key): Likewise.
4576 (Fw32_toggle_lock_key): Likewise.
4577 * w32menu.c (add_menu_item): Likewise.
4578 (w32_menu_display_help): Use XIL instead of checking
4579 USE_LISP_UNION_TYPE.
4580 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4581 (init_heap): Likewise.
4582 * w32term.c (w32_read_socket): Update comment.
4583
1d3823c9
GM
45842012-06-13 Glenn Morris <rgm@gnu.org>
4585
c62ff706
GM
4586 * s/usg5-4-common.h, src/s/unixware.h:
4587 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4588
1d3823c9
GM
4589 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4590
bfe3e0a2
PE
45912012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4594 * alloc.c (make_number) [!defined make_number]:
4595 Remove, as lisp.h always defines this now.
4596 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4597 (roundup_size): Verify that it is a power of 2.
4598 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4599 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4600 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4601 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4602 USE_LSB_TAG now is always defined to be either 0 or 1.
4603 All uses changed.
4604 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4605 code works fine either way, and efficiency is not a concern here,
4606 as the union type is for debugging, not for production.
4607 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4608 Use an inline function on all platforms when using the union type,
4609 since this is simpler and 'static inline' can be used portably
4610 within Emacs now.
4611 (LISP_INITIALLY_ZERO): New macro.
4612 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4613 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4614
45fa9c0f
GM
46152012-06-12 Glenn Morris <rgm@gnu.org>
4616
b4492cba
GM
4617 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4618
4619 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4620
45fa9c0f
GM
4621 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4622 Move BROKEN_SIGIO to configure.
4623
4624 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4625 Move NO_TERMIO to configure.
4626
0e25d334
CY
46272012-06-12 Chong Yidong <cyd@gnu.org>
4628
4629 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4630 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4631 MagickExportImagePixels is undefined.
4632
43682bb6
PE
46332012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 * image.c (imagemagick_load_image): Remove unused label.
4636
a9be7d2b
GM
46372012-06-11 Glenn Morris <rgm@gnu.org>
4638
4639 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4640 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4641 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4642 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4643
3017f87f
SM
46442012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4645
4646 * alloc.c (make_byte_code): New function.
4647 (Fmake_byte_code): Use it. Don't purify here.
4648 * lread.c (read1): Use it as well to avoid extra allocation.
4649
1b9b4cf4
CY
46502012-06-11 Chong Yidong <cyd@gnu.org>
4651
4652 * image.c (imagemagick_load_image): Implement transparency.
4653
95988fcf
AS
46542012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4655
4656 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4657 account for preceding backslashes. (Bug#11663)
4658
cd4eb164
CY
46592012-06-09 Chong Yidong <cyd@gnu.org>
4660
4661 * term.c: Support italics in capable terminals (Bug#9652).
4662 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4663 (turn_on_face): Output using TS_enter_italic_mode if available.
4664 Don't handle unused blinking and alt-charset cases.
4665 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4666 and tty_alt_charset_p cases.
4667 (tty_capable_p, init_tty): Support italics.
4668
4669 * termchar.h (struct tty_display_info): Add field for italics.
4670 Remove unused blink field.
4671
4672 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4673 Handle slant.
4674
4675 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4676 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4677 tty_alt_charset_p. Add tty_italic_p.
4678
ff88beb8
MA
46792012-06-09 Michael Albinus <michael.albinus@gmx.de>
4680
4681 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4682 dbus_type_is_basic if available.
4683 (xd_extract_signed, xd_extract_unsigned): Rename from
4684 extract_signed and extract_unsigned, respectively. Adapt callers.
4685
44286096
CY
46862012-06-09 Chong Yidong <cyd@gnu.org>
4687
1682701f
CY
4688 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4689
44286096
CY
4690 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4691 case (Bug#9752).
4692
d86feb17
PE
46932012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 * xdisp.c (vmessage): Treat frame message as multibyte.
4696 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4697 would generate the diagnostic "Making \302\247 buffer-local while
4698 let-bound!".
4699
d5c20fe8
EZ
47002012-06-08 Eli Zaretskii <eliz@gnu.org>
4701
4702 * dispnew.c (showing_window_margins_p): Undo last change, which
4703 was done due to an inadvertent commit.
4704 (adjust_frame_glyphs_for_frame_redisplay): Do call
4705 showing_window_margins_p.
4706
513749ee
SM
47072012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4708
4709 * eval.c (Fmake_var_non_special): New primitive.
4710 (syms_of_eval): Defsubr it.
4711 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4712
d4a8f5c1
JB
47132012-06-08 Juanma Barranquero <lekktu@gmail.com>
4714
4715 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4716 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4717
8bbbc977
EZ
47182012-06-08 Eli Zaretskii <eliz@gnu.org>
4719
4720 * alloc.c (allocate_vectorlike): Fix last change.
4721
f3372c87
DA
47222012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4723
4724 Block-based vector allocation of small vectors.
4725 * lisp.h (struct vectorlike_header): New field `nbytes',
4726 adjust comment accordingly.
4727 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4728 to denote vector blocks. Adjust users (live_vector_p,
4729 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4730 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4731 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4732 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4733 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4734 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4735 (roundup_size): New constant.
4736 (struct vector_block): New data type.
4737 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4738 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4739 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4740 (sweep_vectors): New functions.
4741 (allocate_vectorlike): Return `zero_vector' as the only vector of
4742 0 items. Allocate new vector from block if vector size is less than
4743 or equal to VBLOCK_BYTES_MAX.
4744 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4745 (init_alloc_once): Add call to init_vectors.
4746
4f18a4ed
SM
47472012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4748
4749 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4750
86f158bc
PE
47512012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * doprnt.c (doprnt): Truncate multibyte char correctly.
4754 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4755 would mishandle a string argument "Xc" if X was a multibyte
4756 character of length 2: it would truncate after X's first byte
4757 rather than including all of X.
4758
c5cfcbe0
CY
47592012-06-06 Chong Yidong <cyd@gnu.org>
4760
4761 * buffer.c (word_wrap): Doc fix.
4762
c05cf390
PE
47632012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4766
0c3461de
GM
47672012-06-03 Glenn Morris <rgm@gnu.org>
4768
4769 * xdisp.c (tool-bar-style): Doc fix.
4770
c71232db
UM
47712012-06-03 Ulrich Müller <ulm@gentoo.org>
4772
4773 * Makefile.in (PAXCTL): Define.
4774 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4775 binary via PaX flags if the paxctl utility is available.
4776 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4777 Restore PaX flags to their default. (Bug#11398)
4778
383f7350
CY
47792012-06-03 Chong Yidong <cyd@gnu.org>
4780
4781 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4782 buffer (Bug#11226).
4783
5f2c76c6
CY
47842012-06-03 Chong Yidong <cyd@gnu.org>
4785
4786 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4787 (note_mode_line_or_margin_highlight): If there is no help echo,
4788 use mode-line-default-help-echo. Handle the case where the mouse
4789 position is past the end of the mode line string.
4790
4791 * buffer.c (buffer_local_value_1): New function, split from
4792 Fbuffer_local_value; can return Qunbound.
4793 (Fbuffer_local_value): Use it.
4794 (Vmode_line_format): Docstring tweaks.
4795
773d47f6
PE
47962012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4797
4798 * sysdep.c (system_process_attributes): Improve comment.
4799
f2d6a3df
SM
48002012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4801
4802 * keyboard.c: Export real-this-command to Elisp.
4803 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4804 and DEFVAR it. Update all users.
4805
63810350
PE
48062012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4807
7bd5c1f4
PE
4808 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4809
63810350
PE
4810 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4811 Convert pctcpu and pctmem to Lisp float properly.
4812 Let the compiler fold better, as 100.0/0x8000 is exact.
4813
a2821611
AS
48142012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4815
4816 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4817 cons_block.
4818
5fceba1d
PE
48192012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4822
c98ff5dd
DA
48232012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4824
4825 For a 'struct window', replace some Lisp_Object fields to
4826 bitfields where appropriate, remove unused fields.
4827 * window.h (struct window): Remove unused 'last_mark_x' and
4828 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4829 change it's type from Lisp_Object to bitfield.
4830 Change type of 'force_start', 'optional_new_start',
4831 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4832 fields from Lisp_Object to bitfield. Adjust users accordingly.
4833
ca34e0be
PE
48342012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 Pacify gcc -Wdouble-precision when using Xaw.
4837 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4838 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4839 Use 'float' consistently, rather than 'float' in most places
4840 and 'double' in a couple of places.
4841
efc00ab1 48422012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4843
4844 * xdisp.c (handle_stop): Detect whether we have overlay strings
4845 loaded by testing it->current.overlay_string_index to be
4846 non-negative, instead of checking whether n_overlay_strings is
4847 positive. (Bug#11587)
4848
efc00ab1 48492012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4850
4851 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4852
4853 * doc.c (Fsubstitute_command_keys): Doc fix.
4854
efc00ab1 48552012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4856
4857 * search.c (search_buffer): Remove calls to
4858 r_alloc_inhibit_buffer_relocation, as it is now called by
4859 maybe_unify_char, which was the cause of relocation of buffer text
4860 in bug#11519.
4861
efc00ab1 48622012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4863
4864 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4865 for the duration of call to load_charset, to avoid problems with
4866 callers of maybe_unify_char that access buffer text through C
4867 pointers.
4868
4869 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4870 decrement the inhibition flag, instead of just setting or
4871 resetting it.
4872
ba93a187
PE
48732012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4874
4875 Remove obsolete '#define static' cruft.
4876 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4877 This #undef was "temporary" in 2000; it is no longer needed
4878 now that '#define static' has gone away.
4879 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4880 (gray_bitmap_bits): Remove; no longer needed.
4881 All uses replaced with definiens.
4882 * xterm.c: Include "bitmaps/gray.xbm".
4883
9e4bf381
PE
48842012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4885
4886 Clean up __executable_start, monstartup when --enable-profiling.
4887 The following changes affect the code only when profiling.
4888 * dispnew.c (__executable_start): Rename from safe_bcopy.
4889 Define only on platforms that need it.
4890 * emacs.c: Include <sys/gmon.h> when profiling.
4891 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4892 (__executable_start): Remove decl, since lisp.h does it now.
4893 (safe_bcopy): Remove decl; no longer has that name.
4894 (main): Coalesce #if into single bit of code, for simplicity.
4895 Cast pointers to uintptr_t, since standard libraries want integers
4896 and not pointers.
4897 * lisp.h (__executable_start): New decl.
4898
32d72c2f
GM
48992012-05-31 Glenn Morris <rgm@gnu.org>
4900
4901 * image.c (Fimagemagick_types): Doc fix.
4902
baac5bc7
JM
49032012-05-30 Jim Meyering <meyering@redhat.com>
4904
4905 * callproc.c (Fcall_process_region): Include directory component
4906 in mkstemp error message (Bug#11586).
4907
72cb32cf
PE
49082012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4909
4910 * alloc.c, lisp.h (make_pure_vector): Now static.
4911
61b108cc
SM
49122012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4913
4914 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4915 Move to byte-run.el.
4916 (Fautoload): Do the hash-doc more carefully.
4917 * data.c (Fdefalias): Purify definition, except for keymaps.
4918 (Qdefun): Move from eval.c.
4919 * lisp.h (Qdefun): Remove.
4920 * lread.c (read1): Tiny simplification.
4921
471fe23d
TN
49222012-05-29 Troels Nielsen <bn.troels@gmail.com>
4923
934f3f58 4924 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4925 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4926 Bug#9642, but explicitly check that the buffer the overlay would
4927 be moved to is live and rearrange lines to make sure that errors
4928 will not put the overlay in an inconsistent state.
4929 (Fdelete_overlay): Cosmetics.
4930
85d0efd1
EZ
49312012-05-28 Eli Zaretskii <eliz@gnu.org>
4932
4933 * w32term.c (my_bring_window_to_top): New function.
4934 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4935 could be different from the original one.
4936 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4937 (Bug#11513)
4938
4939 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4940 by calling BringWindowToTop.
4941
4942 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4943 (WM_EMACS_END): Increase by one.
4944
da92a98c
PE
49452012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4946
4947 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4948 This avoids undefined behavior that might cause the eassert
4949 to not catch an out-of-range value.
4950
74d1f848
JB
49512012-05-28 Juanma Barranquero <lekktu@gmail.com>
4952
4953 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4954 Update dependencies.
4955
9e1a06fc
EZ
49562012-05-27 Eli Zaretskii <eliz@gnu.org>
4957
4958 * bidi.c (bidi_mirror_char): Fix last change.
4959
f3dd7312
AS
49602012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4961
4962 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4963 when referring to sectname field in printf format.
4964
81899c91
PE
49652012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4966
57b81a9f
PE
4967 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4968 Only r_alloc_inhibit_buffer_relocation needed to be added;
4969 the others were already declared.
4970
81899c91
PE
4971 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4972 before checking whether it's out of range. Put the check inside
4973 eassert. See
4974 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4975
33017faf 49762012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4977
4978 * callproc.c (Fcall_process): Restore a line that was accidentally
4979 commented out in the 2011-02-13 change (bug#11547).
4980
33017faf 49812012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4982
4983 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4984 defined on ralloc.c.
4985
4986 * buffer.c [REL_ALLOC]: Remove prototypes of
4987 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4988 they are now on lisp.h.
4989
4990 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4991
4992 * search.c (search_buffer): Use it to inhibit relocation of buffer
4993 text while re_search_2 is doing its job, because re_search_2 is
4994 passed C pointers to buffer text. (Bug#11519)
4995
23415acf
EZ
4996 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4997 Update value to 24.
4998
44e27368
EZ
4999 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5000 state after an additional call to move_it_in_display_line_to, keep
5001 the values of it->max_ascent and it->max_descent found for the
5002 entire line.
5003 (pos_visible_p): Revert the comparison against bottom_y to what it
5004 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5005 (Bug#11464)
5006
c1892f11
PE
50072012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5008
5009 Fix coding-related core dumps with gcc -ftrapv.
5010 The code was computing A - B, where A and B are pointers, and B is
5011 random garbage. This can lead to core dumps on platforms that
5012 have special pointer registers, and it also leads to core dumps on
5013 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5014 A - B only when B is initialized properly.
5015 * coding.c (coding_set_source, coding_set_destination): Return void.
5016 (coding_change_source, coding_change_destinations): New functions,
5017 with the old behaviors of coding_set_source and coding_set_destination.
5018 All callers that need an offset changed to use these new functions.
5019
eb7afdad
GM
50202012-05-26 Glenn Morris <rgm@gnu.org>
5021
5022 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5023
f12fdf02
EZ
50242012-05-26 Eli Zaretskii <eliz@gnu.org>
5025
53a63be6 5026 Extend mouse support on W32 text-mode console.
61b108cc
SM
5027 * xdisp.c (draw_row_with_mouse_face):
5028 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5029
eb3f6f01 5030 * w32console.c: Include window.h.
61b108cc
SM
5031 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5032 New functions.
eb3f6f01
EZ
5033 (initialize_w32_display): Initialize mouse-highlight data.
5034
53a63be6
EZ
5035 * w32inevt.c: Include termchar.h and window.h.
5036 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5037 moves, call note_mouse_highlight. If help_echo changed, call
5038 gen_help_event to produce help-echo message in the echo area.
5039 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5040 highlight info.
5041
4cfd81f6
PE
50422012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5043
5044 * lread.c (read1): Simplify slightly to avoid an overflow warning
5045 with GCC 4.7.0 on x86-64.
5046
4446092a
EZ
50472012-05-26 Eli Zaretskii <eliz@gnu.org>
5048
5049 * bidi.c (bidi_mirror_char): Revert last change: an int is
5050 definitely wide enough here.
5051
42b2a986 50522012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5053
42b2a986 5054 Fix integer width and related bugs (Bug#9874).
eb106a49 5055 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5056 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5057 (string_bytes, check_sblock, allocate_string_data):
5058 (compact_small_strings, Fmake_bool_vector, make_string)
5059 (make_unibyte_string, make_multibyte_string)
5060 (make_string_from_bytes, make_specified_string)
5061 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5062 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5063 (mark_vectorlike):
5064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5065 (allocate_pseudovector):
5066 Use int, not EMACS_INT, where int is wide enough.
5067 (inhibit_garbage_collection, Fgarbage_collect):
5068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5069 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5070 int might not be wide enough.
5071 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5072 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5073 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5074 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5075 (bidi_level_of_next_char, bidi_move_to_visually_next):
5076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5077 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5078 (Fkill_buffer, Fset_buffer_major_mode)
5079 (advance_to_char_boundary, Fbuffer_swap_text)
5080 (Fset_buffer_multibyte, overlays_at, overlays_in)
5081 (overlay_touches_p, struct sortvec, record_overlay_string)
5082 (overlay_strings, recenter_overlay_lists)
5083 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5084 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5085 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5086 (Foverlay_recenter, last_overlay_modification_hooks_used)
5087 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5089 (validate_region): Omit unnecessary test for b <= e,
5090 since that's guaranteed by the previous test.
d311d28c
PE
5091 (adjust_overlays_for_delete): Avoid pos + length overflow.
5092 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5093 (report_overlay_modification):
5094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5095 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5096 Omit pointer cast, which isn't needed anyway, and doesn't work
5097 after the EMACS_INT -> ptrdiff_t change.
02481186 5098 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5099 * buffer.h: Adjust decls to match defn changes elsewhere.
5100 (struct buffer_text, struct buffer):
5101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5102 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5103 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5104 not int, to avoid needless 32-bit limit on 64-bit hosts.
5105 (exec_byte_code): Use tighter memory-full test, one that checks
5106 for alloca overflow. Don't compute the address of the object just
5107 before an array, as that's not portable. Use EMACS_INT, not
5108 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5109 * callint.c (Fcall_interactively):
5110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5111 * callproc.c (call_process_kill, Fcall_process):
5112 Don't assume pid_t fits into an Emacs fixnum.
5113 (call_process_cleanup, Fcall_process, child_setup):
5114 Don't assume pid_t fits into int.
5115 (call_process_cleanup, Fcall_process, delete_temp_file)
5116 (Fcall_process_region):
5117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5118 (Fcall_process): Simplify handling of volatile integers.
5119 Use int, not EMACS_INT, where int will do.
5120 * casefiddle.c (casify_object, casify_region, operate_on_word)
5121 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
5122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5123 (casify_object): Avoid integer overflow when overallocating buffer.
5124 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5125 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5126 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5127 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5128 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5129 integers are now checked earlier. All uses replaced with XINT.
5130 (ccl_driver):
5131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5132 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5133 (ccl_driver, Fregister_code_conversion_map):
5134 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5135 (resolve_symbol_ccl_program): Check that vector header is in range.
5136 Always copy the vector, so that we can check its contents reliably
5137 now rather than having to recheck each instruction as it's being
5138 executed. Check that vector words fit in 'int'.
5139 (ccl_get_compiled_code, Fregister_ccl_program)
5140 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5141 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5142 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5143 contents are in range.
5144 (Fccl_execute_on_string): Check that status is in range.
5145 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5146 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5147 Accept and return EMACS_INT, not int, because callers can pass values
5148 out of 'int' range.
5149 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5150 (multibyte_chars_in_text, parse_str_as_multibyte)
5151 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5152 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5153 (string_escape_byte8, Fget_byte):
5154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5155 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5156 avoid mishandling large integers.
5157 * character.h: Adjust decls to match defn changes elsewhere.
5158 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5159 (Ffind_charset_region):
5160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5161 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5162 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5163 Don't assume fixnum fits in int.
d311d28c
PE
5164 (load_charset_map_from_vector, Fmap_charset_chars):
5165 Remove now-unnecessary CHECK_NATNUMs.
5166 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5167 Don't rely on undefined behavior with signed left shift overflow.
5168 Don't assume unsigned int fits into fixnum, or that fixnum fits
5169 into unsigned int. Don't require max_code to be a valid fixnum;
5170 that's not true for gb10830 4-byte on a 32-bit host. Allow
5171 invalid_code to be a cons, for the same reason. Require code_offset
5172 to be a character. Avoid int overflow if max_char is close
5173 to INT_MAX.
5174 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5175 this is intended anyway and avoids some undefined behavior.
5176 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5177 INDEX_TO_CODE_POINT, as that's what it expects.
5178 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5179 * charset.h (DECODE_CHAR): Return int, not unsigned;
5180 this is what was intended anyway, and it avoids undefined behavior.
5181 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5182 integer-overflow issues.
5183 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5184 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5185 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5186 * chartab.c (Fmake_char_table, Fset_char_table_range)
5187 (uniprop_get_decoder, uniprop_get_encoder):
5188 Don't assume fixnum fits in int.
5189 * cmds.c (move_point): New function, that does the gist of
5190 Fforward_char and Fbackward_char, but does so while checking
5191 for integer overflow more accurately.
c96e5d6a 5192 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5193 (Fforward_line, Fend_of_line, internal_self_insert)
5194 (internal_self_insert):
5195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5196 Fix a FIXME, by checking for integer overflow when calculating
5197 target_clm and actual_clm.
5198 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5199 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5200 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5201 (coding_alloc_by_making_gap, alloc_destination)
5202 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5203 (encode_coding_utf_16, detect_coding_emacs_mule)
5204 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5205 (detect_coding_iso_2022, decode_coding_iso_2022)
5206 (encode_invocation_designation, encode_designation_at_bol)
5207 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5208 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5209 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5210 (encode_coding_ccl, encode_coding_raw_text)
5211 (detect_coding_charset, decode_coding_charset)
5212 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
5213 (produce_composition, produce_charset, produce_annotation)
5214 (decode_coding, handle_composition_annotation)
5215 (handle_charset_annotation, consume_chars, decode_coding_gap)
5216 (decode_coding_object, encode_coding_object, detect_coding_system)
5217 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
5218 (code_convert_region, code_convert_string)
8f50130c
PE
5219 (Fdefine_coding_system_internal)
5220 (coding_set_source, coding_set_destination):
d311d28c
PE
5221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5222 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
5223 (Fdefine_coding_system_internal):
5224 Don't assume fixnums fit in int.
5225 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 5226 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
5227 (Funencodable_char_position, Fcheck_coding_systems_region)
5228 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 5229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 5230 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 5231 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 5232 Don't access memory outside of the args array.
d311d28c 5233 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
5234 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
5235 result of ENCODE_CHAR.
d311d28c
PE
5236 * coding.h: Adjust decls to match defn changes elsewhere.
5237 (struct coding_system):
5238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5239 * composite.c (get_composition_id, find_composition)
5240 (run_composition_function, update_compositions)
5241 (compose_text, composition_gstring_put_cache)
5242 (composition_gstring_p, composition_gstring_width)
5243 (fill_gstring_header, fill_gstring_body, autocmp_chars)
5244 (composition_compute_stop_pos, composition_reseat_it)
5245 (composition_update_it, struct position_record)
5246 (find_automatic_composition, composition_adjust_point)
5247 (Fcomposition_get_gstring, Ffind_composition_internal):
5248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5249 (update_compositions):
5250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5251 * composite.h: Adjust decls to match defn changes elsewhere.
5252 (struct composition):
5253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5254 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5255 Do not attempt to compute the address of the object just before a
5256 buffer; this is not portable.
5257 (Faref, Faset):
5258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5259 (Faset): Use int, not EMACS_INT, where int is wide enough.
5260 (Fstring_to_number): Don't assume fixnums fit in int.
5261 (Frem): Don't assume arg is nonnegative.
5262 * dbusbind.c (xd_append_arg): Check for integers out of range.
5263 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 5264 (extract_signed, extract_unsigned): New functions.
243e0530
PE
5265 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
5266 (xd_get_connection_references): Return ptrdiff_t, not int.
5267 All uses changed.
5268 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
5269 (xd_read_message_1):
5270 Use int, not unsigned, where the dbus API uses int.
5271 (Fdbus_message_internal): Don't overflow mtype.
5272 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
5273 * dired.c (directory_files_internal, file_name_completion, scmp)
5274 (file_name_completion_stat):
5275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5276 (file_name_completion): Don't overflow matchcount.
5277 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
5278 * dispextern.h: Adjust decls to match defn changes elsewhere.
5279 (struct text_pos, struct glyph, struct bidi_saved_info)
5280 (struct bidi_string_data, struct bidi_it, struct composition_it)
5281 (struct it):
5282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5283 (struct display_pos, struct composition_it, struct it):
5284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5285 * dispnew.c (increment_matrix_positions)
5286 (increment_row_positions, mode_line_string)
5287 (marginal_area_string):
5288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 5289 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
5290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5291 (duration_to_sec_usec): New function, to check for overflow better.
5292 (Fsleep_for, sit_for): Use it.
5293 * doc.c (get_doc_string, store_function_docstring):
5294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5295 (get_doc_string, Fsnarf_documentation):
5296 Use int, not EMACS_INT, where int is wide enough.
5297 (get_doc_string):
5298 Use SAFE_ALLOCA, not alloca.
5299 Check for overflow when converting EMACS_INT to off_t.
5300 * doprnt.c (doprnt):
5301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5302 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
5303 Don't assume uid_t fits into fixnum.
5304 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
5305 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
5306 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
5307 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
5308 (general_insert_function)
5309 (Finsert_char, make_buffer_string, make_buffer_string_both)
5310 (update_buffer_properties, Fbuffer_substring)
5311 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
5312 (Fsubst_char_in_region, check_translation)
5313 (Ftranslate_region_internal, save_restriction_restore, Fformat)
5314 (transpose_markers, Ftranspose_regions):
5315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5316 (clip_to_bounds): Move to lisp.h as an inline function).
5317 (Fconstrain_to_field): Don't assume integers are nonnegative.
5318 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
5319 (Fsubst_char_in_region, Fsave_restriction):
5320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5321 (Femacs_pid): Don't assume pid_t fits into fixnum.
5322 (lo_time): Use int, not EMACS_INT, when int suffices.
5323 (lisp_time_argument): Check for usec out of range.
5324 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
5325 (Fuser_login_name, Fuser_full_name): Signal an error
5326 if a uid argument is out of range, rather than relying on
5327 undefined behavior.
c8d5c857
PE
5328 (Fformat_time_string): Remove now-unnecessary check.
5329 lisp_time_argument checks for out-of-range usec now.
243e0530 5330 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
5331 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
5332 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
5333 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
5334 (init_cmdargs, Fdump_emacs):
5335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5336 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
5337 the bottom (typically) 32 bits of the fixnum.
5338 * eval.c (specpdl_size, call_debugger):
5339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5340 (when_entered_debugger, Fbacktrace_debug):
5341 Don't assume fixnum can fit in int.
5342 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
5343 the object just before a buffer; this is not portable.
5344 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
5345 (grow_specpdl, unbind_to):
5346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5347 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
5348 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 5349 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
5350 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
5351 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
5352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5353 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
5354 (a_write, e_write):
5355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5356 (Fcopy_file, non_regular_nbytes, read_non_regular)
5357 (Finsert_file_contents):
5358 Use int, not EMACS_INT, where int is wide enough.
5359 (READ_BUF_SIZE): Verify that it fits in int.
5360 (Finsert_file_contents): Check that counts are in proper range,
5361 rather than assuming fixnums fit into ptrdiff_t etc.
5362 Don't assume fixnums fit into int.
125b3835 5363 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
5364 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
5365 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
5366 (string_char_to_byte, string_byte_to_char)
5367 (string_make_multibyte, string_to_multibyte)
5368 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
5369 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
5370 (substring_both, Fdelete, internal_equal, Ffillarray)
5371 (Fclear_string, mapcar1)
5372 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
5373 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
5374 (larger_vector, make_hash_table, maybe_resize_hash_table)
5375 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
5376 (Fmaphash, secure_hash):
5377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5378 (concat): Check for string index and length overflow.
5379 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
5380 (Frequire):
5381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5382 (larger_vector): New API (vec, incr_min, size_max) replaces old
5383 one (vec, new_size, init). This catches size overflow.
5384 INIT was removed because it was always Qnil.
5385 All callers changed.
5386 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
5387 the upper bound on a hash table index size.
5388 (make_hash_table, maybe_resize_hash_table): Use it.
5389 (secure_hash): Computer start_byte and end_byte only after
5390 they're known to be in ptrdiff_t range.
5391 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
5392 (Ffont_get_glyphs, Ffont_at):
5393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5394 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
5395 (Flist_fonts, Fopen_font):
5396 Don't assume fixnum can fit in int.
5397 (check_gstring): Don't assume index can fit in int.
5398 (font_match_p): Check that fixnum is a character, not a nonnegative
5399 fixnum, since the later code needs to stuff it into an int.
5400 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
5401 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
5402 conversion overflow issues.
5403 (Fopen_font): Check for integer out of range.
5404 (Ffont_get_glyphs): Don't assume index can fit in int.
5405 * font.h: Adjust decls to match defn changes elsewhere.
5406 * fontset.c (reorder_font_vector): Redo score calculation to avoid
5407 integer overflow.
5408 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
5409 printmax_t, where ptrdiff_t is wide enough.
5410 (Finternal_char_font):
5411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5412 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
5413 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
5414 (Fset_frame_position, x_set_frame_parameters)
5415 (x_set_line_spacing, x_set_border_width)
5416 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
5417 Check that fixnums are in proper range for system types.
5418 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
5419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5420 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
5421 Use SAFE_ALLOCA_LISP, not alloca.
5422 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
5423 intptr_t is wide enough.
5424 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
5425 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
5426 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
5427 Check for fixnum out of range.
5428 * ftfont.c (ftfont_list): Don't assume index fits in int.
5429 Check that fixnums are in proper range for system types.
5430 (ftfont_shape_by_flt):
5431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
5432 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5434 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
5435 Check that fixnums are in proper range for system types.
5436 * gnutls.h: Adjust decls to match defn changes elsewhere.
5437 * gtkutil.c (xg_dialog_run):
5438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5439 (update_frame_tool_bar):
5440 Check that fixnums are in proper range for system types.
5441 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 5442 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
5443 * indent.c (last_known_column, last_known_column_point):
5444 (current_column_bol_cache):
5445 (skip_invisible, current_column, check_display_width):
5446 (check_display_width, scan_for_column, current_column_1)
5447 (Findent_to, Fcurrent_indentation, position_indentation)
5448 (indented_beyond_p, Fmove_to_column, compute_motion):
5449 (Fcompute_motion, Fvertical_motion):
5450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5451 (last_known_column_modified): Use EMACS_INT, not int.
5452 (check_display_width):
5453 (Fcompute_motion):
5454 Check that fixnums and floats are in proper range for system types.
5455 (compute_motion): Don't assume index or fixnum fits in int.
5456 (compute_motion, Fcompute_motion):
5457 Use int, not EMACS_INT, when it is wide enough.
5458 (vmotion): Omit local var start_hpos that is always 0; that way
5459 we don't need to worry about overflow in expressions involving it.
5460 * indent.h: Adjust decls to match defn changes elsewhere.
5461 (struct position):
5462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5463 Use int, not EMACS_INT, where int is wide enough.
5464 Remove unused members ovstring_chars_done and tab_offset;
5465 all uses removed.
5466 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
5467 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
5468 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
5469 (make_gap, copy_text, insert, insert_and_inherit)
5470 (insert_before_markers, insert_before_markers_and_inherit)
5471 (insert_1, count_combining_before, count_combining_after)
5472 (insert_1_both, insert_from_string)
5473 (insert_from_string_before_markers, insert_from_string_1)
5474 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
5475 (adjust_after_replace, adjust_after_insert, replace_range)
5476 (replace_range_2, del_range, del_range_1, del_range_byte)
5477 (del_range_both, del_range_2, modify_region)
5478 (prepare_to_modify_buffer, signal_before_change)
5479 (signal_after_change, Fcombine_after_change_execute):
5480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5481 * intervals.c (traverse_intervals, rotate_right, rotate_left)
5482 (balance_an_interval, split_interval_right, split_interval_left)
5483 (find_interval, next_interval, update_interval)
5484 (adjust_intervals_for_insertion, delete_node, delete_interval)
5485 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5486 (static_offset_intervals, offset_intervals)
5487 (merge_interval_right, merge_interval_left, make_new_interval)
5488 (graft_intervals_into_buffer, temp_set_point_both)
5489 (temp_set_point, set_point, adjust_for_invis_intang)
5490 (set_point_both, move_if_not_intangible, get_property_and_range)
5491 (get_local_map, copy_intervals, copy_intervals_to_string)
5492 (compare_string_intervals, set_intervals_multibyte_1):
5493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5494 * intervals.h: Adjust decls to match defn changes elsewhere.
5495 (struct interval):
5496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5497 * keyboard.c (this_command_key_count, this_single_command_key_start)
5498 (before_command_key_count, before_command_echo_length, echo_now)
5499 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5500 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5501 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5502 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5504 (last_non_minibuf_size, last_point_position, echo_truncate)
5505 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5506 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5507 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5508 (stuff_buffered_input):
5509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5510 (last_auto_save, command_loop_1, read_char):
5511 Use EMACS_INT, not int, to avoid integer overflow.
5512 (record_char): Avoid overflow in total_keys computation.
5513 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5514 * keyboard.h: Adjust decls to match defn changes elsewhere.
5515 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5516 (Fkey_description, Fdescribe_vector, Flookup_key):
5517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5518 (click_position): New function, to check that positions are in range.
5519 (Fcurrent_active_maps):
5520 (describe_command):
5521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5522 (Faccessible_keymaps, Fkey_description):
5523 (preferred_sequence_p):
5524 Don't assume fixnum can fit into int.
5525 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5526 Check for integer overflow in size calculations.
5527 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5528 avoid mishandling large integers.
5529 * lisp.h: Adjust decls to match defn changes elsewhere.
5530 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5531 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5532 (struct Lisp_Marker):
5533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5534 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5535 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5536 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5537 All callers changed.
5538 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5539 Assume the arg has valid form, since it always does.
5540 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5541 unsigned integer system type.
5542 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5543 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5545 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5546 (duration_to_sec_usec): New decl.
5547 * lread.c (read_from_string_index, read_from_string_index_byte)
5548 (read_from_string_limit, readchar, unreadchar, openp)
5549 (read_internal_start, read1, oblookup):
5550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5551 (Fload, readevalloop, Feval_buffer, Feval_region):
5552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5553 (openp): Check for out-of-range argument to 'access'.
5554 (read1): Use int, not EMACS_INT, where int is wide enough.
5555 Don't assume fixnum fits into int.
6efdadfd 5556 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5557 (read_filtered_event): Use duration_to_sec_usec
5558 to do proper overflow checking on durations.
d311d28c
PE
5559 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5560 in size calculation.
5561 (Fexecute_kbd_macro):
5562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5563 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5564 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5565 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5566 (set_marker_both, set_marker_restricted_both, marker_position)
5567 (marker_byte_position, Fbuffer_has_markers_at):
5568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5569 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5570 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5571 It now merely ensures that the menu is large enough, without
5572 necessarily growing it, as this avoids some integer overflow issues.
5573 All callers changed.
5574 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5576 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5577 Use SAFE_ALLOCA_LISP, not alloca.
5578 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5579 to EMACS_INT. Check that fixnums are in proper range for system types.
5580 * minibuf.c (minibuf_prompt_width, string_to_object)
5581 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5582 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5584 (get_minibuffer, read_minibuf_unwind):
5585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5586 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5587 this simplifies overflow checking. All callers changed.
5588 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5589 (Ftest_completion):
5590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5591 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5592 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5593 Check that fixnums are in proper range for system types.
5594 (Fx_create_frame, Fx_show_tip):
5595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5596 * nsfont.m (ns_findfonts, nsfont_list_family):
5597 Don't assume fixnum fits in long.
5598 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5600 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5601 wide enough.
17fdb222 5602 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5604 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5605 (PRINTDECLARE, PRINTPREPARE):
5606 (strout, print_string):
5607 (print, print_preprocess, print_check_string_charset_prop)
5608 (print_object):
5609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5610 (PRINTDECLARE):
5611 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5613 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5614 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5615 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5616 (print_error_message): Use SAFE_ALLOCA, not alloca.
5617 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5618 (print_depth, new_backquote_output, print_number_index):
5619 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5620 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5621 (Fset_process_window_size, Fformat_network_address)
5622 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5623 (sigchld_handler):
d311d28c 5624 Check that fixnums are in proper range for system types.
d44287d4 5625 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5626 Check for process-ids out of pid_t range rather than relying on
5627 undefined behavior.
e4d81efc 5628 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5629 (Fformat_network_address, read_process_output, send_process)
5630 (Fprocess_send_region, status_notify):
5631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5632 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5633 (wait_reading_process_output, read_process_output, exec_sentinel):
5634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5635 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5636 (Faccept_process_output): Use duration_to_sec_usec to do proper
5637 overflow checking on durations.
dde14581
PE
5638 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5639 Don't assume pid_t fits in int.
02481186
PE
5640 * process.h (struct Lisp_Process): Members tick and update_tick
5641 are now of type EMACS_INT, not int.
b62b53e8
PE
5642 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5643 configured --with-wide-int.
d311d28c
PE
5644 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5645 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5646 * search.c (looking_at_1, string_match_1):
5647 (fast_string_match, fast_c_string_match_ignore_case)
5648 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5649 (scan_newline, find_before_next_newline, search_command)
5650 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5651 (set_search_regs, wordify):
5652 (Freplace_match):
5653 (Fmatch_data):
5654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5655 (string_match_1, search_buffer, set_search_regs):
5656 (Fmatch_data):
5657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5658 (wordify): Check for overflow in size calculation.
5659 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5660 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5661 Check that fixnums are in proper range for system types.
5662 * sound.c (struct sound_device)
5663 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5665 (Fplay_sound_internal):
5666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5667 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5668 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5669 (Fparse_partial_sexp):
5670 Don't assume fixnums can fit in int.
5671 (struct lisp_parse_state, find_start_pos, find_start_value)
5672 (find_start_value_byte, find_start_begv)
5673 (update_syntax_table, char_quoted, dec_bytepos)
5674 (find_defun_start, prev_char_comend_first, back_comment):
5675 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5676 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5678 (Finternal_describe_syntax_value): Check that match_lisp is a
5679 character, not an integer, since the code stuffs it into int.
5680 (scan_words, scan_sexps_forward):
5681 Check that fixnums are in proper range for system types.
5682 (Fforward_word):
5683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5684 (scan_sexps_forward):
5685 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5686 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5687 * syntax.h: Adjust decls to match defn changes elsewhere.
5688 (struct gl_state_s):
5689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5690 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5691 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5692 * sysdep.c (wait_for_termination_1, wait_for_termination)
5693 (interruptible_wait_for_termination, mkdir):
5694 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5695 (emacs_read, emacs_write):
5696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5697 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5698 and double all fit in int.
d311d28c
PE
5699 * term.c (set_tty_color_mode):
5700 Check that fixnums are in proper range for system types.
5701 * termhooks.h (struct input_event):
5702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5703 * textprop.c (validate_interval_range, interval_of)
5704 (Fadd_text_properties, set_text_properties_1)
5705 (Fremove_text_properties, Fremove_list_of_text_properties)
5706 (Ftext_property_any, Ftext_property_not_all)
5707 (copy_text_properties, text_property_list, extend_property_ranges)
5708 (verify_interval_modification):
5709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5710 (Fnext_single_char_property_change)
5711 (Fprevious_single_char_property_change):
5712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5713 (copy_text_properties):
5714 Check for integer overflow in index calculation.
d311d28c
PE
5715 * undo.c (last_boundary_position, record_point, record_insert)
5716 (record_delete, record_marker_adjustment, record_change)
5717 (record_property_change):
5718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5719 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5721 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5722 (Fx_hide_tip, Fx_file_dialog):
5723 * w32menu.c (set_frame_menubar):
5724 Use ptrdiff_t, not int, for consistency with rest of code.
5725 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5726 (select_window, Fdelete_other_windows_internal)
5727 (window_scroll_pixel_based, window_scroll_line_based)
5728 (Frecenter, Fset_window_configuration):
5729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5730 (Fset_window_hscroll, run_window_configuration_change_hook)
5731 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5732 (Fscroll_other_window, Frecenter):
d311d28c
PE
5733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5734 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5735 Don't assume fixnum fits in int.
5736 (Fset_window_scroll_bars):
5737 Check that fixnums are in proper range for system types.
5738 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5739 (string_pos, c_string_pos, number_of_chars, init_iterator)
5740 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5741 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5742 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5743 (face_before_or_after_it_pos, handle_invisible_prop)
5744 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5745 (display_prop_intangible_p, string_buffer_position_lim)
5746 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5747 (get_overlay_strings_1, get_overlay_strings)
5748 (iterate_out_of_display_property, forward_to_next_line_start)
5749 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5750 (get_next_display_element, set_iterator_to_next)
5751 (get_visually_first_element, compute_stop_pos_backwards)
5752 (handle_stop_backwards, next_element_from_buffer)
5753 (move_it_in_display_line_to, move_it_in_display_line)
5754 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5755 (add_to_log, message_dolog, message_log_check_duplicate)
5756 (message2, message2_nolog, message3, message3_nolog
5757 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5758 (current_message_1, truncate_echo_area, truncate_message_1)
5759 (set_message, set_message_1, store_mode_line_noprop)
5760 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5761 (text_outside_line_unchanged_p, check_point_in_composition)
5762 (reconsider_clip_changes)
5763 (redisplay_internal, set_cursor_from_row, try_scrolling)
5764 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5765 (redisplay_window, find_last_unchanged_at_beg_row)
5766 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5767 (trailing_whitespace_p, find_row_edges, display_line)
5768 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5769 (display_mode_element, store_mode_line_string)
5770 (pint2str, pint2hrstr, decode_mode_spec)
5771 (display_count_lines, display_string, draw_glyphs)
5772 (x_produce_glyphs, x_insert_glyphs)
5773 (rows_from_pos_range, mouse_face_from_buffer_pos)
5774 (fast_find_string_pos, mouse_face_from_string_pos)
5775 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5777 (safe_call, init_from_display_pos, handle_fontified_prop)
5778 (handle_single_display_spec, load_overlay_strings)
5779 (with_echo_area_buffer, setup_echo_area_for_printing)
5780 (display_echo_area, echo_area_display)
5781 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5782 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5783 (redisplay_window, dump_glyph_row, display_mode_line)
5784 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5785 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5787 (handle_single_display_spec, build_desired_tool_bar_string)
5788 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5789 (get_specified_cursor_type):
5790 Check that fixnums are in proper range for system types.
5791 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5792 (Flookup_image_map):
5793 Don't assume fixnums fit in int.
5794 (compare_overlay_entries):
5795 Avoid mishandling comparisons due to subtraction overflow.
5796 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5797 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5798 (handle_tool_bar_click):
5799 Use int, not unsigned, since we prefer signed and the signedness
5800 doesn't matter here.
5801 (get_next_display_element, next_element_from_display_vector):
5802 Use int, not EMACS_INT, when int is wide enough.
5803 (start_hourglass): Use duration_to_sec_usec to do proper
5804 overflow checking on durations.
5805 * xfaces.c (Fbitmap_spec_p):
5806 Check that fixnums are in proper range for system types.
5807 (compare_fonts_by_sort_order):
5808 Avoid mishandling comparisons due to subtraction overflow.
5809 (Fx_family_fonts, realize_basic_faces):
5810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5811 (Fx_family_fonts):
5812 Don't assume fixnum fits in int.
5813 Use SAFE_ALLOCA_LISP, not alloca.
5814 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5815 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5816 (face_at_buffer_position, face_for_overlay_string)
5817 (face_at_string_position):
5818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5819 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5820 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5821 (Fx_show_tip):
5822 Check that fixnums are in proper range for system types.
5823 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5824 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5826 (Fx_change_window_property): Don't assume fixnums fit in int.
5827 * xfont.c (xfont_chars_supported):
5828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5829 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5830 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5832 * xml.c (parse_region):
5833 * xrdb.c (magic_file_p):
5834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5835 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5836 (x_get_local_selection, x_reply_selection_request)
5837 (x_handle_selection_request, wait_for_property_change):
5838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5839 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5840 short is wide enough.
5841 (x_send_client_event): Don't assume fixnum fits in int.
5842 * xterm.c (x_x_to_emacs_modifiers):
5843 Don't assume EMACS_INT overflows nicely into int.
5844 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5845 may come from Lisp.
5846 (handle_one_xevent): NATNUMP can eval its arg twice.
5847 (x_connection_closed):
5848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5849 * xterm.h: Adjust decls to match defn changes elsewhere.
5850 (struct scroll_bar): Use struct vectorlike_header
5851 rather than rolling our own approximation.
5852 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5853
c6574eb5
GM
58542012-05-25 Glenn Morris <rgm@gnu.org>
5855
5856 * lisp.mk (lisp): Update for more files being compiled now.
5857
e8d32c7e
SM
58582012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5859
48def666
SM
5860 * lread.c: Remove `read_pure' which makes no difference.
5861 (read_pure): Remove var.
5862 (unreadpure): Remove function.
5863 (readevalloop): Don't call read_list with -1 flag.
5864 (read1, read_vector): Don't test read_pure any more.
5865 (read_list): Simplify.
5866
e8d32c7e
SM
5867 * fileio.c, character.h: Minor style tweaks.
5868
4b2addb7
DA
58692012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5870
5871 * window.h (clip_changed): Remove useless declaration.
5872
584461b2
JB
58732012-05-22 Juanma Barranquero <lekktu@gmail.com>
5874
5875 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5876 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5877
34374650
PE
58782012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5879
5880 Remove src/m/*.
5881 This directory predates autoconf and is no longer needed nowadays.
5882 Move its few remaining bits of functionality to where they're needed.
5883 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5884 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5885 * m/template.h: Remove.
5886 * Makefile.in (M_FILE): Remove. All uses removed.
5887 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5888 * lisp.h (USE_LSB_TAG):
5889 * mem-limits.h (EXCEEDS_LISP_PTR):
5890 Use VAL_MAX, not VALBITS, in #if.
5891 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5892 (EMACS_UINT): Define unconditionally now.
5893 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5894 (BITS_PER_EMACS_INT): New constants, replacing
5895 what used to be in config.h, but not useful in #if.
5896 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5897 define them any more.
5898 (VAL_MAX): New macro.
5899 (VALMASK): Use it.
5900 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5901 BITS_PER_EMACS_INT, in #if.
5902 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5903 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5904 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5905 * s/ms-w32.h (DATA_START):
5906 Move here from removed file m/intel386.h.
5907 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5908 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5909
261cb4bb
PE
59102012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5911
5912 Assume C89 or later.
5913 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5914 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5915 (xrealloc):
5916 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5917 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5918 * textprop.c, tparam.c (NULL): Remove.
5919 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5920 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5921 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5922 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5923 * xterm.c (input_signal_count): Assume volatile works.
5924
ff23cd9f
KB
59252012-05-21 Ken Brown <kbrown@cornell.edu>
5926
5927 * xgselect.c (xg_select): Fix first argument in call to 'select'
5928 (bug#11508).
5929
1b170bc6
KB
59302012-05-20 Ken Brown <kbrown@cornell.edu>
5931
5932 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5933 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5934
b2f4d39f
KB
59352012-05-19 Ken Brown <kbrown@cornell.edu>
5936
5937 * xfns.c (x_in_use): Remove `static' qualifier.
5938 * xterm.h (x_in_use): Declare.
5939 * xgselect.c: Include xterm.h.
5940 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5941 and `display_arg' (bug#9754).
5942
003fdae2
PE
59432012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5944
9232a6d9
PE
5945 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5946
003fdae2
PE
5947 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5948 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5949
784b56e2
EZ
59502012-05-18 Eli Zaretskii <eliz@gnu.org>
5951
5952 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5953
5954 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5955 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5956
5957 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5958 reference to image_cache->refcount.
5959 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5960
a0a79cde
JL
59612012-05-17 Juri Linkov <juri@jurta.org>
5962
5963 * search.c (Fword_search_regexp, Fword_search_backward)
5964 (Fword_search_forward, Fword_search_backward_lax)
5965 (Fword_search_forward_lax): Move functions to isearch.el
5966 (bug#10145, bug#11381).
5967
b0572523
PE
59682012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5969
5970 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5971
9660f5fc
SM
59722012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5973
5974 * lread.c (init_obarray): Declare Qt and Qnil as special.
5975
4374de83
GM
59762012-05-14 Glenn Morris <rgm@gnu.org>
5977
5978 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5979 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5980
dc44c39a
PE
59812012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5982
078c97cb
PE
5983 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5984
dc44c39a
PE
5985 * unexaix.c: Port to more-recent AIX compilers.
5986 (report_error, report_error_1, make_hdr, copy_sym)
5987 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5988 Make arguments const char *, not char *, to avoid violations of C
5989 standard and to fix some AIX warnings reported by Gilles Pion.
5990
e18afed7 59912012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5992
5993 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5994 already have overlays loaded.
5995 (handle_single_display_spec): Before returning without displaying
5996 fringe bitmap, synchronize the bidi iterator with the main display
5997 iterator, by calling iterate_out_of_display_property.
5998 (iterate_out_of_display_property): Detect buffer iteration by
5999 testing that it->string is a Lisp string.
6000 (get_next_display_element): When the current object is exhausted,
6001 and there's something on it->stack, call set_iterator_to_next to
6002 proceed with what's on the stack, instead of returning zero.
6003 (set_iterator_to_next): If called at the end of a Lisp string,
6004 proceed to consider_string_end without incrementing string
6005 position. Don't increment display vector index past the end of
6006 the display vector. (Bug#11417)
c8fb9dc6
EZ
6007 (pos_visible_p): Don't report a position visible when move_it_to
6008 stopped at the last line of window, which happens to be scanned
6009 backwards by the bidi iteration. (Bug#11464)
ac268e67 6010
e18afed7 60112012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6012
6013 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6014 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6015 are on a TTY, and thus unable to display on the fringes.
6016 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6017 so we need to signal to the caller that this is a "replacing"
6018 display spec. This fixes display when the spec is invalid or we
6019 are on a TTY.
6020
e18afed7 60212012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6022
6023 * unexaix.c (make_hdr): Fix typo in prototype.
6024 This bug broke the build on AIX. Problem reported by Gilles Pion.
6025
9d0a235a
MA
60262012-05-14 Michael Albinus <michael.albinus@gmx.de>
6027
6028 * keyboard.c (kbd_buffer_get_event): Read special events also in
6029 batch mode. (Bug#11415)
6030
9e6b06ed
GM
60312012-05-12 Glenn Morris <rgm@gnu.org>
6032
6033 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6034
c1a1d7a3
EZ
60352012-05-12 Eli Zaretskii <eliz@gnu.org>
6036
6037 * lisp.mk (lisp): Add newcomment.elc.
6038
3fe7cdc8
GM
60392012-05-12 Glenn Morris <rgm@gnu.org>
6040
6041 * Makefile.in (MKDIR_P): New, set by configure.
6042 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6043
53f7d2c0
PE
60442012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 Remove unused function hourglass_started.
6047 * dispextern.h (hourglass_started):
6048 * w32fns.c (hourglass_started):
6049 * xdisp.c (hourglass_started): Remove.
6050
75aafb17
JB
60512012-05-10 Juanma Barranquero <lekktu@gmail.com>
6052
6053 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6054 Update dependencies.
6055
12959e8e
PE
60562012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6057
97107e2e
PE
6058 * xgselect.c (xg_select): Put maxfds+1 into a var.
6059 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6060
12959e8e
PE
6061 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6062
836d29b3
DA
60632012-05-10 Dave Abrahams <dave@boostpro.com>
6064
6065 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6066 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6067
5cb67954
MA
60682012-05-09 Michael Albinus <michael.albinus@gmx.de>
6069
6070 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6071 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6072 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6073 Initialize xd_registered_buses.
6074
3478ec45
PE
60752012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6076
b263a6b0
PE
6077 Untag more efficiently if USE_LSB_TAG.
6078 This is based on a proposal by YAMAMOTO Mitsuharu in
6079 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6080 For an admittedly artificial (nth 8000 longlist) benchmark on
6081 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6082 Emacs's overall text size by 1%.
6083 * lisp.h (XUNTAG): New macro.
6084 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6085 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6086 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6087 * eval.c (Fautoload):
6088 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6089 * frame.h (XFRAME): Use XUNTAG.
6090
3478ec45
PE
6091 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6092 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6093 Remove unportable assumptions about print widths of types like
6094 dbus_uint32_t.
6095 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6096 intptr_t when converting between pointer and integer, to avoid GCC
6097 warnings about wrong width.
6098
666b903b 60992012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6100
6101 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6102 stack for each reader_thread, instead of defaulting to 8MB
6103 determined by the linker. This avoids failures in creating
6104 subprocesses on Windows 7, see the discussion in this thread:
6105 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6106
b120cc17
JC
61072012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6108
6109 Fix up display of the *Minibuf-0* buffer in the mini window.
6110 * keyboard.c (read_char): Don't clear the echo area if there's no
6111 message to clear.
6112 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6113 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6114
9a4b36f8
MA
61152012-05-07 Michael Albinus <michael.albinus@gmx.de>
6116
6117 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6118 batch mode.
6119
e5f9458f
CY
61202012-05-06 Chong Yidong <cyd@gnu.org>
6121
6122 * lisp.mk (lisp): Update.
6123
eceeb5fc 61242012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6125
6126 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6127
71873e2b
SM
61282012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6129
6130 * data.c (PUT_ERROR): New macro.
6131 (syms_of_data): Use it. Add new error type `user-error'.
6132 * undo.c (user_error): New function.
6133 (Fprimitive_undo): Use it.
6134 * print.c (print_error_message): Adjust print style for `user-error'.
6135 * keyboard.c (user_error): New function.
6136 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6137
ab0fa4e4
PE
61382012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6139
6140 Do not limit current-time-string to years 1000..9999.
6141 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6142 (Fcurrent_time_string): Support any year that is supported by the
6143 underlying localtime representation. Don't use asctime, as it
6144 has undefined behavior for years outside the range -999..9999.
6145
7ed806a7
PE
61462012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6147
6148 Fix race conditions involving setenv, gmtime, localtime, asctime.
6149 Without this fix, interrupts could mess up code that uses these
6150 nonreentrant functions, since setting TZ invalidates existing
6151 tm_zone or tzname values, and since most of these functions return
6152 pointers to static storage.
6153 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6154 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6155 Grow the critical sections to include not just invoking
6156 localtime/gmtime, but also accessing these functions' results
6157 including their tm_zone values if any, and any related TZ setting.
6158 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6159 so that the struct tm is saved in the critical section.
6160 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6161 motivated by the fact that memory allocation needs to be outside
6162 the critical section.
6163
0c16dfed
DA
61642012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6165
6166 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6167 with RESET_INTERVAL.
6168
6169 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6170 Remove duplicated buffer name initialization.
6171
3f83ace8
JM
61722012-05-02 Jim Meyering <jim@meyering.net>
6173
6174 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6175
c7b8541e
JM
6176 * xfns.c (x_window): Use xstrdup (Bug#11375).
6177
90207a15 61782012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6179
6180 * xdisp.c (pos_visible_p): If already at a newline from the
6181 display string before the 'while' loop, don't walk back the glyphs
6182 from it3.glyph_row. Solves assertion violation when the display
6183 string begins with a newline (egg.el). (Bug#11367)
6184
b593d6a9
AH
61852012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6186
6187 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6188 Move to simple.el.
6189
4737362e
GM
61902012-05-01 Glenn Morris <rgm@gnu.org>
6191
99cf43f9
GM
6192 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6193 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6194 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6195 All were removed before 23.1.
6196
9311dcff
GM
6197 * dispnew.c: Remove HAVE_LIBNCURSES test;
6198 it is always true on relevant platforms.
6199
4d5c6349
GM
6200 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6201 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6202
4737362e
GM
6203 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6204
74dd3a6b
AS
62052012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6206
6207 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6208 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6209 Remove.
6210
13c379ee
PE
62112012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6212
6213 Do not avoid creating empty evaporating overlays (Bug#9642).
6214 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
6215 That is, do not delete an evaporating overlay if it becomes
6216 empty after its bounds are adjusted to fit within its buffer.
6217 This fix caused other problems, and I'm reverting it until we get
6218 to the bottom of them.
6219
a8e7d6d7 62202012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
6221
6222 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
6223
a8e7d6d7 62242012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6225
6226 * xdisp.c (pos_visible_p): If the window start position is beyond
6227 ZV, start the display from buffer beginning. Prevents assertion
6228 violation in init_iterator when the minibuffer window is scrolled
6229 via the scroll bar.
6230
6231 * window.c (window_scroll_pixel_based): Likewise.
6232
a8e7d6d7 62332012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
6234
6235 * keymap.c (where_is_internal): Doc fix (Bug#10872).
6236
a8e7d6d7 62372012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
6238
6239 * fileio.c (Fcopy_file, Fset_file_selinux_context):
6240 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6241
a8e7d6d7 62422012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 6243
b593d6a9
AH
6244 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
6245 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 6246
1c6900d9
EZ
62472012-04-26 Eli Zaretskii <eliz@gnu.org>
6248
4c3fa1d9
EZ
6249 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
6250 display element, check also the underlying string or buffer
6251 character. (Bug#11341)
6252
1c6900d9
EZ
6253 * w32menu.c: Include w32heap.h.
6254 (add_menu_item): If the call to AppendMenuW (via
6255 unicode_append_menu) fails, disable Unicode menus only if we are
6256 running on Windows 9X/Me.
6257
42bf8205
AS
62582012-04-24 Andreas Schwab <schwab@linux-m68k.org>
6259
6260 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
6261 (xgetint): Add missing shift for LSB tags.
6262
b1bac16e
MR
62632012-04-24 Martin Rudalics <rudalics@gmx.at>
6264
6265 * keyboard.c (read_char): Don't wipe echo area for select window
6266 events: These might get delayed via `mouse-autoselect-window'
6267 (Bug#11304).
6268
d69621cc
JB
62692012-04-24 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
6272 manipulation of :loaded-from data.
6273
02fd101b
JB
62742012-04-23 Juanma Barranquero <lekktu@gmail.com>
6275
6276 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
6277 now a cons (bug#11311).
6278
888bec30
PE
62792012-04-23 Paul Eggert <eggert@cs.ucla.edu>
6280
89a438bd
PE
6281 Do not create empty overlays with the evaporate property (Bug#9642).
6282 * buffer.c (Fmove_overlay): Delete an evaporating overlay
6283 if it becomes empty after its bounds are adjusted to fit within
6284 its buffer. Without this fix, in a nonempty buffer (let ((o
6285 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
6286 yields an empty overlay that has the evaporate property, which is
6287 not supposed to happen.
6288
1068fe4d
PE
6289 Fix minor GTK3 problems found by static checking.
6290 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6291 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6292 (struct _EmacsFixedClass, emacs_fixed_get_type):
6293 Move decls here from emacsgtkfixed.h, since they needn't be public.
6294 (emacs_fixed_get_type): Now static.
6295 (emacs_fixed_class_init): Omit unused local.
6296 (emacs_fixed_child_type): Remove; unused.
6297 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6298 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6299 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
6300 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
6301 (EMACS_FIXED_GET_CLASS): Remove; unused.
6302 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
6303
888bec30
PE
6304 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
6305 Problem reported by Juanma Barranquero for Windows -Wunused-function.
6306
de85e130
PE
63072012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6308
d0baac98 6309 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 6310 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
6311 (__malloc_size_t, __malloc_ptrdiff_t):
6312 Remove. All uses removed, replaced by the definiens if needed,
6313 since we can assume C89 or better now.
6314 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
6315 (protect_malloc_state, align, get_contiguous_space)
6316 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
6317 (malloc_atfork_handler_child, malloc_enable_thread)
6318 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
6319 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
6320 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
6321 (special_realloc, _realloc_internal_nolock, _realloc_internal)
6322 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
6323 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
6324 Define using prototypes, not old style.
6325 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
6326 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
6327 (align): Don't assume that signed integer overflow wraps around.
6328 Omit unused local var.
6329 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
6330 (_free_internal_nolock, memalign, mallochook, reallochook):
6331 Omit no-longer-needed casts.
6332 (valloc): Use getpagesize, not __getpagesize.
6333 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
6334 (struct hdr): The 'magic' member is now size_t, not unsigned long.
6335
de85e130
PE
6336 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
6337
dcbf5805
MA
63382012-04-22 Michael Albinus <michael.albinus@gmx.de>
6339
6340 Move functions from C to Lisp. Make non-blocking method calls
6341 the default. Implement further D-Bus standard interfaces.
6342
6343 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
6344 (QCdbus_request_name_allow_replacement)
6345 (QCdbus_request_name_replace_existing)
6346 (QCdbus_request_name_do_not_queue)
6347 (QCdbus_request_name_reply_primary_owner)
6348 (QCdbus_request_name_reply_in_queue)
6349 (QCdbus_request_name_reply_exists)
6350 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
6351 (QCdbus_registered_serial, QCdbus_registered_method)
6352 (QCdbus_registered_signal): New Lisp objects.
6353 (XD_DEBUG_MESSAGE): Use sizeof.
6354 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
6355 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
6356 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
6357 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
6358 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
6359 (xd_signature, xd_append_arg): Allow float for integer types.
6360 (xd_get_connection_references): New function.
b593d6a9
AH
6361 (xd_get_connection_address): Rename from xd_initialize.
6362 Return cached address.
dcbf5805
MA
6363 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
6364 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
6365 level.
6366 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 6367 Return number of refcounts.
dcbf5805
MA
6368 (Fdbus_get_unique_name): Make stronger parameter check.
6369 (Fdbus_message_internal): New defun.
6370 (Fdbus_call_method, Fdbus_call_method_asynchronously)
6371 (Fdbus_method_return_internal, Fdbus_method_error_internal)
6372 (Fdbus_send_signal, Fdbus_register_service)
6373 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
6374 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
6375 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
6376 (Vdbus_compiled_version, Vdbus_runtime_version)
6377 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
6378 (Vdbus_message_type_method_return, Vdbus_message_type_error)
6379 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
6380 (Vdbus_registered_buses, Vdbus_registered_objects_table):
6381 Adapt docstring.
dcbf5805 6382
52828e02
PE
63832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6384
da05bc4c
PE
6385 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
6386 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
6387 Do not assume ptrdiff_t is the same width as 'int'.
6388
52828e02
PE
6389 * alloc.c: Handle unusual debugging option combinations.
6390 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
6391 since the two debugging options are incompatible.
6392 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
6393 is defined.
6394 (mem_init, mem_insert, mem_insert_fixup):
6395 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
6396 (NEED_MEM_INSERT): Remove; no longer needed.
6397
f01769f9
LL
63982012-04-22 Leo Liu <sdl.web@gmail.com>
6399
6400 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
6401
5790543d
PE
64022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6403
6404 * sysdep.c [__FreeBSD__]: Minor cleanups.
6405 (list_system_processes, system_process_attributes) [__FreeBSD__]:
6406 Use Emacs indenting style more consistently. Avoid some casts.
6407 Use 'double' consistently rather than mixing 'float' and 'double'.
6408
b91b7e4d
EW
64092012-04-21 Eduard Wiebe <usenet@pusto.de>
6410
b593d6a9
AH
6411 * sysdep.c (list_system_processes, system_process_attributes):
6412 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 6413
6114eb15
AS
64142012-04-21 Andreas Schwab <schwab@linux-m68k.org>
6415
6416 * lisp.mk (lisp): Update.
6417
2f38dff7
PE
64182012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
6421 It is never used otherwise.
6422
4ae29f89
SM
64232012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
6424
6425 * print.c (print_preprocess): Only check print_depth if print-circle
6426 is nil.
6427 (print_object): Check for cycles even when print-circle is nil and
6428 print-gensym is t, but only check print_depth if print-circle is nil.
6429
f30d612a
CY
64302012-04-20 Chong Yidong <cyd@gnu.org>
6431
6432 * process.c (wait_reading_process_output): If EIO occurs on a pty,
6433 set the status to "failed" and ensure that sentinel is run.
6434
c07a4c0b 64352012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
6436
6437 * process.c (Fset_process_inherit_coding_system_flag)
6438 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 6439 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 6440
c07a4c0b 64412012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
6442
6443 * xdisp.c (string_buffer_position_lim): Limit starting position to
6444 BEGV.
6445 (set_cursor_from_row): If called for a mode-line or header-line
6446 row, return zero immediately.
6447 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
6448 farther than the first row after the header line, if any.
6449 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
6450 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
6451
c07a4c0b 64522012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6453
4ae29f89
SM
6454 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
6455 (bug#11238).
ad3a2b41 6456
c07a4c0b 64572012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 64582012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
6459
6460 configure: new option --enable-gcc-warnings (Bug#11207)
6461 * Makefile.in (C_WARNINGS_SWITCH): Remove.
6462 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6463 (ALL_CFLAGS): Use new macros rather than old.
6464 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
6465 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
6466 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
6467 -Wunused-result, -Wunused-variable. This should go away once
6468 the Emacs and Gnulib regex code is merged.
6469 (xmalloc, xrealloc): Now static.
6470
aba027e8
PE
64712012-04-17 Paul Eggert <eggert@cs.ucla.edu>
6472
6473 * dired.c (Fsystem_groups): Remove unused local.
6474
e5a36063
GM
64752012-04-17 Glenn Morris <rgm@gnu.org>
6476
6477 * dired.c (Fsystem_users): Doc fix.
6478
316411f0
DA
64792012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6480
6481 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
6482 (syms_of_dired): Add them.
6483
9426aba4
PE
64842012-04-16 Paul Eggert <eggert@cs.ucla.edu>
6485
b62a57be
PE
6486 Fix minor alloc.c problems found by static checking.
6487 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
6488 New extern decls, to avoid calling undeclared functions.
6489 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
6490 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
6491 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6492 (NEED_MEM_INSERT): New macro.
6493 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6494 Remove one incorrect comment and fix another.
b62a57be 6495
3539f31f
PE
6496 Fix minor ralloc.c problems found by static checking.
6497 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6498 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6499 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6500 (r_alloc_sbrk): Now static.
6501
a041960a
PE
6502 Improve ralloc.c interface checking.
6503 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6504 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6505 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6506 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6507 [REL_ALLOC]: ... to here, to check interface.
6508 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6509 Remove decls. This fixes an "It stinks!".
6510
9426aba4
PE
6511 * alloc.c (which_symbols): Fix alignment issue / type clash.
6512
d55c12ed
AS
65132012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6514
6515 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6516 (struct Lisp_Misc_Any): Likewise.
6517 (struct Lisp_Free): Likewise.
6518 * alloc.c (union aligned_Lisp_Symbol): Define.
6519 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6520 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6521 (union aligned_Lisp_Misc): Define.
6522 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6523 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6524 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6525
b948ce8b
PE
65262012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6527
6528 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6529 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6530 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6531 * s/netbsd.h, s/sol2-6.h:
6532 Remove definition of GC_MARK_STACK, since the default now works.
6533 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6534 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6535 no longer the default.
6536 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6537
35dc09a1 65382012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6539
35dc09a1
GM
6540 * lread.c (lisp_file_lexically_bound_p):
6541 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6542
35dc09a1
GM
65432012-04-14 Eli Zaretskii <eliz@gnu.org>
6544
6545 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6546 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6547
65482012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6549
6550 * nsterm.m (constrainFrameRect): Always constrain when there is only
6551 one screen (Bug#10962).
6552
bcd86815
KB
65532012-04-13 Ken Brown <kbrown@cornell.edu>
6554
6555 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6556
c25df26e
RT
65572012-04-13 Reuben Thomas <rrt@sc3d.org>
6558
6559 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6560
0fc59f1e
DC
65612012-04-11 Daniel Colascione <dancol@dancol.org>
6562
6563 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6564 against is gone. It's better to use vfork now so that when Cygwin
6565 gains a new, working vfork, we use it automatically (bug#10398).
6566
de8c03dc
SM
65672012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6568
6569 * window.c (save_window_save): Obey window-point-insertion-type.
6570
2f097256
GM
65712012-04-11 Glenn Morris <rgm@gnu.org>
6572
6573 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6574
453b951e
SM
65752012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6576
6577 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6578
75f1671a 65792012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6580
6581 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6582 (force_quit_count): New var.
6583 (handle_interrupt): Use it.
6584
2a8ce227
JB
65852012-04-10 Juanma Barranquero <lekktu@gmail.com>
6586
6587 * w32.c (w32_delayed_load): Record the full path of the library
6588 being loaded (bug#10424).
6589
935396c0
GM
65902012-04-09 Glenn Morris <rgm@gnu.org>
6591
05920a43
GM
6592 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6593 not just in the obarray, before snarfing them. (Bug#11036)
6594
935396c0
GM
6595 * Makefile.in ($(leimdir)/leim-list.el):
6596 Pass EMACS rather than BUILT_EMACS.
6597
a18ecafa
TZ
65982012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6599
6600 * process.c (make_process):
6601 * process.h: Add integer `gnutls_handshakes_tried' member to
6602 process struct.
6603
6bbef4e5
JC
6604 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6605 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6606
6607 * gnutls.c (gnutls_log_function2i): Convenience log function.
6608 (emacs_gnutls_read): Use new log functions,
6609 `gnutls_handshakes_tried' process member, and
6610 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6611 attempts per process (connection).
6612
b4d3bc10
CY
66132012-04-09 Chong Yidong <cyd@gnu.org>
6614
6615 * eval.c (Fuser_variable_p, user_variable_p_eh)
6616 (lisp_indirect_variable): Functions deleted.
6617 (Fdefvar): Caller changed.
6618
6619 * callint.c (Finteractive, Fcall_interactively):
6620 * minibuf.c (Fread_variable): Callers changed.
6621
70f4d973
EZ
66222012-04-09 Eli Zaretskii <eliz@gnu.org>
6623
6624 * xdisp.c (set_cursor_from_row): If the display string appears in
6625 the buffer at position that is closer to point than the position
6626 after the display string, display the cursor on the first glyph of
6627 the display string. Fixes cursor display when a 'display' text
6628 property immediately follows invisible text. (Bug#11094)
6629
cb3c2e3e
PE
66302012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6631
6632 composite.c: use 'double' consistently
6633 * composite.c (get_composition_id): Use 'double' consistently
6634 instead of converting 'float' to 'double' and vice versa; this is
6635 easier to understand and avoids a GCC warning.
6636
fd06db5d
GM
66372012-04-09 Glenn Morris <rgm@gnu.org>
6638
50fe702a
GM
6639 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6640 preparation for dumping it with emacs. (Bug#4789)
6641 (leimdir): New variable.
6642 ($(leimdir)/leim-list.el): New rule.
6643 (emacs$(EXEEXT)): Depend on leim-list.el.
6644
fd06db5d
GM
6645 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6646 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6647 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6648
55c131ee
AS
66492012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6650
6651 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6652 proper alignment.
6653
9209588f
JB
66542012-04-07 Juanma Barranquero <lekktu@gmail.com>
6655
6656 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6657 Remove unused local variable.
6658
e3fb2efb
PE
66592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6660
6661 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6662 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6663 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6664 objects, as mark_maybe_pointer will catch them otherwise.
6665 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6666 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6667
b5385551
PE
66682012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6669
6670 Fix typo that broke non-Windows builds.
6671 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6672
9078ead6
EZ
66732012-04-07 Eli Zaretskii <eliz@gnu.org>
6674
6675 Support building on MS-Windows with libxml2.
6676
6677 * makefile.w32-in (OBJ2): Add xml.$(O).
6678 (GLOBAL_SOURCES): Add xml.c.
6679 ($(BLD)/xml.$(O)): New dependency list.
6680
6681 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6682 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6683 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6684 [!WINDOWSNT]: New macros.
6685 (init_libxml2_functions, libxml2_loaded_p): New functions.
6686 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6687 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6688 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6689 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6690 linked in).
6bbef4e5
JC
6691 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6692 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6693 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6694
6695 * emacs.c: Don't include libxml/parser.h.
6696 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6697 xmlCleanupParser directly.
6698
6699 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6700
3811fdf3
EZ
67012012-04-07 Eli Zaretskii <eliz@gnu.org>
6702
6703 * indent.c (Fvertical_motion): If there is a display string at
6704 point, use it.vpos to compute how many lines to backtrack after
6705 move_it_to point. (Bug#11133)
6706
2f8e16b2
EZ
67072012-04-06 Eli Zaretskii <eliz@gnu.org>
6708
6709 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6710 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6711 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6712 macros related to unification of CJK characters. For the details,
6713 see the discussion following the message here:
6714 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6715
3d439cd1
CY
67162012-04-04 Chong Yidong <cyd@gnu.org>
6717
6718 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6719
8bc53d00
EZ
67202012-04-01 Eli Zaretskii <eliz@gnu.org>
6721
6722 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6723 instead of alloca. (Bug#11138)
6724
3b0512a3
AS
67252012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6726
6727 * w32menu.c (is_simple_dialog): Properly check lisp types.
6728 (Bug#11141)
6729
8427ddd2
EZ
67302012-03-31 Eli Zaretskii <eliz@gnu.org>
6731
979022ef
EZ
6732 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6733 position we get to after a call to move_it_to fails the
6734 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6735 only if we wind up in a string from display property. (Bug#11063)
6736
a6b1c7cc
EZ
6737 * window.c (Fdelete_other_windows_internal): Invalidate the row
6738 and column information about mouse highlight, so that redisplay
6739 restores it after reallocating the glyph matrices. (Bug#7464)
6740
8427ddd2
EZ
6741 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6742 string comes from a `display' text property, use the buffer
6743 position of that property as if we actually saw that position in
6744 the row's glyphs.
697ba24b
EZ
6745 (move_it_by_lines): Remove the assertion that
6746 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6747 violated when there's a before-string at the beginning of a line.
6748 (Bug#11063)
8427ddd2 6749
65a0a738
EZ
67502012-03-30 Eli Zaretskii <eliz@gnu.org>
6751
6752 * xdisp.c (append_space_for_newline): If the default face was
6753 remapped, use the remapped face for the appended newline.
6754 (extend_face_to_end_of_line): Use the remapped default face for
6755 extending the face to the end of the line.
6756 (display_line): Call extend_face_to_end_of_line when the default
6757 face was remapped. (Bug#11068)
6758
581355cc
EZ
67592012-03-29 Eli Zaretskii <eliz@gnu.org>
6760
6761 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6762
e8fc049f
SM
67632012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6764
6765 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6766
4fb9a543
GM
67672012-03-27 Glenn Morris <rgm@gnu.org>
6768
6769 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6770 Doc fixes.
6771
679910f1
KH
67722012-03-26 Kenichi Handa <handa@m17n.org>
6773
6774 * dispextern.h (struct glyph): Fix previous change. Change the
6775 bit length of glyphless.ch to 25 (Bug#11082).
6776
90d49b7f
CY
67772012-03-26 Chong Yidong <cyd@gnu.org>
6778
6779 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6780 (command_loop_1): Use it; inhibit selection update for
6781 handle-select-window too (Bug#8996).
6782
f514f6f0
FP
67832012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6784
e8fc049f 6785 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6786
bf43fa51
KH
67872012-03-25 Kenichi Handa <handa@m17n.org>
6788
6789 * dispextern.h (struct glyph): Change the bit length of
6790 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6791
8a0c01dd
EZ
67922012-03-24 Eli Zaretskii <eliz@gnu.org>
6793
6794 * s/ms-w32.h (tzname): Include time.h before redirecting to
6795 _tzname. Fixes the MSVC build. (Bug#9960)
6796
7d1c3a76
AS
67972012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6798
8ed79523
AS
6799 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6800 characters.
6801
7d1c3a76
AS
6802 * xterm.c (XTread_socket): Only modify handling_signal if
6803 !SYNC_INPUT. (Bug#11080)
6804
e99a9b8b
EZ
68052012-03-23 Eli Zaretskii <eliz@gnu.org>
6806
6807 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6808 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6809 when fetching a multibyte character consumes more bytes than
6810 CHAR_BYTES returns, due to unification of CJK characters in
6811 string_char. (Bug#11073)
6812
5063c0e1
TN
68132012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6814
6815 * process.c (wait_reading_process_output): Handle pty disconnect
6816 by refraining from sending oneself a SIGCHLD (bug#10933).
6817
9f851fbd
CY
68182012-03-22 Chong Yidong <cyd@gnu.org>
6819
6820 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6821
5063c0e1 6822 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6823 Mark string as coming from a prefix property.
6824 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6825 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6826
fb5b8aca
CY
68272012-03-21 Chong Yidong <cyd@gnu.org>
6828
6829 * xfaces.c (Vface_remapping_alist): Doc fix.
6830
62356a1b
EZ
68312012-03-20 Eli Zaretskii <eliz@gnu.org>
6832
6833 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6834 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6835 Doc fixes.
62356a1b 6836
025de85b
CY
68372012-03-20 Chong Yidong <cyd@gnu.org>
6838
6839 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6840 to reflect default non-nil value of redisplay-dont-pause.
6841
4827f94e
KH
68422012-03-19 Kenichi Handa <handa@m17n.org>
6843
6844 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6845 it fit in a valid range (Bug#11003).
6846
e50a24a2
EZ
68472012-03-18 Eli Zaretskii <eliz@gnu.org>
6848
6849 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6850 that is not from display property, accept the row as a "cursor
6851 row" if one of the string's character has a non-nil `cursor'
6852 property. Fixes cursor positioning when there are newlines in
6853 overlay strings, e.g. in icomplete.el. (Bug#11035)
6854
9af5ed87
PE
68552012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6856
6857 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6858
d1f55f16
CY
68592012-03-12 Chong Yidong <cyd@gnu.org>
6860
6861 * eval.c (inhibit_lisp_code): Rename from
6862 inhibit_window_configuration_change_hook; move from window.c.
6863
6864 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6865 * window.c (run_window_configuration_change_hook)
6866 (syms_of_window): Callers changed.
6867
66c5eebd
CY
68682012-03-11 Chong Yidong <cyd@gnu.org>
6869
413df973
CY
6870 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6871
66c5eebd
CY
6872 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6873
1de11f56
CY
68742012-03-10 Chong Yidong <cyd@gnu.org>
6875
6876 * frame.c (other_visible_frames): Don't assume the selected frame
6877 is visible (Bug#10955).
6878
cae07000
SM
68792012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6880
6881 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6882
89c94350
JD
68832012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6884
6885 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6886 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6887 zero (Bug#10954).
6888
999dd333
GM
68892012-03-03 Glenn Morris <rgm@gnu.org>
6890
01a6dcc8 6891 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6892
de0100f2
EZ
68932012-03-02 Eli Zaretskii <eliz@gnu.org>
6894
6895 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6896 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6897 (redisplay_window, next_element_from_string): Fix typos in
6898 comments.
3e441275
EZ
6899 (redisplay_window): Pass to move_it_vertically the margin in
6900 pixels, not in screen lines.
de0100f2 6901
96a72ee9
GM
69022012-03-02 Glenn Morris <rgm@gnu.org>
6903
6904 * buffer.c (buffer-list-update-hook): Doc fix.
6905
312508d7
EZ
69062012-02-29 Eli Zaretskii <eliz@gnu.org>
6907
6908 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6909 push_it before setting up the iterator for the first overlay
6910 string, even if we have an empty string loaded.
6911 (next_overlay_string): If there's an empty string on the iterator
6912 stack, pop the stack. (Bug#10903)
6913
27f3c637
PE
69142012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6915
6916 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6917 Suggested by Stefan Monnier in
6918 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6919 * alloc.c (widen_to_Lisp_Object): New static function.
6920 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6921 and widening them to Lisp_Objects. This would work even if
6922 USE_LSB_TAG is defined and wide integers are used, which might
6923 happen in a future version of Emacs.
6924
3c9dfce6
CY
69252012-02-25 Chong Yidong <cyd@gnu.org>
6926
fa74b241
CY
6927 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6928 Doc fix.
6929
3c9dfce6
CY
6930 * xselect.c (Fx_selection_exists_p): Doc fix.
6931 (x_clipboard_manager_save_all): Print an informative message
6932 before saving to clipboard manager.
6933
9486df08
CY
69342012-02-24 Chong Yidong <cyd@gnu.org>
6935
6936 * keyboard.c (process_special_events): Handle all X selection
6937 requests in kbd_buffer, not just the next one (Bug#8869).
6938
f01d3321
CY
69392012-02-23 Chong Yidong <cyd@gnu.org>
6940
6941 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6942 call when setting menu-bar-lines and tool-bar-lines parameters.
6943 (unwind_create_frame_1): New helper function.
6944
6945 * window.c (inhibit_window_configuration_change_hook): New var.
6946 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6947 (syms_of_window): Initialize it.
f01d3321 6948
86b847b6
CY
69492012-02-22 Chong Yidong <cyd@gnu.org>
6950
6951 * xterm.c (x_draw_image_relief): Add missing type check for
6952 Vtool_bar_button_margin (Bug#10743).
6953
a59225b1
CY
69542012-02-21 Chong Yidong <cyd@gnu.org>
6955
6956 * fileio.c (Vfile_name_handler_alist): Doc fix.
6957
6958 * buffer.c (Fget_file_buffer): Protect against invalid file
6959 handler return value.
6960
310f5bd4
PE
69612012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6962
cb3a28cc
PE
6963 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6964 when computing $valmask.
6965
310f5bd4
PE
6966 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6967 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6968 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6969 It's useless in that case, and it can cause problems on hosts
6970 that allocate halves of EMACS_INT values separately.
6971 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6972 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6973 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6974 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6975 it avoids undefined behavior on hosts where shifting right by more
6976 than the word width has undefined behavior.
6977
2375c96a
CY
69782012-02-19 Chong Yidong <cyd@gnu.org>
6979
6980 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6981 (Funhandled_file_name_directory, Ffile_name_as_directory)
6982 (Fdirectory_file_name, Fexpand_file_name)
6983 (Fsubstitute_in_file_name): Protect against invalid file handler
6984 return values (Bug#10845).
6985
3eb49e71
EZ
69862012-02-18 Eli Zaretskii <eliz@gnu.org>
6987
6988 * .gdbinit (pitx): Fix incorrect references to fields of the
6989 iterator stack.
6990
7b926f3f
CY
69912012-02-17 Chong Yidong <cyd@gnu.org>
6992
6993 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6994
11273115
PE
69952012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6996
6997 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6998 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6999
c3a70e2b
CY
70002012-02-15 Chong Yidong <cyd@gnu.org>
7001
7002 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7003 marked as special. Also, starting docstrings with * is obsolete.
7004
0ca43699
AS
70052012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7006
7007 * gnutls.c (emacs_gnutls_write): Fix last change.
7008
2e8f3c56
LI
70092012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7010
7011 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7012 send_process.
7013
af70074f
SM
70142012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7015
7016 * keymap.c (Fsingle_key_description): Handle char ranges.
7017
95986d52
CY
70182012-02-12 Chong Yidong <cyd@gnu.org>
7019
afd83bd1
CY
7020 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7021 as that creates a dangerous corner case.
7022
95986d52
CY
7023 * window.c (Fdelete_window_internal): Invalidate the mouse
7024 highlight (Bug#9904).
7025
bd7da63e
GM
70262012-02-12 Glenn Morris <rgm@gnu.org>
7027
7028 * xselect.c (Fx_own_selection_internal)
7029 (Fx_get_selection_internal, Fx_disown_selection_internal)
7030 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7031 * nsselect.m (Fx_own_selection_internal)
7032 (Fx_disown_selection_internal, Fx_selection_exists_p)
7033 (Fx_selection_owner_p, Fx_get_selection_internal):
7034 Sync docs and argument specs with the xselect.c versions.
7035
77abcbc2
LI
70362012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7037
7038 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7039
90b671e2
EZ
70402012-02-11 Eli Zaretskii <eliz@gnu.org>
7041
1c0ca0b7
EZ
7042 * w32select.c (Fx_selection_exists_p): Sync doc string and
7043 argument list with xselect.c. (Bug#10783)
7044
7045 * w16select.c (Fx_selection_exists_p): Sync doc string and
7046 argument list with xselect.c. (Bug#10783)
90b671e2 7047
49241268
GM
70482012-02-10 Glenn Morris <rgm@gnu.org>
7049
7050 * fns.c (Fsecure_hash): Doc fix.
7051
f998bbe7 70522012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7053
7054 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7055
0992bd9c
CY
70562012-02-07 Chong Yidong <cyd@gnu.org>
7057
7058 * buffer.c (Fbuffer_local_variables)
7059 (buffer_lisp_local_variables): Handle unbound vars correctly;
7060 don't let Qunbound leak into Lisp.
7061
af008560
GM
70622012-02-07 Glenn Morris <rgm@gnu.org>
7063
dd605cc4
GM
7064 * image.c (Fimagemagick_types): Doc fix.
7065
af008560
GM
7066 * image.c (imagemagick-render-type): Change it from a lisp object
7067 to an integer. Move the doc here from the lisp manual.
7068 Treat all values not equal to 0 the same.
7069
1449fa1d
CY
70702012-02-06 Chong Yidong <cyd@gnu.org>
7071
7072 * doc.c (store_function_docstring): Avoid applying docstring of
7073 alias to base function (Bug#2603).
7074
3723ec07
AS
70752012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7076
7077 * .gdbinit (pp1, pv1): Remove redundant defines.
7078 (pr): Use pp.
7079
79c1cc1e
CY
70802012-02-04 Chong Yidong <cyd@gnu.org>
7081
7082 * nsterm.m: Declare a global (Bug#10694).
7083
d7f29f8e
EZ
70842012-02-04 Eli Zaretskii <eliz@gnu.org>
7085
cae07000
SM
7086 * w32.c (get_emacs_configuration_options):
7087 Include --enable-checking, if specified, in the return value.
d7f29f8e 7088
3b95a6f9
MR
70892012-02-04 Martin Rudalics <rudalics@gmx.at>
7090
7091 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7092 after rounding frame sizes. (Bug#9723)
7093
d6fa96a6
EZ
70942012-02-04 Eli Zaretskii <eliz@gnu.org>
7095
7096 * keyboard.c (adjust_point_for_property): Don't position point
7097 before BEGV. (Bug#10696)
7098
df0b2940
PE
70992012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7100
7101 Handle overflow when computing char display width (Bug#9496).
7102 * character.c (char_width): Return EMACS_INT, not int.
7103 (char_width, c_string_width): Check for overflow when
7104 computing the width; this is possible now that individual
7105 characters can have unbounded width. Problem introduced
7106 by merge from Emacs 23 on 2012-01-19.
7107
6bee44d6
MA
71082012-02-02 Michael Albinus <michael.albinus@gmx.de>
7109
7110 * dbusbind.c (Fdbus_register_method): Mention the return value
7111 :ignore in the docstring.
7112
44f92739
GM
71132012-02-02 Glenn Morris <rgm@gnu.org>
7114
1b9f60cc
GM
7115 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7116
44f92739
GM
7117 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7118 Unconditionally set to t. (Bug#10673)
7119 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7120 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7121 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
7122
c5d3843c
KH
71232012-02-02 Kenichi Handa <handa@m17n.org>
7124
7125 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7126 0, do not call append_composite_glyph.
7127
159462d4 71282012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7129
7130 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7131 NULL (Bug#6988).
7132 (x_produce_glyphs): If the component of a composition is a null
7133 string, set it->pixel_width to 1 to avoid zero-width glyph.
7134
78cef877
EZ
71352012-02-01 Eli Zaretskii <eliz@gnu.org>
7136
7137 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7138 first 2 arguments are identical. This makes inserting large
7139 output from a subprocess an order of magnitude faster on
7140 MS-Windows, where all sbrk'ed memory is always contiguous.
7141
97897668
GM
71422012-01-31 Glenn Morris <rgm@gnu.org>
7143
7144 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7145 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7146 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7147
31fd3586
GM
71482012-01-29 Glenn Morris <rgm@gnu.org>
7149
7150 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7151
0e24a8b2
CY
71522012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7153
7154 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7155
cc0adcb0
CY
71562012-01-28 Chong Yidong <cyd@gnu.org>
7157
7158 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7159
acc28cb9
CY
71602012-01-26 Chong Yidong <cyd@gnu.org>
7161
9c69cfb7
CY
7162 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7163
acc28cb9
CY
7164 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7165 repeat counts (Bug#10507).
7166
48da7392
GM
71672012-01-26 Glenn Morris <rgm@gnu.org>
7168
7169 * lread.c (syms_of_lread): Doc fix.
7170
14af5f7f
CY
71712012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7172
7173 * coding.c (encode_designation_at_bol): Change return value to
7174 EMACS_INT.
7175
0b21c100
CY
71762012-01-25 Chong Yidong <cyd@gnu.org>
7177
7178 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7179
3c2907f7
CY
71802012-01-21 Chong Yidong <cyd@gnu.org>
7181
7182 * floatfns.c (Fcopysign): Make the second argument non-optional,
7183 since nil is not allowed anyway.
7184
959ad23f
AS
71852012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7186
7187 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7188 (send_process): Likewise.
7189
34a02f46
MR
71902012-01-19 Martin Rudalics <rudalics@gmx.at>
7191
7192 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7193 (Vwindow_persistent_parameters): Do not use Qstate.
7194 Rewrite doc-strings.
34a02f46 7195
1259009a 71962012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7197
7198 * character.c (char_width): New function.
70d4fdf6
GM
7199 (Fchar_width, c_string_width, lisp_string_width):
7200 Use char_width (Bug#9496).
25ed9e61 7201
6a6ee00d
MR
72022012-01-16 Martin Rudalics <rudalics@gmx.at>
7203
7204 * window.c (Vwindow_persistent_parameters): New variable.
7205 (Fset_window_configuration, save_window_save): Handle persistent
7206 window parameters.
7207
c85efaf7
EZ
72082012-01-14 Eli Zaretskii <eliz@gnu.org>
7209
7210 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7211 thrashing the stack of the thread. (Bug#9087)
7212
5944709e
PE
72132012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7214
7215 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
7216
e71f5d99
EZ
72172012-01-11 Eli Zaretskii <eliz@gnu.org>
7218
7219 * xdisp.c (rows_from_pos_range): Handle the case where the
7220 highlight ends on a newline. (Bug#10464)
7221 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
7222 he end column for display of highlight that ends on a newline
7223 before a R2L line.
7224
ce316182
GM
72252012-01-11 Glenn Morris <rgm@gnu.org>
7226
7227 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
7228 from load-path also when installation-directory is nil. (Bug#10208)
7229
5b43da69
GM
72302012-01-10 Glenn Morris <rgm@gnu.org>
7231
74cc8ff9
GM
7232 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
7233
7d8d6e4e
GM
7234 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
7235 Update template values to be closer to their typical values these days.
5b43da69 7236
a0db8d43
EZ
72372012-01-09 Eli Zaretskii <eliz@gnu.org>
7238
7239 * xdisp.c (rows_from_pos_range): Accept additional argument
7240 DISP_STRING, and accept any glyph in a row whose object is that
7241 string as eligible for mouse highlight. Fixes mouse highlight of
7242 display strings from overlays. (Bug#10464)
7243
9a0115ab 72442012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 7245
b9110d6a 7246 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
7247 * fileio.c (auto_saving_dir_umask): New static var.
7248 (Fmake_directory_internal): Use it.
7249 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7250 creating the directory. The old code temporarily assigns
7251 too-generous permissions to the directory.
7252 (do_auto_save_eh): Clear it.
b9110d6a 7253 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
7254 that the var is always cleared.
7255
6c1bd3f3
EZ
72562012-01-07 Eli Zaretskii <eliz@gnu.org>
7257
7258 * search.c (scan_buffer): Pass character positions to
7259 know_region_cache, not byte positions. (Bug#6540)
7260
069d2b50
L
72612012-01-07 LynX <_LynX@bk.ru> (tiny change)
7262
7263 * w32.c (sys_rename): Report EXDEV when rename of a directory
7264 fails because the target is on another logical disk. (Bug#10284)
7265
75bf0d33
DB
72662012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
7267
7268 * xterm.c (x_embed_request_focus): New function.
7269
7270 * xterm.h: Add prototype.
7271
7272 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
7273
1c6e5a32
GM
72742012-01-05 Glenn Morris <rgm@gnu.org>
7275
7276 * emacs.c (emacs_copyright): Update short copyright year to 2012.
7277
651e947e
EZ
72782012-01-01 Eli Zaretskii <eliz@gnu.org>
7279
7280 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
7281 Load gnutls_transport_set_lowat only if GnuTLS version is below
7282 2.11.1.
7283 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7284 GnuTLS versions below 2.11.1.
7285
3778cdd8
AL
72862011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
7287
7288 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
7289 to the doc string advising against its use for altering the way
7290 windows are scrolled.
7291
0e5317f7
KH
72922011-12-28 Kenichi Handa <handa@m17n.org>
7293
7294 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
7295 coding-system ASCII compatible only when it does not produce BOM
7296 on encoding (Bug#10383).
7297
93d5ca1f
JD
72982011-12-26 Jan Djärv <jan.h.d@swipnet.se>
7299
7300 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
7301 can scroll.
7302 (create_and_show_popup_menu): Always use menu_position_func for
7303 Gtk3 (Bug#10361).
7304
ca22b785
AS
73052011-12-24 Andreas Schwab <schwab@linux-m68k.org>
7306
7307 * callint.c (Fcall_interactively): Don't truncate prompt string.
7308
d048e1e6
EZ
73092011-12-23 Eli Zaretskii <eliz@gnu.org>
7310
7311 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
7312 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 7313 resumed from there (after widening). (Bug#10360)
d048e1e6 7314
5ccaba1f
JD
73152011-12-22 Jan Djärv <jan.h.d@swipnet.se>
7316
7317 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
7318
204ee57f
JD
73192011-12-21 Jan Djärv <jan.h.d@swipnet.se>
7320
b81d40f0
JB
7321 * nsterm.m (x_free_frame_resources):
7322 Release f->output_data.ns->miniimage.
204ee57f
JD
7323 (ns_index_color): Fix indentation. Do not retain
7324 color_table->colors[i].
7325
7326 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
7327 before returning.
7328
7329 * nsfns.m (x_set_background_color): Assign return value from
7330 ns_index_color to face-background instead of NSColor*.
7331 (ns_implicitly_set_icon_type): Fix indentation.
7332 Change assignment in for loop to comparison.
7333
7334 * emacs.c (ns_pool): New variable.
7335 (main): Assign ns_pool.
7336 (Fkill_emacs): Call ns_release_autorelease_pool.
7337
7338 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
7339 autorelease fdesc, release fdAttrs and tdict.
7340 (ns_get_covering_families): Release charset.
7341 (ns_findfonts): Release NSFontDescriptor created with new.
7342 (ns_uni_to_glyphs): Fix indentation.
7343 (setString): Release attrStr before assigning new value.
7344
c803b2b7
JD
73452011-12-18 Jan Djärv <jan.h.d@swipnet.se>
7346
678f4426
JD
7347 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
7348 and NS_IMPL_COCOA.
7349 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
7350 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7351
cd394be1 73522011-12-18 David Reitter <reitter@cmu.edu>
678f4426 7353
5fecd5fc
JD
7354 * nsterm.m (ns_term_init): Subscribe for notifications
7355 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
7356 to method trackingNotification in EmacsMenu.
7357
7358 * nsmenu.m (trackingMenu): New variable.
3771cb17 7359 (trackingNotification): New method (from Aquamacs).
5fecd5fc 7360 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 7361 from Aquamacs (Bug#7030).
678f4426
JD
7362
73632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 7364
c803b2b7
JD
7365 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
7366 (symbol_to_nsstring): Fix indentation.
7367 (ns_symbol_to_pb): New function.
cae07000
SM
7368 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
7369 (Fns_rotate_cut_buffers_internal): Remove.
7370 (Fns_store_selection_internal): Rename from
c803b2b7
JD
7371 Fns_store_cut_buffer_internal.
7372 (ns_get_foreign_selection, Fx_own_selection_internal)
7373 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
7374 (Fns_get_selection_internal, Fns_store_selection_internal):
7375 Use ns_symbol_to_pb and check if return value is nil.
7376 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
7377 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
7378 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
7379 renamed to Sns_store_selection_internal.
7380 (ns_handle_selection_request): Move code to Fx_own_selection_internal
7381 and remove this function.
7382 (ns_handle_selection_clear): Remove, never used.
7383 (Fx_own_selection_internal): Move code from ns_handle_selection_request
7384 here.
7385
e1b01a3a
KB
73862011-12-17 Ken Brown <kbrown@cornell.edu>
7387
7388 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
7389 GID is unknown (Bug#10257).
7390
2adb6e85
PE
73912011-12-17 Paul Eggert <eggert@cs.ucla.edu>
7392
7393 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
7394 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
7395 which caused a build failure on GNU/Linux IA-64. This problem was
7396 introduced by my 2011-10-07 patch.
7397
d1d7b339
JL
73982011-12-15 Juri Linkov <juri@jurta.org>
7399
7400 * image.c (imagemagick_error): New function. (Bug#10112)
7401 (imagemagick_load_image): Comment out `MagickSetResolution' call.
7402 Use `imagemagick_error' where ImageMagick functions return
7403 `MagickFalse'.
7404 (Fimagemagick_types): Add `Fnreverse' to return the list in the
7405 proper order.
7406
100d5755
KH
74072011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7408
7409 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
7410 fill background (Bug#8992).
7411
454592a6
MR
74122011-12-13 Martin Rudalics <rudalics@gmx.at>
7413
7414 * window.c (Vwindow_combination_resize)
7415 (Vwindow_combination_limit): Use t instead of non-nil in
7416 doc-strings.
61d4b438
MR
7417 (Vrecenter_redisplay): Add first sentence of doc-string on
7418 separate line.
53524d93 7419 (Frecenter): Fix doc-string typo.
454592a6 7420
3633e3aa
KH
74212011-12-11 Kenichi Handa <handa@m17n.org>
7422
7423 * coding.c (Funencodable_char_position): Pay attention to the
7424 buffer text relocation (Bug#9389).
7425
7b9d523a 74262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 7427
7b9d523a
JD
7428 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
7429 gtk_init (Bug#10100).
7430
b73189c6
EZ
74312011-12-10 Eli Zaretskii <eliz@gnu.org>
7432
7433 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
7434 IT->string is nil. (Bug#10263)
7435
f7dfe5d6
JD
74362011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7437
83faebb4
JD
7438 * nsterm.h (x_free_frame_resources): Declare.
7439
f7dfe5d6
JD
7440 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
7441 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7442
7443 * nsterm.h (ns_get_defaults_value): Declare.
7444
7445 * nsterm.m (ns_default): Call ns_get_defaults_value.
7446
7cd4e72c
EZ
74472011-12-09 Eli Zaretskii <eliz@gnu.org>
7448
7449 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
7450 (Bug#10170)
7451
b34d7317
YM
74522011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7453
7454 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
7455 that where the value of an _OBJC_* symbol points to is in the .bss
7456 section (Bug#10240).
7457
76470ad1
KH
74582011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7459
7460 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 7461 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 7462
745fff94
KH
74632011-12-08 Kenichi Handa <handa@m17n.org>
7464
7465 * ftfont.c (get_adstyle_property): Fix previous change
7466 (Bug#10233).
7467
6e44397c
JB
74682011-12-07 Juanma Barranquero <lekktu@gmail.com>
7469
7470 * w32.c (init_environment): If no_site_lisp, remove site-lisp
7471 dirs from the default value of EMACSLOADPATH (bug#10208).
7472
7efa6272
GM
74732011-12-07 Glenn Morris <rgm@gnu.org>
7474
7475 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
7476 installation and source directories as well. (Bug#10208)
7477
f6fc4d87
CY
74782011-12-06 Chong Yidong <cyd@gnu.org>
7479
7480 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
7481
2bf26180
GM
74822011-12-06 Glenn Morris <rgm@gnu.org>
7483
7484 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
7485 as an error, not just -1. (Bug#10217)
7486
3a6ad4f0
CY
74872011-12-05 Chong Yidong <cyd@gnu.org>
7488
7489 * keyboard.c (process_special_events): New function.
7490 (swallow_events, Finput_pending_p): Use it (Bug#10195).
7491
75a3b399
PE
74922011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7493
7494 * coding.c (encode_designation_at_bol): Don't use uninitialized
7495 local variable (Bug#9318).
7496
c3c9e25e
KH
74972011-12-05 Kenichi Handa <handa@m17n.org>
7498
7499 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7500 return Qnil (Bug#8046, Bug#10193).
7501
5eb05ea3
KH
75022011-12-05 Kenichi Handa <handa@m17n.org>
7503
7504 * coding.c (encode_designation_at_bol): New args charbuf_end and
7505 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7506 (coding_set_source): Return how many bytes coding->source was
7507 relocated.
7508 (coding_set_destination): Return how many bytes
7509 coding->destination was relocated.
7510 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7511 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7512
75132011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7514
7515 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7516 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7517 macro (Bug#9318).
7518
75192011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7520
7521 The following changes are to fix Bug#9318.
7522
a79703f5 7523 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7524 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7525 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7526 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7527
7dbda6df
JB
75282011-12-05 Juanma Barranquero <lekktu@gmail.com>
7529
7530 * lisp.h (process_quit_flag): Fix external declaration.
7531
6d5eb5b0
SM
75322011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7533
7534 Don't macro-inline non-performance-critical code.
7535 * eval.c (process_quit_flag): New function.
7536 * lisp.h (QUIT): Use it.
7537
a0c3fad0
JD
75382011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7539
7540 * nsfns.m (get_geometry_from_preferences): New function.
7541 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7542
6c07aac2
AS
75432011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7544
7545 * emacs.c (Qkill_emacs): Define.
7546 (syms_of_emacs): Initialize it.
7547 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7548 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7549 (quit_throw_to_read_char): Add parameter `from_signal'.
7550 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7551 * lisp.h (QUIT): Call Fkill_emacs if requested.
7552
c052ead4
JD
75532011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7554
7555 * widget.c (update_wm_hints): Return if wmshell is null.
7556 (widget_update_wm_size_hints): New function.
7557
7558 * widget.h (widget_update_wm_size_hints): Declare.
7559
7560 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7561 widget_update_wm_size_hints (Bug#10104).
7562
9e49252b
EZ
75632011-12-03 Eli Zaretskii <eliz@gnu.org>
7564
7565 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7566 before a newline, prepare the bidi iterator for consuming the
7567 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7568 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7569
02b16839
JL
75702011-12-02 Juri Linkov <juri@jurta.org>
7571
7572 * search.c (Fword_search_regexp): New Lisp function created from
7573 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7574 (Fword_search_backward, Fword_search_forward)
7575 (Fword_search_backward_lax, Fword_search_forward_lax):
7576 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7577 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7578
0068070e
SM
75792011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7580
7581 * fileio.c (Finsert_file_contents): Move after-change-function call
7582 to before the "handled:" label, since all "goto handled" appear in
7583 cases where the *-change-functions have already been properly called
7584 (bug#10117).
7585
3360a3fc
AS
75862011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7587
7588 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7589 waiting for input. (Bug#10169)
7590
73d6c093
EZ
75912011-11-30 Eli Zaretskii <eliz@gnu.org>
7592
7593 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7594 verifies glyph row's hash code--we have just reallocated the
7595 glyphs, so their contents can be complete garbage. (Bug#10164)
7596
febe6bea
JB
75972011-11-30 Juanma Barranquero <lekktu@gmail.com>
7598
7599 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7600
801a4313
EZ
76012011-11-30 Eli Zaretskii <eliz@gnu.org>
7602
7603 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7604 attributes are tested _before_ calling verify_row_hash, to protect
7605 against GCC re-ordering of the tests. (Bug#10164)
7606
2b56b87e
JD
76072011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7608
7609 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7610
7611 * xterm.c (handle_one_xevent): Only set async_visible and friends
7612 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7613 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7614 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7615
dbf31225
PE
76162011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7617
7618 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7619 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7620 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7621 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7622 All uses changed to use GCPRO1 etc.
7623 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7624 Revert to old implementation (i.e., before 2011-03-11).
7625
1305621b
YM
76262011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7627
7628 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7629 of scroll runs so as to avoid assigning disabled bogus rows and
7630 unnecessary graphics copy operations.
7631
8c9afb46
EZ
76322011-11-27 Eli Zaretskii <eliz@gnu.org>
7633
7634 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7635 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7636 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7637 (malloc, free, realloc, calloc): Redirect to e_* only when
7638 compiling Emacs.
7639
7640 * lisp.h (GCTYPEBITS): Move before first use.
7641 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7642 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7643 this macro definition.
7644
7645 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7646 _MSC_VER.
7647
54e9e3bf
JD
76482011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7649
6d5eb5b0
SM
7650 * gtkutil.c (xg_create_frame_widgets):
7651 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7652 present with Gtk+ 2.0.
7653
83aca1cb
PE
76542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7655
7656 * fileio.c (Finsert_file_contents): Undo previous change; see
7657 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7658
5b76caa4
PE
76592011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7660
7661 Rename locals to avoid shadowing.
7662 * fileio.c (Finsert_file_contents):
7663 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7664 * process.c (wait_reading_process_output):
7665 Rename inner 'proc' to 'p' to avoid shadowing.
7666 Indent for consistency with usual Emacs style.
7667
8c535114
EZ
76682011-11-25 Eli Zaretskii <eliz@gnu.org>
7669
7670 * xdisp.c (redisplay_window): If cursor row is not fully visible
7671 after recentering, and scroll-conservatively is set to a large
7672 number, scroll window by a few more lines to make the cursor fully
7673 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7674 (start_display): Don't move to the next line if the display should
7675 start at a newline that is part of a display vector or an overlay
7676 string. (Bug#10119)
8c535114 7677
fa4fdb5c
JL
76782011-11-24 Juri Linkov <juri@jurta.org>
7679
7680 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7681 after the `MagickPingImage' call. (Bug#10112)
7682
90ec88df
CY
76832011-11-23 Chong Yidong <cyd@gnu.org>
7684
7685 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7686
56e2e794
MR
76872011-11-23 Martin Rudalics <rudalics@gmx.at>
7688
7689 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7690 making another buffer current. (Bug#10114)
7691
b6e64c41
GM
76922011-11-23 Glenn Morris <rgm@gnu.org>
7693
7694 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7695
6b21de18
CY
76962011-11-23 Chong Yidong <cyd@gnu.org>
7697
7698 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7699 using it (Bug#5984).
7700
b12cd789
EZ
77012011-11-22 Eli Zaretskii <eliz@gnu.org>
7702
7703 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7704 and header-lines, as they don't have one computed for them.
7705 (Bug#10098)
7706
7707 * .gdbinit (prow): Make displayed values more self-explaining.
7708 Add row's hash code.
7709
261b6fd4
LMI
77102011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7711
7712 * process.c (wait_reading_process_output): Fix asynchrounous
7713 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7714 (wait_reading_process_output): Add comment and URL.
261b6fd4 7715
e7cfd277
JD
77162011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7717
7718 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7719
a9b9b7f5
CY
77202011-11-21 Chong Yidong <cyd@gnu.org>
7721
7722 * window.c (Fnext_window, Fprevious_window): Doc fix.
7723
b0d15b4f
SM
77242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7725
7726 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7727
fe7a3057
JB
77282011-11-20 Juanma Barranquero <lekktu@gmail.com>
7729
7730 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7731
d2999b1a
MR
77322011-11-20 Martin Rudalics <rudalics@gmx.at>
7733
7734 * window.c (Fset_window_combination_limit): Rename argument
7735 STATUS to LIMIT.
7736 (Vwindow_combination_limit): Remove "status" from doc-string.
7737
d5ff9cd0
AS
77382011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7739
7740 * m/ibms390.h: Remove.
7741 * m/ibms390x.h: Don't include "ibms390.h".
7742
a5bb9bd3
SM
77432011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7744
7745 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7746 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7747
cd1181db
JB
77482011-11-20 Juanma Barranquero <lekktu@gmail.com>
7749
7750 * casetab.c (Fset_case_table):
7751 * charset.c (Fcharset_after): Fix typos.
7752
615a3b8d 77532011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7754
17e845af
PE
7755 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7756 Otherwise, valgrind does not work on some platforms.
7757 Problem reported by Andreas Schwab in
6a0bf43d
PE
7758 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7759 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7760 is set, removing the need for VIRT_ADDRESS_VARIES.
7761 (PURE_P): Use a more-efficient implementation that needs just one
7762 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7763 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7764 to 4 (xorl, subq, cmpq, setbe).
7765 * alloc.c (pure): Always extern now, since that's the
7766 VIRT_ADDR_VARIES behavior.
7767 (PURE_POINTER_P): Use a single comparison, not two, for
7768 consistency with the new puresize.h.
7769 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7770 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7771 Remove VIRT_ADDR_VARIES no longer needed.
7772
f8fe6f96
EZ
77732011-11-19 Eli Zaretskii <eliz@gnu.org>
7774
7775 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7776 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7777 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7778 behave as if the cursor position were at the window margin.
7779
7780 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7781 and the cursor position is out of bounds, behave as if the cursor
7782 position were at the window margin. (Bug#10075)
7783
df05a53c
CY
77842011-11-18 Chong Yidong <cyd@gnu.org>
7785
7786 * window.c (Fwindow_combination_limit): Make first argument
7787 non-optional, since it is meaningless for live windows like the
7788 selected window.
61ccba97 7789
2071918e
DA
77902011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7791
7792 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7793
b50a28de
SM
77942011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7795
7796 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7797 (graft_intervals_into_buffer): Simplify.
7798
015137db
EZ
77992011-11-18 Eli Zaretskii <eliz@gnu.org>
7800
7801 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7802 hash values of the two rows.
7803 (copy_row_except_pointers): Preserve the used[] arrays and the
7804 hash values of the two rows. (Bug#10035)
68c95424 7805 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7806
7807 * xdisp.c (row_hash): New function, body extracted from
7808 compute_line_metrics.
7809 (compute_line_metrics): Call row_hash, instead of computing the
7810 hash code inline.
7811
7812 * dispnew.c (verify_row_hash): Call row_hash for computing the
7813 hash code of a row, instead of duplicating code from xdisp.c.
7814
7815 * dispextern.h (row_hash): Add prototype.
7816
a2addb04
TH
78172011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7818
7819 * frame.c (delete_frame): Don't delete the terminal when the last
7820 X frame is closed if emacs is built with GTK toolkit.
7821
df85d315
JB
78222011-11-17 Juanma Barranquero <lekktu@gmail.com>
7823
7824 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7825
a0c2d0ae
MR
78262011-11-17 Martin Rudalics <rudalics@gmx.at>
7827
7828 * window.c (Vwindow_splits): Rename to
7829 Vwindow_combination_resize. Suggested by Juri Linkov.
7830 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7831 of Vwindow_splits.
7832
58179cce
JB
78332011-11-16 Juanma Barranquero <lekktu@gmail.com>
7834
7877f373
JB
7835 * nsfns.m (Fns_font_name):
7836 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7837
b6f67890
MR
78382011-11-16 Martin Rudalics <rudalics@gmx.at>
7839
7840 * window.h (window): Rename slot "nest" to "combination_limit".
7841 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7842 (Fset_window_nest): Rename to Fset_window_combination_limit.
7843 (Vwindow_nest): Rename to Vwindow_combination_limit.
7844 (recombine_windows, make_parent_window, make_window)
7845 (Fsplit_window_internal, saved_window)
7846 (Fset_window_configuration, save_window_save): Rename all
7847 occurrences of window_nest to window_combination_limit.
7848
c7015153
JB
78492011-11-15 Juanma Barranquero <lekktu@gmail.com>
7850
7851 * image.c (imagemagick_load_image): Fix typo.
7852
322ad6ec
EZ
78532011-11-14 Eli Zaretskii <eliz@gnu.org>
7854
7855 * xdisp.c (display_line): Move the call to
7856 highlight_trailing_whitespace before the call to
7857 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7858 faces of all the glyphs to compute ROW's hash value.
7859 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7860
f067b8ec
JB
78612011-11-14 Juanma Barranquero <lekktu@gmail.com>
7862
7863 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7864 just return (bug#10044).
7865
1e5b2111
EZ
78662011-11-12 Eli Zaretskii <eliz@gnu.org>
7867
7ef3cbd5
EZ
7868 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7869 with user-defined heap size. Bump the default size of the temacs
7870 heap to 27MB, to avoid memory warning when running temacs.
7871 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7872
1e5b2111
EZ
7873 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7874 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7875 (verify_row_hash) [XASSERTS]: New function.
7876 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7877 that the hash value of glyph rows is correct.
1e5b2111 7878
89d61221
MR
78792011-11-12 Martin Rudalics <rudalics@gmx.at>
7880
7881 * window.h (window): Remove splits slot.
7882 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7883 (Fdelete_other_windows_internal, make_parent_window)
7884 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7885 (Fset_window_configuration, save_window_save): Don't deal with
7886 split status of windows.
7887 (saved_window): Remove splits slot.
7888 (Vwindow_splits): Rewrite doc-string.
7889
97f18cc8
JD
78902011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7891
7892 * xfns.c (unwind_create_frame):
7893 * nsfns.m (unwind_create_frame):
7894 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7895 Vframe_list (Bug#9999).
7896
22a648b4
DA
78972011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7898
0b381c7e 7899 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7900
659afede
KH
79012011-11-11 Kenichi Handa <handa@m17n.org>
7902
7903 * callproc.c (Fcall_process): Set the member dst_multibyte of
7904 process_coding.
7905
9ac0394b
KH
79062011-11-11 Johan Bockgård <bojohan@gnu.org>
7907
7908 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7909 avoid a crash (bug#9496).
7910
2fbdc249
CY
79112011-11-09 Chong Yidong <cyd@gnu.org>
7912
7913 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7914 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7915
ac6b1f81
PE
79162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7917
7918 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7919
09db192c
PE
79202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7921
7922 Avoid some portability problems by eschewing 'extern inline' functions.
7923 The trivial performance wins aren't worth the portability hassles; see
7924 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7925 et seq.
7926 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7927 (window_box_width, window_box_left, window_box_left_offset)
7928 (window_box_right, window_box_right_offset): Undo previous change,
7929 by removing the "extern"s.
7930 * intervals.c (adjust_intervals_for_insertion)
7931 (adjust_intervals_for_deletion): Undo previous change,
7932 making these static again.
7933 (offset_intervals, temp_set_point_both, temp_set_point)
7934 (copy_intervals_to_string): No longer inline.
7935 * xdisp.c (window_text_bottom_y, window_box_width)
7936 (window_box_height, window_box_left_offset)
7937 (window_box_right_offset, window_box_left, window_box_right)
7938 (window_box): No longer inline.
7939
105216ed
CY
79402011-11-08 Chong Yidong <cyd@gnu.org>
7941
7942 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7943 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7944 Signal an error if not a live window.
105216ed
CY
7945 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7946 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7947
ae9e237f
JB
79482011-11-07 Juanma Barranquero <lekktu@gmail.com>
7949
7950 * lisp.h (syms_of_abbrev): Remove declaration.
7951 Reported by CHENG Gao <chenggao@royau.me>.
7952
c7aa8333
EZ
79532011-11-07 Eli Zaretskii <eliz@gnu.org>
7954
7955 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7956 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7957 of temacs in GUI mode.
7958
be7f5545
MR
79592011-11-07 Martin Rudalics <rudalics@gmx.at>
7960
7961 * window.h: Declare delete_all_child_windows instead of
7962 delete_all_subwindows.
7963 * window.c (Fwindow_nest, Fset_window_nest)
7964 (Fset_window_new_total, Fset_window_new_normal)
7965 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7966 (delete_all_subwindows): Rename to delete_all_child_windows.
7967 (Fdelete_other_windows_internal, Fset_window_configuration):
7968 Call delete_all_child_windows instead of delete_all_subwindows.
7969 * frame.c (delete_frame): Call delete_all_child_windows instead
7970 of delete_all_subwindows.
7971
ca78dc43
PE
79722011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7973
7974 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7975 This is also needed for porting to any host where GC_MARK_STACK is
7976 not GC_MAKE_GCPROS_NOOPS.
7977 (which_symbols): Use it.
7978
a0241d01
KH
79792011-11-07 Kenichi Handa <handa@m17n.org>
7980
7981 * coding.c (coding_set_destination): Check coding->src_pos only
7982 when coding->src_object is a buffer (bug#9910).
7983
7984 * process.c (send_process): Set the member src_multibyte of coding
7985 to 0 (bug#9911) when sending a unibyte text.
7986
7987 * callproc.c (Fcall_process): Set the member src_multibyte of
7988 process_coding to 0 (bug#9912).
7989
a64bfdfa 79902011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7991
7992 * xmenu.c (cleanup_widget_value_tree): New function.
7993 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7994 calling free_menubar_widget_value_tree directly (Bug#9830).
7995
cb41b32a
PE
79962011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7997
7998 Fix some portability problems with 'inline'.
7999 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8000 (window_box_width, window_box_left, window_box_left_offset)
8001 (window_box_right, window_box_right_offset): Declare extern.
8002 Otherwise, these inline functions do not conform to C99 and
8003 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8004 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8005 * intervals.c (adjust_intervals_for_insertion)
8006 (adjust_intervals_for_deletion): Now extern, because otherwise the
8007 extern inline functions 'offset_intervals' couldn't refer to it.
8008 (static_offset_intervals): Remove.
8009 (offset_intervals): Rewrite using the old contents of
8010 static_offset_intervals. The old version didn't conform to C99
8011 because an extern inline function contained a reference to an
8012 identifier with static linkage.
8013
b7041366
AS
80142011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8015
8016 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8017 GC.
8018
88a37c4d
EZ
80192011-11-06 Eli Zaretskii <eliz@gnu.org>
8020
8021 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8022 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8023 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8024 return Qleft_to_right.
8025
49745b39
CY
80262011-11-06 Chong Yidong <cyd@gnu.org>
8027
8028 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8029 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8030 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8031 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8032 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8033 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8034 (Fwindow_vscroll): Doc fix.
8035 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8036 argument, since it makes no sense to pass a live window and for
8037 consistency with window-child.
8038
1f05cd82
CS
80392011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8040
8041 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8042 support MSVC.
8043
22610910
JR
80442011-11-05 Jason Rumney <jasonr@gnu.org>
8045
8046 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8047 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8048 fonts (Bug#6029).
8049 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8050 bitwise arithmetic preventing use of unicode-sip and non-truetype
8051 opentype fonts.
8052
a06776b2
EZ
80532011-11-05 Eli Zaretskii <eliz@gnu.org>
8054
3ad924ba
EZ
8055 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8056 "emacs"-only part.
8057
a06776b2
EZ
8058 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8059 initialization code to keep similarity to xfns.c after changes
8060 from 2011-11-05.
8061
c9e7db78
JD
80622011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8063
a97f8f3f
JD
8064 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8065 (unwind_create_frame): New function (Bug#9943).
8066 (Fx_create_frame): Restructure code to be more similar to the one in
8067 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8068 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8069 Move terminal->reference_count++ just before making the frame official
8070 (Bug#9943).
8071
8072 * nsterm.m (x_free_frame_resources): New function.
8073 (x_destroy_window): Move code to x_free_frame_resources.
8074
c9e7db78 8075 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8076 (Fx_create_frame, x_create_tip_frame):
8077 Move terminal->reference_count++ just before making the frame
75f1671a 8078 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8079 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8080
a6fc3b5c
EZ
80812011-11-05 Eli Zaretskii <eliz@gnu.org>
8082
8083 Support MSVC build with newer versions of Visual Studio.
8084 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8085 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8086 nt/gmake.defs.
8087
8088 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8089 which are not supported by MSVC.
8090 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8091 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8092 bitfields.
8093 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8094 types in bitfields.
8095 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8096
8097 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8098
58179cce 80992011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8100
8101 Support MSVC build with newer versions of Visual Studio.
8102 * w32.c: Don't include w32api.h for MSVC.
8103 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8104
8105 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8106 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8107 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8108 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8109 e_* cousins.
8110 (alloca) [_MSC_VER]: Define to _alloca.
8111
8112 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8113
8114 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8115
a58c13ed
EZ
81162011-11-04 Eli Zaretskii <eliz@gnu.org>
8117
8118 * xdisp.c (note_mouse_highlight): If either of
8119 previous/next-single-property-change returns nil, treat that as
8120 the beginning or the end of the buffer. (Bug#9955)
8121
fe0b6370
JD
81222011-11-04 Jan Djärv <jan.h.d@swipnet.se>
8123
a58c13ed 8124 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8125 label is not null (Bug#9951).
8126 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8127 may be NULL.
8128
89bd5ee1
EZ
81292011-11-04 Eli Zaretskii <eliz@gnu.org>
8130
8131 * window.c (Fwindow_body_size): Mention in the doc string that the
8132 return value is in frame's canonical units. (Bug#9949)
8133
84c3edb9
EZ
81342011-11-03 Eli Zaretskii <eliz@gnu.org>
8135
4e2fb5c7
EZ
8136 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8137
84c3edb9 8138 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8139 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8140 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8141
bc17a887
EZ
81422011-11-01 Eli Zaretskii <eliz@gnu.org>
8143
8144 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8145 Don't stop backward scan on the continuation glyph, even though
8146 its CHARPOS is positive.
6d5eb5b0
SM
8147 (mouse_face_from_buffer_pos, note_mouse_highlight):
8148 Rename cover_string to disp_string.
bc17a887 8149
4ee88440
MR
81502011-11-01 Martin Rudalics <rudalics@gmx.at>
8151
8152 * window.c (temp_output_buffer_show): Don't use
8153 Vtemp_buffer_show_specifiers.
8154 (Vtemp_buffer_show_specifiers): Remove unused variable.
8155
c2ff3c02
EZ
81562011-10-30 Eli Zaretskii <eliz@gnu.org>
8157
8158 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8159 past the beginning of the current glyph matrix.
8160
58179cce 81612011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8162
8163 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8164 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8165 HAVE_GTK3 (Bug#9869).
b77a6a7f 8166
3b574623
JD
8167 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8168 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8169
b77a6a7f
JD
8170 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8171
8172 * xterm.c: Declare x_handle_net_wm_state to return int.
8173 (handle_one_xevent): Check if we are iconified but don't have
8174 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8175 (get_current_wm_state): Return non-zero if not hidden,
8176 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8177 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8178 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8179 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8180
196e41e4
PE
81812011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8182
8183 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8184 so that this new function doesn't get optimized away by a
8185 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8186
021f2e1a
AS
81872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8188
8189 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8190
8b058d44
EZ
81912011-10-29 Eli Zaretskii <eliz@gnu.org>
8192
8193 Fix the `xbytecode' command.
8194 * .gdbinit (xprintbytestr): New command.
b50a28de 8195 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8196 (xbytecode): Print the byte-code string as well.
8197
4452fb80
EZ
81982011-10-29 Kim Storm <storm@cua.dk>
8199
8b058d44
EZ
8200 * alloc.c (which_symbols): New function.
8201
21b72067
AS
82022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8203
8204 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8205 line. (Bug#9903)
8206
83ed7b5c
GM
82072011-10-29 Glenn Morris <rgm@gnu.org>
8208
8209 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8210 Not clear what it was for, and it causes various bugs. (Bug#9839)
8211
5a7a728b
EZ
82122011-10-28 Eli Zaretskii <eliz@gnu.org>
8213
8214 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
8215 possible random value that matches one of those tested as
8216 condition to clear the mouse face.
8217
d3d0842f
CY
82182011-10-28 Chong Yidong <cyd@gnu.org>
8219
8220 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
8221
31b39d13
DN
82222011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
8223
8224 * window.c (make_window): Initialize phys_cursor_on_p.
8225
9aba6043
SM
82262011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
8227
8228 * lisp.h (struct Lisp_Symbol): Update comments.
8229
c20992f4
JB
82302011-10-28 Juanma Barranquero <lekktu@gmail.com>
8231
8232 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
8233
db4f02f2
EZ
82342011-10-28 Eli Zaretskii <eliz@gnu.org>
8235
8236 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8237 <oslsachem@gmail.com> for helping to debug this.
8238
8239 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
8240 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
8241 (g_b_init_get_glyph_outline_w): New static variables.
8242 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
8243 (GetGlyphOutlineW_Proc): New typedefs.
8244 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
8245 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
8246 New functions.
8247 (w32font_open_internal, compute_metrics):
8248 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
8249 instead of calling the "wide" APIs directly.
8250
8251 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
8252
8253 * w32.h (syms_of_w32font): Add prototype.
8254
87e68db4
JB
82552011-10-27 Juanma Barranquero <lekktu@gmail.com>
8256
8257 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
8258 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
8259 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
8260 (Fmove_to_window_line): Doc fix.
8261
435c1d67
CY
82622011-10-27 Chong Yidong <cyd@gnu.org>
8263
8264 * process.c (make_process): Set gnutls_state to NULL.
8265
8266 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
8267 non-NULL, regardless of GNUTLS_INITSTAGE.
8268 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8269 an error. Set process slots as soon as we allocate them.
8270
8271 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
8272
9c6c6f49
CY
82732011-10-27 Chong Yidong <cyd@gnu.org>
8274
9aba6043
SM
8275 * gnutls.c (emacs_gnutls_deinit): New function.
8276 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
8277 (Fgnutls_deinit, Fgnutls_boot): Use it.
8278
8279 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8280 (deactivate_process): Call emacs_gnutls_deinit.
8281
657d08d3
JB
82822011-10-27 Juanma Barranquero <lekktu@gmail.com>
8283
8284 * image.c (x_create_x_image_and_pixmap):
8285 * w32.c (sys_rename, w32_delayed_load):
8286 * w32font.c (fill_in_logfont):
8287 * w32reg.c (x_get_string_resource): Silence compiler warnings.
8288
5430d399
JB
82892011-10-26 Juanma Barranquero <lekktu@gmail.com>
8290
8291 * w32fns.c (w32_default_color_map): New function,
8292 extracted from Fw32_default_color_map.
a7ef684b 8293 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 8294
fe0055fa
PE
82952011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8296
8297 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
8298
e6346438
SM
82992011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
8300
8301 * keyboard.c (test_undefined): New function (bug#9751).
8302 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
8303
e112cc37
ET
83042011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
8305
8306 * sysdep.c (init_sys_modes): Fix the check for the controlling
8307 terminal (Bug#6649).
8308
7b5d6677
EZ
83092011-10-20 Eli Zaretskii <eliz@gnu.org>
8310
8311 * dispextern.h (struct bidi_it): New member next_en_type.
8312
8313 * bidi.c (bidi_line_init): Initialize the next_en_type member.
8314 (bidi_resolve_explicit_1): When next_en_pos is valid for the
8315 current character, check also for next_en_type being WEAK_EN.
8316 (bidi_resolve_weak): Don't enter the expensive loop if the current
8317 position is before next_en_pos. Record the bidi type of the first
8318 non-ET, non-BN character we find, in addition to its position.
8319 (bidi_level_of_next_char): Invalidate next_en_type when
8320 next_en_pos is over-stepped.
8321
7da0b018
PE
83222011-10-20 Paul Eggert <eggert@cs.ucla.edu>
8323
8324 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
8325 * editfns.c: Rewrite current-time-zone so that it invokes
8326 the equivalent of (format-time-string "%Z") to get the time zone name.
8327 This fixes a bug when the time zone name contains characters that
8328 need converting from the system time locale to Emacs internal format.
8329 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
8330 that patch fixed format-time-string to do the conversion, but
8331 I forgot to fix current-time-zone.
8332 (format_time_string): New function, containing most of
8333 what Fformat_time_string used to contain.
8334 (Fformat_time_string): Rewrite in terms of format_time_string.
8335 This doesn't change this function's behavior.
8336 (current-time-zone): Rewrite to use format_time_string.
8337 This fixes the bug reported by Michael Schierl in
8338 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
8339 Jason Rumney's 2007-06-07 change worked around this bug, but
8340 didn't fix it.
8341 * systime.h (tzname, timezone): Remove no-longer-used declarations.
8342
8547b010
EZ
83432011-10-19 Eli Zaretskii <eliz@gnu.org>
8344
8345 * xdisp.c (start_display): If the character at POS is displayed
8346 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
8347 (try_window_reusing_current_matrix): If a line ends in a display
8348 vector or the next line starts in a display vector, continue
8349 redrawing the window even though the character position of
8350 start_row was reached.
8547b010
EZ
8351 (Bug#9771, part 2)
8352
4e948d15
CY
83532011-10-18 Chong Yidong <cyd@gnu.org>
8354
8355 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
8356 with nobreak-char-display too.
8357
4787455f
EZ
83582011-10-18 Eli Zaretskii <eliz@gnu.org>
8359
8360 Fix part 3 of bug#9771.
8361 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
8362 (bidi_resolve_neutral): Don't enter the expensive loop looking for
8363 non-neutral characters if the current character is a paragraph
8364 separator (a.k.a. Newline). This avoids running the same
8365 expensive loop twice, once when we consume the preceding newline
8366 and the other time when the line actually needs to be displayed.
8367 Avoid the loop when we see neutrals on the base embedding level
8368 following a character whose directionality is the same as the
8369 paragraph's. This avoids running the expensive loop when a line
8370 ends in a long sequence of neutrals, like control characters.
8371 Add assertion against STRONG_AL type. Slightly rearrange code
8372 that determines the type of a neutral given the first non-neutral
8373 that follows it.
8374 (bidi_level_of_next_char): Set next_en_pos to zero when
8375 invalidating its info.
8376
2c91f553
EZ
83772011-10-17 Eli Zaretskii <eliz@gnu.org>
8378
8379 * xdisp.c (push_display_prop): Determine whether to record string
8380 or buffer position by IT->string, not by IT->method. Allow
8381 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
8382 (move_it_vertically_backward): Don't look for character position
8383 immediately after the newline when in a continuation line.
8384 (Bug#9771, part 1)
2c91f553 8385
c7b08b0d
MR
83862011-10-15 Martin Rudalics <rudalics@gmx.at>
8387
8388 * window.c (coordinates_in_window): Rewrite and delabelize
8389 vertical border check. (Bug#5357) (Bug#9618)
8390
6b02f655
SM
83912011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
8392
8393 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
8394 errors in XSetWindowBorder (bug#9310).
8395
81d40c92
DA
83962011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
8397
8398 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
8399 avoid crash when xmalloc overrun checking is enabled.
8400
d4172c3b
EZ
84012011-10-13 Eli Zaretskii <eliz@gnu.org>
8402
8403 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
8404 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
8405 cursor motion with <left> and <right> arrow keys.
8406
8407 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8408 some callers set that themselves.
8409
b00eea75
EZ
84102011-10-12 Eli Zaretskii <eliz@gnu.org>
8411
8412 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
8413 display string and the previous row comes from the same string and
8414 is empty. (Bug#9739) (Bug#9738)
8415
8fe012c4
SM
84162011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8417
8418 * doc.c (get_doc_string): Encode file name (bug#9735).
8419
0074aef2
EZ
84202011-10-12 Eli Zaretskii <eliz@gnu.org>
8421
79beb178
EZ
8422 * bidi.c (bidi_level_of_next_char):
8423 * xdisp.c (get_visually_first_element): Remove old incorrect
8424 comments regarding the Unicode Line Separator character.
8425
0074aef2
EZ
8426 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
8427
6e4b3fbe
DA
84282011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
8429
8430 * alloc.c (Fgc_status): Do not access beyond zombies array
8431 boundary if nzombies > MAX_ZOMBIES.
8432 * alloc.c (dump_zombies): Add missing format specifier.
8433
0324f3af
PE
84342011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8435
b5525cac
PE
8436 * xdisp.c (set_cursor_from_row): Simplify conditionals,
8437 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
8438
0324f3af
PE
8439 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
8440 Some packages use them to denote characters with modifiers.
8441
e9b5f888
AS
84422011-10-11 Andreas Schwab <schwab@linux-m68k.org>
8443
8444 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
8445 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
8446 matching a pp-number. Rename parameter var to var1.
8447
127827c0
SM
84482011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8449
8450 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
8451
c8fd3bd0
GM
84522011-10-08 Glenn Morris <rgm@gnu.org>
8453
8454 * callint.c (Fcall_interactively): Give a more explicit error for the
8455 'c' case with a non-character input. (Bug#8479)
8456
352ec8ff
EZ
84572011-10-08 Eli Zaretskii <eliz@gnu.org>
8458
03669ccb
EZ
8459 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
8460 lines.
7061c986
EZ
8461 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
8462 lines that are hscrolled on the left.
03669ccb 8463
352ec8ff
EZ
8464 * dispnew.c (buffer_posn_from_coords): Account for a possible
8465 presence of header-line. (Bug#4426)
8466
a66cfb1c
SM
84672011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
8468
6b02f655
SM
8469 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
8470 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 8471
7c5ee88e
PE
84722011-10-07 Paul Eggert <eggert@cs.ucla.edu>
8473
8474 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
8475 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
8476 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
8477 this makes Emacs dump core during garbage collection on rare
8478 occasions. sizeof is obviously inferior to offsetof here, so
8479 stick with offsetof.
8480 (GC_POINTER_ALIGNMENT): New macro.
8481 (mark_memory): Omit 3rd (offset) arg; caller changed.
8482 Don't assume EMACS_INT alignment is the same as pointer alignment.
8483
df1bbe5b
SM
84842011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
8485
8486 * keyboard.c (read_key_sequence_remapped): New var.
8487 (read_key_sequence): Compute remapping in the right buffer.
8488 (command_loop_1): Use read_key_sequence's remapping directly.
8489
51553db6
SM
84902011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
8491
32c1fffd
SM
8492 * dired.c (file_name_completion): Don't expand file name.
8493 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8494 before checking file name handler.
8495
51553db6
SM
8496 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8497 they've been requested explicitly (bug#9591).
8498
b6bd1599 84992011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8500
8501 * keymap.c (Fsingle_key_description): Use make_specified_string
8502 instead of build_string to build string from push_key_description.
8503 (Bug#5193)
8504
f701dc2a
PE
85052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8506
4222c55d
PE
8507 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8508 This fixes a Y2038 bug on 64-bit hosts.
8509 * buffer.c (reset_buffer):
8510 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8511 (Fclear_buffer_auto_save_failure):
8512 Use 0, not -1, to represent an unset failure time, since time_t
8513 might not be signed.
8514
f701dc2a
PE
8515 Remove dependency on glibc malloc internals.
8516 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8517 Move back here from lisp.h, but with their new implementations.
8518 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8519 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8520 * charset.c (charset_table_init): New static var.
8521 (syms_of_charset): Use it instead of xmalloc. This removes a
8522 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8523 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8524 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8525 Move back to alloc.c.
8526 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8527 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8528
9ceebf39
JD
85292011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8530
8531 * nsterm.m (windowDidResize): Call x_set_window_size only when
8532 ns_in_resize is true. Otherwise set pixelwidth/height and
8533 call change_frame_size (Bug#9628).
8534
cb993c58
PE
85352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8536
3930c88b
PE
8537 Port --enable-checking=all to Fedora 14 x86-64.
8538 * charset.c (syms_of_charset): Also account for glibc malloc's
8539 internal overhead when calculating the initial malloc maximum.
8540
cb993c58
PE
8541 Port --enable-checking=all to Fedora 14 x86.
8542 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8543 Move to lisp.h.
8544 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8545 (overrun_check_realloc, overrun_check_free):
8546 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8547 That way, xmalloc returns a properly-aligned pointer even if
8548 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8549 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8550 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8551 into account when calculating the initial malloc maximum.
8552 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8553 Move here from alloc.c, so that charset.c can use it too.
8554 Properly align; the old code wasn't right for common 32-bit hosts
8555 when configured with --enable-checking=all.
8556 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8557 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8558
31bed486
EZ
85592011-09-29 Eli Zaretskii <eliz@gnu.org>
8560
04c70788 8561 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8562 use EDOM.
8563
fbcaa2f3
EZ
85642011-09-28 Eli Zaretskii <eliz@gnu.org>
8565
8566 * xdisp.c (compute_display_string_end): If there's no display
8567 string at CHARPOS, return -1.
8568
8569 * bidi.c (bidi_fetch_char): When compute_display_string_end
8570 returns a negative value, treat the character as a normal
8571 character not covered by a display string. (Bug#9624)
8572
a239d4e9
JB
85732011-09-28 Juanma Barranquero <lekktu@gmail.com>
8574
8575 * lread.c (Fread_from_string): Fix typo in docstring.
8576
88652fd5
EZ
85772011-09-27 Eli Zaretskii <eliz@gnu.org>
8578
8579 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8580 newline, reseat the iterator instead of bidi-iterating there one
8581 character at a time. (Bug#9610)
32c1fffd
SM
8582 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8583 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8584
ed497dd4
AS
85852011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8586
8587 * lread.c (readevalloop): Use correct code for NBSP.
8588 (read1): Likewise. (Bug#9608)
8589
b2bf61aa
MA
85902011-09-25 Michael Albinus <michael.albinus@gmx.de>
8591
8592 * dbusbind.c (Fdbus_register_signal): When service is not
8593 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8594
32bbb17c
GM
85952011-09-25 Glenn Morris <rgm@gnu.org>
8596
8597 * buffer.c (truncate-lines): Doc fix.
8598
94e0933e
CY
85992011-09-24 Chong Yidong <cyd@stupidchicken.com>
8600
8601 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8602 (Fset_window_next_buffers): Doc fix.
8603
cddde921
GM
86042011-09-24 Glenn Morris <rgm@gnu.org>
8605
8606 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8607
1260aef1
PE
86082011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8609
25b4bfa0
PE
8610 Fix minor problems found by static checking.
8611 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8612 * indent.c (Fvertical_motion): Fix == vs = typo.
8613
e3cbd34b
EZ
86142011-09-24 Eli Zaretskii <eliz@gnu.org>
8615
a66cfb1c
SM
8616 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8617 Default value is now t. Doc fix.
6bf7006f 8618
e3cbd34b 8619 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8620 logic when moving up, not only when moving down. Fix the
e3cbd34b 8621 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8622 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8623
8624 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8625 CHARPOS is covered by a display string which includes newlines.
8626 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8627 is covered by a display string with embedded newlines.
8628
a3de0cbd
MA
86292011-09-24 Michael Albinus <michael.albinus@gmx.de>
8630
8631 * dbusbind.c (Fdbus_register_signal): Add match rule to
8632 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8633 (Fdbus_register_method, Vdbus_registered_objects_table):
8634 Fix docstring.
a3de0cbd 8635
b260039d
JM
86362011-09-24 Jim Meyering <meyering@redhat.com>
8637
32c1fffd 8638 do not ignore write error for any output size
b260039d
JM
8639 The previous change was incomplete.
8640 While it makes emacs --batch detect the vast majority of stdout
8641 write failures, errors were still ignored whenever the output size is
8642 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8643 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8644 && echo FAIL: ignored write error
8645 FAIL: ignored write error
8646 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8647 && echo FAIL: ignored write error
8648 FAIL: ignored write error
8649 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8650
8eca8a7c
AS
86512011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8652
8653 * emacs.c (Fkill_emacs): In noninteractive mode exit
8654 non-successfully if a write error occurred on stdout. (Bug#9574)
8655
3341db62
EZ
86562011-09-21 Eli Zaretskii <eliz@gnu.org>
8657
8658 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8659 the xassert test.
8660
8661 * dispextern.h (struct it): Update the comment documenting what
8662 can it->OBJECT be.
8663
8c203dbf
EZ
86642011-09-20 Eli Zaretskii <eliz@gnu.org>
8665
8666 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8667 a display string, extend search for cursor position to end of row.
8668 (find_row_edges): If the row ends in a newline from a display
8669 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8670 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8671 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8672 non-empty line. Fixes confusing cursor motion with arrow keys at
8673 the beginning of a line that starts with whitespace.
8c203dbf 8674
a4824228
LMI
86752011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8676
8677 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8678 (bug#9493).
8679
33ed493b
CY
86802011-09-18 Chong Yidong <cyd@stupidchicken.com>
8681
8682 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8683 boolean (Bug#9154).
8684
56cd55c8
EZ
86852011-09-18 Eli Zaretskii <eliz@gnu.org>
8686
8687 * xdisp.c (display_line): Record maximum and minimum buffer
8688 positions even if no glyphs were produced (e.g., by a zero-width
8689 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8690 buffer positions that will be removed from the glyph row because
8691 they don't fit.
c02dcedf
EZ
8692 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8693 column is beyond frame width: don't subtract 1 "pixel" when
8694 computing width of the stretch.
3e62b7e0
EZ
8695 (reseat_at_next_visible_line_start): Undo the change made on
8696 2011-09-17 that saved paragraph information and restored it after
8697 the call to `reseat'. (Bug#9545)
56cd55c8 8698
5ed99d36 86992011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8700
8701 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8702 and turn window cursor on if cleared (Bug#9415).
8703
5ed99d36 87042011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8705
8706 * search.c (boyer_moore): Take unibyte characters from pattern
8707 literally. (Bug#9458)
8708
9bade7b2
EZ
87092011-09-18 Eli Zaretskii <eliz@gnu.org>
8710
8711 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8712
e5e9d610
PE
87132011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8714
87e4427a
PE
8715 Fix minor problem found by static checking.
8716 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8717 initialized, to pacify gcc -Wuninitialized.
8718
e5e9d610
PE
8719 * fileio.c: Report proper errno when syscall falls.
8720 (Finsert_file_contents): Save and restore errno,
8721 so that report_file_error outputs the correct diagnostic.
8722 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8723
a1674f0b
EZ
87242011-09-18 Eli Zaretskii <eliz@gnu.org>
8725
8726 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8727
fbfb6dd4
EZ
87282011-09-17 Eli Zaretskii <eliz@gnu.org>
8729
8730 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8731 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8732
bb187662
EZ
87332011-09-17 Eli Zaretskii <eliz@gnu.org>
8734
1137e8b8 8735 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8736 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8737
8738 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8739 (bidi_find_paragraph_start): Search back for paragraph beginning
8740 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8741 (bidi_move_to_visually_next): Only trigger paragraph-related
8742 computations when the last character is a newline or at EOB, not
8743 just any NEUTRAL_B. (Bug#9470)
8744
bb187662
EZ
8745 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8746 truncated lines if point is covered by a display string. (Bug#9524)
8747
2e621251
PE
87482011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8749
8750 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8751 (cons_to_x_long): New function.
8752 (lisp_data_to_selection_data): Use it. Correct the test for
8753 short-versus-long data; it was negated. Break out of vector
8754 loop, for efficiency, when a long datum is discovered.
8755
91a15bc6
SM
87562011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8757
8758 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8759
b41c3a35
EZ
87602011-09-16 Eli Zaretskii <eliz@gnu.org>
8761
8762 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8763 GCC PR/17406) by declaring this function with external scope.
8764
7812ba2d
PE
87652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8766
8767 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8768 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8769
cf7edc2a
AS
87702011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8771
8772 * editfns.c (Fformat): Correctly handle text properties on "%%".
8773
bd01620e
EZ
87742011-09-15 Eli Zaretskii <eliz@gnu.org>
8775
8776 * xterm.c (x_draw_composite_glyph_string_foreground):
8777 * w32term.c (x_draw_composite_glyph_string_foreground):
8778 * term.c (encode_terminal_code):
8779 * composite.c (composition_update_it, get_composition_id):
8780 * xdisp.c (get_next_display_element)
8781 (fill_composite_glyph_string): Add comments about special meaning
8782 of TAB characters in a composition.
8783
a02719a3
PE
87842011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8785
8786 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8787 This occurs when processing a multibyte format.
8788 Problem reported by Wolfgang Jenker.
a02719a3 8789
72589a3c
JB
87902011-09-15 Johan Bockgård <bojohan@gnu.org>
8791
8792 * xdisp.c (try_cursor_movement): Only check for exact match if
8793 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8794
1c14176c
PE
87952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8796
8797 Remove unused external symbols.
8798 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8799 * xdisp.c (calc_pixel_width_or_height): Now static.
8800 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8801 * indent.c (check_display_width):
8802 * w32term.c: Fix comment to match code.
8803 * xterm.c, xterm.h (x_catching_errors): Remove.
8804
d2eea5b5
PE
88052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8806
8807 * xselect.c: Use signed conversions more consistently (Bug#9498).
8808 (selection_data_to_lisp_data): Assume incoming selection data are
8809 signed integers, not unsigned. This is to be consistent with
8810 outgoing selection data, which was modified to use signed integers
8811 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8812 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8813 expects long, not unsigned long.
8814
46888499
EZ
88152011-09-14 Eli Zaretskii <eliz@gnu.org>
8816
8817 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8818 computation of loop end. Reported by Johan Bockgård
8819 <bojohan@gnu.org>.
8820
ef8ef9fb
CY
88212011-09-13 Chong Yidong <cyd@stupidchicken.com>
8822
8823 * frame.c (Fother_visible_frames_p): Function deleted.
8824
fa819fed
EZ
88252011-09-12 Eli Zaretskii <eliz@gnu.org>
8826
8827 * indent.c (compute_motion): Process display vector front to back
8828 rather than the other way around. (Bug#2496)
8829
2ba8e008
SM
88302011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8831
8832 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8833
20f53c69
CY
88342011-09-11 Chong Yidong <cyd@stupidchicken.com>
8835
8836 * minibuf.c (Fread_from_minibuffer): Doc fix.
8837
d562d7a4
EZ
88382011-09-11 Eli Zaretskii <eliz@gnu.org>
8839
8840 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8841 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8842
1c4d7f3d
LMI
88432011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8844
8845 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8846 value for non-existent files.
8847
b885bf36
EZ
88482011-09-11 Eli Zaretskii <eliz@gnu.org>
8849
8850 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8851 set its "size" to -1. This will set the modtime_size field of
8852 the corresponding buffer to -1, which is what
8853 verify-visited-file-modtime expects for files that do not exist.
8854 (Bug#9139)
8855
6612f0bf
PE
88562011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8857
8858 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8859 here ...
8860 * lisp.h: ... from here. push_key_description is no longer
8861 defined in keyboard.c, so its declaration should not be in
8862 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8863 logically belongs with push_key_description.
8864
dfb3f755
PE
88652011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8866
8867 * buffer.h: Include <sys/types.h> instead of <time.h>.
8868 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8869 Problem reported by Herbert J. Skuhra.
8870
3134906c
LMI
88712011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8872
8873 * xml.c (parse_region): Make the parsing work for
8874 non-comment-starting XML files again (bug#9144).
8875
8d903f4e
AS
88762011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8877
8878 * image.c (gif_load): Fix calculation of bottom and right corner.
8879 (Bug#9468)
8880
80ad64f4
EZ
88812011-09-10 Eli Zaretskii <eliz@gnu.org>
8882
8883 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8884 redisplay in small windows.
8885
208a048d
EZ
88862011-09-09 Eli Zaretskii <eliz@gnu.org>
8887
8888 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8889
9b1c252e
MR
88902011-09-08 Martin Rudalics <rudalics@gmx.at>
8891
8892 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8893 Operate on live windows only.
8894
2949f33b
JB
88952011-09-08 Juanma Barranquero <lekktu@gmail.com>
8896
8897 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8898
e08dcafd
EZ
88992011-09-07 Eli Zaretskii <eliz@gnu.org>
8900
8901 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8902 only under bidi iteration.
8903
115b96bd
JD
89042011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8905
8906 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8907
c8199d0f
PE
89082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8909
8910 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8911 Without this fix, the command to link temacs failed due to an
8912 undefined symbol __builtin_isnan. This is because
8913 /usr/include/iso/math_c99.h #defines isnan(x) to
8914 __builtin_isnan(x), but the bundled gcc, which identifies itself
8915 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8916 a __builtin_isnan.
8917 * floatfns.c (isnan): #undef, and then #define to a clone of
8918 what's in data.c.
8919 (Fisnan): Always define, since it's always available now.
8920 (syms_of_floatfns): Always define isnan at the Lisp level.
8921
e39b275c 89222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8923
8924 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8925
b2db44d9 89262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8927
f4af5137 8928 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8929 The previous code assumed that file offsets (off_t values) fit in
8930 EMACS_INT variables, which is not true on typical 32-bit hosts.
8931 The code messed up by falsely reporting buffer overflow in cases
8932 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8933 when "big" contains more than 2**29 bytes, even though this
8934 inserts just one byte and does not overflow the buffer.
8935 (Finsert_file_contents): Store file offsets as off_t
8936 values, not as EMACS_INT values. Check for overflow when
8937 converting between EMACS_INT and off_t. When checking for
8938 buffer overflow or for overlap, take the offsets into account.
8939 Don't use EMACS_INT for small values where int suffices.
8940 When checking for overlap, fix a typo: ZV was used where
8941 ZV_BYTE was intended.
8942 (Fwrite_region): Don't assume off_t fits into 'long'.
8943 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8944
ecfc0a49
MA
89452011-09-05 Michael Albinus <michael.albinus@gmx.de>
8946
8947 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8948
6511acf2 89492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8950
0999621a 8951 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8952
8953 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8954 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8955 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8956 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8957 (modify_event_symbol): Do not assume that the length of
8958 name_alist_or_stem is safe to alloca and fits in int.
8959 (Fexecute_extended_command): Likewise for function name and binding.
8960 (Frecursion_depth): Wrap around reliably on integer overflow.
8961 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8962 since some callers pass EMACS_INT values.
8963 (Fsingle_key_description): Don't crash if symbol name contains more
8964 than MAX_ALLOCA bytes.
8965 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8966 (get_minibuffer): Arg is now EMACS_INT, not int.
8967 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8968 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8969 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8970
2be7d702
PE
8971 * dbusbind.c (signature_cat): New function.
8972 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8973 Do not overrun buffer; instead, report string overflow.
8974
9d1df220
PE
8975 * dispnew.c (add_window_display_history): Don't overrun buffer.
8976 Truncate instead; this is OK since it's just a log.
8977
33ef5c64
PE
8978 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8979 even if the time zone offset is outlandishly large.
8980 Don't mishandle offset == INT_MIN.
8981
66c6fdd5
PE
8982 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8983 when creating daemon; the previous buffer-overflow check was incorrect.
8984
d749b01b
PE
8985 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8986 which has the guts of the old verror function.
8987
b5cd1905
PE
8988 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8989 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8990
6e1a67fb
PE
8991 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8992 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8993 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8994 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8995 length of string rather than counting it via multiple sprintfs;
8996 that's simpler and more reliable.
c21721cc
PE
8997 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8998 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8999 sprintf, in case result does not fit in int.
9000
c57b67fc
PE
9001 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9002 (fontset_from_font): Print it.
9003
8a401434
PE
9004 * frame.c (tty_frame_count): Now printmax_t, not int.
9005 (make_terminal_frame, set_term_frame_name): Print it.
9006 (x_report_frame_params): In X, window IDs are unsigned long,
9007 not signed long, so print them as unsigned.
9008 (validate_x_resource_name): Check for implausibly long names,
9009 and don't assume name length fits in 'int'.
9010 (x_get_resource_string): Don't blindly alloca invocation name;
9011 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9012 not fit in int.
9013
6e1a67fb
PE
9014 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9015 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9016 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9017
0df02bf3
PE
9018 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9019 Use esprintf, not sprintf, in case result does not fit in int.
9020
48e30793
PE
9021 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9022 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9023 it as a large positive number.
9024 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9025 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9026
a66ff6d8
PE
9027 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9028 in case result does not fit in int.
9029
aca216ff
PE
9030 * print.c (float_to_string): Detect width overflow more reliably.
9031 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9032 buffer overrun. Don't assume list length fits in 'int'. Treat
9033 print length of 0 as 0, not as infinity; to be consistent with other
9034 uses of print length in this function. Don't overflow print length
9035 index. Don't assume hash table size fits in 'long', or that
9036 vectorlike size fits in 'unsigned long'.
9037
31c286f7
PE
9038 * process.c (make_process): Use printmax_t, not int, to format
9039 process-name gensyms.
9040
55e5faa1
PE
9041 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9042
80f2e268
PE
9043 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9044 to avoid potential buffer overrun.
9045
670741ab
PE
9046 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9047 if X resource line is longer than 512 bytes.
9048
b7163a50
PE
9049 * xfns.c (x_window): Make sprintf buffer a bit bigger
9050 to avoid potential buffer overrun.
9051
ae58ff1f
PE
9052 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9053
c43c8a6a
PE
9054 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9055
3f8236f4
PE
90562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9057
53e9fe90 9058 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9059 Without these, Emacs silently mishandles large integers sometimes.
9060 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9061 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9062
6511acf2
PE
9063 * xdisp.c (try_window_id): Check Emacs fixnum range before
9064 converting to 'int'.
806add1d 9065
6511acf2 9066 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9067 Check that an Emacs fixnum is in range before assigning it to 'int'.
9068 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9069 values converted from Emacs fixnums.
9070 (Frecenter): Don't wrap around a line count if it is out of 'int'
9071 range; instead, treat it as an extreme value.
9072 (Fset_window_configuration, compare_window_configurations):
9073 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9074
6511acf2
PE
9075 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9076 that can exceed INT_MAX. Check that EMACS_INT value is in range
9077 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9078 (match_limit): Don't assume that a fixnum can fit in 'int'.
9079
6511acf2 9080 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9081 exceed INT_MAX.
9082
6511acf2 9083 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9084 (Fvertical_motion): Don't wrap around LINES values that don't fit
9085 in 'int'. Instead, treat them as extreme values. This is good
9086 enough for windows, which can't have more than INT_MAX lines anyway.
9087
fcb901a7
LMI
90882011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9089
0f2f6b6d
LMI
9090 * Require libxml/parser.h to avoid compilation warning.
9091
fcb901a7
LMI
9092 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9093
9094 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9095 since this reportedly can destroy thread storage.
9096
6e20a0d4
CY
90972011-08-30 Chong Yidong <cyd@stupidchicken.com>
9098
9099 * syntax.c (find_defun_start): Update all cache variables if
9100 exiting early (Bug#9401).
9101
148ae00e
EZ
91022011-08-30 Eli Zaretskii <eliz@gnu.org>
9103
f6cfbd8f
EZ
9104 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9105
148ae00e
EZ
9106 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9107 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9108 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9109
9110 * term.c (tty_append_glyph): New function.
9111 (produce_stretch_glyph): Static function and its prototype deleted.
9112
a66cfb1c
SM
9113 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9114 Add prototypes.
148ae00e 9115
c4a07a4c
PE
91162011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9117
9118 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9119 when checking :margin (Bug#9390).
9120 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 9121 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
9122 so that the name doesn't mislead. All uses changed.
9123
6bc8cd65
JB
91242011-08-28 Johan Bockgård <bojohan@gnu.org>
9125
9126 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9127 set_tty_hooks.
9128
dca4927e
EZ
91292011-08-27 Eli Zaretskii <eliz@gnu.org>
9130
9131 * xdisp.c (move_it_to): Don't bail out early when reaching
9132 position beyond to_charpos, if we are scanning backwards.
9133 (move_it_vertically_backward): When DY == 0, make sure we get to
9134 the first character in the line after the newline.
9135
f2cad773
PE
91362011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9137
9138 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9139 (ccl_driver): Do not generate an out-of-range pointer.
9140 (Fccl_execute_on_string): Remove unnecessary check for
9141 integer overflow, noted by Stefan Monnier in
9142 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9143 Remove a FIXME that didn't need fixing.
9144 Simplify the newly-introduced buffer reallocation code.
9145
0cae2cdb
JB
91462011-08-27 Juanma Barranquero <lekktu@gmail.com>
9147
9148 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9149
5fc295a4 91502011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9151
70c60eb2 9152 Integer and memory overflow issues (Bug#9196).
726e0ab1 9153
d31850da
PE
9154 * doc.c (get_doc_string): Rework so that
9155 get_doc_string_buffer_size is the actual buffer size, rather than
9156 being 1 less than the actual buffer size; this makes xpalloc more
9157 convenient.
9158
a69fbedb
PE
9159 * image.c (x_allocate_bitmap_record, cache_image):
9160 * xselect.c (Fx_register_dnd_atom):
9161 Simplify previous changes by using xpalloc.
9162
fe5c5d37
PE
9163 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9164 since either will do and ptrdiff_t is convenient with xpalloc.
9165
0065d054
PE
9166 * charset.c (charset_table_size)
9167 (struct charset_sort_data.priority): Now ptrdiff_t.
9168 (charset_compare): Don't overflow if priorities differ greatly.
9169 (Fsort_charsets): Don't assume list length fits in int.
9170 Check for size-calculation overflow when allocating sort data.
9171 (syms_of_charset): Allocate an initial charset table that is
9172 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9173
9174 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9175
9176 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9177 The actual value is always <= INT_MAX, and leaving it unsigned made
9178 overflow checking harder.
9179
9180 * dispextern.h (struct glyph_matrix.rows_allocated)
9181 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9182 with xpalloc. The values are still always <= INT_MAX.
9183
9184 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9185
9186 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9187 (SAFE_NALLOCA): New macro.
9188
9189 * region-cache.c (struct boundary.pos, find_cache_boundary)
9190 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9191 (set_cache_region, invalidate_region_cache)
9192 (revalidate_region_cache, know_region_cache, region_cache_forward)
9193 (region_cache_backward, pp_cache):
9194 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9195 so that ptrdiff_t * can be passed to xpalloc.
9196 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9197 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9198 (pp_cache): Don't assume cache_len fits in int.
9199 * region-cache.h: Adjust extern decls to match.
9200
9201 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9202 EMACS_INT, since either will do, for xpalloc.
9203
9204 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9205 (xnmalloc, xnrealloc, xpalloc): New functions.
9206
726e0ab1
PE
9207 * bidi.c (bidi_shelve_header_size): New constant.
9208 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9209 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9210
51f30bc5 9211 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9212 * buffer.c (overlays_at, overlays_in, record_overlay_string)
9213 (overlay_strings):
9214 Don't update size of array until after memory allocation succeeds,
9215 because xmalloc/xrealloc may not return.
0065d054
PE
9216 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
9217 now that we have proper integer overflow checking.
9218 (record_overlay_string, overlay_strings): Catch overflows when
9219 calculating size of overlay_str_buf.
726e0ab1 9220
0065d054
PE
9221 * callproc.c (Fcall_process): Check for size overflow when
9222 calculating size of args2.
9223 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
9224 Normally we prefer signed values, but sticking with ptrdiff_t would
9225 require adding more-complicated checks.
726e0ab1
PE
9226
9227 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
9228 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
9229 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 9230 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
9231
9232 * character.c (Fstring): Check for size-calculation overflow.
9233
9234 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
9235 unnecessary integer overflow. Check for size overflow.
9236 (encode_coding_object): Don't update size until xmalloc succeeds.
9237
9238 * composite.c (get_composition_id): Check for overflow in glyph
9239 length calculations.
9240
9241 Integer and memory overflow fixes for display code.
9242 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
9243 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
9244 (scrolling_window): Check for overflow in size calculations.
9245 (line_draw_cost, realloc_glyph_pool, add_row_entry):
9246 Don't assume glyph table len fits in int.
9247 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
9248 (row_table_size): Now ptrdiff_t, not int.
9249 (scrolling_window): Avoid overflow in size calculations.
9250 Don't update size until allocation succeeds.
9251 * fns.c (concat): Check for overflow in size calculations.
9252 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
9253 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9254 (NEXT_ALMOST_PRIME_LIMIT): New constant.
9255
9256 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
9257 (get_doc_string): Check for size calculation overflow.
9258 Don't update size until allocation succeeds.
9259 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
9260 EMACS_INT, where ptrdiff_t will do.
9261 (Fsubstitute_command_keys): Check for string overflow.
9262
9263 * editfns.c (set_time_zone_rule): Don't assume environment length
9264 fits in int.
9265 (message_length): Now ptrdiff_t, not int.
9266 (Fmessage_box): Don't update size until allocation succeeds.
9267 Don't assume message length fits in int.
9268 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
9269
0065d054
PE
9270 * emacs.c (main): Do not reallocate argv, since there is a null at
9271 the end that can be overwritten, and this way there's no need to
9272 worry about size-calculation overflow.
9273 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
9274
9275 * eval.c (init_eval_once, grow_specpdl): Don't update size until
9276 alloc succeeds.
9277 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
9278
9279 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
9280 (x_set_scroll_bar_width, x_figure_window_size):
9281 Check for integer overflow.
9282 (x_set_alpha): Do not assume XINT fits in int.
9283
9284 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
9285 This is for the members text_lines, text_cols, total_lines, total_cols,
9286 where the system imposes an 'int' limit.
9287
9288 * fringe.c (Fdefine_fringe_bitmap):
9289 Don't update size until alloc works.
9290
9291 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
9292 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
9293
9294 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
9295 Check for size-calculation overflow.
9296 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
9297 do, as we prefer signed integers.
9298 (id_to_widget.max_size, id_to_widget.used)
9299 (xg_store_widget_in_map, xg_remove_widget_from_map)
9300 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
9301 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
9302 Use and return ptrdiff_t, not int.
9303 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
9304 * gtkutil.h: Change prototypes to match the above.
9305
9306 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
9307 are duplicate now that they've been promoted to lisp.h.
9308 (x_allocate_bitmap_record, x_alloc_image_color)
9309 (make_image_cache, cache_image, xpm_load):
9310 Don't update size until alloc is done.
9311 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
9312 (x_detect_edges):
3256efce 9313 Check for size calculation overflow.
726e0ab1
PE
9314 (ct_colors_allocated_max): New constant.
9315 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
9316 overflow.
3256efce 9317
726e0ab1
PE
9318 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
9319 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
9320 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
9321 Use ptrdiff_t, not int, to count maps.
9322 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
9323 calculations. Don't update size until allocation succeeds.
9324 Redo calculations to avoid overflow.
726e0ab1
PE
9325 * keyboard.h: Change prototypes to match the above.
9326
9327 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
9328 to count maps.
9329 (current_minor_maps): Check for size calculation overflow.
9330 * keymap.h: Change prototypes to match the above.
9331
9332 * lread.c (read1, init_obarray): Don't update size until alloc done.
9333
9334 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
9335 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9336
726e0ab1
PE
9337 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
9338 Now ptrdiff_t, not int.
9339 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9340 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
9341
9342 * process.c (Fnetwork_interface_list): Check for overflow
9343 in size calculation.
9344
9345 * region-cache.c (move_cache_gap): Check for size calculation overflow.
9346
9347 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
9348 overflow. Don't bother calling xmalloc when xrealloc will do.
9349
9350 * search.c (Freplace_match): Check for size calculation overflow.
9351 (Fset_match_data): Don't assume list lengths fit in 'int'.
9352
9353 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
9354 for command line length. Do not attempt to address one before the
9355 beginning of an array, as that's not portable.
9356
9357 * term.c (max_frame_lines): Remove; unused.
9358 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
9359 not int.
9360 (encode_terminal_code, calculate_costs): Check for size
9361 calculation overflow.
9362 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
9363 table lengths and related sizes. Don't update size until alloc
9364 done. Redo calculations to avoid overflow.
9365 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
9366
9367 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
9368 subtracting pointers.
9369 (gobble_line): Check for overflow more carefully. Don't update size
9370 until alloc done.
9371
9372 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
9373 Don't update size until alloc done.
9374 Redo size calculations to avoid overflow.
9375 Check for size calculation overflow.
0065d054 9376 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
9377
9378 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
9379 Use ptrdiff_t, not int, for sizes.
9380 (store_mode_line_noprop_char): Don't update size until alloc done.
9381
0065d054
PE
9382 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
9383 Use ptrdiff_t, not int, for sizes.
9384 (Finternal_make_lisp_face, cache_face):
9385 Check for size calculation overflow.
9386 (cache_face): Treat size calculation overflows as if they were
9387 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
9388
9389 * xfns.c (x_encode_text, x_set_name_internal)
9390 (Fx_change_window_property): Use ptrdiff_t, not int, to count
9391 sizes, since they can exceed INT_MAX in size. Check for size
9392 calculation overflow.
9393
0065d054
PE
9394 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
9395 (xg_select): Check for size calculation overflow.
726e0ab1
PE
9396 Don't update size until alloc done.
9397
0065d054 9398 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 9399 as sprintf is limited to int lengths.
1d526e2f 9400
252c5ee1
PE
9401 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
9402 (X_LONG_MIN): New macros.
864d7ce7
PE
9403 Use them to make the following changes clearer.
9404 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
9405 This change doesn't affect the value now, but it may help remind
9406 future maintainers not to raise the value too much later.
9407 (SELECTION_QUANTUM): Remove, replacing with ...
9408 (selection_quantum): ... new function, which avoids overflow.
9409 All uses changed.
9410 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
9411 assumption that selection length fits in 'int'.
9412 (x_reply_selection_request, x_handle_selection_request)
9413 (x_get_window_property, receive_incremental_selection)
9414 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
9415 (lisp_data_to_selection_data, clean_local_selection_data):
9416 Use ptrdiff_t, not int, to record length of selection.
9417 (x_reply_selection_request, x_get_window_property)
9418 (receive_incremental_selection, x_property_data_to_lisp):
9419 Redo calculations to avoid overflow.
9420 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 9421 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
9422 something.
9423 (x_get_window_property, receive_incremental_selection)
9424 (lisp_data_to_selection_data, x_property_data_to_lisp):
9425 Check for size-calculation overflow.
9426 (x_get_window_property, receive_incremental_selection)
9427 (lisp_data_to_selection_data, Fx_register_dnd_atom):
9428 Don't store size until memory allocation succeeds.
9429 (x_get_window_property): Plug memory leak on memory exhaustion.
9430 Don't double-block input; malloc is safe here. Don't assume 2**34
9431 - 4 fits in unsigned long. Add an xassert to check
9432 XGetWindowProperty overflow. Be more careful about overflow
9433 calculations, and distinguish size from memory overflow better.
9434 (receive_incremental_selection): When tracing, don't assume
9435 unsigned int is less than INT_MAX.
9436 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
9437 harmful) conversions of unsigned short to int.
9438 (lisp_data_to_selection_data): Don't assume that integers
9439 in the range -65535 through -1 fit in an X unsigned short.
9440 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
9441 result parameters unless successful. Rely on cons_to_unsigned
9442 to report problems with elements; the old code wasn't right anyway.
9443 (x_check_property_data): Check for int overflow; we cannot use
9444 a wider type due to X limits.
9445 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
9446
726e0ab1 9447 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 9448
0065d054
PE
9449 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
9450 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
9451 (x_color_cells): Don't store size until memory allocation succeeds.
9452 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 9453 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
9454 (x_term_init): Don't assume length fits in int (sprintf is limited
9455 to int size).
bc18e09d 9456
ebfa62c0
PE
9457 Use ptrdiff_t for composition IDs.
9458 * character.c (lisp_string_width):
9459 * composite.c (composition_table_size, n_compositions)
9460 (get_composition_id, composition_gstring_from_id):
9461 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
9462 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
9463 * window.c (Frecenter):
9464 Use ptrdiff_t, not int, for composition IDs.
9465 * composite.c (get_composition_id): Check for integer overflow.
9466 * composite.h: Adjust prototypes to match the above changes.
9467
d3411f89
PE
9468 Use ptrdiff_t for hash table indexes.
9469 * category.c (hash_get_category_set):
9470 * ccl.c (ccl_driver):
9471 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
9472 * coding.c (coding_system_charset_list, detect_coding_system):
9473 * coding.h (struct coding_system.id):
9474 * composite.c (get_composition_id, gstring_lookup_cache):
9475 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
9476 * image.c (xpm_get_color_table_h):
9477 * lisp.h (hash_lookup, hash_put):
9478 * minibuf.c (Ftest_completion):
9479 Use ptrdiff_t for hash table indexes, not int (which is too
9480 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
9481 32-bit --with-wide-int hosts).
9482
e097a6fa
PE
9483 * charset.c (Fdefine_charset_internal): Check for integer overflow.
9484 Add a FIXME comment about memory leaks.
9485 (syms_of_charset): Don't assume xmalloc returns.
9486
5637687f
PE
9487 Don't assume that stated character widths fit in int.
9488 * character.c (Fchar_width, c_string_width, lisp_string_width):
9489 * character.h (CHAR_WIDTH):
9490 * indent.c (MULTIBYTE_BYTES_WIDTH):
9491 Use sanitize_char_width to avoid undefined and/or bad behavior
9492 with outlandish widths.
a66cfb1c 9493 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9494 now that we have two such functions. All uses changed.
9495 (sanitize_char_width): New inline function.
9496
a2271ba2
PE
9497 Don't assume that tab-width fits in int.
9498 * character.h (sanitize_width): New inline function.
9499 (SANE_TAB_WIDTH): New macro.
9500 (ASCII_CHAR_WIDTH): Use it.
9501 * indent.c (sane_tab_width): Remove. All uses replaced by
9502 SANE_TAB_WIDTH (current_buffer).
9503 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9504
18c52557
PE
9505 * fileio.c: Integer overflow issues with file modes.
9506 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9507
caeeedc1
PE
9508 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9509 Remove unreachable code.
9510 (read_hex, load_charset_map_from_file): Check for integer overflow.
9511
6df6ae42 9512 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9513 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9514 (x_send_scroll_bar_event): Likewise. Check that the size does not
9515 exceed limits imposed by XClientMessageEvent, as well as the usual
9516 ptrdiff_t and size_t limits.
9517
b13995db
PE
9518 * keyboard.c: Overflow, signedness and related fixes.
9519 (make_lispy_movement): Use same integer type in forward decl
9520 that is used in the definition.
9521 (read_key_sequence, keyremap_step):
9522 Change bufsize argument back to int, undoing my 2011-03-30 change.
9523 We prefer signed types, and int is wide enough here.
9524 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9525 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9526 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9527 length, not size_t. Use ptrdiff_t for index, not int.
9528 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9529 possibility of integer overflow.
9530
13464394
PE
9531 Overflow, signedness and related fixes for images.
9532
9533 * dispextern.h (struct it.stack[0].u.image.image_id)
9534 (struct_it.image_id, struct image.id, struct image_cache.size)
9535 (struct image_cache.used, struct image_cache.ref_count):
9536 * gtkutil.c (update_frame_tool_bar):
9537 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9538 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9539 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9540 * nsmenu.m (update_frame_tool_bar):
9541 * xdisp.c (calc_pixel_width_or_height):
9542 * xfns.c (image_cache_refcount):
9543 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9544 on typical 64-bit hosts.
9545
9546 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9547 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9548 Omit unnecessary casts to int.
9549 (parse_image_spec): Check that integers fall into 'int' range
9550 when the callers expect that.
9551 (image_ascent): Redo ascent calculation to avoid int overflow.
9552 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9553 (lookup_image): Remove unnecessary tests.
9554 (xbm_image_p): Locals are now of int, not EMACS_INT,
9555 since parse_image_check makes sure they fit into int.
9556 (png_load, gif_load, svg_load_image):
9557 Prefer int to unsigned where either will do.
9558 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9559 old tiff_error_handler and tiff_warning_handler.
9560 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9561 stack buffer overflows. It uses only the features of vsnprintf
9562 that are common to both POSIX and native Microsoft.
9563 (tiff_error_handler, tiff_warning_handler): Use it.
9564 (tiff_load, gif_load, imagemagick_load_image):
9565 Don't assume :index value fits in 'int'.
9566 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9567 (imagemagick_load_image): Check that crop parameters fit into
9568 the integer types that MagickCropImage accepts. Don't assume
9569 Vimagemagick_render_type has a nonnegative value. Don't assume
9570 size_t fits in 'long'.
9571 (gs_load): Use printmax_t to print the widest integers possible.
9572 Check for integer overflow when computing image height and width.
9573
c11821d4
EZ
95742011-08-26 Eli Zaretskii <eliz@gnu.org>
9575
9576 * xdisp.c (redisplay_window): Don't force window start if point
9577 will be invisible in the resulting window. (Bug#9324)
9578
0c95fcf7
EZ
95792011-08-25 Eli Zaretskii <eliz@gnu.org>
9580
9581 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9582 the display spec is of the form `(space ...)'.
9583 (handle_display_spec): Return the value returned by
9584 handle_single_display_spec, not just 1 or zero.
9585 (handle_single_display_spec): If the display spec is of the form
9586 `(space ...)', and specifies display in the text area, return 2
9587 rather than 1.
fee65a97 9588 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9589 accurately, and prefer exact match for point under bidi.
9590 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9591
9592 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9593 into disp_prop; all users changed.
9594
9595 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9596 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9597 for the text covered by the display property.
9598
e4ed06f1
CY
95992011-08-25 Chong Yidong <cyd@stupidchicken.com>
9600
9601 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9602 Change return value to nil.
9603 (Frecord_buffer): Delete unused function.
9604
f67cdd7f
EZ
96052011-08-24 Eli Zaretskii <eliz@gnu.org>
9606
5980d4c6
EZ
9607 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9608 buffers, return left-to-right.
8610fe8b
EZ
9609 (set_cursor_from_row): Consider candidate row a win if its glyph
9610 represents a newline and point is on that newline. Fixes cursor
9611 positioning on the newline at EOL of R2L text within L2R
9612 paragraph, and vice versa.
9613 (try_cursor_movement): Check continued rows, in addition to
9614 continuation rows. Fixes unwarranted scroll when point enters a
9615 continued line of R2L text within an L2R paragraph, or vice versa.
9616 (cursor_row_p): Consider the case of point being equal to
9617 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9618 from the end of a short line to the beginning of a continued line
9619 of R2L text within L2R paragraph.
9620 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9621 composed characters.
5980d4c6 9622
f67cdd7f
EZ
9623 * bidi.c (bidi_check_type): Use xassert.
9624 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9625 members.
9626
bca633fb
EZ
96272011-08-23 Eli Zaretskii <eliz@gnu.org>
9628
9629 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9630 a character.
9631
4a5885a7
CY
96322011-08-23 Chong Yidong <cyd@stupidchicken.com>
9633
9634 * nsfont.m (ns_otf_to_script): Fix typo.
9635
0902a04e
KH
96362011-08-22 Kenichi Handa <handa@m17n.org>
9637
9638 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9639 extra slot even if the purpose is char-code-property-table.
9640
1a2e6670
EZ
96412011-08-23 Eli Zaretskii <eliz@gnu.org>
9642
8ddde651
EZ
9643 * xdisp.c (redisplay_window): When computing centering_position,
9644 account for the height of the header line. (Bug#8874)
9645
425cc014
EZ
9646 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9647 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9648 candidate is selected by the mouse, and that candidate has a
9649 composed character under the mouse.
9650
1a2e6670
EZ
9651 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9652 coordinates reported by pos-visible-in-window-p for a composed
9653 character in column zero.
9654
8b76d6f8
SM
96552011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9656
9657 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9658
dac347dd
EZ
96592011-08-22 Eli Zaretskii <eliz@gnu.org>
9660
9661 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9662 consider it a hit if to_charpos is anywhere in the range of the
9663 composed buffer positions.
9664
e013fb34
CY
96652011-08-22 Chong Yidong <cyd@stupidchicken.com>
9666
9667 * image.c (gif_load): Don't assume that each subimage has the same
9668 dimensions as the base image. Handle disposal method that is
9669 "undefined" by the gif spec (Bug#9335).
9670
bd1ba3e8
CY
96712011-08-20 Chong Yidong <cyd@stupidchicken.com>
9672
9673 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9674 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9675
54a1215b
EZ
96762011-08-19 Eli Zaretskii <eliz@gnu.org>
9677
823564e5
EZ
9678 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9679 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9680 from an Org mode buffer to a Speedbar frame.
9681
54a1215b
EZ
9682 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9683 a composition, take its buffer position from IT->cmp_it.charpos.
9684 Fixes cursor positioning at the beginning of a line that begins
9685 with a composed character.
9686
9778ebcc
EZ
96872011-08-18 Eli Zaretskii <eliz@gnu.org>
9688
0be6ee06
EZ
9689 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9690 character bidirectional type, use STRONG_L instead. Fixes crashes
9691 in a buffer produced by `describe-categories'.
9692
9778ebcc
EZ
9693 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9694 members before the level stack, so they would be saved and
9695 restored when copying iterator state. Fixes incorrect reordering
9696 around TABs covered by display properties.
9697
156bffbe
AS
96982011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9699
6b02f655 9700 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9701
72ad093b
CY
97022011-08-17 Chong Yidong <cyd@stupidchicken.com>
9703
9704 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9705 (internal_condition_case_2, internal_condition_case_n):
9706 Remove unnecessary aborts (Bug#9081).
72ad093b 9707
35774242
EZ
97082011-08-17 Eli Zaretskii <eliz@gnu.org>
9709
9710 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9711 has no `load' handler, try opening the file locally. (Bug#9311)
9712
db76dd85
KB
97132011-08-16 Ken Brown <kbrown@cornell.edu>
9714
9715 * gmalloc.c: Expand comment.
9716
b215eee5
EZ
97172011-08-16 Eli Zaretskii <eliz@gnu.org>
9718
9719 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9720 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9721
a4579d33
KB
97222011-08-16 Ken Brown <kbrown@cornell.edu>
9723
9724 Fix memory allocation problems in Cygwin build (Bug#9273).
9725
9726 * unexcw.c ( __malloc_initialized): Declare external variable.
9727 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9728
8b76d6f8
SM
9729 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9730 New variables.
a4579d33
KB
9731 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9732 dumped emacs.
9733 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9734 in the static heap.
9735 [CYGWIN] (special_realloc): New function.
9736 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9737 requests to realloc storage in the static heap.
9738
3ebec551
PE
97392011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9740
9741 * bidi.c (bidi_initialize): Remove unused local.
9742
9fd8be00
EZ
97432011-08-15 Eli Zaretskii <eliz@gnu.org>
9744
6b02f655
SM
9745 * bidimirror.h:
9746 * biditype.h: Remove file.
9747 * makefile.w32-in ($(BLD)/bidi.$(O)):
9748 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9749
9750 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9751
9752 * chartab.c: Improve commentary for the uniprop_table API.
9753
32413314
EZ
9754 * bidi.c (bidi_paragraph_init): Support zero value of
9755 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9756 (bidi_initialize): Use uniprop_table instead of including
9757 biditype.h and bidimirror.h.
32413314 9758
9fd8be00
EZ
9759 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9760 coordinates of the iterator when restoring from ppos_it.
9761 (Bug#9296)
9762
5cf2b69b
KH
97632011-08-14 Kenichi Handa <handa@m17n.org>
9764
9765 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9766 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9767
daf17d00
EZ
97682011-08-14 Eli Zaretskii <eliz@gnu.org>
9769
9770 * xdisp.c (move_it_in_display_line_to): Don't invoke
9771 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9772 ppos_it. Fixes vertical cursor motion when line beginning is
9773 covered by an image. (Bug#9296)
9774
08e3161a
JD
97752011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9776
9777 * nsterm.h (ns_run_ascript): Declare.
9778 (NSAPP_DATA2_RUNASSCRIPT): Define.
9779
9780 * nsfns.m (as_script, as_result, as_status): New static variables.
9781 (ns_run_ascript): New function.
5e617bc2 9782 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9783 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9784 the event loop. Get status from as_status (Bug#7276).
9785
9786 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9787 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9788 the event loop (Bug#7276).
9789
a3720aa2
AS
97902011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9791
9792 * gnutls.c (QCgnutls_bootprop_priority)
9793 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9794 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9795 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9796 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9797 (QCgnutls_bootprop_verify_hostname_error)
9798 (QCgnutls_bootprop_callbacks_verify): Rename from
9799 Qgnutls_bootprop_..., all uses changed.
9800
9801 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9802 uses changed.
9803
0a0d27fb
PE
98042011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9805
19d5c50c
PE
9806 * xfaces.c (Qframe_set_background_mode): Now static.
9807 * dispextern.h (Qframe_set_background_mode): Remove decl.
9808
0a0d27fb
PE
9809 * process.c (Fnetwork_interface_info): Declare local only if needed.
9810
377538cb
JD
98112011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9812
9813 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9814 (Fnetwork_interface_list): Allocate in increments of bytes instead
9815 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9816 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9817 sockaddr.
9818 (struct ifflag_def): notrailers is smart on OSX.
9819 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9820 Get hardware address with getifaddrs if available.
9821
08fff70c
EZ
98222011-08-12 Eli Zaretskii <eliz@gnu.org>
9823
9824 * xdisp.c (iterate_out_of_display_property): xassert that
9825 IT->position is set to within IT->object's boundaries. Break from
9826 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9827 when IT->position is set up wrongly due to some bug.
9828 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9829 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9830 entry. Force push_it to save on the stack the current
9831 buffer/string position, to be restored by pop_it. Fix flags in
9832 the iterator structure wrt the object coming from a display
9833 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9834 properties. (Bug#9284)
9835
7be1c708 98362011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9837
7be1c708
CY
9838 * fontset.c (fontset_get_font_group): Add proper type checks.
9839 (Bug#9172)
aac0c6e3 9840
7be1c708 98412011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9842
7be1c708
CY
9843 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9844 and LC_VERSION_MIN_MACOSX.
9845 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9846 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9847
97bb72a6
EZ
98482011-08-08 Eli Zaretskii <eliz@gnu.org>
9849
9850 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9851 no-display-properties-and-no-overlays under bidi display.
9852 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9853 properties and overlays.
97bb72a6 9854
d5617611
CY
98552011-08-08 Chong Yidong <cyd@stupidchicken.com>
9856
37e11a63
CY
9857 * editfns.c (Fset_time_zone_rule): Document relationship with the
9858 setenv function.
9859
d5617611
CY
9860 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9861 the font entity extracted from the cache (Bug#8109).
9862
58872834
CY
98632011-08-07 Chong Yidong <cyd@stupidchicken.com>
9864
9865 * composite.c (autocmp_chars): Don't reset point. That is done by
9866 restore_point_unwind (Bug#5984).
9867
75bfc667
JL
98682011-08-07 Juri Linkov <juri@jurta.org>
9869
9870 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9871 to show the arg `TIME' instead of `TIMEVAL'.
9872
d1410150
EZ
98732011-08-06 Eli Zaretskii <eliz@gnu.org>
9874
9875 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9876 display property strides EOL and includes a newline, as in
9877 longlines-mode. (Bug#9254)
75b771e4
EZ
9878 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9879 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9880
9881 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9882 is non-zero, even if the data buffer is NULL. Fixes a crash in
9883 vertical-motion with longlines-mode. (Bug#9254)
9884
35928349
EZ
98852011-08-05 Eli Zaretskii <eliz@gnu.org>
9886
ec7cc85b
EZ
9887 * bidi.c <bidi_cache_total_alloc>: Now static.
9888 (bidi_initialize): Initialize bidi_cache_total_alloc.
9889
8b76d6f8 9890 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9891 cache. (Bug#9221)
9892
9893 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9894 amount allocated this far in `bidi_cache_total_alloc'.
9895 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9896 non-zero, only free the data buffer without restoring the cache
9897 contents. All callers changed.
9898
9899 * dispextern.h (bidi_unshelve_cache): Update prototype.
9900
9901 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9902 (move_it_in_display_line, move_it_to)
9903 (move_it_vertically_backward, move_it_by_lines): Replace the call
9904 to xfree to an equivalent call to bidi_unshelve_cache.
9905 (move_it_in_display_line_to): Fix logic of returning
412b6358 9906 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9907
e2e2423b
EZ
99082011-08-05 Eli Zaretskii <eliz@gnu.org>
9909
9910 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9911 came from a string character with a `cursor' property. (Bug#9229)
9912
ae9e757a
JD
99132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9914
9915 * Makefile.in (LIB_PTHREAD): New variable.
9916 (LIBES): Add LIB_PTHREAD (Bug#9216).
9917
9918 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9919 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9920
213bd7f2
AS
99212011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9922
6b02f655 9923 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9924
99aaf75f
JD
99252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9926
9927 * xterm.c (x_find_topmost_parent): New function.
9928 (x_set_frame_alpha): Find topmost parent window with
9929 x_find_topmost_parent and set the property there also (bug#9181).
9930 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9931
c74e9d86
PE
99322011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9933
9934 * callproc.c (Fcall_process): Avoid vfork clobbering
9935 the local vars buffer, coding_systems, current_dir.
9936
640c8776
SM
99372011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9938
9939 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9940
f26d0e4c
PE
99412011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9942
8a10d76c
PE
9943 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9944 so that it is not optimized away.
9945
f26d0e4c
PE
9946 * xdisp.c (compute_display_string_pos): Remove unused local.
9947
55439c61
EZ
99482011-08-02 Eli Zaretskii <eliz@gnu.org>
9949
9950 Fix slow cursor motion and scrolling in large buffers with
9951 selective display, like Org Mode buffers. (Bug#9218)
9952
9953 * dispextern.h (struct bidi_it): New member disp_prop_p.
9954
9955 * xdisp.c: Remove one-slot cache of display string positions.
9956 (compute_display_string_pos): Accept an additional argument
5e617bc2 9957 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9958 for a display string or property. If found, set DISP_PROP_P
9959 non-zero.
9960
9961 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9962 DISP_PROP_P, and pass it to compute_display_string_pos.
9963 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9964 non-zero. All callers of bidi_fetch_char changed.
9965
fb33fa43
SM
99662011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9967
9968 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9969
b099e063
DM
99702010-12-03 Don March <don@ohspite.net>
9971
9972 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9973 last character M-[char] is translated to ESC [char] (bug#7541).
9974
5cc7f7af
KH
99752011-08-02 Kenichi Handa <handa@m17n.org>
9976
d0fffa3f 9977 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9978
9979 * chartab.c (uniprop_table): Make it non-static.
9980
525d5e6e
EZ
99812011-08-01 Eli Zaretskii <eliz@gnu.org>
9982
9983 * xdisp.c (forward_to_next_line_start): Accept additional argument
9984 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9985 on the newline.
9986 (reseat_at_next_visible_line_start): Use the bidi iterator state
9987 returned by forward_to_next_line_start to restore the state of
9988 it->bidi_it after backing up to previous newline. (Bug#9212)
9989
31011111
AS
99902011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9991
9992 * regex.c (re_comp): Protoize.
9993 (re_exec): Fix return type.
9994 (regexec): Fix type of `ret'. (Bug#9203)
9995
476371c4
PE
99962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9997
e5d76069
PE
9998 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9999 This is needed if max-image-size is a floating-point number.
10000
9a79b20c
AS
100012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10002
10003 * print.c (print_object): Print empty symbol as ##.
10004
10005 * lread.c (read1): Read ## as empty symbol.
10006
d8c2fa78
AA
100072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10008
10009 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10010 setting frame foreground color (Bug#9175).
10011 (x_set_background_color): Likewise.
10012
ffe57a7a
AA
10013 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10014 contents (Bug#9176).
10015 (EmacsTooltip -init): Remove bezels and add shadows to
10016 tooltip windows.
10017
bf3492a5
AA
10018 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10019 or scroll bar (Bug#8470).
10020
d55e9c53
AA
10021 * nsfont.m (nsfont_open): Remove assignment to voffset and
10022 unnecessary vars hshink, expand, hd, full_height, min_height.
10023 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10024
10025 * nsterm.h (nsfont_info): Remove voffset field.
10026
d8c2fa78 100272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10028
10029 Implement strike-through and overline on NextStep (Bug#8863).
10030
10031 * nsfont.m (nsfont_open): Use underline position provided by font,
10032 instead of hard-coded value of 2.
10033 (nsfont_draw): Call ns_draw_text_decoration instead.
10034
10035 * nsterm.h: Add declaration for ns_draw_text_decoration.
10036
10037 * nsterm.m (ns_draw_text_decoration): New function for drawing
10038 underline, overline, and strike-through.
10039 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10040 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10041 accommodate underlining, etc.
4843aac3 10042
4cc60b9b
EZ
100432011-07-28 Eli Zaretskii <eliz@gnu.org>
10044
bc7ece87
EZ
10045 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10046 default.
4cc60b9b 10047
476371c4
PE
100482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10049
66606eea
PE
10050 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10051 Without this fix, if a signal arrives just after memory fills up,
10052 'malloc' might be invoked reentrantly.
10053
476371c4
PE
10054 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10055 In other words, assume that every image size is allowed, on non-X
10056 hosts. This assumption is probably wrong, but it lets Emacs compile.
10057
f3fcc40d
AS
100582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10059
10060 * regex.c (re_iswctype): Convert return values to boolean.
10061
350c992f
EZ
100622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10063
10064 * xdisp.c (compute_display_string_pos): Don't use cached display
10065 string position if the buffer had its restriction changed.
10066 (Bug#9184)
10067
5266b4bb
PE
100682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10069
10070 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10071
2573a837 100722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10073
41f55ccd 10074 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10075
39e378da
PE
10076 * bidi.c: Integer size and overflow fixes.
10077 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10078 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10079 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10080 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10081 (bidi_find_other_level_edge):
10082 Use ptrdiff_t instead of EMACS_INT where either will do.
10083 This works better on 32-bit hosts configured --with-wide-int.
10084 (bidi_cache_ensure_space): Check for size-calculation overflow.
10085 Use % rather than repeated addition, for better worst-case speed.
10086 Don't set bidi_cache_size until after xrealloc returns, because it
10087 might not return.
10088 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10089 (bidi_cache_ensure_space): Also check that the bidi cache size
10090 does not exceed that of the largest Lisp string or buffer. See Eli
10091 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10092
5e927815
PE
10093 * alloc.c (__malloc_size_t): Remove.
10094 All uses replaced by size_t. See Andreas Schwab's note
10095 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10096
ca4aa935
PE
10097 * image.c: Improve checking for integer overflow.
10098 (check_image_size): Assume that f is nonnull, since
10099 it is always nonnull in practice. This is one less thing to
10100 worry about when checking for integer overflow later.
10101 (x_check_image_size): New function, which checks for integer
10102 overflow issues inside X.
10103 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10104 This removes the need for a memory_full check.
10105 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10106 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10107 (xbm_read_bitmap_data): Change locals back to 'int', since
10108 their values must fit in 'int'.
10109 (xpm_load_image, png_load, tiff_load):
10110 Invoke x_create_x_image_and_pixmap earlier,
10111 to avoid much needless work if the image is too large.
10112 (tiff_load): Treat overly large images as if
10113 x_create_x_image_and_pixmap failed, not as malloc failures.
10114 (gs_load): Use x_check_image_size.
10115
5f8f9cc2
PE
10116 * gtkutil.c: Omit integer casts.
10117 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10118 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10119
5adf60bc
PE
10120 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
10121
c8907a93
PE
10122 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
10123 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
10124 would wrongly return t on a 64-bit host.
10125
e3c25c68
PE
10126 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10127 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10128 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10129 and therefore cause GCC to emit a bogus diagnostic in some cases.
10130
3f791afe
PE
10131 * image.c: Integer signedness and overflow and related fixes.
10132 This is not an exhaustive set of fixes, but it's time to
10133 record what I've got.
10134 (lookup_pixel_color, check_image_size): Remove redundant decls.
10135 (check_image_size): Don't assume that arbitrary EMACS_INT values
10136 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10137 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10138 (tiff_load, imagemagick_load_image):
10139 Check for overflow in size calculations.
10140 (x_create_x_image_and_pixmap): Remove unnecessary test for
10141 xmalloc returning NULL; that can't happen.
10142 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10143 (xpm_color_bucket): Use better integer hashing function.
10144 (xpm_cache_color): Don't possibly over-allocate memory.
10145 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10146 (gif_memory_source):
10147 Use ptrdiff_t, not int or size_t, to record sizes.
10148 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10149 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10150 either works, as we prefer signed integers.
10151 (tiff_read_from_memory, tiff_write_from_memory):
10152 Return tsize_t, not size_t, since that's what the TIFF API wants.
10153 (tiff_read_from_memory): Don't fail simply because the read would
10154 go past EOF; instead, return a short read.
10155 (tiff_load): Omit no-longer-needed casts.
10156 (Fimagemagick_types): Don't assume size fits into 'int'.
10157
3cc5a532
PE
10158 Improve hashing quality when configured --with-wide-int.
10159 * fns.c (hash_string): New function, taken from sxhash_string.
10160 Do not discard information about ASCII character case; this
10161 discarding is no longer needed.
10162 (sxhash-string): Use it. Change sig to match it. Caller changed.
10163 * lisp.h: Declare it.
10164 * lread.c (hash_string): Remove, since we now use fns.c's version.
10165 The fns.c version returns a wider integer if --with-wide-int is
10166 specified, so this should help the quality of the hashing a bit.
10167
b312a492
PE
10168 * emacs.c: Integer overflow minor fix.
10169 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10170 Define only if GNU_LINUX.
10171 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10172
dfd153ae
PE
10173 * dispnew.c: Integer signedness and overflow fixes.
10174 Remove unnecessary forward decls, that were a maintenance hassle.
10175 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10176 All uses changed.
10177 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10178 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10179 (prepare_desired_row, line_draw_cost):
10180 Use int, not unsigned, where either works.
10181 (save_current_matrix, restore_current_matrix):
10182 Use ptrdiff_t, not size_t, where either works.
10183 (init_display): Check for overflow more accurately, and without
10184 relying on undefined behavior.
10185
a81d11a3
PE
10186 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10187 Remove, replacing with the new symbols in lisp.h. All uses changed.
10188 * fileio.c (make_temp_name):
10189 * filelock.c (lock_file_1, lock_file):
10190 * xdisp.c (message_dolog):
10191 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10192 Use pMd etc. instead.
10193 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10194 replacing the pWIDE etc. symbols removed from editfns.c.
10195
3300e6fd
PE
10196 * keyboard.h (num_input_events): Now uintmax_t.
10197 This is (very slightly) less likely to mess up due to wraparound.
10198 All uses changed.
10199
fd05c7e9
PE
10200 * buffer.c: Integer signedness fixes.
10201 (alloc_buffer_text, enlarge_buffer_text):
10202 Use ptrdiff_t rather than size_t when either will do, as we prefer
10203 signed integers.
10204
903fe15d
PE
10205 * alloc.c: Integer signedness and overflow fixes.
10206 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10207 (__malloc_size_t): Default to size_t, not to int.
10208 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10209 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10210 Prefer ptrdiff_t to size_t when either would do, as we prefer
10211 signed integers.
10212 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
10213 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
10214 Now const. Initialize with values that are in range even if char
10215 is signed.
10216 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
10217 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
10218 These functions do the right thing with sizes > 2**32.
10219 (check_depth): Now ptrdiff_t, not int.
10220 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
10221 Adjust to new way of storing sizes. Check for size overflow bugs
10222 in rest of code.
10223 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
10224 slightly wrong anyway, as it missed one instance of
10225 XMALLOC_OVERRUN_CHECK_OVERHEAD.
10226 (refill_memory_reserve): Omit needless cast to size_t.
10227 (mark_object_loop_halt): Mark as externally visible.
10228
ac82cc6a
PE
10229 * xselect.c: Integer signedness and overflow fixes.
10230 (Fx_register_dnd_atom, x_handle_dnd_message):
10231 Use ptrdiff_t, not size_t, since we prefer signed.
10232 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
10233 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
10234 x_dnd_atoms_size and x_dnd_atoms_length.
10235
c2d1e36d
PE
10236 * doprnt.c: Prefer signed to unsigned when either works.
10237 * eval.c (verror):
10238 * doprnt.c (doprnt):
10239 * lisp.h (doprnt):
10240 * xdisp.c (vmessage):
10241 Use ptrdiff_t, not size_t, when using or implementing doprnt,
10242 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10243 prefer signed arithmetic to avoid comparison confusion.
10244 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
10245 but is a bit tricky.
10246
0e926e56
PE
10247 Assume freestanding C89 headers, string.h, stdlib.h.
10248 * data.c, doprnt.c, floatfns.c, print.c:
10249 Include float.h unconditionally.
10250 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
10251 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
10252 * regex.c: Likewise for stddef.h, string.h.
10253 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10254 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
10255 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
10256 (STDC_HEADERS): Remove obsolete defines.
10257 * sysdep.c: Include limits.h unconditionally.
10258
9cfdb3ec
PE
10259 Assume support for memcmp, memcpy, memmove, memset.
10260 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
10261 * regex.c (memcmp, memcpy):
10262 Remove; we assume C89 now.
10263
10264 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
10265 (__malloc_safe_bcopy): Remove; no longer needed.
10266
cf950e6b 10267 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
10268 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
10269 well either way, and we prefer signed to unsigned.
10270
dbf38e02
LMI
102712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
10272
10273 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
10274 closes the connection while we're reading (bug#9182).
10275
d6f0886c 102762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 10277
d6f0886c
JD
10278 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
10279 are specified (Bug#9168).
24e0f6b1 10280
2eb1f9e6
PE
102812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
10282
10283 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
10284 Found by GCC static checking and --with-wide-int on a 32-bit host.
10285
22381272 102862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
10287
10288 * xdisp.c (compute_display_string_pos): Fix logic of caching
10289 previous display string position. Initialize cached_prev_pos to
10290 -1. Fixes slow-down at the beginning of a buffer.
10291
f25e39b4
EZ
102922011-07-24 Eli Zaretskii <eliz@gnu.org>
10293
10294 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10295 for attrs[LFACE_FONTSET_INDEX].
10296
04c4b52e
PE
102972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
10298
10299 * xml.c (parse_region): Remove unused local
10300 that was recently introduced.
10301
c1734fbd
EZ
103022011-07-23 Eli Zaretskii <eliz@gnu.org>
10303
be18c5a5
EZ
10304 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
10305 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
10306
c1734fbd
EZ
10307 * xdisp.c (move_it_in_display_line_to): Record the best matching
10308 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
10309 exit if none of the characters scanned was an exact match.
10310 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
10311 when exact match is impossible due to invisible text, and the
10312 lines are truncated.
10313
a258d627
JD
103142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
10315
10316 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
10317 for OSX >= 10.7.
10318
b6d5a689
EZ
103192011-07-22 Eli Zaretskii <eliz@gnu.org>
10320
0f74f785
EZ
10321 Fix a significant slow-down of cursor motion with C-n, C-p,
10322 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10323 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 10324 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
10325 (next_element_from_buffer): Call compute_stop_pos_backwards to
10326 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
10327 base_level_stop.
10328 (reseat): Don't look for prev_stop, as that could mean a very long
10329 run.
10330 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
10331 <cached_disp_overlay_modiff>: Cache for last found display string
10332 position.
551918c1 10333 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
10334 about the same buffer in the same area of character positions, and
10335 the buffer wasn't changed since the time the display string
10336 position was cached.
551918c1 10337
b2d0c91a
EZ
103382011-07-22 Eli Zaretskii <eliz@gnu.org>
10339
10340 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
10341 is an integer, which is important for empty lines. (Bug#9149)
10342
043604ee
CY
103432011-07-22 Chong Yidong <cyd@stupidchicken.com>
10344
10345 * frame.c (Fmodify_frame_parameters): In tty case, update the
10346 default face if necessary (Bug#4238).
10347
da4adb04
CY
103482011-07-21 Chong Yidong <cyd@stupidchicken.com>
10349
10350 * editfns.c (Fstring_to_char): No need to explain what a character
10351 is in the docstring (Bug#6576).
10352
9abd0532
LMI
103532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10354
10355 * xml.c (parse_region): Make sure we always return a tree.
10356
36881d16
HK
103572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
10358
10359 * xml.c (parse_region): If a document contains only comments,
10360 return that, too.
10361
1e98674d
LMI
103622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10363
10364 * xml.c (make_dom): Return comments, too.
10365
590bd467
PE
103662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
10367
10368 Port to OpenBSD.
10369 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
10370 and the surrounding thread.
10371 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
10372 rather than fgets, and retry after EINTR. Otherwise, 'emacs
10373 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
10374 timer goes off.
10375 * s/openbsd.h (BROKEN_SIGIO): Define.
10376 * unexelf.c (unexec) [__OpenBSD__]:
10377 Don't update the .mdebug section of the Alpha COFF symbol table.
10378
f41628b2
LMI
103792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10380
10381 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
10382 (bug#8460).
10383
b59b67c5
PE
103842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
10385
15e3a074
PE
10386 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
10387 This fixes some race conditions on the permissions of any newly
10388 created file.
10389
41bed37d
PE
10390 * alloc.c (valid_pointer_p): Use pipe, not open.
10391 This fixes some permissions issues when debugging.
10392
b59b67c5
PE
10393 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
10394 If fchown fails to set both uid and gid, try to set just gid,
10395 as that is sometimes allowed. Adjust the file's mode to eliminate
10396 setuid or setgid bits that are inappropriate if fchown fails.
10397
925a6be7
SM
103982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10399
10400 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
10401 to compare Lisp_Objects.
10402 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
10403 global_gnutls_log_level, don't mistake it for a Lisp_Object.
10404 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
10405
52968808
AS
104062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
10407
0a6a104b
AS
10408 * lread.c (read_integer): Unread even EOF character.
10409 (read1): Likewise. Properly record start position of symbol.
10410
52968808
AS
10411 * lread.c (read1): Read `#:' as empty uninterned symbol if no
10412 symbol character follows.
10413
9e381cdd
PE
104142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10415
10416 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
10417 This works around a problem with the previous change to Fcopy_file.
10418 Recent glibc declares fchown with __attribute__((warn_unused_result)),
10419 and without this change, GCC might complain about discarding
10420 fchown's return value.
10421
b5641435
JB
104222011-07-16 Juanma Barranquero <lekktu@gmail.com>
10423
10424 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
10425
a8031457
PE
104262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
10427
10428 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
10429
dd889327
LMI
104302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
10431
750c33f7
LMI
10432 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
10433 it's used from the C level.
10434
dd889327
LMI
10435 * process.c: Use the same condition for POLL_FOR_INPUT in both
10436 keyboard.c and process.c (bug#1858).
10437
87e86684
LM
104382011-07-09 Lawrence Mitchell <wence@gmx.li>
10439
10440 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
10441 (Fgnutls_boot): Use it.
10442
64348f40
AS
104432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
10444
10445 * doc.c (Fsubstitute_command_keys): Revert last change.
10446
1d698799
LMI
104472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
10448
f863868c
LMI
10449 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
10450 quotes the next character, and doesn't affect other longer
10451 sequences (bug#8935).
10452
1d698799
LMI
10453 * lread.c (syms_of_lread): Clarify that is isn't only
10454 `eval-buffer' and `eval-defun' that's affected by
10455 `lexical-binding' (bug#8460).
10456
aa4b6df6
EZ
104572011-07-15 Eli Zaretskii <eliz@gnu.org>
10458
10459 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 10460 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 10461
5d856da6
PE
104622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
10463
ad6042bb
PE
10464 Fix minor problems found by static checking.
10465 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
10466 (elsz): Now a signed constant, not a size_t var. We prefer signed
10467 types to unsigned, to avoid integer comparison confusion. Without
10468 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
10469 "cannot optimize loop, the loop counter may overflow", a symptom
10470 of the confusion.
f00bbb22 10471 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
10472 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
10473
6468f31c
LMI
104742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10475
49080b10
LMI
10476 * search.c (Fre_search_backward): Mention `case-fold-search' in
10477 all the re_search_* functions (bug#8138).
10478
6468f31c
LMI
10479 * keyboard.c (Fopen_dribble_file): Document when the file is
10480 closed (bug#8056).
10481
c965adc5
EZ
104822011-07-14 Eli Zaretskii <eliz@gnu.org>
10483
df9733bf
EZ
10484 * bidi.c (bidi_dump_cached_states): Fix format of displaying
10485 bidi_cache_idx.
10486
0bb23927
EZ
10487 Support bidi reordering of display and overlay strings.
10488 * xdisp.c (compute_display_string_pos)
10489 (compute_display_string_end): Accept additional argument STRING.
10490 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
10491 (reseat_to_string): Initialize bidi_it->string.s and
10492 bidi_it->string.schars.
10493 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10494 NULL (avoids a crash in bidi_paragraph_init).
10495 Initialize itb.string.lstring.
0bb23927
EZ
10496 (init_iterator): Call bidi_init_it only of a valid
10497 buffer position was specified. Initialize paragraph_embedding to
10498 L2R.
10499 (reseat_to_string): Initialize the bidi iterator.
10500 (display_string): If we need to ignore text properties of
10501 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10502 original value of -1 will not work with bidi.)
10503 (compute_display_string_pos): First arg is now struct
10504 `text_pos *'; all callers changed. Support display properties on
10505 Lisp strings.
10506 (compute_display_string_end): Support display properties on Lisp
10507 strings.
10508 (init_iterator, reseat_1, reseat_to_string): Initialize the
10509 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10510 when iterating on a string not from display properties).
640c8776
SM
10511 (compute_display_string_pos, compute_display_string_end):
10512 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10513 arrow keys.
10514 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10515 base_level_stop; instead, set base_level_stop to BEGV.
10516 Fixes crashes in vertical-motion.
0bb23927
EZ
10517 (next_element_from_buffer): Improve commentary for when
10518 the iterator is before prev_stop.
10519 (init_iterator): Initialize bidi_p from the default value of
10520 bidi-display-reordering, not from buffer-local value. Use the
10521 buffer-local value only if initializing for buffer iteration.
10522 (handle_invisible_prop): Support invisible properties on strings
10523 that are being bidi-reordered.
10524 (set_iterator_to_next): Support bidi reordering of C strings and
10525 Lisp strings.
10526 (next_element_from_string): Support bidi reordering of Lisp
10527 strings.
10528 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10529 (display_string): Support display of R2L glyph rows.
10530 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10531 (init_iterator): Don't initialize it->bidi_p for strings
10532 here.
10533 (reseat_to_string): Initialize it->bidi_p for strings here.
10534 (next_element_from_string, next_element_from_c_string)
10535 (next_element_from_buffer): Add xassert's for correspondence
10536 between IT's object being iterated and it->bidi_it.string
10537 structure.
10538 (face_before_or_after_it_pos): Support bidi iteration.
10539 (next_element_from_c_string): Handle the case of the first string
10540 character that is not the first one in the visual order.
10541 (get_visually_first_element): New function, refactored from common
10542 parts of next_element_from_buffer, next_element_from_string, and
10543 next_element_from_c_string.
10544 (tool_bar_lines_needed, redisplay_tool_bar)
10545 (display_menu_bar): Force left-to-right direction. Add a FIXME
10546 comment for making that be controlled by a user option.
10547 (push_it, pop_it): Save and restore the state of the
10548 bidi iterator. Save and restore the bidi_p flag.
10549 (pop_it): Iterate out of display property for string iteration as
10550 well.
10551 (iterate_out_of_display_property): Support iteration over strings.
10552 (handle_single_display_spec): Set up it->bidi_it for iteration
10553 over a display string, and call bidi_init_it.
10554 (handle_single_display_spec, next_overlay_string)
10555 (get_overlay_strings_1, push_display_prop): Set up the bidi
10556 iterator for displaying display or overlay strings.
10557 (forward_to_next_line_start): Don't use the shortcut if
10558 bidi-iterating.
10559 (back_to_previous_visible_line_start): If handle_display_prop
10560 pushed the iterator stack, restore the internal state of the bidi
10561 iterator by calling bidi_pop_it same number of times.
10562 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10563 and we are bidi-iterating, don't decrement the iterator position;
10564 instead, set the first_elt flag in the bidi iterator, to produce
10565 the same effect.
10566 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10567 (push_display_prop): xassert that we are iterating a buffer.
10568 (push_it, pop_it): Save and restore paragraph_embedding member.
10569 (handle_single_display_spec, next_overlay_string)
10570 (get_overlay_strings_1, reseat_1, reseat_to_string)
10571 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10572 correctly. Don't assume unibyte strings are not bidi-reordered.
10573 (compute_display_string_pos)
10574 (compute_display_string_end): Fix handling the case of C string.
10575 (push_it, pop_it): Save and restore from_disp_prop_p.
10576 (handle_single_display_spec, push_display_prop): Set the
10577 from_disp_prop_p flag.
10578 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10579 (pop_it): Call iterate_out_of_display_property only if we are
10580 popping after iteration over a string that came from a display
10581 property. Fix a typo in popping stretch info. Add an assertion
10582 for verifying that the iterator position is in sync with the bidi
10583 iterator.
10584 (handle_single_display_spec, get_overlay_strings_1)
10585 (push_display_prop): Fix initialization of paragraph direction for
10586 string when that of the parent object is not yet determined.
10587 (reseat_1): Call bidi_init_it to resync the bidi
10588 iterator with IT's position. (Bug#7616)
10589 (find_row_edges): If ROW->start.pos gives position
10590 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10591 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10592 Reset the from_disp_prop_p flag.
10593 (SAVE_IT, RESTORE_IT): New macros.
10594 (pos_visible_p, face_before_or_after_it_pos)
10595 (back_to_previous_visible_line_start)
10596 (move_it_in_display_line_to, move_it_in_display_line)
10597 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10598 (try_scrolling, redisplay_window, display_line): Use them when
10599 saving a temporary copy of the iterator and restoring it back.
10600 (back_to_previous_visible_line_start, reseat_1)
10601 (init_iterator): Empty the bidi cache "stack".
10602 (move_it_in_display_line_to): If iterator ended up at
10603 EOL, but we never saw any buffer positions smaller than
10604 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10605 motion in bidi-reordered lines.
10606 (move_it_in_display_line_to): Record prev_method and prev_pos
10607 immediately before the call to set_iterator_to_next. Fixes cursor
10608 motion in bidi-reordered lines with stretch glyphs and strings
10609 displayed in margins. (Bug#8133) (Bug#8867)
10610 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10611 TO_CHARPOS.
640c8776
SM
10612 (pos_visible_p): Support positions in bidi-reordered lines.
10613 Save and restore bidi cache.
0bb23927
EZ
10614
10615 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10616 (bidi_paragraph_info): Delete unused struct.
10617 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10618 (bidi_cache_start): New variable.
10619 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10620 to zero.
10621 (bidi_cache_fetch_state, bidi_cache_search)
10622 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10623 (bidi_cache_find, bidi_peek_at_next_level)
10624 (bidi_level_of_next_char, bidi_find_other_level_edge)
10625 (bidi_move_to_visually_next): Compare cache index with
10626 bidi_cache_start rather than with zero.
10627 (bidi_fetch_char): Accept new argument STRING; all callers
10628 changed. Support iteration over a string. Support strings with
10629 display properties. Support unibyte strings. Fix the type of
10630 `len' according to what STRING_CHAR_AND_LENGTH expects.
10631 (bidi_paragraph_init, bidi_resolve_explicit_1)
10632 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10633 (bidi_level_of_next_char, bidi_move_to_visually_next):
10634 Support iteration over a string.
0bb23927
EZ
10635 (bidi_set_sor_type, bidi_resolve_explicit_1)
10636 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10637 can now be zero (for strings); special values 0 and -1 were
10638 changed to -1 and -2, respectively.
10639 (bidi_char_at_pos): New function.
10640 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10641 Call it instead of FETCH_MULTIBYTE_CHAR.
10642 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10643 initialized to valid values.
10644 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10645 values.
10646 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10647 the test for valid cached positions. Fix the logic for looking up
10648 the sentinel state in the cache. GCPRO the Lisp string we are
10649 iterating.
10650 (bidi_push_it, bidi_pop_it): New functions.
10651 (bidi_initialize): Initialize the bidi cache start stack pointer.
10652 (bidi_cache_ensure_space): New function, refactored from part of
10653 bidi_cache_iterator_state. Don't assume the required size is just
10654 one BIDI_CACHE_CHUNK away.
10655 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10656 (bidi_count_bytes, bidi_char_at_pos): New functions.
10657 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10658 always valid if bidi_cache_idx is valid.
10659 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10660 is valid if it's going to be used.
10661 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10662 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10663 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10664 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10665 (bidi_find_other_level_edge, bidi_cache_start_stack):
10666 All variables related to cache indices are now EMACS_INT.
c965adc5 10667
0bb23927
EZ
10668 * dispextern.h (struct bidi_string_data): New structure.
10669 (struct bidi_it): New member `string'. Make flag members be 1-bit
10670 fields, and put them last in the struct.
640c8776
SM
10671 (compute_display_string_pos, compute_display_string_end):
10672 Update prototypes.
0bb23927
EZ
10673 (bidi_push_it, bidi_pop_it): Add prototypes.
10674 (struct iterator_stack_entry): New members bidi_p,
10675 paragraph_embedding, and from_disp_prop_p.
10676 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10677 (bidi_shelve_cache, bidi_unshelve_cache):
10678 Declare prototypes.
0bb23927
EZ
10679
10680 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10681 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10682 and vector-like objects.
10683
10684 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10685 cache around display iteration.
10686
10687 * window.c (Fwindow_end, window_scroll_pixel_based)
10688 (displayed_window_lines, Frecenter): Save and restore the bidi
10689 cache around display iteration.
10690
3bbd2265
LMI
106912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10692
10693 * editfns.c (Fdelete_region): Clarify the use of the named
10694 parameters (bug#6788).
10695
adc47434
MR
106962011-07-14 Martin Rudalics <rudalics@gmx.at>
10697
10698 * indent.c (Fvertical_motion): Set and restore w->pointm when
10699 saving and restoring the window's buffer (Bug#9006).
10700
837c31f8
LMI
107012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10702
10703 * editfns.c (Fstring_to_char): Clarify just what is returned
10704 (bug#6576). Text by Eli Zaretskii.
10705
ac389d0c
JB
107062011-07-13 Juanma Barranquero <lekktu@gmail.com>
10707
10708 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10709
0be0ce47
EZ
107102011-07-13 Eli Zaretskii <eliz@gnu.org>
10711
10712 * buffer.c (mmap_find): Fix a typo.
10713
cd18e7e3
JB
107142011-07-13 Johan Bockgård <bojohan@gnu.org>
10715
10716 Fix execution of x selection hooks.
10717 * xselect.c (Qx_lost_selection_functions)
10718 (Qx_sent_selection_functions): New vars.
10719 (syms_of_xselect): DEFSYM them.
10720 (x_handle_selection_request): Pass Qx_sent_selection_functions
10721 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10722 (x_handle_selection_clear,x_clear_frame_selections):
10723 Pass Qx_lost_selection_functions rather than
10724 Vx_lost_selection_functions to Frun_hook_with_args.
10725
47ea7f44
PE
107262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10727
ac389d0c 10728 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10729 The old code sometimes used this field without initializing it.
10730
47ea7f44
PE
10731 * alloc.c (gc_sweep): Don't read past end of array.
10732 In theory, the old code could also have corrupted Emacs internals,
10733 though it'd be very unlikely.
10734
bc985c87
AS
107352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10736
10737 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10738 argument. (Bug#4026)
bc985c87 10739
0cf34688
LMI
107402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10741
b3dadd76
LMI
10742 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10743 key" (bug#4257).
10744
0cf34688
LMI
10745 * window.c (Fset_window_start): Doc fix (bug#4199).
10746 (Fset_window_hscroll): Ditto.
10747
270768cd
PE
107482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10749
077e3dda 10750 Fix minor new problems caught by GCC 4.6.1.
270768cd 10751 * term.c (init_tty): Remove unused local.
490011a6 10752 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10753 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10754 not used otherwise.
270768cd 10755
b1f58454
CY
107562011-07-12 Chong Yidong <cyd@stupidchicken.com>
10757
10758 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10759
22b9578d
LMI
107602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10761
6e70ab07
LMI
10762 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10763 are the mini-buffer and the echo area (bug#3320).
10764
22b9578d
LMI
10765 * term.c (init_tty): Remove support for supdup, c10 and perq
10766 terminals, which are no longer supported (bug#1482).
10767
8974cc9f
JB
107682011-07-10 Johan Bockgård <bojohan@gnu.org>
10769
10770 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10771
a560d974
JD
107722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10773
10774 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10775 for non-popups (Bug#3642).
10776
1dae0f0a
AS
107772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10778
268c2c36 10779 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10780 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10781 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10782 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10783 * data.c (fmod): Likewise.
10784 * dispnew.c (swap_glyphs_in_rows): Likewise.
10785 * emacs.c (memory_warning_signal): Likewise.
10786 * floatfns.c (float_error): Likewise.
10787 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10788 (otf_open, font_otf_capability, generate_otf_features)
10789 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10790 Likewise.
10791 * image.c (pbm_read_file): Likewise.
10792 * indent.c (string_display_width): Likewise.
10793 * intervals.c (check_for_interval, search_for_interval)
10794 (inc_interval_count, count_intervals, root_interval)
10795 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10796 * lread.c (defalias): Likewise.
268c2c36 10797 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10798 * regex.c (set_image_of_range_1, set_image_of_range)
10799 (regex_grow_registers): Likewise.
10800 * sysdep.c (strerror): Likewise.
10801 * termcap.c (valid_filename_p, tprint, main): Likewise.
10802 * tparam.c (main): Likewise.
10803 * unexhp9k800.c (run_time_remap, save_data_space)
10804 (update_file_ptrs, read_header, write_header, calculate_checksum)
10805 (copy_file, copy_rest, display_header): Likewise.
10806 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10807 Likewise.
10808 * xdisp.c (check_it): Likewise.
10809 * xfaces.c (register_color, unregister_color, unregister_colors):
10810 Likewise.
10811 * xfns.c (print_fontset_result): Likewise.
10812 * xrdb.c (member, fatal, main): Likewise.
10813
99033785
PE
108142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10815
10816 Fix minor problems found by static checking (Bug#9031).
10817 * chartab.c (char_table_set_range, map_sub_char_table):
10818 Remove unused locals.
10819 (uniprop_table): Now static.
10820 * composite.c (_work_char): Remove unused static var.
10821
9cb2ac56
JB
108222011-07-09 Juanma Barranquero <lekktu@gmail.com>
10823
10824 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10825
f25661f0
JD
108262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10827
10828 * gtkutil.c (qttip_cb): Remove code without function.
10829
8278c4fe
EZ
108302011-07-09 Eli Zaretskii <eliz@gnu.org>
10831
10832 * w32.c (pthread_sigmask): New stub.
10833
1692ae2d 108342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10835
8a6ebd58 10836 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10837 sigprocmask is portable only for single-threaded applications, and
10838 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10839 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10840 (LIBES): Use it.
10841 * callproc.c (Fcall_process):
10842 * process.c (create_process):
10843 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10844 Use pthread_sigmask, not sigprocmask.
123403e4 10845
1b854618
JD
108462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10847
10848 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10849 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10850 wrong (Bug#8591).
10851
3fe4b549
JD
108522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10853
0ce7e563
JD
10854 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10855 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10856 (xg_hide_tooltip): Fix comment.
10857
3fe4b549
JD
10858 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10859 in registerServicesMenuSendTypes.
10860 (validRequestorForSendType): Don't check ns_return_types.
10861
10862 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10863 ns_return_type.
10864
5df75e47
JR
108652011-07-08 Jason Rumney <jasonr@gnu.org>
10866
22610910
JR
10867 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10868 SH_SHOW for hidden windows (Bug#5482).
10869
5df75e47
JR
10870 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10871 frame struct members of non-existent frames (Bug#6284).
10872
699c10bd
JD
108732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10874
4393663b
JD
10875 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10876 variable firstTime not needed on OSX >= 10.6.
10877 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10878 >= 10.5. Use setKnobProportion, setDoubleValue.
10879
10880 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10881 (MAC_OS_X_VERSION_10_5): Define if not defined.
10882 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10883 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10884 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10885
10886 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10887 cString and lossyCString on OSX >= 10.4.
4393663b 10888
58179cce 10889 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10890 sizeToFit on OSX >= 10.2.
10891
10892 * nsimage.m (allocInitFromFile): Don't use deprecated method
10893 bestRepresentationForDevice on OSX >= 10.6.
10894
10895 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10896 to avoid warning.
10897
10898 * emacs.c: Declare unexec_init_emacs_zone.
10899
a63e0781
JD
10900 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10901
699c10bd
JD
10902 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10903
10904 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10905 on svcsMenu (Bug#8842).
10906
10907 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10908 ns_return_types.
10909 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10910
10911 * nsterm.m (QUTF8_STRING): Declare.
10912 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10913 (validRequestorForSendType): Return type is (id).
10914 Change indexOfObjectIdenticalTo to indexOfObject.
10915 Check if we have local selection before returning self (Bug#8842).
10916 (writeSelectionToPasteboard): Put local selection into paste board
10917 if we have a local selection (Bug#8842).
10918 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10919
10920 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10921 (ns_get_local_selection): Declare.
10922
54e10184
LMI
109232011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10924
9888ff71
LMI
10925 * keymap.c (describe_map_tree): Don't insert a double newline at
10926 the end of the buffer (bug#1169) and return whether we inserted
10927 something.
10928
54e10184
LMI
10929 * callint.c (Fcall_interactively): Change "reading args" to
10930 "providing args" to try to clarify what it does (bug#1010).
10931
15fa4783
KH
109322011-07-07 Kenichi Handa <handa@m17n.org>
10933
10934 * composite.c (composition_compute_stop_pos): Ignore a static
10935 composition starting before CHARPOS (Bug#8915).
10936
10937 * xdisp.c (handle_composition_prop): Likewise.
10938
a8815b00
EZ
109392011-07-07 Eli Zaretskii <eliz@gnu.org>
10940
10941 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10942 (Bug#9015)
10943
ef7b981d 109442011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10945
10946 * character.h (unicode_category_t): New enum type.
10947
10948 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10949 (Qchar_code_property_table): New variable.
10950 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10951 (UNIPROP_COMPRESSED_FORM_P): New macros.
10952 (char_table_ascii): Uncompress the compressed values.
10953 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10954 Uncompress the compressed values.
ac389d0c 10955 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10956 (char_table_ref_and_range): Uncompress the compressed values.
10957 (sub_char_table_set): New arg is_uniprop. Callers changed.
10958 Uncompress the compressed values.
10959 (sub_char_table_set_range): Args changed. Callers changed.
10960 (char_table_set_range): Adjuted for the above change.
10961 (map_sub_char_table): Delete args default_val and parent. Add arg
10962 top. Give decoded values to a Lisp function.
640c8776 10963 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10964 values to a Lisp function. Gcpro more variables.
10965 (uniprop_table_uncompress)
10966 (uniprop_decode_value_run_length): New functions.
10967 (uniprop_decoder, uniprop_decoder_count): New variables.
10968 (uniprop_get_decoder, uniprop_encode_value_character)
10969 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10970 New functions.
10971 (uniprop_encoder, uniprop_encoder_count): New variables.
10972 (uniprop_get_encoder, uniprop_table)
10973 (Funicode_property_table_internal, Fget_unicode_property_internal)
10974 (Fput_unicode_property_internal): New functions.
10975 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10976 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10977 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10978 char-code-property-alist.
10979
640c8776 10980 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10981 Vunicode_category_table.
10982
640c8776 10983 * font.c (font_range): Adjust for the change of
c805dec0
KH
10984 Vunicode_category_table.
10985
76b397fb
DN
109862011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10987
10988 * m/iris4d.h: Remove file, move contents ...
10989 * s/irix6-5.h: ... here.
10990
22b4128e
PE
109912011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10992
10993 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10994 * alloc.c (mark_buffer):
10995 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10996 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10997 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10998 This isn't true in general, and it's particularly not true
10999 if Emacs is configured with --with-wide-int.
11000 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11001 New macros, used in the buffer.c change.
11002
869795d6
JD
110032011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11004
11005 * xsettings.c: Use both GConf and GSettings if both are available.
11006 (store_config_changed_event): Add comment.
11007 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11008 (store_tool_bar_style_changed): New functions.
5e617bc2 11009 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11010 (struct xsettings): Move font inside HAVE_XFT.
11011 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11012 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11013 Move inside HAVE_XFT.
640c8776 11014 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11015 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11016 also.
11017 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11018 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11019 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11020 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11021 (parse_settings): Move check for font inside HAVE_XFT.
11022 (read_settings, apply_xft_settings): Add comment.
11023 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11024 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11025 call store_font_name_changed.
11026 (xft_settings_event): Add comment.
11027 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11028 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11029 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11030 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11031 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11032 (xsettings_get_system_font, xsettings_get_system_normal_font):
11033 Add comment.
869795d6 11034
d8ed26bd
PE
110352011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11036
11037 Random fixes. E.g., (random) never returned negative values.
11038 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11039 subseconds part to the entropy, as that's a bit more random.
11040 Prefer signed to unsigned, since the signedness doesn't matter and
11041 in general we prefer signed. When given a limit, use a
11042 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11043 latter isn't right if USE_2_TAGS_FOR_INTS.
11044 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11045 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11046
cabf1cac
SM
110472011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11048
11049 * textprop.c (text_property_stickiness):
11050 Obey Vtext_property_default_nonsticky.
11051 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11052 * w32fns.c (syms_of_w32fns):
11053 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11054
6e9b2be9
PE
110552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11056
11057 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11058 This is more efficient than Ffile_directory_p and avoids a minor race.
11059
90186c68
LMI
110602011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11061
7c301272
LMI
11062 * buffer.c (Foverlay_put): Say what the return value is
11063 (bug#7835).
11064
c4f2d8d4
LMI
11065 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11066 is a directory before asking whether to use the file name
11067 (bug#7564).
ad637907
LMI
11068 (barf_or_query_if_file_exists): Make the "File is a directory"
11069 error be more correct.
c4f2d8d4 11070
90186c68
LMI
11071 * fns.c (Frequire): Remove the mention of the .gz files, since
11072 that's installation-specific, but keep the mention of
11073 `get-load-suffixes'.
11074
da64016e
PE
110752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11076
11077 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11078 Report string overflow if the output is too long.
11079
7d47b580
JB
110802011-07-04 Juanma Barranquero <lekktu@gmail.com>
11081
a555cb87
JB
11082 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11083 (syms_of_gnutls): Remove duplicate DEFSYM for
11084 Qgnutls_bootprop_verify_hostname_error, an error for
11085 Qgnutls_bootprop_verify_error (which is no longer used).
11086
7d47b580
JB
11087 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11088 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11089 Also (re)move comments that are misplaced or no longer relevant.
11090
1e49bfab
LMI
110912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11092
11093 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11094
1485f4c0
CY
110952011-07-03 Chong Yidong <cyd@stupidchicken.com>
11096
11097 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11098 and background color parameters if they have been changed.
11099
a9ab721e
LMI
111002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11101
11102 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11103
cf7cff57
PE
111042011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11105
2e13213d
PE
11106 * xsettings.c (SYSTEM_FONT): Define only when used.
11107 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11108
cf7cff57
PE
11109 * keymap.c (access_keymap_1): Now static.
11110
7a8e04f7
CY
111112011-07-02 Chong Yidong <cyd@stupidchicken.com>
11112
11113 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11114 leave any prefix arg for the up event (Bug#1586).
11115
61352f62
LMI
111162011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11117
69bb1ef7
LMI
11118 * lread.c (syms_of_lread): Mention single symbols defined by
11119 `defvar' or `defconst' (bug#7154).
11120
61352f62 11121 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 11122 (Frequire): Mention get-load-suffixes.
61352f62 11123
28545e04
MR
111242011-07-02 Martin Rudalics <rudalics@gmx.at>
11125
11126 * window.h (window): Remove clone_number slot.
11127 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11128 Remove.
11129 (make_parent_window, make_window, saved_window)
11130 (Fset_window_configuration, save_window_save): Don't deal with
11131 clone numbers.
11132 * buffer.c (Qclone_number): Remove declaration.
11133 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11134
3349e122
SM
111352011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11136
11137 Add multiple inheritance to keymaps.
11138 * keymap.c (Fmake_composed_keymap): New function.
11139 (Fset_keymap_parent): Simplify.
11140 (fix_submap_inheritance): Remove.
11141 (access_keymap_1): New function extracted from access_keymap to handle
11142 embedded parents and handle lists of maps.
11143 (access_keymap): Use it.
11144 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11145 (Fcopy_keymap): Handle embedded parents.
11146 (Fcommand_remapping, define_as_prefix): Simplify.
11147 (Fkey_binding): Simplify.
11148 (syms_of_keymap): Move minibuffer-local-completion-map,
11149 minibuffer-local-filename-completion-map,
11150 minibuffer-local-must-match-map, and
11151 minibuffer-local-filename-must-match-map to Elisp.
11152 (syms_of_keymap): Defsubr make-composed-keymap.
11153 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11154 (parse_menu_item): Trivial simplification.
11155
3279eb87
GM
111562011-07-01 Glenn Morris <rgm@gnu.org>
11157
11158 * Makefile.in (SETTINGS_LIBS): Fix typo.
11159
39cb9e56 111602011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11161
11162 * coding.c (Fencode_coding_string): Record the last coding system
11163 used, as the function doc string says (bug#8738).
11164
0949d2b6
JD
111652011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11166
11167 * xsettings.c (store_monospaced_changed): Take new font as arg and
11168 check for change against current_mono_font.
11169 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11170 (emacs_settings_constructor, emacs_settings_get_property)
11171 (emacs_settings_set_property, emacs_settings_class_init)
11172 (emacs_settings_init, gsettings_obj): Remove.
11173 (something_changedCB): New function for HAVE_GSETTINGS.
11174 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11175 with value as argument.
11176 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11177 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11178 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11179 "changed".
11180
11181 * xgselect.c: Add defined (HAVE_GSETTINGS).
11182 (xgselect_initialize): Ditto.
11183
11184 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11185 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11186 xg_select.
11187
bbc6b304
PE
111882011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11189
11190 * eval.c (struct backtrace): Simplify and port the data structure.
11191 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11192 signed bit field, as this assumption is not portable and it makes
11193 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11194 "char debug_on_exit : 1" as this is not portable either; instead,
11195 use the portable "unsigned int debug_on_exit : 1". Remove unused
11196 member evalargs. Remove obsolete comments about cc bombing out.
11197
9851bfc5
JD
111982011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11199
51bb811f 11200 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11201 Let HAVE_GSETTINGS override HAVE_GCONF.
11202 (store_monospaced_changed): New function.
11203 (EMACS_SETTINGS): A new type derived from GObject to handle
11204 GSettings notifications.
11205 (emacs_settings_constructor, emacs_settings_get_property)
11206 (emacs_settings_set_property, emacs_settings_class_init):
11207 New functions.
11208 (gsettings_client, gsettings_obj): New variables.
11209 (GSETTINGS_SCHEMA): New define.
11210 (something_changedCB): Call store_monospaced_changed.
11211 (init_gsettings): New function.
11212 (xsettings_initialize): Call init_gsettings.
11213 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
11214 to NULL.
11215
640c8776 11216 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
11217 GCONF_CFLAGS/LIBS.
11218
5386012d
MR
112192011-06-29 Martin Rudalics <rudalics@gmx.at>
11220
11221 * window.c (resize_root_window, grow_mini_window)
11222 (shrink_mini_window): Rename Qresize_root_window to
11223 Qwindow_resize_root_window and Qresize_root_window_vertically to
11224 Qwindow_resize_root_window_vertically.
11225
f13e0b08
PE
112262011-06-28 Paul Eggert <eggert@cs.ucla.edu>
11227
11228 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11229
94515237
JB
112302011-06-27 Juanma Barranquero <lekktu@gmail.com>
11231
11232 * makefile.w32-in: Redesign dependencies so they reflect more
11233 clearly which files are directly included by each source file,
11234 and not through other includes.
11235
e43b6e43
MR
112362011-06-27 Martin Rudalics <rudalics@gmx.at>
11237
11238 * buffer.c (Qclone_number): Declare static and DEFSYM it.
11239 (sort_overlays, overlay_strings): When an overlay's clone number
11240 matches the window's clone number process the overlay even if
11241 the overlay's window property doesn't match the current window.
11242
d68443dc
MR
11243 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
11244 (Fwindow_hchild): Rename to Fwindow_left_child.
11245 (Fwindow_next): Rename to Fwindow_next_sibling.
11246 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
11247 (resize_window_check): Rename to window_resize_check.
11248 (resize_window_apply): Rename to window_resize_apply.
11249 (Fresize_window_apply): Rename to Fwindow_resize_apply.
11250 (Fdelete_other_windows_internal, resize_frame_windows)
11251 (Fsplit_window_internal, Fdelete_window_internal)
11252 (grow_mini_window, shrink_mini_window)
11253 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 11254
c7e73be5
JD
112552011-06-26 Jan Djärv <jan.h.d@swipnet.se>
11256
11257 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11258 (emacs_fixed_set_min_size): Remove.
11259 (emacs_fixed_new): Take frame as argument.
11260
11261 * emacsgtkfixed.c: State that this is only used with Gtk+3.
11262 (_EmacsFixedPrivate): Remove minwidth/height.
11263 Add struct frame *f.
11264 (emacs_fixed_init): Initialize priv->f.
11265 (get_parent_class, emacs_fixed_set_min_size): Remove.
11266 (emacs_fixed_new): Set priv->f to argument.
11267 (emacs_fixed_get_preferred_width)
11268 (emacs_fixed_get_preferred_height): Use min_width/height from
11269 frames size_hint to set minimum and natural (Bug#8919).
11270 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
11271 and use min_width/height from frames size_hint to set
11272 min_width/height (Bug#8919).
11273
11274 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
11275 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
11276 Fix indentation.
c7e73be5 11277
cf99dcf8
EZ
112782011-06-26 Eli Zaretskii <eliz@gnu.org>
11279
11280 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
11281 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
11282 called at ZV.
11283
029529ac
CY
112842011-06-26 Chong Yidong <cyd@stupidchicken.com>
11285
11286 * process.c (wait_reading_process_output): Bypass select if
11287 waiting for a cell while ignoring keyboard input, and input is
11288 pending. Suggested by Jan Djärv (Bug#8869).
11289
7a7ef429
PE
112902011-06-25 Paul Eggert <eggert@cs.ucla.edu>
11291
11292 Use gnulib's dup2 module instead of rolling our own.
11293 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11294
11fdef7d 112952011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
11296
11297 * dispnew.c (scrolling_window): Before scrolling, turn off a
11298 mouse-highlight in the window being scrolled.
11299
cd3520a4
JB
113002011-06-24 Juanma Barranquero <lekktu@gmail.com>
11301
11302 Move DEFSYM to lisp.h and use everywhere.
11303
11304 * character.h (DEFSYM): Move declaration...
11305 * lisp.h (DEFSYM): ...here.
11306
11307 * gnutls.c:
11308 * minibuf.c:
11309 * w32menu.c:
11310 * w32proc.c:
11311 * w32select.c: Don't include character.h.
11312
11313 * alloc.c (syms_of_alloc):
11314 * buffer.c (syms_of_buffer):
11315 * bytecode.c (syms_of_bytecode):
11316 * callint.c (syms_of_callint):
11317 * casefiddle.c (syms_of_casefiddle):
11318 * casetab.c (init_casetab_once):
11319 * category.c (init_category_once, syms_of_category):
11320 * ccl.c (syms_of_ccl):
11321 * cmds.c (syms_of_cmds):
11322 * composite.c (syms_of_composite):
11323 * dbusbind.c (syms_of_dbusbind):
11324 * dired.c (syms_of_dired):
11325 * dispnew.c (syms_of_display):
11326 * doc.c (syms_of_doc):
11327 * editfns.c (syms_of_editfns):
11328 * emacs.c (syms_of_emacs):
11329 * eval.c (syms_of_eval):
11330 * fileio.c (syms_of_fileio):
11331 * fns.c (syms_of_fns):
11332 * frame.c (syms_of_frame):
11333 * fringe.c (syms_of_fringe):
11334 * insdel.c (syms_of_insdel):
11335 * keymap.c (syms_of_keymap):
11336 * lread.c (init_obarray, syms_of_lread):
11337 * macros.c (syms_of_macros):
11338 * msdos.c (syms_of_msdos):
11339 * print.c (syms_of_print):
11340 * process.c (syms_of_process):
11341 * search.c (syms_of_search):
11342 * sound.c (syms_of_sound):
11343 * syntax.c (init_syntax_once, syms_of_syntax):
11344 * terminal.c (syms_of_terminal):
11345 * textprop.c (syms_of_textprop):
11346 * undo.c (syms_of_undo):
11347 * w32.c (globals_of_w32):
11348 * window.c (syms_of_window):
11349 * xdisp.c (syms_of_xdisp):
11350 * xfaces.c (syms_of_xfaces):
11351 * xfns.c (syms_of_xfns):
11352 * xmenu.c (syms_of_xmenu):
11353 * xsettings.c (syms_of_xsettings):
11354 * xterm.c (syms_of_xterm): Use DEFSYM.
11355
4228cf16
TZ
113562011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
11357
cd3520a4 11358 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 11359
7fcccf1e
PE
113602011-06-23 Paul Eggert <eggert@cs.ucla.edu>
11361
7efb4e0e
PE
11362 Integer and buffer overflow fixes (Bug#8873).
11363
ff5844ad
PE
11364 * print.c (printchar, strout): Check for string overflow.
11365 (PRINTPREPARE, printchar, strout):
11366 Don't set size unless allocation succeeds.
11367
90532f02
PE
11368 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
11369 for sizes. Check for string overflow more accurately.
11370 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
11371
6d84508d
PE
11372 * macros.c: Integer and buffer overflow fixes.
11373 * keyboard.h (struct keyboard.kbd_macro_bufsize):
11374 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
11375 Use ptrdiff_t, not int, for sizes.
11376 Don't increment bufsize until after realloc succeeds.
11377 Check for size-calculation overflow.
11378 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
11379
437b2cb4
PE
11380 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
11381
8b9ac8b4
PE
11382 * lread.c: Integer overflow fixes.
11383 (read_integer): Radix is now EMACS_INT, not int,
11384 to improve quality of diagnostics for out-of-range radices.
11385 Calculate buffer size correctly for out-of-range radices.
11386 (read1): Check for integer overflow in radices, and in
11387 read-circle numbers.
82cb60d3
PE
11388 (read_escape): Avoid int overflow.
11389 (Fload, openp, read_buffer_size, read1)
11390 (substitute_object_recurse, read_vector, read_list, map_obarray):
11391 Use ptrdiff_t, not int, for sizes.
11392 (read1): Use EMACS_INT, not int, for sizes.
20270765 11393 Check for size overflow.
8b9ac8b4 11394
7fcccf1e
PE
11395 * image.c (cache_image): Check for size arithmetic overflow.
11396
bfbbd7e7
PE
11397 * lread.c: Integer overflow issues.
11398 (saved_doc_string_size, saved_doc_string_length)
11399 (prev_saved_doc_string_size, prev_saved_doc_string_length):
11400 Now ptrdiff_t, not int.
11401 (read1): Don't assume doc string length fits in int. Check for
11402 out-of-range doc string lengths.
11403 (read_list): Don't assume file position fits in int.
39019e54 11404 (read_escape): Check for hex character overflow.
bfbbd7e7 11405
4e323265
LL
114062011-06-22 Leo Liu <sdl.web@gmail.com>
11407
11408 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
11409 Move to minibuffer.el.
11410
85fece3e
PE
114112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11412
20b84ce9 11413 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
11414 The following patches are for when GLYPH_DEBUG && !XASSERT.
11415 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11416 * dispnew.c (flush_stdout):
11417 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
11418 Mark as externally visible.
11419 * dispnew.c (check_window_matrix_pointers): Now static.
11420 * dispnew.c (window_to_frame_vpos):
11421 * xfns.c (unwind_create_frame):
11422 * xterm.c (x_check_font): Remove unused local.
11423 * scroll.c (CHECK_BOUNDS):
11424 * xfaces.c (cache_fache): Rename local to avoid shadowing.
11425 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
11426 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
11427 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
11428 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
11429 Now static.
11430 (debug_method_add): Use va_list and vsprintf rather than relying
11431 on undefined behavior with wrong number of arguments.
11432 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
11433 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
11434 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
11435 since we're not interested in debugging glyphs with old libraries.
11436 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
11437 GCC 4.6.0's static checking.
11438
0766b489
PE
114392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11440
31fd4b32
PE
11441 Integer overflow and signedness fixes (Bug#8873).
11442 A few related buffer overrun fixes, too.
11443
b79e8648
PE
11444 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
11445
0766b489
PE
11446 * dispextern.h (struct face.stipple):
11447 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
11448 (x_bitmap_mask, x_allocate_bitmap_record)
11449 (x_create_bitmap_from_data, x_create_bitmap_from_file)
11450 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
11451 (x_create_bitmap_from_xpm_data):
11452 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
11453 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
11454 (.bitmaps_last):
11455 * xfaces.c (load_pixmap):
11456 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
11457 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
11458 (.bitmaps_last, struct x_output.icon_bitmap):
11459 Use ptrdiff_t, not int, for bitmap indexes.
11460 (x_allocate_bitmap_record): Check for size overflow.
11461 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
11462
b081724f
PE
11463 Use ptrdiff_t, not int, for overlay counts.
11464 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
11465 * editfns.c (overlays_around, get_pos_property):
11466 * textprop.c (get_char_property_and_overlay):
11467 * xdisp.c (next_overlay_change, note_mouse_highlight):
11468 * xfaces.c (face_at_buffer_position):
21514da7
PE
11469 * buffer.c (OVERLAY_COUNT_MAX): New macro.
11470 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11471 (Fnext_overlay_change, Fprevious_overlay_change)
11472 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 11473 Use ptrdiff_t, not int, for sizes.
21514da7 11474 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 11475
3de73e5e
PE
11476 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
11477
2606c57b
PE
11478 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
11479 (x_session_initialize): Do not assume string length fits in int.
11480
aaafe47a
PE
11481 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
11482 This is unlikely, but can occur if DPI is outlandish.
11483
2674ddc8 11484 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
11485 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11486
28154962
PE
11487 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
11488 * xrdb.c (magic_file_p, search_magic_path):
11489 Omit last arg SUFFIX; it was always 0. All callers changed.
11490 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
11491
7de51af5
PE
11492 * xfont.c (xfont_match): Avoid need for strlen.
11493
25ed6cc3
PE
11494 * xfns.c: Don't assume strlen fits in int.
11495 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11496
4eab31dd
PE
11497 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11498 not unsigned long, as we prefer signed integers. All callers changed.
11499 Detect integer overflow in repeat count.
11500 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11501 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11502
171e2a58
PE
11503 * termcap.c: Don't assume sizes fit in int and never overflow.
11504 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11505 (gobble_line): Check for size-calculation overflow.
11506
ad39faca 11507 * minibuf.c (Fread_buffer):
6e5bb2dc 11508 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11509 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11510 Don't assume string length fits in int.
11511
52c61c22 11512 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11513 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11514
b5b8c9e5
PE
11515 * font.c: Don't assume string length fits in int.
11516 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11517 Use ptrdiff_t, not int.
ccd6111c
PE
11518 (font_intern_prop): Don't assume string length fits in int.
11519 Don't assume integer property fits in fixnum.
11520 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11521
882f0d81 11522 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11523 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11524 Reformulate so as not to need the command string.
11525 Invoke gzip -cd rather than gunzip, as it's more portable.
11526 (lock_info_type, lock_file_1, lock_file):
11527 Don't assume pid_t and time_t fit in unsigned long.
11528 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11529 (current_lock_owner): Prefer signed type for sizes.
11530 Use memcpy, not strncpy, where memcpy is what is really wanted.
11531 Don't assume (via atoi) that time_t and pid_t fit in int.
11532 Check for time_t and/or pid_t out of range, e.g., via a network share.
11533 Don't alloca where an auto var works fine.
11534
93f4cf88
PE
11535 * fileio.c: Fix some integer overflow issues.
11536 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11537 Don't assume string length fits in int.
11538 (directory_file_name): Don't assume string length fits in long.
11539 (make_temp_name): Don't assume pid fits in int, or that its print
11540 length is less than 20.
11541
f3e92b69
PE
11542 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11543
1bfdaf10
PE
11544 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11545
35016e9a
PE
11546 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11547
3d1e65a1
PE
11548 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11549 We prefer signed integers, even for size calculations.
11550
0b963a93
PE
11551 * emacs.c: Don't assume string length fits in 'int'.
11552 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11553 (main): Don't invoke strlen when not needed.
11554
573f4b54
PE
11555 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11556 (XD_DEBUG_MESSAGE): Don't waste a byte.
11557
989f33ba
PE
11558 * callproc.c (getenv_internal_1, getenv_internal)
11559 (Fgetenv_internal):
965d34eb
PE
11560 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11561
e4d29b33
PE
11562 * lread.c (invalid_syntax): Omit length argument.
11563 All uses changed. This doesn't fix a bug, but it simplifies the
11564 code away from its former Hollerith-constant appearance, and it's
11565 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11566 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11567
eb49b136
PE
11568 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11569 This didn't break anything, but it didn't help either.
11570 It's confusing to put a bogus integer in a place where the actual
11571 value does not matter.
9f62aeb1 11572 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11573 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11574
15375a22
PE
11575 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11576 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11577 implementation.
b61cc01c
PE
11578 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11579 We prefer signed types, and the value cannot exceed the EMACS_INT
11580 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11581 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11582 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11583 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11584
53b2623d
PE
11585 * indent.c (sane_tab_width): New function.
11586 (current_column, scan_for_column, Findent_to, position_indentation)
11587 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11588 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11589
51cab52b 11590 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11591
f2ed8a70
PE
11592 * lisp.h (lint_assume): New macro.
11593 * composite.c (composition_gstring_put_cache):
11594 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11595
abe80cc6
PE
11596 * editfns.c, insdel.c:
11597 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11598
b02c740e
PE
11599 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11600
ebc96716
PE
11601 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11602
b4e50fa0 11603 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11604 Use much-faster test for byte-length change.
311d5d7c 11605 Don't assume string byte-length fits in 'int'.
a4cf38e4 11606 Check that character arg fits in 'int'.
85461888 11607 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11608
c0c1ee9f
PE
11609 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11610
a498d7f4
PE
11611 * fns.c (concat): Catch string overflow earlier.
11612 Do not rely on integer wraparound.
11613
51cab52b
PE
11614 * dispextern.h (struct it.overlay_strings_charpos)
11615 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11616 * xdisp.c (forward_to_next_line_start)
11617 (back_to_previous_visible_line_start)
11618 (reseat_at_next_visible_line_start, next_element_from_buffer):
11619 Don't arbitrarily truncate the value of 'selective' to int.
11620
76031fad
PE
11621 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11622
5eb55db9
PE
11623 * composite.c: Don't truncate sizes to 'int'.
11624 (composition_gstring_p, composition_reseat_it)
11625 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11626 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11627 not EMACS_UINT, for indexes.
5eb55db9 11628
0703a717
PE
11629 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11630
d6202519
PE
11631 * buffer.c: Include <verify.h>.
11632 (struct sortvec.priority, struct sortstr.priority):
8961a454 11633 Now EMACS_INT, not int.
c20998a7 11634 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11635 (struct sortstr.size, record_overlay_string)
11636 (struct sortstrlist.size, struct sortlist.used):
11637 Don't truncate size to int.
11638 (record_overlay_string): Check for size-calculation overflow.
d6202519 11639 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11640
d5a19415
JM
116412011-06-22 Jim Meyering <meyering@redhat.com>
11642
029529ac 11643 Don't leak an XBM-image-sized buffer
d5a19415
JM
11644 * image.c (xbm_load): Free the image buffer after using it.
11645
a9041e6c
PE
116462011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11647
11648 Port to Sun C.
11649 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11650 that Sun C diagnosed.
11651 * fns.c (secure_hash): Fix pointer signedness issue.
11652 * intervals.c (static_offset_intervals): New function.
11653 (offset_intervals): Use it.
11654
7f3f739f
LL
116552011-06-21 Leo Liu <sdl.web@gmail.com>
11656
11657 * deps.mk (fns.o):
11658 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11659 sha512.h.
11660
11661 * fns.c (secure_hash): Rename from crypto_hash_function and change
11662 the first arg to accept symbols.
5b66d427 11663 (Fsecure_hash): New primitive.
7f3f739f
LL
11664 (syms_of_fns): New symbols.
11665
76147d94
DD
116662011-06-20 Deniz Dogan <deniz@dogan.se>
11667
11668 * process.c (Fset_process_buffer): Clarify return value in
11669 docstring.
11670
7d7d0045
CY
116712011-06-18 Chong Yidong <cyd@stupidchicken.com>
11672
11673 * dispnew.c (add_window_display_history): Use BVAR.
11674
11675 * xdisp.c (debug_method_add): Use BVAR.
11676 (check_window_end, dump_glyph_matrix, dump_glyph)
11677 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11678
11679 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11680 Likewise.
11681
11682 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11683 check till after the cache is created in init_frame_faces.
11684
ff2bc410
SM
116852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11686
11687 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11688
28177add
PE
116892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11690
dd3482fe
PE
11691 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11692 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11693 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11694
393d71f3 11695 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11696 * fileio.c (Finsert_file_contents):
11697 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11698 Remove the old (too-loose) buffer overflow checks.
11699 They weren't needed, since make_gap checks for buffer overflow.
11700 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11701 The old code merely checked for Emacs fixnum overflow, and relied
11702 on undefined (wraparound) behavior. The new code avoids undefined
11703 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11704
2e6813b0 11705 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11706 Tune. Don't use wider integers than needed. Don't use alloca.
11707 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11708
599a9e4f
PE
11709 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11710
99561444
PE
11711 * insdel.c, lisp.h (buffer_overflow): New function.
11712 (insert_from_buffer_1, replace_range, replace_range_2):
11713 * insdel.c (make_gap_larger):
11714 * editfns.c (Finsert_char):
11715 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11716
28177add
PE
11717 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11718
e69dafad
PE
117192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11720
4baa020d 11721 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11722
b1c46f02
PE
11723 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11724 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11725
e69dafad
PE
11726 * fileio.c: Don't assume EMACS_INT fits in off_t.
11727 (emacs_lseek): New static function.
11728 (Finsert_file_contents, Fwrite_region): Use it.
11729 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11730
566684ea
PE
11731 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11732
e6966cd6
PE
11733 * fns.c: Don't overflow int when computing a list length.
11734 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11735 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11736 truncation on 64-bit hosts. Check for QUIT every
11737 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11738 faster and is responsive enough.
11739 (Flength): Report an error instead of overflowing an integer.
11740 (Fsafe_length): Return a float if the value is not representable
11741 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11742 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11743 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11744
dd0b0efb
PE
11745 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11746 (header_size, word_size): New constants.
11747 (allocate_vectorlike): Don't check size overflow here.
11748 (allocate_vector): Check it here instead, since this is the only
11749 caller of allocate_vectorlike that could cause overflow.
11750 Check that the new vector's length is representable as a fixnum.
11751
86fe5cfe
PE
11752 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11753 The previous code was bogus. For example, next_almost_prime (32)
11754 returned 39, which is undesirable as it is a multiple of 3; and
11755 next_almost_prime (24) returned 25, which is a multiple of 5 so
11756 why was the code bothering to check for multiples of 7?
11757
80e88859
PE
11758 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11759
4a2f0ad6
PE
11760 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11761
f66c7cf8
PE
11762 Variadic C functions now count arguments with ptrdiff_t.
11763 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11764 Back then I didn't know that the Emacs coding style prefers signed int.
11765 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11766 were being counted with int, which may truncate counts on 64-bit
11767 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11768 * lisp.h (struct Lisp_Subr.function.aMANY)
11769 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11770 Arg counts are now ptrdiff_t, not size_t.
11771 All variadic functions and their callers changed accordingly.
11772 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11773 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11774 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11775 * callint.c (Fcall_interactively): Check arg count for overflow,
11776 to avoid potential buffer overrun. Use signed char, not 'int',
11777 for 'varies' array, so that we needn't bother to check its size
11778 calculation for overflow.
11779 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11780 * eval.c (apply_lambda):
11781 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11782 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11783 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11784
a1759b76
PE
11785 * callint.c (Fcall_interactively): Don't use index var as event count.
11786
d96be9fc
PE
11787 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11788 * mem-limits.h (SIZE): Remove; no longer used.
11789
a690a978 11790 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11791
578c21e6
PE
11792 Remove unnecessary casts.
11793 * xterm.c (x_term_init):
11794 * xfns.c (x_set_border_pixel):
11795 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11796 These aren't needed now that we assume ANSI C.
11797
96f53c6c
PE
11798 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11799 It's more likely to cause problems (due to unsigned overflow)
11800 than to cure them.
11801
83c77d31
PE
11802 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11803
ee2079f1
PE
11804 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11805
6da65536
PE
11806 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11807
7147c4a4
PE
11808 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11809
193e32d9
PE
11810 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11811
e5533da6
PE
11812 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11813
9910e595
PE
11814 GLYPH_CODE_FACE returns EMACS_INT, not int.
11815 * dispextern.h (merge_faces):
11816 * xfaces.c (merge_faces):
01103c44
PE
11817 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11818 Don't assume EMACS_INT fits in int.
9910e595 11819
2638320e
PE
11820 * character.h (CHAR_VALID_P): Remove unused parameter.
11821 * fontset.c, lisp.h, xdisp.c: All uses changed.
11822
045eb8d9
PE
11823 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11824
c1f134b5
PE
11825 * fns.c (concat): Minor tuning based on overflow analysis.
11826 This doesn't fix any bugs. Use int to hold character, instead
11827 of constantly refetching from Emacs object. Use XFASTINT, not
11828 XINT, for value known to be a character. Don't bother comparing
11829 a single byte to 0400, as it's always less.
11830
395fcb93 11831 * floatfns.c (Fexpt):
327eeec8
PE
11832 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11833
abbd3d23
PE
11834 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11835 for characters.
11836
684a03ef
PE
11837 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11838
0fed43f3
PE
11839 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11840 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11841 incorrectly succeed when S was a string, because 4294967386 was
11842 truncated before it was used.
11843
8fd02eb7
PE
11844 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11845 Otherwise, an out-of-range integer could cause undefined behavior
11846 on a 64-bit host.
11847
f8c86b69
PE
11848 * composite.c: Use int, not EMACS_INT, for characters.
11849 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11850 EMACS_INT, for values that are known to be in character range.
11851 This doesn't fix any bugs but is the usual style inside Emacs and
11852 may generate better code on 32-bit machines.
11853
34206dd2
PE
11854 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11855 This is for reasons similar to the recent CHAR_STRING fix.
11856 * charset.c (Fencode_char): Check that character arg is actually
11857 a character. Pass an int to ENCODE_CHAR.
11858 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11859 wider than 'int', as a compile-time check to prevent future regressions
11860 in this area.
11861
c5958d4c 11862 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11863
11864 Make sure a 64-bit char is never passed to CHAR_STRING.
11865 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11866 by silently ignoring the top 32 bits, allowing some values
11867 that were far too large to be valid characters.
11868 * character.h: Include <verify.h>.
11869 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11870 arguments are no wider than unsigned, as a compile-time check
11871 to prevent future regressions in this area.
11872 * data.c (Faset):
01103c44 11873 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11874 (Fsubst_char_in_region):
11875 * fns.c (concat):
11876 * xdisp.c (decode_mode_spec_coding):
11877 Adjust to CHAR_STRING's new requirement.
11878 * editfns.c (Finsert_char, Fsubst_char_in_region):
11879 * fns.c (concat): Check that character args are actually
11880 characters. Without this test, these functions did the wrong
11881 thing with wildly out-of-range values on 64-bit hosts.
11882
d37ca623
PE
11883 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11884 These casts should not be needed on 32-bit hosts, either.
11885 * keyboard.c (read_char):
11886 * lread.c (Fload): Remove casts to unsigned.
11887
ea204efb
PE
11888 * lisp.h (UNSIGNED_CMP): New macro.
11889 This fixes comparison bugs on 64-bit hosts.
11890 (ASCII_CHAR_P): Use it.
11891 * casefiddle.c (casify_object):
01103c44 11892 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11893 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11894 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11895 * dispextern.h (FACE_FROM_ID):
11896 * keyboard.c (read_char): Use UNSIGNED_CMP.
11897
41cb286c
PE
11898 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11899 not to EMACS_INT, to avoid GCC warning.
11900
4a1b9832
PE
11901 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11902
55daad71
PE
11903 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11904 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11905 isn't needed on 32-bit machines.
8f95c75c 11906
01103c44
PE
11907 * buffer.c (Fgenerate_new_buffer_name):
11908 Use EMACS_INT for count, not int.
0ceccced 11909 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11910
11911 * data.c (Qcompiled_function): Now static.
11912
c6f072e7
PE
11913 * window.c (window_body_lines): Now static.
11914
20ce5912
PE
11915 * image.c (gif_load): Rename local to avoid shadowing.
11916
9c4c5f81
PE
11917 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11918 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11919 * alloc.c (make_save_value): Integer argument is now of type
11920 ptrdiff_t, not int.
11921 (mark_object): Use ptrdiff_t, not int.
11922 * lisp.h (pD): New macro.
11923 * print.c (print_object): Use it.
11924
c0c5c8ae
PE
11925 * alloc.c: Use EMACS_INT, not int, to count objects.
11926 (total_conses, total_markers, total_symbols, total_vector_size)
11927 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11928 (total_free_floats, total_floats, total_free_intervals)
11929 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11930 Now EMACS_INT, not int. All uses changed.
11931 (Fgarbage_collect): Compute overall total using a double, so that
11932 integer overflow is less likely to be a problem. Check for overflow
11933 when converting back to an integer.
5a25e253
PE
11934 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11935 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11936 These were 'int' variables that could overflow on 64-bit hosts;
11937 they were never used, so remove them instead of repairing them.
211a0b2a 11938 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11939 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11940 Previously, this ceilinged at INT_MAX, but that doesn't work on
11941 64-bit machines.
e46bb31a 11942 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11943
c78baabf 11944 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11945 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11946 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11947 when a (possibly-narrower) signed value would do just as well.
11948 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11949
c9d624c6
PE
11950 * alloc.c: Catch some string size overflows that we were missing.
11951 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11952 for convenience in STRING_BYTES_MAX.
11953 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11954 The definition here is exact; the one in lisp.h was approximate.
11955 (allocate_string_data): Check for string overflow. This catches
11956 some instances we weren't catching before. Also, it catches
11957 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11958 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11959 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11960
c9d624c6
PE
11961 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11962 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11963 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11964
353032ce
PE
11965 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11966
2bccce07
PE
11967 * alloc.c (Fmake_string): Check for out-of-range init.
11968
0ac30604
SM
119692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11970
11971 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11972
c195f2de
JD
119732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11974
11975 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11976 xg_get_default_scrollbar_width.
11977
11978 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11979 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11980 (style_changed_cb): Call update_theme_scrollbar_width and call
11981 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11982 all frames (Bug#8505).
11983 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11984 Call gtk_window_set_resizable if HAVE_GTK3.
11985 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11986 and height if HAVE_GTK3 (Bug#8505).
11987 (scroll_bar_width_for_theme): New variable.
11988 (update_theme_scrollbar_width): New function.
11989 (xg_get_default_scrollbar_width): Move code to
11990 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11991 (xg_initialize): Call update_theme_scrollbar_width.
11992
11993 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11994
11995 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11996
e10ac9f1
MR
119972011-06-12 Martin Rudalics <rudalics@gmx.at>
11998
11999 * frame.c (make_frame): Call other_buffer_safely instead of
12000 other_buffer.
12001
12002 * window.c (temp_output_buffer_show): Call display_buffer with
12003 second argument Vtemp_buffer_show_specifiers and reset latter
12004 immediately after the call.
12005 (Vtemp_buffer_show_specifiers): New variable.
12006 (auto_window_vscroll_p, next_screen_context_lines)
12007 (Vscroll_preserve_screen_position): Remove leading asterisks from
12008 doc-strings.
12009
2d3c217e 120102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12011
7b7f97e8 12012 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12013 * buffer.c (Qclone_number): Remove for now, as it's unused.
12014 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12015 (record_buffer): Remove unused local.
12016 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12017 (set_frame_buffer_list): Remove; unused.
12018 * frame.h (other_visible_frames): Remove decl.
12019 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12020 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12021 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12022 if HAVE_GPM.
12023 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12024 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12025 Define only if HAVE_GPM.
12026 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12027 (update_hints_inhibit): Remove; never set. All uses removed.
12028 * widgetprv.h (emacsFrameClassRec): Remove decl.
12029 * window.c (delete_deletable_window): Now returns void, since it
12030 wasn't returning anything.
12031 (compare_window_configurations): Remove unused locals.
12032 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12033 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12034 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12035 the same widths as pointers. This follows up on the 2011-05-06 patch.
12036 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12037 * xterm.h: Likewise.
12038 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12039
1384b89e
JB
120402011-06-12 Juanma Barranquero <lekktu@gmail.com>
12041
12042 * makefile.w32-in: Update dependencies.
12043 (LISP_H): Add lib/intprops.h.
12044
1100a63c
CY
120452011-06-11 Chong Yidong <cyd@stupidchicken.com>
12046
12047 * image.c (gif_load): Add animation frame delay to the metadata.
12048 (syms_of_image): Use DEFSYM. New symbol `delay'.
12049
6198ccd0
MR
120502011-06-11 Martin Rudalics <rudalics@gmx.at>
12051
12052 * window.c (delete_deletable_window): Re-add.
12053 (Fset_window_configuration): Rewrite to handle dead buffers and
12054 consequently deletable windows.
12055 (window_tree, Fwindow_tree): Remove. Supply functionality in
12056 window.el.
12057 (compare_window_configurations): Simplify code.
12058
b6e3633c
AS
120592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12060
1ab0dee5
AS
12061 * image.c (imagemagick_load_image): Fix type mismatch.
12062 (Fimagemagick_types): Likewise.
12063
b6e3633c
AS
12064 * window.h (replace_buffer_in_windows): Declare.
12065
9397e56f
MR
120662011-06-11 Martin Rudalics <rudalics@gmx.at>
12067
12068 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12069 Qclone_number. Remove external declaration of Qdelete_window.
12070 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12071 code.
640c8776
SM
12072 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12073 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12074 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12075 buffer list implementation.
12076 (other_buffer_safely): New function.
12077 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12078 calls to replace_buffer_in_windows and
12079 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12080 if allowed.
12081 (record_buffer): Inhibit quitting and rewrite using quittable
12082 functions. Run Qbuffer_list_update_hook if allowed.
12083 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12084 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12085 Move switch-to-buffer to window.el.
9397e56f
MR
12086 (bury-buffer): Move to window.el.
12087 (Vbuffer_list_update_hook): New variable.
12088
12089 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12090 section.
12091
12092 * window.h (resize_frame_windows): Move up in code.
12093 (Fwindow_frame): Remove EXFUN.
12094 (replace_buffer_in_all_windows): Remove prototype.
12095 (replace_buffer_in_windows_safely): Add prototype.
12096
12097 * window.c: Declare Qdelete_window static again. Move down
12098 declaration of select_count.
12099 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12100 (Fother_window): Move to window.el.
12101 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12102 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12103 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12104 window.el.
12105 (replace_buffer_in_windows): Implement by calling
12106 Qreplace_buffer_in_windows.
12107 (replace_buffer_in_all_windows): Remove with some functionality
12108 moved into replace_buffer_in_windows_safely.
12109 (replace_buffer_in_windows_safely): New function.
12110 (select_window_norecord, select_frame_norecord): Move in front
12111 of run_window_configuration_change_hook. Remove now obsolete
12112 declarations.
640c8776
SM
12113 (Fset_window_buffer): Rewrite doc-string.
12114 Call Qrecord_window_buffer.
9397e56f
MR
12115 (keys_of_window): Move binding for other-window to window.el.
12116
b50691aa
CY
121172011-06-11 Chong Yidong <cyd@stupidchicken.com>
12118
12119 * dispextern.h (struct image): Replace data member, whose int_val
12120 and ptr_val fields were not used by anything, with a single
12121 lisp_val object.
12122
12123 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
12124 (gif_clear_image, gif_load, imagemagick_load_image)
12125 (gs_clear_image, gs_load): Callers changed.
12126
3f754b86
PE
121272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12128
cca69397
PE
12129 * buffer.h: Include <time.h>, for time_t.
12130 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12131
109e28d0
PE
12132 Fix minor problems found by static checking.
12133
60737f02
PE
12134 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12135
4b66faf3
PE
12136 Make identifiers static if they are not used in other modules.
12137 * data.c (Qcompiled_function, Qframe, Qvector):
12138 * image.c (QimageMagick, Qsvg):
12139 * minibuf.c (Qmetadata):
12140 * window.c (resize_window_check, resize_root_window): Now static.
12141 * window.h (resize_window_check, resize_root_window): Remove decls.
12142
109e28d0
PE
12143 * window.c (window_deletion_count, delete_deletable_window):
12144 Remove; unused.
46a4ce9e
PE
12145 (window_body_lines): Now static.
12146 (Fdelete_other_windows_internal): Mark vars as initialized.
12147 Make sure 'resize_failed' is initialized.
12148 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12149 (resize_window_apply): Remove unused local.
12150 * window.h (delete_deletable_window): Remove decl.
12151
109e28d0 12152 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12153 (imagemagick_load_image): Fix pointer signedness problem by changing
12154 last arg from unsigned char * to char *. All uses changed.
12155 Also, fix a local for similar reasons.
12156 Remove unused locals. Remove locals to avoid shadowing.
12157 (fn_rsvg_handle_free): Remove; unused.
12158 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12159 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12160
3f754b86
PE
12161 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12162
2547adb1
CY
121632011-06-10 Chong Yidong <cyd@stupidchicken.com>
12164
12165 * image.c (gif_load): Fix omitted cast error introduced by
12166 2011-06-06 change.
12167
2c8e37d4
MR
121682011-06-10 Martin Rudalics <rudalics@gmx.at>
12169
12170 * window.h (resize_proportionally, orig_total_lines)
12171 (orig_top_line): Remove from window structure.
12172 (set_window_height, set_window_width, change_window_heights)
12173 (Fdelete_window): Remove prototypes.
12174 (resize_frame_windows): Remove duplicate declaration.
12175
440a42e3
EZ
121762011-06-10 Eli Zaretskii <eliz@gnu.org>
12177
12178 * window.h (resize_frame_windows, resize_window_check)
12179 (delete_deletable_window, resize_root_window)
12180 (resize_frame_windows): Declare prototypes.
12181
12182 * window.c (resize_window_apply): Make definition be "static" to
12183 match the prototype.
12184
562dd5e9
MR
121852011-06-10 Martin Rudalics <rudalics@gmx.at>
12186
12187 * window.c: Remove declarations of Qwindow_size_fixed,
12188 window_min_size_1, window_min_size_2, window_min_size,
12189 size_window, window_fixed_size_p, enlarge_window, delete_window.
12190 Remove static from declaration of Qdelete_window, it's
12191 temporarily needed by Fbury_buffer.
12192 (replace_window): Don't assign orig_top_line and
12193 orig_total_lines.
12194 (Fdelete_window, delete_window): Remove. Window deletion is
12195 handled by window.el.
640c8776
SM
12196 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12197 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12198 (Fdelete_other_windows): Remove. Deleting other windows is
12199 handled by window.el.
12200 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12201 handled in window.el.
12202 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12203 Window minimum sizes are handled in window.el.
12204 (shrink_windows, size_window, set_window_height)
12205 (set_window_width, change_window_heights, window_height)
12206 (window_width, CURBEG, CURSIZE, enlarge_window)
12207 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12208 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12209 handled in window.el.
12210 (make_dummy_parent): Rename to make_parent_window and give it a
12211 second argument horflag.
12212 (make_window): Don't set resize_proportionally any more.
12213 (Fsplit_window): Remove. Windows are split in window.el.
12214 (save_restore_action, save_restore_orig_size)
12215 (shrink_window_lowest_first, save_restore_orig_size): Remove.
12216 Resize mini windows in window.el.
12217 (grow_mini_window, shrink_mini_window): Implement by calling
12218 Qresize_root_window_vertically, resize_window_check and
12219 resize_window_apply.
640c8776
SM
12220 (saved_window, Fset_window_configuration, save_window_save):
12221 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
12222 resize_proportionally.
12223 (window_min_height, window_min_width): Move to window.el.
12224 (keys_of_window): Move bindings for delete-other-windows,
12225 split-window, delete-window and enlarge-window to window.el.
12226
12227 * buffer.c: Temporarily extern Qdelete_window.
12228 (Fbury_buffer): Temporarily call Qdelete_window instead of
12229 Fdelete_window (Fbury_buffer will move to window.el soon).
12230
12231 * frame.c (set_menu_bar_lines_1): Remove code handling
12232 orig_top_line and orig_total_lines.
12233
12234 * dispnew.c (adjust_frame_glyphs_initially): Don't use
12235 set_window_height but set heights directly.
12236 (change_frame_size_1): Use resize_frame_windows.
12237
12238 * xdisp.c (init_xdisp): Don't use set_window_height but set
12239 heights directly.
12240
640c8776
SM
12241 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
12242 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
12243 run_window_configuration_change_hook.
12244
12245 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
12246 instead of change_window_heights and run
12247 run_window_configuration_change_hook.
12248
1a13852e
MR
122492011-06-09 Martin Rudalics <rudalics@gmx.at>
12250
12251 * window.c (replace_window): Rename second argument REPLACEMENT to
12252 NEW. New third argument SETFLAG. Rewrite.
12253 (delete_window, make_dummy_parent): Call replace_window with
12254 third argument 1.
12255 (window_list_1): Move down in code.
12256 (run_window_configuration_change_hook): Move set_buffer part
12257 before select_frame_norecord part in order to unwind correctly.
12258 Rename count1 to count.
12259 (recombine_windows, delete_deletable_window, resize_root_window)
12260 (Fdelete_other_windows_internal)
12261 (Frun_window_configuration_change_hook, make_parent_window)
12262 (resize_window_check, resize_window_apply, Fresize_window_apply)
12263 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
12264 (Fdelete_window_internal, Fresize_mini_window_internal):
12265 New functions.
1a13852e
MR
12266 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
12267
f3d1777e
MR
122682011-06-08 Martin Rudalics <rudalics@gmx.at>
12269
496e208e
MR
12270 * window.h (window): Add some new members to window structure -
12271 normal_lines, normal_cols, new_total, new_normal, clone_number,
12272 splits, nest, prev_buffers, next_buffers.
12273 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 12274 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 12275
f3d1777e
MR
12276 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
12277 Remove.
496e208e
MR
12278 (make_dummy_parent): Set new members of windows structure.
12279 (make_window): Move down in code. Handle new members of window
12280 structure.
12281 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
12282 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
12283 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
12284 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
12285 (Fset_window_next_buffers, Fset_window_clone_number):
12286 New functions.
496e208e
MR
12287 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
12288 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
12289 Doc-string fixes.
12290 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
12291 Argument WINDOW can be now internal window too.
12292 (Fwindow_use_time): Move up in code.
12293 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
12294 Rewrite doc-string.
12295 (Fset_window_configuration, saved_window)
12296 (Fcurrent_window_configuration, save_window_save): Handle new
12297 members of window structure.
b9e809c2
MR
12298 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
12299 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
12300 (syms_of_window): New Lisp objects Qrecord_window_buffer,
12301 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
12302 Qget_mru_window, Qresize_root_window,
12303 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
12304 Qauto_buffer_name; staticpro them.
f3d1777e 12305
abde8f8c
MR
123062011-06-07 Martin Rudalics <rudalics@gmx.at>
12307
12308 * window.c (Fwindow_total_size, Fwindow_left_column)
12309 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
12310 (Fwindow_list_1): New functions.
12311 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
12312 (Fwindow_width, Fscroll_left, Fscroll_right):
12313 Use window_body_cols instead of window_box_text_cols.
12314 (delete_window, Fset_window_configuration):
12315 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
12316 (delete_all_subwindows): Take a window as argument and not a
12317 structure. Rewrite.
190b47e6
MR
12318 (window_loop): Remove handling of GET_LRU_WINDOW and
12319 GET_LARGEST_WINDOW.
12320 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
12321
12322 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
12323 window_box_text_cols. delete_all_subwindows now takes a
12324 Lisp_Object as argument.
abde8f8c 12325
640c8776
SM
12326 * indent.c (compute_motion, Fcompute_motion):
12327 Use window_body_cols instead of window_box_text_cols.
abde8f8c 12328
fa8a67e6
MR
12329 * frame.c (delete_frame): Call delete_all_subwindows with root
12330 window as argument.
12331
a54e3482
DC
123322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
12333
12334 * fns.c (Fputhash): Document return value.
12335
60002bf5
CY
123362011-06-06 Chong Yidong <cyd@stupidchicken.com>
12337
12338 * image.c (gif_load): Implement gif89a spec "no disposal" method.
12339
0c671da6 123402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 12341
b862a52a 12342 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 12343
be44ca6c
PE
12344 Check for overflow when converting integer to cons and back.
12345 * charset.c (Fdefine_charset_internal, Fdecode_char):
12346 Use cons_to_unsigned to catch overflow.
12347 (Fencode_char): Use INTEGER_TO_CONS.
12348 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
12349 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
12350 * data.c (long_to_cons, cons_to_long): Remove.
12351 (cons_to_unsigned, cons_to_signed): New functions.
12352 These signal an error for invalid or out-of-range values.
12353 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
12354 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
12355 * font.c (Ffont_variation_glyphs):
12356 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
12357 * lisp.h: Include <intprops.h>.
12358 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
12359 (cons_to_signed, cons_to_unsigned): New decls.
12360 (long_to_cons, cons_to_long): Remove decls.
12361 * undo.c (record_first_change): Use INTEGER_TO_CONS.
12362 (Fprimitive_undo): Use CONS_TO_INTEGER.
12363 * xfns.c (Fx_window_property): Likewise.
12364 * xselect.c: Include <limits.h>.
12365 (x_own_selection, selection_data_to_lisp_data):
12366 Use INTEGER_TO_CONS.
12367 (x_handle_selection_request, x_handle_selection_clear)
12368 (x_get_foreign_selection, Fx_disown_selection_internal)
12369 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
12370 (lisp_data_to_selection_data): Use cons_to_unsigned.
12371 (x_fill_property_data): Use cons_to_signed.
12372 Report values out of range.
12373
d1f3d2af
PE
12374 Check for buffer and string overflow more precisely.
12375 * buffer.h (BUF_BYTES_MAX): New macro.
12376 * lisp.h (STRING_BYTES_MAX): New macro.
12377 * alloc.c (Fmake_string):
12378 * character.c (string_escape_byte8):
12379 * coding.c (coding_alloc_by_realloc):
12380 * doprnt.c (doprnt):
12381 * editfns.c (Fformat):
12382 * eval.c (verror):
12383 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
12384 since they may not be the same number.
12385 * editfns.c (Finsert_char):
12386 * fileio.c (Finsert_file_contents):
12387 Likewise for BUF_BYTES_MAX.
12388
dd52fcea
PE
12389 * image.c: Use ptrdiff_t, not int, for sizes.
12390 (slurp_file): Switch from int to ptrdiff_t.
12391 All uses changed.
12392 (slurp_file): Check that file size fits in both size_t (for
12393 malloc) and ptrdiff_t (for sanity and safety).
12394
7f9bbdbb
PE
12395 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
12396 if b->modtime has its maximal value.
12397
dfe18f82
PE
12398 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
12399
84acfcf0
PE
12400 Don't assume time_t can fit into int.
12401 * buffer.h (struct buffer.modtime): Now time_t, not int.
12402 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
12403 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12404
ccd9a01a
PE
12405 Minor fixes for signed vs unsigned integers.
12406 * character.h (MAYBE_UNIFY_CHAR):
12407 * charset.c (maybe_unify_char):
12408 * keyboard.c (read_char, reorder_modifiers):
12409 XINT -> XFASTINT, since the integer must be nonnegative.
12410 * ftfont.c (ftfont_spec_pattern):
12411 * keymap.c (access_keymap, silly_event_symbol_error):
12412 XUINT -> XFASTINT, since the integer must be nonnegative.
12413 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12414 since it makes no difference and we prefer signed.
12415 * keyboard.c (record_char): Use XUINT when all the neighbors do.
12416 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
12417 nonnegative.
12418
d6d100dd
SM
124192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
12420
12421 * window.h (Fwindow_frame): Declare.
12422
2b6148e4
PE
124232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12424
12425 * alloc.c: Simplify handling of large-request failures (Bug#8800).
12426 (SPARE_MEMORY): Always define.
12427 (LARGE_REQUEST): Remove.
12428 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
12429
f230ecc9
MR
124302011-06-06 Martin Rudalics <rudalics@gmx.at>
12431
727e958e
MR
12432 * lisp.h: Move EXFUNS for Fframe_root_window,
12433 Fframe_first_window and Fset_frame_selected_window to window.h.
12434
12435 * window.h: Move EXFUNS for Fframe_root_window,
12436 Fframe_first_window and Fset_frame_selected_window here from
12437 lisp.h.
12438
12439 * frame.c (Fwindow_frame, Fframe_first_window)
12440 (Fframe_root_window, Fframe_selected_window)
12441 (Fset_frame_selected_window): Move to window.c.
12442 (Factive_minibuffer_window): Move to minibuf.c.
12443 (Fother_visible_frames_p): New function.
12444
12445 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
12446
f230ecc9
MR
12447 * window.c (decode_window, decode_any_window): Move up in code.
12448 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
12449 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
12450 (Fwindow_buffer): Move up and rewrite doc-string.
12451 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
12452 (Fwindow_prev): New functions.
727e958e
MR
12453 (Fwindow_frame): Move here from frame.c. Accept any window as
12454 argument.
12455 (Fframe_root_window, Fframe_first_window)
12456 (Fframe_selected_window): Move here from frame.c. Accept frame
12457 or arbitrary window as argument. Update doc-strings.
12458 (Fminibuffer_window): Move up in code.
12459 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
12460 (Fset_frame_selected_window): Move here from frame.c.
12461 Marginal rewrite.
727e958e
MR
12462 (Fselected_window, select_window, Fselect_window): Move up in
12463 code. Minor doc-string fixes.
f230ecc9 12464
4d09bcf6
PE
124652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12466
12467 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
12468 Do not assume that spare memory exists; that assumption is valid
12469 only if SYSTEM_MALLOC.
12470 (LARGE_REQUEST): New macro, so that the issue of large requests
12471 is separated from the issue of spare memory.
12472
810928a2
AS
124732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
12474
172418ad
AS
12475 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
12476 format. (Bug#8806)
12477
43f862f7
AS
12478 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
12479
810928a2
AS
12480 * xfns.c (x_set_scroll_bar_default_width): Move declarations
12481 before statements.
12482
a059fe24
JD
124832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12484
12485 * gtkutil.c (xg_get_default_scrollbar_width): New function.
12486
12487 * gtkutil.h: Declare xg_get_default_scrollbar_width.
12488
12489 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
12490 min width by calling x_set_scroll_bar_default_width (Bug#8505).
12491
989bf368
JB
124922011-06-05 Juanma Barranquero <lekktu@gmail.com>
12493
12494 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12495
4b80f674
CY
124962011-06-04 Chong Yidong <cyd@stupidchicken.com>
12497
12498 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12499 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12500 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12501 New error handlers.
4b80f674
CY
12502 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12503 Obey Vx_select_enable_clipboard_manager. Catch errors in
12504 x_clipboard_manager_save (Bug#8779).
12505 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12506 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12507
99a33b77 125082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12509
12510 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12511
99a33b77 125122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12513
12514 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12515 in the current matrix if keep_current_p is non-zero.
12516
8264569d
EZ
125172011-06-04 Eli Zaretskii <eliz@gnu.org>
12518
12519 * bidi.c (bidi_level_of_next_char): Fix last change.
12520
57f97249
EZ
125212011-06-03 Eli Zaretskii <eliz@gnu.org>
12522
fec2107c 12523 Support bidi reordering of text covered by display properties.
57f97249 12524
fec2107c
EZ
12525 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12526 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12527 (bidi_cache_search, bidi_cache_iterator_state)
12528 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12529 (bidi_level_of_next_char, bidi_move_to_visually_next):
12530 Support character positions inside a run of characters covered by a
fec2107c
EZ
12531 display string.
12532 (bidi_paragraph_init, bidi_resolve_explicit_1)
12533 (bidi_level_of_next_char): Call bidi_fetch_char and
12534 bidi_fetch_char_advance instead of FETCH_CHAR and
12535 FETCH_CHAR_ADVANCE.
12536 (bidi_init_it): Initialize new members.
12537 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12538 definitions.
12539 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12540 instead of using explicit *_CHAR codes.
d6d100dd
SM
12541 (bidi_resolve_explicit, bidi_resolve_weak):
12542 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12543 bidirectional text is supported only in multibyte buffers.
12544 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12545 it to initialize the frame_window_p member of struct bidi_it.
12546 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12547 (bidi_resolve_explicit, bidi_resolve_weak)
12548 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12549 bidi_it->nchars is non-positive.
12550 (bidi_level_of_next_char): Don't try to lookup the cache for the
12551 next/previous character if nothing is cached there yet, or if we
12552 were just reseat()'ed to a new position.
c40e2fb2 12553
0e14fe90
EZ
12554 * xdisp.c (set_cursor_from_row): Set start and stop points
12555 according to the row's direction when priming the loop that looks
12556 for the glyph on which to display cursor.
12557 (single_display_spec_intangible_p): Function deleted.
12558 (display_prop_intangible_p): Reimplement to call
12559 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12560 Accept 3 additional arguments needed by handle_display_spec.
12561 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12562 values: lists, `(when COND...)' forms, etc.
12563 (single_display_spec_string_p): Support property values that are
12564 lists with the argument STRING its top-level element.
12565 (display_prop_string_p): Fix the condition for processing a
12566 property that is a list to be consistent with handle_display_spec.
fec2107c 12567 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12568 last portion of handle_display_prop.
12569 (compute_display_string_pos): Accept additional argument
12570 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12571 value of a `display' property is a "replacing spec".
12572 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12573 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12574 the display property, but just return a value indicating whether
12575 the display property will replace the characters it covers.
12576 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12577 frame_window_p members of struct bidi_it.
d6d100dd
SM
12578 (compute_display_string_pos, compute_display_string_end):
12579 New functions.
fec2107c
EZ
12580 (push_it): Accept second argument POSITION, where pop_it should
12581 jump to continue iteration.
12582 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12583
fec2107c
EZ
12584 * keyboard.c (adjust_point_for_property): Adjust the call to
12585 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12586
12587 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12588 (bidi_init_it): Update prototypes.
12589 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12590 (compute_display_string_pos, compute_display_string_end):
12591 Declare prototypes.
fec2107c
EZ
12592 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12593 EMACS_INT.
fc6f18ce 12594
40087514 125952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12596
57f53182
PE
12597 Malloc failure behavior now depends on size of allocation.
12598 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12599 * lisp.h: Change signatures accordingly.
12600 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12601 All callers changed. (Bug#8762)
12602
12603 * gnutls.c: Use Emacs's memory allocators.
12604 Without this change, the gnutls library would invoke malloc etc.
12605 directly, which causes problems on non-SYNC_INPUT hosts, and which
12606 runs afoul of improving memory_full behavior. (Bug#8761)
12607 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12608 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12609 xfree instead of the default malloc, realloc, free.
12610 (Fgnutls_boot): No need to check for memory allocation failure,
12611 since xmalloc does that for us.
12612
ac32cd99 12613 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12614 * category.c (hash_get_category_set):
12615 * ccl.c (ccl_driver):
12616 * charset.c (Fdefine_charset_internal):
12617 * charset.h (struct charset.hash_index):
12618 * composite.c (get_composition_id, gstring_lookup_cache)
12619 (composition_gstring_put_cache):
12620 * composite.h (struct composition.hash_index):
12621 * dispextern.h (struct image.hash):
12622 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12623 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12624 (hashfn_equal, hashfn_user_defined, make_hash_table)
12625 (maybe_resize_hash_table, hash_lookup, hash_put)
12626 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12627 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12628 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12629 * image.c (make_image, search_image_cache, lookup_image)
12630 (xpm_put_color_table_h):
12631 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12632 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12633 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12634 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12635 * alloc.c (allocate_vectorlike):
12636 Check for overflow in vector size calculations.
12637 * ccl.c (ccl_driver):
12638 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12639 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12640 need to be updated by these changes.
40087514
PE
12641 * fns.c (make_hash_table, maybe_resize_hash_table):
12642 Check for integer overflow with large hash tables.
0de4bb68
PE
12643 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12644 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12645 (SXHASH_REDUCE): New macro.
12646 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12647 Use it instead of discarding useful hash info with large hash values.
12648 (sxhash_float): New function.
12649 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12650 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12651 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12652 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12653 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12654 Adjust signatures to match updated version of code.
12655 (consing_since_gc): Now EMACS_INT, since a single hash table can
12656 use more than INT_MAX bytes.
12657
698d32e2
DN
126582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12659
12660 Make it possible to build with GCC-4.6+ -O2 -flto.
12661
12662 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12663
fd6fa53f
SM
126642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12665
12666 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12667 Call minibuffer-inactive-mode.
12668
864db017
JB
126692011-05-31 Juanma Barranquero <lekktu@gmail.com>
12670
12671 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12672 Update dependencies.
12673
2ad0baf4
DN
126742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12675
12676 * data.c (init_data): Remove code for UTS, this system is not
12677 supported anymore.
12678
4fcc2638
DN
126792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12680
12681 Don't force ./temacs to start in terminal mode.
12682
12683 * frame.c (make_initial_frame): Initialize faces in all cases, not
12684 only when CANNOT_DUMP is defined.
12685 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12686
c56e0fd5
DN
126872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12688
12689 * dispnew.c (add_window_display_history): Use const for the string
12690 pointer. Remove declaration, not needed.
12691
333d54da 126922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12693
55d4c1b2 12694 Use 'inline', not 'INLINE'.
333d54da 12695 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12696 * alloc.c, fontset.c (INLINE): Remove.
12697 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12698 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12699 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12700 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12701 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12702
738db178
DN
127032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12704
12705 Make it possible to run ./temacs.
12706
12707 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12708 syms_of_callproc does the same thing. Remove test for
12709 "initialized", do it in the caller.
12710 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12711
620c53a6
SM
127122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12713
12714 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12715 (read_minibuf): Use get_minibuffer.
12716 (syms_of_minibuf): Use DEFSYM.
12717 (Qmetadata): New var.
12718 * data.c (Qbuffer): Don't make it static.
12719 (syms_of_data): Use DEFSYM.
12720
e003a292
PE
127212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12722
12723 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12724 (CCL_CODE_MIN): New macro.
12725
ed008a6d
PE
127262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12727
3687c2ef
PE
12728 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12729
ed008a6d
PE
12730 * eval.c (Qdebug): Now static.
12731 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12732 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12733 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12734
d66c4c7c
CY
127352011-05-29 Chong Yidong <cyd@stupidchicken.com>
12736
12737 * image.c: Various fixes to ImageMagick code comments.
12738 (Fimagemagick_types): Doc fix.
12739
5fbc2025
PE
127402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12741
0196f88a
PE
12742 Minor fixes prompted by GCC 4.6.0 warnings.
12743
12744 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12745
5fbc2025
PE
12746 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12747 (x_clipboard_manager_save_all): Move extern decl to ...
12748 * xterm.h: ... here, so that it can be checked for consistency.
12749
1dd3c2d9
CY
127502011-05-29 Chong Yidong <cyd@stupidchicken.com>
12751
12752 * xselect.c (x_clipboard_manager_save_frame)
12753 (x_clipboard_manager_save_all): New functions.
12754 (Fx_clipboard_manager_save): Lisp function deleted.
12755
12756 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12757 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12758
12759 * xterm.h: Update prototype.
12760
5ba6571d
WX
127612011-05-28 William Xu <william.xwl@gmail.com>
12762
12763 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12764 exiting (Bug#8239).
12765
3eaff834
JM
127662011-05-28 Jim Meyering <meyering@redhat.com>
12767
e1900994 12768 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12769 * fns.c (to_uchar): Define.
12770 (crypto_hash_function): Use it to convert some newly-signed
12771 variables to unsigned, to avoid sign-extension bugs. For example,
12772 without this change, (md5 "truc") would evaluate to
12773 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12774 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12775 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12776
0f6990a7
PE
127772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12778
12779 Integer overflow fixes.
c8a9ca5a 12780
08686060
PE
12781 * dbusbind.c: Serial number integer overflow fixes.
12782 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12783 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12784 to hold a serial number that is too large for a fixnum.
12785 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12786 Check for serial numbers out of range. Decode any serial number
59568bf0 12787 that was so large that it became a float. (Bug#8722)
08686060 12788
2d1fc3c7
PE
12789 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12790 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12791 Use XFASTINT rather than XUINT when numbers are nonnegative.
12792 (xd_append_arg, Fdbus_method_return_internal):
12793 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12794 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12795 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12796 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12797 (Bug#8722)
2d1fc3c7 12798
c8a9ca5a
PE
12799 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12800
519e1d69
PE
12801 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12802
6df6ae42 12803 ccl: Add integer overflow checks.
30569699
PE
12804 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12805 (IN_INT_RANGE): New macros.
12806 (ccl_driver): Use them to check for integer overflow when
12807 decoding a CCL program. Many of the new checks are whether XINT (x)
12808 fits in int; it doesn't always, on 64-bit hosts. The new version
12809 doesn't catch all possible integer overflows, but it's an
847044ea 12810 improvement. (Bug#8719)
30569699 12811
c11285dc
PE
12812 * alloc.c (make_event_array): Use XINT, not XUINT.
12813 There's no need for unsigned here.
12814
fdccd48e
PE
12815 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12816 This follows up to the 2011-05-06 change that substituted uintptr_t
12817 for EMACS_INT. This case wasn't caught back then.
12818
37910ab2
PE
12819 Rework Fformat to avoid integer overflow issues.
12820 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12821 now (part of C89). Include <verify.h>.
12822 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12823 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12824 (Fformat): Avoid the prepass trying to compute sizes; it was only
12825 approximate and thus did not catch overflow reliably. Instead, walk
12826 through the format just once, formatting and computing sizes as we go,
12827 checking for integer overflow at every step, and allocating a larger
12828 buffer as needed. Keep track separately whether the format is
12829 multibyte. Keep only the most-recently calculated precision, rather
12830 than them all. Record whether each argument has been converted to
12831 string. Use EMACS_INT, not int, for byte and char and arg counts.
12832 Support field widths and precisions larger than INT_MAX. Avoid
12833 sprintf's undefined behavior with conversion specifications such as %#d
12834 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12835 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12836 formatting out-of-range floating point numbers with int
9173deec 12837 formats. (Bug#8668)
37910ab2 12838
2e6578fb
PE
12839 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12840
0ae6bdee
PE
12841 * data.c: Avoid integer truncation in expressions involving floats.
12842 * data.c: Include <intprops.h>.
12843 (arith_driver): When there's an integer overflow in an expression
12844 involving floating point, convert the integers to floating point
12845 so that the resulting value does not suffer from catastrophic
12846 integer truncation. For example, on a 64-bit host (* 4
12847 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12848 Do not rely on undefined behavior after integer overflow.
12849
de883a70
PE
12850 merge count_size_as_multibyte, parse_str_to_multibyte
12851 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12852 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12853 Check for integer overflow.
12854 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12855 since it's now a duplicate of the other. This is more of
12856 a character than a buffer op, so better that it's in character.c.
12857 * fns.c, print.c: Adjust to above changes.
12858
2ff916cb
PE
128592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12860
12861 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12862
f1b54466
PE
128632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12864
fb1ac845
PE
12865 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12866 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12867 (x_clipboard_manager_save): Now static.
12868 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12869
f1b54466
PE
12870 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12871 (crypto_hash_function): Now static.
12872 Fix pointer signedness problems. Avoid unnecessary initializations.
12873
a9f737ee
CY
128742011-05-27 Chong Yidong <cyd@stupidchicken.com>
12875
12876 * termhooks.h (Vselection_alist): Make it terminal-local.
12877
12878 * terminal.c (create_terminal): Initialize it.
12879
12880 * xselect.c: Support for clipboard managers.
12881 (Vselection_alist): Move to termhooks.h as terminal-local var.
12882 (LOCAL_SELECTION): New macro.
12883 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12884 (symbol_to_x_atom): Remove gratuitous arg.
12885 (x_handle_selection_request, lisp_data_to_selection_data)
12886 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12887 (x_own_selection, x_get_local_selection, x_convert_selection):
12888 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12889 (some_frame_on_display): Delete unused function.
12890 (Fx_own_selection_internal, Fx_get_selection_internal)
12891 (Fx_disown_selection_internal, Fx_selection_owner_p)
12892 (Fx_selection_exists_p): New optional frame arg.
12893 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12894 (x_handle_selection_clear): Don't treat other terminals with the
12895 same keyboard specially. Use the terminal-local Vselection_alist.
12896 (x_clear_frame_selections): Use Frun_hook_with_args.
12897
12898 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12899
12900 * xterm.h: Add support for those atoms.
12901
e067f0c1
CY
129022011-05-26 Chong Yidong <cyd@stupidchicken.com>
12903
12904 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12905 (converted_selections, conversion_fail_tag): New global variables.
12906 (x_selection_request_lisp_error): Free the above.
12907 (x_get_local_selection): Remove unnecessary code.
12908 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12909 of converted selections stored in converted_selections.
12910 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12911 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12912 (x_convert_selection): New function.
12913 (x_handle_selection_event): Simplify.
12914 (x_get_foreign_selection): Don't ignore incoming requests while
12915 waiting for an answer; this will fail when we implement
12916 SAVE_TARGETS, and seems unnecessary anyway.
12917 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12918 (Vx_sent_selection_functions): Doc fix.
12919
0f4aebc0
LL
129202011-05-26 Leo Liu <sdl.web@gmail.com>
12921
12922 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12923
e61124cd
YM
129242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12925
12926 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12927
12928 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12929 for fringe update if it has periodic bitmap.
ac389d0c 12930 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12931 and fringe_bitmap_periodic_p.
12932
12933 * fringe.c (get_fringe_bitmap_data): New function.
12934 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12935 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12936 row. Mark glyph row for fringe update if periodicity changed.
12937
12938 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12939 for fringe update unless it has periodic bitmap.
12940
f16d9837
KH
129412011-05-25 Kenichi Handa <handa@m17n.org>
12942
12943 * xdisp.c (get_next_display_element): Set correct it->face_id for
12944 a static composition.
12945
e1b90ef6
LL
129462011-05-24 Leo Liu <sdl.web@gmail.com>
12947
12948 * deps.mk (fns.o):
12949 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12950
12951 * fns.c (crypto_hash_function, Fsha1): New function.
12952 (Fmd5): Use crypto_hash_function.
12953 (syms_of_fns): Add Ssha1.
12954
7400048f
PE
129552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12956
12957 * gnutls.c: Remove unused macros.
12958 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12959 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12960 Remove macros that are defined and never used.
12961 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12962
abb71cf4
CY
129632011-05-22 Chong Yidong <cyd@stupidchicken.com>
12964
12965 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12966 (Fx_get_selection_internal): Minor cleanup.
12967 (Fx_own_selection_internal): Rename arguments for consistency with
12968 select.el.
12969
6307db39
PE
129702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12971
12972 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12973
f3d4e0a4
CY
129742011-05-22 Chong Yidong <cyd@stupidchicken.com>
12975
12976 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12977
4d8ade89
YM
129782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12979
12980 * dispnew.c (scrolling_window): Don't exclude the case that the
12981 last enabled row in the desired matrix touches the bottom boundary.
12982
32078c8d
GM
129832011-05-21 Glenn Morris <rgm@gnu.org>
12984
12985 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12986 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12987 and add some more files.
32078c8d 12988
7285dc67
EZ
129892011-05-20 Eli Zaretskii <eliz@gnu.org>
12990
12991 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12992 report_file_error introduced by the change from 2011-05-07.
12993
89d1bd22
PE
129942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12995
12996 * systime.h (Time): Define only if emacs is defined.
12997 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12998 where the include path doesn't have X11/X.h by default. See
12999 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13000
cd394be1 130012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13002
13003 * composite.c (find_automatic_composition): Fix previous change.
13004
b9704ad9
GM
130052011-05-20 Glenn Morris <rgm@gnu.org>
13006
13007 * lisp.mk: New file, split from Makefile.in.
13008 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13009 (shortlisp): Remove.
13010 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13011
4a720484
GM
130122011-05-19 Glenn Morris <rgm@gnu.org>
13013
13014 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13015 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13016 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13017 (lisp): Set the order to that of loadup.el.
13018 (shortlisp): Make it a copy of $lisp.
13019 (SOME_MACHINE_LISP): Remove.
13020 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13021 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13022
a28d4396
KH
130232011-05-18 Kenichi Handa <handa@m17n.org>
13024
13025 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13026 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13027 (find_automatic_composition): Mostly rewrite for efficiency.
13028
a2b1fa8e
JB
130292011-05-18 Juanma Barranquero <lekktu@gmail.com>
13030
13031 * makefile.w32-in: Update dependencies.
13032
8e1f5610
CS
130332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13034
13035 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13036 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13037
7025ee00 130382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13039
cdfa6eab
PE
13040 Fix some integer overflow issues, such as string length overflow.
13041
06d6db33
PE
13042 * insdel.c (count_size_as_multibyte): Check for string overflow.
13043
2b4560a8
PE
13044 * character.c (lisp_string_width): Check for string overflow.
13045 Use EMACS_INT, not int, for string indexes and lengths; in
13046 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13047 the resulting string length overflows an EMACS_INT; instead,
13048 report a string overflow if no precision given. When checking for
13049 precision exhaustion, use a check that cannot possibly have
13050 integer overflow. (Bug#8675)
13051 * character.h (lisp_string_width): Adjust to new signature.
13052
cb93f9be
PE
13053 * alloc.c (string_overflow): New function.
13054 (Fmake_string): Use it. This doesn't change behavior, but saves
13055 a few bytes and will simplify future changes.
13056 * character.c (string_escape_byte8): Likewise.
13057 * lisp.h (string_overflow): New decl.
13058
1a1f3366
PE
13059 Fixups, following up to the user-interface timestamp change.
13060 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13061 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13062 * msdos.c (mouse_get_pos): Likewise.
13063 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13064 * w32gui.h (Time): Define by including "systime.h" rather than by
13065 declaring it ourselves. (Bug#8664)
13066
d4e3e4d3
PE
13067 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13068 * image.c (clear_image_cache): Likewise.
13069
f6a24d19
PE
13070 * term.c (term_mouse_position): Don't assume time_t wraparound.
13071
08dc5ae6
PE
13072 Be more systematic about user-interface timestamps.
13073 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13074 and sometimes 'EMACS_UINT', to represent these timestamps.
13075 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13076 This makes the code easier to follow, and makes it easier to catch
13077 integer overflow bugs such as Bug#8664.
13078 * frame.c (Fmouse_position, Fmouse_pixel_position):
13079 Use Time, not unsigned long, for user-interface timestamps.
13080 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13081 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13082 * keyboard.h (last_event_timestamp): Likewise.
13083 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13084 * menu.h (xmenu_show): Likewise.
13085 * term.c (term_mouse_position): Likewise.
13086 * termhooks.h (struct input_event.timestamp): Likewise.
13087 (struct terminal.mouse_position_hook): Likewise.
13088 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13089 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13090 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13091 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13092 what it was before.
13093 * menu.h, termhooks.h: Include "systime.h", for Time.
13094
8e55734a
PE
13095 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13096 Don't assume that the difference between two unsigned long values
13097 can fit into an integer. At this point, we know button_down_time
13098 <= event->timestamp, so the difference must be nonnegative, so
13099 there's no need to cast the result if double-click-time is
13100 nonnegative, as it should be; check that it's nonnegative, just in
13101 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13102 apart (about 25 days). (Bug#8664)
8e55734a 13103
841f1b75 13104 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13105 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13106
3e26f69c
PE
13107 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13108 that always fit in int. Use a sentinel instead of a counter, to
13109 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13110 * frame.h (struct frame): Use int for menu_bar_items_used
13111 instead of EMACS_INT, since it always fits in int.
3e26f69c 13112
5cc152c0
PE
13113 * menu.c (grow_menu_items): Check for int overflow.
13114
d89eb65e
PE
13115 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13116
5235bd3e
PE
13117 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13118 Before, the code was not consistent. These values cannot exceed
13119 2**31 - 1 so there's no need to make them unsigned.
13120 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
13121 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
13122 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13123 as modifiers.
13124 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13125
bc827e23
PE
13126 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13127 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13128 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13129 presumably because the widths might not match.
13130
78eb494e
PE
13131 * window.c (size_window): Avoid needless test at loop start.
13132
04f2d78b
CB
131332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13134
13135 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13136
d2fc7e3d 131372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13138
13139 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13140
d2fc7e3d 131412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13142
13143 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13144 `width' to `bar_area_x' and `bar_area_width', respectively.
13145 (x_scroll_run): Take account of fringe background extension.
13146
04f2d78b
CB
13147 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13148 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13149 `bar_area_width', respectively.
13150 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13151 background extension.
13152
79b70037
GM
131532011-05-10 Jim Meyering <meyering@redhat.com>
13154
13155 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13156
2f142cc5
JB
131572011-05-10 Juanma Barranquero <lekktu@gmail.com>
13158
13159 * image.c (Finit_image_library): Return t for built-in image types,
13160 like pbm and xbm. (Bug#8640)
13161
57679c86
AS
131622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13163
13164 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13165
888c9e86
EZ
131662011-05-07 Eli Zaretskii <eliz@gnu.org>
13167
b0512a1d
EZ
13168 * w32console.c (Fset_screen_color): Doc fix.
13169 (Fget_screen_color): New function.
13170 (syms_of_ntterm): Defsubr it.
13171
7285dc67
EZ
13172 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13173 unlink the temporary file if Fcall_process didn't create it in the
13174 first place.
13175 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13176 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13177 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13178 cue to call_process_cleanup not to close that handle.
13179
4d3fcc8e
BK
131802011-05-07 Ben Key <bkey76@gmail.com>
13181
13182 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13183 one of two shell specific rules, either bootstrap-temacs-CMD or
13184 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13185 to the previous implementation of the bootstrap-temacs rule.
13186 The bootstrap-temacs-CMD rule is similar to the previous
13187 implementation of the bootstrap-temacs rule except that it
13188 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13189 variable.
13190
13191 These changes, along with some changes to nt/configure.bat,
13192 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13193 earlier fix to add support for --cflags and --ldflags options
13194 that include quotes so that it works whether make uses cmd or
13195 sh as the shell.
13196
b4289b64
MA
131972011-05-06 Michael Albinus <michael.albinus@gmx.de>
13198
13199 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13200 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13201 is a constant.
13202 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13203 a string. Handle both cases.
13204 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13205 (Fdbus_register_method): Use Qinvalid_function.
13206
af4c0e28
JB
132072011-05-06 Juanma Barranquero <lekktu@gmail.com>
13208
13209 * makefile.w32-in: Update dependencies.
13210 (LISP_H): Add inttypes.h and stdin.h.
13211 (PROCESS_H): Add unistd.h.
13212
c51453d9
EZ
132132011-05-06 Eli Zaretskii <eliz@gnu.org>
13214
13215 * lread.c: Include limits.h (fixes the MS-Windows build broken by
13216 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
13217
8ff0ac3c 132182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 13219
4c4b566b
PE
13220 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
13221
aab2b9b5
PE
13222 * term.c (vfatal): Remove stray call to va_end.
13223 It's not needed and the C Standard doesn't allow it here anyway.
13224
c378da0b
PE
13225 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
13226 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
13227
288b08c7
PE
13228 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
13229 bytes.
13230
e3601888
PE
13231 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13232
db6c0e74
PE
13233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13234
dd5963ea
PE
13235 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
13236
88c9450f
PE
13237 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
13238
2f9442b8
PE
13239 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
13240
c032b5f8
PE
13241 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
13242 * charset.c (Fdefine_charset_internal): Don't initialize
13243 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 13244 32-bit int (Bug#8600).
a108c10b
PE
13245
13246 * lread.c (read_integer): Be more consistent with string-to-number.
13247 Use string_to_number to do the actual conversion; this avoids
13248 rounding errors and fixes some other screwups. Without this fix,
13249 for example, #x1fffffffffffffff was misread as -2305843009213693952.
13250 (digit_to_number): Move earlier, for benefit of read_integer.
13251 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 13252 not a digit in any supported base. (Bug#8602)
a108c10b 13253
ad5f9eea
PE
13254 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
13255
aec1708a
PE
13256 * dispnew.c (scrolling_window): Return 1 if we scrolled,
13257 to match comment at start of function. This also removes a
13258 GCC warning about overflow in a 32+64-bit port.
13259
47be4ab5
PE
13260 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
13261
371cac43
PE
13262 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
13263 Reported by Stefan Monnier in
13264 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
13265 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13266 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 13267
d01a7826
PE
13268 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
13269 (EMACS_UINTPTR): Likewise, with uintptr_t.
13270
7fd47d5c
PE
13271 * lisp.h: Prefer 64-bit EMACS_INT if available.
13272 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
13273 on 32-bit hosts that have 64-bit int, so that they can access
13274 large files.
122b0c86
PE
13275 However, temporarily disable this change unless the temporary
13276 symbol WIDE_EMACS_INT is defined.
7fd47d5c 13277
8727937b
PE
13278 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
13279
8ac068ac
PE
13280 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
13281 This removes an assumption that EMACS_INT and long are the same
13282 width as pointers. The assumption is true for Emacs porting targets
13283 now, but we want to make other targets possible.
13284 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
13285 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
13286 In the rest of the code, change types of integers that hold casted
13287 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
13288 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
13289 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13290 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
13291 No need to cast type when ORing.
13292 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
13293 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
13294 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
13295 assume EMACS_INT is the same width as char *.
13296 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
13297 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
13298 Remove no-longer-needed casts.
13299 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
13300 (xg_tool_bar_help_callback, xg_make_tool_item):
13301 Use EMACS_INTPTR to hold an integer
13302 that will be cast to void *; this can avoid a GCC warning
13303 if EMACS_INT is not the same width as void *.
13304 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
13305 * xdisp.c (display_echo_area_1, resize_mini_window_1):
13306 (current_message_1, set_message_1):
13307 Use a local to convert to proper width without a cast.
13308 * xmenu.c (dialog_selection_callback): Likewise.
13309
ede49d71
PE
13310 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
13311 Also, don't assume VALBITS / RAND_BITS is less than 5,
13312 and don't rely on undefined behavior when shifting a 1 left into
13313 the sign bit.
13314 * lisp.h (get_random): Change signature to match.
13315
2f30ecd0
PE
13316 * lread.c (hash_string): Use size_t, not int, for hash computation.
13317 Normally we prefer signed values; but hashing is special, because
13318 it's better to use unsigned division on hash table sizes so that
13319 the remainder is nonnegative. Also, size_t is the natural width
13320 for hashing into memory. The previous code used 'int', which doesn't
13321 retain enough info to hash well into very large tables.
13322 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
13323
2a866e7b
PE
13324 * dbusbind.c: Don't possibly lose pointer info when converting.
13325 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13326 Use XPNTR rather than XHASH, so that the high-order bits of
13327 the pointer aren't lost when converting through void *.
13328
51639eac
PE
13329 * eval.c (Fautoload): Don't double-shift a pointer.
13330
92394119
PE
13331 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
13332
dbdb9a7c
JB
133332011-05-06 Juanma Barranquero <lekktu@gmail.com>
13334
13335 * gnutls.c (DEF_GNUTLS_FN):
13336 * image.c (DEF_IMGLIB_FN): Make function pointers static.
13337
db7a0b4f
AS
133382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
13339
13340 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
13341 marker. (Bug#8610)
13342
cd394be1 133432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
13344
13345 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
13346 New version that can reserve upto 2GB of heap space.
13347
f7ff1b0f 133482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
13349
13350 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
13351
639c109b
TZ
133522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
13353
13354 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13355 `gnutls_certificate_set_x509_key_file'.
13356
d2127135
JB
133572011-05-05 Juanma Barranquero <lekktu@gmail.com>
13358
13359 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
13360 Update dependencies.
13361
e968f4f3
JB
133622011-05-04 Juanma Barranquero <lekktu@gmail.com>
13363
13364 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
13365 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
13366 Remove unused parameter `fildes'.
13367 * process.c (read_process_output, send_process): Don't pass it.
13368
84d358f0
JB
133692011-05-04 Juanma Barranquero <lekktu@gmail.com>
13370
13371 Fix previous change: the library cache is defined in w32.c.
13372 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
13373 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
13374
0898ca10
JB
133752011-05-04 Juanma Barranquero <lekktu@gmail.com>
13376
13377 Implement dynamic loading of GnuTLS on Windows.
13378
13379 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
13380 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
13381 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13382 Declare.
13383
13384 * gnutls.c (Qgnutls_dll): Define.
13385 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
13386 (gnutls_*): Declare function pointers.
13387 (init_gnutls_functions): New function to initialize function pointers.
13388 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
13389 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
13390 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13391 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
13392 (emacs_gnutls_write, emacs_gnutls_read)
13393 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
13394 (Fgnutls_available_p): New function.
13395 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
13396 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
13397 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
13398
13399 * image.c: Include w32.h.
13400 (Vimage_type_cache): Delete.
13401 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
13402 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
13403 (w32_delayed_load): Move to w32.c.
13404
13405 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
13406
13407 * w32.c (QCloaded_from, Vlibrary_cache): Define.
13408 (w32_delayed_load): Move from image.c. When loading a library, record
13409 its filename in the :loaded-from property of the library id.
13410 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
13411 Initialize and staticpro them.
13412 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
13413
13414 * process.c: Include lisp.h before w32.h, not after.
13415 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
13416 instead of gnutls_record_check_pending.
13417
13418 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
13419
ff4de4aa
TZ
134202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
13421
13422 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
13423 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
13424 as passed in.
13425
abe95abb
JD
134262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
13427
13428 * xterm.c (x_set_frame_alpha): Do not set property on anything
13429 else than FRAME_X_OUTER_WINDOW (Bug#8608).
13430
e16e55d4
JB
134312011-05-02 Juanma Barranquero <lekktu@gmail.com>
13432
13433 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
13434
bafcf6a5
JB
134352011-05-02 Juanma Barranquero <lekktu@gmail.com>
13436
13437 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
13438 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
13439 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
13440 (gnutls_global_initialized, Qgnutls_bootprop_priority)
13441 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
13442 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13443 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
13444 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
13445 (Qgnutls_bootprop_callbacks_verify): Make static.
13446
e7a6747f
AS
134472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
13448
19ed11ba
AS
13449 * callproc.c: Indentation fixup.
13450
e7a6747f 13451 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
13452 (wait_for_termination, interruptible_wait_for_termination):
13453 Move after wait_for_termination_1.
e7a6747f 13454
1ef14cb4
LMI
134552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
13456
13457 * sysdep.c (interruptible_wait_for_termination): New function
13458 which is like wait_for_termination, but allows keyboard
13459 interruptions.
13460
13461 * callproc.c (Fcall_process): Add (:file "file") as an option for
13462 the STDOUT buffer.
13463 (Fcall_process_region): Ditto.
13464
330d880c
EZ
134652011-04-30 Eli Zaretskii <eliz@gnu.org>
13466
8db90b73
EZ
13467 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
13468 rather than `XVECTOR (FOO)->size'.
13469
330d880c
EZ
13470 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
13471 inttypes.h, as a gnulib replacement is used if it not available in
13472 system headers.
13473
15cbd324
EZ
134742011-04-21 Eli Zaretskii <eliz@gnu.org>
13475
13476 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13477 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
13478 of MOST_POSITIVE_FIXNUM. (Bug#8528)
13479
13480 * coding.c (coding_alloc_by_realloc): Error out if destination
13481 will grow beyond MOST_POSITIVE_FIXNUM.
13482 (decode_coding_emacs_mule): Abort if there isn't enough place in
13483 charbuf for the composition carryover bytes. Reserve an extra
13484 space for up to 2 characters produced in a loop.
13485 (decode_coding_iso_2022): Abort if there isn't enough place in
13486 charbuf for the composition carryover bytes.
13487
134882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 13489
ae940cca
EZ
13490 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
13491 aborting when %lld or %lll format is passed.
13492 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13493 %llo or %llx format is passed. (Bug#8545)
13494
03ab8921
EZ
13495 * window.c (window_scroll_line_based): Use a marker instead of
13496 simple variables to record original value of point. (Bug#7952)
13497
afda1437
EZ
13498 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13499 produced by %s or %c overflows available buffer space. (Bug#8545)
13500
f76dee0c
PE
135012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13502
13503 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13504 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13505
fdc5744d
JB
135062011-04-28 Juanma Barranquero <lekktu@gmail.com>
13507
13508 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13509
638f053a
JB
135102011-04-28 Juanma Barranquero <lekktu@gmail.com>
13511
13512 * keyboard.c (Qdelayed_warnings_hook): Define.
13513 (command_loop_1): Run `delayed-warnings-hook'
13514 if Vdelayed_warnings_list is non-nil.
13515 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13516 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13517
d178f871
EZ
135182011-04-28 Eli Zaretskii <eliz@gnu.org>
13519
13520 * doprnt.c (doprnt): Don't return value smaller than the buffer
13521 size if the message was truncated. (Bug#8545).
13522
b124fd93
JB
135232011-04-28 Juanma Barranquero <lekktu@gmail.com>
13524
13525 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13526 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13527
e810457d
PE
135282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13529
13530 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13531
ea51cceb
JB
135322011-04-27 Juanma Barranquero <lekktu@gmail.com>
13533
13534 * makefile.w32-in: Update dependencies.
13535
94dcfacf
EZ
135362011-04-27 Eli Zaretskii <eliz@gnu.org>
13537
13538 Improve `doprnt' and its usage. (Bug#8545)
13539 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13540 `format_end'. Remove support for %l as a conversion specifier.
13541 Don't use xrealloc. Improve diagnostics when the %l size modifier
13542 is used. Update the commentary.
13543
13544 * eval.c (verror): Simplify calculation of size_t.
13545
13546 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13547 messages.
13548
f61f41d7
PE
135492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13550
13551 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13552 change.
13553
96fb4434
PE
135542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13555
13556 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13557 This makes this file independent of the recent pseudovector change.
13558
671875da 135592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13560
69e9b5a3
PE
13561 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13562
b5f869a7 13563 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13564 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13565 Remove unused local.
c8926152 13566 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13567
841a1577 13568 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13569 GCC 4.6.0 optimizes based on type-based alias analysis.
13570 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13571 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13572 != &v->size, and therefore "v->size = 1; b->size = 2; return
13573 v->size;" must therefore return 1. This assumption is incorrect
13574 for Emacs, since it type-puns struct Lisp_Vector * with many other
13575 types. To fix this problem, this patch adds a new type struct
f904488f 13576 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13577 and pseudovectors, and helps optimizing compilers not get fooled
13578 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13579 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13580 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13581 the size member.
eab3844f
PE
13582 (XSETPVECTYPE): Rewrite in terms of new macro.
13583 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13584 This is a bit clearer, and further avoids the possibility of
13585 undesirable aliasing.
13586 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13587 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13588 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13589 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13590 (ASIZE): Now uses header.size rather than size.
13591 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13592 to avoid the hassle of writing XVECTOR (foo)->header.size.
13593 (struct vectorlike_header): New type.
eab3844f
PE
13594 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13595 object, to help avoid aliasing.
13596 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13597 (SUBRP): Likewise, since Lisp_Subr is a special case.
13598 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13599 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13600 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13601 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13602 changed to be "header.size" and "header.next".
13603 * buffer.h (struct buffer): Likewise.
13604 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13605 * frame.h (struct frame): Likewise.
13606 * process.h (struct Lisp_Process): Likewise.
13607 * termhooks.h (struct terminal): Likewise.
13608 * window.c (struct save_window_data, struct saved_window): Likewise.
13609 * window.h (struct window): Likewise.
13610 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13611 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13612 * buffer.c (init_buffer_once): Likewise.
13613 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13614 special case.
13615 * process.c (Fformat_network_address): Use local var for size,
13616 for brevity.
13617
0df1eac5
PE
13618 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13619
847ab9d1 13620 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13621 * data.c (atof): Remove decl; no longer used or needed.
13622 (digit_to_number): Move to lread.c.
13623 (Fstring_to_number): Use new string_to_number function, to be
13624 consistent with how the Lisp reader treats infinities and NaNs.
13625 Do not assume that floating-point numbers represent EMACS_INT
13626 without losing information; this is not true on most 64-bit hosts.
13627 Avoid double-rounding errors, by insisting on integers when
13628 parsing non-base-10 numbers, as the documentation specifies.
13629 * lisp.h (string_to_number): New decl, replacing ...
13630 (isfloat_string): Remove.
bc0a5c13 13631 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13632 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13633 appears to have been a coding error. Similarly, do not accept
13634 strings like +-1e0 as floating point numbers. Do not report
13635 overflow for integer overflows unless the base is not 10 which
13636 means we have no simple and reliable way to continue.
13637 Break out the floating-point parsing into a new
13638 function string_to_number, so that Fstring_to_number parses
13639 floating point numbers consistently with the Lisp reader.
04f2d78b 13640 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13641 (E_CHAR, EXP_INT): Remove, replacing with ...
13642 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13643 (string_to_number): New function, replacing isfloat_string.
13644 This function checks for valid syntax and produces the resulting
13645 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13646 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13647 so that overflow for non-base-10 numbers is reported only when
13648 there's no portable and simple way to convert to floating point.
452f4150 13649
67769ffc
PE
13650 * textprop.c (set_text_properties_1): Rewrite for clarity,
13651 and to avoid GCC warning about integer overflow.
13652
c20db43f
PE
13653 * intervals.h (struct interval): Use EMACS_INT for members
13654 where EMACS_UINT might cause problems. See
13655 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13656 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13657 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13658 All uses changed.
37aa2f85
PE
13659 (offset_intervals): Tell GCC not to worry about length overflow
13660 when negating a negative length.
c20db43f 13661
2538aa2f
PE
13662 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13663 (overrun_check_free): Likewise.
13664
f2d3008d
PE
13665 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13666 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13667 word size.
13668
ec8df744
PE
13669 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13670 (gnutls_make_error): Rename local to avoid shadowing.
13671 (gnutls_emacs_global_deinit): ifdef out; not used.
13672 (Fgnutls_boot): Use const for pointer to readonly storage.
13673 Comment out unused local. Fix pointer signedness problems.
13674
640ee02d
PE
13675 * lread.c (openp): Don't stuff size_t into an 'int'.
13676 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13677 about possible signed overflow.
13678
6048fb2a
PE
13679 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13680 (GDK_KEY_g): Don't define if already defined.
13681 (xg_prepare_tooltip): Avoid pointer signedness problem.
13682 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13683
fa3c87e1
PE
13684 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13685 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13686
2172544b
PE
13687 * xfns.c (Fx_window_property): Simplify a bit,
13688 to make a bit faster and to avoid GCC 4.6.0 warning.
13689 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13690
9b821a21
PE
13691 * fns.c (internal_equal): Don't assume size_t fits in int.
13692
3c616cfa
PE
13693 * alloc.c (compact_small_strings): Tighten assertion a little.
13694
c2982e87
PE
13695 Replace pEd with more-general pI, and fix some printf arg casts.
13696 * lisp.h (pI): New macro, generalizing old pEd macro to other
13697 conversion specifiers. For example, use "...%"pI"d..." rather
13698 than "...%"pEd"...".
13699 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13700 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13701 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13702 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13703 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13704 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13705 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13706 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13707 64-bit hosts.
13708 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13709 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13710 * print.c (safe_debug_print, print_object): Likewise.
13711 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13712 to int.
6f04d126
PE
13713 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13714 avoiding the 0 flag, which is not portable.
c2982e87
PE
13715 * process.c (Fmake_network_process): Use pI to avoid cast.
13716 * region-cache.c (pp_cache): Likewise.
13717 * xdisp.c (decode_mode_spec): Likewise.
13718 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13719 behavior on 64-bit hosts with printf arg.
6f04d126 13720 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13721 (x_stop_queuing_selection_requests): Likewise.
13722 (x_get_window_property): Don't truncate byte count to an 'int'
13723 when tracing.
0b432f21 13724
5e073ec7
PE
13725 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13726 here, since it parses constructs like leading '-' and spaces,
13727 which are not wanted; and it overflows with large numbers.
13728 Instead, simply match F[0-9]+, which is what is wanted anyway.
13729
36372bf9
PE
13730 * alloc.c: Remove unportable assumptions about struct layout.
13731 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13732 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13733 (allocate_vectorlike, make_pure_vector): Use the new macros,
13734 plus offsetof, to remove unportable assumptions about struct layout.
13735 These assumptions hold on all porting targets that I know of, but
13736 they are not guaranteed, they're easy to remove, and removing them
13737 makes further changes easier.
13738
0b432f21
PE
13739 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13740 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13741 (string_overrun_cookie): Now const. Use initializers that
13742 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13743 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13744 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13745 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13746 multiple of sizeof (EMACS_INT); it need not be, if
13747 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13748 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13749
895009e1
JB
137502011-04-26 Juanma Barranquero <lekktu@gmail.com>
13751
13752 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13753
6a7a1b0b
TZ
137542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13755
13756 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13757 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13758 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13759
841a1577 137602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13761
13762 * lisp.h (Qdebug): List symbol.
895009e1 13763 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13764 * keyboard.c (debug-on-event): New variable.
13765 (handle_user_signal): Break into debugger when debug-on-event
13766 matches the current signal symbol.
13767
f2d3ba6f
DN
137682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13769
13770 * alloc.c (check_sblock, check_string_bytes)
13771 (check_string_free_list): Convert to standard C.
13772
42ce4c63
TZ
137732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13774
13775 * w32.c (emacs_gnutls_push): Fix typo.
13776
825cd63c
EZ
137772011-04-25 Eli Zaretskii <eliz@gnu.org>
13778
fb11d64d
EZ
13779 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13780 "cast to pointer from integer of different size".
13781
825cd63c
EZ
13782 Improve doprnt and its use in verror. (Bug#8545)
13783 * doprnt.c (doprnt): Document the set of format control sequences
13784 supported by the function. Use SAFE_ALLOCA instead of always
13785 using `alloca'.
13786
13787 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13788 is one byte too soon. Don't use xrealloc; instead xfree and
13789 xmalloc anew.
13790
e061a11b
TZ
137912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13792
13793 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13794 callbacks stage.
13795
13796 * gnutls.c: Renamed global_initialized to
13797 gnutls_global_initialized. Added internals for the
13798 :verify-hostname-error, :verify-error, and :verify-flags
13799 parameters of `gnutls-boot' and documented those parameters in the
13800 docstring. Start callback support.
9173deec
JB
13801 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13802 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13803 on error. Return error code.
e061a11b
TZ
13804 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13805 (emacs_gnutls_read): Likewise.
13806 (Fgnutls_boot): Return handshake error code.
13807 (emacs_gnutls_handle_error): New function.
13808 (wsaerror_to_errno): Likewise.
13809
13810 * w32.h (emacs_gnutls_pull): Add prototype.
13811 (emacs_gnutls_push): Likewise.
13812
13813 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13814 (emacs_gnutls_push): Likewise.
13815
138162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13817
13818 * process.c (wait_reading_process_output): Check if GnuTLS
13819 buffered some data internally if no FDs are set for TLS
13820 connections.
13821
13822 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13823 (LIBS): Link to USER_LIBS.
13824 ($(BLD)/gnutls.$(0)): New target.
13825
fa6996bc
EZ
138262011-04-24 Eli Zaretskii <eliz@gnu.org>
13827
eb35682e
EZ
13828 * xdisp.c (handle_single_display_spec): Rename the
13829 display_replaced_before_p argument into display_replaced_p, to
13830 make it consistent with the commentary. Fix typos in the
13831 commentary.
13832
e2ad650c
EZ
13833 * textprop.c (syms_of_textprop): Remove dead code.
13834 (copy_text_properties): Delete obsolete commentary about an
13835 interface that was deleted long ago. Fix typos in the description
13836 of arguments.
13837
1b2de274
EZ
13838 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13839 to changes in oldXMenu/XMenu.h from 2011-04-16.
13840 <menu_help_message, prev_menu_help_message>: Constify.
13841 (IT_menu_make_room): menu->help_text is now `const char **';
13842 adjust.
13843
13844 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13845 to changes in oldXMenu/XMenu.h from 2011-04-16.
13846 (struct XMenu): Declare `help_text' `const char **'.
13847
13848 * xfaces.c <Qunspecified>: Make extern again.
13849
13850 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13851 required by POSIX.
1b2de274 13852
762b15be
EZ
13853 * doc.c (get_doc_string): Improve the format passed to `error'.
13854
13855 * doprnt.c (doprnt): Improve commentary.
13856
13857 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13858
13859 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13860 them with etags.
13861
f1052e5d
EZ
13862 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13863 changes in globals.h immediately force recompilation.
762b15be
EZ
13864 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13865 $(CURDIR)/s/ms-w32.h.
13866 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13867
fa6996bc
EZ
13868 * character.c (Fchar_direction): Function deleted.
13869 (syms_of_character): Don't defsubr it.
13870 <char-direction-table>: Deleted.
13871
e6c3da20
EZ
138722011-04-23 Eli Zaretskii <eliz@gnu.org>
13873
13874 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13875 * doprnt.c: Include limits.h.
13876 (SIZE_MAX): New macro.
04f2d78b
CB
13877 (doprnt): Return a size_t value. 2nd arg is now size_t.
13878 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13879 Improve overflow protection. Support `l' modifier for integer
13880 conversions. Support %l conversion. Don't assume an EMACS_INT
13881 argument for integer conversions and for %c.
13882
13883 * lisp.h (doprnt): Restore prototype.
13884
13885 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13886 $(SRC)/character.h.
13887
13888 * Makefile.in (base_obj): Add back doprnt.o.
13889
13890 * deps.mk (doprnt.o): Add back prerequisites.
13891 (callint.o): Depend on character.h.
13892
13893 * eval.c (internal_lisp_condition_case): Include the handler
13894 representation in the error message.
13895 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13896 when breaking from the loop.
13897
13898 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13899
13900 * callint.c (Fcall_interactively): When displaying error message
13901 about invalid control letter, pass the character's codepoint, not
13902 a pointer to its multibyte form. Improve display of the character
13903 in octal and display also its hex code.
13904
13905 * character.c (char_string): Use %x to display the (unsigned)
13906 codepoint of an invalid character, to avoid displaying a bogus
13907 negative value.
13908
13909 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13910 `error', not SYMBOL_NAME itself.
13911
13912 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13913 character arguments to `error'.
13914
13915 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13916 to `error' in error message about FINAL_CHAR argument. Make sure
13917 FINAL_CHAR is a character, and use %c when it is passed as
13918 argument to `error'.
13919
4ffd0d6b 139202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13921
13922 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13923
13924 * w32.c: Include <time.h>.
13925 (sys_localtime): New function.
13926
4ffd0d6b 139272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13928
13929 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13930
4ffd0d6b 13931 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13932
4ffd0d6b 139332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13934
4ffd0d6b
GM
13935 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13936 zombies (Bug#8467).
aac0c6e3 13937
04c56954
EZ
139382011-04-19 Eli Zaretskii <eliz@gnu.org>
13939
13940 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13941 gl_state.e_property when gl_state.object is Qt.
13942
13943 * insdel.c (make_gap_larger): Remove limitation of buffer size
13944 to <= INT_MAX.
13945
16a43933
CY
139462011-04-18 Chong Yidong <cyd@stupidchicken.com>
13947
13948 * xdisp.c (lookup_glyphless_char_display)
13949 (produce_glyphless_glyph): Handle cons cell entry in
13950 glyphless-char-display.
13951 (Vglyphless_char_display): Document it.
13952
13953 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13954 glyphless-char-display.
13955
4581706e
CY
139562011-04-17 Chong Yidong <cyd@stupidchicken.com>
13957
13958 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13959
13960 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13961
13962 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13963 definition for no-X builds.
13964
4887c6e2 139652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13966
fd35b6f9
PE
13967 Static checks with GCC 4.6.0 and non-default toolkits.
13968
5c1ccb01
PE
13969 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13970
006c5daa
PE
13971 * process.c (keyboard_bit_set): Define only if SIGIO.
13972 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13973 (send_process): Repair possible setjmp clobbering.
13974
efc736d3
PE
13975 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13976
4e2fe2e6
PE
13977 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13978
f97334a2
PE
13979 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13980
4e75f29d
PE
13981 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13982 Define only if needed.
13983
90efadd1
PE
13984 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13985 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13986 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13987
3c647824
PE
13988 * dispextern.h (struct redisplay_interface): Rename param
13989 to avoid shadowing.
e264f262 13990 * termhooks.h (struct terminal): Likewise.
761383f4 13991 * xterm.c (xembed_send_message): Likewise.
3c647824 13992
b58c5c4a
PE
13993 * insdel.c (make_gap_smaller): Define only if
13994 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13995
cad59032
PE
13996 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13997 it.
13998
c339dc2e
PE
13999 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14000 so that we aren't warned about unused symbols.
14001
91a3e27b
PE
14002 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14003
399c71d3 14004 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14005
8ffc96f5
PE
14006 * xfns.c (x_real_positions): Mark locals as initialized.
14007
eef9bc79
PE
14008 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14009
098db9dd
PE
14010 * xterm.c: Fix problems found by static analysis with other toolkits.
14011 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14012 (x_dispatch_event): Declare static if USE_GTK, and
14013 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14014 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14015 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14016 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14017 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14018
eb18f6cc
PE
14019 * xmenu.c (menu_help_callback): Pointer type fixes.
14020 Use const pointers when pointing at readonly data. Avoid pointer
14021 signedness clashes.
14022 (FALSE): Remove unused macro.
14023 (update_frame_menubar): Remove unused decl.
14024
1fe72bf8
PE
14025 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14026
60d9e1db
PE
14027 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14028 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14029 (single_menu_item): Rename local to avoid shadowing.
14030
39261c26
PE
14031 * keyboard.c (make_lispy_event): Remove unused local var.
14032
018c5e19
PE
14033 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14034 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14035
63d2b86e
PE
14036 * bitmaps: Change bitmaps from unsigned char back to the X11
14037 compatible char. Avoid the old compiler warnings about
14038 out-of-range initializers by using, for example, '\xab' rather
14039 than 0xab.
14040
aefd87e1
PE
14041 * xgselect.c (xgselect_initialize): Check vs interface
14042 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14043
bf501fb9
PE
14044 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14045
e9829fdf
PE
14046 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14047 to read-only memory.
14048
1086c095
PE
14049 * fns.c (vector): Remove; this old hack is no longer needed.
14050
2baccd04 14051 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14052 Remove unused var.
dde42981 14053 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14054
72391843 14055 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14056
436c16df 14057 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14058 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14059 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14060
92bb796d 14061 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14062 (x_term_init): Remove local to avoid shadowing.
92bb796d 14063
764430a3 14064 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14065
14066 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14067 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14068
d1dfb56c
EZ
140692011-04-16 Eli Zaretskii <eliz@gnu.org>
14070
c4354cb4
EZ
14071 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14072
d1dfb56c
EZ
14073 Fix regex.c, syntax.c and friends for buffers > 2GB.
14074 * syntax.h (struct gl_state_s): Declare character position members
14075 EMACS_INT.
14076
14077 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14078
04f2d78b
CB
14079 * textprop.c (verify_interval_modification, interval_of):
14080 Declare arguments EMACS_INT.
d1dfb56c
EZ
14081
14082 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14083 EMACS_INT.
14084
14085 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14086
14087 * indent.c (Fvertical_motion): Local variable it_start is now
14088 EMACS_INT.
14089
14090 * regex.c (re_match, re_match_2, re_match_2_internal)
14091 (bcmp_translate, regcomp, regexec, print_double_string)
14092 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14093 (re_compile_pattern, re_exec): Declare arguments and local
14094 variables `size_t' and `ssize_t' and return values `regoff_t', as
14095 appropriate.
14096 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14097 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14098 <compile_stack_type>: `size' and `avail' are now `size_t'.
14099
14100 * regex.h <regoff_t>: Use ssize_t, not int.
14101 (re_search, re_search_2, re_match, re_match_2): Arguments that
14102 specify buffer/string position and length are now ssize_t and
14103 size_t. Return type is regoff_t.
14104
613052cd
BK
141052011-04-16 Ben Key <bkey76@gmail.com>
14106
14107 * nsfont.m: Fixed bugs in ns_get_family and
14108 ns_descriptor_to_entity that were caused by using free to
14109 deallocate memory blocks that were allocated by xmalloc (via
14110 xstrdup). This caused Emacs to crash when compiled with
14111 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14112 --enable-checking=xmallocoverrun). xfree is now used to
14113 deallocate these memory blocks.
14114
4170f62f 141152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14116
71b41406
PE
14117 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14118
9587a89d
PE
14119 emacs_write: Accept and return EMACS_INT for sizes.
14120 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
14121 et seq.
14122 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
14123 Accept and return EMACS_INT.
14124 (emacs_gnutls_write): Return the number of bytes written on
14125 partial writes.
14126 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14127 (emacs_read, emacs_write): Remove check for negative size, as the
14128 Emacs source code has been audited now.
9587a89d
PE
14129 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14130 (emacs_read, emacs_write): Use it.
273a5f82
PE
14131 * process.c (send_process): Adjust to the new signatures of
14132 emacs_write and emacs_gnutls_write. Do not attempt to store
14133 a byte offset into an 'int'; it might overflow.
9587a89d 14134 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14135
3e047f51
PE
14136 * sound.c: Don't assume sizes fit in 'int'.
14137 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14138 Return EMACS_INT, not int.
3e047f51 14139 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14140 Accept EMACS_INT, not int.
14141 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14142 record read return values.
14143
cc39a9db
BK
141442011-04-15 Ben Key <bkey76@gmail.com>
14145
c9d0ec6d
JB
14146 * keyboard.c (Qundefined): Don't declare static since it is used
14147 in nsfns.m.
14148 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14149 static since they are used in nsfont.m.
cc39a9db 14150
6c60eb9f
SM
141512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14152
14153 * process.c (Qprocessp): Don't declare static.
14154 * lisp.h (Qprocessp): Declare again.
14155
7990b61a
JB
141562011-04-15 Juanma Barranquero <lekktu@gmail.com>
14157
14158 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14159
5d4cb038
PE
141602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14161
8bd7b830 14162 Improve C-level modularity by making more things 'static'.
cd64ea1d 14163
e3b27b31
PE
14164 Don't publish debugger-only interfaces to other modules.
14165 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14166 (verify_bytepos, count_markers): Move decls to the only modules
14167 that need them.
14168 * region-cache.h (pp_cache): Likewise.
14169 * window.h (check_all_windows): Likewise.
14170 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14171
5d4cb038
PE
14172 * sysdep.c (croak): Now static, if
14173 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14174 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14175
14176 * alloc.c (refill_memory_reserve): Now static if
14177 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14178 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14179
e87b6180
PE
14180 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14181 Define only if USE_LUCID.
14182
ac64929e
PE
14183 * xrdb.c (x_customization_string, x_rm_string): Now static.
14184
6f37259d
PE
14185 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14186 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14187
1683e3ab
PE
14188 * xdisp.c (draw_row_with_mouse_face): Now static.
14189 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14190
de9c2632
PE
14191 * window.h (check_all_windows): Mark externally visible.
14192
2b96acb7
PE
14193 * window.c (window_deletion_count): Now static.
14194
14195 * undo.c: Make symbols static if they're not exported.
14196 (last_undo_buffer, last_boundary_position, pending_boundary):
14197 Now static.
14198
50436f33
PE
14199 * textprop.c (interval_insert_behind_hooks): Now static.
14200 (interval_insert_in_front_hooks): Likewise.
14201
64520e5c
PE
14202 * term.c: Make symbols static if they're not exported.
14203 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14204 (max_frame_lines, tty_set_terminal_modes):
14205 (tty_reset_terminal_modes, tty_turn_off_highlight):
14206 (get_tty_terminal): Now static.
14207 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14208 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14209 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14210 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14211 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14212
1fa53021
PE
14213 * sysdep.c: Make symbols static if they're not exported.
14214 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
14215 Now static.
14216 (sigprocmask_set, full_mask): Remove; unused.
14217 (wait_debugging): Mark as visible.
14218 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
14219 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
14220
d4b43b22
PE
14221 * syntax.c (syntax_temp): Define only if !__GNUC__.
14222
b7c513d0
PE
14223 * sound.c (current_sound_device, current_sound): Now static.
14224
989b29ad
PE
14225 * search.c (searchbufs, searchbuf_head): Now static.
14226
13a55a78
PE
14227 * scroll.c (scroll_cost): Remove; unused.
14228 * dispextern.h (scroll_cost): Remove decl.
14229
de68a1fc
PE
14230 * region-cache.h (pp_cache): Mark as externally visible.
14231
40ccffa6
PE
14232 * process.c: Make symbols static if they're not exported.
14233 (process_tick, update_tick, create_process, chan_process):
14234 (Vprocess_alist, proc_buffered_char, datagram_access):
14235 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14236 (deactivate_process): Mark defn as static, as well as decl.
14237 * lisp.h (create_process): Remove decl.
14238 * process.h (chan_process, Vprocess_alist): Remove decls.
14239
ad64fc97
PE
14240 * print.c: Make symbols static if they're not exported.
14241 (print_depth, new_backquote_output, being_printed, print_buffer):
14242 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
14243 (print_interval, print_number_index, initial_stderr_stream):
14244 Now static.
14245 * lisp.h (Fprinc): Remove decl.
14246 (debug_output_compilation_hack): Mark as externally visible.
14247
adddb265
PE
14248 * sysdep.c (croak): Move decl from here to syssignal.h.
14249 * syssignal.h (croak): Put it here, so the API can be checked when
14250 'croak' is called from dissociate_if_controlling_tty.
14251
1717ede2
PE
14252 * minibuf.c: Make symbols static if they're not exported.
14253 (minibuf_save_list, choose_minibuf_frame): Now static.
14254 * lisp.h (choose_minibuf_frame): Remove decl.
14255
fa5fb2bc
PE
14256 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
14257
1e3890d1
PE
14258 * lread.c: Make symbols static if they're not exported.
14259 (read_objects, initial_obarray, oblookup_last_bucket_number):
14260 Now static.
14261 (make_symbol): Remove; unused.
14262 * lisp.h (initial_obarray, make_symbol): Remove decls.
14263
8a1414fa
PE
14264 * keyboard.c: Make symbols static if they're not exported.
14265 (single_kboard, recent_keys_index, total_keys, recent_keys):
14266 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
14267 (this_single_command_key_start, echoing, last_auto_save):
14268 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14269 (command_loop, echo_now, keyboard_init_hook, help_char_p):
14270 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
14271 (Vlispy_mouse_stem, double_click_count):
14272 Now static.
14273 (force_auto_save_soon): Define only if SIGDANGER.
14274 (ignore_mouse_drag_p): Now static if
14275 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
14276 (print_help): Remove; unused.
14277 (stop_character, last_timer_event): Mark as externally visible.
14278 * keyboard.h (ignore_mouse_drag_p): Declare only if
14279 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
14280 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
14281 * lisp.h (echoing): Remove decl.
14282 (force_auto_save_soon): Declare only if SIGDANGER.
14283 * xdisp.c (redisplay_window): Simplify code, to make it more
14284 obvious that ignore_mouse_drag_p is not accessed if !defined
14285 USE_GTK && !defined HAVE_NS.
14286
93ea6e8f
PE
14287 * intervals.c: Make symbols static if they're not exported.
14288 (merge_properties_sticky, merge_interval_right, delete_interval):
14289 Now static.
14290 * intervals.h (merge_interval_right, delete_interval): Remove decls.
14291
77382fcc
PE
14292 * insdel.c: Make symbols static if they're not exported.
14293 However, leave prepare_to_modify_buffer alone. It's never
14294 called from outside this function, but that appears to be a bug.
14295 (combine_after_change_list, combine_after_change_buffer):
4889fc82 14296 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
14297 (adjust_after_replace_noundo): Remove; unused.
14298 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 14299 (signal_before_change): Remove decls.
77382fcc 14300
9306c32e
PE
14301 * indent.c (val_compute_motion, val_vmotion): Now static.
14302
cd44d2eb
PE
14303 * image.c: Make symbols static if they're not exported.
14304 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
14305 if USE_GTK.
14306 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
14307 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
14308
ad9a7a06
PE
14309 * fringe.c (standard_bitmaps): Now static.
14310 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
14311
81626931
PE
14312 * frame.c: Make symbols static if they're not exported.
14313 (x_report_frame_params, make_terminal_frame): Now static.
14314 (get_frame_param): Now static, unless HAVE_NS.
14315 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
14316 (x_get_resource_string): Remove; not used.
14317 * frame.h (make_terminal_frame, x_report_frame_params):
14318 (x_get_resource_string); Remove decls.
14319 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14320 * lisp.h (get_frame_param): Declare only if HAVE_NS.
14321
239f9db9
PE
14322 * font.c, fontset.c: Make symbols static if they're not exported.
14323 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
14324 (FACE_SUITABLE_FOR_CHAR_P): Use it.
14325 * font.c (font_close_object): Now static.
14326 * font.h (font_close_object): Remove.
14327 * fontset.c (FONTSET_OBJLIST): Remove.
14328 (free_realized_fontset) #if-0 the body, which does nothing.
14329 (face_suitable_for_char_p): #if-0, as it's never called.
14330 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
14331 * xfaces.c (face_at_string_position):
14332 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
14333 since 0 is always ASCII.
14334
dfcf3579
PE
14335 * fns.c (weak_hash_tables): Now static.
14336
5045092b
PE
14337 * fileio.c: Make symbols static if they're not exported.
14338 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
14339 (Vwrite_region_annotation_buffers): Now static.
14340
57a96f5c
PE
14341 * eval.c: Make symbols static if they're not exported.
14342 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
14343 * lisp.h (backtrace_list): Remove decl.
14344
35f08c38
PE
14345 * emacs.c: Make symbols static if they're not exported.
14346 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
14347 (fatal_error_code, fatal_error_signal_hook, standard_args):
14348 Now static.
14349 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
14350 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
14351 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
14352 * lisp.h (fatal_error_signal_hook): Remove decl.
14353 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
14354
f44bd759
PE
14355 * editfns.c: Move a (normally-unused) function to its only use.
14356 * editfns.c, lisp.h (get_operating_system_release): Remove.
14357 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
14358 worth the hassle of breaking this out.
14359
b532497d
PE
14360 * xterm.c: Make symbols static if they're not exported.
14361 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
14362 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
14363 (x_destroy_window, x_delete_display):
14364 Now static.
14365 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14366 (x_mouse_leave): Remove; unused.
14367 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
14368 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
14369 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
14370 Remove decls.
14371 (x_mouse_leave): Declare only if WINDOWSNT.
14372 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
14373 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
14374 USE_X_TOOLKIT.
14375
1675728f
PE
14376 * ftxfont.c: Make symbols static if they're not exported.
14377 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
14378 HAVE_FREETYPE.
14379 * font.h (ftxfont_driver): Likewise.
14380
e4cebfca
PE
14381 * xfns.c: Make symbols static if they're not exported.
14382 (x_last_font_name, x_display_info_for_name):
14383 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
14384 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
14385 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
14386 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14387 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
14388 (last_show_tip_args): Now static.
14389 (xic_defaut_fontset, xic_create_fontsetname): Define only if
14390 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
14391 (x_screen_planes): Remove; unused.
14392 * dispextern.h (x_screen_planes): Remove decl.
14393
5bf46f05
PE
14394 * dispnew.c: Make symbols static if they're not exported.
14395 * dispextern.h (redraw_garbaged_frames, scrolling):
14396 (increment_row_positions): Remove.
14397 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
14398 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
14399 Now static.
14400 (redraw_garbaged_frames): Remove; unused.
14401
435f4c28
PE
14402 * xfaces.c: Make symbols static if they're not exported.
14403 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
14404 Remove decls.
14405 * xterm.h (defined_color): Remove decls.
14406 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
14407 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
14408 (menu_face_changed_default, defined_color, free_realized_face):
14409 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
14410 (ascii_face_of_lisp_face): Remove; unused.
14411
8524aef3
PE
14412 * xdisp.c: Make symbols static if they're not exported.
14413 * dispextern.h (scratch_glyph_row, window_box_edges):
14414 (glyph_to_pixel_coords, set_cursor_from_row):
14415 (get_next_display_element, set_iterator_to_next):
14416 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
14417 (show_mouse_face): Remove decls
14418 * frame.h (message_buf_print): Likewise.
14419 * lisp.h (pop_message, set_message, check_point_in_composition):
14420 Likewise.
14421 * xterm.h (set_vertical_scroll_bar): Likewise.
14422 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
14423 (message_buf_print, scratch_glyph_row, displayed_buffer):
14424 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
14425 (get_next_display_element, show_mouse_face, window_box_edges):
14426 (frame_to_window_pixel_xy, check_point_in_composition):
14427 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
14428 (glyph_to_pixel_coords): Remove; unused.
14429
16390cd2
PE
14430 * dired.c (file_name_completion): Now static.
14431
14432 * dbusbind.c (xd_in_read_queued_messages): Now static.
14433
a25f4dfa
PE
14434 * lisp.h (circular_list_error, FOREACH): Remove; unused.
14435 * data.c (circular_list_error): Remove.
14436
14a9c8df
PE
14437 * commands.h (last_point_position, last_point_position_buffer):
14438 (last_point_position_window): Remove decls.
14439 * keyboard.c: Make these variables static.
14440
04f2d78b
CB
14441 * coding.h (coding, code_convert_region, encode_coding_gap):
14442 Remove decls.
74ab6df5
PE
14443 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
14444 (iso_code_class, detect_coding, code_convert_region): Now static.
14445 (encode_coding_gap): Remove; unused.
14446
38dfbee1
PE
14447 * chartab.c (chartab_chars, chartab_bits): Now static.
14448
a2cb4e63
PE
14449 * charset.h (charset_iso_8859_1): Remove decl.
14450 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
14451 Now static.
14452
127198fd
PE
14453 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
14454 * ccl.c (Vccl_program_table): Now static.
14455 (check_ccl_update): Remove; unused.
14456
d85b608f
PE
14457 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
14458 * category.h: ... from here.
14459 * category.c (check_category_table, set_category_set): Now static.
14460
31cd66f3
PE
14461 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
14462 * lisp.h: Remove these decls.
14463
c358e587
PE
14464 * buffer.c (buffer_count): Remove unused var.
14465
e78aecca
PE
14466 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
14467 so that it's not optimized away.
14468 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
14469 * dispextern.h (bidi_dump_cached_states): Remove, since it's
14470 exported only to the debugger.
14471
e192d7d3 14472 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 14473 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 14474
92470028
PE
14475 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
14476 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
14477 was inaccessible from Lisp.
14478 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
14479 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
14480
244ed907
PE
14481 alloc.c: Import and export fewer symbols, and remove unused items.
14482 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
14483 is defined.
14484 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
14485 it's not optimized away by whole-program optimization.
14486 (message_enable_multibyte, free_misc): Remove.
14487 (catchlist, handlerlist, mark_backtrace):
14488 Declare only if BYTE_MARK_STACK.
14489 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
14490 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
14491 (message_enable_multibyte): Remove decl.
14492 (free_misc, interval_free_list, float_block, float_block_index):
14493 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14494 (cons_free_list, last_marked_index):
14495 Now static.
14496 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14497 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14498 (mark_backtrace): Define only if BYTE_MARK_STACK.
14499 * xdisp.c (message_enable_multibyte): Now static.
14500
61c2b50e 14501 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14502 This makes it easier for human readers (and static analyzers)
14503 to see whether these variables are used from other modules.
14504 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14505 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14506 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14507 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14508 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14509 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14510 * xmenu.c, xselect.c:
14511 Declare Q* vars static if they are not used in other modules.
14512 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14513 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14514 Remove decls of unexported vars.
14515 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14516
95c82688
PE
14517 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14518
16a97296
PE
14519 Make Emacs functions such as Fatom 'static' by default.
14520 This makes it easier for human readers (and static analyzers)
14521 to see whether these functions can be called from other modules.
14522 DEFUN now defines a static function. To make the function external
14523 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14524 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14525 (Finit_image_library):
16a97296
PE
14526 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14527 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14528 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14529 Remove decls, since these functions are now static.
14530 (Funintern, Fget_internal_run_time): New decls, since these functions
14531 were already external.
95c82688 14532
16a97296
PE
14533 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14534 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14535 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14536 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14537 * keyboard.c, keymap.c, lread.c:
14538 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14539 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14540 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14541 Mark functions with DEFUE instead of DEFUN,
14542 if they are used in other modules.
14543 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14544 decls for now-static functions.
14545 * buffer.h (Fdelete_overlay): Remove decl.
14546 * callproc.c (Fgetenv_internal): Mark as internal.
14547 * composite.c (Fremove_list_of_text_properties): Remove decl.
14548 (Fcomposition_get_gstring): New forward static decl.
14549 * composite.h (Fcomposite_get_gstring): Remove decl.
14550 * dired.c (Ffile_attributes): New forward static decl.
14551 * doc.c (Fdocumntation_property): New forward static decl.
14552 * eval.c (Ffetch_bytecode): New forward static decl.
14553 (Funintern): Remove extern decl; now in .h file where it belongs.
14554 * fileio.c (Fmake_symbolic_link): New forward static decl.
14555 * image.c (Finit_image_library): New forward static decl.
14556 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14557 * intervals.h (Fprevious_property_change):
14558 (Fremove_list_of_text_properties): Remove decls.
14559 * keyboard.c (Fthis_command_keys): Remove decl.
14560 (Fcommand_execute): New forward static decl.
14561 * keymap.c (Flookup_key): New forward static decl.
14562 (Fcopy_keymap): Now static.
14563 * keymap.h (Flookup_key): Remove decl.
14564 * process.c (Fget_process): New forward static decl.
14565 (Fprocess_datagram_address): Mark as internal.
14566 * syntax.c (Fsyntax_table_p): New forward static decl.
14567 (skip_chars): Remove duplicate decl.
14568 * textprop.c (Fprevious_property_change): New forward static decl.
14569 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14570 Now internal.
14571 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14572 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14573
785bbd42
PE
14574 * editfns.c (Fformat): Remove unreachable code.
14575
8b913b57
AS
145762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14577
14578 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14579 change. (Bug#8496)
14580
a6744a35
EZ
145812011-04-13 Eli Zaretskii <eliz@gnu.org>
14582
14583 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14584 when at ZV. (Bug#8487)
14585
e7974947
AS
145862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14587
baad03f0
AS
14588 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14589 (Bug#8437)
14590 * keyboard.c (parse_tool_bar_item): Likewise.
14591 * sound.c (sound_cleanup, alsa_close): Likewise.
14592 * termcap.c (tgetent): Likewise.
14593 * xfns.c (x_default_font_parameter): Likewise.
14594 * xsettings.c (read_and_apply_settings): Likewise.
14595
e7974947
AS
14596 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14597 (overrun_check_free): Protoize.
14598
28272684
PE
145992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14600
14601 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14602 since callers should never pass a negative size.
14603 Change the signature to match that of plain 'read' and 'write'; see
14604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14605 * lisp.h: Update prototypes of emacs_write and emacs_read.
14606
11997c76
EZ
146072011-04-11 Eli Zaretskii <eliz@gnu.org>
14608
14609 * xdisp.c (redisplay_window): Don't try to determine the character
14610 position of the scroll margin if the window start point w->startp
e896f03c 14611 is outside the buffer's accessible region. (Bug#8468)
11997c76 14612
8a2cbd72
EZ
146132011-04-10 Eli Zaretskii <eliz@gnu.org>
14614
14615 Fix write-region and its subroutines for buffers > 2GB.
14616 * fileio.c (a_write, e_write): Modify declaration of arguments and
14617 local variables to support buffers larger than 2GB.
14618 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14619
14620 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14621 argument, local variables, and return value.
14622
14623 * lisp.h: Update prototypes of emacs_write and emacs_read.
14624
14625 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14626
4073e537 146272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14628
1ebfdcb6
PE
14629 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14630
b2ded58d
PE
14631 Fix more problems found by GCC 4.6.0's static checks.
14632
7d66342c
PE
14633 * xdisp.c (vmessage): Use a better test for character truncation.
14634
bbf47d44
PE
14635 * charset.c (load_charset_map): <, not <=, for optimization,
14636 and to avoid potential problems with integer overflow.
9248994d 14637 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14638 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14639 * editfns.c (Fformat): Likewise.
1e69125e 14640 * syntax.c (skip_chars): Likewise.
3befa583 14641
e3019616
PE
14642 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14643 This also lets GCC 4.6.0 generate slightly better loop code.
14644
becfa255
PE
14645 * callint.c (Fcall_interactively): <, not <=, for optimization.
14646 (Fcall_interactively): Count the number of arguments produced,
14647 not the number of arguments given. This is simpler and lets GCC
14648 4.6.0 generate slightly better code.
14649
dae0cd48
PE
14650 * ftfont.c: Distingish more carefully between FcChar8 and char.
14651 The previous code passed unsigned char * to a functions like
14652 strlen and xstrcasecmp that expect char *, which does not
14653 conform to the C standard.
14654 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14655 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14656 char * when the C standard requires it.
14657
76032d70
PE
14658 * keyboard.c (read_char): Remove unused var.
14659
eb3f1cc8
PE
14660 * eval.c: Port to Windows vsnprintf (Bug#8435).
14661 Include <limits.h>.
14662 (SIZE_MAX): Define if the headers do not.
14663 (verror): Do not give up if vsnprintf returns a negative count.
14664 Instead, grow the buffer. This ports to Windows vsnprintf, which
14665 does not conform to C99. Problem reported by Eli Zaretskii.
14666 Also, simplify the allocation scheme, by avoiding the need for
14667 calling realloc, and removing the ALLOCATED variable.
14668
70476b54
PE
14669 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14670
12020a9e
PE
14671 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14672 But keep the doprint source code for now, as we might revamp it
14673 and use it again (Bug#8435).
ea6c7ae6
PE
14674 * lisp.h (doprnt): Remove.
14675 * Makefile.in (base_obj): Remove doprnt.o.
14676 * deps.mk (doprnt.o): Remove.
14677
5fdb398c
PE
14678 error: Print 32- and 64-bit integers portably (Bug#8435).
14679 Without this change, on typical 64-bit hosts error ("...%d...", N)
14680 was used to print both 32- and 64-bit integers N, which relied on
14681 undefined behavior.
61bdb816 14682 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14683 * lisp.h (error, verror): Mark as printf-like functions.
14684 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14685 Report overflow in size calculations when allocating printf buffer.
14686 Do not truncate output string at its first null byte.
14687 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14688 Truncate the output at a character boundary, since vsnprintf does not
14689 do that.
14690 * charset.c (check_iso_charset_parameter): Convert internal
14691 character to string before calling 'error', since %c now has the
14692 printf meaning.
14693 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14694 overflow when computing char to be passed to 'error'. Do not
14695 pass Lisp_Object to 'error'; pass the integer instead.
14696 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14697 formatted with plain %d.
14698
b189fa66
PE
14699 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14700
bff87ef0
PE
14701 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14702
7e2cac20
PE
14703 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14704
ce4d90b5
PE
14705 * xterm.c (x_catch_errors): Remove duplicate declaration.
14706
266c9547
PE
14707 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14708
79c49ad2
PE
14709 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14710
368f4090
JM
147112011-04-10 Jim Meyering <meyering@redhat.com>
14712
14713 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14714 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14715 return ssize_t not "int", and use size_t as the buffer length.
14716 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14717 * gnutls.h: Update declarations.
14718 * process.c (read_process_output): Use ssize_t, to match.
14719 (send_process): Likewise.
14720
a32d4040
CY
147212011-04-09 Chong Yidong <cyd@stupidchicken.com>
14722
14723 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14724
8546720e 147252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14726
04f2d78b
CB
14727 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14728 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14729
8546720e
GM
14730 * xterm.c (handle_one_xevent):
14731 * xmenu.c (create_and_show_popup_menu):
14732 * xselect.c (x_decline_selection_request)
14733 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14734
0a2f5c1a 147352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14736
14737 Fix some uses of `int' instead of EMACS_INT.
14738 * search.c (string_match_1, fast_string_match)
14739 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14740 (scan_buffer, find_next_newline_no_quit)
14741 (find_before_next_newline, search_command, Freplace_match)
14742 (Fmatch_data): Make some `int' variables be EMACS_INT.
14743
14744 * xdisp.c (display_count_lines): 3rd argument and return value now
14745 EMACS_INT. All callers changed.
14746 (pint2hrstr): Last argument is now EMACS_INT.
14747
14748 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14749 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14750 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14751 (decode_coding_utf_16, decode_coding_emacs_mule)
14752 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14753 (decode_coding_ccl, decode_coding_charset)
14754 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14755 (decode_coding_iso_2022, decode_coding_emacs_mule)
14756 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14757 <char_offset, last_offset>: Declare EMACS_INT.
14758 (encode_coding_utf_8, encode_coding_utf_16)
14759 (encode_coding_emacs_mule, encode_invocation_designation)
14760 (encode_designation_at_bol, encode_coding_iso_2022)
14761 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14762 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14763 Declare EMACS_INT.
14764 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14765 (encode_invocation_designation): Last argument P_NCHARS is now
14766 EMACS_INT.
14767 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14768 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14769
14770 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14771 All users changed.
14772
14773 * ccl.c (Fccl_execute_on_string): Declare some variables
14774 EMACS_INT.
14775
8546720e 147762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14777
14778 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14779
4e19a977
CS
147802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14781
14782 * process.c (Fformat_network_address): Doc fix.
14783
87302331
R
147842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14785
ee7683eb 14786 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14787
cbb59342
CY
147882011-04-08 Chong Yidong <cyd@stupidchicken.com>
14789
14790 * keyboard.c (read_char): Call Lisp function help-form-show,
14791 instead of using internal_with_output_to_temp_buffer.
14792 (Qhelp_form_show): New var.
e0d38eeb 14793 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14794
14795 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14796
14797 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14798
e67a13ab
CY
147992011-04-06 Chong Yidong <cyd@stupidchicken.com>
14800
04f2d78b
CB
14801 * process.c (Flist_processes): Remove to Lisp.
14802 (list_processes_1): Delete.
e67a13ab 14803
973f782d
EZ
148042011-04-06 Eli Zaretskii <eliz@gnu.org>
14805
7c106b1e
EZ
14806 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14807
973f782d
EZ
14808 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14809
41cf7d1a 148102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14811
ca23cc88
PE
14812 Fix more problems found by GCC 4.6.0's static checks.
14813
f390e2d5
PE
14814 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14815
42eea0d0
PE
14816 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14817
b69769da 14818 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14819
f9541e84
PE
14820 * xdisp.c (vmessage): Mark as a printf-like function.
14821
13841b55
PE
14822 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14823
c136c10f
PE
14824 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14825
5e2d4a30
PE
14826 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14827 printf-like functions.
14828 (tiff_load): Add casts to remove these marks before passing them
14829 to system-supplied API.
14830
583f48b9
PE
14831 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14832
b25d760e
PE
14833 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14834 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14835 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14836 directly, rather than having caller test rule sign. This avoids
14837 some unnecessary tests.
14838 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14839 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14840 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14841
bc7b6697 14842 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14843 (xfont_open): Avoid unnecessary tests.
bc7b6697 14844
27ccc379
PE
14845 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14846
dcd5c89a
PE
14847 * composite.h, composite.c (composition_gstring_put_cache):
14848 Use EMACS_INT, not int, for length.
14849
b13a45c6
PE
14850 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14851 breaking out part of COMPOSITION_DECODE_RULE.
14852 (COMPOSITION_DECODE_RULE): Use it.
14853 * composite.c (get_composition_id): Remove unused local vars,
14854 by using the new macro.
14855
1e792e4d
PE
14856 * textprop.c (set_text_properties_1): Change while to do-while,
14857 since the condition is always true at first.
14858
dc6c6455 14859 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14860 (interval_deletion_adjustment): Return unsigned value.
14861 All uses changed.
dc6c6455 14862
aba7731a
PE
14863 * process.c (list_processes_1, create_pty, read_process_output):
14864 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14865 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14866 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14867 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14868 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14869
fdfc4bf3
PE
14870 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14871
fca8fe46 14872 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14873 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14874
06a0259a 14875 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14876 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14877 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14878
e7b9e80f
PE
14879 * print.c (print_error_message): Avoid int overflow.
14880
56201685
PE
14881 * font.c (font_list_entities): Redo for clarity,
14882 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14883
78834453 14884 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14885 (font_score): Avoid potential overflow in diff calculation.
78834453 14886
0bc0b309 14887 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14888 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14889
e610eaca
PE
14890 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14891
b895abce
PE
14892 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14893 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14894 can always succeed if overflow has undefined behavior.
14895
1f1d9321 14896 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14897 (wordify): Omit three unnecessary tests.
1f1d9321 14898
c59478bc
PE
14899 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14900 All callers changed. This avoids the need for an unused var.
14901
79b73827
PE
14902 * casefiddle.c (casify_region): Remove var that is set but not used.
14903
a4db5dfe
PE
14904 * dired.c (file_name_completion): Remove var that is set but not used.
14905
43aae36e
PE
14906 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14907
2a47c44d 14908 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14909 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14910
a37c69bf
PE
14911 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14912 Check for integer overflow on size calculations.
14913
328ab8e7
PE
14914 * buffer.c (Fprevious_overlay_change): Remove var that is set
14915 but not used.
14916
e5a2a5cb
PE
14917 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14918 Remove vars that are set but not used.
8d84a6eb 14919 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14920 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14921
a60e5f68
PE
14922 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14923
f661cb61 14924 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14925 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14926
f0397f5a
PE
14927 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14928 that are set but not used.
14929
8664db06 14930 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14931 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14932
6abdaa4a
PE
14933 * xselect.c (x_get_local_selection, x_handle_property_notify):
14934 Remove vars that are set but not used.
14935
0ce7538d 14936 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14937 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14938
9ae848fc
PE
14939 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14940 Remove var that is set but not used.
0b918413
PE
14941 (scroll_bar_windows_size): Now size_t, not int.
14942 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14943 Check for overflow.
9ae848fc 14944
a5a62657
PE
14945 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14946 (map_tty_color) [!defined MSDOS]: Likewise.
14947
5c5cdd39
PE
14948 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14949
66ebf983
PE
14950 * coding.c: Remove vars that are set but not used.
14951 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14952 All callers changed.
14953 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14954 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14955 (decode_coding_charset): Remove vars that are set but not used.
14956
1be4d761
PE
14957 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14958 that is set but not used.
14959
47553fa8
PE
14960 * print.c (print_object): Remove var that is set but not used.
14961
1f7196bf 14962 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14963 The gnulib version avoids calling malloc in the usual case,
14964 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14965 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14966 * filelock.c (current_lock_owner): Likewise.
14967 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14968 * sysdep.c: Include allocator.h, careadlinkat.h.
14969 (emacs_no_realloc_allocator): New static constant.
14970 (emacs_readlink): New function.
fdb61804
PE
14971 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14972 ../lib/careadlinkat.h.
d1fdcab7 14973
f84c17c7
SM
149742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14975
14976 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14977 first non-nil return value).
14978
ef3862ad
JD
149792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14980
14981 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14982 if not defined (Bug#8403).
14983
376a7006
JB
149842011-04-02 Juanma Barranquero <lekktu@gmail.com>
14985
14986 * xdisp.c (display_count_lines): Remove parameter `start',
14987 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14988 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14989 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14990 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14991 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14992 and thereabouts. All callers changed.
14993 (get_per_char_metric): Remove parameter `f', unused since
14994 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14995
6ca3801d
JM
149962011-04-02 Jim Meyering <meyering@redhat.com>
14997
14998 do not dereference NULL upon failed strdup
14999 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15000 (ns_get_family): Likewise.
15001
d8e2b5ba
JB
150022011-04-02 Juanma Barranquero <lekktu@gmail.com>
15003
15004 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15005
8c74fcbd
JD
150062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15007
15008 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15009 later (Bug#8403).
15010
7200d79c
SM
150112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15012
03408648 15013 Add lexical binding.
7200d79c 15014
03408648
SM
15015 * window.c (Ftemp_output_buffer_show): New fun.
15016 (Fsave_window_excursion):
15017 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15018
15019 * lread.c (lisp_file_lexically_bound_p): New function.
15020 (Fload): Bind Qlexical_binding.
15021 (readevalloop): Remove `evalfun' arg.
15022 Bind Qinternal_interpreter_environment.
15023 (Feval_buffer): Bind Qlexical_binding.
15024 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15025 Mark as dynamic.
15026 (syms_of_lread): Declare `lexical-binding'.
15027
15028 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15029
15030 * keyboard.c (eval_dyn): New fun.
15031 (menu_item_eval_property): Use it.
ca105506
SM
15032
15033 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15034
03408648
SM
15035 * fns.c (concat, mapcar1): Accept byte-code-functions.
15036
15037 * eval.c (Fsetq): Handle lexical vars.
15038 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15039 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15040 (FletX, Flet): Obey lexical binding.
15041 (Fcommandp): Handle closures.
15042 (Feval): New `lexical' arg.
15043 (eval_sub): New function extracted from Feval. Use it almost
15044 everywhere where Feval was used. Look up vars in lexical env.
15045 Handle closures.
15046 (Ffunctionp): Move from subr.el.
15047 (Ffuncall): Handle closures.
15048 (apply_lambda): Remove `eval_flags'.
15049 (funcall_lambda): Handle closures and new byte-code-functions.
15050 (Fspecial_variable_p): New function.
15051 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15052 but without exporting it to Lisp.
23aba0ea 15053
23aba0ea 15054 * doc.c (Fdocumentation, store_function_docstring):
03408648 15055 * data.c (Finteractive_form): Handle closures.
23aba0ea 15056
03408648
SM
15057 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15058 interactive spec.
ba83908c 15059
04f2d78b
CB
15060 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15061 New byte-codes.
03408648
SM
15062 (exec_byte_code): New function extracted from Fbyte_code to handle new
15063 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15064
03408648 15065 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15066
03408648 15067 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15068
e2abce01
JB
150692011-03-31 Juanma Barranquero <lekktu@gmail.com>
15070
15071 * xdisp.c (redisplay_internal): Fix prototype.
15072
63696a73 150732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15074
63696a73 15075 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15076 (try_scrolling): Use it when setting scroll_limit.
15077 Limit scrolling to 100 screen lines.
63696a73
EZ
15078 (redisplay_window): Even when falling back on "recentering",
15079 position point in the window according to scroll-conservatively,
15080 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15081
15082 (try_scrolling): When point is above the window, allow searching
15083 as far as scroll_max, or one screenful, to compute vertical
15084 distance from PT to the scroll margin position. This prevents
15085 try_scrolling from unnecessarily failing when
15086 scroll-conservatively is set to a value slightly larger than the
15087 window height. Clean up the case of PT below the margin at bottom
15088 of window: scroll_max can no longer be INT_MAX. When aggressive
15089 scrolling is in use, don't let point enter the opposite scroll
15090 margin as result of the scroll.
15091 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15092 threshold of 100 lines for never-recentering scrolling.
15093
e4cc2dfc
JB
150942011-03-31 Juanma Barranquero <lekktu@gmail.com>
15095
15096 * dispextern.h (move_it_by_lines):
15097 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15098 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15099 (message_log_check_duplicate): Remove parameters `prev_bol' and
15100 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15101 (redisplay_internal): Remove parameter `preserve_echo_area',
15102 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15103
15104 * indent.c (Fvertical_motion):
15105 * window.c (window_scroll_pixel_based, Frecenter):
15106 Don't pass `need_y_p' to `move_it_by_lines'.
15107
1c470562
SM
151082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15109
44f230aa
SM
15110 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15111 steal a few bits to be more compact.
15112 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15113 Remove unneeded casts.
15114
1c470562
SM
15115 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15116
888adce9
ZK
151172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15118
15119 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15120 binding" message (bug#7967).
15121
f838ed7b
PE
151222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
15123
77861b95
PE
15124 Fix more problems found by GCC 4.6.0's static checks.
15125
de6dbc14
PE
15126 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15127 Remove unused local var.
15128
f838ed7b
PE
15129 * editfns.c (Fmessage_box): Remove unused local var.
15130
792c7b2b
PE
15131 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15132 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15133 Omit unused local vars.
c499e557 15134 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15135 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15136 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15137 Omit unused local var.
15138
ba0165e1
PE
15139 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15140 Don't assume string length fits in int.
32ad8845 15141 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15142 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15143
3c59b4c9
PE
15144 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15145 instead of alloca (Bug#8344).
15146
a3eed478 15147 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15148 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15149
eb4d412d
PE
15150 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15151
1658b401
PE
15152 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15153 concerns.
15154
15155 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15156
15157 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15158
9a2c6e05
PE
15159 * keyboard.c (syms_of_keyboard): Use the same style as later
15160 in this function when indexing through an array. This also
15161 works around GCC bug 48267.
15162
03d0a109
PE
15163 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15164
44f730c8
PE
15165 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15166
fe75f926
PE
15167 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15168 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15169
ffa8c828
PE
15170 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15171 This avoids undefined behavior on integer overflow, and is a bit
15172 more convenient anyway since it is compared to a size_t variable.
15173
c5101a77
PE
15174 Variadic C functions now count arguments with size_t, not int.
15175 This avoids an unnecessary limitation on 64-bit machines, which
15176 caused (substring ...) to crash on large vectors (Bug#8344).
15177 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15178 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15179 All variadic functions and their callers changed accordingly.
c5101a77
PE
15180 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15181 * data.c (arith_driver, float_arith_driver): Likewise.
15182 * editfns.c (general_insert_function): Likewise.
15183 * eval.c (struct backtrace.nargs, interactive_p)
15184 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15185 (funcall_lambda, mark_backtrace): Likewise.
15186 * fns.c (concat): Likewise.
15187 * frame.c (x_set_frame_parameters): Likewise.
15188 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15189 0 if not found, not -1. All callers changed.
15190
dd3f25f7
PE
15191 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15192 (stack_copy_size): Now size_t, not int.
15193 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15194
461c2ab9
JB
151952011-03-28 Juanma Barranquero <lekktu@gmail.com>
15196
15197 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15198 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15199 All callers changed.
15200
15201 * lisp.h (multibyte_char_to_unibyte):
15202 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15203 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15204 * character.h (CHAR_TO_BYTE8):
15205 * cmds.c (internal_self_insert):
15206 * editfns.c (general_insert_function):
15207 * keymap.c (push_key_description):
15208 * search.c (Freplace_match):
15209 * xdisp.c (message_dolog, set_message_1): All callers changed.
15210
f6d62986
SM
152112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15212
15213 * keyboard.c (safe_run_hook_funcall): New function.
15214 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
15215 don't set the hook to nil, but remove the offending function instead.
15216 (Qcommand_hook_internal): Remove, unused.
15217 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
15218 Vcommand_hook_internal.
15219
15220 * eval.c (enum run_hooks_condition): Remove.
15221 (funcall_nil, funcall_not): New functions.
15222 (run_hook_with_args): Call each function through a `funcall' argument.
15223 Remove `cond' argument, now redundant.
15224 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
15225 (Frun_hook_with_args_until_failure): Adjust accordingly.
15226 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
15227
1db5b1ad
JB
152282011-03-28 Juanma Barranquero <lekktu@gmail.com>
15229
15230 * dispextern.h (string_buffer_position): Remove declaration.
15231
15232 * print.c (strout): Remove parameter `multibyte', unused since
15233 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
15234
15235 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
15236 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
15237 All callers changed.
15238
15239 * w32.c (_wsa_errlist): Use braces for struct initializers.
15240
15241 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
15242 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
15243 All callers changed.
15244 (string_buffer_position): Likewise. Also, make static (it's never
15245 used outside xdisp.c).
15246 (cursor_row_p): Remove parameter `w', unused since
15247 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
15248 (decode_mode_spec): Remove parameter `precision', introduced during
15249 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
15250 All callers changed.
15251
5ffb62aa
JD
152522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15253
15254 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
15255
461c2ab9 152562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
15257
15258 * nsterm.m (ns_menu_bar_is_hidden): New variable.
15259 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
15260 (ns_update_auto_hide_menu_bar): New functions.
15261 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
15262 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
15263 ns_constrain_all_frames.
15264 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
15265 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
15266
5c380ffb
JD
152672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15268
15269 * nsmenu.m (runDialogAt): Remove argument to timer_check.
15270
9af30bdf
GM
152712011-03-27 Glenn Morris <rgm@gnu.org>
15272
15273 * syssignal.h: Replace RETSIGTYPE with void.
15274 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
15275 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
15276 Replace SIGTYPE with void everywhere.
15277 * s/usg5-4-common.h (SIGTYPE): Remove definition.
15278 * s/template.h (SIGTYPE): Remove commented out definition.
15279
e2abce01
JB
152802011-03-26 Eli Zaretskii <eliz@gnu.org>
15281
15282 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
15283 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
15284
f868cd8a
JB
152852011-03-26 Juanma Barranquero <lekktu@gmail.com>
15286
59eb0929
JB
15287 * w32.c (read_unc_volume): Use parameter `henum', instead of
15288 global variable `wget_enum_handle'.
15289
15290 * keymap.c (describe_vector): Remove parameters `indices' and
15291 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
15292 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
15293
f868cd8a
JB
15294 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
15295
15296 * keyboard.c (timer_check): Remove parameter `do_it_now',
15297 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
15298 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
15299 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
15300
15301 * keyboard.c (read_char):
15302 * w32menu.c (w32_menu_display_help):
15303 * xmenu.c (show_help_event, menu_help_callback):
15304 Adjust calls to `show_help_echo'.
15305
15306 * gtkutil.c (xg_maybe_add_timer):
15307 * keyboard.c (readable_events):
15308 * process.c (wait_reading_process_output):
15309 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
15310
15311 * insdel.c (adjust_markers_gap_motion):
15312 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
15313 (gap_left, gap_right): Don't call it.
15314
2ecf6fdb
CY
153152011-03-25 Chong Yidong <cyd@stupidchicken.com>
15316
15317 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
15318 incurred during fontification.
15319
6b1f9ba4
JB
153202011-03-25 Juanma Barranquero <lekktu@gmail.com>
15321
15322 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
15323 (DEFVAR_PER_BUFFER): Don't pass it.
15324
15325 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
15326 (scrolling_window): Don't pass it.
15327
0f4a96b5
JB
153282011-03-25 Juanma Barranquero <lekktu@gmail.com>
15329
15330 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
15331
15332 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
15333 and `suffix'.
15334 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
15335 of variables specific to SELinux and computation of `encoded_absname'.
15336
15337 * image.c (XPutPixel): Remove unused variable `height'.
15338
15339 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
15340
15341 * unexw32.c (get_section_info): Remove unused variable `section'.
15342
15343 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
15344 (system_process_attributes): Remove unused variable `sess'.
15345 (sys_read): Remove unused variable `err'.
15346
15347 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
15348 (w32_wnd_proc): Remove unused variable `isdead'.
15349 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
15350 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
15351 (x_create_tip_frame): Remove unused variable `tem'.
15352
15353 * w32inevt.c (w32_console_read_socket):
15354 Remove unused variable `no_events'.
15355
15356 * w32term.c (x_draw_composite_glyph_string_foreground):
15357 Remove unused variable `width'.
15358
1149507c
JB
153592011-03-24 Juanma Barranquero <lekktu@gmail.com>
15360
15361 * w32term.c (x_set_glyph_string_clipping):
15362 Don't pass uninitialized region to CombineRgn.
15363
9c88f339
JB
153642011-03-23 Juanma Barranquero <lekktu@gmail.com>
15365
15366 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
15367 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
15368 (Fx_close_connection): Remove unused variable `i'.
15369
15370 * w32font.c (w32font_draw): Return number of glyphs.
15371 (w32font_open_internal): Remove unused variable `i'.
15372 (w32font_driver): Add missing initializer.
15373
15374 * w32menu.c (utf8to16): Remove unused variable `utf16'.
15375 (fill_in_menu): Remove unused variable `items_added'.
15376
15377 * w32term.c (last_mouse_press_frame): Remove static global variable.
15378 (w32_clip_to_row): Remove unused variable `f'.
15379 (x_delete_terminal): Remove unused variable `i'.
15380
15381 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
15382 (NOTHING): Remove unused static global variable.
15383 (uniscribe_check_otf): Remove unused variable `table'.
15384 (uniscribe_font_driver): Add missing initializers.
15385
dee091a3
JD
153862011-03-23 Julien Danjou <julien@danjou.info>
15387
15388 * term.c (Fsuspend_tty, Fresume_tty):
15389 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
15390 * window.c (temp_output_buffer_show):
15391 * insdel.c (signal_before_change):
15392 * frame.c (Fhandle_switch_frame):
15393 * fileio.c (Fdo_auto_save):
15394 * emacs.c (Fkill_emacs):
15395 * editfns.c (save_excursion_restore):
15396 * cmds.c (internal_self_insert):
15397 * callint.c (Fcall_interactively):
15398 * buffer.c (Fkill_all_local_variables):
15399 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
15400 Use Frun_hooks.
0f4a96b5 15401 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 15402 unconditionally since it does the check itself.
dee091a3 15403
2c520ab5 154042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 15405
c9c49752
PE
15406 Fix more problems found by GCC 4.5.2's static checks.
15407
8abc3f12
PE
15408 * coding.c (encode_coding_raw_text): Avoid unnecessary test
15409 the first time through the loop, since we know p0 < p1 then.
15410 This also avoids a gcc -Wstrict-overflow warning.
15411
a2d26660
PE
15412 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
15413 leading to a memory leak, possible in functions like
15414 load_charset_map_from_file that can allocate an unbounded number
b12ef411 15415 of objects (Bug#8318).
a2d26660 15416
916c72e9
PE
15417 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
15418 that could (at least in theory) be that large.
15419
19ab8a18
PE
15420 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
15421 This is less likely to overflow, and avoids undefined behavior if
15422 overflow does occur. All callers changed. Use strtoul to scan
15423 for the unsigned long integer.
b7cbbd6f
PE
15424 (pint2hrstr): Simplify and tune code slightly.
15425 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 15426
f0641eff
PE
15427 * scroll.c (do_scrolling): Work around GCC bug 48228.
15428 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
15429
7f650bb9
PE
15430 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
15431 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
15432 (validate_x_resource_name): Simplify count usage.
15433 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 15434
37dd57d1
PE
15435 * fileio.c (Fcopy_file): Report error if fchown or fchmod
15436 fail (Bug#8306).
81e56e61 15437
699979fc 15438 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 15439
401bf9b4
PE
15440 * process.c (Fmake_network_process): Use socklen_t, not int,
15441 where POSIX says socklen_t is required in portable programs.
15442 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 15443 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
15444 (Fmake_network_process, server_accept_connection):
15445 (wait_reading_process_output, read_process_output):
15446 Likewise.
15447
b93aacde
PE
15448 * process.c: Rename or move locals to avoid shadowing.
15449 (list_processes_1, Fmake_network_process):
15450 (read_process_output_error_handler, exec_sentinel_error_handler):
15451 Rename or move locals.
4dc343ee 15452 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 15453 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 15454 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 15455 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 15456 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 15457
af8a867c 15458 Make tparam.h and terminfo.c consistent.
44f230aa
SM
15459 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
15460 Include tparam.h instead, since it declares them.
af8a867c
PE
15461 * cm.h (PC): Remove extern decl; tparam.h now does this.
15462 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
15463 * terminfo.c: Include tparam.h, to check interfaces.
15464 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
15465 (tparam): Adjust signature to match interface in tparam.h;
15466 this removes some undefined behavior. Check that outstring and len
15467 are zero, which they always are with Emacs.
15468 * tparam.h (PC, BC, UP): New extern decls.
15469
0248044d 15470 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 15471 (xftfont_open): Rename locals to avoid shadowing.
0248044d 15472
8ff096c1 15473 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
15474 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
15475 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 15476 (ftfont_list): Remove unused local.
49eaafba
PE
15477 (get_adstyle_property, ftfont_pattern_entity):
15478 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
15479 Rename locals to avoid shadowing.
8ff096c1 15480
e2be39f6
PE
15481 * xfont.c (xfont_list_family): Mark var as initialized.
15482
c9735e30
PE
15483 * xml.c (make_dom): Now static.
15484
8f5201ae
PE
15485 * composite.c (composition_compute_stop_pos): Rename local to
15486 avoid shadowing.
b246f932
PE
15487 (composition_reseat_it): Remove unused locals.
15488 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 15489 (composition_update_it): Mark var as initialized.
11b61122
PE
15490 (find_automatic_composition): Mark vars as initialized,
15491 with a FIXME (Bug#8290).
8f5201ae 15492
760fbc2c
PE
15493 character.h: Rename locals to avoid shadowing.
15494 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15495 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15496 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15497 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15498 to avoid shadowing.
15499
ff08eb85
PE
15500 * textprop.c (property_change_between_p): Remove; unused.
15501
fc7bf025
PE
15502 * intervals.c (interval_start_pos): Now static.
15503
235d7abc
PE
15504 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15505
44f230aa
SM
15506 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15507 Rename locals to avoid shadowing.
3e7d6594 15508
50060332
PE
15509 * sound.c (wav_play, au_play, Fplay_sound_internal):
15510 Fix pointer signedness.
d01f234b 15511 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15512 (wav_play): Initialize a variable to 0, to prevent undefined
15513 behavior (Bug#8278).
50060332 15514
c4fc4e30
PE
15515 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15516
918436ed
PE
15517 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15518
c939f91b
PE
15519 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15520 clobbering (Bug#8298).
b9c7f648
PE
15521 * sysdep.c (sys_subshell): Likewise.
15522 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15523
6bd8c144
PE
15524 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15525 This should get cleaned up, so that child_setup has the
15526 same signature on all platforms.
15527
7710357c 15528 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15529 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15530
c59da222
CY
155312011-03-22 Chong Yidong <cyd@stupidchicken.com>
15532
15533 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15534 not to be necessary, and produces flickering.
15535
66b87493
GM
155362011-03-20 Glenn Morris <rgm@gnu.org>
15537
15538 * config.in: Remove file.
15539
45b6f6d5
JB
155402011-03-20 Juanma Barranquero <lekktu@gmail.com>
15541
15542 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15543 are now in src/globals.h.
15544 (syms_of_minibuf): Remove spurious & from previous change.
15545
cd394be1 155462011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15547
15548 * minibuf.c (completing-read-function): New variable.
15549 (completing-read-default): Rename from completing-read.
15550 (completing-read): Call completing-read-function.
15551
b14e3e21
CY
155522011-03-19 Juanma Barranquero <lekktu@gmail.com>
15553
15554 * xfaces.c (Fx_load_color_file):
15555 Read color file from absolute filename (bug#8250).
15556
f2b726e6
JB
155572011-03-19 Juanma Barranquero <lekktu@gmail.com>
15558
15559 * makefile.w32-in: Update dependencies.
15560
09f6ff02
EZ
155612011-03-17 Eli Zaretskii <eliz@gnu.org>
15562
15563 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15564
29a6015a
PE
155652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15566
a3a6c54e
PE
15567 Fix more problems found by GCC 4.5.2's static checks.
15568
b766f867
PE
15569 * process.c (make_serial_process_unwind, send_process_trap):
15570 (sigchld_handler): Now static.
15571
be02381c
PE
15572 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15573 That way, the code declares only the vars that it needs.
15574 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15575 * s/cygwin.h (PTY_ITERATION): Likewise.
15576 * s/darwin.h (PTY_ITERATION): Likewise.
15577 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15578
57048744
PE
15579 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15580 * process.c (allocate_pty): Don't declare stb unless it's needed.
15581
7914961c 15582 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15583 (CONSTANTLIM): Remove; unused.
15584 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15585 Define only if needed.
7914961c 15586
b3967b18
PE
15587 * unexelf.c (unexec): Name an expression,
15588 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15589 Use a different way to cause a compilation error if anyone uses
15590 n rather than nn, a way that does not involve shadowing.
73366a00 15591 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15592
29a6015a
PE
15593 * deps.mk (unexalpha.o): Remove; unused.
15594
43cfc33e 15595 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15596 * unexec.h: New file.
ce701a33
PE
15597 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15598 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15599 Depend on unexec.h.
15600 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15601 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15602 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15603 Change as necessary to match prototype in unexec.h.
ce701a33 15604
01f44d5a
PE
15605 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15606 shadowing.
4f63c6bb 15607 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15608
a6670b0b
PE
15609 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15610 Rename locals to avoid shadowing.
15611
cef2010d 15612 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15613 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15614
d4d7173a
PE
15615 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15616
f08b802a
PE
15617 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15618 warning when compiling print.c.
15619
3ddb0639
PE
15620 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15621 instead of using an uninitialized var.
5ad03b97 15622 (font_sort_entities): Mark var as initialized.
3ddb0639 15623
170a2692
PE
15624 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15625
e663c700
PE
15626 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15627 pointers to constants.
89bc529a 15628 (font_parse_fcname): Remove unused vars.
7b81e2d0 15629 (font_delete_unmatched): Now static.
ea838e10 15630 (font_get_spec): Remove; unused.
13a547c6
PE
15631 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15632 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15633 Rename or move locals to avoid shadowing.
e663c700 15634
2a80c887 15635 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15636 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15637
1384fa33 15638 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15639 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15640
8b2c52e9
PE
15641 * alloc.c (mark_backtrace): Move decl from here ...
15642 * lisp.h: ... to here, so that it can be checked.
15643
475545b5 15644 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15645 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15646 (lisp_indirect_variable): Name an expression,
15647 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15648 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15649
b1349114 15650 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15651 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15652 Use const pointer when appropriate.
b1349114 15653
a2928364
PE
15654 * lisp.h (get_system_name, get_operating_system_release):
15655 Move decls here, to check interfaces.
15656 * process.c (get_operating_system_release): Move decl to lisp.h.
15657 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15658 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15659 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15660 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15661 (Fformat_time_string, Fencode_time, Finsert_char):
15662 (Ftranslate_region_internal, Fformat):
15663 Rename or remove local vars to avoid shadowing.
9710023e 15664 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15665
a415e694
PE
15666 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15667 avoid shadowing.
15668
8ef4622d
PE
15669 * lisp.h (eassert): Check that the argument compiles, even if
15670 ENABLE_CHECKING is not defined.
15671
946f9a5b
PE
15672 * data.c (Findirect_variable): Name an expression, to avoid
15673 gcc -Wbad-function-cast warning.
112396d6 15674 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15675 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15676 (Fmake_variable_buffer_local, Fmake_local_variable):
15677 Mark variables as initialized.
52746918 15678 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15679
e5aab7e7 15680 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15681 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15682 Rename locals to avoid shadowing.
dff45157
PE
15683 (mark_stack): Move local variables into the #ifdef region where
15684 they're used.
7bc26fdb
PE
15685 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15686 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15687 needed otherwise.
15688 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15689 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15690 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15691
e5aab7e7
PE
15692 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15693 avoids undefined behavior in theory.
15694
4da60324
PE
15695 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15696
88043301
PE
15697 Use functions, not macros, for up- and down-casing (Bug#8254).
15698 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15699 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15700 to use the following functions instead of these macros.
15701 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15702 EMACS_INT, since callers assume the returned value fits in int.
15703 (upcase1): Likewise, for UPCASE_TABLE.
15704 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15705 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15706 the race-condition problem in the old DOWNCASE.
88043301 15707
19ed5445
PE
15708 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15709 Rename locals to avoid shadowing.
15710 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15711 (regex_compile, re_search_2, re_match_2_internal):
15712 Remove unused local vars.
952db0d7
PE
15713 (FREE_VAR): Rewrite so as not to use empty "else",
15714 which gcc can warn about.
da053e48 15715 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15716 (RETALLOC_IF): Define only if needed.
15717 (WORDCHAR_P): Likewise. This one is never needed, but is used
15718 only in a comment talking about a compiler bug, so put inside
15719 the #if 0 of that comment.
15720 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15721 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15722 Remove; unused.
19ed5445 15723
1f3561e4 15724 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15725 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15726 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15727
ded6f8f7
PE
15728 * search.c (simple_search): Remove unused var.
15729
dbd37a95
PE
15730 * dired.c (compile_pattern): Move decl from here ...
15731 * lisp.h: ... to here, so that it can be checked.
15732 (struct re_registers): New forward decl.
15733
7e47afad
PE
15734 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15735
85f24f61
PE
15736 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15737 All uses changed.
15738 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15739 Rename locals to avoid shadowing.
5671df8f 15740 (Fvertical_motion): Mark locals as initialized.
85f24f61 15741
181aa2be 15742 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15743 (casify_region): Mark local as initialized.
181aa2be 15744
930d429c
PE
15745 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15746
7082eac6
PE
15747 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15748 New macros, so that the caller can use some names other than
15749 gcpro1, gcpro2, etc.
15750 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15751 of the new macros.
15752 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15753 argument, for consistency with GCPRO2_VAR, etc: it is now the
15754 prefix of the variable, not the variable itself. All uses
15755 changed.
38b2c076
PE
15756 * dired.c (directory_files_internal, file_name_completion):
15757 Rename locals to avoid shadowing.
15758
15206ed9
PE
15759 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15760 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15761 dired.c's scmp function, had undefined behavior.
15762 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15763 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15764 * buffer.h: ... to here, because these macros use current_buffer,
15765 and the new implementation with inline functions needs to have
15766 current_buffer in scope now, rather than later when the macros
15767 are used.
15768 (downcase, upcase1): New static inline functions.
15769 (DOWNCASE, UPCASE1): Reimplement using these functions.
15770 This avoids undefined behavior in expressions like
15771 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15772 from race conditions in accessing the global variables
15773 case_temp1 and case_temp2.
15774 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15775 * lisp.h (case_temp1, case_temp2): Remove their decls.
15776 * character.h (ASCII_CHAR_P): Move from here ...
15777 * lisp.h: ... to here, so that the inline functions mentioned
15778 above can use them.
15779
4a6bea26
PE
15780 * dired.c (directory_files_internal_unwind): Now static.
15781
f14b7e14
PE
15782 * fileio.c (file_name_as_directory, directory_file_name):
15783 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15784 Now static.
2893f146
PE
15785 (file_name_as_directory): Use const pointers when appropriate.
15786 (Fexpand_file_name): Likewise. In particular, newdir might
15787 point at constant storage, so make it a const pointer.
fd4ead52 15788 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15789 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15790 signedness issues.
f839df0c
PE
15791 (Fset_file_times, Finsert_file_contents, auto_save_error):
15792 Rename locals to avoid shadowing.
f14b7e14 15793
5716756e 15794 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15795 (Ftry_completion, Fall_completions): Rename or remove locals
15796 to avoid shadowing.
5716756e 15797
b4c3046a
PE
15798 * marker.c (bytepos_to_charpos): Remove; unused.
15799
b45db522
PE
15800 * lisp.h (verify_bytepos, count_markers): New decls,
15801 so that gcc does not warn that these functions aren't declared.
15802
85876d07
PE
15803 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15804 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15805 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15806 (copy_text): Remove unused local var.
85876d07 15807
03d78a21 15808 * filelock.c (within_one_second): Now static.
b3dd38ab 15809 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15810
5df8f01b
PE
15811 * buffer.c (fix_overlays_before): Mark locals as initialized.
15812 (fix_start_end_in_overlays): Likewise. This function should be
15813 simplified by using pointers-to-pointers, but that's a different
15814 matter.
b1d876f1 15815 (switch_to_buffer_1): Now static.
8f54f30a
PE
15816 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15817 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15818
a70072c9 15819 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15820 Fix pointer signedness issue.
edced198
PE
15821 (sys_subshell): Mark local as volatile if checking for lint,
15822 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15823 (MAXPATHLEN): Define only if needed.
a70072c9 15824
a0977c44
PE
15825 * process.c (serial_open, serial_configure): Move decls from here ...
15826 * systty.h: ... to here, so that they can be checked.
15827
a884fdcc
PE
15828 * fns.c (get_random, seed_random): Move extern decls from here ...
15829 * lisp.h: ... to here, so that they can be checked.
15830
604efe86 15831 * sysdep.c (reset_io): Now static.
b8950c94 15832 (wait_for_termination_signal): Remove; unused.
604efe86 15833
38fc62d9
PE
15834 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15835 (copy_keymap_item, append_key, push_text_char_description):
15836 Now static.
1004a21a 15837 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15838 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15839 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15840 (describe_map_tree):
15841 Rename locals to avoid shadowing.
38fc62d9 15842
2f2650da
PE
15843 * keyboard.c: Declare functions static if they are not used elsewhere.
15844 (echo_char, echo_dash, cmd_error, top_level_2):
15845 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15846 (read_char, kbd_buffer_get_event, make_lispy_position):
15847 (make_lispy_event, make_lispy_movement, apply_modifiers):
15848 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15849 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15850 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15851 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15852 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15853
a053e86c 15854 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15855 (mark_kboards): Move decl here ...
15856 * alloc.c (mark_kboards): ... from here.
a053e86c 15857
4752793e
PE
15858 * lisp.h (force_auto_save_soon): New decl.
15859
74f10ca7 15860 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15861 (DEFINE_DUMMY_FUNCTION): New macro.
15862 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15863 Use it.
c03cd23f
PE
15864 (main): Add casts to avoid warnings
15865 if GCC considers string literals to be constants.
74f10ca7 15866
022e70d4
PE
15867 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15868
59d6fe83
PE
15869 * dbusbind.c: Pointer signedness fixes.
15870 (xd_signature, xd_append_arg, xd_initialize):
15871 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15872 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15873 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15874 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15875
78320123
PE
15876 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15877 if GCC considers string literals to be constants.
49cebcca 15878 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15879
35ac2a97
SM
158802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15881
fb103ca9
SM
15882 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15883 (print_preprocess, print_object): New macro to fix last change.
15884
35ac2a97
SM
15885 * print.c (print_preprocess): Don't forget font objects.
15886
62973b41
JB
158872011-03-16 Juanma Barranquero <lekktu@gmail.com>
15888
15889 * emacs.c (USAGE3): Doc fixes.
15890
0e48bb22
AS
158912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15892
15893 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15894 structure.
15895
7684e57b
JB
158962011-03-14 Juanma Barranquero <lekktu@gmail.com>
15897
15898 * lisp.h (VWindow_system, Qfile_name_history):
15899 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15900 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15901 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15902
15903 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15904 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15905
15906 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15907 * w32console.c (detect_input_pending, read_input_pending)
15908 (encode_terminal_code):
15909 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15910 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15911 (w32_system_caret_y, Qfile_name_history):
15912 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15913 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15914 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15915 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15916 * w32proc.c (Qlocal, report_file_error):
15917 * w32term.c (Vwindow_system, updating_frame):
15918 * w32uniscribe.c (initialized, uniscribe_font_driver):
15919 Remove unneeded extern declarations.
15920
2aa46d6c
CY
159212011-03-14 Chong Yidong <cyd@stupidchicken.com>
15922
c96bbc66 15923 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15924
cffc6f3b
CY
159252011-03-13 Chong Yidong <cyd@stupidchicken.com>
15926
15927 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15928 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15929 These macros can no longer be used for assignment.
15930
44f230aa
SM
15931 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15932 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15933 (record_buffer_markers, fetch_buffer_markers): New functions for
15934 recording and fetching special buffer markers.
15935 (set_buffer_internal_1, set_buffer_temp): Use them.
15936
15937 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15938
15939 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15940
15941 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15942 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15943
15944 * xdisp.c (hscroll_window_tree):
15945 (reconsider_clip_changes): Use PT instead of BUF_PT.
15946
d251f04b
EZ
159472011-03-13 Eli Zaretskii <eliz@gnu.org>
15948
15949 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15950 $(EMACS_ROOT)/lib/intprops.h.
15951
f0c77cd1
PE
159522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15953
3eca4629
PE
15954 Fix more problems found by GCC 4.5.2's static checks.
15955
7c86ee98
PE
15956 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15957 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15958 (xg_free_frame_widgets): Make it clear that a local variable is
15959 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15960 (gdk_window_get_screen): Make it clear that this macro is needed
15961 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15962 (int_gtk_range_get_value): New function, which avoids a diagnostic
15963 from gcc -Wbad-function-cast.
15964 (xg_set_toolkit_scroll_bar_thumb): Use it.
15965 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15966 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15967 (get_utf8_string, xg_get_file_with_chooser):
15968 Rename locals to avoid shadowing.
15969 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15970
41729b81
PE
15971 * xgselect.c (xg_select): Remove unused var.
15972
f0c77cd1
PE
15973 * image.c (four_corners_best): Mark locals as initialized.
15974 (gif_load): Initialize transparent_p to zero (Bug#8238).
15975 Mark another local as initialized.
ec6cf4c6 15976 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15977
ce0ad53d 15978 * image.c (clear_image_cache): Now static.
d5d5a617 15979 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15980 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15981 (x_edge_detection): Remove unnecessary cast that
15982 gcc -Wbad-function-cast diagnoses.
2037898d 15983 (gif_load): Fix pointer signedness.
6ae141d6
PE
15984 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15985 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15986
33383987 159872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15988
d32df629
PE
15989 Improve quality of tests for time stamp overflow.
15990 For example, without this patch (encode-time 0 0 0 1 1
15991 1152921504606846976) returns the obviously-bogus value (-948597
15992 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15993 reports time overflow. See
15994 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15995 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15996 * editfns.c: Include limits.h and intprops.h.
15997 (TIME_T_MIN, TIME_T_MAX): New macros.
15998 (time_overflow): Move earlier, to before first use.
15999 (hi_time, lo_time): New functions, for an accurate test for
16000 out-of-range times.
16001 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16002 (Fget_internal_run_time): Don't assume time_t fits in int.
16003 (make_time): Use list2 instead of Fcons twice.
16004 (Fdecode_time): More accurate test for out-of-range times.
16005 (check_tm_member): New function.
16006 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16007 (lisp_time_argument): Don't rely on undefined left-shift and
16008 right-shift behavior when checking for time stamp overflow.
8be6f318 16009
fe31d94c
PE
16010 * editfns.c (time_overflow): New function, refactoring common code.
16011 (Fformat_time_string, Fdecode_time, Fencode_time):
16012 (Fcurrent_time_string): Use it.
16013
8be6f318
PE
16014 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16015 * dired.c (make_time): Move to ...
16016 * editfns.c (make_time): ... here.
16017 * systime.h: Note the move.
16018
09d9db2c 160192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16020
126bc0dc
YM
16021 * fringe.c (update_window_fringes): Remove unused variables.
16022
c47cbdfd
YM
16023 * unexmacosx.c (copy_data_segment): Also copy __got section.
16024 (Bug#8223)
16025
7ac80be9
EZ
160262011-03-12 Eli Zaretskii <eliz@gnu.org>
16027
c96bbc66 16028 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16029 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16030 Constify `char *' arguments and their references according to
16031 prototypes in tparam.h.
16032
ecb0f94d 16033 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16034
7ac80be9
EZ
16035 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16036 Adapt all references accordingly.
16037
16038 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16039
ef1fd07e
TT
160402011-03-11 Tom Tromey <tromey@redhat.com>
16041
16042 * buffer.c (syms_of_buffer): Remove obsolete comment.
16043
7ef4b50c
EZ
160442011-03-11 Eli Zaretskii <eliz@gnu.org>
16045
16046 * termhooks.h (encode_terminal_code): Declare prototype.
16047
16048 * msdos.c (encode_terminal_code): Don't declare prototype.
16049
16050 * term.c (encode_terminal_code): Now external again, used by
16051 w32console.c and msdos.c.
16052
44f230aa
SM
16053 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16054 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16055
4b1ec863 160562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16057
1714f52b 16058 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16059
4b1ec863
PE
16060 * fringe.c (update_window_fringes): Mark locals as initialized
16061 (Bug#8227).
16062 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16063
524c7aa6
PE
16064 * alloc.c (mark_fringe_data): Move decl from here ...
16065 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16066 to check its interface.
16067 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16068
a5c0af81 16069 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16070 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16071 (fontset_font): Mark local as initialized.
a9a06e0b 16072 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16073
b4716021
PE
16074 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16075
811e9bac 16076 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16077 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16078 (x_own_selection, Fx_disown_selection_internal): Rename locals
16079 to avoid shadowing.
16080 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16081
7e3ab302
PE
16082 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16083 so that the caller can use some name other than gcpro1.
16084 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16085 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16086 (Fx_backspace_delete_keys_p):
16087 Use them to avoid shadowing, and rename vars to avoid shadowing.
16088 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16089 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16090 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16091 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16092 Remove unused locals.
7e3ab302
PE
16093 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16094 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16095 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16096 macros.
f78faa98 16097
e2b13473
PE
16098 * xterm.h (x_mouse_leave): New decl.
16099
77f23912
PE
16100 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16101 Remove unused functions.
cdf4ba58
PE
16102 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16103 (x_calc_absolute_position): Now static.
7411c686 16104 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16105 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16106 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16107 unless they are used.
38d0b34a
PE
16108 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16109 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16110 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16111 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16112 (x_error_catcher, x_connection_closed, x_error_handler):
16113 (x_error_quitter, xembed_send_message, x_iconify_frame):
16114 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16115 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16116 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16117
44f230aa
SM
16118 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16119 Rename or move locals to avoid shadowing.
6b463e58 16120 (tty_defined_color, merge_face_heights): Now static.
5967d051 16121 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
16122 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
16123 does not deduce is never used uninitialized.
73719eba
PE
16124 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16125 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16126
426994c3 16127 * terminal.c (store_terminal_param): Now static.
5489860b 16128
032f1620 16129 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16130 (set_frame_menubar): Remove unused local.
d4323972 16131 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16132 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16133 since they might point to immutable storage.
281585b0
PE
16134 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16135 since it's unused otherwise.
032f1620 16136
367c19e5 16137 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16138 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16139 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16140 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16141 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16142 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16143 does not deduce are never used uninitialized.
70739cbe 16144
07b48fa9
PE
16145 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16146
8868a238 16147 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16148 * window.c (window_loop, size_window):
16149 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16150
7e5cf297 16151 * window.c (display_buffer): Now static.
d6550a9f
PE
16152 (size_window): Mark variables that gcc -Wuninitialized
16153 does not deduce are never used uninitialized.
a586633d
PE
16154 * window.h (check_all_windows): New decl, to forestall
16155 gcc -Wmissing-prototypes diagnostic.
5b555da1 16156 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16157
f6095868
PE
16158 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16159 shadowing.
16160 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16161 Include <limits.h>.
16162 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16163 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16164 (load_charset_map): Mark variables that gcc -Wuninitialized
16165 does not deduce are never used uninitialized.
53df7c11 16166 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16167
f38b440c
PE
16168 * coding.c (coding_set_source, coding_set_destination):
16169 Use "else { /* comment */ }" rather than "else /* comment */;"
16170 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16171 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16172 a block, when the outer 'i' will do.
16173 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16174 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16175 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16176 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16177 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16178 Rename locals to avoid shadowing.
16179 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16180 * coding.c (emacs_mule_char, encode_invocation_designation):
16181 Now static, since they're not used elsewhere.
413bb2db 16182 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16183 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16184 (decode_coding_emacs_mule): Mark variables that gcc
16185 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16186 (detect_coding_iso_2022): Initialize a local variable that might
16187 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16188 this initialization is needed. (Bug#8211)
5f58e762
PE
16189 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16190 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16191 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16192 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16193 Remove unused macros.
f38b440c 16194
232b38b9 16195 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16196 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16197 * character.c (string_count_byte8): Likewise.
232b38b9 16198
fb90da1b
PE
16199 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16200 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16201
fb93dbc2
PE
16202 * chartab.c (copy_sub_char_table): Now static, since it's not used
16203 elsewhere.
5c156ace
PE
16204 (sub_char_table_ref_and_range, char_table_ref_and_range):
16205 Rename locals to avoid shadowing.
bbcd0949 16206 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16207
7d3b3862 16208 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16209 (BIDI_BOB): Remove unused macro.
7d3b3862 16210
6be7d3da
PE
16211 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16212 deduce are never used uninitialized.
c2ed9c8b 16213 * term.c (encode_terminal_code): Likewise.
6be7d3da 16214
75f8807f 16215 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 16216
50938595
PE
16217 * tparam.h: New file.
16218 * term.c, tparam.h: Include it.
16219 * deps.mk (term.o, tparam.o): Depend on tparam.h.
16220 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
16221 Move these decls to tparam.h, and make them agree with what
16222 is actually in tparam.c. The previous trick of using incompatible
16223 decls in different modules does not conform to the C standard.
16224 All callers of tparam changed to use tparam's actual API.
16225 * tparam.c (tparam1, tparam, tgoto):
16226 Use const pointers where appropriate.
16227
fbceeba2
PE
16228 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
16229 * cm.h (struct cm): Likewise.
16230 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
16231 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
16232 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
16233 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
16234 (turn_on_face, init_tty): Likewise.
16235 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 16236
7f3f1250
PE
16237 * term.c (term_mouse_position): Rename local to avoid shadowing.
16238
e6ca6543
PE
16239 * alloc.c (mark_ttys): Move decl from here ...
16240 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
16241
c40f8d15
AS
162422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
16243
16244 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
16245
cfe0661d
JB
162462011-03-09 Juanma Barranquero <lekktu@gmail.com>
16247
16248 * search.c (compile_pattern_1): Remove argument regp, unused since
16249 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
16250 (compile_pattern): Don't pass it.
16251
0afb4571
J
162522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
16253
16254 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
16255 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
16256 for ! HAVE_GTK3.
16257 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
16258
16259 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
16260
16261 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
16262 gdk_window_get_screen, gdk_window_get_geometry,
16263 gdk_x11_window_lookup_for_display and GDK_KEY_g.
16264 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
16265 (xg_get_pixbuf_from_pixmap): New function.
16266 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
16267 to Pixmap, take frame as parameter, remove GdkColormap parameter.
16268 Call xg_get_pixbuf_from_pixmap instead of
16269 gdk_pixbuf_get_from_drawable.
16270 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
16271 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
16272 (xg_check_special_colors): Use GtkStyleContext and its functions
16273 for HAVE_GTK3.
16274 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
16275 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
16276 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
16277 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
16278 Call gtk_widget_get_preferred_size.
0afb4571
J
16279 (xg_frame_resized): gdk_window_get_geometry only takes 5
16280 parameters.
44f230aa
SM
16281 (xg_win_to_widget, xg_event_is_for_menubar):
16282 Call gdk_x11_window_lookup_for_display.
0afb4571
J
16283 (xg_set_widget_bg): New function.
16284 (delete_cb): New function.
895009e1 16285 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 16286 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
16287 (xg_set_background_color): Call xg_set_widget_bg.
16288 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
16289 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
16290 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
16291 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
16292 if ! HAVE_GTK3.
16293 (update_frame_tool_bar): Call gtk_widget_hide.
16294 (xg_initialize): Use GDK_KEY_g.
16295
16296 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
16297 if ! HAVE_GTK3
16298 (x_session_initialize): Call gdk_x11_set_sm_client_id.
16299
16300 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
16301 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
16302 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
16303
1c2cc4ef
JB
163042011-03-08 Juanma Barranquero <lekktu@gmail.com>
16305
16306 * w32xfns.c (select_palette): Check success of RealizePalette against
16307 GDI_ERROR, not zero.
16308
33383987 16309See ChangeLog.11 for earlier changes.
aac0c6e3
MR
16310
16311;; Local Variables:
16312;; coding: utf-8
aac0c6e3
MR
16313;; End:
16314
2f097256 16315 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
16316
16317 This file is part of GNU Emacs.
16318
16319 GNU Emacs is free software: you can redistribute it and/or modify
16320 it under the terms of the GNU General Public License as published by
16321 the Free Software Foundation, either version 3 of the License, or
16322 (at your option) any later version.
16323
16324 GNU Emacs is distributed in the hope that it will be useful,
16325 but WITHOUT ANY WARRANTY; without even the implied warranty of
16326 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16327 GNU General Public License for more details.
16328
16329 You should have received a copy of the GNU General Public License
16330 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.