Fix BLOCK_INPUT/UNBLOCK_INPUT mismatch in 2012-06-08T08:44:30Z!dmantipov@yandex.ru.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8bbbc977
EZ
12012-06-08 Eli Zaretskii <eliz@gnu.org>
2
3 * alloc.c (allocate_vectorlike): Fix last change.
4
f3372c87
DA
52012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6
7 Block-based vector allocation of small vectors.
8 * lisp.h (struct vectorlike_header): New field `nbytes',
9 adjust comment accordingly.
10 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
11 to denote vector blocks. Adjust users (live_vector_p,
12 mark_maybe_pointer, valid_lisp_object_p) accordingly.
13 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
14 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
15 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
16 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
17 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
18 (roundup_size): New constant.
19 (struct vector_block): New data type.
20 (vector_blocks, vector_free_lists, zero_vector): New variables.
21 (all_vectors): Renamed to `large_vectors'.
22 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
23 (sweep_vectors): New functions.
24 (allocate_vectorlike): Return `zero_vector' as the only vector of
25 0 items. Allocate new vector from block if vector size is less than
26 or equal to VBLOCK_BYTES_MAX.
27 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
28 (init_alloc_once): Add call to init_vectors.
29
4f18a4ed
SM
302012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
31
32 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
33
86f158bc
PE
342012-06-07 Paul Eggert <eggert@cs.ucla.edu>
35
36 * doprnt.c (doprnt): Truncate multibyte char correctly.
37 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
38 would mishandle a string argument "Xc" if X was a multibyte
39 character of length 2: it would truncate after X's first byte
40 rather than including all of X.
41
c5cfcbe0
CY
422012-06-06 Chong Yidong <cyd@gnu.org>
43
44 * buffer.c (word_wrap): Doc fix.
45
c05cf390
PE
462012-06-04 Paul Eggert <eggert@cs.ucla.edu>
47
48 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
49
0c3461de
GM
502012-06-03 Glenn Morris <rgm@gnu.org>
51
52 * xdisp.c (tool-bar-style): Doc fix.
53
c71232db
UM
542012-06-03 Ulrich Müller <ulm@gentoo.org>
55
56 * Makefile.in (PAXCTL): Define.
57 (temacs$(EXEEXT)): Disable memory randomization for the temacs
58 binary via PaX flags if the paxctl utility is available.
59 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
60 Restore PaX flags to their default. (Bug#11398)
61
383f7350
CY
622012-06-03 Chong Yidong <cyd@gnu.org>
63
64 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
65 buffer (Bug#11226).
66
5f2c76c6
CY
672012-06-03 Chong Yidong <cyd@gnu.org>
68
69 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
70 (note_mode_line_or_margin_highlight): If there is no help echo,
71 use mode-line-default-help-echo. Handle the case where the mouse
72 position is past the end of the mode line string.
73
74 * buffer.c (buffer_local_value_1): New function, split from
75 Fbuffer_local_value; can return Qunbound.
76 (Fbuffer_local_value): Use it.
77 (Vmode_line_format): Docstring tweaks.
78
773d47f6
PE
792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
80
81 * sysdep.c (system_process_attributes): Improve comment.
82
f2d6a3df
SM
832012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
84
85 * keyboard.c: Export real-this-command to Elisp.
86 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
87 and DEFVAR it. Update all users.
88
63810350
PE
892012-06-02 Paul Eggert <eggert@cs.ucla.edu>
90
7bd5c1f4
PE
91 * minibuf.c (Fassoc_string): Remove duplicate declaration.
92
63810350
PE
93 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
94 Convert pctcpu and pctmem to Lisp float properly.
95 Let the compiler fold better, as 100.0/0x8000 is exact.
96
a2821611
AS
972012-06-02 Andreas Schwab <schwab@linux-m68k.org>
98
99 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
100 cons_block.
101
5fceba1d
PE
1022012-06-01 Paul Eggert <eggert@cs.ucla.edu>
103
104 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
105
c98ff5dd
DA
1062012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
107
108 For a 'struct window', replace some Lisp_Object fields to
109 bitfields where appropriate, remove unused fields.
110 * window.h (struct window): Remove unused 'last_mark_x' and
111 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
112 change it's type from Lisp_Object to bitfield.
113 Change type of 'force_start', 'optional_new_start',
114 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
115 fields from Lisp_Object to bitfield. Adjust users accordingly.
116
ca34e0be
PE
1172012-05-31 Paul Eggert <eggert@cs.ucla.edu>
118
119 Pacify gcc -Wdouble-precision when using Xaw.
120 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
121 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
122 Use 'float' consistently, rather than 'float' in most places
123 and 'double' in a couple of places.
124
efc00ab1 1252012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
126
127 * xdisp.c (handle_stop): Detect whether we have overlay strings
128 loaded by testing it->current.overlay_string_index to be
129 non-negative, instead of checking whether n_overlay_strings is
130 positive. (Bug#11587)
131
efc00ab1 1322012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
133
134 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
135
136 * doc.c (Fsubstitute_command_keys): Doc fix.
137
efc00ab1 1382012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
139
140 * search.c (search_buffer): Remove calls to
141 r_alloc_inhibit_buffer_relocation, as it is now called by
142 maybe_unify_char, which was the cause of relocation of buffer text
143 in bug#11519.
144
efc00ab1 1452012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
146
147 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
148 for the duration of call to load_charset, to avoid problems with
149 callers of maybe_unify_char that access buffer text through C
150 pointers.
151
152 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
153 decrement the inhibition flag, instead of just setting or
154 resetting it.
155
ba93a187
PE
1562012-05-31 Paul Eggert <eggert@cs.ucla.edu>
157
158 Remove obsolete '#define static' cruft.
159 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
160 This #undef was "temporary" in 2000; it is no longer needed
161 now that '#define static' has gone away.
162 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
163 (gray_bitmap_bits): Remove; no longer needed.
164 All uses replaced with definiens.
165 * xterm.c: Include "bitmaps/gray.xbm".
166
9e4bf381
PE
1672012-05-30 Paul Eggert <eggert@cs.ucla.edu>
168
169 Clean up __executable_start, monstartup when --enable-profiling.
170 The following changes affect the code only when profiling.
171 * dispnew.c (__executable_start): Rename from safe_bcopy.
172 Define only on platforms that need it.
173 * emacs.c: Include <sys/gmon.h> when profiling.
174 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
175 (__executable_start): Remove decl, since lisp.h does it now.
176 (safe_bcopy): Remove decl; no longer has that name.
177 (main): Coalesce #if into single bit of code, for simplicity.
178 Cast pointers to uintptr_t, since standard libraries want integers
179 and not pointers.
180 * lisp.h (__executable_start): New decl.
181
32d72c2f
GM
1822012-05-31 Glenn Morris <rgm@gnu.org>
183
184 * image.c (Fimagemagick_types): Doc fix.
185
baac5bc7
JM
1862012-05-30 Jim Meyering <meyering@redhat.com>
187
188 * callproc.c (Fcall_process_region): Include directory component
189 in mkstemp error message (Bug#11586).
190
72cb32cf
PE
1912012-05-30 Paul Eggert <eggert@cs.ucla.edu>
192
193 * alloc.c, lisp.h (make_pure_vector): Now static.
194
61b108cc
SM
1952012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
196
197 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
198 Move to byte-run.el.
199 (Fautoload): Do the hash-doc more carefully.
200 * data.c (Fdefalias): Purify definition, except for keymaps.
201 (Qdefun): Move from eval.c.
202 * lisp.h (Qdefun): Remove.
203 * lread.c (read1): Tiny simplification.
204
471fe23d
TN
2052012-05-29 Troels Nielsen <bn.troels@gmail.com>
206
934f3f58 207 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
208 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
209 Bug#9642, but explicitly check that the buffer the overlay would
210 be moved to is live and rearrange lines to make sure that errors
211 will not put the overlay in an inconsistent state.
212 (Fdelete_overlay): Cosmetics.
213
85d0efd1
EZ
2142012-05-28 Eli Zaretskii <eliz@gnu.org>
215
216 * w32term.c (my_bring_window_to_top): New function.
217 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
218 could be different from the original one.
219 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
220 (Bug#11513)
221
222 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
223 by calling BringWindowToTop.
224
225 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
226 (WM_EMACS_END): Increase by one.
227
da92a98c
PE
2282012-05-28 Paul Eggert <eggert@cs.ucla.edu>
229
230 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
231 This avoids undefined behavior that might cause the eassert
232 to not catch an out-of-range value.
233
74d1f848
JB
2342012-05-28 Juanma Barranquero <lekktu@gmail.com>
235
236 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
237 Update dependencies.
238
9e1a06fc
EZ
2392012-05-27 Eli Zaretskii <eliz@gnu.org>
240
241 * bidi.c (bidi_mirror_char): Fix last change.
242
f3dd7312
AS
2432012-05-27 Andreas Schwab <schwab@linux-m68k.org>
244
245 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
246 when referring to sectname field in printf format.
247
81899c91
PE
2482012-05-27 Paul Eggert <eggert@cs.ucla.edu>
249
57b81a9f
PE
250 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
251 Only r_alloc_inhibit_buffer_relocation needed to be added;
252 the others were already declared.
253
81899c91
PE
254 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
255 before checking whether it's out of range. Put the check inside
256 eassert. See
257 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
258
33017faf 2592012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
260
261 * callproc.c (Fcall_process): Restore a line that was accidentally
262 commented out in the 2011-02-13 change (bug#11547).
263
33017faf 2642012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
265
266 * lisp.h [REL_ALLOC]: Add prototypes for external functions
267 defined on ralloc.c.
268
269 * buffer.c [REL_ALLOC]: Remove prototypes of
270 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
271 they are now on lisp.h.
272
273 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
274
275 * search.c (search_buffer): Use it to inhibit relocation of buffer
276 text while re_search_2 is doing its job, because re_search_2 is
277 passed C pointers to buffer text. (Bug#11519)
278
23415acf
EZ
279 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
280 Update value to 24.
281
44e27368
EZ
282 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
283 state after an additional call to move_it_in_display_line_to, keep
284 the values of it->max_ascent and it->max_descent found for the
285 entire line.
286 (pos_visible_p): Revert the comparison against bottom_y to what it
287 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
288 (Bug#11464)
289
c1892f11
PE
2902012-05-26 Paul Eggert <eggert@cs.ucla.edu>
291
292 Fix coding-related core dumps with gcc -ftrapv.
293 The code was computing A - B, where A and B are pointers, and B is
294 random garbage. This can lead to core dumps on platforms that
295 have special pointer registers, and it also leads to core dumps on
296 x86-64 when compiled with gcc -ftrapv. The fix is to compute
297 A - B only when B is initialized properly.
298 * coding.c (coding_set_source, coding_set_destination): Return void.
299 (coding_change_source, coding_change_destinations): New functions,
300 with the old behaviors of coding_set_source and coding_set_destination.
301 All callers that need an offset changed to use these new functions.
302
eb7afdad
GM
3032012-05-26 Glenn Morris <rgm@gnu.org>
304
305 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
306
f12fdf02
EZ
3072012-05-26 Eli Zaretskii <eliz@gnu.org>
308
53a63be6 309 Extend mouse support on W32 text-mode console.
61b108cc
SM
310 * xdisp.c (draw_row_with_mouse_face):
311 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 312
eb3f6f01 313 * w32console.c: Include window.h.
61b108cc
SM
314 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
315 New functions.
eb3f6f01
EZ
316 (initialize_w32_display): Initialize mouse-highlight data.
317
53a63be6
EZ
318 * w32inevt.c: Include termchar.h and window.h.
319 (do_mouse_event): Support mouse-autoselect-window. When the mouse
320 moves, call note_mouse_highlight. If help_echo changed, call
321 gen_help_event to produce help-echo message in the echo area.
322 Call clear_mouse_face if mouse_face_hidden is set in the mouse
323 highlight info.
324
4cfd81f6
PE
3252012-05-26 Paul Eggert <eggert@cs.ucla.edu>
326
327 * lread.c (read1): Simplify slightly to avoid an overflow warning
328 with GCC 4.7.0 on x86-64.
329
4446092a
EZ
3302012-05-26 Eli Zaretskii <eliz@gnu.org>
331
332 * bidi.c (bidi_mirror_char): Revert last change: an int is
333 definitely wide enough here.
334
42b2a986 3352012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 336
42b2a986 337 Fix integer width and related bugs (Bug#9874).
eb106a49 338 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
339 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
340 (string_bytes, check_sblock, allocate_string_data):
341 (compact_small_strings, Fmake_bool_vector, make_string)
342 (make_unibyte_string, make_multibyte_string)
343 (make_string_from_bytes, make_specified_string)
344 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
345 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
346 (mark_vectorlike):
347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
348 (allocate_pseudovector):
349 Use int, not EMACS_INT, where int is wide enough.
350 (inhibit_garbage_collection, Fgarbage_collect):
351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
352 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
353 int might not be wide enough.
354 (bidi_cache_search, bidi_cache_find, bidi_init_it)
355 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
356 (bidi_at_paragraph_end, bidi_find_paragraph_start)
357 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
358 (bidi_level_of_next_char, bidi_move_to_visually_next):
359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
360 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
361 (Fkill_buffer, Fset_buffer_major_mode)
362 (advance_to_char_boundary, Fbuffer_swap_text)
363 (Fset_buffer_multibyte, overlays_at, overlays_in)
364 (overlay_touches_p, struct sortvec, record_overlay_string)
365 (overlay_strings, recenter_overlay_lists)
366 (adjust_overlays_for_insert, adjust_overlays_for_delete)
367 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
368 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
369 (Foverlay_recenter, last_overlay_modification_hooks_used)
370 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
372 (validate_region): Omit unnecessary test for b <= e,
373 since that's guaranteed by the previous test.
d311d28c
PE
374 (adjust_overlays_for_delete): Avoid pos + length overflow.
375 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
376 (report_overlay_modification):
377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
378 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
379 Omit pointer cast, which isn't needed anyway, and doesn't work
380 after the EMACS_INT -> ptrdiff_t change.
02481186 381 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
382 * buffer.h: Adjust decls to match defn changes elsewhere.
383 (struct buffer_text, struct buffer):
384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
385 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
386 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
387 not int, to avoid needless 32-bit limit on 64-bit hosts.
388 (exec_byte_code): Use tighter memory-full test, one that checks
389 for alloca overflow. Don't compute the address of the object just
390 before an array, as that's not portable. Use EMACS_INT, not
391 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
392 * callint.c (Fcall_interactively):
393 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
394 * callproc.c (call_process_kill, Fcall_process):
395 Don't assume pid_t fits into an Emacs fixnum.
396 (call_process_cleanup, Fcall_process, child_setup):
397 Don't assume pid_t fits into int.
398 (call_process_cleanup, Fcall_process, delete_temp_file)
399 (Fcall_process_region):
400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
401 (Fcall_process): Simplify handling of volatile integers.
402 Use int, not EMACS_INT, where int will do.
403 * casefiddle.c (casify_object, casify_region, operate_on_word)
404 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
406 (casify_object): Avoid integer overflow when overallocating buffer.
407 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 408 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
409 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
410 * category.h (CATEGORYP): Don't assume arg is nonnegative.
411 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
412 integers are now checked earlier. All uses replaced with XINT.
413 (ccl_driver):
414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
415 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
416 (ccl_driver, Fregister_code_conversion_map):
417 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
418 (resolve_symbol_ccl_program): Check that vector header is in range.
419 Always copy the vector, so that we can check its contents reliably
420 now rather than having to recheck each instruction as it's being
421 executed. Check that vector words fit in 'int'.
422 (ccl_get_compiled_code, Fregister_ccl_program)
423 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
424 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
425 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
426 contents are in range.
427 (Fccl_execute_on_string): Check that status is in range.
428 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
429 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
430 Accept and return EMACS_INT, not int, because callers can pass values
431 out of 'int' range.
432 (c_string_width, strwidth, lisp_string_width, chars_in_text)
433 (multibyte_chars_in_text, parse_str_as_multibyte)
434 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
435 (str_as_unibyte, str_to_unibyte, string_count_byte8)
436 (string_escape_byte8, Fget_byte):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 438 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
439 avoid mishandling large integers.
440 * character.h: Adjust decls to match defn changes elsewhere.
441 * charset.c (load_charset_map_from_file, find_charsets_in_text)
442 (Ffind_charset_region):
443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
444 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
445 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 446 Don't assume fixnum fits in int.
d311d28c
PE
447 (load_charset_map_from_vector, Fmap_charset_chars):
448 Remove now-unnecessary CHECK_NATNUMs.
449 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
450 Don't rely on undefined behavior with signed left shift overflow.
451 Don't assume unsigned int fits into fixnum, or that fixnum fits
452 into unsigned int. Don't require max_code to be a valid fixnum;
453 that's not true for gb10830 4-byte on a 32-bit host. Allow
454 invalid_code to be a cons, for the same reason. Require code_offset
455 to be a character. Avoid int overflow if max_char is close
456 to INT_MAX.
457 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
458 this is intended anyway and avoids some undefined behavior.
459 (load_charset_map): Pass unsigned, not int, as 2nd arg of
460 INDEX_TO_CODE_POINT, as that's what it expects.
461 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
462 * charset.h (DECODE_CHAR): Return int, not unsigned;
463 this is what was intended anyway, and it avoids undefined behavior.
464 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
465 integer-overflow issues.
466 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
467 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
468 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
469 * chartab.c (Fmake_char_table, Fset_char_table_range)
470 (uniprop_get_decoder, uniprop_get_encoder):
471 Don't assume fixnum fits in int.
472 * cmds.c (move_point): New function, that does the gist of
473 Fforward_char and Fbackward_char, but does so while checking
474 for integer overflow more accurately.
c96e5d6a 475 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
476 (Fforward_line, Fend_of_line, internal_self_insert)
477 (internal_self_insert):
478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
479 Fix a FIXME, by checking for integer overflow when calculating
480 target_clm and actual_clm.
481 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 482 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
483 (ASSURE_DESTINATION, coding_alloc_by_realloc)
484 (coding_alloc_by_making_gap, alloc_destination)
485 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
486 (encode_coding_utf_16, detect_coding_emacs_mule)
487 (decode_coding_emacs_mule, encode_coding_emacs_mule)
488 (detect_coding_iso_2022, decode_coding_iso_2022)
489 (encode_invocation_designation, encode_designation_at_bol)
490 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
491 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
492 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
493 (encode_coding_ccl, encode_coding_raw_text)
494 (detect_coding_charset, decode_coding_charset)
495 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
496 (produce_composition, produce_charset, produce_annotation)
497 (decode_coding, handle_composition_annotation)
498 (handle_charset_annotation, consume_chars, decode_coding_gap)
499 (decode_coding_object, encode_coding_object, detect_coding_system)
500 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
501 (code_convert_region, code_convert_string)
8f50130c
PE
502 (Fdefine_coding_system_internal)
503 (coding_set_source, coding_set_destination):
d311d28c
PE
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
506 (Fdefine_coding_system_internal):
507 Don't assume fixnums fit in int.
508 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 509 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
510 (Funencodable_char_position, Fcheck_coding_systems_region)
511 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 513 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 514 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 515 Don't access memory outside of the args array.
d311d28c 516 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
517 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
518 result of ENCODE_CHAR.
d311d28c
PE
519 * coding.h: Adjust decls to match defn changes elsewhere.
520 (struct coding_system):
521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
522 * composite.c (get_composition_id, find_composition)
523 (run_composition_function, update_compositions)
524 (compose_text, composition_gstring_put_cache)
525 (composition_gstring_p, composition_gstring_width)
526 (fill_gstring_header, fill_gstring_body, autocmp_chars)
527 (composition_compute_stop_pos, composition_reseat_it)
528 (composition_update_it, struct position_record)
529 (find_automatic_composition, composition_adjust_point)
530 (Fcomposition_get_gstring, Ffind_composition_internal):
531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
532 (update_compositions):
533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
534 * composite.h: Adjust decls to match defn changes elsewhere.
535 (struct composition):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
538 Do not attempt to compute the address of the object just before a
539 buffer; this is not portable.
540 (Faref, Faset):
541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
542 (Faset): Use int, not EMACS_INT, where int is wide enough.
543 (Fstring_to_number): Don't assume fixnums fit in int.
544 (Frem): Don't assume arg is nonnegative.
545 * dbusbind.c (xd_append_arg): Check for integers out of range.
546 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 547 (extract_signed, extract_unsigned): New functions.
243e0530
PE
548 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
549 (xd_get_connection_references): Return ptrdiff_t, not int.
550 All uses changed.
551 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
552 (xd_read_message_1):
553 Use int, not unsigned, where the dbus API uses int.
554 (Fdbus_message_internal): Don't overflow mtype.
555 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
556 * dired.c (directory_files_internal, file_name_completion, scmp)
557 (file_name_completion_stat):
558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
559 (file_name_completion): Don't overflow matchcount.
560 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
561 * dispextern.h: Adjust decls to match defn changes elsewhere.
562 (struct text_pos, struct glyph, struct bidi_saved_info)
563 (struct bidi_string_data, struct bidi_it, struct composition_it)
564 (struct it):
565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
566 (struct display_pos, struct composition_it, struct it):
567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
568 * dispnew.c (increment_matrix_positions)
569 (increment_row_positions, mode_line_string)
570 (marginal_area_string):
571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 572 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (duration_to_sec_usec): New function, to check for overflow better.
575 (Fsleep_for, sit_for): Use it.
576 * doc.c (get_doc_string, store_function_docstring):
577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
578 (get_doc_string, Fsnarf_documentation):
579 Use int, not EMACS_INT, where int is wide enough.
580 (get_doc_string):
581 Use SAFE_ALLOCA, not alloca.
582 Check for overflow when converting EMACS_INT to off_t.
583 * doprnt.c (doprnt):
584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
585 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
586 Don't assume uid_t fits into fixnum.
587 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
588 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
589 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
590 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
591 (general_insert_function)
592 (Finsert_char, make_buffer_string, make_buffer_string_both)
593 (update_buffer_properties, Fbuffer_substring)
594 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
595 (Fsubst_char_in_region, check_translation)
596 (Ftranslate_region_internal, save_restriction_restore, Fformat)
597 (transpose_markers, Ftranspose_regions):
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
599 (clip_to_bounds): Move to lisp.h as an inline function).
600 (Fconstrain_to_field): Don't assume integers are nonnegative.
601 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
602 (Fsubst_char_in_region, Fsave_restriction):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 (Femacs_pid): Don't assume pid_t fits into fixnum.
605 (lo_time): Use int, not EMACS_INT, when int suffices.
606 (lisp_time_argument): Check for usec out of range.
607 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
608 (Fuser_login_name, Fuser_full_name): Signal an error
609 if a uid argument is out of range, rather than relying on
610 undefined behavior.
c8d5c857
PE
611 (Fformat_time_string): Remove now-unnecessary check.
612 lisp_time_argument checks for out-of-range usec now.
243e0530 613 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
614 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
615 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
616 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
617 (init_cmdargs, Fdump_emacs):
618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
619 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
620 the bottom (typically) 32 bits of the fixnum.
621 * eval.c (specpdl_size, call_debugger):
622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
623 (when_entered_debugger, Fbacktrace_debug):
624 Don't assume fixnum can fit in int.
625 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
626 the object just before a buffer; this is not portable.
627 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
628 (grow_specpdl, unbind_to):
629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
630 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
631 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 632 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
633 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
634 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
636 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
637 (a_write, e_write):
638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
639 (Fcopy_file, non_regular_nbytes, read_non_regular)
640 (Finsert_file_contents):
641 Use int, not EMACS_INT, where int is wide enough.
642 (READ_BUF_SIZE): Verify that it fits in int.
643 (Finsert_file_contents): Check that counts are in proper range,
644 rather than assuming fixnums fit into ptrdiff_t etc.
645 Don't assume fixnums fit into int.
125b3835 646 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
647 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
648 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
649 (string_char_to_byte, string_byte_to_char)
650 (string_make_multibyte, string_to_multibyte)
651 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
652 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
653 (substring_both, Fdelete, internal_equal, Ffillarray)
654 (Fclear_string, mapcar1)
655 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
656 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
657 (larger_vector, make_hash_table, maybe_resize_hash_table)
658 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
659 (Fmaphash, secure_hash):
660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
661 (concat): Check for string index and length overflow.
662 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
663 (Frequire):
664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
665 (larger_vector): New API (vec, incr_min, size_max) replaces old
666 one (vec, new_size, init). This catches size overflow.
667 INIT was removed because it was always Qnil.
668 All callers changed.
669 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
670 the upper bound on a hash table index size.
671 (make_hash_table, maybe_resize_hash_table): Use it.
672 (secure_hash): Computer start_byte and end_byte only after
673 they're known to be in ptrdiff_t range.
674 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
675 (Ffont_get_glyphs, Ffont_at):
676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
677 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
678 (Flist_fonts, Fopen_font):
679 Don't assume fixnum can fit in int.
680 (check_gstring): Don't assume index can fit in int.
681 (font_match_p): Check that fixnum is a character, not a nonnegative
682 fixnum, since the later code needs to stuff it into an int.
683 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
684 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
685 conversion overflow issues.
686 (Fopen_font): Check for integer out of range.
687 (Ffont_get_glyphs): Don't assume index can fit in int.
688 * font.h: Adjust decls to match defn changes elsewhere.
689 * fontset.c (reorder_font_vector): Redo score calculation to avoid
690 integer overflow.
691 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
692 printmax_t, where ptrdiff_t is wide enough.
693 (Finternal_char_font):
694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
695 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
696 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
697 (Fset_frame_position, x_set_frame_parameters)
698 (x_set_line_spacing, x_set_border_width)
699 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
700 Check that fixnums are in proper range for system types.
701 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
704 Use SAFE_ALLOCA_LISP, not alloca.
705 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
706 intptr_t is wide enough.
707 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
708 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
709 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
710 Check for fixnum out of range.
711 * ftfont.c (ftfont_list): Don't assume index fits in int.
712 Check that fixnums are in proper range for system types.
713 (ftfont_shape_by_flt):
714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
715 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
717 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
718 Check that fixnums are in proper range for system types.
719 * gnutls.h: Adjust decls to match defn changes elsewhere.
720 * gtkutil.c (xg_dialog_run):
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 (update_frame_tool_bar):
723 Check that fixnums are in proper range for system types.
724 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 725 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
726 * indent.c (last_known_column, last_known_column_point):
727 (current_column_bol_cache):
728 (skip_invisible, current_column, check_display_width):
729 (check_display_width, scan_for_column, current_column_1)
730 (Findent_to, Fcurrent_indentation, position_indentation)
731 (indented_beyond_p, Fmove_to_column, compute_motion):
732 (Fcompute_motion, Fvertical_motion):
733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
734 (last_known_column_modified): Use EMACS_INT, not int.
735 (check_display_width):
736 (Fcompute_motion):
737 Check that fixnums and floats are in proper range for system types.
738 (compute_motion): Don't assume index or fixnum fits in int.
739 (compute_motion, Fcompute_motion):
740 Use int, not EMACS_INT, when it is wide enough.
741 (vmotion): Omit local var start_hpos that is always 0; that way
742 we don't need to worry about overflow in expressions involving it.
743 * indent.h: Adjust decls to match defn changes elsewhere.
744 (struct position):
745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
746 Use int, not EMACS_INT, where int is wide enough.
747 Remove unused members ovstring_chars_done and tab_offset;
748 all uses removed.
749 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
750 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
751 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
752 (make_gap, copy_text, insert, insert_and_inherit)
753 (insert_before_markers, insert_before_markers_and_inherit)
754 (insert_1, count_combining_before, count_combining_after)
755 (insert_1_both, insert_from_string)
756 (insert_from_string_before_markers, insert_from_string_1)
757 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
758 (adjust_after_replace, adjust_after_insert, replace_range)
759 (replace_range_2, del_range, del_range_1, del_range_byte)
760 (del_range_both, del_range_2, modify_region)
761 (prepare_to_modify_buffer, signal_before_change)
762 (signal_after_change, Fcombine_after_change_execute):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 * intervals.c (traverse_intervals, rotate_right, rotate_left)
765 (balance_an_interval, split_interval_right, split_interval_left)
766 (find_interval, next_interval, update_interval)
767 (adjust_intervals_for_insertion, delete_node, delete_interval)
768 (interval_deletion_adjustment, adjust_intervals_for_deletion)
769 (static_offset_intervals, offset_intervals)
770 (merge_interval_right, merge_interval_left, make_new_interval)
771 (graft_intervals_into_buffer, temp_set_point_both)
772 (temp_set_point, set_point, adjust_for_invis_intang)
773 (set_point_both, move_if_not_intangible, get_property_and_range)
774 (get_local_map, copy_intervals, copy_intervals_to_string)
775 (compare_string_intervals, set_intervals_multibyte_1):
776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
777 * intervals.h: Adjust decls to match defn changes elsewhere.
778 (struct interval):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 * keyboard.c (this_command_key_count, this_single_command_key_start)
781 (before_command_key_count, before_command_echo_length, echo_now)
782 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
783 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
784 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
785 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
787 (last_non_minibuf_size, last_point_position, echo_truncate)
788 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
789 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
790 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
791 (stuff_buffered_input):
792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
793 (last_auto_save, command_loop_1, read_char):
794 Use EMACS_INT, not int, to avoid integer overflow.
795 (record_char): Avoid overflow in total_keys computation.
796 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
797 * keyboard.h: Adjust decls to match defn changes elsewhere.
798 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
799 (Fkey_description, Fdescribe_vector, Flookup_key):
800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
801 (click_position): New function, to check that positions are in range.
802 (Fcurrent_active_maps):
803 (describe_command):
804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
805 (Faccessible_keymaps, Fkey_description):
806 (preferred_sequence_p):
807 Don't assume fixnum can fit into int.
808 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
809 Check for integer overflow in size calculations.
810 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
811 avoid mishandling large integers.
812 * lisp.h: Adjust decls to match defn changes elsewhere.
813 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
814 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
815 (struct Lisp_Marker):
816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
817 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
818 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
819 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
820 All callers changed.
821 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
822 Assume the arg has valid form, since it always does.
823 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
824 unsigned integer system type.
825 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
826 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
828 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
829 (duration_to_sec_usec): New decl.
830 * lread.c (read_from_string_index, read_from_string_index_byte)
831 (read_from_string_limit, readchar, unreadchar, openp)
832 (read_internal_start, read1, oblookup):
833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
834 (Fload, readevalloop, Feval_buffer, Feval_region):
835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
836 (openp): Check for out-of-range argument to 'access'.
837 (read1): Use int, not EMACS_INT, where int is wide enough.
838 Don't assume fixnum fits into int.
6efdadfd 839 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
840 (read_filtered_event): Use duration_to_sec_usec
841 to do proper overflow checking on durations.
d311d28c
PE
842 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
843 in size calculation.
844 (Fexecute_kbd_macro):
845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
846 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
847 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
848 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
849 (set_marker_both, set_marker_restricted_both, marker_position)
850 (marker_byte_position, Fbuffer_has_markers_at):
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
852 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 853 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
854 It now merely ensures that the menu is large enough, without
855 necessarily growing it, as this avoids some integer overflow issues.
856 All callers changed.
857 (keymap_panes, parse_single_submenu, Fx_popup_menu):
858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
859 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
860 Use SAFE_ALLOCA_LISP, not alloca.
861 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
862 to EMACS_INT. Check that fixnums are in proper range for system types.
863 * minibuf.c (minibuf_prompt_width, string_to_object)
864 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
865 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
867 (get_minibuffer, read_minibuf_unwind):
868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
869 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
870 this simplifies overflow checking. All callers changed.
871 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
872 (Ftest_completion):
873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
874 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
875 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
876 Check that fixnums are in proper range for system types.
877 (Fx_create_frame, Fx_show_tip):
878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
879 * nsfont.m (ns_findfonts, nsfont_list_family):
880 Don't assume fixnum fits in long.
881 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
883 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
884 wide enough.
17fdb222 885 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
887 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
888 (PRINTDECLARE, PRINTPREPARE):
889 (strout, print_string):
890 (print, print_preprocess, print_check_string_charset_prop)
891 (print_object):
892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
893 (PRINTDECLARE):
894 (temp_output_buffer_setup, Fprin1_to_string, print_object):
895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
896 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 897 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 898 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
899 (print_error_message): Use SAFE_ALLOCA, not alloca.
900 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
901 (print_depth, new_backquote_output, print_number_index):
902 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
903 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
904 (Fset_process_window_size, Fformat_network_address)
905 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 906 (sigchld_handler):
d311d28c 907 Check that fixnums are in proper range for system types.
d44287d4 908 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
909 Check for process-ids out of pid_t range rather than relying on
910 undefined behavior.
e4d81efc 911 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
912 (Fformat_network_address, read_process_output, send_process)
913 (Fprocess_send_region, status_notify):
914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
915 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
916 (wait_reading_process_output, read_process_output, exec_sentinel):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
919 (Faccept_process_output): Use duration_to_sec_usec to do proper
920 overflow checking on durations.
dde14581
PE
921 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
922 Don't assume pid_t fits in int.
02481186
PE
923 * process.h (struct Lisp_Process): Members tick and update_tick
924 are now of type EMACS_INT, not int.
b62b53e8
PE
925 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
926 configured --with-wide-int.
d311d28c
PE
927 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
928 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
929 * search.c (looking_at_1, string_match_1):
930 (fast_string_match, fast_c_string_match_ignore_case)
931 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
932 (scan_newline, find_before_next_newline, search_command)
933 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
934 (set_search_regs, wordify):
935 (Freplace_match):
936 (Fmatch_data):
937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
938 (string_match_1, search_buffer, set_search_regs):
939 (Fmatch_data):
940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
941 (wordify): Check for overflow in size calculation.
942 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
943 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
944 Check that fixnums are in proper range for system types.
945 * sound.c (struct sound_device)
946 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 (Fplay_sound_internal):
949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 950 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
951 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
952 (Fparse_partial_sexp):
953 Don't assume fixnums can fit in int.
954 (struct lisp_parse_state, find_start_pos, find_start_value)
955 (find_start_value_byte, find_start_begv)
956 (update_syntax_table, char_quoted, dec_bytepos)
957 (find_defun_start, prev_char_comend_first, back_comment):
958 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
959 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
961 (Finternal_describe_syntax_value): Check that match_lisp is a
962 character, not an integer, since the code stuffs it into int.
963 (scan_words, scan_sexps_forward):
964 Check that fixnums are in proper range for system types.
965 (Fforward_word):
966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
967 (scan_sexps_forward):
968 Use CHARACTERP, not INTEGERP, since the value must fit into int.
969 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
970 * syntax.h: Adjust decls to match defn changes elsewhere.
971 (struct gl_state_s):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
973 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
974 MOST_POSITIVE_FIXNUM.
d311d28c
PE
975 * sysdep.c (wait_for_termination_1, wait_for_termination)
976 (interruptible_wait_for_termination, mkdir):
977 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
978 (emacs_read, emacs_write):
979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
980 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
981 and double all fit in int.
d311d28c
PE
982 * term.c (set_tty_color_mode):
983 Check that fixnums are in proper range for system types.
984 * termhooks.h (struct input_event):
985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
986 * textprop.c (validate_interval_range, interval_of)
987 (Fadd_text_properties, set_text_properties_1)
988 (Fremove_text_properties, Fremove_list_of_text_properties)
989 (Ftext_property_any, Ftext_property_not_all)
990 (copy_text_properties, text_property_list, extend_property_ranges)
991 (verify_interval_modification):
992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
993 (Fnext_single_char_property_change)
994 (Fprevious_single_char_property_change):
995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
996 (copy_text_properties):
997 Check for integer overflow in index calculation.
d311d28c
PE
998 * undo.c (last_boundary_position, record_point, record_insert)
999 (record_delete, record_marker_adjustment, record_change)
1000 (record_property_change):
1001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1002 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1005 (Fx_hide_tip, Fx_file_dialog):
1006 * w32menu.c (set_frame_menubar):
1007 Use ptrdiff_t, not int, for consistency with rest of code.
1008 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1009 (select_window, Fdelete_other_windows_internal)
1010 (window_scroll_pixel_based, window_scroll_line_based)
1011 (Frecenter, Fset_window_configuration):
1012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1013 (Fset_window_hscroll, run_window_configuration_change_hook)
1014 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1015 (Fscroll_other_window, Frecenter):
d311d28c
PE
1016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1017 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1018 Don't assume fixnum fits in int.
1019 (Fset_window_scroll_bars):
1020 Check that fixnums are in proper range for system types.
1021 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1022 (string_pos, c_string_pos, number_of_chars, init_iterator)
1023 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1024 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1025 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1026 (face_before_or_after_it_pos, handle_invisible_prop)
1027 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1028 (display_prop_intangible_p, string_buffer_position_lim)
1029 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1030 (get_overlay_strings_1, get_overlay_strings)
1031 (iterate_out_of_display_property, forward_to_next_line_start)
1032 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1033 (get_next_display_element, set_iterator_to_next)
1034 (get_visually_first_element, compute_stop_pos_backwards)
1035 (handle_stop_backwards, next_element_from_buffer)
1036 (move_it_in_display_line_to, move_it_in_display_line)
1037 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1038 (add_to_log, message_dolog, message_log_check_duplicate)
1039 (message2, message2_nolog, message3, message3_nolog
1040 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1041 (current_message_1, truncate_echo_area, truncate_message_1)
1042 (set_message, set_message_1, store_mode_line_noprop)
1043 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1044 (text_outside_line_unchanged_p, check_point_in_composition)
1045 (reconsider_clip_changes)
1046 (redisplay_internal, set_cursor_from_row, try_scrolling)
1047 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1048 (redisplay_window, find_last_unchanged_at_beg_row)
1049 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1050 (trailing_whitespace_p, find_row_edges, display_line)
1051 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1052 (display_mode_element, store_mode_line_string)
1053 (pint2str, pint2hrstr, decode_mode_spec)
1054 (display_count_lines, display_string, draw_glyphs)
1055 (x_produce_glyphs, x_insert_glyphs)
1056 (rows_from_pos_range, mouse_face_from_buffer_pos)
1057 (fast_find_string_pos, mouse_face_from_string_pos)
1058 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1060 (safe_call, init_from_display_pos, handle_fontified_prop)
1061 (handle_single_display_spec, load_overlay_strings)
1062 (with_echo_area_buffer, setup_echo_area_for_printing)
1063 (display_echo_area, echo_area_display)
1064 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1065 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1066 (redisplay_window, dump_glyph_row, display_mode_line)
1067 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1068 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1070 (handle_single_display_spec, build_desired_tool_bar_string)
1071 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1072 (get_specified_cursor_type):
1073 Check that fixnums are in proper range for system types.
1074 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1075 (Flookup_image_map):
1076 Don't assume fixnums fit in int.
1077 (compare_overlay_entries):
1078 Avoid mishandling comparisons due to subtraction overflow.
1079 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1080 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1081 (handle_tool_bar_click):
1082 Use int, not unsigned, since we prefer signed and the signedness
1083 doesn't matter here.
1084 (get_next_display_element, next_element_from_display_vector):
1085 Use int, not EMACS_INT, when int is wide enough.
1086 (start_hourglass): Use duration_to_sec_usec to do proper
1087 overflow checking on durations.
1088 * xfaces.c (Fbitmap_spec_p):
1089 Check that fixnums are in proper range for system types.
1090 (compare_fonts_by_sort_order):
1091 Avoid mishandling comparisons due to subtraction overflow.
1092 (Fx_family_fonts, realize_basic_faces):
1093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1094 (Fx_family_fonts):
1095 Don't assume fixnum fits in int.
1096 Use SAFE_ALLOCA_LISP, not alloca.
1097 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1098 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1099 (face_at_buffer_position, face_for_overlay_string)
1100 (face_at_string_position):
1101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1102 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1103 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1104 (Fx_show_tip):
1105 Check that fixnums are in proper range for system types.
1106 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1107 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1109 (Fx_change_window_property): Don't assume fixnums fit in int.
1110 * xfont.c (xfont_chars_supported):
1111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1112 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1113 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1115 * xml.c (parse_region):
1116 * xrdb.c (magic_file_p):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1118 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1119 (x_get_local_selection, x_reply_selection_request)
1120 (x_handle_selection_request, wait_for_property_change):
1121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1122 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1123 short is wide enough.
1124 (x_send_client_event): Don't assume fixnum fits in int.
1125 * xterm.c (x_x_to_emacs_modifiers):
1126 Don't assume EMACS_INT overflows nicely into int.
1127 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1128 may come from Lisp.
1129 (handle_one_xevent): NATNUMP can eval its arg twice.
1130 (x_connection_closed):
1131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1132 * xterm.h: Adjust decls to match defn changes elsewhere.
1133 (struct scroll_bar): Use struct vectorlike_header
1134 rather than rolling our own approximation.
1135 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1136
c6574eb5
GM
11372012-05-25 Glenn Morris <rgm@gnu.org>
1138
1139 * lisp.mk (lisp): Update for more files being compiled now.
1140
e8d32c7e
SM
11412012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1142
48def666
SM
1143 * lread.c: Remove `read_pure' which makes no difference.
1144 (read_pure): Remove var.
1145 (unreadpure): Remove function.
1146 (readevalloop): Don't call read_list with -1 flag.
1147 (read1, read_vector): Don't test read_pure any more.
1148 (read_list): Simplify.
1149
e8d32c7e
SM
1150 * fileio.c, character.h: Minor style tweaks.
1151
4b2addb7
DA
11522012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1153
1154 * window.h (clip_changed): Remove useless declaration.
1155
584461b2
JB
11562012-05-22 Juanma Barranquero <lekktu@gmail.com>
1157
1158 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1159 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1160
34374650
PE
11612012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 Remove src/m/*.
1164 This directory predates autoconf and is no longer needed nowadays.
1165 Move its few remaining bits of functionality to where they're needed.
1166 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1167 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1168 * m/template.h: Remove.
1169 * Makefile.in (M_FILE): Remove. All uses removed.
1170 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1171 * lisp.h (USE_LSB_TAG):
1172 * mem-limits.h (EXCEEDS_LISP_PTR):
1173 Use VAL_MAX, not VALBITS, in #if.
1174 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1175 (EMACS_UINT): Define unconditionally now.
1176 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1177 (BITS_PER_EMACS_INT): New constants, replacing
1178 what used to be in config.h, but not useful in #if.
1179 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1180 define them any more.
1181 (VAL_MAX): New macro.
1182 (VALMASK): Use it.
1183 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1184 BITS_PER_EMACS_INT, in #if.
1185 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1186 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1187 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1188 * s/ms-w32.h (DATA_START):
1189 Move here from removed file m/intel386.h.
1190 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1191 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1192
261cb4bb
PE
11932012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 Assume C89 or later.
1196 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1197 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1198 (xrealloc):
1199 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1200 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1201 * textprop.c, tparam.c (NULL): Remove.
1202 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1203 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1204 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1205 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1206 * xterm.c (input_signal_count): Assume volatile works.
1207
ff23cd9f
KB
12082012-05-21 Ken Brown <kbrown@cornell.edu>
1209
1210 * xgselect.c (xg_select): Fix first argument in call to 'select'
1211 (bug#11508).
1212
1b170bc6
KB
12132012-05-20 Ken Brown <kbrown@cornell.edu>
1214
1215 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1216 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1217
b2f4d39f
KB
12182012-05-19 Ken Brown <kbrown@cornell.edu>
1219
1220 * xfns.c (x_in_use): Remove `static' qualifier.
1221 * xterm.h (x_in_use): Declare.
1222 * xgselect.c: Include xterm.h.
1223 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1224 and `display_arg' (bug#9754).
1225
003fdae2
PE
12262012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1227
9232a6d9
PE
1228 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1229
003fdae2
PE
1230 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1231 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1232
784b56e2
EZ
12332012-05-18 Eli Zaretskii <eliz@gnu.org>
1234
1235 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1236
1237 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1238 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1239
1240 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1241 reference to image_cache->refcount.
1242 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1243
a0a79cde
JL
12442012-05-17 Juri Linkov <juri@jurta.org>
1245
1246 * search.c (Fword_search_regexp, Fword_search_backward)
1247 (Fword_search_forward, Fword_search_backward_lax)
1248 (Fword_search_forward_lax): Move functions to isearch.el
1249 (bug#10145, bug#11381).
1250
b0572523
PE
12512012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1254
9660f5fc
SM
12552012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1256
1257 * lread.c (init_obarray): Declare Qt and Qnil as special.
1258
4374de83
GM
12592012-05-14 Glenn Morris <rgm@gnu.org>
1260
1261 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1262 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1263
dc44c39a
PE
12642012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1265
078c97cb
PE
1266 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1267
dc44c39a
PE
1268 * unexaix.c: Port to more-recent AIX compilers.
1269 (report_error, report_error_1, make_hdr, copy_sym)
1270 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1271 Make arguments const char *, not char *, to avoid violations of C
1272 standard and to fix some AIX warnings reported by Gilles Pion.
1273
e18afed7 12742012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1275
1276 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1277 already have overlays loaded.
1278 (handle_single_display_spec): Before returning without displaying
1279 fringe bitmap, synchronize the bidi iterator with the main display
1280 iterator, by calling iterate_out_of_display_property.
1281 (iterate_out_of_display_property): Detect buffer iteration by
1282 testing that it->string is a Lisp string.
1283 (get_next_display_element): When the current object is exhausted,
1284 and there's something on it->stack, call set_iterator_to_next to
1285 proceed with what's on the stack, instead of returning zero.
1286 (set_iterator_to_next): If called at the end of a Lisp string,
1287 proceed to consider_string_end without incrementing string
1288 position. Don't increment display vector index past the end of
1289 the display vector. (Bug#11417)
c8fb9dc6
EZ
1290 (pos_visible_p): Don't report a position visible when move_it_to
1291 stopped at the last line of window, which happens to be scanned
1292 backwards by the bidi iteration. (Bug#11464)
ac268e67 1293
e18afed7 12942012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1295
1296 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1297 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1298 are on a TTY, and thus unable to display on the fringes.
1299 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1300 so we need to signal to the caller that this is a "replacing"
1301 display spec. This fixes display when the spec is invalid or we
1302 are on a TTY.
1303
e18afed7 13042012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1305
1306 * unexaix.c (make_hdr): Fix typo in prototype.
1307 This bug broke the build on AIX. Problem reported by Gilles Pion.
1308
9d0a235a
MA
13092012-05-14 Michael Albinus <michael.albinus@gmx.de>
1310
1311 * keyboard.c (kbd_buffer_get_event): Read special events also in
1312 batch mode. (Bug#11415)
1313
9e6b06ed
GM
13142012-05-12 Glenn Morris <rgm@gnu.org>
1315
1316 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1317
c1a1d7a3
EZ
13182012-05-12 Eli Zaretskii <eliz@gnu.org>
1319
1320 * lisp.mk (lisp): Add newcomment.elc.
1321
3fe7cdc8
GM
13222012-05-12 Glenn Morris <rgm@gnu.org>
1323
1324 * Makefile.in (MKDIR_P): New, set by configure.
1325 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1326
53f7d2c0
PE
13272012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 Remove unused function hourglass_started.
1330 * dispextern.h (hourglass_started):
1331 * w32fns.c (hourglass_started):
1332 * xdisp.c (hourglass_started): Remove.
1333
75aafb17
JB
13342012-05-10 Juanma Barranquero <lekktu@gmail.com>
1335
1336 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1337 Update dependencies.
1338
12959e8e
PE
13392012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1340
97107e2e
PE
1341 * xgselect.c (xg_select): Put maxfds+1 into a var.
1342 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1343
12959e8e
PE
1344 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1345
836d29b3
DA
13462012-05-10 Dave Abrahams <dave@boostpro.com>
1347
1348 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1349 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1350
5cb67954
MA
13512012-05-09 Michael Albinus <michael.albinus@gmx.de>
1352
1353 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1354 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1355 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1356 Initialize xd_registered_buses.
1357
3478ec45
PE
13582012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1359
b263a6b0
PE
1360 Untag more efficiently if USE_LSB_TAG.
1361 This is based on a proposal by YAMAMOTO Mitsuharu in
1362 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1363 For an admittedly artificial (nth 8000 longlist) benchmark on
1364 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1365 Emacs's overall text size by 1%.
1366 * lisp.h (XUNTAG): New macro.
1367 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1368 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1369 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1370 * eval.c (Fautoload):
1371 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1372 * frame.h (XFRAME): Use XUNTAG.
1373
3478ec45
PE
1374 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1375 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1376 Remove unportable assumptions about print widths of types like
1377 dbus_uint32_t.
1378 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1379 intptr_t when converting between pointer and integer, to avoid GCC
1380 warnings about wrong width.
1381
666b903b 13822012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1383
1384 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1385 stack for each reader_thread, instead of defaulting to 8MB
1386 determined by the linker. This avoids failures in creating
1387 subprocesses on Windows 7, see the discussion in this thread:
1388 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1389
b120cc17
JC
13902012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1391
1392 Fix up display of the *Minibuf-0* buffer in the mini window.
1393 * keyboard.c (read_char): Don't clear the echo area if there's no
1394 message to clear.
1395 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1396 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1397
9a4b36f8
MA
13982012-05-07 Michael Albinus <michael.albinus@gmx.de>
1399
1400 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1401 batch mode.
1402
e5f9458f
CY
14032012-05-06 Chong Yidong <cyd@gnu.org>
1404
1405 * lisp.mk (lisp): Update.
1406
eceeb5fc 14072012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1408
1409 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1410
71873e2b
SM
14112012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1412
1413 * data.c (PUT_ERROR): New macro.
1414 (syms_of_data): Use it. Add new error type `user-error'.
1415 * undo.c (user_error): New function.
1416 (Fprimitive_undo): Use it.
1417 * print.c (print_error_message): Adjust print style for `user-error'.
1418 * keyboard.c (user_error): New function.
1419 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1420
ab0fa4e4
PE
14212012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 Do not limit current-time-string to years 1000..9999.
1424 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1425 (Fcurrent_time_string): Support any year that is supported by the
1426 underlying localtime representation. Don't use asctime, as it
1427 has undefined behavior for years outside the range -999..9999.
1428
7ed806a7
PE
14292012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1430
1431 Fix race conditions involving setenv, gmtime, localtime, asctime.
1432 Without this fix, interrupts could mess up code that uses these
1433 nonreentrant functions, since setting TZ invalidates existing
1434 tm_zone or tzname values, and since most of these functions return
1435 pointers to static storage.
1436 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1437 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1438 Grow the critical sections to include not just invoking
1439 localtime/gmtime, but also accessing these functions' results
1440 including their tm_zone values if any, and any related TZ setting.
1441 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1442 so that the struct tm is saved in the critical section.
1443 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1444 motivated by the fact that memory allocation needs to be outside
1445 the critical section.
1446
0c16dfed
DA
14472012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1448
1449 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1450 with RESET_INTERVAL.
1451
1452 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1453 Remove duplicated buffer name initialization.
1454
3f83ace8
JM
14552012-05-02 Jim Meyering <jim@meyering.net>
1456
1457 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1458
c7b8541e
JM
1459 * xfns.c (x_window): Use xstrdup (Bug#11375).
1460
90207a15 14612012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1462
1463 * xdisp.c (pos_visible_p): If already at a newline from the
1464 display string before the 'while' loop, don't walk back the glyphs
1465 from it3.glyph_row. Solves assertion violation when the display
1466 string begins with a newline (egg.el). (Bug#11367)
1467
b593d6a9
AH
14682012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1469
1470 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1471 Move to simple.el.
1472
4737362e
GM
14732012-05-01 Glenn Morris <rgm@gnu.org>
1474
99cf43f9
GM
1475 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1476 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1477 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1478 All were removed before 23.1.
1479
9311dcff
GM
1480 * dispnew.c: Remove HAVE_LIBNCURSES test;
1481 it is always true on relevant platforms.
1482
4d5c6349
GM
1483 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1484 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1485
4737362e
GM
1486 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1487
74dd3a6b
AS
14882012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1489
1490 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1491 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1492 Remove.
1493
13c379ee
PE
14942012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 Do not avoid creating empty evaporating overlays (Bug#9642).
1497 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1498 That is, do not delete an evaporating overlay if it becomes
1499 empty after its bounds are adjusted to fit within its buffer.
1500 This fix caused other problems, and I'm reverting it until we get
1501 to the bottom of them.
1502
a8e7d6d7 15032012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1504
1505 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1506
a8e7d6d7 15072012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1508
1509 * xdisp.c (pos_visible_p): If the window start position is beyond
1510 ZV, start the display from buffer beginning. Prevents assertion
1511 violation in init_iterator when the minibuffer window is scrolled
1512 via the scroll bar.
1513
1514 * window.c (window_scroll_pixel_based): Likewise.
1515
a8e7d6d7 15162012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1517
1518 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1519
a8e7d6d7 15202012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1521
1522 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1523 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1524
a8e7d6d7 15252012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1526
b593d6a9
AH
1527 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1528 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1529
1c6900d9
EZ
15302012-04-26 Eli Zaretskii <eliz@gnu.org>
1531
4c3fa1d9
EZ
1532 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1533 display element, check also the underlying string or buffer
1534 character. (Bug#11341)
1535
1c6900d9
EZ
1536 * w32menu.c: Include w32heap.h.
1537 (add_menu_item): If the call to AppendMenuW (via
1538 unicode_append_menu) fails, disable Unicode menus only if we are
1539 running on Windows 9X/Me.
1540
42bf8205
AS
15412012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1542
1543 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1544 (xgetint): Add missing shift for LSB tags.
1545
b1bac16e
MR
15462012-04-24 Martin Rudalics <rudalics@gmx.at>
1547
1548 * keyboard.c (read_char): Don't wipe echo area for select window
1549 events: These might get delayed via `mouse-autoselect-window'
1550 (Bug#11304).
1551
d69621cc
JB
15522012-04-24 Juanma Barranquero <lekktu@gmail.com>
1553
1554 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1555 manipulation of :loaded-from data.
1556
02fd101b
JB
15572012-04-23 Juanma Barranquero <lekktu@gmail.com>
1558
1559 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1560 now a cons (bug#11311).
1561
888bec30
PE
15622012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1563
89a438bd
PE
1564 Do not create empty overlays with the evaporate property (Bug#9642).
1565 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1566 if it becomes empty after its bounds are adjusted to fit within
1567 its buffer. Without this fix, in a nonempty buffer (let ((o
1568 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1569 yields an empty overlay that has the evaporate property, which is
1570 not supposed to happen.
1571
1068fe4d
PE
1572 Fix minor GTK3 problems found by static checking.
1573 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1574 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1575 (struct _EmacsFixedClass, emacs_fixed_get_type):
1576 Move decls here from emacsgtkfixed.h, since they needn't be public.
1577 (emacs_fixed_get_type): Now static.
1578 (emacs_fixed_class_init): Omit unused local.
1579 (emacs_fixed_child_type): Remove; unused.
1580 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1581 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1582 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1583 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1584 (EMACS_FIXED_GET_CLASS): Remove; unused.
1585 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1586
888bec30
PE
1587 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1588 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1589
de85e130
PE
15902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1591
d0baac98 1592 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1593 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1594 (__malloc_size_t, __malloc_ptrdiff_t):
1595 Remove. All uses removed, replaced by the definiens if needed,
1596 since we can assume C89 or better now.
1597 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1598 (protect_malloc_state, align, get_contiguous_space)
1599 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1600 (malloc_atfork_handler_child, malloc_enable_thread)
1601 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1602 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1603 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1604 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1605 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1606 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1607 Define using prototypes, not old style.
1608 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1609 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1610 (align): Don't assume that signed integer overflow wraps around.
1611 Omit unused local var.
1612 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1613 (_free_internal_nolock, memalign, mallochook, reallochook):
1614 Omit no-longer-needed casts.
1615 (valloc): Use getpagesize, not __getpagesize.
1616 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1617 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1618
de85e130
PE
1619 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1620
dcbf5805
MA
16212012-04-22 Michael Albinus <michael.albinus@gmx.de>
1622
1623 Move functions from C to Lisp. Make non-blocking method calls
1624 the default. Implement further D-Bus standard interfaces.
1625
1626 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1627 (QCdbus_request_name_allow_replacement)
1628 (QCdbus_request_name_replace_existing)
1629 (QCdbus_request_name_do_not_queue)
1630 (QCdbus_request_name_reply_primary_owner)
1631 (QCdbus_request_name_reply_in_queue)
1632 (QCdbus_request_name_reply_exists)
1633 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1634 (QCdbus_registered_serial, QCdbus_registered_method)
1635 (QCdbus_registered_signal): New Lisp objects.
1636 (XD_DEBUG_MESSAGE): Use sizeof.
1637 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1638 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1639 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1640 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1641 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1642 (xd_signature, xd_append_arg): Allow float for integer types.
1643 (xd_get_connection_references): New function.
b593d6a9
AH
1644 (xd_get_connection_address): Rename from xd_initialize.
1645 Return cached address.
dcbf5805
MA
1646 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1647 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1648 level.
1649 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1650 Return number of refcounts.
dcbf5805
MA
1651 (Fdbus_get_unique_name): Make stronger parameter check.
1652 (Fdbus_message_internal): New defun.
1653 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1654 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1655 (Fdbus_send_signal, Fdbus_register_service)
1656 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1657 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1658 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1659 (Vdbus_compiled_version, Vdbus_runtime_version)
1660 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1661 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1662 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1663 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1664 Adapt docstring.
dcbf5805 1665
52828e02
PE
16662012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1667
da05bc4c
PE
1668 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1669 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1670 Do not assume ptrdiff_t is the same width as 'int'.
1671
52828e02
PE
1672 * alloc.c: Handle unusual debugging option combinations.
1673 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1674 since the two debugging options are incompatible.
1675 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1676 is defined.
1677 (mem_init, mem_insert, mem_insert_fixup):
1678 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1679 (NEED_MEM_INSERT): Remove; no longer needed.
1680
f01769f9
LL
16812012-04-22 Leo Liu <sdl.web@gmail.com>
1682
1683 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1684
5790543d
PE
16852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1686
1687 * sysdep.c [__FreeBSD__]: Minor cleanups.
1688 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1689 Use Emacs indenting style more consistently. Avoid some casts.
1690 Use 'double' consistently rather than mixing 'float' and 'double'.
1691
b91b7e4d
EW
16922012-04-21 Eduard Wiebe <usenet@pusto.de>
1693
b593d6a9
AH
1694 * sysdep.c (list_system_processes, system_process_attributes):
1695 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1696
6114eb15
AS
16972012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1698
1699 * lisp.mk (lisp): Update.
1700
2f38dff7
PE
17012012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1704 It is never used otherwise.
1705
4ae29f89
SM
17062012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1707
1708 * print.c (print_preprocess): Only check print_depth if print-circle
1709 is nil.
1710 (print_object): Check for cycles even when print-circle is nil and
1711 print-gensym is t, but only check print_depth if print-circle is nil.
1712
f30d612a
CY
17132012-04-20 Chong Yidong <cyd@gnu.org>
1714
1715 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1716 set the status to "failed" and ensure that sentinel is run.
1717
c07a4c0b 17182012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1719
1720 * process.c (Fset_process_inherit_coding_system_flag)
1721 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1722 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1723
c07a4c0b 17242012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1725
1726 * xdisp.c (string_buffer_position_lim): Limit starting position to
1727 BEGV.
1728 (set_cursor_from_row): If called for a mode-line or header-line
1729 row, return zero immediately.
1730 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1731 farther than the first row after the header line, if any.
1732 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1733 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1734
c07a4c0b 17352012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1736
4ae29f89
SM
1737 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1738 (bug#11238).
ad3a2b41 1739
c07a4c0b 17402012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 17412012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1742
1743 configure: new option --enable-gcc-warnings (Bug#11207)
1744 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1745 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1746 (ALL_CFLAGS): Use new macros rather than old.
1747 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1748 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1749 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1750 -Wunused-result, -Wunused-variable. This should go away once
1751 the Emacs and Gnulib regex code is merged.
1752 (xmalloc, xrealloc): Now static.
1753
aba027e8
PE
17542012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1755
1756 * dired.c (Fsystem_groups): Remove unused local.
1757
e5a36063
GM
17582012-04-17 Glenn Morris <rgm@gnu.org>
1759
1760 * dired.c (Fsystem_users): Doc fix.
1761
316411f0
DA
17622012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1763
1764 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1765 (syms_of_dired): Add them.
1766
9426aba4
PE
17672012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1768
b62a57be
PE
1769 Fix minor alloc.c problems found by static checking.
1770 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1771 New extern decls, to avoid calling undeclared functions.
1772 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1773 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1774 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1775 (NEED_MEM_INSERT): New macro.
1776 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1777 Remove one incorrect comment and fix another.
b62a57be 1778
3539f31f
PE
1779 Fix minor ralloc.c problems found by static checking.
1780 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1781 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1782 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1783 (r_alloc_sbrk): Now static.
1784
a041960a
PE
1785 Improve ralloc.c interface checking.
1786 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1787 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1788 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1789 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1790 [REL_ALLOC]: ... to here, to check interface.
1791 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1792 Remove decls. This fixes an "It stinks!".
1793
9426aba4
PE
1794 * alloc.c (which_symbols): Fix alignment issue / type clash.
1795
d55c12ed
AS
17962012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1797
1798 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1799 (struct Lisp_Misc_Any): Likewise.
1800 (struct Lisp_Free): Likewise.
1801 * alloc.c (union aligned_Lisp_Symbol): Define.
1802 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1803 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1804 (union aligned_Lisp_Misc): Define.
1805 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1806 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1807 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1808
b948ce8b
PE
18092012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1812 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1813 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1814 * s/netbsd.h, s/sol2-6.h:
1815 Remove definition of GC_MARK_STACK, since the default now works.
1816 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1817 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1818 no longer the default.
1819 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1820
35dc09a1 18212012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1822
35dc09a1
GM
1823 * lread.c (lisp_file_lexically_bound_p):
1824 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1825
35dc09a1
GM
18262012-04-14 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1829 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1830
18312012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1832
1833 * nsterm.m (constrainFrameRect): Always constrain when there is only
1834 one screen (Bug#10962).
1835
bcd86815
KB
18362012-04-13 Ken Brown <kbrown@cornell.edu>
1837
1838 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1839
c25df26e
RT
18402012-04-13 Reuben Thomas <rrt@sc3d.org>
1841
1842 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1843
0fc59f1e
DC
18442012-04-11 Daniel Colascione <dancol@dancol.org>
1845
1846 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1847 against is gone. It's better to use vfork now so that when Cygwin
1848 gains a new, working vfork, we use it automatically (bug#10398).
1849
de8c03dc
SM
18502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1851
1852 * window.c (save_window_save): Obey window-point-insertion-type.
1853
2f097256
GM
18542012-04-11 Glenn Morris <rgm@gnu.org>
1855
1856 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1857
453b951e
SM
18582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1859
1860 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1861
75f1671a 18622012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1863
1864 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1865 (force_quit_count): New var.
1866 (handle_interrupt): Use it.
1867
2a8ce227
JB
18682012-04-10 Juanma Barranquero <lekktu@gmail.com>
1869
1870 * w32.c (w32_delayed_load): Record the full path of the library
1871 being loaded (bug#10424).
1872
935396c0
GM
18732012-04-09 Glenn Morris <rgm@gnu.org>
1874
05920a43
GM
1875 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1876 not just in the obarray, before snarfing them. (Bug#11036)
1877
935396c0
GM
1878 * Makefile.in ($(leimdir)/leim-list.el):
1879 Pass EMACS rather than BUILT_EMACS.
1880
a18ecafa
TZ
18812012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1882
1883 * process.c (make_process):
1884 * process.h: Add integer `gnutls_handshakes_tried' member to
1885 process struct.
1886
6bbef4e5
JC
1887 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1888 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1889
1890 * gnutls.c (gnutls_log_function2i): Convenience log function.
1891 (emacs_gnutls_read): Use new log functions,
1892 `gnutls_handshakes_tried' process member, and
1893 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1894 attempts per process (connection).
1895
b4d3bc10
CY
18962012-04-09 Chong Yidong <cyd@gnu.org>
1897
1898 * eval.c (Fuser_variable_p, user_variable_p_eh)
1899 (lisp_indirect_variable): Functions deleted.
1900 (Fdefvar): Caller changed.
1901
1902 * callint.c (Finteractive, Fcall_interactively):
1903 * minibuf.c (Fread_variable): Callers changed.
1904
70f4d973
EZ
19052012-04-09 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (set_cursor_from_row): If the display string appears in
1908 the buffer at position that is closer to point than the position
1909 after the display string, display the cursor on the first glyph of
1910 the display string. Fixes cursor display when a 'display' text
1911 property immediately follows invisible text. (Bug#11094)
1912
cb3c2e3e
PE
19132012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 composite.c: use 'double' consistently
1916 * composite.c (get_composition_id): Use 'double' consistently
1917 instead of converting 'float' to 'double' and vice versa; this is
1918 easier to understand and avoids a GCC warning.
1919
fd06db5d
GM
19202012-04-09 Glenn Morris <rgm@gnu.org>
1921
50fe702a
GM
1922 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1923 preparation for dumping it with emacs. (Bug#4789)
1924 (leimdir): New variable.
1925 ($(leimdir)/leim-list.el): New rule.
1926 (emacs$(EXEEXT)): Depend on leim-list.el.
1927
fd06db5d
GM
1928 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1929 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1930 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1931
55c131ee
AS
19322012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1933
1934 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1935 proper alignment.
1936
9209588f
JB
19372012-04-07 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1940 Remove unused local variable.
1941
e3fb2efb
PE
19422012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1945 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1946 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1947 objects, as mark_maybe_pointer will catch them otherwise.
1948 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1949 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1950
b5385551
PE
19512012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 Fix typo that broke non-Windows builds.
1954 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1955
9078ead6
EZ
19562012-04-07 Eli Zaretskii <eliz@gnu.org>
1957
1958 Support building on MS-Windows with libxml2.
1959
1960 * makefile.w32-in (OBJ2): Add xml.$(O).
1961 (GLOBAL_SOURCES): Add xml.c.
1962 ($(BLD)/xml.$(O)): New dependency list.
1963
1964 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1965 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1966 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1967 [!WINDOWSNT]: New macros.
1968 (init_libxml2_functions, libxml2_loaded_p): New functions.
1969 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1970 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1971 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1972 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1973 linked in).
6bbef4e5
JC
1974 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1975 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1976 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1977
1978 * emacs.c: Don't include libxml/parser.h.
1979 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1980 xmlCleanupParser directly.
1981
1982 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1983
3811fdf3
EZ
19842012-04-07 Eli Zaretskii <eliz@gnu.org>
1985
1986 * indent.c (Fvertical_motion): If there is a display string at
1987 point, use it.vpos to compute how many lines to backtrack after
1988 move_it_to point. (Bug#11133)
1989
2f8e16b2
EZ
19902012-04-06 Eli Zaretskii <eliz@gnu.org>
1991
1992 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1993 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1994 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1995 macros related to unification of CJK characters. For the details,
1996 see the discussion following the message here:
1997 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1998
3d439cd1
CY
19992012-04-04 Chong Yidong <cyd@gnu.org>
2000
2001 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2002
8bc53d00
EZ
20032012-04-01 Eli Zaretskii <eliz@gnu.org>
2004
2005 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2006 instead of alloca. (Bug#11138)
2007
3b0512a3
AS
20082012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2009
2010 * w32menu.c (is_simple_dialog): Properly check lisp types.
2011 (Bug#11141)
2012
8427ddd2
EZ
20132012-03-31 Eli Zaretskii <eliz@gnu.org>
2014
979022ef
EZ
2015 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2016 position we get to after a call to move_it_to fails the
2017 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2018 only if we wind up in a string from display property. (Bug#11063)
2019
a6b1c7cc
EZ
2020 * window.c (Fdelete_other_windows_internal): Invalidate the row
2021 and column information about mouse highlight, so that redisplay
2022 restores it after reallocating the glyph matrices. (Bug#7464)
2023
8427ddd2
EZ
2024 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2025 string comes from a `display' text property, use the buffer
2026 position of that property as if we actually saw that position in
2027 the row's glyphs.
697ba24b
EZ
2028 (move_it_by_lines): Remove the assertion that
2029 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2030 violated when there's a before-string at the beginning of a line.
2031 (Bug#11063)
8427ddd2 2032
65a0a738
EZ
20332012-03-30 Eli Zaretskii <eliz@gnu.org>
2034
2035 * xdisp.c (append_space_for_newline): If the default face was
2036 remapped, use the remapped face for the appended newline.
2037 (extend_face_to_end_of_line): Use the remapped default face for
2038 extending the face to the end of the line.
2039 (display_line): Call extend_face_to_end_of_line when the default
2040 face was remapped. (Bug#11068)
2041
581355cc
EZ
20422012-03-29 Eli Zaretskii <eliz@gnu.org>
2043
2044 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2045
e8fc049f
SM
20462012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2047
2048 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2049
4fb9a543
GM
20502012-03-27 Glenn Morris <rgm@gnu.org>
2051
2052 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2053 Doc fixes.
2054
679910f1
KH
20552012-03-26 Kenichi Handa <handa@m17n.org>
2056
2057 * dispextern.h (struct glyph): Fix previous change. Change the
2058 bit length of glyphless.ch to 25 (Bug#11082).
2059
90d49b7f
CY
20602012-03-26 Chong Yidong <cyd@gnu.org>
2061
2062 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2063 (command_loop_1): Use it; inhibit selection update for
2064 handle-select-window too (Bug#8996).
2065
f514f6f0
FP
20662012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2067
e8fc049f 2068 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2069
bf43fa51
KH
20702012-03-25 Kenichi Handa <handa@m17n.org>
2071
2072 * dispextern.h (struct glyph): Change the bit length of
2073 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2074
8a0c01dd
EZ
20752012-03-24 Eli Zaretskii <eliz@gnu.org>
2076
2077 * s/ms-w32.h (tzname): Include time.h before redirecting to
2078 _tzname. Fixes the MSVC build. (Bug#9960)
2079
7d1c3a76
AS
20802012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2081
8ed79523
AS
2082 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2083 characters.
2084
7d1c3a76
AS
2085 * xterm.c (XTread_socket): Only modify handling_signal if
2086 !SYNC_INPUT. (Bug#11080)
2087
e99a9b8b
EZ
20882012-03-23 Eli Zaretskii <eliz@gnu.org>
2089
2090 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2091 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2092 when fetching a multibyte character consumes more bytes than
2093 CHAR_BYTES returns, due to unification of CJK characters in
2094 string_char. (Bug#11073)
2095
5063c0e1
TN
20962012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2097
2098 * process.c (wait_reading_process_output): Handle pty disconnect
2099 by refraining from sending oneself a SIGCHLD (bug#10933).
2100
9f851fbd
CY
21012012-03-22 Chong Yidong <cyd@gnu.org>
2102
2103 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2104
5063c0e1 2105 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2106 Mark string as coming from a prefix property.
2107 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2108 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2109
fb5b8aca
CY
21102012-03-21 Chong Yidong <cyd@gnu.org>
2111
2112 * xfaces.c (Vface_remapping_alist): Doc fix.
2113
62356a1b
EZ
21142012-03-20 Eli Zaretskii <eliz@gnu.org>
2115
2116 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2117 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2118 Doc fixes.
62356a1b 2119
025de85b
CY
21202012-03-20 Chong Yidong <cyd@gnu.org>
2121
2122 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2123 to reflect default non-nil value of redisplay-dont-pause.
2124
4827f94e
KH
21252012-03-19 Kenichi Handa <handa@m17n.org>
2126
2127 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2128 it fit in a valid range (Bug#11003).
2129
e50a24a2
EZ
21302012-03-18 Eli Zaretskii <eliz@gnu.org>
2131
2132 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2133 that is not from display property, accept the row as a "cursor
2134 row" if one of the string's character has a non-nil `cursor'
2135 property. Fixes cursor positioning when there are newlines in
2136 overlay strings, e.g. in icomplete.el. (Bug#11035)
2137
9af5ed87
PE
21382012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2141
d1f55f16
CY
21422012-03-12 Chong Yidong <cyd@gnu.org>
2143
2144 * eval.c (inhibit_lisp_code): Rename from
2145 inhibit_window_configuration_change_hook; move from window.c.
2146
2147 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2148 * window.c (run_window_configuration_change_hook)
2149 (syms_of_window): Callers changed.
2150
66c5eebd
CY
21512012-03-11 Chong Yidong <cyd@gnu.org>
2152
413df973
CY
2153 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2154
66c5eebd
CY
2155 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2156
1de11f56
CY
21572012-03-10 Chong Yidong <cyd@gnu.org>
2158
2159 * frame.c (other_visible_frames): Don't assume the selected frame
2160 is visible (Bug#10955).
2161
cae07000
SM
21622012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2163
2164 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2165
89c94350
JD
21662012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2169 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2170 zero (Bug#10954).
2171
999dd333
GM
21722012-03-03 Glenn Morris <rgm@gnu.org>
2173
01a6dcc8 2174 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2175
de0100f2
EZ
21762012-03-02 Eli Zaretskii <eliz@gnu.org>
2177
2178 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2179 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2180 (redisplay_window, next_element_from_string): Fix typos in
2181 comments.
3e441275
EZ
2182 (redisplay_window): Pass to move_it_vertically the margin in
2183 pixels, not in screen lines.
de0100f2 2184
96a72ee9
GM
21852012-03-02 Glenn Morris <rgm@gnu.org>
2186
2187 * buffer.c (buffer-list-update-hook): Doc fix.
2188
312508d7
EZ
21892012-02-29 Eli Zaretskii <eliz@gnu.org>
2190
2191 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2192 push_it before setting up the iterator for the first overlay
2193 string, even if we have an empty string loaded.
2194 (next_overlay_string): If there's an empty string on the iterator
2195 stack, pop the stack. (Bug#10903)
2196
27f3c637
PE
21972012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2200 Suggested by Stefan Monnier in
2201 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2202 * alloc.c (widen_to_Lisp_Object): New static function.
2203 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2204 and widening them to Lisp_Objects. This would work even if
2205 USE_LSB_TAG is defined and wide integers are used, which might
2206 happen in a future version of Emacs.
2207
3c9dfce6
CY
22082012-02-25 Chong Yidong <cyd@gnu.org>
2209
fa74b241
CY
2210 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2211 Doc fix.
2212
3c9dfce6
CY
2213 * xselect.c (Fx_selection_exists_p): Doc fix.
2214 (x_clipboard_manager_save_all): Print an informative message
2215 before saving to clipboard manager.
2216
9486df08
CY
22172012-02-24 Chong Yidong <cyd@gnu.org>
2218
2219 * keyboard.c (process_special_events): Handle all X selection
2220 requests in kbd_buffer, not just the next one (Bug#8869).
2221
f01d3321
CY
22222012-02-23 Chong Yidong <cyd@gnu.org>
2223
2224 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2225 call when setting menu-bar-lines and tool-bar-lines parameters.
2226 (unwind_create_frame_1): New helper function.
2227
2228 * window.c (inhibit_window_configuration_change_hook): New var.
2229 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2230 (syms_of_window): Initialize it.
f01d3321 2231
86b847b6
CY
22322012-02-22 Chong Yidong <cyd@gnu.org>
2233
2234 * xterm.c (x_draw_image_relief): Add missing type check for
2235 Vtool_bar_button_margin (Bug#10743).
2236
a59225b1
CY
22372012-02-21 Chong Yidong <cyd@gnu.org>
2238
2239 * fileio.c (Vfile_name_handler_alist): Doc fix.
2240
2241 * buffer.c (Fget_file_buffer): Protect against invalid file
2242 handler return value.
2243
310f5bd4
PE
22442012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2245
cb3a28cc
PE
2246 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2247 when computing $valmask.
2248
310f5bd4
PE
2249 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2250 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2251 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2252 It's useless in that case, and it can cause problems on hosts
2253 that allocate halves of EMACS_INT values separately.
2254 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2255 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2256 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2257 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2258 it avoids undefined behavior on hosts where shifting right by more
2259 than the word width has undefined behavior.
2260
2375c96a
CY
22612012-02-19 Chong Yidong <cyd@gnu.org>
2262
2263 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2264 (Funhandled_file_name_directory, Ffile_name_as_directory)
2265 (Fdirectory_file_name, Fexpand_file_name)
2266 (Fsubstitute_in_file_name): Protect against invalid file handler
2267 return values (Bug#10845).
2268
3eb49e71
EZ
22692012-02-18 Eli Zaretskii <eliz@gnu.org>
2270
2271 * .gdbinit (pitx): Fix incorrect references to fields of the
2272 iterator stack.
2273
7b926f3f
CY
22742012-02-17 Chong Yidong <cyd@gnu.org>
2275
2276 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2277
11273115
PE
22782012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2281 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2282
c3a70e2b
CY
22832012-02-15 Chong Yidong <cyd@gnu.org>
2284
2285 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2286 marked as special. Also, starting docstrings with * is obsolete.
2287
0ca43699
AS
22882012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2289
2290 * gnutls.c (emacs_gnutls_write): Fix last change.
2291
2e8f3c56
LI
22922012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2293
2294 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2295 send_process.
2296
af70074f
SM
22972012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2298
2299 * keymap.c (Fsingle_key_description): Handle char ranges.
2300
95986d52
CY
23012012-02-12 Chong Yidong <cyd@gnu.org>
2302
afd83bd1
CY
2303 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2304 as that creates a dangerous corner case.
2305
95986d52
CY
2306 * window.c (Fdelete_window_internal): Invalidate the mouse
2307 highlight (Bug#9904).
2308
bd7da63e
GM
23092012-02-12 Glenn Morris <rgm@gnu.org>
2310
2311 * xselect.c (Fx_own_selection_internal)
2312 (Fx_get_selection_internal, Fx_disown_selection_internal)
2313 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2314 * nsselect.m (Fx_own_selection_internal)
2315 (Fx_disown_selection_internal, Fx_selection_exists_p)
2316 (Fx_selection_owner_p, Fx_get_selection_internal):
2317 Sync docs and argument specs with the xselect.c versions.
2318
77abcbc2
LI
23192012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2320
2321 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2322
90b671e2
EZ
23232012-02-11 Eli Zaretskii <eliz@gnu.org>
2324
1c0ca0b7
EZ
2325 * w32select.c (Fx_selection_exists_p): Sync doc string and
2326 argument list with xselect.c. (Bug#10783)
2327
2328 * w16select.c (Fx_selection_exists_p): Sync doc string and
2329 argument list with xselect.c. (Bug#10783)
90b671e2 2330
49241268
GM
23312012-02-10 Glenn Morris <rgm@gnu.org>
2332
2333 * fns.c (Fsecure_hash): Doc fix.
2334
f998bbe7 23352012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2336
2337 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2338
0992bd9c
CY
23392012-02-07 Chong Yidong <cyd@gnu.org>
2340
2341 * buffer.c (Fbuffer_local_variables)
2342 (buffer_lisp_local_variables): Handle unbound vars correctly;
2343 don't let Qunbound leak into Lisp.
2344
af008560
GM
23452012-02-07 Glenn Morris <rgm@gnu.org>
2346
dd605cc4
GM
2347 * image.c (Fimagemagick_types): Doc fix.
2348
af008560
GM
2349 * image.c (imagemagick-render-type): Change it from a lisp object
2350 to an integer. Move the doc here from the lisp manual.
2351 Treat all values not equal to 0 the same.
2352
1449fa1d
CY
23532012-02-06 Chong Yidong <cyd@gnu.org>
2354
2355 * doc.c (store_function_docstring): Avoid applying docstring of
2356 alias to base function (Bug#2603).
2357
3723ec07
AS
23582012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2359
2360 * .gdbinit (pp1, pv1): Remove redundant defines.
2361 (pr): Use pp.
2362
79c1cc1e
CY
23632012-02-04 Chong Yidong <cyd@gnu.org>
2364
2365 * nsterm.m: Declare a global (Bug#10694).
2366
d7f29f8e
EZ
23672012-02-04 Eli Zaretskii <eliz@gnu.org>
2368
cae07000
SM
2369 * w32.c (get_emacs_configuration_options):
2370 Include --enable-checking, if specified, in the return value.
d7f29f8e 2371
3b95a6f9
MR
23722012-02-04 Martin Rudalics <rudalics@gmx.at>
2373
2374 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2375 after rounding frame sizes. (Bug#9723)
2376
d6fa96a6
EZ
23772012-02-04 Eli Zaretskii <eliz@gnu.org>
2378
2379 * keyboard.c (adjust_point_for_property): Don't position point
2380 before BEGV. (Bug#10696)
2381
df0b2940
PE
23822012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 Handle overflow when computing char display width (Bug#9496).
2385 * character.c (char_width): Return EMACS_INT, not int.
2386 (char_width, c_string_width): Check for overflow when
2387 computing the width; this is possible now that individual
2388 characters can have unbounded width. Problem introduced
2389 by merge from Emacs 23 on 2012-01-19.
2390
6bee44d6
MA
23912012-02-02 Michael Albinus <michael.albinus@gmx.de>
2392
2393 * dbusbind.c (Fdbus_register_method): Mention the return value
2394 :ignore in the docstring.
2395
44f92739
GM
23962012-02-02 Glenn Morris <rgm@gnu.org>
2397
1b9f60cc
GM
2398 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2399
44f92739
GM
2400 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2401 Unconditionally set to t. (Bug#10673)
2402 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2403 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2404 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2405
c5d3843c
KH
24062012-02-02 Kenichi Handa <handa@m17n.org>
2407
2408 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2409 0, do not call append_composite_glyph.
2410
159462d4 24112012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2412
2413 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2414 NULL (Bug#6988).
2415 (x_produce_glyphs): If the component of a composition is a null
2416 string, set it->pixel_width to 1 to avoid zero-width glyph.
2417
78cef877
EZ
24182012-02-01 Eli Zaretskii <eliz@gnu.org>
2419
2420 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2421 first 2 arguments are identical. This makes inserting large
2422 output from a subprocess an order of magnitude faster on
2423 MS-Windows, where all sbrk'ed memory is always contiguous.
2424
97897668
GM
24252012-01-31 Glenn Morris <rgm@gnu.org>
2426
2427 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2428 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2429 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2430
31fd3586
GM
24312012-01-29 Glenn Morris <rgm@gnu.org>
2432
2433 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2434
0e24a8b2
CY
24352012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2436
2437 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2438
cc0adcb0
CY
24392012-01-28 Chong Yidong <cyd@gnu.org>
2440
2441 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2442
acc28cb9
CY
24432012-01-26 Chong Yidong <cyd@gnu.org>
2444
9c69cfb7
CY
2445 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2446
acc28cb9
CY
2447 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2448 repeat counts (Bug#10507).
2449
48da7392
GM
24502012-01-26 Glenn Morris <rgm@gnu.org>
2451
2452 * lread.c (syms_of_lread): Doc fix.
2453
14af5f7f
CY
24542012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2455
2456 * coding.c (encode_designation_at_bol): Change return value to
2457 EMACS_INT.
2458
0b21c100
CY
24592012-01-25 Chong Yidong <cyd@gnu.org>
2460
2461 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2462
3c2907f7
CY
24632012-01-21 Chong Yidong <cyd@gnu.org>
2464
2465 * floatfns.c (Fcopysign): Make the second argument non-optional,
2466 since nil is not allowed anyway.
2467
959ad23f
AS
24682012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2469
2470 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2471 (send_process): Likewise.
2472
34a02f46
MR
24732012-01-19 Martin Rudalics <rudalics@gmx.at>
2474
2475 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2476 (Vwindow_persistent_parameters): Do not use Qstate.
2477 Rewrite doc-strings.
34a02f46 2478
1259009a 24792012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2480
2481 * character.c (char_width): New function.
70d4fdf6
GM
2482 (Fchar_width, c_string_width, lisp_string_width):
2483 Use char_width (Bug#9496).
25ed9e61 2484
6a6ee00d
MR
24852012-01-16 Martin Rudalics <rudalics@gmx.at>
2486
2487 * window.c (Vwindow_persistent_parameters): New variable.
2488 (Fset_window_configuration, save_window_save): Handle persistent
2489 window parameters.
2490
c85efaf7
EZ
24912012-01-14 Eli Zaretskii <eliz@gnu.org>
2492
2493 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2494 thrashing the stack of the thread. (Bug#9087)
2495
5944709e
PE
24962012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2497
2498 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2499
e71f5d99
EZ
25002012-01-11 Eli Zaretskii <eliz@gnu.org>
2501
2502 * xdisp.c (rows_from_pos_range): Handle the case where the
2503 highlight ends on a newline. (Bug#10464)
2504 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2505 he end column for display of highlight that ends on a newline
2506 before a R2L line.
2507
ce316182
GM
25082012-01-11 Glenn Morris <rgm@gnu.org>
2509
2510 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2511 from load-path also when installation-directory is nil. (Bug#10208)
2512
5b43da69
GM
25132012-01-10 Glenn Morris <rgm@gnu.org>
2514
74cc8ff9
GM
2515 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2516
7d8d6e4e
GM
2517 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2518 Update template values to be closer to their typical values these days.
5b43da69 2519
a0db8d43
EZ
25202012-01-09 Eli Zaretskii <eliz@gnu.org>
2521
2522 * xdisp.c (rows_from_pos_range): Accept additional argument
2523 DISP_STRING, and accept any glyph in a row whose object is that
2524 string as eligible for mouse highlight. Fixes mouse highlight of
2525 display strings from overlays. (Bug#10464)
2526
9a0115ab 25272012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2528
b9110d6a 2529 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2530 * fileio.c (auto_saving_dir_umask): New static var.
2531 (Fmake_directory_internal): Use it.
2532 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2533 creating the directory. The old code temporarily assigns
2534 too-generous permissions to the directory.
2535 (do_auto_save_eh): Clear it.
b9110d6a 2536 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2537 that the var is always cleared.
2538
6c1bd3f3
EZ
25392012-01-07 Eli Zaretskii <eliz@gnu.org>
2540
2541 * search.c (scan_buffer): Pass character positions to
2542 know_region_cache, not byte positions. (Bug#6540)
2543
069d2b50
L
25442012-01-07 LynX <_LynX@bk.ru> (tiny change)
2545
2546 * w32.c (sys_rename): Report EXDEV when rename of a directory
2547 fails because the target is on another logical disk. (Bug#10284)
2548
75bf0d33
DB
25492012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2550
2551 * xterm.c (x_embed_request_focus): New function.
2552
2553 * xterm.h: Add prototype.
2554
2555 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2556
1c6e5a32
GM
25572012-01-05 Glenn Morris <rgm@gnu.org>
2558
2559 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2560
651e947e
EZ
25612012-01-01 Eli Zaretskii <eliz@gnu.org>
2562
2563 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2564 Load gnutls_transport_set_lowat only if GnuTLS version is below
2565 2.11.1.
2566 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2567 GnuTLS versions below 2.11.1.
2568
3778cdd8
AL
25692011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2570
2571 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2572 to the doc string advising against its use for altering the way
2573 windows are scrolled.
2574
0e5317f7
KH
25752011-12-28 Kenichi Handa <handa@m17n.org>
2576
2577 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2578 coding-system ASCII compatible only when it does not produce BOM
2579 on encoding (Bug#10383).
2580
93d5ca1f
JD
25812011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2582
2583 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2584 can scroll.
2585 (create_and_show_popup_menu): Always use menu_position_func for
2586 Gtk3 (Bug#10361).
2587
ca22b785
AS
25882011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2589
2590 * callint.c (Fcall_interactively): Don't truncate prompt string.
2591
d048e1e6
EZ
25922011-12-23 Eli Zaretskii <eliz@gnu.org>
2593
2594 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2595 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2596 resumed from there (after widening). (Bug#10360)
d048e1e6 2597
5ccaba1f
JD
25982011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2599
2600 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2601
204ee57f
JD
26022011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2603
b81d40f0
JB
2604 * nsterm.m (x_free_frame_resources):
2605 Release f->output_data.ns->miniimage.
204ee57f
JD
2606 (ns_index_color): Fix indentation. Do not retain
2607 color_table->colors[i].
2608
2609 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2610 before returning.
2611
2612 * nsfns.m (x_set_background_color): Assign return value from
2613 ns_index_color to face-background instead of NSColor*.
2614 (ns_implicitly_set_icon_type): Fix indentation.
2615 Change assignment in for loop to comparison.
2616
2617 * emacs.c (ns_pool): New variable.
2618 (main): Assign ns_pool.
2619 (Fkill_emacs): Call ns_release_autorelease_pool.
2620
2621 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2622 autorelease fdesc, release fdAttrs and tdict.
2623 (ns_get_covering_families): Release charset.
2624 (ns_findfonts): Release NSFontDescriptor created with new.
2625 (ns_uni_to_glyphs): Fix indentation.
2626 (setString): Release attrStr before assigning new value.
2627
c803b2b7
JD
26282011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2629
678f4426
JD
2630 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2631 and NS_IMPL_COCOA.
2632 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2633 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2634
cd394be1 26352011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2636
5fecd5fc
JD
2637 * nsterm.m (ns_term_init): Subscribe for notifications
2638 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2639 to method trackingNotification in EmacsMenu.
2640
2641 * nsmenu.m (trackingMenu): New variable.
3771cb17 2642 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2643 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2644 from Aquamacs (Bug#7030).
678f4426
JD
2645
26462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2647
c803b2b7
JD
2648 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2649 (symbol_to_nsstring): Fix indentation.
2650 (ns_symbol_to_pb): New function.
cae07000
SM
2651 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2652 (Fns_rotate_cut_buffers_internal): Remove.
2653 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2654 Fns_store_cut_buffer_internal.
2655 (ns_get_foreign_selection, Fx_own_selection_internal)
2656 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2657 (Fns_get_selection_internal, Fns_store_selection_internal):
2658 Use ns_symbol_to_pb and check if return value is nil.
2659 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2660 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2661 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2662 renamed to Sns_store_selection_internal.
2663 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2664 and remove this function.
2665 (ns_handle_selection_clear): Remove, never used.
2666 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2667 here.
2668
e1b01a3a
KB
26692011-12-17 Ken Brown <kbrown@cornell.edu>
2670
2671 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2672 GID is unknown (Bug#10257).
2673
2adb6e85
PE
26742011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2675
2676 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2677 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2678 which caused a build failure on GNU/Linux IA-64. This problem was
2679 introduced by my 2011-10-07 patch.
2680
d1d7b339
JL
26812011-12-15 Juri Linkov <juri@jurta.org>
2682
2683 * image.c (imagemagick_error): New function. (Bug#10112)
2684 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2685 Use `imagemagick_error' where ImageMagick functions return
2686 `MagickFalse'.
2687 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2688 proper order.
2689
100d5755
KH
26902011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2691
2692 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2693 fill background (Bug#8992).
2694
454592a6
MR
26952011-12-13 Martin Rudalics <rudalics@gmx.at>
2696
2697 * window.c (Vwindow_combination_resize)
2698 (Vwindow_combination_limit): Use t instead of non-nil in
2699 doc-strings.
61d4b438
MR
2700 (Vrecenter_redisplay): Add first sentence of doc-string on
2701 separate line.
53524d93 2702 (Frecenter): Fix doc-string typo.
454592a6 2703
3633e3aa
KH
27042011-12-11 Kenichi Handa <handa@m17n.org>
2705
2706 * coding.c (Funencodable_char_position): Pay attention to the
2707 buffer text relocation (Bug#9389).
2708
7b9d523a 27092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2710
7b9d523a
JD
2711 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2712 gtk_init (Bug#10100).
2713
b73189c6
EZ
27142011-12-10 Eli Zaretskii <eliz@gnu.org>
2715
2716 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2717 IT->string is nil. (Bug#10263)
2718
f7dfe5d6
JD
27192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2720
83faebb4
JD
2721 * nsterm.h (x_free_frame_resources): Declare.
2722
f7dfe5d6
JD
2723 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2724 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2725
2726 * nsterm.h (ns_get_defaults_value): Declare.
2727
2728 * nsterm.m (ns_default): Call ns_get_defaults_value.
2729
7cd4e72c
EZ
27302011-12-09 Eli Zaretskii <eliz@gnu.org>
2731
2732 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2733 (Bug#10170)
2734
b34d7317
YM
27352011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2736
2737 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2738 that where the value of an _OBJC_* symbol points to is in the .bss
2739 section (Bug#10240).
2740
76470ad1
KH
27412011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2742
2743 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2744 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2745
745fff94
KH
27462011-12-08 Kenichi Handa <handa@m17n.org>
2747
2748 * ftfont.c (get_adstyle_property): Fix previous change
2749 (Bug#10233).
2750
6e44397c
JB
27512011-12-07 Juanma Barranquero <lekktu@gmail.com>
2752
2753 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2754 dirs from the default value of EMACSLOADPATH (bug#10208).
2755
7efa6272
GM
27562011-12-07 Glenn Morris <rgm@gnu.org>
2757
2758 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2759 installation and source directories as well. (Bug#10208)
2760
f6fc4d87
CY
27612011-12-06 Chong Yidong <cyd@gnu.org>
2762
2763 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2764
2bf26180
GM
27652011-12-06 Glenn Morris <rgm@gnu.org>
2766
2767 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2768 as an error, not just -1. (Bug#10217)
2769
3a6ad4f0
CY
27702011-12-05 Chong Yidong <cyd@gnu.org>
2771
2772 * keyboard.c (process_special_events): New function.
2773 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2774
75a3b399
PE
27752011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2776
2777 * coding.c (encode_designation_at_bol): Don't use uninitialized
2778 local variable (Bug#9318).
2779
c3c9e25e
KH
27802011-12-05 Kenichi Handa <handa@m17n.org>
2781
2782 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2783 return Qnil (Bug#8046, Bug#10193).
2784
5eb05ea3
KH
27852011-12-05 Kenichi Handa <handa@m17n.org>
2786
2787 * coding.c (encode_designation_at_bol): New args charbuf_end and
2788 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2789 (coding_set_source): Return how many bytes coding->source was
2790 relocated.
2791 (coding_set_destination): Return how many bytes
2792 coding->destination was relocated.
2793 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2794 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2795
27962011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2797
2798 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2799 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2800 macro (Bug#9318).
2801
28022011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2803
2804 The following changes are to fix Bug#9318.
2805
a79703f5 2806 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2807 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2808 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2809 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2810
7dbda6df
JB
28112011-12-05 Juanma Barranquero <lekktu@gmail.com>
2812
2813 * lisp.h (process_quit_flag): Fix external declaration.
2814
6d5eb5b0
SM
28152011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2816
2817 Don't macro-inline non-performance-critical code.
2818 * eval.c (process_quit_flag): New function.
2819 * lisp.h (QUIT): Use it.
2820
a0c3fad0
JD
28212011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2822
2823 * nsfns.m (get_geometry_from_preferences): New function.
2824 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2825
6c07aac2
AS
28262011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2827
2828 * emacs.c (Qkill_emacs): Define.
2829 (syms_of_emacs): Initialize it.
2830 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2831 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2832 (quit_throw_to_read_char): Add parameter `from_signal'.
2833 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2834 * lisp.h (QUIT): Call Fkill_emacs if requested.
2835
c052ead4
JD
28362011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2837
2838 * widget.c (update_wm_hints): Return if wmshell is null.
2839 (widget_update_wm_size_hints): New function.
2840
2841 * widget.h (widget_update_wm_size_hints): Declare.
2842
2843 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2844 widget_update_wm_size_hints (Bug#10104).
2845
9e49252b
EZ
28462011-12-03 Eli Zaretskii <eliz@gnu.org>
2847
2848 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2849 before a newline, prepare the bidi iterator for consuming the
2850 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2851 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2852
02b16839
JL
28532011-12-02 Juri Linkov <juri@jurta.org>
2854
2855 * search.c (Fword_search_regexp): New Lisp function created from
2856 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2857 (Fword_search_backward, Fword_search_forward)
2858 (Fword_search_backward_lax, Fword_search_forward_lax):
2859 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2860 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2861
0068070e
SM
28622011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2863
2864 * fileio.c (Finsert_file_contents): Move after-change-function call
2865 to before the "handled:" label, since all "goto handled" appear in
2866 cases where the *-change-functions have already been properly called
2867 (bug#10117).
2868
3360a3fc
AS
28692011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2870
2871 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2872 waiting for input. (Bug#10169)
2873
73d6c093
EZ
28742011-11-30 Eli Zaretskii <eliz@gnu.org>
2875
2876 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2877 verifies glyph row's hash code--we have just reallocated the
2878 glyphs, so their contents can be complete garbage. (Bug#10164)
2879
febe6bea
JB
28802011-11-30 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2883
801a4313
EZ
28842011-11-30 Eli Zaretskii <eliz@gnu.org>
2885
2886 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2887 attributes are tested _before_ calling verify_row_hash, to protect
2888 against GCC re-ordering of the tests. (Bug#10164)
2889
2b56b87e
JD
28902011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2891
2892 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2893
2894 * xterm.c (handle_one_xevent): Only set async_visible and friends
2895 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2896 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2897 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2898
dbf31225
PE
28992011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2900
2901 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2902 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2903 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2904 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2905 All uses changed to use GCPRO1 etc.
2906 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2907 Revert to old implementation (i.e., before 2011-03-11).
2908
1305621b
YM
29092011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2910
2911 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2912 of scroll runs so as to avoid assigning disabled bogus rows and
2913 unnecessary graphics copy operations.
2914
8c9afb46
EZ
29152011-11-27 Eli Zaretskii <eliz@gnu.org>
2916
2917 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2918 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2919 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2920 (malloc, free, realloc, calloc): Redirect to e_* only when
2921 compiling Emacs.
2922
2923 * lisp.h (GCTYPEBITS): Move before first use.
2924 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2925 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2926 this macro definition.
2927
2928 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2929 _MSC_VER.
2930
54e9e3bf
JD
29312011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2932
6d5eb5b0
SM
2933 * gtkutil.c (xg_create_frame_widgets):
2934 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2935 present with Gtk+ 2.0.
2936
83aca1cb
PE
29372011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2938
2939 * fileio.c (Finsert_file_contents): Undo previous change; see
2940 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2941
5b76caa4
PE
29422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 Rename locals to avoid shadowing.
2945 * fileio.c (Finsert_file_contents):
2946 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2947 * process.c (wait_reading_process_output):
2948 Rename inner 'proc' to 'p' to avoid shadowing.
2949 Indent for consistency with usual Emacs style.
2950
8c535114
EZ
29512011-11-25 Eli Zaretskii <eliz@gnu.org>
2952
2953 * xdisp.c (redisplay_window): If cursor row is not fully visible
2954 after recentering, and scroll-conservatively is set to a large
2955 number, scroll window by a few more lines to make the cursor fully
2956 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2957 (start_display): Don't move to the next line if the display should
2958 start at a newline that is part of a display vector or an overlay
2959 string. (Bug#10119)
8c535114 2960
fa4fdb5c
JL
29612011-11-24 Juri Linkov <juri@jurta.org>
2962
2963 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2964 after the `MagickPingImage' call. (Bug#10112)
2965
90ec88df
CY
29662011-11-23 Chong Yidong <cyd@gnu.org>
2967
2968 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2969
56e2e794
MR
29702011-11-23 Martin Rudalics <rudalics@gmx.at>
2971
2972 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2973 making another buffer current. (Bug#10114)
2974
b6e64c41
GM
29752011-11-23 Glenn Morris <rgm@gnu.org>
2976
2977 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2978
6b21de18
CY
29792011-11-23 Chong Yidong <cyd@gnu.org>
2980
2981 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2982 using it (Bug#5984).
2983
b12cd789
EZ
29842011-11-22 Eli Zaretskii <eliz@gnu.org>
2985
2986 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2987 and header-lines, as they don't have one computed for them.
2988 (Bug#10098)
2989
2990 * .gdbinit (prow): Make displayed values more self-explaining.
2991 Add row's hash code.
2992
261b6fd4
LMI
29932011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2994
2995 * process.c (wait_reading_process_output): Fix asynchrounous
2996 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2997 (wait_reading_process_output): Add comment and URL.
261b6fd4 2998
e7cfd277
JD
29992011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3000
3001 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3002
a9b9b7f5
CY
30032011-11-21 Chong Yidong <cyd@gnu.org>
3004
3005 * window.c (Fnext_window, Fprevious_window): Doc fix.
3006
b0d15b4f
SM
30072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3008
3009 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3010
fe7a3057
JB
30112011-11-20 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3014
d2999b1a
MR
30152011-11-20 Martin Rudalics <rudalics@gmx.at>
3016
3017 * window.c (Fset_window_combination_limit): Rename argument
3018 STATUS to LIMIT.
3019 (Vwindow_combination_limit): Remove "status" from doc-string.
3020
d5ff9cd0
AS
30212011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3022
3023 * m/ibms390.h: Remove.
3024 * m/ibms390x.h: Don't include "ibms390.h".
3025
a5bb9bd3
SM
30262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3027
3028 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3029 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3030
cd1181db
JB
30312011-11-20 Juanma Barranquero <lekktu@gmail.com>
3032
3033 * casetab.c (Fset_case_table):
3034 * charset.c (Fcharset_after): Fix typos.
3035
615a3b8d 30362011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3037
17e845af
PE
3038 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3039 Otherwise, valgrind does not work on some platforms.
3040 Problem reported by Andreas Schwab in
6a0bf43d
PE
3041 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3042 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3043 is set, removing the need for VIRT_ADDRESS_VARIES.
3044 (PURE_P): Use a more-efficient implementation that needs just one
3045 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3046 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3047 to 4 (xorl, subq, cmpq, setbe).
3048 * alloc.c (pure): Always extern now, since that's the
3049 VIRT_ADDR_VARIES behavior.
3050 (PURE_POINTER_P): Use a single comparison, not two, for
3051 consistency with the new puresize.h.
3052 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3053 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3054 Remove VIRT_ADDR_VARIES no longer needed.
3055
f8fe6f96
EZ
30562011-11-19 Eli Zaretskii <eliz@gnu.org>
3057
3058 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3059 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3060 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3061 behave as if the cursor position were at the window margin.
3062
3063 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3064 and the cursor position is out of bounds, behave as if the cursor
3065 position were at the window margin. (Bug#10075)
3066
df05a53c
CY
30672011-11-18 Chong Yidong <cyd@gnu.org>
3068
3069 * window.c (Fwindow_combination_limit): Make first argument
3070 non-optional, since it is meaningless for live windows like the
3071 selected window.
61ccba97 3072
2071918e
DA
30732011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3074
3075 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3076
b50a28de
SM
30772011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3078
3079 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3080 (graft_intervals_into_buffer): Simplify.
3081
015137db
EZ
30822011-11-18 Eli Zaretskii <eliz@gnu.org>
3083
3084 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3085 hash values of the two rows.
3086 (copy_row_except_pointers): Preserve the used[] arrays and the
3087 hash values of the two rows. (Bug#10035)
68c95424 3088 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3089
3090 * xdisp.c (row_hash): New function, body extracted from
3091 compute_line_metrics.
3092 (compute_line_metrics): Call row_hash, instead of computing the
3093 hash code inline.
3094
3095 * dispnew.c (verify_row_hash): Call row_hash for computing the
3096 hash code of a row, instead of duplicating code from xdisp.c.
3097
3098 * dispextern.h (row_hash): Add prototype.
3099
a2addb04
TH
31002011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3101
3102 * frame.c (delete_frame): Don't delete the terminal when the last
3103 X frame is closed if emacs is built with GTK toolkit.
3104
df85d315
JB
31052011-11-17 Juanma Barranquero <lekktu@gmail.com>
3106
3107 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3108
a0c2d0ae
MR
31092011-11-17 Martin Rudalics <rudalics@gmx.at>
3110
3111 * window.c (Vwindow_splits): Rename to
3112 Vwindow_combination_resize. Suggested by Juri Linkov.
3113 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3114 of Vwindow_splits.
3115
58179cce
JB
31162011-11-16 Juanma Barranquero <lekktu@gmail.com>
3117
7877f373
JB
3118 * nsfns.m (Fns_font_name):
3119 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3120
b6f67890
MR
31212011-11-16 Martin Rudalics <rudalics@gmx.at>
3122
3123 * window.h (window): Rename slot "nest" to "combination_limit".
3124 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3125 (Fset_window_nest): Rename to Fset_window_combination_limit.
3126 (Vwindow_nest): Rename to Vwindow_combination_limit.
3127 (recombine_windows, make_parent_window, make_window)
3128 (Fsplit_window_internal, saved_window)
3129 (Fset_window_configuration, save_window_save): Rename all
3130 occurrences of window_nest to window_combination_limit.
3131
c7015153
JB
31322011-11-15 Juanma Barranquero <lekktu@gmail.com>
3133
3134 * image.c (imagemagick_load_image): Fix typo.
3135
322ad6ec
EZ
31362011-11-14 Eli Zaretskii <eliz@gnu.org>
3137
3138 * xdisp.c (display_line): Move the call to
3139 highlight_trailing_whitespace before the call to
3140 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3141 faces of all the glyphs to compute ROW's hash value.
3142 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3143
f067b8ec
JB
31442011-11-14 Juanma Barranquero <lekktu@gmail.com>
3145
3146 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3147 just return (bug#10044).
3148
1e5b2111
EZ
31492011-11-12 Eli Zaretskii <eliz@gnu.org>
3150
7ef3cbd5
EZ
3151 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3152 with user-defined heap size. Bump the default size of the temacs
3153 heap to 27MB, to avoid memory warning when running temacs.
3154 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3155
1e5b2111
EZ
3156 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3157 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3158 (verify_row_hash) [XASSERTS]: New function.
3159 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3160 that the hash value of glyph rows is correct.
1e5b2111 3161
89d61221
MR
31622011-11-12 Martin Rudalics <rudalics@gmx.at>
3163
3164 * window.h (window): Remove splits slot.
3165 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3166 (Fdelete_other_windows_internal, make_parent_window)
3167 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3168 (Fset_window_configuration, save_window_save): Don't deal with
3169 split status of windows.
3170 (saved_window): Remove splits slot.
3171 (Vwindow_splits): Rewrite doc-string.
3172
97f18cc8
JD
31732011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3174
3175 * xfns.c (unwind_create_frame):
3176 * nsfns.m (unwind_create_frame):
3177 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3178 Vframe_list (Bug#9999).
3179
22a648b4
DA
31802011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3181
0b381c7e 3182 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3183
659afede
KH
31842011-11-11 Kenichi Handa <handa@m17n.org>
3185
3186 * callproc.c (Fcall_process): Set the member dst_multibyte of
3187 process_coding.
3188
9ac0394b
KH
31892011-11-11 Johan Bockgård <bojohan@gnu.org>
3190
3191 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3192 avoid a crash (bug#9496).
3193
2fbdc249
CY
31942011-11-09 Chong Yidong <cyd@gnu.org>
3195
3196 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3197 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3198
ac6b1f81
PE
31992011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3200
3201 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3202
09db192c
PE
32032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 Avoid some portability problems by eschewing 'extern inline' functions.
3206 The trivial performance wins aren't worth the portability hassles; see
3207 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3208 et seq.
3209 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3210 (window_box_width, window_box_left, window_box_left_offset)
3211 (window_box_right, window_box_right_offset): Undo previous change,
3212 by removing the "extern"s.
3213 * intervals.c (adjust_intervals_for_insertion)
3214 (adjust_intervals_for_deletion): Undo previous change,
3215 making these static again.
3216 (offset_intervals, temp_set_point_both, temp_set_point)
3217 (copy_intervals_to_string): No longer inline.
3218 * xdisp.c (window_text_bottom_y, window_box_width)
3219 (window_box_height, window_box_left_offset)
3220 (window_box_right_offset, window_box_left, window_box_right)
3221 (window_box): No longer inline.
3222
105216ed
CY
32232011-11-08 Chong Yidong <cyd@gnu.org>
3224
3225 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3226 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3227 Signal an error if not a live window.
105216ed
CY
3228 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3229 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3230
ae9e237f
JB
32312011-11-07 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * lisp.h (syms_of_abbrev): Remove declaration.
3234 Reported by CHENG Gao <chenggao@royau.me>.
3235
c7aa8333
EZ
32362011-11-07 Eli Zaretskii <eliz@gnu.org>
3237
3238 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3239 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3240 of temacs in GUI mode.
3241
be7f5545
MR
32422011-11-07 Martin Rudalics <rudalics@gmx.at>
3243
3244 * window.h: Declare delete_all_child_windows instead of
3245 delete_all_subwindows.
3246 * window.c (Fwindow_nest, Fset_window_nest)
3247 (Fset_window_new_total, Fset_window_new_normal)
3248 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3249 (delete_all_subwindows): Rename to delete_all_child_windows.
3250 (Fdelete_other_windows_internal, Fset_window_configuration):
3251 Call delete_all_child_windows instead of delete_all_subwindows.
3252 * frame.c (delete_frame): Call delete_all_child_windows instead
3253 of delete_all_subwindows.
3254
ca78dc43
PE
32552011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3256
3257 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3258 This is also needed for porting to any host where GC_MARK_STACK is
3259 not GC_MAKE_GCPROS_NOOPS.
3260 (which_symbols): Use it.
3261
a0241d01
KH
32622011-11-07 Kenichi Handa <handa@m17n.org>
3263
3264 * coding.c (coding_set_destination): Check coding->src_pos only
3265 when coding->src_object is a buffer (bug#9910).
3266
3267 * process.c (send_process): Set the member src_multibyte of coding
3268 to 0 (bug#9911) when sending a unibyte text.
3269
3270 * callproc.c (Fcall_process): Set the member src_multibyte of
3271 process_coding to 0 (bug#9912).
3272
a64bfdfa 32732011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3274
3275 * xmenu.c (cleanup_widget_value_tree): New function.
3276 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3277 calling free_menubar_widget_value_tree directly (Bug#9830).
3278
cb41b32a
PE
32792011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 Fix some portability problems with 'inline'.
3282 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3283 (window_box_width, window_box_left, window_box_left_offset)
3284 (window_box_right, window_box_right_offset): Declare extern.
3285 Otherwise, these inline functions do not conform to C99 and
3286 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3287 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3288 * intervals.c (adjust_intervals_for_insertion)
3289 (adjust_intervals_for_deletion): Now extern, because otherwise the
3290 extern inline functions 'offset_intervals' couldn't refer to it.
3291 (static_offset_intervals): Remove.
3292 (offset_intervals): Rewrite using the old contents of
3293 static_offset_intervals. The old version didn't conform to C99
3294 because an extern inline function contained a reference to an
3295 identifier with static linkage.
3296
b7041366
AS
32972011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3298
3299 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3300 GC.
3301
88a37c4d
EZ
33022011-11-06 Eli Zaretskii <eliz@gnu.org>
3303
3304 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3305 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3306 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3307 return Qleft_to_right.
3308
49745b39
CY
33092011-11-06 Chong Yidong <cyd@gnu.org>
3310
3311 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3312 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3313 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3314 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3315 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3316 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3317 (Fwindow_vscroll): Doc fix.
3318 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3319 argument, since it makes no sense to pass a live window and for
3320 consistency with window-child.
3321
1f05cd82
CS
33222011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3323
3324 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3325 support MSVC.
3326
22610910
JR
33272011-11-05 Jason Rumney <jasonr@gnu.org>
3328
3329 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3330 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3331 fonts (Bug#6029).
3332 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3333 bitwise arithmetic preventing use of unicode-sip and non-truetype
3334 opentype fonts.
3335
a06776b2
EZ
33362011-11-05 Eli Zaretskii <eliz@gnu.org>
3337
3ad924ba
EZ
3338 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3339 "emacs"-only part.
3340
a06776b2
EZ
3341 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3342 initialization code to keep similarity to xfns.c after changes
3343 from 2011-11-05.
3344
c9e7db78
JD
33452011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3346
a97f8f3f
JD
3347 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3348 (unwind_create_frame): New function (Bug#9943).
3349 (Fx_create_frame): Restructure code to be more similar to the one in
3350 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3351 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3352 Move terminal->reference_count++ just before making the frame official
3353 (Bug#9943).
3354
3355 * nsterm.m (x_free_frame_resources): New function.
3356 (x_destroy_window): Move code to x_free_frame_resources.
3357
c9e7db78 3358 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3359 (Fx_create_frame, x_create_tip_frame):
3360 Move terminal->reference_count++ just before making the frame
75f1671a 3361 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3362 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3363
a6fc3b5c
EZ
33642011-11-05 Eli Zaretskii <eliz@gnu.org>
3365
3366 Support MSVC build with newer versions of Visual Studio.
3367 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3368 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3369 nt/gmake.defs.
3370
3371 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3372 which are not supported by MSVC.
3373 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3374 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3375 bitfields.
3376 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3377 types in bitfields.
3378 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3379
3380 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3381
58179cce 33822011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3383
3384 Support MSVC build with newer versions of Visual Studio.
3385 * w32.c: Don't include w32api.h for MSVC.
3386 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3387
3388 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3389 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3390 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3391 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3392 e_* cousins.
3393 (alloca) [_MSC_VER]: Define to _alloca.
3394
3395 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3396
3397 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3398
a58c13ed
EZ
33992011-11-04 Eli Zaretskii <eliz@gnu.org>
3400
3401 * xdisp.c (note_mouse_highlight): If either of
3402 previous/next-single-property-change returns nil, treat that as
3403 the beginning or the end of the buffer. (Bug#9955)
3404
fe0b6370
JD
34052011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3406
a58c13ed 3407 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3408 label is not null (Bug#9951).
3409 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3410 may be NULL.
3411
89bd5ee1
EZ
34122011-11-04 Eli Zaretskii <eliz@gnu.org>
3413
3414 * window.c (Fwindow_body_size): Mention in the doc string that the
3415 return value is in frame's canonical units. (Bug#9949)
3416
84c3edb9
EZ
34172011-11-03 Eli Zaretskii <eliz@gnu.org>
3418
4e2fb5c7
EZ
3419 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3420
84c3edb9 3421 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3422 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3423 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3424
bc17a887
EZ
34252011-11-01 Eli Zaretskii <eliz@gnu.org>
3426
3427 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3428 Don't stop backward scan on the continuation glyph, even though
3429 its CHARPOS is positive.
6d5eb5b0
SM
3430 (mouse_face_from_buffer_pos, note_mouse_highlight):
3431 Rename cover_string to disp_string.
bc17a887 3432
4ee88440
MR
34332011-11-01 Martin Rudalics <rudalics@gmx.at>
3434
3435 * window.c (temp_output_buffer_show): Don't use
3436 Vtemp_buffer_show_specifiers.
3437 (Vtemp_buffer_show_specifiers): Remove unused variable.
3438
c2ff3c02
EZ
34392011-10-30 Eli Zaretskii <eliz@gnu.org>
3440
3441 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3442 past the beginning of the current glyph matrix.
3443
58179cce 34442011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3445
3446 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3447 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3448 HAVE_GTK3 (Bug#9869).
b77a6a7f 3449
3b574623
JD
3450 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3451 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3452
b77a6a7f
JD
3453 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3454
3455 * xterm.c: Declare x_handle_net_wm_state to return int.
3456 (handle_one_xevent): Check if we are iconified but don't have
3457 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3458 (get_current_wm_state): Return non-zero if not hidden,
3459 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3460 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3461 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3462 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3463
196e41e4
PE
34642011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3465
3466 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3467 so that this new function doesn't get optimized away by a
3468 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3469
021f2e1a
AS
34702011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3471
3472 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3473
8b058d44
EZ
34742011-10-29 Eli Zaretskii <eliz@gnu.org>
3475
3476 Fix the `xbytecode' command.
3477 * .gdbinit (xprintbytestr): New command.
b50a28de 3478 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3479 (xbytecode): Print the byte-code string as well.
3480
4452fb80
EZ
34812011-10-29 Kim Storm <storm@cua.dk>
3482
8b058d44
EZ
3483 * alloc.c (which_symbols): New function.
3484
21b72067
AS
34852011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3486
3487 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3488 line. (Bug#9903)
3489
83ed7b5c
GM
34902011-10-29 Glenn Morris <rgm@gnu.org>
3491
3492 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3493 Not clear what it was for, and it causes various bugs. (Bug#9839)
3494
5a7a728b
EZ
34952011-10-28 Eli Zaretskii <eliz@gnu.org>
3496
3497 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3498 possible random value that matches one of those tested as
3499 condition to clear the mouse face.
3500
d3d0842f
CY
35012011-10-28 Chong Yidong <cyd@gnu.org>
3502
3503 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3504
31b39d13
DN
35052011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3506
3507 * window.c (make_window): Initialize phys_cursor_on_p.
3508
9aba6043
SM
35092011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3510
3511 * lisp.h (struct Lisp_Symbol): Update comments.
3512
c20992f4
JB
35132011-10-28 Juanma Barranquero <lekktu@gmail.com>
3514
3515 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3516
db4f02f2
EZ
35172011-10-28 Eli Zaretskii <eliz@gnu.org>
3518
3519 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3520 <oslsachem@gmail.com> for helping to debug this.
3521
3522 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3523 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3524 (g_b_init_get_glyph_outline_w): New static variables.
3525 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3526 (GetGlyphOutlineW_Proc): New typedefs.
3527 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3528 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3529 New functions.
3530 (w32font_open_internal, compute_metrics):
3531 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3532 instead of calling the "wide" APIs directly.
3533
3534 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3535
3536 * w32.h (syms_of_w32font): Add prototype.
3537
87e68db4
JB
35382011-10-27 Juanma Barranquero <lekktu@gmail.com>
3539
3540 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3541 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3542 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3543 (Fmove_to_window_line): Doc fix.
3544
435c1d67
CY
35452011-10-27 Chong Yidong <cyd@gnu.org>
3546
3547 * process.c (make_process): Set gnutls_state to NULL.
3548
3549 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3550 non-NULL, regardless of GNUTLS_INITSTAGE.
3551 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3552 an error. Set process slots as soon as we allocate them.
3553
3554 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3555
9c6c6f49
CY
35562011-10-27 Chong Yidong <cyd@gnu.org>
3557
9aba6043
SM
3558 * gnutls.c (emacs_gnutls_deinit): New function.
3559 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3560 (Fgnutls_deinit, Fgnutls_boot): Use it.
3561
3562 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3563 (deactivate_process): Call emacs_gnutls_deinit.
3564
657d08d3
JB
35652011-10-27 Juanma Barranquero <lekktu@gmail.com>
3566
3567 * image.c (x_create_x_image_and_pixmap):
3568 * w32.c (sys_rename, w32_delayed_load):
3569 * w32font.c (fill_in_logfont):
3570 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3571
5430d399
JB
35722011-10-26 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * w32fns.c (w32_default_color_map): New function,
3575 extracted from Fw32_default_color_map.
a7ef684b 3576 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3577
fe0055fa
PE
35782011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3579
3580 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3581
e6346438
SM
35822011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3583
3584 * keyboard.c (test_undefined): New function (bug#9751).
3585 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3586
e112cc37
ET
35872011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3588
3589 * sysdep.c (init_sys_modes): Fix the check for the controlling
3590 terminal (Bug#6649).
3591
7b5d6677
EZ
35922011-10-20 Eli Zaretskii <eliz@gnu.org>
3593
3594 * dispextern.h (struct bidi_it): New member next_en_type.
3595
3596 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3597 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3598 current character, check also for next_en_type being WEAK_EN.
3599 (bidi_resolve_weak): Don't enter the expensive loop if the current
3600 position is before next_en_pos. Record the bidi type of the first
3601 non-ET, non-BN character we find, in addition to its position.
3602 (bidi_level_of_next_char): Invalidate next_en_type when
3603 next_en_pos is over-stepped.
3604
7da0b018
PE
36052011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3606
3607 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3608 * editfns.c: Rewrite current-time-zone so that it invokes
3609 the equivalent of (format-time-string "%Z") to get the time zone name.
3610 This fixes a bug when the time zone name contains characters that
3611 need converting from the system time locale to Emacs internal format.
3612 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3613 that patch fixed format-time-string to do the conversion, but
3614 I forgot to fix current-time-zone.
3615 (format_time_string): New function, containing most of
3616 what Fformat_time_string used to contain.
3617 (Fformat_time_string): Rewrite in terms of format_time_string.
3618 This doesn't change this function's behavior.
3619 (current-time-zone): Rewrite to use format_time_string.
3620 This fixes the bug reported by Michael Schierl in
3621 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3622 Jason Rumney's 2007-06-07 change worked around this bug, but
3623 didn't fix it.
3624 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3625
8547b010
EZ
36262011-10-19 Eli Zaretskii <eliz@gnu.org>
3627
3628 * xdisp.c (start_display): If the character at POS is displayed
3629 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3630 (try_window_reusing_current_matrix): If a line ends in a display
3631 vector or the next line starts in a display vector, continue
3632 redrawing the window even though the character position of
3633 start_row was reached.
8547b010
EZ
3634 (Bug#9771, part 2)
3635
4e948d15
CY
36362011-10-18 Chong Yidong <cyd@gnu.org>
3637
3638 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3639 with nobreak-char-display too.
3640
4787455f
EZ
36412011-10-18 Eli Zaretskii <eliz@gnu.org>
3642
3643 Fix part 3 of bug#9771.
3644 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3645 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3646 non-neutral characters if the current character is a paragraph
3647 separator (a.k.a. Newline). This avoids running the same
3648 expensive loop twice, once when we consume the preceding newline
3649 and the other time when the line actually needs to be displayed.
3650 Avoid the loop when we see neutrals on the base embedding level
3651 following a character whose directionality is the same as the
3652 paragraph's. This avoids running the expensive loop when a line
3653 ends in a long sequence of neutrals, like control characters.
3654 Add assertion against STRONG_AL type. Slightly rearrange code
3655 that determines the type of a neutral given the first non-neutral
3656 that follows it.
3657 (bidi_level_of_next_char): Set next_en_pos to zero when
3658 invalidating its info.
3659
2c91f553
EZ
36602011-10-17 Eli Zaretskii <eliz@gnu.org>
3661
3662 * xdisp.c (push_display_prop): Determine whether to record string
3663 or buffer position by IT->string, not by IT->method. Allow
3664 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3665 (move_it_vertically_backward): Don't look for character position
3666 immediately after the newline when in a continuation line.
3667 (Bug#9771, part 1)
2c91f553 3668
c7b08b0d
MR
36692011-10-15 Martin Rudalics <rudalics@gmx.at>
3670
3671 * window.c (coordinates_in_window): Rewrite and delabelize
3672 vertical border check. (Bug#5357) (Bug#9618)
3673
6b02f655
SM
36742011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3675
3676 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3677 errors in XSetWindowBorder (bug#9310).
3678
81d40c92
DA
36792011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3680
3681 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3682 avoid crash when xmalloc overrun checking is enabled.
3683
d4172c3b
EZ
36842011-10-13 Eli Zaretskii <eliz@gnu.org>
3685
3686 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3687 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3688 cursor motion with <left> and <right> arrow keys.
3689
3690 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3691 some callers set that themselves.
3692
b00eea75
EZ
36932011-10-12 Eli Zaretskii <eliz@gnu.org>
3694
3695 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3696 display string and the previous row comes from the same string and
3697 is empty. (Bug#9739) (Bug#9738)
3698
8fe012c4
SM
36992011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3700
3701 * doc.c (get_doc_string): Encode file name (bug#9735).
3702
0074aef2
EZ
37032011-10-12 Eli Zaretskii <eliz@gnu.org>
3704
79beb178
EZ
3705 * bidi.c (bidi_level_of_next_char):
3706 * xdisp.c (get_visually_first_element): Remove old incorrect
3707 comments regarding the Unicode Line Separator character.
3708
0074aef2
EZ
3709 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3710
6e4b3fbe
DA
37112011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3712
3713 * alloc.c (Fgc_status): Do not access beyond zombies array
3714 boundary if nzombies > MAX_ZOMBIES.
3715 * alloc.c (dump_zombies): Add missing format specifier.
3716
0324f3af
PE
37172011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3718
b5525cac
PE
3719 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3720 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3721
0324f3af
PE
3722 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3723 Some packages use them to denote characters with modifiers.
3724
e9b5f888
AS
37252011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3726
3727 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3728 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3729 matching a pp-number. Rename parameter var to var1.
3730
127827c0
SM
37312011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3732
3733 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3734
c8fd3bd0
GM
37352011-10-08 Glenn Morris <rgm@gnu.org>
3736
3737 * callint.c (Fcall_interactively): Give a more explicit error for the
3738 'c' case with a non-character input. (Bug#8479)
3739
352ec8ff
EZ
37402011-10-08 Eli Zaretskii <eliz@gnu.org>
3741
03669ccb
EZ
3742 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3743 lines.
7061c986
EZ
3744 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3745 lines that are hscrolled on the left.
03669ccb 3746
352ec8ff
EZ
3747 * dispnew.c (buffer_posn_from_coords): Account for a possible
3748 presence of header-line. (Bug#4426)
3749
a66cfb1c
SM
37502011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3751
6b02f655
SM
3752 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3753 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3754
7c5ee88e
PE
37552011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3756
3757 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3758 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3759 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3760 this makes Emacs dump core during garbage collection on rare
3761 occasions. sizeof is obviously inferior to offsetof here, so
3762 stick with offsetof.
3763 (GC_POINTER_ALIGNMENT): New macro.
3764 (mark_memory): Omit 3rd (offset) arg; caller changed.
3765 Don't assume EMACS_INT alignment is the same as pointer alignment.
3766
df1bbe5b
SM
37672011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3768
3769 * keyboard.c (read_key_sequence_remapped): New var.
3770 (read_key_sequence): Compute remapping in the right buffer.
3771 (command_loop_1): Use read_key_sequence's remapping directly.
3772
51553db6
SM
37732011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3774
32c1fffd
SM
3775 * dired.c (file_name_completion): Don't expand file name.
3776 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3777 before checking file name handler.
3778
51553db6
SM
3779 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3780 they've been requested explicitly (bug#9591).
3781
b6bd1599 37822011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3783
3784 * keymap.c (Fsingle_key_description): Use make_specified_string
3785 instead of build_string to build string from push_key_description.
3786 (Bug#5193)
3787
f701dc2a
PE
37882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3789
4222c55d
PE
3790 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3791 This fixes a Y2038 bug on 64-bit hosts.
3792 * buffer.c (reset_buffer):
3793 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3794 (Fclear_buffer_auto_save_failure):
3795 Use 0, not -1, to represent an unset failure time, since time_t
3796 might not be signed.
3797
f701dc2a
PE
3798 Remove dependency on glibc malloc internals.
3799 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3800 Move back here from lisp.h, but with their new implementations.
3801 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3802 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3803 * charset.c (charset_table_init): New static var.
3804 (syms_of_charset): Use it instead of xmalloc. This removes a
3805 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3806 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3807 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3808 Move back to alloc.c.
3809 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3810 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3811
9ceebf39
JD
38122011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3813
3814 * nsterm.m (windowDidResize): Call x_set_window_size only when
3815 ns_in_resize is true. Otherwise set pixelwidth/height and
3816 call change_frame_size (Bug#9628).
3817
cb993c58
PE
38182011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3819
3930c88b
PE
3820 Port --enable-checking=all to Fedora 14 x86-64.
3821 * charset.c (syms_of_charset): Also account for glibc malloc's
3822 internal overhead when calculating the initial malloc maximum.
3823
cb993c58
PE
3824 Port --enable-checking=all to Fedora 14 x86.
3825 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3826 Move to lisp.h.
3827 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3828 (overrun_check_realloc, overrun_check_free):
3829 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3830 That way, xmalloc returns a properly-aligned pointer even if
3831 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3832 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3833 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3834 into account when calculating the initial malloc maximum.
3835 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3836 Move here from alloc.c, so that charset.c can use it too.
3837 Properly align; the old code wasn't right for common 32-bit hosts
3838 when configured with --enable-checking=all.
3839 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3840 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3841
31bed486
EZ
38422011-09-29 Eli Zaretskii <eliz@gnu.org>
3843
04c70788 3844 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3845 use EDOM.
3846
fbcaa2f3
EZ
38472011-09-28 Eli Zaretskii <eliz@gnu.org>
3848
3849 * xdisp.c (compute_display_string_end): If there's no display
3850 string at CHARPOS, return -1.
3851
3852 * bidi.c (bidi_fetch_char): When compute_display_string_end
3853 returns a negative value, treat the character as a normal
3854 character not covered by a display string. (Bug#9624)
3855
a239d4e9
JB
38562011-09-28 Juanma Barranquero <lekktu@gmail.com>
3857
3858 * lread.c (Fread_from_string): Fix typo in docstring.
3859
88652fd5
EZ
38602011-09-27 Eli Zaretskii <eliz@gnu.org>
3861
3862 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3863 newline, reseat the iterator instead of bidi-iterating there one
3864 character at a time. (Bug#9610)
32c1fffd
SM
3865 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3866 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3867
ed497dd4
AS
38682011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3869
3870 * lread.c (readevalloop): Use correct code for NBSP.
3871 (read1): Likewise. (Bug#9608)
3872
b2bf61aa
MA
38732011-09-25 Michael Albinus <michael.albinus@gmx.de>
3874
3875 * dbusbind.c (Fdbus_register_signal): When service is not
3876 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3877
32bbb17c
GM
38782011-09-25 Glenn Morris <rgm@gnu.org>
3879
3880 * buffer.c (truncate-lines): Doc fix.
3881
94e0933e
CY
38822011-09-24 Chong Yidong <cyd@stupidchicken.com>
3883
3884 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3885 (Fset_window_next_buffers): Doc fix.
3886
cddde921
GM
38872011-09-24 Glenn Morris <rgm@gnu.org>
3888
3889 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3890
1260aef1
PE
38912011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3892
25b4bfa0
PE
3893 Fix minor problems found by static checking.
3894 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3895 * indent.c (Fvertical_motion): Fix == vs = typo.
3896
e3cbd34b
EZ
38972011-09-24 Eli Zaretskii <eliz@gnu.org>
3898
a66cfb1c
SM
3899 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3900 Default value is now t. Doc fix.
6bf7006f 3901
e3cbd34b 3902 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3903 logic when moving up, not only when moving down. Fix the
e3cbd34b 3904 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3905 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3906
3907 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3908 CHARPOS is covered by a display string which includes newlines.
3909 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3910 is covered by a display string with embedded newlines.
3911
a3de0cbd
MA
39122011-09-24 Michael Albinus <michael.albinus@gmx.de>
3913
3914 * dbusbind.c (Fdbus_register_signal): Add match rule to
3915 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3916 (Fdbus_register_method, Vdbus_registered_objects_table):
3917 Fix docstring.
a3de0cbd 3918
b260039d
JM
39192011-09-24 Jim Meyering <meyering@redhat.com>
3920
32c1fffd 3921 do not ignore write error for any output size
b260039d
JM
3922 The previous change was incomplete.
3923 While it makes emacs --batch detect the vast majority of stdout
3924 write failures, errors were still ignored whenever the output size is
3925 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3926 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3927 && echo FAIL: ignored write error
3928 FAIL: ignored write error
3929 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3930 && echo FAIL: ignored write error
3931 FAIL: ignored write error
3932 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3933
8eca8a7c
AS
39342011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3935
3936 * emacs.c (Fkill_emacs): In noninteractive mode exit
3937 non-successfully if a write error occurred on stdout. (Bug#9574)
3938
3341db62
EZ
39392011-09-21 Eli Zaretskii <eliz@gnu.org>
3940
3941 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3942 the xassert test.
3943
3944 * dispextern.h (struct it): Update the comment documenting what
3945 can it->OBJECT be.
3946
8c203dbf
EZ
39472011-09-20 Eli Zaretskii <eliz@gnu.org>
3948
3949 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3950 a display string, extend search for cursor position to end of row.
3951 (find_row_edges): If the row ends in a newline from a display
3952 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3953 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3954 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3955 non-empty line. Fixes confusing cursor motion with arrow keys at
3956 the beginning of a line that starts with whitespace.
8c203dbf 3957
a4824228
LMI
39582011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3959
3960 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3961 (bug#9493).
3962
33ed493b
CY
39632011-09-18 Chong Yidong <cyd@stupidchicken.com>
3964
3965 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3966 boolean (Bug#9154).
3967
56cd55c8
EZ
39682011-09-18 Eli Zaretskii <eliz@gnu.org>
3969
3970 * xdisp.c (display_line): Record maximum and minimum buffer
3971 positions even if no glyphs were produced (e.g., by a zero-width
3972 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3973 buffer positions that will be removed from the glyph row because
3974 they don't fit.
c02dcedf
EZ
3975 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3976 column is beyond frame width: don't subtract 1 "pixel" when
3977 computing width of the stretch.
3e62b7e0
EZ
3978 (reseat_at_next_visible_line_start): Undo the change made on
3979 2011-09-17 that saved paragraph information and restored it after
3980 the call to `reseat'. (Bug#9545)
56cd55c8 3981
5ed99d36 39822011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3983
3984 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3985 and turn window cursor on if cleared (Bug#9415).
3986
5ed99d36 39872011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3988
3989 * search.c (boyer_moore): Take unibyte characters from pattern
3990 literally. (Bug#9458)
3991
9bade7b2
EZ
39922011-09-18 Eli Zaretskii <eliz@gnu.org>
3993
3994 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3995
e5e9d610
PE
39962011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3997
87e4427a
PE
3998 Fix minor problem found by static checking.
3999 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4000 initialized, to pacify gcc -Wuninitialized.
4001
e5e9d610
PE
4002 * fileio.c: Report proper errno when syscall falls.
4003 (Finsert_file_contents): Save and restore errno,
4004 so that report_file_error outputs the correct diagnostic.
4005 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4006
a1674f0b
EZ
40072011-09-18 Eli Zaretskii <eliz@gnu.org>
4008
4009 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4010
fbfb6dd4
EZ
40112011-09-17 Eli Zaretskii <eliz@gnu.org>
4012
4013 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4014 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4015
bb187662
EZ
40162011-09-17 Eli Zaretskii <eliz@gnu.org>
4017
1137e8b8 4018 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4019 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4020
4021 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4022 (bidi_find_paragraph_start): Search back for paragraph beginning
4023 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4024 (bidi_move_to_visually_next): Only trigger paragraph-related
4025 computations when the last character is a newline or at EOB, not
4026 just any NEUTRAL_B. (Bug#9470)
4027
bb187662
EZ
4028 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4029 truncated lines if point is covered by a display string. (Bug#9524)
4030
2e621251
PE
40312011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4032
4033 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4034 (cons_to_x_long): New function.
4035 (lisp_data_to_selection_data): Use it. Correct the test for
4036 short-versus-long data; it was negated. Break out of vector
4037 loop, for efficiency, when a long datum is discovered.
4038
91a15bc6
SM
40392011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4040
4041 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4042
b41c3a35
EZ
40432011-09-16 Eli Zaretskii <eliz@gnu.org>
4044
4045 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4046 GCC PR/17406) by declaring this function with external scope.
4047
7812ba2d
PE
40482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4049
4050 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4051 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4052
cf7edc2a
AS
40532011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4054
4055 * editfns.c (Fformat): Correctly handle text properties on "%%".
4056
bd01620e
EZ
40572011-09-15 Eli Zaretskii <eliz@gnu.org>
4058
4059 * xterm.c (x_draw_composite_glyph_string_foreground):
4060 * w32term.c (x_draw_composite_glyph_string_foreground):
4061 * term.c (encode_terminal_code):
4062 * composite.c (composition_update_it, get_composition_id):
4063 * xdisp.c (get_next_display_element)
4064 (fill_composite_glyph_string): Add comments about special meaning
4065 of TAB characters in a composition.
4066
a02719a3
PE
40672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4070 This occurs when processing a multibyte format.
4071 Problem reported by Wolfgang Jenker.
a02719a3 4072
72589a3c
JB
40732011-09-15 Johan Bockgård <bojohan@gnu.org>
4074
4075 * xdisp.c (try_cursor_movement): Only check for exact match if
4076 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4077
1c14176c
PE
40782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 Remove unused external symbols.
4081 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4082 * xdisp.c (calc_pixel_width_or_height): Now static.
4083 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4084 * indent.c (check_display_width):
4085 * w32term.c: Fix comment to match code.
4086 * xterm.c, xterm.h (x_catching_errors): Remove.
4087
d2eea5b5
PE
40882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4089
4090 * xselect.c: Use signed conversions more consistently (Bug#9498).
4091 (selection_data_to_lisp_data): Assume incoming selection data are
4092 signed integers, not unsigned. This is to be consistent with
4093 outgoing selection data, which was modified to use signed integers
4094 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4095 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4096 expects long, not unsigned long.
4097
46888499
EZ
40982011-09-14 Eli Zaretskii <eliz@gnu.org>
4099
4100 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4101 computation of loop end. Reported by Johan Bockgård
4102 <bojohan@gnu.org>.
4103
ef8ef9fb
CY
41042011-09-13 Chong Yidong <cyd@stupidchicken.com>
4105
4106 * frame.c (Fother_visible_frames_p): Function deleted.
4107
fa819fed
EZ
41082011-09-12 Eli Zaretskii <eliz@gnu.org>
4109
4110 * indent.c (compute_motion): Process display vector front to back
4111 rather than the other way around. (Bug#2496)
4112
2ba8e008
SM
41132011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4114
4115 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4116
20f53c69
CY
41172011-09-11 Chong Yidong <cyd@stupidchicken.com>
4118
4119 * minibuf.c (Fread_from_minibuffer): Doc fix.
4120
d562d7a4
EZ
41212011-09-11 Eli Zaretskii <eliz@gnu.org>
4122
4123 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4124 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4125
1c4d7f3d
LMI
41262011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4127
4128 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4129 value for non-existent files.
4130
b885bf36
EZ
41312011-09-11 Eli Zaretskii <eliz@gnu.org>
4132
4133 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4134 set its "size" to -1. This will set the modtime_size field of
4135 the corresponding buffer to -1, which is what
4136 verify-visited-file-modtime expects for files that do not exist.
4137 (Bug#9139)
4138
6612f0bf
PE
41392011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4142 here ...
4143 * lisp.h: ... from here. push_key_description is no longer
4144 defined in keyboard.c, so its declaration should not be in
4145 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4146 logically belongs with push_key_description.
4147
dfb3f755
PE
41482011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 * buffer.h: Include <sys/types.h> instead of <time.h>.
4151 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4152 Problem reported by Herbert J. Skuhra.
4153
3134906c
LMI
41542011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4155
4156 * xml.c (parse_region): Make the parsing work for
4157 non-comment-starting XML files again (bug#9144).
4158
8d903f4e
AS
41592011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4160
4161 * image.c (gif_load): Fix calculation of bottom and right corner.
4162 (Bug#9468)
4163
80ad64f4
EZ
41642011-09-10 Eli Zaretskii <eliz@gnu.org>
4165
4166 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4167 redisplay in small windows.
4168
208a048d
EZ
41692011-09-09 Eli Zaretskii <eliz@gnu.org>
4170
4171 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4172
9b1c252e
MR
41732011-09-08 Martin Rudalics <rudalics@gmx.at>
4174
4175 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4176 Operate on live windows only.
4177
2949f33b
JB
41782011-09-08 Juanma Barranquero <lekktu@gmail.com>
4179
4180 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4181
e08dcafd
EZ
41822011-09-07 Eli Zaretskii <eliz@gnu.org>
4183
4184 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4185 only under bidi iteration.
4186
115b96bd
JD
41872011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4188
4189 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4190
c8199d0f
PE
41912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4194 Without this fix, the command to link temacs failed due to an
4195 undefined symbol __builtin_isnan. This is because
4196 /usr/include/iso/math_c99.h #defines isnan(x) to
4197 __builtin_isnan(x), but the bundled gcc, which identifies itself
4198 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4199 a __builtin_isnan.
4200 * floatfns.c (isnan): #undef, and then #define to a clone of
4201 what's in data.c.
4202 (Fisnan): Always define, since it's always available now.
4203 (syms_of_floatfns): Always define isnan at the Lisp level.
4204
e39b275c 42052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4206
4207 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4208
b2db44d9 42092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4210
f4af5137 4211 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4212 The previous code assumed that file offsets (off_t values) fit in
4213 EMACS_INT variables, which is not true on typical 32-bit hosts.
4214 The code messed up by falsely reporting buffer overflow in cases
4215 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4216 when "big" contains more than 2**29 bytes, even though this
4217 inserts just one byte and does not overflow the buffer.
4218 (Finsert_file_contents): Store file offsets as off_t
4219 values, not as EMACS_INT values. Check for overflow when
4220 converting between EMACS_INT and off_t. When checking for
4221 buffer overflow or for overlap, take the offsets into account.
4222 Don't use EMACS_INT for small values where int suffices.
4223 When checking for overlap, fix a typo: ZV was used where
4224 ZV_BYTE was intended.
4225 (Fwrite_region): Don't assume off_t fits into 'long'.
4226 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4227
ecfc0a49
MA
42282011-09-05 Michael Albinus <michael.albinus@gmx.de>
4229
4230 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4231
6511acf2 42322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4233
0999621a 4234 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4235
4236 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4237 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4238 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4239 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4240 (modify_event_symbol): Do not assume that the length of
4241 name_alist_or_stem is safe to alloca and fits in int.
4242 (Fexecute_extended_command): Likewise for function name and binding.
4243 (Frecursion_depth): Wrap around reliably on integer overflow.
4244 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4245 since some callers pass EMACS_INT values.
4246 (Fsingle_key_description): Don't crash if symbol name contains more
4247 than MAX_ALLOCA bytes.
4248 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4249 (get_minibuffer): Arg is now EMACS_INT, not int.
4250 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4251 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4252 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4253
2be7d702
PE
4254 * dbusbind.c (signature_cat): New function.
4255 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4256 Do not overrun buffer; instead, report string overflow.
4257
9d1df220
PE
4258 * dispnew.c (add_window_display_history): Don't overrun buffer.
4259 Truncate instead; this is OK since it's just a log.
4260
33ef5c64
PE
4261 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4262 even if the time zone offset is outlandishly large.
4263 Don't mishandle offset == INT_MIN.
4264
66c6fdd5
PE
4265 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4266 when creating daemon; the previous buffer-overflow check was incorrect.
4267
d749b01b
PE
4268 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4269 which has the guts of the old verror function.
4270
b5cd1905
PE
4271 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4272 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4273
6e1a67fb
PE
4274 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4275 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4276 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4277 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4278 length of string rather than counting it via multiple sprintfs;
4279 that's simpler and more reliable.
c21721cc
PE
4280 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4281 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4282 sprintf, in case result does not fit in int.
4283
c57b67fc
PE
4284 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4285 (fontset_from_font): Print it.
4286
8a401434
PE
4287 * frame.c (tty_frame_count): Now printmax_t, not int.
4288 (make_terminal_frame, set_term_frame_name): Print it.
4289 (x_report_frame_params): In X, window IDs are unsigned long,
4290 not signed long, so print them as unsigned.
4291 (validate_x_resource_name): Check for implausibly long names,
4292 and don't assume name length fits in 'int'.
4293 (x_get_resource_string): Don't blindly alloca invocation name;
4294 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4295 not fit in int.
4296
6e1a67fb
PE
4297 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4298 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4299 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4300
0df02bf3
PE
4301 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4302 Use esprintf, not sprintf, in case result does not fit in int.
4303
48e30793
PE
4304 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4305 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4306 it as a large positive number.
4307 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4308 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4309
a66ff6d8
PE
4310 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4311 in case result does not fit in int.
4312
aca216ff
PE
4313 * print.c (float_to_string): Detect width overflow more reliably.
4314 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4315 buffer overrun. Don't assume list length fits in 'int'. Treat
4316 print length of 0 as 0, not as infinity; to be consistent with other
4317 uses of print length in this function. Don't overflow print length
4318 index. Don't assume hash table size fits in 'long', or that
4319 vectorlike size fits in 'unsigned long'.
4320
31c286f7
PE
4321 * process.c (make_process): Use printmax_t, not int, to format
4322 process-name gensyms.
4323
55e5faa1
PE
4324 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4325
80f2e268
PE
4326 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4327 to avoid potential buffer overrun.
4328
670741ab
PE
4329 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4330 if X resource line is longer than 512 bytes.
4331
b7163a50
PE
4332 * xfns.c (x_window): Make sprintf buffer a bit bigger
4333 to avoid potential buffer overrun.
4334
ae58ff1f
PE
4335 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4336
c43c8a6a
PE
4337 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4338
3f8236f4
PE
43392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4340
53e9fe90 4341 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4342 Without these, Emacs silently mishandles large integers sometimes.
4343 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4344 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4345
6511acf2
PE
4346 * xdisp.c (try_window_id): Check Emacs fixnum range before
4347 converting to 'int'.
806add1d 4348
6511acf2 4349 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4350 Check that an Emacs fixnum is in range before assigning it to 'int'.
4351 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4352 values converted from Emacs fixnums.
4353 (Frecenter): Don't wrap around a line count if it is out of 'int'
4354 range; instead, treat it as an extreme value.
4355 (Fset_window_configuration, compare_window_configurations):
4356 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4357
6511acf2
PE
4358 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4359 that can exceed INT_MAX. Check that EMACS_INT value is in range
4360 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4361 (match_limit): Don't assume that a fixnum can fit in 'int'.
4362
6511acf2 4363 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4364 exceed INT_MAX.
4365
6511acf2 4366 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4367 (Fvertical_motion): Don't wrap around LINES values that don't fit
4368 in 'int'. Instead, treat them as extreme values. This is good
4369 enough for windows, which can't have more than INT_MAX lines anyway.
4370
fcb901a7
LMI
43712011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4372
0f2f6b6d
LMI
4373 * Require libxml/parser.h to avoid compilation warning.
4374
fcb901a7
LMI
4375 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4376
4377 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4378 since this reportedly can destroy thread storage.
4379
6e20a0d4
CY
43802011-08-30 Chong Yidong <cyd@stupidchicken.com>
4381
4382 * syntax.c (find_defun_start): Update all cache variables if
4383 exiting early (Bug#9401).
4384
148ae00e
EZ
43852011-08-30 Eli Zaretskii <eliz@gnu.org>
4386
f6cfbd8f
EZ
4387 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4388
148ae00e
EZ
4389 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4390 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4391 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4392
4393 * term.c (tty_append_glyph): New function.
4394 (produce_stretch_glyph): Static function and its prototype deleted.
4395
a66cfb1c
SM
4396 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4397 Add prototypes.
148ae00e 4398
c4a07a4c
PE
43992011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4400
4401 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4402 when checking :margin (Bug#9390).
4403 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4404 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4405 so that the name doesn't mislead. All uses changed.
4406
6bc8cd65
JB
44072011-08-28 Johan Bockgård <bojohan@gnu.org>
4408
4409 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4410 set_tty_hooks.
4411
dca4927e
EZ
44122011-08-27 Eli Zaretskii <eliz@gnu.org>
4413
4414 * xdisp.c (move_it_to): Don't bail out early when reaching
4415 position beyond to_charpos, if we are scanning backwards.
4416 (move_it_vertically_backward): When DY == 0, make sure we get to
4417 the first character in the line after the newline.
4418
f2cad773
PE
44192011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4420
4421 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4422 (ccl_driver): Do not generate an out-of-range pointer.
4423 (Fccl_execute_on_string): Remove unnecessary check for
4424 integer overflow, noted by Stefan Monnier in
4425 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4426 Remove a FIXME that didn't need fixing.
4427 Simplify the newly-introduced buffer reallocation code.
4428
0cae2cdb
JB
44292011-08-27 Juanma Barranquero <lekktu@gmail.com>
4430
4431 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4432
5fc295a4 44332011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4434
70c60eb2 4435 Integer and memory overflow issues (Bug#9196).
726e0ab1 4436
d31850da
PE
4437 * doc.c (get_doc_string): Rework so that
4438 get_doc_string_buffer_size is the actual buffer size, rather than
4439 being 1 less than the actual buffer size; this makes xpalloc more
4440 convenient.
4441
a69fbedb
PE
4442 * image.c (x_allocate_bitmap_record, cache_image):
4443 * xselect.c (Fx_register_dnd_atom):
4444 Simplify previous changes by using xpalloc.
4445
fe5c5d37
PE
4446 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4447 since either will do and ptrdiff_t is convenient with xpalloc.
4448
0065d054
PE
4449 * charset.c (charset_table_size)
4450 (struct charset_sort_data.priority): Now ptrdiff_t.
4451 (charset_compare): Don't overflow if priorities differ greatly.
4452 (Fsort_charsets): Don't assume list length fits in int.
4453 Check for size-calculation overflow when allocating sort data.
4454 (syms_of_charset): Allocate an initial charset table that is
4455 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4456
4457 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4458
4459 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4460 The actual value is always <= INT_MAX, and leaving it unsigned made
4461 overflow checking harder.
4462
4463 * dispextern.h (struct glyph_matrix.rows_allocated)
4464 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4465 with xpalloc. The values are still always <= INT_MAX.
4466
4467 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4468
4469 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4470 (SAFE_NALLOCA): New macro.
4471
4472 * region-cache.c (struct boundary.pos, find_cache_boundary)
4473 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4474 (set_cache_region, invalidate_region_cache)
4475 (revalidate_region_cache, know_region_cache, region_cache_forward)
4476 (region_cache_backward, pp_cache):
4477 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4478 so that ptrdiff_t * can be passed to xpalloc.
4479 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4480 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4481 (pp_cache): Don't assume cache_len fits in int.
4482 * region-cache.h: Adjust extern decls to match.
4483
4484 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4485 EMACS_INT, since either will do, for xpalloc.
4486
4487 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4488 (xnmalloc, xnrealloc, xpalloc): New functions.
4489
726e0ab1
PE
4490 * bidi.c (bidi_shelve_header_size): New constant.
4491 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4492 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4493
51f30bc5 4494 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4495 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4496 (overlay_strings):
4497 Don't update size of array until after memory allocation succeeds,
4498 because xmalloc/xrealloc may not return.
0065d054
PE
4499 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4500 now that we have proper integer overflow checking.
4501 (record_overlay_string, overlay_strings): Catch overflows when
4502 calculating size of overlay_str_buf.
726e0ab1 4503
0065d054
PE
4504 * callproc.c (Fcall_process): Check for size overflow when
4505 calculating size of args2.
4506 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4507 Normally we prefer signed values, but sticking with ptrdiff_t would
4508 require adding more-complicated checks.
726e0ab1
PE
4509
4510 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4511 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4512 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4513 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4514
4515 * character.c (Fstring): Check for size-calculation overflow.
4516
4517 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4518 unnecessary integer overflow. Check for size overflow.
4519 (encode_coding_object): Don't update size until xmalloc succeeds.
4520
4521 * composite.c (get_composition_id): Check for overflow in glyph
4522 length calculations.
4523
4524 Integer and memory overflow fixes for display code.
4525 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4526 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4527 (scrolling_window): Check for overflow in size calculations.
4528 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4529 Don't assume glyph table len fits in int.
4530 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4531 (row_table_size): Now ptrdiff_t, not int.
4532 (scrolling_window): Avoid overflow in size calculations.
4533 Don't update size until allocation succeeds.
4534 * fns.c (concat): Check for overflow in size calculations.
4535 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4536 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4537 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4538
4539 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4540 (get_doc_string): Check for size calculation overflow.
4541 Don't update size until allocation succeeds.
4542 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4543 EMACS_INT, where ptrdiff_t will do.
4544 (Fsubstitute_command_keys): Check for string overflow.
4545
4546 * editfns.c (set_time_zone_rule): Don't assume environment length
4547 fits in int.
4548 (message_length): Now ptrdiff_t, not int.
4549 (Fmessage_box): Don't update size until allocation succeeds.
4550 Don't assume message length fits in int.
4551 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4552
0065d054
PE
4553 * emacs.c (main): Do not reallocate argv, since there is a null at
4554 the end that can be overwritten, and this way there's no need to
4555 worry about size-calculation overflow.
4556 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4557
4558 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4559 alloc succeeds.
4560 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4561
4562 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4563 (x_set_scroll_bar_width, x_figure_window_size):
4564 Check for integer overflow.
4565 (x_set_alpha): Do not assume XINT fits in int.
4566
4567 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4568 This is for the members text_lines, text_cols, total_lines, total_cols,
4569 where the system imposes an 'int' limit.
4570
4571 * fringe.c (Fdefine_fringe_bitmap):
4572 Don't update size until alloc works.
4573
4574 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4575 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4576
4577 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4578 Check for size-calculation overflow.
4579 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4580 do, as we prefer signed integers.
4581 (id_to_widget.max_size, id_to_widget.used)
4582 (xg_store_widget_in_map, xg_remove_widget_from_map)
4583 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4584 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4585 Use and return ptrdiff_t, not int.
4586 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4587 * gtkutil.h: Change prototypes to match the above.
4588
4589 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4590 are duplicate now that they've been promoted to lisp.h.
4591 (x_allocate_bitmap_record, x_alloc_image_color)
4592 (make_image_cache, cache_image, xpm_load):
4593 Don't update size until alloc is done.
4594 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4595 (x_detect_edges):
3256efce 4596 Check for size calculation overflow.
726e0ab1
PE
4597 (ct_colors_allocated_max): New constant.
4598 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4599 overflow.
3256efce 4600
726e0ab1
PE
4601 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4602 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4603 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4604 Use ptrdiff_t, not int, to count maps.
4605 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4606 calculations. Don't update size until allocation succeeds.
4607 Redo calculations to avoid overflow.
726e0ab1
PE
4608 * keyboard.h: Change prototypes to match the above.
4609
4610 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4611 to count maps.
4612 (current_minor_maps): Check for size calculation overflow.
4613 * keymap.h: Change prototypes to match the above.
4614
4615 * lread.c (read1, init_obarray): Don't update size until alloc done.
4616
4617 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4618 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4619
726e0ab1
PE
4620 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4621 Now ptrdiff_t, not int.
4622 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4623 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4624
4625 * process.c (Fnetwork_interface_list): Check for overflow
4626 in size calculation.
4627
4628 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4629
4630 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4631 overflow. Don't bother calling xmalloc when xrealloc will do.
4632
4633 * search.c (Freplace_match): Check for size calculation overflow.
4634 (Fset_match_data): Don't assume list lengths fit in 'int'.
4635
4636 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4637 for command line length. Do not attempt to address one before the
4638 beginning of an array, as that's not portable.
4639
4640 * term.c (max_frame_lines): Remove; unused.
4641 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4642 not int.
4643 (encode_terminal_code, calculate_costs): Check for size
4644 calculation overflow.
4645 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4646 table lengths and related sizes. Don't update size until alloc
4647 done. Redo calculations to avoid overflow.
4648 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4649
4650 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4651 subtracting pointers.
4652 (gobble_line): Check for overflow more carefully. Don't update size
4653 until alloc done.
4654
4655 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4656 Don't update size until alloc done.
4657 Redo size calculations to avoid overflow.
4658 Check for size calculation overflow.
0065d054 4659 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4660
4661 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4662 Use ptrdiff_t, not int, for sizes.
4663 (store_mode_line_noprop_char): Don't update size until alloc done.
4664
0065d054
PE
4665 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4666 Use ptrdiff_t, not int, for sizes.
4667 (Finternal_make_lisp_face, cache_face):
4668 Check for size calculation overflow.
4669 (cache_face): Treat size calculation overflows as if they were
4670 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4671
4672 * xfns.c (x_encode_text, x_set_name_internal)
4673 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4674 sizes, since they can exceed INT_MAX in size. Check for size
4675 calculation overflow.
4676
0065d054
PE
4677 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4678 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4679 Don't update size until alloc done.
4680
0065d054 4681 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4682 as sprintf is limited to int lengths.
1d526e2f 4683
252c5ee1
PE
4684 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4685 (X_LONG_MIN): New macros.
864d7ce7
PE
4686 Use them to make the following changes clearer.
4687 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4688 This change doesn't affect the value now, but it may help remind
4689 future maintainers not to raise the value too much later.
4690 (SELECTION_QUANTUM): Remove, replacing with ...
4691 (selection_quantum): ... new function, which avoids overflow.
4692 All uses changed.
4693 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4694 assumption that selection length fits in 'int'.
4695 (x_reply_selection_request, x_handle_selection_request)
4696 (x_get_window_property, receive_incremental_selection)
4697 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4698 (lisp_data_to_selection_data, clean_local_selection_data):
4699 Use ptrdiff_t, not int, to record length of selection.
4700 (x_reply_selection_request, x_get_window_property)
4701 (receive_incremental_selection, x_property_data_to_lisp):
4702 Redo calculations to avoid overflow.
4703 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4704 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4705 something.
4706 (x_get_window_property, receive_incremental_selection)
4707 (lisp_data_to_selection_data, x_property_data_to_lisp):
4708 Check for size-calculation overflow.
4709 (x_get_window_property, receive_incremental_selection)
4710 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4711 Don't store size until memory allocation succeeds.
4712 (x_get_window_property): Plug memory leak on memory exhaustion.
4713 Don't double-block input; malloc is safe here. Don't assume 2**34
4714 - 4 fits in unsigned long. Add an xassert to check
4715 XGetWindowProperty overflow. Be more careful about overflow
4716 calculations, and distinguish size from memory overflow better.
4717 (receive_incremental_selection): When tracing, don't assume
4718 unsigned int is less than INT_MAX.
4719 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4720 harmful) conversions of unsigned short to int.
4721 (lisp_data_to_selection_data): Don't assume that integers
4722 in the range -65535 through -1 fit in an X unsigned short.
4723 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4724 result parameters unless successful. Rely on cons_to_unsigned
4725 to report problems with elements; the old code wasn't right anyway.
4726 (x_check_property_data): Check for int overflow; we cannot use
4727 a wider type due to X limits.
4728 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4729
726e0ab1 4730 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4731
0065d054
PE
4732 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4733 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4734 (x_color_cells): Don't store size until memory allocation succeeds.
4735 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4736 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4737 (x_term_init): Don't assume length fits in int (sprintf is limited
4738 to int size).
bc18e09d 4739
ebfa62c0
PE
4740 Use ptrdiff_t for composition IDs.
4741 * character.c (lisp_string_width):
4742 * composite.c (composition_table_size, n_compositions)
4743 (get_composition_id, composition_gstring_from_id):
4744 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4745 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4746 * window.c (Frecenter):
4747 Use ptrdiff_t, not int, for composition IDs.
4748 * composite.c (get_composition_id): Check for integer overflow.
4749 * composite.h: Adjust prototypes to match the above changes.
4750
d3411f89
PE
4751 Use ptrdiff_t for hash table indexes.
4752 * category.c (hash_get_category_set):
4753 * ccl.c (ccl_driver):
4754 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4755 * coding.c (coding_system_charset_list, detect_coding_system):
4756 * coding.h (struct coding_system.id):
4757 * composite.c (get_composition_id, gstring_lookup_cache):
4758 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4759 * image.c (xpm_get_color_table_h):
4760 * lisp.h (hash_lookup, hash_put):
4761 * minibuf.c (Ftest_completion):
4762 Use ptrdiff_t for hash table indexes, not int (which is too
4763 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4764 32-bit --with-wide-int hosts).
4765
e097a6fa
PE
4766 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4767 Add a FIXME comment about memory leaks.
4768 (syms_of_charset): Don't assume xmalloc returns.
4769
5637687f
PE
4770 Don't assume that stated character widths fit in int.
4771 * character.c (Fchar_width, c_string_width, lisp_string_width):
4772 * character.h (CHAR_WIDTH):
4773 * indent.c (MULTIBYTE_BYTES_WIDTH):
4774 Use sanitize_char_width to avoid undefined and/or bad behavior
4775 with outlandish widths.
a66cfb1c 4776 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4777 now that we have two such functions. All uses changed.
4778 (sanitize_char_width): New inline function.
4779
a2271ba2
PE
4780 Don't assume that tab-width fits in int.
4781 * character.h (sanitize_width): New inline function.
4782 (SANE_TAB_WIDTH): New macro.
4783 (ASCII_CHAR_WIDTH): Use it.
4784 * indent.c (sane_tab_width): Remove. All uses replaced by
4785 SANE_TAB_WIDTH (current_buffer).
4786 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4787
18c52557
PE
4788 * fileio.c: Integer overflow issues with file modes.
4789 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4790
caeeedc1
PE
4791 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4792 Remove unreachable code.
4793 (read_hex, load_charset_map_from_file): Check for integer overflow.
4794
6df6ae42 4795 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4796 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4797 (x_send_scroll_bar_event): Likewise. Check that the size does not
4798 exceed limits imposed by XClientMessageEvent, as well as the usual
4799 ptrdiff_t and size_t limits.
4800
b13995db
PE
4801 * keyboard.c: Overflow, signedness and related fixes.
4802 (make_lispy_movement): Use same integer type in forward decl
4803 that is used in the definition.
4804 (read_key_sequence, keyremap_step):
4805 Change bufsize argument back to int, undoing my 2011-03-30 change.
4806 We prefer signed types, and int is wide enough here.
4807 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4808 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4809 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4810 length, not size_t. Use ptrdiff_t for index, not int.
4811 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4812 possibility of integer overflow.
4813
13464394
PE
4814 Overflow, signedness and related fixes for images.
4815
4816 * dispextern.h (struct it.stack[0].u.image.image_id)
4817 (struct_it.image_id, struct image.id, struct image_cache.size)
4818 (struct image_cache.used, struct image_cache.ref_count):
4819 * gtkutil.c (update_frame_tool_bar):
4820 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4821 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4822 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4823 * nsmenu.m (update_frame_tool_bar):
4824 * xdisp.c (calc_pixel_width_or_height):
4825 * xfns.c (image_cache_refcount):
4826 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4827 on typical 64-bit hosts.
4828
4829 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4830 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4831 Omit unnecessary casts to int.
4832 (parse_image_spec): Check that integers fall into 'int' range
4833 when the callers expect that.
4834 (image_ascent): Redo ascent calculation to avoid int overflow.
4835 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4836 (lookup_image): Remove unnecessary tests.
4837 (xbm_image_p): Locals are now of int, not EMACS_INT,
4838 since parse_image_check makes sure they fit into int.
4839 (png_load, gif_load, svg_load_image):
4840 Prefer int to unsigned where either will do.
4841 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4842 old tiff_error_handler and tiff_warning_handler.
4843 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4844 stack buffer overflows. It uses only the features of vsnprintf
4845 that are common to both POSIX and native Microsoft.
4846 (tiff_error_handler, tiff_warning_handler): Use it.
4847 (tiff_load, gif_load, imagemagick_load_image):
4848 Don't assume :index value fits in 'int'.
4849 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4850 (imagemagick_load_image): Check that crop parameters fit into
4851 the integer types that MagickCropImage accepts. Don't assume
4852 Vimagemagick_render_type has a nonnegative value. Don't assume
4853 size_t fits in 'long'.
4854 (gs_load): Use printmax_t to print the widest integers possible.
4855 Check for integer overflow when computing image height and width.
4856
c11821d4
EZ
48572011-08-26 Eli Zaretskii <eliz@gnu.org>
4858
4859 * xdisp.c (redisplay_window): Don't force window start if point
4860 will be invisible in the resulting window. (Bug#9324)
4861
0c95fcf7
EZ
48622011-08-25 Eli Zaretskii <eliz@gnu.org>
4863
4864 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4865 the display spec is of the form `(space ...)'.
4866 (handle_display_spec): Return the value returned by
4867 handle_single_display_spec, not just 1 or zero.
4868 (handle_single_display_spec): If the display spec is of the form
4869 `(space ...)', and specifies display in the text area, return 2
4870 rather than 1.
fee65a97 4871 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4872 accurately, and prefer exact match for point under bidi.
4873 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4874
4875 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4876 into disp_prop; all users changed.
4877
4878 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4879 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4880 for the text covered by the display property.
4881
e4ed06f1
CY
48822011-08-25 Chong Yidong <cyd@stupidchicken.com>
4883
4884 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4885 Change return value to nil.
4886 (Frecord_buffer): Delete unused function.
4887
f67cdd7f
EZ
48882011-08-24 Eli Zaretskii <eliz@gnu.org>
4889
5980d4c6
EZ
4890 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4891 buffers, return left-to-right.
8610fe8b
EZ
4892 (set_cursor_from_row): Consider candidate row a win if its glyph
4893 represents a newline and point is on that newline. Fixes cursor
4894 positioning on the newline at EOL of R2L text within L2R
4895 paragraph, and vice versa.
4896 (try_cursor_movement): Check continued rows, in addition to
4897 continuation rows. Fixes unwarranted scroll when point enters a
4898 continued line of R2L text within an L2R paragraph, or vice versa.
4899 (cursor_row_p): Consider the case of point being equal to
4900 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4901 from the end of a short line to the beginning of a continued line
4902 of R2L text within L2R paragraph.
4903 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4904 composed characters.
5980d4c6 4905
f67cdd7f
EZ
4906 * bidi.c (bidi_check_type): Use xassert.
4907 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4908 members.
4909
bca633fb
EZ
49102011-08-23 Eli Zaretskii <eliz@gnu.org>
4911
4912 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4913 a character.
4914
4a5885a7
CY
49152011-08-23 Chong Yidong <cyd@stupidchicken.com>
4916
4917 * nsfont.m (ns_otf_to_script): Fix typo.
4918
0902a04e
KH
49192011-08-22 Kenichi Handa <handa@m17n.org>
4920
4921 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4922 extra slot even if the purpose is char-code-property-table.
4923
1a2e6670
EZ
49242011-08-23 Eli Zaretskii <eliz@gnu.org>
4925
8ddde651
EZ
4926 * xdisp.c (redisplay_window): When computing centering_position,
4927 account for the height of the header line. (Bug#8874)
4928
425cc014
EZ
4929 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4930 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4931 candidate is selected by the mouse, and that candidate has a
4932 composed character under the mouse.
4933
1a2e6670
EZ
4934 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4935 coordinates reported by pos-visible-in-window-p for a composed
4936 character in column zero.
4937
8b76d6f8
SM
49382011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4939
4940 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4941
dac347dd
EZ
49422011-08-22 Eli Zaretskii <eliz@gnu.org>
4943
4944 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4945 consider it a hit if to_charpos is anywhere in the range of the
4946 composed buffer positions.
4947
e013fb34
CY
49482011-08-22 Chong Yidong <cyd@stupidchicken.com>
4949
4950 * image.c (gif_load): Don't assume that each subimage has the same
4951 dimensions as the base image. Handle disposal method that is
4952 "undefined" by the gif spec (Bug#9335).
4953
bd1ba3e8
CY
49542011-08-20 Chong Yidong <cyd@stupidchicken.com>
4955
4956 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4957 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4958
54a1215b
EZ
49592011-08-19 Eli Zaretskii <eliz@gnu.org>
4960
823564e5
EZ
4961 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4962 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4963 from an Org mode buffer to a Speedbar frame.
4964
54a1215b
EZ
4965 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4966 a composition, take its buffer position from IT->cmp_it.charpos.
4967 Fixes cursor positioning at the beginning of a line that begins
4968 with a composed character.
4969
9778ebcc
EZ
49702011-08-18 Eli Zaretskii <eliz@gnu.org>
4971
0be6ee06
EZ
4972 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4973 character bidirectional type, use STRONG_L instead. Fixes crashes
4974 in a buffer produced by `describe-categories'.
4975
9778ebcc
EZ
4976 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4977 members before the level stack, so they would be saved and
4978 restored when copying iterator state. Fixes incorrect reordering
4979 around TABs covered by display properties.
4980
156bffbe
AS
49812011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4982
6b02f655 4983 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4984
72ad093b
CY
49852011-08-17 Chong Yidong <cyd@stupidchicken.com>
4986
4987 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4988 (internal_condition_case_2, internal_condition_case_n):
4989 Remove unnecessary aborts (Bug#9081).
72ad093b 4990
35774242
EZ
49912011-08-17 Eli Zaretskii <eliz@gnu.org>
4992
4993 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4994 has no `load' handler, try opening the file locally. (Bug#9311)
4995
db76dd85
KB
49962011-08-16 Ken Brown <kbrown@cornell.edu>
4997
4998 * gmalloc.c: Expand comment.
4999
b215eee5
EZ
50002011-08-16 Eli Zaretskii <eliz@gnu.org>
5001
5002 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5003 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5004
a4579d33
KB
50052011-08-16 Ken Brown <kbrown@cornell.edu>
5006
5007 Fix memory allocation problems in Cygwin build (Bug#9273).
5008
5009 * unexcw.c ( __malloc_initialized): Declare external variable.
5010 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5011
8b76d6f8
SM
5012 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5013 New variables.
a4579d33
KB
5014 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5015 dumped emacs.
5016 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5017 in the static heap.
5018 [CYGWIN] (special_realloc): New function.
5019 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5020 requests to realloc storage in the static heap.
5021
3ebec551
PE
50222011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 * bidi.c (bidi_initialize): Remove unused local.
5025
9fd8be00
EZ
50262011-08-15 Eli Zaretskii <eliz@gnu.org>
5027
6b02f655
SM
5028 * bidimirror.h:
5029 * biditype.h: Remove file.
5030 * makefile.w32-in ($(BLD)/bidi.$(O)):
5031 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5032
5033 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5034
5035 * chartab.c: Improve commentary for the uniprop_table API.
5036
32413314
EZ
5037 * bidi.c (bidi_paragraph_init): Support zero value of
5038 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5039 (bidi_initialize): Use uniprop_table instead of including
5040 biditype.h and bidimirror.h.
32413314 5041
9fd8be00
EZ
5042 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5043 coordinates of the iterator when restoring from ppos_it.
5044 (Bug#9296)
5045
5cf2b69b
KH
50462011-08-14 Kenichi Handa <handa@m17n.org>
5047
5048 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5049 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5050
daf17d00
EZ
50512011-08-14 Eli Zaretskii <eliz@gnu.org>
5052
5053 * xdisp.c (move_it_in_display_line_to): Don't invoke
5054 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5055 ppos_it. Fixes vertical cursor motion when line beginning is
5056 covered by an image. (Bug#9296)
5057
08e3161a
JD
50582011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5059
5060 * nsterm.h (ns_run_ascript): Declare.
5061 (NSAPP_DATA2_RUNASSCRIPT): Define.
5062
5063 * nsfns.m (as_script, as_result, as_status): New static variables.
5064 (ns_run_ascript): New function.
5e617bc2 5065 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5066 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5067 the event loop. Get status from as_status (Bug#7276).
5068
5069 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5070 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5071 the event loop (Bug#7276).
5072
a3720aa2
AS
50732011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5074
5075 * gnutls.c (QCgnutls_bootprop_priority)
5076 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5077 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5078 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5079 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5080 (QCgnutls_bootprop_verify_hostname_error)
5081 (QCgnutls_bootprop_callbacks_verify): Rename from
5082 Qgnutls_bootprop_..., all uses changed.
5083
5084 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5085 uses changed.
5086
0a0d27fb
PE
50872011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5088
19d5c50c
PE
5089 * xfaces.c (Qframe_set_background_mode): Now static.
5090 * dispextern.h (Qframe_set_background_mode): Remove decl.
5091
0a0d27fb
PE
5092 * process.c (Fnetwork_interface_info): Declare local only if needed.
5093
377538cb
JD
50942011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5095
5096 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5097 (Fnetwork_interface_list): Allocate in increments of bytes instead
5098 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5099 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5100 sockaddr.
5101 (struct ifflag_def): notrailers is smart on OSX.
5102 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5103 Get hardware address with getifaddrs if available.
5104
08fff70c
EZ
51052011-08-12 Eli Zaretskii <eliz@gnu.org>
5106
5107 * xdisp.c (iterate_out_of_display_property): xassert that
5108 IT->position is set to within IT->object's boundaries. Break from
5109 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5110 when IT->position is set up wrongly due to some bug.
5111 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5112 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5113 entry. Force push_it to save on the stack the current
5114 buffer/string position, to be restored by pop_it. Fix flags in
5115 the iterator structure wrt the object coming from a display
5116 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5117 properties. (Bug#9284)
5118
7be1c708 51192011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5120
7be1c708
CY
5121 * fontset.c (fontset_get_font_group): Add proper type checks.
5122 (Bug#9172)
aac0c6e3 5123
7be1c708 51242011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5125
7be1c708
CY
5126 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5127 and LC_VERSION_MIN_MACOSX.
5128 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5129 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5130
97bb72a6
EZ
51312011-08-08 Eli Zaretskii <eliz@gnu.org>
5132
5133 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5134 no-display-properties-and-no-overlays under bidi display.
5135 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5136 properties and overlays.
97bb72a6 5137
d5617611
CY
51382011-08-08 Chong Yidong <cyd@stupidchicken.com>
5139
37e11a63
CY
5140 * editfns.c (Fset_time_zone_rule): Document relationship with the
5141 setenv function.
5142
d5617611
CY
5143 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5144 the font entity extracted from the cache (Bug#8109).
5145
58872834
CY
51462011-08-07 Chong Yidong <cyd@stupidchicken.com>
5147
5148 * composite.c (autocmp_chars): Don't reset point. That is done by
5149 restore_point_unwind (Bug#5984).
5150
75bfc667
JL
51512011-08-07 Juri Linkov <juri@jurta.org>
5152
5153 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5154 to show the arg `TIME' instead of `TIMEVAL'.
5155
d1410150
EZ
51562011-08-06 Eli Zaretskii <eliz@gnu.org>
5157
5158 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5159 display property strides EOL and includes a newline, as in
5160 longlines-mode. (Bug#9254)
75b771e4
EZ
5161 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5162 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5163
5164 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5165 is non-zero, even if the data buffer is NULL. Fixes a crash in
5166 vertical-motion with longlines-mode. (Bug#9254)
5167
35928349
EZ
51682011-08-05 Eli Zaretskii <eliz@gnu.org>
5169
ec7cc85b
EZ
5170 * bidi.c <bidi_cache_total_alloc>: Now static.
5171 (bidi_initialize): Initialize bidi_cache_total_alloc.
5172
8b76d6f8 5173 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5174 cache. (Bug#9221)
5175
5176 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5177 amount allocated this far in `bidi_cache_total_alloc'.
5178 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5179 non-zero, only free the data buffer without restoring the cache
5180 contents. All callers changed.
5181
5182 * dispextern.h (bidi_unshelve_cache): Update prototype.
5183
5184 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5185 (move_it_in_display_line, move_it_to)
5186 (move_it_vertically_backward, move_it_by_lines): Replace the call
5187 to xfree to an equivalent call to bidi_unshelve_cache.
5188 (move_it_in_display_line_to): Fix logic of returning
412b6358 5189 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5190
e2e2423b
EZ
51912011-08-05 Eli Zaretskii <eliz@gnu.org>
5192
5193 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5194 came from a string character with a `cursor' property. (Bug#9229)
5195
ae9e757a
JD
51962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5197
5198 * Makefile.in (LIB_PTHREAD): New variable.
5199 (LIBES): Add LIB_PTHREAD (Bug#9216).
5200
5201 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5202 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5203
213bd7f2
AS
52042011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5205
6b02f655 5206 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5207
99aaf75f
JD
52082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5209
5210 * xterm.c (x_find_topmost_parent): New function.
5211 (x_set_frame_alpha): Find topmost parent window with
5212 x_find_topmost_parent and set the property there also (bug#9181).
5213 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5214
c74e9d86
PE
52152011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 * callproc.c (Fcall_process): Avoid vfork clobbering
5218 the local vars buffer, coding_systems, current_dir.
5219
640c8776
SM
52202011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5221
5222 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5223
f26d0e4c
PE
52242011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5225
8a10d76c
PE
5226 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5227 so that it is not optimized away.
5228
f26d0e4c
PE
5229 * xdisp.c (compute_display_string_pos): Remove unused local.
5230
55439c61
EZ
52312011-08-02 Eli Zaretskii <eliz@gnu.org>
5232
5233 Fix slow cursor motion and scrolling in large buffers with
5234 selective display, like Org Mode buffers. (Bug#9218)
5235
5236 * dispextern.h (struct bidi_it): New member disp_prop_p.
5237
5238 * xdisp.c: Remove one-slot cache of display string positions.
5239 (compute_display_string_pos): Accept an additional argument
5e617bc2 5240 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5241 for a display string or property. If found, set DISP_PROP_P
5242 non-zero.
5243
5244 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5245 DISP_PROP_P, and pass it to compute_display_string_pos.
5246 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5247 non-zero. All callers of bidi_fetch_char changed.
5248
fb33fa43
SM
52492011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5250
5251 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5252
b099e063
DM
52532010-12-03 Don March <don@ohspite.net>
5254
5255 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5256 last character M-[char] is translated to ESC [char] (bug#7541).
5257
5cc7f7af
KH
52582011-08-02 Kenichi Handa <handa@m17n.org>
5259
d0fffa3f 5260 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5261
5262 * chartab.c (uniprop_table): Make it non-static.
5263
525d5e6e
EZ
52642011-08-01 Eli Zaretskii <eliz@gnu.org>
5265
5266 * xdisp.c (forward_to_next_line_start): Accept additional argument
5267 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5268 on the newline.
5269 (reseat_at_next_visible_line_start): Use the bidi iterator state
5270 returned by forward_to_next_line_start to restore the state of
5271 it->bidi_it after backing up to previous newline. (Bug#9212)
5272
31011111
AS
52732011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5274
5275 * regex.c (re_comp): Protoize.
5276 (re_exec): Fix return type.
5277 (regexec): Fix type of `ret'. (Bug#9203)
5278
476371c4
PE
52792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5280
e5d76069
PE
5281 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5282 This is needed if max-image-size is a floating-point number.
5283
9a79b20c
AS
52842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5285
5286 * print.c (print_object): Print empty symbol as ##.
5287
5288 * lread.c (read1): Read ## as empty symbol.
5289
d8c2fa78
AA
52902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5291
5292 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5293 setting frame foreground color (Bug#9175).
5294 (x_set_background_color): Likewise.
5295
ffe57a7a
AA
5296 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5297 contents (Bug#9176).
5298 (EmacsTooltip -init): Remove bezels and add shadows to
5299 tooltip windows.
5300
bf3492a5
AA
5301 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5302 or scroll bar (Bug#8470).
5303
d55e9c53
AA
5304 * nsfont.m (nsfont_open): Remove assignment to voffset and
5305 unnecessary vars hshink, expand, hd, full_height, min_height.
5306 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5307
5308 * nsterm.h (nsfont_info): Remove voffset field.
5309
d8c2fa78 53102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5311
5312 Implement strike-through and overline on NextStep (Bug#8863).
5313
5314 * nsfont.m (nsfont_open): Use underline position provided by font,
5315 instead of hard-coded value of 2.
5316 (nsfont_draw): Call ns_draw_text_decoration instead.
5317
5318 * nsterm.h: Add declaration for ns_draw_text_decoration.
5319
5320 * nsterm.m (ns_draw_text_decoration): New function for drawing
5321 underline, overline, and strike-through.
5322 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5323 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5324 accommodate underlining, etc.
4843aac3 5325
4cc60b9b
EZ
53262011-07-28 Eli Zaretskii <eliz@gnu.org>
5327
bc7ece87
EZ
5328 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5329 default.
4cc60b9b 5330
476371c4
PE
53312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5332
66606eea
PE
5333 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5334 Without this fix, if a signal arrives just after memory fills up,
5335 'malloc' might be invoked reentrantly.
5336
476371c4
PE
5337 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5338 In other words, assume that every image size is allowed, on non-X
5339 hosts. This assumption is probably wrong, but it lets Emacs compile.
5340
f3fcc40d
AS
53412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5342
5343 * regex.c (re_iswctype): Convert return values to boolean.
5344
350c992f
EZ
53452011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5346
5347 * xdisp.c (compute_display_string_pos): Don't use cached display
5348 string position if the buffer had its restriction changed.
5349 (Bug#9184)
5350
5266b4bb
PE
53512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5352
5353 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5354
2573a837 53552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5356
41f55ccd 5357 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5358
39e378da
PE
5359 * bidi.c: Integer size and overflow fixes.
5360 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5361 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5362 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5363 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5364 (bidi_find_other_level_edge):
5365 Use ptrdiff_t instead of EMACS_INT where either will do.
5366 This works better on 32-bit hosts configured --with-wide-int.
5367 (bidi_cache_ensure_space): Check for size-calculation overflow.
5368 Use % rather than repeated addition, for better worst-case speed.
5369 Don't set bidi_cache_size until after xrealloc returns, because it
5370 might not return.
5371 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5372 (bidi_cache_ensure_space): Also check that the bidi cache size
5373 does not exceed that of the largest Lisp string or buffer. See Eli
5374 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5375
5e927815
PE
5376 * alloc.c (__malloc_size_t): Remove.
5377 All uses replaced by size_t. See Andreas Schwab's note
5378 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5379
ca4aa935
PE
5380 * image.c: Improve checking for integer overflow.
5381 (check_image_size): Assume that f is nonnull, since
5382 it is always nonnull in practice. This is one less thing to
5383 worry about when checking for integer overflow later.
5384 (x_check_image_size): New function, which checks for integer
5385 overflow issues inside X.
5386 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5387 This removes the need for a memory_full check.
5388 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5389 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5390 (xbm_read_bitmap_data): Change locals back to 'int', since
5391 their values must fit in 'int'.
5392 (xpm_load_image, png_load, tiff_load):
5393 Invoke x_create_x_image_and_pixmap earlier,
5394 to avoid much needless work if the image is too large.
5395 (tiff_load): Treat overly large images as if
5396 x_create_x_image_and_pixmap failed, not as malloc failures.
5397 (gs_load): Use x_check_image_size.
5398
5f8f9cc2
PE
5399 * gtkutil.c: Omit integer casts.
5400 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5401 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5402
5adf60bc
PE
5403 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5404
c8907a93
PE
5405 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5406 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5407 would wrongly return t on a 64-bit host.
5408
e3c25c68
PE
5409 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5410 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5411 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5412 and therefore cause GCC to emit a bogus diagnostic in some cases.
5413
3f791afe
PE
5414 * image.c: Integer signedness and overflow and related fixes.
5415 This is not an exhaustive set of fixes, but it's time to
5416 record what I've got.
5417 (lookup_pixel_color, check_image_size): Remove redundant decls.
5418 (check_image_size): Don't assume that arbitrary EMACS_INT values
5419 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5420 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5421 (tiff_load, imagemagick_load_image):
5422 Check for overflow in size calculations.
5423 (x_create_x_image_and_pixmap): Remove unnecessary test for
5424 xmalloc returning NULL; that can't happen.
5425 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5426 (xpm_color_bucket): Use better integer hashing function.
5427 (xpm_cache_color): Don't possibly over-allocate memory.
5428 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5429 (gif_memory_source):
5430 Use ptrdiff_t, not int or size_t, to record sizes.
5431 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5432 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5433 either works, as we prefer signed integers.
5434 (tiff_read_from_memory, tiff_write_from_memory):
5435 Return tsize_t, not size_t, since that's what the TIFF API wants.
5436 (tiff_read_from_memory): Don't fail simply because the read would
5437 go past EOF; instead, return a short read.
5438 (tiff_load): Omit no-longer-needed casts.
5439 (Fimagemagick_types): Don't assume size fits into 'int'.
5440
3cc5a532
PE
5441 Improve hashing quality when configured --with-wide-int.
5442 * fns.c (hash_string): New function, taken from sxhash_string.
5443 Do not discard information about ASCII character case; this
5444 discarding is no longer needed.
5445 (sxhash-string): Use it. Change sig to match it. Caller changed.
5446 * lisp.h: Declare it.
5447 * lread.c (hash_string): Remove, since we now use fns.c's version.
5448 The fns.c version returns a wider integer if --with-wide-int is
5449 specified, so this should help the quality of the hashing a bit.
5450
b312a492
PE
5451 * emacs.c: Integer overflow minor fix.
5452 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5453 Define only if GNU_LINUX.
5454 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5455
dfd153ae
PE
5456 * dispnew.c: Integer signedness and overflow fixes.
5457 Remove unnecessary forward decls, that were a maintenance hassle.
5458 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5459 All uses changed.
5460 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5461 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5462 (prepare_desired_row, line_draw_cost):
5463 Use int, not unsigned, where either works.
5464 (save_current_matrix, restore_current_matrix):
5465 Use ptrdiff_t, not size_t, where either works.
5466 (init_display): Check for overflow more accurately, and without
5467 relying on undefined behavior.
5468
a81d11a3
PE
5469 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5470 Remove, replacing with the new symbols in lisp.h. All uses changed.
5471 * fileio.c (make_temp_name):
5472 * filelock.c (lock_file_1, lock_file):
5473 * xdisp.c (message_dolog):
5474 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5475 Use pMd etc. instead.
5476 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5477 replacing the pWIDE etc. symbols removed from editfns.c.
5478
3300e6fd
PE
5479 * keyboard.h (num_input_events): Now uintmax_t.
5480 This is (very slightly) less likely to mess up due to wraparound.
5481 All uses changed.
5482
fd05c7e9
PE
5483 * buffer.c: Integer signedness fixes.
5484 (alloc_buffer_text, enlarge_buffer_text):
5485 Use ptrdiff_t rather than size_t when either will do, as we prefer
5486 signed integers.
5487
903fe15d
PE
5488 * alloc.c: Integer signedness and overflow fixes.
5489 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5490 (__malloc_size_t): Default to size_t, not to int.
5491 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5492 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5493 Prefer ptrdiff_t to size_t when either would do, as we prefer
5494 signed integers.
5495 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5496 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5497 Now const. Initialize with values that are in range even if char
5498 is signed.
5499 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5500 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5501 These functions do the right thing with sizes > 2**32.
5502 (check_depth): Now ptrdiff_t, not int.
5503 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5504 Adjust to new way of storing sizes. Check for size overflow bugs
5505 in rest of code.
5506 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5507 slightly wrong anyway, as it missed one instance of
5508 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5509 (refill_memory_reserve): Omit needless cast to size_t.
5510 (mark_object_loop_halt): Mark as externally visible.
5511
ac82cc6a
PE
5512 * xselect.c: Integer signedness and overflow fixes.
5513 (Fx_register_dnd_atom, x_handle_dnd_message):
5514 Use ptrdiff_t, not size_t, since we prefer signed.
5515 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5516 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5517 x_dnd_atoms_size and x_dnd_atoms_length.
5518
c2d1e36d
PE
5519 * doprnt.c: Prefer signed to unsigned when either works.
5520 * eval.c (verror):
5521 * doprnt.c (doprnt):
5522 * lisp.h (doprnt):
5523 * xdisp.c (vmessage):
5524 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5525 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5526 prefer signed arithmetic to avoid comparison confusion.
5527 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5528 but is a bit tricky.
5529
0e926e56
PE
5530 Assume freestanding C89 headers, string.h, stdlib.h.
5531 * data.c, doprnt.c, floatfns.c, print.c:
5532 Include float.h unconditionally.
5533 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5534 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5535 * regex.c: Likewise for stddef.h, string.h.
5536 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5537 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5538 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5539 (STDC_HEADERS): Remove obsolete defines.
5540 * sysdep.c: Include limits.h unconditionally.
5541
9cfdb3ec
PE
5542 Assume support for memcmp, memcpy, memmove, memset.
5543 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5544 * regex.c (memcmp, memcpy):
5545 Remove; we assume C89 now.
5546
5547 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5548 (__malloc_safe_bcopy): Remove; no longer needed.
5549
cf950e6b 5550 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5551 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5552 well either way, and we prefer signed to unsigned.
5553
dbf38e02
LMI
55542011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5555
5556 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5557 closes the connection while we're reading (bug#9182).
5558
d6f0886c 55592011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5560
d6f0886c
JD
5561 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5562 are specified (Bug#9168).
24e0f6b1 5563
2eb1f9e6
PE
55642011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5567 Found by GCC static checking and --with-wide-int on a 32-bit host.
5568
22381272 55692011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5570
5571 * xdisp.c (compute_display_string_pos): Fix logic of caching
5572 previous display string position. Initialize cached_prev_pos to
5573 -1. Fixes slow-down at the beginning of a buffer.
5574
f25e39b4
EZ
55752011-07-24 Eli Zaretskii <eliz@gnu.org>
5576
5577 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5578 for attrs[LFACE_FONTSET_INDEX].
5579
04c4b52e
PE
55802011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5581
5582 * xml.c (parse_region): Remove unused local
5583 that was recently introduced.
5584
c1734fbd
EZ
55852011-07-23 Eli Zaretskii <eliz@gnu.org>
5586
be18c5a5
EZ
5587 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5588 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5589
c1734fbd
EZ
5590 * xdisp.c (move_it_in_display_line_to): Record the best matching
5591 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5592 exit if none of the characters scanned was an exact match.
5593 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5594 when exact match is impossible due to invisible text, and the
5595 lines are truncated.
5596
a258d627
JD
55972011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5598
5599 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5600 for OSX >= 10.7.
5601
b6d5a689
EZ
56022011-07-22 Eli Zaretskii <eliz@gnu.org>
5603
0f74f785
EZ
5604 Fix a significant slow-down of cursor motion with C-n, C-p,
5605 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5606 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5607 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5608 (next_element_from_buffer): Call compute_stop_pos_backwards to
5609 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5610 base_level_stop.
5611 (reseat): Don't look for prev_stop, as that could mean a very long
5612 run.
5613 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5614 <cached_disp_overlay_modiff>: Cache for last found display string
5615 position.
551918c1 5616 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5617 about the same buffer in the same area of character positions, and
5618 the buffer wasn't changed since the time the display string
5619 position was cached.
551918c1 5620
b2d0c91a
EZ
56212011-07-22 Eli Zaretskii <eliz@gnu.org>
5622
5623 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5624 is an integer, which is important for empty lines. (Bug#9149)
5625
043604ee
CY
56262011-07-22 Chong Yidong <cyd@stupidchicken.com>
5627
5628 * frame.c (Fmodify_frame_parameters): In tty case, update the
5629 default face if necessary (Bug#4238).
5630
da4adb04
CY
56312011-07-21 Chong Yidong <cyd@stupidchicken.com>
5632
5633 * editfns.c (Fstring_to_char): No need to explain what a character
5634 is in the docstring (Bug#6576).
5635
9abd0532
LMI
56362011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5637
5638 * xml.c (parse_region): Make sure we always return a tree.
5639
36881d16
HK
56402011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5641
5642 * xml.c (parse_region): If a document contains only comments,
5643 return that, too.
5644
1e98674d
LMI
56452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5646
5647 * xml.c (make_dom): Return comments, too.
5648
590bd467
PE
56492011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5650
5651 Port to OpenBSD.
5652 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5653 and the surrounding thread.
5654 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5655 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5656 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5657 timer goes off.
5658 * s/openbsd.h (BROKEN_SIGIO): Define.
5659 * unexelf.c (unexec) [__OpenBSD__]:
5660 Don't update the .mdebug section of the Alpha COFF symbol table.
5661
f41628b2
LMI
56622011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5663
5664 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5665 (bug#8460).
5666
b59b67c5
PE
56672011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5668
15e3a074
PE
5669 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5670 This fixes some race conditions on the permissions of any newly
5671 created file.
5672
41bed37d
PE
5673 * alloc.c (valid_pointer_p): Use pipe, not open.
5674 This fixes some permissions issues when debugging.
5675
b59b67c5
PE
5676 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5677 If fchown fails to set both uid and gid, try to set just gid,
5678 as that is sometimes allowed. Adjust the file's mode to eliminate
5679 setuid or setgid bits that are inappropriate if fchown fails.
5680
925a6be7
SM
56812011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5682
5683 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5684 to compare Lisp_Objects.
5685 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5686 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5687 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5688
52968808
AS
56892011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5690
0a6a104b
AS
5691 * lread.c (read_integer): Unread even EOF character.
5692 (read1): Likewise. Properly record start position of symbol.
5693
52968808
AS
5694 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5695 symbol character follows.
5696
9e381cdd
PE
56972011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5700 This works around a problem with the previous change to Fcopy_file.
5701 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5702 and without this change, GCC might complain about discarding
5703 fchown's return value.
5704
b5641435
JB
57052011-07-16 Juanma Barranquero <lekktu@gmail.com>
5706
5707 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5708
a8031457
PE
57092011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5710
5711 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5712
dd889327
LMI
57132011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5714
750c33f7
LMI
5715 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5716 it's used from the C level.
5717
dd889327
LMI
5718 * process.c: Use the same condition for POLL_FOR_INPUT in both
5719 keyboard.c and process.c (bug#1858).
5720
87e86684
LM
57212011-07-09 Lawrence Mitchell <wence@gmx.li>
5722
5723 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5724 (Fgnutls_boot): Use it.
5725
64348f40
AS
57262011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5727
5728 * doc.c (Fsubstitute_command_keys): Revert last change.
5729
1d698799
LMI
57302011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5731
f863868c
LMI
5732 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5733 quotes the next character, and doesn't affect other longer
5734 sequences (bug#8935).
5735
1d698799
LMI
5736 * lread.c (syms_of_lread): Clarify that is isn't only
5737 `eval-buffer' and `eval-defun' that's affected by
5738 `lexical-binding' (bug#8460).
5739
aa4b6df6
EZ
57402011-07-15 Eli Zaretskii <eliz@gnu.org>
5741
5742 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5743 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5744
5d856da6
PE
57452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5746
ad6042bb
PE
5747 Fix minor problems found by static checking.
5748 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5749 (elsz): Now a signed constant, not a size_t var. We prefer signed
5750 types to unsigned, to avoid integer comparison confusion. Without
5751 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5752 "cannot optimize loop, the loop counter may overflow", a symptom
5753 of the confusion.
f00bbb22 5754 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5755 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5756
6468f31c
LMI
57572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5758
49080b10
LMI
5759 * search.c (Fre_search_backward): Mention `case-fold-search' in
5760 all the re_search_* functions (bug#8138).
5761
6468f31c
LMI
5762 * keyboard.c (Fopen_dribble_file): Document when the file is
5763 closed (bug#8056).
5764
c965adc5
EZ
57652011-07-14 Eli Zaretskii <eliz@gnu.org>
5766
df9733bf
EZ
5767 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5768 bidi_cache_idx.
5769
0bb23927
EZ
5770 Support bidi reordering of display and overlay strings.
5771 * xdisp.c (compute_display_string_pos)
5772 (compute_display_string_end): Accept additional argument STRING.
5773 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5774 (reseat_to_string): Initialize bidi_it->string.s and
5775 bidi_it->string.schars.
5776 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5777 NULL (avoids a crash in bidi_paragraph_init).
5778 Initialize itb.string.lstring.
0bb23927
EZ
5779 (init_iterator): Call bidi_init_it only of a valid
5780 buffer position was specified. Initialize paragraph_embedding to
5781 L2R.
5782 (reseat_to_string): Initialize the bidi iterator.
5783 (display_string): If we need to ignore text properties of
5784 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5785 original value of -1 will not work with bidi.)
5786 (compute_display_string_pos): First arg is now struct
5787 `text_pos *'; all callers changed. Support display properties on
5788 Lisp strings.
5789 (compute_display_string_end): Support display properties on Lisp
5790 strings.
5791 (init_iterator, reseat_1, reseat_to_string): Initialize the
5792 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5793 when iterating on a string not from display properties).
640c8776
SM
5794 (compute_display_string_pos, compute_display_string_end):
5795 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5796 arrow keys.
5797 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5798 base_level_stop; instead, set base_level_stop to BEGV.
5799 Fixes crashes in vertical-motion.
0bb23927
EZ
5800 (next_element_from_buffer): Improve commentary for when
5801 the iterator is before prev_stop.
5802 (init_iterator): Initialize bidi_p from the default value of
5803 bidi-display-reordering, not from buffer-local value. Use the
5804 buffer-local value only if initializing for buffer iteration.
5805 (handle_invisible_prop): Support invisible properties on strings
5806 that are being bidi-reordered.
5807 (set_iterator_to_next): Support bidi reordering of C strings and
5808 Lisp strings.
5809 (next_element_from_string): Support bidi reordering of Lisp
5810 strings.
5811 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5812 (display_string): Support display of R2L glyph rows.
5813 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5814 (init_iterator): Don't initialize it->bidi_p for strings
5815 here.
5816 (reseat_to_string): Initialize it->bidi_p for strings here.
5817 (next_element_from_string, next_element_from_c_string)
5818 (next_element_from_buffer): Add xassert's for correspondence
5819 between IT's object being iterated and it->bidi_it.string
5820 structure.
5821 (face_before_or_after_it_pos): Support bidi iteration.
5822 (next_element_from_c_string): Handle the case of the first string
5823 character that is not the first one in the visual order.
5824 (get_visually_first_element): New function, refactored from common
5825 parts of next_element_from_buffer, next_element_from_string, and
5826 next_element_from_c_string.
5827 (tool_bar_lines_needed, redisplay_tool_bar)
5828 (display_menu_bar): Force left-to-right direction. Add a FIXME
5829 comment for making that be controlled by a user option.
5830 (push_it, pop_it): Save and restore the state of the
5831 bidi iterator. Save and restore the bidi_p flag.
5832 (pop_it): Iterate out of display property for string iteration as
5833 well.
5834 (iterate_out_of_display_property): Support iteration over strings.
5835 (handle_single_display_spec): Set up it->bidi_it for iteration
5836 over a display string, and call bidi_init_it.
5837 (handle_single_display_spec, next_overlay_string)
5838 (get_overlay_strings_1, push_display_prop): Set up the bidi
5839 iterator for displaying display or overlay strings.
5840 (forward_to_next_line_start): Don't use the shortcut if
5841 bidi-iterating.
5842 (back_to_previous_visible_line_start): If handle_display_prop
5843 pushed the iterator stack, restore the internal state of the bidi
5844 iterator by calling bidi_pop_it same number of times.
5845 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5846 and we are bidi-iterating, don't decrement the iterator position;
5847 instead, set the first_elt flag in the bidi iterator, to produce
5848 the same effect.
5849 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5850 (push_display_prop): xassert that we are iterating a buffer.
5851 (push_it, pop_it): Save and restore paragraph_embedding member.
5852 (handle_single_display_spec, next_overlay_string)
5853 (get_overlay_strings_1, reseat_1, reseat_to_string)
5854 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5855 correctly. Don't assume unibyte strings are not bidi-reordered.
5856 (compute_display_string_pos)
5857 (compute_display_string_end): Fix handling the case of C string.
5858 (push_it, pop_it): Save and restore from_disp_prop_p.
5859 (handle_single_display_spec, push_display_prop): Set the
5860 from_disp_prop_p flag.
5861 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5862 (pop_it): Call iterate_out_of_display_property only if we are
5863 popping after iteration over a string that came from a display
5864 property. Fix a typo in popping stretch info. Add an assertion
5865 for verifying that the iterator position is in sync with the bidi
5866 iterator.
5867 (handle_single_display_spec, get_overlay_strings_1)
5868 (push_display_prop): Fix initialization of paragraph direction for
5869 string when that of the parent object is not yet determined.
5870 (reseat_1): Call bidi_init_it to resync the bidi
5871 iterator with IT's position. (Bug#7616)
5872 (find_row_edges): If ROW->start.pos gives position
5873 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5874 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5875 Reset the from_disp_prop_p flag.
5876 (SAVE_IT, RESTORE_IT): New macros.
5877 (pos_visible_p, face_before_or_after_it_pos)
5878 (back_to_previous_visible_line_start)
5879 (move_it_in_display_line_to, move_it_in_display_line)
5880 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5881 (try_scrolling, redisplay_window, display_line): Use them when
5882 saving a temporary copy of the iterator and restoring it back.
5883 (back_to_previous_visible_line_start, reseat_1)
5884 (init_iterator): Empty the bidi cache "stack".
5885 (move_it_in_display_line_to): If iterator ended up at
5886 EOL, but we never saw any buffer positions smaller than
5887 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5888 motion in bidi-reordered lines.
5889 (move_it_in_display_line_to): Record prev_method and prev_pos
5890 immediately before the call to set_iterator_to_next. Fixes cursor
5891 motion in bidi-reordered lines with stretch glyphs and strings
5892 displayed in margins. (Bug#8133) (Bug#8867)
5893 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5894 TO_CHARPOS.
640c8776
SM
5895 (pos_visible_p): Support positions in bidi-reordered lines.
5896 Save and restore bidi cache.
0bb23927
EZ
5897
5898 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5899 (bidi_paragraph_info): Delete unused struct.
5900 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5901 (bidi_cache_start): New variable.
5902 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5903 to zero.
5904 (bidi_cache_fetch_state, bidi_cache_search)
5905 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5906 (bidi_cache_find, bidi_peek_at_next_level)
5907 (bidi_level_of_next_char, bidi_find_other_level_edge)
5908 (bidi_move_to_visually_next): Compare cache index with
5909 bidi_cache_start rather than with zero.
5910 (bidi_fetch_char): Accept new argument STRING; all callers
5911 changed. Support iteration over a string. Support strings with
5912 display properties. Support unibyte strings. Fix the type of
5913 `len' according to what STRING_CHAR_AND_LENGTH expects.
5914 (bidi_paragraph_init, bidi_resolve_explicit_1)
5915 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5916 (bidi_level_of_next_char, bidi_move_to_visually_next):
5917 Support iteration over a string.
0bb23927
EZ
5918 (bidi_set_sor_type, bidi_resolve_explicit_1)
5919 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5920 can now be zero (for strings); special values 0 and -1 were
5921 changed to -1 and -2, respectively.
5922 (bidi_char_at_pos): New function.
5923 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5924 Call it instead of FETCH_MULTIBYTE_CHAR.
5925 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5926 initialized to valid values.
5927 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5928 values.
5929 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5930 the test for valid cached positions. Fix the logic for looking up
5931 the sentinel state in the cache. GCPRO the Lisp string we are
5932 iterating.
5933 (bidi_push_it, bidi_pop_it): New functions.
5934 (bidi_initialize): Initialize the bidi cache start stack pointer.
5935 (bidi_cache_ensure_space): New function, refactored from part of
5936 bidi_cache_iterator_state. Don't assume the required size is just
5937 one BIDI_CACHE_CHUNK away.
5938 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5939 (bidi_count_bytes, bidi_char_at_pos): New functions.
5940 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5941 always valid if bidi_cache_idx is valid.
5942 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5943 is valid if it's going to be used.
5944 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5945 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5946 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5947 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5948 (bidi_find_other_level_edge, bidi_cache_start_stack):
5949 All variables related to cache indices are now EMACS_INT.
c965adc5 5950
0bb23927
EZ
5951 * dispextern.h (struct bidi_string_data): New structure.
5952 (struct bidi_it): New member `string'. Make flag members be 1-bit
5953 fields, and put them last in the struct.
640c8776
SM
5954 (compute_display_string_pos, compute_display_string_end):
5955 Update prototypes.
0bb23927
EZ
5956 (bidi_push_it, bidi_pop_it): Add prototypes.
5957 (struct iterator_stack_entry): New members bidi_p,
5958 paragraph_embedding, and from_disp_prop_p.
5959 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5960 (bidi_shelve_cache, bidi_unshelve_cache):
5961 Declare prototypes.
0bb23927
EZ
5962
5963 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5964 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5965 and vector-like objects.
5966
5967 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5968 cache around display iteration.
5969
5970 * window.c (Fwindow_end, window_scroll_pixel_based)
5971 (displayed_window_lines, Frecenter): Save and restore the bidi
5972 cache around display iteration.
5973
3bbd2265
LMI
59742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5975
5976 * editfns.c (Fdelete_region): Clarify the use of the named
5977 parameters (bug#6788).
5978
adc47434
MR
59792011-07-14 Martin Rudalics <rudalics@gmx.at>
5980
5981 * indent.c (Fvertical_motion): Set and restore w->pointm when
5982 saving and restoring the window's buffer (Bug#9006).
5983
837c31f8
LMI
59842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5985
5986 * editfns.c (Fstring_to_char): Clarify just what is returned
5987 (bug#6576). Text by Eli Zaretskii.
5988
ac389d0c
JB
59892011-07-13 Juanma Barranquero <lekktu@gmail.com>
5990
5991 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5992
0be0ce47
EZ
59932011-07-13 Eli Zaretskii <eliz@gnu.org>
5994
5995 * buffer.c (mmap_find): Fix a typo.
5996
cd18e7e3
JB
59972011-07-13 Johan Bockgård <bojohan@gnu.org>
5998
5999 Fix execution of x selection hooks.
6000 * xselect.c (Qx_lost_selection_functions)
6001 (Qx_sent_selection_functions): New vars.
6002 (syms_of_xselect): DEFSYM them.
6003 (x_handle_selection_request): Pass Qx_sent_selection_functions
6004 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6005 (x_handle_selection_clear,x_clear_frame_selections):
6006 Pass Qx_lost_selection_functions rather than
6007 Vx_lost_selection_functions to Frun_hook_with_args.
6008
47ea7f44
PE
60092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6010
ac389d0c 6011 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6012 The old code sometimes used this field without initializing it.
6013
47ea7f44
PE
6014 * alloc.c (gc_sweep): Don't read past end of array.
6015 In theory, the old code could also have corrupted Emacs internals,
6016 though it'd be very unlikely.
6017
bc985c87
AS
60182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6019
6020 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6021 argument. (Bug#4026)
bc985c87 6022
0cf34688
LMI
60232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6024
b3dadd76
LMI
6025 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6026 key" (bug#4257).
6027
0cf34688
LMI
6028 * window.c (Fset_window_start): Doc fix (bug#4199).
6029 (Fset_window_hscroll): Ditto.
6030
270768cd
PE
60312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6032
077e3dda 6033 Fix minor new problems caught by GCC 4.6.1.
270768cd 6034 * term.c (init_tty): Remove unused local.
490011a6 6035 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6036 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6037 not used otherwise.
270768cd 6038
b1f58454
CY
60392011-07-12 Chong Yidong <cyd@stupidchicken.com>
6040
6041 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6042
22b9578d
LMI
60432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6044
6e70ab07
LMI
6045 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6046 are the mini-buffer and the echo area (bug#3320).
6047
22b9578d
LMI
6048 * term.c (init_tty): Remove support for supdup, c10 and perq
6049 terminals, which are no longer supported (bug#1482).
6050
8974cc9f
JB
60512011-07-10 Johan Bockgård <bojohan@gnu.org>
6052
6053 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6054
a560d974
JD
60552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6056
6057 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6058 for non-popups (Bug#3642).
6059
1dae0f0a
AS
60602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6061
268c2c36 6062 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6063 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6064 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6065 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6066 * data.c (fmod): Likewise.
6067 * dispnew.c (swap_glyphs_in_rows): Likewise.
6068 * emacs.c (memory_warning_signal): Likewise.
6069 * floatfns.c (float_error): Likewise.
6070 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6071 (otf_open, font_otf_capability, generate_otf_features)
6072 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6073 Likewise.
6074 * image.c (pbm_read_file): Likewise.
6075 * indent.c (string_display_width): Likewise.
6076 * intervals.c (check_for_interval, search_for_interval)
6077 (inc_interval_count, count_intervals, root_interval)
6078 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6079 * lread.c (defalias): Likewise.
268c2c36 6080 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6081 * regex.c (set_image_of_range_1, set_image_of_range)
6082 (regex_grow_registers): Likewise.
6083 * sysdep.c (strerror): Likewise.
6084 * termcap.c (valid_filename_p, tprint, main): Likewise.
6085 * tparam.c (main): Likewise.
6086 * unexhp9k800.c (run_time_remap, save_data_space)
6087 (update_file_ptrs, read_header, write_header, calculate_checksum)
6088 (copy_file, copy_rest, display_header): Likewise.
6089 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6090 Likewise.
6091 * xdisp.c (check_it): Likewise.
6092 * xfaces.c (register_color, unregister_color, unregister_colors):
6093 Likewise.
6094 * xfns.c (print_fontset_result): Likewise.
6095 * xrdb.c (member, fatal, main): Likewise.
6096
99033785
PE
60972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6098
6099 Fix minor problems found by static checking (Bug#9031).
6100 * chartab.c (char_table_set_range, map_sub_char_table):
6101 Remove unused locals.
6102 (uniprop_table): Now static.
6103 * composite.c (_work_char): Remove unused static var.
6104
9cb2ac56
JB
61052011-07-09 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6108
f25661f0
JD
61092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6110
6111 * gtkutil.c (qttip_cb): Remove code without function.
6112
8278c4fe
EZ
61132011-07-09 Eli Zaretskii <eliz@gnu.org>
6114
6115 * w32.c (pthread_sigmask): New stub.
6116
1692ae2d 61172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6118
8a6ebd58 6119 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6120 sigprocmask is portable only for single-threaded applications, and
6121 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6122 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6123 (LIBES): Use it.
6124 * callproc.c (Fcall_process):
6125 * process.c (create_process):
6126 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6127 Use pthread_sigmask, not sigprocmask.
123403e4 6128
1b854618
JD
61292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6130
6131 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6132 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6133 wrong (Bug#8591).
6134
3fe4b549
JD
61352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6136
0ce7e563
JD
6137 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6138 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6139 (xg_hide_tooltip): Fix comment.
6140
3fe4b549
JD
6141 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6142 in registerServicesMenuSendTypes.
6143 (validRequestorForSendType): Don't check ns_return_types.
6144
6145 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6146 ns_return_type.
6147
5df75e47
JR
61482011-07-08 Jason Rumney <jasonr@gnu.org>
6149
22610910
JR
6150 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6151 SH_SHOW for hidden windows (Bug#5482).
6152
5df75e47
JR
6153 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6154 frame struct members of non-existent frames (Bug#6284).
6155
699c10bd
JD
61562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6157
4393663b
JD
6158 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6159 variable firstTime not needed on OSX >= 10.6.
6160 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6161 >= 10.5. Use setKnobProportion, setDoubleValue.
6162
6163 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6164 (MAC_OS_X_VERSION_10_5): Define if not defined.
6165 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6166 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6167 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6168
6169 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6170 cString and lossyCString on OSX >= 10.4
6171
58179cce 6172 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6173 sizeToFit on OSX >= 10.2.
6174
6175 * nsimage.m (allocInitFromFile): Don't use deprecated method
6176 bestRepresentationForDevice on OSX >= 10.6.
6177
6178 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6179 to avoid warning.
6180
6181 * emacs.c: Declare unexec_init_emacs_zone.
6182
a63e0781
JD
6183 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6184
699c10bd
JD
6185 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6186
6187 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6188 on svcsMenu (Bug#8842).
6189
6190 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6191 ns_return_types.
6192 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6193
6194 * nsterm.m (QUTF8_STRING): Declare.
6195 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6196 (validRequestorForSendType): Return type is (id).
6197 Change indexOfObjectIdenticalTo to indexOfObject.
6198 Check if we have local selection before returning self (Bug#8842).
6199 (writeSelectionToPasteboard): Put local selection into paste board
6200 if we have a local selection (Bug#8842).
6201 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6202
6203 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6204 (ns_get_local_selection): Declare.
6205
54e10184
LMI
62062011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6207
9888ff71
LMI
6208 * keymap.c (describe_map_tree): Don't insert a double newline at
6209 the end of the buffer (bug#1169) and return whether we inserted
6210 something.
6211
54e10184
LMI
6212 * callint.c (Fcall_interactively): Change "reading args" to
6213 "providing args" to try to clarify what it does (bug#1010).
6214
15fa4783
KH
62152011-07-07 Kenichi Handa <handa@m17n.org>
6216
6217 * composite.c (composition_compute_stop_pos): Ignore a static
6218 composition starting before CHARPOS (Bug#8915).
6219
6220 * xdisp.c (handle_composition_prop): Likewise.
6221
a8815b00
EZ
62222011-07-07 Eli Zaretskii <eliz@gnu.org>
6223
6224 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6225 (Bug#9015)
6226
ef7b981d 62272011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6228
6229 * character.h (unicode_category_t): New enum type.
6230
6231 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6232 (Qchar_code_property_table): New variable.
6233 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6234 (UNIPROP_COMPRESSED_FORM_P): New macros.
6235 (char_table_ascii): Uncompress the compressed values.
6236 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6237 Uncompress the compressed values.
ac389d0c 6238 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6239 (char_table_ref_and_range): Uncompress the compressed values.
6240 (sub_char_table_set): New arg is_uniprop. Callers changed.
6241 Uncompress the compressed values.
6242 (sub_char_table_set_range): Args changed. Callers changed.
6243 (char_table_set_range): Adjuted for the above change.
6244 (map_sub_char_table): Delete args default_val and parent. Add arg
6245 top. Give decoded values to a Lisp function.
640c8776 6246 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6247 values to a Lisp function. Gcpro more variables.
6248 (uniprop_table_uncompress)
6249 (uniprop_decode_value_run_length): New functions.
6250 (uniprop_decoder, uniprop_decoder_count): New variables.
6251 (uniprop_get_decoder, uniprop_encode_value_character)
6252 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6253 New functions.
6254 (uniprop_encoder, uniprop_encoder_count): New variables.
6255 (uniprop_get_encoder, uniprop_table)
6256 (Funicode_property_table_internal, Fget_unicode_property_internal)
6257 (Fput_unicode_property_internal): New functions.
6258 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6259 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6260 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6261 char-code-property-alist.
6262
640c8776 6263 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6264 Vunicode_category_table.
6265
640c8776 6266 * font.c (font_range): Adjust for the change of
c805dec0
KH
6267 Vunicode_category_table.
6268
76b397fb
DN
62692011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6270
6271 * m/iris4d.h: Remove file, move contents ...
6272 * s/irix6-5.h: ... here.
6273
22b4128e
PE
62742011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6275
6276 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6277 * alloc.c (mark_buffer):
6278 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6279 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6280 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6281 This isn't true in general, and it's particularly not true
6282 if Emacs is configured with --with-wide-int.
6283 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6284 New macros, used in the buffer.c change.
6285
869795d6
JD
62862011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6287
6288 * xsettings.c: Use both GConf and GSettings if both are available.
6289 (store_config_changed_event): Add comment.
6290 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6291 (store_tool_bar_style_changed): New functions.
5e617bc2 6292 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6293 (struct xsettings): Move font inside HAVE_XFT.
6294 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6295 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6296 Move inside HAVE_XFT.
640c8776 6297 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6298 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6299 also.
6300 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6301 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6302 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6303 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6304 (parse_settings): Move check for font inside HAVE_XFT.
6305 (read_settings, apply_xft_settings): Add comment.
6306 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6307 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6308 call store_font_name_changed.
6309 (xft_settings_event): Add comment.
6310 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6311 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6312 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6313 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6314 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6315 (xsettings_get_system_font, xsettings_get_system_normal_font):
6316 Add comment.
869795d6 6317
d8ed26bd
PE
63182011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6319
6320 Random fixes. E.g., (random) never returned negative values.
6321 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6322 subseconds part to the entropy, as that's a bit more random.
6323 Prefer signed to unsigned, since the signedness doesn't matter and
6324 in general we prefer signed. When given a limit, use a
6325 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6326 latter isn't right if USE_2_TAGS_FOR_INTS.
6327 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6328 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6329
cabf1cac
SM
63302011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6331
6332 * textprop.c (text_property_stickiness):
6333 Obey Vtext_property_default_nonsticky.
6334 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6335 * w32fns.c (syms_of_w32fns):
6336 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6337
6e9b2be9
PE
63382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6341 This is more efficient than Ffile_directory_p and avoids a minor race.
6342
90186c68
LMI
63432011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6344
7c301272
LMI
6345 * buffer.c (Foverlay_put): Say what the return value is
6346 (bug#7835).
6347
c4f2d8d4
LMI
6348 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6349 is a directory before asking whether to use the file name
6350 (bug#7564).
ad637907
LMI
6351 (barf_or_query_if_file_exists): Make the "File is a directory"
6352 error be more correct.
c4f2d8d4 6353
90186c68
LMI
6354 * fns.c (Frequire): Remove the mention of the .gz files, since
6355 that's installation-specific, but keep the mention of
6356 `get-load-suffixes'.
6357
da64016e
PE
63582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6359
6360 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6361 Report string overflow if the output is too long.
6362
7d47b580
JB
63632011-07-04 Juanma Barranquero <lekktu@gmail.com>
6364
a555cb87
JB
6365 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6366 (syms_of_gnutls): Remove duplicate DEFSYM for
6367 Qgnutls_bootprop_verify_hostname_error, an error for
6368 Qgnutls_bootprop_verify_error (which is no longer used).
6369
7d47b580
JB
6370 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6371 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6372 Also (re)move comments that are misplaced or no longer relevant.
6373
1e49bfab
LMI
63742011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6375
6376 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6377
1485f4c0
CY
63782011-07-03 Chong Yidong <cyd@stupidchicken.com>
6379
6380 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6381 and background color parameters if they have been changed.
6382
a9ab721e
LMI
63832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6384
6385 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6386
cf7cff57
PE
63872011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6388
2e13213d
PE
6389 * xsettings.c (SYSTEM_FONT): Define only when used.
6390 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6391
cf7cff57
PE
6392 * keymap.c (access_keymap_1): Now static.
6393
7a8e04f7
CY
63942011-07-02 Chong Yidong <cyd@stupidchicken.com>
6395
6396 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6397 leave any prefix arg for the up event (Bug#1586).
6398
61352f62
LMI
63992011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6400
69bb1ef7
LMI
6401 * lread.c (syms_of_lread): Mention single symbols defined by
6402 `defvar' or `defconst' (bug#7154).
6403
61352f62 6404 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6405 (Frequire): Mention get-load-suffixes.
61352f62 6406
28545e04
MR
64072011-07-02 Martin Rudalics <rudalics@gmx.at>
6408
6409 * window.h (window): Remove clone_number slot.
6410 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6411 Remove.
6412 (make_parent_window, make_window, saved_window)
6413 (Fset_window_configuration, save_window_save): Don't deal with
6414 clone numbers.
6415 * buffer.c (Qclone_number): Remove declaration.
6416 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6417
3349e122
SM
64182011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6419
6420 Add multiple inheritance to keymaps.
6421 * keymap.c (Fmake_composed_keymap): New function.
6422 (Fset_keymap_parent): Simplify.
6423 (fix_submap_inheritance): Remove.
6424 (access_keymap_1): New function extracted from access_keymap to handle
6425 embedded parents and handle lists of maps.
6426 (access_keymap): Use it.
6427 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6428 (Fcopy_keymap): Handle embedded parents.
6429 (Fcommand_remapping, define_as_prefix): Simplify.
6430 (Fkey_binding): Simplify.
6431 (syms_of_keymap): Move minibuffer-local-completion-map,
6432 minibuffer-local-filename-completion-map,
6433 minibuffer-local-must-match-map, and
6434 minibuffer-local-filename-must-match-map to Elisp.
6435 (syms_of_keymap): Defsubr make-composed-keymap.
6436 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6437 (parse_menu_item): Trivial simplification.
6438
3279eb87
GM
64392011-07-01 Glenn Morris <rgm@gnu.org>
6440
6441 * Makefile.in (SETTINGS_LIBS): Fix typo.
6442
4550efdf
KI
64432011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6444
6445 * coding.c (Fencode_coding_string): Record the last coding system
6446 used, as the function doc string says (bug#8738).
6447
0949d2b6
JD
64482011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6449
6450 * xsettings.c (store_monospaced_changed): Take new font as arg and
6451 check for change against current_mono_font.
6452 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6453 (emacs_settings_constructor, emacs_settings_get_property)
6454 (emacs_settings_set_property, emacs_settings_class_init)
6455 (emacs_settings_init, gsettings_obj): Remove.
6456 (something_changedCB): New function for HAVE_GSETTINGS.
6457 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6458 with value as argument.
6459 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6460 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6461 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6462 "changed".
6463
6464 * xgselect.c: Add defined (HAVE_GSETTINGS).
6465 (xgselect_initialize): Ditto.
6466
6467 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6468 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6469 xg_select.
6470
bbc6b304
PE
64712011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6472
6473 * eval.c (struct backtrace): Simplify and port the data structure.
6474 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6475 signed bit field, as this assumption is not portable and it makes
6476 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6477 "char debug_on_exit : 1" as this is not portable either; instead,
6478 use the portable "unsigned int debug_on_exit : 1". Remove unused
6479 member evalargs. Remove obsolete comments about cc bombing out.
6480
9851bfc5
JD
64812011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6482
51bb811f 6483 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6484 Let HAVE_GSETTINGS override HAVE_GCONF.
6485 (store_monospaced_changed): New function.
6486 (EMACS_SETTINGS): A new type derived from GObject to handle
6487 GSettings notifications.
6488 (emacs_settings_constructor, emacs_settings_get_property)
6489 (emacs_settings_set_property, emacs_settings_class_init):
6490 New functions.
6491 (gsettings_client, gsettings_obj): New variables.
6492 (GSETTINGS_SCHEMA): New define.
6493 (something_changedCB): Call store_monospaced_changed.
6494 (init_gsettings): New function.
6495 (xsettings_initialize): Call init_gsettings.
6496 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6497 to NULL.
6498
640c8776 6499 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6500 GCONF_CFLAGS/LIBS.
6501
5386012d
MR
65022011-06-29 Martin Rudalics <rudalics@gmx.at>
6503
6504 * window.c (resize_root_window, grow_mini_window)
6505 (shrink_mini_window): Rename Qresize_root_window to
6506 Qwindow_resize_root_window and Qresize_root_window_vertically to
6507 Qwindow_resize_root_window_vertically.
6508
f13e0b08
PE
65092011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6510
6511 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6512
94515237
JB
65132011-06-27 Juanma Barranquero <lekktu@gmail.com>
6514
6515 * makefile.w32-in: Redesign dependencies so they reflect more
6516 clearly which files are directly included by each source file,
6517 and not through other includes.
6518
e43b6e43
MR
65192011-06-27 Martin Rudalics <rudalics@gmx.at>
6520
6521 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6522 (sort_overlays, overlay_strings): When an overlay's clone number
6523 matches the window's clone number process the overlay even if
6524 the overlay's window property doesn't match the current window.
6525
d68443dc
MR
6526 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6527 (Fwindow_hchild): Rename to Fwindow_left_child.
6528 (Fwindow_next): Rename to Fwindow_next_sibling.
6529 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6530 (resize_window_check): Rename to window_resize_check.
6531 (resize_window_apply): Rename to window_resize_apply.
6532 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6533 (Fdelete_other_windows_internal, resize_frame_windows)
6534 (Fsplit_window_internal, Fdelete_window_internal)
6535 (grow_mini_window, shrink_mini_window)
6536 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6537
c7e73be5
JD
65382011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6539
6540 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6541 (emacs_fixed_set_min_size): Remove.
6542 (emacs_fixed_new): Take frame as argument.
6543
6544 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6545 (_EmacsFixedPrivate): Remove minwidth/height.
6546 Add struct frame *f.
6547 (emacs_fixed_init): Initialize priv->f.
6548 (get_parent_class, emacs_fixed_set_min_size): Remove.
6549 (emacs_fixed_new): Set priv->f to argument.
6550 (emacs_fixed_get_preferred_width)
6551 (emacs_fixed_get_preferred_height): Use min_width/height from
6552 frames size_hint to set minimum and natural (Bug#8919).
6553 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6554 and use min_width/height from frames size_hint to set
6555 min_width/height (Bug#8919).
6556
6557 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6558 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6559 Fix indentation.
c7e73be5 6560
cf99dcf8
EZ
65612011-06-26 Eli Zaretskii <eliz@gnu.org>
6562
6563 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6564 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6565 called at ZV.
6566
029529ac
CY
65672011-06-26 Chong Yidong <cyd@stupidchicken.com>
6568
6569 * process.c (wait_reading_process_output): Bypass select if
6570 waiting for a cell while ignoring keyboard input, and input is
6571 pending. Suggested by Jan Djärv (Bug#8869).
6572
7a7ef429
PE
65732011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6574
6575 Use gnulib's dup2 module instead of rolling our own.
6576 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6577
11fdef7d 65782011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6579
6580 * dispnew.c (scrolling_window): Before scrolling, turn off a
6581 mouse-highlight in the window being scrolled.
6582
cd3520a4
JB
65832011-06-24 Juanma Barranquero <lekktu@gmail.com>
6584
6585 Move DEFSYM to lisp.h and use everywhere.
6586
6587 * character.h (DEFSYM): Move declaration...
6588 * lisp.h (DEFSYM): ...here.
6589
6590 * gnutls.c:
6591 * minibuf.c:
6592 * w32menu.c:
6593 * w32proc.c:
6594 * w32select.c: Don't include character.h.
6595
6596 * alloc.c (syms_of_alloc):
6597 * buffer.c (syms_of_buffer):
6598 * bytecode.c (syms_of_bytecode):
6599 * callint.c (syms_of_callint):
6600 * casefiddle.c (syms_of_casefiddle):
6601 * casetab.c (init_casetab_once):
6602 * category.c (init_category_once, syms_of_category):
6603 * ccl.c (syms_of_ccl):
6604 * cmds.c (syms_of_cmds):
6605 * composite.c (syms_of_composite):
6606 * dbusbind.c (syms_of_dbusbind):
6607 * dired.c (syms_of_dired):
6608 * dispnew.c (syms_of_display):
6609 * doc.c (syms_of_doc):
6610 * editfns.c (syms_of_editfns):
6611 * emacs.c (syms_of_emacs):
6612 * eval.c (syms_of_eval):
6613 * fileio.c (syms_of_fileio):
6614 * fns.c (syms_of_fns):
6615 * frame.c (syms_of_frame):
6616 * fringe.c (syms_of_fringe):
6617 * insdel.c (syms_of_insdel):
6618 * keymap.c (syms_of_keymap):
6619 * lread.c (init_obarray, syms_of_lread):
6620 * macros.c (syms_of_macros):
6621 * msdos.c (syms_of_msdos):
6622 * print.c (syms_of_print):
6623 * process.c (syms_of_process):
6624 * search.c (syms_of_search):
6625 * sound.c (syms_of_sound):
6626 * syntax.c (init_syntax_once, syms_of_syntax):
6627 * terminal.c (syms_of_terminal):
6628 * textprop.c (syms_of_textprop):
6629 * undo.c (syms_of_undo):
6630 * w32.c (globals_of_w32):
6631 * window.c (syms_of_window):
6632 * xdisp.c (syms_of_xdisp):
6633 * xfaces.c (syms_of_xfaces):
6634 * xfns.c (syms_of_xfns):
6635 * xmenu.c (syms_of_xmenu):
6636 * xsettings.c (syms_of_xsettings):
6637 * xterm.c (syms_of_xterm): Use DEFSYM.
6638
4228cf16
TZ
66392011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6640
cd3520a4 6641 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6642
7fcccf1e
PE
66432011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6644
7efb4e0e
PE
6645 Integer and buffer overflow fixes (Bug#8873).
6646
ff5844ad
PE
6647 * print.c (printchar, strout): Check for string overflow.
6648 (PRINTPREPARE, printchar, strout):
6649 Don't set size unless allocation succeeds.
6650
90532f02
PE
6651 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6652 for sizes. Check for string overflow more accurately.
6653 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6654
6d84508d
PE
6655 * macros.c: Integer and buffer overflow fixes.
6656 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6657 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6658 Use ptrdiff_t, not int, for sizes.
6659 Don't increment bufsize until after realloc succeeds.
6660 Check for size-calculation overflow.
6661 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6662
437b2cb4
PE
6663 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6664
8b9ac8b4
PE
6665 * lread.c: Integer overflow fixes.
6666 (read_integer): Radix is now EMACS_INT, not int,
6667 to improve quality of diagnostics for out-of-range radices.
6668 Calculate buffer size correctly for out-of-range radices.
6669 (read1): Check for integer overflow in radices, and in
6670 read-circle numbers.
82cb60d3
PE
6671 (read_escape): Avoid int overflow.
6672 (Fload, openp, read_buffer_size, read1)
6673 (substitute_object_recurse, read_vector, read_list, map_obarray):
6674 Use ptrdiff_t, not int, for sizes.
6675 (read1): Use EMACS_INT, not int, for sizes.
20270765 6676 Check for size overflow.
8b9ac8b4 6677
7fcccf1e
PE
6678 * image.c (cache_image): Check for size arithmetic overflow.
6679
bfbbd7e7
PE
6680 * lread.c: Integer overflow issues.
6681 (saved_doc_string_size, saved_doc_string_length)
6682 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6683 Now ptrdiff_t, not int.
6684 (read1): Don't assume doc string length fits in int. Check for
6685 out-of-range doc string lengths.
6686 (read_list): Don't assume file position fits in int.
39019e54 6687 (read_escape): Check for hex character overflow.
bfbbd7e7 6688
4e323265
LL
66892011-06-22 Leo Liu <sdl.web@gmail.com>
6690
6691 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6692 Move to minibuffer.el.
6693
85fece3e
PE
66942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6695
20b84ce9 6696 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6697 The following patches are for when GLYPH_DEBUG && !XASSERT.
6698 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6699 * dispnew.c (flush_stdout):
6700 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6701 Mark as externally visible.
6702 * dispnew.c (check_window_matrix_pointers): Now static.
6703 * dispnew.c (window_to_frame_vpos):
6704 * xfns.c (unwind_create_frame):
6705 * xterm.c (x_check_font): Remove unused local.
6706 * scroll.c (CHECK_BOUNDS):
6707 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6708 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6709 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6710 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6711 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6712 Now static.
6713 (debug_method_add): Use va_list and vsprintf rather than relying
6714 on undefined behavior with wrong number of arguments.
6715 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6716 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6717 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6718 since we're not interested in debugging glyphs with old libraries.
6719 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6720 GCC 4.6.0's static checking.
6721
0766b489
PE
67222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6723
31fd4b32
PE
6724 Integer overflow and signedness fixes (Bug#8873).
6725 A few related buffer overrun fixes, too.
6726
b79e8648
PE
6727 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6728
0766b489
PE
6729 * dispextern.h (struct face.stipple):
6730 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6731 (x_bitmap_mask, x_allocate_bitmap_record)
6732 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6733 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6734 (x_create_bitmap_from_xpm_data):
6735 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6736 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6737 (.bitmaps_last):
6738 * xfaces.c (load_pixmap):
6739 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6740 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6741 (.bitmaps_last, struct x_output.icon_bitmap):
6742 Use ptrdiff_t, not int, for bitmap indexes.
6743 (x_allocate_bitmap_record): Check for size overflow.
6744 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6745
b081724f
PE
6746 Use ptrdiff_t, not int, for overlay counts.
6747 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6748 * editfns.c (overlays_around, get_pos_property):
6749 * textprop.c (get_char_property_and_overlay):
6750 * xdisp.c (next_overlay_change, note_mouse_highlight):
6751 * xfaces.c (face_at_buffer_position):
21514da7
PE
6752 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6753 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6754 (Fnext_overlay_change, Fprevious_overlay_change)
6755 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6756 Use ptrdiff_t, not int, for sizes.
21514da7 6757 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6758
3de73e5e
PE
6759 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6760
2606c57b
PE
6761 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6762 (x_session_initialize): Do not assume string length fits in int.
6763
aaafe47a
PE
6764 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6765 This is unlikely, but can occur if DPI is outlandish.
6766
2674ddc8 6767 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6768 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6769
28154962
PE
6770 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6771 * xrdb.c (magic_file_p, search_magic_path):
6772 Omit last arg SUFFIX; it was always 0. All callers changed.
6773 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6774
7de51af5
PE
6775 * xfont.c (xfont_match): Avoid need for strlen.
6776
25ed6cc3
PE
6777 * xfns.c: Don't assume strlen fits in int.
6778 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6779
4eab31dd
PE
6780 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6781 not unsigned long, as we prefer signed integers. All callers changed.
6782 Detect integer overflow in repeat count.
6783 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6784 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6785
171e2a58
PE
6786 * termcap.c: Don't assume sizes fit in int and never overflow.
6787 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6788 (gobble_line): Check for size-calculation overflow.
6789
ad39faca 6790 * minibuf.c (Fread_buffer):
6e5bb2dc 6791 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6792 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6793 Don't assume string length fits in int.
6794
52c61c22 6795 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6796 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6797
b5b8c9e5
PE
6798 * font.c: Don't assume string length fits in int.
6799 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6800 Use ptrdiff_t, not int.
ccd6111c
PE
6801 (font_intern_prop): Don't assume string length fits in int.
6802 Don't assume integer property fits in fixnum.
6803 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6804
882f0d81 6805 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6806 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6807 Reformulate so as not to need the command string.
6808 Invoke gzip -cd rather than gunzip, as it's more portable.
6809 (lock_info_type, lock_file_1, lock_file):
6810 Don't assume pid_t and time_t fit in unsigned long.
6811 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6812 (current_lock_owner): Prefer signed type for sizes.
6813 Use memcpy, not strncpy, where memcpy is what is really wanted.
6814 Don't assume (via atoi) that time_t and pid_t fit in int.
6815 Check for time_t and/or pid_t out of range, e.g., via a network share.
6816 Don't alloca where an auto var works fine.
6817
93f4cf88
PE
6818 * fileio.c: Fix some integer overflow issues.
6819 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6820 Don't assume string length fits in int.
6821 (directory_file_name): Don't assume string length fits in long.
6822 (make_temp_name): Don't assume pid fits in int, or that its print
6823 length is less than 20.
6824
f3e92b69
PE
6825 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6826
1bfdaf10
PE
6827 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6828
35016e9a
PE
6829 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6830
3d1e65a1
PE
6831 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6832 We prefer signed integers, even for size calculations.
6833
0b963a93
PE
6834 * emacs.c: Don't assume string length fits in 'int'.
6835 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6836 (main): Don't invoke strlen when not needed.
6837
573f4b54
PE
6838 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6839 (XD_DEBUG_MESSAGE): Don't waste a byte.
6840
989f33ba
PE
6841 * callproc.c (getenv_internal_1, getenv_internal)
6842 (Fgetenv_internal):
965d34eb
PE
6843 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6844
e4d29b33
PE
6845 * lread.c (invalid_syntax): Omit length argument.
6846 All uses changed. This doesn't fix a bug, but it simplifies the
6847 code away from its former Hollerith-constant appearance, and it's
6848 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6849 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6850
eb49b136
PE
6851 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6852 This didn't break anything, but it didn't help either.
6853 It's confusing to put a bogus integer in a place where the actual
6854 value does not matter.
9f62aeb1 6855 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6856 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6857
15375a22
PE
6858 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6859 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6860 implementation.
b61cc01c
PE
6861 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6862 We prefer signed types, and the value cannot exceed the EMACS_INT
6863 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6864 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6865 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6866 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6867
53b2623d
PE
6868 * indent.c (sane_tab_width): New function.
6869 (current_column, scan_for_column, Findent_to, position_indentation)
6870 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6871 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6872
51cab52b 6873 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6874
f2ed8a70
PE
6875 * lisp.h (lint_assume): New macro.
6876 * composite.c (composition_gstring_put_cache):
6877 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6878
abe80cc6
PE
6879 * editfns.c, insdel.c:
6880 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6881
b02c740e
PE
6882 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6883
ebc96716
PE
6884 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6885
b4e50fa0 6886 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6887 Use much-faster test for byte-length change.
311d5d7c 6888 Don't assume string byte-length fits in 'int'.
a4cf38e4 6889 Check that character arg fits in 'int'.
85461888 6890 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6891
c0c1ee9f
PE
6892 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6893
a498d7f4
PE
6894 * fns.c (concat): Catch string overflow earlier.
6895 Do not rely on integer wraparound.
6896
51cab52b
PE
6897 * dispextern.h (struct it.overlay_strings_charpos)
6898 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6899 * xdisp.c (forward_to_next_line_start)
6900 (back_to_previous_visible_line_start)
6901 (reseat_at_next_visible_line_start, next_element_from_buffer):
6902 Don't arbitrarily truncate the value of 'selective' to int.
6903
76031fad
PE
6904 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6905
5eb55db9
PE
6906 * composite.c: Don't truncate sizes to 'int'.
6907 (composition_gstring_p, composition_reseat_it)
6908 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6909 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6910 not EMACS_UINT, for indexes.
5eb55db9 6911
0703a717
PE
6912 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6913
d6202519
PE
6914 * buffer.c: Include <verify.h>.
6915 (struct sortvec.priority, struct sortstr.priority):
8961a454 6916 Now EMACS_INT, not int.
c20998a7 6917 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6918 (struct sortstr.size, record_overlay_string)
6919 (struct sortstrlist.size, struct sortlist.used):
6920 Don't truncate size to int.
6921 (record_overlay_string): Check for size-calculation overflow.
d6202519 6922 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6923
d5a19415
JM
69242011-06-22 Jim Meyering <meyering@redhat.com>
6925
029529ac 6926 Don't leak an XBM-image-sized buffer
d5a19415
JM
6927 * image.c (xbm_load): Free the image buffer after using it.
6928
a9041e6c
PE
69292011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6930
6931 Port to Sun C.
6932 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6933 that Sun C diagnosed.
6934 * fns.c (secure_hash): Fix pointer signedness issue.
6935 * intervals.c (static_offset_intervals): New function.
6936 (offset_intervals): Use it.
6937
7f3f739f
LL
69382011-06-21 Leo Liu <sdl.web@gmail.com>
6939
6940 * deps.mk (fns.o):
6941 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6942 sha512.h.
6943
6944 * fns.c (secure_hash): Rename from crypto_hash_function and change
6945 the first arg to accept symbols.
5b66d427 6946 (Fsecure_hash): New primitive.
7f3f739f
LL
6947 (syms_of_fns): New symbols.
6948
76147d94
DD
69492011-06-20 Deniz Dogan <deniz@dogan.se>
6950
6951 * process.c (Fset_process_buffer): Clarify return value in
6952 docstring.
6953
7d7d0045
CY
69542011-06-18 Chong Yidong <cyd@stupidchicken.com>
6955
6956 * dispnew.c (add_window_display_history): Use BVAR.
6957
6958 * xdisp.c (debug_method_add): Use BVAR.
6959 (check_window_end, dump_glyph_matrix, dump_glyph)
6960 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6961
6962 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6963 Likewise.
6964
6965 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6966 check till after the cache is created in init_frame_faces.
6967
ff2bc410
SM
69682011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6969
6970 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6971
28177add
PE
69722011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6973
dd3482fe
PE
6974 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6975 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6976 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6977
393d71f3 6978 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6979 * fileio.c (Finsert_file_contents):
6980 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6981 Remove the old (too-loose) buffer overflow checks.
6982 They weren't needed, since make_gap checks for buffer overflow.
6983 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6984 The old code merely checked for Emacs fixnum overflow, and relied
6985 on undefined (wraparound) behavior. The new code avoids undefined
6986 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6987
2e6813b0 6988 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6989 Tune. Don't use wider integers than needed. Don't use alloca.
6990 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6991
599a9e4f
PE
6992 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6993
99561444
PE
6994 * insdel.c, lisp.h (buffer_overflow): New function.
6995 (insert_from_buffer_1, replace_range, replace_range_2):
6996 * insdel.c (make_gap_larger):
6997 * editfns.c (Finsert_char):
6998 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6999
28177add
PE
7000 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7001
e69dafad
PE
70022011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7003
4baa020d 7004 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7005
b1c46f02
PE
7006 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7007 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7008
e69dafad
PE
7009 * fileio.c: Don't assume EMACS_INT fits in off_t.
7010 (emacs_lseek): New static function.
7011 (Finsert_file_contents, Fwrite_region): Use it.
7012 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7013
566684ea
PE
7014 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7015
e6966cd6
PE
7016 * fns.c: Don't overflow int when computing a list length.
7017 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7018 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7019 truncation on 64-bit hosts. Check for QUIT every
7020 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7021 faster and is responsive enough.
7022 (Flength): Report an error instead of overflowing an integer.
7023 (Fsafe_length): Return a float if the value is not representable
7024 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7025 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7026 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7027
dd0b0efb
PE
7028 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7029 (header_size, word_size): New constants.
7030 (allocate_vectorlike): Don't check size overflow here.
7031 (allocate_vector): Check it here instead, since this is the only
7032 caller of allocate_vectorlike that could cause overflow.
7033 Check that the new vector's length is representable as a fixnum.
7034
86fe5cfe
PE
7035 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7036 The previous code was bogus. For example, next_almost_prime (32)
7037 returned 39, which is undesirable as it is a multiple of 3; and
7038 next_almost_prime (24) returned 25, which is a multiple of 5 so
7039 why was the code bothering to check for multiples of 7?
7040
80e88859
PE
7041 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7042
4a2f0ad6
PE
7043 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7044
f66c7cf8
PE
7045 Variadic C functions now count arguments with ptrdiff_t.
7046 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7047 Back then I didn't know that the Emacs coding style prefers signed int.
7048 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7049 were being counted with int, which may truncate counts on 64-bit
7050 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7051 * lisp.h (struct Lisp_Subr.function.aMANY)
7052 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7053 Arg counts are now ptrdiff_t, not size_t.
7054 All variadic functions and their callers changed accordingly.
7055 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7056 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7057 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7058 * callint.c (Fcall_interactively): Check arg count for overflow,
7059 to avoid potential buffer overrun. Use signed char, not 'int',
7060 for 'varies' array, so that we needn't bother to check its size
7061 calculation for overflow.
7062 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7063 * eval.c (apply_lambda):
7064 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7065 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7066 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7067
a1759b76
PE
7068 * callint.c (Fcall_interactively): Don't use index var as event count.
7069
d96be9fc
PE
7070 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7071 * mem-limits.h (SIZE): Remove; no longer used.
7072
a690a978 7073 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7074
578c21e6
PE
7075 Remove unnecessary casts.
7076 * xterm.c (x_term_init):
7077 * xfns.c (x_set_border_pixel):
7078 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7079 These aren't needed now that we assume ANSI C.
7080
96f53c6c
PE
7081 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7082 It's more likely to cause problems (due to unsigned overflow)
7083 than to cure them.
7084
83c77d31
PE
7085 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7086
ee2079f1
PE
7087 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7088
6da65536
PE
7089 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7090
7147c4a4
PE
7091 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7092
193e32d9
PE
7093 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7094
e5533da6
PE
7095 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7096
9910e595
PE
7097 GLYPH_CODE_FACE returns EMACS_INT, not int.
7098 * dispextern.h (merge_faces):
7099 * xfaces.c (merge_faces):
01103c44
PE
7100 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7101 Don't assume EMACS_INT fits in int.
9910e595 7102
2638320e
PE
7103 * character.h (CHAR_VALID_P): Remove unused parameter.
7104 * fontset.c, lisp.h, xdisp.c: All uses changed.
7105
045eb8d9
PE
7106 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7107
c1f134b5
PE
7108 * fns.c (concat): Minor tuning based on overflow analysis.
7109 This doesn't fix any bugs. Use int to hold character, instead
7110 of constantly refetching from Emacs object. Use XFASTINT, not
7111 XINT, for value known to be a character. Don't bother comparing
7112 a single byte to 0400, as it's always less.
7113
395fcb93 7114 * floatfns.c (Fexpt):
327eeec8
PE
7115 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7116
abbd3d23
PE
7117 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7118 for characters.
7119
684a03ef
PE
7120 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7121
0fed43f3
PE
7122 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7123 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7124 incorrectly succeed when S was a string, because 4294967386 was
7125 truncated before it was used.
7126
8fd02eb7
PE
7127 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7128 Otherwise, an out-of-range integer could cause undefined behavior
7129 on a 64-bit host.
7130
f8c86b69
PE
7131 * composite.c: Use int, not EMACS_INT, for characters.
7132 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7133 EMACS_INT, for values that are known to be in character range.
7134 This doesn't fix any bugs but is the usual style inside Emacs and
7135 may generate better code on 32-bit machines.
7136
34206dd2
PE
7137 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7138 This is for reasons similar to the recent CHAR_STRING fix.
7139 * charset.c (Fencode_char): Check that character arg is actually
7140 a character. Pass an int to ENCODE_CHAR.
7141 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7142 wider than 'int', as a compile-time check to prevent future regressions
7143 in this area.
7144
c5958d4c 7145 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7146
7147 Make sure a 64-bit char is never passed to CHAR_STRING.
7148 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7149 by silently ignoring the top 32 bits, allowing some values
7150 that were far too large to be valid characters.
7151 * character.h: Include <verify.h>.
7152 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7153 arguments are no wider than unsigned, as a compile-time check
7154 to prevent future regressions in this area.
7155 * data.c (Faset):
01103c44 7156 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7157 (Fsubst_char_in_region):
7158 * fns.c (concat):
7159 * xdisp.c (decode_mode_spec_coding):
7160 Adjust to CHAR_STRING's new requirement.
7161 * editfns.c (Finsert_char, Fsubst_char_in_region):
7162 * fns.c (concat): Check that character args are actually
7163 characters. Without this test, these functions did the wrong
7164 thing with wildly out-of-range values on 64-bit hosts.
7165
d37ca623
PE
7166 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7167 These casts should not be needed on 32-bit hosts, either.
7168 * keyboard.c (read_char):
7169 * lread.c (Fload): Remove casts to unsigned.
7170
ea204efb
PE
7171 * lisp.h (UNSIGNED_CMP): New macro.
7172 This fixes comparison bugs on 64-bit hosts.
7173 (ASCII_CHAR_P): Use it.
7174 * casefiddle.c (casify_object):
01103c44 7175 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7176 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7177 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7178 * dispextern.h (FACE_FROM_ID):
7179 * keyboard.c (read_char): Use UNSIGNED_CMP.
7180
41cb286c
PE
7181 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7182 not to EMACS_INT, to avoid GCC warning.
7183
4a1b9832
PE
7184 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7185
55daad71
PE
7186 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7187 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7188 isn't needed on 32-bit machines.
8f95c75c 7189
01103c44
PE
7190 * buffer.c (Fgenerate_new_buffer_name):
7191 Use EMACS_INT for count, not int.
0ceccced 7192 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7193
7194 * data.c (Qcompiled_function): Now static.
7195
c6f072e7
PE
7196 * window.c (window_body_lines): Now static.
7197
20ce5912
PE
7198 * image.c (gif_load): Rename local to avoid shadowing.
7199
9c4c5f81
PE
7200 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7201 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7202 * alloc.c (make_save_value): Integer argument is now of type
7203 ptrdiff_t, not int.
7204 (mark_object): Use ptrdiff_t, not int.
7205 * lisp.h (pD): New macro.
7206 * print.c (print_object): Use it.
7207
c0c5c8ae
PE
7208 * alloc.c: Use EMACS_INT, not int, to count objects.
7209 (total_conses, total_markers, total_symbols, total_vector_size)
7210 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7211 (total_free_floats, total_floats, total_free_intervals)
7212 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7213 Now EMACS_INT, not int. All uses changed.
7214 (Fgarbage_collect): Compute overall total using a double, so that
7215 integer overflow is less likely to be a problem. Check for overflow
7216 when converting back to an integer.
5a25e253
PE
7217 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7218 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7219 These were 'int' variables that could overflow on 64-bit hosts;
7220 they were never used, so remove them instead of repairing them.
211a0b2a 7221 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7222 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7223 Previously, this ceilinged at INT_MAX, but that doesn't work on
7224 64-bit machines.
e46bb31a 7225 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7226
c78baabf 7227 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7228 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7229 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7230 when a (possibly-narrower) signed value would do just as well.
7231 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7232
c9d624c6
PE
7233 * alloc.c: Catch some string size overflows that we were missing.
7234 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7235 for convenience in STRING_BYTES_MAX.
7236 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7237 The definition here is exact; the one in lisp.h was approximate.
7238 (allocate_string_data): Check for string overflow. This catches
7239 some instances we weren't catching before. Also, it catches
7240 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7241 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7242 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7243
c9d624c6
PE
7244 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7245 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7246 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7247
353032ce
PE
7248 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7249
2bccce07
PE
7250 * alloc.c (Fmake_string): Check for out-of-range init.
7251
0ac30604
SM
72522011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7253
7254 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7255
c195f2de
JD
72562011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7257
7258 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7259 xg_get_default_scrollbar_width.
7260
7261 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7262 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7263 (style_changed_cb): Call update_theme_scrollbar_width and call
7264 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7265 all frames (Bug#8505).
7266 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7267 Call gtk_window_set_resizable if HAVE_GTK3.
7268 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7269 and height if HAVE_GTK3 (Bug#8505).
7270 (scroll_bar_width_for_theme): New variable.
7271 (update_theme_scrollbar_width): New function.
7272 (xg_get_default_scrollbar_width): Move code to
7273 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7274 (xg_initialize): Call update_theme_scrollbar_width.
7275
7276 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7277
7278 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7279
e10ac9f1
MR
72802011-06-12 Martin Rudalics <rudalics@gmx.at>
7281
7282 * frame.c (make_frame): Call other_buffer_safely instead of
7283 other_buffer.
7284
7285 * window.c (temp_output_buffer_show): Call display_buffer with
7286 second argument Vtemp_buffer_show_specifiers and reset latter
7287 immediately after the call.
7288 (Vtemp_buffer_show_specifiers): New variable.
7289 (auto_window_vscroll_p, next_screen_context_lines)
7290 (Vscroll_preserve_screen_position): Remove leading asterisks from
7291 doc-strings.
7292
2d3c217e 72932011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7294
7b7f97e8 7295 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7296 * buffer.c (Qclone_number): Remove for now, as it's unused.
7297 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7298 (record_buffer): Remove unused local.
7299 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7300 (set_frame_buffer_list): Remove; unused.
7301 * frame.h (other_visible_frames): Remove decl.
7302 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7303 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7304 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7305 if HAVE_GPM.
7306 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7307 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7308 Define only if HAVE_GPM.
7309 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7310 (update_hints_inhibit): Remove; never set. All uses removed.
7311 * widgetprv.h (emacsFrameClassRec): Remove decl.
7312 * window.c (delete_deletable_window): Now returns void, since it
7313 wasn't returning anything.
7314 (compare_window_configurations): Remove unused locals.
7315 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7316 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7317 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7318 the same widths as pointers. This follows up on the 2011-05-06 patch.
7319 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7320 * xterm.h: Likewise.
7321 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7322
1384b89e
JB
73232011-06-12 Juanma Barranquero <lekktu@gmail.com>
7324
7325 * makefile.w32-in: Update dependencies.
7326 (LISP_H): Add lib/intprops.h.
7327
1100a63c
CY
73282011-06-11 Chong Yidong <cyd@stupidchicken.com>
7329
7330 * image.c (gif_load): Add animation frame delay to the metadata.
7331 (syms_of_image): Use DEFSYM. New symbol `delay'.
7332
6198ccd0
MR
73332011-06-11 Martin Rudalics <rudalics@gmx.at>
7334
7335 * window.c (delete_deletable_window): Re-add.
7336 (Fset_window_configuration): Rewrite to handle dead buffers and
7337 consequently deletable windows.
7338 (window_tree, Fwindow_tree): Remove. Supply functionality in
7339 window.el.
7340 (compare_window_configurations): Simplify code.
7341
b6e3633c
AS
73422011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7343
1ab0dee5
AS
7344 * image.c (imagemagick_load_image): Fix type mismatch.
7345 (Fimagemagick_types): Likewise.
7346
b6e3633c
AS
7347 * window.h (replace_buffer_in_windows): Declare.
7348
9397e56f
MR
73492011-06-11 Martin Rudalics <rudalics@gmx.at>
7350
7351 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7352 Qclone_number. Remove external declaration of Qdelete_window.
7353 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7354 code.
640c8776
SM
7355 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7356 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7357 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7358 buffer list implementation.
7359 (other_buffer_safely): New function.
7360 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7361 calls to replace_buffer_in_windows and
7362 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7363 if allowed.
7364 (record_buffer): Inhibit quitting and rewrite using quittable
7365 functions. Run Qbuffer_list_update_hook if allowed.
7366 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7367 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7368 Move switch-to-buffer to window.el.
9397e56f
MR
7369 (bury-buffer): Move to window.el.
7370 (Vbuffer_list_update_hook): New variable.
7371
7372 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7373 section.
7374
7375 * window.h (resize_frame_windows): Move up in code.
7376 (Fwindow_frame): Remove EXFUN.
7377 (replace_buffer_in_all_windows): Remove prototype.
7378 (replace_buffer_in_windows_safely): Add prototype.
7379
7380 * window.c: Declare Qdelete_window static again. Move down
7381 declaration of select_count.
7382 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7383 (Fother_window): Move to window.el.
7384 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7385 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7386 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7387 window.el.
7388 (replace_buffer_in_windows): Implement by calling
7389 Qreplace_buffer_in_windows.
7390 (replace_buffer_in_all_windows): Remove with some functionality
7391 moved into replace_buffer_in_windows_safely.
7392 (replace_buffer_in_windows_safely): New function.
7393 (select_window_norecord, select_frame_norecord): Move in front
7394 of run_window_configuration_change_hook. Remove now obsolete
7395 declarations.
640c8776
SM
7396 (Fset_window_buffer): Rewrite doc-string.
7397 Call Qrecord_window_buffer.
9397e56f
MR
7398 (keys_of_window): Move binding for other-window to window.el.
7399
b50691aa
CY
74002011-06-11 Chong Yidong <cyd@stupidchicken.com>
7401
7402 * dispextern.h (struct image): Replace data member, whose int_val
7403 and ptr_val fields were not used by anything, with a single
7404 lisp_val object.
7405
7406 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7407 (gif_clear_image, gif_load, imagemagick_load_image)
7408 (gs_clear_image, gs_load): Callers changed.
7409
3f754b86
PE
74102011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7411
cca69397
PE
7412 * buffer.h: Include <time.h>, for time_t.
7413 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7414
109e28d0
PE
7415 Fix minor problems found by static checking.
7416
60737f02
PE
7417 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7418
4b66faf3
PE
7419 Make identifiers static if they are not used in other modules.
7420 * data.c (Qcompiled_function, Qframe, Qvector):
7421 * image.c (QimageMagick, Qsvg):
7422 * minibuf.c (Qmetadata):
7423 * window.c (resize_window_check, resize_root_window): Now static.
7424 * window.h (resize_window_check, resize_root_window): Remove decls.
7425
109e28d0
PE
7426 * window.c (window_deletion_count, delete_deletable_window):
7427 Remove; unused.
46a4ce9e
PE
7428 (window_body_lines): Now static.
7429 (Fdelete_other_windows_internal): Mark vars as initialized.
7430 Make sure 'resize_failed' is initialized.
7431 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7432 (resize_window_apply): Remove unused local.
7433 * window.h (delete_deletable_window): Remove decl.
7434
109e28d0 7435 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7436 (imagemagick_load_image): Fix pointer signedness problem by changing
7437 last arg from unsigned char * to char *. All uses changed.
7438 Also, fix a local for similar reasons.
7439 Remove unused locals. Remove locals to avoid shadowing.
7440 (fn_rsvg_handle_free): Remove; unused.
7441 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7442 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7443
3f754b86
PE
7444 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7445
2547adb1
CY
74462011-06-10 Chong Yidong <cyd@stupidchicken.com>
7447
7448 * image.c (gif_load): Fix omitted cast error introduced by
7449 2011-06-06 change.
7450
2c8e37d4
MR
74512011-06-10 Martin Rudalics <rudalics@gmx.at>
7452
7453 * window.h (resize_proportionally, orig_total_lines)
7454 (orig_top_line): Remove from window structure.
7455 (set_window_height, set_window_width, change_window_heights)
7456 (Fdelete_window): Remove prototypes.
7457 (resize_frame_windows): Remove duplicate declaration.
7458
440a42e3
EZ
74592011-06-10 Eli Zaretskii <eliz@gnu.org>
7460
7461 * window.h (resize_frame_windows, resize_window_check)
7462 (delete_deletable_window, resize_root_window)
7463 (resize_frame_windows): Declare prototypes.
7464
7465 * window.c (resize_window_apply): Make definition be "static" to
7466 match the prototype.
7467
562dd5e9
MR
74682011-06-10 Martin Rudalics <rudalics@gmx.at>
7469
7470 * window.c: Remove declarations of Qwindow_size_fixed,
7471 window_min_size_1, window_min_size_2, window_min_size,
7472 size_window, window_fixed_size_p, enlarge_window, delete_window.
7473 Remove static from declaration of Qdelete_window, it's
7474 temporarily needed by Fbury_buffer.
7475 (replace_window): Don't assign orig_top_line and
7476 orig_total_lines.
7477 (Fdelete_window, delete_window): Remove. Window deletion is
7478 handled by window.el.
640c8776
SM
7479 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7480 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7481 (Fdelete_other_windows): Remove. Deleting other windows is
7482 handled by window.el.
7483 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7484 handled in window.el.
7485 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7486 Window minimum sizes are handled in window.el.
7487 (shrink_windows, size_window, set_window_height)
7488 (set_window_width, change_window_heights, window_height)
7489 (window_width, CURBEG, CURSIZE, enlarge_window)
7490 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7491 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7492 handled in window.el.
7493 (make_dummy_parent): Rename to make_parent_window and give it a
7494 second argument horflag.
7495 (make_window): Don't set resize_proportionally any more.
7496 (Fsplit_window): Remove. Windows are split in window.el.
7497 (save_restore_action, save_restore_orig_size)
7498 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7499 Resize mini windows in window.el.
7500 (grow_mini_window, shrink_mini_window): Implement by calling
7501 Qresize_root_window_vertically, resize_window_check and
7502 resize_window_apply.
640c8776
SM
7503 (saved_window, Fset_window_configuration, save_window_save):
7504 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7505 resize_proportionally.
7506 (window_min_height, window_min_width): Move to window.el.
7507 (keys_of_window): Move bindings for delete-other-windows,
7508 split-window, delete-window and enlarge-window to window.el.
7509
7510 * buffer.c: Temporarily extern Qdelete_window.
7511 (Fbury_buffer): Temporarily call Qdelete_window instead of
7512 Fdelete_window (Fbury_buffer will move to window.el soon).
7513
7514 * frame.c (set_menu_bar_lines_1): Remove code handling
7515 orig_top_line and orig_total_lines.
7516
7517 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7518 set_window_height but set heights directly.
7519 (change_frame_size_1): Use resize_frame_windows.
7520
7521 * xdisp.c (init_xdisp): Don't use set_window_height but set
7522 heights directly.
7523
640c8776
SM
7524 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7525 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7526 run_window_configuration_change_hook.
7527
7528 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7529 instead of change_window_heights and run
7530 run_window_configuration_change_hook.
7531
1a13852e
MR
75322011-06-09 Martin Rudalics <rudalics@gmx.at>
7533
7534 * window.c (replace_window): Rename second argument REPLACEMENT to
7535 NEW. New third argument SETFLAG. Rewrite.
7536 (delete_window, make_dummy_parent): Call replace_window with
7537 third argument 1.
7538 (window_list_1): Move down in code.
7539 (run_window_configuration_change_hook): Move set_buffer part
7540 before select_frame_norecord part in order to unwind correctly.
7541 Rename count1 to count.
7542 (recombine_windows, delete_deletable_window, resize_root_window)
7543 (Fdelete_other_windows_internal)
7544 (Frun_window_configuration_change_hook, make_parent_window)
7545 (resize_window_check, resize_window_apply, Fresize_window_apply)
7546 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7547 (Fdelete_window_internal, Fresize_mini_window_internal):
7548 New functions.
1a13852e
MR
7549 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7550
f3d1777e
MR
75512011-06-08 Martin Rudalics <rudalics@gmx.at>
7552
496e208e
MR
7553 * window.h (window): Add some new members to window structure -
7554 normal_lines, normal_cols, new_total, new_normal, clone_number,
7555 splits, nest, prev_buffers, next_buffers.
7556 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7557 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7558
f3d1777e
MR
7559 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7560 Remove.
496e208e
MR
7561 (make_dummy_parent): Set new members of windows structure.
7562 (make_window): Move down in code. Handle new members of window
7563 structure.
7564 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7565 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7566 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7567 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7568 (Fset_window_next_buffers, Fset_window_clone_number):
7569 New functions.
496e208e
MR
7570 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7571 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7572 Doc-string fixes.
7573 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7574 Argument WINDOW can be now internal window too.
7575 (Fwindow_use_time): Move up in code.
7576 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7577 Rewrite doc-string.
7578 (Fset_window_configuration, saved_window)
7579 (Fcurrent_window_configuration, save_window_save): Handle new
7580 members of window structure.
b9e809c2
MR
7581 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7582 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7583 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7584 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7585 Qget_mru_window, Qresize_root_window,
7586 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7587 Qauto_buffer_name; staticpro them.
f3d1777e 7588
abde8f8c
MR
75892011-06-07 Martin Rudalics <rudalics@gmx.at>
7590
7591 * window.c (Fwindow_total_size, Fwindow_left_column)
7592 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7593 (Fwindow_list_1): New functions.
7594 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7595 (Fwindow_width, Fscroll_left, Fscroll_right):
7596 Use window_body_cols instead of window_box_text_cols.
7597 (delete_window, Fset_window_configuration):
7598 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7599 (delete_all_subwindows): Take a window as argument and not a
7600 structure. Rewrite.
190b47e6
MR
7601 (window_loop): Remove handling of GET_LRU_WINDOW and
7602 GET_LARGEST_WINDOW.
7603 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7604
7605 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7606 window_box_text_cols. delete_all_subwindows now takes a
7607 Lisp_Object as argument.
abde8f8c 7608
640c8776
SM
7609 * indent.c (compute_motion, Fcompute_motion):
7610 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7611
fa8a67e6
MR
7612 * frame.c (delete_frame): Call delete_all_subwindows with root
7613 window as argument.
7614
a54e3482
DC
76152011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7616
7617 * fns.c (Fputhash): Document return value.
7618
60002bf5
CY
76192011-06-06 Chong Yidong <cyd@stupidchicken.com>
7620
7621 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7622
0c671da6 76232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7624
b862a52a 7625 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7626
be44ca6c
PE
7627 Check for overflow when converting integer to cons and back.
7628 * charset.c (Fdefine_charset_internal, Fdecode_char):
7629 Use cons_to_unsigned to catch overflow.
7630 (Fencode_char): Use INTEGER_TO_CONS.
7631 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7632 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7633 * data.c (long_to_cons, cons_to_long): Remove.
7634 (cons_to_unsigned, cons_to_signed): New functions.
7635 These signal an error for invalid or out-of-range values.
7636 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7637 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7638 * font.c (Ffont_variation_glyphs):
7639 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7640 * lisp.h: Include <intprops.h>.
7641 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7642 (cons_to_signed, cons_to_unsigned): New decls.
7643 (long_to_cons, cons_to_long): Remove decls.
7644 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7645 (Fprimitive_undo): Use CONS_TO_INTEGER.
7646 * xfns.c (Fx_window_property): Likewise.
7647 * xselect.c: Include <limits.h>.
7648 (x_own_selection, selection_data_to_lisp_data):
7649 Use INTEGER_TO_CONS.
7650 (x_handle_selection_request, x_handle_selection_clear)
7651 (x_get_foreign_selection, Fx_disown_selection_internal)
7652 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7653 (lisp_data_to_selection_data): Use cons_to_unsigned.
7654 (x_fill_property_data): Use cons_to_signed.
7655 Report values out of range.
7656
d1f3d2af
PE
7657 Check for buffer and string overflow more precisely.
7658 * buffer.h (BUF_BYTES_MAX): New macro.
7659 * lisp.h (STRING_BYTES_MAX): New macro.
7660 * alloc.c (Fmake_string):
7661 * character.c (string_escape_byte8):
7662 * coding.c (coding_alloc_by_realloc):
7663 * doprnt.c (doprnt):
7664 * editfns.c (Fformat):
7665 * eval.c (verror):
7666 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7667 since they may not be the same number.
7668 * editfns.c (Finsert_char):
7669 * fileio.c (Finsert_file_contents):
7670 Likewise for BUF_BYTES_MAX.
7671
dd52fcea
PE
7672 * image.c: Use ptrdiff_t, not int, for sizes.
7673 (slurp_file): Switch from int to ptrdiff_t.
7674 All uses changed.
7675 (slurp_file): Check that file size fits in both size_t (for
7676 malloc) and ptrdiff_t (for sanity and safety).
7677
7f9bbdbb
PE
7678 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7679 if b->modtime has its maximal value.
7680
dfe18f82
PE
7681 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7682
84acfcf0
PE
7683 Don't assume time_t can fit into int.
7684 * buffer.h (struct buffer.modtime): Now time_t, not int.
7685 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7686 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7687
ccd9a01a
PE
7688 Minor fixes for signed vs unsigned integers.
7689 * character.h (MAYBE_UNIFY_CHAR):
7690 * charset.c (maybe_unify_char):
7691 * keyboard.c (read_char, reorder_modifiers):
7692 XINT -> XFASTINT, since the integer must be nonnegative.
7693 * ftfont.c (ftfont_spec_pattern):
7694 * keymap.c (access_keymap, silly_event_symbol_error):
7695 XUINT -> XFASTINT, since the integer must be nonnegative.
7696 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7697 since it makes no difference and we prefer signed.
7698 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7699 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7700 nonnegative.
7701
d6d100dd
SM
77022011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7703
7704 * window.h (Fwindow_frame): Declare.
7705
2b6148e4
PE
77062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7707
7708 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7709 (SPARE_MEMORY): Always define.
7710 (LARGE_REQUEST): Remove.
7711 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7712
f230ecc9
MR
77132011-06-06 Martin Rudalics <rudalics@gmx.at>
7714
727e958e
MR
7715 * lisp.h: Move EXFUNS for Fframe_root_window,
7716 Fframe_first_window and Fset_frame_selected_window to window.h.
7717
7718 * window.h: Move EXFUNS for Fframe_root_window,
7719 Fframe_first_window and Fset_frame_selected_window here from
7720 lisp.h.
7721
7722 * frame.c (Fwindow_frame, Fframe_first_window)
7723 (Fframe_root_window, Fframe_selected_window)
7724 (Fset_frame_selected_window): Move to window.c.
7725 (Factive_minibuffer_window): Move to minibuf.c.
7726 (Fother_visible_frames_p): New function.
7727
7728 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7729
f230ecc9
MR
7730 * window.c (decode_window, decode_any_window): Move up in code.
7731 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7732 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7733 (Fwindow_buffer): Move up and rewrite doc-string.
7734 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7735 (Fwindow_prev): New functions.
727e958e
MR
7736 (Fwindow_frame): Move here from frame.c. Accept any window as
7737 argument.
7738 (Fframe_root_window, Fframe_first_window)
7739 (Fframe_selected_window): Move here from frame.c. Accept frame
7740 or arbitrary window as argument. Update doc-strings.
7741 (Fminibuffer_window): Move up in code.
7742 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7743 (Fset_frame_selected_window): Move here from frame.c.
7744 Marginal rewrite.
727e958e
MR
7745 (Fselected_window, select_window, Fselect_window): Move up in
7746 code. Minor doc-string fixes.
f230ecc9 7747
4d09bcf6
PE
77482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7749
7750 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7751 Do not assume that spare memory exists; that assumption is valid
7752 only if SYSTEM_MALLOC.
7753 (LARGE_REQUEST): New macro, so that the issue of large requests
7754 is separated from the issue of spare memory.
7755
810928a2
AS
77562011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7757
172418ad
AS
7758 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7759 format. (Bug#8806)
7760
43f862f7
AS
7761 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7762
810928a2
AS
7763 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7764 before statements.
7765
a059fe24
JD
77662011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7767
7768 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7769
7770 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7771
7772 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7773 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7774
989bf368
JB
77752011-06-05 Juanma Barranquero <lekktu@gmail.com>
7776
7777 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7778
4b80f674
CY
77792011-06-04 Chong Yidong <cyd@stupidchicken.com>
7780
7781 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7782 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7783 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7784 New error handlers.
4b80f674
CY
7785 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7786 Obey Vx_select_enable_clipboard_manager. Catch errors in
7787 x_clipboard_manager_save (Bug#8779).
7788 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7789 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7790
99a33b77 77912011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7792
7793 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7794
99a33b77 77952011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7796
7797 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7798 in the current matrix if keep_current_p is non-zero.
7799
8264569d
EZ
78002011-06-04 Eli Zaretskii <eliz@gnu.org>
7801
7802 * bidi.c (bidi_level_of_next_char): Fix last change.
7803
57f97249
EZ
78042011-06-03 Eli Zaretskii <eliz@gnu.org>
7805
fec2107c 7806 Support bidi reordering of text covered by display properties.
57f97249 7807
fec2107c
EZ
7808 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7809 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7810 (bidi_cache_search, bidi_cache_iterator_state)
7811 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7812 (bidi_level_of_next_char, bidi_move_to_visually_next):
7813 Support character positions inside a run of characters covered by a
fec2107c
EZ
7814 display string.
7815 (bidi_paragraph_init, bidi_resolve_explicit_1)
7816 (bidi_level_of_next_char): Call bidi_fetch_char and
7817 bidi_fetch_char_advance instead of FETCH_CHAR and
7818 FETCH_CHAR_ADVANCE.
7819 (bidi_init_it): Initialize new members.
7820 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7821 definitions.
7822 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7823 instead of using explicit *_CHAR codes.
d6d100dd
SM
7824 (bidi_resolve_explicit, bidi_resolve_weak):
7825 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7826 bidirectional text is supported only in multibyte buffers.
7827 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7828 it to initialize the frame_window_p member of struct bidi_it.
7829 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7830 (bidi_resolve_explicit, bidi_resolve_weak)
7831 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7832 bidi_it->nchars is non-positive.
7833 (bidi_level_of_next_char): Don't try to lookup the cache for the
7834 next/previous character if nothing is cached there yet, or if we
7835 were just reseat()'ed to a new position.
c40e2fb2 7836
0e14fe90
EZ
7837 * xdisp.c (set_cursor_from_row): Set start and stop points
7838 according to the row's direction when priming the loop that looks
7839 for the glyph on which to display cursor.
7840 (single_display_spec_intangible_p): Function deleted.
7841 (display_prop_intangible_p): Reimplement to call
7842 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7843 Accept 3 additional arguments needed by handle_display_spec.
7844 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7845 values: lists, `(when COND...)' forms, etc.
7846 (single_display_spec_string_p): Support property values that are
7847 lists with the argument STRING its top-level element.
7848 (display_prop_string_p): Fix the condition for processing a
7849 property that is a list to be consistent with handle_display_spec.
fec2107c 7850 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7851 last portion of handle_display_prop.
7852 (compute_display_string_pos): Accept additional argument
7853 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7854 value of a `display' property is a "replacing spec".
7855 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7856 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7857 the display property, but just return a value indicating whether
7858 the display property will replace the characters it covers.
7859 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7860 frame_window_p members of struct bidi_it.
d6d100dd
SM
7861 (compute_display_string_pos, compute_display_string_end):
7862 New functions.
fec2107c
EZ
7863 (push_it): Accept second argument POSITION, where pop_it should
7864 jump to continue iteration.
7865 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7866
fec2107c
EZ
7867 * keyboard.c (adjust_point_for_property): Adjust the call to
7868 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7869
7870 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7871 (bidi_init_it): Update prototypes.
7872 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7873 (compute_display_string_pos, compute_display_string_end):
7874 Declare prototypes.
fec2107c
EZ
7875 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7876 EMACS_INT.
fc6f18ce 7877
40087514 78782011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7879
57f53182
PE
7880 Malloc failure behavior now depends on size of allocation.
7881 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7882 * lisp.h: Change signatures accordingly.
7883 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7884 All callers changed. (Bug#8762)
7885
7886 * gnutls.c: Use Emacs's memory allocators.
7887 Without this change, the gnutls library would invoke malloc etc.
7888 directly, which causes problems on non-SYNC_INPUT hosts, and which
7889 runs afoul of improving memory_full behavior. (Bug#8761)
7890 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7891 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7892 xfree instead of the default malloc, realloc, free.
7893 (Fgnutls_boot): No need to check for memory allocation failure,
7894 since xmalloc does that for us.
7895
ac32cd99 7896 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7897 * category.c (hash_get_category_set):
7898 * ccl.c (ccl_driver):
7899 * charset.c (Fdefine_charset_internal):
7900 * charset.h (struct charset.hash_index):
7901 * composite.c (get_composition_id, gstring_lookup_cache)
7902 (composition_gstring_put_cache):
7903 * composite.h (struct composition.hash_index):
7904 * dispextern.h (struct image.hash):
7905 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7906 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7907 (hashfn_equal, hashfn_user_defined, make_hash_table)
7908 (maybe_resize_hash_table, hash_lookup, hash_put)
7909 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7910 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7911 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7912 * image.c (make_image, search_image_cache, lookup_image)
7913 (xpm_put_color_table_h):
7914 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7915 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7916 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7917 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7918 * alloc.c (allocate_vectorlike):
7919 Check for overflow in vector size calculations.
7920 * ccl.c (ccl_driver):
7921 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7922 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7923 need to be updated by these changes.
40087514
PE
7924 * fns.c (make_hash_table, maybe_resize_hash_table):
7925 Check for integer overflow with large hash tables.
0de4bb68
PE
7926 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7927 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7928 (SXHASH_REDUCE): New macro.
7929 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7930 Use it instead of discarding useful hash info with large hash values.
7931 (sxhash_float): New function.
7932 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7933 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7934 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7935 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7936 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7937 Adjust signatures to match updated version of code.
7938 (consing_since_gc): Now EMACS_INT, since a single hash table can
7939 use more than INT_MAX bytes.
7940
698d32e2
DN
79412011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7942
7943 Make it possible to build with GCC-4.6+ -O2 -flto.
7944
7945 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7946
fd6fa53f
SM
79472011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7948
7949 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7950 Call minibuffer-inactive-mode.
7951
864db017
JB
79522011-05-31 Juanma Barranquero <lekktu@gmail.com>
7953
7954 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7955 Update dependencies.
7956
2ad0baf4
DN
79572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7958
7959 * data.c (init_data): Remove code for UTS, this system is not
7960 supported anymore.
7961
4fcc2638
DN
79622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7963
7964 Don't force ./temacs to start in terminal mode.
7965
7966 * frame.c (make_initial_frame): Initialize faces in all cases, not
7967 only when CANNOT_DUMP is defined.
7968 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7969
c56e0fd5
DN
79702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7971
7972 * dispnew.c (add_window_display_history): Use const for the string
7973 pointer. Remove declaration, not needed.
7974
333d54da 79752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7976
55d4c1b2 7977 Use 'inline', not 'INLINE'.
333d54da 7978 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7979 * alloc.c, fontset.c (INLINE): Remove.
7980 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7981 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7982 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7983 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7984 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7985
738db178
DN
79862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7987
7988 Make it possible to run ./temacs.
7989
7990 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7991 syms_of_callproc does the same thing. Remove test for
7992 "initialized", do it in the caller.
7993 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7994
620c53a6
SM
79952011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7996
7997 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7998 (read_minibuf): Use get_minibuffer.
7999 (syms_of_minibuf): Use DEFSYM.
8000 (Qmetadata): New var.
8001 * data.c (Qbuffer): Don't make it static.
8002 (syms_of_data): Use DEFSYM.
8003
e003a292
PE
80042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8005
8006 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8007 (CCL_CODE_MIN): New macro.
8008
ed008a6d
PE
80092011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8010
3687c2ef
PE
8011 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8012
ed008a6d
PE
8013 * eval.c (Qdebug): Now static.
8014 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8015 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8016 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8017
d66c4c7c
CY
80182011-05-29 Chong Yidong <cyd@stupidchicken.com>
8019
8020 * image.c: Various fixes to ImageMagick code comments.
8021 (Fimagemagick_types): Doc fix.
8022
5fbc2025
PE
80232011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8024
0196f88a
PE
8025 Minor fixes prompted by GCC 4.6.0 warnings.
8026
8027 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8028
5fbc2025
PE
8029 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8030 (x_clipboard_manager_save_all): Move extern decl to ...
8031 * xterm.h: ... here, so that it can be checked for consistency.
8032
1dd3c2d9
CY
80332011-05-29 Chong Yidong <cyd@stupidchicken.com>
8034
8035 * xselect.c (x_clipboard_manager_save_frame)
8036 (x_clipboard_manager_save_all): New functions.
8037 (Fx_clipboard_manager_save): Lisp function deleted.
8038
8039 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8040 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8041
8042 * xterm.h: Update prototype.
8043
5ba6571d
WX
80442011-05-28 William Xu <william.xwl@gmail.com>
8045
8046 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8047 exiting (Bug#8239).
8048
3eaff834
JM
80492011-05-28 Jim Meyering <meyering@redhat.com>
8050
e1900994 8051 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8052 * fns.c (to_uchar): Define.
8053 (crypto_hash_function): Use it to convert some newly-signed
8054 variables to unsigned, to avoid sign-extension bugs. For example,
8055 without this change, (md5 "truc") would evaluate to
8056 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8057 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8058 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8059
0f6990a7
PE
80602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8061
8062 Integer overflow fixes.
c8a9ca5a 8063
08686060
PE
8064 * dbusbind.c: Serial number integer overflow fixes.
8065 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8066 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8067 to hold a serial number that is too large for a fixnum.
8068 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8069 Check for serial numbers out of range. Decode any serial number
59568bf0 8070 that was so large that it became a float. (Bug#8722)
08686060 8071
2d1fc3c7
PE
8072 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8073 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8074 Use XFASTINT rather than XUINT when numbers are nonnegative.
8075 (xd_append_arg, Fdbus_method_return_internal):
8076 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8077 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8078 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8079 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8080 (Bug#8722)
2d1fc3c7 8081
c8a9ca5a
PE
8082 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8083
519e1d69
PE
8084 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8085
6df6ae42 8086 ccl: Add integer overflow checks.
30569699
PE
8087 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8088 (IN_INT_RANGE): New macros.
8089 (ccl_driver): Use them to check for integer overflow when
8090 decoding a CCL program. Many of the new checks are whether XINT (x)
8091 fits in int; it doesn't always, on 64-bit hosts. The new version
8092 doesn't catch all possible integer overflows, but it's an
847044ea 8093 improvement. (Bug#8719)
30569699 8094
c11285dc
PE
8095 * alloc.c (make_event_array): Use XINT, not XUINT.
8096 There's no need for unsigned here.
8097
fdccd48e
PE
8098 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8099 This follows up to the 2011-05-06 change that substituted uintptr_t
8100 for EMACS_INT. This case wasn't caught back then.
8101
37910ab2
PE
8102 Rework Fformat to avoid integer overflow issues.
8103 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8104 now (part of C89). Include <verify.h>.
8105 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8106 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8107 (Fformat): Avoid the prepass trying to compute sizes; it was only
8108 approximate and thus did not catch overflow reliably. Instead, walk
8109 through the format just once, formatting and computing sizes as we go,
8110 checking for integer overflow at every step, and allocating a larger
8111 buffer as needed. Keep track separately whether the format is
8112 multibyte. Keep only the most-recently calculated precision, rather
8113 than them all. Record whether each argument has been converted to
8114 string. Use EMACS_INT, not int, for byte and char and arg counts.
8115 Support field widths and precisions larger than INT_MAX. Avoid
8116 sprintf's undefined behavior with conversion specifications such as %#d
8117 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8118 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8119 formatting out-of-range floating point numbers with int
9173deec 8120 formats. (Bug#8668)
37910ab2 8121
2e6578fb
PE
8122 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8123
0ae6bdee
PE
8124 * data.c: Avoid integer truncation in expressions involving floats.
8125 * data.c: Include <intprops.h>.
8126 (arith_driver): When there's an integer overflow in an expression
8127 involving floating point, convert the integers to floating point
8128 so that the resulting value does not suffer from catastrophic
8129 integer truncation. For example, on a 64-bit host (* 4
8130 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8131 Do not rely on undefined behavior after integer overflow.
8132
de883a70
PE
8133 merge count_size_as_multibyte, parse_str_to_multibyte
8134 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8135 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8136 Check for integer overflow.
8137 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8138 since it's now a duplicate of the other. This is more of
8139 a character than a buffer op, so better that it's in character.c.
8140 * fns.c, print.c: Adjust to above changes.
8141
2ff916cb
PE
81422011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8143
8144 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8145
f1b54466
PE
81462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8147
fb1ac845
PE
8148 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8149 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8150 (x_clipboard_manager_save): Now static.
8151 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8152
f1b54466
PE
8153 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8154 (crypto_hash_function): Now static.
8155 Fix pointer signedness problems. Avoid unnecessary initializations.
8156
a9f737ee
CY
81572011-05-27 Chong Yidong <cyd@stupidchicken.com>
8158
8159 * termhooks.h (Vselection_alist): Make it terminal-local.
8160
8161 * terminal.c (create_terminal): Initialize it.
8162
8163 * xselect.c: Support for clipboard managers.
8164 (Vselection_alist): Move to termhooks.h as terminal-local var.
8165 (LOCAL_SELECTION): New macro.
8166 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8167 (symbol_to_x_atom): Remove gratuitous arg.
8168 (x_handle_selection_request, lisp_data_to_selection_data)
8169 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8170 (x_own_selection, x_get_local_selection, x_convert_selection):
8171 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8172 (some_frame_on_display): Delete unused function.
8173 (Fx_own_selection_internal, Fx_get_selection_internal)
8174 (Fx_disown_selection_internal, Fx_selection_owner_p)
8175 (Fx_selection_exists_p): New optional frame arg.
8176 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8177 (x_handle_selection_clear): Don't treat other terminals with the
8178 same keyboard specially. Use the terminal-local Vselection_alist.
8179 (x_clear_frame_selections): Use Frun_hook_with_args.
8180
8181 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8182
8183 * xterm.h: Add support for those atoms.
8184
e067f0c1
CY
81852011-05-26 Chong Yidong <cyd@stupidchicken.com>
8186
8187 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8188 (converted_selections, conversion_fail_tag): New global variables.
8189 (x_selection_request_lisp_error): Free the above.
8190 (x_get_local_selection): Remove unnecessary code.
8191 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8192 of converted selections stored in converted_selections.
8193 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8194 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8195 (x_convert_selection): New function.
8196 (x_handle_selection_event): Simplify.
8197 (x_get_foreign_selection): Don't ignore incoming requests while
8198 waiting for an answer; this will fail when we implement
8199 SAVE_TARGETS, and seems unnecessary anyway.
8200 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8201 (Vx_sent_selection_functions): Doc fix.
8202
0f4aebc0
LL
82032011-05-26 Leo Liu <sdl.web@gmail.com>
8204
8205 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8206
e61124cd
YM
82072011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8208
8209 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8210
8211 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8212 for fringe update if it has periodic bitmap.
ac389d0c 8213 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8214 and fringe_bitmap_periodic_p.
8215
8216 * fringe.c (get_fringe_bitmap_data): New function.
8217 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8218 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8219 row. Mark glyph row for fringe update if periodicity changed.
8220
8221 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8222 for fringe update unless it has periodic bitmap.
8223
f16d9837
KH
82242011-05-25 Kenichi Handa <handa@m17n.org>
8225
8226 * xdisp.c (get_next_display_element): Set correct it->face_id for
8227 a static composition.
8228
e1b90ef6
LL
82292011-05-24 Leo Liu <sdl.web@gmail.com>
8230
8231 * deps.mk (fns.o):
8232 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8233
8234 * fns.c (crypto_hash_function, Fsha1): New function.
8235 (Fmd5): Use crypto_hash_function.
8236 (syms_of_fns): Add Ssha1.
8237
7400048f
PE
82382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8239
8240 * gnutls.c: Remove unused macros.
8241 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8242 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8243 Remove macros that are defined and never used.
8244 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8245
abb71cf4
CY
82462011-05-22 Chong Yidong <cyd@stupidchicken.com>
8247
8248 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8249 (Fx_get_selection_internal): Minor cleanup.
8250 (Fx_own_selection_internal): Rename arguments for consistency with
8251 select.el.
8252
6307db39
PE
82532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8254
8255 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8256
f3d4e0a4
CY
82572011-05-22 Chong Yidong <cyd@stupidchicken.com>
8258
8259 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8260
4d8ade89
YM
82612011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8262
8263 * dispnew.c (scrolling_window): Don't exclude the case that the
8264 last enabled row in the desired matrix touches the bottom boundary.
8265
32078c8d
GM
82662011-05-21 Glenn Morris <rgm@gnu.org>
8267
8268 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8269 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8270 and add some more files.
32078c8d 8271
7285dc67
EZ
82722011-05-20 Eli Zaretskii <eliz@gnu.org>
8273
8274 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8275 report_file_error introduced by the change from 2011-05-07.
8276
89d1bd22
PE
82772011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8278
8279 * systime.h (Time): Define only if emacs is defined.
8280 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8281 where the include path doesn't have X11/X.h by default. See
8282 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8283
cd394be1 82842011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8285
8286 * composite.c (find_automatic_composition): Fix previous change.
8287
b9704ad9
GM
82882011-05-20 Glenn Morris <rgm@gnu.org>
8289
8290 * lisp.mk: New file, split from Makefile.in.
8291 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8292 (shortlisp): Remove.
8293 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8294
4a720484
GM
82952011-05-19 Glenn Morris <rgm@gnu.org>
8296
8297 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8298 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8299 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8300 (lisp): Set the order to that of loadup.el.
8301 (shortlisp): Make it a copy of $lisp.
8302 (SOME_MACHINE_LISP): Remove.
8303 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8304 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8305
a28d4396
KH
83062011-05-18 Kenichi Handa <handa@m17n.org>
8307
8308 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8309 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8310 (find_automatic_composition): Mostly rewrite for efficiency.
8311
a2b1fa8e
JB
83122011-05-18 Juanma Barranquero <lekktu@gmail.com>
8313
8314 * makefile.w32-in: Update dependencies.
8315
8e1f5610
CS
83162011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8317
8318 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8319 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8320
7025ee00 83212011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8322
cdfa6eab
PE
8323 Fix some integer overflow issues, such as string length overflow.
8324
06d6db33
PE
8325 * insdel.c (count_size_as_multibyte): Check for string overflow.
8326
2b4560a8
PE
8327 * character.c (lisp_string_width): Check for string overflow.
8328 Use EMACS_INT, not int, for string indexes and lengths; in
8329 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8330 the resulting string length overflows an EMACS_INT; instead,
8331 report a string overflow if no precision given. When checking for
8332 precision exhaustion, use a check that cannot possibly have
8333 integer overflow. (Bug#8675)
8334 * character.h (lisp_string_width): Adjust to new signature.
8335
cb93f9be
PE
8336 * alloc.c (string_overflow): New function.
8337 (Fmake_string): Use it. This doesn't change behavior, but saves
8338 a few bytes and will simplify future changes.
8339 * character.c (string_escape_byte8): Likewise.
8340 * lisp.h (string_overflow): New decl.
8341
1a1f3366
PE
8342 Fixups, following up to the user-interface timestamp change.
8343 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8344 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8345 * msdos.c (mouse_get_pos): Likewise.
8346 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8347 * w32gui.h (Time): Define by including "systime.h" rather than by
8348 declaring it ourselves. (Bug#8664)
8349
d4e3e4d3
PE
8350 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8351 * image.c (clear_image_cache): Likewise.
8352
f6a24d19
PE
8353 * term.c (term_mouse_position): Don't assume time_t wraparound.
8354
08dc5ae6
PE
8355 Be more systematic about user-interface timestamps.
8356 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8357 and sometimes 'EMACS_UINT', to represent these timestamps.
8358 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8359 This makes the code easier to follow, and makes it easier to catch
8360 integer overflow bugs such as Bug#8664.
8361 * frame.c (Fmouse_position, Fmouse_pixel_position):
8362 Use Time, not unsigned long, for user-interface timestamps.
8363 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8364 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8365 * keyboard.h (last_event_timestamp): Likewise.
8366 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8367 * menu.h (xmenu_show): Likewise.
8368 * term.c (term_mouse_position): Likewise.
8369 * termhooks.h (struct input_event.timestamp): Likewise.
8370 (struct terminal.mouse_position_hook): Likewise.
8371 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8372 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8373 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8374 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8375 what it was before.
8376 * menu.h, termhooks.h: Include "systime.h", for Time.
8377
8e55734a
PE
8378 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8379 Don't assume that the difference between two unsigned long values
8380 can fit into an integer. At this point, we know button_down_time
8381 <= event->timestamp, so the difference must be nonnegative, so
8382 there's no need to cast the result if double-click-time is
8383 nonnegative, as it should be; check that it's nonnegative, just in
8384 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8385 apart (about 25 days). (Bug#8664)
8e55734a 8386
841f1b75 8387 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8388 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8389
3e26f69c
PE
8390 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8391 that always fit in int. Use a sentinel instead of a counter, to
8392 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8393 * frame.h (struct frame): Use int for menu_bar_items_used
8394 instead of EMACS_INT, since it always fits in int.
3e26f69c 8395
5cc152c0
PE
8396 * menu.c (grow_menu_items): Check for int overflow.
8397
d89eb65e
PE
8398 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8399
5235bd3e
PE
8400 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8401 Before, the code was not consistent. These values cannot exceed
8402 2**31 - 1 so there's no need to make them unsigned.
8403 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8404 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8405 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8406 as modifiers.
8407 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8408
bc827e23
PE
8409 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8410 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8411 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8412 presumably because the widths might not match.
8413
78eb494e
PE
8414 * window.c (size_window): Avoid needless test at loop start.
8415
04f2d78b
CB
84162011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8417
8418 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8419
d2fc7e3d 84202011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8421
8422 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8423
d2fc7e3d 84242011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8425
8426 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8427 `width' to `bar_area_x' and `bar_area_width', respectively.
8428 (x_scroll_run): Take account of fringe background extension.
8429
04f2d78b
CB
8430 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8431 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8432 `bar_area_width', respectively.
8433 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8434 background extension.
8435
79b70037
GM
84362011-05-10 Jim Meyering <meyering@redhat.com>
8437
8438 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8439
2f142cc5
JB
84402011-05-10 Juanma Barranquero <lekktu@gmail.com>
8441
8442 * image.c (Finit_image_library): Return t for built-in image types,
8443 like pbm and xbm. (Bug#8640)
8444
57679c86
AS
84452011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8446
8447 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8448
888c9e86
EZ
84492011-05-07 Eli Zaretskii <eliz@gnu.org>
8450
b0512a1d
EZ
8451 * w32console.c (Fset_screen_color): Doc fix.
8452 (Fget_screen_color): New function.
8453 (syms_of_ntterm): Defsubr it.
8454
7285dc67
EZ
8455 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8456 unlink the temporary file if Fcall_process didn't create it in the
8457 first place.
8458 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8459 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8460 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8461 cue to call_process_cleanup not to close that handle.
8462
4d3fcc8e
BK
84632011-05-07 Ben Key <bkey76@gmail.com>
8464
8465 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8466 one of two shell specific rules, either bootstrap-temacs-CMD or
8467 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8468 to the previous implementation of the bootstrap-temacs rule.
8469 The bootstrap-temacs-CMD rule is similar to the previous
8470 implementation of the bootstrap-temacs rule except that it
8471 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8472 variable.
8473
8474 These changes, along with some changes to nt/configure.bat,
8475 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8476 earlier fix to add support for --cflags and --ldflags options
8477 that include quotes so that it works whether make uses cmd or
8478 sh as the shell.
8479
b4289b64
MA
84802011-05-06 Michael Albinus <michael.albinus@gmx.de>
8481
8482 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8483 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8484 is a constant.
8485 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8486 a string. Handle both cases.
8487 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8488 (Fdbus_register_method): Use Qinvalid_function.
8489
af4c0e28
JB
84902011-05-06 Juanma Barranquero <lekktu@gmail.com>
8491
8492 * makefile.w32-in: Update dependencies.
8493 (LISP_H): Add inttypes.h and stdin.h.
8494 (PROCESS_H): Add unistd.h.
8495
c51453d9
EZ
84962011-05-06 Eli Zaretskii <eliz@gnu.org>
8497
8498 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8499 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8500
8ff0ac3c 85012011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8502
4c4b566b
PE
8503 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8504
aab2b9b5
PE
8505 * term.c (vfatal): Remove stray call to va_end.
8506 It's not needed and the C Standard doesn't allow it here anyway.
8507
c378da0b
PE
8508 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8509 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8510
288b08c7
PE
8511 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8512 bytes.
8513
e3601888
PE
8514 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8515
db6c0e74
PE
8516 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8517
dd5963ea
PE
8518 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8519
88c9450f
PE
8520 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8521
2f9442b8
PE
8522 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8523
c032b5f8
PE
8524 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8525 * charset.c (Fdefine_charset_internal): Don't initialize
8526 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8527 32-bit int (Bug#8600).
a108c10b
PE
8528
8529 * lread.c (read_integer): Be more consistent with string-to-number.
8530 Use string_to_number to do the actual conversion; this avoids
8531 rounding errors and fixes some other screwups. Without this fix,
8532 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8533 (digit_to_number): Move earlier, for benefit of read_integer.
8534 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8535 not a digit in any supported base. (Bug#8602)
a108c10b 8536
ad5f9eea
PE
8537 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8538
aec1708a
PE
8539 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8540 to match comment at start of function. This also removes a
8541 GCC warning about overflow in a 32+64-bit port.
8542
47be4ab5
PE
8543 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8544
371cac43
PE
8545 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8546 Reported by Stefan Monnier in
8547 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8548 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8549 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8550
d01a7826
PE
8551 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8552 (EMACS_UINTPTR): Likewise, with uintptr_t.
8553
7fd47d5c
PE
8554 * lisp.h: Prefer 64-bit EMACS_INT if available.
8555 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8556 on 32-bit hosts that have 64-bit int, so that they can access
8557 large files.
122b0c86
PE
8558 However, temporarily disable this change unless the temporary
8559 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8560
8727937b
PE
8561 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8562
8ac068ac
PE
8563 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8564 This removes an assumption that EMACS_INT and long are the same
8565 width as pointers. The assumption is true for Emacs porting targets
8566 now, but we want to make other targets possible.
8567 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8568 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8569 In the rest of the code, change types of integers that hold casted
8570 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8571 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8572 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8573 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8574 No need to cast type when ORing.
8575 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8576 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8577 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8578 assume EMACS_INT is the same width as char *.
8579 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8580 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8581 Remove no-longer-needed casts.
8582 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8583 (xg_tool_bar_help_callback, xg_make_tool_item):
8584 Use EMACS_INTPTR to hold an integer
8585 that will be cast to void *; this can avoid a GCC warning
8586 if EMACS_INT is not the same width as void *.
8587 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8588 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8589 (current_message_1, set_message_1):
8590 Use a local to convert to proper width without a cast.
8591 * xmenu.c (dialog_selection_callback): Likewise.
8592
ede49d71
PE
8593 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8594 Also, don't assume VALBITS / RAND_BITS is less than 5,
8595 and don't rely on undefined behavior when shifting a 1 left into
8596 the sign bit.
8597 * lisp.h (get_random): Change signature to match.
8598
2f30ecd0
PE
8599 * lread.c (hash_string): Use size_t, not int, for hash computation.
8600 Normally we prefer signed values; but hashing is special, because
8601 it's better to use unsigned division on hash table sizes so that
8602 the remainder is nonnegative. Also, size_t is the natural width
8603 for hashing into memory. The previous code used 'int', which doesn't
8604 retain enough info to hash well into very large tables.
8605 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8606
2a866e7b
PE
8607 * dbusbind.c: Don't possibly lose pointer info when converting.
8608 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8609 Use XPNTR rather than XHASH, so that the high-order bits of
8610 the pointer aren't lost when converting through void *.
8611
51639eac
PE
8612 * eval.c (Fautoload): Don't double-shift a pointer.
8613
92394119
PE
8614 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8615
dbdb9a7c
JB
86162011-05-06 Juanma Barranquero <lekktu@gmail.com>
8617
8618 * gnutls.c (DEF_GNUTLS_FN):
8619 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8620
db7a0b4f
AS
86212011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8622
8623 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8624 marker. (Bug#8610)
8625
cd394be1 86262011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8627
8628 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8629 New version that can reserve upto 2GB of heap space.
8630
f7ff1b0f 86312011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8632
8633 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8634
639c109b
TZ
86352011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8636
8637 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8638 `gnutls_certificate_set_x509_key_file'.
8639
d2127135
JB
86402011-05-05 Juanma Barranquero <lekktu@gmail.com>
8641
8642 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8643 Update dependencies.
8644
e968f4f3
JB
86452011-05-04 Juanma Barranquero <lekktu@gmail.com>
8646
8647 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8648 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8649 Remove unused parameter `fildes'.
8650 * process.c (read_process_output, send_process): Don't pass it.
8651
84d358f0
JB
86522011-05-04 Juanma Barranquero <lekktu@gmail.com>
8653
8654 Fix previous change: the library cache is defined in w32.c.
8655 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8656 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8657
0898ca10
JB
86582011-05-04 Juanma Barranquero <lekktu@gmail.com>
8659
8660 Implement dynamic loading of GnuTLS on Windows.
8661
8662 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8663 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8664 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8665 Declare.
8666
8667 * gnutls.c (Qgnutls_dll): Define.
8668 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8669 (gnutls_*): Declare function pointers.
8670 (init_gnutls_functions): New function to initialize function pointers.
8671 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8672 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8673 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8674 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8675 (emacs_gnutls_write, emacs_gnutls_read)
8676 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8677 (Fgnutls_available_p): New function.
8678 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8679 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8680 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8681
8682 * image.c: Include w32.h.
8683 (Vimage_type_cache): Delete.
8684 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8685 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8686 (w32_delayed_load): Move to w32.c.
8687
8688 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8689
8690 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8691 (w32_delayed_load): Move from image.c. When loading a library, record
8692 its filename in the :loaded-from property of the library id.
8693 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8694 Initialize and staticpro them.
8695 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8696
8697 * process.c: Include lisp.h before w32.h, not after.
8698 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8699 instead of gnutls_record_check_pending.
8700
8701 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8702
ff4de4aa
TZ
87032011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8704
8705 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8706 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8707 as passed in.
8708
abe95abb
JD
87092011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8710
8711 * xterm.c (x_set_frame_alpha): Do not set property on anything
8712 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8713
e16e55d4
JB
87142011-05-02 Juanma Barranquero <lekktu@gmail.com>
8715
8716 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8717
bafcf6a5
JB
87182011-05-02 Juanma Barranquero <lekktu@gmail.com>
8719
8720 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8721 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8722 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8723 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8724 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8725 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8726 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8727 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8728 (Qgnutls_bootprop_callbacks_verify): Make static.
8729
e7a6747f
AS
87302011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8731
19ed11ba
AS
8732 * callproc.c: Indentation fixup.
8733
e7a6747f 8734 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8735 (wait_for_termination, interruptible_wait_for_termination):
8736 Move after wait_for_termination_1.
e7a6747f 8737
1ef14cb4
LMI
87382011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8739
8740 * sysdep.c (interruptible_wait_for_termination): New function
8741 which is like wait_for_termination, but allows keyboard
8742 interruptions.
8743
8744 * callproc.c (Fcall_process): Add (:file "file") as an option for
8745 the STDOUT buffer.
8746 (Fcall_process_region): Ditto.
8747
330d880c
EZ
87482011-04-30 Eli Zaretskii <eliz@gnu.org>
8749
8db90b73
EZ
8750 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8751 rather than `XVECTOR (FOO)->size'.
8752
330d880c
EZ
8753 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8754 inttypes.h, as a gnulib replacement is used if it not available in
8755 system headers.
8756
15cbd324
EZ
87572011-04-21 Eli Zaretskii <eliz@gnu.org>
8758
8759 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8760 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8761 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8762
8763 * coding.c (coding_alloc_by_realloc): Error out if destination
8764 will grow beyond MOST_POSITIVE_FIXNUM.
8765 (decode_coding_emacs_mule): Abort if there isn't enough place in
8766 charbuf for the composition carryover bytes. Reserve an extra
8767 space for up to 2 characters produced in a loop.
8768 (decode_coding_iso_2022): Abort if there isn't enough place in
8769 charbuf for the composition carryover bytes.
8770
87712011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8772
ae940cca
EZ
8773 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8774 aborting when %lld or %lll format is passed.
8775 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8776 %llo or %llx format is passed. (Bug#8545)
8777
03ab8921
EZ
8778 * window.c (window_scroll_line_based): Use a marker instead of
8779 simple variables to record original value of point. (Bug#7952)
8780
afda1437
EZ
8781 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8782 produced by %s or %c overflows available buffer space. (Bug#8545)
8783
f76dee0c
PE
87842011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8785
8786 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8787 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8788
fdc5744d
JB
87892011-04-28 Juanma Barranquero <lekktu@gmail.com>
8790
8791 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8792
638f053a
JB
87932011-04-28 Juanma Barranquero <lekktu@gmail.com>
8794
8795 * keyboard.c (Qdelayed_warnings_hook): Define.
8796 (command_loop_1): Run `delayed-warnings-hook'
8797 if Vdelayed_warnings_list is non-nil.
8798 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8799 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8800
d178f871
EZ
88012011-04-28 Eli Zaretskii <eliz@gnu.org>
8802
8803 * doprnt.c (doprnt): Don't return value smaller than the buffer
8804 size if the message was truncated. (Bug#8545).
8805
b124fd93
JB
88062011-04-28 Juanma Barranquero <lekktu@gmail.com>
8807
8808 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8809 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8810
e810457d
PE
88112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8812
8813 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8814
ea51cceb
JB
88152011-04-27 Juanma Barranquero <lekktu@gmail.com>
8816
8817 * makefile.w32-in: Update dependencies.
8818
94dcfacf
EZ
88192011-04-27 Eli Zaretskii <eliz@gnu.org>
8820
8821 Improve `doprnt' and its usage. (Bug#8545)
8822 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8823 `format_end'. Remove support for %l as a conversion specifier.
8824 Don't use xrealloc. Improve diagnostics when the %l size modifier
8825 is used. Update the commentary.
8826
8827 * eval.c (verror): Simplify calculation of size_t.
8828
8829 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8830 messages.
8831
f61f41d7
PE
88322011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8833
8834 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8835 change.
8836
96fb4434
PE
88372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8838
8839 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8840 This makes this file independent of the recent pseudovector change.
8841
671875da 88422011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8843
69e9b5a3
PE
8844 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8845
b5f869a7 8846 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8847 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8848 Remove unused local.
c8926152 8849 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8850
841a1577 8851 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8852 GCC 4.6.0 optimizes based on type-based alias analysis.
8853 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8854 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8855 != &v->size, and therefore "v->size = 1; b->size = 2; return
8856 v->size;" must therefore return 1. This assumption is incorrect
8857 for Emacs, since it type-puns struct Lisp_Vector * with many other
8858 types. To fix this problem, this patch adds a new type struct
f904488f 8859 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8860 and pseudovectors, and helps optimizing compilers not get fooled
8861 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8862 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8863 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8864 the size member.
eab3844f
PE
8865 (XSETPVECTYPE): Rewrite in terms of new macro.
8866 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8867 This is a bit clearer, and further avoids the possibility of
8868 undesirable aliasing.
8869 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8870 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8871 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8872 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8873 (ASIZE): Now uses header.size rather than size.
8874 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8875 to avoid the hassle of writing XVECTOR (foo)->header.size.
8876 (struct vectorlike_header): New type.
eab3844f
PE
8877 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8878 object, to help avoid aliasing.
8879 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8880 (SUBRP): Likewise, since Lisp_Subr is a special case.
8881 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8882 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8883 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8884 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8885 changed to be "header.size" and "header.next".
8886 * buffer.h (struct buffer): Likewise.
8887 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8888 * frame.h (struct frame): Likewise.
8889 * process.h (struct Lisp_Process): Likewise.
8890 * termhooks.h (struct terminal): Likewise.
8891 * window.c (struct save_window_data, struct saved_window): Likewise.
8892 * window.h (struct window): Likewise.
8893 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8894 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8895 * buffer.c (init_buffer_once): Likewise.
8896 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8897 special case.
8898 * process.c (Fformat_network_address): Use local var for size,
8899 for brevity.
8900
0df1eac5
PE
8901 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8902
847ab9d1 8903 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8904 * data.c (atof): Remove decl; no longer used or needed.
8905 (digit_to_number): Move to lread.c.
8906 (Fstring_to_number): Use new string_to_number function, to be
8907 consistent with how the Lisp reader treats infinities and NaNs.
8908 Do not assume that floating-point numbers represent EMACS_INT
8909 without losing information; this is not true on most 64-bit hosts.
8910 Avoid double-rounding errors, by insisting on integers when
8911 parsing non-base-10 numbers, as the documentation specifies.
8912 * lisp.h (string_to_number): New decl, replacing ...
8913 (isfloat_string): Remove.
bc0a5c13 8914 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8915 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8916 appears to have been a coding error. Similarly, do not accept
8917 strings like +-1e0 as floating point numbers. Do not report
8918 overflow for integer overflows unless the base is not 10 which
8919 means we have no simple and reliable way to continue.
8920 Break out the floating-point parsing into a new
8921 function string_to_number, so that Fstring_to_number parses
8922 floating point numbers consistently with the Lisp reader.
04f2d78b 8923 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8924 (E_CHAR, EXP_INT): Remove, replacing with ...
8925 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8926 (string_to_number): New function, replacing isfloat_string.
8927 This function checks for valid syntax and produces the resulting
8928 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8929 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8930 so that overflow for non-base-10 numbers is reported only when
8931 there's no portable and simple way to convert to floating point.
452f4150 8932
67769ffc
PE
8933 * textprop.c (set_text_properties_1): Rewrite for clarity,
8934 and to avoid GCC warning about integer overflow.
8935
c20db43f
PE
8936 * intervals.h (struct interval): Use EMACS_INT for members
8937 where EMACS_UINT might cause problems. See
8938 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8939 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8940 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8941 All uses changed.
37aa2f85
PE
8942 (offset_intervals): Tell GCC not to worry about length overflow
8943 when negating a negative length.
c20db43f 8944
2538aa2f
PE
8945 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8946 (overrun_check_free): Likewise.
8947
f2d3008d
PE
8948 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8949 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8950 word size.
8951
ec8df744
PE
8952 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8953 (gnutls_make_error): Rename local to avoid shadowing.
8954 (gnutls_emacs_global_deinit): ifdef out; not used.
8955 (Fgnutls_boot): Use const for pointer to readonly storage.
8956 Comment out unused local. Fix pointer signedness problems.
8957
640ee02d
PE
8958 * lread.c (openp): Don't stuff size_t into an 'int'.
8959 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8960 about possible signed overflow.
8961
6048fb2a
PE
8962 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8963 (GDK_KEY_g): Don't define if already defined.
8964 (xg_prepare_tooltip): Avoid pointer signedness problem.
8965 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8966
fa3c87e1
PE
8967 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8968 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8969
2172544b
PE
8970 * xfns.c (Fx_window_property): Simplify a bit,
8971 to make a bit faster and to avoid GCC 4.6.0 warning.
8972 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8973
9b821a21
PE
8974 * fns.c (internal_equal): Don't assume size_t fits in int.
8975
3c616cfa
PE
8976 * alloc.c (compact_small_strings): Tighten assertion a little.
8977
c2982e87
PE
8978 Replace pEd with more-general pI, and fix some printf arg casts.
8979 * lisp.h (pI): New macro, generalizing old pEd macro to other
8980 conversion specifiers. For example, use "...%"pI"d..." rather
8981 than "...%"pEd"...".
8982 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8983 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8984 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8985 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8986 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8987 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8988 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8989 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8990 64-bit hosts.
8991 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8992 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8993 * print.c (safe_debug_print, print_object): Likewise.
8994 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8995 to int.
6f04d126
PE
8996 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8997 avoiding the 0 flag, which is not portable.
c2982e87
PE
8998 * process.c (Fmake_network_process): Use pI to avoid cast.
8999 * region-cache.c (pp_cache): Likewise.
9000 * xdisp.c (decode_mode_spec): Likewise.
9001 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9002 behavior on 64-bit hosts with printf arg.
6f04d126 9003 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9004 (x_stop_queuing_selection_requests): Likewise.
9005 (x_get_window_property): Don't truncate byte count to an 'int'
9006 when tracing.
0b432f21 9007
5e073ec7
PE
9008 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9009 here, since it parses constructs like leading '-' and spaces,
9010 which are not wanted; and it overflows with large numbers.
9011 Instead, simply match F[0-9]+, which is what is wanted anyway.
9012
36372bf9
PE
9013 * alloc.c: Remove unportable assumptions about struct layout.
9014 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9015 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9016 (allocate_vectorlike, make_pure_vector): Use the new macros,
9017 plus offsetof, to remove unportable assumptions about struct layout.
9018 These assumptions hold on all porting targets that I know of, but
9019 they are not guaranteed, they're easy to remove, and removing them
9020 makes further changes easier.
9021
0b432f21
PE
9022 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9023 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9024 (string_overrun_cookie): Now const. Use initializers that
9025 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9026 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9027 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9028 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9029 multiple of sizeof (EMACS_INT); it need not be, if
9030 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9031 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9032
895009e1
JB
90332011-04-26 Juanma Barranquero <lekktu@gmail.com>
9034
9035 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9036
6a7a1b0b
TZ
90372011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9038
9039 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9040 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9041 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9042
841a1577 90432011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9044
9045 * lisp.h (Qdebug): List symbol.
895009e1 9046 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9047 * keyboard.c (debug-on-event): New variable.
9048 (handle_user_signal): Break into debugger when debug-on-event
9049 matches the current signal symbol.
9050
f2d3ba6f
DN
90512011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9052
9053 * alloc.c (check_sblock, check_string_bytes)
9054 (check_string_free_list): Convert to standard C.
9055
42ce4c63
TZ
90562011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9057
9058 * w32.c (emacs_gnutls_push): Fix typo.
9059
825cd63c
EZ
90602011-04-25 Eli Zaretskii <eliz@gnu.org>
9061
fb11d64d
EZ
9062 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9063 "cast to pointer from integer of different size".
9064
825cd63c
EZ
9065 Improve doprnt and its use in verror. (Bug#8545)
9066 * doprnt.c (doprnt): Document the set of format control sequences
9067 supported by the function. Use SAFE_ALLOCA instead of always
9068 using `alloca'.
9069
9070 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9071 is one byte too soon. Don't use xrealloc; instead xfree and
9072 xmalloc anew.
9073
e061a11b
TZ
90742011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9075
9076 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9077 callbacks stage.
9078
9079 * gnutls.c: Renamed global_initialized to
9080 gnutls_global_initialized. Added internals for the
9081 :verify-hostname-error, :verify-error, and :verify-flags
9082 parameters of `gnutls-boot' and documented those parameters in the
9083 docstring. Start callback support.
9173deec
JB
9084 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9085 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9086 on error. Return error code.
e061a11b
TZ
9087 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9088 (emacs_gnutls_read): Likewise.
9089 (Fgnutls_boot): Return handshake error code.
9090 (emacs_gnutls_handle_error): New function.
9091 (wsaerror_to_errno): Likewise.
9092
9093 * w32.h (emacs_gnutls_pull): Add prototype.
9094 (emacs_gnutls_push): Likewise.
9095
9096 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9097 (emacs_gnutls_push): Likewise.
9098
90992011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9100
9101 * process.c (wait_reading_process_output): Check if GnuTLS
9102 buffered some data internally if no FDs are set for TLS
9103 connections.
9104
9105 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9106 (LIBS): Link to USER_LIBS.
9107 ($(BLD)/gnutls.$(0)): New target.
9108
fa6996bc
EZ
91092011-04-24 Eli Zaretskii <eliz@gnu.org>
9110
eb35682e
EZ
9111 * xdisp.c (handle_single_display_spec): Rename the
9112 display_replaced_before_p argument into display_replaced_p, to
9113 make it consistent with the commentary. Fix typos in the
9114 commentary.
9115
e2ad650c
EZ
9116 * textprop.c (syms_of_textprop): Remove dead code.
9117 (copy_text_properties): Delete obsolete commentary about an
9118 interface that was deleted long ago. Fix typos in the description
9119 of arguments.
9120
1b2de274
EZ
9121 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9122 to changes in oldXMenu/XMenu.h from 2011-04-16.
9123 <menu_help_message, prev_menu_help_message>: Constify.
9124 (IT_menu_make_room): menu->help_text is now `const char **';
9125 adjust.
9126
9127 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9128 to changes in oldXMenu/XMenu.h from 2011-04-16.
9129 (struct XMenu): Declare `help_text' `const char **'.
9130
9131 * xfaces.c <Qunspecified>: Make extern again.
9132
9133 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9134 required by POSIX.
1b2de274 9135
762b15be
EZ
9136 * doc.c (get_doc_string): Improve the format passed to `error'.
9137
9138 * doprnt.c (doprnt): Improve commentary.
9139
9140 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9141
9142 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9143 them with etags.
9144
f1052e5d
EZ
9145 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9146 changes in globals.h immediately force recompilation.
762b15be
EZ
9147 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9148 $(CURDIR)/s/ms-w32.h.
9149 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9150
fa6996bc
EZ
9151 * character.c (Fchar_direction): Function deleted.
9152 (syms_of_character): Don't defsubr it.
9153 <char-direction-table>: Deleted.
9154
e6c3da20
EZ
91552011-04-23 Eli Zaretskii <eliz@gnu.org>
9156
9157 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9158 * doprnt.c: Include limits.h.
9159 (SIZE_MAX): New macro.
04f2d78b
CB
9160 (doprnt): Return a size_t value. 2nd arg is now size_t.
9161 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9162 Improve overflow protection. Support `l' modifier for integer
9163 conversions. Support %l conversion. Don't assume an EMACS_INT
9164 argument for integer conversions and for %c.
9165
9166 * lisp.h (doprnt): Restore prototype.
9167
9168 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9169 $(SRC)/character.h.
9170
9171 * Makefile.in (base_obj): Add back doprnt.o.
9172
9173 * deps.mk (doprnt.o): Add back prerequisites.
9174 (callint.o): Depend on character.h.
9175
9176 * eval.c (internal_lisp_condition_case): Include the handler
9177 representation in the error message.
9178 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9179 when breaking from the loop.
9180
9181 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9182
9183 * callint.c (Fcall_interactively): When displaying error message
9184 about invalid control letter, pass the character's codepoint, not
9185 a pointer to its multibyte form. Improve display of the character
9186 in octal and display also its hex code.
9187
9188 * character.c (char_string): Use %x to display the (unsigned)
9189 codepoint of an invalid character, to avoid displaying a bogus
9190 negative value.
9191
9192 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9193 `error', not SYMBOL_NAME itself.
9194
9195 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9196 character arguments to `error'.
9197
9198 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9199 to `error' in error message about FINAL_CHAR argument. Make sure
9200 FINAL_CHAR is a character, and use %c when it is passed as
9201 argument to `error'.
9202
4ffd0d6b 92032011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9204
9205 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9206
9207 * w32.c: Include <time.h>.
9208 (sys_localtime): New function.
9209
4ffd0d6b 92102011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9211
9212 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9213
4ffd0d6b 9214 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9215
4ffd0d6b 92162011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9217
4ffd0d6b
GM
9218 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9219 zombies (Bug#8467).
aac0c6e3 9220
04c56954
EZ
92212011-04-19 Eli Zaretskii <eliz@gnu.org>
9222
9223 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9224 gl_state.e_property when gl_state.object is Qt.
9225
9226 * insdel.c (make_gap_larger): Remove limitation of buffer size
9227 to <= INT_MAX.
9228
16a43933
CY
92292011-04-18 Chong Yidong <cyd@stupidchicken.com>
9230
9231 * xdisp.c (lookup_glyphless_char_display)
9232 (produce_glyphless_glyph): Handle cons cell entry in
9233 glyphless-char-display.
9234 (Vglyphless_char_display): Document it.
9235
9236 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9237 glyphless-char-display.
9238
4581706e
CY
92392011-04-17 Chong Yidong <cyd@stupidchicken.com>
9240
9241 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9242
9243 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9244
9245 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9246 definition for no-X builds.
9247
4887c6e2 92482011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9249
fd35b6f9
PE
9250 Static checks with GCC 4.6.0 and non-default toolkits.
9251
5c1ccb01
PE
9252 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9253
006c5daa
PE
9254 * process.c (keyboard_bit_set): Define only if SIGIO.
9255 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9256 (send_process): Repair possible setjmp clobbering.
9257
efc736d3
PE
9258 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9259
4e2fe2e6
PE
9260 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9261
f97334a2
PE
9262 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9263
4e75f29d
PE
9264 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9265 Define only if needed.
9266
90efadd1
PE
9267 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9268 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9269 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9270
3c647824
PE
9271 * dispextern.h (struct redisplay_interface): Rename param
9272 to avoid shadowing.
e264f262 9273 * termhooks.h (struct terminal): Likewise.
761383f4 9274 * xterm.c (xembed_send_message): Likewise.
3c647824 9275
b58c5c4a
PE
9276 * insdel.c (make_gap_smaller): Define only if
9277 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9278
cad59032
PE
9279 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9280 it.
9281
c339dc2e
PE
9282 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9283 so that we aren't warned about unused symbols.
9284
91a3e27b
PE
9285 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9286
399c71d3 9287 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9288
8ffc96f5
PE
9289 * xfns.c (x_real_positions): Mark locals as initialized.
9290
eef9bc79
PE
9291 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9292
098db9dd
PE
9293 * xterm.c: Fix problems found by static analysis with other toolkits.
9294 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9295 (x_dispatch_event): Declare static if USE_GTK, and
9296 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9297 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9298 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9299 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9300 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9301
eb18f6cc
PE
9302 * xmenu.c (menu_help_callback): Pointer type fixes.
9303 Use const pointers when pointing at readonly data. Avoid pointer
9304 signedness clashes.
9305 (FALSE): Remove unused macro.
9306 (update_frame_menubar): Remove unused decl.
9307
1fe72bf8
PE
9308 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9309
60d9e1db
PE
9310 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9311 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9312 (single_menu_item): Rename local to avoid shadowing.
9313
39261c26
PE
9314 * keyboard.c (make_lispy_event): Remove unused local var.
9315
018c5e19
PE
9316 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9317 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9318
63d2b86e
PE
9319 * bitmaps: Change bitmaps from unsigned char back to the X11
9320 compatible char. Avoid the old compiler warnings about
9321 out-of-range initializers by using, for example, '\xab' rather
9322 than 0xab.
9323
aefd87e1
PE
9324 * xgselect.c (xgselect_initialize): Check vs interface
9325 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9326
bf501fb9
PE
9327 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9328
e9829fdf
PE
9329 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9330 to read-only memory.
9331
1086c095
PE
9332 * fns.c (vector): Remove; this old hack is no longer needed.
9333
2baccd04 9334 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9335 Remove unused var.
dde42981 9336 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9337
72391843 9338 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9339
436c16df 9340 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9341 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9342 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9343
92bb796d 9344 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9345 (x_term_init): Remove local to avoid shadowing.
92bb796d 9346
764430a3 9347 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9348
9349 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9350 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9351
d1dfb56c
EZ
93522011-04-16 Eli Zaretskii <eliz@gnu.org>
9353
c4354cb4
EZ
9354 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9355
d1dfb56c
EZ
9356 Fix regex.c, syntax.c and friends for buffers > 2GB.
9357 * syntax.h (struct gl_state_s): Declare character position members
9358 EMACS_INT.
9359
9360 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9361
04f2d78b
CB
9362 * textprop.c (verify_interval_modification, interval_of):
9363 Declare arguments EMACS_INT.
d1dfb56c
EZ
9364
9365 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9366 EMACS_INT.
9367
9368 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9369
9370 * indent.c (Fvertical_motion): Local variable it_start is now
9371 EMACS_INT.
9372
9373 * regex.c (re_match, re_match_2, re_match_2_internal)
9374 (bcmp_translate, regcomp, regexec, print_double_string)
9375 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9376 (re_compile_pattern, re_exec): Declare arguments and local
9377 variables `size_t' and `ssize_t' and return values `regoff_t', as
9378 appropriate.
9379 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9380 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9381 <compile_stack_type>: `size' and `avail' are now `size_t'.
9382
9383 * regex.h <regoff_t>: Use ssize_t, not int.
9384 (re_search, re_search_2, re_match, re_match_2): Arguments that
9385 specify buffer/string position and length are now ssize_t and
9386 size_t. Return type is regoff_t.
9387
613052cd
BK
93882011-04-16 Ben Key <bkey76@gmail.com>
9389
9390 * nsfont.m: Fixed bugs in ns_get_family and
9391 ns_descriptor_to_entity that were caused by using free to
9392 deallocate memory blocks that were allocated by xmalloc (via
9393 xstrdup). This caused Emacs to crash when compiled with
9394 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9395 --enable-checking=xmallocoverrun). xfree is now used to
9396 deallocate these memory blocks.
9397
4170f62f 93982011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9399
71b41406
PE
9400 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9401
9587a89d
PE
9402 emacs_write: Accept and return EMACS_INT for sizes.
9403 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9404 et seq.
9405 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9406 Accept and return EMACS_INT.
9407 (emacs_gnutls_write): Return the number of bytes written on
9408 partial writes.
9409 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9410 (emacs_read, emacs_write): Remove check for negative size, as the
9411 Emacs source code has been audited now.
9587a89d
PE
9412 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9413 (emacs_read, emacs_write): Use it.
273a5f82
PE
9414 * process.c (send_process): Adjust to the new signatures of
9415 emacs_write and emacs_gnutls_write. Do not attempt to store
9416 a byte offset into an 'int'; it might overflow.
9587a89d 9417 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9418
3e047f51
PE
9419 * sound.c: Don't assume sizes fit in 'int'.
9420 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9421 Return EMACS_INT, not int.
3e047f51 9422 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9423 Accept EMACS_INT, not int.
9424 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9425 record read return values.
9426
cc39a9db
BK
94272011-04-15 Ben Key <bkey76@gmail.com>
9428
c9d0ec6d
JB
9429 * keyboard.c (Qundefined): Don't declare static since it is used
9430 in nsfns.m.
9431 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9432 static since they are used in nsfont.m.
cc39a9db 9433
6c60eb9f
SM
94342011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9435
9436 * process.c (Qprocessp): Don't declare static.
9437 * lisp.h (Qprocessp): Declare again.
9438
7990b61a
JB
94392011-04-15 Juanma Barranquero <lekktu@gmail.com>
9440
9441 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9442
5d4cb038
PE
94432011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9444
8bd7b830 9445 Improve C-level modularity by making more things 'static'.
cd64ea1d 9446
e3b27b31
PE
9447 Don't publish debugger-only interfaces to other modules.
9448 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9449 (verify_bytepos, count_markers): Move decls to the only modules
9450 that need them.
9451 * region-cache.h (pp_cache): Likewise.
9452 * window.h (check_all_windows): Likewise.
9453 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9454
5d4cb038
PE
9455 * sysdep.c (croak): Now static, if
9456 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9457 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9458
9459 * alloc.c (refill_memory_reserve): Now static if
9460 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9461 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9462
e87b6180
PE
9463 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9464 Define only if USE_LUCID.
9465
ac64929e
PE
9466 * xrdb.c (x_customization_string, x_rm_string): Now static.
9467
6f37259d
PE
9468 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9469 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9470
1683e3ab
PE
9471 * xdisp.c (draw_row_with_mouse_face): Now static.
9472 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9473
de9c2632
PE
9474 * window.h (check_all_windows): Mark externally visible.
9475
2b96acb7
PE
9476 * window.c (window_deletion_count): Now static.
9477
9478 * undo.c: Make symbols static if they're not exported.
9479 (last_undo_buffer, last_boundary_position, pending_boundary):
9480 Now static.
9481
50436f33
PE
9482 * textprop.c (interval_insert_behind_hooks): Now static.
9483 (interval_insert_in_front_hooks): Likewise.
9484
64520e5c
PE
9485 * term.c: Make symbols static if they're not exported.
9486 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9487 (max_frame_lines, tty_set_terminal_modes):
9488 (tty_reset_terminal_modes, tty_turn_off_highlight):
9489 (get_tty_terminal): Now static.
9490 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9491 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9492 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9493 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9494 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9495
1fa53021
PE
9496 * sysdep.c: Make symbols static if they're not exported.
9497 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9498 Now static.
9499 (sigprocmask_set, full_mask): Remove; unused.
9500 (wait_debugging): Mark as visible.
9501 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9502 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9503
d4b43b22
PE
9504 * syntax.c (syntax_temp): Define only if !__GNUC__.
9505
b7c513d0
PE
9506 * sound.c (current_sound_device, current_sound): Now static.
9507
989b29ad
PE
9508 * search.c (searchbufs, searchbuf_head): Now static.
9509
13a55a78
PE
9510 * scroll.c (scroll_cost): Remove; unused.
9511 * dispextern.h (scroll_cost): Remove decl.
9512
de68a1fc
PE
9513 * region-cache.h (pp_cache): Mark as externally visible.
9514
40ccffa6
PE
9515 * process.c: Make symbols static if they're not exported.
9516 (process_tick, update_tick, create_process, chan_process):
9517 (Vprocess_alist, proc_buffered_char, datagram_access):
9518 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9519 (deactivate_process): Mark defn as static, as well as decl.
9520 * lisp.h (create_process): Remove decl.
9521 * process.h (chan_process, Vprocess_alist): Remove decls.
9522
ad64fc97
PE
9523 * print.c: Make symbols static if they're not exported.
9524 (print_depth, new_backquote_output, being_printed, print_buffer):
9525 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9526 (print_interval, print_number_index, initial_stderr_stream):
9527 Now static.
9528 * lisp.h (Fprinc): Remove decl.
9529 (debug_output_compilation_hack): Mark as externally visible.
9530
adddb265
PE
9531 * sysdep.c (croak): Move decl from here to syssignal.h.
9532 * syssignal.h (croak): Put it here, so the API can be checked when
9533 'croak' is called from dissociate_if_controlling_tty.
9534
1717ede2
PE
9535 * minibuf.c: Make symbols static if they're not exported.
9536 (minibuf_save_list, choose_minibuf_frame): Now static.
9537 * lisp.h (choose_minibuf_frame): Remove decl.
9538
fa5fb2bc
PE
9539 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9540
1e3890d1
PE
9541 * lread.c: Make symbols static if they're not exported.
9542 (read_objects, initial_obarray, oblookup_last_bucket_number):
9543 Now static.
9544 (make_symbol): Remove; unused.
9545 * lisp.h (initial_obarray, make_symbol): Remove decls.
9546
8a1414fa
PE
9547 * keyboard.c: Make symbols static if they're not exported.
9548 (single_kboard, recent_keys_index, total_keys, recent_keys):
9549 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9550 (this_single_command_key_start, echoing, last_auto_save):
9551 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9552 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9553 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9554 (Vlispy_mouse_stem, double_click_count):
9555 Now static.
9556 (force_auto_save_soon): Define only if SIGDANGER.
9557 (ignore_mouse_drag_p): Now static if
9558 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9559 (print_help): Remove; unused.
9560 (stop_character, last_timer_event): Mark as externally visible.
9561 * keyboard.h (ignore_mouse_drag_p): Declare only if
9562 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9563 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9564 * lisp.h (echoing): Remove decl.
9565 (force_auto_save_soon): Declare only if SIGDANGER.
9566 * xdisp.c (redisplay_window): Simplify code, to make it more
9567 obvious that ignore_mouse_drag_p is not accessed if !defined
9568 USE_GTK && !defined HAVE_NS.
9569
93ea6e8f
PE
9570 * intervals.c: Make symbols static if they're not exported.
9571 (merge_properties_sticky, merge_interval_right, delete_interval):
9572 Now static.
9573 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9574
77382fcc
PE
9575 * insdel.c: Make symbols static if they're not exported.
9576 However, leave prepare_to_modify_buffer alone. It's never
9577 called from outside this function, but that appears to be a bug.
9578 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9579 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9580 (adjust_after_replace_noundo): Remove; unused.
9581 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9582 (signal_before_change): Remove decls.
77382fcc 9583
9306c32e
PE
9584 * indent.c (val_compute_motion, val_vmotion): Now static.
9585
cd44d2eb
PE
9586 * image.c: Make symbols static if they're not exported.
9587 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9588 if USE_GTK.
9589 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9590 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9591
ad9a7a06
PE
9592 * fringe.c (standard_bitmaps): Now static.
9593 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9594
81626931
PE
9595 * frame.c: Make symbols static if they're not exported.
9596 (x_report_frame_params, make_terminal_frame): Now static.
9597 (get_frame_param): Now static, unless HAVE_NS.
9598 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9599 (x_get_resource_string): Remove; not used.
9600 * frame.h (make_terminal_frame, x_report_frame_params):
9601 (x_get_resource_string); Remove decls.
9602 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9603 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9604
239f9db9
PE
9605 * font.c, fontset.c: Make symbols static if they're not exported.
9606 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9607 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9608 * font.c (font_close_object): Now static.
9609 * font.h (font_close_object): Remove.
9610 * fontset.c (FONTSET_OBJLIST): Remove.
9611 (free_realized_fontset) #if-0 the body, which does nothing.
9612 (face_suitable_for_char_p): #if-0, as it's never called.
9613 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9614 * xfaces.c (face_at_string_position):
9615 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9616 since 0 is always ASCII.
9617
dfcf3579
PE
9618 * fns.c (weak_hash_tables): Now static.
9619
5045092b
PE
9620 * fileio.c: Make symbols static if they're not exported.
9621 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9622 (Vwrite_region_annotation_buffers): Now static.
9623
57a96f5c
PE
9624 * eval.c: Make symbols static if they're not exported.
9625 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9626 * lisp.h (backtrace_list): Remove decl.
9627
35f08c38
PE
9628 * emacs.c: Make symbols static if they're not exported.
9629 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9630 (fatal_error_code, fatal_error_signal_hook, standard_args):
9631 Now static.
9632 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9633 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9634 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9635 * lisp.h (fatal_error_signal_hook): Remove decl.
9636 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9637
f44bd759
PE
9638 * editfns.c: Move a (normally-unused) function to its only use.
9639 * editfns.c, lisp.h (get_operating_system_release): Remove.
9640 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9641 worth the hassle of breaking this out.
9642
b532497d
PE
9643 * xterm.c: Make symbols static if they're not exported.
9644 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9645 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9646 (x_destroy_window, x_delete_display):
9647 Now static.
9648 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9649 (x_mouse_leave): Remove; unused.
9650 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9651 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9652 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9653 Remove decls.
9654 (x_mouse_leave): Declare only if WINDOWSNT.
9655 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9656 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9657 USE_X_TOOLKIT.
9658
1675728f
PE
9659 * ftxfont.c: Make symbols static if they're not exported.
9660 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9661 HAVE_FREETYPE.
9662 * font.h (ftxfont_driver): Likewise.
9663
e4cebfca
PE
9664 * xfns.c: Make symbols static if they're not exported.
9665 (x_last_font_name, x_display_info_for_name):
9666 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9667 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9668 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9669 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9670 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9671 (last_show_tip_args): Now static.
9672 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9673 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9674 (x_screen_planes): Remove; unused.
9675 * dispextern.h (x_screen_planes): Remove decl.
9676
5bf46f05
PE
9677 * dispnew.c: Make symbols static if they're not exported.
9678 * dispextern.h (redraw_garbaged_frames, scrolling):
9679 (increment_row_positions): Remove.
9680 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9681 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9682 Now static.
9683 (redraw_garbaged_frames): Remove; unused.
9684
435f4c28
PE
9685 * xfaces.c: Make symbols static if they're not exported.
9686 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9687 Remove decls.
9688 * xterm.h (defined_color): Remove decls.
9689 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9690 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9691 (menu_face_changed_default, defined_color, free_realized_face):
9692 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9693 (ascii_face_of_lisp_face): Remove; unused.
9694
8524aef3
PE
9695 * xdisp.c: Make symbols static if they're not exported.
9696 * dispextern.h (scratch_glyph_row, window_box_edges):
9697 (glyph_to_pixel_coords, set_cursor_from_row):
9698 (get_next_display_element, set_iterator_to_next):
9699 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9700 (show_mouse_face): Remove decls
9701 * frame.h (message_buf_print): Likewise.
9702 * lisp.h (pop_message, set_message, check_point_in_composition):
9703 Likewise.
9704 * xterm.h (set_vertical_scroll_bar): Likewise.
9705 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9706 (message_buf_print, scratch_glyph_row, displayed_buffer):
9707 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9708 (get_next_display_element, show_mouse_face, window_box_edges):
9709 (frame_to_window_pixel_xy, check_point_in_composition):
9710 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9711 (glyph_to_pixel_coords): Remove; unused.
9712
16390cd2
PE
9713 * dired.c (file_name_completion): Now static.
9714
9715 * dbusbind.c (xd_in_read_queued_messages): Now static.
9716
a25f4dfa
PE
9717 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9718 * data.c (circular_list_error): Remove.
9719
14a9c8df
PE
9720 * commands.h (last_point_position, last_point_position_buffer):
9721 (last_point_position_window): Remove decls.
9722 * keyboard.c: Make these variables static.
9723
04f2d78b
CB
9724 * coding.h (coding, code_convert_region, encode_coding_gap):
9725 Remove decls.
74ab6df5
PE
9726 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9727 (iso_code_class, detect_coding, code_convert_region): Now static.
9728 (encode_coding_gap): Remove; unused.
9729
38dfbee1
PE
9730 * chartab.c (chartab_chars, chartab_bits): Now static.
9731
a2cb4e63
PE
9732 * charset.h (charset_iso_8859_1): Remove decl.
9733 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9734 Now static.
9735
127198fd
PE
9736 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9737 * ccl.c (Vccl_program_table): Now static.
9738 (check_ccl_update): Remove; unused.
9739
d85b608f
PE
9740 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9741 * category.h: ... from here.
9742 * category.c (check_category_table, set_category_set): Now static.
9743
31cd66f3
PE
9744 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9745 * lisp.h: Remove these decls.
9746
c358e587
PE
9747 * buffer.c (buffer_count): Remove unused var.
9748
e78aecca
PE
9749 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9750 so that it's not optimized away.
9751 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9752 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9753 exported only to the debugger.
9754
e192d7d3 9755 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9756 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9757
92470028
PE
9758 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9759 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9760 was inaccessible from Lisp.
9761 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9762 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9763
244ed907
PE
9764 alloc.c: Import and export fewer symbols, and remove unused items.
9765 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9766 is defined.
9767 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9768 it's not optimized away by whole-program optimization.
9769 (message_enable_multibyte, free_misc): Remove.
9770 (catchlist, handlerlist, mark_backtrace):
9771 Declare only if BYTE_MARK_STACK.
9772 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9773 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9774 (message_enable_multibyte): Remove decl.
9775 (free_misc, interval_free_list, float_block, float_block_index):
9776 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9777 (cons_free_list, last_marked_index):
9778 Now static.
9779 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9780 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9781 (mark_backtrace): Define only if BYTE_MARK_STACK.
9782 * xdisp.c (message_enable_multibyte): Now static.
9783
61c2b50e 9784 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9785 This makes it easier for human readers (and static analyzers)
9786 to see whether these variables are used from other modules.
9787 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9788 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9789 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9790 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9791 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9792 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9793 * xmenu.c, xselect.c:
9794 Declare Q* vars static if they are not used in other modules.
9795 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9796 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9797 Remove decls of unexported vars.
9798 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9799
95c82688
PE
9800 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9801
16a97296
PE
9802 Make Emacs functions such as Fatom 'static' by default.
9803 This makes it easier for human readers (and static analyzers)
9804 to see whether these functions can be called from other modules.
9805 DEFUN now defines a static function. To make the function external
9806 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9807 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9808 (Finit_image_library):
16a97296
PE
9809 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9810 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9811 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9812 Remove decls, since these functions are now static.
9813 (Funintern, Fget_internal_run_time): New decls, since these functions
9814 were already external.
95c82688 9815
16a97296
PE
9816 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9817 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9818 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9819 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9820 * keyboard.c, keymap.c, lread.c:
9821 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9822 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9823 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9824 Mark functions with DEFUE instead of DEFUN,
9825 if they are used in other modules.
9826 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9827 decls for now-static functions.
9828 * buffer.h (Fdelete_overlay): Remove decl.
9829 * callproc.c (Fgetenv_internal): Mark as internal.
9830 * composite.c (Fremove_list_of_text_properties): Remove decl.
9831 (Fcomposition_get_gstring): New forward static decl.
9832 * composite.h (Fcomposite_get_gstring): Remove decl.
9833 * dired.c (Ffile_attributes): New forward static decl.
9834 * doc.c (Fdocumntation_property): New forward static decl.
9835 * eval.c (Ffetch_bytecode): New forward static decl.
9836 (Funintern): Remove extern decl; now in .h file where it belongs.
9837 * fileio.c (Fmake_symbolic_link): New forward static decl.
9838 * image.c (Finit_image_library): New forward static decl.
9839 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9840 * intervals.h (Fprevious_property_change):
9841 (Fremove_list_of_text_properties): Remove decls.
9842 * keyboard.c (Fthis_command_keys): Remove decl.
9843 (Fcommand_execute): New forward static decl.
9844 * keymap.c (Flookup_key): New forward static decl.
9845 (Fcopy_keymap): Now static.
9846 * keymap.h (Flookup_key): Remove decl.
9847 * process.c (Fget_process): New forward static decl.
9848 (Fprocess_datagram_address): Mark as internal.
9849 * syntax.c (Fsyntax_table_p): New forward static decl.
9850 (skip_chars): Remove duplicate decl.
9851 * textprop.c (Fprevious_property_change): New forward static decl.
9852 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9853 Now internal.
9854 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9855 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9856
785bbd42
PE
9857 * editfns.c (Fformat): Remove unreachable code.
9858
8b913b57
AS
98592011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9860
9861 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9862 change. (Bug#8496)
9863
a6744a35
EZ
98642011-04-13 Eli Zaretskii <eliz@gnu.org>
9865
9866 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9867 when at ZV. (Bug#8487)
9868
e7974947
AS
98692011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9870
baad03f0
AS
9871 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9872 (Bug#8437)
9873 * keyboard.c (parse_tool_bar_item): Likewise.
9874 * sound.c (sound_cleanup, alsa_close): Likewise.
9875 * termcap.c (tgetent): Likewise.
9876 * xfns.c (x_default_font_parameter): Likewise.
9877 * xsettings.c (read_and_apply_settings): Likewise.
9878
e7974947
AS
9879 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9880 (overrun_check_free): Protoize.
9881
28272684
PE
98822011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9883
9884 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9885 since callers should never pass a negative size.
9886 Change the signature to match that of plain 'read' and 'write'; see
9887 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9888 * lisp.h: Update prototypes of emacs_write and emacs_read.
9889
11997c76
EZ
98902011-04-11 Eli Zaretskii <eliz@gnu.org>
9891
9892 * xdisp.c (redisplay_window): Don't try to determine the character
9893 position of the scroll margin if the window start point w->startp
e896f03c 9894 is outside the buffer's accessible region. (Bug#8468)
11997c76 9895
8a2cbd72
EZ
98962011-04-10 Eli Zaretskii <eliz@gnu.org>
9897
9898 Fix write-region and its subroutines for buffers > 2GB.
9899 * fileio.c (a_write, e_write): Modify declaration of arguments and
9900 local variables to support buffers larger than 2GB.
9901 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9902
9903 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9904 argument, local variables, and return value.
9905
9906 * lisp.h: Update prototypes of emacs_write and emacs_read.
9907
9908 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9909
4073e537 99102011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9911
1ebfdcb6
PE
9912 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9913
b2ded58d
PE
9914 Fix more problems found by GCC 4.6.0's static checks.
9915
7d66342c
PE
9916 * xdisp.c (vmessage): Use a better test for character truncation.
9917
bbf47d44
PE
9918 * charset.c (load_charset_map): <, not <=, for optimization,
9919 and to avoid potential problems with integer overflow.
9248994d 9920 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9921 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9922 * editfns.c (Fformat): Likewise.
1e69125e 9923 * syntax.c (skip_chars): Likewise.
3befa583 9924
e3019616
PE
9925 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9926 This also lets GCC 4.6.0 generate slightly better loop code.
9927
becfa255
PE
9928 * callint.c (Fcall_interactively): <, not <=, for optimization.
9929 (Fcall_interactively): Count the number of arguments produced,
9930 not the number of arguments given. This is simpler and lets GCC
9931 4.6.0 generate slightly better code.
9932
dae0cd48
PE
9933 * ftfont.c: Distingish more carefully between FcChar8 and char.
9934 The previous code passed unsigned char * to a functions like
9935 strlen and xstrcasecmp that expect char *, which does not
9936 conform to the C standard.
9937 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9938 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9939 char * when the C standard requires it.
9940
76032d70
PE
9941 * keyboard.c (read_char): Remove unused var.
9942
eb3f1cc8
PE
9943 * eval.c: Port to Windows vsnprintf (Bug#8435).
9944 Include <limits.h>.
9945 (SIZE_MAX): Define if the headers do not.
9946 (verror): Do not give up if vsnprintf returns a negative count.
9947 Instead, grow the buffer. This ports to Windows vsnprintf, which
9948 does not conform to C99. Problem reported by Eli Zaretskii.
9949 Also, simplify the allocation scheme, by avoiding the need for
9950 calling realloc, and removing the ALLOCATED variable.
9951
70476b54
PE
9952 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9953
12020a9e
PE
9954 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9955 But keep the doprint source code for now, as we might revamp it
9956 and use it again (Bug#8435).
ea6c7ae6
PE
9957 * lisp.h (doprnt): Remove.
9958 * Makefile.in (base_obj): Remove doprnt.o.
9959 * deps.mk (doprnt.o): Remove.
9960
5fdb398c
PE
9961 error: Print 32- and 64-bit integers portably (Bug#8435).
9962 Without this change, on typical 64-bit hosts error ("...%d...", N)
9963 was used to print both 32- and 64-bit integers N, which relied on
9964 undefined behavior.
61bdb816 9965 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9966 * lisp.h (error, verror): Mark as printf-like functions.
9967 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9968 Report overflow in size calculations when allocating printf buffer.
9969 Do not truncate output string at its first null byte.
9970 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9971 Truncate the output at a character boundary, since vsnprintf does not
9972 do that.
9973 * charset.c (check_iso_charset_parameter): Convert internal
9974 character to string before calling 'error', since %c now has the
9975 printf meaning.
9976 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9977 overflow when computing char to be passed to 'error'. Do not
9978 pass Lisp_Object to 'error'; pass the integer instead.
9979 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9980 formatted with plain %d.
9981
b189fa66
PE
9982 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9983
bff87ef0
PE
9984 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9985
7e2cac20
PE
9986 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9987
ce4d90b5
PE
9988 * xterm.c (x_catch_errors): Remove duplicate declaration.
9989
266c9547
PE
9990 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9991
79c49ad2
PE
9992 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9993
368f4090
JM
99942011-04-10 Jim Meyering <meyering@redhat.com>
9995
9996 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9997 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9998 return ssize_t not "int", and use size_t as the buffer length.
9999 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10000 * gnutls.h: Update declarations.
10001 * process.c (read_process_output): Use ssize_t, to match.
10002 (send_process): Likewise.
10003
a32d4040
CY
100042011-04-09 Chong Yidong <cyd@stupidchicken.com>
10005
10006 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10007
8546720e 100082011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10009
04f2d78b
CB
10010 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10011 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10012
8546720e
GM
10013 * xterm.c (handle_one_xevent):
10014 * xmenu.c (create_and_show_popup_menu):
10015 * xselect.c (x_decline_selection_request)
10016 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10017
0a2f5c1a 100182011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10019
10020 Fix some uses of `int' instead of EMACS_INT.
10021 * search.c (string_match_1, fast_string_match)
10022 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10023 (scan_buffer, find_next_newline_no_quit)
10024 (find_before_next_newline, search_command, Freplace_match)
10025 (Fmatch_data): Make some `int' variables be EMACS_INT.
10026
10027 * xdisp.c (display_count_lines): 3rd argument and return value now
10028 EMACS_INT. All callers changed.
10029 (pint2hrstr): Last argument is now EMACS_INT.
10030
10031 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10032 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10033 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10034 (decode_coding_utf_16, decode_coding_emacs_mule)
10035 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10036 (decode_coding_ccl, decode_coding_charset)
10037 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10038 (decode_coding_iso_2022, decode_coding_emacs_mule)
10039 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10040 <char_offset, last_offset>: Declare EMACS_INT.
10041 (encode_coding_utf_8, encode_coding_utf_16)
10042 (encode_coding_emacs_mule, encode_invocation_designation)
10043 (encode_designation_at_bol, encode_coding_iso_2022)
10044 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10045 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10046 Declare EMACS_INT.
10047 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10048 (encode_invocation_designation): Last argument P_NCHARS is now
10049 EMACS_INT.
10050 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10051 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10052
10053 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10054 All users changed.
10055
10056 * ccl.c (Fccl_execute_on_string): Declare some variables
10057 EMACS_INT.
10058
8546720e 100592011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10060
10061 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10062
4e19a977
CS
100632011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10064
10065 * process.c (Fformat_network_address): Doc fix.
10066
87302331
R
100672011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10068
ee7683eb 10069 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10070
cbb59342
CY
100712011-04-08 Chong Yidong <cyd@stupidchicken.com>
10072
10073 * keyboard.c (read_char): Call Lisp function help-form-show,
10074 instead of using internal_with_output_to_temp_buffer.
10075 (Qhelp_form_show): New var.
e0d38eeb 10076 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10077
10078 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10079
10080 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10081
e67a13ab
CY
100822011-04-06 Chong Yidong <cyd@stupidchicken.com>
10083
04f2d78b
CB
10084 * process.c (Flist_processes): Remove to Lisp.
10085 (list_processes_1): Delete.
e67a13ab 10086
973f782d
EZ
100872011-04-06 Eli Zaretskii <eliz@gnu.org>
10088
7c106b1e
EZ
10089 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10090
973f782d
EZ
10091 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10092
41cf7d1a 100932011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10094
ca23cc88
PE
10095 Fix more problems found by GCC 4.6.0's static checks.
10096
f390e2d5
PE
10097 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10098
42eea0d0
PE
10099 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10100
b69769da 10101 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10102
f9541e84
PE
10103 * xdisp.c (vmessage): Mark as a printf-like function.
10104
13841b55
PE
10105 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10106
c136c10f
PE
10107 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10108
5e2d4a30
PE
10109 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10110 printf-like functions.
10111 (tiff_load): Add casts to remove these marks before passing them
10112 to system-supplied API.
10113
583f48b9
PE
10114 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10115
b25d760e
PE
10116 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10117 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10118 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10119 directly, rather than having caller test rule sign. This avoids
10120 some unnecessary tests.
10121 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10122 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10123 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10124
bc7b6697 10125 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10126 (xfont_open): Avoid unnecessary tests.
bc7b6697 10127
27ccc379
PE
10128 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10129
dcd5c89a
PE
10130 * composite.h, composite.c (composition_gstring_put_cache):
10131 Use EMACS_INT, not int, for length.
10132
b13a45c6
PE
10133 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10134 breaking out part of COMPOSITION_DECODE_RULE.
10135 (COMPOSITION_DECODE_RULE): Use it.
10136 * composite.c (get_composition_id): Remove unused local vars,
10137 by using the new macro.
10138
1e792e4d
PE
10139 * textprop.c (set_text_properties_1): Change while to do-while,
10140 since the condition is always true at first.
10141
dc6c6455 10142 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10143 (interval_deletion_adjustment): Return unsigned value.
10144 All uses changed.
dc6c6455 10145
aba7731a
PE
10146 * process.c (list_processes_1, create_pty, read_process_output):
10147 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10148 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10149 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10150 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10151 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10152
fdfc4bf3
PE
10153 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10154
fca8fe46 10155 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10156 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10157
06a0259a 10158 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10159 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10160 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10161
e7b9e80f
PE
10162 * print.c (print_error_message): Avoid int overflow.
10163
56201685
PE
10164 * font.c (font_list_entities): Redo for clarity,
10165 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10166
78834453 10167 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10168 (font_score): Avoid potential overflow in diff calculation.
78834453 10169
0bc0b309 10170 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10171 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10172
e610eaca
PE
10173 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10174
b895abce
PE
10175 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10176 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10177 can always succeed if overflow has undefined behavior.
10178
1f1d9321 10179 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10180 (wordify): Omit three unnecessary tests.
1f1d9321 10181
c59478bc
PE
10182 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10183 All callers changed. This avoids the need for an unused var.
10184
79b73827
PE
10185 * casefiddle.c (casify_region): Remove var that is set but not used.
10186
a4db5dfe
PE
10187 * dired.c (file_name_completion): Remove var that is set but not used.
10188
43aae36e
PE
10189 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10190
2a47c44d 10191 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10192 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10193
a37c69bf
PE
10194 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10195 Check for integer overflow on size calculations.
10196
328ab8e7
PE
10197 * buffer.c (Fprevious_overlay_change): Remove var that is set
10198 but not used.
10199
e5a2a5cb
PE
10200 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10201 Remove vars that are set but not used.
8d84a6eb 10202 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10203 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10204
a60e5f68
PE
10205 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10206
f661cb61 10207 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10208 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10209
f0397f5a
PE
10210 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10211 that are set but not used.
10212
8664db06 10213 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10214 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10215
6abdaa4a
PE
10216 * xselect.c (x_get_local_selection, x_handle_property_notify):
10217 Remove vars that are set but not used.
10218
0ce7538d 10219 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10220 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10221
9ae848fc
PE
10222 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10223 Remove var that is set but not used.
0b918413
PE
10224 (scroll_bar_windows_size): Now size_t, not int.
10225 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10226 Check for overflow.
9ae848fc 10227
a5a62657
PE
10228 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10229 (map_tty_color) [!defined MSDOS]: Likewise.
10230
5c5cdd39
PE
10231 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10232
66ebf983
PE
10233 * coding.c: Remove vars that are set but not used.
10234 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10235 All callers changed.
10236 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10237 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10238 (decode_coding_charset): Remove vars that are set but not used.
10239
1be4d761
PE
10240 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10241 that is set but not used.
10242
47553fa8
PE
10243 * print.c (print_object): Remove var that is set but not used.
10244
1f7196bf 10245 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10246 The gnulib version avoids calling malloc in the usual case,
10247 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10248 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10249 * filelock.c (current_lock_owner): Likewise.
10250 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10251 * sysdep.c: Include allocator.h, careadlinkat.h.
10252 (emacs_no_realloc_allocator): New static constant.
10253 (emacs_readlink): New function.
fdb61804
PE
10254 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10255 ../lib/careadlinkat.h.
d1fdcab7 10256
f84c17c7
SM
102572011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10258
10259 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10260 first non-nil return value).
10261
ef3862ad
JD
102622011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10263
10264 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10265 if not defined (Bug#8403).
10266
376a7006
JB
102672011-04-02 Juanma Barranquero <lekktu@gmail.com>
10268
10269 * xdisp.c (display_count_lines): Remove parameter `start',
10270 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10271 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10272 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10273 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10274 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10275 and thereabouts. All callers changed.
10276 (get_per_char_metric): Remove parameter `f', unused since
10277 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10278
6ca3801d
JM
102792011-04-02 Jim Meyering <meyering@redhat.com>
10280
10281 do not dereference NULL upon failed strdup
10282 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10283 (ns_get_family): Likewise.
10284
d8e2b5ba
JB
102852011-04-02 Juanma Barranquero <lekktu@gmail.com>
10286
10287 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10288
8c74fcbd
JD
102892011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10290
10291 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10292 later (Bug#8403).
10293
7200d79c
SM
102942011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10295
03408648 10296 Add lexical binding.
7200d79c 10297
03408648
SM
10298 * window.c (Ftemp_output_buffer_show): New fun.
10299 (Fsave_window_excursion):
10300 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10301
10302 * lread.c (lisp_file_lexically_bound_p): New function.
10303 (Fload): Bind Qlexical_binding.
10304 (readevalloop): Remove `evalfun' arg.
10305 Bind Qinternal_interpreter_environment.
10306 (Feval_buffer): Bind Qlexical_binding.
10307 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10308 Mark as dynamic.
10309 (syms_of_lread): Declare `lexical-binding'.
10310
10311 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10312
10313 * keyboard.c (eval_dyn): New fun.
10314 (menu_item_eval_property): Use it.
ca105506
SM
10315
10316 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10317
03408648
SM
10318 * fns.c (concat, mapcar1): Accept byte-code-functions.
10319
10320 * eval.c (Fsetq): Handle lexical vars.
10321 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10322 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10323 (FletX, Flet): Obey lexical binding.
10324 (Fcommandp): Handle closures.
10325 (Feval): New `lexical' arg.
10326 (eval_sub): New function extracted from Feval. Use it almost
10327 everywhere where Feval was used. Look up vars in lexical env.
10328 Handle closures.
10329 (Ffunctionp): Move from subr.el.
10330 (Ffuncall): Handle closures.
10331 (apply_lambda): Remove `eval_flags'.
10332 (funcall_lambda): Handle closures and new byte-code-functions.
10333 (Fspecial_variable_p): New function.
10334 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10335 but without exporting it to Lisp.
23aba0ea 10336
23aba0ea 10337 * doc.c (Fdocumentation, store_function_docstring):
03408648 10338 * data.c (Finteractive_form): Handle closures.
23aba0ea 10339
03408648
SM
10340 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10341 interactive spec.
ba83908c 10342
04f2d78b
CB
10343 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10344 New byte-codes.
03408648
SM
10345 (exec_byte_code): New function extracted from Fbyte_code to handle new
10346 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10347
03408648 10348 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10349
03408648 10350 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10351
e2abce01
JB
103522011-03-31 Juanma Barranquero <lekktu@gmail.com>
10353
10354 * xdisp.c (redisplay_internal): Fix prototype.
10355
63696a73 103562011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10357
63696a73 10358 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10359 (try_scrolling): Use it when setting scroll_limit.
10360 Limit scrolling to 100 screen lines.
63696a73
EZ
10361 (redisplay_window): Even when falling back on "recentering",
10362 position point in the window according to scroll-conservatively,
10363 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10364
10365 (try_scrolling): When point is above the window, allow searching
10366 as far as scroll_max, or one screenful, to compute vertical
10367 distance from PT to the scroll margin position. This prevents
10368 try_scrolling from unnecessarily failing when
10369 scroll-conservatively is set to a value slightly larger than the
10370 window height. Clean up the case of PT below the margin at bottom
10371 of window: scroll_max can no longer be INT_MAX. When aggressive
10372 scrolling is in use, don't let point enter the opposite scroll
10373 margin as result of the scroll.
10374 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10375 threshold of 100 lines for never-recentering scrolling.
10376
e4cc2dfc
JB
103772011-03-31 Juanma Barranquero <lekktu@gmail.com>
10378
10379 * dispextern.h (move_it_by_lines):
10380 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10381 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10382 (message_log_check_duplicate): Remove parameters `prev_bol' and
10383 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10384 (redisplay_internal): Remove parameter `preserve_echo_area',
10385 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10386
10387 * indent.c (Fvertical_motion):
10388 * window.c (window_scroll_pixel_based, Frecenter):
10389 Don't pass `need_y_p' to `move_it_by_lines'.
10390
1c470562
SM
103912011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10392
44f230aa
SM
10393 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10394 steal a few bits to be more compact.
10395 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10396 Remove unneeded casts.
10397
1c470562
SM
10398 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10399
888adce9
ZK
104002011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10401
10402 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10403 binding" message (bug#7967).
10404
f838ed7b
PE
104052011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10406
77861b95
PE
10407 Fix more problems found by GCC 4.6.0's static checks.
10408
de6dbc14
PE
10409 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10410 Remove unused local var.
10411
f838ed7b
PE
10412 * editfns.c (Fmessage_box): Remove unused local var.
10413
792c7b2b
PE
10414 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10415 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10416 Omit unused local vars.
c499e557 10417 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10418 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10419 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10420 Omit unused local var.
10421
ba0165e1
PE
10422 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10423 Don't assume string length fits in int.
32ad8845 10424 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10425 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10426
3c59b4c9
PE
10427 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10428 instead of alloca (Bug#8344).
10429
a3eed478 10430 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10431 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10432
eb4d412d
PE
10433 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10434
1658b401
PE
10435 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10436 concerns.
10437
10438 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10439
10440 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10441
9a2c6e05
PE
10442 * keyboard.c (syms_of_keyboard): Use the same style as later
10443 in this function when indexing through an array. This also
10444 works around GCC bug 48267.
10445
03d0a109
PE
10446 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10447
44f730c8
PE
10448 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10449
fe75f926
PE
10450 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10451 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10452
ffa8c828
PE
10453 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10454 This avoids undefined behavior on integer overflow, and is a bit
10455 more convenient anyway since it is compared to a size_t variable.
10456
c5101a77
PE
10457 Variadic C functions now count arguments with size_t, not int.
10458 This avoids an unnecessary limitation on 64-bit machines, which
10459 caused (substring ...) to crash on large vectors (Bug#8344).
10460 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10461 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10462 All variadic functions and their callers changed accordingly.
c5101a77
PE
10463 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10464 * data.c (arith_driver, float_arith_driver): Likewise.
10465 * editfns.c (general_insert_function): Likewise.
10466 * eval.c (struct backtrace.nargs, interactive_p)
10467 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10468 (funcall_lambda, mark_backtrace): Likewise.
10469 * fns.c (concat): Likewise.
10470 * frame.c (x_set_frame_parameters): Likewise.
10471 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10472 0 if not found, not -1. All callers changed.
10473
dd3f25f7
PE
10474 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10475 (stack_copy_size): Now size_t, not int.
10476 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10477
461c2ab9
JB
104782011-03-28 Juanma Barranquero <lekktu@gmail.com>
10479
10480 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10481 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10482 All callers changed.
10483
10484 * lisp.h (multibyte_char_to_unibyte):
10485 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10486 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10487 * character.h (CHAR_TO_BYTE8):
10488 * cmds.c (internal_self_insert):
10489 * editfns.c (general_insert_function):
10490 * keymap.c (push_key_description):
10491 * search.c (Freplace_match):
10492 * xdisp.c (message_dolog, set_message_1): All callers changed.
10493
f6d62986
SM
104942011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10495
10496 * keyboard.c (safe_run_hook_funcall): New function.
10497 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10498 don't set the hook to nil, but remove the offending function instead.
10499 (Qcommand_hook_internal): Remove, unused.
10500 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10501 Vcommand_hook_internal.
10502
10503 * eval.c (enum run_hooks_condition): Remove.
10504 (funcall_nil, funcall_not): New functions.
10505 (run_hook_with_args): Call each function through a `funcall' argument.
10506 Remove `cond' argument, now redundant.
10507 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10508 (Frun_hook_with_args_until_failure): Adjust accordingly.
10509 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10510
1db5b1ad
JB
105112011-03-28 Juanma Barranquero <lekktu@gmail.com>
10512
10513 * dispextern.h (string_buffer_position): Remove declaration.
10514
10515 * print.c (strout): Remove parameter `multibyte', unused since
10516 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10517
10518 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10519 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10520 All callers changed.
10521
10522 * w32.c (_wsa_errlist): Use braces for struct initializers.
10523
10524 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10525 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10526 All callers changed.
10527 (string_buffer_position): Likewise. Also, make static (it's never
10528 used outside xdisp.c).
10529 (cursor_row_p): Remove parameter `w', unused since
10530 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10531 (decode_mode_spec): Remove parameter `precision', introduced during
10532 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10533 All callers changed.
10534
5ffb62aa
JD
105352011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10536
10537 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10538
461c2ab9 105392011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10540
10541 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10542 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10543 (ns_update_auto_hide_menu_bar): New functions.
10544 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10545 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10546 ns_constrain_all_frames.
10547 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10548 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10549
5c380ffb
JD
105502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10551
10552 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10553
9af30bdf
GM
105542011-03-27 Glenn Morris <rgm@gnu.org>
10555
10556 * syssignal.h: Replace RETSIGTYPE with void.
10557 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10558 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10559 Replace SIGTYPE with void everywhere.
10560 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10561 * s/template.h (SIGTYPE): Remove commented out definition.
10562
e2abce01
JB
105632011-03-26 Eli Zaretskii <eliz@gnu.org>
10564
10565 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10566 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10567
f868cd8a
JB
105682011-03-26 Juanma Barranquero <lekktu@gmail.com>
10569
59eb0929
JB
10570 * w32.c (read_unc_volume): Use parameter `henum', instead of
10571 global variable `wget_enum_handle'.
10572
10573 * keymap.c (describe_vector): Remove parameters `indices' and
10574 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10575 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10576
f868cd8a
JB
10577 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10578
10579 * keyboard.c (timer_check): Remove parameter `do_it_now',
10580 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10581 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10582 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10583
10584 * keyboard.c (read_char):
10585 * w32menu.c (w32_menu_display_help):
10586 * xmenu.c (show_help_event, menu_help_callback):
10587 Adjust calls to `show_help_echo'.
10588
10589 * gtkutil.c (xg_maybe_add_timer):
10590 * keyboard.c (readable_events):
10591 * process.c (wait_reading_process_output):
10592 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10593
10594 * insdel.c (adjust_markers_gap_motion):
10595 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10596 (gap_left, gap_right): Don't call it.
10597
2ecf6fdb
CY
105982011-03-25 Chong Yidong <cyd@stupidchicken.com>
10599
10600 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10601 incurred during fontification.
10602
6b1f9ba4
JB
106032011-03-25 Juanma Barranquero <lekktu@gmail.com>
10604
10605 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10606 (DEFVAR_PER_BUFFER): Don't pass it.
10607
10608 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10609 (scrolling_window): Don't pass it.
10610
0f4a96b5
JB
106112011-03-25 Juanma Barranquero <lekktu@gmail.com>
10612
10613 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10614
10615 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10616 and `suffix'.
10617 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10618 of variables specific to SELinux and computation of `encoded_absname'.
10619
10620 * image.c (XPutPixel): Remove unused variable `height'.
10621
10622 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10623
10624 * unexw32.c (get_section_info): Remove unused variable `section'.
10625
10626 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10627 (system_process_attributes): Remove unused variable `sess'.
10628 (sys_read): Remove unused variable `err'.
10629
10630 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10631 (w32_wnd_proc): Remove unused variable `isdead'.
10632 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10633 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10634 (x_create_tip_frame): Remove unused variable `tem'.
10635
10636 * w32inevt.c (w32_console_read_socket):
10637 Remove unused variable `no_events'.
10638
10639 * w32term.c (x_draw_composite_glyph_string_foreground):
10640 Remove unused variable `width'.
10641
1149507c
JB
106422011-03-24 Juanma Barranquero <lekktu@gmail.com>
10643
10644 * w32term.c (x_set_glyph_string_clipping):
10645 Don't pass uninitialized region to CombineRgn.
10646
9c88f339
JB
106472011-03-23 Juanma Barranquero <lekktu@gmail.com>
10648
10649 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10650 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10651 (Fx_close_connection): Remove unused variable `i'.
10652
10653 * w32font.c (w32font_draw): Return number of glyphs.
10654 (w32font_open_internal): Remove unused variable `i'.
10655 (w32font_driver): Add missing initializer.
10656
10657 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10658 (fill_in_menu): Remove unused variable `items_added'.
10659
10660 * w32term.c (last_mouse_press_frame): Remove static global variable.
10661 (w32_clip_to_row): Remove unused variable `f'.
10662 (x_delete_terminal): Remove unused variable `i'.
10663
10664 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10665 (NOTHING): Remove unused static global variable.
10666 (uniscribe_check_otf): Remove unused variable `table'.
10667 (uniscribe_font_driver): Add missing initializers.
10668
dee091a3
JD
106692011-03-23 Julien Danjou <julien@danjou.info>
10670
10671 * term.c (Fsuspend_tty, Fresume_tty):
10672 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10673 * window.c (temp_output_buffer_show):
10674 * insdel.c (signal_before_change):
10675 * frame.c (Fhandle_switch_frame):
10676 * fileio.c (Fdo_auto_save):
10677 * emacs.c (Fkill_emacs):
10678 * editfns.c (save_excursion_restore):
10679 * cmds.c (internal_self_insert):
10680 * callint.c (Fcall_interactively):
10681 * buffer.c (Fkill_all_local_variables):
10682 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10683 Use Frun_hooks.
0f4a96b5 10684 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10685 unconditionally since it does the check itself.
dee091a3 10686
2c520ab5 106872011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10688
c9c49752
PE
10689 Fix more problems found by GCC 4.5.2's static checks.
10690
8abc3f12
PE
10691 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10692 the first time through the loop, since we know p0 < p1 then.
10693 This also avoids a gcc -Wstrict-overflow warning.
10694
a2d26660
PE
10695 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10696 leading to a memory leak, possible in functions like
10697 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10698 of objects (Bug#8318).
a2d26660 10699
916c72e9
PE
10700 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10701 that could (at least in theory) be that large.
10702
19ab8a18
PE
10703 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10704 This is less likely to overflow, and avoids undefined behavior if
10705 overflow does occur. All callers changed. Use strtoul to scan
10706 for the unsigned long integer.
b7cbbd6f
PE
10707 (pint2hrstr): Simplify and tune code slightly.
10708 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10709
f0641eff
PE
10710 * scroll.c (do_scrolling): Work around GCC bug 48228.
10711 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10712
7f650bb9
PE
10713 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10714 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10715 (validate_x_resource_name): Simplify count usage.
10716 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10717
37dd57d1
PE
10718 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10719 fail (Bug#8306).
81e56e61 10720
699979fc 10721 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10722
401bf9b4
PE
10723 * process.c (Fmake_network_process): Use socklen_t, not int,
10724 where POSIX says socklen_t is required in portable programs.
10725 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10726 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10727 (Fmake_network_process, server_accept_connection):
10728 (wait_reading_process_output, read_process_output):
10729 Likewise.
10730
b93aacde
PE
10731 * process.c: Rename or move locals to avoid shadowing.
10732 (list_processes_1, Fmake_network_process):
10733 (read_process_output_error_handler, exec_sentinel_error_handler):
10734 Rename or move locals.
4dc343ee 10735 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10736 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10737 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10738 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10739 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10740
af8a867c 10741 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10742 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10743 Include tparam.h instead, since it declares them.
af8a867c
PE
10744 * cm.h (PC): Remove extern decl; tparam.h now does this.
10745 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10746 * terminfo.c: Include tparam.h, to check interfaces.
10747 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10748 (tparam): Adjust signature to match interface in tparam.h;
10749 this removes some undefined behavior. Check that outstring and len
10750 are zero, which they always are with Emacs.
10751 * tparam.h (PC, BC, UP): New extern decls.
10752
0248044d 10753 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10754 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10755
8ff096c1 10756 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10757 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10758 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10759 (ftfont_list): Remove unused local.
49eaafba
PE
10760 (get_adstyle_property, ftfont_pattern_entity):
10761 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10762 Rename locals to avoid shadowing.
8ff096c1 10763
e2be39f6
PE
10764 * xfont.c (xfont_list_family): Mark var as initialized.
10765
c9735e30
PE
10766 * xml.c (make_dom): Now static.
10767
8f5201ae
PE
10768 * composite.c (composition_compute_stop_pos): Rename local to
10769 avoid shadowing.
b246f932
PE
10770 (composition_reseat_it): Remove unused locals.
10771 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10772 (composition_update_it): Mark var as initialized.
11b61122
PE
10773 (find_automatic_composition): Mark vars as initialized,
10774 with a FIXME (Bug#8290).
8f5201ae 10775
760fbc2c
PE
10776 character.h: Rename locals to avoid shadowing.
10777 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10778 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10779 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10780 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10781 to avoid shadowing.
10782
ff08eb85
PE
10783 * textprop.c (property_change_between_p): Remove; unused.
10784
fc7bf025
PE
10785 * intervals.c (interval_start_pos): Now static.
10786
235d7abc
PE
10787 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10788
44f230aa
SM
10789 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10790 Rename locals to avoid shadowing.
3e7d6594 10791
50060332
PE
10792 * sound.c (wav_play, au_play, Fplay_sound_internal):
10793 Fix pointer signedness.
d01f234b 10794 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10795 (wav_play): Initialize a variable to 0, to prevent undefined
10796 behavior (Bug#8278).
50060332 10797
c4fc4e30
PE
10798 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10799
918436ed
PE
10800 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10801
c939f91b
PE
10802 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10803 clobbering (Bug#8298).
b9c7f648
PE
10804 * sysdep.c (sys_subshell): Likewise.
10805 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10806
6bd8c144
PE
10807 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10808 This should get cleaned up, so that child_setup has the
10809 same signature on all platforms.
10810
7710357c 10811 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10812 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10813
c59da222
CY
108142011-03-22 Chong Yidong <cyd@stupidchicken.com>
10815
10816 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10817 not to be necessary, and produces flickering.
10818
66b87493
GM
108192011-03-20 Glenn Morris <rgm@gnu.org>
10820
10821 * config.in: Remove file.
10822
45b6f6d5
JB
108232011-03-20 Juanma Barranquero <lekktu@gmail.com>
10824
10825 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10826 are now in src/globals.h.
10827 (syms_of_minibuf): Remove spurious & from previous change.
10828
cd394be1 108292011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10830
10831 * minibuf.c (completing-read-function): New variable.
10832 (completing-read-default): Rename from completing-read.
10833 (completing-read): Call completing-read-function.
10834
b14e3e21
CY
108352011-03-19 Juanma Barranquero <lekktu@gmail.com>
10836
10837 * xfaces.c (Fx_load_color_file):
10838 Read color file from absolute filename (bug#8250).
10839
f2b726e6
JB
108402011-03-19 Juanma Barranquero <lekktu@gmail.com>
10841
10842 * makefile.w32-in: Update dependencies.
10843
09f6ff02
EZ
108442011-03-17 Eli Zaretskii <eliz@gnu.org>
10845
10846 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10847
29a6015a
PE
108482011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10849
a3a6c54e
PE
10850 Fix more problems found by GCC 4.5.2's static checks.
10851
b766f867
PE
10852 * process.c (make_serial_process_unwind, send_process_trap):
10853 (sigchld_handler): Now static.
10854
be02381c
PE
10855 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10856 That way, the code declares only the vars that it needs.
10857 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10858 * s/cygwin.h (PTY_ITERATION): Likewise.
10859 * s/darwin.h (PTY_ITERATION): Likewise.
10860 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10861
57048744
PE
10862 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10863 * process.c (allocate_pty): Don't declare stb unless it's needed.
10864
7914961c 10865 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10866 (CONSTANTLIM): Remove; unused.
10867 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10868 Define only if needed.
7914961c 10869
b3967b18
PE
10870 * unexelf.c (unexec): Name an expression,
10871 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10872 Use a different way to cause a compilation error if anyone uses
10873 n rather than nn, a way that does not involve shadowing.
73366a00 10874 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10875
29a6015a
PE
10876 * deps.mk (unexalpha.o): Remove; unused.
10877
43cfc33e 10878 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10879 * unexec.h: New file.
ce701a33
PE
10880 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10881 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10882 Depend on unexec.h.
10883 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10884 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10885 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10886 Change as necessary to match prototype in unexec.h.
ce701a33 10887
01f44d5a
PE
10888 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10889 shadowing.
4f63c6bb 10890 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10891
a6670b0b
PE
10892 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10893 Rename locals to avoid shadowing.
10894
cef2010d 10895 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10896 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10897
d4d7173a
PE
10898 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10899
f08b802a
PE
10900 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10901 warning when compiling print.c.
10902
3ddb0639
PE
10903 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10904 instead of using an uninitialized var.
5ad03b97 10905 (font_sort_entities): Mark var as initialized.
3ddb0639 10906
170a2692
PE
10907 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10908
e663c700
PE
10909 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10910 pointers to constants.
89bc529a 10911 (font_parse_fcname): Remove unused vars.
7b81e2d0 10912 (font_delete_unmatched): Now static.
ea838e10 10913 (font_get_spec): Remove; unused.
13a547c6
PE
10914 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10915 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10916 Rename or move locals to avoid shadowing.
e663c700 10917
2a80c887 10918 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10919 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10920
1384fa33 10921 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10922 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10923
8b2c52e9
PE
10924 * alloc.c (mark_backtrace): Move decl from here ...
10925 * lisp.h: ... to here, so that it can be checked.
10926
475545b5 10927 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10928 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10929 (lisp_indirect_variable): Name an expression,
10930 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10931 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10932
b1349114 10933 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10934 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10935 Use const pointer when appropriate.
b1349114 10936
a2928364
PE
10937 * lisp.h (get_system_name, get_operating_system_release):
10938 Move decls here, to check interfaces.
10939 * process.c (get_operating_system_release): Move decl to lisp.h.
10940 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10941 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10942 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10943 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10944 (Fformat_time_string, Fencode_time, Finsert_char):
10945 (Ftranslate_region_internal, Fformat):
10946 Rename or remove local vars to avoid shadowing.
9710023e 10947 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10948
a415e694
PE
10949 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10950 avoid shadowing.
10951
8ef4622d
PE
10952 * lisp.h (eassert): Check that the argument compiles, even if
10953 ENABLE_CHECKING is not defined.
10954
946f9a5b
PE
10955 * data.c (Findirect_variable): Name an expression, to avoid
10956 gcc -Wbad-function-cast warning.
112396d6 10957 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10958 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10959 (Fmake_variable_buffer_local, Fmake_local_variable):
10960 Mark variables as initialized.
52746918 10961 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10962
e5aab7e7 10963 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10964 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10965 Rename locals to avoid shadowing.
dff45157
PE
10966 (mark_stack): Move local variables into the #ifdef region where
10967 they're used.
7bc26fdb
PE
10968 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10969 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10970 needed otherwise.
10971 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10972 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10973 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10974
e5aab7e7
PE
10975 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10976 avoids undefined behavior in theory.
10977
4da60324
PE
10978 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10979
88043301
PE
10980 Use functions, not macros, for up- and down-casing (Bug#8254).
10981 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10982 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10983 to use the following functions instead of these macros.
10984 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10985 EMACS_INT, since callers assume the returned value fits in int.
10986 (upcase1): Likewise, for UPCASE_TABLE.
10987 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10988 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10989 the race-condition problem in the old DOWNCASE.
88043301 10990
19ed5445
PE
10991 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10992 Rename locals to avoid shadowing.
10993 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10994 (regex_compile, re_search_2, re_match_2_internal):
10995 Remove unused local vars.
952db0d7
PE
10996 (FREE_VAR): Rewrite so as not to use empty "else",
10997 which gcc can warn about.
da053e48 10998 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10999 (RETALLOC_IF): Define only if needed.
11000 (WORDCHAR_P): Likewise. This one is never needed, but is used
11001 only in a comment talking about a compiler bug, so put inside
11002 the #if 0 of that comment.
11003 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11004 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11005 Remove; unused.
19ed5445 11006
1f3561e4 11007 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11008 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11009 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11010
ded6f8f7
PE
11011 * search.c (simple_search): Remove unused var.
11012
dbd37a95
PE
11013 * dired.c (compile_pattern): Move decl from here ...
11014 * lisp.h: ... to here, so that it can be checked.
11015 (struct re_registers): New forward decl.
11016
7e47afad
PE
11017 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11018
85f24f61
PE
11019 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11020 All uses changed.
11021 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11022 Rename locals to avoid shadowing.
5671df8f 11023 (Fvertical_motion): Mark locals as initialized.
85f24f61 11024
181aa2be 11025 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11026 (casify_region): Mark local as initialized.
181aa2be 11027
930d429c
PE
11028 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11029
7082eac6
PE
11030 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11031 New macros, so that the caller can use some names other than
11032 gcpro1, gcpro2, etc.
11033 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11034 of the new macros.
11035 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11036 argument, for consistency with GCPRO2_VAR, etc: it is now the
11037 prefix of the variable, not the variable itself. All uses
11038 changed.
38b2c076
PE
11039 * dired.c (directory_files_internal, file_name_completion):
11040 Rename locals to avoid shadowing.
11041
15206ed9
PE
11042 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11043 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11044 dired.c's scmp function, had undefined behavior.
11045 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11046 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11047 * buffer.h: ... to here, because these macros use current_buffer,
11048 and the new implementation with inline functions needs to have
11049 current_buffer in scope now, rather than later when the macros
11050 are used.
11051 (downcase, upcase1): New static inline functions.
11052 (DOWNCASE, UPCASE1): Reimplement using these functions.
11053 This avoids undefined behavior in expressions like
11054 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11055 from race conditions in accessing the global variables
11056 case_temp1 and case_temp2.
11057 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11058 * lisp.h (case_temp1, case_temp2): Remove their decls.
11059 * character.h (ASCII_CHAR_P): Move from here ...
11060 * lisp.h: ... to here, so that the inline functions mentioned
11061 above can use them.
11062
4a6bea26
PE
11063 * dired.c (directory_files_internal_unwind): Now static.
11064
f14b7e14
PE
11065 * fileio.c (file_name_as_directory, directory_file_name):
11066 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11067 Now static.
2893f146
PE
11068 (file_name_as_directory): Use const pointers when appropriate.
11069 (Fexpand_file_name): Likewise. In particular, newdir might
11070 point at constant storage, so make it a const pointer.
fd4ead52 11071 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11072 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11073 signedness issues.
f839df0c
PE
11074 (Fset_file_times, Finsert_file_contents, auto_save_error):
11075 Rename locals to avoid shadowing.
f14b7e14 11076
5716756e 11077 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11078 (Ftry_completion, Fall_completions): Rename or remove locals
11079 to avoid shadowing.
5716756e 11080
b4c3046a
PE
11081 * marker.c (bytepos_to_charpos): Remove; unused.
11082
b45db522
PE
11083 * lisp.h (verify_bytepos, count_markers): New decls,
11084 so that gcc does not warn that these functions aren't declared.
11085
85876d07
PE
11086 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11087 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11088 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11089 (copy_text): Remove unused local var.
85876d07 11090
03d78a21 11091 * filelock.c (within_one_second): Now static.
b3dd38ab 11092 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11093
5df8f01b
PE
11094 * buffer.c (fix_overlays_before): Mark locals as initialized.
11095 (fix_start_end_in_overlays): Likewise. This function should be
11096 simplified by using pointers-to-pointers, but that's a different
11097 matter.
b1d876f1 11098 (switch_to_buffer_1): Now static.
8f54f30a
PE
11099 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11100 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11101
a70072c9 11102 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11103 Fix pointer signedness issue.
edced198
PE
11104 (sys_subshell): Mark local as volatile if checking for lint,
11105 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11106 (MAXPATHLEN): Define only if needed.
a70072c9 11107
a0977c44
PE
11108 * process.c (serial_open, serial_configure): Move decls from here ...
11109 * systty.h: ... to here, so that they can be checked.
11110
a884fdcc
PE
11111 * fns.c (get_random, seed_random): Move extern decls from here ...
11112 * lisp.h: ... to here, so that they can be checked.
11113
604efe86 11114 * sysdep.c (reset_io): Now static.
b8950c94 11115 (wait_for_termination_signal): Remove; unused.
604efe86 11116
38fc62d9
PE
11117 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11118 (copy_keymap_item, append_key, push_text_char_description):
11119 Now static.
1004a21a 11120 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11121 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11122 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11123 (describe_map_tree):
11124 Rename locals to avoid shadowing.
38fc62d9 11125
2f2650da
PE
11126 * keyboard.c: Declare functions static if they are not used elsewhere.
11127 (echo_char, echo_dash, cmd_error, top_level_2):
11128 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11129 (read_char, kbd_buffer_get_event, make_lispy_position):
11130 (make_lispy_event, make_lispy_movement, apply_modifiers):
11131 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11132 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11133 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11134 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11135 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11136
a053e86c 11137 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11138 (mark_kboards): Move decl here ...
11139 * alloc.c (mark_kboards): ... from here.
a053e86c 11140
4752793e
PE
11141 * lisp.h (force_auto_save_soon): New decl.
11142
74f10ca7 11143 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11144 (DEFINE_DUMMY_FUNCTION): New macro.
11145 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11146 Use it.
c03cd23f
PE
11147 (main): Add casts to avoid warnings
11148 if GCC considers string literals to be constants.
74f10ca7 11149
022e70d4
PE
11150 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11151
59d6fe83
PE
11152 * dbusbind.c: Pointer signedness fixes.
11153 (xd_signature, xd_append_arg, xd_initialize):
11154 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11155 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11156 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11157 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11158
78320123
PE
11159 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11160 if GCC considers string literals to be constants.
49cebcca 11161 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11162
35ac2a97
SM
111632011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11164
fb103ca9
SM
11165 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11166 (print_preprocess, print_object): New macro to fix last change.
11167
35ac2a97
SM
11168 * print.c (print_preprocess): Don't forget font objects.
11169
62973b41
JB
111702011-03-16 Juanma Barranquero <lekktu@gmail.com>
11171
11172 * emacs.c (USAGE3): Doc fixes.
11173
0e48bb22
AS
111742011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11175
11176 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11177 structure.
11178
7684e57b
JB
111792011-03-14 Juanma Barranquero <lekktu@gmail.com>
11180
11181 * lisp.h (VWindow_system, Qfile_name_history):
11182 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11183 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11184 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11185
11186 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11187 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11188
11189 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11190 * w32console.c (detect_input_pending, read_input_pending)
11191 (encode_terminal_code):
11192 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11193 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11194 (w32_system_caret_y, Qfile_name_history):
11195 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11196 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11197 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11198 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11199 * w32proc.c (Qlocal, report_file_error):
11200 * w32term.c (Vwindow_system, updating_frame):
11201 * w32uniscribe.c (initialized, uniscribe_font_driver):
11202 Remove unneeded extern declarations.
11203
2aa46d6c
CY
112042011-03-14 Chong Yidong <cyd@stupidchicken.com>
11205
c96bbc66 11206 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11207
cffc6f3b
CY
112082011-03-13 Chong Yidong <cyd@stupidchicken.com>
11209
11210 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11211 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11212 These macros can no longer be used for assignment.
11213
44f230aa
SM
11214 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11215 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11216 (record_buffer_markers, fetch_buffer_markers): New functions for
11217 recording and fetching special buffer markers.
11218 (set_buffer_internal_1, set_buffer_temp): Use them.
11219
11220 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11221
11222 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11223
11224 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11225 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11226
11227 * xdisp.c (hscroll_window_tree):
11228 (reconsider_clip_changes): Use PT instead of BUF_PT.
11229
d251f04b
EZ
112302011-03-13 Eli Zaretskii <eliz@gnu.org>
11231
11232 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11233 $(EMACS_ROOT)/lib/intprops.h.
11234
f0c77cd1
PE
112352011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11236
3eca4629
PE
11237 Fix more problems found by GCC 4.5.2's static checks.
11238
7c86ee98
PE
11239 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11240 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11241 (xg_free_frame_widgets): Make it clear that a local variable is
11242 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11243 (gdk_window_get_screen): Make it clear that this macro is needed
11244 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11245 (int_gtk_range_get_value): New function, which avoids a diagnostic
11246 from gcc -Wbad-function-cast.
11247 (xg_set_toolkit_scroll_bar_thumb): Use it.
11248 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11249 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11250 (get_utf8_string, xg_get_file_with_chooser):
11251 Rename locals to avoid shadowing.
11252 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11253
41729b81
PE
11254 * xgselect.c (xg_select): Remove unused var.
11255
f0c77cd1
PE
11256 * image.c (four_corners_best): Mark locals as initialized.
11257 (gif_load): Initialize transparent_p to zero (Bug#8238).
11258 Mark another local as initialized.
ec6cf4c6 11259 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11260
ce0ad53d 11261 * image.c (clear_image_cache): Now static.
d5d5a617 11262 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11263 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11264 (x_edge_detection): Remove unnecessary cast that
11265 gcc -Wbad-function-cast diagnoses.
2037898d 11266 (gif_load): Fix pointer signedness.
6ae141d6
PE
11267 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11268 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11269
33383987 112702011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11271
d32df629
PE
11272 Improve quality of tests for time stamp overflow.
11273 For example, without this patch (encode-time 0 0 0 1 1
11274 1152921504606846976) returns the obviously-bogus value (-948597
11275 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11276 reports time overflow. See
11277 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11278 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11279 * editfns.c: Include limits.h and intprops.h.
11280 (TIME_T_MIN, TIME_T_MAX): New macros.
11281 (time_overflow): Move earlier, to before first use.
11282 (hi_time, lo_time): New functions, for an accurate test for
11283 out-of-range times.
11284 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11285 (Fget_internal_run_time): Don't assume time_t fits in int.
11286 (make_time): Use list2 instead of Fcons twice.
11287 (Fdecode_time): More accurate test for out-of-range times.
11288 (check_tm_member): New function.
11289 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11290 (lisp_time_argument): Don't rely on undefined left-shift and
11291 right-shift behavior when checking for time stamp overflow.
8be6f318 11292
fe31d94c
PE
11293 * editfns.c (time_overflow): New function, refactoring common code.
11294 (Fformat_time_string, Fdecode_time, Fencode_time):
11295 (Fcurrent_time_string): Use it.
11296
8be6f318
PE
11297 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11298 * dired.c (make_time): Move to ...
11299 * editfns.c (make_time): ... here.
11300 * systime.h: Note the move.
11301
09d9db2c 113022011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11303
126bc0dc
YM
11304 * fringe.c (update_window_fringes): Remove unused variables.
11305
c47cbdfd
YM
11306 * unexmacosx.c (copy_data_segment): Also copy __got section.
11307 (Bug#8223)
11308
7ac80be9
EZ
113092011-03-12 Eli Zaretskii <eliz@gnu.org>
11310
c96bbc66 11311 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11312 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11313 Constify `char *' arguments and their references according to
11314 prototypes in tparam.h.
11315
ecb0f94d 11316 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11317
7ac80be9
EZ
11318 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11319 Adapt all references accordingly.
11320
11321 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11322
ef1fd07e
TT
113232011-03-11 Tom Tromey <tromey@redhat.com>
11324
11325 * buffer.c (syms_of_buffer): Remove obsolete comment.
11326
7ef4b50c
EZ
113272011-03-11 Eli Zaretskii <eliz@gnu.org>
11328
11329 * termhooks.h (encode_terminal_code): Declare prototype.
11330
11331 * msdos.c (encode_terminal_code): Don't declare prototype.
11332
11333 * term.c (encode_terminal_code): Now external again, used by
11334 w32console.c and msdos.c.
11335
44f230aa
SM
11336 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11337 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11338
4b1ec863 113392011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11340
1714f52b 11341 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11342
4b1ec863
PE
11343 * fringe.c (update_window_fringes): Mark locals as initialized
11344 (Bug#8227).
11345 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11346
524c7aa6
PE
11347 * alloc.c (mark_fringe_data): Move decl from here ...
11348 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11349 to check its interface.
11350 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11351
a5c0af81 11352 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11353 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11354 (fontset_font): Mark local as initialized.
a9a06e0b 11355 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11356
b4716021
PE
11357 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11358
811e9bac 11359 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11360 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11361 (x_own_selection, Fx_disown_selection_internal): Rename locals
11362 to avoid shadowing.
11363 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11364
7e3ab302
PE
11365 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11366 so that the caller can use some name other than gcpro1.
11367 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11368 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11369 (Fx_backspace_delete_keys_p):
11370 Use them to avoid shadowing, and rename vars to avoid shadowing.
11371 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11372 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11373 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11374 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11375 Remove unused locals.
7e3ab302
PE
11376 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11377 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11378 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11379 macros.
f78faa98 11380
e2b13473
PE
11381 * xterm.h (x_mouse_leave): New decl.
11382
77f23912
PE
11383 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11384 Remove unused functions.
cdf4ba58
PE
11385 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11386 (x_calc_absolute_position): Now static.
7411c686 11387 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11388 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11389 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11390 unless they are used.
38d0b34a
PE
11391 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11392 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11393 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11394 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11395 (x_error_catcher, x_connection_closed, x_error_handler):
11396 (x_error_quitter, xembed_send_message, x_iconify_frame):
11397 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11398 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11399 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11400
44f230aa
SM
11401 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11402 Rename or move locals to avoid shadowing.
6b463e58 11403 (tty_defined_color, merge_face_heights): Now static.
5967d051 11404 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11405 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11406 does not deduce is never used uninitialized.
73719eba
PE
11407 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11408 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11409
426994c3 11410 * terminal.c (store_terminal_param): Now static.
5489860b 11411
032f1620 11412 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11413 (set_frame_menubar): Remove unused local.
d4323972 11414 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11415 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11416 since they might point to immutable storage.
281585b0
PE
11417 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11418 since it's unused otherwise.
032f1620 11419
367c19e5 11420 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11421 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11422 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11423 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11424 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11425 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11426 does not deduce are never used uninitialized.
70739cbe 11427
07b48fa9
PE
11428 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11429
8868a238 11430 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11431 * window.c (window_loop, size_window):
11432 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11433
7e5cf297 11434 * window.c (display_buffer): Now static.
d6550a9f
PE
11435 (size_window): Mark variables that gcc -Wuninitialized
11436 does not deduce are never used uninitialized.
a586633d
PE
11437 * window.h (check_all_windows): New decl, to forestall
11438 gcc -Wmissing-prototypes diagnostic.
5b555da1 11439 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11440
f6095868
PE
11441 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11442 shadowing.
11443 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11444 Include <limits.h>.
11445 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11446 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11447 (load_charset_map): Mark variables that gcc -Wuninitialized
11448 does not deduce are never used uninitialized.
53df7c11 11449 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11450
f38b440c
PE
11451 * coding.c (coding_set_source, coding_set_destination):
11452 Use "else { /* comment */ }" rather than "else /* comment */;"
11453 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11454 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11455 a block, when the outer 'i' will do.
11456 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11457 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11458 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11459 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11460 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11461 Rename locals to avoid shadowing.
11462 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11463 * coding.c (emacs_mule_char, encode_invocation_designation):
11464 Now static, since they're not used elsewhere.
413bb2db 11465 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11466 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11467 (decode_coding_emacs_mule): Mark variables that gcc
11468 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11469 (detect_coding_iso_2022): Initialize a local variable that might
11470 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11471 this initialization is needed. (Bug#8211)
5f58e762
PE
11472 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11473 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11474 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11475 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11476 Remove unused macros.
f38b440c 11477
232b38b9 11478 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11479 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11480 * character.c (string_count_byte8): Likewise.
232b38b9 11481
fb90da1b
PE
11482 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11483 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11484
fb93dbc2
PE
11485 * chartab.c (copy_sub_char_table): Now static, since it's not used
11486 elsewhere.
5c156ace
PE
11487 (sub_char_table_ref_and_range, char_table_ref_and_range):
11488 Rename locals to avoid shadowing.
bbcd0949 11489 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11490
7d3b3862 11491 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11492 (BIDI_BOB): Remove unused macro.
7d3b3862 11493
6be7d3da
PE
11494 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11495 deduce are never used uninitialized.
c2ed9c8b 11496 * term.c (encode_terminal_code): Likewise.
6be7d3da 11497
75f8807f 11498 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11499
50938595
PE
11500 * tparam.h: New file.
11501 * term.c, tparam.h: Include it.
11502 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11503 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11504 Move these decls to tparam.h, and make them agree with what
11505 is actually in tparam.c. The previous trick of using incompatible
11506 decls in different modules does not conform to the C standard.
11507 All callers of tparam changed to use tparam's actual API.
11508 * tparam.c (tparam1, tparam, tgoto):
11509 Use const pointers where appropriate.
11510
fbceeba2
PE
11511 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11512 * cm.h (struct cm): Likewise.
11513 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11514 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11515 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11516 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11517 (turn_on_face, init_tty): Likewise.
11518 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11519
7f3f1250
PE
11520 * term.c (term_mouse_position): Rename local to avoid shadowing.
11521
e6ca6543
PE
11522 * alloc.c (mark_ttys): Move decl from here ...
11523 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11524
c40f8d15
AS
115252011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11526
11527 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11528
cfe0661d
JB
115292011-03-09 Juanma Barranquero <lekktu@gmail.com>
11530
11531 * search.c (compile_pattern_1): Remove argument regp, unused since
11532 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11533 (compile_pattern): Don't pass it.
11534
0afb4571
J
115352011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11536
11537 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11538 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11539 for ! HAVE_GTK3.
11540 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11541
11542 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11543
11544 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11545 gdk_window_get_screen, gdk_window_get_geometry,
11546 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11547 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11548 (xg_get_pixbuf_from_pixmap): New function.
11549 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11550 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11551 Call xg_get_pixbuf_from_pixmap instead of
11552 gdk_pixbuf_get_from_drawable.
11553 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11554 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11555 (xg_check_special_colors): Use GtkStyleContext and its functions
11556 for HAVE_GTK3.
11557 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11558 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11559 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11560 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11561 Call gtk_widget_get_preferred_size.
0afb4571
J
11562 (xg_frame_resized): gdk_window_get_geometry only takes 5
11563 parameters.
44f230aa
SM
11564 (xg_win_to_widget, xg_event_is_for_menubar):
11565 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11566 (xg_set_widget_bg): New function.
11567 (delete_cb): New function.
895009e1 11568 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11569 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11570 (xg_set_background_color): Call xg_set_widget_bg.
11571 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11572 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11573 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11574 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11575 if ! HAVE_GTK3.
11576 (update_frame_tool_bar): Call gtk_widget_hide.
11577 (xg_initialize): Use GDK_KEY_g.
11578
11579 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11580 if ! HAVE_GTK3
11581 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11582
11583 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11584 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11585 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11586
1c2cc4ef
JB
115872011-03-08 Juanma Barranquero <lekktu@gmail.com>
11588
11589 * w32xfns.c (select_palette): Check success of RealizePalette against
11590 GDI_ERROR, not zero.
11591
33383987 11592See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11593
11594;; Local Variables:
11595;; coding: utf-8
aac0c6e3
MR
11596;; End:
11597
2f097256 11598 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11599
11600 This file is part of GNU Emacs.
11601
11602 GNU Emacs is free software: you can redistribute it and/or modify
11603 it under the terms of the GNU General Public License as published by
11604 the Free Software Foundation, either version 3 of the License, or
11605 (at your option) any later version.
11606
11607 GNU Emacs is distributed in the hope that it will be useful,
11608 but WITHOUT ANY WARRANTY; without even the implied warranty of
11609 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11610 GNU General Public License for more details.
11611
11612 You should have received a copy of the GNU General Public License
11613 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.