Spelling fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c052ead4
JD
12011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2
3 * widget.c (update_wm_hints): Return if wmshell is null.
4 (widget_update_wm_size_hints): New function.
5
6 * widget.h (widget_update_wm_size_hints): Declare.
7
8 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9 widget_update_wm_size_hints (Bug#10104).
10
9e49252b
EZ
112011-12-03 Eli Zaretskii <eliz@gnu.org>
12
13 * xdisp.c (handle_invisible_prop): If the invisible text ends just
14 before a newline, prepare the bidi iterator for consuming the
15 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 16 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 17
02b16839
JL
182011-12-02 Juri Linkov <juri@jurta.org>
19
20 * search.c (Fword_search_regexp): New Lisp function created from
21 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
22 (Fword_search_backward, Fword_search_forward)
23 (Fword_search_backward_lax, Fword_search_forward_lax):
24 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
25 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
26
0068070e
SM
272011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
28
29 * fileio.c (Finsert_file_contents): Move after-change-function call
30 to before the "handled:" label, since all "goto handled" appear in
31 cases where the *-change-functions have already been properly called
32 (bug#10117).
33
3360a3fc
AS
342011-12-01 Andreas Schwab <schwab@linux-m68k.org>
35
36 * keyboard.c (interrupt_signal): Don't call kill-emacs when
37 waiting for input. (Bug#10169)
38
73d6c093
EZ
392011-11-30 Eli Zaretskii <eliz@gnu.org>
40
41 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
42 verifies glyph row's hash code--we have just reallocated the
43 glyphs, so their contents can be complete garbage. (Bug#10164)
44
febe6bea
JB
452011-11-30 Juanma Barranquero <lekktu@gmail.com>
46
47 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
48
801a4313
EZ
492011-11-30 Eli Zaretskii <eliz@gnu.org>
50
51 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
52 attributes are tested _before_ calling verify_row_hash, to protect
53 against GCC re-ordering of the tests. (Bug#10164)
54
2b56b87e
JD
552011-11-29 Jan Djärv <jan.h.d@swipnet.se>
56
57 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
58
59 * xterm.c (handle_one_xevent): Only set async_visible and friends
60 if net_wm_state_hidden_seen is non-zero (Bug#10002)
61 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
62 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
63
dbf31225
PE
642011-11-28 Paul Eggert <eggert@cs.ucla.edu>
65
66 Remove GCPRO-related macros that exist only to avoid shadowing locals.
67 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
68 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
69 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
70 All uses changed to use GCPRO1 etc.
71 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
72 Revert to old implementation (i.e., before 2011-03-11).
73
1305621b
YM
742011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
75
76 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
77 of scroll runs so as to avoid assigning disabled bogus rows and
78 unnecessary graphics copy operations.
79
8c9afb46
EZ
802011-11-27 Eli Zaretskii <eliz@gnu.org>
81
82 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
83 (snprintf) [_MSC_VER]: Redirect to _snprintf.
84 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
85 (malloc, free, realloc, calloc): Redirect to e_* only when
86 compiling Emacs.
87
88 * lisp.h (GCTYPEBITS): Move before first use.
89 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
90 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
91 this macro definition.
92
93 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
94 _MSC_VER.
95
54e9e3bf
JD
962011-11-27 Jan Djärv <jan.h.d@swipnet.se>
97
98 * gtkutil.c (xg_create_frame_widgets): Call
99 gtk_window_set_has_resize_grip (FALSE) if that function is
100 present with Gtk+ 2.0.
101
83aca1cb
PE
1022011-11-26 Paul Eggert <eggert@cs.ucla.edu>
103
104 * fileio.c (Finsert_file_contents): Undo previous change; see
105 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
106
5b76caa4
PE
1072011-11-26 Paul Eggert <eggert@cs.ucla.edu>
108
109 Rename locals to avoid shadowing.
110 * fileio.c (Finsert_file_contents):
111 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
112 * process.c (wait_reading_process_output):
113 Rename inner 'proc' to 'p' to avoid shadowing.
114 Indent for consistency with usual Emacs style.
115
8c535114
EZ
1162011-11-25 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (redisplay_window): If cursor row is not fully visible
119 after recentering, and scroll-conservatively is set to a large
120 number, scroll window by a few more lines to make the cursor fully
121 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
122 (start_display): Don't move to the next line if the display should
123 start at a newline that is part of a display vector or an overlay
124 string. (Bug#10119)
8c535114 125
fa4fdb5c
JL
1262011-11-24 Juri Linkov <juri@jurta.org>
127
128 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
129 after the `MagickPingImage' call. (Bug#10112)
130
90ec88df
CY
1312011-11-23 Chong Yidong <cyd@gnu.org>
132
133 * window.c (Fcoordinates_in_window_p): Accept only live windows.
134
56e2e794
MR
1352011-11-23 Martin Rudalics <rudalics@gmx.at>
136
137 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
138 making another buffer current. (Bug#10114)
139
b6e64c41
GM
1402011-11-23 Glenn Morris <rgm@gnu.org>
141
142 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
143
6b21de18
CY
1442011-11-23 Chong Yidong <cyd@gnu.org>
145
146 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
147 using it (Bug#5984).
148
b12cd789
EZ
1492011-11-22 Eli Zaretskii <eliz@gnu.org>
150
151 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
152 and header-lines, as they don't have one computed for them.
153 (Bug#10098)
154
155 * .gdbinit (prow): Make displayed values more self-explaining.
156 Add row's hash code.
157
261b6fd4
LMI
1582011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
159
160 * process.c (wait_reading_process_output): Fix asynchrounous
161 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 162 (wait_reading_process_output): Add comment and URL.
261b6fd4 163
e7cfd277
JD
1642011-11-21 Jan Djärv <jan.h.d@swipnet.se>
165
166 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
167
a9b9b7f5
CY
1682011-11-21 Chong Yidong <cyd@gnu.org>
169
170 * window.c (Fnext_window, Fprevious_window): Doc fix.
171
b0d15b4f
SM
1722011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
173
174 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
175
fe7a3057
JB
1762011-11-20 Juanma Barranquero <lekktu@gmail.com>
177
178 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
179
d2999b1a
MR
1802011-11-20 Martin Rudalics <rudalics@gmx.at>
181
182 * window.c (Fset_window_combination_limit): Rename argument
183 STATUS to LIMIT.
184 (Vwindow_combination_limit): Remove "status" from doc-string.
185
d5ff9cd0
AS
1862011-11-20 Andreas Schwab <schwab@linux-m68k.org>
187
188 * m/ibms390.h: Remove.
189 * m/ibms390x.h: Don't include "ibms390.h".
190
a5bb9bd3
SM
1912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
192
193 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
194 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
195
cd1181db
JB
1962011-11-20 Juanma Barranquero <lekktu@gmail.com>
197
198 * casetab.c (Fset_case_table):
199 * charset.c (Fcharset_after): Fix typos.
200
615a3b8d 2012011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 202
17e845af
PE
203 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
204 Otherwise, valgrind does not work on some platforms.
205 Problem reported by Andreas Schwab in
6a0bf43d
PE
206 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
207 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
208 is set, removing the need for VIRT_ADDRESS_VARIES.
209 (PURE_P): Use a more-efficient implementation that needs just one
210 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
211 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
212 to 4 (xorl, subq, cmpq, setbe).
213 * alloc.c (pure): Always extern now, since that's the
214 VIRT_ADDR_VARIES behavior.
215 (PURE_POINTER_P): Use a single comparison, not two, for
216 consistency with the new puresize.h.
217 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
218 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
219 Remove VIRT_ADDR_VARIES no longer needed.
220
f8fe6f96
EZ
2212011-11-19 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
224 (erase_phys_cursor, update_window_cursor, show_mouse_face)
225 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
226 behave as if the cursor position were at the window margin.
227
228 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
229 and the cursor position is out of bounds, behave as if the cursor
230 position were at the window margin. (Bug#10075)
231
df05a53c
CY
2322011-11-18 Chong Yidong <cyd@gnu.org>
233
234 * window.c (Fwindow_combination_limit): Make first argument
235 non-optional, since it is meaningless for live windows like the
236 selected window.
237
2071918e
DA
2382011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
239
240 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
241
b50a28de
SM
2422011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * intervals.c: Fix grafting over the whole buffer (bug#10071).
245 (graft_intervals_into_buffer): Simplify.
246
015137db
EZ
2472011-11-18 Eli Zaretskii <eliz@gnu.org>
248
249 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
250 hash values of the two rows.
251 (copy_row_except_pointers): Preserve the used[] arrays and the
252 hash values of the two rows. (Bug#10035)
68c95424 253 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
254
255 * xdisp.c (row_hash): New function, body extracted from
256 compute_line_metrics.
257 (compute_line_metrics): Call row_hash, instead of computing the
258 hash code inline.
259
260 * dispnew.c (verify_row_hash): Call row_hash for computing the
261 hash code of a row, instead of duplicating code from xdisp.c.
262
263 * dispextern.h (row_hash): Add prototype.
264
a2addb04
TH
2652011-11-18 Tassilo Horn <tassilo@member.fsf.org>
266
267 * frame.c (delete_frame): Don't delete the terminal when the last
268 X frame is closed if emacs is built with GTK toolkit.
269
df85d315
JB
2702011-11-17 Juanma Barranquero <lekktu@gmail.com>
271
272 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
273
a0c2d0ae
MR
2742011-11-17 Martin Rudalics <rudalics@gmx.at>
275
276 * window.c (Vwindow_splits): Rename to
277 Vwindow_combination_resize. Suggested by Juri Linkov.
278 (Fsplit_window_internal): Use Vwindow_combination_resize instead
279 of Vwindow_splits.
280
58179cce
JB
2812011-11-16 Juanma Barranquero <lekktu@gmail.com>
282
7877f373
JB
283 * nsfns.m (Fns_font_name):
284 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 285
b6f67890
MR
2862011-11-16 Martin Rudalics <rudalics@gmx.at>
287
288 * window.h (window): Rename slot "nest" to "combination_limit".
289 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
290 (Fset_window_nest): Rename to Fset_window_combination_limit.
291 (Vwindow_nest): Rename to Vwindow_combination_limit.
292 (recombine_windows, make_parent_window, make_window)
293 (Fsplit_window_internal, saved_window)
294 (Fset_window_configuration, save_window_save): Rename all
295 occurrences of window_nest to window_combination_limit.
296
c7015153
JB
2972011-11-15 Juanma Barranquero <lekktu@gmail.com>
298
299 * image.c (imagemagick_load_image): Fix typo.
300
322ad6ec
EZ
3012011-11-14 Eli Zaretskii <eliz@gnu.org>
302
303 * xdisp.c (display_line): Move the call to
304 highlight_trailing_whitespace before the call to
305 compute_line_metrics, since the latter needs to see the final
306 faces of all the glyphs to compute ROW's hash value. Fixes
307 assertion violations in row_equal_p. (Bug#10035)
308
f067b8ec
JB
3092011-11-14 Juanma Barranquero <lekktu@gmail.com>
310
311 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
312 just return (bug#10044).
313
1e5b2111
EZ
3142011-11-12 Eli Zaretskii <eliz@gnu.org>
315
7ef3cbd5
EZ
316 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
317 with user-defined heap size. Bump the default size of the temacs
318 heap to 27MB, to avoid memory warning when running temacs.
319 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
320
1e5b2111
EZ
321 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
322 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
323 (verify_row_hash) [XASSERTS]: New function.
324 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
325 that the hash value of glyph rows is correct.
1e5b2111 326
89d61221
MR
3272011-11-12 Martin Rudalics <rudalics@gmx.at>
328
329 * window.h (window): Remove splits slot.
330 * window.c (Fwindow_splits, Fset_window_splits): Remove.
331 (Fdelete_other_windows_internal, make_parent_window)
332 (make_window, Fsplit_window_internal, Fdelete_window_internal)
333 (Fset_window_configuration, save_window_save): Don't deal with
334 split status of windows.
335 (saved_window): Remove splits slot.
336 (Vwindow_splits): Rewrite doc-string.
337
97f18cc8
JD
3382011-11-11 Jan Djärv <jan.h.d@swipnet.se>
339
340 * xfns.c (unwind_create_frame):
341 * nsfns.m (unwind_create_frame):
342 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
343 Vframe_list (Bug#9999).
344
22a648b4
DA
3452011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
346
0b381c7e 347 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 348
659afede
KH
3492011-11-11 Kenichi Handa <handa@m17n.org>
350
351 * callproc.c (Fcall_process): Set the member dst_multibyte of
352 process_coding.
353
9ac0394b
KH
3542011-11-11 Johan Bockgård <bojohan@gnu.org>
355
356 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
357 avoid a crash (bug#9496).
358
2fbdc249
CY
3592011-11-09 Chong Yidong <cyd@gnu.org>
360
361 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
362 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
363
ac6b1f81
PE
3642011-11-08 Paul Eggert <eggert@cs.ucla.edu>
365
366 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
367
09db192c
PE
3682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
369
370 Avoid some portability problems by eschewing 'extern inline' functions.
371 The trivial performance wins aren't worth the portability hassles; see
372 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
373 et seq.
374 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
375 (window_box_width, window_box_left, window_box_left_offset)
376 (window_box_right, window_box_right_offset): Undo previous change,
377 by removing the "extern"s.
378 * intervals.c (adjust_intervals_for_insertion)
379 (adjust_intervals_for_deletion): Undo previous change,
380 making these static again.
381 (offset_intervals, temp_set_point_both, temp_set_point)
382 (copy_intervals_to_string): No longer inline.
383 * xdisp.c (window_text_bottom_y, window_box_width)
384 (window_box_height, window_box_left_offset)
385 (window_box_right_offset, window_box_left, window_box_right)
386 (window_box): No longer inline.
387
105216ed
CY
3882011-11-08 Chong Yidong <cyd@gnu.org>
389
390 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
391 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
392 an error if not a live window.
393 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
394 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
395
ae9e237f
JB
3962011-11-07 Juanma Barranquero <lekktu@gmail.com>
397
398 * lisp.h (syms_of_abbrev): Remove declaration.
399 Reported by CHENG Gao <chenggao@royau.me>.
400
c7aa8333
EZ
4012011-11-07 Eli Zaretskii <eliz@gnu.org>
402
403 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
404 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
405 of temacs in GUI mode.
406
be7f5545
MR
4072011-11-07 Martin Rudalics <rudalics@gmx.at>
408
409 * window.h: Declare delete_all_child_windows instead of
410 delete_all_subwindows.
411 * window.c (Fwindow_nest, Fset_window_nest)
412 (Fset_window_new_total, Fset_window_new_normal)
413 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
414 (delete_all_subwindows): Rename to delete_all_child_windows.
415 (Fdelete_other_windows_internal, Fset_window_configuration):
416 Call delete_all_child_windows instead of delete_all_subwindows.
417 * frame.c (delete_frame): Call delete_all_child_windows instead
418 of delete_all_subwindows.
419
ca78dc43
PE
4202011-11-07 Paul Eggert <eggert@cs.ucla.edu>
421
422 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
423 This is also needed for porting to any host where GC_MARK_STACK is
424 not GC_MAKE_GCPROS_NOOPS.
425 (which_symbols): Use it.
426
a0241d01
KH
4272011-11-07 Kenichi Handa <handa@m17n.org>
428
429 * coding.c (coding_set_destination): Check coding->src_pos only
430 when coding->src_object is a buffer (bug#9910).
431
432 * process.c (send_process): Set the member src_multibyte of coding
433 to 0 (bug#9911) when sending a unibyte text.
434
435 * callproc.c (Fcall_process): Set the member src_multibyte of
436 process_coding to 0 (bug#9912).
437
a64bfdfa 4382011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
439
440 * xmenu.c (cleanup_widget_value_tree): New function.
441 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
442 calling free_menubar_widget_value_tree directly (Bug#9830).
443
cb41b32a
PE
4442011-11-06 Paul Eggert <eggert@cs.ucla.edu>
445
446 Fix some portability problems with 'inline'.
447 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
448 (window_box_width, window_box_left, window_box_left_offset)
449 (window_box_right, window_box_right_offset): Declare extern.
450 Otherwise, these inline functions do not conform to C99 and
451 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
452 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
453 * intervals.c (adjust_intervals_for_insertion)
454 (adjust_intervals_for_deletion): Now extern, because otherwise the
455 extern inline functions 'offset_intervals' couldn't refer to it.
456 (static_offset_intervals): Remove.
457 (offset_intervals): Rewrite using the old contents of
458 static_offset_intervals. The old version didn't conform to C99
459 because an extern inline function contained a reference to an
460 identifier with static linkage.
461
b7041366
AS
4622011-11-06 Andreas Schwab <schwab@linux-m68k.org>
463
464 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
465 GC.
466
88a37c4d
EZ
4672011-11-06 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (init_iterator, reseat_to_string): Don't set the
470 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
471 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
472 return Qleft_to_right.
473
49745b39
CY
4742011-11-06 Chong Yidong <cyd@gnu.org>
475
476 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
477 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
478 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
479 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
480 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
481 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
482 (Fwindow_vscroll): Doc fix.
483 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
484 argument, since it makes no sense to pass a live window and for
485 consistency with window-child.
486
1f05cd82
CS
4872011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
488
489 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
490 support MSVC.
491
22610910
JR
4922011-11-05 Jason Rumney <jasonr@gnu.org>
493
494 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
495 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
496 fonts (Bug#6029).
497 (add_font_entity_to_list): Fix logic errors in mixed boolean and
498 bitwise arithmetic preventing use of unicode-sip and non-truetype
499 opentype fonts.
500
a06776b2
EZ
5012011-11-05 Eli Zaretskii <eliz@gnu.org>
502
3ad924ba
EZ
503 * s/ms-w32.h (fstat, stat, utime): Move redirections to
504 "emacs"-only part.
505
a06776b2
EZ
506 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
507 initialization code to keep similarity to xfns.c after changes
508 from 2011-11-05.
509
c9e7db78
JD
5102011-11-05 Jan Djärv <jan.h.d@swipnet.se>
511
a97f8f3f
JD
512 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
513 (unwind_create_frame): New function (Bug#9943).
514 (Fx_create_frame): Restructure code to be more similar to the one in
515 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
516 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
517 Move terminal->reference_count++ just before making the frame official
518 (Bug#9943).
519
520 * nsterm.m (x_free_frame_resources): New function.
521 (x_destroy_window): Move code to x_free_frame_resources.
522
c9e7db78
JD
523 * xfns.c (unwind_create_frame): Fix comment.
524 (Fx_create_frame, x_create_tip_frame): Move
525 terminal->reference_count++ just before making the frame
526 official. Move initialization of image_cache_refcount and
527 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
528
a6fc3b5c
EZ
5292011-11-05 Eli Zaretskii <eliz@gnu.org>
530
531 Support MSVC build with newer versions of Visual Studio.
532 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
533 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
534 nt/gmake.defs.
535
536 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
537 which are not supported by MSVC.
538 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
539 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
540 bitfields.
541 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
542 types in bitfields.
543 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
544
545 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
546
58179cce 5472011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
548
549 Support MSVC build with newer versions of Visual Studio.
550 * w32.c: Don't include w32api.h for MSVC.
551 (init_environment) [_MSC_VER]: Call sys_access, not _access.
552
553 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
554 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
555 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
556 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
557 e_* cousins.
558 (alloca) [_MSC_VER]: Define to _alloca.
559
560 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
561
562 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
563
a58c13ed
EZ
5642011-11-04 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (note_mouse_highlight): If either of
567 previous/next-single-property-change returns nil, treat that as
568 the beginning or the end of the buffer. (Bug#9955)
569
fe0b6370
JD
5702011-11-04 Jan Djärv <jan.h.d@swipnet.se>
571
a58c13ed 572 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
573 label is not null (Bug#9951).
574 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
575 may be NULL.
576
89bd5ee1
EZ
5772011-11-04 Eli Zaretskii <eliz@gnu.org>
578
579 * window.c (Fwindow_body_size): Mention in the doc string that the
580 return value is in frame's canonical units. (Bug#9949)
581
84c3edb9
EZ
5822011-11-03 Eli Zaretskii <eliz@gnu.org>
583
4e2fb5c7
EZ
584 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
585
84c3edb9 586 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 587 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 588 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 589
bc17a887
EZ
5902011-11-01 Eli Zaretskii <eliz@gnu.org>
591
592 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
593 Don't stop backward scan on the continuation glyph, even though
594 its CHARPOS is positive.
26b46e51
EZ
595 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
596 cover_string to disp_string.
bc17a887 597
4ee88440
MR
5982011-11-01 Martin Rudalics <rudalics@gmx.at>
599
600 * window.c (temp_output_buffer_show): Don't use
601 Vtemp_buffer_show_specifiers.
602 (Vtemp_buffer_show_specifiers): Remove unused variable.
603
c2ff3c02
EZ
6042011-10-30 Eli Zaretskii <eliz@gnu.org>
605
606 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
607 past the beginning of the current glyph matrix.
608
58179cce 6092011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
610
611 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
612 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
613 HAVE_GTK3 (Bug#9869).
b77a6a7f 614
3b574623
JD
615 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
616 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
617
b77a6a7f
JD
618 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
619
620 * xterm.c: Declare x_handle_net_wm_state to return int.
621 (handle_one_xevent): Check if we are iconified but don't have
622 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
623 (get_current_wm_state): Return non-zero if not hidden,
624 check for _NET_WM_STATE_HIDDEN (Bug#9893).
625 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
626 (x_handle_net_wm_state): Return what get_current_wm_state returns.
627 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
628
196e41e4
PE
6292011-10-29 Paul Eggert <eggert@cs.ucla.edu>
630
631 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
632 so that this new function doesn't get optimized away by a
633 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
634
021f2e1a
AS
6352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
636
637 * frame.h (MOUSE_HL_INFO): Remove excess parens.
638
8b058d44
EZ
6392011-10-29 Eli Zaretskii <eliz@gnu.org>
640
641 Fix the `xbytecode' command.
642 * .gdbinit (xprintbytestr): New command.
b50a28de 643 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
644 (xbytecode): Print the byte-code string as well.
645
4452fb80
EZ
6462011-10-29 Kim Storm <storm@cua.dk>
647
8b058d44
EZ
648 * alloc.c (which_symbols): New function.
649
21b72067
AS
6502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
651
652 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
653 line. (Bug#9903)
654
83ed7b5c
GM
6552011-10-29 Glenn Morris <rgm@gnu.org>
656
657 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
658 Not clear what it was for, and it causes various bugs. (Bug#9839)
659
5a7a728b
EZ
6602011-10-28 Eli Zaretskii <eliz@gnu.org>
661
662 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
663 possible random value that matches one of those tested as
664 condition to clear the mouse face.
665
d3d0842f
CY
6662011-10-28 Chong Yidong <cyd@gnu.org>
667
668 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
669
31b39d13
DN
6702011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
671
672 * window.c (make_window): Initialize phys_cursor_on_p.
673
9aba6043
SM
6742011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 * lisp.h (struct Lisp_Symbol): Update comments.
677
c20992f4
JB
6782011-10-28 Juanma Barranquero <lekktu@gmail.com>
679
680 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
681
db4f02f2
EZ
6822011-10-28 Eli Zaretskii <eliz@gnu.org>
683
684 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
685 <oslsachem@gmail.com> for helping to debug this.
686
687 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
688 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
689 (g_b_init_get_glyph_outline_w): New static variables.
690 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
691 (GetGlyphOutlineW_Proc): New typedefs.
692 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
693 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
694 New functions.
695 (w32font_open_internal, compute_metrics):
696 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
697 instead of calling the "wide" APIs directly.
698
699 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
700
701 * w32.h (syms_of_w32font): Add prototype.
702
87e68db4
JB
7032011-10-27 Juanma Barranquero <lekktu@gmail.com>
704
705 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
706 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
707 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
708 (Fmove_to_window_line): Doc fix.
709
435c1d67
CY
7102011-10-27 Chong Yidong <cyd@gnu.org>
711
712 * process.c (make_process): Set gnutls_state to NULL.
713
714 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
715 non-NULL, regardless of GNUTLS_INITSTAGE.
716 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
717 an error. Set process slots as soon as we allocate them.
718
719 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
720
9c6c6f49
CY
7212011-10-27 Chong Yidong <cyd@gnu.org>
722
9aba6043
SM
723 * gnutls.c (emacs_gnutls_deinit): New function.
724 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
725 (Fgnutls_deinit, Fgnutls_boot): Use it.
726
727 * process.c (make_process): Initialize GnuTLS credentials to NULL.
728 (deactivate_process): Call emacs_gnutls_deinit.
729
657d08d3
JB
7302011-10-27 Juanma Barranquero <lekktu@gmail.com>
731
732 * image.c (x_create_x_image_and_pixmap):
733 * w32.c (sys_rename, w32_delayed_load):
734 * w32font.c (fill_in_logfont):
735 * w32reg.c (x_get_string_resource): Silence compiler warnings.
736
5430d399
JB
7372011-10-26 Juanma Barranquero <lekktu@gmail.com>
738
739 * w32fns.c (w32_default_color_map): New function,
740 extracted from Fw32_default_color_map.
a7ef684b 741 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 742
fe0055fa
PE
7432011-10-25 Paul Eggert <eggert@cs.ucla.edu>
744
745 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
746
e6346438
SM
7472011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
748
749 * keyboard.c (test_undefined): New function (bug#9751).
750 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
751
e112cc37
ET
7522011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
753
754 * sysdep.c (init_sys_modes): Fix the check for the controlling
755 terminal (Bug#6649).
756
7b5d6677
EZ
7572011-10-20 Eli Zaretskii <eliz@gnu.org>
758
759 * dispextern.h (struct bidi_it): New member next_en_type.
760
761 * bidi.c (bidi_line_init): Initialize the next_en_type member.
762 (bidi_resolve_explicit_1): When next_en_pos is valid for the
763 current character, check also for next_en_type being WEAK_EN.
764 (bidi_resolve_weak): Don't enter the expensive loop if the current
765 position is before next_en_pos. Record the bidi type of the first
766 non-ET, non-BN character we find, in addition to its position.
767 (bidi_level_of_next_char): Invalidate next_en_type when
768 next_en_pos is over-stepped.
769
7da0b018
PE
7702011-10-20 Paul Eggert <eggert@cs.ucla.edu>
771
772 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
773 * editfns.c: Rewrite current-time-zone so that it invokes
774 the equivalent of (format-time-string "%Z") to get the time zone name.
775 This fixes a bug when the time zone name contains characters that
776 need converting from the system time locale to Emacs internal format.
777 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
778 that patch fixed format-time-string to do the conversion, but
779 I forgot to fix current-time-zone.
780 (format_time_string): New function, containing most of
781 what Fformat_time_string used to contain.
782 (Fformat_time_string): Rewrite in terms of format_time_string.
783 This doesn't change this function's behavior.
784 (current-time-zone): Rewrite to use format_time_string.
785 This fixes the bug reported by Michael Schierl in
786 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
787 Jason Rumney's 2007-06-07 change worked around this bug, but
788 didn't fix it.
789 * systime.h (tzname, timezone): Remove no-longer-used declarations.
790
8547b010
EZ
7912011-10-19 Eli Zaretskii <eliz@gnu.org>
792
793 * xdisp.c (start_display): If the character at POS is displayed
794 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
795 (try_window_reusing_current_matrix): If a line ends in a display
796 vector or the next line starts in a display vector, continue
797 redrawing the window even though the character position of
798 start_row was reached.
8547b010
EZ
799 (Bug#9771, part 2)
800
4e948d15
CY
8012011-10-18 Chong Yidong <cyd@gnu.org>
802
803 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
804 with nobreak-char-display too.
805
4787455f
EZ
8062011-10-18 Eli Zaretskii <eliz@gnu.org>
807
808 Fix part 3 of bug#9771.
809 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
810 (bidi_resolve_neutral): Don't enter the expensive loop looking for
811 non-neutral characters if the current character is a paragraph
812 separator (a.k.a. Newline). This avoids running the same
813 expensive loop twice, once when we consume the preceding newline
814 and the other time when the line actually needs to be displayed.
815 Avoid the loop when we see neutrals on the base embedding level
816 following a character whose directionality is the same as the
817 paragraph's. This avoids running the expensive loop when a line
818 ends in a long sequence of neutrals, like control characters.
819 Add assertion against STRONG_AL type. Slightly rearrange code
820 that determines the type of a neutral given the first non-neutral
821 that follows it.
822 (bidi_level_of_next_char): Set next_en_pos to zero when
823 invalidating its info.
824
2c91f553
EZ
8252011-10-17 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (push_display_prop): Determine whether to record string
828 or buffer position by IT->string, not by IT->method. Allow
829 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
830 (move_it_vertically_backward): Don't look for character position
831 immediately after the newline when in a continuation line.
832 (Bug#9771, part 1)
2c91f553 833
c7b08b0d
MR
8342011-10-15 Martin Rudalics <rudalics@gmx.at>
835
836 * window.c (coordinates_in_window): Rewrite and delabelize
837 vertical border check. (Bug#5357) (Bug#9618)
838
6b02f655
SM
8392011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
840
841 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
842 errors in XSetWindowBorder (bug#9310).
843
81d40c92
DA
8442011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
845
846 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
847 avoid crash when xmalloc overrun checking is enabled.
848
d4172c3b
EZ
8492011-10-13 Eli Zaretskii <eliz@gnu.org>
850
851 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
852 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
853 cursor motion with <left> and <right> arrow keys.
854
855 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
856 some callers set that themselves.
857
b00eea75
EZ
8582011-10-12 Eli Zaretskii <eliz@gnu.org>
859
860 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
861 display string and the previous row comes from the same string and
862 is empty. (Bug#9739) (Bug#9738)
863
8fe012c4
SM
8642011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
865
866 * doc.c (get_doc_string): Encode file name (bug#9735).
867
0074aef2
EZ
8682011-10-12 Eli Zaretskii <eliz@gnu.org>
869
79beb178
EZ
870 * bidi.c (bidi_level_of_next_char):
871 * xdisp.c (get_visually_first_element): Remove old incorrect
872 comments regarding the Unicode Line Separator character.
873
0074aef2
EZ
874 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
875
6e4b3fbe
DA
8762011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
877
878 * alloc.c (Fgc_status): Do not access beyond zombies array
879 boundary if nzombies > MAX_ZOMBIES.
880 * alloc.c (dump_zombies): Add missing format specifier.
881
0324f3af
PE
8822011-10-12 Paul Eggert <eggert@cs.ucla.edu>
883
b5525cac
PE
884 * xdisp.c (set_cursor_from_row): Simplify conditionals,
885 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
886
0324f3af
PE
887 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
888 Some packages use them to denote characters with modifiers.
889
e9b5f888
AS
8902011-10-11 Andreas Schwab <schwab@linux-m68k.org>
891
892 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
893 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
894 matching a pp-number. Rename parameter var to var1.
895
127827c0
SM
8962011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
897
898 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
899
c8fd3bd0
GM
9002011-10-08 Glenn Morris <rgm@gnu.org>
901
902 * callint.c (Fcall_interactively): Give a more explicit error for the
903 'c' case with a non-character input. (Bug#8479)
904
352ec8ff
EZ
9052011-10-08 Eli Zaretskii <eliz@gnu.org>
906
03669ccb
EZ
907 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
908 lines.
7061c986
EZ
909 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
910 lines that are hscrolled on the left.
03669ccb 911
352ec8ff
EZ
912 * dispnew.c (buffer_posn_from_coords): Account for a possible
913 presence of header-line. (Bug#4426)
914
a66cfb1c
SM
9152011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
916
6b02f655
SM
917 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
918 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 919
7c5ee88e
PE
9202011-10-07 Paul Eggert <eggert@cs.ucla.edu>
921
922 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
923 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
924 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
925 this makes Emacs dump core during garbage collection on rare
926 occasions. sizeof is obviously inferior to offsetof here, so
927 stick with offsetof.
928 (GC_POINTER_ALIGNMENT): New macro.
929 (mark_memory): Omit 3rd (offset) arg; caller changed.
930 Don't assume EMACS_INT alignment is the same as pointer alignment.
931
df1bbe5b
SM
9322011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
933
934 * keyboard.c (read_key_sequence_remapped): New var.
935 (read_key_sequence): Compute remapping in the right buffer.
936 (command_loop_1): Use read_key_sequence's remapping directly.
937
51553db6
SM
9382011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
939
32c1fffd
SM
940 * dired.c (file_name_completion): Don't expand file name.
941 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
942 before checking file name handler.
943
51553db6
SM
944 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
945 they've been requested explicitly (bug#9591).
946
b6bd1599 9472011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
948
949 * keymap.c (Fsingle_key_description): Use make_specified_string
950 instead of build_string to build string from push_key_description.
951 (Bug#5193)
952
f701dc2a
PE
9532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
954
4222c55d
PE
955 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
956 This fixes a Y2038 bug on 64-bit hosts.
957 * buffer.c (reset_buffer):
958 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
959 (Fclear_buffer_auto_save_failure):
960 Use 0, not -1, to represent an unset failure time, since time_t
961 might not be signed.
962
f701dc2a
PE
963 Remove dependency on glibc malloc internals.
964 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
965 Move back here from lisp.h, but with their new implementations.
966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
967 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
968 * charset.c (charset_table_init): New static var.
969 (syms_of_charset): Use it instead of xmalloc. This removes a
970 dependency on glibc malloc internals. See Eli Zaretskii's comment in
971 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
972 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
973 Move back to alloc.c.
974 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
975 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
976
9ceebf39
JD
9772011-09-30 Jan Djärv <jan.h.d@swipnet.se>
978
979 * nsterm.m (windowDidResize): Call x_set_window_size only when
980 ns_in_resize is true. Otherwise set pixelwidth/height and
981 call change_frame_size (Bug#9628).
982
cb993c58
PE
9832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
984
3930c88b
PE
985 Port --enable-checking=all to Fedora 14 x86-64.
986 * charset.c (syms_of_charset): Also account for glibc malloc's
987 internal overhead when calculating the initial malloc maximum.
988
cb993c58
PE
989 Port --enable-checking=all to Fedora 14 x86.
990 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
991 Move to lisp.h.
992 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
993 (overrun_check_realloc, overrun_check_free):
994 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
995 That way, xmalloc returns a properly-aligned pointer even if
996 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
997 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
998 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
999 into account when calculating the initial malloc maximum.
1000 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1001 Move here from alloc.c, so that charset.c can use it too.
1002 Properly align; the old code wasn't right for common 32-bit hosts
1003 when configured with --enable-checking=all.
1004 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1005 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1006
31bed486
EZ
10072011-09-29 Eli Zaretskii <eliz@gnu.org>
1008
04c70788 1009 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1010 use EDOM.
1011
fbcaa2f3
EZ
10122011-09-28 Eli Zaretskii <eliz@gnu.org>
1013
1014 * xdisp.c (compute_display_string_end): If there's no display
1015 string at CHARPOS, return -1.
1016
1017 * bidi.c (bidi_fetch_char): When compute_display_string_end
1018 returns a negative value, treat the character as a normal
1019 character not covered by a display string. (Bug#9624)
1020
a239d4e9
JB
10212011-09-28 Juanma Barranquero <lekktu@gmail.com>
1022
1023 * lread.c (Fread_from_string): Fix typo in docstring.
1024
88652fd5
EZ
10252011-09-27 Eli Zaretskii <eliz@gnu.org>
1026
1027 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1028 newline, reseat the iterator instead of bidi-iterating there one
1029 character at a time. (Bug#9610)
32c1fffd
SM
1030 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1031 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1032
ed497dd4
AS
10332011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1034
1035 * lread.c (readevalloop): Use correct code for NBSP.
1036 (read1): Likewise. (Bug#9608)
1037
b2bf61aa
MA
10382011-09-25 Michael Albinus <michael.albinus@gmx.de>
1039
1040 * dbusbind.c (Fdbus_register_signal): When service is not
1041 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1042
32bbb17c
GM
10432011-09-25 Glenn Morris <rgm@gnu.org>
1044
1045 * buffer.c (truncate-lines): Doc fix.
1046
94e0933e
CY
10472011-09-24 Chong Yidong <cyd@stupidchicken.com>
1048
1049 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1050 (Fset_window_next_buffers): Doc fix.
1051
cddde921
GM
10522011-09-24 Glenn Morris <rgm@gnu.org>
1053
1054 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1055
1260aef1
PE
10562011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1057
25b4bfa0
PE
1058 Fix minor problems found by static checking.
1059 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1060 * indent.c (Fvertical_motion): Fix == vs = typo.
1061
e3cbd34b
EZ
10622011-09-24 Eli Zaretskii <eliz@gnu.org>
1063
a66cfb1c
SM
1064 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1065 Default value is now t. Doc fix.
6bf7006f 1066
e3cbd34b 1067 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1068 logic when moving up, not only when moving down. Fix the
e3cbd34b 1069 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1070 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1071
1072 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1073 CHARPOS is covered by a display string which includes newlines.
1074 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1075 is covered by a display string with embedded newlines.
1076
a3de0cbd
MA
10772011-09-24 Michael Albinus <michael.albinus@gmx.de>
1078
1079 * dbusbind.c (Fdbus_register_signal): Add match rule to
1080 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1081 (Fdbus_register_method, Vdbus_registered_objects_table):
1082 Fix docstring.
a3de0cbd 1083
b260039d
JM
10842011-09-24 Jim Meyering <meyering@redhat.com>
1085
32c1fffd 1086 do not ignore write error for any output size
b260039d
JM
1087 The previous change was incomplete.
1088 While it makes emacs --batch detect the vast majority of stdout
1089 write failures, errors were still ignored whenever the output size is
1090 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1091 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1092 && echo FAIL: ignored write error
1093 FAIL: ignored write error
1094 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1095 && echo FAIL: ignored write error
1096 FAIL: ignored write error
1097 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1098
8eca8a7c
AS
10992011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1100
1101 * emacs.c (Fkill_emacs): In noninteractive mode exit
1102 non-successfully if a write error occurred on stdout. (Bug#9574)
1103
3341db62
EZ
11042011-09-21 Eli Zaretskii <eliz@gnu.org>
1105
1106 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1107 the xassert test.
1108
1109 * dispextern.h (struct it): Update the comment documenting what
1110 can it->OBJECT be.
1111
8c203dbf
EZ
11122011-09-20 Eli Zaretskii <eliz@gnu.org>
1113
1114 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1115 a display string, extend search for cursor position to end of row.
1116 (find_row_edges): If the row ends in a newline from a display
1117 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1118 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1119 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1120 non-empty line. Fixes confusing cursor motion with arrow keys at
1121 the beginning of a line that starts with whitespace.
8c203dbf 1122
a4824228
LMI
11232011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1124
1125 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1126 (bug#9493).
1127
33ed493b
CY
11282011-09-18 Chong Yidong <cyd@stupidchicken.com>
1129
1130 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1131 boolean (Bug#9154).
1132
56cd55c8
EZ
11332011-09-18 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (display_line): Record maximum and minimum buffer
1136 positions even if no glyphs were produced (e.g., by a zero-width
1137 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1138 buffer positions that will be removed from the glyph row because
1139 they don't fit.
c02dcedf
EZ
1140 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1141 column is beyond frame width: don't subtract 1 "pixel" when
1142 computing width of the stretch.
3e62b7e0
EZ
1143 (reseat_at_next_visible_line_start): Undo the change made on
1144 2011-09-17 that saved paragraph information and restored it after
1145 the call to `reseat'. (Bug#9545)
56cd55c8 1146
5ed99d36 11472011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1148
1149 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1150 and turn window cursor on if cleared (Bug#9415).
1151
5ed99d36 11522011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1153
1154 * search.c (boyer_moore): Take unibyte characters from pattern
1155 literally. (Bug#9458)
1156
9bade7b2
EZ
11572011-09-18 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1160
e5e9d610
PE
11612011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1162
87e4427a
PE
1163 Fix minor problem found by static checking.
1164 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1165 initialized, to pacify gcc -Wuninitialized.
1166
e5e9d610
PE
1167 * fileio.c: Report proper errno when syscall falls.
1168 (Finsert_file_contents): Save and restore errno,
1169 so that report_file_error outputs the correct diagnostic.
1170 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1171
a1674f0b
EZ
11722011-09-18 Eli Zaretskii <eliz@gnu.org>
1173
1174 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1175
fbfb6dd4
EZ
11762011-09-17 Eli Zaretskii <eliz@gnu.org>
1177
1178 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1179 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1180
bb187662
EZ
11812011-09-17 Eli Zaretskii <eliz@gnu.org>
1182
1137e8b8 1183 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1184 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1185
1186 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1187 (bidi_find_paragraph_start): Search back for paragraph beginning
1188 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1189 (bidi_move_to_visually_next): Only trigger paragraph-related
1190 computations when the last character is a newline or at EOB, not
1191 just any NEUTRAL_B. (Bug#9470)
1192
bb187662
EZ
1193 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1194 truncated lines if point is covered by a display string. (Bug#9524)
1195
2e621251
PE
11962011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1199 (cons_to_x_long): New function.
1200 (lisp_data_to_selection_data): Use it. Correct the test for
1201 short-versus-long data; it was negated. Break out of vector
1202 loop, for efficiency, when a long datum is discovered.
1203
91a15bc6
SM
12042011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1205
1206 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1207
b41c3a35
EZ
12082011-09-16 Eli Zaretskii <eliz@gnu.org>
1209
1210 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1211 GCC PR/17406) by declaring this function with external scope.
1212
7812ba2d
PE
12132011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1214
1215 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1216 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1217
cf7edc2a
AS
12182011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1219
1220 * editfns.c (Fformat): Correctly handle text properties on "%%".
1221
bd01620e
EZ
12222011-09-15 Eli Zaretskii <eliz@gnu.org>
1223
1224 * xterm.c (x_draw_composite_glyph_string_foreground):
1225 * w32term.c (x_draw_composite_glyph_string_foreground):
1226 * term.c (encode_terminal_code):
1227 * composite.c (composition_update_it, get_composition_id):
1228 * xdisp.c (get_next_display_element)
1229 (fill_composite_glyph_string): Add comments about special meaning
1230 of TAB characters in a composition.
1231
a02719a3
PE
12322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1235 This occurs when processing a multibyte format.
1236 Problem reported by Wolfgang Jenker.
a02719a3 1237
72589a3c
JB
12382011-09-15 Johan Bockgård <bojohan@gnu.org>
1239
1240 * xdisp.c (try_cursor_movement): Only check for exact match if
1241 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1242
1c14176c
PE
12432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 Remove unused external symbols.
1246 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1247 * xdisp.c (calc_pixel_width_or_height): Now static.
1248 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1249 * indent.c (check_display_width):
1250 * w32term.c: Fix comment to match code.
1251 * xterm.c, xterm.h (x_catching_errors): Remove.
1252
d2eea5b5
PE
12532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 * xselect.c: Use signed conversions more consistently (Bug#9498).
1256 (selection_data_to_lisp_data): Assume incoming selection data are
1257 signed integers, not unsigned. This is to be consistent with
1258 outgoing selection data, which was modified to use signed integers
1259 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1260 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1261 expects long, not unsigned long.
1262
46888499
EZ
12632011-09-14 Eli Zaretskii <eliz@gnu.org>
1264
1265 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1266 computation of loop end. Reported by Johan Bockgård
1267 <bojohan@gnu.org>.
1268
ef8ef9fb
CY
12692011-09-13 Chong Yidong <cyd@stupidchicken.com>
1270
1271 * frame.c (Fother_visible_frames_p): Function deleted.
1272
fa819fed
EZ
12732011-09-12 Eli Zaretskii <eliz@gnu.org>
1274
1275 * indent.c (compute_motion): Process display vector front to back
1276 rather than the other way around. (Bug#2496)
1277
2ba8e008
SM
12782011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1279
1280 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1281
20f53c69
CY
12822011-09-11 Chong Yidong <cyd@stupidchicken.com>
1283
1284 * minibuf.c (Fread_from_minibuffer): Doc fix.
1285
d562d7a4
EZ
12862011-09-11 Eli Zaretskii <eliz@gnu.org>
1287
1288 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1289 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1290
1c4d7f3d
LMI
12912011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1292
1293 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1294 value for non-existent files.
1295
b885bf36
EZ
12962011-09-11 Eli Zaretskii <eliz@gnu.org>
1297
1298 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1299 set its "size" to -1. This will set the modtime_size field of
1300 the corresponding buffer to -1, which is what
1301 verify-visited-file-modtime expects for files that do not exist.
1302 (Bug#9139)
1303
6612f0bf
PE
13042011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1307 here ...
1308 * lisp.h: ... from here. push_key_description is no longer
1309 defined in keyboard.c, so its declaration should not be in
1310 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1311 logically belongs with push_key_description.
1312
dfb3f755
PE
13132011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 * buffer.h: Include <sys/types.h> instead of <time.h>.
1316 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1317 Problem reported by Herbert J. Skuhra.
1318
3134906c
LMI
13192011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1320
1321 * xml.c (parse_region): Make the parsing work for
1322 non-comment-starting XML files again (bug#9144).
1323
8d903f4e
AS
13242011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1325
1326 * image.c (gif_load): Fix calculation of bottom and right corner.
1327 (Bug#9468)
1328
80ad64f4
EZ
13292011-09-10 Eli Zaretskii <eliz@gnu.org>
1330
1331 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1332 redisplay in small windows.
1333
208a048d
EZ
13342011-09-09 Eli Zaretskii <eliz@gnu.org>
1335
1336 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1337
9b1c252e
MR
13382011-09-08 Martin Rudalics <rudalics@gmx.at>
1339
1340 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1341 Operate on live windows only.
1342
2949f33b
JB
13432011-09-08 Juanma Barranquero <lekktu@gmail.com>
1344
1345 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1346
e08dcafd
EZ
13472011-09-07 Eli Zaretskii <eliz@gnu.org>
1348
1349 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1350 only under bidi iteration.
1351
115b96bd
JD
13522011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1353
1354 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1355
c8199d0f
PE
13562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1359 Without this fix, the command to link temacs failed due to an
1360 undefined symbol __builtin_isnan. This is because
1361 /usr/include/iso/math_c99.h #defines isnan(x) to
1362 __builtin_isnan(x), but the bundled gcc, which identifies itself
1363 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1364 a __builtin_isnan.
1365 * floatfns.c (isnan): #undef, and then #define to a clone of
1366 what's in data.c.
1367 (Fisnan): Always define, since it's always available now.
1368 (syms_of_floatfns): Always define isnan at the Lisp level.
1369
e39b275c 13702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1371
1372 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1373
b2db44d9 13742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1375
f4af5137 1376 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1377 The previous code assumed that file offsets (off_t values) fit in
1378 EMACS_INT variables, which is not true on typical 32-bit hosts.
1379 The code messed up by falsely reporting buffer overflow in cases
1380 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1381 when "big" contains more than 2**29 bytes, even though this
1382 inserts just one byte and does not overflow the buffer.
1383 (Finsert_file_contents): Store file offsets as off_t
1384 values, not as EMACS_INT values. Check for overflow when
1385 converting between EMACS_INT and off_t. When checking for
1386 buffer overflow or for overlap, take the offsets into account.
1387 Don't use EMACS_INT for small values where int suffices.
1388 When checking for overlap, fix a typo: ZV was used where
1389 ZV_BYTE was intended.
1390 (Fwrite_region): Don't assume off_t fits into 'long'.
1391 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1392
ecfc0a49
MA
13932011-09-05 Michael Albinus <michael.albinus@gmx.de>
1394
1395 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1396
6511acf2 13972011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1398
0999621a 1399 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1400
1401 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1402 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1403 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1404 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1405 (modify_event_symbol): Do not assume that the length of
1406 name_alist_or_stem is safe to alloca and fits in int.
1407 (Fexecute_extended_command): Likewise for function name and binding.
1408 (Frecursion_depth): Wrap around reliably on integer overflow.
1409 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1410 since some callers pass EMACS_INT values.
1411 (Fsingle_key_description): Don't crash if symbol name contains more
1412 than MAX_ALLOCA bytes.
1413 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1414 (get_minibuffer): Arg is now EMACS_INT, not int.
1415 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1416 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1417 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1418
2be7d702
PE
1419 * dbusbind.c (signature_cat): New function.
1420 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1421 Do not overrun buffer; instead, report string overflow.
1422
9d1df220
PE
1423 * dispnew.c (add_window_display_history): Don't overrun buffer.
1424 Truncate instead; this is OK since it's just a log.
1425
33ef5c64
PE
1426 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1427 even if the time zone offset is outlandishly large.
1428 Don't mishandle offset == INT_MIN.
1429
66c6fdd5
PE
1430 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1431 when creating daemon; the previous buffer-overflow check was incorrect.
1432
d749b01b
PE
1433 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1434 which has the guts of the old verror function.
1435
b5cd1905
PE
1436 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1437 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1438
6e1a67fb
PE
1439 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1440 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1441 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1442 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1443 length of string rather than counting it via multiple sprintfs;
1444 that's simpler and more reliable.
c21721cc
PE
1445 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1446 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1447 sprintf, in case result does not fit in int.
1448
c57b67fc
PE
1449 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1450 (fontset_from_font): Print it.
1451
8a401434
PE
1452 * frame.c (tty_frame_count): Now printmax_t, not int.
1453 (make_terminal_frame, set_term_frame_name): Print it.
1454 (x_report_frame_params): In X, window IDs are unsigned long,
1455 not signed long, so print them as unsigned.
1456 (validate_x_resource_name): Check for implausibly long names,
1457 and don't assume name length fits in 'int'.
1458 (x_get_resource_string): Don't blindly alloca invocation name;
1459 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1460 not fit in int.
1461
6e1a67fb
PE
1462 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1463 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1464 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1465
0df02bf3
PE
1466 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1467 Use esprintf, not sprintf, in case result does not fit in int.
1468
48e30793
PE
1469 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1470 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1471 it as a large positive number.
1472 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1473 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1474
a66ff6d8
PE
1475 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1476 in case result does not fit in int.
1477
aca216ff
PE
1478 * print.c (float_to_string): Detect width overflow more reliably.
1479 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1480 buffer overrun. Don't assume list length fits in 'int'. Treat
1481 print length of 0 as 0, not as infinity; to be consistent with other
1482 uses of print length in this function. Don't overflow print length
1483 index. Don't assume hash table size fits in 'long', or that
1484 vectorlike size fits in 'unsigned long'.
1485
31c286f7
PE
1486 * process.c (make_process): Use printmax_t, not int, to format
1487 process-name gensyms.
1488
55e5faa1
PE
1489 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1490
80f2e268
PE
1491 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1492 to avoid potential buffer overrun.
1493
670741ab
PE
1494 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1495 if X resource line is longer than 512 bytes.
1496
b7163a50
PE
1497 * xfns.c (x_window): Make sprintf buffer a bit bigger
1498 to avoid potential buffer overrun.
1499
ae58ff1f
PE
1500 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1501
c43c8a6a
PE
1502 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1503
3f8236f4
PE
15042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1505
53e9fe90 1506 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1507 Without these, Emacs silently mishandles large integers sometimes.
1508 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1509 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1510
6511acf2
PE
1511 * xdisp.c (try_window_id): Check Emacs fixnum range before
1512 converting to 'int'.
806add1d 1513
6511acf2 1514 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1515 Check that an Emacs fixnum is in range before assigning it to 'int'.
1516 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1517 values converted from Emacs fixnums.
1518 (Frecenter): Don't wrap around a line count if it is out of 'int'
1519 range; instead, treat it as an extreme value.
1520 (Fset_window_configuration, compare_window_configurations):
1521 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1522
6511acf2
PE
1523 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1524 that can exceed INT_MAX. Check that EMACS_INT value is in range
1525 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1526 (match_limit): Don't assume that a fixnum can fit in 'int'.
1527
6511acf2 1528 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1529 exceed INT_MAX.
1530
6511acf2 1531 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1532 (Fvertical_motion): Don't wrap around LINES values that don't fit
1533 in 'int'. Instead, treat them as extreme values. This is good
1534 enough for windows, which can't have more than INT_MAX lines anyway.
1535
fcb901a7
LMI
15362011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1537
0f2f6b6d
LMI
1538 * Require libxml/parser.h to avoid compilation warning.
1539
fcb901a7
LMI
1540 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1541
1542 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1543 since this reportedly can destroy thread storage.
1544
6e20a0d4
CY
15452011-08-30 Chong Yidong <cyd@stupidchicken.com>
1546
1547 * syntax.c (find_defun_start): Update all cache variables if
1548 exiting early (Bug#9401).
1549
148ae00e
EZ
15502011-08-30 Eli Zaretskii <eliz@gnu.org>
1551
f6cfbd8f
EZ
1552 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1553
148ae00e
EZ
1554 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1555 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1556 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1557
1558 * term.c (tty_append_glyph): New function.
1559 (produce_stretch_glyph): Static function and its prototype deleted.
1560
a66cfb1c
SM
1561 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1562 Add prototypes.
148ae00e 1563
c4a07a4c
PE
15642011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1567 when checking :margin (Bug#9390).
1568 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1569 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1570 so that the name doesn't mislead. All uses changed.
1571
6bc8cd65
JB
15722011-08-28 Johan Bockgård <bojohan@gnu.org>
1573
1574 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1575 set_tty_hooks.
1576
dca4927e
EZ
15772011-08-27 Eli Zaretskii <eliz@gnu.org>
1578
1579 * xdisp.c (move_it_to): Don't bail out early when reaching
1580 position beyond to_charpos, if we are scanning backwards.
1581 (move_it_vertically_backward): When DY == 0, make sure we get to
1582 the first character in the line after the newline.
1583
f2cad773
PE
15842011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1587 (ccl_driver): Do not generate an out-of-range pointer.
1588 (Fccl_execute_on_string): Remove unnecessary check for
1589 integer overflow, noted by Stefan Monnier in
1590 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1591 Remove a FIXME that didn't need fixing.
1592 Simplify the newly-introduced buffer reallocation code.
1593
0cae2cdb
JB
15942011-08-27 Juanma Barranquero <lekktu@gmail.com>
1595
1596 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1597
5fc295a4 15982011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1599
70c60eb2 1600 Integer and memory overflow issues (Bug#9196).
726e0ab1 1601
d31850da
PE
1602 * doc.c (get_doc_string): Rework so that
1603 get_doc_string_buffer_size is the actual buffer size, rather than
1604 being 1 less than the actual buffer size; this makes xpalloc more
1605 convenient.
1606
a69fbedb
PE
1607 * image.c (x_allocate_bitmap_record, cache_image):
1608 * xselect.c (Fx_register_dnd_atom):
1609 Simplify previous changes by using xpalloc.
1610
fe5c5d37
PE
1611 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1612 since either will do and ptrdiff_t is convenient with xpalloc.
1613
0065d054
PE
1614 * charset.c (charset_table_size)
1615 (struct charset_sort_data.priority): Now ptrdiff_t.
1616 (charset_compare): Don't overflow if priorities differ greatly.
1617 (Fsort_charsets): Don't assume list length fits in int.
1618 Check for size-calculation overflow when allocating sort data.
1619 (syms_of_charset): Allocate an initial charset table that is
1620 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1621
1622 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1623
1624 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1625 The actual value is always <= INT_MAX, and leaving it unsigned made
1626 overflow checking harder.
1627
1628 * dispextern.h (struct glyph_matrix.rows_allocated)
1629 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1630 with xpalloc. The values are still always <= INT_MAX.
1631
1632 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1633
1634 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1635 (SAFE_NALLOCA): New macro.
1636
1637 * region-cache.c (struct boundary.pos, find_cache_boundary)
1638 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1639 (set_cache_region, invalidate_region_cache)
1640 (revalidate_region_cache, know_region_cache, region_cache_forward)
1641 (region_cache_backward, pp_cache):
1642 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1643 so that ptrdiff_t * can be passed to xpalloc.
1644 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1645 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1646 (pp_cache): Don't assume cache_len fits in int.
1647 * region-cache.h: Adjust extern decls to match.
1648
1649 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1650 EMACS_INT, since either will do, for xpalloc.
1651
1652 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1653 (xnmalloc, xnrealloc, xpalloc): New functions.
1654
726e0ab1
PE
1655 * bidi.c (bidi_shelve_header_size): New constant.
1656 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1657 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1658
51f30bc5 1659 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1660 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1661 (overlay_strings):
1662 Don't update size of array until after memory allocation succeeds,
1663 because xmalloc/xrealloc may not return.
0065d054
PE
1664 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1665 now that we have proper integer overflow checking.
1666 (record_overlay_string, overlay_strings): Catch overflows when
1667 calculating size of overlay_str_buf.
726e0ab1 1668
0065d054
PE
1669 * callproc.c (Fcall_process): Check for size overflow when
1670 calculating size of args2.
1671 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1672 Normally we prefer signed values, but sticking with ptrdiff_t would
1673 require adding more-complicated checks.
726e0ab1
PE
1674
1675 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1676 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1677 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1678 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1679
1680 * character.c (Fstring): Check for size-calculation overflow.
1681
1682 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1683 unnecessary integer overflow. Check for size overflow.
1684 (encode_coding_object): Don't update size until xmalloc succeeds.
1685
1686 * composite.c (get_composition_id): Check for overflow in glyph
1687 length calculations.
1688
1689 Integer and memory overflow fixes for display code.
1690 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1691 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1692 (scrolling_window): Check for overflow in size calculations.
1693 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1694 Don't assume glyph table len fits in int.
1695 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1696 (row_table_size): Now ptrdiff_t, not int.
1697 (scrolling_window): Avoid overflow in size calculations.
1698 Don't update size until allocation succeeds.
1699 * fns.c (concat): Check for overflow in size calculations.
1700 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1701 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1702 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1703
1704 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1705 (get_doc_string): Check for size calculation overflow.
1706 Don't update size until allocation succeeds.
1707 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1708 EMACS_INT, where ptrdiff_t will do.
1709 (Fsubstitute_command_keys): Check for string overflow.
1710
1711 * editfns.c (set_time_zone_rule): Don't assume environment length
1712 fits in int.
1713 (message_length): Now ptrdiff_t, not int.
1714 (Fmessage_box): Don't update size until allocation succeeds.
1715 Don't assume message length fits in int.
1716 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1717
0065d054
PE
1718 * emacs.c (main): Do not reallocate argv, since there is a null at
1719 the end that can be overwritten, and this way there's no need to
1720 worry about size-calculation overflow.
1721 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1722
1723 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1724 alloc succeeds.
1725 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1726
1727 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1728 (x_set_scroll_bar_width, x_figure_window_size):
1729 Check for integer overflow.
1730 (x_set_alpha): Do not assume XINT fits in int.
1731
1732 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1733 This is for the members text_lines, text_cols, total_lines, total_cols,
1734 where the system imposes an 'int' limit.
1735
1736 * fringe.c (Fdefine_fringe_bitmap):
1737 Don't update size until alloc works.
1738
1739 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1740 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1741
1742 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1743 Check for size-calculation overflow.
1744 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1745 do, as we prefer signed integers.
1746 (id_to_widget.max_size, id_to_widget.used)
1747 (xg_store_widget_in_map, xg_remove_widget_from_map)
1748 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1749 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1750 Use and return ptrdiff_t, not int.
1751 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1752 * gtkutil.h: Change prototypes to match the above.
1753
1754 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1755 are duplicate now that they've been promoted to lisp.h.
1756 (x_allocate_bitmap_record, x_alloc_image_color)
1757 (make_image_cache, cache_image, xpm_load):
1758 Don't update size until alloc is done.
1759 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1760 (x_detect_edges):
3256efce 1761 Check for size calculation overflow.
726e0ab1
PE
1762 (ct_colors_allocated_max): New constant.
1763 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1764 overflow.
3256efce 1765
726e0ab1
PE
1766 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1767 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1768 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1769 Use ptrdiff_t, not int, to count maps.
1770 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1771 calculations. Don't update size until allocation succeeds.
1772 Redo calculations to avoid overflow.
726e0ab1
PE
1773 * keyboard.h: Change prototypes to match the above.
1774
1775 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1776 to count maps.
1777 (current_minor_maps): Check for size calculation overflow.
1778 * keymap.h: Change prototypes to match the above.
1779
1780 * lread.c (read1, init_obarray): Don't update size until alloc done.
1781
1782 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1783 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1784
726e0ab1
PE
1785 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1786 Now ptrdiff_t, not int.
1787 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1788 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1789
1790 * process.c (Fnetwork_interface_list): Check for overflow
1791 in size calculation.
1792
1793 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1794
1795 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1796 overflow. Don't bother calling xmalloc when xrealloc will do.
1797
1798 * search.c (Freplace_match): Check for size calculation overflow.
1799 (Fset_match_data): Don't assume list lengths fit in 'int'.
1800
1801 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1802 for command line length. Do not attempt to address one before the
1803 beginning of an array, as that's not portable.
1804
1805 * term.c (max_frame_lines): Remove; unused.
1806 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1807 not int.
1808 (encode_terminal_code, calculate_costs): Check for size
1809 calculation overflow.
1810 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1811 table lengths and related sizes. Don't update size until alloc
1812 done. Redo calculations to avoid overflow.
1813 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1814
1815 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1816 subtracting pointers.
1817 (gobble_line): Check for overflow more carefully. Don't update size
1818 until alloc done.
1819
1820 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1821 Don't update size until alloc done.
1822 Redo size calculations to avoid overflow.
1823 Check for size calculation overflow.
0065d054 1824 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1825
1826 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1827 Use ptrdiff_t, not int, for sizes.
1828 (store_mode_line_noprop_char): Don't update size until alloc done.
1829
0065d054
PE
1830 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1831 Use ptrdiff_t, not int, for sizes.
1832 (Finternal_make_lisp_face, cache_face):
1833 Check for size calculation overflow.
1834 (cache_face): Treat size calculation overflows as if they were
1835 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1836
1837 * xfns.c (x_encode_text, x_set_name_internal)
1838 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1839 sizes, since they can exceed INT_MAX in size. Check for size
1840 calculation overflow.
1841
0065d054
PE
1842 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1843 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1844 Don't update size until alloc done.
1845
0065d054 1846 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1847 as sprintf is limited to int lengths.
1d526e2f 1848
252c5ee1
PE
1849 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1850 (X_LONG_MIN): New macros.
864d7ce7
PE
1851 Use them to make the following changes clearer.
1852 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1853 This change doesn't affect the value now, but it may help remind
1854 future maintainers not to raise the value too much later.
1855 (SELECTION_QUANTUM): Remove, replacing with ...
1856 (selection_quantum): ... new function, which avoids overflow.
1857 All uses changed.
1858 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1859 assumption that selection length fits in 'int'.
1860 (x_reply_selection_request, x_handle_selection_request)
1861 (x_get_window_property, receive_incremental_selection)
1862 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1863 (lisp_data_to_selection_data, clean_local_selection_data):
1864 Use ptrdiff_t, not int, to record length of selection.
1865 (x_reply_selection_request, x_get_window_property)
1866 (receive_incremental_selection, x_property_data_to_lisp):
1867 Redo calculations to avoid overflow.
1868 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1869 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1870 something.
1871 (x_get_window_property, receive_incremental_selection)
1872 (lisp_data_to_selection_data, x_property_data_to_lisp):
1873 Check for size-calculation overflow.
1874 (x_get_window_property, receive_incremental_selection)
1875 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1876 Don't store size until memory allocation succeeds.
1877 (x_get_window_property): Plug memory leak on memory exhaustion.
1878 Don't double-block input; malloc is safe here. Don't assume 2**34
1879 - 4 fits in unsigned long. Add an xassert to check
1880 XGetWindowProperty overflow. Be more careful about overflow
1881 calculations, and distinguish size from memory overflow better.
1882 (receive_incremental_selection): When tracing, don't assume
1883 unsigned int is less than INT_MAX.
1884 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1885 harmful) conversions of unsigned short to int.
1886 (lisp_data_to_selection_data): Don't assume that integers
1887 in the range -65535 through -1 fit in an X unsigned short.
1888 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1889 result parameters unless successful. Rely on cons_to_unsigned
1890 to report problems with elements; the old code wasn't right anyway.
1891 (x_check_property_data): Check for int overflow; we cannot use
1892 a wider type due to X limits.
1893 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1894
726e0ab1 1895 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1896
0065d054
PE
1897 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1898 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1899 (x_color_cells): Don't store size until memory allocation succeeds.
1900 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1901 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1902 (x_term_init): Don't assume length fits in int (sprintf is limited
1903 to int size).
bc18e09d 1904
ebfa62c0
PE
1905 Use ptrdiff_t for composition IDs.
1906 * character.c (lisp_string_width):
1907 * composite.c (composition_table_size, n_compositions)
1908 (get_composition_id, composition_gstring_from_id):
1909 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1910 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1911 * window.c (Frecenter):
1912 Use ptrdiff_t, not int, for composition IDs.
1913 * composite.c (get_composition_id): Check for integer overflow.
1914 * composite.h: Adjust prototypes to match the above changes.
1915
d3411f89
PE
1916 Use ptrdiff_t for hash table indexes.
1917 * category.c (hash_get_category_set):
1918 * ccl.c (ccl_driver):
1919 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1920 * coding.c (coding_system_charset_list, detect_coding_system):
1921 * coding.h (struct coding_system.id):
1922 * composite.c (get_composition_id, gstring_lookup_cache):
1923 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1924 * image.c (xpm_get_color_table_h):
1925 * lisp.h (hash_lookup, hash_put):
1926 * minibuf.c (Ftest_completion):
1927 Use ptrdiff_t for hash table indexes, not int (which is too
1928 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1929 32-bit --with-wide-int hosts).
1930
e097a6fa
PE
1931 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1932 Add a FIXME comment about memory leaks.
1933 (syms_of_charset): Don't assume xmalloc returns.
1934
5637687f
PE
1935 Don't assume that stated character widths fit in int.
1936 * character.c (Fchar_width, c_string_width, lisp_string_width):
1937 * character.h (CHAR_WIDTH):
1938 * indent.c (MULTIBYTE_BYTES_WIDTH):
1939 Use sanitize_char_width to avoid undefined and/or bad behavior
1940 with outlandish widths.
a66cfb1c 1941 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1942 now that we have two such functions. All uses changed.
1943 (sanitize_char_width): New inline function.
1944
a2271ba2
PE
1945 Don't assume that tab-width fits in int.
1946 * character.h (sanitize_width): New inline function.
1947 (SANE_TAB_WIDTH): New macro.
1948 (ASCII_CHAR_WIDTH): Use it.
1949 * indent.c (sane_tab_width): Remove. All uses replaced by
1950 SANE_TAB_WIDTH (current_buffer).
1951 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1952
18c52557
PE
1953 * fileio.c: Integer overflow issues with file modes.
1954 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1955
caeeedc1
PE
1956 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1957 Remove unreachable code.
1958 (read_hex, load_charset_map_from_file): Check for integer overflow.
1959
50849c52
PE
1960 * xterm.c: don't go over XClientMessageEvent limit
1961 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1962 (x_send_scroll_bar_event): Likewise. Check that the size does not
1963 exceed limits imposed by XClientMessageEvent, as well as the usual
1964 ptrdiff_t and size_t limits.
1965
b13995db
PE
1966 * keyboard.c: Overflow, signedness and related fixes.
1967 (make_lispy_movement): Use same integer type in forward decl
1968 that is used in the definition.
1969 (read_key_sequence, keyremap_step):
1970 Change bufsize argument back to int, undoing my 2011-03-30 change.
1971 We prefer signed types, and int is wide enough here.
1972 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1973 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1974 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1975 length, not size_t. Use ptrdiff_t for index, not int.
1976 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1977 possibility of integer overflow.
1978
13464394
PE
1979 Overflow, signedness and related fixes for images.
1980
1981 * dispextern.h (struct it.stack[0].u.image.image_id)
1982 (struct_it.image_id, struct image.id, struct image_cache.size)
1983 (struct image_cache.used, struct image_cache.ref_count):
1984 * gtkutil.c (update_frame_tool_bar):
1985 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1986 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1987 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1988 * nsmenu.m (update_frame_tool_bar):
1989 * xdisp.c (calc_pixel_width_or_height):
1990 * xfns.c (image_cache_refcount):
1991 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1992 on typical 64-bit hosts.
1993
1994 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1995 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1996 Omit unnecessary casts to int.
1997 (parse_image_spec): Check that integers fall into 'int' range
1998 when the callers expect that.
1999 (image_ascent): Redo ascent calculation to avoid int overflow.
2000 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2001 (lookup_image): Remove unnecessary tests.
2002 (xbm_image_p): Locals are now of int, not EMACS_INT,
2003 since parse_image_check makes sure they fit into int.
2004 (png_load, gif_load, svg_load_image):
2005 Prefer int to unsigned where either will do.
2006 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2007 old tiff_error_handler and tiff_warning_handler.
2008 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2009 stack buffer overflows. It uses only the features of vsnprintf
2010 that are common to both POSIX and native Microsoft.
2011 (tiff_error_handler, tiff_warning_handler): Use it.
2012 (tiff_load, gif_load, imagemagick_load_image):
2013 Don't assume :index value fits in 'int'.
2014 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2015 (imagemagick_load_image): Check that crop parameters fit into
2016 the integer types that MagickCropImage accepts. Don't assume
2017 Vimagemagick_render_type has a nonnegative value. Don't assume
2018 size_t fits in 'long'.
2019 (gs_load): Use printmax_t to print the widest integers possible.
2020 Check for integer overflow when computing image height and width.
2021
c11821d4
EZ
20222011-08-26 Eli Zaretskii <eliz@gnu.org>
2023
2024 * xdisp.c (redisplay_window): Don't force window start if point
2025 will be invisible in the resulting window. (Bug#9324)
2026
0c95fcf7
EZ
20272011-08-25 Eli Zaretskii <eliz@gnu.org>
2028
2029 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2030 the display spec is of the form `(space ...)'.
2031 (handle_display_spec): Return the value returned by
2032 handle_single_display_spec, not just 1 or zero.
2033 (handle_single_display_spec): If the display spec is of the form
2034 `(space ...)', and specifies display in the text area, return 2
2035 rather than 1.
fee65a97 2036 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2037 accurately, and prefer exact match for point under bidi.
2038 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2039
2040 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2041 into disp_prop; all users changed.
2042
2043 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2044 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2045 for the text covered by the display property.
2046
e4ed06f1
CY
20472011-08-25 Chong Yidong <cyd@stupidchicken.com>
2048
2049 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2050 Change return value to nil.
2051 (Frecord_buffer): Delete unused function.
2052
f67cdd7f
EZ
20532011-08-24 Eli Zaretskii <eliz@gnu.org>
2054
5980d4c6
EZ
2055 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2056 buffers, return left-to-right.
8610fe8b
EZ
2057 (set_cursor_from_row): Consider candidate row a win if its glyph
2058 represents a newline and point is on that newline. Fixes cursor
2059 positioning on the newline at EOL of R2L text within L2R
2060 paragraph, and vice versa.
2061 (try_cursor_movement): Check continued rows, in addition to
2062 continuation rows. Fixes unwarranted scroll when point enters a
2063 continued line of R2L text within an L2R paragraph, or vice versa.
2064 (cursor_row_p): Consider the case of point being equal to
2065 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2066 from the end of a short line to the beginning of a continued line
2067 of R2L text within L2R paragraph.
2068 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2069 composed characters.
5980d4c6 2070
f67cdd7f
EZ
2071 * bidi.c (bidi_check_type): Use xassert.
2072 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2073 members.
2074
bca633fb
EZ
20752011-08-23 Eli Zaretskii <eliz@gnu.org>
2076
2077 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2078 a character.
2079
4a5885a7
CY
20802011-08-23 Chong Yidong <cyd@stupidchicken.com>
2081
2082 * nsfont.m (ns_otf_to_script): Fix typo.
2083
0902a04e
KH
20842011-08-22 Kenichi Handa <handa@m17n.org>
2085
2086 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2087 extra slot even if the purpose is char-code-property-table.
2088
1a2e6670
EZ
20892011-08-23 Eli Zaretskii <eliz@gnu.org>
2090
8ddde651
EZ
2091 * xdisp.c (redisplay_window): When computing centering_position,
2092 account for the height of the header line. (Bug#8874)
2093
425cc014
EZ
2094 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2095 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2096 candidate is selected by the mouse, and that candidate has a
2097 composed character under the mouse.
2098
1a2e6670
EZ
2099 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2100 coordinates reported by pos-visible-in-window-p for a composed
2101 character in column zero.
2102
8b76d6f8
SM
21032011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2104
2105 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2106
dac347dd
EZ
21072011-08-22 Eli Zaretskii <eliz@gnu.org>
2108
2109 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2110 consider it a hit if to_charpos is anywhere in the range of the
2111 composed buffer positions.
2112
e013fb34
CY
21132011-08-22 Chong Yidong <cyd@stupidchicken.com>
2114
2115 * image.c (gif_load): Don't assume that each subimage has the same
2116 dimensions as the base image. Handle disposal method that is
2117 "undefined" by the gif spec (Bug#9335).
2118
bd1ba3e8
CY
21192011-08-20 Chong Yidong <cyd@stupidchicken.com>
2120
2121 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2122 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2123
54a1215b
EZ
21242011-08-19 Eli Zaretskii <eliz@gnu.org>
2125
823564e5
EZ
2126 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2127 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2128 from an Org mode buffer to a Speedbar frame.
2129
54a1215b
EZ
2130 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2131 a composition, take its buffer position from IT->cmp_it.charpos.
2132 Fixes cursor positioning at the beginning of a line that begins
2133 with a composed character.
2134
9778ebcc
EZ
21352011-08-18 Eli Zaretskii <eliz@gnu.org>
2136
0be6ee06
EZ
2137 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2138 character bidirectional type, use STRONG_L instead. Fixes crashes
2139 in a buffer produced by `describe-categories'.
2140
9778ebcc
EZ
2141 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2142 members before the level stack, so they would be saved and
2143 restored when copying iterator state. Fixes incorrect reordering
2144 around TABs covered by display properties.
2145
156bffbe
AS
21462011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2147
6b02f655 2148 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2149
72ad093b
CY
21502011-08-17 Chong Yidong <cyd@stupidchicken.com>
2151
2152 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2153 (internal_condition_case_2, internal_condition_case_n):
2154 Remove unnecessary aborts (Bug#9081).
72ad093b 2155
35774242
EZ
21562011-08-17 Eli Zaretskii <eliz@gnu.org>
2157
2158 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2159 has no `load' handler, try opening the file locally. (Bug#9311)
2160
db76dd85
KB
21612011-08-16 Ken Brown <kbrown@cornell.edu>
2162
2163 * gmalloc.c: Expand comment.
2164
b215eee5
EZ
21652011-08-16 Eli Zaretskii <eliz@gnu.org>
2166
2167 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2168 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2169
a4579d33
KB
21702011-08-16 Ken Brown <kbrown@cornell.edu>
2171
2172 Fix memory allocation problems in Cygwin build (Bug#9273).
2173
2174 * unexcw.c ( __malloc_initialized): Declare external variable.
2175 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2176
8b76d6f8
SM
2177 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2178 New variables.
a4579d33
KB
2179 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2180 dumped emacs.
2181 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2182 in the static heap.
2183 [CYGWIN] (special_realloc): New function.
2184 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2185 requests to realloc storage in the static heap.
2186
3ebec551
PE
21872011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 * bidi.c (bidi_initialize): Remove unused local.
2190
9fd8be00
EZ
21912011-08-15 Eli Zaretskii <eliz@gnu.org>
2192
6b02f655
SM
2193 * bidimirror.h:
2194 * biditype.h: Remove file.
2195 * makefile.w32-in ($(BLD)/bidi.$(O)):
2196 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2197
2198 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2199
2200 * chartab.c: Improve commentary for the uniprop_table API.
2201
32413314
EZ
2202 * bidi.c (bidi_paragraph_init): Support zero value of
2203 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2204 (bidi_initialize): Use uniprop_table instead of including
2205 biditype.h and bidimirror.h.
32413314 2206
9fd8be00
EZ
2207 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2208 coordinates of the iterator when restoring from ppos_it.
2209 (Bug#9296)
2210
5cf2b69b
KH
22112011-08-14 Kenichi Handa <handa@m17n.org>
2212
2213 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2214 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2215
daf17d00
EZ
22162011-08-14 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (move_it_in_display_line_to): Don't invoke
2219 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2220 ppos_it. Fixes vertical cursor motion when line beginning is
2221 covered by an image. (Bug#9296)
2222
08e3161a
JD
22232011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2224
2225 * nsterm.h (ns_run_ascript): Declare.
2226 (NSAPP_DATA2_RUNASSCRIPT): Define.
2227
2228 * nsfns.m (as_script, as_result, as_status): New static variables.
2229 (ns_run_ascript): New function.
5e617bc2 2230 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2231 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2232 the event loop. Get status from as_status (Bug#7276).
2233
2234 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2235 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2236 the event loop (Bug#7276).
2237
a3720aa2
AS
22382011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2239
2240 * gnutls.c (QCgnutls_bootprop_priority)
2241 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2242 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2243 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2244 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2245 (QCgnutls_bootprop_verify_hostname_error)
2246 (QCgnutls_bootprop_callbacks_verify): Rename from
2247 Qgnutls_bootprop_..., all uses changed.
2248
2249 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2250 uses changed.
2251
0a0d27fb
PE
22522011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2253
19d5c50c
PE
2254 * xfaces.c (Qframe_set_background_mode): Now static.
2255 * dispextern.h (Qframe_set_background_mode): Remove decl.
2256
0a0d27fb
PE
2257 * process.c (Fnetwork_interface_info): Declare local only if needed.
2258
377538cb
JD
22592011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2260
2261 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2262 (Fnetwork_interface_list): Allocate in increments of bytes instead
2263 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2264 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2265 sockaddr.
2266 (struct ifflag_def): notrailers is smart on OSX.
2267 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2268 Get hardware address with getifaddrs if available.
2269
08fff70c
EZ
22702011-08-12 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xdisp.c (iterate_out_of_display_property): xassert that
2273 IT->position is set to within IT->object's boundaries. Break from
2274 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2275 when IT->position is set up wrongly due to some bug.
2276 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2277 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2278 entry. Force push_it to save on the stack the current
2279 buffer/string position, to be restored by pop_it. Fix flags in
2280 the iterator structure wrt the object coming from a display
2281 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2282 properties. (Bug#9284)
2283
7be1c708 22842011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2285
7be1c708
CY
2286 * fontset.c (fontset_get_font_group): Add proper type checks.
2287 (Bug#9172)
aac0c6e3 2288
7be1c708 22892011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2290
7be1c708
CY
2291 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2292 and LC_VERSION_MIN_MACOSX.
2293 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2294 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2295
97bb72a6
EZ
22962011-08-08 Eli Zaretskii <eliz@gnu.org>
2297
2298 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2299 no-display-properties-and-no-overlays under bidi display.
2300 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2301 properties and overlays.
97bb72a6 2302
d5617611
CY
23032011-08-08 Chong Yidong <cyd@stupidchicken.com>
2304
37e11a63
CY
2305 * editfns.c (Fset_time_zone_rule): Document relationship with the
2306 setenv function.
2307
d5617611
CY
2308 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2309 the font entity extracted from the cache (Bug#8109).
2310
58872834
CY
23112011-08-07 Chong Yidong <cyd@stupidchicken.com>
2312
2313 * composite.c (autocmp_chars): Don't reset point. That is done by
2314 restore_point_unwind (Bug#5984).
2315
75bfc667
JL
23162011-08-07 Juri Linkov <juri@jurta.org>
2317
2318 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2319 to show the arg `TIME' instead of `TIMEVAL'.
2320
d1410150
EZ
23212011-08-06 Eli Zaretskii <eliz@gnu.org>
2322
2323 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2324 display property strides EOL and includes a newline, as in
2325 longlines-mode. (Bug#9254)
75b771e4
EZ
2326 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2327 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2328
2329 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2330 is non-zero, even if the data buffer is NULL. Fixes a crash in
2331 vertical-motion with longlines-mode. (Bug#9254)
2332
35928349
EZ
23332011-08-05 Eli Zaretskii <eliz@gnu.org>
2334
ec7cc85b
EZ
2335 * bidi.c <bidi_cache_total_alloc>: Now static.
2336 (bidi_initialize): Initialize bidi_cache_total_alloc.
2337
8b76d6f8 2338 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2339 cache. (Bug#9221)
2340
2341 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2342 amount allocated this far in `bidi_cache_total_alloc'.
2343 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2344 non-zero, only free the data buffer without restoring the cache
2345 contents. All callers changed.
2346
2347 * dispextern.h (bidi_unshelve_cache): Update prototype.
2348
2349 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2350 (move_it_in_display_line, move_it_to)
2351 (move_it_vertically_backward, move_it_by_lines): Replace the call
2352 to xfree to an equivalent call to bidi_unshelve_cache.
2353 (move_it_in_display_line_to): Fix logic of returning
412b6358 2354 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2355
e2e2423b
EZ
23562011-08-05 Eli Zaretskii <eliz@gnu.org>
2357
2358 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2359 came from a string character with a `cursor' property. (Bug#9229)
2360
ae9e757a
JD
23612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2362
2363 * Makefile.in (LIB_PTHREAD): New variable.
2364 (LIBES): Add LIB_PTHREAD (Bug#9216).
2365
2366 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2367 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2368
213bd7f2
AS
23692011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2370
6b02f655 2371 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2372
99aaf75f
JD
23732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2374
2375 * xterm.c (x_find_topmost_parent): New function.
2376 (x_set_frame_alpha): Find topmost parent window with
2377 x_find_topmost_parent and set the property there also (bug#9181).
2378 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2379
c74e9d86
PE
23802011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 * callproc.c (Fcall_process): Avoid vfork clobbering
2383 the local vars buffer, coding_systems, current_dir.
2384
640c8776
SM
23852011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2386
2387 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2388
f26d0e4c
PE
23892011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2390
8a10d76c
PE
2391 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2392 so that it is not optimized away.
2393
f26d0e4c
PE
2394 * xdisp.c (compute_display_string_pos): Remove unused local.
2395
55439c61
EZ
23962011-08-02 Eli Zaretskii <eliz@gnu.org>
2397
2398 Fix slow cursor motion and scrolling in large buffers with
2399 selective display, like Org Mode buffers. (Bug#9218)
2400
2401 * dispextern.h (struct bidi_it): New member disp_prop_p.
2402
2403 * xdisp.c: Remove one-slot cache of display string positions.
2404 (compute_display_string_pos): Accept an additional argument
5e617bc2 2405 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2406 for a display string or property. If found, set DISP_PROP_P
2407 non-zero.
2408
2409 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2410 DISP_PROP_P, and pass it to compute_display_string_pos.
2411 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2412 non-zero. All callers of bidi_fetch_char changed.
2413
fb33fa43
SM
24142011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2415
2416 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2417
b099e063
DM
24182010-12-03 Don March <don@ohspite.net>
2419
2420 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2421 last character M-[char] is translated to ESC [char] (bug#7541).
2422
5cc7f7af
KH
24232011-08-02 Kenichi Handa <handa@m17n.org>
2424
d0fffa3f 2425 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2426
2427 * chartab.c (uniprop_table): Make it non-static.
2428
525d5e6e
EZ
24292011-08-01 Eli Zaretskii <eliz@gnu.org>
2430
2431 * xdisp.c (forward_to_next_line_start): Accept additional argument
2432 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2433 on the newline.
2434 (reseat_at_next_visible_line_start): Use the bidi iterator state
2435 returned by forward_to_next_line_start to restore the state of
2436 it->bidi_it after backing up to previous newline. (Bug#9212)
2437
31011111
AS
24382011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2439
2440 * regex.c (re_comp): Protoize.
2441 (re_exec): Fix return type.
2442 (regexec): Fix type of `ret'. (Bug#9203)
2443
476371c4
PE
24442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2445
e5d76069
PE
2446 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2447 This is needed if max-image-size is a floating-point number.
2448
9a79b20c
AS
24492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2450
2451 * print.c (print_object): Print empty symbol as ##.
2452
2453 * lread.c (read1): Read ## as empty symbol.
2454
d8c2fa78
AA
24552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2456
2457 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2458 setting frame foreground color (Bug#9175).
2459 (x_set_background_color): Likewise.
2460
ffe57a7a
AA
2461 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2462 contents (Bug#9176).
2463 (EmacsTooltip -init): Remove bezels and add shadows to
2464 tooltip windows.
2465
bf3492a5
AA
2466 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2467 or scroll bar (Bug#8470).
2468
d55e9c53
AA
2469 * nsfont.m (nsfont_open): Remove assignment to voffset and
2470 unnecessary vars hshink, expand, hd, full_height, min_height.
2471 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2472
2473 * nsterm.h (nsfont_info): Remove voffset field.
2474
d8c2fa78 24752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2476
2477 Implement strike-through and overline on NextStep (Bug#8863).
2478
2479 * nsfont.m (nsfont_open): Use underline position provided by font,
2480 instead of hard-coded value of 2.
2481 (nsfont_draw): Call ns_draw_text_decoration instead.
2482
2483 * nsterm.h: Add declaration for ns_draw_text_decoration.
2484
2485 * nsterm.m (ns_draw_text_decoration): New function for drawing
2486 underline, overline, and strike-through.
2487 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2488 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2489 accommodate underlining, etc.
4843aac3 2490
4cc60b9b
EZ
24912011-07-28 Eli Zaretskii <eliz@gnu.org>
2492
bc7ece87
EZ
2493 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2494 default.
4cc60b9b 2495
476371c4
PE
24962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2497
66606eea
PE
2498 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2499 Without this fix, if a signal arrives just after memory fills up,
2500 'malloc' might be invoked reentrantly.
2501
476371c4
PE
2502 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2503 In other words, assume that every image size is allowed, on non-X
2504 hosts. This assumption is probably wrong, but it lets Emacs compile.
2505
f3fcc40d
AS
25062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2507
2508 * regex.c (re_iswctype): Convert return values to boolean.
2509
350c992f
EZ
25102011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2511
2512 * xdisp.c (compute_display_string_pos): Don't use cached display
2513 string position if the buffer had its restriction changed.
2514 (Bug#9184)
2515
5266b4bb
PE
25162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2519
2573a837 25202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2521
41f55ccd 2522 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2523
39e378da
PE
2524 * bidi.c: Integer size and overflow fixes.
2525 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2526 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2527 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2528 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2529 (bidi_find_other_level_edge):
2530 Use ptrdiff_t instead of EMACS_INT where either will do.
2531 This works better on 32-bit hosts configured --with-wide-int.
2532 (bidi_cache_ensure_space): Check for size-calculation overflow.
2533 Use % rather than repeated addition, for better worst-case speed.
2534 Don't set bidi_cache_size until after xrealloc returns, because it
2535 might not return.
2536 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2537 (bidi_cache_ensure_space): Also check that the bidi cache size
2538 does not exceed that of the largest Lisp string or buffer. See Eli
2539 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2540
5e927815
PE
2541 * alloc.c (__malloc_size_t): Remove.
2542 All uses replaced by size_t. See Andreas Schwab's note
2543 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2544
ca4aa935
PE
2545 * image.c: Improve checking for integer overflow.
2546 (check_image_size): Assume that f is nonnull, since
2547 it is always nonnull in practice. This is one less thing to
2548 worry about when checking for integer overflow later.
2549 (x_check_image_size): New function, which checks for integer
2550 overflow issues inside X.
2551 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2552 This removes the need for a memory_full check.
2553 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2554 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2555 (xbm_read_bitmap_data): Change locals back to 'int', since
2556 their values must fit in 'int'.
2557 (xpm_load_image, png_load, tiff_load):
2558 Invoke x_create_x_image_and_pixmap earlier,
2559 to avoid much needless work if the image is too large.
2560 (tiff_load): Treat overly large images as if
2561 x_create_x_image_and_pixmap failed, not as malloc failures.
2562 (gs_load): Use x_check_image_size.
2563
5f8f9cc2
PE
2564 * gtkutil.c: Omit integer casts.
2565 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2566 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2567
5adf60bc
PE
2568 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2569
c8907a93
PE
2570 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2571 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2572 would wrongly return t on a 64-bit host.
2573
e3c25c68
PE
2574 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2575 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2576 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2577 and therefore cause GCC to emit a bogus diagnostic in some cases.
2578
3f791afe
PE
2579 * image.c: Integer signedness and overflow and related fixes.
2580 This is not an exhaustive set of fixes, but it's time to
2581 record what I've got.
2582 (lookup_pixel_color, check_image_size): Remove redundant decls.
2583 (check_image_size): Don't assume that arbitrary EMACS_INT values
2584 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2585 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2586 (tiff_load, imagemagick_load_image):
2587 Check for overflow in size calculations.
2588 (x_create_x_image_and_pixmap): Remove unnecessary test for
2589 xmalloc returning NULL; that can't happen.
2590 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2591 (xpm_color_bucket): Use better integer hashing function.
2592 (xpm_cache_color): Don't possibly over-allocate memory.
2593 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2594 (gif_memory_source):
2595 Use ptrdiff_t, not int or size_t, to record sizes.
2596 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2597 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2598 either works, as we prefer signed integers.
2599 (tiff_read_from_memory, tiff_write_from_memory):
2600 Return tsize_t, not size_t, since that's what the TIFF API wants.
2601 (tiff_read_from_memory): Don't fail simply because the read would
2602 go past EOF; instead, return a short read.
2603 (tiff_load): Omit no-longer-needed casts.
2604 (Fimagemagick_types): Don't assume size fits into 'int'.
2605
3cc5a532
PE
2606 Improve hashing quality when configured --with-wide-int.
2607 * fns.c (hash_string): New function, taken from sxhash_string.
2608 Do not discard information about ASCII character case; this
2609 discarding is no longer needed.
2610 (sxhash-string): Use it. Change sig to match it. Caller changed.
2611 * lisp.h: Declare it.
2612 * lread.c (hash_string): Remove, since we now use fns.c's version.
2613 The fns.c version returns a wider integer if --with-wide-int is
2614 specified, so this should help the quality of the hashing a bit.
2615
b312a492
PE
2616 * emacs.c: Integer overflow minor fix.
2617 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2618 Define only if GNU_LINUX.
2619 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2620
dfd153ae
PE
2621 * dispnew.c: Integer signedness and overflow fixes.
2622 Remove unnecessary forward decls, that were a maintenance hassle.
2623 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2624 All uses changed.
2625 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2626 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2627 (prepare_desired_row, line_draw_cost):
2628 Use int, not unsigned, where either works.
2629 (save_current_matrix, restore_current_matrix):
2630 Use ptrdiff_t, not size_t, where either works.
2631 (init_display): Check for overflow more accurately, and without
2632 relying on undefined behavior.
2633
a81d11a3
PE
2634 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2635 Remove, replacing with the new symbols in lisp.h. All uses changed.
2636 * fileio.c (make_temp_name):
2637 * filelock.c (lock_file_1, lock_file):
2638 * xdisp.c (message_dolog):
2639 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2640 Use pMd etc. instead.
2641 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2642 replacing the pWIDE etc. symbols removed from editfns.c.
2643
3300e6fd
PE
2644 * keyboard.h (num_input_events): Now uintmax_t.
2645 This is (very slightly) less likely to mess up due to wraparound.
2646 All uses changed.
2647
fd05c7e9
PE
2648 * buffer.c: Integer signedness fixes.
2649 (alloc_buffer_text, enlarge_buffer_text):
2650 Use ptrdiff_t rather than size_t when either will do, as we prefer
2651 signed integers.
2652
903fe15d
PE
2653 * alloc.c: Integer signedness and overflow fixes.
2654 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2655 (__malloc_size_t): Default to size_t, not to int.
2656 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2657 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2658 Prefer ptrdiff_t to size_t when either would do, as we prefer
2659 signed integers.
2660 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2661 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2662 Now const. Initialize with values that are in range even if char
2663 is signed.
2664 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2665 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2666 These functions do the right thing with sizes > 2**32.
2667 (check_depth): Now ptrdiff_t, not int.
2668 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2669 Adjust to new way of storing sizes. Check for size overflow bugs
2670 in rest of code.
2671 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2672 slightly wrong anyway, as it missed one instance of
2673 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2674 (refill_memory_reserve): Omit needless cast to size_t.
2675 (mark_object_loop_halt): Mark as externally visible.
2676
ac82cc6a
PE
2677 * xselect.c: Integer signedness and overflow fixes.
2678 (Fx_register_dnd_atom, x_handle_dnd_message):
2679 Use ptrdiff_t, not size_t, since we prefer signed.
2680 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2681 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2682 x_dnd_atoms_size and x_dnd_atoms_length.
2683
c2d1e36d
PE
2684 * doprnt.c: Prefer signed to unsigned when either works.
2685 * eval.c (verror):
2686 * doprnt.c (doprnt):
2687 * lisp.h (doprnt):
2688 * xdisp.c (vmessage):
2689 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2690 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2691 prefer signed arithmetic to avoid comparison confusion.
2692 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2693 but is a bit tricky.
2694
0e926e56
PE
2695 Assume freestanding C89 headers, string.h, stdlib.h.
2696 * data.c, doprnt.c, floatfns.c, print.c:
2697 Include float.h unconditionally.
2698 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2699 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2700 * regex.c: Likewise for stddef.h, string.h.
2701 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2702 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2703 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2704 (STDC_HEADERS): Remove obsolete defines.
2705 * sysdep.c: Include limits.h unconditionally.
2706
9cfdb3ec
PE
2707 Assume support for memcmp, memcpy, memmove, memset.
2708 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2709 * regex.c (memcmp, memcpy):
2710 Remove; we assume C89 now.
2711
2712 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2713 (__malloc_safe_bcopy): Remove; no longer needed.
2714
cf950e6b 2715 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2716 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2717 well either way, and we prefer signed to unsigned.
2718
dbf38e02
LMI
27192011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2720
2721 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2722 closes the connection while we're reading (bug#9182).
2723
d6f0886c 27242011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2725
d6f0886c
JD
2726 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2727 are specified (Bug#9168).
24e0f6b1 2728
2eb1f9e6
PE
27292011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2732 Found by GCC static checking and --with-wide-int on a 32-bit host.
2733
22381272 27342011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2735
2736 * xdisp.c (compute_display_string_pos): Fix logic of caching
2737 previous display string position. Initialize cached_prev_pos to
2738 -1. Fixes slow-down at the beginning of a buffer.
2739
f25e39b4
EZ
27402011-07-24 Eli Zaretskii <eliz@gnu.org>
2741
2742 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2743 for attrs[LFACE_FONTSET_INDEX].
2744
04c4b52e
PE
27452011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 * xml.c (parse_region): Remove unused local
2748 that was recently introduced.
2749
c1734fbd
EZ
27502011-07-23 Eli Zaretskii <eliz@gnu.org>
2751
be18c5a5
EZ
2752 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2753 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2754
c1734fbd
EZ
2755 * xdisp.c (move_it_in_display_line_to): Record the best matching
2756 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2757 exit if none of the characters scanned was an exact match.
2758 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2759 when exact match is impossible due to invisible text, and the
2760 lines are truncated.
2761
a258d627
JD
27622011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2763
2764 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2765 for OSX >= 10.7.
2766
b6d5a689
EZ
27672011-07-22 Eli Zaretskii <eliz@gnu.org>
2768
0f74f785
EZ
2769 Fix a significant slow-down of cursor motion with C-n, C-p,
2770 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2771 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2772 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2773 (next_element_from_buffer): Call compute_stop_pos_backwards to
2774 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2775 base_level_stop.
2776 (reseat): Don't look for prev_stop, as that could mean a very long
2777 run.
2778 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2779 <cached_disp_overlay_modiff>: Cache for last found display string
2780 position.
551918c1 2781 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2782 about the same buffer in the same area of character positions, and
2783 the buffer wasn't changed since the time the display string
2784 position was cached.
551918c1 2785
b2d0c91a
EZ
27862011-07-22 Eli Zaretskii <eliz@gnu.org>
2787
2788 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2789 is an integer, which is important for empty lines. (Bug#9149)
2790
043604ee
CY
27912011-07-22 Chong Yidong <cyd@stupidchicken.com>
2792
2793 * frame.c (Fmodify_frame_parameters): In tty case, update the
2794 default face if necessary (Bug#4238).
2795
da4adb04
CY
27962011-07-21 Chong Yidong <cyd@stupidchicken.com>
2797
2798 * editfns.c (Fstring_to_char): No need to explain what a character
2799 is in the docstring (Bug#6576).
2800
9abd0532
LMI
28012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2802
2803 * xml.c (parse_region): Make sure we always return a tree.
2804
36881d16
HK
28052011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2806
2807 * xml.c (parse_region): If a document contains only comments,
2808 return that, too.
2809
1e98674d
LMI
28102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2811
2812 * xml.c (make_dom): Return comments, too.
2813
590bd467
PE
28142011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2815
2816 Port to OpenBSD.
2817 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2818 and the surrounding thread.
2819 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2820 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2821 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2822 timer goes off.
2823 * s/openbsd.h (BROKEN_SIGIO): Define.
2824 * unexelf.c (unexec) [__OpenBSD__]:
2825 Don't update the .mdebug section of the Alpha COFF symbol table.
2826
f41628b2
LMI
28272011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2828
2829 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2830 (bug#8460).
2831
b59b67c5
PE
28322011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2833
15e3a074
PE
2834 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2835 This fixes some race conditions on the permissions of any newly
2836 created file.
2837
41bed37d
PE
2838 * alloc.c (valid_pointer_p): Use pipe, not open.
2839 This fixes some permissions issues when debugging.
2840
b59b67c5
PE
2841 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2842 If fchown fails to set both uid and gid, try to set just gid,
2843 as that is sometimes allowed. Adjust the file's mode to eliminate
2844 setuid or setgid bits that are inappropriate if fchown fails.
2845
925a6be7
SM
28462011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2847
2848 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2849 to compare Lisp_Objects.
2850 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2851 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2852 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2853
52968808
AS
28542011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2855
0a6a104b
AS
2856 * lread.c (read_integer): Unread even EOF character.
2857 (read1): Likewise. Properly record start position of symbol.
2858
52968808
AS
2859 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2860 symbol character follows.
2861
9e381cdd
PE
28622011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2865 This works around a problem with the previous change to Fcopy_file.
2866 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2867 and without this change, GCC might complain about discarding
2868 fchown's return value.
2869
b5641435
JB
28702011-07-16 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2873
a8031457
PE
28742011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2875
2876 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2877
dd889327
LMI
28782011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2879
750c33f7
LMI
2880 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2881 it's used from the C level.
2882
dd889327
LMI
2883 * process.c: Use the same condition for POLL_FOR_INPUT in both
2884 keyboard.c and process.c (bug#1858).
2885
87e86684
LM
28862011-07-09 Lawrence Mitchell <wence@gmx.li>
2887
2888 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2889 (Fgnutls_boot): Use it.
2890
64348f40
AS
28912011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2892
2893 * doc.c (Fsubstitute_command_keys): Revert last change.
2894
1d698799
LMI
28952011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2896
f863868c
LMI
2897 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2898 quotes the next character, and doesn't affect other longer
2899 sequences (bug#8935).
2900
1d698799
LMI
2901 * lread.c (syms_of_lread): Clarify that is isn't only
2902 `eval-buffer' and `eval-defun' that's affected by
2903 `lexical-binding' (bug#8460).
2904
aa4b6df6
EZ
29052011-07-15 Eli Zaretskii <eliz@gnu.org>
2906
2907 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2908 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2909
5d856da6
PE
29102011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2911
ad6042bb
PE
2912 Fix minor problems found by static checking.
2913 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2914 (elsz): Now a signed constant, not a size_t var. We prefer signed
2915 types to unsigned, to avoid integer comparison confusion. Without
2916 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2917 "cannot optimize loop, the loop counter may overflow", a symptom
2918 of the confusion.
f00bbb22 2919 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2920 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2921
6468f31c
LMI
29222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2923
49080b10
LMI
2924 * search.c (Fre_search_backward): Mention `case-fold-search' in
2925 all the re_search_* functions (bug#8138).
2926
6468f31c
LMI
2927 * keyboard.c (Fopen_dribble_file): Document when the file is
2928 closed (bug#8056).
2929
c965adc5
EZ
29302011-07-14 Eli Zaretskii <eliz@gnu.org>
2931
df9733bf
EZ
2932 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2933 bidi_cache_idx.
2934
0bb23927
EZ
2935 Support bidi reordering of display and overlay strings.
2936 * xdisp.c (compute_display_string_pos)
2937 (compute_display_string_end): Accept additional argument STRING.
2938 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2939 (reseat_to_string): Initialize bidi_it->string.s and
2940 bidi_it->string.schars.
2941 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2942 NULL (avoids a crash in bidi_paragraph_init).
2943 Initialize itb.string.lstring.
0bb23927
EZ
2944 (init_iterator): Call bidi_init_it only of a valid
2945 buffer position was specified. Initialize paragraph_embedding to
2946 L2R.
2947 (reseat_to_string): Initialize the bidi iterator.
2948 (display_string): If we need to ignore text properties of
2949 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2950 original value of -1 will not work with bidi.)
2951 (compute_display_string_pos): First arg is now struct
2952 `text_pos *'; all callers changed. Support display properties on
2953 Lisp strings.
2954 (compute_display_string_end): Support display properties on Lisp
2955 strings.
2956 (init_iterator, reseat_1, reseat_to_string): Initialize the
2957 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2958 when iterating on a string not from display properties).
640c8776
SM
2959 (compute_display_string_pos, compute_display_string_end):
2960 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2961 arrow keys.
2962 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2963 base_level_stop; instead, set base_level_stop to BEGV.
2964 Fixes crashes in vertical-motion.
0bb23927
EZ
2965 (next_element_from_buffer): Improve commentary for when
2966 the iterator is before prev_stop.
2967 (init_iterator): Initialize bidi_p from the default value of
2968 bidi-display-reordering, not from buffer-local value. Use the
2969 buffer-local value only if initializing for buffer iteration.
2970 (handle_invisible_prop): Support invisible properties on strings
2971 that are being bidi-reordered.
2972 (set_iterator_to_next): Support bidi reordering of C strings and
2973 Lisp strings.
2974 (next_element_from_string): Support bidi reordering of Lisp
2975 strings.
2976 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2977 (display_string): Support display of R2L glyph rows.
2978 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2979 (init_iterator): Don't initialize it->bidi_p for strings
2980 here.
2981 (reseat_to_string): Initialize it->bidi_p for strings here.
2982 (next_element_from_string, next_element_from_c_string)
2983 (next_element_from_buffer): Add xassert's for correspondence
2984 between IT's object being iterated and it->bidi_it.string
2985 structure.
2986 (face_before_or_after_it_pos): Support bidi iteration.
2987 (next_element_from_c_string): Handle the case of the first string
2988 character that is not the first one in the visual order.
2989 (get_visually_first_element): New function, refactored from common
2990 parts of next_element_from_buffer, next_element_from_string, and
2991 next_element_from_c_string.
2992 (tool_bar_lines_needed, redisplay_tool_bar)
2993 (display_menu_bar): Force left-to-right direction. Add a FIXME
2994 comment for making that be controlled by a user option.
2995 (push_it, pop_it): Save and restore the state of the
2996 bidi iterator. Save and restore the bidi_p flag.
2997 (pop_it): Iterate out of display property for string iteration as
2998 well.
2999 (iterate_out_of_display_property): Support iteration over strings.
3000 (handle_single_display_spec): Set up it->bidi_it for iteration
3001 over a display string, and call bidi_init_it.
3002 (handle_single_display_spec, next_overlay_string)
3003 (get_overlay_strings_1, push_display_prop): Set up the bidi
3004 iterator for displaying display or overlay strings.
3005 (forward_to_next_line_start): Don't use the shortcut if
3006 bidi-iterating.
3007 (back_to_previous_visible_line_start): If handle_display_prop
3008 pushed the iterator stack, restore the internal state of the bidi
3009 iterator by calling bidi_pop_it same number of times.
3010 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3011 and we are bidi-iterating, don't decrement the iterator position;
3012 instead, set the first_elt flag in the bidi iterator, to produce
3013 the same effect.
3014 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3015 (push_display_prop): xassert that we are iterating a buffer.
3016 (push_it, pop_it): Save and restore paragraph_embedding member.
3017 (handle_single_display_spec, next_overlay_string)
3018 (get_overlay_strings_1, reseat_1, reseat_to_string)
3019 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3020 correctly. Don't assume unibyte strings are not bidi-reordered.
3021 (compute_display_string_pos)
3022 (compute_display_string_end): Fix handling the case of C string.
3023 (push_it, pop_it): Save and restore from_disp_prop_p.
3024 (handle_single_display_spec, push_display_prop): Set the
3025 from_disp_prop_p flag.
3026 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3027 (pop_it): Call iterate_out_of_display_property only if we are
3028 popping after iteration over a string that came from a display
3029 property. Fix a typo in popping stretch info. Add an assertion
3030 for verifying that the iterator position is in sync with the bidi
3031 iterator.
3032 (handle_single_display_spec, get_overlay_strings_1)
3033 (push_display_prop): Fix initialization of paragraph direction for
3034 string when that of the parent object is not yet determined.
3035 (reseat_1): Call bidi_init_it to resync the bidi
3036 iterator with IT's position. (Bug#7616)
3037 (find_row_edges): If ROW->start.pos gives position
3038 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3039 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3040 Reset the from_disp_prop_p flag.
3041 (SAVE_IT, RESTORE_IT): New macros.
3042 (pos_visible_p, face_before_or_after_it_pos)
3043 (back_to_previous_visible_line_start)
3044 (move_it_in_display_line_to, move_it_in_display_line)
3045 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3046 (try_scrolling, redisplay_window, display_line): Use them when
3047 saving a temporary copy of the iterator and restoring it back.
3048 (back_to_previous_visible_line_start, reseat_1)
3049 (init_iterator): Empty the bidi cache "stack".
3050 (move_it_in_display_line_to): If iterator ended up at
3051 EOL, but we never saw any buffer positions smaller than
3052 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3053 motion in bidi-reordered lines.
3054 (move_it_in_display_line_to): Record prev_method and prev_pos
3055 immediately before the call to set_iterator_to_next. Fixes cursor
3056 motion in bidi-reordered lines with stretch glyphs and strings
3057 displayed in margins. (Bug#8133) (Bug#8867)
3058 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3059 TO_CHARPOS.
640c8776
SM
3060 (pos_visible_p): Support positions in bidi-reordered lines.
3061 Save and restore bidi cache.
0bb23927
EZ
3062
3063 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3064 (bidi_paragraph_info): Delete unused struct.
3065 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3066 (bidi_cache_start): New variable.
3067 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3068 to zero.
3069 (bidi_cache_fetch_state, bidi_cache_search)
3070 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3071 (bidi_cache_find, bidi_peek_at_next_level)
3072 (bidi_level_of_next_char, bidi_find_other_level_edge)
3073 (bidi_move_to_visually_next): Compare cache index with
3074 bidi_cache_start rather than with zero.
3075 (bidi_fetch_char): Accept new argument STRING; all callers
3076 changed. Support iteration over a string. Support strings with
3077 display properties. Support unibyte strings. Fix the type of
3078 `len' according to what STRING_CHAR_AND_LENGTH expects.
3079 (bidi_paragraph_init, bidi_resolve_explicit_1)
3080 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3081 (bidi_level_of_next_char, bidi_move_to_visually_next):
3082 Support iteration over a string.
0bb23927
EZ
3083 (bidi_set_sor_type, bidi_resolve_explicit_1)
3084 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3085 can now be zero (for strings); special values 0 and -1 were
3086 changed to -1 and -2, respectively.
3087 (bidi_char_at_pos): New function.
3088 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3089 Call it instead of FETCH_MULTIBYTE_CHAR.
3090 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3091 initialized to valid values.
3092 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3093 values.
3094 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3095 the test for valid cached positions. Fix the logic for looking up
3096 the sentinel state in the cache. GCPRO the Lisp string we are
3097 iterating.
3098 (bidi_push_it, bidi_pop_it): New functions.
3099 (bidi_initialize): Initialize the bidi cache start stack pointer.
3100 (bidi_cache_ensure_space): New function, refactored from part of
3101 bidi_cache_iterator_state. Don't assume the required size is just
3102 one BIDI_CACHE_CHUNK away.
3103 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3104 (bidi_count_bytes, bidi_char_at_pos): New functions.
3105 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3106 always valid if bidi_cache_idx is valid.
3107 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3108 is valid if it's going to be used.
3109 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3110 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3111 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3112 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3113 (bidi_find_other_level_edge, bidi_cache_start_stack):
3114 All variables related to cache indices are now EMACS_INT.
c965adc5 3115
0bb23927
EZ
3116 * dispextern.h (struct bidi_string_data): New structure.
3117 (struct bidi_it): New member `string'. Make flag members be 1-bit
3118 fields, and put them last in the struct.
640c8776
SM
3119 (compute_display_string_pos, compute_display_string_end):
3120 Update prototypes.
0bb23927
EZ
3121 (bidi_push_it, bidi_pop_it): Add prototypes.
3122 (struct iterator_stack_entry): New members bidi_p,
3123 paragraph_embedding, and from_disp_prop_p.
3124 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3125 (bidi_shelve_cache, bidi_unshelve_cache):
3126 Declare prototypes.
0bb23927
EZ
3127
3128 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3129 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3130 and vector-like objects.
3131
3132 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3133 cache around display iteration.
3134
3135 * window.c (Fwindow_end, window_scroll_pixel_based)
3136 (displayed_window_lines, Frecenter): Save and restore the bidi
3137 cache around display iteration.
3138
3bbd2265
LMI
31392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3140
3141 * editfns.c (Fdelete_region): Clarify the use of the named
3142 parameters (bug#6788).
3143
adc47434
MR
31442011-07-14 Martin Rudalics <rudalics@gmx.at>
3145
3146 * indent.c (Fvertical_motion): Set and restore w->pointm when
3147 saving and restoring the window's buffer (Bug#9006).
3148
837c31f8
LMI
31492011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3150
3151 * editfns.c (Fstring_to_char): Clarify just what is returned
3152 (bug#6576). Text by Eli Zaretskii.
3153
ac389d0c
JB
31542011-07-13 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3157
0be0ce47
EZ
31582011-07-13 Eli Zaretskii <eliz@gnu.org>
3159
3160 * buffer.c (mmap_find): Fix a typo.
3161
cd18e7e3
JB
31622011-07-13 Johan Bockgård <bojohan@gnu.org>
3163
3164 Fix execution of x selection hooks.
3165 * xselect.c (Qx_lost_selection_functions)
3166 (Qx_sent_selection_functions): New vars.
3167 (syms_of_xselect): DEFSYM them.
3168 (x_handle_selection_request): Pass Qx_sent_selection_functions
3169 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3170 (x_handle_selection_clear,x_clear_frame_selections):
3171 Pass Qx_lost_selection_functions rather than
3172 Vx_lost_selection_functions to Frun_hook_with_args.
3173
47ea7f44
PE
31742011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3175
ac389d0c 3176 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3177 The old code sometimes used this field without initializing it.
3178
47ea7f44
PE
3179 * alloc.c (gc_sweep): Don't read past end of array.
3180 In theory, the old code could also have corrupted Emacs internals,
3181 though it'd be very unlikely.
3182
bc985c87
AS
31832011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3184
3185 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3186 argument. (Bug#4026)
bc985c87 3187
0cf34688
LMI
31882011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3189
b3dadd76
LMI
3190 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3191 key" (bug#4257).
3192
0cf34688
LMI
3193 * window.c (Fset_window_start): Doc fix (bug#4199).
3194 (Fset_window_hscroll): Ditto.
3195
270768cd
PE
31962011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3197
077e3dda 3198 Fix minor new problems caught by GCC 4.6.1.
270768cd 3199 * term.c (init_tty): Remove unused local.
490011a6 3200 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3201 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3202 not used otherwise.
270768cd 3203
b1f58454
CY
32042011-07-12 Chong Yidong <cyd@stupidchicken.com>
3205
3206 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3207
22b9578d
LMI
32082011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3209
6e70ab07
LMI
3210 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3211 are the mini-buffer and the echo area (bug#3320).
3212
22b9578d
LMI
3213 * term.c (init_tty): Remove support for supdup, c10 and perq
3214 terminals, which are no longer supported (bug#1482).
3215
8974cc9f
JB
32162011-07-10 Johan Bockgård <bojohan@gnu.org>
3217
3218 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3219
a560d974
JD
32202011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3221
3222 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3223 for non-popups (Bug#3642).
3224
1dae0f0a
AS
32252011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3226
268c2c36 3227 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3228 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3229 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3230 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3231 * data.c (fmod): Likewise.
3232 * dispnew.c (swap_glyphs_in_rows): Likewise.
3233 * emacs.c (memory_warning_signal): Likewise.
3234 * floatfns.c (float_error): Likewise.
3235 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3236 (otf_open, font_otf_capability, generate_otf_features)
3237 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3238 Likewise.
3239 * image.c (pbm_read_file): Likewise.
3240 * indent.c (string_display_width): Likewise.
3241 * intervals.c (check_for_interval, search_for_interval)
3242 (inc_interval_count, count_intervals, root_interval)
3243 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3244 * lread.c (defalias): Likewise.
268c2c36 3245 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3246 * regex.c (set_image_of_range_1, set_image_of_range)
3247 (regex_grow_registers): Likewise.
3248 * sysdep.c (strerror): Likewise.
3249 * termcap.c (valid_filename_p, tprint, main): Likewise.
3250 * tparam.c (main): Likewise.
3251 * unexhp9k800.c (run_time_remap, save_data_space)
3252 (update_file_ptrs, read_header, write_header, calculate_checksum)
3253 (copy_file, copy_rest, display_header): Likewise.
3254 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3255 Likewise.
3256 * xdisp.c (check_it): Likewise.
3257 * xfaces.c (register_color, unregister_color, unregister_colors):
3258 Likewise.
3259 * xfns.c (print_fontset_result): Likewise.
3260 * xrdb.c (member, fatal, main): Likewise.
3261
99033785
PE
32622011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 Fix minor problems found by static checking (Bug#9031).
3265 * chartab.c (char_table_set_range, map_sub_char_table):
3266 Remove unused locals.
3267 (uniprop_table): Now static.
3268 * composite.c (_work_char): Remove unused static var.
3269
9cb2ac56
JB
32702011-07-09 Juanma Barranquero <lekktu@gmail.com>
3271
3272 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3273
f25661f0
JD
32742011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3275
3276 * gtkutil.c (qttip_cb): Remove code without function.
3277
8278c4fe
EZ
32782011-07-09 Eli Zaretskii <eliz@gnu.org>
3279
3280 * w32.c (pthread_sigmask): New stub.
3281
1692ae2d 32822011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3283
8a6ebd58 3284 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3285 sigprocmask is portable only for single-threaded applications, and
3286 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3287 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3288 (LIBES): Use it.
3289 * callproc.c (Fcall_process):
3290 * process.c (create_process):
3291 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3292 Use pthread_sigmask, not sigprocmask.
123403e4 3293
1b854618
JD
32942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3295
3296 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3297 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3298 wrong (Bug#8591).
3299
3fe4b549
JD
33002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3301
0ce7e563
JD
3302 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3303 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3304 (xg_hide_tooltip): Fix comment.
3305
3fe4b549
JD
3306 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3307 in registerServicesMenuSendTypes.
3308 (validRequestorForSendType): Don't check ns_return_types.
3309
3310 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3311 ns_return_type.
3312
5df75e47
JR
33132011-07-08 Jason Rumney <jasonr@gnu.org>
3314
22610910
JR
3315 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3316 SH_SHOW for hidden windows (Bug#5482).
3317
5df75e47
JR
3318 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3319 frame struct members of non-existent frames (Bug#6284).
3320
699c10bd
JD
33212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3322
4393663b
JD
3323 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3324 variable firstTime not needed on OSX >= 10.6.
3325 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3326 >= 10.5. Use setKnobProportion, setDoubleValue.
3327
3328 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3329 (MAC_OS_X_VERSION_10_5): Define if not defined.
3330 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3331 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3332 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3333
3334 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3335 cString and lossyCString on OSX >= 10.4
3336
58179cce 3337 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3338 sizeToFit on OSX >= 10.2.
3339
3340 * nsimage.m (allocInitFromFile): Don't use deprecated method
3341 bestRepresentationForDevice on OSX >= 10.6.
3342
3343 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3344 to avoid warning.
3345
3346 * emacs.c: Declare unexec_init_emacs_zone.
3347
a63e0781
JD
3348 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3349
699c10bd
JD
3350 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3351
3352 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3353 on svcsMenu (Bug#8842).
3354
3355 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3356 ns_return_types.
3357 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3358
3359 * nsterm.m (QUTF8_STRING): Declare.
3360 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3361 (validRequestorForSendType): Return type is (id).
3362 Change indexOfObjectIdenticalTo to indexOfObject.
3363 Check if we have local selection before returning self (Bug#8842).
3364 (writeSelectionToPasteboard): Put local selection into paste board
3365 if we have a local selection (Bug#8842).
3366 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3367
3368 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3369 (ns_get_local_selection): Declare.
3370
54e10184
LMI
33712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3372
9888ff71
LMI
3373 * keymap.c (describe_map_tree): Don't insert a double newline at
3374 the end of the buffer (bug#1169) and return whether we inserted
3375 something.
3376
54e10184
LMI
3377 * callint.c (Fcall_interactively): Change "reading args" to
3378 "providing args" to try to clarify what it does (bug#1010).
3379
15fa4783
KH
33802011-07-07 Kenichi Handa <handa@m17n.org>
3381
3382 * composite.c (composition_compute_stop_pos): Ignore a static
3383 composition starting before CHARPOS (Bug#8915).
3384
3385 * xdisp.c (handle_composition_prop): Likewise.
3386
a8815b00
EZ
33872011-07-07 Eli Zaretskii <eliz@gnu.org>
3388
3389 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3390 (Bug#9015)
3391
ef7b981d 33922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3393
3394 * character.h (unicode_category_t): New enum type.
3395
3396 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3397 (Qchar_code_property_table): New variable.
3398 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3399 (UNIPROP_COMPRESSED_FORM_P): New macros.
3400 (char_table_ascii): Uncompress the compressed values.
3401 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3402 Uncompress the compressed values.
ac389d0c 3403 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3404 (char_table_ref_and_range): Uncompress the compressed values.
3405 (sub_char_table_set): New arg is_uniprop. Callers changed.
3406 Uncompress the compressed values.
3407 (sub_char_table_set_range): Args changed. Callers changed.
3408 (char_table_set_range): Adjuted for the above change.
3409 (map_sub_char_table): Delete args default_val and parent. Add arg
3410 top. Give decoded values to a Lisp function.
640c8776 3411 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3412 values to a Lisp function. Gcpro more variables.
3413 (uniprop_table_uncompress)
3414 (uniprop_decode_value_run_length): New functions.
3415 (uniprop_decoder, uniprop_decoder_count): New variables.
3416 (uniprop_get_decoder, uniprop_encode_value_character)
3417 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3418 New functions.
3419 (uniprop_encoder, uniprop_encoder_count): New variables.
3420 (uniprop_get_encoder, uniprop_table)
3421 (Funicode_property_table_internal, Fget_unicode_property_internal)
3422 (Fput_unicode_property_internal): New functions.
3423 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3424 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3425 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3426 char-code-property-alist.
3427
640c8776 3428 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3429 Vunicode_category_table.
3430
640c8776 3431 * font.c (font_range): Adjust for the change of
c805dec0
KH
3432 Vunicode_category_table.
3433
76b397fb
DN
34342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3435
3436 * m/iris4d.h: Remove file, move contents ...
3437 * s/irix6-5.h: ... here.
3438
22b4128e
PE
34392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3442 * alloc.c (mark_buffer):
3443 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3444 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3445 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3446 This isn't true in general, and it's particularly not true
3447 if Emacs is configured with --with-wide-int.
3448 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3449 New macros, used in the buffer.c change.
3450
869795d6
JD
34512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3452
3453 * xsettings.c: Use both GConf and GSettings if both are available.
3454 (store_config_changed_event): Add comment.
3455 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3456 (store_tool_bar_style_changed): New functions.
5e617bc2 3457 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3458 (struct xsettings): Move font inside HAVE_XFT.
3459 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3460 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3461 Move inside HAVE_XFT.
640c8776 3462 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3463 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3464 also.
3465 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3466 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3467 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3468 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3469 (parse_settings): Move check for font inside HAVE_XFT.
3470 (read_settings, apply_xft_settings): Add comment.
3471 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3472 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3473 call store_font_name_changed.
3474 (xft_settings_event): Add comment.
3475 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3476 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3477 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3478 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3479 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3480 (xsettings_get_system_font, xsettings_get_system_normal_font):
3481 Add comment.
869795d6 3482
d8ed26bd
PE
34832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3484
3485 Random fixes. E.g., (random) never returned negative values.
3486 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3487 subseconds part to the entropy, as that's a bit more random.
3488 Prefer signed to unsigned, since the signedness doesn't matter and
3489 in general we prefer signed. When given a limit, use a
3490 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3491 latter isn't right if USE_2_TAGS_FOR_INTS.
3492 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3493 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3494
cabf1cac
SM
34952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3496
3497 * textprop.c (text_property_stickiness):
3498 Obey Vtext_property_default_nonsticky.
3499 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3500 * w32fns.c (syms_of_w32fns):
3501 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3502
6e9b2be9
PE
35032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3504
3505 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3506 This is more efficient than Ffile_directory_p and avoids a minor race.
3507
90186c68
LMI
35082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3509
7c301272
LMI
3510 * buffer.c (Foverlay_put): Say what the return value is
3511 (bug#7835).
3512
c4f2d8d4
LMI
3513 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3514 is a directory before asking whether to use the file name
3515 (bug#7564).
ad637907
LMI
3516 (barf_or_query_if_file_exists): Make the "File is a directory"
3517 error be more correct.
c4f2d8d4 3518
90186c68
LMI
3519 * fns.c (Frequire): Remove the mention of the .gz files, since
3520 that's installation-specific, but keep the mention of
3521 `get-load-suffixes'.
3522
da64016e
PE
35232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3526 Report string overflow if the output is too long.
3527
7d47b580
JB
35282011-07-04 Juanma Barranquero <lekktu@gmail.com>
3529
a555cb87
JB
3530 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3531 (syms_of_gnutls): Remove duplicate DEFSYM for
3532 Qgnutls_bootprop_verify_hostname_error, an error for
3533 Qgnutls_bootprop_verify_error (which is no longer used).
3534
7d47b580
JB
3535 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3536 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3537 Also (re)move comments that are misplaced or no longer relevant.
3538
1e49bfab
LMI
35392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3540
3541 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3542
1485f4c0
CY
35432011-07-03 Chong Yidong <cyd@stupidchicken.com>
3544
3545 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3546 and background color parameters if they have been changed.
3547
a9ab721e
LMI
35482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3549
3550 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3551
cf7cff57
PE
35522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3553
2e13213d
PE
3554 * xsettings.c (SYSTEM_FONT): Define only when used.
3555 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3556
cf7cff57
PE
3557 * keymap.c (access_keymap_1): Now static.
3558
7a8e04f7
CY
35592011-07-02 Chong Yidong <cyd@stupidchicken.com>
3560
3561 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3562 leave any prefix arg for the up event (Bug#1586).
3563
61352f62
LMI
35642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3565
69bb1ef7
LMI
3566 * lread.c (syms_of_lread): Mention single symbols defined by
3567 `defvar' or `defconst' (bug#7154).
3568
61352f62 3569 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3570 (Frequire): Mention get-load-suffixes.
61352f62 3571
28545e04
MR
35722011-07-02 Martin Rudalics <rudalics@gmx.at>
3573
3574 * window.h (window): Remove clone_number slot.
3575 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3576 Remove.
3577 (make_parent_window, make_window, saved_window)
3578 (Fset_window_configuration, save_window_save): Don't deal with
3579 clone numbers.
3580 * buffer.c (Qclone_number): Remove declaration.
3581 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3582
3349e122
SM
35832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3584
3585 Add multiple inheritance to keymaps.
3586 * keymap.c (Fmake_composed_keymap): New function.
3587 (Fset_keymap_parent): Simplify.
3588 (fix_submap_inheritance): Remove.
3589 (access_keymap_1): New function extracted from access_keymap to handle
3590 embedded parents and handle lists of maps.
3591 (access_keymap): Use it.
3592 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3593 (Fcopy_keymap): Handle embedded parents.
3594 (Fcommand_remapping, define_as_prefix): Simplify.
3595 (Fkey_binding): Simplify.
3596 (syms_of_keymap): Move minibuffer-local-completion-map,
3597 minibuffer-local-filename-completion-map,
3598 minibuffer-local-must-match-map, and
3599 minibuffer-local-filename-must-match-map to Elisp.
3600 (syms_of_keymap): Defsubr make-composed-keymap.
3601 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3602 (parse_menu_item): Trivial simplification.
3603
3279eb87
GM
36042011-07-01 Glenn Morris <rgm@gnu.org>
3605
3606 * Makefile.in (SETTINGS_LIBS): Fix typo.
3607
4550efdf
KI
36082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3609
3610 * coding.c (Fencode_coding_string): Record the last coding system
3611 used, as the function doc string says (bug#8738).
3612
0949d2b6
JD
36132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3614
3615 * xsettings.c (store_monospaced_changed): Take new font as arg and
3616 check for change against current_mono_font.
3617 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3618 (emacs_settings_constructor, emacs_settings_get_property)
3619 (emacs_settings_set_property, emacs_settings_class_init)
3620 (emacs_settings_init, gsettings_obj): Remove.
3621 (something_changedCB): New function for HAVE_GSETTINGS.
3622 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3623 with value as argument.
3624 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3625 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3626 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3627 "changed".
3628
3629 * xgselect.c: Add defined (HAVE_GSETTINGS).
3630 (xgselect_initialize): Ditto.
3631
3632 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3633 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3634 xg_select.
3635
bbc6b304
PE
36362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3637
3638 * eval.c (struct backtrace): Simplify and port the data structure.
3639 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3640 signed bit field, as this assumption is not portable and it makes
3641 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3642 "char debug_on_exit : 1" as this is not portable either; instead,
3643 use the portable "unsigned int debug_on_exit : 1". Remove unused
3644 member evalargs. Remove obsolete comments about cc bombing out.
3645
9851bfc5
JD
36462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3647
51bb811f 3648 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3649 Let HAVE_GSETTINGS override HAVE_GCONF.
3650 (store_monospaced_changed): New function.
3651 (EMACS_SETTINGS): A new type derived from GObject to handle
3652 GSettings notifications.
3653 (emacs_settings_constructor, emacs_settings_get_property)
3654 (emacs_settings_set_property, emacs_settings_class_init):
3655 New functions.
3656 (gsettings_client, gsettings_obj): New variables.
3657 (GSETTINGS_SCHEMA): New define.
3658 (something_changedCB): Call store_monospaced_changed.
3659 (init_gsettings): New function.
3660 (xsettings_initialize): Call init_gsettings.
3661 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3662 to NULL.
3663
640c8776 3664 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3665 GCONF_CFLAGS/LIBS.
3666
5386012d
MR
36672011-06-29 Martin Rudalics <rudalics@gmx.at>
3668
3669 * window.c (resize_root_window, grow_mini_window)
3670 (shrink_mini_window): Rename Qresize_root_window to
3671 Qwindow_resize_root_window and Qresize_root_window_vertically to
3672 Qwindow_resize_root_window_vertically.
3673
f13e0b08
PE
36742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3677
94515237
JB
36782011-06-27 Juanma Barranquero <lekktu@gmail.com>
3679
3680 * makefile.w32-in: Redesign dependencies so they reflect more
3681 clearly which files are directly included by each source file,
3682 and not through other includes.
3683
e43b6e43
MR
36842011-06-27 Martin Rudalics <rudalics@gmx.at>
3685
3686 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3687 (sort_overlays, overlay_strings): When an overlay's clone number
3688 matches the window's clone number process the overlay even if
3689 the overlay's window property doesn't match the current window.
3690
d68443dc
MR
3691 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3692 (Fwindow_hchild): Rename to Fwindow_left_child.
3693 (Fwindow_next): Rename to Fwindow_next_sibling.
3694 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3695 (resize_window_check): Rename to window_resize_check.
3696 (resize_window_apply): Rename to window_resize_apply.
3697 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3698 (Fdelete_other_windows_internal, resize_frame_windows)
3699 (Fsplit_window_internal, Fdelete_window_internal)
3700 (grow_mini_window, shrink_mini_window)
3701 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3702
c7e73be5
JD
37032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3704
3705 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3706 (emacs_fixed_set_min_size): Remove.
3707 (emacs_fixed_new): Take frame as argument.
3708
3709 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3710 (_EmacsFixedPrivate): Remove minwidth/height.
3711 Add struct frame *f.
3712 (emacs_fixed_init): Initialize priv->f.
3713 (get_parent_class, emacs_fixed_set_min_size): Remove.
3714 (emacs_fixed_new): Set priv->f to argument.
3715 (emacs_fixed_get_preferred_width)
3716 (emacs_fixed_get_preferred_height): Use min_width/height from
3717 frames size_hint to set minimum and natural (Bug#8919).
3718 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3719 and use min_width/height from frames size_hint to set
3720 min_width/height (Bug#8919).
3721
3722 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3723 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3724 Fix indentation.
c7e73be5 3725
cf99dcf8
EZ
37262011-06-26 Eli Zaretskii <eliz@gnu.org>
3727
3728 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3729 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3730 called at ZV.
3731
029529ac
CY
37322011-06-26 Chong Yidong <cyd@stupidchicken.com>
3733
3734 * process.c (wait_reading_process_output): Bypass select if
3735 waiting for a cell while ignoring keyboard input, and input is
3736 pending. Suggested by Jan Djärv (Bug#8869).
3737
7a7ef429
PE
37382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 Use gnulib's dup2 module instead of rolling our own.
3741 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3742
11fdef7d 37432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3744
3745 * dispnew.c (scrolling_window): Before scrolling, turn off a
3746 mouse-highlight in the window being scrolled.
3747
cd3520a4
JB
37482011-06-24 Juanma Barranquero <lekktu@gmail.com>
3749
3750 Move DEFSYM to lisp.h and use everywhere.
3751
3752 * character.h (DEFSYM): Move declaration...
3753 * lisp.h (DEFSYM): ...here.
3754
3755 * gnutls.c:
3756 * minibuf.c:
3757 * w32menu.c:
3758 * w32proc.c:
3759 * w32select.c: Don't include character.h.
3760
3761 * alloc.c (syms_of_alloc):
3762 * buffer.c (syms_of_buffer):
3763 * bytecode.c (syms_of_bytecode):
3764 * callint.c (syms_of_callint):
3765 * casefiddle.c (syms_of_casefiddle):
3766 * casetab.c (init_casetab_once):
3767 * category.c (init_category_once, syms_of_category):
3768 * ccl.c (syms_of_ccl):
3769 * cmds.c (syms_of_cmds):
3770 * composite.c (syms_of_composite):
3771 * dbusbind.c (syms_of_dbusbind):
3772 * dired.c (syms_of_dired):
3773 * dispnew.c (syms_of_display):
3774 * doc.c (syms_of_doc):
3775 * editfns.c (syms_of_editfns):
3776 * emacs.c (syms_of_emacs):
3777 * eval.c (syms_of_eval):
3778 * fileio.c (syms_of_fileio):
3779 * fns.c (syms_of_fns):
3780 * frame.c (syms_of_frame):
3781 * fringe.c (syms_of_fringe):
3782 * insdel.c (syms_of_insdel):
3783 * keymap.c (syms_of_keymap):
3784 * lread.c (init_obarray, syms_of_lread):
3785 * macros.c (syms_of_macros):
3786 * msdos.c (syms_of_msdos):
3787 * print.c (syms_of_print):
3788 * process.c (syms_of_process):
3789 * search.c (syms_of_search):
3790 * sound.c (syms_of_sound):
3791 * syntax.c (init_syntax_once, syms_of_syntax):
3792 * terminal.c (syms_of_terminal):
3793 * textprop.c (syms_of_textprop):
3794 * undo.c (syms_of_undo):
3795 * w32.c (globals_of_w32):
3796 * window.c (syms_of_window):
3797 * xdisp.c (syms_of_xdisp):
3798 * xfaces.c (syms_of_xfaces):
3799 * xfns.c (syms_of_xfns):
3800 * xmenu.c (syms_of_xmenu):
3801 * xsettings.c (syms_of_xsettings):
3802 * xterm.c (syms_of_xterm): Use DEFSYM.
3803
4228cf16
TZ
38042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3805
cd3520a4 3806 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3807
7fcccf1e
PE
38082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3809
7efb4e0e
PE
3810 Integer and buffer overflow fixes (Bug#8873).
3811
ff5844ad
PE
3812 * print.c (printchar, strout): Check for string overflow.
3813 (PRINTPREPARE, printchar, strout):
3814 Don't set size unless allocation succeeds.
3815
90532f02
PE
3816 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3817 for sizes. Check for string overflow more accurately.
3818 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3819
6d84508d
PE
3820 * macros.c: Integer and buffer overflow fixes.
3821 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3822 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3823 Use ptrdiff_t, not int, for sizes.
3824 Don't increment bufsize until after realloc succeeds.
3825 Check for size-calculation overflow.
3826 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3827
437b2cb4
PE
3828 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3829
8b9ac8b4
PE
3830 * lread.c: Integer overflow fixes.
3831 (read_integer): Radix is now EMACS_INT, not int,
3832 to improve quality of diagnostics for out-of-range radices.
3833 Calculate buffer size correctly for out-of-range radices.
3834 (read1): Check for integer overflow in radices, and in
3835 read-circle numbers.
82cb60d3
PE
3836 (read_escape): Avoid int overflow.
3837 (Fload, openp, read_buffer_size, read1)
3838 (substitute_object_recurse, read_vector, read_list, map_obarray):
3839 Use ptrdiff_t, not int, for sizes.
3840 (read1): Use EMACS_INT, not int, for sizes.
20270765 3841 Check for size overflow.
8b9ac8b4 3842
7fcccf1e
PE
3843 * image.c (cache_image): Check for size arithmetic overflow.
3844
bfbbd7e7
PE
3845 * lread.c: Integer overflow issues.
3846 (saved_doc_string_size, saved_doc_string_length)
3847 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3848 Now ptrdiff_t, not int.
3849 (read1): Don't assume doc string length fits in int. Check for
3850 out-of-range doc string lengths.
3851 (read_list): Don't assume file position fits in int.
39019e54 3852 (read_escape): Check for hex character overflow.
bfbbd7e7 3853
4e323265
LL
38542011-06-22 Leo Liu <sdl.web@gmail.com>
3855
3856 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3857 Move to minibuffer.el.
3858
85fece3e
PE
38592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3860
20b84ce9 3861 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3862 The following patches are for when GLYPH_DEBUG && !XASSERT.
3863 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3864 * dispnew.c (flush_stdout):
3865 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3866 Mark as externally visible.
3867 * dispnew.c (check_window_matrix_pointers): Now static.
3868 * dispnew.c (window_to_frame_vpos):
3869 * xfns.c (unwind_create_frame):
3870 * xterm.c (x_check_font): Remove unused local.
3871 * scroll.c (CHECK_BOUNDS):
3872 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3873 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3874 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3875 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3876 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3877 Now static.
3878 (debug_method_add): Use va_list and vsprintf rather than relying
3879 on undefined behavior with wrong number of arguments.
3880 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3881 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3882 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3883 since we're not interested in debugging glyphs with old libraries.
3884 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3885 GCC 4.6.0's static checking.
3886
0766b489
PE
38872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3888
31fd4b32
PE
3889 Integer overflow and signedness fixes (Bug#8873).
3890 A few related buffer overrun fixes, too.
3891
b79e8648
PE
3892 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3893
0766b489
PE
3894 * dispextern.h (struct face.stipple):
3895 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3896 (x_bitmap_mask, x_allocate_bitmap_record)
3897 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3898 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3899 (x_create_bitmap_from_xpm_data):
3900 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3901 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3902 (.bitmaps_last):
3903 * xfaces.c (load_pixmap):
3904 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3905 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3906 (.bitmaps_last, struct x_output.icon_bitmap):
3907 Use ptrdiff_t, not int, for bitmap indexes.
3908 (x_allocate_bitmap_record): Check for size overflow.
3909 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3910
b081724f
PE
3911 Use ptrdiff_t, not int, for overlay counts.
3912 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3913 * editfns.c (overlays_around, get_pos_property):
3914 * textprop.c (get_char_property_and_overlay):
3915 * xdisp.c (next_overlay_change, note_mouse_highlight):
3916 * xfaces.c (face_at_buffer_position):
21514da7
PE
3917 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3918 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3919 (Fnext_overlay_change, Fprevious_overlay_change)
3920 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3921 Use ptrdiff_t, not int, for sizes.
21514da7 3922 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3923
3de73e5e
PE
3924 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3925
2606c57b
PE
3926 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3927 (x_session_initialize): Do not assume string length fits in int.
3928
aaafe47a
PE
3929 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3930 This is unlikely, but can occur if DPI is outlandish.
3931
2674ddc8 3932 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3933 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3934
28154962
PE
3935 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3936 * xrdb.c (magic_file_p, search_magic_path):
3937 Omit last arg SUFFIX; it was always 0. All callers changed.
3938 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3939
7de51af5
PE
3940 * xfont.c (xfont_match): Avoid need for strlen.
3941
25ed6cc3
PE
3942 * xfns.c: Don't assume strlen fits in int.
3943 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3944
4eab31dd
PE
3945 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3946 not unsigned long, as we prefer signed integers. All callers changed.
3947 Detect integer overflow in repeat count.
3948 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3949 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3950
171e2a58
PE
3951 * termcap.c: Don't assume sizes fit in int and never overflow.
3952 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3953 (gobble_line): Check for size-calculation overflow.
3954
ad39faca 3955 * minibuf.c (Fread_buffer):
6e5bb2dc 3956 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3957 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3958 Don't assume string length fits in int.
3959
52c61c22 3960 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3961 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3962
b5b8c9e5
PE
3963 * font.c: Don't assume string length fits in int.
3964 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3965 Use ptrdiff_t, not int.
ccd6111c
PE
3966 (font_intern_prop): Don't assume string length fits in int.
3967 Don't assume integer property fits in fixnum.
3968 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3969
882f0d81 3970 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3971 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3972 Reformulate so as not to need the command string.
3973 Invoke gzip -cd rather than gunzip, as it's more portable.
3974 (lock_info_type, lock_file_1, lock_file):
3975 Don't assume pid_t and time_t fit in unsigned long.
3976 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3977 (current_lock_owner): Prefer signed type for sizes.
3978 Use memcpy, not strncpy, where memcpy is what is really wanted.
3979 Don't assume (via atoi) that time_t and pid_t fit in int.
3980 Check for time_t and/or pid_t out of range, e.g., via a network share.
3981 Don't alloca where an auto var works fine.
3982
93f4cf88
PE
3983 * fileio.c: Fix some integer overflow issues.
3984 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3985 Don't assume string length fits in int.
3986 (directory_file_name): Don't assume string length fits in long.
3987 (make_temp_name): Don't assume pid fits in int, or that its print
3988 length is less than 20.
3989
f3e92b69
PE
3990 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3991
1bfdaf10
PE
3992 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3993
35016e9a
PE
3994 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3995
3d1e65a1
PE
3996 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3997 We prefer signed integers, even for size calculations.
3998
0b963a93
PE
3999 * emacs.c: Don't assume string length fits in 'int'.
4000 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4001 (main): Don't invoke strlen when not needed.
4002
573f4b54
PE
4003 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4004 (XD_DEBUG_MESSAGE): Don't waste a byte.
4005
989f33ba
PE
4006 * callproc.c (getenv_internal_1, getenv_internal)
4007 (Fgetenv_internal):
965d34eb
PE
4008 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4009
e4d29b33
PE
4010 * lread.c (invalid_syntax): Omit length argument.
4011 All uses changed. This doesn't fix a bug, but it simplifies the
4012 code away from its former Hollerith-constant appearance, and it's
4013 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4014 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4015
eb49b136
PE
4016 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4017 This didn't break anything, but it didn't help either.
4018 It's confusing to put a bogus integer in a place where the actual
4019 value does not matter.
9f62aeb1 4020 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4021 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4022
15375a22
PE
4023 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4024 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4025 implementation.
b61cc01c
PE
4026 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4027 We prefer signed types, and the value cannot exceed the EMACS_INT
4028 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4029 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4030 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4031 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4032
53b2623d
PE
4033 * indent.c (sane_tab_width): New function.
4034 (current_column, scan_for_column, Findent_to, position_indentation)
4035 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4036 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4037
51cab52b 4038 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4039
f2ed8a70
PE
4040 * lisp.h (lint_assume): New macro.
4041 * composite.c (composition_gstring_put_cache):
4042 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4043
abe80cc6
PE
4044 * editfns.c, insdel.c:
4045 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4046
b02c740e
PE
4047 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4048
ebc96716
PE
4049 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4050
b4e50fa0 4051 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4052 Use much-faster test for byte-length change.
311d5d7c 4053 Don't assume string byte-length fits in 'int'.
a4cf38e4 4054 Check that character arg fits in 'int'.
85461888 4055 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4056
c0c1ee9f
PE
4057 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4058
a498d7f4
PE
4059 * fns.c (concat): Catch string overflow earlier.
4060 Do not rely on integer wraparound.
4061
51cab52b
PE
4062 * dispextern.h (struct it.overlay_strings_charpos)
4063 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4064 * xdisp.c (forward_to_next_line_start)
4065 (back_to_previous_visible_line_start)
4066 (reseat_at_next_visible_line_start, next_element_from_buffer):
4067 Don't arbitrarily truncate the value of 'selective' to int.
4068
76031fad
PE
4069 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4070
5eb55db9
PE
4071 * composite.c: Don't truncate sizes to 'int'.
4072 (composition_gstring_p, composition_reseat_it)
4073 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4074 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4075 not EMACS_UINT, for indexes.
5eb55db9 4076
0703a717
PE
4077 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4078
d6202519
PE
4079 * buffer.c: Include <verify.h>.
4080 (struct sortvec.priority, struct sortstr.priority):
8961a454 4081 Now EMACS_INT, not int.
c20998a7 4082 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4083 (struct sortstr.size, record_overlay_string)
4084 (struct sortstrlist.size, struct sortlist.used):
4085 Don't truncate size to int.
4086 (record_overlay_string): Check for size-calculation overflow.
d6202519 4087 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4088
d5a19415
JM
40892011-06-22 Jim Meyering <meyering@redhat.com>
4090
029529ac 4091 Don't leak an XBM-image-sized buffer
d5a19415
JM
4092 * image.c (xbm_load): Free the image buffer after using it.
4093
a9041e6c
PE
40942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4095
4096 Port to Sun C.
4097 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4098 that Sun C diagnosed.
4099 * fns.c (secure_hash): Fix pointer signedness issue.
4100 * intervals.c (static_offset_intervals): New function.
4101 (offset_intervals): Use it.
4102
7f3f739f
LL
41032011-06-21 Leo Liu <sdl.web@gmail.com>
4104
4105 * deps.mk (fns.o):
4106 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4107 sha512.h.
4108
4109 * fns.c (secure_hash): Rename from crypto_hash_function and change
4110 the first arg to accept symbols.
5b66d427 4111 (Fsecure_hash): New primitive.
7f3f739f
LL
4112 (syms_of_fns): New symbols.
4113
76147d94
DD
41142011-06-20 Deniz Dogan <deniz@dogan.se>
4115
4116 * process.c (Fset_process_buffer): Clarify return value in
4117 docstring.
4118
7d7d0045
CY
41192011-06-18 Chong Yidong <cyd@stupidchicken.com>
4120
4121 * dispnew.c (add_window_display_history): Use BVAR.
4122
4123 * xdisp.c (debug_method_add): Use BVAR.
4124 (check_window_end, dump_glyph_matrix, dump_glyph)
4125 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4126
4127 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4128 Likewise.
4129
4130 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4131 check till after the cache is created in init_frame_faces.
4132
ff2bc410
SM
41332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4134
4135 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4136
28177add
PE
41372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4138
dd3482fe
PE
4139 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4140 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4141 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4142
393d71f3 4143 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4144 * fileio.c (Finsert_file_contents):
4145 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4146 Remove the old (too-loose) buffer overflow checks.
4147 They weren't needed, since make_gap checks for buffer overflow.
4148 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4149 The old code merely checked for Emacs fixnum overflow, and relied
4150 on undefined (wraparound) behavior. The new code avoids undefined
4151 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4152
2e6813b0 4153 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4154 Tune. Don't use wider integers than needed. Don't use alloca.
4155 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4156
599a9e4f
PE
4157 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4158
99561444
PE
4159 * insdel.c, lisp.h (buffer_overflow): New function.
4160 (insert_from_buffer_1, replace_range, replace_range_2):
4161 * insdel.c (make_gap_larger):
4162 * editfns.c (Finsert_char):
4163 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4164
28177add
PE
4165 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4166
e69dafad
PE
41672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4168
a7af7fde 4169 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4170
b1c46f02
PE
4171 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4172 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4173
e69dafad
PE
4174 * fileio.c: Don't assume EMACS_INT fits in off_t.
4175 (emacs_lseek): New static function.
4176 (Finsert_file_contents, Fwrite_region): Use it.
4177 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4178
566684ea
PE
4179 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4180
e6966cd6
PE
4181 * fns.c: Don't overflow int when computing a list length.
4182 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4183 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4184 truncation on 64-bit hosts. Check for QUIT every
4185 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4186 faster and is responsive enough.
4187 (Flength): Report an error instead of overflowing an integer.
4188 (Fsafe_length): Return a float if the value is not representable
4189 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4190 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4191 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4192
dd0b0efb
PE
4193 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4194 (header_size, word_size): New constants.
4195 (allocate_vectorlike): Don't check size overflow here.
4196 (allocate_vector): Check it here instead, since this is the only
4197 caller of allocate_vectorlike that could cause overflow.
4198 Check that the new vector's length is representable as a fixnum.
4199
86fe5cfe
PE
4200 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4201 The previous code was bogus. For example, next_almost_prime (32)
4202 returned 39, which is undesirable as it is a multiple of 3; and
4203 next_almost_prime (24) returned 25, which is a multiple of 5 so
4204 why was the code bothering to check for multiples of 7?
4205
80e88859
PE
4206 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4207
4a2f0ad6
PE
4208 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4209
f66c7cf8
PE
4210 Variadic C functions now count arguments with ptrdiff_t.
4211 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4212 Back then I didn't know that the Emacs coding style prefers signed int.
4213 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4214 were being counted with int, which may truncate counts on 64-bit
4215 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4216 * lisp.h (struct Lisp_Subr.function.aMANY)
4217 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4218 Arg counts are now ptrdiff_t, not size_t.
4219 All variadic functions and their callers changed accordingly.
4220 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4221 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4222 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4223 * callint.c (Fcall_interactively): Check arg count for overflow,
4224 to avoid potential buffer overrun. Use signed char, not 'int',
4225 for 'varies' array, so that we needn't bother to check its size
4226 calculation for overflow.
4227 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4228 * eval.c (apply_lambda):
4229 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4230 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4231 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4232
a1759b76
PE
4233 * callint.c (Fcall_interactively): Don't use index var as event count.
4234
d96be9fc
PE
4235 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4236 * mem-limits.h (SIZE): Remove; no longer used.
4237
a690a978 4238 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4239
578c21e6
PE
4240 Remove unnecessary casts.
4241 * xterm.c (x_term_init):
4242 * xfns.c (x_set_border_pixel):
4243 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4244 These aren't needed now that we assume ANSI C.
4245
96f53c6c
PE
4246 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4247 It's more likely to cause problems (due to unsigned overflow)
4248 than to cure them.
4249
83c77d31
PE
4250 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4251
ee2079f1
PE
4252 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4253
6da65536
PE
4254 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4255
7147c4a4
PE
4256 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4257
193e32d9
PE
4258 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4259
e5533da6
PE
4260 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4261
9910e595
PE
4262 GLYPH_CODE_FACE returns EMACS_INT, not int.
4263 * dispextern.h (merge_faces):
4264 * xfaces.c (merge_faces):
01103c44
PE
4265 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4266 Don't assume EMACS_INT fits in int.
9910e595 4267
2638320e
PE
4268 * character.h (CHAR_VALID_P): Remove unused parameter.
4269 * fontset.c, lisp.h, xdisp.c: All uses changed.
4270
045eb8d9
PE
4271 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4272
c1f134b5
PE
4273 * fns.c (concat): Minor tuning based on overflow analysis.
4274 This doesn't fix any bugs. Use int to hold character, instead
4275 of constantly refetching from Emacs object. Use XFASTINT, not
4276 XINT, for value known to be a character. Don't bother comparing
4277 a single byte to 0400, as it's always less.
4278
395fcb93 4279 * floatfns.c (Fexpt):
327eeec8
PE
4280 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4281
abbd3d23
PE
4282 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4283 for characters.
4284
684a03ef
PE
4285 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4286
0fed43f3
PE
4287 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4288 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4289 incorrectly succeed when S was a string, because 4294967386 was
4290 truncated before it was used.
4291
8fd02eb7
PE
4292 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4293 Otherwise, an out-of-range integer could cause undefined behavior
4294 on a 64-bit host.
4295
f8c86b69
PE
4296 * composite.c: Use int, not EMACS_INT, for characters.
4297 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4298 EMACS_INT, for values that are known to be in character range.
4299 This doesn't fix any bugs but is the usual style inside Emacs and
4300 may generate better code on 32-bit machines.
4301
34206dd2
PE
4302 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4303 This is for reasons similar to the recent CHAR_STRING fix.
4304 * charset.c (Fencode_char): Check that character arg is actually
4305 a character. Pass an int to ENCODE_CHAR.
4306 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4307 wider than 'int', as a compile-time check to prevent future regressions
4308 in this area.
4309
c5958d4c 4310 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4311
4312 Make sure a 64-bit char is never passed to CHAR_STRING.
4313 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4314 by silently ignoring the top 32 bits, allowing some values
4315 that were far too large to be valid characters.
4316 * character.h: Include <verify.h>.
4317 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4318 arguments are no wider than unsigned, as a compile-time check
4319 to prevent future regressions in this area.
4320 * data.c (Faset):
01103c44 4321 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4322 (Fsubst_char_in_region):
4323 * fns.c (concat):
4324 * xdisp.c (decode_mode_spec_coding):
4325 Adjust to CHAR_STRING's new requirement.
4326 * editfns.c (Finsert_char, Fsubst_char_in_region):
4327 * fns.c (concat): Check that character args are actually
4328 characters. Without this test, these functions did the wrong
4329 thing with wildly out-of-range values on 64-bit hosts.
4330
d37ca623
PE
4331 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4332 These casts should not be needed on 32-bit hosts, either.
4333 * keyboard.c (read_char):
4334 * lread.c (Fload): Remove casts to unsigned.
4335
ea204efb
PE
4336 * lisp.h (UNSIGNED_CMP): New macro.
4337 This fixes comparison bugs on 64-bit hosts.
4338 (ASCII_CHAR_P): Use it.
4339 * casefiddle.c (casify_object):
01103c44 4340 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4341 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4342 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4343 * dispextern.h (FACE_FROM_ID):
4344 * keyboard.c (read_char): Use UNSIGNED_CMP.
4345
41cb286c
PE
4346 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4347 not to EMACS_INT, to avoid GCC warning.
4348
4a1b9832
PE
4349 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4350
55daad71
PE
4351 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4352 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4353 isn't needed on 32-bit machines.
8f95c75c 4354
01103c44
PE
4355 * buffer.c (Fgenerate_new_buffer_name):
4356 Use EMACS_INT for count, not int.
0ceccced 4357 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4358
4359 * data.c (Qcompiled_function): Now static.
4360
c6f072e7
PE
4361 * window.c (window_body_lines): Now static.
4362
20ce5912
PE
4363 * image.c (gif_load): Rename local to avoid shadowing.
4364
9c4c5f81
PE
4365 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4366 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4367 * alloc.c (make_save_value): Integer argument is now of type
4368 ptrdiff_t, not int.
4369 (mark_object): Use ptrdiff_t, not int.
4370 * lisp.h (pD): New macro.
4371 * print.c (print_object): Use it.
4372
c0c5c8ae
PE
4373 * alloc.c: Use EMACS_INT, not int, to count objects.
4374 (total_conses, total_markers, total_symbols, total_vector_size)
4375 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4376 (total_free_floats, total_floats, total_free_intervals)
4377 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4378 Now EMACS_INT, not int. All uses changed.
4379 (Fgarbage_collect): Compute overall total using a double, so that
4380 integer overflow is less likely to be a problem. Check for overflow
4381 when converting back to an integer.
5a25e253
PE
4382 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4383 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4384 These were 'int' variables that could overflow on 64-bit hosts;
4385 they were never used, so remove them instead of repairing them.
211a0b2a 4386 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4387 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4388 Previously, this ceilinged at INT_MAX, but that doesn't work on
4389 64-bit machines.
e46bb31a 4390 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4391
c78baabf 4392 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4393 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4394 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4395 when a (possibly-narrower) signed value would do just as well.
4396 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4397
c9d624c6
PE
4398 * alloc.c: Catch some string size overflows that we were missing.
4399 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4400 for convenience in STRING_BYTES_MAX.
4401 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4402 The definition here is exact; the one in lisp.h was approximate.
4403 (allocate_string_data): Check for string overflow. This catches
4404 some instances we weren't catching before. Also, it catches
4405 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4406 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4407 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4408
c9d624c6
PE
4409 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4410 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4411 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4412
353032ce
PE
4413 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4414
2bccce07
PE
4415 * alloc.c (Fmake_string): Check for out-of-range init.
4416
0ac30604
SM
44172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4418
4419 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4420
c195f2de
JD
44212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4422
4423 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4424 xg_get_default_scrollbar_width.
4425
4426 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4427 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4428 (style_changed_cb): Call update_theme_scrollbar_width and call
4429 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4430 all frames (Bug#8505).
4431 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4432 Call gtk_window_set_resizable if HAVE_GTK3.
4433 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4434 and height if HAVE_GTK3 (Bug#8505).
4435 (scroll_bar_width_for_theme): New variable.
4436 (update_theme_scrollbar_width): New function.
4437 (xg_get_default_scrollbar_width): Move code to
4438 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4439 (xg_initialize): Call update_theme_scrollbar_width.
4440
4441 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4442
4443 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4444
e10ac9f1
MR
44452011-06-12 Martin Rudalics <rudalics@gmx.at>
4446
4447 * frame.c (make_frame): Call other_buffer_safely instead of
4448 other_buffer.
4449
4450 * window.c (temp_output_buffer_show): Call display_buffer with
4451 second argument Vtemp_buffer_show_specifiers and reset latter
4452 immediately after the call.
4453 (Vtemp_buffer_show_specifiers): New variable.
4454 (auto_window_vscroll_p, next_screen_context_lines)
4455 (Vscroll_preserve_screen_position): Remove leading asterisks from
4456 doc-strings.
4457
2d3c217e 44582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4459
7b7f97e8 4460 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4461 * buffer.c (Qclone_number): Remove for now, as it's unused.
4462 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4463 (record_buffer): Remove unused local.
4464 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4465 (set_frame_buffer_list): Remove; unused.
4466 * frame.h (other_visible_frames): Remove decl.
4467 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4468 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4469 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4470 if HAVE_GPM.
4471 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4472 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4473 Define only if HAVE_GPM.
4474 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4475 (update_hints_inhibit): Remove; never set. All uses removed.
4476 * widgetprv.h (emacsFrameClassRec): Remove decl.
4477 * window.c (delete_deletable_window): Now returns void, since it
4478 wasn't returning anything.
4479 (compare_window_configurations): Remove unused locals.
4480 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4481 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4482 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4483 the same widths as pointers. This follows up on the 2011-05-06 patch.
4484 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4485 * xterm.h: Likewise.
4486 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4487
1384b89e
JB
44882011-06-12 Juanma Barranquero <lekktu@gmail.com>
4489
4490 * makefile.w32-in: Update dependencies.
4491 (LISP_H): Add lib/intprops.h.
4492
1100a63c
CY
44932011-06-11 Chong Yidong <cyd@stupidchicken.com>
4494
4495 * image.c (gif_load): Add animation frame delay to the metadata.
4496 (syms_of_image): Use DEFSYM. New symbol `delay'.
4497
6198ccd0
MR
44982011-06-11 Martin Rudalics <rudalics@gmx.at>
4499
4500 * window.c (delete_deletable_window): Re-add.
4501 (Fset_window_configuration): Rewrite to handle dead buffers and
4502 consequently deletable windows.
4503 (window_tree, Fwindow_tree): Remove. Supply functionality in
4504 window.el.
4505 (compare_window_configurations): Simplify code.
4506
b6e3633c
AS
45072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4508
1ab0dee5
AS
4509 * image.c (imagemagick_load_image): Fix type mismatch.
4510 (Fimagemagick_types): Likewise.
4511
b6e3633c
AS
4512 * window.h (replace_buffer_in_windows): Declare.
4513
9397e56f
MR
45142011-06-11 Martin Rudalics <rudalics@gmx.at>
4515
4516 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4517 Qclone_number. Remove external declaration of Qdelete_window.
4518 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4519 code.
640c8776
SM
4520 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4521 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4522 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4523 buffer list implementation.
4524 (other_buffer_safely): New function.
4525 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4526 calls to replace_buffer_in_windows and
4527 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4528 if allowed.
4529 (record_buffer): Inhibit quitting and rewrite using quittable
4530 functions. Run Qbuffer_list_update_hook if allowed.
4531 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4532 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4533 Move switch-to-buffer to window.el.
9397e56f
MR
4534 (bury-buffer): Move to window.el.
4535 (Vbuffer_list_update_hook): New variable.
4536
4537 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4538 section.
4539
4540 * window.h (resize_frame_windows): Move up in code.
4541 (Fwindow_frame): Remove EXFUN.
4542 (replace_buffer_in_all_windows): Remove prototype.
4543 (replace_buffer_in_windows_safely): Add prototype.
4544
4545 * window.c: Declare Qdelete_window static again. Move down
4546 declaration of select_count.
4547 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4548 (Fother_window): Move to window.el.
4549 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4550 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4551 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4552 window.el.
4553 (replace_buffer_in_windows): Implement by calling
4554 Qreplace_buffer_in_windows.
4555 (replace_buffer_in_all_windows): Remove with some functionality
4556 moved into replace_buffer_in_windows_safely.
4557 (replace_buffer_in_windows_safely): New function.
4558 (select_window_norecord, select_frame_norecord): Move in front
4559 of run_window_configuration_change_hook. Remove now obsolete
4560 declarations.
640c8776
SM
4561 (Fset_window_buffer): Rewrite doc-string.
4562 Call Qrecord_window_buffer.
9397e56f
MR
4563 (keys_of_window): Move binding for other-window to window.el.
4564
b50691aa
CY
45652011-06-11 Chong Yidong <cyd@stupidchicken.com>
4566
4567 * dispextern.h (struct image): Replace data member, whose int_val
4568 and ptr_val fields were not used by anything, with a single
4569 lisp_val object.
4570
4571 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4572 (gif_clear_image, gif_load, imagemagick_load_image)
4573 (gs_clear_image, gs_load): Callers changed.
4574
3f754b86
PE
45752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4576
cca69397
PE
4577 * buffer.h: Include <time.h>, for time_t.
4578 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4579
109e28d0
PE
4580 Fix minor problems found by static checking.
4581
60737f02
PE
4582 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4583
4b66faf3
PE
4584 Make identifiers static if they are not used in other modules.
4585 * data.c (Qcompiled_function, Qframe, Qvector):
4586 * image.c (QimageMagick, Qsvg):
4587 * minibuf.c (Qmetadata):
4588 * window.c (resize_window_check, resize_root_window): Now static.
4589 * window.h (resize_window_check, resize_root_window): Remove decls.
4590
109e28d0
PE
4591 * window.c (window_deletion_count, delete_deletable_window):
4592 Remove; unused.
46a4ce9e
PE
4593 (window_body_lines): Now static.
4594 (Fdelete_other_windows_internal): Mark vars as initialized.
4595 Make sure 'resize_failed' is initialized.
4596 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4597 (resize_window_apply): Remove unused local.
4598 * window.h (delete_deletable_window): Remove decl.
4599
109e28d0 4600 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4601 (imagemagick_load_image): Fix pointer signedness problem by changing
4602 last arg from unsigned char * to char *. All uses changed.
4603 Also, fix a local for similar reasons.
4604 Remove unused locals. Remove locals to avoid shadowing.
4605 (fn_rsvg_handle_free): Remove; unused.
4606 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4607 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4608
3f754b86
PE
4609 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4610
2547adb1
CY
46112011-06-10 Chong Yidong <cyd@stupidchicken.com>
4612
4613 * image.c (gif_load): Fix omitted cast error introduced by
4614 2011-06-06 change.
4615
2c8e37d4
MR
46162011-06-10 Martin Rudalics <rudalics@gmx.at>
4617
4618 * window.h (resize_proportionally, orig_total_lines)
4619 (orig_top_line): Remove from window structure.
4620 (set_window_height, set_window_width, change_window_heights)
4621 (Fdelete_window): Remove prototypes.
4622 (resize_frame_windows): Remove duplicate declaration.
4623
440a42e3
EZ
46242011-06-10 Eli Zaretskii <eliz@gnu.org>
4625
4626 * window.h (resize_frame_windows, resize_window_check)
4627 (delete_deletable_window, resize_root_window)
4628 (resize_frame_windows): Declare prototypes.
4629
4630 * window.c (resize_window_apply): Make definition be "static" to
4631 match the prototype.
4632
562dd5e9
MR
46332011-06-10 Martin Rudalics <rudalics@gmx.at>
4634
4635 * window.c: Remove declarations of Qwindow_size_fixed,
4636 window_min_size_1, window_min_size_2, window_min_size,
4637 size_window, window_fixed_size_p, enlarge_window, delete_window.
4638 Remove static from declaration of Qdelete_window, it's
4639 temporarily needed by Fbury_buffer.
4640 (replace_window): Don't assign orig_top_line and
4641 orig_total_lines.
4642 (Fdelete_window, delete_window): Remove. Window deletion is
4643 handled by window.el.
640c8776
SM
4644 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4645 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4646 (Fdelete_other_windows): Remove. Deleting other windows is
4647 handled by window.el.
4648 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4649 handled in window.el.
4650 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4651 Window minimum sizes are handled in window.el.
4652 (shrink_windows, size_window, set_window_height)
4653 (set_window_width, change_window_heights, window_height)
4654 (window_width, CURBEG, CURSIZE, enlarge_window)
4655 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4656 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4657 handled in window.el.
4658 (make_dummy_parent): Rename to make_parent_window and give it a
4659 second argument horflag.
4660 (make_window): Don't set resize_proportionally any more.
4661 (Fsplit_window): Remove. Windows are split in window.el.
4662 (save_restore_action, save_restore_orig_size)
4663 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4664 Resize mini windows in window.el.
4665 (grow_mini_window, shrink_mini_window): Implement by calling
4666 Qresize_root_window_vertically, resize_window_check and
4667 resize_window_apply.
640c8776
SM
4668 (saved_window, Fset_window_configuration, save_window_save):
4669 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4670 resize_proportionally.
4671 (window_min_height, window_min_width): Move to window.el.
4672 (keys_of_window): Move bindings for delete-other-windows,
4673 split-window, delete-window and enlarge-window to window.el.
4674
4675 * buffer.c: Temporarily extern Qdelete_window.
4676 (Fbury_buffer): Temporarily call Qdelete_window instead of
4677 Fdelete_window (Fbury_buffer will move to window.el soon).
4678
4679 * frame.c (set_menu_bar_lines_1): Remove code handling
4680 orig_top_line and orig_total_lines.
4681
4682 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4683 set_window_height but set heights directly.
4684 (change_frame_size_1): Use resize_frame_windows.
4685
4686 * xdisp.c (init_xdisp): Don't use set_window_height but set
4687 heights directly.
4688
640c8776
SM
4689 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4690 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4691 run_window_configuration_change_hook.
4692
4693 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4694 instead of change_window_heights and run
4695 run_window_configuration_change_hook.
4696
1a13852e
MR
46972011-06-09 Martin Rudalics <rudalics@gmx.at>
4698
4699 * window.c (replace_window): Rename second argument REPLACEMENT to
4700 NEW. New third argument SETFLAG. Rewrite.
4701 (delete_window, make_dummy_parent): Call replace_window with
4702 third argument 1.
4703 (window_list_1): Move down in code.
4704 (run_window_configuration_change_hook): Move set_buffer part
4705 before select_frame_norecord part in order to unwind correctly.
4706 Rename count1 to count.
4707 (recombine_windows, delete_deletable_window, resize_root_window)
4708 (Fdelete_other_windows_internal)
4709 (Frun_window_configuration_change_hook, make_parent_window)
4710 (resize_window_check, resize_window_apply, Fresize_window_apply)
4711 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4712 (Fdelete_window_internal, Fresize_mini_window_internal):
4713 New functions.
1a13852e
MR
4714 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4715
f3d1777e
MR
47162011-06-08 Martin Rudalics <rudalics@gmx.at>
4717
496e208e
MR
4718 * window.h (window): Add some new members to window structure -
4719 normal_lines, normal_cols, new_total, new_normal, clone_number,
4720 splits, nest, prev_buffers, next_buffers.
4721 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4722 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4723
f3d1777e
MR
4724 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4725 Remove.
496e208e
MR
4726 (make_dummy_parent): Set new members of windows structure.
4727 (make_window): Move down in code. Handle new members of window
4728 structure.
4729 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4730 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4731 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4732 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4733 (Fset_window_next_buffers, Fset_window_clone_number):
4734 New functions.
496e208e
MR
4735 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4736 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4737 Doc-string fixes.
4738 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4739 Argument WINDOW can be now internal window too.
4740 (Fwindow_use_time): Move up in code.
4741 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4742 Rewrite doc-string.
4743 (Fset_window_configuration, saved_window)
4744 (Fcurrent_window_configuration, save_window_save): Handle new
4745 members of window structure.
b9e809c2
MR
4746 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4747 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4748 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4749 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4750 Qget_mru_window, Qresize_root_window,
4751 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4752 Qauto_buffer_name; staticpro them.
f3d1777e 4753
abde8f8c
MR
47542011-06-07 Martin Rudalics <rudalics@gmx.at>
4755
4756 * window.c (Fwindow_total_size, Fwindow_left_column)
4757 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4758 (Fwindow_list_1): New functions.
4759 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4760 (Fwindow_width, Fscroll_left, Fscroll_right):
4761 Use window_body_cols instead of window_box_text_cols.
4762 (delete_window, Fset_window_configuration):
4763 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4764 (delete_all_subwindows): Take a window as argument and not a
4765 structure. Rewrite.
190b47e6
MR
4766 (window_loop): Remove handling of GET_LRU_WINDOW and
4767 GET_LARGEST_WINDOW.
4768 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4769
4770 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4771 window_box_text_cols. delete_all_subwindows now takes a
4772 Lisp_Object as argument.
abde8f8c 4773
640c8776
SM
4774 * indent.c (compute_motion, Fcompute_motion):
4775 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4776
fa8a67e6
MR
4777 * frame.c (delete_frame): Call delete_all_subwindows with root
4778 window as argument.
4779
a54e3482
DC
47802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4781
4782 * fns.c (Fputhash): Document return value.
4783
60002bf5
CY
47842011-06-06 Chong Yidong <cyd@stupidchicken.com>
4785
4786 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4787
0c671da6 47882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4789
b862a52a 4790 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4791
be44ca6c
PE
4792 Check for overflow when converting integer to cons and back.
4793 * charset.c (Fdefine_charset_internal, Fdecode_char):
4794 Use cons_to_unsigned to catch overflow.
4795 (Fencode_char): Use INTEGER_TO_CONS.
4796 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4797 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4798 * data.c (long_to_cons, cons_to_long): Remove.
4799 (cons_to_unsigned, cons_to_signed): New functions.
4800 These signal an error for invalid or out-of-range values.
4801 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4802 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4803 * font.c (Ffont_variation_glyphs):
4804 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4805 * lisp.h: Include <intprops.h>.
4806 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4807 (cons_to_signed, cons_to_unsigned): New decls.
4808 (long_to_cons, cons_to_long): Remove decls.
4809 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4810 (Fprimitive_undo): Use CONS_TO_INTEGER.
4811 * xfns.c (Fx_window_property): Likewise.
4812 * xselect.c: Include <limits.h>.
4813 (x_own_selection, selection_data_to_lisp_data):
4814 Use INTEGER_TO_CONS.
4815 (x_handle_selection_request, x_handle_selection_clear)
4816 (x_get_foreign_selection, Fx_disown_selection_internal)
4817 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4818 (lisp_data_to_selection_data): Use cons_to_unsigned.
4819 (x_fill_property_data): Use cons_to_signed.
4820 Report values out of range.
4821
d1f3d2af
PE
4822 Check for buffer and string overflow more precisely.
4823 * buffer.h (BUF_BYTES_MAX): New macro.
4824 * lisp.h (STRING_BYTES_MAX): New macro.
4825 * alloc.c (Fmake_string):
4826 * character.c (string_escape_byte8):
4827 * coding.c (coding_alloc_by_realloc):
4828 * doprnt.c (doprnt):
4829 * editfns.c (Fformat):
4830 * eval.c (verror):
4831 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4832 since they may not be the same number.
4833 * editfns.c (Finsert_char):
4834 * fileio.c (Finsert_file_contents):
4835 Likewise for BUF_BYTES_MAX.
4836
dd52fcea
PE
4837 * image.c: Use ptrdiff_t, not int, for sizes.
4838 (slurp_file): Switch from int to ptrdiff_t.
4839 All uses changed.
4840 (slurp_file): Check that file size fits in both size_t (for
4841 malloc) and ptrdiff_t (for sanity and safety).
4842
7f9bbdbb
PE
4843 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4844 if b->modtime has its maximal value.
4845
dfe18f82
PE
4846 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4847
84acfcf0
PE
4848 Don't assume time_t can fit into int.
4849 * buffer.h (struct buffer.modtime): Now time_t, not int.
4850 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4851 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4852
ccd9a01a
PE
4853 Minor fixes for signed vs unsigned integers.
4854 * character.h (MAYBE_UNIFY_CHAR):
4855 * charset.c (maybe_unify_char):
4856 * keyboard.c (read_char, reorder_modifiers):
4857 XINT -> XFASTINT, since the integer must be nonnegative.
4858 * ftfont.c (ftfont_spec_pattern):
4859 * keymap.c (access_keymap, silly_event_symbol_error):
4860 XUINT -> XFASTINT, since the integer must be nonnegative.
4861 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4862 since it makes no difference and we prefer signed.
4863 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4864 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4865 nonnegative.
4866
d6d100dd
SM
48672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4868
4869 * window.h (Fwindow_frame): Declare.
4870
2b6148e4
PE
48712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4872
4873 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4874 (SPARE_MEMORY): Always define.
4875 (LARGE_REQUEST): Remove.
4876 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4877
f230ecc9
MR
48782011-06-06 Martin Rudalics <rudalics@gmx.at>
4879
727e958e
MR
4880 * lisp.h: Move EXFUNS for Fframe_root_window,
4881 Fframe_first_window and Fset_frame_selected_window to window.h.
4882
4883 * window.h: Move EXFUNS for Fframe_root_window,
4884 Fframe_first_window and Fset_frame_selected_window here from
4885 lisp.h.
4886
4887 * frame.c (Fwindow_frame, Fframe_first_window)
4888 (Fframe_root_window, Fframe_selected_window)
4889 (Fset_frame_selected_window): Move to window.c.
4890 (Factive_minibuffer_window): Move to minibuf.c.
4891 (Fother_visible_frames_p): New function.
4892
4893 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4894
f230ecc9
MR
4895 * window.c (decode_window, decode_any_window): Move up in code.
4896 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4897 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4898 (Fwindow_buffer): Move up and rewrite doc-string.
4899 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4900 (Fwindow_prev): New functions.
727e958e
MR
4901 (Fwindow_frame): Move here from frame.c. Accept any window as
4902 argument.
4903 (Fframe_root_window, Fframe_first_window)
4904 (Fframe_selected_window): Move here from frame.c. Accept frame
4905 or arbitrary window as argument. Update doc-strings.
4906 (Fminibuffer_window): Move up in code.
4907 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4908 (Fset_frame_selected_window): Move here from frame.c.
4909 Marginal rewrite.
727e958e
MR
4910 (Fselected_window, select_window, Fselect_window): Move up in
4911 code. Minor doc-string fixes.
f230ecc9 4912
4d09bcf6
PE
49132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4914
4915 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4916 Do not assume that spare memory exists; that assumption is valid
4917 only if SYSTEM_MALLOC.
4918 (LARGE_REQUEST): New macro, so that the issue of large requests
4919 is separated from the issue of spare memory.
4920
810928a2
AS
49212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4922
172418ad
AS
4923 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4924 format. (Bug#8806)
4925
43f862f7
AS
4926 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4927
810928a2
AS
4928 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4929 before statements.
4930
a059fe24
JD
49312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4932
4933 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4934
4935 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4936
4937 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4938 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4939
989bf368
JB
49402011-06-05 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4943
4b80f674
CY
49442011-06-04 Chong Yidong <cyd@stupidchicken.com>
4945
4946 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4947 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4948 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4949 New error handlers.
4b80f674
CY
4950 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4951 Obey Vx_select_enable_clipboard_manager. Catch errors in
4952 x_clipboard_manager_save (Bug#8779).
4953 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4954 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4955
99a33b77 49562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4957
4958 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4959
99a33b77 49602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4961
4962 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4963 in the current matrix if keep_current_p is non-zero.
4964
8264569d
EZ
49652011-06-04 Eli Zaretskii <eliz@gnu.org>
4966
4967 * bidi.c (bidi_level_of_next_char): Fix last change.
4968
57f97249
EZ
49692011-06-03 Eli Zaretskii <eliz@gnu.org>
4970
fec2107c 4971 Support bidi reordering of text covered by display properties.
57f97249 4972
fec2107c
EZ
4973 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4974 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4975 (bidi_cache_search, bidi_cache_iterator_state)
4976 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4977 (bidi_level_of_next_char, bidi_move_to_visually_next):
4978 Support character positions inside a run of characters covered by a
fec2107c
EZ
4979 display string.
4980 (bidi_paragraph_init, bidi_resolve_explicit_1)
4981 (bidi_level_of_next_char): Call bidi_fetch_char and
4982 bidi_fetch_char_advance instead of FETCH_CHAR and
4983 FETCH_CHAR_ADVANCE.
4984 (bidi_init_it): Initialize new members.
4985 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4986 definitions.
4987 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4988 instead of using explicit *_CHAR codes.
d6d100dd
SM
4989 (bidi_resolve_explicit, bidi_resolve_weak):
4990 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4991 bidirectional text is supported only in multibyte buffers.
4992 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4993 it to initialize the frame_window_p member of struct bidi_it.
4994 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4995 (bidi_resolve_explicit, bidi_resolve_weak)
4996 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4997 bidi_it->nchars is non-positive.
4998 (bidi_level_of_next_char): Don't try to lookup the cache for the
4999 next/previous character if nothing is cached there yet, or if we
5000 were just reseat()'ed to a new position.
c40e2fb2 5001
0e14fe90
EZ
5002 * xdisp.c (set_cursor_from_row): Set start and stop points
5003 according to the row's direction when priming the loop that looks
5004 for the glyph on which to display cursor.
5005 (single_display_spec_intangible_p): Function deleted.
5006 (display_prop_intangible_p): Reimplement to call
5007 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5008 Accept 3 additional arguments needed by handle_display_spec.
5009 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5010 values: lists, `(when COND...)' forms, etc.
5011 (single_display_spec_string_p): Support property values that are
5012 lists with the argument STRING its top-level element.
5013 (display_prop_string_p): Fix the condition for processing a
5014 property that is a list to be consistent with handle_display_spec.
fec2107c 5015 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5016 last portion of handle_display_prop.
5017 (compute_display_string_pos): Accept additional argument
5018 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5019 value of a `display' property is a "replacing spec".
5020 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5021 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5022 the display property, but just return a value indicating whether
5023 the display property will replace the characters it covers.
5024 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5025 frame_window_p members of struct bidi_it.
d6d100dd
SM
5026 (compute_display_string_pos, compute_display_string_end):
5027 New functions.
fec2107c
EZ
5028 (push_it): Accept second argument POSITION, where pop_it should
5029 jump to continue iteration.
5030 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5031
fec2107c
EZ
5032 * keyboard.c (adjust_point_for_property): Adjust the call to
5033 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5034
5035 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5036 (bidi_init_it): Update prototypes.
5037 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5038 (compute_display_string_pos, compute_display_string_end):
5039 Declare prototypes.
fec2107c
EZ
5040 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5041 EMACS_INT.
fc6f18ce 5042
40087514 50432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5044
57f53182
PE
5045 Malloc failure behavior now depends on size of allocation.
5046 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5047 * lisp.h: Change signatures accordingly.
5048 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5049 All callers changed. (Bug#8762)
5050
5051 * gnutls.c: Use Emacs's memory allocators.
5052 Without this change, the gnutls library would invoke malloc etc.
5053 directly, which causes problems on non-SYNC_INPUT hosts, and which
5054 runs afoul of improving memory_full behavior. (Bug#8761)
5055 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5056 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5057 xfree instead of the default malloc, realloc, free.
5058 (Fgnutls_boot): No need to check for memory allocation failure,
5059 since xmalloc does that for us.
5060
ac32cd99 5061 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5062 * category.c (hash_get_category_set):
5063 * ccl.c (ccl_driver):
5064 * charset.c (Fdefine_charset_internal):
5065 * charset.h (struct charset.hash_index):
5066 * composite.c (get_composition_id, gstring_lookup_cache)
5067 (composition_gstring_put_cache):
5068 * composite.h (struct composition.hash_index):
5069 * dispextern.h (struct image.hash):
5070 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5071 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5072 (hashfn_equal, hashfn_user_defined, make_hash_table)
5073 (maybe_resize_hash_table, hash_lookup, hash_put)
5074 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5075 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5076 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5077 * image.c (make_image, search_image_cache, lookup_image)
5078 (xpm_put_color_table_h):
5079 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5080 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5081 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5082 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5083 * alloc.c (allocate_vectorlike):
5084 Check for overflow in vector size calculations.
5085 * ccl.c (ccl_driver):
5086 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5087 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5088 need to be updated by these changes.
40087514
PE
5089 * fns.c (make_hash_table, maybe_resize_hash_table):
5090 Check for integer overflow with large hash tables.
0de4bb68
PE
5091 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5092 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5093 (SXHASH_REDUCE): New macro.
5094 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5095 Use it instead of discarding useful hash info with large hash values.
5096 (sxhash_float): New function.
5097 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5098 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5099 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5100 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5101 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5102 Adjust signatures to match updated version of code.
5103 (consing_since_gc): Now EMACS_INT, since a single hash table can
5104 use more than INT_MAX bytes.
5105
698d32e2
DN
51062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5107
5108 Make it possible to build with GCC-4.6+ -O2 -flto.
5109
5110 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5111
fd6fa53f
SM
51122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5113
5114 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5115 Call minibuffer-inactive-mode.
5116
864db017
JB
51172011-05-31 Juanma Barranquero <lekktu@gmail.com>
5118
5119 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5120 Update dependencies.
5121
2ad0baf4
DN
51222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5123
5124 * data.c (init_data): Remove code for UTS, this system is not
5125 supported anymore.
5126
4fcc2638
DN
51272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5128
5129 Don't force ./temacs to start in terminal mode.
5130
5131 * frame.c (make_initial_frame): Initialize faces in all cases, not
5132 only when CANNOT_DUMP is defined.
5133 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5134
c56e0fd5
DN
51352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5136
5137 * dispnew.c (add_window_display_history): Use const for the string
5138 pointer. Remove declaration, not needed.
5139
333d54da 51402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5141
55d4c1b2 5142 Use 'inline', not 'INLINE'.
333d54da 5143 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5144 * alloc.c, fontset.c (INLINE): Remove.
5145 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5146 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5147 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5148 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5149 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5150
738db178
DN
51512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5152
5153 Make it possible to run ./temacs.
5154
5155 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5156 syms_of_callproc does the same thing. Remove test for
5157 "initialized", do it in the caller.
5158 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5159
620c53a6
SM
51602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5161
5162 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5163 (read_minibuf): Use get_minibuffer.
5164 (syms_of_minibuf): Use DEFSYM.
5165 (Qmetadata): New var.
5166 * data.c (Qbuffer): Don't make it static.
5167 (syms_of_data): Use DEFSYM.
5168
e003a292
PE
51692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5170
5171 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5172 (CCL_CODE_MIN): New macro.
5173
ed008a6d
PE
51742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5175
3687c2ef
PE
5176 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5177
ed008a6d
PE
5178 * eval.c (Qdebug): Now static.
5179 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5180 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5181 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5182
d66c4c7c
CY
51832011-05-29 Chong Yidong <cyd@stupidchicken.com>
5184
5185 * image.c: Various fixes to ImageMagick code comments.
5186 (Fimagemagick_types): Doc fix.
5187
5fbc2025
PE
51882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5189
0196f88a
PE
5190 Minor fixes prompted by GCC 4.6.0 warnings.
5191
5192 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5193
5fbc2025
PE
5194 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5195 (x_clipboard_manager_save_all): Move extern decl to ...
5196 * xterm.h: ... here, so that it can be checked for consistency.
5197
1dd3c2d9
CY
51982011-05-29 Chong Yidong <cyd@stupidchicken.com>
5199
5200 * xselect.c (x_clipboard_manager_save_frame)
5201 (x_clipboard_manager_save_all): New functions.
5202 (Fx_clipboard_manager_save): Lisp function deleted.
5203
5204 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5205 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5206
5207 * xterm.h: Update prototype.
5208
5ba6571d
WX
52092011-05-28 William Xu <william.xwl@gmail.com>
5210
5211 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5212 exiting (Bug#8239).
5213
3eaff834
JM
52142011-05-28 Jim Meyering <meyering@redhat.com>
5215
e1900994 5216 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5217 * fns.c (to_uchar): Define.
5218 (crypto_hash_function): Use it to convert some newly-signed
5219 variables to unsigned, to avoid sign-extension bugs. For example,
5220 without this change, (md5 "truc") would evaluate to
5221 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5222 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5223 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5224
0f6990a7
PE
52252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5226
5227 Integer overflow fixes.
c8a9ca5a 5228
08686060
PE
5229 * dbusbind.c: Serial number integer overflow fixes.
5230 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5231 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5232 to hold a serial number that is too large for a fixnum.
5233 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5234 Check for serial numbers out of range. Decode any serial number
59568bf0 5235 that was so large that it became a float. (Bug#8722)
08686060 5236
2d1fc3c7
PE
5237 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5238 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5239 Use XFASTINT rather than XUINT when numbers are nonnegative.
5240 (xd_append_arg, Fdbus_method_return_internal):
5241 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5242 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5243 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5244 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5245 (Bug#8722)
2d1fc3c7 5246
c8a9ca5a
PE
5247 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5248
519e1d69
PE
5249 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5250
30569699
PE
5251 ccl: add integer overflow checks
5252 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5253 (IN_INT_RANGE): New macros.
5254 (ccl_driver): Use them to check for integer overflow when
5255 decoding a CCL program. Many of the new checks are whether XINT (x)
5256 fits in int; it doesn't always, on 64-bit hosts. The new version
5257 doesn't catch all possible integer overflows, but it's an
847044ea 5258 improvement. (Bug#8719)
30569699 5259
c11285dc
PE
5260 * alloc.c (make_event_array): Use XINT, not XUINT.
5261 There's no need for unsigned here.
5262
fdccd48e
PE
5263 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5264 This follows up to the 2011-05-06 change that substituted uintptr_t
5265 for EMACS_INT. This case wasn't caught back then.
5266
37910ab2
PE
5267 Rework Fformat to avoid integer overflow issues.
5268 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5269 now (part of C89). Include <verify.h>.
5270 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5271 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5272 (Fformat): Avoid the prepass trying to compute sizes; it was only
5273 approximate and thus did not catch overflow reliably. Instead, walk
5274 through the format just once, formatting and computing sizes as we go,
5275 checking for integer overflow at every step, and allocating a larger
5276 buffer as needed. Keep track separately whether the format is
5277 multibyte. Keep only the most-recently calculated precision, rather
5278 than them all. Record whether each argument has been converted to
5279 string. Use EMACS_INT, not int, for byte and char and arg counts.
5280 Support field widths and precisions larger than INT_MAX. Avoid
5281 sprintf's undefined behavior with conversion specifications such as %#d
5282 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5283 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5284 formatting out-of-range floating point numbers with int
9173deec 5285 formats. (Bug#8668)
37910ab2 5286
2e6578fb
PE
5287 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5288
0ae6bdee
PE
5289 * data.c: Avoid integer truncation in expressions involving floats.
5290 * data.c: Include <intprops.h>.
5291 (arith_driver): When there's an integer overflow in an expression
5292 involving floating point, convert the integers to floating point
5293 so that the resulting value does not suffer from catastrophic
5294 integer truncation. For example, on a 64-bit host (* 4
5295 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5296 Do not rely on undefined behavior after integer overflow.
5297
de883a70
PE
5298 merge count_size_as_multibyte, parse_str_to_multibyte
5299 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5300 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5301 Check for integer overflow.
5302 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5303 since it's now a duplicate of the other. This is more of
5304 a character than a buffer op, so better that it's in character.c.
5305 * fns.c, print.c: Adjust to above changes.
5306
2ff916cb
PE
53072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5308
5309 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5310
f1b54466
PE
53112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5312
fb1ac845
PE
5313 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5314 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5315 (x_clipboard_manager_save): Now static.
5316 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5317
f1b54466
PE
5318 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5319 (crypto_hash_function): Now static.
5320 Fix pointer signedness problems. Avoid unnecessary initializations.
5321
a9f737ee
CY
53222011-05-27 Chong Yidong <cyd@stupidchicken.com>
5323
5324 * termhooks.h (Vselection_alist): Make it terminal-local.
5325
5326 * terminal.c (create_terminal): Initialize it.
5327
5328 * xselect.c: Support for clipboard managers.
5329 (Vselection_alist): Move to termhooks.h as terminal-local var.
5330 (LOCAL_SELECTION): New macro.
5331 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5332 (symbol_to_x_atom): Remove gratuitous arg.
5333 (x_handle_selection_request, lisp_data_to_selection_data)
5334 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5335 (x_own_selection, x_get_local_selection, x_convert_selection):
5336 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5337 (some_frame_on_display): Delete unused function.
5338 (Fx_own_selection_internal, Fx_get_selection_internal)
5339 (Fx_disown_selection_internal, Fx_selection_owner_p)
5340 (Fx_selection_exists_p): New optional frame arg.
5341 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5342 (x_handle_selection_clear): Don't treat other terminals with the
5343 same keyboard specially. Use the terminal-local Vselection_alist.
5344 (x_clear_frame_selections): Use Frun_hook_with_args.
5345
5346 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5347
5348 * xterm.h: Add support for those atoms.
5349
e067f0c1
CY
53502011-05-26 Chong Yidong <cyd@stupidchicken.com>
5351
5352 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5353 (converted_selections, conversion_fail_tag): New global variables.
5354 (x_selection_request_lisp_error): Free the above.
5355 (x_get_local_selection): Remove unnecessary code.
5356 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5357 of converted selections stored in converted_selections.
5358 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5359 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5360 (x_convert_selection): New function.
5361 (x_handle_selection_event): Simplify.
5362 (x_get_foreign_selection): Don't ignore incoming requests while
5363 waiting for an answer; this will fail when we implement
5364 SAVE_TARGETS, and seems unnecessary anyway.
5365 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5366 (Vx_sent_selection_functions): Doc fix.
5367
0f4aebc0
LL
53682011-05-26 Leo Liu <sdl.web@gmail.com>
5369
5370 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5371
e61124cd
YM
53722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5373
5374 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5375
5376 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5377 for fringe update if it has periodic bitmap.
ac389d0c 5378 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5379 and fringe_bitmap_periodic_p.
5380
5381 * fringe.c (get_fringe_bitmap_data): New function.
5382 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5383 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5384 row. Mark glyph row for fringe update if periodicity changed.
5385
5386 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5387 for fringe update unless it has periodic bitmap.
5388
f16d9837
KH
53892011-05-25 Kenichi Handa <handa@m17n.org>
5390
5391 * xdisp.c (get_next_display_element): Set correct it->face_id for
5392 a static composition.
5393
e1b90ef6
LL
53942011-05-24 Leo Liu <sdl.web@gmail.com>
5395
5396 * deps.mk (fns.o):
5397 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5398
5399 * fns.c (crypto_hash_function, Fsha1): New function.
5400 (Fmd5): Use crypto_hash_function.
5401 (syms_of_fns): Add Ssha1.
5402
7400048f
PE
54032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5404
5405 * gnutls.c: Remove unused macros.
5406 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5407 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5408 Remove macros that are defined and never used.
5409 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5410
abb71cf4
CY
54112011-05-22 Chong Yidong <cyd@stupidchicken.com>
5412
5413 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5414 (Fx_get_selection_internal): Minor cleanup.
5415 (Fx_own_selection_internal): Rename arguments for consistency with
5416 select.el.
5417
6307db39
PE
54182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5419
5420 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5421
f3d4e0a4
CY
54222011-05-22 Chong Yidong <cyd@stupidchicken.com>
5423
5424 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5425
4d8ade89
YM
54262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5427
5428 * dispnew.c (scrolling_window): Don't exclude the case that the
5429 last enabled row in the desired matrix touches the bottom boundary.
5430
32078c8d
GM
54312011-05-21 Glenn Morris <rgm@gnu.org>
5432
5433 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5434 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5435 and add some more files.
32078c8d 5436
7285dc67
EZ
54372011-05-20 Eli Zaretskii <eliz@gnu.org>
5438
5439 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5440 report_file_error introduced by the change from 2011-05-07.
5441
89d1bd22
PE
54422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 * systime.h (Time): Define only if emacs is defined.
5445 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5446 where the include path doesn't have X11/X.h by default. See
5447 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5448
e23640bb 54492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5450
5451 * composite.c (find_automatic_composition): Fix previous change.
5452
b9704ad9
GM
54532011-05-20 Glenn Morris <rgm@gnu.org>
5454
5455 * lisp.mk: New file, split from Makefile.in.
5456 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5457 (shortlisp): Remove.
5458 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5459
4a720484
GM
54602011-05-19 Glenn Morris <rgm@gnu.org>
5461
5462 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5463 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5464 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5465 (lisp): Set the order to that of loadup.el.
5466 (shortlisp): Make it a copy of $lisp.
5467 (SOME_MACHINE_LISP): Remove.
5468 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5469 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5470
a28d4396
KH
54712011-05-18 Kenichi Handa <handa@m17n.org>
5472
5473 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5474 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5475 (find_automatic_composition): Mostly rewrite for efficiency.
5476
a2b1fa8e
JB
54772011-05-18 Juanma Barranquero <lekktu@gmail.com>
5478
5479 * makefile.w32-in: Update dependencies.
5480
8e1f5610
CS
54812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5482
5483 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5484 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5485
7025ee00 54862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5487
cdfa6eab
PE
5488 Fix some integer overflow issues, such as string length overflow.
5489
06d6db33
PE
5490 * insdel.c (count_size_as_multibyte): Check for string overflow.
5491
2b4560a8
PE
5492 * character.c (lisp_string_width): Check for string overflow.
5493 Use EMACS_INT, not int, for string indexes and lengths; in
5494 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5495 the resulting string length overflows an EMACS_INT; instead,
5496 report a string overflow if no precision given. When checking for
5497 precision exhaustion, use a check that cannot possibly have
5498 integer overflow. (Bug#8675)
5499 * character.h (lisp_string_width): Adjust to new signature.
5500
cb93f9be
PE
5501 * alloc.c (string_overflow): New function.
5502 (Fmake_string): Use it. This doesn't change behavior, but saves
5503 a few bytes and will simplify future changes.
5504 * character.c (string_escape_byte8): Likewise.
5505 * lisp.h (string_overflow): New decl.
5506
1a1f3366
PE
5507 Fixups, following up to the user-interface timestamp change.
5508 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5509 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5510 * msdos.c (mouse_get_pos): Likewise.
5511 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5512 * w32gui.h (Time): Define by including "systime.h" rather than by
5513 declaring it ourselves. (Bug#8664)
5514
d4e3e4d3
PE
5515 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5516 * image.c (clear_image_cache): Likewise.
5517
f6a24d19
PE
5518 * term.c (term_mouse_position): Don't assume time_t wraparound.
5519
08dc5ae6
PE
5520 Be more systematic about user-interface timestamps.
5521 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5522 and sometimes 'EMACS_UINT', to represent these timestamps.
5523 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5524 This makes the code easier to follow, and makes it easier to catch
5525 integer overflow bugs such as Bug#8664.
5526 * frame.c (Fmouse_position, Fmouse_pixel_position):
5527 Use Time, not unsigned long, for user-interface timestamps.
5528 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5529 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5530 * keyboard.h (last_event_timestamp): Likewise.
5531 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5532 * menu.h (xmenu_show): Likewise.
5533 * term.c (term_mouse_position): Likewise.
5534 * termhooks.h (struct input_event.timestamp): Likewise.
5535 (struct terminal.mouse_position_hook): Likewise.
5536 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5537 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5538 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5539 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5540 what it was before.
5541 * menu.h, termhooks.h: Include "systime.h", for Time.
5542
8e55734a
PE
5543 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5544 Don't assume that the difference between two unsigned long values
5545 can fit into an integer. At this point, we know button_down_time
5546 <= event->timestamp, so the difference must be nonnegative, so
5547 there's no need to cast the result if double-click-time is
5548 nonnegative, as it should be; check that it's nonnegative, just in
5549 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5550 apart (about 25 days). (Bug#8664)
8e55734a 5551
841f1b75 5552 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5553 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5554
3e26f69c
PE
5555 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5556 that always fit in int. Use a sentinel instead of a counter, to
5557 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5558 * frame.h (struct frame): Use int for menu_bar_items_used
5559 instead of EMACS_INT, since it always fits in int.
3e26f69c 5560
5cc152c0
PE
5561 * menu.c (grow_menu_items): Check for int overflow.
5562
d89eb65e
PE
5563 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5564
5235bd3e
PE
5565 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5566 Before, the code was not consistent. These values cannot exceed
5567 2**31 - 1 so there's no need to make them unsigned.
5568 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5569 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5570 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5571 as modifiers.
5572 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5573
bc827e23
PE
5574 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5575 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5576 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5577 presumably because the widths might not match.
5578
78eb494e
PE
5579 * window.c (size_window): Avoid needless test at loop start.
5580
04f2d78b
CB
55812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5582
5583 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5584
d2fc7e3d 55852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5586
5587 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5588
d2fc7e3d 55892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5590
5591 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5592 `width' to `bar_area_x' and `bar_area_width', respectively.
5593 (x_scroll_run): Take account of fringe background extension.
5594
04f2d78b
CB
5595 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5596 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5597 `bar_area_width', respectively.
5598 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5599 background extension.
5600
79b70037
GM
56012011-05-10 Jim Meyering <meyering@redhat.com>
5602
5603 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5604
2f142cc5
JB
56052011-05-10 Juanma Barranquero <lekktu@gmail.com>
5606
5607 * image.c (Finit_image_library): Return t for built-in image types,
5608 like pbm and xbm. (Bug#8640)
5609
57679c86
AS
56102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5611
5612 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5613
888c9e86
EZ
56142011-05-07 Eli Zaretskii <eliz@gnu.org>
5615
b0512a1d
EZ
5616 * w32console.c (Fset_screen_color): Doc fix.
5617 (Fget_screen_color): New function.
5618 (syms_of_ntterm): Defsubr it.
5619
7285dc67
EZ
5620 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5621 unlink the temporary file if Fcall_process didn't create it in the
5622 first place.
5623 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5624 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5625 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5626 cue to call_process_cleanup not to close that handle.
5627
4d3fcc8e
BK
56282011-05-07 Ben Key <bkey76@gmail.com>
5629
5630 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5631 one of two shell specific rules, either bootstrap-temacs-CMD or
5632 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5633 to the previous implementation of the bootstrap-temacs rule.
5634 The bootstrap-temacs-CMD rule is similar to the previous
5635 implementation of the bootstrap-temacs rule except that it
5636 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5637 variable.
5638
5639 These changes, along with some changes to nt/configure.bat,
5640 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5641 earlier fix to add support for --cflags and --ldflags options
5642 that include quotes so that it works whether make uses cmd or
5643 sh as the shell.
5644
b4289b64
MA
56452011-05-06 Michael Albinus <michael.albinus@gmx.de>
5646
5647 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5648 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5649 is a constant.
5650 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5651 a string. Handle both cases.
5652 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5653 (Fdbus_register_method): Use Qinvalid_function.
5654
af4c0e28
JB
56552011-05-06 Juanma Barranquero <lekktu@gmail.com>
5656
5657 * makefile.w32-in: Update dependencies.
5658 (LISP_H): Add inttypes.h and stdin.h.
5659 (PROCESS_H): Add unistd.h.
5660
c51453d9
EZ
56612011-05-06 Eli Zaretskii <eliz@gnu.org>
5662
5663 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5664 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5665
8ff0ac3c 56662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5667
4c4b566b
PE
5668 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5669
aab2b9b5
PE
5670 * term.c (vfatal): Remove stray call to va_end.
5671 It's not needed and the C Standard doesn't allow it here anyway.
5672
c378da0b
PE
5673 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5674 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5675
288b08c7
PE
5676 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5677 bytes.
5678
e3601888
PE
5679 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5680
db6c0e74
PE
5681 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5682
dd5963ea
PE
5683 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5684
88c9450f
PE
5685 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5686
2f9442b8
PE
5687 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5688
c032b5f8
PE
5689 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5690 * charset.c (Fdefine_charset_internal): Don't initialize
5691 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5692 32-bit int (Bug#8600).
a108c10b
PE
5693
5694 * lread.c (read_integer): Be more consistent with string-to-number.
5695 Use string_to_number to do the actual conversion; this avoids
5696 rounding errors and fixes some other screwups. Without this fix,
5697 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5698 (digit_to_number): Move earlier, for benefit of read_integer.
5699 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5700 not a digit in any supported base. (Bug#8602)
a108c10b 5701
ad5f9eea
PE
5702 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5703
aec1708a
PE
5704 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5705 to match comment at start of function. This also removes a
5706 GCC warning about overflow in a 32+64-bit port.
5707
47be4ab5
PE
5708 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5709
371cac43
PE
5710 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5711 Reported by Stefan Monnier in
5712 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5713 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5714 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5715
d01a7826
PE
5716 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5717 (EMACS_UINTPTR): Likewise, with uintptr_t.
5718
7fd47d5c
PE
5719 * lisp.h: Prefer 64-bit EMACS_INT if available.
5720 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5721 on 32-bit hosts that have 64-bit int, so that they can access
5722 large files.
122b0c86
PE
5723 However, temporarily disable this change unless the temporary
5724 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5725
8727937b
PE
5726 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5727
8ac068ac
PE
5728 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5729 This removes an assumption that EMACS_INT and long are the same
5730 width as pointers. The assumption is true for Emacs porting targets
5731 now, but we want to make other targets possible.
5732 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5733 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5734 In the rest of the code, change types of integers that hold casted
5735 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5736 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5737 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5738 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5739 No need to cast type when ORing.
5740 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5741 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5742 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5743 assume EMACS_INT is the same width as char *.
5744 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5745 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5746 Remove no-longer-needed casts.
5747 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5748 (xg_tool_bar_help_callback, xg_make_tool_item):
5749 Use EMACS_INTPTR to hold an integer
5750 that will be cast to void *; this can avoid a GCC warning
5751 if EMACS_INT is not the same width as void *.
5752 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5753 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5754 (current_message_1, set_message_1):
5755 Use a local to convert to proper width without a cast.
5756 * xmenu.c (dialog_selection_callback): Likewise.
5757
ede49d71
PE
5758 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5759 Also, don't assume VALBITS / RAND_BITS is less than 5,
5760 and don't rely on undefined behavior when shifting a 1 left into
5761 the sign bit.
5762 * lisp.h (get_random): Change signature to match.
5763
2f30ecd0
PE
5764 * lread.c (hash_string): Use size_t, not int, for hash computation.
5765 Normally we prefer signed values; but hashing is special, because
5766 it's better to use unsigned division on hash table sizes so that
5767 the remainder is nonnegative. Also, size_t is the natural width
5768 for hashing into memory. The previous code used 'int', which doesn't
5769 retain enough info to hash well into very large tables.
5770 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5771
2a866e7b
PE
5772 * dbusbind.c: Don't possibly lose pointer info when converting.
5773 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5774 Use XPNTR rather than XHASH, so that the high-order bits of
5775 the pointer aren't lost when converting through void *.
5776
51639eac
PE
5777 * eval.c (Fautoload): Don't double-shift a pointer.
5778
92394119
PE
5779 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5780
dbdb9a7c
JB
57812011-05-06 Juanma Barranquero <lekktu@gmail.com>
5782
5783 * gnutls.c (DEF_GNUTLS_FN):
5784 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5785
db7a0b4f
AS
57862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5787
5788 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5789 marker. (Bug#8610)
5790
f7ff1b0f 57912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5792
5793 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5794 New version that can reserve upto 2GB of heap space.
5795
f7ff1b0f 57962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5797
5798 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5799
639c109b
TZ
58002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5801
5802 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5803 `gnutls_certificate_set_x509_key_file'.
5804
d2127135
JB
58052011-05-05 Juanma Barranquero <lekktu@gmail.com>
5806
5807 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5808 Update dependencies.
5809
e968f4f3
JB
58102011-05-04 Juanma Barranquero <lekktu@gmail.com>
5811
5812 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5813 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5814 Remove unused parameter `fildes'.
5815 * process.c (read_process_output, send_process): Don't pass it.
5816
84d358f0
JB
58172011-05-04 Juanma Barranquero <lekktu@gmail.com>
5818
5819 Fix previous change: the library cache is defined in w32.c.
5820 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5821 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5822
0898ca10
JB
58232011-05-04 Juanma Barranquero <lekktu@gmail.com>
5824
5825 Implement dynamic loading of GnuTLS on Windows.
5826
5827 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5828 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5829 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5830 Declare.
5831
5832 * gnutls.c (Qgnutls_dll): Define.
5833 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5834 (gnutls_*): Declare function pointers.
5835 (init_gnutls_functions): New function to initialize function pointers.
5836 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5837 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5838 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5839 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5840 (emacs_gnutls_write, emacs_gnutls_read)
5841 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5842 (Fgnutls_available_p): New function.
5843 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5844 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5845 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5846
5847 * image.c: Include w32.h.
5848 (Vimage_type_cache): Delete.
5849 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5850 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5851 (w32_delayed_load): Move to w32.c.
5852
5853 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5854
5855 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5856 (w32_delayed_load): Move from image.c. When loading a library, record
5857 its filename in the :loaded-from property of the library id.
5858 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5859 Initialize and staticpro them.
5860 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5861
5862 * process.c: Include lisp.h before w32.h, not after.
5863 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5864 instead of gnutls_record_check_pending.
5865
5866 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5867
ff4de4aa
TZ
58682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5869
5870 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5871 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5872 as passed in.
5873
abe95abb
JD
58742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5875
5876 * xterm.c (x_set_frame_alpha): Do not set property on anything
5877 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5878
e16e55d4
JB
58792011-05-02 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5882
bafcf6a5
JB
58832011-05-02 Juanma Barranquero <lekktu@gmail.com>
5884
5885 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5886 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5887 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5888 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5889 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5890 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5891 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5892 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5893 (Qgnutls_bootprop_callbacks_verify): Make static.
5894
e7a6747f
AS
58952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5896
19ed11ba
AS
5897 * callproc.c: Indentation fixup.
5898
e7a6747f 5899 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5900 (wait_for_termination, interruptible_wait_for_termination):
5901 Move after wait_for_termination_1.
e7a6747f 5902
1ef14cb4
LMI
59032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5904
5905 * sysdep.c (interruptible_wait_for_termination): New function
5906 which is like wait_for_termination, but allows keyboard
5907 interruptions.
5908
5909 * callproc.c (Fcall_process): Add (:file "file") as an option for
5910 the STDOUT buffer.
5911 (Fcall_process_region): Ditto.
5912
330d880c
EZ
59132011-04-30 Eli Zaretskii <eliz@gnu.org>
5914
8db90b73
EZ
5915 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5916 rather than `XVECTOR (FOO)->size'.
5917
330d880c
EZ
5918 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5919 inttypes.h, as a gnulib replacement is used if it not available in
5920 system headers.
5921
15cbd324
EZ
59222011-04-21 Eli Zaretskii <eliz@gnu.org>
5923
5924 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5925 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5926 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5927
5928 * coding.c (coding_alloc_by_realloc): Error out if destination
5929 will grow beyond MOST_POSITIVE_FIXNUM.
5930 (decode_coding_emacs_mule): Abort if there isn't enough place in
5931 charbuf for the composition carryover bytes. Reserve an extra
5932 space for up to 2 characters produced in a loop.
5933 (decode_coding_iso_2022): Abort if there isn't enough place in
5934 charbuf for the composition carryover bytes.
5935
59362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5937
ae940cca
EZ
5938 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5939 aborting when %lld or %lll format is passed.
5940 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5941 %llo or %llx format is passed. (Bug#8545)
5942
03ab8921
EZ
5943 * window.c (window_scroll_line_based): Use a marker instead of
5944 simple variables to record original value of point. (Bug#7952)
5945
afda1437
EZ
5946 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5947 produced by %s or %c overflows available buffer space. (Bug#8545)
5948
f76dee0c
PE
59492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5950
5951 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5952 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5953
fdc5744d
JB
59542011-04-28 Juanma Barranquero <lekktu@gmail.com>
5955
5956 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5957
638f053a
JB
59582011-04-28 Juanma Barranquero <lekktu@gmail.com>
5959
5960 * keyboard.c (Qdelayed_warnings_hook): Define.
5961 (command_loop_1): Run `delayed-warnings-hook'
5962 if Vdelayed_warnings_list is non-nil.
5963 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5964 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5965
d178f871
EZ
59662011-04-28 Eli Zaretskii <eliz@gnu.org>
5967
5968 * doprnt.c (doprnt): Don't return value smaller than the buffer
5969 size if the message was truncated. (Bug#8545).
5970
b124fd93
JB
59712011-04-28 Juanma Barranquero <lekktu@gmail.com>
5972
5973 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5974 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5975
e810457d
PE
59762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5979
ea51cceb
JB
59802011-04-27 Juanma Barranquero <lekktu@gmail.com>
5981
5982 * makefile.w32-in: Update dependencies.
5983
94dcfacf
EZ
59842011-04-27 Eli Zaretskii <eliz@gnu.org>
5985
5986 Improve `doprnt' and its usage. (Bug#8545)
5987 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5988 `format_end'. Remove support for %l as a conversion specifier.
5989 Don't use xrealloc. Improve diagnostics when the %l size modifier
5990 is used. Update the commentary.
5991
5992 * eval.c (verror): Simplify calculation of size_t.
5993
5994 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5995 messages.
5996
f61f41d7
PE
59972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5998
5999 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6000 change.
6001
96fb4434
PE
60022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6003
6004 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6005 This makes this file independent of the recent pseudovector change.
6006
671875da 60072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6008
69e9b5a3
PE
6009 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6010
b5f869a7 6011 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6012 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6013 Remove unused local.
c8926152 6014 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6015
841a1577 6016 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6017 GCC 4.6.0 optimizes based on type-based alias analysis.
6018 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6019 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6020 != &v->size, and therefore "v->size = 1; b->size = 2; return
6021 v->size;" must therefore return 1. This assumption is incorrect
6022 for Emacs, since it type-puns struct Lisp_Vector * with many other
6023 types. To fix this problem, this patch adds a new type struct
f904488f 6024 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6025 and pseudovectors, and helps optimizing compilers not get fooled
6026 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6027 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6028 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6029 the size member.
eab3844f
PE
6030 (XSETPVECTYPE): Rewrite in terms of new macro.
6031 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6032 This is a bit clearer, and further avoids the possibility of
6033 undesirable aliasing.
6034 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6035 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6036 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6037 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6038 (ASIZE): Now uses header.size rather than size.
6039 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6040 to avoid the hassle of writing XVECTOR (foo)->header.size.
6041 (struct vectorlike_header): New type.
eab3844f
PE
6042 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6043 object, to help avoid aliasing.
6044 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6045 (SUBRP): Likewise, since Lisp_Subr is a special case.
6046 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6047 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6048 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6049 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6050 changed to be "header.size" and "header.next".
6051 * buffer.h (struct buffer): Likewise.
6052 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6053 * frame.h (struct frame): Likewise.
6054 * process.h (struct Lisp_Process): Likewise.
6055 * termhooks.h (struct terminal): Likewise.
6056 * window.c (struct save_window_data, struct saved_window): Likewise.
6057 * window.h (struct window): Likewise.
6058 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6059 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6060 * buffer.c (init_buffer_once): Likewise.
6061 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6062 special case.
6063 * process.c (Fformat_network_address): Use local var for size,
6064 for brevity.
6065
0df1eac5
PE
6066 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6067
847ab9d1 6068 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6069 * data.c (atof): Remove decl; no longer used or needed.
6070 (digit_to_number): Move to lread.c.
6071 (Fstring_to_number): Use new string_to_number function, to be
6072 consistent with how the Lisp reader treats infinities and NaNs.
6073 Do not assume that floating-point numbers represent EMACS_INT
6074 without losing information; this is not true on most 64-bit hosts.
6075 Avoid double-rounding errors, by insisting on integers when
6076 parsing non-base-10 numbers, as the documentation specifies.
6077 * lisp.h (string_to_number): New decl, replacing ...
6078 (isfloat_string): Remove.
bc0a5c13 6079 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6080 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6081 appears to have been a coding error. Similarly, do not accept
6082 strings like +-1e0 as floating point numbers. Do not report
6083 overflow for integer overflows unless the base is not 10 which
6084 means we have no simple and reliable way to continue.
6085 Break out the floating-point parsing into a new
6086 function string_to_number, so that Fstring_to_number parses
6087 floating point numbers consistently with the Lisp reader.
04f2d78b 6088 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6089 (E_CHAR, EXP_INT): Remove, replacing with ...
6090 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6091 (string_to_number): New function, replacing isfloat_string.
6092 This function checks for valid syntax and produces the resulting
6093 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6094 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6095 so that overflow for non-base-10 numbers is reported only when
6096 there's no portable and simple way to convert to floating point.
452f4150 6097
67769ffc
PE
6098 * textprop.c (set_text_properties_1): Rewrite for clarity,
6099 and to avoid GCC warning about integer overflow.
6100
c20db43f
PE
6101 * intervals.h (struct interval): Use EMACS_INT for members
6102 where EMACS_UINT might cause problems. See
6103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6104 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6105 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6106 All uses changed.
37aa2f85
PE
6107 (offset_intervals): Tell GCC not to worry about length overflow
6108 when negating a negative length.
c20db43f 6109
2538aa2f
PE
6110 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6111 (overrun_check_free): Likewise.
6112
f2d3008d
PE
6113 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6114 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6115 word size.
6116
ec8df744
PE
6117 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6118 (gnutls_make_error): Rename local to avoid shadowing.
6119 (gnutls_emacs_global_deinit): ifdef out; not used.
6120 (Fgnutls_boot): Use const for pointer to readonly storage.
6121 Comment out unused local. Fix pointer signedness problems.
6122
640ee02d
PE
6123 * lread.c (openp): Don't stuff size_t into an 'int'.
6124 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6125 about possible signed overflow.
6126
6048fb2a
PE
6127 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6128 (GDK_KEY_g): Don't define if already defined.
6129 (xg_prepare_tooltip): Avoid pointer signedness problem.
6130 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6131
fa3c87e1
PE
6132 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6133 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6134
2172544b
PE
6135 * xfns.c (Fx_window_property): Simplify a bit,
6136 to make a bit faster and to avoid GCC 4.6.0 warning.
6137 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6138
9b821a21
PE
6139 * fns.c (internal_equal): Don't assume size_t fits in int.
6140
3c616cfa
PE
6141 * alloc.c (compact_small_strings): Tighten assertion a little.
6142
c2982e87
PE
6143 Replace pEd with more-general pI, and fix some printf arg casts.
6144 * lisp.h (pI): New macro, generalizing old pEd macro to other
6145 conversion specifiers. For example, use "...%"pI"d..." rather
6146 than "...%"pEd"...".
6147 (pEd): Remove. All uses replaced with similar uses of pI.
6148 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6149 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6150 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6151 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6152 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6153 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6154 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6155 64-bit hosts.
6156 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6157 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6158 * print.c (safe_debug_print, print_object): Likewise.
6159 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6160 to int.
6f04d126
PE
6161 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6162 avoiding the 0 flag, which is not portable.
c2982e87
PE
6163 * process.c (Fmake_network_process): Use pI to avoid cast.
6164 * region-cache.c (pp_cache): Likewise.
6165 * xdisp.c (decode_mode_spec): Likewise.
6166 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6167 behavior on 64-bit hosts with printf arg.
6f04d126 6168 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6169 (x_stop_queuing_selection_requests): Likewise.
6170 (x_get_window_property): Don't truncate byte count to an 'int'
6171 when tracing.
0b432f21 6172
5e073ec7
PE
6173 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6174 here, since it parses constructs like leading '-' and spaces,
6175 which are not wanted; and it overflows with large numbers.
6176 Instead, simply match F[0-9]+, which is what is wanted anyway.
6177
36372bf9
PE
6178 * alloc.c: Remove unportable assumptions about struct layout.
6179 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6180 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6181 (allocate_vectorlike, make_pure_vector): Use the new macros,
6182 plus offsetof, to remove unportable assumptions about struct layout.
6183 These assumptions hold on all porting targets that I know of, but
6184 they are not guaranteed, they're easy to remove, and removing them
6185 makes further changes easier.
6186
0b432f21
PE
6187 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6188 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6189 (string_overrun_cookie): Now const. Use initializers that
6190 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6191 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6192 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6193 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6194 multiple of sizeof (EMACS_INT); it need not be, if
6195 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6196 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6197
895009e1
JB
61982011-04-26 Juanma Barranquero <lekktu@gmail.com>
6199
6200 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6201
6a7a1b0b
TZ
62022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6203
6204 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6205 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6206 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6207
841a1577 62082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6209
6210 * lisp.h (Qdebug): List symbol.
895009e1 6211 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6212 * keyboard.c (debug-on-event): New variable.
6213 (handle_user_signal): Break into debugger when debug-on-event
6214 matches the current signal symbol.
6215
f2d3ba6f
DN
62162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6217
6218 * alloc.c (check_sblock, check_string_bytes)
6219 (check_string_free_list): Convert to standard C.
6220
42ce4c63
TZ
62212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6222
6223 * w32.c (emacs_gnutls_push): Fix typo.
6224
825cd63c
EZ
62252011-04-25 Eli Zaretskii <eliz@gnu.org>
6226
fb11d64d
EZ
6227 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6228 "cast to pointer from integer of different size".
6229
825cd63c
EZ
6230 Improve doprnt and its use in verror. (Bug#8545)
6231 * doprnt.c (doprnt): Document the set of format control sequences
6232 supported by the function. Use SAFE_ALLOCA instead of always
6233 using `alloca'.
6234
6235 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6236 is one byte too soon. Don't use xrealloc; instead xfree and
6237 xmalloc anew.
6238
e061a11b
TZ
62392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6240
6241 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6242 callbacks stage.
6243
6244 * gnutls.c: Renamed global_initialized to
6245 gnutls_global_initialized. Added internals for the
6246 :verify-hostname-error, :verify-error, and :verify-flags
6247 parameters of `gnutls-boot' and documented those parameters in the
6248 docstring. Start callback support.
9173deec
JB
6249 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6250 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6251 on error. Return error code.
e061a11b
TZ
6252 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6253 (emacs_gnutls_read): Likewise.
6254 (Fgnutls_boot): Return handshake error code.
6255 (emacs_gnutls_handle_error): New function.
6256 (wsaerror_to_errno): Likewise.
6257
6258 * w32.h (emacs_gnutls_pull): Add prototype.
6259 (emacs_gnutls_push): Likewise.
6260
6261 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6262 (emacs_gnutls_push): Likewise.
6263
62642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6265
6266 * process.c (wait_reading_process_output): Check if GnuTLS
6267 buffered some data internally if no FDs are set for TLS
6268 connections.
6269
6270 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6271 (LIBS): Link to USER_LIBS.
6272 ($(BLD)/gnutls.$(0)): New target.
6273
fa6996bc
EZ
62742011-04-24 Eli Zaretskii <eliz@gnu.org>
6275
eb35682e
EZ
6276 * xdisp.c (handle_single_display_spec): Rename the
6277 display_replaced_before_p argument into display_replaced_p, to
6278 make it consistent with the commentary. Fix typos in the
6279 commentary.
6280
e2ad650c
EZ
6281 * textprop.c (syms_of_textprop): Remove dead code.
6282 (copy_text_properties): Delete obsolete commentary about an
6283 interface that was deleted long ago. Fix typos in the description
6284 of arguments.
6285
1b2de274
EZ
6286 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6287 to changes in oldXMenu/XMenu.h from 2011-04-16.
6288 <menu_help_message, prev_menu_help_message>: Constify.
6289 (IT_menu_make_room): menu->help_text is now `const char **';
6290 adjust.
6291
6292 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6293 to changes in oldXMenu/XMenu.h from 2011-04-16.
6294 (struct XMenu): Declare `help_text' `const char **'.
6295
6296 * xfaces.c <Qunspecified>: Make extern again.
6297
6298 * syntax.c: Include sys/types.h before including regex.h, as
6299 required by Posix.
6300
762b15be
EZ
6301 * doc.c (get_doc_string): Improve the format passed to `error'.
6302
6303 * doprnt.c (doprnt): Improve commentary.
6304
6305 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6306
6307 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6308 them with etags.
6309
f1052e5d
EZ
6310 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6311 changes in globals.h immediately force recompilation.
762b15be
EZ
6312 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6313 $(CURDIR)/s/ms-w32.h.
6314 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6315
fa6996bc
EZ
6316 * character.c (Fchar_direction): Function deleted.
6317 (syms_of_character): Don't defsubr it.
6318 <char-direction-table>: Deleted.
6319
e6c3da20
EZ
63202011-04-23 Eli Zaretskii <eliz@gnu.org>
6321
6322 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6323 * doprnt.c: Include limits.h.
6324 (SIZE_MAX): New macro.
04f2d78b
CB
6325 (doprnt): Return a size_t value. 2nd arg is now size_t.
6326 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6327 Improve overflow protection. Support `l' modifier for integer
6328 conversions. Support %l conversion. Don't assume an EMACS_INT
6329 argument for integer conversions and for %c.
6330
6331 * lisp.h (doprnt): Restore prototype.
6332
6333 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6334 $(SRC)/character.h.
6335
6336 * Makefile.in (base_obj): Add back doprnt.o.
6337
6338 * deps.mk (doprnt.o): Add back prerequisites.
6339 (callint.o): Depend on character.h.
6340
6341 * eval.c (internal_lisp_condition_case): Include the handler
6342 representation in the error message.
6343 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6344 when breaking from the loop.
6345
6346 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6347
6348 * callint.c (Fcall_interactively): When displaying error message
6349 about invalid control letter, pass the character's codepoint, not
6350 a pointer to its multibyte form. Improve display of the character
6351 in octal and display also its hex code.
6352
6353 * character.c (char_string): Use %x to display the (unsigned)
6354 codepoint of an invalid character, to avoid displaying a bogus
6355 negative value.
6356
6357 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6358 `error', not SYMBOL_NAME itself.
6359
6360 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6361 character arguments to `error'.
6362
6363 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6364 to `error' in error message about FINAL_CHAR argument. Make sure
6365 FINAL_CHAR is a character, and use %c when it is passed as
6366 argument to `error'.
6367
4ffd0d6b 63682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6369
6370 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6371
6372 * w32.c: Include <time.h>.
6373 (sys_localtime): New function.
6374
4ffd0d6b 63752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6376
6377 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6378
4ffd0d6b 6379 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6380
4ffd0d6b 63812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6382
4ffd0d6b
GM
6383 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6384 zombies (Bug#8467).
aac0c6e3 6385
04c56954
EZ
63862011-04-19 Eli Zaretskii <eliz@gnu.org>
6387
6388 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6389 gl_state.e_property when gl_state.object is Qt.
6390
6391 * insdel.c (make_gap_larger): Remove limitation of buffer size
6392 to <= INT_MAX.
6393
16a43933
CY
63942011-04-18 Chong Yidong <cyd@stupidchicken.com>
6395
6396 * xdisp.c (lookup_glyphless_char_display)
6397 (produce_glyphless_glyph): Handle cons cell entry in
6398 glyphless-char-display.
6399 (Vglyphless_char_display): Document it.
6400
6401 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6402 glyphless-char-display.
6403
4581706e
CY
64042011-04-17 Chong Yidong <cyd@stupidchicken.com>
6405
6406 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6407
6408 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6409
6410 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6411 definition for no-X builds.
6412
4887c6e2 64132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6414
fd35b6f9
PE
6415 Static checks with GCC 4.6.0 and non-default toolkits.
6416
5c1ccb01
PE
6417 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6418
006c5daa
PE
6419 * process.c (keyboard_bit_set): Define only if SIGIO.
6420 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6421 (send_process): Repair possible setjmp clobbering.
6422
efc736d3
PE
6423 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6424
4e2fe2e6
PE
6425 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6426
f97334a2
PE
6427 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6428
4e75f29d
PE
6429 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6430 Define only if needed.
6431
90efadd1
PE
6432 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6433 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6434 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6435
3c647824
PE
6436 * dispextern.h (struct redisplay_interface): Rename param
6437 to avoid shadowing.
e264f262 6438 * termhooks.h (struct terminal): Likewise.
761383f4 6439 * xterm.c (xembed_send_message): Likewise.
3c647824 6440
b58c5c4a
PE
6441 * insdel.c (make_gap_smaller): Define only if
6442 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6443
cad59032
PE
6444 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6445 it.
6446
c339dc2e
PE
6447 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6448 so that we aren't warned about unused symbols.
6449
91a3e27b
PE
6450 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6451
399c71d3 6452 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6453
8ffc96f5
PE
6454 * xfns.c (x_real_positions): Mark locals as initialized.
6455
eef9bc79
PE
6456 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6457
098db9dd
PE
6458 * xterm.c: Fix problems found by static analysis with other toolkits.
6459 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6460 (x_dispatch_event): Declare static if USE_GTK, and
6461 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6462 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6463 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6464 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6465 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6466
eb18f6cc
PE
6467 * xmenu.c (menu_help_callback): Pointer type fixes.
6468 Use const pointers when pointing at readonly data. Avoid pointer
6469 signedness clashes.
6470 (FALSE): Remove unused macro.
6471 (update_frame_menubar): Remove unused decl.
6472
1fe72bf8
PE
6473 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6474
60d9e1db
PE
6475 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6476 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6477 (single_menu_item): Rename local to avoid shadowing.
6478
39261c26
PE
6479 * keyboard.c (make_lispy_event): Remove unused local var.
6480
018c5e19
PE
6481 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6482 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6483
63d2b86e
PE
6484 * bitmaps: Change bitmaps from unsigned char back to the X11
6485 compatible char. Avoid the old compiler warnings about
6486 out-of-range initializers by using, for example, '\xab' rather
6487 than 0xab.
6488
aefd87e1
PE
6489 * xgselect.c (xgselect_initialize): Check vs interface
6490 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6491
bf501fb9
PE
6492 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6493
e9829fdf
PE
6494 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6495 to read-only memory.
6496
1086c095
PE
6497 * fns.c (vector): Remove; this old hack is no longer needed.
6498
2baccd04 6499 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6500 Remove unused var.
dde42981 6501 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6502
72391843 6503 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6504
436c16df 6505 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6506 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6507 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6508
92bb796d 6509 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6510 (x_term_init): Remove local to avoid shadowing.
92bb796d 6511
764430a3 6512 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6513
6514 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6515 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6516
d1dfb56c
EZ
65172011-04-16 Eli Zaretskii <eliz@gnu.org>
6518
c4354cb4
EZ
6519 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6520
d1dfb56c
EZ
6521 Fix regex.c, syntax.c and friends for buffers > 2GB.
6522 * syntax.h (struct gl_state_s): Declare character position members
6523 EMACS_INT.
6524
6525 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6526
04f2d78b
CB
6527 * textprop.c (verify_interval_modification, interval_of):
6528 Declare arguments EMACS_INT.
d1dfb56c
EZ
6529
6530 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6531 EMACS_INT.
6532
6533 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6534
6535 * indent.c (Fvertical_motion): Local variable it_start is now
6536 EMACS_INT.
6537
6538 * regex.c (re_match, re_match_2, re_match_2_internal)
6539 (bcmp_translate, regcomp, regexec, print_double_string)
6540 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6541 (re_compile_pattern, re_exec): Declare arguments and local
6542 variables `size_t' and `ssize_t' and return values `regoff_t', as
6543 appropriate.
6544 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6545 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6546 <compile_stack_type>: `size' and `avail' are now `size_t'.
6547
6548 * regex.h <regoff_t>: Use ssize_t, not int.
6549 (re_search, re_search_2, re_match, re_match_2): Arguments that
6550 specify buffer/string position and length are now ssize_t and
6551 size_t. Return type is regoff_t.
6552
613052cd
BK
65532011-04-16 Ben Key <bkey76@gmail.com>
6554
6555 * nsfont.m: Fixed bugs in ns_get_family and
6556 ns_descriptor_to_entity that were caused by using free to
6557 deallocate memory blocks that were allocated by xmalloc (via
6558 xstrdup). This caused Emacs to crash when compiled with
6559 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6560 --enable-checking=xmallocoverrun). xfree is now used to
6561 deallocate these memory blocks.
6562
4170f62f 65632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6564
71b41406
PE
6565 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6566
9587a89d
PE
6567 emacs_write: Accept and return EMACS_INT for sizes.
6568 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6569 et seq.
6570 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6571 Accept and return EMACS_INT.
6572 (emacs_gnutls_write): Return the number of bytes written on
6573 partial writes.
6574 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6575 (emacs_read, emacs_write): Remove check for negative size, as the
6576 Emacs source code has been audited now.
9587a89d
PE
6577 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6578 (emacs_read, emacs_write): Use it.
273a5f82
PE
6579 * process.c (send_process): Adjust to the new signatures of
6580 emacs_write and emacs_gnutls_write. Do not attempt to store
6581 a byte offset into an 'int'; it might overflow.
9587a89d 6582 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6583
3e047f51
PE
6584 * sound.c: Don't assume sizes fit in 'int'.
6585 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6586 Return EMACS_INT, not int.
3e047f51 6587 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6588 Accept EMACS_INT, not int.
6589 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6590 record read return values.
6591
cc39a9db
BK
65922011-04-15 Ben Key <bkey76@gmail.com>
6593
c9d0ec6d
JB
6594 * keyboard.c (Qundefined): Don't declare static since it is used
6595 in nsfns.m.
6596 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6597 static since they are used in nsfont.m.
cc39a9db 6598
6c60eb9f
SM
65992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6600
6601 * process.c (Qprocessp): Don't declare static.
6602 * lisp.h (Qprocessp): Declare again.
6603
7990b61a
JB
66042011-04-15 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6607
5d4cb038
PE
66082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6609
8bd7b830 6610 Improve C-level modularity by making more things 'static'.
cd64ea1d 6611
e3b27b31
PE
6612 Don't publish debugger-only interfaces to other modules.
6613 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6614 (verify_bytepos, count_markers): Move decls to the only modules
6615 that need them.
6616 * region-cache.h (pp_cache): Likewise.
6617 * window.h (check_all_windows): Likewise.
6618 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6619
5d4cb038
PE
6620 * sysdep.c (croak): Now static, if
6621 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6622 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6623
6624 * alloc.c (refill_memory_reserve): Now static if
6625 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6626 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6627
e87b6180
PE
6628 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6629 Define only if USE_LUCID.
6630
ac64929e
PE
6631 * xrdb.c (x_customization_string, x_rm_string): Now static.
6632
6f37259d
PE
6633 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6634 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6635
1683e3ab
PE
6636 * xdisp.c (draw_row_with_mouse_face): Now static.
6637 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6638
de9c2632
PE
6639 * window.h (check_all_windows): Mark externally visible.
6640
2b96acb7
PE
6641 * window.c (window_deletion_count): Now static.
6642
6643 * undo.c: Make symbols static if they're not exported.
6644 (last_undo_buffer, last_boundary_position, pending_boundary):
6645 Now static.
6646
50436f33
PE
6647 * textprop.c (interval_insert_behind_hooks): Now static.
6648 (interval_insert_in_front_hooks): Likewise.
6649
64520e5c
PE
6650 * term.c: Make symbols static if they're not exported.
6651 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6652 (max_frame_lines, tty_set_terminal_modes):
6653 (tty_reset_terminal_modes, tty_turn_off_highlight):
6654 (get_tty_terminal): Now static.
6655 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6656 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6657 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6658 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6659 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6660
1fa53021
PE
6661 * sysdep.c: Make symbols static if they're not exported.
6662 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6663 Now static.
6664 (sigprocmask_set, full_mask): Remove; unused.
6665 (wait_debugging): Mark as visible.
6666 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6667 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6668
d4b43b22
PE
6669 * syntax.c (syntax_temp): Define only if !__GNUC__.
6670
b7c513d0
PE
6671 * sound.c (current_sound_device, current_sound): Now static.
6672
989b29ad
PE
6673 * search.c (searchbufs, searchbuf_head): Now static.
6674
13a55a78
PE
6675 * scroll.c (scroll_cost): Remove; unused.
6676 * dispextern.h (scroll_cost): Remove decl.
6677
de68a1fc
PE
6678 * region-cache.h (pp_cache): Mark as externally visible.
6679
40ccffa6
PE
6680 * process.c: Make symbols static if they're not exported.
6681 (process_tick, update_tick, create_process, chan_process):
6682 (Vprocess_alist, proc_buffered_char, datagram_access):
6683 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6684 (deactivate_process): Mark defn as static, as well as decl.
6685 * lisp.h (create_process): Remove decl.
6686 * process.h (chan_process, Vprocess_alist): Remove decls.
6687
ad64fc97
PE
6688 * print.c: Make symbols static if they're not exported.
6689 (print_depth, new_backquote_output, being_printed, print_buffer):
6690 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6691 (print_interval, print_number_index, initial_stderr_stream):
6692 Now static.
6693 * lisp.h (Fprinc): Remove decl.
6694 (debug_output_compilation_hack): Mark as externally visible.
6695
adddb265
PE
6696 * sysdep.c (croak): Move decl from here to syssignal.h.
6697 * syssignal.h (croak): Put it here, so the API can be checked when
6698 'croak' is called from dissociate_if_controlling_tty.
6699
1717ede2
PE
6700 * minibuf.c: Make symbols static if they're not exported.
6701 (minibuf_save_list, choose_minibuf_frame): Now static.
6702 * lisp.h (choose_minibuf_frame): Remove decl.
6703
fa5fb2bc
PE
6704 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6705
1e3890d1
PE
6706 * lread.c: Make symbols static if they're not exported.
6707 (read_objects, initial_obarray, oblookup_last_bucket_number):
6708 Now static.
6709 (make_symbol): Remove; unused.
6710 * lisp.h (initial_obarray, make_symbol): Remove decls.
6711
8a1414fa
PE
6712 * keyboard.c: Make symbols static if they're not exported.
6713 (single_kboard, recent_keys_index, total_keys, recent_keys):
6714 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6715 (this_single_command_key_start, echoing, last_auto_save):
6716 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6717 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6718 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6719 (Vlispy_mouse_stem, double_click_count):
6720 Now static.
6721 (force_auto_save_soon): Define only if SIGDANGER.
6722 (ignore_mouse_drag_p): Now static if
6723 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6724 (print_help): Remove; unused.
6725 (stop_character, last_timer_event): Mark as externally visible.
6726 * keyboard.h (ignore_mouse_drag_p): Declare only if
6727 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6728 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6729 * lisp.h (echoing): Remove decl.
6730 (force_auto_save_soon): Declare only if SIGDANGER.
6731 * xdisp.c (redisplay_window): Simplify code, to make it more
6732 obvious that ignore_mouse_drag_p is not accessed if !defined
6733 USE_GTK && !defined HAVE_NS.
6734
93ea6e8f
PE
6735 * intervals.c: Make symbols static if they're not exported.
6736 (merge_properties_sticky, merge_interval_right, delete_interval):
6737 Now static.
6738 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6739
77382fcc
PE
6740 * insdel.c: Make symbols static if they're not exported.
6741 However, leave prepare_to_modify_buffer alone. It's never
6742 called from outside this function, but that appears to be a bug.
6743 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6744 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6745 (adjust_after_replace_noundo): Remove; unused.
6746 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6747 (signal_before_change): Remove decls.
77382fcc 6748
9306c32e
PE
6749 * indent.c (val_compute_motion, val_vmotion): Now static.
6750
cd44d2eb
PE
6751 * image.c: Make symbols static if they're not exported.
6752 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6753 if USE_GTK.
6754 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6755 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6756
ad9a7a06
PE
6757 * fringe.c (standard_bitmaps): Now static.
6758 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6759
81626931
PE
6760 * frame.c: Make symbols static if they're not exported.
6761 (x_report_frame_params, make_terminal_frame): Now static.
6762 (get_frame_param): Now static, unless HAVE_NS.
6763 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6764 (x_get_resource_string): Remove; not used.
6765 * frame.h (make_terminal_frame, x_report_frame_params):
6766 (x_get_resource_string); Remove decls.
6767 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6768 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6769
239f9db9
PE
6770 * font.c, fontset.c: Make symbols static if they're not exported.
6771 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6772 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6773 * font.c (font_close_object): Now static.
6774 * font.h (font_close_object): Remove.
6775 * fontset.c (FONTSET_OBJLIST): Remove.
6776 (free_realized_fontset) #if-0 the body, which does nothing.
6777 (face_suitable_for_char_p): #if-0, as it's never called.
6778 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6779 * xfaces.c (face_at_string_position):
6780 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6781 since 0 is always ASCII.
6782
dfcf3579
PE
6783 * fns.c (weak_hash_tables): Now static.
6784
5045092b
PE
6785 * fileio.c: Make symbols static if they're not exported.
6786 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6787 (Vwrite_region_annotation_buffers): Now static.
6788
57a96f5c
PE
6789 * eval.c: Make symbols static if they're not exported.
6790 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6791 * lisp.h (backtrace_list): Remove decl.
6792
35f08c38
PE
6793 * emacs.c: Make symbols static if they're not exported.
6794 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6795 (fatal_error_code, fatal_error_signal_hook, standard_args):
6796 Now static.
6797 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6798 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6799 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6800 * lisp.h (fatal_error_signal_hook): Remove decl.
6801 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6802
f44bd759
PE
6803 * editfns.c: Move a (normally-unused) function to its only use.
6804 * editfns.c, lisp.h (get_operating_system_release): Remove.
6805 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6806 worth the hassle of breaking this out.
6807
b532497d
PE
6808 * xterm.c: Make symbols static if they're not exported.
6809 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6810 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6811 (x_destroy_window, x_delete_display):
6812 Now static.
6813 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6814 (x_mouse_leave): Remove; unused.
6815 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6816 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6817 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6818 Remove decls.
6819 (x_mouse_leave): Declare only if WINDOWSNT.
6820 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6821 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6822 USE_X_TOOLKIT.
6823
1675728f
PE
6824 * ftxfont.c: Make symbols static if they're not exported.
6825 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6826 HAVE_FREETYPE.
6827 * font.h (ftxfont_driver): Likewise.
6828
e4cebfca
PE
6829 * xfns.c: Make symbols static if they're not exported.
6830 (x_last_font_name, x_display_info_for_name):
6831 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6832 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6833 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6834 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6835 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6836 (last_show_tip_args): Now static.
6837 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6838 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6839 (x_screen_planes): Remove; unused.
6840 * dispextern.h (x_screen_planes): Remove decl.
6841
5bf46f05
PE
6842 * dispnew.c: Make symbols static if they're not exported.
6843 * dispextern.h (redraw_garbaged_frames, scrolling):
6844 (increment_row_positions): Remove.
6845 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6846 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6847 Now static.
6848 (redraw_garbaged_frames): Remove; unused.
6849
435f4c28
PE
6850 * xfaces.c: Make symbols static if they're not exported.
6851 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6852 Remove decls.
6853 * xterm.h (defined_color): Remove decls.
6854 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6855 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6856 (menu_face_changed_default, defined_color, free_realized_face):
6857 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6858 (ascii_face_of_lisp_face): Remove; unused.
6859
8524aef3
PE
6860 * xdisp.c: Make symbols static if they're not exported.
6861 * dispextern.h (scratch_glyph_row, window_box_edges):
6862 (glyph_to_pixel_coords, set_cursor_from_row):
6863 (get_next_display_element, set_iterator_to_next):
6864 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6865 (show_mouse_face): Remove decls
6866 * frame.h (message_buf_print): Likewise.
6867 * lisp.h (pop_message, set_message, check_point_in_composition):
6868 Likewise.
6869 * xterm.h (set_vertical_scroll_bar): Likewise.
6870 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6871 (message_buf_print, scratch_glyph_row, displayed_buffer):
6872 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6873 (get_next_display_element, show_mouse_face, window_box_edges):
6874 (frame_to_window_pixel_xy, check_point_in_composition):
6875 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6876 (glyph_to_pixel_coords): Remove; unused.
6877
16390cd2
PE
6878 * dired.c (file_name_completion): Now static.
6879
6880 * dbusbind.c (xd_in_read_queued_messages): Now static.
6881
a25f4dfa
PE
6882 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6883 * data.c (circular_list_error): Remove.
6884
14a9c8df
PE
6885 * commands.h (last_point_position, last_point_position_buffer):
6886 (last_point_position_window): Remove decls.
6887 * keyboard.c: Make these variables static.
6888
04f2d78b
CB
6889 * coding.h (coding, code_convert_region, encode_coding_gap):
6890 Remove decls.
74ab6df5
PE
6891 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6892 (iso_code_class, detect_coding, code_convert_region): Now static.
6893 (encode_coding_gap): Remove; unused.
6894
38dfbee1
PE
6895 * chartab.c (chartab_chars, chartab_bits): Now static.
6896
a2cb4e63
PE
6897 * charset.h (charset_iso_8859_1): Remove decl.
6898 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6899 Now static.
6900
127198fd
PE
6901 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6902 * ccl.c (Vccl_program_table): Now static.
6903 (check_ccl_update): Remove; unused.
6904
d85b608f
PE
6905 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6906 * category.h: ... from here.
6907 * category.c (check_category_table, set_category_set): Now static.
6908
31cd66f3
PE
6909 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6910 * lisp.h: Remove these decls.
6911
c358e587
PE
6912 * buffer.c (buffer_count): Remove unused var.
6913
e78aecca
PE
6914 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6915 so that it's not optimized away.
6916 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6917 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6918 exported only to the debugger.
6919
e192d7d3 6920 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6921 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6922
92470028
PE
6923 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6924 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6925 was inaccessible from Lisp.
6926 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6927 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6928
244ed907
PE
6929 alloc.c: Import and export fewer symbols, and remove unused items.
6930 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6931 is defined.
6932 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6933 it's not optimized away by whole-program optimization.
6934 (message_enable_multibyte, free_misc): Remove.
6935 (catchlist, handlerlist, mark_backtrace):
6936 Declare only if BYTE_MARK_STACK.
6937 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6938 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6939 (message_enable_multibyte): Remove decl.
6940 (free_misc, interval_free_list, float_block, float_block_index):
6941 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6942 (cons_free_list, last_marked_index):
6943 Now static.
6944 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6945 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6946 (mark_backtrace): Define only if BYTE_MARK_STACK.
6947 * xdisp.c (message_enable_multibyte): Now static.
6948
61c2b50e 6949 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6950 This makes it easier for human readers (and static analyzers)
6951 to see whether these variables are used from other modules.
6952 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6953 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6954 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6955 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6956 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6957 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6958 * xmenu.c, xselect.c:
6959 Declare Q* vars static if they are not used in other modules.
6960 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6961 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6962 Remove decls of unexported vars.
6963 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6964
95c82688
PE
6965 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6966
16a97296
PE
6967 Make Emacs functions such as Fatom 'static' by default.
6968 This makes it easier for human readers (and static analyzers)
6969 to see whether these functions can be called from other modules.
6970 DEFUN now defines a static function. To make the function external
6971 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6972 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6973 (Finit_image_library):
16a97296
PE
6974 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6975 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6976 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6977 Remove decls, since these functions are now static.
6978 (Funintern, Fget_internal_run_time): New decls, since these functions
6979 were already external.
95c82688 6980
16a97296
PE
6981 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6982 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6983 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6984 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6985 * keyboard.c, keymap.c, lread.c:
6986 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6987 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6988 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6989 Mark functions with DEFUE instead of DEFUN,
6990 if they are used in other modules.
6991 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6992 decls for now-static functions.
6993 * buffer.h (Fdelete_overlay): Remove decl.
6994 * callproc.c (Fgetenv_internal): Mark as internal.
6995 * composite.c (Fremove_list_of_text_properties): Remove decl.
6996 (Fcomposition_get_gstring): New forward static decl.
6997 * composite.h (Fcomposite_get_gstring): Remove decl.
6998 * dired.c (Ffile_attributes): New forward static decl.
6999 * doc.c (Fdocumntation_property): New forward static decl.
7000 * eval.c (Ffetch_bytecode): New forward static decl.
7001 (Funintern): Remove extern decl; now in .h file where it belongs.
7002 * fileio.c (Fmake_symbolic_link): New forward static decl.
7003 * image.c (Finit_image_library): New forward static decl.
7004 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7005 * intervals.h (Fprevious_property_change):
7006 (Fremove_list_of_text_properties): Remove decls.
7007 * keyboard.c (Fthis_command_keys): Remove decl.
7008 (Fcommand_execute): New forward static decl.
7009 * keymap.c (Flookup_key): New forward static decl.
7010 (Fcopy_keymap): Now static.
7011 * keymap.h (Flookup_key): Remove decl.
7012 * process.c (Fget_process): New forward static decl.
7013 (Fprocess_datagram_address): Mark as internal.
7014 * syntax.c (Fsyntax_table_p): New forward static decl.
7015 (skip_chars): Remove duplicate decl.
7016 * textprop.c (Fprevious_property_change): New forward static decl.
7017 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7018 Now internal.
7019 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7020 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7021
785bbd42
PE
7022 * editfns.c (Fformat): Remove unreachable code.
7023
8b913b57
AS
70242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7025
7026 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7027 change. (Bug#8496)
7028
a6744a35
EZ
70292011-04-13 Eli Zaretskii <eliz@gnu.org>
7030
7031 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7032 when at ZV. (Bug#8487)
7033
e7974947
AS
70342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7035
baad03f0
AS
7036 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7037 (Bug#8437)
7038 * keyboard.c (parse_tool_bar_item): Likewise.
7039 * sound.c (sound_cleanup, alsa_close): Likewise.
7040 * termcap.c (tgetent): Likewise.
7041 * xfns.c (x_default_font_parameter): Likewise.
7042 * xsettings.c (read_and_apply_settings): Likewise.
7043
e7974947
AS
7044 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7045 (overrun_check_free): Protoize.
7046
28272684
PE
70472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7048
7049 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7050 since callers should never pass a negative size.
7051 Change the signature to match that of plain 'read' and 'write'; see
7052 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7053 * lisp.h: Update prototypes of emacs_write and emacs_read.
7054
11997c76
EZ
70552011-04-11 Eli Zaretskii <eliz@gnu.org>
7056
7057 * xdisp.c (redisplay_window): Don't try to determine the character
7058 position of the scroll margin if the window start point w->startp
e896f03c 7059 is outside the buffer's accessible region. (Bug#8468)
11997c76 7060
8a2cbd72
EZ
70612011-04-10 Eli Zaretskii <eliz@gnu.org>
7062
7063 Fix write-region and its subroutines for buffers > 2GB.
7064 * fileio.c (a_write, e_write): Modify declaration of arguments and
7065 local variables to support buffers larger than 2GB.
7066 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7067
7068 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7069 argument, local variables, and return value.
7070
7071 * lisp.h: Update prototypes of emacs_write and emacs_read.
7072
7073 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7074
4073e537 70752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7076
1ebfdcb6
PE
7077 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7078
b2ded58d
PE
7079 Fix more problems found by GCC 4.6.0's static checks.
7080
7d66342c
PE
7081 * xdisp.c (vmessage): Use a better test for character truncation.
7082
bbf47d44
PE
7083 * charset.c (load_charset_map): <, not <=, for optimization,
7084 and to avoid potential problems with integer overflow.
9248994d 7085 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7086 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7087 * editfns.c (Fformat): Likewise.
1e69125e 7088 * syntax.c (skip_chars): Likewise.
3befa583 7089
e3019616
PE
7090 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7091 This also lets GCC 4.6.0 generate slightly better loop code.
7092
becfa255
PE
7093 * callint.c (Fcall_interactively): <, not <=, for optimization.
7094 (Fcall_interactively): Count the number of arguments produced,
7095 not the number of arguments given. This is simpler and lets GCC
7096 4.6.0 generate slightly better code.
7097
dae0cd48
PE
7098 * ftfont.c: Distingish more carefully between FcChar8 and char.
7099 The previous code passed unsigned char * to a functions like
7100 strlen and xstrcasecmp that expect char *, which does not
7101 conform to the C standard.
7102 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7103 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7104 char * when the C standard requires it.
7105
76032d70
PE
7106 * keyboard.c (read_char): Remove unused var.
7107
eb3f1cc8
PE
7108 * eval.c: Port to Windows vsnprintf (Bug#8435).
7109 Include <limits.h>.
7110 (SIZE_MAX): Define if the headers do not.
7111 (verror): Do not give up if vsnprintf returns a negative count.
7112 Instead, grow the buffer. This ports to Windows vsnprintf, which
7113 does not conform to C99. Problem reported by Eli Zaretskii.
7114 Also, simplify the allocation scheme, by avoiding the need for
7115 calling realloc, and removing the ALLOCATED variable.
7116
70476b54
PE
7117 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7118
12020a9e
PE
7119 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7120 But keep the doprint source code for now, as we might revamp it
7121 and use it again (Bug#8435).
ea6c7ae6
PE
7122 * lisp.h (doprnt): Remove.
7123 * Makefile.in (base_obj): Remove doprnt.o.
7124 * deps.mk (doprnt.o): Remove.
7125
5fdb398c
PE
7126 error: Print 32- and 64-bit integers portably (Bug#8435).
7127 Without this change, on typical 64-bit hosts error ("...%d...", N)
7128 was used to print both 32- and 64-bit integers N, which relied on
7129 undefined behavior.
7130 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7131 New macro.
7132 * lisp.h (error, verror): Mark as printf-like functions.
7133 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7134 Report overflow in size calculations when allocating printf buffer.
7135 Do not truncate output string at its first null byte.
7136 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7137 Truncate the output at a character boundary, since vsnprintf does not
7138 do that.
7139 * charset.c (check_iso_charset_parameter): Convert internal
7140 character to string before calling 'error', since %c now has the
7141 printf meaning.
7142 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7143 overflow when computing char to be passed to 'error'. Do not
7144 pass Lisp_Object to 'error'; pass the integer instead.
7145 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7146 formatted with plain %d.
7147
b189fa66
PE
7148 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7149
bff87ef0
PE
7150 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7151
7e2cac20
PE
7152 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7153
ce4d90b5
PE
7154 * xterm.c (x_catch_errors): Remove duplicate declaration.
7155
266c9547
PE
7156 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7157
79c49ad2
PE
7158 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7159
368f4090
JM
71602011-04-10 Jim Meyering <meyering@redhat.com>
7161
7162 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7163 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7164 return ssize_t not "int", and use size_t as the buffer length.
7165 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7166 * gnutls.h: Update declarations.
7167 * process.c (read_process_output): Use ssize_t, to match.
7168 (send_process): Likewise.
7169
a32d4040
CY
71702011-04-09 Chong Yidong <cyd@stupidchicken.com>
7171
7172 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7173
8546720e 71742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7175
04f2d78b
CB
7176 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7177 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7178
8546720e
GM
7179 * xterm.c (handle_one_xevent):
7180 * xmenu.c (create_and_show_popup_menu):
7181 * xselect.c (x_decline_selection_request)
7182 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7183
0a2f5c1a 71842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7185
7186 Fix some uses of `int' instead of EMACS_INT.
7187 * search.c (string_match_1, fast_string_match)
7188 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7189 (scan_buffer, find_next_newline_no_quit)
7190 (find_before_next_newline, search_command, Freplace_match)
7191 (Fmatch_data): Make some `int' variables be EMACS_INT.
7192
7193 * xdisp.c (display_count_lines): 3rd argument and return value now
7194 EMACS_INT. All callers changed.
7195 (pint2hrstr): Last argument is now EMACS_INT.
7196
7197 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7198 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7199 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7200 (decode_coding_utf_16, decode_coding_emacs_mule)
7201 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7202 (decode_coding_ccl, decode_coding_charset)
7203 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7204 (decode_coding_iso_2022, decode_coding_emacs_mule)
7205 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7206 <char_offset, last_offset>: Declare EMACS_INT.
7207 (encode_coding_utf_8, encode_coding_utf_16)
7208 (encode_coding_emacs_mule, encode_invocation_designation)
7209 (encode_designation_at_bol, encode_coding_iso_2022)
7210 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7211 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7212 Declare EMACS_INT.
7213 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7214 (encode_invocation_designation): Last argument P_NCHARS is now
7215 EMACS_INT.
7216 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7217 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7218
7219 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7220 All users changed.
7221
7222 * ccl.c (Fccl_execute_on_string): Declare some variables
7223 EMACS_INT.
7224
8546720e 72252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7226
7227 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7228
4e19a977
CS
72292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7230
7231 * process.c (Fformat_network_address): Doc fix.
7232
87302331
R
72332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7234
ee7683eb 7235 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7236
cbb59342
CY
72372011-04-08 Chong Yidong <cyd@stupidchicken.com>
7238
7239 * keyboard.c (read_char): Call Lisp function help-form-show,
7240 instead of using internal_with_output_to_temp_buffer.
7241 (Qhelp_form_show): New var.
e0d38eeb 7242 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7243
7244 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7245
7246 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7247
e67a13ab
CY
72482011-04-06 Chong Yidong <cyd@stupidchicken.com>
7249
04f2d78b
CB
7250 * process.c (Flist_processes): Remove to Lisp.
7251 (list_processes_1): Delete.
e67a13ab 7252
973f782d
EZ
72532011-04-06 Eli Zaretskii <eliz@gnu.org>
7254
7c106b1e
EZ
7255 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7256
973f782d
EZ
7257 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7258
41cf7d1a 72592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7260
ca23cc88
PE
7261 Fix more problems found by GCC 4.6.0's static checks.
7262
f390e2d5
PE
7263 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7264
42eea0d0
PE
7265 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7266
b69769da 7267 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7268
f9541e84
PE
7269 * xdisp.c (vmessage): Mark as a printf-like function.
7270
13841b55
PE
7271 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7272
c136c10f
PE
7273 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7274
5e2d4a30
PE
7275 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7276 printf-like functions.
7277 (tiff_load): Add casts to remove these marks before passing them
7278 to system-supplied API.
7279
583f48b9
PE
7280 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7281
b25d760e
PE
7282 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7283 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7284 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7285 directly, rather than having caller test rule sign. This avoids
7286 some unnecessary tests.
7287 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7288 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7289 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7290
bc7b6697 7291 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7292 (xfont_open): Avoid unnecessary tests.
bc7b6697 7293
27ccc379
PE
7294 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7295
dcd5c89a
PE
7296 * composite.h, composite.c (composition_gstring_put_cache):
7297 Use EMACS_INT, not int, for length.
7298
b13a45c6
PE
7299 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7300 breaking out part of COMPOSITION_DECODE_RULE.
7301 (COMPOSITION_DECODE_RULE): Use it.
7302 * composite.c (get_composition_id): Remove unused local vars,
7303 by using the new macro.
7304
1e792e4d
PE
7305 * textprop.c (set_text_properties_1): Change while to do-while,
7306 since the condition is always true at first.
7307
dc6c6455 7308 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7309 (interval_deletion_adjustment): Return unsigned value.
7310 All uses changed.
dc6c6455 7311
aba7731a
PE
7312 * process.c (list_processes_1, create_pty, read_process_output):
7313 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7314 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7315 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7316 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7317 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7318
fdfc4bf3
PE
7319 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7320
fca8fe46 7321 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7322 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7323
06a0259a 7324 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7325 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7326 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7327
e7b9e80f
PE
7328 * print.c (print_error_message): Avoid int overflow.
7329
56201685
PE
7330 * font.c (font_list_entities): Redo for clarity,
7331 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7332
78834453 7333 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7334 (font_score): Avoid potential overflow in diff calculation.
78834453 7335
0bc0b309 7336 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7337 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7338
e610eaca
PE
7339 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7340
b895abce
PE
7341 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7342 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7343 can always succeed if overflow has undefined behavior.
7344
1f1d9321 7345 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7346 (wordify): Omit three unnecessary tests.
1f1d9321 7347
c59478bc
PE
7348 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7349 All callers changed. This avoids the need for an unused var.
7350
79b73827
PE
7351 * casefiddle.c (casify_region): Remove var that is set but not used.
7352
a4db5dfe
PE
7353 * dired.c (file_name_completion): Remove var that is set but not used.
7354
43aae36e
PE
7355 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7356
2a47c44d 7357 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7358 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7359
a37c69bf
PE
7360 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7361 Check for integer overflow on size calculations.
7362
328ab8e7
PE
7363 * buffer.c (Fprevious_overlay_change): Remove var that is set
7364 but not used.
7365
e5a2a5cb
PE
7366 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7367 Remove vars that are set but not used.
8d84a6eb 7368 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7369 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7370
a60e5f68
PE
7371 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7372
f661cb61 7373 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7374 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7375
f0397f5a
PE
7376 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7377 that are set but not used.
7378
8664db06 7379 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7380 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7381
6abdaa4a
PE
7382 * xselect.c (x_get_local_selection, x_handle_property_notify):
7383 Remove vars that are set but not used.
7384
0ce7538d 7385 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7386 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7387
9ae848fc
PE
7388 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7389 Remove var that is set but not used.
0b918413
PE
7390 (scroll_bar_windows_size): Now size_t, not int.
7391 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7392 Check for overflow.
9ae848fc 7393
a5a62657
PE
7394 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7395 (map_tty_color) [!defined MSDOS]: Likewise.
7396
5c5cdd39
PE
7397 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7398
66ebf983
PE
7399 * coding.c: Remove vars that are set but not used.
7400 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7401 All callers changed.
7402 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7403 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7404 (decode_coding_charset): Remove vars that are set but not used.
7405
1be4d761
PE
7406 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7407 that is set but not used.
7408
47553fa8
PE
7409 * print.c (print_object): Remove var that is set but not used.
7410
1f7196bf 7411 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7412 The gnulib version avoids calling malloc in the usual case,
7413 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7414 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7415 * filelock.c (current_lock_owner): Likewise.
7416 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7417 * sysdep.c: Include allocator.h, careadlinkat.h.
7418 (emacs_no_realloc_allocator): New static constant.
7419 (emacs_readlink): New function.
fdb61804
PE
7420 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7421 ../lib/careadlinkat.h.
d1fdcab7 7422
f84c17c7
SM
74232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7424
7425 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7426 first non-nil return value).
7427
ef3862ad
JD
74282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7429
7430 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7431 if not defined (Bug#8403).
7432
376a7006
JB
74332011-04-02 Juanma Barranquero <lekktu@gmail.com>
7434
7435 * xdisp.c (display_count_lines): Remove parameter `start',
7436 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7437 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7438 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7439 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7440 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7441 and thereabouts. All callers changed.
7442 (get_per_char_metric): Remove parameter `f', unused since
7443 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7444
6ca3801d
JM
74452011-04-02 Jim Meyering <meyering@redhat.com>
7446
7447 do not dereference NULL upon failed strdup
7448 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7449 (ns_get_family): Likewise.
7450
d8e2b5ba
JB
74512011-04-02 Juanma Barranquero <lekktu@gmail.com>
7452
7453 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7454
8c74fcbd
JD
74552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7456
7457 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7458 later (Bug#8403).
7459
7200d79c
SM
74602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7461
03408648 7462 Add lexical binding.
7200d79c 7463
03408648
SM
7464 * window.c (Ftemp_output_buffer_show): New fun.
7465 (Fsave_window_excursion):
7466 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7467
7468 * lread.c (lisp_file_lexically_bound_p): New function.
7469 (Fload): Bind Qlexical_binding.
7470 (readevalloop): Remove `evalfun' arg.
7471 Bind Qinternal_interpreter_environment.
7472 (Feval_buffer): Bind Qlexical_binding.
7473 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7474 Mark as dynamic.
7475 (syms_of_lread): Declare `lexical-binding'.
7476
7477 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7478
7479 * keyboard.c (eval_dyn): New fun.
7480 (menu_item_eval_property): Use it.
ca105506
SM
7481
7482 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7483
03408648
SM
7484 * fns.c (concat, mapcar1): Accept byte-code-functions.
7485
7486 * eval.c (Fsetq): Handle lexical vars.
7487 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7488 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7489 (FletX, Flet): Obey lexical binding.
7490 (Fcommandp): Handle closures.
7491 (Feval): New `lexical' arg.
7492 (eval_sub): New function extracted from Feval. Use it almost
7493 everywhere where Feval was used. Look up vars in lexical env.
7494 Handle closures.
7495 (Ffunctionp): Move from subr.el.
7496 (Ffuncall): Handle closures.
7497 (apply_lambda): Remove `eval_flags'.
7498 (funcall_lambda): Handle closures and new byte-code-functions.
7499 (Fspecial_variable_p): New function.
7500 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7501 but without exporting it to Lisp.
23aba0ea 7502
23aba0ea 7503 * doc.c (Fdocumentation, store_function_docstring):
03408648 7504 * data.c (Finteractive_form): Handle closures.
23aba0ea 7505
03408648
SM
7506 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7507 interactive spec.
ba83908c 7508
04f2d78b
CB
7509 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7510 New byte-codes.
03408648
SM
7511 (exec_byte_code): New function extracted from Fbyte_code to handle new
7512 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7513
03408648 7514 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7515
03408648 7516 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7517
e2abce01
JB
75182011-03-31 Juanma Barranquero <lekktu@gmail.com>
7519
7520 * xdisp.c (redisplay_internal): Fix prototype.
7521
63696a73 75222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7523
63696a73 7524 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7525 (try_scrolling): Use it when setting scroll_limit.
7526 Limit scrolling to 100 screen lines.
63696a73
EZ
7527 (redisplay_window): Even when falling back on "recentering",
7528 position point in the window according to scroll-conservatively,
7529 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7530
7531 (try_scrolling): When point is above the window, allow searching
7532 as far as scroll_max, or one screenful, to compute vertical
7533 distance from PT to the scroll margin position. This prevents
7534 try_scrolling from unnecessarily failing when
7535 scroll-conservatively is set to a value slightly larger than the
7536 window height. Clean up the case of PT below the margin at bottom
7537 of window: scroll_max can no longer be INT_MAX. When aggressive
7538 scrolling is in use, don't let point enter the opposite scroll
7539 margin as result of the scroll.
7540 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7541 threshold of 100 lines for never-recentering scrolling.
7542
e4cc2dfc
JB
75432011-03-31 Juanma Barranquero <lekktu@gmail.com>
7544
7545 * dispextern.h (move_it_by_lines):
7546 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7547 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7548 (message_log_check_duplicate): Remove parameters `prev_bol' and
7549 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7550 (redisplay_internal): Remove parameter `preserve_echo_area',
7551 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7552
7553 * indent.c (Fvertical_motion):
7554 * window.c (window_scroll_pixel_based, Frecenter):
7555 Don't pass `need_y_p' to `move_it_by_lines'.
7556
1c470562
SM
75572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7558
44f230aa
SM
7559 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7560 steal a few bits to be more compact.
7561 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7562 Remove unneeded casts.
7563
1c470562
SM
7564 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7565
888adce9
ZK
75662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7567
7568 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7569 binding" message (bug#7967).
7570
f838ed7b
PE
75712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7572
77861b95
PE
7573 Fix more problems found by GCC 4.6.0's static checks.
7574
de6dbc14
PE
7575 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7576 Remove unused local var.
7577
f838ed7b
PE
7578 * editfns.c (Fmessage_box): Remove unused local var.
7579
792c7b2b
PE
7580 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7581 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7582 Omit unused local vars.
c499e557 7583 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7584 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7585 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7586 Omit unused local var.
7587
ba0165e1
PE
7588 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7589 Don't assume string length fits in int.
32ad8845 7590 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7591 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7592
3c59b4c9
PE
7593 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7594 instead of alloca (Bug#8344).
7595
a3eed478 7596 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7597 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7598
eb4d412d
PE
7599 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7600
1658b401
PE
7601 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7602 concerns.
7603
7604 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7605
7606 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7607
9a2c6e05
PE
7608 * keyboard.c (syms_of_keyboard): Use the same style as later
7609 in this function when indexing through an array. This also
7610 works around GCC bug 48267.
7611
03d0a109
PE
7612 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7613
44f730c8
PE
7614 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7615
fe75f926
PE
7616 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7617 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7618
ffa8c828
PE
7619 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7620 This avoids undefined behavior on integer overflow, and is a bit
7621 more convenient anyway since it is compared to a size_t variable.
7622
c5101a77
PE
7623 Variadic C functions now count arguments with size_t, not int.
7624 This avoids an unnecessary limitation on 64-bit machines, which
7625 caused (substring ...) to crash on large vectors (Bug#8344).
7626 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7627 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7628 All variadic functions and their callers changed accordingly.
c5101a77
PE
7629 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7630 * data.c (arith_driver, float_arith_driver): Likewise.
7631 * editfns.c (general_insert_function): Likewise.
7632 * eval.c (struct backtrace.nargs, interactive_p)
7633 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7634 (funcall_lambda, mark_backtrace): Likewise.
7635 * fns.c (concat): Likewise.
7636 * frame.c (x_set_frame_parameters): Likewise.
7637 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7638 0 if not found, not -1. All callers changed.
7639
dd3f25f7
PE
7640 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7641 (stack_copy_size): Now size_t, not int.
7642 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7643
461c2ab9
JB
76442011-03-28 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7647 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7648 All callers changed.
7649
7650 * lisp.h (multibyte_char_to_unibyte):
7651 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7652 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7653 * character.h (CHAR_TO_BYTE8):
7654 * cmds.c (internal_self_insert):
7655 * editfns.c (general_insert_function):
7656 * keymap.c (push_key_description):
7657 * search.c (Freplace_match):
7658 * xdisp.c (message_dolog, set_message_1): All callers changed.
7659
f6d62986
SM
76602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7661
7662 * keyboard.c (safe_run_hook_funcall): New function.
7663 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7664 don't set the hook to nil, but remove the offending function instead.
7665 (Qcommand_hook_internal): Remove, unused.
7666 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7667 Vcommand_hook_internal.
7668
7669 * eval.c (enum run_hooks_condition): Remove.
7670 (funcall_nil, funcall_not): New functions.
7671 (run_hook_with_args): Call each function through a `funcall' argument.
7672 Remove `cond' argument, now redundant.
7673 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7674 (Frun_hook_with_args_until_failure): Adjust accordingly.
7675 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7676
1db5b1ad
JB
76772011-03-28 Juanma Barranquero <lekktu@gmail.com>
7678
7679 * dispextern.h (string_buffer_position): Remove declaration.
7680
7681 * print.c (strout): Remove parameter `multibyte', unused since
7682 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7683
7684 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7685 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7686 All callers changed.
7687
7688 * w32.c (_wsa_errlist): Use braces for struct initializers.
7689
7690 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7691 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7692 All callers changed.
7693 (string_buffer_position): Likewise. Also, make static (it's never
7694 used outside xdisp.c).
7695 (cursor_row_p): Remove parameter `w', unused since
7696 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7697 (decode_mode_spec): Remove parameter `precision', introduced during
7698 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7699 All callers changed.
7700
5ffb62aa
JD
77012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7702
7703 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7704
461c2ab9 77052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7706
7707 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7708 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7709 (ns_update_auto_hide_menu_bar): New functions.
7710 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7711 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7712 ns_constrain_all_frames.
7713 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7714 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7715
5c380ffb
JD
77162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7717
7718 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7719
9af30bdf
GM
77202011-03-27 Glenn Morris <rgm@gnu.org>
7721
7722 * syssignal.h: Replace RETSIGTYPE with void.
7723 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7724 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7725 Replace SIGTYPE with void everywhere.
7726 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7727 * s/template.h (SIGTYPE): Remove commented out definition.
7728
e2abce01
JB
77292011-03-26 Eli Zaretskii <eliz@gnu.org>
7730
7731 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7732 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7733
f868cd8a
JB
77342011-03-26 Juanma Barranquero <lekktu@gmail.com>
7735
59eb0929
JB
7736 * w32.c (read_unc_volume): Use parameter `henum', instead of
7737 global variable `wget_enum_handle'.
7738
7739 * keymap.c (describe_vector): Remove parameters `indices' and
7740 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7741 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7742
f868cd8a
JB
7743 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7744
7745 * keyboard.c (timer_check): Remove parameter `do_it_now',
7746 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7747 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7748 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7749
7750 * keyboard.c (read_char):
7751 * w32menu.c (w32_menu_display_help):
7752 * xmenu.c (show_help_event, menu_help_callback):
7753 Adjust calls to `show_help_echo'.
7754
7755 * gtkutil.c (xg_maybe_add_timer):
7756 * keyboard.c (readable_events):
7757 * process.c (wait_reading_process_output):
7758 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7759
7760 * insdel.c (adjust_markers_gap_motion):
7761 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7762 (gap_left, gap_right): Don't call it.
7763
2ecf6fdb
CY
77642011-03-25 Chong Yidong <cyd@stupidchicken.com>
7765
7766 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7767 incurred during fontification.
7768
6b1f9ba4
JB
77692011-03-25 Juanma Barranquero <lekktu@gmail.com>
7770
7771 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7772 (DEFVAR_PER_BUFFER): Don't pass it.
7773
7774 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7775 (scrolling_window): Don't pass it.
7776
0f4a96b5
JB
77772011-03-25 Juanma Barranquero <lekktu@gmail.com>
7778
7779 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7780
7781 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7782 and `suffix'.
7783 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7784 of variables specific to SELinux and computation of `encoded_absname'.
7785
7786 * image.c (XPutPixel): Remove unused variable `height'.
7787
7788 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7789
7790 * unexw32.c (get_section_info): Remove unused variable `section'.
7791
7792 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7793 (system_process_attributes): Remove unused variable `sess'.
7794 (sys_read): Remove unused variable `err'.
7795
7796 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7797 (w32_wnd_proc): Remove unused variable `isdead'.
7798 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7799 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7800 (x_create_tip_frame): Remove unused variable `tem'.
7801
7802 * w32inevt.c (w32_console_read_socket):
7803 Remove unused variable `no_events'.
7804
7805 * w32term.c (x_draw_composite_glyph_string_foreground):
7806 Remove unused variable `width'.
7807
1149507c
JB
78082011-03-24 Juanma Barranquero <lekktu@gmail.com>
7809
7810 * w32term.c (x_set_glyph_string_clipping):
7811 Don't pass uninitialized region to CombineRgn.
7812
9c88f339
JB
78132011-03-23 Juanma Barranquero <lekktu@gmail.com>
7814
7815 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7816 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7817 (Fx_close_connection): Remove unused variable `i'.
7818
7819 * w32font.c (w32font_draw): Return number of glyphs.
7820 (w32font_open_internal): Remove unused variable `i'.
7821 (w32font_driver): Add missing initializer.
7822
7823 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7824 (fill_in_menu): Remove unused variable `items_added'.
7825
7826 * w32term.c (last_mouse_press_frame): Remove static global variable.
7827 (w32_clip_to_row): Remove unused variable `f'.
7828 (x_delete_terminal): Remove unused variable `i'.
7829
7830 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7831 (NOTHING): Remove unused static global variable.
7832 (uniscribe_check_otf): Remove unused variable `table'.
7833 (uniscribe_font_driver): Add missing initializers.
7834
dee091a3
JD
78352011-03-23 Julien Danjou <julien@danjou.info>
7836
7837 * term.c (Fsuspend_tty, Fresume_tty):
7838 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7839 * window.c (temp_output_buffer_show):
7840 * insdel.c (signal_before_change):
7841 * frame.c (Fhandle_switch_frame):
7842 * fileio.c (Fdo_auto_save):
7843 * emacs.c (Fkill_emacs):
7844 * editfns.c (save_excursion_restore):
7845 * cmds.c (internal_self_insert):
7846 * callint.c (Fcall_interactively):
7847 * buffer.c (Fkill_all_local_variables):
7848 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7849 Use Frun_hooks.
0f4a96b5 7850 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7851 unconditionally since it does the check itself.
dee091a3 7852
2c520ab5 78532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7854
c9c49752
PE
7855 Fix more problems found by GCC 4.5.2's static checks.
7856
8abc3f12
PE
7857 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7858 the first time through the loop, since we know p0 < p1 then.
7859 This also avoids a gcc -Wstrict-overflow warning.
7860
a2d26660
PE
7861 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7862 leading to a memory leak, possible in functions like
7863 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7864 of objects (Bug#8318).
a2d26660 7865
916c72e9
PE
7866 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7867 that could (at least in theory) be that large.
7868
19ab8a18
PE
7869 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7870 This is less likely to overflow, and avoids undefined behavior if
7871 overflow does occur. All callers changed. Use strtoul to scan
7872 for the unsigned long integer.
b7cbbd6f
PE
7873 (pint2hrstr): Simplify and tune code slightly.
7874 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7875
f0641eff
PE
7876 * scroll.c (do_scrolling): Work around GCC bug 48228.
7877 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7878
7f650bb9
PE
7879 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7880 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7881 (validate_x_resource_name): Simplify count usage.
7882 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7883
37dd57d1
PE
7884 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7885 fail (Bug#8306).
81e56e61 7886
699979fc 7887 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7888
401bf9b4
PE
7889 * process.c (Fmake_network_process): Use socklen_t, not int,
7890 where POSIX says socklen_t is required in portable programs.
7891 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7892 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7893 (Fmake_network_process, server_accept_connection):
7894 (wait_reading_process_output, read_process_output):
7895 Likewise.
7896
b93aacde
PE
7897 * process.c: Rename or move locals to avoid shadowing.
7898 (list_processes_1, Fmake_network_process):
7899 (read_process_output_error_handler, exec_sentinel_error_handler):
7900 Rename or move locals.
4dc343ee 7901 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7902 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7903 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7904 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7905 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7906
af8a867c 7907 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7908 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7909 Include tparam.h instead, since it declares them.
af8a867c
PE
7910 * cm.h (PC): Remove extern decl; tparam.h now does this.
7911 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7912 * terminfo.c: Include tparam.h, to check interfaces.
7913 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7914 (tparam): Adjust signature to match interface in tparam.h;
7915 this removes some undefined behavior. Check that outstring and len
7916 are zero, which they always are with Emacs.
7917 * tparam.h (PC, BC, UP): New extern decls.
7918
0248044d 7919 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7920 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7921
8ff096c1 7922 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7923 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7924 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7925 (ftfont_list): Remove unused local.
49eaafba
PE
7926 (get_adstyle_property, ftfont_pattern_entity):
7927 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7928 Rename locals to avoid shadowing.
8ff096c1 7929
e2be39f6
PE
7930 * xfont.c (xfont_list_family): Mark var as initialized.
7931
c9735e30
PE
7932 * xml.c (make_dom): Now static.
7933
8f5201ae
PE
7934 * composite.c (composition_compute_stop_pos): Rename local to
7935 avoid shadowing.
b246f932
PE
7936 (composition_reseat_it): Remove unused locals.
7937 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7938 (composition_update_it): Mark var as initialized.
11b61122
PE
7939 (find_automatic_composition): Mark vars as initialized,
7940 with a FIXME (Bug#8290).
8f5201ae 7941
760fbc2c
PE
7942 character.h: Rename locals to avoid shadowing.
7943 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7944 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7945 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7946 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7947 to avoid shadowing.
7948
ff08eb85
PE
7949 * textprop.c (property_change_between_p): Remove; unused.
7950
fc7bf025
PE
7951 * intervals.c (interval_start_pos): Now static.
7952
235d7abc
PE
7953 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7954
44f230aa
SM
7955 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7956 Rename locals to avoid shadowing.
3e7d6594 7957
50060332
PE
7958 * sound.c (wav_play, au_play, Fplay_sound_internal):
7959 Fix pointer signedness.
d01f234b 7960 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7961 (wav_play): Initialize a variable to 0, to prevent undefined
7962 behavior (Bug#8278).
50060332 7963
c4fc4e30
PE
7964 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7965
918436ed
PE
7966 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7967
c939f91b
PE
7968 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7969 clobbering (Bug#8298).
b9c7f648
PE
7970 * sysdep.c (sys_subshell): Likewise.
7971 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7972
6bd8c144
PE
7973 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7974 This should get cleaned up, so that child_setup has the
7975 same signature on all platforms.
7976
7710357c 7977 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7978 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7979
c59da222
CY
79802011-03-22 Chong Yidong <cyd@stupidchicken.com>
7981
7982 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7983 not to be necessary, and produces flickering.
7984
66b87493
GM
79852011-03-20 Glenn Morris <rgm@gnu.org>
7986
7987 * config.in: Remove file.
7988
45b6f6d5
JB
79892011-03-20 Juanma Barranquero <lekktu@gmail.com>
7990
7991 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7992 are now in src/globals.h.
7993 (syms_of_minibuf): Remove spurious & from previous change.
7994
3ec03f7e
LL
79952011-03-20 Leo <sdl.web@gmail.com>
7996
7997 * minibuf.c (completing-read-function): New variable.
7998 (completing-read-default): Rename from completing-read.
7999 (completing-read): Call completing-read-function.
8000
b14e3e21
CY
80012011-03-19 Juanma Barranquero <lekktu@gmail.com>
8002
8003 * xfaces.c (Fx_load_color_file):
8004 Read color file from absolute filename (bug#8250).
8005
f2b726e6
JB
80062011-03-19 Juanma Barranquero <lekktu@gmail.com>
8007
8008 * makefile.w32-in: Update dependencies.
8009
09f6ff02
EZ
80102011-03-17 Eli Zaretskii <eliz@gnu.org>
8011
8012 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8013
29a6015a
PE
80142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8015
a3a6c54e
PE
8016 Fix more problems found by GCC 4.5.2's static checks.
8017
b766f867
PE
8018 * process.c (make_serial_process_unwind, send_process_trap):
8019 (sigchld_handler): Now static.
8020
be02381c
PE
8021 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8022 That way, the code declares only the vars that it needs.
8023 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8024 * s/cygwin.h (PTY_ITERATION): Likewise.
8025 * s/darwin.h (PTY_ITERATION): Likewise.
8026 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8027
57048744
PE
8028 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8029 * process.c (allocate_pty): Don't declare stb unless it's needed.
8030
7914961c 8031 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8032 (CONSTANTLIM): Remove; unused.
8033 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8034 Define only if needed.
7914961c 8035
b3967b18
PE
8036 * unexelf.c (unexec): Name an expression,
8037 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8038 Use a different way to cause a compilation error if anyone uses
8039 n rather than nn, a way that does not involve shadowing.
73366a00 8040 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8041
29a6015a
PE
8042 * deps.mk (unexalpha.o): Remove; unused.
8043
43cfc33e 8044 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8045 * unexec.h: New file.
ce701a33
PE
8046 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8047 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8048 Depend on unexec.h.
8049 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8050 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8051 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8052 Change as necessary to match prototype in unexec.h.
ce701a33 8053
01f44d5a
PE
8054 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8055 shadowing.
4f63c6bb 8056 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8057
a6670b0b
PE
8058 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8059 Rename locals to avoid shadowing.
8060
cef2010d 8061 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8062 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8063
d4d7173a
PE
8064 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8065
f08b802a
PE
8066 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8067 warning when compiling print.c.
8068
3ddb0639
PE
8069 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8070 instead of using an uninitialized var.
5ad03b97 8071 (font_sort_entities): Mark var as initialized.
3ddb0639 8072
170a2692
PE
8073 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8074
e663c700
PE
8075 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8076 pointers to constants.
89bc529a 8077 (font_parse_fcname): Remove unused vars.
7b81e2d0 8078 (font_delete_unmatched): Now static.
ea838e10 8079 (font_get_spec): Remove; unused.
13a547c6
PE
8080 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8081 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8082 Rename or move locals to avoid shadowing.
e663c700 8083
2a80c887 8084 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8085 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8086
1384fa33 8087 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8088 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8089
8b2c52e9
PE
8090 * alloc.c (mark_backtrace): Move decl from here ...
8091 * lisp.h: ... to here, so that it can be checked.
8092
475545b5 8093 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8094 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8095 (lisp_indirect_variable): Name an expression,
8096 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8097 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8098
b1349114 8099 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8100 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8101 Use const pointer when appropriate.
b1349114 8102
a2928364
PE
8103 * lisp.h (get_system_name, get_operating_system_release):
8104 Move decls here, to check interfaces.
8105 * process.c (get_operating_system_release): Move decl to lisp.h.
8106 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8107 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8108 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8109 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8110 (Fformat_time_string, Fencode_time, Finsert_char):
8111 (Ftranslate_region_internal, Fformat):
8112 Rename or remove local vars to avoid shadowing.
9710023e 8113 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8114
a415e694
PE
8115 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8116 avoid shadowing.
8117
8ef4622d
PE
8118 * lisp.h (eassert): Check that the argument compiles, even if
8119 ENABLE_CHECKING is not defined.
8120
946f9a5b
PE
8121 * data.c (Findirect_variable): Name an expression, to avoid
8122 gcc -Wbad-function-cast warning.
112396d6 8123 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8124 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8125 (Fmake_variable_buffer_local, Fmake_local_variable):
8126 Mark variables as initialized.
52746918 8127 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8128
e5aab7e7 8129 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8130 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8131 Rename locals to avoid shadowing.
dff45157
PE
8132 (mark_stack): Move local variables into the #ifdef region where
8133 they're used.
7bc26fdb
PE
8134 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8135 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8136 needed otherwise.
8137 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8138 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8139 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8140
e5aab7e7
PE
8141 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8142 avoids undefined behavior in theory.
8143
4da60324
PE
8144 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8145
88043301
PE
8146 Use functions, not macros, for up- and down-casing (Bug#8254).
8147 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8148 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8149 to use the following functions instead of these macros.
8150 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8151 EMACS_INT, since callers assume the returned value fits in int.
8152 (upcase1): Likewise, for UPCASE_TABLE.
8153 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8154 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8155 the race-condition problem in the old DOWNCASE.
88043301 8156
19ed5445
PE
8157 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8158 Rename locals to avoid shadowing.
8159 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8160 (regex_compile, re_search_2, re_match_2_internal):
8161 Remove unused local vars.
952db0d7
PE
8162 (FREE_VAR): Rewrite so as not to use empty "else",
8163 which gcc can warn about.
da053e48 8164 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8165 (RETALLOC_IF): Define only if needed.
8166 (WORDCHAR_P): Likewise. This one is never needed, but is used
8167 only in a comment talking about a compiler bug, so put inside
8168 the #if 0 of that comment.
8169 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8170 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8171 Remove; unused.
19ed5445 8172
1f3561e4 8173 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8174 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8175 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8176
ded6f8f7
PE
8177 * search.c (simple_search): Remove unused var.
8178
dbd37a95
PE
8179 * dired.c (compile_pattern): Move decl from here ...
8180 * lisp.h: ... to here, so that it can be checked.
8181 (struct re_registers): New forward decl.
8182
7e47afad
PE
8183 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8184
85f24f61
PE
8185 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8186 All uses changed.
8187 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8188 Rename locals to avoid shadowing.
5671df8f 8189 (Fvertical_motion): Mark locals as initialized.
85f24f61 8190
181aa2be 8191 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8192 (casify_region): Mark local as initialized.
181aa2be 8193
930d429c
PE
8194 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8195
7082eac6
PE
8196 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8197 New macros, so that the caller can use some names other than
8198 gcpro1, gcpro2, etc.
8199 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8200 of the new macros.
8201 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8202 argument, for consistency with GCPRO2_VAR, etc: it is now the
8203 prefix of the variable, not the variable itself. All uses
8204 changed.
38b2c076
PE
8205 * dired.c (directory_files_internal, file_name_completion):
8206 Rename locals to avoid shadowing.
8207
15206ed9
PE
8208 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8209 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8210 dired.c's scmp function, had undefined behavior.
8211 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8212 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8213 * buffer.h: ... to here, because these macros use current_buffer,
8214 and the new implementation with inline functions needs to have
8215 current_buffer in scope now, rather than later when the macros
8216 are used.
8217 (downcase, upcase1): New static inline functions.
8218 (DOWNCASE, UPCASE1): Reimplement using these functions.
8219 This avoids undefined behavior in expressions like
8220 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8221 from race conditions in accessing the global variables
8222 case_temp1 and case_temp2.
8223 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8224 * lisp.h (case_temp1, case_temp2): Remove their decls.
8225 * character.h (ASCII_CHAR_P): Move from here ...
8226 * lisp.h: ... to here, so that the inline functions mentioned
8227 above can use them.
8228
4a6bea26
PE
8229 * dired.c (directory_files_internal_unwind): Now static.
8230
f14b7e14
PE
8231 * fileio.c (file_name_as_directory, directory_file_name):
8232 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8233 Now static.
2893f146
PE
8234 (file_name_as_directory): Use const pointers when appropriate.
8235 (Fexpand_file_name): Likewise. In particular, newdir might
8236 point at constant storage, so make it a const pointer.
fd4ead52 8237 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8238 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8239 signedness issues.
f839df0c
PE
8240 (Fset_file_times, Finsert_file_contents, auto_save_error):
8241 Rename locals to avoid shadowing.
f14b7e14 8242
5716756e 8243 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8244 (Ftry_completion, Fall_completions): Rename or remove locals
8245 to avoid shadowing.
5716756e 8246
b4c3046a
PE
8247 * marker.c (bytepos_to_charpos): Remove; unused.
8248
b45db522
PE
8249 * lisp.h (verify_bytepos, count_markers): New decls,
8250 so that gcc does not warn that these functions aren't declared.
8251
85876d07
PE
8252 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8253 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8254 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8255 (copy_text): Remove unused local var.
85876d07 8256
03d78a21 8257 * filelock.c (within_one_second): Now static.
b3dd38ab 8258 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8259
5df8f01b
PE
8260 * buffer.c (fix_overlays_before): Mark locals as initialized.
8261 (fix_start_end_in_overlays): Likewise. This function should be
8262 simplified by using pointers-to-pointers, but that's a different
8263 matter.
b1d876f1 8264 (switch_to_buffer_1): Now static.
8f54f30a
PE
8265 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8266 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8267
a70072c9 8268 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8269 Fix pointer signedness issue.
edced198
PE
8270 (sys_subshell): Mark local as volatile if checking for lint,
8271 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8272 (MAXPATHLEN): Define only if needed.
a70072c9 8273
a0977c44
PE
8274 * process.c (serial_open, serial_configure): Move decls from here ...
8275 * systty.h: ... to here, so that they can be checked.
8276
a884fdcc
PE
8277 * fns.c (get_random, seed_random): Move extern decls from here ...
8278 * lisp.h: ... to here, so that they can be checked.
8279
604efe86 8280 * sysdep.c (reset_io): Now static.
b8950c94 8281 (wait_for_termination_signal): Remove; unused.
604efe86 8282
38fc62d9
PE
8283 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8284 (copy_keymap_item, append_key, push_text_char_description):
8285 Now static.
1004a21a 8286 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8287 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8288 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8289 (describe_map_tree):
8290 Rename locals to avoid shadowing.
38fc62d9 8291
2f2650da
PE
8292 * keyboard.c: Declare functions static if they are not used elsewhere.
8293 (echo_char, echo_dash, cmd_error, top_level_2):
8294 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8295 (read_char, kbd_buffer_get_event, make_lispy_position):
8296 (make_lispy_event, make_lispy_movement, apply_modifiers):
8297 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8298 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8299 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8300 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8301 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8302
a053e86c 8303 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8304 (mark_kboards): Move decl here ...
8305 * alloc.c (mark_kboards): ... from here.
a053e86c 8306
4752793e
PE
8307 * lisp.h (force_auto_save_soon): New decl.
8308
74f10ca7 8309 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8310 (DEFINE_DUMMY_FUNCTION): New macro.
8311 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8312 Use it.
c03cd23f
PE
8313 (main): Add casts to avoid warnings
8314 if GCC considers string literals to be constants.
74f10ca7 8315
022e70d4
PE
8316 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8317
59d6fe83
PE
8318 * dbusbind.c: Pointer signedness fixes.
8319 (xd_signature, xd_append_arg, xd_initialize):
8320 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8321 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8322 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8323 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8324
78320123
PE
8325 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8326 if GCC considers string literals to be constants.
49cebcca 8327 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8328
35ac2a97
SM
83292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8330
fb103ca9
SM
8331 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8332 (print_preprocess, print_object): New macro to fix last change.
8333
35ac2a97
SM
8334 * print.c (print_preprocess): Don't forget font objects.
8335
62973b41
JB
83362011-03-16 Juanma Barranquero <lekktu@gmail.com>
8337
8338 * emacs.c (USAGE3): Doc fixes.
8339
0e48bb22
AS
83402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8341
8342 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8343 structure.
8344
7684e57b
JB
83452011-03-14 Juanma Barranquero <lekktu@gmail.com>
8346
8347 * lisp.h (VWindow_system, Qfile_name_history):
8348 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8349 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8350 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8351
8352 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8353 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8354
8355 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8356 * w32console.c (detect_input_pending, read_input_pending)
8357 (encode_terminal_code):
8358 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8359 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8360 (w32_system_caret_y, Qfile_name_history):
8361 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8362 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8363 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8364 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8365 * w32proc.c (Qlocal, report_file_error):
8366 * w32term.c (Vwindow_system, updating_frame):
8367 * w32uniscribe.c (initialized, uniscribe_font_driver):
8368 Remove unneeded extern declarations.
8369
2aa46d6c
CY
83702011-03-14 Chong Yidong <cyd@stupidchicken.com>
8371
c96bbc66 8372 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8373
cffc6f3b
CY
83742011-03-13 Chong Yidong <cyd@stupidchicken.com>
8375
8376 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8377 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8378 These macros can no longer be used for assignment.
8379
44f230aa
SM
8380 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8381 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8382 (record_buffer_markers, fetch_buffer_markers): New functions for
8383 recording and fetching special buffer markers.
8384 (set_buffer_internal_1, set_buffer_temp): Use them.
8385
8386 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8387
8388 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8389
8390 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8391 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8392
8393 * xdisp.c (hscroll_window_tree):
8394 (reconsider_clip_changes): Use PT instead of BUF_PT.
8395
d251f04b
EZ
83962011-03-13 Eli Zaretskii <eliz@gnu.org>
8397
8398 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8399 $(EMACS_ROOT)/lib/intprops.h.
8400
f0c77cd1
PE
84012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8402
3eca4629
PE
8403 Fix more problems found by GCC 4.5.2's static checks.
8404
7c86ee98
PE
8405 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8406 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8407 (xg_free_frame_widgets): Make it clear that a local variable is
8408 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8409 (gdk_window_get_screen): Make it clear that this macro is needed
8410 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8411 (int_gtk_range_get_value): New function, which avoids a diagnostic
8412 from gcc -Wbad-function-cast.
8413 (xg_set_toolkit_scroll_bar_thumb): Use it.
8414 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8415 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8416 (get_utf8_string, xg_get_file_with_chooser):
8417 Rename locals to avoid shadowing.
8418 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8419
41729b81
PE
8420 * xgselect.c (xg_select): Remove unused var.
8421
f0c77cd1
PE
8422 * image.c (four_corners_best): Mark locals as initialized.
8423 (gif_load): Initialize transparent_p to zero (Bug#8238).
8424 Mark another local as initialized.
ec6cf4c6 8425 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8426
ce0ad53d 8427 * image.c (clear_image_cache): Now static.
d5d5a617 8428 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8429 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8430 (x_edge_detection): Remove unnecessary cast that
8431 gcc -Wbad-function-cast diagnoses.
2037898d 8432 (gif_load): Fix pointer signedness.
6ae141d6
PE
8433 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8434 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8435
33383987 84362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8437
d32df629
PE
8438 Improve quality of tests for time stamp overflow.
8439 For example, without this patch (encode-time 0 0 0 1 1
8440 1152921504606846976) returns the obviously-bogus value (-948597
8441 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8442 reports time overflow. See
8443 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8444 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8445 * editfns.c: Include limits.h and intprops.h.
8446 (TIME_T_MIN, TIME_T_MAX): New macros.
8447 (time_overflow): Move earlier, to before first use.
8448 (hi_time, lo_time): New functions, for an accurate test for
8449 out-of-range times.
8450 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8451 (Fget_internal_run_time): Don't assume time_t fits in int.
8452 (make_time): Use list2 instead of Fcons twice.
8453 (Fdecode_time): More accurate test for out-of-range times.
8454 (check_tm_member): New function.
8455 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8456 (lisp_time_argument): Don't rely on undefined left-shift and
8457 right-shift behavior when checking for time stamp overflow.
8be6f318 8458
fe31d94c
PE
8459 * editfns.c (time_overflow): New function, refactoring common code.
8460 (Fformat_time_string, Fdecode_time, Fencode_time):
8461 (Fcurrent_time_string): Use it.
8462
8be6f318
PE
8463 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8464 * dired.c (make_time): Move to ...
8465 * editfns.c (make_time): ... here.
8466 * systime.h: Note the move.
8467
09d9db2c 84682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8469
126bc0dc
YM
8470 * fringe.c (update_window_fringes): Remove unused variables.
8471
c47cbdfd
YM
8472 * unexmacosx.c (copy_data_segment): Also copy __got section.
8473 (Bug#8223)
8474
7ac80be9
EZ
84752011-03-12 Eli Zaretskii <eliz@gnu.org>
8476
c96bbc66 8477 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8478 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8479 Constify `char *' arguments and their references according to
8480 prototypes in tparam.h.
8481
ecb0f94d 8482 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8483
7ac80be9
EZ
8484 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8485 Adapt all references accordingly.
8486
8487 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8488
ef1fd07e
TT
84892011-03-11 Tom Tromey <tromey@redhat.com>
8490
8491 * buffer.c (syms_of_buffer): Remove obsolete comment.
8492
7ef4b50c
EZ
84932011-03-11 Eli Zaretskii <eliz@gnu.org>
8494
8495 * termhooks.h (encode_terminal_code): Declare prototype.
8496
8497 * msdos.c (encode_terminal_code): Don't declare prototype.
8498
8499 * term.c (encode_terminal_code): Now external again, used by
8500 w32console.c and msdos.c.
8501
44f230aa
SM
8502 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8503 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8504
4b1ec863 85052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8506
1714f52b 8507 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8508
4b1ec863
PE
8509 * fringe.c (update_window_fringes): Mark locals as initialized
8510 (Bug#8227).
8511 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8512
524c7aa6
PE
8513 * alloc.c (mark_fringe_data): Move decl from here ...
8514 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8515 to check its interface.
8516 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8517
a5c0af81 8518 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8519 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8520 (fontset_font): Mark local as initialized.
a9a06e0b 8521 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8522
b4716021
PE
8523 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8524
811e9bac 8525 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8526 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8527 (x_own_selection, Fx_disown_selection_internal): Rename locals
8528 to avoid shadowing.
8529 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8530
7e3ab302
PE
8531 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8532 so that the caller can use some name other than gcpro1.
8533 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8534 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8535 (Fx_backspace_delete_keys_p):
8536 Use them to avoid shadowing, and rename vars to avoid shadowing.
8537 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8538 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8539 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8540 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8541 Remove unused locals.
7e3ab302
PE
8542 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8543 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8544 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8545 macros.
f78faa98 8546
e2b13473
PE
8547 * xterm.h (x_mouse_leave): New decl.
8548
77f23912
PE
8549 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8550 Remove unused functions.
cdf4ba58
PE
8551 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8552 (x_calc_absolute_position): Now static.
7411c686 8553 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8554 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8555 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8556 unless they are used.
38d0b34a
PE
8557 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8558 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8559 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8560 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8561 (x_error_catcher, x_connection_closed, x_error_handler):
8562 (x_error_quitter, xembed_send_message, x_iconify_frame):
8563 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8564 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8565 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8566
44f230aa
SM
8567 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8568 Rename or move locals to avoid shadowing.
6b463e58 8569 (tty_defined_color, merge_face_heights): Now static.
5967d051 8570 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8571 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8572 does not deduce is never used uninitialized.
73719eba
PE
8573 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8574 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8575
426994c3 8576 * terminal.c (store_terminal_param): Now static.
5489860b 8577
032f1620 8578 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8579 (set_frame_menubar): Remove unused local.
d4323972 8580 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8581 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8582 since they might point to immutable storage.
281585b0
PE
8583 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8584 since it's unused otherwise.
032f1620 8585
367c19e5 8586 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8587 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8588 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8589 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8590 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8591 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8592 does not deduce are never used uninitialized.
70739cbe 8593
07b48fa9
PE
8594 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8595
8868a238 8596 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8597 * window.c (window_loop, size_window):
8598 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8599
7e5cf297 8600 * window.c (display_buffer): Now static.
d6550a9f
PE
8601 (size_window): Mark variables that gcc -Wuninitialized
8602 does not deduce are never used uninitialized.
a586633d
PE
8603 * window.h (check_all_windows): New decl, to forestall
8604 gcc -Wmissing-prototypes diagnostic.
5b555da1 8605 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8606
f6095868
PE
8607 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8608 shadowing.
8609 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8610 Include <limits.h>.
8611 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8612 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8613 (load_charset_map): Mark variables that gcc -Wuninitialized
8614 does not deduce are never used uninitialized.
53df7c11 8615 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8616
f38b440c
PE
8617 * coding.c (coding_set_source, coding_set_destination):
8618 Use "else { /* comment */ }" rather than "else /* comment */;"
8619 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8620 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8621 a block, when the outer 'i' will do.
8622 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8623 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8624 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8625 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8626 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8627 Rename locals to avoid shadowing.
8628 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8629 * coding.c (emacs_mule_char, encode_invocation_designation):
8630 Now static, since they're not used elsewhere.
413bb2db 8631 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8632 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8633 (decode_coding_emacs_mule): Mark variables that gcc
8634 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8635 (detect_coding_iso_2022): Initialize a local variable that might
8636 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8637 this initialization is needed. (Bug#8211)
5f58e762
PE
8638 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8639 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8640 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8641 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8642 Remove unused macros.
f38b440c 8643
232b38b9 8644 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8645 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8646 * character.c (string_count_byte8): Likewise.
232b38b9 8647
fb90da1b
PE
8648 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8649 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8650
fb93dbc2
PE
8651 * chartab.c (copy_sub_char_table): Now static, since it's not used
8652 elsewhere.
5c156ace
PE
8653 (sub_char_table_ref_and_range, char_table_ref_and_range):
8654 Rename locals to avoid shadowing.
bbcd0949 8655 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8656
7d3b3862 8657 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8658 (BIDI_BOB): Remove unused macro.
7d3b3862 8659
6be7d3da
PE
8660 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8661 deduce are never used uninitialized.
c2ed9c8b 8662 * term.c (encode_terminal_code): Likewise.
6be7d3da 8663
75f8807f 8664 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8665
50938595
PE
8666 * tparam.h: New file.
8667 * term.c, tparam.h: Include it.
8668 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8669 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8670 Move these decls to tparam.h, and make them agree with what
8671 is actually in tparam.c. The previous trick of using incompatible
8672 decls in different modules does not conform to the C standard.
8673 All callers of tparam changed to use tparam's actual API.
8674 * tparam.c (tparam1, tparam, tgoto):
8675 Use const pointers where appropriate.
8676
fbceeba2
PE
8677 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8678 * cm.h (struct cm): Likewise.
8679 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8680 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8681 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8682 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8683 (turn_on_face, init_tty): Likewise.
8684 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8685
7f3f1250
PE
8686 * term.c (term_mouse_position): Rename local to avoid shadowing.
8687
e6ca6543
PE
8688 * alloc.c (mark_ttys): Move decl from here ...
8689 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8690
c40f8d15
AS
86912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8692
8693 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8694
cfe0661d
JB
86952011-03-09 Juanma Barranquero <lekktu@gmail.com>
8696
8697 * search.c (compile_pattern_1): Remove argument regp, unused since
8698 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8699 (compile_pattern): Don't pass it.
8700
0afb4571
J
87012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8702
8703 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8704 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8705 for ! HAVE_GTK3.
8706 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8707
8708 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8709
8710 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8711 gdk_window_get_screen, gdk_window_get_geometry,
8712 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8713 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8714 (xg_get_pixbuf_from_pixmap): New function.
8715 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8716 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8717 Call xg_get_pixbuf_from_pixmap instead of
8718 gdk_pixbuf_get_from_drawable.
8719 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8720 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8721 (xg_check_special_colors): Use GtkStyleContext and its functions
8722 for HAVE_GTK3.
8723 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8724 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8725 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8726 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8727 Call gtk_widget_get_preferred_size.
0afb4571
J
8728 (xg_frame_resized): gdk_window_get_geometry only takes 5
8729 parameters.
44f230aa
SM
8730 (xg_win_to_widget, xg_event_is_for_menubar):
8731 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8732 (xg_set_widget_bg): New function.
8733 (delete_cb): New function.
895009e1 8734 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8735 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8736 (xg_set_background_color): Call xg_set_widget_bg.
8737 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8738 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8739 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8740 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8741 if ! HAVE_GTK3.
8742 (update_frame_tool_bar): Call gtk_widget_hide.
8743 (xg_initialize): Use GDK_KEY_g.
8744
8745 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8746 if ! HAVE_GTK3
8747 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8748
8749 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8750 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8751 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8752
1c2cc4ef
JB
87532011-03-08 Juanma Barranquero <lekktu@gmail.com>
8754
8755 * w32xfns.c (select_palette): Check success of RealizePalette against
8756 GDI_ERROR, not zero.
8757
33383987 8758See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8759
8760;; Local Variables:
8761;; coding: utf-8
aac0c6e3
MR
8762;; End:
8763
33383987 8764 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8765
8766 This file is part of GNU Emacs.
8767
8768 GNU Emacs is free software: you can redistribute it and/or modify
8769 it under the terms of the GNU General Public License as published by
8770 the Free Software Foundation, either version 3 of the License, or
8771 (at your option) any later version.
8772
8773 GNU Emacs is distributed in the hope that it will be useful,
8774 but WITHOUT ANY WARRANTY; without even the implied warranty of
8775 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8776 GNU General Public License for more details.
8777
8778 You should have received a copy of the GNU General Public License
8779 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.