Rename leim/Makefile's BUILT_EMACS to EMACS
[bpt/emacs.git] / src / ChangeLog
CommitLineData
935396c0
GM
12012-04-09 Glenn Morris <rgm@gnu.org>
2
3 * Makefile.in ($(leimdir)/leim-list.el):
4 Pass EMACS rather than BUILT_EMACS.
5
a18ecafa
TZ
62012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
7
8 * process.c (make_process):
9 * process.h: Add integer `gnutls_handshakes_tried' member to
10 process struct.
11
12 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit. Add
13 convenience `GNUTLS_LOG2i' macro.
14
15 * gnutls.c (gnutls_log_function2i): Convenience log function.
16 (emacs_gnutls_read): Use new log functions,
17 `gnutls_handshakes_tried' process member, and
18 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
19 attempts per process (connection).
20
b4d3bc10
CY
212012-04-09 Chong Yidong <cyd@gnu.org>
22
23 * eval.c (Fuser_variable_p, user_variable_p_eh)
24 (lisp_indirect_variable): Functions deleted.
25 (Fdefvar): Caller changed.
26
27 * callint.c (Finteractive, Fcall_interactively):
28 * minibuf.c (Fread_variable): Callers changed.
29
70f4d973
EZ
302012-04-09 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (set_cursor_from_row): If the display string appears in
33 the buffer at position that is closer to point than the position
34 after the display string, display the cursor on the first glyph of
35 the display string. Fixes cursor display when a 'display' text
36 property immediately follows invisible text. (Bug#11094)
37
cb3c2e3e
PE
382012-04-09 Paul Eggert <eggert@cs.ucla.edu>
39
40 composite.c: use 'double' consistently
41 * composite.c (get_composition_id): Use 'double' consistently
42 instead of converting 'float' to 'double' and vice versa; this is
43 easier to understand and avoids a GCC warning.
44
fd06db5d
GM
452012-04-09 Glenn Morris <rgm@gnu.org>
46
50fe702a
GM
47 * Makefile.in: Generate leim-list with bootstrap-emacs, in
48 preparation for dumping it with emacs. (Bug#4789)
49 (leimdir): New variable.
50 ($(leimdir)/leim-list.el): New rule.
51 (emacs$(EXEEXT)): Depend on leim-list.el.
52
fd06db5d
GM
53 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
54 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
55 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
56
55c131ee
AS
572012-04-08 Andreas Schwab <schwab@linux-m68k.org>
58
59 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
60 proper alignment.
61
9209588f
JB
622012-04-07 Juanma Barranquero <lekktu@gmail.com>
63
64 * xml.c (init_libxml2_functions) [WINDOWSNT]:
65 Remove unused local variable.
66
e3fb2efb
PE
672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
68
69 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
70 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
71 (mark_memory): Mark Lisp_Objects only if pointers might hide in
72 objects, as mark_maybe_pointer will catch them otherwise.
73 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
74 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
75
b5385551
PE
762012-04-07 Paul Eggert <eggert@cs.ucla.edu>
77
78 Fix typo that broke non-Windows builds.
79 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
80
9078ead6
EZ
812012-04-07 Eli Zaretskii <eliz@gnu.org>
82
83 Support building on MS-Windows with libxml2.
84
85 * makefile.w32-in (OBJ2): Add xml.$(O).
86 (GLOBAL_SOURCES): Add xml.c.
87 ($(BLD)/xml.$(O)): New dependency list.
88
89 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
90 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
91 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
92 [!WINDOWSNT]: New macros.
93 (init_libxml2_functions, libxml2_loaded_p): New functions.
94 (parse_region): Call fn_xmlCheckVersion instead of using the macro
95 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
96 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
97 Calls xmlCleanupParser only if libxml2 was loaded (or statically
98 linked in).
99 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
100 init_libxml2_functions before calling libxml2 functions.
101 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
102
103 * emacs.c: Don't include libxml/parser.h.
104 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
105 xmlCleanupParser directly.
106
107 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
108
3811fdf3
EZ
1092012-04-07 Eli Zaretskii <eliz@gnu.org>
110
111 * indent.c (Fvertical_motion): If there is a display string at
112 point, use it.vpos to compute how many lines to backtrack after
113 move_it_to point. (Bug#11133)
114
2f8e16b2
EZ
1152012-04-06 Eli Zaretskii <eliz@gnu.org>
116
117 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
118 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
119 about subtle differences between FETCH_CHAR* and STRING_CHAR*
120 macros related to unification of CJK characters. For the details,
121 see the discussion following the message here:
122 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
123
3d439cd1
CY
1242012-04-04 Chong Yidong <cyd@gnu.org>
125
126 * keyboard.c (Vdelayed_warnings_list): Doc fix.
127
8bc53d00
EZ
1282012-04-01 Eli Zaretskii <eliz@gnu.org>
129
130 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
131 instead of alloca. (Bug#11138)
132
3b0512a3
AS
1332012-04-01 Andreas Schwab <schwab@linux-m68k.org>
134
135 * w32menu.c (is_simple_dialog): Properly check lisp types.
136 (Bug#11141)
137
8427ddd2
EZ
1382012-03-31 Eli Zaretskii <eliz@gnu.org>
139
979022ef
EZ
140 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
141 position we get to after a call to move_it_to fails the
142 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
143 only if we wind up in a string from display property. (Bug#11063)
144
a6b1c7cc
EZ
145 * window.c (Fdelete_other_windows_internal): Invalidate the row
146 and column information about mouse highlight, so that redisplay
147 restores it after reallocating the glyph matrices. (Bug#7464)
148
8427ddd2
EZ
149 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
150 string comes from a `display' text property, use the buffer
151 position of that property as if we actually saw that position in
152 the row's glyphs.
697ba24b
EZ
153 (move_it_by_lines): Remove the assertion that
154 "it->current_x == 0 && it->hpos == 0" which can be legitimately
155 violated when there's a before-string at the beginning of a line.
156 (Bug#11063)
8427ddd2 157
65a0a738
EZ
1582012-03-30 Eli Zaretskii <eliz@gnu.org>
159
160 * xdisp.c (append_space_for_newline): If the default face was
161 remapped, use the remapped face for the appended newline.
162 (extend_face_to_end_of_line): Use the remapped default face for
163 extending the face to the end of the line.
164 (display_line): Call extend_face_to_end_of_line when the default
165 face was remapped. (Bug#11068)
166
581355cc
EZ
1672012-03-29 Eli Zaretskii <eliz@gnu.org>
168
169 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
170
e8fc049f
SM
1712012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
172
173 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
174
4fb9a543
GM
1752012-03-27 Glenn Morris <rgm@gnu.org>
176
177 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
178 Doc fixes.
179
679910f1
KH
1802012-03-26 Kenichi Handa <handa@m17n.org>
181
182 * dispextern.h (struct glyph): Fix previous change. Change the
183 bit length of glyphless.ch to 25 (Bug#11082).
184
90d49b7f
CY
1852012-03-26 Chong Yidong <cyd@gnu.org>
186
187 * keyboard.c (Vselection_inhibit_update_commands): New variable.
188 (command_loop_1): Use it; inhibit selection update for
189 handle-select-window too (Bug#8996).
190
f514f6f0
FP
1912012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
192
e8fc049f 193 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 194
bf43fa51
KH
1952012-03-25 Kenichi Handa <handa@m17n.org>
196
197 * dispextern.h (struct glyph): Change the bit length of
198 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
199
8a0c01dd
EZ
2002012-03-24 Eli Zaretskii <eliz@gnu.org>
201
202 * s/ms-w32.h (tzname): Include time.h before redirecting to
203 _tzname. Fixes the MSVC build. (Bug#9960)
204
7d1c3a76
AS
2052012-03-24 Andreas Schwab <schwab@linux-m68k.org>
206
8ed79523
AS
207 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
208 characters.
209
7d1c3a76
AS
210 * xterm.c (XTread_socket): Only modify handling_signal if
211 !SYNC_INPUT. (Bug#11080)
212
e99a9b8b
EZ
2132012-03-23 Eli Zaretskii <eliz@gnu.org>
214
215 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
216 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
217 when fetching a multibyte character consumes more bytes than
218 CHAR_BYTES returns, due to unification of CJK characters in
219 string_char. (Bug#11073)
220
5063c0e1
TN
2212012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
222
223 * process.c (wait_reading_process_output): Handle pty disconnect
224 by refraining from sending oneself a SIGCHLD (bug#10933).
225
9f851fbd
CY
2262012-03-22 Chong Yidong <cyd@gnu.org>
227
228 * dispextern.h (struct it): New member string_from_prefix_prop_p.
229
5063c0e1 230 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
231 Mark string as coming from a prefix property.
232 (handle_face_prop): Use default face for prefix strings (Bug#4281).
233 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
234
fb5b8aca
CY
2352012-03-21 Chong Yidong <cyd@gnu.org>
236
237 * xfaces.c (Vface_remapping_alist): Doc fix.
238
62356a1b
EZ
2392012-03-20 Eli Zaretskii <eliz@gnu.org>
240
241 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
242 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
243 Doc fixes.
62356a1b 244
025de85b
CY
2452012-03-20 Chong Yidong <cyd@gnu.org>
246
247 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
248 to reflect default non-nil value of redisplay-dont-pause.
249
4827f94e
KH
2502012-03-19 Kenichi Handa <handa@m17n.org>
251
252 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
253 it fit in a valid range (Bug#11003).
254
e50a24a2
EZ
2552012-03-18 Eli Zaretskii <eliz@gnu.org>
256
257 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
258 that is not from display property, accept the row as a "cursor
259 row" if one of the string's character has a non-nil `cursor'
260 property. Fixes cursor positioning when there are newlines in
261 overlay strings, e.g. in icomplete.el. (Bug#11035)
262
9af5ed87
PE
2632012-03-12 Paul Eggert <eggert@cs.ucla.edu>
264
265 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
266
d1f55f16
CY
2672012-03-12 Chong Yidong <cyd@gnu.org>
268
269 * eval.c (inhibit_lisp_code): Rename from
270 inhibit_window_configuration_change_hook; move from window.c.
271
272 * xfns.c (unwind_create_frame_1, Fx_create_frame):
273 * window.c (run_window_configuration_change_hook)
274 (syms_of_window): Callers changed.
275
66c5eebd
CY
2762012-03-11 Chong Yidong <cyd@gnu.org>
277
413df973
CY
278 * keymap.c (Fkey_description): Doc fix (Bug#9700).
279
66c5eebd
CY
280 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
281
1de11f56
CY
2822012-03-10 Chong Yidong <cyd@gnu.org>
283
284 * frame.c (other_visible_frames): Don't assume the selected frame
285 is visible (Bug#10955).
286
cae07000
SM
2872012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
288
289 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
290
89c94350
JD
2912012-03-08 Jan Djärv <jan.h.d@swipnet.se>
292
293 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
294 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
295 zero (Bug#10954).
296
999dd333
GM
2972012-03-03 Glenn Morris <rgm@gnu.org>
298
01a6dcc8 299 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 300
de0100f2
EZ
3012012-03-02 Eli Zaretskii <eliz@gnu.org>
302
303 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
304 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
305 (redisplay_window, next_element_from_string): Fix typos in
306 comments.
3e441275
EZ
307 (redisplay_window): Pass to move_it_vertically the margin in
308 pixels, not in screen lines.
de0100f2 309
96a72ee9
GM
3102012-03-02 Glenn Morris <rgm@gnu.org>
311
312 * buffer.c (buffer-list-update-hook): Doc fix.
313
312508d7
EZ
3142012-02-29 Eli Zaretskii <eliz@gnu.org>
315
316 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
317 push_it before setting up the iterator for the first overlay
318 string, even if we have an empty string loaded.
319 (next_overlay_string): If there's an empty string on the iterator
320 stack, pop the stack. (Bug#10903)
321
27f3c637
PE
3222012-02-25 Paul Eggert <eggert@cs.ucla.edu>
323
324 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
325 Suggested by Stefan Monnier in
326 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
327 * alloc.c (widen_to_Lisp_Object): New static function.
328 (mark_memory): Also mark Lisp_Objects by fetching pointer words
329 and widening them to Lisp_Objects. This would work even if
330 USE_LSB_TAG is defined and wide integers are used, which might
331 happen in a future version of Emacs.
332
3c9dfce6
CY
3332012-02-25 Chong Yidong <cyd@gnu.org>
334
fa74b241
CY
335 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
336 Doc fix.
337
3c9dfce6
CY
338 * xselect.c (Fx_selection_exists_p): Doc fix.
339 (x_clipboard_manager_save_all): Print an informative message
340 before saving to clipboard manager.
341
9486df08
CY
3422012-02-24 Chong Yidong <cyd@gnu.org>
343
344 * keyboard.c (process_special_events): Handle all X selection
345 requests in kbd_buffer, not just the next one (Bug#8869).
346
f01d3321
CY
3472012-02-23 Chong Yidong <cyd@gnu.org>
348
349 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
350 call when setting menu-bar-lines and tool-bar-lines parameters.
351 (unwind_create_frame_1): New helper function.
352
353 * window.c (inhibit_window_configuration_change_hook): New var.
354 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 355 (syms_of_window): Initialize it.
f01d3321 356
86b847b6
CY
3572012-02-22 Chong Yidong <cyd@gnu.org>
358
359 * xterm.c (x_draw_image_relief): Add missing type check for
360 Vtool_bar_button_margin (Bug#10743).
361
a59225b1
CY
3622012-02-21 Chong Yidong <cyd@gnu.org>
363
364 * fileio.c (Vfile_name_handler_alist): Doc fix.
365
366 * buffer.c (Fget_file_buffer): Protect against invalid file
367 handler return value.
368
310f5bd4
PE
3692012-02-20 Paul Eggert <eggert@cs.ucla.edu>
370
cb3a28cc
PE
371 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
372 when computing $valmask.
373
310f5bd4
PE
374 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
375 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
376 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
377 It's useless in that case, and it can cause problems on hosts
378 that allocate halves of EMACS_INT values separately.
379 Reported by Dan Horák. Diagnosed by Andreas Schwab in
380 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
381 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
382 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
383 it avoids undefined behavior on hosts where shifting right by more
384 than the word width has undefined behavior.
385
2375c96a
CY
3862012-02-19 Chong Yidong <cyd@gnu.org>
387
388 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
389 (Funhandled_file_name_directory, Ffile_name_as_directory)
390 (Fdirectory_file_name, Fexpand_file_name)
391 (Fsubstitute_in_file_name): Protect against invalid file handler
392 return values (Bug#10845).
393
3eb49e71
EZ
3942012-02-18 Eli Zaretskii <eliz@gnu.org>
395
396 * .gdbinit (pitx): Fix incorrect references to fields of the
397 iterator stack.
398
7b926f3f
CY
3992012-02-17 Chong Yidong <cyd@gnu.org>
400
401 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
402
11273115
PE
4032012-02-15 Paul Eggert <eggert@cs.ucla.edu>
404
405 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
406 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
407
c3a70e2b
CY
4082012-02-15 Chong Yidong <cyd@gnu.org>
409
410 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
411 marked as special. Also, starting docstrings with * is obsolete.
412
0ca43699
AS
4132012-02-13 Andreas Schwab <schwab@linux-m68k.org>
414
415 * gnutls.c (emacs_gnutls_write): Fix last change.
416
2e8f3c56
LI
4172012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
418
419 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
420 send_process.
421
af70074f
SM
4222012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
423
424 * keymap.c (Fsingle_key_description): Handle char ranges.
425
95986d52
CY
4262012-02-12 Chong Yidong <cyd@gnu.org>
427
afd83bd1
CY
428 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
429 as that creates a dangerous corner case.
430
95986d52
CY
431 * window.c (Fdelete_window_internal): Invalidate the mouse
432 highlight (Bug#9904).
433
bd7da63e
GM
4342012-02-12 Glenn Morris <rgm@gnu.org>
435
436 * xselect.c (Fx_own_selection_internal)
437 (Fx_get_selection_internal, Fx_disown_selection_internal)
438 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
439 * nsselect.m (Fx_own_selection_internal)
440 (Fx_disown_selection_internal, Fx_selection_exists_p)
441 (Fx_selection_owner_p, Fx_get_selection_internal):
442 Sync docs and argument specs with the xselect.c versions.
443
77abcbc2
LI
4442012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
445
446 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
447
90b671e2
EZ
4482012-02-11 Eli Zaretskii <eliz@gnu.org>
449
1c0ca0b7
EZ
450 * w32select.c (Fx_selection_exists_p): Sync doc string and
451 argument list with xselect.c. (Bug#10783)
452
453 * w16select.c (Fx_selection_exists_p): Sync doc string and
454 argument list with xselect.c. (Bug#10783)
90b671e2 455
49241268
GM
4562012-02-10 Glenn Morris <rgm@gnu.org>
457
458 * fns.c (Fsecure_hash): Doc fix.
459
f998bbe7 4602012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
461
462 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
463
0992bd9c
CY
4642012-02-07 Chong Yidong <cyd@gnu.org>
465
466 * buffer.c (Fbuffer_local_variables)
467 (buffer_lisp_local_variables): Handle unbound vars correctly;
468 don't let Qunbound leak into Lisp.
469
af008560
GM
4702012-02-07 Glenn Morris <rgm@gnu.org>
471
dd605cc4
GM
472 * image.c (Fimagemagick_types): Doc fix.
473
af008560
GM
474 * image.c (imagemagick-render-type): Change it from a lisp object
475 to an integer. Move the doc here from the lisp manual.
476 Treat all values not equal to 0 the same.
477
1449fa1d
CY
4782012-02-06 Chong Yidong <cyd@gnu.org>
479
480 * doc.c (store_function_docstring): Avoid applying docstring of
481 alias to base function (Bug#2603).
482
3723ec07
AS
4832012-02-04 Andreas Schwab <schwab@linux-m68k.org>
484
485 * .gdbinit (pp1, pv1): Remove redundant defines.
486 (pr): Use pp.
487
79c1cc1e
CY
4882012-02-04 Chong Yidong <cyd@gnu.org>
489
490 * nsterm.m: Declare a global (Bug#10694).
491
d7f29f8e
EZ
4922012-02-04 Eli Zaretskii <eliz@gnu.org>
493
cae07000
SM
494 * w32.c (get_emacs_configuration_options):
495 Include --enable-checking, if specified, in the return value.
d7f29f8e 496
3b95a6f9
MR
4972012-02-04 Martin Rudalics <rudalics@gmx.at>
498
499 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
500 after rounding frame sizes. (Bug#9723)
501
d6fa96a6
EZ
5022012-02-04 Eli Zaretskii <eliz@gnu.org>
503
504 * keyboard.c (adjust_point_for_property): Don't position point
505 before BEGV. (Bug#10696)
506
df0b2940
PE
5072012-02-03 Paul Eggert <eggert@cs.ucla.edu>
508
509 Handle overflow when computing char display width (Bug#9496).
510 * character.c (char_width): Return EMACS_INT, not int.
511 (char_width, c_string_width): Check for overflow when
512 computing the width; this is possible now that individual
513 characters can have unbounded width. Problem introduced
514 by merge from Emacs 23 on 2012-01-19.
515
6bee44d6
MA
5162012-02-02 Michael Albinus <michael.albinus@gmx.de>
517
518 * dbusbind.c (Fdbus_register_method): Mention the return value
519 :ignore in the docstring.
520
44f92739
GM
5212012-02-02 Glenn Morris <rgm@gnu.org>
522
1b9f60cc
GM
523 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
524
44f92739
GM
525 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
526 Unconditionally set to t. (Bug#10673)
527 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
528 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
529 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
530
c5d3843c
KH
5312012-02-02 Kenichi Handa <handa@m17n.org>
532
533 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
534 0, do not call append_composite_glyph.
535
159462d4 5362012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
537
538 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
539 NULL (Bug#6988).
540 (x_produce_glyphs): If the component of a composition is a null
541 string, set it->pixel_width to 1 to avoid zero-width glyph.
542
78cef877
EZ
5432012-02-01 Eli Zaretskii <eliz@gnu.org>
544
545 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
546 first 2 arguments are identical. This makes inserting large
547 output from a subprocess an order of magnitude faster on
548 MS-Windows, where all sbrk'ed memory is always contiguous.
549
97897668
GM
5502012-01-31 Glenn Morris <rgm@gnu.org>
551
552 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 553 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
554 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
555
31fd3586
GM
5562012-01-29 Glenn Morris <rgm@gnu.org>
557
558 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
559
0e24a8b2
CY
5602012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
561
562 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
563
cc0adcb0
CY
5642012-01-28 Chong Yidong <cyd@gnu.org>
565
566 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
567
acc28cb9
CY
5682012-01-26 Chong Yidong <cyd@gnu.org>
569
9c69cfb7
CY
570 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
571
acc28cb9
CY
572 * search.c (Fsearch_forward, Fsearch_backward): Document negative
573 repeat counts (Bug#10507).
574
48da7392
GM
5752012-01-26 Glenn Morris <rgm@gnu.org>
576
577 * lread.c (syms_of_lread): Doc fix.
578
14af5f7f
CY
5792012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
580
581 * coding.c (encode_designation_at_bol): Change return value to
582 EMACS_INT.
583
0b21c100
CY
5842012-01-25 Chong Yidong <cyd@gnu.org>
585
586 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
587
3c2907f7
CY
5882012-01-21 Chong Yidong <cyd@gnu.org>
589
590 * floatfns.c (Fcopysign): Make the second argument non-optional,
591 since nil is not allowed anyway.
592
959ad23f
AS
5932012-01-21 Andreas Schwab <schwab@linux-m68k.org>
594
595 * process.c (read_process_output): Use p instead of XPROCESS (proc).
596 (send_process): Likewise.
597
34a02f46
MR
5982012-01-19 Martin Rudalics <rudalics@gmx.at>
599
600 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
601 (Vwindow_persistent_parameters): Do not use Qstate.
602 Rewrite doc-strings.
34a02f46 603
1259009a 6042012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
605
606 * character.c (char_width): New function.
70d4fdf6
GM
607 (Fchar_width, c_string_width, lisp_string_width):
608 Use char_width (Bug#9496).
25ed9e61 609
6a6ee00d
MR
6102012-01-16 Martin Rudalics <rudalics@gmx.at>
611
612 * window.c (Vwindow_persistent_parameters): New variable.
613 (Fset_window_configuration, save_window_save): Handle persistent
614 window parameters.
615
c85efaf7
EZ
6162012-01-14 Eli Zaretskii <eliz@gnu.org>
617
618 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
619 thrashing the stack of the thread. (Bug#9087)
620
5944709e
PE
6212012-01-12 Paul Eggert <eggert@cs.ucla.edu>
622
623 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
624
e71f5d99
EZ
6252012-01-11 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (rows_from_pos_range): Handle the case where the
628 highlight ends on a newline. (Bug#10464)
629 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
630 he end column for display of highlight that ends on a newline
631 before a R2L line.
632
ce316182
GM
6332012-01-11 Glenn Morris <rgm@gnu.org>
634
635 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
636 from load-path also when installation-directory is nil. (Bug#10208)
637
5b43da69
GM
6382012-01-10 Glenn Morris <rgm@gnu.org>
639
74cc8ff9
GM
640 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
641
7d8d6e4e
GM
642 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
643 Update template values to be closer to their typical values these days.
5b43da69 644
a0db8d43
EZ
6452012-01-09 Eli Zaretskii <eliz@gnu.org>
646
647 * xdisp.c (rows_from_pos_range): Accept additional argument
648 DISP_STRING, and accept any glyph in a row whose object is that
649 string as eligible for mouse highlight. Fixes mouse highlight of
650 display strings from overlays. (Bug#10464)
651
9a0115ab 6522012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 653
b9110d6a 654 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
655 * fileio.c (auto_saving_dir_umask): New static var.
656 (Fmake_directory_internal): Use it.
657 (do_auto_save_make_dir): Set it, instead of invoking chmod after
658 creating the directory. The old code temporarily assigns
659 too-generous permissions to the directory.
660 (do_auto_save_eh): Clear it.
b9110d6a 661 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
662 that the var is always cleared.
663
6c1bd3f3
EZ
6642012-01-07 Eli Zaretskii <eliz@gnu.org>
665
666 * search.c (scan_buffer): Pass character positions to
667 know_region_cache, not byte positions. (Bug#6540)
668
069d2b50
L
6692012-01-07 LynX <_LynX@bk.ru> (tiny change)
670
671 * w32.c (sys_rename): Report EXDEV when rename of a directory
672 fails because the target is on another logical disk. (Bug#10284)
673
75bf0d33
DB
6742012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
675
676 * xterm.c (x_embed_request_focus): New function.
677
678 * xterm.h: Add prototype.
679
680 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
681
1c6e5a32
GM
6822012-01-05 Glenn Morris <rgm@gnu.org>
683
684 * emacs.c (emacs_copyright): Update short copyright year to 2012.
685
651e947e
EZ
6862012-01-01 Eli Zaretskii <eliz@gnu.org>
687
688 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
689 Load gnutls_transport_set_lowat only if GnuTLS version is below
690 2.11.1.
691 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
692 GnuTLS versions below 2.11.1.
693
3778cdd8
AL
6942011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
695
696 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
697 to the doc string advising against its use for altering the way
698 windows are scrolled.
699
0e5317f7
KH
7002011-12-28 Kenichi Handa <handa@m17n.org>
701
702 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
703 coding-system ASCII compatible only when it does not produce BOM
704 on encoding (Bug#10383).
705
93d5ca1f
JD
7062011-12-26 Jan Djärv <jan.h.d@swipnet.se>
707
708 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
709 can scroll.
710 (create_and_show_popup_menu): Always use menu_position_func for
711 Gtk3 (Bug#10361).
712
ca22b785
AS
7132011-12-24 Andreas Schwab <schwab@linux-m68k.org>
714
715 * callint.c (Fcall_interactively): Don't truncate prompt string.
716
d048e1e6
EZ
7172011-12-23 Eli Zaretskii <eliz@gnu.org>
718
719 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
720 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 721 resumed from there (after widening). (Bug#10360)
d048e1e6 722
5ccaba1f
JD
7232011-12-22 Jan Djärv <jan.h.d@swipnet.se>
724
725 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
726
204ee57f
JD
7272011-12-21 Jan Djärv <jan.h.d@swipnet.se>
728
b81d40f0
JB
729 * nsterm.m (x_free_frame_resources):
730 Release f->output_data.ns->miniimage.
204ee57f
JD
731 (ns_index_color): Fix indentation. Do not retain
732 color_table->colors[i].
733
734 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
735 before returning.
736
737 * nsfns.m (x_set_background_color): Assign return value from
738 ns_index_color to face-background instead of NSColor*.
739 (ns_implicitly_set_icon_type): Fix indentation.
740 Change assignment in for loop to comparison.
741
742 * emacs.c (ns_pool): New variable.
743 (main): Assign ns_pool.
744 (Fkill_emacs): Call ns_release_autorelease_pool.
745
746 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
747 autorelease fdesc, release fdAttrs and tdict.
748 (ns_get_covering_families): Release charset.
749 (ns_findfonts): Release NSFontDescriptor created with new.
750 (ns_uni_to_glyphs): Fix indentation.
751 (setString): Release attrStr before assigning new value.
752
c803b2b7
JD
7532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
754
678f4426
JD
755 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
756 and NS_IMPL_COCOA.
757 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
758 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
759
cd394be1 7602011-12-18 David Reitter <reitter@cmu.edu>
678f4426 761
5fecd5fc
JD
762 * nsterm.m (ns_term_init): Subscribe for notifications
763 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
764 to method trackingNotification in EmacsMenu.
765
766 * nsmenu.m (trackingMenu): New variable.
3771cb17 767 (trackingNotification): New method (from Aquamacs).
5fecd5fc 768 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 769 from Aquamacs (Bug#7030).
678f4426
JD
770
7712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 772
c803b2b7
JD
773 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
774 (symbol_to_nsstring): Fix indentation.
775 (ns_symbol_to_pb): New function.
cae07000
SM
776 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
777 (Fns_rotate_cut_buffers_internal): Remove.
778 (Fns_store_selection_internal): Rename from
c803b2b7
JD
779 Fns_store_cut_buffer_internal.
780 (ns_get_foreign_selection, Fx_own_selection_internal)
781 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
782 (Fns_get_selection_internal, Fns_store_selection_internal):
783 Use ns_symbol_to_pb and check if return value is nil.
784 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
785 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
786 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
787 renamed to Sns_store_selection_internal.
788 (ns_handle_selection_request): Move code to Fx_own_selection_internal
789 and remove this function.
790 (ns_handle_selection_clear): Remove, never used.
791 (Fx_own_selection_internal): Move code from ns_handle_selection_request
792 here.
793
e1b01a3a
KB
7942011-12-17 Ken Brown <kbrown@cornell.edu>
795
796 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
797 GID is unknown (Bug#10257).
798
2adb6e85
PE
7992011-12-17 Paul Eggert <eggert@cs.ucla.edu>
800
801 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
802 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
803 which caused a build failure on GNU/Linux IA-64. This problem was
804 introduced by my 2011-10-07 patch.
805
d1d7b339
JL
8062011-12-15 Juri Linkov <juri@jurta.org>
807
808 * image.c (imagemagick_error): New function. (Bug#10112)
809 (imagemagick_load_image): Comment out `MagickSetResolution' call.
810 Use `imagemagick_error' where ImageMagick functions return
811 `MagickFalse'.
812 (Fimagemagick_types): Add `Fnreverse' to return the list in the
813 proper order.
814
100d5755
KH
8152011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
816
817 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
818 fill background (Bug#8992).
819
454592a6
MR
8202011-12-13 Martin Rudalics <rudalics@gmx.at>
821
822 * window.c (Vwindow_combination_resize)
823 (Vwindow_combination_limit): Use t instead of non-nil in
824 doc-strings.
61d4b438
MR
825 (Vrecenter_redisplay): Add first sentence of doc-string on
826 separate line.
53524d93 827 (Frecenter): Fix doc-string typo.
454592a6 828
3633e3aa
KH
8292011-12-11 Kenichi Handa <handa@m17n.org>
830
831 * coding.c (Funencodable_char_position): Pay attention to the
832 buffer text relocation (Bug#9389).
833
7b9d523a
JD
8342011-12-10 Jan Djärv <jan.h.d@swipnet.se>
835
836 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
837 gtk_init (Bug#10100).
838
b73189c6
EZ
8392011-12-10 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
842 IT->string is nil. (Bug#10263)
843
f7dfe5d6
JD
8442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
845
83faebb4
JD
846 * nsterm.h (x_free_frame_resources): Declare.
847
f7dfe5d6
JD
848 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
849 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
850
851 * nsterm.h (ns_get_defaults_value): Declare.
852
853 * nsterm.m (ns_default): Call ns_get_defaults_value.
854
7cd4e72c
EZ
8552011-12-09 Eli Zaretskii <eliz@gnu.org>
856
857 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
858 (Bug#10170)
859
b34d7317
YM
8602011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
861
862 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
863 that where the value of an _OBJC_* symbol points to is in the .bss
864 section (Bug#10240).
865
76470ad1
KH
8662011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
867
868 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 869 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 870
745fff94
KH
8712011-12-08 Kenichi Handa <handa@m17n.org>
872
873 * ftfont.c (get_adstyle_property): Fix previous change
874 (Bug#10233).
875
6e44397c
JB
8762011-12-07 Juanma Barranquero <lekktu@gmail.com>
877
878 * w32.c (init_environment): If no_site_lisp, remove site-lisp
879 dirs from the default value of EMACSLOADPATH (bug#10208).
880
7efa6272
GM
8812011-12-07 Glenn Morris <rgm@gnu.org>
882
883 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
884 installation and source directories as well. (Bug#10208)
885
f6fc4d87
CY
8862011-12-06 Chong Yidong <cyd@gnu.org>
887
888 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
889
2bf26180
GM
8902011-12-06 Glenn Morris <rgm@gnu.org>
891
892 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
893 as an error, not just -1. (Bug#10217)
894
3a6ad4f0
CY
8952011-12-05 Chong Yidong <cyd@gnu.org>
896
897 * keyboard.c (process_special_events): New function.
898 (swallow_events, Finput_pending_p): Use it (Bug#10195).
899
75a3b399
PE
9002011-12-05 Paul Eggert <eggert@cs.ucla.edu>
901
902 * coding.c (encode_designation_at_bol): Don't use uninitialized
903 local variable (Bug#9318).
904
c3c9e25e
KH
9052011-12-05 Kenichi Handa <handa@m17n.org>
906
907 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
908 return Qnil (Bug#8046, Bug#10193).
909
5eb05ea3
KH
9102011-12-05 Kenichi Handa <handa@m17n.org>
911
912 * coding.c (encode_designation_at_bol): New args charbuf_end and
913 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
914 (coding_set_source): Return how many bytes coding->source was
915 relocated.
916 (coding_set_destination): Return how many bytes
917 coding->destination was relocated.
918 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 919 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
920
9212011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
922
923 * coding.c (CODING_CHAR_CHARSET_P): New macro.
924 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
925 macro (Bug#9318).
926
9272011-12-05 Andreas Schwab <schwab@linux-m68k.org>
928
929 The following changes are to fix Bug#9318.
930
a79703f5 931 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
932 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
933 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 934 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 935
7dbda6df
JB
9362011-12-05 Juanma Barranquero <lekktu@gmail.com>
937
938 * lisp.h (process_quit_flag): Fix external declaration.
939
6d5eb5b0
SM
9402011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
941
942 Don't macro-inline non-performance-critical code.
943 * eval.c (process_quit_flag): New function.
944 * lisp.h (QUIT): Use it.
945
a0c3fad0
JD
9462011-12-04 Jan Djärv <jan.h.d@swipnet.se>
947
948 * nsfns.m (get_geometry_from_preferences): New function.
949 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
950
6c07aac2
AS
9512011-12-04 Andreas Schwab <schwab@linux-m68k.org>
952
953 * emacs.c (Qkill_emacs): Define.
954 (syms_of_emacs): Initialize it.
955 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
956 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
957 (quit_throw_to_read_char): Add parameter `from_signal'.
958 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
959 * lisp.h (QUIT): Call Fkill_emacs if requested.
960
c052ead4
JD
9612011-12-03 Jan Djärv <jan.h.d@swipnet.se>
962
963 * widget.c (update_wm_hints): Return if wmshell is null.
964 (widget_update_wm_size_hints): New function.
965
966 * widget.h (widget_update_wm_size_hints): Declare.
967
968 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
969 widget_update_wm_size_hints (Bug#10104).
970
9e49252b
EZ
9712011-12-03 Eli Zaretskii <eliz@gnu.org>
972
973 * xdisp.c (handle_invisible_prop): If the invisible text ends just
974 before a newline, prepare the bidi iterator for consuming the
975 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 976 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 977
02b16839
JL
9782011-12-02 Juri Linkov <juri@jurta.org>
979
980 * search.c (Fword_search_regexp): New Lisp function created from
981 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
982 (Fword_search_backward, Fword_search_forward)
983 (Fword_search_backward_lax, Fword_search_forward_lax):
984 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
985 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
986
0068070e
SM
9872011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
988
989 * fileio.c (Finsert_file_contents): Move after-change-function call
990 to before the "handled:" label, since all "goto handled" appear in
991 cases where the *-change-functions have already been properly called
992 (bug#10117).
993
3360a3fc
AS
9942011-12-01 Andreas Schwab <schwab@linux-m68k.org>
995
996 * keyboard.c (interrupt_signal): Don't call kill-emacs when
997 waiting for input. (Bug#10169)
998
73d6c093
EZ
9992011-11-30 Eli Zaretskii <eliz@gnu.org>
1000
1001 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1002 verifies glyph row's hash code--we have just reallocated the
1003 glyphs, so their contents can be complete garbage. (Bug#10164)
1004
febe6bea
JB
10052011-11-30 Juanma Barranquero <lekktu@gmail.com>
1006
1007 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1008
801a4313
EZ
10092011-11-30 Eli Zaretskii <eliz@gnu.org>
1010
1011 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1012 attributes are tested _before_ calling verify_row_hash, to protect
1013 against GCC re-ordering of the tests. (Bug#10164)
1014
2b56b87e
JD
10152011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1018
1019 * xterm.c (handle_one_xevent): Only set async_visible and friends
1020 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1021 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1022 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1023
dbf31225
PE
10242011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1027 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1028 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1029 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1030 All uses changed to use GCPRO1 etc.
1031 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1032 Revert to old implementation (i.e., before 2011-03-11).
1033
1305621b
YM
10342011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1035
1036 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1037 of scroll runs so as to avoid assigning disabled bogus rows and
1038 unnecessary graphics copy operations.
1039
8c9afb46
EZ
10402011-11-27 Eli Zaretskii <eliz@gnu.org>
1041
1042 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1043 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1044 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1045 (malloc, free, realloc, calloc): Redirect to e_* only when
1046 compiling Emacs.
1047
1048 * lisp.h (GCTYPEBITS): Move before first use.
1049 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1050 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1051 this macro definition.
1052
1053 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1054 _MSC_VER.
1055
54e9e3bf
JD
10562011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1057
6d5eb5b0
SM
1058 * gtkutil.c (xg_create_frame_widgets):
1059 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1060 present with Gtk+ 2.0.
1061
83aca1cb
PE
10622011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * fileio.c (Finsert_file_contents): Undo previous change; see
1065 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1066
5b76caa4
PE
10672011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 Rename locals to avoid shadowing.
1070 * fileio.c (Finsert_file_contents):
1071 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1072 * process.c (wait_reading_process_output):
1073 Rename inner 'proc' to 'p' to avoid shadowing.
1074 Indent for consistency with usual Emacs style.
1075
8c535114
EZ
10762011-11-25 Eli Zaretskii <eliz@gnu.org>
1077
1078 * xdisp.c (redisplay_window): If cursor row is not fully visible
1079 after recentering, and scroll-conservatively is set to a large
1080 number, scroll window by a few more lines to make the cursor fully
1081 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1082 (start_display): Don't move to the next line if the display should
1083 start at a newline that is part of a display vector or an overlay
1084 string. (Bug#10119)
8c535114 1085
fa4fdb5c
JL
10862011-11-24 Juri Linkov <juri@jurta.org>
1087
1088 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1089 after the `MagickPingImage' call. (Bug#10112)
1090
90ec88df
CY
10912011-11-23 Chong Yidong <cyd@gnu.org>
1092
1093 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1094
56e2e794
MR
10952011-11-23 Martin Rudalics <rudalics@gmx.at>
1096
1097 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1098 making another buffer current. (Bug#10114)
1099
b6e64c41
GM
11002011-11-23 Glenn Morris <rgm@gnu.org>
1101
1102 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1103
6b21de18
CY
11042011-11-23 Chong Yidong <cyd@gnu.org>
1105
1106 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1107 using it (Bug#5984).
1108
b12cd789
EZ
11092011-11-22 Eli Zaretskii <eliz@gnu.org>
1110
1111 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1112 and header-lines, as they don't have one computed for them.
1113 (Bug#10098)
1114
1115 * .gdbinit (prow): Make displayed values more self-explaining.
1116 Add row's hash code.
1117
261b6fd4
LMI
11182011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1119
1120 * process.c (wait_reading_process_output): Fix asynchrounous
1121 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1122 (wait_reading_process_output): Add comment and URL.
261b6fd4 1123
e7cfd277
JD
11242011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1125
1126 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1127
a9b9b7f5
CY
11282011-11-21 Chong Yidong <cyd@gnu.org>
1129
1130 * window.c (Fnext_window, Fprevious_window): Doc fix.
1131
b0d15b4f
SM
11322011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1133
1134 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1135
fe7a3057
JB
11362011-11-20 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1139
d2999b1a
MR
11402011-11-20 Martin Rudalics <rudalics@gmx.at>
1141
1142 * window.c (Fset_window_combination_limit): Rename argument
1143 STATUS to LIMIT.
1144 (Vwindow_combination_limit): Remove "status" from doc-string.
1145
d5ff9cd0
AS
11462011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1147
1148 * m/ibms390.h: Remove.
1149 * m/ibms390x.h: Don't include "ibms390.h".
1150
a5bb9bd3
SM
11512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1152
1153 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1154 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1155
cd1181db
JB
11562011-11-20 Juanma Barranquero <lekktu@gmail.com>
1157
1158 * casetab.c (Fset_case_table):
1159 * charset.c (Fcharset_after): Fix typos.
1160
615a3b8d 11612011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1162
17e845af
PE
1163 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1164 Otherwise, valgrind does not work on some platforms.
1165 Problem reported by Andreas Schwab in
6a0bf43d
PE
1166 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1167 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1168 is set, removing the need for VIRT_ADDRESS_VARIES.
1169 (PURE_P): Use a more-efficient implementation that needs just one
1170 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1171 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1172 to 4 (xorl, subq, cmpq, setbe).
1173 * alloc.c (pure): Always extern now, since that's the
1174 VIRT_ADDR_VARIES behavior.
1175 (PURE_POINTER_P): Use a single comparison, not two, for
1176 consistency with the new puresize.h.
1177 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1178 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1179 Remove VIRT_ADDR_VARIES no longer needed.
1180
f8fe6f96
EZ
11812011-11-19 Eli Zaretskii <eliz@gnu.org>
1182
1183 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1184 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1185 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1186 behave as if the cursor position were at the window margin.
1187
1188 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1189 and the cursor position is out of bounds, behave as if the cursor
1190 position were at the window margin. (Bug#10075)
1191
df05a53c
CY
11922011-11-18 Chong Yidong <cyd@gnu.org>
1193
1194 * window.c (Fwindow_combination_limit): Make first argument
1195 non-optional, since it is meaningless for live windows like the
1196 selected window.
1197
2071918e
DA
11982011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1199
1200 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1201
b50a28de
SM
12022011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1203
1204 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1205 (graft_intervals_into_buffer): Simplify.
1206
015137db
EZ
12072011-11-18 Eli Zaretskii <eliz@gnu.org>
1208
1209 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1210 hash values of the two rows.
1211 (copy_row_except_pointers): Preserve the used[] arrays and the
1212 hash values of the two rows. (Bug#10035)
68c95424 1213 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1214
1215 * xdisp.c (row_hash): New function, body extracted from
1216 compute_line_metrics.
1217 (compute_line_metrics): Call row_hash, instead of computing the
1218 hash code inline.
1219
1220 * dispnew.c (verify_row_hash): Call row_hash for computing the
1221 hash code of a row, instead of duplicating code from xdisp.c.
1222
1223 * dispextern.h (row_hash): Add prototype.
1224
a2addb04
TH
12252011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1226
1227 * frame.c (delete_frame): Don't delete the terminal when the last
1228 X frame is closed if emacs is built with GTK toolkit.
1229
df85d315
JB
12302011-11-17 Juanma Barranquero <lekktu@gmail.com>
1231
1232 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1233
a0c2d0ae
MR
12342011-11-17 Martin Rudalics <rudalics@gmx.at>
1235
1236 * window.c (Vwindow_splits): Rename to
1237 Vwindow_combination_resize. Suggested by Juri Linkov.
1238 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1239 of Vwindow_splits.
1240
58179cce
JB
12412011-11-16 Juanma Barranquero <lekktu@gmail.com>
1242
7877f373
JB
1243 * nsfns.m (Fns_font_name):
1244 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1245
b6f67890
MR
12462011-11-16 Martin Rudalics <rudalics@gmx.at>
1247
1248 * window.h (window): Rename slot "nest" to "combination_limit".
1249 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1250 (Fset_window_nest): Rename to Fset_window_combination_limit.
1251 (Vwindow_nest): Rename to Vwindow_combination_limit.
1252 (recombine_windows, make_parent_window, make_window)
1253 (Fsplit_window_internal, saved_window)
1254 (Fset_window_configuration, save_window_save): Rename all
1255 occurrences of window_nest to window_combination_limit.
1256
c7015153
JB
12572011-11-15 Juanma Barranquero <lekktu@gmail.com>
1258
1259 * image.c (imagemagick_load_image): Fix typo.
1260
322ad6ec
EZ
12612011-11-14 Eli Zaretskii <eliz@gnu.org>
1262
1263 * xdisp.c (display_line): Move the call to
1264 highlight_trailing_whitespace before the call to
1265 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1266 faces of all the glyphs to compute ROW's hash value.
1267 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1268
f067b8ec
JB
12692011-11-14 Juanma Barranquero <lekktu@gmail.com>
1270
1271 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1272 just return (bug#10044).
1273
1e5b2111
EZ
12742011-11-12 Eli Zaretskii <eliz@gnu.org>
1275
7ef3cbd5
EZ
1276 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1277 with user-defined heap size. Bump the default size of the temacs
1278 heap to 27MB, to avoid memory warning when running temacs.
1279 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1280
1e5b2111
EZ
1281 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1282 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1283 (verify_row_hash) [XASSERTS]: New function.
1284 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1285 that the hash value of glyph rows is correct.
1e5b2111 1286
89d61221
MR
12872011-11-12 Martin Rudalics <rudalics@gmx.at>
1288
1289 * window.h (window): Remove splits slot.
1290 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1291 (Fdelete_other_windows_internal, make_parent_window)
1292 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1293 (Fset_window_configuration, save_window_save): Don't deal with
1294 split status of windows.
1295 (saved_window): Remove splits slot.
1296 (Vwindow_splits): Rewrite doc-string.
1297
97f18cc8
JD
12982011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1299
1300 * xfns.c (unwind_create_frame):
1301 * nsfns.m (unwind_create_frame):
1302 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1303 Vframe_list (Bug#9999).
1304
22a648b4
DA
13052011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1306
0b381c7e 1307 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1308
659afede
KH
13092011-11-11 Kenichi Handa <handa@m17n.org>
1310
1311 * callproc.c (Fcall_process): Set the member dst_multibyte of
1312 process_coding.
1313
9ac0394b
KH
13142011-11-11 Johan Bockgård <bojohan@gnu.org>
1315
1316 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1317 avoid a crash (bug#9496).
1318
2fbdc249
CY
13192011-11-09 Chong Yidong <cyd@gnu.org>
1320
1321 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1322 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1323
ac6b1f81
PE
13242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1327
09db192c
PE
13282011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 Avoid some portability problems by eschewing 'extern inline' functions.
1331 The trivial performance wins aren't worth the portability hassles; see
1332 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1333 et seq.
1334 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1335 (window_box_width, window_box_left, window_box_left_offset)
1336 (window_box_right, window_box_right_offset): Undo previous change,
1337 by removing the "extern"s.
1338 * intervals.c (adjust_intervals_for_insertion)
1339 (adjust_intervals_for_deletion): Undo previous change,
1340 making these static again.
1341 (offset_intervals, temp_set_point_both, temp_set_point)
1342 (copy_intervals_to_string): No longer inline.
1343 * xdisp.c (window_text_bottom_y, window_box_width)
1344 (window_box_height, window_box_left_offset)
1345 (window_box_right_offset, window_box_left, window_box_right)
1346 (window_box): No longer inline.
1347
105216ed
CY
13482011-11-08 Chong Yidong <cyd@gnu.org>
1349
1350 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1351 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1352 Signal an error if not a live window.
105216ed
CY
1353 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1354 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1355
ae9e237f
JB
13562011-11-07 Juanma Barranquero <lekktu@gmail.com>
1357
1358 * lisp.h (syms_of_abbrev): Remove declaration.
1359 Reported by CHENG Gao <chenggao@royau.me>.
1360
c7aa8333
EZ
13612011-11-07 Eli Zaretskii <eliz@gnu.org>
1362
1363 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1364 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1365 of temacs in GUI mode.
1366
be7f5545
MR
13672011-11-07 Martin Rudalics <rudalics@gmx.at>
1368
1369 * window.h: Declare delete_all_child_windows instead of
1370 delete_all_subwindows.
1371 * window.c (Fwindow_nest, Fset_window_nest)
1372 (Fset_window_new_total, Fset_window_new_normal)
1373 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1374 (delete_all_subwindows): Rename to delete_all_child_windows.
1375 (Fdelete_other_windows_internal, Fset_window_configuration):
1376 Call delete_all_child_windows instead of delete_all_subwindows.
1377 * frame.c (delete_frame): Call delete_all_child_windows instead
1378 of delete_all_subwindows.
1379
ca78dc43
PE
13802011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1381
1382 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1383 This is also needed for porting to any host where GC_MARK_STACK is
1384 not GC_MAKE_GCPROS_NOOPS.
1385 (which_symbols): Use it.
1386
a0241d01
KH
13872011-11-07 Kenichi Handa <handa@m17n.org>
1388
1389 * coding.c (coding_set_destination): Check coding->src_pos only
1390 when coding->src_object is a buffer (bug#9910).
1391
1392 * process.c (send_process): Set the member src_multibyte of coding
1393 to 0 (bug#9911) when sending a unibyte text.
1394
1395 * callproc.c (Fcall_process): Set the member src_multibyte of
1396 process_coding to 0 (bug#9912).
1397
a64bfdfa 13982011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1399
1400 * xmenu.c (cleanup_widget_value_tree): New function.
1401 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1402 calling free_menubar_widget_value_tree directly (Bug#9830).
1403
cb41b32a
PE
14042011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1405
1406 Fix some portability problems with 'inline'.
1407 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1408 (window_box_width, window_box_left, window_box_left_offset)
1409 (window_box_right, window_box_right_offset): Declare extern.
1410 Otherwise, these inline functions do not conform to C99 and
1411 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1412 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1413 * intervals.c (adjust_intervals_for_insertion)
1414 (adjust_intervals_for_deletion): Now extern, because otherwise the
1415 extern inline functions 'offset_intervals' couldn't refer to it.
1416 (static_offset_intervals): Remove.
1417 (offset_intervals): Rewrite using the old contents of
1418 static_offset_intervals. The old version didn't conform to C99
1419 because an extern inline function contained a reference to an
1420 identifier with static linkage.
1421
b7041366
AS
14222011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1423
1424 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1425 GC.
1426
88a37c4d
EZ
14272011-11-06 Eli Zaretskii <eliz@gnu.org>
1428
1429 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1430 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1431 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1432 return Qleft_to_right.
1433
49745b39
CY
14342011-11-06 Chong Yidong <cyd@gnu.org>
1435
1436 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1437 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1438 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1439 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1440 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1441 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1442 (Fwindow_vscroll): Doc fix.
1443 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1444 argument, since it makes no sense to pass a live window and for
1445 consistency with window-child.
1446
1f05cd82
CS
14472011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1448
1449 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1450 support MSVC.
1451
22610910
JR
14522011-11-05 Jason Rumney <jasonr@gnu.org>
1453
1454 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1455 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1456 fonts (Bug#6029).
1457 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1458 bitwise arithmetic preventing use of unicode-sip and non-truetype
1459 opentype fonts.
1460
a06776b2
EZ
14612011-11-05 Eli Zaretskii <eliz@gnu.org>
1462
3ad924ba
EZ
1463 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1464 "emacs"-only part.
1465
a06776b2
EZ
1466 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1467 initialization code to keep similarity to xfns.c after changes
1468 from 2011-11-05.
1469
c9e7db78
JD
14702011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1471
a97f8f3f
JD
1472 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1473 (unwind_create_frame): New function (Bug#9943).
1474 (Fx_create_frame): Restructure code to be more similar to the one in
1475 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1476 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1477 Move terminal->reference_count++ just before making the frame official
1478 (Bug#9943).
1479
1480 * nsterm.m (x_free_frame_resources): New function.
1481 (x_destroy_window): Move code to x_free_frame_resources.
1482
c9e7db78 1483 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1484 (Fx_create_frame, x_create_tip_frame):
1485 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1486 official. Move initialization of image_cache_refcount and
1487 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1488
a6fc3b5c
EZ
14892011-11-05 Eli Zaretskii <eliz@gnu.org>
1490
1491 Support MSVC build with newer versions of Visual Studio.
1492 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1493 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1494 nt/gmake.defs.
1495
1496 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1497 which are not supported by MSVC.
1498 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1499 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1500 bitfields.
1501 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1502 types in bitfields.
1503 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1504
1505 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1506
58179cce 15072011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1508
1509 Support MSVC build with newer versions of Visual Studio.
1510 * w32.c: Don't include w32api.h for MSVC.
1511 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1512
1513 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1514 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1515 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1516 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1517 e_* cousins.
1518 (alloca) [_MSC_VER]: Define to _alloca.
1519
1520 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1521
1522 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1523
a58c13ed
EZ
15242011-11-04 Eli Zaretskii <eliz@gnu.org>
1525
1526 * xdisp.c (note_mouse_highlight): If either of
1527 previous/next-single-property-change returns nil, treat that as
1528 the beginning or the end of the buffer. (Bug#9955)
1529
fe0b6370
JD
15302011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1531
a58c13ed 1532 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1533 label is not null (Bug#9951).
1534 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1535 may be NULL.
1536
89bd5ee1
EZ
15372011-11-04 Eli Zaretskii <eliz@gnu.org>
1538
1539 * window.c (Fwindow_body_size): Mention in the doc string that the
1540 return value is in frame's canonical units. (Bug#9949)
1541
84c3edb9
EZ
15422011-11-03 Eli Zaretskii <eliz@gnu.org>
1543
4e2fb5c7
EZ
1544 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1545
84c3edb9 1546 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1547 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1548 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1549
bc17a887
EZ
15502011-11-01 Eli Zaretskii <eliz@gnu.org>
1551
1552 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1553 Don't stop backward scan on the continuation glyph, even though
1554 its CHARPOS is positive.
6d5eb5b0
SM
1555 (mouse_face_from_buffer_pos, note_mouse_highlight):
1556 Rename cover_string to disp_string.
bc17a887 1557
4ee88440
MR
15582011-11-01 Martin Rudalics <rudalics@gmx.at>
1559
1560 * window.c (temp_output_buffer_show): Don't use
1561 Vtemp_buffer_show_specifiers.
1562 (Vtemp_buffer_show_specifiers): Remove unused variable.
1563
c2ff3c02
EZ
15642011-10-30 Eli Zaretskii <eliz@gnu.org>
1565
1566 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1567 past the beginning of the current glyph matrix.
1568
58179cce 15692011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1570
1571 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1572 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1573 HAVE_GTK3 (Bug#9869).
b77a6a7f 1574
3b574623
JD
1575 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1576 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1577
b77a6a7f
JD
1578 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1579
1580 * xterm.c: Declare x_handle_net_wm_state to return int.
1581 (handle_one_xevent): Check if we are iconified but don't have
1582 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1583 (get_current_wm_state): Return non-zero if not hidden,
1584 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1585 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1586 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1587 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1588
196e41e4
PE
15892011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1592 so that this new function doesn't get optimized away by a
1593 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1594
021f2e1a
AS
15952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1596
1597 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1598
8b058d44
EZ
15992011-10-29 Eli Zaretskii <eliz@gnu.org>
1600
1601 Fix the `xbytecode' command.
1602 * .gdbinit (xprintbytestr): New command.
b50a28de 1603 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1604 (xbytecode): Print the byte-code string as well.
1605
4452fb80
EZ
16062011-10-29 Kim Storm <storm@cua.dk>
1607
8b058d44
EZ
1608 * alloc.c (which_symbols): New function.
1609
21b72067
AS
16102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1611
1612 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1613 line. (Bug#9903)
1614
83ed7b5c
GM
16152011-10-29 Glenn Morris <rgm@gnu.org>
1616
1617 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1618 Not clear what it was for, and it causes various bugs. (Bug#9839)
1619
5a7a728b
EZ
16202011-10-28 Eli Zaretskii <eliz@gnu.org>
1621
1622 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1623 possible random value that matches one of those tested as
1624 condition to clear the mouse face.
1625
d3d0842f
CY
16262011-10-28 Chong Yidong <cyd@gnu.org>
1627
1628 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1629
31b39d13
DN
16302011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1631
1632 * window.c (make_window): Initialize phys_cursor_on_p.
1633
9aba6043
SM
16342011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1635
1636 * lisp.h (struct Lisp_Symbol): Update comments.
1637
c20992f4
JB
16382011-10-28 Juanma Barranquero <lekktu@gmail.com>
1639
1640 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1641
db4f02f2
EZ
16422011-10-28 Eli Zaretskii <eliz@gnu.org>
1643
1644 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1645 <oslsachem@gmail.com> for helping to debug this.
1646
1647 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1648 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1649 (g_b_init_get_glyph_outline_w): New static variables.
1650 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1651 (GetGlyphOutlineW_Proc): New typedefs.
1652 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1653 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1654 New functions.
1655 (w32font_open_internal, compute_metrics):
1656 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1657 instead of calling the "wide" APIs directly.
1658
1659 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1660
1661 * w32.h (syms_of_w32font): Add prototype.
1662
87e68db4
JB
16632011-10-27 Juanma Barranquero <lekktu@gmail.com>
1664
1665 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1666 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1667 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1668 (Fmove_to_window_line): Doc fix.
1669
435c1d67
CY
16702011-10-27 Chong Yidong <cyd@gnu.org>
1671
1672 * process.c (make_process): Set gnutls_state to NULL.
1673
1674 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1675 non-NULL, regardless of GNUTLS_INITSTAGE.
1676 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1677 an error. Set process slots as soon as we allocate them.
1678
1679 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1680
9c6c6f49
CY
16812011-10-27 Chong Yidong <cyd@gnu.org>
1682
9aba6043
SM
1683 * gnutls.c (emacs_gnutls_deinit): New function.
1684 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1685 (Fgnutls_deinit, Fgnutls_boot): Use it.
1686
1687 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1688 (deactivate_process): Call emacs_gnutls_deinit.
1689
657d08d3
JB
16902011-10-27 Juanma Barranquero <lekktu@gmail.com>
1691
1692 * image.c (x_create_x_image_and_pixmap):
1693 * w32.c (sys_rename, w32_delayed_load):
1694 * w32font.c (fill_in_logfont):
1695 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1696
5430d399
JB
16972011-10-26 Juanma Barranquero <lekktu@gmail.com>
1698
1699 * w32fns.c (w32_default_color_map): New function,
1700 extracted from Fw32_default_color_map.
a7ef684b 1701 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1702
fe0055fa
PE
17032011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1704
1705 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1706
e6346438
SM
17072011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1708
1709 * keyboard.c (test_undefined): New function (bug#9751).
1710 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1711
e112cc37
ET
17122011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1713
1714 * sysdep.c (init_sys_modes): Fix the check for the controlling
1715 terminal (Bug#6649).
1716
7b5d6677
EZ
17172011-10-20 Eli Zaretskii <eliz@gnu.org>
1718
1719 * dispextern.h (struct bidi_it): New member next_en_type.
1720
1721 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1722 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1723 current character, check also for next_en_type being WEAK_EN.
1724 (bidi_resolve_weak): Don't enter the expensive loop if the current
1725 position is before next_en_pos. Record the bidi type of the first
1726 non-ET, non-BN character we find, in addition to its position.
1727 (bidi_level_of_next_char): Invalidate next_en_type when
1728 next_en_pos is over-stepped.
1729
7da0b018
PE
17302011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1733 * editfns.c: Rewrite current-time-zone so that it invokes
1734 the equivalent of (format-time-string "%Z") to get the time zone name.
1735 This fixes a bug when the time zone name contains characters that
1736 need converting from the system time locale to Emacs internal format.
1737 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1738 that patch fixed format-time-string to do the conversion, but
1739 I forgot to fix current-time-zone.
1740 (format_time_string): New function, containing most of
1741 what Fformat_time_string used to contain.
1742 (Fformat_time_string): Rewrite in terms of format_time_string.
1743 This doesn't change this function's behavior.
1744 (current-time-zone): Rewrite to use format_time_string.
1745 This fixes the bug reported by Michael Schierl in
1746 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1747 Jason Rumney's 2007-06-07 change worked around this bug, but
1748 didn't fix it.
1749 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1750
8547b010
EZ
17512011-10-19 Eli Zaretskii <eliz@gnu.org>
1752
1753 * xdisp.c (start_display): If the character at POS is displayed
1754 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1755 (try_window_reusing_current_matrix): If a line ends in a display
1756 vector or the next line starts in a display vector, continue
1757 redrawing the window even though the character position of
1758 start_row was reached.
8547b010
EZ
1759 (Bug#9771, part 2)
1760
4e948d15
CY
17612011-10-18 Chong Yidong <cyd@gnu.org>
1762
1763 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1764 with nobreak-char-display too.
1765
4787455f
EZ
17662011-10-18 Eli Zaretskii <eliz@gnu.org>
1767
1768 Fix part 3 of bug#9771.
1769 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1770 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1771 non-neutral characters if the current character is a paragraph
1772 separator (a.k.a. Newline). This avoids running the same
1773 expensive loop twice, once when we consume the preceding newline
1774 and the other time when the line actually needs to be displayed.
1775 Avoid the loop when we see neutrals on the base embedding level
1776 following a character whose directionality is the same as the
1777 paragraph's. This avoids running the expensive loop when a line
1778 ends in a long sequence of neutrals, like control characters.
1779 Add assertion against STRONG_AL type. Slightly rearrange code
1780 that determines the type of a neutral given the first non-neutral
1781 that follows it.
1782 (bidi_level_of_next_char): Set next_en_pos to zero when
1783 invalidating its info.
1784
2c91f553
EZ
17852011-10-17 Eli Zaretskii <eliz@gnu.org>
1786
1787 * xdisp.c (push_display_prop): Determine whether to record string
1788 or buffer position by IT->string, not by IT->method. Allow
1789 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1790 (move_it_vertically_backward): Don't look for character position
1791 immediately after the newline when in a continuation line.
1792 (Bug#9771, part 1)
2c91f553 1793
c7b08b0d
MR
17942011-10-15 Martin Rudalics <rudalics@gmx.at>
1795
1796 * window.c (coordinates_in_window): Rewrite and delabelize
1797 vertical border check. (Bug#5357) (Bug#9618)
1798
6b02f655
SM
17992011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1800
1801 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1802 errors in XSetWindowBorder (bug#9310).
1803
81d40c92
DA
18042011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1805
1806 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1807 avoid crash when xmalloc overrun checking is enabled.
1808
d4172c3b
EZ
18092011-10-13 Eli Zaretskii <eliz@gnu.org>
1810
1811 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1812 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1813 cursor motion with <left> and <right> arrow keys.
1814
1815 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1816 some callers set that themselves.
1817
b00eea75
EZ
18182011-10-12 Eli Zaretskii <eliz@gnu.org>
1819
1820 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1821 display string and the previous row comes from the same string and
1822 is empty. (Bug#9739) (Bug#9738)
1823
8fe012c4
SM
18242011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1825
1826 * doc.c (get_doc_string): Encode file name (bug#9735).
1827
0074aef2
EZ
18282011-10-12 Eli Zaretskii <eliz@gnu.org>
1829
79beb178
EZ
1830 * bidi.c (bidi_level_of_next_char):
1831 * xdisp.c (get_visually_first_element): Remove old incorrect
1832 comments regarding the Unicode Line Separator character.
1833
0074aef2
EZ
1834 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1835
6e4b3fbe
DA
18362011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1837
1838 * alloc.c (Fgc_status): Do not access beyond zombies array
1839 boundary if nzombies > MAX_ZOMBIES.
1840 * alloc.c (dump_zombies): Add missing format specifier.
1841
0324f3af
PE
18422011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1843
b5525cac
PE
1844 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1845 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1846
0324f3af
PE
1847 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1848 Some packages use them to denote characters with modifiers.
1849
e9b5f888
AS
18502011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1851
1852 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1853 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1854 matching a pp-number. Rename parameter var to var1.
1855
127827c0
SM
18562011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1857
1858 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1859
c8fd3bd0
GM
18602011-10-08 Glenn Morris <rgm@gnu.org>
1861
1862 * callint.c (Fcall_interactively): Give a more explicit error for the
1863 'c' case with a non-character input. (Bug#8479)
1864
352ec8ff
EZ
18652011-10-08 Eli Zaretskii <eliz@gnu.org>
1866
03669ccb
EZ
1867 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1868 lines.
7061c986
EZ
1869 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1870 lines that are hscrolled on the left.
03669ccb 1871
352ec8ff
EZ
1872 * dispnew.c (buffer_posn_from_coords): Account for a possible
1873 presence of header-line. (Bug#4426)
1874
a66cfb1c
SM
18752011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1876
6b02f655
SM
1877 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1878 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1879
7c5ee88e
PE
18802011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1881
1882 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1883 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1884 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1885 this makes Emacs dump core during garbage collection on rare
1886 occasions. sizeof is obviously inferior to offsetof here, so
1887 stick with offsetof.
1888 (GC_POINTER_ALIGNMENT): New macro.
1889 (mark_memory): Omit 3rd (offset) arg; caller changed.
1890 Don't assume EMACS_INT alignment is the same as pointer alignment.
1891
df1bbe5b
SM
18922011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1893
1894 * keyboard.c (read_key_sequence_remapped): New var.
1895 (read_key_sequence): Compute remapping in the right buffer.
1896 (command_loop_1): Use read_key_sequence's remapping directly.
1897
51553db6
SM
18982011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1899
32c1fffd
SM
1900 * dired.c (file_name_completion): Don't expand file name.
1901 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1902 before checking file name handler.
1903
51553db6
SM
1904 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1905 they've been requested explicitly (bug#9591).
1906
b6bd1599 19072011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1908
1909 * keymap.c (Fsingle_key_description): Use make_specified_string
1910 instead of build_string to build string from push_key_description.
1911 (Bug#5193)
1912
f701dc2a
PE
19132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1914
4222c55d
PE
1915 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1916 This fixes a Y2038 bug on 64-bit hosts.
1917 * buffer.c (reset_buffer):
1918 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1919 (Fclear_buffer_auto_save_failure):
1920 Use 0, not -1, to represent an unset failure time, since time_t
1921 might not be signed.
1922
f701dc2a
PE
1923 Remove dependency on glibc malloc internals.
1924 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1925 Move back here from lisp.h, but with their new implementations.
1926 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1927 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1928 * charset.c (charset_table_init): New static var.
1929 (syms_of_charset): Use it instead of xmalloc. This removes a
1930 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1931 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1932 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1933 Move back to alloc.c.
1934 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1935 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1936
9ceebf39
JD
19372011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1938
1939 * nsterm.m (windowDidResize): Call x_set_window_size only when
1940 ns_in_resize is true. Otherwise set pixelwidth/height and
1941 call change_frame_size (Bug#9628).
1942
cb993c58
PE
19432011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1944
3930c88b
PE
1945 Port --enable-checking=all to Fedora 14 x86-64.
1946 * charset.c (syms_of_charset): Also account for glibc malloc's
1947 internal overhead when calculating the initial malloc maximum.
1948
cb993c58
PE
1949 Port --enable-checking=all to Fedora 14 x86.
1950 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1951 Move to lisp.h.
1952 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1953 (overrun_check_realloc, overrun_check_free):
1954 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1955 That way, xmalloc returns a properly-aligned pointer even if
1956 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1957 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1958 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1959 into account when calculating the initial malloc maximum.
1960 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1961 Move here from alloc.c, so that charset.c can use it too.
1962 Properly align; the old code wasn't right for common 32-bit hosts
1963 when configured with --enable-checking=all.
1964 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1965 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1966
31bed486
EZ
19672011-09-29 Eli Zaretskii <eliz@gnu.org>
1968
04c70788 1969 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1970 use EDOM.
1971
fbcaa2f3
EZ
19722011-09-28 Eli Zaretskii <eliz@gnu.org>
1973
1974 * xdisp.c (compute_display_string_end): If there's no display
1975 string at CHARPOS, return -1.
1976
1977 * bidi.c (bidi_fetch_char): When compute_display_string_end
1978 returns a negative value, treat the character as a normal
1979 character not covered by a display string. (Bug#9624)
1980
a239d4e9
JB
19812011-09-28 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * lread.c (Fread_from_string): Fix typo in docstring.
1984
88652fd5
EZ
19852011-09-27 Eli Zaretskii <eliz@gnu.org>
1986
1987 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1988 newline, reseat the iterator instead of bidi-iterating there one
1989 character at a time. (Bug#9610)
32c1fffd
SM
1990 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1991 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1992
ed497dd4
AS
19932011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1994
1995 * lread.c (readevalloop): Use correct code for NBSP.
1996 (read1): Likewise. (Bug#9608)
1997
b2bf61aa
MA
19982011-09-25 Michael Albinus <michael.albinus@gmx.de>
1999
2000 * dbusbind.c (Fdbus_register_signal): When service is not
2001 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2002
32bbb17c
GM
20032011-09-25 Glenn Morris <rgm@gnu.org>
2004
2005 * buffer.c (truncate-lines): Doc fix.
2006
94e0933e
CY
20072011-09-24 Chong Yidong <cyd@stupidchicken.com>
2008
2009 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2010 (Fset_window_next_buffers): Doc fix.
2011
cddde921
GM
20122011-09-24 Glenn Morris <rgm@gnu.org>
2013
2014 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2015
1260aef1
PE
20162011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2017
25b4bfa0
PE
2018 Fix minor problems found by static checking.
2019 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2020 * indent.c (Fvertical_motion): Fix == vs = typo.
2021
e3cbd34b
EZ
20222011-09-24 Eli Zaretskii <eliz@gnu.org>
2023
a66cfb1c
SM
2024 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2025 Default value is now t. Doc fix.
6bf7006f 2026
e3cbd34b 2027 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2028 logic when moving up, not only when moving down. Fix the
e3cbd34b 2029 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2030 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2031
2032 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2033 CHARPOS is covered by a display string which includes newlines.
2034 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2035 is covered by a display string with embedded newlines.
2036
a3de0cbd
MA
20372011-09-24 Michael Albinus <michael.albinus@gmx.de>
2038
2039 * dbusbind.c (Fdbus_register_signal): Add match rule to
2040 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2041 (Fdbus_register_method, Vdbus_registered_objects_table):
2042 Fix docstring.
a3de0cbd 2043
b260039d
JM
20442011-09-24 Jim Meyering <meyering@redhat.com>
2045
32c1fffd 2046 do not ignore write error for any output size
b260039d
JM
2047 The previous change was incomplete.
2048 While it makes emacs --batch detect the vast majority of stdout
2049 write failures, errors were still ignored whenever the output size is
2050 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2051 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2052 && echo FAIL: ignored write error
2053 FAIL: ignored write error
2054 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2055 && echo FAIL: ignored write error
2056 FAIL: ignored write error
2057 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2058
8eca8a7c
AS
20592011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2060
2061 * emacs.c (Fkill_emacs): In noninteractive mode exit
2062 non-successfully if a write error occurred on stdout. (Bug#9574)
2063
3341db62
EZ
20642011-09-21 Eli Zaretskii <eliz@gnu.org>
2065
2066 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2067 the xassert test.
2068
2069 * dispextern.h (struct it): Update the comment documenting what
2070 can it->OBJECT be.
2071
8c203dbf
EZ
20722011-09-20 Eli Zaretskii <eliz@gnu.org>
2073
2074 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2075 a display string, extend search for cursor position to end of row.
2076 (find_row_edges): If the row ends in a newline from a display
2077 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2078 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2079 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2080 non-empty line. Fixes confusing cursor motion with arrow keys at
2081 the beginning of a line that starts with whitespace.
8c203dbf 2082
a4824228
LMI
20832011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2084
2085 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2086 (bug#9493).
2087
33ed493b
CY
20882011-09-18 Chong Yidong <cyd@stupidchicken.com>
2089
2090 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2091 boolean (Bug#9154).
2092
56cd55c8
EZ
20932011-09-18 Eli Zaretskii <eliz@gnu.org>
2094
2095 * xdisp.c (display_line): Record maximum and minimum buffer
2096 positions even if no glyphs were produced (e.g., by a zero-width
2097 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2098 buffer positions that will be removed from the glyph row because
2099 they don't fit.
c02dcedf
EZ
2100 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2101 column is beyond frame width: don't subtract 1 "pixel" when
2102 computing width of the stretch.
3e62b7e0
EZ
2103 (reseat_at_next_visible_line_start): Undo the change made on
2104 2011-09-17 that saved paragraph information and restored it after
2105 the call to `reseat'. (Bug#9545)
56cd55c8 2106
5ed99d36 21072011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2108
2109 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2110 and turn window cursor on if cleared (Bug#9415).
2111
5ed99d36 21122011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2113
2114 * search.c (boyer_moore): Take unibyte characters from pattern
2115 literally. (Bug#9458)
2116
9bade7b2
EZ
21172011-09-18 Eli Zaretskii <eliz@gnu.org>
2118
2119 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2120
e5e9d610
PE
21212011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2122
87e4427a
PE
2123 Fix minor problem found by static checking.
2124 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2125 initialized, to pacify gcc -Wuninitialized.
2126
e5e9d610
PE
2127 * fileio.c: Report proper errno when syscall falls.
2128 (Finsert_file_contents): Save and restore errno,
2129 so that report_file_error outputs the correct diagnostic.
2130 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2131
a1674f0b
EZ
21322011-09-18 Eli Zaretskii <eliz@gnu.org>
2133
2134 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2135
fbfb6dd4
EZ
21362011-09-17 Eli Zaretskii <eliz@gnu.org>
2137
2138 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2139 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2140
bb187662
EZ
21412011-09-17 Eli Zaretskii <eliz@gnu.org>
2142
1137e8b8 2143 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2144 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2145
2146 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2147 (bidi_find_paragraph_start): Search back for paragraph beginning
2148 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2149 (bidi_move_to_visually_next): Only trigger paragraph-related
2150 computations when the last character is a newline or at EOB, not
2151 just any NEUTRAL_B. (Bug#9470)
2152
bb187662
EZ
2153 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2154 truncated lines if point is covered by a display string. (Bug#9524)
2155
2e621251
PE
21562011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2159 (cons_to_x_long): New function.
2160 (lisp_data_to_selection_data): Use it. Correct the test for
2161 short-versus-long data; it was negated. Break out of vector
2162 loop, for efficiency, when a long datum is discovered.
2163
91a15bc6
SM
21642011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2165
2166 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2167
b41c3a35
EZ
21682011-09-16 Eli Zaretskii <eliz@gnu.org>
2169
2170 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2171 GCC PR/17406) by declaring this function with external scope.
2172
7812ba2d
PE
21732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2176 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2177
cf7edc2a
AS
21782011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2179
2180 * editfns.c (Fformat): Correctly handle text properties on "%%".
2181
bd01620e
EZ
21822011-09-15 Eli Zaretskii <eliz@gnu.org>
2183
2184 * xterm.c (x_draw_composite_glyph_string_foreground):
2185 * w32term.c (x_draw_composite_glyph_string_foreground):
2186 * term.c (encode_terminal_code):
2187 * composite.c (composition_update_it, get_composition_id):
2188 * xdisp.c (get_next_display_element)
2189 (fill_composite_glyph_string): Add comments about special meaning
2190 of TAB characters in a composition.
2191
a02719a3
PE
21922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2193
2194 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2195 This occurs when processing a multibyte format.
2196 Problem reported by Wolfgang Jenker.
a02719a3 2197
72589a3c
JB
21982011-09-15 Johan Bockgård <bojohan@gnu.org>
2199
2200 * xdisp.c (try_cursor_movement): Only check for exact match if
2201 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2202
1c14176c
PE
22032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 Remove unused external symbols.
2206 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2207 * xdisp.c (calc_pixel_width_or_height): Now static.
2208 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2209 * indent.c (check_display_width):
2210 * w32term.c: Fix comment to match code.
2211 * xterm.c, xterm.h (x_catching_errors): Remove.
2212
d2eea5b5
PE
22132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 * xselect.c: Use signed conversions more consistently (Bug#9498).
2216 (selection_data_to_lisp_data): Assume incoming selection data are
2217 signed integers, not unsigned. This is to be consistent with
2218 outgoing selection data, which was modified to use signed integers
2219 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2220 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2221 expects long, not unsigned long.
2222
46888499
EZ
22232011-09-14 Eli Zaretskii <eliz@gnu.org>
2224
2225 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2226 computation of loop end. Reported by Johan Bockgård
2227 <bojohan@gnu.org>.
2228
ef8ef9fb
CY
22292011-09-13 Chong Yidong <cyd@stupidchicken.com>
2230
2231 * frame.c (Fother_visible_frames_p): Function deleted.
2232
fa819fed
EZ
22332011-09-12 Eli Zaretskii <eliz@gnu.org>
2234
2235 * indent.c (compute_motion): Process display vector front to back
2236 rather than the other way around. (Bug#2496)
2237
2ba8e008
SM
22382011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2239
2240 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2241
20f53c69
CY
22422011-09-11 Chong Yidong <cyd@stupidchicken.com>
2243
2244 * minibuf.c (Fread_from_minibuffer): Doc fix.
2245
d562d7a4
EZ
22462011-09-11 Eli Zaretskii <eliz@gnu.org>
2247
2248 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2249 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2250
1c4d7f3d
LMI
22512011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2252
2253 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2254 value for non-existent files.
2255
b885bf36
EZ
22562011-09-11 Eli Zaretskii <eliz@gnu.org>
2257
2258 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2259 set its "size" to -1. This will set the modtime_size field of
2260 the corresponding buffer to -1, which is what
2261 verify-visited-file-modtime expects for files that do not exist.
2262 (Bug#9139)
2263
6612f0bf
PE
22642011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2265
2266 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2267 here ...
2268 * lisp.h: ... from here. push_key_description is no longer
2269 defined in keyboard.c, so its declaration should not be in
2270 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2271 logically belongs with push_key_description.
2272
dfb3f755
PE
22732011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2274
2275 * buffer.h: Include <sys/types.h> instead of <time.h>.
2276 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2277 Problem reported by Herbert J. Skuhra.
2278
3134906c
LMI
22792011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2280
2281 * xml.c (parse_region): Make the parsing work for
2282 non-comment-starting XML files again (bug#9144).
2283
8d903f4e
AS
22842011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2285
2286 * image.c (gif_load): Fix calculation of bottom and right corner.
2287 (Bug#9468)
2288
80ad64f4
EZ
22892011-09-10 Eli Zaretskii <eliz@gnu.org>
2290
2291 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2292 redisplay in small windows.
2293
208a048d
EZ
22942011-09-09 Eli Zaretskii <eliz@gnu.org>
2295
2296 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2297
9b1c252e
MR
22982011-09-08 Martin Rudalics <rudalics@gmx.at>
2299
2300 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2301 Operate on live windows only.
2302
2949f33b
JB
23032011-09-08 Juanma Barranquero <lekktu@gmail.com>
2304
2305 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2306
e08dcafd
EZ
23072011-09-07 Eli Zaretskii <eliz@gnu.org>
2308
2309 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2310 only under bidi iteration.
2311
115b96bd
JD
23122011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2313
2314 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2315
c8199d0f
PE
23162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2319 Without this fix, the command to link temacs failed due to an
2320 undefined symbol __builtin_isnan. This is because
2321 /usr/include/iso/math_c99.h #defines isnan(x) to
2322 __builtin_isnan(x), but the bundled gcc, which identifies itself
2323 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2324 a __builtin_isnan.
2325 * floatfns.c (isnan): #undef, and then #define to a clone of
2326 what's in data.c.
2327 (Fisnan): Always define, since it's always available now.
2328 (syms_of_floatfns): Always define isnan at the Lisp level.
2329
e39b275c 23302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2331
2332 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2333
b2db44d9 23342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2335
f4af5137 2336 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2337 The previous code assumed that file offsets (off_t values) fit in
2338 EMACS_INT variables, which is not true on typical 32-bit hosts.
2339 The code messed up by falsely reporting buffer overflow in cases
2340 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2341 when "big" contains more than 2**29 bytes, even though this
2342 inserts just one byte and does not overflow the buffer.
2343 (Finsert_file_contents): Store file offsets as off_t
2344 values, not as EMACS_INT values. Check for overflow when
2345 converting between EMACS_INT and off_t. When checking for
2346 buffer overflow or for overlap, take the offsets into account.
2347 Don't use EMACS_INT for small values where int suffices.
2348 When checking for overlap, fix a typo: ZV was used where
2349 ZV_BYTE was intended.
2350 (Fwrite_region): Don't assume off_t fits into 'long'.
2351 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2352
ecfc0a49
MA
23532011-09-05 Michael Albinus <michael.albinus@gmx.de>
2354
2355 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2356
6511acf2 23572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2358
0999621a 2359 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2360
2361 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2362 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2363 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2364 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2365 (modify_event_symbol): Do not assume that the length of
2366 name_alist_or_stem is safe to alloca and fits in int.
2367 (Fexecute_extended_command): Likewise for function name and binding.
2368 (Frecursion_depth): Wrap around reliably on integer overflow.
2369 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2370 since some callers pass EMACS_INT values.
2371 (Fsingle_key_description): Don't crash if symbol name contains more
2372 than MAX_ALLOCA bytes.
2373 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2374 (get_minibuffer): Arg is now EMACS_INT, not int.
2375 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2376 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2377 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2378
2be7d702
PE
2379 * dbusbind.c (signature_cat): New function.
2380 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2381 Do not overrun buffer; instead, report string overflow.
2382
9d1df220
PE
2383 * dispnew.c (add_window_display_history): Don't overrun buffer.
2384 Truncate instead; this is OK since it's just a log.
2385
33ef5c64
PE
2386 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2387 even if the time zone offset is outlandishly large.
2388 Don't mishandle offset == INT_MIN.
2389
66c6fdd5
PE
2390 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2391 when creating daemon; the previous buffer-overflow check was incorrect.
2392
d749b01b
PE
2393 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2394 which has the guts of the old verror function.
2395
b5cd1905
PE
2396 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2397 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2398
6e1a67fb
PE
2399 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2400 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2401 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2402 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2403 length of string rather than counting it via multiple sprintfs;
2404 that's simpler and more reliable.
c21721cc
PE
2405 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2406 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2407 sprintf, in case result does not fit in int.
2408
c57b67fc
PE
2409 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2410 (fontset_from_font): Print it.
2411
8a401434
PE
2412 * frame.c (tty_frame_count): Now printmax_t, not int.
2413 (make_terminal_frame, set_term_frame_name): Print it.
2414 (x_report_frame_params): In X, window IDs are unsigned long,
2415 not signed long, so print them as unsigned.
2416 (validate_x_resource_name): Check for implausibly long names,
2417 and don't assume name length fits in 'int'.
2418 (x_get_resource_string): Don't blindly alloca invocation name;
2419 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2420 not fit in int.
2421
6e1a67fb
PE
2422 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2423 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2424 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2425
0df02bf3
PE
2426 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2427 Use esprintf, not sprintf, in case result does not fit in int.
2428
48e30793
PE
2429 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2430 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2431 it as a large positive number.
2432 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2433 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2434
a66ff6d8
PE
2435 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2436 in case result does not fit in int.
2437
aca216ff
PE
2438 * print.c (float_to_string): Detect width overflow more reliably.
2439 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2440 buffer overrun. Don't assume list length fits in 'int'. Treat
2441 print length of 0 as 0, not as infinity; to be consistent with other
2442 uses of print length in this function. Don't overflow print length
2443 index. Don't assume hash table size fits in 'long', or that
2444 vectorlike size fits in 'unsigned long'.
2445
31c286f7
PE
2446 * process.c (make_process): Use printmax_t, not int, to format
2447 process-name gensyms.
2448
55e5faa1
PE
2449 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2450
80f2e268
PE
2451 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2452 to avoid potential buffer overrun.
2453
670741ab
PE
2454 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2455 if X resource line is longer than 512 bytes.
2456
b7163a50
PE
2457 * xfns.c (x_window): Make sprintf buffer a bit bigger
2458 to avoid potential buffer overrun.
2459
ae58ff1f
PE
2460 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2461
c43c8a6a
PE
2462 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2463
3f8236f4
PE
24642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2465
53e9fe90 2466 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2467 Without these, Emacs silently mishandles large integers sometimes.
2468 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2469 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2470
6511acf2
PE
2471 * xdisp.c (try_window_id): Check Emacs fixnum range before
2472 converting to 'int'.
806add1d 2473
6511acf2 2474 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2475 Check that an Emacs fixnum is in range before assigning it to 'int'.
2476 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2477 values converted from Emacs fixnums.
2478 (Frecenter): Don't wrap around a line count if it is out of 'int'
2479 range; instead, treat it as an extreme value.
2480 (Fset_window_configuration, compare_window_configurations):
2481 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2482
6511acf2
PE
2483 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2484 that can exceed INT_MAX. Check that EMACS_INT value is in range
2485 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2486 (match_limit): Don't assume that a fixnum can fit in 'int'.
2487
6511acf2 2488 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2489 exceed INT_MAX.
2490
6511acf2 2491 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2492 (Fvertical_motion): Don't wrap around LINES values that don't fit
2493 in 'int'. Instead, treat them as extreme values. This is good
2494 enough for windows, which can't have more than INT_MAX lines anyway.
2495
fcb901a7
LMI
24962011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2497
0f2f6b6d
LMI
2498 * Require libxml/parser.h to avoid compilation warning.
2499
fcb901a7
LMI
2500 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2501
2502 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2503 since this reportedly can destroy thread storage.
2504
6e20a0d4
CY
25052011-08-30 Chong Yidong <cyd@stupidchicken.com>
2506
2507 * syntax.c (find_defun_start): Update all cache variables if
2508 exiting early (Bug#9401).
2509
148ae00e
EZ
25102011-08-30 Eli Zaretskii <eliz@gnu.org>
2511
f6cfbd8f
EZ
2512 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2513
148ae00e
EZ
2514 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2515 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2516 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2517
2518 * term.c (tty_append_glyph): New function.
2519 (produce_stretch_glyph): Static function and its prototype deleted.
2520
a66cfb1c
SM
2521 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2522 Add prototypes.
148ae00e 2523
c4a07a4c
PE
25242011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2527 when checking :margin (Bug#9390).
2528 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2529 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2530 so that the name doesn't mislead. All uses changed.
2531
6bc8cd65
JB
25322011-08-28 Johan Bockgård <bojohan@gnu.org>
2533
2534 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2535 set_tty_hooks.
2536
dca4927e
EZ
25372011-08-27 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (move_it_to): Don't bail out early when reaching
2540 position beyond to_charpos, if we are scanning backwards.
2541 (move_it_vertically_backward): When DY == 0, make sure we get to
2542 the first character in the line after the newline.
2543
f2cad773
PE
25442011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2547 (ccl_driver): Do not generate an out-of-range pointer.
2548 (Fccl_execute_on_string): Remove unnecessary check for
2549 integer overflow, noted by Stefan Monnier in
2550 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2551 Remove a FIXME that didn't need fixing.
2552 Simplify the newly-introduced buffer reallocation code.
2553
0cae2cdb
JB
25542011-08-27 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2557
5fc295a4 25582011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2559
70c60eb2 2560 Integer and memory overflow issues (Bug#9196).
726e0ab1 2561
d31850da
PE
2562 * doc.c (get_doc_string): Rework so that
2563 get_doc_string_buffer_size is the actual buffer size, rather than
2564 being 1 less than the actual buffer size; this makes xpalloc more
2565 convenient.
2566
a69fbedb
PE
2567 * image.c (x_allocate_bitmap_record, cache_image):
2568 * xselect.c (Fx_register_dnd_atom):
2569 Simplify previous changes by using xpalloc.
2570
fe5c5d37
PE
2571 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2572 since either will do and ptrdiff_t is convenient with xpalloc.
2573
0065d054
PE
2574 * charset.c (charset_table_size)
2575 (struct charset_sort_data.priority): Now ptrdiff_t.
2576 (charset_compare): Don't overflow if priorities differ greatly.
2577 (Fsort_charsets): Don't assume list length fits in int.
2578 Check for size-calculation overflow when allocating sort data.
2579 (syms_of_charset): Allocate an initial charset table that is
2580 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2581
2582 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2583
2584 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2585 The actual value is always <= INT_MAX, and leaving it unsigned made
2586 overflow checking harder.
2587
2588 * dispextern.h (struct glyph_matrix.rows_allocated)
2589 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2590 with xpalloc. The values are still always <= INT_MAX.
2591
2592 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2593
2594 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2595 (SAFE_NALLOCA): New macro.
2596
2597 * region-cache.c (struct boundary.pos, find_cache_boundary)
2598 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2599 (set_cache_region, invalidate_region_cache)
2600 (revalidate_region_cache, know_region_cache, region_cache_forward)
2601 (region_cache_backward, pp_cache):
2602 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2603 so that ptrdiff_t * can be passed to xpalloc.
2604 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2605 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2606 (pp_cache): Don't assume cache_len fits in int.
2607 * region-cache.h: Adjust extern decls to match.
2608
2609 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2610 EMACS_INT, since either will do, for xpalloc.
2611
2612 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2613 (xnmalloc, xnrealloc, xpalloc): New functions.
2614
726e0ab1
PE
2615 * bidi.c (bidi_shelve_header_size): New constant.
2616 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2617 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2618
51f30bc5 2619 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2620 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2621 (overlay_strings):
2622 Don't update size of array until after memory allocation succeeds,
2623 because xmalloc/xrealloc may not return.
0065d054
PE
2624 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2625 now that we have proper integer overflow checking.
2626 (record_overlay_string, overlay_strings): Catch overflows when
2627 calculating size of overlay_str_buf.
726e0ab1 2628
0065d054
PE
2629 * callproc.c (Fcall_process): Check for size overflow when
2630 calculating size of args2.
2631 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2632 Normally we prefer signed values, but sticking with ptrdiff_t would
2633 require adding more-complicated checks.
726e0ab1
PE
2634
2635 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2636 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2637 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2638 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2639
2640 * character.c (Fstring): Check for size-calculation overflow.
2641
2642 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2643 unnecessary integer overflow. Check for size overflow.
2644 (encode_coding_object): Don't update size until xmalloc succeeds.
2645
2646 * composite.c (get_composition_id): Check for overflow in glyph
2647 length calculations.
2648
2649 Integer and memory overflow fixes for display code.
2650 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2651 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2652 (scrolling_window): Check for overflow in size calculations.
2653 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2654 Don't assume glyph table len fits in int.
2655 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2656 (row_table_size): Now ptrdiff_t, not int.
2657 (scrolling_window): Avoid overflow in size calculations.
2658 Don't update size until allocation succeeds.
2659 * fns.c (concat): Check for overflow in size calculations.
2660 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2661 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2662 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2663
2664 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2665 (get_doc_string): Check for size calculation overflow.
2666 Don't update size until allocation succeeds.
2667 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2668 EMACS_INT, where ptrdiff_t will do.
2669 (Fsubstitute_command_keys): Check for string overflow.
2670
2671 * editfns.c (set_time_zone_rule): Don't assume environment length
2672 fits in int.
2673 (message_length): Now ptrdiff_t, not int.
2674 (Fmessage_box): Don't update size until allocation succeeds.
2675 Don't assume message length fits in int.
2676 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2677
0065d054
PE
2678 * emacs.c (main): Do not reallocate argv, since there is a null at
2679 the end that can be overwritten, and this way there's no need to
2680 worry about size-calculation overflow.
2681 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2682
2683 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2684 alloc succeeds.
2685 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2686
2687 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2688 (x_set_scroll_bar_width, x_figure_window_size):
2689 Check for integer overflow.
2690 (x_set_alpha): Do not assume XINT fits in int.
2691
2692 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2693 This is for the members text_lines, text_cols, total_lines, total_cols,
2694 where the system imposes an 'int' limit.
2695
2696 * fringe.c (Fdefine_fringe_bitmap):
2697 Don't update size until alloc works.
2698
2699 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2700 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2701
2702 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2703 Check for size-calculation overflow.
2704 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2705 do, as we prefer signed integers.
2706 (id_to_widget.max_size, id_to_widget.used)
2707 (xg_store_widget_in_map, xg_remove_widget_from_map)
2708 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2709 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2710 Use and return ptrdiff_t, not int.
2711 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2712 * gtkutil.h: Change prototypes to match the above.
2713
2714 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2715 are duplicate now that they've been promoted to lisp.h.
2716 (x_allocate_bitmap_record, x_alloc_image_color)
2717 (make_image_cache, cache_image, xpm_load):
2718 Don't update size until alloc is done.
2719 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2720 (x_detect_edges):
3256efce 2721 Check for size calculation overflow.
726e0ab1
PE
2722 (ct_colors_allocated_max): New constant.
2723 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2724 overflow.
3256efce 2725
726e0ab1
PE
2726 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2727 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2728 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2729 Use ptrdiff_t, not int, to count maps.
2730 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2731 calculations. Don't update size until allocation succeeds.
2732 Redo calculations to avoid overflow.
726e0ab1
PE
2733 * keyboard.h: Change prototypes to match the above.
2734
2735 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2736 to count maps.
2737 (current_minor_maps): Check for size calculation overflow.
2738 * keymap.h: Change prototypes to match the above.
2739
2740 * lread.c (read1, init_obarray): Don't update size until alloc done.
2741
2742 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2743 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2744
726e0ab1
PE
2745 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2746 Now ptrdiff_t, not int.
2747 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2748 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2749
2750 * process.c (Fnetwork_interface_list): Check for overflow
2751 in size calculation.
2752
2753 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2754
2755 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2756 overflow. Don't bother calling xmalloc when xrealloc will do.
2757
2758 * search.c (Freplace_match): Check for size calculation overflow.
2759 (Fset_match_data): Don't assume list lengths fit in 'int'.
2760
2761 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2762 for command line length. Do not attempt to address one before the
2763 beginning of an array, as that's not portable.
2764
2765 * term.c (max_frame_lines): Remove; unused.
2766 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2767 not int.
2768 (encode_terminal_code, calculate_costs): Check for size
2769 calculation overflow.
2770 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2771 table lengths and related sizes. Don't update size until alloc
2772 done. Redo calculations to avoid overflow.
2773 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2774
2775 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2776 subtracting pointers.
2777 (gobble_line): Check for overflow more carefully. Don't update size
2778 until alloc done.
2779
2780 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2781 Don't update size until alloc done.
2782 Redo size calculations to avoid overflow.
2783 Check for size calculation overflow.
0065d054 2784 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2785
2786 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2787 Use ptrdiff_t, not int, for sizes.
2788 (store_mode_line_noprop_char): Don't update size until alloc done.
2789
0065d054
PE
2790 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2791 Use ptrdiff_t, not int, for sizes.
2792 (Finternal_make_lisp_face, cache_face):
2793 Check for size calculation overflow.
2794 (cache_face): Treat size calculation overflows as if they were
2795 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2796
2797 * xfns.c (x_encode_text, x_set_name_internal)
2798 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2799 sizes, since they can exceed INT_MAX in size. Check for size
2800 calculation overflow.
2801
0065d054
PE
2802 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2803 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2804 Don't update size until alloc done.
2805
0065d054 2806 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2807 as sprintf is limited to int lengths.
1d526e2f 2808
252c5ee1
PE
2809 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2810 (X_LONG_MIN): New macros.
864d7ce7
PE
2811 Use them to make the following changes clearer.
2812 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2813 This change doesn't affect the value now, but it may help remind
2814 future maintainers not to raise the value too much later.
2815 (SELECTION_QUANTUM): Remove, replacing with ...
2816 (selection_quantum): ... new function, which avoids overflow.
2817 All uses changed.
2818 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2819 assumption that selection length fits in 'int'.
2820 (x_reply_selection_request, x_handle_selection_request)
2821 (x_get_window_property, receive_incremental_selection)
2822 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2823 (lisp_data_to_selection_data, clean_local_selection_data):
2824 Use ptrdiff_t, not int, to record length of selection.
2825 (x_reply_selection_request, x_get_window_property)
2826 (receive_incremental_selection, x_property_data_to_lisp):
2827 Redo calculations to avoid overflow.
2828 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2829 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2830 something.
2831 (x_get_window_property, receive_incremental_selection)
2832 (lisp_data_to_selection_data, x_property_data_to_lisp):
2833 Check for size-calculation overflow.
2834 (x_get_window_property, receive_incremental_selection)
2835 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2836 Don't store size until memory allocation succeeds.
2837 (x_get_window_property): Plug memory leak on memory exhaustion.
2838 Don't double-block input; malloc is safe here. Don't assume 2**34
2839 - 4 fits in unsigned long. Add an xassert to check
2840 XGetWindowProperty overflow. Be more careful about overflow
2841 calculations, and distinguish size from memory overflow better.
2842 (receive_incremental_selection): When tracing, don't assume
2843 unsigned int is less than INT_MAX.
2844 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2845 harmful) conversions of unsigned short to int.
2846 (lisp_data_to_selection_data): Don't assume that integers
2847 in the range -65535 through -1 fit in an X unsigned short.
2848 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2849 result parameters unless successful. Rely on cons_to_unsigned
2850 to report problems with elements; the old code wasn't right anyway.
2851 (x_check_property_data): Check for int overflow; we cannot use
2852 a wider type due to X limits.
2853 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2854
726e0ab1 2855 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2856
0065d054
PE
2857 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2858 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2859 (x_color_cells): Don't store size until memory allocation succeeds.
2860 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2861 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2862 (x_term_init): Don't assume length fits in int (sprintf is limited
2863 to int size).
bc18e09d 2864
ebfa62c0
PE
2865 Use ptrdiff_t for composition IDs.
2866 * character.c (lisp_string_width):
2867 * composite.c (composition_table_size, n_compositions)
2868 (get_composition_id, composition_gstring_from_id):
2869 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2870 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2871 * window.c (Frecenter):
2872 Use ptrdiff_t, not int, for composition IDs.
2873 * composite.c (get_composition_id): Check for integer overflow.
2874 * composite.h: Adjust prototypes to match the above changes.
2875
d3411f89
PE
2876 Use ptrdiff_t for hash table indexes.
2877 * category.c (hash_get_category_set):
2878 * ccl.c (ccl_driver):
2879 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2880 * coding.c (coding_system_charset_list, detect_coding_system):
2881 * coding.h (struct coding_system.id):
2882 * composite.c (get_composition_id, gstring_lookup_cache):
2883 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2884 * image.c (xpm_get_color_table_h):
2885 * lisp.h (hash_lookup, hash_put):
2886 * minibuf.c (Ftest_completion):
2887 Use ptrdiff_t for hash table indexes, not int (which is too
2888 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2889 32-bit --with-wide-int hosts).
2890
e097a6fa
PE
2891 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2892 Add a FIXME comment about memory leaks.
2893 (syms_of_charset): Don't assume xmalloc returns.
2894
5637687f
PE
2895 Don't assume that stated character widths fit in int.
2896 * character.c (Fchar_width, c_string_width, lisp_string_width):
2897 * character.h (CHAR_WIDTH):
2898 * indent.c (MULTIBYTE_BYTES_WIDTH):
2899 Use sanitize_char_width to avoid undefined and/or bad behavior
2900 with outlandish widths.
a66cfb1c 2901 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2902 now that we have two such functions. All uses changed.
2903 (sanitize_char_width): New inline function.
2904
a2271ba2
PE
2905 Don't assume that tab-width fits in int.
2906 * character.h (sanitize_width): New inline function.
2907 (SANE_TAB_WIDTH): New macro.
2908 (ASCII_CHAR_WIDTH): Use it.
2909 * indent.c (sane_tab_width): Remove. All uses replaced by
2910 SANE_TAB_WIDTH (current_buffer).
2911 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2912
18c52557
PE
2913 * fileio.c: Integer overflow issues with file modes.
2914 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2915
caeeedc1
PE
2916 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2917 Remove unreachable code.
2918 (read_hex, load_charset_map_from_file): Check for integer overflow.
2919
6df6ae42 2920 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2921 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2922 (x_send_scroll_bar_event): Likewise. Check that the size does not
2923 exceed limits imposed by XClientMessageEvent, as well as the usual
2924 ptrdiff_t and size_t limits.
2925
b13995db
PE
2926 * keyboard.c: Overflow, signedness and related fixes.
2927 (make_lispy_movement): Use same integer type in forward decl
2928 that is used in the definition.
2929 (read_key_sequence, keyremap_step):
2930 Change bufsize argument back to int, undoing my 2011-03-30 change.
2931 We prefer signed types, and int is wide enough here.
2932 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2933 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2934 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2935 length, not size_t. Use ptrdiff_t for index, not int.
2936 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2937 possibility of integer overflow.
2938
13464394
PE
2939 Overflow, signedness and related fixes for images.
2940
2941 * dispextern.h (struct it.stack[0].u.image.image_id)
2942 (struct_it.image_id, struct image.id, struct image_cache.size)
2943 (struct image_cache.used, struct image_cache.ref_count):
2944 * gtkutil.c (update_frame_tool_bar):
2945 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2946 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2947 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2948 * nsmenu.m (update_frame_tool_bar):
2949 * xdisp.c (calc_pixel_width_or_height):
2950 * xfns.c (image_cache_refcount):
2951 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2952 on typical 64-bit hosts.
2953
2954 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2955 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2956 Omit unnecessary casts to int.
2957 (parse_image_spec): Check that integers fall into 'int' range
2958 when the callers expect that.
2959 (image_ascent): Redo ascent calculation to avoid int overflow.
2960 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2961 (lookup_image): Remove unnecessary tests.
2962 (xbm_image_p): Locals are now of int, not EMACS_INT,
2963 since parse_image_check makes sure they fit into int.
2964 (png_load, gif_load, svg_load_image):
2965 Prefer int to unsigned where either will do.
2966 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2967 old tiff_error_handler and tiff_warning_handler.
2968 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2969 stack buffer overflows. It uses only the features of vsnprintf
2970 that are common to both POSIX and native Microsoft.
2971 (tiff_error_handler, tiff_warning_handler): Use it.
2972 (tiff_load, gif_load, imagemagick_load_image):
2973 Don't assume :index value fits in 'int'.
2974 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2975 (imagemagick_load_image): Check that crop parameters fit into
2976 the integer types that MagickCropImage accepts. Don't assume
2977 Vimagemagick_render_type has a nonnegative value. Don't assume
2978 size_t fits in 'long'.
2979 (gs_load): Use printmax_t to print the widest integers possible.
2980 Check for integer overflow when computing image height and width.
2981
c11821d4
EZ
29822011-08-26 Eli Zaretskii <eliz@gnu.org>
2983
2984 * xdisp.c (redisplay_window): Don't force window start if point
2985 will be invisible in the resulting window. (Bug#9324)
2986
0c95fcf7
EZ
29872011-08-25 Eli Zaretskii <eliz@gnu.org>
2988
2989 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2990 the display spec is of the form `(space ...)'.
2991 (handle_display_spec): Return the value returned by
2992 handle_single_display_spec, not just 1 or zero.
2993 (handle_single_display_spec): If the display spec is of the form
2994 `(space ...)', and specifies display in the text area, return 2
2995 rather than 1.
fee65a97 2996 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2997 accurately, and prefer exact match for point under bidi.
2998 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2999
3000 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3001 into disp_prop; all users changed.
3002
3003 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3004 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3005 for the text covered by the display property.
3006
e4ed06f1
CY
30072011-08-25 Chong Yidong <cyd@stupidchicken.com>
3008
3009 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3010 Change return value to nil.
3011 (Frecord_buffer): Delete unused function.
3012
f67cdd7f
EZ
30132011-08-24 Eli Zaretskii <eliz@gnu.org>
3014
5980d4c6
EZ
3015 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3016 buffers, return left-to-right.
8610fe8b
EZ
3017 (set_cursor_from_row): Consider candidate row a win if its glyph
3018 represents a newline and point is on that newline. Fixes cursor
3019 positioning on the newline at EOL of R2L text within L2R
3020 paragraph, and vice versa.
3021 (try_cursor_movement): Check continued rows, in addition to
3022 continuation rows. Fixes unwarranted scroll when point enters a
3023 continued line of R2L text within an L2R paragraph, or vice versa.
3024 (cursor_row_p): Consider the case of point being equal to
3025 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3026 from the end of a short line to the beginning of a continued line
3027 of R2L text within L2R paragraph.
3028 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3029 composed characters.
5980d4c6 3030
f67cdd7f
EZ
3031 * bidi.c (bidi_check_type): Use xassert.
3032 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3033 members.
3034
bca633fb
EZ
30352011-08-23 Eli Zaretskii <eliz@gnu.org>
3036
3037 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3038 a character.
3039
4a5885a7
CY
30402011-08-23 Chong Yidong <cyd@stupidchicken.com>
3041
3042 * nsfont.m (ns_otf_to_script): Fix typo.
3043
0902a04e
KH
30442011-08-22 Kenichi Handa <handa@m17n.org>
3045
3046 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3047 extra slot even if the purpose is char-code-property-table.
3048
1a2e6670
EZ
30492011-08-23 Eli Zaretskii <eliz@gnu.org>
3050
8ddde651
EZ
3051 * xdisp.c (redisplay_window): When computing centering_position,
3052 account for the height of the header line. (Bug#8874)
3053
425cc014
EZ
3054 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3055 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3056 candidate is selected by the mouse, and that candidate has a
3057 composed character under the mouse.
3058
1a2e6670
EZ
3059 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3060 coordinates reported by pos-visible-in-window-p for a composed
3061 character in column zero.
3062
8b76d6f8
SM
30632011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3064
3065 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3066
dac347dd
EZ
30672011-08-22 Eli Zaretskii <eliz@gnu.org>
3068
3069 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3070 consider it a hit if to_charpos is anywhere in the range of the
3071 composed buffer positions.
3072
e013fb34
CY
30732011-08-22 Chong Yidong <cyd@stupidchicken.com>
3074
3075 * image.c (gif_load): Don't assume that each subimage has the same
3076 dimensions as the base image. Handle disposal method that is
3077 "undefined" by the gif spec (Bug#9335).
3078
bd1ba3e8
CY
30792011-08-20 Chong Yidong <cyd@stupidchicken.com>
3080
3081 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3082 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3083
54a1215b
EZ
30842011-08-19 Eli Zaretskii <eliz@gnu.org>
3085
823564e5
EZ
3086 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3087 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3088 from an Org mode buffer to a Speedbar frame.
3089
54a1215b
EZ
3090 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3091 a composition, take its buffer position from IT->cmp_it.charpos.
3092 Fixes cursor positioning at the beginning of a line that begins
3093 with a composed character.
3094
9778ebcc
EZ
30952011-08-18 Eli Zaretskii <eliz@gnu.org>
3096
0be6ee06
EZ
3097 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3098 character bidirectional type, use STRONG_L instead. Fixes crashes
3099 in a buffer produced by `describe-categories'.
3100
9778ebcc
EZ
3101 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3102 members before the level stack, so they would be saved and
3103 restored when copying iterator state. Fixes incorrect reordering
3104 around TABs covered by display properties.
3105
156bffbe
AS
31062011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3107
6b02f655 3108 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3109
72ad093b
CY
31102011-08-17 Chong Yidong <cyd@stupidchicken.com>
3111
3112 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3113 (internal_condition_case_2, internal_condition_case_n):
3114 Remove unnecessary aborts (Bug#9081).
72ad093b 3115
35774242
EZ
31162011-08-17 Eli Zaretskii <eliz@gnu.org>
3117
3118 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3119 has no `load' handler, try opening the file locally. (Bug#9311)
3120
db76dd85
KB
31212011-08-16 Ken Brown <kbrown@cornell.edu>
3122
3123 * gmalloc.c: Expand comment.
3124
b215eee5
EZ
31252011-08-16 Eli Zaretskii <eliz@gnu.org>
3126
3127 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3128 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3129
a4579d33
KB
31302011-08-16 Ken Brown <kbrown@cornell.edu>
3131
3132 Fix memory allocation problems in Cygwin build (Bug#9273).
3133
3134 * unexcw.c ( __malloc_initialized): Declare external variable.
3135 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3136
8b76d6f8
SM
3137 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3138 New variables.
a4579d33
KB
3139 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3140 dumped emacs.
3141 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3142 in the static heap.
3143 [CYGWIN] (special_realloc): New function.
3144 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3145 requests to realloc storage in the static heap.
3146
3ebec551
PE
31472011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * bidi.c (bidi_initialize): Remove unused local.
3150
9fd8be00
EZ
31512011-08-15 Eli Zaretskii <eliz@gnu.org>
3152
6b02f655
SM
3153 * bidimirror.h:
3154 * biditype.h: Remove file.
3155 * makefile.w32-in ($(BLD)/bidi.$(O)):
3156 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3157
3158 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3159
3160 * chartab.c: Improve commentary for the uniprop_table API.
3161
32413314
EZ
3162 * bidi.c (bidi_paragraph_init): Support zero value of
3163 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3164 (bidi_initialize): Use uniprop_table instead of including
3165 biditype.h and bidimirror.h.
32413314 3166
9fd8be00
EZ
3167 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3168 coordinates of the iterator when restoring from ppos_it.
3169 (Bug#9296)
3170
5cf2b69b
KH
31712011-08-14 Kenichi Handa <handa@m17n.org>
3172
3173 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3174 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3175
daf17d00
EZ
31762011-08-14 Eli Zaretskii <eliz@gnu.org>
3177
3178 * xdisp.c (move_it_in_display_line_to): Don't invoke
3179 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3180 ppos_it. Fixes vertical cursor motion when line beginning is
3181 covered by an image. (Bug#9296)
3182
08e3161a
JD
31832011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3184
3185 * nsterm.h (ns_run_ascript): Declare.
3186 (NSAPP_DATA2_RUNASSCRIPT): Define.
3187
3188 * nsfns.m (as_script, as_result, as_status): New static variables.
3189 (ns_run_ascript): New function.
5e617bc2 3190 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3191 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3192 the event loop. Get status from as_status (Bug#7276).
3193
3194 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3195 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3196 the event loop (Bug#7276).
3197
a3720aa2
AS
31982011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3199
3200 * gnutls.c (QCgnutls_bootprop_priority)
3201 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3202 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3203 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3204 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3205 (QCgnutls_bootprop_verify_hostname_error)
3206 (QCgnutls_bootprop_callbacks_verify): Rename from
3207 Qgnutls_bootprop_..., all uses changed.
3208
3209 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3210 uses changed.
3211
0a0d27fb
PE
32122011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3213
19d5c50c
PE
3214 * xfaces.c (Qframe_set_background_mode): Now static.
3215 * dispextern.h (Qframe_set_background_mode): Remove decl.
3216
0a0d27fb
PE
3217 * process.c (Fnetwork_interface_info): Declare local only if needed.
3218
377538cb
JD
32192011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3220
3221 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3222 (Fnetwork_interface_list): Allocate in increments of bytes instead
3223 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3224 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3225 sockaddr.
3226 (struct ifflag_def): notrailers is smart on OSX.
3227 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3228 Get hardware address with getifaddrs if available.
3229
08fff70c
EZ
32302011-08-12 Eli Zaretskii <eliz@gnu.org>
3231
3232 * xdisp.c (iterate_out_of_display_property): xassert that
3233 IT->position is set to within IT->object's boundaries. Break from
3234 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3235 when IT->position is set up wrongly due to some bug.
3236 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3237 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3238 entry. Force push_it to save on the stack the current
3239 buffer/string position, to be restored by pop_it. Fix flags in
3240 the iterator structure wrt the object coming from a display
3241 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3242 properties. (Bug#9284)
3243
7be1c708 32442011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3245
7be1c708
CY
3246 * fontset.c (fontset_get_font_group): Add proper type checks.
3247 (Bug#9172)
aac0c6e3 3248
7be1c708 32492011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3250
7be1c708
CY
3251 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3252 and LC_VERSION_MIN_MACOSX.
3253 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3254 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3255
97bb72a6
EZ
32562011-08-08 Eli Zaretskii <eliz@gnu.org>
3257
3258 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3259 no-display-properties-and-no-overlays under bidi display.
3260 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3261 properties and overlays.
97bb72a6 3262
d5617611
CY
32632011-08-08 Chong Yidong <cyd@stupidchicken.com>
3264
37e11a63
CY
3265 * editfns.c (Fset_time_zone_rule): Document relationship with the
3266 setenv function.
3267
d5617611
CY
3268 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3269 the font entity extracted from the cache (Bug#8109).
3270
58872834
CY
32712011-08-07 Chong Yidong <cyd@stupidchicken.com>
3272
3273 * composite.c (autocmp_chars): Don't reset point. That is done by
3274 restore_point_unwind (Bug#5984).
3275
75bfc667
JL
32762011-08-07 Juri Linkov <juri@jurta.org>
3277
3278 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3279 to show the arg `TIME' instead of `TIMEVAL'.
3280
d1410150
EZ
32812011-08-06 Eli Zaretskii <eliz@gnu.org>
3282
3283 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3284 display property strides EOL and includes a newline, as in
3285 longlines-mode. (Bug#9254)
75b771e4
EZ
3286 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3287 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3288
3289 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3290 is non-zero, even if the data buffer is NULL. Fixes a crash in
3291 vertical-motion with longlines-mode. (Bug#9254)
3292
35928349
EZ
32932011-08-05 Eli Zaretskii <eliz@gnu.org>
3294
ec7cc85b
EZ
3295 * bidi.c <bidi_cache_total_alloc>: Now static.
3296 (bidi_initialize): Initialize bidi_cache_total_alloc.
3297
8b76d6f8 3298 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3299 cache. (Bug#9221)
3300
3301 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3302 amount allocated this far in `bidi_cache_total_alloc'.
3303 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3304 non-zero, only free the data buffer without restoring the cache
3305 contents. All callers changed.
3306
3307 * dispextern.h (bidi_unshelve_cache): Update prototype.
3308
3309 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3310 (move_it_in_display_line, move_it_to)
3311 (move_it_vertically_backward, move_it_by_lines): Replace the call
3312 to xfree to an equivalent call to bidi_unshelve_cache.
3313 (move_it_in_display_line_to): Fix logic of returning
412b6358 3314 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3315
e2e2423b
EZ
33162011-08-05 Eli Zaretskii <eliz@gnu.org>
3317
3318 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3319 came from a string character with a `cursor' property. (Bug#9229)
3320
ae9e757a
JD
33212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3322
3323 * Makefile.in (LIB_PTHREAD): New variable.
3324 (LIBES): Add LIB_PTHREAD (Bug#9216).
3325
3326 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3327 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3328
213bd7f2
AS
33292011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3330
6b02f655 3331 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3332
99aaf75f
JD
33332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3334
3335 * xterm.c (x_find_topmost_parent): New function.
3336 (x_set_frame_alpha): Find topmost parent window with
3337 x_find_topmost_parent and set the property there also (bug#9181).
3338 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3339
c74e9d86
PE
33402011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * callproc.c (Fcall_process): Avoid vfork clobbering
3343 the local vars buffer, coding_systems, current_dir.
3344
640c8776
SM
33452011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3346
3347 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3348
f26d0e4c
PE
33492011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3350
8a10d76c
PE
3351 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3352 so that it is not optimized away.
3353
f26d0e4c
PE
3354 * xdisp.c (compute_display_string_pos): Remove unused local.
3355
55439c61
EZ
33562011-08-02 Eli Zaretskii <eliz@gnu.org>
3357
3358 Fix slow cursor motion and scrolling in large buffers with
3359 selective display, like Org Mode buffers. (Bug#9218)
3360
3361 * dispextern.h (struct bidi_it): New member disp_prop_p.
3362
3363 * xdisp.c: Remove one-slot cache of display string positions.
3364 (compute_display_string_pos): Accept an additional argument
5e617bc2 3365 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3366 for a display string or property. If found, set DISP_PROP_P
3367 non-zero.
3368
3369 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3370 DISP_PROP_P, and pass it to compute_display_string_pos.
3371 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3372 non-zero. All callers of bidi_fetch_char changed.
3373
fb33fa43
SM
33742011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3375
3376 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3377
b099e063
DM
33782010-12-03 Don March <don@ohspite.net>
3379
3380 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3381 last character M-[char] is translated to ESC [char] (bug#7541).
3382
5cc7f7af
KH
33832011-08-02 Kenichi Handa <handa@m17n.org>
3384
d0fffa3f 3385 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3386
3387 * chartab.c (uniprop_table): Make it non-static.
3388
525d5e6e
EZ
33892011-08-01 Eli Zaretskii <eliz@gnu.org>
3390
3391 * xdisp.c (forward_to_next_line_start): Accept additional argument
3392 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3393 on the newline.
3394 (reseat_at_next_visible_line_start): Use the bidi iterator state
3395 returned by forward_to_next_line_start to restore the state of
3396 it->bidi_it after backing up to previous newline. (Bug#9212)
3397
31011111
AS
33982011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3399
3400 * regex.c (re_comp): Protoize.
3401 (re_exec): Fix return type.
3402 (regexec): Fix type of `ret'. (Bug#9203)
3403
476371c4
PE
34042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3405
e5d76069
PE
3406 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3407 This is needed if max-image-size is a floating-point number.
3408
9a79b20c
AS
34092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3410
3411 * print.c (print_object): Print empty symbol as ##.
3412
3413 * lread.c (read1): Read ## as empty symbol.
3414
d8c2fa78
AA
34152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3416
3417 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3418 setting frame foreground color (Bug#9175).
3419 (x_set_background_color): Likewise.
3420
ffe57a7a
AA
3421 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3422 contents (Bug#9176).
3423 (EmacsTooltip -init): Remove bezels and add shadows to
3424 tooltip windows.
3425
bf3492a5
AA
3426 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3427 or scroll bar (Bug#8470).
3428
d55e9c53
AA
3429 * nsfont.m (nsfont_open): Remove assignment to voffset and
3430 unnecessary vars hshink, expand, hd, full_height, min_height.
3431 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3432
3433 * nsterm.h (nsfont_info): Remove voffset field.
3434
d8c2fa78 34352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3436
3437 Implement strike-through and overline on NextStep (Bug#8863).
3438
3439 * nsfont.m (nsfont_open): Use underline position provided by font,
3440 instead of hard-coded value of 2.
3441 (nsfont_draw): Call ns_draw_text_decoration instead.
3442
3443 * nsterm.h: Add declaration for ns_draw_text_decoration.
3444
3445 * nsterm.m (ns_draw_text_decoration): New function for drawing
3446 underline, overline, and strike-through.
3447 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3448 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3449 accommodate underlining, etc.
4843aac3 3450
4cc60b9b
EZ
34512011-07-28 Eli Zaretskii <eliz@gnu.org>
3452
bc7ece87
EZ
3453 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3454 default.
4cc60b9b 3455
476371c4
PE
34562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3457
66606eea
PE
3458 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3459 Without this fix, if a signal arrives just after memory fills up,
3460 'malloc' might be invoked reentrantly.
3461
476371c4
PE
3462 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3463 In other words, assume that every image size is allowed, on non-X
3464 hosts. This assumption is probably wrong, but it lets Emacs compile.
3465
f3fcc40d
AS
34662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3467
3468 * regex.c (re_iswctype): Convert return values to boolean.
3469
350c992f
EZ
34702011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3471
3472 * xdisp.c (compute_display_string_pos): Don't use cached display
3473 string position if the buffer had its restriction changed.
3474 (Bug#9184)
3475
5266b4bb
PE
34762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3479
2573a837 34802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3481
41f55ccd 3482 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3483
39e378da
PE
3484 * bidi.c: Integer size and overflow fixes.
3485 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3486 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3487 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3488 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3489 (bidi_find_other_level_edge):
3490 Use ptrdiff_t instead of EMACS_INT where either will do.
3491 This works better on 32-bit hosts configured --with-wide-int.
3492 (bidi_cache_ensure_space): Check for size-calculation overflow.
3493 Use % rather than repeated addition, for better worst-case speed.
3494 Don't set bidi_cache_size until after xrealloc returns, because it
3495 might not return.
3496 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3497 (bidi_cache_ensure_space): Also check that the bidi cache size
3498 does not exceed that of the largest Lisp string or buffer. See Eli
3499 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3500
5e927815
PE
3501 * alloc.c (__malloc_size_t): Remove.
3502 All uses replaced by size_t. See Andreas Schwab's note
3503 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3504
ca4aa935
PE
3505 * image.c: Improve checking for integer overflow.
3506 (check_image_size): Assume that f is nonnull, since
3507 it is always nonnull in practice. This is one less thing to
3508 worry about when checking for integer overflow later.
3509 (x_check_image_size): New function, which checks for integer
3510 overflow issues inside X.
3511 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3512 This removes the need for a memory_full check.
3513 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3514 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3515 (xbm_read_bitmap_data): Change locals back to 'int', since
3516 their values must fit in 'int'.
3517 (xpm_load_image, png_load, tiff_load):
3518 Invoke x_create_x_image_and_pixmap earlier,
3519 to avoid much needless work if the image is too large.
3520 (tiff_load): Treat overly large images as if
3521 x_create_x_image_and_pixmap failed, not as malloc failures.
3522 (gs_load): Use x_check_image_size.
3523
5f8f9cc2
PE
3524 * gtkutil.c: Omit integer casts.
3525 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3526 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3527
5adf60bc
PE
3528 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3529
c8907a93
PE
3530 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3531 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3532 would wrongly return t on a 64-bit host.
3533
e3c25c68
PE
3534 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3535 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3536 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3537 and therefore cause GCC to emit a bogus diagnostic in some cases.
3538
3f791afe
PE
3539 * image.c: Integer signedness and overflow and related fixes.
3540 This is not an exhaustive set of fixes, but it's time to
3541 record what I've got.
3542 (lookup_pixel_color, check_image_size): Remove redundant decls.
3543 (check_image_size): Don't assume that arbitrary EMACS_INT values
3544 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3545 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3546 (tiff_load, imagemagick_load_image):
3547 Check for overflow in size calculations.
3548 (x_create_x_image_and_pixmap): Remove unnecessary test for
3549 xmalloc returning NULL; that can't happen.
3550 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3551 (xpm_color_bucket): Use better integer hashing function.
3552 (xpm_cache_color): Don't possibly over-allocate memory.
3553 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3554 (gif_memory_source):
3555 Use ptrdiff_t, not int or size_t, to record sizes.
3556 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3557 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3558 either works, as we prefer signed integers.
3559 (tiff_read_from_memory, tiff_write_from_memory):
3560 Return tsize_t, not size_t, since that's what the TIFF API wants.
3561 (tiff_read_from_memory): Don't fail simply because the read would
3562 go past EOF; instead, return a short read.
3563 (tiff_load): Omit no-longer-needed casts.
3564 (Fimagemagick_types): Don't assume size fits into 'int'.
3565
3cc5a532
PE
3566 Improve hashing quality when configured --with-wide-int.
3567 * fns.c (hash_string): New function, taken from sxhash_string.
3568 Do not discard information about ASCII character case; this
3569 discarding is no longer needed.
3570 (sxhash-string): Use it. Change sig to match it. Caller changed.
3571 * lisp.h: Declare it.
3572 * lread.c (hash_string): Remove, since we now use fns.c's version.
3573 The fns.c version returns a wider integer if --with-wide-int is
3574 specified, so this should help the quality of the hashing a bit.
3575
b312a492
PE
3576 * emacs.c: Integer overflow minor fix.
3577 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3578 Define only if GNU_LINUX.
3579 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3580
dfd153ae
PE
3581 * dispnew.c: Integer signedness and overflow fixes.
3582 Remove unnecessary forward decls, that were a maintenance hassle.
3583 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3584 All uses changed.
3585 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3586 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3587 (prepare_desired_row, line_draw_cost):
3588 Use int, not unsigned, where either works.
3589 (save_current_matrix, restore_current_matrix):
3590 Use ptrdiff_t, not size_t, where either works.
3591 (init_display): Check for overflow more accurately, and without
3592 relying on undefined behavior.
3593
a81d11a3
PE
3594 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3595 Remove, replacing with the new symbols in lisp.h. All uses changed.
3596 * fileio.c (make_temp_name):
3597 * filelock.c (lock_file_1, lock_file):
3598 * xdisp.c (message_dolog):
3599 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3600 Use pMd etc. instead.
3601 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3602 replacing the pWIDE etc. symbols removed from editfns.c.
3603
3300e6fd
PE
3604 * keyboard.h (num_input_events): Now uintmax_t.
3605 This is (very slightly) less likely to mess up due to wraparound.
3606 All uses changed.
3607
fd05c7e9
PE
3608 * buffer.c: Integer signedness fixes.
3609 (alloc_buffer_text, enlarge_buffer_text):
3610 Use ptrdiff_t rather than size_t when either will do, as we prefer
3611 signed integers.
3612
903fe15d
PE
3613 * alloc.c: Integer signedness and overflow fixes.
3614 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3615 (__malloc_size_t): Default to size_t, not to int.
3616 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3617 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3618 Prefer ptrdiff_t to size_t when either would do, as we prefer
3619 signed integers.
3620 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3621 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3622 Now const. Initialize with values that are in range even if char
3623 is signed.
3624 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3625 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3626 These functions do the right thing with sizes > 2**32.
3627 (check_depth): Now ptrdiff_t, not int.
3628 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3629 Adjust to new way of storing sizes. Check for size overflow bugs
3630 in rest of code.
3631 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3632 slightly wrong anyway, as it missed one instance of
3633 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3634 (refill_memory_reserve): Omit needless cast to size_t.
3635 (mark_object_loop_halt): Mark as externally visible.
3636
ac82cc6a
PE
3637 * xselect.c: Integer signedness and overflow fixes.
3638 (Fx_register_dnd_atom, x_handle_dnd_message):
3639 Use ptrdiff_t, not size_t, since we prefer signed.
3640 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3641 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3642 x_dnd_atoms_size and x_dnd_atoms_length.
3643
c2d1e36d
PE
3644 * doprnt.c: Prefer signed to unsigned when either works.
3645 * eval.c (verror):
3646 * doprnt.c (doprnt):
3647 * lisp.h (doprnt):
3648 * xdisp.c (vmessage):
3649 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3650 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3651 prefer signed arithmetic to avoid comparison confusion.
3652 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3653 but is a bit tricky.
3654
0e926e56
PE
3655 Assume freestanding C89 headers, string.h, stdlib.h.
3656 * data.c, doprnt.c, floatfns.c, print.c:
3657 Include float.h unconditionally.
3658 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3659 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3660 * regex.c: Likewise for stddef.h, string.h.
3661 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3662 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3663 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3664 (STDC_HEADERS): Remove obsolete defines.
3665 * sysdep.c: Include limits.h unconditionally.
3666
9cfdb3ec
PE
3667 Assume support for memcmp, memcpy, memmove, memset.
3668 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3669 * regex.c (memcmp, memcpy):
3670 Remove; we assume C89 now.
3671
3672 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3673 (__malloc_safe_bcopy): Remove; no longer needed.
3674
cf950e6b 3675 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3676 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3677 well either way, and we prefer signed to unsigned.
3678
dbf38e02
LMI
36792011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3680
3681 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3682 closes the connection while we're reading (bug#9182).
3683
d6f0886c 36842011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3685
d6f0886c
JD
3686 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3687 are specified (Bug#9168).
24e0f6b1 3688
2eb1f9e6
PE
36892011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3692 Found by GCC static checking and --with-wide-int on a 32-bit host.
3693
22381272 36942011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3695
3696 * xdisp.c (compute_display_string_pos): Fix logic of caching
3697 previous display string position. Initialize cached_prev_pos to
3698 -1. Fixes slow-down at the beginning of a buffer.
3699
f25e39b4
EZ
37002011-07-24 Eli Zaretskii <eliz@gnu.org>
3701
3702 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3703 for attrs[LFACE_FONTSET_INDEX].
3704
04c4b52e
PE
37052011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * xml.c (parse_region): Remove unused local
3708 that was recently introduced.
3709
c1734fbd
EZ
37102011-07-23 Eli Zaretskii <eliz@gnu.org>
3711
be18c5a5
EZ
3712 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3713 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3714
c1734fbd
EZ
3715 * xdisp.c (move_it_in_display_line_to): Record the best matching
3716 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3717 exit if none of the characters scanned was an exact match.
3718 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3719 when exact match is impossible due to invisible text, and the
3720 lines are truncated.
3721
a258d627
JD
37222011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3723
3724 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3725 for OSX >= 10.7.
3726
b6d5a689
EZ
37272011-07-22 Eli Zaretskii <eliz@gnu.org>
3728
0f74f785
EZ
3729 Fix a significant slow-down of cursor motion with C-n, C-p,
3730 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3731 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3732 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3733 (next_element_from_buffer): Call compute_stop_pos_backwards to
3734 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3735 base_level_stop.
3736 (reseat): Don't look for prev_stop, as that could mean a very long
3737 run.
3738 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3739 <cached_disp_overlay_modiff>: Cache for last found display string
3740 position.
551918c1 3741 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3742 about the same buffer in the same area of character positions, and
3743 the buffer wasn't changed since the time the display string
3744 position was cached.
551918c1 3745
b2d0c91a
EZ
37462011-07-22 Eli Zaretskii <eliz@gnu.org>
3747
3748 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3749 is an integer, which is important for empty lines. (Bug#9149)
3750
043604ee
CY
37512011-07-22 Chong Yidong <cyd@stupidchicken.com>
3752
3753 * frame.c (Fmodify_frame_parameters): In tty case, update the
3754 default face if necessary (Bug#4238).
3755
da4adb04
CY
37562011-07-21 Chong Yidong <cyd@stupidchicken.com>
3757
3758 * editfns.c (Fstring_to_char): No need to explain what a character
3759 is in the docstring (Bug#6576).
3760
9abd0532
LMI
37612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3762
3763 * xml.c (parse_region): Make sure we always return a tree.
3764
36881d16
HK
37652011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3766
3767 * xml.c (parse_region): If a document contains only comments,
3768 return that, too.
3769
1e98674d
LMI
37702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3771
3772 * xml.c (make_dom): Return comments, too.
3773
590bd467
PE
37742011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3775
3776 Port to OpenBSD.
3777 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3778 and the surrounding thread.
3779 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3780 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3781 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3782 timer goes off.
3783 * s/openbsd.h (BROKEN_SIGIO): Define.
3784 * unexelf.c (unexec) [__OpenBSD__]:
3785 Don't update the .mdebug section of the Alpha COFF symbol table.
3786
f41628b2
LMI
37872011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3788
3789 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3790 (bug#8460).
3791
b59b67c5
PE
37922011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3793
15e3a074
PE
3794 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3795 This fixes some race conditions on the permissions of any newly
3796 created file.
3797
41bed37d
PE
3798 * alloc.c (valid_pointer_p): Use pipe, not open.
3799 This fixes some permissions issues when debugging.
3800
b59b67c5
PE
3801 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3802 If fchown fails to set both uid and gid, try to set just gid,
3803 as that is sometimes allowed. Adjust the file's mode to eliminate
3804 setuid or setgid bits that are inappropriate if fchown fails.
3805
925a6be7
SM
38062011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3807
3808 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3809 to compare Lisp_Objects.
3810 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3811 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3812 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3813
52968808
AS
38142011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3815
0a6a104b
AS
3816 * lread.c (read_integer): Unread even EOF character.
3817 (read1): Likewise. Properly record start position of symbol.
3818
52968808
AS
3819 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3820 symbol character follows.
3821
9e381cdd
PE
38222011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3825 This works around a problem with the previous change to Fcopy_file.
3826 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3827 and without this change, GCC might complain about discarding
3828 fchown's return value.
3829
b5641435
JB
38302011-07-16 Juanma Barranquero <lekktu@gmail.com>
3831
3832 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3833
a8031457
PE
38342011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3837
dd889327
LMI
38382011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3839
750c33f7
LMI
3840 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3841 it's used from the C level.
3842
dd889327
LMI
3843 * process.c: Use the same condition for POLL_FOR_INPUT in both
3844 keyboard.c and process.c (bug#1858).
3845
87e86684
LM
38462011-07-09 Lawrence Mitchell <wence@gmx.li>
3847
3848 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3849 (Fgnutls_boot): Use it.
3850
64348f40
AS
38512011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3852
3853 * doc.c (Fsubstitute_command_keys): Revert last change.
3854
1d698799
LMI
38552011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3856
f863868c
LMI
3857 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3858 quotes the next character, and doesn't affect other longer
3859 sequences (bug#8935).
3860
1d698799
LMI
3861 * lread.c (syms_of_lread): Clarify that is isn't only
3862 `eval-buffer' and `eval-defun' that's affected by
3863 `lexical-binding' (bug#8460).
3864
aa4b6df6
EZ
38652011-07-15 Eli Zaretskii <eliz@gnu.org>
3866
3867 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3868 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3869
5d856da6
PE
38702011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3871
ad6042bb
PE
3872 Fix minor problems found by static checking.
3873 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3874 (elsz): Now a signed constant, not a size_t var. We prefer signed
3875 types to unsigned, to avoid integer comparison confusion. Without
3876 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3877 "cannot optimize loop, the loop counter may overflow", a symptom
3878 of the confusion.
f00bbb22 3879 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3880 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3881
6468f31c
LMI
38822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3883
49080b10
LMI
3884 * search.c (Fre_search_backward): Mention `case-fold-search' in
3885 all the re_search_* functions (bug#8138).
3886
6468f31c
LMI
3887 * keyboard.c (Fopen_dribble_file): Document when the file is
3888 closed (bug#8056).
3889
c965adc5
EZ
38902011-07-14 Eli Zaretskii <eliz@gnu.org>
3891
df9733bf
EZ
3892 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3893 bidi_cache_idx.
3894
0bb23927
EZ
3895 Support bidi reordering of display and overlay strings.
3896 * xdisp.c (compute_display_string_pos)
3897 (compute_display_string_end): Accept additional argument STRING.
3898 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3899 (reseat_to_string): Initialize bidi_it->string.s and
3900 bidi_it->string.schars.
3901 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3902 NULL (avoids a crash in bidi_paragraph_init).
3903 Initialize itb.string.lstring.
0bb23927
EZ
3904 (init_iterator): Call bidi_init_it only of a valid
3905 buffer position was specified. Initialize paragraph_embedding to
3906 L2R.
3907 (reseat_to_string): Initialize the bidi iterator.
3908 (display_string): If we need to ignore text properties of
3909 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3910 original value of -1 will not work with bidi.)
3911 (compute_display_string_pos): First arg is now struct
3912 `text_pos *'; all callers changed. Support display properties on
3913 Lisp strings.
3914 (compute_display_string_end): Support display properties on Lisp
3915 strings.
3916 (init_iterator, reseat_1, reseat_to_string): Initialize the
3917 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3918 when iterating on a string not from display properties).
640c8776
SM
3919 (compute_display_string_pos, compute_display_string_end):
3920 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3921 arrow keys.
3922 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3923 base_level_stop; instead, set base_level_stop to BEGV.
3924 Fixes crashes in vertical-motion.
0bb23927
EZ
3925 (next_element_from_buffer): Improve commentary for when
3926 the iterator is before prev_stop.
3927 (init_iterator): Initialize bidi_p from the default value of
3928 bidi-display-reordering, not from buffer-local value. Use the
3929 buffer-local value only if initializing for buffer iteration.
3930 (handle_invisible_prop): Support invisible properties on strings
3931 that are being bidi-reordered.
3932 (set_iterator_to_next): Support bidi reordering of C strings and
3933 Lisp strings.
3934 (next_element_from_string): Support bidi reordering of Lisp
3935 strings.
3936 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3937 (display_string): Support display of R2L glyph rows.
3938 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3939 (init_iterator): Don't initialize it->bidi_p for strings
3940 here.
3941 (reseat_to_string): Initialize it->bidi_p for strings here.
3942 (next_element_from_string, next_element_from_c_string)
3943 (next_element_from_buffer): Add xassert's for correspondence
3944 between IT's object being iterated and it->bidi_it.string
3945 structure.
3946 (face_before_or_after_it_pos): Support bidi iteration.
3947 (next_element_from_c_string): Handle the case of the first string
3948 character that is not the first one in the visual order.
3949 (get_visually_first_element): New function, refactored from common
3950 parts of next_element_from_buffer, next_element_from_string, and
3951 next_element_from_c_string.
3952 (tool_bar_lines_needed, redisplay_tool_bar)
3953 (display_menu_bar): Force left-to-right direction. Add a FIXME
3954 comment for making that be controlled by a user option.
3955 (push_it, pop_it): Save and restore the state of the
3956 bidi iterator. Save and restore the bidi_p flag.
3957 (pop_it): Iterate out of display property for string iteration as
3958 well.
3959 (iterate_out_of_display_property): Support iteration over strings.
3960 (handle_single_display_spec): Set up it->bidi_it for iteration
3961 over a display string, and call bidi_init_it.
3962 (handle_single_display_spec, next_overlay_string)
3963 (get_overlay_strings_1, push_display_prop): Set up the bidi
3964 iterator for displaying display or overlay strings.
3965 (forward_to_next_line_start): Don't use the shortcut if
3966 bidi-iterating.
3967 (back_to_previous_visible_line_start): If handle_display_prop
3968 pushed the iterator stack, restore the internal state of the bidi
3969 iterator by calling bidi_pop_it same number of times.
3970 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3971 and we are bidi-iterating, don't decrement the iterator position;
3972 instead, set the first_elt flag in the bidi iterator, to produce
3973 the same effect.
3974 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3975 (push_display_prop): xassert that we are iterating a buffer.
3976 (push_it, pop_it): Save and restore paragraph_embedding member.
3977 (handle_single_display_spec, next_overlay_string)
3978 (get_overlay_strings_1, reseat_1, reseat_to_string)
3979 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3980 correctly. Don't assume unibyte strings are not bidi-reordered.
3981 (compute_display_string_pos)
3982 (compute_display_string_end): Fix handling the case of C string.
3983 (push_it, pop_it): Save and restore from_disp_prop_p.
3984 (handle_single_display_spec, push_display_prop): Set the
3985 from_disp_prop_p flag.
3986 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3987 (pop_it): Call iterate_out_of_display_property only if we are
3988 popping after iteration over a string that came from a display
3989 property. Fix a typo in popping stretch info. Add an assertion
3990 for verifying that the iterator position is in sync with the bidi
3991 iterator.
3992 (handle_single_display_spec, get_overlay_strings_1)
3993 (push_display_prop): Fix initialization of paragraph direction for
3994 string when that of the parent object is not yet determined.
3995 (reseat_1): Call bidi_init_it to resync the bidi
3996 iterator with IT's position. (Bug#7616)
3997 (find_row_edges): If ROW->start.pos gives position
3998 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3999 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4000 Reset the from_disp_prop_p flag.
4001 (SAVE_IT, RESTORE_IT): New macros.
4002 (pos_visible_p, face_before_or_after_it_pos)
4003 (back_to_previous_visible_line_start)
4004 (move_it_in_display_line_to, move_it_in_display_line)
4005 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4006 (try_scrolling, redisplay_window, display_line): Use them when
4007 saving a temporary copy of the iterator and restoring it back.
4008 (back_to_previous_visible_line_start, reseat_1)
4009 (init_iterator): Empty the bidi cache "stack".
4010 (move_it_in_display_line_to): If iterator ended up at
4011 EOL, but we never saw any buffer positions smaller than
4012 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4013 motion in bidi-reordered lines.
4014 (move_it_in_display_line_to): Record prev_method and prev_pos
4015 immediately before the call to set_iterator_to_next. Fixes cursor
4016 motion in bidi-reordered lines with stretch glyphs and strings
4017 displayed in margins. (Bug#8133) (Bug#8867)
4018 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4019 TO_CHARPOS.
640c8776
SM
4020 (pos_visible_p): Support positions in bidi-reordered lines.
4021 Save and restore bidi cache.
0bb23927
EZ
4022
4023 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4024 (bidi_paragraph_info): Delete unused struct.
4025 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4026 (bidi_cache_start): New variable.
4027 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4028 to zero.
4029 (bidi_cache_fetch_state, bidi_cache_search)
4030 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4031 (bidi_cache_find, bidi_peek_at_next_level)
4032 (bidi_level_of_next_char, bidi_find_other_level_edge)
4033 (bidi_move_to_visually_next): Compare cache index with
4034 bidi_cache_start rather than with zero.
4035 (bidi_fetch_char): Accept new argument STRING; all callers
4036 changed. Support iteration over a string. Support strings with
4037 display properties. Support unibyte strings. Fix the type of
4038 `len' according to what STRING_CHAR_AND_LENGTH expects.
4039 (bidi_paragraph_init, bidi_resolve_explicit_1)
4040 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4041 (bidi_level_of_next_char, bidi_move_to_visually_next):
4042 Support iteration over a string.
0bb23927
EZ
4043 (bidi_set_sor_type, bidi_resolve_explicit_1)
4044 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4045 can now be zero (for strings); special values 0 and -1 were
4046 changed to -1 and -2, respectively.
4047 (bidi_char_at_pos): New function.
4048 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4049 Call it instead of FETCH_MULTIBYTE_CHAR.
4050 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4051 initialized to valid values.
4052 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4053 values.
4054 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4055 the test for valid cached positions. Fix the logic for looking up
4056 the sentinel state in the cache. GCPRO the Lisp string we are
4057 iterating.
4058 (bidi_push_it, bidi_pop_it): New functions.
4059 (bidi_initialize): Initialize the bidi cache start stack pointer.
4060 (bidi_cache_ensure_space): New function, refactored from part of
4061 bidi_cache_iterator_state. Don't assume the required size is just
4062 one BIDI_CACHE_CHUNK away.
4063 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4064 (bidi_count_bytes, bidi_char_at_pos): New functions.
4065 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4066 always valid if bidi_cache_idx is valid.
4067 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4068 is valid if it's going to be used.
4069 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4070 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4071 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4072 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4073 (bidi_find_other_level_edge, bidi_cache_start_stack):
4074 All variables related to cache indices are now EMACS_INT.
c965adc5 4075
0bb23927
EZ
4076 * dispextern.h (struct bidi_string_data): New structure.
4077 (struct bidi_it): New member `string'. Make flag members be 1-bit
4078 fields, and put them last in the struct.
640c8776
SM
4079 (compute_display_string_pos, compute_display_string_end):
4080 Update prototypes.
0bb23927
EZ
4081 (bidi_push_it, bidi_pop_it): Add prototypes.
4082 (struct iterator_stack_entry): New members bidi_p,
4083 paragraph_embedding, and from_disp_prop_p.
4084 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4085 (bidi_shelve_cache, bidi_unshelve_cache):
4086 Declare prototypes.
0bb23927
EZ
4087
4088 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4089 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4090 and vector-like objects.
4091
4092 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4093 cache around display iteration.
4094
4095 * window.c (Fwindow_end, window_scroll_pixel_based)
4096 (displayed_window_lines, Frecenter): Save and restore the bidi
4097 cache around display iteration.
4098
3bbd2265
LMI
40992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4100
4101 * editfns.c (Fdelete_region): Clarify the use of the named
4102 parameters (bug#6788).
4103
adc47434
MR
41042011-07-14 Martin Rudalics <rudalics@gmx.at>
4105
4106 * indent.c (Fvertical_motion): Set and restore w->pointm when
4107 saving and restoring the window's buffer (Bug#9006).
4108
837c31f8
LMI
41092011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4110
4111 * editfns.c (Fstring_to_char): Clarify just what is returned
4112 (bug#6576). Text by Eli Zaretskii.
4113
ac389d0c
JB
41142011-07-13 Juanma Barranquero <lekktu@gmail.com>
4115
4116 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4117
0be0ce47
EZ
41182011-07-13 Eli Zaretskii <eliz@gnu.org>
4119
4120 * buffer.c (mmap_find): Fix a typo.
4121
cd18e7e3
JB
41222011-07-13 Johan Bockgård <bojohan@gnu.org>
4123
4124 Fix execution of x selection hooks.
4125 * xselect.c (Qx_lost_selection_functions)
4126 (Qx_sent_selection_functions): New vars.
4127 (syms_of_xselect): DEFSYM them.
4128 (x_handle_selection_request): Pass Qx_sent_selection_functions
4129 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4130 (x_handle_selection_clear,x_clear_frame_selections):
4131 Pass Qx_lost_selection_functions rather than
4132 Vx_lost_selection_functions to Frun_hook_with_args.
4133
47ea7f44
PE
41342011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4135
ac389d0c 4136 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4137 The old code sometimes used this field without initializing it.
4138
47ea7f44
PE
4139 * alloc.c (gc_sweep): Don't read past end of array.
4140 In theory, the old code could also have corrupted Emacs internals,
4141 though it'd be very unlikely.
4142
bc985c87
AS
41432011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4144
4145 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4146 argument. (Bug#4026)
bc985c87 4147
0cf34688
LMI
41482011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4149
b3dadd76
LMI
4150 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4151 key" (bug#4257).
4152
0cf34688
LMI
4153 * window.c (Fset_window_start): Doc fix (bug#4199).
4154 (Fset_window_hscroll): Ditto.
4155
270768cd
PE
41562011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4157
077e3dda 4158 Fix minor new problems caught by GCC 4.6.1.
270768cd 4159 * term.c (init_tty): Remove unused local.
490011a6 4160 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4161 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4162 not used otherwise.
270768cd 4163
b1f58454
CY
41642011-07-12 Chong Yidong <cyd@stupidchicken.com>
4165
4166 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4167
22b9578d
LMI
41682011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4169
6e70ab07
LMI
4170 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4171 are the mini-buffer and the echo area (bug#3320).
4172
22b9578d
LMI
4173 * term.c (init_tty): Remove support for supdup, c10 and perq
4174 terminals, which are no longer supported (bug#1482).
4175
8974cc9f
JB
41762011-07-10 Johan Bockgård <bojohan@gnu.org>
4177
4178 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4179
a560d974
JD
41802011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4181
4182 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4183 for non-popups (Bug#3642).
4184
1dae0f0a
AS
41852011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4186
268c2c36 4187 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4188 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4189 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4190 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4191 * data.c (fmod): Likewise.
4192 * dispnew.c (swap_glyphs_in_rows): Likewise.
4193 * emacs.c (memory_warning_signal): Likewise.
4194 * floatfns.c (float_error): Likewise.
4195 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4196 (otf_open, font_otf_capability, generate_otf_features)
4197 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4198 Likewise.
4199 * image.c (pbm_read_file): Likewise.
4200 * indent.c (string_display_width): Likewise.
4201 * intervals.c (check_for_interval, search_for_interval)
4202 (inc_interval_count, count_intervals, root_interval)
4203 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4204 * lread.c (defalias): Likewise.
268c2c36 4205 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4206 * regex.c (set_image_of_range_1, set_image_of_range)
4207 (regex_grow_registers): Likewise.
4208 * sysdep.c (strerror): Likewise.
4209 * termcap.c (valid_filename_p, tprint, main): Likewise.
4210 * tparam.c (main): Likewise.
4211 * unexhp9k800.c (run_time_remap, save_data_space)
4212 (update_file_ptrs, read_header, write_header, calculate_checksum)
4213 (copy_file, copy_rest, display_header): Likewise.
4214 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4215 Likewise.
4216 * xdisp.c (check_it): Likewise.
4217 * xfaces.c (register_color, unregister_color, unregister_colors):
4218 Likewise.
4219 * xfns.c (print_fontset_result): Likewise.
4220 * xrdb.c (member, fatal, main): Likewise.
4221
99033785
PE
42222011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4223
4224 Fix minor problems found by static checking (Bug#9031).
4225 * chartab.c (char_table_set_range, map_sub_char_table):
4226 Remove unused locals.
4227 (uniprop_table): Now static.
4228 * composite.c (_work_char): Remove unused static var.
4229
9cb2ac56
JB
42302011-07-09 Juanma Barranquero <lekktu@gmail.com>
4231
4232 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4233
f25661f0
JD
42342011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4235
4236 * gtkutil.c (qttip_cb): Remove code without function.
4237
8278c4fe
EZ
42382011-07-09 Eli Zaretskii <eliz@gnu.org>
4239
4240 * w32.c (pthread_sigmask): New stub.
4241
1692ae2d 42422011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4243
8a6ebd58 4244 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4245 sigprocmask is portable only for single-threaded applications, and
4246 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4247 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4248 (LIBES): Use it.
4249 * callproc.c (Fcall_process):
4250 * process.c (create_process):
4251 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4252 Use pthread_sigmask, not sigprocmask.
123403e4 4253
1b854618
JD
42542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4255
4256 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4257 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4258 wrong (Bug#8591).
4259
3fe4b549
JD
42602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4261
0ce7e563
JD
4262 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4263 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4264 (xg_hide_tooltip): Fix comment.
4265
3fe4b549
JD
4266 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4267 in registerServicesMenuSendTypes.
4268 (validRequestorForSendType): Don't check ns_return_types.
4269
4270 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4271 ns_return_type.
4272
5df75e47
JR
42732011-07-08 Jason Rumney <jasonr@gnu.org>
4274
22610910
JR
4275 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4276 SH_SHOW for hidden windows (Bug#5482).
4277
5df75e47
JR
4278 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4279 frame struct members of non-existent frames (Bug#6284).
4280
699c10bd
JD
42812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4282
4393663b
JD
4283 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4284 variable firstTime not needed on OSX >= 10.6.
4285 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4286 >= 10.5. Use setKnobProportion, setDoubleValue.
4287
4288 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4289 (MAC_OS_X_VERSION_10_5): Define if not defined.
4290 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4291 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4292 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4293
4294 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4295 cString and lossyCString on OSX >= 10.4
4296
58179cce 4297 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4298 sizeToFit on OSX >= 10.2.
4299
4300 * nsimage.m (allocInitFromFile): Don't use deprecated method
4301 bestRepresentationForDevice on OSX >= 10.6.
4302
4303 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4304 to avoid warning.
4305
4306 * emacs.c: Declare unexec_init_emacs_zone.
4307
a63e0781
JD
4308 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4309
699c10bd
JD
4310 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4311
4312 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4313 on svcsMenu (Bug#8842).
4314
4315 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4316 ns_return_types.
4317 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4318
4319 * nsterm.m (QUTF8_STRING): Declare.
4320 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4321 (validRequestorForSendType): Return type is (id).
4322 Change indexOfObjectIdenticalTo to indexOfObject.
4323 Check if we have local selection before returning self (Bug#8842).
4324 (writeSelectionToPasteboard): Put local selection into paste board
4325 if we have a local selection (Bug#8842).
4326 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4327
4328 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4329 (ns_get_local_selection): Declare.
4330
54e10184
LMI
43312011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4332
9888ff71
LMI
4333 * keymap.c (describe_map_tree): Don't insert a double newline at
4334 the end of the buffer (bug#1169) and return whether we inserted
4335 something.
4336
54e10184
LMI
4337 * callint.c (Fcall_interactively): Change "reading args" to
4338 "providing args" to try to clarify what it does (bug#1010).
4339
15fa4783
KH
43402011-07-07 Kenichi Handa <handa@m17n.org>
4341
4342 * composite.c (composition_compute_stop_pos): Ignore a static
4343 composition starting before CHARPOS (Bug#8915).
4344
4345 * xdisp.c (handle_composition_prop): Likewise.
4346
a8815b00
EZ
43472011-07-07 Eli Zaretskii <eliz@gnu.org>
4348
4349 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4350 (Bug#9015)
4351
ef7b981d 43522011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4353
4354 * character.h (unicode_category_t): New enum type.
4355
4356 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4357 (Qchar_code_property_table): New variable.
4358 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4359 (UNIPROP_COMPRESSED_FORM_P): New macros.
4360 (char_table_ascii): Uncompress the compressed values.
4361 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4362 Uncompress the compressed values.
ac389d0c 4363 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4364 (char_table_ref_and_range): Uncompress the compressed values.
4365 (sub_char_table_set): New arg is_uniprop. Callers changed.
4366 Uncompress the compressed values.
4367 (sub_char_table_set_range): Args changed. Callers changed.
4368 (char_table_set_range): Adjuted for the above change.
4369 (map_sub_char_table): Delete args default_val and parent. Add arg
4370 top. Give decoded values to a Lisp function.
640c8776 4371 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4372 values to a Lisp function. Gcpro more variables.
4373 (uniprop_table_uncompress)
4374 (uniprop_decode_value_run_length): New functions.
4375 (uniprop_decoder, uniprop_decoder_count): New variables.
4376 (uniprop_get_decoder, uniprop_encode_value_character)
4377 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4378 New functions.
4379 (uniprop_encoder, uniprop_encoder_count): New variables.
4380 (uniprop_get_encoder, uniprop_table)
4381 (Funicode_property_table_internal, Fget_unicode_property_internal)
4382 (Fput_unicode_property_internal): New functions.
4383 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4384 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4385 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4386 char-code-property-alist.
4387
640c8776 4388 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4389 Vunicode_category_table.
4390
640c8776 4391 * font.c (font_range): Adjust for the change of
c805dec0
KH
4392 Vunicode_category_table.
4393
76b397fb
DN
43942011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4395
4396 * m/iris4d.h: Remove file, move contents ...
4397 * s/irix6-5.h: ... here.
4398
22b4128e
PE
43992011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4400
4401 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4402 * alloc.c (mark_buffer):
4403 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4404 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4405 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4406 This isn't true in general, and it's particularly not true
4407 if Emacs is configured with --with-wide-int.
4408 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4409 New macros, used in the buffer.c change.
4410
869795d6
JD
44112011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4412
4413 * xsettings.c: Use both GConf and GSettings if both are available.
4414 (store_config_changed_event): Add comment.
4415 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4416 (store_tool_bar_style_changed): New functions.
5e617bc2 4417 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4418 (struct xsettings): Move font inside HAVE_XFT.
4419 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4420 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4421 Move inside HAVE_XFT.
640c8776 4422 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4423 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4424 also.
4425 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4426 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4427 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4428 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4429 (parse_settings): Move check for font inside HAVE_XFT.
4430 (read_settings, apply_xft_settings): Add comment.
4431 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4432 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4433 call store_font_name_changed.
4434 (xft_settings_event): Add comment.
4435 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4436 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4437 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4438 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4439 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4440 (xsettings_get_system_font, xsettings_get_system_normal_font):
4441 Add comment.
869795d6 4442
d8ed26bd
PE
44432011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4444
4445 Random fixes. E.g., (random) never returned negative values.
4446 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4447 subseconds part to the entropy, as that's a bit more random.
4448 Prefer signed to unsigned, since the signedness doesn't matter and
4449 in general we prefer signed. When given a limit, use a
4450 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4451 latter isn't right if USE_2_TAGS_FOR_INTS.
4452 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4453 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4454
cabf1cac
SM
44552011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4456
4457 * textprop.c (text_property_stickiness):
4458 Obey Vtext_property_default_nonsticky.
4459 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4460 * w32fns.c (syms_of_w32fns):
4461 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4462
6e9b2be9
PE
44632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4466 This is more efficient than Ffile_directory_p and avoids a minor race.
4467
90186c68
LMI
44682011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4469
7c301272
LMI
4470 * buffer.c (Foverlay_put): Say what the return value is
4471 (bug#7835).
4472
c4f2d8d4
LMI
4473 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4474 is a directory before asking whether to use the file name
4475 (bug#7564).
ad637907
LMI
4476 (barf_or_query_if_file_exists): Make the "File is a directory"
4477 error be more correct.
c4f2d8d4 4478
90186c68
LMI
4479 * fns.c (Frequire): Remove the mention of the .gz files, since
4480 that's installation-specific, but keep the mention of
4481 `get-load-suffixes'.
4482
da64016e
PE
44832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4484
4485 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4486 Report string overflow if the output is too long.
4487
7d47b580
JB
44882011-07-04 Juanma Barranquero <lekktu@gmail.com>
4489
a555cb87
JB
4490 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4491 (syms_of_gnutls): Remove duplicate DEFSYM for
4492 Qgnutls_bootprop_verify_hostname_error, an error for
4493 Qgnutls_bootprop_verify_error (which is no longer used).
4494
7d47b580
JB
4495 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4496 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4497 Also (re)move comments that are misplaced or no longer relevant.
4498
1e49bfab
LMI
44992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4500
4501 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4502
1485f4c0
CY
45032011-07-03 Chong Yidong <cyd@stupidchicken.com>
4504
4505 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4506 and background color parameters if they have been changed.
4507
a9ab721e
LMI
45082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4509
4510 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4511
cf7cff57
PE
45122011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4513
2e13213d
PE
4514 * xsettings.c (SYSTEM_FONT): Define only when used.
4515 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4516
cf7cff57
PE
4517 * keymap.c (access_keymap_1): Now static.
4518
7a8e04f7
CY
45192011-07-02 Chong Yidong <cyd@stupidchicken.com>
4520
4521 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4522 leave any prefix arg for the up event (Bug#1586).
4523
61352f62
LMI
45242011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4525
69bb1ef7
LMI
4526 * lread.c (syms_of_lread): Mention single symbols defined by
4527 `defvar' or `defconst' (bug#7154).
4528
61352f62 4529 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4530 (Frequire): Mention get-load-suffixes.
61352f62 4531
28545e04
MR
45322011-07-02 Martin Rudalics <rudalics@gmx.at>
4533
4534 * window.h (window): Remove clone_number slot.
4535 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4536 Remove.
4537 (make_parent_window, make_window, saved_window)
4538 (Fset_window_configuration, save_window_save): Don't deal with
4539 clone numbers.
4540 * buffer.c (Qclone_number): Remove declaration.
4541 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4542
3349e122
SM
45432011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4544
4545 Add multiple inheritance to keymaps.
4546 * keymap.c (Fmake_composed_keymap): New function.
4547 (Fset_keymap_parent): Simplify.
4548 (fix_submap_inheritance): Remove.
4549 (access_keymap_1): New function extracted from access_keymap to handle
4550 embedded parents and handle lists of maps.
4551 (access_keymap): Use it.
4552 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4553 (Fcopy_keymap): Handle embedded parents.
4554 (Fcommand_remapping, define_as_prefix): Simplify.
4555 (Fkey_binding): Simplify.
4556 (syms_of_keymap): Move minibuffer-local-completion-map,
4557 minibuffer-local-filename-completion-map,
4558 minibuffer-local-must-match-map, and
4559 minibuffer-local-filename-must-match-map to Elisp.
4560 (syms_of_keymap): Defsubr make-composed-keymap.
4561 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4562 (parse_menu_item): Trivial simplification.
4563
3279eb87
GM
45642011-07-01 Glenn Morris <rgm@gnu.org>
4565
4566 * Makefile.in (SETTINGS_LIBS): Fix typo.
4567
4550efdf
KI
45682011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4569
4570 * coding.c (Fencode_coding_string): Record the last coding system
4571 used, as the function doc string says (bug#8738).
4572
0949d2b6
JD
45732011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4574
4575 * xsettings.c (store_monospaced_changed): Take new font as arg and
4576 check for change against current_mono_font.
4577 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4578 (emacs_settings_constructor, emacs_settings_get_property)
4579 (emacs_settings_set_property, emacs_settings_class_init)
4580 (emacs_settings_init, gsettings_obj): Remove.
4581 (something_changedCB): New function for HAVE_GSETTINGS.
4582 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4583 with value as argument.
4584 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4585 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4586 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4587 "changed".
4588
4589 * xgselect.c: Add defined (HAVE_GSETTINGS).
4590 (xgselect_initialize): Ditto.
4591
4592 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4593 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4594 xg_select.
4595
bbc6b304
PE
45962011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4597
4598 * eval.c (struct backtrace): Simplify and port the data structure.
4599 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4600 signed bit field, as this assumption is not portable and it makes
4601 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4602 "char debug_on_exit : 1" as this is not portable either; instead,
4603 use the portable "unsigned int debug_on_exit : 1". Remove unused
4604 member evalargs. Remove obsolete comments about cc bombing out.
4605
9851bfc5
JD
46062011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4607
51bb811f 4608 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4609 Let HAVE_GSETTINGS override HAVE_GCONF.
4610 (store_monospaced_changed): New function.
4611 (EMACS_SETTINGS): A new type derived from GObject to handle
4612 GSettings notifications.
4613 (emacs_settings_constructor, emacs_settings_get_property)
4614 (emacs_settings_set_property, emacs_settings_class_init):
4615 New functions.
4616 (gsettings_client, gsettings_obj): New variables.
4617 (GSETTINGS_SCHEMA): New define.
4618 (something_changedCB): Call store_monospaced_changed.
4619 (init_gsettings): New function.
4620 (xsettings_initialize): Call init_gsettings.
4621 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4622 to NULL.
4623
640c8776 4624 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4625 GCONF_CFLAGS/LIBS.
4626
5386012d
MR
46272011-06-29 Martin Rudalics <rudalics@gmx.at>
4628
4629 * window.c (resize_root_window, grow_mini_window)
4630 (shrink_mini_window): Rename Qresize_root_window to
4631 Qwindow_resize_root_window and Qresize_root_window_vertically to
4632 Qwindow_resize_root_window_vertically.
4633
f13e0b08
PE
46342011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4635
4636 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4637
94515237
JB
46382011-06-27 Juanma Barranquero <lekktu@gmail.com>
4639
4640 * makefile.w32-in: Redesign dependencies so they reflect more
4641 clearly which files are directly included by each source file,
4642 and not through other includes.
4643
e43b6e43
MR
46442011-06-27 Martin Rudalics <rudalics@gmx.at>
4645
4646 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4647 (sort_overlays, overlay_strings): When an overlay's clone number
4648 matches the window's clone number process the overlay even if
4649 the overlay's window property doesn't match the current window.
4650
d68443dc
MR
4651 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4652 (Fwindow_hchild): Rename to Fwindow_left_child.
4653 (Fwindow_next): Rename to Fwindow_next_sibling.
4654 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4655 (resize_window_check): Rename to window_resize_check.
4656 (resize_window_apply): Rename to window_resize_apply.
4657 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4658 (Fdelete_other_windows_internal, resize_frame_windows)
4659 (Fsplit_window_internal, Fdelete_window_internal)
4660 (grow_mini_window, shrink_mini_window)
4661 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4662
c7e73be5
JD
46632011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4664
4665 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4666 (emacs_fixed_set_min_size): Remove.
4667 (emacs_fixed_new): Take frame as argument.
4668
4669 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4670 (_EmacsFixedPrivate): Remove minwidth/height.
4671 Add struct frame *f.
4672 (emacs_fixed_init): Initialize priv->f.
4673 (get_parent_class, emacs_fixed_set_min_size): Remove.
4674 (emacs_fixed_new): Set priv->f to argument.
4675 (emacs_fixed_get_preferred_width)
4676 (emacs_fixed_get_preferred_height): Use min_width/height from
4677 frames size_hint to set minimum and natural (Bug#8919).
4678 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4679 and use min_width/height from frames size_hint to set
4680 min_width/height (Bug#8919).
4681
4682 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4683 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4684 Fix indentation.
c7e73be5 4685
cf99dcf8
EZ
46862011-06-26 Eli Zaretskii <eliz@gnu.org>
4687
4688 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4689 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4690 called at ZV.
4691
029529ac
CY
46922011-06-26 Chong Yidong <cyd@stupidchicken.com>
4693
4694 * process.c (wait_reading_process_output): Bypass select if
4695 waiting for a cell while ignoring keyboard input, and input is
4696 pending. Suggested by Jan Djärv (Bug#8869).
4697
7a7ef429
PE
46982011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4699
4700 Use gnulib's dup2 module instead of rolling our own.
4701 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4702
11fdef7d 47032011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4704
4705 * dispnew.c (scrolling_window): Before scrolling, turn off a
4706 mouse-highlight in the window being scrolled.
4707
cd3520a4
JB
47082011-06-24 Juanma Barranquero <lekktu@gmail.com>
4709
4710 Move DEFSYM to lisp.h and use everywhere.
4711
4712 * character.h (DEFSYM): Move declaration...
4713 * lisp.h (DEFSYM): ...here.
4714
4715 * gnutls.c:
4716 * minibuf.c:
4717 * w32menu.c:
4718 * w32proc.c:
4719 * w32select.c: Don't include character.h.
4720
4721 * alloc.c (syms_of_alloc):
4722 * buffer.c (syms_of_buffer):
4723 * bytecode.c (syms_of_bytecode):
4724 * callint.c (syms_of_callint):
4725 * casefiddle.c (syms_of_casefiddle):
4726 * casetab.c (init_casetab_once):
4727 * category.c (init_category_once, syms_of_category):
4728 * ccl.c (syms_of_ccl):
4729 * cmds.c (syms_of_cmds):
4730 * composite.c (syms_of_composite):
4731 * dbusbind.c (syms_of_dbusbind):
4732 * dired.c (syms_of_dired):
4733 * dispnew.c (syms_of_display):
4734 * doc.c (syms_of_doc):
4735 * editfns.c (syms_of_editfns):
4736 * emacs.c (syms_of_emacs):
4737 * eval.c (syms_of_eval):
4738 * fileio.c (syms_of_fileio):
4739 * fns.c (syms_of_fns):
4740 * frame.c (syms_of_frame):
4741 * fringe.c (syms_of_fringe):
4742 * insdel.c (syms_of_insdel):
4743 * keymap.c (syms_of_keymap):
4744 * lread.c (init_obarray, syms_of_lread):
4745 * macros.c (syms_of_macros):
4746 * msdos.c (syms_of_msdos):
4747 * print.c (syms_of_print):
4748 * process.c (syms_of_process):
4749 * search.c (syms_of_search):
4750 * sound.c (syms_of_sound):
4751 * syntax.c (init_syntax_once, syms_of_syntax):
4752 * terminal.c (syms_of_terminal):
4753 * textprop.c (syms_of_textprop):
4754 * undo.c (syms_of_undo):
4755 * w32.c (globals_of_w32):
4756 * window.c (syms_of_window):
4757 * xdisp.c (syms_of_xdisp):
4758 * xfaces.c (syms_of_xfaces):
4759 * xfns.c (syms_of_xfns):
4760 * xmenu.c (syms_of_xmenu):
4761 * xsettings.c (syms_of_xsettings):
4762 * xterm.c (syms_of_xterm): Use DEFSYM.
4763
4228cf16
TZ
47642011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4765
cd3520a4 4766 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4767
7fcccf1e
PE
47682011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4769
7efb4e0e
PE
4770 Integer and buffer overflow fixes (Bug#8873).
4771
ff5844ad
PE
4772 * print.c (printchar, strout): Check for string overflow.
4773 (PRINTPREPARE, printchar, strout):
4774 Don't set size unless allocation succeeds.
4775
90532f02
PE
4776 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4777 for sizes. Check for string overflow more accurately.
4778 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4779
6d84508d
PE
4780 * macros.c: Integer and buffer overflow fixes.
4781 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4782 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4783 Use ptrdiff_t, not int, for sizes.
4784 Don't increment bufsize until after realloc succeeds.
4785 Check for size-calculation overflow.
4786 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4787
437b2cb4
PE
4788 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4789
8b9ac8b4
PE
4790 * lread.c: Integer overflow fixes.
4791 (read_integer): Radix is now EMACS_INT, not int,
4792 to improve quality of diagnostics for out-of-range radices.
4793 Calculate buffer size correctly for out-of-range radices.
4794 (read1): Check for integer overflow in radices, and in
4795 read-circle numbers.
82cb60d3
PE
4796 (read_escape): Avoid int overflow.
4797 (Fload, openp, read_buffer_size, read1)
4798 (substitute_object_recurse, read_vector, read_list, map_obarray):
4799 Use ptrdiff_t, not int, for sizes.
4800 (read1): Use EMACS_INT, not int, for sizes.
20270765 4801 Check for size overflow.
8b9ac8b4 4802
7fcccf1e
PE
4803 * image.c (cache_image): Check for size arithmetic overflow.
4804
bfbbd7e7
PE
4805 * lread.c: Integer overflow issues.
4806 (saved_doc_string_size, saved_doc_string_length)
4807 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4808 Now ptrdiff_t, not int.
4809 (read1): Don't assume doc string length fits in int. Check for
4810 out-of-range doc string lengths.
4811 (read_list): Don't assume file position fits in int.
39019e54 4812 (read_escape): Check for hex character overflow.
bfbbd7e7 4813
4e323265
LL
48142011-06-22 Leo Liu <sdl.web@gmail.com>
4815
4816 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4817 Move to minibuffer.el.
4818
85fece3e
PE
48192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4820
20b84ce9 4821 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4822 The following patches are for when GLYPH_DEBUG && !XASSERT.
4823 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4824 * dispnew.c (flush_stdout):
4825 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4826 Mark as externally visible.
4827 * dispnew.c (check_window_matrix_pointers): Now static.
4828 * dispnew.c (window_to_frame_vpos):
4829 * xfns.c (unwind_create_frame):
4830 * xterm.c (x_check_font): Remove unused local.
4831 * scroll.c (CHECK_BOUNDS):
4832 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4833 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4834 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4835 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4836 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4837 Now static.
4838 (debug_method_add): Use va_list and vsprintf rather than relying
4839 on undefined behavior with wrong number of arguments.
4840 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4841 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4842 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4843 since we're not interested in debugging glyphs with old libraries.
4844 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4845 GCC 4.6.0's static checking.
4846
0766b489
PE
48472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4848
31fd4b32
PE
4849 Integer overflow and signedness fixes (Bug#8873).
4850 A few related buffer overrun fixes, too.
4851
b79e8648
PE
4852 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4853
0766b489
PE
4854 * dispextern.h (struct face.stipple):
4855 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4856 (x_bitmap_mask, x_allocate_bitmap_record)
4857 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4858 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4859 (x_create_bitmap_from_xpm_data):
4860 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4861 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4862 (.bitmaps_last):
4863 * xfaces.c (load_pixmap):
4864 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4865 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4866 (.bitmaps_last, struct x_output.icon_bitmap):
4867 Use ptrdiff_t, not int, for bitmap indexes.
4868 (x_allocate_bitmap_record): Check for size overflow.
4869 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4870
b081724f
PE
4871 Use ptrdiff_t, not int, for overlay counts.
4872 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4873 * editfns.c (overlays_around, get_pos_property):
4874 * textprop.c (get_char_property_and_overlay):
4875 * xdisp.c (next_overlay_change, note_mouse_highlight):
4876 * xfaces.c (face_at_buffer_position):
21514da7
PE
4877 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4878 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4879 (Fnext_overlay_change, Fprevious_overlay_change)
4880 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4881 Use ptrdiff_t, not int, for sizes.
21514da7 4882 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4883
3de73e5e
PE
4884 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4885
2606c57b
PE
4886 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4887 (x_session_initialize): Do not assume string length fits in int.
4888
aaafe47a
PE
4889 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4890 This is unlikely, but can occur if DPI is outlandish.
4891
2674ddc8 4892 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4893 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4894
28154962
PE
4895 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4896 * xrdb.c (magic_file_p, search_magic_path):
4897 Omit last arg SUFFIX; it was always 0. All callers changed.
4898 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4899
7de51af5
PE
4900 * xfont.c (xfont_match): Avoid need for strlen.
4901
25ed6cc3
PE
4902 * xfns.c: Don't assume strlen fits in int.
4903 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4904
4eab31dd
PE
4905 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4906 not unsigned long, as we prefer signed integers. All callers changed.
4907 Detect integer overflow in repeat count.
4908 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4909 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4910
171e2a58
PE
4911 * termcap.c: Don't assume sizes fit in int and never overflow.
4912 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4913 (gobble_line): Check for size-calculation overflow.
4914
ad39faca 4915 * minibuf.c (Fread_buffer):
6e5bb2dc 4916 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4917 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4918 Don't assume string length fits in int.
4919
52c61c22 4920 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4921 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4922
b5b8c9e5
PE
4923 * font.c: Don't assume string length fits in int.
4924 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4925 Use ptrdiff_t, not int.
ccd6111c
PE
4926 (font_intern_prop): Don't assume string length fits in int.
4927 Don't assume integer property fits in fixnum.
4928 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4929
882f0d81 4930 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4931 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4932 Reformulate so as not to need the command string.
4933 Invoke gzip -cd rather than gunzip, as it's more portable.
4934 (lock_info_type, lock_file_1, lock_file):
4935 Don't assume pid_t and time_t fit in unsigned long.
4936 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4937 (current_lock_owner): Prefer signed type for sizes.
4938 Use memcpy, not strncpy, where memcpy is what is really wanted.
4939 Don't assume (via atoi) that time_t and pid_t fit in int.
4940 Check for time_t and/or pid_t out of range, e.g., via a network share.
4941 Don't alloca where an auto var works fine.
4942
93f4cf88
PE
4943 * fileio.c: Fix some integer overflow issues.
4944 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4945 Don't assume string length fits in int.
4946 (directory_file_name): Don't assume string length fits in long.
4947 (make_temp_name): Don't assume pid fits in int, or that its print
4948 length is less than 20.
4949
f3e92b69
PE
4950 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4951
1bfdaf10
PE
4952 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4953
35016e9a
PE
4954 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4955
3d1e65a1
PE
4956 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4957 We prefer signed integers, even for size calculations.
4958
0b963a93
PE
4959 * emacs.c: Don't assume string length fits in 'int'.
4960 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4961 (main): Don't invoke strlen when not needed.
4962
573f4b54
PE
4963 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4964 (XD_DEBUG_MESSAGE): Don't waste a byte.
4965
989f33ba
PE
4966 * callproc.c (getenv_internal_1, getenv_internal)
4967 (Fgetenv_internal):
965d34eb
PE
4968 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4969
e4d29b33
PE
4970 * lread.c (invalid_syntax): Omit length argument.
4971 All uses changed. This doesn't fix a bug, but it simplifies the
4972 code away from its former Hollerith-constant appearance, and it's
4973 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4974 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4975
eb49b136
PE
4976 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4977 This didn't break anything, but it didn't help either.
4978 It's confusing to put a bogus integer in a place where the actual
4979 value does not matter.
9f62aeb1 4980 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4981 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4982
15375a22
PE
4983 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4984 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4985 implementation.
b61cc01c
PE
4986 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4987 We prefer signed types, and the value cannot exceed the EMACS_INT
4988 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4989 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4990 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4991 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4992
53b2623d
PE
4993 * indent.c (sane_tab_width): New function.
4994 (current_column, scan_for_column, Findent_to, position_indentation)
4995 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4996 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4997
51cab52b 4998 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4999
f2ed8a70
PE
5000 * lisp.h (lint_assume): New macro.
5001 * composite.c (composition_gstring_put_cache):
5002 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5003
abe80cc6
PE
5004 * editfns.c, insdel.c:
5005 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5006
b02c740e
PE
5007 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5008
ebc96716
PE
5009 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5010
b4e50fa0 5011 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5012 Use much-faster test for byte-length change.
311d5d7c 5013 Don't assume string byte-length fits in 'int'.
a4cf38e4 5014 Check that character arg fits in 'int'.
85461888 5015 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5016
c0c1ee9f
PE
5017 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5018
a498d7f4
PE
5019 * fns.c (concat): Catch string overflow earlier.
5020 Do not rely on integer wraparound.
5021
51cab52b
PE
5022 * dispextern.h (struct it.overlay_strings_charpos)
5023 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5024 * xdisp.c (forward_to_next_line_start)
5025 (back_to_previous_visible_line_start)
5026 (reseat_at_next_visible_line_start, next_element_from_buffer):
5027 Don't arbitrarily truncate the value of 'selective' to int.
5028
76031fad
PE
5029 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5030
5eb55db9
PE
5031 * composite.c: Don't truncate sizes to 'int'.
5032 (composition_gstring_p, composition_reseat_it)
5033 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5034 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5035 not EMACS_UINT, for indexes.
5eb55db9 5036
0703a717
PE
5037 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5038
d6202519
PE
5039 * buffer.c: Include <verify.h>.
5040 (struct sortvec.priority, struct sortstr.priority):
8961a454 5041 Now EMACS_INT, not int.
c20998a7 5042 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5043 (struct sortstr.size, record_overlay_string)
5044 (struct sortstrlist.size, struct sortlist.used):
5045 Don't truncate size to int.
5046 (record_overlay_string): Check for size-calculation overflow.
d6202519 5047 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5048
d5a19415
JM
50492011-06-22 Jim Meyering <meyering@redhat.com>
5050
029529ac 5051 Don't leak an XBM-image-sized buffer
d5a19415
JM
5052 * image.c (xbm_load): Free the image buffer after using it.
5053
a9041e6c
PE
50542011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5055
5056 Port to Sun C.
5057 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5058 that Sun C diagnosed.
5059 * fns.c (secure_hash): Fix pointer signedness issue.
5060 * intervals.c (static_offset_intervals): New function.
5061 (offset_intervals): Use it.
5062
7f3f739f
LL
50632011-06-21 Leo Liu <sdl.web@gmail.com>
5064
5065 * deps.mk (fns.o):
5066 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5067 sha512.h.
5068
5069 * fns.c (secure_hash): Rename from crypto_hash_function and change
5070 the first arg to accept symbols.
5b66d427 5071 (Fsecure_hash): New primitive.
7f3f739f
LL
5072 (syms_of_fns): New symbols.
5073
76147d94
DD
50742011-06-20 Deniz Dogan <deniz@dogan.se>
5075
5076 * process.c (Fset_process_buffer): Clarify return value in
5077 docstring.
5078
7d7d0045
CY
50792011-06-18 Chong Yidong <cyd@stupidchicken.com>
5080
5081 * dispnew.c (add_window_display_history): Use BVAR.
5082
5083 * xdisp.c (debug_method_add): Use BVAR.
5084 (check_window_end, dump_glyph_matrix, dump_glyph)
5085 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5086
5087 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5088 Likewise.
5089
5090 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5091 check till after the cache is created in init_frame_faces.
5092
ff2bc410
SM
50932011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5094
5095 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5096
28177add
PE
50972011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5098
dd3482fe
PE
5099 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5100 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5101 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5102
393d71f3 5103 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5104 * fileio.c (Finsert_file_contents):
5105 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5106 Remove the old (too-loose) buffer overflow checks.
5107 They weren't needed, since make_gap checks for buffer overflow.
5108 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5109 The old code merely checked for Emacs fixnum overflow, and relied
5110 on undefined (wraparound) behavior. The new code avoids undefined
5111 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5112
2e6813b0 5113 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5114 Tune. Don't use wider integers than needed. Don't use alloca.
5115 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5116
599a9e4f
PE
5117 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5118
99561444
PE
5119 * insdel.c, lisp.h (buffer_overflow): New function.
5120 (insert_from_buffer_1, replace_range, replace_range_2):
5121 * insdel.c (make_gap_larger):
5122 * editfns.c (Finsert_char):
5123 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5124
28177add
PE
5125 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5126
e69dafad
PE
51272011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5128
4baa020d 5129 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5130
b1c46f02
PE
5131 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5132 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5133
e69dafad
PE
5134 * fileio.c: Don't assume EMACS_INT fits in off_t.
5135 (emacs_lseek): New static function.
5136 (Finsert_file_contents, Fwrite_region): Use it.
5137 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5138
566684ea
PE
5139 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5140
e6966cd6
PE
5141 * fns.c: Don't overflow int when computing a list length.
5142 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5143 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5144 truncation on 64-bit hosts. Check for QUIT every
5145 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5146 faster and is responsive enough.
5147 (Flength): Report an error instead of overflowing an integer.
5148 (Fsafe_length): Return a float if the value is not representable
5149 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5150 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5151 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5152
dd0b0efb
PE
5153 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5154 (header_size, word_size): New constants.
5155 (allocate_vectorlike): Don't check size overflow here.
5156 (allocate_vector): Check it here instead, since this is the only
5157 caller of allocate_vectorlike that could cause overflow.
5158 Check that the new vector's length is representable as a fixnum.
5159
86fe5cfe
PE
5160 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5161 The previous code was bogus. For example, next_almost_prime (32)
5162 returned 39, which is undesirable as it is a multiple of 3; and
5163 next_almost_prime (24) returned 25, which is a multiple of 5 so
5164 why was the code bothering to check for multiples of 7?
5165
80e88859
PE
5166 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5167
4a2f0ad6
PE
5168 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5169
f66c7cf8
PE
5170 Variadic C functions now count arguments with ptrdiff_t.
5171 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5172 Back then I didn't know that the Emacs coding style prefers signed int.
5173 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5174 were being counted with int, which may truncate counts on 64-bit
5175 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5176 * lisp.h (struct Lisp_Subr.function.aMANY)
5177 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5178 Arg counts are now ptrdiff_t, not size_t.
5179 All variadic functions and their callers changed accordingly.
5180 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5181 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5182 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5183 * callint.c (Fcall_interactively): Check arg count for overflow,
5184 to avoid potential buffer overrun. Use signed char, not 'int',
5185 for 'varies' array, so that we needn't bother to check its size
5186 calculation for overflow.
5187 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5188 * eval.c (apply_lambda):
5189 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5190 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5191 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5192
a1759b76
PE
5193 * callint.c (Fcall_interactively): Don't use index var as event count.
5194
d96be9fc
PE
5195 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5196 * mem-limits.h (SIZE): Remove; no longer used.
5197
a690a978 5198 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5199
578c21e6
PE
5200 Remove unnecessary casts.
5201 * xterm.c (x_term_init):
5202 * xfns.c (x_set_border_pixel):
5203 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5204 These aren't needed now that we assume ANSI C.
5205
96f53c6c
PE
5206 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5207 It's more likely to cause problems (due to unsigned overflow)
5208 than to cure them.
5209
83c77d31
PE
5210 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5211
ee2079f1
PE
5212 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5213
6da65536
PE
5214 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5215
7147c4a4
PE
5216 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5217
193e32d9
PE
5218 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5219
e5533da6
PE
5220 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5221
9910e595
PE
5222 GLYPH_CODE_FACE returns EMACS_INT, not int.
5223 * dispextern.h (merge_faces):
5224 * xfaces.c (merge_faces):
01103c44
PE
5225 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5226 Don't assume EMACS_INT fits in int.
9910e595 5227
2638320e
PE
5228 * character.h (CHAR_VALID_P): Remove unused parameter.
5229 * fontset.c, lisp.h, xdisp.c: All uses changed.
5230
045eb8d9
PE
5231 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5232
c1f134b5
PE
5233 * fns.c (concat): Minor tuning based on overflow analysis.
5234 This doesn't fix any bugs. Use int to hold character, instead
5235 of constantly refetching from Emacs object. Use XFASTINT, not
5236 XINT, for value known to be a character. Don't bother comparing
5237 a single byte to 0400, as it's always less.
5238
395fcb93 5239 * floatfns.c (Fexpt):
327eeec8
PE
5240 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5241
abbd3d23
PE
5242 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5243 for characters.
5244
684a03ef
PE
5245 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5246
0fed43f3
PE
5247 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5248 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5249 incorrectly succeed when S was a string, because 4294967386 was
5250 truncated before it was used.
5251
8fd02eb7
PE
5252 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5253 Otherwise, an out-of-range integer could cause undefined behavior
5254 on a 64-bit host.
5255
f8c86b69
PE
5256 * composite.c: Use int, not EMACS_INT, for characters.
5257 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5258 EMACS_INT, for values that are known to be in character range.
5259 This doesn't fix any bugs but is the usual style inside Emacs and
5260 may generate better code on 32-bit machines.
5261
34206dd2
PE
5262 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5263 This is for reasons similar to the recent CHAR_STRING fix.
5264 * charset.c (Fencode_char): Check that character arg is actually
5265 a character. Pass an int to ENCODE_CHAR.
5266 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5267 wider than 'int', as a compile-time check to prevent future regressions
5268 in this area.
5269
c5958d4c 5270 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5271
5272 Make sure a 64-bit char is never passed to CHAR_STRING.
5273 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5274 by silently ignoring the top 32 bits, allowing some values
5275 that were far too large to be valid characters.
5276 * character.h: Include <verify.h>.
5277 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5278 arguments are no wider than unsigned, as a compile-time check
5279 to prevent future regressions in this area.
5280 * data.c (Faset):
01103c44 5281 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5282 (Fsubst_char_in_region):
5283 * fns.c (concat):
5284 * xdisp.c (decode_mode_spec_coding):
5285 Adjust to CHAR_STRING's new requirement.
5286 * editfns.c (Finsert_char, Fsubst_char_in_region):
5287 * fns.c (concat): Check that character args are actually
5288 characters. Without this test, these functions did the wrong
5289 thing with wildly out-of-range values on 64-bit hosts.
5290
d37ca623
PE
5291 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5292 These casts should not be needed on 32-bit hosts, either.
5293 * keyboard.c (read_char):
5294 * lread.c (Fload): Remove casts to unsigned.
5295
ea204efb
PE
5296 * lisp.h (UNSIGNED_CMP): New macro.
5297 This fixes comparison bugs on 64-bit hosts.
5298 (ASCII_CHAR_P): Use it.
5299 * casefiddle.c (casify_object):
01103c44 5300 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5301 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5302 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5303 * dispextern.h (FACE_FROM_ID):
5304 * keyboard.c (read_char): Use UNSIGNED_CMP.
5305
41cb286c
PE
5306 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5307 not to EMACS_INT, to avoid GCC warning.
5308
4a1b9832
PE
5309 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5310
55daad71
PE
5311 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5312 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5313 isn't needed on 32-bit machines.
8f95c75c 5314
01103c44
PE
5315 * buffer.c (Fgenerate_new_buffer_name):
5316 Use EMACS_INT for count, not int.
0ceccced 5317 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5318
5319 * data.c (Qcompiled_function): Now static.
5320
c6f072e7
PE
5321 * window.c (window_body_lines): Now static.
5322
20ce5912
PE
5323 * image.c (gif_load): Rename local to avoid shadowing.
5324
9c4c5f81
PE
5325 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5326 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5327 * alloc.c (make_save_value): Integer argument is now of type
5328 ptrdiff_t, not int.
5329 (mark_object): Use ptrdiff_t, not int.
5330 * lisp.h (pD): New macro.
5331 * print.c (print_object): Use it.
5332
c0c5c8ae
PE
5333 * alloc.c: Use EMACS_INT, not int, to count objects.
5334 (total_conses, total_markers, total_symbols, total_vector_size)
5335 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5336 (total_free_floats, total_floats, total_free_intervals)
5337 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5338 Now EMACS_INT, not int. All uses changed.
5339 (Fgarbage_collect): Compute overall total using a double, so that
5340 integer overflow is less likely to be a problem. Check for overflow
5341 when converting back to an integer.
5a25e253
PE
5342 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5343 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5344 These were 'int' variables that could overflow on 64-bit hosts;
5345 they were never used, so remove them instead of repairing them.
211a0b2a 5346 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5347 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5348 Previously, this ceilinged at INT_MAX, but that doesn't work on
5349 64-bit machines.
e46bb31a 5350 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5351
c78baabf 5352 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5353 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5354 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5355 when a (possibly-narrower) signed value would do just as well.
5356 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5357
c9d624c6
PE
5358 * alloc.c: Catch some string size overflows that we were missing.
5359 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5360 for convenience in STRING_BYTES_MAX.
5361 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5362 The definition here is exact; the one in lisp.h was approximate.
5363 (allocate_string_data): Check for string overflow. This catches
5364 some instances we weren't catching before. Also, it catches
5365 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5366 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5367 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5368
c9d624c6
PE
5369 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5370 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5371 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5372
353032ce
PE
5373 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5374
2bccce07
PE
5375 * alloc.c (Fmake_string): Check for out-of-range init.
5376
0ac30604
SM
53772011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5378
5379 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5380
c195f2de
JD
53812011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5382
5383 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5384 xg_get_default_scrollbar_width.
5385
5386 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5387 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5388 (style_changed_cb): Call update_theme_scrollbar_width and call
5389 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5390 all frames (Bug#8505).
5391 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5392 Call gtk_window_set_resizable if HAVE_GTK3.
5393 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5394 and height if HAVE_GTK3 (Bug#8505).
5395 (scroll_bar_width_for_theme): New variable.
5396 (update_theme_scrollbar_width): New function.
5397 (xg_get_default_scrollbar_width): Move code to
5398 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5399 (xg_initialize): Call update_theme_scrollbar_width.
5400
5401 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5402
5403 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5404
e10ac9f1
MR
54052011-06-12 Martin Rudalics <rudalics@gmx.at>
5406
5407 * frame.c (make_frame): Call other_buffer_safely instead of
5408 other_buffer.
5409
5410 * window.c (temp_output_buffer_show): Call display_buffer with
5411 second argument Vtemp_buffer_show_specifiers and reset latter
5412 immediately after the call.
5413 (Vtemp_buffer_show_specifiers): New variable.
5414 (auto_window_vscroll_p, next_screen_context_lines)
5415 (Vscroll_preserve_screen_position): Remove leading asterisks from
5416 doc-strings.
5417
2d3c217e 54182011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5419
7b7f97e8 5420 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5421 * buffer.c (Qclone_number): Remove for now, as it's unused.
5422 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5423 (record_buffer): Remove unused local.
5424 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5425 (set_frame_buffer_list): Remove; unused.
5426 * frame.h (other_visible_frames): Remove decl.
5427 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5428 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5429 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5430 if HAVE_GPM.
5431 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5432 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5433 Define only if HAVE_GPM.
5434 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5435 (update_hints_inhibit): Remove; never set. All uses removed.
5436 * widgetprv.h (emacsFrameClassRec): Remove decl.
5437 * window.c (delete_deletable_window): Now returns void, since it
5438 wasn't returning anything.
5439 (compare_window_configurations): Remove unused locals.
5440 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5441 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5442 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5443 the same widths as pointers. This follows up on the 2011-05-06 patch.
5444 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5445 * xterm.h: Likewise.
5446 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5447
1384b89e
JB
54482011-06-12 Juanma Barranquero <lekktu@gmail.com>
5449
5450 * makefile.w32-in: Update dependencies.
5451 (LISP_H): Add lib/intprops.h.
5452
1100a63c
CY
54532011-06-11 Chong Yidong <cyd@stupidchicken.com>
5454
5455 * image.c (gif_load): Add animation frame delay to the metadata.
5456 (syms_of_image): Use DEFSYM. New symbol `delay'.
5457
6198ccd0
MR
54582011-06-11 Martin Rudalics <rudalics@gmx.at>
5459
5460 * window.c (delete_deletable_window): Re-add.
5461 (Fset_window_configuration): Rewrite to handle dead buffers and
5462 consequently deletable windows.
5463 (window_tree, Fwindow_tree): Remove. Supply functionality in
5464 window.el.
5465 (compare_window_configurations): Simplify code.
5466
b6e3633c
AS
54672011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5468
1ab0dee5
AS
5469 * image.c (imagemagick_load_image): Fix type mismatch.
5470 (Fimagemagick_types): Likewise.
5471
b6e3633c
AS
5472 * window.h (replace_buffer_in_windows): Declare.
5473
9397e56f
MR
54742011-06-11 Martin Rudalics <rudalics@gmx.at>
5475
5476 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5477 Qclone_number. Remove external declaration of Qdelete_window.
5478 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5479 code.
640c8776
SM
5480 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5481 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5482 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5483 buffer list implementation.
5484 (other_buffer_safely): New function.
5485 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5486 calls to replace_buffer_in_windows and
5487 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5488 if allowed.
5489 (record_buffer): Inhibit quitting and rewrite using quittable
5490 functions. Run Qbuffer_list_update_hook if allowed.
5491 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5492 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5493 Move switch-to-buffer to window.el.
9397e56f
MR
5494 (bury-buffer): Move to window.el.
5495 (Vbuffer_list_update_hook): New variable.
5496
5497 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5498 section.
5499
5500 * window.h (resize_frame_windows): Move up in code.
5501 (Fwindow_frame): Remove EXFUN.
5502 (replace_buffer_in_all_windows): Remove prototype.
5503 (replace_buffer_in_windows_safely): Add prototype.
5504
5505 * window.c: Declare Qdelete_window static again. Move down
5506 declaration of select_count.
5507 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5508 (Fother_window): Move to window.el.
5509 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5510 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5511 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5512 window.el.
5513 (replace_buffer_in_windows): Implement by calling
5514 Qreplace_buffer_in_windows.
5515 (replace_buffer_in_all_windows): Remove with some functionality
5516 moved into replace_buffer_in_windows_safely.
5517 (replace_buffer_in_windows_safely): New function.
5518 (select_window_norecord, select_frame_norecord): Move in front
5519 of run_window_configuration_change_hook. Remove now obsolete
5520 declarations.
640c8776
SM
5521 (Fset_window_buffer): Rewrite doc-string.
5522 Call Qrecord_window_buffer.
9397e56f
MR
5523 (keys_of_window): Move binding for other-window to window.el.
5524
b50691aa
CY
55252011-06-11 Chong Yidong <cyd@stupidchicken.com>
5526
5527 * dispextern.h (struct image): Replace data member, whose int_val
5528 and ptr_val fields were not used by anything, with a single
5529 lisp_val object.
5530
5531 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5532 (gif_clear_image, gif_load, imagemagick_load_image)
5533 (gs_clear_image, gs_load): Callers changed.
5534
3f754b86
PE
55352011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5536
cca69397
PE
5537 * buffer.h: Include <time.h>, for time_t.
5538 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5539
109e28d0
PE
5540 Fix minor problems found by static checking.
5541
60737f02
PE
5542 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5543
4b66faf3
PE
5544 Make identifiers static if they are not used in other modules.
5545 * data.c (Qcompiled_function, Qframe, Qvector):
5546 * image.c (QimageMagick, Qsvg):
5547 * minibuf.c (Qmetadata):
5548 * window.c (resize_window_check, resize_root_window): Now static.
5549 * window.h (resize_window_check, resize_root_window): Remove decls.
5550
109e28d0
PE
5551 * window.c (window_deletion_count, delete_deletable_window):
5552 Remove; unused.
46a4ce9e
PE
5553 (window_body_lines): Now static.
5554 (Fdelete_other_windows_internal): Mark vars as initialized.
5555 Make sure 'resize_failed' is initialized.
5556 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5557 (resize_window_apply): Remove unused local.
5558 * window.h (delete_deletable_window): Remove decl.
5559
109e28d0 5560 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5561 (imagemagick_load_image): Fix pointer signedness problem by changing
5562 last arg from unsigned char * to char *. All uses changed.
5563 Also, fix a local for similar reasons.
5564 Remove unused locals. Remove locals to avoid shadowing.
5565 (fn_rsvg_handle_free): Remove; unused.
5566 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5567 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5568
3f754b86
PE
5569 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5570
2547adb1
CY
55712011-06-10 Chong Yidong <cyd@stupidchicken.com>
5572
5573 * image.c (gif_load): Fix omitted cast error introduced by
5574 2011-06-06 change.
5575
2c8e37d4
MR
55762011-06-10 Martin Rudalics <rudalics@gmx.at>
5577
5578 * window.h (resize_proportionally, orig_total_lines)
5579 (orig_top_line): Remove from window structure.
5580 (set_window_height, set_window_width, change_window_heights)
5581 (Fdelete_window): Remove prototypes.
5582 (resize_frame_windows): Remove duplicate declaration.
5583
440a42e3
EZ
55842011-06-10 Eli Zaretskii <eliz@gnu.org>
5585
5586 * window.h (resize_frame_windows, resize_window_check)
5587 (delete_deletable_window, resize_root_window)
5588 (resize_frame_windows): Declare prototypes.
5589
5590 * window.c (resize_window_apply): Make definition be "static" to
5591 match the prototype.
5592
562dd5e9
MR
55932011-06-10 Martin Rudalics <rudalics@gmx.at>
5594
5595 * window.c: Remove declarations of Qwindow_size_fixed,
5596 window_min_size_1, window_min_size_2, window_min_size,
5597 size_window, window_fixed_size_p, enlarge_window, delete_window.
5598 Remove static from declaration of Qdelete_window, it's
5599 temporarily needed by Fbury_buffer.
5600 (replace_window): Don't assign orig_top_line and
5601 orig_total_lines.
5602 (Fdelete_window, delete_window): Remove. Window deletion is
5603 handled by window.el.
640c8776
SM
5604 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5605 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5606 (Fdelete_other_windows): Remove. Deleting other windows is
5607 handled by window.el.
5608 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5609 handled in window.el.
5610 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5611 Window minimum sizes are handled in window.el.
5612 (shrink_windows, size_window, set_window_height)
5613 (set_window_width, change_window_heights, window_height)
5614 (window_width, CURBEG, CURSIZE, enlarge_window)
5615 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5616 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5617 handled in window.el.
5618 (make_dummy_parent): Rename to make_parent_window and give it a
5619 second argument horflag.
5620 (make_window): Don't set resize_proportionally any more.
5621 (Fsplit_window): Remove. Windows are split in window.el.
5622 (save_restore_action, save_restore_orig_size)
5623 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5624 Resize mini windows in window.el.
5625 (grow_mini_window, shrink_mini_window): Implement by calling
5626 Qresize_root_window_vertically, resize_window_check and
5627 resize_window_apply.
640c8776
SM
5628 (saved_window, Fset_window_configuration, save_window_save):
5629 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5630 resize_proportionally.
5631 (window_min_height, window_min_width): Move to window.el.
5632 (keys_of_window): Move bindings for delete-other-windows,
5633 split-window, delete-window and enlarge-window to window.el.
5634
5635 * buffer.c: Temporarily extern Qdelete_window.
5636 (Fbury_buffer): Temporarily call Qdelete_window instead of
5637 Fdelete_window (Fbury_buffer will move to window.el soon).
5638
5639 * frame.c (set_menu_bar_lines_1): Remove code handling
5640 orig_top_line and orig_total_lines.
5641
5642 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5643 set_window_height but set heights directly.
5644 (change_frame_size_1): Use resize_frame_windows.
5645
5646 * xdisp.c (init_xdisp): Don't use set_window_height but set
5647 heights directly.
5648
640c8776
SM
5649 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5650 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5651 run_window_configuration_change_hook.
5652
5653 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5654 instead of change_window_heights and run
5655 run_window_configuration_change_hook.
5656
1a13852e
MR
56572011-06-09 Martin Rudalics <rudalics@gmx.at>
5658
5659 * window.c (replace_window): Rename second argument REPLACEMENT to
5660 NEW. New third argument SETFLAG. Rewrite.
5661 (delete_window, make_dummy_parent): Call replace_window with
5662 third argument 1.
5663 (window_list_1): Move down in code.
5664 (run_window_configuration_change_hook): Move set_buffer part
5665 before select_frame_norecord part in order to unwind correctly.
5666 Rename count1 to count.
5667 (recombine_windows, delete_deletable_window, resize_root_window)
5668 (Fdelete_other_windows_internal)
5669 (Frun_window_configuration_change_hook, make_parent_window)
5670 (resize_window_check, resize_window_apply, Fresize_window_apply)
5671 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5672 (Fdelete_window_internal, Fresize_mini_window_internal):
5673 New functions.
1a13852e
MR
5674 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5675
f3d1777e
MR
56762011-06-08 Martin Rudalics <rudalics@gmx.at>
5677
496e208e
MR
5678 * window.h (window): Add some new members to window structure -
5679 normal_lines, normal_cols, new_total, new_normal, clone_number,
5680 splits, nest, prev_buffers, next_buffers.
5681 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5682 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5683
f3d1777e
MR
5684 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5685 Remove.
496e208e
MR
5686 (make_dummy_parent): Set new members of windows structure.
5687 (make_window): Move down in code. Handle new members of window
5688 structure.
5689 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5690 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5691 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5692 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5693 (Fset_window_next_buffers, Fset_window_clone_number):
5694 New functions.
496e208e
MR
5695 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5696 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5697 Doc-string fixes.
5698 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5699 Argument WINDOW can be now internal window too.
5700 (Fwindow_use_time): Move up in code.
5701 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5702 Rewrite doc-string.
5703 (Fset_window_configuration, saved_window)
5704 (Fcurrent_window_configuration, save_window_save): Handle new
5705 members of window structure.
b9e809c2
MR
5706 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5707 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5708 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5709 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5710 Qget_mru_window, Qresize_root_window,
5711 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5712 Qauto_buffer_name; staticpro them.
f3d1777e 5713
abde8f8c
MR
57142011-06-07 Martin Rudalics <rudalics@gmx.at>
5715
5716 * window.c (Fwindow_total_size, Fwindow_left_column)
5717 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5718 (Fwindow_list_1): New functions.
5719 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5720 (Fwindow_width, Fscroll_left, Fscroll_right):
5721 Use window_body_cols instead of window_box_text_cols.
5722 (delete_window, Fset_window_configuration):
5723 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5724 (delete_all_subwindows): Take a window as argument and not a
5725 structure. Rewrite.
190b47e6
MR
5726 (window_loop): Remove handling of GET_LRU_WINDOW and
5727 GET_LARGEST_WINDOW.
5728 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5729
5730 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5731 window_box_text_cols. delete_all_subwindows now takes a
5732 Lisp_Object as argument.
abde8f8c 5733
640c8776
SM
5734 * indent.c (compute_motion, Fcompute_motion):
5735 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5736
fa8a67e6
MR
5737 * frame.c (delete_frame): Call delete_all_subwindows with root
5738 window as argument.
5739
a54e3482
DC
57402011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5741
5742 * fns.c (Fputhash): Document return value.
5743
60002bf5
CY
57442011-06-06 Chong Yidong <cyd@stupidchicken.com>
5745
5746 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5747
0c671da6 57482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5749
b862a52a 5750 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5751
be44ca6c
PE
5752 Check for overflow when converting integer to cons and back.
5753 * charset.c (Fdefine_charset_internal, Fdecode_char):
5754 Use cons_to_unsigned to catch overflow.
5755 (Fencode_char): Use INTEGER_TO_CONS.
5756 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5757 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5758 * data.c (long_to_cons, cons_to_long): Remove.
5759 (cons_to_unsigned, cons_to_signed): New functions.
5760 These signal an error for invalid or out-of-range values.
5761 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5762 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5763 * font.c (Ffont_variation_glyphs):
5764 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5765 * lisp.h: Include <intprops.h>.
5766 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5767 (cons_to_signed, cons_to_unsigned): New decls.
5768 (long_to_cons, cons_to_long): Remove decls.
5769 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5770 (Fprimitive_undo): Use CONS_TO_INTEGER.
5771 * xfns.c (Fx_window_property): Likewise.
5772 * xselect.c: Include <limits.h>.
5773 (x_own_selection, selection_data_to_lisp_data):
5774 Use INTEGER_TO_CONS.
5775 (x_handle_selection_request, x_handle_selection_clear)
5776 (x_get_foreign_selection, Fx_disown_selection_internal)
5777 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5778 (lisp_data_to_selection_data): Use cons_to_unsigned.
5779 (x_fill_property_data): Use cons_to_signed.
5780 Report values out of range.
5781
d1f3d2af
PE
5782 Check for buffer and string overflow more precisely.
5783 * buffer.h (BUF_BYTES_MAX): New macro.
5784 * lisp.h (STRING_BYTES_MAX): New macro.
5785 * alloc.c (Fmake_string):
5786 * character.c (string_escape_byte8):
5787 * coding.c (coding_alloc_by_realloc):
5788 * doprnt.c (doprnt):
5789 * editfns.c (Fformat):
5790 * eval.c (verror):
5791 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5792 since they may not be the same number.
5793 * editfns.c (Finsert_char):
5794 * fileio.c (Finsert_file_contents):
5795 Likewise for BUF_BYTES_MAX.
5796
dd52fcea
PE
5797 * image.c: Use ptrdiff_t, not int, for sizes.
5798 (slurp_file): Switch from int to ptrdiff_t.
5799 All uses changed.
5800 (slurp_file): Check that file size fits in both size_t (for
5801 malloc) and ptrdiff_t (for sanity and safety).
5802
7f9bbdbb
PE
5803 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5804 if b->modtime has its maximal value.
5805
dfe18f82
PE
5806 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5807
84acfcf0
PE
5808 Don't assume time_t can fit into int.
5809 * buffer.h (struct buffer.modtime): Now time_t, not int.
5810 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5811 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5812
ccd9a01a
PE
5813 Minor fixes for signed vs unsigned integers.
5814 * character.h (MAYBE_UNIFY_CHAR):
5815 * charset.c (maybe_unify_char):
5816 * keyboard.c (read_char, reorder_modifiers):
5817 XINT -> XFASTINT, since the integer must be nonnegative.
5818 * ftfont.c (ftfont_spec_pattern):
5819 * keymap.c (access_keymap, silly_event_symbol_error):
5820 XUINT -> XFASTINT, since the integer must be nonnegative.
5821 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5822 since it makes no difference and we prefer signed.
5823 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5824 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5825 nonnegative.
5826
d6d100dd
SM
58272011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5828
5829 * window.h (Fwindow_frame): Declare.
5830
2b6148e4
PE
58312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5832
5833 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5834 (SPARE_MEMORY): Always define.
5835 (LARGE_REQUEST): Remove.
5836 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5837
f230ecc9
MR
58382011-06-06 Martin Rudalics <rudalics@gmx.at>
5839
727e958e
MR
5840 * lisp.h: Move EXFUNS for Fframe_root_window,
5841 Fframe_first_window and Fset_frame_selected_window to window.h.
5842
5843 * window.h: Move EXFUNS for Fframe_root_window,
5844 Fframe_first_window and Fset_frame_selected_window here from
5845 lisp.h.
5846
5847 * frame.c (Fwindow_frame, Fframe_first_window)
5848 (Fframe_root_window, Fframe_selected_window)
5849 (Fset_frame_selected_window): Move to window.c.
5850 (Factive_minibuffer_window): Move to minibuf.c.
5851 (Fother_visible_frames_p): New function.
5852
5853 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5854
f230ecc9
MR
5855 * window.c (decode_window, decode_any_window): Move up in code.
5856 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5857 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5858 (Fwindow_buffer): Move up and rewrite doc-string.
5859 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5860 (Fwindow_prev): New functions.
727e958e
MR
5861 (Fwindow_frame): Move here from frame.c. Accept any window as
5862 argument.
5863 (Fframe_root_window, Fframe_first_window)
5864 (Fframe_selected_window): Move here from frame.c. Accept frame
5865 or arbitrary window as argument. Update doc-strings.
5866 (Fminibuffer_window): Move up in code.
5867 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5868 (Fset_frame_selected_window): Move here from frame.c.
5869 Marginal rewrite.
727e958e
MR
5870 (Fselected_window, select_window, Fselect_window): Move up in
5871 code. Minor doc-string fixes.
f230ecc9 5872
4d09bcf6
PE
58732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5874
5875 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5876 Do not assume that spare memory exists; that assumption is valid
5877 only if SYSTEM_MALLOC.
5878 (LARGE_REQUEST): New macro, so that the issue of large requests
5879 is separated from the issue of spare memory.
5880
810928a2
AS
58812011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5882
172418ad
AS
5883 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5884 format. (Bug#8806)
5885
43f862f7
AS
5886 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5887
810928a2
AS
5888 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5889 before statements.
5890
a059fe24
JD
58912011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5892
5893 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5894
5895 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5896
5897 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5898 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5899
989bf368
JB
59002011-06-05 Juanma Barranquero <lekktu@gmail.com>
5901
5902 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5903
4b80f674
CY
59042011-06-04 Chong Yidong <cyd@stupidchicken.com>
5905
5906 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5907 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5908 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5909 New error handlers.
4b80f674
CY
5910 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5911 Obey Vx_select_enable_clipboard_manager. Catch errors in
5912 x_clipboard_manager_save (Bug#8779).
5913 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5914 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5915
99a33b77 59162011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5917
5918 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5919
99a33b77 59202011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5921
5922 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5923 in the current matrix if keep_current_p is non-zero.
5924
8264569d
EZ
59252011-06-04 Eli Zaretskii <eliz@gnu.org>
5926
5927 * bidi.c (bidi_level_of_next_char): Fix last change.
5928
57f97249
EZ
59292011-06-03 Eli Zaretskii <eliz@gnu.org>
5930
fec2107c 5931 Support bidi reordering of text covered by display properties.
57f97249 5932
fec2107c
EZ
5933 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5934 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5935 (bidi_cache_search, bidi_cache_iterator_state)
5936 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5937 (bidi_level_of_next_char, bidi_move_to_visually_next):
5938 Support character positions inside a run of characters covered by a
fec2107c
EZ
5939 display string.
5940 (bidi_paragraph_init, bidi_resolve_explicit_1)
5941 (bidi_level_of_next_char): Call bidi_fetch_char and
5942 bidi_fetch_char_advance instead of FETCH_CHAR and
5943 FETCH_CHAR_ADVANCE.
5944 (bidi_init_it): Initialize new members.
5945 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5946 definitions.
5947 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5948 instead of using explicit *_CHAR codes.
d6d100dd
SM
5949 (bidi_resolve_explicit, bidi_resolve_weak):
5950 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5951 bidirectional text is supported only in multibyte buffers.
5952 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5953 it to initialize the frame_window_p member of struct bidi_it.
5954 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5955 (bidi_resolve_explicit, bidi_resolve_weak)
5956 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5957 bidi_it->nchars is non-positive.
5958 (bidi_level_of_next_char): Don't try to lookup the cache for the
5959 next/previous character if nothing is cached there yet, or if we
5960 were just reseat()'ed to a new position.
c40e2fb2 5961
0e14fe90
EZ
5962 * xdisp.c (set_cursor_from_row): Set start and stop points
5963 according to the row's direction when priming the loop that looks
5964 for the glyph on which to display cursor.
5965 (single_display_spec_intangible_p): Function deleted.
5966 (display_prop_intangible_p): Reimplement to call
5967 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5968 Accept 3 additional arguments needed by handle_display_spec.
5969 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5970 values: lists, `(when COND...)' forms, etc.
5971 (single_display_spec_string_p): Support property values that are
5972 lists with the argument STRING its top-level element.
5973 (display_prop_string_p): Fix the condition for processing a
5974 property that is a list to be consistent with handle_display_spec.
fec2107c 5975 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5976 last portion of handle_display_prop.
5977 (compute_display_string_pos): Accept additional argument
5978 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5979 value of a `display' property is a "replacing spec".
5980 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5981 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5982 the display property, but just return a value indicating whether
5983 the display property will replace the characters it covers.
5984 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5985 frame_window_p members of struct bidi_it.
d6d100dd
SM
5986 (compute_display_string_pos, compute_display_string_end):
5987 New functions.
fec2107c
EZ
5988 (push_it): Accept second argument POSITION, where pop_it should
5989 jump to continue iteration.
5990 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5991
fec2107c
EZ
5992 * keyboard.c (adjust_point_for_property): Adjust the call to
5993 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5994
5995 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5996 (bidi_init_it): Update prototypes.
5997 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5998 (compute_display_string_pos, compute_display_string_end):
5999 Declare prototypes.
fec2107c
EZ
6000 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6001 EMACS_INT.
fc6f18ce 6002
40087514 60032011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6004
57f53182
PE
6005 Malloc failure behavior now depends on size of allocation.
6006 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6007 * lisp.h: Change signatures accordingly.
6008 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6009 All callers changed. (Bug#8762)
6010
6011 * gnutls.c: Use Emacs's memory allocators.
6012 Without this change, the gnutls library would invoke malloc etc.
6013 directly, which causes problems on non-SYNC_INPUT hosts, and which
6014 runs afoul of improving memory_full behavior. (Bug#8761)
6015 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6016 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6017 xfree instead of the default malloc, realloc, free.
6018 (Fgnutls_boot): No need to check for memory allocation failure,
6019 since xmalloc does that for us.
6020
ac32cd99 6021 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6022 * category.c (hash_get_category_set):
6023 * ccl.c (ccl_driver):
6024 * charset.c (Fdefine_charset_internal):
6025 * charset.h (struct charset.hash_index):
6026 * composite.c (get_composition_id, gstring_lookup_cache)
6027 (composition_gstring_put_cache):
6028 * composite.h (struct composition.hash_index):
6029 * dispextern.h (struct image.hash):
6030 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6031 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6032 (hashfn_equal, hashfn_user_defined, make_hash_table)
6033 (maybe_resize_hash_table, hash_lookup, hash_put)
6034 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6035 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6036 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6037 * image.c (make_image, search_image_cache, lookup_image)
6038 (xpm_put_color_table_h):
6039 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6040 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6041 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6042 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6043 * alloc.c (allocate_vectorlike):
6044 Check for overflow in vector size calculations.
6045 * ccl.c (ccl_driver):
6046 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6047 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6048 need to be updated by these changes.
40087514
PE
6049 * fns.c (make_hash_table, maybe_resize_hash_table):
6050 Check for integer overflow with large hash tables.
0de4bb68
PE
6051 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6052 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6053 (SXHASH_REDUCE): New macro.
6054 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6055 Use it instead of discarding useful hash info with large hash values.
6056 (sxhash_float): New function.
6057 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6058 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6059 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6060 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6061 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6062 Adjust signatures to match updated version of code.
6063 (consing_since_gc): Now EMACS_INT, since a single hash table can
6064 use more than INT_MAX bytes.
6065
698d32e2
DN
60662011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6067
6068 Make it possible to build with GCC-4.6+ -O2 -flto.
6069
6070 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6071
fd6fa53f
SM
60722011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6073
6074 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6075 Call minibuffer-inactive-mode.
6076
864db017
JB
60772011-05-31 Juanma Barranquero <lekktu@gmail.com>
6078
6079 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6080 Update dependencies.
6081
2ad0baf4
DN
60822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6083
6084 * data.c (init_data): Remove code for UTS, this system is not
6085 supported anymore.
6086
4fcc2638
DN
60872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6088
6089 Don't force ./temacs to start in terminal mode.
6090
6091 * frame.c (make_initial_frame): Initialize faces in all cases, not
6092 only when CANNOT_DUMP is defined.
6093 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6094
c56e0fd5
DN
60952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6096
6097 * dispnew.c (add_window_display_history): Use const for the string
6098 pointer. Remove declaration, not needed.
6099
333d54da 61002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6101
55d4c1b2 6102 Use 'inline', not 'INLINE'.
333d54da 6103 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6104 * alloc.c, fontset.c (INLINE): Remove.
6105 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6106 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6107 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6108 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6109 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6110
738db178
DN
61112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6112
6113 Make it possible to run ./temacs.
6114
6115 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6116 syms_of_callproc does the same thing. Remove test for
6117 "initialized", do it in the caller.
6118 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6119
620c53a6
SM
61202011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6121
6122 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6123 (read_minibuf): Use get_minibuffer.
6124 (syms_of_minibuf): Use DEFSYM.
6125 (Qmetadata): New var.
6126 * data.c (Qbuffer): Don't make it static.
6127 (syms_of_data): Use DEFSYM.
6128
e003a292
PE
61292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6130
6131 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6132 (CCL_CODE_MIN): New macro.
6133
ed008a6d
PE
61342011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6135
3687c2ef
PE
6136 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6137
ed008a6d
PE
6138 * eval.c (Qdebug): Now static.
6139 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6140 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6141 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6142
d66c4c7c
CY
61432011-05-29 Chong Yidong <cyd@stupidchicken.com>
6144
6145 * image.c: Various fixes to ImageMagick code comments.
6146 (Fimagemagick_types): Doc fix.
6147
5fbc2025
PE
61482011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6149
0196f88a
PE
6150 Minor fixes prompted by GCC 4.6.0 warnings.
6151
6152 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6153
5fbc2025
PE
6154 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6155 (x_clipboard_manager_save_all): Move extern decl to ...
6156 * xterm.h: ... here, so that it can be checked for consistency.
6157
1dd3c2d9
CY
61582011-05-29 Chong Yidong <cyd@stupidchicken.com>
6159
6160 * xselect.c (x_clipboard_manager_save_frame)
6161 (x_clipboard_manager_save_all): New functions.
6162 (Fx_clipboard_manager_save): Lisp function deleted.
6163
6164 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6165 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6166
6167 * xterm.h: Update prototype.
6168
5ba6571d
WX
61692011-05-28 William Xu <william.xwl@gmail.com>
6170
6171 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6172 exiting (Bug#8239).
6173
3eaff834
JM
61742011-05-28 Jim Meyering <meyering@redhat.com>
6175
e1900994 6176 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6177 * fns.c (to_uchar): Define.
6178 (crypto_hash_function): Use it to convert some newly-signed
6179 variables to unsigned, to avoid sign-extension bugs. For example,
6180 without this change, (md5 "truc") would evaluate to
6181 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6182 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6183 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6184
0f6990a7
PE
61852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6186
6187 Integer overflow fixes.
c8a9ca5a 6188
08686060
PE
6189 * dbusbind.c: Serial number integer overflow fixes.
6190 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6191 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6192 to hold a serial number that is too large for a fixnum.
6193 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6194 Check for serial numbers out of range. Decode any serial number
59568bf0 6195 that was so large that it became a float. (Bug#8722)
08686060 6196
2d1fc3c7
PE
6197 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6198 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6199 Use XFASTINT rather than XUINT when numbers are nonnegative.
6200 (xd_append_arg, Fdbus_method_return_internal):
6201 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6202 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6203 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6204 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6205 (Bug#8722)
2d1fc3c7 6206
c8a9ca5a
PE
6207 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6208
519e1d69
PE
6209 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6210
6df6ae42 6211 ccl: Add integer overflow checks.
30569699
PE
6212 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6213 (IN_INT_RANGE): New macros.
6214 (ccl_driver): Use them to check for integer overflow when
6215 decoding a CCL program. Many of the new checks are whether XINT (x)
6216 fits in int; it doesn't always, on 64-bit hosts. The new version
6217 doesn't catch all possible integer overflows, but it's an
847044ea 6218 improvement. (Bug#8719)
30569699 6219
c11285dc
PE
6220 * alloc.c (make_event_array): Use XINT, not XUINT.
6221 There's no need for unsigned here.
6222
fdccd48e
PE
6223 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6224 This follows up to the 2011-05-06 change that substituted uintptr_t
6225 for EMACS_INT. This case wasn't caught back then.
6226
37910ab2
PE
6227 Rework Fformat to avoid integer overflow issues.
6228 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6229 now (part of C89). Include <verify.h>.
6230 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6231 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6232 (Fformat): Avoid the prepass trying to compute sizes; it was only
6233 approximate and thus did not catch overflow reliably. Instead, walk
6234 through the format just once, formatting and computing sizes as we go,
6235 checking for integer overflow at every step, and allocating a larger
6236 buffer as needed. Keep track separately whether the format is
6237 multibyte. Keep only the most-recently calculated precision, rather
6238 than them all. Record whether each argument has been converted to
6239 string. Use EMACS_INT, not int, for byte and char and arg counts.
6240 Support field widths and precisions larger than INT_MAX. Avoid
6241 sprintf's undefined behavior with conversion specifications such as %#d
6242 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6243 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6244 formatting out-of-range floating point numbers with int
9173deec 6245 formats. (Bug#8668)
37910ab2 6246
2e6578fb
PE
6247 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6248
0ae6bdee
PE
6249 * data.c: Avoid integer truncation in expressions involving floats.
6250 * data.c: Include <intprops.h>.
6251 (arith_driver): When there's an integer overflow in an expression
6252 involving floating point, convert the integers to floating point
6253 so that the resulting value does not suffer from catastrophic
6254 integer truncation. For example, on a 64-bit host (* 4
6255 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6256 Do not rely on undefined behavior after integer overflow.
6257
de883a70
PE
6258 merge count_size_as_multibyte, parse_str_to_multibyte
6259 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6260 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6261 Check for integer overflow.
6262 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6263 since it's now a duplicate of the other. This is more of
6264 a character than a buffer op, so better that it's in character.c.
6265 * fns.c, print.c: Adjust to above changes.
6266
2ff916cb
PE
62672011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6268
6269 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6270
f1b54466
PE
62712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6272
fb1ac845
PE
6273 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6274 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6275 (x_clipboard_manager_save): Now static.
6276 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6277
f1b54466
PE
6278 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6279 (crypto_hash_function): Now static.
6280 Fix pointer signedness problems. Avoid unnecessary initializations.
6281
a9f737ee
CY
62822011-05-27 Chong Yidong <cyd@stupidchicken.com>
6283
6284 * termhooks.h (Vselection_alist): Make it terminal-local.
6285
6286 * terminal.c (create_terminal): Initialize it.
6287
6288 * xselect.c: Support for clipboard managers.
6289 (Vselection_alist): Move to termhooks.h as terminal-local var.
6290 (LOCAL_SELECTION): New macro.
6291 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6292 (symbol_to_x_atom): Remove gratuitous arg.
6293 (x_handle_selection_request, lisp_data_to_selection_data)
6294 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6295 (x_own_selection, x_get_local_selection, x_convert_selection):
6296 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6297 (some_frame_on_display): Delete unused function.
6298 (Fx_own_selection_internal, Fx_get_selection_internal)
6299 (Fx_disown_selection_internal, Fx_selection_owner_p)
6300 (Fx_selection_exists_p): New optional frame arg.
6301 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6302 (x_handle_selection_clear): Don't treat other terminals with the
6303 same keyboard specially. Use the terminal-local Vselection_alist.
6304 (x_clear_frame_selections): Use Frun_hook_with_args.
6305
6306 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6307
6308 * xterm.h: Add support for those atoms.
6309
e067f0c1
CY
63102011-05-26 Chong Yidong <cyd@stupidchicken.com>
6311
6312 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6313 (converted_selections, conversion_fail_tag): New global variables.
6314 (x_selection_request_lisp_error): Free the above.
6315 (x_get_local_selection): Remove unnecessary code.
6316 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6317 of converted selections stored in converted_selections.
6318 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6319 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6320 (x_convert_selection): New function.
6321 (x_handle_selection_event): Simplify.
6322 (x_get_foreign_selection): Don't ignore incoming requests while
6323 waiting for an answer; this will fail when we implement
6324 SAVE_TARGETS, and seems unnecessary anyway.
6325 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6326 (Vx_sent_selection_functions): Doc fix.
6327
0f4aebc0
LL
63282011-05-26 Leo Liu <sdl.web@gmail.com>
6329
6330 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6331
e61124cd
YM
63322011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6333
6334 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6335
6336 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6337 for fringe update if it has periodic bitmap.
ac389d0c 6338 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6339 and fringe_bitmap_periodic_p.
6340
6341 * fringe.c (get_fringe_bitmap_data): New function.
6342 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6343 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6344 row. Mark glyph row for fringe update if periodicity changed.
6345
6346 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6347 for fringe update unless it has periodic bitmap.
6348
f16d9837
KH
63492011-05-25 Kenichi Handa <handa@m17n.org>
6350
6351 * xdisp.c (get_next_display_element): Set correct it->face_id for
6352 a static composition.
6353
e1b90ef6
LL
63542011-05-24 Leo Liu <sdl.web@gmail.com>
6355
6356 * deps.mk (fns.o):
6357 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6358
6359 * fns.c (crypto_hash_function, Fsha1): New function.
6360 (Fmd5): Use crypto_hash_function.
6361 (syms_of_fns): Add Ssha1.
6362
7400048f
PE
63632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6364
6365 * gnutls.c: Remove unused macros.
6366 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6367 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6368 Remove macros that are defined and never used.
6369 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6370
abb71cf4
CY
63712011-05-22 Chong Yidong <cyd@stupidchicken.com>
6372
6373 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6374 (Fx_get_selection_internal): Minor cleanup.
6375 (Fx_own_selection_internal): Rename arguments for consistency with
6376 select.el.
6377
6307db39
PE
63782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6379
6380 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6381
f3d4e0a4
CY
63822011-05-22 Chong Yidong <cyd@stupidchicken.com>
6383
6384 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6385
4d8ade89
YM
63862011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6387
6388 * dispnew.c (scrolling_window): Don't exclude the case that the
6389 last enabled row in the desired matrix touches the bottom boundary.
6390
32078c8d
GM
63912011-05-21 Glenn Morris <rgm@gnu.org>
6392
6393 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6394 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6395 and add some more files.
32078c8d 6396
7285dc67
EZ
63972011-05-20 Eli Zaretskii <eliz@gnu.org>
6398
6399 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6400 report_file_error introduced by the change from 2011-05-07.
6401
89d1bd22
PE
64022011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6403
6404 * systime.h (Time): Define only if emacs is defined.
6405 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6406 where the include path doesn't have X11/X.h by default. See
6407 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6408
cd394be1 64092011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6410
6411 * composite.c (find_automatic_composition): Fix previous change.
6412
b9704ad9
GM
64132011-05-20 Glenn Morris <rgm@gnu.org>
6414
6415 * lisp.mk: New file, split from Makefile.in.
6416 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6417 (shortlisp): Remove.
6418 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6419
4a720484
GM
64202011-05-19 Glenn Morris <rgm@gnu.org>
6421
6422 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6423 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6424 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6425 (lisp): Set the order to that of loadup.el.
6426 (shortlisp): Make it a copy of $lisp.
6427 (SOME_MACHINE_LISP): Remove.
6428 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6429 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6430
a28d4396
KH
64312011-05-18 Kenichi Handa <handa@m17n.org>
6432
6433 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6434 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6435 (find_automatic_composition): Mostly rewrite for efficiency.
6436
a2b1fa8e
JB
64372011-05-18 Juanma Barranquero <lekktu@gmail.com>
6438
6439 * makefile.w32-in: Update dependencies.
6440
8e1f5610
CS
64412011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6442
6443 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6444 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6445
7025ee00 64462011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6447
cdfa6eab
PE
6448 Fix some integer overflow issues, such as string length overflow.
6449
06d6db33
PE
6450 * insdel.c (count_size_as_multibyte): Check for string overflow.
6451
2b4560a8
PE
6452 * character.c (lisp_string_width): Check for string overflow.
6453 Use EMACS_INT, not int, for string indexes and lengths; in
6454 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6455 the resulting string length overflows an EMACS_INT; instead,
6456 report a string overflow if no precision given. When checking for
6457 precision exhaustion, use a check that cannot possibly have
6458 integer overflow. (Bug#8675)
6459 * character.h (lisp_string_width): Adjust to new signature.
6460
cb93f9be
PE
6461 * alloc.c (string_overflow): New function.
6462 (Fmake_string): Use it. This doesn't change behavior, but saves
6463 a few bytes and will simplify future changes.
6464 * character.c (string_escape_byte8): Likewise.
6465 * lisp.h (string_overflow): New decl.
6466
1a1f3366
PE
6467 Fixups, following up to the user-interface timestamp change.
6468 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6469 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6470 * msdos.c (mouse_get_pos): Likewise.
6471 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6472 * w32gui.h (Time): Define by including "systime.h" rather than by
6473 declaring it ourselves. (Bug#8664)
6474
d4e3e4d3
PE
6475 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6476 * image.c (clear_image_cache): Likewise.
6477
f6a24d19
PE
6478 * term.c (term_mouse_position): Don't assume time_t wraparound.
6479
08dc5ae6
PE
6480 Be more systematic about user-interface timestamps.
6481 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6482 and sometimes 'EMACS_UINT', to represent these timestamps.
6483 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6484 This makes the code easier to follow, and makes it easier to catch
6485 integer overflow bugs such as Bug#8664.
6486 * frame.c (Fmouse_position, Fmouse_pixel_position):
6487 Use Time, not unsigned long, for user-interface timestamps.
6488 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6489 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6490 * keyboard.h (last_event_timestamp): Likewise.
6491 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6492 * menu.h (xmenu_show): Likewise.
6493 * term.c (term_mouse_position): Likewise.
6494 * termhooks.h (struct input_event.timestamp): Likewise.
6495 (struct terminal.mouse_position_hook): Likewise.
6496 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6497 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6498 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6499 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6500 what it was before.
6501 * menu.h, termhooks.h: Include "systime.h", for Time.
6502
8e55734a
PE
6503 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6504 Don't assume that the difference between two unsigned long values
6505 can fit into an integer. At this point, we know button_down_time
6506 <= event->timestamp, so the difference must be nonnegative, so
6507 there's no need to cast the result if double-click-time is
6508 nonnegative, as it should be; check that it's nonnegative, just in
6509 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6510 apart (about 25 days). (Bug#8664)
8e55734a 6511
841f1b75 6512 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6513 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6514
3e26f69c
PE
6515 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6516 that always fit in int. Use a sentinel instead of a counter, to
6517 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6518 * frame.h (struct frame): Use int for menu_bar_items_used
6519 instead of EMACS_INT, since it always fits in int.
3e26f69c 6520
5cc152c0
PE
6521 * menu.c (grow_menu_items): Check for int overflow.
6522
d89eb65e
PE
6523 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6524
5235bd3e
PE
6525 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6526 Before, the code was not consistent. These values cannot exceed
6527 2**31 - 1 so there's no need to make them unsigned.
6528 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6529 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6530 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6531 as modifiers.
6532 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6533
bc827e23
PE
6534 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6535 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6536 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6537 presumably because the widths might not match.
6538
78eb494e
PE
6539 * window.c (size_window): Avoid needless test at loop start.
6540
04f2d78b
CB
65412011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6542
6543 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6544
d2fc7e3d 65452011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6546
6547 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6548
d2fc7e3d 65492011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6550
6551 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6552 `width' to `bar_area_x' and `bar_area_width', respectively.
6553 (x_scroll_run): Take account of fringe background extension.
6554
04f2d78b
CB
6555 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6556 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6557 `bar_area_width', respectively.
6558 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6559 background extension.
6560
79b70037
GM
65612011-05-10 Jim Meyering <meyering@redhat.com>
6562
6563 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6564
2f142cc5
JB
65652011-05-10 Juanma Barranquero <lekktu@gmail.com>
6566
6567 * image.c (Finit_image_library): Return t for built-in image types,
6568 like pbm and xbm. (Bug#8640)
6569
57679c86
AS
65702011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6571
6572 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6573
888c9e86
EZ
65742011-05-07 Eli Zaretskii <eliz@gnu.org>
6575
b0512a1d
EZ
6576 * w32console.c (Fset_screen_color): Doc fix.
6577 (Fget_screen_color): New function.
6578 (syms_of_ntterm): Defsubr it.
6579
7285dc67
EZ
6580 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6581 unlink the temporary file if Fcall_process didn't create it in the
6582 first place.
6583 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6584 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6585 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6586 cue to call_process_cleanup not to close that handle.
6587
4d3fcc8e
BK
65882011-05-07 Ben Key <bkey76@gmail.com>
6589
6590 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6591 one of two shell specific rules, either bootstrap-temacs-CMD or
6592 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6593 to the previous implementation of the bootstrap-temacs rule.
6594 The bootstrap-temacs-CMD rule is similar to the previous
6595 implementation of the bootstrap-temacs rule except that it
6596 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6597 variable.
6598
6599 These changes, along with some changes to nt/configure.bat,
6600 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6601 earlier fix to add support for --cflags and --ldflags options
6602 that include quotes so that it works whether make uses cmd or
6603 sh as the shell.
6604
b4289b64
MA
66052011-05-06 Michael Albinus <michael.albinus@gmx.de>
6606
6607 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6608 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6609 is a constant.
6610 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6611 a string. Handle both cases.
6612 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6613 (Fdbus_register_method): Use Qinvalid_function.
6614
af4c0e28
JB
66152011-05-06 Juanma Barranquero <lekktu@gmail.com>
6616
6617 * makefile.w32-in: Update dependencies.
6618 (LISP_H): Add inttypes.h and stdin.h.
6619 (PROCESS_H): Add unistd.h.
6620
c51453d9
EZ
66212011-05-06 Eli Zaretskii <eliz@gnu.org>
6622
6623 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6624 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6625
8ff0ac3c 66262011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6627
4c4b566b
PE
6628 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6629
aab2b9b5
PE
6630 * term.c (vfatal): Remove stray call to va_end.
6631 It's not needed and the C Standard doesn't allow it here anyway.
6632
c378da0b
PE
6633 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6634 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6635
288b08c7
PE
6636 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6637 bytes.
6638
e3601888
PE
6639 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6640
db6c0e74
PE
6641 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6642
dd5963ea
PE
6643 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6644
88c9450f
PE
6645 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6646
2f9442b8
PE
6647 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6648
c032b5f8
PE
6649 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6650 * charset.c (Fdefine_charset_internal): Don't initialize
6651 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6652 32-bit int (Bug#8600).
a108c10b
PE
6653
6654 * lread.c (read_integer): Be more consistent with string-to-number.
6655 Use string_to_number to do the actual conversion; this avoids
6656 rounding errors and fixes some other screwups. Without this fix,
6657 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6658 (digit_to_number): Move earlier, for benefit of read_integer.
6659 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6660 not a digit in any supported base. (Bug#8602)
a108c10b 6661
ad5f9eea
PE
6662 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6663
aec1708a
PE
6664 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6665 to match comment at start of function. This also removes a
6666 GCC warning about overflow in a 32+64-bit port.
6667
47be4ab5
PE
6668 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6669
371cac43
PE
6670 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6671 Reported by Stefan Monnier in
6672 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6673 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6674 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6675
d01a7826
PE
6676 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6677 (EMACS_UINTPTR): Likewise, with uintptr_t.
6678
7fd47d5c
PE
6679 * lisp.h: Prefer 64-bit EMACS_INT if available.
6680 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6681 on 32-bit hosts that have 64-bit int, so that they can access
6682 large files.
122b0c86
PE
6683 However, temporarily disable this change unless the temporary
6684 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6685
8727937b
PE
6686 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6687
8ac068ac
PE
6688 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6689 This removes an assumption that EMACS_INT and long are the same
6690 width as pointers. The assumption is true for Emacs porting targets
6691 now, but we want to make other targets possible.
6692 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6693 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6694 In the rest of the code, change types of integers that hold casted
6695 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6696 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6697 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6698 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6699 No need to cast type when ORing.
6700 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6701 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6702 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6703 assume EMACS_INT is the same width as char *.
6704 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6705 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6706 Remove no-longer-needed casts.
6707 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6708 (xg_tool_bar_help_callback, xg_make_tool_item):
6709 Use EMACS_INTPTR to hold an integer
6710 that will be cast to void *; this can avoid a GCC warning
6711 if EMACS_INT is not the same width as void *.
6712 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6713 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6714 (current_message_1, set_message_1):
6715 Use a local to convert to proper width without a cast.
6716 * xmenu.c (dialog_selection_callback): Likewise.
6717
ede49d71
PE
6718 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6719 Also, don't assume VALBITS / RAND_BITS is less than 5,
6720 and don't rely on undefined behavior when shifting a 1 left into
6721 the sign bit.
6722 * lisp.h (get_random): Change signature to match.
6723
2f30ecd0
PE
6724 * lread.c (hash_string): Use size_t, not int, for hash computation.
6725 Normally we prefer signed values; but hashing is special, because
6726 it's better to use unsigned division on hash table sizes so that
6727 the remainder is nonnegative. Also, size_t is the natural width
6728 for hashing into memory. The previous code used 'int', which doesn't
6729 retain enough info to hash well into very large tables.
6730 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6731
2a866e7b
PE
6732 * dbusbind.c: Don't possibly lose pointer info when converting.
6733 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6734 Use XPNTR rather than XHASH, so that the high-order bits of
6735 the pointer aren't lost when converting through void *.
6736
51639eac
PE
6737 * eval.c (Fautoload): Don't double-shift a pointer.
6738
92394119
PE
6739 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6740
dbdb9a7c
JB
67412011-05-06 Juanma Barranquero <lekktu@gmail.com>
6742
6743 * gnutls.c (DEF_GNUTLS_FN):
6744 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6745
db7a0b4f
AS
67462011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6747
6748 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6749 marker. (Bug#8610)
6750
cd394be1 67512011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6752
6753 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6754 New version that can reserve upto 2GB of heap space.
6755
f7ff1b0f 67562011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6757
6758 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6759
639c109b
TZ
67602011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6761
6762 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6763 `gnutls_certificate_set_x509_key_file'.
6764
d2127135
JB
67652011-05-05 Juanma Barranquero <lekktu@gmail.com>
6766
6767 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6768 Update dependencies.
6769
e968f4f3
JB
67702011-05-04 Juanma Barranquero <lekktu@gmail.com>
6771
6772 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6773 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6774 Remove unused parameter `fildes'.
6775 * process.c (read_process_output, send_process): Don't pass it.
6776
84d358f0
JB
67772011-05-04 Juanma Barranquero <lekktu@gmail.com>
6778
6779 Fix previous change: the library cache is defined in w32.c.
6780 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6781 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6782
0898ca10
JB
67832011-05-04 Juanma Barranquero <lekktu@gmail.com>
6784
6785 Implement dynamic loading of GnuTLS on Windows.
6786
6787 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6788 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6789 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6790 Declare.
6791
6792 * gnutls.c (Qgnutls_dll): Define.
6793 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6794 (gnutls_*): Declare function pointers.
6795 (init_gnutls_functions): New function to initialize function pointers.
6796 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6797 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6798 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6799 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6800 (emacs_gnutls_write, emacs_gnutls_read)
6801 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6802 (Fgnutls_available_p): New function.
6803 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6804 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6805 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6806
6807 * image.c: Include w32.h.
6808 (Vimage_type_cache): Delete.
6809 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6810 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6811 (w32_delayed_load): Move to w32.c.
6812
6813 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6814
6815 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6816 (w32_delayed_load): Move from image.c. When loading a library, record
6817 its filename in the :loaded-from property of the library id.
6818 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6819 Initialize and staticpro them.
6820 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6821
6822 * process.c: Include lisp.h before w32.h, not after.
6823 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6824 instead of gnutls_record_check_pending.
6825
6826 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6827
ff4de4aa
TZ
68282011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6829
6830 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6831 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6832 as passed in.
6833
abe95abb
JD
68342011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6835
6836 * xterm.c (x_set_frame_alpha): Do not set property on anything
6837 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6838
e16e55d4
JB
68392011-05-02 Juanma Barranquero <lekktu@gmail.com>
6840
6841 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6842
bafcf6a5
JB
68432011-05-02 Juanma Barranquero <lekktu@gmail.com>
6844
6845 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6846 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6847 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6848 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6849 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6850 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6851 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6852 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6853 (Qgnutls_bootprop_callbacks_verify): Make static.
6854
e7a6747f
AS
68552011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6856
19ed11ba
AS
6857 * callproc.c: Indentation fixup.
6858
e7a6747f 6859 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6860 (wait_for_termination, interruptible_wait_for_termination):
6861 Move after wait_for_termination_1.
e7a6747f 6862
1ef14cb4
LMI
68632011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6864
6865 * sysdep.c (interruptible_wait_for_termination): New function
6866 which is like wait_for_termination, but allows keyboard
6867 interruptions.
6868
6869 * callproc.c (Fcall_process): Add (:file "file") as an option for
6870 the STDOUT buffer.
6871 (Fcall_process_region): Ditto.
6872
330d880c
EZ
68732011-04-30 Eli Zaretskii <eliz@gnu.org>
6874
8db90b73
EZ
6875 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6876 rather than `XVECTOR (FOO)->size'.
6877
330d880c
EZ
6878 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6879 inttypes.h, as a gnulib replacement is used if it not available in
6880 system headers.
6881
15cbd324
EZ
68822011-04-21 Eli Zaretskii <eliz@gnu.org>
6883
6884 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6885 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6886 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6887
6888 * coding.c (coding_alloc_by_realloc): Error out if destination
6889 will grow beyond MOST_POSITIVE_FIXNUM.
6890 (decode_coding_emacs_mule): Abort if there isn't enough place in
6891 charbuf for the composition carryover bytes. Reserve an extra
6892 space for up to 2 characters produced in a loop.
6893 (decode_coding_iso_2022): Abort if there isn't enough place in
6894 charbuf for the composition carryover bytes.
6895
68962011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6897
ae940cca
EZ
6898 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6899 aborting when %lld or %lll format is passed.
6900 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6901 %llo or %llx format is passed. (Bug#8545)
6902
03ab8921
EZ
6903 * window.c (window_scroll_line_based): Use a marker instead of
6904 simple variables to record original value of point. (Bug#7952)
6905
afda1437
EZ
6906 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6907 produced by %s or %c overflows available buffer space. (Bug#8545)
6908
f76dee0c
PE
69092011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6910
6911 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6912 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6913
fdc5744d
JB
69142011-04-28 Juanma Barranquero <lekktu@gmail.com>
6915
6916 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6917
638f053a
JB
69182011-04-28 Juanma Barranquero <lekktu@gmail.com>
6919
6920 * keyboard.c (Qdelayed_warnings_hook): Define.
6921 (command_loop_1): Run `delayed-warnings-hook'
6922 if Vdelayed_warnings_list is non-nil.
6923 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6924 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6925
d178f871
EZ
69262011-04-28 Eli Zaretskii <eliz@gnu.org>
6927
6928 * doprnt.c (doprnt): Don't return value smaller than the buffer
6929 size if the message was truncated. (Bug#8545).
6930
b124fd93
JB
69312011-04-28 Juanma Barranquero <lekktu@gmail.com>
6932
6933 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6934 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6935
e810457d
PE
69362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6939
ea51cceb
JB
69402011-04-27 Juanma Barranquero <lekktu@gmail.com>
6941
6942 * makefile.w32-in: Update dependencies.
6943
94dcfacf
EZ
69442011-04-27 Eli Zaretskii <eliz@gnu.org>
6945
6946 Improve `doprnt' and its usage. (Bug#8545)
6947 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6948 `format_end'. Remove support for %l as a conversion specifier.
6949 Don't use xrealloc. Improve diagnostics when the %l size modifier
6950 is used. Update the commentary.
6951
6952 * eval.c (verror): Simplify calculation of size_t.
6953
6954 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6955 messages.
6956
f61f41d7
PE
69572011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6958
6959 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6960 change.
6961
96fb4434
PE
69622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6963
6964 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6965 This makes this file independent of the recent pseudovector change.
6966
671875da 69672011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6968
69e9b5a3
PE
6969 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6970
b5f869a7 6971 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6972 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6973 Remove unused local.
c8926152 6974 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6975
841a1577 6976 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6977 GCC 4.6.0 optimizes based on type-based alias analysis.
6978 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6979 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6980 != &v->size, and therefore "v->size = 1; b->size = 2; return
6981 v->size;" must therefore return 1. This assumption is incorrect
6982 for Emacs, since it type-puns struct Lisp_Vector * with many other
6983 types. To fix this problem, this patch adds a new type struct
f904488f 6984 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6985 and pseudovectors, and helps optimizing compilers not get fooled
6986 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6987 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6988 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6989 the size member.
eab3844f
PE
6990 (XSETPVECTYPE): Rewrite in terms of new macro.
6991 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6992 This is a bit clearer, and further avoids the possibility of
6993 undesirable aliasing.
6994 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6995 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6996 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6997 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6998 (ASIZE): Now uses header.size rather than size.
6999 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7000 to avoid the hassle of writing XVECTOR (foo)->header.size.
7001 (struct vectorlike_header): New type.
eab3844f
PE
7002 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7003 object, to help avoid aliasing.
7004 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7005 (SUBRP): Likewise, since Lisp_Subr is a special case.
7006 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7007 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7008 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7009 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7010 changed to be "header.size" and "header.next".
7011 * buffer.h (struct buffer): Likewise.
7012 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7013 * frame.h (struct frame): Likewise.
7014 * process.h (struct Lisp_Process): Likewise.
7015 * termhooks.h (struct terminal): Likewise.
7016 * window.c (struct save_window_data, struct saved_window): Likewise.
7017 * window.h (struct window): Likewise.
7018 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7019 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7020 * buffer.c (init_buffer_once): Likewise.
7021 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7022 special case.
7023 * process.c (Fformat_network_address): Use local var for size,
7024 for brevity.
7025
0df1eac5
PE
7026 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7027
847ab9d1 7028 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7029 * data.c (atof): Remove decl; no longer used or needed.
7030 (digit_to_number): Move to lread.c.
7031 (Fstring_to_number): Use new string_to_number function, to be
7032 consistent with how the Lisp reader treats infinities and NaNs.
7033 Do not assume that floating-point numbers represent EMACS_INT
7034 without losing information; this is not true on most 64-bit hosts.
7035 Avoid double-rounding errors, by insisting on integers when
7036 parsing non-base-10 numbers, as the documentation specifies.
7037 * lisp.h (string_to_number): New decl, replacing ...
7038 (isfloat_string): Remove.
bc0a5c13 7039 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7040 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7041 appears to have been a coding error. Similarly, do not accept
7042 strings like +-1e0 as floating point numbers. Do not report
7043 overflow for integer overflows unless the base is not 10 which
7044 means we have no simple and reliable way to continue.
7045 Break out the floating-point parsing into a new
7046 function string_to_number, so that Fstring_to_number parses
7047 floating point numbers consistently with the Lisp reader.
04f2d78b 7048 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7049 (E_CHAR, EXP_INT): Remove, replacing with ...
7050 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7051 (string_to_number): New function, replacing isfloat_string.
7052 This function checks for valid syntax and produces the resulting
7053 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7054 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7055 so that overflow for non-base-10 numbers is reported only when
7056 there's no portable and simple way to convert to floating point.
452f4150 7057
67769ffc
PE
7058 * textprop.c (set_text_properties_1): Rewrite for clarity,
7059 and to avoid GCC warning about integer overflow.
7060
c20db43f
PE
7061 * intervals.h (struct interval): Use EMACS_INT for members
7062 where EMACS_UINT might cause problems. See
7063 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7064 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7065 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7066 All uses changed.
37aa2f85
PE
7067 (offset_intervals): Tell GCC not to worry about length overflow
7068 when negating a negative length.
c20db43f 7069
2538aa2f
PE
7070 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7071 (overrun_check_free): Likewise.
7072
f2d3008d
PE
7073 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7074 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7075 word size.
7076
ec8df744
PE
7077 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7078 (gnutls_make_error): Rename local to avoid shadowing.
7079 (gnutls_emacs_global_deinit): ifdef out; not used.
7080 (Fgnutls_boot): Use const for pointer to readonly storage.
7081 Comment out unused local. Fix pointer signedness problems.
7082
640ee02d
PE
7083 * lread.c (openp): Don't stuff size_t into an 'int'.
7084 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7085 about possible signed overflow.
7086
6048fb2a
PE
7087 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7088 (GDK_KEY_g): Don't define if already defined.
7089 (xg_prepare_tooltip): Avoid pointer signedness problem.
7090 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7091
fa3c87e1
PE
7092 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7093 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7094
2172544b
PE
7095 * xfns.c (Fx_window_property): Simplify a bit,
7096 to make a bit faster and to avoid GCC 4.6.0 warning.
7097 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7098
9b821a21
PE
7099 * fns.c (internal_equal): Don't assume size_t fits in int.
7100
3c616cfa
PE
7101 * alloc.c (compact_small_strings): Tighten assertion a little.
7102
c2982e87
PE
7103 Replace pEd with more-general pI, and fix some printf arg casts.
7104 * lisp.h (pI): New macro, generalizing old pEd macro to other
7105 conversion specifiers. For example, use "...%"pI"d..." rather
7106 than "...%"pEd"...".
7107 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7108 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7109 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7110 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7111 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7112 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7113 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7114 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7115 64-bit hosts.
7116 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7117 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7118 * print.c (safe_debug_print, print_object): Likewise.
7119 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7120 to int.
6f04d126
PE
7121 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7122 avoiding the 0 flag, which is not portable.
c2982e87
PE
7123 * process.c (Fmake_network_process): Use pI to avoid cast.
7124 * region-cache.c (pp_cache): Likewise.
7125 * xdisp.c (decode_mode_spec): Likewise.
7126 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7127 behavior on 64-bit hosts with printf arg.
6f04d126 7128 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7129 (x_stop_queuing_selection_requests): Likewise.
7130 (x_get_window_property): Don't truncate byte count to an 'int'
7131 when tracing.
0b432f21 7132
5e073ec7
PE
7133 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7134 here, since it parses constructs like leading '-' and spaces,
7135 which are not wanted; and it overflows with large numbers.
7136 Instead, simply match F[0-9]+, which is what is wanted anyway.
7137
36372bf9
PE
7138 * alloc.c: Remove unportable assumptions about struct layout.
7139 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7140 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7141 (allocate_vectorlike, make_pure_vector): Use the new macros,
7142 plus offsetof, to remove unportable assumptions about struct layout.
7143 These assumptions hold on all porting targets that I know of, but
7144 they are not guaranteed, they're easy to remove, and removing them
7145 makes further changes easier.
7146
0b432f21
PE
7147 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7148 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7149 (string_overrun_cookie): Now const. Use initializers that
7150 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7151 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7152 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7153 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7154 multiple of sizeof (EMACS_INT); it need not be, if
7155 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7156 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7157
895009e1
JB
71582011-04-26 Juanma Barranquero <lekktu@gmail.com>
7159
7160 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7161
6a7a1b0b
TZ
71622011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7163
7164 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7165 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7166 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7167
841a1577 71682011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7169
7170 * lisp.h (Qdebug): List symbol.
895009e1 7171 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7172 * keyboard.c (debug-on-event): New variable.
7173 (handle_user_signal): Break into debugger when debug-on-event
7174 matches the current signal symbol.
7175
f2d3ba6f
DN
71762011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7177
7178 * alloc.c (check_sblock, check_string_bytes)
7179 (check_string_free_list): Convert to standard C.
7180
42ce4c63
TZ
71812011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7182
7183 * w32.c (emacs_gnutls_push): Fix typo.
7184
825cd63c
EZ
71852011-04-25 Eli Zaretskii <eliz@gnu.org>
7186
fb11d64d
EZ
7187 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7188 "cast to pointer from integer of different size".
7189
825cd63c
EZ
7190 Improve doprnt and its use in verror. (Bug#8545)
7191 * doprnt.c (doprnt): Document the set of format control sequences
7192 supported by the function. Use SAFE_ALLOCA instead of always
7193 using `alloca'.
7194
7195 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7196 is one byte too soon. Don't use xrealloc; instead xfree and
7197 xmalloc anew.
7198
e061a11b
TZ
71992011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7200
7201 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7202 callbacks stage.
7203
7204 * gnutls.c: Renamed global_initialized to
7205 gnutls_global_initialized. Added internals for the
7206 :verify-hostname-error, :verify-error, and :verify-flags
7207 parameters of `gnutls-boot' and documented those parameters in the
7208 docstring. Start callback support.
9173deec
JB
7209 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7210 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7211 on error. Return error code.
e061a11b
TZ
7212 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7213 (emacs_gnutls_read): Likewise.
7214 (Fgnutls_boot): Return handshake error code.
7215 (emacs_gnutls_handle_error): New function.
7216 (wsaerror_to_errno): Likewise.
7217
7218 * w32.h (emacs_gnutls_pull): Add prototype.
7219 (emacs_gnutls_push): Likewise.
7220
7221 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7222 (emacs_gnutls_push): Likewise.
7223
72242011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7225
7226 * process.c (wait_reading_process_output): Check if GnuTLS
7227 buffered some data internally if no FDs are set for TLS
7228 connections.
7229
7230 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7231 (LIBS): Link to USER_LIBS.
7232 ($(BLD)/gnutls.$(0)): New target.
7233
fa6996bc
EZ
72342011-04-24 Eli Zaretskii <eliz@gnu.org>
7235
eb35682e
EZ
7236 * xdisp.c (handle_single_display_spec): Rename the
7237 display_replaced_before_p argument into display_replaced_p, to
7238 make it consistent with the commentary. Fix typos in the
7239 commentary.
7240
e2ad650c
EZ
7241 * textprop.c (syms_of_textprop): Remove dead code.
7242 (copy_text_properties): Delete obsolete commentary about an
7243 interface that was deleted long ago. Fix typos in the description
7244 of arguments.
7245
1b2de274
EZ
7246 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7247 to changes in oldXMenu/XMenu.h from 2011-04-16.
7248 <menu_help_message, prev_menu_help_message>: Constify.
7249 (IT_menu_make_room): menu->help_text is now `const char **';
7250 adjust.
7251
7252 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7253 to changes in oldXMenu/XMenu.h from 2011-04-16.
7254 (struct XMenu): Declare `help_text' `const char **'.
7255
7256 * xfaces.c <Qunspecified>: Make extern again.
7257
7258 * syntax.c: Include sys/types.h before including regex.h, as
7259 required by Posix.
7260
762b15be
EZ
7261 * doc.c (get_doc_string): Improve the format passed to `error'.
7262
7263 * doprnt.c (doprnt): Improve commentary.
7264
7265 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7266
7267 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7268 them with etags.
7269
f1052e5d
EZ
7270 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7271 changes in globals.h immediately force recompilation.
762b15be
EZ
7272 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7273 $(CURDIR)/s/ms-w32.h.
7274 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7275
fa6996bc
EZ
7276 * character.c (Fchar_direction): Function deleted.
7277 (syms_of_character): Don't defsubr it.
7278 <char-direction-table>: Deleted.
7279
e6c3da20
EZ
72802011-04-23 Eli Zaretskii <eliz@gnu.org>
7281
7282 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7283 * doprnt.c: Include limits.h.
7284 (SIZE_MAX): New macro.
04f2d78b
CB
7285 (doprnt): Return a size_t value. 2nd arg is now size_t.
7286 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7287 Improve overflow protection. Support `l' modifier for integer
7288 conversions. Support %l conversion. Don't assume an EMACS_INT
7289 argument for integer conversions and for %c.
7290
7291 * lisp.h (doprnt): Restore prototype.
7292
7293 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7294 $(SRC)/character.h.
7295
7296 * Makefile.in (base_obj): Add back doprnt.o.
7297
7298 * deps.mk (doprnt.o): Add back prerequisites.
7299 (callint.o): Depend on character.h.
7300
7301 * eval.c (internal_lisp_condition_case): Include the handler
7302 representation in the error message.
7303 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7304 when breaking from the loop.
7305
7306 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7307
7308 * callint.c (Fcall_interactively): When displaying error message
7309 about invalid control letter, pass the character's codepoint, not
7310 a pointer to its multibyte form. Improve display of the character
7311 in octal and display also its hex code.
7312
7313 * character.c (char_string): Use %x to display the (unsigned)
7314 codepoint of an invalid character, to avoid displaying a bogus
7315 negative value.
7316
7317 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7318 `error', not SYMBOL_NAME itself.
7319
7320 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7321 character arguments to `error'.
7322
7323 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7324 to `error' in error message about FINAL_CHAR argument. Make sure
7325 FINAL_CHAR is a character, and use %c when it is passed as
7326 argument to `error'.
7327
4ffd0d6b 73282011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7329
7330 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7331
7332 * w32.c: Include <time.h>.
7333 (sys_localtime): New function.
7334
4ffd0d6b 73352011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7336
7337 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7338
4ffd0d6b 7339 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7340
4ffd0d6b 73412011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7342
4ffd0d6b
GM
7343 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7344 zombies (Bug#8467).
aac0c6e3 7345
04c56954
EZ
73462011-04-19 Eli Zaretskii <eliz@gnu.org>
7347
7348 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7349 gl_state.e_property when gl_state.object is Qt.
7350
7351 * insdel.c (make_gap_larger): Remove limitation of buffer size
7352 to <= INT_MAX.
7353
16a43933
CY
73542011-04-18 Chong Yidong <cyd@stupidchicken.com>
7355
7356 * xdisp.c (lookup_glyphless_char_display)
7357 (produce_glyphless_glyph): Handle cons cell entry in
7358 glyphless-char-display.
7359 (Vglyphless_char_display): Document it.
7360
7361 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7362 glyphless-char-display.
7363
4581706e
CY
73642011-04-17 Chong Yidong <cyd@stupidchicken.com>
7365
7366 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7367
7368 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7369
7370 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7371 definition for no-X builds.
7372
4887c6e2 73732011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7374
fd35b6f9
PE
7375 Static checks with GCC 4.6.0 and non-default toolkits.
7376
5c1ccb01
PE
7377 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7378
006c5daa
PE
7379 * process.c (keyboard_bit_set): Define only if SIGIO.
7380 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7381 (send_process): Repair possible setjmp clobbering.
7382
efc736d3
PE
7383 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7384
4e2fe2e6
PE
7385 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7386
f97334a2
PE
7387 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7388
4e75f29d
PE
7389 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7390 Define only if needed.
7391
90efadd1
PE
7392 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7393 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7394 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7395
3c647824
PE
7396 * dispextern.h (struct redisplay_interface): Rename param
7397 to avoid shadowing.
e264f262 7398 * termhooks.h (struct terminal): Likewise.
761383f4 7399 * xterm.c (xembed_send_message): Likewise.
3c647824 7400
b58c5c4a
PE
7401 * insdel.c (make_gap_smaller): Define only if
7402 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7403
cad59032
PE
7404 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7405 it.
7406
c339dc2e
PE
7407 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7408 so that we aren't warned about unused symbols.
7409
91a3e27b
PE
7410 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7411
399c71d3 7412 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7413
8ffc96f5
PE
7414 * xfns.c (x_real_positions): Mark locals as initialized.
7415
eef9bc79
PE
7416 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7417
098db9dd
PE
7418 * xterm.c: Fix problems found by static analysis with other toolkits.
7419 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7420 (x_dispatch_event): Declare static if USE_GTK, and
7421 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7422 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7423 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7424 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7425 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7426
eb18f6cc
PE
7427 * xmenu.c (menu_help_callback): Pointer type fixes.
7428 Use const pointers when pointing at readonly data. Avoid pointer
7429 signedness clashes.
7430 (FALSE): Remove unused macro.
7431 (update_frame_menubar): Remove unused decl.
7432
1fe72bf8
PE
7433 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7434
60d9e1db
PE
7435 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7436 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7437 (single_menu_item): Rename local to avoid shadowing.
7438
39261c26
PE
7439 * keyboard.c (make_lispy_event): Remove unused local var.
7440
018c5e19
PE
7441 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7442 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7443
63d2b86e
PE
7444 * bitmaps: Change bitmaps from unsigned char back to the X11
7445 compatible char. Avoid the old compiler warnings about
7446 out-of-range initializers by using, for example, '\xab' rather
7447 than 0xab.
7448
aefd87e1
PE
7449 * xgselect.c (xgselect_initialize): Check vs interface
7450 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7451
bf501fb9
PE
7452 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7453
e9829fdf
PE
7454 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7455 to read-only memory.
7456
1086c095
PE
7457 * fns.c (vector): Remove; this old hack is no longer needed.
7458
2baccd04 7459 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7460 Remove unused var.
dde42981 7461 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7462
72391843 7463 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7464
436c16df 7465 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7466 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7467 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7468
92bb796d 7469 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7470 (x_term_init): Remove local to avoid shadowing.
92bb796d 7471
764430a3 7472 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7473
7474 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7475 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7476
d1dfb56c
EZ
74772011-04-16 Eli Zaretskii <eliz@gnu.org>
7478
c4354cb4
EZ
7479 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7480
d1dfb56c
EZ
7481 Fix regex.c, syntax.c and friends for buffers > 2GB.
7482 * syntax.h (struct gl_state_s): Declare character position members
7483 EMACS_INT.
7484
7485 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7486
04f2d78b
CB
7487 * textprop.c (verify_interval_modification, interval_of):
7488 Declare arguments EMACS_INT.
d1dfb56c
EZ
7489
7490 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7491 EMACS_INT.
7492
7493 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7494
7495 * indent.c (Fvertical_motion): Local variable it_start is now
7496 EMACS_INT.
7497
7498 * regex.c (re_match, re_match_2, re_match_2_internal)
7499 (bcmp_translate, regcomp, regexec, print_double_string)
7500 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7501 (re_compile_pattern, re_exec): Declare arguments and local
7502 variables `size_t' and `ssize_t' and return values `regoff_t', as
7503 appropriate.
7504 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7505 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7506 <compile_stack_type>: `size' and `avail' are now `size_t'.
7507
7508 * regex.h <regoff_t>: Use ssize_t, not int.
7509 (re_search, re_search_2, re_match, re_match_2): Arguments that
7510 specify buffer/string position and length are now ssize_t and
7511 size_t. Return type is regoff_t.
7512
613052cd
BK
75132011-04-16 Ben Key <bkey76@gmail.com>
7514
7515 * nsfont.m: Fixed bugs in ns_get_family and
7516 ns_descriptor_to_entity that were caused by using free to
7517 deallocate memory blocks that were allocated by xmalloc (via
7518 xstrdup). This caused Emacs to crash when compiled with
7519 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7520 --enable-checking=xmallocoverrun). xfree is now used to
7521 deallocate these memory blocks.
7522
4170f62f 75232011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7524
71b41406
PE
7525 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7526
9587a89d
PE
7527 emacs_write: Accept and return EMACS_INT for sizes.
7528 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7529 et seq.
7530 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7531 Accept and return EMACS_INT.
7532 (emacs_gnutls_write): Return the number of bytes written on
7533 partial writes.
7534 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7535 (emacs_read, emacs_write): Remove check for negative size, as the
7536 Emacs source code has been audited now.
9587a89d
PE
7537 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7538 (emacs_read, emacs_write): Use it.
273a5f82
PE
7539 * process.c (send_process): Adjust to the new signatures of
7540 emacs_write and emacs_gnutls_write. Do not attempt to store
7541 a byte offset into an 'int'; it might overflow.
9587a89d 7542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7543
3e047f51
PE
7544 * sound.c: Don't assume sizes fit in 'int'.
7545 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7546 Return EMACS_INT, not int.
3e047f51 7547 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7548 Accept EMACS_INT, not int.
7549 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7550 record read return values.
7551
cc39a9db
BK
75522011-04-15 Ben Key <bkey76@gmail.com>
7553
c9d0ec6d
JB
7554 * keyboard.c (Qundefined): Don't declare static since it is used
7555 in nsfns.m.
7556 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7557 static since they are used in nsfont.m.
cc39a9db 7558
6c60eb9f
SM
75592011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7560
7561 * process.c (Qprocessp): Don't declare static.
7562 * lisp.h (Qprocessp): Declare again.
7563
7990b61a
JB
75642011-04-15 Juanma Barranquero <lekktu@gmail.com>
7565
7566 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7567
5d4cb038
PE
75682011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7569
8bd7b830 7570 Improve C-level modularity by making more things 'static'.
cd64ea1d 7571
e3b27b31
PE
7572 Don't publish debugger-only interfaces to other modules.
7573 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7574 (verify_bytepos, count_markers): Move decls to the only modules
7575 that need them.
7576 * region-cache.h (pp_cache): Likewise.
7577 * window.h (check_all_windows): Likewise.
7578 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7579
5d4cb038
PE
7580 * sysdep.c (croak): Now static, if
7581 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7582 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7583
7584 * alloc.c (refill_memory_reserve): Now static if
7585 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7586 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7587
e87b6180
PE
7588 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7589 Define only if USE_LUCID.
7590
ac64929e
PE
7591 * xrdb.c (x_customization_string, x_rm_string): Now static.
7592
6f37259d
PE
7593 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7594 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7595
1683e3ab
PE
7596 * xdisp.c (draw_row_with_mouse_face): Now static.
7597 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7598
de9c2632
PE
7599 * window.h (check_all_windows): Mark externally visible.
7600
2b96acb7
PE
7601 * window.c (window_deletion_count): Now static.
7602
7603 * undo.c: Make symbols static if they're not exported.
7604 (last_undo_buffer, last_boundary_position, pending_boundary):
7605 Now static.
7606
50436f33
PE
7607 * textprop.c (interval_insert_behind_hooks): Now static.
7608 (interval_insert_in_front_hooks): Likewise.
7609
64520e5c
PE
7610 * term.c: Make symbols static if they're not exported.
7611 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7612 (max_frame_lines, tty_set_terminal_modes):
7613 (tty_reset_terminal_modes, tty_turn_off_highlight):
7614 (get_tty_terminal): Now static.
7615 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7616 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7617 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7618 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7619 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7620
1fa53021
PE
7621 * sysdep.c: Make symbols static if they're not exported.
7622 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7623 Now static.
7624 (sigprocmask_set, full_mask): Remove; unused.
7625 (wait_debugging): Mark as visible.
7626 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7627 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7628
d4b43b22
PE
7629 * syntax.c (syntax_temp): Define only if !__GNUC__.
7630
b7c513d0
PE
7631 * sound.c (current_sound_device, current_sound): Now static.
7632
989b29ad
PE
7633 * search.c (searchbufs, searchbuf_head): Now static.
7634
13a55a78
PE
7635 * scroll.c (scroll_cost): Remove; unused.
7636 * dispextern.h (scroll_cost): Remove decl.
7637
de68a1fc
PE
7638 * region-cache.h (pp_cache): Mark as externally visible.
7639
40ccffa6
PE
7640 * process.c: Make symbols static if they're not exported.
7641 (process_tick, update_tick, create_process, chan_process):
7642 (Vprocess_alist, proc_buffered_char, datagram_access):
7643 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7644 (deactivate_process): Mark defn as static, as well as decl.
7645 * lisp.h (create_process): Remove decl.
7646 * process.h (chan_process, Vprocess_alist): Remove decls.
7647
ad64fc97
PE
7648 * print.c: Make symbols static if they're not exported.
7649 (print_depth, new_backquote_output, being_printed, print_buffer):
7650 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7651 (print_interval, print_number_index, initial_stderr_stream):
7652 Now static.
7653 * lisp.h (Fprinc): Remove decl.
7654 (debug_output_compilation_hack): Mark as externally visible.
7655
adddb265
PE
7656 * sysdep.c (croak): Move decl from here to syssignal.h.
7657 * syssignal.h (croak): Put it here, so the API can be checked when
7658 'croak' is called from dissociate_if_controlling_tty.
7659
1717ede2
PE
7660 * minibuf.c: Make symbols static if they're not exported.
7661 (minibuf_save_list, choose_minibuf_frame): Now static.
7662 * lisp.h (choose_minibuf_frame): Remove decl.
7663
fa5fb2bc
PE
7664 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7665
1e3890d1
PE
7666 * lread.c: Make symbols static if they're not exported.
7667 (read_objects, initial_obarray, oblookup_last_bucket_number):
7668 Now static.
7669 (make_symbol): Remove; unused.
7670 * lisp.h (initial_obarray, make_symbol): Remove decls.
7671
8a1414fa
PE
7672 * keyboard.c: Make symbols static if they're not exported.
7673 (single_kboard, recent_keys_index, total_keys, recent_keys):
7674 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7675 (this_single_command_key_start, echoing, last_auto_save):
7676 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7677 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7678 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7679 (Vlispy_mouse_stem, double_click_count):
7680 Now static.
7681 (force_auto_save_soon): Define only if SIGDANGER.
7682 (ignore_mouse_drag_p): Now static if
7683 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7684 (print_help): Remove; unused.
7685 (stop_character, last_timer_event): Mark as externally visible.
7686 * keyboard.h (ignore_mouse_drag_p): Declare only if
7687 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7688 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7689 * lisp.h (echoing): Remove decl.
7690 (force_auto_save_soon): Declare only if SIGDANGER.
7691 * xdisp.c (redisplay_window): Simplify code, to make it more
7692 obvious that ignore_mouse_drag_p is not accessed if !defined
7693 USE_GTK && !defined HAVE_NS.
7694
93ea6e8f
PE
7695 * intervals.c: Make symbols static if they're not exported.
7696 (merge_properties_sticky, merge_interval_right, delete_interval):
7697 Now static.
7698 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7699
77382fcc
PE
7700 * insdel.c: Make symbols static if they're not exported.
7701 However, leave prepare_to_modify_buffer alone. It's never
7702 called from outside this function, but that appears to be a bug.
7703 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7704 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7705 (adjust_after_replace_noundo): Remove; unused.
7706 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7707 (signal_before_change): Remove decls.
77382fcc 7708
9306c32e
PE
7709 * indent.c (val_compute_motion, val_vmotion): Now static.
7710
cd44d2eb
PE
7711 * image.c: Make symbols static if they're not exported.
7712 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7713 if USE_GTK.
7714 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7715 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7716
ad9a7a06
PE
7717 * fringe.c (standard_bitmaps): Now static.
7718 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7719
81626931
PE
7720 * frame.c: Make symbols static if they're not exported.
7721 (x_report_frame_params, make_terminal_frame): Now static.
7722 (get_frame_param): Now static, unless HAVE_NS.
7723 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7724 (x_get_resource_string): Remove; not used.
7725 * frame.h (make_terminal_frame, x_report_frame_params):
7726 (x_get_resource_string); Remove decls.
7727 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7728 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7729
239f9db9
PE
7730 * font.c, fontset.c: Make symbols static if they're not exported.
7731 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7732 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7733 * font.c (font_close_object): Now static.
7734 * font.h (font_close_object): Remove.
7735 * fontset.c (FONTSET_OBJLIST): Remove.
7736 (free_realized_fontset) #if-0 the body, which does nothing.
7737 (face_suitable_for_char_p): #if-0, as it's never called.
7738 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7739 * xfaces.c (face_at_string_position):
7740 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7741 since 0 is always ASCII.
7742
dfcf3579
PE
7743 * fns.c (weak_hash_tables): Now static.
7744
5045092b
PE
7745 * fileio.c: Make symbols static if they're not exported.
7746 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7747 (Vwrite_region_annotation_buffers): Now static.
7748
57a96f5c
PE
7749 * eval.c: Make symbols static if they're not exported.
7750 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7751 * lisp.h (backtrace_list): Remove decl.
7752
35f08c38
PE
7753 * emacs.c: Make symbols static if they're not exported.
7754 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7755 (fatal_error_code, fatal_error_signal_hook, standard_args):
7756 Now static.
7757 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7758 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7759 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7760 * lisp.h (fatal_error_signal_hook): Remove decl.
7761 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7762
f44bd759
PE
7763 * editfns.c: Move a (normally-unused) function to its only use.
7764 * editfns.c, lisp.h (get_operating_system_release): Remove.
7765 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7766 worth the hassle of breaking this out.
7767
b532497d
PE
7768 * xterm.c: Make symbols static if they're not exported.
7769 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7770 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7771 (x_destroy_window, x_delete_display):
7772 Now static.
7773 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7774 (x_mouse_leave): Remove; unused.
7775 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7776 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7777 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7778 Remove decls.
7779 (x_mouse_leave): Declare only if WINDOWSNT.
7780 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7781 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7782 USE_X_TOOLKIT.
7783
1675728f
PE
7784 * ftxfont.c: Make symbols static if they're not exported.
7785 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7786 HAVE_FREETYPE.
7787 * font.h (ftxfont_driver): Likewise.
7788
e4cebfca
PE
7789 * xfns.c: Make symbols static if they're not exported.
7790 (x_last_font_name, x_display_info_for_name):
7791 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7792 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7793 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7794 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7795 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7796 (last_show_tip_args): Now static.
7797 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7798 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7799 (x_screen_planes): Remove; unused.
7800 * dispextern.h (x_screen_planes): Remove decl.
7801
5bf46f05
PE
7802 * dispnew.c: Make symbols static if they're not exported.
7803 * dispextern.h (redraw_garbaged_frames, scrolling):
7804 (increment_row_positions): Remove.
7805 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7806 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7807 Now static.
7808 (redraw_garbaged_frames): Remove; unused.
7809
435f4c28
PE
7810 * xfaces.c: Make symbols static if they're not exported.
7811 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7812 Remove decls.
7813 * xterm.h (defined_color): Remove decls.
7814 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7815 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7816 (menu_face_changed_default, defined_color, free_realized_face):
7817 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7818 (ascii_face_of_lisp_face): Remove; unused.
7819
8524aef3
PE
7820 * xdisp.c: Make symbols static if they're not exported.
7821 * dispextern.h (scratch_glyph_row, window_box_edges):
7822 (glyph_to_pixel_coords, set_cursor_from_row):
7823 (get_next_display_element, set_iterator_to_next):
7824 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7825 (show_mouse_face): Remove decls
7826 * frame.h (message_buf_print): Likewise.
7827 * lisp.h (pop_message, set_message, check_point_in_composition):
7828 Likewise.
7829 * xterm.h (set_vertical_scroll_bar): Likewise.
7830 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7831 (message_buf_print, scratch_glyph_row, displayed_buffer):
7832 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7833 (get_next_display_element, show_mouse_face, window_box_edges):
7834 (frame_to_window_pixel_xy, check_point_in_composition):
7835 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7836 (glyph_to_pixel_coords): Remove; unused.
7837
16390cd2
PE
7838 * dired.c (file_name_completion): Now static.
7839
7840 * dbusbind.c (xd_in_read_queued_messages): Now static.
7841
a25f4dfa
PE
7842 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7843 * data.c (circular_list_error): Remove.
7844
14a9c8df
PE
7845 * commands.h (last_point_position, last_point_position_buffer):
7846 (last_point_position_window): Remove decls.
7847 * keyboard.c: Make these variables static.
7848
04f2d78b
CB
7849 * coding.h (coding, code_convert_region, encode_coding_gap):
7850 Remove decls.
74ab6df5
PE
7851 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7852 (iso_code_class, detect_coding, code_convert_region): Now static.
7853 (encode_coding_gap): Remove; unused.
7854
38dfbee1
PE
7855 * chartab.c (chartab_chars, chartab_bits): Now static.
7856
a2cb4e63
PE
7857 * charset.h (charset_iso_8859_1): Remove decl.
7858 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7859 Now static.
7860
127198fd
PE
7861 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7862 * ccl.c (Vccl_program_table): Now static.
7863 (check_ccl_update): Remove; unused.
7864
d85b608f
PE
7865 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7866 * category.h: ... from here.
7867 * category.c (check_category_table, set_category_set): Now static.
7868
31cd66f3
PE
7869 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7870 * lisp.h: Remove these decls.
7871
c358e587
PE
7872 * buffer.c (buffer_count): Remove unused var.
7873
e78aecca
PE
7874 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7875 so that it's not optimized away.
7876 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7877 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7878 exported only to the debugger.
7879
e192d7d3 7880 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7881 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7882
92470028
PE
7883 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7884 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7885 was inaccessible from Lisp.
7886 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7887 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7888
244ed907
PE
7889 alloc.c: Import and export fewer symbols, and remove unused items.
7890 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7891 is defined.
7892 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7893 it's not optimized away by whole-program optimization.
7894 (message_enable_multibyte, free_misc): Remove.
7895 (catchlist, handlerlist, mark_backtrace):
7896 Declare only if BYTE_MARK_STACK.
7897 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7898 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7899 (message_enable_multibyte): Remove decl.
7900 (free_misc, interval_free_list, float_block, float_block_index):
7901 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7902 (cons_free_list, last_marked_index):
7903 Now static.
7904 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7905 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7906 (mark_backtrace): Define only if BYTE_MARK_STACK.
7907 * xdisp.c (message_enable_multibyte): Now static.
7908
61c2b50e 7909 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7910 This makes it easier for human readers (and static analyzers)
7911 to see whether these variables are used from other modules.
7912 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7913 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7914 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7915 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7916 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7917 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7918 * xmenu.c, xselect.c:
7919 Declare Q* vars static if they are not used in other modules.
7920 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7921 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7922 Remove decls of unexported vars.
7923 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7924
95c82688
PE
7925 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7926
16a97296
PE
7927 Make Emacs functions such as Fatom 'static' by default.
7928 This makes it easier for human readers (and static analyzers)
7929 to see whether these functions can be called from other modules.
7930 DEFUN now defines a static function. To make the function external
7931 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7932 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7933 (Finit_image_library):
16a97296
PE
7934 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7935 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7936 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7937 Remove decls, since these functions are now static.
7938 (Funintern, Fget_internal_run_time): New decls, since these functions
7939 were already external.
95c82688 7940
16a97296
PE
7941 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7942 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7943 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7944 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7945 * keyboard.c, keymap.c, lread.c:
7946 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7947 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7948 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7949 Mark functions with DEFUE instead of DEFUN,
7950 if they are used in other modules.
7951 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7952 decls for now-static functions.
7953 * buffer.h (Fdelete_overlay): Remove decl.
7954 * callproc.c (Fgetenv_internal): Mark as internal.
7955 * composite.c (Fremove_list_of_text_properties): Remove decl.
7956 (Fcomposition_get_gstring): New forward static decl.
7957 * composite.h (Fcomposite_get_gstring): Remove decl.
7958 * dired.c (Ffile_attributes): New forward static decl.
7959 * doc.c (Fdocumntation_property): New forward static decl.
7960 * eval.c (Ffetch_bytecode): New forward static decl.
7961 (Funintern): Remove extern decl; now in .h file where it belongs.
7962 * fileio.c (Fmake_symbolic_link): New forward static decl.
7963 * image.c (Finit_image_library): New forward static decl.
7964 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7965 * intervals.h (Fprevious_property_change):
7966 (Fremove_list_of_text_properties): Remove decls.
7967 * keyboard.c (Fthis_command_keys): Remove decl.
7968 (Fcommand_execute): New forward static decl.
7969 * keymap.c (Flookup_key): New forward static decl.
7970 (Fcopy_keymap): Now static.
7971 * keymap.h (Flookup_key): Remove decl.
7972 * process.c (Fget_process): New forward static decl.
7973 (Fprocess_datagram_address): Mark as internal.
7974 * syntax.c (Fsyntax_table_p): New forward static decl.
7975 (skip_chars): Remove duplicate decl.
7976 * textprop.c (Fprevious_property_change): New forward static decl.
7977 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7978 Now internal.
7979 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7980 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7981
785bbd42
PE
7982 * editfns.c (Fformat): Remove unreachable code.
7983
8b913b57
AS
79842011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7985
7986 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7987 change. (Bug#8496)
7988
a6744a35
EZ
79892011-04-13 Eli Zaretskii <eliz@gnu.org>
7990
7991 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7992 when at ZV. (Bug#8487)
7993
e7974947
AS
79942011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7995
baad03f0
AS
7996 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7997 (Bug#8437)
7998 * keyboard.c (parse_tool_bar_item): Likewise.
7999 * sound.c (sound_cleanup, alsa_close): Likewise.
8000 * termcap.c (tgetent): Likewise.
8001 * xfns.c (x_default_font_parameter): Likewise.
8002 * xsettings.c (read_and_apply_settings): Likewise.
8003
e7974947
AS
8004 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8005 (overrun_check_free): Protoize.
8006
28272684
PE
80072011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8008
8009 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8010 since callers should never pass a negative size.
8011 Change the signature to match that of plain 'read' and 'write'; see
8012 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8013 * lisp.h: Update prototypes of emacs_write and emacs_read.
8014
11997c76
EZ
80152011-04-11 Eli Zaretskii <eliz@gnu.org>
8016
8017 * xdisp.c (redisplay_window): Don't try to determine the character
8018 position of the scroll margin if the window start point w->startp
e896f03c 8019 is outside the buffer's accessible region. (Bug#8468)
11997c76 8020
8a2cbd72
EZ
80212011-04-10 Eli Zaretskii <eliz@gnu.org>
8022
8023 Fix write-region and its subroutines for buffers > 2GB.
8024 * fileio.c (a_write, e_write): Modify declaration of arguments and
8025 local variables to support buffers larger than 2GB.
8026 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8027
8028 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8029 argument, local variables, and return value.
8030
8031 * lisp.h: Update prototypes of emacs_write and emacs_read.
8032
8033 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8034
4073e537 80352011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8036
1ebfdcb6
PE
8037 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8038
b2ded58d
PE
8039 Fix more problems found by GCC 4.6.0's static checks.
8040
7d66342c
PE
8041 * xdisp.c (vmessage): Use a better test for character truncation.
8042
bbf47d44
PE
8043 * charset.c (load_charset_map): <, not <=, for optimization,
8044 and to avoid potential problems with integer overflow.
9248994d 8045 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8046 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8047 * editfns.c (Fformat): Likewise.
1e69125e 8048 * syntax.c (skip_chars): Likewise.
3befa583 8049
e3019616
PE
8050 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8051 This also lets GCC 4.6.0 generate slightly better loop code.
8052
becfa255
PE
8053 * callint.c (Fcall_interactively): <, not <=, for optimization.
8054 (Fcall_interactively): Count the number of arguments produced,
8055 not the number of arguments given. This is simpler and lets GCC
8056 4.6.0 generate slightly better code.
8057
dae0cd48
PE
8058 * ftfont.c: Distingish more carefully between FcChar8 and char.
8059 The previous code passed unsigned char * to a functions like
8060 strlen and xstrcasecmp that expect char *, which does not
8061 conform to the C standard.
8062 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8063 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8064 char * when the C standard requires it.
8065
76032d70
PE
8066 * keyboard.c (read_char): Remove unused var.
8067
eb3f1cc8
PE
8068 * eval.c: Port to Windows vsnprintf (Bug#8435).
8069 Include <limits.h>.
8070 (SIZE_MAX): Define if the headers do not.
8071 (verror): Do not give up if vsnprintf returns a negative count.
8072 Instead, grow the buffer. This ports to Windows vsnprintf, which
8073 does not conform to C99. Problem reported by Eli Zaretskii.
8074 Also, simplify the allocation scheme, by avoiding the need for
8075 calling realloc, and removing the ALLOCATED variable.
8076
70476b54
PE
8077 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8078
12020a9e
PE
8079 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8080 But keep the doprint source code for now, as we might revamp it
8081 and use it again (Bug#8435).
ea6c7ae6
PE
8082 * lisp.h (doprnt): Remove.
8083 * Makefile.in (base_obj): Remove doprnt.o.
8084 * deps.mk (doprnt.o): Remove.
8085
5fdb398c
PE
8086 error: Print 32- and 64-bit integers portably (Bug#8435).
8087 Without this change, on typical 64-bit hosts error ("...%d...", N)
8088 was used to print both 32- and 64-bit integers N, which relied on
8089 undefined behavior.
61bdb816 8090 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8091 * lisp.h (error, verror): Mark as printf-like functions.
8092 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8093 Report overflow in size calculations when allocating printf buffer.
8094 Do not truncate output string at its first null byte.
8095 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8096 Truncate the output at a character boundary, since vsnprintf does not
8097 do that.
8098 * charset.c (check_iso_charset_parameter): Convert internal
8099 character to string before calling 'error', since %c now has the
8100 printf meaning.
8101 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8102 overflow when computing char to be passed to 'error'. Do not
8103 pass Lisp_Object to 'error'; pass the integer instead.
8104 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8105 formatted with plain %d.
8106
b189fa66
PE
8107 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8108
bff87ef0
PE
8109 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8110
7e2cac20
PE
8111 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8112
ce4d90b5
PE
8113 * xterm.c (x_catch_errors): Remove duplicate declaration.
8114
266c9547
PE
8115 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8116
79c49ad2
PE
8117 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8118
368f4090
JM
81192011-04-10 Jim Meyering <meyering@redhat.com>
8120
8121 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8122 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8123 return ssize_t not "int", and use size_t as the buffer length.
8124 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8125 * gnutls.h: Update declarations.
8126 * process.c (read_process_output): Use ssize_t, to match.
8127 (send_process): Likewise.
8128
a32d4040
CY
81292011-04-09 Chong Yidong <cyd@stupidchicken.com>
8130
8131 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8132
8546720e 81332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8134
04f2d78b
CB
8135 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8136 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8137
8546720e
GM
8138 * xterm.c (handle_one_xevent):
8139 * xmenu.c (create_and_show_popup_menu):
8140 * xselect.c (x_decline_selection_request)
8141 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8142
0a2f5c1a 81432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8144
8145 Fix some uses of `int' instead of EMACS_INT.
8146 * search.c (string_match_1, fast_string_match)
8147 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8148 (scan_buffer, find_next_newline_no_quit)
8149 (find_before_next_newline, search_command, Freplace_match)
8150 (Fmatch_data): Make some `int' variables be EMACS_INT.
8151
8152 * xdisp.c (display_count_lines): 3rd argument and return value now
8153 EMACS_INT. All callers changed.
8154 (pint2hrstr): Last argument is now EMACS_INT.
8155
8156 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8157 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8158 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8159 (decode_coding_utf_16, decode_coding_emacs_mule)
8160 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8161 (decode_coding_ccl, decode_coding_charset)
8162 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8163 (decode_coding_iso_2022, decode_coding_emacs_mule)
8164 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8165 <char_offset, last_offset>: Declare EMACS_INT.
8166 (encode_coding_utf_8, encode_coding_utf_16)
8167 (encode_coding_emacs_mule, encode_invocation_designation)
8168 (encode_designation_at_bol, encode_coding_iso_2022)
8169 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8170 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8171 Declare EMACS_INT.
8172 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8173 (encode_invocation_designation): Last argument P_NCHARS is now
8174 EMACS_INT.
8175 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8176 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8177
8178 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8179 All users changed.
8180
8181 * ccl.c (Fccl_execute_on_string): Declare some variables
8182 EMACS_INT.
8183
8546720e 81842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8185
8186 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8187
4e19a977
CS
81882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8189
8190 * process.c (Fformat_network_address): Doc fix.
8191
87302331
R
81922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8193
ee7683eb 8194 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8195
cbb59342
CY
81962011-04-08 Chong Yidong <cyd@stupidchicken.com>
8197
8198 * keyboard.c (read_char): Call Lisp function help-form-show,
8199 instead of using internal_with_output_to_temp_buffer.
8200 (Qhelp_form_show): New var.
e0d38eeb 8201 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8202
8203 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8204
8205 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8206
e67a13ab
CY
82072011-04-06 Chong Yidong <cyd@stupidchicken.com>
8208
04f2d78b
CB
8209 * process.c (Flist_processes): Remove to Lisp.
8210 (list_processes_1): Delete.
e67a13ab 8211
973f782d
EZ
82122011-04-06 Eli Zaretskii <eliz@gnu.org>
8213
7c106b1e
EZ
8214 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8215
973f782d
EZ
8216 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8217
41cf7d1a 82182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8219
ca23cc88
PE
8220 Fix more problems found by GCC 4.6.0's static checks.
8221
f390e2d5
PE
8222 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8223
42eea0d0
PE
8224 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8225
b69769da 8226 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8227
f9541e84
PE
8228 * xdisp.c (vmessage): Mark as a printf-like function.
8229
13841b55
PE
8230 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8231
c136c10f
PE
8232 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8233
5e2d4a30
PE
8234 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8235 printf-like functions.
8236 (tiff_load): Add casts to remove these marks before passing them
8237 to system-supplied API.
8238
583f48b9
PE
8239 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8240
b25d760e
PE
8241 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8242 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8243 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8244 directly, rather than having caller test rule sign. This avoids
8245 some unnecessary tests.
8246 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8247 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8248 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8249
bc7b6697 8250 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8251 (xfont_open): Avoid unnecessary tests.
bc7b6697 8252
27ccc379
PE
8253 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8254
dcd5c89a
PE
8255 * composite.h, composite.c (composition_gstring_put_cache):
8256 Use EMACS_INT, not int, for length.
8257
b13a45c6
PE
8258 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8259 breaking out part of COMPOSITION_DECODE_RULE.
8260 (COMPOSITION_DECODE_RULE): Use it.
8261 * composite.c (get_composition_id): Remove unused local vars,
8262 by using the new macro.
8263
1e792e4d
PE
8264 * textprop.c (set_text_properties_1): Change while to do-while,
8265 since the condition is always true at first.
8266
dc6c6455 8267 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8268 (interval_deletion_adjustment): Return unsigned value.
8269 All uses changed.
dc6c6455 8270
aba7731a
PE
8271 * process.c (list_processes_1, create_pty, read_process_output):
8272 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8273 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8274 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8275 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8276 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8277
fdfc4bf3
PE
8278 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8279
fca8fe46 8280 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8281 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8282
06a0259a 8283 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8284 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8285 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8286
e7b9e80f
PE
8287 * print.c (print_error_message): Avoid int overflow.
8288
56201685
PE
8289 * font.c (font_list_entities): Redo for clarity,
8290 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8291
78834453 8292 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8293 (font_score): Avoid potential overflow in diff calculation.
78834453 8294
0bc0b309 8295 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8296 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8297
e610eaca
PE
8298 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8299
b895abce
PE
8300 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8301 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8302 can always succeed if overflow has undefined behavior.
8303
1f1d9321 8304 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8305 (wordify): Omit three unnecessary tests.
1f1d9321 8306
c59478bc
PE
8307 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8308 All callers changed. This avoids the need for an unused var.
8309
79b73827
PE
8310 * casefiddle.c (casify_region): Remove var that is set but not used.
8311
a4db5dfe
PE
8312 * dired.c (file_name_completion): Remove var that is set but not used.
8313
43aae36e
PE
8314 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8315
2a47c44d 8316 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8317 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8318
a37c69bf
PE
8319 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8320 Check for integer overflow on size calculations.
8321
328ab8e7
PE
8322 * buffer.c (Fprevious_overlay_change): Remove var that is set
8323 but not used.
8324
e5a2a5cb
PE
8325 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8326 Remove vars that are set but not used.
8d84a6eb 8327 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8328 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8329
a60e5f68
PE
8330 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8331
f661cb61 8332 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8333 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8334
f0397f5a
PE
8335 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8336 that are set but not used.
8337
8664db06 8338 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8339 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8340
6abdaa4a
PE
8341 * xselect.c (x_get_local_selection, x_handle_property_notify):
8342 Remove vars that are set but not used.
8343
0ce7538d 8344 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8345 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8346
9ae848fc
PE
8347 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8348 Remove var that is set but not used.
0b918413
PE
8349 (scroll_bar_windows_size): Now size_t, not int.
8350 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8351 Check for overflow.
9ae848fc 8352
a5a62657
PE
8353 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8354 (map_tty_color) [!defined MSDOS]: Likewise.
8355
5c5cdd39
PE
8356 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8357
66ebf983
PE
8358 * coding.c: Remove vars that are set but not used.
8359 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8360 All callers changed.
8361 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8362 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8363 (decode_coding_charset): Remove vars that are set but not used.
8364
1be4d761
PE
8365 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8366 that is set but not used.
8367
47553fa8
PE
8368 * print.c (print_object): Remove var that is set but not used.
8369
1f7196bf 8370 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8371 The gnulib version avoids calling malloc in the usual case,
8372 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8373 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8374 * filelock.c (current_lock_owner): Likewise.
8375 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8376 * sysdep.c: Include allocator.h, careadlinkat.h.
8377 (emacs_no_realloc_allocator): New static constant.
8378 (emacs_readlink): New function.
fdb61804
PE
8379 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8380 ../lib/careadlinkat.h.
d1fdcab7 8381
f84c17c7
SM
83822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8383
8384 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8385 first non-nil return value).
8386
ef3862ad
JD
83872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8388
8389 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8390 if not defined (Bug#8403).
8391
376a7006
JB
83922011-04-02 Juanma Barranquero <lekktu@gmail.com>
8393
8394 * xdisp.c (display_count_lines): Remove parameter `start',
8395 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8396 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8397 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8398 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8399 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8400 and thereabouts. All callers changed.
8401 (get_per_char_metric): Remove parameter `f', unused since
8402 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8403
6ca3801d
JM
84042011-04-02 Jim Meyering <meyering@redhat.com>
8405
8406 do not dereference NULL upon failed strdup
8407 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8408 (ns_get_family): Likewise.
8409
d8e2b5ba
JB
84102011-04-02 Juanma Barranquero <lekktu@gmail.com>
8411
8412 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8413
8c74fcbd
JD
84142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8415
8416 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8417 later (Bug#8403).
8418
7200d79c
SM
84192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8420
03408648 8421 Add lexical binding.
7200d79c 8422
03408648
SM
8423 * window.c (Ftemp_output_buffer_show): New fun.
8424 (Fsave_window_excursion):
8425 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8426
8427 * lread.c (lisp_file_lexically_bound_p): New function.
8428 (Fload): Bind Qlexical_binding.
8429 (readevalloop): Remove `evalfun' arg.
8430 Bind Qinternal_interpreter_environment.
8431 (Feval_buffer): Bind Qlexical_binding.
8432 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8433 Mark as dynamic.
8434 (syms_of_lread): Declare `lexical-binding'.
8435
8436 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8437
8438 * keyboard.c (eval_dyn): New fun.
8439 (menu_item_eval_property): Use it.
ca105506
SM
8440
8441 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8442
03408648
SM
8443 * fns.c (concat, mapcar1): Accept byte-code-functions.
8444
8445 * eval.c (Fsetq): Handle lexical vars.
8446 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8447 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8448 (FletX, Flet): Obey lexical binding.
8449 (Fcommandp): Handle closures.
8450 (Feval): New `lexical' arg.
8451 (eval_sub): New function extracted from Feval. Use it almost
8452 everywhere where Feval was used. Look up vars in lexical env.
8453 Handle closures.
8454 (Ffunctionp): Move from subr.el.
8455 (Ffuncall): Handle closures.
8456 (apply_lambda): Remove `eval_flags'.
8457 (funcall_lambda): Handle closures and new byte-code-functions.
8458 (Fspecial_variable_p): New function.
8459 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8460 but without exporting it to Lisp.
23aba0ea 8461
23aba0ea 8462 * doc.c (Fdocumentation, store_function_docstring):
03408648 8463 * data.c (Finteractive_form): Handle closures.
23aba0ea 8464
03408648
SM
8465 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8466 interactive spec.
ba83908c 8467
04f2d78b
CB
8468 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8469 New byte-codes.
03408648
SM
8470 (exec_byte_code): New function extracted from Fbyte_code to handle new
8471 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8472
03408648 8473 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8474
03408648 8475 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8476
e2abce01
JB
84772011-03-31 Juanma Barranquero <lekktu@gmail.com>
8478
8479 * xdisp.c (redisplay_internal): Fix prototype.
8480
63696a73 84812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8482
63696a73 8483 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8484 (try_scrolling): Use it when setting scroll_limit.
8485 Limit scrolling to 100 screen lines.
63696a73
EZ
8486 (redisplay_window): Even when falling back on "recentering",
8487 position point in the window according to scroll-conservatively,
8488 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8489
8490 (try_scrolling): When point is above the window, allow searching
8491 as far as scroll_max, or one screenful, to compute vertical
8492 distance from PT to the scroll margin position. This prevents
8493 try_scrolling from unnecessarily failing when
8494 scroll-conservatively is set to a value slightly larger than the
8495 window height. Clean up the case of PT below the margin at bottom
8496 of window: scroll_max can no longer be INT_MAX. When aggressive
8497 scrolling is in use, don't let point enter the opposite scroll
8498 margin as result of the scroll.
8499 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8500 threshold of 100 lines for never-recentering scrolling.
8501
e4cc2dfc
JB
85022011-03-31 Juanma Barranquero <lekktu@gmail.com>
8503
8504 * dispextern.h (move_it_by_lines):
8505 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8506 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8507 (message_log_check_duplicate): Remove parameters `prev_bol' and
8508 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8509 (redisplay_internal): Remove parameter `preserve_echo_area',
8510 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8511
8512 * indent.c (Fvertical_motion):
8513 * window.c (window_scroll_pixel_based, Frecenter):
8514 Don't pass `need_y_p' to `move_it_by_lines'.
8515
1c470562
SM
85162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8517
44f230aa
SM
8518 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8519 steal a few bits to be more compact.
8520 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8521 Remove unneeded casts.
8522
1c470562
SM
8523 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8524
888adce9
ZK
85252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8526
8527 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8528 binding" message (bug#7967).
8529
f838ed7b
PE
85302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8531
77861b95
PE
8532 Fix more problems found by GCC 4.6.0's static checks.
8533
de6dbc14
PE
8534 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8535 Remove unused local var.
8536
f838ed7b
PE
8537 * editfns.c (Fmessage_box): Remove unused local var.
8538
792c7b2b
PE
8539 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8540 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8541 Omit unused local vars.
c499e557 8542 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8543 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8544 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8545 Omit unused local var.
8546
ba0165e1
PE
8547 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8548 Don't assume string length fits in int.
32ad8845 8549 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8550 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8551
3c59b4c9
PE
8552 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8553 instead of alloca (Bug#8344).
8554
a3eed478 8555 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8556 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8557
eb4d412d
PE
8558 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8559
1658b401
PE
8560 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8561 concerns.
8562
8563 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8564
8565 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8566
9a2c6e05
PE
8567 * keyboard.c (syms_of_keyboard): Use the same style as later
8568 in this function when indexing through an array. This also
8569 works around GCC bug 48267.
8570
03d0a109
PE
8571 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8572
44f730c8
PE
8573 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8574
fe75f926
PE
8575 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8576 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8577
ffa8c828
PE
8578 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8579 This avoids undefined behavior on integer overflow, and is a bit
8580 more convenient anyway since it is compared to a size_t variable.
8581
c5101a77
PE
8582 Variadic C functions now count arguments with size_t, not int.
8583 This avoids an unnecessary limitation on 64-bit machines, which
8584 caused (substring ...) to crash on large vectors (Bug#8344).
8585 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8586 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8587 All variadic functions and their callers changed accordingly.
c5101a77
PE
8588 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8589 * data.c (arith_driver, float_arith_driver): Likewise.
8590 * editfns.c (general_insert_function): Likewise.
8591 * eval.c (struct backtrace.nargs, interactive_p)
8592 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8593 (funcall_lambda, mark_backtrace): Likewise.
8594 * fns.c (concat): Likewise.
8595 * frame.c (x_set_frame_parameters): Likewise.
8596 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8597 0 if not found, not -1. All callers changed.
8598
dd3f25f7
PE
8599 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8600 (stack_copy_size): Now size_t, not int.
8601 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8602
461c2ab9
JB
86032011-03-28 Juanma Barranquero <lekktu@gmail.com>
8604
8605 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8606 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8607 All callers changed.
8608
8609 * lisp.h (multibyte_char_to_unibyte):
8610 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8611 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8612 * character.h (CHAR_TO_BYTE8):
8613 * cmds.c (internal_self_insert):
8614 * editfns.c (general_insert_function):
8615 * keymap.c (push_key_description):
8616 * search.c (Freplace_match):
8617 * xdisp.c (message_dolog, set_message_1): All callers changed.
8618
f6d62986
SM
86192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8620
8621 * keyboard.c (safe_run_hook_funcall): New function.
8622 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8623 don't set the hook to nil, but remove the offending function instead.
8624 (Qcommand_hook_internal): Remove, unused.
8625 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8626 Vcommand_hook_internal.
8627
8628 * eval.c (enum run_hooks_condition): Remove.
8629 (funcall_nil, funcall_not): New functions.
8630 (run_hook_with_args): Call each function through a `funcall' argument.
8631 Remove `cond' argument, now redundant.
8632 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8633 (Frun_hook_with_args_until_failure): Adjust accordingly.
8634 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8635
1db5b1ad
JB
86362011-03-28 Juanma Barranquero <lekktu@gmail.com>
8637
8638 * dispextern.h (string_buffer_position): Remove declaration.
8639
8640 * print.c (strout): Remove parameter `multibyte', unused since
8641 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8642
8643 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8644 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8645 All callers changed.
8646
8647 * w32.c (_wsa_errlist): Use braces for struct initializers.
8648
8649 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8650 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8651 All callers changed.
8652 (string_buffer_position): Likewise. Also, make static (it's never
8653 used outside xdisp.c).
8654 (cursor_row_p): Remove parameter `w', unused since
8655 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8656 (decode_mode_spec): Remove parameter `precision', introduced during
8657 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8658 All callers changed.
8659
5ffb62aa
JD
86602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8661
8662 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8663
461c2ab9 86642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8665
8666 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8667 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8668 (ns_update_auto_hide_menu_bar): New functions.
8669 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8670 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8671 ns_constrain_all_frames.
8672 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8673 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8674
5c380ffb
JD
86752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8676
8677 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8678
9af30bdf
GM
86792011-03-27 Glenn Morris <rgm@gnu.org>
8680
8681 * syssignal.h: Replace RETSIGTYPE with void.
8682 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8683 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8684 Replace SIGTYPE with void everywhere.
8685 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8686 * s/template.h (SIGTYPE): Remove commented out definition.
8687
e2abce01
JB
86882011-03-26 Eli Zaretskii <eliz@gnu.org>
8689
8690 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8691 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8692
f868cd8a
JB
86932011-03-26 Juanma Barranquero <lekktu@gmail.com>
8694
59eb0929
JB
8695 * w32.c (read_unc_volume): Use parameter `henum', instead of
8696 global variable `wget_enum_handle'.
8697
8698 * keymap.c (describe_vector): Remove parameters `indices' and
8699 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8700 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8701
f868cd8a
JB
8702 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8703
8704 * keyboard.c (timer_check): Remove parameter `do_it_now',
8705 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8706 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8707 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8708
8709 * keyboard.c (read_char):
8710 * w32menu.c (w32_menu_display_help):
8711 * xmenu.c (show_help_event, menu_help_callback):
8712 Adjust calls to `show_help_echo'.
8713
8714 * gtkutil.c (xg_maybe_add_timer):
8715 * keyboard.c (readable_events):
8716 * process.c (wait_reading_process_output):
8717 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8718
8719 * insdel.c (adjust_markers_gap_motion):
8720 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8721 (gap_left, gap_right): Don't call it.
8722
2ecf6fdb
CY
87232011-03-25 Chong Yidong <cyd@stupidchicken.com>
8724
8725 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8726 incurred during fontification.
8727
6b1f9ba4
JB
87282011-03-25 Juanma Barranquero <lekktu@gmail.com>
8729
8730 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8731 (DEFVAR_PER_BUFFER): Don't pass it.
8732
8733 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8734 (scrolling_window): Don't pass it.
8735
0f4a96b5
JB
87362011-03-25 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8739
8740 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8741 and `suffix'.
8742 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8743 of variables specific to SELinux and computation of `encoded_absname'.
8744
8745 * image.c (XPutPixel): Remove unused variable `height'.
8746
8747 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8748
8749 * unexw32.c (get_section_info): Remove unused variable `section'.
8750
8751 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8752 (system_process_attributes): Remove unused variable `sess'.
8753 (sys_read): Remove unused variable `err'.
8754
8755 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8756 (w32_wnd_proc): Remove unused variable `isdead'.
8757 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8758 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8759 (x_create_tip_frame): Remove unused variable `tem'.
8760
8761 * w32inevt.c (w32_console_read_socket):
8762 Remove unused variable `no_events'.
8763
8764 * w32term.c (x_draw_composite_glyph_string_foreground):
8765 Remove unused variable `width'.
8766
1149507c
JB
87672011-03-24 Juanma Barranquero <lekktu@gmail.com>
8768
8769 * w32term.c (x_set_glyph_string_clipping):
8770 Don't pass uninitialized region to CombineRgn.
8771
9c88f339
JB
87722011-03-23 Juanma Barranquero <lekktu@gmail.com>
8773
8774 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8775 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8776 (Fx_close_connection): Remove unused variable `i'.
8777
8778 * w32font.c (w32font_draw): Return number of glyphs.
8779 (w32font_open_internal): Remove unused variable `i'.
8780 (w32font_driver): Add missing initializer.
8781
8782 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8783 (fill_in_menu): Remove unused variable `items_added'.
8784
8785 * w32term.c (last_mouse_press_frame): Remove static global variable.
8786 (w32_clip_to_row): Remove unused variable `f'.
8787 (x_delete_terminal): Remove unused variable `i'.
8788
8789 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8790 (NOTHING): Remove unused static global variable.
8791 (uniscribe_check_otf): Remove unused variable `table'.
8792 (uniscribe_font_driver): Add missing initializers.
8793
dee091a3
JD
87942011-03-23 Julien Danjou <julien@danjou.info>
8795
8796 * term.c (Fsuspend_tty, Fresume_tty):
8797 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8798 * window.c (temp_output_buffer_show):
8799 * insdel.c (signal_before_change):
8800 * frame.c (Fhandle_switch_frame):
8801 * fileio.c (Fdo_auto_save):
8802 * emacs.c (Fkill_emacs):
8803 * editfns.c (save_excursion_restore):
8804 * cmds.c (internal_self_insert):
8805 * callint.c (Fcall_interactively):
8806 * buffer.c (Fkill_all_local_variables):
8807 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8808 Use Frun_hooks.
0f4a96b5 8809 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8810 unconditionally since it does the check itself.
dee091a3 8811
2c520ab5 88122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8813
c9c49752
PE
8814 Fix more problems found by GCC 4.5.2's static checks.
8815
8abc3f12
PE
8816 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8817 the first time through the loop, since we know p0 < p1 then.
8818 This also avoids a gcc -Wstrict-overflow warning.
8819
a2d26660
PE
8820 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8821 leading to a memory leak, possible in functions like
8822 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8823 of objects (Bug#8318).
a2d26660 8824
916c72e9
PE
8825 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8826 that could (at least in theory) be that large.
8827
19ab8a18
PE
8828 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8829 This is less likely to overflow, and avoids undefined behavior if
8830 overflow does occur. All callers changed. Use strtoul to scan
8831 for the unsigned long integer.
b7cbbd6f
PE
8832 (pint2hrstr): Simplify and tune code slightly.
8833 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8834
f0641eff
PE
8835 * scroll.c (do_scrolling): Work around GCC bug 48228.
8836 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8837
7f650bb9
PE
8838 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8839 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8840 (validate_x_resource_name): Simplify count usage.
8841 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8842
37dd57d1
PE
8843 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8844 fail (Bug#8306).
81e56e61 8845
699979fc 8846 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8847
401bf9b4
PE
8848 * process.c (Fmake_network_process): Use socklen_t, not int,
8849 where POSIX says socklen_t is required in portable programs.
8850 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8851 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8852 (Fmake_network_process, server_accept_connection):
8853 (wait_reading_process_output, read_process_output):
8854 Likewise.
8855
b93aacde
PE
8856 * process.c: Rename or move locals to avoid shadowing.
8857 (list_processes_1, Fmake_network_process):
8858 (read_process_output_error_handler, exec_sentinel_error_handler):
8859 Rename or move locals.
4dc343ee 8860 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8861 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8862 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8863 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8864 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8865
af8a867c 8866 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8867 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8868 Include tparam.h instead, since it declares them.
af8a867c
PE
8869 * cm.h (PC): Remove extern decl; tparam.h now does this.
8870 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8871 * terminfo.c: Include tparam.h, to check interfaces.
8872 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8873 (tparam): Adjust signature to match interface in tparam.h;
8874 this removes some undefined behavior. Check that outstring and len
8875 are zero, which they always are with Emacs.
8876 * tparam.h (PC, BC, UP): New extern decls.
8877
0248044d 8878 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8879 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8880
8ff096c1 8881 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8882 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8883 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8884 (ftfont_list): Remove unused local.
49eaafba
PE
8885 (get_adstyle_property, ftfont_pattern_entity):
8886 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8887 Rename locals to avoid shadowing.
8ff096c1 8888
e2be39f6
PE
8889 * xfont.c (xfont_list_family): Mark var as initialized.
8890
c9735e30
PE
8891 * xml.c (make_dom): Now static.
8892
8f5201ae
PE
8893 * composite.c (composition_compute_stop_pos): Rename local to
8894 avoid shadowing.
b246f932
PE
8895 (composition_reseat_it): Remove unused locals.
8896 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8897 (composition_update_it): Mark var as initialized.
11b61122
PE
8898 (find_automatic_composition): Mark vars as initialized,
8899 with a FIXME (Bug#8290).
8f5201ae 8900
760fbc2c
PE
8901 character.h: Rename locals to avoid shadowing.
8902 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8903 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8904 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8905 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8906 to avoid shadowing.
8907
ff08eb85
PE
8908 * textprop.c (property_change_between_p): Remove; unused.
8909
fc7bf025
PE
8910 * intervals.c (interval_start_pos): Now static.
8911
235d7abc
PE
8912 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8913
44f230aa
SM
8914 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8915 Rename locals to avoid shadowing.
3e7d6594 8916
50060332
PE
8917 * sound.c (wav_play, au_play, Fplay_sound_internal):
8918 Fix pointer signedness.
d01f234b 8919 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8920 (wav_play): Initialize a variable to 0, to prevent undefined
8921 behavior (Bug#8278).
50060332 8922
c4fc4e30
PE
8923 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8924
918436ed
PE
8925 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8926
c939f91b
PE
8927 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8928 clobbering (Bug#8298).
b9c7f648
PE
8929 * sysdep.c (sys_subshell): Likewise.
8930 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8931
6bd8c144
PE
8932 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8933 This should get cleaned up, so that child_setup has the
8934 same signature on all platforms.
8935
7710357c 8936 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8937 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8938
c59da222
CY
89392011-03-22 Chong Yidong <cyd@stupidchicken.com>
8940
8941 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8942 not to be necessary, and produces flickering.
8943
66b87493
GM
89442011-03-20 Glenn Morris <rgm@gnu.org>
8945
8946 * config.in: Remove file.
8947
45b6f6d5
JB
89482011-03-20 Juanma Barranquero <lekktu@gmail.com>
8949
8950 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8951 are now in src/globals.h.
8952 (syms_of_minibuf): Remove spurious & from previous change.
8953
cd394be1 89542011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8955
8956 * minibuf.c (completing-read-function): New variable.
8957 (completing-read-default): Rename from completing-read.
8958 (completing-read): Call completing-read-function.
8959
b14e3e21
CY
89602011-03-19 Juanma Barranquero <lekktu@gmail.com>
8961
8962 * xfaces.c (Fx_load_color_file):
8963 Read color file from absolute filename (bug#8250).
8964
f2b726e6
JB
89652011-03-19 Juanma Barranquero <lekktu@gmail.com>
8966
8967 * makefile.w32-in: Update dependencies.
8968
09f6ff02
EZ
89692011-03-17 Eli Zaretskii <eliz@gnu.org>
8970
8971 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8972
29a6015a
PE
89732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8974
a3a6c54e
PE
8975 Fix more problems found by GCC 4.5.2's static checks.
8976
b766f867
PE
8977 * process.c (make_serial_process_unwind, send_process_trap):
8978 (sigchld_handler): Now static.
8979
be02381c
PE
8980 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8981 That way, the code declares only the vars that it needs.
8982 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8983 * s/cygwin.h (PTY_ITERATION): Likewise.
8984 * s/darwin.h (PTY_ITERATION): Likewise.
8985 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8986
57048744
PE
8987 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8988 * process.c (allocate_pty): Don't declare stb unless it's needed.
8989
7914961c 8990 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8991 (CONSTANTLIM): Remove; unused.
8992 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8993 Define only if needed.
7914961c 8994
b3967b18
PE
8995 * unexelf.c (unexec): Name an expression,
8996 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8997 Use a different way to cause a compilation error if anyone uses
8998 n rather than nn, a way that does not involve shadowing.
73366a00 8999 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9000
29a6015a
PE
9001 * deps.mk (unexalpha.o): Remove; unused.
9002
43cfc33e 9003 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9004 * unexec.h: New file.
ce701a33
PE
9005 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9006 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9007 Depend on unexec.h.
9008 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9009 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9010 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9011 Change as necessary to match prototype in unexec.h.
ce701a33 9012
01f44d5a
PE
9013 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9014 shadowing.
4f63c6bb 9015 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9016
a6670b0b
PE
9017 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9018 Rename locals to avoid shadowing.
9019
cef2010d 9020 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9021 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9022
d4d7173a
PE
9023 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9024
f08b802a
PE
9025 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9026 warning when compiling print.c.
9027
3ddb0639
PE
9028 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9029 instead of using an uninitialized var.
5ad03b97 9030 (font_sort_entities): Mark var as initialized.
3ddb0639 9031
170a2692
PE
9032 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9033
e663c700
PE
9034 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9035 pointers to constants.
89bc529a 9036 (font_parse_fcname): Remove unused vars.
7b81e2d0 9037 (font_delete_unmatched): Now static.
ea838e10 9038 (font_get_spec): Remove; unused.
13a547c6
PE
9039 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9040 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9041 Rename or move locals to avoid shadowing.
e663c700 9042
2a80c887 9043 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9044 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9045
1384fa33 9046 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9047 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9048
8b2c52e9
PE
9049 * alloc.c (mark_backtrace): Move decl from here ...
9050 * lisp.h: ... to here, so that it can be checked.
9051
475545b5 9052 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9053 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9054 (lisp_indirect_variable): Name an expression,
9055 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9056 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9057
b1349114 9058 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9059 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9060 Use const pointer when appropriate.
b1349114 9061
a2928364
PE
9062 * lisp.h (get_system_name, get_operating_system_release):
9063 Move decls here, to check interfaces.
9064 * process.c (get_operating_system_release): Move decl to lisp.h.
9065 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9066 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9067 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9068 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9069 (Fformat_time_string, Fencode_time, Finsert_char):
9070 (Ftranslate_region_internal, Fformat):
9071 Rename or remove local vars to avoid shadowing.
9710023e 9072 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9073
a415e694
PE
9074 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9075 avoid shadowing.
9076
8ef4622d
PE
9077 * lisp.h (eassert): Check that the argument compiles, even if
9078 ENABLE_CHECKING is not defined.
9079
946f9a5b
PE
9080 * data.c (Findirect_variable): Name an expression, to avoid
9081 gcc -Wbad-function-cast warning.
112396d6 9082 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9083 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9084 (Fmake_variable_buffer_local, Fmake_local_variable):
9085 Mark variables as initialized.
52746918 9086 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9087
e5aab7e7 9088 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9089 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9090 Rename locals to avoid shadowing.
dff45157
PE
9091 (mark_stack): Move local variables into the #ifdef region where
9092 they're used.
7bc26fdb
PE
9093 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9094 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9095 needed otherwise.
9096 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9097 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9098 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9099
e5aab7e7
PE
9100 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9101 avoids undefined behavior in theory.
9102
4da60324
PE
9103 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9104
88043301
PE
9105 Use functions, not macros, for up- and down-casing (Bug#8254).
9106 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9107 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9108 to use the following functions instead of these macros.
9109 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9110 EMACS_INT, since callers assume the returned value fits in int.
9111 (upcase1): Likewise, for UPCASE_TABLE.
9112 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9113 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9114 the race-condition problem in the old DOWNCASE.
88043301 9115
19ed5445
PE
9116 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9117 Rename locals to avoid shadowing.
9118 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9119 (regex_compile, re_search_2, re_match_2_internal):
9120 Remove unused local vars.
952db0d7
PE
9121 (FREE_VAR): Rewrite so as not to use empty "else",
9122 which gcc can warn about.
da053e48 9123 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9124 (RETALLOC_IF): Define only if needed.
9125 (WORDCHAR_P): Likewise. This one is never needed, but is used
9126 only in a comment talking about a compiler bug, so put inside
9127 the #if 0 of that comment.
9128 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9129 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9130 Remove; unused.
19ed5445 9131
1f3561e4 9132 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9133 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9134 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9135
ded6f8f7
PE
9136 * search.c (simple_search): Remove unused var.
9137
dbd37a95
PE
9138 * dired.c (compile_pattern): Move decl from here ...
9139 * lisp.h: ... to here, so that it can be checked.
9140 (struct re_registers): New forward decl.
9141
7e47afad
PE
9142 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9143
85f24f61
PE
9144 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9145 All uses changed.
9146 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9147 Rename locals to avoid shadowing.
5671df8f 9148 (Fvertical_motion): Mark locals as initialized.
85f24f61 9149
181aa2be 9150 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9151 (casify_region): Mark local as initialized.
181aa2be 9152
930d429c
PE
9153 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9154
7082eac6
PE
9155 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9156 New macros, so that the caller can use some names other than
9157 gcpro1, gcpro2, etc.
9158 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9159 of the new macros.
9160 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9161 argument, for consistency with GCPRO2_VAR, etc: it is now the
9162 prefix of the variable, not the variable itself. All uses
9163 changed.
38b2c076
PE
9164 * dired.c (directory_files_internal, file_name_completion):
9165 Rename locals to avoid shadowing.
9166
15206ed9
PE
9167 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9168 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9169 dired.c's scmp function, had undefined behavior.
9170 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9171 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9172 * buffer.h: ... to here, because these macros use current_buffer,
9173 and the new implementation with inline functions needs to have
9174 current_buffer in scope now, rather than later when the macros
9175 are used.
9176 (downcase, upcase1): New static inline functions.
9177 (DOWNCASE, UPCASE1): Reimplement using these functions.
9178 This avoids undefined behavior in expressions like
9179 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9180 from race conditions in accessing the global variables
9181 case_temp1 and case_temp2.
9182 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9183 * lisp.h (case_temp1, case_temp2): Remove their decls.
9184 * character.h (ASCII_CHAR_P): Move from here ...
9185 * lisp.h: ... to here, so that the inline functions mentioned
9186 above can use them.
9187
4a6bea26
PE
9188 * dired.c (directory_files_internal_unwind): Now static.
9189
f14b7e14
PE
9190 * fileio.c (file_name_as_directory, directory_file_name):
9191 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9192 Now static.
2893f146
PE
9193 (file_name_as_directory): Use const pointers when appropriate.
9194 (Fexpand_file_name): Likewise. In particular, newdir might
9195 point at constant storage, so make it a const pointer.
fd4ead52 9196 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9197 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9198 signedness issues.
f839df0c
PE
9199 (Fset_file_times, Finsert_file_contents, auto_save_error):
9200 Rename locals to avoid shadowing.
f14b7e14 9201
5716756e 9202 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9203 (Ftry_completion, Fall_completions): Rename or remove locals
9204 to avoid shadowing.
5716756e 9205
b4c3046a
PE
9206 * marker.c (bytepos_to_charpos): Remove; unused.
9207
b45db522
PE
9208 * lisp.h (verify_bytepos, count_markers): New decls,
9209 so that gcc does not warn that these functions aren't declared.
9210
85876d07
PE
9211 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9212 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9213 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9214 (copy_text): Remove unused local var.
85876d07 9215
03d78a21 9216 * filelock.c (within_one_second): Now static.
b3dd38ab 9217 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9218
5df8f01b
PE
9219 * buffer.c (fix_overlays_before): Mark locals as initialized.
9220 (fix_start_end_in_overlays): Likewise. This function should be
9221 simplified by using pointers-to-pointers, but that's a different
9222 matter.
b1d876f1 9223 (switch_to_buffer_1): Now static.
8f54f30a
PE
9224 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9225 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9226
a70072c9 9227 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9228 Fix pointer signedness issue.
edced198
PE
9229 (sys_subshell): Mark local as volatile if checking for lint,
9230 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9231 (MAXPATHLEN): Define only if needed.
a70072c9 9232
a0977c44
PE
9233 * process.c (serial_open, serial_configure): Move decls from here ...
9234 * systty.h: ... to here, so that they can be checked.
9235
a884fdcc
PE
9236 * fns.c (get_random, seed_random): Move extern decls from here ...
9237 * lisp.h: ... to here, so that they can be checked.
9238
604efe86 9239 * sysdep.c (reset_io): Now static.
b8950c94 9240 (wait_for_termination_signal): Remove; unused.
604efe86 9241
38fc62d9
PE
9242 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9243 (copy_keymap_item, append_key, push_text_char_description):
9244 Now static.
1004a21a 9245 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9246 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9247 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9248 (describe_map_tree):
9249 Rename locals to avoid shadowing.
38fc62d9 9250
2f2650da
PE
9251 * keyboard.c: Declare functions static if they are not used elsewhere.
9252 (echo_char, echo_dash, cmd_error, top_level_2):
9253 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9254 (read_char, kbd_buffer_get_event, make_lispy_position):
9255 (make_lispy_event, make_lispy_movement, apply_modifiers):
9256 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9257 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9258 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9259 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9260 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9261
a053e86c 9262 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9263 (mark_kboards): Move decl here ...
9264 * alloc.c (mark_kboards): ... from here.
a053e86c 9265
4752793e
PE
9266 * lisp.h (force_auto_save_soon): New decl.
9267
74f10ca7 9268 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9269 (DEFINE_DUMMY_FUNCTION): New macro.
9270 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9271 Use it.
c03cd23f
PE
9272 (main): Add casts to avoid warnings
9273 if GCC considers string literals to be constants.
74f10ca7 9274
022e70d4
PE
9275 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9276
59d6fe83
PE
9277 * dbusbind.c: Pointer signedness fixes.
9278 (xd_signature, xd_append_arg, xd_initialize):
9279 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9280 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9281 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9282 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9283
78320123
PE
9284 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9285 if GCC considers string literals to be constants.
49cebcca 9286 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9287
35ac2a97
SM
92882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9289
fb103ca9
SM
9290 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9291 (print_preprocess, print_object): New macro to fix last change.
9292
35ac2a97
SM
9293 * print.c (print_preprocess): Don't forget font objects.
9294
62973b41
JB
92952011-03-16 Juanma Barranquero <lekktu@gmail.com>
9296
9297 * emacs.c (USAGE3): Doc fixes.
9298
0e48bb22
AS
92992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9300
9301 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9302 structure.
9303
7684e57b
JB
93042011-03-14 Juanma Barranquero <lekktu@gmail.com>
9305
9306 * lisp.h (VWindow_system, Qfile_name_history):
9307 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9308 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9309 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9310
9311 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9312 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9313
9314 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9315 * w32console.c (detect_input_pending, read_input_pending)
9316 (encode_terminal_code):
9317 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9318 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9319 (w32_system_caret_y, Qfile_name_history):
9320 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9321 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9322 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9323 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9324 * w32proc.c (Qlocal, report_file_error):
9325 * w32term.c (Vwindow_system, updating_frame):
9326 * w32uniscribe.c (initialized, uniscribe_font_driver):
9327 Remove unneeded extern declarations.
9328
2aa46d6c
CY
93292011-03-14 Chong Yidong <cyd@stupidchicken.com>
9330
c96bbc66 9331 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9332
cffc6f3b
CY
93332011-03-13 Chong Yidong <cyd@stupidchicken.com>
9334
9335 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9336 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9337 These macros can no longer be used for assignment.
9338
44f230aa
SM
9339 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9340 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9341 (record_buffer_markers, fetch_buffer_markers): New functions for
9342 recording and fetching special buffer markers.
9343 (set_buffer_internal_1, set_buffer_temp): Use them.
9344
9345 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9346
9347 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9348
9349 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9350 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9351
9352 * xdisp.c (hscroll_window_tree):
9353 (reconsider_clip_changes): Use PT instead of BUF_PT.
9354
d251f04b
EZ
93552011-03-13 Eli Zaretskii <eliz@gnu.org>
9356
9357 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9358 $(EMACS_ROOT)/lib/intprops.h.
9359
f0c77cd1
PE
93602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9361
3eca4629
PE
9362 Fix more problems found by GCC 4.5.2's static checks.
9363
7c86ee98
PE
9364 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9365 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9366 (xg_free_frame_widgets): Make it clear that a local variable is
9367 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9368 (gdk_window_get_screen): Make it clear that this macro is needed
9369 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9370 (int_gtk_range_get_value): New function, which avoids a diagnostic
9371 from gcc -Wbad-function-cast.
9372 (xg_set_toolkit_scroll_bar_thumb): Use it.
9373 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9374 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9375 (get_utf8_string, xg_get_file_with_chooser):
9376 Rename locals to avoid shadowing.
9377 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9378
41729b81
PE
9379 * xgselect.c (xg_select): Remove unused var.
9380
f0c77cd1
PE
9381 * image.c (four_corners_best): Mark locals as initialized.
9382 (gif_load): Initialize transparent_p to zero (Bug#8238).
9383 Mark another local as initialized.
ec6cf4c6 9384 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9385
ce0ad53d 9386 * image.c (clear_image_cache): Now static.
d5d5a617 9387 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9388 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9389 (x_edge_detection): Remove unnecessary cast that
9390 gcc -Wbad-function-cast diagnoses.
2037898d 9391 (gif_load): Fix pointer signedness.
6ae141d6
PE
9392 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9393 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9394
33383987 93952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9396
d32df629
PE
9397 Improve quality of tests for time stamp overflow.
9398 For example, without this patch (encode-time 0 0 0 1 1
9399 1152921504606846976) returns the obviously-bogus value (-948597
9400 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9401 reports time overflow. See
9402 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9403 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9404 * editfns.c: Include limits.h and intprops.h.
9405 (TIME_T_MIN, TIME_T_MAX): New macros.
9406 (time_overflow): Move earlier, to before first use.
9407 (hi_time, lo_time): New functions, for an accurate test for
9408 out-of-range times.
9409 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9410 (Fget_internal_run_time): Don't assume time_t fits in int.
9411 (make_time): Use list2 instead of Fcons twice.
9412 (Fdecode_time): More accurate test for out-of-range times.
9413 (check_tm_member): New function.
9414 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9415 (lisp_time_argument): Don't rely on undefined left-shift and
9416 right-shift behavior when checking for time stamp overflow.
8be6f318 9417
fe31d94c
PE
9418 * editfns.c (time_overflow): New function, refactoring common code.
9419 (Fformat_time_string, Fdecode_time, Fencode_time):
9420 (Fcurrent_time_string): Use it.
9421
8be6f318
PE
9422 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9423 * dired.c (make_time): Move to ...
9424 * editfns.c (make_time): ... here.
9425 * systime.h: Note the move.
9426
09d9db2c 94272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9428
126bc0dc
YM
9429 * fringe.c (update_window_fringes): Remove unused variables.
9430
c47cbdfd
YM
9431 * unexmacosx.c (copy_data_segment): Also copy __got section.
9432 (Bug#8223)
9433
7ac80be9
EZ
94342011-03-12 Eli Zaretskii <eliz@gnu.org>
9435
c96bbc66 9436 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9437 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9438 Constify `char *' arguments and their references according to
9439 prototypes in tparam.h.
9440
ecb0f94d 9441 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9442
7ac80be9
EZ
9443 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9444 Adapt all references accordingly.
9445
9446 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9447
ef1fd07e
TT
94482011-03-11 Tom Tromey <tromey@redhat.com>
9449
9450 * buffer.c (syms_of_buffer): Remove obsolete comment.
9451
7ef4b50c
EZ
94522011-03-11 Eli Zaretskii <eliz@gnu.org>
9453
9454 * termhooks.h (encode_terminal_code): Declare prototype.
9455
9456 * msdos.c (encode_terminal_code): Don't declare prototype.
9457
9458 * term.c (encode_terminal_code): Now external again, used by
9459 w32console.c and msdos.c.
9460
44f230aa
SM
9461 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9462 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9463
4b1ec863 94642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9465
1714f52b 9466 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9467
4b1ec863
PE
9468 * fringe.c (update_window_fringes): Mark locals as initialized
9469 (Bug#8227).
9470 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9471
524c7aa6
PE
9472 * alloc.c (mark_fringe_data): Move decl from here ...
9473 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9474 to check its interface.
9475 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9476
a5c0af81 9477 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9478 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9479 (fontset_font): Mark local as initialized.
a9a06e0b 9480 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9481
b4716021
PE
9482 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9483
811e9bac 9484 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9485 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9486 (x_own_selection, Fx_disown_selection_internal): Rename locals
9487 to avoid shadowing.
9488 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9489
7e3ab302
PE
9490 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9491 so that the caller can use some name other than gcpro1.
9492 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9493 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9494 (Fx_backspace_delete_keys_p):
9495 Use them to avoid shadowing, and rename vars to avoid shadowing.
9496 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9497 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9498 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9499 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9500 Remove unused locals.
7e3ab302
PE
9501 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9502 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9503 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9504 macros.
f78faa98 9505
e2b13473
PE
9506 * xterm.h (x_mouse_leave): New decl.
9507
77f23912
PE
9508 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9509 Remove unused functions.
cdf4ba58
PE
9510 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9511 (x_calc_absolute_position): Now static.
7411c686 9512 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9513 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9514 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9515 unless they are used.
38d0b34a
PE
9516 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9517 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9518 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9519 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9520 (x_error_catcher, x_connection_closed, x_error_handler):
9521 (x_error_quitter, xembed_send_message, x_iconify_frame):
9522 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9523 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9524 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9525
44f230aa
SM
9526 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9527 Rename or move locals to avoid shadowing.
6b463e58 9528 (tty_defined_color, merge_face_heights): Now static.
5967d051 9529 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9530 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9531 does not deduce is never used uninitialized.
73719eba
PE
9532 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9533 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9534
426994c3 9535 * terminal.c (store_terminal_param): Now static.
5489860b 9536
032f1620 9537 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9538 (set_frame_menubar): Remove unused local.
d4323972 9539 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9540 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9541 since they might point to immutable storage.
281585b0
PE
9542 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9543 since it's unused otherwise.
032f1620 9544
367c19e5 9545 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9546 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9547 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9548 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9549 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9550 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9551 does not deduce are never used uninitialized.
70739cbe 9552
07b48fa9
PE
9553 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9554
8868a238 9555 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9556 * window.c (window_loop, size_window):
9557 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9558
7e5cf297 9559 * window.c (display_buffer): Now static.
d6550a9f
PE
9560 (size_window): Mark variables that gcc -Wuninitialized
9561 does not deduce are never used uninitialized.
a586633d
PE
9562 * window.h (check_all_windows): New decl, to forestall
9563 gcc -Wmissing-prototypes diagnostic.
5b555da1 9564 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9565
f6095868
PE
9566 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9567 shadowing.
9568 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9569 Include <limits.h>.
9570 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9571 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9572 (load_charset_map): Mark variables that gcc -Wuninitialized
9573 does not deduce are never used uninitialized.
53df7c11 9574 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9575
f38b440c
PE
9576 * coding.c (coding_set_source, coding_set_destination):
9577 Use "else { /* comment */ }" rather than "else /* comment */;"
9578 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9579 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9580 a block, when the outer 'i' will do.
9581 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9582 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9583 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9584 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9585 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9586 Rename locals to avoid shadowing.
9587 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9588 * coding.c (emacs_mule_char, encode_invocation_designation):
9589 Now static, since they're not used elsewhere.
413bb2db 9590 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9591 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9592 (decode_coding_emacs_mule): Mark variables that gcc
9593 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9594 (detect_coding_iso_2022): Initialize a local variable that might
9595 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9596 this initialization is needed. (Bug#8211)
5f58e762
PE
9597 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9598 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9599 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9600 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9601 Remove unused macros.
f38b440c 9602
232b38b9 9603 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9604 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9605 * character.c (string_count_byte8): Likewise.
232b38b9 9606
fb90da1b
PE
9607 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9608 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9609
fb93dbc2
PE
9610 * chartab.c (copy_sub_char_table): Now static, since it's not used
9611 elsewhere.
5c156ace
PE
9612 (sub_char_table_ref_and_range, char_table_ref_and_range):
9613 Rename locals to avoid shadowing.
bbcd0949 9614 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9615
7d3b3862 9616 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9617 (BIDI_BOB): Remove unused macro.
7d3b3862 9618
6be7d3da
PE
9619 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9620 deduce are never used uninitialized.
c2ed9c8b 9621 * term.c (encode_terminal_code): Likewise.
6be7d3da 9622
75f8807f 9623 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9624
50938595
PE
9625 * tparam.h: New file.
9626 * term.c, tparam.h: Include it.
9627 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9628 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9629 Move these decls to tparam.h, and make them agree with what
9630 is actually in tparam.c. The previous trick of using incompatible
9631 decls in different modules does not conform to the C standard.
9632 All callers of tparam changed to use tparam's actual API.
9633 * tparam.c (tparam1, tparam, tgoto):
9634 Use const pointers where appropriate.
9635
fbceeba2
PE
9636 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9637 * cm.h (struct cm): Likewise.
9638 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9639 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9640 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9641 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9642 (turn_on_face, init_tty): Likewise.
9643 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9644
7f3f1250
PE
9645 * term.c (term_mouse_position): Rename local to avoid shadowing.
9646
e6ca6543
PE
9647 * alloc.c (mark_ttys): Move decl from here ...
9648 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9649
c40f8d15
AS
96502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9651
9652 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9653
cfe0661d
JB
96542011-03-09 Juanma Barranquero <lekktu@gmail.com>
9655
9656 * search.c (compile_pattern_1): Remove argument regp, unused since
9657 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9658 (compile_pattern): Don't pass it.
9659
0afb4571
J
96602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9661
9662 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9663 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9664 for ! HAVE_GTK3.
9665 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9666
9667 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9668
9669 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9670 gdk_window_get_screen, gdk_window_get_geometry,
9671 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9672 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9673 (xg_get_pixbuf_from_pixmap): New function.
9674 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9675 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9676 Call xg_get_pixbuf_from_pixmap instead of
9677 gdk_pixbuf_get_from_drawable.
9678 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9679 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9680 (xg_check_special_colors): Use GtkStyleContext and its functions
9681 for HAVE_GTK3.
9682 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9683 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9684 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9685 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9686 Call gtk_widget_get_preferred_size.
0afb4571
J
9687 (xg_frame_resized): gdk_window_get_geometry only takes 5
9688 parameters.
44f230aa
SM
9689 (xg_win_to_widget, xg_event_is_for_menubar):
9690 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9691 (xg_set_widget_bg): New function.
9692 (delete_cb): New function.
895009e1 9693 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9694 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9695 (xg_set_background_color): Call xg_set_widget_bg.
9696 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9697 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9698 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9699 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9700 if ! HAVE_GTK3.
9701 (update_frame_tool_bar): Call gtk_widget_hide.
9702 (xg_initialize): Use GDK_KEY_g.
9703
9704 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9705 if ! HAVE_GTK3
9706 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9707
9708 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9709 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9710 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9711
1c2cc4ef
JB
97122011-03-08 Juanma Barranquero <lekktu@gmail.com>
9713
9714 * w32xfns.c (select_palette): Check success of RealizePalette against
9715 GDI_ERROR, not zero.
9716
33383987 9717See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9718
9719;; Local Variables:
9720;; coding: utf-8
aac0c6e3
MR
9721;; End:
9722
acaf905b 9723 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9724
9725 This file is part of GNU Emacs.
9726
9727 GNU Emacs is free software: you can redistribute it and/or modify
9728 it under the terms of the GNU General Public License as published by
9729 the Free Software Foundation, either version 3 of the License, or
9730 (at your option) any later version.
9731
9732 GNU Emacs is distributed in the hope that it will be useful,
9733 but WITHOUT ANY WARRANTY; without even the implied warranty of
9734 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9735 GNU General Public License for more details.
9736
9737 You should have received a copy of the GNU General Public License
9738 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.