* net/gnutls.el (gnutls-negotiate): Upcase `gnutls-algorithm-priority'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
64348f40
AS
12011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2
3 * doc.c (Fsubstitute_command_keys): Revert last change.
4
1d698799
LMI
52011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6
f863868c
LMI
7 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8 quotes the next character, and doesn't affect other longer
9 sequences (bug#8935).
10
1d698799
LMI
11 * lread.c (syms_of_lread): Clarify that is isn't only
12 `eval-buffer' and `eval-defun' that's affected by
13 `lexical-binding' (bug#8460).
14
aa4b6df6
EZ
152011-07-15 Eli Zaretskii <eliz@gnu.org>
16
17 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
18 bidi redisplay when a line includes both an image and is
19 truncated.
20
5d856da6
PE
212011-07-14 Paul Eggert <eggert@cs.ucla.edu>
22
ad6042bb
PE
23 Fix minor problems found by static checking.
24 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
25 (elsz): Now a signed constant, not a size_t var. We prefer signed
26 types to unsigned, to avoid integer comparison confusion. Without
27 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
28 "cannot optimize loop, the loop counter may overflow", a symptom
29 of the confusion.
f00bbb22 30 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
31 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
32
6468f31c
LMI
332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
34
49080b10
LMI
35 * search.c (Fre_search_backward): Mention `case-fold-search' in
36 all the re_search_* functions (bug#8138).
37
6468f31c
LMI
38 * keyboard.c (Fopen_dribble_file): Document when the file is
39 closed (bug#8056).
40
c965adc5
EZ
412011-07-14 Eli Zaretskii <eliz@gnu.org>
42
df9733bf
EZ
43 * bidi.c (bidi_dump_cached_states): Fix format of displaying
44 bidi_cache_idx.
45
0bb23927
EZ
46 Support bidi reordering of display and overlay strings.
47 * xdisp.c (compute_display_string_pos)
48 (compute_display_string_end): Accept additional argument STRING.
49 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
50 (reseat_to_string): Initialize bidi_it->string.s and
51 bidi_it->string.schars.
52 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
53 NULL (avoids a crash in bidi_paragraph_init). Initialize
54 itb.string.lstring.
55 (init_iterator): Call bidi_init_it only of a valid
56 buffer position was specified. Initialize paragraph_embedding to
57 L2R.
58 (reseat_to_string): Initialize the bidi iterator.
59 (display_string): If we need to ignore text properties of
60 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
61 original value of -1 will not work with bidi.)
62 (compute_display_string_pos): First arg is now struct
63 `text_pos *'; all callers changed. Support display properties on
64 Lisp strings.
65 (compute_display_string_end): Support display properties on Lisp
66 strings.
67 (init_iterator, reseat_1, reseat_to_string): Initialize the
68 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
69 when iterating on a string not from display properties).
70 (compute_display_string_pos, compute_display_string_end): Fix
71 calculation of the object to scan. Fixes an error when using
72 arrow keys.
73 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
74 base_level_stop; instead, set base_level_stop to BEGV. Fixes
75 crashes in vertical-motion.
76 (next_element_from_buffer): Improve commentary for when
77 the iterator is before prev_stop.
78 (init_iterator): Initialize bidi_p from the default value of
79 bidi-display-reordering, not from buffer-local value. Use the
80 buffer-local value only if initializing for buffer iteration.
81 (handle_invisible_prop): Support invisible properties on strings
82 that are being bidi-reordered.
83 (set_iterator_to_next): Support bidi reordering of C strings and
84 Lisp strings.
85 (next_element_from_string): Support bidi reordering of Lisp
86 strings.
87 (handle_stop_backwards): Support Lisp strings as well.
88 (display_string): Support display of R2L glyph rows. Use
89 IT_STRING_CHARPOS when displaying from a Lisp string.
90 (init_iterator): Don't initialize it->bidi_p for strings
91 here.
92 (reseat_to_string): Initialize it->bidi_p for strings here.
93 (next_element_from_string, next_element_from_c_string)
94 (next_element_from_buffer): Add xassert's for correspondence
95 between IT's object being iterated and it->bidi_it.string
96 structure.
97 (face_before_or_after_it_pos): Support bidi iteration.
98 (next_element_from_c_string): Handle the case of the first string
99 character that is not the first one in the visual order.
100 (get_visually_first_element): New function, refactored from common
101 parts of next_element_from_buffer, next_element_from_string, and
102 next_element_from_c_string.
103 (tool_bar_lines_needed, redisplay_tool_bar)
104 (display_menu_bar): Force left-to-right direction. Add a FIXME
105 comment for making that be controlled by a user option.
106 (push_it, pop_it): Save and restore the state of the
107 bidi iterator. Save and restore the bidi_p flag.
108 (pop_it): Iterate out of display property for string iteration as
109 well.
110 (iterate_out_of_display_property): Support iteration over strings.
111 (handle_single_display_spec): Set up it->bidi_it for iteration
112 over a display string, and call bidi_init_it.
113 (handle_single_display_spec, next_overlay_string)
114 (get_overlay_strings_1, push_display_prop): Set up the bidi
115 iterator for displaying display or overlay strings.
116 (forward_to_next_line_start): Don't use the shortcut if
117 bidi-iterating.
118 (back_to_previous_visible_line_start): If handle_display_prop
119 pushed the iterator stack, restore the internal state of the bidi
120 iterator by calling bidi_pop_it same number of times.
121 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
122 and we are bidi-iterating, don't decrement the iterator position;
123 instead, set the first_elt flag in the bidi iterator, to produce
124 the same effect.
125 (reseat_1): Remove redundant setting of string_from_display_prop_p.
126 (push_display_prop): xassert that we are iterating a buffer.
127 (push_it, pop_it): Save and restore paragraph_embedding member.
128 (handle_single_display_spec, next_overlay_string)
129 (get_overlay_strings_1, reseat_1, reseat_to_string)
130 (push_display_prop): Set up the `unibyte' member of bidi_it.string
131 correctly. Don't assume unibyte strings are not bidi-reordered.
132 (compute_display_string_pos)
133 (compute_display_string_end): Fix handling the case of C string.
134 (push_it, pop_it): Save and restore from_disp_prop_p.
135 (handle_single_display_spec, push_display_prop): Set the
136 from_disp_prop_p flag.
137 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
138 (pop_it): Call iterate_out_of_display_property only if we are
139 popping after iteration over a string that came from a display
140 property. Fix a typo in popping stretch info. Add an assertion
141 for verifying that the iterator position is in sync with the bidi
142 iterator.
143 (handle_single_display_spec, get_overlay_strings_1)
144 (push_display_prop): Fix initialization of paragraph direction for
145 string when that of the parent object is not yet determined.
146 (reseat_1): Call bidi_init_it to resync the bidi
147 iterator with IT's position. (Bug#7616)
148 (find_row_edges): If ROW->start.pos gives position
149 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
150 (handle_stop, back_to_previous_visible_line_start, reseat_1):
151 Reset the from_disp_prop_p flag.
152 (SAVE_IT, RESTORE_IT): New macros.
153 (pos_visible_p, face_before_or_after_it_pos)
154 (back_to_previous_visible_line_start)
155 (move_it_in_display_line_to, move_it_in_display_line)
156 (move_it_to, move_it_vertically_backward, move_it_by_lines)
157 (try_scrolling, redisplay_window, display_line): Use them when
158 saving a temporary copy of the iterator and restoring it back.
159 (back_to_previous_visible_line_start, reseat_1)
160 (init_iterator): Empty the bidi cache "stack".
161 (move_it_in_display_line_to): If iterator ended up at
162 EOL, but we never saw any buffer positions smaller than
163 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
164 motion in bidi-reordered lines.
165 (move_it_in_display_line_to): Record prev_method and prev_pos
166 immediately before the call to set_iterator_to_next. Fixes cursor
167 motion in bidi-reordered lines with stretch glyphs and strings
168 displayed in margins. (Bug#8133) (Bug#8867)
169 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
170 TO_CHARPOS.
171 (pos_visible_p): Support positions in bidi-reordered lines. Save
172 and restore bidi cache.
173
174 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
175 (bidi_paragraph_info): Delete unused struct.
176 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
177 (bidi_cache_start): New variable.
178 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
179 to zero.
180 (bidi_cache_fetch_state, bidi_cache_search)
181 (bidi_cache_find_level_change, bidi_cache_iterator_state)
182 (bidi_cache_find, bidi_peek_at_next_level)
183 (bidi_level_of_next_char, bidi_find_other_level_edge)
184 (bidi_move_to_visually_next): Compare cache index with
185 bidi_cache_start rather than with zero.
186 (bidi_fetch_char): Accept new argument STRING; all callers
187 changed. Support iteration over a string. Support strings with
188 display properties. Support unibyte strings. Fix the type of
189 `len' according to what STRING_CHAR_AND_LENGTH expects.
190 (bidi_paragraph_init, bidi_resolve_explicit_1)
191 (bidi_resolve_explicit, bidi_resolve_weak)
192 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
193 iteration over a string.
194 (bidi_set_sor_type, bidi_resolve_explicit_1)
195 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
196 can now be zero (for strings); special values 0 and -1 were
197 changed to -1 and -2, respectively.
198 (bidi_char_at_pos): New function.
199 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
200 Call it instead of FETCH_MULTIBYTE_CHAR.
201 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
202 initialized to valid values.
203 (bidi_init_it): Don't initialize charpos and bytepos with invalid
204 values.
205 (bidi_level_of_next_char): Allow the sentinel "position" to pass
206 the test for valid cached positions. Fix the logic for looking up
207 the sentinel state in the cache. GCPRO the Lisp string we are
208 iterating.
209 (bidi_push_it, bidi_pop_it): New functions.
210 (bidi_initialize): Initialize the bidi cache start stack pointer.
211 (bidi_cache_ensure_space): New function, refactored from part of
212 bidi_cache_iterator_state. Don't assume the required size is just
213 one BIDI_CACHE_CHUNK away.
214 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
215 (bidi_count_bytes, bidi_char_at_pos): New functions.
216 (bidi_cache_search): Don't assume bidi_cache_last_idx is
217 always valid if bidi_cache_idx is valid.
218 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
219 is valid if it's going to be used.
220 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
221 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
222 (bidi_cache_find_level_change, bidi_cache_ensure_space)
223 (bidi_cache_iterator_state, bidi_cache_find)
224 (bidi_find_other_level_edge, bidi_cache_start_stack): All
225 variables related to cache indices are now EMACS_INT.
226
0bb23927
EZ
227 * dispextern.h (struct bidi_string_data): New structure.
228 (struct bidi_it): New member `string'. Make flag members be 1-bit
229 fields, and put them last in the struct.
230 (compute_display_string_pos, compute_display_string_end): Update
231 prototypes.
232 (bidi_push_it, bidi_pop_it): Add prototypes.
233 (struct iterator_stack_entry): New members bidi_p,
234 paragraph_embedding, and from_disp_prop_p.
235 (struct it): Member bidi_p is now a bit field 1 bit wide.
236 (bidi_shelve_cache, bidi_unshelve_cache): Declare
237 prototypes.
238
239 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
240 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
241 and vector-like objects.
242
243 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
244 cache around display iteration.
245
246 * window.c (Fwindow_end, window_scroll_pixel_based)
247 (displayed_window_lines, Frecenter): Save and restore the bidi
248 cache around display iteration.
249
3bbd2265
LMI
2502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
251
252 * editfns.c (Fdelete_region): Clarify the use of the named
253 parameters (bug#6788).
254
adc47434
MR
2552011-07-14 Martin Rudalics <rudalics@gmx.at>
256
257 * indent.c (Fvertical_motion): Set and restore w->pointm when
258 saving and restoring the window's buffer (Bug#9006).
259
837c31f8
LMI
2602011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
261
262 * editfns.c (Fstring_to_char): Clarify just what is returned
263 (bug#6576). Text by Eli Zaretskii.
264
ac389d0c
JB
2652011-07-13 Juanma Barranquero <lekktu@gmail.com>
266
267 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
268
0be0ce47
EZ
2692011-07-13 Eli Zaretskii <eliz@gnu.org>
270
271 * buffer.c (mmap_find): Fix a typo.
272
cd18e7e3
JB
2732011-07-13 Johan Bockgård <bojohan@gnu.org>
274
275 Fix execution of x selection hooks.
276 * xselect.c (Qx_lost_selection_functions)
277 (Qx_sent_selection_functions): New vars.
278 (syms_of_xselect): DEFSYM them.
279 (x_handle_selection_request): Pass Qx_sent_selection_functions
280 rather than Vx_sent_selection_functions to Frun_hook_with_args.
281 (x_handle_selection_clear,x_clear_frame_selections):
282 Pass Qx_lost_selection_functions rather than
283 Vx_lost_selection_functions to Frun_hook_with_args.
284
47ea7f44
PE
2852011-07-13 Paul Eggert <eggert@cs.ucla.edu>
286
ac389d0c 287 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
288 The old code sometimes used this field without initializing it.
289
47ea7f44
PE
290 * alloc.c (gc_sweep): Don't read past end of array.
291 In theory, the old code could also have corrupted Emacs internals,
292 though it'd be very unlikely.
293
bc985c87
AS
2942011-07-12 Andreas Schwab <schwab@linux-m68k.org>
295
296 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 297 argument. (Bug#4026)
bc985c87 298
0cf34688
LMI
2992011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
300
b3dadd76
LMI
301 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
302 key" (bug#4257).
303
0cf34688
LMI
304 * window.c (Fset_window_start): Doc fix (bug#4199).
305 (Fset_window_hscroll): Ditto.
306
270768cd
PE
3072011-07-12 Paul Eggert <eggert@cs.ucla.edu>
308
077e3dda 309 Fix minor new problems caught by GCC 4.6.1.
270768cd 310 * term.c (init_tty): Remove unused local.
490011a6 311 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 312 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 313 not used otherwise.
270768cd 314
b1f58454
CY
3152011-07-12 Chong Yidong <cyd@stupidchicken.com>
316
317 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
318
22b9578d
LMI
3192011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
320
6e70ab07
LMI
321 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
322 are the mini-buffer and the echo area (bug#3320).
323
22b9578d
LMI
324 * term.c (init_tty): Remove support for supdup, c10 and perq
325 terminals, which are no longer supported (bug#1482).
326
8974cc9f
JB
3272011-07-10 Johan Bockgård <bojohan@gnu.org>
328
329 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
330
a560d974
JD
3312011-07-10 Jan Djärv <jan.h.d@swipnet.se>
332
333 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
334 for non-popups (Bug#3642).
335
1dae0f0a
AS
3362011-07-10 Andreas Schwab <schwab@linux-m68k.org>
337
268c2c36 338 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 339 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
340 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
341 * cm.c (losecursor): Likewise.
1dae0f0a
AS
342 * data.c (fmod): Likewise.
343 * dispnew.c (swap_glyphs_in_rows): Likewise.
344 * emacs.c (memory_warning_signal): Likewise.
345 * floatfns.c (float_error): Likewise.
346 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
347 (otf_open, font_otf_capability, generate_otf_features)
348 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
349 Likewise.
350 * image.c (pbm_read_file): Likewise.
351 * indent.c (string_display_width): Likewise.
352 * intervals.c (check_for_interval, search_for_interval)
353 (inc_interval_count, count_intervals, root_interval)
354 (adjust_intervals_for_insertion, make_new_interval): Likewise.
355 * lread.c (defalias): Likewise.
268c2c36 356 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
357 * regex.c (set_image_of_range_1, set_image_of_range)
358 (regex_grow_registers): Likewise.
359 * sysdep.c (strerror): Likewise.
360 * termcap.c (valid_filename_p, tprint, main): Likewise.
361 * tparam.c (main): Likewise.
362 * unexhp9k800.c (run_time_remap, save_data_space)
363 (update_file_ptrs, read_header, write_header, calculate_checksum)
364 (copy_file, copy_rest, display_header): Likewise.
365 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
366 Likewise.
367 * xdisp.c (check_it): Likewise.
368 * xfaces.c (register_color, unregister_color, unregister_colors):
369 Likewise.
370 * xfns.c (print_fontset_result): Likewise.
371 * xrdb.c (member, fatal, main): Likewise.
372
99033785
PE
3732011-07-10 Paul Eggert <eggert@cs.ucla.edu>
374
375 Fix minor problems found by static checking (Bug#9031).
376 * chartab.c (char_table_set_range, map_sub_char_table):
377 Remove unused locals.
378 (uniprop_table): Now static.
379 * composite.c (_work_char): Remove unused static var.
380
9cb2ac56
JB
3812011-07-09 Juanma Barranquero <lekktu@gmail.com>
382
383 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
384
f25661f0
JD
3852011-07-09 Jan Djärv <jan.h.d@swipnet.se>
386
387 * gtkutil.c (qttip_cb): Remove code without function.
388
8278c4fe
EZ
3892011-07-09 Eli Zaretskii <eliz@gnu.org>
390
391 * w32.c (pthread_sigmask): New stub.
392
1692ae2d 3932011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 394
8a6ebd58 395 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
396 sigprocmask is portable only for single-threaded applications, and
397 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
398 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
399 (LIBES): Use it.
400 * callproc.c (Fcall_process):
401 * process.c (create_process):
402 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
403 Use pthread_sigmask, not sigprocmask.
123403e4 404
1b854618
JD
4052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
406
407 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
408 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
409 wrong (Bug#8591).
410
3fe4b549
JD
4112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
412
0ce7e563
JD
413 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
414 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
415 (xg_hide_tooltip): Fix comment.
416
3fe4b549
JD
417 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
418 in registerServicesMenuSendTypes.
419 (validRequestorForSendType): Don't check ns_return_types.
420
421 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
422 ns_return_type.
423
5df75e47
JR
4242011-07-08 Jason Rumney <jasonr@gnu.org>
425
426 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
427 frame struct members of non-existent frames (Bug#6284).
428
699c10bd
JD
4292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
430
4393663b
JD
431 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
432 variable firstTime not needed on OSX >= 10.6.
433 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
434 >= 10.5. Use setKnobProportion, setDoubleValue.
435
436 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
437 (MAC_OS_X_VERSION_10_5): Define if not defined.
438 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
439 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
440 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
441
442 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
443 cString and lossyCString on OSX >= 10.4
444
445 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
446 sizeToFit on OSX >= 10.2.
447
448 * nsimage.m (allocInitFromFile): Don't use deprecated method
449 bestRepresentationForDevice on OSX >= 10.6.
450
451 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
452 to avoid warning.
453
454 * emacs.c: Declare unexec_init_emacs_zone.
455
a63e0781
JD
456 * nsgui.h: Fix compiler warning about gnulib redefining verify.
457
699c10bd
JD
458 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
459
460 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
461 on svcsMenu (Bug#8842).
462
463 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
464 ns_return_types.
465 (Fns_list_services): Just return Qnil on 10.6, code not working there.
466
467 * nsterm.m (QUTF8_STRING): Declare.
468 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
469 (validRequestorForSendType): Return type is (id).
470 Change indexOfObjectIdenticalTo to indexOfObject.
471 Check if we have local selection before returning self (Bug#8842).
472 (writeSelectionToPasteboard): Put local selection into paste board
473 if we have a local selection (Bug#8842).
474 (syms_of_nsterm): DEFSYM QUTF8_STRING.
475
476 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
477 (ns_get_local_selection): Declare.
478
54e10184
LMI
4792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
480
9888ff71
LMI
481 * keymap.c (describe_map_tree): Don't insert a double newline at
482 the end of the buffer (bug#1169) and return whether we inserted
483 something.
484
54e10184
LMI
485 * callint.c (Fcall_interactively): Change "reading args" to
486 "providing args" to try to clarify what it does (bug#1010).
487
15fa4783
KH
4882011-07-07 Kenichi Handa <handa@m17n.org>
489
490 * composite.c (composition_compute_stop_pos): Ignore a static
491 composition starting before CHARPOS (Bug#8915).
492
493 * xdisp.c (handle_composition_prop): Likewise.
494
a8815b00
EZ
4952011-07-07 Eli Zaretskii <eliz@gnu.org>
496
497 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
498 (Bug#9015)
499
ef7b981d 5002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
501
502 * character.h (unicode_category_t): New enum type.
503
504 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
505 (Qchar_code_property_table): New variable.
506 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
507 (UNIPROP_COMPRESSED_FORM_P): New macros.
508 (char_table_ascii): Uncompress the compressed values.
509 (sub_char_table_ref): New arg is_uniprop. Callers changed.
510 Uncompress the compressed values.
ac389d0c 511 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
512 (char_table_ref_and_range): Uncompress the compressed values.
513 (sub_char_table_set): New arg is_uniprop. Callers changed.
514 Uncompress the compressed values.
515 (sub_char_table_set_range): Args changed. Callers changed.
516 (char_table_set_range): Adjuted for the above change.
517 (map_sub_char_table): Delete args default_val and parent. Add arg
518 top. Give decoded values to a Lisp function.
519 (map_char_table): Adjusted for the above change. Give decoded
520 values to a Lisp function. Gcpro more variables.
521 (uniprop_table_uncompress)
522 (uniprop_decode_value_run_length): New functions.
523 (uniprop_decoder, uniprop_decoder_count): New variables.
524 (uniprop_get_decoder, uniprop_encode_value_character)
525 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
526 New functions.
527 (uniprop_encoder, uniprop_encoder_count): New variables.
528 (uniprop_get_encoder, uniprop_table)
529 (Funicode_property_table_internal, Fget_unicode_property_internal)
530 (Fput_unicode_property_internal): New functions.
531 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
532 Sunicode_property_table_internal, Sget_unicode_property_internal,
533 and Sput_unicode_property_internal. Defvar_lisp
534 char-code-property-alist.
535
536 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
537 Vunicode_category_table.
538
539 * font.c (font_range): Adjusted for the change of
540 Vunicode_category_table.
541
76b397fb
DN
5422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
543
544 * m/iris4d.h: Remove file, move contents ...
545 * s/irix6-5.h: ... here.
546
22b4128e
PE
5472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
548
549 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
550 * alloc.c (mark_buffer):
551 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
552 (clone_per_buffer_values): Don't assume that
22b4128e
PE
553 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
554 This isn't true in general, and it's particularly not true
555 if Emacs is configured with --with-wide-int.
556 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
557 New macros, used in the buffer.c change.
558
869795d6
JD
5592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
560
561 * xsettings.c: Use both GConf and GSettings if both are available.
562 (store_config_changed_event): Add comment.
563 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
564 (store_tool_bar_style_changed): New functions.
565 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
566 (struct xsettings): Move font inside HAVE_XFT.
567 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
568 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
569 Move inside HAVE_XFT.
570 (something_changed_gsettingsCB): Renamed from something_changedCB.
571 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
572 also.
573 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
574 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
575 (something_changed_gconfCB): Renamed from something_changedCB.
576 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
577 (parse_settings): Move check for font inside HAVE_XFT.
578 (read_settings, apply_xft_settings): Add comment.
579 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
580 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
581 call store_font_name_changed.
582 (xft_settings_event): Add comment.
583 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
584 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
585 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
586 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
587 (xsettings_initialize): Call init_gsettings last.
588 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
589 comment.
590
d8ed26bd
PE
5912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
592
593 Random fixes. E.g., (random) never returned negative values.
594 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
595 subseconds part to the entropy, as that's a bit more random.
596 Prefer signed to unsigned, since the signedness doesn't matter and
597 in general we prefer signed. When given a limit, use a
598 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
599 latter isn't right if USE_2_TAGS_FOR_INTS.
600 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
601 not 0..VALMASK. Don't discard "excess" bits that random () returns.
602
cabf1cac
SM
6032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
604
605 * textprop.c (text_property_stickiness):
606 Obey Vtext_property_default_nonsticky.
607 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
608 * w32fns.c (syms_of_w32fns):
609 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
610
6e9b2be9
PE
6112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
612
613 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
614 This is more efficient than Ffile_directory_p and avoids a minor race.
615
90186c68
LMI
6162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
617
7c301272
LMI
618 * buffer.c (Foverlay_put): Say what the return value is
619 (bug#7835).
620
c4f2d8d4
LMI
621 * fileio.c (barf_or_query_if_file_exists): Check first if the file
622 is a directory before asking whether to use the file name
623 (bug#7564).
ad637907
LMI
624 (barf_or_query_if_file_exists): Make the "File is a directory"
625 error be more correct.
c4f2d8d4 626
90186c68
LMI
627 * fns.c (Frequire): Remove the mention of the .gz files, since
628 that's installation-specific, but keep the mention of
629 `get-load-suffixes'.
630
da64016e
PE
6312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
632
633 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
634 Report string overflow if the output is too long.
635
7d47b580
JB
6362011-07-04 Juanma Barranquero <lekktu@gmail.com>
637
a555cb87
JB
638 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
639 (syms_of_gnutls): Remove duplicate DEFSYM for
640 Qgnutls_bootprop_verify_hostname_error, an error for
641 Qgnutls_bootprop_verify_error (which is no longer used).
642
7d47b580
JB
643 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
644 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
645 Also (re)move comments that are misplaced or no longer relevant.
646
1e49bfab
LMI
6472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
648
649 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
650
1485f4c0
CY
6512011-07-03 Chong Yidong <cyd@stupidchicken.com>
652
653 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
654 and background color parameters if they have been changed.
655
a9ab721e
LMI
6562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
657
658 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
659
cf7cff57
PE
6602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
661
2e13213d
PE
662 * xsettings.c (SYSTEM_FONT): Define only when used.
663 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
664
cf7cff57
PE
665 * keymap.c (access_keymap_1): Now static.
666
7a8e04f7
CY
6672011-07-02 Chong Yidong <cyd@stupidchicken.com>
668
669 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
670 leave any prefix arg for the up event (Bug#1586).
671
61352f62
LMI
6722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
673
69bb1ef7
LMI
674 * lread.c (syms_of_lread): Mention single symbols defined by
675 `defvar' or `defconst' (bug#7154).
676
61352f62 677 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 678 (Frequire): Mention get-load-suffixes.
61352f62 679
28545e04
MR
6802011-07-02 Martin Rudalics <rudalics@gmx.at>
681
682 * window.h (window): Remove clone_number slot.
683 * window.c (Fwindow_clone_number, Fset_window_clone_number):
684 Remove.
685 (make_parent_window, make_window, saved_window)
686 (Fset_window_configuration, save_window_save): Don't deal with
687 clone numbers.
688 * buffer.c (Qclone_number): Remove declaration.
689 (sort_overlays, overlay_strings): Don't deal with clone numbers.
690
3349e122
SM
6912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
692
693 Add multiple inheritance to keymaps.
694 * keymap.c (Fmake_composed_keymap): New function.
695 (Fset_keymap_parent): Simplify.
696 (fix_submap_inheritance): Remove.
697 (access_keymap_1): New function extracted from access_keymap to handle
698 embedded parents and handle lists of maps.
699 (access_keymap): Use it.
700 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
701 (Fcopy_keymap): Handle embedded parents.
702 (Fcommand_remapping, define_as_prefix): Simplify.
703 (Fkey_binding): Simplify.
704 (syms_of_keymap): Move minibuffer-local-completion-map,
705 minibuffer-local-filename-completion-map,
706 minibuffer-local-must-match-map, and
707 minibuffer-local-filename-must-match-map to Elisp.
708 (syms_of_keymap): Defsubr make-composed-keymap.
709 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
710 (parse_menu_item): Trivial simplification.
711
3279eb87
GM
7122011-07-01 Glenn Morris <rgm@gnu.org>
713
714 * Makefile.in (SETTINGS_LIBS): Fix typo.
715
4550efdf
KI
7162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
717
718 * coding.c (Fencode_coding_string): Record the last coding system
719 used, as the function doc string says (bug#8738).
720
0949d2b6
JD
7212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
722
723 * xsettings.c (store_monospaced_changed): Take new font as arg and
724 check for change against current_mono_font.
725 (EMACS_TYPE_SETTINGS): Remove this and related defines.
726 (emacs_settings_constructor, emacs_settings_get_property)
727 (emacs_settings_set_property, emacs_settings_class_init)
728 (emacs_settings_init, gsettings_obj): Remove.
729 (something_changedCB): New function for HAVE_GSETTINGS.
730 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
731 with value as argument.
732 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
733 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 734 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
735 "changed".
736
737 * xgselect.c: Add defined (HAVE_GSETTINGS).
738 (xgselect_initialize): Ditto.
739
740 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
741 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
742 xg_select.
743
bbc6b304
PE
7442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
745
746 * eval.c (struct backtrace): Simplify and port the data structure.
747 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
748 signed bit field, as this assumption is not portable and it makes
749 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
750 "char debug_on_exit : 1" as this is not portable either; instead,
751 use the portable "unsigned int debug_on_exit : 1". Remove unused
752 member evalargs. Remove obsolete comments about cc bombing out.
753
9851bfc5
JD
7542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
755
51bb811f 756 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
757 Let HAVE_GSETTINGS override HAVE_GCONF.
758 (store_monospaced_changed): New function.
759 (EMACS_SETTINGS): A new type derived from GObject to handle
760 GSettings notifications.
761 (emacs_settings_constructor, emacs_settings_get_property)
762 (emacs_settings_set_property, emacs_settings_class_init):
763 New functions.
764 (gsettings_client, gsettings_obj): New variables.
765 (GSETTINGS_SCHEMA): New define.
766 (something_changedCB): Call store_monospaced_changed.
767 (init_gsettings): New function.
768 (xsettings_initialize): Call init_gsettings.
769 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
770 to NULL.
771
772 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
773 GCONF_CFLAGS/LIBS.
774
5386012d
MR
7752011-06-29 Martin Rudalics <rudalics@gmx.at>
776
777 * window.c (resize_root_window, grow_mini_window)
778 (shrink_mini_window): Rename Qresize_root_window to
779 Qwindow_resize_root_window and Qresize_root_window_vertically to
780 Qwindow_resize_root_window_vertically.
781
f13e0b08
PE
7822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
783
784 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
785
94515237
JB
7862011-06-27 Juanma Barranquero <lekktu@gmail.com>
787
788 * makefile.w32-in: Redesign dependencies so they reflect more
789 clearly which files are directly included by each source file,
790 and not through other includes.
791
e43b6e43
MR
7922011-06-27 Martin Rudalics <rudalics@gmx.at>
793
794 * buffer.c (Qclone_number): Declare static and DEFSYM it.
795 (sort_overlays, overlay_strings): When an overlay's clone number
796 matches the window's clone number process the overlay even if
797 the overlay's window property doesn't match the current window.
798
d68443dc
MR
799 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
800 (Fwindow_hchild): Rename to Fwindow_left_child.
801 (Fwindow_next): Rename to Fwindow_next_sibling.
802 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
803 (resize_window_check): Rename to window_resize_check.
804 (resize_window_apply): Rename to window_resize_apply.
805 (Fresize_window_apply): Rename to Fwindow_resize_apply.
806 (Fdelete_other_windows_internal, resize_frame_windows)
807 (Fsplit_window_internal, Fdelete_window_internal)
808 (grow_mini_window, shrink_mini_window)
809 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 810
c7e73be5
JD
8112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
812
813 * emacsgtkfixed.h: State that this is only used with Gtk+3.
814 (emacs_fixed_set_min_size): Remove.
815 (emacs_fixed_new): Take frame as argument.
816
817 * emacsgtkfixed.c: State that this is only used with Gtk+3.
818 (_EmacsFixedPrivate): Remove minwidth/height.
819 Add struct frame *f.
820 (emacs_fixed_init): Initialize priv->f.
821 (get_parent_class, emacs_fixed_set_min_size): Remove.
822 (emacs_fixed_new): Set priv->f to argument.
823 (emacs_fixed_get_preferred_width)
824 (emacs_fixed_get_preferred_height): Use min_width/height from
825 frames size_hint to set minimum and natural (Bug#8919).
826 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
827 and use min_width/height from frames size_hint to set
828 min_width/height (Bug#8919).
829
830 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
831 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
832 Fix indentation.
c7e73be5 833
cf99dcf8
EZ
8342011-06-26 Eli Zaretskii <eliz@gnu.org>
835
836 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
837 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
838 called at ZV.
839
029529ac
CY
8402011-06-26 Chong Yidong <cyd@stupidchicken.com>
841
842 * process.c (wait_reading_process_output): Bypass select if
843 waiting for a cell while ignoring keyboard input, and input is
844 pending. Suggested by Jan Djärv (Bug#8869).
845
7a7ef429
PE
8462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
847
848 Use gnulib's dup2 module instead of rolling our own.
849 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
850
11fdef7d 8512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
852
853 * dispnew.c (scrolling_window): Before scrolling, turn off a
854 mouse-highlight in the window being scrolled.
855
cd3520a4
JB
8562011-06-24 Juanma Barranquero <lekktu@gmail.com>
857
858 Move DEFSYM to lisp.h and use everywhere.
859
860 * character.h (DEFSYM): Move declaration...
861 * lisp.h (DEFSYM): ...here.
862
863 * gnutls.c:
864 * minibuf.c:
865 * w32menu.c:
866 * w32proc.c:
867 * w32select.c: Don't include character.h.
868
869 * alloc.c (syms_of_alloc):
870 * buffer.c (syms_of_buffer):
871 * bytecode.c (syms_of_bytecode):
872 * callint.c (syms_of_callint):
873 * casefiddle.c (syms_of_casefiddle):
874 * casetab.c (init_casetab_once):
875 * category.c (init_category_once, syms_of_category):
876 * ccl.c (syms_of_ccl):
877 * cmds.c (syms_of_cmds):
878 * composite.c (syms_of_composite):
879 * dbusbind.c (syms_of_dbusbind):
880 * dired.c (syms_of_dired):
881 * dispnew.c (syms_of_display):
882 * doc.c (syms_of_doc):
883 * editfns.c (syms_of_editfns):
884 * emacs.c (syms_of_emacs):
885 * eval.c (syms_of_eval):
886 * fileio.c (syms_of_fileio):
887 * fns.c (syms_of_fns):
888 * frame.c (syms_of_frame):
889 * fringe.c (syms_of_fringe):
890 * insdel.c (syms_of_insdel):
891 * keymap.c (syms_of_keymap):
892 * lread.c (init_obarray, syms_of_lread):
893 * macros.c (syms_of_macros):
894 * msdos.c (syms_of_msdos):
895 * print.c (syms_of_print):
896 * process.c (syms_of_process):
897 * search.c (syms_of_search):
898 * sound.c (syms_of_sound):
899 * syntax.c (init_syntax_once, syms_of_syntax):
900 * terminal.c (syms_of_terminal):
901 * textprop.c (syms_of_textprop):
902 * undo.c (syms_of_undo):
903 * w32.c (globals_of_w32):
904 * window.c (syms_of_window):
905 * xdisp.c (syms_of_xdisp):
906 * xfaces.c (syms_of_xfaces):
907 * xfns.c (syms_of_xfns):
908 * xmenu.c (syms_of_xmenu):
909 * xsettings.c (syms_of_xsettings):
910 * xterm.c (syms_of_xterm): Use DEFSYM.
911
4228cf16
TZ
9122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
913
cd3520a4 914 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 915
7fcccf1e
PE
9162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
917
7efb4e0e
PE
918 Integer and buffer overflow fixes (Bug#8873).
919
ff5844ad
PE
920 * print.c (printchar, strout): Check for string overflow.
921 (PRINTPREPARE, printchar, strout):
922 Don't set size unless allocation succeeds.
923
90532f02
PE
924 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
925 for sizes. Check for string overflow more accurately.
926 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
927
6d84508d
PE
928 * macros.c: Integer and buffer overflow fixes.
929 * keyboard.h (struct keyboard.kbd_macro_bufsize):
930 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
931 Use ptrdiff_t, not int, for sizes.
932 Don't increment bufsize until after realloc succeeds.
933 Check for size-calculation overflow.
934 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
935
437b2cb4
PE
936 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
937
8b9ac8b4
PE
938 * lread.c: Integer overflow fixes.
939 (read_integer): Radix is now EMACS_INT, not int,
940 to improve quality of diagnostics for out-of-range radices.
941 Calculate buffer size correctly for out-of-range radices.
942 (read1): Check for integer overflow in radices, and in
943 read-circle numbers.
82cb60d3
PE
944 (read_escape): Avoid int overflow.
945 (Fload, openp, read_buffer_size, read1)
946 (substitute_object_recurse, read_vector, read_list, map_obarray):
947 Use ptrdiff_t, not int, for sizes.
948 (read1): Use EMACS_INT, not int, for sizes.
20270765 949 Check for size overflow.
8b9ac8b4 950
7fcccf1e
PE
951 * image.c (cache_image): Check for size arithmetic overflow.
952
bfbbd7e7
PE
953 * lread.c: Integer overflow issues.
954 (saved_doc_string_size, saved_doc_string_length)
955 (prev_saved_doc_string_size, prev_saved_doc_string_length):
956 Now ptrdiff_t, not int.
957 (read1): Don't assume doc string length fits in int. Check for
958 out-of-range doc string lengths.
959 (read_list): Don't assume file position fits in int.
39019e54 960 (read_escape): Check for hex character overflow.
bfbbd7e7 961
4e323265
LL
9622011-06-22 Leo Liu <sdl.web@gmail.com>
963
964 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
965 Move to minibuffer.el.
966
85fece3e
PE
9672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
968
20b84ce9 969 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
970 The following patches are for when GLYPH_DEBUG && !XASSERT.
971 * dispextern.h (trace_redisplay_p, dump_glyph_string):
972 * dispnew.c (flush_stdout):
973 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
974 Mark as externally visible.
975 * dispnew.c (check_window_matrix_pointers): Now static.
976 * dispnew.c (window_to_frame_vpos):
977 * xfns.c (unwind_create_frame):
978 * xterm.c (x_check_font): Remove unused local.
979 * scroll.c (CHECK_BOUNDS):
980 * xfaces.c (cache_fache): Rename local to avoid shadowing.
981 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
982 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
983 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
984 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
985 Now static.
986 (debug_method_add): Use va_list and vsprintf rather than relying
987 on undefined behavior with wrong number of arguments.
988 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
989 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
990 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
991 since we're not interested in debugging glyphs with old libraries.
992 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
993 GCC 4.6.0's static checking.
994
0766b489
PE
9952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
996
31fd4b32
PE
997 Integer overflow and signedness fixes (Bug#8873).
998 A few related buffer overrun fixes, too.
999
b79e8648
PE
1000 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1001
0766b489
PE
1002 * dispextern.h (struct face.stipple):
1003 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1004 (x_bitmap_mask, x_allocate_bitmap_record)
1005 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1006 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1007 (x_create_bitmap_from_xpm_data):
1008 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1009 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1010 (.bitmaps_last):
1011 * xfaces.c (load_pixmap):
1012 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1013 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1014 (.bitmaps_last, struct x_output.icon_bitmap):
1015 Use ptrdiff_t, not int, for bitmap indexes.
1016 (x_allocate_bitmap_record): Check for size overflow.
1017 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1018
b081724f
PE
1019 Use ptrdiff_t, not int, for overlay counts.
1020 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1021 * editfns.c (overlays_around, get_pos_property):
1022 * textprop.c (get_char_property_and_overlay):
1023 * xdisp.c (next_overlay_change, note_mouse_highlight):
1024 * xfaces.c (face_at_buffer_position):
21514da7
PE
1025 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1026 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1027 (Fnext_overlay_change, Fprevious_overlay_change)
1028 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1029 Use ptrdiff_t, not int, for sizes.
21514da7 1030 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1031
3de73e5e
PE
1032 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1033
2606c57b
PE
1034 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1035 (x_session_initialize): Do not assume string length fits in int.
1036
aaafe47a
PE
1037 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1038 This is unlikely, but can occur if DPI is outlandish.
1039
2674ddc8 1040 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1041 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1042
28154962
PE
1043 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1044 * xrdb.c (magic_file_p, search_magic_path):
1045 Omit last arg SUFFIX; it was always 0. All callers changed.
1046 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1047
7de51af5
PE
1048 * xfont.c (xfont_match): Avoid need for strlen.
1049
25ed6cc3
PE
1050 * xfns.c: Don't assume strlen fits in int.
1051 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1052
4eab31dd
PE
1053 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1054 not unsigned long, as we prefer signed integers. All callers changed.
1055 Detect integer overflow in repeat count.
1056 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1057 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1058
171e2a58
PE
1059 * termcap.c: Don't assume sizes fit in int and never overflow.
1060 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1061 (gobble_line): Check for size-calculation overflow.
1062
ad39faca 1063 * minibuf.c (Fread_buffer):
6e5bb2dc 1064 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1065 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1066 Don't assume string length fits in int.
1067
52c61c22 1068 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1069 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1070
b5b8c9e5
PE
1071 * font.c: Don't assume string length fits in int.
1072 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1073 Use ptrdiff_t, not int.
ccd6111c
PE
1074 (font_intern_prop): Don't assume string length fits in int.
1075 Don't assume integer property fits in fixnum.
1076 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1077
882f0d81 1078 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1079 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1080 Reformulate so as not to need the command string.
1081 Invoke gzip -cd rather than gunzip, as it's more portable.
1082 (lock_info_type, lock_file_1, lock_file):
1083 Don't assume pid_t and time_t fit in unsigned long.
1084 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1085 (current_lock_owner): Prefer signed type for sizes.
1086 Use memcpy, not strncpy, where memcpy is what is really wanted.
1087 Don't assume (via atoi) that time_t and pid_t fit in int.
1088 Check for time_t and/or pid_t out of range, e.g., via a network share.
1089 Don't alloca where an auto var works fine.
1090
93f4cf88
PE
1091 * fileio.c: Fix some integer overflow issues.
1092 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1093 Don't assume string length fits in int.
1094 (directory_file_name): Don't assume string length fits in long.
1095 (make_temp_name): Don't assume pid fits in int, or that its print
1096 length is less than 20.
1097
f3e92b69
PE
1098 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1099
1bfdaf10
PE
1100 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1101
35016e9a
PE
1102 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1103
3d1e65a1
PE
1104 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1105 We prefer signed integers, even for size calculations.
1106
0b963a93
PE
1107 * emacs.c: Don't assume string length fits in 'int'.
1108 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1109 (main): Don't invoke strlen when not needed.
1110
573f4b54
PE
1111 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1112 (XD_DEBUG_MESSAGE): Don't waste a byte.
1113
989f33ba
PE
1114 * callproc.c (getenv_internal_1, getenv_internal)
1115 (Fgetenv_internal):
965d34eb
PE
1116 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1117
e4d29b33
PE
1118 * lread.c (invalid_syntax): Omit length argument.
1119 All uses changed. This doesn't fix a bug, but it simplifies the
1120 code away from its former Hollerith-constant appearance, and it's
1121 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1122 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1123
eb49b136
PE
1124 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1125 This didn't break anything, but it didn't help either.
1126 It's confusing to put a bogus integer in a place where the actual
1127 value does not matter.
9f62aeb1 1128 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1129 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1130
15375a22
PE
1131 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1132 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1133 implementation.
b61cc01c
PE
1134 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1135 We prefer signed types, and the value cannot exceed the EMACS_INT
1136 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1137 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1138 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1139 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1140
53b2623d
PE
1141 * indent.c (sane_tab_width): New function.
1142 (current_column, scan_for_column, Findent_to, position_indentation)
1143 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1144 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1145
51cab52b 1146 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1147
f2ed8a70
PE
1148 * lisp.h (lint_assume): New macro.
1149 * composite.c (composition_gstring_put_cache):
1150 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1151
abe80cc6
PE
1152 * editfns.c, insdel.c:
1153 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1154
b02c740e
PE
1155 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1156
ebc96716
PE
1157 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1158
b4e50fa0 1159 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1160 Use much-faster test for byte-length change.
311d5d7c 1161 Don't assume string byte-length fits in 'int'.
a4cf38e4 1162 Check that character arg fits in 'int'.
85461888 1163 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1164
c0c1ee9f
PE
1165 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1166
a498d7f4
PE
1167 * fns.c (concat): Catch string overflow earlier.
1168 Do not rely on integer wraparound.
1169
51cab52b
PE
1170 * dispextern.h (struct it.overlay_strings_charpos)
1171 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1172 * xdisp.c (forward_to_next_line_start)
1173 (back_to_previous_visible_line_start)
1174 (reseat_at_next_visible_line_start, next_element_from_buffer):
1175 Don't arbitrarily truncate the value of 'selective' to int.
1176
76031fad
PE
1177 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1178
5eb55db9
PE
1179 * composite.c: Don't truncate sizes to 'int'.
1180 (composition_gstring_p, composition_reseat_it)
1181 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1182 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1183 not EMACS_UINT, for indexes.
5eb55db9 1184
0703a717
PE
1185 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1186
d6202519
PE
1187 * buffer.c: Include <verify.h>.
1188 (struct sortvec.priority, struct sortstr.priority):
8961a454 1189 Now EMACS_INT, not int.
c20998a7 1190 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1191 (struct sortstr.size, record_overlay_string)
1192 (struct sortstrlist.size, struct sortlist.used):
1193 Don't truncate size to int.
1194 (record_overlay_string): Check for size-calculation overflow.
d6202519 1195 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1196
d5a19415
JM
11972011-06-22 Jim Meyering <meyering@redhat.com>
1198
029529ac 1199 Don't leak an XBM-image-sized buffer
d5a19415
JM
1200 * image.c (xbm_load): Free the image buffer after using it.
1201
a9041e6c
PE
12022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 Port to Sun C.
1205 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1206 that Sun C diagnosed.
1207 * fns.c (secure_hash): Fix pointer signedness issue.
1208 * intervals.c (static_offset_intervals): New function.
1209 (offset_intervals): Use it.
1210
7f3f739f
LL
12112011-06-21 Leo Liu <sdl.web@gmail.com>
1212
1213 * deps.mk (fns.o):
1214 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1215 sha512.h.
1216
1217 * fns.c (secure_hash): Rename from crypto_hash_function and change
1218 the first arg to accept symbols.
5b66d427 1219 (Fsecure_hash): New primitive.
7f3f739f
LL
1220 (syms_of_fns): New symbols.
1221
76147d94
DD
12222011-06-20 Deniz Dogan <deniz@dogan.se>
1223
1224 * process.c (Fset_process_buffer): Clarify return value in
1225 docstring.
1226
7d7d0045
CY
12272011-06-18 Chong Yidong <cyd@stupidchicken.com>
1228
1229 * dispnew.c (add_window_display_history): Use BVAR.
1230
1231 * xdisp.c (debug_method_add): Use BVAR.
1232 (check_window_end, dump_glyph_matrix, dump_glyph)
1233 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1234
1235 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1236 Likewise.
1237
1238 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1239 check till after the cache is created in init_frame_faces.
1240
ff2bc410
SM
12412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1242
1243 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1244
28177add
PE
12452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1246
dd3482fe
PE
1247 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1248 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1249 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1250
393d71f3 1251 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1252 * fileio.c (Finsert_file_contents):
1253 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1254 Remove the old (too-loose) buffer overflow checks.
1255 They weren't needed, since make_gap checks for buffer overflow.
1256 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1257 The old code merely checked for Emacs fixnum overflow, and relied
1258 on undefined (wraparound) behavior. The new code avoids undefined
1259 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1260
2e6813b0 1261 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1262 Tune. Don't use wider integers than needed. Don't use alloca.
1263 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1264
599a9e4f
PE
1265 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1266
99561444
PE
1267 * insdel.c, lisp.h (buffer_overflow): New function.
1268 (insert_from_buffer_1, replace_range, replace_range_2):
1269 * insdel.c (make_gap_larger):
1270 * editfns.c (Finsert_char):
1271 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1272
28177add
PE
1273 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1274
e69dafad
PE
12752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1276
a7af7fde 1277 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1278
b1c46f02
PE
1279 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1280 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1281
e69dafad
PE
1282 * fileio.c: Don't assume EMACS_INT fits in off_t.
1283 (emacs_lseek): New static function.
1284 (Finsert_file_contents, Fwrite_region): Use it.
1285 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1286
566684ea
PE
1287 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1288
e6966cd6
PE
1289 * fns.c: Don't overflow int when computing a list length.
1290 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1291 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1292 truncation on 64-bit hosts. Check for QUIT every
1293 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1294 faster and is responsive enough.
1295 (Flength): Report an error instead of overflowing an integer.
1296 (Fsafe_length): Return a float if the value is not representable
1297 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1298 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1299 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1300
dd0b0efb
PE
1301 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1302 (header_size, word_size): New constants.
1303 (allocate_vectorlike): Don't check size overflow here.
1304 (allocate_vector): Check it here instead, since this is the only
1305 caller of allocate_vectorlike that could cause overflow.
1306 Check that the new vector's length is representable as a fixnum.
1307
86fe5cfe
PE
1308 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1309 The previous code was bogus. For example, next_almost_prime (32)
1310 returned 39, which is undesirable as it is a multiple of 3; and
1311 next_almost_prime (24) returned 25, which is a multiple of 5 so
1312 why was the code bothering to check for multiples of 7?
1313
80e88859
PE
1314 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1315
4a2f0ad6
PE
1316 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1317
f66c7cf8
PE
1318 Variadic C functions now count arguments with ptrdiff_t.
1319 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1320 Back then I didn't know that the Emacs coding style prefers signed int.
1321 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1322 were being counted with int, which may truncate counts on 64-bit
1323 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1324 * lisp.h (struct Lisp_Subr.function.aMANY)
1325 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1326 Arg counts are now ptrdiff_t, not size_t.
1327 All variadic functions and their callers changed accordingly.
1328 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1329 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1330 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1331 * callint.c (Fcall_interactively): Check arg count for overflow,
1332 to avoid potential buffer overrun. Use signed char, not 'int',
1333 for 'varies' array, so that we needn't bother to check its size
1334 calculation for overflow.
1335 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1336 * eval.c (apply_lambda):
1337 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1338 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1339 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1340
a1759b76
PE
1341 * callint.c (Fcall_interactively): Don't use index var as event count.
1342
d96be9fc
PE
1343 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1344 * mem-limits.h (SIZE): Remove; no longer used.
1345
a690a978 1346 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1347
578c21e6
PE
1348 Remove unnecessary casts.
1349 * xterm.c (x_term_init):
1350 * xfns.c (x_set_border_pixel):
1351 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1352 These aren't needed now that we assume ANSI C.
1353
96f53c6c
PE
1354 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1355 It's more likely to cause problems (due to unsigned overflow)
1356 than to cure them.
1357
83c77d31
PE
1358 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1359
ee2079f1
PE
1360 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1361
6da65536
PE
1362 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1363
7147c4a4
PE
1364 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1365
193e32d9
PE
1366 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1367
e5533da6
PE
1368 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1369
9910e595
PE
1370 GLYPH_CODE_FACE returns EMACS_INT, not int.
1371 * dispextern.h (merge_faces):
1372 * xfaces.c (merge_faces):
01103c44
PE
1373 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1374 Don't assume EMACS_INT fits in int.
9910e595 1375
2638320e
PE
1376 * character.h (CHAR_VALID_P): Remove unused parameter.
1377 * fontset.c, lisp.h, xdisp.c: All uses changed.
1378
045eb8d9
PE
1379 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1380
c1f134b5
PE
1381 * fns.c (concat): Minor tuning based on overflow analysis.
1382 This doesn't fix any bugs. Use int to hold character, instead
1383 of constantly refetching from Emacs object. Use XFASTINT, not
1384 XINT, for value known to be a character. Don't bother comparing
1385 a single byte to 0400, as it's always less.
1386
395fcb93 1387 * floatfns.c (Fexpt):
327eeec8
PE
1388 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1389
abbd3d23
PE
1390 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1391 for characters.
1392
684a03ef
PE
1393 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1394
0fed43f3
PE
1395 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1396 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1397 incorrectly succeed when S was a string, because 4294967386 was
1398 truncated before it was used.
1399
8fd02eb7
PE
1400 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1401 Otherwise, an out-of-range integer could cause undefined behavior
1402 on a 64-bit host.
1403
f8c86b69
PE
1404 * composite.c: Use int, not EMACS_INT, for characters.
1405 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1406 EMACS_INT, for values that are known to be in character range.
1407 This doesn't fix any bugs but is the usual style inside Emacs and
1408 may generate better code on 32-bit machines.
1409
34206dd2
PE
1410 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1411 This is for reasons similar to the recent CHAR_STRING fix.
1412 * charset.c (Fencode_char): Check that character arg is actually
1413 a character. Pass an int to ENCODE_CHAR.
1414 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1415 wider than 'int', as a compile-time check to prevent future regressions
1416 in this area.
1417
c5958d4c 1418 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1419
1420 Make sure a 64-bit char is never passed to CHAR_STRING.
1421 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1422 by silently ignoring the top 32 bits, allowing some values
1423 that were far too large to be valid characters.
1424 * character.h: Include <verify.h>.
1425 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1426 arguments are no wider than unsigned, as a compile-time check
1427 to prevent future regressions in this area.
1428 * data.c (Faset):
01103c44 1429 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1430 (Fsubst_char_in_region):
1431 * fns.c (concat):
1432 * xdisp.c (decode_mode_spec_coding):
1433 Adjust to CHAR_STRING's new requirement.
1434 * editfns.c (Finsert_char, Fsubst_char_in_region):
1435 * fns.c (concat): Check that character args are actually
1436 characters. Without this test, these functions did the wrong
1437 thing with wildly out-of-range values on 64-bit hosts.
1438
d37ca623
PE
1439 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1440 These casts should not be needed on 32-bit hosts, either.
1441 * keyboard.c (read_char):
1442 * lread.c (Fload): Remove casts to unsigned.
1443
ea204efb
PE
1444 * lisp.h (UNSIGNED_CMP): New macro.
1445 This fixes comparison bugs on 64-bit hosts.
1446 (ASCII_CHAR_P): Use it.
1447 * casefiddle.c (casify_object):
01103c44 1448 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1449 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1450 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1451 * dispextern.h (FACE_FROM_ID):
1452 * keyboard.c (read_char): Use UNSIGNED_CMP.
1453
41cb286c
PE
1454 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1455 not to EMACS_INT, to avoid GCC warning.
1456
4a1b9832
PE
1457 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1458
55daad71
PE
1459 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1460 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1461 isn't needed on 32-bit machines.
8f95c75c 1462
01103c44
PE
1463 * buffer.c (Fgenerate_new_buffer_name):
1464 Use EMACS_INT for count, not int.
0ceccced 1465 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1466
1467 * data.c (Qcompiled_function): Now static.
1468
c6f072e7
PE
1469 * window.c (window_body_lines): Now static.
1470
20ce5912
PE
1471 * image.c (gif_load): Rename local to avoid shadowing.
1472
9c4c5f81
PE
1473 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1474 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1475 * alloc.c (make_save_value): Integer argument is now of type
1476 ptrdiff_t, not int.
1477 (mark_object): Use ptrdiff_t, not int.
1478 * lisp.h (pD): New macro.
1479 * print.c (print_object): Use it.
1480
c0c5c8ae
PE
1481 * alloc.c: Use EMACS_INT, not int, to count objects.
1482 (total_conses, total_markers, total_symbols, total_vector_size)
1483 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1484 (total_free_floats, total_floats, total_free_intervals)
1485 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1486 Now EMACS_INT, not int. All uses changed.
1487 (Fgarbage_collect): Compute overall total using a double, so that
1488 integer overflow is less likely to be a problem. Check for overflow
1489 when converting back to an integer.
5a25e253
PE
1490 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1491 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1492 These were 'int' variables that could overflow on 64-bit hosts;
1493 they were never used, so remove them instead of repairing them.
211a0b2a 1494 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1495 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1496 Previously, this ceilinged at INT_MAX, but that doesn't work on
1497 64-bit machines.
e46bb31a 1498 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1499
c78baabf 1500 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1501 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1502 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1503 when a (possibly-narrower) signed value would do just as well.
1504 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1505
c9d624c6
PE
1506 * alloc.c: Catch some string size overflows that we were missing.
1507 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1508 for convenience in STRING_BYTES_MAX.
1509 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1510 The definition here is exact; the one in lisp.h was approximate.
1511 (allocate_string_data): Check for string overflow. This catches
1512 some instances we weren't catching before. Also, it catches
1513 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1514 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1515 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1516
c9d624c6
PE
1517 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1518 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1519 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1520
353032ce
PE
1521 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1522
2bccce07
PE
1523 * alloc.c (Fmake_string): Check for out-of-range init.
1524
0ac30604
SM
15252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1526
1527 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1528
c195f2de
JD
15292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1530
1531 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1532 xg_get_default_scrollbar_width.
1533
1534 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1535 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1536 (style_changed_cb): Call update_theme_scrollbar_width and call
1537 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1538 all frames (Bug#8505).
1539 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1540 Call gtk_window_set_resizable if HAVE_GTK3.
1541 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1542 and height if HAVE_GTK3 (Bug#8505).
1543 (scroll_bar_width_for_theme): New variable.
1544 (update_theme_scrollbar_width): New function.
1545 (xg_get_default_scrollbar_width): Move code to
1546 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1547 (xg_initialize): Call update_theme_scrollbar_width.
1548
1549 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1550
1551 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1552
e10ac9f1
MR
15532011-06-12 Martin Rudalics <rudalics@gmx.at>
1554
1555 * frame.c (make_frame): Call other_buffer_safely instead of
1556 other_buffer.
1557
1558 * window.c (temp_output_buffer_show): Call display_buffer with
1559 second argument Vtemp_buffer_show_specifiers and reset latter
1560 immediately after the call.
1561 (Vtemp_buffer_show_specifiers): New variable.
1562 (auto_window_vscroll_p, next_screen_context_lines)
1563 (Vscroll_preserve_screen_position): Remove leading asterisks from
1564 doc-strings.
1565
2d3c217e 15662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1567
7b7f97e8 1568 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1569 * buffer.c (Qclone_number): Remove for now, as it's unused.
1570 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1571 (record_buffer): Remove unused local.
1572 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1573 (set_frame_buffer_list): Remove; unused.
1574 * frame.h (other_visible_frames): Remove decl.
1575 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1576 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1577 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1578 if HAVE_GPM.
1579 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1580 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1581 Define only if HAVE_GPM.
1582 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1583 (update_hints_inhibit): Remove; never set. All uses removed.
1584 * widgetprv.h (emacsFrameClassRec): Remove decl.
1585 * window.c (delete_deletable_window): Now returns void, since it
1586 wasn't returning anything.
1587 (compare_window_configurations): Remove unused locals.
1588 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1589 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1590 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1591 the same widths as pointers. This follows up on the 2011-05-06 patch.
1592 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1593 * xterm.h: Likewise.
1594 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1595
1384b89e
JB
15962011-06-12 Juanma Barranquero <lekktu@gmail.com>
1597
1598 * makefile.w32-in: Update dependencies.
1599 (LISP_H): Add lib/intprops.h.
1600
1100a63c
CY
16012011-06-11 Chong Yidong <cyd@stupidchicken.com>
1602
1603 * image.c (gif_load): Add animation frame delay to the metadata.
1604 (syms_of_image): Use DEFSYM. New symbol `delay'.
1605
6198ccd0
MR
16062011-06-11 Martin Rudalics <rudalics@gmx.at>
1607
1608 * window.c (delete_deletable_window): Re-add.
1609 (Fset_window_configuration): Rewrite to handle dead buffers and
1610 consequently deletable windows.
1611 (window_tree, Fwindow_tree): Remove. Supply functionality in
1612 window.el.
1613 (compare_window_configurations): Simplify code.
1614
b6e3633c
AS
16152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1616
1ab0dee5
AS
1617 * image.c (imagemagick_load_image): Fix type mismatch.
1618 (Fimagemagick_types): Likewise.
1619
b6e3633c
AS
1620 * window.h (replace_buffer_in_windows): Declare.
1621
9397e56f
MR
16222011-06-11 Martin Rudalics <rudalics@gmx.at>
1623
1624 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1625 Qclone_number. Remove external declaration of Qdelete_window.
1626 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1627 code.
1628 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1629 Qbuffer_list_update_hook if allowed.
1630 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1631 buffer list implementation.
1632 (other_buffer_safely): New function.
1633 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1634 calls to replace_buffer_in_windows and
1635 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1636 if allowed.
1637 (record_buffer): Inhibit quitting and rewrite using quittable
1638 functions. Run Qbuffer_list_update_hook if allowed.
1639 (Frecord_buffer, Funrecord_buffer): New functions.
1640 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1641 switch-to-buffer to window.el.
1642 (bury-buffer): Move to window.el.
1643 (Vbuffer_list_update_hook): New variable.
1644
1645 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1646 section.
1647
1648 * window.h (resize_frame_windows): Move up in code.
1649 (Fwindow_frame): Remove EXFUN.
1650 (replace_buffer_in_all_windows): Remove prototype.
1651 (replace_buffer_in_windows_safely): Add prototype.
1652
1653 * window.c: Declare Qdelete_window static again. Move down
1654 declaration of select_count.
1655 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1656 (Fother_window): Move to window.el.
1657 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1658 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1659 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1660 window.el.
1661 (replace_buffer_in_windows): Implement by calling
1662 Qreplace_buffer_in_windows.
1663 (replace_buffer_in_all_windows): Remove with some functionality
1664 moved into replace_buffer_in_windows_safely.
1665 (replace_buffer_in_windows_safely): New function.
1666 (select_window_norecord, select_frame_norecord): Move in front
1667 of run_window_configuration_change_hook. Remove now obsolete
1668 declarations.
1669 (Fset_window_buffer): Rewrite doc-string. Call
1670 Qrecord_window_buffer.
1671 (keys_of_window): Move binding for other-window to window.el.
1672
b50691aa
CY
16732011-06-11 Chong Yidong <cyd@stupidchicken.com>
1674
1675 * dispextern.h (struct image): Replace data member, whose int_val
1676 and ptr_val fields were not used by anything, with a single
1677 lisp_val object.
1678
1679 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1680 (gif_clear_image, gif_load, imagemagick_load_image)
1681 (gs_clear_image, gs_load): Callers changed.
1682
3f754b86
PE
16832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1684
cca69397
PE
1685 * buffer.h: Include <time.h>, for time_t.
1686 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1687
109e28d0
PE
1688 Fix minor problems found by static checking.
1689
60737f02
PE
1690 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1691
4b66faf3
PE
1692 Make identifiers static if they are not used in other modules.
1693 * data.c (Qcompiled_function, Qframe, Qvector):
1694 * image.c (QimageMagick, Qsvg):
1695 * minibuf.c (Qmetadata):
1696 * window.c (resize_window_check, resize_root_window): Now static.
1697 * window.h (resize_window_check, resize_root_window): Remove decls.
1698
109e28d0
PE
1699 * window.c (window_deletion_count, delete_deletable_window):
1700 Remove; unused.
46a4ce9e
PE
1701 (window_body_lines): Now static.
1702 (Fdelete_other_windows_internal): Mark vars as initialized.
1703 Make sure 'resize_failed' is initialized.
1704 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1705 (resize_window_apply): Remove unused local.
1706 * window.h (delete_deletable_window): Remove decl.
1707
109e28d0 1708 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1709 (imagemagick_load_image): Fix pointer signedness problem by changing
1710 last arg from unsigned char * to char *. All uses changed.
1711 Also, fix a local for similar reasons.
1712 Remove unused locals. Remove locals to avoid shadowing.
1713 (fn_rsvg_handle_free): Remove; unused.
1714 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1715 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1716
3f754b86
PE
1717 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1718
2547adb1
CY
17192011-06-10 Chong Yidong <cyd@stupidchicken.com>
1720
1721 * image.c (gif_load): Fix omitted cast error introduced by
1722 2011-06-06 change.
1723
2c8e37d4
MR
17242011-06-10 Martin Rudalics <rudalics@gmx.at>
1725
1726 * window.h (resize_proportionally, orig_total_lines)
1727 (orig_top_line): Remove from window structure.
1728 (set_window_height, set_window_width, change_window_heights)
1729 (Fdelete_window): Remove prototypes.
1730 (resize_frame_windows): Remove duplicate declaration.
1731
440a42e3
EZ
17322011-06-10 Eli Zaretskii <eliz@gnu.org>
1733
1734 * window.h (resize_frame_windows, resize_window_check)
1735 (delete_deletable_window, resize_root_window)
1736 (resize_frame_windows): Declare prototypes.
1737
1738 * window.c (resize_window_apply): Make definition be "static" to
1739 match the prototype.
1740
562dd5e9
MR
17412011-06-10 Martin Rudalics <rudalics@gmx.at>
1742
1743 * window.c: Remove declarations of Qwindow_size_fixed,
1744 window_min_size_1, window_min_size_2, window_min_size,
1745 size_window, window_fixed_size_p, enlarge_window, delete_window.
1746 Remove static from declaration of Qdelete_window, it's
1747 temporarily needed by Fbury_buffer.
1748 (replace_window): Don't assign orig_top_line and
1749 orig_total_lines.
1750 (Fdelete_window, delete_window): Remove. Window deletion is
1751 handled by window.el.
1752 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1753 Fdelete_window calls with calls to Qdelete_window.
1754 (Fdelete_other_windows): Remove. Deleting other windows is
1755 handled by window.el.
1756 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1757 handled in window.el.
1758 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1759 Window minimum sizes are handled in window.el.
1760 (shrink_windows, size_window, set_window_height)
1761 (set_window_width, change_window_heights, window_height)
1762 (window_width, CURBEG, CURSIZE, enlarge_window)
1763 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1764 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1765 handled in window.el.
1766 (make_dummy_parent): Rename to make_parent_window and give it a
1767 second argument horflag.
1768 (make_window): Don't set resize_proportionally any more.
1769 (Fsplit_window): Remove. Windows are split in window.el.
1770 (save_restore_action, save_restore_orig_size)
1771 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1772 Resize mini windows in window.el.
1773 (grow_mini_window, shrink_mini_window): Implement by calling
1774 Qresize_root_window_vertically, resize_window_check and
1775 resize_window_apply.
1776 (saved_window, Fset_window_configuration, save_window_save): Do
1777 not handle orig_top_line, orig_total_lines, and
1778 resize_proportionally.
1779 (window_min_height, window_min_width): Move to window.el.
1780 (keys_of_window): Move bindings for delete-other-windows,
1781 split-window, delete-window and enlarge-window to window.el.
1782
1783 * buffer.c: Temporarily extern Qdelete_window.
1784 (Fbury_buffer): Temporarily call Qdelete_window instead of
1785 Fdelete_window (Fbury_buffer will move to window.el soon).
1786
1787 * frame.c (set_menu_bar_lines_1): Remove code handling
1788 orig_top_line and orig_total_lines.
1789
1790 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1791 set_window_height but set heights directly.
1792 (change_frame_size_1): Use resize_frame_windows.
1793
1794 * xdisp.c (init_xdisp): Don't use set_window_height but set
1795 heights directly.
1796
1797 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1798 resize_frame_windows instead of change_window_heights and run
1799 run_window_configuration_change_hook.
1800
1801 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1802 instead of change_window_heights and run
1803 run_window_configuration_change_hook.
1804
1a13852e
MR
18052011-06-09 Martin Rudalics <rudalics@gmx.at>
1806
1807 * window.c (replace_window): Rename second argument REPLACEMENT to
1808 NEW. New third argument SETFLAG. Rewrite.
1809 (delete_window, make_dummy_parent): Call replace_window with
1810 third argument 1.
1811 (window_list_1): Move down in code.
1812 (run_window_configuration_change_hook): Move set_buffer part
1813 before select_frame_norecord part in order to unwind correctly.
1814 Rename count1 to count.
1815 (recombine_windows, delete_deletable_window, resize_root_window)
1816 (Fdelete_other_windows_internal)
1817 (Frun_window_configuration_change_hook, make_parent_window)
1818 (resize_window_check, resize_window_apply, Fresize_window_apply)
1819 (resize_frame_windows, Fsplit_window_internal)
1820 (Fdelete_window_internal, Fresize_mini_window_internal): New
1821 functions.
1822 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1823
f3d1777e
MR
18242011-06-08 Martin Rudalics <rudalics@gmx.at>
1825
496e208e
MR
1826 * window.h (window): Add some new members to window structure -
1827 normal_lines, normal_cols, new_total, new_normal, clone_number,
1828 splits, nest, prev_buffers, next_buffers.
1829 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1830 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1831
f3d1777e
MR
1832 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1833 Remove.
496e208e
MR
1834 (make_dummy_parent): Set new members of windows structure.
1835 (make_window): Move down in code. Handle new members of window
1836 structure.
1837 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1838 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1839 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1840 (Fset_window_prev_buffers, Fwindow_next_buffers)
1841 (Fset_window_next_buffers, Fset_window_clone_number): New
1842 functions.
1843 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1844 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1845 Doc-string fixes.
1846 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1847 Argument WINDOW can be now internal window too.
1848 (Fwindow_use_time): Move up in code.
1849 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1850 Rewrite doc-string.
1851 (Fset_window_configuration, saved_window)
1852 (Fcurrent_window_configuration, save_window_save): Handle new
1853 members of window structure.
b9e809c2
MR
1854 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1855 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1856 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1857 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1858 Qget_mru_window, Qresize_root_window,
1859 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1860 Qauto_buffer_name; staticpro them.
f3d1777e 1861
abde8f8c
MR
18622011-06-07 Martin Rudalics <rudalics@gmx.at>
1863
1864 * window.c (Fwindow_total_size, Fwindow_left_column)
1865 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1866 (Fwindow_list_1): New functions.
1867 (window_box_text_cols): Replace with window_body_cols.
1868 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1869 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1870 (delete_window, Fset_window_configuration): Call
1871 delete_all_subwindows with window as argument.
1872 (delete_all_subwindows): Take a window as argument and not a
1873 structure. Rewrite.
190b47e6
MR
1874 (window_loop): Remove handling of GET_LRU_WINDOW and
1875 GET_LARGEST_WINDOW.
1876 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1877
1878 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1879 window_box_text_cols. delete_all_subwindows now takes a
1880 Lisp_Object as argument.
abde8f8c
MR
1881
1882 * indent.c (compute_motion, Fcompute_motion): Use
1883 window_body_cols instead of window_box_text_cols.
1884
fa8a67e6
MR
1885 * frame.c (delete_frame): Call delete_all_subwindows with root
1886 window as argument.
1887
a54e3482
DC
18882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1889
1890 * fns.c (Fputhash): Document return value.
1891
60002bf5
CY
18922011-06-06 Chong Yidong <cyd@stupidchicken.com>
1893
1894 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1895
0c671da6 18962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1897
b862a52a 1898 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1899
be44ca6c
PE
1900 Check for overflow when converting integer to cons and back.
1901 * charset.c (Fdefine_charset_internal, Fdecode_char):
1902 Use cons_to_unsigned to catch overflow.
1903 (Fencode_char): Use INTEGER_TO_CONS.
1904 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1905 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1906 * data.c (long_to_cons, cons_to_long): Remove.
1907 (cons_to_unsigned, cons_to_signed): New functions.
1908 These signal an error for invalid or out-of-range values.
1909 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1910 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1911 * font.c (Ffont_variation_glyphs):
1912 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1913 * lisp.h: Include <intprops.h>.
1914 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1915 (cons_to_signed, cons_to_unsigned): New decls.
1916 (long_to_cons, cons_to_long): Remove decls.
1917 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1918 (Fprimitive_undo): Use CONS_TO_INTEGER.
1919 * xfns.c (Fx_window_property): Likewise.
1920 * xselect.c: Include <limits.h>.
1921 (x_own_selection, selection_data_to_lisp_data):
1922 Use INTEGER_TO_CONS.
1923 (x_handle_selection_request, x_handle_selection_clear)
1924 (x_get_foreign_selection, Fx_disown_selection_internal)
1925 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1926 (lisp_data_to_selection_data): Use cons_to_unsigned.
1927 (x_fill_property_data): Use cons_to_signed.
1928 Report values out of range.
1929
d1f3d2af
PE
1930 Check for buffer and string overflow more precisely.
1931 * buffer.h (BUF_BYTES_MAX): New macro.
1932 * lisp.h (STRING_BYTES_MAX): New macro.
1933 * alloc.c (Fmake_string):
1934 * character.c (string_escape_byte8):
1935 * coding.c (coding_alloc_by_realloc):
1936 * doprnt.c (doprnt):
1937 * editfns.c (Fformat):
1938 * eval.c (verror):
1939 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1940 since they may not be the same number.
1941 * editfns.c (Finsert_char):
1942 * fileio.c (Finsert_file_contents):
1943 Likewise for BUF_BYTES_MAX.
1944
dd52fcea
PE
1945 * image.c: Use ptrdiff_t, not int, for sizes.
1946 (slurp_file): Switch from int to ptrdiff_t.
1947 All uses changed.
1948 (slurp_file): Check that file size fits in both size_t (for
1949 malloc) and ptrdiff_t (for sanity and safety).
1950
7f9bbdbb
PE
1951 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1952 if b->modtime has its maximal value.
1953
dfe18f82
PE
1954 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1955
84acfcf0
PE
1956 Don't assume time_t can fit into int.
1957 * buffer.h (struct buffer.modtime): Now time_t, not int.
1958 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1959 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1960
ccd9a01a
PE
1961 Minor fixes for signed vs unsigned integers.
1962 * character.h (MAYBE_UNIFY_CHAR):
1963 * charset.c (maybe_unify_char):
1964 * keyboard.c (read_char, reorder_modifiers):
1965 XINT -> XFASTINT, since the integer must be nonnegative.
1966 * ftfont.c (ftfont_spec_pattern):
1967 * keymap.c (access_keymap, silly_event_symbol_error):
1968 XUINT -> XFASTINT, since the integer must be nonnegative.
1969 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1970 since it makes no difference and we prefer signed.
1971 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1972 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1973 nonnegative.
1974
d6d100dd
SM
19752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1976
1977 * window.h (Fwindow_frame): Declare.
1978
2b6148e4
PE
19792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1982 (SPARE_MEMORY): Always define.
1983 (LARGE_REQUEST): Remove.
1984 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1985
f230ecc9
MR
19862011-06-06 Martin Rudalics <rudalics@gmx.at>
1987
727e958e
MR
1988 * lisp.h: Move EXFUNS for Fframe_root_window,
1989 Fframe_first_window and Fset_frame_selected_window to window.h.
1990
1991 * window.h: Move EXFUNS for Fframe_root_window,
1992 Fframe_first_window and Fset_frame_selected_window here from
1993 lisp.h.
1994
1995 * frame.c (Fwindow_frame, Fframe_first_window)
1996 (Fframe_root_window, Fframe_selected_window)
1997 (Fset_frame_selected_window): Move to window.c.
1998 (Factive_minibuffer_window): Move to minibuf.c.
1999 (Fother_visible_frames_p): New function.
2000
2001 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2002
f230ecc9
MR
2003 * window.c (decode_window, decode_any_window): Move up in code.
2004 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2005 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2006 (Fwindow_buffer): Move up and rewrite doc-string.
2007 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2008 (Fwindow_prev): New functions.
727e958e
MR
2009 (Fwindow_frame): Move here from frame.c. Accept any window as
2010 argument.
2011 (Fframe_root_window, Fframe_first_window)
2012 (Fframe_selected_window): Move here from frame.c. Accept frame
2013 or arbitrary window as argument. Update doc-strings.
2014 (Fminibuffer_window): Move up in code.
2015 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2016 (Fset_frame_selected_window): Move here from frame.c.
2017 Marginal rewrite.
727e958e
MR
2018 (Fselected_window, select_window, Fselect_window): Move up in
2019 code. Minor doc-string fixes.
f230ecc9 2020
4d09bcf6
PE
20212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2024 Do not assume that spare memory exists; that assumption is valid
2025 only if SYSTEM_MALLOC.
2026 (LARGE_REQUEST): New macro, so that the issue of large requests
2027 is separated from the issue of spare memory.
2028
810928a2
AS
20292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2030
172418ad
AS
2031 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2032 format. (Bug#8806)
2033
43f862f7
AS
2034 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2035
810928a2
AS
2036 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2037 before statements.
2038
a059fe24
JD
20392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2040
2041 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2042
2043 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2044
2045 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2046 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2047
989bf368
JB
20482011-06-05 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2051
4b80f674
CY
20522011-06-04 Chong Yidong <cyd@stupidchicken.com>
2053
2054 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2055 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2056 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2057 New error handlers.
4b80f674
CY
2058 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2059 Obey Vx_select_enable_clipboard_manager. Catch errors in
2060 x_clipboard_manager_save (Bug#8779).
2061 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2062 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2063
99a33b77 20642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2065
2066 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2067
99a33b77 20682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2069
2070 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2071 in the current matrix if keep_current_p is non-zero.
2072
8264569d
EZ
20732011-06-04 Eli Zaretskii <eliz@gnu.org>
2074
2075 * bidi.c (bidi_level_of_next_char): Fix last change.
2076
57f97249
EZ
20772011-06-03 Eli Zaretskii <eliz@gnu.org>
2078
fec2107c 2079 Support bidi reordering of text covered by display properties.
57f97249 2080
fec2107c
EZ
2081 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2082 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2083 (bidi_cache_search, bidi_cache_iterator_state)
2084 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2085 (bidi_level_of_next_char, bidi_move_to_visually_next):
2086 Support character positions inside a run of characters covered by a
fec2107c
EZ
2087 display string.
2088 (bidi_paragraph_init, bidi_resolve_explicit_1)
2089 (bidi_level_of_next_char): Call bidi_fetch_char and
2090 bidi_fetch_char_advance instead of FETCH_CHAR and
2091 FETCH_CHAR_ADVANCE.
2092 (bidi_init_it): Initialize new members.
2093 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2094 definitions.
2095 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2096 instead of using explicit *_CHAR codes.
d6d100dd
SM
2097 (bidi_resolve_explicit, bidi_resolve_weak):
2098 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2099 bidirectional text is supported only in multibyte buffers.
2100 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2101 it to initialize the frame_window_p member of struct bidi_it.
2102 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2103 (bidi_resolve_explicit, bidi_resolve_weak)
2104 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2105 bidi_it->nchars is non-positive.
2106 (bidi_level_of_next_char): Don't try to lookup the cache for the
2107 next/previous character if nothing is cached there yet, or if we
2108 were just reseat()'ed to a new position.
c40e2fb2 2109
0e14fe90
EZ
2110 * xdisp.c (set_cursor_from_row): Set start and stop points
2111 according to the row's direction when priming the loop that looks
2112 for the glyph on which to display cursor.
2113 (single_display_spec_intangible_p): Function deleted.
2114 (display_prop_intangible_p): Reimplement to call
2115 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2116 Accept 3 additional arguments needed by handle_display_spec.
2117 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2118 values: lists, `(when COND...)' forms, etc.
2119 (single_display_spec_string_p): Support property values that are
2120 lists with the argument STRING its top-level element.
2121 (display_prop_string_p): Fix the condition for processing a
2122 property that is a list to be consistent with handle_display_spec.
fec2107c 2123 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2124 last portion of handle_display_prop.
2125 (compute_display_string_pos): Accept additional argument
2126 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2127 value of a `display' property is a "replacing spec".
2128 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2129 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2130 the display property, but just return a value indicating whether
2131 the display property will replace the characters it covers.
2132 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2133 frame_window_p members of struct bidi_it.
d6d100dd
SM
2134 (compute_display_string_pos, compute_display_string_end):
2135 New functions.
fec2107c
EZ
2136 (push_it): Accept second argument POSITION, where pop_it should
2137 jump to continue iteration.
2138 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2139
fec2107c
EZ
2140 * keyboard.c (adjust_point_for_property): Adjust the call to
2141 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2142
2143 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2144 (bidi_init_it): Update prototypes.
2145 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2146 (compute_display_string_pos, compute_display_string_end):
2147 Declare prototypes.
fec2107c
EZ
2148 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2149 EMACS_INT.
fc6f18ce 2150
40087514 21512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2152
57f53182
PE
2153 Malloc failure behavior now depends on size of allocation.
2154 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2155 * lisp.h: Change signatures accordingly.
2156 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2157 All callers changed. (Bug#8762)
2158
2159 * gnutls.c: Use Emacs's memory allocators.
2160 Without this change, the gnutls library would invoke malloc etc.
2161 directly, which causes problems on non-SYNC_INPUT hosts, and which
2162 runs afoul of improving memory_full behavior. (Bug#8761)
2163 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2164 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2165 xfree instead of the default malloc, realloc, free.
2166 (Fgnutls_boot): No need to check for memory allocation failure,
2167 since xmalloc does that for us.
2168
ac32cd99 2169 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2170 * category.c (hash_get_category_set):
2171 * ccl.c (ccl_driver):
2172 * charset.c (Fdefine_charset_internal):
2173 * charset.h (struct charset.hash_index):
2174 * composite.c (get_composition_id, gstring_lookup_cache)
2175 (composition_gstring_put_cache):
2176 * composite.h (struct composition.hash_index):
2177 * dispextern.h (struct image.hash):
2178 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2179 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2180 (hashfn_equal, hashfn_user_defined, make_hash_table)
2181 (maybe_resize_hash_table, hash_lookup, hash_put)
2182 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2183 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2184 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2185 * image.c (make_image, search_image_cache, lookup_image)
2186 (xpm_put_color_table_h):
2187 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2188 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2189 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2190 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2191 * alloc.c (allocate_vectorlike):
2192 Check for overflow in vector size calculations.
2193 * ccl.c (ccl_driver):
2194 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2195 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2196 need to be updated by these changes.
40087514
PE
2197 * fns.c (make_hash_table, maybe_resize_hash_table):
2198 Check for integer overflow with large hash tables.
0de4bb68
PE
2199 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2200 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2201 (SXHASH_REDUCE): New macro.
2202 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2203 Use it instead of discarding useful hash info with large hash values.
2204 (sxhash_float): New function.
2205 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2206 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2207 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2208 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2209 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2210 Adjust signatures to match updated version of code.
2211 (consing_since_gc): Now EMACS_INT, since a single hash table can
2212 use more than INT_MAX bytes.
2213
698d32e2
DN
22142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2215
2216 Make it possible to build with GCC-4.6+ -O2 -flto.
2217
2218 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2219
fd6fa53f
SM
22202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2221
2222 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2223 Call minibuffer-inactive-mode.
2224
864db017
JB
22252011-05-31 Juanma Barranquero <lekktu@gmail.com>
2226
2227 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2228 Update dependencies.
2229
2ad0baf4
DN
22302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2231
2232 * data.c (init_data): Remove code for UTS, this system is not
2233 supported anymore.
2234
4fcc2638
DN
22352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2236
2237 Don't force ./temacs to start in terminal mode.
2238
2239 * frame.c (make_initial_frame): Initialize faces in all cases, not
2240 only when CANNOT_DUMP is defined.
2241 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2242
c56e0fd5
DN
22432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2244
2245 * dispnew.c (add_window_display_history): Use const for the string
2246 pointer. Remove declaration, not needed.
2247
333d54da 22482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2249
55d4c1b2 2250 Use 'inline', not 'INLINE'.
333d54da 2251 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2252 * alloc.c, fontset.c (INLINE): Remove.
2253 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2254 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2255 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2256 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2257 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2258
738db178
DN
22592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2260
2261 Make it possible to run ./temacs.
2262
2263 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2264 syms_of_callproc does the same thing. Remove test for
2265 "initialized", do it in the caller.
2266 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2267
620c53a6
SM
22682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2269
2270 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2271 (read_minibuf): Use get_minibuffer.
2272 (syms_of_minibuf): Use DEFSYM.
2273 (Qmetadata): New var.
2274 * data.c (Qbuffer): Don't make it static.
2275 (syms_of_data): Use DEFSYM.
2276
e003a292
PE
22772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2280 (CCL_CODE_MIN): New macro.
2281
ed008a6d
PE
22822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2283
3687c2ef
PE
2284 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2285
ed008a6d
PE
2286 * eval.c (Qdebug): Now static.
2287 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2288 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2289 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2290
d66c4c7c
CY
22912011-05-29 Chong Yidong <cyd@stupidchicken.com>
2292
2293 * image.c: Various fixes to ImageMagick code comments.
2294 (Fimagemagick_types): Doc fix.
2295
5fbc2025
PE
22962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2297
0196f88a
PE
2298 Minor fixes prompted by GCC 4.6.0 warnings.
2299
2300 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2301
5fbc2025
PE
2302 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2303 (x_clipboard_manager_save_all): Move extern decl to ...
2304 * xterm.h: ... here, so that it can be checked for consistency.
2305
1dd3c2d9
CY
23062011-05-29 Chong Yidong <cyd@stupidchicken.com>
2307
2308 * xselect.c (x_clipboard_manager_save_frame)
2309 (x_clipboard_manager_save_all): New functions.
2310 (Fx_clipboard_manager_save): Lisp function deleted.
2311
2312 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2313 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2314
2315 * xterm.h: Update prototype.
2316
5ba6571d
WX
23172011-05-28 William Xu <william.xwl@gmail.com>
2318
2319 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2320 exiting (Bug#8239).
2321
3eaff834
JM
23222011-05-28 Jim Meyering <meyering@redhat.com>
2323
e1900994 2324 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2325 * fns.c (to_uchar): Define.
2326 (crypto_hash_function): Use it to convert some newly-signed
2327 variables to unsigned, to avoid sign-extension bugs. For example,
2328 without this change, (md5 "truc") would evaluate to
2329 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2330 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2331 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2332
0f6990a7
PE
23332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 Integer overflow fixes.
c8a9ca5a 2336
08686060
PE
2337 * dbusbind.c: Serial number integer overflow fixes.
2338 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2339 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2340 to hold a serial number that is too large for a fixnum.
2341 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2342 Check for serial numbers out of range. Decode any serial number
59568bf0 2343 that was so large that it became a float. (Bug#8722)
08686060 2344
2d1fc3c7
PE
2345 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2346 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2347 Use XFASTINT rather than XUINT when numbers are nonnegative.
2348 (xd_append_arg, Fdbus_method_return_internal):
2349 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2350 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2351 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2352 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2353 (Bug#8722)
2d1fc3c7 2354
c8a9ca5a
PE
2355 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2356
519e1d69
PE
2357 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2358
30569699
PE
2359 ccl: add integer overflow checks
2360 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2361 (IN_INT_RANGE): New macros.
2362 (ccl_driver): Use them to check for integer overflow when
2363 decoding a CCL program. Many of the new checks are whether XINT (x)
2364 fits in int; it doesn't always, on 64-bit hosts. The new version
2365 doesn't catch all possible integer overflows, but it's an
847044ea 2366 improvement. (Bug#8719)
30569699 2367
c11285dc
PE
2368 * alloc.c (make_event_array): Use XINT, not XUINT.
2369 There's no need for unsigned here.
2370
fdccd48e
PE
2371 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2372 This follows up to the 2011-05-06 change that substituted uintptr_t
2373 for EMACS_INT. This case wasn't caught back then.
2374
37910ab2
PE
2375 Rework Fformat to avoid integer overflow issues.
2376 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2377 now (part of C89). Include <verify.h>.
2378 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2379 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2380 (Fformat): Avoid the prepass trying to compute sizes; it was only
2381 approximate and thus did not catch overflow reliably. Instead, walk
2382 through the format just once, formatting and computing sizes as we go,
2383 checking for integer overflow at every step, and allocating a larger
2384 buffer as needed. Keep track separately whether the format is
2385 multibyte. Keep only the most-recently calculated precision, rather
2386 than them all. Record whether each argument has been converted to
2387 string. Use EMACS_INT, not int, for byte and char and arg counts.
2388 Support field widths and precisions larger than INT_MAX. Avoid
2389 sprintf's undefined behavior with conversion specifications such as %#d
2390 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2391 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2392 formatting out-of-range floating point numbers with int
9173deec 2393 formats. (Bug#8668)
37910ab2 2394
2e6578fb
PE
2395 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2396
0ae6bdee
PE
2397 * data.c: Avoid integer truncation in expressions involving floats.
2398 * data.c: Include <intprops.h>.
2399 (arith_driver): When there's an integer overflow in an expression
2400 involving floating point, convert the integers to floating point
2401 so that the resulting value does not suffer from catastrophic
2402 integer truncation. For example, on a 64-bit host (* 4
2403 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2404 Do not rely on undefined behavior after integer overflow.
2405
de883a70
PE
2406 merge count_size_as_multibyte, parse_str_to_multibyte
2407 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2408 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2409 Check for integer overflow.
2410 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2411 since it's now a duplicate of the other. This is more of
2412 a character than a buffer op, so better that it's in character.c.
2413 * fns.c, print.c: Adjust to above changes.
2414
2ff916cb
PE
24152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2416
2417 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2418
f1b54466
PE
24192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2420
fb1ac845
PE
2421 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2422 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2423 (x_clipboard_manager_save): Now static.
2424 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2425
f1b54466
PE
2426 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2427 (crypto_hash_function): Now static.
2428 Fix pointer signedness problems. Avoid unnecessary initializations.
2429
a9f737ee
CY
24302011-05-27 Chong Yidong <cyd@stupidchicken.com>
2431
2432 * termhooks.h (Vselection_alist): Make it terminal-local.
2433
2434 * terminal.c (create_terminal): Initialize it.
2435
2436 * xselect.c: Support for clipboard managers.
2437 (Vselection_alist): Move to termhooks.h as terminal-local var.
2438 (LOCAL_SELECTION): New macro.
2439 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2440 (symbol_to_x_atom): Remove gratuitous arg.
2441 (x_handle_selection_request, lisp_data_to_selection_data)
2442 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2443 (x_own_selection, x_get_local_selection, x_convert_selection):
2444 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2445 (some_frame_on_display): Delete unused function.
2446 (Fx_own_selection_internal, Fx_get_selection_internal)
2447 (Fx_disown_selection_internal, Fx_selection_owner_p)
2448 (Fx_selection_exists_p): New optional frame arg.
2449 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2450 (x_handle_selection_clear): Don't treat other terminals with the
2451 same keyboard specially. Use the terminal-local Vselection_alist.
2452 (x_clear_frame_selections): Use Frun_hook_with_args.
2453
2454 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2455
2456 * xterm.h: Add support for those atoms.
2457
e067f0c1
CY
24582011-05-26 Chong Yidong <cyd@stupidchicken.com>
2459
2460 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2461 (converted_selections, conversion_fail_tag): New global variables.
2462 (x_selection_request_lisp_error): Free the above.
2463 (x_get_local_selection): Remove unnecessary code.
2464 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2465 of converted selections stored in converted_selections.
2466 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2467 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2468 (x_convert_selection): New function.
2469 (x_handle_selection_event): Simplify.
2470 (x_get_foreign_selection): Don't ignore incoming requests while
2471 waiting for an answer; this will fail when we implement
2472 SAVE_TARGETS, and seems unnecessary anyway.
2473 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2474 (Vx_sent_selection_functions): Doc fix.
2475
0f4aebc0
LL
24762011-05-26 Leo Liu <sdl.web@gmail.com>
2477
2478 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2479
e61124cd
YM
24802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2481
2482 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2483
2484 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2485 for fringe update if it has periodic bitmap.
ac389d0c 2486 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2487 and fringe_bitmap_periodic_p.
2488
2489 * fringe.c (get_fringe_bitmap_data): New function.
2490 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2491 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2492 row. Mark glyph row for fringe update if periodicity changed.
2493
2494 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2495 for fringe update unless it has periodic bitmap.
2496
f16d9837
KH
24972011-05-25 Kenichi Handa <handa@m17n.org>
2498
2499 * xdisp.c (get_next_display_element): Set correct it->face_id for
2500 a static composition.
2501
e1b90ef6
LL
25022011-05-24 Leo Liu <sdl.web@gmail.com>
2503
2504 * deps.mk (fns.o):
2505 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2506
2507 * fns.c (crypto_hash_function, Fsha1): New function.
2508 (Fmd5): Use crypto_hash_function.
2509 (syms_of_fns): Add Ssha1.
2510
7400048f
PE
25112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 * gnutls.c: Remove unused macros.
2514 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2515 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2516 Remove macros that are defined and never used.
2517 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2518
abb71cf4
CY
25192011-05-22 Chong Yidong <cyd@stupidchicken.com>
2520
2521 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2522 (Fx_get_selection_internal): Minor cleanup.
2523 (Fx_own_selection_internal): Rename arguments for consistency with
2524 select.el.
2525
6307db39
PE
25262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2529
f3d4e0a4
CY
25302011-05-22 Chong Yidong <cyd@stupidchicken.com>
2531
2532 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2533
4d8ade89
YM
25342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2535
2536 * dispnew.c (scrolling_window): Don't exclude the case that the
2537 last enabled row in the desired matrix touches the bottom boundary.
2538
32078c8d
GM
25392011-05-21 Glenn Morris <rgm@gnu.org>
2540
2541 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2542 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2543 and add some more files.
32078c8d 2544
7285dc67
EZ
25452011-05-20 Eli Zaretskii <eliz@gnu.org>
2546
2547 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2548 report_file_error introduced by the change from 2011-05-07.
2549
89d1bd22
PE
25502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 * systime.h (Time): Define only if emacs is defined.
2553 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2554 where the include path doesn't have X11/X.h by default. See
2555 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2556
e23640bb 25572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2558
2559 * composite.c (find_automatic_composition): Fix previous change.
2560
b9704ad9
GM
25612011-05-20 Glenn Morris <rgm@gnu.org>
2562
2563 * lisp.mk: New file, split from Makefile.in.
2564 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2565 (shortlisp): Remove.
2566 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2567
4a720484
GM
25682011-05-19 Glenn Morris <rgm@gnu.org>
2569
2570 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2571 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2572 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2573 (lisp): Set the order to that of loadup.el.
2574 (shortlisp): Make it a copy of $lisp.
2575 (SOME_MACHINE_LISP): Remove.
2576 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2577 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2578
a28d4396
KH
25792011-05-18 Kenichi Handa <handa@m17n.org>
2580
2581 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2582 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2583 (find_automatic_composition): Mostly rewrite for efficiency.
2584
a2b1fa8e
JB
25852011-05-18 Juanma Barranquero <lekktu@gmail.com>
2586
2587 * makefile.w32-in: Update dependencies.
2588
8e1f5610
CS
25892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2590
2591 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2592 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2593
7025ee00 25942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2595
cdfa6eab
PE
2596 Fix some integer overflow issues, such as string length overflow.
2597
06d6db33
PE
2598 * insdel.c (count_size_as_multibyte): Check for string overflow.
2599
2b4560a8
PE
2600 * character.c (lisp_string_width): Check for string overflow.
2601 Use EMACS_INT, not int, for string indexes and lengths; in
2602 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2603 the resulting string length overflows an EMACS_INT; instead,
2604 report a string overflow if no precision given. When checking for
2605 precision exhaustion, use a check that cannot possibly have
2606 integer overflow. (Bug#8675)
2607 * character.h (lisp_string_width): Adjust to new signature.
2608
cb93f9be
PE
2609 * alloc.c (string_overflow): New function.
2610 (Fmake_string): Use it. This doesn't change behavior, but saves
2611 a few bytes and will simplify future changes.
2612 * character.c (string_escape_byte8): Likewise.
2613 * lisp.h (string_overflow): New decl.
2614
1a1f3366
PE
2615 Fixups, following up to the user-interface timestamp change.
2616 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2617 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2618 * msdos.c (mouse_get_pos): Likewise.
2619 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2620 * w32gui.h (Time): Define by including "systime.h" rather than by
2621 declaring it ourselves. (Bug#8664)
2622
d4e3e4d3
PE
2623 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2624 * image.c (clear_image_cache): Likewise.
2625
f6a24d19
PE
2626 * term.c (term_mouse_position): Don't assume time_t wraparound.
2627
08dc5ae6
PE
2628 Be more systematic about user-interface timestamps.
2629 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2630 and sometimes 'EMACS_UINT', to represent these timestamps.
2631 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2632 This makes the code easier to follow, and makes it easier to catch
2633 integer overflow bugs such as Bug#8664.
2634 * frame.c (Fmouse_position, Fmouse_pixel_position):
2635 Use Time, not unsigned long, for user-interface timestamps.
2636 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2637 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2638 * keyboard.h (last_event_timestamp): Likewise.
2639 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2640 * menu.h (xmenu_show): Likewise.
2641 * term.c (term_mouse_position): Likewise.
2642 * termhooks.h (struct input_event.timestamp): Likewise.
2643 (struct terminal.mouse_position_hook): Likewise.
2644 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2645 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2646 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2647 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2648 what it was before.
2649 * menu.h, termhooks.h: Include "systime.h", for Time.
2650
8e55734a
PE
2651 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2652 Don't assume that the difference between two unsigned long values
2653 can fit into an integer. At this point, we know button_down_time
2654 <= event->timestamp, so the difference must be nonnegative, so
2655 there's no need to cast the result if double-click-time is
2656 nonnegative, as it should be; check that it's nonnegative, just in
2657 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2658 apart (about 25 days). (Bug#8664)
8e55734a 2659
841f1b75 2660 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2661 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2662
3e26f69c
PE
2663 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2664 that always fit in int. Use a sentinel instead of a counter, to
2665 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2666 * frame.h (struct frame): Use int for menu_bar_items_used
2667 instead of EMACS_INT, since it always fits in int.
3e26f69c 2668
5cc152c0
PE
2669 * menu.c (grow_menu_items): Check for int overflow.
2670
d89eb65e
PE
2671 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2672
5235bd3e
PE
2673 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2674 Before, the code was not consistent. These values cannot exceed
2675 2**31 - 1 so there's no need to make them unsigned.
2676 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2677 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2678 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2679 as modifiers.
2680 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2681
bc827e23
PE
2682 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2683 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2684 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2685 presumably because the widths might not match.
2686
78eb494e
PE
2687 * window.c (size_window): Avoid needless test at loop start.
2688
04f2d78b
CB
26892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2690
2691 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2692
d2fc7e3d 26932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2694
2695 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2696
d2fc7e3d 26972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2698
2699 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2700 `width' to `bar_area_x' and `bar_area_width', respectively.
2701 (x_scroll_run): Take account of fringe background extension.
2702
04f2d78b
CB
2703 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2704 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2705 `bar_area_width', respectively.
2706 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2707 background extension.
2708
79b70037
GM
27092011-05-10 Jim Meyering <meyering@redhat.com>
2710
2711 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2712
2f142cc5
JB
27132011-05-10 Juanma Barranquero <lekktu@gmail.com>
2714
2715 * image.c (Finit_image_library): Return t for built-in image types,
2716 like pbm and xbm. (Bug#8640)
2717
57679c86
AS
27182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2719
2720 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2721
888c9e86
EZ
27222011-05-07 Eli Zaretskii <eliz@gnu.org>
2723
b0512a1d
EZ
2724 * w32console.c (Fset_screen_color): Doc fix.
2725 (Fget_screen_color): New function.
2726 (syms_of_ntterm): Defsubr it.
2727
7285dc67
EZ
2728 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2729 unlink the temporary file if Fcall_process didn't create it in the
2730 first place.
2731 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2732 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2733 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2734 cue to call_process_cleanup not to close that handle.
2735
4d3fcc8e
BK
27362011-05-07 Ben Key <bkey76@gmail.com>
2737
2738 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2739 one of two shell specific rules, either bootstrap-temacs-CMD or
2740 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2741 to the previous implementation of the bootstrap-temacs rule.
2742 The bootstrap-temacs-CMD rule is similar to the previous
2743 implementation of the bootstrap-temacs rule except that it
2744 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2745 variable.
2746
2747 These changes, along with some changes to nt/configure.bat,
2748 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2749 earlier fix to add support for --cflags and --ldflags options
2750 that include quotes so that it works whether make uses cmd or
2751 sh as the shell.
2752
b4289b64
MA
27532011-05-06 Michael Albinus <michael.albinus@gmx.de>
2754
2755 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2756 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2757 is a constant.
2758 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2759 a string. Handle both cases.
2760 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2761 (Fdbus_register_method): Use Qinvalid_function.
2762
af4c0e28
JB
27632011-05-06 Juanma Barranquero <lekktu@gmail.com>
2764
2765 * makefile.w32-in: Update dependencies.
2766 (LISP_H): Add inttypes.h and stdin.h.
2767 (PROCESS_H): Add unistd.h.
2768
c51453d9
EZ
27692011-05-06 Eli Zaretskii <eliz@gnu.org>
2770
2771 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2772 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2773
8ff0ac3c 27742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2775
4c4b566b
PE
2776 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2777
aab2b9b5
PE
2778 * term.c (vfatal): Remove stray call to va_end.
2779 It's not needed and the C Standard doesn't allow it here anyway.
2780
c378da0b
PE
2781 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2782 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2783
288b08c7
PE
2784 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2785 bytes.
2786
e3601888
PE
2787 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2788
db6c0e74
PE
2789 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2790
dd5963ea
PE
2791 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2792
88c9450f
PE
2793 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2794
2f9442b8
PE
2795 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2796
c032b5f8
PE
2797 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2798 * charset.c (Fdefine_charset_internal): Don't initialize
2799 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2800 32-bit int (Bug#8600).
a108c10b
PE
2801
2802 * lread.c (read_integer): Be more consistent with string-to-number.
2803 Use string_to_number to do the actual conversion; this avoids
2804 rounding errors and fixes some other screwups. Without this fix,
2805 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2806 (digit_to_number): Move earlier, for benefit of read_integer.
2807 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2808 not a digit in any supported base. (Bug#8602)
a108c10b 2809
ad5f9eea
PE
2810 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2811
aec1708a
PE
2812 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2813 to match comment at start of function. This also removes a
2814 GCC warning about overflow in a 32+64-bit port.
2815
47be4ab5
PE
2816 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2817
371cac43
PE
2818 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2819 Reported by Stefan Monnier in
2820 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2821 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2822 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2823
d01a7826
PE
2824 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2825 (EMACS_UINTPTR): Likewise, with uintptr_t.
2826
7fd47d5c
PE
2827 * lisp.h: Prefer 64-bit EMACS_INT if available.
2828 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2829 on 32-bit hosts that have 64-bit int, so that they can access
2830 large files.
122b0c86
PE
2831 However, temporarily disable this change unless the temporary
2832 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2833
8727937b
PE
2834 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2835
8ac068ac
PE
2836 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2837 This removes an assumption that EMACS_INT and long are the same
2838 width as pointers. The assumption is true for Emacs porting targets
2839 now, but we want to make other targets possible.
2840 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2841 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2842 In the rest of the code, change types of integers that hold casted
2843 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2844 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2845 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2846 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2847 No need to cast type when ORing.
2848 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2849 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2850 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2851 assume EMACS_INT is the same width as char *.
2852 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2853 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2854 Remove no-longer-needed casts.
2855 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2856 (xg_tool_bar_help_callback, xg_make_tool_item):
2857 Use EMACS_INTPTR to hold an integer
2858 that will be cast to void *; this can avoid a GCC warning
2859 if EMACS_INT is not the same width as void *.
2860 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2861 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2862 (current_message_1, set_message_1):
2863 Use a local to convert to proper width without a cast.
2864 * xmenu.c (dialog_selection_callback): Likewise.
2865
ede49d71
PE
2866 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2867 Also, don't assume VALBITS / RAND_BITS is less than 5,
2868 and don't rely on undefined behavior when shifting a 1 left into
2869 the sign bit.
2870 * lisp.h (get_random): Change signature to match.
2871
2f30ecd0
PE
2872 * lread.c (hash_string): Use size_t, not int, for hash computation.
2873 Normally we prefer signed values; but hashing is special, because
2874 it's better to use unsigned division on hash table sizes so that
2875 the remainder is nonnegative. Also, size_t is the natural width
2876 for hashing into memory. The previous code used 'int', which doesn't
2877 retain enough info to hash well into very large tables.
2878 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2879
2a866e7b
PE
2880 * dbusbind.c: Don't possibly lose pointer info when converting.
2881 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2882 Use XPNTR rather than XHASH, so that the high-order bits of
2883 the pointer aren't lost when converting through void *.
2884
51639eac
PE
2885 * eval.c (Fautoload): Don't double-shift a pointer.
2886
92394119
PE
2887 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2888
dbdb9a7c
JB
28892011-05-06 Juanma Barranquero <lekktu@gmail.com>
2890
2891 * gnutls.c (DEF_GNUTLS_FN):
2892 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2893
db7a0b4f
AS
28942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2895
2896 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2897 marker. (Bug#8610)
2898
f7ff1b0f 28992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2900
2901 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2902 New version that can reserve upto 2GB of heap space.
2903
f7ff1b0f 29042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2905
2906 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2907
639c109b
TZ
29082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2909
2910 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2911 `gnutls_certificate_set_x509_key_file'.
2912
d2127135
JB
29132011-05-05 Juanma Barranquero <lekktu@gmail.com>
2914
2915 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2916 Update dependencies.
2917
e968f4f3
JB
29182011-05-04 Juanma Barranquero <lekktu@gmail.com>
2919
2920 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2921 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2922 Remove unused parameter `fildes'.
2923 * process.c (read_process_output, send_process): Don't pass it.
2924
84d358f0
JB
29252011-05-04 Juanma Barranquero <lekktu@gmail.com>
2926
2927 Fix previous change: the library cache is defined in w32.c.
2928 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2929 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2930
0898ca10
JB
29312011-05-04 Juanma Barranquero <lekktu@gmail.com>
2932
2933 Implement dynamic loading of GnuTLS on Windows.
2934
2935 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2936 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2937 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2938 Declare.
2939
2940 * gnutls.c (Qgnutls_dll): Define.
2941 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2942 (gnutls_*): Declare function pointers.
2943 (init_gnutls_functions): New function to initialize function pointers.
2944 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2945 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2946 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2947 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2948 (emacs_gnutls_write, emacs_gnutls_read)
2949 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2950 (Fgnutls_available_p): New function.
2951 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2952 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2953 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2954
2955 * image.c: Include w32.h.
2956 (Vimage_type_cache): Delete.
2957 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2958 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2959 (w32_delayed_load): Move to w32.c.
2960
2961 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2962
2963 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2964 (w32_delayed_load): Move from image.c. When loading a library, record
2965 its filename in the :loaded-from property of the library id.
2966 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2967 Initialize and staticpro them.
2968 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2969
2970 * process.c: Include lisp.h before w32.h, not after.
2971 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2972 instead of gnutls_record_check_pending.
2973
2974 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2975
ff4de4aa
TZ
29762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2977
2978 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2979 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2980 as passed in.
2981
abe95abb
JD
29822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2983
2984 * xterm.c (x_set_frame_alpha): Do not set property on anything
2985 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2986
e16e55d4
JB
29872011-05-02 Juanma Barranquero <lekktu@gmail.com>
2988
2989 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2990
bafcf6a5
JB
29912011-05-02 Juanma Barranquero <lekktu@gmail.com>
2992
2993 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2994 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2995 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2996 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2997 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2998 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2999 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3000 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3001 (Qgnutls_bootprop_callbacks_verify): Make static.
3002
e7a6747f
AS
30032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3004
19ed11ba
AS
3005 * callproc.c: Indentation fixup.
3006
e7a6747f 3007 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3008 (wait_for_termination, interruptible_wait_for_termination):
3009 Move after wait_for_termination_1.
e7a6747f 3010
1ef14cb4
LMI
30112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3012
3013 * sysdep.c (interruptible_wait_for_termination): New function
3014 which is like wait_for_termination, but allows keyboard
3015 interruptions.
3016
3017 * callproc.c (Fcall_process): Add (:file "file") as an option for
3018 the STDOUT buffer.
3019 (Fcall_process_region): Ditto.
3020
330d880c
EZ
30212011-04-30 Eli Zaretskii <eliz@gnu.org>
3022
8db90b73
EZ
3023 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3024 rather than `XVECTOR (FOO)->size'.
3025
330d880c
EZ
3026 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3027 inttypes.h, as a gnulib replacement is used if it not available in
3028 system headers.
3029
15cbd324
EZ
30302011-04-21 Eli Zaretskii <eliz@gnu.org>
3031
3032 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3033 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3034 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3035
3036 * coding.c (coding_alloc_by_realloc): Error out if destination
3037 will grow beyond MOST_POSITIVE_FIXNUM.
3038 (decode_coding_emacs_mule): Abort if there isn't enough place in
3039 charbuf for the composition carryover bytes. Reserve an extra
3040 space for up to 2 characters produced in a loop.
3041 (decode_coding_iso_2022): Abort if there isn't enough place in
3042 charbuf for the composition carryover bytes.
3043
30442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3045
ae940cca
EZ
3046 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3047 aborting when %lld or %lll format is passed.
3048 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3049 %llo or %llx format is passed. (Bug#8545)
3050
03ab8921
EZ
3051 * window.c (window_scroll_line_based): Use a marker instead of
3052 simple variables to record original value of point. (Bug#7952)
3053
afda1437
EZ
3054 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3055 produced by %s or %c overflows available buffer space. (Bug#8545)
3056
f76dee0c
PE
30572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3060 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3061
fdc5744d
JB
30622011-04-28 Juanma Barranquero <lekktu@gmail.com>
3063
3064 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3065
638f053a
JB
30662011-04-28 Juanma Barranquero <lekktu@gmail.com>
3067
3068 * keyboard.c (Qdelayed_warnings_hook): Define.
3069 (command_loop_1): Run `delayed-warnings-hook'
3070 if Vdelayed_warnings_list is non-nil.
3071 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3072 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3073
d178f871
EZ
30742011-04-28 Eli Zaretskii <eliz@gnu.org>
3075
3076 * doprnt.c (doprnt): Don't return value smaller than the buffer
3077 size if the message was truncated. (Bug#8545).
3078
b124fd93
JB
30792011-04-28 Juanma Barranquero <lekktu@gmail.com>
3080
3081 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3082 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3083
e810457d
PE
30842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3085
3086 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3087
ea51cceb
JB
30882011-04-27 Juanma Barranquero <lekktu@gmail.com>
3089
3090 * makefile.w32-in: Update dependencies.
3091
94dcfacf
EZ
30922011-04-27 Eli Zaretskii <eliz@gnu.org>
3093
3094 Improve `doprnt' and its usage. (Bug#8545)
3095 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3096 `format_end'. Remove support for %l as a conversion specifier.
3097 Don't use xrealloc. Improve diagnostics when the %l size modifier
3098 is used. Update the commentary.
3099
3100 * eval.c (verror): Simplify calculation of size_t.
3101
3102 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3103 messages.
3104
f61f41d7
PE
31052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3106
3107 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3108 change.
3109
96fb4434
PE
31102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3111
3112 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3113 This makes this file independent of the recent pseudovector change.
3114
671875da 31152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3116
69e9b5a3
PE
3117 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3118
b5f869a7 3119 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3120 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3121 Remove unused local.
c8926152 3122 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3123
841a1577 3124 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3125 GCC 4.6.0 optimizes based on type-based alias analysis.
3126 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3127 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3128 != &v->size, and therefore "v->size = 1; b->size = 2; return
3129 v->size;" must therefore return 1. This assumption is incorrect
3130 for Emacs, since it type-puns struct Lisp_Vector * with many other
3131 types. To fix this problem, this patch adds a new type struct
f904488f 3132 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3133 and pseudovectors, and helps optimizing compilers not get fooled
3134 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3135 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3136 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3137 the size member.
eab3844f
PE
3138 (XSETPVECTYPE): Rewrite in terms of new macro.
3139 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3140 This is a bit clearer, and further avoids the possibility of
3141 undesirable aliasing.
3142 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3143 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3144 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3145 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3146 (ASIZE): Now uses header.size rather than size.
3147 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3148 to avoid the hassle of writing XVECTOR (foo)->header.size.
3149 (struct vectorlike_header): New type.
eab3844f
PE
3150 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3151 object, to help avoid aliasing.
3152 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3153 (SUBRP): Likewise, since Lisp_Subr is a special case.
3154 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3155 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3156 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3157 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3158 changed to be "header.size" and "header.next".
3159 * buffer.h (struct buffer): Likewise.
3160 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3161 * frame.h (struct frame): Likewise.
3162 * process.h (struct Lisp_Process): Likewise.
3163 * termhooks.h (struct terminal): Likewise.
3164 * window.c (struct save_window_data, struct saved_window): Likewise.
3165 * window.h (struct window): Likewise.
3166 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3167 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3168 * buffer.c (init_buffer_once): Likewise.
3169 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3170 special case.
3171 * process.c (Fformat_network_address): Use local var for size,
3172 for brevity.
3173
0df1eac5
PE
3174 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3175
847ab9d1 3176 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3177 * data.c (atof): Remove decl; no longer used or needed.
3178 (digit_to_number): Move to lread.c.
3179 (Fstring_to_number): Use new string_to_number function, to be
3180 consistent with how the Lisp reader treats infinities and NaNs.
3181 Do not assume that floating-point numbers represent EMACS_INT
3182 without losing information; this is not true on most 64-bit hosts.
3183 Avoid double-rounding errors, by insisting on integers when
3184 parsing non-base-10 numbers, as the documentation specifies.
3185 * lisp.h (string_to_number): New decl, replacing ...
3186 (isfloat_string): Remove.
bc0a5c13 3187 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3188 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3189 appears to have been a coding error. Similarly, do not accept
3190 strings like +-1e0 as floating point numbers. Do not report
3191 overflow for integer overflows unless the base is not 10 which
3192 means we have no simple and reliable way to continue.
3193 Break out the floating-point parsing into a new
3194 function string_to_number, so that Fstring_to_number parses
3195 floating point numbers consistently with the Lisp reader.
04f2d78b 3196 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3197 (E_CHAR, EXP_INT): Remove, replacing with ...
3198 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3199 (string_to_number): New function, replacing isfloat_string.
3200 This function checks for valid syntax and produces the resulting
3201 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3202 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3203 so that overflow for non-base-10 numbers is reported only when
3204 there's no portable and simple way to convert to floating point.
452f4150 3205
67769ffc
PE
3206 * textprop.c (set_text_properties_1): Rewrite for clarity,
3207 and to avoid GCC warning about integer overflow.
3208
c20db43f
PE
3209 * intervals.h (struct interval): Use EMACS_INT for members
3210 where EMACS_UINT might cause problems. See
3211 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3212 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3213 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3214 All uses changed.
37aa2f85
PE
3215 (offset_intervals): Tell GCC not to worry about length overflow
3216 when negating a negative length.
c20db43f 3217
2538aa2f
PE
3218 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3219 (overrun_check_free): Likewise.
3220
f2d3008d
PE
3221 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3222 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3223 word size.
3224
ec8df744
PE
3225 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3226 (gnutls_make_error): Rename local to avoid shadowing.
3227 (gnutls_emacs_global_deinit): ifdef out; not used.
3228 (Fgnutls_boot): Use const for pointer to readonly storage.
3229 Comment out unused local. Fix pointer signedness problems.
3230
640ee02d
PE
3231 * lread.c (openp): Don't stuff size_t into an 'int'.
3232 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3233 about possible signed overflow.
3234
6048fb2a
PE
3235 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3236 (GDK_KEY_g): Don't define if already defined.
3237 (xg_prepare_tooltip): Avoid pointer signedness problem.
3238 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3239
fa3c87e1
PE
3240 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3241 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3242
2172544b
PE
3243 * xfns.c (Fx_window_property): Simplify a bit,
3244 to make a bit faster and to avoid GCC 4.6.0 warning.
3245 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3246
9b821a21
PE
3247 * fns.c (internal_equal): Don't assume size_t fits in int.
3248
3c616cfa
PE
3249 * alloc.c (compact_small_strings): Tighten assertion a little.
3250
c2982e87
PE
3251 Replace pEd with more-general pI, and fix some printf arg casts.
3252 * lisp.h (pI): New macro, generalizing old pEd macro to other
3253 conversion specifiers. For example, use "...%"pI"d..." rather
3254 than "...%"pEd"...".
3255 (pEd): Remove. All uses replaced with similar uses of pI.
3256 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3257 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3258 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3259 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3260 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3261 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3262 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3263 64-bit hosts.
3264 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3265 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3266 * print.c (safe_debug_print, print_object): Likewise.
3267 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3268 to int.
6f04d126
PE
3269 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3270 avoiding the 0 flag, which is not portable.
c2982e87
PE
3271 * process.c (Fmake_network_process): Use pI to avoid cast.
3272 * region-cache.c (pp_cache): Likewise.
3273 * xdisp.c (decode_mode_spec): Likewise.
3274 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3275 behavior on 64-bit hosts with printf arg.
6f04d126 3276 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3277 (x_stop_queuing_selection_requests): Likewise.
3278 (x_get_window_property): Don't truncate byte count to an 'int'
3279 when tracing.
0b432f21 3280
5e073ec7
PE
3281 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3282 here, since it parses constructs like leading '-' and spaces,
3283 which are not wanted; and it overflows with large numbers.
3284 Instead, simply match F[0-9]+, which is what is wanted anyway.
3285
36372bf9
PE
3286 * alloc.c: Remove unportable assumptions about struct layout.
3287 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3288 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3289 (allocate_vectorlike, make_pure_vector): Use the new macros,
3290 plus offsetof, to remove unportable assumptions about struct layout.
3291 These assumptions hold on all porting targets that I know of, but
3292 they are not guaranteed, they're easy to remove, and removing them
3293 makes further changes easier.
3294
0b432f21
PE
3295 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3296 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3297 (string_overrun_cookie): Now const. Use initializers that
3298 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3299 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3300 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3301 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3302 multiple of sizeof (EMACS_INT); it need not be, if
3303 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3304 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3305
895009e1
JB
33062011-04-26 Juanma Barranquero <lekktu@gmail.com>
3307
3308 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3309
6a7a1b0b
TZ
33102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3311
3312 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3313 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3314 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3315
841a1577 33162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3317
3318 * lisp.h (Qdebug): List symbol.
895009e1 3319 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3320 * keyboard.c (debug-on-event): New variable.
3321 (handle_user_signal): Break into debugger when debug-on-event
3322 matches the current signal symbol.
3323
f2d3ba6f
DN
33242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3325
3326 * alloc.c (check_sblock, check_string_bytes)
3327 (check_string_free_list): Convert to standard C.
3328
42ce4c63
TZ
33292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3330
3331 * w32.c (emacs_gnutls_push): Fix typo.
3332
825cd63c
EZ
33332011-04-25 Eli Zaretskii <eliz@gnu.org>
3334
fb11d64d
EZ
3335 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3336 "cast to pointer from integer of different size".
3337
825cd63c
EZ
3338 Improve doprnt and its use in verror. (Bug#8545)
3339 * doprnt.c (doprnt): Document the set of format control sequences
3340 supported by the function. Use SAFE_ALLOCA instead of always
3341 using `alloca'.
3342
3343 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3344 is one byte too soon. Don't use xrealloc; instead xfree and
3345 xmalloc anew.
3346
e061a11b
TZ
33472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3348
3349 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3350 callbacks stage.
3351
3352 * gnutls.c: Renamed global_initialized to
3353 gnutls_global_initialized. Added internals for the
3354 :verify-hostname-error, :verify-error, and :verify-flags
3355 parameters of `gnutls-boot' and documented those parameters in the
3356 docstring. Start callback support.
9173deec
JB
3357 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3358 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3359 on error. Return error code.
e061a11b
TZ
3360 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3361 (emacs_gnutls_read): Likewise.
3362 (Fgnutls_boot): Return handshake error code.
3363 (emacs_gnutls_handle_error): New function.
3364 (wsaerror_to_errno): Likewise.
3365
3366 * w32.h (emacs_gnutls_pull): Add prototype.
3367 (emacs_gnutls_push): Likewise.
3368
3369 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3370 (emacs_gnutls_push): Likewise.
3371
33722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3373
3374 * process.c (wait_reading_process_output): Check if GnuTLS
3375 buffered some data internally if no FDs are set for TLS
3376 connections.
3377
3378 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3379 (LIBS): Link to USER_LIBS.
3380 ($(BLD)/gnutls.$(0)): New target.
3381
fa6996bc
EZ
33822011-04-24 Eli Zaretskii <eliz@gnu.org>
3383
eb35682e
EZ
3384 * xdisp.c (handle_single_display_spec): Rename the
3385 display_replaced_before_p argument into display_replaced_p, to
3386 make it consistent with the commentary. Fix typos in the
3387 commentary.
3388
e2ad650c
EZ
3389 * textprop.c (syms_of_textprop): Remove dead code.
3390 (copy_text_properties): Delete obsolete commentary about an
3391 interface that was deleted long ago. Fix typos in the description
3392 of arguments.
3393
1b2de274
EZ
3394 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3395 to changes in oldXMenu/XMenu.h from 2011-04-16.
3396 <menu_help_message, prev_menu_help_message>: Constify.
3397 (IT_menu_make_room): menu->help_text is now `const char **';
3398 adjust.
3399
3400 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3401 to changes in oldXMenu/XMenu.h from 2011-04-16.
3402 (struct XMenu): Declare `help_text' `const char **'.
3403
3404 * xfaces.c <Qunspecified>: Make extern again.
3405
3406 * syntax.c: Include sys/types.h before including regex.h, as
3407 required by Posix.
3408
762b15be
EZ
3409 * doc.c (get_doc_string): Improve the format passed to `error'.
3410
3411 * doprnt.c (doprnt): Improve commentary.
3412
3413 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3414
3415 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3416 them with etags.
3417
f1052e5d
EZ
3418 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3419 changes in globals.h immediately force recompilation.
762b15be
EZ
3420 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3421 $(CURDIR)/s/ms-w32.h.
3422 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3423
fa6996bc
EZ
3424 * character.c (Fchar_direction): Function deleted.
3425 (syms_of_character): Don't defsubr it.
3426 <char-direction-table>: Deleted.
3427
e6c3da20
EZ
34282011-04-23 Eli Zaretskii <eliz@gnu.org>
3429
3430 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3431 * doprnt.c: Include limits.h.
3432 (SIZE_MAX): New macro.
04f2d78b
CB
3433 (doprnt): Return a size_t value. 2nd arg is now size_t.
3434 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3435 Improve overflow protection. Support `l' modifier for integer
3436 conversions. Support %l conversion. Don't assume an EMACS_INT
3437 argument for integer conversions and for %c.
3438
3439 * lisp.h (doprnt): Restore prototype.
3440
3441 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3442 $(SRC)/character.h.
3443
3444 * Makefile.in (base_obj): Add back doprnt.o.
3445
3446 * deps.mk (doprnt.o): Add back prerequisites.
3447 (callint.o): Depend on character.h.
3448
3449 * eval.c (internal_lisp_condition_case): Include the handler
3450 representation in the error message.
3451 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3452 when breaking from the loop.
3453
3454 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3455
3456 * callint.c (Fcall_interactively): When displaying error message
3457 about invalid control letter, pass the character's codepoint, not
3458 a pointer to its multibyte form. Improve display of the character
3459 in octal and display also its hex code.
3460
3461 * character.c (char_string): Use %x to display the (unsigned)
3462 codepoint of an invalid character, to avoid displaying a bogus
3463 negative value.
3464
3465 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3466 `error', not SYMBOL_NAME itself.
3467
3468 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3469 character arguments to `error'.
3470
3471 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3472 to `error' in error message about FINAL_CHAR argument. Make sure
3473 FINAL_CHAR is a character, and use %c when it is passed as
3474 argument to `error'.
3475
4ffd0d6b 34762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3477
3478 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3479
3480 * w32.c: Include <time.h>.
3481 (sys_localtime): New function.
3482
4ffd0d6b 34832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3484
3485 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3486
4ffd0d6b 3487 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3488
4ffd0d6b 34892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3490
4ffd0d6b
GM
3491 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3492 zombies (Bug#8467).
aac0c6e3 3493
04c56954
EZ
34942011-04-19 Eli Zaretskii <eliz@gnu.org>
3495
3496 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3497 gl_state.e_property when gl_state.object is Qt.
3498
3499 * insdel.c (make_gap_larger): Remove limitation of buffer size
3500 to <= INT_MAX.
3501
16a43933
CY
35022011-04-18 Chong Yidong <cyd@stupidchicken.com>
3503
3504 * xdisp.c (lookup_glyphless_char_display)
3505 (produce_glyphless_glyph): Handle cons cell entry in
3506 glyphless-char-display.
3507 (Vglyphless_char_display): Document it.
3508
3509 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3510 glyphless-char-display.
3511
4581706e
CY
35122011-04-17 Chong Yidong <cyd@stupidchicken.com>
3513
3514 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3515
3516 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3517
3518 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3519 definition for no-X builds.
3520
4887c6e2 35212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3522
fd35b6f9
PE
3523 Static checks with GCC 4.6.0 and non-default toolkits.
3524
5c1ccb01
PE
3525 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3526
006c5daa
PE
3527 * process.c (keyboard_bit_set): Define only if SIGIO.
3528 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3529 (send_process): Repair possible setjmp clobbering.
3530
efc736d3
PE
3531 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3532
4e2fe2e6
PE
3533 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3534
f97334a2
PE
3535 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3536
4e75f29d
PE
3537 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3538 Define only if needed.
3539
90efadd1
PE
3540 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3541 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3542 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3543
3c647824
PE
3544 * dispextern.h (struct redisplay_interface): Rename param
3545 to avoid shadowing.
e264f262 3546 * termhooks.h (struct terminal): Likewise.
761383f4 3547 * xterm.c (xembed_send_message): Likewise.
3c647824 3548
b58c5c4a
PE
3549 * insdel.c (make_gap_smaller): Define only if
3550 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3551
cad59032
PE
3552 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3553 it.
3554
c339dc2e
PE
3555 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3556 so that we aren't warned about unused symbols.
3557
91a3e27b
PE
3558 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3559
399c71d3 3560 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3561
8ffc96f5
PE
3562 * xfns.c (x_real_positions): Mark locals as initialized.
3563
eef9bc79
PE
3564 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3565
098db9dd
PE
3566 * xterm.c: Fix problems found by static analysis with other toolkits.
3567 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3568 (x_dispatch_event): Declare static if USE_GTK, and
3569 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3570 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3571 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3572 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3573 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3574
eb18f6cc
PE
3575 * xmenu.c (menu_help_callback): Pointer type fixes.
3576 Use const pointers when pointing at readonly data. Avoid pointer
3577 signedness clashes.
3578 (FALSE): Remove unused macro.
3579 (update_frame_menubar): Remove unused decl.
3580
1fe72bf8
PE
3581 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3582
60d9e1db
PE
3583 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3584 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3585 (single_menu_item): Rename local to avoid shadowing.
3586
39261c26
PE
3587 * keyboard.c (make_lispy_event): Remove unused local var.
3588
018c5e19
PE
3589 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3590 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3591
63d2b86e
PE
3592 * bitmaps: Change bitmaps from unsigned char back to the X11
3593 compatible char. Avoid the old compiler warnings about
3594 out-of-range initializers by using, for example, '\xab' rather
3595 than 0xab.
3596
aefd87e1
PE
3597 * xgselect.c (xgselect_initialize): Check vs interface
3598 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3599
bf501fb9
PE
3600 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3601
e9829fdf
PE
3602 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3603 to read-only memory.
3604
1086c095
PE
3605 * fns.c (vector): Remove; this old hack is no longer needed.
3606
2baccd04 3607 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3608 Remove unused var.
dde42981 3609 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3610
72391843 3611 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3612
436c16df 3613 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3614 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3615 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3616
92bb796d 3617 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3618 (x_term_init): Remove local to avoid shadowing.
92bb796d 3619
764430a3 3620 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3621
3622 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3623 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3624
d1dfb56c
EZ
36252011-04-16 Eli Zaretskii <eliz@gnu.org>
3626
c4354cb4
EZ
3627 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3628
d1dfb56c
EZ
3629 Fix regex.c, syntax.c and friends for buffers > 2GB.
3630 * syntax.h (struct gl_state_s): Declare character position members
3631 EMACS_INT.
3632
3633 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3634
04f2d78b
CB
3635 * textprop.c (verify_interval_modification, interval_of):
3636 Declare arguments EMACS_INT.
d1dfb56c
EZ
3637
3638 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3639 EMACS_INT.
3640
3641 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3642
3643 * indent.c (Fvertical_motion): Local variable it_start is now
3644 EMACS_INT.
3645
3646 * regex.c (re_match, re_match_2, re_match_2_internal)
3647 (bcmp_translate, regcomp, regexec, print_double_string)
3648 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3649 (re_compile_pattern, re_exec): Declare arguments and local
3650 variables `size_t' and `ssize_t' and return values `regoff_t', as
3651 appropriate.
3652 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3653 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3654 <compile_stack_type>: `size' and `avail' are now `size_t'.
3655
3656 * regex.h <regoff_t>: Use ssize_t, not int.
3657 (re_search, re_search_2, re_match, re_match_2): Arguments that
3658 specify buffer/string position and length are now ssize_t and
3659 size_t. Return type is regoff_t.
3660
613052cd
BK
36612011-04-16 Ben Key <bkey76@gmail.com>
3662
3663 * nsfont.m: Fixed bugs in ns_get_family and
3664 ns_descriptor_to_entity that were caused by using free to
3665 deallocate memory blocks that were allocated by xmalloc (via
3666 xstrdup). This caused Emacs to crash when compiled with
3667 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3668 --enable-checking=xmallocoverrun). xfree is now used to
3669 deallocate these memory blocks.
3670
4170f62f 36712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3672
71b41406
PE
3673 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3674
9587a89d
PE
3675 emacs_write: Accept and return EMACS_INT for sizes.
3676 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3677 et seq.
3678 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3679 Accept and return EMACS_INT.
3680 (emacs_gnutls_write): Return the number of bytes written on
3681 partial writes.
3682 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3683 (emacs_read, emacs_write): Remove check for negative size, as the
3684 Emacs source code has been audited now.
9587a89d
PE
3685 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3686 (emacs_read, emacs_write): Use it.
273a5f82
PE
3687 * process.c (send_process): Adjust to the new signatures of
3688 emacs_write and emacs_gnutls_write. Do not attempt to store
3689 a byte offset into an 'int'; it might overflow.
9587a89d 3690 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3691
3e047f51
PE
3692 * sound.c: Don't assume sizes fit in 'int'.
3693 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3694 Return EMACS_INT, not int.
3e047f51 3695 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3696 Accept EMACS_INT, not int.
3697 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3698 record read return values.
3699
cc39a9db
BK
37002011-04-15 Ben Key <bkey76@gmail.com>
3701
c9d0ec6d
JB
3702 * keyboard.c (Qundefined): Don't declare static since it is used
3703 in nsfns.m.
3704 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3705 static since they are used in nsfont.m.
cc39a9db 3706
6c60eb9f
SM
37072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3708
3709 * process.c (Qprocessp): Don't declare static.
3710 * lisp.h (Qprocessp): Declare again.
3711
7990b61a
JB
37122011-04-15 Juanma Barranquero <lekktu@gmail.com>
3713
3714 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3715
5d4cb038
PE
37162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3717
8bd7b830 3718 Improve C-level modularity by making more things 'static'.
cd64ea1d 3719
e3b27b31
PE
3720 Don't publish debugger-only interfaces to other modules.
3721 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3722 (verify_bytepos, count_markers): Move decls to the only modules
3723 that need them.
3724 * region-cache.h (pp_cache): Likewise.
3725 * window.h (check_all_windows): Likewise.
3726 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3727
5d4cb038
PE
3728 * sysdep.c (croak): Now static, if
3729 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3730 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3731
3732 * alloc.c (refill_memory_reserve): Now static if
3733 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3734 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3735
e87b6180
PE
3736 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3737 Define only if USE_LUCID.
3738
ac64929e
PE
3739 * xrdb.c (x_customization_string, x_rm_string): Now static.
3740
6f37259d
PE
3741 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3742 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3743
1683e3ab
PE
3744 * xdisp.c (draw_row_with_mouse_face): Now static.
3745 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3746
de9c2632
PE
3747 * window.h (check_all_windows): Mark externally visible.
3748
2b96acb7
PE
3749 * window.c (window_deletion_count): Now static.
3750
3751 * undo.c: Make symbols static if they're not exported.
3752 (last_undo_buffer, last_boundary_position, pending_boundary):
3753 Now static.
3754
50436f33
PE
3755 * textprop.c (interval_insert_behind_hooks): Now static.
3756 (interval_insert_in_front_hooks): Likewise.
3757
64520e5c
PE
3758 * term.c: Make symbols static if they're not exported.
3759 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3760 (max_frame_lines, tty_set_terminal_modes):
3761 (tty_reset_terminal_modes, tty_turn_off_highlight):
3762 (get_tty_terminal): Now static.
3763 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3764 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3765 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3766 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3767 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3768
1fa53021
PE
3769 * sysdep.c: Make symbols static if they're not exported.
3770 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3771 Now static.
3772 (sigprocmask_set, full_mask): Remove; unused.
3773 (wait_debugging): Mark as visible.
3774 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3775 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3776
d4b43b22
PE
3777 * syntax.c (syntax_temp): Define only if !__GNUC__.
3778
b7c513d0
PE
3779 * sound.c (current_sound_device, current_sound): Now static.
3780
989b29ad
PE
3781 * search.c (searchbufs, searchbuf_head): Now static.
3782
13a55a78
PE
3783 * scroll.c (scroll_cost): Remove; unused.
3784 * dispextern.h (scroll_cost): Remove decl.
3785
de68a1fc
PE
3786 * region-cache.h (pp_cache): Mark as externally visible.
3787
40ccffa6
PE
3788 * process.c: Make symbols static if they're not exported.
3789 (process_tick, update_tick, create_process, chan_process):
3790 (Vprocess_alist, proc_buffered_char, datagram_access):
3791 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3792 (deactivate_process): Mark defn as static, as well as decl.
3793 * lisp.h (create_process): Remove decl.
3794 * process.h (chan_process, Vprocess_alist): Remove decls.
3795
ad64fc97
PE
3796 * print.c: Make symbols static if they're not exported.
3797 (print_depth, new_backquote_output, being_printed, print_buffer):
3798 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3799 (print_interval, print_number_index, initial_stderr_stream):
3800 Now static.
3801 * lisp.h (Fprinc): Remove decl.
3802 (debug_output_compilation_hack): Mark as externally visible.
3803
adddb265
PE
3804 * sysdep.c (croak): Move decl from here to syssignal.h.
3805 * syssignal.h (croak): Put it here, so the API can be checked when
3806 'croak' is called from dissociate_if_controlling_tty.
3807
1717ede2
PE
3808 * minibuf.c: Make symbols static if they're not exported.
3809 (minibuf_save_list, choose_minibuf_frame): Now static.
3810 * lisp.h (choose_minibuf_frame): Remove decl.
3811
fa5fb2bc
PE
3812 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3813
1e3890d1
PE
3814 * lread.c: Make symbols static if they're not exported.
3815 (read_objects, initial_obarray, oblookup_last_bucket_number):
3816 Now static.
3817 (make_symbol): Remove; unused.
3818 * lisp.h (initial_obarray, make_symbol): Remove decls.
3819
8a1414fa
PE
3820 * keyboard.c: Make symbols static if they're not exported.
3821 (single_kboard, recent_keys_index, total_keys, recent_keys):
3822 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3823 (this_single_command_key_start, echoing, last_auto_save):
3824 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3825 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3826 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3827 (Vlispy_mouse_stem, double_click_count):
3828 Now static.
3829 (force_auto_save_soon): Define only if SIGDANGER.
3830 (ignore_mouse_drag_p): Now static if
3831 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3832 (print_help): Remove; unused.
3833 (stop_character, last_timer_event): Mark as externally visible.
3834 * keyboard.h (ignore_mouse_drag_p): Declare only if
3835 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3836 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3837 * lisp.h (echoing): Remove decl.
3838 (force_auto_save_soon): Declare only if SIGDANGER.
3839 * xdisp.c (redisplay_window): Simplify code, to make it more
3840 obvious that ignore_mouse_drag_p is not accessed if !defined
3841 USE_GTK && !defined HAVE_NS.
3842
93ea6e8f
PE
3843 * intervals.c: Make symbols static if they're not exported.
3844 (merge_properties_sticky, merge_interval_right, delete_interval):
3845 Now static.
3846 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3847
77382fcc
PE
3848 * insdel.c: Make symbols static if they're not exported.
3849 However, leave prepare_to_modify_buffer alone. It's never
3850 called from outside this function, but that appears to be a bug.
3851 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3852 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3853 (adjust_after_replace_noundo): Remove; unused.
3854 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3855 (signal_before_change): Remove decls.
77382fcc 3856
9306c32e
PE
3857 * indent.c (val_compute_motion, val_vmotion): Now static.
3858
cd44d2eb
PE
3859 * image.c: Make symbols static if they're not exported.
3860 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3861 if USE_GTK.
3862 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3863 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3864
ad9a7a06
PE
3865 * fringe.c (standard_bitmaps): Now static.
3866 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3867
81626931
PE
3868 * frame.c: Make symbols static if they're not exported.
3869 (x_report_frame_params, make_terminal_frame): Now static.
3870 (get_frame_param): Now static, unless HAVE_NS.
3871 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3872 (x_get_resource_string): Remove; not used.
3873 * frame.h (make_terminal_frame, x_report_frame_params):
3874 (x_get_resource_string); Remove decls.
3875 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3876 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3877
239f9db9
PE
3878 * font.c, fontset.c: Make symbols static if they're not exported.
3879 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3880 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3881 * font.c (font_close_object): Now static.
3882 * font.h (font_close_object): Remove.
3883 * fontset.c (FONTSET_OBJLIST): Remove.
3884 (free_realized_fontset) #if-0 the body, which does nothing.
3885 (face_suitable_for_char_p): #if-0, as it's never called.
3886 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3887 * xfaces.c (face_at_string_position):
3888 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3889 since 0 is always ASCII.
3890
dfcf3579
PE
3891 * fns.c (weak_hash_tables): Now static.
3892
5045092b
PE
3893 * fileio.c: Make symbols static if they're not exported.
3894 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3895 (Vwrite_region_annotation_buffers): Now static.
3896
57a96f5c
PE
3897 * eval.c: Make symbols static if they're not exported.
3898 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3899 * lisp.h (backtrace_list): Remove decl.
3900
35f08c38
PE
3901 * emacs.c: Make symbols static if they're not exported.
3902 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3903 (fatal_error_code, fatal_error_signal_hook, standard_args):
3904 Now static.
3905 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3906 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3907 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3908 * lisp.h (fatal_error_signal_hook): Remove decl.
3909 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3910
f44bd759
PE
3911 * editfns.c: Move a (normally-unused) function to its only use.
3912 * editfns.c, lisp.h (get_operating_system_release): Remove.
3913 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3914 worth the hassle of breaking this out.
3915
b532497d
PE
3916 * xterm.c: Make symbols static if they're not exported.
3917 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3918 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3919 (x_destroy_window, x_delete_display):
3920 Now static.
3921 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3922 (x_mouse_leave): Remove; unused.
3923 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3924 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3925 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3926 Remove decls.
3927 (x_mouse_leave): Declare only if WINDOWSNT.
3928 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3929 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3930 USE_X_TOOLKIT.
3931
1675728f
PE
3932 * ftxfont.c: Make symbols static if they're not exported.
3933 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3934 HAVE_FREETYPE.
3935 * font.h (ftxfont_driver): Likewise.
3936
e4cebfca
PE
3937 * xfns.c: Make symbols static if they're not exported.
3938 (x_last_font_name, x_display_info_for_name):
3939 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3940 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3941 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3942 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3943 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3944 (last_show_tip_args): Now static.
3945 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3946 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3947 (x_screen_planes): Remove; unused.
3948 * dispextern.h (x_screen_planes): Remove decl.
3949
5bf46f05
PE
3950 * dispnew.c: Make symbols static if they're not exported.
3951 * dispextern.h (redraw_garbaged_frames, scrolling):
3952 (increment_row_positions): Remove.
3953 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3954 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3955 Now static.
3956 (redraw_garbaged_frames): Remove; unused.
3957
435f4c28
PE
3958 * xfaces.c: Make symbols static if they're not exported.
3959 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3960 Remove decls.
3961 * xterm.h (defined_color): Remove decls.
3962 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3963 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3964 (menu_face_changed_default, defined_color, free_realized_face):
3965 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3966 (ascii_face_of_lisp_face): Remove; unused.
3967
8524aef3
PE
3968 * xdisp.c: Make symbols static if they're not exported.
3969 * dispextern.h (scratch_glyph_row, window_box_edges):
3970 (glyph_to_pixel_coords, set_cursor_from_row):
3971 (get_next_display_element, set_iterator_to_next):
3972 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3973 (show_mouse_face): Remove decls
3974 * frame.h (message_buf_print): Likewise.
3975 * lisp.h (pop_message, set_message, check_point_in_composition):
3976 Likewise.
3977 * xterm.h (set_vertical_scroll_bar): Likewise.
3978 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3979 (message_buf_print, scratch_glyph_row, displayed_buffer):
3980 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3981 (get_next_display_element, show_mouse_face, window_box_edges):
3982 (frame_to_window_pixel_xy, check_point_in_composition):
3983 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3984 (glyph_to_pixel_coords): Remove; unused.
3985
16390cd2
PE
3986 * dired.c (file_name_completion): Now static.
3987
3988 * dbusbind.c (xd_in_read_queued_messages): Now static.
3989
a25f4dfa
PE
3990 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3991 * data.c (circular_list_error): Remove.
3992
14a9c8df
PE
3993 * commands.h (last_point_position, last_point_position_buffer):
3994 (last_point_position_window): Remove decls.
3995 * keyboard.c: Make these variables static.
3996
04f2d78b
CB
3997 * coding.h (coding, code_convert_region, encode_coding_gap):
3998 Remove decls.
74ab6df5
PE
3999 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4000 (iso_code_class, detect_coding, code_convert_region): Now static.
4001 (encode_coding_gap): Remove; unused.
4002
38dfbee1
PE
4003 * chartab.c (chartab_chars, chartab_bits): Now static.
4004
a2cb4e63
PE
4005 * charset.h (charset_iso_8859_1): Remove decl.
4006 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4007 Now static.
4008
127198fd
PE
4009 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4010 * ccl.c (Vccl_program_table): Now static.
4011 (check_ccl_update): Remove; unused.
4012
d85b608f
PE
4013 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4014 * category.h: ... from here.
4015 * category.c (check_category_table, set_category_set): Now static.
4016
31cd66f3
PE
4017 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4018 * lisp.h: Remove these decls.
4019
c358e587
PE
4020 * buffer.c (buffer_count): Remove unused var.
4021
e78aecca
PE
4022 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4023 so that it's not optimized away.
4024 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4025 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4026 exported only to the debugger.
4027
e192d7d3 4028 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4029 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4030
92470028
PE
4031 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4032 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4033 was inaccessible from Lisp.
4034 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4035 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4036
244ed907
PE
4037 alloc.c: Import and export fewer symbols, and remove unused items.
4038 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4039 is defined.
4040 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4041 it's not optimized away by whole-program optimization.
4042 (message_enable_multibyte, free_misc): Remove.
4043 (catchlist, handlerlist, mark_backtrace):
4044 Declare only if BYTE_MARK_STACK.
4045 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4046 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4047 (message_enable_multibyte): Remove decl.
4048 (free_misc, interval_free_list, float_block, float_block_index):
4049 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4050 (cons_free_list, last_marked_index):
4051 Now static.
4052 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4053 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4054 (mark_backtrace): Define only if BYTE_MARK_STACK.
4055 * xdisp.c (message_enable_multibyte): Now static.
4056
61c2b50e 4057 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4058 This makes it easier for human readers (and static analyzers)
4059 to see whether these variables are used from other modules.
4060 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4061 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4062 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4063 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4064 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4065 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4066 * xmenu.c, xselect.c:
4067 Declare Q* vars static if they are not used in other modules.
4068 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4069 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4070 Remove decls of unexported vars.
4071 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4072
95c82688
PE
4073 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4074
16a97296
PE
4075 Make Emacs functions such as Fatom 'static' by default.
4076 This makes it easier for human readers (and static analyzers)
4077 to see whether these functions can be called from other modules.
4078 DEFUN now defines a static function. To make the function external
4079 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4080 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4081 (Finit_image_library):
16a97296
PE
4082 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4083 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4084 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4085 Remove decls, since these functions are now static.
4086 (Funintern, Fget_internal_run_time): New decls, since these functions
4087 were already external.
95c82688 4088
16a97296
PE
4089 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4090 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4091 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4092 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4093 * keyboard.c, keymap.c, lread.c:
4094 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4095 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4096 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4097 Mark functions with DEFUE instead of DEFUN,
4098 if they are used in other modules.
4099 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4100 decls for now-static functions.
4101 * buffer.h (Fdelete_overlay): Remove decl.
4102 * callproc.c (Fgetenv_internal): Mark as internal.
4103 * composite.c (Fremove_list_of_text_properties): Remove decl.
4104 (Fcomposition_get_gstring): New forward static decl.
4105 * composite.h (Fcomposite_get_gstring): Remove decl.
4106 * dired.c (Ffile_attributes): New forward static decl.
4107 * doc.c (Fdocumntation_property): New forward static decl.
4108 * eval.c (Ffetch_bytecode): New forward static decl.
4109 (Funintern): Remove extern decl; now in .h file where it belongs.
4110 * fileio.c (Fmake_symbolic_link): New forward static decl.
4111 * image.c (Finit_image_library): New forward static decl.
4112 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4113 * intervals.h (Fprevious_property_change):
4114 (Fremove_list_of_text_properties): Remove decls.
4115 * keyboard.c (Fthis_command_keys): Remove decl.
4116 (Fcommand_execute): New forward static decl.
4117 * keymap.c (Flookup_key): New forward static decl.
4118 (Fcopy_keymap): Now static.
4119 * keymap.h (Flookup_key): Remove decl.
4120 * process.c (Fget_process): New forward static decl.
4121 (Fprocess_datagram_address): Mark as internal.
4122 * syntax.c (Fsyntax_table_p): New forward static decl.
4123 (skip_chars): Remove duplicate decl.
4124 * textprop.c (Fprevious_property_change): New forward static decl.
4125 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4126 Now internal.
4127 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4128 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4129
785bbd42
PE
4130 * editfns.c (Fformat): Remove unreachable code.
4131
8b913b57
AS
41322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4133
4134 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4135 change. (Bug#8496)
4136
a6744a35
EZ
41372011-04-13 Eli Zaretskii <eliz@gnu.org>
4138
4139 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4140 when at ZV. (Bug#8487)
4141
e7974947
AS
41422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4143
baad03f0
AS
4144 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4145 (Bug#8437)
4146 * keyboard.c (parse_tool_bar_item): Likewise.
4147 * sound.c (sound_cleanup, alsa_close): Likewise.
4148 * termcap.c (tgetent): Likewise.
4149 * xfns.c (x_default_font_parameter): Likewise.
4150 * xsettings.c (read_and_apply_settings): Likewise.
4151
e7974947
AS
4152 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4153 (overrun_check_free): Protoize.
4154
28272684
PE
41552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4156
4157 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4158 since callers should never pass a negative size.
4159 Change the signature to match that of plain 'read' and 'write'; see
4160 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4161 * lisp.h: Update prototypes of emacs_write and emacs_read.
4162
11997c76
EZ
41632011-04-11 Eli Zaretskii <eliz@gnu.org>
4164
4165 * xdisp.c (redisplay_window): Don't try to determine the character
4166 position of the scroll margin if the window start point w->startp
e896f03c 4167 is outside the buffer's accessible region. (Bug#8468)
11997c76 4168
8a2cbd72
EZ
41692011-04-10 Eli Zaretskii <eliz@gnu.org>
4170
4171 Fix write-region and its subroutines for buffers > 2GB.
4172 * fileio.c (a_write, e_write): Modify declaration of arguments and
4173 local variables to support buffers larger than 2GB.
4174 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4175
4176 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4177 argument, local variables, and return value.
4178
4179 * lisp.h: Update prototypes of emacs_write and emacs_read.
4180
4181 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4182
4073e537 41832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4184
1ebfdcb6
PE
4185 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4186
b2ded58d
PE
4187 Fix more problems found by GCC 4.6.0's static checks.
4188
7d66342c
PE
4189 * xdisp.c (vmessage): Use a better test for character truncation.
4190
bbf47d44
PE
4191 * charset.c (load_charset_map): <, not <=, for optimization,
4192 and to avoid potential problems with integer overflow.
9248994d 4193 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4194 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4195 * editfns.c (Fformat): Likewise.
1e69125e 4196 * syntax.c (skip_chars): Likewise.
3befa583 4197
e3019616
PE
4198 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4199 This also lets GCC 4.6.0 generate slightly better loop code.
4200
becfa255
PE
4201 * callint.c (Fcall_interactively): <, not <=, for optimization.
4202 (Fcall_interactively): Count the number of arguments produced,
4203 not the number of arguments given. This is simpler and lets GCC
4204 4.6.0 generate slightly better code.
4205
dae0cd48
PE
4206 * ftfont.c: Distingish more carefully between FcChar8 and char.
4207 The previous code passed unsigned char * to a functions like
4208 strlen and xstrcasecmp that expect char *, which does not
4209 conform to the C standard.
4210 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4211 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4212 char * when the C standard requires it.
4213
76032d70
PE
4214 * keyboard.c (read_char): Remove unused var.
4215
eb3f1cc8
PE
4216 * eval.c: Port to Windows vsnprintf (Bug#8435).
4217 Include <limits.h>.
4218 (SIZE_MAX): Define if the headers do not.
4219 (verror): Do not give up if vsnprintf returns a negative count.
4220 Instead, grow the buffer. This ports to Windows vsnprintf, which
4221 does not conform to C99. Problem reported by Eli Zaretskii.
4222 Also, simplify the allocation scheme, by avoiding the need for
4223 calling realloc, and removing the ALLOCATED variable.
4224
70476b54
PE
4225 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4226
12020a9e
PE
4227 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4228 But keep the doprint source code for now, as we might revamp it
4229 and use it again (Bug#8435).
ea6c7ae6
PE
4230 * lisp.h (doprnt): Remove.
4231 * Makefile.in (base_obj): Remove doprnt.o.
4232 * deps.mk (doprnt.o): Remove.
4233
5fdb398c
PE
4234 error: Print 32- and 64-bit integers portably (Bug#8435).
4235 Without this change, on typical 64-bit hosts error ("...%d...", N)
4236 was used to print both 32- and 64-bit integers N, which relied on
4237 undefined behavior.
4238 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4239 New macro.
4240 * lisp.h (error, verror): Mark as printf-like functions.
4241 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4242 Report overflow in size calculations when allocating printf buffer.
4243 Do not truncate output string at its first null byte.
4244 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4245 Truncate the output at a character boundary, since vsnprintf does not
4246 do that.
4247 * charset.c (check_iso_charset_parameter): Convert internal
4248 character to string before calling 'error', since %c now has the
4249 printf meaning.
4250 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4251 overflow when computing char to be passed to 'error'. Do not
4252 pass Lisp_Object to 'error'; pass the integer instead.
4253 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4254 formatted with plain %d.
4255
b189fa66
PE
4256 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4257
bff87ef0
PE
4258 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4259
7e2cac20
PE
4260 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4261
ce4d90b5
PE
4262 * xterm.c (x_catch_errors): Remove duplicate declaration.
4263
266c9547
PE
4264 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4265
79c49ad2
PE
4266 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4267
368f4090
JM
42682011-04-10 Jim Meyering <meyering@redhat.com>
4269
4270 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4271 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4272 return ssize_t not "int", and use size_t as the buffer length.
4273 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4274 * gnutls.h: Update declarations.
4275 * process.c (read_process_output): Use ssize_t, to match.
4276 (send_process): Likewise.
4277
a32d4040
CY
42782011-04-09 Chong Yidong <cyd@stupidchicken.com>
4279
4280 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4281
8546720e 42822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4283
04f2d78b
CB
4284 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4285 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4286
8546720e
GM
4287 * xterm.c (handle_one_xevent):
4288 * xmenu.c (create_and_show_popup_menu):
4289 * xselect.c (x_decline_selection_request)
4290 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4291
0a2f5c1a 42922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4293
4294 Fix some uses of `int' instead of EMACS_INT.
4295 * search.c (string_match_1, fast_string_match)
4296 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4297 (scan_buffer, find_next_newline_no_quit)
4298 (find_before_next_newline, search_command, Freplace_match)
4299 (Fmatch_data): Make some `int' variables be EMACS_INT.
4300
4301 * xdisp.c (display_count_lines): 3rd argument and return value now
4302 EMACS_INT. All callers changed.
4303 (pint2hrstr): Last argument is now EMACS_INT.
4304
4305 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4306 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4307 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4308 (decode_coding_utf_16, decode_coding_emacs_mule)
4309 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4310 (decode_coding_ccl, decode_coding_charset)
4311 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4312 (decode_coding_iso_2022, decode_coding_emacs_mule)
4313 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4314 <char_offset, last_offset>: Declare EMACS_INT.
4315 (encode_coding_utf_8, encode_coding_utf_16)
4316 (encode_coding_emacs_mule, encode_invocation_designation)
4317 (encode_designation_at_bol, encode_coding_iso_2022)
4318 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4319 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4320 Declare EMACS_INT.
4321 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4322 (encode_invocation_designation): Last argument P_NCHARS is now
4323 EMACS_INT.
4324 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4325 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4326
4327 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4328 All users changed.
4329
4330 * ccl.c (Fccl_execute_on_string): Declare some variables
4331 EMACS_INT.
4332
8546720e 43332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4334
4335 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4336
4e19a977
CS
43372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4338
4339 * process.c (Fformat_network_address): Doc fix.
4340
87302331
R
43412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4342
4343 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4344
cbb59342
CY
43452011-04-08 Chong Yidong <cyd@stupidchicken.com>
4346
4347 * keyboard.c (read_char): Call Lisp function help-form-show,
4348 instead of using internal_with_output_to_temp_buffer.
4349 (Qhelp_form_show): New var.
e0d38eeb 4350 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4351
4352 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4353
4354 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4355
e67a13ab
CY
43562011-04-06 Chong Yidong <cyd@stupidchicken.com>
4357
04f2d78b
CB
4358 * process.c (Flist_processes): Remove to Lisp.
4359 (list_processes_1): Delete.
e67a13ab 4360
973f782d
EZ
43612011-04-06 Eli Zaretskii <eliz@gnu.org>
4362
7c106b1e
EZ
4363 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4364
973f782d
EZ
4365 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4366
41cf7d1a 43672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4368
ca23cc88
PE
4369 Fix more problems found by GCC 4.6.0's static checks.
4370
f390e2d5
PE
4371 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4372
42eea0d0
PE
4373 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4374
b69769da 4375 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4376
f9541e84
PE
4377 * xdisp.c (vmessage): Mark as a printf-like function.
4378
13841b55
PE
4379 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4380
c136c10f
PE
4381 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4382
5e2d4a30
PE
4383 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4384 printf-like functions.
4385 (tiff_load): Add casts to remove these marks before passing them
4386 to system-supplied API.
4387
583f48b9
PE
4388 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4389
b25d760e
PE
4390 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4391 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4392 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4393 directly, rather than having caller test rule sign. This avoids
4394 some unnecessary tests.
4395 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4396 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4397 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4398
bc7b6697 4399 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4400 (xfont_open): Avoid unnecessary tests.
bc7b6697 4401
27ccc379
PE
4402 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4403
dcd5c89a
PE
4404 * composite.h, composite.c (composition_gstring_put_cache):
4405 Use EMACS_INT, not int, for length.
4406
b13a45c6
PE
4407 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4408 breaking out part of COMPOSITION_DECODE_RULE.
4409 (COMPOSITION_DECODE_RULE): Use it.
4410 * composite.c (get_composition_id): Remove unused local vars,
4411 by using the new macro.
4412
1e792e4d
PE
4413 * textprop.c (set_text_properties_1): Change while to do-while,
4414 since the condition is always true at first.
4415
dc6c6455 4416 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4417 (interval_deletion_adjustment): Return unsigned value.
4418 All uses changed.
dc6c6455 4419
aba7731a
PE
4420 * process.c (list_processes_1, create_pty, read_process_output):
4421 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4422 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4423 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4424 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4425 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4426
fdfc4bf3
PE
4427 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4428
fca8fe46 4429 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4430 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4431
06a0259a 4432 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4433 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4434 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4435
e7b9e80f
PE
4436 * print.c (print_error_message): Avoid int overflow.
4437
56201685
PE
4438 * font.c (font_list_entities): Redo for clarity,
4439 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4440
78834453 4441 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4442 (font_score): Avoid potential overflow in diff calculation.
78834453 4443
0bc0b309 4444 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4445 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4446
e610eaca
PE
4447 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4448
b895abce
PE
4449 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4450 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4451 can always succeed if overflow has undefined behavior.
4452
1f1d9321 4453 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4454 (wordify): Omit three unnecessary tests.
1f1d9321 4455
c59478bc
PE
4456 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4457 All callers changed. This avoids the need for an unused var.
4458
79b73827
PE
4459 * casefiddle.c (casify_region): Remove var that is set but not used.
4460
a4db5dfe
PE
4461 * dired.c (file_name_completion): Remove var that is set but not used.
4462
43aae36e
PE
4463 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4464
2a47c44d 4465 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4466 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4467
a37c69bf
PE
4468 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4469 Check for integer overflow on size calculations.
4470
328ab8e7
PE
4471 * buffer.c (Fprevious_overlay_change): Remove var that is set
4472 but not used.
4473
e5a2a5cb
PE
4474 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4475 Remove vars that are set but not used.
8d84a6eb 4476 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4477 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4478
a60e5f68
PE
4479 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4480
f661cb61 4481 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4482 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4483
f0397f5a
PE
4484 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4485 that are set but not used.
4486
8664db06 4487 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4488 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4489
6abdaa4a
PE
4490 * xselect.c (x_get_local_selection, x_handle_property_notify):
4491 Remove vars that are set but not used.
4492
0ce7538d 4493 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4494 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4495
9ae848fc
PE
4496 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4497 Remove var that is set but not used.
0b918413
PE
4498 (scroll_bar_windows_size): Now size_t, not int.
4499 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4500 Check for overflow.
9ae848fc 4501
a5a62657
PE
4502 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4503 (map_tty_color) [!defined MSDOS]: Likewise.
4504
5c5cdd39
PE
4505 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4506
66ebf983
PE
4507 * coding.c: Remove vars that are set but not used.
4508 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4509 All callers changed.
4510 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4511 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4512 (decode_coding_charset): Remove vars that are set but not used.
4513
1be4d761
PE
4514 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4515 that is set but not used.
4516
47553fa8
PE
4517 * print.c (print_object): Remove var that is set but not used.
4518
1f7196bf 4519 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4520 The gnulib version avoids calling malloc in the usual case,
4521 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4522 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4523 * filelock.c (current_lock_owner): Likewise.
4524 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4525 * sysdep.c: Include allocator.h, careadlinkat.h.
4526 (emacs_no_realloc_allocator): New static constant.
4527 (emacs_readlink): New function.
fdb61804
PE
4528 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4529 ../lib/careadlinkat.h.
d1fdcab7 4530
f84c17c7
SM
45312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4532
4533 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4534 first non-nil return value).
4535
ef3862ad
JD
45362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4537
4538 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4539 if not defined (Bug#8403).
4540
376a7006
JB
45412011-04-02 Juanma Barranquero <lekktu@gmail.com>
4542
4543 * xdisp.c (display_count_lines): Remove parameter `start',
4544 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4545 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4546 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4547 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4548 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4549 and thereabouts. All callers changed.
4550 (get_per_char_metric): Remove parameter `f', unused since
4551 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4552
6ca3801d
JM
45532011-04-02 Jim Meyering <meyering@redhat.com>
4554
4555 do not dereference NULL upon failed strdup
4556 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4557 (ns_get_family): Likewise.
4558
d8e2b5ba
JB
45592011-04-02 Juanma Barranquero <lekktu@gmail.com>
4560
4561 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4562
8c74fcbd
JD
45632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4564
4565 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4566 later (Bug#8403).
4567
7200d79c
SM
45682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4569
03408648 4570 Add lexical binding.
7200d79c 4571
03408648
SM
4572 * window.c (Ftemp_output_buffer_show): New fun.
4573 (Fsave_window_excursion):
4574 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4575
4576 * lread.c (lisp_file_lexically_bound_p): New function.
4577 (Fload): Bind Qlexical_binding.
4578 (readevalloop): Remove `evalfun' arg.
4579 Bind Qinternal_interpreter_environment.
4580 (Feval_buffer): Bind Qlexical_binding.
4581 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4582 Mark as dynamic.
4583 (syms_of_lread): Declare `lexical-binding'.
4584
4585 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4586
4587 * keyboard.c (eval_dyn): New fun.
4588 (menu_item_eval_property): Use it.
ca105506
SM
4589
4590 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4591
03408648
SM
4592 * fns.c (concat, mapcar1): Accept byte-code-functions.
4593
4594 * eval.c (Fsetq): Handle lexical vars.
4595 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4596 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4597 (FletX, Flet): Obey lexical binding.
4598 (Fcommandp): Handle closures.
4599 (Feval): New `lexical' arg.
4600 (eval_sub): New function extracted from Feval. Use it almost
4601 everywhere where Feval was used. Look up vars in lexical env.
4602 Handle closures.
4603 (Ffunctionp): Move from subr.el.
4604 (Ffuncall): Handle closures.
4605 (apply_lambda): Remove `eval_flags'.
4606 (funcall_lambda): Handle closures and new byte-code-functions.
4607 (Fspecial_variable_p): New function.
4608 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4609 but without exporting it to Lisp.
23aba0ea 4610
23aba0ea 4611 * doc.c (Fdocumentation, store_function_docstring):
03408648 4612 * data.c (Finteractive_form): Handle closures.
23aba0ea 4613
03408648
SM
4614 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4615 interactive spec.
ba83908c 4616
04f2d78b
CB
4617 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4618 New byte-codes.
03408648
SM
4619 (exec_byte_code): New function extracted from Fbyte_code to handle new
4620 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4621
03408648 4622 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4623
03408648 4624 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4625
e2abce01
JB
46262011-03-31 Juanma Barranquero <lekktu@gmail.com>
4627
4628 * xdisp.c (redisplay_internal): Fix prototype.
4629
63696a73 46302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4631
63696a73 4632 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4633 (try_scrolling): Use it when setting scroll_limit.
4634 Limit scrolling to 100 screen lines.
63696a73
EZ
4635 (redisplay_window): Even when falling back on "recentering",
4636 position point in the window according to scroll-conservatively,
4637 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4638
4639 (try_scrolling): When point is above the window, allow searching
4640 as far as scroll_max, or one screenful, to compute vertical
4641 distance from PT to the scroll margin position. This prevents
4642 try_scrolling from unnecessarily failing when
4643 scroll-conservatively is set to a value slightly larger than the
4644 window height. Clean up the case of PT below the margin at bottom
4645 of window: scroll_max can no longer be INT_MAX. When aggressive
4646 scrolling is in use, don't let point enter the opposite scroll
4647 margin as result of the scroll.
4648 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4649 threshold of 100 lines for never-recentering scrolling.
4650
e4cc2dfc
JB
46512011-03-31 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * dispextern.h (move_it_by_lines):
4654 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4655 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4656 (message_log_check_duplicate): Remove parameters `prev_bol' and
4657 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4658 (redisplay_internal): Remove parameter `preserve_echo_area',
4659 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4660
4661 * indent.c (Fvertical_motion):
4662 * window.c (window_scroll_pixel_based, Frecenter):
4663 Don't pass `need_y_p' to `move_it_by_lines'.
4664
1c470562
SM
46652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4666
44f230aa
SM
4667 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4668 steal a few bits to be more compact.
4669 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4670 Remove unneeded casts.
4671
1c470562
SM
4672 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4673
888adce9
ZK
46742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4675
4676 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4677 binding" message (bug#7967).
4678
f838ed7b
PE
46792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4680
77861b95
PE
4681 Fix more problems found by GCC 4.6.0's static checks.
4682
de6dbc14
PE
4683 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4684 Remove unused local var.
4685
f838ed7b
PE
4686 * editfns.c (Fmessage_box): Remove unused local var.
4687
792c7b2b
PE
4688 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4689 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4690 Omit unused local vars.
c499e557 4691 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4692 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4693 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4694 Omit unused local var.
4695
ba0165e1
PE
4696 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4697 Don't assume string length fits in int.
32ad8845 4698 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4699 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4700
3c59b4c9
PE
4701 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4702 instead of alloca (Bug#8344).
4703
a3eed478 4704 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4705 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4706
eb4d412d
PE
4707 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4708
1658b401
PE
4709 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4710 concerns.
4711
4712 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4713
4714 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4715
9a2c6e05
PE
4716 * keyboard.c (syms_of_keyboard): Use the same style as later
4717 in this function when indexing through an array. This also
4718 works around GCC bug 48267.
4719
03d0a109
PE
4720 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4721
44f730c8
PE
4722 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4723
fe75f926
PE
4724 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4725 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4726
ffa8c828
PE
4727 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4728 This avoids undefined behavior on integer overflow, and is a bit
4729 more convenient anyway since it is compared to a size_t variable.
4730
c5101a77
PE
4731 Variadic C functions now count arguments with size_t, not int.
4732 This avoids an unnecessary limitation on 64-bit machines, which
4733 caused (substring ...) to crash on large vectors (Bug#8344).
4734 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4735 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4736 All variadic functions and their callers changed accordingly.
c5101a77
PE
4737 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4738 * data.c (arith_driver, float_arith_driver): Likewise.
4739 * editfns.c (general_insert_function): Likewise.
4740 * eval.c (struct backtrace.nargs, interactive_p)
4741 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4742 (funcall_lambda, mark_backtrace): Likewise.
4743 * fns.c (concat): Likewise.
4744 * frame.c (x_set_frame_parameters): Likewise.
4745 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4746 0 if not found, not -1. All callers changed.
4747
dd3f25f7
PE
4748 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4749 (stack_copy_size): Now size_t, not int.
4750 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4751
461c2ab9
JB
47522011-03-28 Juanma Barranquero <lekktu@gmail.com>
4753
4754 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4755 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4756 All callers changed.
4757
4758 * lisp.h (multibyte_char_to_unibyte):
4759 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4760 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4761 * character.h (CHAR_TO_BYTE8):
4762 * cmds.c (internal_self_insert):
4763 * editfns.c (general_insert_function):
4764 * keymap.c (push_key_description):
4765 * search.c (Freplace_match):
4766 * xdisp.c (message_dolog, set_message_1): All callers changed.
4767
f6d62986
SM
47682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4769
4770 * keyboard.c (safe_run_hook_funcall): New function.
4771 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4772 don't set the hook to nil, but remove the offending function instead.
4773 (Qcommand_hook_internal): Remove, unused.
4774 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4775 Vcommand_hook_internal.
4776
4777 * eval.c (enum run_hooks_condition): Remove.
4778 (funcall_nil, funcall_not): New functions.
4779 (run_hook_with_args): Call each function through a `funcall' argument.
4780 Remove `cond' argument, now redundant.
4781 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4782 (Frun_hook_with_args_until_failure): Adjust accordingly.
4783 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4784
1db5b1ad
JB
47852011-03-28 Juanma Barranquero <lekktu@gmail.com>
4786
4787 * dispextern.h (string_buffer_position): Remove declaration.
4788
4789 * print.c (strout): Remove parameter `multibyte', unused since
4790 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4791
4792 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4793 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4794 All callers changed.
4795
4796 * w32.c (_wsa_errlist): Use braces for struct initializers.
4797
4798 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4799 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4800 All callers changed.
4801 (string_buffer_position): Likewise. Also, make static (it's never
4802 used outside xdisp.c).
4803 (cursor_row_p): Remove parameter `w', unused since
4804 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4805 (decode_mode_spec): Remove parameter `precision', introduced during
4806 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4807 All callers changed.
4808
5ffb62aa
JD
48092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4810
4811 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4812
461c2ab9 48132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4814
4815 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4816 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4817 (ns_update_auto_hide_menu_bar): New functions.
4818 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4819 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4820 ns_constrain_all_frames.
4821 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4822 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4823
5c380ffb
JD
48242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4825
4826 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4827
9af30bdf
GM
48282011-03-27 Glenn Morris <rgm@gnu.org>
4829
4830 * syssignal.h: Replace RETSIGTYPE with void.
4831 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4832 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4833 Replace SIGTYPE with void everywhere.
4834 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4835 * s/template.h (SIGTYPE): Remove commented out definition.
4836
e2abce01
JB
48372011-03-26 Eli Zaretskii <eliz@gnu.org>
4838
4839 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4840 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4841
f868cd8a
JB
48422011-03-26 Juanma Barranquero <lekktu@gmail.com>
4843
59eb0929
JB
4844 * w32.c (read_unc_volume): Use parameter `henum', instead of
4845 global variable `wget_enum_handle'.
4846
4847 * keymap.c (describe_vector): Remove parameters `indices' and
4848 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4849 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4850
f868cd8a
JB
4851 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4852
4853 * keyboard.c (timer_check): Remove parameter `do_it_now',
4854 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4855 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4856 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4857
4858 * keyboard.c (read_char):
4859 * w32menu.c (w32_menu_display_help):
4860 * xmenu.c (show_help_event, menu_help_callback):
4861 Adjust calls to `show_help_echo'.
4862
4863 * gtkutil.c (xg_maybe_add_timer):
4864 * keyboard.c (readable_events):
4865 * process.c (wait_reading_process_output):
4866 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4867
4868 * insdel.c (adjust_markers_gap_motion):
4869 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4870 (gap_left, gap_right): Don't call it.
4871
2ecf6fdb
CY
48722011-03-25 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4875 incurred during fontification.
4876
6b1f9ba4
JB
48772011-03-25 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4880 (DEFVAR_PER_BUFFER): Don't pass it.
4881
4882 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4883 (scrolling_window): Don't pass it.
4884
0f4a96b5
JB
48852011-03-25 Juanma Barranquero <lekktu@gmail.com>
4886
4887 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4888
4889 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4890 and `suffix'.
4891 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4892 of variables specific to SELinux and computation of `encoded_absname'.
4893
4894 * image.c (XPutPixel): Remove unused variable `height'.
4895
4896 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4897
4898 * unexw32.c (get_section_info): Remove unused variable `section'.
4899
4900 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4901 (system_process_attributes): Remove unused variable `sess'.
4902 (sys_read): Remove unused variable `err'.
4903
4904 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4905 (w32_wnd_proc): Remove unused variable `isdead'.
4906 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4907 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4908 (x_create_tip_frame): Remove unused variable `tem'.
4909
4910 * w32inevt.c (w32_console_read_socket):
4911 Remove unused variable `no_events'.
4912
4913 * w32term.c (x_draw_composite_glyph_string_foreground):
4914 Remove unused variable `width'.
4915
1149507c
JB
49162011-03-24 Juanma Barranquero <lekktu@gmail.com>
4917
4918 * w32term.c (x_set_glyph_string_clipping):
4919 Don't pass uninitialized region to CombineRgn.
4920
9c88f339
JB
49212011-03-23 Juanma Barranquero <lekktu@gmail.com>
4922
4923 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4924 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4925 (Fx_close_connection): Remove unused variable `i'.
4926
4927 * w32font.c (w32font_draw): Return number of glyphs.
4928 (w32font_open_internal): Remove unused variable `i'.
4929 (w32font_driver): Add missing initializer.
4930
4931 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4932 (fill_in_menu): Remove unused variable `items_added'.
4933
4934 * w32term.c (last_mouse_press_frame): Remove static global variable.
4935 (w32_clip_to_row): Remove unused variable `f'.
4936 (x_delete_terminal): Remove unused variable `i'.
4937
4938 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4939 (NOTHING): Remove unused static global variable.
4940 (uniscribe_check_otf): Remove unused variable `table'.
4941 (uniscribe_font_driver): Add missing initializers.
4942
dee091a3
JD
49432011-03-23 Julien Danjou <julien@danjou.info>
4944
4945 * term.c (Fsuspend_tty, Fresume_tty):
4946 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4947 * window.c (temp_output_buffer_show):
4948 * insdel.c (signal_before_change):
4949 * frame.c (Fhandle_switch_frame):
4950 * fileio.c (Fdo_auto_save):
4951 * emacs.c (Fkill_emacs):
4952 * editfns.c (save_excursion_restore):
4953 * cmds.c (internal_self_insert):
4954 * callint.c (Fcall_interactively):
4955 * buffer.c (Fkill_all_local_variables):
4956 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4957 Use Frun_hooks.
0f4a96b5 4958 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4959 unconditionnaly since it does the check itself.
4960
2c520ab5 49612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4962
c9c49752
PE
4963 Fix more problems found by GCC 4.5.2's static checks.
4964
8abc3f12
PE
4965 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4966 the first time through the loop, since we know p0 < p1 then.
4967 This also avoids a gcc -Wstrict-overflow warning.
4968
a2d26660
PE
4969 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4970 leading to a memory leak, possible in functions like
4971 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4972 of objects (Bug#8318).
a2d26660 4973
916c72e9
PE
4974 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4975 that could (at least in theory) be that large.
4976
19ab8a18
PE
4977 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4978 This is less likely to overflow, and avoids undefined behavior if
4979 overflow does occur. All callers changed. Use strtoul to scan
4980 for the unsigned long integer.
b7cbbd6f
PE
4981 (pint2hrstr): Simplify and tune code slightly.
4982 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4983
f0641eff
PE
4984 * scroll.c (do_scrolling): Work around GCC bug 48228.
4985 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4986
7f650bb9
PE
4987 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4988 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4989 (validate_x_resource_name): Simplify count usage.
4990 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4991
37dd57d1
PE
4992 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4993 fail (Bug#8306).
81e56e61 4994
699979fc 4995 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4996
401bf9b4
PE
4997 * process.c (Fmake_network_process): Use socklen_t, not int,
4998 where POSIX says socklen_t is required in portable programs.
4999 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5000 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5001 (Fmake_network_process, server_accept_connection):
5002 (wait_reading_process_output, read_process_output):
5003 Likewise.
5004
b93aacde
PE
5005 * process.c: Rename or move locals to avoid shadowing.
5006 (list_processes_1, Fmake_network_process):
5007 (read_process_output_error_handler, exec_sentinel_error_handler):
5008 Rename or move locals.
4dc343ee 5009 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5010 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5011 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5012 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5013 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5014
af8a867c 5015 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5016 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5017 Include tparam.h instead, since it declares them.
af8a867c
PE
5018 * cm.h (PC): Remove extern decl; tparam.h now does this.
5019 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5020 * terminfo.c: Include tparam.h, to check interfaces.
5021 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5022 (tparam): Adjust signature to match interface in tparam.h;
5023 this removes some undefined behavior. Check that outstring and len
5024 are zero, which they always are with Emacs.
5025 * tparam.h (PC, BC, UP): New extern decls.
5026
0248044d 5027 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5028 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5029
8ff096c1 5030 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5031 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5032 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5033 (ftfont_list): Remove unused local.
49eaafba
PE
5034 (get_adstyle_property, ftfont_pattern_entity):
5035 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5036 Rename locals to avoid shadowing.
8ff096c1 5037
e2be39f6
PE
5038 * xfont.c (xfont_list_family): Mark var as initialized.
5039
c9735e30
PE
5040 * xml.c (make_dom): Now static.
5041
8f5201ae
PE
5042 * composite.c (composition_compute_stop_pos): Rename local to
5043 avoid shadowing.
b246f932
PE
5044 (composition_reseat_it): Remove unused locals.
5045 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5046 (composition_update_it): Mark var as initialized.
11b61122
PE
5047 (find_automatic_composition): Mark vars as initialized,
5048 with a FIXME (Bug#8290).
8f5201ae 5049
760fbc2c
PE
5050 character.h: Rename locals to avoid shadowing.
5051 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5052 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5053 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5054 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5055 to avoid shadowing.
5056
ff08eb85
PE
5057 * textprop.c (property_change_between_p): Remove; unused.
5058
fc7bf025
PE
5059 * intervals.c (interval_start_pos): Now static.
5060
235d7abc
PE
5061 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5062
44f230aa
SM
5063 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5064 Rename locals to avoid shadowing.
3e7d6594 5065
50060332
PE
5066 * sound.c (wav_play, au_play, Fplay_sound_internal):
5067 Fix pointer signedness.
d01f234b 5068 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5069 (wav_play): Initialize a variable to 0, to prevent undefined
5070 behavior (Bug#8278).
50060332 5071
c4fc4e30
PE
5072 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5073
918436ed
PE
5074 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5075
c939f91b
PE
5076 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5077 clobbering (Bug#8298).
b9c7f648
PE
5078 * sysdep.c (sys_subshell): Likewise.
5079 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5080
6bd8c144
PE
5081 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5082 This should get cleaned up, so that child_setup has the
5083 same signature on all platforms.
5084
7710357c 5085 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5086 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5087
c59da222
CY
50882011-03-22 Chong Yidong <cyd@stupidchicken.com>
5089
5090 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5091 not to be necessary, and produces flickering.
5092
66b87493
GM
50932011-03-20 Glenn Morris <rgm@gnu.org>
5094
5095 * config.in: Remove file.
5096
45b6f6d5
JB
50972011-03-20 Juanma Barranquero <lekktu@gmail.com>
5098
5099 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5100 are now in src/globals.h.
5101 (syms_of_minibuf): Remove spurious & from previous change.
5102
3ec03f7e
LL
51032011-03-20 Leo <sdl.web@gmail.com>
5104
5105 * minibuf.c (completing-read-function): New variable.
5106 (completing-read-default): Rename from completing-read.
5107 (completing-read): Call completing-read-function.
5108
b14e3e21
CY
51092011-03-19 Juanma Barranquero <lekktu@gmail.com>
5110
5111 * xfaces.c (Fx_load_color_file):
5112 Read color file from absolute filename (bug#8250).
5113
f2b726e6
JB
51142011-03-19 Juanma Barranquero <lekktu@gmail.com>
5115
5116 * makefile.w32-in: Update dependencies.
5117
09f6ff02
EZ
51182011-03-17 Eli Zaretskii <eliz@gnu.org>
5119
5120 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5121
29a6015a
PE
51222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5123
a3a6c54e
PE
5124 Fix more problems found by GCC 4.5.2's static checks.
5125
b766f867
PE
5126 * process.c (make_serial_process_unwind, send_process_trap):
5127 (sigchld_handler): Now static.
5128
be02381c
PE
5129 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5130 That way, the code declares only the vars that it needs.
5131 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5132 * s/cygwin.h (PTY_ITERATION): Likewise.
5133 * s/darwin.h (PTY_ITERATION): Likewise.
5134 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5135
57048744
PE
5136 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5137 * process.c (allocate_pty): Don't declare stb unless it's needed.
5138
7914961c 5139 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5140 (CONSTANTLIM): Remove; unused.
5141 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5142 Define only if needed.
7914961c 5143
b3967b18
PE
5144 * unexelf.c (unexec): Name an expression,
5145 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5146 Use a different way to cause a compilation error if anyone uses
5147 n rather than nn, a way that does not involve shadowing.
73366a00 5148 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5149
29a6015a
PE
5150 * deps.mk (unexalpha.o): Remove; unused.
5151
43cfc33e 5152 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5153 * unexec.h: New file.
ce701a33
PE
5154 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5155 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5156 Depend on unexec.h.
5157 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5158 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5159 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5160 Change as necessary to match prototype in unexec.h.
ce701a33 5161
01f44d5a
PE
5162 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5163 shadowing.
4f63c6bb 5164 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5165
a6670b0b
PE
5166 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5167 Rename locals to avoid shadowing.
5168
cef2010d 5169 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5170 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5171
d4d7173a
PE
5172 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5173
f08b802a
PE
5174 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5175 warning when compiling print.c.
5176
3ddb0639
PE
5177 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5178 instead of using an uninitialized var.
5ad03b97 5179 (font_sort_entities): Mark var as initialized.
3ddb0639 5180
170a2692
PE
5181 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5182
e663c700
PE
5183 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5184 pointers to constants.
89bc529a 5185 (font_parse_fcname): Remove unused vars.
7b81e2d0 5186 (font_delete_unmatched): Now static.
ea838e10 5187 (font_get_spec): Remove; unused.
13a547c6
PE
5188 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5189 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5190 Rename or move locals to avoid shadowing.
e663c700 5191
2a80c887 5192 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5193 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5194
1384fa33 5195 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5196 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5197
8b2c52e9
PE
5198 * alloc.c (mark_backtrace): Move decl from here ...
5199 * lisp.h: ... to here, so that it can be checked.
5200
475545b5 5201 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5202 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5203 (lisp_indirect_variable): Name an expression,
5204 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5205 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5206
b1349114 5207 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5208 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5209 Use const pointer when appropriate.
b1349114 5210
a2928364
PE
5211 * lisp.h (get_system_name, get_operating_system_release):
5212 Move decls here, to check interfaces.
5213 * process.c (get_operating_system_release): Move decl to lisp.h.
5214 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5215 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5216 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5217 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5218 (Fformat_time_string, Fencode_time, Finsert_char):
5219 (Ftranslate_region_internal, Fformat):
5220 Rename or remove local vars to avoid shadowing.
9710023e 5221 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5222
a415e694
PE
5223 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5224 avoid shadowing.
5225
8ef4622d
PE
5226 * lisp.h (eassert): Check that the argument compiles, even if
5227 ENABLE_CHECKING is not defined.
5228
946f9a5b
PE
5229 * data.c (Findirect_variable): Name an expression, to avoid
5230 gcc -Wbad-function-cast warning.
112396d6 5231 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5232 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5233 (Fmake_variable_buffer_local, Fmake_local_variable):
5234 Mark variables as initialized.
52746918 5235 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5236
e5aab7e7 5237 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5238 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5239 Rename locals to avoid shadowing.
dff45157
PE
5240 (mark_stack): Move local variables into the #ifdef region where
5241 they're used.
7bc26fdb
PE
5242 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5243 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5244 needed otherwise.
5245 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5246 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5247 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5248
e5aab7e7
PE
5249 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5250 avoids undefined behavior in theory.
5251
4da60324
PE
5252 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5253
88043301
PE
5254 Use functions, not macros, for up- and down-casing (Bug#8254).
5255 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5256 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5257 to use the following functions instead of these macros.
5258 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5259 EMACS_INT, since callers assume the returned value fits in int.
5260 (upcase1): Likewise, for UPCASE_TABLE.
5261 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5262 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5263 the race-condition problem in the old DOWNCASE.
88043301 5264
19ed5445
PE
5265 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5266 Rename locals to avoid shadowing.
5267 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5268 (regex_compile, re_search_2, re_match_2_internal):
5269 Remove unused local vars.
952db0d7
PE
5270 (FREE_VAR): Rewrite so as not to use empty "else",
5271 which gcc can warn about.
da053e48 5272 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5273 (RETALLOC_IF): Define only if needed.
5274 (WORDCHAR_P): Likewise. This one is never needed, but is used
5275 only in a comment talking about a compiler bug, so put inside
5276 the #if 0 of that comment.
5277 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5278 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5279 Remove; unused.
19ed5445 5280
1f3561e4 5281 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5282 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5283 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5284
ded6f8f7
PE
5285 * search.c (simple_search): Remove unused var.
5286
dbd37a95
PE
5287 * dired.c (compile_pattern): Move decl from here ...
5288 * lisp.h: ... to here, so that it can be checked.
5289 (struct re_registers): New forward decl.
5290
7e47afad
PE
5291 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5292
85f24f61
PE
5293 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5294 All uses changed.
5295 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5296 Rename locals to avoid shadowing.
5671df8f 5297 (Fvertical_motion): Mark locals as initialized.
85f24f61 5298
181aa2be 5299 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5300 (casify_region): Mark local as initialized.
181aa2be 5301
930d429c
PE
5302 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5303
7082eac6
PE
5304 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5305 New macros, so that the caller can use some names other than
5306 gcpro1, gcpro2, etc.
5307 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5308 of the new macros.
5309 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5310 argument, for consistency with GCPRO2_VAR, etc: it is now the
5311 prefix of the variable, not the variable itself. All uses
5312 changed.
38b2c076
PE
5313 * dired.c (directory_files_internal, file_name_completion):
5314 Rename locals to avoid shadowing.
5315
15206ed9
PE
5316 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5317 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5318 dired.c's scmp function, had undefined behavior.
5319 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5320 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5321 * buffer.h: ... to here, because these macros use current_buffer,
5322 and the new implementation with inline functions needs to have
5323 current_buffer in scope now, rather than later when the macros
5324 are used.
5325 (downcase, upcase1): New static inline functions.
5326 (DOWNCASE, UPCASE1): Reimplement using these functions.
5327 This avoids undefined behavior in expressions like
5328 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5329 from race conditions in accessing the global variables
5330 case_temp1 and case_temp2.
5331 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5332 * lisp.h (case_temp1, case_temp2): Remove their decls.
5333 * character.h (ASCII_CHAR_P): Move from here ...
5334 * lisp.h: ... to here, so that the inline functions mentioned
5335 above can use them.
5336
4a6bea26
PE
5337 * dired.c (directory_files_internal_unwind): Now static.
5338
f14b7e14
PE
5339 * fileio.c (file_name_as_directory, directory_file_name):
5340 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5341 Now static.
2893f146
PE
5342 (file_name_as_directory): Use const pointers when appropriate.
5343 (Fexpand_file_name): Likewise. In particular, newdir might
5344 point at constant storage, so make it a const pointer.
fd4ead52 5345 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5346 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5347 signedness issues.
f839df0c
PE
5348 (Fset_file_times, Finsert_file_contents, auto_save_error):
5349 Rename locals to avoid shadowing.
f14b7e14 5350
5716756e 5351 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5352 (Ftry_completion, Fall_completions): Rename or remove locals
5353 to avoid shadowing.
5716756e 5354
b4c3046a
PE
5355 * marker.c (bytepos_to_charpos): Remove; unused.
5356
b45db522
PE
5357 * lisp.h (verify_bytepos, count_markers): New decls,
5358 so that gcc does not warn that these functions aren't declared.
5359
85876d07
PE
5360 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5361 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5362 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5363 (copy_text): Remove unused local var.
85876d07 5364
03d78a21 5365 * filelock.c (within_one_second): Now static.
b3dd38ab 5366 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5367
5df8f01b
PE
5368 * buffer.c (fix_overlays_before): Mark locals as initialized.
5369 (fix_start_end_in_overlays): Likewise. This function should be
5370 simplified by using pointers-to-pointers, but that's a different
5371 matter.
b1d876f1 5372 (switch_to_buffer_1): Now static.
8f54f30a
PE
5373 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5374 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5375
a70072c9 5376 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5377 Fix pointer signedness issue.
edced198
PE
5378 (sys_subshell): Mark local as volatile if checking for lint,
5379 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5380 (MAXPATHLEN): Define only if needed.
a70072c9 5381
a0977c44
PE
5382 * process.c (serial_open, serial_configure): Move decls from here ...
5383 * systty.h: ... to here, so that they can be checked.
5384
a884fdcc
PE
5385 * fns.c (get_random, seed_random): Move extern decls from here ...
5386 * lisp.h: ... to here, so that they can be checked.
5387
604efe86 5388 * sysdep.c (reset_io): Now static.
b8950c94 5389 (wait_for_termination_signal): Remove; unused.
604efe86 5390
38fc62d9
PE
5391 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5392 (copy_keymap_item, append_key, push_text_char_description):
5393 Now static.
1004a21a 5394 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5395 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5396 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5397 (describe_map_tree):
5398 Rename locals to avoid shadowing.
38fc62d9 5399
2f2650da
PE
5400 * keyboard.c: Declare functions static if they are not used elsewhere.
5401 (echo_char, echo_dash, cmd_error, top_level_2):
5402 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5403 (read_char, kbd_buffer_get_event, make_lispy_position):
5404 (make_lispy_event, make_lispy_movement, apply_modifiers):
5405 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5406 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5407 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5408 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5409 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5410
a053e86c 5411 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5412 (mark_kboards): Move decl here ...
5413 * alloc.c (mark_kboards): ... from here.
a053e86c 5414
4752793e
PE
5415 * lisp.h (force_auto_save_soon): New decl.
5416
74f10ca7 5417 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5418 (DEFINE_DUMMY_FUNCTION): New macro.
5419 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5420 Use it.
c03cd23f
PE
5421 (main): Add casts to avoid warnings
5422 if GCC considers string literals to be constants.
74f10ca7 5423
022e70d4
PE
5424 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5425
59d6fe83
PE
5426 * dbusbind.c: Pointer signedness fixes.
5427 (xd_signature, xd_append_arg, xd_initialize):
5428 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5429 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5430 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5431 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5432
78320123
PE
5433 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5434 if GCC considers string literals to be constants.
49cebcca 5435 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5436
35ac2a97
SM
54372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5438
fb103ca9
SM
5439 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5440 (print_preprocess, print_object): New macro to fix last change.
5441
35ac2a97
SM
5442 * print.c (print_preprocess): Don't forget font objects.
5443
62973b41
JB
54442011-03-16 Juanma Barranquero <lekktu@gmail.com>
5445
5446 * emacs.c (USAGE3): Doc fixes.
5447
0e48bb22
AS
54482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5449
5450 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5451 structure.
5452
7684e57b
JB
54532011-03-14 Juanma Barranquero <lekktu@gmail.com>
5454
5455 * lisp.h (VWindow_system, Qfile_name_history):
5456 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5457 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5458 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5459
5460 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5461 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5462
5463 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5464 * w32console.c (detect_input_pending, read_input_pending)
5465 (encode_terminal_code):
5466 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5467 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5468 (w32_system_caret_y, Qfile_name_history):
5469 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5470 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5471 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5472 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5473 * w32proc.c (Qlocal, report_file_error):
5474 * w32term.c (Vwindow_system, updating_frame):
5475 * w32uniscribe.c (initialized, uniscribe_font_driver):
5476 Remove unneeded extern declarations.
5477
2aa46d6c
CY
54782011-03-14 Chong Yidong <cyd@stupidchicken.com>
5479
c96bbc66 5480 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5481
cffc6f3b
CY
54822011-03-13 Chong Yidong <cyd@stupidchicken.com>
5483
5484 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5485 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5486 These macros can no longer be used for assignment.
5487
44f230aa
SM
5488 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5489 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5490 (record_buffer_markers, fetch_buffer_markers): New functions for
5491 recording and fetching special buffer markers.
5492 (set_buffer_internal_1, set_buffer_temp): Use them.
5493
5494 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5495
5496 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5497
5498 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5499 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5500
5501 * xdisp.c (hscroll_window_tree):
5502 (reconsider_clip_changes): Use PT instead of BUF_PT.
5503
d251f04b
EZ
55042011-03-13 Eli Zaretskii <eliz@gnu.org>
5505
5506 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5507 $(EMACS_ROOT)/lib/intprops.h.
5508
f0c77cd1
PE
55092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5510
3eca4629
PE
5511 Fix more problems found by GCC 4.5.2's static checks.
5512
7c86ee98
PE
5513 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5514 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5515 (xg_free_frame_widgets): Make it clear that a local variable is
5516 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5517 (gdk_window_get_screen): Make it clear that this macro is needed
5518 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5519 (int_gtk_range_get_value): New function, which avoids a diagnostic
5520 from gcc -Wbad-function-cast.
5521 (xg_set_toolkit_scroll_bar_thumb): Use it.
5522 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5523 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5524 (get_utf8_string, xg_get_file_with_chooser):
5525 Rename locals to avoid shadowing.
5526 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5527
41729b81
PE
5528 * xgselect.c (xg_select): Remove unused var.
5529
f0c77cd1
PE
5530 * image.c (four_corners_best): Mark locals as initialized.
5531 (gif_load): Initialize transparent_p to zero (Bug#8238).
5532 Mark another local as initialized.
ec6cf4c6 5533 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5534
ce0ad53d 5535 * image.c (clear_image_cache): Now static.
d5d5a617 5536 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5537 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5538 (x_edge_detection): Remove unnecessary cast that
5539 gcc -Wbad-function-cast diagnoses.
2037898d 5540 (gif_load): Fix pointer signedness.
6ae141d6
PE
5541 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5542 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5543
33383987 55442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5545
d32df629
PE
5546 Improve quality of tests for time stamp overflow.
5547 For example, without this patch (encode-time 0 0 0 1 1
5548 1152921504606846976) returns the obviously-bogus value (-948597
5549 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5550 reports time overflow. See
5551 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5552 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5553 * editfns.c: Include limits.h and intprops.h.
5554 (TIME_T_MIN, TIME_T_MAX): New macros.
5555 (time_overflow): Move earlier, to before first use.
5556 (hi_time, lo_time): New functions, for an accurate test for
5557 out-of-range times.
5558 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5559 (Fget_internal_run_time): Don't assume time_t fits in int.
5560 (make_time): Use list2 instead of Fcons twice.
5561 (Fdecode_time): More accurate test for out-of-range times.
5562 (check_tm_member): New function.
5563 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5564 (lisp_time_argument): Don't rely on undefined left-shift and
5565 right-shift behavior when checking for time stamp overflow.
8be6f318 5566
fe31d94c
PE
5567 * editfns.c (time_overflow): New function, refactoring common code.
5568 (Fformat_time_string, Fdecode_time, Fencode_time):
5569 (Fcurrent_time_string): Use it.
5570
8be6f318
PE
5571 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5572 * dired.c (make_time): Move to ...
5573 * editfns.c (make_time): ... here.
5574 * systime.h: Note the move.
5575
09d9db2c 55762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5577
126bc0dc
YM
5578 * fringe.c (update_window_fringes): Remove unused variables.
5579
c47cbdfd
YM
5580 * unexmacosx.c (copy_data_segment): Also copy __got section.
5581 (Bug#8223)
5582
7ac80be9
EZ
55832011-03-12 Eli Zaretskii <eliz@gnu.org>
5584
c96bbc66 5585 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5586 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5587 Constify `char *' arguments and their references according to
5588 prototypes in tparam.h.
5589
ecb0f94d 5590 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5591
7ac80be9
EZ
5592 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5593 Adapt all references accordingly.
5594
5595 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5596
ef1fd07e
TT
55972011-03-11 Tom Tromey <tromey@redhat.com>
5598
5599 * buffer.c (syms_of_buffer): Remove obsolete comment.
5600
7ef4b50c
EZ
56012011-03-11 Eli Zaretskii <eliz@gnu.org>
5602
5603 * termhooks.h (encode_terminal_code): Declare prototype.
5604
5605 * msdos.c (encode_terminal_code): Don't declare prototype.
5606
5607 * term.c (encode_terminal_code): Now external again, used by
5608 w32console.c and msdos.c.
5609
44f230aa
SM
5610 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5611 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5612
4b1ec863 56132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5614
1714f52b 5615 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5616
4b1ec863
PE
5617 * fringe.c (update_window_fringes): Mark locals as initialized
5618 (Bug#8227).
5619 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5620
524c7aa6
PE
5621 * alloc.c (mark_fringe_data): Move decl from here ...
5622 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5623 to check its interface.
5624 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5625
a5c0af81 5626 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5627 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5628 (fontset_font): Mark local as initialized.
a9a06e0b 5629 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5630
b4716021
PE
5631 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5632
811e9bac 5633 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5634 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5635 (x_own_selection, Fx_disown_selection_internal): Rename locals
5636 to avoid shadowing.
5637 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5638
7e3ab302
PE
5639 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5640 so that the caller can use some name other than gcpro1.
5641 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5642 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5643 (Fx_backspace_delete_keys_p):
5644 Use them to avoid shadowing, and rename vars to avoid shadowing.
5645 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5646 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5647 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5648 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5649 Remove unused locals.
7e3ab302
PE
5650 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5651 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5652 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5653 macros.
f78faa98 5654
e2b13473
PE
5655 * xterm.h (x_mouse_leave): New decl.
5656
77f23912
PE
5657 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5658 Remove unused functions.
cdf4ba58
PE
5659 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5660 (x_calc_absolute_position): Now static.
7411c686 5661 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5662 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5663 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5664 unless they are used.
38d0b34a
PE
5665 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5666 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5667 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5668 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5669 (x_error_catcher, x_connection_closed, x_error_handler):
5670 (x_error_quitter, xembed_send_message, x_iconify_frame):
5671 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5672 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5673 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5674
44f230aa
SM
5675 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5676 Rename or move locals to avoid shadowing.
6b463e58 5677 (tty_defined_color, merge_face_heights): Now static.
5967d051 5678 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5679 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5680 does not deduce is never used uninitialized.
73719eba
PE
5681 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5682 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5683
426994c3 5684 * terminal.c (store_terminal_param): Now static.
5489860b 5685
032f1620 5686 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5687 (set_frame_menubar): Remove unused local.
d4323972 5688 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5689 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5690 since they might point to immutable storage.
281585b0
PE
5691 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5692 since it's unused otherwise.
032f1620 5693
367c19e5 5694 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5695 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5696 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5697 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5698 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5699 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5700 does not deduce are never used uninitialized.
70739cbe 5701
07b48fa9
PE
5702 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5703
8868a238 5704 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5705 * window.c (window_loop, size_window):
5706 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5707
7e5cf297 5708 * window.c (display_buffer): Now static.
d6550a9f
PE
5709 (size_window): Mark variables that gcc -Wuninitialized
5710 does not deduce are never used uninitialized.
a586633d
PE
5711 * window.h (check_all_windows): New decl, to forestall
5712 gcc -Wmissing-prototypes diagnostic.
5b555da1 5713 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5714
f6095868
PE
5715 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5716 shadowing.
5717 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5718 Include <limits.h>.
5719 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5720 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5721 (load_charset_map): Mark variables that gcc -Wuninitialized
5722 does not deduce are never used uninitialized.
53df7c11 5723 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5724
f38b440c
PE
5725 * coding.c (coding_set_source, coding_set_destination):
5726 Use "else { /* comment */ }" rather than "else /* comment */;"
5727 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5728 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5729 a block, when the outer 'i' will do.
5730 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5731 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5732 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5733 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5734 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5735 Rename locals to avoid shadowing.
5736 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5737 * coding.c (emacs_mule_char, encode_invocation_designation):
5738 Now static, since they're not used elsewhere.
413bb2db 5739 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5740 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5741 (decode_coding_emacs_mule): Mark variables that gcc
5742 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5743 (detect_coding_iso_2022): Initialize a local variable that might
5744 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5745 this initialization is needed. (Bug#8211)
5f58e762
PE
5746 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5747 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5748 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5749 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5750 Remove unused macros.
f38b440c 5751
232b38b9 5752 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5753 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5754 * character.c (string_count_byte8): Likewise.
232b38b9 5755
fb90da1b
PE
5756 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5757 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5758
fb93dbc2
PE
5759 * chartab.c (copy_sub_char_table): Now static, since it's not used
5760 elsewhere.
5c156ace
PE
5761 (sub_char_table_ref_and_range, char_table_ref_and_range):
5762 Rename locals to avoid shadowing.
bbcd0949 5763 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5764
7d3b3862 5765 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5766 (BIDI_BOB): Remove unused macro.
7d3b3862 5767
6be7d3da
PE
5768 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5769 deduce are never used uninitialized.
c2ed9c8b 5770 * term.c (encode_terminal_code): Likewise.
6be7d3da 5771
75f8807f 5772 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5773
50938595
PE
5774 * tparam.h: New file.
5775 * term.c, tparam.h: Include it.
5776 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5777 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5778 Move these decls to tparam.h, and make them agree with what
5779 is actually in tparam.c. The previous trick of using incompatible
5780 decls in different modules does not conform to the C standard.
5781 All callers of tparam changed to use tparam's actual API.
5782 * tparam.c (tparam1, tparam, tgoto):
5783 Use const pointers where appropriate.
5784
fbceeba2
PE
5785 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5786 * cm.h (struct cm): Likewise.
5787 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5788 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5789 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5790 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5791 (turn_on_face, init_tty): Likewise.
5792 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5793
7f3f1250
PE
5794 * term.c (term_mouse_position): Rename local to avoid shadowing.
5795
e6ca6543
PE
5796 * alloc.c (mark_ttys): Move decl from here ...
5797 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5798
c40f8d15
AS
57992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5800
5801 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5802
cfe0661d
JB
58032011-03-09 Juanma Barranquero <lekktu@gmail.com>
5804
5805 * search.c (compile_pattern_1): Remove argument regp, unused since
5806 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5807 (compile_pattern): Don't pass it.
5808
0afb4571
J
58092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5810
5811 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5812 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5813 for ! HAVE_GTK3.
5814 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5815
5816 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5817
5818 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5819 gdk_window_get_screen, gdk_window_get_geometry,
5820 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5821 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5822 (xg_get_pixbuf_from_pixmap): New function.
5823 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5824 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5825 Call xg_get_pixbuf_from_pixmap instead of
5826 gdk_pixbuf_get_from_drawable.
5827 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5828 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5829 (xg_check_special_colors): Use GtkStyleContext and its functions
5830 for HAVE_GTK3.
5831 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5832 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5833 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5834 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5835 Call gtk_widget_get_preferred_size.
0afb4571
J
5836 (xg_frame_resized): gdk_window_get_geometry only takes 5
5837 parameters.
44f230aa
SM
5838 (xg_win_to_widget, xg_event_is_for_menubar):
5839 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5840 (xg_set_widget_bg): New function.
5841 (delete_cb): New function.
895009e1 5842 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5843 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5844 (xg_set_background_color): Call xg_set_widget_bg.
5845 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5846 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5847 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5848 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5849 if ! HAVE_GTK3.
5850 (update_frame_tool_bar): Call gtk_widget_hide.
5851 (xg_initialize): Use GDK_KEY_g.
5852
5853 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5854 if ! HAVE_GTK3
5855 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5856
5857 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5858 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5859 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5860
1c2cc4ef
JB
58612011-03-08 Juanma Barranquero <lekktu@gmail.com>
5862
5863 * w32xfns.c (select_palette): Check success of RealizePalette against
5864 GDI_ERROR, not zero.
5865
33383987 5866See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5867
5868;; Local Variables:
5869;; coding: utf-8
aac0c6e3
MR
5870;; End:
5871
33383987 5872 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5873
5874 This file is part of GNU Emacs.
5875
5876 GNU Emacs is free software: you can redistribute it and/or modify
5877 it under the terms of the GNU General Public License as published by
5878 the Free Software Foundation, either version 3 of the License, or
5879 (at your option) any later version.
5880
5881 GNU Emacs is distributed in the hope that it will be useful,
5882 but WITHOUT ANY WARRANTY; without even the implied warranty of
5883 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5884 GNU General Public License for more details.
5885
5886 You should have received a copy of the GNU General Public License
5887 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.